1 2004-11-25 Martin Baulig <martin@ximian.com>
3 * expression.cs (Invocation.InferType): Added support for byref types.
5 2004-11-25 Martin Baulig <martin@ximian.com>
7 * statement.cs (Foreach.FetchMethodMoveNext): Wrap `mi.ReturnType'
8 in TypeManager.TypeToCoreType().
10 2004-11-25 Martin Baulig <martin@ximian.com>
12 * iterators.cs (Iterator.DoDefineMembers): Override and lookup the
13 "Dispose" method from the `current_type'.
14 (Iterator.EmitMoveNext): Use the `dispose_method' we looked up in
15 DoDefineMembers() instead of using the MethodBuilder; this is
16 required for generic iterators.
18 * class.cs (TypeContainer.DoDefineMembers): Make this virtual.
20 2004-11-24 Martin Baulig <martin@ximian.com>
22 * ecore.cs (Expression.LoadFromPtr): Use `ldobj' for generic parameters.
24 2004-11-20 Martin Baulig <martin@ximian.com>
26 * expression.cs (Invocation.InferType): Correctly infer generic
27 instances; see gen-103.cs.
28 (Invocation.InferTypeArguments): If a generic method doesn't have
29 any unbound type parameters, we don't need to infer anything.
31 2004-11-19 Raja R Harinath <rharinath@novell.com>
33 * Makefile (gmcs.exe): Update to new location of bootstrap mcs.exe.
35 2004-11-17 Raja R Harinath <rharinath@novell.com>
37 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
38 (TypeHandle.GetMemberCache): New.
39 (TypeHandle.TypeHandle): Update.
40 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
41 (TypeManager.LookupParentInterfacesCache):
42 Rename from LookupInterfaceCache. Optimize slightly.
43 (TypeManager.MemberLookup_FindMembers): Update.
44 * decl.cs (MemberCache.MemberCache): Set Container to null in the
46 (AddCacheContents): Rename from AddHashtable.
47 * class.cs (TypeContainer.parent_container): Remove.
48 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
49 (TypeContainer.DoDefineMembers): Don't initialize it.
50 Update to name changes.
52 2004-11-17 Miguel de Icaza <miguel@ximian.com>
54 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
55 that factors the code to check access modifiers on override.
57 (PropertyBase): Use the code here.
59 Patch from Lluis S'anchez, fixes bug #69361.
61 2004-11-15 Miguel de Icaza <miguel@ximian.com>
63 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
64 routine that is used to report the use of a captured variable
65 whose address has been taken.
67 There are two checks: one when variables are being captured and
68 the other check is when the address of a variable is taken.
70 (because an anonymous methods might be resolved before *or* after
71 the address has been taken) and
73 * expression.cs (Conditional.DoResolve): Remove the special
74 casing that Martin added to trueExpr and falseExpr being both
75 NullLiteral. We get the right behavior now just by introducing
76 the null_type into the compiler.
78 * convert.cs (ExplicitConversion): Change the code to use
79 null_type instead of testing `expr is NullLiteral'.
80 (ImplicitConversionStandard): use null_type too.
81 (ImplicitReferenceConversionExists): use null_type too.
82 (ImplicitReferenceConversion): use null_type too.
84 * literal.cs: The type of `NullLiteral' is now null_type instead
86 (Resolve): Set the type here.
88 * typemanager.cs: Introduce null_type.
90 2004-11-18 Martin Baulig <martin@ximian.com>
93 (RootContext.LookupType): Return a `Type', not a `TypeExpr'.
95 2004-11-18 Martin Baulig <martin@ximian.com>
97 * ecore.cs (TypeExpr.DoResolveAsTypeStep): Make this protected.
99 2004-11-18 Martin Baulig <martin@ximian.com>
101 * generic.cs (Constraints.Resolve): Take an `EmitContext' instead
102 of a `DeclSpace'. If one of our constraints is a `ConstructedType',
103 call ResolveConstructedType() on it to resolve it without checking
105 (Constraints.ResolveTypes): Check them here.
106 (ConstructedType.DoResolveAsTypeStep): Fully resolve ourselves,
107 but don't check constraints.
108 (ConstructedType.ResolveAsTypeTerminal): Override this and also
109 check constraints here.
110 (ConstructedType.ResolveConstructedType): New public method. This
111 is called from DoResolveAsTypeStep() and Constraints.Resolve() to
112 resolve ourselves without checking constraints.
114 * ecore.cs (Expression.ResolveAsTypeTerminal): Make this virtual.
116 2004-11-18 Martin Baulig <martin@ximian.com>
119 (DeclSpace.CurrentType): Changed type from `TypeExpr' to `Type'.
121 * delegate.cs (Delegate.DefineType): Always create the EmitContext.
123 2004-11-18 Martin Baulig <martin@ximian.com>
125 * ecore.cs (TypeExpr.ResolveType): Removed.
126 (Expression.ResolveAsTypeTerminal): We always return a fully
127 resolved `TypeExpr', so we can just access its `Type'.
129 * class.cs (TypeContainer.DefineType): Resolve `CurrentType' here.
131 2004-11-17 Martin Baulig <martin@ximian.com>
133 * ecore.cs (IAlias.Type): Replaced with ResolveAsType() to make
134 sure we don't return any unresolved TypeExpr's.
135 (TypeAliasExpression): The .ctor now takes an `IAlias' instead of
137 (Expression.ResolveAsTypeTerminal): Make sure `te.Type != null'.
139 * expression.cs (MemberAccess.ResolveAsTypeStep): Don't return any
140 unresolved `ConstructedType's.
142 2004-11-17 Martin Baulig <martin@ximian.com>
144 * ecore.cs (TypeExpr.ResolveType): Don't make this virtual.
146 2004-11-17 Martin Baulig <martin@ximian.com>
149 (Expression.ResolveAsTypeTerminal): Removed the `bool silent' argument.
151 * decl.cs (DeclSpace.ResolveType): Removed.
152 (DeclSpace.ResolveTypeExpr): Removed the `bool silent' argument.
154 2004-11-17 Martin Baulig <martin@ximian.com>
156 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
157 direction, like FindMembers() does. Fixes #69546, testcase is in
160 2004-11-16 Martin Baulig <martin@ximian.com>
162 This is based on a patch from Marek Safar, see bug #69082.
163 Fixes bugs #63705 and #67130.
165 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
166 method; create a MemberCache for an interface type and cache the
169 * decl.cs (IMemberContainer.ParentContainer): Removed.
170 (IMemberContainer.ParentCache): New property.
171 (MemberCache.SetupCacheForInterface): Removed.
172 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
173 to create a cache for an interface's "parent".
175 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
178 2004-11-14 Ben Maurer <bmaurer@ximian.com>
180 * statement.cs: Avoid adding bools to a hashtable.
182 2004-11-15 Martin Baulig <martin@ximian.com>
184 * decl.cs (MemberName.GetPartialName): Removed, use GetTypeName() instead.
186 2004-11-11 Martin Baulig <martin@ximian.com>
188 * typemanager.cs (TypeManager.GetMethodName): New method.
190 * class.cs (MethodData.Define): Include the generic arity in the
191 name of an explicit interface; also add it to the method name.
193 * pending.cs (PendingImplementation.InterfaceMethod): The method
194 name now includes the generic arity.
196 2004-11-07 Miguel de Icaza <miguel@ximian.com>
198 * expression.cs (Invocation.OverloadResolve): Flag error if we are
199 calling an unsafe method from a safe location.
201 2004-11-06 Marek Safar <marek.safar@seznam.cz>
204 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
206 2004-11-06 Miguel de Icaza <miguel@ximian.com>
208 * namespace.cs (VerifyUsing): use GetPartialName instead of
211 2004-11-05 Miguel de Icaza <miguel@ximian.com>
213 * statement.cs (Return.Resolve): Fix regression in typo: if
214 `in_exc', we have to request a NeedReturnLabel, this was a typo
215 introduced in the anonymous method check-in. Fixes #69131.
217 * Indexers were using the ShortName when defining themselves,
218 causing a regression in the compiler bootstrap when applying the
219 patch from 2004-11-02 (first part), now they use their full name
222 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
224 * driver.cs: Strip the path from the names of embedded resources. Fixes
227 2004-11-04 Raja R Harinath <rharinath@novell.com>
229 Fix error message regression: cs0104-2.cs.
230 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
231 (AliasEntry.Resolve): Update.
232 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
234 (RootContext.LookupType): Update.
236 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
238 * cs-parser.jay: Add support for handling accessor modifiers
239 * class: Add support port accessor modifiers and error checking,
240 define PropertyMethod.Define as virtual (not abstract anymore)
241 * ecore.cs: Add checking for proeprties access with access modifiers
242 * iterators.cs: Modify Accessor constructor call based in the modified
244 2004-11-02 Ben Maurer <bmaurer@ximian.com>
246 * expression.cs (StringConcat): Handle being called twice,
247 as when we have a concat in a field init with more than two
250 2004-11-02 Miguel de Icaza <miguel@ximian.com>
252 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
253 special case explicit implementations, we should always produce
254 the .property or .event declaration.
256 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
257 since it will not return correct data if people use this
258 unresolved in the presence of using statements (see test-313).
260 * class.cs (MethodData.Define): If we are an explicit interface
261 implementation, set the method name to the full name of the
262 interface plus the name of the method.
264 Notice that using the method.MethodName.GetFullName() does not
265 work, as it will only contain the name as declared on the source
266 file (it can be a shorthand in the presence of using statements)
267 and not the fully qualifed type name, for example:
271 class D : ICloneable {
272 object ICloneable.Clone () {
276 Would produce a method called `ICloneable.Clone' instead of
277 `System.ICloneable.Clone'.
279 * namespace.cs (Alias.Resolve): Use GetPartialName.
281 2004-11-01 Marek Safar <marek.safar@seznam.cz>
283 * cs-parser.jay: Add error 1055 report.
285 2004-11-01 Miguel de Icaza <miguel@ximian.com>
287 * assign.cs (Assign.DoResolve): Only do the transform of
288 assignment into a New if the types are compatible, if not, fall
289 through and let the implicit code deal with the errors and with
290 the necessary conversions.
292 2004-11-01 Marek Safar <marek.safar@seznam.cz>
294 * cs-parser.jay: Add error 1031 report.
296 * cs-tokenizer.cs: Add location for error 1038.
298 2004-10-31 Marek Safar <marek.safar@seznam.cz>
300 * cs-parser.jay: Add error 1016 report.
302 2004-10-31 Marek Safar <marek.safar@seznam.cz>
304 * cs-parser.jay: Add errors 1575,1611 report.
306 2004-10-31 Marek Safar <marek.safar@seznam.cz>
308 * cs-parser.jay: Add error 1001 report.
310 2004-10-31 Marek Safar <marek.safar@seznam.cz>
313 * attribute.cs (GetMarshal): Add method argument for
314 caller identification.
316 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
317 agument for GetMarshal and RuntimeMissingSupport.
319 2004-10-31 Marek Safar <marek.safar@seznam.cz>
321 * attribute.cs (ExtractSecurityPermissionSet): Removed
322 TypeManager.code_access_permission_type.
324 * typemanager.cs: Removed TypeManager.code_access_permission_type.
326 2004-10-27 Miguel de Icaza <miguel@ximian.com>
328 * expression.cs (LocalVariableReference.DoResolveLValue): Check
329 for obsolete use of a variable here. Fixes regression on errors
330 cs0619-25 and cs0619-26.
332 2004-10-27 Marek Safar <marek.safar@seznam.cz>
334 Fix #62358, implemented security attribute encoding.
336 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
337 Tests permitted SecurityAction for assembly or other types.
338 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
339 data from SecurityPermissionAttribute to PermisionSet class.
341 * class.cs (ApplyAttributeBuilder): Added special handling
342 for System.Security.Permissions.SecurityAttribute based types.
344 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
345 special handling for System.Security.Permissions.SecurityAttribute
348 * enum.cs (ApplyAttributeBuilder): Added special handling
349 for System.Security.Permissions.SecurityAttribute based types.
351 * parameter.cs (ApplyAttributeBuilder): Added special handling
352 for System.Security.Permissions.SecurityAttribute based types.
354 * rootcontext.cs: Next 2 core types.
356 * typemanager.cs (TypeManager.security_permission_attr_type):
357 Built in type for the SecurityPermission Attribute.
358 (code_access_permission_type): Build in type.
360 2004-10-17 Miguel de Icaza <miguel@ximian.com>
362 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
363 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
364 all of this information into
365 EmitContext.EmitCapturedVariableInstance.
367 * codegen.cs (EmitCapturedVariableInstance): move here the
368 funcionality of emitting an ldarg.0 in the presence of a
369 remapping. This centralizes the instance emit code.
371 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
372 then emit a load of this: it means that we have reached the
373 topmost ScopeInfo: the one that contains the pointer to the
374 instance of the class hosting the anonymous method.
376 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
377 captures to the topmost CaptureContext.
379 2004-10-12 Miguel de Icaza <miguel@ximian.com>
381 * expression.cs (LocalVariableReference): Move the knowledge about
382 the iterators into codegen's EmitCapturedVariableInstance.
384 2004-10-11 Miguel de Icaza <miguel@ximian.com>
386 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
387 all code paths return a value from an anonymous method (it is the
388 same as the 161 error, but for anonymous methods).
390 2004-10-08 Miguel de Icaza <miguel@ximian.com>
392 The introduction of anonymous methods in the compiler changed
393 various ways of doing things in the compiler. The most
394 significant one is the hard split between the resolution phase
395 and the emission phases of the compiler.
397 For instance, routines that referenced local variables no
398 longer can safely create temporary variables during the
399 resolution phase: they must do so from the emission phase,
400 since the variable might have been "captured", hence access to
401 it can not be done with the local-variable operations from the runtime.
405 (Block.Flags): New flag `IsTopLevel' to indicate that this block
408 (ToplevelBlock): A new kind of Block, these are the blocks that
409 are created by the parser for all toplevel method bodies. These
410 include methods, accessors and anonymous methods.
412 These contain some extra information not found in regular blocks:
413 A pointer to an optional CaptureContext (for tracking captured
414 local variables and parameters). A pointer to the parent
417 (Return.Resolve): Catch missmatches when returning a value from an
418 anonymous method (error 1662).
419 Invoke NeedReturnLabel from the Resolve phase instead of the emit
422 (Break.Resolve): ditto.
424 (SwitchLabel): instead of defining the labels during the
425 resolution phase, we now turned the public ILLabel and ILLabelCode
426 labels into methods called GetILLabelCode() and GetILLabel() that
427 only define the label during the Emit phase.
429 (GotoCase): Track the SwitchLabel instead of the computed label
430 (its contained therein). Emit the code by using
431 SwitchLabel.GetILLabelCode ().
433 (LocalInfo.Flags.Captured): A new flag has been introduce to track
434 whether the Local has been captured or not.
436 (LocalInfo.IsCaptured): New property, used to tell whether the
437 local has been captured.
439 * anonymous.cs: Vastly updated to contain the anonymous method
442 The main classes here are: CaptureContext which tracks any
443 captured information for a toplevel block and ScopeInfo used to
444 track the activation frames for various local variables.
446 Each toplevel block has an optional capture context associated
447 with it. When a method contains an anonymous method both the
448 toplevel method and the anonymous method will create a capture
449 context. When variables or parameters are captured, they are
450 recorded on the CaptureContext that owns them, for example:
454 MyDelegate d = delegate {
459 Here `a' will be recorded as captured on the toplevel
460 CapturedContext, the inner captured context will not have anything
461 (it will only have data if local variables or parameters from it
462 are captured in a nested anonymous method.
464 The ScopeInfo is used to track the activation frames for local
465 variables, for example:
467 for (int i = 0; i < 10; i++)
468 for (int j = 0; j < 10; j++){
469 MyDelegate d = delegate {
474 At runtime this captures a single captured variable `i', but it
475 captures 10 different versions of the variable `j'. The variable
476 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
479 The toplevel ScopeInfo will also track information like the `this'
480 pointer if instance variables were referenced (this is necessary
481 as the anonymous method lives inside a nested class in the host
484 (AnonymousMethod): Expanded to track the Toplevel, implement
485 `AnonymousMethod.Compatible' to tell whether an anonymous method
486 can be converted to a target delegate type.
488 The routine now also produces the anonymous method content
490 (AnonymousDelegate): A helper class that derives from
491 DelegateCreation, this is used to generate the code necessary to
492 produce the delegate for the anonymous method that was created.
494 * assign.cs: API adjustments for new changes in
495 Convert.ImplicitStandardConversionExists.
497 * class.cs: Adjustments to cope with the fact that now toplevel
498 blocks are of type `ToplevelBlock'.
500 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
501 insteda of standard blocks.
503 Flag errors if params arguments are passed to anonymous methods.
505 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
506 `CurrentAnonymousMethod' which points to the current Anonymous
507 Method. The variable points to the AnonymousMethod class that
508 holds the code being compiled. It is set in the new EmitContext
509 created for the anonymous method.
511 (EmitContext.Phase): Introduce a variable and an enumeration to
512 assist in enforcing some rules about when and where we are allowed
513 to invoke certain methods (EmitContext.NeedsReturnLabel is the
514 only one that enfonces this right now).
516 (EmitContext.HaveCaptureInfo): new helper method that returns
517 whether we have a CapturedContext initialized.
519 (EmitContext.CaptureVariable): New method used to register that a
520 LocalInfo must be flagged for capturing.
522 (EmitContext.CapturedParameter): New method used to register that a
523 parameters must be flagged for capturing.
525 (EmitContext.CapturedField): New method used to register that a
526 field must be flagged for capturing.
528 (EmitContext.HaveCapturedVariables,
529 EmitContext.HaveCapturedFields): Return whether there are captured
532 (EmitContext.EmitMethodHostInstance): This is used to emit the
533 instance for the anonymous method. The instance might be null
534 (static methods), this (for anonymous methods that capture nothing
535 and happen to live side-by-side with the current method body) or a
536 more complicated expression if the method has a CaptureContext.
538 (EmitContext.EmitTopBlock): Routine that drives the emission of
539 code: it will first resolve the top block, then emit any metadata
540 and then emit the code. The split is done so that we can extract
541 any anonymous methods and flag any captured variables/parameters.
543 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
544 during this phase, the ILGenerator should not be used as labels
545 and local variables declared here might not be accessible to any
546 code that is part of an anonymous method.
548 Exceptions to this include the temporary variables that are
549 created by some statements internally for holding temporary
552 (EmitContext.EmitMeta): New routine, in charge of emitting all the
555 (EmitContext.TemporaryReturn): This method is typically called
556 from the Emit phase, and its the only place where we allow the
557 ReturnLabel to be defined other than the EmitMeta. The reason is
558 that otherwise we would have to duplicate a lot of logic in the
559 Resolve phases of various methods that today is on the Emit
562 (EmitContext.NeedReturnLabel): This no longer creates the label,
563 as the ILGenerator is not valid during the resolve phase.
565 (EmitContext.EmitThis): Extended the knowledge in this class to
566 work in anonymous methods in addition to iterators.
568 (EmitContext.EmitCapturedVariableInstance): This emits whatever
569 code is necessary on the stack to access the instance to a local
570 variable (the variable will be accessed as a field).
572 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
573 EmitContext.EmitAddressOfParameter): Routines to support
574 parameters (not completed at this point).
576 Removals: Removed RemapLocal and RemapLocalLValue. We probably
577 will also remove the parameters.
579 * convert.cs (Convert): Define a `ConstantEC' which points to a
580 null. This is just to prefity some code that uses
581 ImplicitStandardConversion code and do not have an EmitContext
584 The idea is to flag explicitly that at that point in time, it is
585 known that the conversion will not trigger the delegate checking
586 code in implicit conversions (which requires a valid
589 Everywhere: pass new EmitContext parameter since
590 ImplicitStandardConversionExists now requires it to check for
591 anonymous method conversions.
593 (Convert.ImplicitStandardConversionExists): If the type of an
594 expression is the anonymous_method_type, and the type is a
595 delegate, we invoke the AnonymousMethod.Compatible method to check
596 whether an implicit conversion is possible.
598 (Convert.ImplicitConversionStandard): Only do implicit method
599 group conversions if the language level is not ISO_1.
601 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
602 MethodInfo for the Invoke method. used by Delegate and
605 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
606 method conversions if the target type is a delegate.
608 Removed extra debugging nops.
610 (LocalVariableReference): Turn the `local_info' into a public
613 Add `prepared' field, the same hack used for FieldExprs to cope
614 with composed assignments, as Local variables do not necessarily
615 operate purely on the stack as they used to: they can be captured
618 Add `temp' for a temporary result, like fields.
620 Refactor DoResolve and DoResolveLValue into DoResolveBase.
622 It now copes with Local variables that are captured and emits the
623 proper instance variable to load it from a field in the captured
626 (ParameterReference.DoResolveBase): During the resolve phase,
627 capture parameters if we are in an anonymous method.
629 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
630 anonymous method, use the EmitContext helper routines to emit the
633 * iterators.cs: Set RemapToProxy to true/false during the
636 * parameters.cs (GetParameterByName): New helper method.
638 * typemanager.cs (anonymous_method_type) a new type that
639 represents an anonyous method. This is always an internal type,
640 used as a fencepost to test against the anonymous-methodness of an
643 2004-10-20 Marek Safar <marek.safar@seznam.cz>
645 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
647 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
649 2004-11-10 Martin Baulig <martin@ximian.com>
651 * expression.cs (Invocation.BetterFunction): If two methods have
652 equal parameter types, but only one of them is generic, the
653 non-generic one wins.
654 (New.DoResolve): Don't set `is_struct' to false if we're a generic
655 instance; just use `Type.IsValueType' to determine whether
656 something is a struct or not.
657 (MemberAccess.DoResolveAsTypeStep): Don't modify the `args' field,
658 so we can be called multiple times.
660 2004-11-10 Martin Baulig <martin@ximian.com>
662 * generic.cs (TypeParameter.DefineConstraints): New public method.
663 (TypeParameter.CheckAccessLevel): Override this and return true.
664 (ConstructedType.ResolveType): Renamed to DoResolveType(), don't
665 override ResolveType() anymore.
666 (ConstructedType.DoResolveAsTypeStep): Call DoResolveType() here.
668 2004-11-10 Martin Baulig <martin@ximian.com>
670 * rootcontext.cs (RootContext.LookupType): If we're a nested type,
671 call DeclSpace.ResolveNestedType() on it.
673 2004-11-10 Martin Baulig <martin@ximian.com>
675 * support.cs (ReflectionParameters.ParameterModifier): If `gpd' is
676 non-null, call ParameterModifier() on it.
678 2004-11-10 Martin Baulig <martin@ximian.com>
681 (Iterators): Added `current_type' and `this_type' fields.
682 (Iterators.DefineIterator): Create a new EmitContext and store it
683 in `ec'; compute `this_type'.
685 2004-11-10 Martin Baulig <martin@ximian.com>
688 (TypeManager.IsPrivateAccessible): New public method.
689 (Closure.Filter): Use IsPrivateAccessible() instead of IsEqual().
691 2004-11-10 Martin Baulig <martin@ximian.com>
693 * class.cs (TypeContainer.DefineType): Call
694 TypeBuilder.DefineGenericParameters() before resolving the type
696 (MethodData.parent_method): New protected field.
697 (MethodData..ctor): Added `MethodInfo parent_method' argument.
698 (MethodData.Define): Compute `parent_method'.
701 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
702 (MemberCore.GetClsCompliantAttributeValue): Likewise.
703 (DeclSpace.ec): New protected field; store the EmitContext here.
704 (DeclSpace.EmitContext): New public property.
705 (DeclSpace.ResolveType): Un-comment from the [Obsolte] attribute.
706 (DeclSpace.ResolveNestedType): New public method.
707 (DeclSpace.ResolveTypeExpr): Just call ResolveAsTypeTerminal() here.
708 (DeclSpace.NestedAccessible): Added `Type tb' argument.
709 (DeclSpace.FamilyAccessible): Likewise.
710 (DeclSpace.FindType): Call ResolveNestedType() for nested types.
711 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
714 * delegate.cs (Delegate.Define): Store the EmitContext in the `ec'
717 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
718 (Enum.Emit): Don't create a new EmitContext.
720 2004-10-18 Martin Baulig <martin@ximian.com>
722 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
723 `Type' directly, but call ResolveType() on it.
724 (Catch.Resolve): Likewise.
725 (Foreach.Resolve): Likewise.
727 2004-10-18 Martin Baulig <martin@ximian.com>
729 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
730 `Type' directly, but call ResolveType() on it.
731 (Probe.DoResolve): Likewise.
732 (ArrayCreation.LookupType): Likewise.
733 (TypeOf.DoResolve): Likewise.
734 (SizeOf.DoResolve): Likewise.
736 2004-10-18 Raja R Harinath <rharinath@novell.com>
738 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
741 2004-10-17 John Luke <john.luke@gmail.com>
743 * class.cs (Operator.GetSignatureForError): use CSharpName
745 * parameter.cs (Parameter.GetSignatureForError): Returns
746 correct name even if was not defined.
748 2004-10-13 Raja R Harinath <rharinath@novell.com>
751 * class.cs (TypeContainer.EmitContext): New property.
752 (DefineNestedTypes): Create an emitcontext for each part.
753 (MethodCore.DoDefineParameters): Use container's emitcontext.
754 Pass type array to InternalParameters.
755 (MemberBase.DoDefine): Use container's emitcontext.
756 (FieldMember.Define): Likewise.
757 (Event.Define): Likewise.
758 (SetMethod.GetParameterInfo): Change argument to EmitContext.
759 Pass type array to InternalParameters.
760 (SetIndexerMethod.GetParameterInfo): Likewise.
761 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
762 * delegate.cs (Define): Pass emitcontext to
763 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
764 array to InternalParameters.
765 * expression.cs (ParameterReference.DoResolveBase): Pass
766 emitcontext to GetParameterInfo.
767 (ComposedCast.DoResolveAsTypeStep): Remove check on
768 ec.ResolvingTypeTree.
769 * parameter.cs (Parameter.Resolve): Change argument to
770 EmitContext. Use ResolveAsTypeTerminal.
771 (Parameter.GetSignature): Change argument to EmitContext.
772 (Parameters.ComputeSignature): Likewise.
773 (Parameters.ComputeParameterTypes): Likewise.
774 (Parameters.GetParameterInfo): Likewise.
775 (Parameters.ComputeAndDefineParameterTypes): Likewise.
776 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
777 * support.cs (InternalParameters..ctor): Remove variant that takes
779 * typemanager.cs (system_intptr_expr): New.
780 (InitExpressionTypes): Initialize it.
782 2004-10-12 Chris Toshok <toshok@ximian.com>
784 * cs-parser.jay: fix location for try_statement and catch_clause.
786 2004-10-18 Martin Baulig <martin@ximian.com>
788 * class.cs (FieldMember.Define): Don't access the TypeExpr's
789 `Type' directly, but call ResolveType() on it.
790 (MemberBase.DoDefine): Likewise.
792 * expression.cs (New.DoResolve): Don't access the TypeExpr's
793 `Type' directly, but call ResolveType() on it.
794 (ComposedCast.DoResolveAsTypeStep): Likewise.
796 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
797 `Type' directly, but call ResolveType() on it.
799 2004-10-17 John Luke <john.luke@gmail.com>
801 * class.cs (Operator.GetSignatureForError): use CSharpName
803 * parameter.cs (Parameter.GetSignatureForError): Returns
804 correct name even if was not defined.
806 2004-10-13 Raja R Harinath <rharinath@novell.com>
809 * class.cs (TypeContainer.EmitContext): New property.
810 (DefineNestedTypes): Create an emitcontext for each part.
811 (MethodCore.DoDefineParameters): Use container's emitcontext.
812 Pass type array to InternalParameters.
813 (MemberBase.DoDefine): Use container's emitcontext.
814 (FieldMember.Define): Likewise.
815 (Event.Define): Likewise.
816 (SetMethod.GetParameterInfo): Change argument to EmitContext.
817 Pass type array to InternalParameters.
818 (SetIndexerMethod.GetParameterInfo): Likewise.
819 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
820 * delegate.cs (Define): Pass emitcontext to
821 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
822 array to InternalParameters.
823 * expression.cs (ParameterReference.DoResolveBase): Pass
824 emitcontext to GetParameterInfo.
825 (ComposedCast.DoResolveAsTypeStep): Remove check on
826 ec.ResolvingTypeTree.
827 * parameter.cs (Parameter.Resolve): Change argument to
828 EmitContext. Use ResolveAsTypeTerminal.
829 (Parameter.GetSignature): Change argument to EmitContext.
830 (Parameters.ComputeSignature): Likewise.
831 (Parameters.ComputeParameterTypes): Likewise.
832 (Parameters.GetParameterInfo): Likewise.
833 (Parameters.ComputeAndDefineParameterTypes): Likewise.
834 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
835 * support.cs (InternalParameters..ctor): Remove variant that takes
837 * typemanager.cs (system_intptr_expr): New.
838 (InitExpressionTypes): Initialize it.
840 2004-10-12 Chris Toshok <toshok@ximian.com>
842 * cs-parser.jay: fix location for try_statement and catch_clause.
844 2004-10-07 Raja R Harinath <rharinath@novell.com>
846 More DeclSpace.ResolveType avoidance.
847 * decl.cs (MemberCore.InUnsafe): New property.
848 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
849 with newly created EmitContext.
850 (FieldMember.Define): Likewise.
851 * delegate.cs (Delegate.Define): Likewise.
852 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
853 only if normal name-lookup fails.
854 (TypeExpr.DoResolve): Enable error-checking.
855 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
856 (SizeOf.DoResolve): Likewise.
857 (ComposedCast.DoResolveAsTypeStep): Likewise.
858 (StackAlloc.DoResolve): Likewise.
859 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
860 (Block.Unsafe): New property.
861 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
862 (Unsafe): Set 'unsafe' flag of contained block.
863 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
864 (Fixed.Resolve): Likewise.
865 (Catch.Resolve): Likewise.
866 (Using.ResolveLocalVariableDecls): Likewise.
867 (Foreach.Resolve): Likewise.
869 2004-10-05 John Luke <john.luke@gmail.com>
871 * cs-parser.jay: add location to error CS0175
873 2004-10-04 Miguel de Icaza <miguel@ximian.com>
875 * ecore.cs (Expression.Constantity): Add support for turning null
878 * const.cs (Const.Define): Allow constants to be reference types
879 as long as the value is Null.
881 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
883 * namespace.cs (NamespaceEntry.Using): No matter which warning
884 level is set, check if this namespace name has already been added.
886 2004-10-03 Ben Maurer <bmaurer@ximian.com>
888 * expression.cs: reftype [!=]= null should always use br[true,false].
891 2004-10-03 Marek Safar <marek.safar@seznam.cz>
894 * attribute.cs: Enum conversion moved to
895 GetAttributeArgumentExpression to be applied to the all
898 2004-10-01 Raja R Harinath <rharinath@novell.com>
900 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
901 * class.c (TypeContainer.DefineType): Flag error if
902 base types aren't accessible due to access permissions.
903 * decl.cs (DeclSpace.ResolveType): Move logic to
904 Expression.ResolveAsTypeTerminal.
905 (DeclSpace.ResolveTypeExpr): Thin layer over
906 Expression.ResolveAsTypeTerminal.
907 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
908 Refactor code into NestedAccess. Use it.
909 (DeclSpace.NestedAccess): New.
910 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
911 argument to silence errors. Check access permissions.
912 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
913 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
914 (Cast.DoResolve): Likewise.
915 (New.DoResolve): Likewise.
916 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
917 (TypeOf.DoResolve): Likewise.
919 * expression.cs (Invocation.BetterConversion): Return the Type of
920 the better conversion. Implement section 14.4.2.3 more faithfully.
921 (Invocation.BetterFunction): Make boolean. Make correspondence to
922 section 14.4.2.2 explicit.
923 (Invocation.OverloadResolve): Update.
924 (Invocation): Remove is_base field.
925 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
926 (Invocation.Emit): Likewise.
928 2004-09-24 Marek Safar <marek.safar@seznam.cz>
930 * cs-parser.jay: Reverted 642 warning fix.
932 2004-09-23 Marek Safar <marek.safar@seznam.cz>
935 * decl.cs (FindMemberWithSameName): Indexer can have more than
938 2004-09-23 Marek Safar <marek.safar@seznam.cz>
940 * expression.cs (LocalVariableReference.DoResolveLValue):
941 Do not report warning 219 for out values.
942 (EmptyExpression.Null): New member to avoid extra allocations.
944 2004-09-23 Marek Safar <marek.safar@seznam.cz>
946 * cs-parser.jay: Fix wrong warning 642 report.
948 * cs-tokenizer.cs (CheckNextToken): New helper;
949 Inspect next character if is same as expected.
951 2004-09-23 Martin Baulig <martin@ximian.com>
953 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
954 (Convert.ImplicitReferenceConversionExists): Likewise.
956 2004-11-09 Raja R Harinath <rharinath@novell.com>
958 * Makefile (DISTFILES): Comment out a few missing files.
960 2004-10-29 Raja R Harinath <rharinath@novell.com>
962 * Makefile (bootstrap_libs,bootstrap_libfiles): New.
963 (bootstrap-libs): New target. Invokes the net_2_0_bootstrap profile.
964 (gmcs.exe): Invoke bootstrap-libs.
965 (clean-local): Clean the net_2_0_bootstrap profile too.
966 (PROGRAM_INSTALL_DIR): New.
967 (install-local): Use it.
969 2004-10-13 Martin Baulig <martin@ximian.com>
971 * generic.cs (TypeManager.InflatedConstraints): New nested class.
972 (TypeParameter.DefineType): If we're a method type parameter and
973 that method is overriding something, "inflate" its constraints.
975 2004-10-12 Martin Baulig <martin@ximian.com>
977 * expression.cs (MemberAccess.DoResolve): If we're a SimpleName
978 and have type arguments, create and resolve a ConstructedType.
980 2004-10-12 Martin Baulig <martin@ximian.com>
982 * decl.cs (MemberCache.FindMemberToOverride): Use
983 TypeManager.IsEqual() to compare the parameters and Type.Equals()
984 to compare the invocationType.
986 * typemanager.cs (TypeManager.IsEqual): Added support for arrays.
987 When comparing two type parameters, only do the signature-only
988 comparision for method type parameters.
990 2004-10-11 Martin Baulig <martin@ximian.com>
992 * report.cs: Don't make --fatal abort on warnings, we have
993 -warnaserror for that.
995 2004-10-11 Martin Baulig <martin@ximian.com>
998 (TypeManager.IsEqualGenericType): Removed, use IsEqual() instead.
999 (TypeManager.IsEqual): Call ourself recursively instead of using
1002 2004-10-11 Martin Baulig <martin@ximian.com>
1004 * class.cs (TypeContainer.DefineType): Only call TypeParameter.Define()
1005 on our own type parameters, not on the ones we inherit from a containing
1008 * expression.cs (Invocation.InferType): Use `==', not `Equals()' for
1011 * generic.cs (TypeParameter.Define): We may only be called once.
1013 * pending.cs (Pending.InterfaceMethod): Call TypeManager.Real_IsEqual()
1014 instead of TypeManager.IsEqual().
1016 2004-09-28 Martin Baulig <martin@ximian.com>
1019 (GenericConstraints.EffectiveBaseClass): New public property.
1020 (TypeParameter.GenericConstraints): New public property.
1021 (ConstructedType.CheckConstraints): Improved.
1023 * convert.cs (Convert.TypeParam_EffectiveBaseType): New private method.
1024 (Convert.TypeParameterConversion): New private method; use this in
1025 ImplicitReferenceConversion() and ImplicitReferenceConversionExists()
1026 for all conversions related to type parameters.
1028 2004-09-24 Martin Baulig <martin@ximian.com>
1030 * convert.cs (Convert.ImplicitReferenceConversion): Added implicit
1031 type parameter conversions for type parameters which are known to
1034 2004-09-24 Martin Baulig <martin@ximian.com>
1036 * generic.cs (GenericConstraints): Added `IsReferenceType' and
1037 `IsValueType' properties.
1039 * support.cs (ReflectionConstraints): Use
1040 Type.GetGenericParameterConstraints() instead of the old hack.
1042 2004-09-24 Martin Baulig <martin@ximian.com>
1044 * generic.cs (GenericConstraints): Moved here and made it an
1047 * support.cs (GenericConstraints): Moved to generic.cs.
1049 2004-09-24 Martin Baulig <martin@ximian.com>
1052 (ReflectionConstraints): Un-nested this class and made it public.
1055 (TypeManager.GetTypeParameterConstraints): New public method.
1056 (TypeManager.HasConstructorConstraint): Use the attributes.
1058 2004-09-24 Martin Baulig <martin@ximian.com>
1060 * support.cs (GenericConstraints): Replaced `HasConstructor',
1061 `IsReferenceType' and `IsValueType' with `Attributes'.
1062 (ReflectionParameters.ReflectionConstraints): Removed the Create()
1063 method and made the .ctor public.
1065 * generic.cs (Constraints.Attributes): New public property.
1066 (Constraints): Renamed `HasConstructor' -> `HasConstructorConstraint',
1067 `IsReferenceType' -> `HasReferenceTypeConstraint' and
1068 `IsValueType' -> `HasValueTypeConstraint'.
1070 2004-09-23 Martin Baulig <martin@ximian.com>
1072 * generic.cs (Constraints): Reflect latest runtime changes.
1074 2004-09-23 Martin Baulig <martin@ximian.com>
1076 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
1077 (Convert.ImplicitReferenceConversionExists): Likewise.
1079 2004-09-23 Marek Safar <marek.safar@seznam.cz>
1081 * class.cs (Operator.Define): Add error 448 and 559 report.
1083 2004-09-22 Marek Safar <marek.safar@seznam.cz>
1085 * class.cs (MemberBase.IsTypePermitted): New protected
1086 method for checking error CS0610.
1088 2004-09-22 Marek Safar <marek.safar@seznam.cz>
1090 * class.cs (TypeContainer.HasExplicitLayout): New property
1091 Returns whether container has StructLayout attribute set Explicit.
1092 (FieldMember): New abstract class for consts and fields.
1093 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
1094 (Field): Reuse FieldMember.
1096 * const.cs (Const): Reuse FieldMember.
1098 * rootcontext.cs: EmitConstants call moved to class.
1100 2004-09-22 Martin Baulig <martin@ximian.com>
1102 Marek and me just fixed one of our oldest bugs: #28562 :-)
1104 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
1106 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
1107 we're an EnumConstant, just return that.
1108 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
1109 an EnumConstant. In this case, we need to use GetValueAsEnumType()
1110 to get the value which'll actually be written into the attribute.
1111 However, we have to use GetValue() to access the attribute's value
1114 2004-09-22 Marek Safar <marek.safar@seznam.cz>
1116 * constant.cs (Constant.IsNegative): New abstract property
1119 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
1120 (StackAlloc.DoResolve): Reused IsNegative.
1122 2004-09-22 Martin Baulig <martin@ximian.com>
1124 * typemanager.cs (TypeManager.LookupGenericTypeContainer): New
1125 public method; like LookupTypeContainer, but also works for
1128 * report.cs (Report.SymbolRelatedToPreviousError): Use
1129 TypeManager.LookupGenericTypeContainer().
1131 2004-09-22 Martin Baulig <martin@ximian.com>
1133 Thanks to Peter Sestoft for this bug report.
1135 * expression.cs (Conditional): If both the `trueExpr' and the
1136 `falseExpr' is a NullLiteral, return a NullLiteral.
1138 2004-09-22 Martin Baulig <martin@ximian.com>
1140 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
1141 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
1142 for the "get_Current" call.
1144 2004-09-21 Martin Baulig <martin@ximian.com>
1146 * convert.cs (Convert.ImplicitReferenceConversion): When
1147 converting to an interface type, first check whether we're
1148 converting from a reference type.
1150 2004-09-14 Martin Baulig <martin@ximian.com>
1152 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
1154 2004-09-14 Marek Safar <marek.safar@seznam.cz>
1157 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
1158 called and is obsolete then this member suppress message
1159 when call is inside next [Obsolete] method or type.
1161 * expression.cs: Use TestObsoleteMethodUsage member.
1163 2004-09-14 Martin Baulig <martin@ximian.com>
1165 * genericparser.cs: Removed.
1167 2004-09-13 Marek Safar <marek.safar@seznam.cz>
1169 * class.cs (MethodCore.CheckBase): Fix bug #65757.
1171 2004-09-12 Marek Safar <marek.safar@seznam.cz>
1173 * attribute.cs (Attribute.Resolve): Add error 653 report.
1175 * class.cs (Class.ApplyAttributeBuilder): Add error 641
1177 (Method.ApplyAttributeBuilder): Add error 685 report.
1178 (Operator.Define): Add error 564 report.
1180 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
1182 * expression.cs (Invocation.DoResolve): Add error
1185 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
1188 2004-09-11 Marek Safar <marek.safar@seznam.cz>
1190 * class.cs (ConstructorInitializer.Resolve):
1191 Wrong error number (515->516).
1193 2004-09-11 Marek Safar <marek.safar@seznam.cz>
1195 * class.cs (Indexer.Define): Add error 631 report.
1197 2004-09-11 Marek Safar <marek.safar@seznam.cz>
1199 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
1201 2004-09-11 Marek Safar <marek.safar@seznam.cz>
1203 * expression.cs (Probe.DoResolve): Add error CS0241 report.
1205 2004-09-10 Marek Safar <marek.safar@seznam.cz>
1207 * cs-parser.jay: Added error CS0241 report.
1209 2004-09-10 Raja R Harinath <rharinath@novell.com>
1211 * cs-parser.jay (fixed_statement): Introduce a scope for the
1212 declaration in the 'fixed' statement.
1214 2004-09-09 Marek Safar <marek.safar@seznam.cz>
1216 * cs-parser.jay: Added CS0230 error report.
1218 2004-09-09 Marek Safar <marek.safar@seznam.cz>
1220 * cs-parser.jay: Added errors CS0231 and CS0257 report.
1222 2004-09-09 Marek Safar <marek.safar@seznam.cz>
1224 * expression.cs (Argument.Resolve): Added error CS0192 and
1227 2004-09-09 Marek Safar <marek.safar@seznam.cz>
1229 C# 2.0 #pragma warning feature
1231 * cs-tokenizer.cs (PreProcessPragma): New method;
1232 Handles #pragma directive.
1234 * report.cs (WarningRegions): New class; Support
1235 class for #pragma warning directive. It tests whether
1236 warning is enabled for a given line.
1238 2004-09-08 Miguel de Icaza <miguel@ximian.com>
1240 * const.cs: Add more descriptive error report, tahnks to
1243 2004-09-08 Marek Safar <marek.safar@seznam.cz>
1245 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
1247 2004-09-07 Miguel de Icaza <miguel@ximian.com>
1249 * expression.cs: Apply patch from Ben: Remove dead code from
1250 ArrayCreation, and remove the TurnintoConstant call in const.cs,
1251 as that code just threw an exception anwyays.
1253 * const.cs: Remove the call to the turnintoconstant, for details
1256 * literal.cs: The type of the null-literal is the null type; So
1257 we use a placeholder type (literal.cs:System.Null, defined here)
1260 * expression.cs (Conditional.DoResolve): Remove some old code that
1261 is no longer needed, conversions have been fixed.
1263 (ArrayCreationExpression.DoResolve): Return false if we fail to
1264 resolve the inner expression.
1266 2004-09-07 Raja R Harinath <rharinath@novell.com>
1269 * cs-parser.jay (delegate_declaration): Record a delegate
1270 declaration as a type declaration.
1271 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
1273 2004-09-06 Miguel de Icaza <miguel@ximian.com>
1275 * parameter.cs: Do not crash if the type can not be resolved.
1277 * expression.cs: Report errors with unsafe pointers, fixes #64896
1279 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
1281 * expression.cs: Pointer arith always needs to do a conv.i
1282 if the operand is a long. fix 65320
1284 2004-09-04 Marek Safar <marek.safar@seznam.cz>
1286 Fixed cs0619-37.cs, cs0619-38.cs
1288 * enum.cs (GetObsoleteAttribute): Removed.
1290 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
1291 on Enum member is double staged. The first is tested member
1294 2004-09-04 Marek Safar <marek.safar@seznam.cz>
1296 Fixed #56986, #63631, #65231
1298 * class.cs: (TypeContainer.AddToMemberContainer): New method,
1299 adds member to name container.
1300 (TypeContainer.AddToTypeContainer): New method, adds type to
1302 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
1303 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
1304 AddOperator): Simplified by reusing AddToMemberContainer.
1305 (TypeContainer.UserDefinedStaticConstructor): Changed to property
1307 (Method.CheckForDuplications): Fixed implementation to test all
1309 (MemberBase): Detection whether member is explicit interface
1310 implementation is now in constructor.
1311 (MemberBase.UpdateMemberName): Handles IndexerName.
1312 (Accessor): Changed to keep also location information.
1313 (AbstractPropertyEventMethod): Is derived from MemberCore.
1314 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
1315 will be emited or not.
1316 (PropertyBase.AreAccessorsDuplicateImplementation):
1317 Tests whether accessors are not in collision with some method.
1318 (Operator): Is derived from MethodCore to simplify common
1321 * decl.cs (Flags.TestMethodDuplication): Test for duplication
1323 (DeclSpace.AddToContainer): Adds the member to defined_names
1324 table. It tests for duplications and enclosing name conflicts.
1326 * enum.cs (EnumMember): Clean up to reuse the base structures
1328 2004-09-03 Martin Baulig <martin@ximian.com>
1330 Merged latest changes into gmcs. Please keep this comment in
1331 here, it makes it easier for me to see what changed in MCS since
1332 the last time I merged.
1334 2004-09-03 Martin Baulig <martin@ximian.com>
1336 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
1337 into TypeContainer, to make partial classes work again.
1339 2004-09-03 Martin Baulig <martin@ximian.com>
1341 * rootcontext.cs (RootContext.V2): Removed.
1343 2004-03-23 Martin Baulig <martin@ximian.com>
1345 * expression.cs (Invocation.OverloadResolve): Added `bool
1346 may_fail' argument and use it instead of the Location.IsNull() hack.
1348 2004-09-09 Martin Baulig <martin@ximian.com>
1350 * cs-parser.jay (namespace_declaration): Fixed CS0134 reporting.
1352 2004-09-09 Martin Baulig <martin@ximian.com>
1354 * generic.cs (TypeParameter.DefineType): Added support for
1355 explicit interface methods.
1357 2004-09-09 Martin Baulig <martin@ximian.com>
1359 * README.Changes: New document. Started to list important changes
1360 between MCS and GMCS here.
1362 2004-09-08 Martin Baulig <martin@ximian.com>
1365 (TypeContainer.CheckRecursiveDefinition): New protected method.
1366 (TypeContainer.DefineType): Move the CS0146 check into
1367 CheckRecursiveDefinition().
1369 2004-09-06 Martin Baulig <martin@ximian.com>
1371 * generic.cs (ConstructedType.CheckConstraints): Allow builtin
1372 types for the constructor constraint.
1374 2004-09-03 Martin Baulig <martin@ximian.com>
1376 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
1377 into TypeContainer, to make partial classes work again.
1379 2004-09-03 Martin Baulig <martin@ximian.com>
1381 * rootcontext.cs (RootContext.V2): Removed.
1383 2004-03-23 Martin Baulig <martin@ximian.com>
1385 * expression.cs (Invocation.OverloadResolve): Added `bool
1386 may_fail' argument and use it instead of the Location.IsNull() hack.
1388 2004-09-03 Martin Baulig <martin@ximian.com>
1390 Merged latest changes into gmcs. Please keep this comment in
1391 here, it makes it easier for me to see what changed in MCS since
1392 the last time I merged.
1394 2004-09-03 Raja R Harinath <rharinath@novell.com>
1397 * expression.cs (BetterConversion): Don't allow either conversion
1398 to be null. Remove redundant implicit conversion test when 'q ==
1399 null' -- when this function is invoked, we already know that the
1400 implicit conversion exists.
1401 (BetterFunction): Assume that 'best' is non-null. Remove
1402 redundant reimplementation of IsApplicable when 'best' is null.
1403 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
1404 number of arguments.
1405 (IsAncestralType): Extract from OverloadResolve.
1406 (OverloadResolve): Make robust to the MethodGroupExpr being
1407 unsorted. Implement all the logic of Section 14.5.5.1, and
1408 support overloading of methods from multiple applicable types.
1409 Clean up logic somewhat. Don't pass null methods to BetterFunction.
1411 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
1412 (RealError, Warning): Append type of report to related symbol.
1414 2004-09-03 Marek Safar <marek.safar@seznam.cz>
1416 * enum.cs: Fixed CLS-Compliance checks for enum members.
1417 Error tests cs3008-8.cs, cs3014-8.cs
1419 2004-09-02 Marek Safar <marek.safar@seznam.cz>
1421 Fixed bug #62342, #63102
1422 * class.cs: ImplementIndexer uses member.IsExplicitImpl
1423 like ImplementMethod.
1425 2004-09-02 Marek Safar <marek.safar@seznam.cz>
1427 * attribute.cs (Attribute.GetAttributeArgumentExpression):
1430 2004-09-02 Martin Baulig <martin@ximian.com>
1432 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
1433 TypeManager.GetArgumentTypes() rather than calling GetParameters()
1436 2004-09-01 Marek Safar <marek.safar@seznam.cz>
1438 C# 2.0 Static classes implemented
1440 * class.cs (TypeContainer): instance_constructors,
1441 initialized_fields, initialized_static_fields,
1442 default_constructor, base_inteface_types are protected to be
1443 accessible from StaticClass.
1444 (TypeContainer.DefineDefaultConstructor): New virtual method
1445 for custom default constructor generating
1446 (StaticClass): New class to handle "Static classes" feature.
1448 * cs-parser.jay: Handle static keyword on class like instance
1451 * driver.cs: Added "/langversion" command line switch with two
1452 options (iso-1, default).
1454 2004-08-31 Marek Safar <marek.safar@seznam.cz>
1456 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
1458 2004-08-31 Miguel de Icaza <miguel@ximian.com>
1460 * delegate.cs: Style.
1462 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
1464 * delegate.cs: Add seperate instance expr field for miguel.
1466 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
1468 * PointerArithmetic (Resolve): make sure we are not doing
1469 pointer arith on void*. Also, make sure we are resolved
1470 by not setting eclass until resolve.
1472 All callers: Make sure that PointerArithmetic gets resolved.
1474 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
1476 * ArrayCreation (LookupType): If the type does not resolve
1477 to an array, give an error.
1479 2004-08-27 Marek Safar <marek.safar@seznam.cz>
1481 * statement.cs (Try.Resolve): Fixed bug #64222
1483 2004-08-27 Martin Baulig <martin@ximian.com>
1486 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
1489 2004-08-26 Marek Safar <marek.safar@seznam.cz>
1491 * ecore.cs (Constantify): Get underlying type via
1492 System.Enum.GetUnderlyingType to avoid StackOverflow on the
1493 Windows in special cases.
1495 2004-08-26 Marek Safar <marek.safar@seznam.cz>
1497 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
1498 for obtaining also private methods.
1499 (GetRemoveMethod): Used GetRemoveMethod (true)
1500 for obtaining also private methods.
1502 2004-09-02 Martin Baulig <martin@ximian.com>
1504 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
1505 TypeManager.GetArgumentTypes() rather than calling GetParameters()
1508 2004-08-27 Martin Baulig <martin@ximian.com>
1511 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
1514 2004-08-25 Martin Baulig <martin@ximian.com>
1516 * support.cs (ReflectionParameters..ctor): If this is a generic
1517 method, retrieve and store its type parameters.
1518 (InternalParameters..ctor): Added `TypeParameter[]' argument.
1519 (ReflectionParameters.GenericConstraints): The argument specifies
1520 the type parameter, not the method parameter.
1521 (InternalParameters.GenericConstraints): Likewise.
1523 * generic.cs (TypeParameter.DefineType): Correctly handle
1524 constraints wrt. generic methods in interfaces and their
1527 2004-08-24 Martin Baulig <martin@ximian.com>
1529 * generic.cs (TypeParameter.IsSubclassOf): New public method.
1530 (Constraints.IsSubclassOf): New internal method.
1532 * typemanager.cs (TypeManager.FindMembers): Added special support
1533 for GenericTypeParameterBuilder's.
1534 (TypeManager.IsSubclassOf, IsFamilyAccessible): Added support for
1537 2004-08-24 Martin Baulig <martin@ximian.com>
1540 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
1541 this for accessibility checks.
1542 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
1543 IsNestedFamilyAccessible.
1544 (TypeManager.IsSubclassOf): New method, do what the name actually
1547 2004-08-24 Martin Baulig <martin@ximian.com>
1549 * expression.cs (MemberAccess.DoResolve): When resolving ourselves
1550 as a SimpleName, include the generic arity.
1552 2004-08-24 Martin Baulig <martin@ximian.com>
1554 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
1555 MethodAttributes.HideBySig for operators.
1557 2004-08-23 Martin Baulig <martin@ximian.com>
1559 Back to the old error reporting system :-)
1561 * report.cs (Message): Removed.
1562 (Report.MessageData, ErrorData, WarningData): Removed.
1563 (Report.Error, Warning): Back to the old system.
1565 2004-08-23 Martin Baulig <martin@ximian.com>
1567 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
1569 * class.cs (TypeContainer.ParentContainer): New public virtual
1570 method; replaces the explicit interface implementation.
1571 (ClassPart.ParentContainer): Override.
1573 2004-08-23 Martin Baulig <martin@ximian.com>
1575 * statement.cs (Switch): Added support for constant switches; see
1576 #59428 or test-285.cs.
1578 2004-08-22 Marek Safar <marek.safar@seznam.cz>
1581 * statement.cs (GetEnumeratorFilter): Removed useless
1582 logic because C# specs is strict. GetEnumerator must be
1585 2004-08-22 Martin Baulig <martin@ximian.com>
1587 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
1588 a switch and may break, reset the barrier. Fixes #59867.
1590 2004-08-22 Marek Safar <marek.safar@seznam.cz>
1592 CLS-Compliance speed up (~5% for corlib)
1594 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
1595 New method. Tests container for CLS-Compliant names
1597 * class.cs (TypeContainer.VerifyClsName): New method.
1598 Checks whether container name is CLS Compliant.
1599 (Constructor): Implements IMethodData.
1601 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
1602 low-case table for CLS Compliance test.
1603 (MemberCache.VerifyClsParameterConflict): New method.
1604 Checks method parameters for CS3006 error.
1606 * enum.cs (EnumMember): Is derived from MemberCore.
1607 (Enum.VerifyClsName): Optimized for better performance.
1609 2004-08-06 Marek Safar <marek.safar@seznam.cz>
1611 * report.cs: Renamed Error_T to Error and changed all
1614 2004-08-06 Marek Safar <marek.safar@seznam.cz>
1616 * class.cs (TypeContainer.IndexerArrayList): New inner class
1617 container for indexers.
1618 (TypeContainer.DefaultIndexerName): New constant for default
1619 indexer name. Replaced all "Item" with this constant.
1620 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
1622 * typemanager.cs (TypeManager.default_member_ctor): Cache here
1623 DefaultMemberAttribute constructor.
1625 2004-08-05 Martin Baulig <martin@ximian.com>
1627 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
1630 2004-08-05 Marek Safar <marek.safar@seznam.cz>
1632 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
1633 multi platforms problem.
1635 * compiler.csproj: Included shared files.
1637 2004-08-04 Marek Safar <marek.safar@seznam.cz>
1639 Fix bug 60333, 55971 in the more general way
1640 * attribute.cs (Attribute.GetAttributeArgumentExpression):
1641 Added arg_type argument for constant conversion.
1642 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
1644 2004-08-04 Marek Safar <marek.safar@seznam.cz>
1647 * class.cs (TypeContainer ): New inner classes MethodArrayList,
1648 OperatorArrayList, MethodCoreArrayList for typecontainer
1649 containers. Changed class member types to these new types.
1650 (MethodArrayList.DefineMembers): Added test for CS0659.
1652 2004-08-04 Miguel de Icaza <miguel@ximian.com>
1654 * cfold.cs: Synchronize the folding with the code in expression.cs
1655 Binary.DoNumericPromotions for uint operands.
1657 * attribute.cs: Revert patch from Raja, it introduced a regression
1658 while building Blam-1.2.1 (hard to isolate a test case).
1660 2004-08-04 Marek Safar <marek.safar@seznam.cz>
1664 (TypeContainer.Define): Renamed to DefineContainerMembers because of
1666 (MethodCore.parent_method): New member. The method we're overriding
1667 if this is an override method.
1668 (MethodCore.CheckBase): Moved from Method class and made common.
1669 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
1671 (MethodCore.CheckForDuplications): New abstract method. For custom
1672 member duplication search in a container
1673 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
1674 method and its return type.
1675 (Event.conflict_symbol): New member. Symbol with same name in the
1679 (MemberCache.FindMemberWithSameName): New method. The method
1680 is looking for conflict with inherited symbols.
1682 2004-08-04 Martin Baulig <martin@ximian.com>
1684 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
1686 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
1688 2004-08-03 Marek Safar <marek.safar@seznam.cz>
1690 * report.cs (Message): New enum for better error, warning reference in
1692 (MessageData): New inner abstract class. It generally handles printing of
1693 error and warning messages.
1694 Removed unused Error, Warning, Message methods.
1696 2004-08-03 Marek Safar <marek.safar@seznam.cz>
1698 Fix for cs0592-8.cs test
1700 (Attributable.ValidAttributeTargets): Made public.
1701 (Attribute.ExplicitTarget): New member for explicit target value.
1702 (Attribute.CheckTargets): Now we translate explicit attribute
1703 target to Target here.
1705 2004-08-03 Ben Maurer <bmaurer@ximian.com>
1707 * ecore.cs (MethodGroupExpr): new IsBase property.
1709 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
1711 * delegate.cs (DelegateCreation): store a MethodGroupExpr
1712 rather than an instance expr.
1714 (DelegateCreation.Emit): Use the method group rather than
1715 the instance expression. Also, if you have base.Foo as the
1716 method for a delegate, make sure to emit ldftn, not ldftnvirt.
1718 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
1720 (NewDelegate.DoResolve): Only check for the existance of Invoke
1721 if the method is going to be needed. Use MethodGroupExpr.
1723 (NewDelegate.Emit): Remove, DelegateCreation implements this.
1725 * expression.cs: For pointer arith., make sure to use
1726 the size of the type, not the size of the pointer to
1729 2004-08-03 Marek Safar <marek.safar@seznam.cz>
1732 * class.cs (Class): Added error CS0502 test.
1734 2004-08-03 John Luke <jluke@cfl.rr.com>
1735 Raja R Harinath <rharinath@novell.com>
1738 * attribute.cs (Attribute.complained_before): New flag.
1739 (Attribute.ResolveType, Attribute.Resolve),
1740 (Attribute.DefinePInvokeMethod): Set it.
1741 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
1743 2004-08-03 Martin Baulig <martin@ximian.com>
1745 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
1746 use a user-defined operator; we still need to do numeric
1747 promotions in case one argument is a builtin type and the other
1748 one has an implicit conversion to that type. Fixes #62322.
1750 2004-08-18 Martin Baulig <martin@ximian.com>
1752 * class.cs (Method.Define): Use the correct method name when
1753 creating the MethodBuilder for a generic method.
1755 2004-08-17 Martin Baulig <martin@ximian.com>
1757 * generic.cs (Constraints): Support type parameter constraints.
1759 2004-08-16 Martin Baulig <martin@ximian.com>
1761 * cs-tokenizer.cs (Tokenizer.TypeOfParsing): New public property.
1762 (Token.GENERIC_DIMENSION): New token; this is returned if we
1763 encounter an unbound generic type in a typeof() expression.
1765 * cs-parser.jay (opt_type_argument_list): Added GENERIC_DIMENSION;
1766 this token is only generated while parsing a typeof() expression.
1767 (typeof_expression): Removed the old unbound_type hack.
1769 * generic.cs (TypeArguments.IsUnbound): New public property.
1771 * decl.cs (MemberName): Added support for unbound types.
1773 2004-08-14 Martin Baulig <martin@ximian.com>
1776 (TypeManager.IsEqualGenericInstance): New static method.
1777 (TypeManager.IsSubclassOrNestedChildOf, IsSubclassOf): This is
1778 just used to check accessibility, so follow the rules of 26.1.6.
1780 * expression.cs (MemberAccess.ResolveAsTypeStep): Return a
1781 ConstructedType instead of a TypeExpression if we have type arguments.
1783 * cs-parser.jay (typeof_expression): Support unbound generic types.
1785 * ecore.cs (UnboundTypeExpression): New public class.
1787 2004-08-12 Martin Baulig <martin@ximian.com>
1789 * typemanager.cs (TypeManager.IsNestedChildOf): Use
1790 TypeManager.IsEqual() rather than `=='.
1792 * decl.cs (DeclSpace.CheckAccessLevel): Use `tb.FullName' for
1793 generic instances as well.
1795 2004-08-12 Martin Baulig <martin@ximian.com>
1797 * expression.cs (Invocation.InferType): We can only infer method
1798 type parameters. Fixes #62647.
1800 2004-08-11 Martin Baulig <martin@ximian.com>
1802 * class.cs (TypeContainer.DefineType): Create the TypeBuilder
1803 before resolving the base classes.
1805 2004-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
1807 * Makefile: install .mdb file too.
1809 2004-08-05 Martin Baulig <martin@ximian.com>
1811 * ecore.cs (FieldExpr.DoResolveLValue): If we're resolving a field
1812 initializer, the current type is just the TypeBuilder, not the
1813 instantiated generic type.
1814 (FieldExpr.IsFieldInitializer): New public property.
1816 2004-08-04 Martin Baulig <martin@ximian.com>
1818 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
1820 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
1822 2004-08-03 Martin Baulig <martin@ximian.com>
1824 * class.cs (MethodData.Define): If we're an explicit
1825 implementation, remove the generic arity from the type name.
1827 2004-08-03 Martin Baulig <martin@ximian.com>
1829 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
1830 use a user-defined operator; we still need to do numeric
1831 promotions in case one argument is a builtin type and the other
1832 one has an implicit conversion to that type. Fixes #62322.
1834 2004-08-02 Martin Baulig <martin@ximian.com>
1836 * class.cs (TypeContainer.ifaces): Make this a `Type[]', not a
1838 (TypeContainer.GetClassBases): Return the unexpanded list of
1839 interfaces; we expand them later.
1840 (TypeContainer.DefineType): After creating the TypeBuilder, call
1841 TypeManager.ExpandInterfaces() to get an expanded and resolved
1844 * ecore.cs (TypeExpr.GetInterfaces): Removed
1846 * generics.cs (Constraints.InterfaceConstraints): Remove.
1847 (TypeParameter.DefineType): Call TypeManager.RegisterBuilder() to
1848 register the interface constraints.
1851 (TypeManager.AddUserType): Removed the `ifaces' argument.
1852 (TypeManager.AddTypeParameter): Likewise.
1853 (TypeManager.AddUserInterface): Removed, was unused.
1854 (TypeManager.RegisterBuilder): Take a `Type[]' instead of a
1855 `TypeExpr[]' array for the interfaces.
1856 (TypeManager.ExpandInterfaces): Call this after the TypeBuilder
1857 has been defined, returns a list of the resolved interfaces types.
1858 (TypeManager.GetInterfaces): Return a `Type[]', not a `TypeExpr[]'.
1859 (TypeManager.GetExplicitInterfaces): Likewise.
1861 2004-08-02 Martin Baulig <martin@ximian.com>
1863 * expression.cs (Invocation.EmitCall): If we're invoking a method
1864 on a type parameter, use the new `Constrained' prefix opcode.
1866 2004-08-02 Martin Baulig <martin@ximian.com>
1868 * statement.cs (LocalInfo.Flags): Added `IsThis'.
1869 (LocalInfo.IsThis): New public property.
1870 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
1872 2004-08-01 Martin Baulig <martin@ximian.com>
1874 * class.cs (TypeContainer.GetClassBases): Don't set the default
1875 here since we may get called from GetPartialBases().
1876 (TypeContainer.DefineType): If GetClassBases() didn't return a
1877 parent, use the default one.
1879 2004-07-30 Martin Baulig <martin@ximian.com>
1881 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
1883 * class.cs (SourceMethod): New public class, derive from the
1884 symbol writer's ISourceMethod.
1885 (Method): Use the new symbol writer API.
1887 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
1888 as argument and use the new symbol writer.
1891 (SourceFile): Implement the symbol writer's ISourceFile.
1892 (Location.SymbolDocument): Removed.
1893 (Location.SourceFile): New public property.
1895 * symbolwriter.cs: Use the new symbol writer API.
1897 2004-07-30 Raja R Harinath <rharinath@novell.com>
1899 * Makefile (install-local): Remove. Functionality moved to
1902 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
1904 * Makefile: Install mcs.exe.config file together with mcs.exe.
1905 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
1906 correct runtime version.
1908 2004-07-25 Martin Baulig <martin@ximian.com>
1911 (TypeContainer.RegisterOrder): Removed, this was unused.
1912 (TypeContainer, interface_order): Removed.
1913 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
1914 TypeContainer as argument since we can also be called with a
1915 `PartialContainer' for a partial class/struct/interface.
1916 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
1917 of checking whether we're an `Interface' - we could be a
1919 (PartialContainer.Register): Override; call
1920 AddClass()/AddStruct()/AddInterface() on our parent.
1922 * cs-parser.jay (interface_member_declaration): Add things to the
1923 `current_container', not the `current_class'.
1925 * rootcontext.cs (RegisterOrder): The overloaded version which
1926 takes an `Interface' was unused, removed.
1928 * typemanager.cs (TypeManager.LookupInterface): Return a
1929 `TypeContainer', not an `Interface'.
1930 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
1931 contain a `PartialContainer' for an interface, so check it's
1932 `Kind' to figure out what it is.
1934 2004-07-25 Martin Baulig <martin@ximian.com>
1936 * class.cs (Class.DefaultTypeAttributes): New public constant.
1937 (Struct.DefaultTypeAttributes): Likewise.
1938 (Interface.DefaultTypeAttributes): Likewise.
1939 (PartialContainer.TypeAttr): Override this and add the
1940 DefaultTypeAttributes.
1942 2004-07-25 Martin Baulig <martin@ximian.com>
1944 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
1945 we can just use the `Parent' field instead.
1947 2004-07-25 Martin Baulig <martin@ximian.com>
1949 * class.cs (TypeContainer.Emit): Renamed to EmitType().
1951 2004-07-25 Martin Baulig <martin@ximian.com>
1953 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
1954 our parts before defining any methods.
1955 (TypeContainer.VerifyImplements): Make this virtual.
1956 (ClassPart.VerifyImplements): Override and call VerifyImplements()
1957 on our PartialContainer.
1959 2004-07-25 Martin Baulig <martin@ximian.com>
1961 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
1963 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
1964 argument, we can just use the `Parent' field instead.
1967 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
1968 (MemberBase.DoDefine): Likewise.
1970 2004-07-24 Martin Baulig <martin@ximian.com>
1972 * decl.cs (MemberCore.Parent): New public field.
1973 (DeclSpace.Parent): Moved to MemberCore.
1975 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
1976 (MemberBase.ctor): Added TypeContainer argument, pass it to our
1978 (FieldBase, Field, Operator): Likewise.
1979 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
1980 (EventField, Event): Likewise.
1982 2004-07-23 Martin Baulig <martin@ximian.com>
1984 * class.cs (PartialContainer): New public class.
1985 (ClassPart): New public class.
1986 (TypeContainer): Added support for partial classes.
1987 (TypeContainer.GetClassBases): Splitted some of the functionality
1988 out into GetNormalBases() and GetPartialBases().
1990 * cs-tokenizer.cs (Token.PARTIAL): New token.
1991 (Tokenizer.consume_identifier): Added some hacks to recognize
1992 `partial', but only if it's immediately followed by `class',
1993 `struct' or `interface'.
1995 * cs-parser.jay: Added support for partial clases.
1997 2004-07-23 Martin Baulig <martin@ximian.com>
1999 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
2000 a `DeclSpace' and also made it readonly.
2001 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
2002 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
2003 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
2005 * cs-parser.jay: Pass the `current_class', not the
2006 `current_container' (at the moment, this is still the same thing)
2007 to a new Method, Property, Event, Indexer or Constructor.
2009 2004-07-23 Martin Baulig <martin@ximian.com>
2011 * cs-parser.jay (CSharpParser): Added a new `current_class' field
2012 and removed the `current_interface' one.
2013 (struct_declaration, class_declaration, interface_declaration):
2014 Set `current_class' to the newly created class/struct/interface;
2015 set their `Bases' and call Register() before parsing their body.
2017 2004-07-23 Martin Baulig <martin@ximian.com>
2019 * class.cs (Kind): New public enum.
2020 (TypeContainer): Made this class abstract.
2021 (TypeContainer.Kind): New public readonly field.
2022 (TypeContainer.CheckDef): New public method; moved here from
2024 (TypeContainer.Register): New public abstract method.
2025 (TypeContainer.GetPendingImplementations): New public abstract
2027 (TypeContainer.GetClassBases): Removed the `is_class' and
2028 `is_iface' parameters.
2029 (TypeContainer.DefineNestedTypes): Formerly known as
2031 (ClassOrStruct): Made this class abstract.
2033 * tree.cs (RootTypes): New public type.
2035 2004-07-20 Martin Baulig <martin@ximian.com>
2037 * tree.cs (Tree.RecordNamespace): Removed.
2038 (Tree.Namespaces): Removed.
2040 * rootcontext.cs (RootContext.IsNamespace): Removed.
2042 * cs-parser.jay (namespace_declaration): Just create a new
2043 NamespaceEntry here.
2045 2004-07-21 Lluis Sanchez Gual <lluis@novell.com>
2047 * Makefile: Install gmcs.exe.config file together with gmcs.exe.
2048 * gmcs.exe.config: Renamed from mcs.exe.config. Added supportedRuntime
2049 entry to make sure it runs in the correct runtime version.
2051 2004-07-18 Martin Baulig <martin@ximian.com>
2053 * generic.cs (ConstructedType.CheckConstraints): Improved
2054 constraints checking.
2056 2004-07-18 Martin Baulig <martin@ximian.com>
2058 * expression.cs (Invocation.BetterMethod): Call
2059 TypeManager.TypeToCoreType() on all types and removed my previous
2060 hack; we're already doig the right thing here.
2062 2004-07-17 Martin Baulig <martin@ximian.com>
2064 * decl.cs (MemberName.MakeName): Create the "class`1" names here.
2066 2004-07-16 Martin Baulig <martin@ximian.com>
2068 * iterators.cs: Added generics support.
2070 2004-07-16 Martin Baulig <martin@ximian.com>
2072 * iterators.cs: Rewrote this. We're now using one single Proxy
2073 class for both the IEnumerable and the IEnumerator interface and
2074 `Iterator' derives from Class so we can use the high-level API.
2076 * class.cs (TypeContainer.AddIterator): New method.
2077 (TypeContainer.DoDefineType): New protected virtual method, which
2078 is called from DefineType().
2079 (TypeContainer.DoDefineMembers): Call DefineType() and
2080 DefineMembers() on all our iterators.
2081 (TypeContainer.Emit): Call Emit() on all our iterators.
2082 (TypeContainer.CloseType): Call CloseType() on all our iterators.
2084 * codegen.cs (EmitContext.CurrentIterator): New public field.
2086 2004-07-15 Martin Baulig <martin@ximian.com>
2089 (TypeManager.not_supported_exception_type): New type.
2091 2004-07-14 Martin Baulig <martin@ximian.com>
2094 (TypeManager.generic_ienumerable_type): New type.
2095 (TypeManager.generic_ienumerator_type): New type.
2098 (RootContext.interfaces_first_stage): Added
2099 "System.Collections.Generic.IEnumerator`1" and
2100 "System.Collections.Generic.IEnumerable`1".
2102 2004-07-14 Martin Baulig <martin@ximian.com>
2104 * iterators.cs: Use real error numbers.
2106 2004-07-14 Martin Baulig <martin@ximian.com>
2108 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
2109 requires this to be a System.Collection.IEnumerable and not a
2110 class implementing that interface.
2111 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
2113 2004-07-13 Marek Safar <marek.safar@seznam.cz>
2115 * class.cs: Fixed previous fix, it broke some error tests.
2117 2004-07-12 Martin Baulig <martin@ximian.com>
2119 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
2122 2004-07-14 Martin Baulig <martin@ximian.com>
2124 * decl.cs, expression.cs, generic.cs: Use a backqoute (`) and not
2125 an exclamation mark (!) for the generic arity to reflect the
2126 latest spec changes; ie. use "System.Collections.Generic.IList`1".
2128 2004-07-13 Martin Baulig <martin@ximian.com>
2130 * cs-tokenizer.cs (Tokenizer.parse_less_than): Allow array rank
2131 specifiers being part of a type argument.
2133 2004-07-13 Martin Baulig <martin@ximian.com>
2135 * expression.cs (MemberAccess.ResolveAsTypeStep): Use the full `!'
2136 name for generic types.
2138 2004-07-13 Martin Baulig <martin@ximian.com>
2140 * assign.cs (Assign.DoResolve): Moved the CS0131 check up a little
2143 2004-07-09 Miguel de Icaza <miguel@ximian.com>
2145 * assign.cs (LocalTemporary): Add new argument: is_address,If
2146 `is_address' is true, then the value that we store is the address
2147 to the real value, and not the value itself.
2149 * ecore.cs (PropertyExpr): use the new local temporary
2150 stuff to allow us to handle X.Y += z (where X is a struct)
2152 2004-07-08 Martin Baulig <martin@ximian.com>
2154 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
2155 not always return, just like we're doing in Using.Resolve().
2157 2004-07-07 Miguel de Icaza <miguel@ximian.com>
2159 * cs-parser.jay (fixed_statement): flag this as Pinned.
2161 2004-07-06 Miguel de Icaza <miguel@ximian.com>
2163 * typemanager.cs (TypeManager): Removed MakePinned method, this
2164 mechanism is replaced with the .NET 2.x compatible mechanism of
2165 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
2167 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
2168 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
2169 `IsFixed' property which has a different meaning.
2171 2004-07-02 Raja R Harinath <rharinath@novell.com>
2173 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
2174 visible from inside a nested class, not just the names of the
2175 immediately enclosing class.
2178 2004-06-24 Raja R Harinath <rharinath@novell.com>
2180 * expression.cs (BetterConversion): Remove buggy special-case
2181 handling of "implicit constant expression conversions". At this
2182 point, we already know that the conversion is possible -- we're
2183 only checking to see which is better.
2185 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2187 * cs-parser.jay: Added error CS0210 test.
2189 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2191 * cs-parser.jay: Added error CS0134 test.
2193 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2196 * cs-parser.jay: Added error CS0145 test.
2198 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2200 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
2202 2004-06-23 Ben Maurer <bmaurer@ximian.com>
2204 * expression.cs (StackAlloc.Resolve): The argument may not
2205 be a constant; deal with this case.
2207 2004-06-23 Marek Safar <marek.safar@seznam.cz>
2209 * attribute.cs (IndexerName_GetIndexerName): Renamed to
2210 GetIndexerAttributeValue.
2211 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
2213 * class.cs (Indexer.Define): Added error tests for CS0415,
2216 2004-06-23 Miguel de Icaza <miguel@ximian.com>
2218 * attribute.cs (Attribute.Resolve): Keep field code in sync with
2221 2004-06-23 Martin Baulig <martin@ximian.com>
2223 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
2224 neither return nor throw, reset the barrier as well. Fixes #60457.
2226 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
2228 * class.cs : EventAttributes is now set to None by default.
2229 This fixes bug #60459.
2231 2004-06-18 Marek Safar <marek.safar@seznam.cz>
2234 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
2235 Don't throw exception but return null (it's sufficient now).
2237 2004-06-18 Marek Safar <marek.safar@seznam.cz>
2239 * typemanager.cs (GetArgumentTypes): Faster implementation.
2241 2004-06-18 Martin Baulig <martin@ximian.com>
2243 * attribute.cs (Attribute.Resolve): Check whether we're an
2244 EmptyCast which a Constant child. Fixes #60333.
2246 2004-06-17 Ben Maurer <bmaurer@ximian.com>
2248 * statement.cs (EmitCollectionForeach): Account for the fact that
2249 not all valuetypes are in areas which we can take the address of.
2250 For these variables, we store to a temporary variable. Also, make
2251 sure that we dont emit a `callvirt' on a valuetype method.
2253 2004-06-15 Marek Safar <marek.safar@seznam.cz>
2255 * expression.cs (StackAlloc.DoReSolve): Added test for
2256 negative parameter (CS0247).
2258 2004-06-15 Marek Safar <marek.safar@seznam.cz>
2261 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
2263 2004-06-15 Marek Safar <marek.safar@seznam.cz>
2266 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
2269 2004-06-14 Marek Safar <marek.safar@seznam.cz>
2271 Fix bug #58254 & cs1555.cs, cs1556.cs
2272 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
2274 2004-06-14 Marek Safar <marek.safar@seznam.cz>
2276 * cs-parser.jay: Added error CS1669 test for indexers.
2278 2004-06-18 Martin Baulig <martin@ximian.com>
2280 * generics.cs (GenericMethod.ctor): Don't take an Attributes
2281 argument. Fixes #60441.
2283 2004-06-16 Ben Maurer <bmaurer@ximian.com>
2284 * ecore.cs (MethodGroupExpr.Name): Revert Martin's patch.
2285 The name needs to have the actual name of the method in order
2286 for other tests (such as the one in OverloadResolve for Invoke
2287 on a delegate) to work. As well, it does not really help
2288 error reporting because the method group had multiple methods.
2289 * Makefile: Remove MCS_DEBUG, you can enable with the DEBUG_FLAGS.
2290 Make profiling work.
2292 2004-06-13 Martin Baulig <martin@ximian.com>
2294 * cs-parser.jay: Don't allow generic attributes.
2296 2004-06-13 Martin Baulig <martin@ximian.com>
2298 * class.cs (MemberBase.DoDefineBase): New protected method.
2299 (MemberBase.DoDefine): Compute the `flags' in the new
2300 DoDefineBase() which must be called first.
2301 (Method.Define): Call DoDefineBase() first so we have the flags
2302 when defining the generic method.
2304 * cs-parser.jay (interface_method_declaration): Support generic methods.
2306 2004-06-13 Martin Baulig <martin@ximian.com>
2308 * decl.cs (TypeName): Removed.
2309 (MemberName): Removed TypeName and MemberNow; now we just have
2312 * cs-parser.jay: Don't distinguish between type arguments and type
2313 parameters in the grammar and simplified the rules a bit. The
2314 reduce/reduce conflicts are now gone (except the one we inherited
2317 2004-06-11 Martin Baulig <martin@ximian.com>
2319 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
2320 call this twice: for params and varargs methods.
2322 2004-06-11 Marek Safar <marek.safar@seznam.cz>
2325 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
2327 2004-06-11 Marek Safar <marek.safar@seznam.cz>
2329 * attribute.cs (Attribute.GetValidTargets): Made public.
2332 (AbstractPropertyEventMethod): New class for better code sharing.
2333 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
2335 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
2337 2004-06-09 Martin Baulig <martin@ximian.com>
2339 * cs-parser.jay: Removed a reduce/reduce conflict.
2341 2004-06-03 Martin Baulig <martin@ximian.com>
2343 * generic.cs (ConstructedType.GetMemberAccess): Renamed to
2344 GetSimpleName() and return a SimpleName.
2346 * ecore.cs (SimpleName.Arguments): New public field.
2347 (SimpleName): Added overloaded ctor which takes an additional
2348 TypeArguments argument.
2349 (SimpleName.SimpleNameResolve): Added support for generic methods.
2350 (MethodGroupExpr.ResolveGeneric): New public method. The code was
2351 formerly in MemberAccess.DoResolve(), but we also need it in
2352 SimpleNameResolve().
2354 * expression.cs (MemberAccess.DoResolve): Use the new
2355 MethodGroupExpr.ResolveGeneric().
2357 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2359 * decl.cs: If possible, use lookuptypedirect here. We can only do
2360 this if there is no `.' after the namespace. Avoids using
2361 LookupType, which does lots of slow processing.
2362 (FindNestedType) New method, does what it says :-).
2363 * namespace.cs: use LookupTypeDirect.
2364 * rootcontext.cs: use membercache, if possible.
2365 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
2367 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2370 According to the spec,
2372 In a member access of the form E.I, if E is a single identifier,
2373 and if the meaning of E as a simple-name (§7.5.2) is a constant,
2374 field, property, localvariable, or parameter with the same type as
2375 the meaning of E as a type-name (§3.8), then both possible
2376 meanings of E are permitted.
2378 We did not check that E as a simple-name had the same type as E as
2381 This trivial check gives us 5-7% on bootstrap time.
2383 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2385 * expression.cs (Invocation.OverloadResolve): Avoid the
2386 use of hashtables and boxing here by allocating on demand.
2388 2004-05-30 Martin Baulig <martin@ximian.com>
2390 * rootcontext.cs (RootContext.LookupType): Don't cache things if
2391 we're doing a silent lookup. Don't try to lookup nested types in
2392 TypeManager.object_type (thanks to Ben Maurer).
2394 2004-05-30 Martin Baulig <martin@ximian.com>
2396 Committing a patch from Ben Maurer.
2398 * rootcontext.cs (RootContext.LookupType): Cache negative results.
2400 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2402 * convert.cs: add a trivial cache for overload operator resolution.
2404 2004-05-31 Marek Safar <marek.safar@seznam.cz>
2407 (AttributeTester.GetObsoleteAttribute): Returns instance of
2408 ObsoleteAttribute when type is obsolete.
2411 (TypeContainer.VerifyObsoleteAttribute): Override.
2412 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
2413 (MethodCode.VerifyObsoleteAttribute): Override.
2414 (MemberBase.VerifyObsoleteAttribute): Override.
2417 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
2418 and report proper error.
2421 (Delegate.VerifyObsoleteAttribute): Override.
2424 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
2425 and report proper error.
2426 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
2429 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
2433 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
2434 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
2435 Added test for ObsoleteAttribute.
2438 (Catch): Derived from Statement.
2440 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2442 * decl.cs: If possible, use lookuptypedirect here. We can only do
2443 this if there is no `.' after the namespace. Avoids using
2444 LookupType, which does lots of slow processing.
2445 (FindNestedType) New method, does what it says :-).
2446 * namespace.cs: use LookupTypeDirect.
2447 * rootcontext.cs: use membercache, if possible.
2448 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
2450 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2453 According to the spec,
2455 In a member access of the form E.I, if E is a single identifier,
2456 and if the meaning of E as a simple-name (§7.5.2) is a constant,
2457 field, property, localvariable, or parameter with the same type as
2458 the meaning of E as a type-name (§3.8), then both possible
2459 meanings of E are permitted.
2461 We did not check that E as a simple-name had the same type as E as
2464 This trivial check gives us 5-7% on bootstrap time.
2466 2004-05-30 Marek Safar <marek.safar@seznam.cz>
2468 Fixed bug #59071 & cs0160.cs
2469 * statement.cs (Try.Resolve): Check here whether order of catch
2470 clauses matches their dependencies.
2472 2004-05-30 Marek Safar <marek.safar@seznam.cz>
2475 * ecore.cs (SimpleName.SimpleNameResolve): Added test for
2478 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2480 * expression.cs (Invocation.OverloadResolve): Avoid the
2481 use of hashtables and boxing here by allocating on demand.
2483 2004-05-30 Martin Baulig <martin@ximian.com>
2485 * rootcontext.cs (RootContext.LookupType): Don't cache things if
2486 we're doing a silent lookup. Don't try to lookup nested types in
2487 TypeManager.object_type (thanks to Ben Maurer).
2489 2004-05-30 Martin Baulig <martin@ximian.com>
2491 Committing a patch from Ben Maurer.
2493 * rootcontext.cs (RootContext.LookupType): Cache negative results.
2495 2004-05-29 Martin Baulig <martin@ximian.com>
2497 * class.cs (IMethodData.ShouldIgnore): New method.
2499 * typemanager.cs (TypeManager.MethodFlags): Don't take a
2500 `Location' argument, we don't need it anywhere. Use
2501 `IMethodData.ShouldIgnore ()' instead of
2502 `MethodData.GetMethodFlags ()'.
2503 (TypeManager.AddMethod): Removed.
2504 (TypeManager.AddMethod2): Renamed to AddMethod.
2506 2004-05-29 Martin Baulig <martin@ximian.com>
2508 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
2510 * convert.cs (Convert.ImplicitReferenceConversion): If we're
2511 converting from a class type S to an interface type and we already
2512 have an object on the stack, don't box it again. Fixes #52578.
2514 2004-05-29 Martin Baulig <martin@ximian.com>
2516 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
2517 Added support for `params' parameters. Fixes #59267.
2519 2004-05-29 Martin Baulig <martin@ximian.com>
2521 * literal.cs (NullPointer): Provide a private .ctor which sets
2522 `type' to TypeManager.object_type. Fixes #59048.
2524 2004-05-29 Martin Baulig <martin@ximian.com>
2526 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
2527 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
2529 * ecore.cs (EventExpr.instance_expr): Make the field private.
2531 2004-05-26 Marek Safar <marek.safar@seznam.cz>
2533 Fixed bug #50080 & cs0214-2.cs
2534 * expression.cs (Cast.DoResolve): Check unsafe context here.
2536 * statement.cs (Resolve.DoResolve): Likewise.
2538 2004-05-26 Martin Baulig <martin@ximian.com>
2540 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
2542 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
2543 (RootContext.LookupType): Pass down the `silent' flag.
2545 2004-05-25 Martin Baulig <martin@ximian.com>
2548 (MethodGroupExpr.IdenticalTypeName): New public property.
2549 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
2550 expression actually refers to a type.
2552 2004-05-25 Martin Baulig <martin@ximian.com>
2554 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
2555 for #56176 and made it actually work.
2557 2004-05-25 Martin Baulig <martin@ximian.com>
2559 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
2560 (FieldExpr, PropertyExpr): Override and implement
2561 CacheTemporaries. Fixes #52279.
2563 2004-05-25 Miguel de Icaza <miguel@ximian.com>
2565 * location.cs: In the new compiler listing a file twice is a
2566 warning, not an error.
2568 2004-05-24 Martin Baulig <martin@ximian.com>
2570 * enum.cs (Enum.DefineType): For the `BaseType' to be a
2571 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
2573 2004-05-24 Martin Baulig <martin@ximian.com>
2575 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
2576 walking the `using' list. Fixes #53921.
2578 2004-05-24 Martin Baulig <martin@ximian.com>
2580 * const.cs (Const.LookupConstantValue): Added support for
2581 EmptyCast's; fixes #55251.
2583 2004-05-24 Martin Baulig <martin@ximian.com>
2585 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
2586 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
2587 which does the CS0135 check. The reason is that we first need to
2588 check whether the variable actually exists.
2590 2004-05-24 Martin Baulig <martin@ximian.com>
2592 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
2593 than RootContext.LookupType() to find the explicit interface
2596 2004-05-24 Raja R Harinath <rharinath@novell.com>
2598 * Makefile: Simplify. Use executable.make.
2599 * mcs.exe.sources: New file. List of sources of mcs.exe.
2601 2004-05-24 Anders Carlsson <andersca@gnome.org>
2605 Use the invariant culture when doing String.Compare for CLS case
2608 2004-05-23 Martin Baulig <martin@ximian.com>
2610 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
2611 don't have any dots. Fixes #52622, added cs0246-8.cs.
2613 * namespace.cs (NamespaceEntry.Lookup): Likewise.
2615 2004-05-23 Marek Safar <marek.safar@seznam.cz>
2617 * class.cs (MemberBase.Define): Reuse MemberType member for
2618 resolved type. Other methods can use it too.
2620 2004-05-23 Martin Baulig <martin@ximian.com>
2622 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
2623 the variable also exists in the current block (otherwise, we need
2624 to report a CS0103). Fixes #58670.
2626 2004-05-23 Martin Baulig <martin@ximian.com>
2628 * flowanalysis.cs (Reachability.Reachable): Compute this
2629 on-the-fly rather than storing it as a field.
2631 2004-05-23 Martin Baulig <martin@ximian.com>
2633 * flowanalysis.cs (Reachability.And): Manually compute the
2634 resulting `barrier' from the reachability.
2636 2004-05-23 Marek Safar <marek.safar@seznam.cz>
2639 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
2640 instance of ObsoleteAttribute when symbol is obsolete.
2643 (IMethodData): Extended interface for ObsoleteAttribute support.
2645 2004-05-22 Marek Safar <marek.safar@seznam.cz>
2647 * attribute.cs: Fix bug #55970
2649 2004-05-22 Marek Safar <marek.safar@seznam.cz>
2653 (GetObsoleteAttribute): New method. Creates the instance of
2655 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
2656 ObsoleteAttribute when member is obsolete.
2657 (AttributeTester.Report_ObsoleteMessage): Common method for
2658 Obsolete error/warning reporting.
2661 (TypeContainer.base_classs_type): New member for storing parent type.
2664 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
2665 for this MemberCore.
2667 2004-05-21 Marek Safar <marek.safar@seznam.cz>
2669 * attribute.cs, const.cs: Fix bug #58590
2671 2004-05-21 Martin Baulig <martin@ximian.com>
2673 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
2674 out parameters if the end of the method is unreachable. Fixes
2677 2004-05-21 Marek Safar <marek.safar@seznam.cz>
2679 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
2680 Hari was right, why extra method.
2682 2004-05-21 Marek Safar <marek.safar@seznam.cz>
2684 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
2686 2004-05-20 Martin Baulig <martin@ximian.com>
2688 * delegate.cs: Convert this file to Unix mode - like the original
2691 2004-05-20 Martin Baulig <martin@ximian.com>
2693 * attribute.cs: Convert this file to Unix mode - like the original
2696 2004-05-19 Marek Safar <marek.safar@seznam.cz>
2698 Fix bug #58688 (MCS does not report error when the same attribute
2701 * attribute.cs (Attribute.Emit): Distinction between null and default.
2703 2004-05-19 Raja R Harinath <rharinath@novell.com>
2705 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
2706 of a top-level attribute without an attribute target.
2707 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
2709 (Attribute.Conditional_GetConditionName),
2710 (Attribute.Obsolete_GetObsoleteMessage): Update.
2711 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
2712 part of ScanForIndexerName.
2713 (Attribute.CanIgnoreInvalidAttribute): New function.
2714 (Attribute.ScanForIndexerName): Move to ...
2715 (Attributes.ScanForIndexerName): ... here.
2716 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
2717 (Attributes.Search): New internal variant that can choose not to
2718 complain if types aren't resolved. The original signature now
2720 (Attributes.GetClsCompliantAttribute): Use internal variant, with
2721 complaints suppressed.
2722 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
2723 only if it not useful.
2724 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
2725 top-level for attributes that are shared between the assembly
2726 and a top-level class.
2727 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
2728 * class.cs: Update to reflect changes.
2729 (DefineIndexers): Fuse loops.
2730 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
2731 a couple more variants of attribute names.
2733 2004-05-18 Marek Safar <marek.safar@seznam.cz>
2735 Fix bug #52585 (Implemented explicit attribute declaration)
2738 (Attributable.ValidAttributeTargets): New abstract method. It gets
2739 list of valid attribute targets for explicit target declaration.
2740 (Attribute.Target): It holds target itself.
2741 (AttributeSection): Removed.
2742 (Attribute.CheckTargets): New method. It checks whether attribute
2743 target is valid for the current element.
2746 (EventProperty): New class. For events that are declared like
2747 property (with add and remove accessors).
2748 (EventField): New class. For events that are declared like field.
2751 * cs-parser.jay: Implemented explicit attribute target declaration.
2753 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
2754 Override ValidAttributeTargets.
2757 (ReturnParameter): Class for applying custom attributes on
2759 (ParameterAtribute): New class. Class for applying custom
2760 attributes on the parameter type.
2762 2004-05-17 Miguel de Icaza <miguel@ximian.com>
2764 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
2767 (Method): Allow UNSAFE here.
2769 * modifiers.cs: Support unsafe reporting.
2771 2004-05-17 Marek Safar <marek.safar@seznam.cz>
2773 * decl.cs: Fix bug #58478.
2775 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
2777 * statement.cs: When checking for unreachable code on an EmptyStatement,
2778 set the location. Fixes bug #58488.
2780 2004-05-13 Miguel de Icaza <miguel@ximian.com>
2782 * driver.cs: Add -pkg handling.
2784 From Gonzalo: UseShelLExecute=false
2786 2004-05-12 Marek Safar <marek.safar@seznam.cz>
2789 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
2791 (Attribute.IsClsCompliaceRequired): Moved to base for better
2793 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
2794 when attribute is AttributeUsageAttribute.
2795 (Attribute.GetValidTargets): Simplified.
2796 (Attribute.GetAttributeUsage): New method returns AttributeUsage
2797 attribute for this type.
2798 (Attribute.ApplyAttributes): Method renamed to Emit and make
2800 (GlobalAttributeSection): New class for special handling of global
2801 attributes (assembly, module).
2802 (AttributeSection.Emit): New method.
2804 * class.cs: Implemented Attributable abstract methods.
2805 (MethodCore.LabelParameters): Moved to Parameter class.
2806 (Accessor): Is back simple class.
2807 (PropertyMethod): Implemented Attributable abstract class.
2808 (DelegateMethod): Implemented Attributable abstract class.
2809 (Event): New constructor for disctintion between normal Event
2810 and Event with accessors.
2812 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
2814 * codegen.cs, const.cs, decl.cs, delegate.cs:
2815 (CommonAssemblyModulClass): Implemented Attributable abstract class
2818 * enum.cs: Implement IAttributeSupport interface.
2819 (EnumMember): New class for emum members. Implemented Attributable
2823 (ParameterBase): Is abstract.
2824 (ReturnParameter): New class for easier [return:] attribute handling.
2826 * typemanager.cs: Removed builder_to_attr.
2828 2004-05-11 Raja R Harinath <rharinath@novell.com>
2831 * attribute.cs (Attribute.GetPositionalValue): New function.
2832 * class.cs (TypeContainer.VerifyMembers): New function.
2833 (TypeContainer.Emit): Use it.
2834 (ClassOrStruct): New base class for Class and Struct.
2835 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
2836 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
2838 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
2839 then each non-static field should have a FieldOffset attribute.
2840 Otherwise, none of the fields should have a FieldOffset attribute.
2841 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
2842 and FieldOffset attributes.
2843 * typemanager.cs (TypeManager.struct_layout_attribute_type)
2844 (TypeManager.field_offset_attribute_type): New core types.
2845 (TypeManager.InitCoreTypes): Initialize them.
2847 2004-05-11 Michal Moskal <malekith@pld-linux.org>
2849 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
2850 Return correct type.
2853 2004-05-09 Miguel de Icaza <miguel@ximian.com>
2855 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
2856 be implicitly converted to ulong.
2858 * expression.cs: The logic for allowing operator &, | and ^ worked
2859 was wrong, it worked before because we did not report an error in
2860 an else branch. Fixes 57895.
2862 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
2863 allow volatile fields to be reference types.
2865 2004-05-07 Miguel de Icaza <miguel@ximian.com>
2867 * driver.cs: Add support for /debug-
2869 2004-05-07 Raja R Harinath <rharinath@novell.com>
2871 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
2872 Add a 'complain' parameter to silence errors.
2873 (Attribute.Resolve): Update to changes. Put in sanity check to catch
2874 silently overlooked type-resolutions.
2875 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
2877 (Attributes.Search): New function.
2878 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
2879 (Attributes.GetAttributeFullName): Remove hack.
2880 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
2881 Update to reflect changes.
2882 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
2883 Use Attributes.Search instead of nested loops.
2885 2004-05-07 Marek Safar <marek.safar@seznam.cz>
2888 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
2889 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
2890 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
2892 * report.cs: (Report.Warning): Renamed to Warning_T because of
2893 parameter collision.
2895 2004-05-05 Raja R Harinath <rharinath@novell.com>
2897 * expression.cs (MemberAccess.ResolveMemberAccess):
2898 Exit with non-zero status after Report.Error.
2899 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
2901 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
2903 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
2905 * support.cs: Don't hang when the file is empty.
2907 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
2909 * support.cs: In SeekableStreamReader, compute the preamble size of the
2910 underlying stream. Position changes should take into account that initial
2913 2004-05-03 Todd Berman <tberman@sevenl.net>
2915 * driver.cs: remove unused GetSysVersion function.
2917 2004-05-03 Todd Berman <tberman@sevenl.net>
2919 * driver.cs: Remove the hack from saturday, as well as the hack
2920 from jackson (LoadAssemblyFromGac), also adds the CWD to the
2921 link_paths to get that bit proper.
2923 2004-05-01 Todd Berman <tberman@sevenl.net>
2925 * driver.cs: Try a LoadFrom before a Load, this checks the current
2926 path. This is currently a bug in mono that is be fixed, however, this
2927 provides a workaround for now. This will be removed when the bug
2930 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
2932 * CryptoConvert.cs: Updated to latest version. Fix issue with
2933 incomplete key pairs (#57941).
2935 2004-05-01 Todd Berman <tberman@sevenl.net>
2937 * driver.cs: Remove '.' from path_chars, now System.* loads properly
2940 2004-04-30 Jackson Harper <jackson@ximian.com>
2942 * codegen.cs: Open keys readonly.
2944 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
2946 * typemanager.cs: don't report cyclic struct layout when a struct
2947 contains 2 or more fields of the same type. Failed for Pango.AttrShape
2948 which has 2 Pango.Rectangle fields.
2950 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
2952 * expression.cs: Handle IntPtr comparisons with IL code
2953 rather than a method call.
2955 2004-04-29 Martin Baulig <martin@ximian.com>
2957 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
2958 the list of PropertyInfo's in class hierarchy and find the
2959 accessor. Fixes #56013.
2961 2004-04-29 Martin Baulig <martin@ximian.com>
2963 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
2965 2004-04-29 Martin Baulig <martin@ximian.com>
2967 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
2969 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
2971 2004-04-29 Martin Baulig <martin@ximian.com>
2973 * class.cs (ConstructorInitializer.Resolve): Check whether the
2974 parent .ctor is accessible. Fixes #52146.
2976 2004-04-29 Martin Baulig <martin@ximian.com>
2978 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
2980 * statement.cs (Using.EmitLocalVariableDecls): Use
2981 TypeManager.idisposable_type, not typeof (IDisposable).
2982 (Foreach.EmitCollectionForeach): Added support for valuetypes.
2984 2004-04-29 Martin Baulig <martin@ximian.com>
2986 * class.cs (Event.Define): Don't emit the field and don't set
2987 RTSpecialName and SpecialName for events on interfaces. Fixes
2990 2004-04-29 Raja R Harinath <rharinath@novell.com>
2992 Refactor Attribute.ApplyAttributes.
2993 * attribute.cs (Attributable): New base class for objects that can
2994 have Attributes applied on them.
2995 (Attribute): Make AttributeUsage fields public.
2996 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
2997 (Attribute.IsInternalCall): New property.
2998 (Attribute.UsageAttr): Convert to a public read-only property.
2999 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
3000 (Attribute.ResolveType, Attribute.Resolve)
3001 (Attribute.ScanForIndexerName): Update to reflect changes.
3002 (Attribute.CheckAttributeTarget): Re-format.
3003 (Attribute.ApplyAttributes): Refactor, to various
3004 Attributable.ApplyAttributeBuilder methods.
3005 * decl.cs (MemberCore): Make Attributable.
3006 * class.cs (Accessor): Make Attributable.
3007 (MethodData.ApplyAttributes): Use proper attribute types, not
3009 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
3010 (TypeContainer.ApplyAttributeBuilder)
3011 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
3012 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
3013 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
3014 (Operator.ApplyAttributeBuilder): New factored-out methods.
3015 * const.cs (Const.ApplyAttributeBuilder): Likewise.
3016 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
3017 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
3018 * parameter.cs (ParameterBase): New Attributable base class
3019 that can also represent Return types.
3020 (Parameter): Update to the changes.
3022 2004-04-29 Jackson Harper <jackson@ximian.com>
3024 * driver.cs: Prefer the corlib system version when looking for
3025 assemblies in the GAC. This is still a hack, but its a better hack
3028 2004-04-29 Marek Safar <marek.safar@seznam.cz>
3030 * decl.cs, enum.cs: Improved error 3005 reporting.
3032 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
3033 (related_symbols): New private member for list of symbols
3034 related to reported error/warning.
3036 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
3038 2004-04-29 Martin Baulig <martin@ximian.com>
3040 * ecore.cs (Expression.Constantify): If we're an enum and
3041 TypeManager.TypeToCoreType() doesn't give us another type, use
3042 t.UnderlyingSystemType. Fixes #56178.
3044 2004-04-29 Martin Baulig <martin@ximian.com>
3046 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
3047 interfaces and for each interface, only add members directly
3048 declared in that interface. Fixes #53255.
3050 2004-04-28 Martin Baulig <martin@ximian.com>
3052 * expression.cs (ConditionalLogicalOperator): Use a temporary
3053 variable for `left' to avoid that we evaluate it more than once;
3056 2004-04-28 Martin Baulig <martin@ximian.com>
3058 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
3061 2004-04-28 Martin Baulig <martin@ximian.com>
3063 * statement.cs (LocalInfo.Resolve): Check whether the type is not
3066 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
3067 whether the type is not void (CS1547).
3069 2004-04-28 Martin Baulig <martin@ximian.com>
3071 * expression.cs (Unary.DoResolveLValue): Override this and report
3072 CS0131 for anything but Operator.Indirection.
3074 2004-04-28 Martin Baulig <martin@ximian.com>
3076 Committing a patch from Ben Maurer; see bug #50820.
3078 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
3081 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
3084 2004-04-28 Martin Baulig <martin@ximian.com>
3086 Committing a patch from Ben Maurer; see bug #50820.
3088 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
3091 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
3094 2004-04-28 Martin Baulig <martin@ximian.com>
3096 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
3097 (Block.AddLabel): Call DoLookupLabel() to only search in the
3100 2004-04-28 Martin Baulig <martin@ximian.com>
3102 * cfold.cs (ConstantFold.BinaryFold): Added special support for
3103 comparing StringConstants and NullLiterals in Equality and Inequality.
3105 2004-04-28 Jackson Harper <jackson@ximian.com>
3107 * driver.cs: Attempt to load referenced assemblies from the
3108 GAC. This is the quick and dirty version of this method that
3109 doesnt take into account versions and just takes the first
3110 canidate found. Will be good enough for now as we will not have more
3111 then one version installed into the GAC until I update this method.
3113 2004-04-28 Martin Baulig <martin@ximian.com>
3115 * typemanager.cs (TypeManager.CheckStructCycles): New public
3116 static method to check for cycles in the struct layout.
3118 * rootcontext.cs (RootContext.PopulateTypes): Call
3119 TypeManager.CheckStructCycles() for each TypeContainer.
3120 [Note: We only need to visit each type once.]
3122 2004-04-28 Martin Baulig <martin@ximian.com>
3124 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
3126 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
3127 success and added `out object value'. Use a `bool resolved' field
3128 to check whether we've already been called rather than
3129 `ConstantValue != null' since this breaks for NullLiterals.
3131 2004-04-28 Raja R Harinath <rharinath@novell.com>
3133 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
3134 setting of this flag, since the 'set' method may be non-public.
3136 2004-04-28 Raja R Harinath <rharinath@novell.com>
3138 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
3139 check on current_vector.Block.
3141 2004-04-27 Martin Baulig <martin@ximian.com>
3143 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
3144 a field initializer. Fixes #56459.
3146 2004-04-27 Martin Baulig <martin@ximian.com>
3148 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
3149 we're not attempting to use an indexer. Fixes #52154.
3151 2004-04-27 Martin Baulig <martin@ximian.com>
3153 * statement.cs (Return): Don't create a return label if we don't
3154 need it; reverts my change from January 20th. Thanks to Ben
3157 2004-04-27 Martin Baulig <martin@ximian.com>
3159 According to the spec, `goto' can only leave a nested scope, but
3162 * statement.cs (Block.LookupLabel): Only lookup in the current
3163 block, don't recurse into parent or child blocks.
3164 (Block.AddLabel): Check in parent and child blocks, report
3165 CS0140/CS0158 if we find a duplicate.
3166 (Block): Removed this indexer for label lookups.
3167 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
3168 this already does the error reporting for us.
3171 (FlowBranching.UsageVector.Block): New public variable; may be null.
3172 (FlowBranching.CreateSibling): Added `Block' argument.
3173 (FlowBranching.LookupLabel): New public virtual method. Lookup a
3174 label for the target of a `goto' and check whether we're not
3175 leaving a `finally'.
3177 2004-04-27 Martin Baulig <martin@ximian.com>
3179 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
3180 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
3183 2004-04-27 Martin Baulig <martin@ximian.com>
3185 * statement.cs (Block.AddLabel): Also check for implicit blocks
3186 and added a CS0158 check.
3188 2004-04-27 Martin Baulig <martin@ximian.com>
3190 * flowanalysis.cs (FlowBranchingLoop): New class.
3191 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
3192 UsageVector's instead of an ArrayList.
3193 (FlowBranching.Label): Likewise.
3194 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
3195 (FlowBranching.AddBreakVector): New method.
3197 2004-04-27 Miguel de Icaza <miguel@ximian.com>
3199 * attribute.cs: Small regression fix: only convert the type if we
3200 the type is different, fixes System.Drawing build.
3202 2004-04-27 Martin Baulig <martin@ximian.com>
3204 * attribute.cs (Attribute.Resolve): If we have a constant value
3205 for a named field or property, implicity convert it to the correct
3208 2004-04-27 Raja R Harinath <rharinath@novell.com>
3210 * statement.cs (Block.Block): Implicit blocks share
3211 'child_variable_names' fields with parent blocks.
3212 (Block.AddChildVariableNames): Remove.
3213 (Block.AddVariable): Mark variable as "used by a child block" in
3214 every surrounding block.
3215 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
3216 been used in a child block, complain about violation of "Invariant
3217 meaning in blocks" rule.
3218 * cs-parser.jay (declare_local_variables): Don't use
3219 AddChildVariableNames.
3220 (foreach_statement): Don't create an implicit block: 'foreach'
3223 2004-04-23 Miguel de Icaza <miguel@ximian.com>
3225 * convert.cs (ImplicitNumericConversion): 0 is also positive when
3226 converting from 0L to ulong. Fixes 57522.
3228 2004-04-22 Marek Safar <marek.safar@seznam.cz>
3230 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
3231 derived class hides via 'new' keyword field from base class (test-242.cs).
3232 TODO: Handle this in the more general way.
3234 * class.cs (CheckBase): Ditto.
3236 2004-04-22 Marek Safar <marek.safar@seznam.cz>
3238 * decl.cs (caching_flags): New member for storing cached values
3240 (MemberCore.Flags): New enum where bit flags for caching_flags
3242 (MemberCore.cls_compliance): Moved to caching_flags.
3243 (DeclSpace.Created): Moved to caching_flags.
3245 * class.cs: Use caching_flags instead of DeclSpace.Created
3247 2004-04-21 Miguel de Icaza <miguel@ximian.com>
3249 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
3250 if we are only a derived class, not a nested class.
3252 * typemanager.cs: Same as above, but do this at the MemberLookup
3253 level (used by field and methods, properties are handled in
3254 PropertyExpr). Allow for the qualified access if we are a nested
3257 2004-04-21 Marek Safar <marek.safar@seznam.cz>
3259 * class.cs: Refactoring.
3260 (IMethodData): New inteface; Holds links to parent members
3261 to avoid member duplication (reduced memory allocation).
3262 (Method): Implemented IMethodData interface.
3263 (PropertyBase): New inner classes for get/set methods.
3264 (PropertyBase.PropertyMethod): Implemented IMethodData interface
3265 (Event): New inner classes for add/remove methods.
3266 (Event.DelegateMethod): Implemented IMethodData interface.
3268 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
3269 EmitContext (related to class.cs refactoring).
3271 2004-04-21 Raja R Harinath <rharinath@novell.com>
3273 * delegate.cs (Delegate.VerifyApplicability): If the number of
3274 arguments are the same as the number of parameters, first try to
3275 verify applicability ignoring any 'params' modifier on the last
3279 2004-04-08 Martin Baulig <martin@ximian.com>
3281 Merged latest changes into gmcs. Please keep this comment in
3282 here, it makes it easier for me to see what changed in MCS since
3283 the last time I merged.
3285 2004-04-16 Raja R Harinath <rharinath@novell.com>
3287 * class.cs (TypeContainer.AddIndexer): Use
3288 'ExplicitInterfaceName' to determine if interface name was
3289 explicitly specified. 'InterfaceType' is not initialized at this time.
3290 (TypeContainer.DefineIndexers): Remove use of temporary list. The
3291 Indexers array is already in the required order. Initialize
3292 'IndexerName' only if there are normal indexers.
3293 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
3294 (TypeContainer.Emit): Emit DefaultMember attribute only if
3295 IndexerName is initialized.
3298 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
3300 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
3303 2004-04-15 Raja R Harinath <rharinath@novell.com>
3305 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
3309 * attribute.cs (Attribute.Resolve): Check for duplicate named
3313 2004-04-15 Miguel de Icaza <miguel@ximian.com>
3315 * iterators.cs (MarkYield): track whether we are in an exception,
3316 and generate code accordingly. Use a temporary value to store the
3317 result for our state.
3319 I had ignored a bit the interaction of try/catch with iterators
3320 since their behavior was not entirely obvious, but now it is
3321 possible to verify that our behavior is the same as MS .NET 2.0
3325 2004-04-14 Miguel de Icaza <miguel@ximian.com>
3327 * iterators.cs: Avoid creating temporaries if there is no work to
3330 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
3331 Enumerations, use TypeManager.EnumToUnderlying and call
3334 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
3337 (This.Emit): Use EmitContext.EmitThis to emit our
3340 (This.EmitAssign): Ditto.
3342 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
3343 codepaths, we will move all the functionality into
3346 (FieldExpr.EmitAssign): Ditto.
3348 This fixes several hidden bugs that I uncovered while doing a code
3349 review of this today.
3351 * codegen.cs (EmitThis): reworked so the semantics are more clear
3352 and also support value types "this" instances.
3354 * iterators.cs: Changed so that for iterators in value types, we
3355 do not pass the value type as a parameter.
3357 Initialization of the enumerator helpers is now done in the caller
3358 instead of passing the parameters to the constructors and having
3359 the constructor set the fields.
3361 The fields have now `assembly' visibility instead of private.
3363 2004-04-11 Miguel de Icaza <miguel@ximian.com>
3365 * expression.cs (Argument.Resolve): Check if fields passed as ref
3366 or out are contained in a MarshalByRefObject.
3368 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
3369 another compiler type.
3371 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
3373 * class.cs (Indexer.Define): use the new name checking method.
3374 Also, return false on an error.
3375 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
3376 (is_identifier_[start/part]_character): make static.
3378 2004-04-10 Miguel de Icaza <miguel@ximian.com>
3380 * expression.cs (Binary.ResolveOperator): Do no append strings
3381 twice: since we can be invoked more than once (array evaluation)
3382 on the same concatenation, take care of this here. Based on a fix
3383 from Ben (bug #56454)
3385 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
3387 * codegen.cs: Fix another case where CS1548 must be reported (when
3388 delay-sign isn't specified and no private is available #56564). Fix
3389 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
3390 error when MCS is used on the MS runtime and we need to delay-sign
3391 (which seems unsupported by AssemblyBuilder - see #56621).
3393 2004-04-08 Marek Safar <marek.safar@seznam.cz>
3395 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
3396 (TypeManager.ComputeNamespaces): Faster implementation for
3399 * compiler.csproj: Updated AssemblyName to mcs.
3401 2004-05-11 Jackson Harper <jackson@ximian.com>
3403 * Makefile: Preserve MONO_PATH
3405 2004-05-11 Jackson Harper <jackson@ximian.com>
3407 * Makefile: Use mono and mcs to build gmcs
3409 2004-05-03 Miguel de Icaza <miguel@ximian.com>
3411 * codegen.cs: Add patch from Robert Shade
3412 <rshade@dvsconsulting.com>, use FileAccess.Read on the keyfile, to
3415 2004-05-02 Sebastien Pouliot <sebastien@ximian.com>
3417 * CryptoConvert.cs: Updated to latest version. Fix issue with
3418 incomplete key pairs (#57941).
3420 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
3422 * codegen.cs: Fix another case where CS1548 must be reported (when
3423 delay-sign isn't specified and no private is available #56564). Fix
3424 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
3425 error when MCS is used on the MS runtime and we need to delay-sign
3426 (which seems unsupported by AssemblyBuilder - see #56621).
3428 2004-04-29 Jackson Harper <jackson@ximian.com>
3430 * Makefile: Set MONO_PATH to use the bootstrap corlib
3431 * driver.cs: Check the GAC for referenced assemblies.
3433 2004-04-29 Martin Baulig <martin@ximian.com>
3435 * Makefile (gmcs.exe): Set MONO_PATH to use `../class/lib/net_2_0'.
3437 2004-04-07 Martin Baulig <martin@ximian.com>
3439 * expression.cs (Binary.ResolveOperator): Added special case for
3440 Equality/Inequality between a type parameter and a null literal.
3442 2004-04-07 Martin Baulig <martin@ximian.com>
3444 * convert.cs: Check null literal -> type parameter conversions.
3446 2004-04-07 Martin Baulig <martin@ximian.com>
3448 * generic.cs (ConstructedType.CheckConstraints): Enforce the
3449 `class' and `struct' constraints.
3451 2004-04-07 Martin Baulig <martin@ximian.com>
3453 * generic.cs (SpecialConstraint): New public enum.
3454 (Constraints.Resolve): Added support for the `class' and `struct'
3457 * cs-parser.jay (type_parameter_constraint): Added support for the
3458 `class' and `struct' constraints.
3460 2004-04-07 Martin Baulig <martin@ximian.com>
3462 * support.cs (GenericConstraints): Replaced `Types' by
3463 `ClassConstraint' and `InterfaceConstraints'; added
3464 `HasClassConstraint'.
3466 2004-04-07 Martin Baulig <martin@ximian.com>
3469 (Constraints.InterfaceConstraints): New public property.
3470 (Constraints.Types): Make this property public
3471 (TypeParameter): Implement IMemberContainer.
3472 (TypeParameter.Define): Take a `GenericTypeParameterBuilder'
3473 instead of a TypeBuilder/MethodBuilder; pass the interface
3474 constraints to TypeManager.AddTypeParameter().
3475 (TypeParameter.DefineType): Just take an EmitContext and no
3476 TypeBuilder/MethodBuilder. Use the new public API.
3478 * typemanager.cs (TypeManager.AddTypeParameter): Added
3479 `TypeExpr[]' argument; add the interfaces to the
3480 `builder_to_ifaces' hash.
3481 (TypeManager.LookupMemberContainer): For
3482 GenericTypeParameterBuilders, get the TypeParameter from the
3483 `builder_to_type_param'.
3484 (TypeManager.FindMembers): For GenericTypeParameterBuilders, get
3485 the TypeParameter and call FindMembers on it.
3487 2004-04-07 Martin Baulig <martin@ximian.com>
3490 (MethodCore.GenericMethod): Moved this field here from Method.
3491 (MethodCore.IsDuplicateImplementation): Take the number of type
3492 parameters into account if we're a generic method.
3494 * expression.cs (Invocation.InferTypeArguments): Don't return true
3495 if `arguments' is null; we still need to check whether we actually
3496 don't need to infer anything in this case.
3497 (MemberAccess): Merged the functionality from GenericMemberAccess
3500 * generic.cs (GenericMemberAccess): Removed.
3502 2004-04-05 Martin Baulig <martin@ximian.com>
3504 * decl.cs (MemberCore): For generic classes, interfaces and
3505 structs, `Name' now includes the number of type parameters
3507 (DeclSpace.FindType): Removed the `num_type_args' argument; we now
3508 encode the number of type arguments in the type name.
3510 * expression.cs (Expression.MemberLookup): Removed the
3511 `num_type_args' argument; we now encode the number of type
3512 arguments in the type name.
3514 * ecore.cs (SimpleName): Encode the number of type arguments in
3515 the type name itself.
3517 * generic.cs (ConstructedType): Likewise.
3519 * tree.cs (Tree.RecordDecl): Take a `string' instead of a
3520 `MemberName'; we now include the number of type parameters in the
3523 * typemanager.cs (TypeManager.CheckGeneric): Removed.
3524 (TypeManager.MemberLookup): Removed the
3525 `num_type_args' argument; we now encode the number of type
3526 arguments in the type name.
3528 2004-04-03 Martin Baulig <martin@ximian.com>
3530 * decl.cs (MemberCore.ctor): Take a MemberName instead of a sting.
3531 (MemberCore.MemberName): Moved here from MemberBase.
3532 (DeclSpace.SetParameterInfo): Just take the constraints as an
3533 ArrayList; we already have the type parameters in our
3534 `MemberName'; also do the CS0080 reporting here.
3536 * cs-parser.jay (struct_declaration): Use `member_name' instead of
3537 `IDENTIFIER opt_type_parameter_list'; when constructing our
3538 `MemberName', it'll already include our type parameters.
3539 (class_declaration, interface_declaration): Likewise.
3540 (delegate_declaration): Likewise.
3541 (MakeName): Take a MemberName and return a MemberName.
3542 The following two changes are required to avoid shift/reduce conflicts:
3543 (member_name): Don't include a TypeName anymore; ie. this is now
3544 just 'IDENTIFIER opt_type_parameter_list'.
3545 (property_declaration, event_declaration): Use a
3546 `namespace_or_type_name' instead of a `member_name'.
3548 2004-04-03 Martin Baulig <martin@ximian.com>
3550 * decl.cs (MemberName): Renamed to `TypeName' and created a new
3552 (TypeName): Formerly known as MemberName.
3554 * namespace.cs (NamespaceEntry.UsingAlias): Take a `TypeName'
3555 instead of a `MemberName'.
3557 * cs-parser.jay (namespace_or_type_name): Create a TypeName.
3558 (member_name): New rule; create a MemberName.
3560 2004-04-02 Martin Baulig <martin@ximian.com>
3562 * namespace.cs (NamespaceEntry.VerifyUsing): Added error checking
3563 (CS0305 and CS0308).
3565 2004-04-02 Martin Baulig <martin@ximian.com>
3567 * generic.cs (GenericMemberAccess.ResolveAsTypeStep): Added
3568 support for nested types.
3570 2004-04-02 Martin Baulig <martin@ximian.com>
3572 * ecore.cs (IAlias): New public interface.
3573 (TypeExpr, TypeExpression): Implement IAlias.
3574 (TypeAliasExpression): New public class.
3576 * namespace.cs (Namespace): Implement IAlias.
3577 (Namespace.Lookup): Return an IAlias instead on an object.
3578 (Namespace.DefineName): Take an IAlias instead of an object.
3579 (NamespaceEntry.AliasEntry.Resolve): Return an IAlias instead of
3581 (NamespaceEntry.UsingAlias): Take a Membername instead of an
3583 (NamespaceEntry.LookupAlias): Return an IAlias instead on an
3585 (NamespaceEntry.Lookup): Likewise.
3587 * rootcontext.cs (RootContext.LookupType): Return a TypeExpr
3590 * decl.cs (DeclSpace): Implement IAlias.
3591 (DeclSpace.LookupAlias): Return an IAlias instead of a string.
3593 * generic.cs (ConstructedType): Improved error checking.
3595 2004-04-02 Martin Baulig <martin@ximian.com>
3597 * convert.cs: Added type parameter conversions.
3600 (UnboxCast.Emit): Emit an `unbox.any' for type params.
3601 (ClassCast.Emit): If the source type is a type parameter, box it.
3602 If the target type is a type parameter, emit an `unbox.any'
3603 instead of a `classcast'.1
3605 2004-04-01 Martin Baulig <martin@ximian.com>
3607 * cs-tokenizer.cs (parse_less_than): Allow Token.DOT.
3609 2004-04-01 Martin Baulig <martin@ximian.com>
3611 * generic.cs (ConstructedType.CheckConstraints): Use
3612 Convert.ImplicitStandardConversionExists(); user-defined implicit
3613 conversions are not allowed according to the spec.
3615 2004-03-30 Martin Baulig <martin@ximian.com>
3617 * expression.cs (New): Added support for type parameters.
3620 (TypeManager.activator_type): New public static field.
3621 (TypeManager.activator_create_instance): Likewise.
3623 2004-03-30 Martin Baulig <martin@ximian.com>
3625 * typemanager.cs (TypeManager.HasConstructorConstraint): New
3628 2004-03-30 Martin Baulig <martin@ximian.com>
3630 * generic.cs (ConstructedType.CheckConstraints): Actually follow
3631 the spec here: the argument type must be convertible to the
3634 2004-03-30 Martin Baulig <martin@ximian.com>
3637 (TypeParameter.Define, TypeParameter.DefineMethod): Call
3638 TypeManager.AddTypeParameter().
3639 (ConstructedType.CheckConstraints): Re-enable this and actually
3640 check whether we have a constructor constraint.
3643 (TypeManager.builder_to_type_param): New static field.
3644 (TypeManager.AddTypeParameter): New static method.
3645 (TypeManager.LookupTypeParameter): New public method.
3647 2004-03-30 Martin Baulig <martin@ximian.com>
3649 * generic.cs (TypeParameter.DefineType): Return a boolean and use
3650 the new API to actually define the constructor constraint.
3653 (TypeManager.new_constraint_attr_type): New static field.
3654 (TypeManager.InitCoreTypes): Initialize it.
3656 2004-03-30 Martin Baulig <martin@ximian.com>
3658 * generic.cs (Constraints): Completed error checking, use correct
3661 2004-03-29 Martin Baulig <martin@ximian.com>
3663 * delegate.cs (Delegate.VerifyMethod): Infer type arguments.
3665 * expression.cs (Invocation.InferTypeArguments): Added overloaded
3666 public version which takes a `ParameterData pd' instead of an
3669 2004-03-29 Martin Baulig <martin@ximian.com>
3671 * typemanager.cs (TypeManager.IsGenericMethod): Take a MethodBase,
3674 2004-03-29 Martin Baulig <martin@ximian.com>
3676 * expression.cs (Argument.ResolveMethodGroup): If we're a
3677 ConstructedType, call GetMemberAccess() on it.
3679 2004-03-29 Martin Baulig <martin@ximian.com>
3681 * class.cs (MethodBase.CheckGenericOverride): New abstract method.
3682 (MethodCore.CheckGenericOverride): When overriding a generic
3683 method, check whether the constraints match.
3685 * support.cs (GenericConstraints): New public interface.
3686 (ParameterData.GenericConstraints): New public method.
3688 * parameter.cs (Parameter.Resolve): Check whether we're a generic
3689 method parameter and compute our constraints if appropriate.
3690 (Parameter.GenericConstraints): New public property.
3692 * generic.cs (Constraints): Implement GenericConstraints.
3694 2004-03-29 Martin Baulig <martin@ximian.com>
3696 * decl.cs (MemberCache.FindMemberToOverride): Use
3697 `paramTypes [j].Equals (cmpAttrs [j])' instead of `=='.
3699 2004-03-29 Martin Baulig <martin@ximian.com>
3701 * generic.cs (GenericMethod.Define): Resolve our type parameters.
3703 2004-03-29 Martin Baulig <martin@ximian.com>
3705 * cs-parser.jay: Report CS0080 instead of -200 ("Constraints are
3706 not allowed on non-generic declarations").
3708 2004-03-29 Martin Baulig <martin@ximian.com>
3710 * expression.cs (Invocation.InferTypeArguments): Added overloaded
3711 public version of this method.
3713 * class.cs (MethodCore.IsDuplicateImplementation): Use
3714 Invocation.InferTypeArguments() to check this.
3716 2004-03-29 Martin Baulig <martin@ximian.com>
3718 * convert.cs: Use TypeManager.IsDelegateType() instead of
3719 comparing types correctly.
3721 2004-03-29 Martin Baulig <martin@ximian.com>
3723 * convert.cs: Use TypeManager.IsSubclassOf() instead of comparing
3724 types directly to make it work for generic instances.
3726 * typemanager.cs (TypeManager.IsSubclassOf): New static method.
3728 2004-03-29 Martin Baulig <martin@ximian.com>
3730 * typemanager.cs (TypeManager.MayBecomeEqualGenericTypes): Added
3733 2004-03-24 Martin Baulig <martin@ximian.com>
3735 * decl.cs (DeclSpace.FindType): Also use
3736 TypeManager.CheckGeneric() for types from the using clauses.
3738 2004-03-23 Martin Baulig <martin@ximian.com>
3740 * expression.cs (Invocation.OverloadResolve): Added `bool
3741 may_fail' argument and use it instead of the Location.IsNull() hack.
3743 2004-03-23 Martin Baulig <martin@ximian.com>
3745 * expression.cs (Invocation.InferType): Use correct type inference
3748 2004-03-23 Martin Baulig <martin@ximian.com>
3750 * ecore.cs (MethodGroupExpr.Name): Use
3751 TypeManager.CSharpSignature() instead of just the name.
3753 * expression.cs (Invocation.OverloadResolve): Provide better error
3755 (Invocation.DoResolve): OverloadResolve() never returns null
3756 without reporting an error, so removed the error -6 reporting here.
3758 2004-03-23 Martin Baulig <martin@ximian.com>
3760 * typemanager.cs (TypeManager.GetMethodFlags): Fixed the FIXME for
3763 * cs-parser.jay (delegate_declaration): Support generic delegates.
3765 * delegate.cs: Support generic delegates.
3767 2004-03-22 Martin Baulig <martin@ximian.com>
3769 * expression.cs (Invocation.InferParamsTypeArguments): New static
3770 method; does type inference for params arguments.
3772 2004-03-21 Martin Baulig <martin@ximian.com>
3774 * typemanager.cs (TypeManager.IsGenericMethod): New public static
3775 method; checks whether a method is a generic method.
3777 * expression.cs (Invocation.InferTypeArguments): New static method;
3778 infer type arguments for generic method invocation.
3780 * ecore.cs (MethodGroupExpr.HasTypeArguments): New public
3781 property; we set this to true if we're resolving a generic method
3782 invocation and the user specified type arguments, ie. we're not
3783 doing type inference.
3785 2004-03-20 Martin Baulig <martin@ximian.com>
3787 * class.cs (MethodData.DeclaringType): New public property.
3788 (MethodData.Define): Set DeclaringType here.
3789 (Operator.Define): Use OperatorMethod.MethodData.DeclaringType
3790 instead of OperatorMethodBuilder.DeclaringType.
3792 2004-03-20 Martin Baulig <martin@ximian.com>
3794 * cs-tokenizer.cs (xtoken): Return a special
3795 Token.DEFAULT_OPEN_PARENS for "`default' followed by open parens".
3797 * cs-parser.jay (default_value_expression): Switch to the new
3800 2004-03-19 Martin Baulig <martin@ximian.com>
3802 * decl.cs (MemberName): New class. We use this to "construct"
3803 namespace_or_type_name's.
3805 * generics.cs (TypeArguments.GetDeclarations): New public method;
3806 returns the type arguments as a string[] and reports a CS0081 if
3807 one of them is not an identifier.
3809 * class.cs (MemberBase): The .ctor now takes the name as a
3810 MemberName instead of a string.
3811 (MemberBase.ExplicitInterfaceName): Changed type from string to
3813 (MemberBase.DoDefine): If we're an explicit implementation, the
3814 InterfaceType may be a generic instance.
3816 * cs-parser.jay (namespace_or_type_name): Return a MemberName.
3817 (namespace_name): Call MemberName.GetName () to transform the
3818 MemberName into a string and ensure we don't have any type
3820 (type_name): Call MemberName.GetTypeExpression() to transfrom the
3821 MemberName into an expression.
3822 (method_header): Use namespace_or_type_name instead of member_name.
3824 2004-04-07 Miguel de Icaza <miguel@ximian.com>
3826 * rootcontext.cs: Add new types to the boot resolution.
3828 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
3829 MulticastDelegate is not allowed.
3831 * typemanager.cs: Add new types to lookup: System.TypedReference
3834 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
3835 check for TypedReference or ArgIterator, they are not allowed.
3837 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
3838 makes us properly catch 1510 in some conditions (see bug 56016 for
3841 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
3843 * CryptoConvert.cs: update from corlib version
3846 2004-04-05 Miguel de Icaza <miguel@ximian.com>
3848 * class.cs (Indexer.Define): Check indexername declaration
3850 2004-04-05 Marek Safar <marek.safar@seznam.cz>
3852 * attribute.cs (IsClsCompliant): Fixed problem with handling
3853 all three states (compliant, not-compliant, undetected).
3855 2004-03-30 Marek Safar <marek.safar@seznam.cz>
3857 * attribute.cs (Attribute): Location is now public.
3858 (Resolve): Store resolved arguments (pos_values) in attribute class.
3859 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
3860 (GetClsCompliantAttributeValue): New method that gets
3861 CLSCompliantAttribute value.
3862 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
3863 if exists else null.
3864 (AttributeTester): New class for CLS-Compliant verification routines.
3866 * class.cs (Emit): Add CLS-Compliant verification.
3867 (Method.GetSignatureForError): Implemented.
3868 (Constructor.GetSignatureForError): Implemented
3869 (Constructor.HasCompliantArgs): Returns if constructor has
3870 CLS-Compliant arguments.
3871 (Constructor.Emit): Override.
3872 (Construcor.IsIdentifierClsCompliant): New method; For constructors
3873 is needed to test only parameters.
3874 (FieldBase.GetSignatureForError): Implemented.
3875 (TypeContainer): New member for storing base interfaces.
3876 (TypeContainer.FindMembers): Search in base interfaces too.
3878 * codegen.cs (GetClsComplianceAttribute): New method that gets
3879 assembly or module CLSCompliantAttribute value.
3880 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
3882 (ModuleClass.Emit): Add error 3012 test.
3884 * const.cs (Emit): Override and call base for CLS-Compliant tests.
3886 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
3887 state for all decl types.
3888 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
3889 if CLS-Compliant tests are required.
3890 (IsClsCompliaceRequired): New method. Analyze whether code
3891 must be CLS-Compliant.
3892 (IsExposedFromAssembly): New method. Returns true when MemberCore
3893 is exposed from assembly.
3894 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
3895 value or gets cached value.
3896 (HasClsCompliantAttribute): New method. Returns true if MemberCore
3897 is explicitly marked with CLSCompliantAttribute.
3898 (IsIdentifierClsCompliant): New abstract method. This method is
3899 used to testing error 3005.
3900 (IsIdentifierAndParamClsCompliant): New method. Common helper method
3901 for identifier and parameters CLS-Compliant testing.
3902 (VerifyClsCompliance): New method. The main virtual method for
3903 CLS-Compliant verifications.
3904 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
3905 null. I don't know why is null (too many public members !).
3906 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
3907 and get value of first CLSCompliantAttribute that found.
3909 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
3910 (VerifyClsCompliance): Override and add extra tests.
3912 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
3913 clscheck- disable CLS-Compliant verification event if assembly is has
3914 CLSCompliantAttribute(true).
3916 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
3917 ApllyAttribute is now called in emit section as in the other cases.
3918 Possible future Emit integration.
3919 (IsIdentifierClsCompliant): New override.
3920 (VerifyClsCompliance): New override.
3921 (GetEnumeratorName): Returns full enum name.
3923 * parameter.cs (GetSignatureForError): Implemented.
3925 * report.cs (WarningData): New struct for Warning message information.
3926 (LocationOfPreviousError): New method.
3927 (Warning): New method. Reports warning based on the warning table.
3928 (Error_T): New method. Reports error based on the error table.
3930 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
3931 verifications are done here.
3933 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
3935 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
3936 CLSCompliantAttribute.
3937 (all_imported_types): New member holds all imported types from other
3939 (LoadAllImportedTypes): New method fills static table with exported types
3940 from all referenced assemblies.
3941 (Modules): New property returns all assembly modules.
3943 2004-03-30 Miguel de Icaza <miguel@ximian.com>
3945 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
3946 throwing a parser error.
3948 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
3949 which removes the hardcoded get_/set_ prefixes for properties, as
3950 IL allows for the properties to be named something else.
3954 * expression.cs: Do not override operand before we know if it is
3957 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
3959 * typemanager.cs: support for pinned variables.
3961 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
3963 * decl.cs, typemanager.cs: Avoid using an arraylist
3964 as a buffer if there is only one result set.
3966 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
3968 * expression.cs: Make sure you cant call a static method
3969 with an instance expression, bug #56174.
3971 2004-03-29 Miguel de Icaza <miguel@ximian.com>
3973 * class.cs (IsDuplicateImplementation): Improve error reporting to
3974 flag 663 (method only differs in parameter modifier).
3976 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
3977 in preprocessor directives.
3979 * location.cs (LookupFile): Allow for the empty path.
3981 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
3982 better approach for some of that patch, but its failing with the
3983 CharSet enumeration. For now try/catch will do.
3985 * typemanager.cs: Do not crash if a struct does not have fields.
3988 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
3990 * expression.cs: cs0213, cant fix a fixed expression.
3993 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
3995 * cs-parser.jay: detect invalid embeded statements gracefully.
3998 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
4000 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
4003 the invocation type may not be a subclass of the tye of the item/
4004 The type of the item must be a subclass of the invocation item.
4009 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
4011 * attribute.cs: Added methods to get a string and a bool from an
4012 attribute. Required to information from AssemblyKeyFileAttribute,
4013 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
4014 * codegen.cs: Modified AssemblyName creation to include support for
4015 strongnames. Catch additional exceptions to report them as CS1548.
4016 * compiler.csproj: Updated include CryptoConvert.cs.
4017 * compiler.csproj.user: Removed file - user specific configuration.
4018 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
4019 Mono.Security assembly. The original class is maintained and tested in
4020 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
4021 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
4022 like CSC 8.0 (C# v2) supports.
4023 * Makefile: Added CryptoConvert.cs to mcs sources.
4024 * rootcontext.cs: Added new options for strongnames.
4026 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
4028 * driver.cs: For --expect-error, report error code `2'
4029 if the program compiled with no errors, error code `1' if
4030 it compiled with an error other than the one expected.
4032 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
4034 * compiler.csproj: Updated for Visual Studio .NET 2003.
4035 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
4036 * compiler.sln: Updated for Visual Studio .NET 2003.
4038 2004-03-24 Ravi Pratap M <ravi@ximian.com>
4040 * expression.cs: Fix bug #47234. We basically need to apply the
4041 rule that we prefer the conversion of null to a reference type
4042 when faced with a conversion to 'object' (csc behaviour).
4044 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
4046 * statement.cs: Shorter form for foreach, eliminates
4047 a local variable. r=Martin.
4049 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
4051 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
4052 checks if we can use brtrue/brfalse to test for 0.
4053 * expression.cs: use the above in the test for using brtrue/brfalse.
4056 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
4058 * expression.cs: Rewrite string concat stuff. Benefits:
4060 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
4061 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
4062 rather than a concat chain.
4064 * typemanager.cs: Add lookups for more concat overloads.
4066 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
4068 * expression.cs: Emit shorter il code for array init.
4085 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
4087 * statement.cs: Before, two switch blocks would be merged if the
4088 total size of the blocks (end_item - begin_item + 1) was less than
4089 two times the combined sizes of the blocks.
4091 Now, it will only merge if after the merge at least half of the
4096 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
4098 * class.cs : csc build fix for GetMethods(). See bug #52503.
4100 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
4102 * expression.cs: Make sure fp comparisons work with NaN.
4103 This fixes bug #54303. Mig approved this patch a long
4104 time ago, but we were not able to test b/c the runtime
4107 2004-03-19 Miguel de Icaza <miguel@ximian.com>
4109 * ecore.cs (TypExpr.GetHashCode): implement this overload.
4111 2004-03-19 Martin Baulig <martin@ximian.com>
4113 * class.cs (MemberCore.IsDuplicateImplementation): Check whether
4114 two overloads may unify for some type parameter substitutions and
4115 report a CS0408 if appropriate.
4117 2004-03-19 Martin Baulig <martin@ximian.com>
4119 * class.cs (MemberCore.IsDuplicateImplementation): Report the
4120 error here and not in our caller.
4122 2004-03-19 Martin Baulig <martin@ximian.com>
4124 * interface.cs: Completely killed this file.
4125 (Interface): We're now a TypeContainer and live in class.cs.
4127 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
4128 argument; we're now also called for interfaces.
4129 (TypeContainer.DefineMembers): Allow this method being called
4131 (TypeContainer.GetMethods): New public method; formerly known as
4132 Interface.GetMethod(). This is used by PendingImplementation.
4133 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
4134 it's now private and non-static.
4135 (Interface): Moved this here; it's now implemented similar to
4137 (Method, Property, Event, Indexer): Added `bool is_interface'
4138 argument to their .ctor's.
4139 (MemberBase.IsInterface): New public field.
4141 * cs-parser.jay: Create normal Method, Property, Event, Indexer
4142 instances instead of InterfaceMethod, InterfaceProperty, etc.
4143 (opt_interface_base): Removed; we now use `opt_class_base' instead.
4144 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
4146 2004-03-19 Martin Baulig <martin@ximian.com>
4148 * class.cs (MethodCore.IsDuplicateImplementation): New private
4149 method which does the CS0111 checking.
4150 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
4151 Use IsDuplicateImplementation().
4153 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
4155 * decl.cs (FindMemberToOverride): New method to find the correct
4156 method or property to override in the base class.
4158 - Make Method/Property use the above method to find the
4159 version in the base class.
4160 - Remove the InheritableMemberSignatureCompare as it is now
4163 This patch makes large code bases much faster to compile, as it is
4164 O(n) rather than O(n^2) to do this validation.
4166 Also, it fixes bug 52458 which is that nested classes are not
4167 taken into account when finding the base class member.
4169 Reviewed/Approved by Martin.
4171 2004-03-17 Martin Baulig <martin@ximian.com>
4173 * expression.cs (MemberAccess.DoResolve): Take the parent's number
4174 of type arguments into account; use the `real_num_type_args'
4175 approach like in DoResolveAsTypeStep().
4177 * generic.cs (GenericMemberAccess.DoResolve): Make this work for
4180 2004-03-17 Marek Safar <marek.safar@seznam.cz>
4182 * interface.cs: In all interface classes removed redundant
4183 member initialization.
4185 2004-03-16 Martin Baulig <martin@ximian.com>
4187 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
4189 2004-03-15 Miguel de Icaza <miguel@ximian.com>
4191 * decl.cs (DefineTypeAndParents): New helper method to define a
4192 type's containers before the type itself is defined; This is a
4193 bug exposed by the recent changes to Windows.Forms when an
4194 implemented interface was defined inside a class that had not been
4197 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
4199 (Check): Loop correctly to report errors modifiers
4200 (UNSAFE was not in the loop, since it was the same as TOP).
4202 * interface.cs: Every interface member now takes a ModFlags,
4203 instead of a "is_new" bool, which we set on the base MemberCore.
4205 Every place where we called "UnsafeOk" in the interface, now we
4206 call the proper member (InterfaceMethod.UnsafeOK) instead to get
4207 the unsafe settings from the member declaration instead of the
4208 container interface.
4210 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
4212 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
4213 `set_indexer_name' to the pending bits (one per type).
4215 We fixed a bug today that was picking the wrong method to
4216 override, since for properties the existing InterfaceMethod code
4217 basically ignored the method name. Now we make sure that the
4218 method name is one of the valid indexer names.
4220 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
4222 * support.cs (SeekableStreamReader): Keep track of stream byte
4223 positions and don't mix them with character offsets to the buffer.
4225 Patch from Gustavo Giráldez
4227 2004-03-15 Marek Safar <marek.safar@seznam.cz>
4229 * interface.cs (InterfaceSetGetBase): Removed double member
4230 initialization, base class does it as well.
4232 2004-03-13 Martin Baulig <martin@ximian.com>
4234 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
4235 when compiling corlib.
4237 2004-03-13 Miguel de Icaza <miguel@ximian.com>
4239 * convert.cs (ExplicitConversion): We were reporting an error on
4240 certain conversions (object_type source to a value type, when the
4241 expression was `null') before we had a chance to pass it through
4242 the user defined conversions.
4244 * driver.cs: Replace / and \ in resource specifications to dots.
4247 * class.cs: Add check for duplicate operators. Fixes 52477
4249 2004-03-11 Miguel de Icaza <miguel@ximian.com>
4251 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
4252 that are in the middle of the statements, not only at the end.
4255 * class.cs (TypeContainer.AddField): No longer set the
4256 `HaveStaticConstructor' flag, now we call it
4257 `UserDefineStaticConstructor' to diferentiate the slightly
4258 semantic difference.
4260 The situation is that we were not adding BeforeFieldInit (from
4261 Modifiers.TypeAttr) to classes that could have it.
4262 BeforeFieldInit should be set to classes that have no static
4267 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
4269 And most importantly Zoltan's comment:
4271 http://bugzilla.ximian.com/show_bug.cgi?id=44229
4273 "I think beforefieldinit means 'it's ok to initialize the type sometime
4274 before its static fields are used', i.e. initialization does not need
4275 to be triggered by the first access to the type. Setting this flag
4276 helps the JIT to compile better code, since it can run the static
4277 constructor at JIT time, and does not need to generate code to call it
4278 (possibly lots of times) at runtime. Unfortunately, mcs does not set
4279 this flag for lots of classes like String.
4281 csc sets this flag if the type does not have an explicit static
4282 constructor. The reasoning seems to be that if there are only static
4283 initalizers for a type, and no static constructor, then the programmer
4284 does not care when this initialization happens, so beforefieldinit
4287 This bug prevents the AOT compiler from being usable, since it
4288 generates so many calls to mono_runtime_class_init that the AOT code
4289 is much slower than the JITted code. The JITted code is faster,
4290 because it does not generate these calls if the vtable is type is
4291 already initialized, which is true in the majority of cases. But the
4292 AOT compiler can't do this."
4294 2004-03-10 Miguel de Icaza <miguel@ximian.com>
4296 * class.cs (MethodData.Emit): Refactor the code so symbolic
4297 information is generated for destructors; For some reasons we
4298 were taking a code path that did not generate symbolic information
4301 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
4303 * class.cs: Create a Constructor.CheckBase method that
4304 takes care of all validation type code. The method
4305 contains some code that was moved from Define.
4307 It also includes new code that checks for duplicate ctors.
4308 This fixes bug #55148.
4310 2004-03-09 Joshua Tauberer <tauberer@for.net>
4312 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
4313 a { ... }-style array creation invokes EmitStaticInitializers
4314 which is not good for reference-type arrays. String, decimal
4315 and now null constants (NullCast) are not counted toward
4316 static initializers.
4318 2004-03-05 Martin Baulig <martin@ximian.com>
4320 * location.cs (SourceFile.HasLineDirective): New public field;
4321 specifies whether the file contains or is referenced by a "#line"
4323 (Location.DefineSymbolDocuments): Ignore source files which
4324 either contain or are referenced by a "#line" directive.
4326 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
4328 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
4329 direct access to our parent, so check the method inline there.
4331 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
4333 * expression.cs (Invocation.EmitCall): Miguel's last commit
4334 caused a regression. If you had:
4339 In Foo the implict this would be null.
4341 2004-02-27 Miguel de Icaza <miguel@ximian.com>
4343 * expression.cs (Invocation.EmitCall): If the method is not
4344 virtual, do not emit a CallVirt to it, use Call.
4346 * typemanager.cs (GetFullNameSignature): Improve the method to
4347 cope with ".ctor" and replace it with the type name.
4349 * class.cs (ConstructorInitializer.Resolve): Now the method takes
4350 as an argument the ConstructorBuilder where it is being defined,
4351 to catch the recursive constructor invocations.
4353 2004-03-16 Martin Baulig <martin@ximian.com>
4355 * expression.cs (MemberAccess.DoResolve): If `expr' resolved to a
4356 ConstructedType, call ResolveType() on it to get the type rather
4357 than just using `expr.Type'.
4359 2004-03-16 Martin Baulig <martin@ximian.com>
4361 * generics.cs (ConstructedType.GetMemberAccess): Take the
4362 EmitContext instead on the TypeExpr and use
4363 ec.TypeContainer.CurrentType/ec.ContainerType.
4365 2004-03-16 Martin Baulig <martin@ximian.com>
4367 * ecore.cs (SimpleName.DoResolveAsTypeStep): Lookup type
4368 parameters before aliases.
4370 2004-03-16 Martin Baulig <martin@ximian.com>
4372 * typemanager.cs (TypeManager.MayBecomeEqualGenericInstances):
4373 New oublic function; checks whether two generic instances may become
4374 equal under some instantiations (26.3.1).
4376 * class.cs (TypeContainer.Define): Call
4377 TypeManager.MayBecomeEqualGenericInstances() and report CS0695 on
4380 2004-03-16 Martin Baulig <martin@ximian.com>
4382 * class.cs (TypeContainer.GetClassBases): Moved
4383 Error_TypeParameterAsBase() here and also check whether the base
4384 class is not an attribute.
4386 2004-03-16 Martin Baulig <martin@ximian.com>
4388 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
4390 2004-03-16 Martin Baulig <martin@ximian.com>
4392 * class.cs (Error_TypeParameterAsBase): Use correct error number
4395 2004-03-16 Martin Baulig <martin@ximian.com>
4397 * decl.cs (DeclSpace.ResolveTypeExpr): Added more error checking
4400 * generics.cs (ConstructedType.DoResolveAsTypeStep): Added better
4403 2004-03-15 Martin Baulig <martin@ximian.com>
4405 * typemanager.cs (TypeManager.GetFullName): New public method.
4406 (TypeManager.MemberLookup): Added `int_num_type_arguments'
4407 argument; only return members with the correct number of type
4409 (TypeManager.CheckGeneric): Allow -1 to bypass the check.
4410 (TypeManager.FilterWithClosure): Call CheckGeneric() to check
4411 whether the number of type arguments matches.
4413 * generic.cs (GenericMemberAccess.ResolveAsTypeStep): Allow `expr'
4414 not being a ConstructedType; we can now do "typeof (Foo.Bar<U>)".
4416 * expression.cs (MemberAccess): Added public `NumTypeArguments'
4417 field; it's set by the protected .ctor when we're actually a
4418 GenericMemberAccess.
4419 (MemberAccess.ResolveAsTypeStep): Compute the total number of type
4420 arguments and pass it to MemberLookupFinal ().
4422 * ecore.cs (Expression.MemberLookup): Added `int
4423 num_type_arguments' argument; only return members with the correct
4424 number of type arguments.
4425 (Expression.MemberLookupFailed): Check whether the MemberLookup
4426 failed because we did not have the correct number of type
4427 arguments; report CS0305 in this case.
4429 * decl.cs (DeclSpace.ResolveTypeExpr): Don't report an error if
4430 `e.ResolveAsTypeTerminal()' already did so.
4432 2004-03-15 Martin Baulig <martin@ximian.com>
4434 * ecore.cs (Expression.ResolveLValue): Allow e.type being null if
4435 we're a ConstructedType; in this case, the caller must report an
4436 error (for instance CS0131).
4438 * generic.cs (TypeArguments): Added Location argument to the .ctor.
4439 (TypeArguments.Resolve): Actually report errors here.
4441 2004-03-15 Miguel de Icaza <miguel@ximian.com>
4443 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
4444 `set_indexer_name' to the pending bits (one per type).
4446 We fixed a bug today that was picking the wrong method to
4447 override, since for properties the existing InterfaceMethod code
4448 basically ignored the method name. Now we make sure that the
4449 method name is one of the valid indexer names.
4451 2004-03-15 Martin Baulig <martin@ximian.com>
4453 * typemanager.cs (TypeManager.IndexerPropertyName): Added support
4454 for generic instances.
4456 2004-03-13 Martin Baulig <martin@ximian.com>
4458 * class.cs (TypeContainer.DefineType): Call
4459 TypeManager.AddUserType() immediately after creating the
4460 TypeBuilder; pass all type parameters when creating the
4463 * decl.cs (DeclSpace.FindNestedType): New public method.
4464 (DeclSpace.FindType): Added `int num_type_args' argument; only
4465 return types with the correct number of type parameters.
4466 (DeclSpace.CountTypeParams): New public property.
4468 * ecore.cs (SimpleName.ctor): Added overloaded version which takes
4469 the number of type parameters; defaults to zero.
4471 * generic.cs (TypeArguments.Count): New public property.
4472 (ConstructedType.DoResolveAsTypeStep): First call
4473 ds.FindNestedType() to find out whether we're nested in the
4474 current generic type; in this case, we inherit all type parameters
4475 from the current class.
4477 * rootcontext.cs (RootContext.NamespaceLookup): Added `int
4478 num_type_args' argument.
4479 (RootContext.LookupType): Added overloaded version which takes the
4480 number of type arguments; only return types with the correct
4481 number of type arguments.
4483 * typemanager.cs (TypeManager.CheckGeneric): New public function;
4484 checks whether `Type t' has `int num_type_args'.
4486 2004-03-13 Martin Baulig <martin@ximian.com>
4488 * generic.cs (GenericMethod.DefineType): New method; calls
4489 DefineType() on all the type parameters.
4491 * class.cs (MethodData.ctor): Added `GenericMethod generic' argument.
4492 (MethodData.Define): If we're a generic method, call
4493 GenericMethod.DefineType() to define the type parameters.
4495 2004-03-10 Martin Baulig <martin@ximian.com>
4497 * pending.cs (Pending.InterfaceMethod): Use TypeManager.IsEqual()
4498 instead of IsAssignableFrom.
4500 2004-03-10 Martin Baulig <martin@ximian.com>
4502 * ecore.cs (FieldExpr.ctor): Use TypeManager.TypeToCoreType().
4504 * support.cs (ParameterData.HasArrayParameter): New property.
4505 (ReflectionParameters.ctor): Take a MethodBase instead of a
4506 ParameterInfo[]. If we have any type parameters, get the generic
4507 method definition and ask it whether we have variable arguments.
4509 2004-02-26 Miguel de Icaza <miguel@ximian.com>
4511 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
4512 routines to check if a type is an enumerable/enumerator allow
4513 classes that implement the IEnumerable or IEnumerator interfaces.
4515 * class.cs (Property, Operator): Implement IIteratorContainer, and
4516 implement SetYields.
4518 (Property.Define): Do the block swapping for get_methods in the
4519 context of iterators. We need to check if Properties also
4520 include indexers or not.
4522 (Operator): Assign the Block before invoking the
4523 OperatorMethod.Define, so we can trigger the Iterator code
4526 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
4527 Property and Operator classes are not created when we parse the
4528 declarator but until we have the block completed, so we use a
4529 singleton SimpleIteratorContainer.Simple to flag whether the
4530 SetYields has been invoked.
4532 We propagate this setting then to the Property or the Operator to
4533 allow the `yield' to function.
4535 2004-02-25 Marek Safar <marek.safar@seznam.cz>
4537 * codegen.cs: Implemented attribute support for modules.
4538 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
4539 Assembly/Module functionality.
4541 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
4542 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
4543 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
4545 2004-02-16 Marek Safar <marek.safar@seznam.cz>
4547 * interface.cs (FindMembers): The operation is performed on all base
4548 interfaces and not only on the first. It is required for future CLS Compliance patch.
4550 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
4552 * statement.cs, codegen.cs:
4553 This patch deals with patterns such as:
4555 public class List : IEnumerable {
4557 public MyEnumerator GetEnumerator () {
4558 return new MyEnumerator(this);
4561 IEnumerator IEnumerable.GetEnumerator () {
4565 public struct MyEnumerator : IEnumerator {
4570 Before, there were a few things we did wrong:
4571 1) we would emit callvirt on a struct, which is illegal
4572 2) we emited ldarg when we needed to emit ldarga
4573 3) we would mistakenly call the interface methods on an enumerator
4574 type that derived from IEnumerator and was in another assembly. For example:
4576 public class MyEnumerator : IEnumerator
4578 Would have the interface methods called, even if there were public impls of the
4579 method. In a struct, this lead to invalid IL code.
4581 2004-02-11 Marek Safar <marek.safar@seznam.cz>
4583 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
4586 * delegate.cs (Define): Fixed crash when delegate type is undefined.
4588 2004-02-11 Miguel de Icaza <miguel@ximian.com>
4590 * cs-parser.jay: Fix small regression: we were not testing V2
4591 compiler features correctly.
4593 * interface.cs: If the emit context is null, then create one
4595 2004-02-09 Marek Safar <marek.safar@seznam.cz>
4597 * decl.cs (GetSignatureForError): New virtual method to get full name
4600 * attribute.cs (IAttributeSupport): New interface for attribute setting.
4601 Now it is possible to rewrite ApplyAttributes method to be less if/else.
4603 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
4604 Duplicated members and code in these classes has been removed.
4605 Better encapsulation in these classes.
4607 2004-02-07 Miguel de Icaza <miguel@ximian.com>
4609 * assign.cs (Assign.DoResolve): When dealing with compound
4610 assignments, there is a new rule in ECMA C# 2.4 (might have been
4611 there before, but it is documented here) that states that in:
4615 If b is of type int, and the `op' is a shift-operator, then the
4616 above is evaluated as:
4620 * expression.cs (Binary.ResolveOperator): Instead of testing for
4621 int/uint/long/ulong, try to implicitly convert to any of those
4622 types and use that in pointer arithmetic.
4624 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
4625 method to print information for from the type, not from the
4626 null-method we were given.
4628 2004-02-01 Duncan Mak <duncan@ximian.com>
4630 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
4631 parsing for cmd, fixes bug #53694.
4633 2004-02-04 Marek Safar <marek.safar@seznam.cz>
4635 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
4636 in the member name duplication tests. Property and operator name duplication
4637 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
4639 2004-02-03 Marek Safar <marek.safar@seznam.cz>
4641 * interface.cs (PopulateMethod): Fixed crash when interface method
4642 returns not existing type (error test cs0246-3.cs).
4644 2004-02-02 Ravi Pratap M <ravi@ximian.com>
4646 * cs-parser.jay (interface_accessors): Re-write actions to also
4647 store attributes attached to get and set methods. Fix spelling
4650 (inteface_property_declaration): Modify accordingly.
4652 (InterfaceAccessorInfo): New helper class to store information to pass
4653 around between rules that use interface_accessors.
4655 * interface.cs (Emit): Apply attributes on the get and set
4656 accessors of properties and indexers too.
4658 * attribute.cs (ApplyAttributes): Modify accordingly to use the
4659 right MethodBuilder when applying attributes to the get and set accessors.
4661 2004-01-31 Miguel de Icaza <miguel@ximian.com>
4663 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
4665 2004-01-26 Miguel de Icaza <miguel@ximian.com>
4667 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
4669 2004-01-25 Miguel de Icaza <miguel@ximian.com>
4671 * cs-parser.jay: Remove YIELD token, instead use the new grammar
4672 changes that treat `yield' specially when present before `break'
4675 * cs-tokenizer.cs: yield is no longer a keyword.
4677 2004-01-23 Marek Safar <marek.safar@seznam.cz>
4679 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
4680 setting for default constructors.
4681 For default constructors are almost every time set wrong Modifier. The
4682 generated IL code has been alright. But inside mcs this values was
4683 wrong and this was reason why several of my CLS Compliance tests
4686 2004-02-27 Martin Baulig <martin@ximian.com>
4688 * generics.cs (ConstructedType.ResolveType): Make the nested type
4689 stuff actually work.
4691 2004-02-25 Martin Baulig <martin@ximian.com>
4693 * decl.cs (DeclSpace.CurrentTypeParameters): New protected
4694 property; returns the type parameters just from the current type,
4695 ie. with the ones from outer classes.
4696 (DeclSpace.LookupGeneric): First search in the current class, then
4698 (DeclSpace.initialize_type_params): When hiding a type parameter
4699 from an outer class, put it into the `type_param_list' anyways.
4701 * expression.cs (MemberAccess.expr): Made this field protected.
4703 * class.cs (TypeContainer.Define): The `CurrentType' just contains
4704 the type parameters from the current class.
4706 * generic.cs (ConstructedType.ResolveType): Support nested generic
4707 types by taking the type parameters which we inherit from outer
4708 classes into account.
4709 (GenericMemberAccess.ResolveAsTypeStep): Override this and added
4710 support for nested generic types.
4712 2004-02-23 Martin Baulig <martin@ximian.com>
4714 * decl.cs (DeclSpace.IsGeneric): Make this a property instead of a
4715 field and check whether we're nested inside a generic type.
4716 (DeclSpace.ResolveType): If we're resolving to a generic type
4717 definition, create a ConstructedType and return its resolved type.
4718 (DeclSpace.initialize_type_params): New private method;
4719 initializes the `type_param_list' field from the type parameters
4720 from this and all enclosing classes.
4721 (DeclSpace.TypeParameters): Call initialize_type_params() unless
4722 we're already initialized.
4724 2004-02-23 Martin Baulig <martin@ximian.com>
4726 * class.cs (Method.Define): Create the generic method before
4728 (Memberbase.DoDefine): Added DeclSpace argument (in addition to
4729 the TypeContainer one); we use this for generic methods.
4731 * decl.cs (CheckAccessLevel): If we're a GenericMethod, use our
4732 parent's TypeBuilder.
4734 2004-02-18 Martin Baulig <martin@ximian.com>
4736 * ecore.cs (FieldExpr.DoResolveLValue): Use TypeManager.IsEqual()
4737 to check for equality.
4739 2004-02-05 Martin Baulig <martin@ximian.com>
4741 * ecore.cs (FieldExpr.DoResolveLValue): If we have an
4742 `ec.TypeContainer.CurrentType', use it instead of
4743 `ec.ContainerType' to check whether we're in the type's ctor.
4745 2004-01-29 Martin Baulig <martin@ximian.com>
4747 * expression.cs (Invocation.DoResolve): If we're a
4748 `ConstructedType', then we're actually a generic method, so
4749 rewrite the expr as a GenericMemberAccess.
4751 * cs-parser.jay (member_name): Don't use `namespace_or_type_name'
4752 here; manually parse it into a string.
4754 2004-01-28 Martin Baulig <martin@ximian.com>
4756 * typemanager.cs (TypeManager.IsEqual): New static method.
4757 (TypeManager.FilterWithClosure): Call TypeManager.IsEqual() to
4758 check for equality instead of using `=='.
4760 2004-01-26 Martin Baulig <martin@ximian.com>
4762 * decl.cs (DeclSpace.CurrentType): New public field.
4764 * expression.cs (This.ResolveBase): If we have an
4765 `ec.TypeContainer.CurrentType', use it instead of
4768 * class.cs (TypeContainer.DefineType): If we're a generic type,
4769 create the `CurrentType' (unresolved).
4770 (TypeContainer.GenericType): New private field.
4771 (TypeContainer.DefineMembers): If we have a `CurrentType', resolve
4772 it and store it in `GenericType' before creating the MemberCache.
4773 (TypeContainer.GetMembers): If we have a `GenericType', call
4774 TypeManager.FindMembers() on it.
4776 * interface.cs (Interface.GenericType): New private field.
4777 (Interface.DefineType): If we're a generic type, create the
4778 `CurrentType' (unresolved).
4779 (Interface.DefineMembers): If we have a `CurrentType', resolve it
4780 and store it in `GenericType' before creating the MemberCache.
4781 (Interface.GetMembers): If we have a `GenericType', call
4782 TypeManager.FindMembers() on it.
4784 2004-01-22 Martin Baulig <martin@ximian.com>
4786 * cs-parser.jay (namespace_or_type_name): Return an Expression,
4787 not a QualifiedIdentifier. This is what `type_name_expression'
4788 was previously doing.
4789 (type_name_expression): Removed; the code is now in
4790 `namespace_or_type_name'.
4791 (qualified_identifier): Removed, use `namespace_or_type_name'
4793 (QualifiedIdentifier): Removed this class.
4795 2004-01-22 Martin Baulig <martin@ximian.com>
4797 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
4798 not a string as alias name.
4800 2004-01-21 Miguel de Icaza <miguel@ximian.com>
4802 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
4803 #52730 bug, and instead compute correctly the need to use a
4804 temporary variable when requesting an address based on the
4805 static/instace modified of the field and the constructor.
4807 2004-01-21 Martin Baulig <martin@ximian.com>
4809 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
4810 class and namespace before looking up aliases. Fixes #52517.
4812 2004-01-21 Martin Baulig <martin@ximian.com>
4814 * flowanalysis.cs (UsageVector.Merge): Allow variables being
4815 assinged in a 'try'; fixes exception4.cs.
4817 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4818 * class.cs : Implemented parameter-less constructor for TypeContainer
4820 * decl.cs: Attributes are now stored here. New property OptAttributes
4822 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
4824 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
4826 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4828 * typemanager.cs (CSharpSignature): Now reports also inner class name.
4829 (CSharpSignature): New method for indexer and property signature.
4831 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4833 * pending.cs (IsVirtualFilter): Faster implementation.
4835 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4837 * typemanager.cs: Avoid inclusion of same assembly more than once.
4839 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4841 * cs-parser.jay: Fixed problem where the last assembly attribute
4842 has been applied also to following declaration (class, struct, etc.)
4844 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4846 * class.cs: Added error CS0538, CS0539 reporting.
4847 Fixed crash on Microsoft runtime when field type is void.
4849 * cs-parser.jay: Added error CS0537 reporting.
4851 * pending.cs: Added error CS0535 reporting.
4852 Improved error report for errors CS0536, CS0534.
4854 2004-01-20 Miguel de Icaza <miguel@ximian.com>
4856 Merge a few bits from the Anonymous Method MCS tree.
4858 * statement.cs (ToplevelBlock): New class for toplevel methods,
4859 will hold anonymous methods, lifted variables.
4861 * cs-parser.jay: Create toplevel blocks for delegates and for
4862 regular blocks of code.
4864 2004-01-20 Martin Baulig <martin@ximian.com>
4866 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
4867 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
4868 and `NeedExplicitReturn'; added `IsLastStatement'.
4869 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
4870 have a `ReturnLabel' or we're not unreachable.
4872 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
4873 child's reachability; don't just override ours with it. Fixes
4874 #58058 (lluis's example).
4875 (FlowBranching): Added public InTryOrCatch(), InCatch(),
4876 InFinally(), InLoop(), InSwitch() and
4877 BreakCrossesTryCatchBoundary() methods.
4879 * statement.cs (Return): Do all error checking in Resolve().
4880 Unless we are the last statement in a top-level block, always
4881 create a return label and jump to it.
4882 (Break, Continue): Do all error checking in Resolve(); also make
4883 sure we aren't leaving a `finally'.
4884 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
4885 statement in a top-level block.
4886 (Block.Flags): Added `IsDestructor'.
4887 (Block.IsDestructor): New public property.
4889 2004-01-20 Martin Baulig <martin@ximian.com>
4891 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
4893 2004-01-20 Martin Baulig <martin@ximian.com>
4895 * statement.cs (Statement.ResolveUnreachable): New public method.
4896 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
4897 (Block.Resolve): Resolve unreachable statements.
4899 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
4901 * expression.cs: We need to fix the case where we do
4902 not have a temp variable here.
4904 * assign.cs: Only expression compound assignments need
4905 temporary variables.
4907 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
4909 * flowanalysis.cs: Reduce memory allocation in a few ways:
4910 - A block with no variables should not allocate a bit
4912 - A method with no out parameters does not need any tracking
4913 for assignment of the parameters, so we need not allocate
4916 public readonly Type[] VariableTypes;
4917 public readonly string[] VariableNames;
4918 Are redundant. The data is already stored in the variable
4919 map, so we need not allocate another array for it.
4920 - We need to add alot of checks for if (params | locals) == null
4921 due to the first two changes.
4923 2004-01-18 Miguel de Icaza <miguel@ximian.com>
4925 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
4926 implement IMemoryLocation, we store a copy on a local variable and
4927 take the address of it. Patch from Benjamin Jemlich
4929 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
4930 to use a special "type_name_expression" rule which reduces the
4931 number of "QualifiedIdentifier" classes created, and instead
4932 directly creates MemberAccess expressions.
4934 2004-01-17 Miguel de Icaza <miguel@ximian.com>
4936 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
4937 that fixes #52853. Null literal assignment to ValueType
4939 * class.cs (MethodData.Emit): Instead of checking the name of the
4940 method to determine if its a destructor, create a new derived
4941 class from Method called Destructor, and test for that.
4943 * cs-parser.jay: Create a Destructor object instead of a Method.
4945 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
4949 2004-01-16 Miguel de Icaza <miguel@ximian.com>
4951 * expression.cs (Binary.ResolveOperator): Perform an implicit
4952 conversion from MethodGroups to their delegate types on the
4955 * delegate.cs: Introduce a new class DelegateCreation that is the
4956 base class for `NewDelegate' and `ImplicitDelegateCreation',
4957 factor some code in here.
4959 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
4960 conversion from MethodGroups to compatible delegate types.
4962 * ecore.cs (Expression.Resolve): Do not flag error 654
4963 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
4964 we allow conversions from MethodGroups to delegate types now.
4966 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
4967 assignments in v2 either.
4969 2004-01-10 Miguel de Icaza <miguel@ximian.com>
4971 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
4972 static read-only fields in ctors.
4974 Applied patch from Benjamin Jemlich
4976 * expression.cs (UnaryMutator): Avoid leaking local variables.
4978 2004-01-09 Miguel de Icaza <miguel@ximian.com>
4980 * cs-tokenizer.cs (IsCastToken): Allow the various native types
4981 here to return true, as they can be used like this:
4985 Fixed 49836 and all the other dups
4987 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
4989 * driver.cs: Implement /win32res and /win32icon.
4991 2004-01-08 Miguel de Icaza <miguel@ximian.com>
4993 * cs-parser.jay: Add a rule to improve error handling for the
4994 common mistake of placing modifiers after the type.
4996 2004-01-07 Miguel de Icaza <miguel@ximian.com>
4998 * cs-parser.jay (interface_event_declaration): Catch
4999 initialization of events on interfaces, and report cs0068
5001 * cs-parser.jay (interface_event_declaration): Catch
5002 initialization of events.
5004 * ecore.cs: Better report missing constructors.
5006 * expression.cs (Binary.ResolveOperator): My previous bug fix had
5007 the error reporting done in the wrong place. Fix.
5009 * expression.cs (Binary.ResolveOperator): Catch the
5010 operator + (E x, E y) error earlier, and later allow for implicit
5011 conversions in operator +/- (E e, U x) from U to the underlying
5014 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
5015 52596, if the container class is abstract, the default constructor
5016 is protected otherwise its public (before, we were always public).
5018 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
5021 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
5022 Jemlich that fixes bug #52597, MCS was generating invalid code for
5023 idisposable structs. Thanks to Ben for following up with this
5026 2004-01-06 Miguel de Icaza <miguel@ximian.com>
5028 * driver.cs: Allow assemblies without code to be generated, fixes
5031 2004-01-07 Nick Drochak <ndrochak@gol.com>
5033 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
5035 2004-01-05 Miguel de Icaza <miguel@ximian.com>
5037 * cs-parser.jay: Add rules to improve error reporting if fields or
5038 methods are declared at the namespace level (error 116)
5040 * Add rules to catch event add/remove
5042 2004-01-04 David Sheldon <dave-mono@earth.li>
5044 * expression.cs: Added matching ")" to error message for
5047 2004-01-03 Todd Berman <tberman@gentoo.org>
5049 * ecore.cs, attribute.cs:
5050 Applying fix from #52429.
5052 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
5054 * ecore.cs, expression.cs, statement.cs:
5055 Total rewrite of how we handle branching. We
5056 now handle complex boolean expressions with fewer
5057 jumps. As well if (x == 0) no longer emits a ceq.
5059 if (x is Foo) is much faster now, because we generate
5062 Overall, we get a pretty big improvement on our benchmark
5063 tests. The code we generate is smaller and more readable.
5065 I did a full two-stage bootstrap. The patch was reviewed
5066 by Martin and Miguel.
5068 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
5070 * cs-parser.jay: Make primary_expression not take a QI.
5071 we dont need this because the member_access rule covers
5072 us here. So we replace the rule with just IDENTIFIER.
5074 This has two good effects. First, we remove a s/r conflict.
5075 Second, we allocate many fewer QualifiedIdentifier objects.
5077 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
5079 * attribute.cs: Handle MarshalAs attributes as pseudo, and
5080 set the correct information via SRE. This prevents
5081 hanging on the MS runtime. Fixes #29374.
5083 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
5085 * convert.cs: correctly handle conversions to value types
5086 from Enum and ValueType as unboxing conversions.
5088 Fixes bug #52569. Patch by Benjamin Jemlich.
5090 2004-01-02 Ravi Pratap <ravi@ximian.com>
5092 * expression.cs (BetterConversion): Prefer int -> uint
5093 over int -> ulong (csc's behaviour). This fixed bug #52046.
5095 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
5097 * decl.cs (MemberCache.FindMembers): now returns a
5100 * typemanager.cs: In general, go with with ^^.
5101 (CopyNewMethods): take an IList.
5102 (RealMemberLookup): Only allocate an arraylist
5103 if we copy from two sets of methods.
5105 This change basically does two things:
5106 1) Fewer array lists allocated due to CopyNewMethods.
5107 2) the explicit cast in MemberList costed ALOT.
5109 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
5111 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
5112 a hashtable to avoid needless string allocations when an identifier is
5113 used more than once (the common case).
5115 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
5117 * pending.cs: MS's TypeBuilder.GetInterfaces ()
5118 is broken, it will not return anything. So, we
5119 have to use the information we have in mcs to
5122 * typemanager.cs: Add a cache for GetInterfaces,
5123 since this will now be used more often (due to ^^)
5125 (GetExplicitInterfaces) New method that gets the
5126 declared, not effective, interfaces on a type
5127 builder (eg, if you have interface IFoo, interface
5128 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
5131 This patch makes MCS able to bootstrap itself on
5134 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
5136 * expression.cs: Remove the Nop's that Miguel put
5139 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
5141 * report.cs, codegen.cs: Give the real stack trace to
5142 the error when an exception is thrown.
5144 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
5146 * decl.cs: only allocate hashtables for ifaces if
5149 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
5151 * expression.cs: fix the error from cs0121-2.cs
5152 (a parent interface has two child interfaces that
5153 have a function with the same name and 0 params
5154 and the function is called through the parent).
5156 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
5158 * class.cs, rootcontext.cs, typmanager.cs: do not
5161 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
5163 * codegen.cs: remove stack for the ec flow branching.
5164 It is already a linked list, so no need.
5166 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
5168 * Makefile: Allow custom profiler here.
5170 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
5172 * typemanager.cs (LookupType):
5173 - Use a static char [], because split takes
5174 a param array for args, so it was allocating
5176 - Do not store true in a hashtable, it boxes.
5178 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
5180 * flowanalysis.cs: bytify common enums.
5182 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
5184 * modifiers.cs: Add a new set of flags for the
5185 flags allowed on explicit interface impls.
5186 * cs-parser.jay: catch the use of modifiers in
5187 interfaces correctly.
5188 * class.cs: catch private void IFoo.Blah ().
5190 All related to bug #50572.
5192 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
5194 * decl.cs: Rewrite the consistant accessability checking.
5195 Accessability is not linear, it must be implemented in
5196 a tableish way. Fixes #49704.
5198 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
5200 * expression.cs: Handle negation in a checked context.
5201 We must use subtraction from zero. Fixes #38674.
5203 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
5205 * class.cs: Ignore static void main in DLLs.
5206 * rootcontext.cs: Handle the target type here,
5207 since we are have to access it from class.cs
5208 * driver.cs: account for the above.
5210 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
5212 * report.cs: Give line numbers and files if available.
5214 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
5216 * driver.cs: Implement /addmodule.
5218 * typemanager.cs: Change 'modules' field so it now contains Modules not
5221 2003-12-20 Martin Baulig <martin@ximian.com>
5223 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
5224 (FieldBase.IsAssigned): Removed this field.
5225 (FieldBase.SetAssigned): New public method.
5226 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
5228 2003-12-20 Martin Baulig <martin@ximian.com>
5230 * expression.cs (LocalVariableReference.DoResolve): Don't set
5231 `vi.Used' if we're called from DoResolveLValue().
5233 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
5234 returns the usage vector it just merged into the current one -
5235 pass this one to UsageWarning().
5236 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
5237 of the `EmitContext', don't call this recursively on our children.
5239 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
5241 * driver.cs: Implement /target:module.
5243 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
5245 * support.cs (CharArrayHashtable): New helper class.
5247 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
5248 char arrays, not strings, so we can avoid creating a string in
5249 consume_identifier if the identifier is a keyword.
5251 2003-12-16 Martin Baulig <martin@ximian.com>
5253 * statement.cs (LocalInfo.Assigned): Removed this property.
5254 (LocalInfo.Flags): Removed `Assigned'.
5255 (LocalInfo.IsAssigned): New public method; takes the EmitContext
5256 and uses flow analysis.
5257 (Block.UsageWarning): Made this method private.
5258 (Block.Resolve): Call UsageWarning() if appropriate.
5260 * expression.cs (LocalVariableReference.DoResolve): Always set
5261 LocalInfo.Used here.
5263 2003-12-13 Martin Baulig <martin@ximian.com>
5265 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
5266 any value here; we're now using flow analysis to figure out
5267 whether a statement/block returns a value.
5269 2003-12-13 Martin Baulig <martin@ximian.com>
5271 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
5273 (FlowBranching.MergeFinally): Don't call
5274 `branching.CheckOutParameters()' here, this is called in
5276 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
5277 when adding the `finally' vector.
5279 2003-12-13 Martin Baulig <martin@ximian.com>
5282 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
5283 actually work and also fix #48962.
5285 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
5287 * decl.cs: Do not check System.Object for nested types,
5288 since we know it does not have any. Big bang for buck:
5293 corlib: 17.99 seconds
5297 corlib: 17.39 seconds
5299 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
5301 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
5302 time we are returning 0 members, so we save alot here.
5304 2003-12-11 Martin Baulig <martin@ximian.com>
5306 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
5307 `MergeChild()', also just take the `FlowBranching' as argument;
5308 call Merge() on it and return the result.
5309 (FlowBranching.Merge): We don't need to do anything if we just
5312 2003-12-11 Martin Baulig <martin@ximian.com>
5314 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
5315 them in an `ArrayList' to reduce memory usage. Thanks to Ben
5316 Maurer for this idea.
5318 2003-12-11 Martin Baulig <martin@ximian.com>
5320 * flowanalysis.cs (MergeResult): This class is now gone; we now
5321 use the `UsageVector' for this. The reason for this is that if a
5322 branching just has one sibling, we don't need to "merge" them at
5323 all - that's the next step to do.
5324 (FlowBranching.Merge): We now return a `UsageVector' instead of a
5327 2003-12-11 Martin Baulig <martin@ximian.com>
5329 Reworked flow analyis and made it more precise and bug-free. The
5330 most important change is that we're now using a special `Reachability'
5331 class instead of having "magic" meanings of `FlowReturns'. I'll
5332 do some more cleanups and optimizations and also add some more
5333 documentation this week.
5335 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
5336 largely reworked this class.
5337 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
5338 the new `Reachability' class instead of having "magic" values here.
5339 (FlowBranching): We're now using an instance of `Reachability'
5340 instead of having separate `Returns', `Breaks' etc. fields.
5342 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
5343 based on flow analysis; ignore the return value of block.Emit ().
5345 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
5347 * driver.cs typemanager.cs: Find the mono extensions to corlib even
5348 if they are private.
5350 2003-12-09 Martin Baulig <martin@ximian.com>
5352 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
5353 call them directly on the UsageVector.
5355 2003-12-09 Martin Baulig <martin@ximian.com>
5357 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
5358 Changed return type from `FlowReturns' to `Reachability'.
5360 2003-12-09 Martin Baulig <martin@ximian.com>
5362 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
5363 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
5364 `Reachable' fields with a single `Reachability' one.
5366 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
5368 * class.cs (FindMembers): Remove foreach's.
5381 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
5386 This patch does a few things:
5387 1. EmptyStatement is now a singleton, so it is never reallocated.
5388 2. All blah is EmptyStatement constructs have been changed to
5389 blah == EmptyStatement.Value, which is much faster and valid
5390 now that EmptyStatement is a singleton.
5391 3. When resolving a block, rather than allocating a new array for
5392 the non-empty statements, empty statements are replaced with
5393 EmptyStatement.Value
5394 4. Some recursive functions have been made non-recursive.
5395 Mainly the performance impact is from (3), however (1) and (2) are needed for
5396 this to work. (4) does not make a big difference in normal situations, however
5397 it makes the profile look saner.
5402 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
5403 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
5404 Total memory allocated: 56397 KB
5407 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
5408 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
5409 Total memory allocated: 55666 KB
5411 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
5413 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
5414 than the hashtable in a hashtable version
5416 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
5417 we always end up concating a string. This results in a huge perf
5418 loss, because many strings have to be tracked by the GC. In this
5419 patch, we first use a hashtable that works with two keys, so that
5420 the strings do not need to be concat'ed.
5431 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
5433 * Makefile: Add a new target `do-time' that does a quick and simple
5434 profile, leaving easy to parse output.
5436 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
5438 * codegen.cs (Init): Create the dynamic assembly with
5439 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
5441 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
5443 * support.cs: Make the PtrHashtable use only one
5444 instance of its comparer.
5446 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
5448 * typemanager.cs: Fix lookup of GetNamespaces.
5450 2003-11-29 Miguel de Icaza <miguel@ximian.com>
5452 * expression.cs: Removed redundant line.
5454 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
5455 ArrayLists, use for loops with bounds.
5457 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
5460 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
5461 arraylists, use for loop with bounds.
5463 The above three changes give us a 0.071 second performance
5464 improvement out of 3.294 seconds down to 3.223. On my machine
5465 the above changes reduced the memory usage by 1,387 KB during
5468 * cs-parser.jay (QualifiedIdentifier): New class used to represent
5469 QualifiedIdentifiers. Before we created a new string through
5470 concatenation, and mostly later on, the result would be
5471 manipulated by DecomposeQI through string manipulation.
5473 This reduced the compiler memory usage for bootstrapping from
5474 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
5475 compile times in 0.05 seconds.
5477 2003-11-28 Dick Porter <dick@ximian.com>
5479 * support.cs: Do string compares with the Invariant culture.
5487 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
5488 the comparison is done with the Invariant culture.
5490 2003-11-27 Miguel de Icaza <miguel@ximian.com>
5492 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
5493 GetEnumerator method.
5495 (ProbeCollectionType): Iterate starting at the most specific type
5496 upwards looking for a GetEnumerator
5498 * expression.cs: Shift count can be up to 31 for int/uint and 63
5501 2003-11-26 Miguel de Icaza <miguel@ximian.com>
5503 * statement.cs (Block.LookupLabel): Also look for the label on the
5504 children blocks. Use a hash table to keep track of visited
5507 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
5508 we actually did transform the other operand, otherwise fall back
5509 to the common codepath that casts to long.
5511 * cs-tokenizer.cs: Use the same code pattern as the int case.
5512 Maybe I should do the parsing myself, and avoid depending on the
5513 Parse routines to get this done.
5515 2003-11-25 Miguel de Icaza <miguel@ximian.com>
5517 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
5518 which fixes bug 51347. This time test it.
5520 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
5521 attributes for example can not tell the difference between these.
5522 The difference was only a syntax feature of the language.
5524 * attribute.cs: Apply attributes to delegates.
5526 * delegate.cs: Call the apply attributes method.
5528 2003-11-24 Miguel de Icaza <miguel@ximian.com>
5530 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
5531 comparing 0 vs Byte.MinValue, not the value
5533 (ImplicitConversionRequired): When reporting a conversion error,
5534 use error 31 to print out the constant error instead of the
5537 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
5538 which fixes bug 51347.
5540 2003-11-22 Miguel de Icaza <miguel@ximian.com>
5542 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
5543 which fixes the -warnaserror command line option.
5545 2003-11-21 Miguel de Icaza <miguel@ximian.com>
5547 * cfold.cs (DoNumericPromotions): During constant folding of
5548 additions on UIntConstant, special case intconstants with
5549 IntConstants like we do on the expression binary operator.
5551 2003-11-12 Miguel de Icaza <miguel@ximian.com>
5553 * convert.cs (ImplicitReferenceConversion): We were missing a case
5554 (System.Enum are not value types or class types, so we need to
5555 classify them separatedly).
5557 * driver.cs: We do not support error 2007.
5559 2003-11-12 Jackson Harper <jackson@ximian.com>
5561 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
5562 system directory. Also use the full file name so users can
5563 libraries names mscorlib-o-tron.dll in a non system dir.
5565 2004-01-04 David Sheldon <dave-mono@earth.li>
5567 * expression.cs: Added matching ")" to error message for CS0077.
5569 2003-12-19 Martin Baulig <martin@ximian.com>
5571 * typemanager.cs (TypeManager.IsEqualGenericType): New public
5572 static method; see documentation in the method.
5573 (TypeManager.IsSubclassOrNestedChild): Allow IsEqualGenericType().
5575 * convert.cs (Convert.ImplicitReferenceConversion,
5576 Convert.ImplicitReferenceConversionExists): Add support for
5577 generic type declarations; see gen-36.cs.
5579 2003-12-19 Martin Baulig <martin@ximian.com>
5581 * pending.cs (Pending.InterfaceMethod): Use
5582 `Type.IsAssignableFrom()' instead of `=='.
5584 2003-12-18 Martin Baulig <martin@ximian.com>
5586 * decl.cs (DeclSpace.AsAccessible): Check for array, pointer and
5589 * convert.cs (Convert.ImplicitStandardConversionExists): Use
5590 `expr_type.Equals (target_type)' instead of `=='.
5592 2003-12-08 Martin Baulig <martin@ximian.com>
5594 * generics.cs (Constraints.Types): Removed.
5595 (Constraints.Resolve): Just resolve everything to TypeExpr's, not
5597 (Constraints.ResolveTypes): New public method; resolves the
5598 TypeExpr's to Type's.
5599 (TypeParameter.Define): TypeBuilder.DefineGenericParameter() no
5600 longer takes the constraints.
5601 (TypeParameter.DefineMethod): Likewise.
5602 (TypeParameter.DefineType): New public method. Calls
5603 `TypeBuilder/MethodBuilder.SetGenericParameterConstraints()' to set
5606 2003-12-08 Martin Baulig <martin@ximian.com>
5608 * convert.cs (Convert.ImplicitConversionStandard): Use
5609 `expr_type.Equals (target_type)' instead of `=='.
5611 2003-12-08 Martin Baulig <martin@ximian.com>
5613 * typemanager.cs (TypeManager.GetReferenceType): Call
5614 `Type.MakeByRefType ()'.
5616 2003-12-08 Martin Baulig <martin@ximian.com>
5618 * cs-parser.jay, cs-tokenizer.cs: `where' is not a keyword, it
5619 just has some special meaning in some situations. For instance,
5620 it is allowed to use `where' as the name of a variable etc.
5622 2003-12-04 Martin Baulig <martin@ximian.com>
5624 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
5625 `Type.MakeArrayType()' for array types.
5627 2003-11-18 Miguel de Icaza <miguel@ximian.com>
5629 * expression.cs (Invocation.VerifyArgumentsCompat): Remove
5632 (SizeOf.DoResolve): assign the `type_queried' field. This gets
5635 2003-11-16 Martin Baulig <martin@ximian.com>
5637 * codegen.cs (EmitContext.IsGeneric): Removed.
5639 * ecore.cs (SimpleName.ResolveAsTypeStep): Always call
5640 ResolveGeneric() on the DeclSpace.
5642 2003-11-16 Martin Baulig <martin@ximian.com>
5644 * generic.cs (TypeArguments.Resolve):
5645 `Expression.ResolveAsTypeTerminal()' returns a TypeExpr; call
5646 `ResolveType()' on it to get the Type.
5648 2003-11-15 Martin Baulig <martin@ximian.com>
5650 * generic.cs (ConstructedType.GetInterfaces): Override this.
5652 2003-11-14 Martin Baulig <martin@ximian.com>
5654 * interface.cs (Interface.DefineType): Define all type parameters
5655 before adding the interfaces we inherit.
5657 2003-11-11 Martin Baulig <martin@ximian.com>
5659 * generic.cs (ConstructedType.ResolveType): Always call
5660 `gt.BindGenericParameters (atypes)'; also if `args.HasTypeArguments'.
5662 2003-11-10 Martin Baulig <martin@ximian.com>
5664 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
5665 (TypeManager.InitCoreTypes): Initialize them here, but instead of
5666 calling `ResolveType()' on them, directly assign their `Type'.
5668 2003-11-08 Martin Baulig <martin@ximian.com>
5670 * generic.cs (ConstructedType): Override `IsClass' etc.
5672 2003-11-08 Martin Baulig <martin@ximian.com>
5674 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
5675 return value and the `out parent' parameter.
5676 (TypeContainer.DefineType): Moved the CS0644 check into
5677 GetClassBases(). Don't pass the interface types to the
5678 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
5679 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
5681 * ecore.cs (TypeExpr.IsAttribute): New property.
5682 (TypeExpr.GetInterfaces): New method.
5684 * interface.cs (Interface.GetInterfaceTypeByName): Return a
5685 TypeExpr instead of a Type.
5686 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
5687 (Interface.DefineType): Don't pass the interface types to the
5688 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
5689 them later and then call `TypeBulider.AddInterfaceImplementation()'.
5691 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
5692 instead of a `Type[]'.
5693 (TypeManager.RegisterBuilder): Likewise.
5694 (TypeManager.AddUserInterface): Likewise.
5695 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
5696 `Type[]' and also return a `TypeExpr[]'.
5697 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
5699 2003-11-08 Martin Baulig <martin@ximian.com>
5701 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
5704 2003-11-08 Martin Baulig <martin@ximian.com>
5706 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
5707 TypeManager.ResolveExpressionTypes().
5709 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
5710 instead of an Expression.
5711 (TypeExpr): This is now an abstract base class for `TypeExpression'.
5712 (TypeExpression): New public class; formerly known as `TypeExpr'.
5714 * expression.cs (ComposedCast): Derive from TypeExpr.
5716 * typemanager.cs (TypeManager.system_*_expr): These are now
5717 TypExpr's instead of Expression's.
5718 (TypeManager.ResolveExpressionTypes): New public static function;
5719 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
5722 2003-11-06 Miguel de Icaza <miguel@ximian.com>
5724 * expression.cs (New.DoResolve): Do not dereference value that
5725 might be a null return.
5727 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
5728 sure that the constant value has the right type. Fixes an
5729 unreported bug, similar to 50425.
5731 * const.cs (Const.LookupConstantValue): Call
5732 ImplicitStandardConversionExists before doing a conversion to
5733 avoid havng the TypeManager.ChangeType do conversions.
5735 Reduced the number of casts used
5737 (Const.ChangeType): New routine to enable reuse of the constant
5738 type changing code from statement.
5740 * typemanager.cs (ChangeType): Move common initialization to
5741 static global variables.
5745 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
5746 every value type to go through, even if it was void. Fix that.
5748 * cs-tokenizer.cs: Use is_identifier_start_character on the start
5749 character of the define, and the is_identifier_part_character for
5750 the rest of the string.
5752 2003-11-05 Miguel de Icaza <miguel@ximian.com>
5754 * expression.cs (UnaryMutator.EmitCode): When I updated
5755 LocalVariableReference.DoResolve, I overdid it, and dropped an
5756 optimization done on local variable references.
5758 2003-11-04 Miguel de Icaza <miguel@ximian.com>
5760 * ecore.cs: Convert the return from Ldlen into an int.
5762 2003-10-20 Miguel de Icaza <miguel@ximian.com>
5764 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
5765 the accessibility, this is a special case for toplevel non-public
5766 classes (internal for instance).
5768 2003-10-20 Nick Drochak <ndrochak@gol.com>
5770 * ecore.cs: Fix typo and build. Needed another right paren.
5772 2003-10-19 Miguel de Icaza <miguel@ximian.com>
5774 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
5775 `internal' case regular and protected, but not allowing protected
5776 to be evaluated later. Bug 49840
5778 2003-10-15 Miguel de Icaza <miguel@ximian.com>
5780 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
5781 to kb.Nlast, and not the kb.nFirst to isolate the switch
5784 Extract the underlying type, so enumerations of long/ulong are
5785 treated like long/ulong.
5787 2003-10-14 Miguel de Icaza <miguel@ximian.com>
5789 * expression.cs (New): Overload the meaning of RequestedType to
5790 track the possible creation of the NewDelegate type, since
5791 DoResolve is invoked more than once for new constructors on field
5794 See bugs: #48800 and #37014
5796 * cs-parser.jay (declare_local_constants): Take an arraylist
5797 instead of a single constant.
5799 (local_constant_declaration): It should take a
5800 constant_declarators, not a constant_declarator. Fixes 49487
5802 * convert.cs: Fix error report.
5804 2003-10-13 Jackson Harper <jackson@ximian.com>
5806 * typemanager.cs (TypeToCoreType): Add float and double this fixes
5809 2003-11-03 Martin Baulig <martin@ximian.com>
5811 * expression.cs (ArrayAccess.GetStoreOpcode): Added
5812 `out bool has_type_arg'; if set, we need to pass the type to
5814 (ArrayAccess.GetStoreOpcode, ArrayAccess.EmitLoadOpcode): Use
5815 Stelem_Any/Ldelem_Any for generic parameters.
5817 2003-11-02 Martin Baulig <martin@ximian.com>
5819 * expression.cs (Invocation.EmitCall): Use
5820 `TypeManager.IsValueType()' to check whether it's a value type.
5821 Don't set `struct_call' when calling a method on a type parameter.
5823 2003-11-02 Martin Baulig <martin@ximian.com>
5825 * generics.cs (ConstructedType.Resolve): Renamed to ResolveType()
5826 and removed the TypeBuilder argument.
5828 * typemanager.cs (TypeManager.IsValueType): Return
5829 `t.IsGenericParameter || t.IsValueType'.
5831 2003-10-25 Martin Baulig <martin@ximian.com>
5833 * decl.cs (DeclSpace.ResolveType): If we're a ConstructedType,
5834 call ConstructedType.Resolve() on it.
5836 * generic.cs (ConstructedType.Resolve): Set `type' on success.
5838 2003-10-25 Martin Baulig <martin@ximian.com>
5840 * class.cs (TypeContainer.GetClassBases): Changed
5841 `out Type parent' into `out TypeExpr parent'. Moved CS0644 and
5842 CS8214 reporting here.
5843 (TypeContainer.DefineType): GetClassBases() gives us a `TypeExpr'
5844 instead of a `Type' for our parent. In case of a recursive
5845 declaration (see tests/gen-23.cs for an example), our parent is a
5846 ConstructedType and it doesn't have its type set. So, first
5847 create our own TypeBuilder, then call constructed.Resolve() to get
5848 the parent's type and finally TypeBuilder.SetParent() it.
5850 * ecore.cs (TypeExpr.Name): New public virtual property.
5853 (ConstructedType): We're now a TypeExpr and not just an Expression.
5854 (ConstructedType.ResolveAsTypeStep): Don't resolve our type
5855 arguments here; this is done later.
5856 (ConstructedType.Resolve): New public method to resolve the type
5857 arguments and bind them.
5859 2003-10-21 Martin Baulig <martin@ximian.com>
5861 * convert.cs: Use `TypeManager.IsValueType' instead of
5862 'type.IsValueType' everywhere.
5864 * typemanager.cs (TypeManager.IsValueType): Return true for type
5865 parameters. The reason for this is that we need to box a type
5866 parameter when converting it to a reference type.
5868 * cs-parser.jay: Added support for default value expressions.
5870 * generics.cs (DefaultValueExpression): New public class.
5872 2003-10-17 Martin Baulig <martin@ximian.com>
5874 * generic.cs (Constraints.Resolve): Take a DecpSpace instead of a
5875 TypeContainer so we can also use this for Interfaces.
5876 (TypeParameter.Resolve): Likewise.
5878 * interface.cs (Interface.DefineType): Added support for generic
5881 * cs-parser.jay: Added support for generic structs and interfaces.
5883 2003-10-17 Martin Baulig <martin@ximian.com>
5885 * generic.cs (GenericMemberAccess.DoResolve): We can now actually
5886 call generic methods :-)
5888 2003-10-16 Martin Baulig <martin@ximian.com>
5890 * cs-parser.jay (namespace_or_type_name): Only create a
5891 GenericMemberAccess if we actually have type arguments.
5893 2003-10-13 Martin Baulig <martin@ximian.com>
5895 * class.cs (Method.Define): If we're a generic method, call
5896 TypeBuilder.DefineGenericMethod () before resolving
5898 (MethodData): Added .ctor which takes an additional MethodBuilder
5899 argument; this is used for generic methods.
5900 (MethodData.Define): Call `builder.SetGenericMethodSignature()' if
5901 we already have a MethodBuilder.
5903 2003-10-10 Martin Baulig <martin@ximian.com>
5905 * class.cs (Method): Added .ctor which takes a `GenericMethod'
5906 instead of a `DeclSpace'. This is used for generic methods.
5908 * cs-parser.jay (method_header): Added support for generic
5909 methods; create a `GenericMethod' instance and pass it to the
5910 `Method's .ctor; it'll be used as the `DeclSpace' to lookup
5911 parameters and locals.
5913 * decl.cs (DeclSpace.SetParameterInfo): Removed Location argument
5914 since we already have the location. Check whether we're a generic
5915 type declaration or a generic method and create the correct type
5918 * generic.cs (TypeParameter.DefineMethod): New public method.
5919 (GenericMethod): New public class; derives from DeclSpace and is
5920 used for generic methods.
5922 2003-10-09 Martin Baulig <martin@ximian.com>
5924 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
5926 (MethodCore.DoDefineParameters): Removed the TypeContainer
5927 argument; use the DeclSpace which was passed to the .ctor instead.
5928 (MethodCore.CheckParameter): Take a DeclSpace instead of a
5929 TypeContainer; we only need a DeclSpace here.
5931 2003-10-09 Martin Baulig <martin@ximian.com>
5933 * class.cs (MethodData): Added additional `DeclSpace ds' argument
5935 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
5936 EmitContext's .ctor.
5938 2003-10-09 Martin Baulig <martin@ximian.com>
5940 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
5941 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
5942 AsAccessible(), moved them as well.
5944 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
5946 2003-10-07 Miguel de Icaza <miguel@ximian.com>
5948 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
5949 generation for >=, as spotted by Paolo, bug 48679.
5950 Patch from David Waite.
5952 * cs-tokenizer.cs: Add handling for #pragma.
5954 * cs-parser.jay: Allow for both yield and yield return in the
5955 syntax. The anti-cobolization of C# fight will go on!
5957 * class.cs (TypeBuilder.DefineType): Catch error condition here
5958 (Parent.DefineType erroring out and returning null).
5960 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
5961 coping with enumerations variables, we were mistakenly processing
5962 them as a regular value type instead of built-in types. Fixes the
5965 * typemanager.cs (IsBuiltinOrEnum): New method.
5967 2003-09-30 Miguel de Icaza <miguel@ximian.com>
5969 * cs-parser.jay: Upgrade: yield now needs the return clause.
5971 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
5973 * cs-parser.jay : Renamed yyName to yyNames related to jay.
5975 2003-09-29 Martin Baulig <martin@ximian.com>
5977 * typemanager.cs (TypeManager.GetMethodFlags): Added support for
5978 inflated generic methods.
5980 * generics.cs (ConstructedType): Distinguish between open and
5981 closed constructed types; correctly resolve the arguments.
5983 2003-09-22 Martin Baulig <martin@ximian.com>
5985 * generic.cs (ConstructedType.ResolveAsTypeCheck): Check whether
5986 all type arguments meet their constraints.
5988 2003-09-19 Martin Baulig <martin@ximian.com>
5990 * decl.cs (MemberCache.SetupCacheForInterface): Take a
5991 `MemberCache parent' argument. Normally, an interface doesn't
5992 have a parent type except System.Object, but we use this in gmcs
5993 for generic type parameters.
5995 2003-09-18 Martin Baulig <martin@ximian.com>
5997 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
5998 on `type.IsInterface'; don't check whether the type has a parent
5999 to determine whether it's an interface.
6001 2003-09-17 Martin Baulig <martin@ximian.com>
6003 * generic.cs (ConstructedType.ToString): Always use `name' as the
6006 2003-09-15 Martin Baulig <martin@ximian.com>
6008 * cs-parser.jay: Fix grammar wrt. type_parameter_constraints.
6010 * generic.cs (Constraints.Resolve): New public method; this is
6011 called to resolve the constraint types and to check whether all
6012 the constraints are correct.
6013 (Constraints.Types): New public property.
6014 (TypeParameter.Resolve): New public method; resolves all the
6017 * class.cs (TypeContainer.DefineType): Call
6018 TypeParameter.Resolve() before actually defining the type.
6020 2003-09-15 Martin Baulig <martin@ximian.com>
6022 * class.cs (TypeContainer.DefineType): Added an error flag to
6023 avoid reporting duplicate CS0146's ("class definition is
6026 * driver.cs (Driver.MainDriver): Abort if
6027 RootContext.ResolveTree() reported any errors.
6029 2003-09-07 Martin Baulig <martin@ximian.com>
6031 * report.cs (Error, Warning): Added overloaded versions which take
6032 a `params object[] args' and call String.Format().
6034 2003-09-07 Martin Baulig <martin@ximian.com>
6036 * decl.cs (DeclSpace..ctor): Don't call
6037 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
6038 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
6039 (DeclSpace.RecordDecl): New method.
6041 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
6043 2003-09-02 Ravi Pratap <ravi@ximian.com>
6045 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
6046 value attributes to be applied to ParameterBuilders.
6048 * class.cs (MethodCore.LabelParameters): Make static and more
6049 generic so that it can be used from other places - like interface
6050 methods, for instance.
6052 * interface.cs (Interface.Emit): Call LabelParameters before
6053 emitting attributes on the InterfaceMethod.
6055 2003-09-07 Martin Baulig <martin@ximian.com>
6057 * generic.cs (ConstructedType.ResolveAsTypeStep): Report a CS8217
6058 if the number of type parameters doesn't match.
6060 2003-09-04 Martin Baulig <martin@ximian.com>
6062 * expression.cs (ComposedCast.ResolveAsTypeStep): Added support
6063 for arrays of generic type params (ie. `!0[]').
6065 2003-09-04 Martin Baulig <martin@ximian.com>
6067 * class.cs (TypeContainer.AsAccessible): Ignore generic parameters
6070 2003-09-04 Martin Baulig <martin@ximian.com>
6072 * decl.cs (DeclSpace.LookupGeneric): New method.
6073 (DeclSpace.CheckAccessLevel): Ignore generic parameters for the
6076 * generic.cs (TypeParameterExpr): Take a TypeParameter as
6077 argument, not just a string.
6078 (TypeParameter.Define): New public method; this is called to
6079 actually define the generic parameter; after this, you can use the
6080 new `Type' property to get the type.
6082 2003-09-04 Martin Baulig <martin@ximian.com>
6084 * decl.cs (DeclSpace.SetParameterInfo): The `constraints' argument
6085 is now an ArrayList; initialize the result of the `TypeParameters'
6087 (DeclSpace.GetGenericData): Removed.
6088 (DeclSpace.LookupGeneric): Temporarily removed; we need to
6089 implement this in a different way.
6090 (DeclSpace.GetTypeParameters): Removed; there's now a
6091 `TypeParameters' property.
6092 (DeclSpace.TypeParameters): New public property.
6094 * generic.cs (Constraints): Make this class public.
6095 (TypeParameter): New public class.
6097 2003-09-04 Martin Baulig <martin@ximian.com>
6099 * decl.cs (DeclSpace.GetTypeParameters): New method to return the
6102 * class.cs (TypeContainer.DefineType): Call
6103 TypeBuilder.DefineGenericParameter () on all generic parameters if
6104 this is a generic type.
6106 2003-08-28 Martin Baulig <martin@ximian.com>
6108 * sample-stack.il: Compile this with ilasm: "ilasm /dll
6111 * sample-hello.cs: Compile this with gmcs: "gmcs
6112 /r:sample-stack.dll sample-hello.cs".
6114 2003-08-28 Martin Baulig <martin@ximian.com>
6116 * generic.cs (ConstructedType.ResolveAsTypeStep): Actually bind
6117 the parameters to the generic type.
6119 2003-08-28 Martin Baulig <martin@ximian.com>
6121 * cs-tokenizer.cs (parse_less_than): Also allow all builtin types.
6123 2003-08-28 Martin Baulig <martin@ximian.com>
6125 * cs-parser.jay (opt_type_argument_list): Use
6126 `OP_GENERICS_LT type_arguments OP_GENERICS_GT'.
6127 (primary_expression): Replace `qualified_identifier' with `type_name'.
6128 (type_parameter_list): Use `OP_GENERICS_LT type_parameters OP_GENERICS_GT'.
6130 * cs-tokenizer.cs (is_punct): When reading a `<', invoke a custom
6131 parser to check whether it is syntactically a type parameter list;
6132 return OP_GENERICS_LT/OP_GENERICS_GT instead of OP_LT/OP_GT in
6135 2003-08-26 Martin Baulig <martin@ximian.com>
6137 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
6138 resolving aliases; fixes #47927.
6140 2003-08-26 Martin Baulig <martin@ximian.com>
6142 * statement.cs (Using.DoResolve): This is internally emitting a
6143 try/finally clause, so we need to set ec.NeedExplicitReturn if we
6144 do not always return. Fixes #47681.
6146 2003-08-26 Martin Baulig <martin@ximian.com>
6148 * decl.cs (MemberCore): Moved WarningNotHiding(),
6149 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
6151 (AdditionResult): Make this nested in DeclSpace.
6152 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
6153 argument; call NamespaceEntry.Define() unless we're nested in a
6156 * namespace.cs (Namespace.DefineName): New public function. This
6157 is called from DeclSpace's .ctor to add
6158 (Namespace.Lookup): Include DeclSpaces in the lookup.
6160 * class.cs (Operator): Derive from MemberBase, not MemberCore.
6162 * const.cs (Const): Derive from MemberBase, not MemberCore.
6164 2003-08-25 Martin Baulig <martin@ximian.com>
6166 * convert.cs (Convert.ExplicitReferenceConversion): When
6167 converting from an interface type to a class, unbox if the target
6168 type is a struct type. Fixes #47822.
6170 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6172 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
6175 2003-08-22 Martin Baulig <martin@ximian.com>
6177 * class.cs (TypeManager.DefineType): When defining a nested type,
6178 call DefineType() on our parent; fixes #47801.
6180 2003-08-22 Martin Baulig <martin@ximian.com>
6182 * class.cs (MethodData.Define): While checking if a method is an
6183 interface implementation, improve the test a bit more to fix #47654.
6185 2003-08-22 Martin Baulig <martin@ximian.com>
6187 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
6188 correctly; fixes #47722.
6190 2003-08-22 Martin Baulig <martin@ximian.com>
6192 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
6193 LocalVariableReference, ensure it's not read-only. Fixes #47536.
6195 * statement.cs (Fixed.DoResolve): Make all variables read-only.
6197 2003-08-22 Martin Baulig <martin@ximian.com>
6199 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
6200 can only be assigned in static constructors. Fixes #47161.
6202 2003-08-22 Martin Baulig <martin@ximian.com>
6204 Rewrote and improved the flow analysis code.
6206 * flowbranching.cs (FlowBranching): Make this class abstract.
6207 (FlowBranching.CreateBranching): New static function to create a
6209 (FlowBranchingBlock, FlowBranchingException): New classes.
6210 (FlowBranching.UsageVector.Type): New public readonly field.
6211 (FlowBranching.UsageVector.Breaks): Removed the setter.
6212 (FlowBranching.UsageVector.Returns): Removed the setter.
6213 (FlowBranching.UsageVector): Added Break(), Return(),
6214 NeverReachable() and Throw() methods to modify the reachability.
6215 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
6216 done by FlowBranching.Merge().
6217 (FlowBranching.UsageVector.MergeChild): New method; merges the
6218 merge result into the current vector.
6219 (FlowBranching.Merge): New abstract method to merge a branching.
6221 2003-08-12 Martin Baulig <martin@ximian.com>
6223 * expression.cs (Indirection.CacheTemporaries): Create the
6224 LocalTemporary with the pointer type, not its element type.
6226 2003-08-10 Miguel de Icaza <miguel@ximian.com>
6228 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
6229 token was a keyword or not.
6231 Add `error' options where an IDENTIFIER was expected; Provide
6232 CheckToken and CheckIdentifierToken convenience error reporting
6235 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
6237 * decl.cs: Rename `NamespaceEntry Namespace' public field into
6238 NameSpaceEntry NameSpaceEntry.
6240 (LookupInterfaceOrClass): Avoid creating a full qualified name
6241 from namespace and name: avoid doing lookups when we know the
6242 namespace is non-existant. Use new Tree.LookupByNamespace which
6243 looks up DeclSpaces based on their namespace, name pair.
6245 * driver.cs: Provide a new `parser verbose' to display the
6246 exception thrown during parsing. This is turned off by default
6247 now, so the output of a failure from mcs is more graceful.
6249 * namespace.cs: Track all the namespaces defined in a hashtable
6252 (IsNamespace): New method
6254 2003-08-09 Miguel de Icaza <miguel@ximian.com>
6256 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
6257 we know that we need to concatenate (full typename can never be
6262 * statement.cs: Use a bitfield; Do not initialize to null things
6263 which are done by the constructor by default.
6265 * cs-parser.jay: bug fix, parameter was 4, not 3.
6267 * expression.cs: Just use the property;
6269 * statement.cs: No need for GetVariableInfo method.
6271 2003-08-08 Martin Baulig <martin@ximian.com>
6273 * flowanalysis.cs (FlowReturns): This is now nested in the
6274 `FlowBranching' class.
6275 (MyBitVector): Moved this here from statement.cs.
6276 (FlowBranching.SiblingType): New enum type.
6277 (FlowBranching.CreateSibling): Added `SiblingType' argument.
6279 2003-08-07 Martin Baulig <martin@ximian.com>
6281 * flowanalysis.cs (FlowBranchingType): This is now nested in the
6282 `FlowBranching' class and called `BranchingType'.
6284 2003-08-07 Martin Baulig <martin@ximian.com>
6286 * flowanalysis.cs: Moved all the control flow analysis code into
6289 2003-08-07 Martin Baulig <martin@ximian.com>
6291 * assign.cs (Assign.DoResolve): `target' must either be an
6292 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
6295 2003-08-07 Miguel de Icaza <miguel@ximian.com>
6297 * expression.cs (BinaryMethod): This kind of expression is created by the
6298 Binary class if it determines that the operator has to be handled
6301 (BinaryDelegate): This kind of expression is created if we are
6302 dealing with a + or - operator on delegates.
6304 (Binary): remove method, argumetns, and DelegateOperator: when
6305 dealing with methods,
6307 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
6309 * statement.cs (Block): use bitfields for the three extra booleans
6310 we had in use. Remove unused topblock parameter.
6312 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
6314 * assign.cs: Drop extra unneeded tests.
6316 2003-08-06 Miguel de Icaza <miguel@ximian.com>
6318 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
6320 * statement.cs (Foreach): Use VariableStorage instead of
6323 * codegen.cs (VariableStorage): New class used by clients that
6324 require a variable stored: locals or fields for variables that
6325 need to live across yield.
6327 Maybe provide a convenience api for EmitThis+EmitLoad?
6329 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
6332 2003-08-05 Miguel de Icaza <miguel@ximian.com>
6334 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
6335 RemapParameterLValue): New methods that are used to turn a
6336 precomputed FieldInfo into an expression like this:
6340 The idea is to use this instead of making LocalVariableReference
6341 have more than one meaning.
6343 * cs-parser.jay: Add error production to BASE.
6345 * ecore.cs: Deal with TypeManager.GetField returning null, which
6346 is now a valid return value.
6348 (FieldExprNoAddress): New expression for Fields whose address can
6351 * expression.cs (LocalVariableReference): During the resolve
6352 phases, create new expressions if we are in a remapping context.
6353 Remove code that dealt with remapping here.
6355 (ParameterReference): same.
6357 (ProxyInstance): New expression, like the `This' expression, but
6358 it is born fully resolved. We know what we are doing, so remove
6359 the errors that are targeted to user-provided uses of `this'.
6361 * statement.cs (Foreach): our variable is now stored as an
6362 Expression; During resolution, follow the protocol, dont just
6363 assume it will return this.
6365 2003-08-06 Martin Baulig <martin@ximian.com>
6367 * support.cs (SeekableStreamReader.cs): New public class.
6369 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
6370 SeekableStreamReader instead of the normal StreamReader.
6372 2003-08-04 Martin Baulig <martin@ximian.com>
6374 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
6375 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
6376 deambiguate casts and delegate invocations.
6377 (parenthesized_expression): Use the new tokens to ensure this is
6378 not a cast of method invocation.
6380 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
6381 when reading a `)' and Deambiguate_CloseParens () was previously
6384 * expression.cs (ParenthesizedExpression): New class. This is
6385 just used for the CS0075 test.
6386 (Binary.DoResolve): Check for CS0075.
6388 2003-07-29 Ravi Pratap <ravi@ximian.com>
6390 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
6391 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
6392 reference comparison.
6394 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
6395 examine the ReturnType for equality - this is necessary in the
6396 cases of implicit and explicit operators whose signature also
6397 includes the return type.
6399 2003-07-26 Miguel de Icaza <miguel@ximian.com>
6401 * namespace.cs: Cache the result of the namespace computation,
6402 instead of computing it every time.
6404 2003-07-24 Miguel de Icaza <miguel@ximian.com>
6406 * decl.cs: Use a global arraylist that we reuse over invocations
6407 to avoid excesive memory consumption. Reduces memory usage on an
6408 mcs compile by one meg (45 average).
6410 * typemanager.cs (LookupTypeReflection): In .NET pointers are
6411 private, work around that.
6413 2003-07-23 Miguel de Icaza <miguel@ximian.com>
6415 * literal.cs (IntLiteral): Define Zero and One static literals.
6417 * cs-parser.jay (integer_literal): use static literals to reduce
6418 memory usage for the most used literals (0, 1 and -1). 211kb
6419 reduced in memory usage.
6421 Replace all calls to `new ArrayList' with `new
6422 ArrayList(4)' which is a good average number for most allocations,
6423 and also requires only 16 bytes of memory for its buffer by
6426 This reduced MCS memory usage in seven megabytes for the RSS after
6429 2003-07-28 Ravi Pratap <ravi@ximian.com>
6431 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
6432 handle params methods the correct way by forming only one
6433 applicable set with params and normal methods in them. Earlier we
6434 were looking at params methods only if we found no normal methods
6435 which was not the correct thing to do.
6437 (Invocation.BetterFunction): Take separate arguments indicating
6438 when candidate and the best method are params methods in their
6441 This fixes bugs #43367 and #46199.
6443 * attribute.cs: Documentation updates.
6445 (CheckAttribute): Rename to CheckAttributeTarget.
6446 (GetValidPlaces): Rename to GetValidTargets.
6448 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
6449 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
6453 2003-07-28 Miguel de Icaza <miguel@ximian.com>
6455 * codegen.cs: Compute IsGeneric correctly.
6457 * cs-parser.jay: Introduce OP_GENERIC_LT for the grammar ambiguity
6460 Bring back (temporarily) OP_LEFT_SHIFT, OP_RIGHT_SHIFT,
6461 OP_SHIFT_RIGHT_ASSIGN, OP_SHIFT_LEFT_ASSIGN. There were too many
6462 regressions, and I was chasing more bugs than I required.
6464 * interface.cs: Use expressions for base type names (like classes
6465 and structs have been doing for a while now), and resolve that.
6466 This patch should probably go into head as well.
6468 This makes it one less user of FindType.
6470 2003-07-24 Miguel de Icaza <miguel@ximian.com>
6472 This compiler can not self host currently. Need to fix that.
6474 * Makefile: compile to `gmcs.exe'
6476 * driver.cs: Turn on v2 by default on gmcs.
6478 * generic.cs (ConstructedType): Does no longer take a container
6479 type argument; That will be taken care of later.
6481 (ConstructedType.DoResolve, ConstructedType.ResolveAsTypeStep):
6482 Use SimpleName to resolve for now, so we can continue the work on
6483 the parser, until we get Type.GetType that understands generics.
6485 (ConstructedType.ToString): Implement
6487 (TypeArguments.Resolve): Resolve the child expressions as types.
6489 * cs-parser.jay: Rename interface_constraints to
6490 type_parameter_constraints
6492 (namespace_or_type_name): Only use constructed types for the basic
6493 construction, we will deal with identifier<...> later.
6495 (type/type_name): No longer call DecomposeQI, as
6496 namespace_or_type_name is always decoded now.
6498 2003-07-22 Ravi Pratap <ravi@ximian.com>
6500 * expression.cs (Invocation.OverloadResolve): Follow the spec more
6501 closely: we eliminate methods in base types when we have an
6502 applicable method in a top-level type.
6504 Please see section 14.5.5.1 for an exact description of what goes
6507 This fixes bug #45127 and a host of other related to corlib compilation.
6509 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
6510 array is the method corresponding to the top-level type (this is
6511 because of the changes made to icall.c) so we change this
6514 (MethodGroupExpr.Name): This too.
6516 * typemanager.cs (GetElementType): New method which does the right
6517 thing when compiling corlib.
6519 * everywhere: Make use of the above in the relevant places.
6521 2003-07-22 Martin Baulig <martin@ximian.com>
6523 * cs-parser.jay (invocation_expression): Moved
6524 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
6525 `cast_expression', but create a InvocationOrCast which later
6526 resolves to either an Invocation or a Cast.
6528 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
6529 method; call this before EmitStatement() to make sure that this
6530 expression can be used as a statement.
6532 * expression.cs (InvocationOrCast): New class; resolves to either
6533 an Invocation or a Cast.
6535 * statement.cs (StatementExpression): Call ResolveStatement() on
6536 the ExpressionStatement before emitting it.
6538 2003-07-21 Martin Baulig <martin@ximian.com>
6540 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
6541 `ref' and `out' attributes match; fixes #46220.
6542 (MemberAccess.ResolveMemberAccess): You can't reference a type
6543 through an expression; fixes #33180.
6544 (Indexers.GetIndexersForType): Don't return the indexers from
6545 interfaces the class implements; fixes #46502.
6547 2003-07-21 Martin Baulig <martin@ximian.com>
6549 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
6550 CS0661 checks; fixes bug #30442.
6552 2003-07-21 Martin Baulig <martin@ximian.com>
6554 * decl.cs (AdditionResult): Added `Error'.
6556 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
6558 * typemanager.cs (TypeManager.ChangeType): Catch exceptions; makes
6559 cs0031.cs actually work.
6561 2003-07-20 Miguel de Icaza <miguel@ximian.com>
6563 * cs-parser.jay (namespace_name): do not use
6564 namespace_or_type_name, use qualified_identifier, because
6565 namespace_or_type_name will soon return a composed expression
6566 instead of a string.
6568 (namespace_or_type_name): Instead of returning a string, now this
6569 production returns an expression.
6571 * codegen.cs (EmitContext): Setup IsGeneric property based on
6572 whether our DeclSpace is generic, our the method is generic.
6574 * modifier.cs (Modifiers.METHOD_GENERIC): New definition, use if
6575 the method is generic.
6577 * cs-parser.jay (type_arguments, opt_type_argument_list,
6578 type_parameters, type_parameter_list, opt_type_parameter_list,
6579 type_parameter,, opt_type_parameter_constraints_clauses,
6580 type_parameter_constraints_clauses,
6581 type_parameter_constraint_clause, type_parameter_constraint,
6582 interface_constraints): Add new production
6584 * decl.cs (DeclSpace): IsGeneric, flag to track whether this
6585 DeclSpace is generic or not.
6587 (DeclSpace.SetParameterInfo): New routine, used to set the
6588 parameter info for a type.
6590 (DeclSpace.LookupGeneric): Lookups a name, and if it is a generic,
6591 returns a GenericTypeExpr
6593 * ecore.cs (SimpleName.ResolveAsTypeStep): If our container is
6594 generic, lookup the generic argument.
6596 * attribute.cs: Do not allow TypeParameterExpressions in
6599 * class.cs: Do not allow the Main method to be defined in a
6602 * expression.cs (SizeOf): Do not allow generic types to be used as
6603 arguments to sizeof.
6605 * typemanager.cs (IsGeneric): Wrapper for Reflection when we have
6606 it: whether a type is generic or not. Only works for types we are
6607 currently building for now.
6609 2003-07-20 Martin Baulig <martin@ximian.com>
6611 * namespace.cs: Fixed that bug which caused a crash when compiling
6614 2003-07-20 Miguel de Icaza <miguel@ximian.com>
6616 * typemanager.cs (LookupTypeReflection): Never expose types which
6617 are NotPublic, NestedPrivate, NestedAssembly, or
6618 NestedFamANDAssem. We used to return these, and later do a check
6619 that would report a meaningful error, but the problem is that we
6620 would not get the real match, if there was a name override.
6622 2003-07-18 Miguel de Icaza <miguel@ximian.com>
6624 * namespace.cs (Namespace, Name): Do not compute the namespace
6625 name dynamically, compute it in the constructor. This reduced
6626 memory usage by 1697 KB.
6628 * driver.cs: Use --pause to pause at the end.
6630 2003-07-17 Peter Williams <peter@newton.cx>
6632 * Makefile: Change the name of the test target so that it doesn't
6633 conflict with the recursive test target.
6635 2003-07-17 Miguel de Icaza <miguel@ximian.com>
6637 * expression.cs (LocalVariableReference.Emit, EmitAssign,
6638 AddressOf): Do not use EmitThis, that was wrong, use the actual
6641 2003-07-15 Miguel de Icaza <miguel@ximian.com>
6643 * class.cs (MethodData.Define): While checking if a method is an
6644 interface implementation, improve the test: If we are not public
6645 (use new test here: use the computed MethodAttributes directly,
6646 instead of the parsed modifier flags) check if the `implementing'
6647 method comes from an interface or not.
6649 * pending.cs (VerifyPendingMethods): Slightly better error
6652 * makefile: add test target that does the mcs bootstrap.
6654 2003-07-16 Ravi Pratap <ravi@ximian.com>
6656 * interface.cs (Define): Do nothing here since there are no
6657 members to populate etc. Move the attribute emission out of here
6658 since this was just totally the wrong place to put it. Attribute
6659 application happens during the 'Emit' phase, not in the 'Define'
6662 (Emit): Add this method and move the attribute emission here
6664 * rootcontext.cs (EmitCode): Call the Emit method on interface
6667 2003-07-14 Ravi Pratap M <ravi@ximian.com>
6669 * expression.cs (OverloadResolve): Report error only if Location
6670 is not 'Null' which means that there was a probe going on.
6672 2003-07-14 Martin Baulig <martin@ximian.com>
6674 * expression.cs (ConditionalLogicalOperator): New public class to
6675 implement user defined conditional logical operators.
6676 This is section 14.11.2 in the spec and bug #40505.
6678 2003-07-14 Martin Baulig <martin@ximian.com>
6680 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
6682 2003-07-14 Martin Baulig <martin@ximian.com>
6684 * codegen.cs (EmitContext.InFixedInitializer): New public field.
6686 * ecore.cs (IVariable.VerifyFixed): New interface method.
6688 * expression.cs (Unary.ResolveOperator): When resolving the `&'
6689 operator, check whether the variable is actually fixed. Fixes bug
6690 #36055. Set a variable definitely assigned when taking its
6691 address as required by the spec.
6693 * statement.cs (LocalInfo.IsFixed): New field.
6694 (LocalInfo.MakePinned): Set `IsFixed' to true.
6696 2003-07-14 Ravi Pratap M <ravi@ximian.com>
6698 * attribute.cs (Attribute.Resolve): While doing a Member lookup
6699 for .ctors, ensure that we only ask for members declared in the
6700 attribute type (BindingFlags.DeclaredOnly).
6704 * expression.cs (Error_WrongNumArguments): Report error 1501
6705 correctly the way CSC does.
6707 2003-07-13 Martin Baulig <martin@ximian.com>
6709 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
6710 lookup on the fully qualified name, to make things like "X.X" work
6711 where "X.X" is a fully qualified type name, but we also have a
6712 namespace "X" in the using list. Fixes #41975.
6714 2003-07-13 Martin Baulig <martin@ximian.com>
6716 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
6717 function. If we're a CompoundAssign, we need to create an embedded
6718 CompoundAssign, not an embedded Assign.
6719 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
6722 2003-07-13 Martin Baulig <martin@ximian.com>
6724 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
6725 work to fix bug #46088.
6727 2003-07-13 Ravi Pratap <ravi@ximian.com>
6729 * class.cs (Operator.Emit): Do not emit attributes here - it is
6730 taken care of by the Method class that we delegate too. This takes
6733 2003-07-10 Martin Baulig <martin@ximian.com>
6735 * expression.cs (TypeOfVoid): New class.
6736 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
6738 2003-07-10 Martin Baulig <martin@ximian.com>
6740 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
6743 2003-07-10 Martin Baulig <martin@ximian.com>
6745 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
6746 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
6748 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
6750 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
6752 2003-07-10 Martin Baulig <martin@ximian.com>
6754 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
6755 of decimal. Fixes #42850.
6757 NOTE: I also fixed the created byte blob, but this doesn't work on
6758 the MS runtime and csc never produces any byte blobs for decimal
6761 2003-07-10 Martin Baulig <martin@ximian.com>
6763 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
6764 structs; fixes #32068.
6765 (Block.AddChildVariableNames): Fixed #44302.
6767 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6769 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
6771 2003-07-07 Miguel de Icaza <miguel@ximian.com>
6773 * attribute.cs: And this test is onger needed.
6775 2003-07-08 Martin Baulig <martin@ximian.com>
6777 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
6778 inaccessible types. Fixes #36313.
6780 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
6782 * namespace.cs (NamespaceEntry): Create implicit entries for all
6783 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
6784 implicit entries for N1.N2 and N1.
6786 2003-07-08 Martin Baulig <martin@ximian.com>
6788 Rewrote the handling of namespaces to fix a lot of the issues
6789 wrt. `using' aliases etc.
6791 * namespace.cs (Namespace): Splitted this class into a
6792 per-assembly `Namespace' and a per-file `NamespaceEntry'.
6794 * typemanager.cs (TypeManager.IsNamespace): Removed.
6795 (TypeManager.ComputeNamespaces): Only compute namespaces from
6796 loaded assemblies here, not the namespaces from the assembly we're
6797 currently compiling.
6799 2003-07-08 Martin Baulig <martin@ximian.com>
6801 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
6803 2003-07-07 Miguel de Icaza <miguel@ximian.com>
6805 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
6808 I thought about the memory savings here, but LookupTypeReflection
6809 is used under already very constrained scenarios. Compiling
6810 corlib or mcs only exposes one hit, so it would not really reduce
6811 any memory consumption.
6813 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6815 * typemanager.cs: fixes bug #45889 by only adding public types from
6816 other assemblies to the list of known types.
6818 2003-07-07 Miguel de Icaza <miguel@ximian.com>
6820 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
6821 on the type we resolved.
6823 2003-07-05 Martin Baulig <martin@ximian.com>
6825 * pending.cs (PendingImplementation.ParentImplements): Don't
6826 create the proxy if the parent is abstract.
6828 * class.cs (TypeContainer.DefineIndexers): Process explicit
6829 interface implementations first. Fixes #37714.
6831 2003-07-04 Miguel de Icaza <miguel@ximian.com>
6833 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
6834 defined recursively; but since we modify the input parameters
6835 (left is set to `this' temporarily), we reset this value if the
6836 left_is_explicit is false, which gives the original semantics to
6839 * literal.cs (NullPointer): new class used to represent a null
6840 literal in a pointer context.
6842 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
6843 type is a pointer, use a NullPointer object instead of a
6844 NullLiteral. Closes 43687
6846 (ExplicitConversion): Convert pointer values using
6847 the conv opcode to the proper type.
6849 * ecore.cs (New): change ValueTypeVariable property into a method,
6850 that returns whether the valuetype is suitable for being used.
6852 * expression.cs (Binary.DoNumericPromotions): Only return if we
6853 the int constant was a valid uint, and we can return both left and
6854 right as uints. If not, we continue processing, to trigger the
6855 type conversion. This fixes 39018.
6857 * statement.cs (Block.EmitMeta): During constant resolution, set
6858 the CurrentBlock property on the emitcontext, so that we resolve
6859 constants propertly.
6861 2003-07-02 Martin Baulig <martin@ximian.com>
6863 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
6864 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
6866 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
6867 than emitting it here.
6869 * statement.cs: Fixed some more flow analysis bugs.
6871 2003-07-02 Martin Baulig <martin@ximian.com>
6873 * class.cs (MethodData.Define): When implementing interface
6874 methods, set Final unless we're Virtual.
6876 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
6877 check work for interface methods.
6879 2003-07-01 Martin Baulig <martin@ximian.com>
6881 * ecore.cs (EmitContext.This): Replaced this property with a
6882 GetThis() method which takes a Location argument. This ensures
6883 that we get the correct error location for a CS0188.
6885 2003-07-01 Miguel de Icaza <miguel@ximian.com>
6887 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
6888 ImplicitStandardConversion.
6890 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
6892 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
6894 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
6897 2003-06-30 Miguel de Icaza <miguel@ximian.com>
6899 * class.cs (Constructor.Define): Turn off initlocals for unsafe
6902 (MethodData.Define): Turn off initlocals for unsafe methods.
6904 2003-06-29 Miguel de Icaza <miguel@ximian.com>
6906 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
6907 complete; Fixes #37521.
6909 * delegate.cs: Use Modifiers.TypeAttr to compute the
6910 TypeAttributes, instead of rolling our own. This makes the flags
6911 correct for the delegates.
6913 2003-06-28 Miguel de Icaza <miguel@ximian.com>
6915 * class.cs (Constructor.Define): Set the private flag for static
6916 constructors as well.
6918 * cs-parser.jay (statement_expression): Set the return value to
6919 null, to avoid a crash when we catch an error.
6921 2003-06-24 Miguel de Icaza <miguel@ximian.com>
6923 * cs-parser.jay: Applied patch from Jackson that adds support for
6924 extern and unsafe modifiers to destructor declarations.
6926 * expression.cs: Report error 21 if the user is trying to index a
6929 * driver.cs: Add an error message, suggested by the bug report.
6931 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
6932 if we do not have a ": this ()" constructor initializer. Fixes 45149
6934 2003-06-14 Miguel de Icaza <miguel@ximian.com>
6936 * namespace.cs: Add some information to reduce FAQs.
6938 2003-06-13 Miguel de Icaza <miguel@ximian.com>
6940 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
6941 underlying enumeration types. Fixes #43915.
6943 * expression.cs: Treat ushort/short as legal values to be used in
6946 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
6948 * delegate.cs: transfer custom attributes for paramenters from
6949 the delegate declaration to Invoke and BeginInvoke.
6951 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
6953 * attribute.cs: handle custom marshalers and emit marshal info
6956 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
6958 * makefile.gnu: Added anonymous.cs to the compiler sources.
6960 2003-05-28 Miguel de Icaza <miguel@ximian.com>
6962 * iterators.cs: Change the name of the proxy class to include two
6965 * cs-parser.jay: Update grammar to include anonymous methods.
6967 * anonymous.cs: new file.
6969 2003-05-27 Miguel de Icaza <miguel@ximian.com>
6971 * class.cs (Field.Define): Add missing test for pointers and
6974 2003-05-27 Ravi Pratap <ravi@ximian.com>
6976 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
6977 we use the stobj opcode.
6979 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
6980 since it wasn't the correct fix.
6982 It still is puzzling that we are required to use stobj for IntPtr
6983 which seems to be a ValueType.
6985 2003-05-26 Miguel de Icaza <miguel@ximian.com>
6987 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
6988 during regular simple name resolution. Now, the trick is that
6989 instead of returning for processing the simplename, we do a
6990 TypeManager.LookupType (ie, a rooted lookup as opposed to a
6991 contextual lookup type). If a match is found, return that, if
6992 not, return for further composition.
6994 This fixes long-standing 30485.
6996 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
6997 using the address to initialize an object, do an Stobj instead of
6998 using the regular Stelem.
7000 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
7001 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
7002 Because if we are a BaseIndexerAccess that value will be true.
7005 * statement.cs (GotoCase.Resolve): Return after reporting an
7006 error, do not attempt to continue.
7008 * expression.cs (PointerArithmetic.Emit): If our operand is a
7009 long, convert our constants to match the operand before
7010 multiplying. Convert to I type before adding. Fixes 43670.
7012 2003-05-14 Ravi Pratap <ravi@ximian.com>
7014 * enum.cs (ImplicitConversionExists) : Rename to
7015 ImplicitEnumConversionExists to remove ambiguity.
7017 * ecore.cs (NullCast): New type of cast expression class which
7018 basically is very similar to EmptyCast with the difference being
7019 it still is a constant since it is used only to cast a null to
7023 * convert.cs (ImplicitReferenceConversion): When casting a null
7024 literal, we return a NullCast.
7026 * literal.cs (NullLiteralTyped): Remove - I don't see why this
7027 should be around anymore.
7029 The renaming (reported was slightly wrong). Corrections:
7031 ConvertImplicitStandard -> ImplicitConversionStandard
7032 ConvertExplicitStandard -> ExplicitConversionStandard
7034 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
7035 before passing them in !
7037 * convert.cs (ImplicitConversionStandard): When comparing for
7038 equal expr and target types, ensure that expr is not a
7041 In general, we must not be checking (expr_type ==
7042 target_type) in the top level conversion methods
7043 (ImplicitConversion, ExplicitConversion etc). This checking is
7044 done in the methods that they delegate to.
7046 2003-05-20 Miguel de Icaza <miguel@ximian.com>
7048 * convert.cs: Move Error_CannotConvertType,
7049 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
7050 ImplicitNumericConversion, ImplicitConversionExists,
7051 ImplicitUserConversionExists, StandardConversionExists,
7052 FindMostEncompassedType, FindMostSpecificSource,
7053 FindMostSpecificTarget, ImplicitUserConversion,
7054 ExplicitUserConversion, GetConversionOperators,
7055 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
7056 TryImplicitIntConversion, Error_CannotConvertImplicit,
7057 ConvertImplicitRequired, ConvertNumericExplicit,
7058 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
7059 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
7062 Perform the following renames:
7064 StandardConversionExists -> ImplicitStandardConversionExists
7065 ConvertImplicit -> ImplicitConversion
7066 ConvertImplicitStandard -> ImplicitStandardConversion
7067 TryImplicitIntConversion -> ImplicitIntConversion
7068 ConvertImplicitRequired -> ImplicitConversionRequired
7069 ConvertNumericExplicit -> ExplicitNumericConversion
7070 ConvertReferenceExplicit -> ExplicitReferenceConversion
7071 ConvertExplicit -> ExplicitConversion
7072 ConvertExplicitStandard -> ExplicitStandardConversion
7074 2003-05-19 Martin Baulig <martin@ximian.com>
7076 * statement.cs (TypeInfo.StructInfo): Made this type protected.
7077 (TypeInfo): Added support for structs having structs as fields.
7079 * ecore.cs (FieldExpr): Implement IVariable.
7080 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
7081 VariableInfo for the field.
7083 2003-05-18 Martin Baulig <martin@ximian.com>
7085 * expression.cs (This.DoResolve): Report a CS0027 if we're
7086 emitting a field initializer.
7088 2003-05-18 Martin Baulig <martin@ximian.com>
7090 * expression.cs (This.ResolveBase): New public function.
7091 (This.DoResolve): Check for CS0188.
7093 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
7096 * ecore.cs (MethodGroupExpr.DoResolve): Set the
7097 `instance_expression' to null if we don't have any non-static
7100 2003-05-18 Martin Baulig <martin@ximian.com>
7102 Reworked the way how local variables and parameters are handled by
7103 the flow analysis code.
7105 * statement.cs (TypeInfo, VariableMap): New public classes.
7106 (VariableInfo): New public class. This is now responsible for
7107 checking whether a variable has been assigned. It is used for
7108 parameters and local variables.
7109 (Block.EmitMeta): Take the InternalParameters as argument; compute
7110 the layout of the flow vectors here.
7111 (Block.LocalMap, Block.ParameterMap): New public properties.
7112 (FlowBranching): The .ctor doesn't get the InternalParameters
7113 anymore since Block.EmitMeta() now computes the layout of the flow
7115 (MyStructInfo): This class is now known as `StructInfo' and nested
7116 in `TypeInfo'; we don't access this directly anymore.
7118 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
7119 property and removed IsAssigned(), IsFieldAssigned(),
7120 SetAssigned() and SetFieldAssigned(); we now call them on the
7121 VariableInfo so we don't need to duplicate this code everywhere.
7123 * expression.cs (ParameterReference): Added `Block block' argument
7125 (LocalVariableReference, ParameterReference, This): The new
7126 VariableInfo class is now responsible for all the definite
7129 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
7130 IsParameterAssigned, SetParameterAssigned): Removed.
7132 2003-05-18 Martin Baulig <martin@ximian.com>
7134 * typemanager.cs (InitCoreTypes): Try calling
7135 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
7136 the 3-args-version. Corlib now also needs our `void_type'.
7137 (GetMethod): Added overloaded version which takes an optional
7138 `bool report_errors' to allow lookups of optional methods.
7140 2003-05-12 Martin Baulig <martin@ximian.com>
7142 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
7143 only used for locals and not for parameters.
7145 2003-05-12 Miguel de Icaza <miguel@ximian.com>
7147 * support.cs (InternalParameters.ParameterType): Return the
7148 ExternalType of the parameter.
7150 * parameter.cs (Parameter.ExternalType): drop the two arguments,
7153 2003-05-11 Miguel de Icaza <miguel@ximian.com>
7155 * class.cs (MethodData.Define): Do not set the `newslot' on
7156 interface members, if they are also flagged as "override".
7158 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
7159 better code for ++i and i++. This only works for static fields
7160 and local variables.
7162 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
7163 want to pull the DeclSpace out of the builder_to_declspace instead
7164 of the TypeBuilder (like in TypeContainer.FindMembers).
7166 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
7167 instead of LookupTypeContainer. Fixes the crash on .NET for
7168 looking up interface members.
7170 * const.cs: Create our own emit context during the Definition
7171 stage, so that constants are evaluated in the proper context, when
7172 a recursive definition happens.
7174 2003-05-11 Martin Baulig <martin@ximian.com>
7176 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
7177 new block for a switch section.
7178 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
7179 the adding/lookup in the switch block. Fixes #39828.
7181 2003-05-09 Miguel de Icaza <miguel@ximian.com>
7183 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
7184 functionality: I needed to convert the data after I had performed
7185 the add/sub operation into the operands type size.
7187 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
7188 pass the type for the box operation, otherwise the resulting
7189 object would have been of type object.
7191 (BoxedCast): Add constructor to specify the type to box as.
7193 2003-05-07 Miguel de Icaza <miguel@ximian.com>
7195 * iterators.cs: I was reusing the `count' variable inadvertently,
7196 take steps to not allow this to happen.
7198 2003-05-06 Miguel de Icaza <miguel@ximian.com>
7200 * attribute.cs (Attribute.Resolve): Params attributes are encoded
7201 by creating an array at the point where the params starts and
7202 putting all those arguments there, then adjusting the size of the
7205 2003-05-05 Miguel de Icaza <miguel@ximian.com>
7207 * expression.cs (New.AddressOf): Implement interface
7208 IMemoryLocation. This is used when the `new' operator is used in
7209 the context of an invocation to a method on a value type.
7211 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
7214 * namespace.cs: Also check the using aliases here.
7216 * driver.cs: Move the test for using validity after the types have
7217 been entered, so we do a single pass that also includes the using
7220 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
7221 in the regular case. CreateSiblingForFinally is doing extra
7224 * attribute.cs (GetAttributeArgumentExpression): Store the result
7225 on an out value, and use the return value to indicate failure
7226 instead of using null (which is a valid return for Constant.GetValue).
7228 * statement.cs: Perform the analysis flow for the increment
7229 portion after the statement, because this will be the real flow of
7230 execution. Fixes #42385
7232 * codegen.cs (EmitContext.EmitArgument,
7233 EmitContext.EmitStoreArgument): New helper functions when the
7234 RemapToProxy flag is set.
7236 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
7239 Add support for remapping parameters.
7241 * iterators.cs: Propagate parameter values; Store parameter
7242 values in the proxy classes.
7244 2003-05-04 Miguel de Icaza <miguel@ximian.com>
7246 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
7247 need a proxy reference; I do not know what I was thinking
7249 * cs-parser.jay (constructor_initializer): catch another error,
7250 and display nice message.
7252 (field_declaration): catch void field declaration
7253 to flag a better error.
7255 * class.cs (MemberBase.CheckBase): Report an error instead of a
7256 warning if a new protected member is declared in a struct.
7257 (Field.Define): catch the error of readonly/volatile.
7259 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
7261 (FieldExpr.AddressOf): ditto. Catch error where the address of a
7262 volatile variable is taken
7264 2003-05-02 Miguel de Icaza <miguel@ximian.com>
7266 * statement.cs (Fixed.Resolve): Report an error if we are not in
7269 2003-05-01 Miguel de Icaza <miguel@ximian.com>
7271 * typemanager.cs: reuse the code that handles type clashes for
7272 delegates and enumerations.
7274 * class.cs (Report28): Always report.
7276 * expression.cs (EncodeAsAttribute): Allow nulls here.
7278 2003-04-28 Miguel de Icaza <miguel@ximian.com>
7280 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
7281 the functionality for testing whether an expression is valid for
7282 an attribute here. Also handle the case of arrays of elements
7285 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
7286 encoding a linear array into an array of objects that are suitable
7287 to be passed to an CustomAttributeBuilder.
7289 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
7291 * ecore.cs: (FieldExpr): Handle field remapping here.
7293 * iteratators.cs: Pass the instance variable (if the method is an
7294 instance method) to the constructors, so we can access the field
7295 variables on the class.
7297 TODO: Test this with structs. I think the THIS variable on
7298 structs might have to be a pointer, and not a refenrece
7300 2003-04-27 Miguel de Icaza <miguel@ximian.com>
7302 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
7303 local variables to fields in a proxy class.
7305 * iterators.cs (PopulateProxy): Rename our internal fields to
7307 Create a <THIS> field if we are an instance method, so we can
7308 reference our parent container variables.
7309 (MapVariable): Called back from the EmitContext code to enter a
7310 new variable to field mapping into the proxy class (we just create
7314 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
7315 for using the remapped locals to fields.
7317 I placed the code here, because that gives the same semantics to
7318 local variables, and only changes the Emit code.
7320 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
7321 statements inside iterators.
7322 (VariableInfo): Add a FieldBuilder for the cases when we are
7323 remapping local variables to fields in a proxy class
7325 * ecore.cs (SimpleNameResolve): Avoid testing two times for
7326 current_block != null.
7328 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
7329 not cope with strings, as it has been moved to the
7330 TableSwitchEmit. Fixed bug in switch generation.
7332 * expression.cs (New.DoResolve): Provide more context for the user
7333 when reporting an error.
7335 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
7338 * expression.cs (MemberAccess.DoResolve): When we get a type back,
7339 check the permissions for it. Note than in a type-resolution
7340 context the check was already present in DeclSpace.ResolveType,
7341 but was missing from the MemberAccess.
7343 (ArrayCreation.CheckIndices): warn if the user has
7344 more nested levels of expressions, but there are no more
7345 dimensions specified. Avoids crash on bug 41906.
7347 2003-04-26 Miguel de Icaza <miguel@ximian.com>
7349 * statement.cs (Block): replace Implicit bool, for a generic
7351 New flag: `Unchecked'. This is used during the EmitMeta phase
7352 (which is out-of-line with the regular Resolve/Emit process for a
7353 statement, as this is done ahead of time, but still gets a chance
7354 to call constant resolve).
7356 (Block.Flags): new enum for adding a new flag.
7358 (Block.EmitMeta): track the state of unchecked.
7360 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
7361 to enable constant resolution to work there as well.
7363 2003-04-22 Miguel de Icaza <miguel@ximian.com>
7365 * typemanager.cs (ienumerable_type): Also look up
7366 System.Collections.IEnumerable.
7368 2003-04-21 Miguel de Icaza <miguel@ximian.com>
7370 TODO: Test more than one conditional per method.
7372 * class.cs (Indexer.Define): Report the location where the user is
7373 referencing the unsupported feature.
7375 (MethodData): Overload the use of `conditionals' to
7376 minimize the creation of needless ArrayLists. This saves roughly
7377 212kb on my machine.
7379 (Method): Implement the new IIteratorContainer interface.
7380 (Method.SetYields): Implement the method by setting the ModFlags
7381 to contain METHOD_YIELDS.
7383 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
7384 which just got set to null.
7386 * iterators.cs: New file.
7388 (Yield, YieldBreak): New statements.
7390 * statement.cs (Return.Resolve): Flag an error if we are used in
7393 * codegen.cs (InIterator): New flag set if the code is being
7394 compiled in an iterator method.
7396 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
7397 internal modifier, and we just use it to avoid adding extra
7398 fields, as this is seldom used.
7400 * cs-parser.jay: Add yield_statement (yield and yield break).
7402 * driver.cs: New flag -v2 to turn on version 2 features.
7404 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
7405 hashtable when v2 is enabled.
7407 2003-04-20 Miguel de Icaza <miguel@ximian.com>
7409 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
7410 there is already a namespace defined with this name.
7412 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
7413 people upgraded their corlibs.
7415 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
7416 always use fully qualified types, no need to use the compiler
7419 (TypeManager.IsNamespace): Use binarysearch.
7421 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
7422 AddDelegate): I did not quite use the new IsValid API properly: I
7423 have to pass the short-name and the fullname. I was passing only
7424 the basename instead of the fullname sometimes.
7426 (TypeContainer.DefineType): call NamespaceClash.
7428 * interface.cs (Interface.DefineType): use NamespaceClash before
7431 * delegate.cs (Delegate.DefineType): use NamespaceClash before
7434 * enum.cs: (Enum.DefineType): use NamespaceClash before
7437 * typemanager.cs (: 3-line patch that gives us some tasty 11%
7438 speed increase. First, use the negative_hits cache when we get a
7439 negative. Second, add the type with its full original name
7440 instead of the new . and + encoded name (reflection uses + to
7441 separate type from a nested type). Use LookupTypeReflection
7442 directly which bypasses the type->name hashtable (that we already
7443 know does not contain the type.
7445 * decl.cs (DeclSpace.ResolveTypeExpr): track the
7446 location/container type.
7448 * driver.cs: When passing utf8, use directly the UTF8Encoding.
7450 2003-04-19 Miguel de Icaza <miguel@ximian.com>
7452 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
7454 * delegate.cs (NewDelegate.Resolve): Test whether an instance
7455 method is being referenced in the method group from a static
7456 context, and report error 120 if so.
7458 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
7461 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
7462 is created, we create the A namespace).
7464 * cs-parser.jay: A namespace also introduces a DeclarationFound.
7467 2003-04-18 Miguel de Icaza <miguel@ximian.com>
7469 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
7470 invocation to ModuleBuilder.GetType with the same values will
7471 return a new type instance, so we need to cache its return
7474 * expression.cs (Binary.ResolveOperator): Only allow the compare
7475 operators on enums if they are of the same type.
7477 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
7478 types of ValueType on their own case. Before we were giving them
7479 the same treatment as objects.
7481 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
7482 fullname. Short name is used to compare against container name.
7483 Fullname is used to check against defined namespace names.
7485 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
7486 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
7488 (Method.CheckBase): Call parent.
7489 (MemberBase.CheckBase): Check for protected members on sealed
7491 (PropertyBase.CheckBase): Call parent.
7492 (Field.Define): Call parent.
7494 * report.cs: Negative error codes are now mapped to 8000 - code,
7495 so that the display is render more nicely.
7497 * typemanager.cs: Do not use try/catch, instead report a regular
7500 (GetPointerType, GetReferenceType): These methods provide
7501 mechanisms to obtain the T* and T& from a T. We had the code
7502 previously scattered around the code base, and it also used
7503 TypeManager.LookupType that would go through plenty of caches.
7504 This one goes directly to the type source.
7506 In some places we did the Type.GetType followed by
7507 ModuleBuilder.GetType, but not in others, so this unifies the
7510 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
7511 statements now that we have namespace information.
7513 * typemanager.cs (IsNamespace): New method, returns whether the
7514 string presented is a namespace or not.
7516 (ComputeNamespaces): New public entry point, computes the list of
7517 available namespaces, using the GetNamespaces API call in Mono, or
7518 the slower version in MS.NET.
7520 Now before we start the semantic analysis phase, we have a
7521 complete list of namespaces including everything that the user has
7524 Deleted old code to cache namespaces in .nsc files.
7526 2003-04-17 Miguel de Icaza <miguel@ximian.com>
7528 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
7529 class/struct location definition Location for the implicit
7530 constructor location.
7532 (Operator.Define): Use the location of the operator for the
7533 implicit Method definition.
7535 (Constructor.Emit): use the constructor location for the implicit
7536 base initializer constructor.
7538 * ecore.cs: Remove ITypeExpression. This interface is now gone,
7539 and the Expression class now contains two new methods:
7541 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
7542 isolate type lookup from the rest of the resolution process.
7544 Since we use Expressions to hold type definitions due to the way
7545 we parse the input we have historically overloaded Resolve to
7546 perform the Type lookups if a special flag is passed. Now this is
7547 eliminated and two methods take their place.
7549 The differences in the two methods between xStep and xTerminal is
7550 that xStep is involved in our current lookup system that uses
7551 SimpleNames to compose a name, while xTerminal is used just to
7552 catch the case where the simplename lookup failed.
7554 2003-04-16 Miguel de Icaza <miguel@ximian.com>
7556 * expression.cs (ResolveMemberAccess): Remove redundant code.
7557 TypeExpr expressions are always born fully resolved.
7559 * interface.cs (PopulateMethod): Do not lookup the types twice.
7560 We were doing it once during SemanticAnalysis and once during
7563 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
7564 in local variable type definitions, were being returned as a
7565 SimpleName (we decomposed everything into a string), that is
7566 because primary_expression was being used instead of a type in the
7567 grammar (reduce/reduce conflicts).
7569 The part that was wrong is that we converted the expression into a
7570 string (an oversimplification in one hand, compounded with primary
7571 expressions doing string concatenation).
7577 Would return "A.B.C[]" as a SimpleName. This stopped things like
7578 using clauses from working on this particular context. And a type
7579 was being matched directly against "A.B.C[]".
7581 We now use the correct approach, and allow for ComposedCast to be
7582 part of the unary expression. So the "A.B.C []" become a composed
7583 cast of "A.B.C" (as a nested group of MemberAccess with a
7584 SimpleName at the end) plus the rank composition "[]".
7588 2003-04-10 Miguel de Icaza <miguel@ximian.com>
7590 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
7591 for the access level checking.
7593 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
7594 `TypeContainer container', because I kept getting confused when I
7595 was debugging this code.
7597 * expression.cs (Indexers): Instead of tracking getters/setters,
7598 we now track them in parallel. We create one arraylist less, but
7599 most importantly it is possible now for the LValue code to find a
7600 matching get for a set.
7602 (IndexerAccess.DoResolveLValue): Update the code.
7603 GetIndexersForType has been modified already to extract all the
7604 indexers from a type. The code assumed it did not.
7606 Also make the code set the correct return type for the indexer.
7607 This was fixed a long time ago for properties, but was missing for
7608 indexers. It used to be void_type.
7610 (Binary.Emit): Test first for doubles instead of
7611 floats, as they are more common.
7613 (Binary.EmitBranchable): Use the .un version of the branch opcodes
7614 when dealing with floats and the <=, >= operators. This fixes bug
7617 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
7618 to load the array value by emitting a load on the foreach variable
7619 type. This was incorrect.
7621 We now emit the code to load an element using the the array
7622 variable type, and then we emit the conversion operator.
7626 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
7628 * attribute.cs: Avoid allocation of ArrayLists in the common case.
7630 2003-04-09 Miguel de Icaza <miguel@ximian.com>
7632 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
7633 test for protection before we test for signatures.
7635 (MethodSignature.ToString): implement.
7637 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
7638 to the case where we reduced into a LongConstant.
7640 * decl.cs (CheckAccessLevel): If the type is an array, we can not
7641 depend on whether the information is acurrate, because the
7642 Microsoft runtime will always claim that the array type is public,
7643 regardless of the real state.
7645 If the type is a pointer, another problem happens: the type is
7646 reported as non-public in Microsoft.
7648 In both cases we have to call CheckAccessLevel recursively with
7649 the underlying type as the argument to be tested.
7651 2003-04-08 Miguel de Icaza <miguel@ximian.com>
7653 * assign.cs (Assign.Emit): If we are dealing with a compound
7654 assignment expression, we should use the code path that stores the
7655 intermediate result in a temporary value. This fixes #40903.
7657 *expression.cs (Indirection.ToString): Provide ToString method for
7660 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
7662 * class.cs: Null out fields holding references to Block objects so
7663 they can be garbage collected.
7665 * expression.cs (OverloadResolve): Remove unused local.
7667 2003-04-07 Martin Baulig <martin@ximian.com>
7669 * codegen.cs (EmitContext.CurrentFile): New public field.
7670 (EmitContext.Mark): Use the CurrentFile to check whether the
7671 location is in the correct file.
7672 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
7674 2003-04-07 Martin Baulig <martin@ximian.com>
7676 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
7678 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
7679 location. [FIXME: The location argument which gets passed to this
7680 method is sometimes wrong!]
7682 2003-04-07 Nick Drochak <ndrochak@gol.com>
7684 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
7686 2003-04-07 Miguel de Icaza <miguel@ximian.com>
7688 * expression.cs (Indirection.EmitAssign): We were using the
7689 temporary, but returning immediately instead of continuing the
7692 2003-04-06 Martin Baulig <martin@ximian.com>
7694 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
7695 if it's a nested child, but also deriving from the outer class.
7698 * typemanager.cs (IsNestedChildOf): Make this work if it's a
7699 nested child, but also deriving from the outer class. See
7701 (FilterWithClosure): We may access private members of the outer
7702 class if we're a nested child and deriving from the outer class.
7703 (RealMemberLookup): Only set `closure_private_ok' if the
7704 `original_bf' contained BindingFlags.NonPublic.
7706 2003-04-05 Martin Baulig <martin@ximian.com>
7708 * expression.cs (SizeOf.DoResolve): Use ResolveTypeExpr, so we can
7709 probe if its a type parameter, and if so, flag an error.
7711 * decl.cs: Move here the SetParameterInfo code from class.cs.
7712 Handle IsGeneric here.
7714 Handle a variety of errors in the parameter info definition.
7716 * ecore.cs (SimpleName.DoResolveType): Handle look ups for generic
7717 type parameters here.
7719 * cs-parser.jay (class_declaration): report errors for parameters
7722 2003-01-21 Miguel de Icaza <miguel@ximian.com>
7724 * generic.cs: New file, contains support code for generics.
7726 * cs-parser.jay: Remove OP_SHIFT_LEFT, OP_SHIFT_RIGHT,
7727 OP_SHIFT_LEFT_ASSIGN, OP_SHIFT_RIGHT_ASSIGN.
7729 Update parser for the above removals.
7731 * cs-tokenizer.cs: Do not handle <<= or >>= specially. This is
7732 now taken care of in the parser.
7734 2003-04-02 Miguel de Icaza <miguel@ximian.com>
7736 * class.cs (Event.Define): Do not allow abstract events to have
7739 2003-04-01 Miguel de Icaza <miguel@ximian.com>
7741 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
7742 block in event declarations.
7744 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
7745 value type, get its address.
7747 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
7748 leaving a class on the stack instead of a boolean value (int
7749 0/1). Change the code so we compare against null, and then the
7750 result against zero.
7752 * class.cs (TypeContainer.GetClassBases): We were checking for the
7753 parent class being sealed too late.
7755 * expression.cs (Binary.Emit): For <= and >= when dealing with
7756 floating point values, use cgt.un and clt.un instead of cgt and
7759 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
7761 * statement.cs: Apply the same optimization as MS: skip the
7762 GetEnumerator returning an IEnumerator, and use the one returning a
7763 CharEnumerator instead. This allows us to avoid the try-finally block
7766 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
7768 * cs-parser.jay: Attributes cannot be applied to
7769 namespaces. Fixes #40473
7771 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7774 (Add*): check if the name is valid using the full name for constants,
7775 fields, properties and events.
7777 2003-03-28 Miguel de Icaza <miguel@ximian.com>
7779 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
7780 char constants to be part of the enumeration.
7782 * expression.cs (Conditional.DoResolve): Add support for operator
7783 true. Implements the missing functionality from 14.12
7785 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
7786 operator true/false as required by the spec.
7788 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
7789 implicit conversion to boolean.
7791 * statement.cs (Statement.ResolveBoolean): A boolean expression is
7792 also one where the type implements `operator true'.
7794 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
7795 get an expression that will invoke operator true based on an
7798 (GetConversionOperators): Removed the hack that called op_True
7801 (Expression.ResolveBoolean): Move this from Statement.
7803 2003-03-17 Miguel de Icaza <miguel@ximian.com>
7805 * ecore.cs (FieldExpr): do not allow initialization of initonly
7806 fields on derived classes
7808 2003-03-13 Martin Baulig <martin@ximian.com>
7810 * statement.cs (Block.Emit): Call ig.BeginScope() and
7811 ig.EndScope() when compiling with debugging info; call
7812 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
7814 2003-03-08 Miguel de Icaza <miguel@ximian.com>
7816 * expression.cs (Indexers): Do not construct immediately, allow
7817 for new members to be appended as we go. Fixes 38143
7819 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7821 * expression.cs: save/restore context when resolving an unchecked
7824 2003-03-05 Miguel de Icaza <miguel@ximian.com>
7826 * cfold.cs: Catch division by zero in modulus operator during
7829 2003-03-03 Miguel de Icaza <miguel@ximian.com>
7831 * interface.cs (Interface.DefineMembers): Avoid defining members
7834 2003-02-27 Miguel de Icaza <miguel@ximian.com>
7836 * driver.cs: handle the +/- options for -noconfig
7838 * statement.cs (Unckeched.Resolve): Also track the state of
7839 unchecked in the Resolve phase.
7841 2003-02-27 Martin Baulig <martin@ximian.com>
7843 * ecore.cs (Expression.MemberLookup): Don't create a
7844 MethodGroupExpr for something which is not a method. Fixes #38291.
7846 2003-02-25 Miguel de Icaza <miguel@ximian.com>
7848 * class.cs (MemberBase.CheckParameters): Also check that the type
7849 is unmanaged if it is a pointer.
7851 * expression.cs (SizeOf.Resolve): Add location information.
7853 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
7854 a managed type is declared.
7856 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
7857 parameter modifiers as well. Fixes bug 38606
7859 * class.cs: Very sad. Am backing out the speed up changes
7860 introduced by the ArrayList -> Array in the TypeContainer, as they
7861 were not actually that much faster, and introduced a bug (no error
7862 reports on duplicated methods).
7864 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
7865 source first, this will guarantee that we have a valid expression
7866 before calling in lower levels functions that will require a
7867 resolved object. Then use this original_source in the
7868 target.ResolveLValue instead of the original source that was
7871 Another change. Use target.Resolve instead of LValueResolve.
7872 Although we are resolving for LValues, we will let the Assign code
7873 take care of that (it will be called again from Resolve). This
7874 basically allows code like this:
7876 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
7877 class Y { void A (X x) { x [0] += o; }
7879 The problem was that the indexer was trying to resolve for
7880 set_Item (idx, object o) and never finding one. The real set_Item
7881 was set_Item (idx, X). By delaying the process we get the right
7886 2003-02-23 Martin Baulig <martin@ximian.com>
7888 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
7889 while calling DoEmit ().
7891 * codegen.cs (EmitContext.Mark): Don't mark locations in other
7892 source files; if you use the #line directive inside a method, the
7893 compiler stops emitting line numbers for the debugger until it
7894 reaches the end of the method or another #line directive which
7895 restores the original file.
7897 2003-02-23 Martin Baulig <martin@ximian.com>
7899 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
7901 2003-02-23 Martin Baulig <martin@ximian.com>
7903 * statement.cs (Block.AddChildVariableNames): We need to call this
7904 recursively, not just for our immediate children.
7906 2003-02-23 Martin Baulig <martin@ximian.com>
7908 * class.cs (Event.Define): Always make the field private, like csc does.
7910 * typemanager.cs (TypeManager.RealMemberLookup): Make events
7911 actually work, fixes bug #37521.
7913 2003-02-23 Miguel de Icaza <miguel@ximian.com>
7915 * delegate.cs: When creating the various temporary "Parameters"
7916 classes, make sure that we call the ComputeAndDefineParameterTypes
7917 on those new parameters (just like we do with the formal ones), to
7918 allow them to be resolved in the context of the DeclSpace.
7920 This fixes the bug that Dick observed in Bugzilla #38530.
7922 2003-02-22 Miguel de Icaza <miguel@ximian.com>
7924 * expression.cs (ResolveMemberAccess): When resolving a constant,
7925 do not attempt to pull a constant if the value was not able to
7926 generate a valid constant.
7928 * const.cs (LookupConstantValue): Do not report more errors than required.
7930 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7932 * expression.cs: fixes bug #38328.
7934 2003-02-18 Miguel de Icaza <miguel@ximian.com>
7936 * class.cs: Changed all the various members that can be part of a
7937 class from being an ArrayList to be an Array of the right type.
7938 During the DefineType type_list, interface_list, delegate_list and
7939 enum_list are turned into types, interfaces, delegates and enums
7942 And during the member population, indexer_list, event_list,
7943 constant_list, field_list, instance_constructor_list, method_list,
7944 operator_list and property_list are turned into their real arrays.
7946 Although we could probably perform this operation earlier, for
7947 good error reporting we need to keep the lists and remove the
7948 lists for longer than required.
7950 This optimization was triggered by Paolo profiling the compiler
7951 speed on the output of `gen-sample-program.pl' perl script.
7953 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
7954 not crash in methods like MemberLookupFailed that use this field.
7956 This problem arises when the compiler fails to resolve a type
7957 during interface type definition for example.
7959 2003-02-18 Miguel de Icaza <miguel@ximian.com>
7961 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
7962 inherit from System.Object, so we have to stop at null, not only
7963 when reaching System.Object.
7965 2003-02-17 Miguel de Icaza <miguel@ximian.com>
7967 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
7968 DeclaredOnly because the parent indexer might have had a different
7969 name, but did not loop until the top of the hierarchy was reached.
7971 The problem this one fixes is 35492: when a class implemented an
7972 indexer from an interface, we were getting the interface method
7973 (which was abstract) and we were flagging an error (can not invoke
7976 This also keeps bug 33089 functioning, and test-148 functioning.
7978 * typemanager.cs (IsSpecialMethod): The correct way of figuring
7979 out if a method is special is to see if it is declared in a
7980 property or event, or whether it is one of the predefined operator
7981 names. This should fix correctly #36804.
7983 2003-02-15 Miguel de Icaza <miguel@ximian.com>
7985 The goal here is to remove the dependency on EmptyCast.Peel ().
7986 Killing it completely.
7988 The problem is that currently in a number of places where
7989 constants are expected, we have to "probe" for an EmptyCast, and
7990 Peel, which is not the correct thing to do, as this will be
7991 repetitive and will likely lead to errors.
7993 The idea is to remove any EmptyCasts that are used in casts that
7994 can be reduced to constants, so we only have to cope with
7997 This bug hunt was triggered by Bug 37363 and the desire to remove
7998 the duplicate pattern where we were "peeling" emptycasts to check
7999 whether they were constants. Now constants will always be
8002 * ecore.cs: Use an enumconstant here instead of wrapping with
8005 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
8006 throwing me off. By handling this we can get rid of a few hacks.
8008 * statement.cs (Switch): Removed Peel() code.
8010 2003-02-14 Miguel de Icaza <miguel@ximian.com>
8012 * class.cs: Location information for error 508
8014 * expression.cs (New.DoResolve): Add a guard against double
8015 resolution of an expression.
8017 The New DoResolve might be called twice when initializing field
8018 expressions (see EmitFieldInitializers, the call to
8019 GetInitializerExpression will perform a resolve on the expression,
8020 and later the assign will trigger another resolution
8022 This leads to bugs (#37014)
8024 * delegate.cs: The signature for EndInvoke should contain any ref
8025 or out parameters as well. We were not doing this in the past.
8027 * class.cs (Field.Define): Do not overwrite the type definition
8028 inside the `volatile' group. Turns out that volatile enumerations
8029 were changing the type here to perform a validity test, which
8032 2003-02-12 Miguel de Icaza <miguel@ximian.com>
8034 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
8035 and structs, we do not want to load the instance variable
8037 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
8038 enum_type has to be handled like an object reference (implicit
8039 conversions exists from this to object), but the regular IsClass
8040 and IsValueType tests will never return true for this one.
8042 Also we use TypeManager.IsValueType instead of type.IsValueType,
8043 just for consistency with the rest of the code (this is only
8044 needed if we ever use the construct exposed by test-180.cs inside
8045 corlib, which we dont today).
8047 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
8049 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
8052 2003-02-09 Martin Baulig <martin@ximian.com>
8054 * namespace.cs (Namespace..ctor): Added SourceFile argument.
8055 (Namespace.DefineNamespaces): New static public method; this is
8056 called when we're compiling with debugging to add all namespaces
8059 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
8060 pass it to the Namespace's .ctor.
8062 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
8063 and MethodBase arguments; pass the namespace ID to the symwriter;
8064 pass the MethodBase instead of the token to the symwriter.
8065 (SymbolWriter.DefineNamespace): New method to add a namespace to
8068 2003-02-09 Martin Baulig <martin@ximian.com>
8070 * symbolwriter.cs: New file. This is a wrapper around
8071 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
8072 methods here in near future.
8074 2003-02-09 Martin Baulig <martin@ximian.com>
8076 * codegen.cs (EmitContext.Mark): Just pass the arguments to
8077 ILGenerator.MarkSequencePoint() which are actually used by the
8080 2003-02-09 Martin Baulig <martin@ximian.com>
8082 * location.cs (SourceFile): New public sealed class. This
8083 contains the name and an index which is used in the location's token.
8084 (Location): Reserve an appropriate number of bits in the token for
8085 the source file instead of walking over that list, this gives us a
8086 really huge performance improvement when compiling with debugging.
8088 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
8089 `SourceFile' argument instead of a string.
8090 (Driver.ProcessFile): Add all the files via Location.AddFile(),
8091 but don't parse/tokenize here, we need to generate the list of all
8092 source files before we do that.
8093 (Driver.ProcessFiles): New static function. Parses/tokenizes all
8096 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
8097 instead of a string.
8099 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
8102 2003-02-09 Martin Baulig <martin@ximian.com>
8104 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
8105 filename on `#line default'.
8107 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
8109 * statement.cs: don't clear the pinned var when the fixed statement
8110 returns from the method (fixes bug#37752).
8112 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
8114 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
8117 2003-02-07 Martin Baulig <martin@ximian.com>
8119 * driver.cs: Removed the `--debug-args' command line argument.
8121 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
8122 automatically by the AsssemblyBuilder.
8123 (CodeGen.InitializeSymbolWriter): We don't need to call any
8124 initialization function on the symbol writer anymore. This method
8125 doesn't take any arguments.
8127 2003-02-03 Miguel de Icaza <miguel@ximian.com>
8129 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
8130 from referenced assemblies as well.
8132 2003-02-02 Martin Baulig <martin@ximian.com>
8134 * class.cs (MethodData.Emit): Generate debugging info for external methods.
8136 2003-02-02 Martin Baulig <martin@ximian.com>
8138 * class.cs (Constructor.Emit): Open the symbol writer before
8139 emitting the constructor initializer.
8140 (ConstructorInitializer.Emit): Call ec.Mark() to allow
8141 single-stepping through constructor initializers.
8143 2003-01-30 Miguel de Icaza <miguel@ximian.com>
8145 * class.cs: Handle error 549: do not allow virtual methods in
8148 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
8150 * decl.cs: Check access levels when resolving types
8152 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
8154 * statement.cs: Add parameters and locals set in catch blocks that might
8155 return to set vector
8157 2003-01-29 Miguel de Icaza <miguel@ximian.com>
8159 * class.cs (Operator): Set the SpecialName flags for operators.
8161 * expression.cs (Invocation.DoResolve): Only block calls to
8162 accessors and operators on SpecialName methods.
8164 (Cast.TryReduce): Handle conversions from char constants.
8167 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
8169 * statement.cs: small memory and time optimization in FlowBranching.
8171 2003-01-28 Pedro Mart <yoros@wanadoo.es>
8173 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
8174 problem that the last fix but in the other sid (Set).
8176 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
8177 access when there is no indexer in the hierarchy.
8179 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
8181 * class.cs: Combine some if statements.
8183 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8185 * driver.cs: fixed bug #37187.
8187 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
8189 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
8190 any indexer, it's needed to build a list with all the indexers in the
8191 hierarchy (AllGetters), else we have problems. Fixes #35653.
8193 2003-01-23 Miguel de Icaza <miguel@ximian.com>
8195 * class.cs (MethodData.Define): It is wrong for an interface
8196 implementation to be static in both cases: explicit and implicit.
8197 We were only handling this in one case.
8199 Improve the if situation there to not have negations.
8201 * class.cs (Field.Define): Turns out that we do not need to check
8202 the unsafe bit on field definition, only on usage. Remove the test.
8204 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8206 * driver.cs: use assembly.Location instead of Codebase (the latest
8207 patch made mcs fail when using MS assemblies).
8209 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
8211 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
8212 get the path to *corlib.dll.
8214 2003-01-21 Nick Drochak <ndrochak@gol.com>
8218 * typemanager.cs: Remove compiler warnings
8220 2003-01-20 Duncan Mak <duncan@ximian.com>
8222 * AssemblyInfo.cs: Bump the version number to 0.19.
8224 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8226 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
8228 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
8230 * class.cs (Constructor::Emit): Emit debugging info for constructors.
8232 2003-01-17 Miguel de Icaza <miguel@ximian.com>
8234 * cs-parser.jay: Small fix: we were not comparing the constructor
8235 name correctly. Thanks to Zoltan for the initial pointer.
8237 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
8239 * cs-tokenizer.cs: Set file name when specified with #line
8241 2003-01-15 Miguel de Icaza <miguel@ximian.com>
8243 * cs-parser.jay: Only perform the constructor checks here if we
8244 are named like the class; This will help provider a better
8245 error. The constructor path is taken when a type definition is
8246 not found, but most likely the user forgot to add the type, so
8247 report that rather than the constructor error.
8249 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
8251 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
8254 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
8256 * cs-parser.jay: Add cleanup call.
8258 2003-01-13 Duncan Mak <duncan@ximian.com>
8260 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
8261 consistent with other methods.
8263 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
8265 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
8267 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
8269 * attribute.cs: only set GuidAttr to true when we have a
8272 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8276 * typemanager.cs: fixes to allow mcs compile corlib with the new
8277 Type.IsSubclassOf fix.
8279 2003-01-08 Miguel de Icaza <miguel@ximian.com>
8281 * expression.cs (LocalVariableReference.DoResolve): Classify a
8282 constant as a value, not as a variable. Also, set the type for
8285 * cs-parser.jay (fixed_statement): take a type instead of a
8286 pointer_type, so we can produce a better error message later.
8288 * statement.cs (Fixed.Resolve): Flag types that are not pointers
8291 (For.DoEmit): Make inifinite loops have a
8292 non-conditional branch back.
8294 (Fixed.DoEmit): First populate the pinned variables, then emit the
8295 statement, then clear the variables. Before I was emitting the
8296 code once for each fixed piece.
8299 2003-01-08 Martin Baulig <martin@ximian.com>
8301 * statement.cs (FlowBranching.MergeChild): A break in a
8302 SWITCH_SECTION does not leave a loop. Fixes #36155.
8304 2003-01-08 Martin Baulig <martin@ximian.com>
8306 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
8307 lives in the same number space than `param_map'. Fixes #36154.
8309 2003-01-07 Miguel de Icaza <miguel@ximian.com>
8311 * cs-parser.jay (constructor_declaration): Set the
8312 Constructor.ModFlags before probing for it. This makes the
8313 compiler report 514, 515 and 132 (the code was there, but got
8316 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
8317 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
8318 (GotoCase.Resolve): Set `Returns' to ALWAYS.
8320 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
8322 * enum.cs: create the enum static fields using the enum type.
8324 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
8326 * class.cs: don't try to create the ParamBuilder for the return
8327 type if it's not needed (and handle it breaking for the ms runtime
8330 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
8332 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
8334 2002-12-29 Miguel de Icaza <miguel@ximian.com>
8336 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
8337 the command. This showed up while compiling the JANET source
8338 code, which used \r as its only newline separator.
8340 2002-12-28 Miguel de Icaza <miguel@ximian.com>
8342 * class.cs (Method.Define): If we are an operator (because it
8343 reuses our code), then set the SpecialName and HideBySig. #36128
8345 2002-12-22 Miguel de Icaza <miguel@ximian.com>
8347 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
8348 exception, report error 120 `object reference required'.
8350 * driver.cs: Add --pause option, used during to measure the size
8351 of the process as it goes with --timestamp.
8353 * expression.cs (Invocation.DoResolve): Do not allow methods with
8354 SpecialName to be invoked.
8356 2002-12-21 Miguel de Icaza <miguel@ximian.com>
8358 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
8359 number before adding it.
8361 2002-12-21 Ravi Pratap <ravi@ximian.com>
8363 * ecore.cs (StandardImplicitConversion): When in an unsafe
8364 context, we allow conversion between void * to any other pointer
8365 type. This fixes bug #35973.
8367 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
8369 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
8370 is not thrown when extensionless outputs are used
8372 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8374 * rootcontext.cs: fixed compilation of corlib.
8376 2002-12-19 Miguel de Icaza <miguel@ximian.com>
8378 * attribute.cs (Attributes.Contains): Add new method.
8380 * class.cs (MethodCore.LabelParameters): if the parameter is an
8381 `out' parameter, check that no attribute `[In]' has been passed.
8383 * enum.cs: Handle the `value__' name in an enumeration.
8385 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
8387 * decl.cs: Added special case to allow overrides on "protected
8390 2002-12-18 Ravi Pratap <ravi@ximian.com>
8392 * attribute.cs (Attributes.AddAttributeSection): Rename to this
8393 since it makes much more sense.
8395 (Attributes.ctor): Don't require a Location parameter.
8397 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
8399 * attribute.cs (ApplyAttributes): Remove extra Location parameters
8400 since we already have that information per attribute.
8402 * everywhere : make appropriate changes.
8404 * class.cs (LabelParameters): Write the code which actually
8405 applies attributes to the return type. We can't do this on the MS
8406 .NET runtime so we flag a warning in the case an exception is
8409 2002-12-18 Miguel de Icaza <miguel@ximian.com>
8411 * const.cs: Handle implicit null conversions here too.
8413 2002-12-17 Ravi Pratap <ravi@ximian.com>
8415 * class.cs (MethodCore.LabelParameters): Remove the extra
8416 Type [] parameter since it is completely unnecessary. Instead
8417 pass in the method's attributes so that we can extract
8418 the "return" attribute.
8420 2002-12-17 Miguel de Icaza <miguel@ximian.com>
8422 * cs-parser.jay (parse): Use Report.Error to flag errors instead
8423 of ignoring it and letting the compile continue.
8425 * typemanager.cs (ChangeType): use an extra argument to return an
8426 error condition instead of throwing an exception.
8428 2002-12-15 Miguel de Icaza <miguel@ximian.com>
8430 * expression.cs (Unary.TryReduce): mimic the code for the regular
8431 code path. Perform an implicit cast in the cases where we can
8432 implicitly convert to one of the integral types, and then reduce
8433 based on that constant. This fixes bug #35483.
8435 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8437 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
8439 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8441 * namespace.cs: fixed bug #35489.
8443 2002-12-12 Miguel de Icaza <miguel@ximian.com>
8445 * class.cs: Remove some dead code.
8447 * cs-parser.jay: Estimate the number of methods needed
8448 (RootContext.MethodCount);
8450 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
8451 numbers instead of StringBuilders.
8453 * support.cs (PtrHashtable): Add constructor with initial size;
8454 We can now reduce reallocations of the method table.
8456 2002-12-10 Ravi Pratap <ravi@ximian.com>
8458 * attribute.cs (ApplyAttributes): Keep track of the emitted
8459 attributes on a per-target basis. This fixes bug #35413.
8461 2002-12-10 Miguel de Icaza <miguel@ximian.com>
8463 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
8464 default to the Windows 1252 encoding.
8466 (UnixParseOption): Support version, thanks to Alp for the missing
8469 * AssemblyInfo.cs: Add nice assembly information.
8471 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
8474 * cs-parser.jay: Allow a trailing comma before the close bracked
8475 in the attribute_section production.
8477 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
8478 address of the instance was being taken, I will take this out,
8479 because we take the address of the object immediately here.
8481 2002-12-09 Ravi Pratap <ravi@ximian.com>
8483 * typemanager.cs (AreMultipleAllowed): Take care of the most
8484 obvious case where attribute type is not in the current assembly -
8487 2002-12-08 Miguel de Icaza <miguel@ximian.com>
8489 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
8490 definitions, instead of doing that afterwards.
8492 Also we use a nice little hack, depending on the constructor, we
8493 know if we are a "composed" name or a simple name. Hence, we
8494 avoid the IndexOf test, and we avoid
8496 * codegen.cs: Add code to assist in a bug reporter to track down
8497 the source of a compiler crash.
8499 2002-12-07 Ravi Pratap <ravi@ximian.com>
8501 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
8502 types have been emitted for a given element and flag an error
8503 if something which does not have AllowMultiple set is used more
8506 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
8507 attribute types and their corresponding AllowMultiple properties
8509 (AreMultipleAllowed): Check the property for a given type.
8511 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
8512 property in the case we have a TypeContainer.
8514 (Attributes.AddAttribute): Detect duplicates and just skip on
8515 adding them. This trivial fix catches a pretty gross error in our
8516 attribute emission - global attributes were being emitted twice!
8518 Bugzilla bug #33187 is now fixed.
8520 2002-12-06 Miguel de Icaza <miguel@ximian.com>
8522 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
8525 * expression.cs (Binary.ResolveOperator): I can only use the
8526 Concat (string, string, string) and Concat (string, string,
8527 string, string) if the child is actually a concatenation of
8530 2002-12-04 Miguel de Icaza <miguel@ximian.com>
8532 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
8533 context where we need a 2-character lookahead.
8535 * pending.cs (PendingImplementation): Rework so we can keep track
8536 of interface types all the time, and flag those which were
8537 implemented by parents as optional.
8539 2002-12-03 Miguel de Icaza <miguel@ximian.com>
8541 * expression.cs (Binary.ResolveOperator): Use
8542 String.Concat(string,string,string) or
8543 String.Concat(string,string,string,string) when possible.
8545 * typemanager: More helper methods.
8548 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
8550 * pending.cs: remove the bogus return from GetMissingInterfaces()
8551 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
8553 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8555 * namespace.cs: avoid duplicated 'using xxx' being added to
8556 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
8557 when we get more than one 'using' statement for the same namespace.
8558 Report a CS0105 warning for it.
8560 2002-11-30 Miguel de Icaza <miguel@ximian.com>
8562 * cs-tokenizer.cs (consume_identifier): use read directly, instead
8563 of calling getChar/putback, uses internal knowledge of it.
8565 (xtoken): Reorder tokenizer so most common patterns are checked
8566 first. This reduces the compilation time in another 5% (from 8.11s
8567 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
8569 The parsing time is 22% of the compilation in mcs, and from that
8570 64% is spent on the tokenization process.
8572 I tried using a binary search for keywords, but this is slower
8573 than the hashtable. Another option would be to do a couple of
8576 * Not use a StringBuilder, instead use an array of chars,
8577 with a set value. Notice that this way we could catch
8578 the 645 error without having to do it *afterwards*.
8580 * We could write a hand-parser to avoid the hashtable
8581 compares altogether.
8583 The identifier consumption process takes 37% of the tokenization
8584 time. Another 15% is spent on is_number. 56% of the time spent
8585 on is_number is spent on Int64.Parse:
8587 * We could probably choose based on the string length to
8588 use Int32.Parse or Int64.Parse and avoid all the 64-bit
8591 Another 3% is spend on wrapping `xtoken' in the `token' function.
8593 Handle 0xa0 as whitespace (#34752)
8595 2002-11-26 Miguel de Icaza <miguel@ximian.com>
8597 * typemanager.cs (IsCLRType): New routine to tell whether a type
8598 is one of the builtin types.
8600 Maybe it needs to use TypeCodes to be faster. Maybe we could use
8601 typecode in more places instead of doing pointer comparissions.
8602 We could leverage some knowledge about the way the typecodes are
8605 New code to cache namespaces in assemblies, it is currently not
8606 invoked, to be used soon.
8608 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
8610 * expression.cs (Binary.ResolveOperator): specially handle
8611 strings, and do not perform user-defined operator overloading for
8614 2002-11-24 Miguel de Icaza <miguel@ximian.com>
8616 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
8617 internalcall as it is a pretty simple operation; Avoid whenever
8618 possible to call Char.IsLetter.
8620 (consume_identifier): Cut by half the number of
8621 hashtable calls by merging the is_keyword and GetKeyword behavior.
8623 Do not short-circuit, because if we do, we
8624 report errors (ie, #if false && true would produce an invalid
8628 2002-11-24 Martin Baulig <martin@ximian.com>
8630 * expression.cs (Cast.TryReduce): If we're in checked syntax,
8631 check constant ranges and report a CS0221. Fixes #33186.
8633 2002-11-24 Martin Baulig <martin@ximian.com>
8635 * cs-parser.jay: Make this work for uninitialized variable
8636 declarations in the `for' initializer. Fixes #32416.
8638 2002-11-24 Martin Baulig <martin@ximian.com>
8640 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
8641 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
8643 2002-11-24 Martin Baulig <martin@ximian.com>
8645 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
8646 argument; if true, we also check for user-defined conversions.
8647 This is only needed if both arguments are of a user-defined type.
8648 Fixes #30443, added test-175.cs.
8649 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
8651 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
8653 2002-11-24 Martin Baulig <martin@ximian.com>
8655 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
8656 function to get the store opcode.
8657 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
8658 only emit the Ldelema if the store opcode is Stobj. You must run
8659 both test-34 and test-167 to test this. Fixes #34529.
8661 2002-11-23 Martin Baulig <martin@ximian.com>
8663 * ecore.cs (Expression.MemberLookup): Added additional
8664 `qualifier_type' argument which is used when we're being called
8665 from MemberAccess.DoResolve() and null if we're called from a
8667 (Expression.MemberLookupFailed): New method to report errors; this
8668 does the CS1540 check and reports the correct error message.
8670 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
8671 argument for the CS1540 check and redone the way how we're dealing
8672 with private members. See the comment in the source code for details.
8673 (FilterWithClosure): Reverted this back to revision 1.197; renamed
8674 `closure_start_type' to `closure_qualifier_type' and check whether
8675 it's not null. It was not this filter being broken, it was just
8676 being called with the wrong arguments.
8678 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
8679 and pass it the correct `qualifier_type'; this also does the error
8682 2002-11-22 Miguel de Icaza <miguel@ximian.com>
8684 * expression.cs (Invocation.EmitParams): If the we are dealing
8685 with a non-built-in value type, load its address as well.
8687 (ArrayCreation): Use a a pretty constant instead
8688 of the hardcoded value 2. Use 6 instead of 2 for the number of
8689 static initializers.
8691 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
8692 because they are not really value types, just glorified integers.
8694 * driver.cs: Do not append .exe, the CSC compiler does not do it.
8696 * ecore.cs: Remove redundant code for enumerations, make them use
8697 the same code path as everything else, fixes the casting issue
8698 with enumerations in Windows.Forms.
8700 * attribute.cs: Do only cast to string if it is a string, the
8701 validation happens later.
8703 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
8704 people upgrade their corlibs.
8706 * ecore.cs: Oops, enumerations were not following the entire code path
8708 2002-11-21 Miguel de Icaza <miguel@ximian.com>
8710 * typemanager.cs (FilterWithClosure): Commented out the test for
8711 1540 in typemanager.cs, as it has problems when accessing
8712 protected methods from a parent class (see test-174.cs).
8714 * attribute.cs (Attribute.ValidateGuid): new method.
8715 (Attribute.Resolve): Use above.
8717 2002-11-19 Miguel de Icaza <miguel@ximian.com>
8719 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
8721 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
8722 handling for enumerations, as we only needed the TypeContainer
8723 functionality to begin with (this is required for the fix below to
8724 work for enums that reference constants in a container class for
8727 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
8729 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
8730 a valid TypeBuilder to perform lookups on.o
8732 * class.cs (InheritableMemberSignatureCompare): Use true in the
8733 call to GetGetMethod and GetSetMethod, because we are comparing
8734 the signature, and we need to get the methods *even* if they are
8737 (PropertyBase.CheckBase): ditto.
8739 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
8740 GotoCase.Resolve): Use Peel on EmpytCasts.
8742 * ecore.cs (EmptyCast): drop child, add Peel method.
8744 2002-11-17 Martin Baulig <martin@ximian.com>
8746 * ecore.cs (EmptyCast.Child): New public property.
8748 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
8749 label resolved to an EmptyCast. Fixes #34162.
8750 (GotoCase.Resolve): Likewise.
8751 (Block.EmitMeta): Likewise.
8753 2002-11-17 Martin Baulig <martin@ximian.com>
8755 * expression.cs (Invocation.BetterConversion): Prefer int over
8756 uint; short over ushort; long over ulong for integer literals.
8757 Use ImplicitConversionExists instead of StandardConversionExists
8758 since we also need to check for user-defined implicit conversions.
8759 Fixes #34165. Added test-173.cs.
8761 2002-11-16 Martin Baulig <martin@ximian.com>
8763 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
8764 with the `true' and `false' literals. Fixes #33151.
8766 2002-11-16 Martin Baulig <martin@ximian.com>
8768 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
8769 October 22nd; don't do the cs1540 check for static members.
8771 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
8772 now using our own filter here and doing the cs1540 check again.
8774 2002-11-16 Martin Baulig <martin@ximian.com>
8776 * support.cs (InternalParameters): Don't crash if we don't have
8777 any fixed parameters. Fixes #33532.
8779 2002-11-16 Martin Baulig <martin@ximian.com>
8781 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
8782 when looking up static methods to make this work on Windows.
8785 2002-11-16 Martin Baulig <martin@ximian.com>
8787 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
8788 a setter rather than using PropertyInfo.CanWrite.
8790 2002-11-15 Nick Drochak <ndrochak@gol.com>
8792 * class.cs: Allow acces to block member by subclasses. Fixes build
8795 2002-11-14 Martin Baulig <martin@ximian.com>
8797 * class.cs (Constructor.Emit): Added the extern/block check.
8800 2002-11-14 Martin Baulig <martin@ximian.com>
8802 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
8803 iteration while looking for indexers, this is needed because the
8804 indexer may have a different name in our base classes. Fixed the
8805 error reporting (no indexers at all, not get accessor, no
8806 overloaded match). Fixes bug #33089.
8807 (IndexerAccess.DoResolveLValue): Likewise.
8809 2002-11-14 Martin Baulig <martin@ximian.com>
8811 * class.cs (PropertyBase.CheckBase): Make this work for multiple
8812 indexers. Fixes the first part of bug #33089.
8813 (MethodSignature.InheritableMemberSignatureCompare): Added support
8816 2002-11-13 Ravi Pratap <ravi@ximian.com>
8818 * attribute.cs (Attribute.Resolve): Catch the
8819 NullReferenceException and report it since it isn't supposed to
8822 2002-11-12 Miguel de Icaza <miguel@ximian.com>
8824 * expression.cs (Binary.EmitBranchable): Also handle the cases for
8825 LogicalOr and LogicalAnd that can benefit from recursively
8826 handling EmitBranchable. The code now should be nice for Paolo.
8828 2002-11-08 Miguel de Icaza <miguel@ximian.com>
8830 * typemanager.cs (LookupType): Added a negative-hit hashtable for
8831 the Type lookups, as we perform quite a number of lookups on
8832 non-Types. This can be removed once we can deterministically tell
8833 whether we have a type or a namespace in advance.
8835 But this might require special hacks from our corlib.
8839 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
8840 and double which avoids a conversion from an integer to a double.
8842 * expression.cs: tiny optimization, avoid calling IsConstant,
8843 because it effectively performs the lookup twice.
8845 2002-11-06 Miguel de Icaza <miguel@ximian.com>
8847 But a bogus return here to keep the semantics of the old code
8848 until the Mono runtime is fixed.
8850 * pending.cs (GetMissingInterfaces): New method used to remove all
8851 the interfaces that are already implemented by our parent
8852 classes from the list of pending methods.
8854 * interface.cs: Add checks for calls after ResolveTypeExpr.
8856 2002-11-05 Miguel de Icaza <miguel@ximian.com>
8858 * class.cs (Class.Emit): Report warning 67: event not used if the
8859 warning level is beyond 3.
8861 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
8862 being a NullLiteral.
8864 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
8867 * class.cs (TypeContainer.GetClassBases): Cover a missing code
8868 path that might fail if a type can not be resolved.
8870 * expression.cs (Binary.Emit): Emit unsigned versions of the
8873 * driver.cs: use error 5.
8875 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
8877 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
8879 2002-11-01 Miguel de Icaza <miguel@ximian.com>
8881 * cs-parser.jay (switch_section): A beautiful patch from Martin
8882 Baulig that fixed 33094.
8884 2002-10-31 Miguel de Icaza <miguel@ximian.com>
8886 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
8887 Check whether the base is abstract and report an error if so.
8889 * expression.cs (IndexerAccess.DoResolveLValue,
8890 IndexerAccess.DoResolve): ditto.
8892 (Invocation.DoResolve): ditto.
8894 (Invocation.FullMethodDesc): Improve the report string.
8896 * statement.cs (Block): Eliminate IsVariableDefined as it is
8897 basically just a wrapper for GetVariableInfo.
8899 * ecore.cs (SimpleName): Use new
8901 * support.cs (ReflectionParamter.ParameterType): We unwrap the
8902 type, as we return the actual parameter ref/unref state on a
8905 2002-10-30 Miguel de Icaza <miguel@ximian.com>
8907 * support.cs: Return proper flags REF/OUT fixing the previous
8910 * expression.cs: Reverted last patch, that was wrong. Is_ref is
8911 not used to mean `ref' but `ref or out' in ParameterReference
8913 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
8914 full type signature instead of calling TypeManger.CSharpName
8917 * support.cs (InternalParameters.ParameterDesc): Do not compare
8918 directly to the modflags, because REF/OUT will actually be bitsets
8921 * delegate.cs (VerifyMethod): Check also the modifiers.
8923 * cs-tokenizer.cs: Fix bug where floating point values with an
8924 exponent where a sign was missing was ignored.
8926 * driver.cs: Allow multiple assemblies to be specified in a single
8929 2002-10-28 Miguel de Icaza <miguel@ximian.com>
8931 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
8932 because identifiers after a parenthesis would end up in this kind
8933 of production, and we needed to desamiguate it for having casts
8936 (UserDefinedType *) xxx
8938 2002-10-24 Miguel de Icaza <miguel@ximian.com>
8940 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
8941 we should set on the Bindingflags.NonPublic, but not turn on
8942 private_ok. private_ok controls whether a Private member is
8943 returned (this is chekced on the filter routine), while the
8944 BindingFlags.NonPublic just controls whether private/protected
8945 will be allowed. This fixes the problem part of the problem of
8946 private properties being allowed to be used in derived classes.
8948 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
8949 so we can call the children DoResolveLValue method (this will
8950 properly signal errors on lvalue assignments to base properties)
8952 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
8953 getter are null, and we have a property info, we know that this
8954 happened because the lookup failed, so we report an error 122 for
8955 protection level violation.
8957 We also silently return if setter and getter are null in the
8958 resolve functions, this condition only happens if we have flagged
8959 the error before. This is the other half of the problem.
8961 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
8962 not have accessibility information, that is why we were returning
8963 true in the filter function in typemanager.cs.
8965 To properly report 122 (property is inaccessible because of its
8966 protection level) correctly, we report this error in ResolveAccess
8967 by failing if both the setter and the getter are lacking (ie, the
8970 DoResolve and DoLResolve have been modified to check for both
8971 setter/getter being null and returning silently, the reason being
8972 that I did not want to put the knowledge about this error in upper
8975 int old = Report.Errors;
8976 x = new PropertyExpr (...);
8977 if (old != Report.Errors)
8982 So the property expr is returned, but it is invalid, so the error
8983 will be flagged during the resolve process.
8985 * class.cs: Remove InheritablePropertySignatureCompare from the
8986 class, as we no longer depend on the property signature to compute
8987 whether it is possible to implement a method or not.
8989 The reason is that calling PropertyInfo.GetGetMethod will return
8990 null (in .NET, in Mono it works, and we should change this), in
8991 cases where the Get Method does not exist in that particular
8996 class X { public virtual int A { get { return 1; } } }
8998 class Z : Y { public override int A { get { return 2; } } }
9000 Would fail in Z because the parent (Y) would not have the property
9001 defined. So we avoid this completely now (because the alternative
9002 fix was ugly and slow), and we now depend exclusively on the
9005 (PropertyBase.CheckBase): Use a method-base mechanism to find our
9006 reference method, instead of using the property.
9008 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
9009 routines are gone now.
9011 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
9012 names, they were incorrectly named.
9014 * cs-tokenizer.cs: Return are more gentle token on failure.
9016 * pending.cs (PendingImplementation.InterfaceMethod): This routine
9017 had an out-of-sync index variable, which caused it to remove from
9018 the list of pending methods the wrong method sometimes.
9020 2002-10-22 Miguel de Icaza <miguel@ximian.com>
9022 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
9023 CanWrite, because those refer to this particular instance of the
9024 property, and do not take into account the fact that we can
9025 override single members of a property.
9027 Constructor requires an EmitContext. The resolution process does
9028 not happen here, but we need to compute the accessors before,
9029 because the resolution does not always happen for properties.
9031 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
9032 subclass, before we did not update this flag, but we did update
9035 (GetAccessors): Drop this routine, as it did not work in the
9036 presence of partially overwritten set/get methods.
9038 Notice that this broke the cs1540 detection, but that will require
9041 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9045 * driver.cs: issue a warning instead of an error if we don't support
9046 debugging for the platform. Also ignore a couple of errors that may
9047 arise when trying to write the symbols. Undo my previous patch.
9049 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9051 * driver.cs: ignore /debug switch except for Unix platforms.
9053 2002-10-23 Nick Drochak <ndrochak@gol.com>
9055 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
9057 2002-10-21 Miguel de Icaza <miguel@ximian.com>
9059 * driver.cs: Do not make mcs-debug conditional, so we do not break
9062 * statement.cs (UsageVector.MergeChildren): I would like Martin to
9063 review this patch. But basically after all the children variables
9064 have been merged, the value of "Breaks" was not being set to
9065 new_breaks for Switch blocks. I think that it should be set after
9066 it has executed. Currently I set this to the value of new_breaks,
9067 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
9068 conservative, but I do not understand this code very well.
9070 I did not break anything in the build, so that is good ;-)
9072 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
9074 2002-10-20 Mark Crichton <crichton@gimp.org>
9076 * cfold.cs: Fixed compile blocker. Really fixed it this time.
9078 2002-10-20 Nick Drochak <ndrochak@gol.com>
9080 * cfold.cs: Fixed compile blocker.
9082 2002-10-20 Miguel de Icaza <miguel@ximian.com>
9084 * driver.cs: I was chekcing the key, not the file.
9086 2002-10-19 Ravi Pratap <ravi@ximian.com>
9088 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
9089 message that we were generating - we just need to silently return
9092 2002-10-19 Miguel de Icaza <miguel@ximian.com>
9094 * class.cs (Event.Define): Change my previous commit, as this
9095 breaks the debugger. This is a temporary hack, as it seems like
9096 the compiler is generating events incorrectly to begin with.
9098 * expression.cs (Binary.ResolveOperator): Added support for
9099 "U operator - (E x, E y)"
9101 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
9104 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
9105 init-only variables, but this path did not take into account that
9106 there might be also instance readonly variables. Correct this
9109 This fixes bug 32253
9111 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
9114 * driver.cs: Change the extension for modules to `netmodule'
9116 * cs-parser.jay: Improved slightly the location tracking for
9117 the debugger symbols.
9119 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
9120 modifiers that were specified instead of the hardcoded value
9121 (FamAndAssem). This was basically ignoring the static modifier,
9122 and others. Fixes 32429.
9124 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
9125 fixed a bug in the process (32476)
9127 * expression.cs (ArrayAccess.EmitAssign): Patch from
9128 hwang_rob@yahoo.ca that fixes bug 31834.3
9130 2002-10-18 Miguel de Icaza <miguel@ximian.com>
9132 * driver.cs: Make the module extension .netmodule.
9134 2002-10-16 Miguel de Icaza <miguel@ximian.com>
9136 * driver.cs: Report an error if the resource file is not found
9137 instead of crashing.
9139 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
9140 false, like Emit does.
9142 2002-10-16 Nick Drochak <ndrochak@gol.com>
9144 * typemanager.cs: Remove unused private member. Also reported mcs
9145 bug to report this as a warning like csc.
9147 2002-10-15 Martin Baulig <martin@gnome.org>
9149 * statement.cs (Statement.Emit): Made this a virtual method; emits
9150 the line number info and calls DoEmit().
9151 (Statement.DoEmit): New protected abstract method, formerly knows
9152 as Statement.Emit().
9154 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
9156 2002-10-11 Miguel de Icaza <miguel@ximian.com>
9158 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
9159 have fixed a remaining problem: not every AddXXXX was adding a
9160 fully qualified name.
9162 Now everyone registers a fully qualified name in the DeclSpace as
9163 being defined instead of the partial name.
9165 Downsides: we are slower than we need to be due to the excess
9166 copies and the names being registered this way.
9168 The reason for this is that we currently depend (on the corlib
9169 bootstrap for instance) that types are fully qualified, because
9170 we dump all the types in the namespace, and we should really have
9171 types inserted into the proper namespace, so we can only store the
9172 basenames in the defined_names array.
9174 2002-10-10 Martin Baulig <martin@gnome.org>
9176 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
9177 from bug #31834, see the bug report for a testcase which is
9180 2002-10-10 Martin Baulig <martin@gnome.org>
9182 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
9183 flow analysis code for this.
9185 * statement.cs (Do, While, For): Tell the flow analysis code about
9187 (FlowBranching.UsageVector): Added support for infinite loops.
9188 (Block.Resolve): Moved the dead code elimination here and use flow
9191 2002-10-09 Miguel de Icaza <miguel@ximian.com>
9193 * class.cs (Field.Define): Catch cycles on struct type
9196 * typemanager.cs (IsUnmanagedtype): Do not recursively check
9197 fields if the fields are static. We only need to check instance
9200 * expression.cs (As.DoResolve): Test for reference type.
9202 * statement.cs (Using.ResolveExpression): Use
9203 ConvertImplicitRequired, not ConvertImplicit which reports an
9205 (Using.ResolveLocalVariableDecls): ditto.
9207 * expression.cs (Binary.ResolveOperator): Report errors in a few
9208 places where we had to.
9210 * typemanager.cs (IsUnmanagedtype): Finish implementation.
9212 2002-10-08 Miguel de Icaza <miguel@ximian.com>
9214 * expression.cs: Use StoreFromPtr instead of extracting the type
9215 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
9217 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
9218 an enumeration value to a System.Enum, but System.Enum is not a
9219 value type, but an class type, so we need to box.
9221 (Expression.ConvertExplicit): One codepath could return
9222 errors but not flag them. Fix this. Fixes #31853
9224 * parameter.cs (Resolve): Do not allow void as a parameter type.
9226 2002-10-06 Martin Baulig <martin@gnome.org>
9228 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
9229 if it's a class type and not a struct. Fixes #31815.
9231 2002-10-06 Martin Baulig <martin@gnome.org>
9233 * statement.cs: Reworked the flow analysis code a bit to make it
9234 usable for dead code elimination.
9236 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9238 * cs-parser.jay: allow empty source files. Fixes bug #31781.
9240 2002-10-04 Miguel de Icaza <miguel@ximian.com>
9242 * expression.cs (ComposedCast.DoResolveType): A quick workaround
9243 to fix the test 165, will investigate deeper.
9245 2002-10-04 Martin Baulig <martin@gnome.org>
9247 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
9248 finally blocks actually work.
9249 (Try.Resolve): We don't need to create a sibling for `finally' if
9250 there is no finally block.
9252 2002-10-04 Martin Baulig <martin@gnome.org>
9254 * class.cs (Constructor.Define): The default accessibility for a
9255 non-default constructor is private, not public.
9257 2002-10-04 Miguel de Icaza <miguel@ximian.com>
9259 * class.cs (Constructor): Make AllowedModifiers public, add
9262 * cs-parser.jay: Perform the modifiers test here, as the
9263 constructor for the Constructor class usually receives a zero
9264 because of the way we create it (first we create, later we
9265 customize, and we were never checking the modifiers).
9267 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
9268 is a version of LookupTypeReflection that includes the type-name
9269 cache. This can be used as a fast path for functions that know
9270 the fully qualified name and are only calling into *.GetType() to
9271 obtain a composed type.
9273 This is also used by TypeManager.LookupType during its type
9276 (LookupType): We now also track the real type name, as sometimes
9277 we can get a quey for the real type name from things like
9278 ComposedCast. This fixes bug 31422.
9280 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
9281 complete type fullname, it does not have to go through the type
9282 resolution system to obtain the composed version of the type (for
9283 obtaining arrays or pointers).
9285 (Conditional.Emit): Use the EmitBoolExpression to
9286 generate nicer code, as requested by Paolo.
9288 (ArrayCreation.CheckIndices): Use the patch from
9289 hwang_rob@yahoo.ca to validate the array initializers.
9291 2002-10-03 Miguel de Icaza <miguel@ximian.com>
9293 * class.cs (ConstructorInitializer.Emit): simplify code by using
9294 Invocation.EmitCall, and at the same time, fix the bugs in calling
9295 parent constructors that took variable arguments.
9297 * ecore.cs (Expression.ConvertNumericExplicit,
9298 Expression.ImplicitNumericConversion): Remove the code that
9299 manually wrapped decimal (InternalTypeConstructor call is now gone
9302 * expression.cs (Cast.TryReduce): Also handle decimal types when
9303 trying to perform a constant fold on the type.
9305 * typemanager.cs (IsUnmanagedtype): Partially implemented.
9307 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
9308 that only turned off an error report, and did nothing else.
9310 2002-10-02 Miguel de Icaza <miguel@ximian.com>
9312 * driver.cs: Handle and ignore /fullpaths
9314 2002-10-01 Miguel de Icaza <miguel@ximian.com>
9316 * expression.cs (Binary.ResolveOperator): Catch the case where
9317 DoNumericPromotions returns true,
9319 (Binary.DoNumericPromotions): Simplify the code, and the tests.
9321 2002-09-27 Miguel de Icaza <miguel@ximian.com>
9323 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
9326 2002-09-26 Miguel de Icaza <miguel@ximian.com>
9328 * ecore.cs (ConvertNumericExplicit): It is not enough that the
9329 conversion exists, but it is also required that the conversion be
9330 performed. This manifested in "(Type64Enum) 2".
9332 * class.cs (TypeManager.AddMethod): The fix is not to change
9333 AddEnum, because that one was using a fully qualified name (every
9334 DeclSpace derivative does), but to change the AddMethod routine
9335 that was using an un-namespaced name. This now correctly reports
9336 the duplicated name.
9338 Revert patch until I can properly fix it. The issue
9339 is that we have a shared Type space across all namespaces
9340 currently, which is wrong.
9342 Options include making the Namespace a DeclSpace, and merge
9343 current_namespace/current_container in the parser.
9345 2002-09-25 Miguel de Icaza <miguel@ximian.com>
9347 * cs-parser.jay: Improve error reporting when we get a different
9348 kind of expression in local_variable_type and
9349 local_variable_pointer_type.
9351 Propagate this to avoid missleading errors being reported.
9353 * ecore.cs (ImplicitReferenceConversion): treat
9354 TypeManager.value_type as a target just like object_type. As
9359 Is valid, and needs to result in the int 1 being boxed before it
9360 is assigned to the value type v.
9362 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
9363 to validate the enumeration name.
9365 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
9366 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
9367 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
9369 * ecore.cs (TryImplicitIntConversion): When doing an
9370 implicit-enumeration-conversion, check if the type is 64-bits and
9371 perform a conversion before passing to EnumConstant.
9373 2002-09-23 Miguel de Icaza <miguel@ximian.com>
9375 * decl.cs (Error_AmbiguousTypeReference); New routine used to
9376 report ambiguous type references. Unlike the MS version, we
9377 report what the ambiguity is. Innovation at work ;-)
9379 (DeclSpace.FindType): Require a location argument to
9380 display when we display an ambiguous error.
9382 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
9384 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
9386 * expression.cs (EmitDynamicInitializers): Apply patch from
9387 hwang_rob@yahoo.ca that fixes the order in which we emit our
9390 2002-09-21 Martin Baulig <martin@gnome.org>
9392 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
9393 delegate takes no arguments.
9395 2002-09-20 Miguel de Icaza <miguel@ximian.com>
9397 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
9400 * expression.cs: Extract the underlying type.
9402 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
9404 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
9406 2002-09-19 Miguel de Icaza <miguel@ximian.com>
9408 * class.cs (TypeContainer.DefineType): We can not use the nice
9409 PackingSize with the size set to 1 DefineType method, because it
9410 will not allow us to define the interfaces that the struct
9413 This completes the fixing of bug 27287
9415 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
9416 means also structs. This fixes part of the problem.
9417 (Expresion.ImplicitReferenceConversionExists): ditto.
9419 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
9420 error if there were no errors reported during the type lookup
9421 process, to avoid duplicates or redundant errors. Without this
9422 you would get an ambiguous errors plus a type not found. We have
9423 beaten the user enough with the first error.
9425 (DeclSparce.FindType): Emit a warning if we have an ambiguous
9428 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
9429 during the resolution process, stop the lookup, this avoids
9430 repeated error reports (same error twice).
9432 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
9434 * typemanager.cs (LookupType): Redo the type lookup code to match
9435 the needs of System.Reflection.
9437 The issue is that System.Reflection requires references to nested
9438 types to begin with a "+" sign instead of a dot. So toplevel
9439 types look like: "NameSpace.TopLevelClass", and nested ones look
9440 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
9443 2002-09-19 Martin Baulig <martin@gnome.org>
9445 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
9446 says that a method always returns or always throws an exception,
9447 don't report the CS0161.
9449 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
9450 set `Returns = new_returns'.
9452 2002-09-19 Martin Baulig <martin@gnome.org>
9454 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
9455 to an enum constant, check for a CS0176.
9457 2002-09-18 Miguel de Icaza <miguel@ximian.com>
9459 * class.cs (TypeContainer.CheckPairedOperators): Now we check
9460 for operators that must be in pairs and report errors.
9462 * ecore.cs (SimpleName.DoResolveType): During the initial type
9463 resolution process, when we define types recursively, we must
9464 check first for types in our current scope before we perform
9465 lookups in the enclosing scopes.
9467 * expression.cs (MakeByteBlob): Handle Decimal blobs.
9469 (Invocation.VerifyArgumentsCompat): Call
9470 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
9471 I thought we were supposed to always call this, but there are a
9472 few places in the code where we dont do it.
9474 2002-09-17 Miguel de Icaza <miguel@ximian.com>
9476 * driver.cs: Add support in -linkres and -resource to specify the
9477 name of the identifier.
9479 2002-09-16 Miguel de Icaza <miguel@ximian.com>
9481 * ecore.cs (StandardConversionExists): Sync with the conversion
9482 code: allow anything-* to void* conversions.
9484 (FindMostSpecificSource): Use an Expression argument
9485 instead of a Type, because we might be handed over a Literal which
9486 gets a few more implicit conversions that plain types do not. So
9487 this information was being lost.
9489 Also, we drop the temporary type-holder expression when not
9492 2002-09-17 Martin Baulig <martin@gnome.org>
9494 * class.cs (PropertyBase.CheckBase): Don't check the base class if
9495 this is an explicit interface implementation.
9497 2002-09-17 Martin Baulig <martin@gnome.org>
9499 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
9500 different `IndexerName' attributes.
9502 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
9503 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
9504 virtual CommonResolve().
9506 2002-09-16 Miguel de Icaza <miguel@ximian.com>
9508 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
9509 and convert that to the UnderlyingType.
9511 * statement.cs (Foreach.Resolve): Indexers are just like variables
9512 or PropertyAccesses.
9514 * cs-tokenizer.cs (consume_string): Track line numbers and columns
9515 inside quoted strings, we were not doing this before.
9517 2002-09-16 Martin Baulig <martin@gnome.org>
9519 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
9520 resolve it. This is needed for the definite assignment check of the
9521 instance expression, fixes bug #29846.
9522 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
9524 2002-09-16 Nick Drochak <ndrochak@gol.com>
9526 * parameter.cs: Fix compile error. Cannot reference static member
9527 from an instance object. Is this an mcs bug?
9529 2002-09-14 Martin Baulig <martin@gnome.org>
9531 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
9532 multiple times. Fixes bug #30295, added test-166.cs.
9534 2002-09-14 Martin Baulig <martin@gnome.org>
9536 * statement.cs (Block.Emit): Don't emit unreachable code.
9537 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
9539 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
9541 2002-09-14 Martin Baulig <martin@gnome.org>
9543 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
9546 2002-09-14 Martin Baulig <martin@gnome.org>
9548 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
9549 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
9550 be false on the ms runtime.
9552 2002-09-13 Martin Baulig <martin@gnome.org>
9554 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
9555 the CS0038 error message.
9557 2002-09-12 Miguel de Icaza <miguel@ximian.com>
9559 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
9560 constant inside, return it.
9562 2002-09-12 Martin Baulig <martin@gnome.org>
9564 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
9565 implicit conversion can be done between enum types.
9567 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
9568 check whether an implicit conversion to the current enum's UnderlyingType
9569 exists and report an error if not.
9571 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
9572 without debugging support.
9574 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
9575 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
9577 2002-09-12 Martin Baulig <martin@gnome.org>
9579 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
9581 * ecore.cs (IMemberExpr.DeclaringType): New property.
9582 (SimpleName.SimpleNameResolve): Check whether we're accessing a
9583 nonstatic member of an outer type (CS0038).
9585 2002-09-11 Miguel de Icaza <miguel@ximian.com>
9587 * driver.cs: Activate the using-error detector at warning level
9588 4 (at least for MS-compatible APIs).
9590 * namespace.cs (VerifyUsing): Small buglett fix.
9592 * pending.cs (PendingImplementation): pass the container pointer.
9594 * interface.cs (GetMethods): Allow for recursive definition. Long
9595 term, I would like to move every type to support recursive
9596 definitions, not the current ordering mechanism that we have right
9599 The situation is this: Attributes are handled before interfaces,
9600 so we can apply attributes to interfaces. But some attributes
9601 implement interfaces, we will now handle the simple cases
9602 (recursive definitions will just get an error).
9604 * parameter.cs: Only invalidate types at the end if we fail to
9607 2002-09-09 Martin Baulig <martin@gnome.org>
9609 * ecore.cs (PropertyExpr.Emit): Also check for
9610 TypeManager.system_int_array_get_length so this'll also work when
9611 compiling corlib. Fixes #30003.
9613 2002-09-09 Martin Baulig <martin@gnome.org>
9615 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
9616 and throw an exception if we can't get the type's size. Fixed #30040,
9619 2002-09-09 Martin Baulig <martin@gnome.org>
9621 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
9623 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
9624 context. Fixes bug #30027.
9626 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
9627 virtual functions. Fixes bug #30043, added test-164.cs.
9629 2002-09-08 Ravi Pratap <ravi@ximian.com>
9631 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
9633 2002-09-08 Nick Drochak <ndrochak@gol.com>
9635 * driver.cs: Use an object to get the windows codepage since it's not a
9638 2002-09-08 Miguel de Icaza <miguel@ximian.com>
9640 * statement.cs (For.Emit): for infinite loops (test == null)
9641 return whether there is a break inside, not always "true".
9643 * namespace.cs (UsingEntry): New struct to hold the name of the
9644 using definition, the location where it is defined, and whether it
9645 has been used in a successful type lookup.
9647 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
9652 2002-09-06 Ravi Pratap <ravi@ximian.com>
9654 * attribute.cs : Fix incorrect code which relied on catching
9655 a NullReferenceException to detect a null being passed in
9656 where an object was expected.
9658 2002-09-06 Miguel de Icaza <miguel@ximian.com>
9660 * statement.cs (Try): flag the catch variable as assigned
9662 * expression.cs (Cast): Simplified by using ResolveType instead of
9665 * statement.cs (Catch): Fix bug by using ResolveType.
9667 2002-09-06 Ravi Pratap <ravi@ximian.com>
9669 * expression.cs (BetterConversion): Special case for when we have
9670 a NullLiteral as the argument and we have to choose between string
9671 and object types - we choose string the way csc does.
9673 * attribute.cs (Attribute.Resolve): Catch the
9674 NullReferenceException and report error #182 since the Mono
9675 runtime no more has the bug and having this exception raised means
9676 we tried to select a constructor which takes an object and is
9679 2002-09-05 Ravi Pratap <ravi@ximian.com>
9681 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
9682 message (1502, 1503) when we can't locate a method after overload
9683 resolution. This is much more informative and closes the bug
9686 * interface.cs (PopulateMethod): Return if there are no argument
9687 types. Fixes a NullReferenceException bug.
9689 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
9690 expressions too. Previously we were checking only in one place for
9691 positional arguments leaving out named arguments.
9693 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
9694 type to the enum type is not allowed. Remove code corresponding to
9697 (ConvertNumericExplicit): Allow explicit conversions from
9698 the underlying type to enum type. This precisely follows the spec
9699 and closes a bug filed by Gonzalo.
9701 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9704 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
9706 2002-09-03 Miguel de Icaza <miguel@ximian.com>
9708 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
9709 it was important that we stored the right value after the
9710 reduction in `converted'.
9712 2002-09-04 Martin Baulig <martin@gnome.org>
9714 * location.cs (Location.SymbolDocument): Use full pathnames for the
9717 2002-08-30 Miguel de Icaza <miguel@ximian.com>
9719 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
9720 of the expression resolve mechanism, because that will catch the
9721 SimpleName error failures.
9723 (Conditional): If we can not resolve the
9724 expression, return, do not crash.
9726 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9729 (location): display token name instead of its number.
9731 2002-08-28 Martin Baulig <martin@gnome.org>
9733 * expression.cs (Binary.ResolveOperator): Don't silently return
9734 but return an error if an operator cannot be applied between two
9737 2002-08-28 Martin Baulig <martin@gnome.org>
9739 * class.cs (Constructor.Define): Set the permission attributes
9740 correctly instead of making all constructors public.
9742 2002-08-28 Martin Baulig <martin@gnome.org>
9744 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
9745 for private members before reporting a CS0103; if we find anything,
9748 2002-08-28 Martin Baulig <martin@gnome.org>
9750 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
9751 to check whether `closure_start_type == closure_invocation_type',
9752 we also need to check whether `m.DeclaringType == closure_invocation_type'
9753 before bypassing the permission checks. We might be accessing
9754 protected/private members from the base class.
9755 (TypeManager.RealMemberLookup): Only set private_ok if private
9756 members were requested via BindingFlags.NonPublic.
9758 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
9760 * expression.cs (MemberAccess.ResolveMemberAccess): Set
9761 MethodGroupExpr.IsExplicitImpl if appropriate.
9762 (Invocation.DoResolve): Don't report the CS0120 for explicit
9763 interface implementations.
9765 2002-08-27 Martin Baulig <martin@gnome.org>
9767 * expression.cs (Invocation.DoResolve): If this is a static
9768 method and we don't have an InstanceExpression, we must report
9771 2002-08-25 Martin Baulig <martin@gnome.org>
9773 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
9774 `==' between a valuetype and an object.
9776 2002-08-25 Miguel de Icaza <miguel@ximian.com>
9778 * ecore.cs (TypeExpr): Provide a ToString method.
9780 2002-08-24 Martin Baulig <martin@gnome.org>
9782 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
9783 now called proggie.dbg and it's a binary file.
9785 2002-08-23 Martin Baulig <martin@gnome.org>
9787 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
9789 2002-08-23 Martin Baulig <martin@gnome.org>
9791 * struct.cs (MyStructInfo.ctor): Make this work with empty
9792 structs; it's not allowed to use foreach() on null.
9794 2002-08-23 Martin Baulig <martin@gnome.org>
9796 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
9797 writer the full pathname of the generated assembly.
9799 2002-08-23 Martin Baulig <martin@gnome.org>
9801 * statements.cs (FlowBranching.UsageVector.MergeChildren):
9802 A `finally' block never returns or breaks; improved handling of
9805 2002-08-23 Martin Baulig <martin@gnome.org>
9807 * statement.cs (Throw.Resolve): Allow `throw null'.
9809 2002-08-23 Martin Baulig <martin@gnome.org>
9811 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
9812 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
9813 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
9814 MemberLookup would return a wrong event if this is an explicit
9815 interface implementation and the class has an event with the same
9818 2002-08-23 Martin Baulig <martin@gnome.org>
9820 * statement.cs (Block.AddChildVariableNames): New public method.
9821 (Block.AddChildVariableName): Likewise.
9822 (Block.IsVariableNameUsedInChildBlock): Likewise.
9823 (Block.AddVariable): Check whether a variable name has already
9824 been used in a child block.
9826 * cs-parser.jay (declare_local_variables): Mark all variable names
9827 from the current block as being used in a child block in the
9830 2002-08-23 Martin Baulig <martin@gnome.org>
9832 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
9833 find the symbol writer.
9835 * driver.cs: csc also allows the arguments to /define being
9836 separated by commas, not only by semicolons.
9838 2002-08-23 Martin Baulig <martin@gnome.org>
9840 * interface.cs (Interface.GetMembers): Added static check for events.
9842 2002-08-15 Martin Baulig <martin@gnome.org>
9844 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
9845 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
9847 * ecore.cs (Expression.MemberLookup): Added documentation and explained
9848 why the MethodData.EmitDestructor() change was necessary.
9850 2002-08-20 Martin Baulig <martin@gnome.org>
9852 * class.cs (TypeContainer.FindMembers): Added static check for events.
9854 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
9856 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
9857 use Type.GetEvents(), not Type.FindMembers().
9859 2002-08-20 Martin Baulig <martin@gnome.org>
9861 * decl.cs (MemberCache): Added a special method cache which will
9862 be used for method-only searched. This ensures that a method
9863 search will return a MethodInfo with the correct ReflectedType for
9866 2002-08-20 Martin Baulig <martin@gnome.org>
9868 * decl.cs (DeclSpace.FindMembers): Made this public.
9870 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9872 * delegate.cs: fixed build on windows.
9873 [FIXME: Filed as bug #29150: MCS must report these errors.]
9875 2002-08-19 Ravi Pratap <ravi@ximian.com>
9877 * ecore.cs (StandardConversionExists): Return a false
9878 if we are trying to convert the void type to anything else
9879 since that is not allowed.
9881 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
9882 we flag error 70 in the event an event is trying to be accessed
9883 directly from outside the declaring type.
9885 2002-08-20 Martin Baulig <martin@gnome.org>
9887 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
9888 MemberCache from typemanager.cs to decl.cs.
9890 2002-08-19 Martin Baulig <martin@gnome.org>
9892 * class.cs (TypeContainer): Implement IMemberContainer.
9893 (TypeContainer.DefineMembers): Create the MemberCache.
9894 (TypeContainer.FindMembers): Do better BindingFlags checking; only
9895 return public members if BindingFlags.Public was given, check
9896 whether members are static.
9898 2002-08-16 Martin Baulig <martin@gnome.org>
9900 * decl.cs (DeclSpace.Define): Splitted this in Define and
9901 DefineMembers. DefineMembers is called first and initializes the
9904 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
9905 DefineMembers() on all our DeclSpaces.
9907 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
9908 but call DefineMembers() on all nested interfaces. We call their
9909 Define() in our new Define() function.
9911 * interface.cs (Interface): Implement IMemberContainer.
9912 (Interface.Define): Moved all code except the attribute stuf to
9914 (Interface.DefineMembers): Initialize the member cache.
9916 * typemanager.cs (IMemberFinder): Removed this interface, we don't
9917 need this anymore since we can use MemberCache.FindMembers directly.
9919 2002-08-19 Martin Baulig <martin@gnome.org>
9921 * typemanager.cs (MemberCache): When creating the cache for an
9922 interface type, add all inherited members.
9923 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
9924 to `out bool used_cache' and documented it.
9925 (TypeManager.MemberLookup): If we already used the cache in the first
9926 iteration, we don't need to do the interfaces check.
9928 2002-08-19 Martin Baulig <martin@gnome.org>
9930 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
9931 here from IMemberFinder and don't implement this interface anymore.
9932 (DeclSpace.MemberCache): Moved here from IMemberFinder.
9934 * typemanager.cs (IMemberFinder): This interface is now only used by
9935 classes which actually support the member cache.
9936 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
9937 since we only put DeclSpaces into this Hashtable.
9938 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
9939 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
9941 2002-08-16 Martin Baulig <martin@gnome.org>
9943 * typemanager.cs (ICachingMemberFinder): Removed.
9944 (IMemberFinder.MemberCache): New property.
9945 (TypeManager.FindMembers): Merged this with RealFindMembers().
9946 This function will never be called from TypeManager.MemberLookup()
9947 so we can't use the cache here, just the IMemberFinder.
9948 (TypeManager.MemberLookup_FindMembers): Check whether the
9949 IMemberFinder has a MemberCache and call the cache's FindMembers
9951 (MemberCache): Rewrote larger parts of this yet another time and
9952 cleaned it up a bit.
9954 2002-08-15 Miguel de Icaza <miguel@ximian.com>
9956 * driver.cs (LoadArgs): Support quoting.
9958 (Usage): Show the CSC-like command line arguments.
9960 Improved a few error messages.
9962 2002-08-15 Martin Baulig <martin@gnome.org>
9964 * typemanager.cs (IMemberContainer.Type): New property.
9965 (IMemberContainer.IsInterface): New property.
9967 The following changes are conditional to BROKEN_RUNTIME, which is
9968 defined at the top of the file.
9970 * typemanager.cs (MemberCache.MemberCache): Don't add the base
9971 class'es members, but add all members from TypeHandle.ObjectType
9972 if we're an interface.
9973 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
9974 is the current type.
9975 (MemberCache.CacheEntry.Container): Removed this field.
9976 (TypeHandle.GetMembers): Include inherited members.
9978 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9980 * typemanager.cs: fixed compilation and added a comment on a field that
9983 2002-08-15 Martin Baulig <martin@gnome.org>
9985 * class.cs (ConstructorInitializer.Resolve): In the
9986 Expression.MemberLookup call, use the queried_type as
9989 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
9990 declared' attribute, it's always true.
9991 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
9992 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
9993 temporary wrapper for FindMembers which tells MemberLookup whether
9994 members from the base classes are included in the return value.
9995 This will go away soon.
9996 (TypeManager.MemberLookup): Use this temporary hack here; once the
9997 new MemberCache is completed, we don't need to do the DeclaredOnly
9998 looping here anymore since the MemberCache will take care of this.
9999 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
10000 (MemberCache): When creating the MemberCache for a class, get
10001 members from the current class and all its base classes.
10002 (MemberCache.CacheEntry.Container): New field. This is a
10003 temporary hack until the Mono runtime is fixed to distinguish
10004 between ReflectedType and DeclaringType. It allows us to use MCS
10005 with both the MS runtime and the unfixed Mono runtime without
10006 problems and without accecting performance.
10007 (MemberCache.SearchMembers): The DeclaredOnly looping from
10008 TypeManager.MemberLookup is now done here.
10010 2002-08-14 Martin Baulig <martin@gnome.org>
10012 * statement.cs (MyStructInfo.MyStructInfo): Don't call
10013 Type.GetFields on dynamic types but get the fields from the
10014 corresponding TypeContainer.
10015 (MyStructInfo.GetStructInfo): Added check for enum types.
10017 * typemanager.cs (MemberList.IsSynchronized): Implemented.
10018 (MemberList.SyncRoot): Implemented.
10019 (TypeManager.FilterWithClosure): No need to check permissions if
10020 closure_start_type == closure_invocation_type, don't crash if
10021 closure_invocation_type is null.
10023 2002-08-13 Martin Baulig <martin@gnome.org>
10025 Rewrote TypeContainer.FindMembers to use a member cache. This
10026 gives us a speed increase of about 35% for the self-hosting MCS
10027 build and of about 15-20% for the class libs (both on GNU/Linux).
10029 * report.cs (Timer): New class to get enhanced profiling. This
10030 whole class is "TIMER" conditional since it remarkably slows down
10033 * class.cs (MemberList): New class. This is an IList wrapper
10034 which we're now using instead of passing MemberInfo[]'s around to
10035 avoid copying this array unnecessarily.
10036 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
10037 (ICachingMemberFinder, IMemberContainer): New interface.
10038 (TypeManager.FilterWithClosure): If `criteria' is null, the name
10039 has already been checked, otherwise use it for the name comparision.
10040 (TypeManager.FindMembers): Renamed to RealMemberFinder and
10041 provided wrapper which tries to use ICachingMemberFinder.FindMembers
10042 if possible. Returns a MemberList, not a MemberInfo [].
10043 (TypeHandle): New class, implements IMemberContainer. We create
10044 one instance of this class per type, it contains a MemberCache
10045 which is used to do the member lookups.
10046 (MemberCache): New class. Each instance of this class contains
10047 all members of a type and a name-based hash table.
10048 (MemberCache.FindMembers): This is our new member lookup
10049 function. First, it looks up all members of the requested name in
10050 the hash table. Then, it walks this list and sorts out all
10051 applicable members and returns them.
10053 2002-08-13 Martin Baulig <martin@gnome.org>
10055 In addition to a nice code cleanup, this gives us a performance
10056 increase of about 1.4% on GNU/Linux - not much, but it's already
10057 half a second for the self-hosting MCS compilation.
10059 * typemanager.cs (IMemberFinder): New interface. It is used by
10060 TypeManager.FindMembers to call FindMembers on a TypeContainer,
10061 Enum, Delegate or Interface.
10062 (TypeManager.finder_to_member_finder): New PtrHashtable.
10063 (TypeManager.finder_to_container): Removed.
10064 (TypeManager.finder_to_delegate): Removed.
10065 (TypeManager.finder_to_interface): Removed.
10066 (TypeManager.finder_to_enum): Removed.
10068 * interface.cs (Interface): Implement IMemberFinder.
10070 * delegate.cs (Delegate): Implement IMemberFinder.
10072 * enum.cs (Enum): Implement IMemberFinder.
10074 * class.cs (TypeContainer): Implement IMemberFinder.
10076 2002-08-12 Martin Baulig <martin@gnome.org>
10078 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
10080 2002-08-12 Martin Baulig <martin@gnome.org>
10082 * ecore.cs (ITypeExpression): New interface for expressions which
10084 (TypeExpression): Renamed to TypeLookupExpression.
10085 (Expression.DoResolve): If we're doing a types-only lookup, the
10086 expression must implement the ITypeExpression interface and we
10087 call DoResolveType() on it.
10088 (SimpleName): Implement the new ITypeExpression interface.
10089 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
10090 hack, the situation that we're only looking up types can't happen
10091 anymore when this method is called. Moved the type lookup code to
10092 DoResolveType() and call it.
10093 (SimpleName.DoResolveType): This ITypeExpression interface method
10094 is now doing the types-only lookup.
10095 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
10096 (ResolveFlags): Added MaskExprClass.
10098 * expression.cs (MemberAccess): Implement the ITypeExpression
10100 (MemberAccess.DoResolve): Added support for a types-only lookup
10101 when we're called via ITypeExpression.DoResolveType().
10102 (ComposedCast): Implement the ITypeExpression interface.
10104 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
10105 Expression.Resolve() with ResolveFlags.Type instead.
10107 2002-08-12 Martin Baulig <martin@gnome.org>
10109 * interface.cs (Interface.Define): Apply attributes.
10111 * attribute.cs (Attribute.ApplyAttributes): Added support for
10112 interface attributes.
10114 2002-08-11 Martin Baulig <martin@gnome.org>
10116 * statement.cs (Block.Emit): Only check the "this" variable if we
10117 do not always throw an exception.
10119 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
10120 whether the property has a set accessor.
10122 2002-08-11 Martin Baulig <martin@gnome.org>
10124 Added control flow analysis support for structs.
10126 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
10127 with control flow analysis turned off.
10128 (IVariable): New interface.
10129 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
10130 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
10131 (FieldExpr.DoResolve): Resolve the instance expression with flow
10132 analysis turned off and do the definite assignment check after the
10133 resolving when we know what the expression will resolve to.
10135 * expression.cs (LocalVariableReference, ParameterReference):
10136 Implement the new IVariable interface, only call the flow analysis
10137 code if ec.DoFlowAnalysis is true.
10138 (This): Added constructor which takes a Block argument. Implement
10139 the new IVariable interface.
10140 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
10141 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
10142 This does the definite assignment checks for struct members.
10144 * class.cs (Constructor.Emit): If this is a non-static `struct'
10145 constructor which doesn't have any initializer, call
10146 Block.AddThisVariable() to tell the flow analysis code that all
10147 struct elements must be initialized before control returns from
10150 * statement.cs (MyStructInfo): New public class.
10151 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
10152 argument to this indexer. If non-zero, check an individual struct
10153 member, not the whole struct.
10154 (FlowBranching.CheckOutParameters): Check struct members.
10155 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
10156 overloaded versions of these methods which take an additional
10157 `int field_idx' argument to check struct members.
10158 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
10159 overloaded versions of these methods which take an additional
10160 `string field_name' argument to check struct member.s
10161 (VariableInfo): Implement the IVariable interface.
10162 (VariableInfo.StructInfo): New public property. Returns the
10163 MyStructInfo instance of the variable if it's a struct or null.
10164 (Block.AddThisVariable): New public method. This is called from
10165 Constructor.Emit() for non-static `struct' constructor which do
10166 not have any initializer. It creates a special variable for the
10167 "this" instance variable which will be checked by the flow
10168 analysis code to ensure that all of the struct's fields are
10169 initialized before control returns from the constructor.
10170 (UsageVector): Added support for struct members. If a
10171 variable/parameter is a struct with N members, we reserve a slot
10172 in the usage vector for each member. A struct is considered fully
10173 initialized if either the struct itself (slot 0) or all its
10174 members are initialized.
10176 2002-08-08 Martin Baulig <martin@gnome.org>
10178 * driver.cs (Driver.MainDriver): Only report an error CS5001
10179 if there were no compilation errors.
10181 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
10182 `UnsafeContext' property to determine whether the parent is in
10183 unsafe context rather than checking the parent's ModFlags:
10184 classes nested in an unsafe class are unsafe as well.
10186 2002-08-08 Martin Baulig <martin@gnome.org>
10188 * statement.cs (UsageVector.MergeChildren): Distinguish between
10189 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
10190 we return. Added test17() and test18() to test-154.cs.
10192 2002-08-08 Martin Baulig <martin@gnome.org>
10194 * typemanager.cs (TypeManager.FilterWithClosure): If we have
10195 Family access, make sure the invoking type isn't a subclass of the
10196 queried type (that'd be a CS1540).
10198 * ecore.cs (Expression.MemberLookup): Added overloaded version of
10199 this method which takes an additional `Type invocation_type'.
10201 * expression.cs (BaseAccess.DoResolve): Use the base type as
10202 invocation and query type.
10203 (MemberAccess.DoResolve): If the lookup failed and we're about to
10204 report a CS0122, try a lookup with the ec.ContainerType - if this
10205 succeeds, we must report a CS1540.
10207 2002-08-08 Martin Baulig <martin@gnome.org>
10209 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
10210 (MethodGroupExpr): Implement the IMemberExpr interface.
10212 * expression (MemberAccess.ResolveMemberAccess): No need to have
10213 any special code for MethodGroupExprs anymore, they're now
10216 2002-08-08 Martin Baulig <martin@gnome.org>
10218 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
10219 Family, FamANDAssem and FamORAssem permissions.
10220 (TypeManager.IsSubclassOrNestedChildOf): New public method.
10222 2002-08-08 Martin Baulig <martin@gnome.org>
10224 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
10225 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
10228 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
10230 * driver.cs: implemented /resource option to embed managed resources.
10232 2002-08-07 Martin Baulig <martin@gnome.org>
10234 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
10235 (FieldBase.HasFieldInitializer): New public property.
10236 (FieldBase.GetInitializerExpression): New public method. Resolves and
10237 returns the field initializer and makes sure it is only resolved once.
10238 (TypeContainer.EmitFieldInitializers): Call
10239 FieldBase.GetInitializerExpression to get the initializer, this ensures
10240 that it isn't resolved multiple times.
10242 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
10243 the resolving process (SimpleName/MemberLookup) that we're currently
10244 emitting a field initializer (which must not access any instance members,
10245 this is an error CS0236).
10247 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
10248 argument, if the `IsFieldInitializer' flag is set, we must report and
10249 error CS0236 and not an error CS0120.
10251 2002-08-07 Martin Baulig <martin@gnome.org>
10253 * ecore.cs (IMemberExpr): New public interface.
10254 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
10255 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
10256 if the expression is an IMemberExpr.
10258 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
10259 to be null, implicitly default to `this' if we're non-static in
10260 this case. Simplified the code a lot by using the new IMemberExpr
10261 interface. Also fixed bug #28176 here.
10263 2002-08-06 Martin Baulig <martin@gnome.org>
10265 * cs-parser.jay (SimpleLookup): Removed. We need to create
10266 ParameterReferences during semantic analysis so that we can do a
10267 type-only search when resolving Cast, TypeOf and SizeOf.
10268 (block): Pass the `current_local_parameters' to the Block's
10271 * class.cs (ConstructorInitializer): Added `Parameters parameters'
10272 argument to the constructor.
10273 (ConstructorInitializer.Resolve): Create a temporary implicit
10274 block with the parameters.
10276 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
10277 references here if we aren't doing a type-only search.
10279 * statement.cs (Block): Added constructor which takes a
10280 `Parameters parameters' argument.
10281 (Block.Parameters): New public property.
10283 * support.cs (InternalParameters.Parameters): Renamed `parameters'
10284 to `Parameters' and made it public readonly.
10286 2002-08-06 Martin Baulig <martin@gnome.org>
10288 * ecore.cs (Expression.Warning): Made this public as well.
10290 * report.cs (Report.Debug): Print the contents of collections.
10292 2002-08-06 Martin Baulig <martin@gnome.org>
10294 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
10295 used to tell Resolve() which kinds of expressions it may return.
10296 (Expression.Resolve): Added overloaded version of this method which
10297 takes a `ResolveFlags flags' argument. This can be used to tell
10298 Resolve() which kinds of expressions it may return. Reports a
10300 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
10301 ResolveFlags.SimpleName.
10302 (Expression.Error118): Added overloaded version of this method which
10303 takes a `ResolveFlags flags' argument. It uses the flags to determine
10304 which kinds of expressions are allowed.
10306 * expression.cs (Argument.ResolveMethodGroup): New public method.
10307 Resolves an argument, but allows a MethodGroup to be returned.
10308 This is used when invoking a delegate.
10310 * TODO: Updated a bit.
10312 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10314 Fixed compilation with csc.
10316 * ecore.cs: Expression.Error made public. Is this correct? Should
10317 Warning be made public too?
10319 * expression.cs: use ea.Location instead of ea.loc.
10320 [FIXME: Filed as bug #28607: MCS must report these errors.]
10322 2002-08-06 Martin Baulig <martin@gnome.org>
10324 * ecore.cs (Expression.loc): Moved the location here instead of
10325 duplicating it in all derived classes.
10326 (Expression.Location): New public property.
10327 (Expression.Error, Expression.Warning): Made them non-static and
10328 removed the location argument.
10329 (Expression.Warning): Added overloaded version which takes an
10330 `int level' argument.
10331 (Expression.Error118): Make this non-static and removed the
10332 expression and location arguments.
10333 (TypeExpr): Added location argument to the constructor.
10335 * expression.cs (StaticCallExpr): Added location argument to
10337 (Indirection, PointerArithmetic): Likewise.
10338 (CheckedExpr, UnCheckedExpr): Likewise.
10339 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
10340 (StringPtr): Likewise.
10343 2002-08-05 Martin Baulig <martin@gnome.org>
10345 * expression.cs (BaseAccess.DoResolve): Actually report errors.
10347 * assign.cs (Assign.DoResolve): Check whether the source
10348 expression is a value or variable.
10350 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
10351 while resolving the corresponding blocks.
10353 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
10354 an error, don't silently return null.
10356 * statement.cs (Block.AddVariable): Do the error reporting here
10357 and distinguish between CS0128 and CS0136.
10358 (Block.DoResolve): Report all unused labels (warning CS0164).
10359 (LabeledStatement): Pass the location to the constructor.
10360 (LabeledStatement.HasBeenReferenced): New property.
10361 (LabeledStatement.Resolve): Set it to true here.
10363 * statement.cs (Return.Emit): Return success even after reporting
10364 a type mismatch error (CS0126 or CS0127), this is what csc does and
10365 it avoids confusing the users with any consecutive errors.
10367 2002-08-05 Martin Baulig <martin@gnome.org>
10369 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
10371 * const.cs (Const.LookupConstantValue): Catch circular definitions.
10373 * expression.cs (MemberAccess.DoResolve): Silently return if an
10374 error has already been reported.
10376 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
10377 error has already been reported.
10379 2002-08-05 Martin Baulig <martin@gnome.org>
10381 * statement.cs (UsageVector): Only initialize the `parameters'
10382 vector if we actually have any "out" parameters.
10384 2002-08-05 Martin Baulig <martin@gnome.org>
10386 * expression.cs (Binary.ResolveOperator): When combining delegates,
10387 they must have the same type.
10389 2002-08-05 Martin Baulig <martin@gnome.org>
10391 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
10392 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
10393 work with the ms runtime and we also don't need it: if we're a
10394 PropertyBuilder and not in the `indexer_arguments' hash, then we
10395 are a property and not an indexer.
10397 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
10398 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
10399 since the latter one doesn't work with the ms runtime.
10401 2002-08-03 Martin Baulig <martin@gnome.org>
10403 Fixed bugs #27998 and #22735.
10405 * class.cs (Method.IsOperator): New public field.
10406 (Method.CheckBase): Report CS0111 if there's already a method
10407 with the same parameters in the current class. Report CS0508 when
10408 attempting to change the return type of an inherited method.
10409 (MethodData.Emit): Report CS0179 if a method doesn't have a body
10410 and it's not marked abstract or extern.
10411 (PropertyBase): New abstract base class for Property and Indexer.
10412 (PropertyBase.CheckBase): Moved here from Property and made it work
10414 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
10415 the same so we can reuse it there.
10416 (Property, Indexer): Derive from PropertyBase.
10417 (MethodSignature.inheritable_property_signature_filter): New delegate
10418 to find properties and indexers.
10420 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
10421 argument and improved error reporting.
10423 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
10424 EmptyReadOnlyParameters and made it a property.
10426 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
10427 version of this method which takes a `PropertyInfo indexer'.
10428 (TypeManager.RegisterIndexer): New method.
10430 * class.cs: Added myself as author of this file :-)
10432 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10434 * class.cs: fixed compilation on windoze.
10436 2002-08-03 Martin Baulig <martin@gnome.org>
10438 * interface.cs (Interface.GetInterfaceBases): Check whether all
10439 base interfaces are at least as accessible than the current one.
10441 * class.cs (TypeContainer.GetClassBases): Check whether base types
10442 are at least as accessible than the current type.
10443 (TypeContainer.AsAccessible): Implemented and made non-static.
10444 (MemberBase.CheckParameters): Report errors if the accessibility
10447 * delegate.cs (Delegate.Delegate): The default visibility is
10448 internal for top-level types and private for nested types.
10449 (Delegate.Define): Report errors if the accessibility checks fail.
10451 * enum.cs (Enum.Enum): The default visibility is internal for
10452 top-level types and private for nested types.
10453 (Enum.DefineType): Compute the correct visibility.
10455 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
10456 function which takes a `bool is_toplevel' instead of a TypeContainer.
10458 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
10461 2002-08-02 Martin Baulig <martin@gnome.org>
10463 * expression.cs (LocalVariableReferenc): Added constructor which
10464 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
10465 (LocalVariableReference.IsReadOnly): New property.
10466 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
10467 variable is readonly, use our own readonly flag to do this; you can
10468 use the new constructor to get a writable reference to a read-only
10471 * cs-parser.jay (foreach_statement, using_statement): Get a writable
10472 reference to the local variable.
10474 2002-08-01 Miguel de Icaza <miguel@ximian.com>
10476 * rootcontext.cs (ResolveCore): Also include System.Exception
10478 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
10479 we reach an EmptyStatement.
10481 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
10484 * expression.cs (Binary.ResolveOperator): Check error result in
10487 use brtrue/brfalse directly and avoid compares to null.
10489 2002-08-02 Martin Baulig <martin@gnome.org>
10491 * class.cs (TypeContainer.Define): Define all nested interfaces here.
10492 Fixes bug #28407, added test-155.cs.
10494 2002-08-01 Martin Baulig <martin@gnome.org>
10496 * class.cs (Event.EmitDefaultMethod): Make this work with static
10497 events. Fixes #28311, added verify-3.cs.
10499 2002-08-01 Martin Baulig <martin@gnome.org>
10501 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
10502 `is_disposable' fields.
10503 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
10504 `hm.is_disposable' if we're using the collection pattern.
10505 (Foreach.EmitCollectionForeach): Use the correct type for the
10506 enumerator's local variable, only emit the try/finally block if
10507 necessary (fixes #27713).
10509 2002-08-01 Martin Baulig <martin@gnome.org>
10511 * ecore.cs (Expression.report118): Renamed to Error118 and made
10514 * statement.cs (Throw.Resolve): Check whether the expression is of
10515 the correct type (CS0118) and whether the type derives from
10516 System.Exception (CS0155).
10517 (Catch.Resolve): New method. Do the type lookup here and check
10518 whether it derives from System.Exception (CS0155).
10519 (Catch.CatchType, Catch.IsGeneral): New public properties.
10521 * typemanager.cs (TypeManager.exception_type): Added.
10523 2002-07-31 Miguel de Icaza <miguel@ximian.com>
10525 * driver.cs: Updated About function.
10527 2002-07-31 Martin Baulig <martin@gnome.org>
10529 Implemented Control Flow Analysis.
10531 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
10532 (EmitContext.CurrentBranching): Added.
10533 (EmitContext.StartFlowBranching): Added.
10534 (EmitContext.EndFlowBranching): Added.
10535 (EmitContext.KillFlowBranching): Added.
10536 (EmitContext.IsVariableAssigned): Added.
10537 (EmitContext.SetVariableAssigned): Added.
10538 (EmitContext.IsParameterAssigned): Added.
10539 (EmitContext.SetParameterAssigned): Added.
10540 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
10541 Added control flow analysis stuff here.
10543 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
10544 resolve the expression as lvalue.
10545 (LocalVariableReference.DoResolve): Check whether the variable has
10546 already been assigned.
10547 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
10548 the parameter as assigned here.
10549 (ParameterReference.DoResolve): Check whether the parameter has already
10551 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
10552 expression as lvalue.
10554 * statement.cs (FlowBranching): New class for the flow analysis code.
10555 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
10556 (LabeledStatement.IsDefined): New public property.
10557 (LabeledStatement.AddUsageVector): New public method to tell flow
10558 analyis that the label may be reached via a forward jump.
10559 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
10561 (VariableInfo.Number): New public field. This is used by flow analysis
10562 to number all locals of a block.
10563 (Block.CountVariables): New public property. This is the number of
10564 local variables in this block (including the locals from all parent
10566 (Block.EmitMeta): Number all the variables.
10568 * statement.cs: Added flow analysis support to all classes.
10570 2002-07-31 Martin Baulig <martin@gnome.org>
10572 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
10573 To get debugging messages, compile mcs with /define:MCS_DEBUG and
10574 then use this argument.
10576 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
10578 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
10579 use this to specify /define options.
10581 2002-07-29 Martin Baulig <martin@gnome.org>
10583 * statement.cs (Fixed): Moved all code that does variable lookups
10584 and resolvings from Emit to Resolve.
10586 * statement.cs (For): Moved all code that does variable lookups
10587 and resolvings from Emit to Resolve.
10589 * statement.cs (Using): Moved all code that does variable lookups
10590 and resolvings from Emit to Resolve.
10592 2002-07-29 Martin Baulig <martin@gnome.org>
10594 * attribute.cs (Attribute.Resolve): Explicitly catch a
10595 System.NullReferenceException when creating the
10596 CustromAttributeBuilder and report a different warning message.
10598 2002-07-29 Martin Baulig <martin@gnome.org>
10600 * support.cs (ParameterData.ParameterName): Added method to
10601 get the name of a parameter.
10603 * typemanager.cs (TypeManager.IsValueType): New public method.
10605 2002-07-29 Martin Baulig <martin@gnome.org>
10607 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
10608 is a flag which specifies that it's either ref or out.
10609 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
10610 the out parameter to `out Parameter.Modifier mod', also set the
10611 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
10613 * support.cs (InternalParameters.ParameterModifier): Distinguish
10614 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
10615 Parameter.Modifier.ISBYREF flag if it's either ref or out.
10617 * expression.cs (Argument.GetParameterModifier): Distinguish
10618 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
10619 Parameter.Modifier.ISBYREF flag if it's either ref or out.
10621 2002-07-29 Martin Baulig <martin@gnome.org>
10623 * expression.cs (ParameterReference.ParameterReference): Added
10624 `Location loc' argument to the constructor.
10626 * cs-parser.jay: Pass location to ParameterReference.
10628 2002-07-28 Miguel de Icaza <miguel@ximian.com>
10630 * statement.cs (Try): Initialize the location.
10632 * cs-parser.jay: pass location to Try.
10634 * expression.cs (Unary.Reduce): Change the prototype to return
10635 whether a constant fold could be performed or not. The result is
10636 returned in an out parameters. In the case of Indirection and
10637 AddressOf, we want to perform the full tests.
10639 2002-07-26 Miguel de Icaza <miguel@ximian.com>
10641 * statement.cs (Statement.Emit): Flag dead code.
10643 2002-07-27 Andrew Birkett <andy@nobugs.org>
10645 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
10647 2002-07-27 Martin Baulig <martin@gnome.org>
10649 * class.cs (MethodData.Define): Put back call to
10650 TypeManager.AddMethod(), accidentally commented this out.
10652 * report.cs (Debug): New public method to print debugging information,
10653 this is `[Conditional ("DEBUG")]'.
10655 2002-07-26 Martin Baulig <martin@gnome.org>
10657 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
10658 (switch_statement): Push the current_block to the switch_stack and
10659 pop it again when we're done with the switch.
10660 (switch_section): The new block is a child of the current_block.
10661 Fixes bug #24007, added test-152.cs.
10663 2002-07-27 Martin Baulig <martin@gnome.org>
10665 * expression.cs (Invocation.EmitArguments): When calling a varargs
10666 function with only its fixed arguments, we need to pass an empty
10669 2002-07-27 Martin Baulig <martin@gnome.org>
10671 Mono 0.13 has been released.
10673 2002-07-25 Miguel de Icaza <miguel@ximian.com>
10675 * driver.cs: Rename --resource to --linkres, because that is what
10676 we do currently, we dont support --resource yet.
10678 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
10680 2002-07-25 Martin Baulig <martin@gnome.org>
10682 * class.cs (MethodData): New public class. This is a `method builder'
10683 class for a method or one accessor of a Property/Indexer/Event.
10684 (MethodData.GetMethodFlags): Moved here from MemberBase.
10685 (MethodData.ApplyAttributes): Likewise.
10686 (MethodData.ApplyObsoleteAttribute): Likewise.
10687 (MethodData.ApplyConditionalAttribute): Likewise.
10688 (MethodData.ApplyDllImportAttribute): Likewise.
10689 (MethodData.CheckAbstractAndExternal): Likewise.
10690 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
10691 (MethodData.Emit): Formerly known as Method.Emit().
10692 (MemberBase): Moved everything which was specific to a single
10693 accessor/method to MethodData.
10694 (Method): Create a new MethodData and call Define() and Emit() on it.
10695 (Property, Indexer, Event): Create a new MethodData objects for each
10696 accessor and call Define() and Emit() on them.
10698 2002-07-25 Martin Baulig <martin@gnome.org>
10700 Made MethodCore derive from MemberBase to reuse the code from there.
10701 MemberBase now also checks for attributes.
10703 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
10704 (MemberBase.GetMethodFlags): Moved here from class Method and marked
10706 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
10707 `CallingConventions cc' and `Attributes opt_attrs' arguments.
10708 (MemberBase.ApplyAttributes): New virtual method; applies the
10709 attributes to a method or accessor.
10710 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
10711 (MemberBase.ApplyConditionalAttribute): Likewise.
10712 (MemberBase.ApplyDllImportAttribute): Likewise.
10713 (MemberBase.CheckAbstractAndExternal): Likewise.
10714 (MethodCore.ParameterTypes): This is now a property instead of a
10715 method, it's initialized from DoDefineParameters().
10716 (MethodCore.ParameterInfo): Removed the set accessor.
10717 (MethodCore.DoDefineParameters): New protected virtual method to
10718 initialize ParameterTypes and ParameterInfo.
10719 (Method.GetReturnType): We can now simply return the MemberType.
10720 (Method.GetMethodFlags): Override the MemberBase version and add
10721 the conditional flags.
10722 (Method.CheckBase): Moved some code from Define() here, call
10723 DoDefineParameters() here.
10724 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
10725 here to avoid some larger code duplication.
10726 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
10727 ensure that abstract and external accessors don't declare a body.
10729 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
10730 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
10731 lookup in the attribute's parent classes, so we need to abort as soon
10732 as we found the first match.
10733 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
10734 the attribute has no arguments.
10736 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
10739 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10741 * cs-parser.jay: reverted previous patch.
10743 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10745 * cs-parser.jay: fixed bug #22119.
10747 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10749 * attribute.cs: fixed compilation. The error was:
10750 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
10751 be assigned to before control leaves the current method."
10752 [FIXME: Filed as bug #28186: MCS must report this error.]
10754 2002-07-25 Martin Baulig <martin@gnome.org>
10756 * attribute.cs (Attribute.Conditional_GetConditionName): New static
10757 method to pull the condition name ouf of a Conditional attribute.
10758 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
10759 the obsolete message and error flag out of an Obsolete attribute.
10761 * class.cs (Method.GetMethodFlags): New public method to get the
10762 TypeManager.MethodFlags for this method.
10763 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
10765 (Method.Define): Get and apply the Obsolete and Conditional attributes;
10766 if we're overriding a virtual function, set the new private variable
10767 `parent_method'; call the new TypeManager.AddMethod().
10769 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
10770 the MethodBuilder and the Method in a PtrHashtable.
10771 (TypeManager.builder_to_method): Added for this purpose.
10772 (TypeManager.MethodFlags): Added IsObsoleteError.
10773 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
10774 Obsolete and Conditional arguments in MethodBuilders. If we discover
10775 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
10776 the message from the attribute.
10778 2002-07-24 Martin Baulig <martin@gnome.org>
10780 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
10781 preprocessor directives, ensure that the argument to #define/#undef is
10782 exactly one identifier and that it's actually an identifier.
10784 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
10787 2002-07-24 Martin Baulig <martin@gnome.org>
10789 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
10790 initialize it to TypeManager.object_type in the constructor.
10791 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
10792 of the `hm.get_current' method if we're using the collection pattern.
10793 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
10794 for the explicit conversion to make it work when we're using the collection
10795 pattern and the `Current' property has a different return type than `object'.
10798 2002-07-24 Martin Baulig <martin@gnome.org>
10800 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
10801 does not match, but don't report any errors. This method is called in
10802 order for all methods in a MethodGroupExpr until a matching method is
10803 found, so we don't want to bail out if the first method doesn't match.
10804 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
10805 matches, report the 123. Fixes #28070.
10807 2002-07-24 Martin Baulig <martin@gnome.org>
10809 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
10810 TypeManager.TypeToCoreType() to the top of the method so the
10811 following equality checks will work. Fixes #28107.
10813 2002-07-24 Martin Baulig <martin@gnome.org>
10815 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
10816 operand is of type uint, and the other operand is of type sbyte,
10817 short or int, the operands are converted to type long." -
10818 Actually do what this comment already told us. Fixes bug #28106,
10821 2002-07-24 Martin Baulig <martin@gnome.org>
10823 * class.cs (MethodBase): New abstract class. This is now a base
10824 class for Property, Indexer and Event to avoid some code duplication
10825 in their Define() and DefineMethods() methods.
10826 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
10827 generic methods for Define() and DefineMethods().
10828 (FieldBase): Derive from MemberBase, not MemberCore.
10829 (Property): Derive from MemberBase, not MemberCore.
10830 (Property.DefineMethod): Moved all the code from this method to the
10831 new MethodBase.DefineAccessor(), just call it with appropriate
10833 (Property.Define): Call the new Property.DoDefine(), this does some
10834 sanity checks and we don't need to duplicate the code everywhere.
10835 (Event): Derive from MemberBase, not MemberCore.
10836 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
10837 accessors, this will also make them work with interface events.
10838 (Indexer): Derive from MemberBase, not MemberCore.
10839 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
10840 (Indexer.Define): Use the new MethodBase functions.
10842 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
10843 argument to the constructor.
10844 (Interface.FindMembers): Added support for interface events.
10845 (Interface.PopluateEvent): Implemented.
10847 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
10849 2002-07-22 Miguel de Icaza <miguel@ximian.com>
10851 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
10852 but this is required to check for a method name being the same as
10853 the containing class.
10857 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10859 * interface.cs: initialize variable.
10861 2002-07-23 Martin Baulig <martin@gnome.org>
10863 Implemented the IndexerName attribute in interfaces.
10865 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
10866 name if this is an explicit interface implementation.
10867 (Indexer.InterfaceIndexerName): New public variable. If we're
10868 implementing an interface indexer, this is the IndexerName in that
10869 interface. Otherwise, it's the IndexerName.
10870 (Indexer.DefineMethod): If we're implementing interface indexer,
10871 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
10872 and Pending.ImplementIndexer methods.
10873 (Indexer.Define): Also define the PropertyBuilder if we're
10874 implementing an interface indexer and this is neither an explicit
10875 interface implementation nor do the IndexerName match the one in
10878 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
10879 If a method is defined here, then we always need to create a proxy
10880 for it. This is used when implementing interface indexers.
10881 (Pending.IsInterfaceIndexer): New public method.
10882 (Pending.ImplementIndexer): New public method.
10883 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
10884 This is used when implementing interface indexers to define a proxy
10886 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
10887 define a proxy if necessary.
10889 * interface.cs (Interface.IndexerName): New public variable.
10890 (Interface.PopulateIndexer): Set the IndexerName.
10891 (Interface.DefineIndexers): New private method. Populate all the
10892 indexers and make sure their IndexerNames match.
10894 * typemanager.cs (IndexerPropertyName): Added support for interface
10897 2002-07-22 Martin Baulig <martin@gnome.org>
10899 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
10900 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
10901 ret if HasReturnLabel.
10902 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
10905 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
10906 and set the ec.LoopBeginTryCatchLevel.
10907 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
10908 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
10909 the current ec.TryCatchLevel, the branch goes out of an exception
10910 block. In this case, we need to use Leave and not Br.
10912 2002-07-22 Martin Baulig <martin@gnome.org>
10914 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
10915 block unless the block does not always return or it is contained in
10916 another try { ... } catch { ... } block. Fixes bug #26506.
10917 Added verify-1.cs to the test suite.
10919 2002-07-22 Martin Baulig <martin@gnome.org>
10921 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
10922 then we do not always return. Fixes bug #24985.
10924 2002-07-22 Martin Baulig <martin@gnome.org>
10926 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
10927 lookup on a per-class level; ie. walk up the class hierarchy until we
10928 found at least one applicable method, then choose the best among them.
10929 Fixes bug #24463 and test-29.cs.
10931 2002-07-22 Martin Baulig <martin@gnome.org>
10933 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
10934 return types of the methods. The return type is not part of the
10935 signature and we must not check it to make the `new' modifier work.
10936 Fixes bug #27999, also added test-147.cs.
10937 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
10939 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
10940 on the method's return type.
10942 2002-07-21 Martin Baulig <martin@gnome.org>
10944 * assign.cs: Make this work if the rightmost source is a constant and
10945 we need to do an implicit type conversion. Also adding a few more tests
10946 to test-38.cs which should have caught this.
10948 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
10949 target in the makefile for this. The makefile.gnu is primarily intended
10950 for end-users who don't want to debug the compiler.
10952 2002-07-21 Martin Baulig <martin@gnome.org>
10954 * assign.cs: Improved the Assign class so it can now handle embedded
10955 assignments (X = Y = Z = something). As a side-effect this'll now also
10956 consume less local variables. test-38.cs now passes with MCS, added
10957 a few new test cases to that test.
10959 2002-07-20 Martin Baulig <martin@gnome.org>
10961 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
10962 instructions. Fixes bug #27977, also added test-146.cs.
10964 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10966 * cs-tokenizer.cs: fixed getHex ().
10968 2002-07-19 Martin Baulig <martin@gnome.org>
10970 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
10971 not Type.GetType() to lookup the array type. This is needed when
10972 we're constructing an array of a user-defined type.
10973 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
10974 single-dimensional arrays, but also for single-dimensial arrays of
10977 2002-07-19 Martin Baulig <martin@gnome.org>
10979 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
10980 this function is called, it's not allowed to share LocalBuilders
10981 among ILGenerators.
10983 2002-07-19 Martin Baulig <martin@gnome.org>
10985 * expression.cs (Argument.Resolve): Report an error 118 when trying
10986 to pass a type as argument.
10988 2002-07-18 Martin Baulig <martin@gnome.org>
10990 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
10991 Conv_R_Un for the signed `long' type.
10993 2002-07-15 Miguel de Icaza <miguel@ximian.com>
10995 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
10996 `expr' for the temporary result, as that will fail if we do
10997 multiple resolves on the same expression.
10999 2002-07-05 Miguel de Icaza <miguel@ximian.com>
11001 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
11002 ec.TypeContainer for looking up aliases.
11004 * class.cs (TypeContainer): Remove LookupAlias from here.
11006 * decl.cs (DeclSpace); Move here.
11008 2002-07-01 Miguel de Icaza <miguel@ximian.com>
11010 * class.cs (FindMembers): Only call filter if the constructor
11011 bulider is not null.
11013 Also handle delegates in `NestedTypes' now. Now we will perform
11014 type lookups using the standard resolution process. This also
11017 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
11018 This uses Expressions (the limited kind that can be parsed by the
11019 tree) instead of strings.
11021 * expression.cs (ComposedCast.ToString): Implement, used to flag
11022 errors since now we have to render expressions.
11024 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
11027 * ecore.cs (SimpleName.ToString): ditto.
11029 * cs-parser.jay: Instead of using strings to assemble types, use
11030 Expressions to assemble the type (using SimpleName, ComposedCast,
11031 MemberAccess). This should fix the type lookups in declarations,
11032 because we were using a different code path for this.
11034 * statement.cs (Block.Resolve): Continue processing statements
11035 even when there is an error.
11037 2002-07-17 Miguel de Icaza <miguel@ximian.com>
11039 * class.cs (Event.Define): Also remove the `remove' method from
11040 the list of pending items.
11042 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
11043 generate more compact code.
11045 2002-07-17 Martin Baulig <martin@gnome.org>
11047 * const.cs (Const.LookupConstantValue): Add support for constant
11048 `unchecked' and `checked' expressions.
11049 Also adding test case test-140.cs for this.
11051 2002-07-17 Martin Baulig <martin@gnome.org>
11053 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
11054 check whether mi.ReturnType implements the IEnumerator interface; the
11055 `==' and the IsAssignableFrom() will fail in this situation.
11057 2002-07-16 Ravi Pratap <ravi@ximian.com>
11059 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
11062 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11064 * expression.cs: fixed bug #27811.
11066 2002-07-14 Miguel de Icaza <miguel@ximian.com>
11068 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
11069 Molaro: when we are a ref, the value already contains a pointer
11070 value, do not take the address of it.
11072 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
11073 * removed mb-parser.jay and mb-tokenizer.cs
11075 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
11077 * expression.cs: check against the building corlib void type.
11079 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
11081 * ecore.cs: fix for valuetype static readonly fields: when
11082 initializing them, we need their address, not the address of a copy.
11084 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
11086 * typemanager.cs: register also enum_type in corlib.
11088 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
11090 * class.cs: allow calling this (but not base) initializers in structs.
11092 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
11094 * ecore.cs: make sure we compare against the building base types
11097 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
11099 * typemanager.cs: fix TypeToCoreType() to handle void and object
11100 (corlib gets no more typerefs after this change).
11102 2002-07-12 Miguel de Icaza <miguel@ximian.com>
11104 * expression.cs (ArrayCreation.EmitArrayArguments): use
11105 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
11107 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
11108 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
11109 array indexes, the runtime actually forbids them.
11111 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
11112 for array arguments here.
11114 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
11115 instead of the default for ValueTypes.
11117 (New.DoEmit): Use IsValueType instead of
11118 IsSubclassOf (value_type)
11119 (New.DoResolve): ditto.
11120 (Invocation.EmitCall): ditto.
11122 * assign.cs (Assign): ditto.
11124 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
11125 Statements *are* currently doing part of their resolution during
11128 Expressions do always resolve during resolve, but statements are
11129 only required to propagate resolution to their children.
11131 2002-07-11 Miguel de Icaza <miguel@ximian.com>
11133 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
11135 (LoadAssembly): Do not add the dll if it is already specified
11137 (MainDriver): Add the System directory to the link path at the end,
11138 after all the other -L arguments.
11140 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
11141 wrong opcode for loading bytes and bools (ldelem.i1 instead of
11142 ldelem.u1) and using the opposite for sbytes.
11144 This fixes Digger, and we can finally run it.
11146 * driver.cs (UnixParseOption): Move the option parsing here.
11147 (CSCParseOption): Implement CSC-like parsing of options.
11149 We now support both modes of operation, the old Unix way, and the
11150 new CSC-like way. This should help those who wanted to make cross
11151 platform makefiles.
11153 The only thing broken is that /r:, /reference: and /lib: are not
11154 implemented, because I want to make those have the same semantics
11155 as the CSC compiler has, and kill once and for all the confussion
11156 around this. Will be doing this tomorrow.
11158 * statement.cs (Unsafe.Resolve): The state is checked during
11159 resolve, not emit, so we have to set the flags for IsUnsfe here.
11161 2002-07-10 Miguel de Icaza <miguel@ximian.com>
11163 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
11164 not catch the Error_ObjectRefRequired in SimpleName (as it is
11165 possible to have a class/instance variable name that later gets
11166 deambiguated), we have to check this here.
11168 2002-07-10 Ravi Pratap <ravi@ximian.com>
11170 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
11171 make static and put into Expression.
11173 (Event.Define): Register the private field of the event with the
11174 TypeManager so that GetFieldFromEvent can get at it.
11176 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
11177 keep track of the private field associated with an event which
11180 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
11183 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
11185 2002-07-10 Miguel de Icaza <miguel@ximian.com>
11187 * expression.cs (Binary.EmitBranchable): this routine emits the
11188 Binary expression in a branchable context. This basically means:
11189 we need to branch somewhere, not just get the value on the stack.
11191 This works together with Statement.EmitBoolExpression.
11193 * statement.cs (Statement.EmitBoolExpression): Use
11196 2002-07-09 Miguel de Icaza <miguel@ximian.com>
11198 * statement.cs (For): Reduce the number of jumps in loops.
11200 (For): Implement loop inversion for the For statement.
11202 (Break): We can be breaking out of a Try/Catch controlled section
11203 (foreach might have an implicit try/catch clause), so we need to
11204 use Leave instead of Br.
11206 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
11207 now). If the instace expression supports IMemoryLocation, we use
11208 the AddressOf method from the IMemoryLocation to extract the
11209 address instead of emitting the instance.
11211 This showed up with `This', as we were emitting the instance
11212 always (Emit) instead of the Address of This. Particularly
11213 interesting when This is a value type, as we dont want the Emit
11214 effect (which was to load the object).
11216 2002-07-08 Miguel de Icaza <miguel@ximian.com>
11218 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
11220 * statement.cs (Checked): Set the CheckedState during the resolve
11221 process too, as the ConvCast operations track the checked state on
11222 the resolve process, and not emit.
11224 * cs-parser.jay (namespace_member_declaration): Flag that we have
11225 found a declaration when we do. This is used to flag error 1529
11227 * driver.cs: Report ok when we display the help only.
11229 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
11231 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
11233 2002-07-04 Miguel de Icaza <miguel@ximian.com>
11235 * cs-tokenizer.cs (define): We also have to track locally the
11236 defines. AllDefines is just used for the Conditional Attribute,
11237 but we also need the local defines for the current source code.
11239 2002-07-03 Miguel de Icaza <miguel@ximian.com>
11241 * statement.cs (While, For, Do): These loops can exit through a
11242 Break statement, use this information to tell whether the
11243 statement is the last piece of code.
11245 (Break): Flag that we break.
11247 * codegen.cs (EmitContexts): New `Breaks' state variable.
11249 2002-07-03 Martin Baulig <martin@gnome.org>
11251 * class.cs (TypeContainer.MethodModifiersValid): Allow override
11252 modifiers in method declarations in structs. Otherwise, you won't
11253 be able to override things like Object.Equals().
11255 2002-07-02 Miguel de Icaza <miguel@ximian.com>
11257 * class.cs (Method, Property, Indexer): Do not allow the public
11258 modifier to be used in explicit interface implementations.
11260 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
11261 override modifiers in method declarations in structs
11263 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
11265 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
11266 integer or real overflow, report an error
11268 2002-07-02 Martin Baulig <martin@gnome.org>
11270 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
11271 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
11272 to tell the runtime about our newly created System.Object and
11273 System.ValueType types.
11275 2002-07-02 Miguel de Icaza <miguel@ximian.com>
11277 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
11278 struct instead of Ldarg/Starg.
11280 2002-07-02 Martin Baulig <martin@gnome.org>
11282 * expression.cs (Indirection.Indirection): Call
11283 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
11285 2002-07-02 Martin Baulig <martin@gnome.org>
11287 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
11288 ValueType, call TypeManager.TypeToCoreType() on it.
11289 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
11290 the OpCodes.Newarr argument.
11292 2002-07-02 Martin Baulig <martin@gnome.org>
11294 * expression.cs (Invocation.EmitCall): When compiling corlib,
11295 replace all calls to the system's System.Array type to calls to
11296 the newly created one.
11298 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
11299 System.Array methods.
11300 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
11301 from the system's System.Array type which must be replaced.
11303 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
11305 * typemanager.cs: load unverifiable_code_ctor so we can build
11306 corlib using the correct type. Avoid using GetTypeCode() with
11308 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
11309 TypeManager.object_type to allow building corlib.
11311 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
11313 * ecore.cs: handle System.Enum separately in LoadFromPtr().
11315 2002-07-01 Martin Baulig <martin@gnome.org>
11317 * class.cs: Make the last change actually work, we need to check
11318 whether `ifaces != null' to avoid a crash.
11320 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
11322 * class.cs: when we build structs without fields that implement
11323 interfaces, we need to add the interfaces separately, since there is
11324 no API to both set the size and add the interfaces at type creation
11327 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
11329 * expression.cs: the dimension arguments to the array constructors
11330 need to be converted if they are a long.
11332 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
11334 * class.cs: don't emit ldarg.0 if there is no parent constructor
11335 (fixes showstopper for corlib).
11337 2002-06-29 Martin Baulig <martin@gnome.org>
11339 MCS now compiles corlib on GNU/Linux :-)
11341 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
11342 ie. check for MethodImplOptions.InternalCall.
11344 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
11345 and TypeManager.attribute_type are null, so we must explicitly check
11346 whether parent is not null to find out whether it's an attribute type.
11347 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
11348 and SetBuilder, not only if the property is neither abstract nor external.
11349 This is necessary to set the MethodImplOptions on the accessor methods.
11350 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
11351 SetBuilder, see Property.Emit().
11353 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
11354 populate "System.Object", "System.ValueType" and "System.Attribute" since
11355 they've already been populated from BootCorlib_PopulateCoreTypes().
11357 2002-06-29 Martin Baulig <martin@gnome.org>
11359 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
11360 is the NullLiteral, we also need to make sure that target_type is not
11363 2002-06-29 Martin Baulig <martin@gnome.org>
11365 * rootcontext.cs (RootContext.ResolveCore): We must initialize
11366 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
11367 before calling BootstrapCorlib_ResolveDelegate ().
11369 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11371 * statement.cs: fixed build-breaker. All tests passed ok.
11373 2002-06-27 Martin Baulig <martin@gnome.org>
11375 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
11376 for System.Decimal when compiling corlib.
11378 2002-06-27 Martin Baulig <martin@gnome.org>
11380 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
11381 switch blocks which contain nothing but a default clause.
11383 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
11385 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
11387 2002-06-27 Martin Baulig <martin@gnome.org>
11389 * ecore.cs (PropertyExpr.PropertyExpr): Call
11390 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
11392 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
11393 is already a TypeBuilder.
11395 2002-06-27 Martin Baulig <martin@gnome.org>
11397 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
11398 `target_type == TypeManager.array_type', not IsAssignableFrom() in
11399 the "from an array-type to System.Array" case. This makes it work
11400 when compiling corlib.
11402 2002-06-27 Martin Baulig <martin@gnome.org>
11404 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
11405 non-static PropertyExpr, set its InstanceExpression. This makes
11406 the `ICollection.Count' property work in System/Array.cs.
11408 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
11410 * driver.cs: Made error handling more consistent. Errors now
11411 tracked by Report class, so many methods which used to return int
11412 now return void. Main() now prints success/failure and
11413 errors/warnings message.
11415 Renamed '--probe' compiler argument to '--expect-error'. Removed
11416 the magic number return values (123 and 124). Now, if the
11417 expected error occurs, the compiler exits with success (exit value
11418 0). If the compilation completes without seeing that particular
11419 error, the compiler exits with failure (exit value 1). The
11420 makefile in mcs/errors has been changed to handle the new behaviour.
11422 * report.cs: Made 'expected error' number a property and renamed
11423 it from 'Probe' to 'ExpectedError'.
11425 * genericparser.cs: Removed error handling support, since it is
11426 now all done by Report class.
11428 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
11429 class, so parse() no longer returns an int.
11431 * namespace.cs: Use Report.Error instead of GenericParser.error
11433 2002-06-22 Miguel de Icaza <miguel@ximian.com>
11435 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
11436 TypeContainer.AddOperator): At the front of the list put the
11437 explicit implementations, so they get resolved/defined first.
11439 2002-06-21 Miguel de Icaza <miguel@ximian.com>
11441 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
11442 interface type is implemented by this TypeContainer. Used during
11443 explicit interface implementation.
11445 (Property.Define, Indexer.Define, Method.Define): Validate that
11446 the given interface in the explicit implementation is one of the
11447 base classes for the containing type.
11449 Also if we are explicitly implementing an interface, but there is
11450 no match in the pending implementation table, report an error.
11452 (Property.Define): Only define the property if we are
11453 not explicitly implementing a property from an interface. Use the
11454 correct name also for those properties (the same CSC uses,
11455 although that is really not needed).
11457 (Property.Emit): Do not emit attributes for explicitly implemented
11458 properties, as there is no TypeBuilder.
11460 (Indexer.Emit): ditto.
11462 Hiding then means that we do not really *implement* a pending
11463 implementation, which makes code fail.
11465 2002-06-22 Martin Baulig <martin@gnome.org>
11467 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
11468 the return value of Object.GetType(). [FIXME: we need to do this whenever
11469 we get a type back from the reflection library].
11471 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
11473 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
11475 2002-06-20 Miguel de Icaza <miguel@ximian.com>
11477 * attribute.cs: Return null if we can not look up the type.
11479 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
11480 the interface types found.
11482 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
11483 interface types found.
11485 * typemanager.cs (GetInterfaces): Make this routine returns alll
11486 the interfaces and work around the lame differences between
11487 System.Type and System.Reflection.Emit.TypeBuilder in the results
11488 result for GetInterfaces.
11490 (ExpandInterfaces): Given an array of interface types, expand and
11491 eliminate repeated ocurrences of an interface. This expands in
11492 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
11495 2002-06-21 Martin Baulig <martin@gnome.org>
11497 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
11500 2002-06-21 Martin Baulig <martin@gnome.org>
11502 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
11503 and called with one of the core types, return the corresponding typebuilder for
11506 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
11509 2002-06-21 Martin Baulig <martin@gnome.org>
11511 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
11512 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
11513 (Expression.ConvertReferenceExplicit): Likewise.
11515 * expression.cs (ElementAccess.DoResolve): Likewise.
11516 (ElementAccess.DoResolveLValue): Likewise.
11518 2002-06-10 Martin Baulig <martin@gnome.org>
11520 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
11521 add the "value" parameter to the parameter list.
11523 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
11526 2002-06-19 Miguel de Icaza <miguel@ximian.com>
11528 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
11529 the argument to an int, uint, long or ulong, per the spec. Also
11530 catch negative constants in array creation.
11532 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
11534 * class.cs: do not allow the same interface to appear twice in
11535 the definition list.
11537 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
11539 * ecore.cs: don't use ldlen with System.Array.
11541 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
11543 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
11545 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
11547 * modifiers.cs: produce correct field attributes for protected
11548 internal. Easy fix so miguel can work on ther harder stuff:-)
11550 2002-06-18 Miguel de Icaza <miguel@ximian.com>
11552 * pending.cs: New file. Move the code from class.cs here.
11553 Support clearning the pending flag for all methods (when not doing
11554 explicit interface implementation).
11556 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
11558 * rootcontext.cs: added a couple more types needed to bootstrap.
11560 2002-06-17 Miguel de Icaza <miguel@ximian.com>
11562 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
11563 constructor in the type, instead of any constructor in the type
11564 hierarchy. Thanks to Paolo for finding this bug (it showed up as
11565 a bug in the Mono runtime when applying the params attribute).
11567 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
11568 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
11570 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
11572 * expression.cs (Unary.ResolveOperator): Use TypeManager
11573 to resolve the type.
11575 2002-06-13 Ravi Pratap <ravi@ximian.com>
11577 * cs-parser.jay (enum_member_declaration): Pass in the attributes
11580 * enum.cs (AddEnumMember): Add support to store the attributes associated
11581 with each member too.
11583 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
11584 field builders too - this takes care of the enum member case.
11586 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
11588 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
11589 address-of operator on both value types and pointers.
11591 2002-06-10 Martin Baulig <martin@gnome.org>
11593 * interface.cs (Interface.PopulateIndexer): Add the indexer's
11594 PropertyBuilder to the `property_builders' list.
11596 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
11597 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
11598 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
11599 find any indexers which are inherited from an interface.
11601 2002-06-09 Martin Baulig <martin@gnome.org>
11603 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
11604 the same type as the constant if necessary. There's also a test-130.cs
11607 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
11609 * typemanager.cs (TypeManager.ChangeType): Previously known as
11610 Enum.ChangeEnumType().
11612 2002-06-09 Martin Baulig <martin@gnome.org>
11614 * expression.cs (Cast.TryReduce): Added support for consts.
11616 2002-06-08 Ravi Pratap <ravi@ximian.com>
11618 * class.cs (Accessor): Hold attributes information so we can pass
11621 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
11622 Modify to pass in attributes attached to the methods.
11624 (add_accessor_declaration, remove_accessor_declaration): Ditto.
11626 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
11627 to handle the Accessor kind :-)
11629 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
11631 2002-06-08 Martin Baulig <martin@gnome.org>
11633 * expression.cs (Unary.TryReduceNegative): Added support for
11636 2002-06-08 Martin Baulig <martin@gnome.org>
11638 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
11639 name can't be found in the `defined_names' - the caller will do a
11640 MemberLookup in this case and thus find methods in System.Enum
11641 such as Enum.IsDefined().
11643 2002-06-08 Martin Baulig <martin@gnome.org>
11645 * enum.cs (Enum.ChangeEnumType): This is a custom version of
11646 Convert.ChangeType() which works with TypeBuilder created types.
11647 (Enum.LookupEnumValue, Enum.Define): Use it here.
11649 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
11650 `TypeBuilder.BaseType != null' check.
11651 (TypeContainer.FindMembers): Only lookup parent members if we
11652 actually have a parent.
11653 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
11654 (ConstructorInitializer.Resolve): Likewise.
11656 * interface.cs (Interface.FindMembers): Added
11657 `TypeBuilder.BaseType != null' check.
11659 * rootcontext.cs (RootContext.ResolveCore): Added
11660 "System.Runtime.CompilerServices.IndexerNameAttribute" to
11661 classes_second_stage.
11663 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
11664 debug_type and trace_type when compiling with --nostdlib.
11666 2002-06-07 Martin Baulig <martin@gnome.org>
11668 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
11669 (AddField): Set it to true when adding a non-static field.
11670 (DefineType): Use `have_nonstatic_fields' to find out whether we
11671 have non-static fields, not `Fields != null'.
11673 2002-06-02 Miguel de Icaza <miguel@ximian.com>
11675 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
11676 dereferencing a null on the static-field code path)
11678 2002-05-30 Martin Baulig <martin@gnome.org>
11680 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
11681 to take command line arguments. Use reflection to call the new
11682 custom `Initialize' function on the symbol writer and pass it the
11683 command line arguments.
11685 * driver.cs (--debug-args): New command line argument to pass command
11686 line arguments to the symbol writer.
11688 2002-05-28 Miguel de Icaza <miguel@ximian.com>
11690 * assign.cs (DoResolve): Forgot to do the implicit conversion to
11691 the target type for indexers and properties. Thanks to Joe for
11694 2002-05-27 Miguel de Icaza <miguel@ximian.com>
11696 * typemanager.cs (MethodFlags): returns the method flags
11697 (Obsolete/ShouldIgnore) that control warning emission and whether
11698 the invocation should be made, or ignored.
11700 * expression.cs (Invocation.Emit): Remove previous hack, we should
11701 not do this on matching a base type, we should do this based on an attribute
11703 Only emit calls to System.Diagnostics.Debug and
11704 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
11705 on the command line.
11707 * rootcontext.cs: Global settings for tracing and debugging.
11709 * cs-tokenizer.cs (define): New utility function to track
11710 defines. Set the global settings for TRACE and DEBUG if found.
11712 2002-05-25 Ravi Pratap <ravi@ximian.com>
11714 * interface.cs (Populate*): Pass in the TypeContainer as well as
11715 the DeclSpace as parameters so that we can create EmitContexts and
11716 then use that to apply attributes etc.
11718 (PopulateMethod, PopulateEvent, PopulateProperty)
11719 (PopulateIndexer): Apply attributes everywhere.
11721 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
11724 (ApplyAttributes): Update accordingly.
11726 We now apply interface attributes for all members too.
11728 2002-05-26 Miguel de Icaza <miguel@ximian.com>
11730 * class.cs (Indexer.Define); Correctly check if we are explicit
11731 implementation (instead of checking the Name for a ".", we
11732 directly look up if the InterfaceType was specified).
11734 Delay the creation of the PropertyBuilder.
11736 Only create the PropertyBuilder if we are not an explicit
11737 interface implementation. This means that explicit interface
11738 implementation members do not participate in regular function
11739 lookups, and hence fixes another major ambiguity problem in
11740 overload resolution (that was the visible effect).
11742 (DefineMethod): Return whether we are doing an interface
11745 * typemanager.cs: Temporary hack until we get attributes in
11746 interfaces (Ravi is working on that) and we get IndexerName
11747 support in interfaces.
11749 * interface.cs: Register the indexers as properties.
11751 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
11752 warning, I have verified that this is a bug in the .NET runtime
11753 (JavaScript suffers of the same problem).
11755 * typemanager.cs (MemberLookup): When looking up members for
11756 interfaces, the parent of an interface is the implicit
11757 System.Object (so we succeed in searches of Object methods in an
11758 interface method invocation. Example: IEnumerable x; x.ToString
11761 2002-05-25 Miguel de Icaza <miguel@ximian.com>
11763 * class.cs (Event): Events should also register if they do
11764 implement the methods that an interface requires.
11766 * typemanager.cs (MemberLookup); use the new GetInterfaces
11769 (GetInterfaces): The code used to lookup interfaces for a type is
11770 used in more than one place, factor it here.
11772 * driver.cs: Track the errors at the bottom of the file, we kept
11775 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
11776 instance if the method we are calling is static!
11778 2002-05-24 Miguel de Icaza <miguel@ximian.com>
11780 * attribute.cs (ApplyAttributes): Make this function filter out
11781 the IndexerName attribute (as that attribute in reality is never
11782 applied) and return the string constant for the IndexerName
11785 * class.cs (TypeContainer.Emit): Validate that all the indexers
11786 have the same IndexerName attribute, and if so, set the
11787 DefaultName attribute on the class.
11789 * typemanager.cs: The return value might contain other stuff (not
11790 only methods). For instance, consider a method with an "Item"
11791 property and an Item method.
11793 * class.cs: If there is a problem with the parameter types,
11796 2002-05-24 Ravi Pratap <ravi@ximian.com>
11798 * ecore.cs (ImplicitConversionExists): Wrapper function which also
11799 looks at user defined conversion after making a call to
11800 StandardConversionExists - we need this for overload resolution.
11802 * expression.cs : Update accordingly the various method calls.
11804 This fixes 2 bugs filed against implicit user defined conversions
11806 2002-05-22 Miguel de Icaza <miguel@ximian.com>
11808 * statement.cs: Track the result of the assignment.
11810 2002-05-21 Miguel de Icaza <miguel@ximian.com>
11812 * expression.cs (MemberAccess): Improved error reporting for
11813 inaccessible members.
11815 2002-05-22 Martin Baulig <martin@gnome.org>
11817 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
11818 itself with debugging support.
11820 2002-05-22 Martin Baulig <martin@gnome.org>
11822 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
11823 Removed, this isn't needed anymore.
11825 2002-05-20 Martin Baulig <martin@gnome.org>
11827 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
11828 be underlying type for an enum.
11830 2002-05-20 Miguel de Icaza <miguel@ximian.com>
11832 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
11833 that splits out the loading of just the core types.
11835 * rootcontext.cs (ResolveCore): Split the struct resolution in
11836 two, so we can load the enumeration underlying types before any
11839 * expression.cs (Is): Bandaid until we fix properly Switch (see
11840 bug #24985 for details).
11842 * typemanager.cs (ImplementsInterface): The hashtable will contain
11843 a null if there are no interfaces implemented.
11845 2002-05-18 Miguel de Icaza <miguel@ximian.com>
11847 * cs-parser.jay (indexer_declarator): It is fine to have array
11850 2002-05-17 Miguel de Icaza <miguel@ximian.com>
11852 * typemanager.cs: (RegisterBuilder): New function used to register
11853 TypeBuilders that implement interfaces. Since
11854 TypeBuilder.GetInterfaces (as usual) does not work with lame
11856 (AddUserType): register interfaces.
11858 (ImplementsInterface): Use the builder_to_ifaces hash if we are
11859 dealing with TypeBuilder. Also, arrays are showing up as
11860 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
11861 methods can not be invoked on them!
11863 * ecore.cs (ExplicitReferenceConversionExists): Made public.
11864 (ImplicitReferenceConversionExists): Split out from
11865 StandardConversionExists.
11867 * expression.cs (As): We were only implementing one of the three
11868 cases for the as operator. We now implement them all.
11869 (Is): Implement the various other cases for Is as well.
11871 * typemanager.cs (CACHE): New define used to control if we want or
11872 not the FindMembers cache. Seems to have a negative impact on
11873 performance currently
11875 (MemberLookup): Nested types have full acess to
11876 enclosing type members
11878 Remove code that coped with instance/static returns for events, we
11879 now catch this in RealFindMembers.
11881 (RealFindMembers): only perform static lookup if the instance
11882 lookup did not return a type or an event.
11884 2002-05-17 Miguel de Icaza <miguel@ximian.com>
11886 * assign.cs (CompoundAssign): We pass more semantic information
11887 now to Compound Assignments than we did before: now we have all
11888 the information at hand, and now we resolve the target *before* we
11889 do the expression expansion, which allows the "CacheValue" method
11890 to have the effect we intended (before, a [x] += 1 would generate
11891 two differen ArrayAccess expressions from the ElementAccess,
11892 during the resolution process).
11894 (CompoundAssign.DoResolve): Resolve target and original_source here.
11896 2002-05-16 Miguel de Icaza <miguel@ximian.com>
11898 * expression.cs (ArrayAccess): dropped debugging information.
11900 * typemanager.cs: Small bug fix: I was always returning i_members,
11901 instead of one of i_members or s_members (depending on which had
11904 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
11905 method is invoked before any code generation takes place, and it
11906 is a mechanism to inform that the expression will be invoked more
11907 than once, and that the method should use temporary values to
11908 avoid having side effects
11910 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
11912 * ecore.cs (Expression.CacheTemporaries): Provide empty default
11915 * expression.cs (Indirection, ArrayAccess): Add support for
11916 CacheTemporaries in these two bad boys.
11918 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
11919 ldobj or ldind_ref.
11920 (StoreFromPtr): Handle stobj as well.
11922 * expression.cs (UnaryMutator): Share more code.
11924 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
11925 down: I was not tracking the Filter function as well, which
11926 was affecting the results of the cache.
11928 2002-05-15 Miguel de Icaza <miguel@ximian.com>
11930 * attribute.cs: Remove the hack to handle the CharSet property on
11933 2002-05-14 Miguel de Icaza <miguel@ximian.com>
11935 * attribute.cs (DoResolve): More uglyness, we now only try to
11936 resolve the attribute partially, to extract the CharSet
11937 information (only if we are a StructLayout attribute). Otherwise
11939 (GetExtraTypeInfo): Add some code to conditionally kill in the
11940 future this. I am more and more convinced that the .NET
11941 framework has special code to handle the attribute setting on
11944 * expression.cs (IsParamsMethodApplicable): Revert my previous
11945 foreach change here, it was wrong.
11947 2002-05-13 Miguel de Icaza <miguel@ximian.com>
11949 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
11950 (pp_expr): do not abort on unknown input, just return.
11951 (eval): abort if there are pending chars.
11953 * attribute.cs (Attribute.Resolve): Positional parameters are
11954 optional. Deal with that case.
11956 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
11957 the Ansi/Unicode/Auto information for the type.
11959 (TypeContainer.DefineType): instantiate the EmitContext here, as
11960 we will be using it during the type definition (to resolve
11961 attributes) and during the emit phase.
11963 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
11964 to pull type information out of the attributes
11966 (Attribute.Resolve): track the constructor builder, and allow for
11967 multiple invocations (structs and classes will use this).
11969 * ecore.cs (MemberLookupFinal): new version with all the
11970 parameters customizable.
11972 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
11973 constructors. Return if the result value is null (as the error
11974 would have been flagged already by MemberLookupFinal)
11976 Do not allow instances of abstract classes or interfaces to be
11979 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
11980 We have to compare the assembly property here when dealing with
11981 FamANDAssem and Assembly access modifiers, because we might be
11982 creating an assembly from *modules* (that means that we are not
11983 getting TypeBuilders for types defined in other modules that are
11984 part of this assembly).
11986 (Method.Emit): If the method is marked abstract and has a body,
11989 (TypeContainer.DefineMembers): If both the defined member and the
11990 parent name match are methods, then do not emit any warnings: let
11991 the Method.Define routine take care of flagging warnings. But if
11992 there is a mismatch (method overrides something else, or method is
11993 overriwritten by something, then emit warning).
11995 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
11996 set to null, this means `do not check for the return type on the
11999 (Method.Define): set the return type for the method signature to
12000 null, so that we get methods with the same name and parameters and
12001 different return types. This is used to flag warning 114 (you are
12002 hiding a method, and you probably want to use the new/override
12005 * typemanager.cs (MemberLookup): Implemented proper access
12006 control, closing a long standing set of bug reports. The problem
12007 was that the Framework only has two bits: Public and NonPublic,
12008 and NonPublic includes private and protected methods, but we need
12009 to enforce the FamANDAssem, FamOrAssem and Family.
12011 2002-05-11 Miguel de Icaza <miguel@ximian.com>
12013 * statement.cs (GotoCase): Return true: Ammounts to giving up
12014 knowledge on whether we return or not, and letting the other case
12015 be responsible for it.
12017 2002-05-10 Miguel de Icaza <miguel@ximian.com>
12019 * driver.cs: Do not load directories for each file processed, only
12020 do it if there is a pattern.
12022 * ecore.cs: Report readonly assigns here as well, as we might have
12023 been resolved only by MemberAccess.
12025 (SimpleName.SimpleNameResolve): Also be useful for LValue
12026 resolution. We need this to propagate assign to local readonly variables
12028 * typemanager.cs: Use a ptrhashtable for the criteria, because we
12029 do not want to reuse potential criteria memory.
12031 * class.cs (MyEventBuilder): Set reflected_type;
12033 * ecore.cs (Constantify): Added support for constifying bools.
12035 (RootContext.LookupType): Added a cache for values looked up in
12036 the declaration space.
12038 * typemanager.cs (FindMembers): Now is a front-end to
12039 RealFindMembers, and provides a two-level hashtable-based cache to
12042 15% performance improvement: from 22.5 to 19.2 seconds.
12044 * expression.cs (IsParamsMethodApplicable): use foreach.
12045 (Invocation.DoResolve): ditto.
12046 (New.DoResolve): ditto.
12047 (ArrayCreation.DoResolve): ditto.
12049 * ecore.cs (FindMostEncompassingType): use foreach.
12051 * delegate.cs (NewDelegate.DoResolve): Use foreach
12053 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
12054 (RemoveMethods): use foreach.
12056 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
12057 nested foreach statements instead of for, and also break out of
12058 the inner loop once a match is found.
12060 (Invocation.OverloadResolve): Use foreach, simplify the code.
12062 2002-05-08 Miguel de Icaza <miguel@ximian.com>
12064 * cfold.cs (BinaryFold): During an enumeration evaluation context,
12065 we actually unwrap the expression to allow for extra information
12068 * expression.cs: Use Shr_Un on unsigned operations.
12070 2002-05-08 Ravi Pratap <ravi@ximian.com>
12072 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
12073 applicable operators was not being considered correctly. This closes
12074 the bug Miguel reported.
12076 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
12078 * attribute.cs: check that the type derives from System.Attribute
12079 and report the correct error in that case (moved the duplicate code to
12080 its own method, too).
12082 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
12084 * attribute.cs: lookup attribute type name as the spec says: first the
12085 bare attribute name and then name + "Attribute" (nant compiles with
12086 mcs after this fix).
12088 2002-05-07 Miguel de Icaza <miguel@ximian.com>
12090 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
12091 Because of the way we parse things, we should try to see if a
12092 UIntConstant can fit in an integer.
12094 2002-05-07 Ravi Pratap <ravi@ximian.com>
12096 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
12097 when we are in an explicit context.
12099 (ConvertReferenceExplicit): When converting from Iface type S to Class
12100 T make sure the rules are implemented as an OR.
12102 * parameter.cs (ParameterType): Make it a property for now although the
12103 purpose really isn't anything immediate.
12105 * expression.cs (Is*Applicable): Do better checking on the parameter type
12106 of a ref/out parameter. The ones from the system assemblies are already
12107 marked with the correct type so we don't need to do any correction.
12109 * ecore.cs (StandardConversionExists): Conversion from Interface types to
12110 the object type is standard too so include that.
12112 2002-05-06 Miguel de Icaza <miguel@ximian.com>
12114 * ecore.cs (StandardConversionExists): Augment with missing code:
12115 deal with IntConstant, LongConstants and Enumerations.
12117 * assign.cs: Report the error, instead of failing silently
12119 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
12120 typecontainer that they are declared, because the
12121 typecontainer/namespace will have the list of using clauses that
12122 need to be applied.
12124 Assembly Attributes were escaping the normal registration
12127 (EmitCode): Apply attributes within an EmitContext that represents
12128 the container they were declared on.
12130 * cs-parser.jay: Track bases for structs. How did I get this wrong?
12132 2002-05-06 Ravi Pratap <ravi@ximian.com>
12134 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
12135 Revamp completely - make much cleaner as we now operate only
12138 (FindMostSpecificSource, FindMostSpecificTarget): New methods
12139 to implement the logic detailed in the spec more correctly.
12141 (UserDefinedConversion): Update accordingly.
12143 2002-05-06 Miguel de Icaza <miguel@ximian.com>
12145 * statement.cs: Return flow analysis information up.
12147 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
12150 (token): Do not consume an extra character before calling
12153 2002-05-06 Piers Haken <piersh@friskit.com>
12155 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
12157 2002-05-06 Miguel de Icaza <miguel@ximian.com>
12159 * class.cs (Constructor.Emit): Set the IsStatic flag in the
12160 EmitContext during the instance constructor initializer
12161 resolution, to stop access to instance variables.
12163 This is mandated by the spec, last paragraph of the `constructor
12164 initializers' section.
12166 2002-05-05 Miguel de Icaza <miguel@ximian.com>
12168 * cs-parser.jay, class.cs (Accessor): new class used to represent
12169 an accessor (get or set). In the past we used `null' to represent
12170 a missing accessor. But this is ambiguous because there was no
12171 way to tell in abstract indexers/properties if one of them was
12174 Now there is a way of addressing that.
12176 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
12177 instead of FindMembers.
12179 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
12180 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
12182 * attribute.cs: Treat indexers and properties as the same in terms
12183 of applying attributes
12185 * ecore.cs (FindMostEncompassedType): Use statically initialized
12186 EmptyExpressions()s like we do elsewhere to avoid creating useless
12187 objects (and we take this out of the tight loop).
12189 (GetConversionOperators): Move the code to extract the actual
12190 operators to a separate routine to clean things up.
12192 2002-05-04 Miguel de Icaza <miguel@ximian.com>
12194 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
12195 events are always registered FieldBuilders.
12197 * class.cs (FieldBase): New class shared by Fields
12199 * delegate.cs: If we are a toplevel delegate, use our full name.
12200 If we are a nested delegate, then only use our tail name.
12202 2002-05-02 Ravi Pratap <ravi@ximian.com>
12204 * expression.cs (IsApplicable): Ensure that we add the "&" to
12205 ref/out types before comparing it with the type of the argument.
12207 (IsParamsMethodApplicable): Ditto.
12209 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
12212 * delegate.cs : Handle the case when we have more than one applicable
12213 method. Flag an error only when we finish checking all.
12215 2002-05-02 Miguel de Icaza <miguel@ximian.com>
12217 * expression.cs: Add support for boolean static initializers.
12219 2002-05-01 Miguel de Icaza <miguel@ximian.com>
12221 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
12223 * parameter.cs (ComputeParameterTypes,
12224 ComputeAndDefineParameterTypes): Better error handling: now we
12225 clear the `types' cache if we fail during any of the type lookups.
12226 We also return the status code correctly to our caller
12228 * delegate.cs: If we fail to define a delegate, abort the extra
12231 * expression.cs (Binary.ResolveOperator): for
12232 operator==(object,object) and operator !=(object, object) we also
12233 have to verify that there is an implicit conversion from one to
12236 (ArrayAccess.DoResolve): Array Access can operate on
12239 2002-04-30 Miguel de Icaza <miguel@ximian.com>
12241 * assign.cs (CompoundAssign): A new class used as a "flag" that
12242 the assignment actually is happening as part of a compound
12243 assignment operator.
12245 During compound assignment, a few new rules exist to enable things
12252 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
12253 to the type of x) if y is implicitly convertible to the type of x,
12254 and the operator is a builtin operator and the return type of the
12255 operator is explicitly convertible to the type of x.
12257 * rootcontext.cs: Reset warning level to 2. 4 catches various
12258 "interesting" features in mcs, we must clean this up at some
12259 point, but currently am trying to kill other bugs ;-)
12261 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
12262 in container classes as well.
12264 * expression.cs (Binary.ResolveOperator): Handle string case
12265 before anything else (as operator overloading does emit an error
12266 before doing anything else).
12268 This code could go away when we move to a table driven model, but
12269 i could not come up with a good plan last night.
12271 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
12273 * typemanager.cs (CSharpName): reimplementation using regex.
12274 * class.cs: added null check for fields in Emit
12275 * rootcontext.cs: set warninglevel to 4
12277 2002-04-29 Miguel de Icaza <miguel@ximian.com>
12279 * typemanager.cs (CSharpName): reimplemented with Lupus
12282 2002-04-28 Miguel de Icaza <miguel@ximian.com>
12284 * statement.cs (If): correclty implement Resolve, because we were
12285 not catching sem errors in there. The same process is needed
12287 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
12290 (Statement.Warning_DeadCodeFound): Factorize code.
12291 (While): Report dead code here too.
12293 (Statement): Added Resolve virtual method to allow
12294 for resolution split from the emit code.
12296 2002-04-26 Miguel de Icaza <miguel@ximian.com>
12298 * statement.cs (EmitBoolExpression): No longer try to resolve the
12300 (MakeBoolean): New utility function that resolve, implicitly
12301 converts to boolean and tags the expression.
12304 (If, Do): Implement dead code elimination.
12305 (While): Implement loop inversion
12307 (Do, While, For, If): Resolve the expression prior to calling our
12310 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
12313 - added method Report28 (warning: program has more than one entry point)
12314 - added method IsEntryPoint, implements paragraph 10.1 of the spec
12315 - modified method Method.Define, the part at the end of the method
12317 * rootcontext.cs: added static public Location EntryPointLocation;
12319 * ../errors/cs0028.cs : Add test case for the above warning.
12322 - modified method CSharpName to allow arrays of primitive type to
12323 be printed nicely (e.g. instead of System.Int32[][] it now prints
12325 - added method CSharpSignature: returns the signature of a method
12326 in string format to be used in reporting errors, warnings, etc.
12328 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
12331 2002-04-26 Ravi Pratap <ravi@ximian.com>
12333 * delegate.cs (Define): Fix extremely silly bug where I was
12334 setting the type of the 'object' parameter of the BeginInvoke
12335 method to System.IAsyncResult instead of System.Object ;-)
12337 2002-04-26 Miguel de Icaza <miguel@ximian.com>
12339 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
12342 (Constructor.Emit): return if we fail to initialize the
12343 constructor. Another door closed!
12345 * expression.cs (New.DoResolve): Improve error message (from -6 to
12346 1501). Use DeclaredOnly lookup to find the exact constructor.
12348 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
12349 loop. This is useful.
12351 * cs-parser.jay: Adjust the default parameters so that destructors
12352 have the proper signature.
12354 2002-04-26 Martin Baulig <martin@gnome.org>
12356 * driver.cs (LoadAssembly): If `assembly' contains any characters
12357 which are only valid in path names and not in assembly names
12358 (currently slash, backslash and point), use Assembly.LoadFrom ()
12359 instead of Assembly.Load () on the `assembly' (before iteration
12360 over the link_paths).
12362 2002-04-26 Martin Baulig <martin@gnome.org>
12364 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
12366 2002-04-25 Miguel de Icaza <miguel@ximian.com>
12368 * class.cs (Property): use the new typemanager.MemberLookup
12370 (TypeContainer.MemberLookup): Implement using the
12371 TypeManager.MemberLookup now.
12373 * typemanager.cs: Make MemberLookup a function of the TypeManager,
12374 and return MemberInfos, so that these can be used without an
12375 EmitContext (what we had before).
12377 2002-04-24 Miguel de Icaza <miguel@ximian.com>
12379 * expression.cs: Fix the case where the argument to params if the
12380 type of the params. I omitted handling this before. Fixed
12382 2002-04-22 Miguel de Icaza <miguel@ximian.com>
12384 * driver.cs: Call BootCorlib_PopulateCoreType
12386 * class.cs (Property.CheckBase): Check for properties only, not
12389 * interface.cs: Temporary hack: try/catch around the
12390 CustomAttributeBuilder, because I am getting an exception that I
12393 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
12394 types whose definitions are required to be there (attributes are
12395 defined before standard types).
12397 Compute definitions as we boot the various types, as they are used
12398 immediately (value_type class will need object_type, but if we do
12399 not initialize object_type, we will pass a null, which will let
12400 the runtime pick the System.Object from the existing corlib, which
12401 is not what we want).
12403 2002-04-22 Patrik Torstensson <totte@labs2.com>
12405 * cs-tokenizer.cs: fixed a number of trim() issues.
12407 2002-04-22 Ravi Pratap <ravi@ximian.com>
12409 * expression.cs (Argument.Type): Ensure that we return the correct
12410 type when we have out or ref parameters [in which case we
12413 2002-04-22 Miguel de Icaza <miguel@ximian.com>
12415 * class.cs (Property, Indexer): Allow extern modifier in there.
12417 * typemanager.cs (InitBaseTypes): Initializes object_type and
12418 value_type, since those will be used early on during the bootstrap
12419 process to compile corlib.
12421 (InitCoreTypes): Move code from here to InitBaseTypes.
12423 2002-04-21 Miguel de Icaza <miguel@ximian.com>
12425 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
12426 single-dimension arrays as using the ldlen opcode.
12428 Daniel Lewis discovered this optimization.
12430 * typemanager.cs: Add signature for System.Array::get_Length
12432 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
12434 * statement.cs: report the error when the foreach does not apply to an
12435 array nor a collection.
12437 2002-04-19 Miguel de Icaza <miguel@ximian.com>
12439 * expression.cs: Add implicit conversions to the operator ~.
12441 * constant.cs (DecimalConstant.Emit): Emit decimal value.
12443 * typemanager.cs: Locate the decimal constructor.
12445 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
12447 * attribute.cs: use the new property of TypeOf.
12448 * expression.cs: added 'get' property around typearg.
12450 These changes fix a build breaker reported by NickD. Is this the
12451 correct way to fix? If not, please, revert my changes and make it
12454 2002-04-17 Miguel de Icaza <miguel@ximian.com>
12456 * attribute.cs: Add support for typeof in attribute invocations.
12457 I am not sure that this is right though.
12459 2002-04-14 Duncan Mak <duncan@ximian.com>
12461 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
12462 Binary.Operator.Division case.
12464 2002-04-13 Ravi Pratap <ravi@ximian.com>
12466 * class.cs (DefineType): Ensure that we do a proper check on
12467 attribute types and also register it with the TypeManager.
12469 (TypeContainer.Targets): The default for attribute types is
12470 AttributeTargets.All.
12472 * attribute.cs (ApplyAttributes): Registering the attribute type
12473 is done elsewhere, not when we discover we have a Usage attribute.
12475 2002-04-12 Ravi Pratap <ravi@ximian.com>
12477 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
12478 and get rid of is_delegate parameter.
12480 * everywhere : update.
12482 2002-04-12 Ravi Pratap <ravi@ximian.com>
12484 * cs-parser.jay (compilation_unit): Revamp completely to use
12485 some new ideas that I got from Rhys' grammar to solve the problems
12486 with assembly level attributes.
12488 (outer_declaration): New grammar production.
12490 (attribute_sections): Add.
12492 (opt_attributes): Base on attribute_sections
12494 (namespace_declaration): Allow opt_attributes to tackle the case
12495 when we have assembly level attributes - we are clever in this
12498 * attribute.cs (ApplyAttributes): Do not worry about assembly
12499 attributes in the non-global context.
12501 * rootcontext.cs (AddGlobalAttributes): Go back to using this
12502 instead of SetGlobalAttributes.
12504 * class.cs, rootcontext.cs : Ensure we define and generate
12505 attribute types before anything else.
12507 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
12508 and flag the new error -20 for the case when the attribute type
12509 does not have valid targets specified. csc does not catch this.
12511 * ../errors/errors.txt : update for error # -20
12513 2002-04-11 Ravi Pratap <ravi@ximian.com>
12515 * support.cs (InternalParameters.ParameterModifier): Do some null
12516 checking and return sane values.
12518 * class.cs (Method.Define): If we are a PInvoke method, ensure
12519 that we are static and extern. Report error # 601
12521 * ../errors/cs0601.cs : Add test case for the above error.
12523 2002-04-07 Ravi Pratap <ravi@ximian.com>
12525 * rootcontext.cs (attribute_types): We need to keep type of
12526 all attribute types separately and emit code for them first.
12528 (RegisterAttribute) : Implement.
12530 * class.cs (DefineType): Check if the current Type is a custom
12531 attribute type and register it accordingly.
12533 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
12534 adding the first attribute twice and rename to
12536 (SetGlobalAttributes): this.
12538 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
12541 * attribute.cs (ApplyAttributes): Take an additional argument telling us
12542 if we are processing global arguments. Hmm, I am unsure of this.
12544 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
12546 * expression.cs: added static array of strings to avoid calling
12547 Enum.ToString () for Operator in Binary. Significant recover of
12550 2002-04-10 Miguel de Icaza <miguel@ximian.com>
12552 * class.cs (FindMembers): Allow the Builders of the various
12553 members to be null. If they are skip them. This only happens
12554 during the PInvoke declaration.
12556 2002-04-09 Miguel de Icaza <miguel@ximian.com>
12558 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
12559 failure, so we do not keep going afterwards.
12561 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
12562 wanted to pass `false' as the `is_delegate' argument. If this is
12563 the case, why not use delegate_type == null to mean `is_delegate =
12564 false' and anything else as is_delegate = true.
12566 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
12568 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
12569 code for the section, not the beginning of the tests.
12571 2002-04-08 Miguel de Icaza <miguel@ximian.com>
12573 * cfold.cs: Handle operator + (Enum x, Underlying x)
12575 * expression.cs (Binary): same. Warn about errors where we have
12576 Enum/Enum in operator + as well.
12578 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
12581 - added support for switch(bool)
12582 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
12583 - add TableSwitchEmit() to handle table-based switch statements
12585 2002-04-05 Ravi Pratap <ravi@ximian.com>
12587 * expression.cs (Invocation.OverloadResolve): Factor out code which
12588 does parameter compatibility checking with arguments so that we can
12589 re-use the code even from Delegate.VerifyApplicability
12591 (VerifyArgumentsCompat): Move above code here.
12593 * delegate.cs (VerifyApplicability): Get rid of duplicate code
12594 and instead make a call to the above method.
12596 2002-03-31 Ravi Pratap <ravi@ximian.com>
12598 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
12599 We use it to keep track of classes which are attribute types.
12601 2002-04-02 Miguel de Icaza <miguel@ximian.com>
12603 * delegate.cs (Delegate.Define): Correctly define the types in the
12604 presence of fixed and array parameters.
12606 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
12609 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
12610 include NonPublic after the first iteration.
12612 * class.cs (Indexer.CheckBase): Only check if both parents are
12615 * cs-parser.jay (accessor_body): If empty, set to null.
12617 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
12618 same code path here to resolve constants names that we did have in
12619 MemberAccess.DoResolve. There is too much code duplicated here.
12621 2002-04-01 Miguel de Icaza <miguel@ximian.com>
12623 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
12625 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
12628 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
12629 tokens, numbers and strings.
12631 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
12634 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
12635 asyncronous parameters and the regular parameters.
12637 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
12638 specify the target directory.
12640 * expression.cs: (This.DoResolve): Simplify
12641 (As.Emit): Optimize, do not generate IsInst if the expression is
12642 always of the given type.
12644 (Is.DoResolve): Bug fix, we were reporting both always/never for
12647 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
12648 creating too many unnecessary arrays.
12650 2002-03-31 Miguel de Icaza <miguel@ximian.com>
12652 * class.cs (EmitFieldInitializer): Use Assign expression to assign
12653 fields instead of rolling our own initializer. Takes care of all
12654 implicit conversions, and drops unnecessary static checks/argument.
12656 2002-03-31 Dick Porter <dick@ximian.com>
12658 * driver.cs: use the GetDirectories() return values properly, and
12659 use "/" as path separator.
12661 2002-03-30 Miguel de Icaza <miguel@ximian.com>
12663 * expression.cs (Unary): Optimize - - expr into expr.
12664 (Binary): Optimize a + (-b) into a -b.
12666 * codegen.cs (CodeGen): Made all methods static.
12668 2002-03-29 Miguel de Icaza <miguel@ximian.com>
12672 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
12673 TypeBuilder property.
12675 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
12678 * tree.cs: Removed the various RecordXXXX, and replaced with a
12679 single RecordDecl. Removed all the accessor methods, and just
12680 left a single access point Type
12682 * enum.cs: Rename DefineEnum to DefineType.
12684 * decl.cs: New abstract method `DefineType' used to unify the
12685 Defines for Enumerations, Interfaces, TypeContainers and
12688 (FindType): Moved LookupInterfaceOrClass here. Moved the
12689 LookupBaseClasses method that used to live in class.cs and
12690 interface.cs here, and renamed to FindType.
12692 * delegate.cs: Implement DefineType. Take advantage of the
12693 refactored pattern for locating the parent builder without taking
12694 the parent_builder argument (which we know does not work if we are
12695 nested, and triggering a toplevel definition).
12697 2002-03-28 Miguel de Icaza <miguel@ximian.com>
12699 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
12700 accessibility of a member has changed during override and report
12703 * class.cs (Method.Define, Property.Define): Only complain on
12704 overrides if the method is private, any other accessibility is
12705 fine (and since we just checked the permission is the same, we are
12708 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
12709 and elif are processed always. The other pre-processing
12710 directives are only processed if we are "taking" the path
12712 2002-03-29 Martin Baulig <martin@gnome.org>
12714 * class.cs (Method.Emit): Only emit symbolic debugging info if the
12715 current location is not Null.
12717 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
12718 a separate method so we can profile it.
12720 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
12721 `span.Seconds' are just seconds, but no minutes or hours.
12722 (MainDriver): Profile the CodeGen.SaveSymbols calls.
12724 2002-03-28 Miguel de Icaza <miguel@ximian.com>
12726 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
12727 Remove the gratuitous set of Final:
12729 // If an interface implementation, then we can set Final.
12730 if (((flags & MethodAttributes.Abstract) == 0) &&
12731 implementing.DeclaringType.IsInterface)
12732 flags |= MethodAttributes.Final;
12734 I do not know what I was smoking when I used that.
12737 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
12738 step into fixing the name resolution issues for delegates and
12739 unifying the toplevel name resolution.
12741 2002-03-28 Martin Baulig <martin@gnome.org>
12743 * class.cs (Method.Emit): If we have a symbol writer, call its
12744 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
12745 tell it about the current method.
12747 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
12748 writer that we're going to emit the first byte of IL code for a new
12749 statement (a new source line).
12750 (EmitContext.EmitTopBlock): If we have a symbol writer, call
12751 EmitContext.Mark() before emitting any code.
12753 * location.cs (SymbolDocument): Return null when we're Null.
12755 * statement.cs (Statement): Moved the `Location loc' variable here.
12756 (Statement.EmitBoolExpression): If we have a symbol writer, call
12757 ec.Mark() before emitting any code to tell it that we're at the
12758 beginning of a new statement.
12759 (StatementExpression): Added `Location' argument to the constructor.
12760 (Block): Added public readonly variable `StartLocation' and public
12761 variable `EndLocation'. The latter is to be set using SetEndLocation().
12762 (Block): Added constructor which takes a start and end location.
12763 (Block.SetEndLocation): New method. This sets the end location.
12764 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
12765 local variables we create.
12766 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
12767 each statement and do also mark the begin and end of the block.
12769 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
12770 tell it the current lexer.Location, use Location.Null for the end of the
12772 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
12773 current block, set its end location using SetEndLocation().
12774 (statement_expression): StatementExpression constructor now takes the
12775 lexer.Location as additional argument.
12776 (for_statement, declare_local_variables): Likewise.
12777 (declare_local_variables): When creating a new implicit block, use the
12778 new Block constructor and pass it the lexer.Location.
12780 2002-03-28 Miguel de Icaza <miguel@ximian.com>
12782 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
12783 members also on the parent interfaces recursively.
12785 2002-03-27 Miguel de Icaza <miguel@ximian.com>
12787 * report.cs: Use new formats, since Gonzalo finished the missing
12790 * expression.cs (Binary.ResolveOperator): added missing operator|
12791 operator& and operator^ for bool/bool.
12793 * cs-parser.jay: CheckDef now takes a Location argument that is
12794 used to report errors more precisly (instead of reporting the end
12795 of a definition, we try to track something which is a lot closer
12796 to the source of the problem).
12798 * cs-tokenizer.cs: Track global token use, so we can properly flag
12799 the use of #define/#undef after the first token has been seen.
12801 Also, rename the reportXXXX to Error_DescriptiveName
12803 * decl.cs (DeclSpace.IsTopLevel): Move property here from
12804 TypeContainer, so that Enum and Interface can use this too.
12806 * class.cs (TypeContainer.LookupInterfaceOrClass,
12807 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
12808 `builder' argument. Typically this was used to pass the parent
12809 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
12812 The problem is that a nested class could trigger the definition of
12813 a toplevel class, and the builder would be obviously wrong in that
12816 So we drop this argument, and we compute dynamically the
12817 TypeBuilder/ModuleBuilder (the correct information was available
12818 to us anyways from DeclSpace.Parent)
12820 * interface.cs (Interface.DefineInterface): Drop builder
12821 parameter cleanup like class.cs
12823 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
12826 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
12829 (Try.Emit): Propagate the returns value from the statement.
12831 (Return.Emit): Even if we are leavning
12833 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
12835 * modifiers.cs: Fix the computation of MethodAttributes flags.
12837 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
12839 * driver.cs: allow compilation of files that start with '/'.
12840 Add a default case when checking the argument of --target.
12842 2002-03-25 Miguel de Icaza <miguel@ximian.com>
12844 * interface.cs: Implement the same search algorithm for types in
12845 the interface code.
12847 * delegate.cs: Do not allow multiple definition.
12849 * Recovered ChangeLog that got accidentally amputated
12851 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
12853 * rootcontext.cs: Load manually enum to allow core classes to
12854 contain enumerations.
12856 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
12857 Update to new static methods in TypeManager.
12859 * typemanager.cs (GetMethod, GetConstructor): Use our
12860 implementation of FindMembers to find the members, since during
12861 corlib compilation, the types are TypeBuilders and GetMethod and
12862 GetConstructor do not work.
12864 Make all methods in TypeManager static.
12866 (InitCodeHelpers): Split the functionality from
12867 the InitCodeTypes function.
12869 * driver.cs: Call InitCodeHelpers after we have populated the
12872 * cs-parser.jay (delegate_declaration): we did not used to compute
12873 the delegate name correctly for void delegates.
12875 2002-03-24 Miguel de Icaza <miguel@ximian.com>
12877 * rootcontext.cs (RootContext): Init the interface_resolve_order
12878 and type_container_resolve_order always.
12880 (ResolveCore, BootstrapCorlib_ResolveClass,
12881 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
12882 compiler when compiling with --nostdlib
12884 * class.cs (TypeContainer.DefineType): Check that our parent is
12885 not null. This test is most important when we are bootstraping
12888 * codegen.cs: Split out the symbol writing code.
12890 2002-03-25 Martin Baulig <martin@gnome.org>
12892 * driver.cs (-g): Made -g an alias for --debug.
12894 2002-03-24 Martin Baulig <martin@gnome.org>
12896 * codegen.cs (SymbolWriter): New public variable. Returns the
12897 current symbol writer.
12898 (CodeGen): Added `bool want_debugging_support' argument to the
12899 constructor. If true, tell the ModuleBuild that we want debugging
12900 support and ask it for the ISymbolWriter.
12901 (Save): If we have a symbol writer, call it's Close() method after
12902 saving the assembly.
12904 * driver.c (--debug): New command line argument to create a
12905 debugger information file.
12907 * location.cs (SymbolDocument): New public property. Returns an
12908 ISymbolDocumentWriter object for the current source file or null
12909 if we don't have a symbol writer.
12911 2002-03-21 Miguel de Icaza <miguel@ximian.com>
12913 * driver.cs (LoadAssembly): Correctly return when all the paths
12914 have been tried and not before.
12916 * statement.cs (Switch.Emit): return the actual coverage for this
12917 statement (returns/not-returns)
12919 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
12920 switch of the statement if we are the last switch section. That
12921 kills two problems: try/catch problems (we used to emit an empty
12922 nop at the end) and switch statements where all branches would
12925 2002-03-19 Miguel de Icaza <miguel@ximian.com>
12927 * driver.cs: Add default assemblies (the equivalent to the
12928 Microsoft CSC.RSP file)
12930 * cs-tokenizer.cs: When updating `cols and setting it to zero,
12931 also update tokens_seen and set it to false.
12933 * driver.cs: Implement --recurse for Mike.
12935 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
12936 correctly splitting out the paths.
12938 2002-03-18 Miguel de Icaza <miguel@ximian.com>
12940 * interface.cs (Interface.PopulateProperty): Instead of using
12941 `parent' as the declaration space for the set parameters, use
12944 * support.cs (InternalParameters): InternalParameters constructor
12945 takes a DeclSpace instead of a TypeContainer.
12947 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
12948 types are being initialized, load the address of it before calling
12951 (New): Provide a mechanism to disable the generation of local
12952 value type temporaries when the caller will be providing us with
12953 an address to store it.
12955 (ArrayCreation.EmitDynamicInitializers): Use it.
12957 2002-03-17 Miguel de Icaza <miguel@ximian.com>
12959 * expression.cs (Invocation.EmitArguments): Only probe for array
12960 property if there is more than one argument. Sorry about that.
12962 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
12963 empty param arrays.
12965 * class.cs (Method.LabelParameters): Fix incorrect code path that
12966 prevented the `ParamArrayAttribute' from being applied to the
12969 2002-03-16 Miguel de Icaza <miguel@ximian.com>
12971 * support.cs (ReflectionParameters): Correctly compute whether the
12972 last argument is a params array. Fixes the problem with
12975 * typemanager.cs: Make the assemblies array always be non-null
12976 (empty, but non-null)
12978 * tree.cs (RecordDecl): New function that abstracts the recording
12979 of names. This reports error 101, and provides a pointer to the
12980 previous declaration. Fixes a crash in the compiler.
12982 * cs-parser.jay (constructor_declaration): Update to new grammar,
12983 and provide a constructor_body that can be empty.
12985 2002-03-15 Miguel de Icaza <miguel@ximian.com>
12987 * driver.cs: Add support for --resources.
12989 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
12990 Make all types for the various array helper methods be integer.
12992 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
12993 CheckState to ConvCast.
12995 (ConvCast): Now it takes a `checked' state argument, to avoid
12996 depending on the emit context for the conversion, and just using
12997 the resolve time setting.
12999 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
13000 instead of Invocation.EmitArguments. We do not emit the original
13001 arguments, instead we emit those which have been converted to
13002 unsigned int expressions.
13004 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
13006 * codegen.cs: ditto.
13008 * expression.cs (LocalVariableReference): Drop the use of the
13009 Store function that depended on the variable index.
13011 * statement.cs (VariableInfo): Drop the `Idx' property from this
13012 class, as this is not taking into account the indexes for
13013 temporaries tat we generate during the execution, getting the
13016 * class.cs: First emit class initializers, then call the parent
13019 * expression.cs (Binary): Fix opcode emision.
13020 (UnaryMutator.EmitCode): Support checked code generation
13022 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
13023 matches for events for both the Static and Instance scans,
13024 pointing to the same element. Fix that.
13026 2002-03-14 Miguel de Icaza <miguel@ximian.com>
13028 * rootcontext.cs (ResolveTree): Always set the
13029 interface_resolve_order, because nested interfaces will be calling
13032 * class.cs (GetInterfaceOrClass): Track the same resolution
13033 process used by TypeManager.LookupType. This fixes the nested
13034 type lookups in class declarations (separate path from
13037 (TypeContainer.DefineType): Also define nested interfaces.
13038 (TypeContainer.RegisterOrder): New public function used to
13039 register the order in which child interfaces need to be closed.
13041 Nested interfaces need to be closed after their parents have been
13044 * interface.cs (InterfaceAttr): Put all the logic for computing
13045 the interface attribute here.
13047 (DefineInterface): Register our interface order with the
13048 RootContext or with the TypeContainer depending on the case.
13050 2002-03-12 Miguel de Icaza <miguel@ximian.com>
13052 * cs-parser.jay: rework foreach statement to work with the new
13053 changes to the policy on SimpleNames.
13055 * report.cs: support Stacktrace on warnings as well.
13057 * makefile: drop --unsafe and /unsafe from the compile.
13059 2002-03-13 Ravi Pratap <ravi@ximian.com>
13061 * ecore.cs (StandardConversionExists): Modify to take an Expression
13062 as the first parameter. Ensure we do null -> reference type conversion
13065 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
13066 temporary Expression objects.
13068 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
13070 * interface.cs: workaround bug in method overloading resolution
13071 (there is already a bugzilla bug for it).
13073 2002-03-12 Miguel de Icaza <miguel@ximian.com>
13075 We could also solve this problem by having a separate path for
13076 performing type lookups, instead of DoResolve, we could have a
13077 ResolveType entry point, and only participating pieces of the
13078 production (simplename, deref, array) would implement this.
13080 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
13081 signal SimpleName to only resolve type names and not attempt to
13082 resolve anything else.
13084 * expression.cs (Cast): Set the flag.
13086 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
13088 * class.cs: Only report 108 if there is no `new' modifier.
13090 * cs-parser.jay: rework foreach statement to work with the new
13091 changes to the policy on SimpleNames.
13093 * report.cs: support Stacktrace on warnings as well.
13095 * makefile: drop --unsafe and /unsafe from the compile.
13097 2002-03-11 Miguel de Icaza <miguel@ximian.com>
13099 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
13100 lookups here, instead of doing that at parse time. This means
13101 that our grammar will not introduce `LocalVariableReferences' as
13102 expressions at this point. That solves the problem of code like
13106 static void Main ()
13110 This is only half the fix. The full fix requires parameters to
13111 also be handled in this way.
13113 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
13114 makes the use more obvious of the DeclSpace. The
13115 ec.TypeContainer.TypeBuilder is now only used to pull the
13116 TypeBuilder for it.
13118 My theory is that I can get rid of the TypeBuilder completely from
13119 the EmitContext, and have typecasts where it is used (from
13120 DeclSpace to where it matters).
13122 The only pending problem is that the code that implements Aliases
13123 is on TypeContainer, and probably should go in DeclSpace.
13125 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
13126 lookups here, instead of doing that at parse time. This means
13127 that our grammar will not introduce `LocalVariableReferences' as
13128 expressions at this point. That solves the problem of code like
13132 static void Main ()
13136 This is only half the fix. The full fix requires parameters to
13137 also be handled in this way.
13139 * class.cs (Property.DefineMethod): When implementing an interface
13140 method, set newslot, when implementing an abstract method, do not
13141 set the flag (before we tried never setting it, or always setting
13142 it, which is the difference).
13143 (Indexer.DefineMethod): same.
13144 (Method.DefineMethod): same.
13146 * ecore.cs: Only set the status used flag if we get back a Field.
13148 * attribute.cs: Temporary hack, so Paolo can keep working.
13150 2002-03-08 Ravi Pratap <ravi@ximian.com>
13152 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
13153 the unmanaged type in the case we have a MarshalAs attribute.
13155 (Resolve): Handle the case when we are parsing the special MarshalAs
13156 attribute [we need to store the unmanaged type to use later]
13158 * typemanager.cs (marshal_as_attr_type): Built in type for the
13159 MarshalAs Attribute.
13161 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
13162 on parameters and accordingly set the marshalling info.
13164 2002-03-09 Miguel de Icaza <miguel@ximian.com>
13166 * class.cs: Optimizing slightly by removing redundant code after
13167 we switched to the `NoTypes' return value.
13168 (Property.DefineMethod): use NoTypes here too.
13170 This fixes the bug I introduced in my last batch of changes.
13172 2002-03-05 Ravi Pratap <ravi@ximian.com>
13174 * tree.cs (RecordEnum): Add. We now keep track of enums too.
13176 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
13177 Enums since those are types too.
13179 * cs-parser.jay (enum_declaration): Record enums as we parse them.
13181 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
13182 thanks to a call during the lookup process.
13184 2002-03-07 Miguel de Icaza <miguel@ximian.com>
13186 * statement.cs (Foreach): Lots of work to accomodate a particular
13187 kind of foreach statement that I had not kept in mind. It is
13188 possible to have foreachs on classes that provide a GetEnumerator
13189 method that return objects that implement the "pattern" for using
13190 a foreach, there is no need to support GetEnumerator
13193 This is needed to compile nant.
13195 * decl.cs: Only report 114 if the member is not `Finalize' and if
13196 the warning level is at least 2.
13198 * class.cs: Moved the compare function from Method to
13201 (MethodSignature.InheritableMemberSignatureCompare): Add new
13202 filter function that is used to extract inheritable methods from a
13205 (Method.Define): Use the new `inheritable_method_signature_filter'
13208 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
13211 2002-03-06 Miguel de Icaza <miguel@ximian.com>
13213 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
13215 * cs-parser.jay: Add opt_semicolon to the interface declaration.
13217 * expression.cs: Pass location information to
13218 ConvertImplicitStandard.
13220 * class.cs: Added debugging code to track return values from
13223 2002-03-05 Miguel de Icaza <miguel@ximian.com>
13225 * expression.cs (Is.DoResolve): If either side of the `is' is an
13226 interface, do not flag the warning.
13228 * ecore.cs (ImplicitReferenceConversion): We need a separate test
13231 * report.cs: Allow for --fatal to be used with --probe.
13233 * typemanager.cs (NoTypes): Move the definition for the empty Type
13236 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
13238 (TypeContainer.DefineProxy): New function used to proxy to parent
13239 implementations when implementing interfaces.
13240 (TypeContainer.ParentImplements): used to lookup if our parent
13241 implements a public function that is required by an interface.
13242 (TypeContainer.VerifyPendingMethods): Hook this up.
13244 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
13245 `modules' and `assemblies' arraylists into arrays. We only grow
13246 these are the very early start up of the program, so this improves
13247 the speedof LookupType (nicely measured).
13249 * expression.cs (MakeByteBlob): Replaced unsafe code with
13250 BitConverter, as suggested by Paolo.
13252 * cfold.cs (ConstantFold.Binary): Special case: perform constant
13253 folding of string concatenation, but if either side is a string,
13254 and the other is not, then return null, and let the runtime use
13255 the concatenation on the string plus the object (using
13256 `Object.ToString').
13258 2002-03-04 Miguel de Icaza <miguel@ximian.com>
13260 Constant Folding has been implemented now.
13262 * expression.cs (Unary.Reduce): Do not throw an exception, catch
13263 the error instead on types that are not supported in one's
13266 * constant.cs (Constant and all children): New set of functions to
13267 perform implict and explicit conversions.
13269 * ecore.cs (EnumConstant): Implement the new functions to perform
13270 conversion by proxying to the child expression.
13272 * codegen.cs: (ConstantCheckState): Constant evaluation has its
13273 own separate setting that can not be turned off from the command
13274 line using --unchecked or --checked and is only controlled using
13275 the checked/unchecked statements and expressions. This setting is
13276 used by the constant folder to flag errors.
13278 * expression.cs (CheckedExpr, UncheckedExpr): Set the
13279 ConstantCheckState as well.
13281 During Resolve, they also have to flag the state, because the
13282 constant folder runs completely in the Resolve phase.
13284 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
13287 2002-03-01 Miguel de Icaza <miguel@ximian.com>
13289 * cfold.cs: New file, this file contains the constant folder.
13291 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
13292 argument to track whether we are using the resulting address to
13293 load or store a value and provide better error messages.
13295 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
13296 new AddressOf arguments.
13298 * statement.cs (Foreach.EmitCollectionForeach): Update
13300 * expression.cs (Argument.Emit): Call AddressOf with proper
13301 arguments to track usage.
13303 (New.DoEmit): Call AddressOf with new arguments.
13305 (Unary.Emit): Adjust AddressOf call.
13307 2002-03-01 Ravi Pratap <ravi@ximian.com>
13309 * cs-parser.jay (member_access): Change the case for pre-defined types
13310 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
13313 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
13316 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
13317 essentially like methods and apply attributes like MethodImplOptions to them too.
13319 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
13322 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
13323 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
13326 * Update code everywhere accordingly.
13328 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
13330 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
13332 2002-02-28 Ravi Pratap <ravi@ximian.com>
13334 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
13335 try performing lookups against those instead of jumping straight into using
13336 the 'using' clauses.
13338 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
13340 (LookupType): Perform lookups in implicit parents too.
13342 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
13343 sequence as RootContext.LookupType.
13345 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
13346 the various cases of namespace lookups into this method.
13348 2002-03-01 Miguel de Icaza <miguel@ximian.com>
13350 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
13351 in positional arguments)
13353 * class.cs (Operator): Update the AllowedModifiers to contain
13356 * cs-parser.jay: Update operator declaration to allow for the
13357 operator body to be empty.
13359 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
13362 2002-02-27 Miguel de Icaza <miguel@ximian.com>
13364 * class.cs (Method.Emit): Label parameters.
13366 * driver.cs: Return 1 or 0 as the program exit code.
13368 2002-02-26 Miguel de Icaza <miguel@ximian.com>
13370 * expression.cs: Special case the `null' object when trying to
13371 auto-compute the type, as anything can be explicitly converted to
13374 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
13375 spotting this Paolo.
13377 (Expression.ImplicitNumericConversion): Perform comparissions of
13378 the type using the underlying type in the case of an enumeration
13379 rather than using the enumeration type for the compare.
13381 Cope with the underlying == type case, which is not possible to
13384 (Expression.ConvertNumericExplicit): Perform comparissions of
13385 the type using the underlying type in the case of an enumeration
13386 rather than using the enumeration type for the compare.
13388 * driver.cs: If the user does not supply an extension, assume .exe
13390 * cs-parser.jay (if_statement): Rewrote so that we can track the
13391 location for the if statement.
13393 * expression.cs (Binary.ConstantFold): Only concat strings when
13394 the operation is "+", not everything ;-)
13396 * statement.cs (Statement.EmitBoolExpression): Take a location
13398 (If, While, Do): Track location.
13400 * expression.cs (Binary.ResolveOperator): In the object + string
13401 case, I was missing a call to ConvertImplicit
13403 2002-02-25 Ravi Pratap <ravi@ximian.com>
13405 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
13406 Location arguments. Ensure we use RootContext.LookupType to do our work
13407 and not try to do a direct Type.GetType and ModuleBuilder.GetType
13409 * interface.cs (PopulateMethod): Handle the type of the parameter being
13412 * expression.cs (Invocation.BetterFunction): Handle the case when we
13413 have a params method with no fixed arguments and a call is made with no
13416 2002-02-25 Miguel de Icaza <miguel@ximian.com>
13418 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
13419 the verbatim-string-literal
13421 * support.cs (InternalParameters.ParameterModifier): handle null
13423 (InternalParameters.ParameterType): ditto.
13425 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
13426 duplicating the name of the variable parameter.
13427 (GetParameterByName): Fix bug where we were not looking up array
13428 paramters if they were the only present (thanks Paolo!).
13429 (GetParameterInfo): We only have an empty set of types if both
13430 fixed and array are set to null.
13431 (GetParameterInfo-idx): Handle FixedParameter == null
13433 * cs-parser.jay: Handle the case where there is no catch
13434 statements (missing null test).
13436 2002-02-22 Miguel de Icaza <miguel@ximian.com>
13438 * driver.cs (MainDriver): Be conservative on our command line
13441 Catch DirectoryNotFoundException when calling GetFiles.
13443 (SplitPathAndPattern): Used to split the input specification into
13444 a path and a pattern that we can feed to Directory.GetFiles.
13446 2002-02-21 Miguel de Icaza <miguel@ximian.com>
13448 * statement.cs (Fixed): Implement the last case of the Fixed
13449 statement (string handling).
13451 * expression.cs (StringPtr): New class used to return a char * to
13452 a string; Used by the Fixed statement.
13454 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
13456 * expression.cs (Binary.ResolveOperator): Remove redundant
13457 MemberLookup pn parent type.
13458 Optimize union call, we do not need a union if the types are the same.
13459 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
13462 Specialize the use of MemberLookup everywhere, instead of using
13463 the default settings.
13465 (StackAlloc): Implement stackalloc keyword.
13467 * cs-parser.jay: Add rule to parse stackalloc.
13469 * driver.cs: Handle /h, /help, /?
13471 * expression.cs (MakeByteBlob): Removed the hacks we had in place
13472 before we supported unsafe code.
13474 * makefile: add --unsafe to the self compilation of mcs.
13476 2002-02-20 Miguel de Icaza <miguel@ximian.com>
13478 * expression.cs (PointerArithmetic): New class that is used to
13479 perform pointer arithmetic.
13480 (Binary.Resolve): Handle pointer arithmetic
13481 Handle pointer comparission.
13482 (ArrayPtr): Utility expression class that is used to take the
13483 address of an array.
13485 (ElementAccess): Implement array access for pointers
13487 * statement.cs (Fixed): Implement fixed statement for arrays, we
13488 are missing one more case before we are done.
13490 * expression.cs (Indirection): Implement EmitAssign and set the
13491 ExprClass to Variable. This allows pointer dereferences to be
13492 treated as variables, and to have values assigned to them.
13494 * ecore.cs (Expression.StoreFromPtr): New utility function to
13495 store values dereferencing.
13497 2002-02-20 Ravi Pratap <ravi@ximian.com>
13499 * expression.cs (Binary.ResolveOperator): Ensure that we are
13500 not trying to operate on a void type - this fixes the reported
13503 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
13504 the parent implementation is sealed.
13506 * ../errors/cs0239.cs : Add.
13508 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
13510 * typemanager.cs (unverifiable_code_type): Corresponds to
13511 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
13512 which have unsafe code in them.
13514 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
13517 2002-02-19 Miguel de Icaza <miguel@ximian.com>
13519 * cs-tokenizer.cs: Add support for @"litreal strings"
13521 Make tokenizer accept pre-processor directives
13522 on any column (remove the old C-like limitation).
13524 * rootcontext.cs (EmitCode): Emit any global attributes.
13525 (AddGlobalAttributes): Used to keep track of assembly attributes.
13527 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
13529 * cs-parser.jay: Add support for global attributes.
13531 2002-02-17 Miguel de Icaza <miguel@ximian.com>
13533 * expression.cs (Indirection): New helper class. Unary will
13534 create Indirection classes to be able to implement the
13535 IMemoryLocation interface on it.
13537 2002-02-16 Miguel de Icaza <miguel@ximian.com>
13539 * cs-parser.jay (fixed_statement): reference the right statement.
13541 * statement.cs (Fixed.Emit): Finish implementing the fixed
13542 statement for the &x case.
13544 2002-02-14 Miguel de Icaza <miguel@ximian.com>
13546 * class.cs (Property.Define, Method.Define): Remove newslot when
13549 * modifiers.cs: My use of NewSlot when `Abstract' was set was
13550 wrong. NewSlot should only be used if the `new' keyword is present.
13552 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
13553 locating our system dir. Sorry about this.
13555 2002-02-13 Miguel de Icaza <miguel@ximian.com>
13557 * driver.cs (GetSystemDir): Compute correctly the location of our
13558 system assemblies. I was using the compiler directory instead of
13559 the library directory.
13561 2002-02-13 Ravi Pratap <ravi@ximian.com>
13563 * expression.cs (BetterFunction): Put back in what Miguel commented out
13564 since it is the correct fix. The problem is elsewhere ;-)
13566 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
13567 parameters of the parms method are themselves compatible or not !
13569 (StandardConversionExists): Fix very dangerous bug where we were forgetting
13570 to check that a class implements an interface before saying that an implicit
13571 conversion was allowed. Use ImplementsInterface to do the checking.
13573 2002-02-13 Miguel de Icaza <miguel@ximian.com>
13575 * class.cs (Method.Define): Track whether we are an explicit
13576 implementation or not. And only call DefineMethodOverride if we
13577 are an explicit implementation.
13579 (Property.DefineMethod): Ditto.
13581 2002-02-11 Ravi Pratap <ravi@ximian.com>
13583 * expression.cs (BetterFunction): Catch hideous bug which was
13584 preventing us from detecting ambiguous calls due to implicit casts i.e
13587 2002-01-29 Miguel de Icaza <miguel@ximian.com>
13589 * support.cs (Pair): Remove un-needed method. I figured why I was
13590 getting the error in cs-parser.jay, the variable in a foreach loop
13591 is readonly, and the compiler does not really treat this as a variable.
13593 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
13594 instead of EQUALS in grammar.
13596 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
13598 * expression.cs (Unary.DoResolve): Check whether the argument is
13601 2002-01-28 Miguel de Icaza <miguel@ximian.com>
13603 * support.cs: Api for Pair to set a value. Despite the fact that
13604 the variables are public the MS C# compiler refuses to compile
13605 code that accesses the field if the variable is part of a foreach
13608 * statement.cs (Fixed): Begin implementation of the fixed
13611 (Block.AddVariable): Return the VariableInfo on success and null
13612 on failure instead of true/false.
13614 * cs-parser.jay (foreach): Catch errors on variables already
13615 defined (we were ignoring this value before) and properly unwind
13616 the block hierarchy
13618 (fixed_statement): grammar for the fixed statement.
13620 2002-01-25 Miguel de Icaza <miguel@ximian.com>
13622 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
13623 pointer types to be incretemented.
13625 (SizeOf): Implement.
13627 * cs-parser.jay (pointer_member_access): Implement
13628 expr->IDENTIFIER production.
13630 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
13631 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
13634 (Unary): Implement indirection.
13636 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
13637 use in non-unsafe context).
13639 (SimpleName.DoResolve): Check for pointers in field access on safe
13642 (Expression.LoadFromPtr): Factor the load-indirect code in this
13643 function. This was duplicated in UnboxCast and ParameterReference
13645 2002-01-24 Miguel de Icaza <miguel@ximian.com>
13647 * expression.cs (ComposedCast): report an error if a pointer cast
13648 is used in a safe region.
13650 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
13651 pointer type casts in unsafe context.
13653 * codegen.cs (EmitContext): Set up IsUnsafe.
13655 * cs-parser.jay (non_expression_type): Add productions for pointer
13658 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
13659 code. We should not use force into static mode if the method is
13660 not virtual. Fixes bug in MIS
13662 * statement.cs (Do.Emit, While.Emit, For.Emit,
13663 Statement.EmitBoolExpression): Add support to Do and While to
13664 propagate infinite loop as `I do return' semantics.
13666 Improve the For case to also test for boolean constants.
13668 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
13669 to the list of attributes we can add.
13671 Remove `EmitContext' argument.
13673 * class.cs (Method.Define): Apply parameter attributes.
13674 (Constructor.Define): Apply parameter attributes.
13675 (MethodCore.LabelParameters): Move here the core of labeling
13678 * support.cs (ReflectionParameters.ParameterModifier,
13679 InternalParameters.ParameterModifier): Use IsByRef on the type and
13680 only return the OUT bit for these parameters instead of in/out/ref
13683 This is because I miss-understood things. The ParameterInfo.IsIn
13684 and IsOut represent whether the parameter has the [In] and [Out]
13687 2002-01-22 Miguel de Icaza <miguel@ximian.com>
13689 * ecore.cs (FieldExpr.Emit): Release temporaries.
13691 * assign.cs (LocalTemporary.Release): new function.
13693 * codegen.cs (EmitContext.GetTemporaryStorage,
13694 EmitContext.FreeTemporaryStorage): Rework the way we deal with
13695 temporary storage. Now we can "put back" localbuilders when we
13698 2002-01-21 Miguel de Icaza <miguel@ximian.com>
13700 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
13701 need to make a copy of the variable to generate verifiable code.
13703 2002-01-19 Miguel de Icaza <miguel@ximian.com>
13705 * driver.cs: Compute dynamically the system directory.
13707 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
13708 Slower, but more generally useful. Used by the abstract
13709 registering implementation.
13711 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
13712 the rules for the special rule on Type/instances. First check if
13713 we have the same name, and if so, try that special static path
13714 rather than the instance path.
13716 2002-01-18 Miguel de Icaza <miguel@ximian.com>
13718 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
13721 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
13722 Enum, ValueType, Delegate or Array for non-corlib compiles.
13724 * cs-tokenizer.cs: Catch long identifiers (645)
13726 * typemanager.cs (IndexerPropetyName): Ravi never tested this
13729 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
13730 fix, we were returning too early, so we were not registering
13731 pending methods from abstract classes.
13733 Do not register pending methods if the class is abstract.
13735 * expression.cs (Conditional.DoResolve): Report circular implicit
13736 conversions when we neecd to compute it for conditional
13739 (Is.DoResolve): If the expression is always of the provided type,
13740 flag warning 183. If the expression can not ever be of the
13741 provided type flag warning 184.
13743 * class.cs: Catch 169 as well.
13745 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
13748 2002-01-18 Nick Drochak <ndrochak@gol.com>
13750 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
13752 2002-01-17 Miguel de Icaza <miguel@ximian.com>
13754 * interface.cs: (PopulateMethod): Check for pointers being defined
13755 only if the unsafe context is active.
13756 (PopulateProperty): ditto.
13757 (PopulateIndexer): ditto.
13759 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
13760 specified. If pointers are present, make sure that they are
13761 present in an unsafe context.
13762 (Constructor, Constructor.Define): ditto.
13763 (Field, Field.Define): ditto.
13764 (Property, Property.Define): ditto.
13765 (Event, Event.Define): ditto.
13767 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
13768 hashtable if there are classes or structs defined.
13770 * expression.cs (LocalVariableReference.DoResolve): Simplify this
13771 code, as the constant resolution moved.
13773 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
13774 the metadata, so we can flag error 133.
13776 * decl.cs (MemberCore.UnsafeOK): New function to test that a
13777 pointer is being declared in an unsafe context.
13779 2002-01-16 Miguel de Icaza <miguel@ximian.com>
13781 * modifiers.cs (Modifiers.Check): Require a Location argument.
13782 Report error 227 for Unsafe use.
13784 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
13786 * statement.cs (For.Emit): If the test is null, then report that
13787 we do `return', as we wont reach anything afterwards.
13789 (Switch.SwitchGoverningType): Track the expression that matched
13792 * driver.cs: Allow negative numbers as an error code to flag.
13794 * cs-parser.jay: Handle 1551.
13796 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
13798 2002-01-15 Miguel de Icaza <miguel@ximian.com>
13800 * cs-parser.jay: Report 1518 (type declaration can only contain
13801 class, struct, interface, enum or delegate)
13803 (switch_label): Report 1523 (keywords `case' or `default' must
13806 (opt_switch_sections): Report 1522 (empty switch)
13808 * driver.cs: Report 1515 (response file specified multiple times)
13809 Report 1516 (Source file specified multiple times).
13811 * expression.cs (Argument.Resolve): Signal 1510
13813 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
13814 access not allowed in static code)
13816 2002-01-11 Ravi Pratap <ravi@ximian.com>
13818 * typemanager.cs (IsPointerType): Utility method which we are going
13821 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
13822 the object type, so we take care of that.
13824 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
13826 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
13827 added to non-params parameters :-)
13829 * typemanager.cs (CSharpName): Include 'void' type too.
13831 (void_ptr_type): Include in the set of core types.
13833 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
13836 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
13839 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
13840 completely forgotten about it.
13842 2002-01-10 Ravi Pratap <ravi@ximian.com>
13844 * cs-parser.jay (pointer_type): Add. This begins our implementation
13845 of parsing rules for unsafe code.
13847 (unsafe_statement): Implement.
13849 (embedded_statement): Modify to include the above.
13851 * statement.cs (Unsafe): Implement new class for unsafe blocks.
13853 * codegen.cs (EmitContext.InUnsafe): Add. This determines
13854 if the current context is an unsafe one.
13856 * cs-parser.jay (local_variable_pointer_type): Since local variable types
13857 are handled differently, we need separate rules for them.
13859 (local_variable_declaration): Update to use local_variable_pointer_type
13860 to allow variable declarations of unmanaged pointer types.
13862 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
13863 in unsafe contexts.
13865 * ../errors/cs0214.cs : Add.
13867 2002-01-16 Nick Drochak <ndrochak@gol.com>
13869 * makefile: remove 'response' file when cleaning.
13871 2002-01-15 Miguel de Icaza <miguel@ximian.com>
13873 * cs-parser.jay: Report 1524.
13875 2002-01-14 Miguel de Icaza <miguel@ximian.com>
13877 * typemanager.cs (RegisterMethod): drop checking if we have
13878 registered this from here
13880 2002-01-12 Miguel de Icaza <miguel@ximian.com>
13882 * class.cs (Method.EmitDestructor): Implement calling our base
13885 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
13886 value of InFinally.
13888 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
13889 this routine and will wrap the call in a try/catch block. Deal
13892 2002-01-11 Miguel de Icaza <miguel@ximian.com>
13894 * ecore.cs (Expression.MemberLookup): instead of taking a
13895 parameter `same_type' that was used to tell whether we could
13896 access private members we compute our containing type from the
13899 (FieldExpr): Added partial support for volatile fields. This does
13900 not work for volatile fields exposed from assemblies, as I can not
13901 figure out how to extract the modreq from it.
13903 Updated all the source files to use this.
13905 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
13906 because it is referenced by MemberLookup very often.
13908 2002-01-09 Ravi Pratap <ravi@ximian.com>
13910 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
13911 TypeBuilder.GetCustomAttributes to retrieve what we need.
13913 Get rid of redundant default_member_attr_type as this is the same as
13914 default_member_type which already exists.
13916 * interface.cs, attribute.cs : Update accordingly.
13918 2002-01-08 Miguel de Icaza <miguel@ximian.com>
13920 * typemanager.cs: Enable IndexerPropertyName again. It does not
13921 work for TYpeBuilders though. Ravi, can you please fix this?
13923 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
13925 * expression.cs (Argument.Emit): Handle the case of ref objects
13926 being passed to ref functions;
13928 (ParameterReference.EmitLoad): Loads the content of the pointer
13929 without dereferencing.
13931 2002-01-07 Miguel de Icaza <miguel@ximian.com>
13933 * cs-tokenizer.cs: Implemented the pre-processing expressions.
13935 2002-01-08 Ravi Pratap <ravi@ximian.com>
13937 * class.cs (Indexer.DefineMethod): Incorporate the interface
13938 type in the name of the method if we are doing explicit interface
13941 * expression.cs (ConversionExists): Remove as it is completely obsolete.
13943 (BetterConversion): Fix extremely trivial bug where we were referring to
13944 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
13947 * ../errors/bug16.cs : Add although we have fixed it.
13949 2002-01-07 Miguel de Icaza <miguel@ximian.com>
13951 * expression.cs (BaseIndexer): Begin implementation.
13953 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
13955 * cs-parser.jay (indexer_declarator): Use qualified_identifier
13956 production directly to remove a shift/reduce, and implement
13957 explicit interface implementation.
13959 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
13960 after a floating point suffix.
13962 * expression.cs (DoNumericPromotions): Improved the conversion for
13963 uint/uint. If we have a constant, we avoid doing a typecast to a
13966 * class.cs (Indexer): Implement explicit interface implementation
13969 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
13971 * class.cs: make the default instance constructor public and hidebysig.
13973 2001-01-03 Ravi Pratap <ravi@ximian.com>
13975 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
13976 so we can call it from elsewhere.
13978 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
13979 we emit it internally if the class has a defined indexer; otherwise the user
13980 emits it by decorating the class definition with the DefaultMemberAttribute.
13982 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
13983 attribute is not used on a type which defines an indexer.
13985 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
13986 character when we skip whitespace.
13988 * ../errors/cs0646.cs : Add.
13990 2002-01-03 Miguel de Icaza <miguel@ximian.com>
13992 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
13995 * makefile: Add practical target `mcs3.exe' which builds the third
13996 generation compiler.
13998 * expression.cs (New): Fix structures constructor calling.
14000 * class.cs (Property, Method, Indexer): Emit Final flag on the
14001 method if we are an interface implementation and we are not
14004 * ecore.cs (PropertyExpr): New public field `IsBase', tells
14005 whether this property is referencing a `base' method.
14007 * expression.cs (Invocation.EmitCall): take an extra argument:
14008 is_base, this is used to determine whether the `call' or
14009 `callvirt' opcode should be used.
14012 * delegate.cs: update EmitCall.
14014 * class.cs (Method.Define): Set NewSlot for the cases where we are
14015 not implementing an interface method.
14017 (Property.Define): ditto.
14019 2002-01-02 Miguel de Icaza <miguel@ximian.com>
14021 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
14022 'r'. Allows mcs to parse itself fully.
14024 2002-01-02 Ravi Pratap <ravi@ximian.com>
14026 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
14027 of the number of initializers that require the InitializeArray method.
14029 (CheckIndices): Store the Expression in all cases - not the plain value. Also
14030 update the above field where necessary.
14032 (MakeByteBlob): Update accordingly.
14034 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
14037 (EmitDynamicInitializers): Update in accordance with the new optimization.
14039 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
14040 same OpCode applies.
14042 * cs-parser.jay : Fix some glaring errors I introduced.
14044 2002-01-01 Ravi Pratap <ravi@ximian.com>
14046 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
14047 so that we can check for name clashes there too.
14049 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
14050 for interface indexers.
14052 * interfaces.cs (Define): Emit the default member attribute.
14054 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
14055 variable was being referred to while setting the value ;-)
14057 2002-01-01 Miguel de Icaza <miguel@ximian.com>
14059 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
14060 byte-by-byte information when we know the data is zero.
14062 Make the block always a multiple of 4, because
14063 DefineInitializedData has a bug.
14065 * assign.cs: Fix, we should assign from the temporary, not from
14068 * expression.cs (MakeByteBlob): Fix my incorrect code.
14070 2001-12-31 Miguel de Icaza <miguel@ximian.com>
14072 * typemanager.cs (EnumToUnderlying): This function is used to get
14073 the underlying type from an enumeration, because it does not
14076 * constant.cs: Use the I4_S form for values between -128 and 127.
14078 * statement.cs (Block.LookupLabel): Looks up a label.
14079 (Block): Drop support for labeled blocks.
14081 (LabeledStatement): New kind of statement that represents a label
14084 (Goto): Finally implement this bad boy.
14086 * cs-parser.jay: Update to reflect new mechanism to implement
14089 2001-12-30 Miguel de Icaza <miguel@ximian.com>
14091 * codegen.cs (EmitContext.This): a codegen property that keeps the
14092 a single instance of this instead of creating many different this
14095 * delegate.cs (Delegate.DoResolve): Update to use the property;
14097 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
14099 * expression.cs (BaseAccess.DoResolve): Ditto.
14101 2001-12-29 Ravi Pratap <ravi@ximian.com>
14103 * typemanager.cs (methodimpl_attr_type): Add to hold the type
14104 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
14106 (InitCoreTypes): Update accordingly.
14108 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
14109 so we can quickly store the state.
14111 (ApplyAttributes): Set the correct implementation flags
14112 for InternalCall methods.
14114 2001-12-29 Miguel de Icaza <miguel@ximian.com>
14116 * expression.cs (EmitCall): if a method is not virtual, then do
14117 not use callvirt on it.
14119 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
14120 user defined stuff) requires the use of stobj, which takes an
14121 address on the stack instead of an array and an index. So emit
14122 the Ldelema operation for it.
14124 (EmitStoreOpcode): Use stobj for valuetypes.
14126 (UnaryMutator.EmitCode): Use the right 1 value depending on
14127 whether we are dealing with int64/uint64, float or doubles.
14129 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
14130 constructors that I implemented last night.
14132 (Constructor.IsDefault): Fix to work properly for static
14135 * cs-parser.jay (CheckDef): report method signature errors.
14136 Update error number 103 to be 132.
14138 * decl.cs: New AdditionResult enumeration value: MethodExists.
14139 Although we do this check for methods later on in the semantic
14140 analysis, catching repeated default constructors is so easy that
14141 we catch these here.
14143 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
14146 (ParameterReference.EmitAssign, Emit): handle
14149 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
14150 (ArrayAccess.EmitStoreOpcode): ditto.
14152 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
14154 * expression.cs (MakeByteBlob): Complete all the missing types
14155 (uint, short, ushort, byte, sbyte)
14157 * class.cs: Only init instance field initializers on instance
14160 Rename `constructors' to instance_constructors.
14162 (TypeContainer.AddConstructor): Only add constructors to the list
14163 if it is not static.
14165 Make sure that we handle default_static_constructor independently
14166 everywhere where we handle instance_constructors
14168 2001-12-28 Miguel de Icaza <miguel@ximian.com>
14170 * class.cs: Do not lookup or create a base initializer for a
14171 static constructor.
14173 (ConstructorInitializer.Resolve): use the proper type to lookup
14176 * cs-parser.jay: Report error 1585 (modifiers between type and name).
14178 * enum.cs, interface.cs: Remove CloseType, this is taken care by
14181 * decl.cs: CloseType is now an virtual method, the default
14182 implementation just closes this type.
14184 2001-12-28 Ravi Pratap <ravi@ximian.com>
14186 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
14187 to PreserveSig by default. Also emit HideBySig on such methods.
14189 Basically, set the defaults to standard values.
14191 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
14192 argument, if candidate is better, it can't be worse than the best !
14194 (Invocation): Re-write bits to differentiate between methods being
14195 applicable in their expanded form and their normal form - for params
14198 Get rid of use_standard everywhere as only standard conversions are allowed
14199 in overload resolution.
14201 More spec conformance.
14203 2001-12-27 Miguel de Icaza <miguel@ximian.com>
14205 * driver.cs: Add --timestamp, to see where the compiler spends
14208 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
14209 `this' in static code.
14211 (SimpleName.DoResolve): Implement in terms of a helper function
14212 that allows static-references to be passed upstream to
14215 (Expression.ResolveWithSimpleName): Resolve specially simple
14216 names when called by MemberAccess to implement the special
14219 (Expression.ImplicitReferenceConversion): Handle conversions from
14220 Null to reference types before others, as Null's type is
14223 * expression.cs (Invocation.EmitCall): Handle the special case of
14224 calling methods declared on a reference type from a ValueType
14225 (Base classes System.Object and System.Enum)
14227 (MemberAccess.Resolve): Only perform lookups on Enumerations if
14228 the left hand side is a TypeExpr, not on every enumeration.
14230 (Binary.Resolve): If types are reference types, then do a cast to
14231 object on operators != and == of both arguments.
14233 * typemanager.cs (FindMembers): Extract instance and static
14234 members if requested.
14236 * interface.cs (PopulateProperty): Use void_type instead of null
14237 as the return type for the setter method.
14239 (PopulateIndexer): ditto.
14241 2001-12-27 Ravi Pratap <ravi@ximian.com>
14243 * support.cs (ReflectionParameters): Fix minor bug where we
14244 were examining the wrong parameter for the ParamArray attribute.
14246 Cope with requests for the type of the parameter at position
14247 greater than the params parameter's. We now return the element
14248 type of the params array as that makes more sense.
14250 * expression.cs (Invocation.IsParamsMethodApplicable): Update
14251 accordingly as we no longer have to extract the element type
14254 (Invocation.OverloadResolve): Update.
14256 2001-12-27 Miguel de Icaza <miguel@ximian.com>
14258 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
14259 against IEnumerator, test whether the return value is a descendant
14260 of the IEnumerator interface.
14262 * class.cs (Indexer.Define): Use an auxiliary method to implement
14263 the other bits of the method definition. Begin support for
14264 explicit interface implementation.
14266 (Property.DefineMethod): Use TypeManager.void_type instead of null
14267 for an empty return value.
14269 2001-12-26 Miguel de Icaza <miguel@ximian.com>
14271 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
14272 dealing with a FieldExpr which is composed of a FieldBuilder, in
14273 the code path we did extract the constant, but we should have
14274 obtained the underlying value to be able to cast it (otherwise we
14275 end up in an infinite loop, this is what Ravi was running into).
14277 (ArrayCreation.UpdateIndices): Arrays might be empty.
14279 (MemberAccess.ResolveMemberAccess): Add support for section
14280 14.5.4.1 that deals with the special case of E.I when E is a type
14281 and something else, that I can be a reference to a static member.
14283 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
14284 handle a particular array type to create byte blobs, it is just
14285 something we dont generate byteblobs for.
14287 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
14290 * location.cs (Push): remove the key from the hashtable that we
14291 are about to add. This happens for empty files.
14293 * driver.cs: Dispose files after we have parsed them.
14295 (tokenize): new function that only runs the tokenizer on its
14296 input, for speed testing.
14298 2001-12-26 Ravi Pratap <ravi@ximian.com>
14300 * class.cs (Event.Define): Define the private field only if there
14301 are no accessors defined.
14303 * expression.cs (ResolveMemberAccess): If there is no associated
14304 field with the event, that means we have an event defined with its
14305 own accessors and we should flag error cs0070 since transforming
14306 ourselves into a field is not valid in that case.
14308 * ecore.cs (SimpleName.DoResolve): Same as above.
14310 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
14311 and charset to sane values.
14313 2001-12-25 Ravi Pratap <ravi@ximian.com>
14315 * assign.cs (DoResolve): Perform check on events only if they
14316 are being accessed outside the declaring type.
14318 * cs-parser.jay (event_declarations): Update rules to correctly
14319 set the type of the implicit parameter etc.
14321 (add_accessor, remove_accessor): Set current local parameters.
14323 * expression.cs (Binary): For delegate addition and subtraction,
14324 cast the return value from the method into the appropriate delegate
14327 2001-12-24 Ravi Pratap <ravi@ximian.com>
14329 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
14330 of these as the workaround is unnecessary.
14332 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
14333 delegate data - none of that is needed at all.
14335 Re-write bits to extract the instance expression and the delegate method
14338 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
14341 * attribute.cs (ApplyAttributes): New method to take care of common tasks
14342 of attaching attributes instead of duplicating code everywhere.
14344 * everywhere : Update code to do attribute emission using the above method.
14346 2001-12-23 Miguel de Icaza <miguel@ximian.com>
14348 * expression.cs (IsParamsMethodApplicable): if there are not
14349 parameters, return immediately.
14351 * ecore.cs: The 0 literal can be implicity converted to an enum
14354 (SimpleName.DoResolve): First lookup the type, then lookup the
14357 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
14358 want to get its address. If the InstanceExpression is not
14359 addressable, store the result in a temporary variable, then get
14362 * codegen.cs: Only display 219 errors on warning level or above.
14364 * expression.cs (ArrayAccess): Make it implement the
14365 IMemoryLocation interface.
14367 (Binary.DoResolve): handle the operator == (object a, object b)
14368 and operator != (object a, object b) without incurring into a
14369 BoxedCast (because 5 != o should never be performed).
14371 Handle binary enumerator operators.
14373 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
14374 value type, otherwise use Ldelem_ref.
14376 Use precomputed names;
14378 (AddressOf): Implement address of
14380 * cs-parser.jay (labeled_statement): Fix recursive block
14381 addition by reworking the production.
14383 * expression.cs (New.DoEmit): New has a special case:
14385 If we are dealing with a ValueType, we have a few
14386 situations to deal with:
14388 * The target of New is a ValueType variable, that is
14389 easy, we just pass this as the variable reference
14391 * The target of New is being passed as an argument,
14392 to a boxing operation or a function that takes a
14395 In this case, we need to create a temporary variable
14396 that is the argument of New.
14399 2001-12-23 Ravi Pratap <ravi@ximian.com>
14401 * rootcontext.cs (LookupType): Check that current_type is not null before
14402 going about looking at nested types.
14404 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
14405 not implement the IAssignMethod interface any more.
14407 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
14408 where we tranform them into FieldExprs if they are being resolved from within
14409 the declaring type.
14411 * ecore.cs (SimpleName.DoResolve): Do the same here.
14413 * assign.cs (DoResolve, Emit): Clean up code considerably.
14415 * ../errors/bug10.cs : Add.
14417 * ../errors/cs0070.cs : Add.
14419 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
14421 * assign.cs : Get rid of EventIsLocal everywhere.
14423 2001-12-23 Miguel de Icaza <miguel@ximian.com>
14425 * ecore.cs (ConvertIntLiteral): finished the implementation.
14427 * statement.cs (SwitchLabel): Convert the value we are using as a
14428 key before looking up the table.
14430 2001-12-22 Miguel de Icaza <miguel@ximian.com>
14432 * codegen.cs (EmitTopBlock): Require a Location argument now.
14434 * cs-parser.jay (constructor_declarator): We need to setup
14435 current_local_parameters before we parse the
14436 opt_constructor_initializer, to allow the variables to be bound
14437 to the constructor arguments.
14439 * rootcontext.cs (LookupType): First lookup nested classes in our
14440 class and our parents before we go looking outside our class.
14442 * expression.cs (ConstantFold): Extract/debox the values at the
14445 * rootcontext.cs (EmitCode): Resolve the constants first before we
14446 resolve the types. This is not really needed, but it helps debugging.
14448 * statement.cs: report location.
14450 * cs-parser.jay: pass location to throw statement.
14452 * driver.cs: Small bug fix.
14454 * report.cs: Updated format to be 4-zero filled digits.
14456 2001-12-22 Ravi Pratap <ravi@ximian.com>
14458 * expression.cs (CheckIndices): Fix minor bug where the wrong
14459 variable was being referred to ;-)
14461 (DoEmit): Do not call EmitStaticInitializers when the
14462 underlying type is System.Object.
14464 2001-12-21 Ravi Pratap <ravi@ximian.com>
14466 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
14467 and do the usual workaround for SRE.
14469 * class.cs (MyEventBuilder.EventType): New member to get at the type
14470 of the event, quickly.
14472 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
14474 * assign.cs (Assign.DoResolve): Handle the case when the target
14475 is an EventExpr and perform the necessary checks.
14477 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
14480 (SimpleName.MemberStaticCheck): Include check for EventExpr.
14482 (EventExpr): Set the type in the constructor itself since we
14483 are meant to be born fully resolved.
14485 (EventExpr.Define): Revert code I wrote earlier.
14487 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
14488 instance expression is null. The instance expression is a This in that case
14489 or a null, depending on whether it is a static method or not.
14491 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
14492 refers to more than one method.
14494 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
14495 and accordingly flag errors.
14497 2001-12-21 Miguel de Icaza <miguel@ximian.com>
14499 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
14501 2001-12-22 Miguel de Icaza <miguel@ximian.com>
14503 * location.cs (ToString): Provide useful rutine.
14505 2001-12-21 Miguel de Icaza <miguel@ximian.com>
14507 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
14508 objects, return the actual integral boxed.
14510 * statement.cs (SwitchLabel): define an ILLabel for each
14513 (Switch.CheckSwitch): If the value is a Literal, extract
14514 the underlying literal.
14516 Also in the unused hashtable we had, add the SwitchLabel so we can
14517 quickly look this value up.
14519 * constant.cs: Implement a bunch of new constants. Rewrite
14520 Literal based on this. Made changes everywhere to adapt to this.
14522 * expression.cs (Expression.MakeByteBlob): Optimize routine by
14523 dereferencing array only once, and also copes with enumrations.
14525 bytes are two bytes wide, not one.
14527 (Cast): Perform constant conversions.
14529 * ecore.cs (TryImplicitIntConversion): Return literals instead of
14530 wrappers to the literals here.
14532 * expression.cs (DoNumericPromotions): long literals can converted
14533 to ulong implicity (this is taken care of elsewhere, but I was
14534 missing this spot).
14536 * ecore.cs (Expression.Literalize): Make the return type Literal,
14537 to improve type checking.
14539 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
14541 2001-12-20 Miguel de Icaza <miguel@ximian.com>
14543 * literal.cs: Revert code from ravi that checked the bounds. The
14544 bounds are sane by the definition of the type itself.
14546 * typemanager.cs: Fix implementation of ImplementsInterface. We
14547 need to actually look up in our parent hierarchy for interfaces
14550 * const.cs: Use the underlying type for enumerations
14552 * delegate.cs: Compute the basename for the delegate creation,
14553 that should fix the delegate test case, and restore the correct
14554 Type Lookup semantics in rootcontext
14556 * rootcontext.cs: Revert Ravi's last patch. The correct way of
14557 referencing a nested type with the Reflection API is using the "+"
14560 * cs-parser.jay: Do not require EOF token at the end.
14562 2001-12-20 Ravi Pratap <ravi@ximian.com>
14564 * rootcontext.cs (LookupType): Concatenate type names with
14565 a '.' instead of a '+' The test suite passes again.
14567 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
14568 field of the enumeration.
14570 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
14571 the case when the member is an EventExpr.
14573 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
14574 static has an associated instance expression.
14576 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
14578 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
14580 * class.cs (Event.Define): Register event and perform appropriate checks
14583 We define the Add and Remove methods even if the use provides none because
14584 in that case, we provide default implementations ourselves.
14586 Define a private field of the type of the event. This is done by the CSC compiler
14587 and we should be doing it too ;-)
14589 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
14590 More methods we use in code we generate.
14592 (multicast_delegate_type, delegate_type): Two separate types since the distinction
14595 (InitCoreTypes): Update accordingly for the above.
14597 * class.cs (Event.Emit): Generate code for default accessors that we provide
14599 (EmitDefaultMethod): Do the job in the above.
14601 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
14604 2001-12-20 Miguel de Icaza <miguel@ximian.com>
14606 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
14607 builders even if we were missing one.
14609 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
14610 pass the Basename as our class name instead of the Name. The
14611 basename will be correctly composed for us.
14613 * parameter.cs (Paramters): Now takes a Location argument.
14615 * decl.cs (DeclSpace.LookupType): Removed convenience function and
14616 make all the code call directly LookupType in RootContext and take
14617 this chance to pass the Location information everywhere.
14619 * Everywhere: pass Location information.
14621 2001-12-19 Miguel de Icaza <miguel@ximian.com>
14623 * class.cs (Constructor.Define): Updated way of detecting the
14624 length of the parameters.
14626 (TypeContainer.DefineType): Use basename as the type name for
14629 (TypeContainer.Define): Do not recursively define types here, as
14630 definition is taken care in order by the RootContext.
14632 * tree.cs: Keep track of namespaces in a per-file basis.
14634 * parameter.cs (Parameter.ComputeSignature): Update to use
14637 (Parameters.GetSignature): ditto.
14639 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
14640 instead of a TypeContainer.
14642 (Interface.SemanticAnalysis): Use `this' instead of our parent to
14643 resolve names. Because we need to be resolve in our context, not
14646 * driver.cs: Implement response files.
14648 * class.cs (TypeContainer.DefineType): If we are defined, do not
14649 redefine ourselves.
14651 (Event.Emit): Emit the code for add/remove handlers.
14652 (Event.Define): Save the MethodBuilders for add/remove.
14654 * typemanager.cs: Use pair here too.
14656 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
14657 DictionaryEntry requires the first argument to be non-null.
14659 (enum_declaration): Compute full name for registering the
14662 (delegate_declaration): Instead of using
14663 formal_parameter_list, use opt_formal_parameter_list as the list
14666 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
14667 (EventParsing): New property that controls whether `add' and
14668 `remove' are returned as tokens or identifiers (for events);
14670 2001-12-19 Ravi Pratap <ravi@ximian.com>
14672 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
14673 use MyEventBuilder only and let it wrap the real builder for us.
14675 (MyEventBuilder): Revamp constructor etc.
14677 Implement all operations that we perform on EventBuilder in precisely the same
14680 (FindMembers): Update to use the EventBuilder member.
14682 (Event.Emit): Update accordingly.
14684 2001-12-18 Ravi Pratap <ravi@ximian.com>
14686 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
14687 by calling the appropriate methods.
14689 (GetCustomAttributes): Make stubs as they cannot possibly do anything
14692 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
14694 2001-12-17 Ravi Pratap <ravi@ximian.com>
14696 * delegate.cs (Delegate.Populate): Check that the return type
14697 and various parameters types are indeed accessible.
14699 * class.cs (Constructor.Define): Same here.
14701 (Field.Define): Ditto.
14703 (Event.Define): Ditto.
14705 (Operator.Define): Check that the underlying Method defined itself
14706 correctly - so it's MethodBuilder should not be null.
14708 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
14709 expression happens to be null.
14711 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
14712 members but as of now we don't seem to be able to do anything really useful with it.
14714 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
14715 not the EventBuilder.
14717 2001-12-18 Miguel de Icaza <miguel@ximian.com>
14719 * cs-tokenizer.cs: Add support for defines.
14720 Add support for #if, #elif, #else, #endif
14722 (eval_var): evaluates a variable.
14723 (eval): stubbed for evaluating functions.
14725 * cs-parser.jay: Pass the defines information
14727 * driver.cs: Add --define command line option.
14729 * decl.cs: Move MemberCore here.
14731 Make it the base class for DeclSpace. This allows us to catch and
14732 report 108 and 109 for everything now.
14734 * class.cs (TypeContainer.Define): Extract all the members
14735 before populating and emit the warning 108 (new keyword required
14736 to override) instead of having each member implement this.
14738 (MemberCore.Define): New abstract method, we will be using this in
14739 the warning reporting engine in Populate.
14741 (Operator.Define): Adjust to new MemberCore protocol.
14743 * const.cs (Const): This does not derive from Expression, it is a
14744 temporary object we use to create fields, it is a MemberCore.
14746 * class.cs (Method.Define): Allow the entry point to be in a
14749 * driver.cs: Rewrite the argument handler to clean it up a bit.
14751 * rootcontext.cs: Made it just an auxiliary namespace feature by
14752 making everything static.
14754 * driver.cs: Adapt code to use RootContext type name instead of
14757 * delegate.cs: Remove RootContext argument.
14759 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
14762 * class.cs (Event.Define): The lookup can fail.
14764 * cs-tokenizer.cs: Begin implementation of pre-procesor.
14766 * expression.cs: Resolve the this instance before invoking the code.
14768 2001-12-17 Miguel de Icaza <miguel@ximian.com>
14770 * cs-parser.jay: Add a production in element_access that allows
14771 the thing to become a "type" reference. This way we can parse
14772 things like "(string [])" as a type.
14774 Note that this still does not handle the more complex rules of
14778 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
14780 * ecore.cs: (CopyNewMethods): new utility function used to
14781 assemble the list of methods from running FindMembers.
14783 (MemberLookup): Rework FindMembers so that
14785 2001-12-16 Miguel de Icaza <miguel@ximian.com>
14787 * class.cs (TypeContainer): Remove Delegates who fail to be
14790 * delegate.cs (Populate): Verify that we dont get null return
14791 values. TODO: Check for AsAccessible.
14793 * cs-parser.jay: Use basename to emit error 574 (destructor should
14794 have the same name as container class), not the full name.
14796 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
14797 possible representation.
14799 Also implements integer type suffixes U and L.
14801 2001-12-15 Miguel de Icaza <miguel@ximian.com>
14803 * expression.cs (ArrayCreation.DoResolve): We need to do the
14804 argument resolution *always*.
14806 * decl.cs: Make this hold the namespace. Hold the root context as
14808 (LookupType): Move here.
14810 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
14812 * location.cs (Row, Name): Fixed the code, it was always returning
14813 references to the first file.
14815 * interface.cs: Register properties defined through interfaces.
14817 * driver.cs: Add support for globbing on the command line
14819 * class.cs (Field): Make it derive from MemberCore as well.
14822 2001-12-15 Ravi Pratap <ravi@ximian.com>
14824 * class.cs (Event::Define): Check that the type of the event is a delegate
14825 type else flag error #66.
14827 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
14830 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
14831 values of EntryPoint, CharSet etc etc.
14833 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
14835 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
14836 be null and we should ignore this. I am not sure if this is really clean. Apparently,
14837 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
14838 which needs this to do its work.
14840 * ../errors/cs0066.cs : Add.
14842 2001-12-14 Miguel de Icaza <miguel@ximian.com>
14844 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
14847 * class.cs: (MethodSignature.MethodSignature): Removed hack that
14848 clears out the parameters field.
14849 (MemberSignatureCompare): Cleanup
14851 (MemberCore): New base class used to share code between MethodCore
14854 (RegisterRequiredImplementations) BindingFlags.Public requires
14855 either BindingFlags.Instace or Static. Use instance here.
14857 (Property): Refactored code to cope better with the full spec.
14859 * parameter.cs (GetParameterInfo): Return an empty array instead
14862 * class.cs (Property): Abstract or extern properties have no bodies.
14864 * parameter.cs (GetParameterInfo): return a zero-sized array.
14866 * class.cs (TypeContainer.MethodModifiersValid): Move all the
14867 method modifier validation to the typecontainer so we can reuse
14868 this on properties.
14870 (MethodCore.ParameterTypes): return an empty sized array of types.
14872 (Property.Define): Test property modifier validity.
14874 Add tests for sealed/override too.
14876 (Method.Emit): abstract or extern methods have no bodies.
14878 2001-12-14 Ravi Pratap <ravi@ximian.com>
14880 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
14883 (Method::Define, ::Emit): Modify accordingly.
14885 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
14887 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
14889 * makefile: Pass in /unsafe.
14891 2001-12-13 Miguel de Icaza <miguel@ximian.com>
14893 * class.cs (MakeKey): Kill routine.
14895 * class.cs (TypeContainer.Define): Correctly define explicit
14896 method implementations (they require the full interface name plus
14899 * typemanager.cs: Deply the PtrHashtable here and stop using the
14900 lame keys. Things work so much better.
14902 This of course broke everyone who depended on `RegisterMethod' to
14903 do the `test for existance' test. This has to be done elsewhere.
14905 * support.cs (PtrHashtable): A hashtable that avoid comparing with
14906 the object stupid Equals method (because, that like fails all over
14907 the place). We still do not use it.
14909 * class.cs (TypeContainer.SetRequiredInterface,
14910 TypeContainer.RequireMethods): Killed these two routines and moved
14911 all the functionality to RegisterRequiredImplementations.
14913 (TypeContainer.RegisterRequiredImplementations): This routine now
14914 registers all the implementations required in an array for the
14915 interfaces and abstract methods. We use an array of structures
14916 which can be computed ahead of time to reduce memory usage and we
14917 also assume that lookups are cheap as most classes will not
14918 implement too many interfaces.
14920 We also avoid creating too many MethodSignatures.
14922 (TypeContainer.IsInterfaceMethod): Update and optionally does not
14923 clear the "pending" bit if we find that there are problems with
14926 (TypeContainer.VerifyPendingMethods): Update to report errors of
14927 methods that look like implementations but are not.
14929 (TypeContainer.Define): Add support for explicit interface method
14932 2001-12-12 Miguel de Icaza <miguel@ximian.com>
14934 * typemanager.cs: Keep track of the parameters here instead of
14935 being a feature of the TypeContainer.
14937 * class.cs: Drop the registration of parameters here, as
14938 InterfaceMethods are also interface declarations.
14940 * delegate.cs: Register methods with the TypeManager not only with
14941 the TypeContainer. This code was buggy.
14943 * interface.cs: Full registation here.
14945 2001-12-11 Miguel de Icaza <miguel@ximian.com>
14947 * expression.cs: Remove reducer for binary expressions, it can not
14950 * const.cs: Put here the code that used to go into constant.cs
14952 * constant.cs: Put here the code for constants, this is a new base
14953 class for Literals.
14955 * literal.cs: Make Literal derive from Constant.
14957 2001-12-09 Miguel de Icaza <miguel@ximian.com>
14959 * statement.cs (Return.Emit): Report error 157 if the user
14960 attempts to return from a finally block.
14962 (Return.Emit): Instead of emitting a return, jump to the end of
14965 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
14966 LocalBuilder to store the result of the function. ReturnLabel is
14967 the target where we jump.
14970 2001-12-09 Radek Doulik <rodo@ximian.com>
14972 * cs-parser.jay: remember alias in current namespace
14974 * ecore.cs (SimpleName::DoResolve): use aliases for types or
14977 * class.cs (LookupAlias): lookup alias in my_namespace
14979 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
14981 (LookupAlias): lookup alias in this and if needed in parent
14984 2001-12-08 Miguel de Icaza <miguel@ximian.com>
14988 * rootcontext.cs: (ModuleBuilder) Made static, first step into
14989 making things static. I need this to avoid passing the
14990 TypeContainer when calling ParameterType.
14992 * support.cs (InternalParameters.ParameterType): Remove ugly hack
14993 that did string manipulation to compute the type and then call
14994 GetType. Use Parameter.ParameterType instead.
14996 * cs-tokenizer.cs: Consume the suffix for floating values.
14998 * expression.cs (ParameterReference): figure out whether this is a
14999 reference parameter or not. Kill an extra variable by computing
15000 the arg_idx during emission.
15002 * parameter.cs (Parameters.GetParameterInfo): New overloaded
15003 function that returns whether a parameter is an out/ref value or not.
15005 (Parameter.ParameterType): The type of the parameter (base,
15006 without ref/out applied).
15008 (Parameter.Resolve): Perform resolution here.
15009 (Parameter.ExternalType): The full type (with ref/out applied).
15011 * statement.cs (Using.Emit, Using.EmitExpression): Implement
15012 support for expressions on the using statement.
15014 2001-12-07 Miguel de Icaza <miguel@ximian.com>
15016 * statement.cs (Using.EmitLocalVariableDecls): Split the
15017 localvariable handling of the using statement.
15019 (Block.EmitMeta): Keep track of variable count across blocks. We
15020 were reusing slots on separate branches of blocks.
15022 (Try.Emit): Emit the general code block, we were not emitting it.
15024 Check the type of the declaration to be an IDisposable or
15025 something that can be implicity converted to it.
15027 Emit conversions if required.
15029 * ecore.cs (EmptyExpression): New utility class.
15030 (Expression.ImplicitConversionExists): New utility function.
15032 2001-12-06 Miguel de Icaza <miguel@ximian.com>
15034 * statement.cs (Using): Implement.
15036 * expression.cs (LocalVariableReference): Support read only variables.
15038 * statement.cs: Remove the explicit emit for the Leave opcode.
15039 (VariableInfo): Add a readonly field.
15041 2001-12-05 Miguel de Icaza <miguel@ximian.com>
15043 * ecore.cs (ConvCast): new class used to encapsulate the various
15044 explicit integer conversions that works in both checked and
15045 unchecked contexts.
15047 (Expression.ConvertNumericExplicit): Use new ConvCast class to
15048 properly generate the overflow opcodes.
15050 2001-12-04 Miguel de Icaza <miguel@ximian.com>
15052 * statement.cs: The correct type for the EmptyExpression is the
15053 element_type, not the variable type. Ravi pointed this out.
15055 2001-12-04 Ravi Pratap <ravi@ximian.com>
15057 * class.cs (Method::Define): Handle PInvoke methods specially
15058 by using DefinePInvokeMethod instead of the usual one.
15060 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
15061 above to do the task of extracting information and defining the method.
15063 2001-12-04 Ravi Pratap <ravi@ximian.com>
15065 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
15066 of the condition for string type.
15068 (Emit): Move that here.
15070 (ArrayCreation::CheckIndices): Keep string literals in their expression
15073 (EmitDynamicInitializers): Handle strings appropriately.
15075 2001-12-04 Miguel de Icaza <miguel@ximian.com>
15077 * codegen.cs (EmitContext): Replace multiple variables with a
15078 single pointer to the current Switch statement.
15080 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
15083 2001-12-03 Miguel de Icaza <miguel@ximian.com>
15087 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
15090 (Foreach.Emit): Foreach on arrays was not setting
15091 up the loop variables (for break/continue).
15093 (GotoCase): Semi-implented.
15095 2001-12-03 Ravi Pratap <ravi@ximian.com>
15097 * attribute.cs (CheckAttribute): Handle system attributes by using
15098 Attribute.GetAttributes to examine information we need.
15100 (GetValidPlaces): Same here.
15102 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
15104 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
15106 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
15108 (Method::Define): Set appropriate flags if we have a DllImport attribute.
15110 (Method::Emit): Handle the case when we are a PInvoke method.
15112 2001-12-03 Miguel de Icaza <miguel@ximian.com>
15114 * expression.cs: Use ResolveWithSimpleName on compound names.
15116 2001-12-02 Ravi Pratap <ravi@ximian.com>
15118 * constant.cs (EmitConstant): Make sure we resolve the associated expression
15119 before trying to reduce it.
15121 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
15123 * constant.cs (LookupConstantValue): Implement.
15125 (EmitConstant): Use the above in emitting the constant.
15127 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
15128 that are user-defined by doing a LookupConstantValue on them.
15130 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
15133 2001-11-29 Miguel de Icaza <miguel@ximian.com>
15135 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
15137 (BaseAccess.DoResolve): Implement.
15139 (MemberAccess.DoResolve): Split this routine into a
15140 ResolveMemberAccess routine that can be used independently
15142 2001-11-28 Miguel de Icaza <miguel@ximian.com>
15144 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
15145 As that share bits of the implementation. Is returns a boolean,
15146 while As returns the Type that is being probed.
15148 2001-12-01 Ravi Pratap <ravi@ximian.com>
15150 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
15151 instead of a Literal - much easier.
15153 (EnumInTransit): Remove - utterly useless :-)
15155 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
15157 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
15159 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
15160 chain when we have no associated expression.
15162 2001-11-30 Ravi Pratap <ravi@ximian.com>
15164 * constant.cs (Define): Use Location while reporting the errror.
15166 Also emit a warning when 'new' is used and there is no inherited
15169 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
15172 (LookupEnumValue): Implement to lookup an enum member's value and define it
15175 (Populate): Re-write accordingly to use the above routine.
15177 2001-11-27 Miguel de Icaza <miguel@ximian.com>
15179 * expression.cs (This): Fix prototype for DoResolveLValue to
15180 override the base class DoResolveLValue.
15182 * cs-parser.cs: Report errors cs574 and cs575 (destructor
15185 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
15186 (we need to load the address of the field here). This fixes
15189 (FieldExpr.DoResolveLValue): Call the DoResolve
15190 function to initialize the Instance expression.
15192 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
15193 correctly the GetEnumerator operation on a value type.
15195 * cs-parser.jay: Add more simple parsing error catches.
15197 * statement.cs (Switch): Add support for string switches.
15198 Handle null specially.
15200 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
15202 2001-11-28 Ravi Pratap <ravi@ximian.com>
15204 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
15206 (declare_local_constant): New helper function.
15208 * statement.cs (AddConstant): Keep a separate record of constants
15210 (IsConstant): Implement to determine if a variable is a constant.
15212 (GetConstantExpression): Implement.
15214 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
15216 * statement.cs (IsVariableDefined): Re-write.
15218 2001-11-27 Ravi Pratap <ravi@ximian.com>
15220 * class.cs (TypeContainer::FindMembers): Look for constants
15221 in the case when we are looking for MemberTypes.Field
15223 * expression.cs (MemberAccess::DoResolve): Check that in the
15224 case we are a FieldExpr and a Literal, we are not being accessed
15225 by an instance reference.
15227 * cs-parser.jay (local_constant_declaration): Implement.
15229 (declaration_statement): Implement for constant declarations.
15231 2001-11-26 Miguel de Icaza <miguel@ximian.com>
15233 * statement.cs (Switch): Catch double defaults.
15235 (Switch): More work on the switch() statement
15236 implementation. It works for integral values now, need to finish
15240 2001-11-24 Miguel de Icaza <miguel@ximian.com>
15242 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
15243 integer literals into other integer literals. To be used by
15246 2001-11-24 Ravi Pratap <ravi@ximian.com>
15248 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
15251 (EmitDynamicInitializers): Cope with the above since we extract data
15252 directly from ArrayData now.
15254 (ExpectInitializers): Keep track of whether initializers are mandatory
15257 (Bounds): Make it a hashtable to prevent the same dimension being
15258 recorded for every element in that dimension.
15260 (EmitDynamicInitializers): Fix bug which prevented the Set array method
15263 Also fix bug which was causing the indices to be emitted in the reverse
15266 2001-11-24 Miguel de Icaza <miguel@ximian.com>
15268 * expression.cs (ArrayCreation): Implement the bits that Ravi left
15269 unfinished. They do not work, because the underlying code is
15272 2001-11-22 Miguel de Icaza <miguel@ximian.com>
15274 * cs-parser.jay: Remove bogus fixme.
15276 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
15277 on Switch statement.
15279 2001-11-23 Ravi Pratap <ravi@ximian.com>
15281 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
15284 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
15285 parameter. Apparently, any expression is allowed.
15287 (ValidateInitializers): Update accordingly.
15289 (CheckIndices): Fix some tricky bugs thanks to recursion.
15291 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
15292 I was being completely brain-dead.
15294 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
15295 and re-write acordingly.
15297 (DelegateInvocation): Re-write accordingly.
15299 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
15301 (MakeByteBlob): Handle types more correctly.
15303 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
15304 initialization from expressions but it is incomplete because I am a complete
15307 2001-11-22 Miguel de Icaza <miguel@ximian.com>
15309 * statement.cs (If.Emit): Fix a bug that generated incorrect code
15310 on If. Basically, we have to return `true' (ie, we do return to
15311 our caller) only if both branches of the if return.
15313 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
15314 short-circuit operators, handle them as short circuit operators.
15316 (Cast.DoResolve): Resolve type.
15317 (Cast.Cast): Take an expression as the target type.
15319 * cs-parser.jay (cast_expression): Remove old hack that only
15320 allowed a limited set of types to be handled. Now we take a
15321 unary_expression and we resolve to a type during semantic
15324 Use the grammar productions from Rhys to handle casts (this is
15325 not complete like Rhys syntax yet, we fail to handle that corner
15326 case that C# has regarding (-x), but we will get there.
15328 2001-11-22 Ravi Pratap <ravi@ximian.com>
15330 * class.cs (EmitFieldInitializer): Take care of the case when we have a
15331 field which is an array type.
15333 * cs-parser.jay (declare_local_variables): Support array initialization too.
15335 * typemanager.cs (MakeKey): Implement.
15337 (everywhere): Use the above appropriately.
15339 * cs-parser.jay (for_statement): Update for array initialization while
15340 declaring variables.
15342 * ecore.cs : The error message was correct, it's the variable's names that
15343 were misleading ;-) Make the code more readable.
15345 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
15346 the correct type etc.
15348 (ConvertExplicit): Handle Enum types by examining the underlying type.
15350 2001-11-21 Ravi Pratap <ravi@ximian.com>
15352 * parameter.cs (GetCallingConvention): Always return
15353 CallingConventions.Standard for now.
15355 2001-11-22 Miguel de Icaza <miguel@ximian.com>
15357 * expression.cs (Binary.ResolveOperator): Update the values of `l'
15358 and `r' after calling DoNumericPromotions.
15360 * ecore.cs: Fix error message (the types were in the wrong order).
15362 * statement.cs (Foreach.ProbeCollectionType): Need to pass
15363 BindingFlags.Instance as well
15365 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
15366 implicit int literal conversion in an empty cast so that we
15367 propagate the right type upstream.
15369 (UnboxCast): new class used to unbox value types.
15370 (Expression.ConvertExplicit): Add explicit type conversions done
15373 (Expression.ImplicitNumericConversion): Oops, forgot to test for
15374 the target type before applying the implicit LongLiterals to ULong
15377 2001-11-21 Miguel de Icaza <miguel@ximian.com>
15379 * cs-parser.jay (for_statement): Reworked the way For works: now
15380 we declare manually any variables that are introduced in
15381 for_initializer to solve the problem of having out-of-band code
15382 emition (that is what got for broken).
15384 (declaration_statement): Perform the actual variable declaration
15385 that used to be done in local_variable_declaration here.
15387 (local_variable_declaration): Do not declare anything, just pass
15388 the information on a DictionaryEntry
15390 2001-11-20 Ravi Pratap <ravi@ximian.com>
15392 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
15393 re-write of the logic to now make it recursive.
15395 (UpdateIndices): Re-write accordingly.
15397 Store element data in a separate ArrayData list in the above methods.
15399 (MakeByteBlob): Implement to dump the array data into a byte array.
15401 2001-11-19 Ravi Pratap <ravi@ximian.com>
15403 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
15406 * constant.cs (Define): Implement.
15408 (EmitConstant): Re-write fully.
15410 Pass in location info.
15412 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
15415 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
15416 DictionaryEntry since we need location info too.
15418 (constant_declaration): Update accordingly.
15420 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
15421 code into another method : UpdateIndices.
15423 2001-11-18 Ravi Pratap <ravi@ximian.com>
15425 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
15426 some type checking etc.
15428 2001-11-17 Ravi Pratap <ravi@ximian.com>
15430 * expression.cs (ArrayCreation::ValidateInitializers): Implement
15431 bits to provide dimension info if the user skips doing that.
15433 Update second constructor to store the rank correctly.
15435 2001-11-16 Ravi Pratap <ravi@ximian.com>
15437 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
15438 and try to implement.
15440 * ../errors/cs0150.cs : Add.
15442 * ../errors/cs0178.cs : Add.
15444 2001-11-16 Miguel de Icaza <miguel@ximian.com>
15446 * statement.cs: Implement foreach on multi-dimensional arrays.
15448 * parameter.cs (Parameters.GetParameterByName): Also lookup the
15449 name of the params argument.
15451 * expression.cs: Use EmitStoreOpcode to get the right opcode while
15452 initializing the array.
15454 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
15455 we can use this elsewhere.
15457 * statement.cs: Finish implementation of foreach for single
15460 * cs-parser.jay: Use an out-of-band stack to pass information
15461 around, I wonder why I need this.
15463 foreach_block: Make the new foreach_block the current_block.
15465 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
15466 function used to return a static Parameters structure. Used for
15467 empty parameters, as those are created very frequently.
15469 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
15471 2001-11-15 Ravi Pratap <ravi@ximian.com>
15473 * interface.cs : Default modifier is private, not public. The
15474 make verify test passes again.
15476 2001-11-15 Ravi Pratap <ravi@ximian.com>
15478 * support.cs (ReflectionParameters): Fix logic to determine
15479 whether the last parameter is a params one. Test 9 passes again.
15481 * delegate.cs (Populate): Register the builders we define with
15482 RegisterParameterForBuilder. Test 19 passes again.
15484 * cs-parser.jay (property_declaration): Reference $6 instead
15485 of $$ to get at the location.
15487 (indexer_declaration): Similar stuff.
15489 (attribute): Ditto.
15491 * class.cs (Property): Register parameters for the Get and Set methods
15492 if they exist. Test 23 passes again.
15494 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
15495 call to EmitArguments as we are sure there aren't any params arguments.
15496 Test 32 passes again.
15498 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
15499 IndexOutOfRangeException.
15501 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
15502 Test 33 now passes again.
15504 2001-11-15 Miguel de Icaza <miguel@ximian.com>
15506 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
15507 broke a bunch of things. Will have to come up with a better way
15508 of tracking locations.
15510 * statement.cs: Implemented foreach for single dimension arrays.
15512 2001-11-09 Miguel de Icaza <miguel@ximian.com>
15514 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
15515 an error. This removes the lookup from the critical path.
15517 * cs-parser.jay: Removed use of temporary_loc, which is completely
15520 2001-11-14 Miguel de Icaza <miguel@ximian.com>
15522 * support.cs (ReflectionParameters.ParameterModifier): Report
15523 whether the argument is a PARAMS argument or not.
15525 * class.cs: Set the attribute `ParamArrayAttribute' on the
15526 parameter argument.
15528 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
15529 and cons_param_array_attribute (ConstructorInfo for
15530 ParamArrayAttribute).,
15532 * codegen.cs: Emit the return using the `Return' statement, that
15533 way we can report the error correctly for missing return values.
15535 * class.cs (Method.Emit): Clean up.
15537 * expression.cs (Argument.Resolve): Take another argument: the
15538 location where this argument is used. Notice that this is not
15539 part of the "Argument" class as to reduce the size of the
15540 structure (we know the approximate location anyways).
15542 Test if the argument is a variable-reference, if not, then
15543 complain with a 206.
15545 (Argument.Emit): Emit addresses of variables.
15547 (Argument.FullDesc): Simplify.
15549 (Invocation.DoResolve): Update for Argument.Resolve.
15551 (ElementAccess.DoResolve): ditto.
15553 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
15554 method should be virtual, as this method is always virtual.
15556 (NewDelegate.DoResolve): Update for Argument.Resolve.
15558 * class.cs (ConstructorInitializer.DoResolve): ditto.
15560 * attribute.cs (Attribute.Resolve): ditto.
15562 2001-11-13 Miguel de Icaza <miguel@ximian.com>
15564 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
15566 * expression.cs (ParameterReference): Drop IStackStorage and implement
15567 IAssignMethod instead.
15569 (LocalVariableReference): ditto.
15571 * ecore.cs (FieldExpr): Drop IStackStorage and implement
15572 IAssignMethod instead.
15574 2001-11-13 Miguel de Icaza <miguel@ximian.com>
15576 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
15577 enumerations that are used in heavily used structures derive from
15578 byte in a laughable and pathetic attempt to reduce memory usage.
15579 This is the kind of pre-optimzations that you should not do at
15580 home without adult supervision.
15582 * expression.cs (UnaryMutator): New class, used to handle ++ and
15583 -- separatedly from the other unary operators. Cleans up the
15584 code, and kills the ExpressionStatement dependency in Unary.
15586 (Unary): Removed `method' and `Arguments' from this class, making
15587 it smaller, and moving it all to SimpleCall, so I can reuse this
15588 code in other locations and avoid creating a lot of transient data
15589 strucutres when not required.
15591 * cs-parser.jay: Adjust for new changes.
15593 2001-11-11 Miguel de Icaza <miguel@ximian.com>
15595 * enum.cs (Enum.Populate): If there is a failure during
15598 * cs-parser.jay (opt_enum_base): we used to catch type errors
15599 here, but this is really incorrect. The type error should be
15600 catched during semantic analysis.
15602 2001-12-11 Ravi Pratap <ravi@ximian.com>
15604 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
15605 current_local_parameters as expected since I, in my stupidity, had forgotten
15608 * attribute.cs (GetValidPlaces): Fix stupid bug.
15610 * class.cs (Method::Emit): Perform check on applicability of attributes.
15612 (Constructor::Emit): Ditto.
15614 (Field::Emit): Ditto.
15616 (Field.Location): Store location information.
15618 (Property, Event, Indexer, Operator): Ditto.
15620 * cs-parser.jay (field_declaration): Pass in location for each field.
15622 * ../errors/cs0592.cs : Add.
15624 2001-11-12 Ravi Pratap <ravi@ximian.com>
15626 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
15628 (InitCoreTypes): Update accordingly.
15630 (RegisterAttrType, LookupAttr): Implement.
15632 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
15633 info about the same.
15635 (Resolve): Update to populate the above as necessary.
15637 (Error592): Helper.
15639 (GetValidPlaces): Helper to the above.
15641 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
15643 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
15645 2001-11-12 Ravi Pratap <ravi@ximian.com>
15647 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
15649 * ../errors/cs0617.cs : Add.
15651 2001-11-11 Ravi Pratap <ravi@ximian.com>
15653 * enum.cs (Emit): Rename to Populate to be more consistent with what
15654 we expect it to do and when exactly it is called.
15656 * class.cs, rootcontext.cs : Update accordingly.
15658 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
15659 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
15661 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
15663 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
15664 of a fieldinfo using the above, when dealing with a FieldBuilder.
15666 2001-11-10 Ravi Pratap <ravi@ximian.com>
15668 * ../errors/cs0031.cs : Add.
15670 * ../errors/cs1008.cs : Add.
15672 * ../errrors/cs0543.cs : Add.
15674 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
15677 (FindMembers): Implement.
15679 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
15680 enums and delegates too.
15682 (enum_types): Rename to builder_to_enum.
15684 (delegate_types): Rename to builder_to_delegate.
15686 * delegate.cs (FindMembers): Implement.
15688 2001-11-09 Ravi Pratap <ravi@ximian.com>
15690 * typemanager.cs (IsEnumType): Implement.
15692 * enum.cs (Emit): Re-write parts to account for the underlying type
15693 better and perform checking etc.
15695 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
15696 of the underlying type.
15698 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
15701 * enum.cs (error31): Helper to report error #31.
15703 * cs-parser.jay (enum_declaration): Store location of each member too.
15705 * enum.cs (member_to_location): New hashtable.
15707 (AddEnumMember): Update location hashtable.
15709 (Emit): Use the location of each member while reporting errors.
15711 2001-11-09 Miguel de Icaza <miguel@ximian.com>
15713 * cs-parser.jay: A for_initializer if is a
15714 local_variable_declaration really ammount to have an implicit
15715 block with the variable declaration and no initializer for for.
15717 * statement.cs (For.Emit): Cope with null initializers.
15719 This fixes the infinite loop on for initializers.
15721 2001-11-08 Miguel de Icaza <miguel@ximian.com>
15723 * enum.cs: More cleanup.
15725 * ecore.cs: Remove dead code.
15727 * class.cs (Property.Emit): More simplification.
15728 (Event.Emit): ditto.
15730 Reworked to have less levels of indentation.
15732 2001-11-08 Ravi Pratap <ravi@ximian.com>
15734 * class.cs (Property): Emit attributes.
15744 * enum.cs (Emit): Ditto.
15746 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
15749 * class.cs (Field, Event, etc.): Move attribute generation into the
15750 Emit method everywhere.
15752 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
15753 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
15754 as we had no way of defining nested enums !
15756 * rootcontext.cs : Adjust code accordingly.
15758 * typemanager.cs (AddEnumType): To keep track of enum types separately.
15760 2001-11-07 Ravi Pratap <ravi@ximian.com>
15762 * expression.cs (EvalConstantExpression): Move into ecore.cs
15764 * enum.cs (Enum): Rename some members and make them public and readonly
15765 according to our convention.
15767 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
15770 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
15772 (Enum::Emit): Write a simple version for now which doesn't try to compute
15773 expressions. I shall modify this to be more robust in just a while.
15775 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
15777 (TypeContainer::CloseType): Create the Enum types too.
15779 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
15781 * expression.cs (EvalConstantExpression): Get rid of completely.
15783 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
15784 user-defined values and other cases.
15786 (IsValidEnumLiteral): Helper function.
15788 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
15789 out there in the case we had a literal FieldExpr.
15791 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
15793 (Literalize): Revamp a bit to take two arguments.
15795 (EnumLiteral): New class which derives from Literal to wrap enum literals.
15797 2001-11-06 Ravi Pratap <ravi@ximian.com>
15799 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
15801 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
15803 (Resolve): Use the above to ensure we have proper initializers.
15805 2001-11-05 Ravi Pratap <ravi@ximian.com>
15807 * expression.cs (Expression::EvalConstantExpression): New method to
15808 evaluate constant expressions.
15810 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
15812 2001-11-07 Miguel de Icaza <miguel@ximian.com>
15814 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
15817 (Binary.ResolveOperator): Handle operator != (object a, object b)
15818 and operator == (object a, object b);
15820 (Binary.DoNumericPromotions): Indicate whether the numeric
15821 promotion was possible.
15823 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
15826 Made the ArrayAccess implement interface IAssignMethod instead of
15827 IStackStore as the order in which arguments are passed reflects
15830 * assign.cs: Instead of using expr.ExprClass to select the way of
15831 assinging, probe for the IStackStore/IAssignMethod interfaces.
15833 * typemanager.cs: Load InitializeArray definition.
15835 * rootcontext.cs (RootContext.MakeStaticData): Used to define
15836 static data that can be used to initialize arrays.
15838 2001-11-05 Miguel de Icaza <miguel@ximian.com>
15840 * expression.cs: Handle operator== and operator!= for booleans.
15842 (Conditioal.Reduce): Implement reducer for the ?: operator.
15844 (Conditional.Resolve): Implement dead code elimination.
15846 (Binary.Resolve): Catch string literals and return a new
15847 concatenated string.
15849 (Unary.Reduce): Implement reduction of unary expressions.
15851 * ecore.cs: Split out the expression core handling here.
15853 (Expression.Reduce): New method used to perform constant folding
15854 and CSE. This is needed to support constant-expressions.
15856 * statement.cs (Statement.EmitBoolExpression): Pass true and false
15857 targets, and optimize for !x.
15859 2001-11-04 Ravi Pratap <ravi@ximian.com>
15861 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
15862 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
15863 set custom atttributes.
15865 * literal.cs (Literal::GetValue): New abstract method to return the actual
15866 value of the literal, cast as an object.
15868 (*Literal): Implement GetValue method.
15870 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
15871 expressions to the arraylist but objects of type Argument.
15873 * class.cs (TypeContainer::Emit): Emit our attributes too.
15875 (Method::Emit, Constructor::Emit): Ditto.
15877 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
15878 to be ignoring earlier.
15880 2001-11-03 Ravi Pratap <ravi@ximian.com>
15882 * attribute.cs (AttributeSection::Define): Implement to do the business
15883 of constructing a CustomAttributeBuilder.
15885 (Attribute): New trivial class. Increases readability of code.
15887 * cs-parser.jay : Update accordingly.
15889 (positional_argument_list, named_argument_list, named_argument): New rules
15891 (attribute_arguments): Use the above so that we are more correct.
15893 2001-11-02 Ravi Pratap <ravi@ximian.com>
15895 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
15896 to perform all checks for a method with a params parameter.
15898 (Invocation::OverloadResolve): Update to use the above method and therefore
15899 cope correctly with params method invocations.
15901 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
15904 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
15905 constructors in our parent too because we can't afford to miss out on
15908 * attribute.cs (AttributeSection): New name for the class Attribute
15910 Other trivial changes to improve readability.
15912 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
15913 use the new class names.
15915 2001-11-01 Ravi Pratap <ravi@ximian.com>
15917 * class.cs (Method::Define): Complete definition for params types too
15919 (Indexer::Define): Ditto.
15921 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
15922 Cope everywhere with a request for info about the array parameter.
15924 2001-11-01 Ravi Pratap <ravi@ximian.com>
15926 * tree.cs (RecordNamespace): Fix up to check for the correct key.
15928 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
15929 local_variable_type to extract the string corresponding to the type.
15931 (local_variable_type): Fixup the action to use the new helper method.
15933 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
15936 * expression.cs : Clean out code which uses the above.
15938 2001-10-31 Ravi Pratap <ravi@ximian.com>
15940 * typemanager.cs (RegisterMethod): Check if we already have an existing key
15941 and bale out if necessary by returning a false.
15943 (RegisterProperty): Ditto.
15945 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
15946 and print out appropriate error messages.
15948 * interface.cs (everywhere): Ditto.
15950 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
15951 location to constructor.
15953 * class.cs (Property, Event, Indexer): Update accordingly.
15955 * ../errors/cs111.cs : Added.
15957 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
15958 of a method, as laid down by the spec.
15960 (Invocation::OverloadResolve): Use the above method.
15962 2001-10-31 Ravi Pratap <ravi@ximian.com>
15964 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
15965 now take a TypeContainer and a Parameters object.
15967 (ParameterData): Modify return type of ParameterModifier method to be
15968 Parameter.Modifier and not a string.
15970 (ReflectionParameters, InternalParameters): Update accordingly.
15972 * expression.cs (Argument::GetParameterModifier): Same here.
15974 * support.cs (InternalParameters::ParameterType): Find a better way of determining
15975 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
15976 symbol in it at all so maybe this is only for now.
15978 2001-10-30 Ravi Pratap <ravi@ximian.com>
15980 * support.cs (InternalParameters): Constructor now takes an extra argument
15981 which is the actual Parameters class.
15983 (ParameterDesc): Update to provide info on ref/out modifiers.
15985 * class.cs (everywhere): Update call to InternalParameters to pass in
15986 the second argument too.
15988 * support.cs (ParameterData): Add ParameterModifier, which is a method
15989 to return the modifier info [ref/out etc]
15991 (InternalParameters, ReflectionParameters): Implement the above.
15993 * expression.cs (Argument::ParameterModifier): Similar function to return
15994 info about the argument's modifiers.
15996 (Invocation::OverloadResolve): Update to take into account matching modifiers
15999 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
16000 a new SetFormalParameters object which we pass to InternalParameters.
16002 2001-10-30 Ravi Pratap <ravi@ximian.com>
16004 * expression.cs (NewArray): Merge into the ArrayCreation class.
16006 2001-10-29 Ravi Pratap <ravi@ximian.com>
16008 * expression.cs (NewArray): Merge classes NewBuiltinArray and
16009 NewUserdefinedArray into one as there wasn't much of a use in having
16012 * expression.cs (Argument): Change field's name to ArgType from Type.
16014 (Type): New readonly property which returns the proper type, taking into
16015 account ref/out modifiers.
16017 (everywhere): Adjust code accordingly for the above.
16019 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
16020 whether we are emitting for a ref or out parameter.
16022 * expression.cs (Argument::Emit): Use the above field to set the state.
16024 (LocalVariableReference::Emit): Update to honour the flag and emit the
16027 * parameter.cs (Attributes): Set the correct flags for ref parameters.
16029 * expression.cs (Argument::FullDesc): New function to provide a full desc.
16031 * support.cs (ParameterData): Add method ParameterDesc to the interface.
16033 (ReflectionParameters, InternalParameters): Implement the above method.
16035 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
16038 (Invocation::FullMethodDesc): Ditto.
16040 2001-10-29 Miguel de Icaza <miguel@ximian.com>
16042 * cs-parser.jay: Add extra production for the second form of array
16045 * expression.cs (ArrayCreation): Update to reflect the above
16048 * Small changes to prepare for Array initialization.
16050 2001-10-28 Miguel de Icaza <miguel@ximian.com>
16052 * typemanager.cs (ImplementsInterface): interface might be null;
16053 Deal with this problem;
16055 Also, we do store negative hits on the cache (null values), so use
16056 this instead of calling t.GetInterfaces on the type everytime.
16058 2001-10-28 Ravi Pratap <ravi@ximian.com>
16060 * typemanager.cs (IsBuiltinType): New method to help determine the same.
16062 * expression.cs (New::DoResolve): Get rid of array creation code and instead
16063 split functionality out into different classes.
16065 (New::FormArrayType): Move into NewBuiltinArray.
16067 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
16070 (NewBuiltinArray): New class to handle creation of built-in arrays.
16072 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
16073 account creation of one-dimensional arrays.
16075 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
16077 (NewUserdefinedArray::DoResolve): Implement.
16079 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
16081 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
16082 we maintain inside the TypeManager. This is necessary to perform lookups on the
16085 (LookupType): Update to perform GetType on the module builders too.
16087 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
16089 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
16091 2001-10-23 Ravi Pratap <ravi@ximian.com>
16093 * expression.cs (New::DoResolve): Implement guts of array creation.
16095 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
16097 2001-10-27 Miguel de Icaza <miguel@ximian.com>
16099 * expression.cs: Fix bug I introduced lsat night that broke
16102 (Expression.Resolve): Report a 246 error (can not resolve name)
16103 if we find a SimpleName in the stream.
16105 (Expression.ResolveLValue): Ditto.
16107 (Expression.ResolveWithSimpleName): This function is a variant of
16108 ResolveName, this one allows SimpleNames to be returned without a
16109 warning. The only consumer of SimpleNames is MemberAccess
16111 2001-10-26 Miguel de Icaza <miguel@ximian.com>
16113 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
16114 might arrive here. I have my doubts that this is correct.
16116 * statement.cs (Lock): Implement lock statement.
16118 * cs-parser.jay: Small fixes to support `lock' and `using'
16120 * cs-tokenizer.cs: Remove extra space
16122 * driver.cs: New flag --checked, allows to turn on integer math
16125 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
16126 Threading.Monitor.Exit
16128 2001-10-23 Miguel de Icaza <miguel@ximian.com>
16130 * expression.cs (IndexerAccess::DoResolveLValue): Set the
16131 Expression Class to be IndexerAccess.
16133 Notice that Indexer::DoResolve sets the eclass to Value.
16135 2001-10-22 Miguel de Icaza <miguel@ximian.com>
16137 * class.cs (TypeContainer::Emit): Emit code for indexers.
16139 * assign.cs (IAssignMethod): New interface implemented by Indexers
16140 and Properties for handling assignment.
16142 (Assign::Emit): Simplify and reuse code.
16144 * expression.cs (IndexerAccess, PropertyExpr): Implement
16145 IAssignMethod, clean up old code.
16147 2001-10-22 Ravi Pratap <ravi@ximian.com>
16149 * typemanager.cs (ImplementsInterface): New method to determine if a type
16150 implements a given interface. Provides a nice cache too.
16152 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
16155 (ConvertReferenceExplicit): Ditto.
16157 * delegate.cs (Delegate::Populate): Update to define the parameters on the
16158 various methods, with correct names etc.
16160 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
16161 Operator.UnaryNegation.
16163 * cs-parser.jay (operator_declarator): Be a little clever in the case where
16164 we have a unary plus or minus operator.
16166 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
16169 * everywhere : update accordingly.
16171 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
16174 * class.cs (Method::Define): For the case where we are implementing a method
16175 inherited from an interface, we need to set the MethodAttributes.Final flag too.
16176 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
16178 2001-10-21 Ravi Pratap <ravi@ximian.com>
16180 * interface.cs (FindMembers): Implement to work around S.R.E
16183 * typemanager.cs (IsInterfaceType): Implement.
16185 (FindMembers): Update to handle interface types too.
16187 * expression.cs (ImplicitReferenceConversion): Re-write bits which
16188 use IsAssignableFrom as that is not correct - it doesn't work.
16190 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
16191 and accordingly override EmitStatement.
16193 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
16194 using the correct logic :-)
16196 2001-10-19 Ravi Pratap <ravi@ximian.com>
16198 * ../errors/cs-11.cs : Add to demonstrate error -11
16200 2001-10-17 Miguel de Icaza <miguel@ximian.com>
16202 * assign.cs (Assign::Resolve): Resolve right hand side first, and
16203 then pass this as a hint to ResolveLValue.
16205 * expression.cs (FieldExpr): Add Location information
16207 (FieldExpr::LValueResolve): Report assignment to readonly
16210 (Expression::ExprClassFromMemberInfo): Pass location information.
16212 (Expression::ResolveLValue): Add new method that resolves an
16215 (Expression::DoResolveLValue): Default invocation calls
16218 (Indexers): New class used to keep track of indexers in a given
16221 (IStackStore): Renamed from LValue, as it did not really describe
16222 what this did. Also ResolveLValue is gone from this interface and
16223 now is part of Expression.
16225 (ElementAccess): Depending on the element access type
16227 * typemanager.cs: Add `indexer_name_type' as a Core type
16228 (System.Runtime.CompilerServices.IndexerNameAttribute)
16230 * statement.cs (Goto): Take a location.
16232 2001-10-18 Ravi Pratap <ravi@ximian.com>
16234 * delegate.cs (Delegate::VerifyDelegate): New method to verify
16235 if two delegates are compatible.
16237 (NewDelegate::DoResolve): Update to take care of the case when
16238 we instantiate a delegate from another delegate.
16240 * typemanager.cs (FindMembers): Don't even try to look up members
16241 of Delegate types for now.
16243 2001-10-18 Ravi Pratap <ravi@ximian.com>
16245 * delegate.cs (NewDelegate): New class to take care of delegate
16248 * expression.cs (New): Split the delegate related code out into
16249 the NewDelegate class.
16251 * delegate.cs (DelegateInvocation): New class to handle delegate
16254 * expression.cs (Invocation): Split out delegate related code into
16255 the DelegateInvocation class.
16257 2001-10-17 Ravi Pratap <ravi@ximian.com>
16259 * expression.cs (New::DoResolve): Implement delegate creation fully
16260 and according to the spec.
16262 (New::DoEmit): Update to handle delegates differently.
16264 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
16265 because of which we were printing out arguments in reverse order !
16267 * delegate.cs (VerifyMethod): Implement to check if the given method
16268 matches the delegate.
16270 (FullDelegateDesc): Implement.
16272 (VerifyApplicability): Implement.
16274 * expression.cs (Invocation::DoResolve): Update to accordingly handle
16275 delegate invocations too.
16277 (Invocation::Emit): Ditto.
16279 * ../errors/cs1593.cs : Added.
16281 * ../errors/cs1594.cs : Added.
16283 * delegate.cs (InstanceExpression, TargetMethod): New properties.
16285 2001-10-16 Ravi Pratap <ravi@ximian.com>
16287 * typemanager.cs (intptr_type): Core type for System.IntPtr
16289 (InitCoreTypes): Update for the same.
16291 (iasyncresult_type, asynccallback_type): Ditto.
16293 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
16296 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
16299 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
16300 the builders for the 4 members of a delegate type :-)
16302 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
16305 * expression.cs (New::DoResolve): Implement guts for delegate creation.
16307 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
16309 2001-10-15 Miguel de Icaza <miguel@ximian.com>
16311 * statement.cs (Break::Emit): Implement.
16312 (Continue::Emit): Implement.
16314 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
16315 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
16316 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
16317 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
16320 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
16321 properties that track the label for the current loop (begin of the
16322 loop and end of the loop).
16324 2001-10-15 Ravi Pratap <ravi@ximian.com>
16326 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
16327 use of emitting anything at all.
16329 * class.cs, rootcontext.cs : Get rid of calls to the same.
16331 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
16333 (Populate): Define the constructor correctly and set the implementation
16336 * typemanager.cs (delegate_types): New hashtable to hold delegates that
16339 (AddDelegateType): Implement.
16341 (IsDelegateType): Implement helper method.
16343 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
16345 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
16346 and accordingly handle it.
16348 * delegate.cs (Populate): Take TypeContainer argument.
16349 Implement bits to define the Invoke method. However, I still haven't figured out
16350 how to take care of the native int bit :-(
16352 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
16353 Qualify the name of the delegate, not its return type !
16355 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
16358 (StandardConversionExists): Checking for array types turns out to be recursive.
16360 (ConvertReferenceExplicit): Implement array conversion.
16362 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
16364 2001-10-12 Ravi Pratap <ravi@ximian.com>
16366 * cs-parser.jay (delegate_declaration): Store the fully qualified
16367 name as it is a type declaration.
16369 * delegate.cs (ReturnType, Name): Rename members to these. Make them
16372 (DefineDelegate): Renamed from Define. Does the same thing essentially,
16373 as TypeContainer::DefineType.
16375 (Populate): Method in which all the definition of the various methods (Invoke)
16378 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
16381 (CloseDelegate): Finally creates the delegate.
16383 * class.cs (TypeContainer::DefineType): Update to define delegates.
16384 (Populate, Emit and CloseType): Do the same thing here too.
16386 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
16387 delegates in all these operations.
16389 2001-10-14 Miguel de Icaza <miguel@ximian.com>
16391 * expression.cs: LocalTemporary: a new expression used to
16392 reference a temporary that has been created.
16394 * assign.cs: Handle PropertyAccess back here, so that we can
16395 provide the proper semantic access to properties.
16397 * expression.cs (Expression::ConvertReferenceExplicit): Implement
16398 a few more explicit conversions.
16400 * modifiers.cs: `NEW' modifier maps to HideBySig.
16402 * expression.cs (PropertyExpr): Make this into an
16403 ExpressionStatement, and support the EmitStatement code path.
16405 Perform get/set error checking, clean up the interface.
16407 * assign.cs: recognize PropertyExprs as targets, and if so, turn
16408 them into toplevel access objects.
16410 2001-10-12 Miguel de Icaza <miguel@ximian.com>
16412 * expression.cs: PropertyExpr::PropertyExpr: use work around the
16415 * typemanager.cs: Keep track here of our PropertyBuilders again to
16416 work around lameness in SRE.
16418 2001-10-11 Miguel de Icaza <miguel@ximian.com>
16420 * expression.cs (LValue::LValueResolve): New method in the
16421 interface, used to perform a second resolution pass for LValues.
16423 (This::DoResolve): Catch the use of this in static methods.
16425 (This::LValueResolve): Implement.
16427 (This::Store): Remove warning, assigning to `this' in structures
16430 (Invocation::Emit): Deal with invocation of
16431 methods on value types. We need to pass the address to structure
16432 methods rather than the object itself. (The equivalent code to
16433 emit "this" for structures leaves the entire structure on the
16434 stack instead of a pointer to it).
16436 (ParameterReference::DoResolve): Compute the real index for the
16437 argument based on whether the method takes or not a `this' pointer
16438 (ie, the method is static).
16440 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
16441 value types returned from functions when we need to invoke a
16442 method on the sturcture.
16445 2001-10-11 Ravi Pratap <ravi@ximian.com>
16447 * class.cs (TypeContainer::DefineType): Method to actually do the business of
16448 defining the type in the Modulebuilder or Typebuilder. This is to take
16449 care of nested types which need to be defined on the TypeBuilder using
16450 DefineNestedMethod.
16452 (TypeContainer::GetClassBases): Implement. Essentially the code from the
16453 methods in RootContext, only ported to be part of TypeContainer.
16455 (TypeContainer::GetInterfaceOrClass): Ditto.
16457 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
16459 * interface.cs (Interface::DefineInterface): New method. Does exactly
16460 what RootContext.CreateInterface did earlier, only it takes care of nested types
16463 (Interface::GetInterfaces): Move from RootContext here and port.
16465 (Interface::GetInterfaceByName): Same here.
16467 * rootcontext.cs (ResolveTree): Re-write.
16469 (PopulateTypes): Re-write.
16471 * class.cs (TypeContainer::Populate): Populate nested types too.
16472 (TypeContainer::Emit): Emit nested members too.
16474 * typemanager.cs (AddUserType): Do not make use of the FullName property,
16475 instead just use the name argument passed in as it is already fully
16478 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
16479 to TypeContainer mapping to see if a type is user-defined.
16481 * class.cs (TypeContainer::CloseType): Implement.
16483 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
16484 the default constructor.
16486 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
16489 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
16491 * interface.cs (CloseType): Create the type here.
16493 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
16496 Remove all the methods which are now in TypeContainer.
16498 2001-10-10 Ravi Pratap <ravi@ximian.com>
16500 * delegate.cs (Define): Re-write bits to define the delegate
16503 2001-10-10 Miguel de Icaza <miguel@ximian.com>
16505 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
16507 * expression.cs (ImplicitReferenceConversion): handle null as well
16508 as a source to convert to any reference type.
16510 * statement.cs (Return): Perform any implicit conversions to
16511 expected return type.
16513 Validate use of return statement.
16515 * codegen.cs (EmitContext): Pass the expected return type here.
16517 * class.cs (Method, Constructor, Property): Pass expected return
16518 type to EmitContext.
16520 2001-10-09 Miguel de Icaza <miguel@ximian.com>
16522 * expression.cs: Make DoResolve take an EmitContext instead of a
16525 Replaced `l' and `location' for `loc', for consistency.
16527 (Error, Warning): Remove unneeded Tc argument.
16529 * assign.cs, literal.cs, constant.cs: Update to new calling
16532 * codegen.cs: EmitContext now contains a flag indicating whether
16533 code is being generated in a static method or not.
16535 * cs-parser.jay: DecomposeQI, new function that replaces the old
16536 QualifiedIdentifier. Now we always decompose the assembled
16537 strings from qualified_identifier productions into a group of
16540 2001-10-08 Miguel de Icaza <miguel@ximian.com>
16542 * rootcontext.cs: Deal with field-less struct types correctly now
16543 by passing the size option to Define Type.
16545 * class.cs: Removed hack that created one static field.
16547 2001-10-07 Miguel de Icaza <miguel@ximian.com>
16549 * statement.cs: Moved most of the code generation here.
16551 2001-10-09 Ravi Pratap <ravi@ximian.com>
16553 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
16556 (ElementAccess): Remove useless bits for now - keep checks as the spec
16559 2001-10-08 Ravi Pratap <ravi@ximian.com>
16561 * expression.cs (ElementAccess::DoResolve): Remove my crap code
16562 and start performing checks according to the spec.
16564 2001-10-07 Ravi Pratap <ravi@ximian.com>
16566 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
16567 rank_specifiers instead.
16569 (rank_specifiers): Change the order in which the rank specifiers are stored
16571 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
16573 * expression.cs (ElementAccess): Implement the LValue interface too.
16575 2001-10-06 Ravi Pratap <ravi@ximian.com>
16577 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
16578 except that user defined conversions are not included.
16580 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
16581 perform the conversion of the return type, if necessary.
16583 (New::DoResolve): Check whether we are creating an array or an object
16584 and accordingly do the needful.
16586 (New::Emit): Same here.
16588 (New::DoResolve): Implement guts of array creation.
16590 (New::FormLookupType): Helper function.
16592 2001-10-07 Miguel de Icaza <miguel@ximian.com>
16594 * codegen.cs: Removed most of the code generation here, and move the
16595 corresponding code generation bits to the statement classes.
16597 Added support for try/catch/finalize and throw.
16599 * cs-parser.jay: Added support for try/catch/finalize.
16601 * class.cs: Catch static methods having the flags override,
16602 virtual or abstract.
16604 * expression.cs (UserCast): This user cast was not really doing
16605 what it was supposed to do. Which is to be born in fully resolved
16606 state. Parts of the resolution were being performed at Emit time!
16610 2001-10-05 Miguel de Icaza <miguel@ximian.com>
16612 * expression.cs: Implicity convert the result from UserCast.
16614 2001-10-05 Ravi Pratap <ravi@ximian.com>
16616 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
16617 prevented it from working correctly.
16619 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
16620 merely ConvertImplicit.
16622 2001-10-05 Miguel de Icaza <miguel@ximian.com>
16624 * typemanager.cs: Make the LookupTypeContainer function static,
16625 and not per-instance.
16627 * class.cs: Make static FindMembers (the one that takes a Type
16630 * codegen.cs: Add EmitForeach here.
16632 * cs-parser.jay: Make foreach a toplevel object instead of the
16633 inline expansion, as we need to perform semantic analysis on it.
16635 2001-10-05 Ravi Pratap <ravi@ximian.com>
16637 * expression.cs (Expression::ImplicitUserConversion): Rename to
16638 UserDefinedConversion.
16640 (Expression::UserDefinedConversion): Take an extra argument specifying
16641 whether we look for explicit user conversions too.
16643 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
16645 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
16647 (ExplicitUserConversion): Make it a call to UserDefinedConversion
16648 with the appropriate arguments.
16650 * cs-parser.jay (cast_expression): Record location too.
16652 * expression.cs (Cast): Record location info.
16654 (Expression::ConvertExplicit): Take location argument.
16656 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
16657 to determine if we are doing explicit conversions.
16659 (UserCast::Emit): Update accordingly.
16661 (Expression::ConvertExplicit): Report an error if everything fails.
16663 * ../errors/cs0030.cs : Add.
16665 2001-10-04 Miguel de Icaza <miguel@ximian.com>
16667 * modifiers.cs: If the ABSTRACT keyword is present, also set the
16668 virtual and newslot bits.
16670 * class.cs (TypeContainer::RegisterRequiredImplementations):
16671 Record methods we need.
16673 (TypeContainer::MakeKey): Helper function to make keys for
16674 MethodBases, since the Methodbase key is useless.
16676 (TypeContainer::Populate): Call RegisterRequiredImplementations
16677 before defining the methods.
16679 Create a mapping for method_builders_to_methods ahead of time
16680 instead of inside a tight loop.
16682 (::RequireMethods): Accept an object as the data to set into the
16683 hashtable so we can report interface vs abstract method mismatch.
16685 2001-10-03 Miguel de Icaza <miguel@ximian.com>
16687 * report.cs: Make all of it static.
16689 * rootcontext.cs: Drop object_type and value_type computations, as
16690 we have those in the TypeManager anyways.
16692 Drop report instance variable too, now it is a global.
16694 * driver.cs: Use try/catch on command line handling.
16696 Add --probe option to debug the error reporting system with a test
16699 * report.cs: Add support for exiting program when a probe
16700 condition is reached.
16702 2001-10-03 Ravi Pratap <ravi@ximian.com>
16704 * expression.cs (Binary::DoNumericPromotions): Fix the case when
16705 we do a forcible conversion regardless of type, to check if
16706 ForceConversion returns a null.
16708 (Binary::error19): Use location to report error.
16710 (Unary::error23): Use location here too.
16712 * ../errors/cs0019.cs : Check in.
16714 * ../errors/cs0023.cs : Check in.
16716 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
16717 case of a non-null MethodInfo object with a length of 0 !
16719 (Binary::ResolveOperator): Flag error if overload resolution fails to find
16720 an applicable member - according to the spec :-)
16721 Also fix logic to find members in base types.
16723 (Unary::ResolveOperator): Same here.
16725 (Unary::report23): Change name to error23 and make first argument a TypeContainer
16726 as I was getting thoroughly confused between this and error19 :-)
16728 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
16729 (::FindMostEncompassedType): Implement.
16730 (::FindMostEncompassingType): Implement.
16731 (::StandardConversionExists): Implement.
16733 (UserImplicitCast): Re-vamp. We now need info about most specific
16734 source and target types so that we can do the necessary conversions.
16736 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
16737 mathematical union with no duplicates.
16739 2001-10-03 Miguel de Icaza <miguel@ximian.com>
16741 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
16742 in order from base classes to child classes, so that we can in
16743 child classes look up in our parent for method names and
16744 attributes (required for handling abstract, virtual, new, override
16745 constructs: we need to instrospect our base class, and if we dont
16746 populate the classes in order, the introspection might be
16747 incorrect. For example, a method could query its parent before
16748 the parent has any methods and would determine that the parent has
16749 no abstract methods (while it could have had them)).
16751 (RootContext::CreateType): Record the order in which we define the
16754 2001-10-02 Miguel de Icaza <miguel@ximian.com>
16756 * class.cs (TypeContainer::Populate): Also method definitions can
16757 fail now, keep track of this.
16759 (TypeContainer::FindMembers): Implement support for
16760 DeclaredOnly/noDeclaredOnly flag.
16762 (Constructor::Emit) Return the ConstructorBuilder.
16764 (Method::Emit) Return the MethodBuilder.
16765 Check for abstract or virtual methods to be public.
16767 * rootcontext.cs (RootContext::CreateType): Register all the
16768 abstract methods required for the class to be complete and the
16769 interface methods that must be implemented.
16771 * cs-parser.jay: Report error 501 (method requires body if it is
16772 not marked abstract or extern).
16774 * expression.cs (TypeOf::Emit): Implement.
16776 * typemanager.cs: runtime_handle_type, new global type.
16778 * class.cs (Property::Emit): Generate code for properties.
16780 2001-10-02 Ravi Pratap <ravi@ximian.com>
16782 * expression.cs (Unary::ResolveOperator): Find operators on base type
16783 too - we now conform exactly to the spec.
16785 (Binary::ResolveOperator): Same here.
16787 * class.cs (Operator::Define): Fix minor quirk in the tests.
16789 * ../errors/cs0215.cs : Added.
16791 * ../errors/cs0556.cs : Added.
16793 * ../errors/cs0555.cs : Added.
16795 2001-10-01 Miguel de Icaza <miguel@ximian.com>
16797 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
16798 single integer which is really efficient
16800 2001-10-01 Ravi Pratap <ravi@ximian.com>
16802 * expression.cs (Expression::ImplicitUserConversion): Use location
16803 even in the case when we are examining True operators.
16805 * class.cs (Operator::Define): Perform extensive checks to conform
16806 with the rules for operator overloading in the spec.
16808 * expression.cs (Expression::ImplicitReferenceConversion): Implement
16809 some of the other conversions mentioned in the spec.
16811 * typemanager.cs (array_type): New static member for the System.Array built-in
16814 (cloneable_interface): For System.ICloneable interface.
16816 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
16817 we start resolving the tree and populating types.
16819 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
16821 2001-10-01 Miguel de Icaza <miguel@ximian.com>
16823 * expression.cs (Expression::ExprClassFromMemberInfo,
16824 Expression::Literalize): Create literal expressions from
16825 FieldInfos which are literals.
16827 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
16828 type casts, because they were wrong. The test suite in tests
16831 (ImplicitNumericConversion): ushort to ulong requires a widening
16834 Int32 constant to long requires widening cast as well.
16836 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
16837 for integers because the type on the stack is not i4.
16839 2001-09-30 Miguel de Icaza <miguel@ximian.com>
16841 * expression.cs (report118): require location argument.
16843 * parameter.cs: Do not dereference potential null value.
16845 * class.cs: Catch methods that lack the `new' keyword when
16846 overriding a name. Report warnings when `new' is used without
16847 anything being there to override.
16849 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
16851 * class.cs: Only add constructor to hashtable if it is non-null
16852 (as now constructors can fail on define).
16854 (TypeManager, Class, Struct): Take location arguments.
16856 Catch field instance initialization in structs as errors.
16858 accepting_filter: a new filter for FindMembers that is static so
16859 that we dont create an instance per invocation.
16861 (Constructor::Define): Catch errors where a struct constructor is
16864 * cs-parser.jay: Pass location information for various new
16867 * delegate.cs (Delegate): take a location argument.
16869 * driver.cs: Do not call EmitCode if there were problesm in the
16870 Definition of the types, as many Builders wont be there.
16872 * decl.cs (Decl::Decl): Require a location argument.
16874 * cs-tokenizer.cs: Handle properly hex constants that can not fit
16875 into integers, and find the most appropiate integer for it.
16877 * literal.cs: Implement ULongLiteral.
16879 * rootcontext.cs: Provide better information about the location of
16880 failure when CreateType fails.
16882 2001-09-29 Miguel de Icaza <miguel@ximian.com>
16884 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
16887 * expression.cs (Binary::CheckShiftArguments): Add missing type
16889 (Binary::ResolveOperator): Add type to the logical and and logical
16890 or, Bitwise And/Or and Exclusive Or code paths, it was missing
16893 (Binary::DoNumericPromotions): In the case where either argument
16894 is ulong (and most signed types combined with ulong cause an
16895 error) perform implicit integer constant conversions as well.
16897 2001-09-28 Miguel de Icaza <miguel@ximian.com>
16899 * expression.cs (UserImplicitCast): Method should always be
16901 (Invocation::BetterConversion): Simplified test for IntLiteral.
16903 (Expression::ImplicitNumericConversion): Split this routine out.
16904 Put the code that performs implicit constant integer conversions
16907 (Expression::Resolve): Become a wrapper around DoResolve so we can
16908 check eclass and type being set after resolve.
16910 (Invocation::Badness): Remove this dead function
16912 (Binary::ResolveOperator): Do not compute the expensive argumnets
16913 unless we have a union for it.
16915 (Probe::Emit): Is needs to do an isinst and then
16916 compare against null.
16918 (::CanConvert): Added Location argument. If the Location argument
16919 is null (Location.Null), then we do not report errors. This is
16920 used by the `probe' mechanism of the Explicit conversion. We do
16921 not want to generate an error for something that the user
16922 explicitly requested to be casted. But the pipeline for an
16923 explicit cast first tests for potential implicit casts.
16925 So for now, if the Location is null, it means `Probe only' to
16926 avoid adding another argument. Might have to revise this
16929 (ClassCast): New class used to type cast objects into arbitrary
16930 classes (used in Explicit Reference Conversions).
16932 Implement `as' as well.
16934 Reverted all the patches from Ravi below: they were broken:
16936 * The use of `level' as a mechanism to stop recursive
16937 invocations is wrong. That was there just to catch the
16938 bug with a strack trace but not as a way of addressing
16941 To fix the problem we have to *understand* what is going
16942 on and the interactions and come up with a plan, not
16943 just get things going.
16945 * The use of the type conversion cache that I proposed
16946 last night had an open topic: How does this work across
16947 protection domains. A user defined conversion might not
16948 be public in the location where we are applying the
16949 conversion, a different conversion might be selected
16950 (ie, private A->B (better) but public B->A (worse),
16951 inside A, A->B applies, but outside it, B->A will
16954 * On top of that (ie, even if the above is solved),
16955 conversions in a cache need to be abstract. Ie, `To
16956 convert from an Int to a Short use an OpcodeCast', not
16957 `To convert from an Int to a Short use the OpcodeCast on
16958 the variable 5' (which is what this patch was doing).
16960 2001-09-28 Ravi Pratap <ravi@ximian.com>
16962 * expression.cs (Invocation::ConversionExists): Re-write to use
16963 the conversion cache
16965 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
16966 cache all conversions done, not just user-defined ones.
16968 (Invocation::BetterConversion): The real culprit. Use ConversionExists
16969 to determine if a conversion exists instead of acutually trying to
16970 perform the conversion. It's faster too.
16972 (Expression::ConvertExplicit): Modify to use ConversionExists to check
16973 and only then attempt the implicit conversion.
16975 2001-09-28 Ravi Pratap <ravi@ximian.com>
16977 * expression.cs (ConvertImplicit): Use a cache for conversions
16978 already found. Check level of recursion and bail out if necessary.
16980 2001-09-28 Miguel de Icaza <miguel@ximian.com>
16982 * typemanager.cs (string_concat_string_string, string_concat_object_object):
16983 Export standard methods that we expect for string operations.
16985 * statement.cs (Block::UsageWarning): Track usage of variables and
16986 report the errors for not used variables.
16988 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
16991 2001-09-27 Miguel de Icaza <miguel@ximian.com>
16993 * codegen.cs: remove unnneded code
16995 * expression.cs: Removed BuiltinTypeAccess class
16997 Fix the order in which implicit conversions are
17000 The previous fixed dropped support for boxed conversions (adding a
17001 test to the test suite now)
17003 (UserImplicitCast::CanConvert): Remove test for source being null,
17004 that code is broken. We should not feed a null to begin with, if
17005 we do, then we should track the bug where the problem originates
17006 and not try to cover it up here.
17008 Return a resolved expression of type UserImplicitCast on success
17009 rather than true/false. Ravi: this is what I was talking about,
17010 the pattern is to use a static method as a "constructor" for
17013 Also, do not create arguments until the very last minute,
17014 otherwise we always create the arguments even for lookups that
17015 will never be performed.
17017 (UserImplicitCast::Resolve): Eliminate, objects of type
17018 UserImplicitCast are born in a fully resolved state.
17020 * typemanager.cs (InitCoreTypes): Init also value_type
17021 (System.ValueType).
17023 * expression.cs (Cast::Resolve): First resolve the child expression.
17025 (LValue): Add new method AddressOf to be used by
17028 Change the argument of Store to take an EmitContext instead of an
17029 ILGenerator, because things like FieldExpr need to be able to call
17030 their children expression to generate the instance code.
17032 (Expression::Error, Expression::Warning): Sugar functions for
17035 (Expression::MemberLookup): Accept a TypeContainer instead of a
17036 Report as the first argument.
17038 (Expression::ResolvePrimary): Killed. I still want to improve
17039 this as currently the code is just not right.
17041 (Expression::ResolveMemberAccess): Simplify, but it is still
17044 (Unary::Resolve): Catch errors in AddressOf operators.
17046 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
17047 index to a byte for the short-version, or the compiler will choose
17048 the wrong Emit call, which generates the wrong data.
17050 (ParameterReference::Emit, ::Store): same.
17052 (FieldExpr::AddressOf): Implement.
17054 * typemanager.cs: TypeManager: made public variable instead of
17057 * driver.cs: document --fatal.
17059 * report.cs (ErrorMessage, WarningMessage): new names for the old
17060 Error and Warning classes.
17062 * cs-parser.jay (member_access): Turn built-in access to types
17063 into a normal simplename
17065 2001-09-27 Ravi Pratap <ravi@ximian.com>
17067 * expression.cs (Invocation::BetterConversion): Fix to cope
17068 with q being null, since this was introducing a bug.
17070 * expression.cs (ConvertImplicit): Do built-in conversions first.
17072 2001-09-27 Ravi Pratap <ravi@ximian.com>
17074 * expression.cs (UserImplicitCast::Resolve): Fix bug.
17076 2001-09-27 Ravi Pratap <ravi@ximian.com>
17078 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
17079 I had introduced long ago (what's new ?).
17081 * expression.cs (UserImplicitCast::CanConvert): Static method to do
17082 the work of all the checking.
17083 (ConvertImplicit): Call CanConvert and only then create object if necessary.
17084 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
17086 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
17087 that is the right way.
17089 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
17090 overloading resolution. Use everywhere instead of cutting and pasting code.
17092 (Binary::ResolveOperator): Use MakeUnionSet.
17094 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
17095 we have to convert to bool types. Not complete yet.
17097 2001-09-27 Miguel de Icaza <miguel@ximian.com>
17099 * typemanager.cs (TypeManager::CSharpName): support ushort.
17101 * expression.cs (Expression::TryImplicitIntConversion): Attempts
17102 to provide an expression that performsn an implicit constant int
17103 conversion (section 6.1.6).
17104 (Expression::ConvertImplicitRequired): Reworked to include
17105 implicit constant expression conversions.
17107 (Expression::ConvertNumericExplicit): Finished.
17109 (Invocation::Emit): If InstanceExpression is null, then it means
17110 that we perform a call on this.
17112 2001-09-26 Miguel de Icaza <miguel@ximian.com>
17114 * expression.cs (Unary::Emit): Remove some dead code.
17115 (Probe): Implement Resolve and Emit for `is'.
17116 (Expression::ConvertImplicitRequired): Attempt to do constant
17117 expression conversions here. Maybe should be moved to
17118 ConvertImplicit, but I am not sure.
17119 (Expression::ImplicitLongConstantConversionPossible,
17120 Expression::ImplicitIntConstantConversionPossible): New functions
17121 that tell whether is it possible to apply an implicit constant
17122 expression conversion.
17124 (ConvertNumericExplicit): Started work on explicit numeric
17127 * cs-parser.jay: Update operator constants.
17129 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
17130 (Parameters::GetSignature): Hook up VerifyArgs here.
17131 (Parameters::VerifyArgs): Verifies that no two arguments have the
17134 * class.cs (Operator): Update the operator names to reflect the
17135 ones that the spec expects (as we are just stringizing the
17138 * expression.cs (Unary::ResolveOperator): Fix bug: Use
17139 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
17140 previous usage did only work for our methods.
17141 (Expression::ConvertImplicit): Handle decimal implicit numeric
17142 conversions as well.
17143 (Expression::InternalTypeConstructor): Used to invoke constructors
17144 on internal types for default promotions.
17146 (Unary::Emit): Implement special handling for the pre/post
17147 increment/decrement for overloaded operators, as they need to have
17148 the same semantics as the other operators.
17150 (Binary::ResolveOperator): ditto.
17151 (Invocation::ConversionExists): ditto.
17152 (UserImplicitCast::Resolve): ditto.
17154 2001-09-26 Ravi Pratap <ravi@ximian.com>
17156 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
17157 operator, return after emitting body. Regression tests pass again !
17159 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
17160 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
17161 (Invocation::OverloadResolve): Ditto.
17162 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
17164 * everywhere : update calls to the above methods accordingly.
17166 2001-09-26 Miguel de Icaza <miguel@ximian.com>
17168 * assign.cs (Assign): Make it inherit from ExpressionStatement.
17170 * expression.cs (ExpressionStatement): New base class used for
17171 expressions that can appear in statements, so that we can provide
17172 an alternate path to generate expression that do not leave a value
17175 (Expression::Emit, and all the derivatives): We no longer return
17176 whether a value is left on the stack or not. Every expression
17177 after being emitted leaves a single value on the stack.
17179 * codegen.cs (EmitContext::EmitStatementExpression): Use the
17180 facilties of ExpressionStatement if possible.
17182 * cs-parser.jay: Update statement_expression.
17184 2001-09-25 Miguel de Icaza <miguel@ximian.com>
17186 * driver.cs: Change the wording of message
17188 2001-09-25 Ravi Pratap <ravi@ximian.com>
17190 * expression.cs (Binary::ResolveOperator): Had forgottten to set
17191 the type of the expression to the return type of the method if
17192 we have an overloaded operator match ! The regression tests pass again !
17193 (Unary::ResolveOperator): Ditto.
17195 * expression.cs (Invocation::ConversionExists): Correct the member lookup
17196 to find "op_Implicit", not "implicit" ;-)
17197 (UserImplicitCast): New class to take care of user-defined implicit conversions.
17198 (ConvertImplicit, ForceConversion): Take TypeContainer argument
17200 * everywhere : Correct calls to the above accordingly.
17202 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
17203 (ConvertImplicit): Do user-defined conversion if it exists.
17205 2001-09-24 Miguel de Icaza <miguel@ximian.com>
17207 * assign.cs: track location.
17208 (Resolve): Use implicit conversions on assignment.
17210 * literal.cs: Oops. Not good, Emit of short access values should
17211 pass (Bytes) or the wrong argument will be selected.
17213 * expression.cs (Unary::Emit): Emit code for -expr.
17215 (Unary::ResolveOperator): Handle `Substract' for non-constants
17216 (substract from zero from the non-constants).
17217 Deal with Doubles as well.
17219 (Expression::ConvertImplicitRequired): New routine that reports an
17220 error if no implicit conversion exists.
17222 (Invocation::OverloadResolve): Store the converted implicit
17223 expressions if we make them
17225 2001-09-24 Ravi Pratap <ravi@ximian.com>
17227 * class.cs (ConstructorInitializer): Take a Location argument.
17228 (ConstructorBaseInitializer): Same here.
17229 (ConstructorThisInitializer): Same here.
17231 * cs-parser.jay : Update all calls accordingly.
17233 * expression.cs (Unary, Binary, New): Take location argument.
17234 Update accordingly everywhere.
17236 * cs-parser.jay : Update all calls to the above to take a location
17239 * class.cs : Ditto.
17241 2001-09-24 Ravi Pratap <ravi@ximian.com>
17243 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
17244 (Invocation::BetterConversion): Same here
17245 (Invocation::ConversionExists): Ditto.
17247 (Invocation::ConversionExists): Implement.
17249 2001-09-22 Ravi Pratap <ravi@ximian.com>
17251 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
17252 Also take an additional TypeContainer argument.
17254 * All over : Pass in TypeContainer as argument to OverloadResolve.
17256 * typemanager.cs (CSharpName): Update to check for the string type and return
17259 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
17262 2001-09-21 Ravi Pratap <ravi@ximian.com>
17264 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
17265 (Invocation::BetterFunction): Implement.
17266 (Invocation::BetterConversion): Implement.
17267 (Invocation::ConversionExists): Skeleton, no implementation yet.
17269 Okay, things work fine !
17271 2001-09-21 Miguel de Icaza <miguel@ximian.com>
17273 * typemanager.cs: declare and load enum_type, delegate_type and
17276 * expression.cs (Expression::Emit): Now emit returns a value that
17277 tells whether a value is left on the stack or not. This strategy
17278 might be reveted tomorrow with a mechanism that would address
17279 multiple assignments.
17280 (Expression::report118): Utility routine to report mismatches on
17283 (Unary::Report23): Report impossible type/operator combination
17286 (Unary::IsIncrementableNumber): Whether the type can be
17287 incremented or decremented with add.
17288 (Unary::ResolveOperator): Also allow enumerations to be bitwise
17290 (Unary::ResolveOperator): Implement ++, !, ~,
17292 (Invocation::Emit): Deal with new Emit convetion.
17294 * All Expression derivatives: Updated their Emit method to return
17295 whether they leave values on the stack or not.
17297 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
17298 stack for expressions that are statements.
17300 2001-09-20 Miguel de Icaza <miguel@ximian.com>
17302 * expression.cs (LValue): New interface. Must be implemented by
17304 (LocalVariableReference, ParameterReference, FieldExpr): Implement
17307 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
17308 interface for generating code, simplifies the code.
17310 2001-09-20 Ravi Pratap <ravi@ximian.com>
17312 * expression.cs (everywhere): Comment out return statements in ::Resolve
17313 methods to avoid the warnings.
17315 2001-09-20 Miguel de Icaza <miguel@ximian.com>
17317 * driver.cs (parse): Report error 2001 if we can not open the
17320 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
17323 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
17326 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
17327 otherwise nested blocks end up with the same index.
17329 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
17331 * expression.cs: Instead of having FIXMEs in the Resolve
17332 functions, throw exceptions so it is obvious that we are facing a
17335 * cs-parser.jay (invocation_expression): Pass Location information.
17337 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
17338 Use a basename for those routines because .NET does not like paths
17341 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
17344 2001-09-19 Miguel de Icaza <miguel@ximian.com>
17346 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
17347 are loading the correct data types (throws an exception if not).
17348 (TypeManager::InitCoreTypes): Use CoreLookupType
17350 * expression.cs (Unary::ResolveOperator): return the child
17351 expression for expressions which are just +expr.
17352 (Unary::ResolveOperator): Return negative literals for -LITERAL
17353 expressions (otherwise they are Unary {Literal}).
17354 (Invocation::Badness): Take into account `Implicit constant
17355 expression conversions'.
17357 * literal.cs (LongLiteral): Implement long literal class.
17358 (IntLiteral): export the `Value' of the intliteral.
17360 2001-09-19 Ravi Pratap <ravi@ximian.com>
17362 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
17364 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
17365 instead of 'Operator'
17367 * expression.cs (Binary::ResolveOperator): Update accordingly.
17368 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
17371 * cs-parser.jay (unary_expression): Update to use the new names.
17373 * gen-treedump.cs (GetUnary): Same here.
17375 * expression.cs (Unary::Resolve): Implement.
17376 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
17377 operators are found instead of making noise ;-)
17378 (Unary::ResolveOperator): New method to do precisely the same thing which
17379 Binary::ResolveOperator does for Binary expressions.
17380 (Unary.method, .Arguments): Add.
17381 (Unary::OperName): Implement.
17382 (Unary::ForceConversion): Copy and Paste !
17384 * class.cs (Operator::Define): Fix a small bug for the case when we have
17387 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
17388 for the inbuilt operators. Only overloading works for now ;-)
17390 2001-09-18 Miguel de Icaza <miguel@ximian.com>
17392 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
17393 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
17395 * expression.cs (This::Emit): Implement.
17396 (This::Resolve): Implement.
17397 (TypeOf:Resolve): Implement.
17398 (Expression::ResolveSimpleName): Add an implicit this to instance
17400 (MemberAccess::Resolve): Deal with Parameters and Fields.
17401 Bind instance variable to Field expressions.
17402 (FieldExpr::Instance): New field used to track the expression that
17403 represents the object instance.
17404 (FieldExpr::Resolve): Track potential errors from MemberLookup not
17406 (FieldExpr::Emit): Implement.
17408 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
17409 the last instruction contains a return opcode to avoid generating
17410 the last `ret' instruction (this generates correct code, and it is
17411 nice to pass the peverify output).
17413 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
17414 initializer for static and instance variables.
17415 (Constructor::Emit): Allow initializer to be null in the case of
17416 static constructors. Only emit initializer for instance
17419 (TypeContainer::FindMembers): Return a null array if there are no
17422 Also fix the code for the MemberTypes.Method branch, as it was not
17423 scanning that for operators (or tried to access null variables before).
17425 * assign.cs (Assign::Emit): Handle instance and static fields.
17429 * driver.cs: Stop compilation if there are parse errors.
17431 * cs-parser.jay (constructor_declaration): Provide default base
17432 initializer for non-static constructors.
17433 (constructor_declarator): Do not provide a default base
17434 initializers if none was specified.
17435 Catch the fact that constructors should not have parameters.
17437 * class.cs: Do not emit parent class initializers for static
17438 constructors, that should be flagged as an error.
17440 2001-09-18 Ravi Pratap <ravi@ximian.com>
17442 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
17443 Move back code into TypeContainer::Populate.
17445 2001-09-18 Ravi Pratap <ravi@ximian.com>
17447 * class.cs (TypeContainer::AddConstructor): Fix the check to
17448 compare against Name, not Basename.
17449 (Operator::OpType): Change Plus and Minus to Add and Subtract.
17451 * cs-parser.jay : Update accordingly.
17453 * class.cs (TypeContainer::FindMembers): For the case where we are searching
17454 for methods, don't forget to look into the operators too.
17455 (RegisterMethodBuilder): Helper method to take care of this for
17456 methods, constructors and operators.
17457 (Operator::Define): Completely revamp.
17458 (Operator.OperatorMethod, MethodName): New fields.
17459 (TypeContainer::Populate): Move the registering of builders into
17460 RegisterMethodBuilder.
17461 (Operator::Emit): Re-write.
17463 * expression.cs (Binary::Emit): Comment out code path to emit method
17464 invocation stuff for the case when we have a user defined operator. I am
17465 just not able to get it right !
17467 2001-09-17 Miguel de Icaza <miguel@ximian.com>
17469 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
17472 (Expression::MemberLookup): Provide a version that allows to
17473 specify the MemberTypes and BindingFlags.
17475 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
17476 so it was not fetching variable information from outer blocks.
17478 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
17479 Beforefieldinit as it was buggy.
17481 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
17482 that Ravi put here.
17484 * class.cs (Constructor::Emit): Only emit if block is not null.
17485 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
17486 deal with this by semantically definining it as if the user had
17489 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
17490 constructors as we now "emit" them at a higher level.
17492 (TypeContainer::DefineDefaultConstructor): Used to define the
17493 default constructors if none was provided.
17495 (ConstructorInitializer): Add methods Resolve and Emit.
17497 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
17499 2001-09-17 Ravi Pratap <ravi@ximian.com>
17501 * class.cs (TypeContainer::EmitDefaultConstructor): Register
17502 the default constructor builder with our hashtable for methodbuilders
17505 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
17506 and argument_count is 0 in which case we have a match.
17507 (Binary::ResolveOperator): More null checking and miscellaneous coding
17510 2001-09-17 Ravi Pratap <ravi@ximian.com>
17512 * rootcontext.cs (IsNameSpace): Compare against null.
17514 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
17516 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
17517 and Unary::Operator.
17519 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
17522 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
17523 we have overloaded operators.
17524 (Binary::ResolveOperator): Implement the part which does the operator overload
17527 * class.cs (Operator::Emit): Implement.
17528 (TypeContainer::Emit): Emit the operators we have too.
17530 * expression.cs (Binary::Emit): Update to emit the appropriate code for
17531 the case when we have a user-defined operator.
17533 2001-09-17 Miguel de Icaza <miguel@ximian.com>
17535 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
17537 2001-09-16 Ravi Pratap <ravi@ximian.com>
17539 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
17540 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
17541 (Constructor::Emit): Implement.
17542 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
17543 if we have no work to do.
17544 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
17547 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
17548 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
17550 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
17553 2001-09-15 Ravi Pratap <ravi@ximian.com>
17555 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
17557 (Tree::RecordNamespace): Method to do what the name says ;-)
17558 (Tree::Namespaces): Property to get at the namespaces hashtable.
17560 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
17563 * rootcontext.cs (IsNamespace): Fixed it :-)
17565 2001-09-14 Miguel de Icaza <miguel@ximian.com>
17567 * class.cs (TypeContainer::FindMembers): Add support for
17569 (MethodCore): New class that encapsulates both the shared aspects
17570 of a Constructor and a Method.
17571 (Method, Constructor): Factored pieces into MethodCore.
17573 * driver.cs: Added --fatal which makes errors throw exceptions.
17574 Load System assembly as well as part of the standard library.
17576 * report.cs: Allow throwing exceptions on errors for debugging.
17578 * modifiers.cs: Do not use `parent', instead use the real type
17579 container to evaluate permission settings.
17581 * class.cs: Put Ravi's patch back in. He is right, and we will
17582 have to cope with the
17584 2001-09-14 Ravi Pratap <ravi@ximian.com>
17586 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
17587 FamORAssem, not FamANDAssem.
17589 2001-09-14 Miguel de Icaza <miguel@ximian.com>
17591 * driver.cs: Added --parse option that only parses its input files
17594 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
17595 incorrect. IsTopLevel is not used to tell whether an object is
17596 root_types or not (that can be achieved by testing this ==
17597 root_types). But to see if this is a top-level *class* (not
17598 necessarly our "toplevel" container).
17600 2001-09-14 Ravi Pratap <ravi@ximian.com>
17602 * enum.cs (Enum::Define): Modify to call the Lookup method on the
17603 parent instead of a direct call to GetType.
17605 2001-09-14 Ravi Pratap <ravi@ximian.com>
17607 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
17608 Modifiers.TypeAttr. This should just be a call to that method.
17610 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
17611 object so that we can determine if we are top-level or not.
17613 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
17616 * enum.cs (Enum::Define): Ditto.
17618 * modifiers.cs (FieldAttr): Re-write.
17620 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
17621 (TypeContainer::HaveStaticConstructor): New property to provide access
17622 to precisely that info.
17624 * modifiers.cs (MethodAttr): Re-write.
17625 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
17627 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
17628 of top-level types as claimed.
17630 2001-09-13 Miguel de Icaza <miguel@ximian.com>
17632 * expression.cs (MemberLookup): Fruitless attempt to lookup
17633 constructors. Maybe I need to emit default constructors? That
17634 might be it (currently .NET emits this for me automatically).
17635 (Invocation::OverloadResolve): Cope with Arguments == null.
17636 (Invocation::EmitArguments): new function, shared by the new
17637 constructor and us.
17638 (Invocation::Emit): Handle static and instance methods. Emit
17639 proper call instruction for virtual or non-virtual invocations.
17640 (New::Emit): Implement.
17641 (New::Resolve): Implement.
17642 (MemberAccess:Resolve): Implement.
17643 (MethodGroupExpr::InstanceExpression): used conforming to the spec
17644 to track instances.
17645 (FieldExpr::Resolve): Set type.
17647 * support.cs: Handle empty arguments.
17649 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
17650 SimpleLookup): Auxiliary routines to help parse a qualifier
17653 Update qualifier_identifier rule.
17655 * codegen.cs: Removed debugging messages.
17657 * class.cs: Make this a global thing, this acts just as a "key" to
17658 objects that we might have around.
17660 (Populate): Only initialize method_builders_to_methods once.
17662 * expression.cs (PropertyExpr): Initialize type from the
17665 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
17666 Resolve pattern. Attempt to implicitly convert value to boolean.
17669 * expression.cs: Set the type for the int32/int32 argument case.
17670 (Binary::ResolveOperator): Set the return type to boolean for
17671 comparission operators
17673 * typemanager.cs: Remove debugging print code.
17675 (Invocation::Resolve): resolve type.
17677 * class.cs: Allocate a MemberInfo of the correct size, as the code
17678 elsewhere depends on the test to reflect the correct contents.
17680 (Method::) Keep track of parameters, due to System.Reflection holes
17682 (TypeContainer::Populate): Keep track of MethodBuilders to Method
17685 (TypeContainer::FindMembers): Use ArrayList and then copy an array
17686 of the exact size and return that.
17688 (Class::LookupMethodByBuilder): New function that maps
17689 MethodBuilders to its methods. Required to locate the information
17690 on methods because System.Reflection bit us again.
17692 * support.cs: New file, contains an interface ParameterData and
17693 two implementations: ReflectionParameters and InternalParameters
17694 used to access Parameter information. We will need to grow this
17697 * expression.cs (Invocation::GetParameterData): implement a cache
17698 and a wrapper around the ParameterData creation for methods.
17699 (Invocation::OverloadResolve): Use new code.
17701 2001-09-13 Ravi Pratap <ravi@ximian.com>
17703 * class.cs (TypeContainer::EmitField): Remove and move into
17704 (Field::Define): here and modify accordingly.
17705 (Field.FieldBuilder): New member.
17706 (TypeContainer::Populate): Update accordingly.
17707 (TypeContainer::FindMembers): Implement.
17709 2001-09-13 Miguel de Icaza <miguel@ximian.com>
17711 * statement.cs: (VariableInfo::VariableType): New field to be
17712 initialized with the full type once it is resolved.
17714 2001-09-12 Miguel de Icaza <miguel@ximian.com>
17716 * parameter.cs (GetParameterInfo): Use a type cache to compute
17717 things only once, and to reuse this information
17719 * expression.cs (LocalVariableReference::Emit): Implement.
17720 (OpcodeCast::Emit): fix.
17722 (ParameterReference::Resolve): Implement.
17723 (ParameterReference::Emit): Implement.
17725 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
17726 that are expressions need to stay as Expressions.
17728 * typemanager.cs (CSharpName): Returns the C# name of a type if
17731 * expression.cs (Expression::ConvertImplicit): New function that
17732 implements implicit type conversions.
17734 (Expression::ImplicitReferenceConversion): Implements implicit
17735 reference conversions.
17737 (EmptyCast): New type for transparent casts.
17739 (OpcodeCast): New type for casts of types that are performed with
17740 a sequence of bytecodes.
17742 (BoxedCast): New type used for casting value types into reference
17743 types. Emits a box opcode.
17745 (Binary::DoNumericPromotions): Implements numeric promotions of
17746 and computation of the Binary::Type.
17748 (Binary::EmitBranchable): Optimization.
17750 (Binary::Emit): Implement code emission for expressions.
17752 * typemanager.cs (TypeManager): Added two new core types: sbyte
17755 2001-09-12 Ravi Pratap <ravi@ximian.com>
17757 * class.cs (TypeContainer::FindMembers): Method which does exactly
17758 what Type.FindMembers does, only we don't have to use reflection. No
17759 implementation yet.
17761 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
17762 typecontainer objects as we need to get at them.
17763 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
17765 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
17766 typecontainer object.
17768 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
17769 of just a Report object.
17771 2001-09-11 Ravi Pratap <ravi@ximian.com>
17773 * class.cs (Event::Define): Go back to using the prefixes "add_" and
17775 (TypeContainer::Populate): Now define the delegates of the type too.
17776 (TypeContainer.Delegates): Property to access the list of delegates defined
17779 * delegates.cs (Delegate::Define): Implement partially.
17781 * modifiers.cs (TypeAttr): Handle more flags.
17783 2001-09-11 Ravi Pratap <ravi@ximian.com>
17785 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
17787 (Operator::Define): Re-write logic to get types by using the LookupType method
17788 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
17789 (Indexer::Define): Ditto.
17790 (Event::Define): Ditto.
17791 (Property::Define): Ditto.
17793 2001-09-10 Ravi Pratap <ravi@ximian.com>
17795 * class.cs (TypeContainer::Populate): Now define operators too.
17796 (TypeContainer.Operators): New property to access the list of operators
17798 (Operator.OperatorMethodBuilder): New member to hold the method builder
17799 for the operator we are defining.
17800 (Operator::Define): Implement.
17802 2001-09-10 Ravi Pratap <ravi@ximian.com>
17804 * class.cs (Event::Define): Make the prefixes of the accessor methods
17805 addOn_ and removeOn_
17807 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
17808 of the location being passed in too. Ideally, this should go later since all
17809 error reporting should be done through the Report object.
17811 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
17812 (Populate): Iterate thru the indexers we have and define them too.
17813 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
17814 for the get and set accessors.
17815 (Indexer::Define): Implement.
17817 2001-09-09 Miguel de Icaza <miguel@ximian.com>
17819 * expression.cs (Binary::Resolve): Beginning of it. I scratched
17820 my previous implementation, did not work.
17822 * typemanager.cs: Add a couple of missing types (the longs).
17824 * literal.cs: Use TypeManager.bool_type instead of getting it.
17826 * expression.cs (EventExpr): New kind of expressions.
17827 (Expressio::ExprClassFromMemberInfo): finish
17829 2001-09-08 Miguel de Icaza <miguel@ximian.com>
17831 * assign.cs: Emit stores to static fields differently.
17833 2001-09-08 Ravi Pratap <ravi@ximian.com>
17835 * Merge in changes and adjust code to tackle conflicts. Backed out my
17836 code in Assign::Resolve ;-)
17838 2001-09-08 Ravi Pratap <ravi@ximian.com>
17840 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
17841 instead Report.Error and also pass in the location.
17842 (CSharpParser::Lexer): New readonly property to return the reference
17843 to the Tokenizer object.
17844 (declare_local_variables): Use Report.Error with location instead of plain
17848 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
17849 (Operator.CheckBinaryOperator): Ditto.
17851 * cs-parser.jay (operator_declarator): Update accordingly.
17853 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
17854 (CheckBinaryOperator): Same here.
17856 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
17857 on the name without any prefixes of namespace names etc. This is because we
17858 already might have something already fully qualified like
17859 'System.Console.WriteLine'
17861 * assign.cs (Resolve): Begin implementation. Stuck ;-)
17863 2001-09-07 Ravi Pratap <ravi@ximian.com>
17865 * cs-tokenizer.cs (location): Return a string which also contains
17868 * expression.cs (ElementAccess): New class for expressions of the
17869 type 'element access.'
17870 (BaseAccess): New class for expressions of the type 'base access.'
17871 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
17874 * cs-parser.jay (element_access): Implement action.
17875 (base_access): Implement actions.
17876 (checked_expression, unchecked_expression): Implement.
17878 * cs-parser.jay (local_variable_type): Correct and implement.
17879 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
17881 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
17883 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
17884 name and the specifiers.
17886 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
17888 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
17889 making them all public ;-)
17891 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
17894 2001-09-07 Miguel de Icaza <miguel@ximian.com>
17896 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
17898 (FieldExpr, PropertyExprs): New resolved expressions.
17899 (SimpleName::MemberStaticCheck): Perform static checks for access
17900 to non-static fields on static methods. Maybe this should be
17901 generalized for MemberAccesses.
17902 (SimpleName::ResolveSimpleName): More work on simple name
17905 * cs-parser.jay (primary_expression/qualified_identifier): track
17906 the parameter index.
17908 * codegen.cs (CodeGen::Save): Catch save exception, report error.
17909 (EmitContext::EmitBoolExpression): Chain to expression generation
17910 instead of temporary hack.
17911 (::EmitStatementExpression): Put generic expression code generation.
17913 * assign.cs (Assign::Emit): Implement variable assignments to
17914 local variables, parameters and fields.
17916 2001-09-06 Miguel de Icaza <miguel@ximian.com>
17918 * statement.cs (Block::GetVariableInfo): New method, returns the
17919 VariableInfo for a variable name in a block.
17920 (Block::GetVariableType): Implement in terms of GetVariableInfo
17922 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
17923 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
17925 2001-09-06 Ravi Pratap <ravi@ximian.com>
17927 * cs-parser.jay (operator_declaration): Continue on my quest : update
17928 to take attributes argument.
17929 (event_declaration): Ditto.
17930 (enum_declaration): Ditto.
17931 (indexer_declaration): Ditto.
17933 * class.cs (Operator::Operator): Update constructor accordingly.
17934 (Event::Event): Ditto.
17936 * delegate.cs (Delegate::Delegate): Same here.
17938 * enum.cs (Enum::Enum): Same here.
17940 2001-09-05 Ravi Pratap <ravi@ximian.com>
17942 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
17944 * ../tests/cs0658.cs : New file to demonstrate error 0658.
17946 * attribute.cs (Attributes): New class to encapsulate all attributes which were
17947 being passed around as an arraylist.
17948 (Attributes::AddAttribute): Method to add attribute sections.
17950 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
17951 (struct_declaration): Update accordingly.
17952 (constant_declaration): Update.
17953 (field_declaration): Update.
17954 (method_header): Update.
17955 (fixed_parameter): Update.
17956 (parameter_array): Ditto.
17957 (property_declaration): Ditto.
17958 (destructor_declaration): Ditto.
17960 * class.cs (Struct::Struct): Update constructors accordingly.
17961 (Class::Class): Ditto.
17962 (Field::Field): Ditto.
17963 (Method::Method): Ditto.
17964 (Property::Property): Ditto.
17965 (TypeContainer::OptAttribute): update property's return type.
17967 * interface.cs (Interface.opt_attributes): New member.
17968 (Interface::Interface): Update to take the extra Attributes argument.
17970 * parameter.cs (Parameter::Parameter): Ditto.
17972 * constant.cs (Constant::Constant): Ditto.
17974 * interface.cs (InterfaceMemberBase): New OptAttributes field.
17975 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
17976 the attributes as a parameter.
17977 (InterfaceProperty): Update constructor call.
17978 (InterfaceEvent): Ditto.
17979 (InterfaceMethod): Ditto.
17980 (InterfaceIndexer): Ditto.
17982 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
17983 pass the attributes too.
17984 (interface_event_declaration): Ditto.
17985 (interface_property_declaration): Ditto.
17986 (interface_method_declaration): Ditto.
17987 (interface_declaration): Ditto.
17989 2001-09-05 Miguel de Icaza <miguel@ximian.com>
17991 * class.cs (Method::Define): Track the "static Main" definition to
17992 create an entry point.
17994 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
17995 EntryPoint if we find it.
17997 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
17998 (EmitContext::ig): Make this variable public.
18000 * driver.cs: Make the default output file be the first file name
18001 with the .exe extension.
18003 Detect empty compilations
18005 Handle various kinds of output targets. Handle --target and
18006 rename -t to --dumper.
18008 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
18009 methods inherited from Expression return now an Expression. This
18010 will is used during the tree rewriting as we resolve them during
18013 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
18014 the spec. Missing entirely is the information about
18015 accessability of elements of it.
18017 (Expression::ExprClassFromMemberInfo): New constructor for
18018 Expressions that creates a fully initialized Expression based on
18019 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
18022 (Invocation::Resolve): Begin implementing resolution of invocations.
18024 * literal.cs (StringLiteral): Implement Emit.
18026 2001-09-05 Ravi Pratap <ravi@ximian.com>
18028 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
18031 2001-09-04 Ravi Pratap <ravi@ximian.com>
18033 * cs-parser.jay (attribute_arguments): Implement actions.
18034 (attribute): Fix bug in production. Implement action.
18035 (attribute_list): Implement.
18036 (attribute_target): Implement.
18037 (attribute_target_specifier, opt_target_specifier): Implement
18038 (CheckAttributeTarget): New method to check if the attribute target
18040 (attribute_section): Implement.
18041 (opt_attributes): Implement.
18043 * attribute.cs : New file to handle attributes.
18044 (Attribute): Class to hold attribute info.
18046 * cs-parser.jay (opt_attribute_target_specifier): Remove production
18047 (attribute_section): Modify production to use 2 different rules to
18048 achieve the same thing. 1 s/r conflict down !
18049 Clean out commented, useless, non-reducing dimension_separator rules.
18051 * class.cs (TypeContainer.attributes): New member to hold list
18052 of attributes for a type.
18053 (Struct::Struct): Modify to take one more argument, the attribute list.
18054 (Class::Class): Ditto.
18055 (Field::Field): Ditto.
18056 (Method::Method): Ditto.
18057 (Property::Property): Ditto.
18059 * cs-parser.jay (struct_declaration): Update constructor call to
18060 pass in the attributes too.
18061 (class_declaration): Ditto.
18062 (constant_declaration): Ditto.
18063 (field_declaration): Ditto.
18064 (method_header): Ditto.
18065 (fixed_parameter): Ditto.
18066 (parameter_array): Ditto.
18067 (property_declaration): Ditto.
18069 * constant.cs (Constant::Constant): Update constructor similarly.
18070 Use System.Collections.
18072 * parameter.cs (Parameter::Parameter): Update as above.
18074 2001-09-02 Ravi Pratap <ravi@ximian.com>
18076 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
18077 (TypeContainer.delegates): New member to hold list of delegates.
18079 * cs-parser.jay (delegate_declaration): Implement the action correctly
18080 this time as I seem to be on crack ;-)
18082 2001-09-02 Miguel de Icaza <miguel@ximian.com>
18084 * rootcontext.cs (RootContext::IsNamespace): new function, used to
18085 tell whether an identifier represents a namespace.
18087 * expression.cs (NamespaceExpr): A namespace expression, used only
18088 temporarly during expression resolution.
18089 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
18090 utility functions to resolve names on expressions.
18092 2001-09-01 Miguel de Icaza <miguel@ximian.com>
18094 * codegen.cs: Add hook for StatementExpressions.
18096 * class.cs: Fix inverted test for static flag in methods.
18098 2001-09-02 Ravi Pratap <ravi@ximian.com>
18100 * class.cs (Operator::CheckUnaryOperator): Correct error number used
18101 to make it coincide with MS' number.
18102 (Operator::CheckBinaryOperator): Ditto.
18104 * ../errors/errors.txt : Remove error numbers added earlier.
18106 * ../errors/cs1019.cs : Test case for error # 1019
18108 * ../errros/cs1020.cs : Test case for error # 1020
18110 * cs-parser.jay : Clean out commented cruft.
18111 (dimension_separators, dimension_separator): Comment out. Ostensibly not
18112 used anywhere - non-reducing rule.
18113 (namespace_declarations): Non-reducing rule - comment out.
18115 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
18116 with TypeContainer::AddEnum.
18118 * delegate.cs : New file for delegate handling classes.
18119 (Delegate): Class for declaring delegates.
18121 * makefile : Update.
18123 * cs-parser.jay (delegate_declaration): Implement.
18125 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
18127 * class.cs (Event::Define): Implement.
18128 (Event.EventBuilder): New member.
18130 * class.cs (TypeContainer::Populate): Update to define all enums and events
18132 (Events): New property for the events arraylist we hold. Shouldn't we move to using
18133 readonly fields for all these cases ?
18135 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
18137 * class.cs (Property): Revamp to use the convention of making fields readonly.
18138 Accordingly modify code elsewhere.
18140 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
18141 the Define method of the Property class.
18143 * class.cs : Clean up applied patch and update references to variables etc. Fix
18145 (TypeContainer::Populate): Update to define all the properties we have. Also
18146 define all enumerations.
18148 * enum.cs (Define): Implement.
18150 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
18152 * cs-parser.jay (overloadable_operator): The semantic value is an
18153 enum of the Operator class.
18154 (operator_declarator): Implement actions.
18155 (operator_declaration): Implement.
18157 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
18158 validity of definitions.
18159 (Operator::CheckBinaryOperator): Static method to check for binary operators
18160 (TypeContainer::AddOperator): New method to add an operator to a type.
18162 * cs-parser.jay (indexer_declaration): Added line to actually call the
18163 AddIndexer method so it gets added ;-)
18165 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
18166 already taken care of by the MS compiler ?
18168 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
18170 * class.cs (Operator): New class for operator declarations.
18171 (Operator::OpType): Enum for the various operators.
18173 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
18175 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
18176 ostensibly handle this in semantic analysis.
18178 * cs-parser.jay (general_catch_clause): Comment out
18179 (specific_catch_clauses, specific_catch_clause): Ditto.
18180 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
18181 (catch_args, opt_catch_args): New productions.
18182 (catch_clause): Rewrite to use the new productions above
18183 (catch_clauses): Modify accordingly.
18184 (opt_catch_clauses): New production to use in try_statement
18185 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
18186 and re-write the code in the actions to extract the specific and
18187 general catch clauses by being a little smart ;-)
18189 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
18190 Hooray, try and catch statements parse fine !
18192 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
18194 * statement.cs (Block::GetVariableType): Fix logic to extract the type
18195 string from the hashtable of variables.
18197 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
18198 I end up making that mistake ;-)
18199 (catch_clauses): Fixed gross error which made Key and Value of the
18200 DictionaryEntry the same : $1 !!
18202 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
18204 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
18206 * cs-parser.jay (event_declaration): Correct to remove the semicolon
18207 when the add and remove accessors are specified.
18209 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
18211 * cs-parser.jay (IndexerDeclaration): New helper class to hold
18212 information about indexer_declarator.
18213 (indexer_declarator): Implement actions.
18214 (parsing_indexer): New local boolean used to keep track of whether
18215 we are parsing indexers or properties. This is necessary because
18216 implicit_parameters come into picture even for the get accessor in the
18217 case of an indexer.
18218 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
18220 * class.cs (Indexer): New class for indexer declarations.
18221 (TypeContainer::AddIndexer): New method to add an indexer to a type.
18222 (TypeContainer::indexers): New member to hold list of indexers for the
18225 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
18227 * cs-parser.jay (add_accessor_declaration): Implement action.
18228 (remove_accessor_declaration): Implement action.
18229 (event_accessors_declaration): Implement
18230 (variable_declarators): swap statements for first rule - trivial.
18232 * class.cs (Event): New class to hold information about event
18234 (TypeContainer::AddEvent): New method to add an event to a type
18235 (TypeContainer::events): New member to hold list of events.
18237 * cs-parser.jay (event_declaration): Implement actions.
18239 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
18241 * cs-parser.jay (dim_separators): Implement. Make it a string
18242 concatenating all the commas together, just as they appear.
18243 (opt_dim_separators): Modify accordingly
18244 (rank_specifiers): Update accordingly. Basically do the same
18245 thing - instead, collect the brackets here.
18246 (opt_rank_sepcifiers): Modify accordingly.
18247 (array_type): Modify to actually return the complete type string
18248 instead of ignoring the rank_specifiers.
18249 (expression_list): Implement to collect the expressions
18250 (variable_initializer): Implement. We make it a list of expressions
18251 essentially so that we can handle the array_initializer case neatly too.
18252 (variable_initializer_list): Implement.
18253 (array_initializer): Make it a list of variable_initializers
18254 (opt_array_initializer): Modify accordingly.
18256 * expression.cs (New::NType): Add enumeration to help us
18257 keep track of whether we have an object/delegate creation
18258 or an array creation.
18259 (New:NewType, New::Rank, New::Indices, New::Initializers): New
18260 members to hold data about array creation.
18261 (New:New): Modify to update NewType
18262 (New:New): New Overloaded contructor for the array creation
18265 * cs-parser.jay (array_creation_expression): Implement to call
18266 the overloaded New constructor.
18268 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
18270 * class.cs (TypeContainer::Constructors): Return member
18271 constructors instead of returning null.
18273 2001-08-26 Miguel de Icaza <miguel@ximian.com>
18275 * typemanager.cs (InitCoreTypes): Initialize the various core
18276 types after we have populated the type manager with the user
18277 defined types (this distinction will be important later while
18278 compiling corlib.dll)
18280 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
18281 on Expression Classification. Now all expressions have a method
18282 `Resolve' and a method `Emit'.
18284 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
18285 generation from working. Also add some temporary debugging
18288 2001-08-24 Miguel de Icaza <miguel@ximian.com>
18290 * codegen.cs: Lots of code generation pieces. This is only the
18291 beginning, will continue tomorrow with more touches of polish. We
18292 handle the fundamentals of if, while, do, for, return. Others are
18293 trickier and I need to start working on invocations soon.
18295 * gen-treedump.cs: Bug fix, use s.Increment here instead of
18298 * codegen.cs (EmitContext): New struct, used during code
18299 emission to keep a context. Most of the code generation will be
18302 * cs-parser.jay: Add embedded blocks to the list of statements of
18303 this block. So code generation proceeds in a top down fashion.
18305 2001-08-23 Miguel de Icaza <miguel@ximian.com>
18307 * statement.cs: Add support for multiple child blocks.
18309 2001-08-22 Miguel de Icaza <miguel@ximian.com>
18311 * codegen.cs (EmitCode): New function, will emit the code for a
18312 Block of code given a TypeContainer and its ILGenerator.
18314 * statement.cs (Block): Standard public readonly optimization.
18315 (Block::Block constructors): Link children.
18316 (Block::Child): Child Linker.
18317 (Block::EmitVariables): Emits IL variable declarations.
18319 * class.cs: Drop support for MethodGroups here, delay until
18321 (Method::): Applied the same simplification that I did before, and
18322 move from Properties to public readonly fields.
18323 (Method::ParameterTypes): Returns the parameter types for the
18324 function, and implements a cache that will be useful later when I
18325 do error checking and the semantic analysis on the methods is
18327 (Constructor::GetCallingConvention): Renamed from CallingConvetion
18328 and made a method, optional argument tells whether this is a class
18329 or a structure to apply the `has-this' bit.
18330 (Method::GetCallingConvention): Implement, returns the calling
18332 (Method::Define): Defines the type, a second pass is performed
18333 later to populate the methods.
18335 (Constructor::ParameterTypes): implement a cache similar to the
18336 one on Method::ParameterTypes, useful later when we do semantic
18339 (TypeContainer::EmitMethod): New method. Emits methods.
18341 * expression.cs: Removed MethodGroup class from here.
18343 * parameter.cs (Parameters::GetCallingConvention): new method.
18345 2001-08-21 Miguel de Icaza <miguel@ximian.com>
18347 * class.cs (TypeContainer::Populate): Drop RootContext from the
18350 (Constructor::CallingConvention): Returns the calling convention.
18351 (Constructor::ParameterTypes): Returns the constructor parameter
18354 (TypeContainer::AddConstructor): Keep track of default constructor
18355 and the default static constructor.
18357 (Constructor::) Another class that starts using `public readonly'
18358 instead of properties.
18360 (Constructor::IsDefault): Whether this is a default constructor.
18362 (Field::) use readonly public fields instead of properties also.
18364 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
18365 track of static constructors; If none is used, turn on
18366 BeforeFieldInit in the TypeAttributes.
18368 * cs-parser.jay (opt_argument_list): now the return can be null
18369 for the cases where there are no arguments.
18371 (constructor_declarator): If there is no implicit `base' or
18372 `this', then invoke the default parent constructor.
18374 * modifiers.cs (MethodAttr): New static function maps a set of
18375 modifiers flags into a MethodAttributes enum
18376 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
18377 MethodAttr, TypeAttr to represent the various mappings where the
18378 modifiers are used.
18379 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
18381 2001-08-19 Miguel de Icaza <miguel@ximian.com>
18383 * parameter.cs (GetParameterInfo): Fix bug where there would be no
18386 * interface.cs (PopulateIndexer): Implemented the code generator
18387 for interface indexers.
18389 2001-08-17 Miguel de Icaza <miguel@ximian.com>
18391 * interface.cs (InterfaceMemberBase): Now we track the new status
18394 (PopulateProperty): Implement property population. Woohoo! Got
18395 Methods and Properties going today.
18397 Removed all the properties for interfaces, and replaced them with
18398 `public readonly' fields.
18400 2001-08-16 Miguel de Icaza <miguel@ximian.com>
18402 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
18403 initialize their hashtables/arraylists only when they are needed
18404 instead of doing this always.
18406 * parameter.cs: Handle refs and out parameters.
18408 * cs-parser.jay: Use an ArrayList to construct the arguments
18409 instead of the ParameterCollection, and then cast that to a
18412 * parameter.cs: Drop the use of ParameterCollection and use
18413 instead arrays of Parameters.
18415 (GetParameterInfo): Use the Type, not the Name when resolving
18418 2001-08-13 Miguel de Icaza <miguel@ximian.com>
18420 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
18421 and instead use public readonly fields.
18423 * class.cs: Put back walking code for type containers.
18425 2001-08-11 Miguel de Icaza <miguel@ximian.com>
18427 * class.cs (MakeConstant): Code to define constants.
18429 * rootcontext.cs (LookupType): New function. Used to locate types
18432 2001-08-08 Miguel de Icaza <miguel@ximian.com>
18434 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
18435 this System.Reflection code is. Kudos to Microsoft
18437 * typemanager.cs: Implement a type cache and avoid loading all
18438 types at boot time. Wrap in LookupType the internals. This made
18439 the compiler so much faster. Wow. I rule!
18441 * driver.cs: Make sure we always load mscorlib first (for
18442 debugging purposes, nothing really important).
18444 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
18445 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
18447 * rootcontext.cs: Lookup types on their namespace; Lookup types
18448 on namespaces that have been imported using the `using' keyword.
18450 * class.cs (TypeContainer::TypeAttr): Virtualize.
18451 (Class::TypeAttr): Return attributes suitable for this bad boy.
18452 (Struct::TypeAttr): ditto.
18453 Handle nested classes.
18454 (TypeContainer::) Remove all the type visiting code, it is now
18455 replaced with the rootcontext.cs code
18457 * rootcontext.cs (GetClassBases): Added support for structs.
18459 2001-08-06 Miguel de Icaza <miguel@ximian.com>
18461 * interface.cs, statement.cs, class.cs, parameter.cs,
18462 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
18463 Drop use of TypeRefs, and use strings instead.
18465 2001-08-04 Miguel de Icaza <miguel@ximian.com>
18469 * class.cs (Struct::Struct): set the SEALED flags after
18470 checking the modifiers.
18471 (TypeContainer::TypeAttr): new property, returns the
18472 TypeAttributes for a class.
18474 * cs-parser.jay (type_list): Oops, list production was creating a
18475 new list of base types.
18477 * rootcontext.cs (StdLib): New property.
18478 (GetInterfaceTypeByName): returns an interface by type name, and
18479 encapsulates error handling here.
18480 (GetInterfaces): simplified.
18481 (ResolveTree): Encapsulated all the tree resolution here.
18482 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
18485 * driver.cs: Add support for --nostdlib, to avoid loading the
18486 default assemblies.
18487 (Main): Do not put tree resolution here.
18489 * rootcontext.cs: Beginning of the class resolution.
18491 2001-08-03 Miguel de Icaza <miguel@ximian.com>
18493 * rootcontext.cs: Provide better error reporting.
18495 * cs-parser.jay (interface_base): set our $$ to be interfaces.
18497 * rootcontext.cs (CreateInterface): Handle the case where there
18498 are no parent interfaces.
18500 (CloseTypes): Routine to flush types at the end.
18501 (CreateInterface): Track types.
18502 (GetInterfaces): Returns an array of Types from the list of
18503 defined interfaces.
18505 * typemanager.c (AddUserType): Mechanism to track user types (puts
18506 the type on the global type hash, and allows us to close it at the
18509 2001-08-02 Miguel de Icaza <miguel@ximian.com>
18511 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
18512 RecordInterface instead.
18514 * cs-parser.jay: Updated to reflect changes above.
18516 * decl.cs (Definition): Keep track of the TypeBuilder type that
18517 represents this type here. Not sure we will use it in the long
18518 run, but wont hurt for now.
18520 * driver.cs: Smaller changes to accomodate the new code.
18522 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
18525 * rootcontext.cs (CreateInterface): New method, used to create
18526 the System.TypeBuilder type for interfaces.
18527 (ResolveInterfaces): new entry point to resolve the interface
18529 (CodeGen): Property, used to keep track of the code generator.
18531 2001-07-26 Miguel de Icaza <miguel@ximian.com>
18533 * cs-parser.jay: Add a second production for delegate_declaration
18536 (enum_body): Put an opt_comma here instead of putting it on
18537 enum_body or enum_member_declarations so we can handle trailing
18538 commas on enumeration members. Gets rid of a shift/reduce.
18540 (type_list): Need a COMMA in the middle.
18542 (indexer_declaration): Tell tokenizer to recognize get/set
18544 * Remove old targets.
18546 * Re-add the parser target.
18548 2001-07-13 Simon Cozens <simon@simon-cozens.org>
18550 * cs-parser.jay: Add precendence rules for a number of operators
18551 ot reduce the number of shift/reduce conflicts in the grammar.
18553 2001-07-17 Miguel de Icaza <miguel@ximian.com>
18555 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
18558 Get rid of old crufty code.
18560 * rootcontext.cs: Use this to keep track of the parsed
18561 representation and the defined types available to the program.
18563 * gen-treedump.cs: adjust for new convention.
18565 * type.cs: Split out the type manager, and the assembly builder
18568 * typemanager.cs: the type manager will live here now.
18570 * cil-codegen.cs: And the code generator here.
18572 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
18574 * makefile: Fixed up for easy making.
18576 2001-07-13 Simon Cozens <simon@simon-cozens.org>
18578 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
18581 (unary_expression): Expand pre_increment_expression and
18582 post_decrement_expression to reduce a shift/reduce.
18584 2001-07-11 Simon Cozens
18586 * cs-tokenizer.cs: Hex numbers should begin with a 0.
18588 Improve allow_keyword_as_indent name.
18590 2001-06-19 Miguel de Icaza <miguel@ximian.com>
18592 * Adjustments for Beta2.
18594 2001-06-13 Miguel de Icaza <miguel@ximian.com>
18596 * decl.cs: Added `Define' abstract method.
18597 (InTransit): new property, used to catch recursive definitions.
18599 * interface.cs: Implement `Define'.
18601 * modifiers.cs: Map Modifiers.constants to
18602 System.Reflection.TypeAttribute flags.
18604 * class.cs: Keep track of types and user-defined types.
18605 (BuilderInit): New method for creating an assembly
18606 (ResolveType): New function to launch the resolution process, only
18607 used by interfaces for now.
18609 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
18610 that are inserted into the name space.
18612 2001-06-08 Miguel de Icaza <miguel@ximian.com>
18614 * ARGH. I have screwed up my tree so many times due to the use of
18615 rsync rather than using CVS. Going to fix this at once.
18617 * driver.cs: Objetify driver. Load assemblies, use assemblies to
18620 2001-06-07 Miguel de Icaza <miguel@ximian.com>
18622 * Experiment successful: Use System.Type rather that our own
18625 2001-05-25 Miguel de Icaza <miguel@ximian.com>
18627 * cs-parser.jay: Removed nsAliases from here.
18629 Use new namespaces, handle `using XXX;'
18631 * namespace.cs: Reimplemented namespace handling, use a recursive
18632 definition of the class. Now we can keep track of using clauses
18633 and catch invalid using clauses.
18635 2001-05-24 Miguel de Icaza <miguel@ximian.com>
18637 * gen-treedump.cs: Adapted for all the renaming.
18639 * expression.cs (Expression): this class now has a Type property
18640 which returns an expression Type.
18642 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
18643 `Type', as this has a different meaning now in the base
18645 2001-05-22 Miguel de Icaza <miguel@ximian.com>
18647 * interface.cs, class.cs: Removed from all the sources the
18648 references to signature computation, as we can not do method
18649 signature computation during the parsing time, as we are not
18650 trying to solve at that point distinguishing:
18654 void a (NS.Blah x) {}
18657 Which depending on the context might be valid or not, as we do not
18658 know if Blah is the same thing as NS.Blah at that point.
18660 * Redid everything so the code uses TypeRefs now instead of
18661 Types. TypeRefs are just temporary type placeholders, that need
18662 to be resolved. They initially have a pointer to a string and the
18663 current scope in which they are used. This is used later by the
18664 compiler to resolve the reference to an actual Type.
18666 * DeclSpace is no longer a CIR.Type, and neither are
18667 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
18668 are all DeclSpaces, but no Types.
18670 * type.cs (TypeRefManager): This implements the TypeRef manager,
18671 which keeps track of all the types that need to be resolved after
18672 the parsing has finished.
18674 2001-05-13 Miguel de Icaza <miguel@ximian.com>
18676 * ARGH. We are going to have to store `foreach' as a class rather
18677 than resolving it, as we need to verify error 1579 after name
18678 resolution. *OR* we could keep a flag that says `This request to
18679 IEnumerator comes from a foreach statement' which we can then use
18680 to generate the error.
18682 2001-05-10 Miguel de Icaza <miguel@ximian.com>
18684 * class.cs (TypeContainer.AddMethod): we now add methods to the
18685 MethodGroup instead of the method hashtable.
18687 * expression.cs: Add MethodGroup abstraction, which gets us one
18688 step closer to the specification in the way we handle method
18691 * cs-parser.jay (primary_expression): qualified_identifier now
18692 tried to match up an identifier to a local variable reference or
18693 to a parameter reference.
18695 current_local_parameters is now a parser global variable that
18696 points to the current parameters for the block, used during name
18699 (property_declaration): Now creates an implicit `value' argument to
18702 2001-05-09 Miguel de Icaza <miguel@ximian.com>
18704 * parameter.cs: Do not use `param' arguments as part of the
18705 signature, per the spec.
18707 2001-05-08 Miguel de Icaza <miguel@ximian.com>
18709 * decl.cs: Base class for classes, structs and interfaces. This
18710 is the "Declaration Space"
18712 * cs-parser.jay: Use CheckDef for checking declaration errors
18713 instead of having one on each function.
18715 * class.cs: Factor out some code for handling error handling in
18716 accordance to the "Declarations" section in the "Basic Concepts"
18717 chapter in the ECMA C# spec.
18719 * interface.cs: Make all interface member classes derive from
18720 InterfaceMemberBase.
18722 2001-05-07 Miguel de Icaza <miguel@ximian.com>
18724 * Many things: all interfaces are parsed and generated in
18725 gen-treedump. Support for member variables, constructors,
18726 destructors, properties, constants is there.
18728 Beginning of the IL backend, but very little done, just there for
18731 2001-04-29 Miguel de Icaza <miguel@ximian.com>
18733 * cs-parser.jay: Fix labeled statement.
18735 * cs-tokenizer.cs (escape): Escape " and ' always.
18736 ref_line, ref_name: keep track of the line/filename as instructed
18737 by #line by the compiler.
18740 2001-04-27 Miguel de Icaza <miguel@ximian.com>
18742 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
18743 to match the values in System.CodeDOM.
18745 Divid renamed to Divide.
18747 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
18749 (Statements.set): remove.
18751 * System.CodeDOM/CodeCatchClause.cs: always have a valid
18754 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
18755 falseStatements always have valid values.
18757 * cs-parser.jay: Use System.CodeDOM now.