1 2007-10-05 Marek Safar <marek.safar@gmail.com>
4 * generics.cs (Constraints.CheckInterfaceMethod): Compare geenric open
5 types when appropriate.
7 2007-10-02 Marek Safar <marek.safar@gmail.com>
10 * generics.cs (TypeInferenceContext.OutputTypeInference): Slowly
11 implementing method group output type inference.
13 2007-09-25 Marek Safar <marek.safar@gmail.com>
15 * cs-parser.jay: Use only one block per query expression.
17 * generics.cs (GenericMethod.Define): Moved local variables collision
20 * linq.cs: Introduced QueryBlock and removed all blocks from query
23 2007-09-23 Marek Safar <marek.safar@gmail.com>
25 * generics.cs: Fixed lower-bound type inference issue for constructed
28 * linq.cs: Implemented nested queries.
30 2007-09-21 Marek Safar <marek.safar@gmail.com>
32 * cs-parser.jay: Query expression block are not related to each other.
34 2007-09-19 Marek Safar <marek.safar@gmail.com>
36 * generic.cs: Fixed type inference for generic delegate arguments whose
37 return types are generic delegates.
39 * linq.cs: Replaced ec.DeclContainer with ec.TypeContainer.
41 2007-09-17 Marek Safar <marek.safar@gmail.com>
43 * cs-parser.jay, linq.cs: Implemented query continuation.
45 2007-09-12 Marek Safar <marek.safar@gmail.com>
47 * cs-parser.jay: GroupJoin clause connected.
49 * generic.cs (TypeInferenceContext.InflateGenericArgument): Uses
50 inferred types to inflate delegate type argument.
52 * linq.cs: Fixed couple of typos.
53 (GroupJoin): Implemented group join clause.
55 2007-09-11 Marek Safar <marek.safar@gmail.com>
57 * cs-parser.jay: Single join clause connected.
59 * linq.cs: Moved argument creation into CreateSelector and renamed to
60 CreateSelectorArguments.
61 (ARangeVariableQueryClause.BuildQueryClause): Consider all lambda
62 arguments to be implicit.
63 (Join): Implemented single join clause.
65 2007-09-10 Marek Safar <marek.safar@gmail.com>
67 * cs-parser.jay: Create QueryStartClause for the first implicit from.
69 * generic.cs (TypeInterferenceContext.LowerBoundInference): Fixed crash
70 both U and V are not generic.
72 * linq.cs: Use standard method overload resolution for all methods.
74 2007-09-05 Marek Safar <marek.safar@gmail.com>
76 * cs-parser.jay: Plug into let clause.
78 * linq.cs: Implemented let clause, parameters refactoring.
80 2007-08-31 Marek Safar <marek.safar@gmail.com>
82 * generic.cs (TypeParameter): Uses common Emit.
83 (.IsClsComplianceRequired): Is never required.
85 2007-08-31 Marek Safar <marek.safar@gmail.com>
87 * cs-parser.jay: Terminates query block correctly. Fixed orderby
90 * generic.cs (TypeInferenceContext): Better error resistance.
92 * linq.cs: Implemented range variables, transparent identifiers and
95 2007-08-28 Marek Safar <marek.safar@gmail.com>
97 * cs-parser.jay: Anonymous type arguments can be simple name, syntax error
100 2007-08-23 Marek Safar <marek.safar@gmail.com>
102 * generic.cs (TypeInferenceV3.DoSecondPhase): Handle nested delegate
104 (IsTypeNonDependent, RemoveDependentTypes): Handle nested delegate
107 2007-08-21 Marek Safar <marek.safar@gmail.com>
109 * cs-parser.jay, linq.cs: Implemented orderby clause.
111 2007-08-20 Marek Safar <marek.safar@gmail.com>
113 * linq.cs: Switch to lambda expressions.
115 2007-08-20 Marek Safar <marek.safar@gmail.com>
117 * cs-parser.jay: An anonymous type can be empty.
119 2007-08-17 Marek Safar <marek.safar@gmail.com>
121 * linq.cs: MethodGroupExpr update.
123 2007-08-14 Marek Safar <marek.safar@gmail.com>
125 ** C# 3.0 Object and collection initializers
127 * cs-parser.jay: Grammar update.
129 2007-08-11 Marek Safar <marek.safar@gmail.com>
132 * generics.cs (TypeInferenceContext.LowerBoundInference): Don't
133 terminate type inference when an array is not paired.
135 2007-08-10 Miguel de Icaza <miguel@novell.com>
137 * generic.cs (DefaultValueExpression): Add CloneTo support to this
140 2007-08-09 Marek Safar <marek.safar@gmail.com>
142 ** C# 3.0 Anonymous Types (update to the latest standard)
144 * cs-parser.jay: Updated parameters and type names.
146 2007-08-03 Raja R Harinath <harinath@gmail.com>
148 * cs-parser.jay (class_declaration): Update to changes in class.cs.
149 Move calling of 'AddBasesForPart' to ...
150 (class_bases): ... here.
151 (struct_declaration, interface_declaration): Update to changes.
153 2007-08-02 Raja R Harinath <harinath@gmail.com>
155 Reduce some differences between cs-parser.jay in mcs/ and gmcs/.
156 * cs-parser.jay: Some whitespace cleanups.
157 (method_header): Refer to the correct symbol for parameters.
159 2007-08-01 Marek Safar <marek.safar@gmail.com>
162 * cs-parser.jay: Ignore partial keyword inside block expression.
164 2007-08-01 Marek Safar <marek.safar@gmail.com>
166 ** C# 3.0 Type Inference (major bits are working)
168 * generic.cs: Introduced new abstract class as an entry point to type
169 inference. Old type inference moved to TypeInferenceV2. Implemented C# 3.0
170 type inference as descibed in the standard in TypeInferenceV2 class.
172 * linq.cs (ALinqExpression): Disabled caching because it's wrong.
174 2007-07-25 Jb Evain <jbevain@novell.com>
176 * Makefile: don't install on net_2_1.
178 2007-07-18 Marek Safar <marek.safar@gmail.com>
180 * cs-parser.jay: Use ImplicitLambdaParameter everywhere.
182 2007-07-17 Marek Safar <marek.safar@gmail.com>
184 * cs-parser.jay: Correct placeholder for implicit linq parameter.
186 * linq: Add ImplicitArgument.
188 2007-07-03 Marek Safar <marek.safar@gmail.com>
190 * cs-parser.jay: Switch to ImplicitLambdaParameter.
192 2007-07-03 Marek Safar <marek.safar@gmail.com>
194 * cs-parser.jay: Initialize implicit_value_parameter_type for interface
197 * linq.cs (QueryExpression.DoResolve): Resolve implicitly typed query
200 2007-06-20 Marek Safar <marek.safar@gmail.com>
202 * cs-parser.jay: Reworked var keyword handling. We cannot handle var as
203 static keyword because var becomes keyword only if no type with the var
204 name exists in the scope of variable which uses var declaration.
206 2007-06-18 Marek Safar <marek.safar@gmail.com>
208 * cs-parser.jay: Add implicitly typed local variable checks.
210 2007-06-15 Marek Safar <marek.safar@gmail.com>
212 * cs-parser.jay: Correctly split generic arguments and generic
213 parameters. Correctly implemented typeof of generic unbound types.
215 2007-06-14 Marek Safar <marek.safar@gmail.com>
217 * cs-parser.jay: Assembly and module attributes must precede all other
218 elements except using clauses and extern alias declarations.
220 2007-06-08 Marek Safar <marek.safar@gmail.com>
222 * cs-parser.jay: Uses newly defined GroupBy class.
224 * linq.cs (GroupBy): Implemented.
225 (AQueryClause.BuildQueryClause): Refactored to allow customize query
228 2007-06-08 Marek Safar <marek.safar@gmail.com>
230 * generics.cs (InferTypeArguments): Uses AnonymousMethodExpression
233 2007-06-06 Marek Safar <marek.safar@gmail.com>
235 * generics.cs (TypeArguments): New contructor fow known number of
238 2007-06-04 Raja R Harinath <rharinath@novell.com>
240 * linq.cs (Select.DoResolve): Pass the created parameters to the
243 2007-05-29 Raja R Harinath <rharinath@novell.com>
245 * cs-parser.jay: Update to changes in ToplevelBlock.
246 (top_current_block): Remove.
248 2007-05-27 Raja R Harinath <harinath@gmail.com>
250 * cs-parser.jay: Update to new ExplicitBlock invariant.
252 * cs-parser.jay: Update to changes introduced in Block and
255 2007-05-25 Raja R Harinath <rharinath@novell.com>
257 * cs-parser.jay: Use 'start_block' and 'end_block' rather than
258 modifying current_block directly.
260 2007-05-22 Scott Peterson <lunchtimemama@gmail.com>
262 * cs-parser.jay: Implemented automatic properties (C# 3.0)
264 2007-05-15 Scott Peterson <lunchtimemama@gmail.com>
266 * cs-parser.jay: Improved grammar for object and collection
269 2007-04-28 Scott Peterson <lunchtimemama@gmail.com>
271 This code is contributed under the MIT X11 license
273 * cs-parser.jay: Added support for C# 3.0 language features:
274 Variable type inference (the "var" keyword)
277 Object initialization
278 Collection initialization
280 2007-05-06 Marek Safar <marek.safar@gmail.com>
283 * cs-parser.jay: Add special handling for coalescing operator.
285 2007-05-02 Raja R Harinath <rharinath@novell.com>
287 Fix regression in cs0631-3.cs
288 * cs-parser.jay (operator_declarator): Add opt_attributes to error
289 fallback. Make error fallback catch more cases.
291 2007-05-01 Miguel de Icaza <miguel@novell.com>
293 * cs-parser.jay: Allow parameters in operator declarations to have
296 2007-04-27 Miguel de Icaza <miguel@novell.com>
298 * generic.cs (TypeManager.LambdaInfer): now this routine will
299 make only one inference from the list of lambda expression that
300 have not participated in inferring a type.
302 (TypeManager.InferTypeArguments): The logic that drives the type
303 inference in lambda expressions is now driven here.
305 2007-04-23 Miguel de Icaza <miguel@novell.com>
307 * generic.cs: Large update to LambdaInfer, this is merely an
308 update to start the lambda type inference. It is by no means
309 complete. It is currently merely able to build a sample program
310 (with no iteration for the type parameters).
312 2007-04-12 Duncan Mak <duncan@a-chinaman.com>
314 * cs-parser.jay (interface_method_declaration_body): Fixed typo.
316 2007-04-08 Marek Safar <marek.safar@gmail.com>
318 * cs-parser.jay, linq.cs: First select implementation (hacky).
320 * generic.cs (InferTypeArguments): Simplified.
322 2007-03-31 Marek Safar <marek.safar@gmail.com>
324 * generic.cs (InferTypeArguments): Restored validation check.
325 (InferTypeArguments): Move all logic to Compatible method for re-usability.
327 2007-03-25 Marek Safar <marek.safar@gmail.com>
329 * generic.cs (InferTypeArguments): Infer arguments before they are used
330 for compatibility check.
332 2007-03-15 Marek Safar <marek.safar@gmail.com>
334 * generic.cs (InflatedConstraints): Fixed the check order.
335 (TypeArguments.Resolve): Small optimization for generic parameters.
336 (InferTypeArguments): Add infering support for anonymous methods.
338 2007-03-15 Martin Baulig <martin@ximian.com>
343 (TypeParameter.HasConstructorConstraint): Removed.
344 (ConstraintChecker.HasDefaultConstructor): Removed the
345 `TypeBuilder' argument here; correctly check for the ctor
346 constraint on type parameters.
348 2007-03-15 Martin Baulig <martin@ximian.com>
353 (TypeParameter): Create a `MemberCache' here as well. Note that
354 we need to create this on-demand when it's actually used.
356 2007-03-10 Marek Safar <marek.safar@gmail.com>
358 * generic.cs (TypeArguments.Resolve): Avoid redundant checks.
360 2007-03-09 Raja R Harinath <rharinath@novell.com>
362 * cs-parser.jay (WHERE): Move before QUERY_FIRST_TOKEN. 'where'
363 is a valid keyword outside a linq expression too.
365 2007-03-03 Marek Safar <marek.safar@gmail.com>
367 * cs-parser.jay: Implemented basic linq grammar.
369 * linq.cs: New file for hosting query specific classes.
371 2007-02-26 Marek Safar <marek.safar@gmail.com>
373 * cs-parser.jay, expression.cs: Compile empty __arglist correctly.
375 2007-02-20 Marek Safar <marek.safar@gmail.com>
378 * cs-parser.jay: Anonymous container starts at constructor declaration
379 and not at block beginning because it has to be usable in constructor
382 2007-02-18 Marek Safar <marek.safar@gmail.com>
384 A fix for bug #80493 by Atsushi Enomoto
385 * cs-parser.jay: Ignore invalid attribute target.
387 2007-02-15 Miguel de Icaza <miguel@novell.com>
389 * Remove the call to SetExpression for lambda expressions, we do
390 not actually need it.
392 Remove expression tracking code as its not needed.
394 2007-02-11 Miguel de Icaza <miguel@novell.com>
396 * cs-parser.jay (lambda_expression_body): when the body is an
397 expression add a statement of the form:
399 contextual-return expression.
401 Where `contextual-return' is similar to `return', the difference
402 being that if the delegate that the lambda will be converted to
403 has a void return type, it will check that the result is a
404 ExpressionStatement and the result is a plain ret (no return
405 values on the stack). If the return type of the delegate is of a
406 given type, this turns into a return with a value and does the
407 regular checking to check that the computed value can be
408 implicitly converted to the delegate return.
410 2007-01-30 Miguel de Icaza <miguel@novell.com>
412 * cs-parser.jay (anonymous_method_expression): move the
413 before/after productions to the start_anonymous and end_anonymous
414 methods so the code can be reused for lambda functions.
416 (lambda_expression_body): wrap expressions implicitly into a
419 (block): factor out the setup/teardown of parsing a block so we
420 can reuse that in lambda_expression_body
422 (lambda_expression): use new anonymous method helper methods.
424 2007-01-29 Miguel de Icaza <miguel@novell.com>
426 * cs-parser.jay: oob_stack make it static (am guessing that is why
427 we no longer initialize it anymore) and reuse it across
430 2007-01-28 Miguel de Icaza <miguel@novell.com>
432 * cs-parser.jay (open_parens): Introduce new non-terminal that
433 abstracts OPEN_PARENS and OPEN_PARENS_LAMBDA as the later can now
434 be returned in places where types are followed by identifiers
435 (this is expected in declaration, fixed, using, foreach and catch
438 Use open_parens in those places, keep OPEN_PARENS in the
441 cs-parser.jay: New grammar bits for parsing lambda expressions.
443 2007-01-28 Raja R Harinath <rharinath@novell.com>
445 Fix #80534, gtest-309.cs
446 * generic.cs (UnifyType): Rename from InferType. Make unification
447 of generic insts simpler and don't insist on inferring all generic
448 parameters in a single generic inst unification.
450 (InferGenericInstance): Remove.
451 Analysis and initial patch by David Mitchell <dmitchell@logos.com>.
453 2007-01-20 Marek Safar <marek.safar@gmail.com>
455 * cs-parser.jay: Better parameter error handling.
457 2007-01-17 Bill Holmes <bill.holmes@ansys.com>
458 Raja R Harinath <rharinath@novell.com>
460 * cs-parser.jay (accessor_declarations): Use it instead of 'Pair'.
461 Note the order in which accessors are declared in the source.
463 2007-01-16 Sergey P. Kondratyev <se@unicom.tomica.ru>
465 * generic.cs (TypeParameter.FindMembers): Use the generic
466 constraints, not the constraints to check for methods (first fix
469 2006-12-30 Marek Safar <marek.safar@gmail.com>
471 * cs-parser.jay: Better syntax errors handling.
473 2006-11-21 Marek Safar <marek.safar@gmail.com>
475 * cs-parser.jay: Tiny change to work with mcs tokenizer.
477 * cs-tokenizer.cs: Remove after unification with mcs.
479 2006-10-28 Marek Safar <marek.safar@gmail.com>
482 * generic.cs (ConstructedType.AsAccessible): Check accessibility of type
485 2006-10-26 Marek Safar <marek.safar@gmail.com>
488 * cs-tokenizer.cs (IsCastToken): Enable a cast of anonymous methods.
490 2006-10-25 Brian Crowell <brian@fluggo.com>
493 * generic.cs (CheckConstraints): Allow generic parameters with
494 inheritance constraints to satisfy reference type constraints.
496 2006-10-09 Martin Baulig <martin@ximian.com>
499 (NullCoalescingOperator.DoResolve): Fix #78964; added gtest-294.cs.
501 2006-09-25 Martin Baulig <martin@ximian.com>
503 * class.cs: Remove after unification with mcs source.
505 2006-09-24 Raja R Harinath <harinath@gmail.com>
507 * convert.cs: Remove after unification with mcs source.
509 2006-09-24 Marek Safar <marek.safar@seznam.cz>
511 * class.cs (MemberBase.VerifyClsCompliance): When method has type
512 parameters verify them as well.
514 * generic.cs (Constraints.VerifyClsCompliance): Verify CLS-Compliance of
515 the type parameter constraints.
516 (Generics.VerifyClsCompliance): Ditto.
518 2006-09-24 Marek Safar <marek.safar@seznam.cz>
520 * anonymous.cs (AnonymousMethod.Compatible): Cannot generate arguments
521 for anonymous block with out argument.
523 2006-09-24 Marek Safar <marek.safar@seznam.cz>
525 * class.cs (ClassOrStruct.VerifyMembers): Fixed to report correctly
526 not used private events only.
528 2006-09-23 Marek Safar <marek.safar@seznam.cz>
530 * convert.cs (ImplicitReferenceConversion): NullCast to EmptyConstantCast.
532 * cs-parser.jay: Parse correctly cast of default (T).
534 * generic.cs (DefaultValueExpression.DoResolve): Check for void type.
535 Store original type via EmptyConstantCast.
537 2006-09-22 Martin Baulig <martin@ximian.com>
539 * delegate.cs: Removed; this file is now shared with mcs.
541 * attribute.cs: Removed; this file is now shared with mcs.
543 2006-09-22 Martin Baulig <martin@ximian.com>
545 * ecore.cs: Removed; this file is now shared with mcs.
547 2006-09-21 Marek Safar <marek.safar@seznam.cz>
549 * convert.cs (ImplicitReferenceConversion): Reuse ToType.
551 * ecore.cs (NullCast): Derives from NullConstant.
553 * generic.cs (DefaultValueExpression): Fixed to cope with the constant
556 2006-09-21 Martin Baulig <martin@ximian.com>
558 * decl.cs: Removed; this file is now shared with mcs.
560 2006-09-21 Raja R Harinath <rharinath@novell.com>
562 * rootcontext.cs: Remove after unification with mcs source.
564 * report.cs: Remove after unification with mcs source.
565 * generic.cs (AddTypeParameter, LookupTypeParameter): Move to
567 (InitGenerics, CleanUpGenerics): Remove.
569 * support.cs: Remove after unification with mcs source.
571 2006-09-20 Raja R Harinath <rharinath@novell.com>
573 * codegen.cs: Remove after unification with mcs source.
575 2006-09-19 Martin Baulig <martin@ximian.com>
577 * expression.cs: Removed; this file is now shared with mcs.
579 2006-09-19 Martin Baulig <martin@ximian.com>
582 (TypeManager.IsEqual): Moved into ../mcs/typemanager.cs.
583 (TypeManager.DropGenericTypeArguments): Likewise.
584 (TypeManager.DropGenericMethodArguments): Likewise.
585 (TypeManager.GetTypeArguments): Likewise.
586 (TypeManager.HasGenericArguments): Likewise.
588 2006-09-19 Martin Baulig <martin@ximian.com>
590 * ecore.cs (PropertyExpr.InstanceResolve): Fix the CS1540 check.
592 2006-09-19 Martin Baulig <martin@ximian.com>
594 * typemanager.cs: Removed; this file is now shared with mcs.
596 2006-09-16 Raja R Harinath <rharinath@novell.com>
598 * Makefile (LOCAL_MCS_FLAGS): Use instead of PROFILE_MCS_FLAGS.
599 * AssemblyInfo.cs, driver.cs: Remove after unification with mcs source.
601 2006-09-16 Marek Safar <marek.safar@seznam.cz>
604 * class.cs (MethodCore.VerifyClsCompliance): Do check for abstract members
605 only if parent type is class.
606 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Fixed missing cache
609 2006-09-15 Marek Safar <marek.safar@seznam.cz>
612 * expression.cs(MemberAccess.DoResolve): Don't crash when not allowed
614 * typemanager.cs(CSharpName): Converts NullType to null.
616 2006-09-15 Martin Baulig <martin@ximian.com>
618 * pending.cs: Removed; this file is now shared with mcs.
620 2006-09-15 Martin Baulig <martin@ximian.com>
622 * statement.cs: Removed; this file is now shared with mcs.
624 2006-09-15 Martin Baulig <martin@ximian.com>
626 * rootcontext.cs (RootContext.BrokenCircularDeps): Removed.
628 * driver.cs: Removed the `--broken-cycles' argument.
630 2006-09-15 Martin Baulig <martin@ximian.com>
632 * namespace.cs: Removed; this file is now shared with mcs.
634 2006-09-15 Martin Baulig <martin@ximian.com>
636 * decl.cs (MemberName): Minor code cleanups.
638 2006-09-15 Martin Baulig <martin@ximian.com>
640 * parameter.cs: Removed; this file is now shared with mcs.
642 2006-09-15 Martin Baulig <martin@ximian.com>
644 * enum.cs: Removed; this file is now shared with mcs.
646 2006-09-15 Martin Baulig <martin@ximian.com>
648 * Makefile: Define `GMCS_SOURCE'.
650 * flowanalysis.cs: Removed; this file is now shared with mcs.
652 2006-09-15 Martin Baulig <martin@ximian.com>
654 Removed modifiers.cs, literal.cs, location.cs, roottypes.cs,
655 assign.cs, const.cs, cfold.cs, constant.cs, symbolwriter.cs and
656 doc.cs - they are now shared with mcs.
658 * gmcs.exe.sources: Include these files from ../mcs/.
660 2006-09-15 Martin Baulig <martin@ximian.com>
662 * old-code.cs, gen-il.cs, gen-treedump.cs: Removed old stuff.
663 * g1.cs, sample-hello.cs, sample-stack.il: Likewise.
665 2006-09-14 Marek Safar <marek.safar@seznam.cz>
667 * assign.cs, ecore.cs, expression.cs: Share error message text.
668 * class.cs (FieldMember.Define): Check for variable of static type.
669 * decl.cs (check_type_parameter): Report correct type name.
670 * driver.cs (LoadAssembly): Uses error output for errors.
671 * generic.cs (Constraints.Resolve): Add check for constraint accessibility
672 (TypeArguments.Resolve): Static class cannot be used as an argument.
673 * statement.cs (ResolveMeta): Constants cannot be generic types.
675 2006-09-12 Martin Baulig <martin@ximian.com>
677 * generic.cs (TypeManager.IsIList): Moved into convert.cs.
679 * convert.cs (Convert.Array_To_IList): Moved here and correctly
680 implement it; fixes #79345.
682 2006-09-08 Marek Safar <marek.safar@seznam.cz>
684 * decl.cs (DeclSpace.SetParameterInfo): Check for nonexistent type
686 * expression.cs (TypeOf.GetAttributableValue): Check for open generic
688 * generic.cs: Improved error messages.
689 * typemanager.cs (RemoveGenericArity): Made public.
691 2006-09-08 Martin Baulig <martin@ximian.com>
693 * typemanager.cs (TypeManager.interlocked_type): New public field.
694 (TypeManager.int_interlocked_compare-exchange): New public field.
695 (TypeManager.InitEnumUnderlyingTypes): Also initialize the
696 enumerator types here and call InitGenericCoreTypes().
697 (TypeManager.InitCoreTypes): Call InitEnumeratorTypes() right
698 after calling InitEnumUnderlyingTypes().
701 (RootContext.ResolveCore): Added `System.Threading.Interlocked' to
702 `classes_second_stage'.
704 2006-09-07 Marek Safar <marek.safar@seznam.cz>
706 * class.cs, generic.cs (GenericMethod.Define): Check for type parameter
708 * statement.cs (Block.Variables): Made public.
710 2006-09-07 Martin Baulig <martin@ximian.com>
713 (MainDriver): Revert r62663 from Marek; see #70506 for details.
715 2006-09-01 Martin Baulig <martin@ximian.com>
718 (TypeManager.IsIList): Also handle base classes and interfaces.
720 2006-09-01 Raja R Harinath <rharinath@novell.com>
723 * expression.cs (Invocation.MoreSpecific): Check for reference
726 2006-08-29 Miguel de Icaza <miguel@novell.com>
728 * cs-parser.jay: Turn 1522 into a warning, instead of an error #79210
730 2006-08-17 Miguel de Icaza <miguel@novell.com>
732 * cs-tokenizer.cs: Apply patch from Atsushi Enomoto that fixes
733 #52019 and #79064, the use of the \uXXXX sequence in source code
734 to represent unicode characters.
736 2006-08-15 Marek Safar <marek.safar@seznam.cz>
738 * expression.cs (SizeOf.DoResolve): Check for void type. Fixed enum types
740 * class.cs, ecore.cs, statement.cs: Merged to one error message.
742 2006-08-14 Raja R Harinath <rharinath@novell.com>
745 * cs-tokenizer.cs (parse_less_than): Allow '*' to appear in a type
746 parameter too. This only avoids a parse error -- the semantic
747 error is caught elsewhere.
749 2006-08-13 Miguel de Icaza <miguel@novell.com>
751 * assign.cs: Catch attempts to assign to a method groups in += and
754 2006-08-13 Marek Safar <marek.safar@seznam.cz>
757 * cs-parser.jay: Don't destroy current array type by typeof of array's.
759 2006-08-12 Marek Safar <marek.safar@seznam.cz>
761 * cs-parser.jay: Check whether a constraint clause has already been
762 specified for type parameter.
763 * generic.cs (Constraints): Exposed location.
765 2006-08-12 Marek Safar <marek.safar@seznam.cz>
767 * class.cs (Method.Define): Issue a warning when generic method looks like
769 * decl.cs (MemberCore.GetSignatureForError): Print member type arguments
771 * report.cs: New warning number.
773 2006-08-09 Marek Safar <marek.safar@seznam.cz>
775 * anonymous.cs(AnonymousDelegate.Emit): Uses Constructor filter when
777 * decl.cs (MemberCache.FindMembers): When container is interface we need to
778 search all base interfaces as a member can be ambiguous.
779 * delegate.cs (Delegate.FindMembers): Fixed to return valid data for
780 Constructor member type filter.
781 (Delegate.ResolveConstructorMethod) Uses Constructor filter.
782 * ecore.cs: (Expression.MemberLookup): Implemented ambiguity error/warning
783 reporting for returned memberinfos.
784 * report.cs: Updated.
785 * typemanager.cs (TypeManager.LookupBaseInterfacesCache): Uses TypeManager
786 version to work on all runtimes.
787 (TypeManager.RealMemberLookup): Removed members filtering.
789 2006-08-08 Raja R Harinath <rharinath@novell.com>
791 * ecore.cs (FieldExpr.EmitAssign): Release temporary.
792 (PropertyExpr.EmitAssign): Likewise.
793 * expression.cs (Indirection.EmitAssign): Likewise.
794 (LocalVariableReference.EmitAssign): Likewise.
795 (ParameterReference.EmitAssign): Likewise.
796 (Invocation.EmitArguments): Likewise.
797 (ArrayAccess.EmitAssign): Likewise.
798 (IndexerAccess.EmitAssign): Likewise.
799 (This.EmitAssign): Likewise.
800 (ConditionalLogicalOperator.Emit): Likewise.
803 * codegen.cs (EmitContext.GetTemporaryLocal): Simplify. Use Stack
804 instead of ArrayList. If the hashtable has a LocalBuilder, don't
805 leave it in after returning it.
806 (EmitContext.FreeTemporaryLocal): Simplify. Update to changes.
808 2006-08-06 Marek Safar <marek.safar@seznam.cz>
810 * expresssion.cs (IndexerAccess.DoResolve): Fixed to report correct error
813 2006-08-05 Marek Safar <marek.safar@seznam.cz>
815 * class.cs (TypeContainer.AddPartial): Add check for partial declarations
816 with different type names.
817 (TypeContainer.UpdateTypeParameterConstraints): Updated an error message.
819 2006-08-03 Raja R Harinath <rharinath@novell.com>
821 Fix cs0146-3.cs and cs0146-4.cs.
822 * class.cs (TypeManager.CheckRecursiveDefinition): Check that
823 enclosing types don't depend on the current type.
825 2006-08-02 Raja R Harinath <rharinath@novell.com>
828 * class.cs (TypeContainer.DoDefineMembers): Use
829 FindBaseMemberWithSameName on Parent, since we're interested in
830 whether we hide inherited members or not.
831 (FindBaseMemberWithSameName): Make slightly more robust.
834 * codegen.cs (IResolveContext.GenericDeclContainer): New.
835 (EmitContext): Implement new interface requirement.
836 * namespace.cs (UsingEntry, LocalAliasEntry): Likewise.
837 * decl.cs (MemberCore): Likewise.
838 (DeclSpace.GenericDeclContainer): Rename from DeclContainer.
839 * ecore.cs (SimpleName.ResolveAsTypeTerminal): Use
840 ec.GenericDeclContainer to check for generic parameters.
841 (SimpleName.DoSimpleNameResolve): Likewise.
842 * generic.cs (TypeParameter.DeclContainer): Remove override.
844 * namespace.cs (NamespaceEntry.Doppelganger): Create slave
845 declspaces for doppelgangers too.
846 (UsingEntry): Implement IResolveContext.
847 (UsingEntry.Resolve): Don't set ToplevelTypes.Namespace. Use
848 'this' as the resolve context.
849 (LocalAliasEntry): Likewise.
851 Implement parts of #77403
852 * roottypes.cs (RootDeclSpace): New. Used to represent the
853 toplevel declaration space. Each namespace declaration introduces
854 a "partial" root declaretion space.
855 * namespace.cs (NamespaceEntry.SlaveDeclSpace): New.
856 (NamespaceEntry.ctor): Create a SlaveDeclSpace if necessary.
857 * cs-parser.jay (CSharpParser.ctor): Initialize 'current_class'
858 from 'current_namespace.SlaveDeclSpace'.
859 (namespace_declaration): Likewise.
860 * class.cs (TypeContainer.ctor): Remove parent==ToplevelTypes
861 check. It can't happen now.
862 * decl.cs (DeclSpace.LookupType): Likewise.
863 * driver.cs (MainDriver): Sanity check.
865 2006-08-01 Raja R Harinath <rharinath@novell.com>
867 * decl.cs (DeclSpace.FindNestedType): Remove.
868 (DeclSpace.LookupNestedTypeINHierarchy): Use PartialContainer and
869 LookupTypeContainer to get the container of the nested type.
870 * class.cs (TypeContainer.FindNestedType): Make non-override.
872 2006-07-31 Raja R Harinath <rharinath@novell.com>
874 * decl.cs (DeclSpace.PartialContainer): Move field from ...
875 * class.cs (TypeContainer.PartialContainer): ... here.
876 (TypeContainer.AddBasesForPart): New helper.
877 (MemberBase.ParentContainer): Remove. Use Parent.PartialContainer
879 * cs-parser.jay (current_class): Convert to DeclSpace.
880 (struct_declaration, interface_declaration, class_declaration):
881 Use AddBasesForPart instead of .Bases directly.
882 * const.cs, iterators.cs: Update to changes.
884 2006-07-28 Raja R Harinath <rharinath@novell.com>
886 * class.cs (TypeContainer.AddMemberType): Rename from
888 (TypeContainer.AddMember): Rename from AddToMemberContainer.
889 (AddTypeContainer): New. Combine AddClassOrStruct and
891 (AddPartial): Update. Add 'is_partial' argument.
892 * roottypes.cs: Update to changes.
893 * cs-parser.jay (push_current_class): New helper for handling
894 current_container and current_class.
895 (struct_declaration, interface_declaration, class_declaration):
898 2006-07-26 Raja R Harinath <rharinath@novell.com>
900 * roottypes.cs: Rename from tree.cs.
902 Rename RootContext.Tree.Types to RootContext.ToplevelTypes.
903 * tree.cs (Tree, ITreeDump): Remove types.
904 * rootcontext.cs (tree, Tree): Remove fields.
905 (root, ToplevelTypes): New.
906 * *.cs: Update to rename.
908 * tree.cs (Tree.RecordDecl): Remove.
909 (RootTypes.AddToTypeContainer): Record the toplevel type in its
911 * class.cs, cs-parser.jay: Remove mention of RecordDecl.
913 2006-07-23 Raja R Harinath <harinath@gmail.com>
915 * codegen.cs (EmitContext.Flags): Move InCatch, InFinally,
916 DoFlowAnalysis and OmitStructFlowAnalysis here.
917 (ec.With): Rename from WithUnsafe and generalize.
918 (ec.WithCheckState): Remove. All users can be handled by 'With'.
919 (ec.WithFlowAnalyis): New.
920 * ecore.cs, expression.cs, statement.cs: Update.
922 2006-07-22 Raja R Harinath <harinath@gmail.com>
924 * statement.cs (Block.ResolveMeta): Simplify slightly.
926 * codegen.cs (EmitContext.Flags): New enum. Used to represent the
927 multiple boolean fields. Convert InUnsafe, constant_check_state,
928 check_state to flags.
929 (CheckState, ConstantCheckState): Update.
930 (InUnsafe): New read-only property.
931 (FlagsHandle): Rename from CheckStateHandle and convert to handle
933 (WithUnsafe): New helper similar to WithCheckState.
934 * statement.cs (Block.ResolveMeta): Use WithUnsafe.
935 (Unsafe.Resolve, Unsafe.DoEmit): Likewise.
937 2006-07-21 Raja R Harinath <rharinath@novell.com>
939 Make comparisons use the same IL irrespective of whether they're
940 in a 'checked' or 'unchecked' context: one of the issues in #78899
941 * codegen.cs (EmitContext.CheckState): Make read-only property.
942 (EmitContext.ConstantCheckState): Likewise.
943 (EmitContext.CheckStateHandle, EmitContext.WithCheckState): New
944 helper that implement a save/restore stack for CheckState
945 values. This is the only way to change check-state.
946 * ecore.cs (Expression.ExpressionToArrayArgument): Use WithCheckState.
947 * expression.cs (CheckedExpr.DoResolve, CheckedExpr.Emit): Likewise.
948 (CheckedExpr.EmitBranchable): New forwarding method.
949 (UnCheckedExpr): Likewise.
950 * statement.cs (Block.ResolveMeta): Use WithCheckState.
951 (Unchecked.Resolve, Unchecked.DoEmit): Likewise.
952 (Checked.Resolve, checked.DoEmit): Likewise.
954 2006-07-21 Martin Baulig <martin@ximian.com>
956 * generic.cs (TypeManager.InferType): When inferring an array
957 type, also allow IList<T> and ICollection<T>. Fixes #78900.
959 2006-07-21 Martin Baulig <martin@ximian.com>
961 * generic.cs (TypeManager.IsIEnumerable): Renamed into IsIList()
962 and allow IList`1 and all its base interfaces.
964 * convert.cs (Convert.ImplicitReferenceConversion): Allow
965 converting from an array-type of T to IList<T>.
967 2006-07-21 Martin Baulig <martin@ximian.com>
969 * ecore.cs (SimpleName.DoSimpleNameResolve): Added CS0307 check.
971 2006-07-20 Miguel de Icaza <miguel@novell.com>
973 * anonymous.cs: Cache the resolved anonymous delegate, and return
974 this so that the ResolveTopBlock is only triggered once, not
977 Currently we trigger ResolvetopBlock twice due to a first pass of
978 argument check compatibility, and a second pass that does the
981 2006-07-15 Marek Safar <marek.safar@seznam.cz>
983 * annonymous.cs (AnonymousMethod.CreateScopeType): Fixed nested type
985 * rootcontext.cs (Reset): Add helper_classes.
987 2006-07-15 Marek Safar <marek.safar@seznam.cz>
990 * statement.cs (Switch.SimpleSwitchEmit): Handle case null at any position
993 2006-07-13 Miguel de Icaza <miguel@novell.com>
995 * statement.cs (Lock): Handle expressions of type
996 TypeManager.null_type specially. Fixes #78770
998 2006-07-08 Marek Safar <marek.safar@seznam.cz>
1000 * expression.cs (Binary.ResolveOperator): Don't crash when null is assigned
1003 2006-07-08 Marek Safar <marek.safar@seznam.cz>
1005 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Fixed to look
1006 for accessors as well.
1007 * ecore.cs (EventExpr): Add AccessorTable.
1009 2006-07-03 Martin Baulig <martin@ximian.com>
1011 * ecore.cs (UnboxCast.Emit): Also use `Unbox_Any' for generic
1012 instances of value types.
1014 * convert.cs (Convert.ExplicitConversion): Correctly handle
1015 object->nullable conversions.
1017 2006-07-01 Marek Safar <marek.safar@seznam.cz>
1020 * attribute.cs, class.cs, ecore.cs : Add missing location of related symbol
1021 for CS0122 where appropriate.
1022 * typemanager.cs (IsNestedChildOf): Type can be null in the case of top
1024 (Filter): Assembly can be null in the case of top level attributes.
1026 2006-06-28 Raja R Harinath <rharinath@novell.com>
1029 * generic.cs (TypeManager.InferParamsTypeArguments): If there are
1030 no arguments, return 'false': nothing can be inferred.
1032 2006-06-25 Marek Safar <marek.safar@seznam.cz>
1036 * ecore.cs (Expression.MemberLookupFailed): Don't crash when failed lookup
1037 is done at global level.
1039 2006-06-24 Marek Safar <marek.safar@seznam.cz>
1041 A fix for #77002, Implemented TypeForwarder support.
1043 * attribute.cs (Attribute.GetArgumentType): Reads type argument.
1044 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Add TypeForwarder
1046 * expression.cs (TypeOf.TypeArgument): Exposes typeof type.
1047 * typemanager.cs (): Add type_forwarder_attr_type.
1049 2006-06-24 Marek Safar <marek.safar@seznam.cz>
1051 * report.cs: Add CS0469 warning.
1053 2006-06-22 Martin Baulig <martin@ximian.com>
1056 (TypeContainer.GetNormalBases): Also use ResolveAsBaseTerminal()
1057 for interfaces; fixes #78686, which is a modification of #78380
1058 with interfaces instead of classes.
1060 2006-06-21 Martin Baulig <martin@ximian.com>
1062 * codegen.cs (CodeGen.Save): Moved the symbol file generation into
1063 the `try'-block, so we also report CS0016 etc. there.
1065 2006-06-21 Martin Baulig <martin@ximian.com>
1067 * ecore.cs (FieldExpr.EmitAssign, FieldExpr.AddressOf): Correctly
1068 handle SetAssigned() and SetMemberIsUsed() for generic types;
1071 2006-06-21 Martin Baulig <martin@ximian.com>
1074 (Delegate.VerifyMethod): Allow `params' methods; fixes #78678.
1076 2006-06-21 Martin Baulig <martin@ximian.com>
1078 * expression.cs (Unary.ResolveOperator): In `Operator.AddressOf',
1079 also report CS1686 for parameters.
1081 2006-06-21 Martin Baulig <martin@ximian.com>
1083 * statement.cs (GotoCase.Resolve): Report a warning (CS0469)
1084 instead of an error if the value is not implicitly convertible to
1085 the switch types; fixes #77964.
1087 2006-06-21 Raja R Harinath <rharinath@novell.com>
1090 * class.cs (FieldBase.ResolveInitializer): Stop resolution if
1091 FieldBuilder is null.
1094 * expression.cs (Binary.CheckShiftArguments): Don't overwrite original
1095 'left' and 'right' before error-checking.
1097 2006-06-19 Martin Baulig <martin@ximian.com>
1100 (Convert.ImplicitConversionStandard): Cleanup and correctly
1101 implement nullable conversions.
1102 (Convert.ImplicitStandardConversionExists): Likewise.
1103 (Convert.ExplicitConversion): Likewise.
1105 2006-06-19 Martin Baulig <martin@ximian.com>
1108 (Nullable.Wrap.Create, Nullable.Unwrap.Create): New public static
1109 methods; make the ctors protected.
1111 2006-06-19 Martin Baulig <martin@ximian.com>
1113 Fixed #78380; added gtest-273.cs.
1116 (Expression.ResolveAsBaseTerminal): Move the constraint checking
1117 into ResolveAsTypeTerminal().
1120 (ConstraintChecker.HasDefaultConstructor): Use the non-cache based
1121 TypeManager.FindMembers() to check for the default ctor.
1123 2006-06-18 Marek Safar <marek.safar@seznam.cz>
1125 * generic.cs: Fixed NullableInfo accessibility.
1127 2006-06-16 Martin Baulig <martin@ximian.com>
1130 (Constraints.InflatedConstraints.inflate): Correctly inflate
1131 generic types; fixes #78400.
1133 2006-06-16 Juraj Skripsky <js@hotfeet.ch>
1135 * ecore.cs (SimpleName.Error_ObjectRefRequired): Do not truncate the name.
1137 (MemberExpr.EmitInstance): Use GetSignatureForError () to get full name.
1138 (FieldExpr.DoResolve): likewise.
1139 (PropertyExpr.InstanceResolve): likewise.
1140 (EventExpr.InstanceResolve): likewise.
1142 2006-06-15 Martin Baulig <martin@ximian.com>
1145 (SwitchLabel.ResolveAndReduce): Added `bool allow_nullable'
1146 argument; always allow a `null' label if true.
1147 (Switch.SwitchGoverningType): Take an `Expression expr' argument.
1148 (Switch.TableSwitchEmit, Switch.SimpleSwitchEmit): Check whether
1149 we have a `null' label and mark the new `null_target' label;
1150 default to the `default' label.
1151 (Switch.Resolve): Add support for nullable types. Fixes #78630.
1153 2006-06-15 Martin Baulig <martin@ximian.com>
1155 * class.cs (Operator.Define): Allow an implicit/explicit operator
1156 to convert to/from a nullable value of the enclosing type.
1158 * generic.cs (TypeManager.IsNullableTypeOf): New public method.
1159 (Nullable.Unwrap, Nullable.Wrap): Make these classes public.
1162 (Convert.ImplicitStandardConversionExists): Add support for lifted
1163 implicit/explicit conversions.
1164 (Convert.ImplicitConversionStandard): Likewise.
1166 2006-06-13 Martin Baulig <martin@ximian.com>
1168 * ecore.cs (SimpleName.DoSimpleNameResolve): Check whether we have
1169 type arguments and create a ConstructedType if necessary. Fixes #78400.
1171 2006-06-04 Marek Safar <marek.safar@seznam.cz>
1173 * parameter.cs (Parameter.ApplyAttributeBuilder): More DefaultValue
1174 attribute applicable tests for attribute argument.
1176 2006-06-02 Raja R Harinath <rharinath@novell.com>
1179 * expression.cs (Binary.DoNumericPromotions): Remove and rewrite.
1180 (Binary.OverloadResolve_PredefinedIntegral): New.
1181 (Binary.OverloadResolve_PredefinedFloating): New.
1182 (Binary.OverloadResolve_PredefinedString): New.
1183 (Binary.ResolveOperator): Use those instead of DoNumericPromotions.
1184 Follow the standard more closely, and treat numeric promotions in
1185 terms of overload resolution.
1186 (Binary.CheckShiftArguments): Simplify.
1188 2006-06-01 Raja R Harinath <rharinath@novell.com>
1190 * flowanalysis.cs (MyBitVector): Simplify representation.
1191 (MyBitVector.Clone): Avoid allocating BitArray.
1192 (MyBitVector.operator&): Rename from MyBitVector.And and make symmetric.
1193 (MyBitVector.operator|): Likewise, with MyBitVector.Or.
1194 (*): Update. Change all references to MyBitVector.And and
1195 MyBitVector.Or to &= and |=.
1197 2006-05-31 Raja R Harinath <rharinath@novell.com>
1199 * generic.cs (Nullable.LiftedBinaryOperator.EmitEquality):
1200 Use bne.un instead of ceq+brfalse.
1203 * typemanager.cs (IsUnmanagedType): Disallow generic types and
1206 2006-05-29 Raja R Harinath <rharinath@novell.com>
1209 * cs-parser.jay (formal_parameter_list): Extend the pattern below
1210 to param arguments too.
1212 2006-05-26 Miguel de Icaza <miguel@novell.com>
1214 * cs-parser.jay: Catch another parsing form for arglist being
1215 followed by other arguments. Fixes #78313.
1217 2006-05-25 Raja R Harinath <rharinath@novell.com>
1220 * expression.cs (Binary.DoResolve): Use Nullable.LiftedBinaryOperator
1221 also when one of the operands is a null literal.
1222 * generic.cs (Nullable.LiftedBinaryOperator.EmitEquality): Rewrite
1223 to improve clarity, and generate slightly better code.
1225 2006-05-24 Raja R Harinath <rharinath@novell.com>
1227 * flowanalysis.cs (FlowBranchingToplevel.AddReturnOrigin): Move
1228 checking of out parameters to ...
1229 (FlowBranchingToplevel.Merge): ... here.
1230 (FlowBranchingException.AddBreakOrigin): If 'finally_vector' is
1231 set, propagate the origin upward, and only complain if there was
1233 (FlowBranchingException.AddContinueOrigin): Likewise.
1234 (FlowBranchingException.AddReturnOrigin): Likewise.
1235 (FlowBranchingException.AddGotoOrigin): Likewise.
1237 2006-05-23 Raja R Harinath <rharinath@novell.com>
1239 * flowanalysis.cs (UsageVector.MergeOrigins): If an origin is
1240 unreachable, skip it.
1241 (FlowBranchingException.Merge): Always propagate jumps, even if
1242 the finally block renders subsequent code unreachable.
1244 2006-05-18 Raja R Harinath <rharinath@novell.com>
1247 * statement.cs (Goto.Resolve): Move responsibility for resolving
1248 'goto' to FlowBranching.AddGotoOrigin.
1249 (Goto.SetResolvedTarget): New. Callback to set the
1250 LabeledStatement that's the target of the goto.
1251 (Goto.DoEmit): Use Leave instead of Br when crossing an
1252 unwind-protect boundary.
1253 * flowanalysis.cs (FlowBranching.AddGotoOrigin): Rename from
1254 LookupLabel and adjust to new semantics.
1255 (FlowBranchingToplevel.AddGotoOrigin): Likewise.
1256 (FlowBranchingBlock.AddGotoOrigin): Likewise. Use
1257 Goto.SetResolvedTarget to update target.
1258 (FlowBranchingLabeled.AddGotoOrigin): Likewise.
1259 (FlowBranchingException.AddGotoOrigin): Rewrite to be similar to
1260 AddBreakOrigin & co. Delay propagation until ...
1261 (FlowBranchingException.Merge): ... this.
1263 * statement.cs (Block.Resolve): Always depend on flow-branching to
1264 determine unreachability. Kill workaround that originally emitted
1265 only one statement after an "unreachable" label (see infloop in
1268 Fix #77869, #76148, #77755, #75255 and a host of other bugs.
1269 This is still "wrong", but anything better would probably need a
1270 multi-pass algorithm.
1271 * flowanalysis.cs (FlowBranchingLabeled): Salt away a copy of the
1272 usage vector. Force current usage vector to be reachable, to
1273 optimistically signify backward jumps.
1274 (FlowBranchingLabeled.LookupLabel): Note if a backward jump is
1276 (FlowBranchingLabeled.Merge): New. If no backward jump was
1277 detected, return the original salted-away usage vector instead,
1278 updated with appropriate changes. Print unreachable warning if
1280 * statement.cs (Block.Resolve): Don't print unreachable warning on
1281 a labeled statement.
1283 2006-05-17 Gert Driesen <drieseng@users.sourceforge.net>
1285 * driver.cs: Pass filename without path to AssemblyBuilder's
1286 AddResourceFile. Fixes bug #78407.
1288 2006-05-17 Raja R Harinath <rharinath@novell.com>
1290 * statement.cs (LabeledStatement.Resolve): Move merging of origins ...
1291 * flowanalysis.cs (FlowBranchingLabeled): ... here.
1292 (FlowBranching.MergeChild): Overwrite
1293 reachability information from Labeled branchings too.
1295 2006-05-16 Raja R Harinath <rharinath@novell.com>
1297 * statement.cs (Goto.Resolve): Merge jump origins here ...
1298 * flowanalysis.cs (FlowBranching.Label): ... rather than here.
1300 * flowanalysis.cs (FlowBranching.LookupLabel): Move CS0159 check ...
1301 (FlowBranchingToplevel.LookupLabel): ... here. Add CS1632 check.
1302 (FlowBranchingGoto.LookupLabel): New. Handle back jumps.
1303 (FlowBranchingBlock.LookupLabel): Call LabeledStatement.AddReference
1305 * statement.cs (Goto.Resolve): ... not here.
1306 (Goto.Emit): Remove CS1632 check.
1308 2006-05-14 Marek Safar <marek.safar@seznam.cz>
1310 * ecore.cs (Expression.ResolveAsTypeTerminal): Fixed type in the obsolete
1313 2006-05-11 Raja R Harinath <rharinath@novell.com>
1315 * flowanalysis.cs (UsageVector.MergeJumpOrigins): Kill.
1316 (FlowBranchingBlock.Label): Use UsageVector.MergeOrigins.
1317 (FlowBranchingException.Label): Likewise.
1319 * flowanalysis.cs (MyBitVector.SetAll): New. Sets all bits to the
1321 (MyBitVector.Or): Use it to avoid losing information (Count).
1322 (FlowBranching.MergeOrigins): Likewise.
1324 * flowanalysis.cs (UsageVector.IsDirty): Remove.
1325 (UsageVector.Parameters, UsageVector.ParameterVector): Likewise.
1326 (UsageVector.Locals, UsageVector.LocalVector): Likewise.
1327 (UsageVector.ToString): Simplify.
1328 (UsageVector.MergeSiblings): Move here from ...
1329 (FlowBranching.Merge): ... here.
1330 (FlowBranchingToplevel.CheckOutParameters): Take an UsageVector,
1333 2006-05-10 Raja R Harinath <rharinath@novell.com>
1335 * flowanalysis.cs (UsageVector.MergeOrigins): Simplify, now that a
1336 null bitvector is treated as all-true.
1338 * flowanalysis.cs (MyBitVector.And, MyBitVector.Or): Make lazier.
1339 (MyBitVector): Rationalize invariants. 'vector != null' implies
1340 that we have our own copy of the bitvector. Otherwise,
1341 'InheritsFrom == null' implies all inherited bits are true.
1343 2006-05-09 Marek Safar <marek.safar@seznam.cz>
1345 * statement.cs (LocalInfo): Add IsConstant.
1346 (LocalInfo.DeclareLocal): Moved from EmitMeta and changed to don't emit
1347 local variable for constants.
1349 2006-05-09 Raja R Harinath <rharinath@novell.com>
1351 * flowanalysis.cs (MyBitVector.Empty): New.
1352 (MyBitVector): Don't allow InheritedFrom to be null.
1353 (MyBitVector.And, MyBitVector.Or): Treat 'null' as all-ones.
1354 (UsageVector, FlowBranching): Update to changes.
1356 * flowanalysis.cs (FlowBranching.InTryWithCatch): Don't terminate
1357 recursion. The 'Parent == null' condition isn't sufficient for
1359 (FlowBranching.AddBreakOrigin): Likewise.
1360 (FlowBranching.AddContinueOrigin): Likewise.
1361 (FlowBranching.AddReturnOrigin): Likewise.
1362 (FlowBranching.StealFinallyClauses): Likewise.
1363 (FlowBranching.MergeTopBlock): Move to FlowBranchingToplevel.
1364 (FlowBranching.CheckOutParameters): Likewise.
1365 (FlowBranchingToplevel): Terminate all the above recursions here.
1366 (FlowBranchingToplevel.End): Rename from MergeTopBlock.
1367 * codegen.cs (EmitContext.ResolveTopBlock): Update to changes.
1369 * flowanalysis.cs (BranchingType.Toplevel): New. Represents a
1371 (FlowBranchingToplevel): New. Empty for now.
1372 (FlowBranching.MergeTopBlock): Update.
1373 * codegen.cs (EmitContext.ResolveTopBlock): Create a Toplevel
1374 branching for the anonymous delegate.
1375 (EmitContext.StartFlowBranching): Add ToplevelBlock variant.
1377 * flowanalysis.cs (UsageVector.MergeOrigins): Reorganize.
1378 (UsageVector.MergeJumpOrigins): Don't ignore current reachability
1379 information at the start of the merge. Reorganize.
1381 2006-05-07 Marek Safar <marek.safar@seznam.cz>
1383 * class.cs (MethodData.Define): Method cannot implement interface accessor.
1385 2006-05-07 Marek Safar <marek.safar@seznam.cz>
1387 * expression.cs (QualifiedAliasMember.ResolveAsTypeStep): Pass location
1388 to newly introduced ctor.
1390 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Moved an error
1391 message to one place.
1392 (GlobalRootNamespace.Error_NamespaceDoesNotExist): Custom message for
1395 2006-05-07 Marek Safar <marek.safar@seznam.cz>
1397 * const.cs (Const.Error_ExpressionMustBeConstant): Better error message.
1399 * ecore.cs (Expression.ResolveAsConstant): Updated.
1401 * statement.cs (ResolveMeta): Updated.
1403 2006-05-06 Marek Safar <marek.safar@seznam.cz>
1405 * cs-parser.jay: __arglist cannot be used in initializer.
1407 2006-05-06 Marek Safar <marek.safar@seznam.cz>
1410 * namespace.cs (LocalAliasEntry.DoResolve): Don't allow to access nested
1413 2006-05-05 Raja R Harinath <rharinath@novell.com>
1415 * statement.cs (EmptyStatement.ResolveUnreachable): Override.
1416 (LabeledStatement): Add 'name' parameter.
1417 (LabeledStatement.Name, LabeledStatement.JumpOrigins): New.
1418 (Block.AddLabel): Update to changes.
1419 * cs-parser.jay (labeled_statement): Likewise.
1421 * flowanalysis.cs (BranchingType.Labeled): New.
1422 (UsageVector.MergeOrigins): Remove unused 'branching' argument.
1423 (FlowBranchingLabeled): New. Does nothing for now, but will
1424 eventually handle 'goto' flows.
1425 * codegen.cs (StartFlowBranching): Add new LabeledStatement variant.
1426 * statement.cs (LabeledStatement.Resolve): Create a FlowBranching
1427 that's terminated ...
1428 (Block.Resolve): ... here.
1430 * flowanalysis.cs (UsageVector.MergeFinally): Remove.
1431 (UsageVector.MergeFinallyOrigins): Likewise.
1432 (FlowBranching.InTryOrCatch): Likewise.
1433 (FlowBranching.AddFinallyVector): Likewise.
1434 (FlowBranchingException): Update to changes.
1437 * statement.cs (Return.Resolve): Move error checking to ...
1438 * flowbranching.cs (FlowBranching.AddReturnOrigin): ... this.
1439 (FlowBranchingException): Handle return origins like break and
1441 (FlowBranching.UsageVector.CheckOutParameters): Remove.
1443 2006-05-04 Marek Safar <marek.safar@seznam.cz>
1446 * class.cs (TypeContainer.FindMembers): Includes event method in the methods
1449 2006-05-04 Marek Safar <marek.safar@seznam.cz>
1452 * class.cs (MethodData.Define): Do public accessor check only when method
1453 implements an interface.
1455 2006-05-04 Raja R Harinath <rharinath@novell.com>
1457 Remove special handling of 'break'
1458 * flowanalysis.cs (Reachability): Remove all mention of 'breaks'.
1459 (Reachability.Meet): Simplify. Remove 'do_breaks' argument.
1460 (UsageVector.Break): Remove.
1461 (FlowBranching.Merge): Use 'Reachable.IsUnreachable' to determine
1463 (FlowBranchingBreakable.Merge): Don't ResetBreaks.
1465 * statement.cs (Break.Resolve): Call UsageVector.Goto (), not
1466 UsageVector.Breaks (). Don't set NeedsReturnLabel.
1468 2006-05-03 Marek Safar <marek.safar@seznam.cz>
1471 * pending.cs (PendingImplementation.BaseImplements): A found member cannot
1472 be the interface member.
1474 2006-05-03 Marek Safar <marek.safar@seznam.cz>
1477 * constant.cs (LongConstant.EmitLong): Fixed to catch also negative values
1478 for emitting small (int) values.
1480 2006-05-03 Raja R Harinath <rharinath@novell.com>
1483 * flowanalysis.cs (FlowBranchingException.Merge): Ensure
1484 control-flow passes through the 'finally' after merging-in all the
1485 control-flows from 'try' and the 'catch' clauses.
1487 * flowanalysis.cs (FlowBranching.IsLoop): Remove.
1488 (FlowBranching.IsTryOrCatch): Remove 'is_return' parameter. It's
1489 always true at the only non-recursive entry point.
1490 (FlowBranching.CreateBranching) [BranchingType.Loop]: Return a
1491 FlowBranchingBreakable.
1492 (FlowBranchingLoop): Remove.
1493 * statement.cs (Return.DoResolve): Update to changes.
1496 * flowanalysis.cs (FlowBranching.BranchingType.Embedded): New.
1497 (FlowBranching.CreateBranching): Handle it: create a
1498 FlowBranchingContinuable.
1499 (FlowBranching.BreakCrossesExceptionBoundary): Remove.
1500 (FlowBranching.AddContinueOrigin): Similar to AddBreakOrigin,
1501 except that it handles the 'continue' command.
1502 (FlowBranching.UsageVector.MergeOrigins): Rename from
1504 (FlowBranchingContinuable): Similar to FlowBranchingBreakable,
1505 except that it overrides AddContinueOrigin.
1506 (FlowBranchingException): Override AddContinueOrigin, similar to
1508 * statement.cs (While.Resolve, Foreach.ArrayForeach.Resolve):
1509 Create a new branching around the embedded statement.
1510 (Do.Resolve, For.Resolve): Likewise. Do reachability analysis for
1511 control flow after the embedded statement.
1512 (Continue.Resolve): Move all error checking to AddContinueOrigin.
1514 * flowanalysis.cs (FlowBranching.IsSwitch): Remove.
1515 (FlowBranching.CreateBranching) [BranchingType.Switch]: Create a
1516 FlowBranchingBreakable.
1517 (FlowBranchingSwitch): Remove.
1520 * statement.cs (Break.Resolve): Simplify. Move responsibility for
1521 error reporting to ...
1522 * flowanalysis.cs (FlowBranching.AddBreakOrigin) ... this.
1523 Rename from 'AddBreakVector'. Add new location argument. Return
1524 a bool indicating whether the 'break' crosses an unwind-protect.
1525 (FlowBranchingException.AddBreakOrigin): Add.
1526 (FlowBranchingException.Merge): Propagate 'break's to surrounding
1527 flowbranching after updating with the effects of the 'finally'
1529 (FlowBranchingBreakable): New common base class for
1530 FlowBranchingLoop and FlowBranchingSwitch.
1532 * statement.cs (Foreach.ArrayForeach.Resolve): Set barrier after
1534 (Foreach.CollectionForeach.Resolve): Remove extraneous flowbranching.
1536 2006-05-02 Raja R Harinath <rharinath@novell.com>
1538 * statement.cs (Do.Resolve): If the loop is infinite, set the
1540 (While.Resolve, For.Resolve): Set a barrier after the embedded
1541 statement. There's no direct control flow that goes from the end
1542 of the embedded statement to the end of the loop.
1543 * flowanalysis.cs (FlowBranching.Infinite): Remove.
1544 (FlowBranchingLoop.Merge): Don't look at 'Infinite'. The changes
1545 above ensure that the reachability is correctly computed.
1547 * flowanalysis.cs (Reachability.ResetBarrier): Remove.
1548 (UsageVector.MergeBreakOrigins): If the current path is
1549 unreachable, treat it as if all parameters/locals are initialized.
1550 (FlowBranchingLoop.Merge): Don't clear any barriers. Handle
1551 infinite loops before merging-in break origins.
1553 * flowanalysis.cs (Reachability.Meet): Simplify code handling 'returns'.
1554 (Reachability.Reachable): Split part into ...
1555 (Reachability.Unreachable): ... this. Simplify.
1556 (Reachability.IsUnreachable): Use 'Unreachable' instead.
1558 * flowanalysis.cs (Reachability.SetReturnsSometimes): Remove.
1559 (Reachability.SetThrowsSometimes): Likewise.
1560 (FlowBranchingBlock.MergeTopBlock): Don't compare against
1561 TriState.Always, use corresponding property.
1562 * statement.cs (Lock.Resolve, Try.Resolve, Using.Resolve): Likewise.
1563 (Block.Resolve): Likewise. Remove some redundant checks.
1565 2006-05-02 Raja R Harinath <harinath@gmail.com>
1567 * flowanalysis.cs (UsageVector.Throw): Set barrier too.
1568 (Reachability.Meet): Don't bother checking AlwaysThrows --
1569 barrier is always set.
1570 (FlowBranchingBlock.Merge): Likewise.
1572 2006-05-01 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
1574 * attribute.cs: fixed_buffer_cache is declared only if NET_2_0 is
1575 defined, so it's references should also compile only for NET_2_0
1576 (as occurs in mcs version)
1578 2006-05-01 Raja R Harinath <harinath@gmail.com>
1580 * codegen.cs (EmitContext.ResolveTopBlock): Remove redundant
1581 checks for unreachable.
1583 2006-05-01 Marek Safar <marek.safar@seznam.cz>
1586 * flowanalysis.cs (UsageVector.IsAssigned): Add flag to ignore short path.
1588 * statement.cs (Block.UsageWarning): Uses newly introduced flag to detect
1589 whether field is really assigned.
1591 2006-04-30 Raja R Harinath <harinath@gmail.com>
1593 * flowanalysis.cs (Reachability): Make 4-argument constructor
1595 (Reachability.Meet): Rename from 'And'. Remove static variant.
1596 (Reachability.Always): Rename from the highly misleading
1597 'Reachability.Never'.
1598 (FlowBranching.Merge): Update to changes. Mark an impossible
1599 situation with a 'throw'.
1600 (*): Update to changes.
1602 2006-04-29 Raja R Harinath <harinath@gmail.com>
1604 * flowanalysis.cs (TriState): Rename from FlowBranching.FlowReturns.
1606 (FlowBranching.TriState_Meet): Rename from AndFlowReturns. Simplify.
1607 (FlowBranching.TriState_Max): Rename from OrFlowReturns. Simplify.
1608 (*): Update to changes.
1609 * statement.cs: Update to changes.
1611 2006-04-28 Marek Safar <marek.safar@seznam.cz>
1614 *class.cs (Method.FindOutBaseMethod): Base method cannot be property method.
1616 2006-04-28 Raja R Harinath <harinath@gmail.com>
1618 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't create a
1621 * flowanalysis.cs (UsageVector.MergeChild): Change FlowBranching
1622 argument to two arguments: an usage-vector and a bool. Move call
1623 to FlowBranching.Merge () ...
1624 (FlowBranching.MergeChild, FlowBranching.MergeTopBlock): ... here.
1626 * flowanalysis.cs (UsageVector.MergeChild): Move special-case
1627 handling of loop and switch reachability to ...
1628 (FlowBranchingLoop.Merge, FlowBranchingSwitch.Merge): ... these.
1630 2006-04-27 Raja R Harinath <harinath@gmail.com>
1632 * flowanalysis.cs (FlowBranching.InLoop): Move special-case
1633 handling to FlowBranchingLoop.InLoop.
1634 (FlowBranching.InSwitch): Likewise, to FlowBranchingSwitch.
1636 2006-04-26 Marek Safar <marek.safar@seznam.cz>
1639 * anonymous.cs (AnonymousMethod.DoResolve): Moved the check whether
1640 anonymous method is allowed from AnonymousContainer here.
1642 * attribute.cs, codegen.cs (EmitContext): Add IsAnonymousMethodAllowed.
1644 2006-04-24 Raja R Harinath <rharinath@novell.com>
1647 * flowanalysis.cs (MyBitVector.Or): Add null check on argument.
1649 2006-04-23 Marek Safar <marek.safar@seznam.cz>
1652 * constant.cs (FloatConstant.Reduce): Add range checking for checked context.
1653 (DoubleConstant.Reduce): Ditto.
1655 2006-04-23 Raja R Harinath <rharinath@novell.com>
1657 * expression.cs (LocalVariableReference.DoResolveBase): Simplify.
1658 Remove 'lvalue_right_side' argument. Move parts to ...
1659 (LocalVariableReference.ResolveLocalInfo, LocalVariable.DoResolve)
1660 (LocalVariable.DoResolveLValue): ... these.
1662 2006-04-21 Raja R Harinath <rharinath@novell.com>
1665 * codegen.cs (EmitContext.InRefOutArgumentResolving): Remove.
1666 * expression.cs (EmptyExpression.LValueMemberOutAccess): New.
1667 (LocalVariableReference.DoResolveBase): Use it to implement new
1669 (IndexerAccess.DoResolveLValue): Handle LValueMemberOutAccess.
1670 (Argument.Resolve): Simplify. Move CS1510 check ...
1671 * ecore.cs (Expression.ResolveLValue): ... here.
1672 (UnboxCast.DoResolveLValue): Handle LValueMemberOutAccess.
1673 (PropertyExpr.DoResolveLValue): Likewise.
1674 (FieldExpr.Report_AssignToReadonly): Likewise.
1675 (FieldExpr.DoResolve): Add 'out_access' argument. Use
1676 LValueMemberAccess or LValueMemberOutAccess on instance depending
1678 (FieldExpr.DoResolveLValue): Pass 'out_access' argument to
1679 DoResolve as appropriate.
1681 2006-04-20 Raja R Harinath <rharinath@novell.com>
1684 * expression.cs (Invocation.VerifyArgumentsCompat): Don't try
1685 implicit conversions on 'out' and 'ref' arguments.
1687 * expression.cs (Invocation.VerifyArgumentsCompat): Reorganize to
1688 improve clarity. Remove dead code.
1691 * statement.cs (Block.UsageWarning): Allow VariableInfo to be null.
1692 (Catch.Resolve): Resolve VarBlock if it exists.
1694 2006-04-19 Miguel de Icaza <miguel@novell.com>
1696 * statement.cs (Foreach.EmitFinally): Do not emit the enumerator
1697 twice, this was some residual code, the enumerator was emitted
1698 properly in the two branche of if later.
1702 Thanks to Martin for finding the source of the problem
1704 2006-04-19 Raja R Harinath <rharinath@novell.com>
1706 * expression.cs (Cast.ResolveLValue): Remove. The result of a
1707 cast is never an lvalue.
1708 (Cast.DoResolve, Cast.ResolveRest): Combine.
1709 (Argument.Emit): Simplify slightly. Move 'Expr is
1710 IMemoryLocation' check ...
1711 (Argument.Resolve): ... here.
1712 (Argument.Error_LValueRequired): Remove. Inline into only user.
1714 Simplifications. Fix cs0191-2.cs
1715 * ecore.cs (FieldExpr.DoResolve): Move handling of CS0192, CS0198,
1716 CS1649 and CS1651 to ...
1717 (FieldExpr.Report_AssignToReadonly): ... this. Simplify by moving
1718 the actual selection of the error code and message to a lookup
1719 table. Add a dummy return value to simplify callsites.
1720 (FieldExpr.ResolveLValue): Don't allow a constructor to write to
1721 readonly fields of other instances of the same type. Move CS0197
1723 * expression.cs (Argument.Resolve): ... here. Simplify code.
1724 Ensure that ec.InRefOutArgumentResolving is only set during LValue
1725 resolution of an out or ref argument. The code simplification
1726 above uses this invariant.
1728 2006-04-18 Raja R Harinath <rharinath@novell.com>
1730 Possibly fix #77752. Fix cs1690-[4-7].cs.
1731 * ecore.cs (Expression.CheckMarshalByRefAccess): Renamed from
1732 CheckMarshallByRefAccess. Drop parameter.
1733 (FieldExpr.CheckMarshalByRefAccess): Update. Change CS1690 to a
1735 (FieldExpr.DoResolve): Call CheckMarshalByRefAccess on
1737 * report.cs (AllWarnings): Add CS1690.
1738 * expression.cs (Argument.Resolve): Use EmptyExpression.OutAccess
1740 (LocalVariableReference.DoResolveBase): Update.
1742 2006-04-09 Marek Safar <marek.safar@seznam.cz>
1744 * class.cs (MethodOrOperator): Moved common parts from method class.
1745 detect obsolete attributes.
1746 (Method.Define): Simplified as it reuses code from base.
1747 (Constructor.ValidAttributeTargets): Fixed issue found during
1749 (Destructor.ValidAttributeTargets): Fixed issue found during
1751 (Operator): Finished refactoring set off by #78020. Operator class is now
1752 ordinary method class.
1754 * anonymous.cs: Updated.
1756 2006-04-09 Marek Safar <marek.safar@seznam.cz>
1758 * class.cs (Constructor.Emit): Don't emit the attributes twice.
1760 2006-04-09 Marek Safar <marek.safar@seznam.cz>
1762 * class.cs (Operator.Emit): Extracted code from MethodData to correctly
1763 detect obsolete attributes.
1764 (Method.CreateEmitContext): Moved to MethodOrOperator.
1766 2006-04-09 Marek Safar <marek.safar@seznam.cz>
1769 * class.cs (TypeContainer.MemberCoreArrayList.DefineContainerMembers): Throw
1770 customized exception to make crash detection easier.
1771 (MethodOrOperator): Started to work on new base class for methods and
1773 (Method): Derives from MethodOrOperator.
1774 (Constructor.Emit): Emits its own attributes.
1775 (AbstractPropertyEventMethod.Emit): Ditto.
1776 (Operator): Derives from MethodOrOperator, will refactor fully in extra
1778 (Operator.Emit): It's temporary more tricky than should be.
1780 * doc.cs (GetMethodDocCommentName): Updated after operator changes.
1782 * report.cs (InternalErrorException): Add ctor with inner exception.
1784 2006-04-08 Marek Safar <marek.safar@seznam.cz>
1787 * ecore.cs (SimpleName.ResolveAsTypeStep): Report better error when type is
1790 2006-04-07 Marek Safar <marek.safar@seznam.cz>
1793 * expression.cs (ArrayCreation.GetAttributableValue): Creates correctly typed
1796 2006-04-06 Marek Safar <marek.safar@seznam.cz>
1798 * class.cs (Class.ApplyAttributeBuilder): Report an error when ComImport
1799 attribute is present and Guid not.
1800 (Interface.ApplyAttributeBuilder): Ditto.
1802 * attribute.cs: Add error message.
1804 2006-04-06 Marek Safar <marek.safar@seznam.cz>
1808 * attribute.cs (Attribute.AttachTo): The attribute can have multiple
1809 sources (it's composite) so hold them in extra array as they are used in
1810 Emit phase only. It worked in the previous versions by mistake.
1811 (Attribute.Emit): Emit attribute for more owners when exist.
1813 * codegen.cs, class.cs: Updated to don't re-attach attribute twice as now
1814 it has now different behaviour.
1816 2006-04-04 Marek Safar <marek.safar@seznam.cz>
1818 * constant.cs (Constant.IsDefaultInitializer): New method.
1820 * class.cs: Updated.
1822 * expression.cs (ArrayCreation.CheckIndices): Add an optimization to don't
1823 re-initialize default values. It saves KBs almost for every assembly.
1824 Thanks Zoltan for the idea.
1825 (ArrayCreation.ResolveInitializers): Renamed from ValidateInitializers.
1826 (ArrayCreation.DoResolve): Resolve only once.
1827 (ArrayCreation.Emit): Emit static initializer only when it is faster.
1828 (ArrayCreation.GetAttributableValue): Cope with optimized values.
1830 2006-04-03 Zoltan Varga <vargaz@gmail.com>
1832 * report.cs (Warning, Error): Add 0-, 1-, and 2- argument specializations.
1835 2006-04-01 Marek Safar <marek.safar@seznam.cz>
1837 * assign.cs (Assign.DoResolve): Assignment to same variable can occur
1838 in an embedded statement too.
1840 2006-04-01 Raja R Harinath <rharinath@novell.com>
1843 * typemanager.cs (IsNestedChildOf): Drop generic arguments before
1847 * statement.cs (Switch.EmitObjectInteger) [ulong]: Remove bad cast.
1850 * report.cs (SymbolRelatedToPreviousError): Drop generic type
1851 arguments before checking whether a type is reflected or not.
1854 * expression.cs (Invocation.IsApplicable): Ensure a generic method
1855 definition doesn't take part in overload resolution.
1856 (Invocation.IsParamsMethodApplicable): Likewise.
1857 (Invocation.OverloadResolve): When replacing a reflected override
1858 method with its base definition, ensure that type arguments are
1861 2006-04-01 Marek Safar <marek.safar@seznam.cz>
1865 * class.cs (TypeContainer.AddPartial): Don't report an error when modifier
1868 * modifiers.cs: Add DEFAULT_ACCESS_MODIFER.
1870 2006-03-31 Marek Safar <marek.safar@seznam.cz>
1872 * assign.cs (LocalTemporary): Don't require ILGenerator in the resolve
1875 * anonymous.cs, assign.cs, ecore.cs, expression.cs: Updated after
1876 LocalTemporary change.
1878 * class.cs (ClassOrStruct.DefineDefaultConstructor): Moved from
1880 (ClassOrStruct.DefineFieldInitializers): Implemented static field
1881 initializers optimization.
1882 (ClassOrStruct.TypeAttr): Moved from modifiers.
1883 (Constructor.CheckBase): Don't crash when static ctor has parameters.
1884 (FieldBase.ResolveInitializer): Resolves initializer.
1885 (FieldBase.HasDefaultInitializer): New property.
1887 * cs-parser.jay: Removed message.
1889 * expression.cs (CompilerGeneratedThis): New specialization.
1891 * modifiers.cs (TypeAttr): Moved to ClassOrStruct.TypeAttr
1893 2006-03-28 Marek Safar <marek.safar@seznam.cz>
1895 * cs-parser.jay, cs-tokenizer.cs: On demand Stack allocation.
1897 2006-03-27 Marek Safar <marek.safar@seznam.cz>
1899 * ecore.cs (Expression.ResolveAsConstant): Clean up, enum constants should
1900 be now EnumConstants only.
1902 2006-03-27 Marek Safar <marek.safar@seznam.cz>
1904 * attribute.cs, driver.cs: Reset more caches.
1906 2006-03-26 Marek Safar <marek.safar@seznam.cz>
1908 * cs-tokenizer.cs (adjust_real): Uses float.Parse for float literals.
1910 2006-03-26 Marek Safar <marek.safar@seznam.cz>
1912 * constant.cs (Constant.Reduce): Replaced EmitContext with single bool
1913 for easier reuse. Updated all overrides.
1914 (IntegralConstant): New base class for all integral constants.
1915 (IntegralConstant.Error_ValueCannotBeConverted): When assigned value if out
1916 of the constant range, report custom error.
1917 (UIntConstant.Reduce): Fixed uint conversion.
1919 * ecore.cs, literal.cs: Reduce updates.
1921 2006-03-26 Marek Safar <marek.safar@seznam.cz>
1925 * class.cs (Constructor.Define): Removed extra if for default ctors.
1926 A patch from Atsushi Enomoto.
1928 2006-03-26 Marek Safar <marek.safar@seznam.cz>
1930 * attribute.cs (Attribute.ResolveConstructor): Conversion was moved to
1931 GetAttributableValue.
1933 * constant.cs (Constant.GetAttributableValue): Does implicit conversion
1936 * convert.cs (ImplicitConversionRequired): Error message moved to
1939 * ecore.cs (Expression.GetAttributableValue): Add type parameter for
1940 automatic implicit conversion of an output value.
1941 (EnumConstant.GetAttributableValue): Don't reduce the enum constants.
1943 * expression.cs (ArrayCreation.GetAttributableValue): Add element type
1945 (TypeOf.GetAttributableValue): Add extra handling for object type.
1947 * literal.cs (DoubleLiteral.Error_ValueCannotBeConverted): Doubles can have
1948 special error message.
1950 2006-03-25 Marek Safar <marek.safar@seznam.cz>
1952 * class.cs (Constructor.Emit): Don't crash when struct ctor is
1954 (Constructor.ApplyAttributeBuilder): Transform MethodImplAttribute to be
1955 compatible with MS runtime.
1957 2006-03-23 Marek Safar <marek.safar@seznam.cz>
1959 * attribute.cs (Attribute.ResolveConstructor): Check for an invalid
1960 attribute arguments here.
1962 * class.cs (Indexer.Define): The check was moved to attribute class.
1964 2006-03-21 Marek Safar <marek.safar@seznam.cz>
1966 * expression.cs (StringConcat.Append): Reverted back to no warning state.
1968 2006-03-21 Marek Safar <marek.safar@seznam.cz>
1970 * const.cs (Error_ConstantCanBeInitializedWithNullOnly): Share a message.
1972 * statement.cs (Block.ResolveMeta): Look for wrong object constants in
1975 2006-03-21 Atsushi Enomoto <atsushi@ximian.com>
1977 * doc-bootstrap.cs : fix build.
1979 2006-03-20 Marek Safar <marek.safar@seznam.cz>
1981 * expression.cs (StringConcat.Append): Issue a warning when empty string
1984 2006-03-20 Marek Safar <marek.safar@seznam.cz>
1986 * assign.cs (CompoundAssign.ResolveSource): Removed.
1988 * attribute.cs (ResolvePossibleAttributeType): Updated after MemberAccess
1991 * class.cs (TypeContainer.FindMethods): Removed.
1992 (TypeContainer.CheckMemberUsage): Made static.
1994 * codegen.cs (GetAssemblyName): Uses Length for empty string test.
1996 * constant.cs (CheckRange): Removed unused type argument.
1997 (CheckUnsigned): Removed unused type argument.
1999 * cs-parser.jay: Updated after MemberAccess clean up.
2000 Uses Length for empty string test.
2002 * cs-tokenizer.cs: Uses Length for empty string test.
2003 (IsCastToken): Made static.
2004 (is_hex): Made static.
2005 (real_type_suffix): Made static.
2007 * decl.cs (SetupCache): Made static.
2008 (OnGenerateDocComment): Removed unused ds argument.
2010 * delegate.cs (VerifyDelegate): Removed unused argument.
2012 * doc.cs: Uses Length for empty string test.
2014 * driver.cs: Uses Length for empty string test.
2016 * enum.cs (IsValidEnumType): Made static
2018 * expression.cs (EnumLiftUp): Removed unused argument.
2019 (ResolveMethodGroup): Ditto.
2020 (BetterConversion): Ditto.
2021 (GetVarargsTypes): Ditto.
2022 (UpdateIndices): Ditto.
2023 (ValidateInitializers): Ditto.
2024 (MemberAccess.ctor): Ditto.
2025 (GetIndexersForType): Ditto.
2027 * flowanalysis.cs: (MergeFinally): Removed unused argument.
2029 * iterators.cs: Updated after MemberAccess clean up.
2031 * location.cs: Uses Length for empty string test.
2033 * namespace.cs: Uses Length for empty string test.
2035 * report.cs (CheckWarningCode): Made static.
2037 * statement.cs (LabeledStatement): Removed unused argument.
2039 * typemanager.cs (FilterNone): Removed.
2041 2006-03-18 Marek Safar <marek.safar@seznam.cz>
2043 * codegen.cs (EmitContext.TestObsoleteMethodUsage): Removed as it become
2046 * class.cs: Updated.
2048 2006-03-18 Marek Safar <marek.safar@seznam.cz>
2050 * cs-parser.jay.cs: __arglist is not allowed for delegates.
2052 2006-03-18 Marek Safar <marek.safar@seznam.cz>
2056 * anonymous.cs.cs (AnonymousMethod): Add host to allow access to
2058 (AnonymousMethod.ImplicitStandardConversionExists): New method.
2059 (AnonymousMethod.Compatible): Moved parameter resolving to DoResolve.
2060 Add more error reporting; Fixed issue with params.
2062 * convert.cs (ImplicitStandardConversionExists): Returned conversion check.
2064 * cs-parser.jay: AnonymousMethod requires host container.
2066 * delegate.cs (NewDelegate.DoResolve): Updated after Compatible changes.
2068 2006-03-18 Raja R Harinath <harinath@gmail.com>
2070 * class.cs: Change 'TypeContainer ds' constructor argument to
2071 'DeclSpace parent'. Some classes were missed below due to
2072 different naming convention.
2074 * class.cs (MemberCore.Parent): Delete. This makes the
2075 ParentContainer changes below enforceable by the compiler.
2077 Treat pointers to enclosing declaration space as 'DeclSpace', not
2079 * class.cs, const.cs, delegate.cs, enum.cs, iterator.cs: Change
2080 'TypeContainer parent' constructor argument to 'DeclSpace parent'.
2082 * statement.cs (LocalInfo..ctor): Use DeclSpace argument instead
2084 (Block.AddThisVariable): Likewise.
2085 * class.cs (MethodData.Define, MethodData.Emit): Likewise.
2086 (AbstractPropertyEventMethod.Emit): Likewise.
2087 (AbstractPropertyEventMethod.EmitMethod): Likewise.
2088 (GetMethod.Define, SetMethod.Define): Likewise.
2089 (PropertyMethod.Define, DelegateMethod.Define): Likewise.
2090 (DelegateMethod.EmitMethod): Likewise.
2092 Fix regression test-partial-13.cs.
2093 Rationalize use of PartialContainer. Ensure that the partial
2094 class semantics can be tied to type-correctness, i.e., any
2095 violation will cause a compile error.
2096 * class.cs, const.cs: Access all fields that belong to class
2097 TypeContainer via ParentContainer. Arguments of EmitContexts and
2098 Resolve()-like functions still use 'Parent'.
2100 * class.cs (SourceMethod): Use DeclSpace, not TypeContainer.
2101 (*.CreateEmitContext): Change TypeContainer argument to DeclSpace.
2102 (PropertyMethod.CheckModifiers): Remove unused argument.
2103 * codegen.cs (EmitContext..ctor): Change TypeContainer argument to
2106 2006-03-28 Raja R Harinath <rharinath@novell.com>
2108 * decl.cs (DeclSpace.LookupGeneric): Update to changes.
2110 2006-03-17 Raja R Harinath <harinath@gmail.com>
2112 Make semantics of PartialContainer simpler.
2113 * decl.cs (DeclSpace.IsPartial): Remove.
2114 * class.cs (TypeContainer.IsPartial): Likewise.
2115 (TypeContainer..ctor): Set PartialContainer to point to self.
2116 (TypeContainer.GetClsCompliantAttributeValue): Don't use IsPartial.
2117 (TypeContainer.FindNestedType): Likewise.
2118 (MemberCore.ParentContainer): Simplify. Remove deprecation.
2120 2006-03-17 Marek Safar <marek.safar@seznam.cz>
2122 * typemanager.cs.cs (GetInterfaces): Don't recreate 0-sized arrays.
2124 2006-03-15 Marek Safar <marek.safar@seznam.cz>
2126 * class.cs (FieldMember.Emit): ParentContainer is real parent for partial
2129 2006-03-15 Marek Safar <marek.safar@seznam.cz>
2131 * class.cs (Operator.Define): An error for base conversion was not
2134 2006-03-13 Marek Safar <marek.safar@seznam.cz>
2136 A fix for #77593, #77574.
2138 * class.cs (MethodCore.CheckBase): Another if for operator.
2140 2006-03-18 Marek Safar <marek.safar@seznam.cz>
2144 * expression.cs (VerifyArgumentsCompat): Reverted to double error
2145 reporting, it's more tricky than I thought.
2147 2006-03-09 Marek Safar <marek.safar@seznam.cz>
2149 * anonymous.cs (AnonymousMethod.Compatible): Don't crash when parameters
2152 * delegate.cs (Delegate.GetInvokeMethod): Use emitcontext free MemberLookup.
2153 (DelegateCreation.ImplicitStandardConversionExists): New method for just
2156 * ecore.cs (Expression.MemberLookup): Don't ask for emitcontext when it's
2159 2006-03-04 Marek Safar <marek.safar@seznam.cz>
2163 * class.cs (SetMethod.DefineParameters): Uses new parameters type ctor.
2164 (Event.Define): ditto
2165 (SetIndexerMethod.DefineParameters): Uses Parameters.MergeGenerated.
2167 * delegate.cs (Delegate.Define): Uses Parameters.MergeGenerated.
2168 Removed redundant code and set NewSlot for Invoke method too.
2170 * parameter.cs (Parameters.ctor): Add custom, type ctor.
2171 (Parameters.MergeGenerated): New method. Use this method when you merge
2172 compiler generated argument with user arguments.
2174 2006-03-03 Marek Safar <marek.safar@seznam.cz>
2176 * attribute.cs (ResolveAsTypeTerminal): Removed.
2178 * ecore.cs (Expression.ResolveAsTypeTerminal): Make virtual to allow
2179 specialization for predefined types; 30% speed up.
2180 Finally placed obsolete check to right place.
2181 (Expression.ResolveType): Removed.
2183 * enum.cs, expression.cs, parameter.cs, statement.cs, typemanager.cs:
2184 Updated after ResolveType was removed.
2186 * expression.cs (Cast.ctor): Check void cast.
2187 (Binary.ResolveAsTypeTerminal): Is never type.
2188 (Conditional.ResolveAsTypeTerminal): Is never type.
2190 * rootcontext.cs (ResolveCore): Set base type to simplify some code later.
2192 2006-03-26 Marek Safar <marek.safar@seznam.cz>
2194 * rootcontext.cs (ResolveCore): Removed System.INullableValue.
2196 2006-03-23 Martin Baulig <martin@ximian.com>
2198 * expression.cs (Is.DoResolve, As.DoResolve): Perform a dynamic
2199 type check if either of the types is an open generic type.
2201 2006-03-23 Martin Baulig <martin@ximian.com>
2204 (Convert.ExplicitTypeParameterConversion): New method; implement
2205 explicit type parameter conversions.
2207 2006-03-23 Martin Baulig <martin@ximian.com>
2209 * convert.cs (Convert.ImplicitTypeParameterConversion): Do not
2210 blindly allow all conversions if we do not have any constraints.
2212 2006-02-27 Marek Safar <marek.safar@seznam.cz>
2214 * attribute.cs (Attribute.PosArguments, Attribute.NamedArguments): Use
2215 these two separated members to simplify the code.
2216 (Attribute.Resolve): Refactored to use new fields and methods.
2217 (Attribute.ResolveConstructor): Extracted from ResolveArguments and
2218 implemented obsolete attribute checking.
2219 (Attribute.ResolveNamedArguments): Extracted from ResolveArguments and
2220 implemented obsolete checking again. It look line never ending quest ;-)
2221 (GlobalAttribute.ResolveConstructor): Need to override as the rest.
2223 * cfold.cs (BinaryFold): TryReduce throws an exception to indicate error.
2225 * constanct.cs (TryReduce): Throws OverflowException to indicate error.
2227 *class.cs (Property.Define): Add RegisterProperty call.
2229 * cs-parser.jay: Replaced ArrayList with fixed array for attribute
2230 argument groups (only 2).
2232 * ecore.cs (Expression.GetAttributableValue): New virtual method used for
2233 encoding expression to arguments.
2234 (Expression.ExprClassToResolveFlags): Just turned to property.
2236 * expression.cs (ArrayCreation.ValidateInitializers): Slightly optimized.
2237 (ArrayCreation.GetAttributableValue): Renamed from EncodeAsAttribute and
2238 optimized as well as implemented support for zero-length attributes.
2240 * typemanager.cs (TypeManager.RegisterProperty, TypeManager.GetProperty):
2241 Add caching of PropertyInfo's.
2243 2006-02-25 Marek Safar <marek.safar@seznam.cz>
2245 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Don't report
2246 error multiple times.
2248 2006-02-25 Marek Safar <marek.safar@seznam.cz>
2250 New partial class implementation.
2251 A fix for #77027, #77029, #77403
2253 * attribute.cs (Attributable): Made attributes protected.
2255 * class.cs (TypeContainer): Add PartialContainer and partial_parts as
2256 the replacements of ClassPart and PartialContainer.
2257 (TypeContainer.AddClassOrStruct): Call RecordDecl here.
2258 (TypeContainer.AddInterface): Ditto.
2259 (TypeContainer.AddPartial): The main method for partial classes. It checks
2260 for errors and merges ModFlags and attributes. At the end class is added to
2262 (TYpeContainer.DefineDefaultConstructor): Checks whether default ctor is
2264 (TypeContainer.GetClsCompliantAttributeValue): Cope with partial class too.
2265 (TypeContainer.GetNormalPartialBases): Resolves base classes and interfaces
2266 from the rest of partial classes.
2267 (TypeContainer.GetClassBases): Simplified.
2268 (TypeContainer.DefineTypeBuilder): New method, mostly extracted from
2270 (TypeContainer.DefineDefaultConstructor): Is used by derived classes.
2271 (TypeContainer.HasExplicitLayout): Uses Flags now.
2272 (PartialContainer): Removed.
2273 (ClassOrStruct.AddToContainer): Moved enclosing member name check here.
2274 (StaticClass): Was merged with Class.
2275 (Class.GetClassBases): class and static class bases are verified here.
2276 (Class.TypeAttr): Added static attributes when class is static.
2277 (Struct.RegisterFieldForInitialization): Moved from TypeContainer.
2278 (MemberBase): In some cases we need to call parent container for partial
2279 class. It should be eliminated but it's not easy now.
2281 * cs-parser.jay: Replaced all PartialContainer with AddPartial.
2283 * decls.cs (MemberCore.DocComment): Introduced new property as is used by
2284 partial classed to accumulate class comments.
2285 (MemberCore.GetClsCompliantAttributeValue): Moved from TypeContainer.
2287 * doc.cs (GenerateTypeDocComment): Partial classes clean up.
2289 * driver.cs (MainDriver): Tree.GetDecl was removed.
2291 * modifiers.cs (Modifiers): Add partial modifier.
2293 * tree.cs (Tree.decl): Removed.
2294 (RootTypes): Started to use this class more often for root types
2297 2006-03-23 Raja R Harinath <rharinath@novell.com>
2299 * generic.cs (TypeParameter.UpdateConstraints): Update
2300 'constraints' if null.
2302 2006-02-22 Marek Safar <marek.safar@seznam.cz>
2306 * attribute.cs (AttributeTester.GetCoClassAttribute): Don't crash when
2307 external interface does not have an attribute.
2309 2006-02-22 Marek Safar <marek.safar@seznam.cz>
2311 Another prerequisites for new partial classs implementation.
2313 * attribute.cs (Attribute.Equal): Implemented.
2314 (Attribute.Emit): Changed as attributes can be applied more than twice.
2315 (Attributes.Emit): Check for duplicate attributes here.
2317 * class.cs, decl.cs, delegate.cs, doc.cs, enum.cs: Don't pass DeclSpace
2318 as a parameter, clean-up.
2320 2006-02-11 Marek Safar <marek.safar@seznam.cz>
2324 * class.cs (TypeContainer.DefineType): Cannot use ResolveType because it
2325 contains obsolete attribute check which can in some cases look for base
2326 type of current class which is not initialized yet.
2327 (TypeContainer.BaseType): Replacement of ptype.
2329 * decl.cs (MemberCore.CheckObsoleteType): Reuse existing code.
2331 2006-02-11 Marek Safar <marek.safar@seznam.cz>
2333 First of prerequisites for new partial classs implemention.
2335 * attribute.cs (Attributable): Extended by ResolveContext;
2336 Attributes finally have correct context for resolving in all cases.
2337 (AttachTo): Attribute owner is assigned here.
2339 * codegen.cs (IResolveContext): Introduce new interface to hold
2340 all information needed in resolving phase.
2341 (EmitContext): Implements IResolveContext; more clean-up needed here.
2343 * decl.cs (MemberCore): Implemented IResolveContext.
2345 * anonymous.cs, attribute.cs, class.cs, codegen.cs, const.cs,
2346 decl.cs, ecore.cs, enum.cs, expression.cs, iterators.cs, namespace.cs,
2347 parameter.cs, statement.cs, tree.cs, typemanager.cs:
2348 Refactored to use new IResolveContext instead of EmitContext; cleanup
2350 2006-03-22 Raja R Harinath <rharinath@novell.com>
2352 Support ParameterDefaultValueAttribute in gmcs. Also applied to
2353 mcs to keep code differences small.
2354 * attribute.cs (Attribute.GetParameterDefaultValue): New.
2355 * typemanager.cs (parameter_default_value_attribute_type): New.
2356 * parameter.cs (Parameter.ApplyAttributeBuilder): Use them. Add
2359 2006-03-22 Martin Baulig <martin@ximian.com>
2362 (Nullable.NullableLiteral): Derive from `NullLiteral'.
2365 (Convert.TypeParameter_to_Null): Create a `Nullable.NullableLiteral'
2366 instead of the normal `NullLiteral'.
2368 2006-03-21 Martin Baulig <martin@ximian.com>
2371 * generic.cs (TypeManager.InferType): If `pt' is a generic
2372 parameter, don't check whether `pt == at'.
2374 2006-03-20 Raja R Harinath <rharinath@novell.com>
2377 * generic.cs (Constraints.Resolve): Change argument to IResolveContext.
2378 (TypeParameter.Resolve): Update to change.
2379 (ConstraintChecker.CheckConstraints): Resolve type-argument
2380 constraints before use.
2382 2006-03-16 Martin Baulig <martin@ximian.com>
2385 (ConstraintChecker.HasDefaultConstructor): If we're a TypeBuilder
2386 and don't have any instance constructors, also lookup in the base class.
2387 (TypeManager.IsNullableValueType): New public method.
2389 * typemanager.cs (TypeManager.MemberLookup_FindMembers): Clear the
2390 `BindingFlags.DeclaredOnly' flag and set `used_cache'.
2391 (TypeManager.TryGetBaseDefinition): Use DropGenericMethodArguments().
2393 * expression.cs (Unary.DoResolve): Use TypeManager.IsNullableValueType()
2394 instead of just TypeManager.IsNullableType() to determine whether
2395 a lifted operator exists.
2396 (UnaryMutator.DoResolve): Likewise.
2397 (Conditional.DoResolve): Likewise.
2398 (Binary.DoResolve): A lifted operator only exists if both operands
2399 are valuetypes and at least one of them is a nullable type.
2401 2006-03-14 Atsushi Enomoto <atsushi@ximian.com>
2403 * iterator.cs : yield break is allowed in try statement which has
2404 catch clauses. Fixed bug #77767.
2406 2006-03-12 Martin Baulig <martin@ximian.com>
2408 * typemanager.cs (TypeManager.ArrayContainsMethod): Use a new
2409 private IsSignatureEqual() to compare types; see the comment in
2410 that method; fixes #77674.
2412 2006-03-10 Raja R Harinath <rharinath@novell.com>
2414 * ecore.cs (Expression.ResolveAsTypeStep): Remove 1-argument wrapper.
2415 (Expression.ResolveAsTypeTerminal): Likewise.
2416 * class.cs, decl.cs, delegate.cs, ecore.cs: Update to changes.
2417 * expression.cs, generic.cs, iterators.cs: Likewise.
2418 * parameter.cs, statement.cs, typemanager.cs: Likewise.
2420 2006-03-09 Martin Baulig <martin@ximian.com>
2422 * generic.cs (ConstraintChecker.HasDefaultConstructor): Call
2423 TypeManager.DropGenericTypeArguments() on the `atype'; fixes #77548.
2425 2006-03-09 Martin Baulig <martin@ximian.com>
2427 * ecore.cs (FieldExpr.AddressOf): Don't emit the instance if the
2428 `prepared' flag is set.
2430 * generic.cs (LiftedBinaryOperator): Don't allow `||' or `&&' anymore.
2431 (LiftedBinaryOperator, LiftedUnaryMutator): Fix a few nullable
2432 issues; see gtest-254.cs.
2434 2006-03-07 Martin Baulig <martin@ximian.com>
2436 * generic.cs (TypeManager.InferType): Allow infering
2437 `IEnumerable<T>' with an array of T; see gtest-251.cs.
2439 2006-03-06 Martin Baulig <martin@ximian.com>
2442 (TypeManager.InferType): Fix gtest-250.cs.
2445 (TypeManager.IsSubclassOf): Also check the base class.
2448 (Invocation.IsAncestralType): Use TypeManager.IsSubclassOf();
2451 2006-03-01 Raja R Harinath <rharinath@novell.com>
2454 * expression.cs (ParameterReference.DoResolveBase): Change return
2456 (ParameterReference.DoResolve, ParameterReference.DoResolveLValue):
2460 * ecore.cs (PropertyExpr.InstanceResolve): Fix CS1540 check.
2463 * typemanager.cs (GetFullNameSignature): Don't nullref on
2464 protected accessors.
2466 2006-02-16 Martin Baulig <martin@ximian.com>
2469 (TypeManager.GetGenericFieldDefinition): New public method; use it
2470 instead of the `FieldInfo.Mono_GetGenericFieldDefinition()' icall.
2472 2006-02-14 Martin Baulig <martin@ximian.com>
2474 * *.cs: Use `Type.IsGenericType' instead of `Type.IsGenericInstance'.
2476 2006-02-14 Martin Baulig <martin@ximian.com>
2479 (TypeManager.DropGenericMethodArguments): New public method; don't
2480 use GetGenericMethodDefinition() on something which is not a
2483 2006-02-14 Martin Baulig <martin@ximian.com>
2486 (ConstraintChecker.CheckConstraints): If a type parameter has the
2487 `struct' constraint, the type must be a non-nullable valuetype.
2489 2006-02-10 Martin Baulig <martin@ximian.com>
2492 (TypeManager.IsOverride): Make this work for instantiated methods
2493 in a generic class; fixes #77509.
2494 (TypeManager.ExpandInterfaces): Use TypeManager.GetInterfaces()
2495 rather than calling it directly; fixes #77488.
2497 2006-02-08 Martin Baulig <martin@ximian.com>
2499 * generic.cs (ConstraintChecker.CheckConstraints): Move the error
2500 reporting into CheckConstraint() so we can use the correctly
2503 2006-02-08 Martin Baulig <martin@ximian.com>
2505 * expression.cs (BaseAccess): Add support for generic methods.
2507 * ecore.cs (MethodGroupExpr.ResolveGeneric): Propagate `IsBase' to
2508 the new MethodGroupExpr.
2510 2006-02-07 Martin Baulig <martin@ximian.com>
2512 * generic.cs (ConstraintChecker.CheckConstraints): Interfaces are
2513 also reference types; fixes #77483.
2515 2006-02-07 Martin Baulig <martin@ximian.com>
2518 (TypeManager.IsGenericMethod): We now return whether something is
2519 an instantiated generic method (and not a generic method def).
2520 (TypeManager.IsGenericMethodDefinition): New public method.
2523 (TypeManager.CSharpSignature): Only include type arguments for
2524 "real" generic methods, not for any instantiated method.
2525 (TypeManager.GetMethodName): Likewise, but also allow generic
2526 method definitions here.
2528 2006-02-06 Miguel de Icaza <miguel@novell.com>
2530 * codegen.cs (EmitScopeInitFromBlock): check here the
2531 capture_context, there is no need to make two calls to the
2534 * anonymous.cs: Add some debugging messages that might help me
2535 track other instances of this problem in the future (the
2536 regression of test 467).
2538 * cs-parser.jay: track the variable block, as we need to initalize
2539 any captured variables declared in this block for the "catch"
2540 portion of the "Try" statement.
2542 * statement.cs (Try.Emit): If the "Catch" has a VarBlock, emit any
2543 scope initialization for captured variables.
2545 Also, move the emit for the variables after the block location has
2548 2006-02-06 Marek Safar <marek.safar@seznam.cz>
2550 * ecore.cs (PropertyExpr.FindAccessors): Just made flags const.
2552 2006-02-06 Martin Baulig <martin@ximian.com>
2554 * class.cs (TypeContainer.DefineType): If we're a struct, pass
2555 `TypeManager.value_type' as parent type to
2556 ModuleBuilder.DefineType(). Fixes #77358.
2558 2006-02-02 Miguel de Icaza <miguel@novell.com>
2560 * anonymous.cs (CaptureContext.EmitInitScope): I was wrong in the
2561 commit yesterday, the initialization for the roots is necessary.
2562 What is not necessary is the scope activation.
2564 2006-02-02 Raja R Harinath <rharinath@novell.com>
2566 * ecore.cs (PropertyExpr.DoResolveLValue): Add CS0206 check.
2567 * expression.cs (IndexerAccess.DoResolveLValue): Add CS1612 and
2569 (Argument.Resolve): Remove CS0206 checks.
2571 2006-02-01 Miguel de Icaza <miguel@novell.com>
2573 * anonymous.cs (CaptureContext.EmitInitScope): Do not emit the
2574 scopes for all the roots, the scopes will now be emitted when the
2575 Blocks are entered. [This change was wrong, fixed on 2006-02-02]
2577 (CaptureContext.EmitScopeInitFromBlock): Simply emit the ScopeInfo
2578 code. This reduces a lot of existing cruft.
2580 * statement.cs (Block.Emit): Call EmitScopeInitFromBlock here, so
2581 that the ScopeInfo is generated as we enter the scope, not at the
2582 time of use, which is what we used to do before.
2584 * codegen.cs (EmitScopeInitFromBlock): New routine, this is called
2585 every time a Block is about to be emitted if we have a
2588 2006-02-01 Raja R Harinath <rharinath@novell.com>
2590 * codegen.cs (AssemblyClass.Emit): Emit RuntimeCompatibility
2591 attribute for mscorlib too.
2593 * typemanager.cs (NoTypes, NoTypeExprs): Remove.
2595 * *.cs: Use Type.EmptyTypes instead of TypeManager.NoTypes.
2597 * typemanager.cs (cons_param_array_attribute): Make private.
2598 (Reset): Set it to null.
2599 (InitCoreHelpers): Don't initialize it.
2600 (ConsParamArrayAttribute): New. Initialize it as needed.
2601 * parameter.cs (ParamsParameter.ApplyAttribute): Update to change.
2603 2006-01-31 Miguel de Icaza <miguel@novell.com>
2605 * expression.cs: There might be errors reported during the
2606 selection of applicable methods. If there are errors, do not
2607 continue execution as it will lead the compiler to crash.
2609 2006-01-30 Miguel de Icaza <miguel@novell.com>
2611 * expression.cs: Member access is not allowed on anonymous
2612 methods. Fixes #77402.
2614 2006-01-30 Raja R Harinath <rharinath@novell.com>
2617 * cs-parser.jay (VariableDeclaration): Don't set
2618 current_array_type to null.
2619 (field_declaration, event_declaration, declaration_statement):
2620 Set it to null here.
2622 2006-01-29 Raja R Harinath <harinath@gmail.com>
2625 * generic.cs (TypeManager.IsEqual): Handle pass-by-ref types.
2627 2006-01-28 Raja R Harinath <harinath@gmail.com>
2629 * typemanager.cs (GenericParameterPosition): New.
2632 2006-01-28 Atsushi Enomoto <atsushi@ximian.com>
2634 * doc.cs : To process "include" elements, first we should create
2635 another list than XmlNodeList, because it could result in node
2636 removal, which could result in that the XmlNodeList gives up
2639 2006-01-25 Miguel de Icaza <miguel@novell.com>
2641 * expression.cs: Introduce an error report that we were not
2642 catching before. Gonzalo ran into it.
2644 2006-01-23 Miguel de Icaza <miguel@novell.com>
2646 A fix for bug: #76957
2648 * iterators.cs (MoveNextMethod.CreateMethodHost): call
2649 ComputeMethodHost before creating the method, this is a new
2652 * anonymous.cs (AnonymousContainer): Now we track all the scopes
2653 that this method references (RegisterScope). The actual scope
2654 where the method is hosted is computed with the ComputeMethodHost
2655 before we create the method.
2657 Moved the Deepest routine here.
2659 (AnonymousContainer.ComputeMethodHost): New routine used to
2660 compute the proper ScopeInfo that will host the anonymous method.
2662 (ScopeInfo): Deal with multiple roots. The problem was that we
2663 did not have a unique root where all ScopeInfos could be hanged
2664 from. Remove `topmost' ScopeInfo, and instead keep an arraylist
2667 Remove AdjustMethodScope which is now computed at the end. Remove
2668 LinkScope which did a partial link, instead link all ScopeInfos
2669 before code generation from the new "LinkScopes" routine.
2671 Simplify all the Add* routines as they no longer need to maintain
2672 the tree, they just need to record that they are using variables
2675 (IsAncestor, GetAncestorScopes, GetParentScope, LinkScope): New
2676 routines to produce the forest of ScopeInfo trees.
2678 * class.cs (TypeContainer.AppendMethod): This is just like
2679 AddMethod, but ensures that an interface implementation method
2680 (IEnumerable.XXX) is not inserted at the beginning of the queue of
2681 methods, but at the end.
2683 We use this functionality to ensure that the generated MoveNext
2684 method in the iterator class is resolved/emitted before the
2685 enumerator methods created.
2687 This is required because the MoveNext method computes the right
2688 ScopeInfo for the method. And the other methods will eventually
2689 need to resolve and fetch information computed from the anonymous
2693 2006-01-23 Raja R Harinath <rharinath@novell.com>
2695 Improve implementation of section 14.4.2.2 (Better function member).
2696 * expression.cs (Invocation.MoreSpecific): Compare all type
2697 arguments before deciding if one type is more specific than
2698 another. Handle array types too. Return the more specific type.
2699 (Invocation.BetterFunction): Add more tie-breaking rules from
2700 section 14.4.2.2. Perform "more specific" check after
2701 other tie-breaking rules. Compare all parameter types before
2702 choosing the "more specific" method.
2704 2006-01-21 Raja R Harinath <harinath@gmail.com>
2705 Carlos Alberto Cortez <calberto.cortez@gmail.com>
2708 * namespace.cs (NamespaceEntry.UsingExternalAliases): Don't add to
2710 (NamespaceEntry.LookupAlias): Lookup 'extern_aliases' hash too.
2711 (NamespaceEntry.VerifyUsing): Resolve external aliases too.
2713 2006-01-18 Martin Baulig <martin@ximian.com>
2715 * class.cs (TypeContainer.AddToMemberContainer): Use
2716 `symbol.MemberName.MethodName' instead of just `symbol.Name';
2719 2006-01-18 Martin Baulig <martin@ximian.com>
2721 Fix #76417: a generic class may now have methods which may unify
2722 for some type parameter substitutions.
2724 * class.cs (Method.IsDuplicateImplementation): Don't report CS0408
2725 for methods which may unify anymore.
2727 * expression.cs (Invocation.MoreSpecific): New private static
2728 method; checks whether one method is more specific than another
2729 according to 14.4.2.2 of the spec.
2730 (Invocation.BetterFunction): Implement the tie-breaking rules from
2731 14.4.2.2 of the spec: if two methods unify for some type parameter
2732 substitution, we need to pick the more specific one.
2734 2006-01-18 Raja R Harinath <rharinath@novell.com>
2736 Fix #76656, cs0231-2.cs.
2737 * cs-parser.jay (formal_parameter_list): Make error case catch
2739 (parenthesized_expression_0): Add CS1026 check.
2740 (invocation_expression): Remove unused { $$ = lexer.Location }.
2742 2006-01-17 Raja R Harinath <rharinath@novell.com>
2745 * cs-parser.jay (statement_expression): Don't list out the
2746 individual statement-expressions. Convert syntax error into
2749 2006-01-16 Raja R Harinath <rharinath@novell.com>
2752 * ecore.cs (MemberAccess.CheckIntermediateModification): Remove.
2753 (UnboxCast.DoResolveLValue): New. Move CS0445 check from
2754 CheckIntermediateModification.
2755 (FieldExpr.DoResolve): Add new two-argument version that
2756 allows us to resolve the InstanceExpression as an lvalue.
2757 The one-argument variant is now just a wrapper.
2758 (FieldExpr.DoResolveLValue): Use two-argument DoResolve.
2759 Resolve the lhs as an lvalue if the it has a value type.
2760 (FieldExpr.AssignToReadonly): Move CS1648 and CS1650 checks
2761 from Assign.DoResolve.
2762 (PropertyExpr.InstanceResolve): Allow InstanceExpression to be
2763 resolved as an lvalue.
2764 (PropertyExpr.DoResolve): Update.
2765 (PropertyExpr.DoResolveLValue): Resolve the lhs as an lvalue if it
2766 has a value type. Move CS1612 check here from
2767 CheckIntermediateModification.
2768 * assign.cs (Assign.DoResolve): Remove CS1648 and CS1650 checks.
2769 * expression.cs (EmptyExpression.OutAccess): New. Used as the
2770 'right_side' of a ResolveLValue on an 'out' argument.
2771 (EmptyExpression.LValueMemberAccess): New. Used as the
2772 'right_side' of a propagated ResolveLValue on a value type.
2773 (LocalVariableReference.DoResolveBase): Recognize
2774 EmptyExpression.OutAccess and EmptyExpression.LValueMemberAccess.
2776 (Argument.Resolve): Use EmptyExpression.OutAccess rather than
2777 EmptyExpression.Null.
2779 2006-01-16 Atsushi Enomoto <atsushi@ximian.com>
2781 * typemanager.cs : added IsGenericParameter(). In gmcs it returns
2782 Type.IsGenericParameter(). Fixed bug #77183.
2783 * doc.cs : it is now identical to doc.cs in mcs.
2785 2006-01-16 Martin Baulig <martin@ximian.com>
2787 * generic.cs (ConstraintChecker.CheckConstraint): Fix #77167.
2789 2006-01-16 Martin Baulig <martin@ximian.com>
2791 * typemanager.cs (TypeManager.CSharpSignature): Make this work for
2792 ctors; fixes #77250.
2794 2006-01-12 Miguel de Icaza <miguel@novell.com>
2796 This fixes the problem where we used ldfld instead of ldflda to
2797 load the "THIS" pointer on captured parameters, when THIS is a
2798 value type. See bug #77205.
2800 * iterators.cs (CapturedThisReference.Emit): Pass false to
2801 EmitThis (we do not need the address).
2803 * codegen.cs (EmitThis): it needs to know whether we need the
2804 address of `this' or not. This is used by value types.
2806 * expression.cs (This.AddressOf): Pass true to the EmitThis call,
2807 every other call passes false.
2809 2006-01-12 Raja R Harinath <rharinath@novell.com>
2812 * typemanager.cs (TryGetBaseDefinition): Rename from the mis-named
2814 * expression.cs (Invocation.OverloadResolve): Update.
2815 (Invocation.DoResolve): Avoid double resolution of invocation.
2817 2006-01-11 Raja R Harinath <rharinath@novell.com>
2820 * expression.cs (Unary.Emit): When in /checked+ mode, don't emit
2821 unary negation of floating point types as 0-expr; negation cannot
2822 overflow in floating point types.
2825 * expression.cs (MemberAccess.DoResolve): Disallow the use of '.'
2826 on operands of 'void' type.
2829 * cfold.cs (BinaryFold): Implement folding of BinaryOr, BinaryAnd
2830 and ExclusiveOr for boolean constants too.
2832 2006-01-12 Ben Maurer <bmaurer@andrew.cmu.edu>
2834 * expression.cs: Fix Console.WriteLine ((this = x).foo);
2836 2006-01-12 Miguel de Icaza <miguel@novell.com>
2838 * cs-tokenizer.cs (Position): New class used to save and restore
2839 the position state in the tokenizer. Before this patch the save
2840 and restore was not complete enough so the line and columns would
2841 start to drift and the debugger and stack traces will get the
2844 2006-01-10 Martin Baulig <martin@ximian.com>
2847 (TypeParameter.InflateConstraints): New public method.
2849 * iterators.cs (Iterator.DefineNestedTypes): Also inflate the
2850 constraints; fixes #77042.
2852 2006-01-10 Martin Baulig <martin@ximian.com>
2854 * anonymous.cs (ScopeInfo.EmitScopeType): Use the `CurrentType'
2855 instead of the `TypeBuilder' for this "<>THIS" variable; fixes
2858 2006-01-09 Raja R Harinath <rharinath@novell.com>
2861 * expression.cs (Invocation.OverloadResolve): Replace reflected
2862 override methods with their base virtual methods, rather than
2864 * typemanager.cs (TypeManager.GetOverride): New.
2866 2005-12-21 Miguel de Icaza <miguel@novell.com>
2868 * driver.cs: Report the case of no source files and no -out:
2871 2005-12-20 Raja R Harinath <rharinath@novell.com>
2874 * expression.cs (ComposedCast.GetSignatureForError): Define.
2876 2006-01-05 Jb Evain <jbevain@gmail.com>
2878 * class.cs (Property.Define, Indexer.Define): do not tag the
2879 properties as SpecialName | RTSpecialName.
2881 2006-01-04 Miguel de Icaza <miguel@novell.com>
2883 * class.cs (MethodCore.IsDuplicateImplementation): This method was
2884 doing a low-level comparission of parameter types. It was lacking
2885 a check for __argslist.
2887 2005-12-30 Miguel de Icaza <miguel@novell.com>
2889 * expression.cs (ParameterReference.DoResolveBase): Allow
2890 reference parameters if they are local to this block.
2892 This allows the ref and out parameters of a delegate to be used in
2893 an anonymous method, for example:
2895 delegate void set (out int x);
2897 set s = delegate (out int x){
2901 This is used by functionality introduced late in the C# language.
2903 * anonymous.cs (AnonymousMethod.Compatible): Allow anonymous
2904 method that take ref and out parameters.
2906 Fixes #77119 which was a late change in the spec.
2908 2005-12-23 Miguel de Icaza <miguel@novell.com>
2910 * anonymous.cs (ScopeInfo.LinkScope): Do not link the scope to its
2911 parent if its the same scope. Fixes #77060.
2913 2005-12-22 Marek Safar <marek.safar@seznam.cz>
2915 * expression.cs (ComposedCast.DoResolveAsTypeStep): Fixed wrong merge.
2917 2005-12-21 Carlos Alberto Cortez <calberto.cortez@gmail.com>
2919 * codegen.cs (AssemblyClass.CheckInternalsVisibleAttribute): Generate
2920 errors 1726 for strong named assemblies with InternalsVisibleToAttribute
2921 that doesn't contain the full public key. This is a update of the
2922 friend assemblies in .Net 2.0 release.
2924 2005-12-18 Carlos Alberto Cortez <calberto.cortez@gmail.com>
2928 * namespace.cs (NamespaceEntry): Add extern_aliases as a
2929 ListDictionary, to contain the ExternAliasEntry entries (in
2930 addition to the NamespaceEntry.aliases hashtable). This field is
2931 shared between the original entry and its doppelganger (bodyless
2933 (NamespaceEntry.UsingExternalAlias): Add the extern alias entry to
2934 extern_aliases field.
2935 (NamespaceEntry.Lookup): Move the IsImplicit check after the
2936 lookup in extern_aliases.
2938 2005-12-16 Raja R Harinath <rharinath@novell.com>
2941 * class.cs (TypeContainer.Mark_HasEquals): New.
2942 (TypeContainer.Mark_HasGetHashCode): New.
2943 (ClassPart): Override them.
2944 (MethodCore.CheckBase): Use them instead of referring to Parent.Methods.
2946 * generic.cs (GenericMethod.DefineMembers): Update to changes.
2947 (TypeParameter.TypeParameter): Change type of 'parent' argument to
2951 * enum.cs (EnumMember.EnumMember): Pass the parent_enum as the
2952 'parent' argument to the base constructor.
2954 Remove all mention of TypeContainer from decl.cs.
2955 * decl.cs (MemberCore.Parent): Change into a DeclSpace.
2956 (MemberCore.MemberCore): Change type of 'parent' argument to DeclSpace.
2957 (DeclSpace.DeclSpace): Likewise.
2958 (DeclSpace.DefineMembers): Remove unused argument.
2959 * cs-parser.jay (pop_current_class): Update to changes. Simplify
2960 debugging check -- we don't care if the debug code throws an
2961 InvalidCastException instead of an InternalErrorException.
2962 * class.cs (TypeContainer.DefineMembers): Update to changes.
2963 (TypeContainer.DoDefineMembers): Likewise.
2964 (TypeContainer.GetMethods): Likewise.
2965 (PropertyMember.Define): Likewise.
2966 (MemberBase.Parent): New property that forwards to
2967 MemberCore.Parent, but ensures that we get a TypeContainer.
2968 * rootcontext.cs (RootContext.PopulateCoreType): Update to changes.
2969 (RootContext.PopulateTypes): Likewise. Remove special case code
2970 for !RootContext.StdLib: DefineMembers is idempotent.
2972 2005-12-13 Marek Safar <marek.safar@seznam.cz>
2974 * class.cs (Method.ApplyAttributeBuilder): Test out modifier properly.
2976 2005-12-11 Atsushi Enomoto <atsushi@ximian.com>
2978 * doc.cs : The search for referenced namespace was insufficient to
2979 get global one as it used to do. Fixed bug #76965.
2981 2005-12-10 Atsushi Enomoto <atsushi@ximian.com>
2983 * doc.cs : check name in cref in the last phase that whether it is
2986 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
2988 * cs-tokenizer.cs : reverted the latest change: it somehow broke
2991 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
2993 * doc.cs : so it turned out that we cannot skip override check for
2994 interface members. Fixed bug #76954.
2996 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
2998 * cs-tokenizer.cs : fixed bug #75984:
2999 - #warning and #error should not be handled when the source line
3001 - #line is not checked strictly when the source line is disabled.
3002 - #define and #undef is on the other hand checked strictly at any
3005 2005-12-08 Atsushi Enomoto <atsushi@ximian.com>
3007 * cs-tokenizer.cs : missing Location (actually, filename) in one of
3010 2005-12-15 Raja R Harinath <rharinath@novell.com>
3012 * generic.cs (TypeManager.IsGeneric): Remove unused method.
3014 * typemanager.cs (TypeManager.GetFullName): Rewrite to handle
3017 2005-12-14 Martin Baulig <martin@ximian.com>
3019 * typemanager.cs (TypeManager.GetFullName): Make this public;
3020 `Type.Fullname' now never returns null.
3022 * class.cs (Method.Define): Use TypeManager.GetFullName() for
3023 explicit interface implementations; we're now using the same
3024 naming convention than csc does.
3026 2005-12-14 Miguel de Icaza <miguel@novell.com>
3028 * convert.cs (ExplicitConversionCore): Check the return value from
3029 ExplicitConversionCore which can return null on failure. Fixes #76914
3031 2005-12-09 Raja R Harinath <rharinath@novell.com>
3033 * anonymous.cs (AnonymousMethod.Compatible): Use IsGenericType
3034 instead of IsGenericInstance.
3035 * generic.cs (TypeManager.IsEqual): Likewise. Delete redundant
3036 code that's now covered by the more general test.
3037 * typemanager.cs (TypeManager.IsPrivateAccessible): Likewise.
3039 * generic.cs (DropGenericTypeArguments): New. Captures the common
3040 pattern: if (t.IsGenericInstance) t = t.GetGenericTypeDefinition ();
3041 * attribute.cs, class.cs, decl.cs, ecore.cs: Use it.
3042 * generic.cs, report.cs, typemanager.cs: Likewise.
3044 2005-12-08 Martin Baulig <martin@ximian.com>
3046 * generic.cs (TypeArguments.Resolve): Added CS1547 check.
3048 * typemanager.cs (TypeManager.CSharpSignature): Include type
3049 arguments in the signature of a generic method.
3051 2005-12-07 Martin Baulig <martin@ximian.com>
3053 Add support for custom attributes on type parameters.
3055 * cs-parser.jay (type_arguments): Added `opt_attributes'.
3057 * generic.cs (TypeParameterName): New public class; we use this
3058 instead of a `string' to store the name of a type parameter, so we
3059 can also have `Attributes'.
3060 (TypeArguments.GetDeclarations): Return a `TypeParameterName[]'
3061 array instead of a `string[]' array.
3062 (TypeParameter.ctor): We now also take an `Attributes' argument.
3063 (TypeParameter.EmitAttributes): New public method; emit our
3064 `OptAttributes' here.
3065 (GenericMethod.EmitAttributes): New public method; emit the custom
3066 attributes on all our type parameters.
3068 * class.cs (TypeContainer.EmitType): Call EmitAttributes() on all
3069 our type parameters.
3070 (MethodData.Define): If we're a generic method, call
3071 EmitAttributes() on it.
3073 2005-12-07 Martin Baulig <martin@ximian.com>
3076 (ConstraintChecker): New public abstract class; move the
3077 constraint checking here from `ConstructedType' and also do
3078 constraint checking for generic methods here.
3080 * expression.cs (Invocation.OverloadResolve): Use
3081 ConstraintChecker.CheckConstraints() if we resolved to a generic
3084 2005-12-05 Marek Safar <marek.safar@seznam.cz>
3086 * attribute.cs (GlobalAttribute.ctor): Pass NamespaceEntry only.
3088 * class.cs (EmitFieldInitializers): Simplified and fixed to work with
3090 (FieldBase.EmitInitializer): Moved from TypeContainer and simplified.
3091 (FieldBase.Initializer): Initializer is now optional.
3092 (EventField.Define): Only event field can have initializer.
3094 * codegen.cs (EmitContext): DeclSpace is not readonly (small hack).
3096 * const.cs (Const): Reuse initializer.
3098 * cs-parser.jay: Updated after FieldBase changes.
3099 Added current_array_type to simplify array initializers.
3101 * ecore.cs (NullCast.IsDefaultValue): Implemented.
3103 * expression.cs, iterators.cs: Updated.
3105 * namespace.cs (NamespaceEntry): Made UsingFound private.
3107 2005-12-05 Marek Safar <marek.safar@seznam.cz>
3109 * parameterCollection.cs: Obsolete, removed.
3110 * parser.cs: Obsolete, removed.
3112 2005-12-05 Marek Safar <marek.safar@seznam.cz>
3115 * class.cs (Constructor.Emit): Set obsolete checking for whole context.
3117 * enum.cs (Enum.Define): Set obsolete context here.
3119 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
3122 - FindDocumentedMember() now expects 1) paramList as null
3123 when "we don't have to check the number of parameters" and
3124 2) Type.EmptyTypes when "there is no arguments".
3125 - Introduced FoundMember struct to hold the exact type which was
3126 used to find the documented member (the above change broke
3127 test-xml-044; it might be better just to use DeclaringType than
3128 what MS does, like this change does, but it depends on usage.)
3130 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
3132 * doc.cs : documented member might be from DeclaringType for nested
3133 types. Fixed bug #76782.
3135 2005-12-03 Ben Maurer <bmaurer@ximian.com>
3137 * anonymous.cs: Have the param code handle leaving copies on the
3138 stack etc. Allows anonymous params to take part in the assignment
3139 code (++, +=, etc). Fixes bug #76550
3141 * expression.cs: Handle the prepare_for_load/leave_copy by passing
3142 it down to the anon code.
3144 * iterators.cs: Use dummy var here
3146 * codegen.cs: Handle new vars
3148 2005-12-01 Marek Safar <marek.safar@seznam.cz>
3151 * class.cs (MethodData.Define): Set proper Obsolete context.
3153 * ecore.cs (FieldExpr.ResolveMemberAccess): Don't check [Obsolete] in
3155 (FieldExpr.DoResolve): Ditto.
3157 2005-12-01 Marek Safar <marek.safar@seznam.cz>
3160 * class.cs (MethodCore.DoDefineParameters): Test [Obsolete] only when
3161 parent is not obsolete.
3163 2005-12-01 Atsushi Enomoto <atsushi@ximian.com>
3165 * doc.cs : (FindDocumentedMember) find parameterless members first
3166 and get CS0419 in the early stage. Fixed first case of bug #76727.
3168 2005-11-30 Marek Safar <marek.safar@seznam.cz>
3171 * ecore.cs (Expression.ResolveAsConstant): Report constant error only when
3172 no error was reported.
3174 *expression.cs (Binary.DoResolve): left can be null.
3176 2005-12-06 Raja R Harinath <rharinath@novell.com>
3178 * class.cs (MethodCore.CheckGenericOverride): Delete unused
3179 abstract method and all overrides.
3180 * support.cs (ParameterData.GenericConstraints): Delete.
3181 (ReflectionParameters.type_params): Delete.
3182 (ReflectionParameters.ReflectionParameters): Make private.
3183 (ReflectionParameters.GetConstaints): New factory method.
3184 * generic.cs (TypeParameterDefineType): Use it.
3185 (TypeManager.GetTypeParameterConstraints): Likewise.
3187 2005-11-22 Marek Safar <marek.safar@seznam.cz>
3190 * class.cs (MethodData.Emit): Parameters should be labeled first.
3192 2005-11-21 Marek Safar <marek.safar@seznam.cz>
3195 * parameter.cs (Parameter.ApplyAttributeBuilder): Fixed `ref' detection.
3197 2005-11-18 Marek Safar <marek.safar@seznam.cz>
3199 * attribute.cs (AreParametersCompliant): Moved to Parameter.
3201 * class.cs (MethodCore): Parameter clean up.
3202 (IMethodData): Added ParameterInfo.
3203 (MethodData): Parameter clean up.
3204 (Indexer.Define): Parameter clean up.
3216 * typemanager.cs: Parameter clean up.
3218 * delegate.cs (Define): Get rid of duplicated code.
3220 * expression.cs (ParameterReference): Removed useless parameters
3222 (Invocation): Ditto.
3224 * parameter.cs (ParamsParameter): New class, params specialization.
3225 (ArglistParameter): Attemp to separate arglist.
3226 (Parameter): Refactored to be reusable and faster.
3227 (Parameter.Modifier): Made understandable.
3228 (Parameters): Changed to be used as a class for `this' assembly
3229 parameters. Refactored to use new specialized classes.
3231 * support.cs (ParameterData): Added Types property.
3232 (InternalParameters): Deleted.
3234 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
3236 * doc.cs : the previous patch does not actually fix the bug.
3237 PropertyInfo override check is now implemented and really fixed it.
3238 * expression.cs : Invocation.IsAncestralType() is used from doc.cs.
3240 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
3242 * doc.cs : apply "override filter" also to properties.
3245 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
3247 * doc.cs : renamed FindMembers() to FindMethodBase(). For interfaces,
3248 no need to check overrides. For classes, omit those results from
3249 interfaces since they must exist in the class. Fixed bug #76726.
3251 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
3253 * typemanager.cs : (GetFullNameSignature) differentiate indexers
3254 with different parameters. Fixed the second problem in #76685.
3256 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
3258 * doc.cs : (FindDocumentedMember) pass invocation_type as well (to
3259 get expected 'protected' access in CheckValidFamilyAccess()).
3262 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
3264 * doc.cs : (GenerateTypeDocComment) Fields could be FixedField.
3265 Fixed bug #76705. CS1569 was incorrectly commented out.
3267 2005-11-23 Martin Baulig <martin@ximian.com>
3269 * generic.cs (Constraints.Define): Removed.
3270 (TypeParameter.DefineConstraints): Removed.
3271 (TypeParameter.DefineType): Call SetGenericParameterAttributes()
3272 on the GenericTypeParameterBuilder here.
3274 2005-11-23 Martin Baulig <martin@ximian.com>
3276 * typemanager.cs (TypeManager.GetProperty): Make this public.
3278 * generic.cs (Nullable.NullableInfo.ctor): Use
3279 TypeManager.GetProperty() rather than using reflection directly.
3281 2005-11-17 Martin Baulig <martin@ximian.com>
3283 * expression.cs (Indexers.GetIndexersForType): Added support for
3284 generic parameters; fixes #76587.
3286 2005-11-17 Martin Baulig <martin@ximian.com>
3289 (CaptureContext.EmitMethodHostInstance): Use `Ldarg_0' if we
3290 inherit the scope from our parent. Fixes #76653.
3292 2005-11-15 Martin Baulig <martin@ximian.com>
3294 * anonymous.cs (ScopeInfo.ScopeType): New public field; use this
3295 instead of `ScopeTypeBuilder' to refer to the "current" type.
3296 (AnonymousMethod.CreateScopeType): Correctly create the helper
3297 class if we're inside a generic type definition.
3299 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
3301 * doc.cs : use Invocation.IsOverride() to do real override check.
3302 * expression.cs : made Invocation.IsOverride() internal.
3304 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
3306 * doc.cs : use TypeManager.FindMembers() instead of (possible)
3307 TypeBuilder.FindMembers() and filter overriden base members out.
3310 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
3312 * doc.cs : ref/out parameters are represented as '@' (instead of
3313 '&' in type FullName). Fixed bug #76630 (additionally crefs).
3315 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
3317 * doc.cs : when there was no '.' in cref to methods in doc comment,
3318 then parameters were missing in the output. Fixed bug #76691.
3320 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
3322 * driver.cs : don't output docs when there is an error.
3325 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
3328 Now it should detect indexers. Fixed primary concern in bug #76685.
3329 Fixed CS0419 message to not show the identical member signature in
3332 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
3334 * doc.cs : (FindDocumentedMember) use TypeManager.MemberLookup()
3335 instead of Type.FindMembers() since it does not handle events.
3338 2005-11-12 Gert Driesen <drieseng@users.sourceforge.net>
3340 * codegen.cs: Fixed typo (speficied -> specified).
3342 2005-11-11 Marek Safar <marek.safar@seznam.cz>
3345 * doc.cs (FindDocumentedTypeNonArray): Don't resolve again.
3347 2005-11-11 Marek Safar <marek.safar@seznam.cz>
3349 * attribute.cs: Changed error message.
3351 * cs-tokenizer.cs: One more check.
3353 2005-11-10 Marek Safar <marek.safar@seznam.cz>
3355 * statement.cs (Block.Resolve): Ignore empty statement.
3357 2005-11-10 Marek Safar <marek.safar@seznam.cz>
3359 * report.cs: Made error/warning methods more strict to avoid
3362 * anonymous.cs, attribute.cs, class.cs, codegen.cs, constant.cs,
3363 convert.cs, cs-parser.jay, cs-tokenizer.cs, decl.cs, delegate.cs,
3364 doc.cs, driver.cs, ecore.cs, expression.cs, location.cs,
3365 namespace.cs, parameter.cs, statement.cs, typemanager.cs: Updated.
3367 2005-11-11 Carlos Alberto Cortez <calberto.cortez@gmail.com>
3369 * codegen.cs (AssemblyClass.CheckInternalsVisibleAttribute):
3370 Use the more explicit AssemblyName.FullName instead of
3371 AssemblyName.Name to report errors.
3373 2005-11-11 Marek Safar <marek.safar@seznam.cz>
3375 * attribute.cs, class.cs, cs-tokenizer.cs, parameter.cs: Sync
3378 2005-11-10 Marek Safar <marek.safar@seznam.cz>
3388 * report.cs: Fixed error reporting and typos.
3390 * generic.cs (TypeParameter.GetSignatureForError): New method.
3391 (ConstructedType.GetSignatureForError): Instead of DeclarationName.
3393 * typemanager.cs (GetFullName): Refactored.
3395 2005-11-08 Marek Safar <marek.safar@seznam.cz>
3397 * attribute.cs (Attribute.GetCoClassAttributeValue): New method.
3398 (AttributeTester.GetCoClassAttribute): Get CoClassAttribute.
3400 * class.cs (TypeContainer.IsComImport): New property.
3401 (Constructor.Define): Create proper ctor for ComImport types.
3403 * expression.cs (New.CheckComImport): Fixed.
3405 2005-11-07 Miguel de Icaza <miguel@novell.com>
3407 * anonymous.cs (CaptureContext.AddParameterToContext): The fact
3408 that a parameter has been captured does not mean that we do not
3409 have to do the rest of the processing. This fixes the second part
3410 of #76592. If there was another anonymous method capturing
3411 values in the past, the Scope would never be set for the second
3412 method that captured the same parameter.
3414 (CaptureContext.EmitAssignParameter): When `leave_copy' is passed,
3415 properly manipulate the stack. Second part of fix for #76592.
3417 * expression.cs (New): Add support for invoking "new" on
3418 interfaces that have been flagged with the ComImport attribute and
3419 the CoClass. Fixes #76637
3421 * statement.cs (Try.DoEmit): When a variable is captured, do not
3422 try to emit the vi.LocalBuilder variable as it has been captured.
3423 Create a temporary variable and store the results on the
3424 FieldBuilder. Fixes #76642
3426 2005-11-07 Marek Safar <marek.safar@seznam.cz>
3428 * class.cs (CheckPairedOperators): Made compilable with csc 2.0.
3430 * ecore.cs (InstanceResolve): Fixed CS1540 detection.
3432 * expression.cs (Binary.DoResolve): Added && optimalization.
3434 * typemanager.cs (AddUserType): Removed useless argument.
3436 2005-11-04 Marek Safar <marek.safar@seznam.cz>
3438 * statement.cs (Block.variables): Uses ListDictionary.
3440 2005-11-03 Marek Safar <marek.safar@seznam.cz>
3443 * class.cs (PartialContainer.EmitType): Customized to emit
3444 security attributes.
3445 (ClassPart.ApplyAttributeBuilder): Transform security attribute
3446 for partial classes.
3448 2005-11-03 Marek Safar <marek.safar@seznam.cz>
3451 * expression.cs (ElementAccess.DoResolveLValue): Fixed buffer
3452 access has to be fixed.
3454 * typemanager.cs (IsUnmanagedType): Wrong common field type.
3456 2005-11-01 Marek Safar <marek.safar@seznam.cz>
3459 * ecore.cs (NullCast.Reduce): Implemented.
3461 * expression.cs (ArrayCreation.CheckIndices): Correcly check
3464 * statement.cs (SwitchLabel.ResolveAndReduce): Catch null
3466 (Foreach.Resolve): Catch null properly.
3468 2005-10-29 Marek Safar <marek.safar@seznam.cz>
3470 * cs-tokenizer.cs: Warning text fix.
3472 * driver.cs: AllWarningNumbers exposed on public interface.
3474 * report.cs (): Reviewed warning numbers.
3475 (IsValidWarning): Use binary search.
3477 2005-10-29 Marek Safar <marek.safar@seznam.cz>
3479 * driver.cs: Implemeted resource visibility.
3480 (Resources): New class for code sharing between /res: and
3483 2005-11-07 Marek Safar <marek.safar@seznam.cz>
3485 decl.cs (CurrentTypeParameters): Fixed to be public.
3487 2005-11-07 Marek Safar <marek.safar@seznam.cz>
3489 generic.cs, rootcontext.cs: Removed NewConstraintAttribute.
3491 2005-11-07 Marek Safar <marek.safar@seznam.cz>
3493 gmcs.exe.sources: Use CryptoConvert.cs from corlib.
3495 2005-11-05 Kornél Pál <kornelpal@hotmail.com>
3497 * gmcs.exe.config: Updated runtime version to v2.0.50727 (2.0 RTM).
3499 2005-11-04 Carlos Alberto Cortez <calberto.cortez@gmail.com>
3501 Add friend assembly access support.
3502 * typemanager.cs: assembly_internals_vis_attrs
3503 cache for friend assembly access.
3504 (TypeManager.IsFriendAssembly): New method for
3505 checking friend assembly access.
3506 (TypeManager.Error_FriendAccessNameNotMatching): New
3508 (TypeManager.CompareKeyTokens): Likewise.
3509 (TypeManager.Filter): Handle friend accessible
3512 * namespace.cs (RootNamespace.GetTypeInAssembly): Return
3513 friend accessible types.
3515 * ecore.cs (Expression.IsAccessorAccessible): Handle
3516 friend accessible properties.
3518 * decl.cs (DeclSpace.CheckAccessLevel): Handle friend
3521 2005-10-28 Marek Safar <marek.safar@seznam.cz>
3524 * cfold.cs (ConstantFold.BinaryFold): Implemented null cast
3527 * convert (Convert.ImplicitReferenceConversion): NullCast holds
3530 * ecore.cs (NullCast): Child is contant only.
3532 * literal.cs (NullLiteral.Reduce): null can be converted to any
3535 2005-10-28 Kornél Pál <kornelpal@hotmail.com>
3537 * driver.cs: Use Encoding.Default as default code page instead
3540 2005-10-27 Raja R Harinath <rharinath@novell.com>
3543 * expression.cs (Invocation.Error_InvalidArguments): Handle
3544 __arglist parameters.
3545 (Invocation.VerifyArgumentsCompat): Likewise.
3546 * support.cs (ReflectionParameters.GetSignatureForError): Print
3547 __arglist parameters.
3548 (InternalParamters.GetSignatureForError): Likewise.
3549 * parameter.cs (Parameters.GetSignatureForError): Likewise.
3551 2005-10-26 Marek Safar <marek.safar@seznam.cz>
3553 * attribute.cs (GetPropertyValue): Made public.
3555 * codegen.cs (AssemblyClass): ResolveClsCompliance renamed to
3557 Add new property WrapNonExceptionThrows to handle 2.0 assembly
3559 (AssemblyClass.Emit): Emit RuntimeCompatibilityAttribute when it
3562 * driver.cs: Reflect method name change.
3564 * statement.cs (Try.Resolve): Warn when try has both general
3567 * typemanager.cs: runtime_compatibility_attr_type new predefined
3570 2005-10-26 Raja R Harinath <harinath@gmail.com>
3573 * pending.cs (InterfaceMethod): Allow tm.args [i] to be null --
3574 treat it as an empty parameter list.
3576 2005-10-26 Raja R Harinath <rharinath@novell.com>
3579 * ecore.cs (SimpleName.DoSimpleNameResolve): Make fall-back
3580 ResolveAsTypeStep silent.
3581 * statement.cs (Block.AddConstant): Mark block as used.
3582 (Block.ResolveMeta): Avoid piling on error messages
3583 if a constant initializer resolution fails.
3585 2005-10-25 Raja R Harinath <rharinath@novell.com>
3587 * namespace.cs (RootNamespace.VerifyUsingForAll, Namespace.VerifyUsing):
3589 (NamespaceEntry.VerifyAllUsing): New.
3590 (NamespaceEntry.AliasEntry.Resolve): New. Handles common error
3591 behaviour. Delegates actual resolution of alias to ...
3592 (NamespaceEntry.DoResolve): ... this. Renamed from Resolve.
3593 (NamespaceEntry.LocalAliasEntry, NamespaceEntry.ExternAliasEntry):
3595 * driver.cs (Driver.MainDriver): Update.
3597 * namespace.cs (NamespaceEntry.DefineNamespace): Remove.
3598 (NamespaceEntry.SymbolFileID): Make into a on-demand computed
3600 (Namespace.DefineNamespaces, RootNamespace.DefineNamespacesForAll):
3602 * symbolwriter.cs (SymbolWriter.Initialize): Don't call
3603 RootNamespace.DefineNamespacesForAll.
3605 2005-10-24 Raja R Harinath <harinath@gmail.com>
3607 * typemanager.cs (assemblies, external_aliases, modules)
3608 (AddAssembly, AddExternAlias, AddModule GetAssemblies, Modules)
3609 (ComputeNamespaces, GetRootNamespace): Remove extra staging
3610 overhead. Move resposibility ...
3611 * namespace.cs (GlobalRootNamespace): ... here. Update to changes.
3612 * driver.cs, attribute.cs, codegen.cs: Update to changes.
3614 2005-10-23 Raja R Harinath <harinath@gmail.com>
3616 * namespace.cs (RootNamespace.all_namespaces): Renamed from
3617 cached_namespaces. Improve usage.
3618 (RootNamespace.Reset, RootNamespace.RegisterNamespace)
3619 (RootNamespace.VerifyUsingForAll, RootNamespace.DefineNamespacesForAll):
3620 Move from GlobalRootNamespace and simplify.
3621 (RootNamespace.Global): Make instance variable.
3622 (RootNamespace.RootNamespace): Add "alias name" parameter.
3623 (GlobalRootNamespace): Simplify drastically.
3624 (Namespace.Lookup): Don't use GetNamespace.
3625 * typemanager.cs (GetRootNamespace): Rename from
3626 ComputeNamespaceForAlias.
3627 (NamespaceClash): Use Global.IsNamespace instead of GetNamespace.
3629 2005-10-23 Marek Safar <marek.safar@seznam.cz>
3631 * anonymous.cs (AnonymousContainer): Don't crash when container
3634 2005-10-23 Marek Safar <marek.safar@seznam.cz>
3636 * expression.cs (Binary.DoResolve): Warn when comparing same
3639 2005-10-23 Marek Safar <marek.safar@seznam.cz>
3642 * expression.cs (Binary.DoResolve): It looks like there are no
3643 convetsion rules in enum context.
3645 2005-10-19 Carlos Alberto Cortez <calberto.cortez@gmail.com>
3647 Add support for extern alias qualifiers.
3648 * typemanager.cs: Move some LookupTypeReflection code
3649 to namespace.cs, to have cleaner code. Added some methods
3650 to help us keep track of the extern aliased references.
3651 * driver.cs: Add suport for extern alias assemblies on command
3652 line and check for their warnings/errors. Also keep track of the
3653 extern aliased assemblies.
3654 * namespace.cs: Move the global functionality of Namespace
3655 to GlobalRootNamespace/RootNamespace. Now the global namespace
3656 is GlobalRootNamespace.Globa. Also the code moved from
3657 typemanager.cs lives in GlobalRootNames.cs/RootNamespace.cs.
3658 Finally added LocalAliasEntry (AliasEntry before) and
3659 ExternAliasEntry, to handle alias statements.
3660 * cs-parser.jay: Add support in the grammar for extern alias
3662 * doc.cs, delegate.cs, expression.cs ecore.cs, symbolwriter.cs:
3663 Update callings to Namespace (now in GlobalRootNamespace).
3665 2005-10-25 Martin Baulig <martin@ximian.com>
3667 * convert.cs (ImplicitTypeParameterConversion): Make base
3668 interfaces actually work; fixes #76557.
3670 2005-10-25 Martin Baulig <martin@ximian.com>
3673 (GenericMethod.Define): Call TypeParameter.DefineConstraints() on
3674 all the type parameters; fixes #76551.
3676 2005-10-25 Martin Baulig <martin@ximian.com>
3681 (GenericMethod.ctor): Added `Expression return_type' and
3682 `Parameters parameters' arguments.
3683 (GenericMethod.DefineType): Call ResolveAsTypeTerminal() on the
3684 parameter and return types to check their constraints if they're
3687 * codegen.cs (EmitContext.ResolvingGenericMethod): New public
3690 * ecore.cs (Expression.ResolveAsTypeTerminal): Don't check the
3691 constraints of a generic type if `ec.ResolvingGenericMethod'.
3693 * class.cs (MethodCore.DoDefineParameters): Set
3694 `ec.ResolvingGenericMethod' if we're a generic method.
3695 (MemberBase.MemberType): Likewise.
3697 2005-10-25 Carlos Alberto Cortez <calberto.cortez@gmail.com>
3699 * typemanager.cs (TypeManager): Added
3700 TypeManager.internals_visible_attr_type to cache
3701 S.R.CompilerServices.InternalsVisibleToAttribute.
3703 * codegen.cs (AssemblyClass): Added checks for
3704 InternalsVisibleToAttribute in new method
3705 CheckInternalsVisibleAttribute () and also cache the
3706 AssemblyName in AssemblyClass.Name.
3708 2005-10-24 Martin Baulig <martin@ximian.com>
3711 (TypeManager.ExpandInterfaces): Added overloaded version which
3712 just takes a `Type[]' array.
3715 (Constraints.Resolve): Don't expand the interfaces here; ie. we
3716 just use the interfaces which were explicitly specified and not
3717 the interfaces they inherit. Fixes #76482.
3718 (TypeParameter.FindMembers): Expand the interfaces here.
3720 2005-10-21 Martin Baulig <martin@ximian.com>
3723 (Constraints.Resolve): Also resolve the actual types here.
3724 (Constraints.ResolveTypes): Just check the constraints here.
3725 Fixes #76363; see gtest-218.cs.
3727 2005-10-21 Martin Baulig <martin@ximian.com>
3730 (Convert.ImplicitTypeParameterConversion): Use a `ClassCast'
3731 instead of a `BoxedCast'; fixes gtest-217.cs.
3733 2005-10-20 Atsushi Enomoto <atsushi@ximian.com>
3735 * generic.cs : (ConstructedType.CheckConstraints) warn CS0310 when
3736 1) "new()" is specified as generic parameter constraint and 2) the
3737 type is TypeBuilder and 3) the type is abstract even if it has a
3738 default .ctor(). Now errors/gcs0310-3.cs is correctly rejected.
3740 2005-10-20 Martin Baulig <martin@ximian.com>
3743 (GenericConstraints.TypeParameter): New public property.
3744 (TypeParameter.ctor): Also take a `DeclSpace' argument.
3745 (TypeParameter.DeclSpace): New public property.
3746 (TypeParameter.DefineType): Inflate the constraints if our
3747 `DeclSpace' is an `Iterator'.
3749 2005-10-19 Atsushi Enomoto <atsushi@ximian.com>
3751 * class.cs, decl.cs : (MemberCache.FindMemberToOverride) added
3752 GenericMethod argument to compare methods' generic type arguments.
3755 2005-10-19 Martin Baulig <martin@ximian.com>
3757 * class.cs (TypeContainer.DefineType): Only use ResolveAsTypeStep(),
3758 not ResolveType() when resolving the base type, so we're not
3759 checking the constraints here.
3760 (TypeContainer.ResolveType): Call ResolveType() on our base_type
3763 2005-10-19 Martin Baulig <martin@ximian.com>
3765 * generic.cs (ConstructedType.CheckConstraints): Committing
3766 untested fix for #76441.
3768 2005-10-18 Raja R Harinath <rharinath@novell.com>
3771 * class.cs (TypeContainer.DefineType): Move updating of
3772 topological sort earlier in the code.
3773 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Don't use TypeBuilder.
3775 2005-10-18 Marek Safar <marek.safar@seznam.cz>
3778 * cfold.cs (BinaryFold): Reduce constant in enum conversion.
3780 * constant.cs (Constant.TryReduce): Moved from Cast class.
3781 (Reduce): Made little bit more OO and fixed missing conversions.
3783 * ecore.cs (Reduce): Implemented.
3784 (Binary.EnumLiftUp): New method to upgrade values to enum values.
3786 * literal.cs (Reduce): Implemented.
3788 * class.cs: Reverted Miguel's wrong commit.
3790 2005-10-14 Miguel de Icaza <miguel@novell.com>
3792 * ecore.cs (GetMemberType): Report the correct mapping for the MemberCore
3794 2005-10-14 Atsushi Enomoto <atsushi@ximian.com>
3796 * cs-parser.jay, expression.cs : CS0214 was missing error location
3797 for constants. Fixed bug #76404.
3799 2005-10-10 Raja R Harinath <rharinath@novell.com>
3801 * ecore.cs (PropertyExpr.Emit): Use Invocation.EmitCall to emit
3803 (PropertyExpr.EmitCall): Likewise.
3804 * expression.cs (Invocation.EmitArguments): Handle case where
3806 (Invocation.EmitCall): Avoid allocating temporary variable if
3807 there are no arguments.
3809 2005-10-11 Marek Safar <marek.safar@seznam.cz>
3812 * convert.cs (ExplicitConversionCore): Fixed object->enum
3815 2005-10-07 Raja R Harinath <rharinath@novell.com>
3818 * convert.cs (ImplicitConversionStandard): Move conversion of
3819 void* to arbitrary pointer types ...
3820 (ExplicitConversionStandard): .. here.
3821 * ecore.cs (Expression.Error_ValueCannotBeConverted): Fix CS0266
3822 error to always print typenames.
3824 2005-10-07 Raja R Harinath <rharinath@novell.com>
3826 * convert.cs (GetConversionOperator): Rename from
3827 GetConversionOperators. Move operator selection code from ...
3828 (UserDefinedConversion): ... here.
3830 2005-10-06 Marek Safar <marek.safar@seznam.cz>
3832 * convert.cs (ExplicitConversionCore): Removed duplicate enum
3835 2005-10-05 Marek Safar <marek.safar@seznam.cz>
3837 * assign.cs (Assign.DoResolve): Error method changed.
3839 * cfold.cs (DoConstantNumericPromotions): Error method changed.
3841 * const.cs (ResolveValue): Reset in_transit immediately.
3843 * constant.cs: Error method changed.
3845 * convert.cs: Removed useless location parameter.
3846 (ExplicitNumericConversion): Don't do double enum check.
3847 (ExplicitConversionCore): Renamed from ExplicitConversion.
3848 (ExplicitUnsafe): Extracted from ExplicitConversion.
3849 (ExplicitConversion): Uses for error reporting.
3851 * ecore.cs (Error_ValueCannotBeConverted): More logic for more
3853 (ResolveBoolean): Uses common error method.
3854 (CastToDecimal): Get rid of ec.
3855 (CastFromDecimal): Optimized.
3856 (ConvCast): Get rid of ec.
3858 * enum.cs (ResolveValue): Reset in_transit immediately.
3859 (Emit): Return after first error.
3861 * expression.cs: Convert changes.
3863 * literal.cs: Error method changed.
3865 * statement.cs: Error method changed.
3867 2005-10-06 Raja R Harinath <rharinath@novell.com>
3869 Fix gtest-131.cs and gtest-211.cs.
3870 * generic.cs (Nullable.LiftedBinaryOperator.EmitEquality):
3871 Only emit code for a label if it is used. Unreachable code can
3872 violate ECMA evaluation stack invariants.
3874 2005-09-27 Marek Safar <marek.safar@seznam.cz>
3876 * anonymous.cs: Implemented ExprClassName.
3878 * assign.cs (Assign.DoResolve): Don't chrash when type is not
3881 * attribute.cs (ResolveArguments): Enabled MethodImplOptions
3884 * class.cs (StaticClass.DefineContainerMembers): Report protected
3887 * codegen.cs: if(ed) PRODUCTION.
3889 * convert.cs (Error_CannotImplicitConversion): Better error
3892 * cs-parser.jay: More error checks.
3894 * cs-tokenizer.cs (consume_identifier): Fixed Miguel's revert.
3896 * driver.cs (CSCParseOption): Enabled wrong option check.
3898 * ecore.cs (Expression.ExprClassName): Turned to property.
3899 (MemberExpr.CheckIntermediateModification): For checking boxed
3900 value types modification.
3902 * statement.cs (Fixed.Resolve): Expression type must be
3903 convertible to fixed type.
3904 (CollectionForeach.GetEnumeratorFilter,TryType):
3905 Small refactoring for easier error checking.
3907 2005-09-26 Marek Safar <marek.safar@seznam.cz>
3909 * attribute.cs (Attribute.Resolve): Check Obsolete attribute for
3912 * class.cs (GeneratedBaseInitializer): New class for customization
3913 compiler generated initializers.
3914 (MemberBase.DoDefine): Check Obsolete attribute here.
3915 (FieldMember.DoDefine): Ditto.
3917 * const.cs (ExternalConstant.CreateDecimal): Builder for decimal
3920 * decl.cs (MemberCore.EmitContext): Returns valid current ec.
3921 (MemberCore.GetObsoleteAttribute): Removed argument.
3922 (MemberCore.CheckObsoleteness): Obsolete attributes are hierarchic.
3923 (MemberCore.CheckObsoleteType): New helper.
3927 * statement.cs: Updates after MemberCore changes.
3929 * ecore.cs (TypeExpr.ResolveType): Check type obsoleteness here.
3930 (FieldExpr.ResolveMemberAccess): Fixed decimal constants checks.
3932 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't check
3933 obsolete attribute for compiler construct.
3934 (As.DoResolve): Cache result.
3936 * iterators.cs (Define_Constructor): Use GeneratedBaseInitializer.
3938 2005-10-01 Miguel de Icaza <miguel@novell.com>
3940 * expression.cs (Probe): instead of having a "Type probe_type"
3941 keep the extra information as a TypeExpr probe_type_expr since the
3942 "As" operator needs to perform some type checks.
3944 * (As.DoResolve): If the type is a type parameter, ensure that it
3945 is constrained by a class.
3947 2005-09-22 Miguel de Icaza <miguel@novell.com>
3949 * statement.cs (Lock): Use the TemporaryVariable class instead of
3950 manually using local variables as those do not work when variables
3953 * ecore.cs: Moved the TemporaryVariable class from being a nested
3954 class inside Foreach to be a public class that can be employed in
3957 2005-09-19 Marek Safar <marek.safar@seznam.cz>
3959 * cs-parser.jay: interface_accessors replaced by
3960 accessor_declarations.
3962 * ecore.cs, literal.cs, statement.cs: NullLiteral holds null
3965 * statement.cs (GotoCase.Resolve): Convert null constant to
3967 (SwitchLabel.ResolveAndReduce): Ditto.
3968 (SwitchLabel.NullStringCase): Custom null stamp.
3969 (Switch.SimpleSwitchEmit): Fix from NullLiteral to NullStringCase.
3971 typemanager.cs (CSharpSignature): Don't skip first argument
3974 2005-09-16 Marek Safar <marek.safar@seznam.cz>
3976 * cfold.cs, constant.cs, convert.cs, ecore.cs,
3977 expression.cs, iterators.cs, literal.cs: Store constants and
3980 * class.cs (MemberBase.ShortName): Pass location.
3982 * cs-parser.jay: Some location fixes.
3984 * ecore.cs (Expression.Location): Made virtual.
3986 2005-09-27 Marek Safar <marek.safar@seznam.cz>
3989 * const.cs (Const.ResolveValue): Check for assigning non-null
3990 value to reference type.
3992 2005-09-26 Raja R Harinath <rharinath@novell.com>
3995 * expression.cs (This.VerifyFixed): In a value type T, the type of
3996 'this' is T&, iow, 'this' is either an out or ref parameter. In a
3997 value type R, 'this' is treated as a value parameter.
3999 2005-09-05 Miguel de Icaza <miguel@novell.com>
4001 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
4002 if the underlying types are the same, otherwise we need to produce
4003 code that will do the proper cast.
4005 This was exposed by Marek's constant rewrite which produced
4006 invalid code for the call site:
4009 void Method (X v) {}
4013 This fixes test-49.cs
4015 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
4017 * attribute.cs : (Attribute.IsValidArgumentType): array of string/
4018 Type/Object should be allowed as well. Fixed bug #75968.
4020 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
4022 * expression.cs : (Binary.DoResolve): when one is enum constant and
4023 another is constant 0, then return enum one *as enum type*.
4026 2005-10-04 Martin Baulig <martin@ximian.com>
4028 * ecore.cs (PropertyExpr.ResolveAccessors): Cosmetic fix; make the
4029 `SetMemberIsUsed()' work for generics, too.
4031 2005-10-04 Martin Baulig <martin@ximian.com>
4033 * expression.cs (DelegateInvocation.EmitStatement): Make this work
4034 for corlib. Fixes #75691.
4036 2005-09-28 Marek Safar <marek.safar@seznam.cz>
4039 * driver.cs: Fix compilation files with full root path.
4041 2005-09-25 Miguel de Icaza <miguel@novell.com>
4043 * report.cs (SymbolRelatedToPreviousError): Format the output so
4044 it does not use an open parenthesis that is never closed.
4046 * driver.cs: Follow coding guidelines
4048 2005-09-18 Miguel de Icaza <miguel@novell.com>
4050 * driver.cs: Set InEmacs based on the environment variable EMACS.
4052 * location.cs (InEmacs): in this mode, do not report column
4053 location as it confuses Emacs.
4055 2005-10-03 Raja R Harinath <rharinath@novell.com>
4057 * support.cs (SeekableStreamReader.Position): Don't error out when
4058 the requested position is just beyond the end of the current
4061 2005-09-28 Raja R Harinath <rharinath@novell.com>
4063 * support.cs (SeekableStreamReader): Simplify drastically. Don't
4064 try to keep in sync with the byte count of the underlying Stream.
4065 However, this limits us to a window size of 2048 characters: i.e.,
4066 the maximum lookahead of our lexer/parser can be 2048 characters.
4068 2005-09-22 Martin Baulig <martin@ximian.com>
4070 * driver.cs: Removed a debugging FIXME.
4072 2005-09-21 Raja R Harinath <rharinath@novell.com>
4074 * cs-parser.jay (type_arguments): Add CS1644 check.
4075 * decl.cs (DeclSpace.AddToContainer): Restore CS0694 check.
4077 2005-09-15 Raja R Harinath <rharinath@novell.com>
4079 * Makefile (PROGRAM): Make profile specific.
4080 (gmcs.exe) [PROFILE=net_2_0]: Add utility rule to copy gmcs.exe to
4081 the current directory.
4084 * expression.cs (Invocation.EmitCall): Remove optimization on
4085 this_call since it doesn't handle 'this' being a value type.
4087 2005-09-05 Geoff Norton <gnorton@customerdna.com>
4089 * driver.cs: Ensure file handles are closed after parsing
4091 2005-09-05 Miguel de Icaza <miguel@novell.com>
4093 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
4094 if the underlying types are the same, otherwise we need to produce
4095 code that will do the proper cast.
4097 This was exposed by Marek's constant rewrite which produced
4098 invalid code for the call site:
4101 void Method (X v) {}
4105 This fixes test-49.cs
4107 2005-09-05 Martin Baulig <martin@ximian.com>
4109 * expression.cs (As.DoResolve): Use `probe_type.IsValueType'
4110 instead of `TypeManager.IsValueType (probe_type)'; fixes #75668.
4112 * cs-parser.jay (delegate_declaration): Small fix for #75852.
4114 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
4116 * typemanager.cs: (IsUnmanagedType) : generic parameter is not allowed
4117 to be a pointer type due to the spec 25.2, so check if declaring
4118 type is generic type definition. Fixed bug #75772.
4120 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
4123 * generic.cs : (TypeManager.IsEqual(Type,Type)): it should work when
4124 both types are not defined by methods.
4125 * expression.cs : (Invocation.IsApplicable): it should work when
4126 the argument type is equal to the parameter type, not only when
4127 ImplicitConversionExists() returns true.
4129 2005-09-02 Raja R Harinath <rharinath@novell.com>
4131 * attribute.cs (GetMarshal): Work even if "DefineCustom" is
4135 * ecore.cs (SimpleNameResolve.DoSimpleNameResolve): Disable
4136 flow-branching for LocalVariableReferences in case we were invoked
4137 from a MemberAccess.
4138 * expression.cs (LocalVariableReference.VerifyAssigned): New.
4140 (LocalVariableReference.DoResolveBase): ... this.
4141 (MemberAccess.Resolve): Do the check that was disabled during
4144 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
4147 (PartialContainer.Create): check abstract/sealed/static strictly
4148 but abstract/sealed can exist only at one side. Fixed bug #75883.
4150 2005-09-01 Kornél Pál <kornelpal@hotmail.com>
4153 * attribute.cs (Attribute.GetMarshal): If ArraySubType is not
4154 specified, don't default to UnmanagedType.I4.
4156 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
4158 * expression.cs : conditional operator should check possibly
4159 incorrect assign expression. Fixed bug #75946.
4161 2005-08-30 Raja R Harinath <rharinath@novell.com>
4164 * anonymous.cs (ScopeInfo.MakeFieldName): New helper.
4165 (ScopeInfo.EmitScopeType): Use it to construct field names from
4166 names of captured locals.
4169 * ecore.cs (BoxedCast.BoxedCast) [1-argument variant]: Remove.
4170 * convert.cs (ImplicitReferenceConversion, TryImplicitIntConversion):
4171 Pass 'target_type' to BoxedCast. Don't default to 'object'.
4172 (ExplicitConversion): Remove enum cases already handled by
4173 implicit conversion. Move implicit conversion check to the beginning.
4174 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Update.
4175 * expression.cs (ArrayCreation.EmitDynamicInitializers):
4176 Don't treat System.Enum as a struct.
4178 2005-08-30 Jb Evain <jbevain@gmail.com>
4180 * attribute.cs: handles as expression in parameters.
4182 2005-08-30 Raja R Harinath <rharinath@novell.com>
4185 * class.cs (TypeContainer.VerifyClsName): Don't use a
4186 PartialContainer when verifying CLS compliance.
4187 (AbstractPropertyEventMethod): Set Parent here, ...
4188 (PropertyMethod): ... not here.
4190 2005-08-30 Atsushi Enomoto <atsushi@ximian.com>
4192 * attribute.cs : escaped attribute name should not be allowed to be
4193 resolved (e.g. @class as classAttribute). Fixed bug #75930.
4195 2005-08-29 Raja R Harinath <rharinath@novell.com>
4198 * convert.cs (ImplicitStandardConversionExists): Allow zero also
4199 when converting a long constant to unsigned long.
4200 * expression.cs (Invocation.OverloadResolve): Add sanity check to
4201 detect where IsApplicable and VerifyArgumentsCompat disagree.
4203 2005-08-29 Raja R Harinath <rharinath@novell.com>
4204 and Carlos Alberto Cortez <carlos@unixmexico.org>
4207 * class.cs (TypeContainer.CanElideInitializer): New helper.
4208 (TypeContainer.EmitFieldInitializers): Use it to determine if we
4209 can safely emitting the initializer of a field.
4211 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
4213 * statement.cs : (Continue.Resolve()) Unlike break, continue is not
4214 allowed inside a switch (without loop). Fixed bug #75433.
4216 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
4218 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
4219 * mcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
4221 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
4223 * driver.cs : kinda reverting the default encoding changes (not exact
4224 revert since I noticed that "codepage:reset" might not work fine).
4226 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
4228 * class.cs : (AbstractPropertyEventMethod) SetupName() now takes
4229 Location. Now getter and setter store location correctly.
4230 (errors/cs0111-12.cs now reports the expected location.)
4232 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
4234 * driver.cs : Use default encoding on the environment.
4235 Removed (now that) extra parameter for SeekableStreamReader.
4236 * support.cs : (SeekableStreamReader) third .ctor() argument for
4237 StreamReader is not required (always true). preamble size could
4238 be acquired in simpler and safe way.
4240 2005-08-24 Atsushi Enomoto <atsushi@ximian.com>
4242 * cs-parser.jay: report CS0642 at warning level 3
4243 and report CS0642 for an if else statement also
4244 fixes bug #74745. Patch by John Luke (and a bit
4246 Removed extra CS0642 warning check for "while",
4248 * statement.cs: In Block.Resolve(), CS0642 check
4249 is reimplemented to check a sequence of an empty
4250 statement and a block.
4252 Both fix bug #66777.
4254 2005-08-24 Marek Safar <marek.safar@seznam.cz>
4256 * attribute.cs (GetMethodObsoleteAttribute): Disabled obsolete properties
4257 detection until I fix it.
4259 * cs-tokenizer.cs: Changed error message.
4261 * cs-parser.jay: Fixed 2 error locations.
4263 * ecore.cs (Error_TypeDoesNotContainDefinition): Share error message.
4264 (PropertyExpr.Error_PropertyNotFound): First attempt to detect non C#
4267 * enum.cs (GetSignatureForError): Fixed.
4269 * expression.cs (Invocation.IsSpecialMethodInvocation): Improved special
4273 * typemanager.cs (RegisterProperty): Removed.
4275 * statement.cs (CheckInvariantMeaningInBlock): Changed error message.
4277 2005-08-24 Raja R Harinath <rharinath@novell.com>
4280 * expression.cs (ArrayAccess.EmitLoadOpcode): Emit ldelem.i for pointers.
4281 (ArrayAccess.GetStoreOpcode): Return stelem.i for pointers.
4283 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
4285 * expression.cs : tiny fix is required for not warning positive ulong.
4288 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
4290 * expression.cs : add CS0652 check for constant and integral
4291 expression. Fixed bug #53974.
4293 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
4295 * expression.cs : in DoNumericPromotions(), check if there is implicit
4296 conversion overload for string (to check CS0034). Fixed bug #52492.
4298 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
4300 * cs-tokenizer.cs : Check newline in char constant. Fixed bug #75245.
4302 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
4304 * ecore.cs : report location when it is *not* Null.
4306 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
4312 Added OmitStructFlowAnalysis to EmitContext to handle CS0165 check
4313 correctly. Fixed bug #75721.
4315 2005-08-23 Raja R Harinath <rharinath@novell.com>
4317 * support.cs (SeekableStreamReader.Position): Avoid an expensive
4318 loop that performs 'min (pos, char_count)'.
4321 * expression.cs (Unary.ResolveOperator): Don't discard implicit
4322 converted value in Operator.OnesComplement.
4324 2005-08-22 Ben Maurer <bmaurer@ximian.com>
4326 * anonymous.cs: If the anon method is pulled into a helper class,
4327 it needs to be `internal' not `private'. Fixes runtime behavior on
4330 2005-08-17 Marek Safar <marek.safar@seznam.cz>
4333 * decl.cs (DeclSpace.VerifyClsCompliance): Skip when collision object
4336 2005-08-16 Marek Safar <marek.safar@seznam.cz>
4338 The big constants rewrite
4339 Fix #75746, #75685 and more
4340 As a side effect saved 1MB for MWF ;-)
4342 * attribute.cs (GetAttributeArgumentExpression): Use ToType, GetTypedValue.
4343 (GetMarshal, GetMethodImplOptions, GetLayoutKindValue): Values are not
4344 enum based for corlib compilation.
4346 * cfold.cs (BinaryFold): Convert operand for enum additions. Fixed enum
4349 * class.cs (FixedField.Define): Use ResolveAsConstant.
4351 * const.cs (IConstant): Interface constants and enums.
4352 (Const.ResolveValue): New method for constant resolvning.
4353 (ExternalConstant): Constants from imported assemblies.
4355 * constant.cs (Constant.GetTypedValue): Used to get constant with forced
4356 conversion; like enums.
4357 (Constant.ToType): Converts this constant to different type.
4358 (Constant.Increment): Adds 1.
4360 * convert.cs (ImplicitConversionRequired): Simplified.
4362 * cs-parser.jay: Create EnumMember directly.
4364 * decl.cs (MemberCore.CheckObsoleteness): Checks for ObsoleteAttribute presence.
4366 * doc.cs (GenerateEnumDocComment): Removed.
4368 * ecore.cs (Expression.ResolveAsConstant): New constant specific method.
4369 (ConvertIntLiteral): Removed.
4370 (FieldExpr.ResolveMemberAccess): Refactored to remove constant specific if(s).
4372 * enum.cs (EnumMember): Implement IConstant.
4373 (Enum.IsValidEnumConstant): Removed.
4374 (Enum.GetNextDefaultValue): Removed.
4375 (Enum.FindMembers): Updated.
4376 (Enum.GenerateDocComment): Iterate enum members.
4378 * expression.cs (Cast.TryReduce): Handle enums correctly.
4379 (New.Constantify): Made public.
4380 (MemberAccess.DoResolve): Removed contant specific if(s).
4382 * literal.cs (NullLiteral): Implement new abstract methods.
4384 * statement.cs (GotoCase.Resolve): Use new constant methods.
4385 (SwitchLabel.ResolveAndReduce): Use new constant methods.
4387 * typemanager.cs (LookupEnum): Removed.
4388 (IsEnumType): Fixed to work with corlib.
4389 (RegisterConstant): Removed.
4390 (LookupConstant): Removed.
4391 (GetConstant): Changed to work with IConstant.
4393 2005-08-04 Atsushi Enomoto <atsushi@ximian.com>
4395 * location.cs : Fixed overflown (>255) column number.
4397 2005-08-03 Raja R Harinath <rharinath@novell.com>
4399 First cut of the qualified-alias-member feature.
4400 * cs-tokenizer.cs (Tokenizer.is_punct): Recognize the double-colon
4402 * cs-parser.jay (DOUBLE_COLON): New token.
4403 (namespace_or_type_name): Add rule for recognizing
4404 qualified-alias-members.
4405 (primary_expression): Likewise.
4406 (element_access): Allow QualifiedAliasMember as a possible
4407 type-bearing expression.
4408 (local_variable_type, local_variable_pointer_type): Likewise.
4409 * namespace.cs (NamespaceEntry.LookupAlias): New. Looks up
4410 aliases in the current and enclosing namespace declarations.
4411 (NamespaceEntry.UsingAlias): Add CS0440 warning.
4412 * decl.cs (MemberName.is_double_colon): New.
4413 (MemberName.MemberName): Add new constructor for alias-member.
4414 (MemberName.GetTypeExpression): Generate QualifiedAliasMember too.
4415 * expression.cs (QualifiedAliasMember): New expression type.
4417 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
4419 * location.cs : it borked when no argument was specified.
4421 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
4423 * location.cs : tiny ToString() format fix.
4425 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
4427 * statement.cs : oops, it was missing.
4429 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
4431 A set of fixes for precise line/column location.
4434 "token" field now holds a file/line "delta", a line number offset
4435 from the segment, and a column number. See also:
4436 http://lists.ximian.com/pipermail/mono-devel-list/2004-
4437 December/009508.html
4438 Removed static IsNull. Use instance IsNull property instead.
4440 For some tokens it stores Location. For Identifier it stores
4441 LocatedToken which is a pair of string name and location.
4442 Column numbers are adjusted only at getChar().
4444 Use Location.ToString() for reporting (it now contains column).
4446 Largely modified to use LocatedToken instead of
4447 string (IDENTIFIER), and to acquire Location from some tokens.
4448 * namespace.cs, decl.cs, ecore.cs, class.cs, delegate.cs,
4449 iterators.cs, const.cs, anonymous.cs, tree.cs, enum.cs,
4451 Now MemberName holds Location. DeclSpace.ctor() receives Location
4452 as a parameter. Removed extra parameters to all derived classes.
4453 Replaced Location.IsNull() with instance property.
4454 * assign.cs, expression.cs :
4455 Added .ctor() overload that omits Location.
4457 Added "nameEscaped" flag that indicates the identifier was escaped
4458 in the source file. This fixes bug #57047.
4460 2005-09-02 Martin Baulig <martin@ximian.com>
4462 * class.cs: Make CS3005 a warning, not an error.
4464 2005-08-02 Marek Safar <marek.safar@seznam.cz>
4466 * attribute.cs (AttributeTester.GetImportedIgnoreCaseClsType):
4467 New method, looking for lo-case imported cls type.
4469 * decl.cs (DeclSpace.VerifyClsCompliance): Check CS3005 for types
4472 * driver.cs: Removed VerifyTopLevelNameClsCompliance usage.
4474 * enum (Enum.VerifyClsCompliance): Hardcode non-compliant types.
4476 * typemanager.cs (TypeManager.AllClsTopLevelTypes): Renamed from
4478 (TypeManager.LoadAllImportedTypes): Lo-case imported types.
4480 Optimized to save 3.5 MB for SWF compilation.
4482 2005-08-01 Marek Safar <marek.safar@seznam.cz>
4484 * class.cs (AddToTypeContainer): Use inheritance insted of if(s).
4485 (PartialContainer.Create): Moved logic AddToContainer.
4486 (PartialContainer.MarkForDuplicationCheck): Shares name.
4488 * decl.cs (DeclSpace.AddToContainer): Check name collisions at one
4491 * namespace.cs (Namespace.AddDeclSpace): Lazy declspaces
4493 (Namespace.GetSignatureForError): New method.
4495 * tree.cs (Tree.RecordDecl): Moved to AddToContainer.
4496 (RootTypes.AddToTypeContainer): se inheritance insted of if(s).
4498 2005-08-01 Raja R Harinath <rharinath@novell.com>
4501 * ecore.cs (Expression.MemberLookupFailed): Use queried_type for
4502 member lookup rather than qualifier_type, since qualifier_type can
4505 2005-08-01 Marek Safar <marek.safar@seznam.cz>
4507 * enum.cs (Enum.VerifyClsName): Fixed to allow not CLSCompliant
4510 2005-07-31 Miguel de Icaza <miguel@novell.com>
4512 * statement.cs: Copy the local exception into the exception
4513 captured local. Fixes 75674
4515 2005-07-31 Raja R Harinath <harinath@gmail.com>
4518 * expression.cs (Invocation.OverloadResolve): Don't report error
4519 CS1501 if error CS1502 has been reported.
4520 (New.DoResolve): Delegate CS1501 reporting to
4521 Invocation.OverloadResolve.
4524 * statement.cs (Block.CheckInvariantMeaningInBlock): Verify
4525 invariant-meaning-in-block property in an enclosing block if
4528 2005-07-29 Marek Safar <marek.safar@seznam.cz>
4530 * statement.cs (SwitchLabel.ResolveAndReduce): Refactored.
4531 (SwitchLabel.Erorr_AlreadyOccurs): Share error message.
4532 (Switch.CheckSwitch): Just save 50kb for SWF.
4534 2005-07-27 Martin Baulig <martin@ximian.com>
4536 * anonymous.cs (CaptureContext.AddField): Added
4537 `AnonymousContainer am' argument; compute its toplevel scope if
4538 it's not already computed. Fixes #75649.
4540 2005-07-26 Raja R Harinath <rharinath@novell.com>
4543 * class.cs (Constructor.Emit): Reset block to null if the block
4546 2005-07-25 Marek Safar <marek.safar@seznam.cz>
4548 * class.cs (TypeContainer.VerifyMembers): Be compatible in warning 169.
4550 2005-07-25 Marek Safar <marek.safar@seznam.cz>
4552 * class.cs (MethodData.Define): Check whether accessor implementing
4553 interface is public.
4555 * driver.cs (Driver.parse): Try to be smart and check for `MZ' header.
4557 2005-07-22 Marek Safar <marek.safar@seznam.cz>
4560 * namespace.cs (LookupType): Moved same type check to...
4562 * typemanager.cs (LookupTypeReflection): Don't allow to import more types
4565 2005-07-21 Raja R Harinath <rharinath@novell.com>
4567 * namespace.cs (NamespaceLookupType): Avoid a string allocation when we
4568 already found a typebuilder.
4569 * class.cs (MethodCore.IsDuplicateImplementation): Compare
4570 MemberNames, not strings.
4572 * const.cs (Error_ExpressionMustBeConst):
4573 Rename from Error_EpressionMustBeConst.
4574 * const.cs, class.cs, statement.cd: Update.
4576 2005-07-21 Marek Safar <marek.safar@seznam.cz>
4580 * const.cs (Const.LookupConstantValue): Report missing contant expression
4582 (Error_EpressionMustBeConstant): Only one error method.
4584 * class.cs, statement.c: Updated.
4586 2005-07-20 Raja R Harinath <rharinath@novell.com>
4588 * statement.cs (Block.Flags): Add back HasVarargs.
4589 (Block.flags): Make protected.
4590 (ToplevelBlock.HasVarargs): Convert to a property that updates flags.
4592 * typemanager.cs (types, typecontainers, user_types): Remove.
4593 (UserTypes, TypeContainers): Likewise.
4594 (HandleDuplicate, AddDelegateType, AddEnumType): Likewise.
4595 (CleanUp, Reset): Update.
4596 (AddUserType): Combine variants. Now, only updates builder_to_declspace.
4597 (GetNestedType): Use Type.GetNestedType.
4598 (CoreLookupType): Take two arguments, the namespace and the
4599 basename of the type. Update to use the Namespace.Lookup
4601 (InitEnumUnderlyingTypes, InitCoreTypes): Update.
4602 (RealMemberLookup): Use IsNestedChildOf instead of playing with
4603 string concatenation and substring matches.
4604 * class.cs, enum.cs, delegate.cs: Update to changes.
4606 2005-07-20 Marek Safar <marek.safar@seznam.cz>
4608 * constant.cs (Constant.Error_ConstantValueCannotBeConverted): Moved from
4609 Expression and made virtual.
4611 * convert.cs (ImplicitReferenceConversionExists): Skip for value types.
4612 (ImplicitStandardConversionExists): Fixed `byte' typo ?
4614 * ecore.cs (Expression.Error_ConstantValueCannotBeConverted): Moved.
4616 * literal.cs (NullLiteral.Error_ConstantValueCannotBeConverted): Customize
4619 * convert.cs, ecore.cs, enum.cs: Reflect Error_ConstantValueCannotBeConverted
4622 2005-07-18 Marek Safar <marek.safar@seznam.cz>
4625 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Check whether
4626 AssemblyCultureAttribute is not used on executable.
4629 * typemanager.cs: Add System.Reflection.AssemblyCultureAttribute.
4631 2005-07-16 Raja R Harinath <rharinath@novell.com>
4634 * expression.cs (Binary.Warning_UnintendeReferenceComparison):
4635 New. Reports CS0252/CS0253.
4636 Mostly taken from preliminary patch by Duncak Mak.
4637 (Binary.DoResolveOperator): Store results of operator lookup.
4638 Use them to detect if we need to warn about unintended reference
4641 2005-07-15 Raja R Harinath <rharinath@novell.com>
4644 * namespace.cs (Namespace.Lookup): Add back location parameter.
4645 (Namespace.LookupType): Add CS0436 report. Add location parameter.
4646 * delegate.cs, ecore.cs, expression.cs: Update to changes.
4648 * codegen.cs (EmitContext.DeclSpace): Make readonly.
4649 * namespace.cs (Namespace.Lookup): Carve out type lookup into ...
4650 (Namespace.LookupType): ... this.
4651 (NamespaceEntry.GetUsingTable): Allocate only one zero-sized array
4653 * typemanager.cs (LookupTypeReflection): Remove buggy code that
4654 purported to handle pointers.
4655 (char_ptr_type, void_ptr_type): Use GetPointerType rather than
4658 2005-07-15 Marek Safar <marek.safar@seznam.cz>
4660 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
4663 2005-07-15 Raja R Harinath <rharinath@novell.com>
4665 * namespace.cs (Namespace.Lookup): Drop location parameter.
4666 (NamespaceEntry.LookupAlias): Remove. Merge into ...
4667 (NamespaceEntry.Lookup): ... this.
4668 (NamespaceEntry.Error_AmbiguousTypeReference):
4669 Move here from DeclSpace.
4670 (NamespaceEntry.LookupNamespaceOrType): Move support for dotted
4672 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): ... here.
4673 * decl.cs (DeclSpace.ErrorAmbiguousTypeReference):
4674 Move to NamespaceEntry.
4675 * delegate.cs, expression.cs: Update to changes.
4677 2005-08-31 Martin Baulig <martin@ximian.com>
4679 Committing a patch from Atsushi Enomoto for #75850.
4681 * statement.cs (Foreach.CollectionForeach.GetEnumeratorFilter):
4682 Prefer a generic enumerator over a non-generic one.
4684 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
4686 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
4687 * gmcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
4689 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
4691 * driver.cs : reverting default encoding change as well as mcs.
4693 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
4695 * driver.cs, support.cs : merged r48826.
4697 > could you integrate your mcs changes to gmcs otherwise
4698 > gmcs cannot compile some files.
4700 2005-08-20 Martin Baulig <martin@ximian.com>
4702 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
4703 scope if we don't already have it.
4705 * expression.cs (Invocation.EmitCall): Use `ec.EmitThis ()' rather
4706 than `ig.Emit (OpCodes.Ldarg_0)' to make it work inside iterators;
4709 2005-07-31 Miguel de Icaza <miguel@novell.com>
4711 * statement.cs: Copy the local exception into the exception
4712 captured local. Fixes 75674
4714 2005-07-15 Marek Safar <marek.safar@seznam.cz>
4716 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
4719 2005-08-12 Martin Baulig <martin@ximian.com>
4721 * expression.cs (MemberAccess.ResolveNamespaceOrType): Only search
4722 for nested types here to avoid hitting the cache too early.
4724 2005-08-09 Miguel de Icaza <miguel@novell.com>
4726 * enum.cs: On the new compiler CLS error 3005 is now a warning not
4729 2005-08-03 Martin Baulig <martin@ximian.com>
4731 Make iterators in generic methods work; see gtest-191.cs.
4734 (Constraints.Resolve): Protect against being called twice.
4737 (TypeContainer.GetClassBases): Make this `protected virtual'.
4739 * iterator.cs (Iterator.ctor): Added `GenericMethod' argument.
4740 (Iterator.GetClassBases): Override this and compute the base
4742 (Iterator.DefineNestedTypes): If we're a generic method, all our
4743 method type parameters become class type parameters on the proxy
4747 (ToplevelBlock.Parameters): Make this a property, not a field.
4748 (ToplevelBlock.ResolveMeta): Update the `parameters' from the `ip'.
4750 2005-08-03 Martin Baulig <martin@ximian.com>
4752 * typemanager.cs (TypeManager.IsSubclassOf): Use
4753 `TypeManager.IsEqual' instead of `Type.Equals'; fixes gtest-190.cs.
4754 (TypeManager.GetFullName_recursed): Improved.
4756 2005-07-27 Carlos Alberto Cortez <calberto.cortez@gmail.com>
4759 * ecore.cs (Expression.IsAccessorAccessible): Change the check for
4760 Private accessor case, using TypeManager.IsPrivateAccessible instead of
4761 invocation_type == mi.DeclaringType, since the first one also checks
4762 other condition used by generic instances.
4764 2005-07-27 Martin Baulig <martin@ximian.com>
4766 * anonymous.cs (CaptureContext.AddField): Added
4767 `AnonymousContainer am' argument; compute its toplevel scope if
4768 it's not already computed. Fixes #75649.
4770 2005-07-14 Marek Safar <marek.safar@seznam.cz>
4772 * attribute.cs (Attribute.ResolveAttributeType): Renamed from
4773 CheckAttributeType and refactored.
4774 (Attribute.ResolvePossibleAttributeType): Changed to reuse
4775 ResolveAsTypeTerminal error handling.
4776 (ResolveAsTypeTerminal): Introduced because of global attributes extra
4778 (GetSignatureForError): Print errors in same way.
4781 * codegen.cs: Reflect attribute GetSignatureForError change.
4784 * expression.cs: Add silent parameter to ResolveAsTypeStep.
4786 * namespace.cs (UsingEntry): Refactored to make fields private.
4789 statement.cs: Error_UnexpectedKind has extra parameter.
4791 2005-07-14 Raja R Harinath <rharinath@novell.com>
4793 * ecore.cs (IAlias): Remove.
4794 * decl.cs (DeclSpace): Don't derive from IAlias. Remove members
4795 that implement the interface.
4796 * namespace.cs (Namespace): Likewise.
4797 (Namespace.declspaces): Renamed from 'defined_names'.
4798 (Namespace.AddDeclSpace): Renamed from 'DefineName'. Take a
4799 DeclSpace instead of an IAlias.
4800 * tree.cs (Tree.AddDecl): Update.
4802 2005-07-12 Raja R Harinath <rharinath@novell.com>
4804 * statement.cs (Block.Flags); Remove HasVarargs.
4805 (Block.HasVarargs): Move to ToplevelBlock.
4806 (Block.ThisVariable, Block.AddThisVariable): Likewise.
4807 (Block.Variables): Make protected. Initialize variable hashtable
4809 (Block.AddVariable): Update.
4810 (Block.Resolve): Update to changes.
4811 (ToplevelBlock.HasVarargs): New boolean.
4812 (ToplevelBlock.ThisVariable): Move here from Block.
4813 (ToplevelBlock.AddThisVariable): Likewise.
4814 (ToplevelBlock.IsThisAssigned): New. Forwards call to this_variable.
4815 * expression.cs (This.ResolveBase): Update to changes.
4816 (ArglistAccess.DoResolve): Likewise.
4818 2005-07-11 Marek Safar <marek.safar@seznam.cz>
4821 * ecore.cs, class.cs: Use SetAssigned instead of direct access.
4823 * class.cs (TypeContainer.VerifyMembers): Distinguish between
4824 not used and not used & assigned.
4825 (FieldBase.ASSIGNED): Moved to MemberCore.Flags.
4827 2005-07-11 Marek Safar <marek.safar@seznam.cz>
4830 * expression.cs (Is.DoResolve): null is never provided type.
4832 2005-07-08 Marek Safar <marek.safar@seznam.cz>
4835 * cs-parser.jay: Less strict event error rule to catch more errors.
4837 2005-07-11 Martin Baulig <martin@ximian.com>
4839 * generic.cs (ConstructedType.CheckConstraints): Improve the check
4840 for the constructor constraint: we do not only have to check
4841 whether the class has a public constructor, but also ensure that
4842 it's parameterless. Fixes #75492.
4844 2005-07-11 Martin Baulig <martin@ximian.com>
4846 * expression.cs (Binary.ResolveOperator): Only allow `==' and `!='
4847 between type parameters if they either have the reference type
4848 constraint or the class constraint.
4850 2005-07-10 Kamil Skalski <nazgul@nemerle.org>
4852 * generic.cs: Use MakeGenericType instead of BindGenericParameters.
4854 2005-07-07 Marek Safar <marek.safar@seznam.cz>
4857 * attribute.cs (orig_sec_assembly): Holds original version of assembly.
4858 (ExtractSecurityPermissionSet): Cope with self referencing security
4859 attributes properly.
4861 * driver.cs (SetOutputFile): Made public property OutputFile.
4863 2005-07-07 Raja R Harinath <rharinath@novell.com>
4866 * class.cs (TypeContainer.first_nonstatic_field): Rename from
4867 has_nonstatic_fields. Make into a FieldBase pointer.
4868 (TypeContainer.AddField): Add CS0282 check.
4869 (TypeContainer.EmitType): Update.
4871 2005-07-06 Miguel de Icaza <miguel@novell.com>
4873 * cs-tokenizer.cs (consume_identifier): Do not create strings to
4874 compare if they start with __.
4876 2005-07-06 Raja R Harinath <rharinath@novell.com>
4878 * statement.cs (Switch.SwitchGoverningType): Only look at
4879 UserCasts that don't need implicit standard conversions to one of
4880 the allowed switch types (Fixes test-322.cs).
4881 (LocalInfo.Resolve): Re-enable sanity-test.
4883 2005-07-06 Marek Safar <marek.safar@seznam.cz>
4885 * cs-tokenizer.cs (consume_identifier): Detect double undescores
4887 * ecore.cs (FieldExpr.AddressOf): Changed volatile error to warning.
4889 * expression.cs (Invocation.DoResolve): Report error CS0245 here.
4891 2005-07-06 Raja R Harinath <rharinath@novell.com>
4894 * ecore.cs (SimpleName.GetSignatureForError): Add.
4895 * expression.cs (MemberAccess.DoResolve): Don't clobber 'expr' field.
4896 (MemberAccess.GetSignatureForError): Add.
4898 2005-07-05 Marek Safar <marek.safar@seznam.cz>
4900 The big error and warning messages review.
4930 * typemanager.cs: Updated.
4932 * class.cs: (MethodCore.SetYields): Moved here to share.
4933 (PropertyMethod.Define): Moved iterator setup here.
4935 * iterators.cs: Add orig_method to have full access to parent
4938 2005-07-05 Raja R Harinath <rharinath@novell.com>
4940 Make 'fixed variable' handling standards compliant. Fix #70807, #72729.
4941 * ecore.cs (IVariable.VerifyFixed): Remove 'is_expression' parameter.
4942 (FieldExpr.VerifyFixed): Ensure that the field is part of a fixed
4943 variable of struct type.
4944 * expression.cs (Unary.ResolveOperator): Update to change.
4945 (Indirection.VerifyFixed): Likewise.
4946 (LocalVariableReference.VerifyFixed): A local variable is always fixed.
4947 (ParameterReference.VerifyFixed): Value parameters are fixed.
4948 (This.VerifyFixed): Treat 'this' as a value parameter.
4949 * statement.cs (LocalInfo.IsFixed): Remove.
4951 2005-07-01 Martin Baulig <martin@ximian.com>
4953 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
4954 `ec.EmitThis ()' to get the correct scope.
4956 2005-07-01 Martin Baulig <martin@ximian.com>
4958 * ecore.cs (FieldExpr.DoResolve): Don't capture the field if it's
4959 instance is a ParameterReference; fixes #75299.
4961 2005-06-30 Raja R Harinath <rharinath@novell.com>
4964 * expression.cs (Indexers.map): Remove.
4965 (Indexers.Append): Filter out inaccessible setters and getters.
4966 (IndexerAccess.DoResolve, IndexerAccess.DoResolveLValue): Update.
4969 * ecore.cs (MemberExpr.EmitInstance): New. Add CS0120 check.
4971 (FieldExpr.EmitInstance, PropertyExpr.EmitInstance): ... these.
4972 (FieldExpr.Emit, PropertyExpr.Emit): Update.
4973 (FieldExpr.EmitAssign, PropertyExpr.EmitAssign): Update.
4974 * expression.cs (Invocation.EmitCall): Add CS0120 check.
4976 2005-06-30 Marek Safar <marek.safar@seznam.cz>
4979 * class.cs (FieldBase.GetInitializerExpression): One more field
4982 2005-06-28 Miguel de Icaza <miguel@novell.com>
4984 * pending.cs: Do not define a proxy if the base method is virtual,
4985 it will be picked up by the runtime (bug 75270).
4987 2005-07-08 Martin Baulig <martin@ximian.com>
4989 * anonymous.cs (CaptureContext.EmitParameterInstance): Correctly
4990 handle parameters in nested scopes; fixes #74808; see gtest-188.cs.
4992 2005-07-07 Martin Baulig <martin@ximian.com>
4994 * generic.cs (ConstructedType.CheckConstraint): Use
4995 ResolveAsTypeStep(), not ResolveAsTypeTerminal() so we're not
4996 called recursively; fixes #75329.
4998 2005-07-06 Martin Baulig <martin@ximian.com>
5000 * generic.cs (TypeManager.InferTypeArguments): Added support for
5001 anonymous methods; fixes #75461.
5003 2005-07-01 Martin Baulig <martin@ximian.com>
5005 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
5006 `ec.EmitThis ()' to get the correct scope.
5008 2005-07-01 Martin Baulig <martin@ximian.com>
5010 * ecore.cs (FieldExpr.DoResolve): Only capture the field if it's
5011 instance is `This'; fixes #75299.
5013 2005-06-30 Martin Baulig <martin@ximian.com>
5015 * class.cs (Indexer): Implement IIteratorContainer; added support
5016 for iterators in indexers.
5019 (EmitContext.CurrentIterator): Make this a property, not a field.
5021 * anonymous.cs (AnonymousContainer.Iterator): New public property.
5023 2005-06-28 Miguel de Icaza <miguel@novell.com>
5025 * pending.cs: Do not define a proxy if the base method is virtual,
5026 it will be picked up by the runtime (bug 75270).
5028 2005-06-28 Martin Baulig <martin@ximian.com>
5030 * cs-parser.jay (interface_method_declaration): Avoid a
5031 reduce/reduce conflict by moving some of the code into a separate
5032 `interface_method_declaration_body' rule; fixes #75368.
5034 2005-06-28 Martin Baulig <martin@ximian.com>
5036 * typemanager.cs (TypeManager.MemberLookup_FindMembers): Move the
5037 array check after the check for TypeBuilder's.
5039 2005-06-21 Raja R Harinath <rharinath@novell.com>
5041 * convert.cs (FindMostEncompassedType): Add two trivial special
5042 cases (number_of_types == 0 || number_of_types == 1).
5043 (FindMostEncompasingType): Likewise.
5045 2005-06-17 Raja R Harinath <rharinath@novell.com>
5047 Some cleanups preparing for the fix of #75283.
5048 * ecore.cs (PropertyExpr.InstanceResolve): Tighten conditions for
5050 (EventExpr.InstanceResolve): Likewise.
5051 (EventExpr.DoResolve): Remove redundant checks.
5053 2005-06-08 Miguel de Icaza <miguel@novell.com>
5055 * class.cs: Small fix.
5057 2005-06-08 Raja R Harinath <rharinath@novell.com>
5060 * class.cs (GetPartialBases): Fix return value check of
5063 2005-06-07 Raja R Harinath <rharinath@novell.com>
5065 Ensure that partial classes are registered in their enclosing
5066 namespace. Initial part of fix of #75160.
5067 * tree.cs (Tree.RecordDecl): Add new namespace argument.
5068 Register declspace with namespace here, not in
5069 DeclSpace.RecordDecl.
5070 * cs-parser.jay: Pass namespace to RecordDecl.
5071 * class.cs (PartialContainer.Create): Likewise.
5072 (ClassPart.DefineType): New sanity-check. Throws an exception if
5074 * decl.cs (Declspace.RecordDecl): Remove.
5075 * namespace.cs (NamespaceEntry.DefineName): Remove.
5077 2005-06-06 Marek Safar <marek.safar@seznam.cz>
5079 * rootcontext.cs: Reset TargetExt as well.
5081 2005-06-03 Raja R Harinath <rharinath@novell.com>
5083 * ecore.cs (Expression.Resolve): Emit CS0654 error when
5086 2005-06-02 Raja R Harinath <rharinath@novell.com>
5088 Fix #75080, cs0119.cs.
5089 * ecore.cs (Expression.ExprClassToResolveFlags): New. Broken out
5091 (Expression.Resolve): ... this. Use it. Remove bogus code
5092 allowing ExprClass.Type and ExprClass.Namespace for
5093 ResolveFlags.VariableOrValue.
5094 (Expression.Resolve) [1-argument variant]: Change default resolve
5095 flags based on language version.
5096 (Expression.Error_UnexpectedKind): Use a simple string array
5097 rather than an ArrayList.
5098 * expression.cs (TypeOf.DoResolve): Set eclass to ExprClass.Value,
5100 (TypeOfVoid.DoResolve): Likewise.
5101 (MemberAccess.DoResolve) [3-argument variant]: Make private. Drop
5102 flags argument -- it always has the same value.
5104 2005-05-31 Raja R Harinath <rharinath@novell.com>
5107 * ecore.cs (Expression.ResolveLValue): Add a Location parameter.
5108 Use it in the error message.
5109 * assign.cs, expression.cs, statement.cs: Update.
5111 2005-05-30 Raja R Harinath <rharinath@novell.com>
5114 * ecore.cs (Expression.MemberLookupFailed): Add CS0122 check in
5115 the "almostMatchedMember" case too.
5116 * typemanager.cs (Closure.CheckValidFamilyAccess): Add anything
5117 that failed the accessibility checks to 'almost_match'.
5119 2005-05-27 Vladimir Vukicevic <vladimir@pobox.com>
5121 * attribute.cs: Use internal MethodBuilder methods to set
5122 ExactSpelling and SetLastError on PInvoke methods, instead
5123 of passing them via charset. Fixes #75060.
5125 2005-05-27 Raja R Harinath <rharinath@novell.com>
5127 * parameter.cs (Parameter): Remove TODO comment.
5128 (Parameter.DefineParameter): Remove Location parameter.
5129 (Parameters.LabelParameters): Likewise.
5130 * class.cs (Constructor.Emit): Update to change.
5131 (MethodData.Emit): Likewise.
5132 * anonymous.cs (AnonymousMethod.EmitMethod): Likewise.
5133 * delegate.cs (Delegate.Define, Delegate.Emit): Likewise.
5135 2005-05-27 Atsushi Enomoto <atsushi@ximian.com>
5138 Removed Parameters.Location and added Parameter.Location instead.
5139 Removed Location parameter from Emit() and GetSignature().
5146 Modified all related calls.
5148 2005-06-21 Martin Baulig <martin@ximian.com>
5150 * generic.cs (NullCoalescingOperator.Emit): Make this work if the
5151 left-hand side is not a nullable type; fixes #75328.
5153 2005-06-21 Martin Baulig <martin@ximian.com>
5156 (TypeManager.CSharpName): Use GetFullName() instead of `t.FullName'.
5157 (TypeManager.GetFullNameSignature): Likewise.
5159 * convert.cs (Convert.Error_CannotImplicitConversion): Compare
5160 `source.FullName' and `target.FullName' to check whether there are
5161 two conflicting definitions.
5163 2005-06-21 Martin Baulig <martin@ximian.com>
5165 * convert.cs (Convert.ImplicitTypeParameterConversion): Always use
5166 a BoxedCast - also for reference types - to be compatible with csc.
5168 2005-06-21 Martin Baulig <martin@ximian.com>
5170 * expression.cs (MemberAccess.DoResolve): Add support for nested
5171 types in a generic instance; fixes #75320.
5173 2005-06-20 Martin Baulig <martin@ximian.com>
5175 * generic.cs (TypeManager.InferType): Also walk the class
5176 hierarchy for generic instances; fixes #75261.
5178 2005-06-17 Martin Baulig <martin@ximian.com>
5180 * typemanager.cs (TypeManager.IsBuiltinType): Use TypeToCoreType()
5181 to make things work for corlib.
5183 2005-06-15 Martin Baulig <martin@ximian.com>
5185 * attribute.cs (Attribute.CheckSecurityActionValidity): Remove the
5186 obsolete `SecurityAction' values.
5188 2005-06-06 Marek Safar <marek.safar@seznam.cz>
5190 * rootcontext.cs: Reset TargetExt as well.
5192 2005-06-09 Martin Baulig <martin@ximian.com>
5194 * delegate.cs (Delegate.VerifyMethod): Added
5195 `MethodGroupExpr old_mg' argument; inherit its
5196 `HasTypeParameters'; fix #75085.
5198 2005-06-09 Martin Baulig <martin@ximian.com>
5200 * expression.cs (Invocation.OverloadResolve): Correctly handle
5201 generic methods for the SetMemberIsUsed(); fix #75064.
5203 2005-06-09 Martin Baulig <martin@ximian.com>
5205 * statement.cs (Throw.Resolve): Use TypeManager.IsSubclassOf();
5208 2005-06-08 Martin Baulig <martin@ximian.com>
5210 * cs-parser.jay (nullable_type_or_conditional): If we put the
5211 nullable back and our `type' is a `ComposedCast', remove the
5212 nullable from it. Fixes #75156.
5214 * expression.cs (ComposedCast.RemoveNullable): New public method.
5216 2005-06-08 Martin Baulig <martin@ximian.com>
5218 The big Iterators rewrite :-)
5220 * iterators.cs: Rewrite this to use the anonymous methods framework.
5222 * rootcontext.cs (RootContext.DefineTypes): Define Delegates
5223 before the TypeContainers; see 2test-21.cs.
5226 (TypeContainer.DefineType): Don't create a new EmitContext if we
5227 already have one (this only happens if we're an Iterator).
5228 (TypeContainer.Define): Also call Define() on all our iterators.
5229 (Method.CreateEmitContext): Added support for iterators.
5232 (AnonymousContainer): New abstract base class for `AnonymousMethod'.
5233 (AnonymousContainer.CreateMethodHost): Moved here from
5234 AnonymousMethod and made abstract.
5235 (AnonymousContainer.CreateScopeType): New abstract method.
5236 (AnonymousContainer.IsIterator): New public property.
5237 (ScopeInfo.EmitScopeType): Call CreateScopeType() on our Host to
5238 get the ScopeTypeBuilder rather than manually defining it here.
5239 (ScopeInfo.EmitScopeInstance): New public method; correctly handle
5242 * driver.cs (Driver.MainDriver): Call TypeManager.InitCodeHelpers()
5243 before RootContext.DefineTypes().
5245 * codegen.cs (EmitContext.RemapToProxy): Removed.
5246 (EmitContext.CurrentAnonymousMethod): Changed type from
5247 AnonymousMethod -> AnonymousContainer.
5248 (EmitContext.ResolveTopBlock): Protect from being called twice.
5249 (EmitContext.MapVariable, RemapParameter(LValue)): Removed.
5250 (EmitContext.EmitThis): Removed the iterators hacks; use the
5251 anonymous methods framework for that.
5254 (ToplevelBlock.Container): Make this a property, not a field.
5255 (ToplevelBlock.ReParent): New public method; move the
5256 ToplevelBlock into a new container.
5257 (Foreach.TemporaryVariable): Simplify.
5259 2005-06-05 Martin Baulig <martin@ximian.com>
5261 * statement.cs (LocalInfo.CompilerGenerated): New flag.
5262 (Block.AddTemporaryVariable): New public method; creates a new
5263 `LocalInfo' for a temporary variable.
5264 (Block.EmitMeta): Create the LocalBuilders for all the temporary
5266 (Foreach.TemporaryVariable): Use Block.AddTemporaryVariable() for
5267 non-iterator variables.
5269 2005-06-05 Martin Baulig <martin@ximian.com>
5271 * statement.cs (Foreach.TemporaryVariable): Create the
5272 LocalBuilder in the Emit phase and not in Resolve since in some
5273 situations, we don't have an ILGenerator during Resolve; see
5274 2test-19.cs for an example.
5276 2005-06-04 Martin Baulig <martin@ximian.com>
5278 The big Foreach rewrite - Part II.
5280 * typemanager.cs (TypeManager.object_getcurrent_void): Replaced
5281 with `PropertyInfo ienumerator_getcurrent'.
5283 * codegen.cs (VariableStorage): Removed.
5286 (Foreach): Derive from Statement, not ExceptionStatement.
5287 (Foreach.CollectionForeach): New nested class. Moved all the code
5288 dealing with collection foreach here.
5289 (Foreach.ForeachHelperMethods): Removed.
5290 (Foreach.TemporaryVariable): Implement IMemoryLocation.
5292 2005-05-23 Martin Baulig <martin@ximian.com>
5294 * statement.cs (Try.DoResolve): Don't create a `finally' if we
5295 don't need to. Fix #75014.
5297 2005-05-26 Raja R Harinath <rharinath@novell.com>
5299 Improve user-defined conversion handling.
5300 * convert.cs (GetConversionOperators): Rewrite. Return only the
5301 applicable operators.
5302 (AddConversionOperators): New. Helper for GetConversionOperators.
5303 (FindMostEncompassedType, FindMostEncompassingType): Verify that
5304 there is only one most encompassed/encompassing type.
5305 (FindMostSpecificSource, FindMostSpecificTarget): Remove
5306 "applicable operator" handling.
5307 (UserConversion): Move cache here from GetConversionOperators.
5308 Directly cache the chosen operator, rather than the whole
5310 (ExplicitNumericConversion): Fix buggy implementation of Decimal
5311 case. Allow conversion of decimal to sbyte and byte too.
5312 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
5313 New static methods. Used to avoid allocating EmptyExpressions in
5316 2005-05-24 Duncan Mak <duncan@novell.com>
5318 * ecore.cs (CastFromDecimal): New class for casting a decimal to
5319 another class, used in Convert.ExplicitNumericConversion.
5320 (CastToDecimal): New class, similar to above, but casts to
5321 System.Decimal, used in Convert.ImplicitNumericConversion and also
5322 in explicit convesion from double/float to decimal.
5324 * convert.cs (ImplicitNumericConversion): Handle implicit
5325 conversions to System.Decimal.
5326 (ExplicitNumericConversion): handle explicit conversions to
5331 2005-05-20 Miguel de Icaza <miguel@novell.com>
5333 * typemanager.cs: Do not throw an exception in the TypeBuilder
5334 case, we take care of it on the TypeCode.
5336 2005-05-17 Marek Safar <marek.safar@seznam.cz>
5338 * attribute.cs (Attribute.ResolveArguments): GuidAttribute check
5341 * cs-parser.jay: Catch more lexical errors.
5343 * report.cs: Add one more Error method.
5346 * typemanager.cs: Register System.Runtime.InteropServices.GuidAttribute
5348 2005-05-20 Martin Baulig <martin@ximian.com>
5350 * class.cs (TypeContainer.CircularDepException): Removed.
5351 (TypeContainer.DefineType): Removed the `InTransit' stuff.
5352 (TypeContainer.CheckRecursiveDefinition): Check for circular class
5353 (CS0146) and interface (CS0529) dependencies here.
5355 2005-05-20 Martin Baulig <martin@ximian.com>
5357 * expression.cs (New.DoResolve): Move the CS0712 check above the
5358 CS0144 check; otherwise it can never be reached.
5360 2005-05-20 Martin Baulig <martin@ximian.com>
5362 * cs-parser.jay: Fix CS0080 check; add CS0231 and CS0257 from MCS.
5364 2005-05-20 Martin Baulig <martin@ximian.com>
5366 * class.cs (TypeContainer.DefineType): Fix CS0698 check.
5368 * typemanager.cs (TypeManager.IsAttributeType): New public method.
5370 2005-05-19 Martin Baulig <martin@ximian.com>
5373 (ImplicitDelegateCreation.Check): Added `bool check_only' argument
5374 to disable error reporting.
5376 * convert.cs (Convert.ImplicitStandardConversionExists): Use it
5377 here since we don't want to report an error; see the new test-336.cs.
5379 2005-05-19 Raja R Harinath <rharinath@novell.com>
5381 * statement.cs (ToplevelBlock.GetParameterReference)
5382 (ToplevelBlock.IsParameterReference,ToplevelBlock.IsLocalParameter):
5383 Move here from class Block.
5384 * ecore.cs (SimpleName.SimpleNameResolve): Update to changes.
5385 * expression.cs (ParameterReference.DoResolveBase): Likewise.
5387 2005-05-18 Martin Baulig <martin@ximian.com>
5392 (FlowBranching.Reachability): Add non-static public And() and Or()
5394 (FlowBranchingSwitch): New class; do the `break_origins' thing
5395 like in FlowBranchingLoop.
5396 (FlowBranching.UsageVector.MergeBreakOrigins): Also merge the
5397 reachability, not just locals and parameters.
5398 (FlowBranching.MergeChild): Remove some of the hacks for loop and
5399 switch; MergeBreakOrigins() now takes care of that.
5401 2005-05-18 Martin Baulig <martin@ximian.com>
5403 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
5404 a loop and may leave it, reset the barrier; fixes #74974.
5406 2005-05-16 Raja R Harinath <rharinath@novell.com>
5408 Fix test-382.cs. Emit values of decimal constants.
5409 * class.cs (TypeContainer.RegisterFieldForInitialization): New.
5411 (TypeContainer.AddField): ... this.
5412 (TypeContainer.EmitFieldInitializers): Allow the list of fields
5413 with initializers to include 'Const's.
5414 (ClassPart.RegisterFieldForInitialization): Forward to
5416 * const.cs (Const.Const): Pass initializer to base class.
5417 (Const.Define): In case of decimal constants, register them for
5418 initialization in a static constructor.
5420 2005-05-14 Martin Baulig <martin@ximian.com>
5422 * statement.cs (Block.Resolve): Correctly handle unreachable code;
5423 do not call ResolveUnreachable() on unreachable statements in
5424 here, see the comment in the source code.
5426 2005-05-13 Raja R Harinath <rharinath@novell.com>
5429 * expression.cs (BinaryResolveOperator): If one of the operands of
5430 an equality comparison is 'null' and the other is a pointer type,
5431 convert the null to a NullPointer.
5432 * convert.cs (ImplicitReferenceConversion): If the expression is a
5433 NullLiteral and the target type is a pointer type, return a
5434 NullPointer instead.
5435 (ImplicitConversionStandard): Likewise.
5437 2005-05-13 Marek Safar <marek.safar@seznam.cz>
5439 * cs-parser.jay: Set readonly context based on special constructs.
5441 * expression.cs (LocalVariableReference.DoResolveBase): Improved
5442 readonly variable error handling.
5444 * rootcontext.cs (EmitCode): Don't verify members when error
5447 * statement.cs (LocalInfo): Add reaodnly context information.
5448 (SetReadOnlyContext, GetReadOnlyContext): New methods.
5450 2005-05-17 Martin Baulig <martin@ximian.com>
5452 * expression.cs (Argument.Resolve): Turn on flow analysis; fix
5455 2005-05-13 Martin Baulig <martin@ximian.com>
5457 * statement.cs (Block.Resolve, ResolveUnreachable): Correctly
5458 handle unreachable blocks.
5460 2005-05-13 Martin Baulig <martin@ximian.com>
5463 (ConstructorInitializer.GetOverloadedConstructor): Don't crash.
5464 (MethodCore.CheckCore): Use TypeManager.IsEqual(); fix #74904 and
5467 2005-05-13 Martin Baulig <martin@ximian.com>
5469 * statement.cs (Block.Resolve): Make the `bool unresolved' flag an
5470 instance variable, not a local. Fix #74873.
5471 (Block.ResolveUnreachable): Set it to true here.
5473 2005-05-12 Martin Baulig <martin@ximian.com>
5475 * cs-parser.jay (property_declaration): Pass the `current_class',
5476 not the `current_container' to Property's .ctor. Fixes #74912.
5478 2005-05-11 Martin Baulig <martin@ximian.com>
5480 * typemanager.cs (Closure): Copy this from MCS and merge all the
5481 GMCS-specific changes into it.
5483 2005-05-12 Raja R Harinath <harinath@gmail.com>
5486 * typemanager.cs (unmanaged_enclosing_types): New.
5487 (IsUnmanagedType): Avoid infloops by using
5488 'unmanaged_enclosing_types' to talk with recursive invocations.
5490 2005-05-11 Duncan Mak <duncan@novell.com>
5492 * cs-tokenizer.cs (get_cmd_arg): Check that 'c' is not -1 before
5493 continuing to process for 'arg'.
5494 (handle_preprocessing_directive): Check the argument of the #endif
5495 directive and report error CS1025 if there are any trailing
5498 According to the C# spec, having even whitespace after the #endif
5499 directive is illegal; however, because we call arg.TrimEnd ()
5500 beforehand, we have the same behavior as csc, allowing whitespace
5501 after the directive.
5505 2005-05-11 Marek Safar <marek.safar@seznam.cz>
5509 * class.cs (ConstructorInitializer.GetOverloadedConstructor): Removed.
5510 (Constructor.GetObsoleteAttribute): Implemented correctly.
5512 2005-05-10 Martin Baulig <martin@ximian.com>
5514 * generic.cs (Constraints.Resolve): Report CS0246 if we cannot
5515 resolve the type; fixes #74864.
5516 (DefaultValueExpression): Create the LocalTemporary in Emit(), not
5517 in DoResolve(); fixes #74862.
5519 2005-05-10 Martin Baulig <martin@ximian.com>
5521 * support.cs (ReflectionParameters.ParameterModifier): Use
5522 `Parameter.Modifier.REF' if we both have `ParameterAttributes.Out'
5523 and `ParameterAttributes.In'. Fixes #74884.
5525 2005-05-10 Martin Baulig <martin@ximian.com>
5527 * typemanager.cs (TypeManager.MemberLookup_FindMembers): Don't use
5528 the cache if we're just looking for `MemberTypes.NestedType' in a
5531 * ecore.cs (Expression.ResolveAsTypeTerminal): Don't check the
5532 constraints if we're still resolving the type tree.
5533 (Expression.MemberLookup): If we're resolving the type tree, only
5534 look for `MemberTypes.NestedType' since we're only interested in
5537 * class.cs (TypeContainer.DefineType): Don't resolve the type
5538 parameters here; do this later in ResolveType() after the type
5539 tree has been resolved.
5540 (TypeContainer.ResolveType): New public method; this is called
5541 after the type tree is resolved and before the types are being
5542 populated. We resolve the generic constraints here.
5543 (TypeContainer.DoDefineMember): Check the constraints on our base
5544 class and interfaces.
5546 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Make this protected;
5547 set the `ResolvingTypeTree' flag on the EmitContext.
5549 * codegen.cs (EmitContext.ResolvingTypeTree): New public field.
5551 2005-05-10 Marek Safar <marek.safar@seznam.cz>
5553 * class.cs (Method.Define): Catch attempt for Finalizer declaration.
5555 * expression.cs (Argument.GetParameterModifier): Turned to property.
5556 (Invocation.Error_InvalidArguments): Add more descriptive errors.
5558 * parameter.cs (Parameter.GetModifierSignature): Translates modifier to
5561 2005-05-09 Raja R Harinath <rharinath@novell.com>
5564 * decl.cs (MemberCache.AddMethods): Register override methods,
5565 rather than non-override methods.
5566 * typemanager.cs (RegisterOverride): New.
5567 (IsOverride): Update.
5569 2005-05-09 Marek Safar <marek.safar@seznam.cz>
5571 * typemanager.cs (TypeManager): Moved InitGenerics to Reset method.
5573 2005-05-06 Martin Baulig <martin@ximian.com>
5576 (Attributable.IsClsComplianceRequired): Fix typo in the method name.
5577 (AttributeTester.AnalyzeTypeCompliance): Add generics support.
5579 2005-05-09 Marek Safar <marek.safar@seznam.cz>
5583 * ecore.cs (SimpleName.SimpleNameResolve): Add in_transit to catch
5584 recursive declaration.
5586 * statement.cs (Block.ResolveMeta): Report any error in resolving.
5588 2005-05-06 Marek Safar <marek.safar@seznam.cz>
5590 * cfold (DoConstantNumericPromotions): Don't try to convert 0 enum.
5592 * expression.cs (Binary.DoResolve): (x && 0) is always 0.
5594 2005-05-05 Raja R Harinath <rharinath@novell.com>
5597 * decl.cs (DeclSpace.FamilyAccessible):
5598 Use TypeManager.IsNestedFamilyAccessible.
5600 Fix reopened #64812.
5601 * typemanager.cs (Closure.Filter): Introduce checks for 'protected
5604 2005-05-04 Raja R Harinath <rharinath@novell.com>
5605 Abin Thomas <projectmonokochi@rediffmail.com>
5606 Anoob V E <projectmonokochi@rediffmail.com>
5607 Harilal P R <projectmonokochi@rediffmail.com>
5610 * typemanager.cs (Closure.CheckValidFamilyAccess): Don't blindly
5611 allow access to all static members.
5613 2005-05-04 Martin Baulig <martin@ximian.com>
5615 * ecore.cs (FieldExpr.DoResolveLValue): Always call fb.SetAssigned().
5617 2005-05-04 Martin Baulig <martin@ximian.com>
5621 * statement.cs (Switch.SimpleSwitchEmit): Always emit the default
5622 section at the end; make things work if `default' is not the last
5625 2005-05-04 Martin Baulig <martin@ximian.com>
5629 * statement.cs (Switch): Replaced the `got_default' field with a
5630 `default_section' one.
5631 (Switch.CheckSwitch): Set `default_section' here.
5632 (Switch.Resolve): If we're a constant switch and the constant is
5633 not found, use the default section.
5635 2005-05-03 Martin Baulig <martin@ximian.com>
5637 * expression.cs (ArrayAccess.EmitGetLength): New public method.
5639 * statement.cs (Foreach.ArrayForeach): New nested class.
5640 (Foreach.TemporaryVariable): New nested class.
5641 (Foreach.EmitArrayForeach): Removed; this is now in the new
5644 2005-05-03 Raja R Harinath <rharinath@novell.com>
5646 * pending.cs (BaseImplements): Move the #74773 fix here. This is
5648 (VerifyPendingMethods): Revert change below.
5650 * typemanager.cs (IsOverride, RegisterNonOverride): New.
5651 * decl.cs (MemberCache.AddMethod): Register "non-override" methods
5652 that used to trigger warning -28. Remove warning -28.
5653 * expression.cs (Invocation.OverloadResolve): Use
5654 TypeManager.IsOverride to distinguish override methods.
5657 * pending.cs (VerifyPendingMethods): If a base type implements the
5658 requested interface, don't bother checking individual methods of
5659 the base type. As a side-effect, this prevents the creation of
5660 unnecessary proxies.
5662 2005-05-02 Martin Baulig <martin@ximian.com>
5666 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
5667 Also `And' the locals if the old vector is null.
5668 (FlowBranching.UsageVector.BitVector.And): Allow `vector' being
5669 null; in this case we basically reset all the variables.
5671 2005-05-02 Martin Baulig <martin@ximian.com>
5675 * flowanalysis.cs (FlowBranching.UsageVector.MergeBreakOrigins):
5676 Added `FlowBranching branching' argument; always `and' the
5677 variables instead of `or'ing them unless we're an infinite loop.
5679 * statement.cs (While.Resolve): Create a new sibling unless we're
5682 2005-05-02 Martin Baulig <martin@ximian.com>
5686 * class.cs (ConstructorInitializer.Resolve): Added `Block block'
5687 arguments; use it instead of creating a new TopLevelBlock.
5688 (Constructor.Emit): Call `block.ResolveMeta ()' before resolving
5689 our ConstructorInitializer.
5692 (TopLevelBlock.TopLevelBranching): New public property.
5693 (TopLevelBlock.ResolveMeta): New public method; call ResolveMeta()
5694 and create our `TopLevelBranching'.
5696 * codegen.cs (EmitContext.ResolveTopBlock): If we're not an
5697 anonymous method host, use `block.TopLevelBranching' rather than
5698 creating a new branching.
5700 2005-04-20 Miguel de Icaza <miguel@novell.com>
5702 * anonymous.cs (ScopeInfo.AddChild): when adding a new child to
5703 a ScopeInfo, if any of the current children is a child of the new
5704 entry, move those children there.
5706 2005-04-30 Martin Baulig <martin@ximian.com>
5708 * statement.cs (Switch.SimpleSwitchEmit): Reset `default_at_end'
5709 at the beginning of a SwitchSection. Fix #73335.
5711 2005-04-27 Marek Safar <marek.safar@seznam.cz>
5714 * class.cs (EmitFieldInitializers): Use FieldExpr in initializer.
5716 * ecore.cs (FieldExpr): Add a new ctor with in_initializer.
5717 (FieldExpr.DoResolve): Obsolete members are ignored for field
5720 2005-04-26 Marek Safar <marek.safar@seznam.cz>
5722 * attribute.cs (AreOverloadedMethodParamsClsCompliant): Add array
5723 of arrays detection.
5725 * class.cs (Interface.VerifyClsCompliance): Add base interfaces
5727 (Field.VerifyClsCompliance): Volatile fields are not compliant.
5729 * decl.cs (MemberCache.VerifyClsParameterConflict): Add array of
5732 2005-04-25 Ben Maurer <bmaurer@ximian.com>
5734 * cs-parser.jay: Use the prefered version of -unsafe in error
5737 2005-04-22 Marek Safar <marek.safar@seznam.cz>
5739 * driver.cs (CompilerCallableEntryPoint.Invoke): Reset under any
5742 2005-04-20 John Luke <john.luke@gmail.com>
5744 * driver.cs: fix typo in error message, --outout to --output
5746 2005-04-30 Martin Baulig <martin@ximian.com>
5748 * attribute.cs (Attribute.CheckSecurityActionValidity): Correctly
5749 handle the .NET 2.x security attributes.
5751 2005-04-30 Martin Baulig <martin@ximian.com>
5754 (TypeManager.ExpandInterfaces): Don't add things twice.
5757 (TypeContainer.VerifyClsCompliance): Allow generic instances.
5759 2005-04-29 Martin Baulig <martin@ximian.com>
5761 * generic.cs (Constraints.ResolveTypes): Expand interfaces.
5763 * anonymous.cs: Added support for anonymous generic methods.
5765 2005-04-29 Martin Baulig <martin@ximian.com>
5767 * typemanager.cs (TypeManager.GetInterfaces): Correctly handle
5770 2005-04-29 Martin Baulig <martin@ximian.com>
5772 * generic.cs (TypeManager.HasConstructorConstraint): Removed.
5774 * expression.cs (New.DoResolve): Fix the CS0304 check.
5776 2005-04-29 Martin Baulig <martin@ximian.com>
5778 * typemanager.cs (TypeManager.GetFullName): Updated to the new
5781 * class.cs (MethodCore.IsDuplicateImplementation): If we're an
5782 explicit interface implementation, compare the interface types.
5783 (MethodData.Define): Use the new naming scheme from the latest
5785 (MemberBase.DoDefineBase): Resolve `InterfaceType' here.
5787 * decl.cs (MemberName.GetMemberName): Removed.
5788 (MemberName.MethodName, FullName): New properties.
5790 2005-04-25 Raja R Harinath <rharinath@novell.com>
5792 * gmcs.exe.config: Update v2.0.40607 -> v2.0.50215.
5794 2005-04-22 Martin Baulig <martin@ximian.com>
5796 * generic.cs (GenericMethod): Create the EmitContext in the
5797 `Define()'; in `Define(MethodBuilder)', create the type parameters
5798 before calling `Define()'. Fixes #73933.
5800 2005-04-22 Martin Baulig <martin@ximian.com>
5803 (Constraints.Resolve): Make things work wrt. the new type lookup system.
5804 (ConstructedType.ResolveAsTypeTerminal): Don't override this.
5806 * ecore.cs (Expression.ResolveAsTypeTerminal): If `te' is a
5807 ConstructedType, check its constraints.
5809 2005-04-20 Marek Safar <marek.safar@seznam.cz>
5811 * codegen.cs (InRefOutArgumentResolving): New field.
5813 * ecore.cs (FieldExpr.DoResolve): Check for assigning to readonly
5814 fields outside contructor.
5816 * expression.cs (Argument.Resolve): Set InRefOutArgumentResolving.
5818 2005-04-19 Miguel de Icaza <miguel@novell.com>
5820 * anonymous.cs (CaptureContext.EmitParameterInstance): The
5821 parameter code was not completed ever, so it was not as up-to-date
5822 as local variables. Must finish it.
5824 The bug fix was to compare the Toplevel of the block, not the
5825 current block. Thanks for Ben for pointing this out.
5827 2005-04-19 Raja R Harinath <rharinath@novell.com>
5829 * decl.cs (AddMethods): Use the declaring type of the problem
5830 method to determine if we want to squash a warning.
5832 2005-04-19 Marek Safar <marek.safar@seznam.cz>
5834 * attribute.cs: Removed debug output.
5836 * decl.cs (MemberCache.AddMethods): Fixed Finalize ignoring.
5838 * driver.cs (Driver.parse): Synchronize parser ErrorOutput with
5841 2005-04-18 Raja R Harinath <rharinath@novell.com>
5844 * expression.cs (Binary.EqualsNullIsReferenceEquals): New.
5845 (Binary.DoResolveOperator): Use it to avoid blindly optimizing out
5846 all null comparisons against reference types.
5848 2005-04-18 Marek Safar <marek.safar@seznam.cz>
5851 * class.cs (TypeContainer.CircularDepException) New nested
5853 (GetPartialBases, GetNormalBases, GetClassBases): Removed error.
5854 (TypeContainer.DefineType): Removed error, reset InTransit before
5856 (Class.DefineType): Throw exception when is in Transit.
5857 Catch exception and report error.
5858 (Struct.DefineType): Throw exception when is in Transit.
5859 Catch exception and report error.
5860 (Interface.DefineType): Throw exception when is in Transit.
5861 Catch exception and report error.
5863 * codegen.cs: Add InCatch,InFinally to EmitContext to easily
5864 handle nested exception handlers.
5866 * flowanalysis.cs (InTryWithCatch): New method, search for try with
5869 * iterators.cs (Yield.CheckContext): Add CS1626 report. Updated
5870 InFinally and InCatch storage.
5872 * statement.cs (Throw.Resolve): Use InCatch, InFinally from ec.
5873 (Catch.Resolve): Set and Restore ec.InCatch.
5874 (Try.Resolve): Set and Restore ec.InFinally.
5875 (Try.HasCatch): True when try has catch.
5877 2005-04-17 Atsushi Enomoto <atsushi@ximian.com>
5879 * doc.cs : In some cases FilterName returns MonoEvent and MonoField
5880 for the same event member, so exclude such cases from warning 419.
5883 2005-04-16 Miguel de Icaza <miguel@novell.com>
5885 * expression.cs (Binary.ResolveOperator): Apply patch from John
5886 Luke to fix bug 59864: operators &, | and ^ on enumerations
5887 require that the same enum type on both sides.
5889 * driver.cs: Add warnings to old flag usage, this is to assist
5890 people who produce Makefiles and hope that the Makefiles will be
5893 * class.cs (TypeContainer.EmitType): Moved the definition of the
5894 special $PRIVATE$ field from the resolve phase to the Emit phase.
5895 During resolve we do not know if we are a struct with
5896 HasExplicitLayout, we know this only after the attributes for the
5899 Set the FieldOffset to zero on the dummy field that we create for
5900 the class. Fixes 74590.
5902 2005-04-16 Raja R Harinath <rharinath@novell.com>
5905 * ecore.cs (PropertyExpr.resolved): New.
5906 (DoResolve): Use it to handle a case of double resolution here.
5907 Handle a case of identical-name-and-type-name.
5908 * expression.cs (ArrayCreation.CheckIndices): Avoid double
5909 resolution by storing the results of expression resolution back
5910 into the "probes" array.
5912 2005-04-15 Raja R Harinath <rharinath@novell.com>
5914 Fix cs0208-7.cs and cs0208-8.cs.
5915 * typemanager.cs (IsUnmanagedType): Arrays are not allowed
5916 (cf. ECMA standard, behaviour of CSC 1.1 and CSC 2.0). Improve
5917 error reporting to point out the reason a struct is not unmanaged.
5919 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
5921 * doc.cs : In FindDocumentedType(), avoid TypeExpr.ResolveType() and
5922 just use TypeExpr.Type. This fixes bug #74595 when merged to gmcs.
5924 2005-04-13 Raja R Harinath <rharinath@novell.com>
5927 * ecore.cs (PropertyExpr.InstanceResolve): Handle a case of
5928 IdenticalNameAndTypeName here.
5929 (EventExpr.InstanceResolve): Likewise.
5931 2005-04-13 Marek Safar <marek.safar@seznam.cz>
5933 C# 2.0 DefaultCharSetAttribute implementation
5935 * attribute.cs (Attribute.ResolveAsTypeStep): New protected method
5936 which allows us to set GlobalNamespace for every resolve.
5937 (Attribute.ResolveArguments): Cut from Resolve.
5938 (Attribute.GetCharSetValue): Returns CharSet named argument.
5939 (Attribute.DefinePInvokeMethod): Gets default charset from
5941 (GlobalAttribute.ResolveAsTypeStep): Override.
5942 (GlobalAttribute.ResolveArguments): Override.
5944 * class.cs (TypeAttr): Is protected.
5946 * codegen.cs (ModuleClass.DefaultCharSet): New member.
5947 (ModuleClass.DefaultCharSetType): New memeber.
5948 (ModuleClass.ResolveAttributes): Resolves DefaultCharSetAttribute.
5950 * decl.cs (Decl.TypeAttr): New protected virtual. Returns default
5951 charset from module.
5953 * delegate.cs (TypeAttr): Override.
5954 (Delegate.DefineType): Use this TypeAttr.
5956 * driver.cs (Driver.MainDriver): Call Module.ResolveAttributes
5957 at very early stage (before types are defined) to resolve model
5958 module attributes. It will probably not work with corlib but it
5961 * enum.cs (Enum.TypeAttr): New protected virtual. Returns default
5962 charset from module.
5964 * typemanager.cs (default_charset_type): New type.
5966 2005-04-13 Raja R Harinath <rharinath@novell.com>
5968 * decl.cs (MemberCache.AddMethods): Don't warn if
5969 System.Object.Finalize has buggy MethodAttributes.
5971 * typemanager.cs (IsUnmanagedType): Restore !IsValueType check
5974 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
5976 * doc.cs : detect ambiguous reference to overloaded members.
5977 Fixed bug #71603. MS 1.1 csc does not detect it.
5979 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
5981 * doc.cs : delegates must not be referenced with parameters.
5984 2005-04-12 Miguel de Icaza <miguel@novell.com>
5986 * typemanager.cs (IsUnmanagedType): Arrays are allowed.
5988 2005-04-10 Miguel de Icaza <miguel@novell.com>
5990 * driver.cs (MainDriver): Stop processing if the CLS stage found
5993 (CompilerCallableEntryPoint.InvokeCompiler): Always
5994 reset after execution; Take a TextWriter argument for the
5997 * report.cs: Use the error stream instead of hardcoding stderr.
5999 2005-04-09 Miguel de Icaza <miguel@novell.com>
6001 * class.cs: Reduce code paths to test, too small of an
6002 optimization to make it worth the extra testing. Always perform
6005 2005-04-08 Raja R Harinath <rharinath@novell.com>
6008 * class.cs (OperatorArrayList.CheckPairedOperators): Skip
6009 operators that had errors reported on them.
6011 2005-04-08 Marek Safar <marek.safar@seznam.cz>
6013 * attribute.cs (Attribute.IsValidArgumentType): Test valid named
6015 (Attribute.Resolve): Add named argument type checking.
6017 * class.cs (FixedField.Define): Use IsPrimitiveType
6019 * expression.cs (Binary.ResolveOperator): Reflect IsCLRType renaming.
6021 * iterators.cs (Iterator.DefineIterator): Add check for arglist and
6022 unsafe parameter types.
6024 * statement.cs (Using.ResolveExpression): Add better error description.
6026 * typemanager.cs (IsCLRType): Renamed to IsPrimitiveType.
6028 2005-04-08 Raja R Harinath <rharinath@novell.com>
6031 * attribute.cs (Attribute.GetAttributeUsage): Resolve
6032 AttributeUsageAttribute in the emitcontext of the attribute class,
6033 not in the emitcontext of the attributable entity it was attached to.
6034 * cs-parser.jay: Use 'current_class', not 'current_container',
6035 when creating a GlobalAttribute.
6037 2005-04-08 Alp Toker <alp@atoker.com>
6039 * pending.cs: The fix to #58413 failed to compile methods implementing
6040 interfaces with/without params modifiers and vice versa, even though
6041 params modifiers aren't part of the signature. Make the modifier check
6042 less strict as in csc.
6044 2005-04-07 Abin Thomas <projectmonokochi@rediffmail.com>
6045 Anoob V E <projectmonokochi@rediffmail.com>
6046 Harilal P R <projectmonokochi@rediffmail.com>
6049 * pending.cs (TypeAndMethods.mods): New. Store the parameter
6050 modifiers of pending methods.
6051 (PendingImplementation.PendingImplementation): Initialize it.
6052 Add Parameter.Modifier [][] mods and initialize it with ParameterData.
6053 (PendingImplementation.InterFaceMethod): Repalce Type[] argument
6054 with ParameterData. Add check for modifiers.
6055 * class.cs (MethodData.Define): Update to changes.
6057 2005-04-07 Raja R Harinath <rharinath@novell.com>
6059 * ecore.cs (Expression.IsAccessorAccessible): Clarify code somewhat.
6061 2005-04-07 Marek Safar <marek.safar@seznam.cz>
6063 * class.cs (PropertyMethod.Define): Check private accessor in abstract
6066 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't allow RequiredAttribute
6069 * typemanager.cs: Registered RequiredAttributeAttribute.
6071 2005-04-06 Marek Safar <marek.safar@seznam.cz>
6073 * class.cs (VerifyMembers): Doesn't need EmitContext argument.
6074 Warning CS0169 is back at level 3.
6075 (IMethodData.SetMemberIsUsed): New method.
6077 * decl.cs (IsUsed): New value; moved from FieldBase.Status
6078 (SetMemberIsUsed, IsUsed): New methods, encapsulate IsUsed.
6080 * delegate.cs (ResolveMethodGroupExpr): Call SetMemberIsUsed.
6082 * ecore.cs (FieldExpr.ResolveMemberAccess): Call SetMemberIsUsed for
6084 (PropertyExpr.ResolveAccessors): Call SetMemberIsUsed when delegate
6087 * expression.cs (OverloadResolve): Call SetMemberIsUsed. when method
6090 * rootcontext.cs (RootContext.EmitCode): Call VerifyMembers in extra run
6091 to avoid the problems with nested types.
6093 2005-04-05 Abin Thomas <projectmonokochi@rediffmail.com>
6094 Anoob V.E <projectmonokochi@rediffmail.com>
6095 Harilal P.R <projectmonokochi@rediffmail.com>
6096 Raja R Harinath <rharinath@novell.com>
6099 * delegate.cs (Define): Emit ParamArrayAttribute for 'params'
6101 * typemanager (GetConstructor): Make public.
6103 2005-04-05 John Luke <john.luke@gmail.com>
6104 Raja R Harinath <rharinath@novell.com>
6107 * typemanager.cs (IsUnmanagedType): Check non-public fields of a
6108 struct too. Return false quicker in a few cases.
6109 (VerifyUnManaged): Use it.
6111 2005-04-05 Raja R Harinath <rharinath@novell.com>
6114 * statement.cs (Block.Resolve): Initialize 'unreachable' to false,
6115 not 'unreachable_seen'.
6117 2005-04-04 Marek Safar <marek.safar@seznam.cz>
6119 * attribute.cs (Attribute.GetValue): Removed unused.
6121 * codegen.cs (CodeGen.TrimExt): Removed unused.
6123 * cs-parser.jay (output): Removed unused.
6125 * cs-tokenizer.cs (hex_digits): Removed unused.
6127 * enum.cs (MapToInternalType, GetEnumeratorName): Removed unused.
6129 * expression.cs (Indirection.LoadExprValue): Removed unused.
6130 (ArrayCreation.ExpressionToArrayArgument): Removed unused.
6132 * iterators.cs (Iterator.param_types): Removed unused.
6134 * statement.cs (Goto.block): Removed unused.
6135 (ToplevelBlock.did): Removed unused.
6136 (Switch.ResolveConstantSwitch): Removed unused.
6138 2005-04-01 Ben Maurer <bmaurer@ximian.com>
6140 * rootcontext.cs: Allow mcs to bootstrap with the compilation
6143 2005-04-19 Martin Baulig <martin@ximian.com>
6145 Merged r42462 from MCS and made it work for GMCS.
6147 * class.cs (MethodCore.ds): Moved this field to `MemberBase'.
6149 * generic.cs (GenericMethod.Define): Removed `return_type' argument.
6151 2005-04-01 Raja R Harinath <rharinath@novell.com>
6153 Fix #74232 and cs0208-3.cs.
6154 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0208 check.
6155 * typemanager.cs (IsUnmanagedType): Don't allow 'object' as an
6156 unmanaged type. Don't use FieldBuilders when 't' is a
6157 TypeBuilder. Use ModFlags and MemberType fields.
6158 * class.cs (MemberBase.member_type): Rename from MemberType.
6159 (MemberBase.MemberType): New property. Determines member_type on
6161 (MemberBase.DoDefine): Don't initialize MemberType here.
6162 (FieldMember.Define): Likewise.
6164 2005-04-01 Marek Safar <marek.safar@seznam.cz>
6167 * class.cs (Event.Emit): Call Add/Remove emit even for interfaces.
6168 Attributes are emitted there.
6170 2005-04-01 Raja R Harinath <rharinath@novell.com>
6172 * cs-tokenizer.cs (consume_identifier): Treat 'partial' as a
6173 keyword in 'partial enum' too.
6174 * cs-parser.jay (enum_declaration): Add CS0267 check ('partial enum'
6176 Report from Kamil Skalski <nazgul@omega.pl>.
6179 * rootcontext.cs (ResolveTree): The 'root.Interfaces' list can
6180 have partial containers too.
6182 * ecore.cs (SimpleName.SimpleNameResolve): Move 'invariant meaning
6183 in block' checks to Block.CheckInvariantMeaningInBlock.
6184 * statement.cs (Block.GetKnownVariableInfo): Make private.
6185 (Block.IsVariableUsedInChildBlock): Remove.
6186 (Block.IsVariableUsedInBlock): Likewise.
6187 (Block.CheckInvariantMeaningInBlock): New. Show location of
6188 conflicting declaration.
6189 (Block.AddVariable): Make error messages less long-winded and more
6190 specific. Show location of conflicting declaration.
6191 * parameter.cs (Parameters.Location): New readonly property.
6193 2005-03-31 Raja R Harinath <rharinath@novell.com>
6195 Clean up semantics of invoking ResolveMemberAccess.
6196 * ecore.cs (SimpleName.DoSimpleNameResolve): If a MemberExpression
6197 can have an instance, ensure that we pass in a non-TypeExpression
6198 to ResolveMemberAccess. Tighten up IdenticalNameAndTypeName checks.
6199 (MemberExpr.DoSimpleNameResolve): Remove type_is_inferred
6200 argument. Update to changes and simplify.
6201 (FieldExpr.Emitinstance): Remove CS0120 check.
6202 (PropertyExpr.EmitInstance): Likewise.
6203 * expression.cs (Argument.Resolve): Likewise.
6204 (Invocation.DoResolve): Update to changes in semantics of
6207 2005-03-31 Marek Safar <marek.safar@seznam.cz>
6210 * class.cs (AbstractPropertyEventMethod.EmitMethod): Enable emit method
6213 * decl.cs (MemberCache.AddMethods): Fix infinite loop.
6215 2005-03-31 Raja R Harinath <rharinath@novell.com>
6217 Fix difference in behaviour with commandline invocation.
6218 * driver.cs (Driver.Reset): New.
6219 (CompilerCallableEntryPoint): Call it.
6221 * statement.cs (If.Resolve): Avoid spurious "uninitialized
6222 variable" warnings if the boolean expression failed to resolve.
6224 2005-03-30 Sebastien Pouliot <sebastien@ximian.com>
6226 * attribute.cs: Fix the union of several permissions when some of them
6227 are unrestricted (so the result isn't an unrestricted permission set).
6230 2005-03-30 Raja R Harinath <rharinath@novell.com>
6232 * ecore.cs (MemberExpr): New class. Convert from interface
6234 (MemberExpr.ResolveMemberAccess): Refactor and move here from
6235 MemberAccess.ResolveMemberAccess. Tighten up pre-conditions and
6237 (MethodGroupExpr, FieldExpr, PropertyExpr, EventExpr): Update.
6238 (MethodGroupExpr.IsExplicitImpl): Remove.
6239 (Expression.GetFieldFromEvent): Remove.
6240 (SimpleName.MemberStaticCheck): Remove.
6241 (SimpleName.DoSimpleNameResolve): Update to changes.
6242 * expression.cs (MemberAccess.ResolveMemberAccess): Refactor.
6243 (MemberAccess.IdenticalNameAndTypeName): Remove.
6244 (MemberAccess.error176): Move to MemberExpr.
6245 (MemberAccess.DoResolve): Update to changes.
6246 (BaseAccess.DoResolve): Likewise.
6248 2005-03-30 Marek Safar <marek.safar@seznam.cz>
6250 C# 2.0 Conditional attribute class implementation
6252 * attribute.cs (AttributeTester.IsAttributeExcluded): New method.
6253 Analyzes class whether it has attribute which has ConditionalAttribute
6254 and its condition is not defined.
6256 * class.cs (Class.ApplyAttributeBuilder): Add IsAttributeExcluded check.
6257 (Class.IsExcluded): New method. Search for at least one defined
6258 condition in ConditionalAttribute of attribute class.
6260 2005-03-30 Raja R Harinath <rharinath@novell.com>
6262 * ecore.cs (PropertyExpr): Derive from Expression, not
6263 ExpressionStatement.
6264 (PropertyExpr.EmitStatement): Remove.
6266 2005-03-29 Raja R Harinath <rharinath@novell.com>
6269 * expression.cs (MemberAccess.ResolveMemberAccess): Allow the
6270 internal field "value__" of an enum be private. The examples for
6271 "value__" that I found on MSDN all used FieldAttributes.Private.
6273 * decl.cs (MemberCache.AddMethods): Use C# terminology in warning.
6274 Don't mention IL method attribute names.
6276 Fix #47991. Remove a TODO.
6277 * statement.cs (Block.Toplevel): Make into a field.
6278 (Block.Parameters): Move into ToplevelBlock.
6279 (Block.known_variables): Rename from child_variable_names.
6280 (Block.Block): Remove variants that take Parameters. Initialize
6281 'Toplevel' with the immediately surrounding toplevel block.
6282 (Block.AddKnownVariable): Rename from AddChildVariableName. Add a
6283 LocalInfo parameter.
6284 (Block.GetKnownVariableInfo): New.
6285 (Block.IsVariableNameUsedInChildBlock): Update.
6286 (Block.IsVariableNameUsedInBlock): New. Checks if a name is used in
6287 the block, even though it may not be in scope.
6288 (Block.AddVariable): Remove Parameters parameter. Use
6289 Toplevel.Parameters instead.
6290 (Block.AddConstant): Remove Parameters parameter.
6291 (Block.GetParameterReference): Update to use Toplevel.Parameters.
6292 (Block.IsParamaterReference): Likewise.
6293 (Block.IsLocalParameter): Likewise. Simplify a lot.
6294 (ToplevelBlock.Parameters): New. Moved from Block.
6295 (ToplevelBlock.ToplevelBlock): Update to changes. Always
6296 initialize Parameters to a non-null value.
6297 * cs-parser.jay: Update to changes.
6298 * ecore.cs (SimpleName.SimpleNameResolve): Emit cs0136 error for
6299 simple names that mean different things in the same block. Use
6300 Block.IsVariableNameUsedInBlock.
6302 2005-03-28 Raja R Harinath <rharinath@novell.com>
6304 * enum.cs (Enum.LookupEnumValue): Remove debugging code.
6306 2005-03-26 Raja R Harinath <harinath@acm.org>
6309 * assign.cs (Assign.DoResolve): When the RHS of an assignment
6310 fails to resolve, ensure that the LHS is still resolved as an
6313 2005-03-25 Raja R Harinath <harinath@acm.org>
6315 * enum.cs (Enum.DefineType): Set ec.InEnumContext and
6317 (Enum.current_ec): Remove.
6318 (Enum.LookupEnumValue): Remove EmitContext argument.
6319 Just uses the one created during DefineType.
6320 (Enum.FindMembers): Update.
6321 * expression.cs (MemberAccess.DoResolve): Update.
6323 2005-03-22 Marek Safar <marek.safar@seznam.cz>
6325 * assign.cs (Assign.DoResolve): Check for CS1717 when
6326 source and target are same (uses Equals).
6328 * expression.cs (LocalVariableReference, ParameterReference,
6329 This): Implemented Equals, GetHashCode.
6331 * statement.cs (Block.GetParameterReference): Removed useless
6334 2005-03-22 Raja R Harinath <rharinath@novell.com>
6337 * statement.cs (Block.AddVariable): Ensure that we skip implicit
6338 blocks before deciding whether the error is cs0136 or cs0128.
6340 * cs-parser.jay: Pass MemberName to RootContext.Tree.RecordDecl.
6341 (using_alias_directive, using_namespace_directive): Pass
6342 MemberName, not an expression to Namespace.UsingAlias and
6344 (MakeName): Use the MemberName of the namespace.
6345 * namespace.cs (Namespace.MemberName): New.
6346 (UsingEntry.UsingEntry): Take a MemberName, not an expression.
6347 (AliasEntry.AliasEntry, Namespace.Using, Namespace.UsingAlias):
6349 * decl.cs (MemberName.Name): Make readonly.
6350 (MemberName.FromDotted): New "constructor".
6351 (MemberName.Equals, MemberName.GetHashCode): Implement overrides.
6352 (MemberCore.Name): Compute from MemberName on demand.
6353 (MemberCore.SetMemberName): Provide a way to change the
6355 (MemberCore.AddToContainer): Don't take a fullname parameter.
6356 * class.cs (TypeContainer.AddToMemberContainer): Don't add the
6357 fully qualified name of the container to the member name.
6358 (TypeContainer.AddToTypeContainer): Use a fully qualified name
6359 only if the type is a member of the root container.
6360 (TypeContainer.AddMethod, TypeContainer.AddProperty): Use
6361 MemberName.Left rather than searching for an embedded ".".
6362 (PartialContainer.CreatePart): Update to changes in RootContext.
6363 (MemberBase.ShortName): Turn into a property. Use
6364 MemberCore.SetMemberName.
6365 (MemberBase.ExplicitInterfaceName): Remove.
6366 (MemberBase.UpdateMemberName): Remove.
6367 (AbstractPropertyEventMethod.UpdateName): Use SetMemberName.
6368 (PropertyBase.SetMemberName): New override.
6369 * tree.cs (Tree.RecordDecl): Take a MemberName and use it as hash key.
6370 (Tree.GetDecl): New.
6371 (Tree.AllDecls): Rename from Decls.
6372 * attribute.cs, enum.cs, report.cs: Update to changes.
6373 * driver.cs (MainDriver): Use MemberName.FromDotted on
6374 RootContext.MainClass.
6376 2005-03-21 Marek Safar <marek.safar@seznam.cz>
6378 * class.cs (FixedField.Define): Check for CS1664 and more sanity
6381 * expression.cs (ElementAccess.DoResolveLValue): Check for CS1708.
6383 2005-03-18 Marek Safar <marek.safar@seznam.cz>
6385 * modifiers.cs (Modifiers.PROPERTY_CUSTOM): New constant for
6386 property accessor modifiers.
6388 * class.cs (FieldMember.ApplyAttributeBuilder): Don't allow apply
6389 fixed buffer attribute (CS1716).
6390 (PropertyMethod.HasCustomAccessModifier): When property accessor
6391 has custom modifier.
6393 * ecore (PropertyExpr.DoResolve): Add CS0271 for custom accessor
6395 (PropertyExpr.DoResolveLValue): Add CS0272.
6397 2005-03-17 Miguel de Icaza <miguel@novell.com>
6399 * convert.cs: When converting to a pointer, use the proper Conv.U
6400 or Conv.I depending on the source data type.
6402 * cs-tokenizer.cs: Make the size for large decimal constants,
6405 2005-03-17 Martin Baulig <martin@ximian.com>
6407 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
6408 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
6410 2005-03-17 Martin Baulig <martin@ximian.com>
6412 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
6413 to bool so we can return an error condition.
6414 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
6417 2005-03-16 Zoltan Varga <vargaz@freemail.hu>
6419 * attribute.cs: Encode ThrowOnUnmappableChar and BestFitMapping
6422 2005-03-16 Raja R Harinath <rharinath@novell.com>
6424 Remove TypeManager.LookupType and TypeManager.LookupTypeDirect.
6425 Refactor to avoid traversing the list of assemblies, and to avoid
6426 string concatenation.
6427 * typemanager.cs (guid_attr_type): Remove.
6428 (negative_hits, pointers, references): Remove hashes.
6430 (GetConstructedType): New. Uses type_hash to handle constructed
6431 types (arrays, references, pointers).
6432 (GetReferenceType, GetPointerType): Use it.
6433 (GetNestedType): New. Uses type_hash to handle nested types of
6435 (LookupType, LookupTypeDirect): Remove.
6436 (CoreLookupType): Inline parts of old LookupTypeDirect code. Use
6437 'types' hash and LookupTypeReflection directly.
6438 (params_string, params_object): Use GetConstructedType.
6439 * namespace.cs (Namespace.cached_types): New. Cache of reflected
6441 (Namespace.Lookup): Use cached_types.
6442 (NamespaceEntry.LookupNamespaceOrType): Inline the functionality
6443 provided by old TypeManager.LookupType.
6444 * rootcontext.cs (MakeFQN): Remove.
6445 * decl.cs (DeclSpace.MakeFQN): Likewise.
6446 (DeclSpace.LookupType): Use TypeManager.GetNestedType.
6447 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
6448 TypeManager.GetConstructedType.
6449 * tree.cs (decl_ns_hash, LookupByNamespace): Remove.
6451 2005-04-16 Zoltan Varga <vargaz@freemail.hu>
6453 * cs-parser.jay: Fix build.
6455 2005-03-15 Marek Safar <marek.safar@seznam.cz>
6457 * class.cs (TypeContainer.CircularDepException) New nested
6458 (MethodCore.CheckBase): Report CS1715 for properties and indexers.
6460 * cs-parser.jay: Reports CS1527 for any namespace element.
6462 * delegate.cs (DelegateCreation.Error_NoMatchingMethodForDelegate):
6465 * expression.cs (ParameterReference.IsAssigned): Changed error to
6467 (Error_WrongNumArguments): Moved CS0245 detection here.
6469 * statement.cs (Return.Resolve): Add CS1622 report.
6471 2005-03-11 Marek Safar <marek.safar@seznam.cz>
6473 * class.cs (StaticClass.DefineContainerMembers): Added CS0720.
6475 2005-03-11 Zoltan Varga <vargaz@freemail.hu>
6477 * attribute.cs expression.cs: Get rid of some allocations.
6479 2004-03-11 Atsushi Enomoto <atsushi@ximian.com>
6481 * doc.cs : just eliminate the latest change.
6483 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
6485 * doc.cs : commented out the latest change. It breaks xml-030.cs
6487 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
6489 * doc.cs : When TypeBuilder did not create Type yet, GetEvents() will
6490 fail. So invoke CreateType() in FindDocumentedType().
6492 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
6494 * cs-tokenizer.cs : added IsKeyword().
6495 * doc.cs : Detect keyword incorrectly used as identifier.
6496 Allow identifiers prefixed by @.
6498 2005-03-10 Marek Safar <marek.safar@seznam.cz>
6500 * attributes.cs (Attributes.Emit): Continue after CheckTargets.
6501 It caused exception in namespace resolving (again!).
6503 * class.cs (Class.ctor): Removed exit.
6504 (PropertyMethod.ctor): ditto.
6506 * codegen.cs (Codegen.Reset): Reset static data.
6507 (Codegen.ResolveTopBlock): Forward error status from ResolveMeta.
6509 * cs-tokenizer.cs (Cleanup): Removed.
6511 * driver.cs (GetSystemDir): Rewrote to one line command.
6512 It caused problem with unloaded dynamic modules.
6513 (UnixParseOption): Removed Exit.
6514 (CompilerCallableEntryPoint.InvokeCompiler): Make static.
6515 (CompilerCallableEntryPoint.Reset): Reset suitable static data.
6516 Now can be mcs used as library.
6518 * ecore.cs (Expression.ResolveBoolean): Use Location.Null for
6521 * location.cs (Reset): Reset static data.
6523 * namespace.cs (Reset): Reset static data.
6525 * report.cs (Report.Reset): Reset static data.
6527 * rootcontext.cs (RootContext.Reset): Reset static data.
6529 * tree.cs (RootTypes.ctor): Use Location.Null
6531 * typemanager.cs (TypeManager.Reset): Reset static data.
6532 (CoreLookupType): Removed Exit.
6533 (TypeHandle.Reset): Reset static data.
6535 2005-03-10 Raja R Harinath <rharinath@novell.com>
6538 * typemanager.cs (ComputeNamespaces): Import namespaces from
6539 referenced modules too.
6541 2005-03-09 Raja R Harinath <rharinath@novell.com>
6543 * class.cs (TypeContainer.AddToMemberContainer): Use "." rather
6546 2005-03-09 Raja R Harinath <rharinath@novell.com>
6548 * decl.cs (DeclSpace.LookupType): Don't loop but recurse into
6549 enclosing DeclSpace. This ensures that a name-lookup populates
6550 more caches and there are fewer 'TypeExpression's. Carve out
6551 nested type lookup into ...
6552 (LookupNestedTypeInHierarchy): ... this.
6554 2005-04-15 Martin Baulig <martin@ximian.com>
6556 Merged r41590 from MCS and make it work in the generics land.
6558 * generic.cs (TypeParameter.UpdateConstraints): Removed the
6561 * class.cs (PartialContainer.UpdateConstraints): Removed.
6562 (PartialContainer.CheckConstraints): Removed.
6563 (PartialContainer.SetParameterInfo): Store the constraints here.
6564 (PartialContainer.DefineTypeParameters): New public method;
6565 resolve the type parameter's constraints here. Note that the
6566 PartialContainer doesn't have an EmitContext anymore, so we must
6567 do this in the ClassPart.
6569 2005-03-09 Raja R Harinath <rharinath@novell.com>
6571 Clean up a few partial-class semantics.
6572 Fixes test-357.cs and cs1618-2.cs.
6573 * cs-parser.jay (struct_declaration): Use 'current_class' as
6574 parent of newly-created struct. Remove call to Register ().
6575 Use 'pop_current_class' to complete handing the current struct.
6576 (interface_declaration): Likewise.
6577 (class_declaration): Likewise.
6578 (enum_declaration): Use 'current_class' as parent of newly created
6580 (delegate_declaration): Likewise.
6581 (pop_current_class): New function. This is used to handle closing
6582 up the 'current_class' and 'current_container', and pointing them
6583 to the enclosing class/container.
6584 (CSharpParser): Initialize 'current_class' too.
6585 * decl.cs (MemberCore): Add check for invariant: a partial
6586 container is not a parsed entity, and thus does not enclose any
6588 (DeclSpace.TypeResolveEmitContext): Expose 'type_resolve_ec'.
6589 (DeclSpace.BaseTypeExpr): Use it.
6590 (DeclSpace.LookupType): Add check for invariant.
6591 * class.cs (TypeContainer): Add check for invariant: a nested
6592 class should have the same NamespaceEntry as its enclosing class.
6593 (TypeContainer.EmitFieldInitializers): Make virtual.
6594 (TypeContainer.DefineDefaultConstructor): Adhere to invariant in
6596 (TypeContainer.Register): Remove.
6597 (TypeContainer.DefineType): Set the 'ec' of a PartialContainer to
6598 null. Use TypeResolveEmitContext for resolving base types and
6599 interfaces. Move initialization of Parts.TypeBuilder here from
6601 (TypeContainer.DefineNestedTypes): ... here.
6602 (PartialContainer): Take a Namespace not a NamespaceEntry.
6603 (PartialContainer.Create): Don't use Register. Call the
6604 appropriate Add... function directly.
6605 (ClassPart): Take both the PartialContainer and the enclosing
6606 class as constructor arguments.
6607 (ClassPart.EmitFieldInitializers): Override.
6608 (ClassPart.PartFindNestedTypes): Remove.
6609 (FieldBase.GetInitializerExpression): Resolve the initializer
6610 expression in the emit context of the enclosing class.
6611 * tree.cs (RootTypes): Remove Register ().
6613 2005-03-08 Marek Safar <marek.safar@seznam.cz>
6615 * cs-parser.jay: Removed CS0134.
6617 * driver.cs: Removed CS1901.
6619 * expression.cs (SizeOf.DoResolve): Don't report CS0233
6620 for predefined types.
6622 2005-03-07 Duncan Mak <duncan@novell.com>
6624 * codegen.cs (Save): Catch UnauthorizedAccessException as
6625 well. Fixes bug #73454.
6627 2005-03-07 Marek Safar <marek.safar@seznam.cz>
6629 * cs-tokenizer.cs (xtoken): Add CS1035.
6631 * class.cs (MethodData.Define): Add CS0683.
6632 (FieldMember.ctor): Add CS0681.
6634 2005-03-07 Raja R Harinath <rharinath@novell.com>
6636 * ecore.cs (SimpleName.DoResolve): Rename from
6637 SimpleName.DoResolveAllowStatic.
6638 (SimpleName.DoSimpleNameResolve): Remove 'allow_static' argument.
6639 Pass 'intermediate' flag to MemberStaticCheck.
6640 (SimpleName.MemberStaticCheck): Skip "static check" only in case
6641 of "intermediate" lookups via MemberAccess.
6642 (SimpleName.IdenticalNameAndTypeName): New. Carved out of ...
6643 * expression.cs (MemberAccess.IdenticalNameAndTypeName): ... this.
6645 2005-03-07 Raja R Harinath <rharinath@novell.com>
6648 * ecore.cs (FieldExpr.EmitInstance): Catch cases of CS0120 that
6649 slipped in because of variable names that are identical to a
6650 builtin type's BCL equivalent ('string String;', 'int Int32;').
6651 (PropertyExpr.EmitInstance): Likewise.
6653 2005-03-04 Marek Safar <marek.safar@seznam.cz>
6655 * cs-tokenizer.cs (PreProcessPragma): Add warning 1633, 1635.
6657 * report.cs (warning_ignore_table): Made public.
6659 2005-03-04 Raja R Harinath <rharinath@novell.com>
6662 * class.cs (MethodData.Emit): Pass 'container' to
6663 container.GetObsoleteAttribute instead of 'container.Parent'.
6665 2005-03-03 Marek Safar <marek.safar@seznam.cz>
6667 * cs-parser.jay: Add 1534 error test.
6669 * iterators.cs (Yield.CheckContext): Add error 1629.
6670 (Iterator.ctor): Save unsafe modifier.
6671 (MoveNextMethod.DoEmit): Restore unsafe context.
6673 * namespace.cs (UsingAlias): Better error message.
6675 2005-03-03 Dan Winship <danw@novell.com>
6677 * convert.cs (Error_CannotImplicitConversion): fix two bugs in
6678 the warning message [#73219]
6680 2005-03-03 Raja R Harinath <rharinath@novell.com>
6682 Fix compile with MCS 1.0.0.0.
6683 * cs-tokenizer.cs (PreProcessPragma): Simplify w_disable and
6684 w_restore to not depend on string constant folding.
6686 2005-03-03 Raja R Harinath <rharinath@novell.com>
6688 * decl.cs (DeclSpace.LookupType): Remove 'silent' argument. Move
6689 CS0246 check to users who passed 'silent = false'.
6690 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): Add CS0246
6692 (SimpleName.SimpleNameResolve): Update.
6693 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0246 check.
6694 (MemberAccess.IdenticalNameAndTypeName): Update.
6695 * doc.cs (FindDocumentedTypeNonArray): Update.
6697 2005-03-03 Raja R Harinath <rharinath@novell.com>
6699 * codegen.cs (EmitContext): Remove ResolvingTypeTree.
6700 * parameters.cs (ComputeAndDefineParameters): Remove.
6701 * decl.cs (ResolveBaseTypeExpr): Don't set ResolvingTypeTree.
6702 * delegate.cs (Define): Don't invoke ComputeAndDefineParameters.
6703 Use GetParameterInfo.
6705 2005-03-02 Marek Safar <marek.safar@seznam.cz>
6707 * report.cs (StaticClass.DefineContainerMembers): Add warning 628.
6709 2005-03-02 Raja R Harinath <rharinath@novell.com>
6711 Unify DeclSpace.LookupType and DeclSpace.FindType.
6712 * decl.cs (DeclSpace.FindNestedType): New virtual function. This
6713 is in charge of defining nested types on demand.
6714 (DeclSpace.LookupType): Use it when the current_type is a
6715 TypeBuilder. Use LookupTypeDirect for reflected types.
6716 (DeclSpace.FindType): Remove.
6717 (DeclSpace.LookupInterfaceOrClass): Likewise.
6718 (DeclSpace.DefineTypeAndParents): Likewise.
6719 * ecore.cs (SimpleName.ResolveAsTypeStep): Just call
6720 DeclSpace.LookupType.
6721 * doc.cs (FindDocumentedTypeNonArray): Use DeclSpace.LookupType.
6722 * typemanager.cs (LookupType): Simplify.
6723 (AddUserType): Remove type from negative_hits.
6724 * namespace.cs (Namespace.Lookup): Use TypeManager.LookupTypeDirect.
6725 * class.cs (TypeContainer.FindMembers): Move handling of nested
6727 (TypeContainer.FindMembers_NestedTypes): ... here.
6728 (TypeContainer.FindNestedType): Implement override.
6729 (ClassPart.FindNestedType): Delegate to PartialContainer.
6730 (ClassPart.PartFindNestedType): Looks up the nested types of the
6733 2005-04-14 Martin Baulig <martin@ximian.com>
6735 * generic.cs (ConstructedType): Moved all the type lookup and
6736 nested class logic into SimpleName.
6737 (ConstructedType.ResolveConstructedType): Our underlying type is
6738 already fully resolved; all the type lookup stuff is in
6741 * ecore.cs (SimpleName.ResolveAsTypeStep): Resolve nested
6742 constructed types here instead of in ConstructedType.
6744 * decl.cs (MemberName.GetTypeExpression): Always create a
6745 SimpleName, not a ConstructedType.
6746 (DeclSpace.ResolveNestedType): Removed; this is now in SimpleName.
6748 2005-03-02 Martin Baulig <martin@ximian.com>
6750 * class.cs (TypeContainer.DoDefineMembers): We also need a default
6751 static constructor in static classes.
6753 2005-03-01 Zoltan Varga <vargaz@freemail.hu>
6755 * attribute.cs: Pass -1 to DefineLPArrayInternal if sizeConst or
6756 sizeParamIndex is not specified.
6758 2005-03-01 Marek Safar <marek.safar@seznam.cz>
6761 * report.cs (WarningMessage.IsEnabled): Missing null check.
6763 2005-02-28 Marek Safar <marek.safar@seznam.cz>
6765 * attribute.cs (DefinePInvokeMethod): Fix, all data are stored
6766 in the fields and not in the properties.
6768 2005-02-28 Zoltan Varga <vargaz@freemail.hu>
6770 * attribute.cs (GetMarshal): Marshal SizeConst and SizeParamIndex
6773 2005-02-28 Marek Safar <marek.safar@seznam.cz>
6775 * attribute.cs: Small refactoring (improved robustness).
6776 (ImplOptions, UnmanagedType, UsageAttribute): Removed members.
6777 (ValidateGuid): Removed.
6778 (Resolve): Removed referenced to above mentioned.
6779 (GetAttributeUsage): Made private and changed to work without
6781 (GetIndexerAttributeValue): Don't crash.
6782 (GetConditionalAttributeValue): Ditto.
6783 (GetClsCompliantAttributeValue): Ditto.
6784 (ExtractSecurityPermissionSet): All attributes exceptions are
6786 (GetPropertyValue): New helper.
6787 (GetMethodImplOptions): New method.
6788 (DefinePInvokeMethod): Reuse common code. Implemented handling of
6789 some missing properties.
6791 * class.cs (ClassOrStruct.ApplyAttributeBuilder): Updated.
6792 (Method.ApplyAttributeBuilder): Updated.
6794 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't catch shared
6797 2005-02-28 Raja R Harinath <rharinath@novell.com>
6800 * report.cs (Report.SymbolRelatedToPreviousError): Handle
6801 non-simple types (array, pointer, reference).
6803 2005-02-28 Marek Safar <marek.safar@seznam.cz>
6805 * cs-parser.jay: Add errors 1617, 650, 1007, 531, 547, 548
6807 * class.cs (MethodCore.IsDuplicateImplementation): Special error
6809 (Method.CheckBase): Catch wrong destructor here.
6810 (MethodData.Define): Add errors 550, 668.
6812 * cs-tokenizer.cs (PreProcessPragma): Add warning 1634.
6814 * ecore.cs (PropertyExpr.DoResolveLValue): Fixed wrong error code.
6816 * pending.cs (VerifyPendingMethods): Add error 551.
6818 * typemanager.cs (CSharpName): Next error report helper.
6820 2005-02-25 Marek Safar <marek.safar@seznam.cz>
6822 * attribute.cs (Atttribute.Resolve): Add cache for parameter-less
6823 attributes. Removed useless attribute double check.
6824 It saves almost 2MBs for corlib.
6826 2005-02-25 Raja R Harinath <rharinath@novell.com>
6829 * statement.cs (ExpressionStatement.Resolve): Make robust to being
6830 called twice in case of error.
6832 2005-02-23 Chris Toshok <toshok@ximian.com>
6834 Fix compiler portions of #72827.
6835 * statement.cs (Block.Emit): call Begin/EndScope on the
6836 EmitContext instead of the ILGenerator.
6838 * codegen.cs (EmitContext.BeginScope): new method, call
6839 ILGenerator.BeginScope as well as the SymbolWriter's OpenScope (if
6841 (EmitContext.BeginScope): same, but EndScope and CloseScope
6843 * symbolwriter.cs (SymbolWriter.OpenScope): get the current il
6844 offset and call the superclass's OpenScope(int) with it.
6845 (SymbolWriter.CloseScope): get the current il
6846 offset and call superclass's CloseScope(int) with it.
6848 2005-02-23 Marek Safar <marek.safar@seznam.cz>
6850 * anonymous.cs (AnonymousMethod.Compatible): Fixed to report
6851 CS1677 for out and ref as well.
6853 * class.cs (Method.Define): Add error CS1599 detection.
6855 * cs-parser.jay: Add CS1609, CS1670, CS1627 detection.
6857 * cs-tokenizer.cs (xtoken): Add error CS1646 detection.
6859 * delegate.cs (Delegate.Define): Add error CS1599 detection.
6861 * support.cs.cs (ModifierDesc): New helper method.
6863 2005-02-23 Raja R Harinath <rharinath@novell.com>
6864 Abin Thomas <projectmonokochi@rediffmail.com>
6865 Anoob V E <projectmonokochi@rediffmail.com>
6866 Harilal P R <projectmonokochi@rediffmail.com>
6869 * class.cs (ConstructorBuilder.Resolve): Make sure that the second
6870 MemberLookup (used for error reporting) actually returns a result.
6871 Fix error report number (122, not 112).
6873 2005-02-22 Abin Thomas <projectmonokochi@rediffmail.com>
6874 Anoob V E <projectmonokochi@rediffmail.com>
6875 Harilal P R <projectmonokochi@rediffmail.com>
6878 * pending.cs (PendingImplementation.GetAbstractMethods):
6879 Find NonPublic members too.
6881 2005-02-22 Marek Safar <marek.safar@seznam.cz>
6883 * expression.cs.cs (ConditionalLogicalOperator.DoResolve):
6886 * class.cs (MethodCore.CheckMethodAgainstBase):
6887 Add error 239 report.
6889 2005-02-21 Marek Safar <marek.safar@seznam.cz>
6891 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
6893 * class.cs (Operator.Define): Add error 217 report.
6895 2005-02-21 Raja R Harinath <rharinath@novell.com>
6898 * expression.cs (Invocation.IsApplicable): Make public.
6899 (Invocation.IsParamsMethodApplicable): Likewise.
6900 * delegate.cs (Delegate.VerifyApplicability): Don't use
6901 Invocation.VerifyArgumentCompat for parameter applicability
6902 testing. Use Invocation.IsApplicable and
6903 Invocation.IsParamsMethodApplicable.
6905 2005-02-21 Marek Safar <marek.safar@seznam.cz>
6907 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
6909 * class.cs (Operator.Define): Add error 217 report.
6911 2005-02-21 Raja R Harinath <rharinath@novell.com>
6913 * namespace.cs (UsingEntry.Resolve): Undo change below.
6915 2005-02-21 Raja R Harinath <rharinath@novell.com>
6918 * ecore.cs (Expression.MemberLookupFailed): Add argument to
6919 disable the error message when the extended MemberLookup also
6921 (Expression.MemberLookupFinal): Update.
6922 (SimpleName.DoSimpleNameResolve): Update.
6923 * expression.cs (MemberAccess.ResolveNamespaceOrType):
6924 Don't use MemberLookupFinal.
6925 (New.DoResolve): Update.
6926 (BaseAccess.CommonResolve): Update.
6928 2005-02-21 Raja R Harinath <rharinath@novell.com>
6931 * attribute.cs (Attribute.ResolveType): If a 'resolve_error' had
6932 occured previously, don't resolve again.
6934 2005-02-21 Marek Safar <marek.safar@seznam.cz>
6937 * attribute.cs (Attribute.GetAttributeUsage): Add EmitContext
6938 argument. Call ResolveAttributeUsage for unresolved.
6939 when types doesn't match ctor arguments.
6941 * class.cs (DoDefineMembers.TypeContainer): Removed safety check
6942 for nested attribute classes.
6943 (Class.attribute_usage): Removed.
6944 (Class.ResolveAttributeUsage): Resolves AttributeUsageAttribute
6945 for attribute class.
6947 * ecore.cs (IsAttribute): Removed.
6949 * namespace.cs (UsingEntry.Resolve): Don't destroy NamespaceEntry.
6951 * rootcontext.cs (RegisterAttribute): Removed, attributes are
6953 (attribute_types): Removed.
6954 (EmitCode): Global attributes are emited as the latest.
6956 2005-02-18 Marek Safar <marek.safar@seznam.cz>
6958 * class.cs (EmitFieldInitializers): Don't emit field initializer
6959 for default values when optimilization is on.
6961 * constant.cs (Constant.IsDefaultValue): New property.
6963 * driver.cs: Add /optimize handling.
6967 * literal.cs: Implement new IsDefaultValue property.
6969 * rootcontext.cs (Optimize): New field, holds /optimize option.
6971 2005-02-18 Raja R Harinath <rharinath@novell.com>
6973 Fix crasher in re-opened #72347.
6974 * namespace.cs (Namespace.Lookup): Return null if
6975 DeclSpace.DefineType returns null.
6978 * expression.cs (Argument.Resolve): Handle a case of CS0120 here.
6980 2005-02-18 Raja R Harinath <rharinath@novell.com>
6982 Fix remainder of #63202. Change semantics of DoResolveLValue: it
6983 now returns null if it cannot resolve to an lvalue.
6984 * ecore.cs (Expression.DoResolveLValue): Return 'null' by default.
6985 (Expression.ResolveLValue): Emit CS0131 error if DoResolveLValue
6986 returned null. Remove check for SimpleName.
6987 (EventExpr.DoResolveLValue): New.
6988 * iterators.cs (Iterator.FieldExpression.DoResolveLValue): New.
6989 * expression.cs (Argument.Error_LValueRequired): New. Move CS1510
6991 (Argument.Resolve): ... here. Use it. Use DoResolveLValue to
6993 (Unary.ResolveOperator): Move CS0211 check ...
6994 (Unary.DoResolve): ... here. Use DoResolveLValue to avoid
6996 (Unary.DoResolveLValue): Simplify.
6997 (AddressOf.DoResolveLValue): New.
6998 (ArrayAccess.DoResolveLValue): New.
7000 2005-02-16 Marek Safar <marek.safar@seznam.cz>
7002 * attribute.cs (Attribute.Resolve): Add arguments casting for
7003 when types doesn't match ctor arguments.
7005 2005-02-16 Raja R Harinath <rharinath@novell.com>
7007 Fix parts of #63202.
7008 * expression.cs (UnaryMutator.ResolveOperator): Remove redundant
7009 lookup of operator in base type. Ensure that all checks happen
7010 when the operator resolves to an "op_..." method.
7012 2005-02-15 Raja R Harinath <rharinath@novell.com>
7015 * namespace.cs (NamespaceEntry.LookupNamespaceOrType): Add
7016 'ignore_cs0104' parameter. Pass it to ...
7017 (NamespaceEntry.Lookup): ... this.
7018 * decl.cs (DeclSpace.LookupType): Add 'ignore_cs0104' parameter.
7019 * ecore.cs (SimpleName.ResolveAsTypeStep): Update.
7020 (TypeLookupExpression.DoResolveAsTypeStep): Update.
7021 * expression.cs (MemberAccess.IdenticalNameAndTypeName):
7022 Update. Request that cs0104 errors be ignored.
7023 (ComposedCast.ResolveAsTypeStep): Update.
7025 2005-02-14 Raja R Harinath <rharinath@novell.com>
7028 * expression.cs (Invocation.BetterFunction): Remove support for
7029 comparing virtual functions and their overrides.
7030 (Invocation.IsOverride): New.
7031 (Invocation.OverloadResolve): Don't consider 'override' functions
7032 during candidate selection. Store them in a lookaside list.
7033 If the selected method is a 'virtual' function, use the list to
7034 find any overrides that are closer to the LHS type.
7036 2005-02-14 Marek Safar <marek.safar@seznam.cz>
7038 * expression.cs (New.DoResolve): Add complex core type reduction.
7039 (New.Constantify): Converts complex core type syntax like 'new int ()'
7042 2005-02-14 Raja R Harinath <rharinath@novell.com>
7044 * decl.cs (EntryType.EntryType): New constructor to create an
7045 updated copy of a cache entry.
7046 (MemberCache.AddMethods): Use it.
7047 (MemberCache.ClearDeclaredOnly): Remove.
7048 (MemberCache.MemberCache): Update.
7050 2005-02-11 Miguel de Icaza <miguel@novell.com>
7052 * codegen.cs (EmitContext): Introduce the `MethodIsStatic'
7053 variable. This one is represents the actual low-level declaration
7054 of the method, as opposed to the semantic level `IsStatic'.
7056 An anonymous method which is hosted into a static method might be
7057 actually an instance method. IsStatic would reflect the
7058 container, while MethodIsStatic represents the actual code
7061 * expression.cs (ParameterReference): Use the new MethodIsStatic
7062 instead of IsStatic.
7064 * anonymous.cs (AnonymousMethod.Compatible): Pass the
7065 Modifiers.STATIC to the Anonymous' Method EmitContext if static is
7066 set on the current EmitContext.
7068 * expression.cs (Cast): Overload DoResolveLValue so we can pass
7069 resolve our casted expression as an LValue. This triggers the
7070 proper LValue processing that is later required by Assign.
7074 * cs-tokenizer.cs (pp_and): recurse on pp_and, fixes #61903.
7076 2005-02-11 Marek Safar <marek.safar@seznam.cz>
7078 C# 2.0 Fixed buffer implementation
7080 * anonymous.cs: Update after RegisterHelperClass renaming.
7082 * attribute.cs (AttributeTester.fixed_buffer_cache):
7083 Cache of external fixed buffers.
7084 (AttributeTester.GetFixedBuffer): Returns IFixedBuffer
7085 implementation if field is fixed buffer else null.
7088 (TypeContainer.AddField): Accept FieldMember instead of Field.
7089 (FieldBase.IsFieldClsCompliant): Extracted code from
7090 VerifyClsCompliance descendant customization.
7091 (FixedField): New class handles fixed buffer fields.
7092 (FixedFieldExternal): Keeps information about imported fixed
7094 (IFixedField): Make access to internal or external fixed buffer
7097 * cs-parser.jay: Add fixed buffer parsing.
7099 * ecore.cs (FieldExpr.Emit): Add special emit case for fixed
7102 * expression.cs (Indirection): Extended implementation to accept
7104 (PointerArithmetic.Emit): Get element from fixed buffer as well.
7105 (ElementAccess.MakePointerAccess): Get type as parameter.
7106 (DoResolve): Add fixed buffer field expression conversion.
7107 (DoResolveLValue): Ditto.
7108 (FixedBufferPtr): New class. Moved most of original ArrayPtr.
7109 (ArrayPtr): Derives from FixedBufferPtr.
7110 (ArrayPtr.Emit): Add extra emit for array elements.
7112 * flowanalysis.cs.cs (StructInfo): Use FieldMember.
7114 * rootcontext.cs (CloseTypes): Emit CompilerGenerated attribute
7115 for compiler generated types.
7116 (RegisterCompilerGeneratedType): Renamed from RegisterHelperClass.
7118 * statement.cs (Fixed): Refactored to be easier add fixed buffer
7119 and consume less memory.
7120 (Fixed.Resolve): Add fixed buffer case.
7122 * typemanager.cs (compiler_generated_attr_ctor,
7123 fixed_buffer_attr_ctor): Add new 2.0 compiler attributes.
7124 (HasElementType): Add our own implementation to work on every
7127 2005-02-11 Miguel de Icaza <miguel@novell.com>
7129 * anonymous.cs (CaptureContext): Track whether `this' has been
7132 * expression.cs (This.ResolveBase): Call CaptureThis. Before we
7133 only captured `this' if it was implicitly done (instance
7134 methods/variables were used).
7136 * codegen.cs (EmitContext.CaptureThis): New method to flag that
7137 `this' must be captured.
7139 2005-01-30 Miguel de Icaza <miguel@novell.com>
7141 * anonymous.cs (CreateMethodHost): If there Scope.ScopeTypeBuilder
7142 is null it means that there has been no need to capture anything,
7143 so we just create a sibling.
7145 Renamed `EmitHelperClasses' to `EmitAnonymousHelperClasses'
7147 Just a partial fix. The other half is fairly elusive.
7149 2005-02-10 Raja R Harinath <rharinath@novell.com>
7151 Fix #52586, cs0121-4.cs.
7152 * decl.cs (MemberCache.DeepCopy): Rename from SetupCache. Take
7153 and return a hashtable.
7154 (MemberCache.ClearDeclaredOnly): New.
7155 (MemberCache.MemberCache): Update to change. Make a deep copy of
7156 the method_hash of a base type too.
7157 (MemberCache.AddMethods): Adapt to having a deep copy of the base
7158 type methods. Overwrite entries with the same MethodHandle so
7159 that the ReflectedType is correct. The process leaves in base
7160 virtual functions and their overrides as distinct entries.
7161 (CacheEntry): Now a class instead of a struct. It shouldn't alter
7162 matters since it was boxed in a ArrayList before.
7163 (CacheEntry.Member, CacheEntry.EntryType): Remove 'readonly'
7165 * expression.cs (Invocation.BetterFunction): Simplify. Handle the
7166 case of a virtual function and its override (choose the overload
7168 (Invocation.OverloadResolve): Avoid 'override' members during
7169 'applicable_type' calculation.
7171 2005-03-28 Raja R Harinath <rharinath@novell.com>
7173 * typemanager.cs (TypeHandle.BaseType): Make into an IMemberContainer.
7174 (TypeHandle.TypeHandle): Use LookupMemberCache rather than
7175 GetTypeHandle. It is possible for a reflected type to derive from
7176 a TypeBuilder (e.g., int[] derives from the TypeBuilder
7177 System.Array during mscorlib compilation).
7178 * decl.cs (MemberCache.MemberCache): If the base cache doesn't
7179 contain a method_hash, don't create one either. Don't create a
7180 deep copy of the base cache's method_hash.
7181 (MemberCache.SetupCache): Rename back from DeepCopy.
7182 (MemberCache.AddMethods): Rewrite, now that method_hash isn't
7183 already initialized. If we see an override function, add its
7184 underlying base virtual function to the member_hash too.
7186 2005-02-09 Raja R Harinath <rharinath@novell.com>
7188 Combine two near-redundant caches.
7189 * typemanager.cs (method_params): Rename from method_internal_params.
7190 (TypeManager.GetParameterData): New. Replace
7191 Invocation.GetParameterData.
7192 (TypeManager.LookupParametersByBuilder): Remove.
7193 * expression.cs (Invocation.method_parameter_cache): Remove.
7194 (Invocation.GetParameterData): Remove.
7196 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
7199 2005-02-08 Raja R Harinath <rharinath@novell.com>
7202 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
7203 TypeManager.multicast_delegate_type is null, resolve it by looking
7204 up "System.MulticastDelegate".
7205 * rootcontext.cs (RootContext.ResolveCore): Simplify.
7207 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
7208 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
7209 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
7212 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
7213 (LabeledStatement.AddReference): New. Set 'referenced'.
7214 (Goto.Resolve): Use it.
7216 2005-02-05 John Luke <john.luke@gmail.com>
7218 * driver.cs: remove duplicate -doc line in Usage ()
7220 2005-02-04 Raja R Harinath <rharinath@novell.com>
7222 * location.cs (Location.AddFile): Fix CS2002 error report.
7224 2005-02-02 Martin Baulig <martin@ximian.com>
7226 * delegate.cs (Delegate.DefineType): Report an internal error if
7227 TypeManager.multicast_delegate_type is null. See bug #72015 for
7230 2005-02-02 Raja R Harinath <rharinath@novell.com>
7232 Fix a crasher in a variant of #31984.
7233 * const.cs (Constant.CheckBase): New override that defers the
7234 new-or-override check in case the base type hasn't been populated
7236 (Constant.Define): Ensure the new-or-override check is performed.
7238 2005-02-01 Duncan Mak <duncan@ximian.com>
7240 * const.cs (LookupConstantValue): Check that `ce' is not null
7241 before calling GetValue ().
7243 2005-02-01 Raja R Harinath <rharinath@novell.com>
7245 Fix test-334.cs (#69519).
7246 * cs-parser.jay (using_alias_directive): Pass in an expression to
7247 NamespaceEntry.UsingAlias.
7248 (using_namespace_directive): Pass in an expression to
7249 NamespaceEntry.Using.
7250 (namespace_name): Don't flatten to a string.
7251 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
7252 (NamespaceEntry.AliasEntry.Resolve): Lookup using
7254 (NamespaceEntry.UsingEntry): Likewise.
7255 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
7257 (NamespaceEntry.LookupForUsing): Remove.
7258 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
7260 (NamespaceEntry.Lookup): Remove support for dotted names.
7262 2005-02-01 Raja R Harinath <rharinath@novell.com>
7264 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
7266 (NamespaceEntry.ImplicitParent): Compute on demand.
7267 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
7268 parallels the current.
7269 (NamespaceEntry.LookupForUsing): Use it.
7270 (NamespaceEntry.Lookup): If the current namespace-entry is
7271 implicit, don't search aliases and using tables.
7273 2005-02-01 Raja R Harinath <rharinath@novell.com>
7276 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
7278 (TypeContainer.BaseCache): Compute on demand.
7279 (TypeContainer.FindMembers): Define constants and types if they're
7280 not already created.
7281 (FieldMember.Define): Move resetting of ec.InUnsafe before error
7283 * const.cs (Constant.Define): Make idempotent.
7285 2005-01-29 Miguel de Icaza <miguel@novell.com>
7287 * pending.cs: Produce better code (no nops produced by using Ldarg
7290 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
7291 i - 1' it should be arg + 1.
7295 2005-01-28 Raja R Harinath <rharinath@novell.com>
7297 * attribute.cs (Attribute.CheckAttributeType): Make private
7299 (Attribute.ResolveType): Make virtual.
7300 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
7301 handling of RootContext.Tree.Types.
7303 2005-01-27 Raja R Harinath <rharinath@novell.com>
7305 Update attribute-handling to use the SimpleName/MemberAccess
7307 * cs-parser.jay (attribute): Pass in an expression to the
7308 constructors of Attribute and GlobalAttribute.
7309 * attribute.cs (Attribute): Take an expression for the name.
7310 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
7311 passed in attribute name expression.
7312 (Attribute.CheckAttributeType): Use it.
7313 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
7314 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
7315 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
7316 argument to prevent error messages if the lookup fails.
7318 2005-01-27 Marek Safar <marek.safar@seznam.cz>
7320 * expression.cs (Indirection): Implemented IVariable interface
7321 to support indirection in AddressOf operator.
7322 (PointerArithmetic.Emit): Add optimalization for case where
7323 result can be precomputed.
7325 2005-01-26 Martin Baulig <martin@ximian.com>
7327 * class.cs (TypeContainer.AttributeTargets): Return the correct
7328 AttributeTargets depending on our `Kind' instead of throwing an
7329 exception; fixes #71632.
7331 2005-01-26 Marek Safar <marek.safar@seznam.cz>
7334 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
7337 2005-03-17 Martin Baulig <martin@ximian.com>
7339 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
7340 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
7342 2005-03-17 Martin Baulig <martin@ximian.com>
7344 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
7345 to bool so we can return an error condition.
7346 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
7349 2005-03-17 Martin Baulig <martin@ximian.com>
7351 * generic.cs (TypeMananager.IsIEnumerable): New public method.
7353 * convert.cs (Convert.ImplicitReferenceConversion(Exists)): Allow
7354 converting from an array-type of T to `IEnumerable<T>'.
7356 2005-03-16 Martin Baulig <martin@ximian.com>
7358 * generic.cs (Nullable.Unwrap): Implement IAssignMethod.
7359 (Nullable.LiftedUnaryMutator): New public class.
7361 * expression.cs (UnaryMutator.DoResolve): Added support for
7364 2005-03-14 Martin Baulig <martin@ximian.com>
7366 * generic.cs (Nullable.NullCoalescingOperator): Implemented.
7368 2005-03-14 Martin Baulig <martin@ximian.com>
7370 * generic.cs (Nullable.LiftedBinaryOperator): Added support for
7371 the comparision operators `<', `>', `<=' and `>='.
7373 2005-03-13 Martin Baulig <martin@ximian.com>
7376 (Nullable.NullLiteral): Renamed to `Nullable.NullableLiteral' to
7377 avoid confusion with the `NullLiteral'.
7378 (Nullable.LiftedBinaryOperator): Correctly implement `==' and '!='.
7380 2005-03-13 Martin Baulig <martin@ximian.com>
7382 * expression.cs (Binary.ResolveOperator): For `==' and `!=', allow
7383 comparing arbitrary types with the null literal.
7385 2005-03-13 Martin Baulig <martin@ximian.com>
7387 * generic.cs (Nullable.LiftedBinaryOperator): Add support for the
7388 boolean operators '&&', '||', '&' and '|'.
7389 (Nullable.OperatorTrueOrFalse): New public class.
7391 * ecore.cs (Expression.GetOperatorTrue/False): Return an `Expression'
7392 instead of a `StaticCallExpr'; added support for nullables.
7394 2005-03-10 Martin Baulig <martin@ximian.com>
7397 (ArrayAccess.EmitDynamicInitializers): Use `etype.IsValueType'
7398 rather than `etype.IsSubclassOf (TypeManager.value_type)'.
7400 2005-03-07 Martin Baulig <martin@ximian.com>
7402 * generic.cs (Nullable.Unwrap): Implement IMemoryLocation and make
7403 it work if `expr' is not an IMemoryLocation.
7404 (Nullable.Lifted): Implement IMemoryLocation.
7405 (Nullable.LiftedConversion.ResolveUnderlying): Use the correct
7408 2005-03-05 Martin Baulig <martin@ximian.com>
7410 * generic.cs (Nullable.Unwrap, Wrap): New protected classes.
7411 (Nullable.Lifted): New abstract class; rewrote the lifted conversions.
7412 (Nullable): Added support for lifted unary and binary operators.
7414 * expression.cs (Unary.DoResolve): Added support for nullable types.
7415 (Binary.DoResolve): Likewise.
7416 (Conditional.DoResolve): Likewise.
7418 2005-03-02 Martin Baulig <martin@ximian.com>
7420 * decl.cs (DeclSpace.SetParameterInfo): Make this virtual.
7422 * class.cs (ClassPart.SetParameterInfo): Override this.
7423 (PartialContainer.SetParameterInfo): Override this.
7424 (TypeContainer.CheckConstraints): New protected method.
7425 (PartialContainer.CheckConstraints): Override this and check
7426 whether the same contraints were specified in all parts of a
7427 partial generic type definition.
7428 (PartialContainer.UpdateConstraints): New public method.
7430 * generic.cs (TypeParameter.UpdateConstraints): New public method.
7432 2005-03-02 Martin Baulig <martin@ximian.com>
7434 Committing a patch from Carlos Alberto Cortez to fix #72887.
7436 * convert.cs (Convert.ExplicitReferenceConversionExists): Allow
7437 casts from `T []' to `int []'.
7439 2005-03-02 Martin Baulig <martin@ximian.com>
7441 * generic.cs (TypeManager.IsEqual): Make this symmetric.
7443 * expression.cs (Binary.ResolveOperator): When resolving a
7444 BinaryDelegate, use `TypeManager.IsEqual (l, r)' rather than just
7445 `=='. Fixes #71866. See gen-127.cs.
7447 2005-03-02 Martin Baulig <martin@ximian.com>
7449 * class.cs (TypeContainer.DoDefineMembers): We also need a default
7450 static constructor in static classes.
7452 2005-03-02 Martin Baulig <martin@ximian.com>
7455 (NullableType.Name, NullableType.FullName): Add a "?" to the name.
7456 (Nullable.LiftedConversion): Added support for user-defined
7459 * cs-tokenizer.cs (Tokenizer.PutbackCloseParens): New public method.
7461 * cs-parser.jay: Use ComposedCast everywhere instead of
7462 NullableType, so we don't need to check for NullableType
7464 (conditional_expression): Added `INTERR CLOSE_PARENS' rule for the
7465 case where we'll be resolved into a `parenthesized_expression_0'
7469 (Convert.UserDefinedConversion): Added nullable conversions.
7471 2005-02-28 Martin Baulig <martin@ximian.com>
7473 * generic.cs (TypeManager.IsNullableType): New static method.
7474 (Nullable): New abstract class.
7475 (Nullable.NullLiteral): New public class.
7476 (Nullable.LiftedConversion): New public class.
7478 * cs-parser.jay (non_expression_type): Changed `builtin_types' to
7479 `builtin_types opt_nullable'.
7482 (Convert.ImplicitConversionStandard): Added nullable conversions.
7483 (Convert.ExplicitConversionStandard): Likewise.
7484 (Convert.ExplicitConversion): Likewise.
7486 2005-02-26 Martin Baulig <martin@ximian.com>
7488 * expression.cs (ComposedCast.DoResolveAsTypeStep): Allow `dim' to
7489 begin with a "?", for instance "?[]". Don't do a type lookup if
7492 2005-02-25 Martin Baulig <martin@ximian.com>
7494 The first part of Nullable Types :-)
7496 * generic.cs (NullableType): New public class.
7497 (NullCoalescingOperator): New public class.
7498 (TypeArguments.Resolve): Add a CS0306 check.
7500 * cs-parser.jay (opt_error_modifier): Removed, this was unused.
7501 (opt_nullable): New rule.
7502 (type): Added `opt_nullable' to `namespace_or_type_name',
7503 `builtin_types' and `pointer_type'.
7504 (array_type): Added `opt_nullable'.
7505 (opt_rank_specifier_or_nullable): New rule; this is the
7506 combination of `opt_rank_specifier' and `opt_nullable'.
7507 (opt_error): New rule; catch errors here.
7508 (nullable_type_or_conditional): New rule; we use this to check for
7509 nullable and still detect the conditional operator.
7510 (local_variable_type): Use `opt_rank_specifier_or_nullable'
7511 instead `opt_rank_specifier'.
7513 * expression.cs (ComposedCast.DoResolveAsTypeStep): Added support
7516 2005-02-24 Martin Baulig <martin@ximian.com>
7518 * README, README.Changes: Removed; they're old and obsolete.
7520 2005-02-22 Martin Baulig <martin@ximian.com>
7522 * generic.cs (TypeParameter.Resolve): If resolving the constraints
7523 returned an error, set `constraints' to null to avoid a crash
7525 (TypeParameter.ResolveType): Likewise.
7527 2005-02-22 Martin Baulig <martin@ximian.com>
7530 (Constraints.ResolveTypes): Protect against being called twice.
7531 (Constraints.CheckInterfaceMethod): Don't call ResolveTypes().
7532 (TypeParameter.ResolveType): New public method; calls
7533 constraints.ResolveTypes().
7534 (TypeParameter.DefineType): Moved constraints.ResolveType() out
7535 into the new ResolveType().
7536 (GenericMethod.Define): Call ResolveType() on all our
7539 2005-02-21 Martin Baulig <martin@ximian.com>
7542 (TypeManager.generic_nullable_type): New static public field.
7543 (TypeManager.InitGenericCoreType): Lookup "System.Nullable`1".
7546 (RootContext.ResolveCore): Resolve "System.Nullable`1".
7548 2005-02-15 Martin Baulig <martin@ximian.com>
7550 * generic.cs (ConstructedType.Constraints): Correctly check
7551 constraints if the argument type is a type parameter; fixes
7554 2005-02-02 Martin Baulig <martin@ximian.com>
7556 * delegate.cs (Delegate.DefineType): Report an internal error if
7557 TypeManager.multicast_delegate_type is null. See bug #72015 for
7560 2005-01-29 Miguel de Icaza <miguel@novell.com>
7562 * pending.cs: Produce better code (no nops produced by using Ldarg
7565 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
7566 i - 1' it should be arg + 1.
7570 2005-01-26 Martin Baulig <martin@ximian.com>
7572 * cs-parser.jay (indexer_declarator): Don't report an error if we
7573 have type parameters since we can be an explicit interface
7574 implementation; fixes #71449.
7576 2005-01-26 Martin Baulig <martin@ximian.com>
7578 * class.cs (TypeContainer.AttributeTargets): Return the correct
7579 AttributeTargets depending on our `Kind' instead of throwing an
7580 exception; fixes #71632.
7582 2005-01-26 Martin Baulig <martin@ximian.com>
7584 * delegate.cs (Delegate.DefineType): Correctly define our type
7585 parameters. Fixes #71483.
7587 2005-01-25 Raja R Harinath <rharinath@novell.com>
7590 * expression.cs (MemberAccess.DoResolve): Don't complain with
7591 cs0572 when the LHS of a member access has identical name and type
7594 2005-01-25 Marek Safar <marek.safar@seznam.cz>
7597 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
7599 Create custom PermissionSet only for PermissionSetAttribute.
7601 2005-01-24 Marek Safar <marek.safar@seznam.cz>
7604 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
7605 delegates in static class.
7607 2005-01-24 Martin Baulig <martin@ximian.com>
7609 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
7610 merging an implicit block, just use its reachability.
7612 * statement.cs (Block.Resolve): Make the unreachable code check
7613 work wrt. implicit blocks; see test-337 from #63842.
7615 2005-01-21 Alp Toker <alp@atoker.com>
7617 * cs-parser.jay: destructor_declaration's container is PartialContainer
7618 not Class when partial types are used, so use Kind prop instead of
7621 2005-01-22 Miguel de Icaza <miguel@ximian.com>
7623 * cs-parser.jay: Improve error reporting when an interface
7626 2005-01-20 Dick Porter <dick@ximian.com>
7628 * support.cs: SeekableStreamReader fix from Sandor Dobos
7629 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
7630 chars are read. Fixes bug 70369.
7632 2005-01-20 Raja R Harinath <rharinath@novell.com>
7634 * cs-parser.jay (catch_clause): Simplify current_block handling
7637 2005-01-17 Miguel de Icaza <miguel@ximian.com>
7639 * convert.cs (ImplicitStandardConversionExists): Synchronize the
7640 code with ImplicitStandardConversion to handle the implicit
7641 conversion of method groups into valid delegate invocations.
7643 The problem is that in parameter handling we were using this code
7644 path. Fixes bug #64698
7646 2005-01-19 Raja R Harinath <rharinath@novell.com>
7648 * cs-parser.jay: Fix several infelicities.
7649 - Avoid assigning to the parser value stack. Code like
7650 '$3 = null' is unclean. Synthesize a value for the code block
7652 - Avoid using oob_stack for storing location information. Use ...
7653 (_mark_): ... this. New (empty) rule. Saves the current location
7655 (foreach_statement): Avoid using oob_stack for current_block
7656 handling. Use technique used in for_statement and
7657 using_statement. Synthesize a value for the code block to store
7658 additional intermediate information.
7660 2005-01-13 Miguel de Icaza <miguel@ximian.com>
7662 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
7663 of a different type is only allowed to private fields of a
7664 containing type, not on fields of a base class.
7666 See test-174.cs and error cs0122-9.cs
7668 2005-01-13 Raja R Harinath <rharinath@novell.com>
7670 Fix test-335.cs (bug #58126).
7671 * cs-parser.jay (argument): Split out non-expression parts of the
7672 rule into 'non_simple_argument'.
7673 (invocation_expression): Support parenthesized invocations with
7674 multiple arguments, and with single non-simple arguments.
7676 2005-01-13 Raja R Harinath <rharinath@novell.com>
7678 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
7681 2005-01-12 Raja R Harinath <rharinath@novell.com>
7683 Fix cs0038-1.cs, cs1640-6.cs.
7684 * ecore.cs (Expression.Resolve): Remove special-case for
7685 SimpleName in error-handling.
7686 (Expression.almostMatchedMembers): Relax access permission to
7688 (Expression.MemberLookupFailed): Handle duplicates in
7689 almostMatchedMembers list.
7690 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
7691 * expression.cs (New.DoResolve): Report CS1540 for more cases.
7692 * typemanager.cs (GetFullNameSignature): Use the MethodBase
7693 overload if the passed in MemberInfo is a MethodBase.
7695 2005-01-25 Martin Baulig <martin@ximian.com>
7698 (DocUtil.emptyParamList): Removed; use `Type.EmptyTypes' instead.
7700 2005-01-12 Marek Safar <marek.safar@seznam.cz>
7703 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
7704 for non-CAS & merge permission sets properly.
7706 2005-01-11 Raja R Harinath <rharinath@novell.com>
7708 Improve standard-compliance of simple name and member access
7709 resolution. Fixes bugs #52697, #57200, #67520, #69519.
7710 * ecore.cs (FullNamedExpression): New abstract base class
7711 for Namespaces and TypeExpressions.
7712 (ResolveFlags.SimpleName): Remove.
7713 (SimpleName): Remove support for dotted names.
7714 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
7715 DeclSpace.FindType and DeclSpace.LookupType.
7716 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
7717 (Expression.ExprClassName): Make member function.
7718 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
7719 a namespace. Remove creation of dotted "SimpleName"s.
7720 (MemberAccess.DoResolve): Likewise.
7721 * decl.cs (DeclSpace.Cache): Make private.
7722 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
7723 (DeclSpace.FindType): Update.
7724 (DeclSpace.LookupType): Move here from RootContext. Return a
7725 FullNamedExpression.
7726 * namespace.cs (Namespace): Derive from FullNamedExpression
7727 so that it can be part of expression resolution.
7728 (Namespace.Lookup): Return an FullNamedExpression.
7729 (NamespaceEntry.LookupAlias): Lookup aliases only in current
7731 * rootcontext.cs (NamespaceLookup): Remove.
7732 (LookupType): Move to DeclSpace.
7733 * attribute.cs (CheckAttributeType): Update.
7734 * doc.cs (FindDocumentedType): Remove allowAlias argument.
7735 (FindDocumentedTypeNonArray): Likewise.
7737 2005-01-11 Raja R Harinath <rharinath@novell.com>
7739 Fix cs0509.cs, cs1632.cs.
7740 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
7741 is the same as IsInterface.
7742 (TypeContainer.GetClassBases): Likewise.
7743 * statement.cs (LabeledStatement.ig): New field.
7744 (LabeledStatement.LabelTarget): Save ILGenerator which created the
7746 (LabeledStatement.DoEmit): Check that the label was created with
7747 the same ILGenerator.
7749 2005-01-10 Marek Safar <marek.safar@seznam.cz>
7752 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
7753 accessors to its properties.
7755 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
7756 from accessors to property.
7758 2005-01-10 Marek Safar <marek.safar@seznam.cz>
7761 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
7764 2005-01-08 Miguel de Icaza <miguel@ximian.com>
7766 * attribute.cs: Check for null and empty strings.
7768 I have lost another battle to Paolo.
7770 2005-01-07 Marek Safar <marek.safar@seznam.cz>
7773 * class.cs (PropertyMethod): Set Parent field in ctors.
7774 (SetMethod.InternalParameters): Add unsafe switch hack.
7775 Override MarkForDuplicationCheck where it is appropriate.
7777 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
7778 It says whether container allows members with the same name.
7780 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
7781 Removed is_method parameter.
7783 2005-01-06 Duncan Mak <duncan@ximian.com>
7785 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
7786 because the previous change led to incorrect reporting of CS1032
7787 ("Cannot define/undefine preprocessor symbols after first token in
7788 file"). Instead of using `tokens_seen' as the only flag that
7789 triggers CS1040, introduce `comments_seen'. This new flag is used
7790 to signify having seen comments on the current line, so it is
7791 unset after a newline.
7793 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
7795 * doc.cs : When searching for a type, find nested type too.
7796 This fixes bug #71040.
7798 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
7801 - Warn missing member comment on those classes which also does not
7802 have doc comments. Fixed bug #71041.
7803 - Don't warn missing doc comment on default constructor.
7806 2005-01-06 Duncan Mak <duncan@ximian.com>
7808 * cs-tokenizer.cs (xtoken): After handling traditional C-style
7809 comments, set `tokens_seen' to true. This allows us to detect
7810 misplaced preprocessor directives (i.e. not at the beginning of
7811 the a line, nor after whitespaces). In that case, report error
7812 CS1040. This fixes bug #56460.
7814 * cs-parser.jay (interface_member_declaration): Add checks for
7815 IsExplicitImpl, and report CS0541 error if an interface member is
7816 defined as an explicit interface declaration.
7818 2005-01-06 Marek Safar <marek.safar@seznam.cz>
7821 * class.cs (PropertyMethod): Set Parent field in ctors.
7822 (SetMethod.InternalParameters): Add unsafe switch hack.
7824 * decl.cs (MemberCore.Parent): Cannot be readonly.
7826 2005-01-06 Raja R Harinath <rharinath@novell.com>
7828 * decl.cs (DeclSpace.ResolveType): Remove.
7829 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
7830 Merge in code from ...
7831 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
7832 * class.cs, enum.cs: Update to changes.
7834 2005-01-06 Miguel de Icaza <miguel@ximian.com>
7836 * anonymous.cs: Ensure that we init the scope of our parent if it
7837 has not been initialized yet.
7839 2004-12-30 Duncan Mak <duncan@ximian.com>
7841 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
7842 if field.FieldBuilder is null. Fixes #70758.
7844 * convert.cs: Fixed some typos and updated some of the comments.
7845 (ImplicitStandardConversionExists):
7846 (TryImplicitIntConversion): If `target_type' is an interface and
7847 the type of `ic' implements this interface, return true or a new
7848 BoxedCast instead of null. This fixes #70468.
7850 2004-12-29 Duncan Mak <duncan@ximian.com>
7852 * expression.cs (Argument.Emit): Check that Expr is
7853 IMemoryLocation before casting to it, and report CS1510 otherwise.
7857 2004-12-21 Ben Maurer <bmaurer@ximian.com>
7859 * statement.cs (Block.ThisVariable): remove the recursion here, to
7860 make the --profile more sane.
7862 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
7864 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
7865 assembly, by JB Evain.
7867 2004-12-17 Raja R Harinath <rharinath@novell.com>
7869 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
7870 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
7871 "parent" refers to enclosing type/class. "base" refers to superclass.
7873 2004-12-17 Raja R Harinath <rharinath@novell.com>
7875 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
7876 Ensure that we only have GlobalAttributes.
7877 * attribute.cs (Attribute.Emit): Make non-virtual.
7878 (GlobalAttribute.Emit): Remove.
7879 (Attribute.Resolve): Make virtual.
7880 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
7881 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
7882 the argument. Don't create one.
7883 (Attribute.GetObsoleteAttribute): Likewise.
7884 (Attribute.GetClsCompliantAttributeValue): Likewise.
7885 * class.cs, decl.cs: Update to changes.
7887 2004-12-17 Marek Safar <marek.safar@seznam.cz>
7889 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
7891 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
7893 * statement.cs (Foreach.Resolve): Add error 186 report.
7895 2004-12-16 Marek Safar <marek.safar@seznam.cz>
7897 * expression.cs (Conditional.DoResolve): Add warning 429.
7899 * statement.cs (If.Resolve): Add warning 665.
7901 2004-12-16 Raja R Harinath <rharinath@novell.com>
7903 New invariant: RootContext.Tree.Types.NamespaceEntry == null
7904 except when in the parser, and in GlobalAttribute.
7905 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
7906 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
7907 RootContext.Tree.Types.NamespaceEntry once work is done.
7908 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
7909 and resets RootContext.Tree.Types.NamespaceEntry.
7911 2004-12-15 Marek Safar <marek.safar@seznam.cz>
7913 * cs-parser.jay: Don't create a block for every variable.
7915 2004-12-14 Miguel de Icaza <miguel@ximian.com>
7917 * location.cs: Provide extra information.
7919 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
7920 variables from the captured environment, it is the ldarg_0.
7922 2004-12-14 Marek Safar <marek.safar@seznam.cz>
7924 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
7927 * class.cs: Changed warning level for 169 to avoid developer
7928 displeasure from warning flooding. It will be changed back when they
7929 fix most of current BCL warnings.
7931 * RootContext.cs: Pushed default WarningLevel to 3.
7933 * statement.cs: Removed unused variable.
7935 2004-12-14 Marek Safar <marek.safar@seznam.cz>
7937 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
7938 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
7939 Add error 502 report.
7940 (StaticClass.DefineType): Add error 441 report.
7941 (Class.AllowedModifiersProp): New virtual property as temporary
7942 extension to AllowedModifiers.
7943 (Class.DefineType): Add error 418 report. Moved ModFlags check here
7944 to share implementation with StaticClass and don't call virtual
7947 * driver.cs (MainDriver): Add error 1558 test.
7949 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
7950 report. Moved error 36 test here.
7952 * statement.cs (Throw.Resolve): Add error 724 report.
7954 * typemanager.cs: Add out_attribute_type core type.
7956 2004-12-13 Marek Safar <marek.safar@seznam.cz>
7958 * class.cs (TypeContainer.VerifyClsCompliance): Add error
7960 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
7962 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
7965 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
7967 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
7968 Add error 3023 report.
7969 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
7971 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
7974 2004-12-12 John Luke <john.luke@gmail.com>
7976 * driver.cs (AddArgs): take -- into account when
7977 adding arguments, fixes bug 65710
7979 2004-12-12 Martin Baulig <martin@ximian.com>
7981 * expression.cs (Unary.TryReduceNegative): Added support for
7982 SByteConstant and ByteConstant.
7983 (Unary.Reduce): Check error values from TryReduceNegative().
7985 2004-12-10 Marek Safar <marek.safar@seznam.cz>
7987 * attributes.cs (Attribute.Resolve): Avoid multiple error report
7988 and report exception as error 182.
7990 2004-12-10 Raja R Harinath <rharinath@novell.com>
7992 * driver.cs (Main): Fix message when there are warnings.
7994 2004-12-09 Miguel de Icaza <miguel@ximian.com>
7996 * delegate.cs: Fixed my fix from yesterday, sorry about that.
7998 2004-12-09 Marek Safar <marek.safar@seznam.cz>
8000 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
8001 Reduced number of warnings.
8003 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
8005 2004-12-08 Miguel de Icaza <miguel@ximian.com>
8007 * driver.cs: Removed message.
8009 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
8011 2004-12-08 <vargaz@freemail.hu>
8013 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
8015 2004-12-08 Martin Baulig <martin@ximian.com>
8017 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
8018 instead of a CS3002 for properties and indexer.
8020 2004-12-08 Martin Baulig <martin@ximian.com>
8022 * decl.cs (MemberName.ToString): Make this work again.
8024 2004-12-08 Marek Safar <marek.safar@seznam.cz>
8026 * attribute.cs (Resolve): Add error 591 detection.
8028 * class.cs (FieldMember.Define): Add error 1547 detection.
8029 (Indexer.Define): Add error 620 detection.
8030 (Operator.Define): Add error 590 detection.
8032 * ecore.cs: Missing argument for error 79.
8034 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
8037 2004-12-07 Marek Safar <marek.safar@seznam.cz>
8040 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
8043 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
8045 * cs-parser.jay : handle doc comments on implicit/explicit operators.
8046 Some operator comments were suppressed.
8047 * doc.cs : Implicit/explicit operator name in doc comments are like
8048 "op_Explicit(type)~returnType", so added suffix handling.
8050 2005-01-21 Alp Toker <alp@atoker.com>
8052 * cs-parser.jay: destructor_declaration's container is PartialContainer
8053 not Class when partial types are used, so use Kind prop instead of 'is'.
8055 2004-12-12 Martin Baulig <martin@ximian.com>
8057 * expression.cs (Unary.TryReduceNegative): Added support for
8058 SByteConstant and ByteConstant.
8059 (Unary.Reduce): Check error values from TryReduceNegative().
8061 2004-12-11 Martin Baulig <martin@ximian.com>
8063 * support.cs (ReflectionParameters.ParameterName): If we have a
8064 `gpd', call `ParameterName' on it.
8066 * parameter.cs (Parameter.GetParameterAttributes): New static method.
8068 * pending.cs (PendingImplementation.DefineProxy): Call
8069 DefineParameter() for all of the MethodBuilder's arguments.
8071 2004-12-09 Martin Baulig <martin@ximian.com>
8073 * doc.cs (DocUtil): Make this a static class.
8075 2004-12-09 Martin Baulig <martin@ximian.com>
8077 * expression.cs (Invocation.InferType): Moved the type inference
8078 implementation into TypeManager.
8080 * generics.cs (TypeManager): Moved the type inference
8081 implementation here.
8083 2004-12-09 Martin Baulig <martin@ximian.com>
8085 * typemanager.cs (TypeManager): Make this a partial class.
8088 (TypeManager): Move the generics part of `TypeManager' here.
8090 2004-12-08 Martin Baulig <martin@ximian.com>
8092 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
8093 instead of a CS3002 for properties and indexer. Added CS3024
8094 check for generic interfaces.
8096 * attributes.cs (AttributeTester.AnalyzeTypeCompliance): Generic
8097 instances are not CLS-compliant.
8099 2004-12-08 Martin Baulig <martin@ximian.com>
8102 (void_pointer_expression): New rule for `void*', `void**' etc.
8103 (typeof_expression): Add `void_pointer_expression'; fixes #66846.
8105 2004-12-08 Martin Baulig <martin@ximian.com>
8107 * expression.cs (Invocation.InferType): Removed the hack for
8108 MethodCore.MayUnify().
8110 * typemanager.cs (TypeManager.MayBecomeEqualGenericTypes): Make
8113 * class.cs (MethodCore.MayUnify): Use
8114 TypeManager.MayBecomeEqualGenericTypes().
8116 2004-12-08 Martin Baulig <martin@ximian.com>
8118 * expression.cs (Is.DoResolve, As.DoResolve): If we're a type
8119 parameter, box it. Fixes #69233.
8121 2004-12-08 Martin Baulig <martin@ximian.com>
8123 * generic.cs (ConstructedType.CheckConstraints): Valuetypes always
8124 have the ctor constraint. Fixes #68326.
8126 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
8128 * cs-parser.jay : interface comment was not consumed because of
8129 extra opt_semicolon before doc handling.
8131 2004-12-03 Raja R Harinath <rharinath@novell.com>
8133 Fix test-327.cs, test-328.cs, and put in early infrastructure
8134 for eventually fixing #52697.
8135 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
8136 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
8138 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
8139 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
8140 (VerifyUsing, error246): Update.
8141 * rootcontext.cs (RootContext.NamespaceLookup): Just use
8142 'NamespaceEntry.LookupNamespaceOrType'.
8144 2004-12-07 Martin Baulig <martin@ximian.com>
8146 * driver.cs: Call it "BETA SOFTWARE" :-)
8148 2004-12-06 Raja R Harinath <rharinath@novell.com>
8150 Fix crash on cs0657-17.cs.
8151 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
8152 Use RootContext.Tree.Types, not 'new RootTypes ()'.
8153 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
8154 the case where the NamespaceEntry gets overwritten.
8156 2004-12-06 Marek Safar <marek.safar@seznam.cz>
8158 Fixed #69195, #56821
8159 * ecore.cs (ResolveBoolean): Tiny refactoring.
8161 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
8162 of right expression resolving when left is false constant and
8163 operator is LogicalAnd OR true constant and operator is LogicalOr.
8165 * statement.cs (ResolveUnreachable): Always reports warning.
8167 2004-12-05 Miguel de Icaza <miguel@ximian.com>
8169 * class.cs: Distinguish between 1721 and 1722 (just a little help
8170 for the programmer).
8172 2004-12-03 Miguel de Icaza <miguel@ximian.com>
8174 * delegate.cs: Only allow this on new versions of the language.
8176 2004-12-02 Duncan Mak <duncan@ximian.com>
8178 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
8180 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
8181 here as a static method. Take an additional bool out parameter
8182 `must_do_cs1540_check' for signaling to InstanceResolve.
8183 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
8184 member field from PropertyExpr class and made it an argument of
8186 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
8187 check for MarshalByRefObject, and report CS0122 instead of CS1540.
8188 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
8189 and `remove_accessor' as well as InstanceResolve: report CS0122
8194 2004-12-07 Martin Baulig <martin@ximian.com>
8196 * decl.cs (DeclSpace.AddToContainer): Report correct errors CS0694
8197 and CS0692 where appropriate.
8199 2004-12-06 Martin Baulig <martin@ximian.com>
8201 * class.cs (MethodCore.MayUnify): Moved the CS0408 check here from
8202 IsDuplicateImplementation() and improved it.
8204 * expression.cs (Invocation.InferTypeArguments): Added
8205 `Type[] inferred_class_types' argument (for MethodCore.MayUnify)
8206 and removed the "ref" modifier from `infered_types'.
8208 * decl.cs (MemberName.ToString): Removed the exception.
8210 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
8212 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
8213 comments are allowed.
8215 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
8217 * delegate.cs: Add checks for subtypes in paramaters and return values
8218 in VerifyMethod () to add support for Covariance/Contravariance
8221 2004-12-02 Miguel de Icaza <miguel@ximian.com>
8223 * report.cs: Remove extra closing parenthesis.
8225 * convert.cs (Error_CannotImplicitConversion): If the name of the
8226 types are the same, provide some extra information.
8228 2004-12-02 Marek Safar <marek.safar@seznam.cz>
8231 * attribute.cs (Resolve): Improved implementation of params
8232 attribute arguments.
8234 * support.cs (ParameterData): Add HasParams to be faster.
8236 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
8238 all things are for /doc support:
8240 * doc.cs: new file that supports XML documentation generation.
8241 * mcs.exe.sources: added doc.cs.
8243 Handle /doc command line option.
8244 Report error 2006 instead of 5 for missing file name for /doc.
8245 Generate XML documentation when required, after type resolution.
8247 Added support for picking up documentation (/// and /** ... */),
8248 including a new XmlCommentState enumeration.
8250 Added lines to fill Documentation element for field, constant,
8251 property, indexer, method, constructor, destructor, operator, event
8252 and class, struct, interface, delegate, enum.
8253 Added lines to warn incorrect comment.
8255 Added Documentation field (passed only when /doc was specified).
8257 Added DocComment, DocCommentHeader, GenerateDocComment() and
8258 OnGenerateDocComment() and some supporting private members for
8259 /doc feature to MemberCore.
8261 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
8263 Added overriden DocCommentHeader.
8265 Added overriden DocCommentHeader and GenerateDocComment().
8267 2004-12-01 Miguel de Icaza <miguel@ximian.com>
8269 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
8270 unwrapping the enumeration values, chain to
8271 DoConstantNumericPromotions again, so we can promote things to the
8272 fundamental types (takes care of enums that are bytes, sbytes).
8276 2004-12-01 Raja R Harinath <rharinath@novell.com>
8278 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
8279 Fix long-standing bug in type-lookup. Use FindType instead of
8280 LookupType when ec.ResolvingTypeTree.
8281 (Attribute.ResolveType, Attribute.Resolve)
8282 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
8284 (Attributes.Search): Remove internal version. Update.
8285 (Attributes.SearchMulti): Update.
8286 (Attributes.GetClsCompliantAttribute): Remove.
8287 (Attributes.GetIndexerNameAttribute): Remove.
8288 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
8289 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
8290 * class.cs (Indexer.Define): Likewise.
8292 2004-12-01 Marek Safar <marek.safar@seznam.cz>
8295 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
8296 MarshallByReference members access.
8298 * expression.cs: Use CheckMarshallByRefAccess;
8299 Better error CS0197 message.
8301 * report.cs: Print whole related error message.
8303 2004-11-29 Marek Safar <marek.safar@seznam.cz>
8305 * class (GetClassBases): Better error 60 report.
8306 (EventProperty): Disabled warning 67 detection.
8308 2004-11-29 Marek Safar <marek.safar@seznam.cz>
8311 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
8313 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
8316 2004-11-29 Marek Safar <marek.safar@seznam.cz>
8319 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
8321 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
8323 2004-11-26 Miguel de Icaza <miguel@ximian.com>
8325 * attribute.cs (Attribute.Resolve): Refine error reporting and
8326 report a cs0117 if the identifier does not exist, to distinguish
8327 from 0617 which is a miss-use of the actual identifier.
8329 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
8330 between cs0070 and cs0079.
8332 * class.cs (MemberBase.DoDefine): When reporting a wrong
8333 accessibility level, we use MethodCore to compare instead of
8334 Method (this was a regression in some refactoring effort).
8336 So now we correctly report cs0056 again.
8338 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
8339 testing the target_type (which was known to be object_type) and
8340 not the source type (which is anonymous_method).
8342 Fixed reporting of error cs1660.
8344 * expression.cs (UserCast.Source): Expose the underlying cast.
8346 * statement.cs (Switch.SwitchGoverningType): Sort the list of
8347 allowed types to find a match to int32 first (most common).
8349 In addition, it ignores any ImplicitUserConversions that did an
8350 internal implicit conversion (as the switch statement allows only
8351 one integral conversion to exist).
8353 * class.cs (PartialContainer.Create): rename `name' to
8354 `member_name' for clarity. Then replace the string calls with a
8355 call to MemberName.GetPartialName, as now using
8356 MemberName.ToString is an error (this is due to the side effects
8357 it had, that were fixed in the past).
8359 This will restore the error reporting on a number of partial class
8360 errors that were missusing this (and getting an exception as a
8361 results, which is now just a plain textual warning, because
8362 yyparse debug output would crash otherwise).
8364 2004-11-26 Raja R Harinath <rharinath@novell.com>
8366 * Makefile (PROGRAM_INSTALL_DIR): Remove.
8368 2004-11-25 Ben Maurer <bmaurer@ximian.com>
8370 * rootcontext.cs (LookupType): Make sure to cache lookups that
8371 don't give us a negative result. This saves about 5% of corlib
8374 2004-11-25 Miguel de Icaza <miguel@ximian.com>
8376 * report.cs (AbstractMessage.Print): messages are sent to stderr
8378 * class.cs (TypeContainer.GetClassBases): It is an error to have a
8379 non-interface in the list of interfaces (at this point, either
8380 parent was properly set, or a base class is being listed in the
8381 interfaces section).
8383 This flags error 1722, and resolves the crash from bug 69259.
8385 2004-11-25 Ben Maurer <bmaurer@ximian.com>
8387 * statement.cs (Using.EmitExpressionFinally): make this work right
8388 for valuetypes. Fixes 69926.
8390 2004-11-25 Miguel de Icaza <miguel@ximian.com>
8392 * const.cs (Const.ChangeType): Cope with the "0 literal can be
8393 converted to an enum" here, before we try to change the underlying
8394 type. This code exists, but it is a different code path than the
8395 one used while encoding constants.
8397 (ImplicitReferenceConversionExists): In addition, resynchronized
8398 the code here, so it matches the same code in
8399 ImplicitReferenceConversionExists for the `from any class-type S
8400 to any interface-type T'.
8402 2004-11-25 Marek Safar <marek.safar@seznam.cz>
8404 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
8406 2004-11-24 Miguel de Icaza <miguel@ximian.com>
8408 * cs-parser.jay: Use verbosity accordingly.
8410 2004-11-24 Marek Safar <marek.safar@seznam.cz>
8412 * expression.cs (Unary.ResolveOperator): Do not report warning;
8413 AddressOf reads from variable.
8415 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
8417 2004-11-24 Marek Safar <marek.safar@seznam.cz>
8421 * attribute.cs (Attributable): Removed CheckTargets.
8422 (Attributes.Emit): Explicit attribute targets are tested here.
8424 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
8425 not enabled for interfaces.
8427 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
8428 (GetAssemblyName): Ouch next bug there.
8430 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
8432 * expression.cs: Error 275 added.
8434 2004-11-23 Marek Safar <marek.safar@seznam.cz>
8436 Fix bug #69177 (Implemented decimal constant support)
8438 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
8439 (BinaryFold): Add DecimalConstant.
8441 * const.cs (Define): Decimal constant
8443 (ChangeType): Add decimal type handling.
8444 (LookupConstantValue): Don't set value for decimal type but
8445 emit DecimalConstantAttribute. Needed for constant optimization.
8447 * constant.cs (ToDecimal): New method.
8448 (ConvertToDecimal): New method.
8449 (IntConstant): Implemented ConvertToDecimal.
8450 (DecimalConstant.Emit): Emit optimized version for decimals in
8453 * expression.cs (ResolveOperator): Changed order of constant
8454 reduction to work correctly with native types which have
8455 overloaded operators.
8456 (ResolveMemberAccess): Extract constant value from attribute
8459 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
8461 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
8462 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
8463 (ChangeType): Decimal is special.
8464 (TypeToCoreType): Add decimal type.
8466 2004-11-22 Marek Safar <marek.safar@seznam.cz>
8468 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
8471 2004-11-22 Marek Safar <marek.safar@seznam.cz>
8473 * class.cs (EventField.ApplyAttributeBuilder): Fix error
8476 2004-11-19 Marek Safar <marek.safar@seznam.cz>
8478 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
8480 * pending.cs (PendingImplementation): Grab only interfaces.
8482 2004-11-19 Marek Safar <marek.safar@seznam.cz>
8484 * statement.cs (ForeachHelperMethods): Add location member and
8485 error 202 detection.
8487 2004-11-18 Marek Safar <marek.safar@seznam.cz>
8489 * expression.cs (DoResolveBase): Fixed wrong warning for out
8492 2004-12-04 Martin Baulig <martin@ximian.com>
8494 * convert.cs (Convert.TypeParameter_to_Null): Use the constraints
8495 to check whether the conversion is ok.
8497 * typemanager.cs (TypeManager.GetTypeArguments): Just return
8498 `Type.EmptyTypes' if we're not a generic TypeContainer.
8500 2004-11-25 Miguel de Icaza <miguel@ximian.com>
8502 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
8503 old bug: when converting from the null literal to a pointer,
8504 return an EmptyCast, not the NullLiteral.
8506 This fixes #69921, the recent null_type changes probably made this
8509 2004-12-03 Martin Baulig <martin@ximian.com>
8511 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
8512 method as our child, call AnonymousMethod.Compatible() on it.
8514 2004-12-02 Miguel de Icaza <miguel@ximian.com>
8516 * class.cs (FieldBase): Use an unused bit field from the field to
8517 encode the `has_offset' property from the FieldMember. This saves
8518 a couple of Ks on bootstrap compilation.
8520 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
8521 method as our child, return the AnonymousMethod resolved
8524 * expression.cs (New.DoResolve): Allow return values from
8525 NewDelegate to also include AnonymousMethods.
8529 2004-11-29 Raja R Harinath <rharinath@novell.com>
8531 * decl.cs (MemberCore.MemberName): Remove readonly to fix an error
8533 * rootcontext.cs (ResolveCore::interfaces_first_stage): Add
8534 System.Runtime.InteropServices._Exception, since it's a base
8535 interface of the core type System.Exception in the net_2_0 profile.
8537 2004-11-27 Martin Baulig <martin@ximian.com>
8539 * ecore.cs (Expression.StoreFromPtr): Use `stobj' for generic parameters.
8541 2004-11-26 Raja R Harinath <rharinath@novell.com>
8543 * Makefile: Convert to use executable.make.
8544 * gmcs.exe.sources: New.
8546 2004-11-25 Martin Baulig <martin@ximian.com>
8548 * expression.cs (Invocation.InferType): Added support for byref types.
8550 2004-11-25 Martin Baulig <martin@ximian.com>
8552 * statement.cs (Foreach.FetchMethodMoveNext): Wrap `mi.ReturnType'
8553 in TypeManager.TypeToCoreType().
8555 2004-11-25 Martin Baulig <martin@ximian.com>
8557 * iterators.cs (Iterator.DoDefineMembers): Override and lookup the
8558 "Dispose" method from the `current_type'.
8559 (Iterator.EmitMoveNext): Use the `dispose_method' we looked up in
8560 DoDefineMembers() instead of using the MethodBuilder; this is
8561 required for generic iterators.
8563 * class.cs (TypeContainer.DoDefineMembers): Make this virtual.
8565 2004-11-24 Martin Baulig <martin@ximian.com>
8567 * ecore.cs (Expression.LoadFromPtr): Use `ldobj' for generic parameters.
8569 2004-11-20 Martin Baulig <martin@ximian.com>
8571 * expression.cs (Invocation.InferType): Correctly infer generic
8572 instances; see gen-103.cs.
8573 (Invocation.InferTypeArguments): If a generic method doesn't have
8574 any unbound type parameters, we don't need to infer anything.
8576 2004-11-19 Raja R Harinath <rharinath@novell.com>
8578 * Makefile (gmcs.exe): Update to new location of bootstrap mcs.exe.
8580 2004-11-17 Raja R Harinath <rharinath@novell.com>
8582 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
8583 (TypeHandle.GetMemberCache): New.
8584 (TypeHandle.TypeHandle): Update.
8585 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
8586 (TypeManager.LookupParentInterfacesCache):
8587 Rename from LookupInterfaceCache. Optimize slightly.
8588 (TypeManager.MemberLookup_FindMembers): Update.
8589 * decl.cs (MemberCache.MemberCache): Set Container to null in the
8591 (AddCacheContents): Rename from AddHashtable.
8592 * class.cs (TypeContainer.parent_container): Remove.
8593 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
8594 (TypeContainer.DoDefineMembers): Don't initialize it.
8595 Update to name changes.
8597 2004-11-17 Miguel de Icaza <miguel@ximian.com>
8599 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
8600 that factors the code to check access modifiers on override.
8602 (PropertyBase): Use the code here.
8604 Patch from Lluis S'anchez, fixes bug #69361.
8606 2004-11-15 Miguel de Icaza <miguel@ximian.com>
8608 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
8609 routine that is used to report the use of a captured variable
8610 whose address has been taken.
8612 There are two checks: one when variables are being captured and
8613 the other check is when the address of a variable is taken.
8615 (because an anonymous methods might be resolved before *or* after
8616 the address has been taken) and
8618 * expression.cs (Conditional.DoResolve): Remove the special
8619 casing that Martin added to trueExpr and falseExpr being both
8620 NullLiteral. We get the right behavior now just by introducing
8621 the null_type into the compiler.
8623 * convert.cs (ExplicitConversion): Change the code to use
8624 null_type instead of testing `expr is NullLiteral'.
8625 (ImplicitConversionStandard): use null_type too.
8626 (ImplicitReferenceConversionExists): use null_type too.
8627 (ImplicitReferenceConversion): use null_type too.
8629 * literal.cs: The type of `NullLiteral' is now null_type instead
8631 (Resolve): Set the type here.
8633 * typemanager.cs: Introduce null_type.
8635 2004-11-18 Martin Baulig <martin@ximian.com>
8638 (RootContext.LookupType): Return a `Type', not a `TypeExpr'.
8640 2004-11-18 Martin Baulig <martin@ximian.com>
8642 * ecore.cs (TypeExpr.DoResolveAsTypeStep): Make this protected.
8644 2004-11-18 Martin Baulig <martin@ximian.com>
8646 * generic.cs (Constraints.Resolve): Take an `EmitContext' instead
8647 of a `DeclSpace'. If one of our constraints is a `ConstructedType',
8648 call ResolveConstructedType() on it to resolve it without checking
8650 (Constraints.ResolveTypes): Check them here.
8651 (ConstructedType.DoResolveAsTypeStep): Fully resolve ourselves,
8652 but don't check constraints.
8653 (ConstructedType.ResolveAsTypeTerminal): Override this and also
8654 check constraints here.
8655 (ConstructedType.ResolveConstructedType): New public method. This
8656 is called from DoResolveAsTypeStep() and Constraints.Resolve() to
8657 resolve ourselves without checking constraints.
8659 * ecore.cs (Expression.ResolveAsTypeTerminal): Make this virtual.
8661 2004-11-18 Martin Baulig <martin@ximian.com>
8664 (DeclSpace.CurrentType): Changed type from `TypeExpr' to `Type'.
8666 * delegate.cs (Delegate.DefineType): Always create the EmitContext.
8668 2004-11-18 Martin Baulig <martin@ximian.com>
8670 * ecore.cs (TypeExpr.ResolveType): Removed.
8671 (Expression.ResolveAsTypeTerminal): We always return a fully
8672 resolved `TypeExpr', so we can just access its `Type'.
8674 * class.cs (TypeContainer.DefineType): Resolve `CurrentType' here.
8676 2004-11-17 Martin Baulig <martin@ximian.com>
8678 * ecore.cs (IAlias.Type): Replaced with ResolveAsType() to make
8679 sure we don't return any unresolved TypeExpr's.
8680 (TypeAliasExpression): The .ctor now takes an `IAlias' instead of
8682 (Expression.ResolveAsTypeTerminal): Make sure `te.Type != null'.
8684 * expression.cs (MemberAccess.ResolveAsTypeStep): Don't return any
8685 unresolved `ConstructedType's.
8687 2004-11-17 Martin Baulig <martin@ximian.com>
8689 * ecore.cs (TypeExpr.ResolveType): Don't make this virtual.
8691 2004-11-17 Martin Baulig <martin@ximian.com>
8694 (Expression.ResolveAsTypeTerminal): Removed the `bool silent' argument.
8696 * decl.cs (DeclSpace.ResolveType): Removed.
8697 (DeclSpace.ResolveTypeExpr): Removed the `bool silent' argument.
8699 2004-11-17 Martin Baulig <martin@ximian.com>
8701 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
8702 direction, like FindMembers() does. Fixes #69546, testcase is in
8705 2004-11-16 Martin Baulig <martin@ximian.com>
8707 This is based on a patch from Marek Safar, see bug #69082.
8708 Fixes bugs #63705 and #67130.
8710 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
8711 method; create a MemberCache for an interface type and cache the
8714 * decl.cs (IMemberContainer.ParentContainer): Removed.
8715 (IMemberContainer.ParentCache): New property.
8716 (MemberCache.SetupCacheForInterface): Removed.
8717 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
8718 to create a cache for an interface's "parent".
8720 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
8723 2004-11-14 Ben Maurer <bmaurer@ximian.com>
8725 * statement.cs: Avoid adding bools to a hashtable.
8727 2004-11-15 Martin Baulig <martin@ximian.com>
8729 * decl.cs (MemberName.GetPartialName): Removed, use GetTypeName() instead.
8731 2004-11-11 Martin Baulig <martin@ximian.com>
8733 * typemanager.cs (TypeManager.GetMethodName): New method.
8735 * class.cs (MethodData.Define): Include the generic arity in the
8736 name of an explicit interface; also add it to the method name.
8738 * pending.cs (PendingImplementation.InterfaceMethod): The method
8739 name now includes the generic arity.
8741 2004-11-07 Miguel de Icaza <miguel@ximian.com>
8743 * expression.cs (Invocation.OverloadResolve): Flag error if we are
8744 calling an unsafe method from a safe location.
8746 2004-11-06 Marek Safar <marek.safar@seznam.cz>
8749 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
8751 2004-11-06 Miguel de Icaza <miguel@ximian.com>
8753 * namespace.cs (VerifyUsing): use GetPartialName instead of
8756 2004-11-05 Miguel de Icaza <miguel@ximian.com>
8758 * statement.cs (Return.Resolve): Fix regression in typo: if
8759 `in_exc', we have to request a NeedReturnLabel, this was a typo
8760 introduced in the anonymous method check-in. Fixes #69131.
8762 * Indexers were using the ShortName when defining themselves,
8763 causing a regression in the compiler bootstrap when applying the
8764 patch from 2004-11-02 (first part), now they use their full name
8765 and the bug is gone.
8767 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
8769 * driver.cs: Strip the path from the names of embedded resources. Fixes
8772 2004-11-04 Raja R Harinath <rharinath@novell.com>
8774 Fix error message regression: cs0104-2.cs.
8775 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
8776 (AliasEntry.Resolve): Update.
8777 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
8779 (RootContext.LookupType): Update.
8781 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
8783 * cs-parser.jay: Add support for handling accessor modifiers
8784 * class: Add support port accessor modifiers and error checking,
8785 define PropertyMethod.Define as virtual (not abstract anymore)
8786 * ecore.cs: Add checking for proeprties access with access modifiers
8787 * iterators.cs: Modify Accessor constructor call based in the modified
8789 2004-11-02 Ben Maurer <bmaurer@ximian.com>
8791 * expression.cs (StringConcat): Handle being called twice,
8792 as when we have a concat in a field init with more than two
8795 2004-11-02 Miguel de Icaza <miguel@ximian.com>
8797 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
8798 special case explicit implementations, we should always produce
8799 the .property or .event declaration.
8801 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
8802 since it will not return correct data if people use this
8803 unresolved in the presence of using statements (see test-313).
8805 * class.cs (MethodData.Define): If we are an explicit interface
8806 implementation, set the method name to the full name of the
8807 interface plus the name of the method.
8809 Notice that using the method.MethodName.GetFullName() does not
8810 work, as it will only contain the name as declared on the source
8811 file (it can be a shorthand in the presence of using statements)
8812 and not the fully qualifed type name, for example:
8816 class D : ICloneable {
8817 object ICloneable.Clone () {
8821 Would produce a method called `ICloneable.Clone' instead of
8822 `System.ICloneable.Clone'.
8824 * namespace.cs (Alias.Resolve): Use GetPartialName.
8826 2004-11-01 Marek Safar <marek.safar@seznam.cz>
8828 * cs-parser.jay: Add error 1055 report.
8830 2004-11-01 Miguel de Icaza <miguel@ximian.com>
8832 * assign.cs (Assign.DoResolve): Only do the transform of
8833 assignment into a New if the types are compatible, if not, fall
8834 through and let the implicit code deal with the errors and with
8835 the necessary conversions.
8837 2004-11-01 Marek Safar <marek.safar@seznam.cz>
8839 * cs-parser.jay: Add error 1031 report.
8841 * cs-tokenizer.cs: Add location for error 1038.
8843 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8845 * cs-parser.jay: Add error 1016 report.
8847 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8849 * cs-parser.jay: Add errors 1575,1611 report.
8851 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8853 * cs-parser.jay: Add error 1001 report.
8855 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8858 * attribute.cs (GetMarshal): Add method argument for
8859 caller identification.
8861 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
8862 agument for GetMarshal and RuntimeMissingSupport.
8864 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8866 * attribute.cs (ExtractSecurityPermissionSet): Removed
8867 TypeManager.code_access_permission_type.
8869 * typemanager.cs: Removed TypeManager.code_access_permission_type.
8871 2004-10-27 Miguel de Icaza <miguel@ximian.com>
8873 * expression.cs (LocalVariableReference.DoResolveLValue): Check
8874 for obsolete use of a variable here. Fixes regression on errors
8875 cs0619-25 and cs0619-26.
8877 2004-10-27 Marek Safar <marek.safar@seznam.cz>
8879 Fix #62358, implemented security attribute encoding.
8881 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
8882 Tests permitted SecurityAction for assembly or other types.
8883 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
8884 data from SecurityPermissionAttribute to PermisionSet class.
8886 * class.cs (ApplyAttributeBuilder): Added special handling
8887 for System.Security.Permissions.SecurityAttribute based types.
8889 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
8890 special handling for System.Security.Permissions.SecurityAttribute
8893 * enum.cs (ApplyAttributeBuilder): Added special handling
8894 for System.Security.Permissions.SecurityAttribute based types.
8896 * parameter.cs (ApplyAttributeBuilder): Added special handling
8897 for System.Security.Permissions.SecurityAttribute based types.
8899 * rootcontext.cs: Next 2 core types.
8901 * typemanager.cs (TypeManager.security_permission_attr_type):
8902 Built in type for the SecurityPermission Attribute.
8903 (code_access_permission_type): Build in type.
8905 2004-10-17 Miguel de Icaza <miguel@ximian.com>
8907 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
8908 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
8909 all of this information into
8910 EmitContext.EmitCapturedVariableInstance.
8912 * codegen.cs (EmitCapturedVariableInstance): move here the
8913 funcionality of emitting an ldarg.0 in the presence of a
8914 remapping. This centralizes the instance emit code.
8916 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
8917 then emit a load of this: it means that we have reached the
8918 topmost ScopeInfo: the one that contains the pointer to the
8919 instance of the class hosting the anonymous method.
8921 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
8922 captures to the topmost CaptureContext.
8924 2004-10-12 Miguel de Icaza <miguel@ximian.com>
8926 * expression.cs (LocalVariableReference): Move the knowledge about
8927 the iterators into codegen's EmitCapturedVariableInstance.
8929 2004-10-11 Miguel de Icaza <miguel@ximian.com>
8931 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
8932 all code paths return a value from an anonymous method (it is the
8933 same as the 161 error, but for anonymous methods).
8935 2004-10-08 Miguel de Icaza <miguel@ximian.com>
8937 The introduction of anonymous methods in the compiler changed
8938 various ways of doing things in the compiler. The most
8939 significant one is the hard split between the resolution phase
8940 and the emission phases of the compiler.
8942 For instance, routines that referenced local variables no
8943 longer can safely create temporary variables during the
8944 resolution phase: they must do so from the emission phase,
8945 since the variable might have been "captured", hence access to
8946 it can not be done with the local-variable operations from the runtime.
8950 (Block.Flags): New flag `IsTopLevel' to indicate that this block
8951 is a toplevel block.
8953 (ToplevelBlock): A new kind of Block, these are the blocks that
8954 are created by the parser for all toplevel method bodies. These
8955 include methods, accessors and anonymous methods.
8957 These contain some extra information not found in regular blocks:
8958 A pointer to an optional CaptureContext (for tracking captured
8959 local variables and parameters). A pointer to the parent
8962 (Return.Resolve): Catch missmatches when returning a value from an
8963 anonymous method (error 1662).
8964 Invoke NeedReturnLabel from the Resolve phase instead of the emit
8967 (Break.Resolve): ditto.
8969 (SwitchLabel): instead of defining the labels during the
8970 resolution phase, we now turned the public ILLabel and ILLabelCode
8971 labels into methods called GetILLabelCode() and GetILLabel() that
8972 only define the label during the Emit phase.
8974 (GotoCase): Track the SwitchLabel instead of the computed label
8975 (its contained therein). Emit the code by using
8976 SwitchLabel.GetILLabelCode ().
8978 (LocalInfo.Flags.Captured): A new flag has been introduce to track
8979 whether the Local has been captured or not.
8981 (LocalInfo.IsCaptured): New property, used to tell whether the
8982 local has been captured.
8984 * anonymous.cs: Vastly updated to contain the anonymous method
8987 The main classes here are: CaptureContext which tracks any
8988 captured information for a toplevel block and ScopeInfo used to
8989 track the activation frames for various local variables.
8991 Each toplevel block has an optional capture context associated
8992 with it. When a method contains an anonymous method both the
8993 toplevel method and the anonymous method will create a capture
8994 context. When variables or parameters are captured, they are
8995 recorded on the CaptureContext that owns them, for example:
8999 MyDelegate d = delegate {
9004 Here `a' will be recorded as captured on the toplevel
9005 CapturedContext, the inner captured context will not have anything
9006 (it will only have data if local variables or parameters from it
9007 are captured in a nested anonymous method.
9009 The ScopeInfo is used to track the activation frames for local
9010 variables, for example:
9012 for (int i = 0; i < 10; i++)
9013 for (int j = 0; j < 10; j++){
9014 MyDelegate d = delegate {
9019 At runtime this captures a single captured variable `i', but it
9020 captures 10 different versions of the variable `j'. The variable
9021 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
9022 recorded on a child.
9024 The toplevel ScopeInfo will also track information like the `this'
9025 pointer if instance variables were referenced (this is necessary
9026 as the anonymous method lives inside a nested class in the host
9027 type of the method).
9029 (AnonymousMethod): Expanded to track the Toplevel, implement
9030 `AnonymousMethod.Compatible' to tell whether an anonymous method
9031 can be converted to a target delegate type.
9033 The routine now also produces the anonymous method content
9035 (AnonymousDelegate): A helper class that derives from
9036 DelegateCreation, this is used to generate the code necessary to
9037 produce the delegate for the anonymous method that was created.
9039 * assign.cs: API adjustments for new changes in
9040 Convert.ImplicitStandardConversionExists.
9042 * class.cs: Adjustments to cope with the fact that now toplevel
9043 blocks are of type `ToplevelBlock'.
9045 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
9046 insteda of standard blocks.
9048 Flag errors if params arguments are passed to anonymous methods.
9050 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
9051 `CurrentAnonymousMethod' which points to the current Anonymous
9052 Method. The variable points to the AnonymousMethod class that
9053 holds the code being compiled. It is set in the new EmitContext
9054 created for the anonymous method.
9056 (EmitContext.Phase): Introduce a variable and an enumeration to
9057 assist in enforcing some rules about when and where we are allowed
9058 to invoke certain methods (EmitContext.NeedsReturnLabel is the
9059 only one that enfonces this right now).
9061 (EmitContext.HaveCaptureInfo): new helper method that returns
9062 whether we have a CapturedContext initialized.
9064 (EmitContext.CaptureVariable): New method used to register that a
9065 LocalInfo must be flagged for capturing.
9067 (EmitContext.CapturedParameter): New method used to register that a
9068 parameters must be flagged for capturing.
9070 (EmitContext.CapturedField): New method used to register that a
9071 field must be flagged for capturing.
9073 (EmitContext.HaveCapturedVariables,
9074 EmitContext.HaveCapturedFields): Return whether there are captured
9075 variables or fields.
9077 (EmitContext.EmitMethodHostInstance): This is used to emit the
9078 instance for the anonymous method. The instance might be null
9079 (static methods), this (for anonymous methods that capture nothing
9080 and happen to live side-by-side with the current method body) or a
9081 more complicated expression if the method has a CaptureContext.
9083 (EmitContext.EmitTopBlock): Routine that drives the emission of
9084 code: it will first resolve the top block, then emit any metadata
9085 and then emit the code. The split is done so that we can extract
9086 any anonymous methods and flag any captured variables/parameters.
9088 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
9089 during this phase, the ILGenerator should not be used as labels
9090 and local variables declared here might not be accessible to any
9091 code that is part of an anonymous method.
9093 Exceptions to this include the temporary variables that are
9094 created by some statements internally for holding temporary
9097 (EmitContext.EmitMeta): New routine, in charge of emitting all the
9100 (EmitContext.TemporaryReturn): This method is typically called
9101 from the Emit phase, and its the only place where we allow the
9102 ReturnLabel to be defined other than the EmitMeta. The reason is
9103 that otherwise we would have to duplicate a lot of logic in the
9104 Resolve phases of various methods that today is on the Emit
9107 (EmitContext.NeedReturnLabel): This no longer creates the label,
9108 as the ILGenerator is not valid during the resolve phase.
9110 (EmitContext.EmitThis): Extended the knowledge in this class to
9111 work in anonymous methods in addition to iterators.
9113 (EmitContext.EmitCapturedVariableInstance): This emits whatever
9114 code is necessary on the stack to access the instance to a local
9115 variable (the variable will be accessed as a field).
9117 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
9118 EmitContext.EmitAddressOfParameter): Routines to support
9119 parameters (not completed at this point).
9121 Removals: Removed RemapLocal and RemapLocalLValue. We probably
9122 will also remove the parameters.
9124 * convert.cs (Convert): Define a `ConstantEC' which points to a
9125 null. This is just to prefity some code that uses
9126 ImplicitStandardConversion code and do not have an EmitContext
9129 The idea is to flag explicitly that at that point in time, it is
9130 known that the conversion will not trigger the delegate checking
9131 code in implicit conversions (which requires a valid
9134 Everywhere: pass new EmitContext parameter since
9135 ImplicitStandardConversionExists now requires it to check for
9136 anonymous method conversions.
9138 (Convert.ImplicitStandardConversionExists): If the type of an
9139 expression is the anonymous_method_type, and the type is a
9140 delegate, we invoke the AnonymousMethod.Compatible method to check
9141 whether an implicit conversion is possible.
9143 (Convert.ImplicitConversionStandard): Only do implicit method
9144 group conversions if the language level is not ISO_1.
9146 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
9147 MethodInfo for the Invoke method. used by Delegate and
9150 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
9151 method conversions if the target type is a delegate.
9153 Removed extra debugging nops.
9155 (LocalVariableReference): Turn the `local_info' into a public
9158 Add `prepared' field, the same hack used for FieldExprs to cope
9159 with composed assignments, as Local variables do not necessarily
9160 operate purely on the stack as they used to: they can be captured
9163 Add `temp' for a temporary result, like fields.
9165 Refactor DoResolve and DoResolveLValue into DoResolveBase.
9167 It now copes with Local variables that are captured and emits the
9168 proper instance variable to load it from a field in the captured
9171 (ParameterReference.DoResolveBase): During the resolve phase,
9172 capture parameters if we are in an anonymous method.
9174 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
9175 anonymous method, use the EmitContext helper routines to emit the
9176 parameter reference.
9178 * iterators.cs: Set RemapToProxy to true/false during the
9181 * parameters.cs (GetParameterByName): New helper method.
9183 * typemanager.cs (anonymous_method_type) a new type that
9184 represents an anonyous method. This is always an internal type,
9185 used as a fencepost to test against the anonymous-methodness of an
9188 2004-10-20 Marek Safar <marek.safar@seznam.cz>
9190 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
9192 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
9194 2004-11-10 Martin Baulig <martin@ximian.com>
9196 * expression.cs (Invocation.BetterFunction): If two methods have
9197 equal parameter types, but only one of them is generic, the
9198 non-generic one wins.
9199 (New.DoResolve): Don't set `is_struct' to false if we're a generic
9200 instance; just use `Type.IsValueType' to determine whether
9201 something is a struct or not.
9202 (MemberAccess.DoResolveAsTypeStep): Don't modify the `args' field,
9203 so we can be called multiple times.
9205 2004-11-10 Martin Baulig <martin@ximian.com>
9207 * generic.cs (TypeParameter.DefineConstraints): New public method.
9208 (TypeParameter.CheckAccessLevel): Override this and return true.
9209 (ConstructedType.ResolveType): Renamed to DoResolveType(), don't
9210 override ResolveType() anymore.
9211 (ConstructedType.DoResolveAsTypeStep): Call DoResolveType() here.
9213 2004-11-10 Martin Baulig <martin@ximian.com>
9215 * rootcontext.cs (RootContext.LookupType): If we're a nested type,
9216 call DeclSpace.ResolveNestedType() on it.
9218 2004-11-10 Martin Baulig <martin@ximian.com>
9220 * support.cs (ReflectionParameters.ParameterModifier): If `gpd' is
9221 non-null, call ParameterModifier() on it.
9223 2004-11-10 Martin Baulig <martin@ximian.com>
9226 (Iterators): Added `current_type' and `this_type' fields.
9227 (Iterators.DefineIterator): Create a new EmitContext and store it
9228 in `ec'; compute `this_type'.
9230 2004-11-10 Martin Baulig <martin@ximian.com>
9233 (TypeManager.IsPrivateAccessible): New public method.
9234 (Closure.Filter): Use IsPrivateAccessible() instead of IsEqual().
9236 2004-11-10 Martin Baulig <martin@ximian.com>
9238 * class.cs (TypeContainer.DefineType): Call
9239 TypeBuilder.DefineGenericParameters() before resolving the type
9241 (MethodData.parent_method): New protected field.
9242 (MethodData..ctor): Added `MethodInfo parent_method' argument.
9243 (MethodData.Define): Compute `parent_method'.
9246 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
9247 (MemberCore.GetClsCompliantAttributeValue): Likewise.
9248 (DeclSpace.ec): New protected field; store the EmitContext here.
9249 (DeclSpace.EmitContext): New public property.
9250 (DeclSpace.ResolveType): Un-comment from the [Obsolte] attribute.
9251 (DeclSpace.ResolveNestedType): New public method.
9252 (DeclSpace.ResolveTypeExpr): Just call ResolveAsTypeTerminal() here.
9253 (DeclSpace.NestedAccessible): Added `Type tb' argument.
9254 (DeclSpace.FamilyAccessible): Likewise.
9255 (DeclSpace.FindType): Call ResolveNestedType() for nested types.
9256 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
9259 * delegate.cs (Delegate.Define): Store the EmitContext in the `ec'
9262 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
9263 (Enum.Emit): Don't create a new EmitContext.
9265 2004-10-18 Martin Baulig <martin@ximian.com>
9267 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
9268 `Type' directly, but call ResolveType() on it.
9269 (Catch.Resolve): Likewise.
9270 (Foreach.Resolve): Likewise.
9272 2004-10-18 Martin Baulig <martin@ximian.com>
9274 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
9275 `Type' directly, but call ResolveType() on it.
9276 (Probe.DoResolve): Likewise.
9277 (ArrayCreation.LookupType): Likewise.
9278 (TypeOf.DoResolve): Likewise.
9279 (SizeOf.DoResolve): Likewise.
9281 2004-10-18 Raja R Harinath <rharinath@novell.com>
9283 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
9286 2004-10-17 John Luke <john.luke@gmail.com>
9288 * class.cs (Operator.GetSignatureForError): use CSharpName
9290 * parameter.cs (Parameter.GetSignatureForError): Returns
9291 correct name even if was not defined.
9293 2004-10-13 Raja R Harinath <rharinath@novell.com>
9296 * class.cs (TypeContainer.EmitContext): New property.
9297 (DefineNestedTypes): Create an emitcontext for each part.
9298 (MethodCore.DoDefineParameters): Use container's emitcontext.
9299 Pass type array to InternalParameters.
9300 (MemberBase.DoDefine): Use container's emitcontext.
9301 (FieldMember.Define): Likewise.
9302 (Event.Define): Likewise.
9303 (SetMethod.GetParameterInfo): Change argument to EmitContext.
9304 Pass type array to InternalParameters.
9305 (SetIndexerMethod.GetParameterInfo): Likewise.
9306 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
9307 * delegate.cs (Define): Pass emitcontext to
9308 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
9309 array to InternalParameters.
9310 * expression.cs (ParameterReference.DoResolveBase): Pass
9311 emitcontext to GetParameterInfo.
9312 (ComposedCast.DoResolveAsTypeStep): Remove check on
9313 ec.ResolvingTypeTree.
9314 * parameter.cs (Parameter.Resolve): Change argument to
9315 EmitContext. Use ResolveAsTypeTerminal.
9316 (Parameter.GetSignature): Change argument to EmitContext.
9317 (Parameters.ComputeSignature): Likewise.
9318 (Parameters.ComputeParameterTypes): Likewise.
9319 (Parameters.GetParameterInfo): Likewise.
9320 (Parameters.ComputeAndDefineParameterTypes): Likewise.
9321 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
9322 * support.cs (InternalParameters..ctor): Remove variant that takes
9324 * typemanager.cs (system_intptr_expr): New.
9325 (InitExpressionTypes): Initialize it.
9327 2004-10-12 Chris Toshok <toshok@ximian.com>
9329 * cs-parser.jay: fix location for try_statement and catch_clause.
9331 2004-10-18 Martin Baulig <martin@ximian.com>
9333 * class.cs (FieldMember.Define): Don't access the TypeExpr's
9334 `Type' directly, but call ResolveType() on it.
9335 (MemberBase.DoDefine): Likewise.
9337 * expression.cs (New.DoResolve): Don't access the TypeExpr's
9338 `Type' directly, but call ResolveType() on it.
9339 (ComposedCast.DoResolveAsTypeStep): Likewise.
9341 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
9342 `Type' directly, but call ResolveType() on it.
9344 2004-10-17 John Luke <john.luke@gmail.com>
9346 * class.cs (Operator.GetSignatureForError): use CSharpName
9348 * parameter.cs (Parameter.GetSignatureForError): Returns
9349 correct name even if was not defined.
9351 2004-10-13 Raja R Harinath <rharinath@novell.com>
9354 * class.cs (TypeContainer.EmitContext): New property.
9355 (DefineNestedTypes): Create an emitcontext for each part.
9356 (MethodCore.DoDefineParameters): Use container's emitcontext.
9357 Pass type array to InternalParameters.
9358 (MemberBase.DoDefine): Use container's emitcontext.
9359 (FieldMember.Define): Likewise.
9360 (Event.Define): Likewise.
9361 (SetMethod.GetParameterInfo): Change argument to EmitContext.
9362 Pass type array to InternalParameters.
9363 (SetIndexerMethod.GetParameterInfo): Likewise.
9364 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
9365 * delegate.cs (Define): Pass emitcontext to
9366 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
9367 array to InternalParameters.
9368 * expression.cs (ParameterReference.DoResolveBase): Pass
9369 emitcontext to GetParameterInfo.
9370 (ComposedCast.DoResolveAsTypeStep): Remove check on
9371 ec.ResolvingTypeTree.
9372 * parameter.cs (Parameter.Resolve): Change argument to
9373 EmitContext. Use ResolveAsTypeTerminal.
9374 (Parameter.GetSignature): Change argument to EmitContext.
9375 (Parameters.ComputeSignature): Likewise.
9376 (Parameters.ComputeParameterTypes): Likewise.
9377 (Parameters.GetParameterInfo): Likewise.
9378 (Parameters.ComputeAndDefineParameterTypes): Likewise.
9379 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
9380 * support.cs (InternalParameters..ctor): Remove variant that takes
9382 * typemanager.cs (system_intptr_expr): New.
9383 (InitExpressionTypes): Initialize it.
9385 2004-10-12 Chris Toshok <toshok@ximian.com>
9387 * cs-parser.jay: fix location for try_statement and catch_clause.
9389 2004-10-07 Raja R Harinath <rharinath@novell.com>
9391 More DeclSpace.ResolveType avoidance.
9392 * decl.cs (MemberCore.InUnsafe): New property.
9393 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
9394 with newly created EmitContext.
9395 (FieldMember.Define): Likewise.
9396 * delegate.cs (Delegate.Define): Likewise.
9397 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
9398 only if normal name-lookup fails.
9399 (TypeExpr.DoResolve): Enable error-checking.
9400 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
9401 (SizeOf.DoResolve): Likewise.
9402 (ComposedCast.DoResolveAsTypeStep): Likewise.
9403 (StackAlloc.DoResolve): Likewise.
9404 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
9405 (Block.Unsafe): New property.
9406 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
9407 (Unsafe): Set 'unsafe' flag of contained block.
9408 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
9409 (Fixed.Resolve): Likewise.
9410 (Catch.Resolve): Likewise.
9411 (Using.ResolveLocalVariableDecls): Likewise.
9412 (Foreach.Resolve): Likewise.
9414 2004-10-05 John Luke <john.luke@gmail.com>
9416 * cs-parser.jay: add location to error CS0175
9418 2004-10-04 Miguel de Icaza <miguel@ximian.com>
9420 * ecore.cs (Expression.Constantity): Add support for turning null
9423 * const.cs (Const.Define): Allow constants to be reference types
9424 as long as the value is Null.
9426 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
9428 * namespace.cs (NamespaceEntry.Using): No matter which warning
9429 level is set, check if this namespace name has already been added.
9431 2004-10-03 Ben Maurer <bmaurer@ximian.com>
9433 * expression.cs: reftype [!=]= null should always use br[true,false].
9436 2004-10-03 Marek Safar <marek.safar@seznam.cz>
9439 * attribute.cs: Enum conversion moved to
9440 GetAttributeArgumentExpression to be applied to the all
9443 2004-10-01 Raja R Harinath <rharinath@novell.com>
9445 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
9446 * class.c (TypeContainer.DefineType): Flag error if
9447 base types aren't accessible due to access permissions.
9448 * decl.cs (DeclSpace.ResolveType): Move logic to
9449 Expression.ResolveAsTypeTerminal.
9450 (DeclSpace.ResolveTypeExpr): Thin layer over
9451 Expression.ResolveAsTypeTerminal.
9452 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
9453 Refactor code into NestedAccess. Use it.
9454 (DeclSpace.NestedAccess): New.
9455 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
9456 argument to silence errors. Check access permissions.
9457 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
9458 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
9459 (Cast.DoResolve): Likewise.
9460 (New.DoResolve): Likewise.
9461 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
9462 (TypeOf.DoResolve): Likewise.
9464 * expression.cs (Invocation.BetterConversion): Return the Type of
9465 the better conversion. Implement section 14.4.2.3 more faithfully.
9466 (Invocation.BetterFunction): Make boolean. Make correspondence to
9467 section 14.4.2.2 explicit.
9468 (Invocation.OverloadResolve): Update.
9469 (Invocation): Remove is_base field.
9470 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
9471 (Invocation.Emit): Likewise.
9473 2004-09-24 Marek Safar <marek.safar@seznam.cz>
9475 * cs-parser.jay: Reverted 642 warning fix.
9477 2004-09-23 Marek Safar <marek.safar@seznam.cz>
9480 * decl.cs (FindMemberWithSameName): Indexer can have more than
9483 2004-09-23 Marek Safar <marek.safar@seznam.cz>
9485 * expression.cs (LocalVariableReference.DoResolveLValue):
9486 Do not report warning 219 for out values.
9487 (EmptyExpression.Null): New member to avoid extra allocations.
9489 2004-09-23 Marek Safar <marek.safar@seznam.cz>
9491 * cs-parser.jay: Fix wrong warning 642 report.
9493 * cs-tokenizer.cs (CheckNextToken): New helper;
9494 Inspect next character if is same as expected.
9496 2004-09-23 Martin Baulig <martin@ximian.com>
9498 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
9499 (Convert.ImplicitReferenceConversionExists): Likewise.
9501 2004-11-09 Raja R Harinath <rharinath@novell.com>
9503 * Makefile (DISTFILES): Comment out a few missing files.
9505 2004-10-29 Raja R Harinath <rharinath@novell.com>
9507 * Makefile (bootstrap_libs,bootstrap_libfiles): New.
9508 (bootstrap-libs): New target. Invokes the net_2_0_bootstrap profile.
9509 (gmcs.exe): Invoke bootstrap-libs.
9510 (clean-local): Clean the net_2_0_bootstrap profile too.
9511 (PROGRAM_INSTALL_DIR): New.
9512 (install-local): Use it.
9514 2004-10-13 Martin Baulig <martin@ximian.com>
9516 * generic.cs (TypeManager.InflatedConstraints): New nested class.
9517 (TypeParameter.DefineType): If we're a method type parameter and
9518 that method is overriding something, "inflate" its constraints.
9520 2004-10-12 Martin Baulig <martin@ximian.com>
9522 * expression.cs (MemberAccess.DoResolve): If we're a SimpleName
9523 and have type arguments, create and resolve a ConstructedType.
9525 2004-10-12 Martin Baulig <martin@ximian.com>
9527 * decl.cs (MemberCache.FindMemberToOverride): Use
9528 TypeManager.IsEqual() to compare the parameters and Type.Equals()
9529 to compare the invocationType.
9531 * typemanager.cs (TypeManager.IsEqual): Added support for arrays.
9532 When comparing two type parameters, only do the signature-only
9533 comparision for method type parameters.
9535 2004-10-11 Martin Baulig <martin@ximian.com>
9537 * report.cs: Don't make --fatal abort on warnings, we have
9538 -warnaserror for that.
9540 2004-10-11 Martin Baulig <martin@ximian.com>
9543 (TypeManager.IsEqualGenericType): Removed, use IsEqual() instead.
9544 (TypeManager.IsEqual): Call ourself recursively instead of using
9547 2004-10-11 Martin Baulig <martin@ximian.com>
9549 * class.cs (TypeContainer.DefineType): Only call TypeParameter.Define()
9550 on our own type parameters, not on the ones we inherit from a containing
9553 * expression.cs (Invocation.InferType): Use `==', not `Equals()' for
9556 * generic.cs (TypeParameter.Define): We may only be called once.
9558 * pending.cs (Pending.InterfaceMethod): Call TypeManager.Real_IsEqual()
9559 instead of TypeManager.IsEqual().
9561 2004-09-28 Martin Baulig <martin@ximian.com>
9564 (GenericConstraints.EffectiveBaseClass): New public property.
9565 (TypeParameter.GenericConstraints): New public property.
9566 (ConstructedType.CheckConstraints): Improved.
9568 * convert.cs (Convert.TypeParam_EffectiveBaseType): New private method.
9569 (Convert.TypeParameterConversion): New private method; use this in
9570 ImplicitReferenceConversion() and ImplicitReferenceConversionExists()
9571 for all conversions related to type parameters.
9573 2004-09-24 Martin Baulig <martin@ximian.com>
9575 * convert.cs (Convert.ImplicitReferenceConversion): Added implicit
9576 type parameter conversions for type parameters which are known to
9579 2004-09-24 Martin Baulig <martin@ximian.com>
9581 * generic.cs (GenericConstraints): Added `IsReferenceType' and
9582 `IsValueType' properties.
9584 * support.cs (ReflectionConstraints): Use
9585 Type.GetGenericParameterConstraints() instead of the old hack.
9587 2004-09-24 Martin Baulig <martin@ximian.com>
9589 * generic.cs (GenericConstraints): Moved here and made it an
9592 * support.cs (GenericConstraints): Moved to generic.cs.
9594 2004-09-24 Martin Baulig <martin@ximian.com>
9597 (ReflectionConstraints): Un-nested this class and made it public.
9600 (TypeManager.GetTypeParameterConstraints): New public method.
9601 (TypeManager.HasConstructorConstraint): Use the attributes.
9603 2004-09-24 Martin Baulig <martin@ximian.com>
9605 * support.cs (GenericConstraints): Replaced `HasConstructor',
9606 `IsReferenceType' and `IsValueType' with `Attributes'.
9607 (ReflectionParameters.ReflectionConstraints): Removed the Create()
9608 method and made the .ctor public.
9610 * generic.cs (Constraints.Attributes): New public property.
9611 (Constraints): Renamed `HasConstructor' -> `HasConstructorConstraint',
9612 `IsReferenceType' -> `HasReferenceTypeConstraint' and
9613 `IsValueType' -> `HasValueTypeConstraint'.
9615 2004-09-23 Martin Baulig <martin@ximian.com>
9617 * generic.cs (Constraints): Reflect latest runtime changes.
9619 2004-09-23 Martin Baulig <martin@ximian.com>
9621 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
9622 (Convert.ImplicitReferenceConversionExists): Likewise.
9624 2004-09-23 Marek Safar <marek.safar@seznam.cz>
9626 * class.cs (Operator.Define): Add error 448 and 559 report.
9628 2004-09-22 Marek Safar <marek.safar@seznam.cz>
9630 * class.cs (MemberBase.IsTypePermitted): New protected
9631 method for checking error CS0610.
9633 2004-09-22 Marek Safar <marek.safar@seznam.cz>
9635 * class.cs (TypeContainer.HasExplicitLayout): New property
9636 Returns whether container has StructLayout attribute set Explicit.
9637 (FieldMember): New abstract class for consts and fields.
9638 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
9639 (Field): Reuse FieldMember.
9641 * const.cs (Const): Reuse FieldMember.
9643 * rootcontext.cs: EmitConstants call moved to class.
9645 2004-09-22 Martin Baulig <martin@ximian.com>
9647 Marek and me just fixed one of our oldest bugs: #28562 :-)
9649 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
9651 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
9652 we're an EnumConstant, just return that.
9653 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
9654 an EnumConstant. In this case, we need to use GetValueAsEnumType()
9655 to get the value which'll actually be written into the attribute.
9656 However, we have to use GetValue() to access the attribute's value
9659 2004-09-22 Marek Safar <marek.safar@seznam.cz>
9661 * constant.cs (Constant.IsNegative): New abstract property
9664 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
9665 (StackAlloc.DoResolve): Reused IsNegative.
9667 2004-09-22 Martin Baulig <martin@ximian.com>
9669 * typemanager.cs (TypeManager.LookupGenericTypeContainer): New
9670 public method; like LookupTypeContainer, but also works for
9673 * report.cs (Report.SymbolRelatedToPreviousError): Use
9674 TypeManager.LookupGenericTypeContainer().
9676 2004-09-22 Martin Baulig <martin@ximian.com>
9678 Thanks to Peter Sestoft for this bug report.
9680 * expression.cs (Conditional): If both the `trueExpr' and the
9681 `falseExpr' is a NullLiteral, return a NullLiteral.
9683 2004-09-22 Martin Baulig <martin@ximian.com>
9685 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
9686 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
9687 for the "get_Current" call.
9689 2004-09-21 Martin Baulig <martin@ximian.com>
9691 * convert.cs (Convert.ImplicitReferenceConversion): When
9692 converting to an interface type, first check whether we're
9693 converting from a reference type.
9695 2004-09-14 Martin Baulig <martin@ximian.com>
9697 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
9699 2004-09-14 Marek Safar <marek.safar@seznam.cz>
9702 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
9703 called and is obsolete then this member suppress message
9704 when call is inside next [Obsolete] method or type.
9706 * expression.cs: Use TestObsoleteMethodUsage member.
9708 2004-09-14 Martin Baulig <martin@ximian.com>
9710 * genericparser.cs: Removed.
9712 2004-09-13 Marek Safar <marek.safar@seznam.cz>
9714 * class.cs (MethodCore.CheckBase): Fix bug #65757.
9716 2004-09-12 Marek Safar <marek.safar@seznam.cz>
9718 * attribute.cs (Attribute.Resolve): Add error 653 report.
9720 * class.cs (Class.ApplyAttributeBuilder): Add error 641
9722 (Method.ApplyAttributeBuilder): Add error 685 report.
9723 (Operator.Define): Add error 564 report.
9725 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
9727 * expression.cs (Invocation.DoResolve): Add error
9730 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
9733 2004-09-11 Marek Safar <marek.safar@seznam.cz>
9735 * class.cs (ConstructorInitializer.Resolve):
9736 Wrong error number (515->516).
9738 2004-09-11 Marek Safar <marek.safar@seznam.cz>
9740 * class.cs (Indexer.Define): Add error 631 report.
9742 2004-09-11 Marek Safar <marek.safar@seznam.cz>
9744 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
9746 2004-09-11 Marek Safar <marek.safar@seznam.cz>
9748 * expression.cs (Probe.DoResolve): Add error CS0241 report.
9750 2004-09-10 Marek Safar <marek.safar@seznam.cz>
9752 * cs-parser.jay: Added error CS0241 report.
9754 2004-09-10 Raja R Harinath <rharinath@novell.com>
9756 * cs-parser.jay (fixed_statement): Introduce a scope for the
9757 declaration in the 'fixed' statement.
9759 2004-09-09 Marek Safar <marek.safar@seznam.cz>
9761 * cs-parser.jay: Added CS0230 error report.
9763 2004-09-09 Marek Safar <marek.safar@seznam.cz>
9765 * cs-parser.jay: Added errors CS0231 and CS0257 report.
9767 2004-09-09 Marek Safar <marek.safar@seznam.cz>
9769 * expression.cs (Argument.Resolve): Added error CS0192 and
9772 2004-09-09 Marek Safar <marek.safar@seznam.cz>
9774 C# 2.0 #pragma warning feature
9776 * cs-tokenizer.cs (PreProcessPragma): New method;
9777 Handles #pragma directive.
9779 * report.cs (WarningRegions): New class; Support
9780 class for #pragma warning directive. It tests whether
9781 warning is enabled for a given line.
9783 2004-09-08 Miguel de Icaza <miguel@ximian.com>
9785 * const.cs: Add more descriptive error report, tahnks to
9788 2004-09-08 Marek Safar <marek.safar@seznam.cz>
9790 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
9792 2004-09-07 Miguel de Icaza <miguel@ximian.com>
9794 * expression.cs: Apply patch from Ben: Remove dead code from
9795 ArrayCreation, and remove the TurnintoConstant call in const.cs,
9796 as that code just threw an exception anwyays.
9798 * const.cs: Remove the call to the turnintoconstant, for details
9801 * literal.cs: The type of the null-literal is the null type; So
9802 we use a placeholder type (literal.cs:System.Null, defined here)
9805 * expression.cs (Conditional.DoResolve): Remove some old code that
9806 is no longer needed, conversions have been fixed.
9808 (ArrayCreationExpression.DoResolve): Return false if we fail to
9809 resolve the inner expression.
9811 2004-09-07 Raja R Harinath <rharinath@novell.com>
9814 * cs-parser.jay (delegate_declaration): Record a delegate
9815 declaration as a type declaration.
9816 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
9818 2004-09-06 Miguel de Icaza <miguel@ximian.com>
9820 * parameter.cs: Do not crash if the type can not be resolved.
9822 * expression.cs: Report errors with unsafe pointers, fixes #64896
9824 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
9826 * expression.cs: Pointer arith always needs to do a conv.i
9827 if the operand is a long. fix 65320
9829 2004-09-04 Marek Safar <marek.safar@seznam.cz>
9831 Fixed cs0619-37.cs, cs0619-38.cs
9833 * enum.cs (GetObsoleteAttribute): Removed.
9835 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
9836 on Enum member is double staged. The first is tested member
9839 2004-09-04 Marek Safar <marek.safar@seznam.cz>
9841 Fixed #56986, #63631, #65231
9843 * class.cs: (TypeContainer.AddToMemberContainer): New method,
9844 adds member to name container.
9845 (TypeContainer.AddToTypeContainer): New method, adds type to
9847 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
9848 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
9849 AddOperator): Simplified by reusing AddToMemberContainer.
9850 (TypeContainer.UserDefinedStaticConstructor): Changed to property
9852 (Method.CheckForDuplications): Fixed implementation to test all
9854 (MemberBase): Detection whether member is explicit interface
9855 implementation is now in constructor.
9856 (MemberBase.UpdateMemberName): Handles IndexerName.
9857 (Accessor): Changed to keep also location information.
9858 (AbstractPropertyEventMethod): Is derived from MemberCore.
9859 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
9860 will be emited or not.
9861 (PropertyBase.AreAccessorsDuplicateImplementation):
9862 Tests whether accessors are not in collision with some method.
9863 (Operator): Is derived from MethodCore to simplify common
9866 * decl.cs (Flags.TestMethodDuplication): Test for duplication
9868 (DeclSpace.AddToContainer): Adds the member to defined_names
9869 table. It tests for duplications and enclosing name conflicts.
9871 * enum.cs (EnumMember): Clean up to reuse the base structures
9873 2004-09-03 Martin Baulig <martin@ximian.com>
9875 Merged latest changes into gmcs. Please keep this comment in
9876 here, it makes it easier for me to see what changed in MCS since
9877 the last time I merged.
9879 2004-09-03 Martin Baulig <martin@ximian.com>
9881 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
9882 into TypeContainer, to make partial classes work again.
9884 2004-09-03 Martin Baulig <martin@ximian.com>
9886 * rootcontext.cs (RootContext.V2): Removed.
9888 2004-03-23 Martin Baulig <martin@ximian.com>
9890 * expression.cs (Invocation.OverloadResolve): Added `bool
9891 may_fail' argument and use it instead of the Location.IsNull() hack.
9893 2004-09-09 Martin Baulig <martin@ximian.com>
9895 * cs-parser.jay (namespace_declaration): Fixed CS0134 reporting.
9897 2004-09-09 Martin Baulig <martin@ximian.com>
9899 * generic.cs (TypeParameter.DefineType): Added support for
9900 explicit interface methods.
9902 2004-09-09 Martin Baulig <martin@ximian.com>
9904 * README.Changes: New document. Started to list important changes
9905 between MCS and GMCS here.
9907 2004-09-08 Martin Baulig <martin@ximian.com>
9910 (TypeContainer.CheckRecursiveDefinition): New protected method.
9911 (TypeContainer.DefineType): Move the CS0146 check into
9912 CheckRecursiveDefinition().
9914 2004-09-06 Martin Baulig <martin@ximian.com>
9916 * generic.cs (ConstructedType.CheckConstraints): Allow builtin
9917 types for the constructor constraint.
9919 2004-09-03 Martin Baulig <martin@ximian.com>
9921 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
9922 into TypeContainer, to make partial classes work again.
9924 2004-09-03 Martin Baulig <martin@ximian.com>
9926 * rootcontext.cs (RootContext.V2): Removed.
9928 2004-03-23 Martin Baulig <martin@ximian.com>
9930 * expression.cs (Invocation.OverloadResolve): Added `bool
9931 may_fail' argument and use it instead of the Location.IsNull() hack.
9933 2004-09-03 Martin Baulig <martin@ximian.com>
9935 Merged latest changes into gmcs. Please keep this comment in
9936 here, it makes it easier for me to see what changed in MCS since
9937 the last time I merged.
9939 2004-09-03 Raja R Harinath <rharinath@novell.com>
9942 * expression.cs (BetterConversion): Don't allow either conversion
9943 to be null. Remove redundant implicit conversion test when 'q ==
9944 null' -- when this function is invoked, we already know that the
9945 implicit conversion exists.
9946 (BetterFunction): Assume that 'best' is non-null. Remove
9947 redundant reimplementation of IsApplicable when 'best' is null.
9948 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
9949 number of arguments.
9950 (IsAncestralType): Extract from OverloadResolve.
9951 (OverloadResolve): Make robust to the MethodGroupExpr being
9952 unsorted. Implement all the logic of Section 14.5.5.1, and
9953 support overloading of methods from multiple applicable types.
9954 Clean up logic somewhat. Don't pass null methods to BetterFunction.
9956 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
9957 (RealError, Warning): Append type of report to related symbol.
9959 2004-09-03 Marek Safar <marek.safar@seznam.cz>
9961 * enum.cs: Fixed CLS-Compliance checks for enum members.
9962 Error tests cs3008-8.cs, cs3014-8.cs
9964 2004-09-02 Marek Safar <marek.safar@seznam.cz>
9966 Fixed bug #62342, #63102
9967 * class.cs: ImplementIndexer uses member.IsExplicitImpl
9968 like ImplementMethod.
9970 2004-09-02 Marek Safar <marek.safar@seznam.cz>
9972 * attribute.cs (Attribute.GetAttributeArgumentExpression):
9975 2004-09-02 Martin Baulig <martin@ximian.com>
9977 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
9978 TypeManager.GetArgumentTypes() rather than calling GetParameters()
9981 2004-09-01 Marek Safar <marek.safar@seznam.cz>
9983 C# 2.0 Static classes implemented
9985 * class.cs (TypeContainer): instance_constructors,
9986 initialized_fields, initialized_static_fields,
9987 default_constructor, base_inteface_types are protected to be
9988 accessible from StaticClass.
9989 (TypeContainer.DefineDefaultConstructor): New virtual method
9990 for custom default constructor generating
9991 (StaticClass): New class to handle "Static classes" feature.
9993 * cs-parser.jay: Handle static keyword on class like instance
9996 * driver.cs: Added "/langversion" command line switch with two
9997 options (iso-1, default).
9999 2004-08-31 Marek Safar <marek.safar@seznam.cz>
10001 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
10003 2004-08-31 Miguel de Icaza <miguel@ximian.com>
10005 * delegate.cs: Style.
10007 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
10009 * delegate.cs: Add seperate instance expr field for miguel.
10011 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
10013 * PointerArithmetic (Resolve): make sure we are not doing
10014 pointer arith on void*. Also, make sure we are resolved
10015 by not setting eclass until resolve.
10017 All callers: Make sure that PointerArithmetic gets resolved.
10019 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
10021 * ArrayCreation (LookupType): If the type does not resolve
10022 to an array, give an error.
10024 2004-08-27 Marek Safar <marek.safar@seznam.cz>
10026 * statement.cs (Try.Resolve): Fixed bug #64222
10028 2004-08-27 Martin Baulig <martin@ximian.com>
10031 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
10034 2004-08-26 Marek Safar <marek.safar@seznam.cz>
10036 * ecore.cs (Constantify): Get underlying type via
10037 System.Enum.GetUnderlyingType to avoid StackOverflow on the
10038 Windows in special cases.
10040 2004-08-26 Marek Safar <marek.safar@seznam.cz>
10042 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
10043 for obtaining also private methods.
10044 (GetRemoveMethod): Used GetRemoveMethod (true)
10045 for obtaining also private methods.
10047 2004-09-02 Martin Baulig <martin@ximian.com>
10049 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
10050 TypeManager.GetArgumentTypes() rather than calling GetParameters()
10053 2004-08-27 Martin Baulig <martin@ximian.com>
10056 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
10059 2004-08-25 Martin Baulig <martin@ximian.com>
10061 * support.cs (ReflectionParameters..ctor): If this is a generic
10062 method, retrieve and store its type parameters.
10063 (InternalParameters..ctor): Added `TypeParameter[]' argument.
10064 (ReflectionParameters.GenericConstraints): The argument specifies
10065 the type parameter, not the method parameter.
10066 (InternalParameters.GenericConstraints): Likewise.
10068 * generic.cs (TypeParameter.DefineType): Correctly handle
10069 constraints wrt. generic methods in interfaces and their
10072 2004-08-24 Martin Baulig <martin@ximian.com>
10074 * generic.cs (TypeParameter.IsSubclassOf): New public method.
10075 (Constraints.IsSubclassOf): New internal method.
10077 * typemanager.cs (TypeManager.FindMembers): Added special support
10078 for GenericTypeParameterBuilder's.
10079 (TypeManager.IsSubclassOf, IsFamilyAccessible): Added support for
10082 2004-08-24 Martin Baulig <martin@ximian.com>
10085 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
10086 this for accessibility checks.
10087 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
10088 IsNestedFamilyAccessible.
10089 (TypeManager.IsSubclassOf): New method, do what the name actually
10092 2004-08-24 Martin Baulig <martin@ximian.com>
10094 * expression.cs (MemberAccess.DoResolve): When resolving ourselves
10095 as a SimpleName, include the generic arity.
10097 2004-08-24 Martin Baulig <martin@ximian.com>
10099 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
10100 MethodAttributes.HideBySig for operators.
10102 2004-08-23 Martin Baulig <martin@ximian.com>
10104 Back to the old error reporting system :-)
10106 * report.cs (Message): Removed.
10107 (Report.MessageData, ErrorData, WarningData): Removed.
10108 (Report.Error, Warning): Back to the old system.
10110 2004-08-23 Martin Baulig <martin@ximian.com>
10112 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
10114 * class.cs (TypeContainer.ParentContainer): New public virtual
10115 method; replaces the explicit interface implementation.
10116 (ClassPart.ParentContainer): Override.
10118 2004-08-23 Martin Baulig <martin@ximian.com>
10120 * statement.cs (Switch): Added support for constant switches; see
10121 #59428 or test-285.cs.
10123 2004-08-22 Marek Safar <marek.safar@seznam.cz>
10126 * statement.cs (GetEnumeratorFilter): Removed useless
10127 logic because C# specs is strict. GetEnumerator must be
10130 2004-08-22 Martin Baulig <martin@ximian.com>
10132 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
10133 a switch and may break, reset the barrier. Fixes #59867.
10135 2004-08-22 Marek Safar <marek.safar@seznam.cz>
10137 CLS-Compliance speed up (~5% for corlib)
10139 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
10140 New method. Tests container for CLS-Compliant names
10142 * class.cs (TypeContainer.VerifyClsName): New method.
10143 Checks whether container name is CLS Compliant.
10144 (Constructor): Implements IMethodData.
10146 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
10147 low-case table for CLS Compliance test.
10148 (MemberCache.VerifyClsParameterConflict): New method.
10149 Checks method parameters for CS3006 error.
10151 * enum.cs (EnumMember): Is derived from MemberCore.
10152 (Enum.VerifyClsName): Optimized for better performance.
10154 2004-08-06 Marek Safar <marek.safar@seznam.cz>
10156 * report.cs: Renamed Error_T to Error and changed all
10159 2004-08-06 Marek Safar <marek.safar@seznam.cz>
10161 * class.cs (TypeContainer.IndexerArrayList): New inner class
10162 container for indexers.
10163 (TypeContainer.DefaultIndexerName): New constant for default
10164 indexer name. Replaced all "Item" with this constant.
10165 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
10167 * typemanager.cs (TypeManager.default_member_ctor): Cache here
10168 DefaultMemberAttribute constructor.
10170 2004-08-05 Martin Baulig <martin@ximian.com>
10172 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
10175 2004-08-05 Marek Safar <marek.safar@seznam.cz>
10177 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
10178 multi platforms problem.
10180 * compiler.csproj: Included shared files.
10182 2004-08-04 Marek Safar <marek.safar@seznam.cz>
10184 Fix bug 60333, 55971 in the more general way
10185 * attribute.cs (Attribute.GetAttributeArgumentExpression):
10186 Added arg_type argument for constant conversion.
10187 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
10189 2004-08-04 Marek Safar <marek.safar@seznam.cz>
10192 * class.cs (TypeContainer ): New inner classes MethodArrayList,
10193 OperatorArrayList, MethodCoreArrayList for typecontainer
10194 containers. Changed class member types to these new types.
10195 (MethodArrayList.DefineMembers): Added test for CS0659.
10197 2004-08-04 Miguel de Icaza <miguel@ximian.com>
10199 * cfold.cs: Synchronize the folding with the code in expression.cs
10200 Binary.DoNumericPromotions for uint operands.
10202 * attribute.cs: Revert patch from Raja, it introduced a regression
10203 while building Blam-1.2.1 (hard to isolate a test case).
10205 2004-08-04 Marek Safar <marek.safar@seznam.cz>
10209 (TypeContainer.Define): Renamed to DefineContainerMembers because of
10211 (MethodCore.parent_method): New member. The method we're overriding
10212 if this is an override method.
10213 (MethodCore.CheckBase): Moved from Method class and made common.
10214 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
10216 (MethodCore.CheckForDuplications): New abstract method. For custom
10217 member duplication search in a container
10218 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
10219 method and its return type.
10220 (Event.conflict_symbol): New member. Symbol with same name in the
10224 (MemberCache.FindMemberWithSameName): New method. The method
10225 is looking for conflict with inherited symbols.
10227 2004-08-04 Martin Baulig <martin@ximian.com>
10229 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
10231 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
10233 2004-08-03 Marek Safar <marek.safar@seznam.cz>
10235 * report.cs (Message): New enum for better error, warning reference in
10237 (MessageData): New inner abstract class. It generally handles printing of
10238 error and warning messages.
10239 Removed unused Error, Warning, Message methods.
10241 2004-08-03 Marek Safar <marek.safar@seznam.cz>
10243 Fix for cs0592-8.cs test
10245 (Attributable.ValidAttributeTargets): Made public.
10246 (Attribute.ExplicitTarget): New member for explicit target value.
10247 (Attribute.CheckTargets): Now we translate explicit attribute
10248 target to Target here.
10250 2004-08-03 Ben Maurer <bmaurer@ximian.com>
10252 * ecore.cs (MethodGroupExpr): new IsBase property.
10254 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
10256 * delegate.cs (DelegateCreation): store a MethodGroupExpr
10257 rather than an instance expr.
10259 (DelegateCreation.Emit): Use the method group rather than
10260 the instance expression. Also, if you have base.Foo as the
10261 method for a delegate, make sure to emit ldftn, not ldftnvirt.
10263 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
10265 (NewDelegate.DoResolve): Only check for the existance of Invoke
10266 if the method is going to be needed. Use MethodGroupExpr.
10268 (NewDelegate.Emit): Remove, DelegateCreation implements this.
10270 * expression.cs: For pointer arith., make sure to use
10271 the size of the type, not the size of the pointer to
10274 2004-08-03 Marek Safar <marek.safar@seznam.cz>
10277 * class.cs (Class): Added error CS0502 test.
10279 2004-08-03 John Luke <jluke@cfl.rr.com>
10280 Raja R Harinath <rharinath@novell.com>
10283 * attribute.cs (Attribute.complained_before): New flag.
10284 (Attribute.ResolveType, Attribute.Resolve),
10285 (Attribute.DefinePInvokeMethod): Set it.
10286 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
10288 2004-08-03 Martin Baulig <martin@ximian.com>
10290 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
10291 use a user-defined operator; we still need to do numeric
10292 promotions in case one argument is a builtin type and the other
10293 one has an implicit conversion to that type. Fixes #62322.
10295 2004-08-18 Martin Baulig <martin@ximian.com>
10297 * class.cs (Method.Define): Use the correct method name when
10298 creating the MethodBuilder for a generic method.
10300 2004-08-17 Martin Baulig <martin@ximian.com>
10302 * generic.cs (Constraints): Support type parameter constraints.
10304 2004-08-16 Martin Baulig <martin@ximian.com>
10306 * cs-tokenizer.cs (Tokenizer.TypeOfParsing): New public property.
10307 (Token.GENERIC_DIMENSION): New token; this is returned if we
10308 encounter an unbound generic type in a typeof() expression.
10310 * cs-parser.jay (opt_type_argument_list): Added GENERIC_DIMENSION;
10311 this token is only generated while parsing a typeof() expression.
10312 (typeof_expression): Removed the old unbound_type hack.
10314 * generic.cs (TypeArguments.IsUnbound): New public property.
10316 * decl.cs (MemberName): Added support for unbound types.
10318 2004-08-14 Martin Baulig <martin@ximian.com>
10321 (TypeManager.IsEqualGenericInstance): New static method.
10322 (TypeManager.IsSubclassOrNestedChildOf, IsSubclassOf): This is
10323 just used to check accessibility, so follow the rules of 26.1.6.
10325 * expression.cs (MemberAccess.ResolveAsTypeStep): Return a
10326 ConstructedType instead of a TypeExpression if we have type arguments.
10328 * cs-parser.jay (typeof_expression): Support unbound generic types.
10330 * ecore.cs (UnboundTypeExpression): New public class.
10332 2004-08-12 Martin Baulig <martin@ximian.com>
10334 * typemanager.cs (TypeManager.IsNestedChildOf): Use
10335 TypeManager.IsEqual() rather than `=='.
10337 * decl.cs (DeclSpace.CheckAccessLevel): Use `tb.FullName' for
10338 generic instances as well.
10340 2004-08-12 Martin Baulig <martin@ximian.com>
10342 * expression.cs (Invocation.InferType): We can only infer method
10343 type parameters. Fixes #62647.
10345 2004-08-11 Martin Baulig <martin@ximian.com>
10347 * class.cs (TypeContainer.DefineType): Create the TypeBuilder
10348 before resolving the base classes.
10350 2004-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10352 * Makefile: install .mdb file too.
10354 2004-08-05 Martin Baulig <martin@ximian.com>
10356 * ecore.cs (FieldExpr.DoResolveLValue): If we're resolving a field
10357 initializer, the current type is just the TypeBuilder, not the
10358 instantiated generic type.
10359 (FieldExpr.IsFieldInitializer): New public property.
10361 2004-08-04 Martin Baulig <martin@ximian.com>
10363 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
10365 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
10367 2004-08-03 Martin Baulig <martin@ximian.com>
10369 * class.cs (MethodData.Define): If we're an explicit
10370 implementation, remove the generic arity from the type name.
10372 2004-08-03 Martin Baulig <martin@ximian.com>
10374 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
10375 use a user-defined operator; we still need to do numeric
10376 promotions in case one argument is a builtin type and the other
10377 one has an implicit conversion to that type. Fixes #62322.
10379 2004-08-02 Martin Baulig <martin@ximian.com>
10381 * class.cs (TypeContainer.ifaces): Make this a `Type[]', not a
10382 `TypeExpr[]' array.
10383 (TypeContainer.GetClassBases): Return the unexpanded list of
10384 interfaces; we expand them later.
10385 (TypeContainer.DefineType): After creating the TypeBuilder, call
10386 TypeManager.ExpandInterfaces() to get an expanded and resolved
10387 list of interfaces.
10389 * ecore.cs (TypeExpr.GetInterfaces): Removed
10391 * generics.cs (Constraints.InterfaceConstraints): Remove.
10392 (TypeParameter.DefineType): Call TypeManager.RegisterBuilder() to
10393 register the interface constraints.
10396 (TypeManager.AddUserType): Removed the `ifaces' argument.
10397 (TypeManager.AddTypeParameter): Likewise.
10398 (TypeManager.AddUserInterface): Removed, was unused.
10399 (TypeManager.RegisterBuilder): Take a `Type[]' instead of a
10400 `TypeExpr[]' array for the interfaces.
10401 (TypeManager.ExpandInterfaces): Call this after the TypeBuilder
10402 has been defined, returns a list of the resolved interfaces types.
10403 (TypeManager.GetInterfaces): Return a `Type[]', not a `TypeExpr[]'.
10404 (TypeManager.GetExplicitInterfaces): Likewise.
10406 2004-08-02 Martin Baulig <martin@ximian.com>
10408 * expression.cs (Invocation.EmitCall): If we're invoking a method
10409 on a type parameter, use the new `Constrained' prefix opcode.
10411 2004-08-02 Martin Baulig <martin@ximian.com>
10413 * statement.cs (LocalInfo.Flags): Added `IsThis'.
10414 (LocalInfo.IsThis): New public property.
10415 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
10417 2004-08-01 Martin Baulig <martin@ximian.com>
10419 * class.cs (TypeContainer.GetClassBases): Don't set the default
10420 here since we may get called from GetPartialBases().
10421 (TypeContainer.DefineType): If GetClassBases() didn't return a
10422 parent, use the default one.
10424 2004-07-30 Martin Baulig <martin@ximian.com>
10426 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
10428 * class.cs (SourceMethod): New public class, derive from the
10429 symbol writer's ISourceMethod.
10430 (Method): Use the new symbol writer API.
10432 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
10433 as argument and use the new symbol writer.
10436 (SourceFile): Implement the symbol writer's ISourceFile.
10437 (Location.SymbolDocument): Removed.
10438 (Location.SourceFile): New public property.
10440 * symbolwriter.cs: Use the new symbol writer API.
10442 2004-07-30 Raja R Harinath <rharinath@novell.com>
10444 * Makefile (install-local): Remove. Functionality moved to
10447 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
10449 * Makefile: Install mcs.exe.config file together with mcs.exe.
10450 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
10451 correct runtime version.
10453 2004-07-25 Martin Baulig <martin@ximian.com>
10456 (TypeContainer.RegisterOrder): Removed, this was unused.
10457 (TypeContainer, interface_order): Removed.
10458 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
10459 TypeContainer as argument since we can also be called with a
10460 `PartialContainer' for a partial class/struct/interface.
10461 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
10462 of checking whether we're an `Interface' - we could be a
10463 `PartialContainer'.
10464 (PartialContainer.Register): Override; call
10465 AddClass()/AddStruct()/AddInterface() on our parent.
10467 * cs-parser.jay (interface_member_declaration): Add things to the
10468 `current_container', not the `current_class'.
10470 * rootcontext.cs (RegisterOrder): The overloaded version which
10471 takes an `Interface' was unused, removed.
10473 * typemanager.cs (TypeManager.LookupInterface): Return a
10474 `TypeContainer', not an `Interface'.
10475 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
10476 contain a `PartialContainer' for an interface, so check it's
10477 `Kind' to figure out what it is.
10479 2004-07-25 Martin Baulig <martin@ximian.com>
10481 * class.cs (Class.DefaultTypeAttributes): New public constant.
10482 (Struct.DefaultTypeAttributes): Likewise.
10483 (Interface.DefaultTypeAttributes): Likewise.
10484 (PartialContainer.TypeAttr): Override this and add the
10485 DefaultTypeAttributes.
10487 2004-07-25 Martin Baulig <martin@ximian.com>
10489 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
10490 we can just use the `Parent' field instead.
10492 2004-07-25 Martin Baulig <martin@ximian.com>
10494 * class.cs (TypeContainer.Emit): Renamed to EmitType().
10496 2004-07-25 Martin Baulig <martin@ximian.com>
10498 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
10499 our parts before defining any methods.
10500 (TypeContainer.VerifyImplements): Make this virtual.
10501 (ClassPart.VerifyImplements): Override and call VerifyImplements()
10502 on our PartialContainer.
10504 2004-07-25 Martin Baulig <martin@ximian.com>
10506 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
10508 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
10509 argument, we can just use the `Parent' field instead.
10512 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
10513 (MemberBase.DoDefine): Likewise.
10515 2004-07-24 Martin Baulig <martin@ximian.com>
10517 * decl.cs (MemberCore.Parent): New public field.
10518 (DeclSpace.Parent): Moved to MemberCore.
10520 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
10521 (MemberBase.ctor): Added TypeContainer argument, pass it to our
10523 (FieldBase, Field, Operator): Likewise.
10524 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
10525 (EventField, Event): Likewise.
10527 2004-07-23 Martin Baulig <martin@ximian.com>
10529 * class.cs (PartialContainer): New public class.
10530 (ClassPart): New public class.
10531 (TypeContainer): Added support for partial classes.
10532 (TypeContainer.GetClassBases): Splitted some of the functionality
10533 out into GetNormalBases() and GetPartialBases().
10535 * cs-tokenizer.cs (Token.PARTIAL): New token.
10536 (Tokenizer.consume_identifier): Added some hacks to recognize
10537 `partial', but only if it's immediately followed by `class',
10538 `struct' or `interface'.
10540 * cs-parser.jay: Added support for partial clases.
10542 2004-07-23 Martin Baulig <martin@ximian.com>
10544 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
10545 a `DeclSpace' and also made it readonly.
10546 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
10547 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
10548 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
10550 * cs-parser.jay: Pass the `current_class', not the
10551 `current_container' (at the moment, this is still the same thing)
10552 to a new Method, Property, Event, Indexer or Constructor.
10554 2004-07-23 Martin Baulig <martin@ximian.com>
10556 * cs-parser.jay (CSharpParser): Added a new `current_class' field
10557 and removed the `current_interface' one.
10558 (struct_declaration, class_declaration, interface_declaration):
10559 Set `current_class' to the newly created class/struct/interface;
10560 set their `Bases' and call Register() before parsing their body.
10562 2004-07-23 Martin Baulig <martin@ximian.com>
10564 * class.cs (Kind): New public enum.
10565 (TypeContainer): Made this class abstract.
10566 (TypeContainer.Kind): New public readonly field.
10567 (TypeContainer.CheckDef): New public method; moved here from
10569 (TypeContainer.Register): New public abstract method.
10570 (TypeContainer.GetPendingImplementations): New public abstract
10572 (TypeContainer.GetClassBases): Removed the `is_class' and
10573 `is_iface' parameters.
10574 (TypeContainer.DefineNestedTypes): Formerly known as
10576 (ClassOrStruct): Made this class abstract.
10578 * tree.cs (RootTypes): New public type.
10580 2004-07-20 Martin Baulig <martin@ximian.com>
10582 * tree.cs (Tree.RecordNamespace): Removed.
10583 (Tree.Namespaces): Removed.
10585 * rootcontext.cs (RootContext.IsNamespace): Removed.
10587 * cs-parser.jay (namespace_declaration): Just create a new
10588 NamespaceEntry here.
10590 2004-07-21 Lluis Sanchez Gual <lluis@novell.com>
10592 * Makefile: Install gmcs.exe.config file together with gmcs.exe.
10593 * gmcs.exe.config: Renamed from mcs.exe.config. Added supportedRuntime
10594 entry to make sure it runs in the correct runtime version.
10596 2004-07-18 Martin Baulig <martin@ximian.com>
10598 * generic.cs (ConstructedType.CheckConstraints): Improved
10599 constraints checking.
10601 2004-07-18 Martin Baulig <martin@ximian.com>
10603 * expression.cs (Invocation.BetterMethod): Call
10604 TypeManager.TypeToCoreType() on all types and removed my previous
10605 hack; we're already doig the right thing here.
10607 2004-07-17 Martin Baulig <martin@ximian.com>
10609 * decl.cs (MemberName.MakeName): Create the "class`1" names here.
10611 2004-07-16 Martin Baulig <martin@ximian.com>
10613 * iterators.cs: Added generics support.
10615 2004-07-16 Martin Baulig <martin@ximian.com>
10617 * iterators.cs: Rewrote this. We're now using one single Proxy
10618 class for both the IEnumerable and the IEnumerator interface and
10619 `Iterator' derives from Class so we can use the high-level API.
10621 * class.cs (TypeContainer.AddIterator): New method.
10622 (TypeContainer.DoDefineType): New protected virtual method, which
10623 is called from DefineType().
10624 (TypeContainer.DoDefineMembers): Call DefineType() and
10625 DefineMembers() on all our iterators.
10626 (TypeContainer.Emit): Call Emit() on all our iterators.
10627 (TypeContainer.CloseType): Call CloseType() on all our iterators.
10629 * codegen.cs (EmitContext.CurrentIterator): New public field.
10631 2004-07-15 Martin Baulig <martin@ximian.com>
10634 (TypeManager.not_supported_exception_type): New type.
10636 2004-07-14 Martin Baulig <martin@ximian.com>
10639 (TypeManager.generic_ienumerable_type): New type.
10640 (TypeManager.generic_ienumerator_type): New type.
10643 (RootContext.interfaces_first_stage): Added
10644 "System.Collections.Generic.IEnumerator`1" and
10645 "System.Collections.Generic.IEnumerable`1".
10647 2004-07-14 Martin Baulig <martin@ximian.com>
10649 * iterators.cs: Use real error numbers.
10651 2004-07-14 Martin Baulig <martin@ximian.com>
10653 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
10654 requires this to be a System.Collection.IEnumerable and not a
10655 class implementing that interface.
10656 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
10658 2004-07-13 Marek Safar <marek.safar@seznam.cz>
10660 * class.cs: Fixed previous fix, it broke some error tests.
10662 2004-07-12 Martin Baulig <martin@ximian.com>
10664 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
10667 2004-07-14 Martin Baulig <martin@ximian.com>
10669 * decl.cs, expression.cs, generic.cs: Use a backqoute (`) and not
10670 an exclamation mark (!) for the generic arity to reflect the
10671 latest spec changes; ie. use "System.Collections.Generic.IList`1".
10673 2004-07-13 Martin Baulig <martin@ximian.com>
10675 * cs-tokenizer.cs (Tokenizer.parse_less_than): Allow array rank
10676 specifiers being part of a type argument.
10678 2004-07-13 Martin Baulig <martin@ximian.com>
10680 * expression.cs (MemberAccess.ResolveAsTypeStep): Use the full `!'
10681 name for generic types.
10683 2004-07-13 Martin Baulig <martin@ximian.com>
10685 * assign.cs (Assign.DoResolve): Moved the CS0131 check up a little
10688 2004-07-09 Miguel de Icaza <miguel@ximian.com>
10690 * assign.cs (LocalTemporary): Add new argument: is_address,If
10691 `is_address' is true, then the value that we store is the address
10692 to the real value, and not the value itself.
10694 * ecore.cs (PropertyExpr): use the new local temporary
10695 stuff to allow us to handle X.Y += z (where X is a struct)
10697 2004-07-08 Martin Baulig <martin@ximian.com>
10699 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
10700 not always return, just like we're doing in Using.Resolve().
10702 2004-07-07 Miguel de Icaza <miguel@ximian.com>
10704 * cs-parser.jay (fixed_statement): flag this as Pinned.
10706 2004-07-06 Miguel de Icaza <miguel@ximian.com>
10708 * typemanager.cs (TypeManager): Removed MakePinned method, this
10709 mechanism is replaced with the .NET 2.x compatible mechanism of
10710 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
10712 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
10713 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
10714 `IsFixed' property which has a different meaning.
10716 2004-07-02 Raja R Harinath <rharinath@novell.com>
10718 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
10719 visible from inside a nested class, not just the names of the
10720 immediately enclosing class.
10721 Fix for bug #60730.
10723 2004-06-24 Raja R Harinath <rharinath@novell.com>
10725 * expression.cs (BetterConversion): Remove buggy special-case
10726 handling of "implicit constant expression conversions". At this
10727 point, we already know that the conversion is possible -- we're
10728 only checking to see which is better.
10730 2004-06-24 Marek Safar <marek.safar@seznam.cz>
10732 * cs-parser.jay: Added error CS0210 test.
10734 2004-06-24 Marek Safar <marek.safar@seznam.cz>
10736 * cs-parser.jay: Added error CS0134 test.
10738 2004-06-24 Marek Safar <marek.safar@seznam.cz>
10741 * cs-parser.jay: Added error CS0145 test.
10743 2004-06-24 Marek Safar <marek.safar@seznam.cz>
10745 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
10747 2004-06-23 Ben Maurer <bmaurer@ximian.com>
10749 * expression.cs (StackAlloc.Resolve): The argument may not
10750 be a constant; deal with this case.
10752 2004-06-23 Marek Safar <marek.safar@seznam.cz>
10754 * attribute.cs (IndexerName_GetIndexerName): Renamed to
10755 GetIndexerAttributeValue.
10756 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
10758 * class.cs (Indexer.Define): Added error tests for CS0415,
10761 2004-06-23 Miguel de Icaza <miguel@ximian.com>
10763 * attribute.cs (Attribute.Resolve): Keep field code in sync with
10766 2004-06-23 Martin Baulig <martin@ximian.com>
10768 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
10769 neither return nor throw, reset the barrier as well. Fixes #60457.
10771 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
10773 * class.cs : EventAttributes is now set to None by default.
10774 This fixes bug #60459.
10776 2004-06-18 Marek Safar <marek.safar@seznam.cz>
10779 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
10780 Don't throw exception but return null (it's sufficient now).
10782 2004-06-18 Marek Safar <marek.safar@seznam.cz>
10784 * typemanager.cs (GetArgumentTypes): Faster implementation.
10786 2004-06-18 Martin Baulig <martin@ximian.com>
10788 * attribute.cs (Attribute.Resolve): Check whether we're an
10789 EmptyCast which a Constant child. Fixes #60333.
10791 2004-06-17 Ben Maurer <bmaurer@ximian.com>
10793 * statement.cs (EmitCollectionForeach): Account for the fact that
10794 not all valuetypes are in areas which we can take the address of.
10795 For these variables, we store to a temporary variable. Also, make
10796 sure that we dont emit a `callvirt' on a valuetype method.
10798 2004-06-15 Marek Safar <marek.safar@seznam.cz>
10800 * expression.cs (StackAlloc.DoReSolve): Added test for
10801 negative parameter (CS0247).
10803 2004-06-15 Marek Safar <marek.safar@seznam.cz>
10806 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
10808 2004-06-15 Marek Safar <marek.safar@seznam.cz>
10811 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
10814 2004-06-14 Marek Safar <marek.safar@seznam.cz>
10816 Fix bug #58254 & cs1555.cs, cs1556.cs
10817 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
10819 2004-06-14 Marek Safar <marek.safar@seznam.cz>
10821 * cs-parser.jay: Added error CS1669 test for indexers.
10823 2004-06-18 Martin Baulig <martin@ximian.com>
10825 * generics.cs (GenericMethod.ctor): Don't take an Attributes
10826 argument. Fixes #60441.
10828 2004-06-16 Ben Maurer <bmaurer@ximian.com>
10829 * ecore.cs (MethodGroupExpr.Name): Revert Martin's patch.
10830 The name needs to have the actual name of the method in order
10831 for other tests (such as the one in OverloadResolve for Invoke
10832 on a delegate) to work. As well, it does not really help
10833 error reporting because the method group had multiple methods.
10834 * Makefile: Remove MCS_DEBUG, you can enable with the DEBUG_FLAGS.
10835 Make profiling work.
10837 2004-06-13 Martin Baulig <martin@ximian.com>
10839 * cs-parser.jay: Don't allow generic attributes.
10841 2004-06-13 Martin Baulig <martin@ximian.com>
10843 * class.cs (MemberBase.DoDefineBase): New protected method.
10844 (MemberBase.DoDefine): Compute the `flags' in the new
10845 DoDefineBase() which must be called first.
10846 (Method.Define): Call DoDefineBase() first so we have the flags
10847 when defining the generic method.
10849 * cs-parser.jay (interface_method_declaration): Support generic methods.
10851 2004-06-13 Martin Baulig <martin@ximian.com>
10853 * decl.cs (TypeName): Removed.
10854 (MemberName): Removed TypeName and MemberNow; now we just have
10857 * cs-parser.jay: Don't distinguish between type arguments and type
10858 parameters in the grammar and simplified the rules a bit. The
10859 reduce/reduce conflicts are now gone (except the one we inherited
10862 2004-06-11 Martin Baulig <martin@ximian.com>
10864 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
10865 call this twice: for params and varargs methods.
10867 2004-06-11 Marek Safar <marek.safar@seznam.cz>
10870 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
10872 2004-06-11 Marek Safar <marek.safar@seznam.cz>
10874 * attribute.cs (Attribute.GetValidTargets): Made public.
10877 (AbstractPropertyEventMethod): New class for better code sharing.
10878 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
10880 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
10882 2004-06-09 Martin Baulig <martin@ximian.com>
10884 * cs-parser.jay: Removed a reduce/reduce conflict.
10886 2004-06-03 Martin Baulig <martin@ximian.com>
10888 * generic.cs (ConstructedType.GetMemberAccess): Renamed to
10889 GetSimpleName() and return a SimpleName.
10891 * ecore.cs (SimpleName.Arguments): New public field.
10892 (SimpleName): Added overloaded ctor which takes an additional
10893 TypeArguments argument.
10894 (SimpleName.SimpleNameResolve): Added support for generic methods.
10895 (MethodGroupExpr.ResolveGeneric): New public method. The code was
10896 formerly in MemberAccess.DoResolve(), but we also need it in
10897 SimpleNameResolve().
10899 * expression.cs (MemberAccess.DoResolve): Use the new
10900 MethodGroupExpr.ResolveGeneric().
10902 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10904 * decl.cs: If possible, use lookuptypedirect here. We can only do
10905 this if there is no `.' after the namespace. Avoids using
10906 LookupType, which does lots of slow processing.
10907 (FindNestedType) New method, does what it says :-).
10908 * namespace.cs: use LookupTypeDirect.
10909 * rootcontext.cs: use membercache, if possible.
10910 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
10912 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10915 According to the spec,
10917 In a member access of the form E.I, if E is a single identifier,
10918 and if the meaning of E as a simple-name (§7.5.2) is a constant,
10919 field, property, localvariable, or parameter with the same type as
10920 the meaning of E as a type-name (§3.8), then both possible
10921 meanings of E are permitted.
10923 We did not check that E as a simple-name had the same type as E as
10926 This trivial check gives us 5-7% on bootstrap time.
10928 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10930 * expression.cs (Invocation.OverloadResolve): Avoid the
10931 use of hashtables and boxing here by allocating on demand.
10933 2004-05-30 Martin Baulig <martin@ximian.com>
10935 * rootcontext.cs (RootContext.LookupType): Don't cache things if
10936 we're doing a silent lookup. Don't try to lookup nested types in
10937 TypeManager.object_type (thanks to Ben Maurer).
10939 2004-05-30 Martin Baulig <martin@ximian.com>
10941 Committing a patch from Ben Maurer.
10943 * rootcontext.cs (RootContext.LookupType): Cache negative results.
10945 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10947 * convert.cs: add a trivial cache for overload operator resolution.
10949 2004-05-31 Marek Safar <marek.safar@seznam.cz>
10952 (AttributeTester.GetObsoleteAttribute): Returns instance of
10953 ObsoleteAttribute when type is obsolete.
10956 (TypeContainer.VerifyObsoleteAttribute): Override.
10957 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
10958 (MethodCode.VerifyObsoleteAttribute): Override.
10959 (MemberBase.VerifyObsoleteAttribute): Override.
10962 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
10963 and report proper error.
10966 (Delegate.VerifyObsoleteAttribute): Override.
10969 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
10970 and report proper error.
10971 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
10974 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
10978 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
10979 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
10980 Added test for ObsoleteAttribute.
10983 (Catch): Derived from Statement.
10985 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10987 * decl.cs: If possible, use lookuptypedirect here. We can only do
10988 this if there is no `.' after the namespace. Avoids using
10989 LookupType, which does lots of slow processing.
10990 (FindNestedType) New method, does what it says :-).
10991 * namespace.cs: use LookupTypeDirect.
10992 * rootcontext.cs: use membercache, if possible.
10993 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
10995 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10998 According to the spec,
11000 In a member access of the form E.I, if E is a single identifier,
11001 and if the meaning of E as a simple-name (§7.5.2) is a constant,
11002 field, property, localvariable, or parameter with the same type as
11003 the meaning of E as a type-name (§3.8), then both possible
11004 meanings of E are permitted.
11006 We did not check that E as a simple-name had the same type as E as
11009 This trivial check gives us 5-7% on bootstrap time.
11011 2004-05-30 Marek Safar <marek.safar@seznam.cz>
11013 Fixed bug #59071 & cs0160.cs
11014 * statement.cs (Try.Resolve): Check here whether order of catch
11015 clauses matches their dependencies.
11017 2004-05-30 Marek Safar <marek.safar@seznam.cz>
11020 * ecore.cs (SimpleName.SimpleNameResolve): Added test for
11023 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
11025 * expression.cs (Invocation.OverloadResolve): Avoid the
11026 use of hashtables and boxing here by allocating on demand.
11028 2004-05-30 Martin Baulig <martin@ximian.com>
11030 * rootcontext.cs (RootContext.LookupType): Don't cache things if
11031 we're doing a silent lookup. Don't try to lookup nested types in
11032 TypeManager.object_type (thanks to Ben Maurer).
11034 2004-05-30 Martin Baulig <martin@ximian.com>
11036 Committing a patch from Ben Maurer.
11038 * rootcontext.cs (RootContext.LookupType): Cache negative results.
11040 2004-05-29 Martin Baulig <martin@ximian.com>
11042 * class.cs (IMethodData.ShouldIgnore): New method.
11044 * typemanager.cs (TypeManager.MethodFlags): Don't take a
11045 `Location' argument, we don't need it anywhere. Use
11046 `IMethodData.ShouldIgnore ()' instead of
11047 `MethodData.GetMethodFlags ()'.
11048 (TypeManager.AddMethod): Removed.
11049 (TypeManager.AddMethod2): Renamed to AddMethod.
11051 2004-05-29 Martin Baulig <martin@ximian.com>
11053 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
11055 * convert.cs (Convert.ImplicitReferenceConversion): If we're
11056 converting from a class type S to an interface type and we already
11057 have an object on the stack, don't box it again. Fixes #52578.
11059 2004-05-29 Martin Baulig <martin@ximian.com>
11061 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
11062 Added support for `params' parameters. Fixes #59267.
11064 2004-05-29 Martin Baulig <martin@ximian.com>
11066 * literal.cs (NullPointer): Provide a private .ctor which sets
11067 `type' to TypeManager.object_type. Fixes #59048.
11069 2004-05-29 Martin Baulig <martin@ximian.com>
11071 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
11072 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
11074 * ecore.cs (EventExpr.instance_expr): Make the field private.
11076 2004-05-26 Marek Safar <marek.safar@seznam.cz>
11078 Fixed bug #50080 & cs0214-2.cs
11079 * expression.cs (Cast.DoResolve): Check unsafe context here.
11081 * statement.cs (Resolve.DoResolve): Likewise.
11083 2004-05-26 Martin Baulig <martin@ximian.com>
11085 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
11087 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
11088 (RootContext.LookupType): Pass down the `silent' flag.
11090 2004-05-25 Martin Baulig <martin@ximian.com>
11093 (MethodGroupExpr.IdenticalTypeName): New public property.
11094 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
11095 expression actually refers to a type.
11097 2004-05-25 Martin Baulig <martin@ximian.com>
11099 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
11100 for #56176 and made it actually work.
11102 2004-05-25 Martin Baulig <martin@ximian.com>
11104 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
11105 (FieldExpr, PropertyExpr): Override and implement
11106 CacheTemporaries. Fixes #52279.
11108 2004-05-25 Miguel de Icaza <miguel@ximian.com>
11110 * location.cs: In the new compiler listing a file twice is a
11111 warning, not an error.
11113 2004-05-24 Martin Baulig <martin@ximian.com>
11115 * enum.cs (Enum.DefineType): For the `BaseType' to be a
11116 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
11118 2004-05-24 Martin Baulig <martin@ximian.com>
11120 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
11121 walking the `using' list. Fixes #53921.
11123 2004-05-24 Martin Baulig <martin@ximian.com>
11125 * const.cs (Const.LookupConstantValue): Added support for
11126 EmptyCast's; fixes #55251.
11128 2004-05-24 Martin Baulig <martin@ximian.com>
11130 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
11131 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
11132 which does the CS0135 check. The reason is that we first need to
11133 check whether the variable actually exists.
11135 2004-05-24 Martin Baulig <martin@ximian.com>
11137 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
11138 than RootContext.LookupType() to find the explicit interface
11139 type. Fixes #58584.
11141 2004-05-24 Raja R Harinath <rharinath@novell.com>
11143 * Makefile: Simplify. Use executable.make.
11144 * mcs.exe.sources: New file. List of sources of mcs.exe.
11146 2004-05-24 Anders Carlsson <andersca@gnome.org>
11150 Use the invariant culture when doing String.Compare for CLS case
11153 2004-05-23 Martin Baulig <martin@ximian.com>
11155 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
11156 don't have any dots. Fixes #52622, added cs0246-8.cs.
11158 * namespace.cs (NamespaceEntry.Lookup): Likewise.
11160 2004-05-23 Marek Safar <marek.safar@seznam.cz>
11162 * class.cs (MemberBase.Define): Reuse MemberType member for
11163 resolved type. Other methods can use it too.
11165 2004-05-23 Martin Baulig <martin@ximian.com>
11167 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
11168 the variable also exists in the current block (otherwise, we need
11169 to report a CS0103). Fixes #58670.
11171 2004-05-23 Martin Baulig <martin@ximian.com>
11173 * flowanalysis.cs (Reachability.Reachable): Compute this
11174 on-the-fly rather than storing it as a field.
11176 2004-05-23 Martin Baulig <martin@ximian.com>
11178 * flowanalysis.cs (Reachability.And): Manually compute the
11179 resulting `barrier' from the reachability.
11181 2004-05-23 Marek Safar <marek.safar@seznam.cz>
11184 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
11185 instance of ObsoleteAttribute when symbol is obsolete.
11188 (IMethodData): Extended interface for ObsoleteAttribute support.
11190 2004-05-22 Marek Safar <marek.safar@seznam.cz>
11192 * attribute.cs: Fix bug #55970
11194 2004-05-22 Marek Safar <marek.safar@seznam.cz>
11198 (GetObsoleteAttribute): New method. Creates the instance of
11200 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
11201 ObsoleteAttribute when member is obsolete.
11202 (AttributeTester.Report_ObsoleteMessage): Common method for
11203 Obsolete error/warning reporting.
11206 (TypeContainer.base_classs_type): New member for storing parent type.
11209 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
11210 for this MemberCore.
11212 2004-05-21 Marek Safar <marek.safar@seznam.cz>
11214 * attribute.cs, const.cs: Fix bug #58590
11216 2004-05-21 Martin Baulig <martin@ximian.com>
11218 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
11219 out parameters if the end of the method is unreachable. Fixes
11222 2004-05-21 Marek Safar <marek.safar@seznam.cz>
11224 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
11225 Hari was right, why extra method.
11227 2004-05-21 Marek Safar <marek.safar@seznam.cz>
11229 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
11231 2004-05-20 Martin Baulig <martin@ximian.com>
11233 * delegate.cs: Convert this file to Unix mode - like the original
11236 2004-05-20 Martin Baulig <martin@ximian.com>
11238 * attribute.cs: Convert this file to Unix mode - like the original
11241 2004-05-19 Marek Safar <marek.safar@seznam.cz>
11243 Fix bug #58688 (MCS does not report error when the same attribute
11246 * attribute.cs (Attribute.Emit): Distinction between null and default.
11248 2004-05-19 Raja R Harinath <rharinath@novell.com>
11250 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
11251 of a top-level attribute without an attribute target.
11252 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
11254 (Attribute.Conditional_GetConditionName),
11255 (Attribute.Obsolete_GetObsoleteMessage): Update.
11256 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
11257 part of ScanForIndexerName.
11258 (Attribute.CanIgnoreInvalidAttribute): New function.
11259 (Attribute.ScanForIndexerName): Move to ...
11260 (Attributes.ScanForIndexerName): ... here.
11261 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
11262 (Attributes.Search): New internal variant that can choose not to
11263 complain if types aren't resolved. The original signature now
11265 (Attributes.GetClsCompliantAttribute): Use internal variant, with
11266 complaints suppressed.
11267 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
11268 only if it not useful.
11269 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
11270 top-level for attributes that are shared between the assembly
11271 and a top-level class.
11272 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
11273 * class.cs: Update to reflect changes.
11274 (DefineIndexers): Fuse loops.
11275 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
11276 a couple more variants of attribute names.
11278 2004-05-18 Marek Safar <marek.safar@seznam.cz>
11280 Fix bug #52585 (Implemented explicit attribute declaration)
11283 (Attributable.ValidAttributeTargets): New abstract method. It gets
11284 list of valid attribute targets for explicit target declaration.
11285 (Attribute.Target): It holds target itself.
11286 (AttributeSection): Removed.
11287 (Attribute.CheckTargets): New method. It checks whether attribute
11288 target is valid for the current element.
11291 (EventProperty): New class. For events that are declared like
11292 property (with add and remove accessors).
11293 (EventField): New class. For events that are declared like field.
11296 * cs-parser.jay: Implemented explicit attribute target declaration.
11298 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
11299 Override ValidAttributeTargets.
11302 (ReturnParameter): Class for applying custom attributes on
11304 (ParameterAtribute): New class. Class for applying custom
11305 attributes on the parameter type.
11307 2004-05-17 Miguel de Icaza <miguel@ximian.com>
11309 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
11312 (Method): Allow UNSAFE here.
11314 * modifiers.cs: Support unsafe reporting.
11316 2004-05-17 Marek Safar <marek.safar@seznam.cz>
11318 * decl.cs: Fix bug #58478.
11320 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11322 * statement.cs: When checking for unreachable code on an EmptyStatement,
11323 set the location. Fixes bug #58488.
11325 2004-05-13 Miguel de Icaza <miguel@ximian.com>
11327 * driver.cs: Add -pkg handling.
11329 From Gonzalo: UseShelLExecute=false
11331 2004-05-12 Marek Safar <marek.safar@seznam.cz>
11334 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
11336 (Attribute.IsClsCompliaceRequired): Moved to base for better
11338 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
11339 when attribute is AttributeUsageAttribute.
11340 (Attribute.GetValidTargets): Simplified.
11341 (Attribute.GetAttributeUsage): New method returns AttributeUsage
11342 attribute for this type.
11343 (Attribute.ApplyAttributes): Method renamed to Emit and make
11345 (GlobalAttributeSection): New class for special handling of global
11346 attributes (assembly, module).
11347 (AttributeSection.Emit): New method.
11349 * class.cs: Implemented Attributable abstract methods.
11350 (MethodCore.LabelParameters): Moved to Parameter class.
11351 (Accessor): Is back simple class.
11352 (PropertyMethod): Implemented Attributable abstract class.
11353 (DelegateMethod): Implemented Attributable abstract class.
11354 (Event): New constructor for disctintion between normal Event
11355 and Event with accessors.
11357 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
11359 * codegen.cs, const.cs, decl.cs, delegate.cs:
11360 (CommonAssemblyModulClass): Implemented Attributable abstract class
11363 * enum.cs: Implement IAttributeSupport interface.
11364 (EnumMember): New class for emum members. Implemented Attributable
11368 (ParameterBase): Is abstract.
11369 (ReturnParameter): New class for easier [return:] attribute handling.
11371 * typemanager.cs: Removed builder_to_attr.
11373 2004-05-11 Raja R Harinath <rharinath@novell.com>
11376 * attribute.cs (Attribute.GetPositionalValue): New function.
11377 * class.cs (TypeContainer.VerifyMembers): New function.
11378 (TypeContainer.Emit): Use it.
11379 (ClassOrStruct): New base class for Class and Struct.
11380 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
11381 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
11383 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
11384 then each non-static field should have a FieldOffset attribute.
11385 Otherwise, none of the fields should have a FieldOffset attribute.
11386 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
11387 and FieldOffset attributes.
11388 * typemanager.cs (TypeManager.struct_layout_attribute_type)
11389 (TypeManager.field_offset_attribute_type): New core types.
11390 (TypeManager.InitCoreTypes): Initialize them.
11392 2004-05-11 Michal Moskal <malekith@pld-linux.org>
11394 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
11395 Return correct type.
11398 2004-05-09 Miguel de Icaza <miguel@ximian.com>
11400 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
11401 be implicitly converted to ulong.
11403 * expression.cs: The logic for allowing operator &, | and ^ worked
11404 was wrong, it worked before because we did not report an error in
11405 an else branch. Fixes 57895.
11407 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
11408 allow volatile fields to be reference types.
11410 2004-05-07 Miguel de Icaza <miguel@ximian.com>
11412 * driver.cs: Add support for /debug-
11414 2004-05-07 Raja R Harinath <rharinath@novell.com>
11416 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
11417 Add a 'complain' parameter to silence errors.
11418 (Attribute.Resolve): Update to changes. Put in sanity check to catch
11419 silently overlooked type-resolutions.
11420 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
11421 to reflect changes.
11422 (Attributes.Search): New function.
11423 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
11424 (Attributes.GetAttributeFullName): Remove hack.
11425 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
11426 Update to reflect changes.
11427 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
11428 Use Attributes.Search instead of nested loops.
11430 2004-05-07 Marek Safar <marek.safar@seznam.cz>
11433 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
11434 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
11435 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
11437 * report.cs: (Report.Warning): Renamed to Warning_T because of
11438 parameter collision.
11440 2004-05-05 Raja R Harinath <rharinath@novell.com>
11442 * expression.cs (MemberAccess.ResolveMemberAccess):
11443 Exit with non-zero status after Report.Error.
11444 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
11446 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
11448 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
11450 * support.cs: Don't hang when the file is empty.
11452 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
11454 * support.cs: In SeekableStreamReader, compute the preamble size of the
11455 underlying stream. Position changes should take into account that initial
11458 2004-05-03 Todd Berman <tberman@sevenl.net>
11460 * driver.cs: remove unused GetSysVersion function.
11462 2004-05-03 Todd Berman <tberman@sevenl.net>
11464 * driver.cs: Remove the hack from saturday, as well as the hack
11465 from jackson (LoadAssemblyFromGac), also adds the CWD to the
11466 link_paths to get that bit proper.
11468 2004-05-01 Todd Berman <tberman@sevenl.net>
11470 * driver.cs: Try a LoadFrom before a Load, this checks the current
11471 path. This is currently a bug in mono that is be fixed, however, this
11472 provides a workaround for now. This will be removed when the bug
11475 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
11477 * CryptoConvert.cs: Updated to latest version. Fix issue with
11478 incomplete key pairs (#57941).
11480 2004-05-01 Todd Berman <tberman@sevenl.net>
11482 * driver.cs: Remove '.' from path_chars, now System.* loads properly
11485 2004-04-30 Jackson Harper <jackson@ximian.com>
11487 * codegen.cs: Open keys readonly.
11489 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11491 * typemanager.cs: don't report cyclic struct layout when a struct
11492 contains 2 or more fields of the same type. Failed for Pango.AttrShape
11493 which has 2 Pango.Rectangle fields.
11495 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
11497 * expression.cs: Handle IntPtr comparisons with IL code
11498 rather than a method call.
11500 2004-04-29 Martin Baulig <martin@ximian.com>
11502 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
11503 the list of PropertyInfo's in class hierarchy and find the
11504 accessor. Fixes #56013.
11506 2004-04-29 Martin Baulig <martin@ximian.com>
11508 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
11510 2004-04-29 Martin Baulig <martin@ximian.com>
11512 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
11514 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
11516 2004-04-29 Martin Baulig <martin@ximian.com>
11518 * class.cs (ConstructorInitializer.Resolve): Check whether the
11519 parent .ctor is accessible. Fixes #52146.
11521 2004-04-29 Martin Baulig <martin@ximian.com>
11523 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
11525 * statement.cs (Using.EmitLocalVariableDecls): Use
11526 TypeManager.idisposable_type, not typeof (IDisposable).
11527 (Foreach.EmitCollectionForeach): Added support for valuetypes.
11529 2004-04-29 Martin Baulig <martin@ximian.com>
11531 * class.cs (Event.Define): Don't emit the field and don't set
11532 RTSpecialName and SpecialName for events on interfaces. Fixes
11535 2004-04-29 Raja R Harinath <rharinath@novell.com>
11537 Refactor Attribute.ApplyAttributes.
11538 * attribute.cs (Attributable): New base class for objects that can
11539 have Attributes applied on them.
11540 (Attribute): Make AttributeUsage fields public.
11541 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
11542 (Attribute.IsInternalCall): New property.
11543 (Attribute.UsageAttr): Convert to a public read-only property.
11544 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
11545 (Attribute.ResolveType, Attribute.Resolve)
11546 (Attribute.ScanForIndexerName): Update to reflect changes.
11547 (Attribute.CheckAttributeTarget): Re-format.
11548 (Attribute.ApplyAttributes): Refactor, to various
11549 Attributable.ApplyAttributeBuilder methods.
11550 * decl.cs (MemberCore): Make Attributable.
11551 * class.cs (Accessor): Make Attributable.
11552 (MethodData.ApplyAttributes): Use proper attribute types, not
11554 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
11555 (TypeContainer.ApplyAttributeBuilder)
11556 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
11557 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
11558 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
11559 (Operator.ApplyAttributeBuilder): New factored-out methods.
11560 * const.cs (Const.ApplyAttributeBuilder): Likewise.
11561 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
11562 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
11563 * parameter.cs (ParameterBase): New Attributable base class
11564 that can also represent Return types.
11565 (Parameter): Update to the changes.
11567 2004-04-29 Jackson Harper <jackson@ximian.com>
11569 * driver.cs: Prefer the corlib system version when looking for
11570 assemblies in the GAC. This is still a hack, but its a better hack
11573 2004-04-29 Marek Safar <marek.safar@seznam.cz>
11575 * decl.cs, enum.cs: Improved error 3005 reporting.
11577 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
11578 (related_symbols): New private member for list of symbols
11579 related to reported error/warning.
11581 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
11583 2004-04-29 Martin Baulig <martin@ximian.com>
11585 * ecore.cs (Expression.Constantify): If we're an enum and
11586 TypeManager.TypeToCoreType() doesn't give us another type, use
11587 t.UnderlyingSystemType. Fixes #56178.
11589 2004-04-29 Martin Baulig <martin@ximian.com>
11591 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
11592 interfaces and for each interface, only add members directly
11593 declared in that interface. Fixes #53255.
11595 2004-04-28 Martin Baulig <martin@ximian.com>
11597 * expression.cs (ConditionalLogicalOperator): Use a temporary
11598 variable for `left' to avoid that we evaluate it more than once;
11601 2004-04-28 Martin Baulig <martin@ximian.com>
11603 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
11606 2004-04-28 Martin Baulig <martin@ximian.com>
11608 * statement.cs (LocalInfo.Resolve): Check whether the type is not
11611 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
11612 whether the type is not void (CS1547).
11614 2004-04-28 Martin Baulig <martin@ximian.com>
11616 * expression.cs (Unary.DoResolveLValue): Override this and report
11617 CS0131 for anything but Operator.Indirection.
11619 2004-04-28 Martin Baulig <martin@ximian.com>
11621 Committing a patch from Ben Maurer; see bug #50820.
11623 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
11626 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
11629 2004-04-28 Martin Baulig <martin@ximian.com>
11631 Committing a patch from Ben Maurer; see bug #50820.
11633 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
11636 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
11639 2004-04-28 Martin Baulig <martin@ximian.com>
11641 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
11642 (Block.AddLabel): Call DoLookupLabel() to only search in the
11645 2004-04-28 Martin Baulig <martin@ximian.com>
11647 * cfold.cs (ConstantFold.BinaryFold): Added special support for
11648 comparing StringConstants and NullLiterals in Equality and Inequality.
11650 2004-04-28 Jackson Harper <jackson@ximian.com>
11652 * driver.cs: Attempt to load referenced assemblies from the
11653 GAC. This is the quick and dirty version of this method that
11654 doesnt take into account versions and just takes the first
11655 canidate found. Will be good enough for now as we will not have more
11656 then one version installed into the GAC until I update this method.
11658 2004-04-28 Martin Baulig <martin@ximian.com>
11660 * typemanager.cs (TypeManager.CheckStructCycles): New public
11661 static method to check for cycles in the struct layout.
11663 * rootcontext.cs (RootContext.PopulateTypes): Call
11664 TypeManager.CheckStructCycles() for each TypeContainer.
11665 [Note: We only need to visit each type once.]
11667 2004-04-28 Martin Baulig <martin@ximian.com>
11669 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
11671 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
11672 success and added `out object value'. Use a `bool resolved' field
11673 to check whether we've already been called rather than
11674 `ConstantValue != null' since this breaks for NullLiterals.
11676 2004-04-28 Raja R Harinath <rharinath@novell.com>
11678 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
11679 setting of this flag, since the 'set' method may be non-public.
11681 2004-04-28 Raja R Harinath <rharinath@novell.com>
11683 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
11684 check on current_vector.Block.
11686 2004-04-27 Martin Baulig <martin@ximian.com>
11688 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
11689 a field initializer. Fixes #56459.
11691 2004-04-27 Martin Baulig <martin@ximian.com>
11693 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
11694 we're not attempting to use an indexer. Fixes #52154.
11696 2004-04-27 Martin Baulig <martin@ximian.com>
11698 * statement.cs (Return): Don't create a return label if we don't
11699 need it; reverts my change from January 20th. Thanks to Ben
11702 2004-04-27 Martin Baulig <martin@ximian.com>
11704 According to the spec, `goto' can only leave a nested scope, but
11707 * statement.cs (Block.LookupLabel): Only lookup in the current
11708 block, don't recurse into parent or child blocks.
11709 (Block.AddLabel): Check in parent and child blocks, report
11710 CS0140/CS0158 if we find a duplicate.
11711 (Block): Removed this indexer for label lookups.
11712 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
11713 this already does the error reporting for us.
11716 (FlowBranching.UsageVector.Block): New public variable; may be null.
11717 (FlowBranching.CreateSibling): Added `Block' argument.
11718 (FlowBranching.LookupLabel): New public virtual method. Lookup a
11719 label for the target of a `goto' and check whether we're not
11720 leaving a `finally'.
11722 2004-04-27 Martin Baulig <martin@ximian.com>
11724 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
11725 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
11728 2004-04-27 Martin Baulig <martin@ximian.com>
11730 * statement.cs (Block.AddLabel): Also check for implicit blocks
11731 and added a CS0158 check.
11733 2004-04-27 Martin Baulig <martin@ximian.com>
11735 * flowanalysis.cs (FlowBranchingLoop): New class.
11736 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
11737 UsageVector's instead of an ArrayList.
11738 (FlowBranching.Label): Likewise.
11739 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
11740 (FlowBranching.AddBreakVector): New method.
11742 2004-04-27 Miguel de Icaza <miguel@ximian.com>
11744 * attribute.cs: Small regression fix: only convert the type if we
11745 the type is different, fixes System.Drawing build.
11747 2004-04-27 Martin Baulig <martin@ximian.com>
11749 * attribute.cs (Attribute.Resolve): If we have a constant value
11750 for a named field or property, implicity convert it to the correct
11753 2004-04-27 Raja R Harinath <rharinath@novell.com>
11755 * statement.cs (Block.Block): Implicit blocks share
11756 'child_variable_names' fields with parent blocks.
11757 (Block.AddChildVariableNames): Remove.
11758 (Block.AddVariable): Mark variable as "used by a child block" in
11759 every surrounding block.
11760 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
11761 been used in a child block, complain about violation of "Invariant
11762 meaning in blocks" rule.
11763 * cs-parser.jay (declare_local_variables): Don't use
11764 AddChildVariableNames.
11765 (foreach_statement): Don't create an implicit block: 'foreach'
11766 introduces a scope.
11768 2004-04-23 Miguel de Icaza <miguel@ximian.com>
11770 * convert.cs (ImplicitNumericConversion): 0 is also positive when
11771 converting from 0L to ulong. Fixes 57522.
11773 2004-04-22 Marek Safar <marek.safar@seznam.cz>
11775 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
11776 derived class hides via 'new' keyword field from base class (test-242.cs).
11777 TODO: Handle this in the more general way.
11779 * class.cs (CheckBase): Ditto.
11781 2004-04-22 Marek Safar <marek.safar@seznam.cz>
11783 * decl.cs (caching_flags): New member for storing cached values
11785 (MemberCore.Flags): New enum where bit flags for caching_flags
11787 (MemberCore.cls_compliance): Moved to caching_flags.
11788 (DeclSpace.Created): Moved to caching_flags.
11790 * class.cs: Use caching_flags instead of DeclSpace.Created
11792 2004-04-21 Miguel de Icaza <miguel@ximian.com>
11794 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
11795 if we are only a derived class, not a nested class.
11797 * typemanager.cs: Same as above, but do this at the MemberLookup
11798 level (used by field and methods, properties are handled in
11799 PropertyExpr). Allow for the qualified access if we are a nested
11802 2004-04-21 Marek Safar <marek.safar@seznam.cz>
11804 * class.cs: Refactoring.
11805 (IMethodData): New inteface; Holds links to parent members
11806 to avoid member duplication (reduced memory allocation).
11807 (Method): Implemented IMethodData interface.
11808 (PropertyBase): New inner classes for get/set methods.
11809 (PropertyBase.PropertyMethod): Implemented IMethodData interface
11810 (Event): New inner classes for add/remove methods.
11811 (Event.DelegateMethod): Implemented IMethodData interface.
11813 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
11814 EmitContext (related to class.cs refactoring).
11816 2004-04-21 Raja R Harinath <rharinath@novell.com>
11818 * delegate.cs (Delegate.VerifyApplicability): If the number of
11819 arguments are the same as the number of parameters, first try to
11820 verify applicability ignoring any 'params' modifier on the last
11824 2004-04-08 Martin Baulig <martin@ximian.com>
11826 Merged latest changes into gmcs. Please keep this comment in
11827 here, it makes it easier for me to see what changed in MCS since
11828 the last time I merged.
11830 2004-04-16 Raja R Harinath <rharinath@novell.com>
11832 * class.cs (TypeContainer.AddIndexer): Use
11833 'ExplicitInterfaceName' to determine if interface name was
11834 explicitly specified. 'InterfaceType' is not initialized at this time.
11835 (TypeContainer.DefineIndexers): Remove use of temporary list. The
11836 Indexers array is already in the required order. Initialize
11837 'IndexerName' only if there are normal indexers.
11838 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
11839 (TypeContainer.Emit): Emit DefaultMember attribute only if
11840 IndexerName is initialized.
11843 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
11845 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
11848 2004-04-15 Raja R Harinath <rharinath@novell.com>
11850 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
11854 * attribute.cs (Attribute.Resolve): Check for duplicate named
11858 2004-04-15 Miguel de Icaza <miguel@ximian.com>
11860 * iterators.cs (MarkYield): track whether we are in an exception,
11861 and generate code accordingly. Use a temporary value to store the
11862 result for our state.
11864 I had ignored a bit the interaction of try/catch with iterators
11865 since their behavior was not entirely obvious, but now it is
11866 possible to verify that our behavior is the same as MS .NET 2.0
11870 2004-04-14 Miguel de Icaza <miguel@ximian.com>
11872 * iterators.cs: Avoid creating temporaries if there is no work to
11875 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
11876 Enumerations, use TypeManager.EnumToUnderlying and call
11879 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
11882 (This.Emit): Use EmitContext.EmitThis to emit our
11885 (This.EmitAssign): Ditto.
11887 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
11888 codepaths, we will move all the functionality into
11891 (FieldExpr.EmitAssign): Ditto.
11893 This fixes several hidden bugs that I uncovered while doing a code
11894 review of this today.
11896 * codegen.cs (EmitThis): reworked so the semantics are more clear
11897 and also support value types "this" instances.
11899 * iterators.cs: Changed so that for iterators in value types, we
11900 do not pass the value type as a parameter.
11902 Initialization of the enumerator helpers is now done in the caller
11903 instead of passing the parameters to the constructors and having
11904 the constructor set the fields.
11906 The fields have now `assembly' visibility instead of private.
11908 2004-04-11 Miguel de Icaza <miguel@ximian.com>
11910 * expression.cs (Argument.Resolve): Check if fields passed as ref
11911 or out are contained in a MarshalByRefObject.
11913 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
11914 another compiler type.
11916 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
11918 * class.cs (Indexer.Define): use the new name checking method.
11919 Also, return false on an error.
11920 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
11921 (is_identifier_[start/part]_character): make static.
11923 2004-04-10 Miguel de Icaza <miguel@ximian.com>
11925 * expression.cs (Binary.ResolveOperator): Do no append strings
11926 twice: since we can be invoked more than once (array evaluation)
11927 on the same concatenation, take care of this here. Based on a fix
11928 from Ben (bug #56454)
11930 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
11932 * codegen.cs: Fix another case where CS1548 must be reported (when
11933 delay-sign isn't specified and no private is available #56564). Fix
11934 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
11935 error when MCS is used on the MS runtime and we need to delay-sign
11936 (which seems unsupported by AssemblyBuilder - see #56621).
11938 2004-04-08 Marek Safar <marek.safar@seznam.cz>
11940 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
11941 (TypeManager.ComputeNamespaces): Faster implementation for
11944 * compiler.csproj: Updated AssemblyName to mcs.
11946 2004-05-11 Jackson Harper <jackson@ximian.com>
11948 * Makefile: Preserve MONO_PATH
11950 2004-05-11 Jackson Harper <jackson@ximian.com>
11952 * Makefile: Use mono and mcs to build gmcs
11954 2004-05-03 Miguel de Icaza <miguel@ximian.com>
11956 * codegen.cs: Add patch from Robert Shade
11957 <rshade@dvsconsulting.com>, use FileAccess.Read on the keyfile, to
11960 2004-05-02 Sebastien Pouliot <sebastien@ximian.com>
11962 * CryptoConvert.cs: Updated to latest version. Fix issue with
11963 incomplete key pairs (#57941).
11965 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
11967 * codegen.cs: Fix another case where CS1548 must be reported (when
11968 delay-sign isn't specified and no private is available #56564). Fix
11969 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
11970 error when MCS is used on the MS runtime and we need to delay-sign
11971 (which seems unsupported by AssemblyBuilder - see #56621).
11973 2004-04-29 Jackson Harper <jackson@ximian.com>
11975 * Makefile: Set MONO_PATH to use the bootstrap corlib
11976 * driver.cs: Check the GAC for referenced assemblies.
11978 2004-04-29 Martin Baulig <martin@ximian.com>
11980 * Makefile (gmcs.exe): Set MONO_PATH to use `../class/lib/net_2_0'.
11982 2004-04-07 Martin Baulig <martin@ximian.com>
11984 * expression.cs (Binary.ResolveOperator): Added special case for
11985 Equality/Inequality between a type parameter and a null literal.
11987 2004-04-07 Martin Baulig <martin@ximian.com>
11989 * convert.cs: Check null literal -> type parameter conversions.
11991 2004-04-07 Martin Baulig <martin@ximian.com>
11993 * generic.cs (ConstructedType.CheckConstraints): Enforce the
11994 `class' and `struct' constraints.
11996 2004-04-07 Martin Baulig <martin@ximian.com>
11998 * generic.cs (SpecialConstraint): New public enum.
11999 (Constraints.Resolve): Added support for the `class' and `struct'
12002 * cs-parser.jay (type_parameter_constraint): Added support for the
12003 `class' and `struct' constraints.
12005 2004-04-07 Martin Baulig <martin@ximian.com>
12007 * support.cs (GenericConstraints): Replaced `Types' by
12008 `ClassConstraint' and `InterfaceConstraints'; added
12009 `HasClassConstraint'.
12011 2004-04-07 Martin Baulig <martin@ximian.com>
12014 (Constraints.InterfaceConstraints): New public property.
12015 (Constraints.Types): Make this property public
12016 (TypeParameter): Implement IMemberContainer.
12017 (TypeParameter.Define): Take a `GenericTypeParameterBuilder'
12018 instead of a TypeBuilder/MethodBuilder; pass the interface
12019 constraints to TypeManager.AddTypeParameter().
12020 (TypeParameter.DefineType): Just take an EmitContext and no
12021 TypeBuilder/MethodBuilder. Use the new public API.
12023 * typemanager.cs (TypeManager.AddTypeParameter): Added
12024 `TypeExpr[]' argument; add the interfaces to the
12025 `builder_to_ifaces' hash.
12026 (TypeManager.LookupMemberContainer): For
12027 GenericTypeParameterBuilders, get the TypeParameter from the
12028 `builder_to_type_param'.
12029 (TypeManager.FindMembers): For GenericTypeParameterBuilders, get
12030 the TypeParameter and call FindMembers on it.
12032 2004-04-07 Martin Baulig <martin@ximian.com>
12035 (MethodCore.GenericMethod): Moved this field here from Method.
12036 (MethodCore.IsDuplicateImplementation): Take the number of type
12037 parameters into account if we're a generic method.
12039 * expression.cs (Invocation.InferTypeArguments): Don't return true
12040 if `arguments' is null; we still need to check whether we actually
12041 don't need to infer anything in this case.
12042 (MemberAccess): Merged the functionality from GenericMemberAccess
12045 * generic.cs (GenericMemberAccess): Removed.
12047 2004-04-05 Martin Baulig <martin@ximian.com>
12049 * decl.cs (MemberCore): For generic classes, interfaces and
12050 structs, `Name' now includes the number of type parameters
12051 ("Stack!1.Node!1").
12052 (DeclSpace.FindType): Removed the `num_type_args' argument; we now
12053 encode the number of type arguments in the type name.
12055 * expression.cs (Expression.MemberLookup): Removed the
12056 `num_type_args' argument; we now encode the number of type
12057 arguments in the type name.
12059 * ecore.cs (SimpleName): Encode the number of type arguments in
12060 the type name itself.
12062 * generic.cs (ConstructedType): Likewise.
12064 * tree.cs (Tree.RecordDecl): Take a `string' instead of a
12065 `MemberName'; we now include the number of type parameters in the
12068 * typemanager.cs (TypeManager.CheckGeneric): Removed.
12069 (TypeManager.MemberLookup): Removed the
12070 `num_type_args' argument; we now encode the number of type
12071 arguments in the type name.
12073 2004-04-03 Martin Baulig <martin@ximian.com>
12075 * decl.cs (MemberCore.ctor): Take a MemberName instead of a sting.
12076 (MemberCore.MemberName): Moved here from MemberBase.
12077 (DeclSpace.SetParameterInfo): Just take the constraints as an
12078 ArrayList; we already have the type parameters in our
12079 `MemberName'; also do the CS0080 reporting here.
12081 * cs-parser.jay (struct_declaration): Use `member_name' instead of
12082 `IDENTIFIER opt_type_parameter_list'; when constructing our
12083 `MemberName', it'll already include our type parameters.
12084 (class_declaration, interface_declaration): Likewise.
12085 (delegate_declaration): Likewise.
12086 (MakeName): Take a MemberName and return a MemberName.
12087 The following two changes are required to avoid shift/reduce conflicts:
12088 (member_name): Don't include a TypeName anymore; ie. this is now
12089 just 'IDENTIFIER opt_type_parameter_list'.
12090 (property_declaration, event_declaration): Use a
12091 `namespace_or_type_name' instead of a `member_name'.
12093 2004-04-03 Martin Baulig <martin@ximian.com>
12095 * decl.cs (MemberName): Renamed to `TypeName' and created a new
12096 `MemberName' class.
12097 (TypeName): Formerly known as MemberName.
12099 * namespace.cs (NamespaceEntry.UsingAlias): Take a `TypeName'
12100 instead of a `MemberName'.
12102 * cs-parser.jay (namespace_or_type_name): Create a TypeName.
12103 (member_name): New rule; create a MemberName.
12105 2004-04-02 Martin Baulig <martin@ximian.com>
12107 * namespace.cs (NamespaceEntry.VerifyUsing): Added error checking
12108 (CS0305 and CS0308).
12110 2004-04-02 Martin Baulig <martin@ximian.com>
12112 * generic.cs (GenericMemberAccess.ResolveAsTypeStep): Added
12113 support for nested types.
12115 2004-04-02 Martin Baulig <martin@ximian.com>
12117 * ecore.cs (IAlias): New public interface.
12118 (TypeExpr, TypeExpression): Implement IAlias.
12119 (TypeAliasExpression): New public class.
12121 * namespace.cs (Namespace): Implement IAlias.
12122 (Namespace.Lookup): Return an IAlias instead on an object.
12123 (Namespace.DefineName): Take an IAlias instead of an object.
12124 (NamespaceEntry.AliasEntry.Resolve): Return an IAlias instead of
12126 (NamespaceEntry.UsingAlias): Take a Membername instead of an
12128 (NamespaceEntry.LookupAlias): Return an IAlias instead on an
12130 (NamespaceEntry.Lookup): Likewise.
12132 * rootcontext.cs (RootContext.LookupType): Return a TypeExpr
12135 * decl.cs (DeclSpace): Implement IAlias.
12136 (DeclSpace.LookupAlias): Return an IAlias instead of a string.
12138 * generic.cs (ConstructedType): Improved error checking.
12140 2004-04-02 Martin Baulig <martin@ximian.com>
12142 * convert.cs: Added type parameter conversions.
12145 (UnboxCast.Emit): Emit an `unbox.any' for type params.
12146 (ClassCast.Emit): If the source type is a type parameter, box it.
12147 If the target type is a type parameter, emit an `unbox.any'
12148 instead of a `classcast'.1
12150 2004-04-01 Martin Baulig <martin@ximian.com>
12152 * cs-tokenizer.cs (parse_less_than): Allow Token.DOT.
12154 2004-04-01 Martin Baulig <martin@ximian.com>
12156 * generic.cs (ConstructedType.CheckConstraints): Use
12157 Convert.ImplicitStandardConversionExists(); user-defined implicit
12158 conversions are not allowed according to the spec.
12160 2004-03-30 Martin Baulig <martin@ximian.com>
12162 * expression.cs (New): Added support for type parameters.
12165 (TypeManager.activator_type): New public static field.
12166 (TypeManager.activator_create_instance): Likewise.
12168 2004-03-30 Martin Baulig <martin@ximian.com>
12170 * typemanager.cs (TypeManager.HasConstructorConstraint): New
12173 2004-03-30 Martin Baulig <martin@ximian.com>
12175 * generic.cs (ConstructedType.CheckConstraints): Actually follow
12176 the spec here: the argument type must be convertible to the
12179 2004-03-30 Martin Baulig <martin@ximian.com>
12182 (TypeParameter.Define, TypeParameter.DefineMethod): Call
12183 TypeManager.AddTypeParameter().
12184 (ConstructedType.CheckConstraints): Re-enable this and actually
12185 check whether we have a constructor constraint.
12188 (TypeManager.builder_to_type_param): New static field.
12189 (TypeManager.AddTypeParameter): New static method.
12190 (TypeManager.LookupTypeParameter): New public method.
12192 2004-03-30 Martin Baulig <martin@ximian.com>
12194 * generic.cs (TypeParameter.DefineType): Return a boolean and use
12195 the new API to actually define the constructor constraint.
12198 (TypeManager.new_constraint_attr_type): New static field.
12199 (TypeManager.InitCoreTypes): Initialize it.
12201 2004-03-30 Martin Baulig <martin@ximian.com>
12203 * generic.cs (Constraints): Completed error checking, use correct
12206 2004-03-29 Martin Baulig <martin@ximian.com>
12208 * delegate.cs (Delegate.VerifyMethod): Infer type arguments.
12210 * expression.cs (Invocation.InferTypeArguments): Added overloaded
12211 public version which takes a `ParameterData pd' instead of an
12214 2004-03-29 Martin Baulig <martin@ximian.com>
12216 * typemanager.cs (TypeManager.IsGenericMethod): Take a MethodBase,
12219 2004-03-29 Martin Baulig <martin@ximian.com>
12221 * expression.cs (Argument.ResolveMethodGroup): If we're a
12222 ConstructedType, call GetMemberAccess() on it.
12224 2004-03-29 Martin Baulig <martin@ximian.com>
12226 * class.cs (MethodBase.CheckGenericOverride): New abstract method.
12227 (MethodCore.CheckGenericOverride): When overriding a generic
12228 method, check whether the constraints match.
12230 * support.cs (GenericConstraints): New public interface.
12231 (ParameterData.GenericConstraints): New public method.
12233 * parameter.cs (Parameter.Resolve): Check whether we're a generic
12234 method parameter and compute our constraints if appropriate.
12235 (Parameter.GenericConstraints): New public property.
12237 * generic.cs (Constraints): Implement GenericConstraints.
12239 2004-03-29 Martin Baulig <martin@ximian.com>
12241 * decl.cs (MemberCache.FindMemberToOverride): Use
12242 `paramTypes [j].Equals (cmpAttrs [j])' instead of `=='.
12244 2004-03-29 Martin Baulig <martin@ximian.com>
12246 * generic.cs (GenericMethod.Define): Resolve our type parameters.
12248 2004-03-29 Martin Baulig <martin@ximian.com>
12250 * cs-parser.jay: Report CS0080 instead of -200 ("Constraints are
12251 not allowed on non-generic declarations").
12253 2004-03-29 Martin Baulig <martin@ximian.com>
12255 * expression.cs (Invocation.InferTypeArguments): Added overloaded
12256 public version of this method.
12258 * class.cs (MethodCore.IsDuplicateImplementation): Use
12259 Invocation.InferTypeArguments() to check this.
12261 2004-03-29 Martin Baulig <martin@ximian.com>
12263 * convert.cs: Use TypeManager.IsDelegateType() instead of
12264 comparing types correctly.
12266 2004-03-29 Martin Baulig <martin@ximian.com>
12268 * convert.cs: Use TypeManager.IsSubclassOf() instead of comparing
12269 types directly to make it work for generic instances.
12271 * typemanager.cs (TypeManager.IsSubclassOf): New static method.
12273 2004-03-29 Martin Baulig <martin@ximian.com>
12275 * typemanager.cs (TypeManager.MayBecomeEqualGenericTypes): Added
12276 support for arrays.
12278 2004-03-24 Martin Baulig <martin@ximian.com>
12280 * decl.cs (DeclSpace.FindType): Also use
12281 TypeManager.CheckGeneric() for types from the using clauses.
12283 2004-03-23 Martin Baulig <martin@ximian.com>
12285 * expression.cs (Invocation.OverloadResolve): Added `bool
12286 may_fail' argument and use it instead of the Location.IsNull() hack.
12288 2004-03-23 Martin Baulig <martin@ximian.com>
12290 * expression.cs (Invocation.InferType): Use correct type inference
12293 2004-03-23 Martin Baulig <martin@ximian.com>
12295 * ecore.cs (MethodGroupExpr.Name): Use
12296 TypeManager.CSharpSignature() instead of just the name.
12298 * expression.cs (Invocation.OverloadResolve): Provide better error
12300 (Invocation.DoResolve): OverloadResolve() never returns null
12301 without reporting an error, so removed the error -6 reporting here.
12303 2004-03-23 Martin Baulig <martin@ximian.com>
12305 * typemanager.cs (TypeManager.GetMethodFlags): Fixed the FIXME for
12308 * cs-parser.jay (delegate_declaration): Support generic delegates.
12310 * delegate.cs: Support generic delegates.
12312 2004-03-22 Martin Baulig <martin@ximian.com>
12314 * expression.cs (Invocation.InferParamsTypeArguments): New static
12315 method; does type inference for params arguments.
12317 2004-03-21 Martin Baulig <martin@ximian.com>
12319 * typemanager.cs (TypeManager.IsGenericMethod): New public static
12320 method; checks whether a method is a generic method.
12322 * expression.cs (Invocation.InferTypeArguments): New static method;
12323 infer type arguments for generic method invocation.
12325 * ecore.cs (MethodGroupExpr.HasTypeArguments): New public
12326 property; we set this to true if we're resolving a generic method
12327 invocation and the user specified type arguments, ie. we're not
12328 doing type inference.
12330 2004-03-20 Martin Baulig <martin@ximian.com>
12332 * class.cs (MethodData.DeclaringType): New public property.
12333 (MethodData.Define): Set DeclaringType here.
12334 (Operator.Define): Use OperatorMethod.MethodData.DeclaringType
12335 instead of OperatorMethodBuilder.DeclaringType.
12337 2004-03-20 Martin Baulig <martin@ximian.com>
12339 * cs-tokenizer.cs (xtoken): Return a special
12340 Token.DEFAULT_OPEN_PARENS for "`default' followed by open parens".
12342 * cs-parser.jay (default_value_expression): Switch to the new
12345 2004-03-19 Martin Baulig <martin@ximian.com>
12347 * decl.cs (MemberName): New class. We use this to "construct"
12348 namespace_or_type_name's.
12350 * generics.cs (TypeArguments.GetDeclarations): New public method;
12351 returns the type arguments as a string[] and reports a CS0081 if
12352 one of them is not an identifier.
12354 * class.cs (MemberBase): The .ctor now takes the name as a
12355 MemberName instead of a string.
12356 (MemberBase.ExplicitInterfaceName): Changed type from string to
12358 (MemberBase.DoDefine): If we're an explicit implementation, the
12359 InterfaceType may be a generic instance.
12361 * cs-parser.jay (namespace_or_type_name): Return a MemberName.
12362 (namespace_name): Call MemberName.GetName () to transform the
12363 MemberName into a string and ensure we don't have any type
12365 (type_name): Call MemberName.GetTypeExpression() to transfrom the
12366 MemberName into an expression.
12367 (method_header): Use namespace_or_type_name instead of member_name.
12369 2004-04-07 Miguel de Icaza <miguel@ximian.com>
12371 * rootcontext.cs: Add new types to the boot resolution.
12373 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
12374 MulticastDelegate is not allowed.
12376 * typemanager.cs: Add new types to lookup: System.TypedReference
12379 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
12380 check for TypedReference or ArgIterator, they are not allowed.
12382 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
12383 makes us properly catch 1510 in some conditions (see bug 56016 for
12386 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
12388 * CryptoConvert.cs: update from corlib version
12391 2004-04-05 Miguel de Icaza <miguel@ximian.com>
12393 * class.cs (Indexer.Define): Check indexername declaration
12395 2004-04-05 Marek Safar <marek.safar@seznam.cz>
12397 * attribute.cs (IsClsCompliant): Fixed problem with handling
12398 all three states (compliant, not-compliant, undetected).
12400 2004-03-30 Marek Safar <marek.safar@seznam.cz>
12402 * attribute.cs (Attribute): Location is now public.
12403 (Resolve): Store resolved arguments (pos_values) in attribute class.
12404 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
12405 (GetClsCompliantAttributeValue): New method that gets
12406 CLSCompliantAttribute value.
12407 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
12408 if exists else null.
12409 (AttributeTester): New class for CLS-Compliant verification routines.
12411 * class.cs (Emit): Add CLS-Compliant verification.
12412 (Method.GetSignatureForError): Implemented.
12413 (Constructor.GetSignatureForError): Implemented
12414 (Constructor.HasCompliantArgs): Returns if constructor has
12415 CLS-Compliant arguments.
12416 (Constructor.Emit): Override.
12417 (Construcor.IsIdentifierClsCompliant): New method; For constructors
12418 is needed to test only parameters.
12419 (FieldBase.GetSignatureForError): Implemented.
12420 (TypeContainer): New member for storing base interfaces.
12421 (TypeContainer.FindMembers): Search in base interfaces too.
12423 * codegen.cs (GetClsComplianceAttribute): New method that gets
12424 assembly or module CLSCompliantAttribute value.
12425 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
12427 (ModuleClass.Emit): Add error 3012 test.
12429 * const.cs (Emit): Override and call base for CLS-Compliant tests.
12431 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
12432 state for all decl types.
12433 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
12434 if CLS-Compliant tests are required.
12435 (IsClsCompliaceRequired): New method. Analyze whether code
12436 must be CLS-Compliant.
12437 (IsExposedFromAssembly): New method. Returns true when MemberCore
12438 is exposed from assembly.
12439 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
12440 value or gets cached value.
12441 (HasClsCompliantAttribute): New method. Returns true if MemberCore
12442 is explicitly marked with CLSCompliantAttribute.
12443 (IsIdentifierClsCompliant): New abstract method. This method is
12444 used to testing error 3005.
12445 (IsIdentifierAndParamClsCompliant): New method. Common helper method
12446 for identifier and parameters CLS-Compliant testing.
12447 (VerifyClsCompliance): New method. The main virtual method for
12448 CLS-Compliant verifications.
12449 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
12450 null. I don't know why is null (too many public members !).
12451 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
12452 and get value of first CLSCompliantAttribute that found.
12454 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
12455 (VerifyClsCompliance): Override and add extra tests.
12457 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
12458 clscheck- disable CLS-Compliant verification event if assembly is has
12459 CLSCompliantAttribute(true).
12461 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
12462 ApllyAttribute is now called in emit section as in the other cases.
12463 Possible future Emit integration.
12464 (IsIdentifierClsCompliant): New override.
12465 (VerifyClsCompliance): New override.
12466 (GetEnumeratorName): Returns full enum name.
12468 * parameter.cs (GetSignatureForError): Implemented.
12470 * report.cs (WarningData): New struct for Warning message information.
12471 (LocationOfPreviousError): New method.
12472 (Warning): New method. Reports warning based on the warning table.
12473 (Error_T): New method. Reports error based on the error table.
12475 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
12476 verifications are done here.
12478 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
12480 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
12481 CLSCompliantAttribute.
12482 (all_imported_types): New member holds all imported types from other
12484 (LoadAllImportedTypes): New method fills static table with exported types
12485 from all referenced assemblies.
12486 (Modules): New property returns all assembly modules.
12488 2004-03-30 Miguel de Icaza <miguel@ximian.com>
12490 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
12491 throwing a parser error.
12493 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
12494 which removes the hardcoded get_/set_ prefixes for properties, as
12495 IL allows for the properties to be named something else.
12499 * expression.cs: Do not override operand before we know if it is
12500 non-null. Fix 56207
12502 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
12504 * typemanager.cs: support for pinned variables.
12506 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
12508 * decl.cs, typemanager.cs: Avoid using an arraylist
12509 as a buffer if there is only one result set.
12511 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
12513 * expression.cs: Make sure you cant call a static method
12514 with an instance expression, bug #56174.
12516 2004-03-29 Miguel de Icaza <miguel@ximian.com>
12518 * class.cs (IsDuplicateImplementation): Improve error reporting to
12519 flag 663 (method only differs in parameter modifier).
12521 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
12522 in preprocessor directives.
12524 * location.cs (LookupFile): Allow for the empty path.
12526 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
12527 better approach for some of that patch, but its failing with the
12528 CharSet enumeration. For now try/catch will do.
12530 * typemanager.cs: Do not crash if a struct does not have fields.
12533 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
12535 * expression.cs: cs0213, cant fix a fixed expression.
12538 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
12540 * cs-parser.jay: detect invalid embeded statements gracefully.
12543 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
12545 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
12548 the invocation type may not be a subclass of the tye of the item/
12549 The type of the item must be a subclass of the invocation item.
12554 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
12556 * attribute.cs: Added methods to get a string and a bool from an
12557 attribute. Required to information from AssemblyKeyFileAttribute,
12558 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
12559 * codegen.cs: Modified AssemblyName creation to include support for
12560 strongnames. Catch additional exceptions to report them as CS1548.
12561 * compiler.csproj: Updated include CryptoConvert.cs.
12562 * compiler.csproj.user: Removed file - user specific configuration.
12563 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
12564 Mono.Security assembly. The original class is maintained and tested in
12565 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
12566 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
12567 like CSC 8.0 (C# v2) supports.
12568 * Makefile: Added CryptoConvert.cs to mcs sources.
12569 * rootcontext.cs: Added new options for strongnames.
12571 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
12573 * driver.cs: For --expect-error, report error code `2'
12574 if the program compiled with no errors, error code `1' if
12575 it compiled with an error other than the one expected.
12577 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
12579 * compiler.csproj: Updated for Visual Studio .NET 2003.
12580 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
12581 * compiler.sln: Updated for Visual Studio .NET 2003.
12583 2004-03-24 Ravi Pratap M <ravi@ximian.com>
12585 * expression.cs: Fix bug #47234. We basically need to apply the
12586 rule that we prefer the conversion of null to a reference type
12587 when faced with a conversion to 'object' (csc behaviour).
12589 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
12591 * statement.cs: Shorter form for foreach, eliminates
12592 a local variable. r=Martin.
12594 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
12596 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
12597 checks if we can use brtrue/brfalse to test for 0.
12598 * expression.cs: use the above in the test for using brtrue/brfalse.
12599 cleanup code a bit.
12601 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
12603 * expression.cs: Rewrite string concat stuff. Benefits:
12605 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
12606 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
12607 rather than a concat chain.
12609 * typemanager.cs: Add lookups for more concat overloads.
12611 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
12613 * expression.cs: Emit shorter il code for array init.
12630 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
12632 * statement.cs: Before, two switch blocks would be merged if the
12633 total size of the blocks (end_item - begin_item + 1) was less than
12634 two times the combined sizes of the blocks.
12636 Now, it will only merge if after the merge at least half of the
12641 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
12643 * class.cs : csc build fix for GetMethods(). See bug #52503.
12645 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
12647 * expression.cs: Make sure fp comparisons work with NaN.
12648 This fixes bug #54303. Mig approved this patch a long
12649 time ago, but we were not able to test b/c the runtime
12652 2004-03-19 Miguel de Icaza <miguel@ximian.com>
12654 * ecore.cs (TypExpr.GetHashCode): implement this overload.
12656 2004-03-19 Martin Baulig <martin@ximian.com>
12658 * class.cs (MemberCore.IsDuplicateImplementation): Check whether
12659 two overloads may unify for some type parameter substitutions and
12660 report a CS0408 if appropriate.
12662 2004-03-19 Martin Baulig <martin@ximian.com>
12664 * class.cs (MemberCore.IsDuplicateImplementation): Report the
12665 error here and not in our caller.
12667 2004-03-19 Martin Baulig <martin@ximian.com>
12669 * interface.cs: Completely killed this file.
12670 (Interface): We're now a TypeContainer and live in class.cs.
12672 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
12673 argument; we're now also called for interfaces.
12674 (TypeContainer.DefineMembers): Allow this method being called
12676 (TypeContainer.GetMethods): New public method; formerly known as
12677 Interface.GetMethod(). This is used by PendingImplementation.
12678 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
12679 it's now private and non-static.
12680 (Interface): Moved this here; it's now implemented similar to
12682 (Method, Property, Event, Indexer): Added `bool is_interface'
12683 argument to their .ctor's.
12684 (MemberBase.IsInterface): New public field.
12686 * cs-parser.jay: Create normal Method, Property, Event, Indexer
12687 instances instead of InterfaceMethod, InterfaceProperty, etc.
12688 (opt_interface_base): Removed; we now use `opt_class_base' instead.
12689 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
12691 2004-03-19 Martin Baulig <martin@ximian.com>
12693 * class.cs (MethodCore.IsDuplicateImplementation): New private
12694 method which does the CS0111 checking.
12695 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
12696 Use IsDuplicateImplementation().
12698 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
12700 * decl.cs (FindMemberToOverride): New method to find the correct
12701 method or property to override in the base class.
12703 - Make Method/Property use the above method to find the
12704 version in the base class.
12705 - Remove the InheritableMemberSignatureCompare as it is now
12708 This patch makes large code bases much faster to compile, as it is
12709 O(n) rather than O(n^2) to do this validation.
12711 Also, it fixes bug 52458 which is that nested classes are not
12712 taken into account when finding the base class member.
12714 Reviewed/Approved by Martin.
12716 2004-03-17 Martin Baulig <martin@ximian.com>
12718 * expression.cs (MemberAccess.DoResolve): Take the parent's number
12719 of type arguments into account; use the `real_num_type_args'
12720 approach like in DoResolveAsTypeStep().
12722 * generic.cs (GenericMemberAccess.DoResolve): Make this work for
12725 2004-03-17 Marek Safar <marek.safar@seznam.cz>
12727 * interface.cs: In all interface classes removed redundant
12728 member initialization.
12730 2004-03-16 Martin Baulig <martin@ximian.com>
12732 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
12734 2004-03-15 Miguel de Icaza <miguel@ximian.com>
12736 * decl.cs (DefineTypeAndParents): New helper method to define a
12737 type's containers before the type itself is defined; This is a
12738 bug exposed by the recent changes to Windows.Forms when an
12739 implemented interface was defined inside a class that had not been
12742 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
12744 (Check): Loop correctly to report errors modifiers
12745 (UNSAFE was not in the loop, since it was the same as TOP).
12747 * interface.cs: Every interface member now takes a ModFlags,
12748 instead of a "is_new" bool, which we set on the base MemberCore.
12750 Every place where we called "UnsafeOk" in the interface, now we
12751 call the proper member (InterfaceMethod.UnsafeOK) instead to get
12752 the unsafe settings from the member declaration instead of the
12753 container interface.
12755 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
12757 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
12758 `set_indexer_name' to the pending bits (one per type).
12760 We fixed a bug today that was picking the wrong method to
12761 override, since for properties the existing InterfaceMethod code
12762 basically ignored the method name. Now we make sure that the
12763 method name is one of the valid indexer names.
12765 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
12767 * support.cs (SeekableStreamReader): Keep track of stream byte
12768 positions and don't mix them with character offsets to the buffer.
12770 Patch from Gustavo Giráldez
12772 2004-03-15 Marek Safar <marek.safar@seznam.cz>
12774 * interface.cs (InterfaceSetGetBase): Removed double member
12775 initialization, base class does it as well.
12777 2004-03-13 Martin Baulig <martin@ximian.com>
12779 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
12780 when compiling corlib.
12782 2004-03-13 Miguel de Icaza <miguel@ximian.com>
12784 * convert.cs (ExplicitConversion): We were reporting an error on
12785 certain conversions (object_type source to a value type, when the
12786 expression was `null') before we had a chance to pass it through
12787 the user defined conversions.
12789 * driver.cs: Replace / and \ in resource specifications to dots.
12792 * class.cs: Add check for duplicate operators. Fixes 52477
12794 2004-03-11 Miguel de Icaza <miguel@ximian.com>
12796 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
12797 that are in the middle of the statements, not only at the end.
12800 * class.cs (TypeContainer.AddField): No longer set the
12801 `HaveStaticConstructor' flag, now we call it
12802 `UserDefineStaticConstructor' to diferentiate the slightly
12803 semantic difference.
12805 The situation is that we were not adding BeforeFieldInit (from
12806 Modifiers.TypeAttr) to classes that could have it.
12807 BeforeFieldInit should be set to classes that have no static
12812 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
12814 And most importantly Zoltan's comment:
12816 http://bugzilla.ximian.com/show_bug.cgi?id=44229
12818 "I think beforefieldinit means 'it's ok to initialize the type sometime
12819 before its static fields are used', i.e. initialization does not need
12820 to be triggered by the first access to the type. Setting this flag
12821 helps the JIT to compile better code, since it can run the static
12822 constructor at JIT time, and does not need to generate code to call it
12823 (possibly lots of times) at runtime. Unfortunately, mcs does not set
12824 this flag for lots of classes like String.
12826 csc sets this flag if the type does not have an explicit static
12827 constructor. The reasoning seems to be that if there are only static
12828 initalizers for a type, and no static constructor, then the programmer
12829 does not care when this initialization happens, so beforefieldinit
12832 This bug prevents the AOT compiler from being usable, since it
12833 generates so many calls to mono_runtime_class_init that the AOT code
12834 is much slower than the JITted code. The JITted code is faster,
12835 because it does not generate these calls if the vtable is type is
12836 already initialized, which is true in the majority of cases. But the
12837 AOT compiler can't do this."
12839 2004-03-10 Miguel de Icaza <miguel@ximian.com>
12841 * class.cs (MethodData.Emit): Refactor the code so symbolic
12842 information is generated for destructors; For some reasons we
12843 were taking a code path that did not generate symbolic information
12846 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
12848 * class.cs: Create a Constructor.CheckBase method that
12849 takes care of all validation type code. The method
12850 contains some code that was moved from Define.
12852 It also includes new code that checks for duplicate ctors.
12853 This fixes bug #55148.
12855 2004-03-09 Joshua Tauberer <tauberer@for.net>
12857 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
12858 a { ... }-style array creation invokes EmitStaticInitializers
12859 which is not good for reference-type arrays. String, decimal
12860 and now null constants (NullCast) are not counted toward
12861 static initializers.
12863 2004-03-05 Martin Baulig <martin@ximian.com>
12865 * location.cs (SourceFile.HasLineDirective): New public field;
12866 specifies whether the file contains or is referenced by a "#line"
12868 (Location.DefineSymbolDocuments): Ignore source files which
12869 either contain or are referenced by a "#line" directive.
12871 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
12873 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
12874 direct access to our parent, so check the method inline there.
12876 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
12878 * expression.cs (Invocation.EmitCall): Miguel's last commit
12879 caused a regression. If you had:
12884 In Foo the implict this would be null.
12886 2004-02-27 Miguel de Icaza <miguel@ximian.com>
12888 * expression.cs (Invocation.EmitCall): If the method is not
12889 virtual, do not emit a CallVirt to it, use Call.
12891 * typemanager.cs (GetFullNameSignature): Improve the method to
12892 cope with ".ctor" and replace it with the type name.
12894 * class.cs (ConstructorInitializer.Resolve): Now the method takes
12895 as an argument the ConstructorBuilder where it is being defined,
12896 to catch the recursive constructor invocations.
12898 2004-03-16 Martin Baulig <martin@ximian.com>
12900 * expression.cs (MemberAccess.DoResolve): If `expr' resolved to a
12901 ConstructedType, call ResolveType() on it to get the type rather
12902 than just using `expr.Type'.
12904 2004-03-16 Martin Baulig <martin@ximian.com>
12906 * generics.cs (ConstructedType.GetMemberAccess): Take the
12907 EmitContext instead on the TypeExpr and use
12908 ec.TypeContainer.CurrentType/ec.ContainerType.
12910 2004-03-16 Martin Baulig <martin@ximian.com>
12912 * ecore.cs (SimpleName.DoResolveAsTypeStep): Lookup type
12913 parameters before aliases.
12915 2004-03-16 Martin Baulig <martin@ximian.com>
12917 * typemanager.cs (TypeManager.MayBecomeEqualGenericInstances):
12918 New oublic function; checks whether two generic instances may become
12919 equal under some instantiations (26.3.1).
12921 * class.cs (TypeContainer.Define): Call
12922 TypeManager.MayBecomeEqualGenericInstances() and report CS0695 on
12925 2004-03-16 Martin Baulig <martin@ximian.com>
12927 * class.cs (TypeContainer.GetClassBases): Moved
12928 Error_TypeParameterAsBase() here and also check whether the base
12929 class is not an attribute.
12931 2004-03-16 Martin Baulig <martin@ximian.com>
12933 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
12935 2004-03-16 Martin Baulig <martin@ximian.com>
12937 * class.cs (Error_TypeParameterAsBase): Use correct error number
12940 2004-03-16 Martin Baulig <martin@ximian.com>
12942 * decl.cs (DeclSpace.ResolveTypeExpr): Added more error checking
12945 * generics.cs (ConstructedType.DoResolveAsTypeStep): Added better
12948 2004-03-15 Martin Baulig <martin@ximian.com>
12950 * typemanager.cs (TypeManager.GetFullName): New public method.
12951 (TypeManager.MemberLookup): Added `int_num_type_arguments'
12952 argument; only return members with the correct number of type
12954 (TypeManager.CheckGeneric): Allow -1 to bypass the check.
12955 (TypeManager.FilterWithClosure): Call CheckGeneric() to check
12956 whether the number of type arguments matches.
12958 * generic.cs (GenericMemberAccess.ResolveAsTypeStep): Allow `expr'
12959 not being a ConstructedType; we can now do "typeof (Foo.Bar<U>)".
12961 * expression.cs (MemberAccess): Added public `NumTypeArguments'
12962 field; it's set by the protected .ctor when we're actually a
12963 GenericMemberAccess.
12964 (MemberAccess.ResolveAsTypeStep): Compute the total number of type
12965 arguments and pass it to MemberLookupFinal ().
12967 * ecore.cs (Expression.MemberLookup): Added `int
12968 num_type_arguments' argument; only return members with the correct
12969 number of type arguments.
12970 (Expression.MemberLookupFailed): Check whether the MemberLookup
12971 failed because we did not have the correct number of type
12972 arguments; report CS0305 in this case.
12974 * decl.cs (DeclSpace.ResolveTypeExpr): Don't report an error if
12975 `e.ResolveAsTypeTerminal()' already did so.
12977 2004-03-15 Martin Baulig <martin@ximian.com>
12979 * ecore.cs (Expression.ResolveLValue): Allow e.type being null if
12980 we're a ConstructedType; in this case, the caller must report an
12981 error (for instance CS0131).
12983 * generic.cs (TypeArguments): Added Location argument to the .ctor.
12984 (TypeArguments.Resolve): Actually report errors here.
12986 2004-03-15 Miguel de Icaza <miguel@ximian.com>
12988 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
12989 `set_indexer_name' to the pending bits (one per type).
12991 We fixed a bug today that was picking the wrong method to
12992 override, since for properties the existing InterfaceMethod code
12993 basically ignored the method name. Now we make sure that the
12994 method name is one of the valid indexer names.
12996 2004-03-15 Martin Baulig <martin@ximian.com>
12998 * typemanager.cs (TypeManager.IndexerPropertyName): Added support
12999 for generic instances.
13001 2004-03-13 Martin Baulig <martin@ximian.com>
13003 * class.cs (TypeContainer.DefineType): Call
13004 TypeManager.AddUserType() immediately after creating the
13005 TypeBuilder; pass all type parameters when creating the
13008 * decl.cs (DeclSpace.FindNestedType): New public method.
13009 (DeclSpace.FindType): Added `int num_type_args' argument; only
13010 return types with the correct number of type parameters.
13011 (DeclSpace.CountTypeParams): New public property.
13013 * ecore.cs (SimpleName.ctor): Added overloaded version which takes
13014 the number of type parameters; defaults to zero.
13016 * generic.cs (TypeArguments.Count): New public property.
13017 (ConstructedType.DoResolveAsTypeStep): First call
13018 ds.FindNestedType() to find out whether we're nested in the
13019 current generic type; in this case, we inherit all type parameters
13020 from the current class.
13022 * rootcontext.cs (RootContext.NamespaceLookup): Added `int
13023 num_type_args' argument.
13024 (RootContext.LookupType): Added overloaded version which takes the
13025 number of type arguments; only return types with the correct
13026 number of type arguments.
13028 * typemanager.cs (TypeManager.CheckGeneric): New public function;
13029 checks whether `Type t' has `int num_type_args'.
13031 2004-03-13 Martin Baulig <martin@ximian.com>
13033 * generic.cs (GenericMethod.DefineType): New method; calls
13034 DefineType() on all the type parameters.
13036 * class.cs (MethodData.ctor): Added `GenericMethod generic' argument.
13037 (MethodData.Define): If we're a generic method, call
13038 GenericMethod.DefineType() to define the type parameters.
13040 2004-03-10 Martin Baulig <martin@ximian.com>
13042 * pending.cs (Pending.InterfaceMethod): Use TypeManager.IsEqual()
13043 instead of IsAssignableFrom.
13045 2004-03-10 Martin Baulig <martin@ximian.com>
13047 * ecore.cs (FieldExpr.ctor): Use TypeManager.TypeToCoreType().
13049 * support.cs (ParameterData.HasArrayParameter): New property.
13050 (ReflectionParameters.ctor): Take a MethodBase instead of a
13051 ParameterInfo[]. If we have any type parameters, get the generic
13052 method definition and ask it whether we have variable arguments.
13054 2004-02-26 Miguel de Icaza <miguel@ximian.com>
13056 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
13057 routines to check if a type is an enumerable/enumerator allow
13058 classes that implement the IEnumerable or IEnumerator interfaces.
13060 * class.cs (Property, Operator): Implement IIteratorContainer, and
13061 implement SetYields.
13063 (Property.Define): Do the block swapping for get_methods in the
13064 context of iterators. We need to check if Properties also
13065 include indexers or not.
13067 (Operator): Assign the Block before invoking the
13068 OperatorMethod.Define, so we can trigger the Iterator code
13071 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
13072 Property and Operator classes are not created when we parse the
13073 declarator but until we have the block completed, so we use a
13074 singleton SimpleIteratorContainer.Simple to flag whether the
13075 SetYields has been invoked.
13077 We propagate this setting then to the Property or the Operator to
13078 allow the `yield' to function.
13080 2004-02-25 Marek Safar <marek.safar@seznam.cz>
13082 * codegen.cs: Implemented attribute support for modules.
13083 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
13084 Assembly/Module functionality.
13086 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
13087 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
13088 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
13090 2004-02-16 Marek Safar <marek.safar@seznam.cz>
13092 * interface.cs (FindMembers): The operation is performed on all base
13093 interfaces and not only on the first. It is required for future CLS Compliance patch.
13095 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
13097 * statement.cs, codegen.cs:
13098 This patch deals with patterns such as:
13100 public class List : IEnumerable {
13102 public MyEnumerator GetEnumerator () {
13103 return new MyEnumerator(this);
13106 IEnumerator IEnumerable.GetEnumerator () {
13110 public struct MyEnumerator : IEnumerator {
13115 Before, there were a few things we did wrong:
13116 1) we would emit callvirt on a struct, which is illegal
13117 2) we emited ldarg when we needed to emit ldarga
13118 3) we would mistakenly call the interface methods on an enumerator
13119 type that derived from IEnumerator and was in another assembly. For example:
13121 public class MyEnumerator : IEnumerator
13123 Would have the interface methods called, even if there were public impls of the
13124 method. In a struct, this lead to invalid IL code.
13126 2004-02-11 Marek Safar <marek.safar@seznam.cz>
13128 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
13131 * delegate.cs (Define): Fixed crash when delegate type is undefined.
13133 2004-02-11 Miguel de Icaza <miguel@ximian.com>
13135 * cs-parser.jay: Fix small regression: we were not testing V2
13136 compiler features correctly.
13138 * interface.cs: If the emit context is null, then create one
13140 2004-02-09 Marek Safar <marek.safar@seznam.cz>
13142 * decl.cs (GetSignatureForError): New virtual method to get full name
13143 for error messages.
13145 * attribute.cs (IAttributeSupport): New interface for attribute setting.
13146 Now it is possible to rewrite ApplyAttributes method to be less if/else.
13148 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
13149 Duplicated members and code in these classes has been removed.
13150 Better encapsulation in these classes.
13152 2004-02-07 Miguel de Icaza <miguel@ximian.com>
13154 * assign.cs (Assign.DoResolve): When dealing with compound
13155 assignments, there is a new rule in ECMA C# 2.4 (might have been
13156 there before, but it is documented here) that states that in:
13160 If b is of type int, and the `op' is a shift-operator, then the
13161 above is evaluated as:
13165 * expression.cs (Binary.ResolveOperator): Instead of testing for
13166 int/uint/long/ulong, try to implicitly convert to any of those
13167 types and use that in pointer arithmetic.
13169 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
13170 method to print information for from the type, not from the
13171 null-method we were given.
13173 2004-02-01 Duncan Mak <duncan@ximian.com>
13175 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
13176 parsing for cmd, fixes bug #53694.
13178 2004-02-04 Marek Safar <marek.safar@seznam.cz>
13180 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
13181 in the member name duplication tests. Property and operator name duplication
13182 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
13184 2004-02-03 Marek Safar <marek.safar@seznam.cz>
13186 * interface.cs (PopulateMethod): Fixed crash when interface method
13187 returns not existing type (error test cs0246-3.cs).
13189 2004-02-02 Ravi Pratap M <ravi@ximian.com>
13191 * cs-parser.jay (interface_accessors): Re-write actions to also
13192 store attributes attached to get and set methods. Fix spelling
13195 (inteface_property_declaration): Modify accordingly.
13197 (InterfaceAccessorInfo): New helper class to store information to pass
13198 around between rules that use interface_accessors.
13200 * interface.cs (Emit): Apply attributes on the get and set
13201 accessors of properties and indexers too.
13203 * attribute.cs (ApplyAttributes): Modify accordingly to use the
13204 right MethodBuilder when applying attributes to the get and set accessors.
13206 2004-01-31 Miguel de Icaza <miguel@ximian.com>
13208 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
13210 2004-01-26 Miguel de Icaza <miguel@ximian.com>
13212 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
13214 2004-01-25 Miguel de Icaza <miguel@ximian.com>
13216 * cs-parser.jay: Remove YIELD token, instead use the new grammar
13217 changes that treat `yield' specially when present before `break'
13218 or `return' tokens.
13220 * cs-tokenizer.cs: yield is no longer a keyword.
13222 2004-01-23 Marek Safar <marek.safar@seznam.cz>
13224 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
13225 setting for default constructors.
13226 For default constructors are almost every time set wrong Modifier. The
13227 generated IL code has been alright. But inside mcs this values was
13228 wrong and this was reason why several of my CLS Compliance tests
13231 2004-02-27 Martin Baulig <martin@ximian.com>
13233 * generics.cs (ConstructedType.ResolveType): Make the nested type
13234 stuff actually work.
13236 2004-02-25 Martin Baulig <martin@ximian.com>
13238 * decl.cs (DeclSpace.CurrentTypeParameters): New protected
13239 property; returns the type parameters just from the current type,
13240 ie. with the ones from outer classes.
13241 (DeclSpace.LookupGeneric): First search in the current class, then
13243 (DeclSpace.initialize_type_params): When hiding a type parameter
13244 from an outer class, put it into the `type_param_list' anyways.
13246 * expression.cs (MemberAccess.expr): Made this field protected.
13248 * class.cs (TypeContainer.Define): The `CurrentType' just contains
13249 the type parameters from the current class.
13251 * generic.cs (ConstructedType.ResolveType): Support nested generic
13252 types by taking the type parameters which we inherit from outer
13253 classes into account.
13254 (GenericMemberAccess.ResolveAsTypeStep): Override this and added
13255 support for nested generic types.
13257 2004-02-23 Martin Baulig <martin@ximian.com>
13259 * decl.cs (DeclSpace.IsGeneric): Make this a property instead of a
13260 field and check whether we're nested inside a generic type.
13261 (DeclSpace.ResolveType): If we're resolving to a generic type
13262 definition, create a ConstructedType and return its resolved type.
13263 (DeclSpace.initialize_type_params): New private method;
13264 initializes the `type_param_list' field from the type parameters
13265 from this and all enclosing classes.
13266 (DeclSpace.TypeParameters): Call initialize_type_params() unless
13267 we're already initialized.
13269 2004-02-23 Martin Baulig <martin@ximian.com>
13271 * class.cs (Method.Define): Create the generic method before
13272 calling DoDefine().
13273 (Memberbase.DoDefine): Added DeclSpace argument (in addition to
13274 the TypeContainer one); we use this for generic methods.
13276 * decl.cs (CheckAccessLevel): If we're a GenericMethod, use our
13277 parent's TypeBuilder.
13279 2004-02-18 Martin Baulig <martin@ximian.com>
13281 * ecore.cs (FieldExpr.DoResolveLValue): Use TypeManager.IsEqual()
13282 to check for equality.
13284 2004-02-05 Martin Baulig <martin@ximian.com>
13286 * ecore.cs (FieldExpr.DoResolveLValue): If we have an
13287 `ec.TypeContainer.CurrentType', use it instead of
13288 `ec.ContainerType' to check whether we're in the type's ctor.
13290 2004-01-29 Martin Baulig <martin@ximian.com>
13292 * expression.cs (Invocation.DoResolve): If we're a
13293 `ConstructedType', then we're actually a generic method, so
13294 rewrite the expr as a GenericMemberAccess.
13296 * cs-parser.jay (member_name): Don't use `namespace_or_type_name'
13297 here; manually parse it into a string.
13299 2004-01-28 Martin Baulig <martin@ximian.com>
13301 * typemanager.cs (TypeManager.IsEqual): New static method.
13302 (TypeManager.FilterWithClosure): Call TypeManager.IsEqual() to
13303 check for equality instead of using `=='.
13305 2004-01-26 Martin Baulig <martin@ximian.com>
13307 * decl.cs (DeclSpace.CurrentType): New public field.
13309 * expression.cs (This.ResolveBase): If we have an
13310 `ec.TypeContainer.CurrentType', use it instead of
13311 `ec.ContainerType'.
13313 * class.cs (TypeContainer.DefineType): If we're a generic type,
13314 create the `CurrentType' (unresolved).
13315 (TypeContainer.GenericType): New private field.
13316 (TypeContainer.DefineMembers): If we have a `CurrentType', resolve
13317 it and store it in `GenericType' before creating the MemberCache.
13318 (TypeContainer.GetMembers): If we have a `GenericType', call
13319 TypeManager.FindMembers() on it.
13321 * interface.cs (Interface.GenericType): New private field.
13322 (Interface.DefineType): If we're a generic type, create the
13323 `CurrentType' (unresolved).
13324 (Interface.DefineMembers): If we have a `CurrentType', resolve it
13325 and store it in `GenericType' before creating the MemberCache.
13326 (Interface.GetMembers): If we have a `GenericType', call
13327 TypeManager.FindMembers() on it.
13329 2004-01-22 Martin Baulig <martin@ximian.com>
13331 * cs-parser.jay (namespace_or_type_name): Return an Expression,
13332 not a QualifiedIdentifier. This is what `type_name_expression'
13333 was previously doing.
13334 (type_name_expression): Removed; the code is now in
13335 `namespace_or_type_name'.
13336 (qualified_identifier): Removed, use `namespace_or_type_name'
13338 (QualifiedIdentifier): Removed this class.
13340 2004-01-22 Martin Baulig <martin@ximian.com>
13342 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
13343 not a string as alias name.
13345 2004-01-21 Miguel de Icaza <miguel@ximian.com>
13347 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
13348 #52730 bug, and instead compute correctly the need to use a
13349 temporary variable when requesting an address based on the
13350 static/instace modified of the field and the constructor.
13352 2004-01-21 Martin Baulig <martin@ximian.com>
13354 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
13355 class and namespace before looking up aliases. Fixes #52517.
13357 2004-01-21 Martin Baulig <martin@ximian.com>
13359 * flowanalysis.cs (UsageVector.Merge): Allow variables being
13360 assinged in a 'try'; fixes exception4.cs.
13362 2004-01-21 Marek Safar <marek.safar@seznam.cz>
13363 * class.cs : Implemented parameter-less constructor for TypeContainer
13365 * decl.cs: Attributes are now stored here. New property OptAttributes
13367 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
13369 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
13371 2004-01-21 Marek Safar <marek.safar@seznam.cz>
13373 * typemanager.cs (CSharpSignature): Now reports also inner class name.
13374 (CSharpSignature): New method for indexer and property signature.
13376 2004-01-21 Marek Safar <marek.safar@seznam.cz>
13378 * pending.cs (IsVirtualFilter): Faster implementation.
13380 2004-01-21 Marek Safar <marek.safar@seznam.cz>
13382 * typemanager.cs: Avoid inclusion of same assembly more than once.
13384 2004-01-21 Marek Safar <marek.safar@seznam.cz>
13386 * cs-parser.jay: Fixed problem where the last assembly attribute
13387 has been applied also to following declaration (class, struct, etc.)
13389 2004-01-21 Marek Safar <marek.safar@seznam.cz>
13391 * class.cs: Added error CS0538, CS0539 reporting.
13392 Fixed crash on Microsoft runtime when field type is void.
13394 * cs-parser.jay: Added error CS0537 reporting.
13396 * pending.cs: Added error CS0535 reporting.
13397 Improved error report for errors CS0536, CS0534.
13399 2004-01-20 Miguel de Icaza <miguel@ximian.com>
13401 Merge a few bits from the Anonymous Method MCS tree.
13403 * statement.cs (ToplevelBlock): New class for toplevel methods,
13404 will hold anonymous methods, lifted variables.
13406 * cs-parser.jay: Create toplevel blocks for delegates and for
13407 regular blocks of code.
13409 2004-01-20 Martin Baulig <martin@ximian.com>
13411 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
13412 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
13413 and `NeedExplicitReturn'; added `IsLastStatement'.
13414 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
13415 have a `ReturnLabel' or we're not unreachable.
13417 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
13418 child's reachability; don't just override ours with it. Fixes
13419 #58058 (lluis's example).
13420 (FlowBranching): Added public InTryOrCatch(), InCatch(),
13421 InFinally(), InLoop(), InSwitch() and
13422 BreakCrossesTryCatchBoundary() methods.
13424 * statement.cs (Return): Do all error checking in Resolve().
13425 Unless we are the last statement in a top-level block, always
13426 create a return label and jump to it.
13427 (Break, Continue): Do all error checking in Resolve(); also make
13428 sure we aren't leaving a `finally'.
13429 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
13430 statement in a top-level block.
13431 (Block.Flags): Added `IsDestructor'.
13432 (Block.IsDestructor): New public property.
13434 2004-01-20 Martin Baulig <martin@ximian.com>
13436 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
13438 2004-01-20 Martin Baulig <martin@ximian.com>
13440 * statement.cs (Statement.ResolveUnreachable): New public method.
13441 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
13442 (Block.Resolve): Resolve unreachable statements.
13444 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
13446 * expression.cs: We need to fix the case where we do
13447 not have a temp variable here.
13449 * assign.cs: Only expression compound assignments need
13450 temporary variables.
13452 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
13454 * flowanalysis.cs: Reduce memory allocation in a few ways:
13455 - A block with no variables should not allocate a bit
13457 - A method with no out parameters does not need any tracking
13458 for assignment of the parameters, so we need not allocate
13461 public readonly Type[] VariableTypes;
13462 public readonly string[] VariableNames;
13463 Are redundant. The data is already stored in the variable
13464 map, so we need not allocate another array for it.
13465 - We need to add alot of checks for if (params | locals) == null
13466 due to the first two changes.
13468 2004-01-18 Miguel de Icaza <miguel@ximian.com>
13470 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
13471 implement IMemoryLocation, we store a copy on a local variable and
13472 take the address of it. Patch from Benjamin Jemlich
13474 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
13475 to use a special "type_name_expression" rule which reduces the
13476 number of "QualifiedIdentifier" classes created, and instead
13477 directly creates MemberAccess expressions.
13479 2004-01-17 Miguel de Icaza <miguel@ximian.com>
13481 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
13482 that fixes #52853. Null literal assignment to ValueType
13484 * class.cs (MethodData.Emit): Instead of checking the name of the
13485 method to determine if its a destructor, create a new derived
13486 class from Method called Destructor, and test for that.
13488 * cs-parser.jay: Create a Destructor object instead of a Method.
13490 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
13494 2004-01-16 Miguel de Icaza <miguel@ximian.com>
13496 * expression.cs (Binary.ResolveOperator): Perform an implicit
13497 conversion from MethodGroups to their delegate types on the
13498 Addition operation.
13500 * delegate.cs: Introduce a new class DelegateCreation that is the
13501 base class for `NewDelegate' and `ImplicitDelegateCreation',
13502 factor some code in here.
13504 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
13505 conversion from MethodGroups to compatible delegate types.
13507 * ecore.cs (Expression.Resolve): Do not flag error 654
13508 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
13509 we allow conversions from MethodGroups to delegate types now.
13511 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
13512 assignments in v2 either.
13514 2004-01-10 Miguel de Icaza <miguel@ximian.com>
13516 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
13517 static read-only fields in ctors.
13519 Applied patch from Benjamin Jemlich
13521 * expression.cs (UnaryMutator): Avoid leaking local variables.
13523 2004-01-09 Miguel de Icaza <miguel@ximian.com>
13525 * cs-tokenizer.cs (IsCastToken): Allow the various native types
13526 here to return true, as they can be used like this:
13528 (XXX) int.MEMBER ()
13530 Fixed 49836 and all the other dups
13532 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
13534 * driver.cs: Implement /win32res and /win32icon.
13536 2004-01-08 Miguel de Icaza <miguel@ximian.com>
13538 * cs-parser.jay: Add a rule to improve error handling for the
13539 common mistake of placing modifiers after the type.
13541 2004-01-07 Miguel de Icaza <miguel@ximian.com>
13543 * cs-parser.jay (interface_event_declaration): Catch
13544 initialization of events on interfaces, and report cs0068
13546 * cs-parser.jay (interface_event_declaration): Catch
13547 initialization of events.
13549 * ecore.cs: Better report missing constructors.
13551 * expression.cs (Binary.ResolveOperator): My previous bug fix had
13552 the error reporting done in the wrong place. Fix.
13554 * expression.cs (Binary.ResolveOperator): Catch the
13555 operator + (E x, E y) error earlier, and later allow for implicit
13556 conversions in operator +/- (E e, U x) from U to the underlying
13559 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
13560 52596, if the container class is abstract, the default constructor
13561 is protected otherwise its public (before, we were always public).
13563 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
13566 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
13567 Jemlich that fixes bug #52597, MCS was generating invalid code for
13568 idisposable structs. Thanks to Ben for following up with this
13571 2004-01-06 Miguel de Icaza <miguel@ximian.com>
13573 * driver.cs: Allow assemblies without code to be generated, fixes
13576 2004-01-07 Nick Drochak <ndrochak@gol.com>
13578 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
13580 2004-01-05 Miguel de Icaza <miguel@ximian.com>
13582 * cs-parser.jay: Add rules to improve error reporting if fields or
13583 methods are declared at the namespace level (error 116)
13585 * Add rules to catch event add/remove
13587 2004-01-04 David Sheldon <dave-mono@earth.li>
13589 * expression.cs: Added matching ")" to error message for
13592 2004-01-03 Todd Berman <tberman@gentoo.org>
13594 * ecore.cs, attribute.cs:
13595 Applying fix from #52429.
13597 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
13599 * ecore.cs, expression.cs, statement.cs:
13600 Total rewrite of how we handle branching. We
13601 now handle complex boolean expressions with fewer
13602 jumps. As well if (x == 0) no longer emits a ceq.
13604 if (x is Foo) is much faster now, because we generate
13607 Overall, we get a pretty big improvement on our benchmark
13608 tests. The code we generate is smaller and more readable.
13610 I did a full two-stage bootstrap. The patch was reviewed
13611 by Martin and Miguel.
13613 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
13615 * cs-parser.jay: Make primary_expression not take a QI.
13616 we dont need this because the member_access rule covers
13617 us here. So we replace the rule with just IDENTIFIER.
13619 This has two good effects. First, we remove a s/r conflict.
13620 Second, we allocate many fewer QualifiedIdentifier objects.
13622 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
13624 * attribute.cs: Handle MarshalAs attributes as pseudo, and
13625 set the correct information via SRE. This prevents
13626 hanging on the MS runtime. Fixes #29374.
13628 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
13630 * convert.cs: correctly handle conversions to value types
13631 from Enum and ValueType as unboxing conversions.
13633 Fixes bug #52569. Patch by Benjamin Jemlich.
13635 2004-01-02 Ravi Pratap <ravi@ximian.com>
13637 * expression.cs (BetterConversion): Prefer int -> uint
13638 over int -> ulong (csc's behaviour). This fixed bug #52046.
13640 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
13642 * decl.cs (MemberCache.FindMembers): now returns a
13645 * typemanager.cs: In general, go with with ^^.
13646 (CopyNewMethods): take an IList.
13647 (RealMemberLookup): Only allocate an arraylist
13648 if we copy from two sets of methods.
13650 This change basically does two things:
13651 1) Fewer array lists allocated due to CopyNewMethods.
13652 2) the explicit cast in MemberList costed ALOT.
13654 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
13656 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
13657 a hashtable to avoid needless string allocations when an identifier is
13658 used more than once (the common case).
13660 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
13662 * pending.cs: MS's TypeBuilder.GetInterfaces ()
13663 is broken, it will not return anything. So, we
13664 have to use the information we have in mcs to
13667 * typemanager.cs: Add a cache for GetInterfaces,
13668 since this will now be used more often (due to ^^)
13670 (GetExplicitInterfaces) New method that gets the
13671 declared, not effective, interfaces on a type
13672 builder (eg, if you have interface IFoo, interface
13673 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
13676 This patch makes MCS able to bootstrap itself on
13679 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
13681 * expression.cs: Remove the Nop's that Miguel put
13684 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
13686 * report.cs, codegen.cs: Give the real stack trace to
13687 the error when an exception is thrown.
13689 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
13691 * decl.cs: only allocate hashtables for ifaces if
13694 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
13696 * expression.cs: fix the error from cs0121-2.cs
13697 (a parent interface has two child interfaces that
13698 have a function with the same name and 0 params
13699 and the function is called through the parent).
13701 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
13703 * class.cs, rootcontext.cs, typmanager.cs: do not
13706 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
13708 * codegen.cs: remove stack for the ec flow branching.
13709 It is already a linked list, so no need.
13711 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
13713 * Makefile: Allow custom profiler here.
13715 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
13717 * typemanager.cs (LookupType):
13718 - Use a static char [], because split takes
13719 a param array for args, so it was allocating
13721 - Do not store true in a hashtable, it boxes.
13723 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
13725 * flowanalysis.cs: bytify common enums.
13727 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
13729 * modifiers.cs: Add a new set of flags for the
13730 flags allowed on explicit interface impls.
13731 * cs-parser.jay: catch the use of modifiers in
13732 interfaces correctly.
13733 * class.cs: catch private void IFoo.Blah ().
13735 All related to bug #50572.
13737 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
13739 * decl.cs: Rewrite the consistant accessability checking.
13740 Accessability is not linear, it must be implemented in
13741 a tableish way. Fixes #49704.
13743 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
13745 * expression.cs: Handle negation in a checked context.
13746 We must use subtraction from zero. Fixes #38674.
13748 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
13750 * class.cs: Ignore static void main in DLLs.
13751 * rootcontext.cs: Handle the target type here,
13752 since we are have to access it from class.cs
13753 * driver.cs: account for the above.
13755 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
13757 * report.cs: Give line numbers and files if available.
13759 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
13761 * driver.cs: Implement /addmodule.
13763 * typemanager.cs: Change 'modules' field so it now contains Modules not
13766 2003-12-20 Martin Baulig <martin@ximian.com>
13768 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
13769 (FieldBase.IsAssigned): Removed this field.
13770 (FieldBase.SetAssigned): New public method.
13771 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
13773 2003-12-20 Martin Baulig <martin@ximian.com>
13775 * expression.cs (LocalVariableReference.DoResolve): Don't set
13776 `vi.Used' if we're called from DoResolveLValue().
13778 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
13779 returns the usage vector it just merged into the current one -
13780 pass this one to UsageWarning().
13781 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
13782 of the `EmitContext', don't call this recursively on our children.
13784 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
13786 * driver.cs: Implement /target:module.
13788 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
13790 * support.cs (CharArrayHashtable): New helper class.
13792 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
13793 char arrays, not strings, so we can avoid creating a string in
13794 consume_identifier if the identifier is a keyword.
13796 2003-12-16 Martin Baulig <martin@ximian.com>
13798 * statement.cs (LocalInfo.Assigned): Removed this property.
13799 (LocalInfo.Flags): Removed `Assigned'.
13800 (LocalInfo.IsAssigned): New public method; takes the EmitContext
13801 and uses flow analysis.
13802 (Block.UsageWarning): Made this method private.
13803 (Block.Resolve): Call UsageWarning() if appropriate.
13805 * expression.cs (LocalVariableReference.DoResolve): Always set
13806 LocalInfo.Used here.
13808 2003-12-13 Martin Baulig <martin@ximian.com>
13810 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
13811 any value here; we're now using flow analysis to figure out
13812 whether a statement/block returns a value.
13814 2003-12-13 Martin Baulig <martin@ximian.com>
13816 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
13818 (FlowBranching.MergeFinally): Don't call
13819 `branching.CheckOutParameters()' here, this is called in
13821 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
13822 when adding the `finally' vector.
13824 2003-12-13 Martin Baulig <martin@ximian.com>
13827 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
13828 actually work and also fix #48962.
13830 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
13832 * decl.cs: Do not check System.Object for nested types,
13833 since we know it does not have any. Big bang for buck:
13836 Run 1: 8.35 seconds
13837 Run 2: 8.32 seconds
13838 corlib: 17.99 seconds
13840 Run 1: 8.17 seconds
13841 Run 2: 8.17 seconds
13842 corlib: 17.39 seconds
13844 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
13846 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
13847 time we are returning 0 members, so we save alot here.
13849 2003-12-11 Martin Baulig <martin@ximian.com>
13851 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
13852 `MergeChild()', also just take the `FlowBranching' as argument;
13853 call Merge() on it and return the result.
13854 (FlowBranching.Merge): We don't need to do anything if we just
13857 2003-12-11 Martin Baulig <martin@ximian.com>
13859 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
13860 them in an `ArrayList' to reduce memory usage. Thanks to Ben
13861 Maurer for this idea.
13863 2003-12-11 Martin Baulig <martin@ximian.com>
13865 * flowanalysis.cs (MergeResult): This class is now gone; we now
13866 use the `UsageVector' for this. The reason for this is that if a
13867 branching just has one sibling, we don't need to "merge" them at
13868 all - that's the next step to do.
13869 (FlowBranching.Merge): We now return a `UsageVector' instead of a
13872 2003-12-11 Martin Baulig <martin@ximian.com>
13874 Reworked flow analyis and made it more precise and bug-free. The
13875 most important change is that we're now using a special `Reachability'
13876 class instead of having "magic" meanings of `FlowReturns'. I'll
13877 do some more cleanups and optimizations and also add some more
13878 documentation this week.
13880 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
13881 largely reworked this class.
13882 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
13883 the new `Reachability' class instead of having "magic" values here.
13884 (FlowBranching): We're now using an instance of `Reachability'
13885 instead of having separate `Returns', `Breaks' etc. fields.
13887 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
13888 based on flow analysis; ignore the return value of block.Emit ().
13890 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
13892 * driver.cs typemanager.cs: Find the mono extensions to corlib even
13893 if they are private.
13895 2003-12-09 Martin Baulig <martin@ximian.com>
13897 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
13898 call them directly on the UsageVector.
13900 2003-12-09 Martin Baulig <martin@ximian.com>
13902 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
13903 Changed return type from `FlowReturns' to `Reachability'.
13905 2003-12-09 Martin Baulig <martin@ximian.com>
13907 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
13908 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
13909 `Reachable' fields with a single `Reachability' one.
13911 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
13913 * class.cs (FindMembers): Remove foreach's.
13918 Run 1: 8.74 seconds
13919 Run 2: 8.71 seconds
13922 Run 1: 8.64 seconds
13923 Run 2: 8.58 seconds
13926 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
13931 This patch does a few things:
13932 1. EmptyStatement is now a singleton, so it is never reallocated.
13933 2. All blah is EmptyStatement constructs have been changed to
13934 blah == EmptyStatement.Value, which is much faster and valid
13935 now that EmptyStatement is a singleton.
13936 3. When resolving a block, rather than allocating a new array for
13937 the non-empty statements, empty statements are replaced with
13938 EmptyStatement.Value
13939 4. Some recursive functions have been made non-recursive.
13940 Mainly the performance impact is from (3), however (1) and (2) are needed for
13941 this to work. (4) does not make a big difference in normal situations, however
13942 it makes the profile look saner.
13947 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
13948 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
13949 Total memory allocated: 56397 KB
13952 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
13953 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
13954 Total memory allocated: 55666 KB
13956 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
13958 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
13959 than the hashtable in a hashtable version
13961 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
13962 we always end up concating a string. This results in a huge perf
13963 loss, because many strings have to be tracked by the GC. In this
13964 patch, we first use a hashtable that works with two keys, so that
13965 the strings do not need to be concat'ed.
13969 Run 1: 8.74 seconds
13970 Run 2: 8.71 seconds
13973 Run 1: 8.65 seconds
13974 Run 2: 8.56 seconds
13976 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
13978 * Makefile: Add a new target `do-time' that does a quick and simple
13979 profile, leaving easy to parse output.
13981 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
13983 * codegen.cs (Init): Create the dynamic assembly with
13984 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
13986 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
13988 * support.cs: Make the PtrHashtable use only one
13989 instance of its comparer.
13991 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
13993 * typemanager.cs: Fix lookup of GetNamespaces.
13995 2003-11-29 Miguel de Icaza <miguel@ximian.com>
13997 * expression.cs: Removed redundant line.
13999 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
14000 ArrayLists, use for loops with bounds.
14002 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
14005 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
14006 arraylists, use for loop with bounds.
14008 The above three changes give us a 0.071 second performance
14009 improvement out of 3.294 seconds down to 3.223. On my machine
14010 the above changes reduced the memory usage by 1,387 KB during
14011 compiler bootstrap.
14013 * cs-parser.jay (QualifiedIdentifier): New class used to represent
14014 QualifiedIdentifiers. Before we created a new string through
14015 concatenation, and mostly later on, the result would be
14016 manipulated by DecomposeQI through string manipulation.
14018 This reduced the compiler memory usage for bootstrapping from
14019 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
14020 compile times in 0.05 seconds.
14022 2003-11-28 Dick Porter <dick@ximian.com>
14024 * support.cs: Do string compares with the Invariant culture.
14032 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
14033 the comparison is done with the Invariant culture.
14035 2003-11-27 Miguel de Icaza <miguel@ximian.com>
14037 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
14038 GetEnumerator method.
14040 (ProbeCollectionType): Iterate starting at the most specific type
14041 upwards looking for a GetEnumerator
14043 * expression.cs: Shift count can be up to 31 for int/uint and 63
14046 2003-11-26 Miguel de Icaza <miguel@ximian.com>
14048 * statement.cs (Block.LookupLabel): Also look for the label on the
14049 children blocks. Use a hash table to keep track of visited
14052 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
14053 we actually did transform the other operand, otherwise fall back
14054 to the common codepath that casts to long.
14056 * cs-tokenizer.cs: Use the same code pattern as the int case.
14057 Maybe I should do the parsing myself, and avoid depending on the
14058 Parse routines to get this done.
14060 2003-11-25 Miguel de Icaza <miguel@ximian.com>
14062 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
14063 which fixes bug 51347. This time test it.
14065 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
14066 attributes for example can not tell the difference between these.
14067 The difference was only a syntax feature of the language.
14069 * attribute.cs: Apply attributes to delegates.
14071 * delegate.cs: Call the apply attributes method.
14073 2003-11-24 Miguel de Icaza <miguel@ximian.com>
14075 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
14076 comparing 0 vs Byte.MinValue, not the value
14078 (ImplicitConversionRequired): When reporting a conversion error,
14079 use error 31 to print out the constant error instead of the
14082 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
14083 which fixes bug 51347.
14085 2003-11-22 Miguel de Icaza <miguel@ximian.com>
14087 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
14088 which fixes the -warnaserror command line option.
14090 2003-11-21 Miguel de Icaza <miguel@ximian.com>
14092 * cfold.cs (DoNumericPromotions): During constant folding of
14093 additions on UIntConstant, special case intconstants with
14094 IntConstants like we do on the expression binary operator.
14096 2003-11-12 Miguel de Icaza <miguel@ximian.com>
14098 * convert.cs (ImplicitReferenceConversion): We were missing a case
14099 (System.Enum are not value types or class types, so we need to
14100 classify them separatedly).
14102 * driver.cs: We do not support error 2007.
14104 2003-11-12 Jackson Harper <jackson@ximian.com>
14106 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
14107 system directory. Also use the full file name so users can
14108 libraries names mscorlib-o-tron.dll in a non system dir.
14110 2004-01-04 David Sheldon <dave-mono@earth.li>
14112 * expression.cs: Added matching ")" to error message for CS0077.
14114 2003-12-19 Martin Baulig <martin@ximian.com>
14116 * typemanager.cs (TypeManager.IsEqualGenericType): New public
14117 static method; see documentation in the method.
14118 (TypeManager.IsSubclassOrNestedChild): Allow IsEqualGenericType().
14120 * convert.cs (Convert.ImplicitReferenceConversion,
14121 Convert.ImplicitReferenceConversionExists): Add support for
14122 generic type declarations; see gen-36.cs.
14124 2003-12-19 Martin Baulig <martin@ximian.com>
14126 * pending.cs (Pending.InterfaceMethod): Use
14127 `Type.IsAssignableFrom()' instead of `=='.
14129 2003-12-18 Martin Baulig <martin@ximian.com>
14131 * decl.cs (DeclSpace.AsAccessible): Check for array, pointer and
14134 * convert.cs (Convert.ImplicitStandardConversionExists): Use
14135 `expr_type.Equals (target_type)' instead of `=='.
14137 2003-12-08 Martin Baulig <martin@ximian.com>
14139 * generics.cs (Constraints.Types): Removed.
14140 (Constraints.Resolve): Just resolve everything to TypeExpr's, not
14142 (Constraints.ResolveTypes): New public method; resolves the
14143 TypeExpr's to Type's.
14144 (TypeParameter.Define): TypeBuilder.DefineGenericParameter() no
14145 longer takes the constraints.
14146 (TypeParameter.DefineMethod): Likewise.
14147 (TypeParameter.DefineType): New public method. Calls
14148 `TypeBuilder/MethodBuilder.SetGenericParameterConstraints()' to set
14151 2003-12-08 Martin Baulig <martin@ximian.com>
14153 * convert.cs (Convert.ImplicitConversionStandard): Use
14154 `expr_type.Equals (target_type)' instead of `=='.
14156 2003-12-08 Martin Baulig <martin@ximian.com>
14158 * typemanager.cs (TypeManager.GetReferenceType): Call
14159 `Type.MakeByRefType ()'.
14161 2003-12-08 Martin Baulig <martin@ximian.com>
14163 * cs-parser.jay, cs-tokenizer.cs: `where' is not a keyword, it
14164 just has some special meaning in some situations. For instance,
14165 it is allowed to use `where' as the name of a variable etc.
14167 2003-12-04 Martin Baulig <martin@ximian.com>
14169 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
14170 `Type.MakeArrayType()' for array types.
14172 2003-11-18 Miguel de Icaza <miguel@ximian.com>
14174 * expression.cs (Invocation.VerifyArgumentsCompat): Remove
14177 (SizeOf.DoResolve): assign the `type_queried' field. This gets
14180 2003-11-16 Martin Baulig <martin@ximian.com>
14182 * codegen.cs (EmitContext.IsGeneric): Removed.
14184 * ecore.cs (SimpleName.ResolveAsTypeStep): Always call
14185 ResolveGeneric() on the DeclSpace.
14187 2003-11-16 Martin Baulig <martin@ximian.com>
14189 * generic.cs (TypeArguments.Resolve):
14190 `Expression.ResolveAsTypeTerminal()' returns a TypeExpr; call
14191 `ResolveType()' on it to get the Type.
14193 2003-11-15 Martin Baulig <martin@ximian.com>
14195 * generic.cs (ConstructedType.GetInterfaces): Override this.
14197 2003-11-14 Martin Baulig <martin@ximian.com>
14199 * interface.cs (Interface.DefineType): Define all type parameters
14200 before adding the interfaces we inherit.
14202 2003-11-11 Martin Baulig <martin@ximian.com>
14204 * generic.cs (ConstructedType.ResolveType): Always call
14205 `gt.BindGenericParameters (atypes)'; also if `args.HasTypeArguments'.
14207 2003-11-10 Martin Baulig <martin@ximian.com>
14209 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
14210 (TypeManager.InitCoreTypes): Initialize them here, but instead of
14211 calling `ResolveType()' on them, directly assign their `Type'.
14213 2003-11-08 Martin Baulig <martin@ximian.com>
14215 * generic.cs (ConstructedType): Override `IsClass' etc.
14217 2003-11-08 Martin Baulig <martin@ximian.com>
14219 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
14220 return value and the `out parent' parameter.
14221 (TypeContainer.DefineType): Moved the CS0644 check into
14222 GetClassBases(). Don't pass the interface types to the
14223 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
14224 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
14226 * ecore.cs (TypeExpr.IsAttribute): New property.
14227 (TypeExpr.GetInterfaces): New method.
14229 * interface.cs (Interface.GetInterfaceTypeByName): Return a
14230 TypeExpr instead of a Type.
14231 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
14232 (Interface.DefineType): Don't pass the interface types to the
14233 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
14234 them later and then call `TypeBulider.AddInterfaceImplementation()'.
14236 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
14237 instead of a `Type[]'.
14238 (TypeManager.RegisterBuilder): Likewise.
14239 (TypeManager.AddUserInterface): Likewise.
14240 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
14241 `Type[]' and also return a `TypeExpr[]'.
14242 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
14244 2003-11-08 Martin Baulig <martin@ximian.com>
14246 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
14249 2003-11-08 Martin Baulig <martin@ximian.com>
14251 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
14252 TypeManager.ResolveExpressionTypes().
14254 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
14255 instead of an Expression.
14256 (TypeExpr): This is now an abstract base class for `TypeExpression'.
14257 (TypeExpression): New public class; formerly known as `TypeExpr'.
14259 * expression.cs (ComposedCast): Derive from TypeExpr.
14261 * typemanager.cs (TypeManager.system_*_expr): These are now
14262 TypExpr's instead of Expression's.
14263 (TypeManager.ResolveExpressionTypes): New public static function;
14264 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
14267 2003-11-06 Miguel de Icaza <miguel@ximian.com>
14269 * expression.cs (New.DoResolve): Do not dereference value that
14270 might be a null return.
14272 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
14273 sure that the constant value has the right type. Fixes an
14274 unreported bug, similar to 50425.
14276 * const.cs (Const.LookupConstantValue): Call
14277 ImplicitStandardConversionExists before doing a conversion to
14278 avoid havng the TypeManager.ChangeType do conversions.
14280 Reduced the number of casts used
14282 (Const.ChangeType): New routine to enable reuse of the constant
14283 type changing code from statement.
14285 * typemanager.cs (ChangeType): Move common initialization to
14286 static global variables.
14290 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
14291 every value type to go through, even if it was void. Fix that.
14293 * cs-tokenizer.cs: Use is_identifier_start_character on the start
14294 character of the define, and the is_identifier_part_character for
14295 the rest of the string.
14297 2003-11-05 Miguel de Icaza <miguel@ximian.com>
14299 * expression.cs (UnaryMutator.EmitCode): When I updated
14300 LocalVariableReference.DoResolve, I overdid it, and dropped an
14301 optimization done on local variable references.
14303 2003-11-04 Miguel de Icaza <miguel@ximian.com>
14305 * ecore.cs: Convert the return from Ldlen into an int.
14307 2003-10-20 Miguel de Icaza <miguel@ximian.com>
14309 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
14310 the accessibility, this is a special case for toplevel non-public
14311 classes (internal for instance).
14313 2003-10-20 Nick Drochak <ndrochak@gol.com>
14315 * ecore.cs: Fix typo and build. Needed another right paren.
14317 2003-10-19 Miguel de Icaza <miguel@ximian.com>
14319 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
14320 `internal' case regular and protected, but not allowing protected
14321 to be evaluated later. Bug 49840
14323 2003-10-15 Miguel de Icaza <miguel@ximian.com>
14325 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
14326 to kb.Nlast, and not the kb.nFirst to isolate the switch
14329 Extract the underlying type, so enumerations of long/ulong are
14330 treated like long/ulong.
14332 2003-10-14 Miguel de Icaza <miguel@ximian.com>
14334 * expression.cs (New): Overload the meaning of RequestedType to
14335 track the possible creation of the NewDelegate type, since
14336 DoResolve is invoked more than once for new constructors on field
14339 See bugs: #48800 and #37014
14341 * cs-parser.jay (declare_local_constants): Take an arraylist
14342 instead of a single constant.
14344 (local_constant_declaration): It should take a
14345 constant_declarators, not a constant_declarator. Fixes 49487
14347 * convert.cs: Fix error report.
14349 2003-10-13 Jackson Harper <jackson@ximian.com>
14351 * typemanager.cs (TypeToCoreType): Add float and double this fixes
14354 2003-11-03 Martin Baulig <martin@ximian.com>
14356 * expression.cs (ArrayAccess.GetStoreOpcode): Added
14357 `out bool has_type_arg'; if set, we need to pass the type to
14359 (ArrayAccess.GetStoreOpcode, ArrayAccess.EmitLoadOpcode): Use
14360 Stelem_Any/Ldelem_Any for generic parameters.
14362 2003-11-02 Martin Baulig <martin@ximian.com>
14364 * expression.cs (Invocation.EmitCall): Use
14365 `TypeManager.IsValueType()' to check whether it's a value type.
14366 Don't set `struct_call' when calling a method on a type parameter.
14368 2003-11-02 Martin Baulig <martin@ximian.com>
14370 * generics.cs (ConstructedType.Resolve): Renamed to ResolveType()
14371 and removed the TypeBuilder argument.
14373 * typemanager.cs (TypeManager.IsValueType): Return
14374 `t.IsGenericParameter || t.IsValueType'.
14376 2003-10-25 Martin Baulig <martin@ximian.com>
14378 * decl.cs (DeclSpace.ResolveType): If we're a ConstructedType,
14379 call ConstructedType.Resolve() on it.
14381 * generic.cs (ConstructedType.Resolve): Set `type' on success.
14383 2003-10-25 Martin Baulig <martin@ximian.com>
14385 * class.cs (TypeContainer.GetClassBases): Changed
14386 `out Type parent' into `out TypeExpr parent'. Moved CS0644 and
14387 CS8214 reporting here.
14388 (TypeContainer.DefineType): GetClassBases() gives us a `TypeExpr'
14389 instead of a `Type' for our parent. In case of a recursive
14390 declaration (see tests/gen-23.cs for an example), our parent is a
14391 ConstructedType and it doesn't have its type set. So, first
14392 create our own TypeBuilder, then call constructed.Resolve() to get
14393 the parent's type and finally TypeBuilder.SetParent() it.
14395 * ecore.cs (TypeExpr.Name): New public virtual property.
14398 (ConstructedType): We're now a TypeExpr and not just an Expression.
14399 (ConstructedType.ResolveAsTypeStep): Don't resolve our type
14400 arguments here; this is done later.
14401 (ConstructedType.Resolve): New public method to resolve the type
14402 arguments and bind them.
14404 2003-10-21 Martin Baulig <martin@ximian.com>
14406 * convert.cs: Use `TypeManager.IsValueType' instead of
14407 'type.IsValueType' everywhere.
14409 * typemanager.cs (TypeManager.IsValueType): Return true for type
14410 parameters. The reason for this is that we need to box a type
14411 parameter when converting it to a reference type.
14413 * cs-parser.jay: Added support for default value expressions.
14415 * generics.cs (DefaultValueExpression): New public class.
14417 2003-10-17 Martin Baulig <martin@ximian.com>
14419 * generic.cs (Constraints.Resolve): Take a DecpSpace instead of a
14420 TypeContainer so we can also use this for Interfaces.
14421 (TypeParameter.Resolve): Likewise.
14423 * interface.cs (Interface.DefineType): Added support for generic
14426 * cs-parser.jay: Added support for generic structs and interfaces.
14428 2003-10-17 Martin Baulig <martin@ximian.com>
14430 * generic.cs (GenericMemberAccess.DoResolve): We can now actually
14431 call generic methods :-)
14433 2003-10-16 Martin Baulig <martin@ximian.com>
14435 * cs-parser.jay (namespace_or_type_name): Only create a
14436 GenericMemberAccess if we actually have type arguments.
14438 2003-10-13 Martin Baulig <martin@ximian.com>
14440 * class.cs (Method.Define): If we're a generic method, call
14441 TypeBuilder.DefineGenericMethod () before resolving
14443 (MethodData): Added .ctor which takes an additional MethodBuilder
14444 argument; this is used for generic methods.
14445 (MethodData.Define): Call `builder.SetGenericMethodSignature()' if
14446 we already have a MethodBuilder.
14448 2003-10-10 Martin Baulig <martin@ximian.com>
14450 * class.cs (Method): Added .ctor which takes a `GenericMethod'
14451 instead of a `DeclSpace'. This is used for generic methods.
14453 * cs-parser.jay (method_header): Added support for generic
14454 methods; create a `GenericMethod' instance and pass it to the
14455 `Method's .ctor; it'll be used as the `DeclSpace' to lookup
14456 parameters and locals.
14458 * decl.cs (DeclSpace.SetParameterInfo): Removed Location argument
14459 since we already have the location. Check whether we're a generic
14460 type declaration or a generic method and create the correct type
14463 * generic.cs (TypeParameter.DefineMethod): New public method.
14464 (GenericMethod): New public class; derives from DeclSpace and is
14465 used for generic methods.
14467 2003-10-09 Martin Baulig <martin@ximian.com>
14469 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
14471 (MethodCore.DoDefineParameters): Removed the TypeContainer
14472 argument; use the DeclSpace which was passed to the .ctor instead.
14473 (MethodCore.CheckParameter): Take a DeclSpace instead of a
14474 TypeContainer; we only need a DeclSpace here.
14476 2003-10-09 Martin Baulig <martin@ximian.com>
14478 * class.cs (MethodData): Added additional `DeclSpace ds' argument
14480 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
14481 EmitContext's .ctor.
14483 2003-10-09 Martin Baulig <martin@ximian.com>
14485 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
14486 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
14487 AsAccessible(), moved them as well.
14489 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
14491 2003-10-07 Miguel de Icaza <miguel@ximian.com>
14493 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
14494 generation for >=, as spotted by Paolo, bug 48679.
14495 Patch from David Waite.
14497 * cs-tokenizer.cs: Add handling for #pragma.
14499 * cs-parser.jay: Allow for both yield and yield return in the
14500 syntax. The anti-cobolization of C# fight will go on!
14502 * class.cs (TypeBuilder.DefineType): Catch error condition here
14503 (Parent.DefineType erroring out and returning null).
14505 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
14506 coping with enumerations variables, we were mistakenly processing
14507 them as a regular value type instead of built-in types. Fixes the
14510 * typemanager.cs (IsBuiltinOrEnum): New method.
14512 2003-09-30 Miguel de Icaza <miguel@ximian.com>
14514 * cs-parser.jay: Upgrade: yield now needs the return clause.
14516 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
14518 * cs-parser.jay : Renamed yyName to yyNames related to jay.
14520 2003-09-29 Martin Baulig <martin@ximian.com>
14522 * typemanager.cs (TypeManager.GetMethodFlags): Added support for
14523 inflated generic methods.
14525 * generics.cs (ConstructedType): Distinguish between open and
14526 closed constructed types; correctly resolve the arguments.
14528 2003-09-22 Martin Baulig <martin@ximian.com>
14530 * generic.cs (ConstructedType.ResolveAsTypeCheck): Check whether
14531 all type arguments meet their constraints.
14533 2003-09-19 Martin Baulig <martin@ximian.com>
14535 * decl.cs (MemberCache.SetupCacheForInterface): Take a
14536 `MemberCache parent' argument. Normally, an interface doesn't
14537 have a parent type except System.Object, but we use this in gmcs
14538 for generic type parameters.
14540 2003-09-18 Martin Baulig <martin@ximian.com>
14542 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
14543 on `type.IsInterface'; don't check whether the type has a parent
14544 to determine whether it's an interface.
14546 2003-09-17 Martin Baulig <martin@ximian.com>
14548 * generic.cs (ConstructedType.ToString): Always use `name' as the
14551 2003-09-15 Martin Baulig <martin@ximian.com>
14553 * cs-parser.jay: Fix grammar wrt. type_parameter_constraints.
14555 * generic.cs (Constraints.Resolve): New public method; this is
14556 called to resolve the constraint types and to check whether all
14557 the constraints are correct.
14558 (Constraints.Types): New public property.
14559 (TypeParameter.Resolve): New public method; resolves all the
14560 type's constraints.
14562 * class.cs (TypeContainer.DefineType): Call
14563 TypeParameter.Resolve() before actually defining the type.
14565 2003-09-15 Martin Baulig <martin@ximian.com>
14567 * class.cs (TypeContainer.DefineType): Added an error flag to
14568 avoid reporting duplicate CS0146's ("class definition is
14571 * driver.cs (Driver.MainDriver): Abort if
14572 RootContext.ResolveTree() reported any errors.
14574 2003-09-07 Martin Baulig <martin@ximian.com>
14576 * report.cs (Error, Warning): Added overloaded versions which take
14577 a `params object[] args' and call String.Format().
14579 2003-09-07 Martin Baulig <martin@ximian.com>
14581 * decl.cs (DeclSpace..ctor): Don't call
14582 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
14583 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
14584 (DeclSpace.RecordDecl): New method.
14586 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
14588 2003-09-02 Ravi Pratap <ravi@ximian.com>
14590 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
14591 value attributes to be applied to ParameterBuilders.
14593 * class.cs (MethodCore.LabelParameters): Make static and more
14594 generic so that it can be used from other places - like interface
14595 methods, for instance.
14597 * interface.cs (Interface.Emit): Call LabelParameters before
14598 emitting attributes on the InterfaceMethod.
14600 2003-09-07 Martin Baulig <martin@ximian.com>
14602 * generic.cs (ConstructedType.ResolveAsTypeStep): Report a CS8217
14603 if the number of type parameters doesn't match.
14605 2003-09-04 Martin Baulig <martin@ximian.com>
14607 * expression.cs (ComposedCast.ResolveAsTypeStep): Added support
14608 for arrays of generic type params (ie. `!0[]').
14610 2003-09-04 Martin Baulig <martin@ximian.com>
14612 * class.cs (TypeContainer.AsAccessible): Ignore generic parameters
14615 2003-09-04 Martin Baulig <martin@ximian.com>
14617 * decl.cs (DeclSpace.LookupGeneric): New method.
14618 (DeclSpace.CheckAccessLevel): Ignore generic parameters for the
14621 * generic.cs (TypeParameterExpr): Take a TypeParameter as
14622 argument, not just a string.
14623 (TypeParameter.Define): New public method; this is called to
14624 actually define the generic parameter; after this, you can use the
14625 new `Type' property to get the type.
14627 2003-09-04 Martin Baulig <martin@ximian.com>
14629 * decl.cs (DeclSpace.SetParameterInfo): The `constraints' argument
14630 is now an ArrayList; initialize the result of the `TypeParameters'
14632 (DeclSpace.GetGenericData): Removed.
14633 (DeclSpace.LookupGeneric): Temporarily removed; we need to
14634 implement this in a different way.
14635 (DeclSpace.GetTypeParameters): Removed; there's now a
14636 `TypeParameters' property.
14637 (DeclSpace.TypeParameters): New public property.
14639 * generic.cs (Constraints): Make this class public.
14640 (TypeParameter): New public class.
14642 2003-09-04 Martin Baulig <martin@ximian.com>
14644 * decl.cs (DeclSpace.GetTypeParameters): New method to return the
14645 generic parameters.
14647 * class.cs (TypeContainer.DefineType): Call
14648 TypeBuilder.DefineGenericParameter () on all generic parameters if
14649 this is a generic type.
14651 2003-08-28 Martin Baulig <martin@ximian.com>
14653 * sample-stack.il: Compile this with ilasm: "ilasm /dll
14656 * sample-hello.cs: Compile this with gmcs: "gmcs
14657 /r:sample-stack.dll sample-hello.cs".
14659 2003-08-28 Martin Baulig <martin@ximian.com>
14661 * generic.cs (ConstructedType.ResolveAsTypeStep): Actually bind
14662 the parameters to the generic type.
14664 2003-08-28 Martin Baulig <martin@ximian.com>
14666 * cs-tokenizer.cs (parse_less_than): Also allow all builtin types.
14668 2003-08-28 Martin Baulig <martin@ximian.com>
14670 * cs-parser.jay (opt_type_argument_list): Use
14671 `OP_GENERICS_LT type_arguments OP_GENERICS_GT'.
14672 (primary_expression): Replace `qualified_identifier' with `type_name'.
14673 (type_parameter_list): Use `OP_GENERICS_LT type_parameters OP_GENERICS_GT'.
14675 * cs-tokenizer.cs (is_punct): When reading a `<', invoke a custom
14676 parser to check whether it is syntactically a type parameter list;
14677 return OP_GENERICS_LT/OP_GENERICS_GT instead of OP_LT/OP_GT in
14680 2003-08-26 Martin Baulig <martin@ximian.com>
14682 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
14683 resolving aliases; fixes #47927.
14685 2003-08-26 Martin Baulig <martin@ximian.com>
14687 * statement.cs (Using.DoResolve): This is internally emitting a
14688 try/finally clause, so we need to set ec.NeedExplicitReturn if we
14689 do not always return. Fixes #47681.
14691 2003-08-26 Martin Baulig <martin@ximian.com>
14693 * decl.cs (MemberCore): Moved WarningNotHiding(),
14694 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
14696 (AdditionResult): Make this nested in DeclSpace.
14697 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
14698 argument; call NamespaceEntry.Define() unless we're nested in a
14701 * namespace.cs (Namespace.DefineName): New public function. This
14702 is called from DeclSpace's .ctor to add
14703 (Namespace.Lookup): Include DeclSpaces in the lookup.
14705 * class.cs (Operator): Derive from MemberBase, not MemberCore.
14707 * const.cs (Const): Derive from MemberBase, not MemberCore.
14709 2003-08-25 Martin Baulig <martin@ximian.com>
14711 * convert.cs (Convert.ExplicitReferenceConversion): When
14712 converting from an interface type to a class, unbox if the target
14713 type is a struct type. Fixes #47822.
14715 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
14717 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
14720 2003-08-22 Martin Baulig <martin@ximian.com>
14722 * class.cs (TypeManager.DefineType): When defining a nested type,
14723 call DefineType() on our parent; fixes #47801.
14725 2003-08-22 Martin Baulig <martin@ximian.com>
14727 * class.cs (MethodData.Define): While checking if a method is an
14728 interface implementation, improve the test a bit more to fix #47654.
14730 2003-08-22 Martin Baulig <martin@ximian.com>
14732 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
14733 correctly; fixes #47722.
14735 2003-08-22 Martin Baulig <martin@ximian.com>
14737 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
14738 LocalVariableReference, ensure it's not read-only. Fixes #47536.
14740 * statement.cs (Fixed.DoResolve): Make all variables read-only.
14742 2003-08-22 Martin Baulig <martin@ximian.com>
14744 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
14745 can only be assigned in static constructors. Fixes #47161.
14747 2003-08-22 Martin Baulig <martin@ximian.com>
14749 Rewrote and improved the flow analysis code.
14751 * flowbranching.cs (FlowBranching): Make this class abstract.
14752 (FlowBranching.CreateBranching): New static function to create a
14753 new flow branching.
14754 (FlowBranchingBlock, FlowBranchingException): New classes.
14755 (FlowBranching.UsageVector.Type): New public readonly field.
14756 (FlowBranching.UsageVector.Breaks): Removed the setter.
14757 (FlowBranching.UsageVector.Returns): Removed the setter.
14758 (FlowBranching.UsageVector): Added Break(), Return(),
14759 NeverReachable() and Throw() methods to modify the reachability.
14760 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
14761 done by FlowBranching.Merge().
14762 (FlowBranching.UsageVector.MergeChild): New method; merges the
14763 merge result into the current vector.
14764 (FlowBranching.Merge): New abstract method to merge a branching.
14766 2003-08-12 Martin Baulig <martin@ximian.com>
14768 * expression.cs (Indirection.CacheTemporaries): Create the
14769 LocalTemporary with the pointer type, not its element type.
14771 2003-08-10 Miguel de Icaza <miguel@ximian.com>
14773 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
14774 token was a keyword or not.
14776 Add `error' options where an IDENTIFIER was expected; Provide
14777 CheckToken and CheckIdentifierToken convenience error reporting
14780 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
14782 * decl.cs: Rename `NamespaceEntry Namespace' public field into
14783 NameSpaceEntry NameSpaceEntry.
14785 (LookupInterfaceOrClass): Avoid creating a full qualified name
14786 from namespace and name: avoid doing lookups when we know the
14787 namespace is non-existant. Use new Tree.LookupByNamespace which
14788 looks up DeclSpaces based on their namespace, name pair.
14790 * driver.cs: Provide a new `parser verbose' to display the
14791 exception thrown during parsing. This is turned off by default
14792 now, so the output of a failure from mcs is more graceful.
14794 * namespace.cs: Track all the namespaces defined in a hashtable
14797 (IsNamespace): New method
14799 2003-08-09 Miguel de Icaza <miguel@ximian.com>
14801 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
14802 we know that we need to concatenate (full typename can never be
14807 * statement.cs: Use a bitfield; Do not initialize to null things
14808 which are done by the constructor by default.
14810 * cs-parser.jay: bug fix, parameter was 4, not 3.
14812 * expression.cs: Just use the property;
14814 * statement.cs: No need for GetVariableInfo method.
14816 2003-08-08 Martin Baulig <martin@ximian.com>
14818 * flowanalysis.cs (FlowReturns): This is now nested in the
14819 `FlowBranching' class.
14820 (MyBitVector): Moved this here from statement.cs.
14821 (FlowBranching.SiblingType): New enum type.
14822 (FlowBranching.CreateSibling): Added `SiblingType' argument.
14824 2003-08-07 Martin Baulig <martin@ximian.com>
14826 * flowanalysis.cs (FlowBranchingType): This is now nested in the
14827 `FlowBranching' class and called `BranchingType'.
14829 2003-08-07 Martin Baulig <martin@ximian.com>
14831 * flowanalysis.cs: Moved all the control flow analysis code into
14834 2003-08-07 Martin Baulig <martin@ximian.com>
14836 * assign.cs (Assign.DoResolve): `target' must either be an
14837 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
14840 2003-08-07 Miguel de Icaza <miguel@ximian.com>
14842 * expression.cs (BinaryMethod): This kind of expression is created by the
14843 Binary class if it determines that the operator has to be handled
14846 (BinaryDelegate): This kind of expression is created if we are
14847 dealing with a + or - operator on delegates.
14849 (Binary): remove method, argumetns, and DelegateOperator: when
14850 dealing with methods,
14852 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
14854 * statement.cs (Block): use bitfields for the three extra booleans
14855 we had in use. Remove unused topblock parameter.
14857 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
14859 * assign.cs: Drop extra unneeded tests.
14861 2003-08-06 Miguel de Icaza <miguel@ximian.com>
14863 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
14865 * statement.cs (Foreach): Use VariableStorage instead of
14868 * codegen.cs (VariableStorage): New class used by clients that
14869 require a variable stored: locals or fields for variables that
14870 need to live across yield.
14872 Maybe provide a convenience api for EmitThis+EmitLoad?
14874 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
14877 2003-08-05 Miguel de Icaza <miguel@ximian.com>
14879 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
14880 RemapParameterLValue): New methods that are used to turn a
14881 precomputed FieldInfo into an expression like this:
14885 The idea is to use this instead of making LocalVariableReference
14886 have more than one meaning.
14888 * cs-parser.jay: Add error production to BASE.
14890 * ecore.cs: Deal with TypeManager.GetField returning null, which
14891 is now a valid return value.
14893 (FieldExprNoAddress): New expression for Fields whose address can
14896 * expression.cs (LocalVariableReference): During the resolve
14897 phases, create new expressions if we are in a remapping context.
14898 Remove code that dealt with remapping here.
14900 (ParameterReference): same.
14902 (ProxyInstance): New expression, like the `This' expression, but
14903 it is born fully resolved. We know what we are doing, so remove
14904 the errors that are targeted to user-provided uses of `this'.
14906 * statement.cs (Foreach): our variable is now stored as an
14907 Expression; During resolution, follow the protocol, dont just
14908 assume it will return this.
14910 2003-08-06 Martin Baulig <martin@ximian.com>
14912 * support.cs (SeekableStreamReader.cs): New public class.
14914 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
14915 SeekableStreamReader instead of the normal StreamReader.
14917 2003-08-04 Martin Baulig <martin@ximian.com>
14919 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
14920 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
14921 deambiguate casts and delegate invocations.
14922 (parenthesized_expression): Use the new tokens to ensure this is
14923 not a cast of method invocation.
14925 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
14926 when reading a `)' and Deambiguate_CloseParens () was previously
14929 * expression.cs (ParenthesizedExpression): New class. This is
14930 just used for the CS0075 test.
14931 (Binary.DoResolve): Check for CS0075.
14933 2003-07-29 Ravi Pratap <ravi@ximian.com>
14935 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
14936 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
14937 reference comparison.
14939 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
14940 examine the ReturnType for equality - this is necessary in the
14941 cases of implicit and explicit operators whose signature also
14942 includes the return type.
14944 2003-07-26 Miguel de Icaza <miguel@ximian.com>
14946 * namespace.cs: Cache the result of the namespace computation,
14947 instead of computing it every time.
14949 2003-07-24 Miguel de Icaza <miguel@ximian.com>
14951 * decl.cs: Use a global arraylist that we reuse over invocations
14952 to avoid excesive memory consumption. Reduces memory usage on an
14953 mcs compile by one meg (45 average).
14955 * typemanager.cs (LookupTypeReflection): In .NET pointers are
14956 private, work around that.
14958 2003-07-23 Miguel de Icaza <miguel@ximian.com>
14960 * literal.cs (IntLiteral): Define Zero and One static literals.
14962 * cs-parser.jay (integer_literal): use static literals to reduce
14963 memory usage for the most used literals (0, 1 and -1). 211kb
14964 reduced in memory usage.
14966 Replace all calls to `new ArrayList' with `new
14967 ArrayList(4)' which is a good average number for most allocations,
14968 and also requires only 16 bytes of memory for its buffer by
14971 This reduced MCS memory usage in seven megabytes for the RSS after
14974 2003-07-28 Ravi Pratap <ravi@ximian.com>
14976 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
14977 handle params methods the correct way by forming only one
14978 applicable set with params and normal methods in them. Earlier we
14979 were looking at params methods only if we found no normal methods
14980 which was not the correct thing to do.
14982 (Invocation.BetterFunction): Take separate arguments indicating
14983 when candidate and the best method are params methods in their
14986 This fixes bugs #43367 and #46199.
14988 * attribute.cs: Documentation updates.
14990 (CheckAttribute): Rename to CheckAttributeTarget.
14991 (GetValidPlaces): Rename to GetValidTargets.
14993 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
14994 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
14998 2003-07-28 Miguel de Icaza <miguel@ximian.com>
15000 * codegen.cs: Compute IsGeneric correctly.
15002 * cs-parser.jay: Introduce OP_GENERIC_LT for the grammar ambiguity
15005 Bring back (temporarily) OP_LEFT_SHIFT, OP_RIGHT_SHIFT,
15006 OP_SHIFT_RIGHT_ASSIGN, OP_SHIFT_LEFT_ASSIGN. There were too many
15007 regressions, and I was chasing more bugs than I required.
15009 * interface.cs: Use expressions for base type names (like classes
15010 and structs have been doing for a while now), and resolve that.
15011 This patch should probably go into head as well.
15013 This makes it one less user of FindType.
15015 2003-07-24 Miguel de Icaza <miguel@ximian.com>
15017 This compiler can not self host currently. Need to fix that.
15019 * Makefile: compile to `gmcs.exe'
15021 * driver.cs: Turn on v2 by default on gmcs.
15023 * generic.cs (ConstructedType): Does no longer take a container
15024 type argument; That will be taken care of later.
15026 (ConstructedType.DoResolve, ConstructedType.ResolveAsTypeStep):
15027 Use SimpleName to resolve for now, so we can continue the work on
15028 the parser, until we get Type.GetType that understands generics.
15030 (ConstructedType.ToString): Implement
15032 (TypeArguments.Resolve): Resolve the child expressions as types.
15034 * cs-parser.jay: Rename interface_constraints to
15035 type_parameter_constraints
15037 (namespace_or_type_name): Only use constructed types for the basic
15038 construction, we will deal with identifier<...> later.
15040 (type/type_name): No longer call DecomposeQI, as
15041 namespace_or_type_name is always decoded now.
15043 2003-07-22 Ravi Pratap <ravi@ximian.com>
15045 * expression.cs (Invocation.OverloadResolve): Follow the spec more
15046 closely: we eliminate methods in base types when we have an
15047 applicable method in a top-level type.
15049 Please see section 14.5.5.1 for an exact description of what goes
15052 This fixes bug #45127 and a host of other related to corlib compilation.
15054 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
15055 array is the method corresponding to the top-level type (this is
15056 because of the changes made to icall.c) so we change this
15059 (MethodGroupExpr.Name): This too.
15061 * typemanager.cs (GetElementType): New method which does the right
15062 thing when compiling corlib.
15064 * everywhere: Make use of the above in the relevant places.
15066 2003-07-22 Martin Baulig <martin@ximian.com>
15068 * cs-parser.jay (invocation_expression): Moved
15069 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
15070 `cast_expression', but create a InvocationOrCast which later
15071 resolves to either an Invocation or a Cast.
15073 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
15074 method; call this before EmitStatement() to make sure that this
15075 expression can be used as a statement.
15077 * expression.cs (InvocationOrCast): New class; resolves to either
15078 an Invocation or a Cast.
15080 * statement.cs (StatementExpression): Call ResolveStatement() on
15081 the ExpressionStatement before emitting it.
15083 2003-07-21 Martin Baulig <martin@ximian.com>
15085 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
15086 `ref' and `out' attributes match; fixes #46220.
15087 (MemberAccess.ResolveMemberAccess): You can't reference a type
15088 through an expression; fixes #33180.
15089 (Indexers.GetIndexersForType): Don't return the indexers from
15090 interfaces the class implements; fixes #46502.
15092 2003-07-21 Martin Baulig <martin@ximian.com>
15094 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
15095 CS0661 checks; fixes bug #30442.
15097 2003-07-21 Martin Baulig <martin@ximian.com>
15099 * decl.cs (AdditionResult): Added `Error'.
15101 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
15103 * typemanager.cs (TypeManager.ChangeType): Catch exceptions; makes
15104 cs0031.cs actually work.
15106 2003-07-20 Miguel de Icaza <miguel@ximian.com>
15108 * cs-parser.jay (namespace_name): do not use
15109 namespace_or_type_name, use qualified_identifier, because
15110 namespace_or_type_name will soon return a composed expression
15111 instead of a string.
15113 (namespace_or_type_name): Instead of returning a string, now this
15114 production returns an expression.
15116 * codegen.cs (EmitContext): Setup IsGeneric property based on
15117 whether our DeclSpace is generic, our the method is generic.
15119 * modifier.cs (Modifiers.METHOD_GENERIC): New definition, use if
15120 the method is generic.
15122 * cs-parser.jay (type_arguments, opt_type_argument_list,
15123 type_parameters, type_parameter_list, opt_type_parameter_list,
15124 type_parameter,, opt_type_parameter_constraints_clauses,
15125 type_parameter_constraints_clauses,
15126 type_parameter_constraint_clause, type_parameter_constraint,
15127 interface_constraints): Add new production
15129 * decl.cs (DeclSpace): IsGeneric, flag to track whether this
15130 DeclSpace is generic or not.
15132 (DeclSpace.SetParameterInfo): New routine, used to set the
15133 parameter info for a type.
15135 (DeclSpace.LookupGeneric): Lookups a name, and if it is a generic,
15136 returns a GenericTypeExpr
15138 * ecore.cs (SimpleName.ResolveAsTypeStep): If our container is
15139 generic, lookup the generic argument.
15141 * attribute.cs: Do not allow TypeParameterExpressions in
15144 * class.cs: Do not allow the Main method to be defined in a
15147 * expression.cs (SizeOf): Do not allow generic types to be used as
15148 arguments to sizeof.
15150 * typemanager.cs (IsGeneric): Wrapper for Reflection when we have
15151 it: whether a type is generic or not. Only works for types we are
15152 currently building for now.
15154 2003-07-20 Martin Baulig <martin@ximian.com>
15156 * namespace.cs: Fixed that bug which caused a crash when compiling
15157 the debugger's GUI.
15159 2003-07-20 Miguel de Icaza <miguel@ximian.com>
15161 * typemanager.cs (LookupTypeReflection): Never expose types which
15162 are NotPublic, NestedPrivate, NestedAssembly, or
15163 NestedFamANDAssem. We used to return these, and later do a check
15164 that would report a meaningful error, but the problem is that we
15165 would not get the real match, if there was a name override.
15167 2003-07-18 Miguel de Icaza <miguel@ximian.com>
15169 * namespace.cs (Namespace, Name): Do not compute the namespace
15170 name dynamically, compute it in the constructor. This reduced
15171 memory usage by 1697 KB.
15173 * driver.cs: Use --pause to pause at the end.
15175 2003-07-17 Peter Williams <peter@newton.cx>
15177 * Makefile: Change the name of the test target so that it doesn't
15178 conflict with the recursive test target.
15180 2003-07-17 Miguel de Icaza <miguel@ximian.com>
15182 * expression.cs (LocalVariableReference.Emit, EmitAssign,
15183 AddressOf): Do not use EmitThis, that was wrong, use the actual
15186 2003-07-15 Miguel de Icaza <miguel@ximian.com>
15188 * class.cs (MethodData.Define): While checking if a method is an
15189 interface implementation, improve the test: If we are not public
15190 (use new test here: use the computed MethodAttributes directly,
15191 instead of the parsed modifier flags) check if the `implementing'
15192 method comes from an interface or not.
15194 * pending.cs (VerifyPendingMethods): Slightly better error
15197 * makefile: add test target that does the mcs bootstrap.
15199 2003-07-16 Ravi Pratap <ravi@ximian.com>
15201 * interface.cs (Define): Do nothing here since there are no
15202 members to populate etc. Move the attribute emission out of here
15203 since this was just totally the wrong place to put it. Attribute
15204 application happens during the 'Emit' phase, not in the 'Define'
15207 (Emit): Add this method and move the attribute emission here
15209 * rootcontext.cs (EmitCode): Call the Emit method on interface
15212 2003-07-14 Ravi Pratap M <ravi@ximian.com>
15214 * expression.cs (OverloadResolve): Report error only if Location
15215 is not 'Null' which means that there was a probe going on.
15217 2003-07-14 Martin Baulig <martin@ximian.com>
15219 * expression.cs (ConditionalLogicalOperator): New public class to
15220 implement user defined conditional logical operators.
15221 This is section 14.11.2 in the spec and bug #40505.
15223 2003-07-14 Martin Baulig <martin@ximian.com>
15225 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
15227 2003-07-14 Martin Baulig <martin@ximian.com>
15229 * codegen.cs (EmitContext.InFixedInitializer): New public field.
15231 * ecore.cs (IVariable.VerifyFixed): New interface method.
15233 * expression.cs (Unary.ResolveOperator): When resolving the `&'
15234 operator, check whether the variable is actually fixed. Fixes bug
15235 #36055. Set a variable definitely assigned when taking its
15236 address as required by the spec.
15238 * statement.cs (LocalInfo.IsFixed): New field.
15239 (LocalInfo.MakePinned): Set `IsFixed' to true.
15241 2003-07-14 Ravi Pratap M <ravi@ximian.com>
15243 * attribute.cs (Attribute.Resolve): While doing a Member lookup
15244 for .ctors, ensure that we only ask for members declared in the
15245 attribute type (BindingFlags.DeclaredOnly).
15249 * expression.cs (Error_WrongNumArguments): Report error 1501
15250 correctly the way CSC does.
15252 2003-07-13 Martin Baulig <martin@ximian.com>
15254 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
15255 lookup on the fully qualified name, to make things like "X.X" work
15256 where "X.X" is a fully qualified type name, but we also have a
15257 namespace "X" in the using list. Fixes #41975.
15259 2003-07-13 Martin Baulig <martin@ximian.com>
15261 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
15262 function. If we're a CompoundAssign, we need to create an embedded
15263 CompoundAssign, not an embedded Assign.
15264 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
15267 2003-07-13 Martin Baulig <martin@ximian.com>
15269 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
15270 work to fix bug #46088.
15272 2003-07-13 Ravi Pratap <ravi@ximian.com>
15274 * class.cs (Operator.Emit): Do not emit attributes here - it is
15275 taken care of by the Method class that we delegate too. This takes
15276 care of bug #45876.
15278 2003-07-10 Martin Baulig <martin@ximian.com>
15280 * expression.cs (TypeOfVoid): New class.
15281 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
15283 2003-07-10 Martin Baulig <martin@ximian.com>
15285 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
15288 2003-07-10 Martin Baulig <martin@ximian.com>
15290 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
15291 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
15293 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
15295 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
15297 2003-07-10 Martin Baulig <martin@ximian.com>
15299 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
15300 of decimal. Fixes #42850.
15302 NOTE: I also fixed the created byte blob, but this doesn't work on
15303 the MS runtime and csc never produces any byte blobs for decimal
15306 2003-07-10 Martin Baulig <martin@ximian.com>
15308 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
15309 structs; fixes #32068.
15310 (Block.AddChildVariableNames): Fixed #44302.
15312 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
15314 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
15316 2003-07-07 Miguel de Icaza <miguel@ximian.com>
15318 * attribute.cs: And this test is onger needed.
15320 2003-07-08 Martin Baulig <martin@ximian.com>
15322 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
15323 inaccessible types. Fixes #36313.
15325 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
15327 * namespace.cs (NamespaceEntry): Create implicit entries for all
15328 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
15329 implicit entries for N1.N2 and N1.
15331 2003-07-08 Martin Baulig <martin@ximian.com>
15333 Rewrote the handling of namespaces to fix a lot of the issues
15334 wrt. `using' aliases etc.
15336 * namespace.cs (Namespace): Splitted this class into a
15337 per-assembly `Namespace' and a per-file `NamespaceEntry'.
15339 * typemanager.cs (TypeManager.IsNamespace): Removed.
15340 (TypeManager.ComputeNamespaces): Only compute namespaces from
15341 loaded assemblies here, not the namespaces from the assembly we're
15342 currently compiling.
15344 2003-07-08 Martin Baulig <martin@ximian.com>
15346 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
15348 2003-07-07 Miguel de Icaza <miguel@ximian.com>
15350 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
15353 I thought about the memory savings here, but LookupTypeReflection
15354 is used under already very constrained scenarios. Compiling
15355 corlib or mcs only exposes one hit, so it would not really reduce
15356 any memory consumption.
15358 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
15360 * typemanager.cs: fixes bug #45889 by only adding public types from
15361 other assemblies to the list of known types.
15363 2003-07-07 Miguel de Icaza <miguel@ximian.com>
15365 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
15366 on the type we resolved.
15368 2003-07-05 Martin Baulig <martin@ximian.com>
15370 * pending.cs (PendingImplementation.ParentImplements): Don't
15371 create the proxy if the parent is abstract.
15373 * class.cs (TypeContainer.DefineIndexers): Process explicit
15374 interface implementations first. Fixes #37714.
15376 2003-07-04 Miguel de Icaza <miguel@ximian.com>
15378 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
15379 defined recursively; but since we modify the input parameters
15380 (left is set to `this' temporarily), we reset this value if the
15381 left_is_explicit is false, which gives the original semantics to
15384 * literal.cs (NullPointer): new class used to represent a null
15385 literal in a pointer context.
15387 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
15388 type is a pointer, use a NullPointer object instead of a
15389 NullLiteral. Closes 43687
15391 (ExplicitConversion): Convert pointer values using
15392 the conv opcode to the proper type.
15394 * ecore.cs (New): change ValueTypeVariable property into a method,
15395 that returns whether the valuetype is suitable for being used.
15397 * expression.cs (Binary.DoNumericPromotions): Only return if we
15398 the int constant was a valid uint, and we can return both left and
15399 right as uints. If not, we continue processing, to trigger the
15400 type conversion. This fixes 39018.
15402 * statement.cs (Block.EmitMeta): During constant resolution, set
15403 the CurrentBlock property on the emitcontext, so that we resolve
15404 constants propertly.
15406 2003-07-02 Martin Baulig <martin@ximian.com>
15408 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
15409 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
15411 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
15412 than emitting it here.
15414 * statement.cs: Fixed some more flow analysis bugs.
15416 2003-07-02 Martin Baulig <martin@ximian.com>
15418 * class.cs (MethodData.Define): When implementing interface
15419 methods, set Final unless we're Virtual.
15421 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
15422 check work for interface methods.
15424 2003-07-01 Martin Baulig <martin@ximian.com>
15426 * ecore.cs (EmitContext.This): Replaced this property with a
15427 GetThis() method which takes a Location argument. This ensures
15428 that we get the correct error location for a CS0188.
15430 2003-07-01 Miguel de Icaza <miguel@ximian.com>
15432 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
15433 ImplicitStandardConversion.
15435 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
15437 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
15439 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
15442 2003-06-30 Miguel de Icaza <miguel@ximian.com>
15444 * class.cs (Constructor.Define): Turn off initlocals for unsafe
15447 (MethodData.Define): Turn off initlocals for unsafe methods.
15449 2003-06-29 Miguel de Icaza <miguel@ximian.com>
15451 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
15452 complete; Fixes #37521.
15454 * delegate.cs: Use Modifiers.TypeAttr to compute the
15455 TypeAttributes, instead of rolling our own. This makes the flags
15456 correct for the delegates.
15458 2003-06-28 Miguel de Icaza <miguel@ximian.com>
15460 * class.cs (Constructor.Define): Set the private flag for static
15461 constructors as well.
15463 * cs-parser.jay (statement_expression): Set the return value to
15464 null, to avoid a crash when we catch an error.
15466 2003-06-24 Miguel de Icaza <miguel@ximian.com>
15468 * cs-parser.jay: Applied patch from Jackson that adds support for
15469 extern and unsafe modifiers to destructor declarations.
15471 * expression.cs: Report error 21 if the user is trying to index a
15474 * driver.cs: Add an error message, suggested by the bug report.
15476 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
15477 if we do not have a ": this ()" constructor initializer. Fixes 45149
15479 2003-06-14 Miguel de Icaza <miguel@ximian.com>
15481 * namespace.cs: Add some information to reduce FAQs.
15483 2003-06-13 Miguel de Icaza <miguel@ximian.com>
15485 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
15486 underlying enumeration types. Fixes #43915.
15488 * expression.cs: Treat ushort/short as legal values to be used in
15489 bitwise operations.
15491 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
15493 * delegate.cs: transfer custom attributes for paramenters from
15494 the delegate declaration to Invoke and BeginInvoke.
15496 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
15498 * attribute.cs: handle custom marshalers and emit marshal info
15501 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
15503 * makefile.gnu: Added anonymous.cs to the compiler sources.
15505 2003-05-28 Miguel de Icaza <miguel@ximian.com>
15507 * iterators.cs: Change the name of the proxy class to include two
15510 * cs-parser.jay: Update grammar to include anonymous methods.
15512 * anonymous.cs: new file.
15514 2003-05-27 Miguel de Icaza <miguel@ximian.com>
15516 * class.cs (Field.Define): Add missing test for pointers and
15519 2003-05-27 Ravi Pratap <ravi@ximian.com>
15521 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
15522 we use the stobj opcode.
15524 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
15525 since it wasn't the correct fix.
15527 It still is puzzling that we are required to use stobj for IntPtr
15528 which seems to be a ValueType.
15530 2003-05-26 Miguel de Icaza <miguel@ximian.com>
15532 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
15533 during regular simple name resolution. Now, the trick is that
15534 instead of returning for processing the simplename, we do a
15535 TypeManager.LookupType (ie, a rooted lookup as opposed to a
15536 contextual lookup type). If a match is found, return that, if
15537 not, return for further composition.
15539 This fixes long-standing 30485.
15541 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
15542 using the address to initialize an object, do an Stobj instead of
15543 using the regular Stelem.
15545 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
15546 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
15547 Because if we are a BaseIndexerAccess that value will be true.
15550 * statement.cs (GotoCase.Resolve): Return after reporting an
15551 error, do not attempt to continue.
15553 * expression.cs (PointerArithmetic.Emit): If our operand is a
15554 long, convert our constants to match the operand before
15555 multiplying. Convert to I type before adding. Fixes 43670.
15557 2003-05-14 Ravi Pratap <ravi@ximian.com>
15559 * enum.cs (ImplicitConversionExists) : Rename to
15560 ImplicitEnumConversionExists to remove ambiguity.
15562 * ecore.cs (NullCast): New type of cast expression class which
15563 basically is very similar to EmptyCast with the difference being
15564 it still is a constant since it is used only to cast a null to
15566 (eg. (string) null)
15568 * convert.cs (ImplicitReferenceConversion): When casting a null
15569 literal, we return a NullCast.
15571 * literal.cs (NullLiteralTyped): Remove - I don't see why this
15572 should be around anymore.
15574 The renaming (reported was slightly wrong). Corrections:
15576 ConvertImplicitStandard -> ImplicitConversionStandard
15577 ConvertExplicitStandard -> ExplicitConversionStandard
15579 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
15580 before passing them in !
15582 * convert.cs (ImplicitConversionStandard): When comparing for
15583 equal expr and target types, ensure that expr is not a
15586 In general, we must not be checking (expr_type ==
15587 target_type) in the top level conversion methods
15588 (ImplicitConversion, ExplicitConversion etc). This checking is
15589 done in the methods that they delegate to.
15591 2003-05-20 Miguel de Icaza <miguel@ximian.com>
15593 * convert.cs: Move Error_CannotConvertType,
15594 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
15595 ImplicitNumericConversion, ImplicitConversionExists,
15596 ImplicitUserConversionExists, StandardConversionExists,
15597 FindMostEncompassedType, FindMostSpecificSource,
15598 FindMostSpecificTarget, ImplicitUserConversion,
15599 ExplicitUserConversion, GetConversionOperators,
15600 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
15601 TryImplicitIntConversion, Error_CannotConvertImplicit,
15602 ConvertImplicitRequired, ConvertNumericExplicit,
15603 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
15604 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
15607 Perform the following renames:
15609 StandardConversionExists -> ImplicitStandardConversionExists
15610 ConvertImplicit -> ImplicitConversion
15611 ConvertImplicitStandard -> ImplicitStandardConversion
15612 TryImplicitIntConversion -> ImplicitIntConversion
15613 ConvertImplicitRequired -> ImplicitConversionRequired
15614 ConvertNumericExplicit -> ExplicitNumericConversion
15615 ConvertReferenceExplicit -> ExplicitReferenceConversion
15616 ConvertExplicit -> ExplicitConversion
15617 ConvertExplicitStandard -> ExplicitStandardConversion
15619 2003-05-19 Martin Baulig <martin@ximian.com>
15621 * statement.cs (TypeInfo.StructInfo): Made this type protected.
15622 (TypeInfo): Added support for structs having structs as fields.
15624 * ecore.cs (FieldExpr): Implement IVariable.
15625 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
15626 VariableInfo for the field.
15628 2003-05-18 Martin Baulig <martin@ximian.com>
15630 * expression.cs (This.DoResolve): Report a CS0027 if we're
15631 emitting a field initializer.
15633 2003-05-18 Martin Baulig <martin@ximian.com>
15635 * expression.cs (This.ResolveBase): New public function.
15636 (This.DoResolve): Check for CS0188.
15638 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
15641 * ecore.cs (MethodGroupExpr.DoResolve): Set the
15642 `instance_expression' to null if we don't have any non-static
15645 2003-05-18 Martin Baulig <martin@ximian.com>
15647 Reworked the way how local variables and parameters are handled by
15648 the flow analysis code.
15650 * statement.cs (TypeInfo, VariableMap): New public classes.
15651 (VariableInfo): New public class. This is now responsible for
15652 checking whether a variable has been assigned. It is used for
15653 parameters and local variables.
15654 (Block.EmitMeta): Take the InternalParameters as argument; compute
15655 the layout of the flow vectors here.
15656 (Block.LocalMap, Block.ParameterMap): New public properties.
15657 (FlowBranching): The .ctor doesn't get the InternalParameters
15658 anymore since Block.EmitMeta() now computes the layout of the flow
15660 (MyStructInfo): This class is now known as `StructInfo' and nested
15661 in `TypeInfo'; we don't access this directly anymore.
15663 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
15664 property and removed IsAssigned(), IsFieldAssigned(),
15665 SetAssigned() and SetFieldAssigned(); we now call them on the
15666 VariableInfo so we don't need to duplicate this code everywhere.
15668 * expression.cs (ParameterReference): Added `Block block' argument
15670 (LocalVariableReference, ParameterReference, This): The new
15671 VariableInfo class is now responsible for all the definite
15674 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
15675 IsParameterAssigned, SetParameterAssigned): Removed.
15677 2003-05-18 Martin Baulig <martin@ximian.com>
15679 * typemanager.cs (InitCoreTypes): Try calling
15680 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
15681 the 3-args-version. Corlib now also needs our `void_type'.
15682 (GetMethod): Added overloaded version which takes an optional
15683 `bool report_errors' to allow lookups of optional methods.
15685 2003-05-12 Martin Baulig <martin@ximian.com>
15687 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
15688 only used for locals and not for parameters.
15690 2003-05-12 Miguel de Icaza <miguel@ximian.com>
15692 * support.cs (InternalParameters.ParameterType): Return the
15693 ExternalType of the parameter.
15695 * parameter.cs (Parameter.ExternalType): drop the two arguments,
15698 2003-05-11 Miguel de Icaza <miguel@ximian.com>
15700 * class.cs (MethodData.Define): Do not set the `newslot' on
15701 interface members, if they are also flagged as "override".
15703 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
15704 better code for ++i and i++. This only works for static fields
15705 and local variables.
15707 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
15708 want to pull the DeclSpace out of the builder_to_declspace instead
15709 of the TypeBuilder (like in TypeContainer.FindMembers).
15711 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
15712 instead of LookupTypeContainer. Fixes the crash on .NET for
15713 looking up interface members.
15715 * const.cs: Create our own emit context during the Definition
15716 stage, so that constants are evaluated in the proper context, when
15717 a recursive definition happens.
15719 2003-05-11 Martin Baulig <martin@ximian.com>
15721 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
15722 new block for a switch section.
15723 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
15724 the adding/lookup in the switch block. Fixes #39828.
15726 2003-05-09 Miguel de Icaza <miguel@ximian.com>
15728 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
15729 functionality: I needed to convert the data after I had performed
15730 the add/sub operation into the operands type size.
15732 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
15733 pass the type for the box operation, otherwise the resulting
15734 object would have been of type object.
15736 (BoxedCast): Add constructor to specify the type to box as.
15738 2003-05-07 Miguel de Icaza <miguel@ximian.com>
15740 * iterators.cs: I was reusing the `count' variable inadvertently,
15741 take steps to not allow this to happen.
15743 2003-05-06 Miguel de Icaza <miguel@ximian.com>
15745 * attribute.cs (Attribute.Resolve): Params attributes are encoded
15746 by creating an array at the point where the params starts and
15747 putting all those arguments there, then adjusting the size of the
15750 2003-05-05 Miguel de Icaza <miguel@ximian.com>
15752 * expression.cs (New.AddressOf): Implement interface
15753 IMemoryLocation. This is used when the `new' operator is used in
15754 the context of an invocation to a method on a value type.
15756 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
15759 * namespace.cs: Also check the using aliases here.
15761 * driver.cs: Move the test for using validity after the types have
15762 been entered, so we do a single pass that also includes the using
15765 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
15766 in the regular case. CreateSiblingForFinally is doing extra
15769 * attribute.cs (GetAttributeArgumentExpression): Store the result
15770 on an out value, and use the return value to indicate failure
15771 instead of using null (which is a valid return for Constant.GetValue).
15773 * statement.cs: Perform the analysis flow for the increment
15774 portion after the statement, because this will be the real flow of
15775 execution. Fixes #42385
15777 * codegen.cs (EmitContext.EmitArgument,
15778 EmitContext.EmitStoreArgument): New helper functions when the
15779 RemapToProxy flag is set.
15781 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
15784 Add support for remapping parameters.
15786 * iterators.cs: Propagate parameter values; Store parameter
15787 values in the proxy classes.
15789 2003-05-04 Miguel de Icaza <miguel@ximian.com>
15791 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
15792 need a proxy reference; I do not know what I was thinking
15794 * cs-parser.jay (constructor_initializer): catch another error,
15795 and display nice message.
15797 (field_declaration): catch void field declaration
15798 to flag a better error.
15800 * class.cs (MemberBase.CheckBase): Report an error instead of a
15801 warning if a new protected member is declared in a struct.
15802 (Field.Define): catch the error of readonly/volatile.
15804 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
15806 (FieldExpr.AddressOf): ditto. Catch error where the address of a
15807 volatile variable is taken
15809 2003-05-02 Miguel de Icaza <miguel@ximian.com>
15811 * statement.cs (Fixed.Resolve): Report an error if we are not in
15814 2003-05-01 Miguel de Icaza <miguel@ximian.com>
15816 * typemanager.cs: reuse the code that handles type clashes for
15817 delegates and enumerations.
15819 * class.cs (Report28): Always report.
15821 * expression.cs (EncodeAsAttribute): Allow nulls here.
15823 2003-04-28 Miguel de Icaza <miguel@ximian.com>
15825 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
15826 the functionality for testing whether an expression is valid for
15827 an attribute here. Also handle the case of arrays of elements
15830 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
15831 encoding a linear array into an array of objects that are suitable
15832 to be passed to an CustomAttributeBuilder.
15834 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
15836 * ecore.cs: (FieldExpr): Handle field remapping here.
15838 * iteratators.cs: Pass the instance variable (if the method is an
15839 instance method) to the constructors, so we can access the field
15840 variables on the class.
15842 TODO: Test this with structs. I think the THIS variable on
15843 structs might have to be a pointer, and not a refenrece
15845 2003-04-27 Miguel de Icaza <miguel@ximian.com>
15847 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
15848 local variables to fields in a proxy class.
15850 * iterators.cs (PopulateProxy): Rename our internal fields to
15852 Create a <THIS> field if we are an instance method, so we can
15853 reference our parent container variables.
15854 (MapVariable): Called back from the EmitContext code to enter a
15855 new variable to field mapping into the proxy class (we just create
15859 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
15860 for using the remapped locals to fields.
15862 I placed the code here, because that gives the same semantics to
15863 local variables, and only changes the Emit code.
15865 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
15866 statements inside iterators.
15867 (VariableInfo): Add a FieldBuilder for the cases when we are
15868 remapping local variables to fields in a proxy class
15870 * ecore.cs (SimpleNameResolve): Avoid testing two times for
15871 current_block != null.
15873 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
15874 not cope with strings, as it has been moved to the
15875 TableSwitchEmit. Fixed bug in switch generation.
15877 * expression.cs (New.DoResolve): Provide more context for the user
15878 when reporting an error.
15880 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
15883 * expression.cs (MemberAccess.DoResolve): When we get a type back,
15884 check the permissions for it. Note than in a type-resolution
15885 context the check was already present in DeclSpace.ResolveType,
15886 but was missing from the MemberAccess.
15888 (ArrayCreation.CheckIndices): warn if the user has
15889 more nested levels of expressions, but there are no more
15890 dimensions specified. Avoids crash on bug 41906.
15892 2003-04-26 Miguel de Icaza <miguel@ximian.com>
15894 * statement.cs (Block): replace Implicit bool, for a generic
15896 New flag: `Unchecked'. This is used during the EmitMeta phase
15897 (which is out-of-line with the regular Resolve/Emit process for a
15898 statement, as this is done ahead of time, but still gets a chance
15899 to call constant resolve).
15901 (Block.Flags): new enum for adding a new flag.
15903 (Block.EmitMeta): track the state of unchecked.
15905 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
15906 to enable constant resolution to work there as well.
15908 2003-04-22 Miguel de Icaza <miguel@ximian.com>
15910 * typemanager.cs (ienumerable_type): Also look up
15911 System.Collections.IEnumerable.
15913 2003-04-21 Miguel de Icaza <miguel@ximian.com>
15915 TODO: Test more than one conditional per method.
15917 * class.cs (Indexer.Define): Report the location where the user is
15918 referencing the unsupported feature.
15920 (MethodData): Overload the use of `conditionals' to
15921 minimize the creation of needless ArrayLists. This saves roughly
15922 212kb on my machine.
15924 (Method): Implement the new IIteratorContainer interface.
15925 (Method.SetYields): Implement the method by setting the ModFlags
15926 to contain METHOD_YIELDS.
15928 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
15929 which just got set to null.
15931 * iterators.cs: New file.
15933 (Yield, YieldBreak): New statements.
15935 * statement.cs (Return.Resolve): Flag an error if we are used in
15936 an iterator method.
15938 * codegen.cs (InIterator): New flag set if the code is being
15939 compiled in an iterator method.
15941 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
15942 internal modifier, and we just use it to avoid adding extra
15943 fields, as this is seldom used.
15945 * cs-parser.jay: Add yield_statement (yield and yield break).
15947 * driver.cs: New flag -v2 to turn on version 2 features.
15949 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
15950 hashtable when v2 is enabled.
15952 2003-04-20 Miguel de Icaza <miguel@ximian.com>
15954 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
15955 there is already a namespace defined with this name.
15957 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
15958 people upgraded their corlibs.
15960 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
15961 always use fully qualified types, no need to use the compiler
15964 (TypeManager.IsNamespace): Use binarysearch.
15966 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
15967 AddDelegate): I did not quite use the new IsValid API properly: I
15968 have to pass the short-name and the fullname. I was passing only
15969 the basename instead of the fullname sometimes.
15971 (TypeContainer.DefineType): call NamespaceClash.
15973 * interface.cs (Interface.DefineType): use NamespaceClash before
15976 * delegate.cs (Delegate.DefineType): use NamespaceClash before
15979 * enum.cs: (Enum.DefineType): use NamespaceClash before
15982 * typemanager.cs (: 3-line patch that gives us some tasty 11%
15983 speed increase. First, use the negative_hits cache when we get a
15984 negative. Second, add the type with its full original name
15985 instead of the new . and + encoded name (reflection uses + to
15986 separate type from a nested type). Use LookupTypeReflection
15987 directly which bypasses the type->name hashtable (that we already
15988 know does not contain the type.
15990 * decl.cs (DeclSpace.ResolveTypeExpr): track the
15991 location/container type.
15993 * driver.cs: When passing utf8, use directly the UTF8Encoding.
15995 2003-04-19 Miguel de Icaza <miguel@ximian.com>
15997 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
15999 * delegate.cs (NewDelegate.Resolve): Test whether an instance
16000 method is being referenced in the method group from a static
16001 context, and report error 120 if so.
16003 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
16006 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
16007 is created, we create the A namespace).
16009 * cs-parser.jay: A namespace also introduces a DeclarationFound.
16012 2003-04-18 Miguel de Icaza <miguel@ximian.com>
16014 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
16015 invocation to ModuleBuilder.GetType with the same values will
16016 return a new type instance, so we need to cache its return
16019 * expression.cs (Binary.ResolveOperator): Only allow the compare
16020 operators on enums if they are of the same type.
16022 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
16023 types of ValueType on their own case. Before we were giving them
16024 the same treatment as objects.
16026 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
16027 fullname. Short name is used to compare against container name.
16028 Fullname is used to check against defined namespace names.
16030 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
16031 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
16033 (Method.CheckBase): Call parent.
16034 (MemberBase.CheckBase): Check for protected members on sealed
16036 (PropertyBase.CheckBase): Call parent.
16037 (Field.Define): Call parent.
16039 * report.cs: Negative error codes are now mapped to 8000 - code,
16040 so that the display is render more nicely.
16042 * typemanager.cs: Do not use try/catch, instead report a regular
16045 (GetPointerType, GetReferenceType): These methods provide
16046 mechanisms to obtain the T* and T& from a T. We had the code
16047 previously scattered around the code base, and it also used
16048 TypeManager.LookupType that would go through plenty of caches.
16049 This one goes directly to the type source.
16051 In some places we did the Type.GetType followed by
16052 ModuleBuilder.GetType, but not in others, so this unifies the
16053 processing as well.
16055 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
16056 statements now that we have namespace information.
16058 * typemanager.cs (IsNamespace): New method, returns whether the
16059 string presented is a namespace or not.
16061 (ComputeNamespaces): New public entry point, computes the list of
16062 available namespaces, using the GetNamespaces API call in Mono, or
16063 the slower version in MS.NET.
16065 Now before we start the semantic analysis phase, we have a
16066 complete list of namespaces including everything that the user has
16069 Deleted old code to cache namespaces in .nsc files.
16071 2003-04-17 Miguel de Icaza <miguel@ximian.com>
16073 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
16074 class/struct location definition Location for the implicit
16075 constructor location.
16077 (Operator.Define): Use the location of the operator for the
16078 implicit Method definition.
16080 (Constructor.Emit): use the constructor location for the implicit
16081 base initializer constructor.
16083 * ecore.cs: Remove ITypeExpression. This interface is now gone,
16084 and the Expression class now contains two new methods:
16086 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
16087 isolate type lookup from the rest of the resolution process.
16089 Since we use Expressions to hold type definitions due to the way
16090 we parse the input we have historically overloaded Resolve to
16091 perform the Type lookups if a special flag is passed. Now this is
16092 eliminated and two methods take their place.
16094 The differences in the two methods between xStep and xTerminal is
16095 that xStep is involved in our current lookup system that uses
16096 SimpleNames to compose a name, while xTerminal is used just to
16097 catch the case where the simplename lookup failed.
16099 2003-04-16 Miguel de Icaza <miguel@ximian.com>
16101 * expression.cs (ResolveMemberAccess): Remove redundant code.
16102 TypeExpr expressions are always born fully resolved.
16104 * interface.cs (PopulateMethod): Do not lookup the types twice.
16105 We were doing it once during SemanticAnalysis and once during
16108 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
16109 in local variable type definitions, were being returned as a
16110 SimpleName (we decomposed everything into a string), that is
16111 because primary_expression was being used instead of a type in the
16112 grammar (reduce/reduce conflicts).
16114 The part that was wrong is that we converted the expression into a
16115 string (an oversimplification in one hand, compounded with primary
16116 expressions doing string concatenation).
16122 Would return "A.B.C[]" as a SimpleName. This stopped things like
16123 using clauses from working on this particular context. And a type
16124 was being matched directly against "A.B.C[]".
16126 We now use the correct approach, and allow for ComposedCast to be
16127 part of the unary expression. So the "A.B.C []" become a composed
16128 cast of "A.B.C" (as a nested group of MemberAccess with a
16129 SimpleName at the end) plus the rank composition "[]".
16133 2003-04-10 Miguel de Icaza <miguel@ximian.com>
16135 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
16136 for the access level checking.
16138 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
16139 `TypeContainer container', because I kept getting confused when I
16140 was debugging this code.
16142 * expression.cs (Indexers): Instead of tracking getters/setters,
16143 we now track them in parallel. We create one arraylist less, but
16144 most importantly it is possible now for the LValue code to find a
16145 matching get for a set.
16147 (IndexerAccess.DoResolveLValue): Update the code.
16148 GetIndexersForType has been modified already to extract all the
16149 indexers from a type. The code assumed it did not.
16151 Also make the code set the correct return type for the indexer.
16152 This was fixed a long time ago for properties, but was missing for
16153 indexers. It used to be void_type.
16155 (Binary.Emit): Test first for doubles instead of
16156 floats, as they are more common.
16158 (Binary.EmitBranchable): Use the .un version of the branch opcodes
16159 when dealing with floats and the <=, >= operators. This fixes bug
16162 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
16163 to load the array value by emitting a load on the foreach variable
16164 type. This was incorrect.
16166 We now emit the code to load an element using the the array
16167 variable type, and then we emit the conversion operator.
16171 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
16173 * attribute.cs: Avoid allocation of ArrayLists in the common case.
16175 2003-04-09 Miguel de Icaza <miguel@ximian.com>
16177 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
16178 test for protection before we test for signatures.
16180 (MethodSignature.ToString): implement.
16182 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
16183 to the case where we reduced into a LongConstant.
16185 * decl.cs (CheckAccessLevel): If the type is an array, we can not
16186 depend on whether the information is acurrate, because the
16187 Microsoft runtime will always claim that the array type is public,
16188 regardless of the real state.
16190 If the type is a pointer, another problem happens: the type is
16191 reported as non-public in Microsoft.
16193 In both cases we have to call CheckAccessLevel recursively with
16194 the underlying type as the argument to be tested.
16196 2003-04-08 Miguel de Icaza <miguel@ximian.com>
16198 * assign.cs (Assign.Emit): If we are dealing with a compound
16199 assignment expression, we should use the code path that stores the
16200 intermediate result in a temporary value. This fixes #40903.
16202 *expression.cs (Indirection.ToString): Provide ToString method for
16205 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
16207 * class.cs: Null out fields holding references to Block objects so
16208 they can be garbage collected.
16210 * expression.cs (OverloadResolve): Remove unused local.
16212 2003-04-07 Martin Baulig <martin@ximian.com>
16214 * codegen.cs (EmitContext.CurrentFile): New public field.
16215 (EmitContext.Mark): Use the CurrentFile to check whether the
16216 location is in the correct file.
16217 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
16219 2003-04-07 Martin Baulig <martin@ximian.com>
16221 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
16223 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
16224 location. [FIXME: The location argument which gets passed to this
16225 method is sometimes wrong!]
16227 2003-04-07 Nick Drochak <ndrochak@gol.com>
16229 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
16231 2003-04-07 Miguel de Icaza <miguel@ximian.com>
16233 * expression.cs (Indirection.EmitAssign): We were using the
16234 temporary, but returning immediately instead of continuing the
16237 2003-04-06 Martin Baulig <martin@ximian.com>
16239 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
16240 if it's a nested child, but also deriving from the outer class.
16243 * typemanager.cs (IsNestedChildOf): Make this work if it's a
16244 nested child, but also deriving from the outer class. See
16246 (FilterWithClosure): We may access private members of the outer
16247 class if we're a nested child and deriving from the outer class.
16248 (RealMemberLookup): Only set `closure_private_ok' if the
16249 `original_bf' contained BindingFlags.NonPublic.
16251 2003-04-05 Martin Baulig <martin@ximian.com>
16253 * expression.cs (SizeOf.DoResolve): Use ResolveTypeExpr, so we can
16254 probe if its a type parameter, and if so, flag an error.
16256 * decl.cs: Move here the SetParameterInfo code from class.cs.
16257 Handle IsGeneric here.
16259 Handle a variety of errors in the parameter info definition.
16261 * ecore.cs (SimpleName.DoResolveType): Handle look ups for generic
16262 type parameters here.
16264 * cs-parser.jay (class_declaration): report errors for parameters
16267 2003-01-21 Miguel de Icaza <miguel@ximian.com>
16269 * generic.cs: New file, contains support code for generics.
16271 * cs-parser.jay: Remove OP_SHIFT_LEFT, OP_SHIFT_RIGHT,
16272 OP_SHIFT_LEFT_ASSIGN, OP_SHIFT_RIGHT_ASSIGN.
16274 Update parser for the above removals.
16276 * cs-tokenizer.cs: Do not handle <<= or >>= specially. This is
16277 now taken care of in the parser.
16279 2003-04-02 Miguel de Icaza <miguel@ximian.com>
16281 * class.cs (Event.Define): Do not allow abstract events to have
16284 2003-04-01 Miguel de Icaza <miguel@ximian.com>
16286 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
16287 block in event declarations.
16289 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
16290 value type, get its address.
16292 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
16293 leaving a class on the stack instead of a boolean value (int
16294 0/1). Change the code so we compare against null, and then the
16295 result against zero.
16297 * class.cs (TypeContainer.GetClassBases): We were checking for the
16298 parent class being sealed too late.
16300 * expression.cs (Binary.Emit): For <= and >= when dealing with
16301 floating point values, use cgt.un and clt.un instead of cgt and
16304 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
16306 * statement.cs: Apply the same optimization as MS: skip the
16307 GetEnumerator returning an IEnumerator, and use the one returning a
16308 CharEnumerator instead. This allows us to avoid the try-finally block
16311 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
16313 * cs-parser.jay: Attributes cannot be applied to
16314 namespaces. Fixes #40473
16316 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16319 (Add*): check if the name is valid using the full name for constants,
16320 fields, properties and events.
16322 2003-03-28 Miguel de Icaza <miguel@ximian.com>
16324 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
16325 char constants to be part of the enumeration.
16327 * expression.cs (Conditional.DoResolve): Add support for operator
16328 true. Implements the missing functionality from 14.12
16330 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
16331 operator true/false as required by the spec.
16333 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
16334 implicit conversion to boolean.
16336 * statement.cs (Statement.ResolveBoolean): A boolean expression is
16337 also one where the type implements `operator true'.
16339 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
16340 get an expression that will invoke operator true based on an
16343 (GetConversionOperators): Removed the hack that called op_True
16346 (Expression.ResolveBoolean): Move this from Statement.
16348 2003-03-17 Miguel de Icaza <miguel@ximian.com>
16350 * ecore.cs (FieldExpr): do not allow initialization of initonly
16351 fields on derived classes
16353 2003-03-13 Martin Baulig <martin@ximian.com>
16355 * statement.cs (Block.Emit): Call ig.BeginScope() and
16356 ig.EndScope() when compiling with debugging info; call
16357 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
16359 2003-03-08 Miguel de Icaza <miguel@ximian.com>
16361 * expression.cs (Indexers): Do not construct immediately, allow
16362 for new members to be appended as we go. Fixes 38143
16364 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16366 * expression.cs: save/restore context when resolving an unchecked
16369 2003-03-05 Miguel de Icaza <miguel@ximian.com>
16371 * cfold.cs: Catch division by zero in modulus operator during
16374 2003-03-03 Miguel de Icaza <miguel@ximian.com>
16376 * interface.cs (Interface.DefineMembers): Avoid defining members
16379 2003-02-27 Miguel de Icaza <miguel@ximian.com>
16381 * driver.cs: handle the +/- options for -noconfig
16383 * statement.cs (Unckeched.Resolve): Also track the state of
16384 unchecked in the Resolve phase.
16386 2003-02-27 Martin Baulig <martin@ximian.com>
16388 * ecore.cs (Expression.MemberLookup): Don't create a
16389 MethodGroupExpr for something which is not a method. Fixes #38291.
16391 2003-02-25 Miguel de Icaza <miguel@ximian.com>
16393 * class.cs (MemberBase.CheckParameters): Also check that the type
16394 is unmanaged if it is a pointer.
16396 * expression.cs (SizeOf.Resolve): Add location information.
16398 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
16399 a managed type is declared.
16401 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
16402 parameter modifiers as well. Fixes bug 38606
16404 * class.cs: Very sad. Am backing out the speed up changes
16405 introduced by the ArrayList -> Array in the TypeContainer, as they
16406 were not actually that much faster, and introduced a bug (no error
16407 reports on duplicated methods).
16409 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
16410 source first, this will guarantee that we have a valid expression
16411 before calling in lower levels functions that will require a
16412 resolved object. Then use this original_source in the
16413 target.ResolveLValue instead of the original source that was
16416 Another change. Use target.Resolve instead of LValueResolve.
16417 Although we are resolving for LValues, we will let the Assign code
16418 take care of that (it will be called again from Resolve). This
16419 basically allows code like this:
16421 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
16422 class Y { void A (X x) { x [0] += o; }
16424 The problem was that the indexer was trying to resolve for
16425 set_Item (idx, object o) and never finding one. The real set_Item
16426 was set_Item (idx, X). By delaying the process we get the right
16431 2003-02-23 Martin Baulig <martin@ximian.com>
16433 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
16434 while calling DoEmit ().
16436 * codegen.cs (EmitContext.Mark): Don't mark locations in other
16437 source files; if you use the #line directive inside a method, the
16438 compiler stops emitting line numbers for the debugger until it
16439 reaches the end of the method or another #line directive which
16440 restores the original file.
16442 2003-02-23 Martin Baulig <martin@ximian.com>
16444 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
16446 2003-02-23 Martin Baulig <martin@ximian.com>
16448 * statement.cs (Block.AddChildVariableNames): We need to call this
16449 recursively, not just for our immediate children.
16451 2003-02-23 Martin Baulig <martin@ximian.com>
16453 * class.cs (Event.Define): Always make the field private, like csc does.
16455 * typemanager.cs (TypeManager.RealMemberLookup): Make events
16456 actually work, fixes bug #37521.
16458 2003-02-23 Miguel de Icaza <miguel@ximian.com>
16460 * delegate.cs: When creating the various temporary "Parameters"
16461 classes, make sure that we call the ComputeAndDefineParameterTypes
16462 on those new parameters (just like we do with the formal ones), to
16463 allow them to be resolved in the context of the DeclSpace.
16465 This fixes the bug that Dick observed in Bugzilla #38530.
16467 2003-02-22 Miguel de Icaza <miguel@ximian.com>
16469 * expression.cs (ResolveMemberAccess): When resolving a constant,
16470 do not attempt to pull a constant if the value was not able to
16471 generate a valid constant.
16473 * const.cs (LookupConstantValue): Do not report more errors than required.
16475 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16477 * expression.cs: fixes bug #38328.
16479 2003-02-18 Miguel de Icaza <miguel@ximian.com>
16481 * class.cs: Changed all the various members that can be part of a
16482 class from being an ArrayList to be an Array of the right type.
16483 During the DefineType type_list, interface_list, delegate_list and
16484 enum_list are turned into types, interfaces, delegates and enums
16487 And during the member population, indexer_list, event_list,
16488 constant_list, field_list, instance_constructor_list, method_list,
16489 operator_list and property_list are turned into their real arrays.
16491 Although we could probably perform this operation earlier, for
16492 good error reporting we need to keep the lists and remove the
16493 lists for longer than required.
16495 This optimization was triggered by Paolo profiling the compiler
16496 speed on the output of `gen-sample-program.pl' perl script.
16498 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
16499 not crash in methods like MemberLookupFailed that use this field.
16501 This problem arises when the compiler fails to resolve a type
16502 during interface type definition for example.
16504 2003-02-18 Miguel de Icaza <miguel@ximian.com>
16506 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
16507 inherit from System.Object, so we have to stop at null, not only
16508 when reaching System.Object.
16510 2003-02-17 Miguel de Icaza <miguel@ximian.com>
16512 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
16513 DeclaredOnly because the parent indexer might have had a different
16514 name, but did not loop until the top of the hierarchy was reached.
16516 The problem this one fixes is 35492: when a class implemented an
16517 indexer from an interface, we were getting the interface method
16518 (which was abstract) and we were flagging an error (can not invoke
16521 This also keeps bug 33089 functioning, and test-148 functioning.
16523 * typemanager.cs (IsSpecialMethod): The correct way of figuring
16524 out if a method is special is to see if it is declared in a
16525 property or event, or whether it is one of the predefined operator
16526 names. This should fix correctly #36804.
16528 2003-02-15 Miguel de Icaza <miguel@ximian.com>
16530 The goal here is to remove the dependency on EmptyCast.Peel ().
16531 Killing it completely.
16533 The problem is that currently in a number of places where
16534 constants are expected, we have to "probe" for an EmptyCast, and
16535 Peel, which is not the correct thing to do, as this will be
16536 repetitive and will likely lead to errors.
16538 The idea is to remove any EmptyCasts that are used in casts that
16539 can be reduced to constants, so we only have to cope with
16542 This bug hunt was triggered by Bug 37363 and the desire to remove
16543 the duplicate pattern where we were "peeling" emptycasts to check
16544 whether they were constants. Now constants will always be
16547 * ecore.cs: Use an enumconstant here instead of wrapping with
16550 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
16551 throwing me off. By handling this we can get rid of a few hacks.
16553 * statement.cs (Switch): Removed Peel() code.
16555 2003-02-14 Miguel de Icaza <miguel@ximian.com>
16557 * class.cs: Location information for error 508
16559 * expression.cs (New.DoResolve): Add a guard against double
16560 resolution of an expression.
16562 The New DoResolve might be called twice when initializing field
16563 expressions (see EmitFieldInitializers, the call to
16564 GetInitializerExpression will perform a resolve on the expression,
16565 and later the assign will trigger another resolution
16567 This leads to bugs (#37014)
16569 * delegate.cs: The signature for EndInvoke should contain any ref
16570 or out parameters as well. We were not doing this in the past.
16572 * class.cs (Field.Define): Do not overwrite the type definition
16573 inside the `volatile' group. Turns out that volatile enumerations
16574 were changing the type here to perform a validity test, which
16577 2003-02-12 Miguel de Icaza <miguel@ximian.com>
16579 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
16580 and structs, we do not want to load the instance variable
16582 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
16583 enum_type has to be handled like an object reference (implicit
16584 conversions exists from this to object), but the regular IsClass
16585 and IsValueType tests will never return true for this one.
16587 Also we use TypeManager.IsValueType instead of type.IsValueType,
16588 just for consistency with the rest of the code (this is only
16589 needed if we ever use the construct exposed by test-180.cs inside
16590 corlib, which we dont today).
16592 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
16594 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
16597 2003-02-09 Martin Baulig <martin@ximian.com>
16599 * namespace.cs (Namespace..ctor): Added SourceFile argument.
16600 (Namespace.DefineNamespaces): New static public method; this is
16601 called when we're compiling with debugging to add all namespaces
16602 to the symbol file.
16604 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
16605 pass it to the Namespace's .ctor.
16607 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
16608 and MethodBase arguments; pass the namespace ID to the symwriter;
16609 pass the MethodBase instead of the token to the symwriter.
16610 (SymbolWriter.DefineNamespace): New method to add a namespace to
16613 2003-02-09 Martin Baulig <martin@ximian.com>
16615 * symbolwriter.cs: New file. This is a wrapper around
16616 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
16617 methods here in near future.
16619 2003-02-09 Martin Baulig <martin@ximian.com>
16621 * codegen.cs (EmitContext.Mark): Just pass the arguments to
16622 ILGenerator.MarkSequencePoint() which are actually used by the
16625 2003-02-09 Martin Baulig <martin@ximian.com>
16627 * location.cs (SourceFile): New public sealed class. This
16628 contains the name and an index which is used in the location's token.
16629 (Location): Reserve an appropriate number of bits in the token for
16630 the source file instead of walking over that list, this gives us a
16631 really huge performance improvement when compiling with debugging.
16633 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
16634 `SourceFile' argument instead of a string.
16635 (Driver.ProcessFile): Add all the files via Location.AddFile(),
16636 but don't parse/tokenize here, we need to generate the list of all
16637 source files before we do that.
16638 (Driver.ProcessFiles): New static function. Parses/tokenizes all
16641 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
16642 instead of a string.
16644 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
16647 2003-02-09 Martin Baulig <martin@ximian.com>
16649 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
16650 filename on `#line default'.
16652 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
16654 * statement.cs: don't clear the pinned var when the fixed statement
16655 returns from the method (fixes bug#37752).
16657 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
16659 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
16662 2003-02-07 Martin Baulig <martin@ximian.com>
16664 * driver.cs: Removed the `--debug-args' command line argument.
16666 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
16667 automatically by the AsssemblyBuilder.
16668 (CodeGen.InitializeSymbolWriter): We don't need to call any
16669 initialization function on the symbol writer anymore. This method
16670 doesn't take any arguments.
16672 2003-02-03 Miguel de Icaza <miguel@ximian.com>
16674 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
16675 from referenced assemblies as well.
16677 2003-02-02 Martin Baulig <martin@ximian.com>
16679 * class.cs (MethodData.Emit): Generate debugging info for external methods.
16681 2003-02-02 Martin Baulig <martin@ximian.com>
16683 * class.cs (Constructor.Emit): Open the symbol writer before
16684 emitting the constructor initializer.
16685 (ConstructorInitializer.Emit): Call ec.Mark() to allow
16686 single-stepping through constructor initializers.
16688 2003-01-30 Miguel de Icaza <miguel@ximian.com>
16690 * class.cs: Handle error 549: do not allow virtual methods in
16693 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
16695 * decl.cs: Check access levels when resolving types
16697 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
16699 * statement.cs: Add parameters and locals set in catch blocks that might
16700 return to set vector
16702 2003-01-29 Miguel de Icaza <miguel@ximian.com>
16704 * class.cs (Operator): Set the SpecialName flags for operators.
16706 * expression.cs (Invocation.DoResolve): Only block calls to
16707 accessors and operators on SpecialName methods.
16709 (Cast.TryReduce): Handle conversions from char constants.
16712 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
16714 * statement.cs: small memory and time optimization in FlowBranching.
16716 2003-01-28 Pedro Mart <yoros@wanadoo.es>
16718 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
16719 problem that the last fix but in the other sid (Set).
16721 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
16722 access when there is no indexer in the hierarchy.
16724 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
16726 * class.cs: Combine some if statements.
16728 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16730 * driver.cs: fixed bug #37187.
16732 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
16734 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
16735 any indexer, it's needed to build a list with all the indexers in the
16736 hierarchy (AllGetters), else we have problems. Fixes #35653.
16738 2003-01-23 Miguel de Icaza <miguel@ximian.com>
16740 * class.cs (MethodData.Define): It is wrong for an interface
16741 implementation to be static in both cases: explicit and implicit.
16742 We were only handling this in one case.
16744 Improve the if situation there to not have negations.
16746 * class.cs (Field.Define): Turns out that we do not need to check
16747 the unsafe bit on field definition, only on usage. Remove the test.
16749 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16751 * driver.cs: use assembly.Location instead of Codebase (the latest
16752 patch made mcs fail when using MS assemblies).
16754 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
16756 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
16757 get the path to *corlib.dll.
16759 2003-01-21 Nick Drochak <ndrochak@gol.com>
16763 * typemanager.cs: Remove compiler warnings
16765 2003-01-20 Duncan Mak <duncan@ximian.com>
16767 * AssemblyInfo.cs: Bump the version number to 0.19.
16769 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16771 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
16773 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
16775 * class.cs (Constructor::Emit): Emit debugging info for constructors.
16777 2003-01-17 Miguel de Icaza <miguel@ximian.com>
16779 * cs-parser.jay: Small fix: we were not comparing the constructor
16780 name correctly. Thanks to Zoltan for the initial pointer.
16782 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
16784 * cs-tokenizer.cs: Set file name when specified with #line
16786 2003-01-15 Miguel de Icaza <miguel@ximian.com>
16788 * cs-parser.jay: Only perform the constructor checks here if we
16789 are named like the class; This will help provider a better
16790 error. The constructor path is taken when a type definition is
16791 not found, but most likely the user forgot to add the type, so
16792 report that rather than the constructor error.
16794 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
16796 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
16799 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
16801 * cs-parser.jay: Add cleanup call.
16803 2003-01-13 Duncan Mak <duncan@ximian.com>
16805 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
16806 consistent with other methods.
16808 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
16810 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
16812 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
16814 * attribute.cs: only set GuidAttr to true when we have a
16817 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16821 * typemanager.cs: fixes to allow mcs compile corlib with the new
16822 Type.IsSubclassOf fix.
16824 2003-01-08 Miguel de Icaza <miguel@ximian.com>
16826 * expression.cs (LocalVariableReference.DoResolve): Classify a
16827 constant as a value, not as a variable. Also, set the type for
16830 * cs-parser.jay (fixed_statement): take a type instead of a
16831 pointer_type, so we can produce a better error message later.
16833 * statement.cs (Fixed.Resolve): Flag types that are not pointers
16836 (For.DoEmit): Make inifinite loops have a
16837 non-conditional branch back.
16839 (Fixed.DoEmit): First populate the pinned variables, then emit the
16840 statement, then clear the variables. Before I was emitting the
16841 code once for each fixed piece.
16844 2003-01-08 Martin Baulig <martin@ximian.com>
16846 * statement.cs (FlowBranching.MergeChild): A break in a
16847 SWITCH_SECTION does not leave a loop. Fixes #36155.
16849 2003-01-08 Martin Baulig <martin@ximian.com>
16851 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
16852 lives in the same number space than `param_map'. Fixes #36154.
16854 2003-01-07 Miguel de Icaza <miguel@ximian.com>
16856 * cs-parser.jay (constructor_declaration): Set the
16857 Constructor.ModFlags before probing for it. This makes the
16858 compiler report 514, 515 and 132 (the code was there, but got
16861 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
16862 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
16863 (GotoCase.Resolve): Set `Returns' to ALWAYS.
16865 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
16867 * enum.cs: create the enum static fields using the enum type.
16869 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
16871 * class.cs: don't try to create the ParamBuilder for the return
16872 type if it's not needed (and handle it breaking for the ms runtime
16875 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
16877 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
16879 2002-12-29 Miguel de Icaza <miguel@ximian.com>
16881 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
16882 the command. This showed up while compiling the JANET source
16883 code, which used \r as its only newline separator.
16885 2002-12-28 Miguel de Icaza <miguel@ximian.com>
16887 * class.cs (Method.Define): If we are an operator (because it
16888 reuses our code), then set the SpecialName and HideBySig. #36128
16890 2002-12-22 Miguel de Icaza <miguel@ximian.com>
16892 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
16893 exception, report error 120 `object reference required'.
16895 * driver.cs: Add --pause option, used during to measure the size
16896 of the process as it goes with --timestamp.
16898 * expression.cs (Invocation.DoResolve): Do not allow methods with
16899 SpecialName to be invoked.
16901 2002-12-21 Miguel de Icaza <miguel@ximian.com>
16903 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
16904 number before adding it.
16906 2002-12-21 Ravi Pratap <ravi@ximian.com>
16908 * ecore.cs (StandardImplicitConversion): When in an unsafe
16909 context, we allow conversion between void * to any other pointer
16910 type. This fixes bug #35973.
16912 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
16914 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
16915 is not thrown when extensionless outputs are used
16917 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16919 * rootcontext.cs: fixed compilation of corlib.
16921 2002-12-19 Miguel de Icaza <miguel@ximian.com>
16923 * attribute.cs (Attributes.Contains): Add new method.
16925 * class.cs (MethodCore.LabelParameters): if the parameter is an
16926 `out' parameter, check that no attribute `[In]' has been passed.
16928 * enum.cs: Handle the `value__' name in an enumeration.
16930 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
16932 * decl.cs: Added special case to allow overrides on "protected
16935 2002-12-18 Ravi Pratap <ravi@ximian.com>
16937 * attribute.cs (Attributes.AddAttributeSection): Rename to this
16938 since it makes much more sense.
16940 (Attributes.ctor): Don't require a Location parameter.
16942 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
16944 * attribute.cs (ApplyAttributes): Remove extra Location parameters
16945 since we already have that information per attribute.
16947 * everywhere : make appropriate changes.
16949 * class.cs (LabelParameters): Write the code which actually
16950 applies attributes to the return type. We can't do this on the MS
16951 .NET runtime so we flag a warning in the case an exception is
16954 2002-12-18 Miguel de Icaza <miguel@ximian.com>
16956 * const.cs: Handle implicit null conversions here too.
16958 2002-12-17 Ravi Pratap <ravi@ximian.com>
16960 * class.cs (MethodCore.LabelParameters): Remove the extra
16961 Type [] parameter since it is completely unnecessary. Instead
16962 pass in the method's attributes so that we can extract
16963 the "return" attribute.
16965 2002-12-17 Miguel de Icaza <miguel@ximian.com>
16967 * cs-parser.jay (parse): Use Report.Error to flag errors instead
16968 of ignoring it and letting the compile continue.
16970 * typemanager.cs (ChangeType): use an extra argument to return an
16971 error condition instead of throwing an exception.
16973 2002-12-15 Miguel de Icaza <miguel@ximian.com>
16975 * expression.cs (Unary.TryReduce): mimic the code for the regular
16976 code path. Perform an implicit cast in the cases where we can
16977 implicitly convert to one of the integral types, and then reduce
16978 based on that constant. This fixes bug #35483.
16980 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16982 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
16984 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16986 * namespace.cs: fixed bug #35489.
16988 2002-12-12 Miguel de Icaza <miguel@ximian.com>
16990 * class.cs: Remove some dead code.
16992 * cs-parser.jay: Estimate the number of methods needed
16993 (RootContext.MethodCount);
16995 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
16996 numbers instead of StringBuilders.
16998 * support.cs (PtrHashtable): Add constructor with initial size;
16999 We can now reduce reallocations of the method table.
17001 2002-12-10 Ravi Pratap <ravi@ximian.com>
17003 * attribute.cs (ApplyAttributes): Keep track of the emitted
17004 attributes on a per-target basis. This fixes bug #35413.
17006 2002-12-10 Miguel de Icaza <miguel@ximian.com>
17008 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
17009 default to the Windows 1252 encoding.
17011 (UnixParseOption): Support version, thanks to Alp for the missing
17014 * AssemblyInfo.cs: Add nice assembly information.
17016 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
17019 * cs-parser.jay: Allow a trailing comma before the close bracked
17020 in the attribute_section production.
17022 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
17023 address of the instance was being taken, I will take this out,
17024 because we take the address of the object immediately here.
17026 2002-12-09 Ravi Pratap <ravi@ximian.com>
17028 * typemanager.cs (AreMultipleAllowed): Take care of the most
17029 obvious case where attribute type is not in the current assembly -
17032 2002-12-08 Miguel de Icaza <miguel@ximian.com>
17034 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
17035 definitions, instead of doing that afterwards.
17037 Also we use a nice little hack, depending on the constructor, we
17038 know if we are a "composed" name or a simple name. Hence, we
17039 avoid the IndexOf test, and we avoid
17041 * codegen.cs: Add code to assist in a bug reporter to track down
17042 the source of a compiler crash.
17044 2002-12-07 Ravi Pratap <ravi@ximian.com>
17046 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
17047 types have been emitted for a given element and flag an error
17048 if something which does not have AllowMultiple set is used more
17051 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
17052 attribute types and their corresponding AllowMultiple properties
17054 (AreMultipleAllowed): Check the property for a given type.
17056 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
17057 property in the case we have a TypeContainer.
17059 (Attributes.AddAttribute): Detect duplicates and just skip on
17060 adding them. This trivial fix catches a pretty gross error in our
17061 attribute emission - global attributes were being emitted twice!
17063 Bugzilla bug #33187 is now fixed.
17065 2002-12-06 Miguel de Icaza <miguel@ximian.com>
17067 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
17068 instead of pp_and).
17070 * expression.cs (Binary.ResolveOperator): I can only use the
17071 Concat (string, string, string) and Concat (string, string,
17072 string, string) if the child is actually a concatenation of
17075 2002-12-04 Miguel de Icaza <miguel@ximian.com>
17077 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
17078 context where we need a 2-character lookahead.
17080 * pending.cs (PendingImplementation): Rework so we can keep track
17081 of interface types all the time, and flag those which were
17082 implemented by parents as optional.
17084 2002-12-03 Miguel de Icaza <miguel@ximian.com>
17086 * expression.cs (Binary.ResolveOperator): Use
17087 String.Concat(string,string,string) or
17088 String.Concat(string,string,string,string) when possible.
17090 * typemanager: More helper methods.
17093 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
17095 * pending.cs: remove the bogus return from GetMissingInterfaces()
17096 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
17098 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17100 * namespace.cs: avoid duplicated 'using xxx' being added to
17101 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
17102 when we get more than one 'using' statement for the same namespace.
17103 Report a CS0105 warning for it.
17105 2002-11-30 Miguel de Icaza <miguel@ximian.com>
17107 * cs-tokenizer.cs (consume_identifier): use read directly, instead
17108 of calling getChar/putback, uses internal knowledge of it.
17110 (xtoken): Reorder tokenizer so most common patterns are checked
17111 first. This reduces the compilation time in another 5% (from 8.11s
17112 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
17114 The parsing time is 22% of the compilation in mcs, and from that
17115 64% is spent on the tokenization process.
17117 I tried using a binary search for keywords, but this is slower
17118 than the hashtable. Another option would be to do a couple of
17121 * Not use a StringBuilder, instead use an array of chars,
17122 with a set value. Notice that this way we could catch
17123 the 645 error without having to do it *afterwards*.
17125 * We could write a hand-parser to avoid the hashtable
17126 compares altogether.
17128 The identifier consumption process takes 37% of the tokenization
17129 time. Another 15% is spent on is_number. 56% of the time spent
17130 on is_number is spent on Int64.Parse:
17132 * We could probably choose based on the string length to
17133 use Int32.Parse or Int64.Parse and avoid all the 64-bit
17136 Another 3% is spend on wrapping `xtoken' in the `token' function.
17138 Handle 0xa0 as whitespace (#34752)
17140 2002-11-26 Miguel de Icaza <miguel@ximian.com>
17142 * typemanager.cs (IsCLRType): New routine to tell whether a type
17143 is one of the builtin types.
17145 Maybe it needs to use TypeCodes to be faster. Maybe we could use
17146 typecode in more places instead of doing pointer comparissions.
17147 We could leverage some knowledge about the way the typecodes are
17150 New code to cache namespaces in assemblies, it is currently not
17151 invoked, to be used soon.
17153 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
17155 * expression.cs (Binary.ResolveOperator): specially handle
17156 strings, and do not perform user-defined operator overloading for
17159 2002-11-24 Miguel de Icaza <miguel@ximian.com>
17161 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
17162 internalcall as it is a pretty simple operation; Avoid whenever
17163 possible to call Char.IsLetter.
17165 (consume_identifier): Cut by half the number of
17166 hashtable calls by merging the is_keyword and GetKeyword behavior.
17168 Do not short-circuit, because if we do, we
17169 report errors (ie, #if false && true would produce an invalid
17173 2002-11-24 Martin Baulig <martin@ximian.com>
17175 * expression.cs (Cast.TryReduce): If we're in checked syntax,
17176 check constant ranges and report a CS0221. Fixes #33186.
17178 2002-11-24 Martin Baulig <martin@ximian.com>
17180 * cs-parser.jay: Make this work for uninitialized variable
17181 declarations in the `for' initializer. Fixes #32416.
17183 2002-11-24 Martin Baulig <martin@ximian.com>
17185 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
17186 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
17188 2002-11-24 Martin Baulig <martin@ximian.com>
17190 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
17191 argument; if true, we also check for user-defined conversions.
17192 This is only needed if both arguments are of a user-defined type.
17193 Fixes #30443, added test-175.cs.
17194 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
17196 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
17198 2002-11-24 Martin Baulig <martin@ximian.com>
17200 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
17201 function to get the store opcode.
17202 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
17203 only emit the Ldelema if the store opcode is Stobj. You must run
17204 both test-34 and test-167 to test this. Fixes #34529.
17206 2002-11-23 Martin Baulig <martin@ximian.com>
17208 * ecore.cs (Expression.MemberLookup): Added additional
17209 `qualifier_type' argument which is used when we're being called
17210 from MemberAccess.DoResolve() and null if we're called from a
17212 (Expression.MemberLookupFailed): New method to report errors; this
17213 does the CS1540 check and reports the correct error message.
17215 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
17216 argument for the CS1540 check and redone the way how we're dealing
17217 with private members. See the comment in the source code for details.
17218 (FilterWithClosure): Reverted this back to revision 1.197; renamed
17219 `closure_start_type' to `closure_qualifier_type' and check whether
17220 it's not null. It was not this filter being broken, it was just
17221 being called with the wrong arguments.
17223 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
17224 and pass it the correct `qualifier_type'; this also does the error
17227 2002-11-22 Miguel de Icaza <miguel@ximian.com>
17229 * expression.cs (Invocation.EmitParams): If the we are dealing
17230 with a non-built-in value type, load its address as well.
17232 (ArrayCreation): Use a a pretty constant instead
17233 of the hardcoded value 2. Use 6 instead of 2 for the number of
17234 static initializers.
17236 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
17237 because they are not really value types, just glorified integers.
17239 * driver.cs: Do not append .exe, the CSC compiler does not do it.
17241 * ecore.cs: Remove redundant code for enumerations, make them use
17242 the same code path as everything else, fixes the casting issue
17243 with enumerations in Windows.Forms.
17245 * attribute.cs: Do only cast to string if it is a string, the
17246 validation happens later.
17248 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
17249 people upgrade their corlibs.
17251 * ecore.cs: Oops, enumerations were not following the entire code path
17253 2002-11-21 Miguel de Icaza <miguel@ximian.com>
17255 * typemanager.cs (FilterWithClosure): Commented out the test for
17256 1540 in typemanager.cs, as it has problems when accessing
17257 protected methods from a parent class (see test-174.cs).
17259 * attribute.cs (Attribute.ValidateGuid): new method.
17260 (Attribute.Resolve): Use above.
17262 2002-11-19 Miguel de Icaza <miguel@ximian.com>
17264 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
17266 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
17267 handling for enumerations, as we only needed the TypeContainer
17268 functionality to begin with (this is required for the fix below to
17269 work for enums that reference constants in a container class for
17272 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
17274 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
17275 a valid TypeBuilder to perform lookups on.o
17277 * class.cs (InheritableMemberSignatureCompare): Use true in the
17278 call to GetGetMethod and GetSetMethod, because we are comparing
17279 the signature, and we need to get the methods *even* if they are
17282 (PropertyBase.CheckBase): ditto.
17284 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
17285 GotoCase.Resolve): Use Peel on EmpytCasts.
17287 * ecore.cs (EmptyCast): drop child, add Peel method.
17289 2002-11-17 Martin Baulig <martin@ximian.com>
17291 * ecore.cs (EmptyCast.Child): New public property.
17293 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
17294 label resolved to an EmptyCast. Fixes #34162.
17295 (GotoCase.Resolve): Likewise.
17296 (Block.EmitMeta): Likewise.
17298 2002-11-17 Martin Baulig <martin@ximian.com>
17300 * expression.cs (Invocation.BetterConversion): Prefer int over
17301 uint; short over ushort; long over ulong for integer literals.
17302 Use ImplicitConversionExists instead of StandardConversionExists
17303 since we also need to check for user-defined implicit conversions.
17304 Fixes #34165. Added test-173.cs.
17306 2002-11-16 Martin Baulig <martin@ximian.com>
17308 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
17309 with the `true' and `false' literals. Fixes #33151.
17311 2002-11-16 Martin Baulig <martin@ximian.com>
17313 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
17314 October 22nd; don't do the cs1540 check for static members.
17316 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
17317 now using our own filter here and doing the cs1540 check again.
17319 2002-11-16 Martin Baulig <martin@ximian.com>
17321 * support.cs (InternalParameters): Don't crash if we don't have
17322 any fixed parameters. Fixes #33532.
17324 2002-11-16 Martin Baulig <martin@ximian.com>
17326 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
17327 when looking up static methods to make this work on Windows.
17330 2002-11-16 Martin Baulig <martin@ximian.com>
17332 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
17333 a setter rather than using PropertyInfo.CanWrite.
17335 2002-11-15 Nick Drochak <ndrochak@gol.com>
17337 * class.cs: Allow acces to block member by subclasses. Fixes build
17340 2002-11-14 Martin Baulig <martin@ximian.com>
17342 * class.cs (Constructor.Emit): Added the extern/block check.
17345 2002-11-14 Martin Baulig <martin@ximian.com>
17347 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
17348 iteration while looking for indexers, this is needed because the
17349 indexer may have a different name in our base classes. Fixed the
17350 error reporting (no indexers at all, not get accessor, no
17351 overloaded match). Fixes bug #33089.
17352 (IndexerAccess.DoResolveLValue): Likewise.
17354 2002-11-14 Martin Baulig <martin@ximian.com>
17356 * class.cs (PropertyBase.CheckBase): Make this work for multiple
17357 indexers. Fixes the first part of bug #33089.
17358 (MethodSignature.InheritableMemberSignatureCompare): Added support
17361 2002-11-13 Ravi Pratap <ravi@ximian.com>
17363 * attribute.cs (Attribute.Resolve): Catch the
17364 NullReferenceException and report it since it isn't supposed to
17367 2002-11-12 Miguel de Icaza <miguel@ximian.com>
17369 * expression.cs (Binary.EmitBranchable): Also handle the cases for
17370 LogicalOr and LogicalAnd that can benefit from recursively
17371 handling EmitBranchable. The code now should be nice for Paolo.
17373 2002-11-08 Miguel de Icaza <miguel@ximian.com>
17375 * typemanager.cs (LookupType): Added a negative-hit hashtable for
17376 the Type lookups, as we perform quite a number of lookups on
17377 non-Types. This can be removed once we can deterministically tell
17378 whether we have a type or a namespace in advance.
17380 But this might require special hacks from our corlib.
17384 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
17385 and double which avoids a conversion from an integer to a double.
17387 * expression.cs: tiny optimization, avoid calling IsConstant,
17388 because it effectively performs the lookup twice.
17390 2002-11-06 Miguel de Icaza <miguel@ximian.com>
17392 But a bogus return here to keep the semantics of the old code
17393 until the Mono runtime is fixed.
17395 * pending.cs (GetMissingInterfaces): New method used to remove all
17396 the interfaces that are already implemented by our parent
17397 classes from the list of pending methods.
17399 * interface.cs: Add checks for calls after ResolveTypeExpr.
17401 2002-11-05 Miguel de Icaza <miguel@ximian.com>
17403 * class.cs (Class.Emit): Report warning 67: event not used if the
17404 warning level is beyond 3.
17406 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
17407 being a NullLiteral.
17409 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
17412 * class.cs (TypeContainer.GetClassBases): Cover a missing code
17413 path that might fail if a type can not be resolved.
17415 * expression.cs (Binary.Emit): Emit unsigned versions of the
17418 * driver.cs: use error 5.
17420 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
17422 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
17424 2002-11-01 Miguel de Icaza <miguel@ximian.com>
17426 * cs-parser.jay (switch_section): A beautiful patch from Martin
17427 Baulig that fixed 33094.
17429 2002-10-31 Miguel de Icaza <miguel@ximian.com>
17431 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
17432 Check whether the base is abstract and report an error if so.
17434 * expression.cs (IndexerAccess.DoResolveLValue,
17435 IndexerAccess.DoResolve): ditto.
17437 (Invocation.DoResolve): ditto.
17439 (Invocation.FullMethodDesc): Improve the report string.
17441 * statement.cs (Block): Eliminate IsVariableDefined as it is
17442 basically just a wrapper for GetVariableInfo.
17444 * ecore.cs (SimpleName): Use new
17446 * support.cs (ReflectionParamter.ParameterType): We unwrap the
17447 type, as we return the actual parameter ref/unref state on a
17450 2002-10-30 Miguel de Icaza <miguel@ximian.com>
17452 * support.cs: Return proper flags REF/OUT fixing the previous
17455 * expression.cs: Reverted last patch, that was wrong. Is_ref is
17456 not used to mean `ref' but `ref or out' in ParameterReference
17458 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
17459 full type signature instead of calling TypeManger.CSharpName
17462 * support.cs (InternalParameters.ParameterDesc): Do not compare
17463 directly to the modflags, because REF/OUT will actually be bitsets
17466 * delegate.cs (VerifyMethod): Check also the modifiers.
17468 * cs-tokenizer.cs: Fix bug where floating point values with an
17469 exponent where a sign was missing was ignored.
17471 * driver.cs: Allow multiple assemblies to be specified in a single
17474 2002-10-28 Miguel de Icaza <miguel@ximian.com>
17476 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
17477 because identifiers after a parenthesis would end up in this kind
17478 of production, and we needed to desamiguate it for having casts
17481 (UserDefinedType *) xxx
17483 2002-10-24 Miguel de Icaza <miguel@ximian.com>
17485 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
17486 we should set on the Bindingflags.NonPublic, but not turn on
17487 private_ok. private_ok controls whether a Private member is
17488 returned (this is chekced on the filter routine), while the
17489 BindingFlags.NonPublic just controls whether private/protected
17490 will be allowed. This fixes the problem part of the problem of
17491 private properties being allowed to be used in derived classes.
17493 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
17494 so we can call the children DoResolveLValue method (this will
17495 properly signal errors on lvalue assignments to base properties)
17497 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
17498 getter are null, and we have a property info, we know that this
17499 happened because the lookup failed, so we report an error 122 for
17500 protection level violation.
17502 We also silently return if setter and getter are null in the
17503 resolve functions, this condition only happens if we have flagged
17504 the error before. This is the other half of the problem.
17506 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
17507 not have accessibility information, that is why we were returning
17508 true in the filter function in typemanager.cs.
17510 To properly report 122 (property is inaccessible because of its
17511 protection level) correctly, we report this error in ResolveAccess
17512 by failing if both the setter and the getter are lacking (ie, the
17515 DoResolve and DoLResolve have been modified to check for both
17516 setter/getter being null and returning silently, the reason being
17517 that I did not want to put the knowledge about this error in upper
17520 int old = Report.Errors;
17521 x = new PropertyExpr (...);
17522 if (old != Report.Errors)
17527 So the property expr is returned, but it is invalid, so the error
17528 will be flagged during the resolve process.
17530 * class.cs: Remove InheritablePropertySignatureCompare from the
17531 class, as we no longer depend on the property signature to compute
17532 whether it is possible to implement a method or not.
17534 The reason is that calling PropertyInfo.GetGetMethod will return
17535 null (in .NET, in Mono it works, and we should change this), in
17536 cases where the Get Method does not exist in that particular
17541 class X { public virtual int A { get { return 1; } } }
17543 class Z : Y { public override int A { get { return 2; } } }
17545 Would fail in Z because the parent (Y) would not have the property
17546 defined. So we avoid this completely now (because the alternative
17547 fix was ugly and slow), and we now depend exclusively on the
17550 (PropertyBase.CheckBase): Use a method-base mechanism to find our
17551 reference method, instead of using the property.
17553 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
17554 routines are gone now.
17556 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
17557 names, they were incorrectly named.
17559 * cs-tokenizer.cs: Return are more gentle token on failure.
17561 * pending.cs (PendingImplementation.InterfaceMethod): This routine
17562 had an out-of-sync index variable, which caused it to remove from
17563 the list of pending methods the wrong method sometimes.
17565 2002-10-22 Miguel de Icaza <miguel@ximian.com>
17567 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
17568 CanWrite, because those refer to this particular instance of the
17569 property, and do not take into account the fact that we can
17570 override single members of a property.
17572 Constructor requires an EmitContext. The resolution process does
17573 not happen here, but we need to compute the accessors before,
17574 because the resolution does not always happen for properties.
17576 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
17577 subclass, before we did not update this flag, but we did update
17580 (GetAccessors): Drop this routine, as it did not work in the
17581 presence of partially overwritten set/get methods.
17583 Notice that this broke the cs1540 detection, but that will require
17586 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17590 * driver.cs: issue a warning instead of an error if we don't support
17591 debugging for the platform. Also ignore a couple of errors that may
17592 arise when trying to write the symbols. Undo my previous patch.
17594 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17596 * driver.cs: ignore /debug switch except for Unix platforms.
17598 2002-10-23 Nick Drochak <ndrochak@gol.com>
17600 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
17602 2002-10-21 Miguel de Icaza <miguel@ximian.com>
17604 * driver.cs: Do not make mcs-debug conditional, so we do not break
17605 builds that use it.
17607 * statement.cs (UsageVector.MergeChildren): I would like Martin to
17608 review this patch. But basically after all the children variables
17609 have been merged, the value of "Breaks" was not being set to
17610 new_breaks for Switch blocks. I think that it should be set after
17611 it has executed. Currently I set this to the value of new_breaks,
17612 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
17613 conservative, but I do not understand this code very well.
17615 I did not break anything in the build, so that is good ;-)
17617 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
17619 2002-10-20 Mark Crichton <crichton@gimp.org>
17621 * cfold.cs: Fixed compile blocker. Really fixed it this time.
17623 2002-10-20 Nick Drochak <ndrochak@gol.com>
17625 * cfold.cs: Fixed compile blocker.
17627 2002-10-20 Miguel de Icaza <miguel@ximian.com>
17629 * driver.cs: I was chekcing the key, not the file.
17631 2002-10-19 Ravi Pratap <ravi@ximian.com>
17633 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
17634 message that we were generating - we just need to silently return
17637 2002-10-19 Miguel de Icaza <miguel@ximian.com>
17639 * class.cs (Event.Define): Change my previous commit, as this
17640 breaks the debugger. This is a temporary hack, as it seems like
17641 the compiler is generating events incorrectly to begin with.
17643 * expression.cs (Binary.ResolveOperator): Added support for
17644 "U operator - (E x, E y)"
17646 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
17649 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
17650 init-only variables, but this path did not take into account that
17651 there might be also instance readonly variables. Correct this
17654 This fixes bug 32253
17656 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
17659 * driver.cs: Change the extension for modules to `netmodule'
17661 * cs-parser.jay: Improved slightly the location tracking for
17662 the debugger symbols.
17664 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
17665 modifiers that were specified instead of the hardcoded value
17666 (FamAndAssem). This was basically ignoring the static modifier,
17667 and others. Fixes 32429.
17669 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
17670 fixed a bug in the process (32476)
17672 * expression.cs (ArrayAccess.EmitAssign): Patch from
17673 hwang_rob@yahoo.ca that fixes bug 31834.3
17675 2002-10-18 Miguel de Icaza <miguel@ximian.com>
17677 * driver.cs: Make the module extension .netmodule.
17679 2002-10-16 Miguel de Icaza <miguel@ximian.com>
17681 * driver.cs: Report an error if the resource file is not found
17682 instead of crashing.
17684 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
17685 false, like Emit does.
17687 2002-10-16 Nick Drochak <ndrochak@gol.com>
17689 * typemanager.cs: Remove unused private member. Also reported mcs
17690 bug to report this as a warning like csc.
17692 2002-10-15 Martin Baulig <martin@gnome.org>
17694 * statement.cs (Statement.Emit): Made this a virtual method; emits
17695 the line number info and calls DoEmit().
17696 (Statement.DoEmit): New protected abstract method, formerly knows
17697 as Statement.Emit().
17699 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
17701 2002-10-11 Miguel de Icaza <miguel@ximian.com>
17703 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
17704 have fixed a remaining problem: not every AddXXXX was adding a
17705 fully qualified name.
17707 Now everyone registers a fully qualified name in the DeclSpace as
17708 being defined instead of the partial name.
17710 Downsides: we are slower than we need to be due to the excess
17711 copies and the names being registered this way.
17713 The reason for this is that we currently depend (on the corlib
17714 bootstrap for instance) that types are fully qualified, because
17715 we dump all the types in the namespace, and we should really have
17716 types inserted into the proper namespace, so we can only store the
17717 basenames in the defined_names array.
17719 2002-10-10 Martin Baulig <martin@gnome.org>
17721 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
17722 from bug #31834, see the bug report for a testcase which is
17725 2002-10-10 Martin Baulig <martin@gnome.org>
17727 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
17728 flow analysis code for this.
17730 * statement.cs (Do, While, For): Tell the flow analysis code about
17732 (FlowBranching.UsageVector): Added support for infinite loops.
17733 (Block.Resolve): Moved the dead code elimination here and use flow
17736 2002-10-09 Miguel de Icaza <miguel@ximian.com>
17738 * class.cs (Field.Define): Catch cycles on struct type
17741 * typemanager.cs (IsUnmanagedtype): Do not recursively check
17742 fields if the fields are static. We only need to check instance
17745 * expression.cs (As.DoResolve): Test for reference type.
17747 * statement.cs (Using.ResolveExpression): Use
17748 ConvertImplicitRequired, not ConvertImplicit which reports an
17750 (Using.ResolveLocalVariableDecls): ditto.
17752 * expression.cs (Binary.ResolveOperator): Report errors in a few
17753 places where we had to.
17755 * typemanager.cs (IsUnmanagedtype): Finish implementation.
17757 2002-10-08 Miguel de Icaza <miguel@ximian.com>
17759 * expression.cs: Use StoreFromPtr instead of extracting the type
17760 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
17762 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
17763 an enumeration value to a System.Enum, but System.Enum is not a
17764 value type, but an class type, so we need to box.
17766 (Expression.ConvertExplicit): One codepath could return
17767 errors but not flag them. Fix this. Fixes #31853
17769 * parameter.cs (Resolve): Do not allow void as a parameter type.
17771 2002-10-06 Martin Baulig <martin@gnome.org>
17773 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
17774 if it's a class type and not a struct. Fixes #31815.
17776 2002-10-06 Martin Baulig <martin@gnome.org>
17778 * statement.cs: Reworked the flow analysis code a bit to make it
17779 usable for dead code elimination.
17781 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17783 * cs-parser.jay: allow empty source files. Fixes bug #31781.
17785 2002-10-04 Miguel de Icaza <miguel@ximian.com>
17787 * expression.cs (ComposedCast.DoResolveType): A quick workaround
17788 to fix the test 165, will investigate deeper.
17790 2002-10-04 Martin Baulig <martin@gnome.org>
17792 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
17793 finally blocks actually work.
17794 (Try.Resolve): We don't need to create a sibling for `finally' if
17795 there is no finally block.
17797 2002-10-04 Martin Baulig <martin@gnome.org>
17799 * class.cs (Constructor.Define): The default accessibility for a
17800 non-default constructor is private, not public.
17802 2002-10-04 Miguel de Icaza <miguel@ximian.com>
17804 * class.cs (Constructor): Make AllowedModifiers public, add
17807 * cs-parser.jay: Perform the modifiers test here, as the
17808 constructor for the Constructor class usually receives a zero
17809 because of the way we create it (first we create, later we
17810 customize, and we were never checking the modifiers).
17812 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
17813 is a version of LookupTypeReflection that includes the type-name
17814 cache. This can be used as a fast path for functions that know
17815 the fully qualified name and are only calling into *.GetType() to
17816 obtain a composed type.
17818 This is also used by TypeManager.LookupType during its type
17821 (LookupType): We now also track the real type name, as sometimes
17822 we can get a quey for the real type name from things like
17823 ComposedCast. This fixes bug 31422.
17825 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
17826 complete type fullname, it does not have to go through the type
17827 resolution system to obtain the composed version of the type (for
17828 obtaining arrays or pointers).
17830 (Conditional.Emit): Use the EmitBoolExpression to
17831 generate nicer code, as requested by Paolo.
17833 (ArrayCreation.CheckIndices): Use the patch from
17834 hwang_rob@yahoo.ca to validate the array initializers.
17836 2002-10-03 Miguel de Icaza <miguel@ximian.com>
17838 * class.cs (ConstructorInitializer.Emit): simplify code by using
17839 Invocation.EmitCall, and at the same time, fix the bugs in calling
17840 parent constructors that took variable arguments.
17842 * ecore.cs (Expression.ConvertNumericExplicit,
17843 Expression.ImplicitNumericConversion): Remove the code that
17844 manually wrapped decimal (InternalTypeConstructor call is now gone
17847 * expression.cs (Cast.TryReduce): Also handle decimal types when
17848 trying to perform a constant fold on the type.
17850 * typemanager.cs (IsUnmanagedtype): Partially implemented.
17852 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
17853 that only turned off an error report, and did nothing else.
17855 2002-10-02 Miguel de Icaza <miguel@ximian.com>
17857 * driver.cs: Handle and ignore /fullpaths
17859 2002-10-01 Miguel de Icaza <miguel@ximian.com>
17861 * expression.cs (Binary.ResolveOperator): Catch the case where
17862 DoNumericPromotions returns true,
17864 (Binary.DoNumericPromotions): Simplify the code, and the tests.
17866 2002-09-27 Miguel de Icaza <miguel@ximian.com>
17868 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
17871 2002-09-26 Miguel de Icaza <miguel@ximian.com>
17873 * ecore.cs (ConvertNumericExplicit): It is not enough that the
17874 conversion exists, but it is also required that the conversion be
17875 performed. This manifested in "(Type64Enum) 2".
17877 * class.cs (TypeManager.AddMethod): The fix is not to change
17878 AddEnum, because that one was using a fully qualified name (every
17879 DeclSpace derivative does), but to change the AddMethod routine
17880 that was using an un-namespaced name. This now correctly reports
17881 the duplicated name.
17883 Revert patch until I can properly fix it. The issue
17884 is that we have a shared Type space across all namespaces
17885 currently, which is wrong.
17887 Options include making the Namespace a DeclSpace, and merge
17888 current_namespace/current_container in the parser.
17890 2002-09-25 Miguel de Icaza <miguel@ximian.com>
17892 * cs-parser.jay: Improve error reporting when we get a different
17893 kind of expression in local_variable_type and
17894 local_variable_pointer_type.
17896 Propagate this to avoid missleading errors being reported.
17898 * ecore.cs (ImplicitReferenceConversion): treat
17899 TypeManager.value_type as a target just like object_type. As
17904 Is valid, and needs to result in the int 1 being boxed before it
17905 is assigned to the value type v.
17907 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
17908 to validate the enumeration name.
17910 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
17911 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
17912 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
17914 * ecore.cs (TryImplicitIntConversion): When doing an
17915 implicit-enumeration-conversion, check if the type is 64-bits and
17916 perform a conversion before passing to EnumConstant.
17918 2002-09-23 Miguel de Icaza <miguel@ximian.com>
17920 * decl.cs (Error_AmbiguousTypeReference); New routine used to
17921 report ambiguous type references. Unlike the MS version, we
17922 report what the ambiguity is. Innovation at work ;-)
17924 (DeclSpace.FindType): Require a location argument to
17925 display when we display an ambiguous error.
17927 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
17929 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
17931 * expression.cs (EmitDynamicInitializers): Apply patch from
17932 hwang_rob@yahoo.ca that fixes the order in which we emit our
17935 2002-09-21 Martin Baulig <martin@gnome.org>
17937 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
17938 delegate takes no arguments.
17940 2002-09-20 Miguel de Icaza <miguel@ximian.com>
17942 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
17945 * expression.cs: Extract the underlying type.
17947 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
17949 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
17951 2002-09-19 Miguel de Icaza <miguel@ximian.com>
17953 * class.cs (TypeContainer.DefineType): We can not use the nice
17954 PackingSize with the size set to 1 DefineType method, because it
17955 will not allow us to define the interfaces that the struct
17958 This completes the fixing of bug 27287
17960 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
17961 means also structs. This fixes part of the problem.
17962 (Expresion.ImplicitReferenceConversionExists): ditto.
17964 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
17965 error if there were no errors reported during the type lookup
17966 process, to avoid duplicates or redundant errors. Without this
17967 you would get an ambiguous errors plus a type not found. We have
17968 beaten the user enough with the first error.
17970 (DeclSparce.FindType): Emit a warning if we have an ambiguous
17973 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
17974 during the resolution process, stop the lookup, this avoids
17975 repeated error reports (same error twice).
17977 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
17979 * typemanager.cs (LookupType): Redo the type lookup code to match
17980 the needs of System.Reflection.
17982 The issue is that System.Reflection requires references to nested
17983 types to begin with a "+" sign instead of a dot. So toplevel
17984 types look like: "NameSpace.TopLevelClass", and nested ones look
17985 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
17988 2002-09-19 Martin Baulig <martin@gnome.org>
17990 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
17991 says that a method always returns or always throws an exception,
17992 don't report the CS0161.
17994 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
17995 set `Returns = new_returns'.
17997 2002-09-19 Martin Baulig <martin@gnome.org>
17999 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
18000 to an enum constant, check for a CS0176.
18002 2002-09-18 Miguel de Icaza <miguel@ximian.com>
18004 * class.cs (TypeContainer.CheckPairedOperators): Now we check
18005 for operators that must be in pairs and report errors.
18007 * ecore.cs (SimpleName.DoResolveType): During the initial type
18008 resolution process, when we define types recursively, we must
18009 check first for types in our current scope before we perform
18010 lookups in the enclosing scopes.
18012 * expression.cs (MakeByteBlob): Handle Decimal blobs.
18014 (Invocation.VerifyArgumentsCompat): Call
18015 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
18016 I thought we were supposed to always call this, but there are a
18017 few places in the code where we dont do it.
18019 2002-09-17 Miguel de Icaza <miguel@ximian.com>
18021 * driver.cs: Add support in -linkres and -resource to specify the
18022 name of the identifier.
18024 2002-09-16 Miguel de Icaza <miguel@ximian.com>
18026 * ecore.cs (StandardConversionExists): Sync with the conversion
18027 code: allow anything-* to void* conversions.
18029 (FindMostSpecificSource): Use an Expression argument
18030 instead of a Type, because we might be handed over a Literal which
18031 gets a few more implicit conversions that plain types do not. So
18032 this information was being lost.
18034 Also, we drop the temporary type-holder expression when not
18037 2002-09-17 Martin Baulig <martin@gnome.org>
18039 * class.cs (PropertyBase.CheckBase): Don't check the base class if
18040 this is an explicit interface implementation.
18042 2002-09-17 Martin Baulig <martin@gnome.org>
18044 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
18045 different `IndexerName' attributes.
18047 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
18048 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
18049 virtual CommonResolve().
18051 2002-09-16 Miguel de Icaza <miguel@ximian.com>
18053 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
18054 and convert that to the UnderlyingType.
18056 * statement.cs (Foreach.Resolve): Indexers are just like variables
18057 or PropertyAccesses.
18059 * cs-tokenizer.cs (consume_string): Track line numbers and columns
18060 inside quoted strings, we were not doing this before.
18062 2002-09-16 Martin Baulig <martin@gnome.org>
18064 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
18065 resolve it. This is needed for the definite assignment check of the
18066 instance expression, fixes bug #29846.
18067 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
18069 2002-09-16 Nick Drochak <ndrochak@gol.com>
18071 * parameter.cs: Fix compile error. Cannot reference static member
18072 from an instance object. Is this an mcs bug?
18074 2002-09-14 Martin Baulig <martin@gnome.org>
18076 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
18077 multiple times. Fixes bug #30295, added test-166.cs.
18079 2002-09-14 Martin Baulig <martin@gnome.org>
18081 * statement.cs (Block.Emit): Don't emit unreachable code.
18082 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
18083 `break' statements.
18084 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
18086 2002-09-14 Martin Baulig <martin@gnome.org>
18088 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
18091 2002-09-14 Martin Baulig <martin@gnome.org>
18093 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
18094 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
18095 be false on the ms runtime.
18097 2002-09-13 Martin Baulig <martin@gnome.org>
18099 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
18100 the CS0038 error message.
18102 2002-09-12 Miguel de Icaza <miguel@ximian.com>
18104 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
18105 constant inside, return it.
18107 2002-09-12 Martin Baulig <martin@gnome.org>
18109 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
18110 implicit conversion can be done between enum types.
18112 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
18113 check whether an implicit conversion to the current enum's UnderlyingType
18114 exists and report an error if not.
18116 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
18117 without debugging support.
18119 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
18120 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
18122 2002-09-12 Martin Baulig <martin@gnome.org>
18124 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
18126 * ecore.cs (IMemberExpr.DeclaringType): New property.
18127 (SimpleName.SimpleNameResolve): Check whether we're accessing a
18128 nonstatic member of an outer type (CS0038).
18130 2002-09-11 Miguel de Icaza <miguel@ximian.com>
18132 * driver.cs: Activate the using-error detector at warning level
18133 4 (at least for MS-compatible APIs).
18135 * namespace.cs (VerifyUsing): Small buglett fix.
18137 * pending.cs (PendingImplementation): pass the container pointer.
18139 * interface.cs (GetMethods): Allow for recursive definition. Long
18140 term, I would like to move every type to support recursive
18141 definitions, not the current ordering mechanism that we have right
18144 The situation is this: Attributes are handled before interfaces,
18145 so we can apply attributes to interfaces. But some attributes
18146 implement interfaces, we will now handle the simple cases
18147 (recursive definitions will just get an error).
18149 * parameter.cs: Only invalidate types at the end if we fail to
18152 2002-09-09 Martin Baulig <martin@gnome.org>
18154 * ecore.cs (PropertyExpr.Emit): Also check for
18155 TypeManager.system_int_array_get_length so this'll also work when
18156 compiling corlib. Fixes #30003.
18158 2002-09-09 Martin Baulig <martin@gnome.org>
18160 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
18161 and throw an exception if we can't get the type's size. Fixed #30040,
18164 2002-09-09 Martin Baulig <martin@gnome.org>
18166 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
18168 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
18169 context. Fixes bug #30027.
18171 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
18172 virtual functions. Fixes bug #30043, added test-164.cs.
18174 2002-09-08 Ravi Pratap <ravi@ximian.com>
18176 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
18178 2002-09-08 Nick Drochak <ndrochak@gol.com>
18180 * driver.cs: Use an object to get the windows codepage since it's not a
18183 2002-09-08 Miguel de Icaza <miguel@ximian.com>
18185 * statement.cs (For.Emit): for infinite loops (test == null)
18186 return whether there is a break inside, not always "true".
18188 * namespace.cs (UsingEntry): New struct to hold the name of the
18189 using definition, the location where it is defined, and whether it
18190 has been used in a successful type lookup.
18192 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
18197 2002-09-06 Ravi Pratap <ravi@ximian.com>
18199 * attribute.cs : Fix incorrect code which relied on catching
18200 a NullReferenceException to detect a null being passed in
18201 where an object was expected.
18203 2002-09-06 Miguel de Icaza <miguel@ximian.com>
18205 * statement.cs (Try): flag the catch variable as assigned
18207 * expression.cs (Cast): Simplified by using ResolveType instead of
18208 manually resolving.
18210 * statement.cs (Catch): Fix bug by using ResolveType.
18212 2002-09-06 Ravi Pratap <ravi@ximian.com>
18214 * expression.cs (BetterConversion): Special case for when we have
18215 a NullLiteral as the argument and we have to choose between string
18216 and object types - we choose string the way csc does.
18218 * attribute.cs (Attribute.Resolve): Catch the
18219 NullReferenceException and report error #182 since the Mono
18220 runtime no more has the bug and having this exception raised means
18221 we tried to select a constructor which takes an object and is
18224 2002-09-05 Ravi Pratap <ravi@ximian.com>
18226 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
18227 message (1502, 1503) when we can't locate a method after overload
18228 resolution. This is much more informative and closes the bug
18231 * interface.cs (PopulateMethod): Return if there are no argument
18232 types. Fixes a NullReferenceException bug.
18234 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
18235 expressions too. Previously we were checking only in one place for
18236 positional arguments leaving out named arguments.
18238 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
18239 type to the enum type is not allowed. Remove code corresponding to
18242 (ConvertNumericExplicit): Allow explicit conversions from
18243 the underlying type to enum type. This precisely follows the spec
18244 and closes a bug filed by Gonzalo.
18246 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18249 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
18251 2002-09-03 Miguel de Icaza <miguel@ximian.com>
18253 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
18254 it was important that we stored the right value after the
18255 reduction in `converted'.
18257 2002-09-04 Martin Baulig <martin@gnome.org>
18259 * location.cs (Location.SymbolDocument): Use full pathnames for the
18262 2002-08-30 Miguel de Icaza <miguel@ximian.com>
18264 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
18265 of the expression resolve mechanism, because that will catch the
18266 SimpleName error failures.
18268 (Conditional): If we can not resolve the
18269 expression, return, do not crash.
18271 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18274 (location): display token name instead of its number.
18276 2002-08-28 Martin Baulig <martin@gnome.org>
18278 * expression.cs (Binary.ResolveOperator): Don't silently return
18279 but return an error if an operator cannot be applied between two
18282 2002-08-28 Martin Baulig <martin@gnome.org>
18284 * class.cs (Constructor.Define): Set the permission attributes
18285 correctly instead of making all constructors public.
18287 2002-08-28 Martin Baulig <martin@gnome.org>
18289 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
18290 for private members before reporting a CS0103; if we find anything,
18293 2002-08-28 Martin Baulig <martin@gnome.org>
18295 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
18296 to check whether `closure_start_type == closure_invocation_type',
18297 we also need to check whether `m.DeclaringType == closure_invocation_type'
18298 before bypassing the permission checks. We might be accessing
18299 protected/private members from the base class.
18300 (TypeManager.RealMemberLookup): Only set private_ok if private
18301 members were requested via BindingFlags.NonPublic.
18303 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
18305 * expression.cs (MemberAccess.ResolveMemberAccess): Set
18306 MethodGroupExpr.IsExplicitImpl if appropriate.
18307 (Invocation.DoResolve): Don't report the CS0120 for explicit
18308 interface implementations.
18310 2002-08-27 Martin Baulig <martin@gnome.org>
18312 * expression.cs (Invocation.DoResolve): If this is a static
18313 method and we don't have an InstanceExpression, we must report
18316 2002-08-25 Martin Baulig <martin@gnome.org>
18318 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
18319 `==' between a valuetype and an object.
18321 2002-08-25 Miguel de Icaza <miguel@ximian.com>
18323 * ecore.cs (TypeExpr): Provide a ToString method.
18325 2002-08-24 Martin Baulig <martin@gnome.org>
18327 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
18328 now called proggie.dbg and it's a binary file.
18330 2002-08-23 Martin Baulig <martin@gnome.org>
18332 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
18334 2002-08-23 Martin Baulig <martin@gnome.org>
18336 * struct.cs (MyStructInfo.ctor): Make this work with empty
18337 structs; it's not allowed to use foreach() on null.
18339 2002-08-23 Martin Baulig <martin@gnome.org>
18341 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
18342 writer the full pathname of the generated assembly.
18344 2002-08-23 Martin Baulig <martin@gnome.org>
18346 * statements.cs (FlowBranching.UsageVector.MergeChildren):
18347 A `finally' block never returns or breaks; improved handling of
18350 2002-08-23 Martin Baulig <martin@gnome.org>
18352 * statement.cs (Throw.Resolve): Allow `throw null'.
18354 2002-08-23 Martin Baulig <martin@gnome.org>
18356 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
18357 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
18358 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
18359 MemberLookup would return a wrong event if this is an explicit
18360 interface implementation and the class has an event with the same
18363 2002-08-23 Martin Baulig <martin@gnome.org>
18365 * statement.cs (Block.AddChildVariableNames): New public method.
18366 (Block.AddChildVariableName): Likewise.
18367 (Block.IsVariableNameUsedInChildBlock): Likewise.
18368 (Block.AddVariable): Check whether a variable name has already
18369 been used in a child block.
18371 * cs-parser.jay (declare_local_variables): Mark all variable names
18372 from the current block as being used in a child block in the
18375 2002-08-23 Martin Baulig <martin@gnome.org>
18377 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
18378 find the symbol writer.
18380 * driver.cs: csc also allows the arguments to /define being
18381 separated by commas, not only by semicolons.
18383 2002-08-23 Martin Baulig <martin@gnome.org>
18385 * interface.cs (Interface.GetMembers): Added static check for events.
18387 2002-08-15 Martin Baulig <martin@gnome.org>
18389 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
18390 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
18392 * ecore.cs (Expression.MemberLookup): Added documentation and explained
18393 why the MethodData.EmitDestructor() change was necessary.
18395 2002-08-20 Martin Baulig <martin@gnome.org>
18397 * class.cs (TypeContainer.FindMembers): Added static check for events.
18399 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
18401 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
18402 use Type.GetEvents(), not Type.FindMembers().
18404 2002-08-20 Martin Baulig <martin@gnome.org>
18406 * decl.cs (MemberCache): Added a special method cache which will
18407 be used for method-only searched. This ensures that a method
18408 search will return a MethodInfo with the correct ReflectedType for
18411 2002-08-20 Martin Baulig <martin@gnome.org>
18413 * decl.cs (DeclSpace.FindMembers): Made this public.
18415 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18417 * delegate.cs: fixed build on windows.
18418 [FIXME: Filed as bug #29150: MCS must report these errors.]
18420 2002-08-19 Ravi Pratap <ravi@ximian.com>
18422 * ecore.cs (StandardConversionExists): Return a false
18423 if we are trying to convert the void type to anything else
18424 since that is not allowed.
18426 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
18427 we flag error 70 in the event an event is trying to be accessed
18428 directly from outside the declaring type.
18430 2002-08-20 Martin Baulig <martin@gnome.org>
18432 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
18433 MemberCache from typemanager.cs to decl.cs.
18435 2002-08-19 Martin Baulig <martin@gnome.org>
18437 * class.cs (TypeContainer): Implement IMemberContainer.
18438 (TypeContainer.DefineMembers): Create the MemberCache.
18439 (TypeContainer.FindMembers): Do better BindingFlags checking; only
18440 return public members if BindingFlags.Public was given, check
18441 whether members are static.
18443 2002-08-16 Martin Baulig <martin@gnome.org>
18445 * decl.cs (DeclSpace.Define): Splitted this in Define and
18446 DefineMembers. DefineMembers is called first and initializes the
18449 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
18450 DefineMembers() on all our DeclSpaces.
18452 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
18453 but call DefineMembers() on all nested interfaces. We call their
18454 Define() in our new Define() function.
18456 * interface.cs (Interface): Implement IMemberContainer.
18457 (Interface.Define): Moved all code except the attribute stuf to
18459 (Interface.DefineMembers): Initialize the member cache.
18461 * typemanager.cs (IMemberFinder): Removed this interface, we don't
18462 need this anymore since we can use MemberCache.FindMembers directly.
18464 2002-08-19 Martin Baulig <martin@gnome.org>
18466 * typemanager.cs (MemberCache): When creating the cache for an
18467 interface type, add all inherited members.
18468 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
18469 to `out bool used_cache' and documented it.
18470 (TypeManager.MemberLookup): If we already used the cache in the first
18471 iteration, we don't need to do the interfaces check.
18473 2002-08-19 Martin Baulig <martin@gnome.org>
18475 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
18476 here from IMemberFinder and don't implement this interface anymore.
18477 (DeclSpace.MemberCache): Moved here from IMemberFinder.
18479 * typemanager.cs (IMemberFinder): This interface is now only used by
18480 classes which actually support the member cache.
18481 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
18482 since we only put DeclSpaces into this Hashtable.
18483 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
18484 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
18486 2002-08-16 Martin Baulig <martin@gnome.org>
18488 * typemanager.cs (ICachingMemberFinder): Removed.
18489 (IMemberFinder.MemberCache): New property.
18490 (TypeManager.FindMembers): Merged this with RealFindMembers().
18491 This function will never be called from TypeManager.MemberLookup()
18492 so we can't use the cache here, just the IMemberFinder.
18493 (TypeManager.MemberLookup_FindMembers): Check whether the
18494 IMemberFinder has a MemberCache and call the cache's FindMembers
18496 (MemberCache): Rewrote larger parts of this yet another time and
18497 cleaned it up a bit.
18499 2002-08-15 Miguel de Icaza <miguel@ximian.com>
18501 * driver.cs (LoadArgs): Support quoting.
18503 (Usage): Show the CSC-like command line arguments.
18505 Improved a few error messages.
18507 2002-08-15 Martin Baulig <martin@gnome.org>
18509 * typemanager.cs (IMemberContainer.Type): New property.
18510 (IMemberContainer.IsInterface): New property.
18512 The following changes are conditional to BROKEN_RUNTIME, which is
18513 defined at the top of the file.
18515 * typemanager.cs (MemberCache.MemberCache): Don't add the base
18516 class'es members, but add all members from TypeHandle.ObjectType
18517 if we're an interface.
18518 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
18519 is the current type.
18520 (MemberCache.CacheEntry.Container): Removed this field.
18521 (TypeHandle.GetMembers): Include inherited members.
18523 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18525 * typemanager.cs: fixed compilation and added a comment on a field that
18528 2002-08-15 Martin Baulig <martin@gnome.org>
18530 * class.cs (ConstructorInitializer.Resolve): In the
18531 Expression.MemberLookup call, use the queried_type as
18534 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
18535 declared' attribute, it's always true.
18536 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
18537 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
18538 temporary wrapper for FindMembers which tells MemberLookup whether
18539 members from the base classes are included in the return value.
18540 This will go away soon.
18541 (TypeManager.MemberLookup): Use this temporary hack here; once the
18542 new MemberCache is completed, we don't need to do the DeclaredOnly
18543 looping here anymore since the MemberCache will take care of this.
18544 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
18545 (MemberCache): When creating the MemberCache for a class, get
18546 members from the current class and all its base classes.
18547 (MemberCache.CacheEntry.Container): New field. This is a
18548 temporary hack until the Mono runtime is fixed to distinguish
18549 between ReflectedType and DeclaringType. It allows us to use MCS
18550 with both the MS runtime and the unfixed Mono runtime without
18551 problems and without accecting performance.
18552 (MemberCache.SearchMembers): The DeclaredOnly looping from
18553 TypeManager.MemberLookup is now done here.
18555 2002-08-14 Martin Baulig <martin@gnome.org>
18557 * statement.cs (MyStructInfo.MyStructInfo): Don't call
18558 Type.GetFields on dynamic types but get the fields from the
18559 corresponding TypeContainer.
18560 (MyStructInfo.GetStructInfo): Added check for enum types.
18562 * typemanager.cs (MemberList.IsSynchronized): Implemented.
18563 (MemberList.SyncRoot): Implemented.
18564 (TypeManager.FilterWithClosure): No need to check permissions if
18565 closure_start_type == closure_invocation_type, don't crash if
18566 closure_invocation_type is null.
18568 2002-08-13 Martin Baulig <martin@gnome.org>
18570 Rewrote TypeContainer.FindMembers to use a member cache. This
18571 gives us a speed increase of about 35% for the self-hosting MCS
18572 build and of about 15-20% for the class libs (both on GNU/Linux).
18574 * report.cs (Timer): New class to get enhanced profiling. This
18575 whole class is "TIMER" conditional since it remarkably slows down
18578 * class.cs (MemberList): New class. This is an IList wrapper
18579 which we're now using instead of passing MemberInfo[]'s around to
18580 avoid copying this array unnecessarily.
18581 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
18582 (ICachingMemberFinder, IMemberContainer): New interface.
18583 (TypeManager.FilterWithClosure): If `criteria' is null, the name
18584 has already been checked, otherwise use it for the name comparision.
18585 (TypeManager.FindMembers): Renamed to RealMemberFinder and
18586 provided wrapper which tries to use ICachingMemberFinder.FindMembers
18587 if possible. Returns a MemberList, not a MemberInfo [].
18588 (TypeHandle): New class, implements IMemberContainer. We create
18589 one instance of this class per type, it contains a MemberCache
18590 which is used to do the member lookups.
18591 (MemberCache): New class. Each instance of this class contains
18592 all members of a type and a name-based hash table.
18593 (MemberCache.FindMembers): This is our new member lookup
18594 function. First, it looks up all members of the requested name in
18595 the hash table. Then, it walks this list and sorts out all
18596 applicable members and returns them.
18598 2002-08-13 Martin Baulig <martin@gnome.org>
18600 In addition to a nice code cleanup, this gives us a performance
18601 increase of about 1.4% on GNU/Linux - not much, but it's already
18602 half a second for the self-hosting MCS compilation.
18604 * typemanager.cs (IMemberFinder): New interface. It is used by
18605 TypeManager.FindMembers to call FindMembers on a TypeContainer,
18606 Enum, Delegate or Interface.
18607 (TypeManager.finder_to_member_finder): New PtrHashtable.
18608 (TypeManager.finder_to_container): Removed.
18609 (TypeManager.finder_to_delegate): Removed.
18610 (TypeManager.finder_to_interface): Removed.
18611 (TypeManager.finder_to_enum): Removed.
18613 * interface.cs (Interface): Implement IMemberFinder.
18615 * delegate.cs (Delegate): Implement IMemberFinder.
18617 * enum.cs (Enum): Implement IMemberFinder.
18619 * class.cs (TypeContainer): Implement IMemberFinder.
18621 2002-08-12 Martin Baulig <martin@gnome.org>
18623 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
18625 2002-08-12 Martin Baulig <martin@gnome.org>
18627 * ecore.cs (ITypeExpression): New interface for expressions which
18629 (TypeExpression): Renamed to TypeLookupExpression.
18630 (Expression.DoResolve): If we're doing a types-only lookup, the
18631 expression must implement the ITypeExpression interface and we
18632 call DoResolveType() on it.
18633 (SimpleName): Implement the new ITypeExpression interface.
18634 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
18635 hack, the situation that we're only looking up types can't happen
18636 anymore when this method is called. Moved the type lookup code to
18637 DoResolveType() and call it.
18638 (SimpleName.DoResolveType): This ITypeExpression interface method
18639 is now doing the types-only lookup.
18640 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
18641 (ResolveFlags): Added MaskExprClass.
18643 * expression.cs (MemberAccess): Implement the ITypeExpression
18645 (MemberAccess.DoResolve): Added support for a types-only lookup
18646 when we're called via ITypeExpression.DoResolveType().
18647 (ComposedCast): Implement the ITypeExpression interface.
18649 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
18650 Expression.Resolve() with ResolveFlags.Type instead.
18652 2002-08-12 Martin Baulig <martin@gnome.org>
18654 * interface.cs (Interface.Define): Apply attributes.
18656 * attribute.cs (Attribute.ApplyAttributes): Added support for
18657 interface attributes.
18659 2002-08-11 Martin Baulig <martin@gnome.org>
18661 * statement.cs (Block.Emit): Only check the "this" variable if we
18662 do not always throw an exception.
18664 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
18665 whether the property has a set accessor.
18667 2002-08-11 Martin Baulig <martin@gnome.org>
18669 Added control flow analysis support for structs.
18671 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
18672 with control flow analysis turned off.
18673 (IVariable): New interface.
18674 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
18675 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
18676 (FieldExpr.DoResolve): Resolve the instance expression with flow
18677 analysis turned off and do the definite assignment check after the
18678 resolving when we know what the expression will resolve to.
18680 * expression.cs (LocalVariableReference, ParameterReference):
18681 Implement the new IVariable interface, only call the flow analysis
18682 code if ec.DoFlowAnalysis is true.
18683 (This): Added constructor which takes a Block argument. Implement
18684 the new IVariable interface.
18685 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
18686 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
18687 This does the definite assignment checks for struct members.
18689 * class.cs (Constructor.Emit): If this is a non-static `struct'
18690 constructor which doesn't have any initializer, call
18691 Block.AddThisVariable() to tell the flow analysis code that all
18692 struct elements must be initialized before control returns from
18695 * statement.cs (MyStructInfo): New public class.
18696 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
18697 argument to this indexer. If non-zero, check an individual struct
18698 member, not the whole struct.
18699 (FlowBranching.CheckOutParameters): Check struct members.
18700 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
18701 overloaded versions of these methods which take an additional
18702 `int field_idx' argument to check struct members.
18703 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
18704 overloaded versions of these methods which take an additional
18705 `string field_name' argument to check struct member.s
18706 (VariableInfo): Implement the IVariable interface.
18707 (VariableInfo.StructInfo): New public property. Returns the
18708 MyStructInfo instance of the variable if it's a struct or null.
18709 (Block.AddThisVariable): New public method. This is called from
18710 Constructor.Emit() for non-static `struct' constructor which do
18711 not have any initializer. It creates a special variable for the
18712 "this" instance variable which will be checked by the flow
18713 analysis code to ensure that all of the struct's fields are
18714 initialized before control returns from the constructor.
18715 (UsageVector): Added support for struct members. If a
18716 variable/parameter is a struct with N members, we reserve a slot
18717 in the usage vector for each member. A struct is considered fully
18718 initialized if either the struct itself (slot 0) or all its
18719 members are initialized.
18721 2002-08-08 Martin Baulig <martin@gnome.org>
18723 * driver.cs (Driver.MainDriver): Only report an error CS5001
18724 if there were no compilation errors.
18726 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
18727 `UnsafeContext' property to determine whether the parent is in
18728 unsafe context rather than checking the parent's ModFlags:
18729 classes nested in an unsafe class are unsafe as well.
18731 2002-08-08 Martin Baulig <martin@gnome.org>
18733 * statement.cs (UsageVector.MergeChildren): Distinguish between
18734 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
18735 we return. Added test17() and test18() to test-154.cs.
18737 2002-08-08 Martin Baulig <martin@gnome.org>
18739 * typemanager.cs (TypeManager.FilterWithClosure): If we have
18740 Family access, make sure the invoking type isn't a subclass of the
18741 queried type (that'd be a CS1540).
18743 * ecore.cs (Expression.MemberLookup): Added overloaded version of
18744 this method which takes an additional `Type invocation_type'.
18746 * expression.cs (BaseAccess.DoResolve): Use the base type as
18747 invocation and query type.
18748 (MemberAccess.DoResolve): If the lookup failed and we're about to
18749 report a CS0122, try a lookup with the ec.ContainerType - if this
18750 succeeds, we must report a CS1540.
18752 2002-08-08 Martin Baulig <martin@gnome.org>
18754 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
18755 (MethodGroupExpr): Implement the IMemberExpr interface.
18757 * expression (MemberAccess.ResolveMemberAccess): No need to have
18758 any special code for MethodGroupExprs anymore, they're now
18761 2002-08-08 Martin Baulig <martin@gnome.org>
18763 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
18764 Family, FamANDAssem and FamORAssem permissions.
18765 (TypeManager.IsSubclassOrNestedChildOf): New public method.
18767 2002-08-08 Martin Baulig <martin@gnome.org>
18769 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
18770 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
18773 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
18775 * driver.cs: implemented /resource option to embed managed resources.
18777 2002-08-07 Martin Baulig <martin@gnome.org>
18779 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
18780 (FieldBase.HasFieldInitializer): New public property.
18781 (FieldBase.GetInitializerExpression): New public method. Resolves and
18782 returns the field initializer and makes sure it is only resolved once.
18783 (TypeContainer.EmitFieldInitializers): Call
18784 FieldBase.GetInitializerExpression to get the initializer, this ensures
18785 that it isn't resolved multiple times.
18787 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
18788 the resolving process (SimpleName/MemberLookup) that we're currently
18789 emitting a field initializer (which must not access any instance members,
18790 this is an error CS0236).
18792 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
18793 argument, if the `IsFieldInitializer' flag is set, we must report and
18794 error CS0236 and not an error CS0120.
18796 2002-08-07 Martin Baulig <martin@gnome.org>
18798 * ecore.cs (IMemberExpr): New public interface.
18799 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
18800 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
18801 if the expression is an IMemberExpr.
18803 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
18804 to be null, implicitly default to `this' if we're non-static in
18805 this case. Simplified the code a lot by using the new IMemberExpr
18806 interface. Also fixed bug #28176 here.
18808 2002-08-06 Martin Baulig <martin@gnome.org>
18810 * cs-parser.jay (SimpleLookup): Removed. We need to create
18811 ParameterReferences during semantic analysis so that we can do a
18812 type-only search when resolving Cast, TypeOf and SizeOf.
18813 (block): Pass the `current_local_parameters' to the Block's
18816 * class.cs (ConstructorInitializer): Added `Parameters parameters'
18817 argument to the constructor.
18818 (ConstructorInitializer.Resolve): Create a temporary implicit
18819 block with the parameters.
18821 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
18822 references here if we aren't doing a type-only search.
18824 * statement.cs (Block): Added constructor which takes a
18825 `Parameters parameters' argument.
18826 (Block.Parameters): New public property.
18828 * support.cs (InternalParameters.Parameters): Renamed `parameters'
18829 to `Parameters' and made it public readonly.
18831 2002-08-06 Martin Baulig <martin@gnome.org>
18833 * ecore.cs (Expression.Warning): Made this public as well.
18835 * report.cs (Report.Debug): Print the contents of collections.
18837 2002-08-06 Martin Baulig <martin@gnome.org>
18839 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
18840 used to tell Resolve() which kinds of expressions it may return.
18841 (Expression.Resolve): Added overloaded version of this method which
18842 takes a `ResolveFlags flags' argument. This can be used to tell
18843 Resolve() which kinds of expressions it may return. Reports a
18845 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
18846 ResolveFlags.SimpleName.
18847 (Expression.Error118): Added overloaded version of this method which
18848 takes a `ResolveFlags flags' argument. It uses the flags to determine
18849 which kinds of expressions are allowed.
18851 * expression.cs (Argument.ResolveMethodGroup): New public method.
18852 Resolves an argument, but allows a MethodGroup to be returned.
18853 This is used when invoking a delegate.
18855 * TODO: Updated a bit.
18857 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18859 Fixed compilation with csc.
18861 * ecore.cs: Expression.Error made public. Is this correct? Should
18862 Warning be made public too?
18864 * expression.cs: use ea.Location instead of ea.loc.
18865 [FIXME: Filed as bug #28607: MCS must report these errors.]
18867 2002-08-06 Martin Baulig <martin@gnome.org>
18869 * ecore.cs (Expression.loc): Moved the location here instead of
18870 duplicating it in all derived classes.
18871 (Expression.Location): New public property.
18872 (Expression.Error, Expression.Warning): Made them non-static and
18873 removed the location argument.
18874 (Expression.Warning): Added overloaded version which takes an
18875 `int level' argument.
18876 (Expression.Error118): Make this non-static and removed the
18877 expression and location arguments.
18878 (TypeExpr): Added location argument to the constructor.
18880 * expression.cs (StaticCallExpr): Added location argument to
18882 (Indirection, PointerArithmetic): Likewise.
18883 (CheckedExpr, UnCheckedExpr): Likewise.
18884 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
18885 (StringPtr): Likewise.
18888 2002-08-05 Martin Baulig <martin@gnome.org>
18890 * expression.cs (BaseAccess.DoResolve): Actually report errors.
18892 * assign.cs (Assign.DoResolve): Check whether the source
18893 expression is a value or variable.
18895 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
18896 while resolving the corresponding blocks.
18898 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
18899 an error, don't silently return null.
18901 * statement.cs (Block.AddVariable): Do the error reporting here
18902 and distinguish between CS0128 and CS0136.
18903 (Block.DoResolve): Report all unused labels (warning CS0164).
18904 (LabeledStatement): Pass the location to the constructor.
18905 (LabeledStatement.HasBeenReferenced): New property.
18906 (LabeledStatement.Resolve): Set it to true here.
18908 * statement.cs (Return.Emit): Return success even after reporting
18909 a type mismatch error (CS0126 or CS0127), this is what csc does and
18910 it avoids confusing the users with any consecutive errors.
18912 2002-08-05 Martin Baulig <martin@gnome.org>
18914 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
18916 * const.cs (Const.LookupConstantValue): Catch circular definitions.
18918 * expression.cs (MemberAccess.DoResolve): Silently return if an
18919 error has already been reported.
18921 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
18922 error has already been reported.
18924 2002-08-05 Martin Baulig <martin@gnome.org>
18926 * statement.cs (UsageVector): Only initialize the `parameters'
18927 vector if we actually have any "out" parameters.
18929 2002-08-05 Martin Baulig <martin@gnome.org>
18931 * expression.cs (Binary.ResolveOperator): When combining delegates,
18932 they must have the same type.
18934 2002-08-05 Martin Baulig <martin@gnome.org>
18936 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
18937 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
18938 work with the ms runtime and we also don't need it: if we're a
18939 PropertyBuilder and not in the `indexer_arguments' hash, then we
18940 are a property and not an indexer.
18942 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
18943 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
18944 since the latter one doesn't work with the ms runtime.
18946 2002-08-03 Martin Baulig <martin@gnome.org>
18948 Fixed bugs #27998 and #22735.
18950 * class.cs (Method.IsOperator): New public field.
18951 (Method.CheckBase): Report CS0111 if there's already a method
18952 with the same parameters in the current class. Report CS0508 when
18953 attempting to change the return type of an inherited method.
18954 (MethodData.Emit): Report CS0179 if a method doesn't have a body
18955 and it's not marked abstract or extern.
18956 (PropertyBase): New abstract base class for Property and Indexer.
18957 (PropertyBase.CheckBase): Moved here from Property and made it work
18959 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
18960 the same so we can reuse it there.
18961 (Property, Indexer): Derive from PropertyBase.
18962 (MethodSignature.inheritable_property_signature_filter): New delegate
18963 to find properties and indexers.
18965 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
18966 argument and improved error reporting.
18968 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
18969 EmptyReadOnlyParameters and made it a property.
18971 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
18972 version of this method which takes a `PropertyInfo indexer'.
18973 (TypeManager.RegisterIndexer): New method.
18975 * class.cs: Added myself as author of this file :-)
18977 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18979 * class.cs: fixed compilation on windoze.
18981 2002-08-03 Martin Baulig <martin@gnome.org>
18983 * interface.cs (Interface.GetInterfaceBases): Check whether all
18984 base interfaces are at least as accessible than the current one.
18986 * class.cs (TypeContainer.GetClassBases): Check whether base types
18987 are at least as accessible than the current type.
18988 (TypeContainer.AsAccessible): Implemented and made non-static.
18989 (MemberBase.CheckParameters): Report errors if the accessibility
18992 * delegate.cs (Delegate.Delegate): The default visibility is
18993 internal for top-level types and private for nested types.
18994 (Delegate.Define): Report errors if the accessibility checks fail.
18996 * enum.cs (Enum.Enum): The default visibility is internal for
18997 top-level types and private for nested types.
18998 (Enum.DefineType): Compute the correct visibility.
19000 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
19001 function which takes a `bool is_toplevel' instead of a TypeContainer.
19003 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
19006 2002-08-02 Martin Baulig <martin@gnome.org>
19008 * expression.cs (LocalVariableReferenc): Added constructor which
19009 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
19010 (LocalVariableReference.IsReadOnly): New property.
19011 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
19012 variable is readonly, use our own readonly flag to do this; you can
19013 use the new constructor to get a writable reference to a read-only
19016 * cs-parser.jay (foreach_statement, using_statement): Get a writable
19017 reference to the local variable.
19019 2002-08-01 Miguel de Icaza <miguel@ximian.com>
19021 * rootcontext.cs (ResolveCore): Also include System.Exception
19023 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
19024 we reach an EmptyStatement.
19026 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
19029 * expression.cs (Binary.ResolveOperator): Check error result in
19032 use brtrue/brfalse directly and avoid compares to null.
19034 2002-08-02 Martin Baulig <martin@gnome.org>
19036 * class.cs (TypeContainer.Define): Define all nested interfaces here.
19037 Fixes bug #28407, added test-155.cs.
19039 2002-08-01 Martin Baulig <martin@gnome.org>
19041 * class.cs (Event.EmitDefaultMethod): Make this work with static
19042 events. Fixes #28311, added verify-3.cs.
19044 2002-08-01 Martin Baulig <martin@gnome.org>
19046 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
19047 `is_disposable' fields.
19048 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
19049 `hm.is_disposable' if we're using the collection pattern.
19050 (Foreach.EmitCollectionForeach): Use the correct type for the
19051 enumerator's local variable, only emit the try/finally block if
19052 necessary (fixes #27713).
19054 2002-08-01 Martin Baulig <martin@gnome.org>
19056 * ecore.cs (Expression.report118): Renamed to Error118 and made
19059 * statement.cs (Throw.Resolve): Check whether the expression is of
19060 the correct type (CS0118) and whether the type derives from
19061 System.Exception (CS0155).
19062 (Catch.Resolve): New method. Do the type lookup here and check
19063 whether it derives from System.Exception (CS0155).
19064 (Catch.CatchType, Catch.IsGeneral): New public properties.
19066 * typemanager.cs (TypeManager.exception_type): Added.
19068 2002-07-31 Miguel de Icaza <miguel@ximian.com>
19070 * driver.cs: Updated About function.
19072 2002-07-31 Martin Baulig <martin@gnome.org>
19074 Implemented Control Flow Analysis.
19076 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
19077 (EmitContext.CurrentBranching): Added.
19078 (EmitContext.StartFlowBranching): Added.
19079 (EmitContext.EndFlowBranching): Added.
19080 (EmitContext.KillFlowBranching): Added.
19081 (EmitContext.IsVariableAssigned): Added.
19082 (EmitContext.SetVariableAssigned): Added.
19083 (EmitContext.IsParameterAssigned): Added.
19084 (EmitContext.SetParameterAssigned): Added.
19085 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
19086 Added control flow analysis stuff here.
19088 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
19089 resolve the expression as lvalue.
19090 (LocalVariableReference.DoResolve): Check whether the variable has
19091 already been assigned.
19092 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
19093 the parameter as assigned here.
19094 (ParameterReference.DoResolve): Check whether the parameter has already
19096 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
19097 expression as lvalue.
19099 * statement.cs (FlowBranching): New class for the flow analysis code.
19100 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
19101 (LabeledStatement.IsDefined): New public property.
19102 (LabeledStatement.AddUsageVector): New public method to tell flow
19103 analyis that the label may be reached via a forward jump.
19104 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
19106 (VariableInfo.Number): New public field. This is used by flow analysis
19107 to number all locals of a block.
19108 (Block.CountVariables): New public property. This is the number of
19109 local variables in this block (including the locals from all parent
19111 (Block.EmitMeta): Number all the variables.
19113 * statement.cs: Added flow analysis support to all classes.
19115 2002-07-31 Martin Baulig <martin@gnome.org>
19117 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
19118 To get debugging messages, compile mcs with /define:MCS_DEBUG and
19119 then use this argument.
19121 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
19123 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
19124 use this to specify /define options.
19126 2002-07-29 Martin Baulig <martin@gnome.org>
19128 * statement.cs (Fixed): Moved all code that does variable lookups
19129 and resolvings from Emit to Resolve.
19131 * statement.cs (For): Moved all code that does variable lookups
19132 and resolvings from Emit to Resolve.
19134 * statement.cs (Using): Moved all code that does variable lookups
19135 and resolvings from Emit to Resolve.
19137 2002-07-29 Martin Baulig <martin@gnome.org>
19139 * attribute.cs (Attribute.Resolve): Explicitly catch a
19140 System.NullReferenceException when creating the
19141 CustromAttributeBuilder and report a different warning message.
19143 2002-07-29 Martin Baulig <martin@gnome.org>
19145 * support.cs (ParameterData.ParameterName): Added method to
19146 get the name of a parameter.
19148 * typemanager.cs (TypeManager.IsValueType): New public method.
19150 2002-07-29 Martin Baulig <martin@gnome.org>
19152 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
19153 is a flag which specifies that it's either ref or out.
19154 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
19155 the out parameter to `out Parameter.Modifier mod', also set the
19156 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
19158 * support.cs (InternalParameters.ParameterModifier): Distinguish
19159 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
19160 Parameter.Modifier.ISBYREF flag if it's either ref or out.
19162 * expression.cs (Argument.GetParameterModifier): Distinguish
19163 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
19164 Parameter.Modifier.ISBYREF flag if it's either ref or out.
19166 2002-07-29 Martin Baulig <martin@gnome.org>
19168 * expression.cs (ParameterReference.ParameterReference): Added
19169 `Location loc' argument to the constructor.
19171 * cs-parser.jay: Pass location to ParameterReference.
19173 2002-07-28 Miguel de Icaza <miguel@ximian.com>
19175 * statement.cs (Try): Initialize the location.
19177 * cs-parser.jay: pass location to Try.
19179 * expression.cs (Unary.Reduce): Change the prototype to return
19180 whether a constant fold could be performed or not. The result is
19181 returned in an out parameters. In the case of Indirection and
19182 AddressOf, we want to perform the full tests.
19184 2002-07-26 Miguel de Icaza <miguel@ximian.com>
19186 * statement.cs (Statement.Emit): Flag dead code.
19188 2002-07-27 Andrew Birkett <andy@nobugs.org>
19190 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
19192 2002-07-27 Martin Baulig <martin@gnome.org>
19194 * class.cs (MethodData.Define): Put back call to
19195 TypeManager.AddMethod(), accidentally commented this out.
19197 * report.cs (Debug): New public method to print debugging information,
19198 this is `[Conditional ("DEBUG")]'.
19200 2002-07-26 Martin Baulig <martin@gnome.org>
19202 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
19203 (switch_statement): Push the current_block to the switch_stack and
19204 pop it again when we're done with the switch.
19205 (switch_section): The new block is a child of the current_block.
19206 Fixes bug #24007, added test-152.cs.
19208 2002-07-27 Martin Baulig <martin@gnome.org>
19210 * expression.cs (Invocation.EmitArguments): When calling a varargs
19211 function with only its fixed arguments, we need to pass an empty
19214 2002-07-27 Martin Baulig <martin@gnome.org>
19216 Mono 0.13 has been released.
19218 2002-07-25 Miguel de Icaza <miguel@ximian.com>
19220 * driver.cs: Rename --resource to --linkres, because that is what
19221 we do currently, we dont support --resource yet.
19223 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
19225 2002-07-25 Martin Baulig <martin@gnome.org>
19227 * class.cs (MethodData): New public class. This is a `method builder'
19228 class for a method or one accessor of a Property/Indexer/Event.
19229 (MethodData.GetMethodFlags): Moved here from MemberBase.
19230 (MethodData.ApplyAttributes): Likewise.
19231 (MethodData.ApplyObsoleteAttribute): Likewise.
19232 (MethodData.ApplyConditionalAttribute): Likewise.
19233 (MethodData.ApplyDllImportAttribute): Likewise.
19234 (MethodData.CheckAbstractAndExternal): Likewise.
19235 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
19236 (MethodData.Emit): Formerly known as Method.Emit().
19237 (MemberBase): Moved everything which was specific to a single
19238 accessor/method to MethodData.
19239 (Method): Create a new MethodData and call Define() and Emit() on it.
19240 (Property, Indexer, Event): Create a new MethodData objects for each
19241 accessor and call Define() and Emit() on them.
19243 2002-07-25 Martin Baulig <martin@gnome.org>
19245 Made MethodCore derive from MemberBase to reuse the code from there.
19246 MemberBase now also checks for attributes.
19248 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
19249 (MemberBase.GetMethodFlags): Moved here from class Method and marked
19251 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
19252 `CallingConventions cc' and `Attributes opt_attrs' arguments.
19253 (MemberBase.ApplyAttributes): New virtual method; applies the
19254 attributes to a method or accessor.
19255 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
19256 (MemberBase.ApplyConditionalAttribute): Likewise.
19257 (MemberBase.ApplyDllImportAttribute): Likewise.
19258 (MemberBase.CheckAbstractAndExternal): Likewise.
19259 (MethodCore.ParameterTypes): This is now a property instead of a
19260 method, it's initialized from DoDefineParameters().
19261 (MethodCore.ParameterInfo): Removed the set accessor.
19262 (MethodCore.DoDefineParameters): New protected virtual method to
19263 initialize ParameterTypes and ParameterInfo.
19264 (Method.GetReturnType): We can now simply return the MemberType.
19265 (Method.GetMethodFlags): Override the MemberBase version and add
19266 the conditional flags.
19267 (Method.CheckBase): Moved some code from Define() here, call
19268 DoDefineParameters() here.
19269 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
19270 here to avoid some larger code duplication.
19271 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
19272 ensure that abstract and external accessors don't declare a body.
19274 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
19275 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
19276 lookup in the attribute's parent classes, so we need to abort as soon
19277 as we found the first match.
19278 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
19279 the attribute has no arguments.
19281 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
19284 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19286 * cs-parser.jay: reverted previous patch.
19288 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19290 * cs-parser.jay: fixed bug #22119.
19292 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19294 * attribute.cs: fixed compilation. The error was:
19295 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
19296 be assigned to before control leaves the current method."
19297 [FIXME: Filed as bug #28186: MCS must report this error.]
19299 2002-07-25 Martin Baulig <martin@gnome.org>
19301 * attribute.cs (Attribute.Conditional_GetConditionName): New static
19302 method to pull the condition name ouf of a Conditional attribute.
19303 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
19304 the obsolete message and error flag out of an Obsolete attribute.
19306 * class.cs (Method.GetMethodFlags): New public method to get the
19307 TypeManager.MethodFlags for this method.
19308 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
19310 (Method.Define): Get and apply the Obsolete and Conditional attributes;
19311 if we're overriding a virtual function, set the new private variable
19312 `parent_method'; call the new TypeManager.AddMethod().
19314 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
19315 the MethodBuilder and the Method in a PtrHashtable.
19316 (TypeManager.builder_to_method): Added for this purpose.
19317 (TypeManager.MethodFlags): Added IsObsoleteError.
19318 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
19319 Obsolete and Conditional arguments in MethodBuilders. If we discover
19320 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
19321 the message from the attribute.
19323 2002-07-24 Martin Baulig <martin@gnome.org>
19325 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
19326 preprocessor directives, ensure that the argument to #define/#undef is
19327 exactly one identifier and that it's actually an identifier.
19329 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
19332 2002-07-24 Martin Baulig <martin@gnome.org>
19334 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
19335 initialize it to TypeManager.object_type in the constructor.
19336 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
19337 of the `hm.get_current' method if we're using the collection pattern.
19338 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
19339 for the explicit conversion to make it work when we're using the collection
19340 pattern and the `Current' property has a different return type than `object'.
19343 2002-07-24 Martin Baulig <martin@gnome.org>
19345 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
19346 does not match, but don't report any errors. This method is called in
19347 order for all methods in a MethodGroupExpr until a matching method is
19348 found, so we don't want to bail out if the first method doesn't match.
19349 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
19350 matches, report the 123. Fixes #28070.
19352 2002-07-24 Martin Baulig <martin@gnome.org>
19354 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
19355 TypeManager.TypeToCoreType() to the top of the method so the
19356 following equality checks will work. Fixes #28107.
19358 2002-07-24 Martin Baulig <martin@gnome.org>
19360 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
19361 operand is of type uint, and the other operand is of type sbyte,
19362 short or int, the operands are converted to type long." -
19363 Actually do what this comment already told us. Fixes bug #28106,
19366 2002-07-24 Martin Baulig <martin@gnome.org>
19368 * class.cs (MethodBase): New abstract class. This is now a base
19369 class for Property, Indexer and Event to avoid some code duplication
19370 in their Define() and DefineMethods() methods.
19371 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
19372 generic methods for Define() and DefineMethods().
19373 (FieldBase): Derive from MemberBase, not MemberCore.
19374 (Property): Derive from MemberBase, not MemberCore.
19375 (Property.DefineMethod): Moved all the code from this method to the
19376 new MethodBase.DefineAccessor(), just call it with appropriate
19378 (Property.Define): Call the new Property.DoDefine(), this does some
19379 sanity checks and we don't need to duplicate the code everywhere.
19380 (Event): Derive from MemberBase, not MemberCore.
19381 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
19382 accessors, this will also make them work with interface events.
19383 (Indexer): Derive from MemberBase, not MemberCore.
19384 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
19385 (Indexer.Define): Use the new MethodBase functions.
19387 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
19388 argument to the constructor.
19389 (Interface.FindMembers): Added support for interface events.
19390 (Interface.PopluateEvent): Implemented.
19392 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
19394 2002-07-22 Miguel de Icaza <miguel@ximian.com>
19396 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
19397 but this is required to check for a method name being the same as
19398 the containing class.
19402 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19404 * interface.cs: initialize variable.
19406 2002-07-23 Martin Baulig <martin@gnome.org>
19408 Implemented the IndexerName attribute in interfaces.
19410 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
19411 name if this is an explicit interface implementation.
19412 (Indexer.InterfaceIndexerName): New public variable. If we're
19413 implementing an interface indexer, this is the IndexerName in that
19414 interface. Otherwise, it's the IndexerName.
19415 (Indexer.DefineMethod): If we're implementing interface indexer,
19416 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
19417 and Pending.ImplementIndexer methods.
19418 (Indexer.Define): Also define the PropertyBuilder if we're
19419 implementing an interface indexer and this is neither an explicit
19420 interface implementation nor do the IndexerName match the one in
19423 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
19424 If a method is defined here, then we always need to create a proxy
19425 for it. This is used when implementing interface indexers.
19426 (Pending.IsInterfaceIndexer): New public method.
19427 (Pending.ImplementIndexer): New public method.
19428 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
19429 This is used when implementing interface indexers to define a proxy
19431 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
19432 define a proxy if necessary.
19434 * interface.cs (Interface.IndexerName): New public variable.
19435 (Interface.PopulateIndexer): Set the IndexerName.
19436 (Interface.DefineIndexers): New private method. Populate all the
19437 indexers and make sure their IndexerNames match.
19439 * typemanager.cs (IndexerPropertyName): Added support for interface
19442 2002-07-22 Martin Baulig <martin@gnome.org>
19444 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
19445 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
19446 ret if HasReturnLabel.
19447 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
19450 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
19451 and set the ec.LoopBeginTryCatchLevel.
19452 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
19453 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
19454 the current ec.TryCatchLevel, the branch goes out of an exception
19455 block. In this case, we need to use Leave and not Br.
19457 2002-07-22 Martin Baulig <martin@gnome.org>
19459 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
19460 block unless the block does not always return or it is contained in
19461 another try { ... } catch { ... } block. Fixes bug #26506.
19462 Added verify-1.cs to the test suite.
19464 2002-07-22 Martin Baulig <martin@gnome.org>
19466 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
19467 then we do not always return. Fixes bug #24985.
19469 2002-07-22 Martin Baulig <martin@gnome.org>
19471 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
19472 lookup on a per-class level; ie. walk up the class hierarchy until we
19473 found at least one applicable method, then choose the best among them.
19474 Fixes bug #24463 and test-29.cs.
19476 2002-07-22 Martin Baulig <martin@gnome.org>
19478 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
19479 return types of the methods. The return type is not part of the
19480 signature and we must not check it to make the `new' modifier work.
19481 Fixes bug #27999, also added test-147.cs.
19482 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
19484 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
19485 on the method's return type.
19487 2002-07-21 Martin Baulig <martin@gnome.org>
19489 * assign.cs: Make this work if the rightmost source is a constant and
19490 we need to do an implicit type conversion. Also adding a few more tests
19491 to test-38.cs which should have caught this.
19493 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
19494 target in the makefile for this. The makefile.gnu is primarily intended
19495 for end-users who don't want to debug the compiler.
19497 2002-07-21 Martin Baulig <martin@gnome.org>
19499 * assign.cs: Improved the Assign class so it can now handle embedded
19500 assignments (X = Y = Z = something). As a side-effect this'll now also
19501 consume less local variables. test-38.cs now passes with MCS, added
19502 a few new test cases to that test.
19504 2002-07-20 Martin Baulig <martin@gnome.org>
19506 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
19507 instructions. Fixes bug #27977, also added test-146.cs.
19509 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19511 * cs-tokenizer.cs: fixed getHex ().
19513 2002-07-19 Martin Baulig <martin@gnome.org>
19515 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
19516 not Type.GetType() to lookup the array type. This is needed when
19517 we're constructing an array of a user-defined type.
19518 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
19519 single-dimensional arrays, but also for single-dimensial arrays of
19522 2002-07-19 Martin Baulig <martin@gnome.org>
19524 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
19525 this function is called, it's not allowed to share LocalBuilders
19526 among ILGenerators.
19528 2002-07-19 Martin Baulig <martin@gnome.org>
19530 * expression.cs (Argument.Resolve): Report an error 118 when trying
19531 to pass a type as argument.
19533 2002-07-18 Martin Baulig <martin@gnome.org>
19535 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
19536 Conv_R_Un for the signed `long' type.
19538 2002-07-15 Miguel de Icaza <miguel@ximian.com>
19540 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
19541 `expr' for the temporary result, as that will fail if we do
19542 multiple resolves on the same expression.
19544 2002-07-05 Miguel de Icaza <miguel@ximian.com>
19546 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
19547 ec.TypeContainer for looking up aliases.
19549 * class.cs (TypeContainer): Remove LookupAlias from here.
19551 * decl.cs (DeclSpace); Move here.
19553 2002-07-01 Miguel de Icaza <miguel@ximian.com>
19555 * class.cs (FindMembers): Only call filter if the constructor
19556 bulider is not null.
19558 Also handle delegates in `NestedTypes' now. Now we will perform
19559 type lookups using the standard resolution process. This also
19562 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
19563 This uses Expressions (the limited kind that can be parsed by the
19564 tree) instead of strings.
19566 * expression.cs (ComposedCast.ToString): Implement, used to flag
19567 errors since now we have to render expressions.
19569 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
19572 * ecore.cs (SimpleName.ToString): ditto.
19574 * cs-parser.jay: Instead of using strings to assemble types, use
19575 Expressions to assemble the type (using SimpleName, ComposedCast,
19576 MemberAccess). This should fix the type lookups in declarations,
19577 because we were using a different code path for this.
19579 * statement.cs (Block.Resolve): Continue processing statements
19580 even when there is an error.
19582 2002-07-17 Miguel de Icaza <miguel@ximian.com>
19584 * class.cs (Event.Define): Also remove the `remove' method from
19585 the list of pending items.
19587 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
19588 generate more compact code.
19590 2002-07-17 Martin Baulig <martin@gnome.org>
19592 * const.cs (Const.LookupConstantValue): Add support for constant
19593 `unchecked' and `checked' expressions.
19594 Also adding test case test-140.cs for this.
19596 2002-07-17 Martin Baulig <martin@gnome.org>
19598 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
19599 check whether mi.ReturnType implements the IEnumerator interface; the
19600 `==' and the IsAssignableFrom() will fail in this situation.
19602 2002-07-16 Ravi Pratap <ravi@ximian.com>
19604 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
19607 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19609 * expression.cs: fixed bug #27811.
19611 2002-07-14 Miguel de Icaza <miguel@ximian.com>
19613 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
19614 Molaro: when we are a ref, the value already contains a pointer
19615 value, do not take the address of it.
19617 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
19618 * removed mb-parser.jay and mb-tokenizer.cs
19620 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
19622 * expression.cs: check against the building corlib void type.
19624 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
19626 * ecore.cs: fix for valuetype static readonly fields: when
19627 initializing them, we need their address, not the address of a copy.
19629 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
19631 * typemanager.cs: register also enum_type in corlib.
19633 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
19635 * class.cs: allow calling this (but not base) initializers in structs.
19637 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
19639 * ecore.cs: make sure we compare against the building base types
19642 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
19644 * typemanager.cs: fix TypeToCoreType() to handle void and object
19645 (corlib gets no more typerefs after this change).
19647 2002-07-12 Miguel de Icaza <miguel@ximian.com>
19649 * expression.cs (ArrayCreation.EmitArrayArguments): use
19650 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
19652 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
19653 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
19654 array indexes, the runtime actually forbids them.
19656 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
19657 for array arguments here.
19659 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
19660 instead of the default for ValueTypes.
19662 (New.DoEmit): Use IsValueType instead of
19663 IsSubclassOf (value_type)
19664 (New.DoResolve): ditto.
19665 (Invocation.EmitCall): ditto.
19667 * assign.cs (Assign): ditto.
19669 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
19670 Statements *are* currently doing part of their resolution during
19673 Expressions do always resolve during resolve, but statements are
19674 only required to propagate resolution to their children.
19676 2002-07-11 Miguel de Icaza <miguel@ximian.com>
19678 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
19680 (LoadAssembly): Do not add the dll if it is already specified
19682 (MainDriver): Add the System directory to the link path at the end,
19683 after all the other -L arguments.
19685 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
19686 wrong opcode for loading bytes and bools (ldelem.i1 instead of
19687 ldelem.u1) and using the opposite for sbytes.
19689 This fixes Digger, and we can finally run it.
19691 * driver.cs (UnixParseOption): Move the option parsing here.
19692 (CSCParseOption): Implement CSC-like parsing of options.
19694 We now support both modes of operation, the old Unix way, and the
19695 new CSC-like way. This should help those who wanted to make cross
19696 platform makefiles.
19698 The only thing broken is that /r:, /reference: and /lib: are not
19699 implemented, because I want to make those have the same semantics
19700 as the CSC compiler has, and kill once and for all the confussion
19701 around this. Will be doing this tomorrow.
19703 * statement.cs (Unsafe.Resolve): The state is checked during
19704 resolve, not emit, so we have to set the flags for IsUnsfe here.
19706 2002-07-10 Miguel de Icaza <miguel@ximian.com>
19708 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
19709 not catch the Error_ObjectRefRequired in SimpleName (as it is
19710 possible to have a class/instance variable name that later gets
19711 deambiguated), we have to check this here.
19713 2002-07-10 Ravi Pratap <ravi@ximian.com>
19715 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
19716 make static and put into Expression.
19718 (Event.Define): Register the private field of the event with the
19719 TypeManager so that GetFieldFromEvent can get at it.
19721 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
19722 keep track of the private field associated with an event which
19725 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
19728 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
19730 2002-07-10 Miguel de Icaza <miguel@ximian.com>
19732 * expression.cs (Binary.EmitBranchable): this routine emits the
19733 Binary expression in a branchable context. This basically means:
19734 we need to branch somewhere, not just get the value on the stack.
19736 This works together with Statement.EmitBoolExpression.
19738 * statement.cs (Statement.EmitBoolExpression): Use
19741 2002-07-09 Miguel de Icaza <miguel@ximian.com>
19743 * statement.cs (For): Reduce the number of jumps in loops.
19745 (For): Implement loop inversion for the For statement.
19747 (Break): We can be breaking out of a Try/Catch controlled section
19748 (foreach might have an implicit try/catch clause), so we need to
19749 use Leave instead of Br.
19751 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
19752 now). If the instace expression supports IMemoryLocation, we use
19753 the AddressOf method from the IMemoryLocation to extract the
19754 address instead of emitting the instance.
19756 This showed up with `This', as we were emitting the instance
19757 always (Emit) instead of the Address of This. Particularly
19758 interesting when This is a value type, as we dont want the Emit
19759 effect (which was to load the object).
19761 2002-07-08 Miguel de Icaza <miguel@ximian.com>
19763 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
19765 * statement.cs (Checked): Set the CheckedState during the resolve
19766 process too, as the ConvCast operations track the checked state on
19767 the resolve process, and not emit.
19769 * cs-parser.jay (namespace_member_declaration): Flag that we have
19770 found a declaration when we do. This is used to flag error 1529
19772 * driver.cs: Report ok when we display the help only.
19774 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
19776 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
19778 2002-07-04 Miguel de Icaza <miguel@ximian.com>
19780 * cs-tokenizer.cs (define): We also have to track locally the
19781 defines. AllDefines is just used for the Conditional Attribute,
19782 but we also need the local defines for the current source code.
19784 2002-07-03 Miguel de Icaza <miguel@ximian.com>
19786 * statement.cs (While, For, Do): These loops can exit through a
19787 Break statement, use this information to tell whether the
19788 statement is the last piece of code.
19790 (Break): Flag that we break.
19792 * codegen.cs (EmitContexts): New `Breaks' state variable.
19794 2002-07-03 Martin Baulig <martin@gnome.org>
19796 * class.cs (TypeContainer.MethodModifiersValid): Allow override
19797 modifiers in method declarations in structs. Otherwise, you won't
19798 be able to override things like Object.Equals().
19800 2002-07-02 Miguel de Icaza <miguel@ximian.com>
19802 * class.cs (Method, Property, Indexer): Do not allow the public
19803 modifier to be used in explicit interface implementations.
19805 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
19806 override modifiers in method declarations in structs
19808 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
19810 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
19811 integer or real overflow, report an error
19813 2002-07-02 Martin Baulig <martin@gnome.org>
19815 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
19816 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
19817 to tell the runtime about our newly created System.Object and
19818 System.ValueType types.
19820 2002-07-02 Miguel de Icaza <miguel@ximian.com>
19822 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
19823 struct instead of Ldarg/Starg.
19825 2002-07-02 Martin Baulig <martin@gnome.org>
19827 * expression.cs (Indirection.Indirection): Call
19828 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
19830 2002-07-02 Martin Baulig <martin@gnome.org>
19832 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
19833 ValueType, call TypeManager.TypeToCoreType() on it.
19834 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
19835 the OpCodes.Newarr argument.
19837 2002-07-02 Martin Baulig <martin@gnome.org>
19839 * expression.cs (Invocation.EmitCall): When compiling corlib,
19840 replace all calls to the system's System.Array type to calls to
19841 the newly created one.
19843 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
19844 System.Array methods.
19845 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
19846 from the system's System.Array type which must be replaced.
19848 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
19850 * typemanager.cs: load unverifiable_code_ctor so we can build
19851 corlib using the correct type. Avoid using GetTypeCode() with
19853 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
19854 TypeManager.object_type to allow building corlib.
19856 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
19858 * ecore.cs: handle System.Enum separately in LoadFromPtr().
19860 2002-07-01 Martin Baulig <martin@gnome.org>
19862 * class.cs: Make the last change actually work, we need to check
19863 whether `ifaces != null' to avoid a crash.
19865 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
19867 * class.cs: when we build structs without fields that implement
19868 interfaces, we need to add the interfaces separately, since there is
19869 no API to both set the size and add the interfaces at type creation
19872 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
19874 * expression.cs: the dimension arguments to the array constructors
19875 need to be converted if they are a long.
19877 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
19879 * class.cs: don't emit ldarg.0 if there is no parent constructor
19880 (fixes showstopper for corlib).
19882 2002-06-29 Martin Baulig <martin@gnome.org>
19884 MCS now compiles corlib on GNU/Linux :-)
19886 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
19887 ie. check for MethodImplOptions.InternalCall.
19889 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
19890 and TypeManager.attribute_type are null, so we must explicitly check
19891 whether parent is not null to find out whether it's an attribute type.
19892 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
19893 and SetBuilder, not only if the property is neither abstract nor external.
19894 This is necessary to set the MethodImplOptions on the accessor methods.
19895 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
19896 SetBuilder, see Property.Emit().
19898 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
19899 populate "System.Object", "System.ValueType" and "System.Attribute" since
19900 they've already been populated from BootCorlib_PopulateCoreTypes().
19902 2002-06-29 Martin Baulig <martin@gnome.org>
19904 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
19905 is the NullLiteral, we also need to make sure that target_type is not
19908 2002-06-29 Martin Baulig <martin@gnome.org>
19910 * rootcontext.cs (RootContext.ResolveCore): We must initialize
19911 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
19912 before calling BootstrapCorlib_ResolveDelegate ().
19914 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19916 * statement.cs: fixed build-breaker. All tests passed ok.
19918 2002-06-27 Martin Baulig <martin@gnome.org>
19920 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
19921 for System.Decimal when compiling corlib.
19923 2002-06-27 Martin Baulig <martin@gnome.org>
19925 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
19926 switch blocks which contain nothing but a default clause.
19928 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
19930 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
19932 2002-06-27 Martin Baulig <martin@gnome.org>
19934 * ecore.cs (PropertyExpr.PropertyExpr): Call
19935 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
19937 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
19938 is already a TypeBuilder.
19940 2002-06-27 Martin Baulig <martin@gnome.org>
19942 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
19943 `target_type == TypeManager.array_type', not IsAssignableFrom() in
19944 the "from an array-type to System.Array" case. This makes it work
19945 when compiling corlib.
19947 2002-06-27 Martin Baulig <martin@gnome.org>
19949 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
19950 non-static PropertyExpr, set its InstanceExpression. This makes
19951 the `ICollection.Count' property work in System/Array.cs.
19953 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
19955 * driver.cs: Made error handling more consistent. Errors now
19956 tracked by Report class, so many methods which used to return int
19957 now return void. Main() now prints success/failure and
19958 errors/warnings message.
19960 Renamed '--probe' compiler argument to '--expect-error'. Removed
19961 the magic number return values (123 and 124). Now, if the
19962 expected error occurs, the compiler exits with success (exit value
19963 0). If the compilation completes without seeing that particular
19964 error, the compiler exits with failure (exit value 1). The
19965 makefile in mcs/errors has been changed to handle the new behaviour.
19967 * report.cs: Made 'expected error' number a property and renamed
19968 it from 'Probe' to 'ExpectedError'.
19970 * genericparser.cs: Removed error handling support, since it is
19971 now all done by Report class.
19973 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
19974 class, so parse() no longer returns an int.
19976 * namespace.cs: Use Report.Error instead of GenericParser.error
19978 2002-06-22 Miguel de Icaza <miguel@ximian.com>
19980 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
19981 TypeContainer.AddOperator): At the front of the list put the
19982 explicit implementations, so they get resolved/defined first.
19984 2002-06-21 Miguel de Icaza <miguel@ximian.com>
19986 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
19987 interface type is implemented by this TypeContainer. Used during
19988 explicit interface implementation.
19990 (Property.Define, Indexer.Define, Method.Define): Validate that
19991 the given interface in the explicit implementation is one of the
19992 base classes for the containing type.
19994 Also if we are explicitly implementing an interface, but there is
19995 no match in the pending implementation table, report an error.
19997 (Property.Define): Only define the property if we are
19998 not explicitly implementing a property from an interface. Use the
19999 correct name also for those properties (the same CSC uses,
20000 although that is really not needed).
20002 (Property.Emit): Do not emit attributes for explicitly implemented
20003 properties, as there is no TypeBuilder.
20005 (Indexer.Emit): ditto.
20007 Hiding then means that we do not really *implement* a pending
20008 implementation, which makes code fail.
20010 2002-06-22 Martin Baulig <martin@gnome.org>
20012 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
20013 the return value of Object.GetType(). [FIXME: we need to do this whenever
20014 we get a type back from the reflection library].
20016 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
20018 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
20020 2002-06-20 Miguel de Icaza <miguel@ximian.com>
20022 * attribute.cs: Return null if we can not look up the type.
20024 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
20025 the interface types found.
20027 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
20028 interface types found.
20030 * typemanager.cs (GetInterfaces): Make this routine returns alll
20031 the interfaces and work around the lame differences between
20032 System.Type and System.Reflection.Emit.TypeBuilder in the results
20033 result for GetInterfaces.
20035 (ExpandInterfaces): Given an array of interface types, expand and
20036 eliminate repeated ocurrences of an interface. This expands in
20037 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
20040 2002-06-21 Martin Baulig <martin@gnome.org>
20042 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
20045 2002-06-21 Martin Baulig <martin@gnome.org>
20047 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
20048 and called with one of the core types, return the corresponding typebuilder for
20051 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
20054 2002-06-21 Martin Baulig <martin@gnome.org>
20056 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
20057 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
20058 (Expression.ConvertReferenceExplicit): Likewise.
20060 * expression.cs (ElementAccess.DoResolve): Likewise.
20061 (ElementAccess.DoResolveLValue): Likewise.
20063 2002-06-10 Martin Baulig <martin@gnome.org>
20065 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
20066 add the "value" parameter to the parameter list.
20068 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
20071 2002-06-19 Miguel de Icaza <miguel@ximian.com>
20073 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
20074 the argument to an int, uint, long or ulong, per the spec. Also
20075 catch negative constants in array creation.
20077 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
20079 * class.cs: do not allow the same interface to appear twice in
20080 the definition list.
20082 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
20084 * ecore.cs: don't use ldlen with System.Array.
20086 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
20088 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
20090 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
20092 * modifiers.cs: produce correct field attributes for protected
20093 internal. Easy fix so miguel can work on ther harder stuff:-)
20095 2002-06-18 Miguel de Icaza <miguel@ximian.com>
20097 * pending.cs: New file. Move the code from class.cs here.
20098 Support clearning the pending flag for all methods (when not doing
20099 explicit interface implementation).
20101 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
20103 * rootcontext.cs: added a couple more types needed to bootstrap.
20105 2002-06-17 Miguel de Icaza <miguel@ximian.com>
20107 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
20108 constructor in the type, instead of any constructor in the type
20109 hierarchy. Thanks to Paolo for finding this bug (it showed up as
20110 a bug in the Mono runtime when applying the params attribute).
20112 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
20113 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
20115 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
20117 * expression.cs (Unary.ResolveOperator): Use TypeManager
20118 to resolve the type.
20120 2002-06-13 Ravi Pratap <ravi@ximian.com>
20122 * cs-parser.jay (enum_member_declaration): Pass in the attributes
20125 * enum.cs (AddEnumMember): Add support to store the attributes associated
20126 with each member too.
20128 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
20129 field builders too - this takes care of the enum member case.
20131 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
20133 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
20134 address-of operator on both value types and pointers.
20136 2002-06-10 Martin Baulig <martin@gnome.org>
20138 * interface.cs (Interface.PopulateIndexer): Add the indexer's
20139 PropertyBuilder to the `property_builders' list.
20141 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
20142 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
20143 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
20144 find any indexers which are inherited from an interface.
20146 2002-06-09 Martin Baulig <martin@gnome.org>
20148 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
20149 the same type as the constant if necessary. There's also a test-130.cs
20152 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
20154 * typemanager.cs (TypeManager.ChangeType): Previously known as
20155 Enum.ChangeEnumType().
20157 2002-06-09 Martin Baulig <martin@gnome.org>
20159 * expression.cs (Cast.TryReduce): Added support for consts.
20161 2002-06-08 Ravi Pratap <ravi@ximian.com>
20163 * class.cs (Accessor): Hold attributes information so we can pass
20166 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
20167 Modify to pass in attributes attached to the methods.
20169 (add_accessor_declaration, remove_accessor_declaration): Ditto.
20171 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
20172 to handle the Accessor kind :-)
20174 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
20176 2002-06-08 Martin Baulig <martin@gnome.org>
20178 * expression.cs (Unary.TryReduceNegative): Added support for
20181 2002-06-08 Martin Baulig <martin@gnome.org>
20183 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
20184 name can't be found in the `defined_names' - the caller will do a
20185 MemberLookup in this case and thus find methods in System.Enum
20186 such as Enum.IsDefined().
20188 2002-06-08 Martin Baulig <martin@gnome.org>
20190 * enum.cs (Enum.ChangeEnumType): This is a custom version of
20191 Convert.ChangeType() which works with TypeBuilder created types.
20192 (Enum.LookupEnumValue, Enum.Define): Use it here.
20194 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
20195 `TypeBuilder.BaseType != null' check.
20196 (TypeContainer.FindMembers): Only lookup parent members if we
20197 actually have a parent.
20198 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
20199 (ConstructorInitializer.Resolve): Likewise.
20201 * interface.cs (Interface.FindMembers): Added
20202 `TypeBuilder.BaseType != null' check.
20204 * rootcontext.cs (RootContext.ResolveCore): Added
20205 "System.Runtime.CompilerServices.IndexerNameAttribute" to
20206 classes_second_stage.
20208 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
20209 debug_type and trace_type when compiling with --nostdlib.
20211 2002-06-07 Martin Baulig <martin@gnome.org>
20213 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
20214 (AddField): Set it to true when adding a non-static field.
20215 (DefineType): Use `have_nonstatic_fields' to find out whether we
20216 have non-static fields, not `Fields != null'.
20218 2002-06-02 Miguel de Icaza <miguel@ximian.com>
20220 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
20221 dereferencing a null on the static-field code path)
20223 2002-05-30 Martin Baulig <martin@gnome.org>
20225 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
20226 to take command line arguments. Use reflection to call the new
20227 custom `Initialize' function on the symbol writer and pass it the
20228 command line arguments.
20230 * driver.cs (--debug-args): New command line argument to pass command
20231 line arguments to the symbol writer.
20233 2002-05-28 Miguel de Icaza <miguel@ximian.com>
20235 * assign.cs (DoResolve): Forgot to do the implicit conversion to
20236 the target type for indexers and properties. Thanks to Joe for
20239 2002-05-27 Miguel de Icaza <miguel@ximian.com>
20241 * typemanager.cs (MethodFlags): returns the method flags
20242 (Obsolete/ShouldIgnore) that control warning emission and whether
20243 the invocation should be made, or ignored.
20245 * expression.cs (Invocation.Emit): Remove previous hack, we should
20246 not do this on matching a base type, we should do this based on an attribute
20248 Only emit calls to System.Diagnostics.Debug and
20249 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
20250 on the command line.
20252 * rootcontext.cs: Global settings for tracing and debugging.
20254 * cs-tokenizer.cs (define): New utility function to track
20255 defines. Set the global settings for TRACE and DEBUG if found.
20257 2002-05-25 Ravi Pratap <ravi@ximian.com>
20259 * interface.cs (Populate*): Pass in the TypeContainer as well as
20260 the DeclSpace as parameters so that we can create EmitContexts and
20261 then use that to apply attributes etc.
20263 (PopulateMethod, PopulateEvent, PopulateProperty)
20264 (PopulateIndexer): Apply attributes everywhere.
20266 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
20269 (ApplyAttributes): Update accordingly.
20271 We now apply interface attributes for all members too.
20273 2002-05-26 Miguel de Icaza <miguel@ximian.com>
20275 * class.cs (Indexer.Define); Correctly check if we are explicit
20276 implementation (instead of checking the Name for a ".", we
20277 directly look up if the InterfaceType was specified).
20279 Delay the creation of the PropertyBuilder.
20281 Only create the PropertyBuilder if we are not an explicit
20282 interface implementation. This means that explicit interface
20283 implementation members do not participate in regular function
20284 lookups, and hence fixes another major ambiguity problem in
20285 overload resolution (that was the visible effect).
20287 (DefineMethod): Return whether we are doing an interface
20290 * typemanager.cs: Temporary hack until we get attributes in
20291 interfaces (Ravi is working on that) and we get IndexerName
20292 support in interfaces.
20294 * interface.cs: Register the indexers as properties.
20296 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
20297 warning, I have verified that this is a bug in the .NET runtime
20298 (JavaScript suffers of the same problem).
20300 * typemanager.cs (MemberLookup): When looking up members for
20301 interfaces, the parent of an interface is the implicit
20302 System.Object (so we succeed in searches of Object methods in an
20303 interface method invocation. Example: IEnumerable x; x.ToString
20306 2002-05-25 Miguel de Icaza <miguel@ximian.com>
20308 * class.cs (Event): Events should also register if they do
20309 implement the methods that an interface requires.
20311 * typemanager.cs (MemberLookup); use the new GetInterfaces
20314 (GetInterfaces): The code used to lookup interfaces for a type is
20315 used in more than one place, factor it here.
20317 * driver.cs: Track the errors at the bottom of the file, we kept
20320 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
20321 instance if the method we are calling is static!
20323 2002-05-24 Miguel de Icaza <miguel@ximian.com>
20325 * attribute.cs (ApplyAttributes): Make this function filter out
20326 the IndexerName attribute (as that attribute in reality is never
20327 applied) and return the string constant for the IndexerName
20330 * class.cs (TypeContainer.Emit): Validate that all the indexers
20331 have the same IndexerName attribute, and if so, set the
20332 DefaultName attribute on the class.
20334 * typemanager.cs: The return value might contain other stuff (not
20335 only methods). For instance, consider a method with an "Item"
20336 property and an Item method.
20338 * class.cs: If there is a problem with the parameter types,
20341 2002-05-24 Ravi Pratap <ravi@ximian.com>
20343 * ecore.cs (ImplicitConversionExists): Wrapper function which also
20344 looks at user defined conversion after making a call to
20345 StandardConversionExists - we need this for overload resolution.
20347 * expression.cs : Update accordingly the various method calls.
20349 This fixes 2 bugs filed against implicit user defined conversions
20351 2002-05-22 Miguel de Icaza <miguel@ximian.com>
20353 * statement.cs: Track the result of the assignment.
20355 2002-05-21 Miguel de Icaza <miguel@ximian.com>
20357 * expression.cs (MemberAccess): Improved error reporting for
20358 inaccessible members.
20360 2002-05-22 Martin Baulig <martin@gnome.org>
20362 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
20363 itself with debugging support.
20365 2002-05-22 Martin Baulig <martin@gnome.org>
20367 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
20368 Removed, this isn't needed anymore.
20370 2002-05-20 Martin Baulig <martin@gnome.org>
20372 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
20373 be underlying type for an enum.
20375 2002-05-20 Miguel de Icaza <miguel@ximian.com>
20377 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
20378 that splits out the loading of just the core types.
20380 * rootcontext.cs (ResolveCore): Split the struct resolution in
20381 two, so we can load the enumeration underlying types before any
20384 * expression.cs (Is): Bandaid until we fix properly Switch (see
20385 bug #24985 for details).
20387 * typemanager.cs (ImplementsInterface): The hashtable will contain
20388 a null if there are no interfaces implemented.
20390 2002-05-18 Miguel de Icaza <miguel@ximian.com>
20392 * cs-parser.jay (indexer_declarator): It is fine to have array
20395 2002-05-17 Miguel de Icaza <miguel@ximian.com>
20397 * typemanager.cs: (RegisterBuilder): New function used to register
20398 TypeBuilders that implement interfaces. Since
20399 TypeBuilder.GetInterfaces (as usual) does not work with lame
20401 (AddUserType): register interfaces.
20403 (ImplementsInterface): Use the builder_to_ifaces hash if we are
20404 dealing with TypeBuilder. Also, arrays are showing up as
20405 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
20406 methods can not be invoked on them!
20408 * ecore.cs (ExplicitReferenceConversionExists): Made public.
20409 (ImplicitReferenceConversionExists): Split out from
20410 StandardConversionExists.
20412 * expression.cs (As): We were only implementing one of the three
20413 cases for the as operator. We now implement them all.
20414 (Is): Implement the various other cases for Is as well.
20416 * typemanager.cs (CACHE): New define used to control if we want or
20417 not the FindMembers cache. Seems to have a negative impact on
20418 performance currently
20420 (MemberLookup): Nested types have full acess to
20421 enclosing type members
20423 Remove code that coped with instance/static returns for events, we
20424 now catch this in RealFindMembers.
20426 (RealFindMembers): only perform static lookup if the instance
20427 lookup did not return a type or an event.
20429 2002-05-17 Miguel de Icaza <miguel@ximian.com>
20431 * assign.cs (CompoundAssign): We pass more semantic information
20432 now to Compound Assignments than we did before: now we have all
20433 the information at hand, and now we resolve the target *before* we
20434 do the expression expansion, which allows the "CacheValue" method
20435 to have the effect we intended (before, a [x] += 1 would generate
20436 two differen ArrayAccess expressions from the ElementAccess,
20437 during the resolution process).
20439 (CompoundAssign.DoResolve): Resolve target and original_source here.
20441 2002-05-16 Miguel de Icaza <miguel@ximian.com>
20443 * expression.cs (ArrayAccess): dropped debugging information.
20445 * typemanager.cs: Small bug fix: I was always returning i_members,
20446 instead of one of i_members or s_members (depending on which had
20449 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
20450 method is invoked before any code generation takes place, and it
20451 is a mechanism to inform that the expression will be invoked more
20452 than once, and that the method should use temporary values to
20453 avoid having side effects
20455 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
20457 * ecore.cs (Expression.CacheTemporaries): Provide empty default
20460 * expression.cs (Indirection, ArrayAccess): Add support for
20461 CacheTemporaries in these two bad boys.
20463 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
20464 ldobj or ldind_ref.
20465 (StoreFromPtr): Handle stobj as well.
20467 * expression.cs (UnaryMutator): Share more code.
20469 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
20470 down: I was not tracking the Filter function as well, which
20471 was affecting the results of the cache.
20473 2002-05-15 Miguel de Icaza <miguel@ximian.com>
20475 * attribute.cs: Remove the hack to handle the CharSet property on
20478 2002-05-14 Miguel de Icaza <miguel@ximian.com>
20480 * attribute.cs (DoResolve): More uglyness, we now only try to
20481 resolve the attribute partially, to extract the CharSet
20482 information (only if we are a StructLayout attribute). Otherwise
20484 (GetExtraTypeInfo): Add some code to conditionally kill in the
20485 future this. I am more and more convinced that the .NET
20486 framework has special code to handle the attribute setting on
20489 * expression.cs (IsParamsMethodApplicable): Revert my previous
20490 foreach change here, it was wrong.
20492 2002-05-13 Miguel de Icaza <miguel@ximian.com>
20494 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
20495 (pp_expr): do not abort on unknown input, just return.
20496 (eval): abort if there are pending chars.
20498 * attribute.cs (Attribute.Resolve): Positional parameters are
20499 optional. Deal with that case.
20501 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
20502 the Ansi/Unicode/Auto information for the type.
20504 (TypeContainer.DefineType): instantiate the EmitContext here, as
20505 we will be using it during the type definition (to resolve
20506 attributes) and during the emit phase.
20508 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
20509 to pull type information out of the attributes
20511 (Attribute.Resolve): track the constructor builder, and allow for
20512 multiple invocations (structs and classes will use this).
20514 * ecore.cs (MemberLookupFinal): new version with all the
20515 parameters customizable.
20517 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
20518 constructors. Return if the result value is null (as the error
20519 would have been flagged already by MemberLookupFinal)
20521 Do not allow instances of abstract classes or interfaces to be
20524 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
20525 We have to compare the assembly property here when dealing with
20526 FamANDAssem and Assembly access modifiers, because we might be
20527 creating an assembly from *modules* (that means that we are not
20528 getting TypeBuilders for types defined in other modules that are
20529 part of this assembly).
20531 (Method.Emit): If the method is marked abstract and has a body,
20534 (TypeContainer.DefineMembers): If both the defined member and the
20535 parent name match are methods, then do not emit any warnings: let
20536 the Method.Define routine take care of flagging warnings. But if
20537 there is a mismatch (method overrides something else, or method is
20538 overriwritten by something, then emit warning).
20540 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
20541 set to null, this means `do not check for the return type on the
20544 (Method.Define): set the return type for the method signature to
20545 null, so that we get methods with the same name and parameters and
20546 different return types. This is used to flag warning 114 (you are
20547 hiding a method, and you probably want to use the new/override
20550 * typemanager.cs (MemberLookup): Implemented proper access
20551 control, closing a long standing set of bug reports. The problem
20552 was that the Framework only has two bits: Public and NonPublic,
20553 and NonPublic includes private and protected methods, but we need
20554 to enforce the FamANDAssem, FamOrAssem and Family.
20556 2002-05-11 Miguel de Icaza <miguel@ximian.com>
20558 * statement.cs (GotoCase): Return true: Ammounts to giving up
20559 knowledge on whether we return or not, and letting the other case
20560 be responsible for it.
20562 2002-05-10 Miguel de Icaza <miguel@ximian.com>
20564 * driver.cs: Do not load directories for each file processed, only
20565 do it if there is a pattern.
20567 * ecore.cs: Report readonly assigns here as well, as we might have
20568 been resolved only by MemberAccess.
20570 (SimpleName.SimpleNameResolve): Also be useful for LValue
20571 resolution. We need this to propagate assign to local readonly variables
20573 * typemanager.cs: Use a ptrhashtable for the criteria, because we
20574 do not want to reuse potential criteria memory.
20576 * class.cs (MyEventBuilder): Set reflected_type;
20578 * ecore.cs (Constantify): Added support for constifying bools.
20580 (RootContext.LookupType): Added a cache for values looked up in
20581 the declaration space.
20583 * typemanager.cs (FindMembers): Now is a front-end to
20584 RealFindMembers, and provides a two-level hashtable-based cache to
20587 15% performance improvement: from 22.5 to 19.2 seconds.
20589 * expression.cs (IsParamsMethodApplicable): use foreach.
20590 (Invocation.DoResolve): ditto.
20591 (New.DoResolve): ditto.
20592 (ArrayCreation.DoResolve): ditto.
20594 * ecore.cs (FindMostEncompassingType): use foreach.
20596 * delegate.cs (NewDelegate.DoResolve): Use foreach
20598 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
20599 (RemoveMethods): use foreach.
20601 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
20602 nested foreach statements instead of for, and also break out of
20603 the inner loop once a match is found.
20605 (Invocation.OverloadResolve): Use foreach, simplify the code.
20607 2002-05-08 Miguel de Icaza <miguel@ximian.com>
20609 * cfold.cs (BinaryFold): During an enumeration evaluation context,
20610 we actually unwrap the expression to allow for extra information
20613 * expression.cs: Use Shr_Un on unsigned operations.
20615 2002-05-08 Ravi Pratap <ravi@ximian.com>
20617 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
20618 applicable operators was not being considered correctly. This closes
20619 the bug Miguel reported.
20621 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
20623 * attribute.cs: check that the type derives from System.Attribute
20624 and report the correct error in that case (moved the duplicate code to
20625 its own method, too).
20627 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
20629 * attribute.cs: lookup attribute type name as the spec says: first the
20630 bare attribute name and then name + "Attribute" (nant compiles with
20631 mcs after this fix).
20633 2002-05-07 Miguel de Icaza <miguel@ximian.com>
20635 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
20636 Because of the way we parse things, we should try to see if a
20637 UIntConstant can fit in an integer.
20639 2002-05-07 Ravi Pratap <ravi@ximian.com>
20641 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
20642 when we are in an explicit context.
20644 (ConvertReferenceExplicit): When converting from Iface type S to Class
20645 T make sure the rules are implemented as an OR.
20647 * parameter.cs (ParameterType): Make it a property for now although the
20648 purpose really isn't anything immediate.
20650 * expression.cs (Is*Applicable): Do better checking on the parameter type
20651 of a ref/out parameter. The ones from the system assemblies are already
20652 marked with the correct type so we don't need to do any correction.
20654 * ecore.cs (StandardConversionExists): Conversion from Interface types to
20655 the object type is standard too so include that.
20657 2002-05-06 Miguel de Icaza <miguel@ximian.com>
20659 * ecore.cs (StandardConversionExists): Augment with missing code:
20660 deal with IntConstant, LongConstants and Enumerations.
20662 * assign.cs: Report the error, instead of failing silently
20664 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
20665 typecontainer that they are declared, because the
20666 typecontainer/namespace will have the list of using clauses that
20667 need to be applied.
20669 Assembly Attributes were escaping the normal registration
20672 (EmitCode): Apply attributes within an EmitContext that represents
20673 the container they were declared on.
20675 * cs-parser.jay: Track bases for structs. How did I get this wrong?
20677 2002-05-06 Ravi Pratap <ravi@ximian.com>
20679 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
20680 Revamp completely - make much cleaner as we now operate only
20683 (FindMostSpecificSource, FindMostSpecificTarget): New methods
20684 to implement the logic detailed in the spec more correctly.
20686 (UserDefinedConversion): Update accordingly.
20688 2002-05-06 Miguel de Icaza <miguel@ximian.com>
20690 * statement.cs: Return flow analysis information up.
20692 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
20695 (token): Do not consume an extra character before calling
20698 2002-05-06 Piers Haken <piersh@friskit.com>
20700 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
20702 2002-05-06 Miguel de Icaza <miguel@ximian.com>
20704 * class.cs (Constructor.Emit): Set the IsStatic flag in the
20705 EmitContext during the instance constructor initializer
20706 resolution, to stop access to instance variables.
20708 This is mandated by the spec, last paragraph of the `constructor
20709 initializers' section.
20711 2002-05-05 Miguel de Icaza <miguel@ximian.com>
20713 * cs-parser.jay, class.cs (Accessor): new class used to represent
20714 an accessor (get or set). In the past we used `null' to represent
20715 a missing accessor. But this is ambiguous because there was no
20716 way to tell in abstract indexers/properties if one of them was
20719 Now there is a way of addressing that.
20721 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
20722 instead of FindMembers.
20724 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
20725 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
20727 * attribute.cs: Treat indexers and properties as the same in terms
20728 of applying attributes
20730 * ecore.cs (FindMostEncompassedType): Use statically initialized
20731 EmptyExpressions()s like we do elsewhere to avoid creating useless
20732 objects (and we take this out of the tight loop).
20734 (GetConversionOperators): Move the code to extract the actual
20735 operators to a separate routine to clean things up.
20737 2002-05-04 Miguel de Icaza <miguel@ximian.com>
20739 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
20740 events are always registered FieldBuilders.
20742 * class.cs (FieldBase): New class shared by Fields
20744 * delegate.cs: If we are a toplevel delegate, use our full name.
20745 If we are a nested delegate, then only use our tail name.
20747 2002-05-02 Ravi Pratap <ravi@ximian.com>
20749 * expression.cs (IsApplicable): Ensure that we add the "&" to
20750 ref/out types before comparing it with the type of the argument.
20752 (IsParamsMethodApplicable): Ditto.
20754 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
20757 * delegate.cs : Handle the case when we have more than one applicable
20758 method. Flag an error only when we finish checking all.
20760 2002-05-02 Miguel de Icaza <miguel@ximian.com>
20762 * expression.cs: Add support for boolean static initializers.
20764 2002-05-01 Miguel de Icaza <miguel@ximian.com>
20766 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
20768 * parameter.cs (ComputeParameterTypes,
20769 ComputeAndDefineParameterTypes): Better error handling: now we
20770 clear the `types' cache if we fail during any of the type lookups.
20771 We also return the status code correctly to our caller
20773 * delegate.cs: If we fail to define a delegate, abort the extra
20776 * expression.cs (Binary.ResolveOperator): for
20777 operator==(object,object) and operator !=(object, object) we also
20778 have to verify that there is an implicit conversion from one to
20781 (ArrayAccess.DoResolve): Array Access can operate on
20784 2002-04-30 Miguel de Icaza <miguel@ximian.com>
20786 * assign.cs (CompoundAssign): A new class used as a "flag" that
20787 the assignment actually is happening as part of a compound
20788 assignment operator.
20790 During compound assignment, a few new rules exist to enable things
20797 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
20798 to the type of x) if y is implicitly convertible to the type of x,
20799 and the operator is a builtin operator and the return type of the
20800 operator is explicitly convertible to the type of x.
20802 * rootcontext.cs: Reset warning level to 2. 4 catches various
20803 "interesting" features in mcs, we must clean this up at some
20804 point, but currently am trying to kill other bugs ;-)
20806 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
20807 in container classes as well.
20809 * expression.cs (Binary.ResolveOperator): Handle string case
20810 before anything else (as operator overloading does emit an error
20811 before doing anything else).
20813 This code could go away when we move to a table driven model, but
20814 i could not come up with a good plan last night.
20816 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
20818 * typemanager.cs (CSharpName): reimplementation using regex.
20819 * class.cs: added null check for fields in Emit
20820 * rootcontext.cs: set warninglevel to 4
20822 2002-04-29 Miguel de Icaza <miguel@ximian.com>
20824 * typemanager.cs (CSharpName): reimplemented with Lupus
20827 2002-04-28 Miguel de Icaza <miguel@ximian.com>
20829 * statement.cs (If): correclty implement Resolve, because we were
20830 not catching sem errors in there. The same process is needed
20832 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
20835 (Statement.Warning_DeadCodeFound): Factorize code.
20836 (While): Report dead code here too.
20838 (Statement): Added Resolve virtual method to allow
20839 for resolution split from the emit code.
20841 2002-04-26 Miguel de Icaza <miguel@ximian.com>
20843 * statement.cs (EmitBoolExpression): No longer try to resolve the
20845 (MakeBoolean): New utility function that resolve, implicitly
20846 converts to boolean and tags the expression.
20849 (If, Do): Implement dead code elimination.
20850 (While): Implement loop inversion
20852 (Do, While, For, If): Resolve the expression prior to calling our
20855 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
20858 - added method Report28 (warning: program has more than one entry point)
20859 - added method IsEntryPoint, implements paragraph 10.1 of the spec
20860 - modified method Method.Define, the part at the end of the method
20862 * rootcontext.cs: added static public Location EntryPointLocation;
20864 * ../errors/cs0028.cs : Add test case for the above warning.
20867 - modified method CSharpName to allow arrays of primitive type to
20868 be printed nicely (e.g. instead of System.Int32[][] it now prints
20870 - added method CSharpSignature: returns the signature of a method
20871 in string format to be used in reporting errors, warnings, etc.
20873 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
20876 2002-04-26 Ravi Pratap <ravi@ximian.com>
20878 * delegate.cs (Define): Fix extremely silly bug where I was
20879 setting the type of the 'object' parameter of the BeginInvoke
20880 method to System.IAsyncResult instead of System.Object ;-)
20882 2002-04-26 Miguel de Icaza <miguel@ximian.com>
20884 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
20887 (Constructor.Emit): return if we fail to initialize the
20888 constructor. Another door closed!
20890 * expression.cs (New.DoResolve): Improve error message (from -6 to
20891 1501). Use DeclaredOnly lookup to find the exact constructor.
20893 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
20894 loop. This is useful.
20896 * cs-parser.jay: Adjust the default parameters so that destructors
20897 have the proper signature.
20899 2002-04-26 Martin Baulig <martin@gnome.org>
20901 * driver.cs (LoadAssembly): If `assembly' contains any characters
20902 which are only valid in path names and not in assembly names
20903 (currently slash, backslash and point), use Assembly.LoadFrom ()
20904 instead of Assembly.Load () on the `assembly' (before iteration
20905 over the link_paths).
20907 2002-04-26 Martin Baulig <martin@gnome.org>
20909 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
20911 2002-04-25 Miguel de Icaza <miguel@ximian.com>
20913 * class.cs (Property): use the new typemanager.MemberLookup
20915 (TypeContainer.MemberLookup): Implement using the
20916 TypeManager.MemberLookup now.
20918 * typemanager.cs: Make MemberLookup a function of the TypeManager,
20919 and return MemberInfos, so that these can be used without an
20920 EmitContext (what we had before).
20922 2002-04-24 Miguel de Icaza <miguel@ximian.com>
20924 * expression.cs: Fix the case where the argument to params if the
20925 type of the params. I omitted handling this before. Fixed
20927 2002-04-22 Miguel de Icaza <miguel@ximian.com>
20929 * driver.cs: Call BootCorlib_PopulateCoreType
20931 * class.cs (Property.CheckBase): Check for properties only, not
20934 * interface.cs: Temporary hack: try/catch around the
20935 CustomAttributeBuilder, because I am getting an exception that I
20938 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
20939 types whose definitions are required to be there (attributes are
20940 defined before standard types).
20942 Compute definitions as we boot the various types, as they are used
20943 immediately (value_type class will need object_type, but if we do
20944 not initialize object_type, we will pass a null, which will let
20945 the runtime pick the System.Object from the existing corlib, which
20946 is not what we want).
20948 2002-04-22 Patrik Torstensson <totte@labs2.com>
20950 * cs-tokenizer.cs: fixed a number of trim() issues.
20952 2002-04-22 Ravi Pratap <ravi@ximian.com>
20954 * expression.cs (Argument.Type): Ensure that we return the correct
20955 type when we have out or ref parameters [in which case we
20958 2002-04-22 Miguel de Icaza <miguel@ximian.com>
20960 * class.cs (Property, Indexer): Allow extern modifier in there.
20962 * typemanager.cs (InitBaseTypes): Initializes object_type and
20963 value_type, since those will be used early on during the bootstrap
20964 process to compile corlib.
20966 (InitCoreTypes): Move code from here to InitBaseTypes.
20968 2002-04-21 Miguel de Icaza <miguel@ximian.com>
20970 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
20971 single-dimension arrays as using the ldlen opcode.
20973 Daniel Lewis discovered this optimization.
20975 * typemanager.cs: Add signature for System.Array::get_Length
20977 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20979 * statement.cs: report the error when the foreach does not apply to an
20980 array nor a collection.
20982 2002-04-19 Miguel de Icaza <miguel@ximian.com>
20984 * expression.cs: Add implicit conversions to the operator ~.
20986 * constant.cs (DecimalConstant.Emit): Emit decimal value.
20988 * typemanager.cs: Locate the decimal constructor.
20990 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20992 * attribute.cs: use the new property of TypeOf.
20993 * expression.cs: added 'get' property around typearg.
20995 These changes fix a build breaker reported by NickD. Is this the
20996 correct way to fix? If not, please, revert my changes and make it
20999 2002-04-17 Miguel de Icaza <miguel@ximian.com>
21001 * attribute.cs: Add support for typeof in attribute invocations.
21002 I am not sure that this is right though.
21004 2002-04-14 Duncan Mak <duncan@ximian.com>
21006 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
21007 Binary.Operator.Division case.
21009 2002-04-13 Ravi Pratap <ravi@ximian.com>
21011 * class.cs (DefineType): Ensure that we do a proper check on
21012 attribute types and also register it with the TypeManager.
21014 (TypeContainer.Targets): The default for attribute types is
21015 AttributeTargets.All.
21017 * attribute.cs (ApplyAttributes): Registering the attribute type
21018 is done elsewhere, not when we discover we have a Usage attribute.
21020 2002-04-12 Ravi Pratap <ravi@ximian.com>
21022 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
21023 and get rid of is_delegate parameter.
21025 * everywhere : update.
21027 2002-04-12 Ravi Pratap <ravi@ximian.com>
21029 * cs-parser.jay (compilation_unit): Revamp completely to use
21030 some new ideas that I got from Rhys' grammar to solve the problems
21031 with assembly level attributes.
21033 (outer_declaration): New grammar production.
21035 (attribute_sections): Add.
21037 (opt_attributes): Base on attribute_sections
21039 (namespace_declaration): Allow opt_attributes to tackle the case
21040 when we have assembly level attributes - we are clever in this
21043 * attribute.cs (ApplyAttributes): Do not worry about assembly
21044 attributes in the non-global context.
21046 * rootcontext.cs (AddGlobalAttributes): Go back to using this
21047 instead of SetGlobalAttributes.
21049 * class.cs, rootcontext.cs : Ensure we define and generate
21050 attribute types before anything else.
21052 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
21053 and flag the new error -20 for the case when the attribute type
21054 does not have valid targets specified. csc does not catch this.
21056 * ../errors/errors.txt : update for error # -20
21058 2002-04-11 Ravi Pratap <ravi@ximian.com>
21060 * support.cs (InternalParameters.ParameterModifier): Do some null
21061 checking and return sane values.
21063 * class.cs (Method.Define): If we are a PInvoke method, ensure
21064 that we are static and extern. Report error # 601
21066 * ../errors/cs0601.cs : Add test case for the above error.
21068 2002-04-07 Ravi Pratap <ravi@ximian.com>
21070 * rootcontext.cs (attribute_types): We need to keep type of
21071 all attribute types separately and emit code for them first.
21073 (RegisterAttribute) : Implement.
21075 * class.cs (DefineType): Check if the current Type is a custom
21076 attribute type and register it accordingly.
21078 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
21079 adding the first attribute twice and rename to
21081 (SetGlobalAttributes): this.
21083 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
21086 * attribute.cs (ApplyAttributes): Take an additional argument telling us
21087 if we are processing global arguments. Hmm, I am unsure of this.
21089 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21091 * expression.cs: added static array of strings to avoid calling
21092 Enum.ToString () for Operator in Binary. Significant recover of
21095 2002-04-10 Miguel de Icaza <miguel@ximian.com>
21097 * class.cs (FindMembers): Allow the Builders of the various
21098 members to be null. If they are skip them. This only happens
21099 during the PInvoke declaration.
21101 2002-04-09 Miguel de Icaza <miguel@ximian.com>
21103 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
21104 failure, so we do not keep going afterwards.
21106 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
21107 wanted to pass `false' as the `is_delegate' argument. If this is
21108 the case, why not use delegate_type == null to mean `is_delegate =
21109 false' and anything else as is_delegate = true.
21111 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
21113 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
21114 code for the section, not the beginning of the tests.
21116 2002-04-08 Miguel de Icaza <miguel@ximian.com>
21118 * cfold.cs: Handle operator + (Enum x, Underlying x)
21120 * expression.cs (Binary): same. Warn about errors where we have
21121 Enum/Enum in operator + as well.
21123 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
21126 - added support for switch(bool)
21127 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
21128 - add TableSwitchEmit() to handle table-based switch statements
21130 2002-04-05 Ravi Pratap <ravi@ximian.com>
21132 * expression.cs (Invocation.OverloadResolve): Factor out code which
21133 does parameter compatibility checking with arguments so that we can
21134 re-use the code even from Delegate.VerifyApplicability
21136 (VerifyArgumentsCompat): Move above code here.
21138 * delegate.cs (VerifyApplicability): Get rid of duplicate code
21139 and instead make a call to the above method.
21141 2002-03-31 Ravi Pratap <ravi@ximian.com>
21143 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
21144 We use it to keep track of classes which are attribute types.
21146 2002-04-02 Miguel de Icaza <miguel@ximian.com>
21148 * delegate.cs (Delegate.Define): Correctly define the types in the
21149 presence of fixed and array parameters.
21151 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
21154 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
21155 include NonPublic after the first iteration.
21157 * class.cs (Indexer.CheckBase): Only check if both parents are
21160 * cs-parser.jay (accessor_body): If empty, set to null.
21162 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
21163 same code path here to resolve constants names that we did have in
21164 MemberAccess.DoResolve. There is too much code duplicated here.
21166 2002-04-01 Miguel de Icaza <miguel@ximian.com>
21168 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
21170 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
21173 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
21174 tokens, numbers and strings.
21176 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
21179 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
21180 asyncronous parameters and the regular parameters.
21182 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
21183 specify the target directory.
21185 * expression.cs: (This.DoResolve): Simplify
21186 (As.Emit): Optimize, do not generate IsInst if the expression is
21187 always of the given type.
21189 (Is.DoResolve): Bug fix, we were reporting both always/never for
21192 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
21193 creating too many unnecessary arrays.
21195 2002-03-31 Miguel de Icaza <miguel@ximian.com>
21197 * class.cs (EmitFieldInitializer): Use Assign expression to assign
21198 fields instead of rolling our own initializer. Takes care of all
21199 implicit conversions, and drops unnecessary static checks/argument.
21201 2002-03-31 Dick Porter <dick@ximian.com>
21203 * driver.cs: use the GetDirectories() return values properly, and
21204 use "/" as path separator.
21206 2002-03-30 Miguel de Icaza <miguel@ximian.com>
21208 * expression.cs (Unary): Optimize - - expr into expr.
21209 (Binary): Optimize a + (-b) into a -b.
21211 * codegen.cs (CodeGen): Made all methods static.
21213 2002-03-29 Miguel de Icaza <miguel@ximian.com>
21217 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
21218 TypeBuilder property.
21220 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
21223 * tree.cs: Removed the various RecordXXXX, and replaced with a
21224 single RecordDecl. Removed all the accessor methods, and just
21225 left a single access point Type
21227 * enum.cs: Rename DefineEnum to DefineType.
21229 * decl.cs: New abstract method `DefineType' used to unify the
21230 Defines for Enumerations, Interfaces, TypeContainers and
21233 (FindType): Moved LookupInterfaceOrClass here. Moved the
21234 LookupBaseClasses method that used to live in class.cs and
21235 interface.cs here, and renamed to FindType.
21237 * delegate.cs: Implement DefineType. Take advantage of the
21238 refactored pattern for locating the parent builder without taking
21239 the parent_builder argument (which we know does not work if we are
21240 nested, and triggering a toplevel definition).
21242 2002-03-28 Miguel de Icaza <miguel@ximian.com>
21244 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
21245 accessibility of a member has changed during override and report
21248 * class.cs (Method.Define, Property.Define): Only complain on
21249 overrides if the method is private, any other accessibility is
21250 fine (and since we just checked the permission is the same, we are
21253 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
21254 and elif are processed always. The other pre-processing
21255 directives are only processed if we are "taking" the path
21257 2002-03-29 Martin Baulig <martin@gnome.org>
21259 * class.cs (Method.Emit): Only emit symbolic debugging info if the
21260 current location is not Null.
21262 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
21263 a separate method so we can profile it.
21265 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
21266 `span.Seconds' are just seconds, but no minutes or hours.
21267 (MainDriver): Profile the CodeGen.SaveSymbols calls.
21269 2002-03-28 Miguel de Icaza <miguel@ximian.com>
21271 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
21272 Remove the gratuitous set of Final:
21274 // If an interface implementation, then we can set Final.
21275 if (((flags & MethodAttributes.Abstract) == 0) &&
21276 implementing.DeclaringType.IsInterface)
21277 flags |= MethodAttributes.Final;
21279 I do not know what I was smoking when I used that.
21282 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
21283 step into fixing the name resolution issues for delegates and
21284 unifying the toplevel name resolution.
21286 2002-03-28 Martin Baulig <martin@gnome.org>
21288 * class.cs (Method.Emit): If we have a symbol writer, call its
21289 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
21290 tell it about the current method.
21292 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
21293 writer that we're going to emit the first byte of IL code for a new
21294 statement (a new source line).
21295 (EmitContext.EmitTopBlock): If we have a symbol writer, call
21296 EmitContext.Mark() before emitting any code.
21298 * location.cs (SymbolDocument): Return null when we're Null.
21300 * statement.cs (Statement): Moved the `Location loc' variable here.
21301 (Statement.EmitBoolExpression): If we have a symbol writer, call
21302 ec.Mark() before emitting any code to tell it that we're at the
21303 beginning of a new statement.
21304 (StatementExpression): Added `Location' argument to the constructor.
21305 (Block): Added public readonly variable `StartLocation' and public
21306 variable `EndLocation'. The latter is to be set using SetEndLocation().
21307 (Block): Added constructor which takes a start and end location.
21308 (Block.SetEndLocation): New method. This sets the end location.
21309 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
21310 local variables we create.
21311 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
21312 each statement and do also mark the begin and end of the block.
21314 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
21315 tell it the current lexer.Location, use Location.Null for the end of the
21317 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
21318 current block, set its end location using SetEndLocation().
21319 (statement_expression): StatementExpression constructor now takes the
21320 lexer.Location as additional argument.
21321 (for_statement, declare_local_variables): Likewise.
21322 (declare_local_variables): When creating a new implicit block, use the
21323 new Block constructor and pass it the lexer.Location.
21325 2002-03-28 Miguel de Icaza <miguel@ximian.com>
21327 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
21328 members also on the parent interfaces recursively.
21330 2002-03-27 Miguel de Icaza <miguel@ximian.com>
21332 * report.cs: Use new formats, since Gonzalo finished the missing
21335 * expression.cs (Binary.ResolveOperator): added missing operator|
21336 operator& and operator^ for bool/bool.
21338 * cs-parser.jay: CheckDef now takes a Location argument that is
21339 used to report errors more precisly (instead of reporting the end
21340 of a definition, we try to track something which is a lot closer
21341 to the source of the problem).
21343 * cs-tokenizer.cs: Track global token use, so we can properly flag
21344 the use of #define/#undef after the first token has been seen.
21346 Also, rename the reportXXXX to Error_DescriptiveName
21348 * decl.cs (DeclSpace.IsTopLevel): Move property here from
21349 TypeContainer, so that Enum and Interface can use this too.
21351 * class.cs (TypeContainer.LookupInterfaceOrClass,
21352 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
21353 `builder' argument. Typically this was used to pass the parent
21354 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
21357 The problem is that a nested class could trigger the definition of
21358 a toplevel class, and the builder would be obviously wrong in that
21361 So we drop this argument, and we compute dynamically the
21362 TypeBuilder/ModuleBuilder (the correct information was available
21363 to us anyways from DeclSpace.Parent)
21365 * interface.cs (Interface.DefineInterface): Drop builder
21366 parameter cleanup like class.cs
21368 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
21371 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
21374 (Try.Emit): Propagate the returns value from the statement.
21376 (Return.Emit): Even if we are leavning
21378 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
21380 * modifiers.cs: Fix the computation of MethodAttributes flags.
21382 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
21384 * driver.cs: allow compilation of files that start with '/'.
21385 Add a default case when checking the argument of --target.
21387 2002-03-25 Miguel de Icaza <miguel@ximian.com>
21389 * interface.cs: Implement the same search algorithm for types in
21390 the interface code.
21392 * delegate.cs: Do not allow multiple definition.
21394 * Recovered ChangeLog that got accidentally amputated
21396 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
21398 * rootcontext.cs: Load manually enum to allow core classes to
21399 contain enumerations.
21401 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
21402 Update to new static methods in TypeManager.
21404 * typemanager.cs (GetMethod, GetConstructor): Use our
21405 implementation of FindMembers to find the members, since during
21406 corlib compilation, the types are TypeBuilders and GetMethod and
21407 GetConstructor do not work.
21409 Make all methods in TypeManager static.
21411 (InitCodeHelpers): Split the functionality from
21412 the InitCodeTypes function.
21414 * driver.cs: Call InitCodeHelpers after we have populated the
21417 * cs-parser.jay (delegate_declaration): we did not used to compute
21418 the delegate name correctly for void delegates.
21420 2002-03-24 Miguel de Icaza <miguel@ximian.com>
21422 * rootcontext.cs (RootContext): Init the interface_resolve_order
21423 and type_container_resolve_order always.
21425 (ResolveCore, BootstrapCorlib_ResolveClass,
21426 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
21427 compiler when compiling with --nostdlib
21429 * class.cs (TypeContainer.DefineType): Check that our parent is
21430 not null. This test is most important when we are bootstraping
21433 * codegen.cs: Split out the symbol writing code.
21435 2002-03-25 Martin Baulig <martin@gnome.org>
21437 * driver.cs (-g): Made -g an alias for --debug.
21439 2002-03-24 Martin Baulig <martin@gnome.org>
21441 * codegen.cs (SymbolWriter): New public variable. Returns the
21442 current symbol writer.
21443 (CodeGen): Added `bool want_debugging_support' argument to the
21444 constructor. If true, tell the ModuleBuild that we want debugging
21445 support and ask it for the ISymbolWriter.
21446 (Save): If we have a symbol writer, call it's Close() method after
21447 saving the assembly.
21449 * driver.c (--debug): New command line argument to create a
21450 debugger information file.
21452 * location.cs (SymbolDocument): New public property. Returns an
21453 ISymbolDocumentWriter object for the current source file or null
21454 if we don't have a symbol writer.
21456 2002-03-21 Miguel de Icaza <miguel@ximian.com>
21458 * driver.cs (LoadAssembly): Correctly return when all the paths
21459 have been tried and not before.
21461 * statement.cs (Switch.Emit): return the actual coverage for this
21462 statement (returns/not-returns)
21464 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
21465 switch of the statement if we are the last switch section. That
21466 kills two problems: try/catch problems (we used to emit an empty
21467 nop at the end) and switch statements where all branches would
21470 2002-03-19 Miguel de Icaza <miguel@ximian.com>
21472 * driver.cs: Add default assemblies (the equivalent to the
21473 Microsoft CSC.RSP file)
21475 * cs-tokenizer.cs: When updating `cols and setting it to zero,
21476 also update tokens_seen and set it to false.
21478 * driver.cs: Implement --recurse for Mike.
21480 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
21481 correctly splitting out the paths.
21483 2002-03-18 Miguel de Icaza <miguel@ximian.com>
21485 * interface.cs (Interface.PopulateProperty): Instead of using
21486 `parent' as the declaration space for the set parameters, use
21489 * support.cs (InternalParameters): InternalParameters constructor
21490 takes a DeclSpace instead of a TypeContainer.
21492 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
21493 types are being initialized, load the address of it before calling
21496 (New): Provide a mechanism to disable the generation of local
21497 value type temporaries when the caller will be providing us with
21498 an address to store it.
21500 (ArrayCreation.EmitDynamicInitializers): Use it.
21502 2002-03-17 Miguel de Icaza <miguel@ximian.com>
21504 * expression.cs (Invocation.EmitArguments): Only probe for array
21505 property if there is more than one argument. Sorry about that.
21507 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
21508 empty param arrays.
21510 * class.cs (Method.LabelParameters): Fix incorrect code path that
21511 prevented the `ParamArrayAttribute' from being applied to the
21514 2002-03-16 Miguel de Icaza <miguel@ximian.com>
21516 * support.cs (ReflectionParameters): Correctly compute whether the
21517 last argument is a params array. Fixes the problem with
21520 * typemanager.cs: Make the assemblies array always be non-null
21521 (empty, but non-null)
21523 * tree.cs (RecordDecl): New function that abstracts the recording
21524 of names. This reports error 101, and provides a pointer to the
21525 previous declaration. Fixes a crash in the compiler.
21527 * cs-parser.jay (constructor_declaration): Update to new grammar,
21528 and provide a constructor_body that can be empty.
21530 2002-03-15 Miguel de Icaza <miguel@ximian.com>
21532 * driver.cs: Add support for --resources.
21534 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
21535 Make all types for the various array helper methods be integer.
21537 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
21538 CheckState to ConvCast.
21540 (ConvCast): Now it takes a `checked' state argument, to avoid
21541 depending on the emit context for the conversion, and just using
21542 the resolve time setting.
21544 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
21545 instead of Invocation.EmitArguments. We do not emit the original
21546 arguments, instead we emit those which have been converted to
21547 unsigned int expressions.
21549 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
21551 * codegen.cs: ditto.
21553 * expression.cs (LocalVariableReference): Drop the use of the
21554 Store function that depended on the variable index.
21556 * statement.cs (VariableInfo): Drop the `Idx' property from this
21557 class, as this is not taking into account the indexes for
21558 temporaries tat we generate during the execution, getting the
21561 * class.cs: First emit class initializers, then call the parent
21564 * expression.cs (Binary): Fix opcode emision.
21565 (UnaryMutator.EmitCode): Support checked code generation
21567 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
21568 matches for events for both the Static and Instance scans,
21569 pointing to the same element. Fix that.
21571 2002-03-14 Miguel de Icaza <miguel@ximian.com>
21573 * rootcontext.cs (ResolveTree): Always set the
21574 interface_resolve_order, because nested interfaces will be calling
21577 * class.cs (GetInterfaceOrClass): Track the same resolution
21578 process used by TypeManager.LookupType. This fixes the nested
21579 type lookups in class declarations (separate path from
21582 (TypeContainer.DefineType): Also define nested interfaces.
21583 (TypeContainer.RegisterOrder): New public function used to
21584 register the order in which child interfaces need to be closed.
21586 Nested interfaces need to be closed after their parents have been
21589 * interface.cs (InterfaceAttr): Put all the logic for computing
21590 the interface attribute here.
21592 (DefineInterface): Register our interface order with the
21593 RootContext or with the TypeContainer depending on the case.
21595 2002-03-12 Miguel de Icaza <miguel@ximian.com>
21597 * cs-parser.jay: rework foreach statement to work with the new
21598 changes to the policy on SimpleNames.
21600 * report.cs: support Stacktrace on warnings as well.
21602 * makefile: drop --unsafe and /unsafe from the compile.
21604 2002-03-13 Ravi Pratap <ravi@ximian.com>
21606 * ecore.cs (StandardConversionExists): Modify to take an Expression
21607 as the first parameter. Ensure we do null -> reference type conversion
21610 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
21611 temporary Expression objects.
21613 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
21615 * interface.cs: workaround bug in method overloading resolution
21616 (there is already a bugzilla bug for it).
21618 2002-03-12 Miguel de Icaza <miguel@ximian.com>
21620 We could also solve this problem by having a separate path for
21621 performing type lookups, instead of DoResolve, we could have a
21622 ResolveType entry point, and only participating pieces of the
21623 production (simplename, deref, array) would implement this.
21625 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
21626 signal SimpleName to only resolve type names and not attempt to
21627 resolve anything else.
21629 * expression.cs (Cast): Set the flag.
21631 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
21633 * class.cs: Only report 108 if there is no `new' modifier.
21635 * cs-parser.jay: rework foreach statement to work with the new
21636 changes to the policy on SimpleNames.
21638 * report.cs: support Stacktrace on warnings as well.
21640 * makefile: drop --unsafe and /unsafe from the compile.
21642 2002-03-11 Miguel de Icaza <miguel@ximian.com>
21644 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
21645 lookups here, instead of doing that at parse time. This means
21646 that our grammar will not introduce `LocalVariableReferences' as
21647 expressions at this point. That solves the problem of code like
21651 static void Main ()
21655 This is only half the fix. The full fix requires parameters to
21656 also be handled in this way.
21658 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
21659 makes the use more obvious of the DeclSpace. The
21660 ec.TypeContainer.TypeBuilder is now only used to pull the
21661 TypeBuilder for it.
21663 My theory is that I can get rid of the TypeBuilder completely from
21664 the EmitContext, and have typecasts where it is used (from
21665 DeclSpace to where it matters).
21667 The only pending problem is that the code that implements Aliases
21668 is on TypeContainer, and probably should go in DeclSpace.
21670 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
21671 lookups here, instead of doing that at parse time. This means
21672 that our grammar will not introduce `LocalVariableReferences' as
21673 expressions at this point. That solves the problem of code like
21677 static void Main ()
21681 This is only half the fix. The full fix requires parameters to
21682 also be handled in this way.
21684 * class.cs (Property.DefineMethod): When implementing an interface
21685 method, set newslot, when implementing an abstract method, do not
21686 set the flag (before we tried never setting it, or always setting
21687 it, which is the difference).
21688 (Indexer.DefineMethod): same.
21689 (Method.DefineMethod): same.
21691 * ecore.cs: Only set the status used flag if we get back a Field.
21693 * attribute.cs: Temporary hack, so Paolo can keep working.
21695 2002-03-08 Ravi Pratap <ravi@ximian.com>
21697 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
21698 the unmanaged type in the case we have a MarshalAs attribute.
21700 (Resolve): Handle the case when we are parsing the special MarshalAs
21701 attribute [we need to store the unmanaged type to use later]
21703 * typemanager.cs (marshal_as_attr_type): Built in type for the
21704 MarshalAs Attribute.
21706 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
21707 on parameters and accordingly set the marshalling info.
21709 2002-03-09 Miguel de Icaza <miguel@ximian.com>
21711 * class.cs: Optimizing slightly by removing redundant code after
21712 we switched to the `NoTypes' return value.
21713 (Property.DefineMethod): use NoTypes here too.
21715 This fixes the bug I introduced in my last batch of changes.
21717 2002-03-05 Ravi Pratap <ravi@ximian.com>
21719 * tree.cs (RecordEnum): Add. We now keep track of enums too.
21721 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
21722 Enums since those are types too.
21724 * cs-parser.jay (enum_declaration): Record enums as we parse them.
21726 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
21727 thanks to a call during the lookup process.
21729 2002-03-07 Miguel de Icaza <miguel@ximian.com>
21731 * statement.cs (Foreach): Lots of work to accomodate a particular
21732 kind of foreach statement that I had not kept in mind. It is
21733 possible to have foreachs on classes that provide a GetEnumerator
21734 method that return objects that implement the "pattern" for using
21735 a foreach, there is no need to support GetEnumerator
21738 This is needed to compile nant.
21740 * decl.cs: Only report 114 if the member is not `Finalize' and if
21741 the warning level is at least 2.
21743 * class.cs: Moved the compare function from Method to
21746 (MethodSignature.InheritableMemberSignatureCompare): Add new
21747 filter function that is used to extract inheritable methods from a
21750 (Method.Define): Use the new `inheritable_method_signature_filter'
21753 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
21756 2002-03-06 Miguel de Icaza <miguel@ximian.com>
21758 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
21760 * cs-parser.jay: Add opt_semicolon to the interface declaration.
21762 * expression.cs: Pass location information to
21763 ConvertImplicitStandard.
21765 * class.cs: Added debugging code to track return values from
21768 2002-03-05 Miguel de Icaza <miguel@ximian.com>
21770 * expression.cs (Is.DoResolve): If either side of the `is' is an
21771 interface, do not flag the warning.
21773 * ecore.cs (ImplicitReferenceConversion): We need a separate test
21776 * report.cs: Allow for --fatal to be used with --probe.
21778 * typemanager.cs (NoTypes): Move the definition for the empty Type
21781 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
21783 (TypeContainer.DefineProxy): New function used to proxy to parent
21784 implementations when implementing interfaces.
21785 (TypeContainer.ParentImplements): used to lookup if our parent
21786 implements a public function that is required by an interface.
21787 (TypeContainer.VerifyPendingMethods): Hook this up.
21789 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
21790 `modules' and `assemblies' arraylists into arrays. We only grow
21791 these are the very early start up of the program, so this improves
21792 the speedof LookupType (nicely measured).
21794 * expression.cs (MakeByteBlob): Replaced unsafe code with
21795 BitConverter, as suggested by Paolo.
21797 * cfold.cs (ConstantFold.Binary): Special case: perform constant
21798 folding of string concatenation, but if either side is a string,
21799 and the other is not, then return null, and let the runtime use
21800 the concatenation on the string plus the object (using
21801 `Object.ToString').
21803 2002-03-04 Miguel de Icaza <miguel@ximian.com>
21805 Constant Folding has been implemented now.
21807 * expression.cs (Unary.Reduce): Do not throw an exception, catch
21808 the error instead on types that are not supported in one's
21811 * constant.cs (Constant and all children): New set of functions to
21812 perform implict and explicit conversions.
21814 * ecore.cs (EnumConstant): Implement the new functions to perform
21815 conversion by proxying to the child expression.
21817 * codegen.cs: (ConstantCheckState): Constant evaluation has its
21818 own separate setting that can not be turned off from the command
21819 line using --unchecked or --checked and is only controlled using
21820 the checked/unchecked statements and expressions. This setting is
21821 used by the constant folder to flag errors.
21823 * expression.cs (CheckedExpr, UncheckedExpr): Set the
21824 ConstantCheckState as well.
21826 During Resolve, they also have to flag the state, because the
21827 constant folder runs completely in the Resolve phase.
21829 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
21832 2002-03-01 Miguel de Icaza <miguel@ximian.com>
21834 * cfold.cs: New file, this file contains the constant folder.
21836 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
21837 argument to track whether we are using the resulting address to
21838 load or store a value and provide better error messages.
21840 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
21841 new AddressOf arguments.
21843 * statement.cs (Foreach.EmitCollectionForeach): Update
21845 * expression.cs (Argument.Emit): Call AddressOf with proper
21846 arguments to track usage.
21848 (New.DoEmit): Call AddressOf with new arguments.
21850 (Unary.Emit): Adjust AddressOf call.
21852 2002-03-01 Ravi Pratap <ravi@ximian.com>
21854 * cs-parser.jay (member_access): Change the case for pre-defined types
21855 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
21858 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
21861 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
21862 essentially like methods and apply attributes like MethodImplOptions to them too.
21864 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
21867 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
21868 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
21871 * Update code everywhere accordingly.
21873 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
21875 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
21877 2002-02-28 Ravi Pratap <ravi@ximian.com>
21879 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
21880 try performing lookups against those instead of jumping straight into using
21881 the 'using' clauses.
21883 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
21885 (LookupType): Perform lookups in implicit parents too.
21887 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
21888 sequence as RootContext.LookupType.
21890 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
21891 the various cases of namespace lookups into this method.
21893 2002-03-01 Miguel de Icaza <miguel@ximian.com>
21895 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
21896 in positional arguments)
21898 * class.cs (Operator): Update the AllowedModifiers to contain
21901 * cs-parser.jay: Update operator declaration to allow for the
21902 operator body to be empty.
21904 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
21907 2002-02-27 Miguel de Icaza <miguel@ximian.com>
21909 * class.cs (Method.Emit): Label parameters.
21911 * driver.cs: Return 1 or 0 as the program exit code.
21913 2002-02-26 Miguel de Icaza <miguel@ximian.com>
21915 * expression.cs: Special case the `null' object when trying to
21916 auto-compute the type, as anything can be explicitly converted to
21919 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
21920 spotting this Paolo.
21922 (Expression.ImplicitNumericConversion): Perform comparissions of
21923 the type using the underlying type in the case of an enumeration
21924 rather than using the enumeration type for the compare.
21926 Cope with the underlying == type case, which is not possible to
21929 (Expression.ConvertNumericExplicit): Perform comparissions of
21930 the type using the underlying type in the case of an enumeration
21931 rather than using the enumeration type for the compare.
21933 * driver.cs: If the user does not supply an extension, assume .exe
21935 * cs-parser.jay (if_statement): Rewrote so that we can track the
21936 location for the if statement.
21938 * expression.cs (Binary.ConstantFold): Only concat strings when
21939 the operation is "+", not everything ;-)
21941 * statement.cs (Statement.EmitBoolExpression): Take a location
21943 (If, While, Do): Track location.
21945 * expression.cs (Binary.ResolveOperator): In the object + string
21946 case, I was missing a call to ConvertImplicit
21948 2002-02-25 Ravi Pratap <ravi@ximian.com>
21950 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
21951 Location arguments. Ensure we use RootContext.LookupType to do our work
21952 and not try to do a direct Type.GetType and ModuleBuilder.GetType
21954 * interface.cs (PopulateMethod): Handle the type of the parameter being
21957 * expression.cs (Invocation.BetterFunction): Handle the case when we
21958 have a params method with no fixed arguments and a call is made with no
21961 2002-02-25 Miguel de Icaza <miguel@ximian.com>
21963 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
21964 the verbatim-string-literal
21966 * support.cs (InternalParameters.ParameterModifier): handle null
21968 (InternalParameters.ParameterType): ditto.
21970 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
21971 duplicating the name of the variable parameter.
21972 (GetParameterByName): Fix bug where we were not looking up array
21973 paramters if they were the only present (thanks Paolo!).
21974 (GetParameterInfo): We only have an empty set of types if both
21975 fixed and array are set to null.
21976 (GetParameterInfo-idx): Handle FixedParameter == null
21978 * cs-parser.jay: Handle the case where there is no catch
21979 statements (missing null test).
21981 2002-02-22 Miguel de Icaza <miguel@ximian.com>
21983 * driver.cs (MainDriver): Be conservative on our command line
21986 Catch DirectoryNotFoundException when calling GetFiles.
21988 (SplitPathAndPattern): Used to split the input specification into
21989 a path and a pattern that we can feed to Directory.GetFiles.
21991 2002-02-21 Miguel de Icaza <miguel@ximian.com>
21993 * statement.cs (Fixed): Implement the last case of the Fixed
21994 statement (string handling).
21996 * expression.cs (StringPtr): New class used to return a char * to
21997 a string; Used by the Fixed statement.
21999 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
22001 * expression.cs (Binary.ResolveOperator): Remove redundant
22002 MemberLookup pn parent type.
22003 Optimize union call, we do not need a union if the types are the same.
22004 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
22007 Specialize the use of MemberLookup everywhere, instead of using
22008 the default settings.
22010 (StackAlloc): Implement stackalloc keyword.
22012 * cs-parser.jay: Add rule to parse stackalloc.
22014 * driver.cs: Handle /h, /help, /?
22016 * expression.cs (MakeByteBlob): Removed the hacks we had in place
22017 before we supported unsafe code.
22019 * makefile: add --unsafe to the self compilation of mcs.
22021 2002-02-20 Miguel de Icaza <miguel@ximian.com>
22023 * expression.cs (PointerArithmetic): New class that is used to
22024 perform pointer arithmetic.
22025 (Binary.Resolve): Handle pointer arithmetic
22026 Handle pointer comparission.
22027 (ArrayPtr): Utility expression class that is used to take the
22028 address of an array.
22030 (ElementAccess): Implement array access for pointers
22032 * statement.cs (Fixed): Implement fixed statement for arrays, we
22033 are missing one more case before we are done.
22035 * expression.cs (Indirection): Implement EmitAssign and set the
22036 ExprClass to Variable. This allows pointer dereferences to be
22037 treated as variables, and to have values assigned to them.
22039 * ecore.cs (Expression.StoreFromPtr): New utility function to
22040 store values dereferencing.
22042 2002-02-20 Ravi Pratap <ravi@ximian.com>
22044 * expression.cs (Binary.ResolveOperator): Ensure that we are
22045 not trying to operate on a void type - this fixes the reported
22048 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
22049 the parent implementation is sealed.
22051 * ../errors/cs0239.cs : Add.
22053 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
22055 * typemanager.cs (unverifiable_code_type): Corresponds to
22056 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
22057 which have unsafe code in them.
22059 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
22062 2002-02-19 Miguel de Icaza <miguel@ximian.com>
22064 * cs-tokenizer.cs: Add support for @"litreal strings"
22066 Make tokenizer accept pre-processor directives
22067 on any column (remove the old C-like limitation).
22069 * rootcontext.cs (EmitCode): Emit any global attributes.
22070 (AddGlobalAttributes): Used to keep track of assembly attributes.
22072 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
22074 * cs-parser.jay: Add support for global attributes.
22076 2002-02-17 Miguel de Icaza <miguel@ximian.com>
22078 * expression.cs (Indirection): New helper class. Unary will
22079 create Indirection classes to be able to implement the
22080 IMemoryLocation interface on it.
22082 2002-02-16 Miguel de Icaza <miguel@ximian.com>
22084 * cs-parser.jay (fixed_statement): reference the right statement.
22086 * statement.cs (Fixed.Emit): Finish implementing the fixed
22087 statement for the &x case.
22089 2002-02-14 Miguel de Icaza <miguel@ximian.com>
22091 * class.cs (Property.Define, Method.Define): Remove newslot when
22094 * modifiers.cs: My use of NewSlot when `Abstract' was set was
22095 wrong. NewSlot should only be used if the `new' keyword is present.
22097 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
22098 locating our system dir. Sorry about this.
22100 2002-02-13 Miguel de Icaza <miguel@ximian.com>
22102 * driver.cs (GetSystemDir): Compute correctly the location of our
22103 system assemblies. I was using the compiler directory instead of
22104 the library directory.
22106 2002-02-13 Ravi Pratap <ravi@ximian.com>
22108 * expression.cs (BetterFunction): Put back in what Miguel commented out
22109 since it is the correct fix. The problem is elsewhere ;-)
22111 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
22112 parameters of the parms method are themselves compatible or not !
22114 (StandardConversionExists): Fix very dangerous bug where we were forgetting
22115 to check that a class implements an interface before saying that an implicit
22116 conversion was allowed. Use ImplementsInterface to do the checking.
22118 2002-02-13 Miguel de Icaza <miguel@ximian.com>
22120 * class.cs (Method.Define): Track whether we are an explicit
22121 implementation or not. And only call DefineMethodOverride if we
22122 are an explicit implementation.
22124 (Property.DefineMethod): Ditto.
22126 2002-02-11 Ravi Pratap <ravi@ximian.com>
22128 * expression.cs (BetterFunction): Catch hideous bug which was
22129 preventing us from detecting ambiguous calls due to implicit casts i.e
22132 2002-01-29 Miguel de Icaza <miguel@ximian.com>
22134 * support.cs (Pair): Remove un-needed method. I figured why I was
22135 getting the error in cs-parser.jay, the variable in a foreach loop
22136 is readonly, and the compiler does not really treat this as a variable.
22138 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
22139 instead of EQUALS in grammar.
22141 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
22143 * expression.cs (Unary.DoResolve): Check whether the argument is
22146 2002-01-28 Miguel de Icaza <miguel@ximian.com>
22148 * support.cs: Api for Pair to set a value. Despite the fact that
22149 the variables are public the MS C# compiler refuses to compile
22150 code that accesses the field if the variable is part of a foreach
22153 * statement.cs (Fixed): Begin implementation of the fixed
22156 (Block.AddVariable): Return the VariableInfo on success and null
22157 on failure instead of true/false.
22159 * cs-parser.jay (foreach): Catch errors on variables already
22160 defined (we were ignoring this value before) and properly unwind
22161 the block hierarchy
22163 (fixed_statement): grammar for the fixed statement.
22165 2002-01-25 Miguel de Icaza <miguel@ximian.com>
22167 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
22168 pointer types to be incretemented.
22170 (SizeOf): Implement.
22172 * cs-parser.jay (pointer_member_access): Implement
22173 expr->IDENTIFIER production.
22175 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
22176 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
22179 (Unary): Implement indirection.
22181 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
22182 use in non-unsafe context).
22184 (SimpleName.DoResolve): Check for pointers in field access on safe
22187 (Expression.LoadFromPtr): Factor the load-indirect code in this
22188 function. This was duplicated in UnboxCast and ParameterReference
22190 2002-01-24 Miguel de Icaza <miguel@ximian.com>
22192 * expression.cs (ComposedCast): report an error if a pointer cast
22193 is used in a safe region.
22195 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
22196 pointer type casts in unsafe context.
22198 * codegen.cs (EmitContext): Set up IsUnsafe.
22200 * cs-parser.jay (non_expression_type): Add productions for pointer
22203 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
22204 code. We should not use force into static mode if the method is
22205 not virtual. Fixes bug in MIS
22207 * statement.cs (Do.Emit, While.Emit, For.Emit,
22208 Statement.EmitBoolExpression): Add support to Do and While to
22209 propagate infinite loop as `I do return' semantics.
22211 Improve the For case to also test for boolean constants.
22213 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
22214 to the list of attributes we can add.
22216 Remove `EmitContext' argument.
22218 * class.cs (Method.Define): Apply parameter attributes.
22219 (Constructor.Define): Apply parameter attributes.
22220 (MethodCore.LabelParameters): Move here the core of labeling
22223 * support.cs (ReflectionParameters.ParameterModifier,
22224 InternalParameters.ParameterModifier): Use IsByRef on the type and
22225 only return the OUT bit for these parameters instead of in/out/ref
22228 This is because I miss-understood things. The ParameterInfo.IsIn
22229 and IsOut represent whether the parameter has the [In] and [Out]
22232 2002-01-22 Miguel de Icaza <miguel@ximian.com>
22234 * ecore.cs (FieldExpr.Emit): Release temporaries.
22236 * assign.cs (LocalTemporary.Release): new function.
22238 * codegen.cs (EmitContext.GetTemporaryStorage,
22239 EmitContext.FreeTemporaryStorage): Rework the way we deal with
22240 temporary storage. Now we can "put back" localbuilders when we
22243 2002-01-21 Miguel de Icaza <miguel@ximian.com>
22245 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
22246 need to make a copy of the variable to generate verifiable code.
22248 2002-01-19 Miguel de Icaza <miguel@ximian.com>
22250 * driver.cs: Compute dynamically the system directory.
22252 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
22253 Slower, but more generally useful. Used by the abstract
22254 registering implementation.
22256 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
22257 the rules for the special rule on Type/instances. First check if
22258 we have the same name, and if so, try that special static path
22259 rather than the instance path.
22261 2002-01-18 Miguel de Icaza <miguel@ximian.com>
22263 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
22266 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
22267 Enum, ValueType, Delegate or Array for non-corlib compiles.
22269 * cs-tokenizer.cs: Catch long identifiers (645)
22271 * typemanager.cs (IndexerPropetyName): Ravi never tested this
22274 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
22275 fix, we were returning too early, so we were not registering
22276 pending methods from abstract classes.
22278 Do not register pending methods if the class is abstract.
22280 * expression.cs (Conditional.DoResolve): Report circular implicit
22281 conversions when we neecd to compute it for conditional
22284 (Is.DoResolve): If the expression is always of the provided type,
22285 flag warning 183. If the expression can not ever be of the
22286 provided type flag warning 184.
22288 * class.cs: Catch 169 as well.
22290 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
22293 2002-01-18 Nick Drochak <ndrochak@gol.com>
22295 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
22297 2002-01-17 Miguel de Icaza <miguel@ximian.com>
22299 * interface.cs: (PopulateMethod): Check for pointers being defined
22300 only if the unsafe context is active.
22301 (PopulateProperty): ditto.
22302 (PopulateIndexer): ditto.
22304 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
22305 specified. If pointers are present, make sure that they are
22306 present in an unsafe context.
22307 (Constructor, Constructor.Define): ditto.
22308 (Field, Field.Define): ditto.
22309 (Property, Property.Define): ditto.
22310 (Event, Event.Define): ditto.
22312 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
22313 hashtable if there are classes or structs defined.
22315 * expression.cs (LocalVariableReference.DoResolve): Simplify this
22316 code, as the constant resolution moved.
22318 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
22319 the metadata, so we can flag error 133.
22321 * decl.cs (MemberCore.UnsafeOK): New function to test that a
22322 pointer is being declared in an unsafe context.
22324 2002-01-16 Miguel de Icaza <miguel@ximian.com>
22326 * modifiers.cs (Modifiers.Check): Require a Location argument.
22327 Report error 227 for Unsafe use.
22329 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
22331 * statement.cs (For.Emit): If the test is null, then report that
22332 we do `return', as we wont reach anything afterwards.
22334 (Switch.SwitchGoverningType): Track the expression that matched
22337 * driver.cs: Allow negative numbers as an error code to flag.
22339 * cs-parser.jay: Handle 1551.
22341 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
22343 2002-01-15 Miguel de Icaza <miguel@ximian.com>
22345 * cs-parser.jay: Report 1518 (type declaration can only contain
22346 class, struct, interface, enum or delegate)
22348 (switch_label): Report 1523 (keywords `case' or `default' must
22351 (opt_switch_sections): Report 1522 (empty switch)
22353 * driver.cs: Report 1515 (response file specified multiple times)
22354 Report 1516 (Source file specified multiple times).
22356 * expression.cs (Argument.Resolve): Signal 1510
22358 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
22359 access not allowed in static code)
22361 2002-01-11 Ravi Pratap <ravi@ximian.com>
22363 * typemanager.cs (IsPointerType): Utility method which we are going
22366 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
22367 the object type, so we take care of that.
22369 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
22371 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
22372 added to non-params parameters :-)
22374 * typemanager.cs (CSharpName): Include 'void' type too.
22376 (void_ptr_type): Include in the set of core types.
22378 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
22381 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
22384 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
22385 completely forgotten about it.
22387 2002-01-10 Ravi Pratap <ravi@ximian.com>
22389 * cs-parser.jay (pointer_type): Add. This begins our implementation
22390 of parsing rules for unsafe code.
22392 (unsafe_statement): Implement.
22394 (embedded_statement): Modify to include the above.
22396 * statement.cs (Unsafe): Implement new class for unsafe blocks.
22398 * codegen.cs (EmitContext.InUnsafe): Add. This determines
22399 if the current context is an unsafe one.
22401 * cs-parser.jay (local_variable_pointer_type): Since local variable types
22402 are handled differently, we need separate rules for them.
22404 (local_variable_declaration): Update to use local_variable_pointer_type
22405 to allow variable declarations of unmanaged pointer types.
22407 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
22408 in unsafe contexts.
22410 * ../errors/cs0214.cs : Add.
22412 2002-01-16 Nick Drochak <ndrochak@gol.com>
22414 * makefile: remove 'response' file when cleaning.
22416 2002-01-15 Miguel de Icaza <miguel@ximian.com>
22418 * cs-parser.jay: Report 1524.
22420 2002-01-14 Miguel de Icaza <miguel@ximian.com>
22422 * typemanager.cs (RegisterMethod): drop checking if we have
22423 registered this from here
22425 2002-01-12 Miguel de Icaza <miguel@ximian.com>
22427 * class.cs (Method.EmitDestructor): Implement calling our base
22430 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
22431 value of InFinally.
22433 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
22434 this routine and will wrap the call in a try/catch block. Deal
22437 2002-01-11 Miguel de Icaza <miguel@ximian.com>
22439 * ecore.cs (Expression.MemberLookup): instead of taking a
22440 parameter `same_type' that was used to tell whether we could
22441 access private members we compute our containing type from the
22444 (FieldExpr): Added partial support for volatile fields. This does
22445 not work for volatile fields exposed from assemblies, as I can not
22446 figure out how to extract the modreq from it.
22448 Updated all the source files to use this.
22450 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
22451 because it is referenced by MemberLookup very often.
22453 2002-01-09 Ravi Pratap <ravi@ximian.com>
22455 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
22456 TypeBuilder.GetCustomAttributes to retrieve what we need.
22458 Get rid of redundant default_member_attr_type as this is the same as
22459 default_member_type which already exists.
22461 * interface.cs, attribute.cs : Update accordingly.
22463 2002-01-08 Miguel de Icaza <miguel@ximian.com>
22465 * typemanager.cs: Enable IndexerPropertyName again. It does not
22466 work for TYpeBuilders though. Ravi, can you please fix this?
22468 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
22470 * expression.cs (Argument.Emit): Handle the case of ref objects
22471 being passed to ref functions;
22473 (ParameterReference.EmitLoad): Loads the content of the pointer
22474 without dereferencing.
22476 2002-01-07 Miguel de Icaza <miguel@ximian.com>
22478 * cs-tokenizer.cs: Implemented the pre-processing expressions.
22480 2002-01-08 Ravi Pratap <ravi@ximian.com>
22482 * class.cs (Indexer.DefineMethod): Incorporate the interface
22483 type in the name of the method if we are doing explicit interface
22486 * expression.cs (ConversionExists): Remove as it is completely obsolete.
22488 (BetterConversion): Fix extremely trivial bug where we were referring to
22489 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
22492 * ../errors/bug16.cs : Add although we have fixed it.
22494 2002-01-07 Miguel de Icaza <miguel@ximian.com>
22496 * expression.cs (BaseIndexer): Begin implementation.
22498 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
22500 * cs-parser.jay (indexer_declarator): Use qualified_identifier
22501 production directly to remove a shift/reduce, and implement
22502 explicit interface implementation.
22504 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
22505 after a floating point suffix.
22507 * expression.cs (DoNumericPromotions): Improved the conversion for
22508 uint/uint. If we have a constant, we avoid doing a typecast to a
22511 * class.cs (Indexer): Implement explicit interface implementation
22514 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
22516 * class.cs: make the default instance constructor public and hidebysig.
22518 2001-01-03 Ravi Pratap <ravi@ximian.com>
22520 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
22521 so we can call it from elsewhere.
22523 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
22524 we emit it internally if the class has a defined indexer; otherwise the user
22525 emits it by decorating the class definition with the DefaultMemberAttribute.
22527 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
22528 attribute is not used on a type which defines an indexer.
22530 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
22531 character when we skip whitespace.
22533 * ../errors/cs0646.cs : Add.
22535 2002-01-03 Miguel de Icaza <miguel@ximian.com>
22537 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
22540 * makefile: Add practical target `mcs3.exe' which builds the third
22541 generation compiler.
22543 * expression.cs (New): Fix structures constructor calling.
22545 * class.cs (Property, Method, Indexer): Emit Final flag on the
22546 method if we are an interface implementation and we are not
22549 * ecore.cs (PropertyExpr): New public field `IsBase', tells
22550 whether this property is referencing a `base' method.
22552 * expression.cs (Invocation.EmitCall): take an extra argument:
22553 is_base, this is used to determine whether the `call' or
22554 `callvirt' opcode should be used.
22557 * delegate.cs: update EmitCall.
22559 * class.cs (Method.Define): Set NewSlot for the cases where we are
22560 not implementing an interface method.
22562 (Property.Define): ditto.
22564 2002-01-02 Miguel de Icaza <miguel@ximian.com>
22566 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
22567 'r'. Allows mcs to parse itself fully.
22569 2002-01-02 Ravi Pratap <ravi@ximian.com>
22571 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
22572 of the number of initializers that require the InitializeArray method.
22574 (CheckIndices): Store the Expression in all cases - not the plain value. Also
22575 update the above field where necessary.
22577 (MakeByteBlob): Update accordingly.
22579 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
22582 (EmitDynamicInitializers): Update in accordance with the new optimization.
22584 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
22585 same OpCode applies.
22587 * cs-parser.jay : Fix some glaring errors I introduced.
22589 2002-01-01 Ravi Pratap <ravi@ximian.com>
22591 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
22592 so that we can check for name clashes there too.
22594 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
22595 for interface indexers.
22597 * interfaces.cs (Define): Emit the default member attribute.
22599 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
22600 variable was being referred to while setting the value ;-)
22602 2002-01-01 Miguel de Icaza <miguel@ximian.com>
22604 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
22605 byte-by-byte information when we know the data is zero.
22607 Make the block always a multiple of 4, because
22608 DefineInitializedData has a bug.
22610 * assign.cs: Fix, we should assign from the temporary, not from
22613 * expression.cs (MakeByteBlob): Fix my incorrect code.
22615 2001-12-31 Miguel de Icaza <miguel@ximian.com>
22617 * typemanager.cs (EnumToUnderlying): This function is used to get
22618 the underlying type from an enumeration, because it does not
22621 * constant.cs: Use the I4_S form for values between -128 and 127.
22623 * statement.cs (Block.LookupLabel): Looks up a label.
22624 (Block): Drop support for labeled blocks.
22626 (LabeledStatement): New kind of statement that represents a label
22629 (Goto): Finally implement this bad boy.
22631 * cs-parser.jay: Update to reflect new mechanism to implement
22634 2001-12-30 Miguel de Icaza <miguel@ximian.com>
22636 * codegen.cs (EmitContext.This): a codegen property that keeps the
22637 a single instance of this instead of creating many different this
22640 * delegate.cs (Delegate.DoResolve): Update to use the property;
22642 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
22644 * expression.cs (BaseAccess.DoResolve): Ditto.
22646 2001-12-29 Ravi Pratap <ravi@ximian.com>
22648 * typemanager.cs (methodimpl_attr_type): Add to hold the type
22649 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
22651 (InitCoreTypes): Update accordingly.
22653 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
22654 so we can quickly store the state.
22656 (ApplyAttributes): Set the correct implementation flags
22657 for InternalCall methods.
22659 2001-12-29 Miguel de Icaza <miguel@ximian.com>
22661 * expression.cs (EmitCall): if a method is not virtual, then do
22662 not use callvirt on it.
22664 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
22665 user defined stuff) requires the use of stobj, which takes an
22666 address on the stack instead of an array and an index. So emit
22667 the Ldelema operation for it.
22669 (EmitStoreOpcode): Use stobj for valuetypes.
22671 (UnaryMutator.EmitCode): Use the right 1 value depending on
22672 whether we are dealing with int64/uint64, float or doubles.
22674 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
22675 constructors that I implemented last night.
22677 (Constructor.IsDefault): Fix to work properly for static
22680 * cs-parser.jay (CheckDef): report method signature errors.
22681 Update error number 103 to be 132.
22683 * decl.cs: New AdditionResult enumeration value: MethodExists.
22684 Although we do this check for methods later on in the semantic
22685 analysis, catching repeated default constructors is so easy that
22686 we catch these here.
22688 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
22691 (ParameterReference.EmitAssign, Emit): handle
22694 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
22695 (ArrayAccess.EmitStoreOpcode): ditto.
22697 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
22699 * expression.cs (MakeByteBlob): Complete all the missing types
22700 (uint, short, ushort, byte, sbyte)
22702 * class.cs: Only init instance field initializers on instance
22705 Rename `constructors' to instance_constructors.
22707 (TypeContainer.AddConstructor): Only add constructors to the list
22708 if it is not static.
22710 Make sure that we handle default_static_constructor independently
22711 everywhere where we handle instance_constructors
22713 2001-12-28 Miguel de Icaza <miguel@ximian.com>
22715 * class.cs: Do not lookup or create a base initializer for a
22716 static constructor.
22718 (ConstructorInitializer.Resolve): use the proper type to lookup
22721 * cs-parser.jay: Report error 1585 (modifiers between type and name).
22723 * enum.cs, interface.cs: Remove CloseType, this is taken care by
22726 * decl.cs: CloseType is now an virtual method, the default
22727 implementation just closes this type.
22729 2001-12-28 Ravi Pratap <ravi@ximian.com>
22731 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
22732 to PreserveSig by default. Also emit HideBySig on such methods.
22734 Basically, set the defaults to standard values.
22736 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
22737 argument, if candidate is better, it can't be worse than the best !
22739 (Invocation): Re-write bits to differentiate between methods being
22740 applicable in their expanded form and their normal form - for params
22743 Get rid of use_standard everywhere as only standard conversions are allowed
22744 in overload resolution.
22746 More spec conformance.
22748 2001-12-27 Miguel de Icaza <miguel@ximian.com>
22750 * driver.cs: Add --timestamp, to see where the compiler spends
22753 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
22754 `this' in static code.
22756 (SimpleName.DoResolve): Implement in terms of a helper function
22757 that allows static-references to be passed upstream to
22760 (Expression.ResolveWithSimpleName): Resolve specially simple
22761 names when called by MemberAccess to implement the special
22764 (Expression.ImplicitReferenceConversion): Handle conversions from
22765 Null to reference types before others, as Null's type is
22768 * expression.cs (Invocation.EmitCall): Handle the special case of
22769 calling methods declared on a reference type from a ValueType
22770 (Base classes System.Object and System.Enum)
22772 (MemberAccess.Resolve): Only perform lookups on Enumerations if
22773 the left hand side is a TypeExpr, not on every enumeration.
22775 (Binary.Resolve): If types are reference types, then do a cast to
22776 object on operators != and == of both arguments.
22778 * typemanager.cs (FindMembers): Extract instance and static
22779 members if requested.
22781 * interface.cs (PopulateProperty): Use void_type instead of null
22782 as the return type for the setter method.
22784 (PopulateIndexer): ditto.
22786 2001-12-27 Ravi Pratap <ravi@ximian.com>
22788 * support.cs (ReflectionParameters): Fix minor bug where we
22789 were examining the wrong parameter for the ParamArray attribute.
22791 Cope with requests for the type of the parameter at position
22792 greater than the params parameter's. We now return the element
22793 type of the params array as that makes more sense.
22795 * expression.cs (Invocation.IsParamsMethodApplicable): Update
22796 accordingly as we no longer have to extract the element type
22799 (Invocation.OverloadResolve): Update.
22801 2001-12-27 Miguel de Icaza <miguel@ximian.com>
22803 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
22804 against IEnumerator, test whether the return value is a descendant
22805 of the IEnumerator interface.
22807 * class.cs (Indexer.Define): Use an auxiliary method to implement
22808 the other bits of the method definition. Begin support for
22809 explicit interface implementation.
22811 (Property.DefineMethod): Use TypeManager.void_type instead of null
22812 for an empty return value.
22814 2001-12-26 Miguel de Icaza <miguel@ximian.com>
22816 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
22817 dealing with a FieldExpr which is composed of a FieldBuilder, in
22818 the code path we did extract the constant, but we should have
22819 obtained the underlying value to be able to cast it (otherwise we
22820 end up in an infinite loop, this is what Ravi was running into).
22822 (ArrayCreation.UpdateIndices): Arrays might be empty.
22824 (MemberAccess.ResolveMemberAccess): Add support for section
22825 14.5.4.1 that deals with the special case of E.I when E is a type
22826 and something else, that I can be a reference to a static member.
22828 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
22829 handle a particular array type to create byte blobs, it is just
22830 something we dont generate byteblobs for.
22832 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
22835 * location.cs (Push): remove the key from the hashtable that we
22836 are about to add. This happens for empty files.
22838 * driver.cs: Dispose files after we have parsed them.
22840 (tokenize): new function that only runs the tokenizer on its
22841 input, for speed testing.
22843 2001-12-26 Ravi Pratap <ravi@ximian.com>
22845 * class.cs (Event.Define): Define the private field only if there
22846 are no accessors defined.
22848 * expression.cs (ResolveMemberAccess): If there is no associated
22849 field with the event, that means we have an event defined with its
22850 own accessors and we should flag error cs0070 since transforming
22851 ourselves into a field is not valid in that case.
22853 * ecore.cs (SimpleName.DoResolve): Same as above.
22855 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
22856 and charset to sane values.
22858 2001-12-25 Ravi Pratap <ravi@ximian.com>
22860 * assign.cs (DoResolve): Perform check on events only if they
22861 are being accessed outside the declaring type.
22863 * cs-parser.jay (event_declarations): Update rules to correctly
22864 set the type of the implicit parameter etc.
22866 (add_accessor, remove_accessor): Set current local parameters.
22868 * expression.cs (Binary): For delegate addition and subtraction,
22869 cast the return value from the method into the appropriate delegate
22872 2001-12-24 Ravi Pratap <ravi@ximian.com>
22874 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
22875 of these as the workaround is unnecessary.
22877 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
22878 delegate data - none of that is needed at all.
22880 Re-write bits to extract the instance expression and the delegate method
22883 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
22886 * attribute.cs (ApplyAttributes): New method to take care of common tasks
22887 of attaching attributes instead of duplicating code everywhere.
22889 * everywhere : Update code to do attribute emission using the above method.
22891 2001-12-23 Miguel de Icaza <miguel@ximian.com>
22893 * expression.cs (IsParamsMethodApplicable): if there are not
22894 parameters, return immediately.
22896 * ecore.cs: The 0 literal can be implicity converted to an enum
22899 (SimpleName.DoResolve): First lookup the type, then lookup the
22902 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
22903 want to get its address. If the InstanceExpression is not
22904 addressable, store the result in a temporary variable, then get
22907 * codegen.cs: Only display 219 errors on warning level or above.
22909 * expression.cs (ArrayAccess): Make it implement the
22910 IMemoryLocation interface.
22912 (Binary.DoResolve): handle the operator == (object a, object b)
22913 and operator != (object a, object b) without incurring into a
22914 BoxedCast (because 5 != o should never be performed).
22916 Handle binary enumerator operators.
22918 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
22919 value type, otherwise use Ldelem_ref.
22921 Use precomputed names;
22923 (AddressOf): Implement address of
22925 * cs-parser.jay (labeled_statement): Fix recursive block
22926 addition by reworking the production.
22928 * expression.cs (New.DoEmit): New has a special case:
22930 If we are dealing with a ValueType, we have a few
22931 situations to deal with:
22933 * The target of New is a ValueType variable, that is
22934 easy, we just pass this as the variable reference
22936 * The target of New is being passed as an argument,
22937 to a boxing operation or a function that takes a
22940 In this case, we need to create a temporary variable
22941 that is the argument of New.
22944 2001-12-23 Ravi Pratap <ravi@ximian.com>
22946 * rootcontext.cs (LookupType): Check that current_type is not null before
22947 going about looking at nested types.
22949 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
22950 not implement the IAssignMethod interface any more.
22952 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
22953 where we tranform them into FieldExprs if they are being resolved from within
22954 the declaring type.
22956 * ecore.cs (SimpleName.DoResolve): Do the same here.
22958 * assign.cs (DoResolve, Emit): Clean up code considerably.
22960 * ../errors/bug10.cs : Add.
22962 * ../errors/cs0070.cs : Add.
22964 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
22966 * assign.cs : Get rid of EventIsLocal everywhere.
22968 2001-12-23 Miguel de Icaza <miguel@ximian.com>
22970 * ecore.cs (ConvertIntLiteral): finished the implementation.
22972 * statement.cs (SwitchLabel): Convert the value we are using as a
22973 key before looking up the table.
22975 2001-12-22 Miguel de Icaza <miguel@ximian.com>
22977 * codegen.cs (EmitTopBlock): Require a Location argument now.
22979 * cs-parser.jay (constructor_declarator): We need to setup
22980 current_local_parameters before we parse the
22981 opt_constructor_initializer, to allow the variables to be bound
22982 to the constructor arguments.
22984 * rootcontext.cs (LookupType): First lookup nested classes in our
22985 class and our parents before we go looking outside our class.
22987 * expression.cs (ConstantFold): Extract/debox the values at the
22990 * rootcontext.cs (EmitCode): Resolve the constants first before we
22991 resolve the types. This is not really needed, but it helps debugging.
22993 * statement.cs: report location.
22995 * cs-parser.jay: pass location to throw statement.
22997 * driver.cs: Small bug fix.
22999 * report.cs: Updated format to be 4-zero filled digits.
23001 2001-12-22 Ravi Pratap <ravi@ximian.com>
23003 * expression.cs (CheckIndices): Fix minor bug where the wrong
23004 variable was being referred to ;-)
23006 (DoEmit): Do not call EmitStaticInitializers when the
23007 underlying type is System.Object.
23009 2001-12-21 Ravi Pratap <ravi@ximian.com>
23011 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
23012 and do the usual workaround for SRE.
23014 * class.cs (MyEventBuilder.EventType): New member to get at the type
23015 of the event, quickly.
23017 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
23019 * assign.cs (Assign.DoResolve): Handle the case when the target
23020 is an EventExpr and perform the necessary checks.
23022 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
23025 (SimpleName.MemberStaticCheck): Include check for EventExpr.
23027 (EventExpr): Set the type in the constructor itself since we
23028 are meant to be born fully resolved.
23030 (EventExpr.Define): Revert code I wrote earlier.
23032 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
23033 instance expression is null. The instance expression is a This in that case
23034 or a null, depending on whether it is a static method or not.
23036 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
23037 refers to more than one method.
23039 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
23040 and accordingly flag errors.
23042 2001-12-21 Miguel de Icaza <miguel@ximian.com>
23044 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
23046 2001-12-22 Miguel de Icaza <miguel@ximian.com>
23048 * location.cs (ToString): Provide useful rutine.
23050 2001-12-21 Miguel de Icaza <miguel@ximian.com>
23052 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
23053 objects, return the actual integral boxed.
23055 * statement.cs (SwitchLabel): define an ILLabel for each
23058 (Switch.CheckSwitch): If the value is a Literal, extract
23059 the underlying literal.
23061 Also in the unused hashtable we had, add the SwitchLabel so we can
23062 quickly look this value up.
23064 * constant.cs: Implement a bunch of new constants. Rewrite
23065 Literal based on this. Made changes everywhere to adapt to this.
23067 * expression.cs (Expression.MakeByteBlob): Optimize routine by
23068 dereferencing array only once, and also copes with enumrations.
23070 bytes are two bytes wide, not one.
23072 (Cast): Perform constant conversions.
23074 * ecore.cs (TryImplicitIntConversion): Return literals instead of
23075 wrappers to the literals here.
23077 * expression.cs (DoNumericPromotions): long literals can converted
23078 to ulong implicity (this is taken care of elsewhere, but I was
23079 missing this spot).
23081 * ecore.cs (Expression.Literalize): Make the return type Literal,
23082 to improve type checking.
23084 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
23086 2001-12-20 Miguel de Icaza <miguel@ximian.com>
23088 * literal.cs: Revert code from ravi that checked the bounds. The
23089 bounds are sane by the definition of the type itself.
23091 * typemanager.cs: Fix implementation of ImplementsInterface. We
23092 need to actually look up in our parent hierarchy for interfaces
23095 * const.cs: Use the underlying type for enumerations
23097 * delegate.cs: Compute the basename for the delegate creation,
23098 that should fix the delegate test case, and restore the correct
23099 Type Lookup semantics in rootcontext
23101 * rootcontext.cs: Revert Ravi's last patch. The correct way of
23102 referencing a nested type with the Reflection API is using the "+"
23105 * cs-parser.jay: Do not require EOF token at the end.
23107 2001-12-20 Ravi Pratap <ravi@ximian.com>
23109 * rootcontext.cs (LookupType): Concatenate type names with
23110 a '.' instead of a '+' The test suite passes again.
23112 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
23113 field of the enumeration.
23115 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
23116 the case when the member is an EventExpr.
23118 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
23119 static has an associated instance expression.
23121 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
23123 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
23125 * class.cs (Event.Define): Register event and perform appropriate checks
23128 We define the Add and Remove methods even if the use provides none because
23129 in that case, we provide default implementations ourselves.
23131 Define a private field of the type of the event. This is done by the CSC compiler
23132 and we should be doing it too ;-)
23134 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
23135 More methods we use in code we generate.
23137 (multicast_delegate_type, delegate_type): Two separate types since the distinction
23140 (InitCoreTypes): Update accordingly for the above.
23142 * class.cs (Event.Emit): Generate code for default accessors that we provide
23144 (EmitDefaultMethod): Do the job in the above.
23146 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
23149 2001-12-20 Miguel de Icaza <miguel@ximian.com>
23151 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
23152 builders even if we were missing one.
23154 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
23155 pass the Basename as our class name instead of the Name. The
23156 basename will be correctly composed for us.
23158 * parameter.cs (Paramters): Now takes a Location argument.
23160 * decl.cs (DeclSpace.LookupType): Removed convenience function and
23161 make all the code call directly LookupType in RootContext and take
23162 this chance to pass the Location information everywhere.
23164 * Everywhere: pass Location information.
23166 2001-12-19 Miguel de Icaza <miguel@ximian.com>
23168 * class.cs (Constructor.Define): Updated way of detecting the
23169 length of the parameters.
23171 (TypeContainer.DefineType): Use basename as the type name for
23174 (TypeContainer.Define): Do not recursively define types here, as
23175 definition is taken care in order by the RootContext.
23177 * tree.cs: Keep track of namespaces in a per-file basis.
23179 * parameter.cs (Parameter.ComputeSignature): Update to use
23182 (Parameters.GetSignature): ditto.
23184 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
23185 instead of a TypeContainer.
23187 (Interface.SemanticAnalysis): Use `this' instead of our parent to
23188 resolve names. Because we need to be resolve in our context, not
23191 * driver.cs: Implement response files.
23193 * class.cs (TypeContainer.DefineType): If we are defined, do not
23194 redefine ourselves.
23196 (Event.Emit): Emit the code for add/remove handlers.
23197 (Event.Define): Save the MethodBuilders for add/remove.
23199 * typemanager.cs: Use pair here too.
23201 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
23202 DictionaryEntry requires the first argument to be non-null.
23204 (enum_declaration): Compute full name for registering the
23207 (delegate_declaration): Instead of using
23208 formal_parameter_list, use opt_formal_parameter_list as the list
23211 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
23212 (EventParsing): New property that controls whether `add' and
23213 `remove' are returned as tokens or identifiers (for events);
23215 2001-12-19 Ravi Pratap <ravi@ximian.com>
23217 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
23218 use MyEventBuilder only and let it wrap the real builder for us.
23220 (MyEventBuilder): Revamp constructor etc.
23222 Implement all operations that we perform on EventBuilder in precisely the same
23225 (FindMembers): Update to use the EventBuilder member.
23227 (Event.Emit): Update accordingly.
23229 2001-12-18 Ravi Pratap <ravi@ximian.com>
23231 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
23232 by calling the appropriate methods.
23234 (GetCustomAttributes): Make stubs as they cannot possibly do anything
23237 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
23239 2001-12-17 Ravi Pratap <ravi@ximian.com>
23241 * delegate.cs (Delegate.Populate): Check that the return type
23242 and various parameters types are indeed accessible.
23244 * class.cs (Constructor.Define): Same here.
23246 (Field.Define): Ditto.
23248 (Event.Define): Ditto.
23250 (Operator.Define): Check that the underlying Method defined itself
23251 correctly - so it's MethodBuilder should not be null.
23253 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
23254 expression happens to be null.
23256 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
23257 members but as of now we don't seem to be able to do anything really useful with it.
23259 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
23260 not the EventBuilder.
23262 2001-12-18 Miguel de Icaza <miguel@ximian.com>
23264 * cs-tokenizer.cs: Add support for defines.
23265 Add support for #if, #elif, #else, #endif
23267 (eval_var): evaluates a variable.
23268 (eval): stubbed for evaluating functions.
23270 * cs-parser.jay: Pass the defines information
23272 * driver.cs: Add --define command line option.
23274 * decl.cs: Move MemberCore here.
23276 Make it the base class for DeclSpace. This allows us to catch and
23277 report 108 and 109 for everything now.
23279 * class.cs (TypeContainer.Define): Extract all the members
23280 before populating and emit the warning 108 (new keyword required
23281 to override) instead of having each member implement this.
23283 (MemberCore.Define): New abstract method, we will be using this in
23284 the warning reporting engine in Populate.
23286 (Operator.Define): Adjust to new MemberCore protocol.
23288 * const.cs (Const): This does not derive from Expression, it is a
23289 temporary object we use to create fields, it is a MemberCore.
23291 * class.cs (Method.Define): Allow the entry point to be in a
23294 * driver.cs: Rewrite the argument handler to clean it up a bit.
23296 * rootcontext.cs: Made it just an auxiliary namespace feature by
23297 making everything static.
23299 * driver.cs: Adapt code to use RootContext type name instead of
23302 * delegate.cs: Remove RootContext argument.
23304 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
23307 * class.cs (Event.Define): The lookup can fail.
23309 * cs-tokenizer.cs: Begin implementation of pre-procesor.
23311 * expression.cs: Resolve the this instance before invoking the code.
23313 2001-12-17 Miguel de Icaza <miguel@ximian.com>
23315 * cs-parser.jay: Add a production in element_access that allows
23316 the thing to become a "type" reference. This way we can parse
23317 things like "(string [])" as a type.
23319 Note that this still does not handle the more complex rules of
23323 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
23325 * ecore.cs: (CopyNewMethods): new utility function used to
23326 assemble the list of methods from running FindMembers.
23328 (MemberLookup): Rework FindMembers so that
23330 2001-12-16 Miguel de Icaza <miguel@ximian.com>
23332 * class.cs (TypeContainer): Remove Delegates who fail to be
23335 * delegate.cs (Populate): Verify that we dont get null return
23336 values. TODO: Check for AsAccessible.
23338 * cs-parser.jay: Use basename to emit error 574 (destructor should
23339 have the same name as container class), not the full name.
23341 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
23342 possible representation.
23344 Also implements integer type suffixes U and L.
23346 2001-12-15 Miguel de Icaza <miguel@ximian.com>
23348 * expression.cs (ArrayCreation.DoResolve): We need to do the
23349 argument resolution *always*.
23351 * decl.cs: Make this hold the namespace. Hold the root context as
23353 (LookupType): Move here.
23355 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
23357 * location.cs (Row, Name): Fixed the code, it was always returning
23358 references to the first file.
23360 * interface.cs: Register properties defined through interfaces.
23362 * driver.cs: Add support for globbing on the command line
23364 * class.cs (Field): Make it derive from MemberCore as well.
23367 2001-12-15 Ravi Pratap <ravi@ximian.com>
23369 * class.cs (Event::Define): Check that the type of the event is a delegate
23370 type else flag error #66.
23372 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
23375 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
23376 values of EntryPoint, CharSet etc etc.
23378 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
23380 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
23381 be null and we should ignore this. I am not sure if this is really clean. Apparently,
23382 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
23383 which needs this to do its work.
23385 * ../errors/cs0066.cs : Add.
23387 2001-12-14 Miguel de Icaza <miguel@ximian.com>
23389 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
23392 * class.cs: (MethodSignature.MethodSignature): Removed hack that
23393 clears out the parameters field.
23394 (MemberSignatureCompare): Cleanup
23396 (MemberCore): New base class used to share code between MethodCore
23399 (RegisterRequiredImplementations) BindingFlags.Public requires
23400 either BindingFlags.Instace or Static. Use instance here.
23402 (Property): Refactored code to cope better with the full spec.
23404 * parameter.cs (GetParameterInfo): Return an empty array instead
23407 * class.cs (Property): Abstract or extern properties have no bodies.
23409 * parameter.cs (GetParameterInfo): return a zero-sized array.
23411 * class.cs (TypeContainer.MethodModifiersValid): Move all the
23412 method modifier validation to the typecontainer so we can reuse
23413 this on properties.
23415 (MethodCore.ParameterTypes): return an empty sized array of types.
23417 (Property.Define): Test property modifier validity.
23419 Add tests for sealed/override too.
23421 (Method.Emit): abstract or extern methods have no bodies.
23423 2001-12-14 Ravi Pratap <ravi@ximian.com>
23425 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
23428 (Method::Define, ::Emit): Modify accordingly.
23430 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
23432 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
23434 * makefile: Pass in /unsafe.
23436 2001-12-13 Miguel de Icaza <miguel@ximian.com>
23438 * class.cs (MakeKey): Kill routine.
23440 * class.cs (TypeContainer.Define): Correctly define explicit
23441 method implementations (they require the full interface name plus
23444 * typemanager.cs: Deply the PtrHashtable here and stop using the
23445 lame keys. Things work so much better.
23447 This of course broke everyone who depended on `RegisterMethod' to
23448 do the `test for existance' test. This has to be done elsewhere.
23450 * support.cs (PtrHashtable): A hashtable that avoid comparing with
23451 the object stupid Equals method (because, that like fails all over
23452 the place). We still do not use it.
23454 * class.cs (TypeContainer.SetRequiredInterface,
23455 TypeContainer.RequireMethods): Killed these two routines and moved
23456 all the functionality to RegisterRequiredImplementations.
23458 (TypeContainer.RegisterRequiredImplementations): This routine now
23459 registers all the implementations required in an array for the
23460 interfaces and abstract methods. We use an array of structures
23461 which can be computed ahead of time to reduce memory usage and we
23462 also assume that lookups are cheap as most classes will not
23463 implement too many interfaces.
23465 We also avoid creating too many MethodSignatures.
23467 (TypeContainer.IsInterfaceMethod): Update and optionally does not
23468 clear the "pending" bit if we find that there are problems with
23471 (TypeContainer.VerifyPendingMethods): Update to report errors of
23472 methods that look like implementations but are not.
23474 (TypeContainer.Define): Add support for explicit interface method
23477 2001-12-12 Miguel de Icaza <miguel@ximian.com>
23479 * typemanager.cs: Keep track of the parameters here instead of
23480 being a feature of the TypeContainer.
23482 * class.cs: Drop the registration of parameters here, as
23483 InterfaceMethods are also interface declarations.
23485 * delegate.cs: Register methods with the TypeManager not only with
23486 the TypeContainer. This code was buggy.
23488 * interface.cs: Full registation here.
23490 2001-12-11 Miguel de Icaza <miguel@ximian.com>
23492 * expression.cs: Remove reducer for binary expressions, it can not
23495 * const.cs: Put here the code that used to go into constant.cs
23497 * constant.cs: Put here the code for constants, this is a new base
23498 class for Literals.
23500 * literal.cs: Make Literal derive from Constant.
23502 2001-12-09 Miguel de Icaza <miguel@ximian.com>
23504 * statement.cs (Return.Emit): Report error 157 if the user
23505 attempts to return from a finally block.
23507 (Return.Emit): Instead of emitting a return, jump to the end of
23510 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
23511 LocalBuilder to store the result of the function. ReturnLabel is
23512 the target where we jump.
23515 2001-12-09 Radek Doulik <rodo@ximian.com>
23517 * cs-parser.jay: remember alias in current namespace
23519 * ecore.cs (SimpleName::DoResolve): use aliases for types or
23522 * class.cs (LookupAlias): lookup alias in my_namespace
23524 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
23526 (LookupAlias): lookup alias in this and if needed in parent
23529 2001-12-08 Miguel de Icaza <miguel@ximian.com>
23533 * rootcontext.cs: (ModuleBuilder) Made static, first step into
23534 making things static. I need this to avoid passing the
23535 TypeContainer when calling ParameterType.
23537 * support.cs (InternalParameters.ParameterType): Remove ugly hack
23538 that did string manipulation to compute the type and then call
23539 GetType. Use Parameter.ParameterType instead.
23541 * cs-tokenizer.cs: Consume the suffix for floating values.
23543 * expression.cs (ParameterReference): figure out whether this is a
23544 reference parameter or not. Kill an extra variable by computing
23545 the arg_idx during emission.
23547 * parameter.cs (Parameters.GetParameterInfo): New overloaded
23548 function that returns whether a parameter is an out/ref value or not.
23550 (Parameter.ParameterType): The type of the parameter (base,
23551 without ref/out applied).
23553 (Parameter.Resolve): Perform resolution here.
23554 (Parameter.ExternalType): The full type (with ref/out applied).
23556 * statement.cs (Using.Emit, Using.EmitExpression): Implement
23557 support for expressions on the using statement.
23559 2001-12-07 Miguel de Icaza <miguel@ximian.com>
23561 * statement.cs (Using.EmitLocalVariableDecls): Split the
23562 localvariable handling of the using statement.
23564 (Block.EmitMeta): Keep track of variable count across blocks. We
23565 were reusing slots on separate branches of blocks.
23567 (Try.Emit): Emit the general code block, we were not emitting it.
23569 Check the type of the declaration to be an IDisposable or
23570 something that can be implicity converted to it.
23572 Emit conversions if required.
23574 * ecore.cs (EmptyExpression): New utility class.
23575 (Expression.ImplicitConversionExists): New utility function.
23577 2001-12-06 Miguel de Icaza <miguel@ximian.com>
23579 * statement.cs (Using): Implement.
23581 * expression.cs (LocalVariableReference): Support read only variables.
23583 * statement.cs: Remove the explicit emit for the Leave opcode.
23584 (VariableInfo): Add a readonly field.
23586 2001-12-05 Miguel de Icaza <miguel@ximian.com>
23588 * ecore.cs (ConvCast): new class used to encapsulate the various
23589 explicit integer conversions that works in both checked and
23590 unchecked contexts.
23592 (Expression.ConvertNumericExplicit): Use new ConvCast class to
23593 properly generate the overflow opcodes.
23595 2001-12-04 Miguel de Icaza <miguel@ximian.com>
23597 * statement.cs: The correct type for the EmptyExpression is the
23598 element_type, not the variable type. Ravi pointed this out.
23600 2001-12-04 Ravi Pratap <ravi@ximian.com>
23602 * class.cs (Method::Define): Handle PInvoke methods specially
23603 by using DefinePInvokeMethod instead of the usual one.
23605 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
23606 above to do the task of extracting information and defining the method.
23608 2001-12-04 Ravi Pratap <ravi@ximian.com>
23610 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
23611 of the condition for string type.
23613 (Emit): Move that here.
23615 (ArrayCreation::CheckIndices): Keep string literals in their expression
23618 (EmitDynamicInitializers): Handle strings appropriately.
23620 2001-12-04 Miguel de Icaza <miguel@ximian.com>
23622 * codegen.cs (EmitContext): Replace multiple variables with a
23623 single pointer to the current Switch statement.
23625 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
23628 2001-12-03 Miguel de Icaza <miguel@ximian.com>
23632 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
23635 (Foreach.Emit): Foreach on arrays was not setting
23636 up the loop variables (for break/continue).
23638 (GotoCase): Semi-implented.
23640 2001-12-03 Ravi Pratap <ravi@ximian.com>
23642 * attribute.cs (CheckAttribute): Handle system attributes by using
23643 Attribute.GetAttributes to examine information we need.
23645 (GetValidPlaces): Same here.
23647 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
23649 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
23651 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
23653 (Method::Define): Set appropriate flags if we have a DllImport attribute.
23655 (Method::Emit): Handle the case when we are a PInvoke method.
23657 2001-12-03 Miguel de Icaza <miguel@ximian.com>
23659 * expression.cs: Use ResolveWithSimpleName on compound names.
23661 2001-12-02 Ravi Pratap <ravi@ximian.com>
23663 * constant.cs (EmitConstant): Make sure we resolve the associated expression
23664 before trying to reduce it.
23666 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
23668 * constant.cs (LookupConstantValue): Implement.
23670 (EmitConstant): Use the above in emitting the constant.
23672 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
23673 that are user-defined by doing a LookupConstantValue on them.
23675 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
23678 2001-11-29 Miguel de Icaza <miguel@ximian.com>
23680 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
23682 (BaseAccess.DoResolve): Implement.
23684 (MemberAccess.DoResolve): Split this routine into a
23685 ResolveMemberAccess routine that can be used independently
23687 2001-11-28 Miguel de Icaza <miguel@ximian.com>
23689 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
23690 As that share bits of the implementation. Is returns a boolean,
23691 while As returns the Type that is being probed.
23693 2001-12-01 Ravi Pratap <ravi@ximian.com>
23695 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
23696 instead of a Literal - much easier.
23698 (EnumInTransit): Remove - utterly useless :-)
23700 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
23702 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
23704 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
23705 chain when we have no associated expression.
23707 2001-11-30 Ravi Pratap <ravi@ximian.com>
23709 * constant.cs (Define): Use Location while reporting the errror.
23711 Also emit a warning when 'new' is used and there is no inherited
23714 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
23717 (LookupEnumValue): Implement to lookup an enum member's value and define it
23720 (Populate): Re-write accordingly to use the above routine.
23722 2001-11-27 Miguel de Icaza <miguel@ximian.com>
23724 * expression.cs (This): Fix prototype for DoResolveLValue to
23725 override the base class DoResolveLValue.
23727 * cs-parser.cs: Report errors cs574 and cs575 (destructor
23730 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
23731 (we need to load the address of the field here). This fixes
23734 (FieldExpr.DoResolveLValue): Call the DoResolve
23735 function to initialize the Instance expression.
23737 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
23738 correctly the GetEnumerator operation on a value type.
23740 * cs-parser.jay: Add more simple parsing error catches.
23742 * statement.cs (Switch): Add support for string switches.
23743 Handle null specially.
23745 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
23747 2001-11-28 Ravi Pratap <ravi@ximian.com>
23749 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
23751 (declare_local_constant): New helper function.
23753 * statement.cs (AddConstant): Keep a separate record of constants
23755 (IsConstant): Implement to determine if a variable is a constant.
23757 (GetConstantExpression): Implement.
23759 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
23761 * statement.cs (IsVariableDefined): Re-write.
23763 2001-11-27 Ravi Pratap <ravi@ximian.com>
23765 * class.cs (TypeContainer::FindMembers): Look for constants
23766 in the case when we are looking for MemberTypes.Field
23768 * expression.cs (MemberAccess::DoResolve): Check that in the
23769 case we are a FieldExpr and a Literal, we are not being accessed
23770 by an instance reference.
23772 * cs-parser.jay (local_constant_declaration): Implement.
23774 (declaration_statement): Implement for constant declarations.
23776 2001-11-26 Miguel de Icaza <miguel@ximian.com>
23778 * statement.cs (Switch): Catch double defaults.
23780 (Switch): More work on the switch() statement
23781 implementation. It works for integral values now, need to finish
23785 2001-11-24 Miguel de Icaza <miguel@ximian.com>
23787 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
23788 integer literals into other integer literals. To be used by
23791 2001-11-24 Ravi Pratap <ravi@ximian.com>
23793 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
23796 (EmitDynamicInitializers): Cope with the above since we extract data
23797 directly from ArrayData now.
23799 (ExpectInitializers): Keep track of whether initializers are mandatory
23802 (Bounds): Make it a hashtable to prevent the same dimension being
23803 recorded for every element in that dimension.
23805 (EmitDynamicInitializers): Fix bug which prevented the Set array method
23808 Also fix bug which was causing the indices to be emitted in the reverse
23811 2001-11-24 Miguel de Icaza <miguel@ximian.com>
23813 * expression.cs (ArrayCreation): Implement the bits that Ravi left
23814 unfinished. They do not work, because the underlying code is
23817 2001-11-22 Miguel de Icaza <miguel@ximian.com>
23819 * cs-parser.jay: Remove bogus fixme.
23821 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
23822 on Switch statement.
23824 2001-11-23 Ravi Pratap <ravi@ximian.com>
23826 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
23829 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
23830 parameter. Apparently, any expression is allowed.
23832 (ValidateInitializers): Update accordingly.
23834 (CheckIndices): Fix some tricky bugs thanks to recursion.
23836 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
23837 I was being completely brain-dead.
23839 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
23840 and re-write acordingly.
23842 (DelegateInvocation): Re-write accordingly.
23844 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
23846 (MakeByteBlob): Handle types more correctly.
23848 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
23849 initialization from expressions but it is incomplete because I am a complete
23852 2001-11-22 Miguel de Icaza <miguel@ximian.com>
23854 * statement.cs (If.Emit): Fix a bug that generated incorrect code
23855 on If. Basically, we have to return `true' (ie, we do return to
23856 our caller) only if both branches of the if return.
23858 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
23859 short-circuit operators, handle them as short circuit operators.
23861 (Cast.DoResolve): Resolve type.
23862 (Cast.Cast): Take an expression as the target type.
23864 * cs-parser.jay (cast_expression): Remove old hack that only
23865 allowed a limited set of types to be handled. Now we take a
23866 unary_expression and we resolve to a type during semantic
23869 Use the grammar productions from Rhys to handle casts (this is
23870 not complete like Rhys syntax yet, we fail to handle that corner
23871 case that C# has regarding (-x), but we will get there.
23873 2001-11-22 Ravi Pratap <ravi@ximian.com>
23875 * class.cs (EmitFieldInitializer): Take care of the case when we have a
23876 field which is an array type.
23878 * cs-parser.jay (declare_local_variables): Support array initialization too.
23880 * typemanager.cs (MakeKey): Implement.
23882 (everywhere): Use the above appropriately.
23884 * cs-parser.jay (for_statement): Update for array initialization while
23885 declaring variables.
23887 * ecore.cs : The error message was correct, it's the variable's names that
23888 were misleading ;-) Make the code more readable.
23890 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
23891 the correct type etc.
23893 (ConvertExplicit): Handle Enum types by examining the underlying type.
23895 2001-11-21 Ravi Pratap <ravi@ximian.com>
23897 * parameter.cs (GetCallingConvention): Always return
23898 CallingConventions.Standard for now.
23900 2001-11-22 Miguel de Icaza <miguel@ximian.com>
23902 * expression.cs (Binary.ResolveOperator): Update the values of `l'
23903 and `r' after calling DoNumericPromotions.
23905 * ecore.cs: Fix error message (the types were in the wrong order).
23907 * statement.cs (Foreach.ProbeCollectionType): Need to pass
23908 BindingFlags.Instance as well
23910 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
23911 implicit int literal conversion in an empty cast so that we
23912 propagate the right type upstream.
23914 (UnboxCast): new class used to unbox value types.
23915 (Expression.ConvertExplicit): Add explicit type conversions done
23918 (Expression.ImplicitNumericConversion): Oops, forgot to test for
23919 the target type before applying the implicit LongLiterals to ULong
23922 2001-11-21 Miguel de Icaza <miguel@ximian.com>
23924 * cs-parser.jay (for_statement): Reworked the way For works: now
23925 we declare manually any variables that are introduced in
23926 for_initializer to solve the problem of having out-of-band code
23927 emition (that is what got for broken).
23929 (declaration_statement): Perform the actual variable declaration
23930 that used to be done in local_variable_declaration here.
23932 (local_variable_declaration): Do not declare anything, just pass
23933 the information on a DictionaryEntry
23935 2001-11-20 Ravi Pratap <ravi@ximian.com>
23937 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
23938 re-write of the logic to now make it recursive.
23940 (UpdateIndices): Re-write accordingly.
23942 Store element data in a separate ArrayData list in the above methods.
23944 (MakeByteBlob): Implement to dump the array data into a byte array.
23946 2001-11-19 Ravi Pratap <ravi@ximian.com>
23948 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
23951 * constant.cs (Define): Implement.
23953 (EmitConstant): Re-write fully.
23955 Pass in location info.
23957 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
23960 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
23961 DictionaryEntry since we need location info too.
23963 (constant_declaration): Update accordingly.
23965 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
23966 code into another method : UpdateIndices.
23968 2001-11-18 Ravi Pratap <ravi@ximian.com>
23970 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
23971 some type checking etc.
23973 2001-11-17 Ravi Pratap <ravi@ximian.com>
23975 * expression.cs (ArrayCreation::ValidateInitializers): Implement
23976 bits to provide dimension info if the user skips doing that.
23978 Update second constructor to store the rank correctly.
23980 2001-11-16 Ravi Pratap <ravi@ximian.com>
23982 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
23983 and try to implement.
23985 * ../errors/cs0150.cs : Add.
23987 * ../errors/cs0178.cs : Add.
23989 2001-11-16 Miguel de Icaza <miguel@ximian.com>
23991 * statement.cs: Implement foreach on multi-dimensional arrays.
23993 * parameter.cs (Parameters.GetParameterByName): Also lookup the
23994 name of the params argument.
23996 * expression.cs: Use EmitStoreOpcode to get the right opcode while
23997 initializing the array.
23999 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
24000 we can use this elsewhere.
24002 * statement.cs: Finish implementation of foreach for single
24005 * cs-parser.jay: Use an out-of-band stack to pass information
24006 around, I wonder why I need this.
24008 foreach_block: Make the new foreach_block the current_block.
24010 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
24011 function used to return a static Parameters structure. Used for
24012 empty parameters, as those are created very frequently.
24014 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
24016 2001-11-15 Ravi Pratap <ravi@ximian.com>
24018 * interface.cs : Default modifier is private, not public. The
24019 make verify test passes again.
24021 2001-11-15 Ravi Pratap <ravi@ximian.com>
24023 * support.cs (ReflectionParameters): Fix logic to determine
24024 whether the last parameter is a params one. Test 9 passes again.
24026 * delegate.cs (Populate): Register the builders we define with
24027 RegisterParameterForBuilder. Test 19 passes again.
24029 * cs-parser.jay (property_declaration): Reference $6 instead
24030 of $$ to get at the location.
24032 (indexer_declaration): Similar stuff.
24034 (attribute): Ditto.
24036 * class.cs (Property): Register parameters for the Get and Set methods
24037 if they exist. Test 23 passes again.
24039 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
24040 call to EmitArguments as we are sure there aren't any params arguments.
24041 Test 32 passes again.
24043 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
24044 IndexOutOfRangeException.
24046 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
24047 Test 33 now passes again.
24049 2001-11-15 Miguel de Icaza <miguel@ximian.com>
24051 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
24052 broke a bunch of things. Will have to come up with a better way
24053 of tracking locations.
24055 * statement.cs: Implemented foreach for single dimension arrays.
24057 2001-11-09 Miguel de Icaza <miguel@ximian.com>
24059 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
24060 an error. This removes the lookup from the critical path.
24062 * cs-parser.jay: Removed use of temporary_loc, which is completely
24065 2001-11-14 Miguel de Icaza <miguel@ximian.com>
24067 * support.cs (ReflectionParameters.ParameterModifier): Report
24068 whether the argument is a PARAMS argument or not.
24070 * class.cs: Set the attribute `ParamArrayAttribute' on the
24071 parameter argument.
24073 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
24074 and cons_param_array_attribute (ConstructorInfo for
24075 ParamArrayAttribute).,
24077 * codegen.cs: Emit the return using the `Return' statement, that
24078 way we can report the error correctly for missing return values.
24080 * class.cs (Method.Emit): Clean up.
24082 * expression.cs (Argument.Resolve): Take another argument: the
24083 location where this argument is used. Notice that this is not
24084 part of the "Argument" class as to reduce the size of the
24085 structure (we know the approximate location anyways).
24087 Test if the argument is a variable-reference, if not, then
24088 complain with a 206.
24090 (Argument.Emit): Emit addresses of variables.
24092 (Argument.FullDesc): Simplify.
24094 (Invocation.DoResolve): Update for Argument.Resolve.
24096 (ElementAccess.DoResolve): ditto.
24098 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
24099 method should be virtual, as this method is always virtual.
24101 (NewDelegate.DoResolve): Update for Argument.Resolve.
24103 * class.cs (ConstructorInitializer.DoResolve): ditto.
24105 * attribute.cs (Attribute.Resolve): ditto.
24107 2001-11-13 Miguel de Icaza <miguel@ximian.com>
24109 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
24111 * expression.cs (ParameterReference): Drop IStackStorage and implement
24112 IAssignMethod instead.
24114 (LocalVariableReference): ditto.
24116 * ecore.cs (FieldExpr): Drop IStackStorage and implement
24117 IAssignMethod instead.
24119 2001-11-13 Miguel de Icaza <miguel@ximian.com>
24121 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
24122 enumerations that are used in heavily used structures derive from
24123 byte in a laughable and pathetic attempt to reduce memory usage.
24124 This is the kind of pre-optimzations that you should not do at
24125 home without adult supervision.
24127 * expression.cs (UnaryMutator): New class, used to handle ++ and
24128 -- separatedly from the other unary operators. Cleans up the
24129 code, and kills the ExpressionStatement dependency in Unary.
24131 (Unary): Removed `method' and `Arguments' from this class, making
24132 it smaller, and moving it all to SimpleCall, so I can reuse this
24133 code in other locations and avoid creating a lot of transient data
24134 strucutres when not required.
24136 * cs-parser.jay: Adjust for new changes.
24138 2001-11-11 Miguel de Icaza <miguel@ximian.com>
24140 * enum.cs (Enum.Populate): If there is a failure during
24143 * cs-parser.jay (opt_enum_base): we used to catch type errors
24144 here, but this is really incorrect. The type error should be
24145 catched during semantic analysis.
24147 2001-12-11 Ravi Pratap <ravi@ximian.com>
24149 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
24150 current_local_parameters as expected since I, in my stupidity, had forgotten
24153 * attribute.cs (GetValidPlaces): Fix stupid bug.
24155 * class.cs (Method::Emit): Perform check on applicability of attributes.
24157 (Constructor::Emit): Ditto.
24159 (Field::Emit): Ditto.
24161 (Field.Location): Store location information.
24163 (Property, Event, Indexer, Operator): Ditto.
24165 * cs-parser.jay (field_declaration): Pass in location for each field.
24167 * ../errors/cs0592.cs : Add.
24169 2001-11-12 Ravi Pratap <ravi@ximian.com>
24171 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
24173 (InitCoreTypes): Update accordingly.
24175 (RegisterAttrType, LookupAttr): Implement.
24177 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
24178 info about the same.
24180 (Resolve): Update to populate the above as necessary.
24182 (Error592): Helper.
24184 (GetValidPlaces): Helper to the above.
24186 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
24188 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
24190 2001-11-12 Ravi Pratap <ravi@ximian.com>
24192 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
24194 * ../errors/cs0617.cs : Add.
24196 2001-11-11 Ravi Pratap <ravi@ximian.com>
24198 * enum.cs (Emit): Rename to Populate to be more consistent with what
24199 we expect it to do and when exactly it is called.
24201 * class.cs, rootcontext.cs : Update accordingly.
24203 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
24204 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
24206 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
24208 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
24209 of a fieldinfo using the above, when dealing with a FieldBuilder.
24211 2001-11-10 Ravi Pratap <ravi@ximian.com>
24213 * ../errors/cs0031.cs : Add.
24215 * ../errors/cs1008.cs : Add.
24217 * ../errrors/cs0543.cs : Add.
24219 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
24222 (FindMembers): Implement.
24224 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
24225 enums and delegates too.
24227 (enum_types): Rename to builder_to_enum.
24229 (delegate_types): Rename to builder_to_delegate.
24231 * delegate.cs (FindMembers): Implement.
24233 2001-11-09 Ravi Pratap <ravi@ximian.com>
24235 * typemanager.cs (IsEnumType): Implement.
24237 * enum.cs (Emit): Re-write parts to account for the underlying type
24238 better and perform checking etc.
24240 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
24241 of the underlying type.
24243 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
24246 * enum.cs (error31): Helper to report error #31.
24248 * cs-parser.jay (enum_declaration): Store location of each member too.
24250 * enum.cs (member_to_location): New hashtable.
24252 (AddEnumMember): Update location hashtable.
24254 (Emit): Use the location of each member while reporting errors.
24256 2001-11-09 Miguel de Icaza <miguel@ximian.com>
24258 * cs-parser.jay: A for_initializer if is a
24259 local_variable_declaration really ammount to have an implicit
24260 block with the variable declaration and no initializer for for.
24262 * statement.cs (For.Emit): Cope with null initializers.
24264 This fixes the infinite loop on for initializers.
24266 2001-11-08 Miguel de Icaza <miguel@ximian.com>
24268 * enum.cs: More cleanup.
24270 * ecore.cs: Remove dead code.
24272 * class.cs (Property.Emit): More simplification.
24273 (Event.Emit): ditto.
24275 Reworked to have less levels of indentation.
24277 2001-11-08 Ravi Pratap <ravi@ximian.com>
24279 * class.cs (Property): Emit attributes.
24289 * enum.cs (Emit): Ditto.
24291 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
24294 * class.cs (Field, Event, etc.): Move attribute generation into the
24295 Emit method everywhere.
24297 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
24298 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
24299 as we had no way of defining nested enums !
24301 * rootcontext.cs : Adjust code accordingly.
24303 * typemanager.cs (AddEnumType): To keep track of enum types separately.
24305 2001-11-07 Ravi Pratap <ravi@ximian.com>
24307 * expression.cs (EvalConstantExpression): Move into ecore.cs
24309 * enum.cs (Enum): Rename some members and make them public and readonly
24310 according to our convention.
24312 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
24315 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
24317 (Enum::Emit): Write a simple version for now which doesn't try to compute
24318 expressions. I shall modify this to be more robust in just a while.
24320 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
24322 (TypeContainer::CloseType): Create the Enum types too.
24324 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
24326 * expression.cs (EvalConstantExpression): Get rid of completely.
24328 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
24329 user-defined values and other cases.
24331 (IsValidEnumLiteral): Helper function.
24333 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
24334 out there in the case we had a literal FieldExpr.
24336 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
24338 (Literalize): Revamp a bit to take two arguments.
24340 (EnumLiteral): New class which derives from Literal to wrap enum literals.
24342 2001-11-06 Ravi Pratap <ravi@ximian.com>
24344 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
24346 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
24348 (Resolve): Use the above to ensure we have proper initializers.
24350 2001-11-05 Ravi Pratap <ravi@ximian.com>
24352 * expression.cs (Expression::EvalConstantExpression): New method to
24353 evaluate constant expressions.
24355 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
24357 2001-11-07 Miguel de Icaza <miguel@ximian.com>
24359 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
24362 (Binary.ResolveOperator): Handle operator != (object a, object b)
24363 and operator == (object a, object b);
24365 (Binary.DoNumericPromotions): Indicate whether the numeric
24366 promotion was possible.
24368 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
24371 Made the ArrayAccess implement interface IAssignMethod instead of
24372 IStackStore as the order in which arguments are passed reflects
24375 * assign.cs: Instead of using expr.ExprClass to select the way of
24376 assinging, probe for the IStackStore/IAssignMethod interfaces.
24378 * typemanager.cs: Load InitializeArray definition.
24380 * rootcontext.cs (RootContext.MakeStaticData): Used to define
24381 static data that can be used to initialize arrays.
24383 2001-11-05 Miguel de Icaza <miguel@ximian.com>
24385 * expression.cs: Handle operator== and operator!= for booleans.
24387 (Conditioal.Reduce): Implement reducer for the ?: operator.
24389 (Conditional.Resolve): Implement dead code elimination.
24391 (Binary.Resolve): Catch string literals and return a new
24392 concatenated string.
24394 (Unary.Reduce): Implement reduction of unary expressions.
24396 * ecore.cs: Split out the expression core handling here.
24398 (Expression.Reduce): New method used to perform constant folding
24399 and CSE. This is needed to support constant-expressions.
24401 * statement.cs (Statement.EmitBoolExpression): Pass true and false
24402 targets, and optimize for !x.
24404 2001-11-04 Ravi Pratap <ravi@ximian.com>
24406 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
24407 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
24408 set custom atttributes.
24410 * literal.cs (Literal::GetValue): New abstract method to return the actual
24411 value of the literal, cast as an object.
24413 (*Literal): Implement GetValue method.
24415 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
24416 expressions to the arraylist but objects of type Argument.
24418 * class.cs (TypeContainer::Emit): Emit our attributes too.
24420 (Method::Emit, Constructor::Emit): Ditto.
24422 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
24423 to be ignoring earlier.
24425 2001-11-03 Ravi Pratap <ravi@ximian.com>
24427 * attribute.cs (AttributeSection::Define): Implement to do the business
24428 of constructing a CustomAttributeBuilder.
24430 (Attribute): New trivial class. Increases readability of code.
24432 * cs-parser.jay : Update accordingly.
24434 (positional_argument_list, named_argument_list, named_argument): New rules
24436 (attribute_arguments): Use the above so that we are more correct.
24438 2001-11-02 Ravi Pratap <ravi@ximian.com>
24440 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
24441 to perform all checks for a method with a params parameter.
24443 (Invocation::OverloadResolve): Update to use the above method and therefore
24444 cope correctly with params method invocations.
24446 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
24449 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
24450 constructors in our parent too because we can't afford to miss out on
24453 * attribute.cs (AttributeSection): New name for the class Attribute
24455 Other trivial changes to improve readability.
24457 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
24458 use the new class names.
24460 2001-11-01 Ravi Pratap <ravi@ximian.com>
24462 * class.cs (Method::Define): Complete definition for params types too
24464 (Indexer::Define): Ditto.
24466 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
24467 Cope everywhere with a request for info about the array parameter.
24469 2001-11-01 Ravi Pratap <ravi@ximian.com>
24471 * tree.cs (RecordNamespace): Fix up to check for the correct key.
24473 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
24474 local_variable_type to extract the string corresponding to the type.
24476 (local_variable_type): Fixup the action to use the new helper method.
24478 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
24481 * expression.cs : Clean out code which uses the above.
24483 2001-10-31 Ravi Pratap <ravi@ximian.com>
24485 * typemanager.cs (RegisterMethod): Check if we already have an existing key
24486 and bale out if necessary by returning a false.
24488 (RegisterProperty): Ditto.
24490 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
24491 and print out appropriate error messages.
24493 * interface.cs (everywhere): Ditto.
24495 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
24496 location to constructor.
24498 * class.cs (Property, Event, Indexer): Update accordingly.
24500 * ../errors/cs111.cs : Added.
24502 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
24503 of a method, as laid down by the spec.
24505 (Invocation::OverloadResolve): Use the above method.
24507 2001-10-31 Ravi Pratap <ravi@ximian.com>
24509 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
24510 now take a TypeContainer and a Parameters object.
24512 (ParameterData): Modify return type of ParameterModifier method to be
24513 Parameter.Modifier and not a string.
24515 (ReflectionParameters, InternalParameters): Update accordingly.
24517 * expression.cs (Argument::GetParameterModifier): Same here.
24519 * support.cs (InternalParameters::ParameterType): Find a better way of determining
24520 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
24521 symbol in it at all so maybe this is only for now.
24523 2001-10-30 Ravi Pratap <ravi@ximian.com>
24525 * support.cs (InternalParameters): Constructor now takes an extra argument
24526 which is the actual Parameters class.
24528 (ParameterDesc): Update to provide info on ref/out modifiers.
24530 * class.cs (everywhere): Update call to InternalParameters to pass in
24531 the second argument too.
24533 * support.cs (ParameterData): Add ParameterModifier, which is a method
24534 to return the modifier info [ref/out etc]
24536 (InternalParameters, ReflectionParameters): Implement the above.
24538 * expression.cs (Argument::ParameterModifier): Similar function to return
24539 info about the argument's modifiers.
24541 (Invocation::OverloadResolve): Update to take into account matching modifiers
24544 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
24545 a new SetFormalParameters object which we pass to InternalParameters.
24547 2001-10-30 Ravi Pratap <ravi@ximian.com>
24549 * expression.cs (NewArray): Merge into the ArrayCreation class.
24551 2001-10-29 Ravi Pratap <ravi@ximian.com>
24553 * expression.cs (NewArray): Merge classes NewBuiltinArray and
24554 NewUserdefinedArray into one as there wasn't much of a use in having
24557 * expression.cs (Argument): Change field's name to ArgType from Type.
24559 (Type): New readonly property which returns the proper type, taking into
24560 account ref/out modifiers.
24562 (everywhere): Adjust code accordingly for the above.
24564 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
24565 whether we are emitting for a ref or out parameter.
24567 * expression.cs (Argument::Emit): Use the above field to set the state.
24569 (LocalVariableReference::Emit): Update to honour the flag and emit the
24572 * parameter.cs (Attributes): Set the correct flags for ref parameters.
24574 * expression.cs (Argument::FullDesc): New function to provide a full desc.
24576 * support.cs (ParameterData): Add method ParameterDesc to the interface.
24578 (ReflectionParameters, InternalParameters): Implement the above method.
24580 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
24583 (Invocation::FullMethodDesc): Ditto.
24585 2001-10-29 Miguel de Icaza <miguel@ximian.com>
24587 * cs-parser.jay: Add extra production for the second form of array
24590 * expression.cs (ArrayCreation): Update to reflect the above
24593 * Small changes to prepare for Array initialization.
24595 2001-10-28 Miguel de Icaza <miguel@ximian.com>
24597 * typemanager.cs (ImplementsInterface): interface might be null;
24598 Deal with this problem;
24600 Also, we do store negative hits on the cache (null values), so use
24601 this instead of calling t.GetInterfaces on the type everytime.
24603 2001-10-28 Ravi Pratap <ravi@ximian.com>
24605 * typemanager.cs (IsBuiltinType): New method to help determine the same.
24607 * expression.cs (New::DoResolve): Get rid of array creation code and instead
24608 split functionality out into different classes.
24610 (New::FormArrayType): Move into NewBuiltinArray.
24612 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
24615 (NewBuiltinArray): New class to handle creation of built-in arrays.
24617 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
24618 account creation of one-dimensional arrays.
24620 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
24622 (NewUserdefinedArray::DoResolve): Implement.
24624 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
24626 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
24627 we maintain inside the TypeManager. This is necessary to perform lookups on the
24630 (LookupType): Update to perform GetType on the module builders too.
24632 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
24634 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
24636 2001-10-23 Ravi Pratap <ravi@ximian.com>
24638 * expression.cs (New::DoResolve): Implement guts of array creation.
24640 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
24642 2001-10-27 Miguel de Icaza <miguel@ximian.com>
24644 * expression.cs: Fix bug I introduced lsat night that broke
24647 (Expression.Resolve): Report a 246 error (can not resolve name)
24648 if we find a SimpleName in the stream.
24650 (Expression.ResolveLValue): Ditto.
24652 (Expression.ResolveWithSimpleName): This function is a variant of
24653 ResolveName, this one allows SimpleNames to be returned without a
24654 warning. The only consumer of SimpleNames is MemberAccess
24656 2001-10-26 Miguel de Icaza <miguel@ximian.com>
24658 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
24659 might arrive here. I have my doubts that this is correct.
24661 * statement.cs (Lock): Implement lock statement.
24663 * cs-parser.jay: Small fixes to support `lock' and `using'
24665 * cs-tokenizer.cs: Remove extra space
24667 * driver.cs: New flag --checked, allows to turn on integer math
24670 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
24671 Threading.Monitor.Exit
24673 2001-10-23 Miguel de Icaza <miguel@ximian.com>
24675 * expression.cs (IndexerAccess::DoResolveLValue): Set the
24676 Expression Class to be IndexerAccess.
24678 Notice that Indexer::DoResolve sets the eclass to Value.
24680 2001-10-22 Miguel de Icaza <miguel@ximian.com>
24682 * class.cs (TypeContainer::Emit): Emit code for indexers.
24684 * assign.cs (IAssignMethod): New interface implemented by Indexers
24685 and Properties for handling assignment.
24687 (Assign::Emit): Simplify and reuse code.
24689 * expression.cs (IndexerAccess, PropertyExpr): Implement
24690 IAssignMethod, clean up old code.
24692 2001-10-22 Ravi Pratap <ravi@ximian.com>
24694 * typemanager.cs (ImplementsInterface): New method to determine if a type
24695 implements a given interface. Provides a nice cache too.
24697 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
24700 (ConvertReferenceExplicit): Ditto.
24702 * delegate.cs (Delegate::Populate): Update to define the parameters on the
24703 various methods, with correct names etc.
24705 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
24706 Operator.UnaryNegation.
24708 * cs-parser.jay (operator_declarator): Be a little clever in the case where
24709 we have a unary plus or minus operator.
24711 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
24714 * everywhere : update accordingly.
24716 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
24719 * class.cs (Method::Define): For the case where we are implementing a method
24720 inherited from an interface, we need to set the MethodAttributes.Final flag too.
24721 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
24723 2001-10-21 Ravi Pratap <ravi@ximian.com>
24725 * interface.cs (FindMembers): Implement to work around S.R.E
24728 * typemanager.cs (IsInterfaceType): Implement.
24730 (FindMembers): Update to handle interface types too.
24732 * expression.cs (ImplicitReferenceConversion): Re-write bits which
24733 use IsAssignableFrom as that is not correct - it doesn't work.
24735 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
24736 and accordingly override EmitStatement.
24738 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
24739 using the correct logic :-)
24741 2001-10-19 Ravi Pratap <ravi@ximian.com>
24743 * ../errors/cs-11.cs : Add to demonstrate error -11
24745 2001-10-17 Miguel de Icaza <miguel@ximian.com>
24747 * assign.cs (Assign::Resolve): Resolve right hand side first, and
24748 then pass this as a hint to ResolveLValue.
24750 * expression.cs (FieldExpr): Add Location information
24752 (FieldExpr::LValueResolve): Report assignment to readonly
24755 (Expression::ExprClassFromMemberInfo): Pass location information.
24757 (Expression::ResolveLValue): Add new method that resolves an
24760 (Expression::DoResolveLValue): Default invocation calls
24763 (Indexers): New class used to keep track of indexers in a given
24766 (IStackStore): Renamed from LValue, as it did not really describe
24767 what this did. Also ResolveLValue is gone from this interface and
24768 now is part of Expression.
24770 (ElementAccess): Depending on the element access type
24772 * typemanager.cs: Add `indexer_name_type' as a Core type
24773 (System.Runtime.CompilerServices.IndexerNameAttribute)
24775 * statement.cs (Goto): Take a location.
24777 2001-10-18 Ravi Pratap <ravi@ximian.com>
24779 * delegate.cs (Delegate::VerifyDelegate): New method to verify
24780 if two delegates are compatible.
24782 (NewDelegate::DoResolve): Update to take care of the case when
24783 we instantiate a delegate from another delegate.
24785 * typemanager.cs (FindMembers): Don't even try to look up members
24786 of Delegate types for now.
24788 2001-10-18 Ravi Pratap <ravi@ximian.com>
24790 * delegate.cs (NewDelegate): New class to take care of delegate
24793 * expression.cs (New): Split the delegate related code out into
24794 the NewDelegate class.
24796 * delegate.cs (DelegateInvocation): New class to handle delegate
24799 * expression.cs (Invocation): Split out delegate related code into
24800 the DelegateInvocation class.
24802 2001-10-17 Ravi Pratap <ravi@ximian.com>
24804 * expression.cs (New::DoResolve): Implement delegate creation fully
24805 and according to the spec.
24807 (New::DoEmit): Update to handle delegates differently.
24809 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
24810 because of which we were printing out arguments in reverse order !
24812 * delegate.cs (VerifyMethod): Implement to check if the given method
24813 matches the delegate.
24815 (FullDelegateDesc): Implement.
24817 (VerifyApplicability): Implement.
24819 * expression.cs (Invocation::DoResolve): Update to accordingly handle
24820 delegate invocations too.
24822 (Invocation::Emit): Ditto.
24824 * ../errors/cs1593.cs : Added.
24826 * ../errors/cs1594.cs : Added.
24828 * delegate.cs (InstanceExpression, TargetMethod): New properties.
24830 2001-10-16 Ravi Pratap <ravi@ximian.com>
24832 * typemanager.cs (intptr_type): Core type for System.IntPtr
24834 (InitCoreTypes): Update for the same.
24836 (iasyncresult_type, asynccallback_type): Ditto.
24838 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
24841 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
24844 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
24845 the builders for the 4 members of a delegate type :-)
24847 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
24850 * expression.cs (New::DoResolve): Implement guts for delegate creation.
24852 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
24854 2001-10-15 Miguel de Icaza <miguel@ximian.com>
24856 * statement.cs (Break::Emit): Implement.
24857 (Continue::Emit): Implement.
24859 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
24860 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
24861 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
24862 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
24865 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
24866 properties that track the label for the current loop (begin of the
24867 loop and end of the loop).
24869 2001-10-15 Ravi Pratap <ravi@ximian.com>
24871 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
24872 use of emitting anything at all.
24874 * class.cs, rootcontext.cs : Get rid of calls to the same.
24876 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
24878 (Populate): Define the constructor correctly and set the implementation
24881 * typemanager.cs (delegate_types): New hashtable to hold delegates that
24884 (AddDelegateType): Implement.
24886 (IsDelegateType): Implement helper method.
24888 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
24890 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
24891 and accordingly handle it.
24893 * delegate.cs (Populate): Take TypeContainer argument.
24894 Implement bits to define the Invoke method. However, I still haven't figured out
24895 how to take care of the native int bit :-(
24897 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
24898 Qualify the name of the delegate, not its return type !
24900 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
24903 (StandardConversionExists): Checking for array types turns out to be recursive.
24905 (ConvertReferenceExplicit): Implement array conversion.
24907 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
24909 2001-10-12 Ravi Pratap <ravi@ximian.com>
24911 * cs-parser.jay (delegate_declaration): Store the fully qualified
24912 name as it is a type declaration.
24914 * delegate.cs (ReturnType, Name): Rename members to these. Make them
24917 (DefineDelegate): Renamed from Define. Does the same thing essentially,
24918 as TypeContainer::DefineType.
24920 (Populate): Method in which all the definition of the various methods (Invoke)
24923 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
24926 (CloseDelegate): Finally creates the delegate.
24928 * class.cs (TypeContainer::DefineType): Update to define delegates.
24929 (Populate, Emit and CloseType): Do the same thing here too.
24931 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
24932 delegates in all these operations.
24934 2001-10-14 Miguel de Icaza <miguel@ximian.com>
24936 * expression.cs: LocalTemporary: a new expression used to
24937 reference a temporary that has been created.
24939 * assign.cs: Handle PropertyAccess back here, so that we can
24940 provide the proper semantic access to properties.
24942 * expression.cs (Expression::ConvertReferenceExplicit): Implement
24943 a few more explicit conversions.
24945 * modifiers.cs: `NEW' modifier maps to HideBySig.
24947 * expression.cs (PropertyExpr): Make this into an
24948 ExpressionStatement, and support the EmitStatement code path.
24950 Perform get/set error checking, clean up the interface.
24952 * assign.cs: recognize PropertyExprs as targets, and if so, turn
24953 them into toplevel access objects.
24955 2001-10-12 Miguel de Icaza <miguel@ximian.com>
24957 * expression.cs: PropertyExpr::PropertyExpr: use work around the
24960 * typemanager.cs: Keep track here of our PropertyBuilders again to
24961 work around lameness in SRE.
24963 2001-10-11 Miguel de Icaza <miguel@ximian.com>
24965 * expression.cs (LValue::LValueResolve): New method in the
24966 interface, used to perform a second resolution pass for LValues.
24968 (This::DoResolve): Catch the use of this in static methods.
24970 (This::LValueResolve): Implement.
24972 (This::Store): Remove warning, assigning to `this' in structures
24975 (Invocation::Emit): Deal with invocation of
24976 methods on value types. We need to pass the address to structure
24977 methods rather than the object itself. (The equivalent code to
24978 emit "this" for structures leaves the entire structure on the
24979 stack instead of a pointer to it).
24981 (ParameterReference::DoResolve): Compute the real index for the
24982 argument based on whether the method takes or not a `this' pointer
24983 (ie, the method is static).
24985 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
24986 value types returned from functions when we need to invoke a
24987 method on the sturcture.
24990 2001-10-11 Ravi Pratap <ravi@ximian.com>
24992 * class.cs (TypeContainer::DefineType): Method to actually do the business of
24993 defining the type in the Modulebuilder or Typebuilder. This is to take
24994 care of nested types which need to be defined on the TypeBuilder using
24995 DefineNestedMethod.
24997 (TypeContainer::GetClassBases): Implement. Essentially the code from the
24998 methods in RootContext, only ported to be part of TypeContainer.
25000 (TypeContainer::GetInterfaceOrClass): Ditto.
25002 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
25004 * interface.cs (Interface::DefineInterface): New method. Does exactly
25005 what RootContext.CreateInterface did earlier, only it takes care of nested types
25008 (Interface::GetInterfaces): Move from RootContext here and port.
25010 (Interface::GetInterfaceByName): Same here.
25012 * rootcontext.cs (ResolveTree): Re-write.
25014 (PopulateTypes): Re-write.
25016 * class.cs (TypeContainer::Populate): Populate nested types too.
25017 (TypeContainer::Emit): Emit nested members too.
25019 * typemanager.cs (AddUserType): Do not make use of the FullName property,
25020 instead just use the name argument passed in as it is already fully
25023 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
25024 to TypeContainer mapping to see if a type is user-defined.
25026 * class.cs (TypeContainer::CloseType): Implement.
25028 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
25029 the default constructor.
25031 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
25034 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
25036 * interface.cs (CloseType): Create the type here.
25038 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
25041 Remove all the methods which are now in TypeContainer.
25043 2001-10-10 Ravi Pratap <ravi@ximian.com>
25045 * delegate.cs (Define): Re-write bits to define the delegate
25048 2001-10-10 Miguel de Icaza <miguel@ximian.com>
25050 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
25052 * expression.cs (ImplicitReferenceConversion): handle null as well
25053 as a source to convert to any reference type.
25055 * statement.cs (Return): Perform any implicit conversions to
25056 expected return type.
25058 Validate use of return statement.
25060 * codegen.cs (EmitContext): Pass the expected return type here.
25062 * class.cs (Method, Constructor, Property): Pass expected return
25063 type to EmitContext.
25065 2001-10-09 Miguel de Icaza <miguel@ximian.com>
25067 * expression.cs: Make DoResolve take an EmitContext instead of a
25070 Replaced `l' and `location' for `loc', for consistency.
25072 (Error, Warning): Remove unneeded Tc argument.
25074 * assign.cs, literal.cs, constant.cs: Update to new calling
25077 * codegen.cs: EmitContext now contains a flag indicating whether
25078 code is being generated in a static method or not.
25080 * cs-parser.jay: DecomposeQI, new function that replaces the old
25081 QualifiedIdentifier. Now we always decompose the assembled
25082 strings from qualified_identifier productions into a group of
25085 2001-10-08 Miguel de Icaza <miguel@ximian.com>
25087 * rootcontext.cs: Deal with field-less struct types correctly now
25088 by passing the size option to Define Type.
25090 * class.cs: Removed hack that created one static field.
25092 2001-10-07 Miguel de Icaza <miguel@ximian.com>
25094 * statement.cs: Moved most of the code generation here.
25096 2001-10-09 Ravi Pratap <ravi@ximian.com>
25098 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
25101 (ElementAccess): Remove useless bits for now - keep checks as the spec
25104 2001-10-08 Ravi Pratap <ravi@ximian.com>
25106 * expression.cs (ElementAccess::DoResolve): Remove my crap code
25107 and start performing checks according to the spec.
25109 2001-10-07 Ravi Pratap <ravi@ximian.com>
25111 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
25112 rank_specifiers instead.
25114 (rank_specifiers): Change the order in which the rank specifiers are stored
25116 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
25118 * expression.cs (ElementAccess): Implement the LValue interface too.
25120 2001-10-06 Ravi Pratap <ravi@ximian.com>
25122 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
25123 except that user defined conversions are not included.
25125 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
25126 perform the conversion of the return type, if necessary.
25128 (New::DoResolve): Check whether we are creating an array or an object
25129 and accordingly do the needful.
25131 (New::Emit): Same here.
25133 (New::DoResolve): Implement guts of array creation.
25135 (New::FormLookupType): Helper function.
25137 2001-10-07 Miguel de Icaza <miguel@ximian.com>
25139 * codegen.cs: Removed most of the code generation here, and move the
25140 corresponding code generation bits to the statement classes.
25142 Added support for try/catch/finalize and throw.
25144 * cs-parser.jay: Added support for try/catch/finalize.
25146 * class.cs: Catch static methods having the flags override,
25147 virtual or abstract.
25149 * expression.cs (UserCast): This user cast was not really doing
25150 what it was supposed to do. Which is to be born in fully resolved
25151 state. Parts of the resolution were being performed at Emit time!
25155 2001-10-05 Miguel de Icaza <miguel@ximian.com>
25157 * expression.cs: Implicity convert the result from UserCast.
25159 2001-10-05 Ravi Pratap <ravi@ximian.com>
25161 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
25162 prevented it from working correctly.
25164 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
25165 merely ConvertImplicit.
25167 2001-10-05 Miguel de Icaza <miguel@ximian.com>
25169 * typemanager.cs: Make the LookupTypeContainer function static,
25170 and not per-instance.
25172 * class.cs: Make static FindMembers (the one that takes a Type
25175 * codegen.cs: Add EmitForeach here.
25177 * cs-parser.jay: Make foreach a toplevel object instead of the
25178 inline expansion, as we need to perform semantic analysis on it.
25180 2001-10-05 Ravi Pratap <ravi@ximian.com>
25182 * expression.cs (Expression::ImplicitUserConversion): Rename to
25183 UserDefinedConversion.
25185 (Expression::UserDefinedConversion): Take an extra argument specifying
25186 whether we look for explicit user conversions too.
25188 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
25190 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
25192 (ExplicitUserConversion): Make it a call to UserDefinedConversion
25193 with the appropriate arguments.
25195 * cs-parser.jay (cast_expression): Record location too.
25197 * expression.cs (Cast): Record location info.
25199 (Expression::ConvertExplicit): Take location argument.
25201 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
25202 to determine if we are doing explicit conversions.
25204 (UserCast::Emit): Update accordingly.
25206 (Expression::ConvertExplicit): Report an error if everything fails.
25208 * ../errors/cs0030.cs : Add.
25210 2001-10-04 Miguel de Icaza <miguel@ximian.com>
25212 * modifiers.cs: If the ABSTRACT keyword is present, also set the
25213 virtual and newslot bits.
25215 * class.cs (TypeContainer::RegisterRequiredImplementations):
25216 Record methods we need.
25218 (TypeContainer::MakeKey): Helper function to make keys for
25219 MethodBases, since the Methodbase key is useless.
25221 (TypeContainer::Populate): Call RegisterRequiredImplementations
25222 before defining the methods.
25224 Create a mapping for method_builders_to_methods ahead of time
25225 instead of inside a tight loop.
25227 (::RequireMethods): Accept an object as the data to set into the
25228 hashtable so we can report interface vs abstract method mismatch.
25230 2001-10-03 Miguel de Icaza <miguel@ximian.com>
25232 * report.cs: Make all of it static.
25234 * rootcontext.cs: Drop object_type and value_type computations, as
25235 we have those in the TypeManager anyways.
25237 Drop report instance variable too, now it is a global.
25239 * driver.cs: Use try/catch on command line handling.
25241 Add --probe option to debug the error reporting system with a test
25244 * report.cs: Add support for exiting program when a probe
25245 condition is reached.
25247 2001-10-03 Ravi Pratap <ravi@ximian.com>
25249 * expression.cs (Binary::DoNumericPromotions): Fix the case when
25250 we do a forcible conversion regardless of type, to check if
25251 ForceConversion returns a null.
25253 (Binary::error19): Use location to report error.
25255 (Unary::error23): Use location here too.
25257 * ../errors/cs0019.cs : Check in.
25259 * ../errors/cs0023.cs : Check in.
25261 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
25262 case of a non-null MethodInfo object with a length of 0 !
25264 (Binary::ResolveOperator): Flag error if overload resolution fails to find
25265 an applicable member - according to the spec :-)
25266 Also fix logic to find members in base types.
25268 (Unary::ResolveOperator): Same here.
25270 (Unary::report23): Change name to error23 and make first argument a TypeContainer
25271 as I was getting thoroughly confused between this and error19 :-)
25273 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
25274 (::FindMostEncompassedType): Implement.
25275 (::FindMostEncompassingType): Implement.
25276 (::StandardConversionExists): Implement.
25278 (UserImplicitCast): Re-vamp. We now need info about most specific
25279 source and target types so that we can do the necessary conversions.
25281 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
25282 mathematical union with no duplicates.
25284 2001-10-03 Miguel de Icaza <miguel@ximian.com>
25286 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
25287 in order from base classes to child classes, so that we can in
25288 child classes look up in our parent for method names and
25289 attributes (required for handling abstract, virtual, new, override
25290 constructs: we need to instrospect our base class, and if we dont
25291 populate the classes in order, the introspection might be
25292 incorrect. For example, a method could query its parent before
25293 the parent has any methods and would determine that the parent has
25294 no abstract methods (while it could have had them)).
25296 (RootContext::CreateType): Record the order in which we define the
25299 2001-10-02 Miguel de Icaza <miguel@ximian.com>
25301 * class.cs (TypeContainer::Populate): Also method definitions can
25302 fail now, keep track of this.
25304 (TypeContainer::FindMembers): Implement support for
25305 DeclaredOnly/noDeclaredOnly flag.
25307 (Constructor::Emit) Return the ConstructorBuilder.
25309 (Method::Emit) Return the MethodBuilder.
25310 Check for abstract or virtual methods to be public.
25312 * rootcontext.cs (RootContext::CreateType): Register all the
25313 abstract methods required for the class to be complete and the
25314 interface methods that must be implemented.
25316 * cs-parser.jay: Report error 501 (method requires body if it is
25317 not marked abstract or extern).
25319 * expression.cs (TypeOf::Emit): Implement.
25321 * typemanager.cs: runtime_handle_type, new global type.
25323 * class.cs (Property::Emit): Generate code for properties.
25325 2001-10-02 Ravi Pratap <ravi@ximian.com>
25327 * expression.cs (Unary::ResolveOperator): Find operators on base type
25328 too - we now conform exactly to the spec.
25330 (Binary::ResolveOperator): Same here.
25332 * class.cs (Operator::Define): Fix minor quirk in the tests.
25334 * ../errors/cs0215.cs : Added.
25336 * ../errors/cs0556.cs : Added.
25338 * ../errors/cs0555.cs : Added.
25340 2001-10-01 Miguel de Icaza <miguel@ximian.com>
25342 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
25343 single integer which is really efficient
25345 2001-10-01 Ravi Pratap <ravi@ximian.com>
25347 * expression.cs (Expression::ImplicitUserConversion): Use location
25348 even in the case when we are examining True operators.
25350 * class.cs (Operator::Define): Perform extensive checks to conform
25351 with the rules for operator overloading in the spec.
25353 * expression.cs (Expression::ImplicitReferenceConversion): Implement
25354 some of the other conversions mentioned in the spec.
25356 * typemanager.cs (array_type): New static member for the System.Array built-in
25359 (cloneable_interface): For System.ICloneable interface.
25361 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
25362 we start resolving the tree and populating types.
25364 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
25366 2001-10-01 Miguel de Icaza <miguel@ximian.com>
25368 * expression.cs (Expression::ExprClassFromMemberInfo,
25369 Expression::Literalize): Create literal expressions from
25370 FieldInfos which are literals.
25372 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
25373 type casts, because they were wrong. The test suite in tests
25376 (ImplicitNumericConversion): ushort to ulong requires a widening
25379 Int32 constant to long requires widening cast as well.
25381 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
25382 for integers because the type on the stack is not i4.
25384 2001-09-30 Miguel de Icaza <miguel@ximian.com>
25386 * expression.cs (report118): require location argument.
25388 * parameter.cs: Do not dereference potential null value.
25390 * class.cs: Catch methods that lack the `new' keyword when
25391 overriding a name. Report warnings when `new' is used without
25392 anything being there to override.
25394 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
25396 * class.cs: Only add constructor to hashtable if it is non-null
25397 (as now constructors can fail on define).
25399 (TypeManager, Class, Struct): Take location arguments.
25401 Catch field instance initialization in structs as errors.
25403 accepting_filter: a new filter for FindMembers that is static so
25404 that we dont create an instance per invocation.
25406 (Constructor::Define): Catch errors where a struct constructor is
25409 * cs-parser.jay: Pass location information for various new
25412 * delegate.cs (Delegate): take a location argument.
25414 * driver.cs: Do not call EmitCode if there were problesm in the
25415 Definition of the types, as many Builders wont be there.
25417 * decl.cs (Decl::Decl): Require a location argument.
25419 * cs-tokenizer.cs: Handle properly hex constants that can not fit
25420 into integers, and find the most appropiate integer for it.
25422 * literal.cs: Implement ULongLiteral.
25424 * rootcontext.cs: Provide better information about the location of
25425 failure when CreateType fails.
25427 2001-09-29 Miguel de Icaza <miguel@ximian.com>
25429 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
25432 * expression.cs (Binary::CheckShiftArguments): Add missing type
25434 (Binary::ResolveOperator): Add type to the logical and and logical
25435 or, Bitwise And/Or and Exclusive Or code paths, it was missing
25438 (Binary::DoNumericPromotions): In the case where either argument
25439 is ulong (and most signed types combined with ulong cause an
25440 error) perform implicit integer constant conversions as well.
25442 2001-09-28 Miguel de Icaza <miguel@ximian.com>
25444 * expression.cs (UserImplicitCast): Method should always be
25446 (Invocation::BetterConversion): Simplified test for IntLiteral.
25448 (Expression::ImplicitNumericConversion): Split this routine out.
25449 Put the code that performs implicit constant integer conversions
25452 (Expression::Resolve): Become a wrapper around DoResolve so we can
25453 check eclass and type being set after resolve.
25455 (Invocation::Badness): Remove this dead function
25457 (Binary::ResolveOperator): Do not compute the expensive argumnets
25458 unless we have a union for it.
25460 (Probe::Emit): Is needs to do an isinst and then
25461 compare against null.
25463 (::CanConvert): Added Location argument. If the Location argument
25464 is null (Location.Null), then we do not report errors. This is
25465 used by the `probe' mechanism of the Explicit conversion. We do
25466 not want to generate an error for something that the user
25467 explicitly requested to be casted. But the pipeline for an
25468 explicit cast first tests for potential implicit casts.
25470 So for now, if the Location is null, it means `Probe only' to
25471 avoid adding another argument. Might have to revise this
25474 (ClassCast): New class used to type cast objects into arbitrary
25475 classes (used in Explicit Reference Conversions).
25477 Implement `as' as well.
25479 Reverted all the patches from Ravi below: they were broken:
25481 * The use of `level' as a mechanism to stop recursive
25482 invocations is wrong. That was there just to catch the
25483 bug with a strack trace but not as a way of addressing
25486 To fix the problem we have to *understand* what is going
25487 on and the interactions and come up with a plan, not
25488 just get things going.
25490 * The use of the type conversion cache that I proposed
25491 last night had an open topic: How does this work across
25492 protection domains. A user defined conversion might not
25493 be public in the location where we are applying the
25494 conversion, a different conversion might be selected
25495 (ie, private A->B (better) but public B->A (worse),
25496 inside A, A->B applies, but outside it, B->A will
25499 * On top of that (ie, even if the above is solved),
25500 conversions in a cache need to be abstract. Ie, `To
25501 convert from an Int to a Short use an OpcodeCast', not
25502 `To convert from an Int to a Short use the OpcodeCast on
25503 the variable 5' (which is what this patch was doing).
25505 2001-09-28 Ravi Pratap <ravi@ximian.com>
25507 * expression.cs (Invocation::ConversionExists): Re-write to use
25508 the conversion cache
25510 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
25511 cache all conversions done, not just user-defined ones.
25513 (Invocation::BetterConversion): The real culprit. Use ConversionExists
25514 to determine if a conversion exists instead of acutually trying to
25515 perform the conversion. It's faster too.
25517 (Expression::ConvertExplicit): Modify to use ConversionExists to check
25518 and only then attempt the implicit conversion.
25520 2001-09-28 Ravi Pratap <ravi@ximian.com>
25522 * expression.cs (ConvertImplicit): Use a cache for conversions
25523 already found. Check level of recursion and bail out if necessary.
25525 2001-09-28 Miguel de Icaza <miguel@ximian.com>
25527 * typemanager.cs (string_concat_string_string, string_concat_object_object):
25528 Export standard methods that we expect for string operations.
25530 * statement.cs (Block::UsageWarning): Track usage of variables and
25531 report the errors for not used variables.
25533 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
25536 2001-09-27 Miguel de Icaza <miguel@ximian.com>
25538 * codegen.cs: remove unnneded code
25540 * expression.cs: Removed BuiltinTypeAccess class
25542 Fix the order in which implicit conversions are
25545 The previous fixed dropped support for boxed conversions (adding a
25546 test to the test suite now)
25548 (UserImplicitCast::CanConvert): Remove test for source being null,
25549 that code is broken. We should not feed a null to begin with, if
25550 we do, then we should track the bug where the problem originates
25551 and not try to cover it up here.
25553 Return a resolved expression of type UserImplicitCast on success
25554 rather than true/false. Ravi: this is what I was talking about,
25555 the pattern is to use a static method as a "constructor" for
25558 Also, do not create arguments until the very last minute,
25559 otherwise we always create the arguments even for lookups that
25560 will never be performed.
25562 (UserImplicitCast::Resolve): Eliminate, objects of type
25563 UserImplicitCast are born in a fully resolved state.
25565 * typemanager.cs (InitCoreTypes): Init also value_type
25566 (System.ValueType).
25568 * expression.cs (Cast::Resolve): First resolve the child expression.
25570 (LValue): Add new method AddressOf to be used by
25573 Change the argument of Store to take an EmitContext instead of an
25574 ILGenerator, because things like FieldExpr need to be able to call
25575 their children expression to generate the instance code.
25577 (Expression::Error, Expression::Warning): Sugar functions for
25580 (Expression::MemberLookup): Accept a TypeContainer instead of a
25581 Report as the first argument.
25583 (Expression::ResolvePrimary): Killed. I still want to improve
25584 this as currently the code is just not right.
25586 (Expression::ResolveMemberAccess): Simplify, but it is still
25589 (Unary::Resolve): Catch errors in AddressOf operators.
25591 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
25592 index to a byte for the short-version, or the compiler will choose
25593 the wrong Emit call, which generates the wrong data.
25595 (ParameterReference::Emit, ::Store): same.
25597 (FieldExpr::AddressOf): Implement.
25599 * typemanager.cs: TypeManager: made public variable instead of
25602 * driver.cs: document --fatal.
25604 * report.cs (ErrorMessage, WarningMessage): new names for the old
25605 Error and Warning classes.
25607 * cs-parser.jay (member_access): Turn built-in access to types
25608 into a normal simplename
25610 2001-09-27 Ravi Pratap <ravi@ximian.com>
25612 * expression.cs (Invocation::BetterConversion): Fix to cope
25613 with q being null, since this was introducing a bug.
25615 * expression.cs (ConvertImplicit): Do built-in conversions first.
25617 2001-09-27 Ravi Pratap <ravi@ximian.com>
25619 * expression.cs (UserImplicitCast::Resolve): Fix bug.
25621 2001-09-27 Ravi Pratap <ravi@ximian.com>
25623 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
25624 I had introduced long ago (what's new ?).
25626 * expression.cs (UserImplicitCast::CanConvert): Static method to do
25627 the work of all the checking.
25628 (ConvertImplicit): Call CanConvert and only then create object if necessary.
25629 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
25631 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
25632 that is the right way.
25634 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
25635 overloading resolution. Use everywhere instead of cutting and pasting code.
25637 (Binary::ResolveOperator): Use MakeUnionSet.
25639 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
25640 we have to convert to bool types. Not complete yet.
25642 2001-09-27 Miguel de Icaza <miguel@ximian.com>
25644 * typemanager.cs (TypeManager::CSharpName): support ushort.
25646 * expression.cs (Expression::TryImplicitIntConversion): Attempts
25647 to provide an expression that performsn an implicit constant int
25648 conversion (section 6.1.6).
25649 (Expression::ConvertImplicitRequired): Reworked to include
25650 implicit constant expression conversions.
25652 (Expression::ConvertNumericExplicit): Finished.
25654 (Invocation::Emit): If InstanceExpression is null, then it means
25655 that we perform a call on this.
25657 2001-09-26 Miguel de Icaza <miguel@ximian.com>
25659 * expression.cs (Unary::Emit): Remove some dead code.
25660 (Probe): Implement Resolve and Emit for `is'.
25661 (Expression::ConvertImplicitRequired): Attempt to do constant
25662 expression conversions here. Maybe should be moved to
25663 ConvertImplicit, but I am not sure.
25664 (Expression::ImplicitLongConstantConversionPossible,
25665 Expression::ImplicitIntConstantConversionPossible): New functions
25666 that tell whether is it possible to apply an implicit constant
25667 expression conversion.
25669 (ConvertNumericExplicit): Started work on explicit numeric
25672 * cs-parser.jay: Update operator constants.
25674 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
25675 (Parameters::GetSignature): Hook up VerifyArgs here.
25676 (Parameters::VerifyArgs): Verifies that no two arguments have the
25679 * class.cs (Operator): Update the operator names to reflect the
25680 ones that the spec expects (as we are just stringizing the
25683 * expression.cs (Unary::ResolveOperator): Fix bug: Use
25684 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
25685 previous usage did only work for our methods.
25686 (Expression::ConvertImplicit): Handle decimal implicit numeric
25687 conversions as well.
25688 (Expression::InternalTypeConstructor): Used to invoke constructors
25689 on internal types for default promotions.
25691 (Unary::Emit): Implement special handling for the pre/post
25692 increment/decrement for overloaded operators, as they need to have
25693 the same semantics as the other operators.
25695 (Binary::ResolveOperator): ditto.
25696 (Invocation::ConversionExists): ditto.
25697 (UserImplicitCast::Resolve): ditto.
25699 2001-09-26 Ravi Pratap <ravi@ximian.com>
25701 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
25702 operator, return after emitting body. Regression tests pass again !
25704 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
25705 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
25706 (Invocation::OverloadResolve): Ditto.
25707 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
25709 * everywhere : update calls to the above methods accordingly.
25711 2001-09-26 Miguel de Icaza <miguel@ximian.com>
25713 * assign.cs (Assign): Make it inherit from ExpressionStatement.
25715 * expression.cs (ExpressionStatement): New base class used for
25716 expressions that can appear in statements, so that we can provide
25717 an alternate path to generate expression that do not leave a value
25720 (Expression::Emit, and all the derivatives): We no longer return
25721 whether a value is left on the stack or not. Every expression
25722 after being emitted leaves a single value on the stack.
25724 * codegen.cs (EmitContext::EmitStatementExpression): Use the
25725 facilties of ExpressionStatement if possible.
25727 * cs-parser.jay: Update statement_expression.
25729 2001-09-25 Miguel de Icaza <miguel@ximian.com>
25731 * driver.cs: Change the wording of message
25733 2001-09-25 Ravi Pratap <ravi@ximian.com>
25735 * expression.cs (Binary::ResolveOperator): Had forgottten to set
25736 the type of the expression to the return type of the method if
25737 we have an overloaded operator match ! The regression tests pass again !
25738 (Unary::ResolveOperator): Ditto.
25740 * expression.cs (Invocation::ConversionExists): Correct the member lookup
25741 to find "op_Implicit", not "implicit" ;-)
25742 (UserImplicitCast): New class to take care of user-defined implicit conversions.
25743 (ConvertImplicit, ForceConversion): Take TypeContainer argument
25745 * everywhere : Correct calls to the above accordingly.
25747 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
25748 (ConvertImplicit): Do user-defined conversion if it exists.
25750 2001-09-24 Miguel de Icaza <miguel@ximian.com>
25752 * assign.cs: track location.
25753 (Resolve): Use implicit conversions on assignment.
25755 * literal.cs: Oops. Not good, Emit of short access values should
25756 pass (Bytes) or the wrong argument will be selected.
25758 * expression.cs (Unary::Emit): Emit code for -expr.
25760 (Unary::ResolveOperator): Handle `Substract' for non-constants
25761 (substract from zero from the non-constants).
25762 Deal with Doubles as well.
25764 (Expression::ConvertImplicitRequired): New routine that reports an
25765 error if no implicit conversion exists.
25767 (Invocation::OverloadResolve): Store the converted implicit
25768 expressions if we make them
25770 2001-09-24 Ravi Pratap <ravi@ximian.com>
25772 * class.cs (ConstructorInitializer): Take a Location argument.
25773 (ConstructorBaseInitializer): Same here.
25774 (ConstructorThisInitializer): Same here.
25776 * cs-parser.jay : Update all calls accordingly.
25778 * expression.cs (Unary, Binary, New): Take location argument.
25779 Update accordingly everywhere.
25781 * cs-parser.jay : Update all calls to the above to take a location
25784 * class.cs : Ditto.
25786 2001-09-24 Ravi Pratap <ravi@ximian.com>
25788 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
25789 (Invocation::BetterConversion): Same here
25790 (Invocation::ConversionExists): Ditto.
25792 (Invocation::ConversionExists): Implement.
25794 2001-09-22 Ravi Pratap <ravi@ximian.com>
25796 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
25797 Also take an additional TypeContainer argument.
25799 * All over : Pass in TypeContainer as argument to OverloadResolve.
25801 * typemanager.cs (CSharpName): Update to check for the string type and return
25804 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
25807 2001-09-21 Ravi Pratap <ravi@ximian.com>
25809 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
25810 (Invocation::BetterFunction): Implement.
25811 (Invocation::BetterConversion): Implement.
25812 (Invocation::ConversionExists): Skeleton, no implementation yet.
25814 Okay, things work fine !
25816 2001-09-21 Miguel de Icaza <miguel@ximian.com>
25818 * typemanager.cs: declare and load enum_type, delegate_type and
25821 * expression.cs (Expression::Emit): Now emit returns a value that
25822 tells whether a value is left on the stack or not. This strategy
25823 might be reveted tomorrow with a mechanism that would address
25824 multiple assignments.
25825 (Expression::report118): Utility routine to report mismatches on
25828 (Unary::Report23): Report impossible type/operator combination
25831 (Unary::IsIncrementableNumber): Whether the type can be
25832 incremented or decremented with add.
25833 (Unary::ResolveOperator): Also allow enumerations to be bitwise
25835 (Unary::ResolveOperator): Implement ++, !, ~,
25837 (Invocation::Emit): Deal with new Emit convetion.
25839 * All Expression derivatives: Updated their Emit method to return
25840 whether they leave values on the stack or not.
25842 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
25843 stack for expressions that are statements.
25845 2001-09-20 Miguel de Icaza <miguel@ximian.com>
25847 * expression.cs (LValue): New interface. Must be implemented by
25849 (LocalVariableReference, ParameterReference, FieldExpr): Implement
25852 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
25853 interface for generating code, simplifies the code.
25855 2001-09-20 Ravi Pratap <ravi@ximian.com>
25857 * expression.cs (everywhere): Comment out return statements in ::Resolve
25858 methods to avoid the warnings.
25860 2001-09-20 Miguel de Icaza <miguel@ximian.com>
25862 * driver.cs (parse): Report error 2001 if we can not open the
25865 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
25868 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
25871 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
25872 otherwise nested blocks end up with the same index.
25874 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
25876 * expression.cs: Instead of having FIXMEs in the Resolve
25877 functions, throw exceptions so it is obvious that we are facing a
25880 * cs-parser.jay (invocation_expression): Pass Location information.
25882 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
25883 Use a basename for those routines because .NET does not like paths
25886 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
25889 2001-09-19 Miguel de Icaza <miguel@ximian.com>
25891 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
25892 are loading the correct data types (throws an exception if not).
25893 (TypeManager::InitCoreTypes): Use CoreLookupType
25895 * expression.cs (Unary::ResolveOperator): return the child
25896 expression for expressions which are just +expr.
25897 (Unary::ResolveOperator): Return negative literals for -LITERAL
25898 expressions (otherwise they are Unary {Literal}).
25899 (Invocation::Badness): Take into account `Implicit constant
25900 expression conversions'.
25902 * literal.cs (LongLiteral): Implement long literal class.
25903 (IntLiteral): export the `Value' of the intliteral.
25905 2001-09-19 Ravi Pratap <ravi@ximian.com>
25907 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
25909 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
25910 instead of 'Operator'
25912 * expression.cs (Binary::ResolveOperator): Update accordingly.
25913 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
25916 * cs-parser.jay (unary_expression): Update to use the new names.
25918 * gen-treedump.cs (GetUnary): Same here.
25920 * expression.cs (Unary::Resolve): Implement.
25921 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
25922 operators are found instead of making noise ;-)
25923 (Unary::ResolveOperator): New method to do precisely the same thing which
25924 Binary::ResolveOperator does for Binary expressions.
25925 (Unary.method, .Arguments): Add.
25926 (Unary::OperName): Implement.
25927 (Unary::ForceConversion): Copy and Paste !
25929 * class.cs (Operator::Define): Fix a small bug for the case when we have
25932 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
25933 for the inbuilt operators. Only overloading works for now ;-)
25935 2001-09-18 Miguel de Icaza <miguel@ximian.com>
25937 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
25938 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
25940 * expression.cs (This::Emit): Implement.
25941 (This::Resolve): Implement.
25942 (TypeOf:Resolve): Implement.
25943 (Expression::ResolveSimpleName): Add an implicit this to instance
25945 (MemberAccess::Resolve): Deal with Parameters and Fields.
25946 Bind instance variable to Field expressions.
25947 (FieldExpr::Instance): New field used to track the expression that
25948 represents the object instance.
25949 (FieldExpr::Resolve): Track potential errors from MemberLookup not
25951 (FieldExpr::Emit): Implement.
25953 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
25954 the last instruction contains a return opcode to avoid generating
25955 the last `ret' instruction (this generates correct code, and it is
25956 nice to pass the peverify output).
25958 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
25959 initializer for static and instance variables.
25960 (Constructor::Emit): Allow initializer to be null in the case of
25961 static constructors. Only emit initializer for instance
25964 (TypeContainer::FindMembers): Return a null array if there are no
25967 Also fix the code for the MemberTypes.Method branch, as it was not
25968 scanning that for operators (or tried to access null variables before).
25970 * assign.cs (Assign::Emit): Handle instance and static fields.
25974 * driver.cs: Stop compilation if there are parse errors.
25976 * cs-parser.jay (constructor_declaration): Provide default base
25977 initializer for non-static constructors.
25978 (constructor_declarator): Do not provide a default base
25979 initializers if none was specified.
25980 Catch the fact that constructors should not have parameters.
25982 * class.cs: Do not emit parent class initializers for static
25983 constructors, that should be flagged as an error.
25985 2001-09-18 Ravi Pratap <ravi@ximian.com>
25987 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
25988 Move back code into TypeContainer::Populate.
25990 2001-09-18 Ravi Pratap <ravi@ximian.com>
25992 * class.cs (TypeContainer::AddConstructor): Fix the check to
25993 compare against Name, not Basename.
25994 (Operator::OpType): Change Plus and Minus to Add and Subtract.
25996 * cs-parser.jay : Update accordingly.
25998 * class.cs (TypeContainer::FindMembers): For the case where we are searching
25999 for methods, don't forget to look into the operators too.
26000 (RegisterMethodBuilder): Helper method to take care of this for
26001 methods, constructors and operators.
26002 (Operator::Define): Completely revamp.
26003 (Operator.OperatorMethod, MethodName): New fields.
26004 (TypeContainer::Populate): Move the registering of builders into
26005 RegisterMethodBuilder.
26006 (Operator::Emit): Re-write.
26008 * expression.cs (Binary::Emit): Comment out code path to emit method
26009 invocation stuff for the case when we have a user defined operator. I am
26010 just not able to get it right !
26012 2001-09-17 Miguel de Icaza <miguel@ximian.com>
26014 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
26017 (Expression::MemberLookup): Provide a version that allows to
26018 specify the MemberTypes and BindingFlags.
26020 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
26021 so it was not fetching variable information from outer blocks.
26023 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
26024 Beforefieldinit as it was buggy.
26026 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
26027 that Ravi put here.
26029 * class.cs (Constructor::Emit): Only emit if block is not null.
26030 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
26031 deal with this by semantically definining it as if the user had
26034 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
26035 constructors as we now "emit" them at a higher level.
26037 (TypeContainer::DefineDefaultConstructor): Used to define the
26038 default constructors if none was provided.
26040 (ConstructorInitializer): Add methods Resolve and Emit.
26042 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
26044 2001-09-17 Ravi Pratap <ravi@ximian.com>
26046 * class.cs (TypeContainer::EmitDefaultConstructor): Register
26047 the default constructor builder with our hashtable for methodbuilders
26050 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
26051 and argument_count is 0 in which case we have a match.
26052 (Binary::ResolveOperator): More null checking and miscellaneous coding
26055 2001-09-17 Ravi Pratap <ravi@ximian.com>
26057 * rootcontext.cs (IsNameSpace): Compare against null.
26059 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
26061 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
26062 and Unary::Operator.
26064 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
26067 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
26068 we have overloaded operators.
26069 (Binary::ResolveOperator): Implement the part which does the operator overload
26072 * class.cs (Operator::Emit): Implement.
26073 (TypeContainer::Emit): Emit the operators we have too.
26075 * expression.cs (Binary::Emit): Update to emit the appropriate code for
26076 the case when we have a user-defined operator.
26078 2001-09-17 Miguel de Icaza <miguel@ximian.com>
26080 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
26082 2001-09-16 Ravi Pratap <ravi@ximian.com>
26084 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
26085 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
26086 (Constructor::Emit): Implement.
26087 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
26088 if we have no work to do.
26089 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
26092 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
26093 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
26095 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
26098 2001-09-15 Ravi Pratap <ravi@ximian.com>
26100 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
26102 (Tree::RecordNamespace): Method to do what the name says ;-)
26103 (Tree::Namespaces): Property to get at the namespaces hashtable.
26105 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
26108 * rootcontext.cs (IsNamespace): Fixed it :-)
26110 2001-09-14 Miguel de Icaza <miguel@ximian.com>
26112 * class.cs (TypeContainer::FindMembers): Add support for
26114 (MethodCore): New class that encapsulates both the shared aspects
26115 of a Constructor and a Method.
26116 (Method, Constructor): Factored pieces into MethodCore.
26118 * driver.cs: Added --fatal which makes errors throw exceptions.
26119 Load System assembly as well as part of the standard library.
26121 * report.cs: Allow throwing exceptions on errors for debugging.
26123 * modifiers.cs: Do not use `parent', instead use the real type
26124 container to evaluate permission settings.
26126 * class.cs: Put Ravi's patch back in. He is right, and we will
26127 have to cope with the
26129 2001-09-14 Ravi Pratap <ravi@ximian.com>
26131 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
26132 FamORAssem, not FamANDAssem.
26134 2001-09-14 Miguel de Icaza <miguel@ximian.com>
26136 * driver.cs: Added --parse option that only parses its input files
26139 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
26140 incorrect. IsTopLevel is not used to tell whether an object is
26141 root_types or not (that can be achieved by testing this ==
26142 root_types). But to see if this is a top-level *class* (not
26143 necessarly our "toplevel" container).
26145 2001-09-14 Ravi Pratap <ravi@ximian.com>
26147 * enum.cs (Enum::Define): Modify to call the Lookup method on the
26148 parent instead of a direct call to GetType.
26150 2001-09-14 Ravi Pratap <ravi@ximian.com>
26152 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
26153 Modifiers.TypeAttr. This should just be a call to that method.
26155 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
26156 object so that we can determine if we are top-level or not.
26158 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
26161 * enum.cs (Enum::Define): Ditto.
26163 * modifiers.cs (FieldAttr): Re-write.
26165 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
26166 (TypeContainer::HaveStaticConstructor): New property to provide access
26167 to precisely that info.
26169 * modifiers.cs (MethodAttr): Re-write.
26170 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
26172 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
26173 of top-level types as claimed.
26175 2001-09-13 Miguel de Icaza <miguel@ximian.com>
26177 * expression.cs (MemberLookup): Fruitless attempt to lookup
26178 constructors. Maybe I need to emit default constructors? That
26179 might be it (currently .NET emits this for me automatically).
26180 (Invocation::OverloadResolve): Cope with Arguments == null.
26181 (Invocation::EmitArguments): new function, shared by the new
26182 constructor and us.
26183 (Invocation::Emit): Handle static and instance methods. Emit
26184 proper call instruction for virtual or non-virtual invocations.
26185 (New::Emit): Implement.
26186 (New::Resolve): Implement.
26187 (MemberAccess:Resolve): Implement.
26188 (MethodGroupExpr::InstanceExpression): used conforming to the spec
26189 to track instances.
26190 (FieldExpr::Resolve): Set type.
26192 * support.cs: Handle empty arguments.
26194 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
26195 SimpleLookup): Auxiliary routines to help parse a qualifier
26198 Update qualifier_identifier rule.
26200 * codegen.cs: Removed debugging messages.
26202 * class.cs: Make this a global thing, this acts just as a "key" to
26203 objects that we might have around.
26205 (Populate): Only initialize method_builders_to_methods once.
26207 * expression.cs (PropertyExpr): Initialize type from the
26210 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
26211 Resolve pattern. Attempt to implicitly convert value to boolean.
26214 * expression.cs: Set the type for the int32/int32 argument case.
26215 (Binary::ResolveOperator): Set the return type to boolean for
26216 comparission operators
26218 * typemanager.cs: Remove debugging print code.
26220 (Invocation::Resolve): resolve type.
26222 * class.cs: Allocate a MemberInfo of the correct size, as the code
26223 elsewhere depends on the test to reflect the correct contents.
26225 (Method::) Keep track of parameters, due to System.Reflection holes
26227 (TypeContainer::Populate): Keep track of MethodBuilders to Method
26230 (TypeContainer::FindMembers): Use ArrayList and then copy an array
26231 of the exact size and return that.
26233 (Class::LookupMethodByBuilder): New function that maps
26234 MethodBuilders to its methods. Required to locate the information
26235 on methods because System.Reflection bit us again.
26237 * support.cs: New file, contains an interface ParameterData and
26238 two implementations: ReflectionParameters and InternalParameters
26239 used to access Parameter information. We will need to grow this
26242 * expression.cs (Invocation::GetParameterData): implement a cache
26243 and a wrapper around the ParameterData creation for methods.
26244 (Invocation::OverloadResolve): Use new code.
26246 2001-09-13 Ravi Pratap <ravi@ximian.com>
26248 * class.cs (TypeContainer::EmitField): Remove and move into
26249 (Field::Define): here and modify accordingly.
26250 (Field.FieldBuilder): New member.
26251 (TypeContainer::Populate): Update accordingly.
26252 (TypeContainer::FindMembers): Implement.
26254 2001-09-13 Miguel de Icaza <miguel@ximian.com>
26256 * statement.cs: (VariableInfo::VariableType): New field to be
26257 initialized with the full type once it is resolved.
26259 2001-09-12 Miguel de Icaza <miguel@ximian.com>
26261 * parameter.cs (GetParameterInfo): Use a type cache to compute
26262 things only once, and to reuse this information
26264 * expression.cs (LocalVariableReference::Emit): Implement.
26265 (OpcodeCast::Emit): fix.
26267 (ParameterReference::Resolve): Implement.
26268 (ParameterReference::Emit): Implement.
26270 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
26271 that are expressions need to stay as Expressions.
26273 * typemanager.cs (CSharpName): Returns the C# name of a type if
26276 * expression.cs (Expression::ConvertImplicit): New function that
26277 implements implicit type conversions.
26279 (Expression::ImplicitReferenceConversion): Implements implicit
26280 reference conversions.
26282 (EmptyCast): New type for transparent casts.
26284 (OpcodeCast): New type for casts of types that are performed with
26285 a sequence of bytecodes.
26287 (BoxedCast): New type used for casting value types into reference
26288 types. Emits a box opcode.
26290 (Binary::DoNumericPromotions): Implements numeric promotions of
26291 and computation of the Binary::Type.
26293 (Binary::EmitBranchable): Optimization.
26295 (Binary::Emit): Implement code emission for expressions.
26297 * typemanager.cs (TypeManager): Added two new core types: sbyte
26300 2001-09-12 Ravi Pratap <ravi@ximian.com>
26302 * class.cs (TypeContainer::FindMembers): Method which does exactly
26303 what Type.FindMembers does, only we don't have to use reflection. No
26304 implementation yet.
26306 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
26307 typecontainer objects as we need to get at them.
26308 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
26310 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
26311 typecontainer object.
26313 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
26314 of just a Report object.
26316 2001-09-11 Ravi Pratap <ravi@ximian.com>
26318 * class.cs (Event::Define): Go back to using the prefixes "add_" and
26320 (TypeContainer::Populate): Now define the delegates of the type too.
26321 (TypeContainer.Delegates): Property to access the list of delegates defined
26324 * delegates.cs (Delegate::Define): Implement partially.
26326 * modifiers.cs (TypeAttr): Handle more flags.
26328 2001-09-11 Ravi Pratap <ravi@ximian.com>
26330 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
26332 (Operator::Define): Re-write logic to get types by using the LookupType method
26333 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
26334 (Indexer::Define): Ditto.
26335 (Event::Define): Ditto.
26336 (Property::Define): Ditto.
26338 2001-09-10 Ravi Pratap <ravi@ximian.com>
26340 * class.cs (TypeContainer::Populate): Now define operators too.
26341 (TypeContainer.Operators): New property to access the list of operators
26343 (Operator.OperatorMethodBuilder): New member to hold the method builder
26344 for the operator we are defining.
26345 (Operator::Define): Implement.
26347 2001-09-10 Ravi Pratap <ravi@ximian.com>
26349 * class.cs (Event::Define): Make the prefixes of the accessor methods
26350 addOn_ and removeOn_
26352 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
26353 of the location being passed in too. Ideally, this should go later since all
26354 error reporting should be done through the Report object.
26356 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
26357 (Populate): Iterate thru the indexers we have and define them too.
26358 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
26359 for the get and set accessors.
26360 (Indexer::Define): Implement.
26362 2001-09-09 Miguel de Icaza <miguel@ximian.com>
26364 * expression.cs (Binary::Resolve): Beginning of it. I scratched
26365 my previous implementation, did not work.
26367 * typemanager.cs: Add a couple of missing types (the longs).
26369 * literal.cs: Use TypeManager.bool_type instead of getting it.
26371 * expression.cs (EventExpr): New kind of expressions.
26372 (Expressio::ExprClassFromMemberInfo): finish
26374 2001-09-08 Miguel de Icaza <miguel@ximian.com>
26376 * assign.cs: Emit stores to static fields differently.
26378 2001-09-08 Ravi Pratap <ravi@ximian.com>
26380 * Merge in changes and adjust code to tackle conflicts. Backed out my
26381 code in Assign::Resolve ;-)
26383 2001-09-08 Ravi Pratap <ravi@ximian.com>
26385 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
26386 instead Report.Error and also pass in the location.
26387 (CSharpParser::Lexer): New readonly property to return the reference
26388 to the Tokenizer object.
26389 (declare_local_variables): Use Report.Error with location instead of plain
26393 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
26394 (Operator.CheckBinaryOperator): Ditto.
26396 * cs-parser.jay (operator_declarator): Update accordingly.
26398 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
26399 (CheckBinaryOperator): Same here.
26401 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
26402 on the name without any prefixes of namespace names etc. This is because we
26403 already might have something already fully qualified like
26404 'System.Console.WriteLine'
26406 * assign.cs (Resolve): Begin implementation. Stuck ;-)
26408 2001-09-07 Ravi Pratap <ravi@ximian.com>
26410 * cs-tokenizer.cs (location): Return a string which also contains
26413 * expression.cs (ElementAccess): New class for expressions of the
26414 type 'element access.'
26415 (BaseAccess): New class for expressions of the type 'base access.'
26416 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
26419 * cs-parser.jay (element_access): Implement action.
26420 (base_access): Implement actions.
26421 (checked_expression, unchecked_expression): Implement.
26423 * cs-parser.jay (local_variable_type): Correct and implement.
26424 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
26426 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
26428 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
26429 name and the specifiers.
26431 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
26433 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
26434 making them all public ;-)
26436 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
26439 2001-09-07 Miguel de Icaza <miguel@ximian.com>
26441 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
26443 (FieldExpr, PropertyExprs): New resolved expressions.
26444 (SimpleName::MemberStaticCheck): Perform static checks for access
26445 to non-static fields on static methods. Maybe this should be
26446 generalized for MemberAccesses.
26447 (SimpleName::ResolveSimpleName): More work on simple name
26450 * cs-parser.jay (primary_expression/qualified_identifier): track
26451 the parameter index.
26453 * codegen.cs (CodeGen::Save): Catch save exception, report error.
26454 (EmitContext::EmitBoolExpression): Chain to expression generation
26455 instead of temporary hack.
26456 (::EmitStatementExpression): Put generic expression code generation.
26458 * assign.cs (Assign::Emit): Implement variable assignments to
26459 local variables, parameters and fields.
26461 2001-09-06 Miguel de Icaza <miguel@ximian.com>
26463 * statement.cs (Block::GetVariableInfo): New method, returns the
26464 VariableInfo for a variable name in a block.
26465 (Block::GetVariableType): Implement in terms of GetVariableInfo
26467 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
26468 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
26470 2001-09-06 Ravi Pratap <ravi@ximian.com>
26472 * cs-parser.jay (operator_declaration): Continue on my quest : update
26473 to take attributes argument.
26474 (event_declaration): Ditto.
26475 (enum_declaration): Ditto.
26476 (indexer_declaration): Ditto.
26478 * class.cs (Operator::Operator): Update constructor accordingly.
26479 (Event::Event): Ditto.
26481 * delegate.cs (Delegate::Delegate): Same here.
26483 * enum.cs (Enum::Enum): Same here.
26485 2001-09-05 Ravi Pratap <ravi@ximian.com>
26487 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
26489 * ../tests/cs0658.cs : New file to demonstrate error 0658.
26491 * attribute.cs (Attributes): New class to encapsulate all attributes which were
26492 being passed around as an arraylist.
26493 (Attributes::AddAttribute): Method to add attribute sections.
26495 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
26496 (struct_declaration): Update accordingly.
26497 (constant_declaration): Update.
26498 (field_declaration): Update.
26499 (method_header): Update.
26500 (fixed_parameter): Update.
26501 (parameter_array): Ditto.
26502 (property_declaration): Ditto.
26503 (destructor_declaration): Ditto.
26505 * class.cs (Struct::Struct): Update constructors accordingly.
26506 (Class::Class): Ditto.
26507 (Field::Field): Ditto.
26508 (Method::Method): Ditto.
26509 (Property::Property): Ditto.
26510 (TypeContainer::OptAttribute): update property's return type.
26512 * interface.cs (Interface.opt_attributes): New member.
26513 (Interface::Interface): Update to take the extra Attributes argument.
26515 * parameter.cs (Parameter::Parameter): Ditto.
26517 * constant.cs (Constant::Constant): Ditto.
26519 * interface.cs (InterfaceMemberBase): New OptAttributes field.
26520 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
26521 the attributes as a parameter.
26522 (InterfaceProperty): Update constructor call.
26523 (InterfaceEvent): Ditto.
26524 (InterfaceMethod): Ditto.
26525 (InterfaceIndexer): Ditto.
26527 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
26528 pass the attributes too.
26529 (interface_event_declaration): Ditto.
26530 (interface_property_declaration): Ditto.
26531 (interface_method_declaration): Ditto.
26532 (interface_declaration): Ditto.
26534 2001-09-05 Miguel de Icaza <miguel@ximian.com>
26536 * class.cs (Method::Define): Track the "static Main" definition to
26537 create an entry point.
26539 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
26540 EntryPoint if we find it.
26542 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
26543 (EmitContext::ig): Make this variable public.
26545 * driver.cs: Make the default output file be the first file name
26546 with the .exe extension.
26548 Detect empty compilations
26550 Handle various kinds of output targets. Handle --target and
26551 rename -t to --dumper.
26553 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
26554 methods inherited from Expression return now an Expression. This
26555 will is used during the tree rewriting as we resolve them during
26558 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
26559 the spec. Missing entirely is the information about
26560 accessability of elements of it.
26562 (Expression::ExprClassFromMemberInfo): New constructor for
26563 Expressions that creates a fully initialized Expression based on
26564 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
26567 (Invocation::Resolve): Begin implementing resolution of invocations.
26569 * literal.cs (StringLiteral): Implement Emit.
26571 2001-09-05 Ravi Pratap <ravi@ximian.com>
26573 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
26576 2001-09-04 Ravi Pratap <ravi@ximian.com>
26578 * cs-parser.jay (attribute_arguments): Implement actions.
26579 (attribute): Fix bug in production. Implement action.
26580 (attribute_list): Implement.
26581 (attribute_target): Implement.
26582 (attribute_target_specifier, opt_target_specifier): Implement
26583 (CheckAttributeTarget): New method to check if the attribute target
26585 (attribute_section): Implement.
26586 (opt_attributes): Implement.
26588 * attribute.cs : New file to handle attributes.
26589 (Attribute): Class to hold attribute info.
26591 * cs-parser.jay (opt_attribute_target_specifier): Remove production
26592 (attribute_section): Modify production to use 2 different rules to
26593 achieve the same thing. 1 s/r conflict down !
26594 Clean out commented, useless, non-reducing dimension_separator rules.
26596 * class.cs (TypeContainer.attributes): New member to hold list
26597 of attributes for a type.
26598 (Struct::Struct): Modify to take one more argument, the attribute list.
26599 (Class::Class): Ditto.
26600 (Field::Field): Ditto.
26601 (Method::Method): Ditto.
26602 (Property::Property): Ditto.
26604 * cs-parser.jay (struct_declaration): Update constructor call to
26605 pass in the attributes too.
26606 (class_declaration): Ditto.
26607 (constant_declaration): Ditto.
26608 (field_declaration): Ditto.
26609 (method_header): Ditto.
26610 (fixed_parameter): Ditto.
26611 (parameter_array): Ditto.
26612 (property_declaration): Ditto.
26614 * constant.cs (Constant::Constant): Update constructor similarly.
26615 Use System.Collections.
26617 * parameter.cs (Parameter::Parameter): Update as above.
26619 2001-09-02 Ravi Pratap <ravi@ximian.com>
26621 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
26622 (TypeContainer.delegates): New member to hold list of delegates.
26624 * cs-parser.jay (delegate_declaration): Implement the action correctly
26625 this time as I seem to be on crack ;-)
26627 2001-09-02 Miguel de Icaza <miguel@ximian.com>
26629 * rootcontext.cs (RootContext::IsNamespace): new function, used to
26630 tell whether an identifier represents a namespace.
26632 * expression.cs (NamespaceExpr): A namespace expression, used only
26633 temporarly during expression resolution.
26634 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
26635 utility functions to resolve names on expressions.
26637 2001-09-01 Miguel de Icaza <miguel@ximian.com>
26639 * codegen.cs: Add hook for StatementExpressions.
26641 * class.cs: Fix inverted test for static flag in methods.
26643 2001-09-02 Ravi Pratap <ravi@ximian.com>
26645 * class.cs (Operator::CheckUnaryOperator): Correct error number used
26646 to make it coincide with MS' number.
26647 (Operator::CheckBinaryOperator): Ditto.
26649 * ../errors/errors.txt : Remove error numbers added earlier.
26651 * ../errors/cs1019.cs : Test case for error # 1019
26653 * ../errros/cs1020.cs : Test case for error # 1020
26655 * cs-parser.jay : Clean out commented cruft.
26656 (dimension_separators, dimension_separator): Comment out. Ostensibly not
26657 used anywhere - non-reducing rule.
26658 (namespace_declarations): Non-reducing rule - comment out.
26660 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
26661 with TypeContainer::AddEnum.
26663 * delegate.cs : New file for delegate handling classes.
26664 (Delegate): Class for declaring delegates.
26666 * makefile : Update.
26668 * cs-parser.jay (delegate_declaration): Implement.
26670 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
26672 * class.cs (Event::Define): Implement.
26673 (Event.EventBuilder): New member.
26675 * class.cs (TypeContainer::Populate): Update to define all enums and events
26677 (Events): New property for the events arraylist we hold. Shouldn't we move to using
26678 readonly fields for all these cases ?
26680 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
26682 * class.cs (Property): Revamp to use the convention of making fields readonly.
26683 Accordingly modify code elsewhere.
26685 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
26686 the Define method of the Property class.
26688 * class.cs : Clean up applied patch and update references to variables etc. Fix
26690 (TypeContainer::Populate): Update to define all the properties we have. Also
26691 define all enumerations.
26693 * enum.cs (Define): Implement.
26695 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
26697 * cs-parser.jay (overloadable_operator): The semantic value is an
26698 enum of the Operator class.
26699 (operator_declarator): Implement actions.
26700 (operator_declaration): Implement.
26702 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
26703 validity of definitions.
26704 (Operator::CheckBinaryOperator): Static method to check for binary operators
26705 (TypeContainer::AddOperator): New method to add an operator to a type.
26707 * cs-parser.jay (indexer_declaration): Added line to actually call the
26708 AddIndexer method so it gets added ;-)
26710 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
26711 already taken care of by the MS compiler ?
26713 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
26715 * class.cs (Operator): New class for operator declarations.
26716 (Operator::OpType): Enum for the various operators.
26718 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
26720 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
26721 ostensibly handle this in semantic analysis.
26723 * cs-parser.jay (general_catch_clause): Comment out
26724 (specific_catch_clauses, specific_catch_clause): Ditto.
26725 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
26726 (catch_args, opt_catch_args): New productions.
26727 (catch_clause): Rewrite to use the new productions above
26728 (catch_clauses): Modify accordingly.
26729 (opt_catch_clauses): New production to use in try_statement
26730 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
26731 and re-write the code in the actions to extract the specific and
26732 general catch clauses by being a little smart ;-)
26734 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
26735 Hooray, try and catch statements parse fine !
26737 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
26739 * statement.cs (Block::GetVariableType): Fix logic to extract the type
26740 string from the hashtable of variables.
26742 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
26743 I end up making that mistake ;-)
26744 (catch_clauses): Fixed gross error which made Key and Value of the
26745 DictionaryEntry the same : $1 !!
26747 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
26749 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
26751 * cs-parser.jay (event_declaration): Correct to remove the semicolon
26752 when the add and remove accessors are specified.
26754 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
26756 * cs-parser.jay (IndexerDeclaration): New helper class to hold
26757 information about indexer_declarator.
26758 (indexer_declarator): Implement actions.
26759 (parsing_indexer): New local boolean used to keep track of whether
26760 we are parsing indexers or properties. This is necessary because
26761 implicit_parameters come into picture even for the get accessor in the
26762 case of an indexer.
26763 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
26765 * class.cs (Indexer): New class for indexer declarations.
26766 (TypeContainer::AddIndexer): New method to add an indexer to a type.
26767 (TypeContainer::indexers): New member to hold list of indexers for the
26770 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
26772 * cs-parser.jay (add_accessor_declaration): Implement action.
26773 (remove_accessor_declaration): Implement action.
26774 (event_accessors_declaration): Implement
26775 (variable_declarators): swap statements for first rule - trivial.
26777 * class.cs (Event): New class to hold information about event
26779 (TypeContainer::AddEvent): New method to add an event to a type
26780 (TypeContainer::events): New member to hold list of events.
26782 * cs-parser.jay (event_declaration): Implement actions.
26784 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
26786 * cs-parser.jay (dim_separators): Implement. Make it a string
26787 concatenating all the commas together, just as they appear.
26788 (opt_dim_separators): Modify accordingly
26789 (rank_specifiers): Update accordingly. Basically do the same
26790 thing - instead, collect the brackets here.
26791 (opt_rank_sepcifiers): Modify accordingly.
26792 (array_type): Modify to actually return the complete type string
26793 instead of ignoring the rank_specifiers.
26794 (expression_list): Implement to collect the expressions
26795 (variable_initializer): Implement. We make it a list of expressions
26796 essentially so that we can handle the array_initializer case neatly too.
26797 (variable_initializer_list): Implement.
26798 (array_initializer): Make it a list of variable_initializers
26799 (opt_array_initializer): Modify accordingly.
26801 * expression.cs (New::NType): Add enumeration to help us
26802 keep track of whether we have an object/delegate creation
26803 or an array creation.
26804 (New:NewType, New::Rank, New::Indices, New::Initializers): New
26805 members to hold data about array creation.
26806 (New:New): Modify to update NewType
26807 (New:New): New Overloaded contructor for the array creation
26810 * cs-parser.jay (array_creation_expression): Implement to call
26811 the overloaded New constructor.
26813 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
26815 * class.cs (TypeContainer::Constructors): Return member
26816 constructors instead of returning null.
26818 2001-08-26 Miguel de Icaza <miguel@ximian.com>
26820 * typemanager.cs (InitCoreTypes): Initialize the various core
26821 types after we have populated the type manager with the user
26822 defined types (this distinction will be important later while
26823 compiling corlib.dll)
26825 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
26826 on Expression Classification. Now all expressions have a method
26827 `Resolve' and a method `Emit'.
26829 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
26830 generation from working. Also add some temporary debugging
26833 2001-08-24 Miguel de Icaza <miguel@ximian.com>
26835 * codegen.cs: Lots of code generation pieces. This is only the
26836 beginning, will continue tomorrow with more touches of polish. We
26837 handle the fundamentals of if, while, do, for, return. Others are
26838 trickier and I need to start working on invocations soon.
26840 * gen-treedump.cs: Bug fix, use s.Increment here instead of
26843 * codegen.cs (EmitContext): New struct, used during code
26844 emission to keep a context. Most of the code generation will be
26847 * cs-parser.jay: Add embedded blocks to the list of statements of
26848 this block. So code generation proceeds in a top down fashion.
26850 2001-08-23 Miguel de Icaza <miguel@ximian.com>
26852 * statement.cs: Add support for multiple child blocks.
26854 2001-08-22 Miguel de Icaza <miguel@ximian.com>
26856 * codegen.cs (EmitCode): New function, will emit the code for a
26857 Block of code given a TypeContainer and its ILGenerator.
26859 * statement.cs (Block): Standard public readonly optimization.
26860 (Block::Block constructors): Link children.
26861 (Block::Child): Child Linker.
26862 (Block::EmitVariables): Emits IL variable declarations.
26864 * class.cs: Drop support for MethodGroups here, delay until
26866 (Method::): Applied the same simplification that I did before, and
26867 move from Properties to public readonly fields.
26868 (Method::ParameterTypes): Returns the parameter types for the
26869 function, and implements a cache that will be useful later when I
26870 do error checking and the semantic analysis on the methods is
26872 (Constructor::GetCallingConvention): Renamed from CallingConvetion
26873 and made a method, optional argument tells whether this is a class
26874 or a structure to apply the `has-this' bit.
26875 (Method::GetCallingConvention): Implement, returns the calling
26877 (Method::Define): Defines the type, a second pass is performed
26878 later to populate the methods.
26880 (Constructor::ParameterTypes): implement a cache similar to the
26881 one on Method::ParameterTypes, useful later when we do semantic
26884 (TypeContainer::EmitMethod): New method. Emits methods.
26886 * expression.cs: Removed MethodGroup class from here.
26888 * parameter.cs (Parameters::GetCallingConvention): new method.
26890 2001-08-21 Miguel de Icaza <miguel@ximian.com>
26892 * class.cs (TypeContainer::Populate): Drop RootContext from the
26895 (Constructor::CallingConvention): Returns the calling convention.
26896 (Constructor::ParameterTypes): Returns the constructor parameter
26899 (TypeContainer::AddConstructor): Keep track of default constructor
26900 and the default static constructor.
26902 (Constructor::) Another class that starts using `public readonly'
26903 instead of properties.
26905 (Constructor::IsDefault): Whether this is a default constructor.
26907 (Field::) use readonly public fields instead of properties also.
26909 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
26910 track of static constructors; If none is used, turn on
26911 BeforeFieldInit in the TypeAttributes.
26913 * cs-parser.jay (opt_argument_list): now the return can be null
26914 for the cases where there are no arguments.
26916 (constructor_declarator): If there is no implicit `base' or
26917 `this', then invoke the default parent constructor.
26919 * modifiers.cs (MethodAttr): New static function maps a set of
26920 modifiers flags into a MethodAttributes enum
26921 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
26922 MethodAttr, TypeAttr to represent the various mappings where the
26923 modifiers are used.
26924 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
26926 2001-08-19 Miguel de Icaza <miguel@ximian.com>
26928 * parameter.cs (GetParameterInfo): Fix bug where there would be no
26931 * interface.cs (PopulateIndexer): Implemented the code generator
26932 for interface indexers.
26934 2001-08-17 Miguel de Icaza <miguel@ximian.com>
26936 * interface.cs (InterfaceMemberBase): Now we track the new status
26939 (PopulateProperty): Implement property population. Woohoo! Got
26940 Methods and Properties going today.
26942 Removed all the properties for interfaces, and replaced them with
26943 `public readonly' fields.
26945 2001-08-16 Miguel de Icaza <miguel@ximian.com>
26947 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
26948 initialize their hashtables/arraylists only when they are needed
26949 instead of doing this always.
26951 * parameter.cs: Handle refs and out parameters.
26953 * cs-parser.jay: Use an ArrayList to construct the arguments
26954 instead of the ParameterCollection, and then cast that to a
26957 * parameter.cs: Drop the use of ParameterCollection and use
26958 instead arrays of Parameters.
26960 (GetParameterInfo): Use the Type, not the Name when resolving
26963 2001-08-13 Miguel de Icaza <miguel@ximian.com>
26965 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
26966 and instead use public readonly fields.
26968 * class.cs: Put back walking code for type containers.
26970 2001-08-11 Miguel de Icaza <miguel@ximian.com>
26972 * class.cs (MakeConstant): Code to define constants.
26974 * rootcontext.cs (LookupType): New function. Used to locate types
26977 2001-08-08 Miguel de Icaza <miguel@ximian.com>
26979 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
26980 this System.Reflection code is. Kudos to Microsoft
26982 * typemanager.cs: Implement a type cache and avoid loading all
26983 types at boot time. Wrap in LookupType the internals. This made
26984 the compiler so much faster. Wow. I rule!
26986 * driver.cs: Make sure we always load mscorlib first (for
26987 debugging purposes, nothing really important).
26989 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
26990 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
26992 * rootcontext.cs: Lookup types on their namespace; Lookup types
26993 on namespaces that have been imported using the `using' keyword.
26995 * class.cs (TypeContainer::TypeAttr): Virtualize.
26996 (Class::TypeAttr): Return attributes suitable for this bad boy.
26997 (Struct::TypeAttr): ditto.
26998 Handle nested classes.
26999 (TypeContainer::) Remove all the type visiting code, it is now
27000 replaced with the rootcontext.cs code
27002 * rootcontext.cs (GetClassBases): Added support for structs.
27004 2001-08-06 Miguel de Icaza <miguel@ximian.com>
27006 * interface.cs, statement.cs, class.cs, parameter.cs,
27007 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
27008 Drop use of TypeRefs, and use strings instead.
27010 2001-08-04 Miguel de Icaza <miguel@ximian.com>
27014 * class.cs (Struct::Struct): set the SEALED flags after
27015 checking the modifiers.
27016 (TypeContainer::TypeAttr): new property, returns the
27017 TypeAttributes for a class.
27019 * cs-parser.jay (type_list): Oops, list production was creating a
27020 new list of base types.
27022 * rootcontext.cs (StdLib): New property.
27023 (GetInterfaceTypeByName): returns an interface by type name, and
27024 encapsulates error handling here.
27025 (GetInterfaces): simplified.
27026 (ResolveTree): Encapsulated all the tree resolution here.
27027 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
27030 * driver.cs: Add support for --nostdlib, to avoid loading the
27031 default assemblies.
27032 (Main): Do not put tree resolution here.
27034 * rootcontext.cs: Beginning of the class resolution.
27036 2001-08-03 Miguel de Icaza <miguel@ximian.com>
27038 * rootcontext.cs: Provide better error reporting.
27040 * cs-parser.jay (interface_base): set our $$ to be interfaces.
27042 * rootcontext.cs (CreateInterface): Handle the case where there
27043 are no parent interfaces.
27045 (CloseTypes): Routine to flush types at the end.
27046 (CreateInterface): Track types.
27047 (GetInterfaces): Returns an array of Types from the list of
27048 defined interfaces.
27050 * typemanager.c (AddUserType): Mechanism to track user types (puts
27051 the type on the global type hash, and allows us to close it at the
27054 2001-08-02 Miguel de Icaza <miguel@ximian.com>
27056 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
27057 RecordInterface instead.
27059 * cs-parser.jay: Updated to reflect changes above.
27061 * decl.cs (Definition): Keep track of the TypeBuilder type that
27062 represents this type here. Not sure we will use it in the long
27063 run, but wont hurt for now.
27065 * driver.cs: Smaller changes to accomodate the new code.
27067 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
27070 * rootcontext.cs (CreateInterface): New method, used to create
27071 the System.TypeBuilder type for interfaces.
27072 (ResolveInterfaces): new entry point to resolve the interface
27074 (CodeGen): Property, used to keep track of the code generator.
27076 2001-07-26 Miguel de Icaza <miguel@ximian.com>
27078 * cs-parser.jay: Add a second production for delegate_declaration
27081 (enum_body): Put an opt_comma here instead of putting it on
27082 enum_body or enum_member_declarations so we can handle trailing
27083 commas on enumeration members. Gets rid of a shift/reduce.
27085 (type_list): Need a COMMA in the middle.
27087 (indexer_declaration): Tell tokenizer to recognize get/set
27089 * Remove old targets.
27091 * Re-add the parser target.
27093 2001-07-13 Simon Cozens <simon@simon-cozens.org>
27095 * cs-parser.jay: Add precendence rules for a number of operators
27096 ot reduce the number of shift/reduce conflicts in the grammar.
27098 2001-07-17 Miguel de Icaza <miguel@ximian.com>
27100 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
27103 Get rid of old crufty code.
27105 * rootcontext.cs: Use this to keep track of the parsed
27106 representation and the defined types available to the program.
27108 * gen-treedump.cs: adjust for new convention.
27110 * type.cs: Split out the type manager, and the assembly builder
27113 * typemanager.cs: the type manager will live here now.
27115 * cil-codegen.cs: And the code generator here.
27117 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
27119 * makefile: Fixed up for easy making.
27121 2001-07-13 Simon Cozens <simon@simon-cozens.org>
27123 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
27126 (unary_expression): Expand pre_increment_expression and
27127 post_decrement_expression to reduce a shift/reduce.
27129 2001-07-11 Simon Cozens
27131 * cs-tokenizer.cs: Hex numbers should begin with a 0.
27133 Improve allow_keyword_as_indent name.
27135 2001-06-19 Miguel de Icaza <miguel@ximian.com>
27137 * Adjustments for Beta2.
27139 2001-06-13 Miguel de Icaza <miguel@ximian.com>
27141 * decl.cs: Added `Define' abstract method.
27142 (InTransit): new property, used to catch recursive definitions.
27144 * interface.cs: Implement `Define'.
27146 * modifiers.cs: Map Modifiers.constants to
27147 System.Reflection.TypeAttribute flags.
27149 * class.cs: Keep track of types and user-defined types.
27150 (BuilderInit): New method for creating an assembly
27151 (ResolveType): New function to launch the resolution process, only
27152 used by interfaces for now.
27154 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
27155 that are inserted into the name space.
27157 2001-06-08 Miguel de Icaza <miguel@ximian.com>
27159 * ARGH. I have screwed up my tree so many times due to the use of
27160 rsync rather than using CVS. Going to fix this at once.
27162 * driver.cs: Objetify driver. Load assemblies, use assemblies to
27165 2001-06-07 Miguel de Icaza <miguel@ximian.com>
27167 * Experiment successful: Use System.Type rather that our own
27170 2001-05-25 Miguel de Icaza <miguel@ximian.com>
27172 * cs-parser.jay: Removed nsAliases from here.
27174 Use new namespaces, handle `using XXX;'
27176 * namespace.cs: Reimplemented namespace handling, use a recursive
27177 definition of the class. Now we can keep track of using clauses
27178 and catch invalid using clauses.
27180 2001-05-24 Miguel de Icaza <miguel@ximian.com>
27182 * gen-treedump.cs: Adapted for all the renaming.
27184 * expression.cs (Expression): this class now has a Type property
27185 which returns an expression Type.
27187 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
27188 `Type', as this has a different meaning now in the base
27190 2001-05-22 Miguel de Icaza <miguel@ximian.com>
27192 * interface.cs, class.cs: Removed from all the sources the
27193 references to signature computation, as we can not do method
27194 signature computation during the parsing time, as we are not
27195 trying to solve at that point distinguishing:
27199 void a (NS.Blah x) {}
27202 Which depending on the context might be valid or not, as we do not
27203 know if Blah is the same thing as NS.Blah at that point.
27205 * Redid everything so the code uses TypeRefs now instead of
27206 Types. TypeRefs are just temporary type placeholders, that need
27207 to be resolved. They initially have a pointer to a string and the
27208 current scope in which they are used. This is used later by the
27209 compiler to resolve the reference to an actual Type.
27211 * DeclSpace is no longer a CIR.Type, and neither are
27212 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
27213 are all DeclSpaces, but no Types.
27215 * type.cs (TypeRefManager): This implements the TypeRef manager,
27216 which keeps track of all the types that need to be resolved after
27217 the parsing has finished.
27219 2001-05-13 Miguel de Icaza <miguel@ximian.com>
27221 * ARGH. We are going to have to store `foreach' as a class rather
27222 than resolving it, as we need to verify error 1579 after name
27223 resolution. *OR* we could keep a flag that says `This request to
27224 IEnumerator comes from a foreach statement' which we can then use
27225 to generate the error.
27227 2001-05-10 Miguel de Icaza <miguel@ximian.com>
27229 * class.cs (TypeContainer.AddMethod): we now add methods to the
27230 MethodGroup instead of the method hashtable.
27232 * expression.cs: Add MethodGroup abstraction, which gets us one
27233 step closer to the specification in the way we handle method
27236 * cs-parser.jay (primary_expression): qualified_identifier now
27237 tried to match up an identifier to a local variable reference or
27238 to a parameter reference.
27240 current_local_parameters is now a parser global variable that
27241 points to the current parameters for the block, used during name
27244 (property_declaration): Now creates an implicit `value' argument to
27247 2001-05-09 Miguel de Icaza <miguel@ximian.com>
27249 * parameter.cs: Do not use `param' arguments as part of the
27250 signature, per the spec.
27252 2001-05-08 Miguel de Icaza <miguel@ximian.com>
27254 * decl.cs: Base class for classes, structs and interfaces. This
27255 is the "Declaration Space"
27257 * cs-parser.jay: Use CheckDef for checking declaration errors
27258 instead of having one on each function.
27260 * class.cs: Factor out some code for handling error handling in
27261 accordance to the "Declarations" section in the "Basic Concepts"
27262 chapter in the ECMA C# spec.
27264 * interface.cs: Make all interface member classes derive from
27265 InterfaceMemberBase.
27267 2001-05-07 Miguel de Icaza <miguel@ximian.com>
27269 * Many things: all interfaces are parsed and generated in
27270 gen-treedump. Support for member variables, constructors,
27271 destructors, properties, constants is there.
27273 Beginning of the IL backend, but very little done, just there for
27276 2001-04-29 Miguel de Icaza <miguel@ximian.com>
27278 * cs-parser.jay: Fix labeled statement.
27280 * cs-tokenizer.cs (escape): Escape " and ' always.
27281 ref_line, ref_name: keep track of the line/filename as instructed
27282 by #line by the compiler.
27285 2001-04-27 Miguel de Icaza <miguel@ximian.com>
27287 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
27288 to match the values in System.CodeDOM.
27290 Divid renamed to Divide.
27292 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
27294 (Statements.set): remove.
27296 * System.CodeDOM/CodeCatchClause.cs: always have a valid
27299 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
27300 falseStatements always have valid values.
27302 * cs-parser.jay: Use System.CodeDOM now.