1 2004-11-24 Martin Baulig <martin@ximian.com>
3 * ecore.cs (Expression.LoadFromPtr): Use `ldobj' for generic parameters.
5 2004-11-20 Martin Baulig <martin@ximian.com>
7 * expression.cs (Invocation.InferType): Correctly infer generic
8 instances; see gen-103.cs.
9 (Invocation.InferTypeArguments): If a generic method doesn't have
10 any unbound type parameters, we don't need to infer anything.
12 2004-11-19 Raja R Harinath <rharinath@novell.com>
14 * Makefile (gmcs.exe): Update to new location of bootstrap mcs.exe.
16 2004-11-17 Raja R Harinath <rharinath@novell.com>
18 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
19 (TypeHandle.GetMemberCache): New.
20 (TypeHandle.TypeHandle): Update.
21 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
22 (TypeManager.LookupParentInterfacesCache):
23 Rename from LookupInterfaceCache. Optimize slightly.
24 (TypeManager.MemberLookup_FindMembers): Update.
25 * decl.cs (MemberCache.MemberCache): Set Container to null in the
27 (AddCacheContents): Rename from AddHashtable.
28 * class.cs (TypeContainer.parent_container): Remove.
29 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
30 (TypeContainer.DoDefineMembers): Don't initialize it.
31 Update to name changes.
33 2004-11-17 Miguel de Icaza <miguel@ximian.com>
35 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
36 that factors the code to check access modifiers on override.
38 (PropertyBase): Use the code here.
40 Patch from Lluis S'anchez, fixes bug #69361.
42 2004-11-15 Miguel de Icaza <miguel@ximian.com>
44 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
45 routine that is used to report the use of a captured variable
46 whose address has been taken.
48 There are two checks: one when variables are being captured and
49 the other check is when the address of a variable is taken.
51 (because an anonymous methods might be resolved before *or* after
52 the address has been taken) and
54 * expression.cs (Conditional.DoResolve): Remove the special
55 casing that Martin added to trueExpr and falseExpr being both
56 NullLiteral. We get the right behavior now just by introducing
57 the null_type into the compiler.
59 * convert.cs (ExplicitConversion): Change the code to use
60 null_type instead of testing `expr is NullLiteral'.
61 (ImplicitConversionStandard): use null_type too.
62 (ImplicitReferenceConversionExists): use null_type too.
63 (ImplicitReferenceConversion): use null_type too.
65 * literal.cs: The type of `NullLiteral' is now null_type instead
67 (Resolve): Set the type here.
69 * typemanager.cs: Introduce null_type.
71 2004-11-18 Martin Baulig <martin@ximian.com>
74 (RootContext.LookupType): Return a `Type', not a `TypeExpr'.
76 2004-11-18 Martin Baulig <martin@ximian.com>
78 * ecore.cs (TypeExpr.DoResolveAsTypeStep): Make this protected.
80 2004-11-18 Martin Baulig <martin@ximian.com>
82 * generic.cs (Constraints.Resolve): Take an `EmitContext' instead
83 of a `DeclSpace'. If one of our constraints is a `ConstructedType',
84 call ResolveConstructedType() on it to resolve it without checking
86 (Constraints.ResolveTypes): Check them here.
87 (ConstructedType.DoResolveAsTypeStep): Fully resolve ourselves,
88 but don't check constraints.
89 (ConstructedType.ResolveAsTypeTerminal): Override this and also
90 check constraints here.
91 (ConstructedType.ResolveConstructedType): New public method. This
92 is called from DoResolveAsTypeStep() and Constraints.Resolve() to
93 resolve ourselves without checking constraints.
95 * ecore.cs (Expression.ResolveAsTypeTerminal): Make this virtual.
97 2004-11-18 Martin Baulig <martin@ximian.com>
100 (DeclSpace.CurrentType): Changed type from `TypeExpr' to `Type'.
102 * delegate.cs (Delegate.DefineType): Always create the EmitContext.
104 2004-11-18 Martin Baulig <martin@ximian.com>
106 * ecore.cs (TypeExpr.ResolveType): Removed.
107 (Expression.ResolveAsTypeTerminal): We always return a fully
108 resolved `TypeExpr', so we can just access its `Type'.
110 * class.cs (TypeContainer.DefineType): Resolve `CurrentType' here.
112 2004-11-17 Martin Baulig <martin@ximian.com>
114 * ecore.cs (IAlias.Type): Replaced with ResolveAsType() to make
115 sure we don't return any unresolved TypeExpr's.
116 (TypeAliasExpression): The .ctor now takes an `IAlias' instead of
118 (Expression.ResolveAsTypeTerminal): Make sure `te.Type != null'.
120 * expression.cs (MemberAccess.ResolveAsTypeStep): Don't return any
121 unresolved `ConstructedType's.
123 2004-11-17 Martin Baulig <martin@ximian.com>
125 * ecore.cs (TypeExpr.ResolveType): Don't make this virtual.
127 2004-11-17 Martin Baulig <martin@ximian.com>
130 (Expression.ResolveAsTypeTerminal): Removed the `bool silent' argument.
132 * decl.cs (DeclSpace.ResolveType): Removed.
133 (DeclSpace.ResolveTypeExpr): Removed the `bool silent' argument.
135 2004-11-17 Martin Baulig <martin@ximian.com>
137 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
138 direction, like FindMembers() does. Fixes #69546, testcase is in
141 2004-11-16 Martin Baulig <martin@ximian.com>
143 This is based on a patch from Marek Safar, see bug #69082.
144 Fixes bugs #63705 and #67130.
146 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
147 method; create a MemberCache for an interface type and cache the
150 * decl.cs (IMemberContainer.ParentContainer): Removed.
151 (IMemberContainer.ParentCache): New property.
152 (MemberCache.SetupCacheForInterface): Removed.
153 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
154 to create a cache for an interface's "parent".
156 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
159 2004-11-14 Ben Maurer <bmaurer@ximian.com>
161 * statement.cs: Avoid adding bools to a hashtable.
163 2004-11-15 Martin Baulig <martin@ximian.com>
165 * decl.cs (MemberName.GetPartialName): Removed, use GetTypeName() instead.
167 2004-11-11 Martin Baulig <martin@ximian.com>
169 * typemanager.cs (TypeManager.GetMethodName): New method.
171 * class.cs (MethodData.Define): Include the generic arity in the
172 name of an explicit interface; also add it to the method name.
174 * pending.cs (PendingImplementation.InterfaceMethod): The method
175 name now includes the generic arity.
177 2004-11-07 Miguel de Icaza <miguel@ximian.com>
179 * expression.cs (Invocation.OverloadResolve): Flag error if we are
180 calling an unsafe method from a safe location.
182 2004-11-06 Marek Safar <marek.safar@seznam.cz>
185 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
187 2004-11-06 Miguel de Icaza <miguel@ximian.com>
189 * namespace.cs (VerifyUsing): use GetPartialName instead of
192 2004-11-05 Miguel de Icaza <miguel@ximian.com>
194 * statement.cs (Return.Resolve): Fix regression in typo: if
195 `in_exc', we have to request a NeedReturnLabel, this was a typo
196 introduced in the anonymous method check-in. Fixes #69131.
198 * Indexers were using the ShortName when defining themselves,
199 causing a regression in the compiler bootstrap when applying the
200 patch from 2004-11-02 (first part), now they use their full name
203 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
205 * driver.cs: Strip the path from the names of embedded resources. Fixes
208 2004-11-04 Raja R Harinath <rharinath@novell.com>
210 Fix error message regression: cs0104-2.cs.
211 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
212 (AliasEntry.Resolve): Update.
213 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
215 (RootContext.LookupType): Update.
217 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
219 * cs-parser.jay: Add support for handling accessor modifiers
220 * class: Add support port accessor modifiers and error checking,
221 define PropertyMethod.Define as virtual (not abstract anymore)
222 * ecore.cs: Add checking for proeprties access with access modifiers
223 * iterators.cs: Modify Accessor constructor call based in the modified
225 2004-11-02 Ben Maurer <bmaurer@ximian.com>
227 * expression.cs (StringConcat): Handle being called twice,
228 as when we have a concat in a field init with more than two
231 2004-11-02 Miguel de Icaza <miguel@ximian.com>
233 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
234 special case explicit implementations, we should always produce
235 the .property or .event declaration.
237 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
238 since it will not return correct data if people use this
239 unresolved in the presence of using statements (see test-313).
241 * class.cs (MethodData.Define): If we are an explicit interface
242 implementation, set the method name to the full name of the
243 interface plus the name of the method.
245 Notice that using the method.MethodName.GetFullName() does not
246 work, as it will only contain the name as declared on the source
247 file (it can be a shorthand in the presence of using statements)
248 and not the fully qualifed type name, for example:
252 class D : ICloneable {
253 object ICloneable.Clone () {
257 Would produce a method called `ICloneable.Clone' instead of
258 `System.ICloneable.Clone'.
260 * namespace.cs (Alias.Resolve): Use GetPartialName.
262 2004-11-01 Marek Safar <marek.safar@seznam.cz>
264 * cs-parser.jay: Add error 1055 report.
266 2004-11-01 Miguel de Icaza <miguel@ximian.com>
268 * assign.cs (Assign.DoResolve): Only do the transform of
269 assignment into a New if the types are compatible, if not, fall
270 through and let the implicit code deal with the errors and with
271 the necessary conversions.
273 2004-11-01 Marek Safar <marek.safar@seznam.cz>
275 * cs-parser.jay: Add error 1031 report.
277 * cs-tokenizer.cs: Add location for error 1038.
279 2004-10-31 Marek Safar <marek.safar@seznam.cz>
281 * cs-parser.jay: Add error 1016 report.
283 2004-10-31 Marek Safar <marek.safar@seznam.cz>
285 * cs-parser.jay: Add errors 1575,1611 report.
287 2004-10-31 Marek Safar <marek.safar@seznam.cz>
289 * cs-parser.jay: Add error 1001 report.
291 2004-10-31 Marek Safar <marek.safar@seznam.cz>
294 * attribute.cs (GetMarshal): Add method argument for
295 caller identification.
297 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
298 agument for GetMarshal and RuntimeMissingSupport.
300 2004-10-31 Marek Safar <marek.safar@seznam.cz>
302 * attribute.cs (ExtractSecurityPermissionSet): Removed
303 TypeManager.code_access_permission_type.
305 * typemanager.cs: Removed TypeManager.code_access_permission_type.
307 2004-10-27 Miguel de Icaza <miguel@ximian.com>
309 * expression.cs (LocalVariableReference.DoResolveLValue): Check
310 for obsolete use of a variable here. Fixes regression on errors
311 cs0619-25 and cs0619-26.
313 2004-10-27 Marek Safar <marek.safar@seznam.cz>
315 Fix #62358, implemented security attribute encoding.
317 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
318 Tests permitted SecurityAction for assembly or other types.
319 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
320 data from SecurityPermissionAttribute to PermisionSet class.
322 * class.cs (ApplyAttributeBuilder): Added special handling
323 for System.Security.Permissions.SecurityAttribute based types.
325 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
326 special handling for System.Security.Permissions.SecurityAttribute
329 * enum.cs (ApplyAttributeBuilder): Added special handling
330 for System.Security.Permissions.SecurityAttribute based types.
332 * parameter.cs (ApplyAttributeBuilder): Added special handling
333 for System.Security.Permissions.SecurityAttribute based types.
335 * rootcontext.cs: Next 2 core types.
337 * typemanager.cs (TypeManager.security_permission_attr_type):
338 Built in type for the SecurityPermission Attribute.
339 (code_access_permission_type): Build in type.
341 2004-10-17 Miguel de Icaza <miguel@ximian.com>
343 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
344 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
345 all of this information into
346 EmitContext.EmitCapturedVariableInstance.
348 * codegen.cs (EmitCapturedVariableInstance): move here the
349 funcionality of emitting an ldarg.0 in the presence of a
350 remapping. This centralizes the instance emit code.
352 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
353 then emit a load of this: it means that we have reached the
354 topmost ScopeInfo: the one that contains the pointer to the
355 instance of the class hosting the anonymous method.
357 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
358 captures to the topmost CaptureContext.
360 2004-10-12 Miguel de Icaza <miguel@ximian.com>
362 * expression.cs (LocalVariableReference): Move the knowledge about
363 the iterators into codegen's EmitCapturedVariableInstance.
365 2004-10-11 Miguel de Icaza <miguel@ximian.com>
367 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
368 all code paths return a value from an anonymous method (it is the
369 same as the 161 error, but for anonymous methods).
371 2004-10-08 Miguel de Icaza <miguel@ximian.com>
373 The introduction of anonymous methods in the compiler changed
374 various ways of doing things in the compiler. The most
375 significant one is the hard split between the resolution phase
376 and the emission phases of the compiler.
378 For instance, routines that referenced local variables no
379 longer can safely create temporary variables during the
380 resolution phase: they must do so from the emission phase,
381 since the variable might have been "captured", hence access to
382 it can not be done with the local-variable operations from the runtime.
386 (Block.Flags): New flag `IsTopLevel' to indicate that this block
389 (ToplevelBlock): A new kind of Block, these are the blocks that
390 are created by the parser for all toplevel method bodies. These
391 include methods, accessors and anonymous methods.
393 These contain some extra information not found in regular blocks:
394 A pointer to an optional CaptureContext (for tracking captured
395 local variables and parameters). A pointer to the parent
398 (Return.Resolve): Catch missmatches when returning a value from an
399 anonymous method (error 1662).
400 Invoke NeedReturnLabel from the Resolve phase instead of the emit
403 (Break.Resolve): ditto.
405 (SwitchLabel): instead of defining the labels during the
406 resolution phase, we now turned the public ILLabel and ILLabelCode
407 labels into methods called GetILLabelCode() and GetILLabel() that
408 only define the label during the Emit phase.
410 (GotoCase): Track the SwitchLabel instead of the computed label
411 (its contained therein). Emit the code by using
412 SwitchLabel.GetILLabelCode ().
414 (LocalInfo.Flags.Captured): A new flag has been introduce to track
415 whether the Local has been captured or not.
417 (LocalInfo.IsCaptured): New property, used to tell whether the
418 local has been captured.
420 * anonymous.cs: Vastly updated to contain the anonymous method
423 The main classes here are: CaptureContext which tracks any
424 captured information for a toplevel block and ScopeInfo used to
425 track the activation frames for various local variables.
427 Each toplevel block has an optional capture context associated
428 with it. When a method contains an anonymous method both the
429 toplevel method and the anonymous method will create a capture
430 context. When variables or parameters are captured, they are
431 recorded on the CaptureContext that owns them, for example:
435 MyDelegate d = delegate {
440 Here `a' will be recorded as captured on the toplevel
441 CapturedContext, the inner captured context will not have anything
442 (it will only have data if local variables or parameters from it
443 are captured in a nested anonymous method.
445 The ScopeInfo is used to track the activation frames for local
446 variables, for example:
448 for (int i = 0; i < 10; i++)
449 for (int j = 0; j < 10; j++){
450 MyDelegate d = delegate {
455 At runtime this captures a single captured variable `i', but it
456 captures 10 different versions of the variable `j'. The variable
457 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
460 The toplevel ScopeInfo will also track information like the `this'
461 pointer if instance variables were referenced (this is necessary
462 as the anonymous method lives inside a nested class in the host
465 (AnonymousMethod): Expanded to track the Toplevel, implement
466 `AnonymousMethod.Compatible' to tell whether an anonymous method
467 can be converted to a target delegate type.
469 The routine now also produces the anonymous method content
471 (AnonymousDelegate): A helper class that derives from
472 DelegateCreation, this is used to generate the code necessary to
473 produce the delegate for the anonymous method that was created.
475 * assign.cs: API adjustments for new changes in
476 Convert.ImplicitStandardConversionExists.
478 * class.cs: Adjustments to cope with the fact that now toplevel
479 blocks are of type `ToplevelBlock'.
481 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
482 insteda of standard blocks.
484 Flag errors if params arguments are passed to anonymous methods.
486 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
487 `CurrentAnonymousMethod' which points to the current Anonymous
488 Method. The variable points to the AnonymousMethod class that
489 holds the code being compiled. It is set in the new EmitContext
490 created for the anonymous method.
492 (EmitContext.Phase): Introduce a variable and an enumeration to
493 assist in enforcing some rules about when and where we are allowed
494 to invoke certain methods (EmitContext.NeedsReturnLabel is the
495 only one that enfonces this right now).
497 (EmitContext.HaveCaptureInfo): new helper method that returns
498 whether we have a CapturedContext initialized.
500 (EmitContext.CaptureVariable): New method used to register that a
501 LocalInfo must be flagged for capturing.
503 (EmitContext.CapturedParameter): New method used to register that a
504 parameters must be flagged for capturing.
506 (EmitContext.CapturedField): New method used to register that a
507 field must be flagged for capturing.
509 (EmitContext.HaveCapturedVariables,
510 EmitContext.HaveCapturedFields): Return whether there are captured
513 (EmitContext.EmitMethodHostInstance): This is used to emit the
514 instance for the anonymous method. The instance might be null
515 (static methods), this (for anonymous methods that capture nothing
516 and happen to live side-by-side with the current method body) or a
517 more complicated expression if the method has a CaptureContext.
519 (EmitContext.EmitTopBlock): Routine that drives the emission of
520 code: it will first resolve the top block, then emit any metadata
521 and then emit the code. The split is done so that we can extract
522 any anonymous methods and flag any captured variables/parameters.
524 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
525 during this phase, the ILGenerator should not be used as labels
526 and local variables declared here might not be accessible to any
527 code that is part of an anonymous method.
529 Exceptions to this include the temporary variables that are
530 created by some statements internally for holding temporary
533 (EmitContext.EmitMeta): New routine, in charge of emitting all the
536 (EmitContext.TemporaryReturn): This method is typically called
537 from the Emit phase, and its the only place where we allow the
538 ReturnLabel to be defined other than the EmitMeta. The reason is
539 that otherwise we would have to duplicate a lot of logic in the
540 Resolve phases of various methods that today is on the Emit
543 (EmitContext.NeedReturnLabel): This no longer creates the label,
544 as the ILGenerator is not valid during the resolve phase.
546 (EmitContext.EmitThis): Extended the knowledge in this class to
547 work in anonymous methods in addition to iterators.
549 (EmitContext.EmitCapturedVariableInstance): This emits whatever
550 code is necessary on the stack to access the instance to a local
551 variable (the variable will be accessed as a field).
553 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
554 EmitContext.EmitAddressOfParameter): Routines to support
555 parameters (not completed at this point).
557 Removals: Removed RemapLocal and RemapLocalLValue. We probably
558 will also remove the parameters.
560 * convert.cs (Convert): Define a `ConstantEC' which points to a
561 null. This is just to prefity some code that uses
562 ImplicitStandardConversion code and do not have an EmitContext
565 The idea is to flag explicitly that at that point in time, it is
566 known that the conversion will not trigger the delegate checking
567 code in implicit conversions (which requires a valid
570 Everywhere: pass new EmitContext parameter since
571 ImplicitStandardConversionExists now requires it to check for
572 anonymous method conversions.
574 (Convert.ImplicitStandardConversionExists): If the type of an
575 expression is the anonymous_method_type, and the type is a
576 delegate, we invoke the AnonymousMethod.Compatible method to check
577 whether an implicit conversion is possible.
579 (Convert.ImplicitConversionStandard): Only do implicit method
580 group conversions if the language level is not ISO_1.
582 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
583 MethodInfo for the Invoke method. used by Delegate and
586 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
587 method conversions if the target type is a delegate.
589 Removed extra debugging nops.
591 (LocalVariableReference): Turn the `local_info' into a public
594 Add `prepared' field, the same hack used for FieldExprs to cope
595 with composed assignments, as Local variables do not necessarily
596 operate purely on the stack as they used to: they can be captured
599 Add `temp' for a temporary result, like fields.
601 Refactor DoResolve and DoResolveLValue into DoResolveBase.
603 It now copes with Local variables that are captured and emits the
604 proper instance variable to load it from a field in the captured
607 (ParameterReference.DoResolveBase): During the resolve phase,
608 capture parameters if we are in an anonymous method.
610 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
611 anonymous method, use the EmitContext helper routines to emit the
614 * iterators.cs: Set RemapToProxy to true/false during the
617 * parameters.cs (GetParameterByName): New helper method.
619 * typemanager.cs (anonymous_method_type) a new type that
620 represents an anonyous method. This is always an internal type,
621 used as a fencepost to test against the anonymous-methodness of an
624 2004-10-20 Marek Safar <marek.safar@seznam.cz>
626 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
628 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
630 2004-11-10 Martin Baulig <martin@ximian.com>
632 * expression.cs (Invocation.BetterFunction): If two methods have
633 equal parameter types, but only one of them is generic, the
634 non-generic one wins.
635 (New.DoResolve): Don't set `is_struct' to false if we're a generic
636 instance; just use `Type.IsValueType' to determine whether
637 something is a struct or not.
638 (MemberAccess.DoResolveAsTypeStep): Don't modify the `args' field,
639 so we can be called multiple times.
641 2004-11-10 Martin Baulig <martin@ximian.com>
643 * generic.cs (TypeParameter.DefineConstraints): New public method.
644 (TypeParameter.CheckAccessLevel): Override this and return true.
645 (ConstructedType.ResolveType): Renamed to DoResolveType(), don't
646 override ResolveType() anymore.
647 (ConstructedType.DoResolveAsTypeStep): Call DoResolveType() here.
649 2004-11-10 Martin Baulig <martin@ximian.com>
651 * rootcontext.cs (RootContext.LookupType): If we're a nested type,
652 call DeclSpace.ResolveNestedType() on it.
654 2004-11-10 Martin Baulig <martin@ximian.com>
656 * support.cs (ReflectionParameters.ParameterModifier): If `gpd' is
657 non-null, call ParameterModifier() on it.
659 2004-11-10 Martin Baulig <martin@ximian.com>
662 (Iterators): Added `current_type' and `this_type' fields.
663 (Iterators.DefineIterator): Create a new EmitContext and store it
664 in `ec'; compute `this_type'.
666 2004-11-10 Martin Baulig <martin@ximian.com>
669 (TypeManager.IsPrivateAccessible): New public method.
670 (Closure.Filter): Use IsPrivateAccessible() instead of IsEqual().
672 2004-11-10 Martin Baulig <martin@ximian.com>
674 * class.cs (TypeContainer.DefineType): Call
675 TypeBuilder.DefineGenericParameters() before resolving the type
677 (MethodData.parent_method): New protected field.
678 (MethodData..ctor): Added `MethodInfo parent_method' argument.
679 (MethodData.Define): Compute `parent_method'.
682 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
683 (MemberCore.GetClsCompliantAttributeValue): Likewise.
684 (DeclSpace.ec): New protected field; store the EmitContext here.
685 (DeclSpace.EmitContext): New public property.
686 (DeclSpace.ResolveType): Un-comment from the [Obsolte] attribute.
687 (DeclSpace.ResolveNestedType): New public method.
688 (DeclSpace.ResolveTypeExpr): Just call ResolveAsTypeTerminal() here.
689 (DeclSpace.NestedAccessible): Added `Type tb' argument.
690 (DeclSpace.FamilyAccessible): Likewise.
691 (DeclSpace.FindType): Call ResolveNestedType() for nested types.
692 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
695 * delegate.cs (Delegate.Define): Store the EmitContext in the `ec'
698 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
699 (Enum.Emit): Don't create a new EmitContext.
701 2004-10-18 Martin Baulig <martin@ximian.com>
703 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
704 `Type' directly, but call ResolveType() on it.
705 (Catch.Resolve): Likewise.
706 (Foreach.Resolve): Likewise.
708 2004-10-18 Martin Baulig <martin@ximian.com>
710 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
711 `Type' directly, but call ResolveType() on it.
712 (Probe.DoResolve): Likewise.
713 (ArrayCreation.LookupType): Likewise.
714 (TypeOf.DoResolve): Likewise.
715 (SizeOf.DoResolve): Likewise.
717 2004-10-18 Raja R Harinath <rharinath@novell.com>
719 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
722 2004-10-17 John Luke <john.luke@gmail.com>
724 * class.cs (Operator.GetSignatureForError): use CSharpName
726 * parameter.cs (Parameter.GetSignatureForError): Returns
727 correct name even if was not defined.
729 2004-10-13 Raja R Harinath <rharinath@novell.com>
732 * class.cs (TypeContainer.EmitContext): New property.
733 (DefineNestedTypes): Create an emitcontext for each part.
734 (MethodCore.DoDefineParameters): Use container's emitcontext.
735 Pass type array to InternalParameters.
736 (MemberBase.DoDefine): Use container's emitcontext.
737 (FieldMember.Define): Likewise.
738 (Event.Define): Likewise.
739 (SetMethod.GetParameterInfo): Change argument to EmitContext.
740 Pass type array to InternalParameters.
741 (SetIndexerMethod.GetParameterInfo): Likewise.
742 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
743 * delegate.cs (Define): Pass emitcontext to
744 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
745 array to InternalParameters.
746 * expression.cs (ParameterReference.DoResolveBase): Pass
747 emitcontext to GetParameterInfo.
748 (ComposedCast.DoResolveAsTypeStep): Remove check on
749 ec.ResolvingTypeTree.
750 * parameter.cs (Parameter.Resolve): Change argument to
751 EmitContext. Use ResolveAsTypeTerminal.
752 (Parameter.GetSignature): Change argument to EmitContext.
753 (Parameters.ComputeSignature): Likewise.
754 (Parameters.ComputeParameterTypes): Likewise.
755 (Parameters.GetParameterInfo): Likewise.
756 (Parameters.ComputeAndDefineParameterTypes): Likewise.
757 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
758 * support.cs (InternalParameters..ctor): Remove variant that takes
760 * typemanager.cs (system_intptr_expr): New.
761 (InitExpressionTypes): Initialize it.
763 2004-10-12 Chris Toshok <toshok@ximian.com>
765 * cs-parser.jay: fix location for try_statement and catch_clause.
767 2004-10-18 Martin Baulig <martin@ximian.com>
769 * class.cs (FieldMember.Define): Don't access the TypeExpr's
770 `Type' directly, but call ResolveType() on it.
771 (MemberBase.DoDefine): Likewise.
773 * expression.cs (New.DoResolve): Don't access the TypeExpr's
774 `Type' directly, but call ResolveType() on it.
775 (ComposedCast.DoResolveAsTypeStep): Likewise.
777 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
778 `Type' directly, but call ResolveType() on it.
780 2004-10-17 John Luke <john.luke@gmail.com>
782 * class.cs (Operator.GetSignatureForError): use CSharpName
784 * parameter.cs (Parameter.GetSignatureForError): Returns
785 correct name even if was not defined.
787 2004-10-13 Raja R Harinath <rharinath@novell.com>
790 * class.cs (TypeContainer.EmitContext): New property.
791 (DefineNestedTypes): Create an emitcontext for each part.
792 (MethodCore.DoDefineParameters): Use container's emitcontext.
793 Pass type array to InternalParameters.
794 (MemberBase.DoDefine): Use container's emitcontext.
795 (FieldMember.Define): Likewise.
796 (Event.Define): Likewise.
797 (SetMethod.GetParameterInfo): Change argument to EmitContext.
798 Pass type array to InternalParameters.
799 (SetIndexerMethod.GetParameterInfo): Likewise.
800 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
801 * delegate.cs (Define): Pass emitcontext to
802 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
803 array to InternalParameters.
804 * expression.cs (ParameterReference.DoResolveBase): Pass
805 emitcontext to GetParameterInfo.
806 (ComposedCast.DoResolveAsTypeStep): Remove check on
807 ec.ResolvingTypeTree.
808 * parameter.cs (Parameter.Resolve): Change argument to
809 EmitContext. Use ResolveAsTypeTerminal.
810 (Parameter.GetSignature): Change argument to EmitContext.
811 (Parameters.ComputeSignature): Likewise.
812 (Parameters.ComputeParameterTypes): Likewise.
813 (Parameters.GetParameterInfo): Likewise.
814 (Parameters.ComputeAndDefineParameterTypes): Likewise.
815 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
816 * support.cs (InternalParameters..ctor): Remove variant that takes
818 * typemanager.cs (system_intptr_expr): New.
819 (InitExpressionTypes): Initialize it.
821 2004-10-12 Chris Toshok <toshok@ximian.com>
823 * cs-parser.jay: fix location for try_statement and catch_clause.
825 2004-10-07 Raja R Harinath <rharinath@novell.com>
827 More DeclSpace.ResolveType avoidance.
828 * decl.cs (MemberCore.InUnsafe): New property.
829 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
830 with newly created EmitContext.
831 (FieldMember.Define): Likewise.
832 * delegate.cs (Delegate.Define): Likewise.
833 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
834 only if normal name-lookup fails.
835 (TypeExpr.DoResolve): Enable error-checking.
836 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
837 (SizeOf.DoResolve): Likewise.
838 (ComposedCast.DoResolveAsTypeStep): Likewise.
839 (StackAlloc.DoResolve): Likewise.
840 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
841 (Block.Unsafe): New property.
842 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
843 (Unsafe): Set 'unsafe' flag of contained block.
844 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
845 (Fixed.Resolve): Likewise.
846 (Catch.Resolve): Likewise.
847 (Using.ResolveLocalVariableDecls): Likewise.
848 (Foreach.Resolve): Likewise.
850 2004-10-05 John Luke <john.luke@gmail.com>
852 * cs-parser.jay: add location to error CS0175
854 2004-10-04 Miguel de Icaza <miguel@ximian.com>
856 * ecore.cs (Expression.Constantity): Add support for turning null
859 * const.cs (Const.Define): Allow constants to be reference types
860 as long as the value is Null.
862 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
864 * namespace.cs (NamespaceEntry.Using): No matter which warning
865 level is set, check if this namespace name has already been added.
867 2004-10-03 Ben Maurer <bmaurer@ximian.com>
869 * expression.cs: reftype [!=]= null should always use br[true,false].
872 2004-10-03 Marek Safar <marek.safar@seznam.cz>
875 * attribute.cs: Enum conversion moved to
876 GetAttributeArgumentExpression to be applied to the all
879 2004-10-01 Raja R Harinath <rharinath@novell.com>
881 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
882 * class.c (TypeContainer.DefineType): Flag error if
883 base types aren't accessible due to access permissions.
884 * decl.cs (DeclSpace.ResolveType): Move logic to
885 Expression.ResolveAsTypeTerminal.
886 (DeclSpace.ResolveTypeExpr): Thin layer over
887 Expression.ResolveAsTypeTerminal.
888 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
889 Refactor code into NestedAccess. Use it.
890 (DeclSpace.NestedAccess): New.
891 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
892 argument to silence errors. Check access permissions.
893 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
894 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
895 (Cast.DoResolve): Likewise.
896 (New.DoResolve): Likewise.
897 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
898 (TypeOf.DoResolve): Likewise.
900 * expression.cs (Invocation.BetterConversion): Return the Type of
901 the better conversion. Implement section 14.4.2.3 more faithfully.
902 (Invocation.BetterFunction): Make boolean. Make correspondence to
903 section 14.4.2.2 explicit.
904 (Invocation.OverloadResolve): Update.
905 (Invocation): Remove is_base field.
906 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
907 (Invocation.Emit): Likewise.
909 2004-09-24 Marek Safar <marek.safar@seznam.cz>
911 * cs-parser.jay: Reverted 642 warning fix.
913 2004-09-23 Marek Safar <marek.safar@seznam.cz>
916 * decl.cs (FindMemberWithSameName): Indexer can have more than
919 2004-09-23 Marek Safar <marek.safar@seznam.cz>
921 * expression.cs (LocalVariableReference.DoResolveLValue):
922 Do not report warning 219 for out values.
923 (EmptyExpression.Null): New member to avoid extra allocations.
925 2004-09-23 Marek Safar <marek.safar@seznam.cz>
927 * cs-parser.jay: Fix wrong warning 642 report.
929 * cs-tokenizer.cs (CheckNextToken): New helper;
930 Inspect next character if is same as expected.
932 2004-09-23 Martin Baulig <martin@ximian.com>
934 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
935 (Convert.ImplicitReferenceConversionExists): Likewise.
937 2004-11-09 Raja R Harinath <rharinath@novell.com>
939 * Makefile (DISTFILES): Comment out a few missing files.
941 2004-10-29 Raja R Harinath <rharinath@novell.com>
943 * Makefile (bootstrap_libs,bootstrap_libfiles): New.
944 (bootstrap-libs): New target. Invokes the net_2_0_bootstrap profile.
945 (gmcs.exe): Invoke bootstrap-libs.
946 (clean-local): Clean the net_2_0_bootstrap profile too.
947 (PROGRAM_INSTALL_DIR): New.
948 (install-local): Use it.
950 2004-10-13 Martin Baulig <martin@ximian.com>
952 * generic.cs (TypeManager.InflatedConstraints): New nested class.
953 (TypeParameter.DefineType): If we're a method type parameter and
954 that method is overriding something, "inflate" its constraints.
956 2004-10-12 Martin Baulig <martin@ximian.com>
958 * expression.cs (MemberAccess.DoResolve): If we're a SimpleName
959 and have type arguments, create and resolve a ConstructedType.
961 2004-10-12 Martin Baulig <martin@ximian.com>
963 * decl.cs (MemberCache.FindMemberToOverride): Use
964 TypeManager.IsEqual() to compare the parameters and Type.Equals()
965 to compare the invocationType.
967 * typemanager.cs (TypeManager.IsEqual): Added support for arrays.
968 When comparing two type parameters, only do the signature-only
969 comparision for method type parameters.
971 2004-10-11 Martin Baulig <martin@ximian.com>
973 * report.cs: Don't make --fatal abort on warnings, we have
974 -warnaserror for that.
976 2004-10-11 Martin Baulig <martin@ximian.com>
979 (TypeManager.IsEqualGenericType): Removed, use IsEqual() instead.
980 (TypeManager.IsEqual): Call ourself recursively instead of using
983 2004-10-11 Martin Baulig <martin@ximian.com>
985 * class.cs (TypeContainer.DefineType): Only call TypeParameter.Define()
986 on our own type parameters, not on the ones we inherit from a containing
989 * expression.cs (Invocation.InferType): Use `==', not `Equals()' for
992 * generic.cs (TypeParameter.Define): We may only be called once.
994 * pending.cs (Pending.InterfaceMethod): Call TypeManager.Real_IsEqual()
995 instead of TypeManager.IsEqual().
997 2004-09-28 Martin Baulig <martin@ximian.com>
1000 (GenericConstraints.EffectiveBaseClass): New public property.
1001 (TypeParameter.GenericConstraints): New public property.
1002 (ConstructedType.CheckConstraints): Improved.
1004 * convert.cs (Convert.TypeParam_EffectiveBaseType): New private method.
1005 (Convert.TypeParameterConversion): New private method; use this in
1006 ImplicitReferenceConversion() and ImplicitReferenceConversionExists()
1007 for all conversions related to type parameters.
1009 2004-09-24 Martin Baulig <martin@ximian.com>
1011 * convert.cs (Convert.ImplicitReferenceConversion): Added implicit
1012 type parameter conversions for type parameters which are known to
1015 2004-09-24 Martin Baulig <martin@ximian.com>
1017 * generic.cs (GenericConstraints): Added `IsReferenceType' and
1018 `IsValueType' properties.
1020 * support.cs (ReflectionConstraints): Use
1021 Type.GetGenericParameterConstraints() instead of the old hack.
1023 2004-09-24 Martin Baulig <martin@ximian.com>
1025 * generic.cs (GenericConstraints): Moved here and made it an
1028 * support.cs (GenericConstraints): Moved to generic.cs.
1030 2004-09-24 Martin Baulig <martin@ximian.com>
1033 (ReflectionConstraints): Un-nested this class and made it public.
1036 (TypeManager.GetTypeParameterConstraints): New public method.
1037 (TypeManager.HasConstructorConstraint): Use the attributes.
1039 2004-09-24 Martin Baulig <martin@ximian.com>
1041 * support.cs (GenericConstraints): Replaced `HasConstructor',
1042 `IsReferenceType' and `IsValueType' with `Attributes'.
1043 (ReflectionParameters.ReflectionConstraints): Removed the Create()
1044 method and made the .ctor public.
1046 * generic.cs (Constraints.Attributes): New public property.
1047 (Constraints): Renamed `HasConstructor' -> `HasConstructorConstraint',
1048 `IsReferenceType' -> `HasReferenceTypeConstraint' and
1049 `IsValueType' -> `HasValueTypeConstraint'.
1051 2004-09-23 Martin Baulig <martin@ximian.com>
1053 * generic.cs (Constraints): Reflect latest runtime changes.
1055 2004-09-23 Martin Baulig <martin@ximian.com>
1057 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
1058 (Convert.ImplicitReferenceConversionExists): Likewise.
1060 2004-09-23 Marek Safar <marek.safar@seznam.cz>
1062 * class.cs (Operator.Define): Add error 448 and 559 report.
1064 2004-09-22 Marek Safar <marek.safar@seznam.cz>
1066 * class.cs (MemberBase.IsTypePermitted): New protected
1067 method for checking error CS0610.
1069 2004-09-22 Marek Safar <marek.safar@seznam.cz>
1071 * class.cs (TypeContainer.HasExplicitLayout): New property
1072 Returns whether container has StructLayout attribute set Explicit.
1073 (FieldMember): New abstract class for consts and fields.
1074 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
1075 (Field): Reuse FieldMember.
1077 * const.cs (Const): Reuse FieldMember.
1079 * rootcontext.cs: EmitConstants call moved to class.
1081 2004-09-22 Martin Baulig <martin@ximian.com>
1083 Marek and me just fixed one of our oldest bugs: #28562 :-)
1085 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
1087 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
1088 we're an EnumConstant, just return that.
1089 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
1090 an EnumConstant. In this case, we need to use GetValueAsEnumType()
1091 to get the value which'll actually be written into the attribute.
1092 However, we have to use GetValue() to access the attribute's value
1095 2004-09-22 Marek Safar <marek.safar@seznam.cz>
1097 * constant.cs (Constant.IsNegative): New abstract property
1100 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
1101 (StackAlloc.DoResolve): Reused IsNegative.
1103 2004-09-22 Martin Baulig <martin@ximian.com>
1105 * typemanager.cs (TypeManager.LookupGenericTypeContainer): New
1106 public method; like LookupTypeContainer, but also works for
1109 * report.cs (Report.SymbolRelatedToPreviousError): Use
1110 TypeManager.LookupGenericTypeContainer().
1112 2004-09-22 Martin Baulig <martin@ximian.com>
1114 Thanks to Peter Sestoft for this bug report.
1116 * expression.cs (Conditional): If both the `trueExpr' and the
1117 `falseExpr' is a NullLiteral, return a NullLiteral.
1119 2004-09-22 Martin Baulig <martin@ximian.com>
1121 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
1122 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
1123 for the "get_Current" call.
1125 2004-09-21 Martin Baulig <martin@ximian.com>
1127 * convert.cs (Convert.ImplicitReferenceConversion): When
1128 converting to an interface type, first check whether we're
1129 converting from a reference type.
1131 2004-09-14 Martin Baulig <martin@ximian.com>
1133 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
1135 2004-09-14 Marek Safar <marek.safar@seznam.cz>
1138 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
1139 called and is obsolete then this member suppress message
1140 when call is inside next [Obsolete] method or type.
1142 * expression.cs: Use TestObsoleteMethodUsage member.
1144 2004-09-14 Martin Baulig <martin@ximian.com>
1146 * genericparser.cs: Removed.
1148 2004-09-13 Marek Safar <marek.safar@seznam.cz>
1150 * class.cs (MethodCore.CheckBase): Fix bug #65757.
1152 2004-09-12 Marek Safar <marek.safar@seznam.cz>
1154 * attribute.cs (Attribute.Resolve): Add error 653 report.
1156 * class.cs (Class.ApplyAttributeBuilder): Add error 641
1158 (Method.ApplyAttributeBuilder): Add error 685 report.
1159 (Operator.Define): Add error 564 report.
1161 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
1163 * expression.cs (Invocation.DoResolve): Add error
1166 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
1169 2004-09-11 Marek Safar <marek.safar@seznam.cz>
1171 * class.cs (ConstructorInitializer.Resolve):
1172 Wrong error number (515->516).
1174 2004-09-11 Marek Safar <marek.safar@seznam.cz>
1176 * class.cs (Indexer.Define): Add error 631 report.
1178 2004-09-11 Marek Safar <marek.safar@seznam.cz>
1180 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
1182 2004-09-11 Marek Safar <marek.safar@seznam.cz>
1184 * expression.cs (Probe.DoResolve): Add error CS0241 report.
1186 2004-09-10 Marek Safar <marek.safar@seznam.cz>
1188 * cs-parser.jay: Added error CS0241 report.
1190 2004-09-10 Raja R Harinath <rharinath@novell.com>
1192 * cs-parser.jay (fixed_statement): Introduce a scope for the
1193 declaration in the 'fixed' statement.
1195 2004-09-09 Marek Safar <marek.safar@seznam.cz>
1197 * cs-parser.jay: Added CS0230 error report.
1199 2004-09-09 Marek Safar <marek.safar@seznam.cz>
1201 * cs-parser.jay: Added errors CS0231 and CS0257 report.
1203 2004-09-09 Marek Safar <marek.safar@seznam.cz>
1205 * expression.cs (Argument.Resolve): Added error CS0192 and
1208 2004-09-09 Marek Safar <marek.safar@seznam.cz>
1210 C# 2.0 #pragma warning feature
1212 * cs-tokenizer.cs (PreProcessPragma): New method;
1213 Handles #pragma directive.
1215 * report.cs (WarningRegions): New class; Support
1216 class for #pragma warning directive. It tests whether
1217 warning is enabled for a given line.
1219 2004-09-08 Miguel de Icaza <miguel@ximian.com>
1221 * const.cs: Add more descriptive error report, tahnks to
1224 2004-09-08 Marek Safar <marek.safar@seznam.cz>
1226 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
1228 2004-09-07 Miguel de Icaza <miguel@ximian.com>
1230 * expression.cs: Apply patch from Ben: Remove dead code from
1231 ArrayCreation, and remove the TurnintoConstant call in const.cs,
1232 as that code just threw an exception anwyays.
1234 * const.cs: Remove the call to the turnintoconstant, for details
1237 * literal.cs: The type of the null-literal is the null type; So
1238 we use a placeholder type (literal.cs:System.Null, defined here)
1241 * expression.cs (Conditional.DoResolve): Remove some old code that
1242 is no longer needed, conversions have been fixed.
1244 (ArrayCreationExpression.DoResolve): Return false if we fail to
1245 resolve the inner expression.
1247 2004-09-07 Raja R Harinath <rharinath@novell.com>
1250 * cs-parser.jay (delegate_declaration): Record a delegate
1251 declaration as a type declaration.
1252 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
1254 2004-09-06 Miguel de Icaza <miguel@ximian.com>
1256 * parameter.cs: Do not crash if the type can not be resolved.
1258 * expression.cs: Report errors with unsafe pointers, fixes #64896
1260 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
1262 * expression.cs: Pointer arith always needs to do a conv.i
1263 if the operand is a long. fix 65320
1265 2004-09-04 Marek Safar <marek.safar@seznam.cz>
1267 Fixed cs0619-37.cs, cs0619-38.cs
1269 * enum.cs (GetObsoleteAttribute): Removed.
1271 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
1272 on Enum member is double staged. The first is tested member
1275 2004-09-04 Marek Safar <marek.safar@seznam.cz>
1277 Fixed #56986, #63631, #65231
1279 * class.cs: (TypeContainer.AddToMemberContainer): New method,
1280 adds member to name container.
1281 (TypeContainer.AddToTypeContainer): New method, adds type to
1283 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
1284 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
1285 AddOperator): Simplified by reusing AddToMemberContainer.
1286 (TypeContainer.UserDefinedStaticConstructor): Changed to property
1288 (Method.CheckForDuplications): Fixed implementation to test all
1290 (MemberBase): Detection whether member is explicit interface
1291 implementation is now in constructor.
1292 (MemberBase.UpdateMemberName): Handles IndexerName.
1293 (Accessor): Changed to keep also location information.
1294 (AbstractPropertyEventMethod): Is derived from MemberCore.
1295 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
1296 will be emited or not.
1297 (PropertyBase.AreAccessorsDuplicateImplementation):
1298 Tests whether accessors are not in collision with some method.
1299 (Operator): Is derived from MethodCore to simplify common
1302 * decl.cs (Flags.TestMethodDuplication): Test for duplication
1304 (DeclSpace.AddToContainer): Adds the member to defined_names
1305 table. It tests for duplications and enclosing name conflicts.
1307 * enum.cs (EnumMember): Clean up to reuse the base structures
1309 2004-09-03 Martin Baulig <martin@ximian.com>
1311 Merged latest changes into gmcs. Please keep this comment in
1312 here, it makes it easier for me to see what changed in MCS since
1313 the last time I merged.
1315 2004-09-03 Martin Baulig <martin@ximian.com>
1317 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
1318 into TypeContainer, to make partial classes work again.
1320 2004-09-03 Martin Baulig <martin@ximian.com>
1322 * rootcontext.cs (RootContext.V2): Removed.
1324 2004-03-23 Martin Baulig <martin@ximian.com>
1326 * expression.cs (Invocation.OverloadResolve): Added `bool
1327 may_fail' argument and use it instead of the Location.IsNull() hack.
1329 2004-09-09 Martin Baulig <martin@ximian.com>
1331 * cs-parser.jay (namespace_declaration): Fixed CS0134 reporting.
1333 2004-09-09 Martin Baulig <martin@ximian.com>
1335 * generic.cs (TypeParameter.DefineType): Added support for
1336 explicit interface methods.
1338 2004-09-09 Martin Baulig <martin@ximian.com>
1340 * README.Changes: New document. Started to list important changes
1341 between MCS and GMCS here.
1343 2004-09-08 Martin Baulig <martin@ximian.com>
1346 (TypeContainer.CheckRecursiveDefinition): New protected method.
1347 (TypeContainer.DefineType): Move the CS0146 check into
1348 CheckRecursiveDefinition().
1350 2004-09-06 Martin Baulig <martin@ximian.com>
1352 * generic.cs (ConstructedType.CheckConstraints): Allow builtin
1353 types for the constructor constraint.
1355 2004-09-03 Martin Baulig <martin@ximian.com>
1357 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
1358 into TypeContainer, to make partial classes work again.
1360 2004-09-03 Martin Baulig <martin@ximian.com>
1362 * rootcontext.cs (RootContext.V2): Removed.
1364 2004-03-23 Martin Baulig <martin@ximian.com>
1366 * expression.cs (Invocation.OverloadResolve): Added `bool
1367 may_fail' argument and use it instead of the Location.IsNull() hack.
1369 2004-09-03 Martin Baulig <martin@ximian.com>
1371 Merged latest changes into gmcs. Please keep this comment in
1372 here, it makes it easier for me to see what changed in MCS since
1373 the last time I merged.
1375 2004-09-03 Raja R Harinath <rharinath@novell.com>
1378 * expression.cs (BetterConversion): Don't allow either conversion
1379 to be null. Remove redundant implicit conversion test when 'q ==
1380 null' -- when this function is invoked, we already know that the
1381 implicit conversion exists.
1382 (BetterFunction): Assume that 'best' is non-null. Remove
1383 redundant reimplementation of IsApplicable when 'best' is null.
1384 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
1385 number of arguments.
1386 (IsAncestralType): Extract from OverloadResolve.
1387 (OverloadResolve): Make robust to the MethodGroupExpr being
1388 unsorted. Implement all the logic of Section 14.5.5.1, and
1389 support overloading of methods from multiple applicable types.
1390 Clean up logic somewhat. Don't pass null methods to BetterFunction.
1392 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
1393 (RealError, Warning): Append type of report to related symbol.
1395 2004-09-03 Marek Safar <marek.safar@seznam.cz>
1397 * enum.cs: Fixed CLS-Compliance checks for enum members.
1398 Error tests cs3008-8.cs, cs3014-8.cs
1400 2004-09-02 Marek Safar <marek.safar@seznam.cz>
1402 Fixed bug #62342, #63102
1403 * class.cs: ImplementIndexer uses member.IsExplicitImpl
1404 like ImplementMethod.
1406 2004-09-02 Marek Safar <marek.safar@seznam.cz>
1408 * attribute.cs (Attribute.GetAttributeArgumentExpression):
1411 2004-09-02 Martin Baulig <martin@ximian.com>
1413 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
1414 TypeManager.GetArgumentTypes() rather than calling GetParameters()
1417 2004-09-01 Marek Safar <marek.safar@seznam.cz>
1419 C# 2.0 Static classes implemented
1421 * class.cs (TypeContainer): instance_constructors,
1422 initialized_fields, initialized_static_fields,
1423 default_constructor, base_inteface_types are protected to be
1424 accessible from StaticClass.
1425 (TypeContainer.DefineDefaultConstructor): New virtual method
1426 for custom default constructor generating
1427 (StaticClass): New class to handle "Static classes" feature.
1429 * cs-parser.jay: Handle static keyword on class like instance
1432 * driver.cs: Added "/langversion" command line switch with two
1433 options (iso-1, default).
1435 2004-08-31 Marek Safar <marek.safar@seznam.cz>
1437 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
1439 2004-08-31 Miguel de Icaza <miguel@ximian.com>
1441 * delegate.cs: Style.
1443 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
1445 * delegate.cs: Add seperate instance expr field for miguel.
1447 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
1449 * PointerArithmetic (Resolve): make sure we are not doing
1450 pointer arith on void*. Also, make sure we are resolved
1451 by not setting eclass until resolve.
1453 All callers: Make sure that PointerArithmetic gets resolved.
1455 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
1457 * ArrayCreation (LookupType): If the type does not resolve
1458 to an array, give an error.
1460 2004-08-27 Marek Safar <marek.safar@seznam.cz>
1462 * statement.cs (Try.Resolve): Fixed bug #64222
1464 2004-08-27 Martin Baulig <martin@ximian.com>
1467 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
1470 2004-08-26 Marek Safar <marek.safar@seznam.cz>
1472 * ecore.cs (Constantify): Get underlying type via
1473 System.Enum.GetUnderlyingType to avoid StackOverflow on the
1474 Windows in special cases.
1476 2004-08-26 Marek Safar <marek.safar@seznam.cz>
1478 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
1479 for obtaining also private methods.
1480 (GetRemoveMethod): Used GetRemoveMethod (true)
1481 for obtaining also private methods.
1483 2004-09-02 Martin Baulig <martin@ximian.com>
1485 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
1486 TypeManager.GetArgumentTypes() rather than calling GetParameters()
1489 2004-08-27 Martin Baulig <martin@ximian.com>
1492 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
1495 2004-08-25 Martin Baulig <martin@ximian.com>
1497 * support.cs (ReflectionParameters..ctor): If this is a generic
1498 method, retrieve and store its type parameters.
1499 (InternalParameters..ctor): Added `TypeParameter[]' argument.
1500 (ReflectionParameters.GenericConstraints): The argument specifies
1501 the type parameter, not the method parameter.
1502 (InternalParameters.GenericConstraints): Likewise.
1504 * generic.cs (TypeParameter.DefineType): Correctly handle
1505 constraints wrt. generic methods in interfaces and their
1508 2004-08-24 Martin Baulig <martin@ximian.com>
1510 * generic.cs (TypeParameter.IsSubclassOf): New public method.
1511 (Constraints.IsSubclassOf): New internal method.
1513 * typemanager.cs (TypeManager.FindMembers): Added special support
1514 for GenericTypeParameterBuilder's.
1515 (TypeManager.IsSubclassOf, IsFamilyAccessible): Added support for
1518 2004-08-24 Martin Baulig <martin@ximian.com>
1521 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
1522 this for accessibility checks.
1523 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
1524 IsNestedFamilyAccessible.
1525 (TypeManager.IsSubclassOf): New method, do what the name actually
1528 2004-08-24 Martin Baulig <martin@ximian.com>
1530 * expression.cs (MemberAccess.DoResolve): When resolving ourselves
1531 as a SimpleName, include the generic arity.
1533 2004-08-24 Martin Baulig <martin@ximian.com>
1535 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
1536 MethodAttributes.HideBySig for operators.
1538 2004-08-23 Martin Baulig <martin@ximian.com>
1540 Back to the old error reporting system :-)
1542 * report.cs (Message): Removed.
1543 (Report.MessageData, ErrorData, WarningData): Removed.
1544 (Report.Error, Warning): Back to the old system.
1546 2004-08-23 Martin Baulig <martin@ximian.com>
1548 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
1550 * class.cs (TypeContainer.ParentContainer): New public virtual
1551 method; replaces the explicit interface implementation.
1552 (ClassPart.ParentContainer): Override.
1554 2004-08-23 Martin Baulig <martin@ximian.com>
1556 * statement.cs (Switch): Added support for constant switches; see
1557 #59428 or test-285.cs.
1559 2004-08-22 Marek Safar <marek.safar@seznam.cz>
1562 * statement.cs (GetEnumeratorFilter): Removed useless
1563 logic because C# specs is strict. GetEnumerator must be
1566 2004-08-22 Martin Baulig <martin@ximian.com>
1568 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
1569 a switch and may break, reset the barrier. Fixes #59867.
1571 2004-08-22 Marek Safar <marek.safar@seznam.cz>
1573 CLS-Compliance speed up (~5% for corlib)
1575 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
1576 New method. Tests container for CLS-Compliant names
1578 * class.cs (TypeContainer.VerifyClsName): New method.
1579 Checks whether container name is CLS Compliant.
1580 (Constructor): Implements IMethodData.
1582 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
1583 low-case table for CLS Compliance test.
1584 (MemberCache.VerifyClsParameterConflict): New method.
1585 Checks method parameters for CS3006 error.
1587 * enum.cs (EnumMember): Is derived from MemberCore.
1588 (Enum.VerifyClsName): Optimized for better performance.
1590 2004-08-06 Marek Safar <marek.safar@seznam.cz>
1592 * report.cs: Renamed Error_T to Error and changed all
1595 2004-08-06 Marek Safar <marek.safar@seznam.cz>
1597 * class.cs (TypeContainer.IndexerArrayList): New inner class
1598 container for indexers.
1599 (TypeContainer.DefaultIndexerName): New constant for default
1600 indexer name. Replaced all "Item" with this constant.
1601 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
1603 * typemanager.cs (TypeManager.default_member_ctor): Cache here
1604 DefaultMemberAttribute constructor.
1606 2004-08-05 Martin Baulig <martin@ximian.com>
1608 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
1611 2004-08-05 Marek Safar <marek.safar@seznam.cz>
1613 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
1614 multi platforms problem.
1616 * compiler.csproj: Included shared files.
1618 2004-08-04 Marek Safar <marek.safar@seznam.cz>
1620 Fix bug 60333, 55971 in the more general way
1621 * attribute.cs (Attribute.GetAttributeArgumentExpression):
1622 Added arg_type argument for constant conversion.
1623 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
1625 2004-08-04 Marek Safar <marek.safar@seznam.cz>
1628 * class.cs (TypeContainer ): New inner classes MethodArrayList,
1629 OperatorArrayList, MethodCoreArrayList for typecontainer
1630 containers. Changed class member types to these new types.
1631 (MethodArrayList.DefineMembers): Added test for CS0659.
1633 2004-08-04 Miguel de Icaza <miguel@ximian.com>
1635 * cfold.cs: Synchronize the folding with the code in expression.cs
1636 Binary.DoNumericPromotions for uint operands.
1638 * attribute.cs: Revert patch from Raja, it introduced a regression
1639 while building Blam-1.2.1 (hard to isolate a test case).
1641 2004-08-04 Marek Safar <marek.safar@seznam.cz>
1645 (TypeContainer.Define): Renamed to DefineContainerMembers because of
1647 (MethodCore.parent_method): New member. The method we're overriding
1648 if this is an override method.
1649 (MethodCore.CheckBase): Moved from Method class and made common.
1650 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
1652 (MethodCore.CheckForDuplications): New abstract method. For custom
1653 member duplication search in a container
1654 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
1655 method and its return type.
1656 (Event.conflict_symbol): New member. Symbol with same name in the
1660 (MemberCache.FindMemberWithSameName): New method. The method
1661 is looking for conflict with inherited symbols.
1663 2004-08-04 Martin Baulig <martin@ximian.com>
1665 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
1667 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
1669 2004-08-03 Marek Safar <marek.safar@seznam.cz>
1671 * report.cs (Message): New enum for better error, warning reference in
1673 (MessageData): New inner abstract class. It generally handles printing of
1674 error and warning messages.
1675 Removed unused Error, Warning, Message methods.
1677 2004-08-03 Marek Safar <marek.safar@seznam.cz>
1679 Fix for cs0592-8.cs test
1681 (Attributable.ValidAttributeTargets): Made public.
1682 (Attribute.ExplicitTarget): New member for explicit target value.
1683 (Attribute.CheckTargets): Now we translate explicit attribute
1684 target to Target here.
1686 2004-08-03 Ben Maurer <bmaurer@ximian.com>
1688 * ecore.cs (MethodGroupExpr): new IsBase property.
1690 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
1692 * delegate.cs (DelegateCreation): store a MethodGroupExpr
1693 rather than an instance expr.
1695 (DelegateCreation.Emit): Use the method group rather than
1696 the instance expression. Also, if you have base.Foo as the
1697 method for a delegate, make sure to emit ldftn, not ldftnvirt.
1699 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
1701 (NewDelegate.DoResolve): Only check for the existance of Invoke
1702 if the method is going to be needed. Use MethodGroupExpr.
1704 (NewDelegate.Emit): Remove, DelegateCreation implements this.
1706 * expression.cs: For pointer arith., make sure to use
1707 the size of the type, not the size of the pointer to
1710 2004-08-03 Marek Safar <marek.safar@seznam.cz>
1713 * class.cs (Class): Added error CS0502 test.
1715 2004-08-03 John Luke <jluke@cfl.rr.com>
1716 Raja R Harinath <rharinath@novell.com>
1719 * attribute.cs (Attribute.complained_before): New flag.
1720 (Attribute.ResolveType, Attribute.Resolve),
1721 (Attribute.DefinePInvokeMethod): Set it.
1722 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
1724 2004-08-03 Martin Baulig <martin@ximian.com>
1726 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
1727 use a user-defined operator; we still need to do numeric
1728 promotions in case one argument is a builtin type and the other
1729 one has an implicit conversion to that type. Fixes #62322.
1731 2004-08-18 Martin Baulig <martin@ximian.com>
1733 * class.cs (Method.Define): Use the correct method name when
1734 creating the MethodBuilder for a generic method.
1736 2004-08-17 Martin Baulig <martin@ximian.com>
1738 * generic.cs (Constraints): Support type parameter constraints.
1740 2004-08-16 Martin Baulig <martin@ximian.com>
1742 * cs-tokenizer.cs (Tokenizer.TypeOfParsing): New public property.
1743 (Token.GENERIC_DIMENSION): New token; this is returned if we
1744 encounter an unbound generic type in a typeof() expression.
1746 * cs-parser.jay (opt_type_argument_list): Added GENERIC_DIMENSION;
1747 this token is only generated while parsing a typeof() expression.
1748 (typeof_expression): Removed the old unbound_type hack.
1750 * generic.cs (TypeArguments.IsUnbound): New public property.
1752 * decl.cs (MemberName): Added support for unbound types.
1754 2004-08-14 Martin Baulig <martin@ximian.com>
1757 (TypeManager.IsEqualGenericInstance): New static method.
1758 (TypeManager.IsSubclassOrNestedChildOf, IsSubclassOf): This is
1759 just used to check accessibility, so follow the rules of 26.1.6.
1761 * expression.cs (MemberAccess.ResolveAsTypeStep): Return a
1762 ConstructedType instead of a TypeExpression if we have type arguments.
1764 * cs-parser.jay (typeof_expression): Support unbound generic types.
1766 * ecore.cs (UnboundTypeExpression): New public class.
1768 2004-08-12 Martin Baulig <martin@ximian.com>
1770 * typemanager.cs (TypeManager.IsNestedChildOf): Use
1771 TypeManager.IsEqual() rather than `=='.
1773 * decl.cs (DeclSpace.CheckAccessLevel): Use `tb.FullName' for
1774 generic instances as well.
1776 2004-08-12 Martin Baulig <martin@ximian.com>
1778 * expression.cs (Invocation.InferType): We can only infer method
1779 type parameters. Fixes #62647.
1781 2004-08-11 Martin Baulig <martin@ximian.com>
1783 * class.cs (TypeContainer.DefineType): Create the TypeBuilder
1784 before resolving the base classes.
1786 2004-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
1788 * Makefile: install .mdb file too.
1790 2004-08-05 Martin Baulig <martin@ximian.com>
1792 * ecore.cs (FieldExpr.DoResolveLValue): If we're resolving a field
1793 initializer, the current type is just the TypeBuilder, not the
1794 instantiated generic type.
1795 (FieldExpr.IsFieldInitializer): New public property.
1797 2004-08-04 Martin Baulig <martin@ximian.com>
1799 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
1801 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
1803 2004-08-03 Martin Baulig <martin@ximian.com>
1805 * class.cs (MethodData.Define): If we're an explicit
1806 implementation, remove the generic arity from the type name.
1808 2004-08-03 Martin Baulig <martin@ximian.com>
1810 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
1811 use a user-defined operator; we still need to do numeric
1812 promotions in case one argument is a builtin type and the other
1813 one has an implicit conversion to that type. Fixes #62322.
1815 2004-08-02 Martin Baulig <martin@ximian.com>
1817 * class.cs (TypeContainer.ifaces): Make this a `Type[]', not a
1819 (TypeContainer.GetClassBases): Return the unexpanded list of
1820 interfaces; we expand them later.
1821 (TypeContainer.DefineType): After creating the TypeBuilder, call
1822 TypeManager.ExpandInterfaces() to get an expanded and resolved
1825 * ecore.cs (TypeExpr.GetInterfaces): Removed
1827 * generics.cs (Constraints.InterfaceConstraints): Remove.
1828 (TypeParameter.DefineType): Call TypeManager.RegisterBuilder() to
1829 register the interface constraints.
1832 (TypeManager.AddUserType): Removed the `ifaces' argument.
1833 (TypeManager.AddTypeParameter): Likewise.
1834 (TypeManager.AddUserInterface): Removed, was unused.
1835 (TypeManager.RegisterBuilder): Take a `Type[]' instead of a
1836 `TypeExpr[]' array for the interfaces.
1837 (TypeManager.ExpandInterfaces): Call this after the TypeBuilder
1838 has been defined, returns a list of the resolved interfaces types.
1839 (TypeManager.GetInterfaces): Return a `Type[]', not a `TypeExpr[]'.
1840 (TypeManager.GetExplicitInterfaces): Likewise.
1842 2004-08-02 Martin Baulig <martin@ximian.com>
1844 * expression.cs (Invocation.EmitCall): If we're invoking a method
1845 on a type parameter, use the new `Constrained' prefix opcode.
1847 2004-08-02 Martin Baulig <martin@ximian.com>
1849 * statement.cs (LocalInfo.Flags): Added `IsThis'.
1850 (LocalInfo.IsThis): New public property.
1851 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
1853 2004-08-01 Martin Baulig <martin@ximian.com>
1855 * class.cs (TypeContainer.GetClassBases): Don't set the default
1856 here since we may get called from GetPartialBases().
1857 (TypeContainer.DefineType): If GetClassBases() didn't return a
1858 parent, use the default one.
1860 2004-07-30 Martin Baulig <martin@ximian.com>
1862 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
1864 * class.cs (SourceMethod): New public class, derive from the
1865 symbol writer's ISourceMethod.
1866 (Method): Use the new symbol writer API.
1868 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
1869 as argument and use the new symbol writer.
1872 (SourceFile): Implement the symbol writer's ISourceFile.
1873 (Location.SymbolDocument): Removed.
1874 (Location.SourceFile): New public property.
1876 * symbolwriter.cs: Use the new symbol writer API.
1878 2004-07-30 Raja R Harinath <rharinath@novell.com>
1880 * Makefile (install-local): Remove. Functionality moved to
1883 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
1885 * Makefile: Install mcs.exe.config file together with mcs.exe.
1886 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
1887 correct runtime version.
1889 2004-07-25 Martin Baulig <martin@ximian.com>
1892 (TypeContainer.RegisterOrder): Removed, this was unused.
1893 (TypeContainer, interface_order): Removed.
1894 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
1895 TypeContainer as argument since we can also be called with a
1896 `PartialContainer' for a partial class/struct/interface.
1897 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
1898 of checking whether we're an `Interface' - we could be a
1900 (PartialContainer.Register): Override; call
1901 AddClass()/AddStruct()/AddInterface() on our parent.
1903 * cs-parser.jay (interface_member_declaration): Add things to the
1904 `current_container', not the `current_class'.
1906 * rootcontext.cs (RegisterOrder): The overloaded version which
1907 takes an `Interface' was unused, removed.
1909 * typemanager.cs (TypeManager.LookupInterface): Return a
1910 `TypeContainer', not an `Interface'.
1911 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
1912 contain a `PartialContainer' for an interface, so check it's
1913 `Kind' to figure out what it is.
1915 2004-07-25 Martin Baulig <martin@ximian.com>
1917 * class.cs (Class.DefaultTypeAttributes): New public constant.
1918 (Struct.DefaultTypeAttributes): Likewise.
1919 (Interface.DefaultTypeAttributes): Likewise.
1920 (PartialContainer.TypeAttr): Override this and add the
1921 DefaultTypeAttributes.
1923 2004-07-25 Martin Baulig <martin@ximian.com>
1925 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
1926 we can just use the `Parent' field instead.
1928 2004-07-25 Martin Baulig <martin@ximian.com>
1930 * class.cs (TypeContainer.Emit): Renamed to EmitType().
1932 2004-07-25 Martin Baulig <martin@ximian.com>
1934 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
1935 our parts before defining any methods.
1936 (TypeContainer.VerifyImplements): Make this virtual.
1937 (ClassPart.VerifyImplements): Override and call VerifyImplements()
1938 on our PartialContainer.
1940 2004-07-25 Martin Baulig <martin@ximian.com>
1942 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
1944 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
1945 argument, we can just use the `Parent' field instead.
1948 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
1949 (MemberBase.DoDefine): Likewise.
1951 2004-07-24 Martin Baulig <martin@ximian.com>
1953 * decl.cs (MemberCore.Parent): New public field.
1954 (DeclSpace.Parent): Moved to MemberCore.
1956 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
1957 (MemberBase.ctor): Added TypeContainer argument, pass it to our
1959 (FieldBase, Field, Operator): Likewise.
1960 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
1961 (EventField, Event): Likewise.
1963 2004-07-23 Martin Baulig <martin@ximian.com>
1965 * class.cs (PartialContainer): New public class.
1966 (ClassPart): New public class.
1967 (TypeContainer): Added support for partial classes.
1968 (TypeContainer.GetClassBases): Splitted some of the functionality
1969 out into GetNormalBases() and GetPartialBases().
1971 * cs-tokenizer.cs (Token.PARTIAL): New token.
1972 (Tokenizer.consume_identifier): Added some hacks to recognize
1973 `partial', but only if it's immediately followed by `class',
1974 `struct' or `interface'.
1976 * cs-parser.jay: Added support for partial clases.
1978 2004-07-23 Martin Baulig <martin@ximian.com>
1980 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
1981 a `DeclSpace' and also made it readonly.
1982 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
1983 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
1984 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
1986 * cs-parser.jay: Pass the `current_class', not the
1987 `current_container' (at the moment, this is still the same thing)
1988 to a new Method, Property, Event, Indexer or Constructor.
1990 2004-07-23 Martin Baulig <martin@ximian.com>
1992 * cs-parser.jay (CSharpParser): Added a new `current_class' field
1993 and removed the `current_interface' one.
1994 (struct_declaration, class_declaration, interface_declaration):
1995 Set `current_class' to the newly created class/struct/interface;
1996 set their `Bases' and call Register() before parsing their body.
1998 2004-07-23 Martin Baulig <martin@ximian.com>
2000 * class.cs (Kind): New public enum.
2001 (TypeContainer): Made this class abstract.
2002 (TypeContainer.Kind): New public readonly field.
2003 (TypeContainer.CheckDef): New public method; moved here from
2005 (TypeContainer.Register): New public abstract method.
2006 (TypeContainer.GetPendingImplementations): New public abstract
2008 (TypeContainer.GetClassBases): Removed the `is_class' and
2009 `is_iface' parameters.
2010 (TypeContainer.DefineNestedTypes): Formerly known as
2012 (ClassOrStruct): Made this class abstract.
2014 * tree.cs (RootTypes): New public type.
2016 2004-07-20 Martin Baulig <martin@ximian.com>
2018 * tree.cs (Tree.RecordNamespace): Removed.
2019 (Tree.Namespaces): Removed.
2021 * rootcontext.cs (RootContext.IsNamespace): Removed.
2023 * cs-parser.jay (namespace_declaration): Just create a new
2024 NamespaceEntry here.
2026 2004-07-21 Lluis Sanchez Gual <lluis@novell.com>
2028 * Makefile: Install gmcs.exe.config file together with gmcs.exe.
2029 * gmcs.exe.config: Renamed from mcs.exe.config. Added supportedRuntime
2030 entry to make sure it runs in the correct runtime version.
2032 2004-07-18 Martin Baulig <martin@ximian.com>
2034 * generic.cs (ConstructedType.CheckConstraints): Improved
2035 constraints checking.
2037 2004-07-18 Martin Baulig <martin@ximian.com>
2039 * expression.cs (Invocation.BetterMethod): Call
2040 TypeManager.TypeToCoreType() on all types and removed my previous
2041 hack; we're already doig the right thing here.
2043 2004-07-17 Martin Baulig <martin@ximian.com>
2045 * decl.cs (MemberName.MakeName): Create the "class`1" names here.
2047 2004-07-16 Martin Baulig <martin@ximian.com>
2049 * iterators.cs: Added generics support.
2051 2004-07-16 Martin Baulig <martin@ximian.com>
2053 * iterators.cs: Rewrote this. We're now using one single Proxy
2054 class for both the IEnumerable and the IEnumerator interface and
2055 `Iterator' derives from Class so we can use the high-level API.
2057 * class.cs (TypeContainer.AddIterator): New method.
2058 (TypeContainer.DoDefineType): New protected virtual method, which
2059 is called from DefineType().
2060 (TypeContainer.DoDefineMembers): Call DefineType() and
2061 DefineMembers() on all our iterators.
2062 (TypeContainer.Emit): Call Emit() on all our iterators.
2063 (TypeContainer.CloseType): Call CloseType() on all our iterators.
2065 * codegen.cs (EmitContext.CurrentIterator): New public field.
2067 2004-07-15 Martin Baulig <martin@ximian.com>
2070 (TypeManager.not_supported_exception_type): New type.
2072 2004-07-14 Martin Baulig <martin@ximian.com>
2075 (TypeManager.generic_ienumerable_type): New type.
2076 (TypeManager.generic_ienumerator_type): New type.
2079 (RootContext.interfaces_first_stage): Added
2080 "System.Collections.Generic.IEnumerator`1" and
2081 "System.Collections.Generic.IEnumerable`1".
2083 2004-07-14 Martin Baulig <martin@ximian.com>
2085 * iterators.cs: Use real error numbers.
2087 2004-07-14 Martin Baulig <martin@ximian.com>
2089 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
2090 requires this to be a System.Collection.IEnumerable and not a
2091 class implementing that interface.
2092 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
2094 2004-07-13 Marek Safar <marek.safar@seznam.cz>
2096 * class.cs: Fixed previous fix, it broke some error tests.
2098 2004-07-12 Martin Baulig <martin@ximian.com>
2100 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
2103 2004-07-14 Martin Baulig <martin@ximian.com>
2105 * decl.cs, expression.cs, generic.cs: Use a backqoute (`) and not
2106 an exclamation mark (!) for the generic arity to reflect the
2107 latest spec changes; ie. use "System.Collections.Generic.IList`1".
2109 2004-07-13 Martin Baulig <martin@ximian.com>
2111 * cs-tokenizer.cs (Tokenizer.parse_less_than): Allow array rank
2112 specifiers being part of a type argument.
2114 2004-07-13 Martin Baulig <martin@ximian.com>
2116 * expression.cs (MemberAccess.ResolveAsTypeStep): Use the full `!'
2117 name for generic types.
2119 2004-07-13 Martin Baulig <martin@ximian.com>
2121 * assign.cs (Assign.DoResolve): Moved the CS0131 check up a little
2124 2004-07-09 Miguel de Icaza <miguel@ximian.com>
2126 * assign.cs (LocalTemporary): Add new argument: is_address,If
2127 `is_address' is true, then the value that we store is the address
2128 to the real value, and not the value itself.
2130 * ecore.cs (PropertyExpr): use the new local temporary
2131 stuff to allow us to handle X.Y += z (where X is a struct)
2133 2004-07-08 Martin Baulig <martin@ximian.com>
2135 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
2136 not always return, just like we're doing in Using.Resolve().
2138 2004-07-07 Miguel de Icaza <miguel@ximian.com>
2140 * cs-parser.jay (fixed_statement): flag this as Pinned.
2142 2004-07-06 Miguel de Icaza <miguel@ximian.com>
2144 * typemanager.cs (TypeManager): Removed MakePinned method, this
2145 mechanism is replaced with the .NET 2.x compatible mechanism of
2146 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
2148 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
2149 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
2150 `IsFixed' property which has a different meaning.
2152 2004-07-02 Raja R Harinath <rharinath@novell.com>
2154 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
2155 visible from inside a nested class, not just the names of the
2156 immediately enclosing class.
2159 2004-06-24 Raja R Harinath <rharinath@novell.com>
2161 * expression.cs (BetterConversion): Remove buggy special-case
2162 handling of "implicit constant expression conversions". At this
2163 point, we already know that the conversion is possible -- we're
2164 only checking to see which is better.
2166 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2168 * cs-parser.jay: Added error CS0210 test.
2170 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2172 * cs-parser.jay: Added error CS0134 test.
2174 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2177 * cs-parser.jay: Added error CS0145 test.
2179 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2181 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
2183 2004-06-23 Ben Maurer <bmaurer@ximian.com>
2185 * expression.cs (StackAlloc.Resolve): The argument may not
2186 be a constant; deal with this case.
2188 2004-06-23 Marek Safar <marek.safar@seznam.cz>
2190 * attribute.cs (IndexerName_GetIndexerName): Renamed to
2191 GetIndexerAttributeValue.
2192 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
2194 * class.cs (Indexer.Define): Added error tests for CS0415,
2197 2004-06-23 Miguel de Icaza <miguel@ximian.com>
2199 * attribute.cs (Attribute.Resolve): Keep field code in sync with
2202 2004-06-23 Martin Baulig <martin@ximian.com>
2204 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
2205 neither return nor throw, reset the barrier as well. Fixes #60457.
2207 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
2209 * class.cs : EventAttributes is now set to None by default.
2210 This fixes bug #60459.
2212 2004-06-18 Marek Safar <marek.safar@seznam.cz>
2215 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
2216 Don't throw exception but return null (it's sufficient now).
2218 2004-06-18 Marek Safar <marek.safar@seznam.cz>
2220 * typemanager.cs (GetArgumentTypes): Faster implementation.
2222 2004-06-18 Martin Baulig <martin@ximian.com>
2224 * attribute.cs (Attribute.Resolve): Check whether we're an
2225 EmptyCast which a Constant child. Fixes #60333.
2227 2004-06-17 Ben Maurer <bmaurer@ximian.com>
2229 * statement.cs (EmitCollectionForeach): Account for the fact that
2230 not all valuetypes are in areas which we can take the address of.
2231 For these variables, we store to a temporary variable. Also, make
2232 sure that we dont emit a `callvirt' on a valuetype method.
2234 2004-06-15 Marek Safar <marek.safar@seznam.cz>
2236 * expression.cs (StackAlloc.DoReSolve): Added test for
2237 negative parameter (CS0247).
2239 2004-06-15 Marek Safar <marek.safar@seznam.cz>
2242 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
2244 2004-06-15 Marek Safar <marek.safar@seznam.cz>
2247 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
2250 2004-06-14 Marek Safar <marek.safar@seznam.cz>
2252 Fix bug #58254 & cs1555.cs, cs1556.cs
2253 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
2255 2004-06-14 Marek Safar <marek.safar@seznam.cz>
2257 * cs-parser.jay: Added error CS1669 test for indexers.
2259 2004-06-18 Martin Baulig <martin@ximian.com>
2261 * generics.cs (GenericMethod.ctor): Don't take an Attributes
2262 argument. Fixes #60441.
2264 2004-06-16 Ben Maurer <bmaurer@ximian.com>
2265 * ecore.cs (MethodGroupExpr.Name): Revert Martin's patch.
2266 The name needs to have the actual name of the method in order
2267 for other tests (such as the one in OverloadResolve for Invoke
2268 on a delegate) to work. As well, it does not really help
2269 error reporting because the method group had multiple methods.
2270 * Makefile: Remove MCS_DEBUG, you can enable with the DEBUG_FLAGS.
2271 Make profiling work.
2273 2004-06-13 Martin Baulig <martin@ximian.com>
2275 * cs-parser.jay: Don't allow generic attributes.
2277 2004-06-13 Martin Baulig <martin@ximian.com>
2279 * class.cs (MemberBase.DoDefineBase): New protected method.
2280 (MemberBase.DoDefine): Compute the `flags' in the new
2281 DoDefineBase() which must be called first.
2282 (Method.Define): Call DoDefineBase() first so we have the flags
2283 when defining the generic method.
2285 * cs-parser.jay (interface_method_declaration): Support generic methods.
2287 2004-06-13 Martin Baulig <martin@ximian.com>
2289 * decl.cs (TypeName): Removed.
2290 (MemberName): Removed TypeName and MemberNow; now we just have
2293 * cs-parser.jay: Don't distinguish between type arguments and type
2294 parameters in the grammar and simplified the rules a bit. The
2295 reduce/reduce conflicts are now gone (except the one we inherited
2298 2004-06-11 Martin Baulig <martin@ximian.com>
2300 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
2301 call this twice: for params and varargs methods.
2303 2004-06-11 Marek Safar <marek.safar@seznam.cz>
2306 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
2308 2004-06-11 Marek Safar <marek.safar@seznam.cz>
2310 * attribute.cs (Attribute.GetValidTargets): Made public.
2313 (AbstractPropertyEventMethod): New class for better code sharing.
2314 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
2316 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
2318 2004-06-09 Martin Baulig <martin@ximian.com>
2320 * cs-parser.jay: Removed a reduce/reduce conflict.
2322 2004-06-03 Martin Baulig <martin@ximian.com>
2324 * generic.cs (ConstructedType.GetMemberAccess): Renamed to
2325 GetSimpleName() and return a SimpleName.
2327 * ecore.cs (SimpleName.Arguments): New public field.
2328 (SimpleName): Added overloaded ctor which takes an additional
2329 TypeArguments argument.
2330 (SimpleName.SimpleNameResolve): Added support for generic methods.
2331 (MethodGroupExpr.ResolveGeneric): New public method. The code was
2332 formerly in MemberAccess.DoResolve(), but we also need it in
2333 SimpleNameResolve().
2335 * expression.cs (MemberAccess.DoResolve): Use the new
2336 MethodGroupExpr.ResolveGeneric().
2338 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2340 * decl.cs: If possible, use lookuptypedirect here. We can only do
2341 this if there is no `.' after the namespace. Avoids using
2342 LookupType, which does lots of slow processing.
2343 (FindNestedType) New method, does what it says :-).
2344 * namespace.cs: use LookupTypeDirect.
2345 * rootcontext.cs: use membercache, if possible.
2346 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
2348 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2351 According to the spec,
2353 In a member access of the form E.I, if E is a single identifier,
2354 and if the meaning of E as a simple-name (§7.5.2) is a constant,
2355 field, property, localvariable, or parameter with the same type as
2356 the meaning of E as a type-name (§3.8), then both possible
2357 meanings of E are permitted.
2359 We did not check that E as a simple-name had the same type as E as
2362 This trivial check gives us 5-7% on bootstrap time.
2364 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2366 * expression.cs (Invocation.OverloadResolve): Avoid the
2367 use of hashtables and boxing here by allocating on demand.
2369 2004-05-30 Martin Baulig <martin@ximian.com>
2371 * rootcontext.cs (RootContext.LookupType): Don't cache things if
2372 we're doing a silent lookup. Don't try to lookup nested types in
2373 TypeManager.object_type (thanks to Ben Maurer).
2375 2004-05-30 Martin Baulig <martin@ximian.com>
2377 Committing a patch from Ben Maurer.
2379 * rootcontext.cs (RootContext.LookupType): Cache negative results.
2381 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2383 * convert.cs: add a trivial cache for overload operator resolution.
2385 2004-05-31 Marek Safar <marek.safar@seznam.cz>
2388 (AttributeTester.GetObsoleteAttribute): Returns instance of
2389 ObsoleteAttribute when type is obsolete.
2392 (TypeContainer.VerifyObsoleteAttribute): Override.
2393 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
2394 (MethodCode.VerifyObsoleteAttribute): Override.
2395 (MemberBase.VerifyObsoleteAttribute): Override.
2398 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
2399 and report proper error.
2402 (Delegate.VerifyObsoleteAttribute): Override.
2405 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
2406 and report proper error.
2407 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
2410 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
2414 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
2415 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
2416 Added test for ObsoleteAttribute.
2419 (Catch): Derived from Statement.
2421 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2423 * decl.cs: If possible, use lookuptypedirect here. We can only do
2424 this if there is no `.' after the namespace. Avoids using
2425 LookupType, which does lots of slow processing.
2426 (FindNestedType) New method, does what it says :-).
2427 * namespace.cs: use LookupTypeDirect.
2428 * rootcontext.cs: use membercache, if possible.
2429 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
2431 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2434 According to the spec,
2436 In a member access of the form E.I, if E is a single identifier,
2437 and if the meaning of E as a simple-name (§7.5.2) is a constant,
2438 field, property, localvariable, or parameter with the same type as
2439 the meaning of E as a type-name (§3.8), then both possible
2440 meanings of E are permitted.
2442 We did not check that E as a simple-name had the same type as E as
2445 This trivial check gives us 5-7% on bootstrap time.
2447 2004-05-30 Marek Safar <marek.safar@seznam.cz>
2449 Fixed bug #59071 & cs0160.cs
2450 * statement.cs (Try.Resolve): Check here whether order of catch
2451 clauses matches their dependencies.
2453 2004-05-30 Marek Safar <marek.safar@seznam.cz>
2456 * ecore.cs (SimpleName.SimpleNameResolve): Added test for
2459 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2461 * expression.cs (Invocation.OverloadResolve): Avoid the
2462 use of hashtables and boxing here by allocating on demand.
2464 2004-05-30 Martin Baulig <martin@ximian.com>
2466 * rootcontext.cs (RootContext.LookupType): Don't cache things if
2467 we're doing a silent lookup. Don't try to lookup nested types in
2468 TypeManager.object_type (thanks to Ben Maurer).
2470 2004-05-30 Martin Baulig <martin@ximian.com>
2472 Committing a patch from Ben Maurer.
2474 * rootcontext.cs (RootContext.LookupType): Cache negative results.
2476 2004-05-29 Martin Baulig <martin@ximian.com>
2478 * class.cs (IMethodData.ShouldIgnore): New method.
2480 * typemanager.cs (TypeManager.MethodFlags): Don't take a
2481 `Location' argument, we don't need it anywhere. Use
2482 `IMethodData.ShouldIgnore ()' instead of
2483 `MethodData.GetMethodFlags ()'.
2484 (TypeManager.AddMethod): Removed.
2485 (TypeManager.AddMethod2): Renamed to AddMethod.
2487 2004-05-29 Martin Baulig <martin@ximian.com>
2489 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
2491 * convert.cs (Convert.ImplicitReferenceConversion): If we're
2492 converting from a class type S to an interface type and we already
2493 have an object on the stack, don't box it again. Fixes #52578.
2495 2004-05-29 Martin Baulig <martin@ximian.com>
2497 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
2498 Added support for `params' parameters. Fixes #59267.
2500 2004-05-29 Martin Baulig <martin@ximian.com>
2502 * literal.cs (NullPointer): Provide a private .ctor which sets
2503 `type' to TypeManager.object_type. Fixes #59048.
2505 2004-05-29 Martin Baulig <martin@ximian.com>
2507 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
2508 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
2510 * ecore.cs (EventExpr.instance_expr): Make the field private.
2512 2004-05-26 Marek Safar <marek.safar@seznam.cz>
2514 Fixed bug #50080 & cs0214-2.cs
2515 * expression.cs (Cast.DoResolve): Check unsafe context here.
2517 * statement.cs (Resolve.DoResolve): Likewise.
2519 2004-05-26 Martin Baulig <martin@ximian.com>
2521 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
2523 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
2524 (RootContext.LookupType): Pass down the `silent' flag.
2526 2004-05-25 Martin Baulig <martin@ximian.com>
2529 (MethodGroupExpr.IdenticalTypeName): New public property.
2530 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
2531 expression actually refers to a type.
2533 2004-05-25 Martin Baulig <martin@ximian.com>
2535 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
2536 for #56176 and made it actually work.
2538 2004-05-25 Martin Baulig <martin@ximian.com>
2540 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
2541 (FieldExpr, PropertyExpr): Override and implement
2542 CacheTemporaries. Fixes #52279.
2544 2004-05-25 Miguel de Icaza <miguel@ximian.com>
2546 * location.cs: In the new compiler listing a file twice is a
2547 warning, not an error.
2549 2004-05-24 Martin Baulig <martin@ximian.com>
2551 * enum.cs (Enum.DefineType): For the `BaseType' to be a
2552 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
2554 2004-05-24 Martin Baulig <martin@ximian.com>
2556 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
2557 walking the `using' list. Fixes #53921.
2559 2004-05-24 Martin Baulig <martin@ximian.com>
2561 * const.cs (Const.LookupConstantValue): Added support for
2562 EmptyCast's; fixes #55251.
2564 2004-05-24 Martin Baulig <martin@ximian.com>
2566 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
2567 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
2568 which does the CS0135 check. The reason is that we first need to
2569 check whether the variable actually exists.
2571 2004-05-24 Martin Baulig <martin@ximian.com>
2573 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
2574 than RootContext.LookupType() to find the explicit interface
2577 2004-05-24 Raja R Harinath <rharinath@novell.com>
2579 * Makefile: Simplify. Use executable.make.
2580 * mcs.exe.sources: New file. List of sources of mcs.exe.
2582 2004-05-24 Anders Carlsson <andersca@gnome.org>
2586 Use the invariant culture when doing String.Compare for CLS case
2589 2004-05-23 Martin Baulig <martin@ximian.com>
2591 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
2592 don't have any dots. Fixes #52622, added cs0246-8.cs.
2594 * namespace.cs (NamespaceEntry.Lookup): Likewise.
2596 2004-05-23 Marek Safar <marek.safar@seznam.cz>
2598 * class.cs (MemberBase.Define): Reuse MemberType member for
2599 resolved type. Other methods can use it too.
2601 2004-05-23 Martin Baulig <martin@ximian.com>
2603 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
2604 the variable also exists in the current block (otherwise, we need
2605 to report a CS0103). Fixes #58670.
2607 2004-05-23 Martin Baulig <martin@ximian.com>
2609 * flowanalysis.cs (Reachability.Reachable): Compute this
2610 on-the-fly rather than storing it as a field.
2612 2004-05-23 Martin Baulig <martin@ximian.com>
2614 * flowanalysis.cs (Reachability.And): Manually compute the
2615 resulting `barrier' from the reachability.
2617 2004-05-23 Marek Safar <marek.safar@seznam.cz>
2620 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
2621 instance of ObsoleteAttribute when symbol is obsolete.
2624 (IMethodData): Extended interface for ObsoleteAttribute support.
2626 2004-05-22 Marek Safar <marek.safar@seznam.cz>
2628 * attribute.cs: Fix bug #55970
2630 2004-05-22 Marek Safar <marek.safar@seznam.cz>
2634 (GetObsoleteAttribute): New method. Creates the instance of
2636 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
2637 ObsoleteAttribute when member is obsolete.
2638 (AttributeTester.Report_ObsoleteMessage): Common method for
2639 Obsolete error/warning reporting.
2642 (TypeContainer.base_classs_type): New member for storing parent type.
2645 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
2646 for this MemberCore.
2648 2004-05-21 Marek Safar <marek.safar@seznam.cz>
2650 * attribute.cs, const.cs: Fix bug #58590
2652 2004-05-21 Martin Baulig <martin@ximian.com>
2654 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
2655 out parameters if the end of the method is unreachable. Fixes
2658 2004-05-21 Marek Safar <marek.safar@seznam.cz>
2660 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
2661 Hari was right, why extra method.
2663 2004-05-21 Marek Safar <marek.safar@seznam.cz>
2665 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
2667 2004-05-20 Martin Baulig <martin@ximian.com>
2669 * delegate.cs: Convert this file to Unix mode - like the original
2672 2004-05-20 Martin Baulig <martin@ximian.com>
2674 * attribute.cs: Convert this file to Unix mode - like the original
2677 2004-05-19 Marek Safar <marek.safar@seznam.cz>
2679 Fix bug #58688 (MCS does not report error when the same attribute
2682 * attribute.cs (Attribute.Emit): Distinction between null and default.
2684 2004-05-19 Raja R Harinath <rharinath@novell.com>
2686 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
2687 of a top-level attribute without an attribute target.
2688 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
2690 (Attribute.Conditional_GetConditionName),
2691 (Attribute.Obsolete_GetObsoleteMessage): Update.
2692 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
2693 part of ScanForIndexerName.
2694 (Attribute.CanIgnoreInvalidAttribute): New function.
2695 (Attribute.ScanForIndexerName): Move to ...
2696 (Attributes.ScanForIndexerName): ... here.
2697 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
2698 (Attributes.Search): New internal variant that can choose not to
2699 complain if types aren't resolved. The original signature now
2701 (Attributes.GetClsCompliantAttribute): Use internal variant, with
2702 complaints suppressed.
2703 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
2704 only if it not useful.
2705 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
2706 top-level for attributes that are shared between the assembly
2707 and a top-level class.
2708 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
2709 * class.cs: Update to reflect changes.
2710 (DefineIndexers): Fuse loops.
2711 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
2712 a couple more variants of attribute names.
2714 2004-05-18 Marek Safar <marek.safar@seznam.cz>
2716 Fix bug #52585 (Implemented explicit attribute declaration)
2719 (Attributable.ValidAttributeTargets): New abstract method. It gets
2720 list of valid attribute targets for explicit target declaration.
2721 (Attribute.Target): It holds target itself.
2722 (AttributeSection): Removed.
2723 (Attribute.CheckTargets): New method. It checks whether attribute
2724 target is valid for the current element.
2727 (EventProperty): New class. For events that are declared like
2728 property (with add and remove accessors).
2729 (EventField): New class. For events that are declared like field.
2732 * cs-parser.jay: Implemented explicit attribute target declaration.
2734 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
2735 Override ValidAttributeTargets.
2738 (ReturnParameter): Class for applying custom attributes on
2740 (ParameterAtribute): New class. Class for applying custom
2741 attributes on the parameter type.
2743 2004-05-17 Miguel de Icaza <miguel@ximian.com>
2745 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
2748 (Method): Allow UNSAFE here.
2750 * modifiers.cs: Support unsafe reporting.
2752 2004-05-17 Marek Safar <marek.safar@seznam.cz>
2754 * decl.cs: Fix bug #58478.
2756 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
2758 * statement.cs: When checking for unreachable code on an EmptyStatement,
2759 set the location. Fixes bug #58488.
2761 2004-05-13 Miguel de Icaza <miguel@ximian.com>
2763 * driver.cs: Add -pkg handling.
2765 From Gonzalo: UseShelLExecute=false
2767 2004-05-12 Marek Safar <marek.safar@seznam.cz>
2770 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
2772 (Attribute.IsClsCompliaceRequired): Moved to base for better
2774 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
2775 when attribute is AttributeUsageAttribute.
2776 (Attribute.GetValidTargets): Simplified.
2777 (Attribute.GetAttributeUsage): New method returns AttributeUsage
2778 attribute for this type.
2779 (Attribute.ApplyAttributes): Method renamed to Emit and make
2781 (GlobalAttributeSection): New class for special handling of global
2782 attributes (assembly, module).
2783 (AttributeSection.Emit): New method.
2785 * class.cs: Implemented Attributable abstract methods.
2786 (MethodCore.LabelParameters): Moved to Parameter class.
2787 (Accessor): Is back simple class.
2788 (PropertyMethod): Implemented Attributable abstract class.
2789 (DelegateMethod): Implemented Attributable abstract class.
2790 (Event): New constructor for disctintion between normal Event
2791 and Event with accessors.
2793 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
2795 * codegen.cs, const.cs, decl.cs, delegate.cs:
2796 (CommonAssemblyModulClass): Implemented Attributable abstract class
2799 * enum.cs: Implement IAttributeSupport interface.
2800 (EnumMember): New class for emum members. Implemented Attributable
2804 (ParameterBase): Is abstract.
2805 (ReturnParameter): New class for easier [return:] attribute handling.
2807 * typemanager.cs: Removed builder_to_attr.
2809 2004-05-11 Raja R Harinath <rharinath@novell.com>
2812 * attribute.cs (Attribute.GetPositionalValue): New function.
2813 * class.cs (TypeContainer.VerifyMembers): New function.
2814 (TypeContainer.Emit): Use it.
2815 (ClassOrStruct): New base class for Class and Struct.
2816 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
2817 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
2819 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
2820 then each non-static field should have a FieldOffset attribute.
2821 Otherwise, none of the fields should have a FieldOffset attribute.
2822 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
2823 and FieldOffset attributes.
2824 * typemanager.cs (TypeManager.struct_layout_attribute_type)
2825 (TypeManager.field_offset_attribute_type): New core types.
2826 (TypeManager.InitCoreTypes): Initialize them.
2828 2004-05-11 Michal Moskal <malekith@pld-linux.org>
2830 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
2831 Return correct type.
2834 2004-05-09 Miguel de Icaza <miguel@ximian.com>
2836 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
2837 be implicitly converted to ulong.
2839 * expression.cs: The logic for allowing operator &, | and ^ worked
2840 was wrong, it worked before because we did not report an error in
2841 an else branch. Fixes 57895.
2843 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
2844 allow volatile fields to be reference types.
2846 2004-05-07 Miguel de Icaza <miguel@ximian.com>
2848 * driver.cs: Add support for /debug-
2850 2004-05-07 Raja R Harinath <rharinath@novell.com>
2852 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
2853 Add a 'complain' parameter to silence errors.
2854 (Attribute.Resolve): Update to changes. Put in sanity check to catch
2855 silently overlooked type-resolutions.
2856 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
2858 (Attributes.Search): New function.
2859 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
2860 (Attributes.GetAttributeFullName): Remove hack.
2861 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
2862 Update to reflect changes.
2863 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
2864 Use Attributes.Search instead of nested loops.
2866 2004-05-07 Marek Safar <marek.safar@seznam.cz>
2869 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
2870 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
2871 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
2873 * report.cs: (Report.Warning): Renamed to Warning_T because of
2874 parameter collision.
2876 2004-05-05 Raja R Harinath <rharinath@novell.com>
2878 * expression.cs (MemberAccess.ResolveMemberAccess):
2879 Exit with non-zero status after Report.Error.
2880 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
2882 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
2884 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
2886 * support.cs: Don't hang when the file is empty.
2888 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
2890 * support.cs: In SeekableStreamReader, compute the preamble size of the
2891 underlying stream. Position changes should take into account that initial
2894 2004-05-03 Todd Berman <tberman@sevenl.net>
2896 * driver.cs: remove unused GetSysVersion function.
2898 2004-05-03 Todd Berman <tberman@sevenl.net>
2900 * driver.cs: Remove the hack from saturday, as well as the hack
2901 from jackson (LoadAssemblyFromGac), also adds the CWD to the
2902 link_paths to get that bit proper.
2904 2004-05-01 Todd Berman <tberman@sevenl.net>
2906 * driver.cs: Try a LoadFrom before a Load, this checks the current
2907 path. This is currently a bug in mono that is be fixed, however, this
2908 provides a workaround for now. This will be removed when the bug
2911 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
2913 * CryptoConvert.cs: Updated to latest version. Fix issue with
2914 incomplete key pairs (#57941).
2916 2004-05-01 Todd Berman <tberman@sevenl.net>
2918 * driver.cs: Remove '.' from path_chars, now System.* loads properly
2921 2004-04-30 Jackson Harper <jackson@ximian.com>
2923 * codegen.cs: Open keys readonly.
2925 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
2927 * typemanager.cs: don't report cyclic struct layout when a struct
2928 contains 2 or more fields of the same type. Failed for Pango.AttrShape
2929 which has 2 Pango.Rectangle fields.
2931 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
2933 * expression.cs: Handle IntPtr comparisons with IL code
2934 rather than a method call.
2936 2004-04-29 Martin Baulig <martin@ximian.com>
2938 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
2939 the list of PropertyInfo's in class hierarchy and find the
2940 accessor. Fixes #56013.
2942 2004-04-29 Martin Baulig <martin@ximian.com>
2944 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
2946 2004-04-29 Martin Baulig <martin@ximian.com>
2948 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
2950 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
2952 2004-04-29 Martin Baulig <martin@ximian.com>
2954 * class.cs (ConstructorInitializer.Resolve): Check whether the
2955 parent .ctor is accessible. Fixes #52146.
2957 2004-04-29 Martin Baulig <martin@ximian.com>
2959 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
2961 * statement.cs (Using.EmitLocalVariableDecls): Use
2962 TypeManager.idisposable_type, not typeof (IDisposable).
2963 (Foreach.EmitCollectionForeach): Added support for valuetypes.
2965 2004-04-29 Martin Baulig <martin@ximian.com>
2967 * class.cs (Event.Define): Don't emit the field and don't set
2968 RTSpecialName and SpecialName for events on interfaces. Fixes
2971 2004-04-29 Raja R Harinath <rharinath@novell.com>
2973 Refactor Attribute.ApplyAttributes.
2974 * attribute.cs (Attributable): New base class for objects that can
2975 have Attributes applied on them.
2976 (Attribute): Make AttributeUsage fields public.
2977 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
2978 (Attribute.IsInternalCall): New property.
2979 (Attribute.UsageAttr): Convert to a public read-only property.
2980 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
2981 (Attribute.ResolveType, Attribute.Resolve)
2982 (Attribute.ScanForIndexerName): Update to reflect changes.
2983 (Attribute.CheckAttributeTarget): Re-format.
2984 (Attribute.ApplyAttributes): Refactor, to various
2985 Attributable.ApplyAttributeBuilder methods.
2986 * decl.cs (MemberCore): Make Attributable.
2987 * class.cs (Accessor): Make Attributable.
2988 (MethodData.ApplyAttributes): Use proper attribute types, not
2990 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
2991 (TypeContainer.ApplyAttributeBuilder)
2992 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
2993 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
2994 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
2995 (Operator.ApplyAttributeBuilder): New factored-out methods.
2996 * const.cs (Const.ApplyAttributeBuilder): Likewise.
2997 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
2998 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
2999 * parameter.cs (ParameterBase): New Attributable base class
3000 that can also represent Return types.
3001 (Parameter): Update to the changes.
3003 2004-04-29 Jackson Harper <jackson@ximian.com>
3005 * driver.cs: Prefer the corlib system version when looking for
3006 assemblies in the GAC. This is still a hack, but its a better hack
3009 2004-04-29 Marek Safar <marek.safar@seznam.cz>
3011 * decl.cs, enum.cs: Improved error 3005 reporting.
3013 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
3014 (related_symbols): New private member for list of symbols
3015 related to reported error/warning.
3017 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
3019 2004-04-29 Martin Baulig <martin@ximian.com>
3021 * ecore.cs (Expression.Constantify): If we're an enum and
3022 TypeManager.TypeToCoreType() doesn't give us another type, use
3023 t.UnderlyingSystemType. Fixes #56178.
3025 2004-04-29 Martin Baulig <martin@ximian.com>
3027 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
3028 interfaces and for each interface, only add members directly
3029 declared in that interface. Fixes #53255.
3031 2004-04-28 Martin Baulig <martin@ximian.com>
3033 * expression.cs (ConditionalLogicalOperator): Use a temporary
3034 variable for `left' to avoid that we evaluate it more than once;
3037 2004-04-28 Martin Baulig <martin@ximian.com>
3039 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
3042 2004-04-28 Martin Baulig <martin@ximian.com>
3044 * statement.cs (LocalInfo.Resolve): Check whether the type is not
3047 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
3048 whether the type is not void (CS1547).
3050 2004-04-28 Martin Baulig <martin@ximian.com>
3052 * expression.cs (Unary.DoResolveLValue): Override this and report
3053 CS0131 for anything but Operator.Indirection.
3055 2004-04-28 Martin Baulig <martin@ximian.com>
3057 Committing a patch from Ben Maurer; see bug #50820.
3059 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
3062 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
3065 2004-04-28 Martin Baulig <martin@ximian.com>
3067 Committing a patch from Ben Maurer; see bug #50820.
3069 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
3072 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
3075 2004-04-28 Martin Baulig <martin@ximian.com>
3077 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
3078 (Block.AddLabel): Call DoLookupLabel() to only search in the
3081 2004-04-28 Martin Baulig <martin@ximian.com>
3083 * cfold.cs (ConstantFold.BinaryFold): Added special support for
3084 comparing StringConstants and NullLiterals in Equality and Inequality.
3086 2004-04-28 Jackson Harper <jackson@ximian.com>
3088 * driver.cs: Attempt to load referenced assemblies from the
3089 GAC. This is the quick and dirty version of this method that
3090 doesnt take into account versions and just takes the first
3091 canidate found. Will be good enough for now as we will not have more
3092 then one version installed into the GAC until I update this method.
3094 2004-04-28 Martin Baulig <martin@ximian.com>
3096 * typemanager.cs (TypeManager.CheckStructCycles): New public
3097 static method to check for cycles in the struct layout.
3099 * rootcontext.cs (RootContext.PopulateTypes): Call
3100 TypeManager.CheckStructCycles() for each TypeContainer.
3101 [Note: We only need to visit each type once.]
3103 2004-04-28 Martin Baulig <martin@ximian.com>
3105 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
3107 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
3108 success and added `out object value'. Use a `bool resolved' field
3109 to check whether we've already been called rather than
3110 `ConstantValue != null' since this breaks for NullLiterals.
3112 2004-04-28 Raja R Harinath <rharinath@novell.com>
3114 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
3115 setting of this flag, since the 'set' method may be non-public.
3117 2004-04-28 Raja R Harinath <rharinath@novell.com>
3119 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
3120 check on current_vector.Block.
3122 2004-04-27 Martin Baulig <martin@ximian.com>
3124 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
3125 a field initializer. Fixes #56459.
3127 2004-04-27 Martin Baulig <martin@ximian.com>
3129 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
3130 we're not attempting to use an indexer. Fixes #52154.
3132 2004-04-27 Martin Baulig <martin@ximian.com>
3134 * statement.cs (Return): Don't create a return label if we don't
3135 need it; reverts my change from January 20th. Thanks to Ben
3138 2004-04-27 Martin Baulig <martin@ximian.com>
3140 According to the spec, `goto' can only leave a nested scope, but
3143 * statement.cs (Block.LookupLabel): Only lookup in the current
3144 block, don't recurse into parent or child blocks.
3145 (Block.AddLabel): Check in parent and child blocks, report
3146 CS0140/CS0158 if we find a duplicate.
3147 (Block): Removed this indexer for label lookups.
3148 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
3149 this already does the error reporting for us.
3152 (FlowBranching.UsageVector.Block): New public variable; may be null.
3153 (FlowBranching.CreateSibling): Added `Block' argument.
3154 (FlowBranching.LookupLabel): New public virtual method. Lookup a
3155 label for the target of a `goto' and check whether we're not
3156 leaving a `finally'.
3158 2004-04-27 Martin Baulig <martin@ximian.com>
3160 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
3161 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
3164 2004-04-27 Martin Baulig <martin@ximian.com>
3166 * statement.cs (Block.AddLabel): Also check for implicit blocks
3167 and added a CS0158 check.
3169 2004-04-27 Martin Baulig <martin@ximian.com>
3171 * flowanalysis.cs (FlowBranchingLoop): New class.
3172 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
3173 UsageVector's instead of an ArrayList.
3174 (FlowBranching.Label): Likewise.
3175 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
3176 (FlowBranching.AddBreakVector): New method.
3178 2004-04-27 Miguel de Icaza <miguel@ximian.com>
3180 * attribute.cs: Small regression fix: only convert the type if we
3181 the type is different, fixes System.Drawing build.
3183 2004-04-27 Martin Baulig <martin@ximian.com>
3185 * attribute.cs (Attribute.Resolve): If we have a constant value
3186 for a named field or property, implicity convert it to the correct
3189 2004-04-27 Raja R Harinath <rharinath@novell.com>
3191 * statement.cs (Block.Block): Implicit blocks share
3192 'child_variable_names' fields with parent blocks.
3193 (Block.AddChildVariableNames): Remove.
3194 (Block.AddVariable): Mark variable as "used by a child block" in
3195 every surrounding block.
3196 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
3197 been used in a child block, complain about violation of "Invariant
3198 meaning in blocks" rule.
3199 * cs-parser.jay (declare_local_variables): Don't use
3200 AddChildVariableNames.
3201 (foreach_statement): Don't create an implicit block: 'foreach'
3204 2004-04-23 Miguel de Icaza <miguel@ximian.com>
3206 * convert.cs (ImplicitNumericConversion): 0 is also positive when
3207 converting from 0L to ulong. Fixes 57522.
3209 2004-04-22 Marek Safar <marek.safar@seznam.cz>
3211 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
3212 derived class hides via 'new' keyword field from base class (test-242.cs).
3213 TODO: Handle this in the more general way.
3215 * class.cs (CheckBase): Ditto.
3217 2004-04-22 Marek Safar <marek.safar@seznam.cz>
3219 * decl.cs (caching_flags): New member for storing cached values
3221 (MemberCore.Flags): New enum where bit flags for caching_flags
3223 (MemberCore.cls_compliance): Moved to caching_flags.
3224 (DeclSpace.Created): Moved to caching_flags.
3226 * class.cs: Use caching_flags instead of DeclSpace.Created
3228 2004-04-21 Miguel de Icaza <miguel@ximian.com>
3230 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
3231 if we are only a derived class, not a nested class.
3233 * typemanager.cs: Same as above, but do this at the MemberLookup
3234 level (used by field and methods, properties are handled in
3235 PropertyExpr). Allow for the qualified access if we are a nested
3238 2004-04-21 Marek Safar <marek.safar@seznam.cz>
3240 * class.cs: Refactoring.
3241 (IMethodData): New inteface; Holds links to parent members
3242 to avoid member duplication (reduced memory allocation).
3243 (Method): Implemented IMethodData interface.
3244 (PropertyBase): New inner classes for get/set methods.
3245 (PropertyBase.PropertyMethod): Implemented IMethodData interface
3246 (Event): New inner classes for add/remove methods.
3247 (Event.DelegateMethod): Implemented IMethodData interface.
3249 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
3250 EmitContext (related to class.cs refactoring).
3252 2004-04-21 Raja R Harinath <rharinath@novell.com>
3254 * delegate.cs (Delegate.VerifyApplicability): If the number of
3255 arguments are the same as the number of parameters, first try to
3256 verify applicability ignoring any 'params' modifier on the last
3260 2004-04-08 Martin Baulig <martin@ximian.com>
3262 Merged latest changes into gmcs. Please keep this comment in
3263 here, it makes it easier for me to see what changed in MCS since
3264 the last time I merged.
3266 2004-04-16 Raja R Harinath <rharinath@novell.com>
3268 * class.cs (TypeContainer.AddIndexer): Use
3269 'ExplicitInterfaceName' to determine if interface name was
3270 explicitly specified. 'InterfaceType' is not initialized at this time.
3271 (TypeContainer.DefineIndexers): Remove use of temporary list. The
3272 Indexers array is already in the required order. Initialize
3273 'IndexerName' only if there are normal indexers.
3274 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
3275 (TypeContainer.Emit): Emit DefaultMember attribute only if
3276 IndexerName is initialized.
3279 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
3281 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
3284 2004-04-15 Raja R Harinath <rharinath@novell.com>
3286 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
3290 * attribute.cs (Attribute.Resolve): Check for duplicate named
3294 2004-04-15 Miguel de Icaza <miguel@ximian.com>
3296 * iterators.cs (MarkYield): track whether we are in an exception,
3297 and generate code accordingly. Use a temporary value to store the
3298 result for our state.
3300 I had ignored a bit the interaction of try/catch with iterators
3301 since their behavior was not entirely obvious, but now it is
3302 possible to verify that our behavior is the same as MS .NET 2.0
3306 2004-04-14 Miguel de Icaza <miguel@ximian.com>
3308 * iterators.cs: Avoid creating temporaries if there is no work to
3311 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
3312 Enumerations, use TypeManager.EnumToUnderlying and call
3315 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
3318 (This.Emit): Use EmitContext.EmitThis to emit our
3321 (This.EmitAssign): Ditto.
3323 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
3324 codepaths, we will move all the functionality into
3327 (FieldExpr.EmitAssign): Ditto.
3329 This fixes several hidden bugs that I uncovered while doing a code
3330 review of this today.
3332 * codegen.cs (EmitThis): reworked so the semantics are more clear
3333 and also support value types "this" instances.
3335 * iterators.cs: Changed so that for iterators in value types, we
3336 do not pass the value type as a parameter.
3338 Initialization of the enumerator helpers is now done in the caller
3339 instead of passing the parameters to the constructors and having
3340 the constructor set the fields.
3342 The fields have now `assembly' visibility instead of private.
3344 2004-04-11 Miguel de Icaza <miguel@ximian.com>
3346 * expression.cs (Argument.Resolve): Check if fields passed as ref
3347 or out are contained in a MarshalByRefObject.
3349 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
3350 another compiler type.
3352 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
3354 * class.cs (Indexer.Define): use the new name checking method.
3355 Also, return false on an error.
3356 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
3357 (is_identifier_[start/part]_character): make static.
3359 2004-04-10 Miguel de Icaza <miguel@ximian.com>
3361 * expression.cs (Binary.ResolveOperator): Do no append strings
3362 twice: since we can be invoked more than once (array evaluation)
3363 on the same concatenation, take care of this here. Based on a fix
3364 from Ben (bug #56454)
3366 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
3368 * codegen.cs: Fix another case where CS1548 must be reported (when
3369 delay-sign isn't specified and no private is available #56564). Fix
3370 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
3371 error when MCS is used on the MS runtime and we need to delay-sign
3372 (which seems unsupported by AssemblyBuilder - see #56621).
3374 2004-04-08 Marek Safar <marek.safar@seznam.cz>
3376 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
3377 (TypeManager.ComputeNamespaces): Faster implementation for
3380 * compiler.csproj: Updated AssemblyName to mcs.
3382 2004-05-11 Jackson Harper <jackson@ximian.com>
3384 * Makefile: Preserve MONO_PATH
3386 2004-05-11 Jackson Harper <jackson@ximian.com>
3388 * Makefile: Use mono and mcs to build gmcs
3390 2004-05-03 Miguel de Icaza <miguel@ximian.com>
3392 * codegen.cs: Add patch from Robert Shade
3393 <rshade@dvsconsulting.com>, use FileAccess.Read on the keyfile, to
3396 2004-05-02 Sebastien Pouliot <sebastien@ximian.com>
3398 * CryptoConvert.cs: Updated to latest version. Fix issue with
3399 incomplete key pairs (#57941).
3401 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
3403 * codegen.cs: Fix another case where CS1548 must be reported (when
3404 delay-sign isn't specified and no private is available #56564). Fix
3405 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
3406 error when MCS is used on the MS runtime and we need to delay-sign
3407 (which seems unsupported by AssemblyBuilder - see #56621).
3409 2004-04-29 Jackson Harper <jackson@ximian.com>
3411 * Makefile: Set MONO_PATH to use the bootstrap corlib
3412 * driver.cs: Check the GAC for referenced assemblies.
3414 2004-04-29 Martin Baulig <martin@ximian.com>
3416 * Makefile (gmcs.exe): Set MONO_PATH to use `../class/lib/net_2_0'.
3418 2004-04-07 Martin Baulig <martin@ximian.com>
3420 * expression.cs (Binary.ResolveOperator): Added special case for
3421 Equality/Inequality between a type parameter and a null literal.
3423 2004-04-07 Martin Baulig <martin@ximian.com>
3425 * convert.cs: Check null literal -> type parameter conversions.
3427 2004-04-07 Martin Baulig <martin@ximian.com>
3429 * generic.cs (ConstructedType.CheckConstraints): Enforce the
3430 `class' and `struct' constraints.
3432 2004-04-07 Martin Baulig <martin@ximian.com>
3434 * generic.cs (SpecialConstraint): New public enum.
3435 (Constraints.Resolve): Added support for the `class' and `struct'
3438 * cs-parser.jay (type_parameter_constraint): Added support for the
3439 `class' and `struct' constraints.
3441 2004-04-07 Martin Baulig <martin@ximian.com>
3443 * support.cs (GenericConstraints): Replaced `Types' by
3444 `ClassConstraint' and `InterfaceConstraints'; added
3445 `HasClassConstraint'.
3447 2004-04-07 Martin Baulig <martin@ximian.com>
3450 (Constraints.InterfaceConstraints): New public property.
3451 (Constraints.Types): Make this property public
3452 (TypeParameter): Implement IMemberContainer.
3453 (TypeParameter.Define): Take a `GenericTypeParameterBuilder'
3454 instead of a TypeBuilder/MethodBuilder; pass the interface
3455 constraints to TypeManager.AddTypeParameter().
3456 (TypeParameter.DefineType): Just take an EmitContext and no
3457 TypeBuilder/MethodBuilder. Use the new public API.
3459 * typemanager.cs (TypeManager.AddTypeParameter): Added
3460 `TypeExpr[]' argument; add the interfaces to the
3461 `builder_to_ifaces' hash.
3462 (TypeManager.LookupMemberContainer): For
3463 GenericTypeParameterBuilders, get the TypeParameter from the
3464 `builder_to_type_param'.
3465 (TypeManager.FindMembers): For GenericTypeParameterBuilders, get
3466 the TypeParameter and call FindMembers on it.
3468 2004-04-07 Martin Baulig <martin@ximian.com>
3471 (MethodCore.GenericMethod): Moved this field here from Method.
3472 (MethodCore.IsDuplicateImplementation): Take the number of type
3473 parameters into account if we're a generic method.
3475 * expression.cs (Invocation.InferTypeArguments): Don't return true
3476 if `arguments' is null; we still need to check whether we actually
3477 don't need to infer anything in this case.
3478 (MemberAccess): Merged the functionality from GenericMemberAccess
3481 * generic.cs (GenericMemberAccess): Removed.
3483 2004-04-05 Martin Baulig <martin@ximian.com>
3485 * decl.cs (MemberCore): For generic classes, interfaces and
3486 structs, `Name' now includes the number of type parameters
3488 (DeclSpace.FindType): Removed the `num_type_args' argument; we now
3489 encode the number of type arguments in the type name.
3491 * expression.cs (Expression.MemberLookup): Removed the
3492 `num_type_args' argument; we now encode the number of type
3493 arguments in the type name.
3495 * ecore.cs (SimpleName): Encode the number of type arguments in
3496 the type name itself.
3498 * generic.cs (ConstructedType): Likewise.
3500 * tree.cs (Tree.RecordDecl): Take a `string' instead of a
3501 `MemberName'; we now include the number of type parameters in the
3504 * typemanager.cs (TypeManager.CheckGeneric): Removed.
3505 (TypeManager.MemberLookup): Removed the
3506 `num_type_args' argument; we now encode the number of type
3507 arguments in the type name.
3509 2004-04-03 Martin Baulig <martin@ximian.com>
3511 * decl.cs (MemberCore.ctor): Take a MemberName instead of a sting.
3512 (MemberCore.MemberName): Moved here from MemberBase.
3513 (DeclSpace.SetParameterInfo): Just take the constraints as an
3514 ArrayList; we already have the type parameters in our
3515 `MemberName'; also do the CS0080 reporting here.
3517 * cs-parser.jay (struct_declaration): Use `member_name' instead of
3518 `IDENTIFIER opt_type_parameter_list'; when constructing our
3519 `MemberName', it'll already include our type parameters.
3520 (class_declaration, interface_declaration): Likewise.
3521 (delegate_declaration): Likewise.
3522 (MakeName): Take a MemberName and return a MemberName.
3523 The following two changes are required to avoid shift/reduce conflicts:
3524 (member_name): Don't include a TypeName anymore; ie. this is now
3525 just 'IDENTIFIER opt_type_parameter_list'.
3526 (property_declaration, event_declaration): Use a
3527 `namespace_or_type_name' instead of a `member_name'.
3529 2004-04-03 Martin Baulig <martin@ximian.com>
3531 * decl.cs (MemberName): Renamed to `TypeName' and created a new
3533 (TypeName): Formerly known as MemberName.
3535 * namespace.cs (NamespaceEntry.UsingAlias): Take a `TypeName'
3536 instead of a `MemberName'.
3538 * cs-parser.jay (namespace_or_type_name): Create a TypeName.
3539 (member_name): New rule; create a MemberName.
3541 2004-04-02 Martin Baulig <martin@ximian.com>
3543 * namespace.cs (NamespaceEntry.VerifyUsing): Added error checking
3544 (CS0305 and CS0308).
3546 2004-04-02 Martin Baulig <martin@ximian.com>
3548 * generic.cs (GenericMemberAccess.ResolveAsTypeStep): Added
3549 support for nested types.
3551 2004-04-02 Martin Baulig <martin@ximian.com>
3553 * ecore.cs (IAlias): New public interface.
3554 (TypeExpr, TypeExpression): Implement IAlias.
3555 (TypeAliasExpression): New public class.
3557 * namespace.cs (Namespace): Implement IAlias.
3558 (Namespace.Lookup): Return an IAlias instead on an object.
3559 (Namespace.DefineName): Take an IAlias instead of an object.
3560 (NamespaceEntry.AliasEntry.Resolve): Return an IAlias instead of
3562 (NamespaceEntry.UsingAlias): Take a Membername instead of an
3564 (NamespaceEntry.LookupAlias): Return an IAlias instead on an
3566 (NamespaceEntry.Lookup): Likewise.
3568 * rootcontext.cs (RootContext.LookupType): Return a TypeExpr
3571 * decl.cs (DeclSpace): Implement IAlias.
3572 (DeclSpace.LookupAlias): Return an IAlias instead of a string.
3574 * generic.cs (ConstructedType): Improved error checking.
3576 2004-04-02 Martin Baulig <martin@ximian.com>
3578 * convert.cs: Added type parameter conversions.
3581 (UnboxCast.Emit): Emit an `unbox.any' for type params.
3582 (ClassCast.Emit): If the source type is a type parameter, box it.
3583 If the target type is a type parameter, emit an `unbox.any'
3584 instead of a `classcast'.1
3586 2004-04-01 Martin Baulig <martin@ximian.com>
3588 * cs-tokenizer.cs (parse_less_than): Allow Token.DOT.
3590 2004-04-01 Martin Baulig <martin@ximian.com>
3592 * generic.cs (ConstructedType.CheckConstraints): Use
3593 Convert.ImplicitStandardConversionExists(); user-defined implicit
3594 conversions are not allowed according to the spec.
3596 2004-03-30 Martin Baulig <martin@ximian.com>
3598 * expression.cs (New): Added support for type parameters.
3601 (TypeManager.activator_type): New public static field.
3602 (TypeManager.activator_create_instance): Likewise.
3604 2004-03-30 Martin Baulig <martin@ximian.com>
3606 * typemanager.cs (TypeManager.HasConstructorConstraint): New
3609 2004-03-30 Martin Baulig <martin@ximian.com>
3611 * generic.cs (ConstructedType.CheckConstraints): Actually follow
3612 the spec here: the argument type must be convertible to the
3615 2004-03-30 Martin Baulig <martin@ximian.com>
3618 (TypeParameter.Define, TypeParameter.DefineMethod): Call
3619 TypeManager.AddTypeParameter().
3620 (ConstructedType.CheckConstraints): Re-enable this and actually
3621 check whether we have a constructor constraint.
3624 (TypeManager.builder_to_type_param): New static field.
3625 (TypeManager.AddTypeParameter): New static method.
3626 (TypeManager.LookupTypeParameter): New public method.
3628 2004-03-30 Martin Baulig <martin@ximian.com>
3630 * generic.cs (TypeParameter.DefineType): Return a boolean and use
3631 the new API to actually define the constructor constraint.
3634 (TypeManager.new_constraint_attr_type): New static field.
3635 (TypeManager.InitCoreTypes): Initialize it.
3637 2004-03-30 Martin Baulig <martin@ximian.com>
3639 * generic.cs (Constraints): Completed error checking, use correct
3642 2004-03-29 Martin Baulig <martin@ximian.com>
3644 * delegate.cs (Delegate.VerifyMethod): Infer type arguments.
3646 * expression.cs (Invocation.InferTypeArguments): Added overloaded
3647 public version which takes a `ParameterData pd' instead of an
3650 2004-03-29 Martin Baulig <martin@ximian.com>
3652 * typemanager.cs (TypeManager.IsGenericMethod): Take a MethodBase,
3655 2004-03-29 Martin Baulig <martin@ximian.com>
3657 * expression.cs (Argument.ResolveMethodGroup): If we're a
3658 ConstructedType, call GetMemberAccess() on it.
3660 2004-03-29 Martin Baulig <martin@ximian.com>
3662 * class.cs (MethodBase.CheckGenericOverride): New abstract method.
3663 (MethodCore.CheckGenericOverride): When overriding a generic
3664 method, check whether the constraints match.
3666 * support.cs (GenericConstraints): New public interface.
3667 (ParameterData.GenericConstraints): New public method.
3669 * parameter.cs (Parameter.Resolve): Check whether we're a generic
3670 method parameter and compute our constraints if appropriate.
3671 (Parameter.GenericConstraints): New public property.
3673 * generic.cs (Constraints): Implement GenericConstraints.
3675 2004-03-29 Martin Baulig <martin@ximian.com>
3677 * decl.cs (MemberCache.FindMemberToOverride): Use
3678 `paramTypes [j].Equals (cmpAttrs [j])' instead of `=='.
3680 2004-03-29 Martin Baulig <martin@ximian.com>
3682 * generic.cs (GenericMethod.Define): Resolve our type parameters.
3684 2004-03-29 Martin Baulig <martin@ximian.com>
3686 * cs-parser.jay: Report CS0080 instead of -200 ("Constraints are
3687 not allowed on non-generic declarations").
3689 2004-03-29 Martin Baulig <martin@ximian.com>
3691 * expression.cs (Invocation.InferTypeArguments): Added overloaded
3692 public version of this method.
3694 * class.cs (MethodCore.IsDuplicateImplementation): Use
3695 Invocation.InferTypeArguments() to check this.
3697 2004-03-29 Martin Baulig <martin@ximian.com>
3699 * convert.cs: Use TypeManager.IsDelegateType() instead of
3700 comparing types correctly.
3702 2004-03-29 Martin Baulig <martin@ximian.com>
3704 * convert.cs: Use TypeManager.IsSubclassOf() instead of comparing
3705 types directly to make it work for generic instances.
3707 * typemanager.cs (TypeManager.IsSubclassOf): New static method.
3709 2004-03-29 Martin Baulig <martin@ximian.com>
3711 * typemanager.cs (TypeManager.MayBecomeEqualGenericTypes): Added
3714 2004-03-24 Martin Baulig <martin@ximian.com>
3716 * decl.cs (DeclSpace.FindType): Also use
3717 TypeManager.CheckGeneric() for types from the using clauses.
3719 2004-03-23 Martin Baulig <martin@ximian.com>
3721 * expression.cs (Invocation.OverloadResolve): Added `bool
3722 may_fail' argument and use it instead of the Location.IsNull() hack.
3724 2004-03-23 Martin Baulig <martin@ximian.com>
3726 * expression.cs (Invocation.InferType): Use correct type inference
3729 2004-03-23 Martin Baulig <martin@ximian.com>
3731 * ecore.cs (MethodGroupExpr.Name): Use
3732 TypeManager.CSharpSignature() instead of just the name.
3734 * expression.cs (Invocation.OverloadResolve): Provide better error
3736 (Invocation.DoResolve): OverloadResolve() never returns null
3737 without reporting an error, so removed the error -6 reporting here.
3739 2004-03-23 Martin Baulig <martin@ximian.com>
3741 * typemanager.cs (TypeManager.GetMethodFlags): Fixed the FIXME for
3744 * cs-parser.jay (delegate_declaration): Support generic delegates.
3746 * delegate.cs: Support generic delegates.
3748 2004-03-22 Martin Baulig <martin@ximian.com>
3750 * expression.cs (Invocation.InferParamsTypeArguments): New static
3751 method; does type inference for params arguments.
3753 2004-03-21 Martin Baulig <martin@ximian.com>
3755 * typemanager.cs (TypeManager.IsGenericMethod): New public static
3756 method; checks whether a method is a generic method.
3758 * expression.cs (Invocation.InferTypeArguments): New static method;
3759 infer type arguments for generic method invocation.
3761 * ecore.cs (MethodGroupExpr.HasTypeArguments): New public
3762 property; we set this to true if we're resolving a generic method
3763 invocation and the user specified type arguments, ie. we're not
3764 doing type inference.
3766 2004-03-20 Martin Baulig <martin@ximian.com>
3768 * class.cs (MethodData.DeclaringType): New public property.
3769 (MethodData.Define): Set DeclaringType here.
3770 (Operator.Define): Use OperatorMethod.MethodData.DeclaringType
3771 instead of OperatorMethodBuilder.DeclaringType.
3773 2004-03-20 Martin Baulig <martin@ximian.com>
3775 * cs-tokenizer.cs (xtoken): Return a special
3776 Token.DEFAULT_OPEN_PARENS for "`default' followed by open parens".
3778 * cs-parser.jay (default_value_expression): Switch to the new
3781 2004-03-19 Martin Baulig <martin@ximian.com>
3783 * decl.cs (MemberName): New class. We use this to "construct"
3784 namespace_or_type_name's.
3786 * generics.cs (TypeArguments.GetDeclarations): New public method;
3787 returns the type arguments as a string[] and reports a CS0081 if
3788 one of them is not an identifier.
3790 * class.cs (MemberBase): The .ctor now takes the name as a
3791 MemberName instead of a string.
3792 (MemberBase.ExplicitInterfaceName): Changed type from string to
3794 (MemberBase.DoDefine): If we're an explicit implementation, the
3795 InterfaceType may be a generic instance.
3797 * cs-parser.jay (namespace_or_type_name): Return a MemberName.
3798 (namespace_name): Call MemberName.GetName () to transform the
3799 MemberName into a string and ensure we don't have any type
3801 (type_name): Call MemberName.GetTypeExpression() to transfrom the
3802 MemberName into an expression.
3803 (method_header): Use namespace_or_type_name instead of member_name.
3805 2004-04-07 Miguel de Icaza <miguel@ximian.com>
3807 * rootcontext.cs: Add new types to the boot resolution.
3809 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
3810 MulticastDelegate is not allowed.
3812 * typemanager.cs: Add new types to lookup: System.TypedReference
3815 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
3816 check for TypedReference or ArgIterator, they are not allowed.
3818 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
3819 makes us properly catch 1510 in some conditions (see bug 56016 for
3822 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
3824 * CryptoConvert.cs: update from corlib version
3827 2004-04-05 Miguel de Icaza <miguel@ximian.com>
3829 * class.cs (Indexer.Define): Check indexername declaration
3831 2004-04-05 Marek Safar <marek.safar@seznam.cz>
3833 * attribute.cs (IsClsCompliant): Fixed problem with handling
3834 all three states (compliant, not-compliant, undetected).
3836 2004-03-30 Marek Safar <marek.safar@seznam.cz>
3838 * attribute.cs (Attribute): Location is now public.
3839 (Resolve): Store resolved arguments (pos_values) in attribute class.
3840 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
3841 (GetClsCompliantAttributeValue): New method that gets
3842 CLSCompliantAttribute value.
3843 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
3844 if exists else null.
3845 (AttributeTester): New class for CLS-Compliant verification routines.
3847 * class.cs (Emit): Add CLS-Compliant verification.
3848 (Method.GetSignatureForError): Implemented.
3849 (Constructor.GetSignatureForError): Implemented
3850 (Constructor.HasCompliantArgs): Returns if constructor has
3851 CLS-Compliant arguments.
3852 (Constructor.Emit): Override.
3853 (Construcor.IsIdentifierClsCompliant): New method; For constructors
3854 is needed to test only parameters.
3855 (FieldBase.GetSignatureForError): Implemented.
3856 (TypeContainer): New member for storing base interfaces.
3857 (TypeContainer.FindMembers): Search in base interfaces too.
3859 * codegen.cs (GetClsComplianceAttribute): New method that gets
3860 assembly or module CLSCompliantAttribute value.
3861 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
3863 (ModuleClass.Emit): Add error 3012 test.
3865 * const.cs (Emit): Override and call base for CLS-Compliant tests.
3867 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
3868 state for all decl types.
3869 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
3870 if CLS-Compliant tests are required.
3871 (IsClsCompliaceRequired): New method. Analyze whether code
3872 must be CLS-Compliant.
3873 (IsExposedFromAssembly): New method. Returns true when MemberCore
3874 is exposed from assembly.
3875 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
3876 value or gets cached value.
3877 (HasClsCompliantAttribute): New method. Returns true if MemberCore
3878 is explicitly marked with CLSCompliantAttribute.
3879 (IsIdentifierClsCompliant): New abstract method. This method is
3880 used to testing error 3005.
3881 (IsIdentifierAndParamClsCompliant): New method. Common helper method
3882 for identifier and parameters CLS-Compliant testing.
3883 (VerifyClsCompliance): New method. The main virtual method for
3884 CLS-Compliant verifications.
3885 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
3886 null. I don't know why is null (too many public members !).
3887 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
3888 and get value of first CLSCompliantAttribute that found.
3890 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
3891 (VerifyClsCompliance): Override and add extra tests.
3893 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
3894 clscheck- disable CLS-Compliant verification event if assembly is has
3895 CLSCompliantAttribute(true).
3897 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
3898 ApllyAttribute is now called in emit section as in the other cases.
3899 Possible future Emit integration.
3900 (IsIdentifierClsCompliant): New override.
3901 (VerifyClsCompliance): New override.
3902 (GetEnumeratorName): Returns full enum name.
3904 * parameter.cs (GetSignatureForError): Implemented.
3906 * report.cs (WarningData): New struct for Warning message information.
3907 (LocationOfPreviousError): New method.
3908 (Warning): New method. Reports warning based on the warning table.
3909 (Error_T): New method. Reports error based on the error table.
3911 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
3912 verifications are done here.
3914 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
3916 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
3917 CLSCompliantAttribute.
3918 (all_imported_types): New member holds all imported types from other
3920 (LoadAllImportedTypes): New method fills static table with exported types
3921 from all referenced assemblies.
3922 (Modules): New property returns all assembly modules.
3924 2004-03-30 Miguel de Icaza <miguel@ximian.com>
3926 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
3927 throwing a parser error.
3929 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
3930 which removes the hardcoded get_/set_ prefixes for properties, as
3931 IL allows for the properties to be named something else.
3935 * expression.cs: Do not override operand before we know if it is
3938 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
3940 * typemanager.cs: support for pinned variables.
3942 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
3944 * decl.cs, typemanager.cs: Avoid using an arraylist
3945 as a buffer if there is only one result set.
3947 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
3949 * expression.cs: Make sure you cant call a static method
3950 with an instance expression, bug #56174.
3952 2004-03-29 Miguel de Icaza <miguel@ximian.com>
3954 * class.cs (IsDuplicateImplementation): Improve error reporting to
3955 flag 663 (method only differs in parameter modifier).
3957 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
3958 in preprocessor directives.
3960 * location.cs (LookupFile): Allow for the empty path.
3962 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
3963 better approach for some of that patch, but its failing with the
3964 CharSet enumeration. For now try/catch will do.
3966 * typemanager.cs: Do not crash if a struct does not have fields.
3969 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
3971 * expression.cs: cs0213, cant fix a fixed expression.
3974 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
3976 * cs-parser.jay: detect invalid embeded statements gracefully.
3979 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
3981 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
3984 the invocation type may not be a subclass of the tye of the item/
3985 The type of the item must be a subclass of the invocation item.
3990 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
3992 * attribute.cs: Added methods to get a string and a bool from an
3993 attribute. Required to information from AssemblyKeyFileAttribute,
3994 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
3995 * codegen.cs: Modified AssemblyName creation to include support for
3996 strongnames. Catch additional exceptions to report them as CS1548.
3997 * compiler.csproj: Updated include CryptoConvert.cs.
3998 * compiler.csproj.user: Removed file - user specific configuration.
3999 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
4000 Mono.Security assembly. The original class is maintained and tested in
4001 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
4002 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
4003 like CSC 8.0 (C# v2) supports.
4004 * Makefile: Added CryptoConvert.cs to mcs sources.
4005 * rootcontext.cs: Added new options for strongnames.
4007 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
4009 * driver.cs: For --expect-error, report error code `2'
4010 if the program compiled with no errors, error code `1' if
4011 it compiled with an error other than the one expected.
4013 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
4015 * compiler.csproj: Updated for Visual Studio .NET 2003.
4016 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
4017 * compiler.sln: Updated for Visual Studio .NET 2003.
4019 2004-03-24 Ravi Pratap M <ravi@ximian.com>
4021 * expression.cs: Fix bug #47234. We basically need to apply the
4022 rule that we prefer the conversion of null to a reference type
4023 when faced with a conversion to 'object' (csc behaviour).
4025 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
4027 * statement.cs: Shorter form for foreach, eliminates
4028 a local variable. r=Martin.
4030 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
4032 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
4033 checks if we can use brtrue/brfalse to test for 0.
4034 * expression.cs: use the above in the test for using brtrue/brfalse.
4037 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
4039 * expression.cs: Rewrite string concat stuff. Benefits:
4041 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
4042 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
4043 rather than a concat chain.
4045 * typemanager.cs: Add lookups for more concat overloads.
4047 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
4049 * expression.cs: Emit shorter il code for array init.
4066 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
4068 * statement.cs: Before, two switch blocks would be merged if the
4069 total size of the blocks (end_item - begin_item + 1) was less than
4070 two times the combined sizes of the blocks.
4072 Now, it will only merge if after the merge at least half of the
4077 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
4079 * class.cs : csc build fix for GetMethods(). See bug #52503.
4081 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
4083 * expression.cs: Make sure fp comparisons work with NaN.
4084 This fixes bug #54303. Mig approved this patch a long
4085 time ago, but we were not able to test b/c the runtime
4088 2004-03-19 Miguel de Icaza <miguel@ximian.com>
4090 * ecore.cs (TypExpr.GetHashCode): implement this overload.
4092 2004-03-19 Martin Baulig <martin@ximian.com>
4094 * class.cs (MemberCore.IsDuplicateImplementation): Check whether
4095 two overloads may unify for some type parameter substitutions and
4096 report a CS0408 if appropriate.
4098 2004-03-19 Martin Baulig <martin@ximian.com>
4100 * class.cs (MemberCore.IsDuplicateImplementation): Report the
4101 error here and not in our caller.
4103 2004-03-19 Martin Baulig <martin@ximian.com>
4105 * interface.cs: Completely killed this file.
4106 (Interface): We're now a TypeContainer and live in class.cs.
4108 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
4109 argument; we're now also called for interfaces.
4110 (TypeContainer.DefineMembers): Allow this method being called
4112 (TypeContainer.GetMethods): New public method; formerly known as
4113 Interface.GetMethod(). This is used by PendingImplementation.
4114 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
4115 it's now private and non-static.
4116 (Interface): Moved this here; it's now implemented similar to
4118 (Method, Property, Event, Indexer): Added `bool is_interface'
4119 argument to their .ctor's.
4120 (MemberBase.IsInterface): New public field.
4122 * cs-parser.jay: Create normal Method, Property, Event, Indexer
4123 instances instead of InterfaceMethod, InterfaceProperty, etc.
4124 (opt_interface_base): Removed; we now use `opt_class_base' instead.
4125 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
4127 2004-03-19 Martin Baulig <martin@ximian.com>
4129 * class.cs (MethodCore.IsDuplicateImplementation): New private
4130 method which does the CS0111 checking.
4131 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
4132 Use IsDuplicateImplementation().
4134 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
4136 * decl.cs (FindMemberToOverride): New method to find the correct
4137 method or property to override in the base class.
4139 - Make Method/Property use the above method to find the
4140 version in the base class.
4141 - Remove the InheritableMemberSignatureCompare as it is now
4144 This patch makes large code bases much faster to compile, as it is
4145 O(n) rather than O(n^2) to do this validation.
4147 Also, it fixes bug 52458 which is that nested classes are not
4148 taken into account when finding the base class member.
4150 Reviewed/Approved by Martin.
4152 2004-03-17 Martin Baulig <martin@ximian.com>
4154 * expression.cs (MemberAccess.DoResolve): Take the parent's number
4155 of type arguments into account; use the `real_num_type_args'
4156 approach like in DoResolveAsTypeStep().
4158 * generic.cs (GenericMemberAccess.DoResolve): Make this work for
4161 2004-03-17 Marek Safar <marek.safar@seznam.cz>
4163 * interface.cs: In all interface classes removed redundant
4164 member initialization.
4166 2004-03-16 Martin Baulig <martin@ximian.com>
4168 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
4170 2004-03-15 Miguel de Icaza <miguel@ximian.com>
4172 * decl.cs (DefineTypeAndParents): New helper method to define a
4173 type's containers before the type itself is defined; This is a
4174 bug exposed by the recent changes to Windows.Forms when an
4175 implemented interface was defined inside a class that had not been
4178 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
4180 (Check): Loop correctly to report errors modifiers
4181 (UNSAFE was not in the loop, since it was the same as TOP).
4183 * interface.cs: Every interface member now takes a ModFlags,
4184 instead of a "is_new" bool, which we set on the base MemberCore.
4186 Every place where we called "UnsafeOk" in the interface, now we
4187 call the proper member (InterfaceMethod.UnsafeOK) instead to get
4188 the unsafe settings from the member declaration instead of the
4189 container interface.
4191 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
4193 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
4194 `set_indexer_name' to the pending bits (one per type).
4196 We fixed a bug today that was picking the wrong method to
4197 override, since for properties the existing InterfaceMethod code
4198 basically ignored the method name. Now we make sure that the
4199 method name is one of the valid indexer names.
4201 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
4203 * support.cs (SeekableStreamReader): Keep track of stream byte
4204 positions and don't mix them with character offsets to the buffer.
4206 Patch from Gustavo Giráldez
4208 2004-03-15 Marek Safar <marek.safar@seznam.cz>
4210 * interface.cs (InterfaceSetGetBase): Removed double member
4211 initialization, base class does it as well.
4213 2004-03-13 Martin Baulig <martin@ximian.com>
4215 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
4216 when compiling corlib.
4218 2004-03-13 Miguel de Icaza <miguel@ximian.com>
4220 * convert.cs (ExplicitConversion): We were reporting an error on
4221 certain conversions (object_type source to a value type, when the
4222 expression was `null') before we had a chance to pass it through
4223 the user defined conversions.
4225 * driver.cs: Replace / and \ in resource specifications to dots.
4228 * class.cs: Add check for duplicate operators. Fixes 52477
4230 2004-03-11 Miguel de Icaza <miguel@ximian.com>
4232 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
4233 that are in the middle of the statements, not only at the end.
4236 * class.cs (TypeContainer.AddField): No longer set the
4237 `HaveStaticConstructor' flag, now we call it
4238 `UserDefineStaticConstructor' to diferentiate the slightly
4239 semantic difference.
4241 The situation is that we were not adding BeforeFieldInit (from
4242 Modifiers.TypeAttr) to classes that could have it.
4243 BeforeFieldInit should be set to classes that have no static
4248 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
4250 And most importantly Zoltan's comment:
4252 http://bugzilla.ximian.com/show_bug.cgi?id=44229
4254 "I think beforefieldinit means 'it's ok to initialize the type sometime
4255 before its static fields are used', i.e. initialization does not need
4256 to be triggered by the first access to the type. Setting this flag
4257 helps the JIT to compile better code, since it can run the static
4258 constructor at JIT time, and does not need to generate code to call it
4259 (possibly lots of times) at runtime. Unfortunately, mcs does not set
4260 this flag for lots of classes like String.
4262 csc sets this flag if the type does not have an explicit static
4263 constructor. The reasoning seems to be that if there are only static
4264 initalizers for a type, and no static constructor, then the programmer
4265 does not care when this initialization happens, so beforefieldinit
4268 This bug prevents the AOT compiler from being usable, since it
4269 generates so many calls to mono_runtime_class_init that the AOT code
4270 is much slower than the JITted code. The JITted code is faster,
4271 because it does not generate these calls if the vtable is type is
4272 already initialized, which is true in the majority of cases. But the
4273 AOT compiler can't do this."
4275 2004-03-10 Miguel de Icaza <miguel@ximian.com>
4277 * class.cs (MethodData.Emit): Refactor the code so symbolic
4278 information is generated for destructors; For some reasons we
4279 were taking a code path that did not generate symbolic information
4282 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
4284 * class.cs: Create a Constructor.CheckBase method that
4285 takes care of all validation type code. The method
4286 contains some code that was moved from Define.
4288 It also includes new code that checks for duplicate ctors.
4289 This fixes bug #55148.
4291 2004-03-09 Joshua Tauberer <tauberer@for.net>
4293 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
4294 a { ... }-style array creation invokes EmitStaticInitializers
4295 which is not good for reference-type arrays. String, decimal
4296 and now null constants (NullCast) are not counted toward
4297 static initializers.
4299 2004-03-05 Martin Baulig <martin@ximian.com>
4301 * location.cs (SourceFile.HasLineDirective): New public field;
4302 specifies whether the file contains or is referenced by a "#line"
4304 (Location.DefineSymbolDocuments): Ignore source files which
4305 either contain or are referenced by a "#line" directive.
4307 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
4309 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
4310 direct access to our parent, so check the method inline there.
4312 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
4314 * expression.cs (Invocation.EmitCall): Miguel's last commit
4315 caused a regression. If you had:
4320 In Foo the implict this would be null.
4322 2004-02-27 Miguel de Icaza <miguel@ximian.com>
4324 * expression.cs (Invocation.EmitCall): If the method is not
4325 virtual, do not emit a CallVirt to it, use Call.
4327 * typemanager.cs (GetFullNameSignature): Improve the method to
4328 cope with ".ctor" and replace it with the type name.
4330 * class.cs (ConstructorInitializer.Resolve): Now the method takes
4331 as an argument the ConstructorBuilder where it is being defined,
4332 to catch the recursive constructor invocations.
4334 2004-03-16 Martin Baulig <martin@ximian.com>
4336 * expression.cs (MemberAccess.DoResolve): If `expr' resolved to a
4337 ConstructedType, call ResolveType() on it to get the type rather
4338 than just using `expr.Type'.
4340 2004-03-16 Martin Baulig <martin@ximian.com>
4342 * generics.cs (ConstructedType.GetMemberAccess): Take the
4343 EmitContext instead on the TypeExpr and use
4344 ec.TypeContainer.CurrentType/ec.ContainerType.
4346 2004-03-16 Martin Baulig <martin@ximian.com>
4348 * ecore.cs (SimpleName.DoResolveAsTypeStep): Lookup type
4349 parameters before aliases.
4351 2004-03-16 Martin Baulig <martin@ximian.com>
4353 * typemanager.cs (TypeManager.MayBecomeEqualGenericInstances):
4354 New oublic function; checks whether two generic instances may become
4355 equal under some instantiations (26.3.1).
4357 * class.cs (TypeContainer.Define): Call
4358 TypeManager.MayBecomeEqualGenericInstances() and report CS0695 on
4361 2004-03-16 Martin Baulig <martin@ximian.com>
4363 * class.cs (TypeContainer.GetClassBases): Moved
4364 Error_TypeParameterAsBase() here and also check whether the base
4365 class is not an attribute.
4367 2004-03-16 Martin Baulig <martin@ximian.com>
4369 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
4371 2004-03-16 Martin Baulig <martin@ximian.com>
4373 * class.cs (Error_TypeParameterAsBase): Use correct error number
4376 2004-03-16 Martin Baulig <martin@ximian.com>
4378 * decl.cs (DeclSpace.ResolveTypeExpr): Added more error checking
4381 * generics.cs (ConstructedType.DoResolveAsTypeStep): Added better
4384 2004-03-15 Martin Baulig <martin@ximian.com>
4386 * typemanager.cs (TypeManager.GetFullName): New public method.
4387 (TypeManager.MemberLookup): Added `int_num_type_arguments'
4388 argument; only return members with the correct number of type
4390 (TypeManager.CheckGeneric): Allow -1 to bypass the check.
4391 (TypeManager.FilterWithClosure): Call CheckGeneric() to check
4392 whether the number of type arguments matches.
4394 * generic.cs (GenericMemberAccess.ResolveAsTypeStep): Allow `expr'
4395 not being a ConstructedType; we can now do "typeof (Foo.Bar<U>)".
4397 * expression.cs (MemberAccess): Added public `NumTypeArguments'
4398 field; it's set by the protected .ctor when we're actually a
4399 GenericMemberAccess.
4400 (MemberAccess.ResolveAsTypeStep): Compute the total number of type
4401 arguments and pass it to MemberLookupFinal ().
4403 * ecore.cs (Expression.MemberLookup): Added `int
4404 num_type_arguments' argument; only return members with the correct
4405 number of type arguments.
4406 (Expression.MemberLookupFailed): Check whether the MemberLookup
4407 failed because we did not have the correct number of type
4408 arguments; report CS0305 in this case.
4410 * decl.cs (DeclSpace.ResolveTypeExpr): Don't report an error if
4411 `e.ResolveAsTypeTerminal()' already did so.
4413 2004-03-15 Martin Baulig <martin@ximian.com>
4415 * ecore.cs (Expression.ResolveLValue): Allow e.type being null if
4416 we're a ConstructedType; in this case, the caller must report an
4417 error (for instance CS0131).
4419 * generic.cs (TypeArguments): Added Location argument to the .ctor.
4420 (TypeArguments.Resolve): Actually report errors here.
4422 2004-03-15 Miguel de Icaza <miguel@ximian.com>
4424 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
4425 `set_indexer_name' to the pending bits (one per type).
4427 We fixed a bug today that was picking the wrong method to
4428 override, since for properties the existing InterfaceMethod code
4429 basically ignored the method name. Now we make sure that the
4430 method name is one of the valid indexer names.
4432 2004-03-15 Martin Baulig <martin@ximian.com>
4434 * typemanager.cs (TypeManager.IndexerPropertyName): Added support
4435 for generic instances.
4437 2004-03-13 Martin Baulig <martin@ximian.com>
4439 * class.cs (TypeContainer.DefineType): Call
4440 TypeManager.AddUserType() immediately after creating the
4441 TypeBuilder; pass all type parameters when creating the
4444 * decl.cs (DeclSpace.FindNestedType): New public method.
4445 (DeclSpace.FindType): Added `int num_type_args' argument; only
4446 return types with the correct number of type parameters.
4447 (DeclSpace.CountTypeParams): New public property.
4449 * ecore.cs (SimpleName.ctor): Added overloaded version which takes
4450 the number of type parameters; defaults to zero.
4452 * generic.cs (TypeArguments.Count): New public property.
4453 (ConstructedType.DoResolveAsTypeStep): First call
4454 ds.FindNestedType() to find out whether we're nested in the
4455 current generic type; in this case, we inherit all type parameters
4456 from the current class.
4458 * rootcontext.cs (RootContext.NamespaceLookup): Added `int
4459 num_type_args' argument.
4460 (RootContext.LookupType): Added overloaded version which takes the
4461 number of type arguments; only return types with the correct
4462 number of type arguments.
4464 * typemanager.cs (TypeManager.CheckGeneric): New public function;
4465 checks whether `Type t' has `int num_type_args'.
4467 2004-03-13 Martin Baulig <martin@ximian.com>
4469 * generic.cs (GenericMethod.DefineType): New method; calls
4470 DefineType() on all the type parameters.
4472 * class.cs (MethodData.ctor): Added `GenericMethod generic' argument.
4473 (MethodData.Define): If we're a generic method, call
4474 GenericMethod.DefineType() to define the type parameters.
4476 2004-03-10 Martin Baulig <martin@ximian.com>
4478 * pending.cs (Pending.InterfaceMethod): Use TypeManager.IsEqual()
4479 instead of IsAssignableFrom.
4481 2004-03-10 Martin Baulig <martin@ximian.com>
4483 * ecore.cs (FieldExpr.ctor): Use TypeManager.TypeToCoreType().
4485 * support.cs (ParameterData.HasArrayParameter): New property.
4486 (ReflectionParameters.ctor): Take a MethodBase instead of a
4487 ParameterInfo[]. If we have any type parameters, get the generic
4488 method definition and ask it whether we have variable arguments.
4490 2004-02-26 Miguel de Icaza <miguel@ximian.com>
4492 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
4493 routines to check if a type is an enumerable/enumerator allow
4494 classes that implement the IEnumerable or IEnumerator interfaces.
4496 * class.cs (Property, Operator): Implement IIteratorContainer, and
4497 implement SetYields.
4499 (Property.Define): Do the block swapping for get_methods in the
4500 context of iterators. We need to check if Properties also
4501 include indexers or not.
4503 (Operator): Assign the Block before invoking the
4504 OperatorMethod.Define, so we can trigger the Iterator code
4507 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
4508 Property and Operator classes are not created when we parse the
4509 declarator but until we have the block completed, so we use a
4510 singleton SimpleIteratorContainer.Simple to flag whether the
4511 SetYields has been invoked.
4513 We propagate this setting then to the Property or the Operator to
4514 allow the `yield' to function.
4516 2004-02-25 Marek Safar <marek.safar@seznam.cz>
4518 * codegen.cs: Implemented attribute support for modules.
4519 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
4520 Assembly/Module functionality.
4522 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
4523 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
4524 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
4526 2004-02-16 Marek Safar <marek.safar@seznam.cz>
4528 * interface.cs (FindMembers): The operation is performed on all base
4529 interfaces and not only on the first. It is required for future CLS Compliance patch.
4531 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
4533 * statement.cs, codegen.cs:
4534 This patch deals with patterns such as:
4536 public class List : IEnumerable {
4538 public MyEnumerator GetEnumerator () {
4539 return new MyEnumerator(this);
4542 IEnumerator IEnumerable.GetEnumerator () {
4546 public struct MyEnumerator : IEnumerator {
4551 Before, there were a few things we did wrong:
4552 1) we would emit callvirt on a struct, which is illegal
4553 2) we emited ldarg when we needed to emit ldarga
4554 3) we would mistakenly call the interface methods on an enumerator
4555 type that derived from IEnumerator and was in another assembly. For example:
4557 public class MyEnumerator : IEnumerator
4559 Would have the interface methods called, even if there were public impls of the
4560 method. In a struct, this lead to invalid IL code.
4562 2004-02-11 Marek Safar <marek.safar@seznam.cz>
4564 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
4567 * delegate.cs (Define): Fixed crash when delegate type is undefined.
4569 2004-02-11 Miguel de Icaza <miguel@ximian.com>
4571 * cs-parser.jay: Fix small regression: we were not testing V2
4572 compiler features correctly.
4574 * interface.cs: If the emit context is null, then create one
4576 2004-02-09 Marek Safar <marek.safar@seznam.cz>
4578 * decl.cs (GetSignatureForError): New virtual method to get full name
4581 * attribute.cs (IAttributeSupport): New interface for attribute setting.
4582 Now it is possible to rewrite ApplyAttributes method to be less if/else.
4584 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
4585 Duplicated members and code in these classes has been removed.
4586 Better encapsulation in these classes.
4588 2004-02-07 Miguel de Icaza <miguel@ximian.com>
4590 * assign.cs (Assign.DoResolve): When dealing with compound
4591 assignments, there is a new rule in ECMA C# 2.4 (might have been
4592 there before, but it is documented here) that states that in:
4596 If b is of type int, and the `op' is a shift-operator, then the
4597 above is evaluated as:
4601 * expression.cs (Binary.ResolveOperator): Instead of testing for
4602 int/uint/long/ulong, try to implicitly convert to any of those
4603 types and use that in pointer arithmetic.
4605 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
4606 method to print information for from the type, not from the
4607 null-method we were given.
4609 2004-02-01 Duncan Mak <duncan@ximian.com>
4611 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
4612 parsing for cmd, fixes bug #53694.
4614 2004-02-04 Marek Safar <marek.safar@seznam.cz>
4616 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
4617 in the member name duplication tests. Property and operator name duplication
4618 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
4620 2004-02-03 Marek Safar <marek.safar@seznam.cz>
4622 * interface.cs (PopulateMethod): Fixed crash when interface method
4623 returns not existing type (error test cs0246-3.cs).
4625 2004-02-02 Ravi Pratap M <ravi@ximian.com>
4627 * cs-parser.jay (interface_accessors): Re-write actions to also
4628 store attributes attached to get and set methods. Fix spelling
4631 (inteface_property_declaration): Modify accordingly.
4633 (InterfaceAccessorInfo): New helper class to store information to pass
4634 around between rules that use interface_accessors.
4636 * interface.cs (Emit): Apply attributes on the get and set
4637 accessors of properties and indexers too.
4639 * attribute.cs (ApplyAttributes): Modify accordingly to use the
4640 right MethodBuilder when applying attributes to the get and set accessors.
4642 2004-01-31 Miguel de Icaza <miguel@ximian.com>
4644 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
4646 2004-01-26 Miguel de Icaza <miguel@ximian.com>
4648 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
4650 2004-01-25 Miguel de Icaza <miguel@ximian.com>
4652 * cs-parser.jay: Remove YIELD token, instead use the new grammar
4653 changes that treat `yield' specially when present before `break'
4656 * cs-tokenizer.cs: yield is no longer a keyword.
4658 2004-01-23 Marek Safar <marek.safar@seznam.cz>
4660 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
4661 setting for default constructors.
4662 For default constructors are almost every time set wrong Modifier. The
4663 generated IL code has been alright. But inside mcs this values was
4664 wrong and this was reason why several of my CLS Compliance tests
4667 2004-02-27 Martin Baulig <martin@ximian.com>
4669 * generics.cs (ConstructedType.ResolveType): Make the nested type
4670 stuff actually work.
4672 2004-02-25 Martin Baulig <martin@ximian.com>
4674 * decl.cs (DeclSpace.CurrentTypeParameters): New protected
4675 property; returns the type parameters just from the current type,
4676 ie. with the ones from outer classes.
4677 (DeclSpace.LookupGeneric): First search in the current class, then
4679 (DeclSpace.initialize_type_params): When hiding a type parameter
4680 from an outer class, put it into the `type_param_list' anyways.
4682 * expression.cs (MemberAccess.expr): Made this field protected.
4684 * class.cs (TypeContainer.Define): The `CurrentType' just contains
4685 the type parameters from the current class.
4687 * generic.cs (ConstructedType.ResolveType): Support nested generic
4688 types by taking the type parameters which we inherit from outer
4689 classes into account.
4690 (GenericMemberAccess.ResolveAsTypeStep): Override this and added
4691 support for nested generic types.
4693 2004-02-23 Martin Baulig <martin@ximian.com>
4695 * decl.cs (DeclSpace.IsGeneric): Make this a property instead of a
4696 field and check whether we're nested inside a generic type.
4697 (DeclSpace.ResolveType): If we're resolving to a generic type
4698 definition, create a ConstructedType and return its resolved type.
4699 (DeclSpace.initialize_type_params): New private method;
4700 initializes the `type_param_list' field from the type parameters
4701 from this and all enclosing classes.
4702 (DeclSpace.TypeParameters): Call initialize_type_params() unless
4703 we're already initialized.
4705 2004-02-23 Martin Baulig <martin@ximian.com>
4707 * class.cs (Method.Define): Create the generic method before
4709 (Memberbase.DoDefine): Added DeclSpace argument (in addition to
4710 the TypeContainer one); we use this for generic methods.
4712 * decl.cs (CheckAccessLevel): If we're a GenericMethod, use our
4713 parent's TypeBuilder.
4715 2004-02-18 Martin Baulig <martin@ximian.com>
4717 * ecore.cs (FieldExpr.DoResolveLValue): Use TypeManager.IsEqual()
4718 to check for equality.
4720 2004-02-05 Martin Baulig <martin@ximian.com>
4722 * ecore.cs (FieldExpr.DoResolveLValue): If we have an
4723 `ec.TypeContainer.CurrentType', use it instead of
4724 `ec.ContainerType' to check whether we're in the type's ctor.
4726 2004-01-29 Martin Baulig <martin@ximian.com>
4728 * expression.cs (Invocation.DoResolve): If we're a
4729 `ConstructedType', then we're actually a generic method, so
4730 rewrite the expr as a GenericMemberAccess.
4732 * cs-parser.jay (member_name): Don't use `namespace_or_type_name'
4733 here; manually parse it into a string.
4735 2004-01-28 Martin Baulig <martin@ximian.com>
4737 * typemanager.cs (TypeManager.IsEqual): New static method.
4738 (TypeManager.FilterWithClosure): Call TypeManager.IsEqual() to
4739 check for equality instead of using `=='.
4741 2004-01-26 Martin Baulig <martin@ximian.com>
4743 * decl.cs (DeclSpace.CurrentType): New public field.
4745 * expression.cs (This.ResolveBase): If we have an
4746 `ec.TypeContainer.CurrentType', use it instead of
4749 * class.cs (TypeContainer.DefineType): If we're a generic type,
4750 create the `CurrentType' (unresolved).
4751 (TypeContainer.GenericType): New private field.
4752 (TypeContainer.DefineMembers): If we have a `CurrentType', resolve
4753 it and store it in `GenericType' before creating the MemberCache.
4754 (TypeContainer.GetMembers): If we have a `GenericType', call
4755 TypeManager.FindMembers() on it.
4757 * interface.cs (Interface.GenericType): New private field.
4758 (Interface.DefineType): If we're a generic type, create the
4759 `CurrentType' (unresolved).
4760 (Interface.DefineMembers): If we have a `CurrentType', resolve it
4761 and store it in `GenericType' before creating the MemberCache.
4762 (Interface.GetMembers): If we have a `GenericType', call
4763 TypeManager.FindMembers() on it.
4765 2004-01-22 Martin Baulig <martin@ximian.com>
4767 * cs-parser.jay (namespace_or_type_name): Return an Expression,
4768 not a QualifiedIdentifier. This is what `type_name_expression'
4769 was previously doing.
4770 (type_name_expression): Removed; the code is now in
4771 `namespace_or_type_name'.
4772 (qualified_identifier): Removed, use `namespace_or_type_name'
4774 (QualifiedIdentifier): Removed this class.
4776 2004-01-22 Martin Baulig <martin@ximian.com>
4778 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
4779 not a string as alias name.
4781 2004-01-21 Miguel de Icaza <miguel@ximian.com>
4783 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
4784 #52730 bug, and instead compute correctly the need to use a
4785 temporary variable when requesting an address based on the
4786 static/instace modified of the field and the constructor.
4788 2004-01-21 Martin Baulig <martin@ximian.com>
4790 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
4791 class and namespace before looking up aliases. Fixes #52517.
4793 2004-01-21 Martin Baulig <martin@ximian.com>
4795 * flowanalysis.cs (UsageVector.Merge): Allow variables being
4796 assinged in a 'try'; fixes exception4.cs.
4798 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4799 * class.cs : Implemented parameter-less constructor for TypeContainer
4801 * decl.cs: Attributes are now stored here. New property OptAttributes
4803 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
4805 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
4807 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4809 * typemanager.cs (CSharpSignature): Now reports also inner class name.
4810 (CSharpSignature): New method for indexer and property signature.
4812 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4814 * pending.cs (IsVirtualFilter): Faster implementation.
4816 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4818 * typemanager.cs: Avoid inclusion of same assembly more than once.
4820 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4822 * cs-parser.jay: Fixed problem where the last assembly attribute
4823 has been applied also to following declaration (class, struct, etc.)
4825 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4827 * class.cs: Added error CS0538, CS0539 reporting.
4828 Fixed crash on Microsoft runtime when field type is void.
4830 * cs-parser.jay: Added error CS0537 reporting.
4832 * pending.cs: Added error CS0535 reporting.
4833 Improved error report for errors CS0536, CS0534.
4835 2004-01-20 Miguel de Icaza <miguel@ximian.com>
4837 Merge a few bits from the Anonymous Method MCS tree.
4839 * statement.cs (ToplevelBlock): New class for toplevel methods,
4840 will hold anonymous methods, lifted variables.
4842 * cs-parser.jay: Create toplevel blocks for delegates and for
4843 regular blocks of code.
4845 2004-01-20 Martin Baulig <martin@ximian.com>
4847 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
4848 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
4849 and `NeedExplicitReturn'; added `IsLastStatement'.
4850 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
4851 have a `ReturnLabel' or we're not unreachable.
4853 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
4854 child's reachability; don't just override ours with it. Fixes
4855 #58058 (lluis's example).
4856 (FlowBranching): Added public InTryOrCatch(), InCatch(),
4857 InFinally(), InLoop(), InSwitch() and
4858 BreakCrossesTryCatchBoundary() methods.
4860 * statement.cs (Return): Do all error checking in Resolve().
4861 Unless we are the last statement in a top-level block, always
4862 create a return label and jump to it.
4863 (Break, Continue): Do all error checking in Resolve(); also make
4864 sure we aren't leaving a `finally'.
4865 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
4866 statement in a top-level block.
4867 (Block.Flags): Added `IsDestructor'.
4868 (Block.IsDestructor): New public property.
4870 2004-01-20 Martin Baulig <martin@ximian.com>
4872 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
4874 2004-01-20 Martin Baulig <martin@ximian.com>
4876 * statement.cs (Statement.ResolveUnreachable): New public method.
4877 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
4878 (Block.Resolve): Resolve unreachable statements.
4880 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
4882 * expression.cs: We need to fix the case where we do
4883 not have a temp variable here.
4885 * assign.cs: Only expression compound assignments need
4886 temporary variables.
4888 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
4890 * flowanalysis.cs: Reduce memory allocation in a few ways:
4891 - A block with no variables should not allocate a bit
4893 - A method with no out parameters does not need any tracking
4894 for assignment of the parameters, so we need not allocate
4897 public readonly Type[] VariableTypes;
4898 public readonly string[] VariableNames;
4899 Are redundant. The data is already stored in the variable
4900 map, so we need not allocate another array for it.
4901 - We need to add alot of checks for if (params | locals) == null
4902 due to the first two changes.
4904 2004-01-18 Miguel de Icaza <miguel@ximian.com>
4906 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
4907 implement IMemoryLocation, we store a copy on a local variable and
4908 take the address of it. Patch from Benjamin Jemlich
4910 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
4911 to use a special "type_name_expression" rule which reduces the
4912 number of "QualifiedIdentifier" classes created, and instead
4913 directly creates MemberAccess expressions.
4915 2004-01-17 Miguel de Icaza <miguel@ximian.com>
4917 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
4918 that fixes #52853. Null literal assignment to ValueType
4920 * class.cs (MethodData.Emit): Instead of checking the name of the
4921 method to determine if its a destructor, create a new derived
4922 class from Method called Destructor, and test for that.
4924 * cs-parser.jay: Create a Destructor object instead of a Method.
4926 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
4930 2004-01-16 Miguel de Icaza <miguel@ximian.com>
4932 * expression.cs (Binary.ResolveOperator): Perform an implicit
4933 conversion from MethodGroups to their delegate types on the
4936 * delegate.cs: Introduce a new class DelegateCreation that is the
4937 base class for `NewDelegate' and `ImplicitDelegateCreation',
4938 factor some code in here.
4940 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
4941 conversion from MethodGroups to compatible delegate types.
4943 * ecore.cs (Expression.Resolve): Do not flag error 654
4944 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
4945 we allow conversions from MethodGroups to delegate types now.
4947 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
4948 assignments in v2 either.
4950 2004-01-10 Miguel de Icaza <miguel@ximian.com>
4952 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
4953 static read-only fields in ctors.
4955 Applied patch from Benjamin Jemlich
4957 * expression.cs (UnaryMutator): Avoid leaking local variables.
4959 2004-01-09 Miguel de Icaza <miguel@ximian.com>
4961 * cs-tokenizer.cs (IsCastToken): Allow the various native types
4962 here to return true, as they can be used like this:
4966 Fixed 49836 and all the other dups
4968 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
4970 * driver.cs: Implement /win32res and /win32icon.
4972 2004-01-08 Miguel de Icaza <miguel@ximian.com>
4974 * cs-parser.jay: Add a rule to improve error handling for the
4975 common mistake of placing modifiers after the type.
4977 2004-01-07 Miguel de Icaza <miguel@ximian.com>
4979 * cs-parser.jay (interface_event_declaration): Catch
4980 initialization of events on interfaces, and report cs0068
4982 * cs-parser.jay (interface_event_declaration): Catch
4983 initialization of events.
4985 * ecore.cs: Better report missing constructors.
4987 * expression.cs (Binary.ResolveOperator): My previous bug fix had
4988 the error reporting done in the wrong place. Fix.
4990 * expression.cs (Binary.ResolveOperator): Catch the
4991 operator + (E x, E y) error earlier, and later allow for implicit
4992 conversions in operator +/- (E e, U x) from U to the underlying
4995 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
4996 52596, if the container class is abstract, the default constructor
4997 is protected otherwise its public (before, we were always public).
4999 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
5002 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
5003 Jemlich that fixes bug #52597, MCS was generating invalid code for
5004 idisposable structs. Thanks to Ben for following up with this
5007 2004-01-06 Miguel de Icaza <miguel@ximian.com>
5009 * driver.cs: Allow assemblies without code to be generated, fixes
5012 2004-01-07 Nick Drochak <ndrochak@gol.com>
5014 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
5016 2004-01-05 Miguel de Icaza <miguel@ximian.com>
5018 * cs-parser.jay: Add rules to improve error reporting if fields or
5019 methods are declared at the namespace level (error 116)
5021 * Add rules to catch event add/remove
5023 2004-01-04 David Sheldon <dave-mono@earth.li>
5025 * expression.cs: Added matching ")" to error message for
5028 2004-01-03 Todd Berman <tberman@gentoo.org>
5030 * ecore.cs, attribute.cs:
5031 Applying fix from #52429.
5033 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
5035 * ecore.cs, expression.cs, statement.cs:
5036 Total rewrite of how we handle branching. We
5037 now handle complex boolean expressions with fewer
5038 jumps. As well if (x == 0) no longer emits a ceq.
5040 if (x is Foo) is much faster now, because we generate
5043 Overall, we get a pretty big improvement on our benchmark
5044 tests. The code we generate is smaller and more readable.
5046 I did a full two-stage bootstrap. The patch was reviewed
5047 by Martin and Miguel.
5049 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
5051 * cs-parser.jay: Make primary_expression not take a QI.
5052 we dont need this because the member_access rule covers
5053 us here. So we replace the rule with just IDENTIFIER.
5055 This has two good effects. First, we remove a s/r conflict.
5056 Second, we allocate many fewer QualifiedIdentifier objects.
5058 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
5060 * attribute.cs: Handle MarshalAs attributes as pseudo, and
5061 set the correct information via SRE. This prevents
5062 hanging on the MS runtime. Fixes #29374.
5064 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
5066 * convert.cs: correctly handle conversions to value types
5067 from Enum and ValueType as unboxing conversions.
5069 Fixes bug #52569. Patch by Benjamin Jemlich.
5071 2004-01-02 Ravi Pratap <ravi@ximian.com>
5073 * expression.cs (BetterConversion): Prefer int -> uint
5074 over int -> ulong (csc's behaviour). This fixed bug #52046.
5076 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
5078 * decl.cs (MemberCache.FindMembers): now returns a
5081 * typemanager.cs: In general, go with with ^^.
5082 (CopyNewMethods): take an IList.
5083 (RealMemberLookup): Only allocate an arraylist
5084 if we copy from two sets of methods.
5086 This change basically does two things:
5087 1) Fewer array lists allocated due to CopyNewMethods.
5088 2) the explicit cast in MemberList costed ALOT.
5090 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
5092 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
5093 a hashtable to avoid needless string allocations when an identifier is
5094 used more than once (the common case).
5096 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
5098 * pending.cs: MS's TypeBuilder.GetInterfaces ()
5099 is broken, it will not return anything. So, we
5100 have to use the information we have in mcs to
5103 * typemanager.cs: Add a cache for GetInterfaces,
5104 since this will now be used more often (due to ^^)
5106 (GetExplicitInterfaces) New method that gets the
5107 declared, not effective, interfaces on a type
5108 builder (eg, if you have interface IFoo, interface
5109 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
5112 This patch makes MCS able to bootstrap itself on
5115 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
5117 * expression.cs: Remove the Nop's that Miguel put
5120 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
5122 * report.cs, codegen.cs: Give the real stack trace to
5123 the error when an exception is thrown.
5125 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
5127 * decl.cs: only allocate hashtables for ifaces if
5130 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
5132 * expression.cs: fix the error from cs0121-2.cs
5133 (a parent interface has two child interfaces that
5134 have a function with the same name and 0 params
5135 and the function is called through the parent).
5137 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
5139 * class.cs, rootcontext.cs, typmanager.cs: do not
5142 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
5144 * codegen.cs: remove stack for the ec flow branching.
5145 It is already a linked list, so no need.
5147 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
5149 * Makefile: Allow custom profiler here.
5151 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
5153 * typemanager.cs (LookupType):
5154 - Use a static char [], because split takes
5155 a param array for args, so it was allocating
5157 - Do not store true in a hashtable, it boxes.
5159 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
5161 * flowanalysis.cs: bytify common enums.
5163 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
5165 * modifiers.cs: Add a new set of flags for the
5166 flags allowed on explicit interface impls.
5167 * cs-parser.jay: catch the use of modifiers in
5168 interfaces correctly.
5169 * class.cs: catch private void IFoo.Blah ().
5171 All related to bug #50572.
5173 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
5175 * decl.cs: Rewrite the consistant accessability checking.
5176 Accessability is not linear, it must be implemented in
5177 a tableish way. Fixes #49704.
5179 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
5181 * expression.cs: Handle negation in a checked context.
5182 We must use subtraction from zero. Fixes #38674.
5184 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
5186 * class.cs: Ignore static void main in DLLs.
5187 * rootcontext.cs: Handle the target type here,
5188 since we are have to access it from class.cs
5189 * driver.cs: account for the above.
5191 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
5193 * report.cs: Give line numbers and files if available.
5195 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
5197 * driver.cs: Implement /addmodule.
5199 * typemanager.cs: Change 'modules' field so it now contains Modules not
5202 2003-12-20 Martin Baulig <martin@ximian.com>
5204 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
5205 (FieldBase.IsAssigned): Removed this field.
5206 (FieldBase.SetAssigned): New public method.
5207 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
5209 2003-12-20 Martin Baulig <martin@ximian.com>
5211 * expression.cs (LocalVariableReference.DoResolve): Don't set
5212 `vi.Used' if we're called from DoResolveLValue().
5214 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
5215 returns the usage vector it just merged into the current one -
5216 pass this one to UsageWarning().
5217 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
5218 of the `EmitContext', don't call this recursively on our children.
5220 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
5222 * driver.cs: Implement /target:module.
5224 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
5226 * support.cs (CharArrayHashtable): New helper class.
5228 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
5229 char arrays, not strings, so we can avoid creating a string in
5230 consume_identifier if the identifier is a keyword.
5232 2003-12-16 Martin Baulig <martin@ximian.com>
5234 * statement.cs (LocalInfo.Assigned): Removed this property.
5235 (LocalInfo.Flags): Removed `Assigned'.
5236 (LocalInfo.IsAssigned): New public method; takes the EmitContext
5237 and uses flow analysis.
5238 (Block.UsageWarning): Made this method private.
5239 (Block.Resolve): Call UsageWarning() if appropriate.
5241 * expression.cs (LocalVariableReference.DoResolve): Always set
5242 LocalInfo.Used here.
5244 2003-12-13 Martin Baulig <martin@ximian.com>
5246 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
5247 any value here; we're now using flow analysis to figure out
5248 whether a statement/block returns a value.
5250 2003-12-13 Martin Baulig <martin@ximian.com>
5252 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
5254 (FlowBranching.MergeFinally): Don't call
5255 `branching.CheckOutParameters()' here, this is called in
5257 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
5258 when adding the `finally' vector.
5260 2003-12-13 Martin Baulig <martin@ximian.com>
5263 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
5264 actually work and also fix #48962.
5266 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
5268 * decl.cs: Do not check System.Object for nested types,
5269 since we know it does not have any. Big bang for buck:
5274 corlib: 17.99 seconds
5278 corlib: 17.39 seconds
5280 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
5282 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
5283 time we are returning 0 members, so we save alot here.
5285 2003-12-11 Martin Baulig <martin@ximian.com>
5287 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
5288 `MergeChild()', also just take the `FlowBranching' as argument;
5289 call Merge() on it and return the result.
5290 (FlowBranching.Merge): We don't need to do anything if we just
5293 2003-12-11 Martin Baulig <martin@ximian.com>
5295 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
5296 them in an `ArrayList' to reduce memory usage. Thanks to Ben
5297 Maurer for this idea.
5299 2003-12-11 Martin Baulig <martin@ximian.com>
5301 * flowanalysis.cs (MergeResult): This class is now gone; we now
5302 use the `UsageVector' for this. The reason for this is that if a
5303 branching just has one sibling, we don't need to "merge" them at
5304 all - that's the next step to do.
5305 (FlowBranching.Merge): We now return a `UsageVector' instead of a
5308 2003-12-11 Martin Baulig <martin@ximian.com>
5310 Reworked flow analyis and made it more precise and bug-free. The
5311 most important change is that we're now using a special `Reachability'
5312 class instead of having "magic" meanings of `FlowReturns'. I'll
5313 do some more cleanups and optimizations and also add some more
5314 documentation this week.
5316 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
5317 largely reworked this class.
5318 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
5319 the new `Reachability' class instead of having "magic" values here.
5320 (FlowBranching): We're now using an instance of `Reachability'
5321 instead of having separate `Returns', `Breaks' etc. fields.
5323 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
5324 based on flow analysis; ignore the return value of block.Emit ().
5326 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
5328 * driver.cs typemanager.cs: Find the mono extensions to corlib even
5329 if they are private.
5331 2003-12-09 Martin Baulig <martin@ximian.com>
5333 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
5334 call them directly on the UsageVector.
5336 2003-12-09 Martin Baulig <martin@ximian.com>
5338 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
5339 Changed return type from `FlowReturns' to `Reachability'.
5341 2003-12-09 Martin Baulig <martin@ximian.com>
5343 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
5344 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
5345 `Reachable' fields with a single `Reachability' one.
5347 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
5349 * class.cs (FindMembers): Remove foreach's.
5362 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
5367 This patch does a few things:
5368 1. EmptyStatement is now a singleton, so it is never reallocated.
5369 2. All blah is EmptyStatement constructs have been changed to
5370 blah == EmptyStatement.Value, which is much faster and valid
5371 now that EmptyStatement is a singleton.
5372 3. When resolving a block, rather than allocating a new array for
5373 the non-empty statements, empty statements are replaced with
5374 EmptyStatement.Value
5375 4. Some recursive functions have been made non-recursive.
5376 Mainly the performance impact is from (3), however (1) and (2) are needed for
5377 this to work. (4) does not make a big difference in normal situations, however
5378 it makes the profile look saner.
5383 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
5384 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
5385 Total memory allocated: 56397 KB
5388 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
5389 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
5390 Total memory allocated: 55666 KB
5392 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
5394 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
5395 than the hashtable in a hashtable version
5397 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
5398 we always end up concating a string. This results in a huge perf
5399 loss, because many strings have to be tracked by the GC. In this
5400 patch, we first use a hashtable that works with two keys, so that
5401 the strings do not need to be concat'ed.
5412 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
5414 * Makefile: Add a new target `do-time' that does a quick and simple
5415 profile, leaving easy to parse output.
5417 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
5419 * codegen.cs (Init): Create the dynamic assembly with
5420 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
5422 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
5424 * support.cs: Make the PtrHashtable use only one
5425 instance of its comparer.
5427 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
5429 * typemanager.cs: Fix lookup of GetNamespaces.
5431 2003-11-29 Miguel de Icaza <miguel@ximian.com>
5433 * expression.cs: Removed redundant line.
5435 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
5436 ArrayLists, use for loops with bounds.
5438 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
5441 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
5442 arraylists, use for loop with bounds.
5444 The above three changes give us a 0.071 second performance
5445 improvement out of 3.294 seconds down to 3.223. On my machine
5446 the above changes reduced the memory usage by 1,387 KB during
5449 * cs-parser.jay (QualifiedIdentifier): New class used to represent
5450 QualifiedIdentifiers. Before we created a new string through
5451 concatenation, and mostly later on, the result would be
5452 manipulated by DecomposeQI through string manipulation.
5454 This reduced the compiler memory usage for bootstrapping from
5455 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
5456 compile times in 0.05 seconds.
5458 2003-11-28 Dick Porter <dick@ximian.com>
5460 * support.cs: Do string compares with the Invariant culture.
5468 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
5469 the comparison is done with the Invariant culture.
5471 2003-11-27 Miguel de Icaza <miguel@ximian.com>
5473 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
5474 GetEnumerator method.
5476 (ProbeCollectionType): Iterate starting at the most specific type
5477 upwards looking for a GetEnumerator
5479 * expression.cs: Shift count can be up to 31 for int/uint and 63
5482 2003-11-26 Miguel de Icaza <miguel@ximian.com>
5484 * statement.cs (Block.LookupLabel): Also look for the label on the
5485 children blocks. Use a hash table to keep track of visited
5488 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
5489 we actually did transform the other operand, otherwise fall back
5490 to the common codepath that casts to long.
5492 * cs-tokenizer.cs: Use the same code pattern as the int case.
5493 Maybe I should do the parsing myself, and avoid depending on the
5494 Parse routines to get this done.
5496 2003-11-25 Miguel de Icaza <miguel@ximian.com>
5498 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
5499 which fixes bug 51347. This time test it.
5501 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
5502 attributes for example can not tell the difference between these.
5503 The difference was only a syntax feature of the language.
5505 * attribute.cs: Apply attributes to delegates.
5507 * delegate.cs: Call the apply attributes method.
5509 2003-11-24 Miguel de Icaza <miguel@ximian.com>
5511 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
5512 comparing 0 vs Byte.MinValue, not the value
5514 (ImplicitConversionRequired): When reporting a conversion error,
5515 use error 31 to print out the constant error instead of the
5518 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
5519 which fixes bug 51347.
5521 2003-11-22 Miguel de Icaza <miguel@ximian.com>
5523 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
5524 which fixes the -warnaserror command line option.
5526 2003-11-21 Miguel de Icaza <miguel@ximian.com>
5528 * cfold.cs (DoNumericPromotions): During constant folding of
5529 additions on UIntConstant, special case intconstants with
5530 IntConstants like we do on the expression binary operator.
5532 2003-11-12 Miguel de Icaza <miguel@ximian.com>
5534 * convert.cs (ImplicitReferenceConversion): We were missing a case
5535 (System.Enum are not value types or class types, so we need to
5536 classify them separatedly).
5538 * driver.cs: We do not support error 2007.
5540 2003-11-12 Jackson Harper <jackson@ximian.com>
5542 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
5543 system directory. Also use the full file name so users can
5544 libraries names mscorlib-o-tron.dll in a non system dir.
5546 2004-01-04 David Sheldon <dave-mono@earth.li>
5548 * expression.cs: Added matching ")" to error message for CS0077.
5550 2003-12-19 Martin Baulig <martin@ximian.com>
5552 * typemanager.cs (TypeManager.IsEqualGenericType): New public
5553 static method; see documentation in the method.
5554 (TypeManager.IsSubclassOrNestedChild): Allow IsEqualGenericType().
5556 * convert.cs (Convert.ImplicitReferenceConversion,
5557 Convert.ImplicitReferenceConversionExists): Add support for
5558 generic type declarations; see gen-36.cs.
5560 2003-12-19 Martin Baulig <martin@ximian.com>
5562 * pending.cs (Pending.InterfaceMethod): Use
5563 `Type.IsAssignableFrom()' instead of `=='.
5565 2003-12-18 Martin Baulig <martin@ximian.com>
5567 * decl.cs (DeclSpace.AsAccessible): Check for array, pointer and
5570 * convert.cs (Convert.ImplicitStandardConversionExists): Use
5571 `expr_type.Equals (target_type)' instead of `=='.
5573 2003-12-08 Martin Baulig <martin@ximian.com>
5575 * generics.cs (Constraints.Types): Removed.
5576 (Constraints.Resolve): Just resolve everything to TypeExpr's, not
5578 (Constraints.ResolveTypes): New public method; resolves the
5579 TypeExpr's to Type's.
5580 (TypeParameter.Define): TypeBuilder.DefineGenericParameter() no
5581 longer takes the constraints.
5582 (TypeParameter.DefineMethod): Likewise.
5583 (TypeParameter.DefineType): New public method. Calls
5584 `TypeBuilder/MethodBuilder.SetGenericParameterConstraints()' to set
5587 2003-12-08 Martin Baulig <martin@ximian.com>
5589 * convert.cs (Convert.ImplicitConversionStandard): Use
5590 `expr_type.Equals (target_type)' instead of `=='.
5592 2003-12-08 Martin Baulig <martin@ximian.com>
5594 * typemanager.cs (TypeManager.GetReferenceType): Call
5595 `Type.MakeByRefType ()'.
5597 2003-12-08 Martin Baulig <martin@ximian.com>
5599 * cs-parser.jay, cs-tokenizer.cs: `where' is not a keyword, it
5600 just has some special meaning in some situations. For instance,
5601 it is allowed to use `where' as the name of a variable etc.
5603 2003-12-04 Martin Baulig <martin@ximian.com>
5605 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
5606 `Type.MakeArrayType()' for array types.
5608 2003-11-18 Miguel de Icaza <miguel@ximian.com>
5610 * expression.cs (Invocation.VerifyArgumentsCompat): Remove
5613 (SizeOf.DoResolve): assign the `type_queried' field. This gets
5616 2003-11-16 Martin Baulig <martin@ximian.com>
5618 * codegen.cs (EmitContext.IsGeneric): Removed.
5620 * ecore.cs (SimpleName.ResolveAsTypeStep): Always call
5621 ResolveGeneric() on the DeclSpace.
5623 2003-11-16 Martin Baulig <martin@ximian.com>
5625 * generic.cs (TypeArguments.Resolve):
5626 `Expression.ResolveAsTypeTerminal()' returns a TypeExpr; call
5627 `ResolveType()' on it to get the Type.
5629 2003-11-15 Martin Baulig <martin@ximian.com>
5631 * generic.cs (ConstructedType.GetInterfaces): Override this.
5633 2003-11-14 Martin Baulig <martin@ximian.com>
5635 * interface.cs (Interface.DefineType): Define all type parameters
5636 before adding the interfaces we inherit.
5638 2003-11-11 Martin Baulig <martin@ximian.com>
5640 * generic.cs (ConstructedType.ResolveType): Always call
5641 `gt.BindGenericParameters (atypes)'; also if `args.HasTypeArguments'.
5643 2003-11-10 Martin Baulig <martin@ximian.com>
5645 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
5646 (TypeManager.InitCoreTypes): Initialize them here, but instead of
5647 calling `ResolveType()' on them, directly assign their `Type'.
5649 2003-11-08 Martin Baulig <martin@ximian.com>
5651 * generic.cs (ConstructedType): Override `IsClass' etc.
5653 2003-11-08 Martin Baulig <martin@ximian.com>
5655 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
5656 return value and the `out parent' parameter.
5657 (TypeContainer.DefineType): Moved the CS0644 check into
5658 GetClassBases(). Don't pass the interface types to the
5659 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
5660 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
5662 * ecore.cs (TypeExpr.IsAttribute): New property.
5663 (TypeExpr.GetInterfaces): New method.
5665 * interface.cs (Interface.GetInterfaceTypeByName): Return a
5666 TypeExpr instead of a Type.
5667 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
5668 (Interface.DefineType): Don't pass the interface types to the
5669 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
5670 them later and then call `TypeBulider.AddInterfaceImplementation()'.
5672 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
5673 instead of a `Type[]'.
5674 (TypeManager.RegisterBuilder): Likewise.
5675 (TypeManager.AddUserInterface): Likewise.
5676 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
5677 `Type[]' and also return a `TypeExpr[]'.
5678 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
5680 2003-11-08 Martin Baulig <martin@ximian.com>
5682 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
5685 2003-11-08 Martin Baulig <martin@ximian.com>
5687 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
5688 TypeManager.ResolveExpressionTypes().
5690 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
5691 instead of an Expression.
5692 (TypeExpr): This is now an abstract base class for `TypeExpression'.
5693 (TypeExpression): New public class; formerly known as `TypeExpr'.
5695 * expression.cs (ComposedCast): Derive from TypeExpr.
5697 * typemanager.cs (TypeManager.system_*_expr): These are now
5698 TypExpr's instead of Expression's.
5699 (TypeManager.ResolveExpressionTypes): New public static function;
5700 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
5703 2003-11-06 Miguel de Icaza <miguel@ximian.com>
5705 * expression.cs (New.DoResolve): Do not dereference value that
5706 might be a null return.
5708 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
5709 sure that the constant value has the right type. Fixes an
5710 unreported bug, similar to 50425.
5712 * const.cs (Const.LookupConstantValue): Call
5713 ImplicitStandardConversionExists before doing a conversion to
5714 avoid havng the TypeManager.ChangeType do conversions.
5716 Reduced the number of casts used
5718 (Const.ChangeType): New routine to enable reuse of the constant
5719 type changing code from statement.
5721 * typemanager.cs (ChangeType): Move common initialization to
5722 static global variables.
5726 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
5727 every value type to go through, even if it was void. Fix that.
5729 * cs-tokenizer.cs: Use is_identifier_start_character on the start
5730 character of the define, and the is_identifier_part_character for
5731 the rest of the string.
5733 2003-11-05 Miguel de Icaza <miguel@ximian.com>
5735 * expression.cs (UnaryMutator.EmitCode): When I updated
5736 LocalVariableReference.DoResolve, I overdid it, and dropped an
5737 optimization done on local variable references.
5739 2003-11-04 Miguel de Icaza <miguel@ximian.com>
5741 * ecore.cs: Convert the return from Ldlen into an int.
5743 2003-10-20 Miguel de Icaza <miguel@ximian.com>
5745 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
5746 the accessibility, this is a special case for toplevel non-public
5747 classes (internal for instance).
5749 2003-10-20 Nick Drochak <ndrochak@gol.com>
5751 * ecore.cs: Fix typo and build. Needed another right paren.
5753 2003-10-19 Miguel de Icaza <miguel@ximian.com>
5755 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
5756 `internal' case regular and protected, but not allowing protected
5757 to be evaluated later. Bug 49840
5759 2003-10-15 Miguel de Icaza <miguel@ximian.com>
5761 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
5762 to kb.Nlast, and not the kb.nFirst to isolate the switch
5765 Extract the underlying type, so enumerations of long/ulong are
5766 treated like long/ulong.
5768 2003-10-14 Miguel de Icaza <miguel@ximian.com>
5770 * expression.cs (New): Overload the meaning of RequestedType to
5771 track the possible creation of the NewDelegate type, since
5772 DoResolve is invoked more than once for new constructors on field
5775 See bugs: #48800 and #37014
5777 * cs-parser.jay (declare_local_constants): Take an arraylist
5778 instead of a single constant.
5780 (local_constant_declaration): It should take a
5781 constant_declarators, not a constant_declarator. Fixes 49487
5783 * convert.cs: Fix error report.
5785 2003-10-13 Jackson Harper <jackson@ximian.com>
5787 * typemanager.cs (TypeToCoreType): Add float and double this fixes
5790 2003-11-03 Martin Baulig <martin@ximian.com>
5792 * expression.cs (ArrayAccess.GetStoreOpcode): Added
5793 `out bool has_type_arg'; if set, we need to pass the type to
5795 (ArrayAccess.GetStoreOpcode, ArrayAccess.EmitLoadOpcode): Use
5796 Stelem_Any/Ldelem_Any for generic parameters.
5798 2003-11-02 Martin Baulig <martin@ximian.com>
5800 * expression.cs (Invocation.EmitCall): Use
5801 `TypeManager.IsValueType()' to check whether it's a value type.
5802 Don't set `struct_call' when calling a method on a type parameter.
5804 2003-11-02 Martin Baulig <martin@ximian.com>
5806 * generics.cs (ConstructedType.Resolve): Renamed to ResolveType()
5807 and removed the TypeBuilder argument.
5809 * typemanager.cs (TypeManager.IsValueType): Return
5810 `t.IsGenericParameter || t.IsValueType'.
5812 2003-10-25 Martin Baulig <martin@ximian.com>
5814 * decl.cs (DeclSpace.ResolveType): If we're a ConstructedType,
5815 call ConstructedType.Resolve() on it.
5817 * generic.cs (ConstructedType.Resolve): Set `type' on success.
5819 2003-10-25 Martin Baulig <martin@ximian.com>
5821 * class.cs (TypeContainer.GetClassBases): Changed
5822 `out Type parent' into `out TypeExpr parent'. Moved CS0644 and
5823 CS8214 reporting here.
5824 (TypeContainer.DefineType): GetClassBases() gives us a `TypeExpr'
5825 instead of a `Type' for our parent. In case of a recursive
5826 declaration (see tests/gen-23.cs for an example), our parent is a
5827 ConstructedType and it doesn't have its type set. So, first
5828 create our own TypeBuilder, then call constructed.Resolve() to get
5829 the parent's type and finally TypeBuilder.SetParent() it.
5831 * ecore.cs (TypeExpr.Name): New public virtual property.
5834 (ConstructedType): We're now a TypeExpr and not just an Expression.
5835 (ConstructedType.ResolveAsTypeStep): Don't resolve our type
5836 arguments here; this is done later.
5837 (ConstructedType.Resolve): New public method to resolve the type
5838 arguments and bind them.
5840 2003-10-21 Martin Baulig <martin@ximian.com>
5842 * convert.cs: Use `TypeManager.IsValueType' instead of
5843 'type.IsValueType' everywhere.
5845 * typemanager.cs (TypeManager.IsValueType): Return true for type
5846 parameters. The reason for this is that we need to box a type
5847 parameter when converting it to a reference type.
5849 * cs-parser.jay: Added support for default value expressions.
5851 * generics.cs (DefaultValueExpression): New public class.
5853 2003-10-17 Martin Baulig <martin@ximian.com>
5855 * generic.cs (Constraints.Resolve): Take a DecpSpace instead of a
5856 TypeContainer so we can also use this for Interfaces.
5857 (TypeParameter.Resolve): Likewise.
5859 * interface.cs (Interface.DefineType): Added support for generic
5862 * cs-parser.jay: Added support for generic structs and interfaces.
5864 2003-10-17 Martin Baulig <martin@ximian.com>
5866 * generic.cs (GenericMemberAccess.DoResolve): We can now actually
5867 call generic methods :-)
5869 2003-10-16 Martin Baulig <martin@ximian.com>
5871 * cs-parser.jay (namespace_or_type_name): Only create a
5872 GenericMemberAccess if we actually have type arguments.
5874 2003-10-13 Martin Baulig <martin@ximian.com>
5876 * class.cs (Method.Define): If we're a generic method, call
5877 TypeBuilder.DefineGenericMethod () before resolving
5879 (MethodData): Added .ctor which takes an additional MethodBuilder
5880 argument; this is used for generic methods.
5881 (MethodData.Define): Call `builder.SetGenericMethodSignature()' if
5882 we already have a MethodBuilder.
5884 2003-10-10 Martin Baulig <martin@ximian.com>
5886 * class.cs (Method): Added .ctor which takes a `GenericMethod'
5887 instead of a `DeclSpace'. This is used for generic methods.
5889 * cs-parser.jay (method_header): Added support for generic
5890 methods; create a `GenericMethod' instance and pass it to the
5891 `Method's .ctor; it'll be used as the `DeclSpace' to lookup
5892 parameters and locals.
5894 * decl.cs (DeclSpace.SetParameterInfo): Removed Location argument
5895 since we already have the location. Check whether we're a generic
5896 type declaration or a generic method and create the correct type
5899 * generic.cs (TypeParameter.DefineMethod): New public method.
5900 (GenericMethod): New public class; derives from DeclSpace and is
5901 used for generic methods.
5903 2003-10-09 Martin Baulig <martin@ximian.com>
5905 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
5907 (MethodCore.DoDefineParameters): Removed the TypeContainer
5908 argument; use the DeclSpace which was passed to the .ctor instead.
5909 (MethodCore.CheckParameter): Take a DeclSpace instead of a
5910 TypeContainer; we only need a DeclSpace here.
5912 2003-10-09 Martin Baulig <martin@ximian.com>
5914 * class.cs (MethodData): Added additional `DeclSpace ds' argument
5916 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
5917 EmitContext's .ctor.
5919 2003-10-09 Martin Baulig <martin@ximian.com>
5921 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
5922 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
5923 AsAccessible(), moved them as well.
5925 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
5927 2003-10-07 Miguel de Icaza <miguel@ximian.com>
5929 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
5930 generation for >=, as spotted by Paolo, bug 48679.
5931 Patch from David Waite.
5933 * cs-tokenizer.cs: Add handling for #pragma.
5935 * cs-parser.jay: Allow for both yield and yield return in the
5936 syntax. The anti-cobolization of C# fight will go on!
5938 * class.cs (TypeBuilder.DefineType): Catch error condition here
5939 (Parent.DefineType erroring out and returning null).
5941 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
5942 coping with enumerations variables, we were mistakenly processing
5943 them as a regular value type instead of built-in types. Fixes the
5946 * typemanager.cs (IsBuiltinOrEnum): New method.
5948 2003-09-30 Miguel de Icaza <miguel@ximian.com>
5950 * cs-parser.jay: Upgrade: yield now needs the return clause.
5952 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
5954 * cs-parser.jay : Renamed yyName to yyNames related to jay.
5956 2003-09-29 Martin Baulig <martin@ximian.com>
5958 * typemanager.cs (TypeManager.GetMethodFlags): Added support for
5959 inflated generic methods.
5961 * generics.cs (ConstructedType): Distinguish between open and
5962 closed constructed types; correctly resolve the arguments.
5964 2003-09-22 Martin Baulig <martin@ximian.com>
5966 * generic.cs (ConstructedType.ResolveAsTypeCheck): Check whether
5967 all type arguments meet their constraints.
5969 2003-09-19 Martin Baulig <martin@ximian.com>
5971 * decl.cs (MemberCache.SetupCacheForInterface): Take a
5972 `MemberCache parent' argument. Normally, an interface doesn't
5973 have a parent type except System.Object, but we use this in gmcs
5974 for generic type parameters.
5976 2003-09-18 Martin Baulig <martin@ximian.com>
5978 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
5979 on `type.IsInterface'; don't check whether the type has a parent
5980 to determine whether it's an interface.
5982 2003-09-17 Martin Baulig <martin@ximian.com>
5984 * generic.cs (ConstructedType.ToString): Always use `name' as the
5987 2003-09-15 Martin Baulig <martin@ximian.com>
5989 * cs-parser.jay: Fix grammar wrt. type_parameter_constraints.
5991 * generic.cs (Constraints.Resolve): New public method; this is
5992 called to resolve the constraint types and to check whether all
5993 the constraints are correct.
5994 (Constraints.Types): New public property.
5995 (TypeParameter.Resolve): New public method; resolves all the
5998 * class.cs (TypeContainer.DefineType): Call
5999 TypeParameter.Resolve() before actually defining the type.
6001 2003-09-15 Martin Baulig <martin@ximian.com>
6003 * class.cs (TypeContainer.DefineType): Added an error flag to
6004 avoid reporting duplicate CS0146's ("class definition is
6007 * driver.cs (Driver.MainDriver): Abort if
6008 RootContext.ResolveTree() reported any errors.
6010 2003-09-07 Martin Baulig <martin@ximian.com>
6012 * report.cs (Error, Warning): Added overloaded versions which take
6013 a `params object[] args' and call String.Format().
6015 2003-09-07 Martin Baulig <martin@ximian.com>
6017 * decl.cs (DeclSpace..ctor): Don't call
6018 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
6019 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
6020 (DeclSpace.RecordDecl): New method.
6022 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
6024 2003-09-02 Ravi Pratap <ravi@ximian.com>
6026 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
6027 value attributes to be applied to ParameterBuilders.
6029 * class.cs (MethodCore.LabelParameters): Make static and more
6030 generic so that it can be used from other places - like interface
6031 methods, for instance.
6033 * interface.cs (Interface.Emit): Call LabelParameters before
6034 emitting attributes on the InterfaceMethod.
6036 2003-09-07 Martin Baulig <martin@ximian.com>
6038 * generic.cs (ConstructedType.ResolveAsTypeStep): Report a CS8217
6039 if the number of type parameters doesn't match.
6041 2003-09-04 Martin Baulig <martin@ximian.com>
6043 * expression.cs (ComposedCast.ResolveAsTypeStep): Added support
6044 for arrays of generic type params (ie. `!0[]').
6046 2003-09-04 Martin Baulig <martin@ximian.com>
6048 * class.cs (TypeContainer.AsAccessible): Ignore generic parameters
6051 2003-09-04 Martin Baulig <martin@ximian.com>
6053 * decl.cs (DeclSpace.LookupGeneric): New method.
6054 (DeclSpace.CheckAccessLevel): Ignore generic parameters for the
6057 * generic.cs (TypeParameterExpr): Take a TypeParameter as
6058 argument, not just a string.
6059 (TypeParameter.Define): New public method; this is called to
6060 actually define the generic parameter; after this, you can use the
6061 new `Type' property to get the type.
6063 2003-09-04 Martin Baulig <martin@ximian.com>
6065 * decl.cs (DeclSpace.SetParameterInfo): The `constraints' argument
6066 is now an ArrayList; initialize the result of the `TypeParameters'
6068 (DeclSpace.GetGenericData): Removed.
6069 (DeclSpace.LookupGeneric): Temporarily removed; we need to
6070 implement this in a different way.
6071 (DeclSpace.GetTypeParameters): Removed; there's now a
6072 `TypeParameters' property.
6073 (DeclSpace.TypeParameters): New public property.
6075 * generic.cs (Constraints): Make this class public.
6076 (TypeParameter): New public class.
6078 2003-09-04 Martin Baulig <martin@ximian.com>
6080 * decl.cs (DeclSpace.GetTypeParameters): New method to return the
6083 * class.cs (TypeContainer.DefineType): Call
6084 TypeBuilder.DefineGenericParameter () on all generic parameters if
6085 this is a generic type.
6087 2003-08-28 Martin Baulig <martin@ximian.com>
6089 * sample-stack.il: Compile this with ilasm: "ilasm /dll
6092 * sample-hello.cs: Compile this with gmcs: "gmcs
6093 /r:sample-stack.dll sample-hello.cs".
6095 2003-08-28 Martin Baulig <martin@ximian.com>
6097 * generic.cs (ConstructedType.ResolveAsTypeStep): Actually bind
6098 the parameters to the generic type.
6100 2003-08-28 Martin Baulig <martin@ximian.com>
6102 * cs-tokenizer.cs (parse_less_than): Also allow all builtin types.
6104 2003-08-28 Martin Baulig <martin@ximian.com>
6106 * cs-parser.jay (opt_type_argument_list): Use
6107 `OP_GENERICS_LT type_arguments OP_GENERICS_GT'.
6108 (primary_expression): Replace `qualified_identifier' with `type_name'.
6109 (type_parameter_list): Use `OP_GENERICS_LT type_parameters OP_GENERICS_GT'.
6111 * cs-tokenizer.cs (is_punct): When reading a `<', invoke a custom
6112 parser to check whether it is syntactically a type parameter list;
6113 return OP_GENERICS_LT/OP_GENERICS_GT instead of OP_LT/OP_GT in
6116 2003-08-26 Martin Baulig <martin@ximian.com>
6118 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
6119 resolving aliases; fixes #47927.
6121 2003-08-26 Martin Baulig <martin@ximian.com>
6123 * statement.cs (Using.DoResolve): This is internally emitting a
6124 try/finally clause, so we need to set ec.NeedExplicitReturn if we
6125 do not always return. Fixes #47681.
6127 2003-08-26 Martin Baulig <martin@ximian.com>
6129 * decl.cs (MemberCore): Moved WarningNotHiding(),
6130 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
6132 (AdditionResult): Make this nested in DeclSpace.
6133 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
6134 argument; call NamespaceEntry.Define() unless we're nested in a
6137 * namespace.cs (Namespace.DefineName): New public function. This
6138 is called from DeclSpace's .ctor to add
6139 (Namespace.Lookup): Include DeclSpaces in the lookup.
6141 * class.cs (Operator): Derive from MemberBase, not MemberCore.
6143 * const.cs (Const): Derive from MemberBase, not MemberCore.
6145 2003-08-25 Martin Baulig <martin@ximian.com>
6147 * convert.cs (Convert.ExplicitReferenceConversion): When
6148 converting from an interface type to a class, unbox if the target
6149 type is a struct type. Fixes #47822.
6151 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6153 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
6156 2003-08-22 Martin Baulig <martin@ximian.com>
6158 * class.cs (TypeManager.DefineType): When defining a nested type,
6159 call DefineType() on our parent; fixes #47801.
6161 2003-08-22 Martin Baulig <martin@ximian.com>
6163 * class.cs (MethodData.Define): While checking if a method is an
6164 interface implementation, improve the test a bit more to fix #47654.
6166 2003-08-22 Martin Baulig <martin@ximian.com>
6168 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
6169 correctly; fixes #47722.
6171 2003-08-22 Martin Baulig <martin@ximian.com>
6173 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
6174 LocalVariableReference, ensure it's not read-only. Fixes #47536.
6176 * statement.cs (Fixed.DoResolve): Make all variables read-only.
6178 2003-08-22 Martin Baulig <martin@ximian.com>
6180 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
6181 can only be assigned in static constructors. Fixes #47161.
6183 2003-08-22 Martin Baulig <martin@ximian.com>
6185 Rewrote and improved the flow analysis code.
6187 * flowbranching.cs (FlowBranching): Make this class abstract.
6188 (FlowBranching.CreateBranching): New static function to create a
6190 (FlowBranchingBlock, FlowBranchingException): New classes.
6191 (FlowBranching.UsageVector.Type): New public readonly field.
6192 (FlowBranching.UsageVector.Breaks): Removed the setter.
6193 (FlowBranching.UsageVector.Returns): Removed the setter.
6194 (FlowBranching.UsageVector): Added Break(), Return(),
6195 NeverReachable() and Throw() methods to modify the reachability.
6196 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
6197 done by FlowBranching.Merge().
6198 (FlowBranching.UsageVector.MergeChild): New method; merges the
6199 merge result into the current vector.
6200 (FlowBranching.Merge): New abstract method to merge a branching.
6202 2003-08-12 Martin Baulig <martin@ximian.com>
6204 * expression.cs (Indirection.CacheTemporaries): Create the
6205 LocalTemporary with the pointer type, not its element type.
6207 2003-08-10 Miguel de Icaza <miguel@ximian.com>
6209 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
6210 token was a keyword or not.
6212 Add `error' options where an IDENTIFIER was expected; Provide
6213 CheckToken and CheckIdentifierToken convenience error reporting
6216 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
6218 * decl.cs: Rename `NamespaceEntry Namespace' public field into
6219 NameSpaceEntry NameSpaceEntry.
6221 (LookupInterfaceOrClass): Avoid creating a full qualified name
6222 from namespace and name: avoid doing lookups when we know the
6223 namespace is non-existant. Use new Tree.LookupByNamespace which
6224 looks up DeclSpaces based on their namespace, name pair.
6226 * driver.cs: Provide a new `parser verbose' to display the
6227 exception thrown during parsing. This is turned off by default
6228 now, so the output of a failure from mcs is more graceful.
6230 * namespace.cs: Track all the namespaces defined in a hashtable
6233 (IsNamespace): New method
6235 2003-08-09 Miguel de Icaza <miguel@ximian.com>
6237 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
6238 we know that we need to concatenate (full typename can never be
6243 * statement.cs: Use a bitfield; Do not initialize to null things
6244 which are done by the constructor by default.
6246 * cs-parser.jay: bug fix, parameter was 4, not 3.
6248 * expression.cs: Just use the property;
6250 * statement.cs: No need for GetVariableInfo method.
6252 2003-08-08 Martin Baulig <martin@ximian.com>
6254 * flowanalysis.cs (FlowReturns): This is now nested in the
6255 `FlowBranching' class.
6256 (MyBitVector): Moved this here from statement.cs.
6257 (FlowBranching.SiblingType): New enum type.
6258 (FlowBranching.CreateSibling): Added `SiblingType' argument.
6260 2003-08-07 Martin Baulig <martin@ximian.com>
6262 * flowanalysis.cs (FlowBranchingType): This is now nested in the
6263 `FlowBranching' class and called `BranchingType'.
6265 2003-08-07 Martin Baulig <martin@ximian.com>
6267 * flowanalysis.cs: Moved all the control flow analysis code into
6270 2003-08-07 Martin Baulig <martin@ximian.com>
6272 * assign.cs (Assign.DoResolve): `target' must either be an
6273 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
6276 2003-08-07 Miguel de Icaza <miguel@ximian.com>
6278 * expression.cs (BinaryMethod): This kind of expression is created by the
6279 Binary class if it determines that the operator has to be handled
6282 (BinaryDelegate): This kind of expression is created if we are
6283 dealing with a + or - operator on delegates.
6285 (Binary): remove method, argumetns, and DelegateOperator: when
6286 dealing with methods,
6288 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
6290 * statement.cs (Block): use bitfields for the three extra booleans
6291 we had in use. Remove unused topblock parameter.
6293 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
6295 * assign.cs: Drop extra unneeded tests.
6297 2003-08-06 Miguel de Icaza <miguel@ximian.com>
6299 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
6301 * statement.cs (Foreach): Use VariableStorage instead of
6304 * codegen.cs (VariableStorage): New class used by clients that
6305 require a variable stored: locals or fields for variables that
6306 need to live across yield.
6308 Maybe provide a convenience api for EmitThis+EmitLoad?
6310 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
6313 2003-08-05 Miguel de Icaza <miguel@ximian.com>
6315 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
6316 RemapParameterLValue): New methods that are used to turn a
6317 precomputed FieldInfo into an expression like this:
6321 The idea is to use this instead of making LocalVariableReference
6322 have more than one meaning.
6324 * cs-parser.jay: Add error production to BASE.
6326 * ecore.cs: Deal with TypeManager.GetField returning null, which
6327 is now a valid return value.
6329 (FieldExprNoAddress): New expression for Fields whose address can
6332 * expression.cs (LocalVariableReference): During the resolve
6333 phases, create new expressions if we are in a remapping context.
6334 Remove code that dealt with remapping here.
6336 (ParameterReference): same.
6338 (ProxyInstance): New expression, like the `This' expression, but
6339 it is born fully resolved. We know what we are doing, so remove
6340 the errors that are targeted to user-provided uses of `this'.
6342 * statement.cs (Foreach): our variable is now stored as an
6343 Expression; During resolution, follow the protocol, dont just
6344 assume it will return this.
6346 2003-08-06 Martin Baulig <martin@ximian.com>
6348 * support.cs (SeekableStreamReader.cs): New public class.
6350 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
6351 SeekableStreamReader instead of the normal StreamReader.
6353 2003-08-04 Martin Baulig <martin@ximian.com>
6355 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
6356 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
6357 deambiguate casts and delegate invocations.
6358 (parenthesized_expression): Use the new tokens to ensure this is
6359 not a cast of method invocation.
6361 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
6362 when reading a `)' and Deambiguate_CloseParens () was previously
6365 * expression.cs (ParenthesizedExpression): New class. This is
6366 just used for the CS0075 test.
6367 (Binary.DoResolve): Check for CS0075.
6369 2003-07-29 Ravi Pratap <ravi@ximian.com>
6371 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
6372 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
6373 reference comparison.
6375 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
6376 examine the ReturnType for equality - this is necessary in the
6377 cases of implicit and explicit operators whose signature also
6378 includes the return type.
6380 2003-07-26 Miguel de Icaza <miguel@ximian.com>
6382 * namespace.cs: Cache the result of the namespace computation,
6383 instead of computing it every time.
6385 2003-07-24 Miguel de Icaza <miguel@ximian.com>
6387 * decl.cs: Use a global arraylist that we reuse over invocations
6388 to avoid excesive memory consumption. Reduces memory usage on an
6389 mcs compile by one meg (45 average).
6391 * typemanager.cs (LookupTypeReflection): In .NET pointers are
6392 private, work around that.
6394 2003-07-23 Miguel de Icaza <miguel@ximian.com>
6396 * literal.cs (IntLiteral): Define Zero and One static literals.
6398 * cs-parser.jay (integer_literal): use static literals to reduce
6399 memory usage for the most used literals (0, 1 and -1). 211kb
6400 reduced in memory usage.
6402 Replace all calls to `new ArrayList' with `new
6403 ArrayList(4)' which is a good average number for most allocations,
6404 and also requires only 16 bytes of memory for its buffer by
6407 This reduced MCS memory usage in seven megabytes for the RSS after
6410 2003-07-28 Ravi Pratap <ravi@ximian.com>
6412 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
6413 handle params methods the correct way by forming only one
6414 applicable set with params and normal methods in them. Earlier we
6415 were looking at params methods only if we found no normal methods
6416 which was not the correct thing to do.
6418 (Invocation.BetterFunction): Take separate arguments indicating
6419 when candidate and the best method are params methods in their
6422 This fixes bugs #43367 and #46199.
6424 * attribute.cs: Documentation updates.
6426 (CheckAttribute): Rename to CheckAttributeTarget.
6427 (GetValidPlaces): Rename to GetValidTargets.
6429 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
6430 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
6434 2003-07-28 Miguel de Icaza <miguel@ximian.com>
6436 * codegen.cs: Compute IsGeneric correctly.
6438 * cs-parser.jay: Introduce OP_GENERIC_LT for the grammar ambiguity
6441 Bring back (temporarily) OP_LEFT_SHIFT, OP_RIGHT_SHIFT,
6442 OP_SHIFT_RIGHT_ASSIGN, OP_SHIFT_LEFT_ASSIGN. There were too many
6443 regressions, and I was chasing more bugs than I required.
6445 * interface.cs: Use expressions for base type names (like classes
6446 and structs have been doing for a while now), and resolve that.
6447 This patch should probably go into head as well.
6449 This makes it one less user of FindType.
6451 2003-07-24 Miguel de Icaza <miguel@ximian.com>
6453 This compiler can not self host currently. Need to fix that.
6455 * Makefile: compile to `gmcs.exe'
6457 * driver.cs: Turn on v2 by default on gmcs.
6459 * generic.cs (ConstructedType): Does no longer take a container
6460 type argument; That will be taken care of later.
6462 (ConstructedType.DoResolve, ConstructedType.ResolveAsTypeStep):
6463 Use SimpleName to resolve for now, so we can continue the work on
6464 the parser, until we get Type.GetType that understands generics.
6466 (ConstructedType.ToString): Implement
6468 (TypeArguments.Resolve): Resolve the child expressions as types.
6470 * cs-parser.jay: Rename interface_constraints to
6471 type_parameter_constraints
6473 (namespace_or_type_name): Only use constructed types for the basic
6474 construction, we will deal with identifier<...> later.
6476 (type/type_name): No longer call DecomposeQI, as
6477 namespace_or_type_name is always decoded now.
6479 2003-07-22 Ravi Pratap <ravi@ximian.com>
6481 * expression.cs (Invocation.OverloadResolve): Follow the spec more
6482 closely: we eliminate methods in base types when we have an
6483 applicable method in a top-level type.
6485 Please see section 14.5.5.1 for an exact description of what goes
6488 This fixes bug #45127 and a host of other related to corlib compilation.
6490 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
6491 array is the method corresponding to the top-level type (this is
6492 because of the changes made to icall.c) so we change this
6495 (MethodGroupExpr.Name): This too.
6497 * typemanager.cs (GetElementType): New method which does the right
6498 thing when compiling corlib.
6500 * everywhere: Make use of the above in the relevant places.
6502 2003-07-22 Martin Baulig <martin@ximian.com>
6504 * cs-parser.jay (invocation_expression): Moved
6505 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
6506 `cast_expression', but create a InvocationOrCast which later
6507 resolves to either an Invocation or a Cast.
6509 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
6510 method; call this before EmitStatement() to make sure that this
6511 expression can be used as a statement.
6513 * expression.cs (InvocationOrCast): New class; resolves to either
6514 an Invocation or a Cast.
6516 * statement.cs (StatementExpression): Call ResolveStatement() on
6517 the ExpressionStatement before emitting it.
6519 2003-07-21 Martin Baulig <martin@ximian.com>
6521 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
6522 `ref' and `out' attributes match; fixes #46220.
6523 (MemberAccess.ResolveMemberAccess): You can't reference a type
6524 through an expression; fixes #33180.
6525 (Indexers.GetIndexersForType): Don't return the indexers from
6526 interfaces the class implements; fixes #46502.
6528 2003-07-21 Martin Baulig <martin@ximian.com>
6530 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
6531 CS0661 checks; fixes bug #30442.
6533 2003-07-21 Martin Baulig <martin@ximian.com>
6535 * decl.cs (AdditionResult): Added `Error'.
6537 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
6539 * typemanager.cs (TypeManager.ChangeType): Catch exceptions; makes
6540 cs0031.cs actually work.
6542 2003-07-20 Miguel de Icaza <miguel@ximian.com>
6544 * cs-parser.jay (namespace_name): do not use
6545 namespace_or_type_name, use qualified_identifier, because
6546 namespace_or_type_name will soon return a composed expression
6547 instead of a string.
6549 (namespace_or_type_name): Instead of returning a string, now this
6550 production returns an expression.
6552 * codegen.cs (EmitContext): Setup IsGeneric property based on
6553 whether our DeclSpace is generic, our the method is generic.
6555 * modifier.cs (Modifiers.METHOD_GENERIC): New definition, use if
6556 the method is generic.
6558 * cs-parser.jay (type_arguments, opt_type_argument_list,
6559 type_parameters, type_parameter_list, opt_type_parameter_list,
6560 type_parameter,, opt_type_parameter_constraints_clauses,
6561 type_parameter_constraints_clauses,
6562 type_parameter_constraint_clause, type_parameter_constraint,
6563 interface_constraints): Add new production
6565 * decl.cs (DeclSpace): IsGeneric, flag to track whether this
6566 DeclSpace is generic or not.
6568 (DeclSpace.SetParameterInfo): New routine, used to set the
6569 parameter info for a type.
6571 (DeclSpace.LookupGeneric): Lookups a name, and if it is a generic,
6572 returns a GenericTypeExpr
6574 * ecore.cs (SimpleName.ResolveAsTypeStep): If our container is
6575 generic, lookup the generic argument.
6577 * attribute.cs: Do not allow TypeParameterExpressions in
6580 * class.cs: Do not allow the Main method to be defined in a
6583 * expression.cs (SizeOf): Do not allow generic types to be used as
6584 arguments to sizeof.
6586 * typemanager.cs (IsGeneric): Wrapper for Reflection when we have
6587 it: whether a type is generic or not. Only works for types we are
6588 currently building for now.
6590 2003-07-20 Martin Baulig <martin@ximian.com>
6592 * namespace.cs: Fixed that bug which caused a crash when compiling
6595 2003-07-20 Miguel de Icaza <miguel@ximian.com>
6597 * typemanager.cs (LookupTypeReflection): Never expose types which
6598 are NotPublic, NestedPrivate, NestedAssembly, or
6599 NestedFamANDAssem. We used to return these, and later do a check
6600 that would report a meaningful error, but the problem is that we
6601 would not get the real match, if there was a name override.
6603 2003-07-18 Miguel de Icaza <miguel@ximian.com>
6605 * namespace.cs (Namespace, Name): Do not compute the namespace
6606 name dynamically, compute it in the constructor. This reduced
6607 memory usage by 1697 KB.
6609 * driver.cs: Use --pause to pause at the end.
6611 2003-07-17 Peter Williams <peter@newton.cx>
6613 * Makefile: Change the name of the test target so that it doesn't
6614 conflict with the recursive test target.
6616 2003-07-17 Miguel de Icaza <miguel@ximian.com>
6618 * expression.cs (LocalVariableReference.Emit, EmitAssign,
6619 AddressOf): Do not use EmitThis, that was wrong, use the actual
6622 2003-07-15 Miguel de Icaza <miguel@ximian.com>
6624 * class.cs (MethodData.Define): While checking if a method is an
6625 interface implementation, improve the test: If we are not public
6626 (use new test here: use the computed MethodAttributes directly,
6627 instead of the parsed modifier flags) check if the `implementing'
6628 method comes from an interface or not.
6630 * pending.cs (VerifyPendingMethods): Slightly better error
6633 * makefile: add test target that does the mcs bootstrap.
6635 2003-07-16 Ravi Pratap <ravi@ximian.com>
6637 * interface.cs (Define): Do nothing here since there are no
6638 members to populate etc. Move the attribute emission out of here
6639 since this was just totally the wrong place to put it. Attribute
6640 application happens during the 'Emit' phase, not in the 'Define'
6643 (Emit): Add this method and move the attribute emission here
6645 * rootcontext.cs (EmitCode): Call the Emit method on interface
6648 2003-07-14 Ravi Pratap M <ravi@ximian.com>
6650 * expression.cs (OverloadResolve): Report error only if Location
6651 is not 'Null' which means that there was a probe going on.
6653 2003-07-14 Martin Baulig <martin@ximian.com>
6655 * expression.cs (ConditionalLogicalOperator): New public class to
6656 implement user defined conditional logical operators.
6657 This is section 14.11.2 in the spec and bug #40505.
6659 2003-07-14 Martin Baulig <martin@ximian.com>
6661 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
6663 2003-07-14 Martin Baulig <martin@ximian.com>
6665 * codegen.cs (EmitContext.InFixedInitializer): New public field.
6667 * ecore.cs (IVariable.VerifyFixed): New interface method.
6669 * expression.cs (Unary.ResolveOperator): When resolving the `&'
6670 operator, check whether the variable is actually fixed. Fixes bug
6671 #36055. Set a variable definitely assigned when taking its
6672 address as required by the spec.
6674 * statement.cs (LocalInfo.IsFixed): New field.
6675 (LocalInfo.MakePinned): Set `IsFixed' to true.
6677 2003-07-14 Ravi Pratap M <ravi@ximian.com>
6679 * attribute.cs (Attribute.Resolve): While doing a Member lookup
6680 for .ctors, ensure that we only ask for members declared in the
6681 attribute type (BindingFlags.DeclaredOnly).
6685 * expression.cs (Error_WrongNumArguments): Report error 1501
6686 correctly the way CSC does.
6688 2003-07-13 Martin Baulig <martin@ximian.com>
6690 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
6691 lookup on the fully qualified name, to make things like "X.X" work
6692 where "X.X" is a fully qualified type name, but we also have a
6693 namespace "X" in the using list. Fixes #41975.
6695 2003-07-13 Martin Baulig <martin@ximian.com>
6697 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
6698 function. If we're a CompoundAssign, we need to create an embedded
6699 CompoundAssign, not an embedded Assign.
6700 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
6703 2003-07-13 Martin Baulig <martin@ximian.com>
6705 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
6706 work to fix bug #46088.
6708 2003-07-13 Ravi Pratap <ravi@ximian.com>
6710 * class.cs (Operator.Emit): Do not emit attributes here - it is
6711 taken care of by the Method class that we delegate too. This takes
6714 2003-07-10 Martin Baulig <martin@ximian.com>
6716 * expression.cs (TypeOfVoid): New class.
6717 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
6719 2003-07-10 Martin Baulig <martin@ximian.com>
6721 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
6724 2003-07-10 Martin Baulig <martin@ximian.com>
6726 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
6727 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
6729 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
6731 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
6733 2003-07-10 Martin Baulig <martin@ximian.com>
6735 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
6736 of decimal. Fixes #42850.
6738 NOTE: I also fixed the created byte blob, but this doesn't work on
6739 the MS runtime and csc never produces any byte blobs for decimal
6742 2003-07-10 Martin Baulig <martin@ximian.com>
6744 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
6745 structs; fixes #32068.
6746 (Block.AddChildVariableNames): Fixed #44302.
6748 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6750 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
6752 2003-07-07 Miguel de Icaza <miguel@ximian.com>
6754 * attribute.cs: And this test is onger needed.
6756 2003-07-08 Martin Baulig <martin@ximian.com>
6758 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
6759 inaccessible types. Fixes #36313.
6761 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
6763 * namespace.cs (NamespaceEntry): Create implicit entries for all
6764 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
6765 implicit entries for N1.N2 and N1.
6767 2003-07-08 Martin Baulig <martin@ximian.com>
6769 Rewrote the handling of namespaces to fix a lot of the issues
6770 wrt. `using' aliases etc.
6772 * namespace.cs (Namespace): Splitted this class into a
6773 per-assembly `Namespace' and a per-file `NamespaceEntry'.
6775 * typemanager.cs (TypeManager.IsNamespace): Removed.
6776 (TypeManager.ComputeNamespaces): Only compute namespaces from
6777 loaded assemblies here, not the namespaces from the assembly we're
6778 currently compiling.
6780 2003-07-08 Martin Baulig <martin@ximian.com>
6782 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
6784 2003-07-07 Miguel de Icaza <miguel@ximian.com>
6786 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
6789 I thought about the memory savings here, but LookupTypeReflection
6790 is used under already very constrained scenarios. Compiling
6791 corlib or mcs only exposes one hit, so it would not really reduce
6792 any memory consumption.
6794 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6796 * typemanager.cs: fixes bug #45889 by only adding public types from
6797 other assemblies to the list of known types.
6799 2003-07-07 Miguel de Icaza <miguel@ximian.com>
6801 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
6802 on the type we resolved.
6804 2003-07-05 Martin Baulig <martin@ximian.com>
6806 * pending.cs (PendingImplementation.ParentImplements): Don't
6807 create the proxy if the parent is abstract.
6809 * class.cs (TypeContainer.DefineIndexers): Process explicit
6810 interface implementations first. Fixes #37714.
6812 2003-07-04 Miguel de Icaza <miguel@ximian.com>
6814 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
6815 defined recursively; but since we modify the input parameters
6816 (left is set to `this' temporarily), we reset this value if the
6817 left_is_explicit is false, which gives the original semantics to
6820 * literal.cs (NullPointer): new class used to represent a null
6821 literal in a pointer context.
6823 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
6824 type is a pointer, use a NullPointer object instead of a
6825 NullLiteral. Closes 43687
6827 (ExplicitConversion): Convert pointer values using
6828 the conv opcode to the proper type.
6830 * ecore.cs (New): change ValueTypeVariable property into a method,
6831 that returns whether the valuetype is suitable for being used.
6833 * expression.cs (Binary.DoNumericPromotions): Only return if we
6834 the int constant was a valid uint, and we can return both left and
6835 right as uints. If not, we continue processing, to trigger the
6836 type conversion. This fixes 39018.
6838 * statement.cs (Block.EmitMeta): During constant resolution, set
6839 the CurrentBlock property on the emitcontext, so that we resolve
6840 constants propertly.
6842 2003-07-02 Martin Baulig <martin@ximian.com>
6844 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
6845 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
6847 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
6848 than emitting it here.
6850 * statement.cs: Fixed some more flow analysis bugs.
6852 2003-07-02 Martin Baulig <martin@ximian.com>
6854 * class.cs (MethodData.Define): When implementing interface
6855 methods, set Final unless we're Virtual.
6857 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
6858 check work for interface methods.
6860 2003-07-01 Martin Baulig <martin@ximian.com>
6862 * ecore.cs (EmitContext.This): Replaced this property with a
6863 GetThis() method which takes a Location argument. This ensures
6864 that we get the correct error location for a CS0188.
6866 2003-07-01 Miguel de Icaza <miguel@ximian.com>
6868 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
6869 ImplicitStandardConversion.
6871 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
6873 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
6875 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
6878 2003-06-30 Miguel de Icaza <miguel@ximian.com>
6880 * class.cs (Constructor.Define): Turn off initlocals for unsafe
6883 (MethodData.Define): Turn off initlocals for unsafe methods.
6885 2003-06-29 Miguel de Icaza <miguel@ximian.com>
6887 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
6888 complete; Fixes #37521.
6890 * delegate.cs: Use Modifiers.TypeAttr to compute the
6891 TypeAttributes, instead of rolling our own. This makes the flags
6892 correct for the delegates.
6894 2003-06-28 Miguel de Icaza <miguel@ximian.com>
6896 * class.cs (Constructor.Define): Set the private flag for static
6897 constructors as well.
6899 * cs-parser.jay (statement_expression): Set the return value to
6900 null, to avoid a crash when we catch an error.
6902 2003-06-24 Miguel de Icaza <miguel@ximian.com>
6904 * cs-parser.jay: Applied patch from Jackson that adds support for
6905 extern and unsafe modifiers to destructor declarations.
6907 * expression.cs: Report error 21 if the user is trying to index a
6910 * driver.cs: Add an error message, suggested by the bug report.
6912 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
6913 if we do not have a ": this ()" constructor initializer. Fixes 45149
6915 2003-06-14 Miguel de Icaza <miguel@ximian.com>
6917 * namespace.cs: Add some information to reduce FAQs.
6919 2003-06-13 Miguel de Icaza <miguel@ximian.com>
6921 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
6922 underlying enumeration types. Fixes #43915.
6924 * expression.cs: Treat ushort/short as legal values to be used in
6927 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
6929 * delegate.cs: transfer custom attributes for paramenters from
6930 the delegate declaration to Invoke and BeginInvoke.
6932 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
6934 * attribute.cs: handle custom marshalers and emit marshal info
6937 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
6939 * makefile.gnu: Added anonymous.cs to the compiler sources.
6941 2003-05-28 Miguel de Icaza <miguel@ximian.com>
6943 * iterators.cs: Change the name of the proxy class to include two
6946 * cs-parser.jay: Update grammar to include anonymous methods.
6948 * anonymous.cs: new file.
6950 2003-05-27 Miguel de Icaza <miguel@ximian.com>
6952 * class.cs (Field.Define): Add missing test for pointers and
6955 2003-05-27 Ravi Pratap <ravi@ximian.com>
6957 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
6958 we use the stobj opcode.
6960 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
6961 since it wasn't the correct fix.
6963 It still is puzzling that we are required to use stobj for IntPtr
6964 which seems to be a ValueType.
6966 2003-05-26 Miguel de Icaza <miguel@ximian.com>
6968 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
6969 during regular simple name resolution. Now, the trick is that
6970 instead of returning for processing the simplename, we do a
6971 TypeManager.LookupType (ie, a rooted lookup as opposed to a
6972 contextual lookup type). If a match is found, return that, if
6973 not, return for further composition.
6975 This fixes long-standing 30485.
6977 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
6978 using the address to initialize an object, do an Stobj instead of
6979 using the regular Stelem.
6981 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
6982 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
6983 Because if we are a BaseIndexerAccess that value will be true.
6986 * statement.cs (GotoCase.Resolve): Return after reporting an
6987 error, do not attempt to continue.
6989 * expression.cs (PointerArithmetic.Emit): If our operand is a
6990 long, convert our constants to match the operand before
6991 multiplying. Convert to I type before adding. Fixes 43670.
6993 2003-05-14 Ravi Pratap <ravi@ximian.com>
6995 * enum.cs (ImplicitConversionExists) : Rename to
6996 ImplicitEnumConversionExists to remove ambiguity.
6998 * ecore.cs (NullCast): New type of cast expression class which
6999 basically is very similar to EmptyCast with the difference being
7000 it still is a constant since it is used only to cast a null to
7004 * convert.cs (ImplicitReferenceConversion): When casting a null
7005 literal, we return a NullCast.
7007 * literal.cs (NullLiteralTyped): Remove - I don't see why this
7008 should be around anymore.
7010 The renaming (reported was slightly wrong). Corrections:
7012 ConvertImplicitStandard -> ImplicitConversionStandard
7013 ConvertExplicitStandard -> ExplicitConversionStandard
7015 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
7016 before passing them in !
7018 * convert.cs (ImplicitConversionStandard): When comparing for
7019 equal expr and target types, ensure that expr is not a
7022 In general, we must not be checking (expr_type ==
7023 target_type) in the top level conversion methods
7024 (ImplicitConversion, ExplicitConversion etc). This checking is
7025 done in the methods that they delegate to.
7027 2003-05-20 Miguel de Icaza <miguel@ximian.com>
7029 * convert.cs: Move Error_CannotConvertType,
7030 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
7031 ImplicitNumericConversion, ImplicitConversionExists,
7032 ImplicitUserConversionExists, StandardConversionExists,
7033 FindMostEncompassedType, FindMostSpecificSource,
7034 FindMostSpecificTarget, ImplicitUserConversion,
7035 ExplicitUserConversion, GetConversionOperators,
7036 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
7037 TryImplicitIntConversion, Error_CannotConvertImplicit,
7038 ConvertImplicitRequired, ConvertNumericExplicit,
7039 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
7040 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
7043 Perform the following renames:
7045 StandardConversionExists -> ImplicitStandardConversionExists
7046 ConvertImplicit -> ImplicitConversion
7047 ConvertImplicitStandard -> ImplicitStandardConversion
7048 TryImplicitIntConversion -> ImplicitIntConversion
7049 ConvertImplicitRequired -> ImplicitConversionRequired
7050 ConvertNumericExplicit -> ExplicitNumericConversion
7051 ConvertReferenceExplicit -> ExplicitReferenceConversion
7052 ConvertExplicit -> ExplicitConversion
7053 ConvertExplicitStandard -> ExplicitStandardConversion
7055 2003-05-19 Martin Baulig <martin@ximian.com>
7057 * statement.cs (TypeInfo.StructInfo): Made this type protected.
7058 (TypeInfo): Added support for structs having structs as fields.
7060 * ecore.cs (FieldExpr): Implement IVariable.
7061 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
7062 VariableInfo for the field.
7064 2003-05-18 Martin Baulig <martin@ximian.com>
7066 * expression.cs (This.DoResolve): Report a CS0027 if we're
7067 emitting a field initializer.
7069 2003-05-18 Martin Baulig <martin@ximian.com>
7071 * expression.cs (This.ResolveBase): New public function.
7072 (This.DoResolve): Check for CS0188.
7074 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
7077 * ecore.cs (MethodGroupExpr.DoResolve): Set the
7078 `instance_expression' to null if we don't have any non-static
7081 2003-05-18 Martin Baulig <martin@ximian.com>
7083 Reworked the way how local variables and parameters are handled by
7084 the flow analysis code.
7086 * statement.cs (TypeInfo, VariableMap): New public classes.
7087 (VariableInfo): New public class. This is now responsible for
7088 checking whether a variable has been assigned. It is used for
7089 parameters and local variables.
7090 (Block.EmitMeta): Take the InternalParameters as argument; compute
7091 the layout of the flow vectors here.
7092 (Block.LocalMap, Block.ParameterMap): New public properties.
7093 (FlowBranching): The .ctor doesn't get the InternalParameters
7094 anymore since Block.EmitMeta() now computes the layout of the flow
7096 (MyStructInfo): This class is now known as `StructInfo' and nested
7097 in `TypeInfo'; we don't access this directly anymore.
7099 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
7100 property and removed IsAssigned(), IsFieldAssigned(),
7101 SetAssigned() and SetFieldAssigned(); we now call them on the
7102 VariableInfo so we don't need to duplicate this code everywhere.
7104 * expression.cs (ParameterReference): Added `Block block' argument
7106 (LocalVariableReference, ParameterReference, This): The new
7107 VariableInfo class is now responsible for all the definite
7110 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
7111 IsParameterAssigned, SetParameterAssigned): Removed.
7113 2003-05-18 Martin Baulig <martin@ximian.com>
7115 * typemanager.cs (InitCoreTypes): Try calling
7116 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
7117 the 3-args-version. Corlib now also needs our `void_type'.
7118 (GetMethod): Added overloaded version which takes an optional
7119 `bool report_errors' to allow lookups of optional methods.
7121 2003-05-12 Martin Baulig <martin@ximian.com>
7123 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
7124 only used for locals and not for parameters.
7126 2003-05-12 Miguel de Icaza <miguel@ximian.com>
7128 * support.cs (InternalParameters.ParameterType): Return the
7129 ExternalType of the parameter.
7131 * parameter.cs (Parameter.ExternalType): drop the two arguments,
7134 2003-05-11 Miguel de Icaza <miguel@ximian.com>
7136 * class.cs (MethodData.Define): Do not set the `newslot' on
7137 interface members, if they are also flagged as "override".
7139 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
7140 better code for ++i and i++. This only works for static fields
7141 and local variables.
7143 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
7144 want to pull the DeclSpace out of the builder_to_declspace instead
7145 of the TypeBuilder (like in TypeContainer.FindMembers).
7147 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
7148 instead of LookupTypeContainer. Fixes the crash on .NET for
7149 looking up interface members.
7151 * const.cs: Create our own emit context during the Definition
7152 stage, so that constants are evaluated in the proper context, when
7153 a recursive definition happens.
7155 2003-05-11 Martin Baulig <martin@ximian.com>
7157 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
7158 new block for a switch section.
7159 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
7160 the adding/lookup in the switch block. Fixes #39828.
7162 2003-05-09 Miguel de Icaza <miguel@ximian.com>
7164 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
7165 functionality: I needed to convert the data after I had performed
7166 the add/sub operation into the operands type size.
7168 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
7169 pass the type for the box operation, otherwise the resulting
7170 object would have been of type object.
7172 (BoxedCast): Add constructor to specify the type to box as.
7174 2003-05-07 Miguel de Icaza <miguel@ximian.com>
7176 * iterators.cs: I was reusing the `count' variable inadvertently,
7177 take steps to not allow this to happen.
7179 2003-05-06 Miguel de Icaza <miguel@ximian.com>
7181 * attribute.cs (Attribute.Resolve): Params attributes are encoded
7182 by creating an array at the point where the params starts and
7183 putting all those arguments there, then adjusting the size of the
7186 2003-05-05 Miguel de Icaza <miguel@ximian.com>
7188 * expression.cs (New.AddressOf): Implement interface
7189 IMemoryLocation. This is used when the `new' operator is used in
7190 the context of an invocation to a method on a value type.
7192 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
7195 * namespace.cs: Also check the using aliases here.
7197 * driver.cs: Move the test for using validity after the types have
7198 been entered, so we do a single pass that also includes the using
7201 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
7202 in the regular case. CreateSiblingForFinally is doing extra
7205 * attribute.cs (GetAttributeArgumentExpression): Store the result
7206 on an out value, and use the return value to indicate failure
7207 instead of using null (which is a valid return for Constant.GetValue).
7209 * statement.cs: Perform the analysis flow for the increment
7210 portion after the statement, because this will be the real flow of
7211 execution. Fixes #42385
7213 * codegen.cs (EmitContext.EmitArgument,
7214 EmitContext.EmitStoreArgument): New helper functions when the
7215 RemapToProxy flag is set.
7217 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
7220 Add support for remapping parameters.
7222 * iterators.cs: Propagate parameter values; Store parameter
7223 values in the proxy classes.
7225 2003-05-04 Miguel de Icaza <miguel@ximian.com>
7227 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
7228 need a proxy reference; I do not know what I was thinking
7230 * cs-parser.jay (constructor_initializer): catch another error,
7231 and display nice message.
7233 (field_declaration): catch void field declaration
7234 to flag a better error.
7236 * class.cs (MemberBase.CheckBase): Report an error instead of a
7237 warning if a new protected member is declared in a struct.
7238 (Field.Define): catch the error of readonly/volatile.
7240 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
7242 (FieldExpr.AddressOf): ditto. Catch error where the address of a
7243 volatile variable is taken
7245 2003-05-02 Miguel de Icaza <miguel@ximian.com>
7247 * statement.cs (Fixed.Resolve): Report an error if we are not in
7250 2003-05-01 Miguel de Icaza <miguel@ximian.com>
7252 * typemanager.cs: reuse the code that handles type clashes for
7253 delegates and enumerations.
7255 * class.cs (Report28): Always report.
7257 * expression.cs (EncodeAsAttribute): Allow nulls here.
7259 2003-04-28 Miguel de Icaza <miguel@ximian.com>
7261 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
7262 the functionality for testing whether an expression is valid for
7263 an attribute here. Also handle the case of arrays of elements
7266 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
7267 encoding a linear array into an array of objects that are suitable
7268 to be passed to an CustomAttributeBuilder.
7270 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
7272 * ecore.cs: (FieldExpr): Handle field remapping here.
7274 * iteratators.cs: Pass the instance variable (if the method is an
7275 instance method) to the constructors, so we can access the field
7276 variables on the class.
7278 TODO: Test this with structs. I think the THIS variable on
7279 structs might have to be a pointer, and not a refenrece
7281 2003-04-27 Miguel de Icaza <miguel@ximian.com>
7283 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
7284 local variables to fields in a proxy class.
7286 * iterators.cs (PopulateProxy): Rename our internal fields to
7288 Create a <THIS> field if we are an instance method, so we can
7289 reference our parent container variables.
7290 (MapVariable): Called back from the EmitContext code to enter a
7291 new variable to field mapping into the proxy class (we just create
7295 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
7296 for using the remapped locals to fields.
7298 I placed the code here, because that gives the same semantics to
7299 local variables, and only changes the Emit code.
7301 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
7302 statements inside iterators.
7303 (VariableInfo): Add a FieldBuilder for the cases when we are
7304 remapping local variables to fields in a proxy class
7306 * ecore.cs (SimpleNameResolve): Avoid testing two times for
7307 current_block != null.
7309 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
7310 not cope with strings, as it has been moved to the
7311 TableSwitchEmit. Fixed bug in switch generation.
7313 * expression.cs (New.DoResolve): Provide more context for the user
7314 when reporting an error.
7316 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
7319 * expression.cs (MemberAccess.DoResolve): When we get a type back,
7320 check the permissions for it. Note than in a type-resolution
7321 context the check was already present in DeclSpace.ResolveType,
7322 but was missing from the MemberAccess.
7324 (ArrayCreation.CheckIndices): warn if the user has
7325 more nested levels of expressions, but there are no more
7326 dimensions specified. Avoids crash on bug 41906.
7328 2003-04-26 Miguel de Icaza <miguel@ximian.com>
7330 * statement.cs (Block): replace Implicit bool, for a generic
7332 New flag: `Unchecked'. This is used during the EmitMeta phase
7333 (which is out-of-line with the regular Resolve/Emit process for a
7334 statement, as this is done ahead of time, but still gets a chance
7335 to call constant resolve).
7337 (Block.Flags): new enum for adding a new flag.
7339 (Block.EmitMeta): track the state of unchecked.
7341 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
7342 to enable constant resolution to work there as well.
7344 2003-04-22 Miguel de Icaza <miguel@ximian.com>
7346 * typemanager.cs (ienumerable_type): Also look up
7347 System.Collections.IEnumerable.
7349 2003-04-21 Miguel de Icaza <miguel@ximian.com>
7351 TODO: Test more than one conditional per method.
7353 * class.cs (Indexer.Define): Report the location where the user is
7354 referencing the unsupported feature.
7356 (MethodData): Overload the use of `conditionals' to
7357 minimize the creation of needless ArrayLists. This saves roughly
7358 212kb on my machine.
7360 (Method): Implement the new IIteratorContainer interface.
7361 (Method.SetYields): Implement the method by setting the ModFlags
7362 to contain METHOD_YIELDS.
7364 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
7365 which just got set to null.
7367 * iterators.cs: New file.
7369 (Yield, YieldBreak): New statements.
7371 * statement.cs (Return.Resolve): Flag an error if we are used in
7374 * codegen.cs (InIterator): New flag set if the code is being
7375 compiled in an iterator method.
7377 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
7378 internal modifier, and we just use it to avoid adding extra
7379 fields, as this is seldom used.
7381 * cs-parser.jay: Add yield_statement (yield and yield break).
7383 * driver.cs: New flag -v2 to turn on version 2 features.
7385 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
7386 hashtable when v2 is enabled.
7388 2003-04-20 Miguel de Icaza <miguel@ximian.com>
7390 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
7391 there is already a namespace defined with this name.
7393 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
7394 people upgraded their corlibs.
7396 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
7397 always use fully qualified types, no need to use the compiler
7400 (TypeManager.IsNamespace): Use binarysearch.
7402 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
7403 AddDelegate): I did not quite use the new IsValid API properly: I
7404 have to pass the short-name and the fullname. I was passing only
7405 the basename instead of the fullname sometimes.
7407 (TypeContainer.DefineType): call NamespaceClash.
7409 * interface.cs (Interface.DefineType): use NamespaceClash before
7412 * delegate.cs (Delegate.DefineType): use NamespaceClash before
7415 * enum.cs: (Enum.DefineType): use NamespaceClash before
7418 * typemanager.cs (: 3-line patch that gives us some tasty 11%
7419 speed increase. First, use the negative_hits cache when we get a
7420 negative. Second, add the type with its full original name
7421 instead of the new . and + encoded name (reflection uses + to
7422 separate type from a nested type). Use LookupTypeReflection
7423 directly which bypasses the type->name hashtable (that we already
7424 know does not contain the type.
7426 * decl.cs (DeclSpace.ResolveTypeExpr): track the
7427 location/container type.
7429 * driver.cs: When passing utf8, use directly the UTF8Encoding.
7431 2003-04-19 Miguel de Icaza <miguel@ximian.com>
7433 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
7435 * delegate.cs (NewDelegate.Resolve): Test whether an instance
7436 method is being referenced in the method group from a static
7437 context, and report error 120 if so.
7439 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
7442 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
7443 is created, we create the A namespace).
7445 * cs-parser.jay: A namespace also introduces a DeclarationFound.
7448 2003-04-18 Miguel de Icaza <miguel@ximian.com>
7450 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
7451 invocation to ModuleBuilder.GetType with the same values will
7452 return a new type instance, so we need to cache its return
7455 * expression.cs (Binary.ResolveOperator): Only allow the compare
7456 operators on enums if they are of the same type.
7458 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
7459 types of ValueType on their own case. Before we were giving them
7460 the same treatment as objects.
7462 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
7463 fullname. Short name is used to compare against container name.
7464 Fullname is used to check against defined namespace names.
7466 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
7467 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
7469 (Method.CheckBase): Call parent.
7470 (MemberBase.CheckBase): Check for protected members on sealed
7472 (PropertyBase.CheckBase): Call parent.
7473 (Field.Define): Call parent.
7475 * report.cs: Negative error codes are now mapped to 8000 - code,
7476 so that the display is render more nicely.
7478 * typemanager.cs: Do not use try/catch, instead report a regular
7481 (GetPointerType, GetReferenceType): These methods provide
7482 mechanisms to obtain the T* and T& from a T. We had the code
7483 previously scattered around the code base, and it also used
7484 TypeManager.LookupType that would go through plenty of caches.
7485 This one goes directly to the type source.
7487 In some places we did the Type.GetType followed by
7488 ModuleBuilder.GetType, but not in others, so this unifies the
7491 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
7492 statements now that we have namespace information.
7494 * typemanager.cs (IsNamespace): New method, returns whether the
7495 string presented is a namespace or not.
7497 (ComputeNamespaces): New public entry point, computes the list of
7498 available namespaces, using the GetNamespaces API call in Mono, or
7499 the slower version in MS.NET.
7501 Now before we start the semantic analysis phase, we have a
7502 complete list of namespaces including everything that the user has
7505 Deleted old code to cache namespaces in .nsc files.
7507 2003-04-17 Miguel de Icaza <miguel@ximian.com>
7509 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
7510 class/struct location definition Location for the implicit
7511 constructor location.
7513 (Operator.Define): Use the location of the operator for the
7514 implicit Method definition.
7516 (Constructor.Emit): use the constructor location for the implicit
7517 base initializer constructor.
7519 * ecore.cs: Remove ITypeExpression. This interface is now gone,
7520 and the Expression class now contains two new methods:
7522 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
7523 isolate type lookup from the rest of the resolution process.
7525 Since we use Expressions to hold type definitions due to the way
7526 we parse the input we have historically overloaded Resolve to
7527 perform the Type lookups if a special flag is passed. Now this is
7528 eliminated and two methods take their place.
7530 The differences in the two methods between xStep and xTerminal is
7531 that xStep is involved in our current lookup system that uses
7532 SimpleNames to compose a name, while xTerminal is used just to
7533 catch the case where the simplename lookup failed.
7535 2003-04-16 Miguel de Icaza <miguel@ximian.com>
7537 * expression.cs (ResolveMemberAccess): Remove redundant code.
7538 TypeExpr expressions are always born fully resolved.
7540 * interface.cs (PopulateMethod): Do not lookup the types twice.
7541 We were doing it once during SemanticAnalysis and once during
7544 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
7545 in local variable type definitions, were being returned as a
7546 SimpleName (we decomposed everything into a string), that is
7547 because primary_expression was being used instead of a type in the
7548 grammar (reduce/reduce conflicts).
7550 The part that was wrong is that we converted the expression into a
7551 string (an oversimplification in one hand, compounded with primary
7552 expressions doing string concatenation).
7558 Would return "A.B.C[]" as a SimpleName. This stopped things like
7559 using clauses from working on this particular context. And a type
7560 was being matched directly against "A.B.C[]".
7562 We now use the correct approach, and allow for ComposedCast to be
7563 part of the unary expression. So the "A.B.C []" become a composed
7564 cast of "A.B.C" (as a nested group of MemberAccess with a
7565 SimpleName at the end) plus the rank composition "[]".
7569 2003-04-10 Miguel de Icaza <miguel@ximian.com>
7571 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
7572 for the access level checking.
7574 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
7575 `TypeContainer container', because I kept getting confused when I
7576 was debugging this code.
7578 * expression.cs (Indexers): Instead of tracking getters/setters,
7579 we now track them in parallel. We create one arraylist less, but
7580 most importantly it is possible now for the LValue code to find a
7581 matching get for a set.
7583 (IndexerAccess.DoResolveLValue): Update the code.
7584 GetIndexersForType has been modified already to extract all the
7585 indexers from a type. The code assumed it did not.
7587 Also make the code set the correct return type for the indexer.
7588 This was fixed a long time ago for properties, but was missing for
7589 indexers. It used to be void_type.
7591 (Binary.Emit): Test first for doubles instead of
7592 floats, as they are more common.
7594 (Binary.EmitBranchable): Use the .un version of the branch opcodes
7595 when dealing with floats and the <=, >= operators. This fixes bug
7598 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
7599 to load the array value by emitting a load on the foreach variable
7600 type. This was incorrect.
7602 We now emit the code to load an element using the the array
7603 variable type, and then we emit the conversion operator.
7607 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
7609 * attribute.cs: Avoid allocation of ArrayLists in the common case.
7611 2003-04-09 Miguel de Icaza <miguel@ximian.com>
7613 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
7614 test for protection before we test for signatures.
7616 (MethodSignature.ToString): implement.
7618 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
7619 to the case where we reduced into a LongConstant.
7621 * decl.cs (CheckAccessLevel): If the type is an array, we can not
7622 depend on whether the information is acurrate, because the
7623 Microsoft runtime will always claim that the array type is public,
7624 regardless of the real state.
7626 If the type is a pointer, another problem happens: the type is
7627 reported as non-public in Microsoft.
7629 In both cases we have to call CheckAccessLevel recursively with
7630 the underlying type as the argument to be tested.
7632 2003-04-08 Miguel de Icaza <miguel@ximian.com>
7634 * assign.cs (Assign.Emit): If we are dealing with a compound
7635 assignment expression, we should use the code path that stores the
7636 intermediate result in a temporary value. This fixes #40903.
7638 *expression.cs (Indirection.ToString): Provide ToString method for
7641 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
7643 * class.cs: Null out fields holding references to Block objects so
7644 they can be garbage collected.
7646 * expression.cs (OverloadResolve): Remove unused local.
7648 2003-04-07 Martin Baulig <martin@ximian.com>
7650 * codegen.cs (EmitContext.CurrentFile): New public field.
7651 (EmitContext.Mark): Use the CurrentFile to check whether the
7652 location is in the correct file.
7653 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
7655 2003-04-07 Martin Baulig <martin@ximian.com>
7657 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
7659 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
7660 location. [FIXME: The location argument which gets passed to this
7661 method is sometimes wrong!]
7663 2003-04-07 Nick Drochak <ndrochak@gol.com>
7665 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
7667 2003-04-07 Miguel de Icaza <miguel@ximian.com>
7669 * expression.cs (Indirection.EmitAssign): We were using the
7670 temporary, but returning immediately instead of continuing the
7673 2003-04-06 Martin Baulig <martin@ximian.com>
7675 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
7676 if it's a nested child, but also deriving from the outer class.
7679 * typemanager.cs (IsNestedChildOf): Make this work if it's a
7680 nested child, but also deriving from the outer class. See
7682 (FilterWithClosure): We may access private members of the outer
7683 class if we're a nested child and deriving from the outer class.
7684 (RealMemberLookup): Only set `closure_private_ok' if the
7685 `original_bf' contained BindingFlags.NonPublic.
7687 2003-04-05 Martin Baulig <martin@ximian.com>
7689 * expression.cs (SizeOf.DoResolve): Use ResolveTypeExpr, so we can
7690 probe if its a type parameter, and if so, flag an error.
7692 * decl.cs: Move here the SetParameterInfo code from class.cs.
7693 Handle IsGeneric here.
7695 Handle a variety of errors in the parameter info definition.
7697 * ecore.cs (SimpleName.DoResolveType): Handle look ups for generic
7698 type parameters here.
7700 * cs-parser.jay (class_declaration): report errors for parameters
7703 2003-01-21 Miguel de Icaza <miguel@ximian.com>
7705 * generic.cs: New file, contains support code for generics.
7707 * cs-parser.jay: Remove OP_SHIFT_LEFT, OP_SHIFT_RIGHT,
7708 OP_SHIFT_LEFT_ASSIGN, OP_SHIFT_RIGHT_ASSIGN.
7710 Update parser for the above removals.
7712 * cs-tokenizer.cs: Do not handle <<= or >>= specially. This is
7713 now taken care of in the parser.
7715 2003-04-02 Miguel de Icaza <miguel@ximian.com>
7717 * class.cs (Event.Define): Do not allow abstract events to have
7720 2003-04-01 Miguel de Icaza <miguel@ximian.com>
7722 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
7723 block in event declarations.
7725 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
7726 value type, get its address.
7728 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
7729 leaving a class on the stack instead of a boolean value (int
7730 0/1). Change the code so we compare against null, and then the
7731 result against zero.
7733 * class.cs (TypeContainer.GetClassBases): We were checking for the
7734 parent class being sealed too late.
7736 * expression.cs (Binary.Emit): For <= and >= when dealing with
7737 floating point values, use cgt.un and clt.un instead of cgt and
7740 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
7742 * statement.cs: Apply the same optimization as MS: skip the
7743 GetEnumerator returning an IEnumerator, and use the one returning a
7744 CharEnumerator instead. This allows us to avoid the try-finally block
7747 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
7749 * cs-parser.jay: Attributes cannot be applied to
7750 namespaces. Fixes #40473
7752 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7755 (Add*): check if the name is valid using the full name for constants,
7756 fields, properties and events.
7758 2003-03-28 Miguel de Icaza <miguel@ximian.com>
7760 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
7761 char constants to be part of the enumeration.
7763 * expression.cs (Conditional.DoResolve): Add support for operator
7764 true. Implements the missing functionality from 14.12
7766 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
7767 operator true/false as required by the spec.
7769 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
7770 implicit conversion to boolean.
7772 * statement.cs (Statement.ResolveBoolean): A boolean expression is
7773 also one where the type implements `operator true'.
7775 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
7776 get an expression that will invoke operator true based on an
7779 (GetConversionOperators): Removed the hack that called op_True
7782 (Expression.ResolveBoolean): Move this from Statement.
7784 2003-03-17 Miguel de Icaza <miguel@ximian.com>
7786 * ecore.cs (FieldExpr): do not allow initialization of initonly
7787 fields on derived classes
7789 2003-03-13 Martin Baulig <martin@ximian.com>
7791 * statement.cs (Block.Emit): Call ig.BeginScope() and
7792 ig.EndScope() when compiling with debugging info; call
7793 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
7795 2003-03-08 Miguel de Icaza <miguel@ximian.com>
7797 * expression.cs (Indexers): Do not construct immediately, allow
7798 for new members to be appended as we go. Fixes 38143
7800 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7802 * expression.cs: save/restore context when resolving an unchecked
7805 2003-03-05 Miguel de Icaza <miguel@ximian.com>
7807 * cfold.cs: Catch division by zero in modulus operator during
7810 2003-03-03 Miguel de Icaza <miguel@ximian.com>
7812 * interface.cs (Interface.DefineMembers): Avoid defining members
7815 2003-02-27 Miguel de Icaza <miguel@ximian.com>
7817 * driver.cs: handle the +/- options for -noconfig
7819 * statement.cs (Unckeched.Resolve): Also track the state of
7820 unchecked in the Resolve phase.
7822 2003-02-27 Martin Baulig <martin@ximian.com>
7824 * ecore.cs (Expression.MemberLookup): Don't create a
7825 MethodGroupExpr for something which is not a method. Fixes #38291.
7827 2003-02-25 Miguel de Icaza <miguel@ximian.com>
7829 * class.cs (MemberBase.CheckParameters): Also check that the type
7830 is unmanaged if it is a pointer.
7832 * expression.cs (SizeOf.Resolve): Add location information.
7834 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
7835 a managed type is declared.
7837 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
7838 parameter modifiers as well. Fixes bug 38606
7840 * class.cs: Very sad. Am backing out the speed up changes
7841 introduced by the ArrayList -> Array in the TypeContainer, as they
7842 were not actually that much faster, and introduced a bug (no error
7843 reports on duplicated methods).
7845 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
7846 source first, this will guarantee that we have a valid expression
7847 before calling in lower levels functions that will require a
7848 resolved object. Then use this original_source in the
7849 target.ResolveLValue instead of the original source that was
7852 Another change. Use target.Resolve instead of LValueResolve.
7853 Although we are resolving for LValues, we will let the Assign code
7854 take care of that (it will be called again from Resolve). This
7855 basically allows code like this:
7857 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
7858 class Y { void A (X x) { x [0] += o; }
7860 The problem was that the indexer was trying to resolve for
7861 set_Item (idx, object o) and never finding one. The real set_Item
7862 was set_Item (idx, X). By delaying the process we get the right
7867 2003-02-23 Martin Baulig <martin@ximian.com>
7869 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
7870 while calling DoEmit ().
7872 * codegen.cs (EmitContext.Mark): Don't mark locations in other
7873 source files; if you use the #line directive inside a method, the
7874 compiler stops emitting line numbers for the debugger until it
7875 reaches the end of the method or another #line directive which
7876 restores the original file.
7878 2003-02-23 Martin Baulig <martin@ximian.com>
7880 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
7882 2003-02-23 Martin Baulig <martin@ximian.com>
7884 * statement.cs (Block.AddChildVariableNames): We need to call this
7885 recursively, not just for our immediate children.
7887 2003-02-23 Martin Baulig <martin@ximian.com>
7889 * class.cs (Event.Define): Always make the field private, like csc does.
7891 * typemanager.cs (TypeManager.RealMemberLookup): Make events
7892 actually work, fixes bug #37521.
7894 2003-02-23 Miguel de Icaza <miguel@ximian.com>
7896 * delegate.cs: When creating the various temporary "Parameters"
7897 classes, make sure that we call the ComputeAndDefineParameterTypes
7898 on those new parameters (just like we do with the formal ones), to
7899 allow them to be resolved in the context of the DeclSpace.
7901 This fixes the bug that Dick observed in Bugzilla #38530.
7903 2003-02-22 Miguel de Icaza <miguel@ximian.com>
7905 * expression.cs (ResolveMemberAccess): When resolving a constant,
7906 do not attempt to pull a constant if the value was not able to
7907 generate a valid constant.
7909 * const.cs (LookupConstantValue): Do not report more errors than required.
7911 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7913 * expression.cs: fixes bug #38328.
7915 2003-02-18 Miguel de Icaza <miguel@ximian.com>
7917 * class.cs: Changed all the various members that can be part of a
7918 class from being an ArrayList to be an Array of the right type.
7919 During the DefineType type_list, interface_list, delegate_list and
7920 enum_list are turned into types, interfaces, delegates and enums
7923 And during the member population, indexer_list, event_list,
7924 constant_list, field_list, instance_constructor_list, method_list,
7925 operator_list and property_list are turned into their real arrays.
7927 Although we could probably perform this operation earlier, for
7928 good error reporting we need to keep the lists and remove the
7929 lists for longer than required.
7931 This optimization was triggered by Paolo profiling the compiler
7932 speed on the output of `gen-sample-program.pl' perl script.
7934 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
7935 not crash in methods like MemberLookupFailed that use this field.
7937 This problem arises when the compiler fails to resolve a type
7938 during interface type definition for example.
7940 2003-02-18 Miguel de Icaza <miguel@ximian.com>
7942 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
7943 inherit from System.Object, so we have to stop at null, not only
7944 when reaching System.Object.
7946 2003-02-17 Miguel de Icaza <miguel@ximian.com>
7948 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
7949 DeclaredOnly because the parent indexer might have had a different
7950 name, but did not loop until the top of the hierarchy was reached.
7952 The problem this one fixes is 35492: when a class implemented an
7953 indexer from an interface, we were getting the interface method
7954 (which was abstract) and we were flagging an error (can not invoke
7957 This also keeps bug 33089 functioning, and test-148 functioning.
7959 * typemanager.cs (IsSpecialMethod): The correct way of figuring
7960 out if a method is special is to see if it is declared in a
7961 property or event, or whether it is one of the predefined operator
7962 names. This should fix correctly #36804.
7964 2003-02-15 Miguel de Icaza <miguel@ximian.com>
7966 The goal here is to remove the dependency on EmptyCast.Peel ().
7967 Killing it completely.
7969 The problem is that currently in a number of places where
7970 constants are expected, we have to "probe" for an EmptyCast, and
7971 Peel, which is not the correct thing to do, as this will be
7972 repetitive and will likely lead to errors.
7974 The idea is to remove any EmptyCasts that are used in casts that
7975 can be reduced to constants, so we only have to cope with
7978 This bug hunt was triggered by Bug 37363 and the desire to remove
7979 the duplicate pattern where we were "peeling" emptycasts to check
7980 whether they were constants. Now constants will always be
7983 * ecore.cs: Use an enumconstant here instead of wrapping with
7986 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
7987 throwing me off. By handling this we can get rid of a few hacks.
7989 * statement.cs (Switch): Removed Peel() code.
7991 2003-02-14 Miguel de Icaza <miguel@ximian.com>
7993 * class.cs: Location information for error 508
7995 * expression.cs (New.DoResolve): Add a guard against double
7996 resolution of an expression.
7998 The New DoResolve might be called twice when initializing field
7999 expressions (see EmitFieldInitializers, the call to
8000 GetInitializerExpression will perform a resolve on the expression,
8001 and later the assign will trigger another resolution
8003 This leads to bugs (#37014)
8005 * delegate.cs: The signature for EndInvoke should contain any ref
8006 or out parameters as well. We were not doing this in the past.
8008 * class.cs (Field.Define): Do not overwrite the type definition
8009 inside the `volatile' group. Turns out that volatile enumerations
8010 were changing the type here to perform a validity test, which
8013 2003-02-12 Miguel de Icaza <miguel@ximian.com>
8015 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
8016 and structs, we do not want to load the instance variable
8018 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
8019 enum_type has to be handled like an object reference (implicit
8020 conversions exists from this to object), but the regular IsClass
8021 and IsValueType tests will never return true for this one.
8023 Also we use TypeManager.IsValueType instead of type.IsValueType,
8024 just for consistency with the rest of the code (this is only
8025 needed if we ever use the construct exposed by test-180.cs inside
8026 corlib, which we dont today).
8028 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
8030 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
8033 2003-02-09 Martin Baulig <martin@ximian.com>
8035 * namespace.cs (Namespace..ctor): Added SourceFile argument.
8036 (Namespace.DefineNamespaces): New static public method; this is
8037 called when we're compiling with debugging to add all namespaces
8040 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
8041 pass it to the Namespace's .ctor.
8043 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
8044 and MethodBase arguments; pass the namespace ID to the symwriter;
8045 pass the MethodBase instead of the token to the symwriter.
8046 (SymbolWriter.DefineNamespace): New method to add a namespace to
8049 2003-02-09 Martin Baulig <martin@ximian.com>
8051 * symbolwriter.cs: New file. This is a wrapper around
8052 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
8053 methods here in near future.
8055 2003-02-09 Martin Baulig <martin@ximian.com>
8057 * codegen.cs (EmitContext.Mark): Just pass the arguments to
8058 ILGenerator.MarkSequencePoint() which are actually used by the
8061 2003-02-09 Martin Baulig <martin@ximian.com>
8063 * location.cs (SourceFile): New public sealed class. This
8064 contains the name and an index which is used in the location's token.
8065 (Location): Reserve an appropriate number of bits in the token for
8066 the source file instead of walking over that list, this gives us a
8067 really huge performance improvement when compiling with debugging.
8069 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
8070 `SourceFile' argument instead of a string.
8071 (Driver.ProcessFile): Add all the files via Location.AddFile(),
8072 but don't parse/tokenize here, we need to generate the list of all
8073 source files before we do that.
8074 (Driver.ProcessFiles): New static function. Parses/tokenizes all
8077 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
8078 instead of a string.
8080 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
8083 2003-02-09 Martin Baulig <martin@ximian.com>
8085 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
8086 filename on `#line default'.
8088 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
8090 * statement.cs: don't clear the pinned var when the fixed statement
8091 returns from the method (fixes bug#37752).
8093 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
8095 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
8098 2003-02-07 Martin Baulig <martin@ximian.com>
8100 * driver.cs: Removed the `--debug-args' command line argument.
8102 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
8103 automatically by the AsssemblyBuilder.
8104 (CodeGen.InitializeSymbolWriter): We don't need to call any
8105 initialization function on the symbol writer anymore. This method
8106 doesn't take any arguments.
8108 2003-02-03 Miguel de Icaza <miguel@ximian.com>
8110 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
8111 from referenced assemblies as well.
8113 2003-02-02 Martin Baulig <martin@ximian.com>
8115 * class.cs (MethodData.Emit): Generate debugging info for external methods.
8117 2003-02-02 Martin Baulig <martin@ximian.com>
8119 * class.cs (Constructor.Emit): Open the symbol writer before
8120 emitting the constructor initializer.
8121 (ConstructorInitializer.Emit): Call ec.Mark() to allow
8122 single-stepping through constructor initializers.
8124 2003-01-30 Miguel de Icaza <miguel@ximian.com>
8126 * class.cs: Handle error 549: do not allow virtual methods in
8129 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
8131 * decl.cs: Check access levels when resolving types
8133 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
8135 * statement.cs: Add parameters and locals set in catch blocks that might
8136 return to set vector
8138 2003-01-29 Miguel de Icaza <miguel@ximian.com>
8140 * class.cs (Operator): Set the SpecialName flags for operators.
8142 * expression.cs (Invocation.DoResolve): Only block calls to
8143 accessors and operators on SpecialName methods.
8145 (Cast.TryReduce): Handle conversions from char constants.
8148 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
8150 * statement.cs: small memory and time optimization in FlowBranching.
8152 2003-01-28 Pedro Mart <yoros@wanadoo.es>
8154 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
8155 problem that the last fix but in the other sid (Set).
8157 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
8158 access when there is no indexer in the hierarchy.
8160 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
8162 * class.cs: Combine some if statements.
8164 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8166 * driver.cs: fixed bug #37187.
8168 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
8170 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
8171 any indexer, it's needed to build a list with all the indexers in the
8172 hierarchy (AllGetters), else we have problems. Fixes #35653.
8174 2003-01-23 Miguel de Icaza <miguel@ximian.com>
8176 * class.cs (MethodData.Define): It is wrong for an interface
8177 implementation to be static in both cases: explicit and implicit.
8178 We were only handling this in one case.
8180 Improve the if situation there to not have negations.
8182 * class.cs (Field.Define): Turns out that we do not need to check
8183 the unsafe bit on field definition, only on usage. Remove the test.
8185 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8187 * driver.cs: use assembly.Location instead of Codebase (the latest
8188 patch made mcs fail when using MS assemblies).
8190 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
8192 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
8193 get the path to *corlib.dll.
8195 2003-01-21 Nick Drochak <ndrochak@gol.com>
8199 * typemanager.cs: Remove compiler warnings
8201 2003-01-20 Duncan Mak <duncan@ximian.com>
8203 * AssemblyInfo.cs: Bump the version number to 0.19.
8205 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8207 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
8209 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
8211 * class.cs (Constructor::Emit): Emit debugging info for constructors.
8213 2003-01-17 Miguel de Icaza <miguel@ximian.com>
8215 * cs-parser.jay: Small fix: we were not comparing the constructor
8216 name correctly. Thanks to Zoltan for the initial pointer.
8218 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
8220 * cs-tokenizer.cs: Set file name when specified with #line
8222 2003-01-15 Miguel de Icaza <miguel@ximian.com>
8224 * cs-parser.jay: Only perform the constructor checks here if we
8225 are named like the class; This will help provider a better
8226 error. The constructor path is taken when a type definition is
8227 not found, but most likely the user forgot to add the type, so
8228 report that rather than the constructor error.
8230 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
8232 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
8235 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
8237 * cs-parser.jay: Add cleanup call.
8239 2003-01-13 Duncan Mak <duncan@ximian.com>
8241 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
8242 consistent with other methods.
8244 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
8246 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
8248 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
8250 * attribute.cs: only set GuidAttr to true when we have a
8253 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8257 * typemanager.cs: fixes to allow mcs compile corlib with the new
8258 Type.IsSubclassOf fix.
8260 2003-01-08 Miguel de Icaza <miguel@ximian.com>
8262 * expression.cs (LocalVariableReference.DoResolve): Classify a
8263 constant as a value, not as a variable. Also, set the type for
8266 * cs-parser.jay (fixed_statement): take a type instead of a
8267 pointer_type, so we can produce a better error message later.
8269 * statement.cs (Fixed.Resolve): Flag types that are not pointers
8272 (For.DoEmit): Make inifinite loops have a
8273 non-conditional branch back.
8275 (Fixed.DoEmit): First populate the pinned variables, then emit the
8276 statement, then clear the variables. Before I was emitting the
8277 code once for each fixed piece.
8280 2003-01-08 Martin Baulig <martin@ximian.com>
8282 * statement.cs (FlowBranching.MergeChild): A break in a
8283 SWITCH_SECTION does not leave a loop. Fixes #36155.
8285 2003-01-08 Martin Baulig <martin@ximian.com>
8287 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
8288 lives in the same number space than `param_map'. Fixes #36154.
8290 2003-01-07 Miguel de Icaza <miguel@ximian.com>
8292 * cs-parser.jay (constructor_declaration): Set the
8293 Constructor.ModFlags before probing for it. This makes the
8294 compiler report 514, 515 and 132 (the code was there, but got
8297 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
8298 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
8299 (GotoCase.Resolve): Set `Returns' to ALWAYS.
8301 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
8303 * enum.cs: create the enum static fields using the enum type.
8305 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
8307 * class.cs: don't try to create the ParamBuilder for the return
8308 type if it's not needed (and handle it breaking for the ms runtime
8311 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
8313 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
8315 2002-12-29 Miguel de Icaza <miguel@ximian.com>
8317 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
8318 the command. This showed up while compiling the JANET source
8319 code, which used \r as its only newline separator.
8321 2002-12-28 Miguel de Icaza <miguel@ximian.com>
8323 * class.cs (Method.Define): If we are an operator (because it
8324 reuses our code), then set the SpecialName and HideBySig. #36128
8326 2002-12-22 Miguel de Icaza <miguel@ximian.com>
8328 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
8329 exception, report error 120 `object reference required'.
8331 * driver.cs: Add --pause option, used during to measure the size
8332 of the process as it goes with --timestamp.
8334 * expression.cs (Invocation.DoResolve): Do not allow methods with
8335 SpecialName to be invoked.
8337 2002-12-21 Miguel de Icaza <miguel@ximian.com>
8339 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
8340 number before adding it.
8342 2002-12-21 Ravi Pratap <ravi@ximian.com>
8344 * ecore.cs (StandardImplicitConversion): When in an unsafe
8345 context, we allow conversion between void * to any other pointer
8346 type. This fixes bug #35973.
8348 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
8350 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
8351 is not thrown when extensionless outputs are used
8353 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8355 * rootcontext.cs: fixed compilation of corlib.
8357 2002-12-19 Miguel de Icaza <miguel@ximian.com>
8359 * attribute.cs (Attributes.Contains): Add new method.
8361 * class.cs (MethodCore.LabelParameters): if the parameter is an
8362 `out' parameter, check that no attribute `[In]' has been passed.
8364 * enum.cs: Handle the `value__' name in an enumeration.
8366 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
8368 * decl.cs: Added special case to allow overrides on "protected
8371 2002-12-18 Ravi Pratap <ravi@ximian.com>
8373 * attribute.cs (Attributes.AddAttributeSection): Rename to this
8374 since it makes much more sense.
8376 (Attributes.ctor): Don't require a Location parameter.
8378 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
8380 * attribute.cs (ApplyAttributes): Remove extra Location parameters
8381 since we already have that information per attribute.
8383 * everywhere : make appropriate changes.
8385 * class.cs (LabelParameters): Write the code which actually
8386 applies attributes to the return type. We can't do this on the MS
8387 .NET runtime so we flag a warning in the case an exception is
8390 2002-12-18 Miguel de Icaza <miguel@ximian.com>
8392 * const.cs: Handle implicit null conversions here too.
8394 2002-12-17 Ravi Pratap <ravi@ximian.com>
8396 * class.cs (MethodCore.LabelParameters): Remove the extra
8397 Type [] parameter since it is completely unnecessary. Instead
8398 pass in the method's attributes so that we can extract
8399 the "return" attribute.
8401 2002-12-17 Miguel de Icaza <miguel@ximian.com>
8403 * cs-parser.jay (parse): Use Report.Error to flag errors instead
8404 of ignoring it and letting the compile continue.
8406 * typemanager.cs (ChangeType): use an extra argument to return an
8407 error condition instead of throwing an exception.
8409 2002-12-15 Miguel de Icaza <miguel@ximian.com>
8411 * expression.cs (Unary.TryReduce): mimic the code for the regular
8412 code path. Perform an implicit cast in the cases where we can
8413 implicitly convert to one of the integral types, and then reduce
8414 based on that constant. This fixes bug #35483.
8416 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8418 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
8420 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8422 * namespace.cs: fixed bug #35489.
8424 2002-12-12 Miguel de Icaza <miguel@ximian.com>
8426 * class.cs: Remove some dead code.
8428 * cs-parser.jay: Estimate the number of methods needed
8429 (RootContext.MethodCount);
8431 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
8432 numbers instead of StringBuilders.
8434 * support.cs (PtrHashtable): Add constructor with initial size;
8435 We can now reduce reallocations of the method table.
8437 2002-12-10 Ravi Pratap <ravi@ximian.com>
8439 * attribute.cs (ApplyAttributes): Keep track of the emitted
8440 attributes on a per-target basis. This fixes bug #35413.
8442 2002-12-10 Miguel de Icaza <miguel@ximian.com>
8444 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
8445 default to the Windows 1252 encoding.
8447 (UnixParseOption): Support version, thanks to Alp for the missing
8450 * AssemblyInfo.cs: Add nice assembly information.
8452 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
8455 * cs-parser.jay: Allow a trailing comma before the close bracked
8456 in the attribute_section production.
8458 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
8459 address of the instance was being taken, I will take this out,
8460 because we take the address of the object immediately here.
8462 2002-12-09 Ravi Pratap <ravi@ximian.com>
8464 * typemanager.cs (AreMultipleAllowed): Take care of the most
8465 obvious case where attribute type is not in the current assembly -
8468 2002-12-08 Miguel de Icaza <miguel@ximian.com>
8470 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
8471 definitions, instead of doing that afterwards.
8473 Also we use a nice little hack, depending on the constructor, we
8474 know if we are a "composed" name or a simple name. Hence, we
8475 avoid the IndexOf test, and we avoid
8477 * codegen.cs: Add code to assist in a bug reporter to track down
8478 the source of a compiler crash.
8480 2002-12-07 Ravi Pratap <ravi@ximian.com>
8482 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
8483 types have been emitted for a given element and flag an error
8484 if something which does not have AllowMultiple set is used more
8487 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
8488 attribute types and their corresponding AllowMultiple properties
8490 (AreMultipleAllowed): Check the property for a given type.
8492 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
8493 property in the case we have a TypeContainer.
8495 (Attributes.AddAttribute): Detect duplicates and just skip on
8496 adding them. This trivial fix catches a pretty gross error in our
8497 attribute emission - global attributes were being emitted twice!
8499 Bugzilla bug #33187 is now fixed.
8501 2002-12-06 Miguel de Icaza <miguel@ximian.com>
8503 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
8506 * expression.cs (Binary.ResolveOperator): I can only use the
8507 Concat (string, string, string) and Concat (string, string,
8508 string, string) if the child is actually a concatenation of
8511 2002-12-04 Miguel de Icaza <miguel@ximian.com>
8513 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
8514 context where we need a 2-character lookahead.
8516 * pending.cs (PendingImplementation): Rework so we can keep track
8517 of interface types all the time, and flag those which were
8518 implemented by parents as optional.
8520 2002-12-03 Miguel de Icaza <miguel@ximian.com>
8522 * expression.cs (Binary.ResolveOperator): Use
8523 String.Concat(string,string,string) or
8524 String.Concat(string,string,string,string) when possible.
8526 * typemanager: More helper methods.
8529 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
8531 * pending.cs: remove the bogus return from GetMissingInterfaces()
8532 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
8534 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8536 * namespace.cs: avoid duplicated 'using xxx' being added to
8537 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
8538 when we get more than one 'using' statement for the same namespace.
8539 Report a CS0105 warning for it.
8541 2002-11-30 Miguel de Icaza <miguel@ximian.com>
8543 * cs-tokenizer.cs (consume_identifier): use read directly, instead
8544 of calling getChar/putback, uses internal knowledge of it.
8546 (xtoken): Reorder tokenizer so most common patterns are checked
8547 first. This reduces the compilation time in another 5% (from 8.11s
8548 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
8550 The parsing time is 22% of the compilation in mcs, and from that
8551 64% is spent on the tokenization process.
8553 I tried using a binary search for keywords, but this is slower
8554 than the hashtable. Another option would be to do a couple of
8557 * Not use a StringBuilder, instead use an array of chars,
8558 with a set value. Notice that this way we could catch
8559 the 645 error without having to do it *afterwards*.
8561 * We could write a hand-parser to avoid the hashtable
8562 compares altogether.
8564 The identifier consumption process takes 37% of the tokenization
8565 time. Another 15% is spent on is_number. 56% of the time spent
8566 on is_number is spent on Int64.Parse:
8568 * We could probably choose based on the string length to
8569 use Int32.Parse or Int64.Parse and avoid all the 64-bit
8572 Another 3% is spend on wrapping `xtoken' in the `token' function.
8574 Handle 0xa0 as whitespace (#34752)
8576 2002-11-26 Miguel de Icaza <miguel@ximian.com>
8578 * typemanager.cs (IsCLRType): New routine to tell whether a type
8579 is one of the builtin types.
8581 Maybe it needs to use TypeCodes to be faster. Maybe we could use
8582 typecode in more places instead of doing pointer comparissions.
8583 We could leverage some knowledge about the way the typecodes are
8586 New code to cache namespaces in assemblies, it is currently not
8587 invoked, to be used soon.
8589 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
8591 * expression.cs (Binary.ResolveOperator): specially handle
8592 strings, and do not perform user-defined operator overloading for
8595 2002-11-24 Miguel de Icaza <miguel@ximian.com>
8597 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
8598 internalcall as it is a pretty simple operation; Avoid whenever
8599 possible to call Char.IsLetter.
8601 (consume_identifier): Cut by half the number of
8602 hashtable calls by merging the is_keyword and GetKeyword behavior.
8604 Do not short-circuit, because if we do, we
8605 report errors (ie, #if false && true would produce an invalid
8609 2002-11-24 Martin Baulig <martin@ximian.com>
8611 * expression.cs (Cast.TryReduce): If we're in checked syntax,
8612 check constant ranges and report a CS0221. Fixes #33186.
8614 2002-11-24 Martin Baulig <martin@ximian.com>
8616 * cs-parser.jay: Make this work for uninitialized variable
8617 declarations in the `for' initializer. Fixes #32416.
8619 2002-11-24 Martin Baulig <martin@ximian.com>
8621 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
8622 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
8624 2002-11-24 Martin Baulig <martin@ximian.com>
8626 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
8627 argument; if true, we also check for user-defined conversions.
8628 This is only needed if both arguments are of a user-defined type.
8629 Fixes #30443, added test-175.cs.
8630 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
8632 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
8634 2002-11-24 Martin Baulig <martin@ximian.com>
8636 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
8637 function to get the store opcode.
8638 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
8639 only emit the Ldelema if the store opcode is Stobj. You must run
8640 both test-34 and test-167 to test this. Fixes #34529.
8642 2002-11-23 Martin Baulig <martin@ximian.com>
8644 * ecore.cs (Expression.MemberLookup): Added additional
8645 `qualifier_type' argument which is used when we're being called
8646 from MemberAccess.DoResolve() and null if we're called from a
8648 (Expression.MemberLookupFailed): New method to report errors; this
8649 does the CS1540 check and reports the correct error message.
8651 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
8652 argument for the CS1540 check and redone the way how we're dealing
8653 with private members. See the comment in the source code for details.
8654 (FilterWithClosure): Reverted this back to revision 1.197; renamed
8655 `closure_start_type' to `closure_qualifier_type' and check whether
8656 it's not null. It was not this filter being broken, it was just
8657 being called with the wrong arguments.
8659 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
8660 and pass it the correct `qualifier_type'; this also does the error
8663 2002-11-22 Miguel de Icaza <miguel@ximian.com>
8665 * expression.cs (Invocation.EmitParams): If the we are dealing
8666 with a non-built-in value type, load its address as well.
8668 (ArrayCreation): Use a a pretty constant instead
8669 of the hardcoded value 2. Use 6 instead of 2 for the number of
8670 static initializers.
8672 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
8673 because they are not really value types, just glorified integers.
8675 * driver.cs: Do not append .exe, the CSC compiler does not do it.
8677 * ecore.cs: Remove redundant code for enumerations, make them use
8678 the same code path as everything else, fixes the casting issue
8679 with enumerations in Windows.Forms.
8681 * attribute.cs: Do only cast to string if it is a string, the
8682 validation happens later.
8684 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
8685 people upgrade their corlibs.
8687 * ecore.cs: Oops, enumerations were not following the entire code path
8689 2002-11-21 Miguel de Icaza <miguel@ximian.com>
8691 * typemanager.cs (FilterWithClosure): Commented out the test for
8692 1540 in typemanager.cs, as it has problems when accessing
8693 protected methods from a parent class (see test-174.cs).
8695 * attribute.cs (Attribute.ValidateGuid): new method.
8696 (Attribute.Resolve): Use above.
8698 2002-11-19 Miguel de Icaza <miguel@ximian.com>
8700 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
8702 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
8703 handling for enumerations, as we only needed the TypeContainer
8704 functionality to begin with (this is required for the fix below to
8705 work for enums that reference constants in a container class for
8708 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
8710 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
8711 a valid TypeBuilder to perform lookups on.o
8713 * class.cs (InheritableMemberSignatureCompare): Use true in the
8714 call to GetGetMethod and GetSetMethod, because we are comparing
8715 the signature, and we need to get the methods *even* if they are
8718 (PropertyBase.CheckBase): ditto.
8720 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
8721 GotoCase.Resolve): Use Peel on EmpytCasts.
8723 * ecore.cs (EmptyCast): drop child, add Peel method.
8725 2002-11-17 Martin Baulig <martin@ximian.com>
8727 * ecore.cs (EmptyCast.Child): New public property.
8729 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
8730 label resolved to an EmptyCast. Fixes #34162.
8731 (GotoCase.Resolve): Likewise.
8732 (Block.EmitMeta): Likewise.
8734 2002-11-17 Martin Baulig <martin@ximian.com>
8736 * expression.cs (Invocation.BetterConversion): Prefer int over
8737 uint; short over ushort; long over ulong for integer literals.
8738 Use ImplicitConversionExists instead of StandardConversionExists
8739 since we also need to check for user-defined implicit conversions.
8740 Fixes #34165. Added test-173.cs.
8742 2002-11-16 Martin Baulig <martin@ximian.com>
8744 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
8745 with the `true' and `false' literals. Fixes #33151.
8747 2002-11-16 Martin Baulig <martin@ximian.com>
8749 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
8750 October 22nd; don't do the cs1540 check for static members.
8752 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
8753 now using our own filter here and doing the cs1540 check again.
8755 2002-11-16 Martin Baulig <martin@ximian.com>
8757 * support.cs (InternalParameters): Don't crash if we don't have
8758 any fixed parameters. Fixes #33532.
8760 2002-11-16 Martin Baulig <martin@ximian.com>
8762 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
8763 when looking up static methods to make this work on Windows.
8766 2002-11-16 Martin Baulig <martin@ximian.com>
8768 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
8769 a setter rather than using PropertyInfo.CanWrite.
8771 2002-11-15 Nick Drochak <ndrochak@gol.com>
8773 * class.cs: Allow acces to block member by subclasses. Fixes build
8776 2002-11-14 Martin Baulig <martin@ximian.com>
8778 * class.cs (Constructor.Emit): Added the extern/block check.
8781 2002-11-14 Martin Baulig <martin@ximian.com>
8783 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
8784 iteration while looking for indexers, this is needed because the
8785 indexer may have a different name in our base classes. Fixed the
8786 error reporting (no indexers at all, not get accessor, no
8787 overloaded match). Fixes bug #33089.
8788 (IndexerAccess.DoResolveLValue): Likewise.
8790 2002-11-14 Martin Baulig <martin@ximian.com>
8792 * class.cs (PropertyBase.CheckBase): Make this work for multiple
8793 indexers. Fixes the first part of bug #33089.
8794 (MethodSignature.InheritableMemberSignatureCompare): Added support
8797 2002-11-13 Ravi Pratap <ravi@ximian.com>
8799 * attribute.cs (Attribute.Resolve): Catch the
8800 NullReferenceException and report it since it isn't supposed to
8803 2002-11-12 Miguel de Icaza <miguel@ximian.com>
8805 * expression.cs (Binary.EmitBranchable): Also handle the cases for
8806 LogicalOr and LogicalAnd that can benefit from recursively
8807 handling EmitBranchable. The code now should be nice for Paolo.
8809 2002-11-08 Miguel de Icaza <miguel@ximian.com>
8811 * typemanager.cs (LookupType): Added a negative-hit hashtable for
8812 the Type lookups, as we perform quite a number of lookups on
8813 non-Types. This can be removed once we can deterministically tell
8814 whether we have a type or a namespace in advance.
8816 But this might require special hacks from our corlib.
8820 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
8821 and double which avoids a conversion from an integer to a double.
8823 * expression.cs: tiny optimization, avoid calling IsConstant,
8824 because it effectively performs the lookup twice.
8826 2002-11-06 Miguel de Icaza <miguel@ximian.com>
8828 But a bogus return here to keep the semantics of the old code
8829 until the Mono runtime is fixed.
8831 * pending.cs (GetMissingInterfaces): New method used to remove all
8832 the interfaces that are already implemented by our parent
8833 classes from the list of pending methods.
8835 * interface.cs: Add checks for calls after ResolveTypeExpr.
8837 2002-11-05 Miguel de Icaza <miguel@ximian.com>
8839 * class.cs (Class.Emit): Report warning 67: event not used if the
8840 warning level is beyond 3.
8842 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
8843 being a NullLiteral.
8845 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
8848 * class.cs (TypeContainer.GetClassBases): Cover a missing code
8849 path that might fail if a type can not be resolved.
8851 * expression.cs (Binary.Emit): Emit unsigned versions of the
8854 * driver.cs: use error 5.
8856 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
8858 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
8860 2002-11-01 Miguel de Icaza <miguel@ximian.com>
8862 * cs-parser.jay (switch_section): A beautiful patch from Martin
8863 Baulig that fixed 33094.
8865 2002-10-31 Miguel de Icaza <miguel@ximian.com>
8867 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
8868 Check whether the base is abstract and report an error if so.
8870 * expression.cs (IndexerAccess.DoResolveLValue,
8871 IndexerAccess.DoResolve): ditto.
8873 (Invocation.DoResolve): ditto.
8875 (Invocation.FullMethodDesc): Improve the report string.
8877 * statement.cs (Block): Eliminate IsVariableDefined as it is
8878 basically just a wrapper for GetVariableInfo.
8880 * ecore.cs (SimpleName): Use new
8882 * support.cs (ReflectionParamter.ParameterType): We unwrap the
8883 type, as we return the actual parameter ref/unref state on a
8886 2002-10-30 Miguel de Icaza <miguel@ximian.com>
8888 * support.cs: Return proper flags REF/OUT fixing the previous
8891 * expression.cs: Reverted last patch, that was wrong. Is_ref is
8892 not used to mean `ref' but `ref or out' in ParameterReference
8894 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
8895 full type signature instead of calling TypeManger.CSharpName
8898 * support.cs (InternalParameters.ParameterDesc): Do not compare
8899 directly to the modflags, because REF/OUT will actually be bitsets
8902 * delegate.cs (VerifyMethod): Check also the modifiers.
8904 * cs-tokenizer.cs: Fix bug where floating point values with an
8905 exponent where a sign was missing was ignored.
8907 * driver.cs: Allow multiple assemblies to be specified in a single
8910 2002-10-28 Miguel de Icaza <miguel@ximian.com>
8912 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
8913 because identifiers after a parenthesis would end up in this kind
8914 of production, and we needed to desamiguate it for having casts
8917 (UserDefinedType *) xxx
8919 2002-10-24 Miguel de Icaza <miguel@ximian.com>
8921 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
8922 we should set on the Bindingflags.NonPublic, but not turn on
8923 private_ok. private_ok controls whether a Private member is
8924 returned (this is chekced on the filter routine), while the
8925 BindingFlags.NonPublic just controls whether private/protected
8926 will be allowed. This fixes the problem part of the problem of
8927 private properties being allowed to be used in derived classes.
8929 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
8930 so we can call the children DoResolveLValue method (this will
8931 properly signal errors on lvalue assignments to base properties)
8933 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
8934 getter are null, and we have a property info, we know that this
8935 happened because the lookup failed, so we report an error 122 for
8936 protection level violation.
8938 We also silently return if setter and getter are null in the
8939 resolve functions, this condition only happens if we have flagged
8940 the error before. This is the other half of the problem.
8942 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
8943 not have accessibility information, that is why we were returning
8944 true in the filter function in typemanager.cs.
8946 To properly report 122 (property is inaccessible because of its
8947 protection level) correctly, we report this error in ResolveAccess
8948 by failing if both the setter and the getter are lacking (ie, the
8951 DoResolve and DoLResolve have been modified to check for both
8952 setter/getter being null and returning silently, the reason being
8953 that I did not want to put the knowledge about this error in upper
8956 int old = Report.Errors;
8957 x = new PropertyExpr (...);
8958 if (old != Report.Errors)
8963 So the property expr is returned, but it is invalid, so the error
8964 will be flagged during the resolve process.
8966 * class.cs: Remove InheritablePropertySignatureCompare from the
8967 class, as we no longer depend on the property signature to compute
8968 whether it is possible to implement a method or not.
8970 The reason is that calling PropertyInfo.GetGetMethod will return
8971 null (in .NET, in Mono it works, and we should change this), in
8972 cases where the Get Method does not exist in that particular
8977 class X { public virtual int A { get { return 1; } } }
8979 class Z : Y { public override int A { get { return 2; } } }
8981 Would fail in Z because the parent (Y) would not have the property
8982 defined. So we avoid this completely now (because the alternative
8983 fix was ugly and slow), and we now depend exclusively on the
8986 (PropertyBase.CheckBase): Use a method-base mechanism to find our
8987 reference method, instead of using the property.
8989 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
8990 routines are gone now.
8992 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
8993 names, they were incorrectly named.
8995 * cs-tokenizer.cs: Return are more gentle token on failure.
8997 * pending.cs (PendingImplementation.InterfaceMethod): This routine
8998 had an out-of-sync index variable, which caused it to remove from
8999 the list of pending methods the wrong method sometimes.
9001 2002-10-22 Miguel de Icaza <miguel@ximian.com>
9003 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
9004 CanWrite, because those refer to this particular instance of the
9005 property, and do not take into account the fact that we can
9006 override single members of a property.
9008 Constructor requires an EmitContext. The resolution process does
9009 not happen here, but we need to compute the accessors before,
9010 because the resolution does not always happen for properties.
9012 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
9013 subclass, before we did not update this flag, but we did update
9016 (GetAccessors): Drop this routine, as it did not work in the
9017 presence of partially overwritten set/get methods.
9019 Notice that this broke the cs1540 detection, but that will require
9022 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9026 * driver.cs: issue a warning instead of an error if we don't support
9027 debugging for the platform. Also ignore a couple of errors that may
9028 arise when trying to write the symbols. Undo my previous patch.
9030 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9032 * driver.cs: ignore /debug switch except for Unix platforms.
9034 2002-10-23 Nick Drochak <ndrochak@gol.com>
9036 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
9038 2002-10-21 Miguel de Icaza <miguel@ximian.com>
9040 * driver.cs: Do not make mcs-debug conditional, so we do not break
9043 * statement.cs (UsageVector.MergeChildren): I would like Martin to
9044 review this patch. But basically after all the children variables
9045 have been merged, the value of "Breaks" was not being set to
9046 new_breaks for Switch blocks. I think that it should be set after
9047 it has executed. Currently I set this to the value of new_breaks,
9048 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
9049 conservative, but I do not understand this code very well.
9051 I did not break anything in the build, so that is good ;-)
9053 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
9055 2002-10-20 Mark Crichton <crichton@gimp.org>
9057 * cfold.cs: Fixed compile blocker. Really fixed it this time.
9059 2002-10-20 Nick Drochak <ndrochak@gol.com>
9061 * cfold.cs: Fixed compile blocker.
9063 2002-10-20 Miguel de Icaza <miguel@ximian.com>
9065 * driver.cs: I was chekcing the key, not the file.
9067 2002-10-19 Ravi Pratap <ravi@ximian.com>
9069 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
9070 message that we were generating - we just need to silently return
9073 2002-10-19 Miguel de Icaza <miguel@ximian.com>
9075 * class.cs (Event.Define): Change my previous commit, as this
9076 breaks the debugger. This is a temporary hack, as it seems like
9077 the compiler is generating events incorrectly to begin with.
9079 * expression.cs (Binary.ResolveOperator): Added support for
9080 "U operator - (E x, E y)"
9082 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
9085 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
9086 init-only variables, but this path did not take into account that
9087 there might be also instance readonly variables. Correct this
9090 This fixes bug 32253
9092 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
9095 * driver.cs: Change the extension for modules to `netmodule'
9097 * cs-parser.jay: Improved slightly the location tracking for
9098 the debugger symbols.
9100 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
9101 modifiers that were specified instead of the hardcoded value
9102 (FamAndAssem). This was basically ignoring the static modifier,
9103 and others. Fixes 32429.
9105 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
9106 fixed a bug in the process (32476)
9108 * expression.cs (ArrayAccess.EmitAssign): Patch from
9109 hwang_rob@yahoo.ca that fixes bug 31834.3
9111 2002-10-18 Miguel de Icaza <miguel@ximian.com>
9113 * driver.cs: Make the module extension .netmodule.
9115 2002-10-16 Miguel de Icaza <miguel@ximian.com>
9117 * driver.cs: Report an error if the resource file is not found
9118 instead of crashing.
9120 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
9121 false, like Emit does.
9123 2002-10-16 Nick Drochak <ndrochak@gol.com>
9125 * typemanager.cs: Remove unused private member. Also reported mcs
9126 bug to report this as a warning like csc.
9128 2002-10-15 Martin Baulig <martin@gnome.org>
9130 * statement.cs (Statement.Emit): Made this a virtual method; emits
9131 the line number info and calls DoEmit().
9132 (Statement.DoEmit): New protected abstract method, formerly knows
9133 as Statement.Emit().
9135 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
9137 2002-10-11 Miguel de Icaza <miguel@ximian.com>
9139 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
9140 have fixed a remaining problem: not every AddXXXX was adding a
9141 fully qualified name.
9143 Now everyone registers a fully qualified name in the DeclSpace as
9144 being defined instead of the partial name.
9146 Downsides: we are slower than we need to be due to the excess
9147 copies and the names being registered this way.
9149 The reason for this is that we currently depend (on the corlib
9150 bootstrap for instance) that types are fully qualified, because
9151 we dump all the types in the namespace, and we should really have
9152 types inserted into the proper namespace, so we can only store the
9153 basenames in the defined_names array.
9155 2002-10-10 Martin Baulig <martin@gnome.org>
9157 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
9158 from bug #31834, see the bug report for a testcase which is
9161 2002-10-10 Martin Baulig <martin@gnome.org>
9163 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
9164 flow analysis code for this.
9166 * statement.cs (Do, While, For): Tell the flow analysis code about
9168 (FlowBranching.UsageVector): Added support for infinite loops.
9169 (Block.Resolve): Moved the dead code elimination here and use flow
9172 2002-10-09 Miguel de Icaza <miguel@ximian.com>
9174 * class.cs (Field.Define): Catch cycles on struct type
9177 * typemanager.cs (IsUnmanagedtype): Do not recursively check
9178 fields if the fields are static. We only need to check instance
9181 * expression.cs (As.DoResolve): Test for reference type.
9183 * statement.cs (Using.ResolveExpression): Use
9184 ConvertImplicitRequired, not ConvertImplicit which reports an
9186 (Using.ResolveLocalVariableDecls): ditto.
9188 * expression.cs (Binary.ResolveOperator): Report errors in a few
9189 places where we had to.
9191 * typemanager.cs (IsUnmanagedtype): Finish implementation.
9193 2002-10-08 Miguel de Icaza <miguel@ximian.com>
9195 * expression.cs: Use StoreFromPtr instead of extracting the type
9196 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
9198 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
9199 an enumeration value to a System.Enum, but System.Enum is not a
9200 value type, but an class type, so we need to box.
9202 (Expression.ConvertExplicit): One codepath could return
9203 errors but not flag them. Fix this. Fixes #31853
9205 * parameter.cs (Resolve): Do not allow void as a parameter type.
9207 2002-10-06 Martin Baulig <martin@gnome.org>
9209 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
9210 if it's a class type and not a struct. Fixes #31815.
9212 2002-10-06 Martin Baulig <martin@gnome.org>
9214 * statement.cs: Reworked the flow analysis code a bit to make it
9215 usable for dead code elimination.
9217 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9219 * cs-parser.jay: allow empty source files. Fixes bug #31781.
9221 2002-10-04 Miguel de Icaza <miguel@ximian.com>
9223 * expression.cs (ComposedCast.DoResolveType): A quick workaround
9224 to fix the test 165, will investigate deeper.
9226 2002-10-04 Martin Baulig <martin@gnome.org>
9228 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
9229 finally blocks actually work.
9230 (Try.Resolve): We don't need to create a sibling for `finally' if
9231 there is no finally block.
9233 2002-10-04 Martin Baulig <martin@gnome.org>
9235 * class.cs (Constructor.Define): The default accessibility for a
9236 non-default constructor is private, not public.
9238 2002-10-04 Miguel de Icaza <miguel@ximian.com>
9240 * class.cs (Constructor): Make AllowedModifiers public, add
9243 * cs-parser.jay: Perform the modifiers test here, as the
9244 constructor for the Constructor class usually receives a zero
9245 because of the way we create it (first we create, later we
9246 customize, and we were never checking the modifiers).
9248 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
9249 is a version of LookupTypeReflection that includes the type-name
9250 cache. This can be used as a fast path for functions that know
9251 the fully qualified name and are only calling into *.GetType() to
9252 obtain a composed type.
9254 This is also used by TypeManager.LookupType during its type
9257 (LookupType): We now also track the real type name, as sometimes
9258 we can get a quey for the real type name from things like
9259 ComposedCast. This fixes bug 31422.
9261 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
9262 complete type fullname, it does not have to go through the type
9263 resolution system to obtain the composed version of the type (for
9264 obtaining arrays or pointers).
9266 (Conditional.Emit): Use the EmitBoolExpression to
9267 generate nicer code, as requested by Paolo.
9269 (ArrayCreation.CheckIndices): Use the patch from
9270 hwang_rob@yahoo.ca to validate the array initializers.
9272 2002-10-03 Miguel de Icaza <miguel@ximian.com>
9274 * class.cs (ConstructorInitializer.Emit): simplify code by using
9275 Invocation.EmitCall, and at the same time, fix the bugs in calling
9276 parent constructors that took variable arguments.
9278 * ecore.cs (Expression.ConvertNumericExplicit,
9279 Expression.ImplicitNumericConversion): Remove the code that
9280 manually wrapped decimal (InternalTypeConstructor call is now gone
9283 * expression.cs (Cast.TryReduce): Also handle decimal types when
9284 trying to perform a constant fold on the type.
9286 * typemanager.cs (IsUnmanagedtype): Partially implemented.
9288 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
9289 that only turned off an error report, and did nothing else.
9291 2002-10-02 Miguel de Icaza <miguel@ximian.com>
9293 * driver.cs: Handle and ignore /fullpaths
9295 2002-10-01 Miguel de Icaza <miguel@ximian.com>
9297 * expression.cs (Binary.ResolveOperator): Catch the case where
9298 DoNumericPromotions returns true,
9300 (Binary.DoNumericPromotions): Simplify the code, and the tests.
9302 2002-09-27 Miguel de Icaza <miguel@ximian.com>
9304 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
9307 2002-09-26 Miguel de Icaza <miguel@ximian.com>
9309 * ecore.cs (ConvertNumericExplicit): It is not enough that the
9310 conversion exists, but it is also required that the conversion be
9311 performed. This manifested in "(Type64Enum) 2".
9313 * class.cs (TypeManager.AddMethod): The fix is not to change
9314 AddEnum, because that one was using a fully qualified name (every
9315 DeclSpace derivative does), but to change the AddMethod routine
9316 that was using an un-namespaced name. This now correctly reports
9317 the duplicated name.
9319 Revert patch until I can properly fix it. The issue
9320 is that we have a shared Type space across all namespaces
9321 currently, which is wrong.
9323 Options include making the Namespace a DeclSpace, and merge
9324 current_namespace/current_container in the parser.
9326 2002-09-25 Miguel de Icaza <miguel@ximian.com>
9328 * cs-parser.jay: Improve error reporting when we get a different
9329 kind of expression in local_variable_type and
9330 local_variable_pointer_type.
9332 Propagate this to avoid missleading errors being reported.
9334 * ecore.cs (ImplicitReferenceConversion): treat
9335 TypeManager.value_type as a target just like object_type. As
9340 Is valid, and needs to result in the int 1 being boxed before it
9341 is assigned to the value type v.
9343 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
9344 to validate the enumeration name.
9346 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
9347 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
9348 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
9350 * ecore.cs (TryImplicitIntConversion): When doing an
9351 implicit-enumeration-conversion, check if the type is 64-bits and
9352 perform a conversion before passing to EnumConstant.
9354 2002-09-23 Miguel de Icaza <miguel@ximian.com>
9356 * decl.cs (Error_AmbiguousTypeReference); New routine used to
9357 report ambiguous type references. Unlike the MS version, we
9358 report what the ambiguity is. Innovation at work ;-)
9360 (DeclSpace.FindType): Require a location argument to
9361 display when we display an ambiguous error.
9363 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
9365 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
9367 * expression.cs (EmitDynamicInitializers): Apply patch from
9368 hwang_rob@yahoo.ca that fixes the order in which we emit our
9371 2002-09-21 Martin Baulig <martin@gnome.org>
9373 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
9374 delegate takes no arguments.
9376 2002-09-20 Miguel de Icaza <miguel@ximian.com>
9378 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
9381 * expression.cs: Extract the underlying type.
9383 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
9385 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
9387 2002-09-19 Miguel de Icaza <miguel@ximian.com>
9389 * class.cs (TypeContainer.DefineType): We can not use the nice
9390 PackingSize with the size set to 1 DefineType method, because it
9391 will not allow us to define the interfaces that the struct
9394 This completes the fixing of bug 27287
9396 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
9397 means also structs. This fixes part of the problem.
9398 (Expresion.ImplicitReferenceConversionExists): ditto.
9400 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
9401 error if there were no errors reported during the type lookup
9402 process, to avoid duplicates or redundant errors. Without this
9403 you would get an ambiguous errors plus a type not found. We have
9404 beaten the user enough with the first error.
9406 (DeclSparce.FindType): Emit a warning if we have an ambiguous
9409 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
9410 during the resolution process, stop the lookup, this avoids
9411 repeated error reports (same error twice).
9413 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
9415 * typemanager.cs (LookupType): Redo the type lookup code to match
9416 the needs of System.Reflection.
9418 The issue is that System.Reflection requires references to nested
9419 types to begin with a "+" sign instead of a dot. So toplevel
9420 types look like: "NameSpace.TopLevelClass", and nested ones look
9421 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
9424 2002-09-19 Martin Baulig <martin@gnome.org>
9426 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
9427 says that a method always returns or always throws an exception,
9428 don't report the CS0161.
9430 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
9431 set `Returns = new_returns'.
9433 2002-09-19 Martin Baulig <martin@gnome.org>
9435 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
9436 to an enum constant, check for a CS0176.
9438 2002-09-18 Miguel de Icaza <miguel@ximian.com>
9440 * class.cs (TypeContainer.CheckPairedOperators): Now we check
9441 for operators that must be in pairs and report errors.
9443 * ecore.cs (SimpleName.DoResolveType): During the initial type
9444 resolution process, when we define types recursively, we must
9445 check first for types in our current scope before we perform
9446 lookups in the enclosing scopes.
9448 * expression.cs (MakeByteBlob): Handle Decimal blobs.
9450 (Invocation.VerifyArgumentsCompat): Call
9451 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
9452 I thought we were supposed to always call this, but there are a
9453 few places in the code where we dont do it.
9455 2002-09-17 Miguel de Icaza <miguel@ximian.com>
9457 * driver.cs: Add support in -linkres and -resource to specify the
9458 name of the identifier.
9460 2002-09-16 Miguel de Icaza <miguel@ximian.com>
9462 * ecore.cs (StandardConversionExists): Sync with the conversion
9463 code: allow anything-* to void* conversions.
9465 (FindMostSpecificSource): Use an Expression argument
9466 instead of a Type, because we might be handed over a Literal which
9467 gets a few more implicit conversions that plain types do not. So
9468 this information was being lost.
9470 Also, we drop the temporary type-holder expression when not
9473 2002-09-17 Martin Baulig <martin@gnome.org>
9475 * class.cs (PropertyBase.CheckBase): Don't check the base class if
9476 this is an explicit interface implementation.
9478 2002-09-17 Martin Baulig <martin@gnome.org>
9480 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
9481 different `IndexerName' attributes.
9483 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
9484 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
9485 virtual CommonResolve().
9487 2002-09-16 Miguel de Icaza <miguel@ximian.com>
9489 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
9490 and convert that to the UnderlyingType.
9492 * statement.cs (Foreach.Resolve): Indexers are just like variables
9493 or PropertyAccesses.
9495 * cs-tokenizer.cs (consume_string): Track line numbers and columns
9496 inside quoted strings, we were not doing this before.
9498 2002-09-16 Martin Baulig <martin@gnome.org>
9500 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
9501 resolve it. This is needed for the definite assignment check of the
9502 instance expression, fixes bug #29846.
9503 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
9505 2002-09-16 Nick Drochak <ndrochak@gol.com>
9507 * parameter.cs: Fix compile error. Cannot reference static member
9508 from an instance object. Is this an mcs bug?
9510 2002-09-14 Martin Baulig <martin@gnome.org>
9512 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
9513 multiple times. Fixes bug #30295, added test-166.cs.
9515 2002-09-14 Martin Baulig <martin@gnome.org>
9517 * statement.cs (Block.Emit): Don't emit unreachable code.
9518 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
9520 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
9522 2002-09-14 Martin Baulig <martin@gnome.org>
9524 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
9527 2002-09-14 Martin Baulig <martin@gnome.org>
9529 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
9530 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
9531 be false on the ms runtime.
9533 2002-09-13 Martin Baulig <martin@gnome.org>
9535 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
9536 the CS0038 error message.
9538 2002-09-12 Miguel de Icaza <miguel@ximian.com>
9540 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
9541 constant inside, return it.
9543 2002-09-12 Martin Baulig <martin@gnome.org>
9545 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
9546 implicit conversion can be done between enum types.
9548 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
9549 check whether an implicit conversion to the current enum's UnderlyingType
9550 exists and report an error if not.
9552 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
9553 without debugging support.
9555 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
9556 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
9558 2002-09-12 Martin Baulig <martin@gnome.org>
9560 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
9562 * ecore.cs (IMemberExpr.DeclaringType): New property.
9563 (SimpleName.SimpleNameResolve): Check whether we're accessing a
9564 nonstatic member of an outer type (CS0038).
9566 2002-09-11 Miguel de Icaza <miguel@ximian.com>
9568 * driver.cs: Activate the using-error detector at warning level
9569 4 (at least for MS-compatible APIs).
9571 * namespace.cs (VerifyUsing): Small buglett fix.
9573 * pending.cs (PendingImplementation): pass the container pointer.
9575 * interface.cs (GetMethods): Allow for recursive definition. Long
9576 term, I would like to move every type to support recursive
9577 definitions, not the current ordering mechanism that we have right
9580 The situation is this: Attributes are handled before interfaces,
9581 so we can apply attributes to interfaces. But some attributes
9582 implement interfaces, we will now handle the simple cases
9583 (recursive definitions will just get an error).
9585 * parameter.cs: Only invalidate types at the end if we fail to
9588 2002-09-09 Martin Baulig <martin@gnome.org>
9590 * ecore.cs (PropertyExpr.Emit): Also check for
9591 TypeManager.system_int_array_get_length so this'll also work when
9592 compiling corlib. Fixes #30003.
9594 2002-09-09 Martin Baulig <martin@gnome.org>
9596 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
9597 and throw an exception if we can't get the type's size. Fixed #30040,
9600 2002-09-09 Martin Baulig <martin@gnome.org>
9602 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
9604 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
9605 context. Fixes bug #30027.
9607 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
9608 virtual functions. Fixes bug #30043, added test-164.cs.
9610 2002-09-08 Ravi Pratap <ravi@ximian.com>
9612 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
9614 2002-09-08 Nick Drochak <ndrochak@gol.com>
9616 * driver.cs: Use an object to get the windows codepage since it's not a
9619 2002-09-08 Miguel de Icaza <miguel@ximian.com>
9621 * statement.cs (For.Emit): for infinite loops (test == null)
9622 return whether there is a break inside, not always "true".
9624 * namespace.cs (UsingEntry): New struct to hold the name of the
9625 using definition, the location where it is defined, and whether it
9626 has been used in a successful type lookup.
9628 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
9633 2002-09-06 Ravi Pratap <ravi@ximian.com>
9635 * attribute.cs : Fix incorrect code which relied on catching
9636 a NullReferenceException to detect a null being passed in
9637 where an object was expected.
9639 2002-09-06 Miguel de Icaza <miguel@ximian.com>
9641 * statement.cs (Try): flag the catch variable as assigned
9643 * expression.cs (Cast): Simplified by using ResolveType instead of
9646 * statement.cs (Catch): Fix bug by using ResolveType.
9648 2002-09-06 Ravi Pratap <ravi@ximian.com>
9650 * expression.cs (BetterConversion): Special case for when we have
9651 a NullLiteral as the argument and we have to choose between string
9652 and object types - we choose string the way csc does.
9654 * attribute.cs (Attribute.Resolve): Catch the
9655 NullReferenceException and report error #182 since the Mono
9656 runtime no more has the bug and having this exception raised means
9657 we tried to select a constructor which takes an object and is
9660 2002-09-05 Ravi Pratap <ravi@ximian.com>
9662 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
9663 message (1502, 1503) when we can't locate a method after overload
9664 resolution. This is much more informative and closes the bug
9667 * interface.cs (PopulateMethod): Return if there are no argument
9668 types. Fixes a NullReferenceException bug.
9670 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
9671 expressions too. Previously we were checking only in one place for
9672 positional arguments leaving out named arguments.
9674 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
9675 type to the enum type is not allowed. Remove code corresponding to
9678 (ConvertNumericExplicit): Allow explicit conversions from
9679 the underlying type to enum type. This precisely follows the spec
9680 and closes a bug filed by Gonzalo.
9682 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9685 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
9687 2002-09-03 Miguel de Icaza <miguel@ximian.com>
9689 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
9690 it was important that we stored the right value after the
9691 reduction in `converted'.
9693 2002-09-04 Martin Baulig <martin@gnome.org>
9695 * location.cs (Location.SymbolDocument): Use full pathnames for the
9698 2002-08-30 Miguel de Icaza <miguel@ximian.com>
9700 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
9701 of the expression resolve mechanism, because that will catch the
9702 SimpleName error failures.
9704 (Conditional): If we can not resolve the
9705 expression, return, do not crash.
9707 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9710 (location): display token name instead of its number.
9712 2002-08-28 Martin Baulig <martin@gnome.org>
9714 * expression.cs (Binary.ResolveOperator): Don't silently return
9715 but return an error if an operator cannot be applied between two
9718 2002-08-28 Martin Baulig <martin@gnome.org>
9720 * class.cs (Constructor.Define): Set the permission attributes
9721 correctly instead of making all constructors public.
9723 2002-08-28 Martin Baulig <martin@gnome.org>
9725 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
9726 for private members before reporting a CS0103; if we find anything,
9729 2002-08-28 Martin Baulig <martin@gnome.org>
9731 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
9732 to check whether `closure_start_type == closure_invocation_type',
9733 we also need to check whether `m.DeclaringType == closure_invocation_type'
9734 before bypassing the permission checks. We might be accessing
9735 protected/private members from the base class.
9736 (TypeManager.RealMemberLookup): Only set private_ok if private
9737 members were requested via BindingFlags.NonPublic.
9739 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
9741 * expression.cs (MemberAccess.ResolveMemberAccess): Set
9742 MethodGroupExpr.IsExplicitImpl if appropriate.
9743 (Invocation.DoResolve): Don't report the CS0120 for explicit
9744 interface implementations.
9746 2002-08-27 Martin Baulig <martin@gnome.org>
9748 * expression.cs (Invocation.DoResolve): If this is a static
9749 method and we don't have an InstanceExpression, we must report
9752 2002-08-25 Martin Baulig <martin@gnome.org>
9754 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
9755 `==' between a valuetype and an object.
9757 2002-08-25 Miguel de Icaza <miguel@ximian.com>
9759 * ecore.cs (TypeExpr): Provide a ToString method.
9761 2002-08-24 Martin Baulig <martin@gnome.org>
9763 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
9764 now called proggie.dbg and it's a binary file.
9766 2002-08-23 Martin Baulig <martin@gnome.org>
9768 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
9770 2002-08-23 Martin Baulig <martin@gnome.org>
9772 * struct.cs (MyStructInfo.ctor): Make this work with empty
9773 structs; it's not allowed to use foreach() on null.
9775 2002-08-23 Martin Baulig <martin@gnome.org>
9777 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
9778 writer the full pathname of the generated assembly.
9780 2002-08-23 Martin Baulig <martin@gnome.org>
9782 * statements.cs (FlowBranching.UsageVector.MergeChildren):
9783 A `finally' block never returns or breaks; improved handling of
9786 2002-08-23 Martin Baulig <martin@gnome.org>
9788 * statement.cs (Throw.Resolve): Allow `throw null'.
9790 2002-08-23 Martin Baulig <martin@gnome.org>
9792 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
9793 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
9794 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
9795 MemberLookup would return a wrong event if this is an explicit
9796 interface implementation and the class has an event with the same
9799 2002-08-23 Martin Baulig <martin@gnome.org>
9801 * statement.cs (Block.AddChildVariableNames): New public method.
9802 (Block.AddChildVariableName): Likewise.
9803 (Block.IsVariableNameUsedInChildBlock): Likewise.
9804 (Block.AddVariable): Check whether a variable name has already
9805 been used in a child block.
9807 * cs-parser.jay (declare_local_variables): Mark all variable names
9808 from the current block as being used in a child block in the
9811 2002-08-23 Martin Baulig <martin@gnome.org>
9813 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
9814 find the symbol writer.
9816 * driver.cs: csc also allows the arguments to /define being
9817 separated by commas, not only by semicolons.
9819 2002-08-23 Martin Baulig <martin@gnome.org>
9821 * interface.cs (Interface.GetMembers): Added static check for events.
9823 2002-08-15 Martin Baulig <martin@gnome.org>
9825 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
9826 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
9828 * ecore.cs (Expression.MemberLookup): Added documentation and explained
9829 why the MethodData.EmitDestructor() change was necessary.
9831 2002-08-20 Martin Baulig <martin@gnome.org>
9833 * class.cs (TypeContainer.FindMembers): Added static check for events.
9835 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
9837 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
9838 use Type.GetEvents(), not Type.FindMembers().
9840 2002-08-20 Martin Baulig <martin@gnome.org>
9842 * decl.cs (MemberCache): Added a special method cache which will
9843 be used for method-only searched. This ensures that a method
9844 search will return a MethodInfo with the correct ReflectedType for
9847 2002-08-20 Martin Baulig <martin@gnome.org>
9849 * decl.cs (DeclSpace.FindMembers): Made this public.
9851 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9853 * delegate.cs: fixed build on windows.
9854 [FIXME: Filed as bug #29150: MCS must report these errors.]
9856 2002-08-19 Ravi Pratap <ravi@ximian.com>
9858 * ecore.cs (StandardConversionExists): Return a false
9859 if we are trying to convert the void type to anything else
9860 since that is not allowed.
9862 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
9863 we flag error 70 in the event an event is trying to be accessed
9864 directly from outside the declaring type.
9866 2002-08-20 Martin Baulig <martin@gnome.org>
9868 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
9869 MemberCache from typemanager.cs to decl.cs.
9871 2002-08-19 Martin Baulig <martin@gnome.org>
9873 * class.cs (TypeContainer): Implement IMemberContainer.
9874 (TypeContainer.DefineMembers): Create the MemberCache.
9875 (TypeContainer.FindMembers): Do better BindingFlags checking; only
9876 return public members if BindingFlags.Public was given, check
9877 whether members are static.
9879 2002-08-16 Martin Baulig <martin@gnome.org>
9881 * decl.cs (DeclSpace.Define): Splitted this in Define and
9882 DefineMembers. DefineMembers is called first and initializes the
9885 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
9886 DefineMembers() on all our DeclSpaces.
9888 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
9889 but call DefineMembers() on all nested interfaces. We call their
9890 Define() in our new Define() function.
9892 * interface.cs (Interface): Implement IMemberContainer.
9893 (Interface.Define): Moved all code except the attribute stuf to
9895 (Interface.DefineMembers): Initialize the member cache.
9897 * typemanager.cs (IMemberFinder): Removed this interface, we don't
9898 need this anymore since we can use MemberCache.FindMembers directly.
9900 2002-08-19 Martin Baulig <martin@gnome.org>
9902 * typemanager.cs (MemberCache): When creating the cache for an
9903 interface type, add all inherited members.
9904 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
9905 to `out bool used_cache' and documented it.
9906 (TypeManager.MemberLookup): If we already used the cache in the first
9907 iteration, we don't need to do the interfaces check.
9909 2002-08-19 Martin Baulig <martin@gnome.org>
9911 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
9912 here from IMemberFinder and don't implement this interface anymore.
9913 (DeclSpace.MemberCache): Moved here from IMemberFinder.
9915 * typemanager.cs (IMemberFinder): This interface is now only used by
9916 classes which actually support the member cache.
9917 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
9918 since we only put DeclSpaces into this Hashtable.
9919 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
9920 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
9922 2002-08-16 Martin Baulig <martin@gnome.org>
9924 * typemanager.cs (ICachingMemberFinder): Removed.
9925 (IMemberFinder.MemberCache): New property.
9926 (TypeManager.FindMembers): Merged this with RealFindMembers().
9927 This function will never be called from TypeManager.MemberLookup()
9928 so we can't use the cache here, just the IMemberFinder.
9929 (TypeManager.MemberLookup_FindMembers): Check whether the
9930 IMemberFinder has a MemberCache and call the cache's FindMembers
9932 (MemberCache): Rewrote larger parts of this yet another time and
9933 cleaned it up a bit.
9935 2002-08-15 Miguel de Icaza <miguel@ximian.com>
9937 * driver.cs (LoadArgs): Support quoting.
9939 (Usage): Show the CSC-like command line arguments.
9941 Improved a few error messages.
9943 2002-08-15 Martin Baulig <martin@gnome.org>
9945 * typemanager.cs (IMemberContainer.Type): New property.
9946 (IMemberContainer.IsInterface): New property.
9948 The following changes are conditional to BROKEN_RUNTIME, which is
9949 defined at the top of the file.
9951 * typemanager.cs (MemberCache.MemberCache): Don't add the base
9952 class'es members, but add all members from TypeHandle.ObjectType
9953 if we're an interface.
9954 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
9955 is the current type.
9956 (MemberCache.CacheEntry.Container): Removed this field.
9957 (TypeHandle.GetMembers): Include inherited members.
9959 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9961 * typemanager.cs: fixed compilation and added a comment on a field that
9964 2002-08-15 Martin Baulig <martin@gnome.org>
9966 * class.cs (ConstructorInitializer.Resolve): In the
9967 Expression.MemberLookup call, use the queried_type as
9970 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
9971 declared' attribute, it's always true.
9972 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
9973 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
9974 temporary wrapper for FindMembers which tells MemberLookup whether
9975 members from the base classes are included in the return value.
9976 This will go away soon.
9977 (TypeManager.MemberLookup): Use this temporary hack here; once the
9978 new MemberCache is completed, we don't need to do the DeclaredOnly
9979 looping here anymore since the MemberCache will take care of this.
9980 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
9981 (MemberCache): When creating the MemberCache for a class, get
9982 members from the current class and all its base classes.
9983 (MemberCache.CacheEntry.Container): New field. This is a
9984 temporary hack until the Mono runtime is fixed to distinguish
9985 between ReflectedType and DeclaringType. It allows us to use MCS
9986 with both the MS runtime and the unfixed Mono runtime without
9987 problems and without accecting performance.
9988 (MemberCache.SearchMembers): The DeclaredOnly looping from
9989 TypeManager.MemberLookup is now done here.
9991 2002-08-14 Martin Baulig <martin@gnome.org>
9993 * statement.cs (MyStructInfo.MyStructInfo): Don't call
9994 Type.GetFields on dynamic types but get the fields from the
9995 corresponding TypeContainer.
9996 (MyStructInfo.GetStructInfo): Added check for enum types.
9998 * typemanager.cs (MemberList.IsSynchronized): Implemented.
9999 (MemberList.SyncRoot): Implemented.
10000 (TypeManager.FilterWithClosure): No need to check permissions if
10001 closure_start_type == closure_invocation_type, don't crash if
10002 closure_invocation_type is null.
10004 2002-08-13 Martin Baulig <martin@gnome.org>
10006 Rewrote TypeContainer.FindMembers to use a member cache. This
10007 gives us a speed increase of about 35% for the self-hosting MCS
10008 build and of about 15-20% for the class libs (both on GNU/Linux).
10010 * report.cs (Timer): New class to get enhanced profiling. This
10011 whole class is "TIMER" conditional since it remarkably slows down
10014 * class.cs (MemberList): New class. This is an IList wrapper
10015 which we're now using instead of passing MemberInfo[]'s around to
10016 avoid copying this array unnecessarily.
10017 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
10018 (ICachingMemberFinder, IMemberContainer): New interface.
10019 (TypeManager.FilterWithClosure): If `criteria' is null, the name
10020 has already been checked, otherwise use it for the name comparision.
10021 (TypeManager.FindMembers): Renamed to RealMemberFinder and
10022 provided wrapper which tries to use ICachingMemberFinder.FindMembers
10023 if possible. Returns a MemberList, not a MemberInfo [].
10024 (TypeHandle): New class, implements IMemberContainer. We create
10025 one instance of this class per type, it contains a MemberCache
10026 which is used to do the member lookups.
10027 (MemberCache): New class. Each instance of this class contains
10028 all members of a type and a name-based hash table.
10029 (MemberCache.FindMembers): This is our new member lookup
10030 function. First, it looks up all members of the requested name in
10031 the hash table. Then, it walks this list and sorts out all
10032 applicable members and returns them.
10034 2002-08-13 Martin Baulig <martin@gnome.org>
10036 In addition to a nice code cleanup, this gives us a performance
10037 increase of about 1.4% on GNU/Linux - not much, but it's already
10038 half a second for the self-hosting MCS compilation.
10040 * typemanager.cs (IMemberFinder): New interface. It is used by
10041 TypeManager.FindMembers to call FindMembers on a TypeContainer,
10042 Enum, Delegate or Interface.
10043 (TypeManager.finder_to_member_finder): New PtrHashtable.
10044 (TypeManager.finder_to_container): Removed.
10045 (TypeManager.finder_to_delegate): Removed.
10046 (TypeManager.finder_to_interface): Removed.
10047 (TypeManager.finder_to_enum): Removed.
10049 * interface.cs (Interface): Implement IMemberFinder.
10051 * delegate.cs (Delegate): Implement IMemberFinder.
10053 * enum.cs (Enum): Implement IMemberFinder.
10055 * class.cs (TypeContainer): Implement IMemberFinder.
10057 2002-08-12 Martin Baulig <martin@gnome.org>
10059 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
10061 2002-08-12 Martin Baulig <martin@gnome.org>
10063 * ecore.cs (ITypeExpression): New interface for expressions which
10065 (TypeExpression): Renamed to TypeLookupExpression.
10066 (Expression.DoResolve): If we're doing a types-only lookup, the
10067 expression must implement the ITypeExpression interface and we
10068 call DoResolveType() on it.
10069 (SimpleName): Implement the new ITypeExpression interface.
10070 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
10071 hack, the situation that we're only looking up types can't happen
10072 anymore when this method is called. Moved the type lookup code to
10073 DoResolveType() and call it.
10074 (SimpleName.DoResolveType): This ITypeExpression interface method
10075 is now doing the types-only lookup.
10076 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
10077 (ResolveFlags): Added MaskExprClass.
10079 * expression.cs (MemberAccess): Implement the ITypeExpression
10081 (MemberAccess.DoResolve): Added support for a types-only lookup
10082 when we're called via ITypeExpression.DoResolveType().
10083 (ComposedCast): Implement the ITypeExpression interface.
10085 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
10086 Expression.Resolve() with ResolveFlags.Type instead.
10088 2002-08-12 Martin Baulig <martin@gnome.org>
10090 * interface.cs (Interface.Define): Apply attributes.
10092 * attribute.cs (Attribute.ApplyAttributes): Added support for
10093 interface attributes.
10095 2002-08-11 Martin Baulig <martin@gnome.org>
10097 * statement.cs (Block.Emit): Only check the "this" variable if we
10098 do not always throw an exception.
10100 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
10101 whether the property has a set accessor.
10103 2002-08-11 Martin Baulig <martin@gnome.org>
10105 Added control flow analysis support for structs.
10107 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
10108 with control flow analysis turned off.
10109 (IVariable): New interface.
10110 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
10111 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
10112 (FieldExpr.DoResolve): Resolve the instance expression with flow
10113 analysis turned off and do the definite assignment check after the
10114 resolving when we know what the expression will resolve to.
10116 * expression.cs (LocalVariableReference, ParameterReference):
10117 Implement the new IVariable interface, only call the flow analysis
10118 code if ec.DoFlowAnalysis is true.
10119 (This): Added constructor which takes a Block argument. Implement
10120 the new IVariable interface.
10121 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
10122 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
10123 This does the definite assignment checks for struct members.
10125 * class.cs (Constructor.Emit): If this is a non-static `struct'
10126 constructor which doesn't have any initializer, call
10127 Block.AddThisVariable() to tell the flow analysis code that all
10128 struct elements must be initialized before control returns from
10131 * statement.cs (MyStructInfo): New public class.
10132 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
10133 argument to this indexer. If non-zero, check an individual struct
10134 member, not the whole struct.
10135 (FlowBranching.CheckOutParameters): Check struct members.
10136 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
10137 overloaded versions of these methods which take an additional
10138 `int field_idx' argument to check struct members.
10139 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
10140 overloaded versions of these methods which take an additional
10141 `string field_name' argument to check struct member.s
10142 (VariableInfo): Implement the IVariable interface.
10143 (VariableInfo.StructInfo): New public property. Returns the
10144 MyStructInfo instance of the variable if it's a struct or null.
10145 (Block.AddThisVariable): New public method. This is called from
10146 Constructor.Emit() for non-static `struct' constructor which do
10147 not have any initializer. It creates a special variable for the
10148 "this" instance variable which will be checked by the flow
10149 analysis code to ensure that all of the struct's fields are
10150 initialized before control returns from the constructor.
10151 (UsageVector): Added support for struct members. If a
10152 variable/parameter is a struct with N members, we reserve a slot
10153 in the usage vector for each member. A struct is considered fully
10154 initialized if either the struct itself (slot 0) or all its
10155 members are initialized.
10157 2002-08-08 Martin Baulig <martin@gnome.org>
10159 * driver.cs (Driver.MainDriver): Only report an error CS5001
10160 if there were no compilation errors.
10162 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
10163 `UnsafeContext' property to determine whether the parent is in
10164 unsafe context rather than checking the parent's ModFlags:
10165 classes nested in an unsafe class are unsafe as well.
10167 2002-08-08 Martin Baulig <martin@gnome.org>
10169 * statement.cs (UsageVector.MergeChildren): Distinguish between
10170 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
10171 we return. Added test17() and test18() to test-154.cs.
10173 2002-08-08 Martin Baulig <martin@gnome.org>
10175 * typemanager.cs (TypeManager.FilterWithClosure): If we have
10176 Family access, make sure the invoking type isn't a subclass of the
10177 queried type (that'd be a CS1540).
10179 * ecore.cs (Expression.MemberLookup): Added overloaded version of
10180 this method which takes an additional `Type invocation_type'.
10182 * expression.cs (BaseAccess.DoResolve): Use the base type as
10183 invocation and query type.
10184 (MemberAccess.DoResolve): If the lookup failed and we're about to
10185 report a CS0122, try a lookup with the ec.ContainerType - if this
10186 succeeds, we must report a CS1540.
10188 2002-08-08 Martin Baulig <martin@gnome.org>
10190 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
10191 (MethodGroupExpr): Implement the IMemberExpr interface.
10193 * expression (MemberAccess.ResolveMemberAccess): No need to have
10194 any special code for MethodGroupExprs anymore, they're now
10197 2002-08-08 Martin Baulig <martin@gnome.org>
10199 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
10200 Family, FamANDAssem and FamORAssem permissions.
10201 (TypeManager.IsSubclassOrNestedChildOf): New public method.
10203 2002-08-08 Martin Baulig <martin@gnome.org>
10205 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
10206 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
10209 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
10211 * driver.cs: implemented /resource option to embed managed resources.
10213 2002-08-07 Martin Baulig <martin@gnome.org>
10215 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
10216 (FieldBase.HasFieldInitializer): New public property.
10217 (FieldBase.GetInitializerExpression): New public method. Resolves and
10218 returns the field initializer and makes sure it is only resolved once.
10219 (TypeContainer.EmitFieldInitializers): Call
10220 FieldBase.GetInitializerExpression to get the initializer, this ensures
10221 that it isn't resolved multiple times.
10223 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
10224 the resolving process (SimpleName/MemberLookup) that we're currently
10225 emitting a field initializer (which must not access any instance members,
10226 this is an error CS0236).
10228 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
10229 argument, if the `IsFieldInitializer' flag is set, we must report and
10230 error CS0236 and not an error CS0120.
10232 2002-08-07 Martin Baulig <martin@gnome.org>
10234 * ecore.cs (IMemberExpr): New public interface.
10235 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
10236 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
10237 if the expression is an IMemberExpr.
10239 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
10240 to be null, implicitly default to `this' if we're non-static in
10241 this case. Simplified the code a lot by using the new IMemberExpr
10242 interface. Also fixed bug #28176 here.
10244 2002-08-06 Martin Baulig <martin@gnome.org>
10246 * cs-parser.jay (SimpleLookup): Removed. We need to create
10247 ParameterReferences during semantic analysis so that we can do a
10248 type-only search when resolving Cast, TypeOf and SizeOf.
10249 (block): Pass the `current_local_parameters' to the Block's
10252 * class.cs (ConstructorInitializer): Added `Parameters parameters'
10253 argument to the constructor.
10254 (ConstructorInitializer.Resolve): Create a temporary implicit
10255 block with the parameters.
10257 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
10258 references here if we aren't doing a type-only search.
10260 * statement.cs (Block): Added constructor which takes a
10261 `Parameters parameters' argument.
10262 (Block.Parameters): New public property.
10264 * support.cs (InternalParameters.Parameters): Renamed `parameters'
10265 to `Parameters' and made it public readonly.
10267 2002-08-06 Martin Baulig <martin@gnome.org>
10269 * ecore.cs (Expression.Warning): Made this public as well.
10271 * report.cs (Report.Debug): Print the contents of collections.
10273 2002-08-06 Martin Baulig <martin@gnome.org>
10275 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
10276 used to tell Resolve() which kinds of expressions it may return.
10277 (Expression.Resolve): Added overloaded version of this method which
10278 takes a `ResolveFlags flags' argument. This can be used to tell
10279 Resolve() which kinds of expressions it may return. Reports a
10281 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
10282 ResolveFlags.SimpleName.
10283 (Expression.Error118): Added overloaded version of this method which
10284 takes a `ResolveFlags flags' argument. It uses the flags to determine
10285 which kinds of expressions are allowed.
10287 * expression.cs (Argument.ResolveMethodGroup): New public method.
10288 Resolves an argument, but allows a MethodGroup to be returned.
10289 This is used when invoking a delegate.
10291 * TODO: Updated a bit.
10293 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10295 Fixed compilation with csc.
10297 * ecore.cs: Expression.Error made public. Is this correct? Should
10298 Warning be made public too?
10300 * expression.cs: use ea.Location instead of ea.loc.
10301 [FIXME: Filed as bug #28607: MCS must report these errors.]
10303 2002-08-06 Martin Baulig <martin@gnome.org>
10305 * ecore.cs (Expression.loc): Moved the location here instead of
10306 duplicating it in all derived classes.
10307 (Expression.Location): New public property.
10308 (Expression.Error, Expression.Warning): Made them non-static and
10309 removed the location argument.
10310 (Expression.Warning): Added overloaded version which takes an
10311 `int level' argument.
10312 (Expression.Error118): Make this non-static and removed the
10313 expression and location arguments.
10314 (TypeExpr): Added location argument to the constructor.
10316 * expression.cs (StaticCallExpr): Added location argument to
10318 (Indirection, PointerArithmetic): Likewise.
10319 (CheckedExpr, UnCheckedExpr): Likewise.
10320 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
10321 (StringPtr): Likewise.
10324 2002-08-05 Martin Baulig <martin@gnome.org>
10326 * expression.cs (BaseAccess.DoResolve): Actually report errors.
10328 * assign.cs (Assign.DoResolve): Check whether the source
10329 expression is a value or variable.
10331 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
10332 while resolving the corresponding blocks.
10334 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
10335 an error, don't silently return null.
10337 * statement.cs (Block.AddVariable): Do the error reporting here
10338 and distinguish between CS0128 and CS0136.
10339 (Block.DoResolve): Report all unused labels (warning CS0164).
10340 (LabeledStatement): Pass the location to the constructor.
10341 (LabeledStatement.HasBeenReferenced): New property.
10342 (LabeledStatement.Resolve): Set it to true here.
10344 * statement.cs (Return.Emit): Return success even after reporting
10345 a type mismatch error (CS0126 or CS0127), this is what csc does and
10346 it avoids confusing the users with any consecutive errors.
10348 2002-08-05 Martin Baulig <martin@gnome.org>
10350 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
10352 * const.cs (Const.LookupConstantValue): Catch circular definitions.
10354 * expression.cs (MemberAccess.DoResolve): Silently return if an
10355 error has already been reported.
10357 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
10358 error has already been reported.
10360 2002-08-05 Martin Baulig <martin@gnome.org>
10362 * statement.cs (UsageVector): Only initialize the `parameters'
10363 vector if we actually have any "out" parameters.
10365 2002-08-05 Martin Baulig <martin@gnome.org>
10367 * expression.cs (Binary.ResolveOperator): When combining delegates,
10368 they must have the same type.
10370 2002-08-05 Martin Baulig <martin@gnome.org>
10372 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
10373 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
10374 work with the ms runtime and we also don't need it: if we're a
10375 PropertyBuilder and not in the `indexer_arguments' hash, then we
10376 are a property and not an indexer.
10378 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
10379 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
10380 since the latter one doesn't work with the ms runtime.
10382 2002-08-03 Martin Baulig <martin@gnome.org>
10384 Fixed bugs #27998 and #22735.
10386 * class.cs (Method.IsOperator): New public field.
10387 (Method.CheckBase): Report CS0111 if there's already a method
10388 with the same parameters in the current class. Report CS0508 when
10389 attempting to change the return type of an inherited method.
10390 (MethodData.Emit): Report CS0179 if a method doesn't have a body
10391 and it's not marked abstract or extern.
10392 (PropertyBase): New abstract base class for Property and Indexer.
10393 (PropertyBase.CheckBase): Moved here from Property and made it work
10395 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
10396 the same so we can reuse it there.
10397 (Property, Indexer): Derive from PropertyBase.
10398 (MethodSignature.inheritable_property_signature_filter): New delegate
10399 to find properties and indexers.
10401 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
10402 argument and improved error reporting.
10404 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
10405 EmptyReadOnlyParameters and made it a property.
10407 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
10408 version of this method which takes a `PropertyInfo indexer'.
10409 (TypeManager.RegisterIndexer): New method.
10411 * class.cs: Added myself as author of this file :-)
10413 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10415 * class.cs: fixed compilation on windoze.
10417 2002-08-03 Martin Baulig <martin@gnome.org>
10419 * interface.cs (Interface.GetInterfaceBases): Check whether all
10420 base interfaces are at least as accessible than the current one.
10422 * class.cs (TypeContainer.GetClassBases): Check whether base types
10423 are at least as accessible than the current type.
10424 (TypeContainer.AsAccessible): Implemented and made non-static.
10425 (MemberBase.CheckParameters): Report errors if the accessibility
10428 * delegate.cs (Delegate.Delegate): The default visibility is
10429 internal for top-level types and private for nested types.
10430 (Delegate.Define): Report errors if the accessibility checks fail.
10432 * enum.cs (Enum.Enum): The default visibility is internal for
10433 top-level types and private for nested types.
10434 (Enum.DefineType): Compute the correct visibility.
10436 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
10437 function which takes a `bool is_toplevel' instead of a TypeContainer.
10439 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
10442 2002-08-02 Martin Baulig <martin@gnome.org>
10444 * expression.cs (LocalVariableReferenc): Added constructor which
10445 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
10446 (LocalVariableReference.IsReadOnly): New property.
10447 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
10448 variable is readonly, use our own readonly flag to do this; you can
10449 use the new constructor to get a writable reference to a read-only
10452 * cs-parser.jay (foreach_statement, using_statement): Get a writable
10453 reference to the local variable.
10455 2002-08-01 Miguel de Icaza <miguel@ximian.com>
10457 * rootcontext.cs (ResolveCore): Also include System.Exception
10459 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
10460 we reach an EmptyStatement.
10462 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
10465 * expression.cs (Binary.ResolveOperator): Check error result in
10468 use brtrue/brfalse directly and avoid compares to null.
10470 2002-08-02 Martin Baulig <martin@gnome.org>
10472 * class.cs (TypeContainer.Define): Define all nested interfaces here.
10473 Fixes bug #28407, added test-155.cs.
10475 2002-08-01 Martin Baulig <martin@gnome.org>
10477 * class.cs (Event.EmitDefaultMethod): Make this work with static
10478 events. Fixes #28311, added verify-3.cs.
10480 2002-08-01 Martin Baulig <martin@gnome.org>
10482 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
10483 `is_disposable' fields.
10484 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
10485 `hm.is_disposable' if we're using the collection pattern.
10486 (Foreach.EmitCollectionForeach): Use the correct type for the
10487 enumerator's local variable, only emit the try/finally block if
10488 necessary (fixes #27713).
10490 2002-08-01 Martin Baulig <martin@gnome.org>
10492 * ecore.cs (Expression.report118): Renamed to Error118 and made
10495 * statement.cs (Throw.Resolve): Check whether the expression is of
10496 the correct type (CS0118) and whether the type derives from
10497 System.Exception (CS0155).
10498 (Catch.Resolve): New method. Do the type lookup here and check
10499 whether it derives from System.Exception (CS0155).
10500 (Catch.CatchType, Catch.IsGeneral): New public properties.
10502 * typemanager.cs (TypeManager.exception_type): Added.
10504 2002-07-31 Miguel de Icaza <miguel@ximian.com>
10506 * driver.cs: Updated About function.
10508 2002-07-31 Martin Baulig <martin@gnome.org>
10510 Implemented Control Flow Analysis.
10512 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
10513 (EmitContext.CurrentBranching): Added.
10514 (EmitContext.StartFlowBranching): Added.
10515 (EmitContext.EndFlowBranching): Added.
10516 (EmitContext.KillFlowBranching): Added.
10517 (EmitContext.IsVariableAssigned): Added.
10518 (EmitContext.SetVariableAssigned): Added.
10519 (EmitContext.IsParameterAssigned): Added.
10520 (EmitContext.SetParameterAssigned): Added.
10521 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
10522 Added control flow analysis stuff here.
10524 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
10525 resolve the expression as lvalue.
10526 (LocalVariableReference.DoResolve): Check whether the variable has
10527 already been assigned.
10528 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
10529 the parameter as assigned here.
10530 (ParameterReference.DoResolve): Check whether the parameter has already
10532 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
10533 expression as lvalue.
10535 * statement.cs (FlowBranching): New class for the flow analysis code.
10536 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
10537 (LabeledStatement.IsDefined): New public property.
10538 (LabeledStatement.AddUsageVector): New public method to tell flow
10539 analyis that the label may be reached via a forward jump.
10540 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
10542 (VariableInfo.Number): New public field. This is used by flow analysis
10543 to number all locals of a block.
10544 (Block.CountVariables): New public property. This is the number of
10545 local variables in this block (including the locals from all parent
10547 (Block.EmitMeta): Number all the variables.
10549 * statement.cs: Added flow analysis support to all classes.
10551 2002-07-31 Martin Baulig <martin@gnome.org>
10553 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
10554 To get debugging messages, compile mcs with /define:MCS_DEBUG and
10555 then use this argument.
10557 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
10559 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
10560 use this to specify /define options.
10562 2002-07-29 Martin Baulig <martin@gnome.org>
10564 * statement.cs (Fixed): Moved all code that does variable lookups
10565 and resolvings from Emit to Resolve.
10567 * statement.cs (For): Moved all code that does variable lookups
10568 and resolvings from Emit to Resolve.
10570 * statement.cs (Using): Moved all code that does variable lookups
10571 and resolvings from Emit to Resolve.
10573 2002-07-29 Martin Baulig <martin@gnome.org>
10575 * attribute.cs (Attribute.Resolve): Explicitly catch a
10576 System.NullReferenceException when creating the
10577 CustromAttributeBuilder and report a different warning message.
10579 2002-07-29 Martin Baulig <martin@gnome.org>
10581 * support.cs (ParameterData.ParameterName): Added method to
10582 get the name of a parameter.
10584 * typemanager.cs (TypeManager.IsValueType): New public method.
10586 2002-07-29 Martin Baulig <martin@gnome.org>
10588 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
10589 is a flag which specifies that it's either ref or out.
10590 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
10591 the out parameter to `out Parameter.Modifier mod', also set the
10592 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
10594 * support.cs (InternalParameters.ParameterModifier): Distinguish
10595 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
10596 Parameter.Modifier.ISBYREF flag if it's either ref or out.
10598 * expression.cs (Argument.GetParameterModifier): Distinguish
10599 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
10600 Parameter.Modifier.ISBYREF flag if it's either ref or out.
10602 2002-07-29 Martin Baulig <martin@gnome.org>
10604 * expression.cs (ParameterReference.ParameterReference): Added
10605 `Location loc' argument to the constructor.
10607 * cs-parser.jay: Pass location to ParameterReference.
10609 2002-07-28 Miguel de Icaza <miguel@ximian.com>
10611 * statement.cs (Try): Initialize the location.
10613 * cs-parser.jay: pass location to Try.
10615 * expression.cs (Unary.Reduce): Change the prototype to return
10616 whether a constant fold could be performed or not. The result is
10617 returned in an out parameters. In the case of Indirection and
10618 AddressOf, we want to perform the full tests.
10620 2002-07-26 Miguel de Icaza <miguel@ximian.com>
10622 * statement.cs (Statement.Emit): Flag dead code.
10624 2002-07-27 Andrew Birkett <andy@nobugs.org>
10626 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
10628 2002-07-27 Martin Baulig <martin@gnome.org>
10630 * class.cs (MethodData.Define): Put back call to
10631 TypeManager.AddMethod(), accidentally commented this out.
10633 * report.cs (Debug): New public method to print debugging information,
10634 this is `[Conditional ("DEBUG")]'.
10636 2002-07-26 Martin Baulig <martin@gnome.org>
10638 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
10639 (switch_statement): Push the current_block to the switch_stack and
10640 pop it again when we're done with the switch.
10641 (switch_section): The new block is a child of the current_block.
10642 Fixes bug #24007, added test-152.cs.
10644 2002-07-27 Martin Baulig <martin@gnome.org>
10646 * expression.cs (Invocation.EmitArguments): When calling a varargs
10647 function with only its fixed arguments, we need to pass an empty
10650 2002-07-27 Martin Baulig <martin@gnome.org>
10652 Mono 0.13 has been released.
10654 2002-07-25 Miguel de Icaza <miguel@ximian.com>
10656 * driver.cs: Rename --resource to --linkres, because that is what
10657 we do currently, we dont support --resource yet.
10659 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
10661 2002-07-25 Martin Baulig <martin@gnome.org>
10663 * class.cs (MethodData): New public class. This is a `method builder'
10664 class for a method or one accessor of a Property/Indexer/Event.
10665 (MethodData.GetMethodFlags): Moved here from MemberBase.
10666 (MethodData.ApplyAttributes): Likewise.
10667 (MethodData.ApplyObsoleteAttribute): Likewise.
10668 (MethodData.ApplyConditionalAttribute): Likewise.
10669 (MethodData.ApplyDllImportAttribute): Likewise.
10670 (MethodData.CheckAbstractAndExternal): Likewise.
10671 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
10672 (MethodData.Emit): Formerly known as Method.Emit().
10673 (MemberBase): Moved everything which was specific to a single
10674 accessor/method to MethodData.
10675 (Method): Create a new MethodData and call Define() and Emit() on it.
10676 (Property, Indexer, Event): Create a new MethodData objects for each
10677 accessor and call Define() and Emit() on them.
10679 2002-07-25 Martin Baulig <martin@gnome.org>
10681 Made MethodCore derive from MemberBase to reuse the code from there.
10682 MemberBase now also checks for attributes.
10684 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
10685 (MemberBase.GetMethodFlags): Moved here from class Method and marked
10687 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
10688 `CallingConventions cc' and `Attributes opt_attrs' arguments.
10689 (MemberBase.ApplyAttributes): New virtual method; applies the
10690 attributes to a method or accessor.
10691 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
10692 (MemberBase.ApplyConditionalAttribute): Likewise.
10693 (MemberBase.ApplyDllImportAttribute): Likewise.
10694 (MemberBase.CheckAbstractAndExternal): Likewise.
10695 (MethodCore.ParameterTypes): This is now a property instead of a
10696 method, it's initialized from DoDefineParameters().
10697 (MethodCore.ParameterInfo): Removed the set accessor.
10698 (MethodCore.DoDefineParameters): New protected virtual method to
10699 initialize ParameterTypes and ParameterInfo.
10700 (Method.GetReturnType): We can now simply return the MemberType.
10701 (Method.GetMethodFlags): Override the MemberBase version and add
10702 the conditional flags.
10703 (Method.CheckBase): Moved some code from Define() here, call
10704 DoDefineParameters() here.
10705 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
10706 here to avoid some larger code duplication.
10707 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
10708 ensure that abstract and external accessors don't declare a body.
10710 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
10711 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
10712 lookup in the attribute's parent classes, so we need to abort as soon
10713 as we found the first match.
10714 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
10715 the attribute has no arguments.
10717 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
10720 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10722 * cs-parser.jay: reverted previous patch.
10724 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10726 * cs-parser.jay: fixed bug #22119.
10728 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10730 * attribute.cs: fixed compilation. The error was:
10731 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
10732 be assigned to before control leaves the current method."
10733 [FIXME: Filed as bug #28186: MCS must report this error.]
10735 2002-07-25 Martin Baulig <martin@gnome.org>
10737 * attribute.cs (Attribute.Conditional_GetConditionName): New static
10738 method to pull the condition name ouf of a Conditional attribute.
10739 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
10740 the obsolete message and error flag out of an Obsolete attribute.
10742 * class.cs (Method.GetMethodFlags): New public method to get the
10743 TypeManager.MethodFlags for this method.
10744 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
10746 (Method.Define): Get and apply the Obsolete and Conditional attributes;
10747 if we're overriding a virtual function, set the new private variable
10748 `parent_method'; call the new TypeManager.AddMethod().
10750 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
10751 the MethodBuilder and the Method in a PtrHashtable.
10752 (TypeManager.builder_to_method): Added for this purpose.
10753 (TypeManager.MethodFlags): Added IsObsoleteError.
10754 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
10755 Obsolete and Conditional arguments in MethodBuilders. If we discover
10756 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
10757 the message from the attribute.
10759 2002-07-24 Martin Baulig <martin@gnome.org>
10761 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
10762 preprocessor directives, ensure that the argument to #define/#undef is
10763 exactly one identifier and that it's actually an identifier.
10765 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
10768 2002-07-24 Martin Baulig <martin@gnome.org>
10770 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
10771 initialize it to TypeManager.object_type in the constructor.
10772 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
10773 of the `hm.get_current' method if we're using the collection pattern.
10774 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
10775 for the explicit conversion to make it work when we're using the collection
10776 pattern and the `Current' property has a different return type than `object'.
10779 2002-07-24 Martin Baulig <martin@gnome.org>
10781 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
10782 does not match, but don't report any errors. This method is called in
10783 order for all methods in a MethodGroupExpr until a matching method is
10784 found, so we don't want to bail out if the first method doesn't match.
10785 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
10786 matches, report the 123. Fixes #28070.
10788 2002-07-24 Martin Baulig <martin@gnome.org>
10790 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
10791 TypeManager.TypeToCoreType() to the top of the method so the
10792 following equality checks will work. Fixes #28107.
10794 2002-07-24 Martin Baulig <martin@gnome.org>
10796 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
10797 operand is of type uint, and the other operand is of type sbyte,
10798 short or int, the operands are converted to type long." -
10799 Actually do what this comment already told us. Fixes bug #28106,
10802 2002-07-24 Martin Baulig <martin@gnome.org>
10804 * class.cs (MethodBase): New abstract class. This is now a base
10805 class for Property, Indexer and Event to avoid some code duplication
10806 in their Define() and DefineMethods() methods.
10807 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
10808 generic methods for Define() and DefineMethods().
10809 (FieldBase): Derive from MemberBase, not MemberCore.
10810 (Property): Derive from MemberBase, not MemberCore.
10811 (Property.DefineMethod): Moved all the code from this method to the
10812 new MethodBase.DefineAccessor(), just call it with appropriate
10814 (Property.Define): Call the new Property.DoDefine(), this does some
10815 sanity checks and we don't need to duplicate the code everywhere.
10816 (Event): Derive from MemberBase, not MemberCore.
10817 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
10818 accessors, this will also make them work with interface events.
10819 (Indexer): Derive from MemberBase, not MemberCore.
10820 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
10821 (Indexer.Define): Use the new MethodBase functions.
10823 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
10824 argument to the constructor.
10825 (Interface.FindMembers): Added support for interface events.
10826 (Interface.PopluateEvent): Implemented.
10828 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
10830 2002-07-22 Miguel de Icaza <miguel@ximian.com>
10832 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
10833 but this is required to check for a method name being the same as
10834 the containing class.
10838 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10840 * interface.cs: initialize variable.
10842 2002-07-23 Martin Baulig <martin@gnome.org>
10844 Implemented the IndexerName attribute in interfaces.
10846 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
10847 name if this is an explicit interface implementation.
10848 (Indexer.InterfaceIndexerName): New public variable. If we're
10849 implementing an interface indexer, this is the IndexerName in that
10850 interface. Otherwise, it's the IndexerName.
10851 (Indexer.DefineMethod): If we're implementing interface indexer,
10852 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
10853 and Pending.ImplementIndexer methods.
10854 (Indexer.Define): Also define the PropertyBuilder if we're
10855 implementing an interface indexer and this is neither an explicit
10856 interface implementation nor do the IndexerName match the one in
10859 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
10860 If a method is defined here, then we always need to create a proxy
10861 for it. This is used when implementing interface indexers.
10862 (Pending.IsInterfaceIndexer): New public method.
10863 (Pending.ImplementIndexer): New public method.
10864 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
10865 This is used when implementing interface indexers to define a proxy
10867 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
10868 define a proxy if necessary.
10870 * interface.cs (Interface.IndexerName): New public variable.
10871 (Interface.PopulateIndexer): Set the IndexerName.
10872 (Interface.DefineIndexers): New private method. Populate all the
10873 indexers and make sure their IndexerNames match.
10875 * typemanager.cs (IndexerPropertyName): Added support for interface
10878 2002-07-22 Martin Baulig <martin@gnome.org>
10880 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
10881 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
10882 ret if HasReturnLabel.
10883 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
10886 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
10887 and set the ec.LoopBeginTryCatchLevel.
10888 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
10889 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
10890 the current ec.TryCatchLevel, the branch goes out of an exception
10891 block. In this case, we need to use Leave and not Br.
10893 2002-07-22 Martin Baulig <martin@gnome.org>
10895 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
10896 block unless the block does not always return or it is contained in
10897 another try { ... } catch { ... } block. Fixes bug #26506.
10898 Added verify-1.cs to the test suite.
10900 2002-07-22 Martin Baulig <martin@gnome.org>
10902 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
10903 then we do not always return. Fixes bug #24985.
10905 2002-07-22 Martin Baulig <martin@gnome.org>
10907 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
10908 lookup on a per-class level; ie. walk up the class hierarchy until we
10909 found at least one applicable method, then choose the best among them.
10910 Fixes bug #24463 and test-29.cs.
10912 2002-07-22 Martin Baulig <martin@gnome.org>
10914 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
10915 return types of the methods. The return type is not part of the
10916 signature and we must not check it to make the `new' modifier work.
10917 Fixes bug #27999, also added test-147.cs.
10918 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
10920 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
10921 on the method's return type.
10923 2002-07-21 Martin Baulig <martin@gnome.org>
10925 * assign.cs: Make this work if the rightmost source is a constant and
10926 we need to do an implicit type conversion. Also adding a few more tests
10927 to test-38.cs which should have caught this.
10929 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
10930 target in the makefile for this. The makefile.gnu is primarily intended
10931 for end-users who don't want to debug the compiler.
10933 2002-07-21 Martin Baulig <martin@gnome.org>
10935 * assign.cs: Improved the Assign class so it can now handle embedded
10936 assignments (X = Y = Z = something). As a side-effect this'll now also
10937 consume less local variables. test-38.cs now passes with MCS, added
10938 a few new test cases to that test.
10940 2002-07-20 Martin Baulig <martin@gnome.org>
10942 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
10943 instructions. Fixes bug #27977, also added test-146.cs.
10945 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10947 * cs-tokenizer.cs: fixed getHex ().
10949 2002-07-19 Martin Baulig <martin@gnome.org>
10951 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
10952 not Type.GetType() to lookup the array type. This is needed when
10953 we're constructing an array of a user-defined type.
10954 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
10955 single-dimensional arrays, but also for single-dimensial arrays of
10958 2002-07-19 Martin Baulig <martin@gnome.org>
10960 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
10961 this function is called, it's not allowed to share LocalBuilders
10962 among ILGenerators.
10964 2002-07-19 Martin Baulig <martin@gnome.org>
10966 * expression.cs (Argument.Resolve): Report an error 118 when trying
10967 to pass a type as argument.
10969 2002-07-18 Martin Baulig <martin@gnome.org>
10971 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
10972 Conv_R_Un for the signed `long' type.
10974 2002-07-15 Miguel de Icaza <miguel@ximian.com>
10976 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
10977 `expr' for the temporary result, as that will fail if we do
10978 multiple resolves on the same expression.
10980 2002-07-05 Miguel de Icaza <miguel@ximian.com>
10982 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
10983 ec.TypeContainer for looking up aliases.
10985 * class.cs (TypeContainer): Remove LookupAlias from here.
10987 * decl.cs (DeclSpace); Move here.
10989 2002-07-01 Miguel de Icaza <miguel@ximian.com>
10991 * class.cs (FindMembers): Only call filter if the constructor
10992 bulider is not null.
10994 Also handle delegates in `NestedTypes' now. Now we will perform
10995 type lookups using the standard resolution process. This also
10998 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
10999 This uses Expressions (the limited kind that can be parsed by the
11000 tree) instead of strings.
11002 * expression.cs (ComposedCast.ToString): Implement, used to flag
11003 errors since now we have to render expressions.
11005 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
11008 * ecore.cs (SimpleName.ToString): ditto.
11010 * cs-parser.jay: Instead of using strings to assemble types, use
11011 Expressions to assemble the type (using SimpleName, ComposedCast,
11012 MemberAccess). This should fix the type lookups in declarations,
11013 because we were using a different code path for this.
11015 * statement.cs (Block.Resolve): Continue processing statements
11016 even when there is an error.
11018 2002-07-17 Miguel de Icaza <miguel@ximian.com>
11020 * class.cs (Event.Define): Also remove the `remove' method from
11021 the list of pending items.
11023 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
11024 generate more compact code.
11026 2002-07-17 Martin Baulig <martin@gnome.org>
11028 * const.cs (Const.LookupConstantValue): Add support for constant
11029 `unchecked' and `checked' expressions.
11030 Also adding test case test-140.cs for this.
11032 2002-07-17 Martin Baulig <martin@gnome.org>
11034 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
11035 check whether mi.ReturnType implements the IEnumerator interface; the
11036 `==' and the IsAssignableFrom() will fail in this situation.
11038 2002-07-16 Ravi Pratap <ravi@ximian.com>
11040 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
11043 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11045 * expression.cs: fixed bug #27811.
11047 2002-07-14 Miguel de Icaza <miguel@ximian.com>
11049 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
11050 Molaro: when we are a ref, the value already contains a pointer
11051 value, do not take the address of it.
11053 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
11054 * removed mb-parser.jay and mb-tokenizer.cs
11056 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
11058 * expression.cs: check against the building corlib void type.
11060 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
11062 * ecore.cs: fix for valuetype static readonly fields: when
11063 initializing them, we need their address, not the address of a copy.
11065 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
11067 * typemanager.cs: register also enum_type in corlib.
11069 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
11071 * class.cs: allow calling this (but not base) initializers in structs.
11073 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
11075 * ecore.cs: make sure we compare against the building base types
11078 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
11080 * typemanager.cs: fix TypeToCoreType() to handle void and object
11081 (corlib gets no more typerefs after this change).
11083 2002-07-12 Miguel de Icaza <miguel@ximian.com>
11085 * expression.cs (ArrayCreation.EmitArrayArguments): use
11086 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
11088 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
11089 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
11090 array indexes, the runtime actually forbids them.
11092 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
11093 for array arguments here.
11095 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
11096 instead of the default for ValueTypes.
11098 (New.DoEmit): Use IsValueType instead of
11099 IsSubclassOf (value_type)
11100 (New.DoResolve): ditto.
11101 (Invocation.EmitCall): ditto.
11103 * assign.cs (Assign): ditto.
11105 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
11106 Statements *are* currently doing part of their resolution during
11109 Expressions do always resolve during resolve, but statements are
11110 only required to propagate resolution to their children.
11112 2002-07-11 Miguel de Icaza <miguel@ximian.com>
11114 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
11116 (LoadAssembly): Do not add the dll if it is already specified
11118 (MainDriver): Add the System directory to the link path at the end,
11119 after all the other -L arguments.
11121 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
11122 wrong opcode for loading bytes and bools (ldelem.i1 instead of
11123 ldelem.u1) and using the opposite for sbytes.
11125 This fixes Digger, and we can finally run it.
11127 * driver.cs (UnixParseOption): Move the option parsing here.
11128 (CSCParseOption): Implement CSC-like parsing of options.
11130 We now support both modes of operation, the old Unix way, and the
11131 new CSC-like way. This should help those who wanted to make cross
11132 platform makefiles.
11134 The only thing broken is that /r:, /reference: and /lib: are not
11135 implemented, because I want to make those have the same semantics
11136 as the CSC compiler has, and kill once and for all the confussion
11137 around this. Will be doing this tomorrow.
11139 * statement.cs (Unsafe.Resolve): The state is checked during
11140 resolve, not emit, so we have to set the flags for IsUnsfe here.
11142 2002-07-10 Miguel de Icaza <miguel@ximian.com>
11144 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
11145 not catch the Error_ObjectRefRequired in SimpleName (as it is
11146 possible to have a class/instance variable name that later gets
11147 deambiguated), we have to check this here.
11149 2002-07-10 Ravi Pratap <ravi@ximian.com>
11151 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
11152 make static and put into Expression.
11154 (Event.Define): Register the private field of the event with the
11155 TypeManager so that GetFieldFromEvent can get at it.
11157 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
11158 keep track of the private field associated with an event which
11161 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
11164 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
11166 2002-07-10 Miguel de Icaza <miguel@ximian.com>
11168 * expression.cs (Binary.EmitBranchable): this routine emits the
11169 Binary expression in a branchable context. This basically means:
11170 we need to branch somewhere, not just get the value on the stack.
11172 This works together with Statement.EmitBoolExpression.
11174 * statement.cs (Statement.EmitBoolExpression): Use
11177 2002-07-09 Miguel de Icaza <miguel@ximian.com>
11179 * statement.cs (For): Reduce the number of jumps in loops.
11181 (For): Implement loop inversion for the For statement.
11183 (Break): We can be breaking out of a Try/Catch controlled section
11184 (foreach might have an implicit try/catch clause), so we need to
11185 use Leave instead of Br.
11187 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
11188 now). If the instace expression supports IMemoryLocation, we use
11189 the AddressOf method from the IMemoryLocation to extract the
11190 address instead of emitting the instance.
11192 This showed up with `This', as we were emitting the instance
11193 always (Emit) instead of the Address of This. Particularly
11194 interesting when This is a value type, as we dont want the Emit
11195 effect (which was to load the object).
11197 2002-07-08 Miguel de Icaza <miguel@ximian.com>
11199 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
11201 * statement.cs (Checked): Set the CheckedState during the resolve
11202 process too, as the ConvCast operations track the checked state on
11203 the resolve process, and not emit.
11205 * cs-parser.jay (namespace_member_declaration): Flag that we have
11206 found a declaration when we do. This is used to flag error 1529
11208 * driver.cs: Report ok when we display the help only.
11210 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
11212 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
11214 2002-07-04 Miguel de Icaza <miguel@ximian.com>
11216 * cs-tokenizer.cs (define): We also have to track locally the
11217 defines. AllDefines is just used for the Conditional Attribute,
11218 but we also need the local defines for the current source code.
11220 2002-07-03 Miguel de Icaza <miguel@ximian.com>
11222 * statement.cs (While, For, Do): These loops can exit through a
11223 Break statement, use this information to tell whether the
11224 statement is the last piece of code.
11226 (Break): Flag that we break.
11228 * codegen.cs (EmitContexts): New `Breaks' state variable.
11230 2002-07-03 Martin Baulig <martin@gnome.org>
11232 * class.cs (TypeContainer.MethodModifiersValid): Allow override
11233 modifiers in method declarations in structs. Otherwise, you won't
11234 be able to override things like Object.Equals().
11236 2002-07-02 Miguel de Icaza <miguel@ximian.com>
11238 * class.cs (Method, Property, Indexer): Do not allow the public
11239 modifier to be used in explicit interface implementations.
11241 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
11242 override modifiers in method declarations in structs
11244 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
11246 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
11247 integer or real overflow, report an error
11249 2002-07-02 Martin Baulig <martin@gnome.org>
11251 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
11252 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
11253 to tell the runtime about our newly created System.Object and
11254 System.ValueType types.
11256 2002-07-02 Miguel de Icaza <miguel@ximian.com>
11258 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
11259 struct instead of Ldarg/Starg.
11261 2002-07-02 Martin Baulig <martin@gnome.org>
11263 * expression.cs (Indirection.Indirection): Call
11264 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
11266 2002-07-02 Martin Baulig <martin@gnome.org>
11268 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
11269 ValueType, call TypeManager.TypeToCoreType() on it.
11270 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
11271 the OpCodes.Newarr argument.
11273 2002-07-02 Martin Baulig <martin@gnome.org>
11275 * expression.cs (Invocation.EmitCall): When compiling corlib,
11276 replace all calls to the system's System.Array type to calls to
11277 the newly created one.
11279 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
11280 System.Array methods.
11281 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
11282 from the system's System.Array type which must be replaced.
11284 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
11286 * typemanager.cs: load unverifiable_code_ctor so we can build
11287 corlib using the correct type. Avoid using GetTypeCode() with
11289 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
11290 TypeManager.object_type to allow building corlib.
11292 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
11294 * ecore.cs: handle System.Enum separately in LoadFromPtr().
11296 2002-07-01 Martin Baulig <martin@gnome.org>
11298 * class.cs: Make the last change actually work, we need to check
11299 whether `ifaces != null' to avoid a crash.
11301 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
11303 * class.cs: when we build structs without fields that implement
11304 interfaces, we need to add the interfaces separately, since there is
11305 no API to both set the size and add the interfaces at type creation
11308 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
11310 * expression.cs: the dimension arguments to the array constructors
11311 need to be converted if they are a long.
11313 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
11315 * class.cs: don't emit ldarg.0 if there is no parent constructor
11316 (fixes showstopper for corlib).
11318 2002-06-29 Martin Baulig <martin@gnome.org>
11320 MCS now compiles corlib on GNU/Linux :-)
11322 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
11323 ie. check for MethodImplOptions.InternalCall.
11325 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
11326 and TypeManager.attribute_type are null, so we must explicitly check
11327 whether parent is not null to find out whether it's an attribute type.
11328 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
11329 and SetBuilder, not only if the property is neither abstract nor external.
11330 This is necessary to set the MethodImplOptions on the accessor methods.
11331 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
11332 SetBuilder, see Property.Emit().
11334 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
11335 populate "System.Object", "System.ValueType" and "System.Attribute" since
11336 they've already been populated from BootCorlib_PopulateCoreTypes().
11338 2002-06-29 Martin Baulig <martin@gnome.org>
11340 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
11341 is the NullLiteral, we also need to make sure that target_type is not
11344 2002-06-29 Martin Baulig <martin@gnome.org>
11346 * rootcontext.cs (RootContext.ResolveCore): We must initialize
11347 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
11348 before calling BootstrapCorlib_ResolveDelegate ().
11350 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11352 * statement.cs: fixed build-breaker. All tests passed ok.
11354 2002-06-27 Martin Baulig <martin@gnome.org>
11356 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
11357 for System.Decimal when compiling corlib.
11359 2002-06-27 Martin Baulig <martin@gnome.org>
11361 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
11362 switch blocks which contain nothing but a default clause.
11364 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
11366 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
11368 2002-06-27 Martin Baulig <martin@gnome.org>
11370 * ecore.cs (PropertyExpr.PropertyExpr): Call
11371 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
11373 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
11374 is already a TypeBuilder.
11376 2002-06-27 Martin Baulig <martin@gnome.org>
11378 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
11379 `target_type == TypeManager.array_type', not IsAssignableFrom() in
11380 the "from an array-type to System.Array" case. This makes it work
11381 when compiling corlib.
11383 2002-06-27 Martin Baulig <martin@gnome.org>
11385 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
11386 non-static PropertyExpr, set its InstanceExpression. This makes
11387 the `ICollection.Count' property work in System/Array.cs.
11389 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
11391 * driver.cs: Made error handling more consistent. Errors now
11392 tracked by Report class, so many methods which used to return int
11393 now return void. Main() now prints success/failure and
11394 errors/warnings message.
11396 Renamed '--probe' compiler argument to '--expect-error'. Removed
11397 the magic number return values (123 and 124). Now, if the
11398 expected error occurs, the compiler exits with success (exit value
11399 0). If the compilation completes without seeing that particular
11400 error, the compiler exits with failure (exit value 1). The
11401 makefile in mcs/errors has been changed to handle the new behaviour.
11403 * report.cs: Made 'expected error' number a property and renamed
11404 it from 'Probe' to 'ExpectedError'.
11406 * genericparser.cs: Removed error handling support, since it is
11407 now all done by Report class.
11409 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
11410 class, so parse() no longer returns an int.
11412 * namespace.cs: Use Report.Error instead of GenericParser.error
11414 2002-06-22 Miguel de Icaza <miguel@ximian.com>
11416 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
11417 TypeContainer.AddOperator): At the front of the list put the
11418 explicit implementations, so they get resolved/defined first.
11420 2002-06-21 Miguel de Icaza <miguel@ximian.com>
11422 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
11423 interface type is implemented by this TypeContainer. Used during
11424 explicit interface implementation.
11426 (Property.Define, Indexer.Define, Method.Define): Validate that
11427 the given interface in the explicit implementation is one of the
11428 base classes for the containing type.
11430 Also if we are explicitly implementing an interface, but there is
11431 no match in the pending implementation table, report an error.
11433 (Property.Define): Only define the property if we are
11434 not explicitly implementing a property from an interface. Use the
11435 correct name also for those properties (the same CSC uses,
11436 although that is really not needed).
11438 (Property.Emit): Do not emit attributes for explicitly implemented
11439 properties, as there is no TypeBuilder.
11441 (Indexer.Emit): ditto.
11443 Hiding then means that we do not really *implement* a pending
11444 implementation, which makes code fail.
11446 2002-06-22 Martin Baulig <martin@gnome.org>
11448 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
11449 the return value of Object.GetType(). [FIXME: we need to do this whenever
11450 we get a type back from the reflection library].
11452 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
11454 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
11456 2002-06-20 Miguel de Icaza <miguel@ximian.com>
11458 * attribute.cs: Return null if we can not look up the type.
11460 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
11461 the interface types found.
11463 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
11464 interface types found.
11466 * typemanager.cs (GetInterfaces): Make this routine returns alll
11467 the interfaces and work around the lame differences between
11468 System.Type and System.Reflection.Emit.TypeBuilder in the results
11469 result for GetInterfaces.
11471 (ExpandInterfaces): Given an array of interface types, expand and
11472 eliminate repeated ocurrences of an interface. This expands in
11473 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
11476 2002-06-21 Martin Baulig <martin@gnome.org>
11478 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
11481 2002-06-21 Martin Baulig <martin@gnome.org>
11483 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
11484 and called with one of the core types, return the corresponding typebuilder for
11487 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
11490 2002-06-21 Martin Baulig <martin@gnome.org>
11492 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
11493 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
11494 (Expression.ConvertReferenceExplicit): Likewise.
11496 * expression.cs (ElementAccess.DoResolve): Likewise.
11497 (ElementAccess.DoResolveLValue): Likewise.
11499 2002-06-10 Martin Baulig <martin@gnome.org>
11501 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
11502 add the "value" parameter to the parameter list.
11504 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
11507 2002-06-19 Miguel de Icaza <miguel@ximian.com>
11509 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
11510 the argument to an int, uint, long or ulong, per the spec. Also
11511 catch negative constants in array creation.
11513 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
11515 * class.cs: do not allow the same interface to appear twice in
11516 the definition list.
11518 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
11520 * ecore.cs: don't use ldlen with System.Array.
11522 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
11524 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
11526 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
11528 * modifiers.cs: produce correct field attributes for protected
11529 internal. Easy fix so miguel can work on ther harder stuff:-)
11531 2002-06-18 Miguel de Icaza <miguel@ximian.com>
11533 * pending.cs: New file. Move the code from class.cs here.
11534 Support clearning the pending flag for all methods (when not doing
11535 explicit interface implementation).
11537 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
11539 * rootcontext.cs: added a couple more types needed to bootstrap.
11541 2002-06-17 Miguel de Icaza <miguel@ximian.com>
11543 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
11544 constructor in the type, instead of any constructor in the type
11545 hierarchy. Thanks to Paolo for finding this bug (it showed up as
11546 a bug in the Mono runtime when applying the params attribute).
11548 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
11549 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
11551 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
11553 * expression.cs (Unary.ResolveOperator): Use TypeManager
11554 to resolve the type.
11556 2002-06-13 Ravi Pratap <ravi@ximian.com>
11558 * cs-parser.jay (enum_member_declaration): Pass in the attributes
11561 * enum.cs (AddEnumMember): Add support to store the attributes associated
11562 with each member too.
11564 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
11565 field builders too - this takes care of the enum member case.
11567 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
11569 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
11570 address-of operator on both value types and pointers.
11572 2002-06-10 Martin Baulig <martin@gnome.org>
11574 * interface.cs (Interface.PopulateIndexer): Add the indexer's
11575 PropertyBuilder to the `property_builders' list.
11577 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
11578 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
11579 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
11580 find any indexers which are inherited from an interface.
11582 2002-06-09 Martin Baulig <martin@gnome.org>
11584 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
11585 the same type as the constant if necessary. There's also a test-130.cs
11588 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
11590 * typemanager.cs (TypeManager.ChangeType): Previously known as
11591 Enum.ChangeEnumType().
11593 2002-06-09 Martin Baulig <martin@gnome.org>
11595 * expression.cs (Cast.TryReduce): Added support for consts.
11597 2002-06-08 Ravi Pratap <ravi@ximian.com>
11599 * class.cs (Accessor): Hold attributes information so we can pass
11602 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
11603 Modify to pass in attributes attached to the methods.
11605 (add_accessor_declaration, remove_accessor_declaration): Ditto.
11607 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
11608 to handle the Accessor kind :-)
11610 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
11612 2002-06-08 Martin Baulig <martin@gnome.org>
11614 * expression.cs (Unary.TryReduceNegative): Added support for
11617 2002-06-08 Martin Baulig <martin@gnome.org>
11619 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
11620 name can't be found in the `defined_names' - the caller will do a
11621 MemberLookup in this case and thus find methods in System.Enum
11622 such as Enum.IsDefined().
11624 2002-06-08 Martin Baulig <martin@gnome.org>
11626 * enum.cs (Enum.ChangeEnumType): This is a custom version of
11627 Convert.ChangeType() which works with TypeBuilder created types.
11628 (Enum.LookupEnumValue, Enum.Define): Use it here.
11630 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
11631 `TypeBuilder.BaseType != null' check.
11632 (TypeContainer.FindMembers): Only lookup parent members if we
11633 actually have a parent.
11634 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
11635 (ConstructorInitializer.Resolve): Likewise.
11637 * interface.cs (Interface.FindMembers): Added
11638 `TypeBuilder.BaseType != null' check.
11640 * rootcontext.cs (RootContext.ResolveCore): Added
11641 "System.Runtime.CompilerServices.IndexerNameAttribute" to
11642 classes_second_stage.
11644 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
11645 debug_type and trace_type when compiling with --nostdlib.
11647 2002-06-07 Martin Baulig <martin@gnome.org>
11649 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
11650 (AddField): Set it to true when adding a non-static field.
11651 (DefineType): Use `have_nonstatic_fields' to find out whether we
11652 have non-static fields, not `Fields != null'.
11654 2002-06-02 Miguel de Icaza <miguel@ximian.com>
11656 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
11657 dereferencing a null on the static-field code path)
11659 2002-05-30 Martin Baulig <martin@gnome.org>
11661 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
11662 to take command line arguments. Use reflection to call the new
11663 custom `Initialize' function on the symbol writer and pass it the
11664 command line arguments.
11666 * driver.cs (--debug-args): New command line argument to pass command
11667 line arguments to the symbol writer.
11669 2002-05-28 Miguel de Icaza <miguel@ximian.com>
11671 * assign.cs (DoResolve): Forgot to do the implicit conversion to
11672 the target type for indexers and properties. Thanks to Joe for
11675 2002-05-27 Miguel de Icaza <miguel@ximian.com>
11677 * typemanager.cs (MethodFlags): returns the method flags
11678 (Obsolete/ShouldIgnore) that control warning emission and whether
11679 the invocation should be made, or ignored.
11681 * expression.cs (Invocation.Emit): Remove previous hack, we should
11682 not do this on matching a base type, we should do this based on an attribute
11684 Only emit calls to System.Diagnostics.Debug and
11685 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
11686 on the command line.
11688 * rootcontext.cs: Global settings for tracing and debugging.
11690 * cs-tokenizer.cs (define): New utility function to track
11691 defines. Set the global settings for TRACE and DEBUG if found.
11693 2002-05-25 Ravi Pratap <ravi@ximian.com>
11695 * interface.cs (Populate*): Pass in the TypeContainer as well as
11696 the DeclSpace as parameters so that we can create EmitContexts and
11697 then use that to apply attributes etc.
11699 (PopulateMethod, PopulateEvent, PopulateProperty)
11700 (PopulateIndexer): Apply attributes everywhere.
11702 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
11705 (ApplyAttributes): Update accordingly.
11707 We now apply interface attributes for all members too.
11709 2002-05-26 Miguel de Icaza <miguel@ximian.com>
11711 * class.cs (Indexer.Define); Correctly check if we are explicit
11712 implementation (instead of checking the Name for a ".", we
11713 directly look up if the InterfaceType was specified).
11715 Delay the creation of the PropertyBuilder.
11717 Only create the PropertyBuilder if we are not an explicit
11718 interface implementation. This means that explicit interface
11719 implementation members do not participate in regular function
11720 lookups, and hence fixes another major ambiguity problem in
11721 overload resolution (that was the visible effect).
11723 (DefineMethod): Return whether we are doing an interface
11726 * typemanager.cs: Temporary hack until we get attributes in
11727 interfaces (Ravi is working on that) and we get IndexerName
11728 support in interfaces.
11730 * interface.cs: Register the indexers as properties.
11732 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
11733 warning, I have verified that this is a bug in the .NET runtime
11734 (JavaScript suffers of the same problem).
11736 * typemanager.cs (MemberLookup): When looking up members for
11737 interfaces, the parent of an interface is the implicit
11738 System.Object (so we succeed in searches of Object methods in an
11739 interface method invocation. Example: IEnumerable x; x.ToString
11742 2002-05-25 Miguel de Icaza <miguel@ximian.com>
11744 * class.cs (Event): Events should also register if they do
11745 implement the methods that an interface requires.
11747 * typemanager.cs (MemberLookup); use the new GetInterfaces
11750 (GetInterfaces): The code used to lookup interfaces for a type is
11751 used in more than one place, factor it here.
11753 * driver.cs: Track the errors at the bottom of the file, we kept
11756 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
11757 instance if the method we are calling is static!
11759 2002-05-24 Miguel de Icaza <miguel@ximian.com>
11761 * attribute.cs (ApplyAttributes): Make this function filter out
11762 the IndexerName attribute (as that attribute in reality is never
11763 applied) and return the string constant for the IndexerName
11766 * class.cs (TypeContainer.Emit): Validate that all the indexers
11767 have the same IndexerName attribute, and if so, set the
11768 DefaultName attribute on the class.
11770 * typemanager.cs: The return value might contain other stuff (not
11771 only methods). For instance, consider a method with an "Item"
11772 property and an Item method.
11774 * class.cs: If there is a problem with the parameter types,
11777 2002-05-24 Ravi Pratap <ravi@ximian.com>
11779 * ecore.cs (ImplicitConversionExists): Wrapper function which also
11780 looks at user defined conversion after making a call to
11781 StandardConversionExists - we need this for overload resolution.
11783 * expression.cs : Update accordingly the various method calls.
11785 This fixes 2 bugs filed against implicit user defined conversions
11787 2002-05-22 Miguel de Icaza <miguel@ximian.com>
11789 * statement.cs: Track the result of the assignment.
11791 2002-05-21 Miguel de Icaza <miguel@ximian.com>
11793 * expression.cs (MemberAccess): Improved error reporting for
11794 inaccessible members.
11796 2002-05-22 Martin Baulig <martin@gnome.org>
11798 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
11799 itself with debugging support.
11801 2002-05-22 Martin Baulig <martin@gnome.org>
11803 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
11804 Removed, this isn't needed anymore.
11806 2002-05-20 Martin Baulig <martin@gnome.org>
11808 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
11809 be underlying type for an enum.
11811 2002-05-20 Miguel de Icaza <miguel@ximian.com>
11813 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
11814 that splits out the loading of just the core types.
11816 * rootcontext.cs (ResolveCore): Split the struct resolution in
11817 two, so we can load the enumeration underlying types before any
11820 * expression.cs (Is): Bandaid until we fix properly Switch (see
11821 bug #24985 for details).
11823 * typemanager.cs (ImplementsInterface): The hashtable will contain
11824 a null if there are no interfaces implemented.
11826 2002-05-18 Miguel de Icaza <miguel@ximian.com>
11828 * cs-parser.jay (indexer_declarator): It is fine to have array
11831 2002-05-17 Miguel de Icaza <miguel@ximian.com>
11833 * typemanager.cs: (RegisterBuilder): New function used to register
11834 TypeBuilders that implement interfaces. Since
11835 TypeBuilder.GetInterfaces (as usual) does not work with lame
11837 (AddUserType): register interfaces.
11839 (ImplementsInterface): Use the builder_to_ifaces hash if we are
11840 dealing with TypeBuilder. Also, arrays are showing up as
11841 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
11842 methods can not be invoked on them!
11844 * ecore.cs (ExplicitReferenceConversionExists): Made public.
11845 (ImplicitReferenceConversionExists): Split out from
11846 StandardConversionExists.
11848 * expression.cs (As): We were only implementing one of the three
11849 cases for the as operator. We now implement them all.
11850 (Is): Implement the various other cases for Is as well.
11852 * typemanager.cs (CACHE): New define used to control if we want or
11853 not the FindMembers cache. Seems to have a negative impact on
11854 performance currently
11856 (MemberLookup): Nested types have full acess to
11857 enclosing type members
11859 Remove code that coped with instance/static returns for events, we
11860 now catch this in RealFindMembers.
11862 (RealFindMembers): only perform static lookup if the instance
11863 lookup did not return a type or an event.
11865 2002-05-17 Miguel de Icaza <miguel@ximian.com>
11867 * assign.cs (CompoundAssign): We pass more semantic information
11868 now to Compound Assignments than we did before: now we have all
11869 the information at hand, and now we resolve the target *before* we
11870 do the expression expansion, which allows the "CacheValue" method
11871 to have the effect we intended (before, a [x] += 1 would generate
11872 two differen ArrayAccess expressions from the ElementAccess,
11873 during the resolution process).
11875 (CompoundAssign.DoResolve): Resolve target and original_source here.
11877 2002-05-16 Miguel de Icaza <miguel@ximian.com>
11879 * expression.cs (ArrayAccess): dropped debugging information.
11881 * typemanager.cs: Small bug fix: I was always returning i_members,
11882 instead of one of i_members or s_members (depending on which had
11885 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
11886 method is invoked before any code generation takes place, and it
11887 is a mechanism to inform that the expression will be invoked more
11888 than once, and that the method should use temporary values to
11889 avoid having side effects
11891 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
11893 * ecore.cs (Expression.CacheTemporaries): Provide empty default
11896 * expression.cs (Indirection, ArrayAccess): Add support for
11897 CacheTemporaries in these two bad boys.
11899 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
11900 ldobj or ldind_ref.
11901 (StoreFromPtr): Handle stobj as well.
11903 * expression.cs (UnaryMutator): Share more code.
11905 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
11906 down: I was not tracking the Filter function as well, which
11907 was affecting the results of the cache.
11909 2002-05-15 Miguel de Icaza <miguel@ximian.com>
11911 * attribute.cs: Remove the hack to handle the CharSet property on
11914 2002-05-14 Miguel de Icaza <miguel@ximian.com>
11916 * attribute.cs (DoResolve): More uglyness, we now only try to
11917 resolve the attribute partially, to extract the CharSet
11918 information (only if we are a StructLayout attribute). Otherwise
11920 (GetExtraTypeInfo): Add some code to conditionally kill in the
11921 future this. I am more and more convinced that the .NET
11922 framework has special code to handle the attribute setting on
11925 * expression.cs (IsParamsMethodApplicable): Revert my previous
11926 foreach change here, it was wrong.
11928 2002-05-13 Miguel de Icaza <miguel@ximian.com>
11930 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
11931 (pp_expr): do not abort on unknown input, just return.
11932 (eval): abort if there are pending chars.
11934 * attribute.cs (Attribute.Resolve): Positional parameters are
11935 optional. Deal with that case.
11937 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
11938 the Ansi/Unicode/Auto information for the type.
11940 (TypeContainer.DefineType): instantiate the EmitContext here, as
11941 we will be using it during the type definition (to resolve
11942 attributes) and during the emit phase.
11944 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
11945 to pull type information out of the attributes
11947 (Attribute.Resolve): track the constructor builder, and allow for
11948 multiple invocations (structs and classes will use this).
11950 * ecore.cs (MemberLookupFinal): new version with all the
11951 parameters customizable.
11953 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
11954 constructors. Return if the result value is null (as the error
11955 would have been flagged already by MemberLookupFinal)
11957 Do not allow instances of abstract classes or interfaces to be
11960 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
11961 We have to compare the assembly property here when dealing with
11962 FamANDAssem and Assembly access modifiers, because we might be
11963 creating an assembly from *modules* (that means that we are not
11964 getting TypeBuilders for types defined in other modules that are
11965 part of this assembly).
11967 (Method.Emit): If the method is marked abstract and has a body,
11970 (TypeContainer.DefineMembers): If both the defined member and the
11971 parent name match are methods, then do not emit any warnings: let
11972 the Method.Define routine take care of flagging warnings. But if
11973 there is a mismatch (method overrides something else, or method is
11974 overriwritten by something, then emit warning).
11976 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
11977 set to null, this means `do not check for the return type on the
11980 (Method.Define): set the return type for the method signature to
11981 null, so that we get methods with the same name and parameters and
11982 different return types. This is used to flag warning 114 (you are
11983 hiding a method, and you probably want to use the new/override
11986 * typemanager.cs (MemberLookup): Implemented proper access
11987 control, closing a long standing set of bug reports. The problem
11988 was that the Framework only has two bits: Public and NonPublic,
11989 and NonPublic includes private and protected methods, but we need
11990 to enforce the FamANDAssem, FamOrAssem and Family.
11992 2002-05-11 Miguel de Icaza <miguel@ximian.com>
11994 * statement.cs (GotoCase): Return true: Ammounts to giving up
11995 knowledge on whether we return or not, and letting the other case
11996 be responsible for it.
11998 2002-05-10 Miguel de Icaza <miguel@ximian.com>
12000 * driver.cs: Do not load directories for each file processed, only
12001 do it if there is a pattern.
12003 * ecore.cs: Report readonly assigns here as well, as we might have
12004 been resolved only by MemberAccess.
12006 (SimpleName.SimpleNameResolve): Also be useful for LValue
12007 resolution. We need this to propagate assign to local readonly variables
12009 * typemanager.cs: Use a ptrhashtable for the criteria, because we
12010 do not want to reuse potential criteria memory.
12012 * class.cs (MyEventBuilder): Set reflected_type;
12014 * ecore.cs (Constantify): Added support for constifying bools.
12016 (RootContext.LookupType): Added a cache for values looked up in
12017 the declaration space.
12019 * typemanager.cs (FindMembers): Now is a front-end to
12020 RealFindMembers, and provides a two-level hashtable-based cache to
12023 15% performance improvement: from 22.5 to 19.2 seconds.
12025 * expression.cs (IsParamsMethodApplicable): use foreach.
12026 (Invocation.DoResolve): ditto.
12027 (New.DoResolve): ditto.
12028 (ArrayCreation.DoResolve): ditto.
12030 * ecore.cs (FindMostEncompassingType): use foreach.
12032 * delegate.cs (NewDelegate.DoResolve): Use foreach
12034 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
12035 (RemoveMethods): use foreach.
12037 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
12038 nested foreach statements instead of for, and also break out of
12039 the inner loop once a match is found.
12041 (Invocation.OverloadResolve): Use foreach, simplify the code.
12043 2002-05-08 Miguel de Icaza <miguel@ximian.com>
12045 * cfold.cs (BinaryFold): During an enumeration evaluation context,
12046 we actually unwrap the expression to allow for extra information
12049 * expression.cs: Use Shr_Un on unsigned operations.
12051 2002-05-08 Ravi Pratap <ravi@ximian.com>
12053 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
12054 applicable operators was not being considered correctly. This closes
12055 the bug Miguel reported.
12057 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
12059 * attribute.cs: check that the type derives from System.Attribute
12060 and report the correct error in that case (moved the duplicate code to
12061 its own method, too).
12063 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
12065 * attribute.cs: lookup attribute type name as the spec says: first the
12066 bare attribute name and then name + "Attribute" (nant compiles with
12067 mcs after this fix).
12069 2002-05-07 Miguel de Icaza <miguel@ximian.com>
12071 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
12072 Because of the way we parse things, we should try to see if a
12073 UIntConstant can fit in an integer.
12075 2002-05-07 Ravi Pratap <ravi@ximian.com>
12077 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
12078 when we are in an explicit context.
12080 (ConvertReferenceExplicit): When converting from Iface type S to Class
12081 T make sure the rules are implemented as an OR.
12083 * parameter.cs (ParameterType): Make it a property for now although the
12084 purpose really isn't anything immediate.
12086 * expression.cs (Is*Applicable): Do better checking on the parameter type
12087 of a ref/out parameter. The ones from the system assemblies are already
12088 marked with the correct type so we don't need to do any correction.
12090 * ecore.cs (StandardConversionExists): Conversion from Interface types to
12091 the object type is standard too so include that.
12093 2002-05-06 Miguel de Icaza <miguel@ximian.com>
12095 * ecore.cs (StandardConversionExists): Augment with missing code:
12096 deal with IntConstant, LongConstants and Enumerations.
12098 * assign.cs: Report the error, instead of failing silently
12100 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
12101 typecontainer that they are declared, because the
12102 typecontainer/namespace will have the list of using clauses that
12103 need to be applied.
12105 Assembly Attributes were escaping the normal registration
12108 (EmitCode): Apply attributes within an EmitContext that represents
12109 the container they were declared on.
12111 * cs-parser.jay: Track bases for structs. How did I get this wrong?
12113 2002-05-06 Ravi Pratap <ravi@ximian.com>
12115 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
12116 Revamp completely - make much cleaner as we now operate only
12119 (FindMostSpecificSource, FindMostSpecificTarget): New methods
12120 to implement the logic detailed in the spec more correctly.
12122 (UserDefinedConversion): Update accordingly.
12124 2002-05-06 Miguel de Icaza <miguel@ximian.com>
12126 * statement.cs: Return flow analysis information up.
12128 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
12131 (token): Do not consume an extra character before calling
12134 2002-05-06 Piers Haken <piersh@friskit.com>
12136 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
12138 2002-05-06 Miguel de Icaza <miguel@ximian.com>
12140 * class.cs (Constructor.Emit): Set the IsStatic flag in the
12141 EmitContext during the instance constructor initializer
12142 resolution, to stop access to instance variables.
12144 This is mandated by the spec, last paragraph of the `constructor
12145 initializers' section.
12147 2002-05-05 Miguel de Icaza <miguel@ximian.com>
12149 * cs-parser.jay, class.cs (Accessor): new class used to represent
12150 an accessor (get or set). In the past we used `null' to represent
12151 a missing accessor. But this is ambiguous because there was no
12152 way to tell in abstract indexers/properties if one of them was
12155 Now there is a way of addressing that.
12157 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
12158 instead of FindMembers.
12160 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
12161 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
12163 * attribute.cs: Treat indexers and properties as the same in terms
12164 of applying attributes
12166 * ecore.cs (FindMostEncompassedType): Use statically initialized
12167 EmptyExpressions()s like we do elsewhere to avoid creating useless
12168 objects (and we take this out of the tight loop).
12170 (GetConversionOperators): Move the code to extract the actual
12171 operators to a separate routine to clean things up.
12173 2002-05-04 Miguel de Icaza <miguel@ximian.com>
12175 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
12176 events are always registered FieldBuilders.
12178 * class.cs (FieldBase): New class shared by Fields
12180 * delegate.cs: If we are a toplevel delegate, use our full name.
12181 If we are a nested delegate, then only use our tail name.
12183 2002-05-02 Ravi Pratap <ravi@ximian.com>
12185 * expression.cs (IsApplicable): Ensure that we add the "&" to
12186 ref/out types before comparing it with the type of the argument.
12188 (IsParamsMethodApplicable): Ditto.
12190 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
12193 * delegate.cs : Handle the case when we have more than one applicable
12194 method. Flag an error only when we finish checking all.
12196 2002-05-02 Miguel de Icaza <miguel@ximian.com>
12198 * expression.cs: Add support for boolean static initializers.
12200 2002-05-01 Miguel de Icaza <miguel@ximian.com>
12202 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
12204 * parameter.cs (ComputeParameterTypes,
12205 ComputeAndDefineParameterTypes): Better error handling: now we
12206 clear the `types' cache if we fail during any of the type lookups.
12207 We also return the status code correctly to our caller
12209 * delegate.cs: If we fail to define a delegate, abort the extra
12212 * expression.cs (Binary.ResolveOperator): for
12213 operator==(object,object) and operator !=(object, object) we also
12214 have to verify that there is an implicit conversion from one to
12217 (ArrayAccess.DoResolve): Array Access can operate on
12220 2002-04-30 Miguel de Icaza <miguel@ximian.com>
12222 * assign.cs (CompoundAssign): A new class used as a "flag" that
12223 the assignment actually is happening as part of a compound
12224 assignment operator.
12226 During compound assignment, a few new rules exist to enable things
12233 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
12234 to the type of x) if y is implicitly convertible to the type of x,
12235 and the operator is a builtin operator and the return type of the
12236 operator is explicitly convertible to the type of x.
12238 * rootcontext.cs: Reset warning level to 2. 4 catches various
12239 "interesting" features in mcs, we must clean this up at some
12240 point, but currently am trying to kill other bugs ;-)
12242 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
12243 in container classes as well.
12245 * expression.cs (Binary.ResolveOperator): Handle string case
12246 before anything else (as operator overloading does emit an error
12247 before doing anything else).
12249 This code could go away when we move to a table driven model, but
12250 i could not come up with a good plan last night.
12252 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
12254 * typemanager.cs (CSharpName): reimplementation using regex.
12255 * class.cs: added null check for fields in Emit
12256 * rootcontext.cs: set warninglevel to 4
12258 2002-04-29 Miguel de Icaza <miguel@ximian.com>
12260 * typemanager.cs (CSharpName): reimplemented with Lupus
12263 2002-04-28 Miguel de Icaza <miguel@ximian.com>
12265 * statement.cs (If): correclty implement Resolve, because we were
12266 not catching sem errors in there. The same process is needed
12268 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
12271 (Statement.Warning_DeadCodeFound): Factorize code.
12272 (While): Report dead code here too.
12274 (Statement): Added Resolve virtual method to allow
12275 for resolution split from the emit code.
12277 2002-04-26 Miguel de Icaza <miguel@ximian.com>
12279 * statement.cs (EmitBoolExpression): No longer try to resolve the
12281 (MakeBoolean): New utility function that resolve, implicitly
12282 converts to boolean and tags the expression.
12285 (If, Do): Implement dead code elimination.
12286 (While): Implement loop inversion
12288 (Do, While, For, If): Resolve the expression prior to calling our
12291 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
12294 - added method Report28 (warning: program has more than one entry point)
12295 - added method IsEntryPoint, implements paragraph 10.1 of the spec
12296 - modified method Method.Define, the part at the end of the method
12298 * rootcontext.cs: added static public Location EntryPointLocation;
12300 * ../errors/cs0028.cs : Add test case for the above warning.
12303 - modified method CSharpName to allow arrays of primitive type to
12304 be printed nicely (e.g. instead of System.Int32[][] it now prints
12306 - added method CSharpSignature: returns the signature of a method
12307 in string format to be used in reporting errors, warnings, etc.
12309 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
12312 2002-04-26 Ravi Pratap <ravi@ximian.com>
12314 * delegate.cs (Define): Fix extremely silly bug where I was
12315 setting the type of the 'object' parameter of the BeginInvoke
12316 method to System.IAsyncResult instead of System.Object ;-)
12318 2002-04-26 Miguel de Icaza <miguel@ximian.com>
12320 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
12323 (Constructor.Emit): return if we fail to initialize the
12324 constructor. Another door closed!
12326 * expression.cs (New.DoResolve): Improve error message (from -6 to
12327 1501). Use DeclaredOnly lookup to find the exact constructor.
12329 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
12330 loop. This is useful.
12332 * cs-parser.jay: Adjust the default parameters so that destructors
12333 have the proper signature.
12335 2002-04-26 Martin Baulig <martin@gnome.org>
12337 * driver.cs (LoadAssembly): If `assembly' contains any characters
12338 which are only valid in path names and not in assembly names
12339 (currently slash, backslash and point), use Assembly.LoadFrom ()
12340 instead of Assembly.Load () on the `assembly' (before iteration
12341 over the link_paths).
12343 2002-04-26 Martin Baulig <martin@gnome.org>
12345 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
12347 2002-04-25 Miguel de Icaza <miguel@ximian.com>
12349 * class.cs (Property): use the new typemanager.MemberLookup
12351 (TypeContainer.MemberLookup): Implement using the
12352 TypeManager.MemberLookup now.
12354 * typemanager.cs: Make MemberLookup a function of the TypeManager,
12355 and return MemberInfos, so that these can be used without an
12356 EmitContext (what we had before).
12358 2002-04-24 Miguel de Icaza <miguel@ximian.com>
12360 * expression.cs: Fix the case where the argument to params if the
12361 type of the params. I omitted handling this before. Fixed
12363 2002-04-22 Miguel de Icaza <miguel@ximian.com>
12365 * driver.cs: Call BootCorlib_PopulateCoreType
12367 * class.cs (Property.CheckBase): Check for properties only, not
12370 * interface.cs: Temporary hack: try/catch around the
12371 CustomAttributeBuilder, because I am getting an exception that I
12374 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
12375 types whose definitions are required to be there (attributes are
12376 defined before standard types).
12378 Compute definitions as we boot the various types, as they are used
12379 immediately (value_type class will need object_type, but if we do
12380 not initialize object_type, we will pass a null, which will let
12381 the runtime pick the System.Object from the existing corlib, which
12382 is not what we want).
12384 2002-04-22 Patrik Torstensson <totte@labs2.com>
12386 * cs-tokenizer.cs: fixed a number of trim() issues.
12388 2002-04-22 Ravi Pratap <ravi@ximian.com>
12390 * expression.cs (Argument.Type): Ensure that we return the correct
12391 type when we have out or ref parameters [in which case we
12394 2002-04-22 Miguel de Icaza <miguel@ximian.com>
12396 * class.cs (Property, Indexer): Allow extern modifier in there.
12398 * typemanager.cs (InitBaseTypes): Initializes object_type and
12399 value_type, since those will be used early on during the bootstrap
12400 process to compile corlib.
12402 (InitCoreTypes): Move code from here to InitBaseTypes.
12404 2002-04-21 Miguel de Icaza <miguel@ximian.com>
12406 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
12407 single-dimension arrays as using the ldlen opcode.
12409 Daniel Lewis discovered this optimization.
12411 * typemanager.cs: Add signature for System.Array::get_Length
12413 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
12415 * statement.cs: report the error when the foreach does not apply to an
12416 array nor a collection.
12418 2002-04-19 Miguel de Icaza <miguel@ximian.com>
12420 * expression.cs: Add implicit conversions to the operator ~.
12422 * constant.cs (DecimalConstant.Emit): Emit decimal value.
12424 * typemanager.cs: Locate the decimal constructor.
12426 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
12428 * attribute.cs: use the new property of TypeOf.
12429 * expression.cs: added 'get' property around typearg.
12431 These changes fix a build breaker reported by NickD. Is this the
12432 correct way to fix? If not, please, revert my changes and make it
12435 2002-04-17 Miguel de Icaza <miguel@ximian.com>
12437 * attribute.cs: Add support for typeof in attribute invocations.
12438 I am not sure that this is right though.
12440 2002-04-14 Duncan Mak <duncan@ximian.com>
12442 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
12443 Binary.Operator.Division case.
12445 2002-04-13 Ravi Pratap <ravi@ximian.com>
12447 * class.cs (DefineType): Ensure that we do a proper check on
12448 attribute types and also register it with the TypeManager.
12450 (TypeContainer.Targets): The default for attribute types is
12451 AttributeTargets.All.
12453 * attribute.cs (ApplyAttributes): Registering the attribute type
12454 is done elsewhere, not when we discover we have a Usage attribute.
12456 2002-04-12 Ravi Pratap <ravi@ximian.com>
12458 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
12459 and get rid of is_delegate parameter.
12461 * everywhere : update.
12463 2002-04-12 Ravi Pratap <ravi@ximian.com>
12465 * cs-parser.jay (compilation_unit): Revamp completely to use
12466 some new ideas that I got from Rhys' grammar to solve the problems
12467 with assembly level attributes.
12469 (outer_declaration): New grammar production.
12471 (attribute_sections): Add.
12473 (opt_attributes): Base on attribute_sections
12475 (namespace_declaration): Allow opt_attributes to tackle the case
12476 when we have assembly level attributes - we are clever in this
12479 * attribute.cs (ApplyAttributes): Do not worry about assembly
12480 attributes in the non-global context.
12482 * rootcontext.cs (AddGlobalAttributes): Go back to using this
12483 instead of SetGlobalAttributes.
12485 * class.cs, rootcontext.cs : Ensure we define and generate
12486 attribute types before anything else.
12488 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
12489 and flag the new error -20 for the case when the attribute type
12490 does not have valid targets specified. csc does not catch this.
12492 * ../errors/errors.txt : update for error # -20
12494 2002-04-11 Ravi Pratap <ravi@ximian.com>
12496 * support.cs (InternalParameters.ParameterModifier): Do some null
12497 checking and return sane values.
12499 * class.cs (Method.Define): If we are a PInvoke method, ensure
12500 that we are static and extern. Report error # 601
12502 * ../errors/cs0601.cs : Add test case for the above error.
12504 2002-04-07 Ravi Pratap <ravi@ximian.com>
12506 * rootcontext.cs (attribute_types): We need to keep type of
12507 all attribute types separately and emit code for them first.
12509 (RegisterAttribute) : Implement.
12511 * class.cs (DefineType): Check if the current Type is a custom
12512 attribute type and register it accordingly.
12514 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
12515 adding the first attribute twice and rename to
12517 (SetGlobalAttributes): this.
12519 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
12522 * attribute.cs (ApplyAttributes): Take an additional argument telling us
12523 if we are processing global arguments. Hmm, I am unsure of this.
12525 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
12527 * expression.cs: added static array of strings to avoid calling
12528 Enum.ToString () for Operator in Binary. Significant recover of
12531 2002-04-10 Miguel de Icaza <miguel@ximian.com>
12533 * class.cs (FindMembers): Allow the Builders of the various
12534 members to be null. If they are skip them. This only happens
12535 during the PInvoke declaration.
12537 2002-04-09 Miguel de Icaza <miguel@ximian.com>
12539 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
12540 failure, so we do not keep going afterwards.
12542 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
12543 wanted to pass `false' as the `is_delegate' argument. If this is
12544 the case, why not use delegate_type == null to mean `is_delegate =
12545 false' and anything else as is_delegate = true.
12547 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
12549 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
12550 code for the section, not the beginning of the tests.
12552 2002-04-08 Miguel de Icaza <miguel@ximian.com>
12554 * cfold.cs: Handle operator + (Enum x, Underlying x)
12556 * expression.cs (Binary): same. Warn about errors where we have
12557 Enum/Enum in operator + as well.
12559 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
12562 - added support for switch(bool)
12563 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
12564 - add TableSwitchEmit() to handle table-based switch statements
12566 2002-04-05 Ravi Pratap <ravi@ximian.com>
12568 * expression.cs (Invocation.OverloadResolve): Factor out code which
12569 does parameter compatibility checking with arguments so that we can
12570 re-use the code even from Delegate.VerifyApplicability
12572 (VerifyArgumentsCompat): Move above code here.
12574 * delegate.cs (VerifyApplicability): Get rid of duplicate code
12575 and instead make a call to the above method.
12577 2002-03-31 Ravi Pratap <ravi@ximian.com>
12579 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
12580 We use it to keep track of classes which are attribute types.
12582 2002-04-02 Miguel de Icaza <miguel@ximian.com>
12584 * delegate.cs (Delegate.Define): Correctly define the types in the
12585 presence of fixed and array parameters.
12587 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
12590 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
12591 include NonPublic after the first iteration.
12593 * class.cs (Indexer.CheckBase): Only check if both parents are
12596 * cs-parser.jay (accessor_body): If empty, set to null.
12598 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
12599 same code path here to resolve constants names that we did have in
12600 MemberAccess.DoResolve. There is too much code duplicated here.
12602 2002-04-01 Miguel de Icaza <miguel@ximian.com>
12604 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
12606 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
12609 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
12610 tokens, numbers and strings.
12612 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
12615 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
12616 asyncronous parameters and the regular parameters.
12618 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
12619 specify the target directory.
12621 * expression.cs: (This.DoResolve): Simplify
12622 (As.Emit): Optimize, do not generate IsInst if the expression is
12623 always of the given type.
12625 (Is.DoResolve): Bug fix, we were reporting both always/never for
12628 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
12629 creating too many unnecessary arrays.
12631 2002-03-31 Miguel de Icaza <miguel@ximian.com>
12633 * class.cs (EmitFieldInitializer): Use Assign expression to assign
12634 fields instead of rolling our own initializer. Takes care of all
12635 implicit conversions, and drops unnecessary static checks/argument.
12637 2002-03-31 Dick Porter <dick@ximian.com>
12639 * driver.cs: use the GetDirectories() return values properly, and
12640 use "/" as path separator.
12642 2002-03-30 Miguel de Icaza <miguel@ximian.com>
12644 * expression.cs (Unary): Optimize - - expr into expr.
12645 (Binary): Optimize a + (-b) into a -b.
12647 * codegen.cs (CodeGen): Made all methods static.
12649 2002-03-29 Miguel de Icaza <miguel@ximian.com>
12653 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
12654 TypeBuilder property.
12656 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
12659 * tree.cs: Removed the various RecordXXXX, and replaced with a
12660 single RecordDecl. Removed all the accessor methods, and just
12661 left a single access point Type
12663 * enum.cs: Rename DefineEnum to DefineType.
12665 * decl.cs: New abstract method `DefineType' used to unify the
12666 Defines for Enumerations, Interfaces, TypeContainers and
12669 (FindType): Moved LookupInterfaceOrClass here. Moved the
12670 LookupBaseClasses method that used to live in class.cs and
12671 interface.cs here, and renamed to FindType.
12673 * delegate.cs: Implement DefineType. Take advantage of the
12674 refactored pattern for locating the parent builder without taking
12675 the parent_builder argument (which we know does not work if we are
12676 nested, and triggering a toplevel definition).
12678 2002-03-28 Miguel de Icaza <miguel@ximian.com>
12680 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
12681 accessibility of a member has changed during override and report
12684 * class.cs (Method.Define, Property.Define): Only complain on
12685 overrides if the method is private, any other accessibility is
12686 fine (and since we just checked the permission is the same, we are
12689 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
12690 and elif are processed always. The other pre-processing
12691 directives are only processed if we are "taking" the path
12693 2002-03-29 Martin Baulig <martin@gnome.org>
12695 * class.cs (Method.Emit): Only emit symbolic debugging info if the
12696 current location is not Null.
12698 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
12699 a separate method so we can profile it.
12701 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
12702 `span.Seconds' are just seconds, but no minutes or hours.
12703 (MainDriver): Profile the CodeGen.SaveSymbols calls.
12705 2002-03-28 Miguel de Icaza <miguel@ximian.com>
12707 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
12708 Remove the gratuitous set of Final:
12710 // If an interface implementation, then we can set Final.
12711 if (((flags & MethodAttributes.Abstract) == 0) &&
12712 implementing.DeclaringType.IsInterface)
12713 flags |= MethodAttributes.Final;
12715 I do not know what I was smoking when I used that.
12718 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
12719 step into fixing the name resolution issues for delegates and
12720 unifying the toplevel name resolution.
12722 2002-03-28 Martin Baulig <martin@gnome.org>
12724 * class.cs (Method.Emit): If we have a symbol writer, call its
12725 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
12726 tell it about the current method.
12728 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
12729 writer that we're going to emit the first byte of IL code for a new
12730 statement (a new source line).
12731 (EmitContext.EmitTopBlock): If we have a symbol writer, call
12732 EmitContext.Mark() before emitting any code.
12734 * location.cs (SymbolDocument): Return null when we're Null.
12736 * statement.cs (Statement): Moved the `Location loc' variable here.
12737 (Statement.EmitBoolExpression): If we have a symbol writer, call
12738 ec.Mark() before emitting any code to tell it that we're at the
12739 beginning of a new statement.
12740 (StatementExpression): Added `Location' argument to the constructor.
12741 (Block): Added public readonly variable `StartLocation' and public
12742 variable `EndLocation'. The latter is to be set using SetEndLocation().
12743 (Block): Added constructor which takes a start and end location.
12744 (Block.SetEndLocation): New method. This sets the end location.
12745 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
12746 local variables we create.
12747 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
12748 each statement and do also mark the begin and end of the block.
12750 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
12751 tell it the current lexer.Location, use Location.Null for the end of the
12753 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
12754 current block, set its end location using SetEndLocation().
12755 (statement_expression): StatementExpression constructor now takes the
12756 lexer.Location as additional argument.
12757 (for_statement, declare_local_variables): Likewise.
12758 (declare_local_variables): When creating a new implicit block, use the
12759 new Block constructor and pass it the lexer.Location.
12761 2002-03-28 Miguel de Icaza <miguel@ximian.com>
12763 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
12764 members also on the parent interfaces recursively.
12766 2002-03-27 Miguel de Icaza <miguel@ximian.com>
12768 * report.cs: Use new formats, since Gonzalo finished the missing
12771 * expression.cs (Binary.ResolveOperator): added missing operator|
12772 operator& and operator^ for bool/bool.
12774 * cs-parser.jay: CheckDef now takes a Location argument that is
12775 used to report errors more precisly (instead of reporting the end
12776 of a definition, we try to track something which is a lot closer
12777 to the source of the problem).
12779 * cs-tokenizer.cs: Track global token use, so we can properly flag
12780 the use of #define/#undef after the first token has been seen.
12782 Also, rename the reportXXXX to Error_DescriptiveName
12784 * decl.cs (DeclSpace.IsTopLevel): Move property here from
12785 TypeContainer, so that Enum and Interface can use this too.
12787 * class.cs (TypeContainer.LookupInterfaceOrClass,
12788 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
12789 `builder' argument. Typically this was used to pass the parent
12790 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
12793 The problem is that a nested class could trigger the definition of
12794 a toplevel class, and the builder would be obviously wrong in that
12797 So we drop this argument, and we compute dynamically the
12798 TypeBuilder/ModuleBuilder (the correct information was available
12799 to us anyways from DeclSpace.Parent)
12801 * interface.cs (Interface.DefineInterface): Drop builder
12802 parameter cleanup like class.cs
12804 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
12807 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
12810 (Try.Emit): Propagate the returns value from the statement.
12812 (Return.Emit): Even if we are leavning
12814 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
12816 * modifiers.cs: Fix the computation of MethodAttributes flags.
12818 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
12820 * driver.cs: allow compilation of files that start with '/'.
12821 Add a default case when checking the argument of --target.
12823 2002-03-25 Miguel de Icaza <miguel@ximian.com>
12825 * interface.cs: Implement the same search algorithm for types in
12826 the interface code.
12828 * delegate.cs: Do not allow multiple definition.
12830 * Recovered ChangeLog that got accidentally amputated
12832 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
12834 * rootcontext.cs: Load manually enum to allow core classes to
12835 contain enumerations.
12837 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
12838 Update to new static methods in TypeManager.
12840 * typemanager.cs (GetMethod, GetConstructor): Use our
12841 implementation of FindMembers to find the members, since during
12842 corlib compilation, the types are TypeBuilders and GetMethod and
12843 GetConstructor do not work.
12845 Make all methods in TypeManager static.
12847 (InitCodeHelpers): Split the functionality from
12848 the InitCodeTypes function.
12850 * driver.cs: Call InitCodeHelpers after we have populated the
12853 * cs-parser.jay (delegate_declaration): we did not used to compute
12854 the delegate name correctly for void delegates.
12856 2002-03-24 Miguel de Icaza <miguel@ximian.com>
12858 * rootcontext.cs (RootContext): Init the interface_resolve_order
12859 and type_container_resolve_order always.
12861 (ResolveCore, BootstrapCorlib_ResolveClass,
12862 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
12863 compiler when compiling with --nostdlib
12865 * class.cs (TypeContainer.DefineType): Check that our parent is
12866 not null. This test is most important when we are bootstraping
12869 * codegen.cs: Split out the symbol writing code.
12871 2002-03-25 Martin Baulig <martin@gnome.org>
12873 * driver.cs (-g): Made -g an alias for --debug.
12875 2002-03-24 Martin Baulig <martin@gnome.org>
12877 * codegen.cs (SymbolWriter): New public variable. Returns the
12878 current symbol writer.
12879 (CodeGen): Added `bool want_debugging_support' argument to the
12880 constructor. If true, tell the ModuleBuild that we want debugging
12881 support and ask it for the ISymbolWriter.
12882 (Save): If we have a symbol writer, call it's Close() method after
12883 saving the assembly.
12885 * driver.c (--debug): New command line argument to create a
12886 debugger information file.
12888 * location.cs (SymbolDocument): New public property. Returns an
12889 ISymbolDocumentWriter object for the current source file or null
12890 if we don't have a symbol writer.
12892 2002-03-21 Miguel de Icaza <miguel@ximian.com>
12894 * driver.cs (LoadAssembly): Correctly return when all the paths
12895 have been tried and not before.
12897 * statement.cs (Switch.Emit): return the actual coverage for this
12898 statement (returns/not-returns)
12900 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
12901 switch of the statement if we are the last switch section. That
12902 kills two problems: try/catch problems (we used to emit an empty
12903 nop at the end) and switch statements where all branches would
12906 2002-03-19 Miguel de Icaza <miguel@ximian.com>
12908 * driver.cs: Add default assemblies (the equivalent to the
12909 Microsoft CSC.RSP file)
12911 * cs-tokenizer.cs: When updating `cols and setting it to zero,
12912 also update tokens_seen and set it to false.
12914 * driver.cs: Implement --recurse for Mike.
12916 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
12917 correctly splitting out the paths.
12919 2002-03-18 Miguel de Icaza <miguel@ximian.com>
12921 * interface.cs (Interface.PopulateProperty): Instead of using
12922 `parent' as the declaration space for the set parameters, use
12925 * support.cs (InternalParameters): InternalParameters constructor
12926 takes a DeclSpace instead of a TypeContainer.
12928 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
12929 types are being initialized, load the address of it before calling
12932 (New): Provide a mechanism to disable the generation of local
12933 value type temporaries when the caller will be providing us with
12934 an address to store it.
12936 (ArrayCreation.EmitDynamicInitializers): Use it.
12938 2002-03-17 Miguel de Icaza <miguel@ximian.com>
12940 * expression.cs (Invocation.EmitArguments): Only probe for array
12941 property if there is more than one argument. Sorry about that.
12943 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
12944 empty param arrays.
12946 * class.cs (Method.LabelParameters): Fix incorrect code path that
12947 prevented the `ParamArrayAttribute' from being applied to the
12950 2002-03-16 Miguel de Icaza <miguel@ximian.com>
12952 * support.cs (ReflectionParameters): Correctly compute whether the
12953 last argument is a params array. Fixes the problem with
12956 * typemanager.cs: Make the assemblies array always be non-null
12957 (empty, but non-null)
12959 * tree.cs (RecordDecl): New function that abstracts the recording
12960 of names. This reports error 101, and provides a pointer to the
12961 previous declaration. Fixes a crash in the compiler.
12963 * cs-parser.jay (constructor_declaration): Update to new grammar,
12964 and provide a constructor_body that can be empty.
12966 2002-03-15 Miguel de Icaza <miguel@ximian.com>
12968 * driver.cs: Add support for --resources.
12970 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
12971 Make all types for the various array helper methods be integer.
12973 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
12974 CheckState to ConvCast.
12976 (ConvCast): Now it takes a `checked' state argument, to avoid
12977 depending on the emit context for the conversion, and just using
12978 the resolve time setting.
12980 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
12981 instead of Invocation.EmitArguments. We do not emit the original
12982 arguments, instead we emit those which have been converted to
12983 unsigned int expressions.
12985 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
12987 * codegen.cs: ditto.
12989 * expression.cs (LocalVariableReference): Drop the use of the
12990 Store function that depended on the variable index.
12992 * statement.cs (VariableInfo): Drop the `Idx' property from this
12993 class, as this is not taking into account the indexes for
12994 temporaries tat we generate during the execution, getting the
12997 * class.cs: First emit class initializers, then call the parent
13000 * expression.cs (Binary): Fix opcode emision.
13001 (UnaryMutator.EmitCode): Support checked code generation
13003 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
13004 matches for events for both the Static and Instance scans,
13005 pointing to the same element. Fix that.
13007 2002-03-14 Miguel de Icaza <miguel@ximian.com>
13009 * rootcontext.cs (ResolveTree): Always set the
13010 interface_resolve_order, because nested interfaces will be calling
13013 * class.cs (GetInterfaceOrClass): Track the same resolution
13014 process used by TypeManager.LookupType. This fixes the nested
13015 type lookups in class declarations (separate path from
13018 (TypeContainer.DefineType): Also define nested interfaces.
13019 (TypeContainer.RegisterOrder): New public function used to
13020 register the order in which child interfaces need to be closed.
13022 Nested interfaces need to be closed after their parents have been
13025 * interface.cs (InterfaceAttr): Put all the logic for computing
13026 the interface attribute here.
13028 (DefineInterface): Register our interface order with the
13029 RootContext or with the TypeContainer depending on the case.
13031 2002-03-12 Miguel de Icaza <miguel@ximian.com>
13033 * cs-parser.jay: rework foreach statement to work with the new
13034 changes to the policy on SimpleNames.
13036 * report.cs: support Stacktrace on warnings as well.
13038 * makefile: drop --unsafe and /unsafe from the compile.
13040 2002-03-13 Ravi Pratap <ravi@ximian.com>
13042 * ecore.cs (StandardConversionExists): Modify to take an Expression
13043 as the first parameter. Ensure we do null -> reference type conversion
13046 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
13047 temporary Expression objects.
13049 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
13051 * interface.cs: workaround bug in method overloading resolution
13052 (there is already a bugzilla bug for it).
13054 2002-03-12 Miguel de Icaza <miguel@ximian.com>
13056 We could also solve this problem by having a separate path for
13057 performing type lookups, instead of DoResolve, we could have a
13058 ResolveType entry point, and only participating pieces of the
13059 production (simplename, deref, array) would implement this.
13061 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
13062 signal SimpleName to only resolve type names and not attempt to
13063 resolve anything else.
13065 * expression.cs (Cast): Set the flag.
13067 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
13069 * class.cs: Only report 108 if there is no `new' modifier.
13071 * cs-parser.jay: rework foreach statement to work with the new
13072 changes to the policy on SimpleNames.
13074 * report.cs: support Stacktrace on warnings as well.
13076 * makefile: drop --unsafe and /unsafe from the compile.
13078 2002-03-11 Miguel de Icaza <miguel@ximian.com>
13080 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
13081 lookups here, instead of doing that at parse time. This means
13082 that our grammar will not introduce `LocalVariableReferences' as
13083 expressions at this point. That solves the problem of code like
13087 static void Main ()
13091 This is only half the fix. The full fix requires parameters to
13092 also be handled in this way.
13094 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
13095 makes the use more obvious of the DeclSpace. The
13096 ec.TypeContainer.TypeBuilder is now only used to pull the
13097 TypeBuilder for it.
13099 My theory is that I can get rid of the TypeBuilder completely from
13100 the EmitContext, and have typecasts where it is used (from
13101 DeclSpace to where it matters).
13103 The only pending problem is that the code that implements Aliases
13104 is on TypeContainer, and probably should go in DeclSpace.
13106 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
13107 lookups here, instead of doing that at parse time. This means
13108 that our grammar will not introduce `LocalVariableReferences' as
13109 expressions at this point. That solves the problem of code like
13113 static void Main ()
13117 This is only half the fix. The full fix requires parameters to
13118 also be handled in this way.
13120 * class.cs (Property.DefineMethod): When implementing an interface
13121 method, set newslot, when implementing an abstract method, do not
13122 set the flag (before we tried never setting it, or always setting
13123 it, which is the difference).
13124 (Indexer.DefineMethod): same.
13125 (Method.DefineMethod): same.
13127 * ecore.cs: Only set the status used flag if we get back a Field.
13129 * attribute.cs: Temporary hack, so Paolo can keep working.
13131 2002-03-08 Ravi Pratap <ravi@ximian.com>
13133 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
13134 the unmanaged type in the case we have a MarshalAs attribute.
13136 (Resolve): Handle the case when we are parsing the special MarshalAs
13137 attribute [we need to store the unmanaged type to use later]
13139 * typemanager.cs (marshal_as_attr_type): Built in type for the
13140 MarshalAs Attribute.
13142 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
13143 on parameters and accordingly set the marshalling info.
13145 2002-03-09 Miguel de Icaza <miguel@ximian.com>
13147 * class.cs: Optimizing slightly by removing redundant code after
13148 we switched to the `NoTypes' return value.
13149 (Property.DefineMethod): use NoTypes here too.
13151 This fixes the bug I introduced in my last batch of changes.
13153 2002-03-05 Ravi Pratap <ravi@ximian.com>
13155 * tree.cs (RecordEnum): Add. We now keep track of enums too.
13157 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
13158 Enums since those are types too.
13160 * cs-parser.jay (enum_declaration): Record enums as we parse them.
13162 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
13163 thanks to a call during the lookup process.
13165 2002-03-07 Miguel de Icaza <miguel@ximian.com>
13167 * statement.cs (Foreach): Lots of work to accomodate a particular
13168 kind of foreach statement that I had not kept in mind. It is
13169 possible to have foreachs on classes that provide a GetEnumerator
13170 method that return objects that implement the "pattern" for using
13171 a foreach, there is no need to support GetEnumerator
13174 This is needed to compile nant.
13176 * decl.cs: Only report 114 if the member is not `Finalize' and if
13177 the warning level is at least 2.
13179 * class.cs: Moved the compare function from Method to
13182 (MethodSignature.InheritableMemberSignatureCompare): Add new
13183 filter function that is used to extract inheritable methods from a
13186 (Method.Define): Use the new `inheritable_method_signature_filter'
13189 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
13192 2002-03-06 Miguel de Icaza <miguel@ximian.com>
13194 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
13196 * cs-parser.jay: Add opt_semicolon to the interface declaration.
13198 * expression.cs: Pass location information to
13199 ConvertImplicitStandard.
13201 * class.cs: Added debugging code to track return values from
13204 2002-03-05 Miguel de Icaza <miguel@ximian.com>
13206 * expression.cs (Is.DoResolve): If either side of the `is' is an
13207 interface, do not flag the warning.
13209 * ecore.cs (ImplicitReferenceConversion): We need a separate test
13212 * report.cs: Allow for --fatal to be used with --probe.
13214 * typemanager.cs (NoTypes): Move the definition for the empty Type
13217 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
13219 (TypeContainer.DefineProxy): New function used to proxy to parent
13220 implementations when implementing interfaces.
13221 (TypeContainer.ParentImplements): used to lookup if our parent
13222 implements a public function that is required by an interface.
13223 (TypeContainer.VerifyPendingMethods): Hook this up.
13225 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
13226 `modules' and `assemblies' arraylists into arrays. We only grow
13227 these are the very early start up of the program, so this improves
13228 the speedof LookupType (nicely measured).
13230 * expression.cs (MakeByteBlob): Replaced unsafe code with
13231 BitConverter, as suggested by Paolo.
13233 * cfold.cs (ConstantFold.Binary): Special case: perform constant
13234 folding of string concatenation, but if either side is a string,
13235 and the other is not, then return null, and let the runtime use
13236 the concatenation on the string plus the object (using
13237 `Object.ToString').
13239 2002-03-04 Miguel de Icaza <miguel@ximian.com>
13241 Constant Folding has been implemented now.
13243 * expression.cs (Unary.Reduce): Do not throw an exception, catch
13244 the error instead on types that are not supported in one's
13247 * constant.cs (Constant and all children): New set of functions to
13248 perform implict and explicit conversions.
13250 * ecore.cs (EnumConstant): Implement the new functions to perform
13251 conversion by proxying to the child expression.
13253 * codegen.cs: (ConstantCheckState): Constant evaluation has its
13254 own separate setting that can not be turned off from the command
13255 line using --unchecked or --checked and is only controlled using
13256 the checked/unchecked statements and expressions. This setting is
13257 used by the constant folder to flag errors.
13259 * expression.cs (CheckedExpr, UncheckedExpr): Set the
13260 ConstantCheckState as well.
13262 During Resolve, they also have to flag the state, because the
13263 constant folder runs completely in the Resolve phase.
13265 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
13268 2002-03-01 Miguel de Icaza <miguel@ximian.com>
13270 * cfold.cs: New file, this file contains the constant folder.
13272 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
13273 argument to track whether we are using the resulting address to
13274 load or store a value and provide better error messages.
13276 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
13277 new AddressOf arguments.
13279 * statement.cs (Foreach.EmitCollectionForeach): Update
13281 * expression.cs (Argument.Emit): Call AddressOf with proper
13282 arguments to track usage.
13284 (New.DoEmit): Call AddressOf with new arguments.
13286 (Unary.Emit): Adjust AddressOf call.
13288 2002-03-01 Ravi Pratap <ravi@ximian.com>
13290 * cs-parser.jay (member_access): Change the case for pre-defined types
13291 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
13294 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
13297 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
13298 essentially like methods and apply attributes like MethodImplOptions to them too.
13300 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
13303 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
13304 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
13307 * Update code everywhere accordingly.
13309 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
13311 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
13313 2002-02-28 Ravi Pratap <ravi@ximian.com>
13315 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
13316 try performing lookups against those instead of jumping straight into using
13317 the 'using' clauses.
13319 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
13321 (LookupType): Perform lookups in implicit parents too.
13323 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
13324 sequence as RootContext.LookupType.
13326 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
13327 the various cases of namespace lookups into this method.
13329 2002-03-01 Miguel de Icaza <miguel@ximian.com>
13331 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
13332 in positional arguments)
13334 * class.cs (Operator): Update the AllowedModifiers to contain
13337 * cs-parser.jay: Update operator declaration to allow for the
13338 operator body to be empty.
13340 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
13343 2002-02-27 Miguel de Icaza <miguel@ximian.com>
13345 * class.cs (Method.Emit): Label parameters.
13347 * driver.cs: Return 1 or 0 as the program exit code.
13349 2002-02-26 Miguel de Icaza <miguel@ximian.com>
13351 * expression.cs: Special case the `null' object when trying to
13352 auto-compute the type, as anything can be explicitly converted to
13355 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
13356 spotting this Paolo.
13358 (Expression.ImplicitNumericConversion): Perform comparissions of
13359 the type using the underlying type in the case of an enumeration
13360 rather than using the enumeration type for the compare.
13362 Cope with the underlying == type case, which is not possible to
13365 (Expression.ConvertNumericExplicit): Perform comparissions of
13366 the type using the underlying type in the case of an enumeration
13367 rather than using the enumeration type for the compare.
13369 * driver.cs: If the user does not supply an extension, assume .exe
13371 * cs-parser.jay (if_statement): Rewrote so that we can track the
13372 location for the if statement.
13374 * expression.cs (Binary.ConstantFold): Only concat strings when
13375 the operation is "+", not everything ;-)
13377 * statement.cs (Statement.EmitBoolExpression): Take a location
13379 (If, While, Do): Track location.
13381 * expression.cs (Binary.ResolveOperator): In the object + string
13382 case, I was missing a call to ConvertImplicit
13384 2002-02-25 Ravi Pratap <ravi@ximian.com>
13386 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
13387 Location arguments. Ensure we use RootContext.LookupType to do our work
13388 and not try to do a direct Type.GetType and ModuleBuilder.GetType
13390 * interface.cs (PopulateMethod): Handle the type of the parameter being
13393 * expression.cs (Invocation.BetterFunction): Handle the case when we
13394 have a params method with no fixed arguments and a call is made with no
13397 2002-02-25 Miguel de Icaza <miguel@ximian.com>
13399 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
13400 the verbatim-string-literal
13402 * support.cs (InternalParameters.ParameterModifier): handle null
13404 (InternalParameters.ParameterType): ditto.
13406 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
13407 duplicating the name of the variable parameter.
13408 (GetParameterByName): Fix bug where we were not looking up array
13409 paramters if they were the only present (thanks Paolo!).
13410 (GetParameterInfo): We only have an empty set of types if both
13411 fixed and array are set to null.
13412 (GetParameterInfo-idx): Handle FixedParameter == null
13414 * cs-parser.jay: Handle the case where there is no catch
13415 statements (missing null test).
13417 2002-02-22 Miguel de Icaza <miguel@ximian.com>
13419 * driver.cs (MainDriver): Be conservative on our command line
13422 Catch DirectoryNotFoundException when calling GetFiles.
13424 (SplitPathAndPattern): Used to split the input specification into
13425 a path and a pattern that we can feed to Directory.GetFiles.
13427 2002-02-21 Miguel de Icaza <miguel@ximian.com>
13429 * statement.cs (Fixed): Implement the last case of the Fixed
13430 statement (string handling).
13432 * expression.cs (StringPtr): New class used to return a char * to
13433 a string; Used by the Fixed statement.
13435 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
13437 * expression.cs (Binary.ResolveOperator): Remove redundant
13438 MemberLookup pn parent type.
13439 Optimize union call, we do not need a union if the types are the same.
13440 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
13443 Specialize the use of MemberLookup everywhere, instead of using
13444 the default settings.
13446 (StackAlloc): Implement stackalloc keyword.
13448 * cs-parser.jay: Add rule to parse stackalloc.
13450 * driver.cs: Handle /h, /help, /?
13452 * expression.cs (MakeByteBlob): Removed the hacks we had in place
13453 before we supported unsafe code.
13455 * makefile: add --unsafe to the self compilation of mcs.
13457 2002-02-20 Miguel de Icaza <miguel@ximian.com>
13459 * expression.cs (PointerArithmetic): New class that is used to
13460 perform pointer arithmetic.
13461 (Binary.Resolve): Handle pointer arithmetic
13462 Handle pointer comparission.
13463 (ArrayPtr): Utility expression class that is used to take the
13464 address of an array.
13466 (ElementAccess): Implement array access for pointers
13468 * statement.cs (Fixed): Implement fixed statement for arrays, we
13469 are missing one more case before we are done.
13471 * expression.cs (Indirection): Implement EmitAssign and set the
13472 ExprClass to Variable. This allows pointer dereferences to be
13473 treated as variables, and to have values assigned to them.
13475 * ecore.cs (Expression.StoreFromPtr): New utility function to
13476 store values dereferencing.
13478 2002-02-20 Ravi Pratap <ravi@ximian.com>
13480 * expression.cs (Binary.ResolveOperator): Ensure that we are
13481 not trying to operate on a void type - this fixes the reported
13484 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
13485 the parent implementation is sealed.
13487 * ../errors/cs0239.cs : Add.
13489 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
13491 * typemanager.cs (unverifiable_code_type): Corresponds to
13492 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
13493 which have unsafe code in them.
13495 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
13498 2002-02-19 Miguel de Icaza <miguel@ximian.com>
13500 * cs-tokenizer.cs: Add support for @"litreal strings"
13502 Make tokenizer accept pre-processor directives
13503 on any column (remove the old C-like limitation).
13505 * rootcontext.cs (EmitCode): Emit any global attributes.
13506 (AddGlobalAttributes): Used to keep track of assembly attributes.
13508 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
13510 * cs-parser.jay: Add support for global attributes.
13512 2002-02-17 Miguel de Icaza <miguel@ximian.com>
13514 * expression.cs (Indirection): New helper class. Unary will
13515 create Indirection classes to be able to implement the
13516 IMemoryLocation interface on it.
13518 2002-02-16 Miguel de Icaza <miguel@ximian.com>
13520 * cs-parser.jay (fixed_statement): reference the right statement.
13522 * statement.cs (Fixed.Emit): Finish implementing the fixed
13523 statement for the &x case.
13525 2002-02-14 Miguel de Icaza <miguel@ximian.com>
13527 * class.cs (Property.Define, Method.Define): Remove newslot when
13530 * modifiers.cs: My use of NewSlot when `Abstract' was set was
13531 wrong. NewSlot should only be used if the `new' keyword is present.
13533 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
13534 locating our system dir. Sorry about this.
13536 2002-02-13 Miguel de Icaza <miguel@ximian.com>
13538 * driver.cs (GetSystemDir): Compute correctly the location of our
13539 system assemblies. I was using the compiler directory instead of
13540 the library directory.
13542 2002-02-13 Ravi Pratap <ravi@ximian.com>
13544 * expression.cs (BetterFunction): Put back in what Miguel commented out
13545 since it is the correct fix. The problem is elsewhere ;-)
13547 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
13548 parameters of the parms method are themselves compatible or not !
13550 (StandardConversionExists): Fix very dangerous bug where we were forgetting
13551 to check that a class implements an interface before saying that an implicit
13552 conversion was allowed. Use ImplementsInterface to do the checking.
13554 2002-02-13 Miguel de Icaza <miguel@ximian.com>
13556 * class.cs (Method.Define): Track whether we are an explicit
13557 implementation or not. And only call DefineMethodOverride if we
13558 are an explicit implementation.
13560 (Property.DefineMethod): Ditto.
13562 2002-02-11 Ravi Pratap <ravi@ximian.com>
13564 * expression.cs (BetterFunction): Catch hideous bug which was
13565 preventing us from detecting ambiguous calls due to implicit casts i.e
13568 2002-01-29 Miguel de Icaza <miguel@ximian.com>
13570 * support.cs (Pair): Remove un-needed method. I figured why I was
13571 getting the error in cs-parser.jay, the variable in a foreach loop
13572 is readonly, and the compiler does not really treat this as a variable.
13574 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
13575 instead of EQUALS in grammar.
13577 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
13579 * expression.cs (Unary.DoResolve): Check whether the argument is
13582 2002-01-28 Miguel de Icaza <miguel@ximian.com>
13584 * support.cs: Api for Pair to set a value. Despite the fact that
13585 the variables are public the MS C# compiler refuses to compile
13586 code that accesses the field if the variable is part of a foreach
13589 * statement.cs (Fixed): Begin implementation of the fixed
13592 (Block.AddVariable): Return the VariableInfo on success and null
13593 on failure instead of true/false.
13595 * cs-parser.jay (foreach): Catch errors on variables already
13596 defined (we were ignoring this value before) and properly unwind
13597 the block hierarchy
13599 (fixed_statement): grammar for the fixed statement.
13601 2002-01-25 Miguel de Icaza <miguel@ximian.com>
13603 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
13604 pointer types to be incretemented.
13606 (SizeOf): Implement.
13608 * cs-parser.jay (pointer_member_access): Implement
13609 expr->IDENTIFIER production.
13611 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
13612 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
13615 (Unary): Implement indirection.
13617 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
13618 use in non-unsafe context).
13620 (SimpleName.DoResolve): Check for pointers in field access on safe
13623 (Expression.LoadFromPtr): Factor the load-indirect code in this
13624 function. This was duplicated in UnboxCast and ParameterReference
13626 2002-01-24 Miguel de Icaza <miguel@ximian.com>
13628 * expression.cs (ComposedCast): report an error if a pointer cast
13629 is used in a safe region.
13631 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
13632 pointer type casts in unsafe context.
13634 * codegen.cs (EmitContext): Set up IsUnsafe.
13636 * cs-parser.jay (non_expression_type): Add productions for pointer
13639 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
13640 code. We should not use force into static mode if the method is
13641 not virtual. Fixes bug in MIS
13643 * statement.cs (Do.Emit, While.Emit, For.Emit,
13644 Statement.EmitBoolExpression): Add support to Do and While to
13645 propagate infinite loop as `I do return' semantics.
13647 Improve the For case to also test for boolean constants.
13649 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
13650 to the list of attributes we can add.
13652 Remove `EmitContext' argument.
13654 * class.cs (Method.Define): Apply parameter attributes.
13655 (Constructor.Define): Apply parameter attributes.
13656 (MethodCore.LabelParameters): Move here the core of labeling
13659 * support.cs (ReflectionParameters.ParameterModifier,
13660 InternalParameters.ParameterModifier): Use IsByRef on the type and
13661 only return the OUT bit for these parameters instead of in/out/ref
13664 This is because I miss-understood things. The ParameterInfo.IsIn
13665 and IsOut represent whether the parameter has the [In] and [Out]
13668 2002-01-22 Miguel de Icaza <miguel@ximian.com>
13670 * ecore.cs (FieldExpr.Emit): Release temporaries.
13672 * assign.cs (LocalTemporary.Release): new function.
13674 * codegen.cs (EmitContext.GetTemporaryStorage,
13675 EmitContext.FreeTemporaryStorage): Rework the way we deal with
13676 temporary storage. Now we can "put back" localbuilders when we
13679 2002-01-21 Miguel de Icaza <miguel@ximian.com>
13681 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
13682 need to make a copy of the variable to generate verifiable code.
13684 2002-01-19 Miguel de Icaza <miguel@ximian.com>
13686 * driver.cs: Compute dynamically the system directory.
13688 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
13689 Slower, but more generally useful. Used by the abstract
13690 registering implementation.
13692 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
13693 the rules for the special rule on Type/instances. First check if
13694 we have the same name, and if so, try that special static path
13695 rather than the instance path.
13697 2002-01-18 Miguel de Icaza <miguel@ximian.com>
13699 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
13702 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
13703 Enum, ValueType, Delegate or Array for non-corlib compiles.
13705 * cs-tokenizer.cs: Catch long identifiers (645)
13707 * typemanager.cs (IndexerPropetyName): Ravi never tested this
13710 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
13711 fix, we were returning too early, so we were not registering
13712 pending methods from abstract classes.
13714 Do not register pending methods if the class is abstract.
13716 * expression.cs (Conditional.DoResolve): Report circular implicit
13717 conversions when we neecd to compute it for conditional
13720 (Is.DoResolve): If the expression is always of the provided type,
13721 flag warning 183. If the expression can not ever be of the
13722 provided type flag warning 184.
13724 * class.cs: Catch 169 as well.
13726 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
13729 2002-01-18 Nick Drochak <ndrochak@gol.com>
13731 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
13733 2002-01-17 Miguel de Icaza <miguel@ximian.com>
13735 * interface.cs: (PopulateMethod): Check for pointers being defined
13736 only if the unsafe context is active.
13737 (PopulateProperty): ditto.
13738 (PopulateIndexer): ditto.
13740 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
13741 specified. If pointers are present, make sure that they are
13742 present in an unsafe context.
13743 (Constructor, Constructor.Define): ditto.
13744 (Field, Field.Define): ditto.
13745 (Property, Property.Define): ditto.
13746 (Event, Event.Define): ditto.
13748 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
13749 hashtable if there are classes or structs defined.
13751 * expression.cs (LocalVariableReference.DoResolve): Simplify this
13752 code, as the constant resolution moved.
13754 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
13755 the metadata, so we can flag error 133.
13757 * decl.cs (MemberCore.UnsafeOK): New function to test that a
13758 pointer is being declared in an unsafe context.
13760 2002-01-16 Miguel de Icaza <miguel@ximian.com>
13762 * modifiers.cs (Modifiers.Check): Require a Location argument.
13763 Report error 227 for Unsafe use.
13765 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
13767 * statement.cs (For.Emit): If the test is null, then report that
13768 we do `return', as we wont reach anything afterwards.
13770 (Switch.SwitchGoverningType): Track the expression that matched
13773 * driver.cs: Allow negative numbers as an error code to flag.
13775 * cs-parser.jay: Handle 1551.
13777 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
13779 2002-01-15 Miguel de Icaza <miguel@ximian.com>
13781 * cs-parser.jay: Report 1518 (type declaration can only contain
13782 class, struct, interface, enum or delegate)
13784 (switch_label): Report 1523 (keywords `case' or `default' must
13787 (opt_switch_sections): Report 1522 (empty switch)
13789 * driver.cs: Report 1515 (response file specified multiple times)
13790 Report 1516 (Source file specified multiple times).
13792 * expression.cs (Argument.Resolve): Signal 1510
13794 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
13795 access not allowed in static code)
13797 2002-01-11 Ravi Pratap <ravi@ximian.com>
13799 * typemanager.cs (IsPointerType): Utility method which we are going
13802 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
13803 the object type, so we take care of that.
13805 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
13807 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
13808 added to non-params parameters :-)
13810 * typemanager.cs (CSharpName): Include 'void' type too.
13812 (void_ptr_type): Include in the set of core types.
13814 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
13817 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
13820 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
13821 completely forgotten about it.
13823 2002-01-10 Ravi Pratap <ravi@ximian.com>
13825 * cs-parser.jay (pointer_type): Add. This begins our implementation
13826 of parsing rules for unsafe code.
13828 (unsafe_statement): Implement.
13830 (embedded_statement): Modify to include the above.
13832 * statement.cs (Unsafe): Implement new class for unsafe blocks.
13834 * codegen.cs (EmitContext.InUnsafe): Add. This determines
13835 if the current context is an unsafe one.
13837 * cs-parser.jay (local_variable_pointer_type): Since local variable types
13838 are handled differently, we need separate rules for them.
13840 (local_variable_declaration): Update to use local_variable_pointer_type
13841 to allow variable declarations of unmanaged pointer types.
13843 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
13844 in unsafe contexts.
13846 * ../errors/cs0214.cs : Add.
13848 2002-01-16 Nick Drochak <ndrochak@gol.com>
13850 * makefile: remove 'response' file when cleaning.
13852 2002-01-15 Miguel de Icaza <miguel@ximian.com>
13854 * cs-parser.jay: Report 1524.
13856 2002-01-14 Miguel de Icaza <miguel@ximian.com>
13858 * typemanager.cs (RegisterMethod): drop checking if we have
13859 registered this from here
13861 2002-01-12 Miguel de Icaza <miguel@ximian.com>
13863 * class.cs (Method.EmitDestructor): Implement calling our base
13866 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
13867 value of InFinally.
13869 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
13870 this routine and will wrap the call in a try/catch block. Deal
13873 2002-01-11 Miguel de Icaza <miguel@ximian.com>
13875 * ecore.cs (Expression.MemberLookup): instead of taking a
13876 parameter `same_type' that was used to tell whether we could
13877 access private members we compute our containing type from the
13880 (FieldExpr): Added partial support for volatile fields. This does
13881 not work for volatile fields exposed from assemblies, as I can not
13882 figure out how to extract the modreq from it.
13884 Updated all the source files to use this.
13886 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
13887 because it is referenced by MemberLookup very often.
13889 2002-01-09 Ravi Pratap <ravi@ximian.com>
13891 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
13892 TypeBuilder.GetCustomAttributes to retrieve what we need.
13894 Get rid of redundant default_member_attr_type as this is the same as
13895 default_member_type which already exists.
13897 * interface.cs, attribute.cs : Update accordingly.
13899 2002-01-08 Miguel de Icaza <miguel@ximian.com>
13901 * typemanager.cs: Enable IndexerPropertyName again. It does not
13902 work for TYpeBuilders though. Ravi, can you please fix this?
13904 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
13906 * expression.cs (Argument.Emit): Handle the case of ref objects
13907 being passed to ref functions;
13909 (ParameterReference.EmitLoad): Loads the content of the pointer
13910 without dereferencing.
13912 2002-01-07 Miguel de Icaza <miguel@ximian.com>
13914 * cs-tokenizer.cs: Implemented the pre-processing expressions.
13916 2002-01-08 Ravi Pratap <ravi@ximian.com>
13918 * class.cs (Indexer.DefineMethod): Incorporate the interface
13919 type in the name of the method if we are doing explicit interface
13922 * expression.cs (ConversionExists): Remove as it is completely obsolete.
13924 (BetterConversion): Fix extremely trivial bug where we were referring to
13925 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
13928 * ../errors/bug16.cs : Add although we have fixed it.
13930 2002-01-07 Miguel de Icaza <miguel@ximian.com>
13932 * expression.cs (BaseIndexer): Begin implementation.
13934 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
13936 * cs-parser.jay (indexer_declarator): Use qualified_identifier
13937 production directly to remove a shift/reduce, and implement
13938 explicit interface implementation.
13940 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
13941 after a floating point suffix.
13943 * expression.cs (DoNumericPromotions): Improved the conversion for
13944 uint/uint. If we have a constant, we avoid doing a typecast to a
13947 * class.cs (Indexer): Implement explicit interface implementation
13950 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
13952 * class.cs: make the default instance constructor public and hidebysig.
13954 2001-01-03 Ravi Pratap <ravi@ximian.com>
13956 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
13957 so we can call it from elsewhere.
13959 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
13960 we emit it internally if the class has a defined indexer; otherwise the user
13961 emits it by decorating the class definition with the DefaultMemberAttribute.
13963 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
13964 attribute is not used on a type which defines an indexer.
13966 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
13967 character when we skip whitespace.
13969 * ../errors/cs0646.cs : Add.
13971 2002-01-03 Miguel de Icaza <miguel@ximian.com>
13973 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
13976 * makefile: Add practical target `mcs3.exe' which builds the third
13977 generation compiler.
13979 * expression.cs (New): Fix structures constructor calling.
13981 * class.cs (Property, Method, Indexer): Emit Final flag on the
13982 method if we are an interface implementation and we are not
13985 * ecore.cs (PropertyExpr): New public field `IsBase', tells
13986 whether this property is referencing a `base' method.
13988 * expression.cs (Invocation.EmitCall): take an extra argument:
13989 is_base, this is used to determine whether the `call' or
13990 `callvirt' opcode should be used.
13993 * delegate.cs: update EmitCall.
13995 * class.cs (Method.Define): Set NewSlot for the cases where we are
13996 not implementing an interface method.
13998 (Property.Define): ditto.
14000 2002-01-02 Miguel de Icaza <miguel@ximian.com>
14002 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
14003 'r'. Allows mcs to parse itself fully.
14005 2002-01-02 Ravi Pratap <ravi@ximian.com>
14007 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
14008 of the number of initializers that require the InitializeArray method.
14010 (CheckIndices): Store the Expression in all cases - not the plain value. Also
14011 update the above field where necessary.
14013 (MakeByteBlob): Update accordingly.
14015 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
14018 (EmitDynamicInitializers): Update in accordance with the new optimization.
14020 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
14021 same OpCode applies.
14023 * cs-parser.jay : Fix some glaring errors I introduced.
14025 2002-01-01 Ravi Pratap <ravi@ximian.com>
14027 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
14028 so that we can check for name clashes there too.
14030 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
14031 for interface indexers.
14033 * interfaces.cs (Define): Emit the default member attribute.
14035 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
14036 variable was being referred to while setting the value ;-)
14038 2002-01-01 Miguel de Icaza <miguel@ximian.com>
14040 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
14041 byte-by-byte information when we know the data is zero.
14043 Make the block always a multiple of 4, because
14044 DefineInitializedData has a bug.
14046 * assign.cs: Fix, we should assign from the temporary, not from
14049 * expression.cs (MakeByteBlob): Fix my incorrect code.
14051 2001-12-31 Miguel de Icaza <miguel@ximian.com>
14053 * typemanager.cs (EnumToUnderlying): This function is used to get
14054 the underlying type from an enumeration, because it does not
14057 * constant.cs: Use the I4_S form for values between -128 and 127.
14059 * statement.cs (Block.LookupLabel): Looks up a label.
14060 (Block): Drop support for labeled blocks.
14062 (LabeledStatement): New kind of statement that represents a label
14065 (Goto): Finally implement this bad boy.
14067 * cs-parser.jay: Update to reflect new mechanism to implement
14070 2001-12-30 Miguel de Icaza <miguel@ximian.com>
14072 * codegen.cs (EmitContext.This): a codegen property that keeps the
14073 a single instance of this instead of creating many different this
14076 * delegate.cs (Delegate.DoResolve): Update to use the property;
14078 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
14080 * expression.cs (BaseAccess.DoResolve): Ditto.
14082 2001-12-29 Ravi Pratap <ravi@ximian.com>
14084 * typemanager.cs (methodimpl_attr_type): Add to hold the type
14085 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
14087 (InitCoreTypes): Update accordingly.
14089 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
14090 so we can quickly store the state.
14092 (ApplyAttributes): Set the correct implementation flags
14093 for InternalCall methods.
14095 2001-12-29 Miguel de Icaza <miguel@ximian.com>
14097 * expression.cs (EmitCall): if a method is not virtual, then do
14098 not use callvirt on it.
14100 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
14101 user defined stuff) requires the use of stobj, which takes an
14102 address on the stack instead of an array and an index. So emit
14103 the Ldelema operation for it.
14105 (EmitStoreOpcode): Use stobj for valuetypes.
14107 (UnaryMutator.EmitCode): Use the right 1 value depending on
14108 whether we are dealing with int64/uint64, float or doubles.
14110 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
14111 constructors that I implemented last night.
14113 (Constructor.IsDefault): Fix to work properly for static
14116 * cs-parser.jay (CheckDef): report method signature errors.
14117 Update error number 103 to be 132.
14119 * decl.cs: New AdditionResult enumeration value: MethodExists.
14120 Although we do this check for methods later on in the semantic
14121 analysis, catching repeated default constructors is so easy that
14122 we catch these here.
14124 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
14127 (ParameterReference.EmitAssign, Emit): handle
14130 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
14131 (ArrayAccess.EmitStoreOpcode): ditto.
14133 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
14135 * expression.cs (MakeByteBlob): Complete all the missing types
14136 (uint, short, ushort, byte, sbyte)
14138 * class.cs: Only init instance field initializers on instance
14141 Rename `constructors' to instance_constructors.
14143 (TypeContainer.AddConstructor): Only add constructors to the list
14144 if it is not static.
14146 Make sure that we handle default_static_constructor independently
14147 everywhere where we handle instance_constructors
14149 2001-12-28 Miguel de Icaza <miguel@ximian.com>
14151 * class.cs: Do not lookup or create a base initializer for a
14152 static constructor.
14154 (ConstructorInitializer.Resolve): use the proper type to lookup
14157 * cs-parser.jay: Report error 1585 (modifiers between type and name).
14159 * enum.cs, interface.cs: Remove CloseType, this is taken care by
14162 * decl.cs: CloseType is now an virtual method, the default
14163 implementation just closes this type.
14165 2001-12-28 Ravi Pratap <ravi@ximian.com>
14167 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
14168 to PreserveSig by default. Also emit HideBySig on such methods.
14170 Basically, set the defaults to standard values.
14172 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
14173 argument, if candidate is better, it can't be worse than the best !
14175 (Invocation): Re-write bits to differentiate between methods being
14176 applicable in their expanded form and their normal form - for params
14179 Get rid of use_standard everywhere as only standard conversions are allowed
14180 in overload resolution.
14182 More spec conformance.
14184 2001-12-27 Miguel de Icaza <miguel@ximian.com>
14186 * driver.cs: Add --timestamp, to see where the compiler spends
14189 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
14190 `this' in static code.
14192 (SimpleName.DoResolve): Implement in terms of a helper function
14193 that allows static-references to be passed upstream to
14196 (Expression.ResolveWithSimpleName): Resolve specially simple
14197 names when called by MemberAccess to implement the special
14200 (Expression.ImplicitReferenceConversion): Handle conversions from
14201 Null to reference types before others, as Null's type is
14204 * expression.cs (Invocation.EmitCall): Handle the special case of
14205 calling methods declared on a reference type from a ValueType
14206 (Base classes System.Object and System.Enum)
14208 (MemberAccess.Resolve): Only perform lookups on Enumerations if
14209 the left hand side is a TypeExpr, not on every enumeration.
14211 (Binary.Resolve): If types are reference types, then do a cast to
14212 object on operators != and == of both arguments.
14214 * typemanager.cs (FindMembers): Extract instance and static
14215 members if requested.
14217 * interface.cs (PopulateProperty): Use void_type instead of null
14218 as the return type for the setter method.
14220 (PopulateIndexer): ditto.
14222 2001-12-27 Ravi Pratap <ravi@ximian.com>
14224 * support.cs (ReflectionParameters): Fix minor bug where we
14225 were examining the wrong parameter for the ParamArray attribute.
14227 Cope with requests for the type of the parameter at position
14228 greater than the params parameter's. We now return the element
14229 type of the params array as that makes more sense.
14231 * expression.cs (Invocation.IsParamsMethodApplicable): Update
14232 accordingly as we no longer have to extract the element type
14235 (Invocation.OverloadResolve): Update.
14237 2001-12-27 Miguel de Icaza <miguel@ximian.com>
14239 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
14240 against IEnumerator, test whether the return value is a descendant
14241 of the IEnumerator interface.
14243 * class.cs (Indexer.Define): Use an auxiliary method to implement
14244 the other bits of the method definition. Begin support for
14245 explicit interface implementation.
14247 (Property.DefineMethod): Use TypeManager.void_type instead of null
14248 for an empty return value.
14250 2001-12-26 Miguel de Icaza <miguel@ximian.com>
14252 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
14253 dealing with a FieldExpr which is composed of a FieldBuilder, in
14254 the code path we did extract the constant, but we should have
14255 obtained the underlying value to be able to cast it (otherwise we
14256 end up in an infinite loop, this is what Ravi was running into).
14258 (ArrayCreation.UpdateIndices): Arrays might be empty.
14260 (MemberAccess.ResolveMemberAccess): Add support for section
14261 14.5.4.1 that deals with the special case of E.I when E is a type
14262 and something else, that I can be a reference to a static member.
14264 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
14265 handle a particular array type to create byte blobs, it is just
14266 something we dont generate byteblobs for.
14268 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
14271 * location.cs (Push): remove the key from the hashtable that we
14272 are about to add. This happens for empty files.
14274 * driver.cs: Dispose files after we have parsed them.
14276 (tokenize): new function that only runs the tokenizer on its
14277 input, for speed testing.
14279 2001-12-26 Ravi Pratap <ravi@ximian.com>
14281 * class.cs (Event.Define): Define the private field only if there
14282 are no accessors defined.
14284 * expression.cs (ResolveMemberAccess): If there is no associated
14285 field with the event, that means we have an event defined with its
14286 own accessors and we should flag error cs0070 since transforming
14287 ourselves into a field is not valid in that case.
14289 * ecore.cs (SimpleName.DoResolve): Same as above.
14291 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
14292 and charset to sane values.
14294 2001-12-25 Ravi Pratap <ravi@ximian.com>
14296 * assign.cs (DoResolve): Perform check on events only if they
14297 are being accessed outside the declaring type.
14299 * cs-parser.jay (event_declarations): Update rules to correctly
14300 set the type of the implicit parameter etc.
14302 (add_accessor, remove_accessor): Set current local parameters.
14304 * expression.cs (Binary): For delegate addition and subtraction,
14305 cast the return value from the method into the appropriate delegate
14308 2001-12-24 Ravi Pratap <ravi@ximian.com>
14310 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
14311 of these as the workaround is unnecessary.
14313 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
14314 delegate data - none of that is needed at all.
14316 Re-write bits to extract the instance expression and the delegate method
14319 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
14322 * attribute.cs (ApplyAttributes): New method to take care of common tasks
14323 of attaching attributes instead of duplicating code everywhere.
14325 * everywhere : Update code to do attribute emission using the above method.
14327 2001-12-23 Miguel de Icaza <miguel@ximian.com>
14329 * expression.cs (IsParamsMethodApplicable): if there are not
14330 parameters, return immediately.
14332 * ecore.cs: The 0 literal can be implicity converted to an enum
14335 (SimpleName.DoResolve): First lookup the type, then lookup the
14338 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
14339 want to get its address. If the InstanceExpression is not
14340 addressable, store the result in a temporary variable, then get
14343 * codegen.cs: Only display 219 errors on warning level or above.
14345 * expression.cs (ArrayAccess): Make it implement the
14346 IMemoryLocation interface.
14348 (Binary.DoResolve): handle the operator == (object a, object b)
14349 and operator != (object a, object b) without incurring into a
14350 BoxedCast (because 5 != o should never be performed).
14352 Handle binary enumerator operators.
14354 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
14355 value type, otherwise use Ldelem_ref.
14357 Use precomputed names;
14359 (AddressOf): Implement address of
14361 * cs-parser.jay (labeled_statement): Fix recursive block
14362 addition by reworking the production.
14364 * expression.cs (New.DoEmit): New has a special case:
14366 If we are dealing with a ValueType, we have a few
14367 situations to deal with:
14369 * The target of New is a ValueType variable, that is
14370 easy, we just pass this as the variable reference
14372 * The target of New is being passed as an argument,
14373 to a boxing operation or a function that takes a
14376 In this case, we need to create a temporary variable
14377 that is the argument of New.
14380 2001-12-23 Ravi Pratap <ravi@ximian.com>
14382 * rootcontext.cs (LookupType): Check that current_type is not null before
14383 going about looking at nested types.
14385 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
14386 not implement the IAssignMethod interface any more.
14388 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
14389 where we tranform them into FieldExprs if they are being resolved from within
14390 the declaring type.
14392 * ecore.cs (SimpleName.DoResolve): Do the same here.
14394 * assign.cs (DoResolve, Emit): Clean up code considerably.
14396 * ../errors/bug10.cs : Add.
14398 * ../errors/cs0070.cs : Add.
14400 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
14402 * assign.cs : Get rid of EventIsLocal everywhere.
14404 2001-12-23 Miguel de Icaza <miguel@ximian.com>
14406 * ecore.cs (ConvertIntLiteral): finished the implementation.
14408 * statement.cs (SwitchLabel): Convert the value we are using as a
14409 key before looking up the table.
14411 2001-12-22 Miguel de Icaza <miguel@ximian.com>
14413 * codegen.cs (EmitTopBlock): Require a Location argument now.
14415 * cs-parser.jay (constructor_declarator): We need to setup
14416 current_local_parameters before we parse the
14417 opt_constructor_initializer, to allow the variables to be bound
14418 to the constructor arguments.
14420 * rootcontext.cs (LookupType): First lookup nested classes in our
14421 class and our parents before we go looking outside our class.
14423 * expression.cs (ConstantFold): Extract/debox the values at the
14426 * rootcontext.cs (EmitCode): Resolve the constants first before we
14427 resolve the types. This is not really needed, but it helps debugging.
14429 * statement.cs: report location.
14431 * cs-parser.jay: pass location to throw statement.
14433 * driver.cs: Small bug fix.
14435 * report.cs: Updated format to be 4-zero filled digits.
14437 2001-12-22 Ravi Pratap <ravi@ximian.com>
14439 * expression.cs (CheckIndices): Fix minor bug where the wrong
14440 variable was being referred to ;-)
14442 (DoEmit): Do not call EmitStaticInitializers when the
14443 underlying type is System.Object.
14445 2001-12-21 Ravi Pratap <ravi@ximian.com>
14447 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
14448 and do the usual workaround for SRE.
14450 * class.cs (MyEventBuilder.EventType): New member to get at the type
14451 of the event, quickly.
14453 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
14455 * assign.cs (Assign.DoResolve): Handle the case when the target
14456 is an EventExpr and perform the necessary checks.
14458 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
14461 (SimpleName.MemberStaticCheck): Include check for EventExpr.
14463 (EventExpr): Set the type in the constructor itself since we
14464 are meant to be born fully resolved.
14466 (EventExpr.Define): Revert code I wrote earlier.
14468 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
14469 instance expression is null. The instance expression is a This in that case
14470 or a null, depending on whether it is a static method or not.
14472 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
14473 refers to more than one method.
14475 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
14476 and accordingly flag errors.
14478 2001-12-21 Miguel de Icaza <miguel@ximian.com>
14480 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
14482 2001-12-22 Miguel de Icaza <miguel@ximian.com>
14484 * location.cs (ToString): Provide useful rutine.
14486 2001-12-21 Miguel de Icaza <miguel@ximian.com>
14488 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
14489 objects, return the actual integral boxed.
14491 * statement.cs (SwitchLabel): define an ILLabel for each
14494 (Switch.CheckSwitch): If the value is a Literal, extract
14495 the underlying literal.
14497 Also in the unused hashtable we had, add the SwitchLabel so we can
14498 quickly look this value up.
14500 * constant.cs: Implement a bunch of new constants. Rewrite
14501 Literal based on this. Made changes everywhere to adapt to this.
14503 * expression.cs (Expression.MakeByteBlob): Optimize routine by
14504 dereferencing array only once, and also copes with enumrations.
14506 bytes are two bytes wide, not one.
14508 (Cast): Perform constant conversions.
14510 * ecore.cs (TryImplicitIntConversion): Return literals instead of
14511 wrappers to the literals here.
14513 * expression.cs (DoNumericPromotions): long literals can converted
14514 to ulong implicity (this is taken care of elsewhere, but I was
14515 missing this spot).
14517 * ecore.cs (Expression.Literalize): Make the return type Literal,
14518 to improve type checking.
14520 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
14522 2001-12-20 Miguel de Icaza <miguel@ximian.com>
14524 * literal.cs: Revert code from ravi that checked the bounds. The
14525 bounds are sane by the definition of the type itself.
14527 * typemanager.cs: Fix implementation of ImplementsInterface. We
14528 need to actually look up in our parent hierarchy for interfaces
14531 * const.cs: Use the underlying type for enumerations
14533 * delegate.cs: Compute the basename for the delegate creation,
14534 that should fix the delegate test case, and restore the correct
14535 Type Lookup semantics in rootcontext
14537 * rootcontext.cs: Revert Ravi's last patch. The correct way of
14538 referencing a nested type with the Reflection API is using the "+"
14541 * cs-parser.jay: Do not require EOF token at the end.
14543 2001-12-20 Ravi Pratap <ravi@ximian.com>
14545 * rootcontext.cs (LookupType): Concatenate type names with
14546 a '.' instead of a '+' The test suite passes again.
14548 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
14549 field of the enumeration.
14551 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
14552 the case when the member is an EventExpr.
14554 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
14555 static has an associated instance expression.
14557 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
14559 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
14561 * class.cs (Event.Define): Register event and perform appropriate checks
14564 We define the Add and Remove methods even if the use provides none because
14565 in that case, we provide default implementations ourselves.
14567 Define a private field of the type of the event. This is done by the CSC compiler
14568 and we should be doing it too ;-)
14570 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
14571 More methods we use in code we generate.
14573 (multicast_delegate_type, delegate_type): Two separate types since the distinction
14576 (InitCoreTypes): Update accordingly for the above.
14578 * class.cs (Event.Emit): Generate code for default accessors that we provide
14580 (EmitDefaultMethod): Do the job in the above.
14582 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
14585 2001-12-20 Miguel de Icaza <miguel@ximian.com>
14587 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
14588 builders even if we were missing one.
14590 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
14591 pass the Basename as our class name instead of the Name. The
14592 basename will be correctly composed for us.
14594 * parameter.cs (Paramters): Now takes a Location argument.
14596 * decl.cs (DeclSpace.LookupType): Removed convenience function and
14597 make all the code call directly LookupType in RootContext and take
14598 this chance to pass the Location information everywhere.
14600 * Everywhere: pass Location information.
14602 2001-12-19 Miguel de Icaza <miguel@ximian.com>
14604 * class.cs (Constructor.Define): Updated way of detecting the
14605 length of the parameters.
14607 (TypeContainer.DefineType): Use basename as the type name for
14610 (TypeContainer.Define): Do not recursively define types here, as
14611 definition is taken care in order by the RootContext.
14613 * tree.cs: Keep track of namespaces in a per-file basis.
14615 * parameter.cs (Parameter.ComputeSignature): Update to use
14618 (Parameters.GetSignature): ditto.
14620 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
14621 instead of a TypeContainer.
14623 (Interface.SemanticAnalysis): Use `this' instead of our parent to
14624 resolve names. Because we need to be resolve in our context, not
14627 * driver.cs: Implement response files.
14629 * class.cs (TypeContainer.DefineType): If we are defined, do not
14630 redefine ourselves.
14632 (Event.Emit): Emit the code for add/remove handlers.
14633 (Event.Define): Save the MethodBuilders for add/remove.
14635 * typemanager.cs: Use pair here too.
14637 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
14638 DictionaryEntry requires the first argument to be non-null.
14640 (enum_declaration): Compute full name for registering the
14643 (delegate_declaration): Instead of using
14644 formal_parameter_list, use opt_formal_parameter_list as the list
14647 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
14648 (EventParsing): New property that controls whether `add' and
14649 `remove' are returned as tokens or identifiers (for events);
14651 2001-12-19 Ravi Pratap <ravi@ximian.com>
14653 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
14654 use MyEventBuilder only and let it wrap the real builder for us.
14656 (MyEventBuilder): Revamp constructor etc.
14658 Implement all operations that we perform on EventBuilder in precisely the same
14661 (FindMembers): Update to use the EventBuilder member.
14663 (Event.Emit): Update accordingly.
14665 2001-12-18 Ravi Pratap <ravi@ximian.com>
14667 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
14668 by calling the appropriate methods.
14670 (GetCustomAttributes): Make stubs as they cannot possibly do anything
14673 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
14675 2001-12-17 Ravi Pratap <ravi@ximian.com>
14677 * delegate.cs (Delegate.Populate): Check that the return type
14678 and various parameters types are indeed accessible.
14680 * class.cs (Constructor.Define): Same here.
14682 (Field.Define): Ditto.
14684 (Event.Define): Ditto.
14686 (Operator.Define): Check that the underlying Method defined itself
14687 correctly - so it's MethodBuilder should not be null.
14689 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
14690 expression happens to be null.
14692 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
14693 members but as of now we don't seem to be able to do anything really useful with it.
14695 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
14696 not the EventBuilder.
14698 2001-12-18 Miguel de Icaza <miguel@ximian.com>
14700 * cs-tokenizer.cs: Add support for defines.
14701 Add support for #if, #elif, #else, #endif
14703 (eval_var): evaluates a variable.
14704 (eval): stubbed for evaluating functions.
14706 * cs-parser.jay: Pass the defines information
14708 * driver.cs: Add --define command line option.
14710 * decl.cs: Move MemberCore here.
14712 Make it the base class for DeclSpace. This allows us to catch and
14713 report 108 and 109 for everything now.
14715 * class.cs (TypeContainer.Define): Extract all the members
14716 before populating and emit the warning 108 (new keyword required
14717 to override) instead of having each member implement this.
14719 (MemberCore.Define): New abstract method, we will be using this in
14720 the warning reporting engine in Populate.
14722 (Operator.Define): Adjust to new MemberCore protocol.
14724 * const.cs (Const): This does not derive from Expression, it is a
14725 temporary object we use to create fields, it is a MemberCore.
14727 * class.cs (Method.Define): Allow the entry point to be in a
14730 * driver.cs: Rewrite the argument handler to clean it up a bit.
14732 * rootcontext.cs: Made it just an auxiliary namespace feature by
14733 making everything static.
14735 * driver.cs: Adapt code to use RootContext type name instead of
14738 * delegate.cs: Remove RootContext argument.
14740 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
14743 * class.cs (Event.Define): The lookup can fail.
14745 * cs-tokenizer.cs: Begin implementation of pre-procesor.
14747 * expression.cs: Resolve the this instance before invoking the code.
14749 2001-12-17 Miguel de Icaza <miguel@ximian.com>
14751 * cs-parser.jay: Add a production in element_access that allows
14752 the thing to become a "type" reference. This way we can parse
14753 things like "(string [])" as a type.
14755 Note that this still does not handle the more complex rules of
14759 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
14761 * ecore.cs: (CopyNewMethods): new utility function used to
14762 assemble the list of methods from running FindMembers.
14764 (MemberLookup): Rework FindMembers so that
14766 2001-12-16 Miguel de Icaza <miguel@ximian.com>
14768 * class.cs (TypeContainer): Remove Delegates who fail to be
14771 * delegate.cs (Populate): Verify that we dont get null return
14772 values. TODO: Check for AsAccessible.
14774 * cs-parser.jay: Use basename to emit error 574 (destructor should
14775 have the same name as container class), not the full name.
14777 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
14778 possible representation.
14780 Also implements integer type suffixes U and L.
14782 2001-12-15 Miguel de Icaza <miguel@ximian.com>
14784 * expression.cs (ArrayCreation.DoResolve): We need to do the
14785 argument resolution *always*.
14787 * decl.cs: Make this hold the namespace. Hold the root context as
14789 (LookupType): Move here.
14791 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
14793 * location.cs (Row, Name): Fixed the code, it was always returning
14794 references to the first file.
14796 * interface.cs: Register properties defined through interfaces.
14798 * driver.cs: Add support for globbing on the command line
14800 * class.cs (Field): Make it derive from MemberCore as well.
14803 2001-12-15 Ravi Pratap <ravi@ximian.com>
14805 * class.cs (Event::Define): Check that the type of the event is a delegate
14806 type else flag error #66.
14808 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
14811 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
14812 values of EntryPoint, CharSet etc etc.
14814 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
14816 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
14817 be null and we should ignore this. I am not sure if this is really clean. Apparently,
14818 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
14819 which needs this to do its work.
14821 * ../errors/cs0066.cs : Add.
14823 2001-12-14 Miguel de Icaza <miguel@ximian.com>
14825 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
14828 * class.cs: (MethodSignature.MethodSignature): Removed hack that
14829 clears out the parameters field.
14830 (MemberSignatureCompare): Cleanup
14832 (MemberCore): New base class used to share code between MethodCore
14835 (RegisterRequiredImplementations) BindingFlags.Public requires
14836 either BindingFlags.Instace or Static. Use instance here.
14838 (Property): Refactored code to cope better with the full spec.
14840 * parameter.cs (GetParameterInfo): Return an empty array instead
14843 * class.cs (Property): Abstract or extern properties have no bodies.
14845 * parameter.cs (GetParameterInfo): return a zero-sized array.
14847 * class.cs (TypeContainer.MethodModifiersValid): Move all the
14848 method modifier validation to the typecontainer so we can reuse
14849 this on properties.
14851 (MethodCore.ParameterTypes): return an empty sized array of types.
14853 (Property.Define): Test property modifier validity.
14855 Add tests for sealed/override too.
14857 (Method.Emit): abstract or extern methods have no bodies.
14859 2001-12-14 Ravi Pratap <ravi@ximian.com>
14861 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
14864 (Method::Define, ::Emit): Modify accordingly.
14866 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
14868 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
14870 * makefile: Pass in /unsafe.
14872 2001-12-13 Miguel de Icaza <miguel@ximian.com>
14874 * class.cs (MakeKey): Kill routine.
14876 * class.cs (TypeContainer.Define): Correctly define explicit
14877 method implementations (they require the full interface name plus
14880 * typemanager.cs: Deply the PtrHashtable here and stop using the
14881 lame keys. Things work so much better.
14883 This of course broke everyone who depended on `RegisterMethod' to
14884 do the `test for existance' test. This has to be done elsewhere.
14886 * support.cs (PtrHashtable): A hashtable that avoid comparing with
14887 the object stupid Equals method (because, that like fails all over
14888 the place). We still do not use it.
14890 * class.cs (TypeContainer.SetRequiredInterface,
14891 TypeContainer.RequireMethods): Killed these two routines and moved
14892 all the functionality to RegisterRequiredImplementations.
14894 (TypeContainer.RegisterRequiredImplementations): This routine now
14895 registers all the implementations required in an array for the
14896 interfaces and abstract methods. We use an array of structures
14897 which can be computed ahead of time to reduce memory usage and we
14898 also assume that lookups are cheap as most classes will not
14899 implement too many interfaces.
14901 We also avoid creating too many MethodSignatures.
14903 (TypeContainer.IsInterfaceMethod): Update and optionally does not
14904 clear the "pending" bit if we find that there are problems with
14907 (TypeContainer.VerifyPendingMethods): Update to report errors of
14908 methods that look like implementations but are not.
14910 (TypeContainer.Define): Add support for explicit interface method
14913 2001-12-12 Miguel de Icaza <miguel@ximian.com>
14915 * typemanager.cs: Keep track of the parameters here instead of
14916 being a feature of the TypeContainer.
14918 * class.cs: Drop the registration of parameters here, as
14919 InterfaceMethods are also interface declarations.
14921 * delegate.cs: Register methods with the TypeManager not only with
14922 the TypeContainer. This code was buggy.
14924 * interface.cs: Full registation here.
14926 2001-12-11 Miguel de Icaza <miguel@ximian.com>
14928 * expression.cs: Remove reducer for binary expressions, it can not
14931 * const.cs: Put here the code that used to go into constant.cs
14933 * constant.cs: Put here the code for constants, this is a new base
14934 class for Literals.
14936 * literal.cs: Make Literal derive from Constant.
14938 2001-12-09 Miguel de Icaza <miguel@ximian.com>
14940 * statement.cs (Return.Emit): Report error 157 if the user
14941 attempts to return from a finally block.
14943 (Return.Emit): Instead of emitting a return, jump to the end of
14946 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
14947 LocalBuilder to store the result of the function. ReturnLabel is
14948 the target where we jump.
14951 2001-12-09 Radek Doulik <rodo@ximian.com>
14953 * cs-parser.jay: remember alias in current namespace
14955 * ecore.cs (SimpleName::DoResolve): use aliases for types or
14958 * class.cs (LookupAlias): lookup alias in my_namespace
14960 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
14962 (LookupAlias): lookup alias in this and if needed in parent
14965 2001-12-08 Miguel de Icaza <miguel@ximian.com>
14969 * rootcontext.cs: (ModuleBuilder) Made static, first step into
14970 making things static. I need this to avoid passing the
14971 TypeContainer when calling ParameterType.
14973 * support.cs (InternalParameters.ParameterType): Remove ugly hack
14974 that did string manipulation to compute the type and then call
14975 GetType. Use Parameter.ParameterType instead.
14977 * cs-tokenizer.cs: Consume the suffix for floating values.
14979 * expression.cs (ParameterReference): figure out whether this is a
14980 reference parameter or not. Kill an extra variable by computing
14981 the arg_idx during emission.
14983 * parameter.cs (Parameters.GetParameterInfo): New overloaded
14984 function that returns whether a parameter is an out/ref value or not.
14986 (Parameter.ParameterType): The type of the parameter (base,
14987 without ref/out applied).
14989 (Parameter.Resolve): Perform resolution here.
14990 (Parameter.ExternalType): The full type (with ref/out applied).
14992 * statement.cs (Using.Emit, Using.EmitExpression): Implement
14993 support for expressions on the using statement.
14995 2001-12-07 Miguel de Icaza <miguel@ximian.com>
14997 * statement.cs (Using.EmitLocalVariableDecls): Split the
14998 localvariable handling of the using statement.
15000 (Block.EmitMeta): Keep track of variable count across blocks. We
15001 were reusing slots on separate branches of blocks.
15003 (Try.Emit): Emit the general code block, we were not emitting it.
15005 Check the type of the declaration to be an IDisposable or
15006 something that can be implicity converted to it.
15008 Emit conversions if required.
15010 * ecore.cs (EmptyExpression): New utility class.
15011 (Expression.ImplicitConversionExists): New utility function.
15013 2001-12-06 Miguel de Icaza <miguel@ximian.com>
15015 * statement.cs (Using): Implement.
15017 * expression.cs (LocalVariableReference): Support read only variables.
15019 * statement.cs: Remove the explicit emit for the Leave opcode.
15020 (VariableInfo): Add a readonly field.
15022 2001-12-05 Miguel de Icaza <miguel@ximian.com>
15024 * ecore.cs (ConvCast): new class used to encapsulate the various
15025 explicit integer conversions that works in both checked and
15026 unchecked contexts.
15028 (Expression.ConvertNumericExplicit): Use new ConvCast class to
15029 properly generate the overflow opcodes.
15031 2001-12-04 Miguel de Icaza <miguel@ximian.com>
15033 * statement.cs: The correct type for the EmptyExpression is the
15034 element_type, not the variable type. Ravi pointed this out.
15036 2001-12-04 Ravi Pratap <ravi@ximian.com>
15038 * class.cs (Method::Define): Handle PInvoke methods specially
15039 by using DefinePInvokeMethod instead of the usual one.
15041 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
15042 above to do the task of extracting information and defining the method.
15044 2001-12-04 Ravi Pratap <ravi@ximian.com>
15046 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
15047 of the condition for string type.
15049 (Emit): Move that here.
15051 (ArrayCreation::CheckIndices): Keep string literals in their expression
15054 (EmitDynamicInitializers): Handle strings appropriately.
15056 2001-12-04 Miguel de Icaza <miguel@ximian.com>
15058 * codegen.cs (EmitContext): Replace multiple variables with a
15059 single pointer to the current Switch statement.
15061 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
15064 2001-12-03 Miguel de Icaza <miguel@ximian.com>
15068 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
15071 (Foreach.Emit): Foreach on arrays was not setting
15072 up the loop variables (for break/continue).
15074 (GotoCase): Semi-implented.
15076 2001-12-03 Ravi Pratap <ravi@ximian.com>
15078 * attribute.cs (CheckAttribute): Handle system attributes by using
15079 Attribute.GetAttributes to examine information we need.
15081 (GetValidPlaces): Same here.
15083 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
15085 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
15087 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
15089 (Method::Define): Set appropriate flags if we have a DllImport attribute.
15091 (Method::Emit): Handle the case when we are a PInvoke method.
15093 2001-12-03 Miguel de Icaza <miguel@ximian.com>
15095 * expression.cs: Use ResolveWithSimpleName on compound names.
15097 2001-12-02 Ravi Pratap <ravi@ximian.com>
15099 * constant.cs (EmitConstant): Make sure we resolve the associated expression
15100 before trying to reduce it.
15102 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
15104 * constant.cs (LookupConstantValue): Implement.
15106 (EmitConstant): Use the above in emitting the constant.
15108 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
15109 that are user-defined by doing a LookupConstantValue on them.
15111 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
15114 2001-11-29 Miguel de Icaza <miguel@ximian.com>
15116 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
15118 (BaseAccess.DoResolve): Implement.
15120 (MemberAccess.DoResolve): Split this routine into a
15121 ResolveMemberAccess routine that can be used independently
15123 2001-11-28 Miguel de Icaza <miguel@ximian.com>
15125 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
15126 As that share bits of the implementation. Is returns a boolean,
15127 while As returns the Type that is being probed.
15129 2001-12-01 Ravi Pratap <ravi@ximian.com>
15131 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
15132 instead of a Literal - much easier.
15134 (EnumInTransit): Remove - utterly useless :-)
15136 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
15138 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
15140 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
15141 chain when we have no associated expression.
15143 2001-11-30 Ravi Pratap <ravi@ximian.com>
15145 * constant.cs (Define): Use Location while reporting the errror.
15147 Also emit a warning when 'new' is used and there is no inherited
15150 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
15153 (LookupEnumValue): Implement to lookup an enum member's value and define it
15156 (Populate): Re-write accordingly to use the above routine.
15158 2001-11-27 Miguel de Icaza <miguel@ximian.com>
15160 * expression.cs (This): Fix prototype for DoResolveLValue to
15161 override the base class DoResolveLValue.
15163 * cs-parser.cs: Report errors cs574 and cs575 (destructor
15166 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
15167 (we need to load the address of the field here). This fixes
15170 (FieldExpr.DoResolveLValue): Call the DoResolve
15171 function to initialize the Instance expression.
15173 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
15174 correctly the GetEnumerator operation on a value type.
15176 * cs-parser.jay: Add more simple parsing error catches.
15178 * statement.cs (Switch): Add support for string switches.
15179 Handle null specially.
15181 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
15183 2001-11-28 Ravi Pratap <ravi@ximian.com>
15185 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
15187 (declare_local_constant): New helper function.
15189 * statement.cs (AddConstant): Keep a separate record of constants
15191 (IsConstant): Implement to determine if a variable is a constant.
15193 (GetConstantExpression): Implement.
15195 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
15197 * statement.cs (IsVariableDefined): Re-write.
15199 2001-11-27 Ravi Pratap <ravi@ximian.com>
15201 * class.cs (TypeContainer::FindMembers): Look for constants
15202 in the case when we are looking for MemberTypes.Field
15204 * expression.cs (MemberAccess::DoResolve): Check that in the
15205 case we are a FieldExpr and a Literal, we are not being accessed
15206 by an instance reference.
15208 * cs-parser.jay (local_constant_declaration): Implement.
15210 (declaration_statement): Implement for constant declarations.
15212 2001-11-26 Miguel de Icaza <miguel@ximian.com>
15214 * statement.cs (Switch): Catch double defaults.
15216 (Switch): More work on the switch() statement
15217 implementation. It works for integral values now, need to finish
15221 2001-11-24 Miguel de Icaza <miguel@ximian.com>
15223 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
15224 integer literals into other integer literals. To be used by
15227 2001-11-24 Ravi Pratap <ravi@ximian.com>
15229 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
15232 (EmitDynamicInitializers): Cope with the above since we extract data
15233 directly from ArrayData now.
15235 (ExpectInitializers): Keep track of whether initializers are mandatory
15238 (Bounds): Make it a hashtable to prevent the same dimension being
15239 recorded for every element in that dimension.
15241 (EmitDynamicInitializers): Fix bug which prevented the Set array method
15244 Also fix bug which was causing the indices to be emitted in the reverse
15247 2001-11-24 Miguel de Icaza <miguel@ximian.com>
15249 * expression.cs (ArrayCreation): Implement the bits that Ravi left
15250 unfinished. They do not work, because the underlying code is
15253 2001-11-22 Miguel de Icaza <miguel@ximian.com>
15255 * cs-parser.jay: Remove bogus fixme.
15257 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
15258 on Switch statement.
15260 2001-11-23 Ravi Pratap <ravi@ximian.com>
15262 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
15265 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
15266 parameter. Apparently, any expression is allowed.
15268 (ValidateInitializers): Update accordingly.
15270 (CheckIndices): Fix some tricky bugs thanks to recursion.
15272 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
15273 I was being completely brain-dead.
15275 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
15276 and re-write acordingly.
15278 (DelegateInvocation): Re-write accordingly.
15280 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
15282 (MakeByteBlob): Handle types more correctly.
15284 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
15285 initialization from expressions but it is incomplete because I am a complete
15288 2001-11-22 Miguel de Icaza <miguel@ximian.com>
15290 * statement.cs (If.Emit): Fix a bug that generated incorrect code
15291 on If. Basically, we have to return `true' (ie, we do return to
15292 our caller) only if both branches of the if return.
15294 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
15295 short-circuit operators, handle them as short circuit operators.
15297 (Cast.DoResolve): Resolve type.
15298 (Cast.Cast): Take an expression as the target type.
15300 * cs-parser.jay (cast_expression): Remove old hack that only
15301 allowed a limited set of types to be handled. Now we take a
15302 unary_expression and we resolve to a type during semantic
15305 Use the grammar productions from Rhys to handle casts (this is
15306 not complete like Rhys syntax yet, we fail to handle that corner
15307 case that C# has regarding (-x), but we will get there.
15309 2001-11-22 Ravi Pratap <ravi@ximian.com>
15311 * class.cs (EmitFieldInitializer): Take care of the case when we have a
15312 field which is an array type.
15314 * cs-parser.jay (declare_local_variables): Support array initialization too.
15316 * typemanager.cs (MakeKey): Implement.
15318 (everywhere): Use the above appropriately.
15320 * cs-parser.jay (for_statement): Update for array initialization while
15321 declaring variables.
15323 * ecore.cs : The error message was correct, it's the variable's names that
15324 were misleading ;-) Make the code more readable.
15326 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
15327 the correct type etc.
15329 (ConvertExplicit): Handle Enum types by examining the underlying type.
15331 2001-11-21 Ravi Pratap <ravi@ximian.com>
15333 * parameter.cs (GetCallingConvention): Always return
15334 CallingConventions.Standard for now.
15336 2001-11-22 Miguel de Icaza <miguel@ximian.com>
15338 * expression.cs (Binary.ResolveOperator): Update the values of `l'
15339 and `r' after calling DoNumericPromotions.
15341 * ecore.cs: Fix error message (the types were in the wrong order).
15343 * statement.cs (Foreach.ProbeCollectionType): Need to pass
15344 BindingFlags.Instance as well
15346 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
15347 implicit int literal conversion in an empty cast so that we
15348 propagate the right type upstream.
15350 (UnboxCast): new class used to unbox value types.
15351 (Expression.ConvertExplicit): Add explicit type conversions done
15354 (Expression.ImplicitNumericConversion): Oops, forgot to test for
15355 the target type before applying the implicit LongLiterals to ULong
15358 2001-11-21 Miguel de Icaza <miguel@ximian.com>
15360 * cs-parser.jay (for_statement): Reworked the way For works: now
15361 we declare manually any variables that are introduced in
15362 for_initializer to solve the problem of having out-of-band code
15363 emition (that is what got for broken).
15365 (declaration_statement): Perform the actual variable declaration
15366 that used to be done in local_variable_declaration here.
15368 (local_variable_declaration): Do not declare anything, just pass
15369 the information on a DictionaryEntry
15371 2001-11-20 Ravi Pratap <ravi@ximian.com>
15373 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
15374 re-write of the logic to now make it recursive.
15376 (UpdateIndices): Re-write accordingly.
15378 Store element data in a separate ArrayData list in the above methods.
15380 (MakeByteBlob): Implement to dump the array data into a byte array.
15382 2001-11-19 Ravi Pratap <ravi@ximian.com>
15384 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
15387 * constant.cs (Define): Implement.
15389 (EmitConstant): Re-write fully.
15391 Pass in location info.
15393 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
15396 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
15397 DictionaryEntry since we need location info too.
15399 (constant_declaration): Update accordingly.
15401 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
15402 code into another method : UpdateIndices.
15404 2001-11-18 Ravi Pratap <ravi@ximian.com>
15406 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
15407 some type checking etc.
15409 2001-11-17 Ravi Pratap <ravi@ximian.com>
15411 * expression.cs (ArrayCreation::ValidateInitializers): Implement
15412 bits to provide dimension info if the user skips doing that.
15414 Update second constructor to store the rank correctly.
15416 2001-11-16 Ravi Pratap <ravi@ximian.com>
15418 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
15419 and try to implement.
15421 * ../errors/cs0150.cs : Add.
15423 * ../errors/cs0178.cs : Add.
15425 2001-11-16 Miguel de Icaza <miguel@ximian.com>
15427 * statement.cs: Implement foreach on multi-dimensional arrays.
15429 * parameter.cs (Parameters.GetParameterByName): Also lookup the
15430 name of the params argument.
15432 * expression.cs: Use EmitStoreOpcode to get the right opcode while
15433 initializing the array.
15435 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
15436 we can use this elsewhere.
15438 * statement.cs: Finish implementation of foreach for single
15441 * cs-parser.jay: Use an out-of-band stack to pass information
15442 around, I wonder why I need this.
15444 foreach_block: Make the new foreach_block the current_block.
15446 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
15447 function used to return a static Parameters structure. Used for
15448 empty parameters, as those are created very frequently.
15450 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
15452 2001-11-15 Ravi Pratap <ravi@ximian.com>
15454 * interface.cs : Default modifier is private, not public. The
15455 make verify test passes again.
15457 2001-11-15 Ravi Pratap <ravi@ximian.com>
15459 * support.cs (ReflectionParameters): Fix logic to determine
15460 whether the last parameter is a params one. Test 9 passes again.
15462 * delegate.cs (Populate): Register the builders we define with
15463 RegisterParameterForBuilder. Test 19 passes again.
15465 * cs-parser.jay (property_declaration): Reference $6 instead
15466 of $$ to get at the location.
15468 (indexer_declaration): Similar stuff.
15470 (attribute): Ditto.
15472 * class.cs (Property): Register parameters for the Get and Set methods
15473 if they exist. Test 23 passes again.
15475 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
15476 call to EmitArguments as we are sure there aren't any params arguments.
15477 Test 32 passes again.
15479 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
15480 IndexOutOfRangeException.
15482 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
15483 Test 33 now passes again.
15485 2001-11-15 Miguel de Icaza <miguel@ximian.com>
15487 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
15488 broke a bunch of things. Will have to come up with a better way
15489 of tracking locations.
15491 * statement.cs: Implemented foreach for single dimension arrays.
15493 2001-11-09 Miguel de Icaza <miguel@ximian.com>
15495 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
15496 an error. This removes the lookup from the critical path.
15498 * cs-parser.jay: Removed use of temporary_loc, which is completely
15501 2001-11-14 Miguel de Icaza <miguel@ximian.com>
15503 * support.cs (ReflectionParameters.ParameterModifier): Report
15504 whether the argument is a PARAMS argument or not.
15506 * class.cs: Set the attribute `ParamArrayAttribute' on the
15507 parameter argument.
15509 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
15510 and cons_param_array_attribute (ConstructorInfo for
15511 ParamArrayAttribute).,
15513 * codegen.cs: Emit the return using the `Return' statement, that
15514 way we can report the error correctly for missing return values.
15516 * class.cs (Method.Emit): Clean up.
15518 * expression.cs (Argument.Resolve): Take another argument: the
15519 location where this argument is used. Notice that this is not
15520 part of the "Argument" class as to reduce the size of the
15521 structure (we know the approximate location anyways).
15523 Test if the argument is a variable-reference, if not, then
15524 complain with a 206.
15526 (Argument.Emit): Emit addresses of variables.
15528 (Argument.FullDesc): Simplify.
15530 (Invocation.DoResolve): Update for Argument.Resolve.
15532 (ElementAccess.DoResolve): ditto.
15534 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
15535 method should be virtual, as this method is always virtual.
15537 (NewDelegate.DoResolve): Update for Argument.Resolve.
15539 * class.cs (ConstructorInitializer.DoResolve): ditto.
15541 * attribute.cs (Attribute.Resolve): ditto.
15543 2001-11-13 Miguel de Icaza <miguel@ximian.com>
15545 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
15547 * expression.cs (ParameterReference): Drop IStackStorage and implement
15548 IAssignMethod instead.
15550 (LocalVariableReference): ditto.
15552 * ecore.cs (FieldExpr): Drop IStackStorage and implement
15553 IAssignMethod instead.
15555 2001-11-13 Miguel de Icaza <miguel@ximian.com>
15557 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
15558 enumerations that are used in heavily used structures derive from
15559 byte in a laughable and pathetic attempt to reduce memory usage.
15560 This is the kind of pre-optimzations that you should not do at
15561 home without adult supervision.
15563 * expression.cs (UnaryMutator): New class, used to handle ++ and
15564 -- separatedly from the other unary operators. Cleans up the
15565 code, and kills the ExpressionStatement dependency in Unary.
15567 (Unary): Removed `method' and `Arguments' from this class, making
15568 it smaller, and moving it all to SimpleCall, so I can reuse this
15569 code in other locations and avoid creating a lot of transient data
15570 strucutres when not required.
15572 * cs-parser.jay: Adjust for new changes.
15574 2001-11-11 Miguel de Icaza <miguel@ximian.com>
15576 * enum.cs (Enum.Populate): If there is a failure during
15579 * cs-parser.jay (opt_enum_base): we used to catch type errors
15580 here, but this is really incorrect. The type error should be
15581 catched during semantic analysis.
15583 2001-12-11 Ravi Pratap <ravi@ximian.com>
15585 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
15586 current_local_parameters as expected since I, in my stupidity, had forgotten
15589 * attribute.cs (GetValidPlaces): Fix stupid bug.
15591 * class.cs (Method::Emit): Perform check on applicability of attributes.
15593 (Constructor::Emit): Ditto.
15595 (Field::Emit): Ditto.
15597 (Field.Location): Store location information.
15599 (Property, Event, Indexer, Operator): Ditto.
15601 * cs-parser.jay (field_declaration): Pass in location for each field.
15603 * ../errors/cs0592.cs : Add.
15605 2001-11-12 Ravi Pratap <ravi@ximian.com>
15607 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
15609 (InitCoreTypes): Update accordingly.
15611 (RegisterAttrType, LookupAttr): Implement.
15613 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
15614 info about the same.
15616 (Resolve): Update to populate the above as necessary.
15618 (Error592): Helper.
15620 (GetValidPlaces): Helper to the above.
15622 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
15624 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
15626 2001-11-12 Ravi Pratap <ravi@ximian.com>
15628 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
15630 * ../errors/cs0617.cs : Add.
15632 2001-11-11 Ravi Pratap <ravi@ximian.com>
15634 * enum.cs (Emit): Rename to Populate to be more consistent with what
15635 we expect it to do and when exactly it is called.
15637 * class.cs, rootcontext.cs : Update accordingly.
15639 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
15640 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
15642 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
15644 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
15645 of a fieldinfo using the above, when dealing with a FieldBuilder.
15647 2001-11-10 Ravi Pratap <ravi@ximian.com>
15649 * ../errors/cs0031.cs : Add.
15651 * ../errors/cs1008.cs : Add.
15653 * ../errrors/cs0543.cs : Add.
15655 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
15658 (FindMembers): Implement.
15660 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
15661 enums and delegates too.
15663 (enum_types): Rename to builder_to_enum.
15665 (delegate_types): Rename to builder_to_delegate.
15667 * delegate.cs (FindMembers): Implement.
15669 2001-11-09 Ravi Pratap <ravi@ximian.com>
15671 * typemanager.cs (IsEnumType): Implement.
15673 * enum.cs (Emit): Re-write parts to account for the underlying type
15674 better and perform checking etc.
15676 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
15677 of the underlying type.
15679 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
15682 * enum.cs (error31): Helper to report error #31.
15684 * cs-parser.jay (enum_declaration): Store location of each member too.
15686 * enum.cs (member_to_location): New hashtable.
15688 (AddEnumMember): Update location hashtable.
15690 (Emit): Use the location of each member while reporting errors.
15692 2001-11-09 Miguel de Icaza <miguel@ximian.com>
15694 * cs-parser.jay: A for_initializer if is a
15695 local_variable_declaration really ammount to have an implicit
15696 block with the variable declaration and no initializer for for.
15698 * statement.cs (For.Emit): Cope with null initializers.
15700 This fixes the infinite loop on for initializers.
15702 2001-11-08 Miguel de Icaza <miguel@ximian.com>
15704 * enum.cs: More cleanup.
15706 * ecore.cs: Remove dead code.
15708 * class.cs (Property.Emit): More simplification.
15709 (Event.Emit): ditto.
15711 Reworked to have less levels of indentation.
15713 2001-11-08 Ravi Pratap <ravi@ximian.com>
15715 * class.cs (Property): Emit attributes.
15725 * enum.cs (Emit): Ditto.
15727 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
15730 * class.cs (Field, Event, etc.): Move attribute generation into the
15731 Emit method everywhere.
15733 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
15734 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
15735 as we had no way of defining nested enums !
15737 * rootcontext.cs : Adjust code accordingly.
15739 * typemanager.cs (AddEnumType): To keep track of enum types separately.
15741 2001-11-07 Ravi Pratap <ravi@ximian.com>
15743 * expression.cs (EvalConstantExpression): Move into ecore.cs
15745 * enum.cs (Enum): Rename some members and make them public and readonly
15746 according to our convention.
15748 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
15751 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
15753 (Enum::Emit): Write a simple version for now which doesn't try to compute
15754 expressions. I shall modify this to be more robust in just a while.
15756 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
15758 (TypeContainer::CloseType): Create the Enum types too.
15760 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
15762 * expression.cs (EvalConstantExpression): Get rid of completely.
15764 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
15765 user-defined values and other cases.
15767 (IsValidEnumLiteral): Helper function.
15769 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
15770 out there in the case we had a literal FieldExpr.
15772 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
15774 (Literalize): Revamp a bit to take two arguments.
15776 (EnumLiteral): New class which derives from Literal to wrap enum literals.
15778 2001-11-06 Ravi Pratap <ravi@ximian.com>
15780 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
15782 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
15784 (Resolve): Use the above to ensure we have proper initializers.
15786 2001-11-05 Ravi Pratap <ravi@ximian.com>
15788 * expression.cs (Expression::EvalConstantExpression): New method to
15789 evaluate constant expressions.
15791 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
15793 2001-11-07 Miguel de Icaza <miguel@ximian.com>
15795 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
15798 (Binary.ResolveOperator): Handle operator != (object a, object b)
15799 and operator == (object a, object b);
15801 (Binary.DoNumericPromotions): Indicate whether the numeric
15802 promotion was possible.
15804 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
15807 Made the ArrayAccess implement interface IAssignMethod instead of
15808 IStackStore as the order in which arguments are passed reflects
15811 * assign.cs: Instead of using expr.ExprClass to select the way of
15812 assinging, probe for the IStackStore/IAssignMethod interfaces.
15814 * typemanager.cs: Load InitializeArray definition.
15816 * rootcontext.cs (RootContext.MakeStaticData): Used to define
15817 static data that can be used to initialize arrays.
15819 2001-11-05 Miguel de Icaza <miguel@ximian.com>
15821 * expression.cs: Handle operator== and operator!= for booleans.
15823 (Conditioal.Reduce): Implement reducer for the ?: operator.
15825 (Conditional.Resolve): Implement dead code elimination.
15827 (Binary.Resolve): Catch string literals and return a new
15828 concatenated string.
15830 (Unary.Reduce): Implement reduction of unary expressions.
15832 * ecore.cs: Split out the expression core handling here.
15834 (Expression.Reduce): New method used to perform constant folding
15835 and CSE. This is needed to support constant-expressions.
15837 * statement.cs (Statement.EmitBoolExpression): Pass true and false
15838 targets, and optimize for !x.
15840 2001-11-04 Ravi Pratap <ravi@ximian.com>
15842 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
15843 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
15844 set custom atttributes.
15846 * literal.cs (Literal::GetValue): New abstract method to return the actual
15847 value of the literal, cast as an object.
15849 (*Literal): Implement GetValue method.
15851 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
15852 expressions to the arraylist but objects of type Argument.
15854 * class.cs (TypeContainer::Emit): Emit our attributes too.
15856 (Method::Emit, Constructor::Emit): Ditto.
15858 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
15859 to be ignoring earlier.
15861 2001-11-03 Ravi Pratap <ravi@ximian.com>
15863 * attribute.cs (AttributeSection::Define): Implement to do the business
15864 of constructing a CustomAttributeBuilder.
15866 (Attribute): New trivial class. Increases readability of code.
15868 * cs-parser.jay : Update accordingly.
15870 (positional_argument_list, named_argument_list, named_argument): New rules
15872 (attribute_arguments): Use the above so that we are more correct.
15874 2001-11-02 Ravi Pratap <ravi@ximian.com>
15876 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
15877 to perform all checks for a method with a params parameter.
15879 (Invocation::OverloadResolve): Update to use the above method and therefore
15880 cope correctly with params method invocations.
15882 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
15885 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
15886 constructors in our parent too because we can't afford to miss out on
15889 * attribute.cs (AttributeSection): New name for the class Attribute
15891 Other trivial changes to improve readability.
15893 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
15894 use the new class names.
15896 2001-11-01 Ravi Pratap <ravi@ximian.com>
15898 * class.cs (Method::Define): Complete definition for params types too
15900 (Indexer::Define): Ditto.
15902 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
15903 Cope everywhere with a request for info about the array parameter.
15905 2001-11-01 Ravi Pratap <ravi@ximian.com>
15907 * tree.cs (RecordNamespace): Fix up to check for the correct key.
15909 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
15910 local_variable_type to extract the string corresponding to the type.
15912 (local_variable_type): Fixup the action to use the new helper method.
15914 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
15917 * expression.cs : Clean out code which uses the above.
15919 2001-10-31 Ravi Pratap <ravi@ximian.com>
15921 * typemanager.cs (RegisterMethod): Check if we already have an existing key
15922 and bale out if necessary by returning a false.
15924 (RegisterProperty): Ditto.
15926 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
15927 and print out appropriate error messages.
15929 * interface.cs (everywhere): Ditto.
15931 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
15932 location to constructor.
15934 * class.cs (Property, Event, Indexer): Update accordingly.
15936 * ../errors/cs111.cs : Added.
15938 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
15939 of a method, as laid down by the spec.
15941 (Invocation::OverloadResolve): Use the above method.
15943 2001-10-31 Ravi Pratap <ravi@ximian.com>
15945 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
15946 now take a TypeContainer and a Parameters object.
15948 (ParameterData): Modify return type of ParameterModifier method to be
15949 Parameter.Modifier and not a string.
15951 (ReflectionParameters, InternalParameters): Update accordingly.
15953 * expression.cs (Argument::GetParameterModifier): Same here.
15955 * support.cs (InternalParameters::ParameterType): Find a better way of determining
15956 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
15957 symbol in it at all so maybe this is only for now.
15959 2001-10-30 Ravi Pratap <ravi@ximian.com>
15961 * support.cs (InternalParameters): Constructor now takes an extra argument
15962 which is the actual Parameters class.
15964 (ParameterDesc): Update to provide info on ref/out modifiers.
15966 * class.cs (everywhere): Update call to InternalParameters to pass in
15967 the second argument too.
15969 * support.cs (ParameterData): Add ParameterModifier, which is a method
15970 to return the modifier info [ref/out etc]
15972 (InternalParameters, ReflectionParameters): Implement the above.
15974 * expression.cs (Argument::ParameterModifier): Similar function to return
15975 info about the argument's modifiers.
15977 (Invocation::OverloadResolve): Update to take into account matching modifiers
15980 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
15981 a new SetFormalParameters object which we pass to InternalParameters.
15983 2001-10-30 Ravi Pratap <ravi@ximian.com>
15985 * expression.cs (NewArray): Merge into the ArrayCreation class.
15987 2001-10-29 Ravi Pratap <ravi@ximian.com>
15989 * expression.cs (NewArray): Merge classes NewBuiltinArray and
15990 NewUserdefinedArray into one as there wasn't much of a use in having
15993 * expression.cs (Argument): Change field's name to ArgType from Type.
15995 (Type): New readonly property which returns the proper type, taking into
15996 account ref/out modifiers.
15998 (everywhere): Adjust code accordingly for the above.
16000 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
16001 whether we are emitting for a ref or out parameter.
16003 * expression.cs (Argument::Emit): Use the above field to set the state.
16005 (LocalVariableReference::Emit): Update to honour the flag and emit the
16008 * parameter.cs (Attributes): Set the correct flags for ref parameters.
16010 * expression.cs (Argument::FullDesc): New function to provide a full desc.
16012 * support.cs (ParameterData): Add method ParameterDesc to the interface.
16014 (ReflectionParameters, InternalParameters): Implement the above method.
16016 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
16019 (Invocation::FullMethodDesc): Ditto.
16021 2001-10-29 Miguel de Icaza <miguel@ximian.com>
16023 * cs-parser.jay: Add extra production for the second form of array
16026 * expression.cs (ArrayCreation): Update to reflect the above
16029 * Small changes to prepare for Array initialization.
16031 2001-10-28 Miguel de Icaza <miguel@ximian.com>
16033 * typemanager.cs (ImplementsInterface): interface might be null;
16034 Deal with this problem;
16036 Also, we do store negative hits on the cache (null values), so use
16037 this instead of calling t.GetInterfaces on the type everytime.
16039 2001-10-28 Ravi Pratap <ravi@ximian.com>
16041 * typemanager.cs (IsBuiltinType): New method to help determine the same.
16043 * expression.cs (New::DoResolve): Get rid of array creation code and instead
16044 split functionality out into different classes.
16046 (New::FormArrayType): Move into NewBuiltinArray.
16048 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
16051 (NewBuiltinArray): New class to handle creation of built-in arrays.
16053 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
16054 account creation of one-dimensional arrays.
16056 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
16058 (NewUserdefinedArray::DoResolve): Implement.
16060 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
16062 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
16063 we maintain inside the TypeManager. This is necessary to perform lookups on the
16066 (LookupType): Update to perform GetType on the module builders too.
16068 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
16070 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
16072 2001-10-23 Ravi Pratap <ravi@ximian.com>
16074 * expression.cs (New::DoResolve): Implement guts of array creation.
16076 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
16078 2001-10-27 Miguel de Icaza <miguel@ximian.com>
16080 * expression.cs: Fix bug I introduced lsat night that broke
16083 (Expression.Resolve): Report a 246 error (can not resolve name)
16084 if we find a SimpleName in the stream.
16086 (Expression.ResolveLValue): Ditto.
16088 (Expression.ResolveWithSimpleName): This function is a variant of
16089 ResolveName, this one allows SimpleNames to be returned without a
16090 warning. The only consumer of SimpleNames is MemberAccess
16092 2001-10-26 Miguel de Icaza <miguel@ximian.com>
16094 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
16095 might arrive here. I have my doubts that this is correct.
16097 * statement.cs (Lock): Implement lock statement.
16099 * cs-parser.jay: Small fixes to support `lock' and `using'
16101 * cs-tokenizer.cs: Remove extra space
16103 * driver.cs: New flag --checked, allows to turn on integer math
16106 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
16107 Threading.Monitor.Exit
16109 2001-10-23 Miguel de Icaza <miguel@ximian.com>
16111 * expression.cs (IndexerAccess::DoResolveLValue): Set the
16112 Expression Class to be IndexerAccess.
16114 Notice that Indexer::DoResolve sets the eclass to Value.
16116 2001-10-22 Miguel de Icaza <miguel@ximian.com>
16118 * class.cs (TypeContainer::Emit): Emit code for indexers.
16120 * assign.cs (IAssignMethod): New interface implemented by Indexers
16121 and Properties for handling assignment.
16123 (Assign::Emit): Simplify and reuse code.
16125 * expression.cs (IndexerAccess, PropertyExpr): Implement
16126 IAssignMethod, clean up old code.
16128 2001-10-22 Ravi Pratap <ravi@ximian.com>
16130 * typemanager.cs (ImplementsInterface): New method to determine if a type
16131 implements a given interface. Provides a nice cache too.
16133 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
16136 (ConvertReferenceExplicit): Ditto.
16138 * delegate.cs (Delegate::Populate): Update to define the parameters on the
16139 various methods, with correct names etc.
16141 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
16142 Operator.UnaryNegation.
16144 * cs-parser.jay (operator_declarator): Be a little clever in the case where
16145 we have a unary plus or minus operator.
16147 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
16150 * everywhere : update accordingly.
16152 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
16155 * class.cs (Method::Define): For the case where we are implementing a method
16156 inherited from an interface, we need to set the MethodAttributes.Final flag too.
16157 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
16159 2001-10-21 Ravi Pratap <ravi@ximian.com>
16161 * interface.cs (FindMembers): Implement to work around S.R.E
16164 * typemanager.cs (IsInterfaceType): Implement.
16166 (FindMembers): Update to handle interface types too.
16168 * expression.cs (ImplicitReferenceConversion): Re-write bits which
16169 use IsAssignableFrom as that is not correct - it doesn't work.
16171 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
16172 and accordingly override EmitStatement.
16174 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
16175 using the correct logic :-)
16177 2001-10-19 Ravi Pratap <ravi@ximian.com>
16179 * ../errors/cs-11.cs : Add to demonstrate error -11
16181 2001-10-17 Miguel de Icaza <miguel@ximian.com>
16183 * assign.cs (Assign::Resolve): Resolve right hand side first, and
16184 then pass this as a hint to ResolveLValue.
16186 * expression.cs (FieldExpr): Add Location information
16188 (FieldExpr::LValueResolve): Report assignment to readonly
16191 (Expression::ExprClassFromMemberInfo): Pass location information.
16193 (Expression::ResolveLValue): Add new method that resolves an
16196 (Expression::DoResolveLValue): Default invocation calls
16199 (Indexers): New class used to keep track of indexers in a given
16202 (IStackStore): Renamed from LValue, as it did not really describe
16203 what this did. Also ResolveLValue is gone from this interface and
16204 now is part of Expression.
16206 (ElementAccess): Depending on the element access type
16208 * typemanager.cs: Add `indexer_name_type' as a Core type
16209 (System.Runtime.CompilerServices.IndexerNameAttribute)
16211 * statement.cs (Goto): Take a location.
16213 2001-10-18 Ravi Pratap <ravi@ximian.com>
16215 * delegate.cs (Delegate::VerifyDelegate): New method to verify
16216 if two delegates are compatible.
16218 (NewDelegate::DoResolve): Update to take care of the case when
16219 we instantiate a delegate from another delegate.
16221 * typemanager.cs (FindMembers): Don't even try to look up members
16222 of Delegate types for now.
16224 2001-10-18 Ravi Pratap <ravi@ximian.com>
16226 * delegate.cs (NewDelegate): New class to take care of delegate
16229 * expression.cs (New): Split the delegate related code out into
16230 the NewDelegate class.
16232 * delegate.cs (DelegateInvocation): New class to handle delegate
16235 * expression.cs (Invocation): Split out delegate related code into
16236 the DelegateInvocation class.
16238 2001-10-17 Ravi Pratap <ravi@ximian.com>
16240 * expression.cs (New::DoResolve): Implement delegate creation fully
16241 and according to the spec.
16243 (New::DoEmit): Update to handle delegates differently.
16245 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
16246 because of which we were printing out arguments in reverse order !
16248 * delegate.cs (VerifyMethod): Implement to check if the given method
16249 matches the delegate.
16251 (FullDelegateDesc): Implement.
16253 (VerifyApplicability): Implement.
16255 * expression.cs (Invocation::DoResolve): Update to accordingly handle
16256 delegate invocations too.
16258 (Invocation::Emit): Ditto.
16260 * ../errors/cs1593.cs : Added.
16262 * ../errors/cs1594.cs : Added.
16264 * delegate.cs (InstanceExpression, TargetMethod): New properties.
16266 2001-10-16 Ravi Pratap <ravi@ximian.com>
16268 * typemanager.cs (intptr_type): Core type for System.IntPtr
16270 (InitCoreTypes): Update for the same.
16272 (iasyncresult_type, asynccallback_type): Ditto.
16274 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
16277 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
16280 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
16281 the builders for the 4 members of a delegate type :-)
16283 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
16286 * expression.cs (New::DoResolve): Implement guts for delegate creation.
16288 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
16290 2001-10-15 Miguel de Icaza <miguel@ximian.com>
16292 * statement.cs (Break::Emit): Implement.
16293 (Continue::Emit): Implement.
16295 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
16296 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
16297 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
16298 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
16301 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
16302 properties that track the label for the current loop (begin of the
16303 loop and end of the loop).
16305 2001-10-15 Ravi Pratap <ravi@ximian.com>
16307 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
16308 use of emitting anything at all.
16310 * class.cs, rootcontext.cs : Get rid of calls to the same.
16312 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
16314 (Populate): Define the constructor correctly and set the implementation
16317 * typemanager.cs (delegate_types): New hashtable to hold delegates that
16320 (AddDelegateType): Implement.
16322 (IsDelegateType): Implement helper method.
16324 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
16326 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
16327 and accordingly handle it.
16329 * delegate.cs (Populate): Take TypeContainer argument.
16330 Implement bits to define the Invoke method. However, I still haven't figured out
16331 how to take care of the native int bit :-(
16333 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
16334 Qualify the name of the delegate, not its return type !
16336 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
16339 (StandardConversionExists): Checking for array types turns out to be recursive.
16341 (ConvertReferenceExplicit): Implement array conversion.
16343 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
16345 2001-10-12 Ravi Pratap <ravi@ximian.com>
16347 * cs-parser.jay (delegate_declaration): Store the fully qualified
16348 name as it is a type declaration.
16350 * delegate.cs (ReturnType, Name): Rename members to these. Make them
16353 (DefineDelegate): Renamed from Define. Does the same thing essentially,
16354 as TypeContainer::DefineType.
16356 (Populate): Method in which all the definition of the various methods (Invoke)
16359 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
16362 (CloseDelegate): Finally creates the delegate.
16364 * class.cs (TypeContainer::DefineType): Update to define delegates.
16365 (Populate, Emit and CloseType): Do the same thing here too.
16367 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
16368 delegates in all these operations.
16370 2001-10-14 Miguel de Icaza <miguel@ximian.com>
16372 * expression.cs: LocalTemporary: a new expression used to
16373 reference a temporary that has been created.
16375 * assign.cs: Handle PropertyAccess back here, so that we can
16376 provide the proper semantic access to properties.
16378 * expression.cs (Expression::ConvertReferenceExplicit): Implement
16379 a few more explicit conversions.
16381 * modifiers.cs: `NEW' modifier maps to HideBySig.
16383 * expression.cs (PropertyExpr): Make this into an
16384 ExpressionStatement, and support the EmitStatement code path.
16386 Perform get/set error checking, clean up the interface.
16388 * assign.cs: recognize PropertyExprs as targets, and if so, turn
16389 them into toplevel access objects.
16391 2001-10-12 Miguel de Icaza <miguel@ximian.com>
16393 * expression.cs: PropertyExpr::PropertyExpr: use work around the
16396 * typemanager.cs: Keep track here of our PropertyBuilders again to
16397 work around lameness in SRE.
16399 2001-10-11 Miguel de Icaza <miguel@ximian.com>
16401 * expression.cs (LValue::LValueResolve): New method in the
16402 interface, used to perform a second resolution pass for LValues.
16404 (This::DoResolve): Catch the use of this in static methods.
16406 (This::LValueResolve): Implement.
16408 (This::Store): Remove warning, assigning to `this' in structures
16411 (Invocation::Emit): Deal with invocation of
16412 methods on value types. We need to pass the address to structure
16413 methods rather than the object itself. (The equivalent code to
16414 emit "this" for structures leaves the entire structure on the
16415 stack instead of a pointer to it).
16417 (ParameterReference::DoResolve): Compute the real index for the
16418 argument based on whether the method takes or not a `this' pointer
16419 (ie, the method is static).
16421 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
16422 value types returned from functions when we need to invoke a
16423 method on the sturcture.
16426 2001-10-11 Ravi Pratap <ravi@ximian.com>
16428 * class.cs (TypeContainer::DefineType): Method to actually do the business of
16429 defining the type in the Modulebuilder or Typebuilder. This is to take
16430 care of nested types which need to be defined on the TypeBuilder using
16431 DefineNestedMethod.
16433 (TypeContainer::GetClassBases): Implement. Essentially the code from the
16434 methods in RootContext, only ported to be part of TypeContainer.
16436 (TypeContainer::GetInterfaceOrClass): Ditto.
16438 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
16440 * interface.cs (Interface::DefineInterface): New method. Does exactly
16441 what RootContext.CreateInterface did earlier, only it takes care of nested types
16444 (Interface::GetInterfaces): Move from RootContext here and port.
16446 (Interface::GetInterfaceByName): Same here.
16448 * rootcontext.cs (ResolveTree): Re-write.
16450 (PopulateTypes): Re-write.
16452 * class.cs (TypeContainer::Populate): Populate nested types too.
16453 (TypeContainer::Emit): Emit nested members too.
16455 * typemanager.cs (AddUserType): Do not make use of the FullName property,
16456 instead just use the name argument passed in as it is already fully
16459 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
16460 to TypeContainer mapping to see if a type is user-defined.
16462 * class.cs (TypeContainer::CloseType): Implement.
16464 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
16465 the default constructor.
16467 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
16470 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
16472 * interface.cs (CloseType): Create the type here.
16474 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
16477 Remove all the methods which are now in TypeContainer.
16479 2001-10-10 Ravi Pratap <ravi@ximian.com>
16481 * delegate.cs (Define): Re-write bits to define the delegate
16484 2001-10-10 Miguel de Icaza <miguel@ximian.com>
16486 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
16488 * expression.cs (ImplicitReferenceConversion): handle null as well
16489 as a source to convert to any reference type.
16491 * statement.cs (Return): Perform any implicit conversions to
16492 expected return type.
16494 Validate use of return statement.
16496 * codegen.cs (EmitContext): Pass the expected return type here.
16498 * class.cs (Method, Constructor, Property): Pass expected return
16499 type to EmitContext.
16501 2001-10-09 Miguel de Icaza <miguel@ximian.com>
16503 * expression.cs: Make DoResolve take an EmitContext instead of a
16506 Replaced `l' and `location' for `loc', for consistency.
16508 (Error, Warning): Remove unneeded Tc argument.
16510 * assign.cs, literal.cs, constant.cs: Update to new calling
16513 * codegen.cs: EmitContext now contains a flag indicating whether
16514 code is being generated in a static method or not.
16516 * cs-parser.jay: DecomposeQI, new function that replaces the old
16517 QualifiedIdentifier. Now we always decompose the assembled
16518 strings from qualified_identifier productions into a group of
16521 2001-10-08 Miguel de Icaza <miguel@ximian.com>
16523 * rootcontext.cs: Deal with field-less struct types correctly now
16524 by passing the size option to Define Type.
16526 * class.cs: Removed hack that created one static field.
16528 2001-10-07 Miguel de Icaza <miguel@ximian.com>
16530 * statement.cs: Moved most of the code generation here.
16532 2001-10-09 Ravi Pratap <ravi@ximian.com>
16534 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
16537 (ElementAccess): Remove useless bits for now - keep checks as the spec
16540 2001-10-08 Ravi Pratap <ravi@ximian.com>
16542 * expression.cs (ElementAccess::DoResolve): Remove my crap code
16543 and start performing checks according to the spec.
16545 2001-10-07 Ravi Pratap <ravi@ximian.com>
16547 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
16548 rank_specifiers instead.
16550 (rank_specifiers): Change the order in which the rank specifiers are stored
16552 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
16554 * expression.cs (ElementAccess): Implement the LValue interface too.
16556 2001-10-06 Ravi Pratap <ravi@ximian.com>
16558 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
16559 except that user defined conversions are not included.
16561 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
16562 perform the conversion of the return type, if necessary.
16564 (New::DoResolve): Check whether we are creating an array or an object
16565 and accordingly do the needful.
16567 (New::Emit): Same here.
16569 (New::DoResolve): Implement guts of array creation.
16571 (New::FormLookupType): Helper function.
16573 2001-10-07 Miguel de Icaza <miguel@ximian.com>
16575 * codegen.cs: Removed most of the code generation here, and move the
16576 corresponding code generation bits to the statement classes.
16578 Added support for try/catch/finalize and throw.
16580 * cs-parser.jay: Added support for try/catch/finalize.
16582 * class.cs: Catch static methods having the flags override,
16583 virtual or abstract.
16585 * expression.cs (UserCast): This user cast was not really doing
16586 what it was supposed to do. Which is to be born in fully resolved
16587 state. Parts of the resolution were being performed at Emit time!
16591 2001-10-05 Miguel de Icaza <miguel@ximian.com>
16593 * expression.cs: Implicity convert the result from UserCast.
16595 2001-10-05 Ravi Pratap <ravi@ximian.com>
16597 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
16598 prevented it from working correctly.
16600 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
16601 merely ConvertImplicit.
16603 2001-10-05 Miguel de Icaza <miguel@ximian.com>
16605 * typemanager.cs: Make the LookupTypeContainer function static,
16606 and not per-instance.
16608 * class.cs: Make static FindMembers (the one that takes a Type
16611 * codegen.cs: Add EmitForeach here.
16613 * cs-parser.jay: Make foreach a toplevel object instead of the
16614 inline expansion, as we need to perform semantic analysis on it.
16616 2001-10-05 Ravi Pratap <ravi@ximian.com>
16618 * expression.cs (Expression::ImplicitUserConversion): Rename to
16619 UserDefinedConversion.
16621 (Expression::UserDefinedConversion): Take an extra argument specifying
16622 whether we look for explicit user conversions too.
16624 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
16626 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
16628 (ExplicitUserConversion): Make it a call to UserDefinedConversion
16629 with the appropriate arguments.
16631 * cs-parser.jay (cast_expression): Record location too.
16633 * expression.cs (Cast): Record location info.
16635 (Expression::ConvertExplicit): Take location argument.
16637 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
16638 to determine if we are doing explicit conversions.
16640 (UserCast::Emit): Update accordingly.
16642 (Expression::ConvertExplicit): Report an error if everything fails.
16644 * ../errors/cs0030.cs : Add.
16646 2001-10-04 Miguel de Icaza <miguel@ximian.com>
16648 * modifiers.cs: If the ABSTRACT keyword is present, also set the
16649 virtual and newslot bits.
16651 * class.cs (TypeContainer::RegisterRequiredImplementations):
16652 Record methods we need.
16654 (TypeContainer::MakeKey): Helper function to make keys for
16655 MethodBases, since the Methodbase key is useless.
16657 (TypeContainer::Populate): Call RegisterRequiredImplementations
16658 before defining the methods.
16660 Create a mapping for method_builders_to_methods ahead of time
16661 instead of inside a tight loop.
16663 (::RequireMethods): Accept an object as the data to set into the
16664 hashtable so we can report interface vs abstract method mismatch.
16666 2001-10-03 Miguel de Icaza <miguel@ximian.com>
16668 * report.cs: Make all of it static.
16670 * rootcontext.cs: Drop object_type and value_type computations, as
16671 we have those in the TypeManager anyways.
16673 Drop report instance variable too, now it is a global.
16675 * driver.cs: Use try/catch on command line handling.
16677 Add --probe option to debug the error reporting system with a test
16680 * report.cs: Add support for exiting program when a probe
16681 condition is reached.
16683 2001-10-03 Ravi Pratap <ravi@ximian.com>
16685 * expression.cs (Binary::DoNumericPromotions): Fix the case when
16686 we do a forcible conversion regardless of type, to check if
16687 ForceConversion returns a null.
16689 (Binary::error19): Use location to report error.
16691 (Unary::error23): Use location here too.
16693 * ../errors/cs0019.cs : Check in.
16695 * ../errors/cs0023.cs : Check in.
16697 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
16698 case of a non-null MethodInfo object with a length of 0 !
16700 (Binary::ResolveOperator): Flag error if overload resolution fails to find
16701 an applicable member - according to the spec :-)
16702 Also fix logic to find members in base types.
16704 (Unary::ResolveOperator): Same here.
16706 (Unary::report23): Change name to error23 and make first argument a TypeContainer
16707 as I was getting thoroughly confused between this and error19 :-)
16709 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
16710 (::FindMostEncompassedType): Implement.
16711 (::FindMostEncompassingType): Implement.
16712 (::StandardConversionExists): Implement.
16714 (UserImplicitCast): Re-vamp. We now need info about most specific
16715 source and target types so that we can do the necessary conversions.
16717 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
16718 mathematical union with no duplicates.
16720 2001-10-03 Miguel de Icaza <miguel@ximian.com>
16722 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
16723 in order from base classes to child classes, so that we can in
16724 child classes look up in our parent for method names and
16725 attributes (required for handling abstract, virtual, new, override
16726 constructs: we need to instrospect our base class, and if we dont
16727 populate the classes in order, the introspection might be
16728 incorrect. For example, a method could query its parent before
16729 the parent has any methods and would determine that the parent has
16730 no abstract methods (while it could have had them)).
16732 (RootContext::CreateType): Record the order in which we define the
16735 2001-10-02 Miguel de Icaza <miguel@ximian.com>
16737 * class.cs (TypeContainer::Populate): Also method definitions can
16738 fail now, keep track of this.
16740 (TypeContainer::FindMembers): Implement support for
16741 DeclaredOnly/noDeclaredOnly flag.
16743 (Constructor::Emit) Return the ConstructorBuilder.
16745 (Method::Emit) Return the MethodBuilder.
16746 Check for abstract or virtual methods to be public.
16748 * rootcontext.cs (RootContext::CreateType): Register all the
16749 abstract methods required for the class to be complete and the
16750 interface methods that must be implemented.
16752 * cs-parser.jay: Report error 501 (method requires body if it is
16753 not marked abstract or extern).
16755 * expression.cs (TypeOf::Emit): Implement.
16757 * typemanager.cs: runtime_handle_type, new global type.
16759 * class.cs (Property::Emit): Generate code for properties.
16761 2001-10-02 Ravi Pratap <ravi@ximian.com>
16763 * expression.cs (Unary::ResolveOperator): Find operators on base type
16764 too - we now conform exactly to the spec.
16766 (Binary::ResolveOperator): Same here.
16768 * class.cs (Operator::Define): Fix minor quirk in the tests.
16770 * ../errors/cs0215.cs : Added.
16772 * ../errors/cs0556.cs : Added.
16774 * ../errors/cs0555.cs : Added.
16776 2001-10-01 Miguel de Icaza <miguel@ximian.com>
16778 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
16779 single integer which is really efficient
16781 2001-10-01 Ravi Pratap <ravi@ximian.com>
16783 * expression.cs (Expression::ImplicitUserConversion): Use location
16784 even in the case when we are examining True operators.
16786 * class.cs (Operator::Define): Perform extensive checks to conform
16787 with the rules for operator overloading in the spec.
16789 * expression.cs (Expression::ImplicitReferenceConversion): Implement
16790 some of the other conversions mentioned in the spec.
16792 * typemanager.cs (array_type): New static member for the System.Array built-in
16795 (cloneable_interface): For System.ICloneable interface.
16797 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
16798 we start resolving the tree and populating types.
16800 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
16802 2001-10-01 Miguel de Icaza <miguel@ximian.com>
16804 * expression.cs (Expression::ExprClassFromMemberInfo,
16805 Expression::Literalize): Create literal expressions from
16806 FieldInfos which are literals.
16808 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
16809 type casts, because they were wrong. The test suite in tests
16812 (ImplicitNumericConversion): ushort to ulong requires a widening
16815 Int32 constant to long requires widening cast as well.
16817 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
16818 for integers because the type on the stack is not i4.
16820 2001-09-30 Miguel de Icaza <miguel@ximian.com>
16822 * expression.cs (report118): require location argument.
16824 * parameter.cs: Do not dereference potential null value.
16826 * class.cs: Catch methods that lack the `new' keyword when
16827 overriding a name. Report warnings when `new' is used without
16828 anything being there to override.
16830 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
16832 * class.cs: Only add constructor to hashtable if it is non-null
16833 (as now constructors can fail on define).
16835 (TypeManager, Class, Struct): Take location arguments.
16837 Catch field instance initialization in structs as errors.
16839 accepting_filter: a new filter for FindMembers that is static so
16840 that we dont create an instance per invocation.
16842 (Constructor::Define): Catch errors where a struct constructor is
16845 * cs-parser.jay: Pass location information for various new
16848 * delegate.cs (Delegate): take a location argument.
16850 * driver.cs: Do not call EmitCode if there were problesm in the
16851 Definition of the types, as many Builders wont be there.
16853 * decl.cs (Decl::Decl): Require a location argument.
16855 * cs-tokenizer.cs: Handle properly hex constants that can not fit
16856 into integers, and find the most appropiate integer for it.
16858 * literal.cs: Implement ULongLiteral.
16860 * rootcontext.cs: Provide better information about the location of
16861 failure when CreateType fails.
16863 2001-09-29 Miguel de Icaza <miguel@ximian.com>
16865 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
16868 * expression.cs (Binary::CheckShiftArguments): Add missing type
16870 (Binary::ResolveOperator): Add type to the logical and and logical
16871 or, Bitwise And/Or and Exclusive Or code paths, it was missing
16874 (Binary::DoNumericPromotions): In the case where either argument
16875 is ulong (and most signed types combined with ulong cause an
16876 error) perform implicit integer constant conversions as well.
16878 2001-09-28 Miguel de Icaza <miguel@ximian.com>
16880 * expression.cs (UserImplicitCast): Method should always be
16882 (Invocation::BetterConversion): Simplified test for IntLiteral.
16884 (Expression::ImplicitNumericConversion): Split this routine out.
16885 Put the code that performs implicit constant integer conversions
16888 (Expression::Resolve): Become a wrapper around DoResolve so we can
16889 check eclass and type being set after resolve.
16891 (Invocation::Badness): Remove this dead function
16893 (Binary::ResolveOperator): Do not compute the expensive argumnets
16894 unless we have a union for it.
16896 (Probe::Emit): Is needs to do an isinst and then
16897 compare against null.
16899 (::CanConvert): Added Location argument. If the Location argument
16900 is null (Location.Null), then we do not report errors. This is
16901 used by the `probe' mechanism of the Explicit conversion. We do
16902 not want to generate an error for something that the user
16903 explicitly requested to be casted. But the pipeline for an
16904 explicit cast first tests for potential implicit casts.
16906 So for now, if the Location is null, it means `Probe only' to
16907 avoid adding another argument. Might have to revise this
16910 (ClassCast): New class used to type cast objects into arbitrary
16911 classes (used in Explicit Reference Conversions).
16913 Implement `as' as well.
16915 Reverted all the patches from Ravi below: they were broken:
16917 * The use of `level' as a mechanism to stop recursive
16918 invocations is wrong. That was there just to catch the
16919 bug with a strack trace but not as a way of addressing
16922 To fix the problem we have to *understand* what is going
16923 on and the interactions and come up with a plan, not
16924 just get things going.
16926 * The use of the type conversion cache that I proposed
16927 last night had an open topic: How does this work across
16928 protection domains. A user defined conversion might not
16929 be public in the location where we are applying the
16930 conversion, a different conversion might be selected
16931 (ie, private A->B (better) but public B->A (worse),
16932 inside A, A->B applies, but outside it, B->A will
16935 * On top of that (ie, even if the above is solved),
16936 conversions in a cache need to be abstract. Ie, `To
16937 convert from an Int to a Short use an OpcodeCast', not
16938 `To convert from an Int to a Short use the OpcodeCast on
16939 the variable 5' (which is what this patch was doing).
16941 2001-09-28 Ravi Pratap <ravi@ximian.com>
16943 * expression.cs (Invocation::ConversionExists): Re-write to use
16944 the conversion cache
16946 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
16947 cache all conversions done, not just user-defined ones.
16949 (Invocation::BetterConversion): The real culprit. Use ConversionExists
16950 to determine if a conversion exists instead of acutually trying to
16951 perform the conversion. It's faster too.
16953 (Expression::ConvertExplicit): Modify to use ConversionExists to check
16954 and only then attempt the implicit conversion.
16956 2001-09-28 Ravi Pratap <ravi@ximian.com>
16958 * expression.cs (ConvertImplicit): Use a cache for conversions
16959 already found. Check level of recursion and bail out if necessary.
16961 2001-09-28 Miguel de Icaza <miguel@ximian.com>
16963 * typemanager.cs (string_concat_string_string, string_concat_object_object):
16964 Export standard methods that we expect for string operations.
16966 * statement.cs (Block::UsageWarning): Track usage of variables and
16967 report the errors for not used variables.
16969 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
16972 2001-09-27 Miguel de Icaza <miguel@ximian.com>
16974 * codegen.cs: remove unnneded code
16976 * expression.cs: Removed BuiltinTypeAccess class
16978 Fix the order in which implicit conversions are
16981 The previous fixed dropped support for boxed conversions (adding a
16982 test to the test suite now)
16984 (UserImplicitCast::CanConvert): Remove test for source being null,
16985 that code is broken. We should not feed a null to begin with, if
16986 we do, then we should track the bug where the problem originates
16987 and not try to cover it up here.
16989 Return a resolved expression of type UserImplicitCast on success
16990 rather than true/false. Ravi: this is what I was talking about,
16991 the pattern is to use a static method as a "constructor" for
16994 Also, do not create arguments until the very last minute,
16995 otherwise we always create the arguments even for lookups that
16996 will never be performed.
16998 (UserImplicitCast::Resolve): Eliminate, objects of type
16999 UserImplicitCast are born in a fully resolved state.
17001 * typemanager.cs (InitCoreTypes): Init also value_type
17002 (System.ValueType).
17004 * expression.cs (Cast::Resolve): First resolve the child expression.
17006 (LValue): Add new method AddressOf to be used by
17009 Change the argument of Store to take an EmitContext instead of an
17010 ILGenerator, because things like FieldExpr need to be able to call
17011 their children expression to generate the instance code.
17013 (Expression::Error, Expression::Warning): Sugar functions for
17016 (Expression::MemberLookup): Accept a TypeContainer instead of a
17017 Report as the first argument.
17019 (Expression::ResolvePrimary): Killed. I still want to improve
17020 this as currently the code is just not right.
17022 (Expression::ResolveMemberAccess): Simplify, but it is still
17025 (Unary::Resolve): Catch errors in AddressOf operators.
17027 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
17028 index to a byte for the short-version, or the compiler will choose
17029 the wrong Emit call, which generates the wrong data.
17031 (ParameterReference::Emit, ::Store): same.
17033 (FieldExpr::AddressOf): Implement.
17035 * typemanager.cs: TypeManager: made public variable instead of
17038 * driver.cs: document --fatal.
17040 * report.cs (ErrorMessage, WarningMessage): new names for the old
17041 Error and Warning classes.
17043 * cs-parser.jay (member_access): Turn built-in access to types
17044 into a normal simplename
17046 2001-09-27 Ravi Pratap <ravi@ximian.com>
17048 * expression.cs (Invocation::BetterConversion): Fix to cope
17049 with q being null, since this was introducing a bug.
17051 * expression.cs (ConvertImplicit): Do built-in conversions first.
17053 2001-09-27 Ravi Pratap <ravi@ximian.com>
17055 * expression.cs (UserImplicitCast::Resolve): Fix bug.
17057 2001-09-27 Ravi Pratap <ravi@ximian.com>
17059 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
17060 I had introduced long ago (what's new ?).
17062 * expression.cs (UserImplicitCast::CanConvert): Static method to do
17063 the work of all the checking.
17064 (ConvertImplicit): Call CanConvert and only then create object if necessary.
17065 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
17067 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
17068 that is the right way.
17070 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
17071 overloading resolution. Use everywhere instead of cutting and pasting code.
17073 (Binary::ResolveOperator): Use MakeUnionSet.
17075 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
17076 we have to convert to bool types. Not complete yet.
17078 2001-09-27 Miguel de Icaza <miguel@ximian.com>
17080 * typemanager.cs (TypeManager::CSharpName): support ushort.
17082 * expression.cs (Expression::TryImplicitIntConversion): Attempts
17083 to provide an expression that performsn an implicit constant int
17084 conversion (section 6.1.6).
17085 (Expression::ConvertImplicitRequired): Reworked to include
17086 implicit constant expression conversions.
17088 (Expression::ConvertNumericExplicit): Finished.
17090 (Invocation::Emit): If InstanceExpression is null, then it means
17091 that we perform a call on this.
17093 2001-09-26 Miguel de Icaza <miguel@ximian.com>
17095 * expression.cs (Unary::Emit): Remove some dead code.
17096 (Probe): Implement Resolve and Emit for `is'.
17097 (Expression::ConvertImplicitRequired): Attempt to do constant
17098 expression conversions here. Maybe should be moved to
17099 ConvertImplicit, but I am not sure.
17100 (Expression::ImplicitLongConstantConversionPossible,
17101 Expression::ImplicitIntConstantConversionPossible): New functions
17102 that tell whether is it possible to apply an implicit constant
17103 expression conversion.
17105 (ConvertNumericExplicit): Started work on explicit numeric
17108 * cs-parser.jay: Update operator constants.
17110 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
17111 (Parameters::GetSignature): Hook up VerifyArgs here.
17112 (Parameters::VerifyArgs): Verifies that no two arguments have the
17115 * class.cs (Operator): Update the operator names to reflect the
17116 ones that the spec expects (as we are just stringizing the
17119 * expression.cs (Unary::ResolveOperator): Fix bug: Use
17120 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
17121 previous usage did only work for our methods.
17122 (Expression::ConvertImplicit): Handle decimal implicit numeric
17123 conversions as well.
17124 (Expression::InternalTypeConstructor): Used to invoke constructors
17125 on internal types for default promotions.
17127 (Unary::Emit): Implement special handling for the pre/post
17128 increment/decrement for overloaded operators, as they need to have
17129 the same semantics as the other operators.
17131 (Binary::ResolveOperator): ditto.
17132 (Invocation::ConversionExists): ditto.
17133 (UserImplicitCast::Resolve): ditto.
17135 2001-09-26 Ravi Pratap <ravi@ximian.com>
17137 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
17138 operator, return after emitting body. Regression tests pass again !
17140 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
17141 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
17142 (Invocation::OverloadResolve): Ditto.
17143 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
17145 * everywhere : update calls to the above methods accordingly.
17147 2001-09-26 Miguel de Icaza <miguel@ximian.com>
17149 * assign.cs (Assign): Make it inherit from ExpressionStatement.
17151 * expression.cs (ExpressionStatement): New base class used for
17152 expressions that can appear in statements, so that we can provide
17153 an alternate path to generate expression that do not leave a value
17156 (Expression::Emit, and all the derivatives): We no longer return
17157 whether a value is left on the stack or not. Every expression
17158 after being emitted leaves a single value on the stack.
17160 * codegen.cs (EmitContext::EmitStatementExpression): Use the
17161 facilties of ExpressionStatement if possible.
17163 * cs-parser.jay: Update statement_expression.
17165 2001-09-25 Miguel de Icaza <miguel@ximian.com>
17167 * driver.cs: Change the wording of message
17169 2001-09-25 Ravi Pratap <ravi@ximian.com>
17171 * expression.cs (Binary::ResolveOperator): Had forgottten to set
17172 the type of the expression to the return type of the method if
17173 we have an overloaded operator match ! The regression tests pass again !
17174 (Unary::ResolveOperator): Ditto.
17176 * expression.cs (Invocation::ConversionExists): Correct the member lookup
17177 to find "op_Implicit", not "implicit" ;-)
17178 (UserImplicitCast): New class to take care of user-defined implicit conversions.
17179 (ConvertImplicit, ForceConversion): Take TypeContainer argument
17181 * everywhere : Correct calls to the above accordingly.
17183 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
17184 (ConvertImplicit): Do user-defined conversion if it exists.
17186 2001-09-24 Miguel de Icaza <miguel@ximian.com>
17188 * assign.cs: track location.
17189 (Resolve): Use implicit conversions on assignment.
17191 * literal.cs: Oops. Not good, Emit of short access values should
17192 pass (Bytes) or the wrong argument will be selected.
17194 * expression.cs (Unary::Emit): Emit code for -expr.
17196 (Unary::ResolveOperator): Handle `Substract' for non-constants
17197 (substract from zero from the non-constants).
17198 Deal with Doubles as well.
17200 (Expression::ConvertImplicitRequired): New routine that reports an
17201 error if no implicit conversion exists.
17203 (Invocation::OverloadResolve): Store the converted implicit
17204 expressions if we make them
17206 2001-09-24 Ravi Pratap <ravi@ximian.com>
17208 * class.cs (ConstructorInitializer): Take a Location argument.
17209 (ConstructorBaseInitializer): Same here.
17210 (ConstructorThisInitializer): Same here.
17212 * cs-parser.jay : Update all calls accordingly.
17214 * expression.cs (Unary, Binary, New): Take location argument.
17215 Update accordingly everywhere.
17217 * cs-parser.jay : Update all calls to the above to take a location
17220 * class.cs : Ditto.
17222 2001-09-24 Ravi Pratap <ravi@ximian.com>
17224 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
17225 (Invocation::BetterConversion): Same here
17226 (Invocation::ConversionExists): Ditto.
17228 (Invocation::ConversionExists): Implement.
17230 2001-09-22 Ravi Pratap <ravi@ximian.com>
17232 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
17233 Also take an additional TypeContainer argument.
17235 * All over : Pass in TypeContainer as argument to OverloadResolve.
17237 * typemanager.cs (CSharpName): Update to check for the string type and return
17240 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
17243 2001-09-21 Ravi Pratap <ravi@ximian.com>
17245 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
17246 (Invocation::BetterFunction): Implement.
17247 (Invocation::BetterConversion): Implement.
17248 (Invocation::ConversionExists): Skeleton, no implementation yet.
17250 Okay, things work fine !
17252 2001-09-21 Miguel de Icaza <miguel@ximian.com>
17254 * typemanager.cs: declare and load enum_type, delegate_type and
17257 * expression.cs (Expression::Emit): Now emit returns a value that
17258 tells whether a value is left on the stack or not. This strategy
17259 might be reveted tomorrow with a mechanism that would address
17260 multiple assignments.
17261 (Expression::report118): Utility routine to report mismatches on
17264 (Unary::Report23): Report impossible type/operator combination
17267 (Unary::IsIncrementableNumber): Whether the type can be
17268 incremented or decremented with add.
17269 (Unary::ResolveOperator): Also allow enumerations to be bitwise
17271 (Unary::ResolveOperator): Implement ++, !, ~,
17273 (Invocation::Emit): Deal with new Emit convetion.
17275 * All Expression derivatives: Updated their Emit method to return
17276 whether they leave values on the stack or not.
17278 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
17279 stack for expressions that are statements.
17281 2001-09-20 Miguel de Icaza <miguel@ximian.com>
17283 * expression.cs (LValue): New interface. Must be implemented by
17285 (LocalVariableReference, ParameterReference, FieldExpr): Implement
17288 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
17289 interface for generating code, simplifies the code.
17291 2001-09-20 Ravi Pratap <ravi@ximian.com>
17293 * expression.cs (everywhere): Comment out return statements in ::Resolve
17294 methods to avoid the warnings.
17296 2001-09-20 Miguel de Icaza <miguel@ximian.com>
17298 * driver.cs (parse): Report error 2001 if we can not open the
17301 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
17304 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
17307 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
17308 otherwise nested blocks end up with the same index.
17310 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
17312 * expression.cs: Instead of having FIXMEs in the Resolve
17313 functions, throw exceptions so it is obvious that we are facing a
17316 * cs-parser.jay (invocation_expression): Pass Location information.
17318 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
17319 Use a basename for those routines because .NET does not like paths
17322 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
17325 2001-09-19 Miguel de Icaza <miguel@ximian.com>
17327 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
17328 are loading the correct data types (throws an exception if not).
17329 (TypeManager::InitCoreTypes): Use CoreLookupType
17331 * expression.cs (Unary::ResolveOperator): return the child
17332 expression for expressions which are just +expr.
17333 (Unary::ResolveOperator): Return negative literals for -LITERAL
17334 expressions (otherwise they are Unary {Literal}).
17335 (Invocation::Badness): Take into account `Implicit constant
17336 expression conversions'.
17338 * literal.cs (LongLiteral): Implement long literal class.
17339 (IntLiteral): export the `Value' of the intliteral.
17341 2001-09-19 Ravi Pratap <ravi@ximian.com>
17343 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
17345 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
17346 instead of 'Operator'
17348 * expression.cs (Binary::ResolveOperator): Update accordingly.
17349 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
17352 * cs-parser.jay (unary_expression): Update to use the new names.
17354 * gen-treedump.cs (GetUnary): Same here.
17356 * expression.cs (Unary::Resolve): Implement.
17357 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
17358 operators are found instead of making noise ;-)
17359 (Unary::ResolveOperator): New method to do precisely the same thing which
17360 Binary::ResolveOperator does for Binary expressions.
17361 (Unary.method, .Arguments): Add.
17362 (Unary::OperName): Implement.
17363 (Unary::ForceConversion): Copy and Paste !
17365 * class.cs (Operator::Define): Fix a small bug for the case when we have
17368 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
17369 for the inbuilt operators. Only overloading works for now ;-)
17371 2001-09-18 Miguel de Icaza <miguel@ximian.com>
17373 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
17374 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
17376 * expression.cs (This::Emit): Implement.
17377 (This::Resolve): Implement.
17378 (TypeOf:Resolve): Implement.
17379 (Expression::ResolveSimpleName): Add an implicit this to instance
17381 (MemberAccess::Resolve): Deal with Parameters and Fields.
17382 Bind instance variable to Field expressions.
17383 (FieldExpr::Instance): New field used to track the expression that
17384 represents the object instance.
17385 (FieldExpr::Resolve): Track potential errors from MemberLookup not
17387 (FieldExpr::Emit): Implement.
17389 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
17390 the last instruction contains a return opcode to avoid generating
17391 the last `ret' instruction (this generates correct code, and it is
17392 nice to pass the peverify output).
17394 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
17395 initializer for static and instance variables.
17396 (Constructor::Emit): Allow initializer to be null in the case of
17397 static constructors. Only emit initializer for instance
17400 (TypeContainer::FindMembers): Return a null array if there are no
17403 Also fix the code for the MemberTypes.Method branch, as it was not
17404 scanning that for operators (or tried to access null variables before).
17406 * assign.cs (Assign::Emit): Handle instance and static fields.
17410 * driver.cs: Stop compilation if there are parse errors.
17412 * cs-parser.jay (constructor_declaration): Provide default base
17413 initializer for non-static constructors.
17414 (constructor_declarator): Do not provide a default base
17415 initializers if none was specified.
17416 Catch the fact that constructors should not have parameters.
17418 * class.cs: Do not emit parent class initializers for static
17419 constructors, that should be flagged as an error.
17421 2001-09-18 Ravi Pratap <ravi@ximian.com>
17423 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
17424 Move back code into TypeContainer::Populate.
17426 2001-09-18 Ravi Pratap <ravi@ximian.com>
17428 * class.cs (TypeContainer::AddConstructor): Fix the check to
17429 compare against Name, not Basename.
17430 (Operator::OpType): Change Plus and Minus to Add and Subtract.
17432 * cs-parser.jay : Update accordingly.
17434 * class.cs (TypeContainer::FindMembers): For the case where we are searching
17435 for methods, don't forget to look into the operators too.
17436 (RegisterMethodBuilder): Helper method to take care of this for
17437 methods, constructors and operators.
17438 (Operator::Define): Completely revamp.
17439 (Operator.OperatorMethod, MethodName): New fields.
17440 (TypeContainer::Populate): Move the registering of builders into
17441 RegisterMethodBuilder.
17442 (Operator::Emit): Re-write.
17444 * expression.cs (Binary::Emit): Comment out code path to emit method
17445 invocation stuff for the case when we have a user defined operator. I am
17446 just not able to get it right !
17448 2001-09-17 Miguel de Icaza <miguel@ximian.com>
17450 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
17453 (Expression::MemberLookup): Provide a version that allows to
17454 specify the MemberTypes and BindingFlags.
17456 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
17457 so it was not fetching variable information from outer blocks.
17459 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
17460 Beforefieldinit as it was buggy.
17462 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
17463 that Ravi put here.
17465 * class.cs (Constructor::Emit): Only emit if block is not null.
17466 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
17467 deal with this by semantically definining it as if the user had
17470 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
17471 constructors as we now "emit" them at a higher level.
17473 (TypeContainer::DefineDefaultConstructor): Used to define the
17474 default constructors if none was provided.
17476 (ConstructorInitializer): Add methods Resolve and Emit.
17478 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
17480 2001-09-17 Ravi Pratap <ravi@ximian.com>
17482 * class.cs (TypeContainer::EmitDefaultConstructor): Register
17483 the default constructor builder with our hashtable for methodbuilders
17486 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
17487 and argument_count is 0 in which case we have a match.
17488 (Binary::ResolveOperator): More null checking and miscellaneous coding
17491 2001-09-17 Ravi Pratap <ravi@ximian.com>
17493 * rootcontext.cs (IsNameSpace): Compare against null.
17495 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
17497 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
17498 and Unary::Operator.
17500 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
17503 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
17504 we have overloaded operators.
17505 (Binary::ResolveOperator): Implement the part which does the operator overload
17508 * class.cs (Operator::Emit): Implement.
17509 (TypeContainer::Emit): Emit the operators we have too.
17511 * expression.cs (Binary::Emit): Update to emit the appropriate code for
17512 the case when we have a user-defined operator.
17514 2001-09-17 Miguel de Icaza <miguel@ximian.com>
17516 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
17518 2001-09-16 Ravi Pratap <ravi@ximian.com>
17520 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
17521 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
17522 (Constructor::Emit): Implement.
17523 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
17524 if we have no work to do.
17525 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
17528 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
17529 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
17531 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
17534 2001-09-15 Ravi Pratap <ravi@ximian.com>
17536 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
17538 (Tree::RecordNamespace): Method to do what the name says ;-)
17539 (Tree::Namespaces): Property to get at the namespaces hashtable.
17541 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
17544 * rootcontext.cs (IsNamespace): Fixed it :-)
17546 2001-09-14 Miguel de Icaza <miguel@ximian.com>
17548 * class.cs (TypeContainer::FindMembers): Add support for
17550 (MethodCore): New class that encapsulates both the shared aspects
17551 of a Constructor and a Method.
17552 (Method, Constructor): Factored pieces into MethodCore.
17554 * driver.cs: Added --fatal which makes errors throw exceptions.
17555 Load System assembly as well as part of the standard library.
17557 * report.cs: Allow throwing exceptions on errors for debugging.
17559 * modifiers.cs: Do not use `parent', instead use the real type
17560 container to evaluate permission settings.
17562 * class.cs: Put Ravi's patch back in. He is right, and we will
17563 have to cope with the
17565 2001-09-14 Ravi Pratap <ravi@ximian.com>
17567 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
17568 FamORAssem, not FamANDAssem.
17570 2001-09-14 Miguel de Icaza <miguel@ximian.com>
17572 * driver.cs: Added --parse option that only parses its input files
17575 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
17576 incorrect. IsTopLevel is not used to tell whether an object is
17577 root_types or not (that can be achieved by testing this ==
17578 root_types). But to see if this is a top-level *class* (not
17579 necessarly our "toplevel" container).
17581 2001-09-14 Ravi Pratap <ravi@ximian.com>
17583 * enum.cs (Enum::Define): Modify to call the Lookup method on the
17584 parent instead of a direct call to GetType.
17586 2001-09-14 Ravi Pratap <ravi@ximian.com>
17588 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
17589 Modifiers.TypeAttr. This should just be a call to that method.
17591 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
17592 object so that we can determine if we are top-level or not.
17594 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
17597 * enum.cs (Enum::Define): Ditto.
17599 * modifiers.cs (FieldAttr): Re-write.
17601 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
17602 (TypeContainer::HaveStaticConstructor): New property to provide access
17603 to precisely that info.
17605 * modifiers.cs (MethodAttr): Re-write.
17606 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
17608 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
17609 of top-level types as claimed.
17611 2001-09-13 Miguel de Icaza <miguel@ximian.com>
17613 * expression.cs (MemberLookup): Fruitless attempt to lookup
17614 constructors. Maybe I need to emit default constructors? That
17615 might be it (currently .NET emits this for me automatically).
17616 (Invocation::OverloadResolve): Cope with Arguments == null.
17617 (Invocation::EmitArguments): new function, shared by the new
17618 constructor and us.
17619 (Invocation::Emit): Handle static and instance methods. Emit
17620 proper call instruction for virtual or non-virtual invocations.
17621 (New::Emit): Implement.
17622 (New::Resolve): Implement.
17623 (MemberAccess:Resolve): Implement.
17624 (MethodGroupExpr::InstanceExpression): used conforming to the spec
17625 to track instances.
17626 (FieldExpr::Resolve): Set type.
17628 * support.cs: Handle empty arguments.
17630 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
17631 SimpleLookup): Auxiliary routines to help parse a qualifier
17634 Update qualifier_identifier rule.
17636 * codegen.cs: Removed debugging messages.
17638 * class.cs: Make this a global thing, this acts just as a "key" to
17639 objects that we might have around.
17641 (Populate): Only initialize method_builders_to_methods once.
17643 * expression.cs (PropertyExpr): Initialize type from the
17646 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
17647 Resolve pattern. Attempt to implicitly convert value to boolean.
17650 * expression.cs: Set the type for the int32/int32 argument case.
17651 (Binary::ResolveOperator): Set the return type to boolean for
17652 comparission operators
17654 * typemanager.cs: Remove debugging print code.
17656 (Invocation::Resolve): resolve type.
17658 * class.cs: Allocate a MemberInfo of the correct size, as the code
17659 elsewhere depends on the test to reflect the correct contents.
17661 (Method::) Keep track of parameters, due to System.Reflection holes
17663 (TypeContainer::Populate): Keep track of MethodBuilders to Method
17666 (TypeContainer::FindMembers): Use ArrayList and then copy an array
17667 of the exact size and return that.
17669 (Class::LookupMethodByBuilder): New function that maps
17670 MethodBuilders to its methods. Required to locate the information
17671 on methods because System.Reflection bit us again.
17673 * support.cs: New file, contains an interface ParameterData and
17674 two implementations: ReflectionParameters and InternalParameters
17675 used to access Parameter information. We will need to grow this
17678 * expression.cs (Invocation::GetParameterData): implement a cache
17679 and a wrapper around the ParameterData creation for methods.
17680 (Invocation::OverloadResolve): Use new code.
17682 2001-09-13 Ravi Pratap <ravi@ximian.com>
17684 * class.cs (TypeContainer::EmitField): Remove and move into
17685 (Field::Define): here and modify accordingly.
17686 (Field.FieldBuilder): New member.
17687 (TypeContainer::Populate): Update accordingly.
17688 (TypeContainer::FindMembers): Implement.
17690 2001-09-13 Miguel de Icaza <miguel@ximian.com>
17692 * statement.cs: (VariableInfo::VariableType): New field to be
17693 initialized with the full type once it is resolved.
17695 2001-09-12 Miguel de Icaza <miguel@ximian.com>
17697 * parameter.cs (GetParameterInfo): Use a type cache to compute
17698 things only once, and to reuse this information
17700 * expression.cs (LocalVariableReference::Emit): Implement.
17701 (OpcodeCast::Emit): fix.
17703 (ParameterReference::Resolve): Implement.
17704 (ParameterReference::Emit): Implement.
17706 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
17707 that are expressions need to stay as Expressions.
17709 * typemanager.cs (CSharpName): Returns the C# name of a type if
17712 * expression.cs (Expression::ConvertImplicit): New function that
17713 implements implicit type conversions.
17715 (Expression::ImplicitReferenceConversion): Implements implicit
17716 reference conversions.
17718 (EmptyCast): New type for transparent casts.
17720 (OpcodeCast): New type for casts of types that are performed with
17721 a sequence of bytecodes.
17723 (BoxedCast): New type used for casting value types into reference
17724 types. Emits a box opcode.
17726 (Binary::DoNumericPromotions): Implements numeric promotions of
17727 and computation of the Binary::Type.
17729 (Binary::EmitBranchable): Optimization.
17731 (Binary::Emit): Implement code emission for expressions.
17733 * typemanager.cs (TypeManager): Added two new core types: sbyte
17736 2001-09-12 Ravi Pratap <ravi@ximian.com>
17738 * class.cs (TypeContainer::FindMembers): Method which does exactly
17739 what Type.FindMembers does, only we don't have to use reflection. No
17740 implementation yet.
17742 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
17743 typecontainer objects as we need to get at them.
17744 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
17746 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
17747 typecontainer object.
17749 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
17750 of just a Report object.
17752 2001-09-11 Ravi Pratap <ravi@ximian.com>
17754 * class.cs (Event::Define): Go back to using the prefixes "add_" and
17756 (TypeContainer::Populate): Now define the delegates of the type too.
17757 (TypeContainer.Delegates): Property to access the list of delegates defined
17760 * delegates.cs (Delegate::Define): Implement partially.
17762 * modifiers.cs (TypeAttr): Handle more flags.
17764 2001-09-11 Ravi Pratap <ravi@ximian.com>
17766 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
17768 (Operator::Define): Re-write logic to get types by using the LookupType method
17769 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
17770 (Indexer::Define): Ditto.
17771 (Event::Define): Ditto.
17772 (Property::Define): Ditto.
17774 2001-09-10 Ravi Pratap <ravi@ximian.com>
17776 * class.cs (TypeContainer::Populate): Now define operators too.
17777 (TypeContainer.Operators): New property to access the list of operators
17779 (Operator.OperatorMethodBuilder): New member to hold the method builder
17780 for the operator we are defining.
17781 (Operator::Define): Implement.
17783 2001-09-10 Ravi Pratap <ravi@ximian.com>
17785 * class.cs (Event::Define): Make the prefixes of the accessor methods
17786 addOn_ and removeOn_
17788 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
17789 of the location being passed in too. Ideally, this should go later since all
17790 error reporting should be done through the Report object.
17792 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
17793 (Populate): Iterate thru the indexers we have and define them too.
17794 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
17795 for the get and set accessors.
17796 (Indexer::Define): Implement.
17798 2001-09-09 Miguel de Icaza <miguel@ximian.com>
17800 * expression.cs (Binary::Resolve): Beginning of it. I scratched
17801 my previous implementation, did not work.
17803 * typemanager.cs: Add a couple of missing types (the longs).
17805 * literal.cs: Use TypeManager.bool_type instead of getting it.
17807 * expression.cs (EventExpr): New kind of expressions.
17808 (Expressio::ExprClassFromMemberInfo): finish
17810 2001-09-08 Miguel de Icaza <miguel@ximian.com>
17812 * assign.cs: Emit stores to static fields differently.
17814 2001-09-08 Ravi Pratap <ravi@ximian.com>
17816 * Merge in changes and adjust code to tackle conflicts. Backed out my
17817 code in Assign::Resolve ;-)
17819 2001-09-08 Ravi Pratap <ravi@ximian.com>
17821 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
17822 instead Report.Error and also pass in the location.
17823 (CSharpParser::Lexer): New readonly property to return the reference
17824 to the Tokenizer object.
17825 (declare_local_variables): Use Report.Error with location instead of plain
17829 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
17830 (Operator.CheckBinaryOperator): Ditto.
17832 * cs-parser.jay (operator_declarator): Update accordingly.
17834 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
17835 (CheckBinaryOperator): Same here.
17837 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
17838 on the name without any prefixes of namespace names etc. This is because we
17839 already might have something already fully qualified like
17840 'System.Console.WriteLine'
17842 * assign.cs (Resolve): Begin implementation. Stuck ;-)
17844 2001-09-07 Ravi Pratap <ravi@ximian.com>
17846 * cs-tokenizer.cs (location): Return a string which also contains
17849 * expression.cs (ElementAccess): New class for expressions of the
17850 type 'element access.'
17851 (BaseAccess): New class for expressions of the type 'base access.'
17852 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
17855 * cs-parser.jay (element_access): Implement action.
17856 (base_access): Implement actions.
17857 (checked_expression, unchecked_expression): Implement.
17859 * cs-parser.jay (local_variable_type): Correct and implement.
17860 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
17862 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
17864 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
17865 name and the specifiers.
17867 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
17869 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
17870 making them all public ;-)
17872 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
17875 2001-09-07 Miguel de Icaza <miguel@ximian.com>
17877 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
17879 (FieldExpr, PropertyExprs): New resolved expressions.
17880 (SimpleName::MemberStaticCheck): Perform static checks for access
17881 to non-static fields on static methods. Maybe this should be
17882 generalized for MemberAccesses.
17883 (SimpleName::ResolveSimpleName): More work on simple name
17886 * cs-parser.jay (primary_expression/qualified_identifier): track
17887 the parameter index.
17889 * codegen.cs (CodeGen::Save): Catch save exception, report error.
17890 (EmitContext::EmitBoolExpression): Chain to expression generation
17891 instead of temporary hack.
17892 (::EmitStatementExpression): Put generic expression code generation.
17894 * assign.cs (Assign::Emit): Implement variable assignments to
17895 local variables, parameters and fields.
17897 2001-09-06 Miguel de Icaza <miguel@ximian.com>
17899 * statement.cs (Block::GetVariableInfo): New method, returns the
17900 VariableInfo for a variable name in a block.
17901 (Block::GetVariableType): Implement in terms of GetVariableInfo
17903 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
17904 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
17906 2001-09-06 Ravi Pratap <ravi@ximian.com>
17908 * cs-parser.jay (operator_declaration): Continue on my quest : update
17909 to take attributes argument.
17910 (event_declaration): Ditto.
17911 (enum_declaration): Ditto.
17912 (indexer_declaration): Ditto.
17914 * class.cs (Operator::Operator): Update constructor accordingly.
17915 (Event::Event): Ditto.
17917 * delegate.cs (Delegate::Delegate): Same here.
17919 * enum.cs (Enum::Enum): Same here.
17921 2001-09-05 Ravi Pratap <ravi@ximian.com>
17923 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
17925 * ../tests/cs0658.cs : New file to demonstrate error 0658.
17927 * attribute.cs (Attributes): New class to encapsulate all attributes which were
17928 being passed around as an arraylist.
17929 (Attributes::AddAttribute): Method to add attribute sections.
17931 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
17932 (struct_declaration): Update accordingly.
17933 (constant_declaration): Update.
17934 (field_declaration): Update.
17935 (method_header): Update.
17936 (fixed_parameter): Update.
17937 (parameter_array): Ditto.
17938 (property_declaration): Ditto.
17939 (destructor_declaration): Ditto.
17941 * class.cs (Struct::Struct): Update constructors accordingly.
17942 (Class::Class): Ditto.
17943 (Field::Field): Ditto.
17944 (Method::Method): Ditto.
17945 (Property::Property): Ditto.
17946 (TypeContainer::OptAttribute): update property's return type.
17948 * interface.cs (Interface.opt_attributes): New member.
17949 (Interface::Interface): Update to take the extra Attributes argument.
17951 * parameter.cs (Parameter::Parameter): Ditto.
17953 * constant.cs (Constant::Constant): Ditto.
17955 * interface.cs (InterfaceMemberBase): New OptAttributes field.
17956 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
17957 the attributes as a parameter.
17958 (InterfaceProperty): Update constructor call.
17959 (InterfaceEvent): Ditto.
17960 (InterfaceMethod): Ditto.
17961 (InterfaceIndexer): Ditto.
17963 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
17964 pass the attributes too.
17965 (interface_event_declaration): Ditto.
17966 (interface_property_declaration): Ditto.
17967 (interface_method_declaration): Ditto.
17968 (interface_declaration): Ditto.
17970 2001-09-05 Miguel de Icaza <miguel@ximian.com>
17972 * class.cs (Method::Define): Track the "static Main" definition to
17973 create an entry point.
17975 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
17976 EntryPoint if we find it.
17978 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
17979 (EmitContext::ig): Make this variable public.
17981 * driver.cs: Make the default output file be the first file name
17982 with the .exe extension.
17984 Detect empty compilations
17986 Handle various kinds of output targets. Handle --target and
17987 rename -t to --dumper.
17989 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
17990 methods inherited from Expression return now an Expression. This
17991 will is used during the tree rewriting as we resolve them during
17994 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
17995 the spec. Missing entirely is the information about
17996 accessability of elements of it.
17998 (Expression::ExprClassFromMemberInfo): New constructor for
17999 Expressions that creates a fully initialized Expression based on
18000 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
18003 (Invocation::Resolve): Begin implementing resolution of invocations.
18005 * literal.cs (StringLiteral): Implement Emit.
18007 2001-09-05 Ravi Pratap <ravi@ximian.com>
18009 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
18012 2001-09-04 Ravi Pratap <ravi@ximian.com>
18014 * cs-parser.jay (attribute_arguments): Implement actions.
18015 (attribute): Fix bug in production. Implement action.
18016 (attribute_list): Implement.
18017 (attribute_target): Implement.
18018 (attribute_target_specifier, opt_target_specifier): Implement
18019 (CheckAttributeTarget): New method to check if the attribute target
18021 (attribute_section): Implement.
18022 (opt_attributes): Implement.
18024 * attribute.cs : New file to handle attributes.
18025 (Attribute): Class to hold attribute info.
18027 * cs-parser.jay (opt_attribute_target_specifier): Remove production
18028 (attribute_section): Modify production to use 2 different rules to
18029 achieve the same thing. 1 s/r conflict down !
18030 Clean out commented, useless, non-reducing dimension_separator rules.
18032 * class.cs (TypeContainer.attributes): New member to hold list
18033 of attributes for a type.
18034 (Struct::Struct): Modify to take one more argument, the attribute list.
18035 (Class::Class): Ditto.
18036 (Field::Field): Ditto.
18037 (Method::Method): Ditto.
18038 (Property::Property): Ditto.
18040 * cs-parser.jay (struct_declaration): Update constructor call to
18041 pass in the attributes too.
18042 (class_declaration): Ditto.
18043 (constant_declaration): Ditto.
18044 (field_declaration): Ditto.
18045 (method_header): Ditto.
18046 (fixed_parameter): Ditto.
18047 (parameter_array): Ditto.
18048 (property_declaration): Ditto.
18050 * constant.cs (Constant::Constant): Update constructor similarly.
18051 Use System.Collections.
18053 * parameter.cs (Parameter::Parameter): Update as above.
18055 2001-09-02 Ravi Pratap <ravi@ximian.com>
18057 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
18058 (TypeContainer.delegates): New member to hold list of delegates.
18060 * cs-parser.jay (delegate_declaration): Implement the action correctly
18061 this time as I seem to be on crack ;-)
18063 2001-09-02 Miguel de Icaza <miguel@ximian.com>
18065 * rootcontext.cs (RootContext::IsNamespace): new function, used to
18066 tell whether an identifier represents a namespace.
18068 * expression.cs (NamespaceExpr): A namespace expression, used only
18069 temporarly during expression resolution.
18070 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
18071 utility functions to resolve names on expressions.
18073 2001-09-01 Miguel de Icaza <miguel@ximian.com>
18075 * codegen.cs: Add hook for StatementExpressions.
18077 * class.cs: Fix inverted test for static flag in methods.
18079 2001-09-02 Ravi Pratap <ravi@ximian.com>
18081 * class.cs (Operator::CheckUnaryOperator): Correct error number used
18082 to make it coincide with MS' number.
18083 (Operator::CheckBinaryOperator): Ditto.
18085 * ../errors/errors.txt : Remove error numbers added earlier.
18087 * ../errors/cs1019.cs : Test case for error # 1019
18089 * ../errros/cs1020.cs : Test case for error # 1020
18091 * cs-parser.jay : Clean out commented cruft.
18092 (dimension_separators, dimension_separator): Comment out. Ostensibly not
18093 used anywhere - non-reducing rule.
18094 (namespace_declarations): Non-reducing rule - comment out.
18096 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
18097 with TypeContainer::AddEnum.
18099 * delegate.cs : New file for delegate handling classes.
18100 (Delegate): Class for declaring delegates.
18102 * makefile : Update.
18104 * cs-parser.jay (delegate_declaration): Implement.
18106 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
18108 * class.cs (Event::Define): Implement.
18109 (Event.EventBuilder): New member.
18111 * class.cs (TypeContainer::Populate): Update to define all enums and events
18113 (Events): New property for the events arraylist we hold. Shouldn't we move to using
18114 readonly fields for all these cases ?
18116 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
18118 * class.cs (Property): Revamp to use the convention of making fields readonly.
18119 Accordingly modify code elsewhere.
18121 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
18122 the Define method of the Property class.
18124 * class.cs : Clean up applied patch and update references to variables etc. Fix
18126 (TypeContainer::Populate): Update to define all the properties we have. Also
18127 define all enumerations.
18129 * enum.cs (Define): Implement.
18131 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
18133 * cs-parser.jay (overloadable_operator): The semantic value is an
18134 enum of the Operator class.
18135 (operator_declarator): Implement actions.
18136 (operator_declaration): Implement.
18138 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
18139 validity of definitions.
18140 (Operator::CheckBinaryOperator): Static method to check for binary operators
18141 (TypeContainer::AddOperator): New method to add an operator to a type.
18143 * cs-parser.jay (indexer_declaration): Added line to actually call the
18144 AddIndexer method so it gets added ;-)
18146 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
18147 already taken care of by the MS compiler ?
18149 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
18151 * class.cs (Operator): New class for operator declarations.
18152 (Operator::OpType): Enum for the various operators.
18154 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
18156 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
18157 ostensibly handle this in semantic analysis.
18159 * cs-parser.jay (general_catch_clause): Comment out
18160 (specific_catch_clauses, specific_catch_clause): Ditto.
18161 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
18162 (catch_args, opt_catch_args): New productions.
18163 (catch_clause): Rewrite to use the new productions above
18164 (catch_clauses): Modify accordingly.
18165 (opt_catch_clauses): New production to use in try_statement
18166 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
18167 and re-write the code in the actions to extract the specific and
18168 general catch clauses by being a little smart ;-)
18170 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
18171 Hooray, try and catch statements parse fine !
18173 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
18175 * statement.cs (Block::GetVariableType): Fix logic to extract the type
18176 string from the hashtable of variables.
18178 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
18179 I end up making that mistake ;-)
18180 (catch_clauses): Fixed gross error which made Key and Value of the
18181 DictionaryEntry the same : $1 !!
18183 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
18185 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
18187 * cs-parser.jay (event_declaration): Correct to remove the semicolon
18188 when the add and remove accessors are specified.
18190 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
18192 * cs-parser.jay (IndexerDeclaration): New helper class to hold
18193 information about indexer_declarator.
18194 (indexer_declarator): Implement actions.
18195 (parsing_indexer): New local boolean used to keep track of whether
18196 we are parsing indexers or properties. This is necessary because
18197 implicit_parameters come into picture even for the get accessor in the
18198 case of an indexer.
18199 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
18201 * class.cs (Indexer): New class for indexer declarations.
18202 (TypeContainer::AddIndexer): New method to add an indexer to a type.
18203 (TypeContainer::indexers): New member to hold list of indexers for the
18206 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
18208 * cs-parser.jay (add_accessor_declaration): Implement action.
18209 (remove_accessor_declaration): Implement action.
18210 (event_accessors_declaration): Implement
18211 (variable_declarators): swap statements for first rule - trivial.
18213 * class.cs (Event): New class to hold information about event
18215 (TypeContainer::AddEvent): New method to add an event to a type
18216 (TypeContainer::events): New member to hold list of events.
18218 * cs-parser.jay (event_declaration): Implement actions.
18220 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
18222 * cs-parser.jay (dim_separators): Implement. Make it a string
18223 concatenating all the commas together, just as they appear.
18224 (opt_dim_separators): Modify accordingly
18225 (rank_specifiers): Update accordingly. Basically do the same
18226 thing - instead, collect the brackets here.
18227 (opt_rank_sepcifiers): Modify accordingly.
18228 (array_type): Modify to actually return the complete type string
18229 instead of ignoring the rank_specifiers.
18230 (expression_list): Implement to collect the expressions
18231 (variable_initializer): Implement. We make it a list of expressions
18232 essentially so that we can handle the array_initializer case neatly too.
18233 (variable_initializer_list): Implement.
18234 (array_initializer): Make it a list of variable_initializers
18235 (opt_array_initializer): Modify accordingly.
18237 * expression.cs (New::NType): Add enumeration to help us
18238 keep track of whether we have an object/delegate creation
18239 or an array creation.
18240 (New:NewType, New::Rank, New::Indices, New::Initializers): New
18241 members to hold data about array creation.
18242 (New:New): Modify to update NewType
18243 (New:New): New Overloaded contructor for the array creation
18246 * cs-parser.jay (array_creation_expression): Implement to call
18247 the overloaded New constructor.
18249 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
18251 * class.cs (TypeContainer::Constructors): Return member
18252 constructors instead of returning null.
18254 2001-08-26 Miguel de Icaza <miguel@ximian.com>
18256 * typemanager.cs (InitCoreTypes): Initialize the various core
18257 types after we have populated the type manager with the user
18258 defined types (this distinction will be important later while
18259 compiling corlib.dll)
18261 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
18262 on Expression Classification. Now all expressions have a method
18263 `Resolve' and a method `Emit'.
18265 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
18266 generation from working. Also add some temporary debugging
18269 2001-08-24 Miguel de Icaza <miguel@ximian.com>
18271 * codegen.cs: Lots of code generation pieces. This is only the
18272 beginning, will continue tomorrow with more touches of polish. We
18273 handle the fundamentals of if, while, do, for, return. Others are
18274 trickier and I need to start working on invocations soon.
18276 * gen-treedump.cs: Bug fix, use s.Increment here instead of
18279 * codegen.cs (EmitContext): New struct, used during code
18280 emission to keep a context. Most of the code generation will be
18283 * cs-parser.jay: Add embedded blocks to the list of statements of
18284 this block. So code generation proceeds in a top down fashion.
18286 2001-08-23 Miguel de Icaza <miguel@ximian.com>
18288 * statement.cs: Add support for multiple child blocks.
18290 2001-08-22 Miguel de Icaza <miguel@ximian.com>
18292 * codegen.cs (EmitCode): New function, will emit the code for a
18293 Block of code given a TypeContainer and its ILGenerator.
18295 * statement.cs (Block): Standard public readonly optimization.
18296 (Block::Block constructors): Link children.
18297 (Block::Child): Child Linker.
18298 (Block::EmitVariables): Emits IL variable declarations.
18300 * class.cs: Drop support for MethodGroups here, delay until
18302 (Method::): Applied the same simplification that I did before, and
18303 move from Properties to public readonly fields.
18304 (Method::ParameterTypes): Returns the parameter types for the
18305 function, and implements a cache that will be useful later when I
18306 do error checking and the semantic analysis on the methods is
18308 (Constructor::GetCallingConvention): Renamed from CallingConvetion
18309 and made a method, optional argument tells whether this is a class
18310 or a structure to apply the `has-this' bit.
18311 (Method::GetCallingConvention): Implement, returns the calling
18313 (Method::Define): Defines the type, a second pass is performed
18314 later to populate the methods.
18316 (Constructor::ParameterTypes): implement a cache similar to the
18317 one on Method::ParameterTypes, useful later when we do semantic
18320 (TypeContainer::EmitMethod): New method. Emits methods.
18322 * expression.cs: Removed MethodGroup class from here.
18324 * parameter.cs (Parameters::GetCallingConvention): new method.
18326 2001-08-21 Miguel de Icaza <miguel@ximian.com>
18328 * class.cs (TypeContainer::Populate): Drop RootContext from the
18331 (Constructor::CallingConvention): Returns the calling convention.
18332 (Constructor::ParameterTypes): Returns the constructor parameter
18335 (TypeContainer::AddConstructor): Keep track of default constructor
18336 and the default static constructor.
18338 (Constructor::) Another class that starts using `public readonly'
18339 instead of properties.
18341 (Constructor::IsDefault): Whether this is a default constructor.
18343 (Field::) use readonly public fields instead of properties also.
18345 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
18346 track of static constructors; If none is used, turn on
18347 BeforeFieldInit in the TypeAttributes.
18349 * cs-parser.jay (opt_argument_list): now the return can be null
18350 for the cases where there are no arguments.
18352 (constructor_declarator): If there is no implicit `base' or
18353 `this', then invoke the default parent constructor.
18355 * modifiers.cs (MethodAttr): New static function maps a set of
18356 modifiers flags into a MethodAttributes enum
18357 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
18358 MethodAttr, TypeAttr to represent the various mappings where the
18359 modifiers are used.
18360 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
18362 2001-08-19 Miguel de Icaza <miguel@ximian.com>
18364 * parameter.cs (GetParameterInfo): Fix bug where there would be no
18367 * interface.cs (PopulateIndexer): Implemented the code generator
18368 for interface indexers.
18370 2001-08-17 Miguel de Icaza <miguel@ximian.com>
18372 * interface.cs (InterfaceMemberBase): Now we track the new status
18375 (PopulateProperty): Implement property population. Woohoo! Got
18376 Methods and Properties going today.
18378 Removed all the properties for interfaces, and replaced them with
18379 `public readonly' fields.
18381 2001-08-16 Miguel de Icaza <miguel@ximian.com>
18383 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
18384 initialize their hashtables/arraylists only when they are needed
18385 instead of doing this always.
18387 * parameter.cs: Handle refs and out parameters.
18389 * cs-parser.jay: Use an ArrayList to construct the arguments
18390 instead of the ParameterCollection, and then cast that to a
18393 * parameter.cs: Drop the use of ParameterCollection and use
18394 instead arrays of Parameters.
18396 (GetParameterInfo): Use the Type, not the Name when resolving
18399 2001-08-13 Miguel de Icaza <miguel@ximian.com>
18401 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
18402 and instead use public readonly fields.
18404 * class.cs: Put back walking code for type containers.
18406 2001-08-11 Miguel de Icaza <miguel@ximian.com>
18408 * class.cs (MakeConstant): Code to define constants.
18410 * rootcontext.cs (LookupType): New function. Used to locate types
18413 2001-08-08 Miguel de Icaza <miguel@ximian.com>
18415 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
18416 this System.Reflection code is. Kudos to Microsoft
18418 * typemanager.cs: Implement a type cache and avoid loading all
18419 types at boot time. Wrap in LookupType the internals. This made
18420 the compiler so much faster. Wow. I rule!
18422 * driver.cs: Make sure we always load mscorlib first (for
18423 debugging purposes, nothing really important).
18425 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
18426 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
18428 * rootcontext.cs: Lookup types on their namespace; Lookup types
18429 on namespaces that have been imported using the `using' keyword.
18431 * class.cs (TypeContainer::TypeAttr): Virtualize.
18432 (Class::TypeAttr): Return attributes suitable for this bad boy.
18433 (Struct::TypeAttr): ditto.
18434 Handle nested classes.
18435 (TypeContainer::) Remove all the type visiting code, it is now
18436 replaced with the rootcontext.cs code
18438 * rootcontext.cs (GetClassBases): Added support for structs.
18440 2001-08-06 Miguel de Icaza <miguel@ximian.com>
18442 * interface.cs, statement.cs, class.cs, parameter.cs,
18443 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
18444 Drop use of TypeRefs, and use strings instead.
18446 2001-08-04 Miguel de Icaza <miguel@ximian.com>
18450 * class.cs (Struct::Struct): set the SEALED flags after
18451 checking the modifiers.
18452 (TypeContainer::TypeAttr): new property, returns the
18453 TypeAttributes for a class.
18455 * cs-parser.jay (type_list): Oops, list production was creating a
18456 new list of base types.
18458 * rootcontext.cs (StdLib): New property.
18459 (GetInterfaceTypeByName): returns an interface by type name, and
18460 encapsulates error handling here.
18461 (GetInterfaces): simplified.
18462 (ResolveTree): Encapsulated all the tree resolution here.
18463 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
18466 * driver.cs: Add support for --nostdlib, to avoid loading the
18467 default assemblies.
18468 (Main): Do not put tree resolution here.
18470 * rootcontext.cs: Beginning of the class resolution.
18472 2001-08-03 Miguel de Icaza <miguel@ximian.com>
18474 * rootcontext.cs: Provide better error reporting.
18476 * cs-parser.jay (interface_base): set our $$ to be interfaces.
18478 * rootcontext.cs (CreateInterface): Handle the case where there
18479 are no parent interfaces.
18481 (CloseTypes): Routine to flush types at the end.
18482 (CreateInterface): Track types.
18483 (GetInterfaces): Returns an array of Types from the list of
18484 defined interfaces.
18486 * typemanager.c (AddUserType): Mechanism to track user types (puts
18487 the type on the global type hash, and allows us to close it at the
18490 2001-08-02 Miguel de Icaza <miguel@ximian.com>
18492 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
18493 RecordInterface instead.
18495 * cs-parser.jay: Updated to reflect changes above.
18497 * decl.cs (Definition): Keep track of the TypeBuilder type that
18498 represents this type here. Not sure we will use it in the long
18499 run, but wont hurt for now.
18501 * driver.cs: Smaller changes to accomodate the new code.
18503 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
18506 * rootcontext.cs (CreateInterface): New method, used to create
18507 the System.TypeBuilder type for interfaces.
18508 (ResolveInterfaces): new entry point to resolve the interface
18510 (CodeGen): Property, used to keep track of the code generator.
18512 2001-07-26 Miguel de Icaza <miguel@ximian.com>
18514 * cs-parser.jay: Add a second production for delegate_declaration
18517 (enum_body): Put an opt_comma here instead of putting it on
18518 enum_body or enum_member_declarations so we can handle trailing
18519 commas on enumeration members. Gets rid of a shift/reduce.
18521 (type_list): Need a COMMA in the middle.
18523 (indexer_declaration): Tell tokenizer to recognize get/set
18525 * Remove old targets.
18527 * Re-add the parser target.
18529 2001-07-13 Simon Cozens <simon@simon-cozens.org>
18531 * cs-parser.jay: Add precendence rules for a number of operators
18532 ot reduce the number of shift/reduce conflicts in the grammar.
18534 2001-07-17 Miguel de Icaza <miguel@ximian.com>
18536 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
18539 Get rid of old crufty code.
18541 * rootcontext.cs: Use this to keep track of the parsed
18542 representation and the defined types available to the program.
18544 * gen-treedump.cs: adjust for new convention.
18546 * type.cs: Split out the type manager, and the assembly builder
18549 * typemanager.cs: the type manager will live here now.
18551 * cil-codegen.cs: And the code generator here.
18553 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
18555 * makefile: Fixed up for easy making.
18557 2001-07-13 Simon Cozens <simon@simon-cozens.org>
18559 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
18562 (unary_expression): Expand pre_increment_expression and
18563 post_decrement_expression to reduce a shift/reduce.
18565 2001-07-11 Simon Cozens
18567 * cs-tokenizer.cs: Hex numbers should begin with a 0.
18569 Improve allow_keyword_as_indent name.
18571 2001-06-19 Miguel de Icaza <miguel@ximian.com>
18573 * Adjustments for Beta2.
18575 2001-06-13 Miguel de Icaza <miguel@ximian.com>
18577 * decl.cs: Added `Define' abstract method.
18578 (InTransit): new property, used to catch recursive definitions.
18580 * interface.cs: Implement `Define'.
18582 * modifiers.cs: Map Modifiers.constants to
18583 System.Reflection.TypeAttribute flags.
18585 * class.cs: Keep track of types and user-defined types.
18586 (BuilderInit): New method for creating an assembly
18587 (ResolveType): New function to launch the resolution process, only
18588 used by interfaces for now.
18590 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
18591 that are inserted into the name space.
18593 2001-06-08 Miguel de Icaza <miguel@ximian.com>
18595 * ARGH. I have screwed up my tree so many times due to the use of
18596 rsync rather than using CVS. Going to fix this at once.
18598 * driver.cs: Objetify driver. Load assemblies, use assemblies to
18601 2001-06-07 Miguel de Icaza <miguel@ximian.com>
18603 * Experiment successful: Use System.Type rather that our own
18606 2001-05-25 Miguel de Icaza <miguel@ximian.com>
18608 * cs-parser.jay: Removed nsAliases from here.
18610 Use new namespaces, handle `using XXX;'
18612 * namespace.cs: Reimplemented namespace handling, use a recursive
18613 definition of the class. Now we can keep track of using clauses
18614 and catch invalid using clauses.
18616 2001-05-24 Miguel de Icaza <miguel@ximian.com>
18618 * gen-treedump.cs: Adapted for all the renaming.
18620 * expression.cs (Expression): this class now has a Type property
18621 which returns an expression Type.
18623 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
18624 `Type', as this has a different meaning now in the base
18626 2001-05-22 Miguel de Icaza <miguel@ximian.com>
18628 * interface.cs, class.cs: Removed from all the sources the
18629 references to signature computation, as we can not do method
18630 signature computation during the parsing time, as we are not
18631 trying to solve at that point distinguishing:
18635 void a (NS.Blah x) {}
18638 Which depending on the context might be valid or not, as we do not
18639 know if Blah is the same thing as NS.Blah at that point.
18641 * Redid everything so the code uses TypeRefs now instead of
18642 Types. TypeRefs are just temporary type placeholders, that need
18643 to be resolved. They initially have a pointer to a string and the
18644 current scope in which they are used. This is used later by the
18645 compiler to resolve the reference to an actual Type.
18647 * DeclSpace is no longer a CIR.Type, and neither are
18648 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
18649 are all DeclSpaces, but no Types.
18651 * type.cs (TypeRefManager): This implements the TypeRef manager,
18652 which keeps track of all the types that need to be resolved after
18653 the parsing has finished.
18655 2001-05-13 Miguel de Icaza <miguel@ximian.com>
18657 * ARGH. We are going to have to store `foreach' as a class rather
18658 than resolving it, as we need to verify error 1579 after name
18659 resolution. *OR* we could keep a flag that says `This request to
18660 IEnumerator comes from a foreach statement' which we can then use
18661 to generate the error.
18663 2001-05-10 Miguel de Icaza <miguel@ximian.com>
18665 * class.cs (TypeContainer.AddMethod): we now add methods to the
18666 MethodGroup instead of the method hashtable.
18668 * expression.cs: Add MethodGroup abstraction, which gets us one
18669 step closer to the specification in the way we handle method
18672 * cs-parser.jay (primary_expression): qualified_identifier now
18673 tried to match up an identifier to a local variable reference or
18674 to a parameter reference.
18676 current_local_parameters is now a parser global variable that
18677 points to the current parameters for the block, used during name
18680 (property_declaration): Now creates an implicit `value' argument to
18683 2001-05-09 Miguel de Icaza <miguel@ximian.com>
18685 * parameter.cs: Do not use `param' arguments as part of the
18686 signature, per the spec.
18688 2001-05-08 Miguel de Icaza <miguel@ximian.com>
18690 * decl.cs: Base class for classes, structs and interfaces. This
18691 is the "Declaration Space"
18693 * cs-parser.jay: Use CheckDef for checking declaration errors
18694 instead of having one on each function.
18696 * class.cs: Factor out some code for handling error handling in
18697 accordance to the "Declarations" section in the "Basic Concepts"
18698 chapter in the ECMA C# spec.
18700 * interface.cs: Make all interface member classes derive from
18701 InterfaceMemberBase.
18703 2001-05-07 Miguel de Icaza <miguel@ximian.com>
18705 * Many things: all interfaces are parsed and generated in
18706 gen-treedump. Support for member variables, constructors,
18707 destructors, properties, constants is there.
18709 Beginning of the IL backend, but very little done, just there for
18712 2001-04-29 Miguel de Icaza <miguel@ximian.com>
18714 * cs-parser.jay: Fix labeled statement.
18716 * cs-tokenizer.cs (escape): Escape " and ' always.
18717 ref_line, ref_name: keep track of the line/filename as instructed
18718 by #line by the compiler.
18721 2001-04-27 Miguel de Icaza <miguel@ximian.com>
18723 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
18724 to match the values in System.CodeDOM.
18726 Divid renamed to Divide.
18728 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
18730 (Statements.set): remove.
18732 * System.CodeDOM/CodeCatchClause.cs: always have a valid
18735 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
18736 falseStatements always have valid values.
18738 * cs-parser.jay: Use System.CodeDOM now.