1 2004-11-10 Martin Baulig <martin@localhost>
4 (TypeManager.IsPrivateAccessible): New public method.
5 (Closure.Filter): Use IsPrivateAccessible() instead of IsEqual().
7 2004-11-10 Martin Baulig <martin@ximian.com>
9 * class.cs (TypeContainer.DefineType): Call
10 TypeBuilder.DefineGenericParameters() before resolving the type
12 (MethodData.parent_method): New protected field.
13 (MethodData..ctor): Added `MethodInfo parent_method' argument.
14 (MethodData.Define): Compute `parent_method'.
17 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
18 (MemberCore.GetClsCompliantAttributeValue): Likewise.
19 (DeclSpace.ec): New protected field; store the EmitContext here.
20 (DeclSpace.EmitContext): New public property.
21 (DeclSpace.ResolveType): Un-comment from the [Obsolte] attribute.
22 (DeclSpace.ResolveNestedType): New public method.
23 (DeclSpace.ResolveTypeExpr): Just call ResolveAsTypeTerminal() here.
24 (DeclSpace.NestedAccessible): Added `Type tb' argument.
25 (DeclSpace.FamilyAccessible): Likewise.
26 (DeclSpace.FindType): Call ResolveNestedType() for nested types.
27 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
30 * delegate.cs (Delegate.Define): Store the EmitContext in the `ec'
33 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
34 (Enum.Emit): Don't create a new EmitContext.
36 2004-10-18 Martin Baulig <martin@ximian.com>
38 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
39 `Type' directly, but call ResolveType() on it.
40 (Catch.Resolve): Likewise.
41 (Foreach.Resolve): Likewise.
43 2004-10-18 Martin Baulig <martin@ximian.com>
45 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
46 `Type' directly, but call ResolveType() on it.
47 (Probe.DoResolve): Likewise.
48 (ArrayCreation.LookupType): Likewise.
49 (TypeOf.DoResolve): Likewise.
50 (SizeOf.DoResolve): Likewise.
52 2004-10-18 Raja R Harinath <rharinath@novell.com>
54 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
57 2004-10-17 John Luke <john.luke@gmail.com>
59 * class.cs (Operator.GetSignatureForError): use CSharpName
61 * parameter.cs (Parameter.GetSignatureForError): Returns
62 correct name even if was not defined.
64 2004-10-13 Raja R Harinath <rharinath@novell.com>
67 * class.cs (TypeContainer.EmitContext): New property.
68 (DefineNestedTypes): Create an emitcontext for each part.
69 (MethodCore.DoDefineParameters): Use container's emitcontext.
70 Pass type array to InternalParameters.
71 (MemberBase.DoDefine): Use container's emitcontext.
72 (FieldMember.Define): Likewise.
73 (Event.Define): Likewise.
74 (SetMethod.GetParameterInfo): Change argument to EmitContext.
75 Pass type array to InternalParameters.
76 (SetIndexerMethod.GetParameterInfo): Likewise.
77 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
78 * delegate.cs (Define): Pass emitcontext to
79 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
80 array to InternalParameters.
81 * expression.cs (ParameterReference.DoResolveBase): Pass
82 emitcontext to GetParameterInfo.
83 (ComposedCast.DoResolveAsTypeStep): Remove check on
85 * parameter.cs (Parameter.Resolve): Change argument to
86 EmitContext. Use ResolveAsTypeTerminal.
87 (Parameter.GetSignature): Change argument to EmitContext.
88 (Parameters.ComputeSignature): Likewise.
89 (Parameters.ComputeParameterTypes): Likewise.
90 (Parameters.GetParameterInfo): Likewise.
91 (Parameters.ComputeAndDefineParameterTypes): Likewise.
92 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
93 * support.cs (InternalParameters..ctor): Remove variant that takes
95 * typemanager.cs (system_intptr_expr): New.
96 (InitExpressionTypes): Initialize it.
98 2004-10-12 Chris Toshok <toshok@ximian.com>
100 * cs-parser.jay: fix location for try_statement and catch_clause.
102 2004-10-18 Martin Baulig <martin@ximian.com>
104 * class.cs (FieldMember.Define): Don't access the TypeExpr's
105 `Type' directly, but call ResolveType() on it.
106 (MemberBase.DoDefine): Likewise.
108 * expression.cs (New.DoResolve): Don't access the TypeExpr's
109 `Type' directly, but call ResolveType() on it.
110 (ComposedCast.DoResolveAsTypeStep): Likewise.
112 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
113 `Type' directly, but call ResolveType() on it.
115 2004-10-07 Raja R Harinath <rharinath@novell.com>
117 More DeclSpace.ResolveType avoidance.
118 * decl.cs (MemberCore.InUnsafe): New property.
119 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
120 with newly created EmitContext.
121 (FieldMember.Define): Likewise.
122 * delegate.cs (Delegate.Define): Likewise.
123 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
124 only if normal name-lookup fails.
125 (TypeExpr.DoResolve): Enable error-checking.
126 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
127 (SizeOf.DoResolve): Likewise.
128 (ComposedCast.DoResolveAsTypeStep): Likewise.
129 (StackAlloc.DoResolve): Likewise.
130 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
131 (Block.Unsafe): New property.
132 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
133 (Unsafe): Set 'unsafe' flag of contained block.
134 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
135 (Fixed.Resolve): Likewise.
136 (Catch.Resolve): Likewise.
137 (Using.ResolveLocalVariableDecls): Likewise.
138 (Foreach.Resolve): Likewise.
140 2004-10-05 John Luke <john.luke@gmail.com>
142 * cs-parser.jay: add location to error CS0175
144 2004-10-04 Miguel de Icaza <miguel@ximian.com>
146 * ecore.cs (Expression.Constantity): Add support for turning null
149 * const.cs (Const.Define): Allow constants to be reference types
150 as long as the value is Null.
152 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
154 * namespace.cs (NamespaceEntry.Using): No matter which warning
155 level is set, check if this namespace name has already been added.
157 2004-10-03 Ben Maurer <bmaurer@ximian.com>
159 * expression.cs: reftype [!=]= null should always use br[true,false].
162 2004-10-03 Marek Safar <marek.safar@seznam.cz>
165 * attribute.cs: Enum conversion moved to
166 GetAttributeArgumentExpression to be applied to the all
169 2004-10-01 Raja R Harinath <rharinath@novell.com>
171 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
172 * class.c (TypeContainer.DefineType): Flag error if
173 base types aren't accessible due to access permissions.
174 * decl.cs (DeclSpace.ResolveType): Move logic to
175 Expression.ResolveAsTypeTerminal.
176 (DeclSpace.ResolveTypeExpr): Thin layer over
177 Expression.ResolveAsTypeTerminal.
178 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
179 Refactor code into NestedAccess. Use it.
180 (DeclSpace.NestedAccess): New.
181 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
182 argument to silence errors. Check access permissions.
183 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
184 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
185 (Cast.DoResolve): Likewise.
186 (New.DoResolve): Likewise.
187 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
188 (TypeOf.DoResolve): Likewise.
190 * expression.cs (Invocation.BetterConversion): Return the Type of
191 the better conversion. Implement section 14.4.2.3 more faithfully.
192 (Invocation.BetterFunction): Make boolean. Make correspondence to
193 section 14.4.2.2 explicit.
194 (Invocation.OverloadResolve): Update.
195 (Invocation): Remove is_base field.
196 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
197 (Invocation.Emit): Likewise.
199 2004-09-24 Marek Safar <marek.safar@seznam.cz>
201 * cs-parser.jay: Reverted 642 warning fix.
203 2004-09-23 Marek Safar <marek.safar@seznam.cz>
206 * decl.cs (FindMemberWithSameName): Indexer can have more than
209 2004-09-23 Marek Safar <marek.safar@seznam.cz>
211 * expression.cs (LocalVariableReference.DoResolveLValue):
212 Do not report warning 219 for out values.
213 (EmptyExpression.Null): New member to avoid extra allocations.
215 2004-09-23 Marek Safar <marek.safar@seznam.cz>
217 * cs-parser.jay: Fix wrong warning 642 report.
219 * cs-tokenizer.cs (CheckNextToken): New helper;
220 Inspect next character if is same as expected.
222 2004-09-23 Martin Baulig <martin@ximian.com>
224 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
225 (Convert.ImplicitReferenceConversionExists): Likewise.
227 2004-11-09 Raja R Harinath <rharinath@novell.com>
229 * Makefile (DISTFILES): Comment out a few missing files.
231 2004-10-29 Raja R Harinath <rharinath@novell.com>
233 * Makefile (bootstrap_libs,bootstrap_libfiles): New.
234 (bootstrap-libs): New target. Invokes the net_2_0_bootstrap profile.
235 (gmcs.exe): Invoke bootstrap-libs.
236 (clean-local): Clean the net_2_0_bootstrap profile too.
237 (PROGRAM_INSTALL_DIR): New.
238 (install-local): Use it.
240 2004-10-13 Martin Baulig <martin@ximian.com>
242 * generic.cs (TypeManager.InflatedConstraints): New nested class.
243 (TypeParameter.DefineType): If we're a method type parameter and
244 that method is overriding something, "inflate" its constraints.
246 2004-10-12 Martin Baulig <martin@ximian.com>
248 * expression.cs (MemberAccess.DoResolve): If we're a SimpleName
249 and have type arguments, create and resolve a ConstructedType.
251 2004-10-12 Martin Baulig <martin@ximian.com>
253 * decl.cs (MemberCache.FindMemberToOverride): Use
254 TypeManager.IsEqual() to compare the parameters and Type.Equals()
255 to compare the invocationType.
257 * typemanager.cs (TypeManager.IsEqual): Added support for arrays.
258 When comparing two type parameters, only do the signature-only
259 comparision for method type parameters.
261 2004-10-11 Martin Baulig <martin@ximian.com>
263 * report.cs: Don't make --fatal abort on warnings, we have
264 -warnaserror for that.
266 2004-10-11 Martin Baulig <martin@ximian.com>
269 (TypeManager.IsEqualGenericType): Removed, use IsEqual() instead.
270 (TypeManager.IsEqual): Call ourself recursively instead of using
273 2004-10-11 Martin Baulig <martin@ximian.com>
275 * class.cs (TypeContainer.DefineType): Only call TypeParameter.Define()
276 on our own type parameters, not on the ones we inherit from a containing
279 * expression.cs (Invocation.InferType): Use `==', not `Equals()' for
282 * generic.cs (TypeParameter.Define): We may only be called once.
284 * pending.cs (Pending.InterfaceMethod): Call TypeManager.Real_IsEqual()
285 instead of TypeManager.IsEqual().
287 2004-09-28 Martin Baulig <martin@ximian.com>
290 (GenericConstraints.EffectiveBaseClass): New public property.
291 (TypeParameter.GenericConstraints): New public property.
292 (ConstructedType.CheckConstraints): Improved.
294 * convert.cs (Convert.TypeParam_EffectiveBaseType): New private method.
295 (Convert.TypeParameterConversion): New private method; use this in
296 ImplicitReferenceConversion() and ImplicitReferenceConversionExists()
297 for all conversions related to type parameters.
299 2004-09-24 Martin Baulig <martin@ximian.com>
301 * convert.cs (Convert.ImplicitReferenceConversion): Added implicit
302 type parameter conversions for type parameters which are known to
305 2004-09-24 Martin Baulig <martin@ximian.com>
307 * generic.cs (GenericConstraints): Added `IsReferenceType' and
308 `IsValueType' properties.
310 * support.cs (ReflectionConstraints): Use
311 Type.GetGenericParameterConstraints() instead of the old hack.
313 2004-09-24 Martin Baulig <martin@ximian.com>
315 * generic.cs (GenericConstraints): Moved here and made it an
318 * support.cs (GenericConstraints): Moved to generic.cs.
320 2004-09-24 Martin Baulig <martin@ximian.com>
323 (ReflectionConstraints): Un-nested this class and made it public.
326 (TypeManager.GetTypeParameterConstraints): New public method.
327 (TypeManager.HasConstructorConstraint): Use the attributes.
329 2004-09-24 Martin Baulig <martin@ximian.com>
331 * support.cs (GenericConstraints): Replaced `HasConstructor',
332 `IsReferenceType' and `IsValueType' with `Attributes'.
333 (ReflectionParameters.ReflectionConstraints): Removed the Create()
334 method and made the .ctor public.
336 * generic.cs (Constraints.Attributes): New public property.
337 (Constraints): Renamed `HasConstructor' -> `HasConstructorConstraint',
338 `IsReferenceType' -> `HasReferenceTypeConstraint' and
339 `IsValueType' -> `HasValueTypeConstraint'.
341 2004-09-23 Martin Baulig <martin@ximian.com>
343 * generic.cs (Constraints): Reflect latest runtime changes.
345 2004-09-23 Martin Baulig <martin@ximian.com>
347 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
348 (Convert.ImplicitReferenceConversionExists): Likewise.
350 2004-09-23 Marek Safar <marek.safar@seznam.cz>
352 * class.cs (Operator.Define): Add error 448 and 559 report.
354 2004-09-22 Marek Safar <marek.safar@seznam.cz>
356 * class.cs (MemberBase.IsTypePermitted): New protected
357 method for checking error CS0610.
359 2004-09-22 Marek Safar <marek.safar@seznam.cz>
361 * class.cs (TypeContainer.HasExplicitLayout): New property
362 Returns whether container has StructLayout attribute set Explicit.
363 (FieldMember): New abstract class for consts and fields.
364 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
365 (Field): Reuse FieldMember.
367 * const.cs (Const): Reuse FieldMember.
369 * rootcontext.cs: EmitConstants call moved to class.
371 2004-09-22 Martin Baulig <martin@ximian.com>
373 Marek and me just fixed one of our oldest bugs: #28562 :-)
375 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
377 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
378 we're an EnumConstant, just return that.
379 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
380 an EnumConstant. In this case, we need to use GetValueAsEnumType()
381 to get the value which'll actually be written into the attribute.
382 However, we have to use GetValue() to access the attribute's value
385 2004-09-22 Marek Safar <marek.safar@seznam.cz>
387 * constant.cs (Constant.IsNegative): New abstract property
390 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
391 (StackAlloc.DoResolve): Reused IsNegative.
393 2004-09-22 Martin Baulig <martin@ximian.com>
395 * typemanager.cs (TypeManager.LookupGenericTypeContainer): New
396 public method; like LookupTypeContainer, but also works for
399 * report.cs (Report.SymbolRelatedToPreviousError): Use
400 TypeManager.LookupGenericTypeContainer().
402 2004-09-22 Martin Baulig <martin@ximian.com>
404 Thanks to Peter Sestoft for this bug report.
406 * expression.cs (Conditional): If both the `trueExpr' and the
407 `falseExpr' is a NullLiteral, return a NullLiteral.
409 2004-09-22 Martin Baulig <martin@ximian.com>
411 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
412 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
413 for the "get_Current" call.
415 2004-09-21 Martin Baulig <martin@ximian.com>
417 * convert.cs (Convert.ImplicitReferenceConversion): When
418 converting to an interface type, first check whether we're
419 converting from a reference type.
421 2004-09-14 Martin Baulig <martin@ximian.com>
423 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
425 2004-09-14 Marek Safar <marek.safar@seznam.cz>
428 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
429 called and is obsolete then this member suppress message
430 when call is inside next [Obsolete] method or type.
432 * expression.cs: Use TestObsoleteMethodUsage member.
434 2004-09-14 Martin Baulig <martin@ximian.com>
436 * genericparser.cs: Removed.
438 2004-09-13 Marek Safar <marek.safar@seznam.cz>
440 * class.cs (MethodCore.CheckBase): Fix bug #65757.
442 2004-09-12 Marek Safar <marek.safar@seznam.cz>
444 * attribute.cs (Attribute.Resolve): Add error 653 report.
446 * class.cs (Class.ApplyAttributeBuilder): Add error 641
448 (Method.ApplyAttributeBuilder): Add error 685 report.
449 (Operator.Define): Add error 564 report.
451 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
453 * expression.cs (Invocation.DoResolve): Add error
456 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
459 2004-09-11 Marek Safar <marek.safar@seznam.cz>
461 * class.cs (ConstructorInitializer.Resolve):
462 Wrong error number (515->516).
464 2004-09-11 Marek Safar <marek.safar@seznam.cz>
466 * class.cs (Indexer.Define): Add error 631 report.
468 2004-09-11 Marek Safar <marek.safar@seznam.cz>
470 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
472 2004-09-11 Marek Safar <marek.safar@seznam.cz>
474 * expression.cs (Probe.DoResolve): Add error CS0241 report.
476 2004-09-10 Marek Safar <marek.safar@seznam.cz>
478 * cs-parser.jay: Added error CS0241 report.
480 2004-09-10 Raja R Harinath <rharinath@novell.com>
482 * cs-parser.jay (fixed_statement): Introduce a scope for the
483 declaration in the 'fixed' statement.
485 2004-09-09 Marek Safar <marek.safar@seznam.cz>
487 * cs-parser.jay: Added CS0230 error report.
489 2004-09-09 Marek Safar <marek.safar@seznam.cz>
491 * cs-parser.jay: Added errors CS0231 and CS0257 report.
493 2004-09-09 Marek Safar <marek.safar@seznam.cz>
495 * expression.cs (Argument.Resolve): Added error CS0192 and
498 2004-09-09 Marek Safar <marek.safar@seznam.cz>
500 C# 2.0 #pragma warning feature
502 * cs-tokenizer.cs (PreProcessPragma): New method;
503 Handles #pragma directive.
505 * report.cs (WarningRegions): New class; Support
506 class for #pragma warning directive. It tests whether
507 warning is enabled for a given line.
509 2004-09-08 Miguel de Icaza <miguel@ximian.com>
511 * const.cs: Add more descriptive error report, tahnks to
514 2004-09-08 Marek Safar <marek.safar@seznam.cz>
516 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
518 2004-09-07 Miguel de Icaza <miguel@ximian.com>
520 * expression.cs: Apply patch from Ben: Remove dead code from
521 ArrayCreation, and remove the TurnintoConstant call in const.cs,
522 as that code just threw an exception anwyays.
524 * const.cs: Remove the call to the turnintoconstant, for details
527 * literal.cs: The type of the null-literal is the null type; So
528 we use a placeholder type (literal.cs:System.Null, defined here)
531 * expression.cs (Conditional.DoResolve): Remove some old code that
532 is no longer needed, conversions have been fixed.
534 (ArrayCreationExpression.DoResolve): Return false if we fail to
535 resolve the inner expression.
537 2004-09-07 Raja R Harinath <rharinath@novell.com>
540 * cs-parser.jay (delegate_declaration): Record a delegate
541 declaration as a type declaration.
542 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
544 2004-09-06 Miguel de Icaza <miguel@ximian.com>
546 * parameter.cs: Do not crash if the type can not be resolved.
548 * expression.cs: Report errors with unsafe pointers, fixes #64896
550 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
552 * expression.cs: Pointer arith always needs to do a conv.i
553 if the operand is a long. fix 65320
555 2004-09-04 Marek Safar <marek.safar@seznam.cz>
557 Fixed cs0619-37.cs, cs0619-38.cs
559 * enum.cs (GetObsoleteAttribute): Removed.
561 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
562 on Enum member is double staged. The first is tested member
565 2004-09-04 Marek Safar <marek.safar@seznam.cz>
567 Fixed #56986, #63631, #65231
569 * class.cs: (TypeContainer.AddToMemberContainer): New method,
570 adds member to name container.
571 (TypeContainer.AddToTypeContainer): New method, adds type to
573 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
574 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
575 AddOperator): Simplified by reusing AddToMemberContainer.
576 (TypeContainer.UserDefinedStaticConstructor): Changed to property
578 (Method.CheckForDuplications): Fixed implementation to test all
580 (MemberBase): Detection whether member is explicit interface
581 implementation is now in constructor.
582 (MemberBase.UpdateMemberName): Handles IndexerName.
583 (Accessor): Changed to keep also location information.
584 (AbstractPropertyEventMethod): Is derived from MemberCore.
585 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
586 will be emited or not.
587 (PropertyBase.AreAccessorsDuplicateImplementation):
588 Tests whether accessors are not in collision with some method.
589 (Operator): Is derived from MethodCore to simplify common
592 * decl.cs (Flags.TestMethodDuplication): Test for duplication
594 (DeclSpace.AddToContainer): Adds the member to defined_names
595 table. It tests for duplications and enclosing name conflicts.
597 * enum.cs (EnumMember): Clean up to reuse the base structures
599 2004-09-03 Martin Baulig <martin@ximian.com>
601 Merged latest changes into gmcs. Please keep this comment in
602 here, it makes it easier for me to see what changed in MCS since
603 the last time I merged.
605 2004-09-03 Martin Baulig <martin@ximian.com>
607 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
608 into TypeContainer, to make partial classes work again.
610 2004-09-03 Martin Baulig <martin@ximian.com>
612 * rootcontext.cs (RootContext.V2): Removed.
614 2004-03-23 Martin Baulig <martin@ximian.com>
616 * expression.cs (Invocation.OverloadResolve): Added `bool
617 may_fail' argument and use it instead of the Location.IsNull() hack.
619 2004-09-09 Martin Baulig <martin@ximian.com>
621 * cs-parser.jay (namespace_declaration): Fixed CS0134 reporting.
623 2004-09-09 Martin Baulig <martin@ximian.com>
625 * generic.cs (TypeParameter.DefineType): Added support for
626 explicit interface methods.
628 2004-09-09 Martin Baulig <martin@ximian.com>
630 * README.Changes: New document. Started to list important changes
631 between MCS and GMCS here.
633 2004-09-08 Martin Baulig <martin@ximian.com>
636 (TypeContainer.CheckRecursiveDefinition): New protected method.
637 (TypeContainer.DefineType): Move the CS0146 check into
638 CheckRecursiveDefinition().
640 2004-09-06 Martin Baulig <martin@ximian.com>
642 * generic.cs (ConstructedType.CheckConstraints): Allow builtin
643 types for the constructor constraint.
645 2004-09-03 Martin Baulig <martin@ximian.com>
647 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
648 into TypeContainer, to make partial classes work again.
650 2004-09-03 Martin Baulig <martin@ximian.com>
652 * rootcontext.cs (RootContext.V2): Removed.
654 2004-03-23 Martin Baulig <martin@ximian.com>
656 * expression.cs (Invocation.OverloadResolve): Added `bool
657 may_fail' argument and use it instead of the Location.IsNull() hack.
659 2004-09-03 Martin Baulig <martin@ximian.com>
661 Merged latest changes into gmcs. Please keep this comment in
662 here, it makes it easier for me to see what changed in MCS since
663 the last time I merged.
665 2004-09-03 Raja R Harinath <rharinath@novell.com>
668 * expression.cs (BetterConversion): Don't allow either conversion
669 to be null. Remove redundant implicit conversion test when 'q ==
670 null' -- when this function is invoked, we already know that the
671 implicit conversion exists.
672 (BetterFunction): Assume that 'best' is non-null. Remove
673 redundant reimplementation of IsApplicable when 'best' is null.
674 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
676 (IsAncestralType): Extract from OverloadResolve.
677 (OverloadResolve): Make robust to the MethodGroupExpr being
678 unsorted. Implement all the logic of Section 14.5.5.1, and
679 support overloading of methods from multiple applicable types.
680 Clean up logic somewhat. Don't pass null methods to BetterFunction.
682 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
683 (RealError, Warning): Append type of report to related symbol.
685 2004-09-03 Marek Safar <marek.safar@seznam.cz>
687 * enum.cs: Fixed CLS-Compliance checks for enum members.
688 Error tests cs3008-8.cs, cs3014-8.cs
690 2004-09-02 Marek Safar <marek.safar@seznam.cz>
692 Fixed bug #62342, #63102
693 * class.cs: ImplementIndexer uses member.IsExplicitImpl
694 like ImplementMethod.
696 2004-09-02 Marek Safar <marek.safar@seznam.cz>
698 * attribute.cs (Attribute.GetAttributeArgumentExpression):
701 2004-09-02 Martin Baulig <martin@ximian.com>
703 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
704 TypeManager.GetArgumentTypes() rather than calling GetParameters()
707 2004-09-01 Marek Safar <marek.safar@seznam.cz>
709 C# 2.0 Static classes implemented
711 * class.cs (TypeContainer): instance_constructors,
712 initialized_fields, initialized_static_fields,
713 default_constructor, base_inteface_types are protected to be
714 accessible from StaticClass.
715 (TypeContainer.DefineDefaultConstructor): New virtual method
716 for custom default constructor generating
717 (StaticClass): New class to handle "Static classes" feature.
719 * cs-parser.jay: Handle static keyword on class like instance
722 * driver.cs: Added "/langversion" command line switch with two
723 options (iso-1, default).
725 2004-08-31 Marek Safar <marek.safar@seznam.cz>
727 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
729 2004-08-31 Miguel de Icaza <miguel@ximian.com>
731 * delegate.cs: Style.
733 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
735 * delegate.cs: Add seperate instance expr field for miguel.
737 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
739 * PointerArithmetic (Resolve): make sure we are not doing
740 pointer arith on void*. Also, make sure we are resolved
741 by not setting eclass until resolve.
743 All callers: Make sure that PointerArithmetic gets resolved.
745 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
747 * ArrayCreation (LookupType): If the type does not resolve
748 to an array, give an error.
750 2004-08-27 Marek Safar <marek.safar@seznam.cz>
752 * statement.cs (Try.Resolve): Fixed bug #64222
754 2004-08-27 Martin Baulig <martin@ximian.com>
757 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
760 2004-08-26 Marek Safar <marek.safar@seznam.cz>
762 * ecore.cs (Constantify): Get underlying type via
763 System.Enum.GetUnderlyingType to avoid StackOverflow on the
764 Windows in special cases.
766 2004-08-26 Marek Safar <marek.safar@seznam.cz>
768 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
769 for obtaining also private methods.
770 (GetRemoveMethod): Used GetRemoveMethod (true)
771 for obtaining also private methods.
773 2004-09-02 Martin Baulig <martin@ximian.com>
775 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
776 TypeManager.GetArgumentTypes() rather than calling GetParameters()
779 2004-08-27 Martin Baulig <martin@ximian.com>
782 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
785 2004-08-25 Martin Baulig <martin@ximian.com>
787 * support.cs (ReflectionParameters..ctor): If this is a generic
788 method, retrieve and store its type parameters.
789 (InternalParameters..ctor): Added `TypeParameter[]' argument.
790 (ReflectionParameters.GenericConstraints): The argument specifies
791 the type parameter, not the method parameter.
792 (InternalParameters.GenericConstraints): Likewise.
794 * generic.cs (TypeParameter.DefineType): Correctly handle
795 constraints wrt. generic methods in interfaces and their
798 2004-08-24 Martin Baulig <martin@ximian.com>
800 * generic.cs (TypeParameter.IsSubclassOf): New public method.
801 (Constraints.IsSubclassOf): New internal method.
803 * typemanager.cs (TypeManager.FindMembers): Added special support
804 for GenericTypeParameterBuilder's.
805 (TypeManager.IsSubclassOf, IsFamilyAccessible): Added support for
808 2004-08-24 Martin Baulig <martin@ximian.com>
811 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
812 this for accessibility checks.
813 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
814 IsNestedFamilyAccessible.
815 (TypeManager.IsSubclassOf): New method, do what the name actually
818 2004-08-24 Martin Baulig <martin@ximian.com>
820 * expression.cs (MemberAccess.DoResolve): When resolving ourselves
821 as a SimpleName, include the generic arity.
823 2004-08-24 Martin Baulig <martin@ximian.com>
825 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
826 MethodAttributes.HideBySig for operators.
828 2004-08-23 Martin Baulig <martin@ximian.com>
830 Back to the old error reporting system :-)
832 * report.cs (Message): Removed.
833 (Report.MessageData, ErrorData, WarningData): Removed.
834 (Report.Error, Warning): Back to the old system.
836 2004-08-23 Martin Baulig <martin@ximian.com>
838 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
840 * class.cs (TypeContainer.ParentContainer): New public virtual
841 method; replaces the explicit interface implementation.
842 (ClassPart.ParentContainer): Override.
844 2004-08-23 Martin Baulig <martin@ximian.com>
846 * statement.cs (Switch): Added support for constant switches; see
847 #59428 or test-285.cs.
849 2004-08-22 Marek Safar <marek.safar@seznam.cz>
852 * statement.cs (GetEnumeratorFilter): Removed useless
853 logic because C# specs is strict. GetEnumerator must be
856 2004-08-22 Martin Baulig <martin@ximian.com>
858 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
859 a switch and may break, reset the barrier. Fixes #59867.
861 2004-08-22 Marek Safar <marek.safar@seznam.cz>
863 CLS-Compliance speed up (~5% for corlib)
865 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
866 New method. Tests container for CLS-Compliant names
868 * class.cs (TypeContainer.VerifyClsName): New method.
869 Checks whether container name is CLS Compliant.
870 (Constructor): Implements IMethodData.
872 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
873 low-case table for CLS Compliance test.
874 (MemberCache.VerifyClsParameterConflict): New method.
875 Checks method parameters for CS3006 error.
877 * enum.cs (EnumMember): Is derived from MemberCore.
878 (Enum.VerifyClsName): Optimized for better performance.
880 2004-08-06 Marek Safar <marek.safar@seznam.cz>
882 * report.cs: Renamed Error_T to Error and changed all
885 2004-08-06 Marek Safar <marek.safar@seznam.cz>
887 * class.cs (TypeContainer.IndexerArrayList): New inner class
888 container for indexers.
889 (TypeContainer.DefaultIndexerName): New constant for default
890 indexer name. Replaced all "Item" with this constant.
891 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
893 * typemanager.cs (TypeManager.default_member_ctor): Cache here
894 DefaultMemberAttribute constructor.
896 2004-08-05 Martin Baulig <martin@ximian.com>
898 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
901 2004-08-05 Marek Safar <marek.safar@seznam.cz>
903 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
904 multi platforms problem.
906 * compiler.csproj: Included shared files.
908 2004-08-04 Marek Safar <marek.safar@seznam.cz>
910 Fix bug 60333, 55971 in the more general way
911 * attribute.cs (Attribute.GetAttributeArgumentExpression):
912 Added arg_type argument for constant conversion.
913 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
915 2004-08-04 Marek Safar <marek.safar@seznam.cz>
918 * class.cs (TypeContainer ): New inner classes MethodArrayList,
919 OperatorArrayList, MethodCoreArrayList for typecontainer
920 containers. Changed class member types to these new types.
921 (MethodArrayList.DefineMembers): Added test for CS0659.
923 2004-08-04 Miguel de Icaza <miguel@ximian.com>
925 * cfold.cs: Synchronize the folding with the code in expression.cs
926 Binary.DoNumericPromotions for uint operands.
928 * attribute.cs: Revert patch from Raja, it introduced a regression
929 while building Blam-1.2.1 (hard to isolate a test case).
931 2004-08-04 Marek Safar <marek.safar@seznam.cz>
935 (TypeContainer.Define): Renamed to DefineContainerMembers because of
937 (MethodCore.parent_method): New member. The method we're overriding
938 if this is an override method.
939 (MethodCore.CheckBase): Moved from Method class and made common.
940 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
942 (MethodCore.CheckForDuplications): New abstract method. For custom
943 member duplication search in a container
944 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
945 method and its return type.
946 (Event.conflict_symbol): New member. Symbol with same name in the
950 (MemberCache.FindMemberWithSameName): New method. The method
951 is looking for conflict with inherited symbols.
953 2004-08-04 Martin Baulig <martin@ximian.com>
955 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
957 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
959 2004-08-03 Marek Safar <marek.safar@seznam.cz>
961 * report.cs (Message): New enum for better error, warning reference in
963 (MessageData): New inner abstract class. It generally handles printing of
964 error and warning messages.
965 Removed unused Error, Warning, Message methods.
967 2004-08-03 Marek Safar <marek.safar@seznam.cz>
969 Fix for cs0592-8.cs test
971 (Attributable.ValidAttributeTargets): Made public.
972 (Attribute.ExplicitTarget): New member for explicit target value.
973 (Attribute.CheckTargets): Now we translate explicit attribute
974 target to Target here.
976 2004-08-03 Ben Maurer <bmaurer@ximian.com>
978 * ecore.cs (MethodGroupExpr): new IsBase property.
980 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
982 * delegate.cs (DelegateCreation): store a MethodGroupExpr
983 rather than an instance expr.
985 (DelegateCreation.Emit): Use the method group rather than
986 the instance expression. Also, if you have base.Foo as the
987 method for a delegate, make sure to emit ldftn, not ldftnvirt.
989 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
991 (NewDelegate.DoResolve): Only check for the existance of Invoke
992 if the method is going to be needed. Use MethodGroupExpr.
994 (NewDelegate.Emit): Remove, DelegateCreation implements this.
996 * expression.cs: For pointer arith., make sure to use
997 the size of the type, not the size of the pointer to
1000 2004-08-03 Marek Safar <marek.safar@seznam.cz>
1003 * class.cs (Class): Added error CS0502 test.
1005 2004-08-03 John Luke <jluke@cfl.rr.com>
1006 Raja R Harinath <rharinath@novell.com>
1009 * attribute.cs (Attribute.complained_before): New flag.
1010 (Attribute.ResolveType, Attribute.Resolve),
1011 (Attribute.DefinePInvokeMethod): Set it.
1012 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
1014 2004-08-03 Martin Baulig <martin@ximian.com>
1016 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
1017 use a user-defined operator; we still need to do numeric
1018 promotions in case one argument is a builtin type and the other
1019 one has an implicit conversion to that type. Fixes #62322.
1021 2004-08-18 Martin Baulig <martin@ximian.com>
1023 * class.cs (Method.Define): Use the correct method name when
1024 creating the MethodBuilder for a generic method.
1026 2004-08-17 Martin Baulig <martin@ximian.com>
1028 * generic.cs (Constraints): Support type parameter constraints.
1030 2004-08-16 Martin Baulig <martin@ximian.com>
1032 * cs-tokenizer.cs (Tokenizer.TypeOfParsing): New public property.
1033 (Token.GENERIC_DIMENSION): New token; this is returned if we
1034 encounter an unbound generic type in a typeof() expression.
1036 * cs-parser.jay (opt_type_argument_list): Added GENERIC_DIMENSION;
1037 this token is only generated while parsing a typeof() expression.
1038 (typeof_expression): Removed the old unbound_type hack.
1040 * generic.cs (TypeArguments.IsUnbound): New public property.
1042 * decl.cs (MemberName): Added support for unbound types.
1044 2004-08-14 Martin Baulig <martin@ximian.com>
1047 (TypeManager.IsEqualGenericInstance): New static method.
1048 (TypeManager.IsSubclassOrNestedChildOf, IsSubclassOf): This is
1049 just used to check accessibility, so follow the rules of 26.1.6.
1051 * expression.cs (MemberAccess.ResolveAsTypeStep): Return a
1052 ConstructedType instead of a TypeExpression if we have type arguments.
1054 * cs-parser.jay (typeof_expression): Support unbound generic types.
1056 * ecore.cs (UnboundTypeExpression): New public class.
1058 2004-08-12 Martin Baulig <martin@ximian.com>
1060 * typemanager.cs (TypeManager.IsNestedChildOf): Use
1061 TypeManager.IsEqual() rather than `=='.
1063 * decl.cs (DeclSpace.CheckAccessLevel): Use `tb.FullName' for
1064 generic instances as well.
1066 2004-08-12 Martin Baulig <martin@ximian.com>
1068 * expression.cs (Invocation.InferType): We can only infer method
1069 type parameters. Fixes #62647.
1071 2004-08-11 Martin Baulig <martin@ximian.com>
1073 * class.cs (TypeContainer.DefineType): Create the TypeBuilder
1074 before resolving the base classes.
1076 2004-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
1078 * Makefile: install .mdb file too.
1080 2004-08-05 Martin Baulig <martin@ximian.com>
1082 * ecore.cs (FieldExpr.DoResolveLValue): If we're resolving a field
1083 initializer, the current type is just the TypeBuilder, not the
1084 instantiated generic type.
1085 (FieldExpr.IsFieldInitializer): New public property.
1087 2004-08-04 Martin Baulig <martin@ximian.com>
1089 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
1091 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
1093 2004-08-03 Martin Baulig <martin@ximian.com>
1095 * class.cs (MethodData.Define): If we're an explicit
1096 implementation, remove the generic arity from the type name.
1098 2004-08-03 Martin Baulig <martin@ximian.com>
1100 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
1101 use a user-defined operator; we still need to do numeric
1102 promotions in case one argument is a builtin type and the other
1103 one has an implicit conversion to that type. Fixes #62322.
1105 2004-08-02 Martin Baulig <martin@ximian.com>
1107 * class.cs (TypeContainer.ifaces): Make this a `Type[]', not a
1109 (TypeContainer.GetClassBases): Return the unexpanded list of
1110 interfaces; we expand them later.
1111 (TypeContainer.DefineType): After creating the TypeBuilder, call
1112 TypeManager.ExpandInterfaces() to get an expanded and resolved
1115 * ecore.cs (TypeExpr.GetInterfaces): Removed
1117 * generics.cs (Constraints.InterfaceConstraints): Remove.
1118 (TypeParameter.DefineType): Call TypeManager.RegisterBuilder() to
1119 register the interface constraints.
1122 (TypeManager.AddUserType): Removed the `ifaces' argument.
1123 (TypeManager.AddTypeParameter): Likewise.
1124 (TypeManager.AddUserInterface): Removed, was unused.
1125 (TypeManager.RegisterBuilder): Take a `Type[]' instead of a
1126 `TypeExpr[]' array for the interfaces.
1127 (TypeManager.ExpandInterfaces): Call this after the TypeBuilder
1128 has been defined, returns a list of the resolved interfaces types.
1129 (TypeManager.GetInterfaces): Return a `Type[]', not a `TypeExpr[]'.
1130 (TypeManager.GetExplicitInterfaces): Likewise.
1132 2004-08-02 Martin Baulig <martin@ximian.com>
1134 * expression.cs (Invocation.EmitCall): If we're invoking a method
1135 on a type parameter, use the new `Constrained' prefix opcode.
1137 2004-08-02 Martin Baulig <martin@ximian.com>
1139 * statement.cs (LocalInfo.Flags): Added `IsThis'.
1140 (LocalInfo.IsThis): New public property.
1141 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
1143 2004-08-01 Martin Baulig <martin@ximian.com>
1145 * class.cs (TypeContainer.GetClassBases): Don't set the default
1146 here since we may get called from GetPartialBases().
1147 (TypeContainer.DefineType): If GetClassBases() didn't return a
1148 parent, use the default one.
1150 2004-07-30 Martin Baulig <martin@ximian.com>
1152 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
1154 * class.cs (SourceMethod): New public class, derive from the
1155 symbol writer's ISourceMethod.
1156 (Method): Use the new symbol writer API.
1158 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
1159 as argument and use the new symbol writer.
1162 (SourceFile): Implement the symbol writer's ISourceFile.
1163 (Location.SymbolDocument): Removed.
1164 (Location.SourceFile): New public property.
1166 * symbolwriter.cs: Use the new symbol writer API.
1168 2004-07-30 Raja R Harinath <rharinath@novell.com>
1170 * Makefile (install-local): Remove. Functionality moved to
1173 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
1175 * Makefile: Install mcs.exe.config file together with mcs.exe.
1176 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
1177 correct runtime version.
1179 2004-07-25 Martin Baulig <martin@ximian.com>
1182 (TypeContainer.RegisterOrder): Removed, this was unused.
1183 (TypeContainer, interface_order): Removed.
1184 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
1185 TypeContainer as argument since we can also be called with a
1186 `PartialContainer' for a partial class/struct/interface.
1187 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
1188 of checking whether we're an `Interface' - we could be a
1190 (PartialContainer.Register): Override; call
1191 AddClass()/AddStruct()/AddInterface() on our parent.
1193 * cs-parser.jay (interface_member_declaration): Add things to the
1194 `current_container', not the `current_class'.
1196 * rootcontext.cs (RegisterOrder): The overloaded version which
1197 takes an `Interface' was unused, removed.
1199 * typemanager.cs (TypeManager.LookupInterface): Return a
1200 `TypeContainer', not an `Interface'.
1201 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
1202 contain a `PartialContainer' for an interface, so check it's
1203 `Kind' to figure out what it is.
1205 2004-07-25 Martin Baulig <martin@ximian.com>
1207 * class.cs (Class.DefaultTypeAttributes): New public constant.
1208 (Struct.DefaultTypeAttributes): Likewise.
1209 (Interface.DefaultTypeAttributes): Likewise.
1210 (PartialContainer.TypeAttr): Override this and add the
1211 DefaultTypeAttributes.
1213 2004-07-25 Martin Baulig <martin@ximian.com>
1215 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
1216 we can just use the `Parent' field instead.
1218 2004-07-25 Martin Baulig <martin@ximian.com>
1220 * class.cs (TypeContainer.Emit): Renamed to EmitType().
1222 2004-07-25 Martin Baulig <martin@ximian.com>
1224 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
1225 our parts before defining any methods.
1226 (TypeContainer.VerifyImplements): Make this virtual.
1227 (ClassPart.VerifyImplements): Override and call VerifyImplements()
1228 on our PartialContainer.
1230 2004-07-25 Martin Baulig <martin@ximian.com>
1232 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
1234 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
1235 argument, we can just use the `Parent' field instead.
1238 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
1239 (MemberBase.DoDefine): Likewise.
1241 2004-07-24 Martin Baulig <martin@ximian.com>
1243 * decl.cs (MemberCore.Parent): New public field.
1244 (DeclSpace.Parent): Moved to MemberCore.
1246 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
1247 (MemberBase.ctor): Added TypeContainer argument, pass it to our
1249 (FieldBase, Field, Operator): Likewise.
1250 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
1251 (EventField, Event): Likewise.
1253 2004-07-23 Martin Baulig <martin@ximian.com>
1255 * class.cs (PartialContainer): New public class.
1256 (ClassPart): New public class.
1257 (TypeContainer): Added support for partial classes.
1258 (TypeContainer.GetClassBases): Splitted some of the functionality
1259 out into GetNormalBases() and GetPartialBases().
1261 * cs-tokenizer.cs (Token.PARTIAL): New token.
1262 (Tokenizer.consume_identifier): Added some hacks to recognize
1263 `partial', but only if it's immediately followed by `class',
1264 `struct' or `interface'.
1266 * cs-parser.jay: Added support for partial clases.
1268 2004-07-23 Martin Baulig <martin@ximian.com>
1270 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
1271 a `DeclSpace' and also made it readonly.
1272 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
1273 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
1274 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
1276 * cs-parser.jay: Pass the `current_class', not the
1277 `current_container' (at the moment, this is still the same thing)
1278 to a new Method, Property, Event, Indexer or Constructor.
1280 2004-07-23 Martin Baulig <martin@ximian.com>
1282 * cs-parser.jay (CSharpParser): Added a new `current_class' field
1283 and removed the `current_interface' one.
1284 (struct_declaration, class_declaration, interface_declaration):
1285 Set `current_class' to the newly created class/struct/interface;
1286 set their `Bases' and call Register() before parsing their body.
1288 2004-07-23 Martin Baulig <martin@ximian.com>
1290 * class.cs (Kind): New public enum.
1291 (TypeContainer): Made this class abstract.
1292 (TypeContainer.Kind): New public readonly field.
1293 (TypeContainer.CheckDef): New public method; moved here from
1295 (TypeContainer.Register): New public abstract method.
1296 (TypeContainer.GetPendingImplementations): New public abstract
1298 (TypeContainer.GetClassBases): Removed the `is_class' and
1299 `is_iface' parameters.
1300 (TypeContainer.DefineNestedTypes): Formerly known as
1302 (ClassOrStruct): Made this class abstract.
1304 * tree.cs (RootTypes): New public type.
1306 2004-07-20 Martin Baulig <martin@ximian.com>
1308 * tree.cs (Tree.RecordNamespace): Removed.
1309 (Tree.Namespaces): Removed.
1311 * rootcontext.cs (RootContext.IsNamespace): Removed.
1313 * cs-parser.jay (namespace_declaration): Just create a new
1314 NamespaceEntry here.
1316 2004-07-21 Lluis Sanchez Gual <lluis@novell.com>
1318 * Makefile: Install gmcs.exe.config file together with gmcs.exe.
1319 * gmcs.exe.config: Renamed from mcs.exe.config. Added supportedRuntime
1320 entry to make sure it runs in the correct runtime version.
1322 2004-07-18 Martin Baulig <martin@ximian.com>
1324 * generic.cs (ConstructedType.CheckConstraints): Improved
1325 constraints checking.
1327 2004-07-18 Martin Baulig <martin@ximian.com>
1329 * expression.cs (Invocation.BetterMethod): Call
1330 TypeManager.TypeToCoreType() on all types and removed my previous
1331 hack; we're already doig the right thing here.
1333 2004-07-17 Martin Baulig <martin@ximian.com>
1335 * decl.cs (MemberName.MakeName): Create the "class`1" names here.
1337 2004-07-16 Martin Baulig <martin@ximian.com>
1339 * iterators.cs: Added generics support.
1341 2004-07-16 Martin Baulig <martin@ximian.com>
1343 * iterators.cs: Rewrote this. We're now using one single Proxy
1344 class for both the IEnumerable and the IEnumerator interface and
1345 `Iterator' derives from Class so we can use the high-level API.
1347 * class.cs (TypeContainer.AddIterator): New method.
1348 (TypeContainer.DoDefineType): New protected virtual method, which
1349 is called from DefineType().
1350 (TypeContainer.DoDefineMembers): Call DefineType() and
1351 DefineMembers() on all our iterators.
1352 (TypeContainer.Emit): Call Emit() on all our iterators.
1353 (TypeContainer.CloseType): Call CloseType() on all our iterators.
1355 * codegen.cs (EmitContext.CurrentIterator): New public field.
1357 2004-07-15 Martin Baulig <martin@ximian.com>
1360 (TypeManager.not_supported_exception_type): New type.
1362 2004-07-14 Martin Baulig <martin@ximian.com>
1365 (TypeManager.generic_ienumerable_type): New type.
1366 (TypeManager.generic_ienumerator_type): New type.
1369 (RootContext.interfaces_first_stage): Added
1370 "System.Collections.Generic.IEnumerator`1" and
1371 "System.Collections.Generic.IEnumerable`1".
1373 2004-07-14 Martin Baulig <martin@ximian.com>
1375 * iterators.cs: Use real error numbers.
1377 2004-07-14 Martin Baulig <martin@ximian.com>
1379 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
1380 requires this to be a System.Collection.IEnumerable and not a
1381 class implementing that interface.
1382 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
1384 2004-07-13 Marek Safar <marek.safar@seznam.cz>
1386 * class.cs: Fixed previous fix, it broke some error tests.
1388 2004-07-12 Martin Baulig <martin@ximian.com>
1390 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
1393 2004-07-14 Martin Baulig <martin@ximian.com>
1395 * decl.cs, expression.cs, generic.cs: Use a backqoute (`) and not
1396 an exclamation mark (!) for the generic arity to reflect the
1397 latest spec changes; ie. use "System.Collections.Generic.IList`1".
1399 2004-07-13 Martin Baulig <martin@ximian.com>
1401 * cs-tokenizer.cs (Tokenizer.parse_less_than): Allow array rank
1402 specifiers being part of a type argument.
1404 2004-07-13 Martin Baulig <martin@ximian.com>
1406 * expression.cs (MemberAccess.ResolveAsTypeStep): Use the full `!'
1407 name for generic types.
1409 2004-07-13 Martin Baulig <martin@ximian.com>
1411 * assign.cs (Assign.DoResolve): Moved the CS0131 check up a little
1414 2004-07-09 Miguel de Icaza <miguel@ximian.com>
1416 * assign.cs (LocalTemporary): Add new argument: is_address,If
1417 `is_address' is true, then the value that we store is the address
1418 to the real value, and not the value itself.
1420 * ecore.cs (PropertyExpr): use the new local temporary
1421 stuff to allow us to handle X.Y += z (where X is a struct)
1423 2004-07-08 Martin Baulig <martin@ximian.com>
1425 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
1426 not always return, just like we're doing in Using.Resolve().
1428 2004-07-07 Miguel de Icaza <miguel@ximian.com>
1430 * cs-parser.jay (fixed_statement): flag this as Pinned.
1432 2004-07-06 Miguel de Icaza <miguel@ximian.com>
1434 * typemanager.cs (TypeManager): Removed MakePinned method, this
1435 mechanism is replaced with the .NET 2.x compatible mechanism of
1436 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
1438 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
1439 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
1440 `IsFixed' property which has a different meaning.
1442 2004-07-02 Raja R Harinath <rharinath@novell.com>
1444 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
1445 visible from inside a nested class, not just the names of the
1446 immediately enclosing class.
1449 2004-06-24 Raja R Harinath <rharinath@novell.com>
1451 * expression.cs (BetterConversion): Remove buggy special-case
1452 handling of "implicit constant expression conversions". At this
1453 point, we already know that the conversion is possible -- we're
1454 only checking to see which is better.
1456 2004-06-24 Marek Safar <marek.safar@seznam.cz>
1458 * cs-parser.jay: Added error CS0210 test.
1460 2004-06-24 Marek Safar <marek.safar@seznam.cz>
1462 * cs-parser.jay: Added error CS0134 test.
1464 2004-06-24 Marek Safar <marek.safar@seznam.cz>
1467 * cs-parser.jay: Added error CS0145 test.
1469 2004-06-24 Marek Safar <marek.safar@seznam.cz>
1471 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
1473 2004-06-23 Ben Maurer <bmaurer@ximian.com>
1475 * expression.cs (StackAlloc.Resolve): The argument may not
1476 be a constant; deal with this case.
1478 2004-06-23 Marek Safar <marek.safar@seznam.cz>
1480 * attribute.cs (IndexerName_GetIndexerName): Renamed to
1481 GetIndexerAttributeValue.
1482 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
1484 * class.cs (Indexer.Define): Added error tests for CS0415,
1487 2004-06-23 Miguel de Icaza <miguel@ximian.com>
1489 * attribute.cs (Attribute.Resolve): Keep field code in sync with
1492 2004-06-23 Martin Baulig <martin@ximian.com>
1494 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
1495 neither return nor throw, reset the barrier as well. Fixes #60457.
1497 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
1499 * class.cs : EventAttributes is now set to None by default.
1500 This fixes bug #60459.
1502 2004-06-18 Marek Safar <marek.safar@seznam.cz>
1505 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
1506 Don't throw exception but return null (it's sufficient now).
1508 2004-06-18 Marek Safar <marek.safar@seznam.cz>
1510 * typemanager.cs (GetArgumentTypes): Faster implementation.
1512 2004-06-18 Martin Baulig <martin@ximian.com>
1514 * attribute.cs (Attribute.Resolve): Check whether we're an
1515 EmptyCast which a Constant child. Fixes #60333.
1517 2004-06-17 Ben Maurer <bmaurer@ximian.com>
1519 * statement.cs (EmitCollectionForeach): Account for the fact that
1520 not all valuetypes are in areas which we can take the address of.
1521 For these variables, we store to a temporary variable. Also, make
1522 sure that we dont emit a `callvirt' on a valuetype method.
1524 2004-06-15 Marek Safar <marek.safar@seznam.cz>
1526 * expression.cs (StackAlloc.DoReSolve): Added test for
1527 negative parameter (CS0247).
1529 2004-06-15 Marek Safar <marek.safar@seznam.cz>
1532 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
1534 2004-06-15 Marek Safar <marek.safar@seznam.cz>
1537 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
1540 2004-06-14 Marek Safar <marek.safar@seznam.cz>
1542 Fix bug #58254 & cs1555.cs, cs1556.cs
1543 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
1545 2004-06-14 Marek Safar <marek.safar@seznam.cz>
1547 * cs-parser.jay: Added error CS1669 test for indexers.
1549 2004-06-18 Martin Baulig <martin@ximian.com>
1551 * generics.cs (GenericMethod.ctor): Don't take an Attributes
1552 argument. Fixes #60441.
1554 2004-06-16 Ben Maurer <bmaurer@ximian.com>
1555 * ecore.cs (MethodGroupExpr.Name): Revert Martin's patch.
1556 The name needs to have the actual name of the method in order
1557 for other tests (such as the one in OverloadResolve for Invoke
1558 on a delegate) to work. As well, it does not really help
1559 error reporting because the method group had multiple methods.
1560 * Makefile: Remove MCS_DEBUG, you can enable with the DEBUG_FLAGS.
1561 Make profiling work.
1563 2004-06-13 Martin Baulig <martin@ximian.com>
1565 * cs-parser.jay: Don't allow generic attributes.
1567 2004-06-13 Martin Baulig <martin@ximian.com>
1569 * class.cs (MemberBase.DoDefineBase): New protected method.
1570 (MemberBase.DoDefine): Compute the `flags' in the new
1571 DoDefineBase() which must be called first.
1572 (Method.Define): Call DoDefineBase() first so we have the flags
1573 when defining the generic method.
1575 * cs-parser.jay (interface_method_declaration): Support generic methods.
1577 2004-06-13 Martin Baulig <martin@ximian.com>
1579 * decl.cs (TypeName): Removed.
1580 (MemberName): Removed TypeName and MemberNow; now we just have
1583 * cs-parser.jay: Don't distinguish between type arguments and type
1584 parameters in the grammar and simplified the rules a bit. The
1585 reduce/reduce conflicts are now gone (except the one we inherited
1588 2004-06-11 Martin Baulig <martin@ximian.com>
1590 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
1591 call this twice: for params and varargs methods.
1593 2004-06-11 Marek Safar <marek.safar@seznam.cz>
1596 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
1598 2004-06-11 Marek Safar <marek.safar@seznam.cz>
1600 * attribute.cs (Attribute.GetValidTargets): Made public.
1603 (AbstractPropertyEventMethod): New class for better code sharing.
1604 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
1606 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
1608 2004-06-09 Martin Baulig <martin@ximian.com>
1610 * cs-parser.jay: Removed a reduce/reduce conflict.
1612 2004-06-03 Martin Baulig <martin@ximian.com>
1614 * generic.cs (ConstructedType.GetMemberAccess): Renamed to
1615 GetSimpleName() and return a SimpleName.
1617 * ecore.cs (SimpleName.Arguments): New public field.
1618 (SimpleName): Added overloaded ctor which takes an additional
1619 TypeArguments argument.
1620 (SimpleName.SimpleNameResolve): Added support for generic methods.
1621 (MethodGroupExpr.ResolveGeneric): New public method. The code was
1622 formerly in MemberAccess.DoResolve(), but we also need it in
1623 SimpleNameResolve().
1625 * expression.cs (MemberAccess.DoResolve): Use the new
1626 MethodGroupExpr.ResolveGeneric().
1628 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
1630 * decl.cs: If possible, use lookuptypedirect here. We can only do
1631 this if there is no `.' after the namespace. Avoids using
1632 LookupType, which does lots of slow processing.
1633 (FindNestedType) New method, does what it says :-).
1634 * namespace.cs: use LookupTypeDirect.
1635 * rootcontext.cs: use membercache, if possible.
1636 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
1638 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
1641 According to the spec,
1643 In a member access of the form E.I, if E is a single identifier,
1644 and if the meaning of E as a simple-name (§7.5.2) is a constant,
1645 field, property, localvariable, or parameter with the same type as
1646 the meaning of E as a type-name (§3.8), then both possible
1647 meanings of E are permitted.
1649 We did not check that E as a simple-name had the same type as E as
1652 This trivial check gives us 5-7% on bootstrap time.
1654 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
1656 * expression.cs (Invocation.OverloadResolve): Avoid the
1657 use of hashtables and boxing here by allocating on demand.
1659 2004-05-30 Martin Baulig <martin@ximian.com>
1661 * rootcontext.cs (RootContext.LookupType): Don't cache things if
1662 we're doing a silent lookup. Don't try to lookup nested types in
1663 TypeManager.object_type (thanks to Ben Maurer).
1665 2004-05-30 Martin Baulig <martin@ximian.com>
1667 Committing a patch from Ben Maurer.
1669 * rootcontext.cs (RootContext.LookupType): Cache negative results.
1671 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
1673 * convert.cs: add a trivial cache for overload operator resolution.
1675 2004-05-31 Marek Safar <marek.safar@seznam.cz>
1678 (AttributeTester.GetObsoleteAttribute): Returns instance of
1679 ObsoleteAttribute when type is obsolete.
1682 (TypeContainer.VerifyObsoleteAttribute): Override.
1683 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
1684 (MethodCode.VerifyObsoleteAttribute): Override.
1685 (MemberBase.VerifyObsoleteAttribute): Override.
1688 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
1689 and report proper error.
1692 (Delegate.VerifyObsoleteAttribute): Override.
1695 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
1696 and report proper error.
1697 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
1700 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
1704 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
1705 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
1706 Added test for ObsoleteAttribute.
1709 (Catch): Derived from Statement.
1711 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
1713 * decl.cs: If possible, use lookuptypedirect here. We can only do
1714 this if there is no `.' after the namespace. Avoids using
1715 LookupType, which does lots of slow processing.
1716 (FindNestedType) New method, does what it says :-).
1717 * namespace.cs: use LookupTypeDirect.
1718 * rootcontext.cs: use membercache, if possible.
1719 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
1721 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
1724 According to the spec,
1726 In a member access of the form E.I, if E is a single identifier,
1727 and if the meaning of E as a simple-name (§7.5.2) is a constant,
1728 field, property, localvariable, or parameter with the same type as
1729 the meaning of E as a type-name (§3.8), then both possible
1730 meanings of E are permitted.
1732 We did not check that E as a simple-name had the same type as E as
1735 This trivial check gives us 5-7% on bootstrap time.
1737 2004-05-30 Marek Safar <marek.safar@seznam.cz>
1739 Fixed bug #59071 & cs0160.cs
1740 * statement.cs (Try.Resolve): Check here whether order of catch
1741 clauses matches their dependencies.
1743 2004-05-30 Marek Safar <marek.safar@seznam.cz>
1746 * ecore.cs (SimpleName.SimpleNameResolve): Added test for
1749 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
1751 * expression.cs (Invocation.OverloadResolve): Avoid the
1752 use of hashtables and boxing here by allocating on demand.
1754 2004-05-30 Martin Baulig <martin@ximian.com>
1756 * rootcontext.cs (RootContext.LookupType): Don't cache things if
1757 we're doing a silent lookup. Don't try to lookup nested types in
1758 TypeManager.object_type (thanks to Ben Maurer).
1760 2004-05-30 Martin Baulig <martin@ximian.com>
1762 Committing a patch from Ben Maurer.
1764 * rootcontext.cs (RootContext.LookupType): Cache negative results.
1766 2004-05-29 Martin Baulig <martin@ximian.com>
1768 * class.cs (IMethodData.ShouldIgnore): New method.
1770 * typemanager.cs (TypeManager.MethodFlags): Don't take a
1771 `Location' argument, we don't need it anywhere. Use
1772 `IMethodData.ShouldIgnore ()' instead of
1773 `MethodData.GetMethodFlags ()'.
1774 (TypeManager.AddMethod): Removed.
1775 (TypeManager.AddMethod2): Renamed to AddMethod.
1777 2004-05-29 Martin Baulig <martin@ximian.com>
1779 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
1781 * convert.cs (Convert.ImplicitReferenceConversion): If we're
1782 converting from a class type S to an interface type and we already
1783 have an object on the stack, don't box it again. Fixes #52578.
1785 2004-05-29 Martin Baulig <martin@ximian.com>
1787 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
1788 Added support for `params' parameters. Fixes #59267.
1790 2004-05-29 Martin Baulig <martin@ximian.com>
1792 * literal.cs (NullPointer): Provide a private .ctor which sets
1793 `type' to TypeManager.object_type. Fixes #59048.
1795 2004-05-29 Martin Baulig <martin@ximian.com>
1797 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
1798 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
1800 * ecore.cs (EventExpr.instance_expr): Make the field private.
1802 2004-05-26 Marek Safar <marek.safar@seznam.cz>
1804 Fixed bug #50080 & cs0214-2.cs
1805 * expression.cs (Cast.DoResolve): Check unsafe context here.
1807 * statement.cs (Resolve.DoResolve): Likewise.
1809 2004-05-26 Martin Baulig <martin@ximian.com>
1811 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
1813 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
1814 (RootContext.LookupType): Pass down the `silent' flag.
1816 2004-05-25 Martin Baulig <martin@ximian.com>
1819 (MethodGroupExpr.IdenticalTypeName): New public property.
1820 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
1821 expression actually refers to a type.
1823 2004-05-25 Martin Baulig <martin@ximian.com>
1825 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
1826 for #56176 and made it actually work.
1828 2004-05-25 Martin Baulig <martin@ximian.com>
1830 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
1831 (FieldExpr, PropertyExpr): Override and implement
1832 CacheTemporaries. Fixes #52279.
1834 2004-05-25 Miguel de Icaza <miguel@ximian.com>
1836 * location.cs: In the new compiler listing a file twice is a
1837 warning, not an error.
1839 2004-05-24 Martin Baulig <martin@ximian.com>
1841 * enum.cs (Enum.DefineType): For the `BaseType' to be a
1842 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
1844 2004-05-24 Martin Baulig <martin@ximian.com>
1846 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
1847 walking the `using' list. Fixes #53921.
1849 2004-05-24 Martin Baulig <martin@ximian.com>
1851 * const.cs (Const.LookupConstantValue): Added support for
1852 EmptyCast's; fixes #55251.
1854 2004-05-24 Martin Baulig <martin@ximian.com>
1856 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
1857 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
1858 which does the CS0135 check. The reason is that we first need to
1859 check whether the variable actually exists.
1861 2004-05-24 Martin Baulig <martin@ximian.com>
1863 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
1864 than RootContext.LookupType() to find the explicit interface
1867 2004-05-24 Raja R Harinath <rharinath@novell.com>
1869 * Makefile: Simplify. Use executable.make.
1870 * mcs.exe.sources: New file. List of sources of mcs.exe.
1872 2004-05-24 Anders Carlsson <andersca@gnome.org>
1876 Use the invariant culture when doing String.Compare for CLS case
1879 2004-05-23 Martin Baulig <martin@ximian.com>
1881 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
1882 don't have any dots. Fixes #52622, added cs0246-8.cs.
1884 * namespace.cs (NamespaceEntry.Lookup): Likewise.
1886 2004-05-23 Marek Safar <marek.safar@seznam.cz>
1888 * class.cs (MemberBase.Define): Reuse MemberType member for
1889 resolved type. Other methods can use it too.
1891 2004-05-23 Martin Baulig <martin@ximian.com>
1893 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
1894 the variable also exists in the current block (otherwise, we need
1895 to report a CS0103). Fixes #58670.
1897 2004-05-23 Martin Baulig <martin@ximian.com>
1899 * flowanalysis.cs (Reachability.Reachable): Compute this
1900 on-the-fly rather than storing it as a field.
1902 2004-05-23 Martin Baulig <martin@ximian.com>
1904 * flowanalysis.cs (Reachability.And): Manually compute the
1905 resulting `barrier' from the reachability.
1907 2004-05-23 Marek Safar <marek.safar@seznam.cz>
1910 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
1911 instance of ObsoleteAttribute when symbol is obsolete.
1914 (IMethodData): Extended interface for ObsoleteAttribute support.
1916 2004-05-22 Marek Safar <marek.safar@seznam.cz>
1918 * attribute.cs: Fix bug #55970
1920 2004-05-22 Marek Safar <marek.safar@seznam.cz>
1924 (GetObsoleteAttribute): New method. Creates the instance of
1926 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
1927 ObsoleteAttribute when member is obsolete.
1928 (AttributeTester.Report_ObsoleteMessage): Common method for
1929 Obsolete error/warning reporting.
1932 (TypeContainer.base_classs_type): New member for storing parent type.
1935 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
1936 for this MemberCore.
1938 2004-05-21 Marek Safar <marek.safar@seznam.cz>
1940 * attribute.cs, const.cs: Fix bug #58590
1942 2004-05-21 Martin Baulig <martin@ximian.com>
1944 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
1945 out parameters if the end of the method is unreachable. Fixes
1948 2004-05-21 Marek Safar <marek.safar@seznam.cz>
1950 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
1951 Hari was right, why extra method.
1953 2004-05-21 Marek Safar <marek.safar@seznam.cz>
1955 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
1957 2004-05-20 Martin Baulig <martin@ximian.com>
1959 * delegate.cs: Convert this file to Unix mode - like the original
1962 2004-05-20 Martin Baulig <martin@ximian.com>
1964 * attribute.cs: Convert this file to Unix mode - like the original
1967 2004-05-19 Marek Safar <marek.safar@seznam.cz>
1969 Fix bug #58688 (MCS does not report error when the same attribute
1972 * attribute.cs (Attribute.Emit): Distinction between null and default.
1974 2004-05-19 Raja R Harinath <rharinath@novell.com>
1976 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
1977 of a top-level attribute without an attribute target.
1978 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
1980 (Attribute.Conditional_GetConditionName),
1981 (Attribute.Obsolete_GetObsoleteMessage): Update.
1982 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
1983 part of ScanForIndexerName.
1984 (Attribute.CanIgnoreInvalidAttribute): New function.
1985 (Attribute.ScanForIndexerName): Move to ...
1986 (Attributes.ScanForIndexerName): ... here.
1987 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
1988 (Attributes.Search): New internal variant that can choose not to
1989 complain if types aren't resolved. The original signature now
1991 (Attributes.GetClsCompliantAttribute): Use internal variant, with
1992 complaints suppressed.
1993 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
1994 only if it not useful.
1995 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
1996 top-level for attributes that are shared between the assembly
1997 and a top-level class.
1998 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
1999 * class.cs: Update to reflect changes.
2000 (DefineIndexers): Fuse loops.
2001 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
2002 a couple more variants of attribute names.
2004 2004-05-18 Marek Safar <marek.safar@seznam.cz>
2006 Fix bug #52585 (Implemented explicit attribute declaration)
2009 (Attributable.ValidAttributeTargets): New abstract method. It gets
2010 list of valid attribute targets for explicit target declaration.
2011 (Attribute.Target): It holds target itself.
2012 (AttributeSection): Removed.
2013 (Attribute.CheckTargets): New method. It checks whether attribute
2014 target is valid for the current element.
2017 (EventProperty): New class. For events that are declared like
2018 property (with add and remove accessors).
2019 (EventField): New class. For events that are declared like field.
2022 * cs-parser.jay: Implemented explicit attribute target declaration.
2024 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
2025 Override ValidAttributeTargets.
2028 (ReturnParameter): Class for applying custom attributes on
2030 (ParameterAtribute): New class. Class for applying custom
2031 attributes on the parameter type.
2033 2004-05-17 Miguel de Icaza <miguel@ximian.com>
2035 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
2038 (Method): Allow UNSAFE here.
2040 * modifiers.cs: Support unsafe reporting.
2042 2004-05-17 Marek Safar <marek.safar@seznam.cz>
2044 * decl.cs: Fix bug #58478.
2046 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
2048 * statement.cs: When checking for unreachable code on an EmptyStatement,
2049 set the location. Fixes bug #58488.
2051 2004-05-13 Miguel de Icaza <miguel@ximian.com>
2053 * driver.cs: Add -pkg handling.
2055 From Gonzalo: UseShelLExecute=false
2057 2004-05-12 Marek Safar <marek.safar@seznam.cz>
2060 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
2062 (Attribute.IsClsCompliaceRequired): Moved to base for better
2064 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
2065 when attribute is AttributeUsageAttribute.
2066 (Attribute.GetValidTargets): Simplified.
2067 (Attribute.GetAttributeUsage): New method returns AttributeUsage
2068 attribute for this type.
2069 (Attribute.ApplyAttributes): Method renamed to Emit and make
2071 (GlobalAttributeSection): New class for special handling of global
2072 attributes (assembly, module).
2073 (AttributeSection.Emit): New method.
2075 * class.cs: Implemented Attributable abstract methods.
2076 (MethodCore.LabelParameters): Moved to Parameter class.
2077 (Accessor): Is back simple class.
2078 (PropertyMethod): Implemented Attributable abstract class.
2079 (DelegateMethod): Implemented Attributable abstract class.
2080 (Event): New constructor for disctintion between normal Event
2081 and Event with accessors.
2083 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
2085 * codegen.cs, const.cs, decl.cs, delegate.cs:
2086 (CommonAssemblyModulClass): Implemented Attributable abstract class
2089 * enum.cs: Implement IAttributeSupport interface.
2090 (EnumMember): New class for emum members. Implemented Attributable
2094 (ParameterBase): Is abstract.
2095 (ReturnParameter): New class for easier [return:] attribute handling.
2097 * typemanager.cs: Removed builder_to_attr.
2099 2004-05-11 Raja R Harinath <rharinath@novell.com>
2102 * attribute.cs (Attribute.GetPositionalValue): New function.
2103 * class.cs (TypeContainer.VerifyMembers): New function.
2104 (TypeContainer.Emit): Use it.
2105 (ClassOrStruct): New base class for Class and Struct.
2106 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
2107 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
2109 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
2110 then each non-static field should have a FieldOffset attribute.
2111 Otherwise, none of the fields should have a FieldOffset attribute.
2112 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
2113 and FieldOffset attributes.
2114 * typemanager.cs (TypeManager.struct_layout_attribute_type)
2115 (TypeManager.field_offset_attribute_type): New core types.
2116 (TypeManager.InitCoreTypes): Initialize them.
2118 2004-05-11 Michal Moskal <malekith@pld-linux.org>
2120 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
2121 Return correct type.
2124 2004-05-09 Miguel de Icaza <miguel@ximian.com>
2126 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
2127 be implicitly converted to ulong.
2129 * expression.cs: The logic for allowing operator &, | and ^ worked
2130 was wrong, it worked before because we did not report an error in
2131 an else branch. Fixes 57895.
2133 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
2134 allow volatile fields to be reference types.
2136 2004-05-07 Miguel de Icaza <miguel@ximian.com>
2138 * driver.cs: Add support for /debug-
2140 2004-05-07 Raja R Harinath <rharinath@novell.com>
2142 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
2143 Add a 'complain' parameter to silence errors.
2144 (Attribute.Resolve): Update to changes. Put in sanity check to catch
2145 silently overlooked type-resolutions.
2146 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
2148 (Attributes.Search): New function.
2149 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
2150 (Attributes.GetAttributeFullName): Remove hack.
2151 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
2152 Update to reflect changes.
2153 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
2154 Use Attributes.Search instead of nested loops.
2156 2004-05-07 Marek Safar <marek.safar@seznam.cz>
2159 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
2160 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
2161 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
2163 * report.cs: (Report.Warning): Renamed to Warning_T because of
2164 parameter collision.
2166 2004-05-05 Raja R Harinath <rharinath@novell.com>
2168 * expression.cs (MemberAccess.ResolveMemberAccess):
2169 Exit with non-zero status after Report.Error.
2170 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
2172 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
2174 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
2176 * support.cs: Don't hang when the file is empty.
2178 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
2180 * support.cs: In SeekableStreamReader, compute the preamble size of the
2181 underlying stream. Position changes should take into account that initial
2184 2004-05-03 Todd Berman <tberman@sevenl.net>
2186 * driver.cs: remove unused GetSysVersion function.
2188 2004-05-03 Todd Berman <tberman@sevenl.net>
2190 * driver.cs: Remove the hack from saturday, as well as the hack
2191 from jackson (LoadAssemblyFromGac), also adds the CWD to the
2192 link_paths to get that bit proper.
2194 2004-05-01 Todd Berman <tberman@sevenl.net>
2196 * driver.cs: Try a LoadFrom before a Load, this checks the current
2197 path. This is currently a bug in mono that is be fixed, however, this
2198 provides a workaround for now. This will be removed when the bug
2201 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
2203 * CryptoConvert.cs: Updated to latest version. Fix issue with
2204 incomplete key pairs (#57941).
2206 2004-05-01 Todd Berman <tberman@sevenl.net>
2208 * driver.cs: Remove '.' from path_chars, now System.* loads properly
2211 2004-04-30 Jackson Harper <jackson@ximian.com>
2213 * codegen.cs: Open keys readonly.
2215 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
2217 * typemanager.cs: don't report cyclic struct layout when a struct
2218 contains 2 or more fields of the same type. Failed for Pango.AttrShape
2219 which has 2 Pango.Rectangle fields.
2221 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
2223 * expression.cs: Handle IntPtr comparisons with IL code
2224 rather than a method call.
2226 2004-04-29 Martin Baulig <martin@ximian.com>
2228 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
2229 the list of PropertyInfo's in class hierarchy and find the
2230 accessor. Fixes #56013.
2232 2004-04-29 Martin Baulig <martin@ximian.com>
2234 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
2236 2004-04-29 Martin Baulig <martin@ximian.com>
2238 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
2240 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
2242 2004-04-29 Martin Baulig <martin@ximian.com>
2244 * class.cs (ConstructorInitializer.Resolve): Check whether the
2245 parent .ctor is accessible. Fixes #52146.
2247 2004-04-29 Martin Baulig <martin@ximian.com>
2249 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
2251 * statement.cs (Using.EmitLocalVariableDecls): Use
2252 TypeManager.idisposable_type, not typeof (IDisposable).
2253 (Foreach.EmitCollectionForeach): Added support for valuetypes.
2255 2004-04-29 Martin Baulig <martin@ximian.com>
2257 * class.cs (Event.Define): Don't emit the field and don't set
2258 RTSpecialName and SpecialName for events on interfaces. Fixes
2261 2004-04-29 Raja R Harinath <rharinath@novell.com>
2263 Refactor Attribute.ApplyAttributes.
2264 * attribute.cs (Attributable): New base class for objects that can
2265 have Attributes applied on them.
2266 (Attribute): Make AttributeUsage fields public.
2267 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
2268 (Attribute.IsInternalCall): New property.
2269 (Attribute.UsageAttr): Convert to a public read-only property.
2270 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
2271 (Attribute.ResolveType, Attribute.Resolve)
2272 (Attribute.ScanForIndexerName): Update to reflect changes.
2273 (Attribute.CheckAttributeTarget): Re-format.
2274 (Attribute.ApplyAttributes): Refactor, to various
2275 Attributable.ApplyAttributeBuilder methods.
2276 * decl.cs (MemberCore): Make Attributable.
2277 * class.cs (Accessor): Make Attributable.
2278 (MethodData.ApplyAttributes): Use proper attribute types, not
2280 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
2281 (TypeContainer.ApplyAttributeBuilder)
2282 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
2283 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
2284 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
2285 (Operator.ApplyAttributeBuilder): New factored-out methods.
2286 * const.cs (Const.ApplyAttributeBuilder): Likewise.
2287 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
2288 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
2289 * parameter.cs (ParameterBase): New Attributable base class
2290 that can also represent Return types.
2291 (Parameter): Update to the changes.
2293 2004-04-29 Jackson Harper <jackson@ximian.com>
2295 * driver.cs: Prefer the corlib system version when looking for
2296 assemblies in the GAC. This is still a hack, but its a better hack
2299 2004-04-29 Marek Safar <marek.safar@seznam.cz>
2301 * decl.cs, enum.cs: Improved error 3005 reporting.
2303 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
2304 (related_symbols): New private member for list of symbols
2305 related to reported error/warning.
2307 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
2309 2004-04-29 Martin Baulig <martin@ximian.com>
2311 * ecore.cs (Expression.Constantify): If we're an enum and
2312 TypeManager.TypeToCoreType() doesn't give us another type, use
2313 t.UnderlyingSystemType. Fixes #56178.
2315 2004-04-29 Martin Baulig <martin@ximian.com>
2317 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
2318 interfaces and for each interface, only add members directly
2319 declared in that interface. Fixes #53255.
2321 2004-04-28 Martin Baulig <martin@ximian.com>
2323 * expression.cs (ConditionalLogicalOperator): Use a temporary
2324 variable for `left' to avoid that we evaluate it more than once;
2327 2004-04-28 Martin Baulig <martin@ximian.com>
2329 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
2332 2004-04-28 Martin Baulig <martin@ximian.com>
2334 * statement.cs (LocalInfo.Resolve): Check whether the type is not
2337 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
2338 whether the type is not void (CS1547).
2340 2004-04-28 Martin Baulig <martin@ximian.com>
2342 * expression.cs (Unary.DoResolveLValue): Override this and report
2343 CS0131 for anything but Operator.Indirection.
2345 2004-04-28 Martin Baulig <martin@ximian.com>
2347 Committing a patch from Ben Maurer; see bug #50820.
2349 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
2352 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
2355 2004-04-28 Martin Baulig <martin@ximian.com>
2357 Committing a patch from Ben Maurer; see bug #50820.
2359 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
2362 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
2365 2004-04-28 Martin Baulig <martin@ximian.com>
2367 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
2368 (Block.AddLabel): Call DoLookupLabel() to only search in the
2371 2004-04-28 Martin Baulig <martin@ximian.com>
2373 * cfold.cs (ConstantFold.BinaryFold): Added special support for
2374 comparing StringConstants and NullLiterals in Equality and Inequality.
2376 2004-04-28 Jackson Harper <jackson@ximian.com>
2378 * driver.cs: Attempt to load referenced assemblies from the
2379 GAC. This is the quick and dirty version of this method that
2380 doesnt take into account versions and just takes the first
2381 canidate found. Will be good enough for now as we will not have more
2382 then one version installed into the GAC until I update this method.
2384 2004-04-28 Martin Baulig <martin@ximian.com>
2386 * typemanager.cs (TypeManager.CheckStructCycles): New public
2387 static method to check for cycles in the struct layout.
2389 * rootcontext.cs (RootContext.PopulateTypes): Call
2390 TypeManager.CheckStructCycles() for each TypeContainer.
2391 [Note: We only need to visit each type once.]
2393 2004-04-28 Martin Baulig <martin@ximian.com>
2395 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
2397 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
2398 success and added `out object value'. Use a `bool resolved' field
2399 to check whether we've already been called rather than
2400 `ConstantValue != null' since this breaks for NullLiterals.
2402 2004-04-28 Raja R Harinath <rharinath@novell.com>
2404 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
2405 setting of this flag, since the 'set' method may be non-public.
2407 2004-04-28 Raja R Harinath <rharinath@novell.com>
2409 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
2410 check on current_vector.Block.
2412 2004-04-27 Martin Baulig <martin@ximian.com>
2414 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
2415 a field initializer. Fixes #56459.
2417 2004-04-27 Martin Baulig <martin@ximian.com>
2419 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
2420 we're not attempting to use an indexer. Fixes #52154.
2422 2004-04-27 Martin Baulig <martin@ximian.com>
2424 * statement.cs (Return): Don't create a return label if we don't
2425 need it; reverts my change from January 20th. Thanks to Ben
2428 2004-04-27 Martin Baulig <martin@ximian.com>
2430 According to the spec, `goto' can only leave a nested scope, but
2433 * statement.cs (Block.LookupLabel): Only lookup in the current
2434 block, don't recurse into parent or child blocks.
2435 (Block.AddLabel): Check in parent and child blocks, report
2436 CS0140/CS0158 if we find a duplicate.
2437 (Block): Removed this indexer for label lookups.
2438 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
2439 this already does the error reporting for us.
2442 (FlowBranching.UsageVector.Block): New public variable; may be null.
2443 (FlowBranching.CreateSibling): Added `Block' argument.
2444 (FlowBranching.LookupLabel): New public virtual method. Lookup a
2445 label for the target of a `goto' and check whether we're not
2446 leaving a `finally'.
2448 2004-04-27 Martin Baulig <martin@ximian.com>
2450 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
2451 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
2454 2004-04-27 Martin Baulig <martin@ximian.com>
2456 * statement.cs (Block.AddLabel): Also check for implicit blocks
2457 and added a CS0158 check.
2459 2004-04-27 Martin Baulig <martin@ximian.com>
2461 * flowanalysis.cs (FlowBranchingLoop): New class.
2462 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
2463 UsageVector's instead of an ArrayList.
2464 (FlowBranching.Label): Likewise.
2465 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
2466 (FlowBranching.AddBreakVector): New method.
2468 2004-04-27 Miguel de Icaza <miguel@ximian.com>
2470 * attribute.cs: Small regression fix: only convert the type if we
2471 the type is different, fixes System.Drawing build.
2473 2004-04-27 Martin Baulig <martin@ximian.com>
2475 * attribute.cs (Attribute.Resolve): If we have a constant value
2476 for a named field or property, implicity convert it to the correct
2479 2004-04-27 Raja R Harinath <rharinath@novell.com>
2481 * statement.cs (Block.Block): Implicit blocks share
2482 'child_variable_names' fields with parent blocks.
2483 (Block.AddChildVariableNames): Remove.
2484 (Block.AddVariable): Mark variable as "used by a child block" in
2485 every surrounding block.
2486 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
2487 been used in a child block, complain about violation of "Invariant
2488 meaning in blocks" rule.
2489 * cs-parser.jay (declare_local_variables): Don't use
2490 AddChildVariableNames.
2491 (foreach_statement): Don't create an implicit block: 'foreach'
2494 2004-04-23 Miguel de Icaza <miguel@ximian.com>
2496 * convert.cs (ImplicitNumericConversion): 0 is also positive when
2497 converting from 0L to ulong. Fixes 57522.
2499 2004-04-22 Marek Safar <marek.safar@seznam.cz>
2501 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
2502 derived class hides via 'new' keyword field from base class (test-242.cs).
2503 TODO: Handle this in the more general way.
2505 * class.cs (CheckBase): Ditto.
2507 2004-04-22 Marek Safar <marek.safar@seznam.cz>
2509 * decl.cs (caching_flags): New member for storing cached values
2511 (MemberCore.Flags): New enum where bit flags for caching_flags
2513 (MemberCore.cls_compliance): Moved to caching_flags.
2514 (DeclSpace.Created): Moved to caching_flags.
2516 * class.cs: Use caching_flags instead of DeclSpace.Created
2518 2004-04-21 Miguel de Icaza <miguel@ximian.com>
2520 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
2521 if we are only a derived class, not a nested class.
2523 * typemanager.cs: Same as above, but do this at the MemberLookup
2524 level (used by field and methods, properties are handled in
2525 PropertyExpr). Allow for the qualified access if we are a nested
2528 2004-04-21 Marek Safar <marek.safar@seznam.cz>
2530 * class.cs: Refactoring.
2531 (IMethodData): New inteface; Holds links to parent members
2532 to avoid member duplication (reduced memory allocation).
2533 (Method): Implemented IMethodData interface.
2534 (PropertyBase): New inner classes for get/set methods.
2535 (PropertyBase.PropertyMethod): Implemented IMethodData interface
2536 (Event): New inner classes for add/remove methods.
2537 (Event.DelegateMethod): Implemented IMethodData interface.
2539 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
2540 EmitContext (related to class.cs refactoring).
2542 2004-04-21 Raja R Harinath <rharinath@novell.com>
2544 * delegate.cs (Delegate.VerifyApplicability): If the number of
2545 arguments are the same as the number of parameters, first try to
2546 verify applicability ignoring any 'params' modifier on the last
2550 2004-04-08 Martin Baulig <martin@ximian.com>
2552 Merged latest changes into gmcs. Please keep this comment in
2553 here, it makes it easier for me to see what changed in MCS since
2554 the last time I merged.
2556 2004-04-16 Raja R Harinath <rharinath@novell.com>
2558 * class.cs (TypeContainer.AddIndexer): Use
2559 'ExplicitInterfaceName' to determine if interface name was
2560 explicitly specified. 'InterfaceType' is not initialized at this time.
2561 (TypeContainer.DefineIndexers): Remove use of temporary list. The
2562 Indexers array is already in the required order. Initialize
2563 'IndexerName' only if there are normal indexers.
2564 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
2565 (TypeContainer.Emit): Emit DefaultMember attribute only if
2566 IndexerName is initialized.
2569 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
2571 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
2574 2004-04-15 Raja R Harinath <rharinath@novell.com>
2576 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
2580 * attribute.cs (Attribute.Resolve): Check for duplicate named
2584 2004-04-15 Miguel de Icaza <miguel@ximian.com>
2586 * iterators.cs (MarkYield): track whether we are in an exception,
2587 and generate code accordingly. Use a temporary value to store the
2588 result for our state.
2590 I had ignored a bit the interaction of try/catch with iterators
2591 since their behavior was not entirely obvious, but now it is
2592 possible to verify that our behavior is the same as MS .NET 2.0
2596 2004-04-14 Miguel de Icaza <miguel@ximian.com>
2598 * iterators.cs: Avoid creating temporaries if there is no work to
2601 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
2602 Enumerations, use TypeManager.EnumToUnderlying and call
2605 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
2608 (This.Emit): Use EmitContext.EmitThis to emit our
2611 (This.EmitAssign): Ditto.
2613 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
2614 codepaths, we will move all the functionality into
2617 (FieldExpr.EmitAssign): Ditto.
2619 This fixes several hidden bugs that I uncovered while doing a code
2620 review of this today.
2622 * codegen.cs (EmitThis): reworked so the semantics are more clear
2623 and also support value types "this" instances.
2625 * iterators.cs: Changed so that for iterators in value types, we
2626 do not pass the value type as a parameter.
2628 Initialization of the enumerator helpers is now done in the caller
2629 instead of passing the parameters to the constructors and having
2630 the constructor set the fields.
2632 The fields have now `assembly' visibility instead of private.
2634 2004-04-11 Miguel de Icaza <miguel@ximian.com>
2636 * expression.cs (Argument.Resolve): Check if fields passed as ref
2637 or out are contained in a MarshalByRefObject.
2639 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
2640 another compiler type.
2642 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
2644 * class.cs (Indexer.Define): use the new name checking method.
2645 Also, return false on an error.
2646 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
2647 (is_identifier_[start/part]_character): make static.
2649 2004-04-10 Miguel de Icaza <miguel@ximian.com>
2651 * expression.cs (Binary.ResolveOperator): Do no append strings
2652 twice: since we can be invoked more than once (array evaluation)
2653 on the same concatenation, take care of this here. Based on a fix
2654 from Ben (bug #56454)
2656 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
2658 * codegen.cs: Fix another case where CS1548 must be reported (when
2659 delay-sign isn't specified and no private is available #56564). Fix
2660 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
2661 error when MCS is used on the MS runtime and we need to delay-sign
2662 (which seems unsupported by AssemblyBuilder - see #56621).
2664 2004-04-08 Marek Safar <marek.safar@seznam.cz>
2666 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
2667 (TypeManager.ComputeNamespaces): Faster implementation for
2670 * compiler.csproj: Updated AssemblyName to mcs.
2672 2004-05-11 Jackson Harper <jackson@ximian.com>
2674 * Makefile: Preserve MONO_PATH
2676 2004-05-11 Jackson Harper <jackson@ximian.com>
2678 * Makefile: Use mono and mcs to build gmcs
2680 2004-05-03 Miguel de Icaza <miguel@ximian.com>
2682 * codegen.cs: Add patch from Robert Shade
2683 <rshade@dvsconsulting.com>, use FileAccess.Read on the keyfile, to
2686 2004-05-02 Sebastien Pouliot <sebastien@ximian.com>
2688 * CryptoConvert.cs: Updated to latest version. Fix issue with
2689 incomplete key pairs (#57941).
2691 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
2693 * codegen.cs: Fix another case where CS1548 must be reported (when
2694 delay-sign isn't specified and no private is available #56564). Fix
2695 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
2696 error when MCS is used on the MS runtime and we need to delay-sign
2697 (which seems unsupported by AssemblyBuilder - see #56621).
2699 2004-04-29 Jackson Harper <jackson@ximian.com>
2701 * Makefile: Set MONO_PATH to use the bootstrap corlib
2702 * driver.cs: Check the GAC for referenced assemblies.
2704 2004-04-29 Martin Baulig <martin@ximian.com>
2706 * Makefile (gmcs.exe): Set MONO_PATH to use `../class/lib/net_2_0'.
2708 2004-04-07 Martin Baulig <martin@ximian.com>
2710 * expression.cs (Binary.ResolveOperator): Added special case for
2711 Equality/Inequality between a type parameter and a null literal.
2713 2004-04-07 Martin Baulig <martin@ximian.com>
2715 * convert.cs: Check null literal -> type parameter conversions.
2717 2004-04-07 Martin Baulig <martin@ximian.com>
2719 * generic.cs (ConstructedType.CheckConstraints): Enforce the
2720 `class' and `struct' constraints.
2722 2004-04-07 Martin Baulig <martin@ximian.com>
2724 * generic.cs (SpecialConstraint): New public enum.
2725 (Constraints.Resolve): Added support for the `class' and `struct'
2728 * cs-parser.jay (type_parameter_constraint): Added support for the
2729 `class' and `struct' constraints.
2731 2004-04-07 Martin Baulig <martin@ximian.com>
2733 * support.cs (GenericConstraints): Replaced `Types' by
2734 `ClassConstraint' and `InterfaceConstraints'; added
2735 `HasClassConstraint'.
2737 2004-04-07 Martin Baulig <martin@ximian.com>
2740 (Constraints.InterfaceConstraints): New public property.
2741 (Constraints.Types): Make this property public
2742 (TypeParameter): Implement IMemberContainer.
2743 (TypeParameter.Define): Take a `GenericTypeParameterBuilder'
2744 instead of a TypeBuilder/MethodBuilder; pass the interface
2745 constraints to TypeManager.AddTypeParameter().
2746 (TypeParameter.DefineType): Just take an EmitContext and no
2747 TypeBuilder/MethodBuilder. Use the new public API.
2749 * typemanager.cs (TypeManager.AddTypeParameter): Added
2750 `TypeExpr[]' argument; add the interfaces to the
2751 `builder_to_ifaces' hash.
2752 (TypeManager.LookupMemberContainer): For
2753 GenericTypeParameterBuilders, get the TypeParameter from the
2754 `builder_to_type_param'.
2755 (TypeManager.FindMembers): For GenericTypeParameterBuilders, get
2756 the TypeParameter and call FindMembers on it.
2758 2004-04-07 Martin Baulig <martin@ximian.com>
2761 (MethodCore.GenericMethod): Moved this field here from Method.
2762 (MethodCore.IsDuplicateImplementation): Take the number of type
2763 parameters into account if we're a generic method.
2765 * expression.cs (Invocation.InferTypeArguments): Don't return true
2766 if `arguments' is null; we still need to check whether we actually
2767 don't need to infer anything in this case.
2768 (MemberAccess): Merged the functionality from GenericMemberAccess
2771 * generic.cs (GenericMemberAccess): Removed.
2773 2004-04-05 Martin Baulig <martin@ximian.com>
2775 * decl.cs (MemberCore): For generic classes, interfaces and
2776 structs, `Name' now includes the number of type parameters
2778 (DeclSpace.FindType): Removed the `num_type_args' argument; we now
2779 encode the number of type arguments in the type name.
2781 * expression.cs (Expression.MemberLookup): Removed the
2782 `num_type_args' argument; we now encode the number of type
2783 arguments in the type name.
2785 * ecore.cs (SimpleName): Encode the number of type arguments in
2786 the type name itself.
2788 * generic.cs (ConstructedType): Likewise.
2790 * tree.cs (Tree.RecordDecl): Take a `string' instead of a
2791 `MemberName'; we now include the number of type parameters in the
2794 * typemanager.cs (TypeManager.CheckGeneric): Removed.
2795 (TypeManager.MemberLookup): Removed the
2796 `num_type_args' argument; we now encode the number of type
2797 arguments in the type name.
2799 2004-04-03 Martin Baulig <martin@ximian.com>
2801 * decl.cs (MemberCore.ctor): Take a MemberName instead of a sting.
2802 (MemberCore.MemberName): Moved here from MemberBase.
2803 (DeclSpace.SetParameterInfo): Just take the constraints as an
2804 ArrayList; we already have the type parameters in our
2805 `MemberName'; also do the CS0080 reporting here.
2807 * cs-parser.jay (struct_declaration): Use `member_name' instead of
2808 `IDENTIFIER opt_type_parameter_list'; when constructing our
2809 `MemberName', it'll already include our type parameters.
2810 (class_declaration, interface_declaration): Likewise.
2811 (delegate_declaration): Likewise.
2812 (MakeName): Take a MemberName and return a MemberName.
2813 The following two changes are required to avoid shift/reduce conflicts:
2814 (member_name): Don't include a TypeName anymore; ie. this is now
2815 just 'IDENTIFIER opt_type_parameter_list'.
2816 (property_declaration, event_declaration): Use a
2817 `namespace_or_type_name' instead of a `member_name'.
2819 2004-04-03 Martin Baulig <martin@ximian.com>
2821 * decl.cs (MemberName): Renamed to `TypeName' and created a new
2823 (TypeName): Formerly known as MemberName.
2825 * namespace.cs (NamespaceEntry.UsingAlias): Take a `TypeName'
2826 instead of a `MemberName'.
2828 * cs-parser.jay (namespace_or_type_name): Create a TypeName.
2829 (member_name): New rule; create a MemberName.
2831 2004-04-02 Martin Baulig <martin@ximian.com>
2833 * namespace.cs (NamespaceEntry.VerifyUsing): Added error checking
2834 (CS0305 and CS0308).
2836 2004-04-02 Martin Baulig <martin@ximian.com>
2838 * generic.cs (GenericMemberAccess.ResolveAsTypeStep): Added
2839 support for nested types.
2841 2004-04-02 Martin Baulig <martin@ximian.com>
2843 * ecore.cs (IAlias): New public interface.
2844 (TypeExpr, TypeExpression): Implement IAlias.
2845 (TypeAliasExpression): New public class.
2847 * namespace.cs (Namespace): Implement IAlias.
2848 (Namespace.Lookup): Return an IAlias instead on an object.
2849 (Namespace.DefineName): Take an IAlias instead of an object.
2850 (NamespaceEntry.AliasEntry.Resolve): Return an IAlias instead of
2852 (NamespaceEntry.UsingAlias): Take a Membername instead of an
2854 (NamespaceEntry.LookupAlias): Return an IAlias instead on an
2856 (NamespaceEntry.Lookup): Likewise.
2858 * rootcontext.cs (RootContext.LookupType): Return a TypeExpr
2861 * decl.cs (DeclSpace): Implement IAlias.
2862 (DeclSpace.LookupAlias): Return an IAlias instead of a string.
2864 * generic.cs (ConstructedType): Improved error checking.
2866 2004-04-02 Martin Baulig <martin@ximian.com>
2868 * convert.cs: Added type parameter conversions.
2871 (UnboxCast.Emit): Emit an `unbox.any' for type params.
2872 (ClassCast.Emit): If the source type is a type parameter, box it.
2873 If the target type is a type parameter, emit an `unbox.any'
2874 instead of a `classcast'.1
2876 2004-04-01 Martin Baulig <martin@ximian.com>
2878 * cs-tokenizer.cs (parse_less_than): Allow Token.DOT.
2880 2004-04-01 Martin Baulig <martin@ximian.com>
2882 * generic.cs (ConstructedType.CheckConstraints): Use
2883 Convert.ImplicitStandardConversionExists(); user-defined implicit
2884 conversions are not allowed according to the spec.
2886 2004-03-30 Martin Baulig <martin@ximian.com>
2888 * expression.cs (New): Added support for type parameters.
2891 (TypeManager.activator_type): New public static field.
2892 (TypeManager.activator_create_instance): Likewise.
2894 2004-03-30 Martin Baulig <martin@ximian.com>
2896 * typemanager.cs (TypeManager.HasConstructorConstraint): New
2899 2004-03-30 Martin Baulig <martin@ximian.com>
2901 * generic.cs (ConstructedType.CheckConstraints): Actually follow
2902 the spec here: the argument type must be convertible to the
2905 2004-03-30 Martin Baulig <martin@ximian.com>
2908 (TypeParameter.Define, TypeParameter.DefineMethod): Call
2909 TypeManager.AddTypeParameter().
2910 (ConstructedType.CheckConstraints): Re-enable this and actually
2911 check whether we have a constructor constraint.
2914 (TypeManager.builder_to_type_param): New static field.
2915 (TypeManager.AddTypeParameter): New static method.
2916 (TypeManager.LookupTypeParameter): New public method.
2918 2004-03-30 Martin Baulig <martin@ximian.com>
2920 * generic.cs (TypeParameter.DefineType): Return a boolean and use
2921 the new API to actually define the constructor constraint.
2924 (TypeManager.new_constraint_attr_type): New static field.
2925 (TypeManager.InitCoreTypes): Initialize it.
2927 2004-03-30 Martin Baulig <martin@ximian.com>
2929 * generic.cs (Constraints): Completed error checking, use correct
2932 2004-03-29 Martin Baulig <martin@ximian.com>
2934 * delegate.cs (Delegate.VerifyMethod): Infer type arguments.
2936 * expression.cs (Invocation.InferTypeArguments): Added overloaded
2937 public version which takes a `ParameterData pd' instead of an
2940 2004-03-29 Martin Baulig <martin@ximian.com>
2942 * typemanager.cs (TypeManager.IsGenericMethod): Take a MethodBase,
2945 2004-03-29 Martin Baulig <martin@ximian.com>
2947 * expression.cs (Argument.ResolveMethodGroup): If we're a
2948 ConstructedType, call GetMemberAccess() on it.
2950 2004-03-29 Martin Baulig <martin@ximian.com>
2952 * class.cs (MethodBase.CheckGenericOverride): New abstract method.
2953 (MethodCore.CheckGenericOverride): When overriding a generic
2954 method, check whether the constraints match.
2956 * support.cs (GenericConstraints): New public interface.
2957 (ParameterData.GenericConstraints): New public method.
2959 * parameter.cs (Parameter.Resolve): Check whether we're a generic
2960 method parameter and compute our constraints if appropriate.
2961 (Parameter.GenericConstraints): New public property.
2963 * generic.cs (Constraints): Implement GenericConstraints.
2965 2004-03-29 Martin Baulig <martin@ximian.com>
2967 * decl.cs (MemberCache.FindMemberToOverride): Use
2968 `paramTypes [j].Equals (cmpAttrs [j])' instead of `=='.
2970 2004-03-29 Martin Baulig <martin@ximian.com>
2972 * generic.cs (GenericMethod.Define): Resolve our type parameters.
2974 2004-03-29 Martin Baulig <martin@ximian.com>
2976 * cs-parser.jay: Report CS0080 instead of -200 ("Constraints are
2977 not allowed on non-generic declarations").
2979 2004-03-29 Martin Baulig <martin@ximian.com>
2981 * expression.cs (Invocation.InferTypeArguments): Added overloaded
2982 public version of this method.
2984 * class.cs (MethodCore.IsDuplicateImplementation): Use
2985 Invocation.InferTypeArguments() to check this.
2987 2004-03-29 Martin Baulig <martin@ximian.com>
2989 * convert.cs: Use TypeManager.IsDelegateType() instead of
2990 comparing types correctly.
2992 2004-03-29 Martin Baulig <martin@ximian.com>
2994 * convert.cs: Use TypeManager.IsSubclassOf() instead of comparing
2995 types directly to make it work for generic instances.
2997 * typemanager.cs (TypeManager.IsSubclassOf): New static method.
2999 2004-03-29 Martin Baulig <martin@ximian.com>
3001 * typemanager.cs (TypeManager.MayBecomeEqualGenericTypes): Added
3004 2004-03-24 Martin Baulig <martin@ximian.com>
3006 * decl.cs (DeclSpace.FindType): Also use
3007 TypeManager.CheckGeneric() for types from the using clauses.
3009 2004-03-23 Martin Baulig <martin@ximian.com>
3011 * expression.cs (Invocation.OverloadResolve): Added `bool
3012 may_fail' argument and use it instead of the Location.IsNull() hack.
3014 2004-03-23 Martin Baulig <martin@ximian.com>
3016 * expression.cs (Invocation.InferType): Use correct type inference
3019 2004-03-23 Martin Baulig <martin@ximian.com>
3021 * ecore.cs (MethodGroupExpr.Name): Use
3022 TypeManager.CSharpSignature() instead of just the name.
3024 * expression.cs (Invocation.OverloadResolve): Provide better error
3026 (Invocation.DoResolve): OverloadResolve() never returns null
3027 without reporting an error, so removed the error -6 reporting here.
3029 2004-03-23 Martin Baulig <martin@ximian.com>
3031 * typemanager.cs (TypeManager.GetMethodFlags): Fixed the FIXME for
3034 * cs-parser.jay (delegate_declaration): Support generic delegates.
3036 * delegate.cs: Support generic delegates.
3038 2004-03-22 Martin Baulig <martin@ximian.com>
3040 * expression.cs (Invocation.InferParamsTypeArguments): New static
3041 method; does type inference for params arguments.
3043 2004-03-21 Martin Baulig <martin@ximian.com>
3045 * typemanager.cs (TypeManager.IsGenericMethod): New public static
3046 method; checks whether a method is a generic method.
3048 * expression.cs (Invocation.InferTypeArguments): New static method;
3049 infer type arguments for generic method invocation.
3051 * ecore.cs (MethodGroupExpr.HasTypeArguments): New public
3052 property; we set this to true if we're resolving a generic method
3053 invocation and the user specified type arguments, ie. we're not
3054 doing type inference.
3056 2004-03-20 Martin Baulig <martin@ximian.com>
3058 * class.cs (MethodData.DeclaringType): New public property.
3059 (MethodData.Define): Set DeclaringType here.
3060 (Operator.Define): Use OperatorMethod.MethodData.DeclaringType
3061 instead of OperatorMethodBuilder.DeclaringType.
3063 2004-03-20 Martin Baulig <martin@ximian.com>
3065 * cs-tokenizer.cs (xtoken): Return a special
3066 Token.DEFAULT_OPEN_PARENS for "`default' followed by open parens".
3068 * cs-parser.jay (default_value_expression): Switch to the new
3071 2004-03-19 Martin Baulig <martin@ximian.com>
3073 * decl.cs (MemberName): New class. We use this to "construct"
3074 namespace_or_type_name's.
3076 * generics.cs (TypeArguments.GetDeclarations): New public method;
3077 returns the type arguments as a string[] and reports a CS0081 if
3078 one of them is not an identifier.
3080 * class.cs (MemberBase): The .ctor now takes the name as a
3081 MemberName instead of a string.
3082 (MemberBase.ExplicitInterfaceName): Changed type from string to
3084 (MemberBase.DoDefine): If we're an explicit implementation, the
3085 InterfaceType may be a generic instance.
3087 * cs-parser.jay (namespace_or_type_name): Return a MemberName.
3088 (namespace_name): Call MemberName.GetName () to transform the
3089 MemberName into a string and ensure we don't have any type
3091 (type_name): Call MemberName.GetTypeExpression() to transfrom the
3092 MemberName into an expression.
3093 (method_header): Use namespace_or_type_name instead of member_name.
3095 2004-04-07 Miguel de Icaza <miguel@ximian.com>
3097 * rootcontext.cs: Add new types to the boot resolution.
3099 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
3100 MulticastDelegate is not allowed.
3102 * typemanager.cs: Add new types to lookup: System.TypedReference
3105 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
3106 check for TypedReference or ArgIterator, they are not allowed.
3108 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
3109 makes us properly catch 1510 in some conditions (see bug 56016 for
3112 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
3114 * CryptoConvert.cs: update from corlib version
3117 2004-04-05 Miguel de Icaza <miguel@ximian.com>
3119 * class.cs (Indexer.Define): Check indexername declaration
3121 2004-04-05 Marek Safar <marek.safar@seznam.cz>
3123 * attribute.cs (IsClsCompliant): Fixed problem with handling
3124 all three states (compliant, not-compliant, undetected).
3126 2004-03-30 Marek Safar <marek.safar@seznam.cz>
3128 * attribute.cs (Attribute): Location is now public.
3129 (Resolve): Store resolved arguments (pos_values) in attribute class.
3130 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
3131 (GetClsCompliantAttributeValue): New method that gets
3132 CLSCompliantAttribute value.
3133 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
3134 if exists else null.
3135 (AttributeTester): New class for CLS-Compliant verification routines.
3137 * class.cs (Emit): Add CLS-Compliant verification.
3138 (Method.GetSignatureForError): Implemented.
3139 (Constructor.GetSignatureForError): Implemented
3140 (Constructor.HasCompliantArgs): Returns if constructor has
3141 CLS-Compliant arguments.
3142 (Constructor.Emit): Override.
3143 (Construcor.IsIdentifierClsCompliant): New method; For constructors
3144 is needed to test only parameters.
3145 (FieldBase.GetSignatureForError): Implemented.
3146 (TypeContainer): New member for storing base interfaces.
3147 (TypeContainer.FindMembers): Search in base interfaces too.
3149 * codegen.cs (GetClsComplianceAttribute): New method that gets
3150 assembly or module CLSCompliantAttribute value.
3151 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
3153 (ModuleClass.Emit): Add error 3012 test.
3155 * const.cs (Emit): Override and call base for CLS-Compliant tests.
3157 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
3158 state for all decl types.
3159 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
3160 if CLS-Compliant tests are required.
3161 (IsClsCompliaceRequired): New method. Analyze whether code
3162 must be CLS-Compliant.
3163 (IsExposedFromAssembly): New method. Returns true when MemberCore
3164 is exposed from assembly.
3165 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
3166 value or gets cached value.
3167 (HasClsCompliantAttribute): New method. Returns true if MemberCore
3168 is explicitly marked with CLSCompliantAttribute.
3169 (IsIdentifierClsCompliant): New abstract method. This method is
3170 used to testing error 3005.
3171 (IsIdentifierAndParamClsCompliant): New method. Common helper method
3172 for identifier and parameters CLS-Compliant testing.
3173 (VerifyClsCompliance): New method. The main virtual method for
3174 CLS-Compliant verifications.
3175 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
3176 null. I don't know why is null (too many public members !).
3177 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
3178 and get value of first CLSCompliantAttribute that found.
3180 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
3181 (VerifyClsCompliance): Override and add extra tests.
3183 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
3184 clscheck- disable CLS-Compliant verification event if assembly is has
3185 CLSCompliantAttribute(true).
3187 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
3188 ApllyAttribute is now called in emit section as in the other cases.
3189 Possible future Emit integration.
3190 (IsIdentifierClsCompliant): New override.
3191 (VerifyClsCompliance): New override.
3192 (GetEnumeratorName): Returns full enum name.
3194 * parameter.cs (GetSignatureForError): Implemented.
3196 * report.cs (WarningData): New struct for Warning message information.
3197 (LocationOfPreviousError): New method.
3198 (Warning): New method. Reports warning based on the warning table.
3199 (Error_T): New method. Reports error based on the error table.
3201 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
3202 verifications are done here.
3204 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
3206 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
3207 CLSCompliantAttribute.
3208 (all_imported_types): New member holds all imported types from other
3210 (LoadAllImportedTypes): New method fills static table with exported types
3211 from all referenced assemblies.
3212 (Modules): New property returns all assembly modules.
3214 2004-03-30 Miguel de Icaza <miguel@ximian.com>
3216 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
3217 throwing a parser error.
3219 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
3220 which removes the hardcoded get_/set_ prefixes for properties, as
3221 IL allows for the properties to be named something else.
3225 * expression.cs: Do not override operand before we know if it is
3228 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
3230 * typemanager.cs: support for pinned variables.
3232 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
3234 * decl.cs, typemanager.cs: Avoid using an arraylist
3235 as a buffer if there is only one result set.
3237 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
3239 * expression.cs: Make sure you cant call a static method
3240 with an instance expression, bug #56174.
3242 2004-03-29 Miguel de Icaza <miguel@ximian.com>
3244 * class.cs (IsDuplicateImplementation): Improve error reporting to
3245 flag 663 (method only differs in parameter modifier).
3247 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
3248 in preprocessor directives.
3250 * location.cs (LookupFile): Allow for the empty path.
3252 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
3253 better approach for some of that patch, but its failing with the
3254 CharSet enumeration. For now try/catch will do.
3256 * typemanager.cs: Do not crash if a struct does not have fields.
3259 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
3261 * expression.cs: cs0213, cant fix a fixed expression.
3264 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
3266 * cs-parser.jay: detect invalid embeded statements gracefully.
3269 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
3271 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
3274 the invocation type may not be a subclass of the tye of the item/
3275 The type of the item must be a subclass of the invocation item.
3280 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
3282 * attribute.cs: Added methods to get a string and a bool from an
3283 attribute. Required to information from AssemblyKeyFileAttribute,
3284 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
3285 * codegen.cs: Modified AssemblyName creation to include support for
3286 strongnames. Catch additional exceptions to report them as CS1548.
3287 * compiler.csproj: Updated include CryptoConvert.cs.
3288 * compiler.csproj.user: Removed file - user specific configuration.
3289 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
3290 Mono.Security assembly. The original class is maintained and tested in
3291 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
3292 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
3293 like CSC 8.0 (C# v2) supports.
3294 * Makefile: Added CryptoConvert.cs to mcs sources.
3295 * rootcontext.cs: Added new options for strongnames.
3297 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
3299 * driver.cs: For --expect-error, report error code `2'
3300 if the program compiled with no errors, error code `1' if
3301 it compiled with an error other than the one expected.
3303 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
3305 * compiler.csproj: Updated for Visual Studio .NET 2003.
3306 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
3307 * compiler.sln: Updated for Visual Studio .NET 2003.
3309 2004-03-24 Ravi Pratap M <ravi@ximian.com>
3311 * expression.cs: Fix bug #47234. We basically need to apply the
3312 rule that we prefer the conversion of null to a reference type
3313 when faced with a conversion to 'object' (csc behaviour).
3315 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
3317 * statement.cs: Shorter form for foreach, eliminates
3318 a local variable. r=Martin.
3320 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
3322 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
3323 checks if we can use brtrue/brfalse to test for 0.
3324 * expression.cs: use the above in the test for using brtrue/brfalse.
3327 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
3329 * expression.cs: Rewrite string concat stuff. Benefits:
3331 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
3332 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
3333 rather than a concat chain.
3335 * typemanager.cs: Add lookups for more concat overloads.
3337 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
3339 * expression.cs: Emit shorter il code for array init.
3356 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
3358 * statement.cs: Before, two switch blocks would be merged if the
3359 total size of the blocks (end_item - begin_item + 1) was less than
3360 two times the combined sizes of the blocks.
3362 Now, it will only merge if after the merge at least half of the
3367 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
3369 * class.cs : csc build fix for GetMethods(). See bug #52503.
3371 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
3373 * expression.cs: Make sure fp comparisons work with NaN.
3374 This fixes bug #54303. Mig approved this patch a long
3375 time ago, but we were not able to test b/c the runtime
3378 2004-03-19 Miguel de Icaza <miguel@ximian.com>
3380 * ecore.cs (TypExpr.GetHashCode): implement this overload.
3382 2004-03-19 Martin Baulig <martin@ximian.com>
3384 * class.cs (MemberCore.IsDuplicateImplementation): Check whether
3385 two overloads may unify for some type parameter substitutions and
3386 report a CS0408 if appropriate.
3388 2004-03-19 Martin Baulig <martin@ximian.com>
3390 * class.cs (MemberCore.IsDuplicateImplementation): Report the
3391 error here and not in our caller.
3393 2004-03-19 Martin Baulig <martin@ximian.com>
3395 * interface.cs: Completely killed this file.
3396 (Interface): We're now a TypeContainer and live in class.cs.
3398 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
3399 argument; we're now also called for interfaces.
3400 (TypeContainer.DefineMembers): Allow this method being called
3402 (TypeContainer.GetMethods): New public method; formerly known as
3403 Interface.GetMethod(). This is used by PendingImplementation.
3404 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
3405 it's now private and non-static.
3406 (Interface): Moved this here; it's now implemented similar to
3408 (Method, Property, Event, Indexer): Added `bool is_interface'
3409 argument to their .ctor's.
3410 (MemberBase.IsInterface): New public field.
3412 * cs-parser.jay: Create normal Method, Property, Event, Indexer
3413 instances instead of InterfaceMethod, InterfaceProperty, etc.
3414 (opt_interface_base): Removed; we now use `opt_class_base' instead.
3415 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
3417 2004-03-19 Martin Baulig <martin@ximian.com>
3419 * class.cs (MethodCore.IsDuplicateImplementation): New private
3420 method which does the CS0111 checking.
3421 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
3422 Use IsDuplicateImplementation().
3424 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
3426 * decl.cs (FindMemberToOverride): New method to find the correct
3427 method or property to override in the base class.
3429 - Make Method/Property use the above method to find the
3430 version in the base class.
3431 - Remove the InheritableMemberSignatureCompare as it is now
3434 This patch makes large code bases much faster to compile, as it is
3435 O(n) rather than O(n^2) to do this validation.
3437 Also, it fixes bug 52458 which is that nested classes are not
3438 taken into account when finding the base class member.
3440 Reviewed/Approved by Martin.
3442 2004-03-17 Martin Baulig <martin@ximian.com>
3444 * expression.cs (MemberAccess.DoResolve): Take the parent's number
3445 of type arguments into account; use the `real_num_type_args'
3446 approach like in DoResolveAsTypeStep().
3448 * generic.cs (GenericMemberAccess.DoResolve): Make this work for
3451 2004-03-17 Marek Safar <marek.safar@seznam.cz>
3453 * interface.cs: In all interface classes removed redundant
3454 member initialization.
3456 2004-03-16 Martin Baulig <martin@ximian.com>
3458 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
3460 2004-03-15 Miguel de Icaza <miguel@ximian.com>
3462 * decl.cs (DefineTypeAndParents): New helper method to define a
3463 type's containers before the type itself is defined; This is a
3464 bug exposed by the recent changes to Windows.Forms when an
3465 implemented interface was defined inside a class that had not been
3468 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
3470 (Check): Loop correctly to report errors modifiers
3471 (UNSAFE was not in the loop, since it was the same as TOP).
3473 * interface.cs: Every interface member now takes a ModFlags,
3474 instead of a "is_new" bool, which we set on the base MemberCore.
3476 Every place where we called "UnsafeOk" in the interface, now we
3477 call the proper member (InterfaceMethod.UnsafeOK) instead to get
3478 the unsafe settings from the member declaration instead of the
3479 container interface.
3481 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
3483 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
3484 `set_indexer_name' to the pending bits (one per type).
3486 We fixed a bug today that was picking the wrong method to
3487 override, since for properties the existing InterfaceMethod code
3488 basically ignored the method name. Now we make sure that the
3489 method name is one of the valid indexer names.
3491 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
3493 * support.cs (SeekableStreamReader): Keep track of stream byte
3494 positions and don't mix them with character offsets to the buffer.
3496 Patch from Gustavo Giráldez
3498 2004-03-15 Marek Safar <marek.safar@seznam.cz>
3500 * interface.cs (InterfaceSetGetBase): Removed double member
3501 initialization, base class does it as well.
3503 2004-03-13 Martin Baulig <martin@ximian.com>
3505 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
3506 when compiling corlib.
3508 2004-03-13 Miguel de Icaza <miguel@ximian.com>
3510 * convert.cs (ExplicitConversion): We were reporting an error on
3511 certain conversions (object_type source to a value type, when the
3512 expression was `null') before we had a chance to pass it through
3513 the user defined conversions.
3515 * driver.cs: Replace / and \ in resource specifications to dots.
3518 * class.cs: Add check for duplicate operators. Fixes 52477
3520 2004-03-11 Miguel de Icaza <miguel@ximian.com>
3522 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
3523 that are in the middle of the statements, not only at the end.
3526 * class.cs (TypeContainer.AddField): No longer set the
3527 `HaveStaticConstructor' flag, now we call it
3528 `UserDefineStaticConstructor' to diferentiate the slightly
3529 semantic difference.
3531 The situation is that we were not adding BeforeFieldInit (from
3532 Modifiers.TypeAttr) to classes that could have it.
3533 BeforeFieldInit should be set to classes that have no static
3538 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
3540 And most importantly Zoltan's comment:
3542 http://bugzilla.ximian.com/show_bug.cgi?id=44229
3544 "I think beforefieldinit means 'it's ok to initialize the type sometime
3545 before its static fields are used', i.e. initialization does not need
3546 to be triggered by the first access to the type. Setting this flag
3547 helps the JIT to compile better code, since it can run the static
3548 constructor at JIT time, and does not need to generate code to call it
3549 (possibly lots of times) at runtime. Unfortunately, mcs does not set
3550 this flag for lots of classes like String.
3552 csc sets this flag if the type does not have an explicit static
3553 constructor. The reasoning seems to be that if there are only static
3554 initalizers for a type, and no static constructor, then the programmer
3555 does not care when this initialization happens, so beforefieldinit
3558 This bug prevents the AOT compiler from being usable, since it
3559 generates so many calls to mono_runtime_class_init that the AOT code
3560 is much slower than the JITted code. The JITted code is faster,
3561 because it does not generate these calls if the vtable is type is
3562 already initialized, which is true in the majority of cases. But the
3563 AOT compiler can't do this."
3565 2004-03-10 Miguel de Icaza <miguel@ximian.com>
3567 * class.cs (MethodData.Emit): Refactor the code so symbolic
3568 information is generated for destructors; For some reasons we
3569 were taking a code path that did not generate symbolic information
3572 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
3574 * class.cs: Create a Constructor.CheckBase method that
3575 takes care of all validation type code. The method
3576 contains some code that was moved from Define.
3578 It also includes new code that checks for duplicate ctors.
3579 This fixes bug #55148.
3581 2004-03-09 Joshua Tauberer <tauberer@for.net>
3583 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
3584 a { ... }-style array creation invokes EmitStaticInitializers
3585 which is not good for reference-type arrays. String, decimal
3586 and now null constants (NullCast) are not counted toward
3587 static initializers.
3589 2004-03-05 Martin Baulig <martin@ximian.com>
3591 * location.cs (SourceFile.HasLineDirective): New public field;
3592 specifies whether the file contains or is referenced by a "#line"
3594 (Location.DefineSymbolDocuments): Ignore source files which
3595 either contain or are referenced by a "#line" directive.
3597 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
3599 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
3600 direct access to our parent, so check the method inline there.
3602 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
3604 * expression.cs (Invocation.EmitCall): Miguel's last commit
3605 caused a regression. If you had:
3610 In Foo the implict this would be null.
3612 2004-02-27 Miguel de Icaza <miguel@ximian.com>
3614 * expression.cs (Invocation.EmitCall): If the method is not
3615 virtual, do not emit a CallVirt to it, use Call.
3617 * typemanager.cs (GetFullNameSignature): Improve the method to
3618 cope with ".ctor" and replace it with the type name.
3620 * class.cs (ConstructorInitializer.Resolve): Now the method takes
3621 as an argument the ConstructorBuilder where it is being defined,
3622 to catch the recursive constructor invocations.
3624 2004-03-16 Martin Baulig <martin@ximian.com>
3626 * expression.cs (MemberAccess.DoResolve): If `expr' resolved to a
3627 ConstructedType, call ResolveType() on it to get the type rather
3628 than just using `expr.Type'.
3630 2004-03-16 Martin Baulig <martin@ximian.com>
3632 * generics.cs (ConstructedType.GetMemberAccess): Take the
3633 EmitContext instead on the TypeExpr and use
3634 ec.TypeContainer.CurrentType/ec.ContainerType.
3636 2004-03-16 Martin Baulig <martin@ximian.com>
3638 * ecore.cs (SimpleName.DoResolveAsTypeStep): Lookup type
3639 parameters before aliases.
3641 2004-03-16 Martin Baulig <martin@ximian.com>
3643 * typemanager.cs (TypeManager.MayBecomeEqualGenericInstances):
3644 New oublic function; checks whether two generic instances may become
3645 equal under some instantiations (26.3.1).
3647 * class.cs (TypeContainer.Define): Call
3648 TypeManager.MayBecomeEqualGenericInstances() and report CS0695 on
3651 2004-03-16 Martin Baulig <martin@ximian.com>
3653 * class.cs (TypeContainer.GetClassBases): Moved
3654 Error_TypeParameterAsBase() here and also check whether the base
3655 class is not an attribute.
3657 2004-03-16 Martin Baulig <martin@ximian.com>
3659 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
3661 2004-03-16 Martin Baulig <martin@ximian.com>
3663 * class.cs (Error_TypeParameterAsBase): Use correct error number
3666 2004-03-16 Martin Baulig <martin@ximian.com>
3668 * decl.cs (DeclSpace.ResolveTypeExpr): Added more error checking
3671 * generics.cs (ConstructedType.DoResolveAsTypeStep): Added better
3674 2004-03-15 Martin Baulig <martin@ximian.com>
3676 * typemanager.cs (TypeManager.GetFullName): New public method.
3677 (TypeManager.MemberLookup): Added `int_num_type_arguments'
3678 argument; only return members with the correct number of type
3680 (TypeManager.CheckGeneric): Allow -1 to bypass the check.
3681 (TypeManager.FilterWithClosure): Call CheckGeneric() to check
3682 whether the number of type arguments matches.
3684 * generic.cs (GenericMemberAccess.ResolveAsTypeStep): Allow `expr'
3685 not being a ConstructedType; we can now do "typeof (Foo.Bar<U>)".
3687 * expression.cs (MemberAccess): Added public `NumTypeArguments'
3688 field; it's set by the protected .ctor when we're actually a
3689 GenericMemberAccess.
3690 (MemberAccess.ResolveAsTypeStep): Compute the total number of type
3691 arguments and pass it to MemberLookupFinal ().
3693 * ecore.cs (Expression.MemberLookup): Added `int
3694 num_type_arguments' argument; only return members with the correct
3695 number of type arguments.
3696 (Expression.MemberLookupFailed): Check whether the MemberLookup
3697 failed because we did not have the correct number of type
3698 arguments; report CS0305 in this case.
3700 * decl.cs (DeclSpace.ResolveTypeExpr): Don't report an error if
3701 `e.ResolveAsTypeTerminal()' already did so.
3703 2004-03-15 Martin Baulig <martin@ximian.com>
3705 * ecore.cs (Expression.ResolveLValue): Allow e.type being null if
3706 we're a ConstructedType; in this case, the caller must report an
3707 error (for instance CS0131).
3709 * generic.cs (TypeArguments): Added Location argument to the .ctor.
3710 (TypeArguments.Resolve): Actually report errors here.
3712 2004-03-15 Miguel de Icaza <miguel@ximian.com>
3714 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
3715 `set_indexer_name' to the pending bits (one per type).
3717 We fixed a bug today that was picking the wrong method to
3718 override, since for properties the existing InterfaceMethod code
3719 basically ignored the method name. Now we make sure that the
3720 method name is one of the valid indexer names.
3722 2004-03-15 Martin Baulig <martin@ximian.com>
3724 * typemanager.cs (TypeManager.IndexerPropertyName): Added support
3725 for generic instances.
3727 2004-03-13 Martin Baulig <martin@ximian.com>
3729 * class.cs (TypeContainer.DefineType): Call
3730 TypeManager.AddUserType() immediately after creating the
3731 TypeBuilder; pass all type parameters when creating the
3734 * decl.cs (DeclSpace.FindNestedType): New public method.
3735 (DeclSpace.FindType): Added `int num_type_args' argument; only
3736 return types with the correct number of type parameters.
3737 (DeclSpace.CountTypeParams): New public property.
3739 * ecore.cs (SimpleName.ctor): Added overloaded version which takes
3740 the number of type parameters; defaults to zero.
3742 * generic.cs (TypeArguments.Count): New public property.
3743 (ConstructedType.DoResolveAsTypeStep): First call
3744 ds.FindNestedType() to find out whether we're nested in the
3745 current generic type; in this case, we inherit all type parameters
3746 from the current class.
3748 * rootcontext.cs (RootContext.NamespaceLookup): Added `int
3749 num_type_args' argument.
3750 (RootContext.LookupType): Added overloaded version which takes the
3751 number of type arguments; only return types with the correct
3752 number of type arguments.
3754 * typemanager.cs (TypeManager.CheckGeneric): New public function;
3755 checks whether `Type t' has `int num_type_args'.
3757 2004-03-13 Martin Baulig <martin@ximian.com>
3759 * generic.cs (GenericMethod.DefineType): New method; calls
3760 DefineType() on all the type parameters.
3762 * class.cs (MethodData.ctor): Added `GenericMethod generic' argument.
3763 (MethodData.Define): If we're a generic method, call
3764 GenericMethod.DefineType() to define the type parameters.
3766 2004-03-10 Martin Baulig <martin@ximian.com>
3768 * pending.cs (Pending.InterfaceMethod): Use TypeManager.IsEqual()
3769 instead of IsAssignableFrom.
3771 2004-03-10 Martin Baulig <martin@ximian.com>
3773 * ecore.cs (FieldExpr.ctor): Use TypeManager.TypeToCoreType().
3775 * support.cs (ParameterData.HasArrayParameter): New property.
3776 (ReflectionParameters.ctor): Take a MethodBase instead of a
3777 ParameterInfo[]. If we have any type parameters, get the generic
3778 method definition and ask it whether we have variable arguments.
3780 2004-02-26 Miguel de Icaza <miguel@ximian.com>
3782 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
3783 routines to check if a type is an enumerable/enumerator allow
3784 classes that implement the IEnumerable or IEnumerator interfaces.
3786 * class.cs (Property, Operator): Implement IIteratorContainer, and
3787 implement SetYields.
3789 (Property.Define): Do the block swapping for get_methods in the
3790 context of iterators. We need to check if Properties also
3791 include indexers or not.
3793 (Operator): Assign the Block before invoking the
3794 OperatorMethod.Define, so we can trigger the Iterator code
3797 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
3798 Property and Operator classes are not created when we parse the
3799 declarator but until we have the block completed, so we use a
3800 singleton SimpleIteratorContainer.Simple to flag whether the
3801 SetYields has been invoked.
3803 We propagate this setting then to the Property or the Operator to
3804 allow the `yield' to function.
3806 2004-02-25 Marek Safar <marek.safar@seznam.cz>
3808 * codegen.cs: Implemented attribute support for modules.
3809 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
3810 Assembly/Module functionality.
3812 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
3813 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
3814 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
3816 2004-02-16 Marek Safar <marek.safar@seznam.cz>
3818 * interface.cs (FindMembers): The operation is performed on all base
3819 interfaces and not only on the first. It is required for future CLS Compliance patch.
3821 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
3823 * statement.cs, codegen.cs:
3824 This patch deals with patterns such as:
3826 public class List : IEnumerable {
3828 public MyEnumerator GetEnumerator () {
3829 return new MyEnumerator(this);
3832 IEnumerator IEnumerable.GetEnumerator () {
3836 public struct MyEnumerator : IEnumerator {
3841 Before, there were a few things we did wrong:
3842 1) we would emit callvirt on a struct, which is illegal
3843 2) we emited ldarg when we needed to emit ldarga
3844 3) we would mistakenly call the interface methods on an enumerator
3845 type that derived from IEnumerator and was in another assembly. For example:
3847 public class MyEnumerator : IEnumerator
3849 Would have the interface methods called, even if there were public impls of the
3850 method. In a struct, this lead to invalid IL code.
3852 2004-02-11 Marek Safar <marek.safar@seznam.cz>
3854 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
3857 * delegate.cs (Define): Fixed crash when delegate type is undefined.
3859 2004-02-11 Miguel de Icaza <miguel@ximian.com>
3861 * cs-parser.jay: Fix small regression: we were not testing V2
3862 compiler features correctly.
3864 * interface.cs: If the emit context is null, then create one
3866 2004-02-09 Marek Safar <marek.safar@seznam.cz>
3868 * decl.cs (GetSignatureForError): New virtual method to get full name
3871 * attribute.cs (IAttributeSupport): New interface for attribute setting.
3872 Now it is possible to rewrite ApplyAttributes method to be less if/else.
3874 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
3875 Duplicated members and code in these classes has been removed.
3876 Better encapsulation in these classes.
3878 2004-02-07 Miguel de Icaza <miguel@ximian.com>
3880 * assign.cs (Assign.DoResolve): When dealing with compound
3881 assignments, there is a new rule in ECMA C# 2.4 (might have been
3882 there before, but it is documented here) that states that in:
3886 If b is of type int, and the `op' is a shift-operator, then the
3887 above is evaluated as:
3891 * expression.cs (Binary.ResolveOperator): Instead of testing for
3892 int/uint/long/ulong, try to implicitly convert to any of those
3893 types and use that in pointer arithmetic.
3895 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
3896 method to print information for from the type, not from the
3897 null-method we were given.
3899 2004-02-01 Duncan Mak <duncan@ximian.com>
3901 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
3902 parsing for cmd, fixes bug #53694.
3904 2004-02-04 Marek Safar <marek.safar@seznam.cz>
3906 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
3907 in the member name duplication tests. Property and operator name duplication
3908 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
3910 2004-02-03 Marek Safar <marek.safar@seznam.cz>
3912 * interface.cs (PopulateMethod): Fixed crash when interface method
3913 returns not existing type (error test cs0246-3.cs).
3915 2004-02-02 Ravi Pratap M <ravi@ximian.com>
3917 * cs-parser.jay (interface_accessors): Re-write actions to also
3918 store attributes attached to get and set methods. Fix spelling
3921 (inteface_property_declaration): Modify accordingly.
3923 (InterfaceAccessorInfo): New helper class to store information to pass
3924 around between rules that use interface_accessors.
3926 * interface.cs (Emit): Apply attributes on the get and set
3927 accessors of properties and indexers too.
3929 * attribute.cs (ApplyAttributes): Modify accordingly to use the
3930 right MethodBuilder when applying attributes to the get and set accessors.
3932 2004-01-31 Miguel de Icaza <miguel@ximian.com>
3934 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
3936 2004-01-26 Miguel de Icaza <miguel@ximian.com>
3938 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
3940 2004-01-25 Miguel de Icaza <miguel@ximian.com>
3942 * cs-parser.jay: Remove YIELD token, instead use the new grammar
3943 changes that treat `yield' specially when present before `break'
3946 * cs-tokenizer.cs: yield is no longer a keyword.
3948 2004-01-23 Marek Safar <marek.safar@seznam.cz>
3950 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
3951 setting for default constructors.
3952 For default constructors are almost every time set wrong Modifier. The
3953 generated IL code has been alright. But inside mcs this values was
3954 wrong and this was reason why several of my CLS Compliance tests
3957 2004-02-27 Martin Baulig <martin@ximian.com>
3959 * generics.cs (ConstructedType.ResolveType): Make the nested type
3960 stuff actually work.
3962 2004-02-25 Martin Baulig <martin@ximian.com>
3964 * decl.cs (DeclSpace.CurrentTypeParameters): New protected
3965 property; returns the type parameters just from the current type,
3966 ie. with the ones from outer classes.
3967 (DeclSpace.LookupGeneric): First search in the current class, then
3969 (DeclSpace.initialize_type_params): When hiding a type parameter
3970 from an outer class, put it into the `type_param_list' anyways.
3972 * expression.cs (MemberAccess.expr): Made this field protected.
3974 * class.cs (TypeContainer.Define): The `CurrentType' just contains
3975 the type parameters from the current class.
3977 * generic.cs (ConstructedType.ResolveType): Support nested generic
3978 types by taking the type parameters which we inherit from outer
3979 classes into account.
3980 (GenericMemberAccess.ResolveAsTypeStep): Override this and added
3981 support for nested generic types.
3983 2004-02-23 Martin Baulig <martin@ximian.com>
3985 * decl.cs (DeclSpace.IsGeneric): Make this a property instead of a
3986 field and check whether we're nested inside a generic type.
3987 (DeclSpace.ResolveType): If we're resolving to a generic type
3988 definition, create a ConstructedType and return its resolved type.
3989 (DeclSpace.initialize_type_params): New private method;
3990 initializes the `type_param_list' field from the type parameters
3991 from this and all enclosing classes.
3992 (DeclSpace.TypeParameters): Call initialize_type_params() unless
3993 we're already initialized.
3995 2004-02-23 Martin Baulig <martin@ximian.com>
3997 * class.cs (Method.Define): Create the generic method before
3999 (Memberbase.DoDefine): Added DeclSpace argument (in addition to
4000 the TypeContainer one); we use this for generic methods.
4002 * decl.cs (CheckAccessLevel): If we're a GenericMethod, use our
4003 parent's TypeBuilder.
4005 2004-02-18 Martin Baulig <martin@ximian.com>
4007 * ecore.cs (FieldExpr.DoResolveLValue): Use TypeManager.IsEqual()
4008 to check for equality.
4010 2004-02-05 Martin Baulig <martin@ximian.com>
4012 * ecore.cs (FieldExpr.DoResolveLValue): If we have an
4013 `ec.TypeContainer.CurrentType', use it instead of
4014 `ec.ContainerType' to check whether we're in the type's ctor.
4016 2004-01-29 Martin Baulig <martin@ximian.com>
4018 * expression.cs (Invocation.DoResolve): If we're a
4019 `ConstructedType', then we're actually a generic method, so
4020 rewrite the expr as a GenericMemberAccess.
4022 * cs-parser.jay (member_name): Don't use `namespace_or_type_name'
4023 here; manually parse it into a string.
4025 2004-01-28 Martin Baulig <martin@ximian.com>
4027 * typemanager.cs (TypeManager.IsEqual): New static method.
4028 (TypeManager.FilterWithClosure): Call TypeManager.IsEqual() to
4029 check for equality instead of using `=='.
4031 2004-01-26 Martin Baulig <martin@ximian.com>
4033 * decl.cs (DeclSpace.CurrentType): New public field.
4035 * expression.cs (This.ResolveBase): If we have an
4036 `ec.TypeContainer.CurrentType', use it instead of
4039 * class.cs (TypeContainer.DefineType): If we're a generic type,
4040 create the `CurrentType' (unresolved).
4041 (TypeContainer.GenericType): New private field.
4042 (TypeContainer.DefineMembers): If we have a `CurrentType', resolve
4043 it and store it in `GenericType' before creating the MemberCache.
4044 (TypeContainer.GetMembers): If we have a `GenericType', call
4045 TypeManager.FindMembers() on it.
4047 * interface.cs (Interface.GenericType): New private field.
4048 (Interface.DefineType): If we're a generic type, create the
4049 `CurrentType' (unresolved).
4050 (Interface.DefineMembers): If we have a `CurrentType', resolve it
4051 and store it in `GenericType' before creating the MemberCache.
4052 (Interface.GetMembers): If we have a `GenericType', call
4053 TypeManager.FindMembers() on it.
4055 2004-01-22 Martin Baulig <martin@ximian.com>
4057 * cs-parser.jay (namespace_or_type_name): Return an Expression,
4058 not a QualifiedIdentifier. This is what `type_name_expression'
4059 was previously doing.
4060 (type_name_expression): Removed; the code is now in
4061 `namespace_or_type_name'.
4062 (qualified_identifier): Removed, use `namespace_or_type_name'
4064 (QualifiedIdentifier): Removed this class.
4066 2004-01-22 Martin Baulig <martin@ximian.com>
4068 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
4069 not a string as alias name.
4071 2004-01-21 Miguel de Icaza <miguel@ximian.com>
4073 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
4074 #52730 bug, and instead compute correctly the need to use a
4075 temporary variable when requesting an address based on the
4076 static/instace modified of the field and the constructor.
4078 2004-01-21 Martin Baulig <martin@ximian.com>
4080 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
4081 class and namespace before looking up aliases. Fixes #52517.
4083 2004-01-21 Martin Baulig <martin@ximian.com>
4085 * flowanalysis.cs (UsageVector.Merge): Allow variables being
4086 assinged in a 'try'; fixes exception4.cs.
4088 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4089 * class.cs : Implemented parameter-less constructor for TypeContainer
4091 * decl.cs: Attributes are now stored here. New property OptAttributes
4093 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
4095 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
4097 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4099 * typemanager.cs (CSharpSignature): Now reports also inner class name.
4100 (CSharpSignature): New method for indexer and property signature.
4102 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4104 * pending.cs (IsVirtualFilter): Faster implementation.
4106 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4108 * typemanager.cs: Avoid inclusion of same assembly more than once.
4110 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4112 * cs-parser.jay: Fixed problem where the last assembly attribute
4113 has been applied also to following declaration (class, struct, etc.)
4115 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4117 * class.cs: Added error CS0538, CS0539 reporting.
4118 Fixed crash on Microsoft runtime when field type is void.
4120 * cs-parser.jay: Added error CS0537 reporting.
4122 * pending.cs: Added error CS0535 reporting.
4123 Improved error report for errors CS0536, CS0534.
4125 2004-01-20 Miguel de Icaza <miguel@ximian.com>
4127 Merge a few bits from the Anonymous Method MCS tree.
4129 * statement.cs (ToplevelBlock): New class for toplevel methods,
4130 will hold anonymous methods, lifted variables.
4132 * cs-parser.jay: Create toplevel blocks for delegates and for
4133 regular blocks of code.
4135 2004-01-20 Martin Baulig <martin@ximian.com>
4137 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
4138 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
4139 and `NeedExplicitReturn'; added `IsLastStatement'.
4140 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
4141 have a `ReturnLabel' or we're not unreachable.
4143 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
4144 child's reachability; don't just override ours with it. Fixes
4145 #58058 (lluis's example).
4146 (FlowBranching): Added public InTryOrCatch(), InCatch(),
4147 InFinally(), InLoop(), InSwitch() and
4148 BreakCrossesTryCatchBoundary() methods.
4150 * statement.cs (Return): Do all error checking in Resolve().
4151 Unless we are the last statement in a top-level block, always
4152 create a return label and jump to it.
4153 (Break, Continue): Do all error checking in Resolve(); also make
4154 sure we aren't leaving a `finally'.
4155 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
4156 statement in a top-level block.
4157 (Block.Flags): Added `IsDestructor'.
4158 (Block.IsDestructor): New public property.
4160 2004-01-20 Martin Baulig <martin@ximian.com>
4162 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
4164 2004-01-20 Martin Baulig <martin@ximian.com>
4166 * statement.cs (Statement.ResolveUnreachable): New public method.
4167 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
4168 (Block.Resolve): Resolve unreachable statements.
4170 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
4172 * expression.cs: We need to fix the case where we do
4173 not have a temp variable here.
4175 * assign.cs: Only expression compound assignments need
4176 temporary variables.
4178 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
4180 * flowanalysis.cs: Reduce memory allocation in a few ways:
4181 - A block with no variables should not allocate a bit
4183 - A method with no out parameters does not need any tracking
4184 for assignment of the parameters, so we need not allocate
4187 public readonly Type[] VariableTypes;
4188 public readonly string[] VariableNames;
4189 Are redundant. The data is already stored in the variable
4190 map, so we need not allocate another array for it.
4191 - We need to add alot of checks for if (params | locals) == null
4192 due to the first two changes.
4194 2004-01-18 Miguel de Icaza <miguel@ximian.com>
4196 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
4197 implement IMemoryLocation, we store a copy on a local variable and
4198 take the address of it. Patch from Benjamin Jemlich
4200 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
4201 to use a special "type_name_expression" rule which reduces the
4202 number of "QualifiedIdentifier" classes created, and instead
4203 directly creates MemberAccess expressions.
4205 2004-01-17 Miguel de Icaza <miguel@ximian.com>
4207 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
4208 that fixes #52853. Null literal assignment to ValueType
4210 * class.cs (MethodData.Emit): Instead of checking the name of the
4211 method to determine if its a destructor, create a new derived
4212 class from Method called Destructor, and test for that.
4214 * cs-parser.jay: Create a Destructor object instead of a Method.
4216 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
4220 2004-01-16 Miguel de Icaza <miguel@ximian.com>
4222 * expression.cs (Binary.ResolveOperator): Perform an implicit
4223 conversion from MethodGroups to their delegate types on the
4226 * delegate.cs: Introduce a new class DelegateCreation that is the
4227 base class for `NewDelegate' and `ImplicitDelegateCreation',
4228 factor some code in here.
4230 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
4231 conversion from MethodGroups to compatible delegate types.
4233 * ecore.cs (Expression.Resolve): Do not flag error 654
4234 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
4235 we allow conversions from MethodGroups to delegate types now.
4237 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
4238 assignments in v2 either.
4240 2004-01-10 Miguel de Icaza <miguel@ximian.com>
4242 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
4243 static read-only fields in ctors.
4245 Applied patch from Benjamin Jemlich
4247 * expression.cs (UnaryMutator): Avoid leaking local variables.
4249 2004-01-09 Miguel de Icaza <miguel@ximian.com>
4251 * cs-tokenizer.cs (IsCastToken): Allow the various native types
4252 here to return true, as they can be used like this:
4256 Fixed 49836 and all the other dups
4258 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
4260 * driver.cs: Implement /win32res and /win32icon.
4262 2004-01-08 Miguel de Icaza <miguel@ximian.com>
4264 * cs-parser.jay: Add a rule to improve error handling for the
4265 common mistake of placing modifiers after the type.
4267 2004-01-07 Miguel de Icaza <miguel@ximian.com>
4269 * cs-parser.jay (interface_event_declaration): Catch
4270 initialization of events on interfaces, and report cs0068
4272 * cs-parser.jay (interface_event_declaration): Catch
4273 initialization of events.
4275 * ecore.cs: Better report missing constructors.
4277 * expression.cs (Binary.ResolveOperator): My previous bug fix had
4278 the error reporting done in the wrong place. Fix.
4280 * expression.cs (Binary.ResolveOperator): Catch the
4281 operator + (E x, E y) error earlier, and later allow for implicit
4282 conversions in operator +/- (E e, U x) from U to the underlying
4285 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
4286 52596, if the container class is abstract, the default constructor
4287 is protected otherwise its public (before, we were always public).
4289 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
4292 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
4293 Jemlich that fixes bug #52597, MCS was generating invalid code for
4294 idisposable structs. Thanks to Ben for following up with this
4297 2004-01-06 Miguel de Icaza <miguel@ximian.com>
4299 * driver.cs: Allow assemblies without code to be generated, fixes
4302 2004-01-07 Nick Drochak <ndrochak@gol.com>
4304 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
4306 2004-01-05 Miguel de Icaza <miguel@ximian.com>
4308 * cs-parser.jay: Add rules to improve error reporting if fields or
4309 methods are declared at the namespace level (error 116)
4311 * Add rules to catch event add/remove
4313 2004-01-04 David Sheldon <dave-mono@earth.li>
4315 * expression.cs: Added matching ")" to error message for
4318 2004-01-03 Todd Berman <tberman@gentoo.org>
4320 * ecore.cs, attribute.cs:
4321 Applying fix from #52429.
4323 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
4325 * ecore.cs, expression.cs, statement.cs:
4326 Total rewrite of how we handle branching. We
4327 now handle complex boolean expressions with fewer
4328 jumps. As well if (x == 0) no longer emits a ceq.
4330 if (x is Foo) is much faster now, because we generate
4333 Overall, we get a pretty big improvement on our benchmark
4334 tests. The code we generate is smaller and more readable.
4336 I did a full two-stage bootstrap. The patch was reviewed
4337 by Martin and Miguel.
4339 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
4341 * cs-parser.jay: Make primary_expression not take a QI.
4342 we dont need this because the member_access rule covers
4343 us here. So we replace the rule with just IDENTIFIER.
4345 This has two good effects. First, we remove a s/r conflict.
4346 Second, we allocate many fewer QualifiedIdentifier objects.
4348 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
4350 * attribute.cs: Handle MarshalAs attributes as pseudo, and
4351 set the correct information via SRE. This prevents
4352 hanging on the MS runtime. Fixes #29374.
4354 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
4356 * convert.cs: correctly handle conversions to value types
4357 from Enum and ValueType as unboxing conversions.
4359 Fixes bug #52569. Patch by Benjamin Jemlich.
4361 2004-01-02 Ravi Pratap <ravi@ximian.com>
4363 * expression.cs (BetterConversion): Prefer int -> uint
4364 over int -> ulong (csc's behaviour). This fixed bug #52046.
4366 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
4368 * decl.cs (MemberCache.FindMembers): now returns a
4371 * typemanager.cs: In general, go with with ^^.
4372 (CopyNewMethods): take an IList.
4373 (RealMemberLookup): Only allocate an arraylist
4374 if we copy from two sets of methods.
4376 This change basically does two things:
4377 1) Fewer array lists allocated due to CopyNewMethods.
4378 2) the explicit cast in MemberList costed ALOT.
4380 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
4382 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
4383 a hashtable to avoid needless string allocations when an identifier is
4384 used more than once (the common case).
4386 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
4388 * pending.cs: MS's TypeBuilder.GetInterfaces ()
4389 is broken, it will not return anything. So, we
4390 have to use the information we have in mcs to
4393 * typemanager.cs: Add a cache for GetInterfaces,
4394 since this will now be used more often (due to ^^)
4396 (GetExplicitInterfaces) New method that gets the
4397 declared, not effective, interfaces on a type
4398 builder (eg, if you have interface IFoo, interface
4399 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
4402 This patch makes MCS able to bootstrap itself on
4405 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
4407 * expression.cs: Remove the Nop's that Miguel put
4410 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
4412 * report.cs, codegen.cs: Give the real stack trace to
4413 the error when an exception is thrown.
4415 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
4417 * decl.cs: only allocate hashtables for ifaces if
4420 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
4422 * expression.cs: fix the error from cs0121-2.cs
4423 (a parent interface has two child interfaces that
4424 have a function with the same name and 0 params
4425 and the function is called through the parent).
4427 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
4429 * class.cs, rootcontext.cs, typmanager.cs: do not
4432 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
4434 * codegen.cs: remove stack for the ec flow branching.
4435 It is already a linked list, so no need.
4437 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
4439 * Makefile: Allow custom profiler here.
4441 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
4443 * typemanager.cs (LookupType):
4444 - Use a static char [], because split takes
4445 a param array for args, so it was allocating
4447 - Do not store true in a hashtable, it boxes.
4449 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
4451 * flowanalysis.cs: bytify common enums.
4453 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
4455 * modifiers.cs: Add a new set of flags for the
4456 flags allowed on explicit interface impls.
4457 * cs-parser.jay: catch the use of modifiers in
4458 interfaces correctly.
4459 * class.cs: catch private void IFoo.Blah ().
4461 All related to bug #50572.
4463 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
4465 * decl.cs: Rewrite the consistant accessability checking.
4466 Accessability is not linear, it must be implemented in
4467 a tableish way. Fixes #49704.
4469 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
4471 * expression.cs: Handle negation in a checked context.
4472 We must use subtraction from zero. Fixes #38674.
4474 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
4476 * class.cs: Ignore static void main in DLLs.
4477 * rootcontext.cs: Handle the target type here,
4478 since we are have to access it from class.cs
4479 * driver.cs: account for the above.
4481 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
4483 * report.cs: Give line numbers and files if available.
4485 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
4487 * driver.cs: Implement /addmodule.
4489 * typemanager.cs: Change 'modules' field so it now contains Modules not
4492 2003-12-20 Martin Baulig <martin@ximian.com>
4494 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
4495 (FieldBase.IsAssigned): Removed this field.
4496 (FieldBase.SetAssigned): New public method.
4497 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
4499 2003-12-20 Martin Baulig <martin@ximian.com>
4501 * expression.cs (LocalVariableReference.DoResolve): Don't set
4502 `vi.Used' if we're called from DoResolveLValue().
4504 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
4505 returns the usage vector it just merged into the current one -
4506 pass this one to UsageWarning().
4507 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
4508 of the `EmitContext', don't call this recursively on our children.
4510 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
4512 * driver.cs: Implement /target:module.
4514 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
4516 * support.cs (CharArrayHashtable): New helper class.
4518 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
4519 char arrays, not strings, so we can avoid creating a string in
4520 consume_identifier if the identifier is a keyword.
4522 2003-12-16 Martin Baulig <martin@ximian.com>
4524 * statement.cs (LocalInfo.Assigned): Removed this property.
4525 (LocalInfo.Flags): Removed `Assigned'.
4526 (LocalInfo.IsAssigned): New public method; takes the EmitContext
4527 and uses flow analysis.
4528 (Block.UsageWarning): Made this method private.
4529 (Block.Resolve): Call UsageWarning() if appropriate.
4531 * expression.cs (LocalVariableReference.DoResolve): Always set
4532 LocalInfo.Used here.
4534 2003-12-13 Martin Baulig <martin@ximian.com>
4536 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
4537 any value here; we're now using flow analysis to figure out
4538 whether a statement/block returns a value.
4540 2003-12-13 Martin Baulig <martin@ximian.com>
4542 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
4544 (FlowBranching.MergeFinally): Don't call
4545 `branching.CheckOutParameters()' here, this is called in
4547 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
4548 when adding the `finally' vector.
4550 2003-12-13 Martin Baulig <martin@ximian.com>
4553 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
4554 actually work and also fix #48962.
4556 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
4558 * decl.cs: Do not check System.Object for nested types,
4559 since we know it does not have any. Big bang for buck:
4564 corlib: 17.99 seconds
4568 corlib: 17.39 seconds
4570 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
4572 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
4573 time we are returning 0 members, so we save alot here.
4575 2003-12-11 Martin Baulig <martin@ximian.com>
4577 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
4578 `MergeChild()', also just take the `FlowBranching' as argument;
4579 call Merge() on it and return the result.
4580 (FlowBranching.Merge): We don't need to do anything if we just
4583 2003-12-11 Martin Baulig <martin@ximian.com>
4585 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
4586 them in an `ArrayList' to reduce memory usage. Thanks to Ben
4587 Maurer for this idea.
4589 2003-12-11 Martin Baulig <martin@ximian.com>
4591 * flowanalysis.cs (MergeResult): This class is now gone; we now
4592 use the `UsageVector' for this. The reason for this is that if a
4593 branching just has one sibling, we don't need to "merge" them at
4594 all - that's the next step to do.
4595 (FlowBranching.Merge): We now return a `UsageVector' instead of a
4598 2003-12-11 Martin Baulig <martin@ximian.com>
4600 Reworked flow analyis and made it more precise and bug-free. The
4601 most important change is that we're now using a special `Reachability'
4602 class instead of having "magic" meanings of `FlowReturns'. I'll
4603 do some more cleanups and optimizations and also add some more
4604 documentation this week.
4606 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
4607 largely reworked this class.
4608 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
4609 the new `Reachability' class instead of having "magic" values here.
4610 (FlowBranching): We're now using an instance of `Reachability'
4611 instead of having separate `Returns', `Breaks' etc. fields.
4613 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
4614 based on flow analysis; ignore the return value of block.Emit ().
4616 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
4618 * driver.cs typemanager.cs: Find the mono extensions to corlib even
4619 if they are private.
4621 2003-12-09 Martin Baulig <martin@ximian.com>
4623 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
4624 call them directly on the UsageVector.
4626 2003-12-09 Martin Baulig <martin@ximian.com>
4628 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
4629 Changed return type from `FlowReturns' to `Reachability'.
4631 2003-12-09 Martin Baulig <martin@ximian.com>
4633 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
4634 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
4635 `Reachable' fields with a single `Reachability' one.
4637 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
4639 * class.cs (FindMembers): Remove foreach's.
4652 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
4657 This patch does a few things:
4658 1. EmptyStatement is now a singleton, so it is never reallocated.
4659 2. All blah is EmptyStatement constructs have been changed to
4660 blah == EmptyStatement.Value, which is much faster and valid
4661 now that EmptyStatement is a singleton.
4662 3. When resolving a block, rather than allocating a new array for
4663 the non-empty statements, empty statements are replaced with
4664 EmptyStatement.Value
4665 4. Some recursive functions have been made non-recursive.
4666 Mainly the performance impact is from (3), however (1) and (2) are needed for
4667 this to work. (4) does not make a big difference in normal situations, however
4668 it makes the profile look saner.
4673 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
4674 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
4675 Total memory allocated: 56397 KB
4678 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
4679 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
4680 Total memory allocated: 55666 KB
4682 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
4684 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
4685 than the hashtable in a hashtable version
4687 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
4688 we always end up concating a string. This results in a huge perf
4689 loss, because many strings have to be tracked by the GC. In this
4690 patch, we first use a hashtable that works with two keys, so that
4691 the strings do not need to be concat'ed.
4702 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
4704 * Makefile: Add a new target `do-time' that does a quick and simple
4705 profile, leaving easy to parse output.
4707 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
4709 * codegen.cs (Init): Create the dynamic assembly with
4710 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
4712 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
4714 * support.cs: Make the PtrHashtable use only one
4715 instance of its comparer.
4717 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
4719 * typemanager.cs: Fix lookup of GetNamespaces.
4721 2003-11-29 Miguel de Icaza <miguel@ximian.com>
4723 * expression.cs: Removed redundant line.
4725 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
4726 ArrayLists, use for loops with bounds.
4728 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
4731 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
4732 arraylists, use for loop with bounds.
4734 The above three changes give us a 0.071 second performance
4735 improvement out of 3.294 seconds down to 3.223. On my machine
4736 the above changes reduced the memory usage by 1,387 KB during
4739 * cs-parser.jay (QualifiedIdentifier): New class used to represent
4740 QualifiedIdentifiers. Before we created a new string through
4741 concatenation, and mostly later on, the result would be
4742 manipulated by DecomposeQI through string manipulation.
4744 This reduced the compiler memory usage for bootstrapping from
4745 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
4746 compile times in 0.05 seconds.
4748 2003-11-28 Dick Porter <dick@ximian.com>
4750 * support.cs: Do string compares with the Invariant culture.
4758 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
4759 the comparison is done with the Invariant culture.
4761 2003-11-27 Miguel de Icaza <miguel@ximian.com>
4763 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
4764 GetEnumerator method.
4766 (ProbeCollectionType): Iterate starting at the most specific type
4767 upwards looking for a GetEnumerator
4769 * expression.cs: Shift count can be up to 31 for int/uint and 63
4772 2003-11-26 Miguel de Icaza <miguel@ximian.com>
4774 * statement.cs (Block.LookupLabel): Also look for the label on the
4775 children blocks. Use a hash table to keep track of visited
4778 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
4779 we actually did transform the other operand, otherwise fall back
4780 to the common codepath that casts to long.
4782 * cs-tokenizer.cs: Use the same code pattern as the int case.
4783 Maybe I should do the parsing myself, and avoid depending on the
4784 Parse routines to get this done.
4786 2003-11-25 Miguel de Icaza <miguel@ximian.com>
4788 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
4789 which fixes bug 51347. This time test it.
4791 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
4792 attributes for example can not tell the difference between these.
4793 The difference was only a syntax feature of the language.
4795 * attribute.cs: Apply attributes to delegates.
4797 * delegate.cs: Call the apply attributes method.
4799 2003-11-24 Miguel de Icaza <miguel@ximian.com>
4801 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
4802 comparing 0 vs Byte.MinValue, not the value
4804 (ImplicitConversionRequired): When reporting a conversion error,
4805 use error 31 to print out the constant error instead of the
4808 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
4809 which fixes bug 51347.
4811 2003-11-22 Miguel de Icaza <miguel@ximian.com>
4813 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
4814 which fixes the -warnaserror command line option.
4816 2003-11-21 Miguel de Icaza <miguel@ximian.com>
4818 * cfold.cs (DoNumericPromotions): During constant folding of
4819 additions on UIntConstant, special case intconstants with
4820 IntConstants like we do on the expression binary operator.
4822 2003-11-12 Miguel de Icaza <miguel@ximian.com>
4824 * convert.cs (ImplicitReferenceConversion): We were missing a case
4825 (System.Enum are not value types or class types, so we need to
4826 classify them separatedly).
4828 * driver.cs: We do not support error 2007.
4830 2003-11-12 Jackson Harper <jackson@ximian.com>
4832 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
4833 system directory. Also use the full file name so users can
4834 libraries names mscorlib-o-tron.dll in a non system dir.
4836 2004-01-04 David Sheldon <dave-mono@earth.li>
4838 * expression.cs: Added matching ")" to error message for CS0077.
4840 2003-12-19 Martin Baulig <martin@ximian.com>
4842 * typemanager.cs (TypeManager.IsEqualGenericType): New public
4843 static method; see documentation in the method.
4844 (TypeManager.IsSubclassOrNestedChild): Allow IsEqualGenericType().
4846 * convert.cs (Convert.ImplicitReferenceConversion,
4847 Convert.ImplicitReferenceConversionExists): Add support for
4848 generic type declarations; see gen-36.cs.
4850 2003-12-19 Martin Baulig <martin@ximian.com>
4852 * pending.cs (Pending.InterfaceMethod): Use
4853 `Type.IsAssignableFrom()' instead of `=='.
4855 2003-12-18 Martin Baulig <martin@ximian.com>
4857 * decl.cs (DeclSpace.AsAccessible): Check for array, pointer and
4860 * convert.cs (Convert.ImplicitStandardConversionExists): Use
4861 `expr_type.Equals (target_type)' instead of `=='.
4863 2003-12-08 Martin Baulig <martin@ximian.com>
4865 * generics.cs (Constraints.Types): Removed.
4866 (Constraints.Resolve): Just resolve everything to TypeExpr's, not
4868 (Constraints.ResolveTypes): New public method; resolves the
4869 TypeExpr's to Type's.
4870 (TypeParameter.Define): TypeBuilder.DefineGenericParameter() no
4871 longer takes the constraints.
4872 (TypeParameter.DefineMethod): Likewise.
4873 (TypeParameter.DefineType): New public method. Calls
4874 `TypeBuilder/MethodBuilder.SetGenericParameterConstraints()' to set
4877 2003-12-08 Martin Baulig <martin@ximian.com>
4879 * convert.cs (Convert.ImplicitConversionStandard): Use
4880 `expr_type.Equals (target_type)' instead of `=='.
4882 2003-12-08 Martin Baulig <martin@ximian.com>
4884 * typemanager.cs (TypeManager.GetReferenceType): Call
4885 `Type.MakeByRefType ()'.
4887 2003-12-08 Martin Baulig <martin@ximian.com>
4889 * cs-parser.jay, cs-tokenizer.cs: `where' is not a keyword, it
4890 just has some special meaning in some situations. For instance,
4891 it is allowed to use `where' as the name of a variable etc.
4893 2003-12-04 Martin Baulig <martin@ximian.com>
4895 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
4896 `Type.MakeArrayType()' for array types.
4898 2003-11-18 Miguel de Icaza <miguel@ximian.com>
4900 * expression.cs (Invocation.VerifyArgumentsCompat): Remove
4903 (SizeOf.DoResolve): assign the `type_queried' field. This gets
4906 2003-11-16 Martin Baulig <martin@ximian.com>
4908 * codegen.cs (EmitContext.IsGeneric): Removed.
4910 * ecore.cs (SimpleName.ResolveAsTypeStep): Always call
4911 ResolveGeneric() on the DeclSpace.
4913 2003-11-16 Martin Baulig <martin@ximian.com>
4915 * generic.cs (TypeArguments.Resolve):
4916 `Expression.ResolveAsTypeTerminal()' returns a TypeExpr; call
4917 `ResolveType()' on it to get the Type.
4919 2003-11-15 Martin Baulig <martin@ximian.com>
4921 * generic.cs (ConstructedType.GetInterfaces): Override this.
4923 2003-11-14 Martin Baulig <martin@ximian.com>
4925 * interface.cs (Interface.DefineType): Define all type parameters
4926 before adding the interfaces we inherit.
4928 2003-11-11 Martin Baulig <martin@ximian.com>
4930 * generic.cs (ConstructedType.ResolveType): Always call
4931 `gt.BindGenericParameters (atypes)'; also if `args.HasTypeArguments'.
4933 2003-11-10 Martin Baulig <martin@ximian.com>
4935 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
4936 (TypeManager.InitCoreTypes): Initialize them here, but instead of
4937 calling `ResolveType()' on them, directly assign their `Type'.
4939 2003-11-08 Martin Baulig <martin@ximian.com>
4941 * generic.cs (ConstructedType): Override `IsClass' etc.
4943 2003-11-08 Martin Baulig <martin@ximian.com>
4945 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
4946 return value and the `out parent' parameter.
4947 (TypeContainer.DefineType): Moved the CS0644 check into
4948 GetClassBases(). Don't pass the interface types to the
4949 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
4950 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
4952 * ecore.cs (TypeExpr.IsAttribute): New property.
4953 (TypeExpr.GetInterfaces): New method.
4955 * interface.cs (Interface.GetInterfaceTypeByName): Return a
4956 TypeExpr instead of a Type.
4957 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
4958 (Interface.DefineType): Don't pass the interface types to the
4959 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
4960 them later and then call `TypeBulider.AddInterfaceImplementation()'.
4962 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
4963 instead of a `Type[]'.
4964 (TypeManager.RegisterBuilder): Likewise.
4965 (TypeManager.AddUserInterface): Likewise.
4966 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
4967 `Type[]' and also return a `TypeExpr[]'.
4968 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
4970 2003-11-08 Martin Baulig <martin@ximian.com>
4972 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
4975 2003-11-08 Martin Baulig <martin@ximian.com>
4977 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
4978 TypeManager.ResolveExpressionTypes().
4980 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
4981 instead of an Expression.
4982 (TypeExpr): This is now an abstract base class for `TypeExpression'.
4983 (TypeExpression): New public class; formerly known as `TypeExpr'.
4985 * expression.cs (ComposedCast): Derive from TypeExpr.
4987 * typemanager.cs (TypeManager.system_*_expr): These are now
4988 TypExpr's instead of Expression's.
4989 (TypeManager.ResolveExpressionTypes): New public static function;
4990 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
4993 2003-11-06 Miguel de Icaza <miguel@ximian.com>
4995 * expression.cs (New.DoResolve): Do not dereference value that
4996 might be a null return.
4998 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
4999 sure that the constant value has the right type. Fixes an
5000 unreported bug, similar to 50425.
5002 * const.cs (Const.LookupConstantValue): Call
5003 ImplicitStandardConversionExists before doing a conversion to
5004 avoid havng the TypeManager.ChangeType do conversions.
5006 Reduced the number of casts used
5008 (Const.ChangeType): New routine to enable reuse of the constant
5009 type changing code from statement.
5011 * typemanager.cs (ChangeType): Move common initialization to
5012 static global variables.
5016 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
5017 every value type to go through, even if it was void. Fix that.
5019 * cs-tokenizer.cs: Use is_identifier_start_character on the start
5020 character of the define, and the is_identifier_part_character for
5021 the rest of the string.
5023 2003-11-05 Miguel de Icaza <miguel@ximian.com>
5025 * expression.cs (UnaryMutator.EmitCode): When I updated
5026 LocalVariableReference.DoResolve, I overdid it, and dropped an
5027 optimization done on local variable references.
5029 2003-11-04 Miguel de Icaza <miguel@ximian.com>
5031 * ecore.cs: Convert the return from Ldlen into an int.
5033 2003-10-20 Miguel de Icaza <miguel@ximian.com>
5035 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
5036 the accessibility, this is a special case for toplevel non-public
5037 classes (internal for instance).
5039 2003-10-20 Nick Drochak <ndrochak@gol.com>
5041 * ecore.cs: Fix typo and build. Needed another right paren.
5043 2003-10-19 Miguel de Icaza <miguel@ximian.com>
5045 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
5046 `internal' case regular and protected, but not allowing protected
5047 to be evaluated later. Bug 49840
5049 2003-10-15 Miguel de Icaza <miguel@ximian.com>
5051 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
5052 to kb.Nlast, and not the kb.nFirst to isolate the switch
5055 Extract the underlying type, so enumerations of long/ulong are
5056 treated like long/ulong.
5058 2003-10-14 Miguel de Icaza <miguel@ximian.com>
5060 * expression.cs (New): Overload the meaning of RequestedType to
5061 track the possible creation of the NewDelegate type, since
5062 DoResolve is invoked more than once for new constructors on field
5065 See bugs: #48800 and #37014
5067 * cs-parser.jay (declare_local_constants): Take an arraylist
5068 instead of a single constant.
5070 (local_constant_declaration): It should take a
5071 constant_declarators, not a constant_declarator. Fixes 49487
5073 * convert.cs: Fix error report.
5075 2003-10-13 Jackson Harper <jackson@ximian.com>
5077 * typemanager.cs (TypeToCoreType): Add float and double this fixes
5080 2003-11-03 Martin Baulig <martin@ximian.com>
5082 * expression.cs (ArrayAccess.GetStoreOpcode): Added
5083 `out bool has_type_arg'; if set, we need to pass the type to
5085 (ArrayAccess.GetStoreOpcode, ArrayAccess.EmitLoadOpcode): Use
5086 Stelem_Any/Ldelem_Any for generic parameters.
5088 2003-11-02 Martin Baulig <martin@ximian.com>
5090 * expression.cs (Invocation.EmitCall): Use
5091 `TypeManager.IsValueType()' to check whether it's a value type.
5092 Don't set `struct_call' when calling a method on a type parameter.
5094 2003-11-02 Martin Baulig <martin@ximian.com>
5096 * generics.cs (ConstructedType.Resolve): Renamed to ResolveType()
5097 and removed the TypeBuilder argument.
5099 * typemanager.cs (TypeManager.IsValueType): Return
5100 `t.IsGenericParameter || t.IsValueType'.
5102 2003-10-25 Martin Baulig <martin@ximian.com>
5104 * decl.cs (DeclSpace.ResolveType): If we're a ConstructedType,
5105 call ConstructedType.Resolve() on it.
5107 * generic.cs (ConstructedType.Resolve): Set `type' on success.
5109 2003-10-25 Martin Baulig <martin@ximian.com>
5111 * class.cs (TypeContainer.GetClassBases): Changed
5112 `out Type parent' into `out TypeExpr parent'. Moved CS0644 and
5113 CS8214 reporting here.
5114 (TypeContainer.DefineType): GetClassBases() gives us a `TypeExpr'
5115 instead of a `Type' for our parent. In case of a recursive
5116 declaration (see tests/gen-23.cs for an example), our parent is a
5117 ConstructedType and it doesn't have its type set. So, first
5118 create our own TypeBuilder, then call constructed.Resolve() to get
5119 the parent's type and finally TypeBuilder.SetParent() it.
5121 * ecore.cs (TypeExpr.Name): New public virtual property.
5124 (ConstructedType): We're now a TypeExpr and not just an Expression.
5125 (ConstructedType.ResolveAsTypeStep): Don't resolve our type
5126 arguments here; this is done later.
5127 (ConstructedType.Resolve): New public method to resolve the type
5128 arguments and bind them.
5130 2003-10-21 Martin Baulig <martin@ximian.com>
5132 * convert.cs: Use `TypeManager.IsValueType' instead of
5133 'type.IsValueType' everywhere.
5135 * typemanager.cs (TypeManager.IsValueType): Return true for type
5136 parameters. The reason for this is that we need to box a type
5137 parameter when converting it to a reference type.
5139 * cs-parser.jay: Added support for default value expressions.
5141 * generics.cs (DefaultValueExpression): New public class.
5143 2003-10-17 Martin Baulig <martin@ximian.com>
5145 * generic.cs (Constraints.Resolve): Take a DecpSpace instead of a
5146 TypeContainer so we can also use this for Interfaces.
5147 (TypeParameter.Resolve): Likewise.
5149 * interface.cs (Interface.DefineType): Added support for generic
5152 * cs-parser.jay: Added support for generic structs and interfaces.
5154 2003-10-17 Martin Baulig <martin@ximian.com>
5156 * generic.cs (GenericMemberAccess.DoResolve): We can now actually
5157 call generic methods :-)
5159 2003-10-16 Martin Baulig <martin@ximian.com>
5161 * cs-parser.jay (namespace_or_type_name): Only create a
5162 GenericMemberAccess if we actually have type arguments.
5164 2003-10-13 Martin Baulig <martin@ximian.com>
5166 * class.cs (Method.Define): If we're a generic method, call
5167 TypeBuilder.DefineGenericMethod () before resolving
5169 (MethodData): Added .ctor which takes an additional MethodBuilder
5170 argument; this is used for generic methods.
5171 (MethodData.Define): Call `builder.SetGenericMethodSignature()' if
5172 we already have a MethodBuilder.
5174 2003-10-10 Martin Baulig <martin@ximian.com>
5176 * class.cs (Method): Added .ctor which takes a `GenericMethod'
5177 instead of a `DeclSpace'. This is used for generic methods.
5179 * cs-parser.jay (method_header): Added support for generic
5180 methods; create a `GenericMethod' instance and pass it to the
5181 `Method's .ctor; it'll be used as the `DeclSpace' to lookup
5182 parameters and locals.
5184 * decl.cs (DeclSpace.SetParameterInfo): Removed Location argument
5185 since we already have the location. Check whether we're a generic
5186 type declaration or a generic method and create the correct type
5189 * generic.cs (TypeParameter.DefineMethod): New public method.
5190 (GenericMethod): New public class; derives from DeclSpace and is
5191 used for generic methods.
5193 2003-10-09 Martin Baulig <martin@ximian.com>
5195 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
5197 (MethodCore.DoDefineParameters): Removed the TypeContainer
5198 argument; use the DeclSpace which was passed to the .ctor instead.
5199 (MethodCore.CheckParameter): Take a DeclSpace instead of a
5200 TypeContainer; we only need a DeclSpace here.
5202 2003-10-09 Martin Baulig <martin@ximian.com>
5204 * class.cs (MethodData): Added additional `DeclSpace ds' argument
5206 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
5207 EmitContext's .ctor.
5209 2003-10-09 Martin Baulig <martin@ximian.com>
5211 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
5212 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
5213 AsAccessible(), moved them as well.
5215 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
5217 2003-10-07 Miguel de Icaza <miguel@ximian.com>
5219 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
5220 generation for >=, as spotted by Paolo, bug 48679.
5221 Patch from David Waite.
5223 * cs-tokenizer.cs: Add handling for #pragma.
5225 * cs-parser.jay: Allow for both yield and yield return in the
5226 syntax. The anti-cobolization of C# fight will go on!
5228 * class.cs (TypeBuilder.DefineType): Catch error condition here
5229 (Parent.DefineType erroring out and returning null).
5231 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
5232 coping with enumerations variables, we were mistakenly processing
5233 them as a regular value type instead of built-in types. Fixes the
5236 * typemanager.cs (IsBuiltinOrEnum): New method.
5238 2003-09-30 Miguel de Icaza <miguel@ximian.com>
5240 * cs-parser.jay: Upgrade: yield now needs the return clause.
5242 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
5244 * cs-parser.jay : Renamed yyName to yyNames related to jay.
5246 2003-09-29 Martin Baulig <martin@ximian.com>
5248 * typemanager.cs (TypeManager.GetMethodFlags): Added support for
5249 inflated generic methods.
5251 * generics.cs (ConstructedType): Distinguish between open and
5252 closed constructed types; correctly resolve the arguments.
5254 2003-09-22 Martin Baulig <martin@ximian.com>
5256 * generic.cs (ConstructedType.ResolveAsTypeCheck): Check whether
5257 all type arguments meet their constraints.
5259 2003-09-19 Martin Baulig <martin@ximian.com>
5261 * decl.cs (MemberCache.SetupCacheForInterface): Take a
5262 `MemberCache parent' argument. Normally, an interface doesn't
5263 have a parent type except System.Object, but we use this in gmcs
5264 for generic type parameters.
5266 2003-09-18 Martin Baulig <martin@ximian.com>
5268 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
5269 on `type.IsInterface'; don't check whether the type has a parent
5270 to determine whether it's an interface.
5272 2003-09-17 Martin Baulig <martin@ximian.com>
5274 * generic.cs (ConstructedType.ToString): Always use `name' as the
5277 2003-09-15 Martin Baulig <martin@ximian.com>
5279 * cs-parser.jay: Fix grammar wrt. type_parameter_constraints.
5281 * generic.cs (Constraints.Resolve): New public method; this is
5282 called to resolve the constraint types and to check whether all
5283 the constraints are correct.
5284 (Constraints.Types): New public property.
5285 (TypeParameter.Resolve): New public method; resolves all the
5288 * class.cs (TypeContainer.DefineType): Call
5289 TypeParameter.Resolve() before actually defining the type.
5291 2003-09-15 Martin Baulig <martin@ximian.com>
5293 * class.cs (TypeContainer.DefineType): Added an error flag to
5294 avoid reporting duplicate CS0146's ("class definition is
5297 * driver.cs (Driver.MainDriver): Abort if
5298 RootContext.ResolveTree() reported any errors.
5300 2003-09-07 Martin Baulig <martin@ximian.com>
5302 * report.cs (Error, Warning): Added overloaded versions which take
5303 a `params object[] args' and call String.Format().
5305 2003-09-07 Martin Baulig <martin@ximian.com>
5307 * decl.cs (DeclSpace..ctor): Don't call
5308 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
5309 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
5310 (DeclSpace.RecordDecl): New method.
5312 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
5314 2003-09-02 Ravi Pratap <ravi@ximian.com>
5316 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
5317 value attributes to be applied to ParameterBuilders.
5319 * class.cs (MethodCore.LabelParameters): Make static and more
5320 generic so that it can be used from other places - like interface
5321 methods, for instance.
5323 * interface.cs (Interface.Emit): Call LabelParameters before
5324 emitting attributes on the InterfaceMethod.
5326 2003-09-07 Martin Baulig <martin@ximian.com>
5328 * generic.cs (ConstructedType.ResolveAsTypeStep): Report a CS8217
5329 if the number of type parameters doesn't match.
5331 2003-09-04 Martin Baulig <martin@ximian.com>
5333 * expression.cs (ComposedCast.ResolveAsTypeStep): Added support
5334 for arrays of generic type params (ie. `!0[]').
5336 2003-09-04 Martin Baulig <martin@ximian.com>
5338 * class.cs (TypeContainer.AsAccessible): Ignore generic parameters
5341 2003-09-04 Martin Baulig <martin@ximian.com>
5343 * decl.cs (DeclSpace.LookupGeneric): New method.
5344 (DeclSpace.CheckAccessLevel): Ignore generic parameters for the
5347 * generic.cs (TypeParameterExpr): Take a TypeParameter as
5348 argument, not just a string.
5349 (TypeParameter.Define): New public method; this is called to
5350 actually define the generic parameter; after this, you can use the
5351 new `Type' property to get the type.
5353 2003-09-04 Martin Baulig <martin@ximian.com>
5355 * decl.cs (DeclSpace.SetParameterInfo): The `constraints' argument
5356 is now an ArrayList; initialize the result of the `TypeParameters'
5358 (DeclSpace.GetGenericData): Removed.
5359 (DeclSpace.LookupGeneric): Temporarily removed; we need to
5360 implement this in a different way.
5361 (DeclSpace.GetTypeParameters): Removed; there's now a
5362 `TypeParameters' property.
5363 (DeclSpace.TypeParameters): New public property.
5365 * generic.cs (Constraints): Make this class public.
5366 (TypeParameter): New public class.
5368 2003-09-04 Martin Baulig <martin@ximian.com>
5370 * decl.cs (DeclSpace.GetTypeParameters): New method to return the
5373 * class.cs (TypeContainer.DefineType): Call
5374 TypeBuilder.DefineGenericParameter () on all generic parameters if
5375 this is a generic type.
5377 2003-08-28 Martin Baulig <martin@ximian.com>
5379 * sample-stack.il: Compile this with ilasm: "ilasm /dll
5382 * sample-hello.cs: Compile this with gmcs: "gmcs
5383 /r:sample-stack.dll sample-hello.cs".
5385 2003-08-28 Martin Baulig <martin@ximian.com>
5387 * generic.cs (ConstructedType.ResolveAsTypeStep): Actually bind
5388 the parameters to the generic type.
5390 2003-08-28 Martin Baulig <martin@ximian.com>
5392 * cs-tokenizer.cs (parse_less_than): Also allow all builtin types.
5394 2003-08-28 Martin Baulig <martin@ximian.com>
5396 * cs-parser.jay (opt_type_argument_list): Use
5397 `OP_GENERICS_LT type_arguments OP_GENERICS_GT'.
5398 (primary_expression): Replace `qualified_identifier' with `type_name'.
5399 (type_parameter_list): Use `OP_GENERICS_LT type_parameters OP_GENERICS_GT'.
5401 * cs-tokenizer.cs (is_punct): When reading a `<', invoke a custom
5402 parser to check whether it is syntactically a type parameter list;
5403 return OP_GENERICS_LT/OP_GENERICS_GT instead of OP_LT/OP_GT in
5406 2003-08-26 Martin Baulig <martin@ximian.com>
5408 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
5409 resolving aliases; fixes #47927.
5411 2003-08-26 Martin Baulig <martin@ximian.com>
5413 * statement.cs (Using.DoResolve): This is internally emitting a
5414 try/finally clause, so we need to set ec.NeedExplicitReturn if we
5415 do not always return. Fixes #47681.
5417 2003-08-26 Martin Baulig <martin@ximian.com>
5419 * decl.cs (MemberCore): Moved WarningNotHiding(),
5420 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
5422 (AdditionResult): Make this nested in DeclSpace.
5423 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
5424 argument; call NamespaceEntry.Define() unless we're nested in a
5427 * namespace.cs (Namespace.DefineName): New public function. This
5428 is called from DeclSpace's .ctor to add
5429 (Namespace.Lookup): Include DeclSpaces in the lookup.
5431 * class.cs (Operator): Derive from MemberBase, not MemberCore.
5433 * const.cs (Const): Derive from MemberBase, not MemberCore.
5435 2003-08-25 Martin Baulig <martin@ximian.com>
5437 * convert.cs (Convert.ExplicitReferenceConversion): When
5438 converting from an interface type to a class, unbox if the target
5439 type is a struct type. Fixes #47822.
5441 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
5443 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
5446 2003-08-22 Martin Baulig <martin@ximian.com>
5448 * class.cs (TypeManager.DefineType): When defining a nested type,
5449 call DefineType() on our parent; fixes #47801.
5451 2003-08-22 Martin Baulig <martin@ximian.com>
5453 * class.cs (MethodData.Define): While checking if a method is an
5454 interface implementation, improve the test a bit more to fix #47654.
5456 2003-08-22 Martin Baulig <martin@ximian.com>
5458 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
5459 correctly; fixes #47722.
5461 2003-08-22 Martin Baulig <martin@ximian.com>
5463 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
5464 LocalVariableReference, ensure it's not read-only. Fixes #47536.
5466 * statement.cs (Fixed.DoResolve): Make all variables read-only.
5468 2003-08-22 Martin Baulig <martin@ximian.com>
5470 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
5471 can only be assigned in static constructors. Fixes #47161.
5473 2003-08-22 Martin Baulig <martin@ximian.com>
5475 Rewrote and improved the flow analysis code.
5477 * flowbranching.cs (FlowBranching): Make this class abstract.
5478 (FlowBranching.CreateBranching): New static function to create a
5480 (FlowBranchingBlock, FlowBranchingException): New classes.
5481 (FlowBranching.UsageVector.Type): New public readonly field.
5482 (FlowBranching.UsageVector.Breaks): Removed the setter.
5483 (FlowBranching.UsageVector.Returns): Removed the setter.
5484 (FlowBranching.UsageVector): Added Break(), Return(),
5485 NeverReachable() and Throw() methods to modify the reachability.
5486 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
5487 done by FlowBranching.Merge().
5488 (FlowBranching.UsageVector.MergeChild): New method; merges the
5489 merge result into the current vector.
5490 (FlowBranching.Merge): New abstract method to merge a branching.
5492 2003-08-12 Martin Baulig <martin@ximian.com>
5494 * expression.cs (Indirection.CacheTemporaries): Create the
5495 LocalTemporary with the pointer type, not its element type.
5497 2003-08-10 Miguel de Icaza <miguel@ximian.com>
5499 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
5500 token was a keyword or not.
5502 Add `error' options where an IDENTIFIER was expected; Provide
5503 CheckToken and CheckIdentifierToken convenience error reporting
5506 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
5508 * decl.cs: Rename `NamespaceEntry Namespace' public field into
5509 NameSpaceEntry NameSpaceEntry.
5511 (LookupInterfaceOrClass): Avoid creating a full qualified name
5512 from namespace and name: avoid doing lookups when we know the
5513 namespace is non-existant. Use new Tree.LookupByNamespace which
5514 looks up DeclSpaces based on their namespace, name pair.
5516 * driver.cs: Provide a new `parser verbose' to display the
5517 exception thrown during parsing. This is turned off by default
5518 now, so the output of a failure from mcs is more graceful.
5520 * namespace.cs: Track all the namespaces defined in a hashtable
5523 (IsNamespace): New method
5525 2003-08-09 Miguel de Icaza <miguel@ximian.com>
5527 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
5528 we know that we need to concatenate (full typename can never be
5533 * statement.cs: Use a bitfield; Do not initialize to null things
5534 which are done by the constructor by default.
5536 * cs-parser.jay: bug fix, parameter was 4, not 3.
5538 * expression.cs: Just use the property;
5540 * statement.cs: No need for GetVariableInfo method.
5542 2003-08-08 Martin Baulig <martin@ximian.com>
5544 * flowanalysis.cs (FlowReturns): This is now nested in the
5545 `FlowBranching' class.
5546 (MyBitVector): Moved this here from statement.cs.
5547 (FlowBranching.SiblingType): New enum type.
5548 (FlowBranching.CreateSibling): Added `SiblingType' argument.
5550 2003-08-07 Martin Baulig <martin@ximian.com>
5552 * flowanalysis.cs (FlowBranchingType): This is now nested in the
5553 `FlowBranching' class and called `BranchingType'.
5555 2003-08-07 Martin Baulig <martin@ximian.com>
5557 * flowanalysis.cs: Moved all the control flow analysis code into
5560 2003-08-07 Martin Baulig <martin@ximian.com>
5562 * assign.cs (Assign.DoResolve): `target' must either be an
5563 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
5566 2003-08-07 Miguel de Icaza <miguel@ximian.com>
5568 * expression.cs (BinaryMethod): This kind of expression is created by the
5569 Binary class if it determines that the operator has to be handled
5572 (BinaryDelegate): This kind of expression is created if we are
5573 dealing with a + or - operator on delegates.
5575 (Binary): remove method, argumetns, and DelegateOperator: when
5576 dealing with methods,
5578 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
5580 * statement.cs (Block): use bitfields for the three extra booleans
5581 we had in use. Remove unused topblock parameter.
5583 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
5585 * assign.cs: Drop extra unneeded tests.
5587 2003-08-06 Miguel de Icaza <miguel@ximian.com>
5589 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
5591 * statement.cs (Foreach): Use VariableStorage instead of
5594 * codegen.cs (VariableStorage): New class used by clients that
5595 require a variable stored: locals or fields for variables that
5596 need to live across yield.
5598 Maybe provide a convenience api for EmitThis+EmitLoad?
5600 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
5603 2003-08-05 Miguel de Icaza <miguel@ximian.com>
5605 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
5606 RemapParameterLValue): New methods that are used to turn a
5607 precomputed FieldInfo into an expression like this:
5611 The idea is to use this instead of making LocalVariableReference
5612 have more than one meaning.
5614 * cs-parser.jay: Add error production to BASE.
5616 * ecore.cs: Deal with TypeManager.GetField returning null, which
5617 is now a valid return value.
5619 (FieldExprNoAddress): New expression for Fields whose address can
5622 * expression.cs (LocalVariableReference): During the resolve
5623 phases, create new expressions if we are in a remapping context.
5624 Remove code that dealt with remapping here.
5626 (ParameterReference): same.
5628 (ProxyInstance): New expression, like the `This' expression, but
5629 it is born fully resolved. We know what we are doing, so remove
5630 the errors that are targeted to user-provided uses of `this'.
5632 * statement.cs (Foreach): our variable is now stored as an
5633 Expression; During resolution, follow the protocol, dont just
5634 assume it will return this.
5636 2003-08-06 Martin Baulig <martin@ximian.com>
5638 * support.cs (SeekableStreamReader.cs): New public class.
5640 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
5641 SeekableStreamReader instead of the normal StreamReader.
5643 2003-08-04 Martin Baulig <martin@ximian.com>
5645 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
5646 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
5647 deambiguate casts and delegate invocations.
5648 (parenthesized_expression): Use the new tokens to ensure this is
5649 not a cast of method invocation.
5651 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
5652 when reading a `)' and Deambiguate_CloseParens () was previously
5655 * expression.cs (ParenthesizedExpression): New class. This is
5656 just used for the CS0075 test.
5657 (Binary.DoResolve): Check for CS0075.
5659 2003-07-29 Ravi Pratap <ravi@ximian.com>
5661 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
5662 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
5663 reference comparison.
5665 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
5666 examine the ReturnType for equality - this is necessary in the
5667 cases of implicit and explicit operators whose signature also
5668 includes the return type.
5670 2003-07-26 Miguel de Icaza <miguel@ximian.com>
5672 * namespace.cs: Cache the result of the namespace computation,
5673 instead of computing it every time.
5675 2003-07-24 Miguel de Icaza <miguel@ximian.com>
5677 * decl.cs: Use a global arraylist that we reuse over invocations
5678 to avoid excesive memory consumption. Reduces memory usage on an
5679 mcs compile by one meg (45 average).
5681 * typemanager.cs (LookupTypeReflection): In .NET pointers are
5682 private, work around that.
5684 2003-07-23 Miguel de Icaza <miguel@ximian.com>
5686 * literal.cs (IntLiteral): Define Zero and One static literals.
5688 * cs-parser.jay (integer_literal): use static literals to reduce
5689 memory usage for the most used literals (0, 1 and -1). 211kb
5690 reduced in memory usage.
5692 Replace all calls to `new ArrayList' with `new
5693 ArrayList(4)' which is a good average number for most allocations,
5694 and also requires only 16 bytes of memory for its buffer by
5697 This reduced MCS memory usage in seven megabytes for the RSS after
5700 2003-07-28 Ravi Pratap <ravi@ximian.com>
5702 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
5703 handle params methods the correct way by forming only one
5704 applicable set with params and normal methods in them. Earlier we
5705 were looking at params methods only if we found no normal methods
5706 which was not the correct thing to do.
5708 (Invocation.BetterFunction): Take separate arguments indicating
5709 when candidate and the best method are params methods in their
5712 This fixes bugs #43367 and #46199.
5714 * attribute.cs: Documentation updates.
5716 (CheckAttribute): Rename to CheckAttributeTarget.
5717 (GetValidPlaces): Rename to GetValidTargets.
5719 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
5720 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
5724 2003-07-28 Miguel de Icaza <miguel@ximian.com>
5726 * codegen.cs: Compute IsGeneric correctly.
5728 * cs-parser.jay: Introduce OP_GENERIC_LT for the grammar ambiguity
5731 Bring back (temporarily) OP_LEFT_SHIFT, OP_RIGHT_SHIFT,
5732 OP_SHIFT_RIGHT_ASSIGN, OP_SHIFT_LEFT_ASSIGN. There were too many
5733 regressions, and I was chasing more bugs than I required.
5735 * interface.cs: Use expressions for base type names (like classes
5736 and structs have been doing for a while now), and resolve that.
5737 This patch should probably go into head as well.
5739 This makes it one less user of FindType.
5741 2003-07-24 Miguel de Icaza <miguel@ximian.com>
5743 This compiler can not self host currently. Need to fix that.
5745 * Makefile: compile to `gmcs.exe'
5747 * driver.cs: Turn on v2 by default on gmcs.
5749 * generic.cs (ConstructedType): Does no longer take a container
5750 type argument; That will be taken care of later.
5752 (ConstructedType.DoResolve, ConstructedType.ResolveAsTypeStep):
5753 Use SimpleName to resolve for now, so we can continue the work on
5754 the parser, until we get Type.GetType that understands generics.
5756 (ConstructedType.ToString): Implement
5758 (TypeArguments.Resolve): Resolve the child expressions as types.
5760 * cs-parser.jay: Rename interface_constraints to
5761 type_parameter_constraints
5763 (namespace_or_type_name): Only use constructed types for the basic
5764 construction, we will deal with identifier<...> later.
5766 (type/type_name): No longer call DecomposeQI, as
5767 namespace_or_type_name is always decoded now.
5769 2003-07-22 Ravi Pratap <ravi@ximian.com>
5771 * expression.cs (Invocation.OverloadResolve): Follow the spec more
5772 closely: we eliminate methods in base types when we have an
5773 applicable method in a top-level type.
5775 Please see section 14.5.5.1 for an exact description of what goes
5778 This fixes bug #45127 and a host of other related to corlib compilation.
5780 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
5781 array is the method corresponding to the top-level type (this is
5782 because of the changes made to icall.c) so we change this
5785 (MethodGroupExpr.Name): This too.
5787 * typemanager.cs (GetElementType): New method which does the right
5788 thing when compiling corlib.
5790 * everywhere: Make use of the above in the relevant places.
5792 2003-07-22 Martin Baulig <martin@ximian.com>
5794 * cs-parser.jay (invocation_expression): Moved
5795 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
5796 `cast_expression', but create a InvocationOrCast which later
5797 resolves to either an Invocation or a Cast.
5799 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
5800 method; call this before EmitStatement() to make sure that this
5801 expression can be used as a statement.
5803 * expression.cs (InvocationOrCast): New class; resolves to either
5804 an Invocation or a Cast.
5806 * statement.cs (StatementExpression): Call ResolveStatement() on
5807 the ExpressionStatement before emitting it.
5809 2003-07-21 Martin Baulig <martin@ximian.com>
5811 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
5812 `ref' and `out' attributes match; fixes #46220.
5813 (MemberAccess.ResolveMemberAccess): You can't reference a type
5814 through an expression; fixes #33180.
5815 (Indexers.GetIndexersForType): Don't return the indexers from
5816 interfaces the class implements; fixes #46502.
5818 2003-07-21 Martin Baulig <martin@ximian.com>
5820 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
5821 CS0661 checks; fixes bug #30442.
5823 2003-07-21 Martin Baulig <martin@ximian.com>
5825 * decl.cs (AdditionResult): Added `Error'.
5827 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
5829 * typemanager.cs (TypeManager.ChangeType): Catch exceptions; makes
5830 cs0031.cs actually work.
5832 2003-07-20 Miguel de Icaza <miguel@ximian.com>
5834 * cs-parser.jay (namespace_name): do not use
5835 namespace_or_type_name, use qualified_identifier, because
5836 namespace_or_type_name will soon return a composed expression
5837 instead of a string.
5839 (namespace_or_type_name): Instead of returning a string, now this
5840 production returns an expression.
5842 * codegen.cs (EmitContext): Setup IsGeneric property based on
5843 whether our DeclSpace is generic, our the method is generic.
5845 * modifier.cs (Modifiers.METHOD_GENERIC): New definition, use if
5846 the method is generic.
5848 * cs-parser.jay (type_arguments, opt_type_argument_list,
5849 type_parameters, type_parameter_list, opt_type_parameter_list,
5850 type_parameter,, opt_type_parameter_constraints_clauses,
5851 type_parameter_constraints_clauses,
5852 type_parameter_constraint_clause, type_parameter_constraint,
5853 interface_constraints): Add new production
5855 * decl.cs (DeclSpace): IsGeneric, flag to track whether this
5856 DeclSpace is generic or not.
5858 (DeclSpace.SetParameterInfo): New routine, used to set the
5859 parameter info for a type.
5861 (DeclSpace.LookupGeneric): Lookups a name, and if it is a generic,
5862 returns a GenericTypeExpr
5864 * ecore.cs (SimpleName.ResolveAsTypeStep): If our container is
5865 generic, lookup the generic argument.
5867 * attribute.cs: Do not allow TypeParameterExpressions in
5870 * class.cs: Do not allow the Main method to be defined in a
5873 * expression.cs (SizeOf): Do not allow generic types to be used as
5874 arguments to sizeof.
5876 * typemanager.cs (IsGeneric): Wrapper for Reflection when we have
5877 it: whether a type is generic or not. Only works for types we are
5878 currently building for now.
5880 2003-07-20 Martin Baulig <martin@ximian.com>
5882 * namespace.cs: Fixed that bug which caused a crash when compiling
5885 2003-07-20 Miguel de Icaza <miguel@ximian.com>
5887 * typemanager.cs (LookupTypeReflection): Never expose types which
5888 are NotPublic, NestedPrivate, NestedAssembly, or
5889 NestedFamANDAssem. We used to return these, and later do a check
5890 that would report a meaningful error, but the problem is that we
5891 would not get the real match, if there was a name override.
5893 2003-07-18 Miguel de Icaza <miguel@ximian.com>
5895 * namespace.cs (Namespace, Name): Do not compute the namespace
5896 name dynamically, compute it in the constructor. This reduced
5897 memory usage by 1697 KB.
5899 * driver.cs: Use --pause to pause at the end.
5901 2003-07-17 Peter Williams <peter@newton.cx>
5903 * Makefile: Change the name of the test target so that it doesn't
5904 conflict with the recursive test target.
5906 2003-07-17 Miguel de Icaza <miguel@ximian.com>
5908 * expression.cs (LocalVariableReference.Emit, EmitAssign,
5909 AddressOf): Do not use EmitThis, that was wrong, use the actual
5912 2003-07-15 Miguel de Icaza <miguel@ximian.com>
5914 * class.cs (MethodData.Define): While checking if a method is an
5915 interface implementation, improve the test: If we are not public
5916 (use new test here: use the computed MethodAttributes directly,
5917 instead of the parsed modifier flags) check if the `implementing'
5918 method comes from an interface or not.
5920 * pending.cs (VerifyPendingMethods): Slightly better error
5923 * makefile: add test target that does the mcs bootstrap.
5925 2003-07-16 Ravi Pratap <ravi@ximian.com>
5927 * interface.cs (Define): Do nothing here since there are no
5928 members to populate etc. Move the attribute emission out of here
5929 since this was just totally the wrong place to put it. Attribute
5930 application happens during the 'Emit' phase, not in the 'Define'
5933 (Emit): Add this method and move the attribute emission here
5935 * rootcontext.cs (EmitCode): Call the Emit method on interface
5938 2003-07-14 Ravi Pratap M <ravi@ximian.com>
5940 * expression.cs (OverloadResolve): Report error only if Location
5941 is not 'Null' which means that there was a probe going on.
5943 2003-07-14 Martin Baulig <martin@ximian.com>
5945 * expression.cs (ConditionalLogicalOperator): New public class to
5946 implement user defined conditional logical operators.
5947 This is section 14.11.2 in the spec and bug #40505.
5949 2003-07-14 Martin Baulig <martin@ximian.com>
5951 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
5953 2003-07-14 Martin Baulig <martin@ximian.com>
5955 * codegen.cs (EmitContext.InFixedInitializer): New public field.
5957 * ecore.cs (IVariable.VerifyFixed): New interface method.
5959 * expression.cs (Unary.ResolveOperator): When resolving the `&'
5960 operator, check whether the variable is actually fixed. Fixes bug
5961 #36055. Set a variable definitely assigned when taking its
5962 address as required by the spec.
5964 * statement.cs (LocalInfo.IsFixed): New field.
5965 (LocalInfo.MakePinned): Set `IsFixed' to true.
5967 2003-07-14 Ravi Pratap M <ravi@ximian.com>
5969 * attribute.cs (Attribute.Resolve): While doing a Member lookup
5970 for .ctors, ensure that we only ask for members declared in the
5971 attribute type (BindingFlags.DeclaredOnly).
5975 * expression.cs (Error_WrongNumArguments): Report error 1501
5976 correctly the way CSC does.
5978 2003-07-13 Martin Baulig <martin@ximian.com>
5980 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
5981 lookup on the fully qualified name, to make things like "X.X" work
5982 where "X.X" is a fully qualified type name, but we also have a
5983 namespace "X" in the using list. Fixes #41975.
5985 2003-07-13 Martin Baulig <martin@ximian.com>
5987 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
5988 function. If we're a CompoundAssign, we need to create an embedded
5989 CompoundAssign, not an embedded Assign.
5990 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
5993 2003-07-13 Martin Baulig <martin@ximian.com>
5995 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
5996 work to fix bug #46088.
5998 2003-07-13 Ravi Pratap <ravi@ximian.com>
6000 * class.cs (Operator.Emit): Do not emit attributes here - it is
6001 taken care of by the Method class that we delegate too. This takes
6004 2003-07-10 Martin Baulig <martin@ximian.com>
6006 * expression.cs (TypeOfVoid): New class.
6007 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
6009 2003-07-10 Martin Baulig <martin@ximian.com>
6011 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
6014 2003-07-10 Martin Baulig <martin@ximian.com>
6016 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
6017 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
6019 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
6021 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
6023 2003-07-10 Martin Baulig <martin@ximian.com>
6025 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
6026 of decimal. Fixes #42850.
6028 NOTE: I also fixed the created byte blob, but this doesn't work on
6029 the MS runtime and csc never produces any byte blobs for decimal
6032 2003-07-10 Martin Baulig <martin@ximian.com>
6034 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
6035 structs; fixes #32068.
6036 (Block.AddChildVariableNames): Fixed #44302.
6038 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6040 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
6042 2003-07-07 Miguel de Icaza <miguel@ximian.com>
6044 * attribute.cs: And this test is onger needed.
6046 2003-07-08 Martin Baulig <martin@ximian.com>
6048 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
6049 inaccessible types. Fixes #36313.
6051 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
6053 * namespace.cs (NamespaceEntry): Create implicit entries for all
6054 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
6055 implicit entries for N1.N2 and N1.
6057 2003-07-08 Martin Baulig <martin@ximian.com>
6059 Rewrote the handling of namespaces to fix a lot of the issues
6060 wrt. `using' aliases etc.
6062 * namespace.cs (Namespace): Splitted this class into a
6063 per-assembly `Namespace' and a per-file `NamespaceEntry'.
6065 * typemanager.cs (TypeManager.IsNamespace): Removed.
6066 (TypeManager.ComputeNamespaces): Only compute namespaces from
6067 loaded assemblies here, not the namespaces from the assembly we're
6068 currently compiling.
6070 2003-07-08 Martin Baulig <martin@ximian.com>
6072 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
6074 2003-07-07 Miguel de Icaza <miguel@ximian.com>
6076 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
6079 I thought about the memory savings here, but LookupTypeReflection
6080 is used under already very constrained scenarios. Compiling
6081 corlib or mcs only exposes one hit, so it would not really reduce
6082 any memory consumption.
6084 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6086 * typemanager.cs: fixes bug #45889 by only adding public types from
6087 other assemblies to the list of known types.
6089 2003-07-07 Miguel de Icaza <miguel@ximian.com>
6091 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
6092 on the type we resolved.
6094 2003-07-05 Martin Baulig <martin@ximian.com>
6096 * pending.cs (PendingImplementation.ParentImplements): Don't
6097 create the proxy if the parent is abstract.
6099 * class.cs (TypeContainer.DefineIndexers): Process explicit
6100 interface implementations first. Fixes #37714.
6102 2003-07-04 Miguel de Icaza <miguel@ximian.com>
6104 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
6105 defined recursively; but since we modify the input parameters
6106 (left is set to `this' temporarily), we reset this value if the
6107 left_is_explicit is false, which gives the original semantics to
6110 * literal.cs (NullPointer): new class used to represent a null
6111 literal in a pointer context.
6113 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
6114 type is a pointer, use a NullPointer object instead of a
6115 NullLiteral. Closes 43687
6117 (ExplicitConversion): Convert pointer values using
6118 the conv opcode to the proper type.
6120 * ecore.cs (New): change ValueTypeVariable property into a method,
6121 that returns whether the valuetype is suitable for being used.
6123 * expression.cs (Binary.DoNumericPromotions): Only return if we
6124 the int constant was a valid uint, and we can return both left and
6125 right as uints. If not, we continue processing, to trigger the
6126 type conversion. This fixes 39018.
6128 * statement.cs (Block.EmitMeta): During constant resolution, set
6129 the CurrentBlock property on the emitcontext, so that we resolve
6130 constants propertly.
6132 2003-07-02 Martin Baulig <martin@ximian.com>
6134 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
6135 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
6137 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
6138 than emitting it here.
6140 * statement.cs: Fixed some more flow analysis bugs.
6142 2003-07-02 Martin Baulig <martin@ximian.com>
6144 * class.cs (MethodData.Define): When implementing interface
6145 methods, set Final unless we're Virtual.
6147 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
6148 check work for interface methods.
6150 2003-07-01 Martin Baulig <martin@ximian.com>
6152 * ecore.cs (EmitContext.This): Replaced this property with a
6153 GetThis() method which takes a Location argument. This ensures
6154 that we get the correct error location for a CS0188.
6156 2003-07-01 Miguel de Icaza <miguel@ximian.com>
6158 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
6159 ImplicitStandardConversion.
6161 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
6163 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
6165 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
6168 2003-06-30 Miguel de Icaza <miguel@ximian.com>
6170 * class.cs (Constructor.Define): Turn off initlocals for unsafe
6173 (MethodData.Define): Turn off initlocals for unsafe methods.
6175 2003-06-29 Miguel de Icaza <miguel@ximian.com>
6177 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
6178 complete; Fixes #37521.
6180 * delegate.cs: Use Modifiers.TypeAttr to compute the
6181 TypeAttributes, instead of rolling our own. This makes the flags
6182 correct for the delegates.
6184 2003-06-28 Miguel de Icaza <miguel@ximian.com>
6186 * class.cs (Constructor.Define): Set the private flag for static
6187 constructors as well.
6189 * cs-parser.jay (statement_expression): Set the return value to
6190 null, to avoid a crash when we catch an error.
6192 2003-06-24 Miguel de Icaza <miguel@ximian.com>
6194 * cs-parser.jay: Applied patch from Jackson that adds support for
6195 extern and unsafe modifiers to destructor declarations.
6197 * expression.cs: Report error 21 if the user is trying to index a
6200 * driver.cs: Add an error message, suggested by the bug report.
6202 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
6203 if we do not have a ": this ()" constructor initializer. Fixes 45149
6205 2003-06-14 Miguel de Icaza <miguel@ximian.com>
6207 * namespace.cs: Add some information to reduce FAQs.
6209 2003-06-13 Miguel de Icaza <miguel@ximian.com>
6211 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
6212 underlying enumeration types. Fixes #43915.
6214 * expression.cs: Treat ushort/short as legal values to be used in
6217 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
6219 * delegate.cs: transfer custom attributes for paramenters from
6220 the delegate declaration to Invoke and BeginInvoke.
6222 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
6224 * attribute.cs: handle custom marshalers and emit marshal info
6227 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
6229 * makefile.gnu: Added anonymous.cs to the compiler sources.
6231 2003-05-28 Miguel de Icaza <miguel@ximian.com>
6233 * iterators.cs: Change the name of the proxy class to include two
6236 * cs-parser.jay: Update grammar to include anonymous methods.
6238 * anonymous.cs: new file.
6240 2003-05-27 Miguel de Icaza <miguel@ximian.com>
6242 * class.cs (Field.Define): Add missing test for pointers and
6245 2003-05-27 Ravi Pratap <ravi@ximian.com>
6247 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
6248 we use the stobj opcode.
6250 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
6251 since it wasn't the correct fix.
6253 It still is puzzling that we are required to use stobj for IntPtr
6254 which seems to be a ValueType.
6256 2003-05-26 Miguel de Icaza <miguel@ximian.com>
6258 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
6259 during regular simple name resolution. Now, the trick is that
6260 instead of returning for processing the simplename, we do a
6261 TypeManager.LookupType (ie, a rooted lookup as opposed to a
6262 contextual lookup type). If a match is found, return that, if
6263 not, return for further composition.
6265 This fixes long-standing 30485.
6267 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
6268 using the address to initialize an object, do an Stobj instead of
6269 using the regular Stelem.
6271 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
6272 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
6273 Because if we are a BaseIndexerAccess that value will be true.
6276 * statement.cs (GotoCase.Resolve): Return after reporting an
6277 error, do not attempt to continue.
6279 * expression.cs (PointerArithmetic.Emit): If our operand is a
6280 long, convert our constants to match the operand before
6281 multiplying. Convert to I type before adding. Fixes 43670.
6283 2003-05-14 Ravi Pratap <ravi@ximian.com>
6285 * enum.cs (ImplicitConversionExists) : Rename to
6286 ImplicitEnumConversionExists to remove ambiguity.
6288 * ecore.cs (NullCast): New type of cast expression class which
6289 basically is very similar to EmptyCast with the difference being
6290 it still is a constant since it is used only to cast a null to
6294 * convert.cs (ImplicitReferenceConversion): When casting a null
6295 literal, we return a NullCast.
6297 * literal.cs (NullLiteralTyped): Remove - I don't see why this
6298 should be around anymore.
6300 The renaming (reported was slightly wrong). Corrections:
6302 ConvertImplicitStandard -> ImplicitConversionStandard
6303 ConvertExplicitStandard -> ExplicitConversionStandard
6305 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
6306 before passing them in !
6308 * convert.cs (ImplicitConversionStandard): When comparing for
6309 equal expr and target types, ensure that expr is not a
6312 In general, we must not be checking (expr_type ==
6313 target_type) in the top level conversion methods
6314 (ImplicitConversion, ExplicitConversion etc). This checking is
6315 done in the methods that they delegate to.
6317 2003-05-20 Miguel de Icaza <miguel@ximian.com>
6319 * convert.cs: Move Error_CannotConvertType,
6320 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
6321 ImplicitNumericConversion, ImplicitConversionExists,
6322 ImplicitUserConversionExists, StandardConversionExists,
6323 FindMostEncompassedType, FindMostSpecificSource,
6324 FindMostSpecificTarget, ImplicitUserConversion,
6325 ExplicitUserConversion, GetConversionOperators,
6326 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
6327 TryImplicitIntConversion, Error_CannotConvertImplicit,
6328 ConvertImplicitRequired, ConvertNumericExplicit,
6329 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
6330 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
6333 Perform the following renames:
6335 StandardConversionExists -> ImplicitStandardConversionExists
6336 ConvertImplicit -> ImplicitConversion
6337 ConvertImplicitStandard -> ImplicitStandardConversion
6338 TryImplicitIntConversion -> ImplicitIntConversion
6339 ConvertImplicitRequired -> ImplicitConversionRequired
6340 ConvertNumericExplicit -> ExplicitNumericConversion
6341 ConvertReferenceExplicit -> ExplicitReferenceConversion
6342 ConvertExplicit -> ExplicitConversion
6343 ConvertExplicitStandard -> ExplicitStandardConversion
6345 2003-05-19 Martin Baulig <martin@ximian.com>
6347 * statement.cs (TypeInfo.StructInfo): Made this type protected.
6348 (TypeInfo): Added support for structs having structs as fields.
6350 * ecore.cs (FieldExpr): Implement IVariable.
6351 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
6352 VariableInfo for the field.
6354 2003-05-18 Martin Baulig <martin@ximian.com>
6356 * expression.cs (This.DoResolve): Report a CS0027 if we're
6357 emitting a field initializer.
6359 2003-05-18 Martin Baulig <martin@ximian.com>
6361 * expression.cs (This.ResolveBase): New public function.
6362 (This.DoResolve): Check for CS0188.
6364 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
6367 * ecore.cs (MethodGroupExpr.DoResolve): Set the
6368 `instance_expression' to null if we don't have any non-static
6371 2003-05-18 Martin Baulig <martin@ximian.com>
6373 Reworked the way how local variables and parameters are handled by
6374 the flow analysis code.
6376 * statement.cs (TypeInfo, VariableMap): New public classes.
6377 (VariableInfo): New public class. This is now responsible for
6378 checking whether a variable has been assigned. It is used for
6379 parameters and local variables.
6380 (Block.EmitMeta): Take the InternalParameters as argument; compute
6381 the layout of the flow vectors here.
6382 (Block.LocalMap, Block.ParameterMap): New public properties.
6383 (FlowBranching): The .ctor doesn't get the InternalParameters
6384 anymore since Block.EmitMeta() now computes the layout of the flow
6386 (MyStructInfo): This class is now known as `StructInfo' and nested
6387 in `TypeInfo'; we don't access this directly anymore.
6389 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
6390 property and removed IsAssigned(), IsFieldAssigned(),
6391 SetAssigned() and SetFieldAssigned(); we now call them on the
6392 VariableInfo so we don't need to duplicate this code everywhere.
6394 * expression.cs (ParameterReference): Added `Block block' argument
6396 (LocalVariableReference, ParameterReference, This): The new
6397 VariableInfo class is now responsible for all the definite
6400 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
6401 IsParameterAssigned, SetParameterAssigned): Removed.
6403 2003-05-18 Martin Baulig <martin@ximian.com>
6405 * typemanager.cs (InitCoreTypes): Try calling
6406 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
6407 the 3-args-version. Corlib now also needs our `void_type'.
6408 (GetMethod): Added overloaded version which takes an optional
6409 `bool report_errors' to allow lookups of optional methods.
6411 2003-05-12 Martin Baulig <martin@ximian.com>
6413 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
6414 only used for locals and not for parameters.
6416 2003-05-12 Miguel de Icaza <miguel@ximian.com>
6418 * support.cs (InternalParameters.ParameterType): Return the
6419 ExternalType of the parameter.
6421 * parameter.cs (Parameter.ExternalType): drop the two arguments,
6424 2003-05-11 Miguel de Icaza <miguel@ximian.com>
6426 * class.cs (MethodData.Define): Do not set the `newslot' on
6427 interface members, if they are also flagged as "override".
6429 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
6430 better code for ++i and i++. This only works for static fields
6431 and local variables.
6433 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
6434 want to pull the DeclSpace out of the builder_to_declspace instead
6435 of the TypeBuilder (like in TypeContainer.FindMembers).
6437 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
6438 instead of LookupTypeContainer. Fixes the crash on .NET for
6439 looking up interface members.
6441 * const.cs: Create our own emit context during the Definition
6442 stage, so that constants are evaluated in the proper context, when
6443 a recursive definition happens.
6445 2003-05-11 Martin Baulig <martin@ximian.com>
6447 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
6448 new block for a switch section.
6449 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
6450 the adding/lookup in the switch block. Fixes #39828.
6452 2003-05-09 Miguel de Icaza <miguel@ximian.com>
6454 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
6455 functionality: I needed to convert the data after I had performed
6456 the add/sub operation into the operands type size.
6458 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
6459 pass the type for the box operation, otherwise the resulting
6460 object would have been of type object.
6462 (BoxedCast): Add constructor to specify the type to box as.
6464 2003-05-07 Miguel de Icaza <miguel@ximian.com>
6466 * iterators.cs: I was reusing the `count' variable inadvertently,
6467 take steps to not allow this to happen.
6469 2003-05-06 Miguel de Icaza <miguel@ximian.com>
6471 * attribute.cs (Attribute.Resolve): Params attributes are encoded
6472 by creating an array at the point where the params starts and
6473 putting all those arguments there, then adjusting the size of the
6476 2003-05-05 Miguel de Icaza <miguel@ximian.com>
6478 * expression.cs (New.AddressOf): Implement interface
6479 IMemoryLocation. This is used when the `new' operator is used in
6480 the context of an invocation to a method on a value type.
6482 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
6485 * namespace.cs: Also check the using aliases here.
6487 * driver.cs: Move the test for using validity after the types have
6488 been entered, so we do a single pass that also includes the using
6491 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
6492 in the regular case. CreateSiblingForFinally is doing extra
6495 * attribute.cs (GetAttributeArgumentExpression): Store the result
6496 on an out value, and use the return value to indicate failure
6497 instead of using null (which is a valid return for Constant.GetValue).
6499 * statement.cs: Perform the analysis flow for the increment
6500 portion after the statement, because this will be the real flow of
6501 execution. Fixes #42385
6503 * codegen.cs (EmitContext.EmitArgument,
6504 EmitContext.EmitStoreArgument): New helper functions when the
6505 RemapToProxy flag is set.
6507 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
6510 Add support for remapping parameters.
6512 * iterators.cs: Propagate parameter values; Store parameter
6513 values in the proxy classes.
6515 2003-05-04 Miguel de Icaza <miguel@ximian.com>
6517 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
6518 need a proxy reference; I do not know what I was thinking
6520 * cs-parser.jay (constructor_initializer): catch another error,
6521 and display nice message.
6523 (field_declaration): catch void field declaration
6524 to flag a better error.
6526 * class.cs (MemberBase.CheckBase): Report an error instead of a
6527 warning if a new protected member is declared in a struct.
6528 (Field.Define): catch the error of readonly/volatile.
6530 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
6532 (FieldExpr.AddressOf): ditto. Catch error where the address of a
6533 volatile variable is taken
6535 2003-05-02 Miguel de Icaza <miguel@ximian.com>
6537 * statement.cs (Fixed.Resolve): Report an error if we are not in
6540 2003-05-01 Miguel de Icaza <miguel@ximian.com>
6542 * typemanager.cs: reuse the code that handles type clashes for
6543 delegates and enumerations.
6545 * class.cs (Report28): Always report.
6547 * expression.cs (EncodeAsAttribute): Allow nulls here.
6549 2003-04-28 Miguel de Icaza <miguel@ximian.com>
6551 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
6552 the functionality for testing whether an expression is valid for
6553 an attribute here. Also handle the case of arrays of elements
6556 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
6557 encoding a linear array into an array of objects that are suitable
6558 to be passed to an CustomAttributeBuilder.
6560 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
6562 * ecore.cs: (FieldExpr): Handle field remapping here.
6564 * iteratators.cs: Pass the instance variable (if the method is an
6565 instance method) to the constructors, so we can access the field
6566 variables on the class.
6568 TODO: Test this with structs. I think the THIS variable on
6569 structs might have to be a pointer, and not a refenrece
6571 2003-04-27 Miguel de Icaza <miguel@ximian.com>
6573 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
6574 local variables to fields in a proxy class.
6576 * iterators.cs (PopulateProxy): Rename our internal fields to
6578 Create a <THIS> field if we are an instance method, so we can
6579 reference our parent container variables.
6580 (MapVariable): Called back from the EmitContext code to enter a
6581 new variable to field mapping into the proxy class (we just create
6585 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
6586 for using the remapped locals to fields.
6588 I placed the code here, because that gives the same semantics to
6589 local variables, and only changes the Emit code.
6591 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
6592 statements inside iterators.
6593 (VariableInfo): Add a FieldBuilder for the cases when we are
6594 remapping local variables to fields in a proxy class
6596 * ecore.cs (SimpleNameResolve): Avoid testing two times for
6597 current_block != null.
6599 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
6600 not cope with strings, as it has been moved to the
6601 TableSwitchEmit. Fixed bug in switch generation.
6603 * expression.cs (New.DoResolve): Provide more context for the user
6604 when reporting an error.
6606 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
6609 * expression.cs (MemberAccess.DoResolve): When we get a type back,
6610 check the permissions for it. Note than in a type-resolution
6611 context the check was already present in DeclSpace.ResolveType,
6612 but was missing from the MemberAccess.
6614 (ArrayCreation.CheckIndices): warn if the user has
6615 more nested levels of expressions, but there are no more
6616 dimensions specified. Avoids crash on bug 41906.
6618 2003-04-26 Miguel de Icaza <miguel@ximian.com>
6620 * statement.cs (Block): replace Implicit bool, for a generic
6622 New flag: `Unchecked'. This is used during the EmitMeta phase
6623 (which is out-of-line with the regular Resolve/Emit process for a
6624 statement, as this is done ahead of time, but still gets a chance
6625 to call constant resolve).
6627 (Block.Flags): new enum for adding a new flag.
6629 (Block.EmitMeta): track the state of unchecked.
6631 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
6632 to enable constant resolution to work there as well.
6634 2003-04-22 Miguel de Icaza <miguel@ximian.com>
6636 * typemanager.cs (ienumerable_type): Also look up
6637 System.Collections.IEnumerable.
6639 2003-04-21 Miguel de Icaza <miguel@ximian.com>
6641 TODO: Test more than one conditional per method.
6643 * class.cs (Indexer.Define): Report the location where the user is
6644 referencing the unsupported feature.
6646 (MethodData): Overload the use of `conditionals' to
6647 minimize the creation of needless ArrayLists. This saves roughly
6648 212kb on my machine.
6650 (Method): Implement the new IIteratorContainer interface.
6651 (Method.SetYields): Implement the method by setting the ModFlags
6652 to contain METHOD_YIELDS.
6654 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
6655 which just got set to null.
6657 * iterators.cs: New file.
6659 (Yield, YieldBreak): New statements.
6661 * statement.cs (Return.Resolve): Flag an error if we are used in
6664 * codegen.cs (InIterator): New flag set if the code is being
6665 compiled in an iterator method.
6667 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
6668 internal modifier, and we just use it to avoid adding extra
6669 fields, as this is seldom used.
6671 * cs-parser.jay: Add yield_statement (yield and yield break).
6673 * driver.cs: New flag -v2 to turn on version 2 features.
6675 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
6676 hashtable when v2 is enabled.
6678 2003-04-20 Miguel de Icaza <miguel@ximian.com>
6680 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
6681 there is already a namespace defined with this name.
6683 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
6684 people upgraded their corlibs.
6686 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
6687 always use fully qualified types, no need to use the compiler
6690 (TypeManager.IsNamespace): Use binarysearch.
6692 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
6693 AddDelegate): I did not quite use the new IsValid API properly: I
6694 have to pass the short-name and the fullname. I was passing only
6695 the basename instead of the fullname sometimes.
6697 (TypeContainer.DefineType): call NamespaceClash.
6699 * interface.cs (Interface.DefineType): use NamespaceClash before
6702 * delegate.cs (Delegate.DefineType): use NamespaceClash before
6705 * enum.cs: (Enum.DefineType): use NamespaceClash before
6708 * typemanager.cs (: 3-line patch that gives us some tasty 11%
6709 speed increase. First, use the negative_hits cache when we get a
6710 negative. Second, add the type with its full original name
6711 instead of the new . and + encoded name (reflection uses + to
6712 separate type from a nested type). Use LookupTypeReflection
6713 directly which bypasses the type->name hashtable (that we already
6714 know does not contain the type.
6716 * decl.cs (DeclSpace.ResolveTypeExpr): track the
6717 location/container type.
6719 * driver.cs: When passing utf8, use directly the UTF8Encoding.
6721 2003-04-19 Miguel de Icaza <miguel@ximian.com>
6723 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
6725 * delegate.cs (NewDelegate.Resolve): Test whether an instance
6726 method is being referenced in the method group from a static
6727 context, and report error 120 if so.
6729 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
6732 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
6733 is created, we create the A namespace).
6735 * cs-parser.jay: A namespace also introduces a DeclarationFound.
6738 2003-04-18 Miguel de Icaza <miguel@ximian.com>
6740 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
6741 invocation to ModuleBuilder.GetType with the same values will
6742 return a new type instance, so we need to cache its return
6745 * expression.cs (Binary.ResolveOperator): Only allow the compare
6746 operators on enums if they are of the same type.
6748 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
6749 types of ValueType on their own case. Before we were giving them
6750 the same treatment as objects.
6752 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
6753 fullname. Short name is used to compare against container name.
6754 Fullname is used to check against defined namespace names.
6756 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
6757 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
6759 (Method.CheckBase): Call parent.
6760 (MemberBase.CheckBase): Check for protected members on sealed
6762 (PropertyBase.CheckBase): Call parent.
6763 (Field.Define): Call parent.
6765 * report.cs: Negative error codes are now mapped to 8000 - code,
6766 so that the display is render more nicely.
6768 * typemanager.cs: Do not use try/catch, instead report a regular
6771 (GetPointerType, GetReferenceType): These methods provide
6772 mechanisms to obtain the T* and T& from a T. We had the code
6773 previously scattered around the code base, and it also used
6774 TypeManager.LookupType that would go through plenty of caches.
6775 This one goes directly to the type source.
6777 In some places we did the Type.GetType followed by
6778 ModuleBuilder.GetType, but not in others, so this unifies the
6781 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
6782 statements now that we have namespace information.
6784 * typemanager.cs (IsNamespace): New method, returns whether the
6785 string presented is a namespace or not.
6787 (ComputeNamespaces): New public entry point, computes the list of
6788 available namespaces, using the GetNamespaces API call in Mono, or
6789 the slower version in MS.NET.
6791 Now before we start the semantic analysis phase, we have a
6792 complete list of namespaces including everything that the user has
6795 Deleted old code to cache namespaces in .nsc files.
6797 2003-04-17 Miguel de Icaza <miguel@ximian.com>
6799 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
6800 class/struct location definition Location for the implicit
6801 constructor location.
6803 (Operator.Define): Use the location of the operator for the
6804 implicit Method definition.
6806 (Constructor.Emit): use the constructor location for the implicit
6807 base initializer constructor.
6809 * ecore.cs: Remove ITypeExpression. This interface is now gone,
6810 and the Expression class now contains two new methods:
6812 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
6813 isolate type lookup from the rest of the resolution process.
6815 Since we use Expressions to hold type definitions due to the way
6816 we parse the input we have historically overloaded Resolve to
6817 perform the Type lookups if a special flag is passed. Now this is
6818 eliminated and two methods take their place.
6820 The differences in the two methods between xStep and xTerminal is
6821 that xStep is involved in our current lookup system that uses
6822 SimpleNames to compose a name, while xTerminal is used just to
6823 catch the case where the simplename lookup failed.
6825 2003-04-16 Miguel de Icaza <miguel@ximian.com>
6827 * expression.cs (ResolveMemberAccess): Remove redundant code.
6828 TypeExpr expressions are always born fully resolved.
6830 * interface.cs (PopulateMethod): Do not lookup the types twice.
6831 We were doing it once during SemanticAnalysis and once during
6834 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
6835 in local variable type definitions, were being returned as a
6836 SimpleName (we decomposed everything into a string), that is
6837 because primary_expression was being used instead of a type in the
6838 grammar (reduce/reduce conflicts).
6840 The part that was wrong is that we converted the expression into a
6841 string (an oversimplification in one hand, compounded with primary
6842 expressions doing string concatenation).
6848 Would return "A.B.C[]" as a SimpleName. This stopped things like
6849 using clauses from working on this particular context. And a type
6850 was being matched directly against "A.B.C[]".
6852 We now use the correct approach, and allow for ComposedCast to be
6853 part of the unary expression. So the "A.B.C []" become a composed
6854 cast of "A.B.C" (as a nested group of MemberAccess with a
6855 SimpleName at the end) plus the rank composition "[]".
6859 2003-04-10 Miguel de Icaza <miguel@ximian.com>
6861 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
6862 for the access level checking.
6864 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
6865 `TypeContainer container', because I kept getting confused when I
6866 was debugging this code.
6868 * expression.cs (Indexers): Instead of tracking getters/setters,
6869 we now track them in parallel. We create one arraylist less, but
6870 most importantly it is possible now for the LValue code to find a
6871 matching get for a set.
6873 (IndexerAccess.DoResolveLValue): Update the code.
6874 GetIndexersForType has been modified already to extract all the
6875 indexers from a type. The code assumed it did not.
6877 Also make the code set the correct return type for the indexer.
6878 This was fixed a long time ago for properties, but was missing for
6879 indexers. It used to be void_type.
6881 (Binary.Emit): Test first for doubles instead of
6882 floats, as they are more common.
6884 (Binary.EmitBranchable): Use the .un version of the branch opcodes
6885 when dealing with floats and the <=, >= operators. This fixes bug
6888 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
6889 to load the array value by emitting a load on the foreach variable
6890 type. This was incorrect.
6892 We now emit the code to load an element using the the array
6893 variable type, and then we emit the conversion operator.
6897 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
6899 * attribute.cs: Avoid allocation of ArrayLists in the common case.
6901 2003-04-09 Miguel de Icaza <miguel@ximian.com>
6903 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
6904 test for protection before we test for signatures.
6906 (MethodSignature.ToString): implement.
6908 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
6909 to the case where we reduced into a LongConstant.
6911 * decl.cs (CheckAccessLevel): If the type is an array, we can not
6912 depend on whether the information is acurrate, because the
6913 Microsoft runtime will always claim that the array type is public,
6914 regardless of the real state.
6916 If the type is a pointer, another problem happens: the type is
6917 reported as non-public in Microsoft.
6919 In both cases we have to call CheckAccessLevel recursively with
6920 the underlying type as the argument to be tested.
6922 2003-04-08 Miguel de Icaza <miguel@ximian.com>
6924 * assign.cs (Assign.Emit): If we are dealing with a compound
6925 assignment expression, we should use the code path that stores the
6926 intermediate result in a temporary value. This fixes #40903.
6928 *expression.cs (Indirection.ToString): Provide ToString method for
6931 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
6933 * class.cs: Null out fields holding references to Block objects so
6934 they can be garbage collected.
6936 * expression.cs (OverloadResolve): Remove unused local.
6938 2003-04-07 Martin Baulig <martin@ximian.com>
6940 * codegen.cs (EmitContext.CurrentFile): New public field.
6941 (EmitContext.Mark): Use the CurrentFile to check whether the
6942 location is in the correct file.
6943 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
6945 2003-04-07 Martin Baulig <martin@ximian.com>
6947 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
6949 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
6950 location. [FIXME: The location argument which gets passed to this
6951 method is sometimes wrong!]
6953 2003-04-07 Nick Drochak <ndrochak@gol.com>
6955 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
6957 2003-04-07 Miguel de Icaza <miguel@ximian.com>
6959 * expression.cs (Indirection.EmitAssign): We were using the
6960 temporary, but returning immediately instead of continuing the
6963 2003-04-06 Martin Baulig <martin@ximian.com>
6965 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
6966 if it's a nested child, but also deriving from the outer class.
6969 * typemanager.cs (IsNestedChildOf): Make this work if it's a
6970 nested child, but also deriving from the outer class. See
6972 (FilterWithClosure): We may access private members of the outer
6973 class if we're a nested child and deriving from the outer class.
6974 (RealMemberLookup): Only set `closure_private_ok' if the
6975 `original_bf' contained BindingFlags.NonPublic.
6977 2003-04-05 Martin Baulig <martin@ximian.com>
6979 * expression.cs (SizeOf.DoResolve): Use ResolveTypeExpr, so we can
6980 probe if its a type parameter, and if so, flag an error.
6982 * decl.cs: Move here the SetParameterInfo code from class.cs.
6983 Handle IsGeneric here.
6985 Handle a variety of errors in the parameter info definition.
6987 * ecore.cs (SimpleName.DoResolveType): Handle look ups for generic
6988 type parameters here.
6990 * cs-parser.jay (class_declaration): report errors for parameters
6993 2003-01-21 Miguel de Icaza <miguel@ximian.com>
6995 * generic.cs: New file, contains support code for generics.
6997 * cs-parser.jay: Remove OP_SHIFT_LEFT, OP_SHIFT_RIGHT,
6998 OP_SHIFT_LEFT_ASSIGN, OP_SHIFT_RIGHT_ASSIGN.
7000 Update parser for the above removals.
7002 * cs-tokenizer.cs: Do not handle <<= or >>= specially. This is
7003 now taken care of in the parser.
7005 2003-04-02 Miguel de Icaza <miguel@ximian.com>
7007 * class.cs (Event.Define): Do not allow abstract events to have
7010 2003-04-01 Miguel de Icaza <miguel@ximian.com>
7012 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
7013 block in event declarations.
7015 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
7016 value type, get its address.
7018 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
7019 leaving a class on the stack instead of a boolean value (int
7020 0/1). Change the code so we compare against null, and then the
7021 result against zero.
7023 * class.cs (TypeContainer.GetClassBases): We were checking for the
7024 parent class being sealed too late.
7026 * expression.cs (Binary.Emit): For <= and >= when dealing with
7027 floating point values, use cgt.un and clt.un instead of cgt and
7030 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
7032 * statement.cs: Apply the same optimization as MS: skip the
7033 GetEnumerator returning an IEnumerator, and use the one returning a
7034 CharEnumerator instead. This allows us to avoid the try-finally block
7037 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
7039 * cs-parser.jay: Attributes cannot be applied to
7040 namespaces. Fixes #40473
7042 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7045 (Add*): check if the name is valid using the full name for constants,
7046 fields, properties and events.
7048 2003-03-28 Miguel de Icaza <miguel@ximian.com>
7050 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
7051 char constants to be part of the enumeration.
7053 * expression.cs (Conditional.DoResolve): Add support for operator
7054 true. Implements the missing functionality from 14.12
7056 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
7057 operator true/false as required by the spec.
7059 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
7060 implicit conversion to boolean.
7062 * statement.cs (Statement.ResolveBoolean): A boolean expression is
7063 also one where the type implements `operator true'.
7065 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
7066 get an expression that will invoke operator true based on an
7069 (GetConversionOperators): Removed the hack that called op_True
7072 (Expression.ResolveBoolean): Move this from Statement.
7074 2003-03-17 Miguel de Icaza <miguel@ximian.com>
7076 * ecore.cs (FieldExpr): do not allow initialization of initonly
7077 fields on derived classes
7079 2003-03-13 Martin Baulig <martin@ximian.com>
7081 * statement.cs (Block.Emit): Call ig.BeginScope() and
7082 ig.EndScope() when compiling with debugging info; call
7083 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
7085 2003-03-08 Miguel de Icaza <miguel@ximian.com>
7087 * expression.cs (Indexers): Do not construct immediately, allow
7088 for new members to be appended as we go. Fixes 38143
7090 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7092 * expression.cs: save/restore context when resolving an unchecked
7095 2003-03-05 Miguel de Icaza <miguel@ximian.com>
7097 * cfold.cs: Catch division by zero in modulus operator during
7100 2003-03-03 Miguel de Icaza <miguel@ximian.com>
7102 * interface.cs (Interface.DefineMembers): Avoid defining members
7105 2003-02-27 Miguel de Icaza <miguel@ximian.com>
7107 * driver.cs: handle the +/- options for -noconfig
7109 * statement.cs (Unckeched.Resolve): Also track the state of
7110 unchecked in the Resolve phase.
7112 2003-02-27 Martin Baulig <martin@ximian.com>
7114 * ecore.cs (Expression.MemberLookup): Don't create a
7115 MethodGroupExpr for something which is not a method. Fixes #38291.
7117 2003-02-25 Miguel de Icaza <miguel@ximian.com>
7119 * class.cs (MemberBase.CheckParameters): Also check that the type
7120 is unmanaged if it is a pointer.
7122 * expression.cs (SizeOf.Resolve): Add location information.
7124 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
7125 a managed type is declared.
7127 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
7128 parameter modifiers as well. Fixes bug 38606
7130 * class.cs: Very sad. Am backing out the speed up changes
7131 introduced by the ArrayList -> Array in the TypeContainer, as they
7132 were not actually that much faster, and introduced a bug (no error
7133 reports on duplicated methods).
7135 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
7136 source first, this will guarantee that we have a valid expression
7137 before calling in lower levels functions that will require a
7138 resolved object. Then use this original_source in the
7139 target.ResolveLValue instead of the original source that was
7142 Another change. Use target.Resolve instead of LValueResolve.
7143 Although we are resolving for LValues, we will let the Assign code
7144 take care of that (it will be called again from Resolve). This
7145 basically allows code like this:
7147 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
7148 class Y { void A (X x) { x [0] += o; }
7150 The problem was that the indexer was trying to resolve for
7151 set_Item (idx, object o) and never finding one. The real set_Item
7152 was set_Item (idx, X). By delaying the process we get the right
7157 2003-02-23 Martin Baulig <martin@ximian.com>
7159 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
7160 while calling DoEmit ().
7162 * codegen.cs (EmitContext.Mark): Don't mark locations in other
7163 source files; if you use the #line directive inside a method, the
7164 compiler stops emitting line numbers for the debugger until it
7165 reaches the end of the method or another #line directive which
7166 restores the original file.
7168 2003-02-23 Martin Baulig <martin@ximian.com>
7170 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
7172 2003-02-23 Martin Baulig <martin@ximian.com>
7174 * statement.cs (Block.AddChildVariableNames): We need to call this
7175 recursively, not just for our immediate children.
7177 2003-02-23 Martin Baulig <martin@ximian.com>
7179 * class.cs (Event.Define): Always make the field private, like csc does.
7181 * typemanager.cs (TypeManager.RealMemberLookup): Make events
7182 actually work, fixes bug #37521.
7184 2003-02-23 Miguel de Icaza <miguel@ximian.com>
7186 * delegate.cs: When creating the various temporary "Parameters"
7187 classes, make sure that we call the ComputeAndDefineParameterTypes
7188 on those new parameters (just like we do with the formal ones), to
7189 allow them to be resolved in the context of the DeclSpace.
7191 This fixes the bug that Dick observed in Bugzilla #38530.
7193 2003-02-22 Miguel de Icaza <miguel@ximian.com>
7195 * expression.cs (ResolveMemberAccess): When resolving a constant,
7196 do not attempt to pull a constant if the value was not able to
7197 generate a valid constant.
7199 * const.cs (LookupConstantValue): Do not report more errors than required.
7201 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7203 * expression.cs: fixes bug #38328.
7205 2003-02-18 Miguel de Icaza <miguel@ximian.com>
7207 * class.cs: Changed all the various members that can be part of a
7208 class from being an ArrayList to be an Array of the right type.
7209 During the DefineType type_list, interface_list, delegate_list and
7210 enum_list are turned into types, interfaces, delegates and enums
7213 And during the member population, indexer_list, event_list,
7214 constant_list, field_list, instance_constructor_list, method_list,
7215 operator_list and property_list are turned into their real arrays.
7217 Although we could probably perform this operation earlier, for
7218 good error reporting we need to keep the lists and remove the
7219 lists for longer than required.
7221 This optimization was triggered by Paolo profiling the compiler
7222 speed on the output of `gen-sample-program.pl' perl script.
7224 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
7225 not crash in methods like MemberLookupFailed that use this field.
7227 This problem arises when the compiler fails to resolve a type
7228 during interface type definition for example.
7230 2003-02-18 Miguel de Icaza <miguel@ximian.com>
7232 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
7233 inherit from System.Object, so we have to stop at null, not only
7234 when reaching System.Object.
7236 2003-02-17 Miguel de Icaza <miguel@ximian.com>
7238 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
7239 DeclaredOnly because the parent indexer might have had a different
7240 name, but did not loop until the top of the hierarchy was reached.
7242 The problem this one fixes is 35492: when a class implemented an
7243 indexer from an interface, we were getting the interface method
7244 (which was abstract) and we were flagging an error (can not invoke
7247 This also keeps bug 33089 functioning, and test-148 functioning.
7249 * typemanager.cs (IsSpecialMethod): The correct way of figuring
7250 out if a method is special is to see if it is declared in a
7251 property or event, or whether it is one of the predefined operator
7252 names. This should fix correctly #36804.
7254 2003-02-15 Miguel de Icaza <miguel@ximian.com>
7256 The goal here is to remove the dependency on EmptyCast.Peel ().
7257 Killing it completely.
7259 The problem is that currently in a number of places where
7260 constants are expected, we have to "probe" for an EmptyCast, and
7261 Peel, which is not the correct thing to do, as this will be
7262 repetitive and will likely lead to errors.
7264 The idea is to remove any EmptyCasts that are used in casts that
7265 can be reduced to constants, so we only have to cope with
7268 This bug hunt was triggered by Bug 37363 and the desire to remove
7269 the duplicate pattern where we were "peeling" emptycasts to check
7270 whether they were constants. Now constants will always be
7273 * ecore.cs: Use an enumconstant here instead of wrapping with
7276 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
7277 throwing me off. By handling this we can get rid of a few hacks.
7279 * statement.cs (Switch): Removed Peel() code.
7281 2003-02-14 Miguel de Icaza <miguel@ximian.com>
7283 * class.cs: Location information for error 508
7285 * expression.cs (New.DoResolve): Add a guard against double
7286 resolution of an expression.
7288 The New DoResolve might be called twice when initializing field
7289 expressions (see EmitFieldInitializers, the call to
7290 GetInitializerExpression will perform a resolve on the expression,
7291 and later the assign will trigger another resolution
7293 This leads to bugs (#37014)
7295 * delegate.cs: The signature for EndInvoke should contain any ref
7296 or out parameters as well. We were not doing this in the past.
7298 * class.cs (Field.Define): Do not overwrite the type definition
7299 inside the `volatile' group. Turns out that volatile enumerations
7300 were changing the type here to perform a validity test, which
7303 2003-02-12 Miguel de Icaza <miguel@ximian.com>
7305 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
7306 and structs, we do not want to load the instance variable
7308 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
7309 enum_type has to be handled like an object reference (implicit
7310 conversions exists from this to object), but the regular IsClass
7311 and IsValueType tests will never return true for this one.
7313 Also we use TypeManager.IsValueType instead of type.IsValueType,
7314 just for consistency with the rest of the code (this is only
7315 needed if we ever use the construct exposed by test-180.cs inside
7316 corlib, which we dont today).
7318 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
7320 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
7323 2003-02-09 Martin Baulig <martin@ximian.com>
7325 * namespace.cs (Namespace..ctor): Added SourceFile argument.
7326 (Namespace.DefineNamespaces): New static public method; this is
7327 called when we're compiling with debugging to add all namespaces
7330 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
7331 pass it to the Namespace's .ctor.
7333 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
7334 and MethodBase arguments; pass the namespace ID to the symwriter;
7335 pass the MethodBase instead of the token to the symwriter.
7336 (SymbolWriter.DefineNamespace): New method to add a namespace to
7339 2003-02-09 Martin Baulig <martin@ximian.com>
7341 * symbolwriter.cs: New file. This is a wrapper around
7342 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
7343 methods here in near future.
7345 2003-02-09 Martin Baulig <martin@ximian.com>
7347 * codegen.cs (EmitContext.Mark): Just pass the arguments to
7348 ILGenerator.MarkSequencePoint() which are actually used by the
7351 2003-02-09 Martin Baulig <martin@ximian.com>
7353 * location.cs (SourceFile): New public sealed class. This
7354 contains the name and an index which is used in the location's token.
7355 (Location): Reserve an appropriate number of bits in the token for
7356 the source file instead of walking over that list, this gives us a
7357 really huge performance improvement when compiling with debugging.
7359 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
7360 `SourceFile' argument instead of a string.
7361 (Driver.ProcessFile): Add all the files via Location.AddFile(),
7362 but don't parse/tokenize here, we need to generate the list of all
7363 source files before we do that.
7364 (Driver.ProcessFiles): New static function. Parses/tokenizes all
7367 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
7368 instead of a string.
7370 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
7373 2003-02-09 Martin Baulig <martin@ximian.com>
7375 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
7376 filename on `#line default'.
7378 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
7380 * statement.cs: don't clear the pinned var when the fixed statement
7381 returns from the method (fixes bug#37752).
7383 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
7385 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
7388 2003-02-07 Martin Baulig <martin@ximian.com>
7390 * driver.cs: Removed the `--debug-args' command line argument.
7392 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
7393 automatically by the AsssemblyBuilder.
7394 (CodeGen.InitializeSymbolWriter): We don't need to call any
7395 initialization function on the symbol writer anymore. This method
7396 doesn't take any arguments.
7398 2003-02-03 Miguel de Icaza <miguel@ximian.com>
7400 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
7401 from referenced assemblies as well.
7403 2003-02-02 Martin Baulig <martin@ximian.com>
7405 * class.cs (MethodData.Emit): Generate debugging info for external methods.
7407 2003-02-02 Martin Baulig <martin@ximian.com>
7409 * class.cs (Constructor.Emit): Open the symbol writer before
7410 emitting the constructor initializer.
7411 (ConstructorInitializer.Emit): Call ec.Mark() to allow
7412 single-stepping through constructor initializers.
7414 2003-01-30 Miguel de Icaza <miguel@ximian.com>
7416 * class.cs: Handle error 549: do not allow virtual methods in
7419 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
7421 * decl.cs: Check access levels when resolving types
7423 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
7425 * statement.cs: Add parameters and locals set in catch blocks that might
7426 return to set vector
7428 2003-01-29 Miguel de Icaza <miguel@ximian.com>
7430 * class.cs (Operator): Set the SpecialName flags for operators.
7432 * expression.cs (Invocation.DoResolve): Only block calls to
7433 accessors and operators on SpecialName methods.
7435 (Cast.TryReduce): Handle conversions from char constants.
7438 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
7440 * statement.cs: small memory and time optimization in FlowBranching.
7442 2003-01-28 Pedro Mart <yoros@wanadoo.es>
7444 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
7445 problem that the last fix but in the other sid (Set).
7447 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
7448 access when there is no indexer in the hierarchy.
7450 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
7452 * class.cs: Combine some if statements.
7454 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7456 * driver.cs: fixed bug #37187.
7458 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
7460 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
7461 any indexer, it's needed to build a list with all the indexers in the
7462 hierarchy (AllGetters), else we have problems. Fixes #35653.
7464 2003-01-23 Miguel de Icaza <miguel@ximian.com>
7466 * class.cs (MethodData.Define): It is wrong for an interface
7467 implementation to be static in both cases: explicit and implicit.
7468 We were only handling this in one case.
7470 Improve the if situation there to not have negations.
7472 * class.cs (Field.Define): Turns out that we do not need to check
7473 the unsafe bit on field definition, only on usage. Remove the test.
7475 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7477 * driver.cs: use assembly.Location instead of Codebase (the latest
7478 patch made mcs fail when using MS assemblies).
7480 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
7482 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
7483 get the path to *corlib.dll.
7485 2003-01-21 Nick Drochak <ndrochak@gol.com>
7489 * typemanager.cs: Remove compiler warnings
7491 2003-01-20 Duncan Mak <duncan@ximian.com>
7493 * AssemblyInfo.cs: Bump the version number to 0.19.
7495 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7497 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
7499 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
7501 * class.cs (Constructor::Emit): Emit debugging info for constructors.
7503 2003-01-17 Miguel de Icaza <miguel@ximian.com>
7505 * cs-parser.jay: Small fix: we were not comparing the constructor
7506 name correctly. Thanks to Zoltan for the initial pointer.
7508 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
7510 * cs-tokenizer.cs: Set file name when specified with #line
7512 2003-01-15 Miguel de Icaza <miguel@ximian.com>
7514 * cs-parser.jay: Only perform the constructor checks here if we
7515 are named like the class; This will help provider a better
7516 error. The constructor path is taken when a type definition is
7517 not found, but most likely the user forgot to add the type, so
7518 report that rather than the constructor error.
7520 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
7522 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
7525 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
7527 * cs-parser.jay: Add cleanup call.
7529 2003-01-13 Duncan Mak <duncan@ximian.com>
7531 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
7532 consistent with other methods.
7534 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
7536 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
7538 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
7540 * attribute.cs: only set GuidAttr to true when we have a
7543 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7547 * typemanager.cs: fixes to allow mcs compile corlib with the new
7548 Type.IsSubclassOf fix.
7550 2003-01-08 Miguel de Icaza <miguel@ximian.com>
7552 * expression.cs (LocalVariableReference.DoResolve): Classify a
7553 constant as a value, not as a variable. Also, set the type for
7556 * cs-parser.jay (fixed_statement): take a type instead of a
7557 pointer_type, so we can produce a better error message later.
7559 * statement.cs (Fixed.Resolve): Flag types that are not pointers
7562 (For.DoEmit): Make inifinite loops have a
7563 non-conditional branch back.
7565 (Fixed.DoEmit): First populate the pinned variables, then emit the
7566 statement, then clear the variables. Before I was emitting the
7567 code once for each fixed piece.
7570 2003-01-08 Martin Baulig <martin@ximian.com>
7572 * statement.cs (FlowBranching.MergeChild): A break in a
7573 SWITCH_SECTION does not leave a loop. Fixes #36155.
7575 2003-01-08 Martin Baulig <martin@ximian.com>
7577 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
7578 lives in the same number space than `param_map'. Fixes #36154.
7580 2003-01-07 Miguel de Icaza <miguel@ximian.com>
7582 * cs-parser.jay (constructor_declaration): Set the
7583 Constructor.ModFlags before probing for it. This makes the
7584 compiler report 514, 515 and 132 (the code was there, but got
7587 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
7588 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
7589 (GotoCase.Resolve): Set `Returns' to ALWAYS.
7591 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
7593 * enum.cs: create the enum static fields using the enum type.
7595 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
7597 * class.cs: don't try to create the ParamBuilder for the return
7598 type if it's not needed (and handle it breaking for the ms runtime
7601 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
7603 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
7605 2002-12-29 Miguel de Icaza <miguel@ximian.com>
7607 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
7608 the command. This showed up while compiling the JANET source
7609 code, which used \r as its only newline separator.
7611 2002-12-28 Miguel de Icaza <miguel@ximian.com>
7613 * class.cs (Method.Define): If we are an operator (because it
7614 reuses our code), then set the SpecialName and HideBySig. #36128
7616 2002-12-22 Miguel de Icaza <miguel@ximian.com>
7618 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
7619 exception, report error 120 `object reference required'.
7621 * driver.cs: Add --pause option, used during to measure the size
7622 of the process as it goes with --timestamp.
7624 * expression.cs (Invocation.DoResolve): Do not allow methods with
7625 SpecialName to be invoked.
7627 2002-12-21 Miguel de Icaza <miguel@ximian.com>
7629 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
7630 number before adding it.
7632 2002-12-21 Ravi Pratap <ravi@ximian.com>
7634 * ecore.cs (StandardImplicitConversion): When in an unsafe
7635 context, we allow conversion between void * to any other pointer
7636 type. This fixes bug #35973.
7638 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
7640 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
7641 is not thrown when extensionless outputs are used
7643 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7645 * rootcontext.cs: fixed compilation of corlib.
7647 2002-12-19 Miguel de Icaza <miguel@ximian.com>
7649 * attribute.cs (Attributes.Contains): Add new method.
7651 * class.cs (MethodCore.LabelParameters): if the parameter is an
7652 `out' parameter, check that no attribute `[In]' has been passed.
7654 * enum.cs: Handle the `value__' name in an enumeration.
7656 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
7658 * decl.cs: Added special case to allow overrides on "protected
7661 2002-12-18 Ravi Pratap <ravi@ximian.com>
7663 * attribute.cs (Attributes.AddAttributeSection): Rename to this
7664 since it makes much more sense.
7666 (Attributes.ctor): Don't require a Location parameter.
7668 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
7670 * attribute.cs (ApplyAttributes): Remove extra Location parameters
7671 since we already have that information per attribute.
7673 * everywhere : make appropriate changes.
7675 * class.cs (LabelParameters): Write the code which actually
7676 applies attributes to the return type. We can't do this on the MS
7677 .NET runtime so we flag a warning in the case an exception is
7680 2002-12-18 Miguel de Icaza <miguel@ximian.com>
7682 * const.cs: Handle implicit null conversions here too.
7684 2002-12-17 Ravi Pratap <ravi@ximian.com>
7686 * class.cs (MethodCore.LabelParameters): Remove the extra
7687 Type [] parameter since it is completely unnecessary. Instead
7688 pass in the method's attributes so that we can extract
7689 the "return" attribute.
7691 2002-12-17 Miguel de Icaza <miguel@ximian.com>
7693 * cs-parser.jay (parse): Use Report.Error to flag errors instead
7694 of ignoring it and letting the compile continue.
7696 * typemanager.cs (ChangeType): use an extra argument to return an
7697 error condition instead of throwing an exception.
7699 2002-12-15 Miguel de Icaza <miguel@ximian.com>
7701 * expression.cs (Unary.TryReduce): mimic the code for the regular
7702 code path. Perform an implicit cast in the cases where we can
7703 implicitly convert to one of the integral types, and then reduce
7704 based on that constant. This fixes bug #35483.
7706 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7708 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
7710 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7712 * namespace.cs: fixed bug #35489.
7714 2002-12-12 Miguel de Icaza <miguel@ximian.com>
7716 * class.cs: Remove some dead code.
7718 * cs-parser.jay: Estimate the number of methods needed
7719 (RootContext.MethodCount);
7721 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
7722 numbers instead of StringBuilders.
7724 * support.cs (PtrHashtable): Add constructor with initial size;
7725 We can now reduce reallocations of the method table.
7727 2002-12-10 Ravi Pratap <ravi@ximian.com>
7729 * attribute.cs (ApplyAttributes): Keep track of the emitted
7730 attributes on a per-target basis. This fixes bug #35413.
7732 2002-12-10 Miguel de Icaza <miguel@ximian.com>
7734 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
7735 default to the Windows 1252 encoding.
7737 (UnixParseOption): Support version, thanks to Alp for the missing
7740 * AssemblyInfo.cs: Add nice assembly information.
7742 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
7745 * cs-parser.jay: Allow a trailing comma before the close bracked
7746 in the attribute_section production.
7748 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
7749 address of the instance was being taken, I will take this out,
7750 because we take the address of the object immediately here.
7752 2002-12-09 Ravi Pratap <ravi@ximian.com>
7754 * typemanager.cs (AreMultipleAllowed): Take care of the most
7755 obvious case where attribute type is not in the current assembly -
7758 2002-12-08 Miguel de Icaza <miguel@ximian.com>
7760 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
7761 definitions, instead of doing that afterwards.
7763 Also we use a nice little hack, depending on the constructor, we
7764 know if we are a "composed" name or a simple name. Hence, we
7765 avoid the IndexOf test, and we avoid
7767 * codegen.cs: Add code to assist in a bug reporter to track down
7768 the source of a compiler crash.
7770 2002-12-07 Ravi Pratap <ravi@ximian.com>
7772 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
7773 types have been emitted for a given element and flag an error
7774 if something which does not have AllowMultiple set is used more
7777 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
7778 attribute types and their corresponding AllowMultiple properties
7780 (AreMultipleAllowed): Check the property for a given type.
7782 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
7783 property in the case we have a TypeContainer.
7785 (Attributes.AddAttribute): Detect duplicates and just skip on
7786 adding them. This trivial fix catches a pretty gross error in our
7787 attribute emission - global attributes were being emitted twice!
7789 Bugzilla bug #33187 is now fixed.
7791 2002-12-06 Miguel de Icaza <miguel@ximian.com>
7793 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
7796 * expression.cs (Binary.ResolveOperator): I can only use the
7797 Concat (string, string, string) and Concat (string, string,
7798 string, string) if the child is actually a concatenation of
7801 2002-12-04 Miguel de Icaza <miguel@ximian.com>
7803 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
7804 context where we need a 2-character lookahead.
7806 * pending.cs (PendingImplementation): Rework so we can keep track
7807 of interface types all the time, and flag those which were
7808 implemented by parents as optional.
7810 2002-12-03 Miguel de Icaza <miguel@ximian.com>
7812 * expression.cs (Binary.ResolveOperator): Use
7813 String.Concat(string,string,string) or
7814 String.Concat(string,string,string,string) when possible.
7816 * typemanager: More helper methods.
7819 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
7821 * pending.cs: remove the bogus return from GetMissingInterfaces()
7822 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
7824 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7826 * namespace.cs: avoid duplicated 'using xxx' being added to
7827 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
7828 when we get more than one 'using' statement for the same namespace.
7829 Report a CS0105 warning for it.
7831 2002-11-30 Miguel de Icaza <miguel@ximian.com>
7833 * cs-tokenizer.cs (consume_identifier): use read directly, instead
7834 of calling getChar/putback, uses internal knowledge of it.
7836 (xtoken): Reorder tokenizer so most common patterns are checked
7837 first. This reduces the compilation time in another 5% (from 8.11s
7838 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
7840 The parsing time is 22% of the compilation in mcs, and from that
7841 64% is spent on the tokenization process.
7843 I tried using a binary search for keywords, but this is slower
7844 than the hashtable. Another option would be to do a couple of
7847 * Not use a StringBuilder, instead use an array of chars,
7848 with a set value. Notice that this way we could catch
7849 the 645 error without having to do it *afterwards*.
7851 * We could write a hand-parser to avoid the hashtable
7852 compares altogether.
7854 The identifier consumption process takes 37% of the tokenization
7855 time. Another 15% is spent on is_number. 56% of the time spent
7856 on is_number is spent on Int64.Parse:
7858 * We could probably choose based on the string length to
7859 use Int32.Parse or Int64.Parse and avoid all the 64-bit
7862 Another 3% is spend on wrapping `xtoken' in the `token' function.
7864 Handle 0xa0 as whitespace (#34752)
7866 2002-11-26 Miguel de Icaza <miguel@ximian.com>
7868 * typemanager.cs (IsCLRType): New routine to tell whether a type
7869 is one of the builtin types.
7871 Maybe it needs to use TypeCodes to be faster. Maybe we could use
7872 typecode in more places instead of doing pointer comparissions.
7873 We could leverage some knowledge about the way the typecodes are
7876 New code to cache namespaces in assemblies, it is currently not
7877 invoked, to be used soon.
7879 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
7881 * expression.cs (Binary.ResolveOperator): specially handle
7882 strings, and do not perform user-defined operator overloading for
7885 2002-11-24 Miguel de Icaza <miguel@ximian.com>
7887 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
7888 internalcall as it is a pretty simple operation; Avoid whenever
7889 possible to call Char.IsLetter.
7891 (consume_identifier): Cut by half the number of
7892 hashtable calls by merging the is_keyword and GetKeyword behavior.
7894 Do not short-circuit, because if we do, we
7895 report errors (ie, #if false && true would produce an invalid
7899 2002-11-24 Martin Baulig <martin@ximian.com>
7901 * expression.cs (Cast.TryReduce): If we're in checked syntax,
7902 check constant ranges and report a CS0221. Fixes #33186.
7904 2002-11-24 Martin Baulig <martin@ximian.com>
7906 * cs-parser.jay: Make this work for uninitialized variable
7907 declarations in the `for' initializer. Fixes #32416.
7909 2002-11-24 Martin Baulig <martin@ximian.com>
7911 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
7912 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
7914 2002-11-24 Martin Baulig <martin@ximian.com>
7916 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
7917 argument; if true, we also check for user-defined conversions.
7918 This is only needed if both arguments are of a user-defined type.
7919 Fixes #30443, added test-175.cs.
7920 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
7922 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
7924 2002-11-24 Martin Baulig <martin@ximian.com>
7926 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
7927 function to get the store opcode.
7928 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
7929 only emit the Ldelema if the store opcode is Stobj. You must run
7930 both test-34 and test-167 to test this. Fixes #34529.
7932 2002-11-23 Martin Baulig <martin@ximian.com>
7934 * ecore.cs (Expression.MemberLookup): Added additional
7935 `qualifier_type' argument which is used when we're being called
7936 from MemberAccess.DoResolve() and null if we're called from a
7938 (Expression.MemberLookupFailed): New method to report errors; this
7939 does the CS1540 check and reports the correct error message.
7941 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
7942 argument for the CS1540 check and redone the way how we're dealing
7943 with private members. See the comment in the source code for details.
7944 (FilterWithClosure): Reverted this back to revision 1.197; renamed
7945 `closure_start_type' to `closure_qualifier_type' and check whether
7946 it's not null. It was not this filter being broken, it was just
7947 being called with the wrong arguments.
7949 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
7950 and pass it the correct `qualifier_type'; this also does the error
7953 2002-11-22 Miguel de Icaza <miguel@ximian.com>
7955 * expression.cs (Invocation.EmitParams): If the we are dealing
7956 with a non-built-in value type, load its address as well.
7958 (ArrayCreation): Use a a pretty constant instead
7959 of the hardcoded value 2. Use 6 instead of 2 for the number of
7960 static initializers.
7962 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
7963 because they are not really value types, just glorified integers.
7965 * driver.cs: Do not append .exe, the CSC compiler does not do it.
7967 * ecore.cs: Remove redundant code for enumerations, make them use
7968 the same code path as everything else, fixes the casting issue
7969 with enumerations in Windows.Forms.
7971 * attribute.cs: Do only cast to string if it is a string, the
7972 validation happens later.
7974 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
7975 people upgrade their corlibs.
7977 * ecore.cs: Oops, enumerations were not following the entire code path
7979 2002-11-21 Miguel de Icaza <miguel@ximian.com>
7981 * typemanager.cs (FilterWithClosure): Commented out the test for
7982 1540 in typemanager.cs, as it has problems when accessing
7983 protected methods from a parent class (see test-174.cs).
7985 * attribute.cs (Attribute.ValidateGuid): new method.
7986 (Attribute.Resolve): Use above.
7988 2002-11-19 Miguel de Icaza <miguel@ximian.com>
7990 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
7992 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
7993 handling for enumerations, as we only needed the TypeContainer
7994 functionality to begin with (this is required for the fix below to
7995 work for enums that reference constants in a container class for
7998 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
8000 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
8001 a valid TypeBuilder to perform lookups on.o
8003 * class.cs (InheritableMemberSignatureCompare): Use true in the
8004 call to GetGetMethod and GetSetMethod, because we are comparing
8005 the signature, and we need to get the methods *even* if they are
8008 (PropertyBase.CheckBase): ditto.
8010 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
8011 GotoCase.Resolve): Use Peel on EmpytCasts.
8013 * ecore.cs (EmptyCast): drop child, add Peel method.
8015 2002-11-17 Martin Baulig <martin@ximian.com>
8017 * ecore.cs (EmptyCast.Child): New public property.
8019 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
8020 label resolved to an EmptyCast. Fixes #34162.
8021 (GotoCase.Resolve): Likewise.
8022 (Block.EmitMeta): Likewise.
8024 2002-11-17 Martin Baulig <martin@ximian.com>
8026 * expression.cs (Invocation.BetterConversion): Prefer int over
8027 uint; short over ushort; long over ulong for integer literals.
8028 Use ImplicitConversionExists instead of StandardConversionExists
8029 since we also need to check for user-defined implicit conversions.
8030 Fixes #34165. Added test-173.cs.
8032 2002-11-16 Martin Baulig <martin@ximian.com>
8034 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
8035 with the `true' and `false' literals. Fixes #33151.
8037 2002-11-16 Martin Baulig <martin@ximian.com>
8039 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
8040 October 22nd; don't do the cs1540 check for static members.
8042 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
8043 now using our own filter here and doing the cs1540 check again.
8045 2002-11-16 Martin Baulig <martin@ximian.com>
8047 * support.cs (InternalParameters): Don't crash if we don't have
8048 any fixed parameters. Fixes #33532.
8050 2002-11-16 Martin Baulig <martin@ximian.com>
8052 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
8053 when looking up static methods to make this work on Windows.
8056 2002-11-16 Martin Baulig <martin@ximian.com>
8058 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
8059 a setter rather than using PropertyInfo.CanWrite.
8061 2002-11-15 Nick Drochak <ndrochak@gol.com>
8063 * class.cs: Allow acces to block member by subclasses. Fixes build
8066 2002-11-14 Martin Baulig <martin@ximian.com>
8068 * class.cs (Constructor.Emit): Added the extern/block check.
8071 2002-11-14 Martin Baulig <martin@ximian.com>
8073 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
8074 iteration while looking for indexers, this is needed because the
8075 indexer may have a different name in our base classes. Fixed the
8076 error reporting (no indexers at all, not get accessor, no
8077 overloaded match). Fixes bug #33089.
8078 (IndexerAccess.DoResolveLValue): Likewise.
8080 2002-11-14 Martin Baulig <martin@ximian.com>
8082 * class.cs (PropertyBase.CheckBase): Make this work for multiple
8083 indexers. Fixes the first part of bug #33089.
8084 (MethodSignature.InheritableMemberSignatureCompare): Added support
8087 2002-11-13 Ravi Pratap <ravi@ximian.com>
8089 * attribute.cs (Attribute.Resolve): Catch the
8090 NullReferenceException and report it since it isn't supposed to
8093 2002-11-12 Miguel de Icaza <miguel@ximian.com>
8095 * expression.cs (Binary.EmitBranchable): Also handle the cases for
8096 LogicalOr and LogicalAnd that can benefit from recursively
8097 handling EmitBranchable. The code now should be nice for Paolo.
8099 2002-11-08 Miguel de Icaza <miguel@ximian.com>
8101 * typemanager.cs (LookupType): Added a negative-hit hashtable for
8102 the Type lookups, as we perform quite a number of lookups on
8103 non-Types. This can be removed once we can deterministically tell
8104 whether we have a type or a namespace in advance.
8106 But this might require special hacks from our corlib.
8110 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
8111 and double which avoids a conversion from an integer to a double.
8113 * expression.cs: tiny optimization, avoid calling IsConstant,
8114 because it effectively performs the lookup twice.
8116 2002-11-06 Miguel de Icaza <miguel@ximian.com>
8118 But a bogus return here to keep the semantics of the old code
8119 until the Mono runtime is fixed.
8121 * pending.cs (GetMissingInterfaces): New method used to remove all
8122 the interfaces that are already implemented by our parent
8123 classes from the list of pending methods.
8125 * interface.cs: Add checks for calls after ResolveTypeExpr.
8127 2002-11-05 Miguel de Icaza <miguel@ximian.com>
8129 * class.cs (Class.Emit): Report warning 67: event not used if the
8130 warning level is beyond 3.
8132 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
8133 being a NullLiteral.
8135 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
8138 * class.cs (TypeContainer.GetClassBases): Cover a missing code
8139 path that might fail if a type can not be resolved.
8141 * expression.cs (Binary.Emit): Emit unsigned versions of the
8144 * driver.cs: use error 5.
8146 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
8148 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
8150 2002-11-01 Miguel de Icaza <miguel@ximian.com>
8152 * cs-parser.jay (switch_section): A beautiful patch from Martin
8153 Baulig that fixed 33094.
8155 2002-10-31 Miguel de Icaza <miguel@ximian.com>
8157 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
8158 Check whether the base is abstract and report an error if so.
8160 * expression.cs (IndexerAccess.DoResolveLValue,
8161 IndexerAccess.DoResolve): ditto.
8163 (Invocation.DoResolve): ditto.
8165 (Invocation.FullMethodDesc): Improve the report string.
8167 * statement.cs (Block): Eliminate IsVariableDefined as it is
8168 basically just a wrapper for GetVariableInfo.
8170 * ecore.cs (SimpleName): Use new
8172 * support.cs (ReflectionParamter.ParameterType): We unwrap the
8173 type, as we return the actual parameter ref/unref state on a
8176 2002-10-30 Miguel de Icaza <miguel@ximian.com>
8178 * support.cs: Return proper flags REF/OUT fixing the previous
8181 * expression.cs: Reverted last patch, that was wrong. Is_ref is
8182 not used to mean `ref' but `ref or out' in ParameterReference
8184 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
8185 full type signature instead of calling TypeManger.CSharpName
8188 * support.cs (InternalParameters.ParameterDesc): Do not compare
8189 directly to the modflags, because REF/OUT will actually be bitsets
8192 * delegate.cs (VerifyMethod): Check also the modifiers.
8194 * cs-tokenizer.cs: Fix bug where floating point values with an
8195 exponent where a sign was missing was ignored.
8197 * driver.cs: Allow multiple assemblies to be specified in a single
8200 2002-10-28 Miguel de Icaza <miguel@ximian.com>
8202 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
8203 because identifiers after a parenthesis would end up in this kind
8204 of production, and we needed to desamiguate it for having casts
8207 (UserDefinedType *) xxx
8209 2002-10-24 Miguel de Icaza <miguel@ximian.com>
8211 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
8212 we should set on the Bindingflags.NonPublic, but not turn on
8213 private_ok. private_ok controls whether a Private member is
8214 returned (this is chekced on the filter routine), while the
8215 BindingFlags.NonPublic just controls whether private/protected
8216 will be allowed. This fixes the problem part of the problem of
8217 private properties being allowed to be used in derived classes.
8219 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
8220 so we can call the children DoResolveLValue method (this will
8221 properly signal errors on lvalue assignments to base properties)
8223 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
8224 getter are null, and we have a property info, we know that this
8225 happened because the lookup failed, so we report an error 122 for
8226 protection level violation.
8228 We also silently return if setter and getter are null in the
8229 resolve functions, this condition only happens if we have flagged
8230 the error before. This is the other half of the problem.
8232 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
8233 not have accessibility information, that is why we were returning
8234 true in the filter function in typemanager.cs.
8236 To properly report 122 (property is inaccessible because of its
8237 protection level) correctly, we report this error in ResolveAccess
8238 by failing if both the setter and the getter are lacking (ie, the
8241 DoResolve and DoLResolve have been modified to check for both
8242 setter/getter being null and returning silently, the reason being
8243 that I did not want to put the knowledge about this error in upper
8246 int old = Report.Errors;
8247 x = new PropertyExpr (...);
8248 if (old != Report.Errors)
8253 So the property expr is returned, but it is invalid, so the error
8254 will be flagged during the resolve process.
8256 * class.cs: Remove InheritablePropertySignatureCompare from the
8257 class, as we no longer depend on the property signature to compute
8258 whether it is possible to implement a method or not.
8260 The reason is that calling PropertyInfo.GetGetMethod will return
8261 null (in .NET, in Mono it works, and we should change this), in
8262 cases where the Get Method does not exist in that particular
8267 class X { public virtual int A { get { return 1; } } }
8269 class Z : Y { public override int A { get { return 2; } } }
8271 Would fail in Z because the parent (Y) would not have the property
8272 defined. So we avoid this completely now (because the alternative
8273 fix was ugly and slow), and we now depend exclusively on the
8276 (PropertyBase.CheckBase): Use a method-base mechanism to find our
8277 reference method, instead of using the property.
8279 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
8280 routines are gone now.
8282 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
8283 names, they were incorrectly named.
8285 * cs-tokenizer.cs: Return are more gentle token on failure.
8287 * pending.cs (PendingImplementation.InterfaceMethod): This routine
8288 had an out-of-sync index variable, which caused it to remove from
8289 the list of pending methods the wrong method sometimes.
8291 2002-10-22 Miguel de Icaza <miguel@ximian.com>
8293 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
8294 CanWrite, because those refer to this particular instance of the
8295 property, and do not take into account the fact that we can
8296 override single members of a property.
8298 Constructor requires an EmitContext. The resolution process does
8299 not happen here, but we need to compute the accessors before,
8300 because the resolution does not always happen for properties.
8302 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
8303 subclass, before we did not update this flag, but we did update
8306 (GetAccessors): Drop this routine, as it did not work in the
8307 presence of partially overwritten set/get methods.
8309 Notice that this broke the cs1540 detection, but that will require
8312 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8316 * driver.cs: issue a warning instead of an error if we don't support
8317 debugging for the platform. Also ignore a couple of errors that may
8318 arise when trying to write the symbols. Undo my previous patch.
8320 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8322 * driver.cs: ignore /debug switch except for Unix platforms.
8324 2002-10-23 Nick Drochak <ndrochak@gol.com>
8326 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
8328 2002-10-21 Miguel de Icaza <miguel@ximian.com>
8330 * driver.cs: Do not make mcs-debug conditional, so we do not break
8333 * statement.cs (UsageVector.MergeChildren): I would like Martin to
8334 review this patch. But basically after all the children variables
8335 have been merged, the value of "Breaks" was not being set to
8336 new_breaks for Switch blocks. I think that it should be set after
8337 it has executed. Currently I set this to the value of new_breaks,
8338 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
8339 conservative, but I do not understand this code very well.
8341 I did not break anything in the build, so that is good ;-)
8343 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
8345 2002-10-20 Mark Crichton <crichton@gimp.org>
8347 * cfold.cs: Fixed compile blocker. Really fixed it this time.
8349 2002-10-20 Nick Drochak <ndrochak@gol.com>
8351 * cfold.cs: Fixed compile blocker.
8353 2002-10-20 Miguel de Icaza <miguel@ximian.com>
8355 * driver.cs: I was chekcing the key, not the file.
8357 2002-10-19 Ravi Pratap <ravi@ximian.com>
8359 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
8360 message that we were generating - we just need to silently return
8363 2002-10-19 Miguel de Icaza <miguel@ximian.com>
8365 * class.cs (Event.Define): Change my previous commit, as this
8366 breaks the debugger. This is a temporary hack, as it seems like
8367 the compiler is generating events incorrectly to begin with.
8369 * expression.cs (Binary.ResolveOperator): Added support for
8370 "U operator - (E x, E y)"
8372 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
8375 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
8376 init-only variables, but this path did not take into account that
8377 there might be also instance readonly variables. Correct this
8380 This fixes bug 32253
8382 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
8385 * driver.cs: Change the extension for modules to `netmodule'
8387 * cs-parser.jay: Improved slightly the location tracking for
8388 the debugger symbols.
8390 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
8391 modifiers that were specified instead of the hardcoded value
8392 (FamAndAssem). This was basically ignoring the static modifier,
8393 and others. Fixes 32429.
8395 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
8396 fixed a bug in the process (32476)
8398 * expression.cs (ArrayAccess.EmitAssign): Patch from
8399 hwang_rob@yahoo.ca that fixes bug 31834.3
8401 2002-10-18 Miguel de Icaza <miguel@ximian.com>
8403 * driver.cs: Make the module extension .netmodule.
8405 2002-10-16 Miguel de Icaza <miguel@ximian.com>
8407 * driver.cs: Report an error if the resource file is not found
8408 instead of crashing.
8410 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
8411 false, like Emit does.
8413 2002-10-16 Nick Drochak <ndrochak@gol.com>
8415 * typemanager.cs: Remove unused private member. Also reported mcs
8416 bug to report this as a warning like csc.
8418 2002-10-15 Martin Baulig <martin@gnome.org>
8420 * statement.cs (Statement.Emit): Made this a virtual method; emits
8421 the line number info and calls DoEmit().
8422 (Statement.DoEmit): New protected abstract method, formerly knows
8423 as Statement.Emit().
8425 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
8427 2002-10-11 Miguel de Icaza <miguel@ximian.com>
8429 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
8430 have fixed a remaining problem: not every AddXXXX was adding a
8431 fully qualified name.
8433 Now everyone registers a fully qualified name in the DeclSpace as
8434 being defined instead of the partial name.
8436 Downsides: we are slower than we need to be due to the excess
8437 copies and the names being registered this way.
8439 The reason for this is that we currently depend (on the corlib
8440 bootstrap for instance) that types are fully qualified, because
8441 we dump all the types in the namespace, and we should really have
8442 types inserted into the proper namespace, so we can only store the
8443 basenames in the defined_names array.
8445 2002-10-10 Martin Baulig <martin@gnome.org>
8447 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
8448 from bug #31834, see the bug report for a testcase which is
8451 2002-10-10 Martin Baulig <martin@gnome.org>
8453 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
8454 flow analysis code for this.
8456 * statement.cs (Do, While, For): Tell the flow analysis code about
8458 (FlowBranching.UsageVector): Added support for infinite loops.
8459 (Block.Resolve): Moved the dead code elimination here and use flow
8462 2002-10-09 Miguel de Icaza <miguel@ximian.com>
8464 * class.cs (Field.Define): Catch cycles on struct type
8467 * typemanager.cs (IsUnmanagedtype): Do not recursively check
8468 fields if the fields are static. We only need to check instance
8471 * expression.cs (As.DoResolve): Test for reference type.
8473 * statement.cs (Using.ResolveExpression): Use
8474 ConvertImplicitRequired, not ConvertImplicit which reports an
8476 (Using.ResolveLocalVariableDecls): ditto.
8478 * expression.cs (Binary.ResolveOperator): Report errors in a few
8479 places where we had to.
8481 * typemanager.cs (IsUnmanagedtype): Finish implementation.
8483 2002-10-08 Miguel de Icaza <miguel@ximian.com>
8485 * expression.cs: Use StoreFromPtr instead of extracting the type
8486 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
8488 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
8489 an enumeration value to a System.Enum, but System.Enum is not a
8490 value type, but an class type, so we need to box.
8492 (Expression.ConvertExplicit): One codepath could return
8493 errors but not flag them. Fix this. Fixes #31853
8495 * parameter.cs (Resolve): Do not allow void as a parameter type.
8497 2002-10-06 Martin Baulig <martin@gnome.org>
8499 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
8500 if it's a class type and not a struct. Fixes #31815.
8502 2002-10-06 Martin Baulig <martin@gnome.org>
8504 * statement.cs: Reworked the flow analysis code a bit to make it
8505 usable for dead code elimination.
8507 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8509 * cs-parser.jay: allow empty source files. Fixes bug #31781.
8511 2002-10-04 Miguel de Icaza <miguel@ximian.com>
8513 * expression.cs (ComposedCast.DoResolveType): A quick workaround
8514 to fix the test 165, will investigate deeper.
8516 2002-10-04 Martin Baulig <martin@gnome.org>
8518 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
8519 finally blocks actually work.
8520 (Try.Resolve): We don't need to create a sibling for `finally' if
8521 there is no finally block.
8523 2002-10-04 Martin Baulig <martin@gnome.org>
8525 * class.cs (Constructor.Define): The default accessibility for a
8526 non-default constructor is private, not public.
8528 2002-10-04 Miguel de Icaza <miguel@ximian.com>
8530 * class.cs (Constructor): Make AllowedModifiers public, add
8533 * cs-parser.jay: Perform the modifiers test here, as the
8534 constructor for the Constructor class usually receives a zero
8535 because of the way we create it (first we create, later we
8536 customize, and we were never checking the modifiers).
8538 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
8539 is a version of LookupTypeReflection that includes the type-name
8540 cache. This can be used as a fast path for functions that know
8541 the fully qualified name and are only calling into *.GetType() to
8542 obtain a composed type.
8544 This is also used by TypeManager.LookupType during its type
8547 (LookupType): We now also track the real type name, as sometimes
8548 we can get a quey for the real type name from things like
8549 ComposedCast. This fixes bug 31422.
8551 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
8552 complete type fullname, it does not have to go through the type
8553 resolution system to obtain the composed version of the type (for
8554 obtaining arrays or pointers).
8556 (Conditional.Emit): Use the EmitBoolExpression to
8557 generate nicer code, as requested by Paolo.
8559 (ArrayCreation.CheckIndices): Use the patch from
8560 hwang_rob@yahoo.ca to validate the array initializers.
8562 2002-10-03 Miguel de Icaza <miguel@ximian.com>
8564 * class.cs (ConstructorInitializer.Emit): simplify code by using
8565 Invocation.EmitCall, and at the same time, fix the bugs in calling
8566 parent constructors that took variable arguments.
8568 * ecore.cs (Expression.ConvertNumericExplicit,
8569 Expression.ImplicitNumericConversion): Remove the code that
8570 manually wrapped decimal (InternalTypeConstructor call is now gone
8573 * expression.cs (Cast.TryReduce): Also handle decimal types when
8574 trying to perform a constant fold on the type.
8576 * typemanager.cs (IsUnmanagedtype): Partially implemented.
8578 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
8579 that only turned off an error report, and did nothing else.
8581 2002-10-02 Miguel de Icaza <miguel@ximian.com>
8583 * driver.cs: Handle and ignore /fullpaths
8585 2002-10-01 Miguel de Icaza <miguel@ximian.com>
8587 * expression.cs (Binary.ResolveOperator): Catch the case where
8588 DoNumericPromotions returns true,
8590 (Binary.DoNumericPromotions): Simplify the code, and the tests.
8592 2002-09-27 Miguel de Icaza <miguel@ximian.com>
8594 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
8597 2002-09-26 Miguel de Icaza <miguel@ximian.com>
8599 * ecore.cs (ConvertNumericExplicit): It is not enough that the
8600 conversion exists, but it is also required that the conversion be
8601 performed. This manifested in "(Type64Enum) 2".
8603 * class.cs (TypeManager.AddMethod): The fix is not to change
8604 AddEnum, because that one was using a fully qualified name (every
8605 DeclSpace derivative does), but to change the AddMethod routine
8606 that was using an un-namespaced name. This now correctly reports
8607 the duplicated name.
8609 Revert patch until I can properly fix it. The issue
8610 is that we have a shared Type space across all namespaces
8611 currently, which is wrong.
8613 Options include making the Namespace a DeclSpace, and merge
8614 current_namespace/current_container in the parser.
8616 2002-09-25 Miguel de Icaza <miguel@ximian.com>
8618 * cs-parser.jay: Improve error reporting when we get a different
8619 kind of expression in local_variable_type and
8620 local_variable_pointer_type.
8622 Propagate this to avoid missleading errors being reported.
8624 * ecore.cs (ImplicitReferenceConversion): treat
8625 TypeManager.value_type as a target just like object_type. As
8630 Is valid, and needs to result in the int 1 being boxed before it
8631 is assigned to the value type v.
8633 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
8634 to validate the enumeration name.
8636 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
8637 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
8638 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
8640 * ecore.cs (TryImplicitIntConversion): When doing an
8641 implicit-enumeration-conversion, check if the type is 64-bits and
8642 perform a conversion before passing to EnumConstant.
8644 2002-09-23 Miguel de Icaza <miguel@ximian.com>
8646 * decl.cs (Error_AmbiguousTypeReference); New routine used to
8647 report ambiguous type references. Unlike the MS version, we
8648 report what the ambiguity is. Innovation at work ;-)
8650 (DeclSpace.FindType): Require a location argument to
8651 display when we display an ambiguous error.
8653 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
8655 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
8657 * expression.cs (EmitDynamicInitializers): Apply patch from
8658 hwang_rob@yahoo.ca that fixes the order in which we emit our
8661 2002-09-21 Martin Baulig <martin@gnome.org>
8663 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
8664 delegate takes no arguments.
8666 2002-09-20 Miguel de Icaza <miguel@ximian.com>
8668 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
8671 * expression.cs: Extract the underlying type.
8673 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
8675 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
8677 2002-09-19 Miguel de Icaza <miguel@ximian.com>
8679 * class.cs (TypeContainer.DefineType): We can not use the nice
8680 PackingSize with the size set to 1 DefineType method, because it
8681 will not allow us to define the interfaces that the struct
8684 This completes the fixing of bug 27287
8686 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
8687 means also structs. This fixes part of the problem.
8688 (Expresion.ImplicitReferenceConversionExists): ditto.
8690 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
8691 error if there were no errors reported during the type lookup
8692 process, to avoid duplicates or redundant errors. Without this
8693 you would get an ambiguous errors plus a type not found. We have
8694 beaten the user enough with the first error.
8696 (DeclSparce.FindType): Emit a warning if we have an ambiguous
8699 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
8700 during the resolution process, stop the lookup, this avoids
8701 repeated error reports (same error twice).
8703 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
8705 * typemanager.cs (LookupType): Redo the type lookup code to match
8706 the needs of System.Reflection.
8708 The issue is that System.Reflection requires references to nested
8709 types to begin with a "+" sign instead of a dot. So toplevel
8710 types look like: "NameSpace.TopLevelClass", and nested ones look
8711 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
8714 2002-09-19 Martin Baulig <martin@gnome.org>
8716 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
8717 says that a method always returns or always throws an exception,
8718 don't report the CS0161.
8720 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
8721 set `Returns = new_returns'.
8723 2002-09-19 Martin Baulig <martin@gnome.org>
8725 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
8726 to an enum constant, check for a CS0176.
8728 2002-09-18 Miguel de Icaza <miguel@ximian.com>
8730 * class.cs (TypeContainer.CheckPairedOperators): Now we check
8731 for operators that must be in pairs and report errors.
8733 * ecore.cs (SimpleName.DoResolveType): During the initial type
8734 resolution process, when we define types recursively, we must
8735 check first for types in our current scope before we perform
8736 lookups in the enclosing scopes.
8738 * expression.cs (MakeByteBlob): Handle Decimal blobs.
8740 (Invocation.VerifyArgumentsCompat): Call
8741 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
8742 I thought we were supposed to always call this, but there are a
8743 few places in the code where we dont do it.
8745 2002-09-17 Miguel de Icaza <miguel@ximian.com>
8747 * driver.cs: Add support in -linkres and -resource to specify the
8748 name of the identifier.
8750 2002-09-16 Miguel de Icaza <miguel@ximian.com>
8752 * ecore.cs (StandardConversionExists): Sync with the conversion
8753 code: allow anything-* to void* conversions.
8755 (FindMostSpecificSource): Use an Expression argument
8756 instead of a Type, because we might be handed over a Literal which
8757 gets a few more implicit conversions that plain types do not. So
8758 this information was being lost.
8760 Also, we drop the temporary type-holder expression when not
8763 2002-09-17 Martin Baulig <martin@gnome.org>
8765 * class.cs (PropertyBase.CheckBase): Don't check the base class if
8766 this is an explicit interface implementation.
8768 2002-09-17 Martin Baulig <martin@gnome.org>
8770 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
8771 different `IndexerName' attributes.
8773 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
8774 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
8775 virtual CommonResolve().
8777 2002-09-16 Miguel de Icaza <miguel@ximian.com>
8779 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
8780 and convert that to the UnderlyingType.
8782 * statement.cs (Foreach.Resolve): Indexers are just like variables
8783 or PropertyAccesses.
8785 * cs-tokenizer.cs (consume_string): Track line numbers and columns
8786 inside quoted strings, we were not doing this before.
8788 2002-09-16 Martin Baulig <martin@gnome.org>
8790 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
8791 resolve it. This is needed for the definite assignment check of the
8792 instance expression, fixes bug #29846.
8793 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
8795 2002-09-16 Nick Drochak <ndrochak@gol.com>
8797 * parameter.cs: Fix compile error. Cannot reference static member
8798 from an instance object. Is this an mcs bug?
8800 2002-09-14 Martin Baulig <martin@gnome.org>
8802 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
8803 multiple times. Fixes bug #30295, added test-166.cs.
8805 2002-09-14 Martin Baulig <martin@gnome.org>
8807 * statement.cs (Block.Emit): Don't emit unreachable code.
8808 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
8810 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
8812 2002-09-14 Martin Baulig <martin@gnome.org>
8814 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
8817 2002-09-14 Martin Baulig <martin@gnome.org>
8819 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
8820 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
8821 be false on the ms runtime.
8823 2002-09-13 Martin Baulig <martin@gnome.org>
8825 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
8826 the CS0038 error message.
8828 2002-09-12 Miguel de Icaza <miguel@ximian.com>
8830 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
8831 constant inside, return it.
8833 2002-09-12 Martin Baulig <martin@gnome.org>
8835 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
8836 implicit conversion can be done between enum types.
8838 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
8839 check whether an implicit conversion to the current enum's UnderlyingType
8840 exists and report an error if not.
8842 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
8843 without debugging support.
8845 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
8846 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
8848 2002-09-12 Martin Baulig <martin@gnome.org>
8850 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
8852 * ecore.cs (IMemberExpr.DeclaringType): New property.
8853 (SimpleName.SimpleNameResolve): Check whether we're accessing a
8854 nonstatic member of an outer type (CS0038).
8856 2002-09-11 Miguel de Icaza <miguel@ximian.com>
8858 * driver.cs: Activate the using-error detector at warning level
8859 4 (at least for MS-compatible APIs).
8861 * namespace.cs (VerifyUsing): Small buglett fix.
8863 * pending.cs (PendingImplementation): pass the container pointer.
8865 * interface.cs (GetMethods): Allow for recursive definition. Long
8866 term, I would like to move every type to support recursive
8867 definitions, not the current ordering mechanism that we have right
8870 The situation is this: Attributes are handled before interfaces,
8871 so we can apply attributes to interfaces. But some attributes
8872 implement interfaces, we will now handle the simple cases
8873 (recursive definitions will just get an error).
8875 * parameter.cs: Only invalidate types at the end if we fail to
8878 2002-09-09 Martin Baulig <martin@gnome.org>
8880 * ecore.cs (PropertyExpr.Emit): Also check for
8881 TypeManager.system_int_array_get_length so this'll also work when
8882 compiling corlib. Fixes #30003.
8884 2002-09-09 Martin Baulig <martin@gnome.org>
8886 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
8887 and throw an exception if we can't get the type's size. Fixed #30040,
8890 2002-09-09 Martin Baulig <martin@gnome.org>
8892 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
8894 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
8895 context. Fixes bug #30027.
8897 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
8898 virtual functions. Fixes bug #30043, added test-164.cs.
8900 2002-09-08 Ravi Pratap <ravi@ximian.com>
8902 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
8904 2002-09-08 Nick Drochak <ndrochak@gol.com>
8906 * driver.cs: Use an object to get the windows codepage since it's not a
8909 2002-09-08 Miguel de Icaza <miguel@ximian.com>
8911 * statement.cs (For.Emit): for infinite loops (test == null)
8912 return whether there is a break inside, not always "true".
8914 * namespace.cs (UsingEntry): New struct to hold the name of the
8915 using definition, the location where it is defined, and whether it
8916 has been used in a successful type lookup.
8918 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
8923 2002-09-06 Ravi Pratap <ravi@ximian.com>
8925 * attribute.cs : Fix incorrect code which relied on catching
8926 a NullReferenceException to detect a null being passed in
8927 where an object was expected.
8929 2002-09-06 Miguel de Icaza <miguel@ximian.com>
8931 * statement.cs (Try): flag the catch variable as assigned
8933 * expression.cs (Cast): Simplified by using ResolveType instead of
8936 * statement.cs (Catch): Fix bug by using ResolveType.
8938 2002-09-06 Ravi Pratap <ravi@ximian.com>
8940 * expression.cs (BetterConversion): Special case for when we have
8941 a NullLiteral as the argument and we have to choose between string
8942 and object types - we choose string the way csc does.
8944 * attribute.cs (Attribute.Resolve): Catch the
8945 NullReferenceException and report error #182 since the Mono
8946 runtime no more has the bug and having this exception raised means
8947 we tried to select a constructor which takes an object and is
8950 2002-09-05 Ravi Pratap <ravi@ximian.com>
8952 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
8953 message (1502, 1503) when we can't locate a method after overload
8954 resolution. This is much more informative and closes the bug
8957 * interface.cs (PopulateMethod): Return if there are no argument
8958 types. Fixes a NullReferenceException bug.
8960 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
8961 expressions too. Previously we were checking only in one place for
8962 positional arguments leaving out named arguments.
8964 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
8965 type to the enum type is not allowed. Remove code corresponding to
8968 (ConvertNumericExplicit): Allow explicit conversions from
8969 the underlying type to enum type. This precisely follows the spec
8970 and closes a bug filed by Gonzalo.
8972 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8975 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
8977 2002-09-03 Miguel de Icaza <miguel@ximian.com>
8979 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
8980 it was important that we stored the right value after the
8981 reduction in `converted'.
8983 2002-09-04 Martin Baulig <martin@gnome.org>
8985 * location.cs (Location.SymbolDocument): Use full pathnames for the
8988 2002-08-30 Miguel de Icaza <miguel@ximian.com>
8990 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
8991 of the expression resolve mechanism, because that will catch the
8992 SimpleName error failures.
8994 (Conditional): If we can not resolve the
8995 expression, return, do not crash.
8997 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9000 (location): display token name instead of its number.
9002 2002-08-28 Martin Baulig <martin@gnome.org>
9004 * expression.cs (Binary.ResolveOperator): Don't silently return
9005 but return an error if an operator cannot be applied between two
9008 2002-08-28 Martin Baulig <martin@gnome.org>
9010 * class.cs (Constructor.Define): Set the permission attributes
9011 correctly instead of making all constructors public.
9013 2002-08-28 Martin Baulig <martin@gnome.org>
9015 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
9016 for private members before reporting a CS0103; if we find anything,
9019 2002-08-28 Martin Baulig <martin@gnome.org>
9021 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
9022 to check whether `closure_start_type == closure_invocation_type',
9023 we also need to check whether `m.DeclaringType == closure_invocation_type'
9024 before bypassing the permission checks. We might be accessing
9025 protected/private members from the base class.
9026 (TypeManager.RealMemberLookup): Only set private_ok if private
9027 members were requested via BindingFlags.NonPublic.
9029 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
9031 * expression.cs (MemberAccess.ResolveMemberAccess): Set
9032 MethodGroupExpr.IsExplicitImpl if appropriate.
9033 (Invocation.DoResolve): Don't report the CS0120 for explicit
9034 interface implementations.
9036 2002-08-27 Martin Baulig <martin@gnome.org>
9038 * expression.cs (Invocation.DoResolve): If this is a static
9039 method and we don't have an InstanceExpression, we must report
9042 2002-08-25 Martin Baulig <martin@gnome.org>
9044 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
9045 `==' between a valuetype and an object.
9047 2002-08-25 Miguel de Icaza <miguel@ximian.com>
9049 * ecore.cs (TypeExpr): Provide a ToString method.
9051 2002-08-24 Martin Baulig <martin@gnome.org>
9053 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
9054 now called proggie.dbg and it's a binary file.
9056 2002-08-23 Martin Baulig <martin@gnome.org>
9058 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
9060 2002-08-23 Martin Baulig <martin@gnome.org>
9062 * struct.cs (MyStructInfo.ctor): Make this work with empty
9063 structs; it's not allowed to use foreach() on null.
9065 2002-08-23 Martin Baulig <martin@gnome.org>
9067 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
9068 writer the full pathname of the generated assembly.
9070 2002-08-23 Martin Baulig <martin@gnome.org>
9072 * statements.cs (FlowBranching.UsageVector.MergeChildren):
9073 A `finally' block never returns or breaks; improved handling of
9076 2002-08-23 Martin Baulig <martin@gnome.org>
9078 * statement.cs (Throw.Resolve): Allow `throw null'.
9080 2002-08-23 Martin Baulig <martin@gnome.org>
9082 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
9083 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
9084 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
9085 MemberLookup would return a wrong event if this is an explicit
9086 interface implementation and the class has an event with the same
9089 2002-08-23 Martin Baulig <martin@gnome.org>
9091 * statement.cs (Block.AddChildVariableNames): New public method.
9092 (Block.AddChildVariableName): Likewise.
9093 (Block.IsVariableNameUsedInChildBlock): Likewise.
9094 (Block.AddVariable): Check whether a variable name has already
9095 been used in a child block.
9097 * cs-parser.jay (declare_local_variables): Mark all variable names
9098 from the current block as being used in a child block in the
9101 2002-08-23 Martin Baulig <martin@gnome.org>
9103 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
9104 find the symbol writer.
9106 * driver.cs: csc also allows the arguments to /define being
9107 separated by commas, not only by semicolons.
9109 2002-08-23 Martin Baulig <martin@gnome.org>
9111 * interface.cs (Interface.GetMembers): Added static check for events.
9113 2002-08-15 Martin Baulig <martin@gnome.org>
9115 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
9116 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
9118 * ecore.cs (Expression.MemberLookup): Added documentation and explained
9119 why the MethodData.EmitDestructor() change was necessary.
9121 2002-08-20 Martin Baulig <martin@gnome.org>
9123 * class.cs (TypeContainer.FindMembers): Added static check for events.
9125 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
9127 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
9128 use Type.GetEvents(), not Type.FindMembers().
9130 2002-08-20 Martin Baulig <martin@gnome.org>
9132 * decl.cs (MemberCache): Added a special method cache which will
9133 be used for method-only searched. This ensures that a method
9134 search will return a MethodInfo with the correct ReflectedType for
9137 2002-08-20 Martin Baulig <martin@gnome.org>
9139 * decl.cs (DeclSpace.FindMembers): Made this public.
9141 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9143 * delegate.cs: fixed build on windows.
9144 [FIXME: Filed as bug #29150: MCS must report these errors.]
9146 2002-08-19 Ravi Pratap <ravi@ximian.com>
9148 * ecore.cs (StandardConversionExists): Return a false
9149 if we are trying to convert the void type to anything else
9150 since that is not allowed.
9152 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
9153 we flag error 70 in the event an event is trying to be accessed
9154 directly from outside the declaring type.
9156 2002-08-20 Martin Baulig <martin@gnome.org>
9158 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
9159 MemberCache from typemanager.cs to decl.cs.
9161 2002-08-19 Martin Baulig <martin@gnome.org>
9163 * class.cs (TypeContainer): Implement IMemberContainer.
9164 (TypeContainer.DefineMembers): Create the MemberCache.
9165 (TypeContainer.FindMembers): Do better BindingFlags checking; only
9166 return public members if BindingFlags.Public was given, check
9167 whether members are static.
9169 2002-08-16 Martin Baulig <martin@gnome.org>
9171 * decl.cs (DeclSpace.Define): Splitted this in Define and
9172 DefineMembers. DefineMembers is called first and initializes the
9175 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
9176 DefineMembers() on all our DeclSpaces.
9178 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
9179 but call DefineMembers() on all nested interfaces. We call their
9180 Define() in our new Define() function.
9182 * interface.cs (Interface): Implement IMemberContainer.
9183 (Interface.Define): Moved all code except the attribute stuf to
9185 (Interface.DefineMembers): Initialize the member cache.
9187 * typemanager.cs (IMemberFinder): Removed this interface, we don't
9188 need this anymore since we can use MemberCache.FindMembers directly.
9190 2002-08-19 Martin Baulig <martin@gnome.org>
9192 * typemanager.cs (MemberCache): When creating the cache for an
9193 interface type, add all inherited members.
9194 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
9195 to `out bool used_cache' and documented it.
9196 (TypeManager.MemberLookup): If we already used the cache in the first
9197 iteration, we don't need to do the interfaces check.
9199 2002-08-19 Martin Baulig <martin@gnome.org>
9201 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
9202 here from IMemberFinder and don't implement this interface anymore.
9203 (DeclSpace.MemberCache): Moved here from IMemberFinder.
9205 * typemanager.cs (IMemberFinder): This interface is now only used by
9206 classes which actually support the member cache.
9207 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
9208 since we only put DeclSpaces into this Hashtable.
9209 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
9210 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
9212 2002-08-16 Martin Baulig <martin@gnome.org>
9214 * typemanager.cs (ICachingMemberFinder): Removed.
9215 (IMemberFinder.MemberCache): New property.
9216 (TypeManager.FindMembers): Merged this with RealFindMembers().
9217 This function will never be called from TypeManager.MemberLookup()
9218 so we can't use the cache here, just the IMemberFinder.
9219 (TypeManager.MemberLookup_FindMembers): Check whether the
9220 IMemberFinder has a MemberCache and call the cache's FindMembers
9222 (MemberCache): Rewrote larger parts of this yet another time and
9223 cleaned it up a bit.
9225 2002-08-15 Miguel de Icaza <miguel@ximian.com>
9227 * driver.cs (LoadArgs): Support quoting.
9229 (Usage): Show the CSC-like command line arguments.
9231 Improved a few error messages.
9233 2002-08-15 Martin Baulig <martin@gnome.org>
9235 * typemanager.cs (IMemberContainer.Type): New property.
9236 (IMemberContainer.IsInterface): New property.
9238 The following changes are conditional to BROKEN_RUNTIME, which is
9239 defined at the top of the file.
9241 * typemanager.cs (MemberCache.MemberCache): Don't add the base
9242 class'es members, but add all members from TypeHandle.ObjectType
9243 if we're an interface.
9244 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
9245 is the current type.
9246 (MemberCache.CacheEntry.Container): Removed this field.
9247 (TypeHandle.GetMembers): Include inherited members.
9249 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9251 * typemanager.cs: fixed compilation and added a comment on a field that
9254 2002-08-15 Martin Baulig <martin@gnome.org>
9256 * class.cs (ConstructorInitializer.Resolve): In the
9257 Expression.MemberLookup call, use the queried_type as
9260 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
9261 declared' attribute, it's always true.
9262 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
9263 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
9264 temporary wrapper for FindMembers which tells MemberLookup whether
9265 members from the base classes are included in the return value.
9266 This will go away soon.
9267 (TypeManager.MemberLookup): Use this temporary hack here; once the
9268 new MemberCache is completed, we don't need to do the DeclaredOnly
9269 looping here anymore since the MemberCache will take care of this.
9270 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
9271 (MemberCache): When creating the MemberCache for a class, get
9272 members from the current class and all its base classes.
9273 (MemberCache.CacheEntry.Container): New field. This is a
9274 temporary hack until the Mono runtime is fixed to distinguish
9275 between ReflectedType and DeclaringType. It allows us to use MCS
9276 with both the MS runtime and the unfixed Mono runtime without
9277 problems and without accecting performance.
9278 (MemberCache.SearchMembers): The DeclaredOnly looping from
9279 TypeManager.MemberLookup is now done here.
9281 2002-08-14 Martin Baulig <martin@gnome.org>
9283 * statement.cs (MyStructInfo.MyStructInfo): Don't call
9284 Type.GetFields on dynamic types but get the fields from the
9285 corresponding TypeContainer.
9286 (MyStructInfo.GetStructInfo): Added check for enum types.
9288 * typemanager.cs (MemberList.IsSynchronized): Implemented.
9289 (MemberList.SyncRoot): Implemented.
9290 (TypeManager.FilterWithClosure): No need to check permissions if
9291 closure_start_type == closure_invocation_type, don't crash if
9292 closure_invocation_type is null.
9294 2002-08-13 Martin Baulig <martin@gnome.org>
9296 Rewrote TypeContainer.FindMembers to use a member cache. This
9297 gives us a speed increase of about 35% for the self-hosting MCS
9298 build and of about 15-20% for the class libs (both on GNU/Linux).
9300 * report.cs (Timer): New class to get enhanced profiling. This
9301 whole class is "TIMER" conditional since it remarkably slows down
9304 * class.cs (MemberList): New class. This is an IList wrapper
9305 which we're now using instead of passing MemberInfo[]'s around to
9306 avoid copying this array unnecessarily.
9307 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
9308 (ICachingMemberFinder, IMemberContainer): New interface.
9309 (TypeManager.FilterWithClosure): If `criteria' is null, the name
9310 has already been checked, otherwise use it for the name comparision.
9311 (TypeManager.FindMembers): Renamed to RealMemberFinder and
9312 provided wrapper which tries to use ICachingMemberFinder.FindMembers
9313 if possible. Returns a MemberList, not a MemberInfo [].
9314 (TypeHandle): New class, implements IMemberContainer. We create
9315 one instance of this class per type, it contains a MemberCache
9316 which is used to do the member lookups.
9317 (MemberCache): New class. Each instance of this class contains
9318 all members of a type and a name-based hash table.
9319 (MemberCache.FindMembers): This is our new member lookup
9320 function. First, it looks up all members of the requested name in
9321 the hash table. Then, it walks this list and sorts out all
9322 applicable members and returns them.
9324 2002-08-13 Martin Baulig <martin@gnome.org>
9326 In addition to a nice code cleanup, this gives us a performance
9327 increase of about 1.4% on GNU/Linux - not much, but it's already
9328 half a second for the self-hosting MCS compilation.
9330 * typemanager.cs (IMemberFinder): New interface. It is used by
9331 TypeManager.FindMembers to call FindMembers on a TypeContainer,
9332 Enum, Delegate or Interface.
9333 (TypeManager.finder_to_member_finder): New PtrHashtable.
9334 (TypeManager.finder_to_container): Removed.
9335 (TypeManager.finder_to_delegate): Removed.
9336 (TypeManager.finder_to_interface): Removed.
9337 (TypeManager.finder_to_enum): Removed.
9339 * interface.cs (Interface): Implement IMemberFinder.
9341 * delegate.cs (Delegate): Implement IMemberFinder.
9343 * enum.cs (Enum): Implement IMemberFinder.
9345 * class.cs (TypeContainer): Implement IMemberFinder.
9347 2002-08-12 Martin Baulig <martin@gnome.org>
9349 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
9351 2002-08-12 Martin Baulig <martin@gnome.org>
9353 * ecore.cs (ITypeExpression): New interface for expressions which
9355 (TypeExpression): Renamed to TypeLookupExpression.
9356 (Expression.DoResolve): If we're doing a types-only lookup, the
9357 expression must implement the ITypeExpression interface and we
9358 call DoResolveType() on it.
9359 (SimpleName): Implement the new ITypeExpression interface.
9360 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
9361 hack, the situation that we're only looking up types can't happen
9362 anymore when this method is called. Moved the type lookup code to
9363 DoResolveType() and call it.
9364 (SimpleName.DoResolveType): This ITypeExpression interface method
9365 is now doing the types-only lookup.
9366 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
9367 (ResolveFlags): Added MaskExprClass.
9369 * expression.cs (MemberAccess): Implement the ITypeExpression
9371 (MemberAccess.DoResolve): Added support for a types-only lookup
9372 when we're called via ITypeExpression.DoResolveType().
9373 (ComposedCast): Implement the ITypeExpression interface.
9375 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
9376 Expression.Resolve() with ResolveFlags.Type instead.
9378 2002-08-12 Martin Baulig <martin@gnome.org>
9380 * interface.cs (Interface.Define): Apply attributes.
9382 * attribute.cs (Attribute.ApplyAttributes): Added support for
9383 interface attributes.
9385 2002-08-11 Martin Baulig <martin@gnome.org>
9387 * statement.cs (Block.Emit): Only check the "this" variable if we
9388 do not always throw an exception.
9390 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
9391 whether the property has a set accessor.
9393 2002-08-11 Martin Baulig <martin@gnome.org>
9395 Added control flow analysis support for structs.
9397 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
9398 with control flow analysis turned off.
9399 (IVariable): New interface.
9400 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
9401 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
9402 (FieldExpr.DoResolve): Resolve the instance expression with flow
9403 analysis turned off and do the definite assignment check after the
9404 resolving when we know what the expression will resolve to.
9406 * expression.cs (LocalVariableReference, ParameterReference):
9407 Implement the new IVariable interface, only call the flow analysis
9408 code if ec.DoFlowAnalysis is true.
9409 (This): Added constructor which takes a Block argument. Implement
9410 the new IVariable interface.
9411 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
9412 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
9413 This does the definite assignment checks for struct members.
9415 * class.cs (Constructor.Emit): If this is a non-static `struct'
9416 constructor which doesn't have any initializer, call
9417 Block.AddThisVariable() to tell the flow analysis code that all
9418 struct elements must be initialized before control returns from
9421 * statement.cs (MyStructInfo): New public class.
9422 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
9423 argument to this indexer. If non-zero, check an individual struct
9424 member, not the whole struct.
9425 (FlowBranching.CheckOutParameters): Check struct members.
9426 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
9427 overloaded versions of these methods which take an additional
9428 `int field_idx' argument to check struct members.
9429 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
9430 overloaded versions of these methods which take an additional
9431 `string field_name' argument to check struct member.s
9432 (VariableInfo): Implement the IVariable interface.
9433 (VariableInfo.StructInfo): New public property. Returns the
9434 MyStructInfo instance of the variable if it's a struct or null.
9435 (Block.AddThisVariable): New public method. This is called from
9436 Constructor.Emit() for non-static `struct' constructor which do
9437 not have any initializer. It creates a special variable for the
9438 "this" instance variable which will be checked by the flow
9439 analysis code to ensure that all of the struct's fields are
9440 initialized before control returns from the constructor.
9441 (UsageVector): Added support for struct members. If a
9442 variable/parameter is a struct with N members, we reserve a slot
9443 in the usage vector for each member. A struct is considered fully
9444 initialized if either the struct itself (slot 0) or all its
9445 members are initialized.
9447 2002-08-08 Martin Baulig <martin@gnome.org>
9449 * driver.cs (Driver.MainDriver): Only report an error CS5001
9450 if there were no compilation errors.
9452 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
9453 `UnsafeContext' property to determine whether the parent is in
9454 unsafe context rather than checking the parent's ModFlags:
9455 classes nested in an unsafe class are unsafe as well.
9457 2002-08-08 Martin Baulig <martin@gnome.org>
9459 * statement.cs (UsageVector.MergeChildren): Distinguish between
9460 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
9461 we return. Added test17() and test18() to test-154.cs.
9463 2002-08-08 Martin Baulig <martin@gnome.org>
9465 * typemanager.cs (TypeManager.FilterWithClosure): If we have
9466 Family access, make sure the invoking type isn't a subclass of the
9467 queried type (that'd be a CS1540).
9469 * ecore.cs (Expression.MemberLookup): Added overloaded version of
9470 this method which takes an additional `Type invocation_type'.
9472 * expression.cs (BaseAccess.DoResolve): Use the base type as
9473 invocation and query type.
9474 (MemberAccess.DoResolve): If the lookup failed and we're about to
9475 report a CS0122, try a lookup with the ec.ContainerType - if this
9476 succeeds, we must report a CS1540.
9478 2002-08-08 Martin Baulig <martin@gnome.org>
9480 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
9481 (MethodGroupExpr): Implement the IMemberExpr interface.
9483 * expression (MemberAccess.ResolveMemberAccess): No need to have
9484 any special code for MethodGroupExprs anymore, they're now
9487 2002-08-08 Martin Baulig <martin@gnome.org>
9489 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
9490 Family, FamANDAssem and FamORAssem permissions.
9491 (TypeManager.IsSubclassOrNestedChildOf): New public method.
9493 2002-08-08 Martin Baulig <martin@gnome.org>
9495 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
9496 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
9499 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
9501 * driver.cs: implemented /resource option to embed managed resources.
9503 2002-08-07 Martin Baulig <martin@gnome.org>
9505 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
9506 (FieldBase.HasFieldInitializer): New public property.
9507 (FieldBase.GetInitializerExpression): New public method. Resolves and
9508 returns the field initializer and makes sure it is only resolved once.
9509 (TypeContainer.EmitFieldInitializers): Call
9510 FieldBase.GetInitializerExpression to get the initializer, this ensures
9511 that it isn't resolved multiple times.
9513 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
9514 the resolving process (SimpleName/MemberLookup) that we're currently
9515 emitting a field initializer (which must not access any instance members,
9516 this is an error CS0236).
9518 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
9519 argument, if the `IsFieldInitializer' flag is set, we must report and
9520 error CS0236 and not an error CS0120.
9522 2002-08-07 Martin Baulig <martin@gnome.org>
9524 * ecore.cs (IMemberExpr): New public interface.
9525 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
9526 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
9527 if the expression is an IMemberExpr.
9529 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
9530 to be null, implicitly default to `this' if we're non-static in
9531 this case. Simplified the code a lot by using the new IMemberExpr
9532 interface. Also fixed bug #28176 here.
9534 2002-08-06 Martin Baulig <martin@gnome.org>
9536 * cs-parser.jay (SimpleLookup): Removed. We need to create
9537 ParameterReferences during semantic analysis so that we can do a
9538 type-only search when resolving Cast, TypeOf and SizeOf.
9539 (block): Pass the `current_local_parameters' to the Block's
9542 * class.cs (ConstructorInitializer): Added `Parameters parameters'
9543 argument to the constructor.
9544 (ConstructorInitializer.Resolve): Create a temporary implicit
9545 block with the parameters.
9547 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
9548 references here if we aren't doing a type-only search.
9550 * statement.cs (Block): Added constructor which takes a
9551 `Parameters parameters' argument.
9552 (Block.Parameters): New public property.
9554 * support.cs (InternalParameters.Parameters): Renamed `parameters'
9555 to `Parameters' and made it public readonly.
9557 2002-08-06 Martin Baulig <martin@gnome.org>
9559 * ecore.cs (Expression.Warning): Made this public as well.
9561 * report.cs (Report.Debug): Print the contents of collections.
9563 2002-08-06 Martin Baulig <martin@gnome.org>
9565 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
9566 used to tell Resolve() which kinds of expressions it may return.
9567 (Expression.Resolve): Added overloaded version of this method which
9568 takes a `ResolveFlags flags' argument. This can be used to tell
9569 Resolve() which kinds of expressions it may return. Reports a
9571 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
9572 ResolveFlags.SimpleName.
9573 (Expression.Error118): Added overloaded version of this method which
9574 takes a `ResolveFlags flags' argument. It uses the flags to determine
9575 which kinds of expressions are allowed.
9577 * expression.cs (Argument.ResolveMethodGroup): New public method.
9578 Resolves an argument, but allows a MethodGroup to be returned.
9579 This is used when invoking a delegate.
9581 * TODO: Updated a bit.
9583 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9585 Fixed compilation with csc.
9587 * ecore.cs: Expression.Error made public. Is this correct? Should
9588 Warning be made public too?
9590 * expression.cs: use ea.Location instead of ea.loc.
9591 [FIXME: Filed as bug #28607: MCS must report these errors.]
9593 2002-08-06 Martin Baulig <martin@gnome.org>
9595 * ecore.cs (Expression.loc): Moved the location here instead of
9596 duplicating it in all derived classes.
9597 (Expression.Location): New public property.
9598 (Expression.Error, Expression.Warning): Made them non-static and
9599 removed the location argument.
9600 (Expression.Warning): Added overloaded version which takes an
9601 `int level' argument.
9602 (Expression.Error118): Make this non-static and removed the
9603 expression and location arguments.
9604 (TypeExpr): Added location argument to the constructor.
9606 * expression.cs (StaticCallExpr): Added location argument to
9608 (Indirection, PointerArithmetic): Likewise.
9609 (CheckedExpr, UnCheckedExpr): Likewise.
9610 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
9611 (StringPtr): Likewise.
9614 2002-08-05 Martin Baulig <martin@gnome.org>
9616 * expression.cs (BaseAccess.DoResolve): Actually report errors.
9618 * assign.cs (Assign.DoResolve): Check whether the source
9619 expression is a value or variable.
9621 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
9622 while resolving the corresponding blocks.
9624 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
9625 an error, don't silently return null.
9627 * statement.cs (Block.AddVariable): Do the error reporting here
9628 and distinguish between CS0128 and CS0136.
9629 (Block.DoResolve): Report all unused labels (warning CS0164).
9630 (LabeledStatement): Pass the location to the constructor.
9631 (LabeledStatement.HasBeenReferenced): New property.
9632 (LabeledStatement.Resolve): Set it to true here.
9634 * statement.cs (Return.Emit): Return success even after reporting
9635 a type mismatch error (CS0126 or CS0127), this is what csc does and
9636 it avoids confusing the users with any consecutive errors.
9638 2002-08-05 Martin Baulig <martin@gnome.org>
9640 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
9642 * const.cs (Const.LookupConstantValue): Catch circular definitions.
9644 * expression.cs (MemberAccess.DoResolve): Silently return if an
9645 error has already been reported.
9647 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
9648 error has already been reported.
9650 2002-08-05 Martin Baulig <martin@gnome.org>
9652 * statement.cs (UsageVector): Only initialize the `parameters'
9653 vector if we actually have any "out" parameters.
9655 2002-08-05 Martin Baulig <martin@gnome.org>
9657 * expression.cs (Binary.ResolveOperator): When combining delegates,
9658 they must have the same type.
9660 2002-08-05 Martin Baulig <martin@gnome.org>
9662 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
9663 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
9664 work with the ms runtime and we also don't need it: if we're a
9665 PropertyBuilder and not in the `indexer_arguments' hash, then we
9666 are a property and not an indexer.
9668 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
9669 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
9670 since the latter one doesn't work with the ms runtime.
9672 2002-08-03 Martin Baulig <martin@gnome.org>
9674 Fixed bugs #27998 and #22735.
9676 * class.cs (Method.IsOperator): New public field.
9677 (Method.CheckBase): Report CS0111 if there's already a method
9678 with the same parameters in the current class. Report CS0508 when
9679 attempting to change the return type of an inherited method.
9680 (MethodData.Emit): Report CS0179 if a method doesn't have a body
9681 and it's not marked abstract or extern.
9682 (PropertyBase): New abstract base class for Property and Indexer.
9683 (PropertyBase.CheckBase): Moved here from Property and made it work
9685 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
9686 the same so we can reuse it there.
9687 (Property, Indexer): Derive from PropertyBase.
9688 (MethodSignature.inheritable_property_signature_filter): New delegate
9689 to find properties and indexers.
9691 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
9692 argument and improved error reporting.
9694 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
9695 EmptyReadOnlyParameters and made it a property.
9697 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
9698 version of this method which takes a `PropertyInfo indexer'.
9699 (TypeManager.RegisterIndexer): New method.
9701 * class.cs: Added myself as author of this file :-)
9703 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9705 * class.cs: fixed compilation on windoze.
9707 2002-08-03 Martin Baulig <martin@gnome.org>
9709 * interface.cs (Interface.GetInterfaceBases): Check whether all
9710 base interfaces are at least as accessible than the current one.
9712 * class.cs (TypeContainer.GetClassBases): Check whether base types
9713 are at least as accessible than the current type.
9714 (TypeContainer.AsAccessible): Implemented and made non-static.
9715 (MemberBase.CheckParameters): Report errors if the accessibility
9718 * delegate.cs (Delegate.Delegate): The default visibility is
9719 internal for top-level types and private for nested types.
9720 (Delegate.Define): Report errors if the accessibility checks fail.
9722 * enum.cs (Enum.Enum): The default visibility is internal for
9723 top-level types and private for nested types.
9724 (Enum.DefineType): Compute the correct visibility.
9726 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
9727 function which takes a `bool is_toplevel' instead of a TypeContainer.
9729 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
9732 2002-08-02 Martin Baulig <martin@gnome.org>
9734 * expression.cs (LocalVariableReferenc): Added constructor which
9735 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
9736 (LocalVariableReference.IsReadOnly): New property.
9737 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
9738 variable is readonly, use our own readonly flag to do this; you can
9739 use the new constructor to get a writable reference to a read-only
9742 * cs-parser.jay (foreach_statement, using_statement): Get a writable
9743 reference to the local variable.
9745 2002-08-01 Miguel de Icaza <miguel@ximian.com>
9747 * rootcontext.cs (ResolveCore): Also include System.Exception
9749 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
9750 we reach an EmptyStatement.
9752 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
9755 * expression.cs (Binary.ResolveOperator): Check error result in
9758 use brtrue/brfalse directly and avoid compares to null.
9760 2002-08-02 Martin Baulig <martin@gnome.org>
9762 * class.cs (TypeContainer.Define): Define all nested interfaces here.
9763 Fixes bug #28407, added test-155.cs.
9765 2002-08-01 Martin Baulig <martin@gnome.org>
9767 * class.cs (Event.EmitDefaultMethod): Make this work with static
9768 events. Fixes #28311, added verify-3.cs.
9770 2002-08-01 Martin Baulig <martin@gnome.org>
9772 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
9773 `is_disposable' fields.
9774 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
9775 `hm.is_disposable' if we're using the collection pattern.
9776 (Foreach.EmitCollectionForeach): Use the correct type for the
9777 enumerator's local variable, only emit the try/finally block if
9778 necessary (fixes #27713).
9780 2002-08-01 Martin Baulig <martin@gnome.org>
9782 * ecore.cs (Expression.report118): Renamed to Error118 and made
9785 * statement.cs (Throw.Resolve): Check whether the expression is of
9786 the correct type (CS0118) and whether the type derives from
9787 System.Exception (CS0155).
9788 (Catch.Resolve): New method. Do the type lookup here and check
9789 whether it derives from System.Exception (CS0155).
9790 (Catch.CatchType, Catch.IsGeneral): New public properties.
9792 * typemanager.cs (TypeManager.exception_type): Added.
9794 2002-07-31 Miguel de Icaza <miguel@ximian.com>
9796 * driver.cs: Updated About function.
9798 2002-07-31 Martin Baulig <martin@gnome.org>
9800 Implemented Control Flow Analysis.
9802 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
9803 (EmitContext.CurrentBranching): Added.
9804 (EmitContext.StartFlowBranching): Added.
9805 (EmitContext.EndFlowBranching): Added.
9806 (EmitContext.KillFlowBranching): Added.
9807 (EmitContext.IsVariableAssigned): Added.
9808 (EmitContext.SetVariableAssigned): Added.
9809 (EmitContext.IsParameterAssigned): Added.
9810 (EmitContext.SetParameterAssigned): Added.
9811 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
9812 Added control flow analysis stuff here.
9814 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
9815 resolve the expression as lvalue.
9816 (LocalVariableReference.DoResolve): Check whether the variable has
9817 already been assigned.
9818 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
9819 the parameter as assigned here.
9820 (ParameterReference.DoResolve): Check whether the parameter has already
9822 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
9823 expression as lvalue.
9825 * statement.cs (FlowBranching): New class for the flow analysis code.
9826 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
9827 (LabeledStatement.IsDefined): New public property.
9828 (LabeledStatement.AddUsageVector): New public method to tell flow
9829 analyis that the label may be reached via a forward jump.
9830 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
9832 (VariableInfo.Number): New public field. This is used by flow analysis
9833 to number all locals of a block.
9834 (Block.CountVariables): New public property. This is the number of
9835 local variables in this block (including the locals from all parent
9837 (Block.EmitMeta): Number all the variables.
9839 * statement.cs: Added flow analysis support to all classes.
9841 2002-07-31 Martin Baulig <martin@gnome.org>
9843 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
9844 To get debugging messages, compile mcs with /define:MCS_DEBUG and
9845 then use this argument.
9847 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
9849 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
9850 use this to specify /define options.
9852 2002-07-29 Martin Baulig <martin@gnome.org>
9854 * statement.cs (Fixed): Moved all code that does variable lookups
9855 and resolvings from Emit to Resolve.
9857 * statement.cs (For): Moved all code that does variable lookups
9858 and resolvings from Emit to Resolve.
9860 * statement.cs (Using): Moved all code that does variable lookups
9861 and resolvings from Emit to Resolve.
9863 2002-07-29 Martin Baulig <martin@gnome.org>
9865 * attribute.cs (Attribute.Resolve): Explicitly catch a
9866 System.NullReferenceException when creating the
9867 CustromAttributeBuilder and report a different warning message.
9869 2002-07-29 Martin Baulig <martin@gnome.org>
9871 * support.cs (ParameterData.ParameterName): Added method to
9872 get the name of a parameter.
9874 * typemanager.cs (TypeManager.IsValueType): New public method.
9876 2002-07-29 Martin Baulig <martin@gnome.org>
9878 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
9879 is a flag which specifies that it's either ref or out.
9880 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
9881 the out parameter to `out Parameter.Modifier mod', also set the
9882 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
9884 * support.cs (InternalParameters.ParameterModifier): Distinguish
9885 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
9886 Parameter.Modifier.ISBYREF flag if it's either ref or out.
9888 * expression.cs (Argument.GetParameterModifier): Distinguish
9889 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
9890 Parameter.Modifier.ISBYREF flag if it's either ref or out.
9892 2002-07-29 Martin Baulig <martin@gnome.org>
9894 * expression.cs (ParameterReference.ParameterReference): Added
9895 `Location loc' argument to the constructor.
9897 * cs-parser.jay: Pass location to ParameterReference.
9899 2002-07-28 Miguel de Icaza <miguel@ximian.com>
9901 * statement.cs (Try): Initialize the location.
9903 * cs-parser.jay: pass location to Try.
9905 * expression.cs (Unary.Reduce): Change the prototype to return
9906 whether a constant fold could be performed or not. The result is
9907 returned in an out parameters. In the case of Indirection and
9908 AddressOf, we want to perform the full tests.
9910 2002-07-26 Miguel de Icaza <miguel@ximian.com>
9912 * statement.cs (Statement.Emit): Flag dead code.
9914 2002-07-27 Andrew Birkett <andy@nobugs.org>
9916 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
9918 2002-07-27 Martin Baulig <martin@gnome.org>
9920 * class.cs (MethodData.Define): Put back call to
9921 TypeManager.AddMethod(), accidentally commented this out.
9923 * report.cs (Debug): New public method to print debugging information,
9924 this is `[Conditional ("DEBUG")]'.
9926 2002-07-26 Martin Baulig <martin@gnome.org>
9928 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
9929 (switch_statement): Push the current_block to the switch_stack and
9930 pop it again when we're done with the switch.
9931 (switch_section): The new block is a child of the current_block.
9932 Fixes bug #24007, added test-152.cs.
9934 2002-07-27 Martin Baulig <martin@gnome.org>
9936 * expression.cs (Invocation.EmitArguments): When calling a varargs
9937 function with only its fixed arguments, we need to pass an empty
9940 2002-07-27 Martin Baulig <martin@gnome.org>
9942 Mono 0.13 has been released.
9944 2002-07-25 Miguel de Icaza <miguel@ximian.com>
9946 * driver.cs: Rename --resource to --linkres, because that is what
9947 we do currently, we dont support --resource yet.
9949 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
9951 2002-07-25 Martin Baulig <martin@gnome.org>
9953 * class.cs (MethodData): New public class. This is a `method builder'
9954 class for a method or one accessor of a Property/Indexer/Event.
9955 (MethodData.GetMethodFlags): Moved here from MemberBase.
9956 (MethodData.ApplyAttributes): Likewise.
9957 (MethodData.ApplyObsoleteAttribute): Likewise.
9958 (MethodData.ApplyConditionalAttribute): Likewise.
9959 (MethodData.ApplyDllImportAttribute): Likewise.
9960 (MethodData.CheckAbstractAndExternal): Likewise.
9961 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
9962 (MethodData.Emit): Formerly known as Method.Emit().
9963 (MemberBase): Moved everything which was specific to a single
9964 accessor/method to MethodData.
9965 (Method): Create a new MethodData and call Define() and Emit() on it.
9966 (Property, Indexer, Event): Create a new MethodData objects for each
9967 accessor and call Define() and Emit() on them.
9969 2002-07-25 Martin Baulig <martin@gnome.org>
9971 Made MethodCore derive from MemberBase to reuse the code from there.
9972 MemberBase now also checks for attributes.
9974 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
9975 (MemberBase.GetMethodFlags): Moved here from class Method and marked
9977 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
9978 `CallingConventions cc' and `Attributes opt_attrs' arguments.
9979 (MemberBase.ApplyAttributes): New virtual method; applies the
9980 attributes to a method or accessor.
9981 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
9982 (MemberBase.ApplyConditionalAttribute): Likewise.
9983 (MemberBase.ApplyDllImportAttribute): Likewise.
9984 (MemberBase.CheckAbstractAndExternal): Likewise.
9985 (MethodCore.ParameterTypes): This is now a property instead of a
9986 method, it's initialized from DoDefineParameters().
9987 (MethodCore.ParameterInfo): Removed the set accessor.
9988 (MethodCore.DoDefineParameters): New protected virtual method to
9989 initialize ParameterTypes and ParameterInfo.
9990 (Method.GetReturnType): We can now simply return the MemberType.
9991 (Method.GetMethodFlags): Override the MemberBase version and add
9992 the conditional flags.
9993 (Method.CheckBase): Moved some code from Define() here, call
9994 DoDefineParameters() here.
9995 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
9996 here to avoid some larger code duplication.
9997 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
9998 ensure that abstract and external accessors don't declare a body.
10000 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
10001 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
10002 lookup in the attribute's parent classes, so we need to abort as soon
10003 as we found the first match.
10004 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
10005 the attribute has no arguments.
10007 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
10010 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10012 * cs-parser.jay: reverted previous patch.
10014 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10016 * cs-parser.jay: fixed bug #22119.
10018 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10020 * attribute.cs: fixed compilation. The error was:
10021 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
10022 be assigned to before control leaves the current method."
10023 [FIXME: Filed as bug #28186: MCS must report this error.]
10025 2002-07-25 Martin Baulig <martin@gnome.org>
10027 * attribute.cs (Attribute.Conditional_GetConditionName): New static
10028 method to pull the condition name ouf of a Conditional attribute.
10029 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
10030 the obsolete message and error flag out of an Obsolete attribute.
10032 * class.cs (Method.GetMethodFlags): New public method to get the
10033 TypeManager.MethodFlags for this method.
10034 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
10036 (Method.Define): Get and apply the Obsolete and Conditional attributes;
10037 if we're overriding a virtual function, set the new private variable
10038 `parent_method'; call the new TypeManager.AddMethod().
10040 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
10041 the MethodBuilder and the Method in a PtrHashtable.
10042 (TypeManager.builder_to_method): Added for this purpose.
10043 (TypeManager.MethodFlags): Added IsObsoleteError.
10044 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
10045 Obsolete and Conditional arguments in MethodBuilders. If we discover
10046 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
10047 the message from the attribute.
10049 2002-07-24 Martin Baulig <martin@gnome.org>
10051 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
10052 preprocessor directives, ensure that the argument to #define/#undef is
10053 exactly one identifier and that it's actually an identifier.
10055 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
10058 2002-07-24 Martin Baulig <martin@gnome.org>
10060 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
10061 initialize it to TypeManager.object_type in the constructor.
10062 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
10063 of the `hm.get_current' method if we're using the collection pattern.
10064 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
10065 for the explicit conversion to make it work when we're using the collection
10066 pattern and the `Current' property has a different return type than `object'.
10069 2002-07-24 Martin Baulig <martin@gnome.org>
10071 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
10072 does not match, but don't report any errors. This method is called in
10073 order for all methods in a MethodGroupExpr until a matching method is
10074 found, so we don't want to bail out if the first method doesn't match.
10075 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
10076 matches, report the 123. Fixes #28070.
10078 2002-07-24 Martin Baulig <martin@gnome.org>
10080 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
10081 TypeManager.TypeToCoreType() to the top of the method so the
10082 following equality checks will work. Fixes #28107.
10084 2002-07-24 Martin Baulig <martin@gnome.org>
10086 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
10087 operand is of type uint, and the other operand is of type sbyte,
10088 short or int, the operands are converted to type long." -
10089 Actually do what this comment already told us. Fixes bug #28106,
10092 2002-07-24 Martin Baulig <martin@gnome.org>
10094 * class.cs (MethodBase): New abstract class. This is now a base
10095 class for Property, Indexer and Event to avoid some code duplication
10096 in their Define() and DefineMethods() methods.
10097 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
10098 generic methods for Define() and DefineMethods().
10099 (FieldBase): Derive from MemberBase, not MemberCore.
10100 (Property): Derive from MemberBase, not MemberCore.
10101 (Property.DefineMethod): Moved all the code from this method to the
10102 new MethodBase.DefineAccessor(), just call it with appropriate
10104 (Property.Define): Call the new Property.DoDefine(), this does some
10105 sanity checks and we don't need to duplicate the code everywhere.
10106 (Event): Derive from MemberBase, not MemberCore.
10107 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
10108 accessors, this will also make them work with interface events.
10109 (Indexer): Derive from MemberBase, not MemberCore.
10110 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
10111 (Indexer.Define): Use the new MethodBase functions.
10113 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
10114 argument to the constructor.
10115 (Interface.FindMembers): Added support for interface events.
10116 (Interface.PopluateEvent): Implemented.
10118 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
10120 2002-07-22 Miguel de Icaza <miguel@ximian.com>
10122 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
10123 but this is required to check for a method name being the same as
10124 the containing class.
10128 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10130 * interface.cs: initialize variable.
10132 2002-07-23 Martin Baulig <martin@gnome.org>
10134 Implemented the IndexerName attribute in interfaces.
10136 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
10137 name if this is an explicit interface implementation.
10138 (Indexer.InterfaceIndexerName): New public variable. If we're
10139 implementing an interface indexer, this is the IndexerName in that
10140 interface. Otherwise, it's the IndexerName.
10141 (Indexer.DefineMethod): If we're implementing interface indexer,
10142 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
10143 and Pending.ImplementIndexer methods.
10144 (Indexer.Define): Also define the PropertyBuilder if we're
10145 implementing an interface indexer and this is neither an explicit
10146 interface implementation nor do the IndexerName match the one in
10149 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
10150 If a method is defined here, then we always need to create a proxy
10151 for it. This is used when implementing interface indexers.
10152 (Pending.IsInterfaceIndexer): New public method.
10153 (Pending.ImplementIndexer): New public method.
10154 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
10155 This is used when implementing interface indexers to define a proxy
10157 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
10158 define a proxy if necessary.
10160 * interface.cs (Interface.IndexerName): New public variable.
10161 (Interface.PopulateIndexer): Set the IndexerName.
10162 (Interface.DefineIndexers): New private method. Populate all the
10163 indexers and make sure their IndexerNames match.
10165 * typemanager.cs (IndexerPropertyName): Added support for interface
10168 2002-07-22 Martin Baulig <martin@gnome.org>
10170 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
10171 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
10172 ret if HasReturnLabel.
10173 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
10176 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
10177 and set the ec.LoopBeginTryCatchLevel.
10178 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
10179 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
10180 the current ec.TryCatchLevel, the branch goes out of an exception
10181 block. In this case, we need to use Leave and not Br.
10183 2002-07-22 Martin Baulig <martin@gnome.org>
10185 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
10186 block unless the block does not always return or it is contained in
10187 another try { ... } catch { ... } block. Fixes bug #26506.
10188 Added verify-1.cs to the test suite.
10190 2002-07-22 Martin Baulig <martin@gnome.org>
10192 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
10193 then we do not always return. Fixes bug #24985.
10195 2002-07-22 Martin Baulig <martin@gnome.org>
10197 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
10198 lookup on a per-class level; ie. walk up the class hierarchy until we
10199 found at least one applicable method, then choose the best among them.
10200 Fixes bug #24463 and test-29.cs.
10202 2002-07-22 Martin Baulig <martin@gnome.org>
10204 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
10205 return types of the methods. The return type is not part of the
10206 signature and we must not check it to make the `new' modifier work.
10207 Fixes bug #27999, also added test-147.cs.
10208 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
10210 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
10211 on the method's return type.
10213 2002-07-21 Martin Baulig <martin@gnome.org>
10215 * assign.cs: Make this work if the rightmost source is a constant and
10216 we need to do an implicit type conversion. Also adding a few more tests
10217 to test-38.cs which should have caught this.
10219 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
10220 target in the makefile for this. The makefile.gnu is primarily intended
10221 for end-users who don't want to debug the compiler.
10223 2002-07-21 Martin Baulig <martin@gnome.org>
10225 * assign.cs: Improved the Assign class so it can now handle embedded
10226 assignments (X = Y = Z = something). As a side-effect this'll now also
10227 consume less local variables. test-38.cs now passes with MCS, added
10228 a few new test cases to that test.
10230 2002-07-20 Martin Baulig <martin@gnome.org>
10232 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
10233 instructions. Fixes bug #27977, also added test-146.cs.
10235 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10237 * cs-tokenizer.cs: fixed getHex ().
10239 2002-07-19 Martin Baulig <martin@gnome.org>
10241 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
10242 not Type.GetType() to lookup the array type. This is needed when
10243 we're constructing an array of a user-defined type.
10244 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
10245 single-dimensional arrays, but also for single-dimensial arrays of
10248 2002-07-19 Martin Baulig <martin@gnome.org>
10250 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
10251 this function is called, it's not allowed to share LocalBuilders
10252 among ILGenerators.
10254 2002-07-19 Martin Baulig <martin@gnome.org>
10256 * expression.cs (Argument.Resolve): Report an error 118 when trying
10257 to pass a type as argument.
10259 2002-07-18 Martin Baulig <martin@gnome.org>
10261 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
10262 Conv_R_Un for the signed `long' type.
10264 2002-07-15 Miguel de Icaza <miguel@ximian.com>
10266 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
10267 `expr' for the temporary result, as that will fail if we do
10268 multiple resolves on the same expression.
10270 2002-07-05 Miguel de Icaza <miguel@ximian.com>
10272 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
10273 ec.TypeContainer for looking up aliases.
10275 * class.cs (TypeContainer): Remove LookupAlias from here.
10277 * decl.cs (DeclSpace); Move here.
10279 2002-07-01 Miguel de Icaza <miguel@ximian.com>
10281 * class.cs (FindMembers): Only call filter if the constructor
10282 bulider is not null.
10284 Also handle delegates in `NestedTypes' now. Now we will perform
10285 type lookups using the standard resolution process. This also
10288 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
10289 This uses Expressions (the limited kind that can be parsed by the
10290 tree) instead of strings.
10292 * expression.cs (ComposedCast.ToString): Implement, used to flag
10293 errors since now we have to render expressions.
10295 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
10298 * ecore.cs (SimpleName.ToString): ditto.
10300 * cs-parser.jay: Instead of using strings to assemble types, use
10301 Expressions to assemble the type (using SimpleName, ComposedCast,
10302 MemberAccess). This should fix the type lookups in declarations,
10303 because we were using a different code path for this.
10305 * statement.cs (Block.Resolve): Continue processing statements
10306 even when there is an error.
10308 2002-07-17 Miguel de Icaza <miguel@ximian.com>
10310 * class.cs (Event.Define): Also remove the `remove' method from
10311 the list of pending items.
10313 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
10314 generate more compact code.
10316 2002-07-17 Martin Baulig <martin@gnome.org>
10318 * const.cs (Const.LookupConstantValue): Add support for constant
10319 `unchecked' and `checked' expressions.
10320 Also adding test case test-140.cs for this.
10322 2002-07-17 Martin Baulig <martin@gnome.org>
10324 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
10325 check whether mi.ReturnType implements the IEnumerator interface; the
10326 `==' and the IsAssignableFrom() will fail in this situation.
10328 2002-07-16 Ravi Pratap <ravi@ximian.com>
10330 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
10333 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10335 * expression.cs: fixed bug #27811.
10337 2002-07-14 Miguel de Icaza <miguel@ximian.com>
10339 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
10340 Molaro: when we are a ref, the value already contains a pointer
10341 value, do not take the address of it.
10343 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
10344 * removed mb-parser.jay and mb-tokenizer.cs
10346 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
10348 * expression.cs: check against the building corlib void type.
10350 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
10352 * ecore.cs: fix for valuetype static readonly fields: when
10353 initializing them, we need their address, not the address of a copy.
10355 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
10357 * typemanager.cs: register also enum_type in corlib.
10359 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
10361 * class.cs: allow calling this (but not base) initializers in structs.
10363 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
10365 * ecore.cs: make sure we compare against the building base types
10368 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
10370 * typemanager.cs: fix TypeToCoreType() to handle void and object
10371 (corlib gets no more typerefs after this change).
10373 2002-07-12 Miguel de Icaza <miguel@ximian.com>
10375 * expression.cs (ArrayCreation.EmitArrayArguments): use
10376 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
10378 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
10379 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
10380 array indexes, the runtime actually forbids them.
10382 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
10383 for array arguments here.
10385 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
10386 instead of the default for ValueTypes.
10388 (New.DoEmit): Use IsValueType instead of
10389 IsSubclassOf (value_type)
10390 (New.DoResolve): ditto.
10391 (Invocation.EmitCall): ditto.
10393 * assign.cs (Assign): ditto.
10395 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
10396 Statements *are* currently doing part of their resolution during
10399 Expressions do always resolve during resolve, but statements are
10400 only required to propagate resolution to their children.
10402 2002-07-11 Miguel de Icaza <miguel@ximian.com>
10404 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
10406 (LoadAssembly): Do not add the dll if it is already specified
10408 (MainDriver): Add the System directory to the link path at the end,
10409 after all the other -L arguments.
10411 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
10412 wrong opcode for loading bytes and bools (ldelem.i1 instead of
10413 ldelem.u1) and using the opposite for sbytes.
10415 This fixes Digger, and we can finally run it.
10417 * driver.cs (UnixParseOption): Move the option parsing here.
10418 (CSCParseOption): Implement CSC-like parsing of options.
10420 We now support both modes of operation, the old Unix way, and the
10421 new CSC-like way. This should help those who wanted to make cross
10422 platform makefiles.
10424 The only thing broken is that /r:, /reference: and /lib: are not
10425 implemented, because I want to make those have the same semantics
10426 as the CSC compiler has, and kill once and for all the confussion
10427 around this. Will be doing this tomorrow.
10429 * statement.cs (Unsafe.Resolve): The state is checked during
10430 resolve, not emit, so we have to set the flags for IsUnsfe here.
10432 2002-07-10 Miguel de Icaza <miguel@ximian.com>
10434 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
10435 not catch the Error_ObjectRefRequired in SimpleName (as it is
10436 possible to have a class/instance variable name that later gets
10437 deambiguated), we have to check this here.
10439 2002-07-10 Ravi Pratap <ravi@ximian.com>
10441 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
10442 make static and put into Expression.
10444 (Event.Define): Register the private field of the event with the
10445 TypeManager so that GetFieldFromEvent can get at it.
10447 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
10448 keep track of the private field associated with an event which
10451 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
10454 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
10456 2002-07-10 Miguel de Icaza <miguel@ximian.com>
10458 * expression.cs (Binary.EmitBranchable): this routine emits the
10459 Binary expression in a branchable context. This basically means:
10460 we need to branch somewhere, not just get the value on the stack.
10462 This works together with Statement.EmitBoolExpression.
10464 * statement.cs (Statement.EmitBoolExpression): Use
10467 2002-07-09 Miguel de Icaza <miguel@ximian.com>
10469 * statement.cs (For): Reduce the number of jumps in loops.
10471 (For): Implement loop inversion for the For statement.
10473 (Break): We can be breaking out of a Try/Catch controlled section
10474 (foreach might have an implicit try/catch clause), so we need to
10475 use Leave instead of Br.
10477 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
10478 now). If the instace expression supports IMemoryLocation, we use
10479 the AddressOf method from the IMemoryLocation to extract the
10480 address instead of emitting the instance.
10482 This showed up with `This', as we were emitting the instance
10483 always (Emit) instead of the Address of This. Particularly
10484 interesting when This is a value type, as we dont want the Emit
10485 effect (which was to load the object).
10487 2002-07-08 Miguel de Icaza <miguel@ximian.com>
10489 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
10491 * statement.cs (Checked): Set the CheckedState during the resolve
10492 process too, as the ConvCast operations track the checked state on
10493 the resolve process, and not emit.
10495 * cs-parser.jay (namespace_member_declaration): Flag that we have
10496 found a declaration when we do. This is used to flag error 1529
10498 * driver.cs: Report ok when we display the help only.
10500 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
10502 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
10504 2002-07-04 Miguel de Icaza <miguel@ximian.com>
10506 * cs-tokenizer.cs (define): We also have to track locally the
10507 defines. AllDefines is just used for the Conditional Attribute,
10508 but we also need the local defines for the current source code.
10510 2002-07-03 Miguel de Icaza <miguel@ximian.com>
10512 * statement.cs (While, For, Do): These loops can exit through a
10513 Break statement, use this information to tell whether the
10514 statement is the last piece of code.
10516 (Break): Flag that we break.
10518 * codegen.cs (EmitContexts): New `Breaks' state variable.
10520 2002-07-03 Martin Baulig <martin@gnome.org>
10522 * class.cs (TypeContainer.MethodModifiersValid): Allow override
10523 modifiers in method declarations in structs. Otherwise, you won't
10524 be able to override things like Object.Equals().
10526 2002-07-02 Miguel de Icaza <miguel@ximian.com>
10528 * class.cs (Method, Property, Indexer): Do not allow the public
10529 modifier to be used in explicit interface implementations.
10531 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
10532 override modifiers in method declarations in structs
10534 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
10536 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
10537 integer or real overflow, report an error
10539 2002-07-02 Martin Baulig <martin@gnome.org>
10541 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
10542 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
10543 to tell the runtime about our newly created System.Object and
10544 System.ValueType types.
10546 2002-07-02 Miguel de Icaza <miguel@ximian.com>
10548 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
10549 struct instead of Ldarg/Starg.
10551 2002-07-02 Martin Baulig <martin@gnome.org>
10553 * expression.cs (Indirection.Indirection): Call
10554 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
10556 2002-07-02 Martin Baulig <martin@gnome.org>
10558 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
10559 ValueType, call TypeManager.TypeToCoreType() on it.
10560 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
10561 the OpCodes.Newarr argument.
10563 2002-07-02 Martin Baulig <martin@gnome.org>
10565 * expression.cs (Invocation.EmitCall): When compiling corlib,
10566 replace all calls to the system's System.Array type to calls to
10567 the newly created one.
10569 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
10570 System.Array methods.
10571 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
10572 from the system's System.Array type which must be replaced.
10574 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
10576 * typemanager.cs: load unverifiable_code_ctor so we can build
10577 corlib using the correct type. Avoid using GetTypeCode() with
10579 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
10580 TypeManager.object_type to allow building corlib.
10582 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
10584 * ecore.cs: handle System.Enum separately in LoadFromPtr().
10586 2002-07-01 Martin Baulig <martin@gnome.org>
10588 * class.cs: Make the last change actually work, we need to check
10589 whether `ifaces != null' to avoid a crash.
10591 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
10593 * class.cs: when we build structs without fields that implement
10594 interfaces, we need to add the interfaces separately, since there is
10595 no API to both set the size and add the interfaces at type creation
10598 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
10600 * expression.cs: the dimension arguments to the array constructors
10601 need to be converted if they are a long.
10603 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
10605 * class.cs: don't emit ldarg.0 if there is no parent constructor
10606 (fixes showstopper for corlib).
10608 2002-06-29 Martin Baulig <martin@gnome.org>
10610 MCS now compiles corlib on GNU/Linux :-)
10612 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
10613 ie. check for MethodImplOptions.InternalCall.
10615 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
10616 and TypeManager.attribute_type are null, so we must explicitly check
10617 whether parent is not null to find out whether it's an attribute type.
10618 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
10619 and SetBuilder, not only if the property is neither abstract nor external.
10620 This is necessary to set the MethodImplOptions on the accessor methods.
10621 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
10622 SetBuilder, see Property.Emit().
10624 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
10625 populate "System.Object", "System.ValueType" and "System.Attribute" since
10626 they've already been populated from BootCorlib_PopulateCoreTypes().
10628 2002-06-29 Martin Baulig <martin@gnome.org>
10630 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
10631 is the NullLiteral, we also need to make sure that target_type is not
10634 2002-06-29 Martin Baulig <martin@gnome.org>
10636 * rootcontext.cs (RootContext.ResolveCore): We must initialize
10637 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
10638 before calling BootstrapCorlib_ResolveDelegate ().
10640 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10642 * statement.cs: fixed build-breaker. All tests passed ok.
10644 2002-06-27 Martin Baulig <martin@gnome.org>
10646 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
10647 for System.Decimal when compiling corlib.
10649 2002-06-27 Martin Baulig <martin@gnome.org>
10651 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
10652 switch blocks which contain nothing but a default clause.
10654 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
10656 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
10658 2002-06-27 Martin Baulig <martin@gnome.org>
10660 * ecore.cs (PropertyExpr.PropertyExpr): Call
10661 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
10663 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
10664 is already a TypeBuilder.
10666 2002-06-27 Martin Baulig <martin@gnome.org>
10668 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
10669 `target_type == TypeManager.array_type', not IsAssignableFrom() in
10670 the "from an array-type to System.Array" case. This makes it work
10671 when compiling corlib.
10673 2002-06-27 Martin Baulig <martin@gnome.org>
10675 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
10676 non-static PropertyExpr, set its InstanceExpression. This makes
10677 the `ICollection.Count' property work in System/Array.cs.
10679 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
10681 * driver.cs: Made error handling more consistent. Errors now
10682 tracked by Report class, so many methods which used to return int
10683 now return void. Main() now prints success/failure and
10684 errors/warnings message.
10686 Renamed '--probe' compiler argument to '--expect-error'. Removed
10687 the magic number return values (123 and 124). Now, if the
10688 expected error occurs, the compiler exits with success (exit value
10689 0). If the compilation completes without seeing that particular
10690 error, the compiler exits with failure (exit value 1). The
10691 makefile in mcs/errors has been changed to handle the new behaviour.
10693 * report.cs: Made 'expected error' number a property and renamed
10694 it from 'Probe' to 'ExpectedError'.
10696 * genericparser.cs: Removed error handling support, since it is
10697 now all done by Report class.
10699 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
10700 class, so parse() no longer returns an int.
10702 * namespace.cs: Use Report.Error instead of GenericParser.error
10704 2002-06-22 Miguel de Icaza <miguel@ximian.com>
10706 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
10707 TypeContainer.AddOperator): At the front of the list put the
10708 explicit implementations, so they get resolved/defined first.
10710 2002-06-21 Miguel de Icaza <miguel@ximian.com>
10712 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
10713 interface type is implemented by this TypeContainer. Used during
10714 explicit interface implementation.
10716 (Property.Define, Indexer.Define, Method.Define): Validate that
10717 the given interface in the explicit implementation is one of the
10718 base classes for the containing type.
10720 Also if we are explicitly implementing an interface, but there is
10721 no match in the pending implementation table, report an error.
10723 (Property.Define): Only define the property if we are
10724 not explicitly implementing a property from an interface. Use the
10725 correct name also for those properties (the same CSC uses,
10726 although that is really not needed).
10728 (Property.Emit): Do not emit attributes for explicitly implemented
10729 properties, as there is no TypeBuilder.
10731 (Indexer.Emit): ditto.
10733 Hiding then means that we do not really *implement* a pending
10734 implementation, which makes code fail.
10736 2002-06-22 Martin Baulig <martin@gnome.org>
10738 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
10739 the return value of Object.GetType(). [FIXME: we need to do this whenever
10740 we get a type back from the reflection library].
10742 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
10744 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
10746 2002-06-20 Miguel de Icaza <miguel@ximian.com>
10748 * attribute.cs: Return null if we can not look up the type.
10750 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
10751 the interface types found.
10753 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
10754 interface types found.
10756 * typemanager.cs (GetInterfaces): Make this routine returns alll
10757 the interfaces and work around the lame differences between
10758 System.Type and System.Reflection.Emit.TypeBuilder in the results
10759 result for GetInterfaces.
10761 (ExpandInterfaces): Given an array of interface types, expand and
10762 eliminate repeated ocurrences of an interface. This expands in
10763 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
10766 2002-06-21 Martin Baulig <martin@gnome.org>
10768 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
10771 2002-06-21 Martin Baulig <martin@gnome.org>
10773 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
10774 and called with one of the core types, return the corresponding typebuilder for
10777 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
10780 2002-06-21 Martin Baulig <martin@gnome.org>
10782 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
10783 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
10784 (Expression.ConvertReferenceExplicit): Likewise.
10786 * expression.cs (ElementAccess.DoResolve): Likewise.
10787 (ElementAccess.DoResolveLValue): Likewise.
10789 2002-06-10 Martin Baulig <martin@gnome.org>
10791 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
10792 add the "value" parameter to the parameter list.
10794 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
10797 2002-06-19 Miguel de Icaza <miguel@ximian.com>
10799 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
10800 the argument to an int, uint, long or ulong, per the spec. Also
10801 catch negative constants in array creation.
10803 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
10805 * class.cs: do not allow the same interface to appear twice in
10806 the definition list.
10808 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
10810 * ecore.cs: don't use ldlen with System.Array.
10812 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
10814 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
10816 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
10818 * modifiers.cs: produce correct field attributes for protected
10819 internal. Easy fix so miguel can work on ther harder stuff:-)
10821 2002-06-18 Miguel de Icaza <miguel@ximian.com>
10823 * pending.cs: New file. Move the code from class.cs here.
10824 Support clearning the pending flag for all methods (when not doing
10825 explicit interface implementation).
10827 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
10829 * rootcontext.cs: added a couple more types needed to bootstrap.
10831 2002-06-17 Miguel de Icaza <miguel@ximian.com>
10833 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
10834 constructor in the type, instead of any constructor in the type
10835 hierarchy. Thanks to Paolo for finding this bug (it showed up as
10836 a bug in the Mono runtime when applying the params attribute).
10838 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
10839 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
10841 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
10843 * expression.cs (Unary.ResolveOperator): Use TypeManager
10844 to resolve the type.
10846 2002-06-13 Ravi Pratap <ravi@ximian.com>
10848 * cs-parser.jay (enum_member_declaration): Pass in the attributes
10851 * enum.cs (AddEnumMember): Add support to store the attributes associated
10852 with each member too.
10854 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
10855 field builders too - this takes care of the enum member case.
10857 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
10859 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
10860 address-of operator on both value types and pointers.
10862 2002-06-10 Martin Baulig <martin@gnome.org>
10864 * interface.cs (Interface.PopulateIndexer): Add the indexer's
10865 PropertyBuilder to the `property_builders' list.
10867 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
10868 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
10869 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
10870 find any indexers which are inherited from an interface.
10872 2002-06-09 Martin Baulig <martin@gnome.org>
10874 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
10875 the same type as the constant if necessary. There's also a test-130.cs
10878 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
10880 * typemanager.cs (TypeManager.ChangeType): Previously known as
10881 Enum.ChangeEnumType().
10883 2002-06-09 Martin Baulig <martin@gnome.org>
10885 * expression.cs (Cast.TryReduce): Added support for consts.
10887 2002-06-08 Ravi Pratap <ravi@ximian.com>
10889 * class.cs (Accessor): Hold attributes information so we can pass
10892 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
10893 Modify to pass in attributes attached to the methods.
10895 (add_accessor_declaration, remove_accessor_declaration): Ditto.
10897 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
10898 to handle the Accessor kind :-)
10900 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
10902 2002-06-08 Martin Baulig <martin@gnome.org>
10904 * expression.cs (Unary.TryReduceNegative): Added support for
10907 2002-06-08 Martin Baulig <martin@gnome.org>
10909 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
10910 name can't be found in the `defined_names' - the caller will do a
10911 MemberLookup in this case and thus find methods in System.Enum
10912 such as Enum.IsDefined().
10914 2002-06-08 Martin Baulig <martin@gnome.org>
10916 * enum.cs (Enum.ChangeEnumType): This is a custom version of
10917 Convert.ChangeType() which works with TypeBuilder created types.
10918 (Enum.LookupEnumValue, Enum.Define): Use it here.
10920 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
10921 `TypeBuilder.BaseType != null' check.
10922 (TypeContainer.FindMembers): Only lookup parent members if we
10923 actually have a parent.
10924 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
10925 (ConstructorInitializer.Resolve): Likewise.
10927 * interface.cs (Interface.FindMembers): Added
10928 `TypeBuilder.BaseType != null' check.
10930 * rootcontext.cs (RootContext.ResolveCore): Added
10931 "System.Runtime.CompilerServices.IndexerNameAttribute" to
10932 classes_second_stage.
10934 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
10935 debug_type and trace_type when compiling with --nostdlib.
10937 2002-06-07 Martin Baulig <martin@gnome.org>
10939 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
10940 (AddField): Set it to true when adding a non-static field.
10941 (DefineType): Use `have_nonstatic_fields' to find out whether we
10942 have non-static fields, not `Fields != null'.
10944 2002-06-02 Miguel de Icaza <miguel@ximian.com>
10946 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
10947 dereferencing a null on the static-field code path)
10949 2002-05-30 Martin Baulig <martin@gnome.org>
10951 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
10952 to take command line arguments. Use reflection to call the new
10953 custom `Initialize' function on the symbol writer and pass it the
10954 command line arguments.
10956 * driver.cs (--debug-args): New command line argument to pass command
10957 line arguments to the symbol writer.
10959 2002-05-28 Miguel de Icaza <miguel@ximian.com>
10961 * assign.cs (DoResolve): Forgot to do the implicit conversion to
10962 the target type for indexers and properties. Thanks to Joe for
10965 2002-05-27 Miguel de Icaza <miguel@ximian.com>
10967 * typemanager.cs (MethodFlags): returns the method flags
10968 (Obsolete/ShouldIgnore) that control warning emission and whether
10969 the invocation should be made, or ignored.
10971 * expression.cs (Invocation.Emit): Remove previous hack, we should
10972 not do this on matching a base type, we should do this based on an attribute
10974 Only emit calls to System.Diagnostics.Debug and
10975 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
10976 on the command line.
10978 * rootcontext.cs: Global settings for tracing and debugging.
10980 * cs-tokenizer.cs (define): New utility function to track
10981 defines. Set the global settings for TRACE and DEBUG if found.
10983 2002-05-25 Ravi Pratap <ravi@ximian.com>
10985 * interface.cs (Populate*): Pass in the TypeContainer as well as
10986 the DeclSpace as parameters so that we can create EmitContexts and
10987 then use that to apply attributes etc.
10989 (PopulateMethod, PopulateEvent, PopulateProperty)
10990 (PopulateIndexer): Apply attributes everywhere.
10992 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
10995 (ApplyAttributes): Update accordingly.
10997 We now apply interface attributes for all members too.
10999 2002-05-26 Miguel de Icaza <miguel@ximian.com>
11001 * class.cs (Indexer.Define); Correctly check if we are explicit
11002 implementation (instead of checking the Name for a ".", we
11003 directly look up if the InterfaceType was specified).
11005 Delay the creation of the PropertyBuilder.
11007 Only create the PropertyBuilder if we are not an explicit
11008 interface implementation. This means that explicit interface
11009 implementation members do not participate in regular function
11010 lookups, and hence fixes another major ambiguity problem in
11011 overload resolution (that was the visible effect).
11013 (DefineMethod): Return whether we are doing an interface
11016 * typemanager.cs: Temporary hack until we get attributes in
11017 interfaces (Ravi is working on that) and we get IndexerName
11018 support in interfaces.
11020 * interface.cs: Register the indexers as properties.
11022 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
11023 warning, I have verified that this is a bug in the .NET runtime
11024 (JavaScript suffers of the same problem).
11026 * typemanager.cs (MemberLookup): When looking up members for
11027 interfaces, the parent of an interface is the implicit
11028 System.Object (so we succeed in searches of Object methods in an
11029 interface method invocation. Example: IEnumerable x; x.ToString
11032 2002-05-25 Miguel de Icaza <miguel@ximian.com>
11034 * class.cs (Event): Events should also register if they do
11035 implement the methods that an interface requires.
11037 * typemanager.cs (MemberLookup); use the new GetInterfaces
11040 (GetInterfaces): The code used to lookup interfaces for a type is
11041 used in more than one place, factor it here.
11043 * driver.cs: Track the errors at the bottom of the file, we kept
11046 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
11047 instance if the method we are calling is static!
11049 2002-05-24 Miguel de Icaza <miguel@ximian.com>
11051 * attribute.cs (ApplyAttributes): Make this function filter out
11052 the IndexerName attribute (as that attribute in reality is never
11053 applied) and return the string constant for the IndexerName
11056 * class.cs (TypeContainer.Emit): Validate that all the indexers
11057 have the same IndexerName attribute, and if so, set the
11058 DefaultName attribute on the class.
11060 * typemanager.cs: The return value might contain other stuff (not
11061 only methods). For instance, consider a method with an "Item"
11062 property and an Item method.
11064 * class.cs: If there is a problem with the parameter types,
11067 2002-05-24 Ravi Pratap <ravi@ximian.com>
11069 * ecore.cs (ImplicitConversionExists): Wrapper function which also
11070 looks at user defined conversion after making a call to
11071 StandardConversionExists - we need this for overload resolution.
11073 * expression.cs : Update accordingly the various method calls.
11075 This fixes 2 bugs filed against implicit user defined conversions
11077 2002-05-22 Miguel de Icaza <miguel@ximian.com>
11079 * statement.cs: Track the result of the assignment.
11081 2002-05-21 Miguel de Icaza <miguel@ximian.com>
11083 * expression.cs (MemberAccess): Improved error reporting for
11084 inaccessible members.
11086 2002-05-22 Martin Baulig <martin@gnome.org>
11088 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
11089 itself with debugging support.
11091 2002-05-22 Martin Baulig <martin@gnome.org>
11093 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
11094 Removed, this isn't needed anymore.
11096 2002-05-20 Martin Baulig <martin@gnome.org>
11098 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
11099 be underlying type for an enum.
11101 2002-05-20 Miguel de Icaza <miguel@ximian.com>
11103 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
11104 that splits out the loading of just the core types.
11106 * rootcontext.cs (ResolveCore): Split the struct resolution in
11107 two, so we can load the enumeration underlying types before any
11110 * expression.cs (Is): Bandaid until we fix properly Switch (see
11111 bug #24985 for details).
11113 * typemanager.cs (ImplementsInterface): The hashtable will contain
11114 a null if there are no interfaces implemented.
11116 2002-05-18 Miguel de Icaza <miguel@ximian.com>
11118 * cs-parser.jay (indexer_declarator): It is fine to have array
11121 2002-05-17 Miguel de Icaza <miguel@ximian.com>
11123 * typemanager.cs: (RegisterBuilder): New function used to register
11124 TypeBuilders that implement interfaces. Since
11125 TypeBuilder.GetInterfaces (as usual) does not work with lame
11127 (AddUserType): register interfaces.
11129 (ImplementsInterface): Use the builder_to_ifaces hash if we are
11130 dealing with TypeBuilder. Also, arrays are showing up as
11131 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
11132 methods can not be invoked on them!
11134 * ecore.cs (ExplicitReferenceConversionExists): Made public.
11135 (ImplicitReferenceConversionExists): Split out from
11136 StandardConversionExists.
11138 * expression.cs (As): We were only implementing one of the three
11139 cases for the as operator. We now implement them all.
11140 (Is): Implement the various other cases for Is as well.
11142 * typemanager.cs (CACHE): New define used to control if we want or
11143 not the FindMembers cache. Seems to have a negative impact on
11144 performance currently
11146 (MemberLookup): Nested types have full acess to
11147 enclosing type members
11149 Remove code that coped with instance/static returns for events, we
11150 now catch this in RealFindMembers.
11152 (RealFindMembers): only perform static lookup if the instance
11153 lookup did not return a type or an event.
11155 2002-05-17 Miguel de Icaza <miguel@ximian.com>
11157 * assign.cs (CompoundAssign): We pass more semantic information
11158 now to Compound Assignments than we did before: now we have all
11159 the information at hand, and now we resolve the target *before* we
11160 do the expression expansion, which allows the "CacheValue" method
11161 to have the effect we intended (before, a [x] += 1 would generate
11162 two differen ArrayAccess expressions from the ElementAccess,
11163 during the resolution process).
11165 (CompoundAssign.DoResolve): Resolve target and original_source here.
11167 2002-05-16 Miguel de Icaza <miguel@ximian.com>
11169 * expression.cs (ArrayAccess): dropped debugging information.
11171 * typemanager.cs: Small bug fix: I was always returning i_members,
11172 instead of one of i_members or s_members (depending on which had
11175 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
11176 method is invoked before any code generation takes place, and it
11177 is a mechanism to inform that the expression will be invoked more
11178 than once, and that the method should use temporary values to
11179 avoid having side effects
11181 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
11183 * ecore.cs (Expression.CacheTemporaries): Provide empty default
11186 * expression.cs (Indirection, ArrayAccess): Add support for
11187 CacheTemporaries in these two bad boys.
11189 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
11190 ldobj or ldind_ref.
11191 (StoreFromPtr): Handle stobj as well.
11193 * expression.cs (UnaryMutator): Share more code.
11195 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
11196 down: I was not tracking the Filter function as well, which
11197 was affecting the results of the cache.
11199 2002-05-15 Miguel de Icaza <miguel@ximian.com>
11201 * attribute.cs: Remove the hack to handle the CharSet property on
11204 2002-05-14 Miguel de Icaza <miguel@ximian.com>
11206 * attribute.cs (DoResolve): More uglyness, we now only try to
11207 resolve the attribute partially, to extract the CharSet
11208 information (only if we are a StructLayout attribute). Otherwise
11210 (GetExtraTypeInfo): Add some code to conditionally kill in the
11211 future this. I am more and more convinced that the .NET
11212 framework has special code to handle the attribute setting on
11215 * expression.cs (IsParamsMethodApplicable): Revert my previous
11216 foreach change here, it was wrong.
11218 2002-05-13 Miguel de Icaza <miguel@ximian.com>
11220 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
11221 (pp_expr): do not abort on unknown input, just return.
11222 (eval): abort if there are pending chars.
11224 * attribute.cs (Attribute.Resolve): Positional parameters are
11225 optional. Deal with that case.
11227 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
11228 the Ansi/Unicode/Auto information for the type.
11230 (TypeContainer.DefineType): instantiate the EmitContext here, as
11231 we will be using it during the type definition (to resolve
11232 attributes) and during the emit phase.
11234 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
11235 to pull type information out of the attributes
11237 (Attribute.Resolve): track the constructor builder, and allow for
11238 multiple invocations (structs and classes will use this).
11240 * ecore.cs (MemberLookupFinal): new version with all the
11241 parameters customizable.
11243 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
11244 constructors. Return if the result value is null (as the error
11245 would have been flagged already by MemberLookupFinal)
11247 Do not allow instances of abstract classes or interfaces to be
11250 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
11251 We have to compare the assembly property here when dealing with
11252 FamANDAssem and Assembly access modifiers, because we might be
11253 creating an assembly from *modules* (that means that we are not
11254 getting TypeBuilders for types defined in other modules that are
11255 part of this assembly).
11257 (Method.Emit): If the method is marked abstract and has a body,
11260 (TypeContainer.DefineMembers): If both the defined member and the
11261 parent name match are methods, then do not emit any warnings: let
11262 the Method.Define routine take care of flagging warnings. But if
11263 there is a mismatch (method overrides something else, or method is
11264 overriwritten by something, then emit warning).
11266 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
11267 set to null, this means `do not check for the return type on the
11270 (Method.Define): set the return type for the method signature to
11271 null, so that we get methods with the same name and parameters and
11272 different return types. This is used to flag warning 114 (you are
11273 hiding a method, and you probably want to use the new/override
11276 * typemanager.cs (MemberLookup): Implemented proper access
11277 control, closing a long standing set of bug reports. The problem
11278 was that the Framework only has two bits: Public and NonPublic,
11279 and NonPublic includes private and protected methods, but we need
11280 to enforce the FamANDAssem, FamOrAssem and Family.
11282 2002-05-11 Miguel de Icaza <miguel@ximian.com>
11284 * statement.cs (GotoCase): Return true: Ammounts to giving up
11285 knowledge on whether we return or not, and letting the other case
11286 be responsible for it.
11288 2002-05-10 Miguel de Icaza <miguel@ximian.com>
11290 * driver.cs: Do not load directories for each file processed, only
11291 do it if there is a pattern.
11293 * ecore.cs: Report readonly assigns here as well, as we might have
11294 been resolved only by MemberAccess.
11296 (SimpleName.SimpleNameResolve): Also be useful for LValue
11297 resolution. We need this to propagate assign to local readonly variables
11299 * typemanager.cs: Use a ptrhashtable for the criteria, because we
11300 do not want to reuse potential criteria memory.
11302 * class.cs (MyEventBuilder): Set reflected_type;
11304 * ecore.cs (Constantify): Added support for constifying bools.
11306 (RootContext.LookupType): Added a cache for values looked up in
11307 the declaration space.
11309 * typemanager.cs (FindMembers): Now is a front-end to
11310 RealFindMembers, and provides a two-level hashtable-based cache to
11313 15% performance improvement: from 22.5 to 19.2 seconds.
11315 * expression.cs (IsParamsMethodApplicable): use foreach.
11316 (Invocation.DoResolve): ditto.
11317 (New.DoResolve): ditto.
11318 (ArrayCreation.DoResolve): ditto.
11320 * ecore.cs (FindMostEncompassingType): use foreach.
11322 * delegate.cs (NewDelegate.DoResolve): Use foreach
11324 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
11325 (RemoveMethods): use foreach.
11327 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
11328 nested foreach statements instead of for, and also break out of
11329 the inner loop once a match is found.
11331 (Invocation.OverloadResolve): Use foreach, simplify the code.
11333 2002-05-08 Miguel de Icaza <miguel@ximian.com>
11335 * cfold.cs (BinaryFold): During an enumeration evaluation context,
11336 we actually unwrap the expression to allow for extra information
11339 * expression.cs: Use Shr_Un on unsigned operations.
11341 2002-05-08 Ravi Pratap <ravi@ximian.com>
11343 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
11344 applicable operators was not being considered correctly. This closes
11345 the bug Miguel reported.
11347 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
11349 * attribute.cs: check that the type derives from System.Attribute
11350 and report the correct error in that case (moved the duplicate code to
11351 its own method, too).
11353 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
11355 * attribute.cs: lookup attribute type name as the spec says: first the
11356 bare attribute name and then name + "Attribute" (nant compiles with
11357 mcs after this fix).
11359 2002-05-07 Miguel de Icaza <miguel@ximian.com>
11361 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
11362 Because of the way we parse things, we should try to see if a
11363 UIntConstant can fit in an integer.
11365 2002-05-07 Ravi Pratap <ravi@ximian.com>
11367 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
11368 when we are in an explicit context.
11370 (ConvertReferenceExplicit): When converting from Iface type S to Class
11371 T make sure the rules are implemented as an OR.
11373 * parameter.cs (ParameterType): Make it a property for now although the
11374 purpose really isn't anything immediate.
11376 * expression.cs (Is*Applicable): Do better checking on the parameter type
11377 of a ref/out parameter. The ones from the system assemblies are already
11378 marked with the correct type so we don't need to do any correction.
11380 * ecore.cs (StandardConversionExists): Conversion from Interface types to
11381 the object type is standard too so include that.
11383 2002-05-06 Miguel de Icaza <miguel@ximian.com>
11385 * ecore.cs (StandardConversionExists): Augment with missing code:
11386 deal with IntConstant, LongConstants and Enumerations.
11388 * assign.cs: Report the error, instead of failing silently
11390 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
11391 typecontainer that they are declared, because the
11392 typecontainer/namespace will have the list of using clauses that
11393 need to be applied.
11395 Assembly Attributes were escaping the normal registration
11398 (EmitCode): Apply attributes within an EmitContext that represents
11399 the container they were declared on.
11401 * cs-parser.jay: Track bases for structs. How did I get this wrong?
11403 2002-05-06 Ravi Pratap <ravi@ximian.com>
11405 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
11406 Revamp completely - make much cleaner as we now operate only
11409 (FindMostSpecificSource, FindMostSpecificTarget): New methods
11410 to implement the logic detailed in the spec more correctly.
11412 (UserDefinedConversion): Update accordingly.
11414 2002-05-06 Miguel de Icaza <miguel@ximian.com>
11416 * statement.cs: Return flow analysis information up.
11418 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
11421 (token): Do not consume an extra character before calling
11424 2002-05-06 Piers Haken <piersh@friskit.com>
11426 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
11428 2002-05-06 Miguel de Icaza <miguel@ximian.com>
11430 * class.cs (Constructor.Emit): Set the IsStatic flag in the
11431 EmitContext during the instance constructor initializer
11432 resolution, to stop access to instance variables.
11434 This is mandated by the spec, last paragraph of the `constructor
11435 initializers' section.
11437 2002-05-05 Miguel de Icaza <miguel@ximian.com>
11439 * cs-parser.jay, class.cs (Accessor): new class used to represent
11440 an accessor (get or set). In the past we used `null' to represent
11441 a missing accessor. But this is ambiguous because there was no
11442 way to tell in abstract indexers/properties if one of them was
11445 Now there is a way of addressing that.
11447 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
11448 instead of FindMembers.
11450 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
11451 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
11453 * attribute.cs: Treat indexers and properties as the same in terms
11454 of applying attributes
11456 * ecore.cs (FindMostEncompassedType): Use statically initialized
11457 EmptyExpressions()s like we do elsewhere to avoid creating useless
11458 objects (and we take this out of the tight loop).
11460 (GetConversionOperators): Move the code to extract the actual
11461 operators to a separate routine to clean things up.
11463 2002-05-04 Miguel de Icaza <miguel@ximian.com>
11465 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
11466 events are always registered FieldBuilders.
11468 * class.cs (FieldBase): New class shared by Fields
11470 * delegate.cs: If we are a toplevel delegate, use our full name.
11471 If we are a nested delegate, then only use our tail name.
11473 2002-05-02 Ravi Pratap <ravi@ximian.com>
11475 * expression.cs (IsApplicable): Ensure that we add the "&" to
11476 ref/out types before comparing it with the type of the argument.
11478 (IsParamsMethodApplicable): Ditto.
11480 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
11483 * delegate.cs : Handle the case when we have more than one applicable
11484 method. Flag an error only when we finish checking all.
11486 2002-05-02 Miguel de Icaza <miguel@ximian.com>
11488 * expression.cs: Add support for boolean static initializers.
11490 2002-05-01 Miguel de Icaza <miguel@ximian.com>
11492 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
11494 * parameter.cs (ComputeParameterTypes,
11495 ComputeAndDefineParameterTypes): Better error handling: now we
11496 clear the `types' cache if we fail during any of the type lookups.
11497 We also return the status code correctly to our caller
11499 * delegate.cs: If we fail to define a delegate, abort the extra
11502 * expression.cs (Binary.ResolveOperator): for
11503 operator==(object,object) and operator !=(object, object) we also
11504 have to verify that there is an implicit conversion from one to
11507 (ArrayAccess.DoResolve): Array Access can operate on
11510 2002-04-30 Miguel de Icaza <miguel@ximian.com>
11512 * assign.cs (CompoundAssign): A new class used as a "flag" that
11513 the assignment actually is happening as part of a compound
11514 assignment operator.
11516 During compound assignment, a few new rules exist to enable things
11523 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
11524 to the type of x) if y is implicitly convertible to the type of x,
11525 and the operator is a builtin operator and the return type of the
11526 operator is explicitly convertible to the type of x.
11528 * rootcontext.cs: Reset warning level to 2. 4 catches various
11529 "interesting" features in mcs, we must clean this up at some
11530 point, but currently am trying to kill other bugs ;-)
11532 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
11533 in container classes as well.
11535 * expression.cs (Binary.ResolveOperator): Handle string case
11536 before anything else (as operator overloading does emit an error
11537 before doing anything else).
11539 This code could go away when we move to a table driven model, but
11540 i could not come up with a good plan last night.
11542 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
11544 * typemanager.cs (CSharpName): reimplementation using regex.
11545 * class.cs: added null check for fields in Emit
11546 * rootcontext.cs: set warninglevel to 4
11548 2002-04-29 Miguel de Icaza <miguel@ximian.com>
11550 * typemanager.cs (CSharpName): reimplemented with Lupus
11553 2002-04-28 Miguel de Icaza <miguel@ximian.com>
11555 * statement.cs (If): correclty implement Resolve, because we were
11556 not catching sem errors in there. The same process is needed
11558 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
11561 (Statement.Warning_DeadCodeFound): Factorize code.
11562 (While): Report dead code here too.
11564 (Statement): Added Resolve virtual method to allow
11565 for resolution split from the emit code.
11567 2002-04-26 Miguel de Icaza <miguel@ximian.com>
11569 * statement.cs (EmitBoolExpression): No longer try to resolve the
11571 (MakeBoolean): New utility function that resolve, implicitly
11572 converts to boolean and tags the expression.
11575 (If, Do): Implement dead code elimination.
11576 (While): Implement loop inversion
11578 (Do, While, For, If): Resolve the expression prior to calling our
11581 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
11584 - added method Report28 (warning: program has more than one entry point)
11585 - added method IsEntryPoint, implements paragraph 10.1 of the spec
11586 - modified method Method.Define, the part at the end of the method
11588 * rootcontext.cs: added static public Location EntryPointLocation;
11590 * ../errors/cs0028.cs : Add test case for the above warning.
11593 - modified method CSharpName to allow arrays of primitive type to
11594 be printed nicely (e.g. instead of System.Int32[][] it now prints
11596 - added method CSharpSignature: returns the signature of a method
11597 in string format to be used in reporting errors, warnings, etc.
11599 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
11602 2002-04-26 Ravi Pratap <ravi@ximian.com>
11604 * delegate.cs (Define): Fix extremely silly bug where I was
11605 setting the type of the 'object' parameter of the BeginInvoke
11606 method to System.IAsyncResult instead of System.Object ;-)
11608 2002-04-26 Miguel de Icaza <miguel@ximian.com>
11610 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
11613 (Constructor.Emit): return if we fail to initialize the
11614 constructor. Another door closed!
11616 * expression.cs (New.DoResolve): Improve error message (from -6 to
11617 1501). Use DeclaredOnly lookup to find the exact constructor.
11619 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
11620 loop. This is useful.
11622 * cs-parser.jay: Adjust the default parameters so that destructors
11623 have the proper signature.
11625 2002-04-26 Martin Baulig <martin@gnome.org>
11627 * driver.cs (LoadAssembly): If `assembly' contains any characters
11628 which are only valid in path names and not in assembly names
11629 (currently slash, backslash and point), use Assembly.LoadFrom ()
11630 instead of Assembly.Load () on the `assembly' (before iteration
11631 over the link_paths).
11633 2002-04-26 Martin Baulig <martin@gnome.org>
11635 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
11637 2002-04-25 Miguel de Icaza <miguel@ximian.com>
11639 * class.cs (Property): use the new typemanager.MemberLookup
11641 (TypeContainer.MemberLookup): Implement using the
11642 TypeManager.MemberLookup now.
11644 * typemanager.cs: Make MemberLookup a function of the TypeManager,
11645 and return MemberInfos, so that these can be used without an
11646 EmitContext (what we had before).
11648 2002-04-24 Miguel de Icaza <miguel@ximian.com>
11650 * expression.cs: Fix the case where the argument to params if the
11651 type of the params. I omitted handling this before. Fixed
11653 2002-04-22 Miguel de Icaza <miguel@ximian.com>
11655 * driver.cs: Call BootCorlib_PopulateCoreType
11657 * class.cs (Property.CheckBase): Check for properties only, not
11660 * interface.cs: Temporary hack: try/catch around the
11661 CustomAttributeBuilder, because I am getting an exception that I
11664 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
11665 types whose definitions are required to be there (attributes are
11666 defined before standard types).
11668 Compute definitions as we boot the various types, as they are used
11669 immediately (value_type class will need object_type, but if we do
11670 not initialize object_type, we will pass a null, which will let
11671 the runtime pick the System.Object from the existing corlib, which
11672 is not what we want).
11674 2002-04-22 Patrik Torstensson <totte@labs2.com>
11676 * cs-tokenizer.cs: fixed a number of trim() issues.
11678 2002-04-22 Ravi Pratap <ravi@ximian.com>
11680 * expression.cs (Argument.Type): Ensure that we return the correct
11681 type when we have out or ref parameters [in which case we
11684 2002-04-22 Miguel de Icaza <miguel@ximian.com>
11686 * class.cs (Property, Indexer): Allow extern modifier in there.
11688 * typemanager.cs (InitBaseTypes): Initializes object_type and
11689 value_type, since those will be used early on during the bootstrap
11690 process to compile corlib.
11692 (InitCoreTypes): Move code from here to InitBaseTypes.
11694 2002-04-21 Miguel de Icaza <miguel@ximian.com>
11696 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
11697 single-dimension arrays as using the ldlen opcode.
11699 Daniel Lewis discovered this optimization.
11701 * typemanager.cs: Add signature for System.Array::get_Length
11703 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11705 * statement.cs: report the error when the foreach does not apply to an
11706 array nor a collection.
11708 2002-04-19 Miguel de Icaza <miguel@ximian.com>
11710 * expression.cs: Add implicit conversions to the operator ~.
11712 * constant.cs (DecimalConstant.Emit): Emit decimal value.
11714 * typemanager.cs: Locate the decimal constructor.
11716 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11718 * attribute.cs: use the new property of TypeOf.
11719 * expression.cs: added 'get' property around typearg.
11721 These changes fix a build breaker reported by NickD. Is this the
11722 correct way to fix? If not, please, revert my changes and make it
11725 2002-04-17 Miguel de Icaza <miguel@ximian.com>
11727 * attribute.cs: Add support for typeof in attribute invocations.
11728 I am not sure that this is right though.
11730 2002-04-14 Duncan Mak <duncan@ximian.com>
11732 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
11733 Binary.Operator.Division case.
11735 2002-04-13 Ravi Pratap <ravi@ximian.com>
11737 * class.cs (DefineType): Ensure that we do a proper check on
11738 attribute types and also register it with the TypeManager.
11740 (TypeContainer.Targets): The default for attribute types is
11741 AttributeTargets.All.
11743 * attribute.cs (ApplyAttributes): Registering the attribute type
11744 is done elsewhere, not when we discover we have a Usage attribute.
11746 2002-04-12 Ravi Pratap <ravi@ximian.com>
11748 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
11749 and get rid of is_delegate parameter.
11751 * everywhere : update.
11753 2002-04-12 Ravi Pratap <ravi@ximian.com>
11755 * cs-parser.jay (compilation_unit): Revamp completely to use
11756 some new ideas that I got from Rhys' grammar to solve the problems
11757 with assembly level attributes.
11759 (outer_declaration): New grammar production.
11761 (attribute_sections): Add.
11763 (opt_attributes): Base on attribute_sections
11765 (namespace_declaration): Allow opt_attributes to tackle the case
11766 when we have assembly level attributes - we are clever in this
11769 * attribute.cs (ApplyAttributes): Do not worry about assembly
11770 attributes in the non-global context.
11772 * rootcontext.cs (AddGlobalAttributes): Go back to using this
11773 instead of SetGlobalAttributes.
11775 * class.cs, rootcontext.cs : Ensure we define and generate
11776 attribute types before anything else.
11778 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
11779 and flag the new error -20 for the case when the attribute type
11780 does not have valid targets specified. csc does not catch this.
11782 * ../errors/errors.txt : update for error # -20
11784 2002-04-11 Ravi Pratap <ravi@ximian.com>
11786 * support.cs (InternalParameters.ParameterModifier): Do some null
11787 checking and return sane values.
11789 * class.cs (Method.Define): If we are a PInvoke method, ensure
11790 that we are static and extern. Report error # 601
11792 * ../errors/cs0601.cs : Add test case for the above error.
11794 2002-04-07 Ravi Pratap <ravi@ximian.com>
11796 * rootcontext.cs (attribute_types): We need to keep type of
11797 all attribute types separately and emit code for them first.
11799 (RegisterAttribute) : Implement.
11801 * class.cs (DefineType): Check if the current Type is a custom
11802 attribute type and register it accordingly.
11804 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
11805 adding the first attribute twice and rename to
11807 (SetGlobalAttributes): this.
11809 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
11812 * attribute.cs (ApplyAttributes): Take an additional argument telling us
11813 if we are processing global arguments. Hmm, I am unsure of this.
11815 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11817 * expression.cs: added static array of strings to avoid calling
11818 Enum.ToString () for Operator in Binary. Significant recover of
11821 2002-04-10 Miguel de Icaza <miguel@ximian.com>
11823 * class.cs (FindMembers): Allow the Builders of the various
11824 members to be null. If they are skip them. This only happens
11825 during the PInvoke declaration.
11827 2002-04-09 Miguel de Icaza <miguel@ximian.com>
11829 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
11830 failure, so we do not keep going afterwards.
11832 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
11833 wanted to pass `false' as the `is_delegate' argument. If this is
11834 the case, why not use delegate_type == null to mean `is_delegate =
11835 false' and anything else as is_delegate = true.
11837 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
11839 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
11840 code for the section, not the beginning of the tests.
11842 2002-04-08 Miguel de Icaza <miguel@ximian.com>
11844 * cfold.cs: Handle operator + (Enum x, Underlying x)
11846 * expression.cs (Binary): same. Warn about errors where we have
11847 Enum/Enum in operator + as well.
11849 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
11852 - added support for switch(bool)
11853 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
11854 - add TableSwitchEmit() to handle table-based switch statements
11856 2002-04-05 Ravi Pratap <ravi@ximian.com>
11858 * expression.cs (Invocation.OverloadResolve): Factor out code which
11859 does parameter compatibility checking with arguments so that we can
11860 re-use the code even from Delegate.VerifyApplicability
11862 (VerifyArgumentsCompat): Move above code here.
11864 * delegate.cs (VerifyApplicability): Get rid of duplicate code
11865 and instead make a call to the above method.
11867 2002-03-31 Ravi Pratap <ravi@ximian.com>
11869 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
11870 We use it to keep track of classes which are attribute types.
11872 2002-04-02 Miguel de Icaza <miguel@ximian.com>
11874 * delegate.cs (Delegate.Define): Correctly define the types in the
11875 presence of fixed and array parameters.
11877 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
11880 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
11881 include NonPublic after the first iteration.
11883 * class.cs (Indexer.CheckBase): Only check if both parents are
11886 * cs-parser.jay (accessor_body): If empty, set to null.
11888 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
11889 same code path here to resolve constants names that we did have in
11890 MemberAccess.DoResolve. There is too much code duplicated here.
11892 2002-04-01 Miguel de Icaza <miguel@ximian.com>
11894 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
11896 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
11899 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
11900 tokens, numbers and strings.
11902 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
11905 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
11906 asyncronous parameters and the regular parameters.
11908 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
11909 specify the target directory.
11911 * expression.cs: (This.DoResolve): Simplify
11912 (As.Emit): Optimize, do not generate IsInst if the expression is
11913 always of the given type.
11915 (Is.DoResolve): Bug fix, we were reporting both always/never for
11918 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
11919 creating too many unnecessary arrays.
11921 2002-03-31 Miguel de Icaza <miguel@ximian.com>
11923 * class.cs (EmitFieldInitializer): Use Assign expression to assign
11924 fields instead of rolling our own initializer. Takes care of all
11925 implicit conversions, and drops unnecessary static checks/argument.
11927 2002-03-31 Dick Porter <dick@ximian.com>
11929 * driver.cs: use the GetDirectories() return values properly, and
11930 use "/" as path separator.
11932 2002-03-30 Miguel de Icaza <miguel@ximian.com>
11934 * expression.cs (Unary): Optimize - - expr into expr.
11935 (Binary): Optimize a + (-b) into a -b.
11937 * codegen.cs (CodeGen): Made all methods static.
11939 2002-03-29 Miguel de Icaza <miguel@ximian.com>
11943 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
11944 TypeBuilder property.
11946 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
11949 * tree.cs: Removed the various RecordXXXX, and replaced with a
11950 single RecordDecl. Removed all the accessor methods, and just
11951 left a single access point Type
11953 * enum.cs: Rename DefineEnum to DefineType.
11955 * decl.cs: New abstract method `DefineType' used to unify the
11956 Defines for Enumerations, Interfaces, TypeContainers and
11959 (FindType): Moved LookupInterfaceOrClass here. Moved the
11960 LookupBaseClasses method that used to live in class.cs and
11961 interface.cs here, and renamed to FindType.
11963 * delegate.cs: Implement DefineType. Take advantage of the
11964 refactored pattern for locating the parent builder without taking
11965 the parent_builder argument (which we know does not work if we are
11966 nested, and triggering a toplevel definition).
11968 2002-03-28 Miguel de Icaza <miguel@ximian.com>
11970 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
11971 accessibility of a member has changed during override and report
11974 * class.cs (Method.Define, Property.Define): Only complain on
11975 overrides if the method is private, any other accessibility is
11976 fine (and since we just checked the permission is the same, we are
11979 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
11980 and elif are processed always. The other pre-processing
11981 directives are only processed if we are "taking" the path
11983 2002-03-29 Martin Baulig <martin@gnome.org>
11985 * class.cs (Method.Emit): Only emit symbolic debugging info if the
11986 current location is not Null.
11988 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
11989 a separate method so we can profile it.
11991 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
11992 `span.Seconds' are just seconds, but no minutes or hours.
11993 (MainDriver): Profile the CodeGen.SaveSymbols calls.
11995 2002-03-28 Miguel de Icaza <miguel@ximian.com>
11997 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
11998 Remove the gratuitous set of Final:
12000 // If an interface implementation, then we can set Final.
12001 if (((flags & MethodAttributes.Abstract) == 0) &&
12002 implementing.DeclaringType.IsInterface)
12003 flags |= MethodAttributes.Final;
12005 I do not know what I was smoking when I used that.
12008 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
12009 step into fixing the name resolution issues for delegates and
12010 unifying the toplevel name resolution.
12012 2002-03-28 Martin Baulig <martin@gnome.org>
12014 * class.cs (Method.Emit): If we have a symbol writer, call its
12015 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
12016 tell it about the current method.
12018 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
12019 writer that we're going to emit the first byte of IL code for a new
12020 statement (a new source line).
12021 (EmitContext.EmitTopBlock): If we have a symbol writer, call
12022 EmitContext.Mark() before emitting any code.
12024 * location.cs (SymbolDocument): Return null when we're Null.
12026 * statement.cs (Statement): Moved the `Location loc' variable here.
12027 (Statement.EmitBoolExpression): If we have a symbol writer, call
12028 ec.Mark() before emitting any code to tell it that we're at the
12029 beginning of a new statement.
12030 (StatementExpression): Added `Location' argument to the constructor.
12031 (Block): Added public readonly variable `StartLocation' and public
12032 variable `EndLocation'. The latter is to be set using SetEndLocation().
12033 (Block): Added constructor which takes a start and end location.
12034 (Block.SetEndLocation): New method. This sets the end location.
12035 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
12036 local variables we create.
12037 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
12038 each statement and do also mark the begin and end of the block.
12040 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
12041 tell it the current lexer.Location, use Location.Null for the end of the
12043 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
12044 current block, set its end location using SetEndLocation().
12045 (statement_expression): StatementExpression constructor now takes the
12046 lexer.Location as additional argument.
12047 (for_statement, declare_local_variables): Likewise.
12048 (declare_local_variables): When creating a new implicit block, use the
12049 new Block constructor and pass it the lexer.Location.
12051 2002-03-28 Miguel de Icaza <miguel@ximian.com>
12053 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
12054 members also on the parent interfaces recursively.
12056 2002-03-27 Miguel de Icaza <miguel@ximian.com>
12058 * report.cs: Use new formats, since Gonzalo finished the missing
12061 * expression.cs (Binary.ResolveOperator): added missing operator|
12062 operator& and operator^ for bool/bool.
12064 * cs-parser.jay: CheckDef now takes a Location argument that is
12065 used to report errors more precisly (instead of reporting the end
12066 of a definition, we try to track something which is a lot closer
12067 to the source of the problem).
12069 * cs-tokenizer.cs: Track global token use, so we can properly flag
12070 the use of #define/#undef after the first token has been seen.
12072 Also, rename the reportXXXX to Error_DescriptiveName
12074 * decl.cs (DeclSpace.IsTopLevel): Move property here from
12075 TypeContainer, so that Enum and Interface can use this too.
12077 * class.cs (TypeContainer.LookupInterfaceOrClass,
12078 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
12079 `builder' argument. Typically this was used to pass the parent
12080 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
12083 The problem is that a nested class could trigger the definition of
12084 a toplevel class, and the builder would be obviously wrong in that
12087 So we drop this argument, and we compute dynamically the
12088 TypeBuilder/ModuleBuilder (the correct information was available
12089 to us anyways from DeclSpace.Parent)
12091 * interface.cs (Interface.DefineInterface): Drop builder
12092 parameter cleanup like class.cs
12094 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
12097 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
12100 (Try.Emit): Propagate the returns value from the statement.
12102 (Return.Emit): Even if we are leavning
12104 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
12106 * modifiers.cs: Fix the computation of MethodAttributes flags.
12108 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
12110 * driver.cs: allow compilation of files that start with '/'.
12111 Add a default case when checking the argument of --target.
12113 2002-03-25 Miguel de Icaza <miguel@ximian.com>
12115 * interface.cs: Implement the same search algorithm for types in
12116 the interface code.
12118 * delegate.cs: Do not allow multiple definition.
12120 * Recovered ChangeLog that got accidentally amputated
12122 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
12124 * rootcontext.cs: Load manually enum to allow core classes to
12125 contain enumerations.
12127 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
12128 Update to new static methods in TypeManager.
12130 * typemanager.cs (GetMethod, GetConstructor): Use our
12131 implementation of FindMembers to find the members, since during
12132 corlib compilation, the types are TypeBuilders and GetMethod and
12133 GetConstructor do not work.
12135 Make all methods in TypeManager static.
12137 (InitCodeHelpers): Split the functionality from
12138 the InitCodeTypes function.
12140 * driver.cs: Call InitCodeHelpers after we have populated the
12143 * cs-parser.jay (delegate_declaration): we did not used to compute
12144 the delegate name correctly for void delegates.
12146 2002-03-24 Miguel de Icaza <miguel@ximian.com>
12148 * rootcontext.cs (RootContext): Init the interface_resolve_order
12149 and type_container_resolve_order always.
12151 (ResolveCore, BootstrapCorlib_ResolveClass,
12152 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
12153 compiler when compiling with --nostdlib
12155 * class.cs (TypeContainer.DefineType): Check that our parent is
12156 not null. This test is most important when we are bootstraping
12159 * codegen.cs: Split out the symbol writing code.
12161 2002-03-25 Martin Baulig <martin@gnome.org>
12163 * driver.cs (-g): Made -g an alias for --debug.
12165 2002-03-24 Martin Baulig <martin@gnome.org>
12167 * codegen.cs (SymbolWriter): New public variable. Returns the
12168 current symbol writer.
12169 (CodeGen): Added `bool want_debugging_support' argument to the
12170 constructor. If true, tell the ModuleBuild that we want debugging
12171 support and ask it for the ISymbolWriter.
12172 (Save): If we have a symbol writer, call it's Close() method after
12173 saving the assembly.
12175 * driver.c (--debug): New command line argument to create a
12176 debugger information file.
12178 * location.cs (SymbolDocument): New public property. Returns an
12179 ISymbolDocumentWriter object for the current source file or null
12180 if we don't have a symbol writer.
12182 2002-03-21 Miguel de Icaza <miguel@ximian.com>
12184 * driver.cs (LoadAssembly): Correctly return when all the paths
12185 have been tried and not before.
12187 * statement.cs (Switch.Emit): return the actual coverage for this
12188 statement (returns/not-returns)
12190 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
12191 switch of the statement if we are the last switch section. That
12192 kills two problems: try/catch problems (we used to emit an empty
12193 nop at the end) and switch statements where all branches would
12196 2002-03-19 Miguel de Icaza <miguel@ximian.com>
12198 * driver.cs: Add default assemblies (the equivalent to the
12199 Microsoft CSC.RSP file)
12201 * cs-tokenizer.cs: When updating `cols and setting it to zero,
12202 also update tokens_seen and set it to false.
12204 * driver.cs: Implement --recurse for Mike.
12206 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
12207 correctly splitting out the paths.
12209 2002-03-18 Miguel de Icaza <miguel@ximian.com>
12211 * interface.cs (Interface.PopulateProperty): Instead of using
12212 `parent' as the declaration space for the set parameters, use
12215 * support.cs (InternalParameters): InternalParameters constructor
12216 takes a DeclSpace instead of a TypeContainer.
12218 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
12219 types are being initialized, load the address of it before calling
12222 (New): Provide a mechanism to disable the generation of local
12223 value type temporaries when the caller will be providing us with
12224 an address to store it.
12226 (ArrayCreation.EmitDynamicInitializers): Use it.
12228 2002-03-17 Miguel de Icaza <miguel@ximian.com>
12230 * expression.cs (Invocation.EmitArguments): Only probe for array
12231 property if there is more than one argument. Sorry about that.
12233 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
12234 empty param arrays.
12236 * class.cs (Method.LabelParameters): Fix incorrect code path that
12237 prevented the `ParamArrayAttribute' from being applied to the
12240 2002-03-16 Miguel de Icaza <miguel@ximian.com>
12242 * support.cs (ReflectionParameters): Correctly compute whether the
12243 last argument is a params array. Fixes the problem with
12246 * typemanager.cs: Make the assemblies array always be non-null
12247 (empty, but non-null)
12249 * tree.cs (RecordDecl): New function that abstracts the recording
12250 of names. This reports error 101, and provides a pointer to the
12251 previous declaration. Fixes a crash in the compiler.
12253 * cs-parser.jay (constructor_declaration): Update to new grammar,
12254 and provide a constructor_body that can be empty.
12256 2002-03-15 Miguel de Icaza <miguel@ximian.com>
12258 * driver.cs: Add support for --resources.
12260 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
12261 Make all types for the various array helper methods be integer.
12263 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
12264 CheckState to ConvCast.
12266 (ConvCast): Now it takes a `checked' state argument, to avoid
12267 depending on the emit context for the conversion, and just using
12268 the resolve time setting.
12270 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
12271 instead of Invocation.EmitArguments. We do not emit the original
12272 arguments, instead we emit those which have been converted to
12273 unsigned int expressions.
12275 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
12277 * codegen.cs: ditto.
12279 * expression.cs (LocalVariableReference): Drop the use of the
12280 Store function that depended on the variable index.
12282 * statement.cs (VariableInfo): Drop the `Idx' property from this
12283 class, as this is not taking into account the indexes for
12284 temporaries tat we generate during the execution, getting the
12287 * class.cs: First emit class initializers, then call the parent
12290 * expression.cs (Binary): Fix opcode emision.
12291 (UnaryMutator.EmitCode): Support checked code generation
12293 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
12294 matches for events for both the Static and Instance scans,
12295 pointing to the same element. Fix that.
12297 2002-03-14 Miguel de Icaza <miguel@ximian.com>
12299 * rootcontext.cs (ResolveTree): Always set the
12300 interface_resolve_order, because nested interfaces will be calling
12303 * class.cs (GetInterfaceOrClass): Track the same resolution
12304 process used by TypeManager.LookupType. This fixes the nested
12305 type lookups in class declarations (separate path from
12308 (TypeContainer.DefineType): Also define nested interfaces.
12309 (TypeContainer.RegisterOrder): New public function used to
12310 register the order in which child interfaces need to be closed.
12312 Nested interfaces need to be closed after their parents have been
12315 * interface.cs (InterfaceAttr): Put all the logic for computing
12316 the interface attribute here.
12318 (DefineInterface): Register our interface order with the
12319 RootContext or with the TypeContainer depending on the case.
12321 2002-03-12 Miguel de Icaza <miguel@ximian.com>
12323 * cs-parser.jay: rework foreach statement to work with the new
12324 changes to the policy on SimpleNames.
12326 * report.cs: support Stacktrace on warnings as well.
12328 * makefile: drop --unsafe and /unsafe from the compile.
12330 2002-03-13 Ravi Pratap <ravi@ximian.com>
12332 * ecore.cs (StandardConversionExists): Modify to take an Expression
12333 as the first parameter. Ensure we do null -> reference type conversion
12336 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
12337 temporary Expression objects.
12339 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
12341 * interface.cs: workaround bug in method overloading resolution
12342 (there is already a bugzilla bug for it).
12344 2002-03-12 Miguel de Icaza <miguel@ximian.com>
12346 We could also solve this problem by having a separate path for
12347 performing type lookups, instead of DoResolve, we could have a
12348 ResolveType entry point, and only participating pieces of the
12349 production (simplename, deref, array) would implement this.
12351 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
12352 signal SimpleName to only resolve type names and not attempt to
12353 resolve anything else.
12355 * expression.cs (Cast): Set the flag.
12357 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
12359 * class.cs: Only report 108 if there is no `new' modifier.
12361 * cs-parser.jay: rework foreach statement to work with the new
12362 changes to the policy on SimpleNames.
12364 * report.cs: support Stacktrace on warnings as well.
12366 * makefile: drop --unsafe and /unsafe from the compile.
12368 2002-03-11 Miguel de Icaza <miguel@ximian.com>
12370 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
12371 lookups here, instead of doing that at parse time. This means
12372 that our grammar will not introduce `LocalVariableReferences' as
12373 expressions at this point. That solves the problem of code like
12377 static void Main ()
12381 This is only half the fix. The full fix requires parameters to
12382 also be handled in this way.
12384 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
12385 makes the use more obvious of the DeclSpace. The
12386 ec.TypeContainer.TypeBuilder is now only used to pull the
12387 TypeBuilder for it.
12389 My theory is that I can get rid of the TypeBuilder completely from
12390 the EmitContext, and have typecasts where it is used (from
12391 DeclSpace to where it matters).
12393 The only pending problem is that the code that implements Aliases
12394 is on TypeContainer, and probably should go in DeclSpace.
12396 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
12397 lookups here, instead of doing that at parse time. This means
12398 that our grammar will not introduce `LocalVariableReferences' as
12399 expressions at this point. That solves the problem of code like
12403 static void Main ()
12407 This is only half the fix. The full fix requires parameters to
12408 also be handled in this way.
12410 * class.cs (Property.DefineMethod): When implementing an interface
12411 method, set newslot, when implementing an abstract method, do not
12412 set the flag (before we tried never setting it, or always setting
12413 it, which is the difference).
12414 (Indexer.DefineMethod): same.
12415 (Method.DefineMethod): same.
12417 * ecore.cs: Only set the status used flag if we get back a Field.
12419 * attribute.cs: Temporary hack, so Paolo can keep working.
12421 2002-03-08 Ravi Pratap <ravi@ximian.com>
12423 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
12424 the unmanaged type in the case we have a MarshalAs attribute.
12426 (Resolve): Handle the case when we are parsing the special MarshalAs
12427 attribute [we need to store the unmanaged type to use later]
12429 * typemanager.cs (marshal_as_attr_type): Built in type for the
12430 MarshalAs Attribute.
12432 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
12433 on parameters and accordingly set the marshalling info.
12435 2002-03-09 Miguel de Icaza <miguel@ximian.com>
12437 * class.cs: Optimizing slightly by removing redundant code after
12438 we switched to the `NoTypes' return value.
12439 (Property.DefineMethod): use NoTypes here too.
12441 This fixes the bug I introduced in my last batch of changes.
12443 2002-03-05 Ravi Pratap <ravi@ximian.com>
12445 * tree.cs (RecordEnum): Add. We now keep track of enums too.
12447 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
12448 Enums since those are types too.
12450 * cs-parser.jay (enum_declaration): Record enums as we parse them.
12452 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
12453 thanks to a call during the lookup process.
12455 2002-03-07 Miguel de Icaza <miguel@ximian.com>
12457 * statement.cs (Foreach): Lots of work to accomodate a particular
12458 kind of foreach statement that I had not kept in mind. It is
12459 possible to have foreachs on classes that provide a GetEnumerator
12460 method that return objects that implement the "pattern" for using
12461 a foreach, there is no need to support GetEnumerator
12464 This is needed to compile nant.
12466 * decl.cs: Only report 114 if the member is not `Finalize' and if
12467 the warning level is at least 2.
12469 * class.cs: Moved the compare function from Method to
12472 (MethodSignature.InheritableMemberSignatureCompare): Add new
12473 filter function that is used to extract inheritable methods from a
12476 (Method.Define): Use the new `inheritable_method_signature_filter'
12479 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
12482 2002-03-06 Miguel de Icaza <miguel@ximian.com>
12484 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
12486 * cs-parser.jay: Add opt_semicolon to the interface declaration.
12488 * expression.cs: Pass location information to
12489 ConvertImplicitStandard.
12491 * class.cs: Added debugging code to track return values from
12494 2002-03-05 Miguel de Icaza <miguel@ximian.com>
12496 * expression.cs (Is.DoResolve): If either side of the `is' is an
12497 interface, do not flag the warning.
12499 * ecore.cs (ImplicitReferenceConversion): We need a separate test
12502 * report.cs: Allow for --fatal to be used with --probe.
12504 * typemanager.cs (NoTypes): Move the definition for the empty Type
12507 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
12509 (TypeContainer.DefineProxy): New function used to proxy to parent
12510 implementations when implementing interfaces.
12511 (TypeContainer.ParentImplements): used to lookup if our parent
12512 implements a public function that is required by an interface.
12513 (TypeContainer.VerifyPendingMethods): Hook this up.
12515 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
12516 `modules' and `assemblies' arraylists into arrays. We only grow
12517 these are the very early start up of the program, so this improves
12518 the speedof LookupType (nicely measured).
12520 * expression.cs (MakeByteBlob): Replaced unsafe code with
12521 BitConverter, as suggested by Paolo.
12523 * cfold.cs (ConstantFold.Binary): Special case: perform constant
12524 folding of string concatenation, but if either side is a string,
12525 and the other is not, then return null, and let the runtime use
12526 the concatenation on the string plus the object (using
12527 `Object.ToString').
12529 2002-03-04 Miguel de Icaza <miguel@ximian.com>
12531 Constant Folding has been implemented now.
12533 * expression.cs (Unary.Reduce): Do not throw an exception, catch
12534 the error instead on types that are not supported in one's
12537 * constant.cs (Constant and all children): New set of functions to
12538 perform implict and explicit conversions.
12540 * ecore.cs (EnumConstant): Implement the new functions to perform
12541 conversion by proxying to the child expression.
12543 * codegen.cs: (ConstantCheckState): Constant evaluation has its
12544 own separate setting that can not be turned off from the command
12545 line using --unchecked or --checked and is only controlled using
12546 the checked/unchecked statements and expressions. This setting is
12547 used by the constant folder to flag errors.
12549 * expression.cs (CheckedExpr, UncheckedExpr): Set the
12550 ConstantCheckState as well.
12552 During Resolve, they also have to flag the state, because the
12553 constant folder runs completely in the Resolve phase.
12555 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
12558 2002-03-01 Miguel de Icaza <miguel@ximian.com>
12560 * cfold.cs: New file, this file contains the constant folder.
12562 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
12563 argument to track whether we are using the resulting address to
12564 load or store a value and provide better error messages.
12566 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
12567 new AddressOf arguments.
12569 * statement.cs (Foreach.EmitCollectionForeach): Update
12571 * expression.cs (Argument.Emit): Call AddressOf with proper
12572 arguments to track usage.
12574 (New.DoEmit): Call AddressOf with new arguments.
12576 (Unary.Emit): Adjust AddressOf call.
12578 2002-03-01 Ravi Pratap <ravi@ximian.com>
12580 * cs-parser.jay (member_access): Change the case for pre-defined types
12581 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
12584 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
12587 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
12588 essentially like methods and apply attributes like MethodImplOptions to them too.
12590 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
12593 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
12594 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
12597 * Update code everywhere accordingly.
12599 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
12601 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
12603 2002-02-28 Ravi Pratap <ravi@ximian.com>
12605 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
12606 try performing lookups against those instead of jumping straight into using
12607 the 'using' clauses.
12609 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
12611 (LookupType): Perform lookups in implicit parents too.
12613 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
12614 sequence as RootContext.LookupType.
12616 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
12617 the various cases of namespace lookups into this method.
12619 2002-03-01 Miguel de Icaza <miguel@ximian.com>
12621 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
12622 in positional arguments)
12624 * class.cs (Operator): Update the AllowedModifiers to contain
12627 * cs-parser.jay: Update operator declaration to allow for the
12628 operator body to be empty.
12630 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
12633 2002-02-27 Miguel de Icaza <miguel@ximian.com>
12635 * class.cs (Method.Emit): Label parameters.
12637 * driver.cs: Return 1 or 0 as the program exit code.
12639 2002-02-26 Miguel de Icaza <miguel@ximian.com>
12641 * expression.cs: Special case the `null' object when trying to
12642 auto-compute the type, as anything can be explicitly converted to
12645 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
12646 spotting this Paolo.
12648 (Expression.ImplicitNumericConversion): Perform comparissions of
12649 the type using the underlying type in the case of an enumeration
12650 rather than using the enumeration type for the compare.
12652 Cope with the underlying == type case, which is not possible to
12655 (Expression.ConvertNumericExplicit): Perform comparissions of
12656 the type using the underlying type in the case of an enumeration
12657 rather than using the enumeration type for the compare.
12659 * driver.cs: If the user does not supply an extension, assume .exe
12661 * cs-parser.jay (if_statement): Rewrote so that we can track the
12662 location for the if statement.
12664 * expression.cs (Binary.ConstantFold): Only concat strings when
12665 the operation is "+", not everything ;-)
12667 * statement.cs (Statement.EmitBoolExpression): Take a location
12669 (If, While, Do): Track location.
12671 * expression.cs (Binary.ResolveOperator): In the object + string
12672 case, I was missing a call to ConvertImplicit
12674 2002-02-25 Ravi Pratap <ravi@ximian.com>
12676 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
12677 Location arguments. Ensure we use RootContext.LookupType to do our work
12678 and not try to do a direct Type.GetType and ModuleBuilder.GetType
12680 * interface.cs (PopulateMethod): Handle the type of the parameter being
12683 * expression.cs (Invocation.BetterFunction): Handle the case when we
12684 have a params method with no fixed arguments and a call is made with no
12687 2002-02-25 Miguel de Icaza <miguel@ximian.com>
12689 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
12690 the verbatim-string-literal
12692 * support.cs (InternalParameters.ParameterModifier): handle null
12694 (InternalParameters.ParameterType): ditto.
12696 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
12697 duplicating the name of the variable parameter.
12698 (GetParameterByName): Fix bug where we were not looking up array
12699 paramters if they were the only present (thanks Paolo!).
12700 (GetParameterInfo): We only have an empty set of types if both
12701 fixed and array are set to null.
12702 (GetParameterInfo-idx): Handle FixedParameter == null
12704 * cs-parser.jay: Handle the case where there is no catch
12705 statements (missing null test).
12707 2002-02-22 Miguel de Icaza <miguel@ximian.com>
12709 * driver.cs (MainDriver): Be conservative on our command line
12712 Catch DirectoryNotFoundException when calling GetFiles.
12714 (SplitPathAndPattern): Used to split the input specification into
12715 a path and a pattern that we can feed to Directory.GetFiles.
12717 2002-02-21 Miguel de Icaza <miguel@ximian.com>
12719 * statement.cs (Fixed): Implement the last case of the Fixed
12720 statement (string handling).
12722 * expression.cs (StringPtr): New class used to return a char * to
12723 a string; Used by the Fixed statement.
12725 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
12727 * expression.cs (Binary.ResolveOperator): Remove redundant
12728 MemberLookup pn parent type.
12729 Optimize union call, we do not need a union if the types are the same.
12730 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
12733 Specialize the use of MemberLookup everywhere, instead of using
12734 the default settings.
12736 (StackAlloc): Implement stackalloc keyword.
12738 * cs-parser.jay: Add rule to parse stackalloc.
12740 * driver.cs: Handle /h, /help, /?
12742 * expression.cs (MakeByteBlob): Removed the hacks we had in place
12743 before we supported unsafe code.
12745 * makefile: add --unsafe to the self compilation of mcs.
12747 2002-02-20 Miguel de Icaza <miguel@ximian.com>
12749 * expression.cs (PointerArithmetic): New class that is used to
12750 perform pointer arithmetic.
12751 (Binary.Resolve): Handle pointer arithmetic
12752 Handle pointer comparission.
12753 (ArrayPtr): Utility expression class that is used to take the
12754 address of an array.
12756 (ElementAccess): Implement array access for pointers
12758 * statement.cs (Fixed): Implement fixed statement for arrays, we
12759 are missing one more case before we are done.
12761 * expression.cs (Indirection): Implement EmitAssign and set the
12762 ExprClass to Variable. This allows pointer dereferences to be
12763 treated as variables, and to have values assigned to them.
12765 * ecore.cs (Expression.StoreFromPtr): New utility function to
12766 store values dereferencing.
12768 2002-02-20 Ravi Pratap <ravi@ximian.com>
12770 * expression.cs (Binary.ResolveOperator): Ensure that we are
12771 not trying to operate on a void type - this fixes the reported
12774 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
12775 the parent implementation is sealed.
12777 * ../errors/cs0239.cs : Add.
12779 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
12781 * typemanager.cs (unverifiable_code_type): Corresponds to
12782 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
12783 which have unsafe code in them.
12785 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
12788 2002-02-19 Miguel de Icaza <miguel@ximian.com>
12790 * cs-tokenizer.cs: Add support for @"litreal strings"
12792 Make tokenizer accept pre-processor directives
12793 on any column (remove the old C-like limitation).
12795 * rootcontext.cs (EmitCode): Emit any global attributes.
12796 (AddGlobalAttributes): Used to keep track of assembly attributes.
12798 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
12800 * cs-parser.jay: Add support for global attributes.
12802 2002-02-17 Miguel de Icaza <miguel@ximian.com>
12804 * expression.cs (Indirection): New helper class. Unary will
12805 create Indirection classes to be able to implement the
12806 IMemoryLocation interface on it.
12808 2002-02-16 Miguel de Icaza <miguel@ximian.com>
12810 * cs-parser.jay (fixed_statement): reference the right statement.
12812 * statement.cs (Fixed.Emit): Finish implementing the fixed
12813 statement for the &x case.
12815 2002-02-14 Miguel de Icaza <miguel@ximian.com>
12817 * class.cs (Property.Define, Method.Define): Remove newslot when
12820 * modifiers.cs: My use of NewSlot when `Abstract' was set was
12821 wrong. NewSlot should only be used if the `new' keyword is present.
12823 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
12824 locating our system dir. Sorry about this.
12826 2002-02-13 Miguel de Icaza <miguel@ximian.com>
12828 * driver.cs (GetSystemDir): Compute correctly the location of our
12829 system assemblies. I was using the compiler directory instead of
12830 the library directory.
12832 2002-02-13 Ravi Pratap <ravi@ximian.com>
12834 * expression.cs (BetterFunction): Put back in what Miguel commented out
12835 since it is the correct fix. The problem is elsewhere ;-)
12837 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
12838 parameters of the parms method are themselves compatible or not !
12840 (StandardConversionExists): Fix very dangerous bug where we were forgetting
12841 to check that a class implements an interface before saying that an implicit
12842 conversion was allowed. Use ImplementsInterface to do the checking.
12844 2002-02-13 Miguel de Icaza <miguel@ximian.com>
12846 * class.cs (Method.Define): Track whether we are an explicit
12847 implementation or not. And only call DefineMethodOverride if we
12848 are an explicit implementation.
12850 (Property.DefineMethod): Ditto.
12852 2002-02-11 Ravi Pratap <ravi@ximian.com>
12854 * expression.cs (BetterFunction): Catch hideous bug which was
12855 preventing us from detecting ambiguous calls due to implicit casts i.e
12858 2002-01-29 Miguel de Icaza <miguel@ximian.com>
12860 * support.cs (Pair): Remove un-needed method. I figured why I was
12861 getting the error in cs-parser.jay, the variable in a foreach loop
12862 is readonly, and the compiler does not really treat this as a variable.
12864 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
12865 instead of EQUALS in grammar.
12867 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
12869 * expression.cs (Unary.DoResolve): Check whether the argument is
12872 2002-01-28 Miguel de Icaza <miguel@ximian.com>
12874 * support.cs: Api for Pair to set a value. Despite the fact that
12875 the variables are public the MS C# compiler refuses to compile
12876 code that accesses the field if the variable is part of a foreach
12879 * statement.cs (Fixed): Begin implementation of the fixed
12882 (Block.AddVariable): Return the VariableInfo on success and null
12883 on failure instead of true/false.
12885 * cs-parser.jay (foreach): Catch errors on variables already
12886 defined (we were ignoring this value before) and properly unwind
12887 the block hierarchy
12889 (fixed_statement): grammar for the fixed statement.
12891 2002-01-25 Miguel de Icaza <miguel@ximian.com>
12893 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
12894 pointer types to be incretemented.
12896 (SizeOf): Implement.
12898 * cs-parser.jay (pointer_member_access): Implement
12899 expr->IDENTIFIER production.
12901 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
12902 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
12905 (Unary): Implement indirection.
12907 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
12908 use in non-unsafe context).
12910 (SimpleName.DoResolve): Check for pointers in field access on safe
12913 (Expression.LoadFromPtr): Factor the load-indirect code in this
12914 function. This was duplicated in UnboxCast and ParameterReference
12916 2002-01-24 Miguel de Icaza <miguel@ximian.com>
12918 * expression.cs (ComposedCast): report an error if a pointer cast
12919 is used in a safe region.
12921 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
12922 pointer type casts in unsafe context.
12924 * codegen.cs (EmitContext): Set up IsUnsafe.
12926 * cs-parser.jay (non_expression_type): Add productions for pointer
12929 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
12930 code. We should not use force into static mode if the method is
12931 not virtual. Fixes bug in MIS
12933 * statement.cs (Do.Emit, While.Emit, For.Emit,
12934 Statement.EmitBoolExpression): Add support to Do and While to
12935 propagate infinite loop as `I do return' semantics.
12937 Improve the For case to also test for boolean constants.
12939 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
12940 to the list of attributes we can add.
12942 Remove `EmitContext' argument.
12944 * class.cs (Method.Define): Apply parameter attributes.
12945 (Constructor.Define): Apply parameter attributes.
12946 (MethodCore.LabelParameters): Move here the core of labeling
12949 * support.cs (ReflectionParameters.ParameterModifier,
12950 InternalParameters.ParameterModifier): Use IsByRef on the type and
12951 only return the OUT bit for these parameters instead of in/out/ref
12954 This is because I miss-understood things. The ParameterInfo.IsIn
12955 and IsOut represent whether the parameter has the [In] and [Out]
12958 2002-01-22 Miguel de Icaza <miguel@ximian.com>
12960 * ecore.cs (FieldExpr.Emit): Release temporaries.
12962 * assign.cs (LocalTemporary.Release): new function.
12964 * codegen.cs (EmitContext.GetTemporaryStorage,
12965 EmitContext.FreeTemporaryStorage): Rework the way we deal with
12966 temporary storage. Now we can "put back" localbuilders when we
12969 2002-01-21 Miguel de Icaza <miguel@ximian.com>
12971 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
12972 need to make a copy of the variable to generate verifiable code.
12974 2002-01-19 Miguel de Icaza <miguel@ximian.com>
12976 * driver.cs: Compute dynamically the system directory.
12978 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
12979 Slower, but more generally useful. Used by the abstract
12980 registering implementation.
12982 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
12983 the rules for the special rule on Type/instances. First check if
12984 we have the same name, and if so, try that special static path
12985 rather than the instance path.
12987 2002-01-18 Miguel de Icaza <miguel@ximian.com>
12989 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
12992 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
12993 Enum, ValueType, Delegate or Array for non-corlib compiles.
12995 * cs-tokenizer.cs: Catch long identifiers (645)
12997 * typemanager.cs (IndexerPropetyName): Ravi never tested this
13000 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
13001 fix, we were returning too early, so we were not registering
13002 pending methods from abstract classes.
13004 Do not register pending methods if the class is abstract.
13006 * expression.cs (Conditional.DoResolve): Report circular implicit
13007 conversions when we neecd to compute it for conditional
13010 (Is.DoResolve): If the expression is always of the provided type,
13011 flag warning 183. If the expression can not ever be of the
13012 provided type flag warning 184.
13014 * class.cs: Catch 169 as well.
13016 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
13019 2002-01-18 Nick Drochak <ndrochak@gol.com>
13021 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
13023 2002-01-17 Miguel de Icaza <miguel@ximian.com>
13025 * interface.cs: (PopulateMethod): Check for pointers being defined
13026 only if the unsafe context is active.
13027 (PopulateProperty): ditto.
13028 (PopulateIndexer): ditto.
13030 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
13031 specified. If pointers are present, make sure that they are
13032 present in an unsafe context.
13033 (Constructor, Constructor.Define): ditto.
13034 (Field, Field.Define): ditto.
13035 (Property, Property.Define): ditto.
13036 (Event, Event.Define): ditto.
13038 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
13039 hashtable if there are classes or structs defined.
13041 * expression.cs (LocalVariableReference.DoResolve): Simplify this
13042 code, as the constant resolution moved.
13044 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
13045 the metadata, so we can flag error 133.
13047 * decl.cs (MemberCore.UnsafeOK): New function to test that a
13048 pointer is being declared in an unsafe context.
13050 2002-01-16 Miguel de Icaza <miguel@ximian.com>
13052 * modifiers.cs (Modifiers.Check): Require a Location argument.
13053 Report error 227 for Unsafe use.
13055 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
13057 * statement.cs (For.Emit): If the test is null, then report that
13058 we do `return', as we wont reach anything afterwards.
13060 (Switch.SwitchGoverningType): Track the expression that matched
13063 * driver.cs: Allow negative numbers as an error code to flag.
13065 * cs-parser.jay: Handle 1551.
13067 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
13069 2002-01-15 Miguel de Icaza <miguel@ximian.com>
13071 * cs-parser.jay: Report 1518 (type declaration can only contain
13072 class, struct, interface, enum or delegate)
13074 (switch_label): Report 1523 (keywords `case' or `default' must
13077 (opt_switch_sections): Report 1522 (empty switch)
13079 * driver.cs: Report 1515 (response file specified multiple times)
13080 Report 1516 (Source file specified multiple times).
13082 * expression.cs (Argument.Resolve): Signal 1510
13084 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
13085 access not allowed in static code)
13087 2002-01-11 Ravi Pratap <ravi@ximian.com>
13089 * typemanager.cs (IsPointerType): Utility method which we are going
13092 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
13093 the object type, so we take care of that.
13095 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
13097 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
13098 added to non-params parameters :-)
13100 * typemanager.cs (CSharpName): Include 'void' type too.
13102 (void_ptr_type): Include in the set of core types.
13104 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
13107 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
13110 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
13111 completely forgotten about it.
13113 2002-01-10 Ravi Pratap <ravi@ximian.com>
13115 * cs-parser.jay (pointer_type): Add. This begins our implementation
13116 of parsing rules for unsafe code.
13118 (unsafe_statement): Implement.
13120 (embedded_statement): Modify to include the above.
13122 * statement.cs (Unsafe): Implement new class for unsafe blocks.
13124 * codegen.cs (EmitContext.InUnsafe): Add. This determines
13125 if the current context is an unsafe one.
13127 * cs-parser.jay (local_variable_pointer_type): Since local variable types
13128 are handled differently, we need separate rules for them.
13130 (local_variable_declaration): Update to use local_variable_pointer_type
13131 to allow variable declarations of unmanaged pointer types.
13133 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
13134 in unsafe contexts.
13136 * ../errors/cs0214.cs : Add.
13138 2002-01-16 Nick Drochak <ndrochak@gol.com>
13140 * makefile: remove 'response' file when cleaning.
13142 2002-01-15 Miguel de Icaza <miguel@ximian.com>
13144 * cs-parser.jay: Report 1524.
13146 2002-01-14 Miguel de Icaza <miguel@ximian.com>
13148 * typemanager.cs (RegisterMethod): drop checking if we have
13149 registered this from here
13151 2002-01-12 Miguel de Icaza <miguel@ximian.com>
13153 * class.cs (Method.EmitDestructor): Implement calling our base
13156 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
13157 value of InFinally.
13159 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
13160 this routine and will wrap the call in a try/catch block. Deal
13163 2002-01-11 Miguel de Icaza <miguel@ximian.com>
13165 * ecore.cs (Expression.MemberLookup): instead of taking a
13166 parameter `same_type' that was used to tell whether we could
13167 access private members we compute our containing type from the
13170 (FieldExpr): Added partial support for volatile fields. This does
13171 not work for volatile fields exposed from assemblies, as I can not
13172 figure out how to extract the modreq from it.
13174 Updated all the source files to use this.
13176 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
13177 because it is referenced by MemberLookup very often.
13179 2002-01-09 Ravi Pratap <ravi@ximian.com>
13181 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
13182 TypeBuilder.GetCustomAttributes to retrieve what we need.
13184 Get rid of redundant default_member_attr_type as this is the same as
13185 default_member_type which already exists.
13187 * interface.cs, attribute.cs : Update accordingly.
13189 2002-01-08 Miguel de Icaza <miguel@ximian.com>
13191 * typemanager.cs: Enable IndexerPropertyName again. It does not
13192 work for TYpeBuilders though. Ravi, can you please fix this?
13194 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
13196 * expression.cs (Argument.Emit): Handle the case of ref objects
13197 being passed to ref functions;
13199 (ParameterReference.EmitLoad): Loads the content of the pointer
13200 without dereferencing.
13202 2002-01-07 Miguel de Icaza <miguel@ximian.com>
13204 * cs-tokenizer.cs: Implemented the pre-processing expressions.
13206 2002-01-08 Ravi Pratap <ravi@ximian.com>
13208 * class.cs (Indexer.DefineMethod): Incorporate the interface
13209 type in the name of the method if we are doing explicit interface
13212 * expression.cs (ConversionExists): Remove as it is completely obsolete.
13214 (BetterConversion): Fix extremely trivial bug where we were referring to
13215 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
13218 * ../errors/bug16.cs : Add although we have fixed it.
13220 2002-01-07 Miguel de Icaza <miguel@ximian.com>
13222 * expression.cs (BaseIndexer): Begin implementation.
13224 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
13226 * cs-parser.jay (indexer_declarator): Use qualified_identifier
13227 production directly to remove a shift/reduce, and implement
13228 explicit interface implementation.
13230 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
13231 after a floating point suffix.
13233 * expression.cs (DoNumericPromotions): Improved the conversion for
13234 uint/uint. If we have a constant, we avoid doing a typecast to a
13237 * class.cs (Indexer): Implement explicit interface implementation
13240 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
13242 * class.cs: make the default instance constructor public and hidebysig.
13244 2001-01-03 Ravi Pratap <ravi@ximian.com>
13246 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
13247 so we can call it from elsewhere.
13249 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
13250 we emit it internally if the class has a defined indexer; otherwise the user
13251 emits it by decorating the class definition with the DefaultMemberAttribute.
13253 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
13254 attribute is not used on a type which defines an indexer.
13256 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
13257 character when we skip whitespace.
13259 * ../errors/cs0646.cs : Add.
13261 2002-01-03 Miguel de Icaza <miguel@ximian.com>
13263 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
13266 * makefile: Add practical target `mcs3.exe' which builds the third
13267 generation compiler.
13269 * expression.cs (New): Fix structures constructor calling.
13271 * class.cs (Property, Method, Indexer): Emit Final flag on the
13272 method if we are an interface implementation and we are not
13275 * ecore.cs (PropertyExpr): New public field `IsBase', tells
13276 whether this property is referencing a `base' method.
13278 * expression.cs (Invocation.EmitCall): take an extra argument:
13279 is_base, this is used to determine whether the `call' or
13280 `callvirt' opcode should be used.
13283 * delegate.cs: update EmitCall.
13285 * class.cs (Method.Define): Set NewSlot for the cases where we are
13286 not implementing an interface method.
13288 (Property.Define): ditto.
13290 2002-01-02 Miguel de Icaza <miguel@ximian.com>
13292 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
13293 'r'. Allows mcs to parse itself fully.
13295 2002-01-02 Ravi Pratap <ravi@ximian.com>
13297 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
13298 of the number of initializers that require the InitializeArray method.
13300 (CheckIndices): Store the Expression in all cases - not the plain value. Also
13301 update the above field where necessary.
13303 (MakeByteBlob): Update accordingly.
13305 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
13308 (EmitDynamicInitializers): Update in accordance with the new optimization.
13310 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
13311 same OpCode applies.
13313 * cs-parser.jay : Fix some glaring errors I introduced.
13315 2002-01-01 Ravi Pratap <ravi@ximian.com>
13317 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
13318 so that we can check for name clashes there too.
13320 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
13321 for interface indexers.
13323 * interfaces.cs (Define): Emit the default member attribute.
13325 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
13326 variable was being referred to while setting the value ;-)
13328 2002-01-01 Miguel de Icaza <miguel@ximian.com>
13330 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
13331 byte-by-byte information when we know the data is zero.
13333 Make the block always a multiple of 4, because
13334 DefineInitializedData has a bug.
13336 * assign.cs: Fix, we should assign from the temporary, not from
13339 * expression.cs (MakeByteBlob): Fix my incorrect code.
13341 2001-12-31 Miguel de Icaza <miguel@ximian.com>
13343 * typemanager.cs (EnumToUnderlying): This function is used to get
13344 the underlying type from an enumeration, because it does not
13347 * constant.cs: Use the I4_S form for values between -128 and 127.
13349 * statement.cs (Block.LookupLabel): Looks up a label.
13350 (Block): Drop support for labeled blocks.
13352 (LabeledStatement): New kind of statement that represents a label
13355 (Goto): Finally implement this bad boy.
13357 * cs-parser.jay: Update to reflect new mechanism to implement
13360 2001-12-30 Miguel de Icaza <miguel@ximian.com>
13362 * codegen.cs (EmitContext.This): a codegen property that keeps the
13363 a single instance of this instead of creating many different this
13366 * delegate.cs (Delegate.DoResolve): Update to use the property;
13368 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
13370 * expression.cs (BaseAccess.DoResolve): Ditto.
13372 2001-12-29 Ravi Pratap <ravi@ximian.com>
13374 * typemanager.cs (methodimpl_attr_type): Add to hold the type
13375 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
13377 (InitCoreTypes): Update accordingly.
13379 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
13380 so we can quickly store the state.
13382 (ApplyAttributes): Set the correct implementation flags
13383 for InternalCall methods.
13385 2001-12-29 Miguel de Icaza <miguel@ximian.com>
13387 * expression.cs (EmitCall): if a method is not virtual, then do
13388 not use callvirt on it.
13390 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
13391 user defined stuff) requires the use of stobj, which takes an
13392 address on the stack instead of an array and an index. So emit
13393 the Ldelema operation for it.
13395 (EmitStoreOpcode): Use stobj for valuetypes.
13397 (UnaryMutator.EmitCode): Use the right 1 value depending on
13398 whether we are dealing with int64/uint64, float or doubles.
13400 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
13401 constructors that I implemented last night.
13403 (Constructor.IsDefault): Fix to work properly for static
13406 * cs-parser.jay (CheckDef): report method signature errors.
13407 Update error number 103 to be 132.
13409 * decl.cs: New AdditionResult enumeration value: MethodExists.
13410 Although we do this check for methods later on in the semantic
13411 analysis, catching repeated default constructors is so easy that
13412 we catch these here.
13414 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
13417 (ParameterReference.EmitAssign, Emit): handle
13420 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
13421 (ArrayAccess.EmitStoreOpcode): ditto.
13423 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
13425 * expression.cs (MakeByteBlob): Complete all the missing types
13426 (uint, short, ushort, byte, sbyte)
13428 * class.cs: Only init instance field initializers on instance
13431 Rename `constructors' to instance_constructors.
13433 (TypeContainer.AddConstructor): Only add constructors to the list
13434 if it is not static.
13436 Make sure that we handle default_static_constructor independently
13437 everywhere where we handle instance_constructors
13439 2001-12-28 Miguel de Icaza <miguel@ximian.com>
13441 * class.cs: Do not lookup or create a base initializer for a
13442 static constructor.
13444 (ConstructorInitializer.Resolve): use the proper type to lookup
13447 * cs-parser.jay: Report error 1585 (modifiers between type and name).
13449 * enum.cs, interface.cs: Remove CloseType, this is taken care by
13452 * decl.cs: CloseType is now an virtual method, the default
13453 implementation just closes this type.
13455 2001-12-28 Ravi Pratap <ravi@ximian.com>
13457 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
13458 to PreserveSig by default. Also emit HideBySig on such methods.
13460 Basically, set the defaults to standard values.
13462 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
13463 argument, if candidate is better, it can't be worse than the best !
13465 (Invocation): Re-write bits to differentiate between methods being
13466 applicable in their expanded form and their normal form - for params
13469 Get rid of use_standard everywhere as only standard conversions are allowed
13470 in overload resolution.
13472 More spec conformance.
13474 2001-12-27 Miguel de Icaza <miguel@ximian.com>
13476 * driver.cs: Add --timestamp, to see where the compiler spends
13479 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
13480 `this' in static code.
13482 (SimpleName.DoResolve): Implement in terms of a helper function
13483 that allows static-references to be passed upstream to
13486 (Expression.ResolveWithSimpleName): Resolve specially simple
13487 names when called by MemberAccess to implement the special
13490 (Expression.ImplicitReferenceConversion): Handle conversions from
13491 Null to reference types before others, as Null's type is
13494 * expression.cs (Invocation.EmitCall): Handle the special case of
13495 calling methods declared on a reference type from a ValueType
13496 (Base classes System.Object and System.Enum)
13498 (MemberAccess.Resolve): Only perform lookups on Enumerations if
13499 the left hand side is a TypeExpr, not on every enumeration.
13501 (Binary.Resolve): If types are reference types, then do a cast to
13502 object on operators != and == of both arguments.
13504 * typemanager.cs (FindMembers): Extract instance and static
13505 members if requested.
13507 * interface.cs (PopulateProperty): Use void_type instead of null
13508 as the return type for the setter method.
13510 (PopulateIndexer): ditto.
13512 2001-12-27 Ravi Pratap <ravi@ximian.com>
13514 * support.cs (ReflectionParameters): Fix minor bug where we
13515 were examining the wrong parameter for the ParamArray attribute.
13517 Cope with requests for the type of the parameter at position
13518 greater than the params parameter's. We now return the element
13519 type of the params array as that makes more sense.
13521 * expression.cs (Invocation.IsParamsMethodApplicable): Update
13522 accordingly as we no longer have to extract the element type
13525 (Invocation.OverloadResolve): Update.
13527 2001-12-27 Miguel de Icaza <miguel@ximian.com>
13529 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
13530 against IEnumerator, test whether the return value is a descendant
13531 of the IEnumerator interface.
13533 * class.cs (Indexer.Define): Use an auxiliary method to implement
13534 the other bits of the method definition. Begin support for
13535 explicit interface implementation.
13537 (Property.DefineMethod): Use TypeManager.void_type instead of null
13538 for an empty return value.
13540 2001-12-26 Miguel de Icaza <miguel@ximian.com>
13542 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
13543 dealing with a FieldExpr which is composed of a FieldBuilder, in
13544 the code path we did extract the constant, but we should have
13545 obtained the underlying value to be able to cast it (otherwise we
13546 end up in an infinite loop, this is what Ravi was running into).
13548 (ArrayCreation.UpdateIndices): Arrays might be empty.
13550 (MemberAccess.ResolveMemberAccess): Add support for section
13551 14.5.4.1 that deals with the special case of E.I when E is a type
13552 and something else, that I can be a reference to a static member.
13554 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
13555 handle a particular array type to create byte blobs, it is just
13556 something we dont generate byteblobs for.
13558 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
13561 * location.cs (Push): remove the key from the hashtable that we
13562 are about to add. This happens for empty files.
13564 * driver.cs: Dispose files after we have parsed them.
13566 (tokenize): new function that only runs the tokenizer on its
13567 input, for speed testing.
13569 2001-12-26 Ravi Pratap <ravi@ximian.com>
13571 * class.cs (Event.Define): Define the private field only if there
13572 are no accessors defined.
13574 * expression.cs (ResolveMemberAccess): If there is no associated
13575 field with the event, that means we have an event defined with its
13576 own accessors and we should flag error cs0070 since transforming
13577 ourselves into a field is not valid in that case.
13579 * ecore.cs (SimpleName.DoResolve): Same as above.
13581 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
13582 and charset to sane values.
13584 2001-12-25 Ravi Pratap <ravi@ximian.com>
13586 * assign.cs (DoResolve): Perform check on events only if they
13587 are being accessed outside the declaring type.
13589 * cs-parser.jay (event_declarations): Update rules to correctly
13590 set the type of the implicit parameter etc.
13592 (add_accessor, remove_accessor): Set current local parameters.
13594 * expression.cs (Binary): For delegate addition and subtraction,
13595 cast the return value from the method into the appropriate delegate
13598 2001-12-24 Ravi Pratap <ravi@ximian.com>
13600 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
13601 of these as the workaround is unnecessary.
13603 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
13604 delegate data - none of that is needed at all.
13606 Re-write bits to extract the instance expression and the delegate method
13609 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
13612 * attribute.cs (ApplyAttributes): New method to take care of common tasks
13613 of attaching attributes instead of duplicating code everywhere.
13615 * everywhere : Update code to do attribute emission using the above method.
13617 2001-12-23 Miguel de Icaza <miguel@ximian.com>
13619 * expression.cs (IsParamsMethodApplicable): if there are not
13620 parameters, return immediately.
13622 * ecore.cs: The 0 literal can be implicity converted to an enum
13625 (SimpleName.DoResolve): First lookup the type, then lookup the
13628 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
13629 want to get its address. If the InstanceExpression is not
13630 addressable, store the result in a temporary variable, then get
13633 * codegen.cs: Only display 219 errors on warning level or above.
13635 * expression.cs (ArrayAccess): Make it implement the
13636 IMemoryLocation interface.
13638 (Binary.DoResolve): handle the operator == (object a, object b)
13639 and operator != (object a, object b) without incurring into a
13640 BoxedCast (because 5 != o should never be performed).
13642 Handle binary enumerator operators.
13644 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
13645 value type, otherwise use Ldelem_ref.
13647 Use precomputed names;
13649 (AddressOf): Implement address of
13651 * cs-parser.jay (labeled_statement): Fix recursive block
13652 addition by reworking the production.
13654 * expression.cs (New.DoEmit): New has a special case:
13656 If we are dealing with a ValueType, we have a few
13657 situations to deal with:
13659 * The target of New is a ValueType variable, that is
13660 easy, we just pass this as the variable reference
13662 * The target of New is being passed as an argument,
13663 to a boxing operation or a function that takes a
13666 In this case, we need to create a temporary variable
13667 that is the argument of New.
13670 2001-12-23 Ravi Pratap <ravi@ximian.com>
13672 * rootcontext.cs (LookupType): Check that current_type is not null before
13673 going about looking at nested types.
13675 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
13676 not implement the IAssignMethod interface any more.
13678 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
13679 where we tranform them into FieldExprs if they are being resolved from within
13680 the declaring type.
13682 * ecore.cs (SimpleName.DoResolve): Do the same here.
13684 * assign.cs (DoResolve, Emit): Clean up code considerably.
13686 * ../errors/bug10.cs : Add.
13688 * ../errors/cs0070.cs : Add.
13690 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
13692 * assign.cs : Get rid of EventIsLocal everywhere.
13694 2001-12-23 Miguel de Icaza <miguel@ximian.com>
13696 * ecore.cs (ConvertIntLiteral): finished the implementation.
13698 * statement.cs (SwitchLabel): Convert the value we are using as a
13699 key before looking up the table.
13701 2001-12-22 Miguel de Icaza <miguel@ximian.com>
13703 * codegen.cs (EmitTopBlock): Require a Location argument now.
13705 * cs-parser.jay (constructor_declarator): We need to setup
13706 current_local_parameters before we parse the
13707 opt_constructor_initializer, to allow the variables to be bound
13708 to the constructor arguments.
13710 * rootcontext.cs (LookupType): First lookup nested classes in our
13711 class and our parents before we go looking outside our class.
13713 * expression.cs (ConstantFold): Extract/debox the values at the
13716 * rootcontext.cs (EmitCode): Resolve the constants first before we
13717 resolve the types. This is not really needed, but it helps debugging.
13719 * statement.cs: report location.
13721 * cs-parser.jay: pass location to throw statement.
13723 * driver.cs: Small bug fix.
13725 * report.cs: Updated format to be 4-zero filled digits.
13727 2001-12-22 Ravi Pratap <ravi@ximian.com>
13729 * expression.cs (CheckIndices): Fix minor bug where the wrong
13730 variable was being referred to ;-)
13732 (DoEmit): Do not call EmitStaticInitializers when the
13733 underlying type is System.Object.
13735 2001-12-21 Ravi Pratap <ravi@ximian.com>
13737 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
13738 and do the usual workaround for SRE.
13740 * class.cs (MyEventBuilder.EventType): New member to get at the type
13741 of the event, quickly.
13743 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
13745 * assign.cs (Assign.DoResolve): Handle the case when the target
13746 is an EventExpr and perform the necessary checks.
13748 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
13751 (SimpleName.MemberStaticCheck): Include check for EventExpr.
13753 (EventExpr): Set the type in the constructor itself since we
13754 are meant to be born fully resolved.
13756 (EventExpr.Define): Revert code I wrote earlier.
13758 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
13759 instance expression is null. The instance expression is a This in that case
13760 or a null, depending on whether it is a static method or not.
13762 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
13763 refers to more than one method.
13765 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
13766 and accordingly flag errors.
13768 2001-12-21 Miguel de Icaza <miguel@ximian.com>
13770 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
13772 2001-12-22 Miguel de Icaza <miguel@ximian.com>
13774 * location.cs (ToString): Provide useful rutine.
13776 2001-12-21 Miguel de Icaza <miguel@ximian.com>
13778 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
13779 objects, return the actual integral boxed.
13781 * statement.cs (SwitchLabel): define an ILLabel for each
13784 (Switch.CheckSwitch): If the value is a Literal, extract
13785 the underlying literal.
13787 Also in the unused hashtable we had, add the SwitchLabel so we can
13788 quickly look this value up.
13790 * constant.cs: Implement a bunch of new constants. Rewrite
13791 Literal based on this. Made changes everywhere to adapt to this.
13793 * expression.cs (Expression.MakeByteBlob): Optimize routine by
13794 dereferencing array only once, and also copes with enumrations.
13796 bytes are two bytes wide, not one.
13798 (Cast): Perform constant conversions.
13800 * ecore.cs (TryImplicitIntConversion): Return literals instead of
13801 wrappers to the literals here.
13803 * expression.cs (DoNumericPromotions): long literals can converted
13804 to ulong implicity (this is taken care of elsewhere, but I was
13805 missing this spot).
13807 * ecore.cs (Expression.Literalize): Make the return type Literal,
13808 to improve type checking.
13810 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
13812 2001-12-20 Miguel de Icaza <miguel@ximian.com>
13814 * literal.cs: Revert code from ravi that checked the bounds. The
13815 bounds are sane by the definition of the type itself.
13817 * typemanager.cs: Fix implementation of ImplementsInterface. We
13818 need to actually look up in our parent hierarchy for interfaces
13821 * const.cs: Use the underlying type for enumerations
13823 * delegate.cs: Compute the basename for the delegate creation,
13824 that should fix the delegate test case, and restore the correct
13825 Type Lookup semantics in rootcontext
13827 * rootcontext.cs: Revert Ravi's last patch. The correct way of
13828 referencing a nested type with the Reflection API is using the "+"
13831 * cs-parser.jay: Do not require EOF token at the end.
13833 2001-12-20 Ravi Pratap <ravi@ximian.com>
13835 * rootcontext.cs (LookupType): Concatenate type names with
13836 a '.' instead of a '+' The test suite passes again.
13838 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
13839 field of the enumeration.
13841 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
13842 the case when the member is an EventExpr.
13844 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
13845 static has an associated instance expression.
13847 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
13849 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
13851 * class.cs (Event.Define): Register event and perform appropriate checks
13854 We define the Add and Remove methods even if the use provides none because
13855 in that case, we provide default implementations ourselves.
13857 Define a private field of the type of the event. This is done by the CSC compiler
13858 and we should be doing it too ;-)
13860 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
13861 More methods we use in code we generate.
13863 (multicast_delegate_type, delegate_type): Two separate types since the distinction
13866 (InitCoreTypes): Update accordingly for the above.
13868 * class.cs (Event.Emit): Generate code for default accessors that we provide
13870 (EmitDefaultMethod): Do the job in the above.
13872 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
13875 2001-12-20 Miguel de Icaza <miguel@ximian.com>
13877 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
13878 builders even if we were missing one.
13880 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
13881 pass the Basename as our class name instead of the Name. The
13882 basename will be correctly composed for us.
13884 * parameter.cs (Paramters): Now takes a Location argument.
13886 * decl.cs (DeclSpace.LookupType): Removed convenience function and
13887 make all the code call directly LookupType in RootContext and take
13888 this chance to pass the Location information everywhere.
13890 * Everywhere: pass Location information.
13892 2001-12-19 Miguel de Icaza <miguel@ximian.com>
13894 * class.cs (Constructor.Define): Updated way of detecting the
13895 length of the parameters.
13897 (TypeContainer.DefineType): Use basename as the type name for
13900 (TypeContainer.Define): Do not recursively define types here, as
13901 definition is taken care in order by the RootContext.
13903 * tree.cs: Keep track of namespaces in a per-file basis.
13905 * parameter.cs (Parameter.ComputeSignature): Update to use
13908 (Parameters.GetSignature): ditto.
13910 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
13911 instead of a TypeContainer.
13913 (Interface.SemanticAnalysis): Use `this' instead of our parent to
13914 resolve names. Because we need to be resolve in our context, not
13917 * driver.cs: Implement response files.
13919 * class.cs (TypeContainer.DefineType): If we are defined, do not
13920 redefine ourselves.
13922 (Event.Emit): Emit the code for add/remove handlers.
13923 (Event.Define): Save the MethodBuilders for add/remove.
13925 * typemanager.cs: Use pair here too.
13927 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
13928 DictionaryEntry requires the first argument to be non-null.
13930 (enum_declaration): Compute full name for registering the
13933 (delegate_declaration): Instead of using
13934 formal_parameter_list, use opt_formal_parameter_list as the list
13937 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
13938 (EventParsing): New property that controls whether `add' and
13939 `remove' are returned as tokens or identifiers (for events);
13941 2001-12-19 Ravi Pratap <ravi@ximian.com>
13943 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
13944 use MyEventBuilder only and let it wrap the real builder for us.
13946 (MyEventBuilder): Revamp constructor etc.
13948 Implement all operations that we perform on EventBuilder in precisely the same
13951 (FindMembers): Update to use the EventBuilder member.
13953 (Event.Emit): Update accordingly.
13955 2001-12-18 Ravi Pratap <ravi@ximian.com>
13957 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
13958 by calling the appropriate methods.
13960 (GetCustomAttributes): Make stubs as they cannot possibly do anything
13963 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
13965 2001-12-17 Ravi Pratap <ravi@ximian.com>
13967 * delegate.cs (Delegate.Populate): Check that the return type
13968 and various parameters types are indeed accessible.
13970 * class.cs (Constructor.Define): Same here.
13972 (Field.Define): Ditto.
13974 (Event.Define): Ditto.
13976 (Operator.Define): Check that the underlying Method defined itself
13977 correctly - so it's MethodBuilder should not be null.
13979 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
13980 expression happens to be null.
13982 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
13983 members but as of now we don't seem to be able to do anything really useful with it.
13985 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
13986 not the EventBuilder.
13988 2001-12-18 Miguel de Icaza <miguel@ximian.com>
13990 * cs-tokenizer.cs: Add support for defines.
13991 Add support for #if, #elif, #else, #endif
13993 (eval_var): evaluates a variable.
13994 (eval): stubbed for evaluating functions.
13996 * cs-parser.jay: Pass the defines information
13998 * driver.cs: Add --define command line option.
14000 * decl.cs: Move MemberCore here.
14002 Make it the base class for DeclSpace. This allows us to catch and
14003 report 108 and 109 for everything now.
14005 * class.cs (TypeContainer.Define): Extract all the members
14006 before populating and emit the warning 108 (new keyword required
14007 to override) instead of having each member implement this.
14009 (MemberCore.Define): New abstract method, we will be using this in
14010 the warning reporting engine in Populate.
14012 (Operator.Define): Adjust to new MemberCore protocol.
14014 * const.cs (Const): This does not derive from Expression, it is a
14015 temporary object we use to create fields, it is a MemberCore.
14017 * class.cs (Method.Define): Allow the entry point to be in a
14020 * driver.cs: Rewrite the argument handler to clean it up a bit.
14022 * rootcontext.cs: Made it just an auxiliary namespace feature by
14023 making everything static.
14025 * driver.cs: Adapt code to use RootContext type name instead of
14028 * delegate.cs: Remove RootContext argument.
14030 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
14033 * class.cs (Event.Define): The lookup can fail.
14035 * cs-tokenizer.cs: Begin implementation of pre-procesor.
14037 * expression.cs: Resolve the this instance before invoking the code.
14039 2001-12-17 Miguel de Icaza <miguel@ximian.com>
14041 * cs-parser.jay: Add a production in element_access that allows
14042 the thing to become a "type" reference. This way we can parse
14043 things like "(string [])" as a type.
14045 Note that this still does not handle the more complex rules of
14049 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
14051 * ecore.cs: (CopyNewMethods): new utility function used to
14052 assemble the list of methods from running FindMembers.
14054 (MemberLookup): Rework FindMembers so that
14056 2001-12-16 Miguel de Icaza <miguel@ximian.com>
14058 * class.cs (TypeContainer): Remove Delegates who fail to be
14061 * delegate.cs (Populate): Verify that we dont get null return
14062 values. TODO: Check for AsAccessible.
14064 * cs-parser.jay: Use basename to emit error 574 (destructor should
14065 have the same name as container class), not the full name.
14067 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
14068 possible representation.
14070 Also implements integer type suffixes U and L.
14072 2001-12-15 Miguel de Icaza <miguel@ximian.com>
14074 * expression.cs (ArrayCreation.DoResolve): We need to do the
14075 argument resolution *always*.
14077 * decl.cs: Make this hold the namespace. Hold the root context as
14079 (LookupType): Move here.
14081 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
14083 * location.cs (Row, Name): Fixed the code, it was always returning
14084 references to the first file.
14086 * interface.cs: Register properties defined through interfaces.
14088 * driver.cs: Add support for globbing on the command line
14090 * class.cs (Field): Make it derive from MemberCore as well.
14093 2001-12-15 Ravi Pratap <ravi@ximian.com>
14095 * class.cs (Event::Define): Check that the type of the event is a delegate
14096 type else flag error #66.
14098 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
14101 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
14102 values of EntryPoint, CharSet etc etc.
14104 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
14106 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
14107 be null and we should ignore this. I am not sure if this is really clean. Apparently,
14108 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
14109 which needs this to do its work.
14111 * ../errors/cs0066.cs : Add.
14113 2001-12-14 Miguel de Icaza <miguel@ximian.com>
14115 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
14118 * class.cs: (MethodSignature.MethodSignature): Removed hack that
14119 clears out the parameters field.
14120 (MemberSignatureCompare): Cleanup
14122 (MemberCore): New base class used to share code between MethodCore
14125 (RegisterRequiredImplementations) BindingFlags.Public requires
14126 either BindingFlags.Instace or Static. Use instance here.
14128 (Property): Refactored code to cope better with the full spec.
14130 * parameter.cs (GetParameterInfo): Return an empty array instead
14133 * class.cs (Property): Abstract or extern properties have no bodies.
14135 * parameter.cs (GetParameterInfo): return a zero-sized array.
14137 * class.cs (TypeContainer.MethodModifiersValid): Move all the
14138 method modifier validation to the typecontainer so we can reuse
14139 this on properties.
14141 (MethodCore.ParameterTypes): return an empty sized array of types.
14143 (Property.Define): Test property modifier validity.
14145 Add tests for sealed/override too.
14147 (Method.Emit): abstract or extern methods have no bodies.
14149 2001-12-14 Ravi Pratap <ravi@ximian.com>
14151 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
14154 (Method::Define, ::Emit): Modify accordingly.
14156 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
14158 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
14160 * makefile: Pass in /unsafe.
14162 2001-12-13 Miguel de Icaza <miguel@ximian.com>
14164 * class.cs (MakeKey): Kill routine.
14166 * class.cs (TypeContainer.Define): Correctly define explicit
14167 method implementations (they require the full interface name plus
14170 * typemanager.cs: Deply the PtrHashtable here and stop using the
14171 lame keys. Things work so much better.
14173 This of course broke everyone who depended on `RegisterMethod' to
14174 do the `test for existance' test. This has to be done elsewhere.
14176 * support.cs (PtrHashtable): A hashtable that avoid comparing with
14177 the object stupid Equals method (because, that like fails all over
14178 the place). We still do not use it.
14180 * class.cs (TypeContainer.SetRequiredInterface,
14181 TypeContainer.RequireMethods): Killed these two routines and moved
14182 all the functionality to RegisterRequiredImplementations.
14184 (TypeContainer.RegisterRequiredImplementations): This routine now
14185 registers all the implementations required in an array for the
14186 interfaces and abstract methods. We use an array of structures
14187 which can be computed ahead of time to reduce memory usage and we
14188 also assume that lookups are cheap as most classes will not
14189 implement too many interfaces.
14191 We also avoid creating too many MethodSignatures.
14193 (TypeContainer.IsInterfaceMethod): Update and optionally does not
14194 clear the "pending" bit if we find that there are problems with
14197 (TypeContainer.VerifyPendingMethods): Update to report errors of
14198 methods that look like implementations but are not.
14200 (TypeContainer.Define): Add support for explicit interface method
14203 2001-12-12 Miguel de Icaza <miguel@ximian.com>
14205 * typemanager.cs: Keep track of the parameters here instead of
14206 being a feature of the TypeContainer.
14208 * class.cs: Drop the registration of parameters here, as
14209 InterfaceMethods are also interface declarations.
14211 * delegate.cs: Register methods with the TypeManager not only with
14212 the TypeContainer. This code was buggy.
14214 * interface.cs: Full registation here.
14216 2001-12-11 Miguel de Icaza <miguel@ximian.com>
14218 * expression.cs: Remove reducer for binary expressions, it can not
14221 * const.cs: Put here the code that used to go into constant.cs
14223 * constant.cs: Put here the code for constants, this is a new base
14224 class for Literals.
14226 * literal.cs: Make Literal derive from Constant.
14228 2001-12-09 Miguel de Icaza <miguel@ximian.com>
14230 * statement.cs (Return.Emit): Report error 157 if the user
14231 attempts to return from a finally block.
14233 (Return.Emit): Instead of emitting a return, jump to the end of
14236 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
14237 LocalBuilder to store the result of the function. ReturnLabel is
14238 the target where we jump.
14241 2001-12-09 Radek Doulik <rodo@ximian.com>
14243 * cs-parser.jay: remember alias in current namespace
14245 * ecore.cs (SimpleName::DoResolve): use aliases for types or
14248 * class.cs (LookupAlias): lookup alias in my_namespace
14250 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
14252 (LookupAlias): lookup alias in this and if needed in parent
14255 2001-12-08 Miguel de Icaza <miguel@ximian.com>
14259 * rootcontext.cs: (ModuleBuilder) Made static, first step into
14260 making things static. I need this to avoid passing the
14261 TypeContainer when calling ParameterType.
14263 * support.cs (InternalParameters.ParameterType): Remove ugly hack
14264 that did string manipulation to compute the type and then call
14265 GetType. Use Parameter.ParameterType instead.
14267 * cs-tokenizer.cs: Consume the suffix for floating values.
14269 * expression.cs (ParameterReference): figure out whether this is a
14270 reference parameter or not. Kill an extra variable by computing
14271 the arg_idx during emission.
14273 * parameter.cs (Parameters.GetParameterInfo): New overloaded
14274 function that returns whether a parameter is an out/ref value or not.
14276 (Parameter.ParameterType): The type of the parameter (base,
14277 without ref/out applied).
14279 (Parameter.Resolve): Perform resolution here.
14280 (Parameter.ExternalType): The full type (with ref/out applied).
14282 * statement.cs (Using.Emit, Using.EmitExpression): Implement
14283 support for expressions on the using statement.
14285 2001-12-07 Miguel de Icaza <miguel@ximian.com>
14287 * statement.cs (Using.EmitLocalVariableDecls): Split the
14288 localvariable handling of the using statement.
14290 (Block.EmitMeta): Keep track of variable count across blocks. We
14291 were reusing slots on separate branches of blocks.
14293 (Try.Emit): Emit the general code block, we were not emitting it.
14295 Check the type of the declaration to be an IDisposable or
14296 something that can be implicity converted to it.
14298 Emit conversions if required.
14300 * ecore.cs (EmptyExpression): New utility class.
14301 (Expression.ImplicitConversionExists): New utility function.
14303 2001-12-06 Miguel de Icaza <miguel@ximian.com>
14305 * statement.cs (Using): Implement.
14307 * expression.cs (LocalVariableReference): Support read only variables.
14309 * statement.cs: Remove the explicit emit for the Leave opcode.
14310 (VariableInfo): Add a readonly field.
14312 2001-12-05 Miguel de Icaza <miguel@ximian.com>
14314 * ecore.cs (ConvCast): new class used to encapsulate the various
14315 explicit integer conversions that works in both checked and
14316 unchecked contexts.
14318 (Expression.ConvertNumericExplicit): Use new ConvCast class to
14319 properly generate the overflow opcodes.
14321 2001-12-04 Miguel de Icaza <miguel@ximian.com>
14323 * statement.cs: The correct type for the EmptyExpression is the
14324 element_type, not the variable type. Ravi pointed this out.
14326 2001-12-04 Ravi Pratap <ravi@ximian.com>
14328 * class.cs (Method::Define): Handle PInvoke methods specially
14329 by using DefinePInvokeMethod instead of the usual one.
14331 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
14332 above to do the task of extracting information and defining the method.
14334 2001-12-04 Ravi Pratap <ravi@ximian.com>
14336 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
14337 of the condition for string type.
14339 (Emit): Move that here.
14341 (ArrayCreation::CheckIndices): Keep string literals in their expression
14344 (EmitDynamicInitializers): Handle strings appropriately.
14346 2001-12-04 Miguel de Icaza <miguel@ximian.com>
14348 * codegen.cs (EmitContext): Replace multiple variables with a
14349 single pointer to the current Switch statement.
14351 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
14354 2001-12-03 Miguel de Icaza <miguel@ximian.com>
14358 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
14361 (Foreach.Emit): Foreach on arrays was not setting
14362 up the loop variables (for break/continue).
14364 (GotoCase): Semi-implented.
14366 2001-12-03 Ravi Pratap <ravi@ximian.com>
14368 * attribute.cs (CheckAttribute): Handle system attributes by using
14369 Attribute.GetAttributes to examine information we need.
14371 (GetValidPlaces): Same here.
14373 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
14375 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
14377 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
14379 (Method::Define): Set appropriate flags if we have a DllImport attribute.
14381 (Method::Emit): Handle the case when we are a PInvoke method.
14383 2001-12-03 Miguel de Icaza <miguel@ximian.com>
14385 * expression.cs: Use ResolveWithSimpleName on compound names.
14387 2001-12-02 Ravi Pratap <ravi@ximian.com>
14389 * constant.cs (EmitConstant): Make sure we resolve the associated expression
14390 before trying to reduce it.
14392 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
14394 * constant.cs (LookupConstantValue): Implement.
14396 (EmitConstant): Use the above in emitting the constant.
14398 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
14399 that are user-defined by doing a LookupConstantValue on them.
14401 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
14404 2001-11-29 Miguel de Icaza <miguel@ximian.com>
14406 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
14408 (BaseAccess.DoResolve): Implement.
14410 (MemberAccess.DoResolve): Split this routine into a
14411 ResolveMemberAccess routine that can be used independently
14413 2001-11-28 Miguel de Icaza <miguel@ximian.com>
14415 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
14416 As that share bits of the implementation. Is returns a boolean,
14417 while As returns the Type that is being probed.
14419 2001-12-01 Ravi Pratap <ravi@ximian.com>
14421 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
14422 instead of a Literal - much easier.
14424 (EnumInTransit): Remove - utterly useless :-)
14426 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
14428 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
14430 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
14431 chain when we have no associated expression.
14433 2001-11-30 Ravi Pratap <ravi@ximian.com>
14435 * constant.cs (Define): Use Location while reporting the errror.
14437 Also emit a warning when 'new' is used and there is no inherited
14440 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
14443 (LookupEnumValue): Implement to lookup an enum member's value and define it
14446 (Populate): Re-write accordingly to use the above routine.
14448 2001-11-27 Miguel de Icaza <miguel@ximian.com>
14450 * expression.cs (This): Fix prototype for DoResolveLValue to
14451 override the base class DoResolveLValue.
14453 * cs-parser.cs: Report errors cs574 and cs575 (destructor
14456 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
14457 (we need to load the address of the field here). This fixes
14460 (FieldExpr.DoResolveLValue): Call the DoResolve
14461 function to initialize the Instance expression.
14463 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
14464 correctly the GetEnumerator operation on a value type.
14466 * cs-parser.jay: Add more simple parsing error catches.
14468 * statement.cs (Switch): Add support for string switches.
14469 Handle null specially.
14471 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
14473 2001-11-28 Ravi Pratap <ravi@ximian.com>
14475 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
14477 (declare_local_constant): New helper function.
14479 * statement.cs (AddConstant): Keep a separate record of constants
14481 (IsConstant): Implement to determine if a variable is a constant.
14483 (GetConstantExpression): Implement.
14485 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
14487 * statement.cs (IsVariableDefined): Re-write.
14489 2001-11-27 Ravi Pratap <ravi@ximian.com>
14491 * class.cs (TypeContainer::FindMembers): Look for constants
14492 in the case when we are looking for MemberTypes.Field
14494 * expression.cs (MemberAccess::DoResolve): Check that in the
14495 case we are a FieldExpr and a Literal, we are not being accessed
14496 by an instance reference.
14498 * cs-parser.jay (local_constant_declaration): Implement.
14500 (declaration_statement): Implement for constant declarations.
14502 2001-11-26 Miguel de Icaza <miguel@ximian.com>
14504 * statement.cs (Switch): Catch double defaults.
14506 (Switch): More work on the switch() statement
14507 implementation. It works for integral values now, need to finish
14511 2001-11-24 Miguel de Icaza <miguel@ximian.com>
14513 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
14514 integer literals into other integer literals. To be used by
14517 2001-11-24 Ravi Pratap <ravi@ximian.com>
14519 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
14522 (EmitDynamicInitializers): Cope with the above since we extract data
14523 directly from ArrayData now.
14525 (ExpectInitializers): Keep track of whether initializers are mandatory
14528 (Bounds): Make it a hashtable to prevent the same dimension being
14529 recorded for every element in that dimension.
14531 (EmitDynamicInitializers): Fix bug which prevented the Set array method
14534 Also fix bug which was causing the indices to be emitted in the reverse
14537 2001-11-24 Miguel de Icaza <miguel@ximian.com>
14539 * expression.cs (ArrayCreation): Implement the bits that Ravi left
14540 unfinished. They do not work, because the underlying code is
14543 2001-11-22 Miguel de Icaza <miguel@ximian.com>
14545 * cs-parser.jay: Remove bogus fixme.
14547 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
14548 on Switch statement.
14550 2001-11-23 Ravi Pratap <ravi@ximian.com>
14552 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
14555 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
14556 parameter. Apparently, any expression is allowed.
14558 (ValidateInitializers): Update accordingly.
14560 (CheckIndices): Fix some tricky bugs thanks to recursion.
14562 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
14563 I was being completely brain-dead.
14565 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
14566 and re-write acordingly.
14568 (DelegateInvocation): Re-write accordingly.
14570 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
14572 (MakeByteBlob): Handle types more correctly.
14574 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
14575 initialization from expressions but it is incomplete because I am a complete
14578 2001-11-22 Miguel de Icaza <miguel@ximian.com>
14580 * statement.cs (If.Emit): Fix a bug that generated incorrect code
14581 on If. Basically, we have to return `true' (ie, we do return to
14582 our caller) only if both branches of the if return.
14584 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
14585 short-circuit operators, handle them as short circuit operators.
14587 (Cast.DoResolve): Resolve type.
14588 (Cast.Cast): Take an expression as the target type.
14590 * cs-parser.jay (cast_expression): Remove old hack that only
14591 allowed a limited set of types to be handled. Now we take a
14592 unary_expression and we resolve to a type during semantic
14595 Use the grammar productions from Rhys to handle casts (this is
14596 not complete like Rhys syntax yet, we fail to handle that corner
14597 case that C# has regarding (-x), but we will get there.
14599 2001-11-22 Ravi Pratap <ravi@ximian.com>
14601 * class.cs (EmitFieldInitializer): Take care of the case when we have a
14602 field which is an array type.
14604 * cs-parser.jay (declare_local_variables): Support array initialization too.
14606 * typemanager.cs (MakeKey): Implement.
14608 (everywhere): Use the above appropriately.
14610 * cs-parser.jay (for_statement): Update for array initialization while
14611 declaring variables.
14613 * ecore.cs : The error message was correct, it's the variable's names that
14614 were misleading ;-) Make the code more readable.
14616 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
14617 the correct type etc.
14619 (ConvertExplicit): Handle Enum types by examining the underlying type.
14621 2001-11-21 Ravi Pratap <ravi@ximian.com>
14623 * parameter.cs (GetCallingConvention): Always return
14624 CallingConventions.Standard for now.
14626 2001-11-22 Miguel de Icaza <miguel@ximian.com>
14628 * expression.cs (Binary.ResolveOperator): Update the values of `l'
14629 and `r' after calling DoNumericPromotions.
14631 * ecore.cs: Fix error message (the types were in the wrong order).
14633 * statement.cs (Foreach.ProbeCollectionType): Need to pass
14634 BindingFlags.Instance as well
14636 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
14637 implicit int literal conversion in an empty cast so that we
14638 propagate the right type upstream.
14640 (UnboxCast): new class used to unbox value types.
14641 (Expression.ConvertExplicit): Add explicit type conversions done
14644 (Expression.ImplicitNumericConversion): Oops, forgot to test for
14645 the target type before applying the implicit LongLiterals to ULong
14648 2001-11-21 Miguel de Icaza <miguel@ximian.com>
14650 * cs-parser.jay (for_statement): Reworked the way For works: now
14651 we declare manually any variables that are introduced in
14652 for_initializer to solve the problem of having out-of-band code
14653 emition (that is what got for broken).
14655 (declaration_statement): Perform the actual variable declaration
14656 that used to be done in local_variable_declaration here.
14658 (local_variable_declaration): Do not declare anything, just pass
14659 the information on a DictionaryEntry
14661 2001-11-20 Ravi Pratap <ravi@ximian.com>
14663 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
14664 re-write of the logic to now make it recursive.
14666 (UpdateIndices): Re-write accordingly.
14668 Store element data in a separate ArrayData list in the above methods.
14670 (MakeByteBlob): Implement to dump the array data into a byte array.
14672 2001-11-19 Ravi Pratap <ravi@ximian.com>
14674 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
14677 * constant.cs (Define): Implement.
14679 (EmitConstant): Re-write fully.
14681 Pass in location info.
14683 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
14686 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
14687 DictionaryEntry since we need location info too.
14689 (constant_declaration): Update accordingly.
14691 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
14692 code into another method : UpdateIndices.
14694 2001-11-18 Ravi Pratap <ravi@ximian.com>
14696 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
14697 some type checking etc.
14699 2001-11-17 Ravi Pratap <ravi@ximian.com>
14701 * expression.cs (ArrayCreation::ValidateInitializers): Implement
14702 bits to provide dimension info if the user skips doing that.
14704 Update second constructor to store the rank correctly.
14706 2001-11-16 Ravi Pratap <ravi@ximian.com>
14708 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
14709 and try to implement.
14711 * ../errors/cs0150.cs : Add.
14713 * ../errors/cs0178.cs : Add.
14715 2001-11-16 Miguel de Icaza <miguel@ximian.com>
14717 * statement.cs: Implement foreach on multi-dimensional arrays.
14719 * parameter.cs (Parameters.GetParameterByName): Also lookup the
14720 name of the params argument.
14722 * expression.cs: Use EmitStoreOpcode to get the right opcode while
14723 initializing the array.
14725 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
14726 we can use this elsewhere.
14728 * statement.cs: Finish implementation of foreach for single
14731 * cs-parser.jay: Use an out-of-band stack to pass information
14732 around, I wonder why I need this.
14734 foreach_block: Make the new foreach_block the current_block.
14736 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
14737 function used to return a static Parameters structure. Used for
14738 empty parameters, as those are created very frequently.
14740 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
14742 2001-11-15 Ravi Pratap <ravi@ximian.com>
14744 * interface.cs : Default modifier is private, not public. The
14745 make verify test passes again.
14747 2001-11-15 Ravi Pratap <ravi@ximian.com>
14749 * support.cs (ReflectionParameters): Fix logic to determine
14750 whether the last parameter is a params one. Test 9 passes again.
14752 * delegate.cs (Populate): Register the builders we define with
14753 RegisterParameterForBuilder. Test 19 passes again.
14755 * cs-parser.jay (property_declaration): Reference $6 instead
14756 of $$ to get at the location.
14758 (indexer_declaration): Similar stuff.
14760 (attribute): Ditto.
14762 * class.cs (Property): Register parameters for the Get and Set methods
14763 if they exist. Test 23 passes again.
14765 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
14766 call to EmitArguments as we are sure there aren't any params arguments.
14767 Test 32 passes again.
14769 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
14770 IndexOutOfRangeException.
14772 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
14773 Test 33 now passes again.
14775 2001-11-15 Miguel de Icaza <miguel@ximian.com>
14777 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
14778 broke a bunch of things. Will have to come up with a better way
14779 of tracking locations.
14781 * statement.cs: Implemented foreach for single dimension arrays.
14783 2001-11-09 Miguel de Icaza <miguel@ximian.com>
14785 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
14786 an error. This removes the lookup from the critical path.
14788 * cs-parser.jay: Removed use of temporary_loc, which is completely
14791 2001-11-14 Miguel de Icaza <miguel@ximian.com>
14793 * support.cs (ReflectionParameters.ParameterModifier): Report
14794 whether the argument is a PARAMS argument or not.
14796 * class.cs: Set the attribute `ParamArrayAttribute' on the
14797 parameter argument.
14799 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
14800 and cons_param_array_attribute (ConstructorInfo for
14801 ParamArrayAttribute).,
14803 * codegen.cs: Emit the return using the `Return' statement, that
14804 way we can report the error correctly for missing return values.
14806 * class.cs (Method.Emit): Clean up.
14808 * expression.cs (Argument.Resolve): Take another argument: the
14809 location where this argument is used. Notice that this is not
14810 part of the "Argument" class as to reduce the size of the
14811 structure (we know the approximate location anyways).
14813 Test if the argument is a variable-reference, if not, then
14814 complain with a 206.
14816 (Argument.Emit): Emit addresses of variables.
14818 (Argument.FullDesc): Simplify.
14820 (Invocation.DoResolve): Update for Argument.Resolve.
14822 (ElementAccess.DoResolve): ditto.
14824 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
14825 method should be virtual, as this method is always virtual.
14827 (NewDelegate.DoResolve): Update for Argument.Resolve.
14829 * class.cs (ConstructorInitializer.DoResolve): ditto.
14831 * attribute.cs (Attribute.Resolve): ditto.
14833 2001-11-13 Miguel de Icaza <miguel@ximian.com>
14835 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
14837 * expression.cs (ParameterReference): Drop IStackStorage and implement
14838 IAssignMethod instead.
14840 (LocalVariableReference): ditto.
14842 * ecore.cs (FieldExpr): Drop IStackStorage and implement
14843 IAssignMethod instead.
14845 2001-11-13 Miguel de Icaza <miguel@ximian.com>
14847 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
14848 enumerations that are used in heavily used structures derive from
14849 byte in a laughable and pathetic attempt to reduce memory usage.
14850 This is the kind of pre-optimzations that you should not do at
14851 home without adult supervision.
14853 * expression.cs (UnaryMutator): New class, used to handle ++ and
14854 -- separatedly from the other unary operators. Cleans up the
14855 code, and kills the ExpressionStatement dependency in Unary.
14857 (Unary): Removed `method' and `Arguments' from this class, making
14858 it smaller, and moving it all to SimpleCall, so I can reuse this
14859 code in other locations and avoid creating a lot of transient data
14860 strucutres when not required.
14862 * cs-parser.jay: Adjust for new changes.
14864 2001-11-11 Miguel de Icaza <miguel@ximian.com>
14866 * enum.cs (Enum.Populate): If there is a failure during
14869 * cs-parser.jay (opt_enum_base): we used to catch type errors
14870 here, but this is really incorrect. The type error should be
14871 catched during semantic analysis.
14873 2001-12-11 Ravi Pratap <ravi@ximian.com>
14875 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
14876 current_local_parameters as expected since I, in my stupidity, had forgotten
14879 * attribute.cs (GetValidPlaces): Fix stupid bug.
14881 * class.cs (Method::Emit): Perform check on applicability of attributes.
14883 (Constructor::Emit): Ditto.
14885 (Field::Emit): Ditto.
14887 (Field.Location): Store location information.
14889 (Property, Event, Indexer, Operator): Ditto.
14891 * cs-parser.jay (field_declaration): Pass in location for each field.
14893 * ../errors/cs0592.cs : Add.
14895 2001-11-12 Ravi Pratap <ravi@ximian.com>
14897 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
14899 (InitCoreTypes): Update accordingly.
14901 (RegisterAttrType, LookupAttr): Implement.
14903 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
14904 info about the same.
14906 (Resolve): Update to populate the above as necessary.
14908 (Error592): Helper.
14910 (GetValidPlaces): Helper to the above.
14912 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
14914 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
14916 2001-11-12 Ravi Pratap <ravi@ximian.com>
14918 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
14920 * ../errors/cs0617.cs : Add.
14922 2001-11-11 Ravi Pratap <ravi@ximian.com>
14924 * enum.cs (Emit): Rename to Populate to be more consistent with what
14925 we expect it to do and when exactly it is called.
14927 * class.cs, rootcontext.cs : Update accordingly.
14929 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
14930 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
14932 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
14934 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
14935 of a fieldinfo using the above, when dealing with a FieldBuilder.
14937 2001-11-10 Ravi Pratap <ravi@ximian.com>
14939 * ../errors/cs0031.cs : Add.
14941 * ../errors/cs1008.cs : Add.
14943 * ../errrors/cs0543.cs : Add.
14945 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
14948 (FindMembers): Implement.
14950 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
14951 enums and delegates too.
14953 (enum_types): Rename to builder_to_enum.
14955 (delegate_types): Rename to builder_to_delegate.
14957 * delegate.cs (FindMembers): Implement.
14959 2001-11-09 Ravi Pratap <ravi@ximian.com>
14961 * typemanager.cs (IsEnumType): Implement.
14963 * enum.cs (Emit): Re-write parts to account for the underlying type
14964 better and perform checking etc.
14966 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
14967 of the underlying type.
14969 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
14972 * enum.cs (error31): Helper to report error #31.
14974 * cs-parser.jay (enum_declaration): Store location of each member too.
14976 * enum.cs (member_to_location): New hashtable.
14978 (AddEnumMember): Update location hashtable.
14980 (Emit): Use the location of each member while reporting errors.
14982 2001-11-09 Miguel de Icaza <miguel@ximian.com>
14984 * cs-parser.jay: A for_initializer if is a
14985 local_variable_declaration really ammount to have an implicit
14986 block with the variable declaration and no initializer for for.
14988 * statement.cs (For.Emit): Cope with null initializers.
14990 This fixes the infinite loop on for initializers.
14992 2001-11-08 Miguel de Icaza <miguel@ximian.com>
14994 * enum.cs: More cleanup.
14996 * ecore.cs: Remove dead code.
14998 * class.cs (Property.Emit): More simplification.
14999 (Event.Emit): ditto.
15001 Reworked to have less levels of indentation.
15003 2001-11-08 Ravi Pratap <ravi@ximian.com>
15005 * class.cs (Property): Emit attributes.
15015 * enum.cs (Emit): Ditto.
15017 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
15020 * class.cs (Field, Event, etc.): Move attribute generation into the
15021 Emit method everywhere.
15023 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
15024 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
15025 as we had no way of defining nested enums !
15027 * rootcontext.cs : Adjust code accordingly.
15029 * typemanager.cs (AddEnumType): To keep track of enum types separately.
15031 2001-11-07 Ravi Pratap <ravi@ximian.com>
15033 * expression.cs (EvalConstantExpression): Move into ecore.cs
15035 * enum.cs (Enum): Rename some members and make them public and readonly
15036 according to our convention.
15038 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
15041 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
15043 (Enum::Emit): Write a simple version for now which doesn't try to compute
15044 expressions. I shall modify this to be more robust in just a while.
15046 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
15048 (TypeContainer::CloseType): Create the Enum types too.
15050 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
15052 * expression.cs (EvalConstantExpression): Get rid of completely.
15054 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
15055 user-defined values and other cases.
15057 (IsValidEnumLiteral): Helper function.
15059 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
15060 out there in the case we had a literal FieldExpr.
15062 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
15064 (Literalize): Revamp a bit to take two arguments.
15066 (EnumLiteral): New class which derives from Literal to wrap enum literals.
15068 2001-11-06 Ravi Pratap <ravi@ximian.com>
15070 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
15072 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
15074 (Resolve): Use the above to ensure we have proper initializers.
15076 2001-11-05 Ravi Pratap <ravi@ximian.com>
15078 * expression.cs (Expression::EvalConstantExpression): New method to
15079 evaluate constant expressions.
15081 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
15083 2001-11-07 Miguel de Icaza <miguel@ximian.com>
15085 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
15088 (Binary.ResolveOperator): Handle operator != (object a, object b)
15089 and operator == (object a, object b);
15091 (Binary.DoNumericPromotions): Indicate whether the numeric
15092 promotion was possible.
15094 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
15097 Made the ArrayAccess implement interface IAssignMethod instead of
15098 IStackStore as the order in which arguments are passed reflects
15101 * assign.cs: Instead of using expr.ExprClass to select the way of
15102 assinging, probe for the IStackStore/IAssignMethod interfaces.
15104 * typemanager.cs: Load InitializeArray definition.
15106 * rootcontext.cs (RootContext.MakeStaticData): Used to define
15107 static data that can be used to initialize arrays.
15109 2001-11-05 Miguel de Icaza <miguel@ximian.com>
15111 * expression.cs: Handle operator== and operator!= for booleans.
15113 (Conditioal.Reduce): Implement reducer for the ?: operator.
15115 (Conditional.Resolve): Implement dead code elimination.
15117 (Binary.Resolve): Catch string literals and return a new
15118 concatenated string.
15120 (Unary.Reduce): Implement reduction of unary expressions.
15122 * ecore.cs: Split out the expression core handling here.
15124 (Expression.Reduce): New method used to perform constant folding
15125 and CSE. This is needed to support constant-expressions.
15127 * statement.cs (Statement.EmitBoolExpression): Pass true and false
15128 targets, and optimize for !x.
15130 2001-11-04 Ravi Pratap <ravi@ximian.com>
15132 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
15133 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
15134 set custom atttributes.
15136 * literal.cs (Literal::GetValue): New abstract method to return the actual
15137 value of the literal, cast as an object.
15139 (*Literal): Implement GetValue method.
15141 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
15142 expressions to the arraylist but objects of type Argument.
15144 * class.cs (TypeContainer::Emit): Emit our attributes too.
15146 (Method::Emit, Constructor::Emit): Ditto.
15148 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
15149 to be ignoring earlier.
15151 2001-11-03 Ravi Pratap <ravi@ximian.com>
15153 * attribute.cs (AttributeSection::Define): Implement to do the business
15154 of constructing a CustomAttributeBuilder.
15156 (Attribute): New trivial class. Increases readability of code.
15158 * cs-parser.jay : Update accordingly.
15160 (positional_argument_list, named_argument_list, named_argument): New rules
15162 (attribute_arguments): Use the above so that we are more correct.
15164 2001-11-02 Ravi Pratap <ravi@ximian.com>
15166 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
15167 to perform all checks for a method with a params parameter.
15169 (Invocation::OverloadResolve): Update to use the above method and therefore
15170 cope correctly with params method invocations.
15172 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
15175 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
15176 constructors in our parent too because we can't afford to miss out on
15179 * attribute.cs (AttributeSection): New name for the class Attribute
15181 Other trivial changes to improve readability.
15183 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
15184 use the new class names.
15186 2001-11-01 Ravi Pratap <ravi@ximian.com>
15188 * class.cs (Method::Define): Complete definition for params types too
15190 (Indexer::Define): Ditto.
15192 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
15193 Cope everywhere with a request for info about the array parameter.
15195 2001-11-01 Ravi Pratap <ravi@ximian.com>
15197 * tree.cs (RecordNamespace): Fix up to check for the correct key.
15199 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
15200 local_variable_type to extract the string corresponding to the type.
15202 (local_variable_type): Fixup the action to use the new helper method.
15204 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
15207 * expression.cs : Clean out code which uses the above.
15209 2001-10-31 Ravi Pratap <ravi@ximian.com>
15211 * typemanager.cs (RegisterMethod): Check if we already have an existing key
15212 and bale out if necessary by returning a false.
15214 (RegisterProperty): Ditto.
15216 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
15217 and print out appropriate error messages.
15219 * interface.cs (everywhere): Ditto.
15221 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
15222 location to constructor.
15224 * class.cs (Property, Event, Indexer): Update accordingly.
15226 * ../errors/cs111.cs : Added.
15228 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
15229 of a method, as laid down by the spec.
15231 (Invocation::OverloadResolve): Use the above method.
15233 2001-10-31 Ravi Pratap <ravi@ximian.com>
15235 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
15236 now take a TypeContainer and a Parameters object.
15238 (ParameterData): Modify return type of ParameterModifier method to be
15239 Parameter.Modifier and not a string.
15241 (ReflectionParameters, InternalParameters): Update accordingly.
15243 * expression.cs (Argument::GetParameterModifier): Same here.
15245 * support.cs (InternalParameters::ParameterType): Find a better way of determining
15246 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
15247 symbol in it at all so maybe this is only for now.
15249 2001-10-30 Ravi Pratap <ravi@ximian.com>
15251 * support.cs (InternalParameters): Constructor now takes an extra argument
15252 which is the actual Parameters class.
15254 (ParameterDesc): Update to provide info on ref/out modifiers.
15256 * class.cs (everywhere): Update call to InternalParameters to pass in
15257 the second argument too.
15259 * support.cs (ParameterData): Add ParameterModifier, which is a method
15260 to return the modifier info [ref/out etc]
15262 (InternalParameters, ReflectionParameters): Implement the above.
15264 * expression.cs (Argument::ParameterModifier): Similar function to return
15265 info about the argument's modifiers.
15267 (Invocation::OverloadResolve): Update to take into account matching modifiers
15270 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
15271 a new SetFormalParameters object which we pass to InternalParameters.
15273 2001-10-30 Ravi Pratap <ravi@ximian.com>
15275 * expression.cs (NewArray): Merge into the ArrayCreation class.
15277 2001-10-29 Ravi Pratap <ravi@ximian.com>
15279 * expression.cs (NewArray): Merge classes NewBuiltinArray and
15280 NewUserdefinedArray into one as there wasn't much of a use in having
15283 * expression.cs (Argument): Change field's name to ArgType from Type.
15285 (Type): New readonly property which returns the proper type, taking into
15286 account ref/out modifiers.
15288 (everywhere): Adjust code accordingly for the above.
15290 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
15291 whether we are emitting for a ref or out parameter.
15293 * expression.cs (Argument::Emit): Use the above field to set the state.
15295 (LocalVariableReference::Emit): Update to honour the flag and emit the
15298 * parameter.cs (Attributes): Set the correct flags for ref parameters.
15300 * expression.cs (Argument::FullDesc): New function to provide a full desc.
15302 * support.cs (ParameterData): Add method ParameterDesc to the interface.
15304 (ReflectionParameters, InternalParameters): Implement the above method.
15306 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
15309 (Invocation::FullMethodDesc): Ditto.
15311 2001-10-29 Miguel de Icaza <miguel@ximian.com>
15313 * cs-parser.jay: Add extra production for the second form of array
15316 * expression.cs (ArrayCreation): Update to reflect the above
15319 * Small changes to prepare for Array initialization.
15321 2001-10-28 Miguel de Icaza <miguel@ximian.com>
15323 * typemanager.cs (ImplementsInterface): interface might be null;
15324 Deal with this problem;
15326 Also, we do store negative hits on the cache (null values), so use
15327 this instead of calling t.GetInterfaces on the type everytime.
15329 2001-10-28 Ravi Pratap <ravi@ximian.com>
15331 * typemanager.cs (IsBuiltinType): New method to help determine the same.
15333 * expression.cs (New::DoResolve): Get rid of array creation code and instead
15334 split functionality out into different classes.
15336 (New::FormArrayType): Move into NewBuiltinArray.
15338 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
15341 (NewBuiltinArray): New class to handle creation of built-in arrays.
15343 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
15344 account creation of one-dimensional arrays.
15346 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
15348 (NewUserdefinedArray::DoResolve): Implement.
15350 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
15352 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
15353 we maintain inside the TypeManager. This is necessary to perform lookups on the
15356 (LookupType): Update to perform GetType on the module builders too.
15358 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
15360 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
15362 2001-10-23 Ravi Pratap <ravi@ximian.com>
15364 * expression.cs (New::DoResolve): Implement guts of array creation.
15366 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
15368 2001-10-27 Miguel de Icaza <miguel@ximian.com>
15370 * expression.cs: Fix bug I introduced lsat night that broke
15373 (Expression.Resolve): Report a 246 error (can not resolve name)
15374 if we find a SimpleName in the stream.
15376 (Expression.ResolveLValue): Ditto.
15378 (Expression.ResolveWithSimpleName): This function is a variant of
15379 ResolveName, this one allows SimpleNames to be returned without a
15380 warning. The only consumer of SimpleNames is MemberAccess
15382 2001-10-26 Miguel de Icaza <miguel@ximian.com>
15384 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
15385 might arrive here. I have my doubts that this is correct.
15387 * statement.cs (Lock): Implement lock statement.
15389 * cs-parser.jay: Small fixes to support `lock' and `using'
15391 * cs-tokenizer.cs: Remove extra space
15393 * driver.cs: New flag --checked, allows to turn on integer math
15396 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
15397 Threading.Monitor.Exit
15399 2001-10-23 Miguel de Icaza <miguel@ximian.com>
15401 * expression.cs (IndexerAccess::DoResolveLValue): Set the
15402 Expression Class to be IndexerAccess.
15404 Notice that Indexer::DoResolve sets the eclass to Value.
15406 2001-10-22 Miguel de Icaza <miguel@ximian.com>
15408 * class.cs (TypeContainer::Emit): Emit code for indexers.
15410 * assign.cs (IAssignMethod): New interface implemented by Indexers
15411 and Properties for handling assignment.
15413 (Assign::Emit): Simplify and reuse code.
15415 * expression.cs (IndexerAccess, PropertyExpr): Implement
15416 IAssignMethod, clean up old code.
15418 2001-10-22 Ravi Pratap <ravi@ximian.com>
15420 * typemanager.cs (ImplementsInterface): New method to determine if a type
15421 implements a given interface. Provides a nice cache too.
15423 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
15426 (ConvertReferenceExplicit): Ditto.
15428 * delegate.cs (Delegate::Populate): Update to define the parameters on the
15429 various methods, with correct names etc.
15431 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
15432 Operator.UnaryNegation.
15434 * cs-parser.jay (operator_declarator): Be a little clever in the case where
15435 we have a unary plus or minus operator.
15437 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
15440 * everywhere : update accordingly.
15442 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
15445 * class.cs (Method::Define): For the case where we are implementing a method
15446 inherited from an interface, we need to set the MethodAttributes.Final flag too.
15447 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
15449 2001-10-21 Ravi Pratap <ravi@ximian.com>
15451 * interface.cs (FindMembers): Implement to work around S.R.E
15454 * typemanager.cs (IsInterfaceType): Implement.
15456 (FindMembers): Update to handle interface types too.
15458 * expression.cs (ImplicitReferenceConversion): Re-write bits which
15459 use IsAssignableFrom as that is not correct - it doesn't work.
15461 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
15462 and accordingly override EmitStatement.
15464 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
15465 using the correct logic :-)
15467 2001-10-19 Ravi Pratap <ravi@ximian.com>
15469 * ../errors/cs-11.cs : Add to demonstrate error -11
15471 2001-10-17 Miguel de Icaza <miguel@ximian.com>
15473 * assign.cs (Assign::Resolve): Resolve right hand side first, and
15474 then pass this as a hint to ResolveLValue.
15476 * expression.cs (FieldExpr): Add Location information
15478 (FieldExpr::LValueResolve): Report assignment to readonly
15481 (Expression::ExprClassFromMemberInfo): Pass location information.
15483 (Expression::ResolveLValue): Add new method that resolves an
15486 (Expression::DoResolveLValue): Default invocation calls
15489 (Indexers): New class used to keep track of indexers in a given
15492 (IStackStore): Renamed from LValue, as it did not really describe
15493 what this did. Also ResolveLValue is gone from this interface and
15494 now is part of Expression.
15496 (ElementAccess): Depending on the element access type
15498 * typemanager.cs: Add `indexer_name_type' as a Core type
15499 (System.Runtime.CompilerServices.IndexerNameAttribute)
15501 * statement.cs (Goto): Take a location.
15503 2001-10-18 Ravi Pratap <ravi@ximian.com>
15505 * delegate.cs (Delegate::VerifyDelegate): New method to verify
15506 if two delegates are compatible.
15508 (NewDelegate::DoResolve): Update to take care of the case when
15509 we instantiate a delegate from another delegate.
15511 * typemanager.cs (FindMembers): Don't even try to look up members
15512 of Delegate types for now.
15514 2001-10-18 Ravi Pratap <ravi@ximian.com>
15516 * delegate.cs (NewDelegate): New class to take care of delegate
15519 * expression.cs (New): Split the delegate related code out into
15520 the NewDelegate class.
15522 * delegate.cs (DelegateInvocation): New class to handle delegate
15525 * expression.cs (Invocation): Split out delegate related code into
15526 the DelegateInvocation class.
15528 2001-10-17 Ravi Pratap <ravi@ximian.com>
15530 * expression.cs (New::DoResolve): Implement delegate creation fully
15531 and according to the spec.
15533 (New::DoEmit): Update to handle delegates differently.
15535 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
15536 because of which we were printing out arguments in reverse order !
15538 * delegate.cs (VerifyMethod): Implement to check if the given method
15539 matches the delegate.
15541 (FullDelegateDesc): Implement.
15543 (VerifyApplicability): Implement.
15545 * expression.cs (Invocation::DoResolve): Update to accordingly handle
15546 delegate invocations too.
15548 (Invocation::Emit): Ditto.
15550 * ../errors/cs1593.cs : Added.
15552 * ../errors/cs1594.cs : Added.
15554 * delegate.cs (InstanceExpression, TargetMethod): New properties.
15556 2001-10-16 Ravi Pratap <ravi@ximian.com>
15558 * typemanager.cs (intptr_type): Core type for System.IntPtr
15560 (InitCoreTypes): Update for the same.
15562 (iasyncresult_type, asynccallback_type): Ditto.
15564 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
15567 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
15570 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
15571 the builders for the 4 members of a delegate type :-)
15573 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
15576 * expression.cs (New::DoResolve): Implement guts for delegate creation.
15578 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
15580 2001-10-15 Miguel de Icaza <miguel@ximian.com>
15582 * statement.cs (Break::Emit): Implement.
15583 (Continue::Emit): Implement.
15585 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
15586 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
15587 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
15588 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
15591 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
15592 properties that track the label for the current loop (begin of the
15593 loop and end of the loop).
15595 2001-10-15 Ravi Pratap <ravi@ximian.com>
15597 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
15598 use of emitting anything at all.
15600 * class.cs, rootcontext.cs : Get rid of calls to the same.
15602 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
15604 (Populate): Define the constructor correctly and set the implementation
15607 * typemanager.cs (delegate_types): New hashtable to hold delegates that
15610 (AddDelegateType): Implement.
15612 (IsDelegateType): Implement helper method.
15614 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
15616 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
15617 and accordingly handle it.
15619 * delegate.cs (Populate): Take TypeContainer argument.
15620 Implement bits to define the Invoke method. However, I still haven't figured out
15621 how to take care of the native int bit :-(
15623 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
15624 Qualify the name of the delegate, not its return type !
15626 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
15629 (StandardConversionExists): Checking for array types turns out to be recursive.
15631 (ConvertReferenceExplicit): Implement array conversion.
15633 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
15635 2001-10-12 Ravi Pratap <ravi@ximian.com>
15637 * cs-parser.jay (delegate_declaration): Store the fully qualified
15638 name as it is a type declaration.
15640 * delegate.cs (ReturnType, Name): Rename members to these. Make them
15643 (DefineDelegate): Renamed from Define. Does the same thing essentially,
15644 as TypeContainer::DefineType.
15646 (Populate): Method in which all the definition of the various methods (Invoke)
15649 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
15652 (CloseDelegate): Finally creates the delegate.
15654 * class.cs (TypeContainer::DefineType): Update to define delegates.
15655 (Populate, Emit and CloseType): Do the same thing here too.
15657 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
15658 delegates in all these operations.
15660 2001-10-14 Miguel de Icaza <miguel@ximian.com>
15662 * expression.cs: LocalTemporary: a new expression used to
15663 reference a temporary that has been created.
15665 * assign.cs: Handle PropertyAccess back here, so that we can
15666 provide the proper semantic access to properties.
15668 * expression.cs (Expression::ConvertReferenceExplicit): Implement
15669 a few more explicit conversions.
15671 * modifiers.cs: `NEW' modifier maps to HideBySig.
15673 * expression.cs (PropertyExpr): Make this into an
15674 ExpressionStatement, and support the EmitStatement code path.
15676 Perform get/set error checking, clean up the interface.
15678 * assign.cs: recognize PropertyExprs as targets, and if so, turn
15679 them into toplevel access objects.
15681 2001-10-12 Miguel de Icaza <miguel@ximian.com>
15683 * expression.cs: PropertyExpr::PropertyExpr: use work around the
15686 * typemanager.cs: Keep track here of our PropertyBuilders again to
15687 work around lameness in SRE.
15689 2001-10-11 Miguel de Icaza <miguel@ximian.com>
15691 * expression.cs (LValue::LValueResolve): New method in the
15692 interface, used to perform a second resolution pass for LValues.
15694 (This::DoResolve): Catch the use of this in static methods.
15696 (This::LValueResolve): Implement.
15698 (This::Store): Remove warning, assigning to `this' in structures
15701 (Invocation::Emit): Deal with invocation of
15702 methods on value types. We need to pass the address to structure
15703 methods rather than the object itself. (The equivalent code to
15704 emit "this" for structures leaves the entire structure on the
15705 stack instead of a pointer to it).
15707 (ParameterReference::DoResolve): Compute the real index for the
15708 argument based on whether the method takes or not a `this' pointer
15709 (ie, the method is static).
15711 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
15712 value types returned from functions when we need to invoke a
15713 method on the sturcture.
15716 2001-10-11 Ravi Pratap <ravi@ximian.com>
15718 * class.cs (TypeContainer::DefineType): Method to actually do the business of
15719 defining the type in the Modulebuilder or Typebuilder. This is to take
15720 care of nested types which need to be defined on the TypeBuilder using
15721 DefineNestedMethod.
15723 (TypeContainer::GetClassBases): Implement. Essentially the code from the
15724 methods in RootContext, only ported to be part of TypeContainer.
15726 (TypeContainer::GetInterfaceOrClass): Ditto.
15728 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
15730 * interface.cs (Interface::DefineInterface): New method. Does exactly
15731 what RootContext.CreateInterface did earlier, only it takes care of nested types
15734 (Interface::GetInterfaces): Move from RootContext here and port.
15736 (Interface::GetInterfaceByName): Same here.
15738 * rootcontext.cs (ResolveTree): Re-write.
15740 (PopulateTypes): Re-write.
15742 * class.cs (TypeContainer::Populate): Populate nested types too.
15743 (TypeContainer::Emit): Emit nested members too.
15745 * typemanager.cs (AddUserType): Do not make use of the FullName property,
15746 instead just use the name argument passed in as it is already fully
15749 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
15750 to TypeContainer mapping to see if a type is user-defined.
15752 * class.cs (TypeContainer::CloseType): Implement.
15754 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
15755 the default constructor.
15757 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
15760 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
15762 * interface.cs (CloseType): Create the type here.
15764 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
15767 Remove all the methods which are now in TypeContainer.
15769 2001-10-10 Ravi Pratap <ravi@ximian.com>
15771 * delegate.cs (Define): Re-write bits to define the delegate
15774 2001-10-10 Miguel de Icaza <miguel@ximian.com>
15776 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
15778 * expression.cs (ImplicitReferenceConversion): handle null as well
15779 as a source to convert to any reference type.
15781 * statement.cs (Return): Perform any implicit conversions to
15782 expected return type.
15784 Validate use of return statement.
15786 * codegen.cs (EmitContext): Pass the expected return type here.
15788 * class.cs (Method, Constructor, Property): Pass expected return
15789 type to EmitContext.
15791 2001-10-09 Miguel de Icaza <miguel@ximian.com>
15793 * expression.cs: Make DoResolve take an EmitContext instead of a
15796 Replaced `l' and `location' for `loc', for consistency.
15798 (Error, Warning): Remove unneeded Tc argument.
15800 * assign.cs, literal.cs, constant.cs: Update to new calling
15803 * codegen.cs: EmitContext now contains a flag indicating whether
15804 code is being generated in a static method or not.
15806 * cs-parser.jay: DecomposeQI, new function that replaces the old
15807 QualifiedIdentifier. Now we always decompose the assembled
15808 strings from qualified_identifier productions into a group of
15811 2001-10-08 Miguel de Icaza <miguel@ximian.com>
15813 * rootcontext.cs: Deal with field-less struct types correctly now
15814 by passing the size option to Define Type.
15816 * class.cs: Removed hack that created one static field.
15818 2001-10-07 Miguel de Icaza <miguel@ximian.com>
15820 * statement.cs: Moved most of the code generation here.
15822 2001-10-09 Ravi Pratap <ravi@ximian.com>
15824 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
15827 (ElementAccess): Remove useless bits for now - keep checks as the spec
15830 2001-10-08 Ravi Pratap <ravi@ximian.com>
15832 * expression.cs (ElementAccess::DoResolve): Remove my crap code
15833 and start performing checks according to the spec.
15835 2001-10-07 Ravi Pratap <ravi@ximian.com>
15837 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
15838 rank_specifiers instead.
15840 (rank_specifiers): Change the order in which the rank specifiers are stored
15842 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
15844 * expression.cs (ElementAccess): Implement the LValue interface too.
15846 2001-10-06 Ravi Pratap <ravi@ximian.com>
15848 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
15849 except that user defined conversions are not included.
15851 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
15852 perform the conversion of the return type, if necessary.
15854 (New::DoResolve): Check whether we are creating an array or an object
15855 and accordingly do the needful.
15857 (New::Emit): Same here.
15859 (New::DoResolve): Implement guts of array creation.
15861 (New::FormLookupType): Helper function.
15863 2001-10-07 Miguel de Icaza <miguel@ximian.com>
15865 * codegen.cs: Removed most of the code generation here, and move the
15866 corresponding code generation bits to the statement classes.
15868 Added support for try/catch/finalize and throw.
15870 * cs-parser.jay: Added support for try/catch/finalize.
15872 * class.cs: Catch static methods having the flags override,
15873 virtual or abstract.
15875 * expression.cs (UserCast): This user cast was not really doing
15876 what it was supposed to do. Which is to be born in fully resolved
15877 state. Parts of the resolution were being performed at Emit time!
15881 2001-10-05 Miguel de Icaza <miguel@ximian.com>
15883 * expression.cs: Implicity convert the result from UserCast.
15885 2001-10-05 Ravi Pratap <ravi@ximian.com>
15887 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
15888 prevented it from working correctly.
15890 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
15891 merely ConvertImplicit.
15893 2001-10-05 Miguel de Icaza <miguel@ximian.com>
15895 * typemanager.cs: Make the LookupTypeContainer function static,
15896 and not per-instance.
15898 * class.cs: Make static FindMembers (the one that takes a Type
15901 * codegen.cs: Add EmitForeach here.
15903 * cs-parser.jay: Make foreach a toplevel object instead of the
15904 inline expansion, as we need to perform semantic analysis on it.
15906 2001-10-05 Ravi Pratap <ravi@ximian.com>
15908 * expression.cs (Expression::ImplicitUserConversion): Rename to
15909 UserDefinedConversion.
15911 (Expression::UserDefinedConversion): Take an extra argument specifying
15912 whether we look for explicit user conversions too.
15914 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
15916 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
15918 (ExplicitUserConversion): Make it a call to UserDefinedConversion
15919 with the appropriate arguments.
15921 * cs-parser.jay (cast_expression): Record location too.
15923 * expression.cs (Cast): Record location info.
15925 (Expression::ConvertExplicit): Take location argument.
15927 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
15928 to determine if we are doing explicit conversions.
15930 (UserCast::Emit): Update accordingly.
15932 (Expression::ConvertExplicit): Report an error if everything fails.
15934 * ../errors/cs0030.cs : Add.
15936 2001-10-04 Miguel de Icaza <miguel@ximian.com>
15938 * modifiers.cs: If the ABSTRACT keyword is present, also set the
15939 virtual and newslot bits.
15941 * class.cs (TypeContainer::RegisterRequiredImplementations):
15942 Record methods we need.
15944 (TypeContainer::MakeKey): Helper function to make keys for
15945 MethodBases, since the Methodbase key is useless.
15947 (TypeContainer::Populate): Call RegisterRequiredImplementations
15948 before defining the methods.
15950 Create a mapping for method_builders_to_methods ahead of time
15951 instead of inside a tight loop.
15953 (::RequireMethods): Accept an object as the data to set into the
15954 hashtable so we can report interface vs abstract method mismatch.
15956 2001-10-03 Miguel de Icaza <miguel@ximian.com>
15958 * report.cs: Make all of it static.
15960 * rootcontext.cs: Drop object_type and value_type computations, as
15961 we have those in the TypeManager anyways.
15963 Drop report instance variable too, now it is a global.
15965 * driver.cs: Use try/catch on command line handling.
15967 Add --probe option to debug the error reporting system with a test
15970 * report.cs: Add support for exiting program when a probe
15971 condition is reached.
15973 2001-10-03 Ravi Pratap <ravi@ximian.com>
15975 * expression.cs (Binary::DoNumericPromotions): Fix the case when
15976 we do a forcible conversion regardless of type, to check if
15977 ForceConversion returns a null.
15979 (Binary::error19): Use location to report error.
15981 (Unary::error23): Use location here too.
15983 * ../errors/cs0019.cs : Check in.
15985 * ../errors/cs0023.cs : Check in.
15987 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
15988 case of a non-null MethodInfo object with a length of 0 !
15990 (Binary::ResolveOperator): Flag error if overload resolution fails to find
15991 an applicable member - according to the spec :-)
15992 Also fix logic to find members in base types.
15994 (Unary::ResolveOperator): Same here.
15996 (Unary::report23): Change name to error23 and make first argument a TypeContainer
15997 as I was getting thoroughly confused between this and error19 :-)
15999 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
16000 (::FindMostEncompassedType): Implement.
16001 (::FindMostEncompassingType): Implement.
16002 (::StandardConversionExists): Implement.
16004 (UserImplicitCast): Re-vamp. We now need info about most specific
16005 source and target types so that we can do the necessary conversions.
16007 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
16008 mathematical union with no duplicates.
16010 2001-10-03 Miguel de Icaza <miguel@ximian.com>
16012 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
16013 in order from base classes to child classes, so that we can in
16014 child classes look up in our parent for method names and
16015 attributes (required for handling abstract, virtual, new, override
16016 constructs: we need to instrospect our base class, and if we dont
16017 populate the classes in order, the introspection might be
16018 incorrect. For example, a method could query its parent before
16019 the parent has any methods and would determine that the parent has
16020 no abstract methods (while it could have had them)).
16022 (RootContext::CreateType): Record the order in which we define the
16025 2001-10-02 Miguel de Icaza <miguel@ximian.com>
16027 * class.cs (TypeContainer::Populate): Also method definitions can
16028 fail now, keep track of this.
16030 (TypeContainer::FindMembers): Implement support for
16031 DeclaredOnly/noDeclaredOnly flag.
16033 (Constructor::Emit) Return the ConstructorBuilder.
16035 (Method::Emit) Return the MethodBuilder.
16036 Check for abstract or virtual methods to be public.
16038 * rootcontext.cs (RootContext::CreateType): Register all the
16039 abstract methods required for the class to be complete and the
16040 interface methods that must be implemented.
16042 * cs-parser.jay: Report error 501 (method requires body if it is
16043 not marked abstract or extern).
16045 * expression.cs (TypeOf::Emit): Implement.
16047 * typemanager.cs: runtime_handle_type, new global type.
16049 * class.cs (Property::Emit): Generate code for properties.
16051 2001-10-02 Ravi Pratap <ravi@ximian.com>
16053 * expression.cs (Unary::ResolveOperator): Find operators on base type
16054 too - we now conform exactly to the spec.
16056 (Binary::ResolveOperator): Same here.
16058 * class.cs (Operator::Define): Fix minor quirk in the tests.
16060 * ../errors/cs0215.cs : Added.
16062 * ../errors/cs0556.cs : Added.
16064 * ../errors/cs0555.cs : Added.
16066 2001-10-01 Miguel de Icaza <miguel@ximian.com>
16068 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
16069 single integer which is really efficient
16071 2001-10-01 Ravi Pratap <ravi@ximian.com>
16073 * expression.cs (Expression::ImplicitUserConversion): Use location
16074 even in the case when we are examining True operators.
16076 * class.cs (Operator::Define): Perform extensive checks to conform
16077 with the rules for operator overloading in the spec.
16079 * expression.cs (Expression::ImplicitReferenceConversion): Implement
16080 some of the other conversions mentioned in the spec.
16082 * typemanager.cs (array_type): New static member for the System.Array built-in
16085 (cloneable_interface): For System.ICloneable interface.
16087 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
16088 we start resolving the tree and populating types.
16090 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
16092 2001-10-01 Miguel de Icaza <miguel@ximian.com>
16094 * expression.cs (Expression::ExprClassFromMemberInfo,
16095 Expression::Literalize): Create literal expressions from
16096 FieldInfos which are literals.
16098 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
16099 type casts, because they were wrong. The test suite in tests
16102 (ImplicitNumericConversion): ushort to ulong requires a widening
16105 Int32 constant to long requires widening cast as well.
16107 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
16108 for integers because the type on the stack is not i4.
16110 2001-09-30 Miguel de Icaza <miguel@ximian.com>
16112 * expression.cs (report118): require location argument.
16114 * parameter.cs: Do not dereference potential null value.
16116 * class.cs: Catch methods that lack the `new' keyword when
16117 overriding a name. Report warnings when `new' is used without
16118 anything being there to override.
16120 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
16122 * class.cs: Only add constructor to hashtable if it is non-null
16123 (as now constructors can fail on define).
16125 (TypeManager, Class, Struct): Take location arguments.
16127 Catch field instance initialization in structs as errors.
16129 accepting_filter: a new filter for FindMembers that is static so
16130 that we dont create an instance per invocation.
16132 (Constructor::Define): Catch errors where a struct constructor is
16135 * cs-parser.jay: Pass location information for various new
16138 * delegate.cs (Delegate): take a location argument.
16140 * driver.cs: Do not call EmitCode if there were problesm in the
16141 Definition of the types, as many Builders wont be there.
16143 * decl.cs (Decl::Decl): Require a location argument.
16145 * cs-tokenizer.cs: Handle properly hex constants that can not fit
16146 into integers, and find the most appropiate integer for it.
16148 * literal.cs: Implement ULongLiteral.
16150 * rootcontext.cs: Provide better information about the location of
16151 failure when CreateType fails.
16153 2001-09-29 Miguel de Icaza <miguel@ximian.com>
16155 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
16158 * expression.cs (Binary::CheckShiftArguments): Add missing type
16160 (Binary::ResolveOperator): Add type to the logical and and logical
16161 or, Bitwise And/Or and Exclusive Or code paths, it was missing
16164 (Binary::DoNumericPromotions): In the case where either argument
16165 is ulong (and most signed types combined with ulong cause an
16166 error) perform implicit integer constant conversions as well.
16168 2001-09-28 Miguel de Icaza <miguel@ximian.com>
16170 * expression.cs (UserImplicitCast): Method should always be
16172 (Invocation::BetterConversion): Simplified test for IntLiteral.
16174 (Expression::ImplicitNumericConversion): Split this routine out.
16175 Put the code that performs implicit constant integer conversions
16178 (Expression::Resolve): Become a wrapper around DoResolve so we can
16179 check eclass and type being set after resolve.
16181 (Invocation::Badness): Remove this dead function
16183 (Binary::ResolveOperator): Do not compute the expensive argumnets
16184 unless we have a union for it.
16186 (Probe::Emit): Is needs to do an isinst and then
16187 compare against null.
16189 (::CanConvert): Added Location argument. If the Location argument
16190 is null (Location.Null), then we do not report errors. This is
16191 used by the `probe' mechanism of the Explicit conversion. We do
16192 not want to generate an error for something that the user
16193 explicitly requested to be casted. But the pipeline for an
16194 explicit cast first tests for potential implicit casts.
16196 So for now, if the Location is null, it means `Probe only' to
16197 avoid adding another argument. Might have to revise this
16200 (ClassCast): New class used to type cast objects into arbitrary
16201 classes (used in Explicit Reference Conversions).
16203 Implement `as' as well.
16205 Reverted all the patches from Ravi below: they were broken:
16207 * The use of `level' as a mechanism to stop recursive
16208 invocations is wrong. That was there just to catch the
16209 bug with a strack trace but not as a way of addressing
16212 To fix the problem we have to *understand* what is going
16213 on and the interactions and come up with a plan, not
16214 just get things going.
16216 * The use of the type conversion cache that I proposed
16217 last night had an open topic: How does this work across
16218 protection domains. A user defined conversion might not
16219 be public in the location where we are applying the
16220 conversion, a different conversion might be selected
16221 (ie, private A->B (better) but public B->A (worse),
16222 inside A, A->B applies, but outside it, B->A will
16225 * On top of that (ie, even if the above is solved),
16226 conversions in a cache need to be abstract. Ie, `To
16227 convert from an Int to a Short use an OpcodeCast', not
16228 `To convert from an Int to a Short use the OpcodeCast on
16229 the variable 5' (which is what this patch was doing).
16231 2001-09-28 Ravi Pratap <ravi@ximian.com>
16233 * expression.cs (Invocation::ConversionExists): Re-write to use
16234 the conversion cache
16236 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
16237 cache all conversions done, not just user-defined ones.
16239 (Invocation::BetterConversion): The real culprit. Use ConversionExists
16240 to determine if a conversion exists instead of acutually trying to
16241 perform the conversion. It's faster too.
16243 (Expression::ConvertExplicit): Modify to use ConversionExists to check
16244 and only then attempt the implicit conversion.
16246 2001-09-28 Ravi Pratap <ravi@ximian.com>
16248 * expression.cs (ConvertImplicit): Use a cache for conversions
16249 already found. Check level of recursion and bail out if necessary.
16251 2001-09-28 Miguel de Icaza <miguel@ximian.com>
16253 * typemanager.cs (string_concat_string_string, string_concat_object_object):
16254 Export standard methods that we expect for string operations.
16256 * statement.cs (Block::UsageWarning): Track usage of variables and
16257 report the errors for not used variables.
16259 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
16262 2001-09-27 Miguel de Icaza <miguel@ximian.com>
16264 * codegen.cs: remove unnneded code
16266 * expression.cs: Removed BuiltinTypeAccess class
16268 Fix the order in which implicit conversions are
16271 The previous fixed dropped support for boxed conversions (adding a
16272 test to the test suite now)
16274 (UserImplicitCast::CanConvert): Remove test for source being null,
16275 that code is broken. We should not feed a null to begin with, if
16276 we do, then we should track the bug where the problem originates
16277 and not try to cover it up here.
16279 Return a resolved expression of type UserImplicitCast on success
16280 rather than true/false. Ravi: this is what I was talking about,
16281 the pattern is to use a static method as a "constructor" for
16284 Also, do not create arguments until the very last minute,
16285 otherwise we always create the arguments even for lookups that
16286 will never be performed.
16288 (UserImplicitCast::Resolve): Eliminate, objects of type
16289 UserImplicitCast are born in a fully resolved state.
16291 * typemanager.cs (InitCoreTypes): Init also value_type
16292 (System.ValueType).
16294 * expression.cs (Cast::Resolve): First resolve the child expression.
16296 (LValue): Add new method AddressOf to be used by
16299 Change the argument of Store to take an EmitContext instead of an
16300 ILGenerator, because things like FieldExpr need to be able to call
16301 their children expression to generate the instance code.
16303 (Expression::Error, Expression::Warning): Sugar functions for
16306 (Expression::MemberLookup): Accept a TypeContainer instead of a
16307 Report as the first argument.
16309 (Expression::ResolvePrimary): Killed. I still want to improve
16310 this as currently the code is just not right.
16312 (Expression::ResolveMemberAccess): Simplify, but it is still
16315 (Unary::Resolve): Catch errors in AddressOf operators.
16317 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
16318 index to a byte for the short-version, or the compiler will choose
16319 the wrong Emit call, which generates the wrong data.
16321 (ParameterReference::Emit, ::Store): same.
16323 (FieldExpr::AddressOf): Implement.
16325 * typemanager.cs: TypeManager: made public variable instead of
16328 * driver.cs: document --fatal.
16330 * report.cs (ErrorMessage, WarningMessage): new names for the old
16331 Error and Warning classes.
16333 * cs-parser.jay (member_access): Turn built-in access to types
16334 into a normal simplename
16336 2001-09-27 Ravi Pratap <ravi@ximian.com>
16338 * expression.cs (Invocation::BetterConversion): Fix to cope
16339 with q being null, since this was introducing a bug.
16341 * expression.cs (ConvertImplicit): Do built-in conversions first.
16343 2001-09-27 Ravi Pratap <ravi@ximian.com>
16345 * expression.cs (UserImplicitCast::Resolve): Fix bug.
16347 2001-09-27 Ravi Pratap <ravi@ximian.com>
16349 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
16350 I had introduced long ago (what's new ?).
16352 * expression.cs (UserImplicitCast::CanConvert): Static method to do
16353 the work of all the checking.
16354 (ConvertImplicit): Call CanConvert and only then create object if necessary.
16355 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
16357 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
16358 that is the right way.
16360 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
16361 overloading resolution. Use everywhere instead of cutting and pasting code.
16363 (Binary::ResolveOperator): Use MakeUnionSet.
16365 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
16366 we have to convert to bool types. Not complete yet.
16368 2001-09-27 Miguel de Icaza <miguel@ximian.com>
16370 * typemanager.cs (TypeManager::CSharpName): support ushort.
16372 * expression.cs (Expression::TryImplicitIntConversion): Attempts
16373 to provide an expression that performsn an implicit constant int
16374 conversion (section 6.1.6).
16375 (Expression::ConvertImplicitRequired): Reworked to include
16376 implicit constant expression conversions.
16378 (Expression::ConvertNumericExplicit): Finished.
16380 (Invocation::Emit): If InstanceExpression is null, then it means
16381 that we perform a call on this.
16383 2001-09-26 Miguel de Icaza <miguel@ximian.com>
16385 * expression.cs (Unary::Emit): Remove some dead code.
16386 (Probe): Implement Resolve and Emit for `is'.
16387 (Expression::ConvertImplicitRequired): Attempt to do constant
16388 expression conversions here. Maybe should be moved to
16389 ConvertImplicit, but I am not sure.
16390 (Expression::ImplicitLongConstantConversionPossible,
16391 Expression::ImplicitIntConstantConversionPossible): New functions
16392 that tell whether is it possible to apply an implicit constant
16393 expression conversion.
16395 (ConvertNumericExplicit): Started work on explicit numeric
16398 * cs-parser.jay: Update operator constants.
16400 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
16401 (Parameters::GetSignature): Hook up VerifyArgs here.
16402 (Parameters::VerifyArgs): Verifies that no two arguments have the
16405 * class.cs (Operator): Update the operator names to reflect the
16406 ones that the spec expects (as we are just stringizing the
16409 * expression.cs (Unary::ResolveOperator): Fix bug: Use
16410 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
16411 previous usage did only work for our methods.
16412 (Expression::ConvertImplicit): Handle decimal implicit numeric
16413 conversions as well.
16414 (Expression::InternalTypeConstructor): Used to invoke constructors
16415 on internal types for default promotions.
16417 (Unary::Emit): Implement special handling for the pre/post
16418 increment/decrement for overloaded operators, as they need to have
16419 the same semantics as the other operators.
16421 (Binary::ResolveOperator): ditto.
16422 (Invocation::ConversionExists): ditto.
16423 (UserImplicitCast::Resolve): ditto.
16425 2001-09-26 Ravi Pratap <ravi@ximian.com>
16427 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
16428 operator, return after emitting body. Regression tests pass again !
16430 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
16431 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
16432 (Invocation::OverloadResolve): Ditto.
16433 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
16435 * everywhere : update calls to the above methods accordingly.
16437 2001-09-26 Miguel de Icaza <miguel@ximian.com>
16439 * assign.cs (Assign): Make it inherit from ExpressionStatement.
16441 * expression.cs (ExpressionStatement): New base class used for
16442 expressions that can appear in statements, so that we can provide
16443 an alternate path to generate expression that do not leave a value
16446 (Expression::Emit, and all the derivatives): We no longer return
16447 whether a value is left on the stack or not. Every expression
16448 after being emitted leaves a single value on the stack.
16450 * codegen.cs (EmitContext::EmitStatementExpression): Use the
16451 facilties of ExpressionStatement if possible.
16453 * cs-parser.jay: Update statement_expression.
16455 2001-09-25 Miguel de Icaza <miguel@ximian.com>
16457 * driver.cs: Change the wording of message
16459 2001-09-25 Ravi Pratap <ravi@ximian.com>
16461 * expression.cs (Binary::ResolveOperator): Had forgottten to set
16462 the type of the expression to the return type of the method if
16463 we have an overloaded operator match ! The regression tests pass again !
16464 (Unary::ResolveOperator): Ditto.
16466 * expression.cs (Invocation::ConversionExists): Correct the member lookup
16467 to find "op_Implicit", not "implicit" ;-)
16468 (UserImplicitCast): New class to take care of user-defined implicit conversions.
16469 (ConvertImplicit, ForceConversion): Take TypeContainer argument
16471 * everywhere : Correct calls to the above accordingly.
16473 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
16474 (ConvertImplicit): Do user-defined conversion if it exists.
16476 2001-09-24 Miguel de Icaza <miguel@ximian.com>
16478 * assign.cs: track location.
16479 (Resolve): Use implicit conversions on assignment.
16481 * literal.cs: Oops. Not good, Emit of short access values should
16482 pass (Bytes) or the wrong argument will be selected.
16484 * expression.cs (Unary::Emit): Emit code for -expr.
16486 (Unary::ResolveOperator): Handle `Substract' for non-constants
16487 (substract from zero from the non-constants).
16488 Deal with Doubles as well.
16490 (Expression::ConvertImplicitRequired): New routine that reports an
16491 error if no implicit conversion exists.
16493 (Invocation::OverloadResolve): Store the converted implicit
16494 expressions if we make them
16496 2001-09-24 Ravi Pratap <ravi@ximian.com>
16498 * class.cs (ConstructorInitializer): Take a Location argument.
16499 (ConstructorBaseInitializer): Same here.
16500 (ConstructorThisInitializer): Same here.
16502 * cs-parser.jay : Update all calls accordingly.
16504 * expression.cs (Unary, Binary, New): Take location argument.
16505 Update accordingly everywhere.
16507 * cs-parser.jay : Update all calls to the above to take a location
16510 * class.cs : Ditto.
16512 2001-09-24 Ravi Pratap <ravi@ximian.com>
16514 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
16515 (Invocation::BetterConversion): Same here
16516 (Invocation::ConversionExists): Ditto.
16518 (Invocation::ConversionExists): Implement.
16520 2001-09-22 Ravi Pratap <ravi@ximian.com>
16522 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
16523 Also take an additional TypeContainer argument.
16525 * All over : Pass in TypeContainer as argument to OverloadResolve.
16527 * typemanager.cs (CSharpName): Update to check for the string type and return
16530 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
16533 2001-09-21 Ravi Pratap <ravi@ximian.com>
16535 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
16536 (Invocation::BetterFunction): Implement.
16537 (Invocation::BetterConversion): Implement.
16538 (Invocation::ConversionExists): Skeleton, no implementation yet.
16540 Okay, things work fine !
16542 2001-09-21 Miguel de Icaza <miguel@ximian.com>
16544 * typemanager.cs: declare and load enum_type, delegate_type and
16547 * expression.cs (Expression::Emit): Now emit returns a value that
16548 tells whether a value is left on the stack or not. This strategy
16549 might be reveted tomorrow with a mechanism that would address
16550 multiple assignments.
16551 (Expression::report118): Utility routine to report mismatches on
16554 (Unary::Report23): Report impossible type/operator combination
16557 (Unary::IsIncrementableNumber): Whether the type can be
16558 incremented or decremented with add.
16559 (Unary::ResolveOperator): Also allow enumerations to be bitwise
16561 (Unary::ResolveOperator): Implement ++, !, ~,
16563 (Invocation::Emit): Deal with new Emit convetion.
16565 * All Expression derivatives: Updated their Emit method to return
16566 whether they leave values on the stack or not.
16568 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
16569 stack for expressions that are statements.
16571 2001-09-20 Miguel de Icaza <miguel@ximian.com>
16573 * expression.cs (LValue): New interface. Must be implemented by
16575 (LocalVariableReference, ParameterReference, FieldExpr): Implement
16578 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
16579 interface for generating code, simplifies the code.
16581 2001-09-20 Ravi Pratap <ravi@ximian.com>
16583 * expression.cs (everywhere): Comment out return statements in ::Resolve
16584 methods to avoid the warnings.
16586 2001-09-20 Miguel de Icaza <miguel@ximian.com>
16588 * driver.cs (parse): Report error 2001 if we can not open the
16591 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
16594 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
16597 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
16598 otherwise nested blocks end up with the same index.
16600 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
16602 * expression.cs: Instead of having FIXMEs in the Resolve
16603 functions, throw exceptions so it is obvious that we are facing a
16606 * cs-parser.jay (invocation_expression): Pass Location information.
16608 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
16609 Use a basename for those routines because .NET does not like paths
16612 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
16615 2001-09-19 Miguel de Icaza <miguel@ximian.com>
16617 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
16618 are loading the correct data types (throws an exception if not).
16619 (TypeManager::InitCoreTypes): Use CoreLookupType
16621 * expression.cs (Unary::ResolveOperator): return the child
16622 expression for expressions which are just +expr.
16623 (Unary::ResolveOperator): Return negative literals for -LITERAL
16624 expressions (otherwise they are Unary {Literal}).
16625 (Invocation::Badness): Take into account `Implicit constant
16626 expression conversions'.
16628 * literal.cs (LongLiteral): Implement long literal class.
16629 (IntLiteral): export the `Value' of the intliteral.
16631 2001-09-19 Ravi Pratap <ravi@ximian.com>
16633 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
16635 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
16636 instead of 'Operator'
16638 * expression.cs (Binary::ResolveOperator): Update accordingly.
16639 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
16642 * cs-parser.jay (unary_expression): Update to use the new names.
16644 * gen-treedump.cs (GetUnary): Same here.
16646 * expression.cs (Unary::Resolve): Implement.
16647 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
16648 operators are found instead of making noise ;-)
16649 (Unary::ResolveOperator): New method to do precisely the same thing which
16650 Binary::ResolveOperator does for Binary expressions.
16651 (Unary.method, .Arguments): Add.
16652 (Unary::OperName): Implement.
16653 (Unary::ForceConversion): Copy and Paste !
16655 * class.cs (Operator::Define): Fix a small bug for the case when we have
16658 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
16659 for the inbuilt operators. Only overloading works for now ;-)
16661 2001-09-18 Miguel de Icaza <miguel@ximian.com>
16663 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
16664 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
16666 * expression.cs (This::Emit): Implement.
16667 (This::Resolve): Implement.
16668 (TypeOf:Resolve): Implement.
16669 (Expression::ResolveSimpleName): Add an implicit this to instance
16671 (MemberAccess::Resolve): Deal with Parameters and Fields.
16672 Bind instance variable to Field expressions.
16673 (FieldExpr::Instance): New field used to track the expression that
16674 represents the object instance.
16675 (FieldExpr::Resolve): Track potential errors from MemberLookup not
16677 (FieldExpr::Emit): Implement.
16679 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
16680 the last instruction contains a return opcode to avoid generating
16681 the last `ret' instruction (this generates correct code, and it is
16682 nice to pass the peverify output).
16684 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
16685 initializer for static and instance variables.
16686 (Constructor::Emit): Allow initializer to be null in the case of
16687 static constructors. Only emit initializer for instance
16690 (TypeContainer::FindMembers): Return a null array if there are no
16693 Also fix the code for the MemberTypes.Method branch, as it was not
16694 scanning that for operators (or tried to access null variables before).
16696 * assign.cs (Assign::Emit): Handle instance and static fields.
16700 * driver.cs: Stop compilation if there are parse errors.
16702 * cs-parser.jay (constructor_declaration): Provide default base
16703 initializer for non-static constructors.
16704 (constructor_declarator): Do not provide a default base
16705 initializers if none was specified.
16706 Catch the fact that constructors should not have parameters.
16708 * class.cs: Do not emit parent class initializers for static
16709 constructors, that should be flagged as an error.
16711 2001-09-18 Ravi Pratap <ravi@ximian.com>
16713 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
16714 Move back code into TypeContainer::Populate.
16716 2001-09-18 Ravi Pratap <ravi@ximian.com>
16718 * class.cs (TypeContainer::AddConstructor): Fix the check to
16719 compare against Name, not Basename.
16720 (Operator::OpType): Change Plus and Minus to Add and Subtract.
16722 * cs-parser.jay : Update accordingly.
16724 * class.cs (TypeContainer::FindMembers): For the case where we are searching
16725 for methods, don't forget to look into the operators too.
16726 (RegisterMethodBuilder): Helper method to take care of this for
16727 methods, constructors and operators.
16728 (Operator::Define): Completely revamp.
16729 (Operator.OperatorMethod, MethodName): New fields.
16730 (TypeContainer::Populate): Move the registering of builders into
16731 RegisterMethodBuilder.
16732 (Operator::Emit): Re-write.
16734 * expression.cs (Binary::Emit): Comment out code path to emit method
16735 invocation stuff for the case when we have a user defined operator. I am
16736 just not able to get it right !
16738 2001-09-17 Miguel de Icaza <miguel@ximian.com>
16740 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
16743 (Expression::MemberLookup): Provide a version that allows to
16744 specify the MemberTypes and BindingFlags.
16746 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
16747 so it was not fetching variable information from outer blocks.
16749 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
16750 Beforefieldinit as it was buggy.
16752 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
16753 that Ravi put here.
16755 * class.cs (Constructor::Emit): Only emit if block is not null.
16756 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
16757 deal with this by semantically definining it as if the user had
16760 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
16761 constructors as we now "emit" them at a higher level.
16763 (TypeContainer::DefineDefaultConstructor): Used to define the
16764 default constructors if none was provided.
16766 (ConstructorInitializer): Add methods Resolve and Emit.
16768 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
16770 2001-09-17 Ravi Pratap <ravi@ximian.com>
16772 * class.cs (TypeContainer::EmitDefaultConstructor): Register
16773 the default constructor builder with our hashtable for methodbuilders
16776 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
16777 and argument_count is 0 in which case we have a match.
16778 (Binary::ResolveOperator): More null checking and miscellaneous coding
16781 2001-09-17 Ravi Pratap <ravi@ximian.com>
16783 * rootcontext.cs (IsNameSpace): Compare against null.
16785 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
16787 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
16788 and Unary::Operator.
16790 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
16793 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
16794 we have overloaded operators.
16795 (Binary::ResolveOperator): Implement the part which does the operator overload
16798 * class.cs (Operator::Emit): Implement.
16799 (TypeContainer::Emit): Emit the operators we have too.
16801 * expression.cs (Binary::Emit): Update to emit the appropriate code for
16802 the case when we have a user-defined operator.
16804 2001-09-17 Miguel de Icaza <miguel@ximian.com>
16806 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
16808 2001-09-16 Ravi Pratap <ravi@ximian.com>
16810 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
16811 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
16812 (Constructor::Emit): Implement.
16813 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
16814 if we have no work to do.
16815 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
16818 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
16819 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
16821 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
16824 2001-09-15 Ravi Pratap <ravi@ximian.com>
16826 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
16828 (Tree::RecordNamespace): Method to do what the name says ;-)
16829 (Tree::Namespaces): Property to get at the namespaces hashtable.
16831 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
16834 * rootcontext.cs (IsNamespace): Fixed it :-)
16836 2001-09-14 Miguel de Icaza <miguel@ximian.com>
16838 * class.cs (TypeContainer::FindMembers): Add support for
16840 (MethodCore): New class that encapsulates both the shared aspects
16841 of a Constructor and a Method.
16842 (Method, Constructor): Factored pieces into MethodCore.
16844 * driver.cs: Added --fatal which makes errors throw exceptions.
16845 Load System assembly as well as part of the standard library.
16847 * report.cs: Allow throwing exceptions on errors for debugging.
16849 * modifiers.cs: Do not use `parent', instead use the real type
16850 container to evaluate permission settings.
16852 * class.cs: Put Ravi's patch back in. He is right, and we will
16853 have to cope with the
16855 2001-09-14 Ravi Pratap <ravi@ximian.com>
16857 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
16858 FamORAssem, not FamANDAssem.
16860 2001-09-14 Miguel de Icaza <miguel@ximian.com>
16862 * driver.cs: Added --parse option that only parses its input files
16865 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
16866 incorrect. IsTopLevel is not used to tell whether an object is
16867 root_types or not (that can be achieved by testing this ==
16868 root_types). But to see if this is a top-level *class* (not
16869 necessarly our "toplevel" container).
16871 2001-09-14 Ravi Pratap <ravi@ximian.com>
16873 * enum.cs (Enum::Define): Modify to call the Lookup method on the
16874 parent instead of a direct call to GetType.
16876 2001-09-14 Ravi Pratap <ravi@ximian.com>
16878 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
16879 Modifiers.TypeAttr. This should just be a call to that method.
16881 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
16882 object so that we can determine if we are top-level or not.
16884 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
16887 * enum.cs (Enum::Define): Ditto.
16889 * modifiers.cs (FieldAttr): Re-write.
16891 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
16892 (TypeContainer::HaveStaticConstructor): New property to provide access
16893 to precisely that info.
16895 * modifiers.cs (MethodAttr): Re-write.
16896 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
16898 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
16899 of top-level types as claimed.
16901 2001-09-13 Miguel de Icaza <miguel@ximian.com>
16903 * expression.cs (MemberLookup): Fruitless attempt to lookup
16904 constructors. Maybe I need to emit default constructors? That
16905 might be it (currently .NET emits this for me automatically).
16906 (Invocation::OverloadResolve): Cope with Arguments == null.
16907 (Invocation::EmitArguments): new function, shared by the new
16908 constructor and us.
16909 (Invocation::Emit): Handle static and instance methods. Emit
16910 proper call instruction for virtual or non-virtual invocations.
16911 (New::Emit): Implement.
16912 (New::Resolve): Implement.
16913 (MemberAccess:Resolve): Implement.
16914 (MethodGroupExpr::InstanceExpression): used conforming to the spec
16915 to track instances.
16916 (FieldExpr::Resolve): Set type.
16918 * support.cs: Handle empty arguments.
16920 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
16921 SimpleLookup): Auxiliary routines to help parse a qualifier
16924 Update qualifier_identifier rule.
16926 * codegen.cs: Removed debugging messages.
16928 * class.cs: Make this a global thing, this acts just as a "key" to
16929 objects that we might have around.
16931 (Populate): Only initialize method_builders_to_methods once.
16933 * expression.cs (PropertyExpr): Initialize type from the
16936 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
16937 Resolve pattern. Attempt to implicitly convert value to boolean.
16940 * expression.cs: Set the type for the int32/int32 argument case.
16941 (Binary::ResolveOperator): Set the return type to boolean for
16942 comparission operators
16944 * typemanager.cs: Remove debugging print code.
16946 (Invocation::Resolve): resolve type.
16948 * class.cs: Allocate a MemberInfo of the correct size, as the code
16949 elsewhere depends on the test to reflect the correct contents.
16951 (Method::) Keep track of parameters, due to System.Reflection holes
16953 (TypeContainer::Populate): Keep track of MethodBuilders to Method
16956 (TypeContainer::FindMembers): Use ArrayList and then copy an array
16957 of the exact size and return that.
16959 (Class::LookupMethodByBuilder): New function that maps
16960 MethodBuilders to its methods. Required to locate the information
16961 on methods because System.Reflection bit us again.
16963 * support.cs: New file, contains an interface ParameterData and
16964 two implementations: ReflectionParameters and InternalParameters
16965 used to access Parameter information. We will need to grow this
16968 * expression.cs (Invocation::GetParameterData): implement a cache
16969 and a wrapper around the ParameterData creation for methods.
16970 (Invocation::OverloadResolve): Use new code.
16972 2001-09-13 Ravi Pratap <ravi@ximian.com>
16974 * class.cs (TypeContainer::EmitField): Remove and move into
16975 (Field::Define): here and modify accordingly.
16976 (Field.FieldBuilder): New member.
16977 (TypeContainer::Populate): Update accordingly.
16978 (TypeContainer::FindMembers): Implement.
16980 2001-09-13 Miguel de Icaza <miguel@ximian.com>
16982 * statement.cs: (VariableInfo::VariableType): New field to be
16983 initialized with the full type once it is resolved.
16985 2001-09-12 Miguel de Icaza <miguel@ximian.com>
16987 * parameter.cs (GetParameterInfo): Use a type cache to compute
16988 things only once, and to reuse this information
16990 * expression.cs (LocalVariableReference::Emit): Implement.
16991 (OpcodeCast::Emit): fix.
16993 (ParameterReference::Resolve): Implement.
16994 (ParameterReference::Emit): Implement.
16996 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
16997 that are expressions need to stay as Expressions.
16999 * typemanager.cs (CSharpName): Returns the C# name of a type if
17002 * expression.cs (Expression::ConvertImplicit): New function that
17003 implements implicit type conversions.
17005 (Expression::ImplicitReferenceConversion): Implements implicit
17006 reference conversions.
17008 (EmptyCast): New type for transparent casts.
17010 (OpcodeCast): New type for casts of types that are performed with
17011 a sequence of bytecodes.
17013 (BoxedCast): New type used for casting value types into reference
17014 types. Emits a box opcode.
17016 (Binary::DoNumericPromotions): Implements numeric promotions of
17017 and computation of the Binary::Type.
17019 (Binary::EmitBranchable): Optimization.
17021 (Binary::Emit): Implement code emission for expressions.
17023 * typemanager.cs (TypeManager): Added two new core types: sbyte
17026 2001-09-12 Ravi Pratap <ravi@ximian.com>
17028 * class.cs (TypeContainer::FindMembers): Method which does exactly
17029 what Type.FindMembers does, only we don't have to use reflection. No
17030 implementation yet.
17032 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
17033 typecontainer objects as we need to get at them.
17034 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
17036 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
17037 typecontainer object.
17039 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
17040 of just a Report object.
17042 2001-09-11 Ravi Pratap <ravi@ximian.com>
17044 * class.cs (Event::Define): Go back to using the prefixes "add_" and
17046 (TypeContainer::Populate): Now define the delegates of the type too.
17047 (TypeContainer.Delegates): Property to access the list of delegates defined
17050 * delegates.cs (Delegate::Define): Implement partially.
17052 * modifiers.cs (TypeAttr): Handle more flags.
17054 2001-09-11 Ravi Pratap <ravi@ximian.com>
17056 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
17058 (Operator::Define): Re-write logic to get types by using the LookupType method
17059 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
17060 (Indexer::Define): Ditto.
17061 (Event::Define): Ditto.
17062 (Property::Define): Ditto.
17064 2001-09-10 Ravi Pratap <ravi@ximian.com>
17066 * class.cs (TypeContainer::Populate): Now define operators too.
17067 (TypeContainer.Operators): New property to access the list of operators
17069 (Operator.OperatorMethodBuilder): New member to hold the method builder
17070 for the operator we are defining.
17071 (Operator::Define): Implement.
17073 2001-09-10 Ravi Pratap <ravi@ximian.com>
17075 * class.cs (Event::Define): Make the prefixes of the accessor methods
17076 addOn_ and removeOn_
17078 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
17079 of the location being passed in too. Ideally, this should go later since all
17080 error reporting should be done through the Report object.
17082 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
17083 (Populate): Iterate thru the indexers we have and define them too.
17084 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
17085 for the get and set accessors.
17086 (Indexer::Define): Implement.
17088 2001-09-09 Miguel de Icaza <miguel@ximian.com>
17090 * expression.cs (Binary::Resolve): Beginning of it. I scratched
17091 my previous implementation, did not work.
17093 * typemanager.cs: Add a couple of missing types (the longs).
17095 * literal.cs: Use TypeManager.bool_type instead of getting it.
17097 * expression.cs (EventExpr): New kind of expressions.
17098 (Expressio::ExprClassFromMemberInfo): finish
17100 2001-09-08 Miguel de Icaza <miguel@ximian.com>
17102 * assign.cs: Emit stores to static fields differently.
17104 2001-09-08 Ravi Pratap <ravi@ximian.com>
17106 * Merge in changes and adjust code to tackle conflicts. Backed out my
17107 code in Assign::Resolve ;-)
17109 2001-09-08 Ravi Pratap <ravi@ximian.com>
17111 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
17112 instead Report.Error and also pass in the location.
17113 (CSharpParser::Lexer): New readonly property to return the reference
17114 to the Tokenizer object.
17115 (declare_local_variables): Use Report.Error with location instead of plain
17119 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
17120 (Operator.CheckBinaryOperator): Ditto.
17122 * cs-parser.jay (operator_declarator): Update accordingly.
17124 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
17125 (CheckBinaryOperator): Same here.
17127 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
17128 on the name without any prefixes of namespace names etc. This is because we
17129 already might have something already fully qualified like
17130 'System.Console.WriteLine'
17132 * assign.cs (Resolve): Begin implementation. Stuck ;-)
17134 2001-09-07 Ravi Pratap <ravi@ximian.com>
17136 * cs-tokenizer.cs (location): Return a string which also contains
17139 * expression.cs (ElementAccess): New class for expressions of the
17140 type 'element access.'
17141 (BaseAccess): New class for expressions of the type 'base access.'
17142 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
17145 * cs-parser.jay (element_access): Implement action.
17146 (base_access): Implement actions.
17147 (checked_expression, unchecked_expression): Implement.
17149 * cs-parser.jay (local_variable_type): Correct and implement.
17150 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
17152 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
17154 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
17155 name and the specifiers.
17157 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
17159 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
17160 making them all public ;-)
17162 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
17165 2001-09-07 Miguel de Icaza <miguel@ximian.com>
17167 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
17169 (FieldExpr, PropertyExprs): New resolved expressions.
17170 (SimpleName::MemberStaticCheck): Perform static checks for access
17171 to non-static fields on static methods. Maybe this should be
17172 generalized for MemberAccesses.
17173 (SimpleName::ResolveSimpleName): More work on simple name
17176 * cs-parser.jay (primary_expression/qualified_identifier): track
17177 the parameter index.
17179 * codegen.cs (CodeGen::Save): Catch save exception, report error.
17180 (EmitContext::EmitBoolExpression): Chain to expression generation
17181 instead of temporary hack.
17182 (::EmitStatementExpression): Put generic expression code generation.
17184 * assign.cs (Assign::Emit): Implement variable assignments to
17185 local variables, parameters and fields.
17187 2001-09-06 Miguel de Icaza <miguel@ximian.com>
17189 * statement.cs (Block::GetVariableInfo): New method, returns the
17190 VariableInfo for a variable name in a block.
17191 (Block::GetVariableType): Implement in terms of GetVariableInfo
17193 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
17194 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
17196 2001-09-06 Ravi Pratap <ravi@ximian.com>
17198 * cs-parser.jay (operator_declaration): Continue on my quest : update
17199 to take attributes argument.
17200 (event_declaration): Ditto.
17201 (enum_declaration): Ditto.
17202 (indexer_declaration): Ditto.
17204 * class.cs (Operator::Operator): Update constructor accordingly.
17205 (Event::Event): Ditto.
17207 * delegate.cs (Delegate::Delegate): Same here.
17209 * enum.cs (Enum::Enum): Same here.
17211 2001-09-05 Ravi Pratap <ravi@ximian.com>
17213 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
17215 * ../tests/cs0658.cs : New file to demonstrate error 0658.
17217 * attribute.cs (Attributes): New class to encapsulate all attributes which were
17218 being passed around as an arraylist.
17219 (Attributes::AddAttribute): Method to add attribute sections.
17221 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
17222 (struct_declaration): Update accordingly.
17223 (constant_declaration): Update.
17224 (field_declaration): Update.
17225 (method_header): Update.
17226 (fixed_parameter): Update.
17227 (parameter_array): Ditto.
17228 (property_declaration): Ditto.
17229 (destructor_declaration): Ditto.
17231 * class.cs (Struct::Struct): Update constructors accordingly.
17232 (Class::Class): Ditto.
17233 (Field::Field): Ditto.
17234 (Method::Method): Ditto.
17235 (Property::Property): Ditto.
17236 (TypeContainer::OptAttribute): update property's return type.
17238 * interface.cs (Interface.opt_attributes): New member.
17239 (Interface::Interface): Update to take the extra Attributes argument.
17241 * parameter.cs (Parameter::Parameter): Ditto.
17243 * constant.cs (Constant::Constant): Ditto.
17245 * interface.cs (InterfaceMemberBase): New OptAttributes field.
17246 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
17247 the attributes as a parameter.
17248 (InterfaceProperty): Update constructor call.
17249 (InterfaceEvent): Ditto.
17250 (InterfaceMethod): Ditto.
17251 (InterfaceIndexer): Ditto.
17253 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
17254 pass the attributes too.
17255 (interface_event_declaration): Ditto.
17256 (interface_property_declaration): Ditto.
17257 (interface_method_declaration): Ditto.
17258 (interface_declaration): Ditto.
17260 2001-09-05 Miguel de Icaza <miguel@ximian.com>
17262 * class.cs (Method::Define): Track the "static Main" definition to
17263 create an entry point.
17265 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
17266 EntryPoint if we find it.
17268 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
17269 (EmitContext::ig): Make this variable public.
17271 * driver.cs: Make the default output file be the first file name
17272 with the .exe extension.
17274 Detect empty compilations
17276 Handle various kinds of output targets. Handle --target and
17277 rename -t to --dumper.
17279 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
17280 methods inherited from Expression return now an Expression. This
17281 will is used during the tree rewriting as we resolve them during
17284 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
17285 the spec. Missing entirely is the information about
17286 accessability of elements of it.
17288 (Expression::ExprClassFromMemberInfo): New constructor for
17289 Expressions that creates a fully initialized Expression based on
17290 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
17293 (Invocation::Resolve): Begin implementing resolution of invocations.
17295 * literal.cs (StringLiteral): Implement Emit.
17297 2001-09-05 Ravi Pratap <ravi@ximian.com>
17299 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
17302 2001-09-04 Ravi Pratap <ravi@ximian.com>
17304 * cs-parser.jay (attribute_arguments): Implement actions.
17305 (attribute): Fix bug in production. Implement action.
17306 (attribute_list): Implement.
17307 (attribute_target): Implement.
17308 (attribute_target_specifier, opt_target_specifier): Implement
17309 (CheckAttributeTarget): New method to check if the attribute target
17311 (attribute_section): Implement.
17312 (opt_attributes): Implement.
17314 * attribute.cs : New file to handle attributes.
17315 (Attribute): Class to hold attribute info.
17317 * cs-parser.jay (opt_attribute_target_specifier): Remove production
17318 (attribute_section): Modify production to use 2 different rules to
17319 achieve the same thing. 1 s/r conflict down !
17320 Clean out commented, useless, non-reducing dimension_separator rules.
17322 * class.cs (TypeContainer.attributes): New member to hold list
17323 of attributes for a type.
17324 (Struct::Struct): Modify to take one more argument, the attribute list.
17325 (Class::Class): Ditto.
17326 (Field::Field): Ditto.
17327 (Method::Method): Ditto.
17328 (Property::Property): Ditto.
17330 * cs-parser.jay (struct_declaration): Update constructor call to
17331 pass in the attributes too.
17332 (class_declaration): Ditto.
17333 (constant_declaration): Ditto.
17334 (field_declaration): Ditto.
17335 (method_header): Ditto.
17336 (fixed_parameter): Ditto.
17337 (parameter_array): Ditto.
17338 (property_declaration): Ditto.
17340 * constant.cs (Constant::Constant): Update constructor similarly.
17341 Use System.Collections.
17343 * parameter.cs (Parameter::Parameter): Update as above.
17345 2001-09-02 Ravi Pratap <ravi@ximian.com>
17347 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
17348 (TypeContainer.delegates): New member to hold list of delegates.
17350 * cs-parser.jay (delegate_declaration): Implement the action correctly
17351 this time as I seem to be on crack ;-)
17353 2001-09-02 Miguel de Icaza <miguel@ximian.com>
17355 * rootcontext.cs (RootContext::IsNamespace): new function, used to
17356 tell whether an identifier represents a namespace.
17358 * expression.cs (NamespaceExpr): A namespace expression, used only
17359 temporarly during expression resolution.
17360 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
17361 utility functions to resolve names on expressions.
17363 2001-09-01 Miguel de Icaza <miguel@ximian.com>
17365 * codegen.cs: Add hook for StatementExpressions.
17367 * class.cs: Fix inverted test for static flag in methods.
17369 2001-09-02 Ravi Pratap <ravi@ximian.com>
17371 * class.cs (Operator::CheckUnaryOperator): Correct error number used
17372 to make it coincide with MS' number.
17373 (Operator::CheckBinaryOperator): Ditto.
17375 * ../errors/errors.txt : Remove error numbers added earlier.
17377 * ../errors/cs1019.cs : Test case for error # 1019
17379 * ../errros/cs1020.cs : Test case for error # 1020
17381 * cs-parser.jay : Clean out commented cruft.
17382 (dimension_separators, dimension_separator): Comment out. Ostensibly not
17383 used anywhere - non-reducing rule.
17384 (namespace_declarations): Non-reducing rule - comment out.
17386 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
17387 with TypeContainer::AddEnum.
17389 * delegate.cs : New file for delegate handling classes.
17390 (Delegate): Class for declaring delegates.
17392 * makefile : Update.
17394 * cs-parser.jay (delegate_declaration): Implement.
17396 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
17398 * class.cs (Event::Define): Implement.
17399 (Event.EventBuilder): New member.
17401 * class.cs (TypeContainer::Populate): Update to define all enums and events
17403 (Events): New property for the events arraylist we hold. Shouldn't we move to using
17404 readonly fields for all these cases ?
17406 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
17408 * class.cs (Property): Revamp to use the convention of making fields readonly.
17409 Accordingly modify code elsewhere.
17411 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
17412 the Define method of the Property class.
17414 * class.cs : Clean up applied patch and update references to variables etc. Fix
17416 (TypeContainer::Populate): Update to define all the properties we have. Also
17417 define all enumerations.
17419 * enum.cs (Define): Implement.
17421 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
17423 * cs-parser.jay (overloadable_operator): The semantic value is an
17424 enum of the Operator class.
17425 (operator_declarator): Implement actions.
17426 (operator_declaration): Implement.
17428 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
17429 validity of definitions.
17430 (Operator::CheckBinaryOperator): Static method to check for binary operators
17431 (TypeContainer::AddOperator): New method to add an operator to a type.
17433 * cs-parser.jay (indexer_declaration): Added line to actually call the
17434 AddIndexer method so it gets added ;-)
17436 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
17437 already taken care of by the MS compiler ?
17439 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
17441 * class.cs (Operator): New class for operator declarations.
17442 (Operator::OpType): Enum for the various operators.
17444 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
17446 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
17447 ostensibly handle this in semantic analysis.
17449 * cs-parser.jay (general_catch_clause): Comment out
17450 (specific_catch_clauses, specific_catch_clause): Ditto.
17451 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
17452 (catch_args, opt_catch_args): New productions.
17453 (catch_clause): Rewrite to use the new productions above
17454 (catch_clauses): Modify accordingly.
17455 (opt_catch_clauses): New production to use in try_statement
17456 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
17457 and re-write the code in the actions to extract the specific and
17458 general catch clauses by being a little smart ;-)
17460 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
17461 Hooray, try and catch statements parse fine !
17463 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
17465 * statement.cs (Block::GetVariableType): Fix logic to extract the type
17466 string from the hashtable of variables.
17468 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
17469 I end up making that mistake ;-)
17470 (catch_clauses): Fixed gross error which made Key and Value of the
17471 DictionaryEntry the same : $1 !!
17473 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
17475 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
17477 * cs-parser.jay (event_declaration): Correct to remove the semicolon
17478 when the add and remove accessors are specified.
17480 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
17482 * cs-parser.jay (IndexerDeclaration): New helper class to hold
17483 information about indexer_declarator.
17484 (indexer_declarator): Implement actions.
17485 (parsing_indexer): New local boolean used to keep track of whether
17486 we are parsing indexers or properties. This is necessary because
17487 implicit_parameters come into picture even for the get accessor in the
17488 case of an indexer.
17489 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
17491 * class.cs (Indexer): New class for indexer declarations.
17492 (TypeContainer::AddIndexer): New method to add an indexer to a type.
17493 (TypeContainer::indexers): New member to hold list of indexers for the
17496 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
17498 * cs-parser.jay (add_accessor_declaration): Implement action.
17499 (remove_accessor_declaration): Implement action.
17500 (event_accessors_declaration): Implement
17501 (variable_declarators): swap statements for first rule - trivial.
17503 * class.cs (Event): New class to hold information about event
17505 (TypeContainer::AddEvent): New method to add an event to a type
17506 (TypeContainer::events): New member to hold list of events.
17508 * cs-parser.jay (event_declaration): Implement actions.
17510 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
17512 * cs-parser.jay (dim_separators): Implement. Make it a string
17513 concatenating all the commas together, just as they appear.
17514 (opt_dim_separators): Modify accordingly
17515 (rank_specifiers): Update accordingly. Basically do the same
17516 thing - instead, collect the brackets here.
17517 (opt_rank_sepcifiers): Modify accordingly.
17518 (array_type): Modify to actually return the complete type string
17519 instead of ignoring the rank_specifiers.
17520 (expression_list): Implement to collect the expressions
17521 (variable_initializer): Implement. We make it a list of expressions
17522 essentially so that we can handle the array_initializer case neatly too.
17523 (variable_initializer_list): Implement.
17524 (array_initializer): Make it a list of variable_initializers
17525 (opt_array_initializer): Modify accordingly.
17527 * expression.cs (New::NType): Add enumeration to help us
17528 keep track of whether we have an object/delegate creation
17529 or an array creation.
17530 (New:NewType, New::Rank, New::Indices, New::Initializers): New
17531 members to hold data about array creation.
17532 (New:New): Modify to update NewType
17533 (New:New): New Overloaded contructor for the array creation
17536 * cs-parser.jay (array_creation_expression): Implement to call
17537 the overloaded New constructor.
17539 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
17541 * class.cs (TypeContainer::Constructors): Return member
17542 constructors instead of returning null.
17544 2001-08-26 Miguel de Icaza <miguel@ximian.com>
17546 * typemanager.cs (InitCoreTypes): Initialize the various core
17547 types after we have populated the type manager with the user
17548 defined types (this distinction will be important later while
17549 compiling corlib.dll)
17551 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
17552 on Expression Classification. Now all expressions have a method
17553 `Resolve' and a method `Emit'.
17555 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
17556 generation from working. Also add some temporary debugging
17559 2001-08-24 Miguel de Icaza <miguel@ximian.com>
17561 * codegen.cs: Lots of code generation pieces. This is only the
17562 beginning, will continue tomorrow with more touches of polish. We
17563 handle the fundamentals of if, while, do, for, return. Others are
17564 trickier and I need to start working on invocations soon.
17566 * gen-treedump.cs: Bug fix, use s.Increment here instead of
17569 * codegen.cs (EmitContext): New struct, used during code
17570 emission to keep a context. Most of the code generation will be
17573 * cs-parser.jay: Add embedded blocks to the list of statements of
17574 this block. So code generation proceeds in a top down fashion.
17576 2001-08-23 Miguel de Icaza <miguel@ximian.com>
17578 * statement.cs: Add support for multiple child blocks.
17580 2001-08-22 Miguel de Icaza <miguel@ximian.com>
17582 * codegen.cs (EmitCode): New function, will emit the code for a
17583 Block of code given a TypeContainer and its ILGenerator.
17585 * statement.cs (Block): Standard public readonly optimization.
17586 (Block::Block constructors): Link children.
17587 (Block::Child): Child Linker.
17588 (Block::EmitVariables): Emits IL variable declarations.
17590 * class.cs: Drop support for MethodGroups here, delay until
17592 (Method::): Applied the same simplification that I did before, and
17593 move from Properties to public readonly fields.
17594 (Method::ParameterTypes): Returns the parameter types for the
17595 function, and implements a cache that will be useful later when I
17596 do error checking and the semantic analysis on the methods is
17598 (Constructor::GetCallingConvention): Renamed from CallingConvetion
17599 and made a method, optional argument tells whether this is a class
17600 or a structure to apply the `has-this' bit.
17601 (Method::GetCallingConvention): Implement, returns the calling
17603 (Method::Define): Defines the type, a second pass is performed
17604 later to populate the methods.
17606 (Constructor::ParameterTypes): implement a cache similar to the
17607 one on Method::ParameterTypes, useful later when we do semantic
17610 (TypeContainer::EmitMethod): New method. Emits methods.
17612 * expression.cs: Removed MethodGroup class from here.
17614 * parameter.cs (Parameters::GetCallingConvention): new method.
17616 2001-08-21 Miguel de Icaza <miguel@ximian.com>
17618 * class.cs (TypeContainer::Populate): Drop RootContext from the
17621 (Constructor::CallingConvention): Returns the calling convention.
17622 (Constructor::ParameterTypes): Returns the constructor parameter
17625 (TypeContainer::AddConstructor): Keep track of default constructor
17626 and the default static constructor.
17628 (Constructor::) Another class that starts using `public readonly'
17629 instead of properties.
17631 (Constructor::IsDefault): Whether this is a default constructor.
17633 (Field::) use readonly public fields instead of properties also.
17635 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
17636 track of static constructors; If none is used, turn on
17637 BeforeFieldInit in the TypeAttributes.
17639 * cs-parser.jay (opt_argument_list): now the return can be null
17640 for the cases where there are no arguments.
17642 (constructor_declarator): If there is no implicit `base' or
17643 `this', then invoke the default parent constructor.
17645 * modifiers.cs (MethodAttr): New static function maps a set of
17646 modifiers flags into a MethodAttributes enum
17647 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
17648 MethodAttr, TypeAttr to represent the various mappings where the
17649 modifiers are used.
17650 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
17652 2001-08-19 Miguel de Icaza <miguel@ximian.com>
17654 * parameter.cs (GetParameterInfo): Fix bug where there would be no
17657 * interface.cs (PopulateIndexer): Implemented the code generator
17658 for interface indexers.
17660 2001-08-17 Miguel de Icaza <miguel@ximian.com>
17662 * interface.cs (InterfaceMemberBase): Now we track the new status
17665 (PopulateProperty): Implement property population. Woohoo! Got
17666 Methods and Properties going today.
17668 Removed all the properties for interfaces, and replaced them with
17669 `public readonly' fields.
17671 2001-08-16 Miguel de Icaza <miguel@ximian.com>
17673 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
17674 initialize their hashtables/arraylists only when they are needed
17675 instead of doing this always.
17677 * parameter.cs: Handle refs and out parameters.
17679 * cs-parser.jay: Use an ArrayList to construct the arguments
17680 instead of the ParameterCollection, and then cast that to a
17683 * parameter.cs: Drop the use of ParameterCollection and use
17684 instead arrays of Parameters.
17686 (GetParameterInfo): Use the Type, not the Name when resolving
17689 2001-08-13 Miguel de Icaza <miguel@ximian.com>
17691 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
17692 and instead use public readonly fields.
17694 * class.cs: Put back walking code for type containers.
17696 2001-08-11 Miguel de Icaza <miguel@ximian.com>
17698 * class.cs (MakeConstant): Code to define constants.
17700 * rootcontext.cs (LookupType): New function. Used to locate types
17703 2001-08-08 Miguel de Icaza <miguel@ximian.com>
17705 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
17706 this System.Reflection code is. Kudos to Microsoft
17708 * typemanager.cs: Implement a type cache and avoid loading all
17709 types at boot time. Wrap in LookupType the internals. This made
17710 the compiler so much faster. Wow. I rule!
17712 * driver.cs: Make sure we always load mscorlib first (for
17713 debugging purposes, nothing really important).
17715 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
17716 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
17718 * rootcontext.cs: Lookup types on their namespace; Lookup types
17719 on namespaces that have been imported using the `using' keyword.
17721 * class.cs (TypeContainer::TypeAttr): Virtualize.
17722 (Class::TypeAttr): Return attributes suitable for this bad boy.
17723 (Struct::TypeAttr): ditto.
17724 Handle nested classes.
17725 (TypeContainer::) Remove all the type visiting code, it is now
17726 replaced with the rootcontext.cs code
17728 * rootcontext.cs (GetClassBases): Added support for structs.
17730 2001-08-06 Miguel de Icaza <miguel@ximian.com>
17732 * interface.cs, statement.cs, class.cs, parameter.cs,
17733 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
17734 Drop use of TypeRefs, and use strings instead.
17736 2001-08-04 Miguel de Icaza <miguel@ximian.com>
17740 * class.cs (Struct::Struct): set the SEALED flags after
17741 checking the modifiers.
17742 (TypeContainer::TypeAttr): new property, returns the
17743 TypeAttributes for a class.
17745 * cs-parser.jay (type_list): Oops, list production was creating a
17746 new list of base types.
17748 * rootcontext.cs (StdLib): New property.
17749 (GetInterfaceTypeByName): returns an interface by type name, and
17750 encapsulates error handling here.
17751 (GetInterfaces): simplified.
17752 (ResolveTree): Encapsulated all the tree resolution here.
17753 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
17756 * driver.cs: Add support for --nostdlib, to avoid loading the
17757 default assemblies.
17758 (Main): Do not put tree resolution here.
17760 * rootcontext.cs: Beginning of the class resolution.
17762 2001-08-03 Miguel de Icaza <miguel@ximian.com>
17764 * rootcontext.cs: Provide better error reporting.
17766 * cs-parser.jay (interface_base): set our $$ to be interfaces.
17768 * rootcontext.cs (CreateInterface): Handle the case where there
17769 are no parent interfaces.
17771 (CloseTypes): Routine to flush types at the end.
17772 (CreateInterface): Track types.
17773 (GetInterfaces): Returns an array of Types from the list of
17774 defined interfaces.
17776 * typemanager.c (AddUserType): Mechanism to track user types (puts
17777 the type on the global type hash, and allows us to close it at the
17780 2001-08-02 Miguel de Icaza <miguel@ximian.com>
17782 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
17783 RecordInterface instead.
17785 * cs-parser.jay: Updated to reflect changes above.
17787 * decl.cs (Definition): Keep track of the TypeBuilder type that
17788 represents this type here. Not sure we will use it in the long
17789 run, but wont hurt for now.
17791 * driver.cs: Smaller changes to accomodate the new code.
17793 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
17796 * rootcontext.cs (CreateInterface): New method, used to create
17797 the System.TypeBuilder type for interfaces.
17798 (ResolveInterfaces): new entry point to resolve the interface
17800 (CodeGen): Property, used to keep track of the code generator.
17802 2001-07-26 Miguel de Icaza <miguel@ximian.com>
17804 * cs-parser.jay: Add a second production for delegate_declaration
17807 (enum_body): Put an opt_comma here instead of putting it on
17808 enum_body or enum_member_declarations so we can handle trailing
17809 commas on enumeration members. Gets rid of a shift/reduce.
17811 (type_list): Need a COMMA in the middle.
17813 (indexer_declaration): Tell tokenizer to recognize get/set
17815 * Remove old targets.
17817 * Re-add the parser target.
17819 2001-07-13 Simon Cozens <simon@simon-cozens.org>
17821 * cs-parser.jay: Add precendence rules for a number of operators
17822 ot reduce the number of shift/reduce conflicts in the grammar.
17824 2001-07-17 Miguel de Icaza <miguel@ximian.com>
17826 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
17829 Get rid of old crufty code.
17831 * rootcontext.cs: Use this to keep track of the parsed
17832 representation and the defined types available to the program.
17834 * gen-treedump.cs: adjust for new convention.
17836 * type.cs: Split out the type manager, and the assembly builder
17839 * typemanager.cs: the type manager will live here now.
17841 * cil-codegen.cs: And the code generator here.
17843 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
17845 * makefile: Fixed up for easy making.
17847 2001-07-13 Simon Cozens <simon@simon-cozens.org>
17849 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
17852 (unary_expression): Expand pre_increment_expression and
17853 post_decrement_expression to reduce a shift/reduce.
17855 2001-07-11 Simon Cozens
17857 * cs-tokenizer.cs: Hex numbers should begin with a 0.
17859 Improve allow_keyword_as_indent name.
17861 2001-06-19 Miguel de Icaza <miguel@ximian.com>
17863 * Adjustments for Beta2.
17865 2001-06-13 Miguel de Icaza <miguel@ximian.com>
17867 * decl.cs: Added `Define' abstract method.
17868 (InTransit): new property, used to catch recursive definitions.
17870 * interface.cs: Implement `Define'.
17872 * modifiers.cs: Map Modifiers.constants to
17873 System.Reflection.TypeAttribute flags.
17875 * class.cs: Keep track of types and user-defined types.
17876 (BuilderInit): New method for creating an assembly
17877 (ResolveType): New function to launch the resolution process, only
17878 used by interfaces for now.
17880 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
17881 that are inserted into the name space.
17883 2001-06-08 Miguel de Icaza <miguel@ximian.com>
17885 * ARGH. I have screwed up my tree so many times due to the use of
17886 rsync rather than using CVS. Going to fix this at once.
17888 * driver.cs: Objetify driver. Load assemblies, use assemblies to
17891 2001-06-07 Miguel de Icaza <miguel@ximian.com>
17893 * Experiment successful: Use System.Type rather that our own
17896 2001-05-25 Miguel de Icaza <miguel@ximian.com>
17898 * cs-parser.jay: Removed nsAliases from here.
17900 Use new namespaces, handle `using XXX;'
17902 * namespace.cs: Reimplemented namespace handling, use a recursive
17903 definition of the class. Now we can keep track of using clauses
17904 and catch invalid using clauses.
17906 2001-05-24 Miguel de Icaza <miguel@ximian.com>
17908 * gen-treedump.cs: Adapted for all the renaming.
17910 * expression.cs (Expression): this class now has a Type property
17911 which returns an expression Type.
17913 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
17914 `Type', as this has a different meaning now in the base
17916 2001-05-22 Miguel de Icaza <miguel@ximian.com>
17918 * interface.cs, class.cs: Removed from all the sources the
17919 references to signature computation, as we can not do method
17920 signature computation during the parsing time, as we are not
17921 trying to solve at that point distinguishing:
17925 void a (NS.Blah x) {}
17928 Which depending on the context might be valid or not, as we do not
17929 know if Blah is the same thing as NS.Blah at that point.
17931 * Redid everything so the code uses TypeRefs now instead of
17932 Types. TypeRefs are just temporary type placeholders, that need
17933 to be resolved. They initially have a pointer to a string and the
17934 current scope in which they are used. This is used later by the
17935 compiler to resolve the reference to an actual Type.
17937 * DeclSpace is no longer a CIR.Type, and neither are
17938 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
17939 are all DeclSpaces, but no Types.
17941 * type.cs (TypeRefManager): This implements the TypeRef manager,
17942 which keeps track of all the types that need to be resolved after
17943 the parsing has finished.
17945 2001-05-13 Miguel de Icaza <miguel@ximian.com>
17947 * ARGH. We are going to have to store `foreach' as a class rather
17948 than resolving it, as we need to verify error 1579 after name
17949 resolution. *OR* we could keep a flag that says `This request to
17950 IEnumerator comes from a foreach statement' which we can then use
17951 to generate the error.
17953 2001-05-10 Miguel de Icaza <miguel@ximian.com>
17955 * class.cs (TypeContainer.AddMethod): we now add methods to the
17956 MethodGroup instead of the method hashtable.
17958 * expression.cs: Add MethodGroup abstraction, which gets us one
17959 step closer to the specification in the way we handle method
17962 * cs-parser.jay (primary_expression): qualified_identifier now
17963 tried to match up an identifier to a local variable reference or
17964 to a parameter reference.
17966 current_local_parameters is now a parser global variable that
17967 points to the current parameters for the block, used during name
17970 (property_declaration): Now creates an implicit `value' argument to
17973 2001-05-09 Miguel de Icaza <miguel@ximian.com>
17975 * parameter.cs: Do not use `param' arguments as part of the
17976 signature, per the spec.
17978 2001-05-08 Miguel de Icaza <miguel@ximian.com>
17980 * decl.cs: Base class for classes, structs and interfaces. This
17981 is the "Declaration Space"
17983 * cs-parser.jay: Use CheckDef for checking declaration errors
17984 instead of having one on each function.
17986 * class.cs: Factor out some code for handling error handling in
17987 accordance to the "Declarations" section in the "Basic Concepts"
17988 chapter in the ECMA C# spec.
17990 * interface.cs: Make all interface member classes derive from
17991 InterfaceMemberBase.
17993 2001-05-07 Miguel de Icaza <miguel@ximian.com>
17995 * Many things: all interfaces are parsed and generated in
17996 gen-treedump. Support for member variables, constructors,
17997 destructors, properties, constants is there.
17999 Beginning of the IL backend, but very little done, just there for
18002 2001-04-29 Miguel de Icaza <miguel@ximian.com>
18004 * cs-parser.jay: Fix labeled statement.
18006 * cs-tokenizer.cs (escape): Escape " and ' always.
18007 ref_line, ref_name: keep track of the line/filename as instructed
18008 by #line by the compiler.
18011 2001-04-27 Miguel de Icaza <miguel@ximian.com>
18013 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
18014 to match the values in System.CodeDOM.
18016 Divid renamed to Divide.
18018 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
18020 (Statements.set): remove.
18022 * System.CodeDOM/CodeCatchClause.cs: always have a valid
18025 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
18026 falseStatements always have valid values.
18028 * cs-parser.jay: Use System.CodeDOM now.