1 2007-05-29 Raja R Harinath <rharinath@novell.com>
3 * cs-parser.jay: Update to changes in ToplevelBlock.
4 (top_current_block): Remove.
6 2007-05-27 Raja R Harinath <harinath@gmail.com>
8 * cs-parser.jay: Update to new ExplicitBlock invariant.
10 * cs-parser.jay: Update to changes introduced in Block and
13 2007-05-25 Raja R Harinath <rharinath@novell.com>
15 * cs-parser.jay: Use 'start_block' and 'end_block' rather than
16 modifying current_block directly.
18 2007-05-22 Scott Peterson <lunchtimemama@gmail.com>
20 * cs-parser.jay: Implemented automatic properties (C# 3.0)
22 2007-05-15 Scott Peterson <lunchtimemama@gmail.com>
24 * cs-parser.jay: Improved grammar for object and collection
27 2007-04-28 Scott Peterson <lunchtimemama@gmail.com>
29 This code is contributed under the MIT X11 license
31 * cs-parser.jay: Added support for C# 3.0 language features:
32 Variable type inference (the "var" keyword)
36 Collection initialization
38 2007-05-06 Marek Safar <marek.safar@gmail.com>
41 * cs-parser.jay: Add special handling for coalescing operator.
43 2007-05-02 Raja R Harinath <rharinath@novell.com>
45 Fix regression in cs0631-3.cs
46 * cs-parser.jay (operator_declarator): Add opt_attributes to error
47 fallback. Make error fallback catch more cases.
49 2007-05-01 Miguel de Icaza <miguel@novell.com>
51 * cs-parser.jay: Allow parameters in operator declarations to have
54 2007-04-27 Miguel de Icaza <miguel@novell.com>
56 * generic.cs (TypeManager.LambdaInfer): now this routine will
57 make only one inference from the list of lambda expression that
58 have not participated in inferring a type.
60 (TypeManager.InferTypeArguments): The logic that drives the type
61 inference in lambda expressions is now driven here.
63 2007-04-23 Miguel de Icaza <miguel@novell.com>
65 * generic.cs: Large update to LambdaInfer, this is merely an
66 update to start the lambda type inference. It is by no means
67 complete. It is currently merely able to build a sample program
68 (with no iteration for the type parameters).
70 2007-04-12 Duncan Mak <duncan@a-chinaman.com>
72 * cs-parser.jay (interface_method_declaration_body): Fixed typo.
74 2007-04-08 Marek Safar <marek.safar@gmail.com>
76 * cs-parser.jay, linq.cs: First select implementation (hacky).
78 * generic.cs (InferTypeArguments): Simplified.
80 2007-03-31 Marek Safar <marek.safar@gmail.com>
82 * generic.cs (InferTypeArguments): Restored validation check.
83 (InferTypeArguments): Move all logic to Compatible method for re-usability.
85 2007-03-25 Marek Safar <marek.safar@gmail.com>
87 * generic.cs (InferTypeArguments): Infer arguments before they are used
88 for compatibility check.
90 2007-03-15 Marek Safar <marek.safar@gmail.com>
92 * generic.cs (InflatedConstraints): Fixed the check order.
93 (TypeArguments.Resolve): Small optimization for generic parameters.
94 (InferTypeArguments): Add infering support for anonymous methods.
96 2007-03-15 Martin Baulig <martin@ximian.com>
101 (TypeParameter.HasConstructorConstraint): Removed.
102 (ConstraintChecker.HasDefaultConstructor): Removed the
103 `TypeBuilder' argument here; correctly check for the ctor
104 constraint on type parameters.
106 2007-03-15 Martin Baulig <martin@ximian.com>
111 (TypeParameter): Create a `MemberCache' here as well. Note that
112 we need to create this on-demand when it's actually used.
114 2007-03-10 Marek Safar <marek.safar@gmail.com>
116 * generic.cs (TypeArguments.Resolve): Avoid redundant checks.
118 2007-03-09 Raja R Harinath <rharinath@novell.com>
120 * cs-parser.jay (WHERE): Move before QUERY_FIRST_TOKEN. 'where'
121 is a valid keyword outside a linq expression too.
123 2007-03-03 Marek Safar <marek.safar@gmail.com>
125 * cs-parser.jay: Implemented basic linq grammar.
127 * linq.cs: New file for hosting query specific classes.
129 2007-02-26 Marek Safar <marek.safar@gmail.com>
131 * cs-parser.jay, expression.cs: Compile empty __arglist correctly.
133 2007-02-20 Marek Safar <marek.safar@gmail.com>
136 * cs-parser.jay: Anonymous container starts at constructor declaration
137 and not at block beginning because it has to be usable in constructor
140 2007-02-18 Marek Safar <marek.safar@gmail.com>
142 A fix for bug #80493 by Atsushi Enomoto
143 * cs-parser.jay: Ignore invalid attribute target.
145 2007-02-15 Miguel de Icaza <miguel@novell.com>
147 * Remove the call to SetExpression for lambda expressions, we do
148 not actually need it.
150 Remove expression tracking code as its not needed.
152 2007-02-11 Miguel de Icaza <miguel@novell.com>
154 * cs-parser.jay (lambda_expression_body): when the body is an
155 expression add a statement of the form:
157 contextual-return expression.
159 Where `contextual-return' is similar to `return', the difference
160 being that if the delegate that the lambda will be converted to
161 has a void return type, it will check that the result is a
162 ExpressionStatement and the result is a plain ret (no return
163 values on the stack). If the return type of the delegate is of a
164 given type, this turns into a return with a value and does the
165 regular checking to check that the computed value can be
166 implicitly converted to the delegate return.
168 2007-01-30 Miguel de Icaza <miguel@novell.com>
170 * cs-parser.jay (anonymous_method_expression): move the
171 before/after productions to the start_anonymous and end_anonymous
172 methods so the code can be reused for lambda functions.
174 (lambda_expression_body): wrap expressions implicitly into a
177 (block): factor out the setup/teardown of parsing a block so we
178 can reuse that in lambda_expression_body
180 (lambda_expression): use new anonymous method helper methods.
182 2007-01-29 Miguel de Icaza <miguel@novell.com>
184 * cs-parser.jay: oob_stack make it static (am guessing that is why
185 we no longer initialize it anymore) and reuse it across
188 2007-01-28 Miguel de Icaza <miguel@novell.com>
190 * cs-parser.jay (open_parens): Introduce new non-terminal that
191 abstracts OPEN_PARENS and OPEN_PARENS_LAMBDA as the later can now
192 be returned in places where types are followed by identifiers
193 (this is expected in declaration, fixed, using, foreach and catch
196 Use open_parens in those places, keep OPEN_PARENS in the
199 cs-parser.jay: New grammar bits for parsing lambda expressions.
201 2007-01-28 Raja R Harinath <rharinath@novell.com>
203 Fix #80534, gtest-309.cs
204 * generic.cs (UnifyType): Rename from InferType. Make unification
205 of generic insts simpler and don't insist on inferring all generic
206 parameters in a single generic inst unification.
208 (InferGenericInstance): Remove.
209 Analysis and initial patch by David Mitchell <dmitchell@logos.com>.
211 2007-01-20 Marek Safar <marek.safar@gmail.com>
213 * cs-parser.jay: Better parameter error handling.
215 2007-01-17 Bill Holmes <bill.holmes@ansys.com>
216 Raja R Harinath <rharinath@novell.com>
218 * cs-parser.jay (accessor_declarations): Use it instead of 'Pair'.
219 Note the order in which accessors are declared in the source.
221 2007-01-16 Sergey P. Kondratyev <se@unicom.tomica.ru>
223 * generic.cs (TypeParameter.FindMembers): Use the generic
224 constraints, not the constraints to check for methods (first fix
227 2006-12-30 Marek Safar <marek.safar@gmail.com>
229 * cs-parser.jay: Better syntax errors handling.
231 2006-11-21 Marek Safar <marek.safar@gmail.com>
233 * cs-parser.jay: Tiny change to work with mcs tokenizer.
235 * cs-tokenizer.cs: Remove after unification with mcs.
237 2006-10-28 Marek Safar <marek.safar@gmail.com>
240 * generic.cs (ConstructedType.AsAccessible): Check accessibility of type
243 2006-10-26 Marek Safar <marek.safar@gmail.com>
246 * cs-tokenizer.cs (IsCastToken): Enable a cast of anonymous methods.
248 2006-10-25 Brian Crowell <brian@fluggo.com>
251 * generic.cs (CheckConstraints): Allow generic parameters with
252 inheritance constraints to satisfy reference type constraints.
254 2006-10-09 Martin Baulig <martin@ximian.com>
257 (NullCoalescingOperator.DoResolve): Fix #78964; added gtest-294.cs.
259 2006-09-25 Martin Baulig <martin@ximian.com>
261 * class.cs: Remove after unification with mcs source.
263 2006-09-24 Raja R Harinath <harinath@gmail.com>
265 * convert.cs: Remove after unification with mcs source.
267 2006-09-24 Marek Safar <marek.safar@seznam.cz>
269 * class.cs (MemberBase.VerifyClsCompliance): When method has type
270 parameters verify them as well.
272 * generic.cs (Constraints.VerifyClsCompliance): Verify CLS-Compliance of
273 the type parameter constraints.
274 (Generics.VerifyClsCompliance): Ditto.
276 2006-09-24 Marek Safar <marek.safar@seznam.cz>
278 * anonymous.cs (AnonymousMethod.Compatible): Cannot generate arguments
279 for anonymous block with out argument.
281 2006-09-24 Marek Safar <marek.safar@seznam.cz>
283 * class.cs (ClassOrStruct.VerifyMembers): Fixed to report correctly
284 not used private events only.
286 2006-09-23 Marek Safar <marek.safar@seznam.cz>
288 * convert.cs (ImplicitReferenceConversion): NullCast to EmptyConstantCast.
290 * cs-parser.jay: Parse correctly cast of default (T).
292 * generic.cs (DefaultValueExpression.DoResolve): Check for void type.
293 Store original type via EmptyConstantCast.
295 2006-09-22 Martin Baulig <martin@ximian.com>
297 * delegate.cs: Removed; this file is now shared with mcs.
299 * attribute.cs: Removed; this file is now shared with mcs.
301 2006-09-22 Martin Baulig <martin@ximian.com>
303 * ecore.cs: Removed; this file is now shared with mcs.
305 2006-09-21 Marek Safar <marek.safar@seznam.cz>
307 * convert.cs (ImplicitReferenceConversion): Reuse ToType.
309 * ecore.cs (NullCast): Derives from NullConstant.
311 * generic.cs (DefaultValueExpression): Fixed to cope with the constant
314 2006-09-21 Martin Baulig <martin@ximian.com>
316 * decl.cs: Removed; this file is now shared with mcs.
318 2006-09-21 Raja R Harinath <rharinath@novell.com>
320 * rootcontext.cs: Remove after unification with mcs source.
322 * report.cs: Remove after unification with mcs source.
323 * generic.cs (AddTypeParameter, LookupTypeParameter): Move to
325 (InitGenerics, CleanUpGenerics): Remove.
327 * support.cs: Remove after unification with mcs source.
329 2006-09-20 Raja R Harinath <rharinath@novell.com>
331 * codegen.cs: Remove after unification with mcs source.
333 2006-09-19 Martin Baulig <martin@ximian.com>
335 * expression.cs: Removed; this file is now shared with mcs.
337 2006-09-19 Martin Baulig <martin@ximian.com>
340 (TypeManager.IsEqual): Moved into ../mcs/typemanager.cs.
341 (TypeManager.DropGenericTypeArguments): Likewise.
342 (TypeManager.DropGenericMethodArguments): Likewise.
343 (TypeManager.GetTypeArguments): Likewise.
344 (TypeManager.HasGenericArguments): Likewise.
346 2006-09-19 Martin Baulig <martin@ximian.com>
348 * ecore.cs (PropertyExpr.InstanceResolve): Fix the CS1540 check.
350 2006-09-19 Martin Baulig <martin@ximian.com>
352 * typemanager.cs: Removed; this file is now shared with mcs.
354 2006-09-16 Raja R Harinath <rharinath@novell.com>
356 * Makefile (LOCAL_MCS_FLAGS): Use instead of PROFILE_MCS_FLAGS.
357 * AssemblyInfo.cs, driver.cs: Remove after unification with mcs source.
359 2006-09-16 Marek Safar <marek.safar@seznam.cz>
362 * class.cs (MethodCore.VerifyClsCompliance): Do check for abstract members
363 only if parent type is class.
364 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Fixed missing cache
367 2006-09-15 Marek Safar <marek.safar@seznam.cz>
370 * expression.cs(MemberAccess.DoResolve): Don't crash when not allowed
372 * typemanager.cs(CSharpName): Converts NullType to null.
374 2006-09-15 Martin Baulig <martin@ximian.com>
376 * pending.cs: Removed; this file is now shared with mcs.
378 2006-09-15 Martin Baulig <martin@ximian.com>
380 * statement.cs: Removed; this file is now shared with mcs.
382 2006-09-15 Martin Baulig <martin@ximian.com>
384 * rootcontext.cs (RootContext.BrokenCircularDeps): Removed.
386 * driver.cs: Removed the `--broken-cycles' argument.
388 2006-09-15 Martin Baulig <martin@ximian.com>
390 * namespace.cs: Removed; this file is now shared with mcs.
392 2006-09-15 Martin Baulig <martin@ximian.com>
394 * decl.cs (MemberName): Minor code cleanups.
396 2006-09-15 Martin Baulig <martin@ximian.com>
398 * parameter.cs: Removed; this file is now shared with mcs.
400 2006-09-15 Martin Baulig <martin@ximian.com>
402 * enum.cs: Removed; this file is now shared with mcs.
404 2006-09-15 Martin Baulig <martin@ximian.com>
406 * Makefile: Define `GMCS_SOURCE'.
408 * flowanalysis.cs: Removed; this file is now shared with mcs.
410 2006-09-15 Martin Baulig <martin@ximian.com>
412 Removed modifiers.cs, literal.cs, location.cs, roottypes.cs,
413 assign.cs, const.cs, cfold.cs, constant.cs, symbolwriter.cs and
414 doc.cs - they are now shared with mcs.
416 * gmcs.exe.sources: Include these files from ../mcs/.
418 2006-09-15 Martin Baulig <martin@ximian.com>
420 * old-code.cs, gen-il.cs, gen-treedump.cs: Removed old stuff.
421 * g1.cs, sample-hello.cs, sample-stack.il: Likewise.
423 2006-09-14 Marek Safar <marek.safar@seznam.cz>
425 * assign.cs, ecore.cs, expression.cs: Share error message text.
426 * class.cs (FieldMember.Define): Check for variable of static type.
427 * decl.cs (check_type_parameter): Report correct type name.
428 * driver.cs (LoadAssembly): Uses error output for errors.
429 * generic.cs (Constraints.Resolve): Add check for constraint accessibility
430 (TypeArguments.Resolve): Static class cannot be used as an argument.
431 * statement.cs (ResolveMeta): Constants cannot be generic types.
433 2006-09-12 Martin Baulig <martin@ximian.com>
435 * generic.cs (TypeManager.IsIList): Moved into convert.cs.
437 * convert.cs (Convert.Array_To_IList): Moved here and correctly
438 implement it; fixes #79345.
440 2006-09-08 Marek Safar <marek.safar@seznam.cz>
442 * decl.cs (DeclSpace.SetParameterInfo): Check for nonexistent type
444 * expression.cs (TypeOf.GetAttributableValue): Check for open generic
446 * generic.cs: Improved error messages.
447 * typemanager.cs (RemoveGenericArity): Made public.
449 2006-09-08 Martin Baulig <martin@ximian.com>
451 * typemanager.cs (TypeManager.interlocked_type): New public field.
452 (TypeManager.int_interlocked_compare-exchange): New public field.
453 (TypeManager.InitEnumUnderlyingTypes): Also initialize the
454 enumerator types here and call InitGenericCoreTypes().
455 (TypeManager.InitCoreTypes): Call InitEnumeratorTypes() right
456 after calling InitEnumUnderlyingTypes().
459 (RootContext.ResolveCore): Added `System.Threading.Interlocked' to
460 `classes_second_stage'.
462 2006-09-07 Marek Safar <marek.safar@seznam.cz>
464 * class.cs, generic.cs (GenericMethod.Define): Check for type parameter
466 * statement.cs (Block.Variables): Made public.
468 2006-09-07 Martin Baulig <martin@ximian.com>
471 (MainDriver): Revert r62663 from Marek; see #70506 for details.
473 2006-09-01 Martin Baulig <martin@ximian.com>
476 (TypeManager.IsIList): Also handle base classes and interfaces.
478 2006-09-01 Raja R Harinath <rharinath@novell.com>
481 * expression.cs (Invocation.MoreSpecific): Check for reference
484 2006-08-29 Miguel de Icaza <miguel@novell.com>
486 * cs-parser.jay: Turn 1522 into a warning, instead of an error #79210
488 2006-08-17 Miguel de Icaza <miguel@novell.com>
490 * cs-tokenizer.cs: Apply patch from Atsushi Enomoto that fixes
491 #52019 and #79064, the use of the \uXXXX sequence in source code
492 to represent unicode characters.
494 2006-08-15 Marek Safar <marek.safar@seznam.cz>
496 * expression.cs (SizeOf.DoResolve): Check for void type. Fixed enum types
498 * class.cs, ecore.cs, statement.cs: Merged to one error message.
500 2006-08-14 Raja R Harinath <rharinath@novell.com>
503 * cs-tokenizer.cs (parse_less_than): Allow '*' to appear in a type
504 parameter too. This only avoids a parse error -- the semantic
505 error is caught elsewhere.
507 2006-08-13 Miguel de Icaza <miguel@novell.com>
509 * assign.cs: Catch attempts to assign to a method groups in += and
512 2006-08-13 Marek Safar <marek.safar@seznam.cz>
515 * cs-parser.jay: Don't destroy current array type by typeof of array's.
517 2006-08-12 Marek Safar <marek.safar@seznam.cz>
519 * cs-parser.jay: Check whether a constraint clause has already been
520 specified for type parameter.
521 * generic.cs (Constraints): Exposed location.
523 2006-08-12 Marek Safar <marek.safar@seznam.cz>
525 * class.cs (Method.Define): Issue a warning when generic method looks like
527 * decl.cs (MemberCore.GetSignatureForError): Print member type arguments
529 * report.cs: New warning number.
531 2006-08-09 Marek Safar <marek.safar@seznam.cz>
533 * anonymous.cs(AnonymousDelegate.Emit): Uses Constructor filter when
535 * decl.cs (MemberCache.FindMembers): When container is interface we need to
536 search all base interfaces as a member can be ambiguous.
537 * delegate.cs (Delegate.FindMembers): Fixed to return valid data for
538 Constructor member type filter.
539 (Delegate.ResolveConstructorMethod) Uses Constructor filter.
540 * ecore.cs: (Expression.MemberLookup): Implemented ambiguity error/warning
541 reporting for returned memberinfos.
542 * report.cs: Updated.
543 * typemanager.cs (TypeManager.LookupBaseInterfacesCache): Uses TypeManager
544 version to work on all runtimes.
545 (TypeManager.RealMemberLookup): Removed members filtering.
547 2006-08-08 Raja R Harinath <rharinath@novell.com>
549 * ecore.cs (FieldExpr.EmitAssign): Release temporary.
550 (PropertyExpr.EmitAssign): Likewise.
551 * expression.cs (Indirection.EmitAssign): Likewise.
552 (LocalVariableReference.EmitAssign): Likewise.
553 (ParameterReference.EmitAssign): Likewise.
554 (Invocation.EmitArguments): Likewise.
555 (ArrayAccess.EmitAssign): Likewise.
556 (IndexerAccess.EmitAssign): Likewise.
557 (This.EmitAssign): Likewise.
558 (ConditionalLogicalOperator.Emit): Likewise.
561 * codegen.cs (EmitContext.GetTemporaryLocal): Simplify. Use Stack
562 instead of ArrayList. If the hashtable has a LocalBuilder, don't
563 leave it in after returning it.
564 (EmitContext.FreeTemporaryLocal): Simplify. Update to changes.
566 2006-08-06 Marek Safar <marek.safar@seznam.cz>
568 * expresssion.cs (IndexerAccess.DoResolve): Fixed to report correct error
571 2006-08-05 Marek Safar <marek.safar@seznam.cz>
573 * class.cs (TypeContainer.AddPartial): Add check for partial declarations
574 with different type names.
575 (TypeContainer.UpdateTypeParameterConstraints): Updated an error message.
577 2006-08-03 Raja R Harinath <rharinath@novell.com>
579 Fix cs0146-3.cs and cs0146-4.cs.
580 * class.cs (TypeManager.CheckRecursiveDefinition): Check that
581 enclosing types don't depend on the current type.
583 2006-08-02 Raja R Harinath <rharinath@novell.com>
586 * class.cs (TypeContainer.DoDefineMembers): Use
587 FindBaseMemberWithSameName on Parent, since we're interested in
588 whether we hide inherited members or not.
589 (FindBaseMemberWithSameName): Make slightly more robust.
592 * codegen.cs (IResolveContext.GenericDeclContainer): New.
593 (EmitContext): Implement new interface requirement.
594 * namespace.cs (UsingEntry, LocalAliasEntry): Likewise.
595 * decl.cs (MemberCore): Likewise.
596 (DeclSpace.GenericDeclContainer): Rename from DeclContainer.
597 * ecore.cs (SimpleName.ResolveAsTypeTerminal): Use
598 ec.GenericDeclContainer to check for generic parameters.
599 (SimpleName.DoSimpleNameResolve): Likewise.
600 * generic.cs (TypeParameter.DeclContainer): Remove override.
602 * namespace.cs (NamespaceEntry.Doppelganger): Create slave
603 declspaces for doppelgangers too.
604 (UsingEntry): Implement IResolveContext.
605 (UsingEntry.Resolve): Don't set ToplevelTypes.Namespace. Use
606 'this' as the resolve context.
607 (LocalAliasEntry): Likewise.
609 Implement parts of #77403
610 * roottypes.cs (RootDeclSpace): New. Used to represent the
611 toplevel declaration space. Each namespace declaration introduces
612 a "partial" root declaretion space.
613 * namespace.cs (NamespaceEntry.SlaveDeclSpace): New.
614 (NamespaceEntry.ctor): Create a SlaveDeclSpace if necessary.
615 * cs-parser.jay (CSharpParser.ctor): Initialize 'current_class'
616 from 'current_namespace.SlaveDeclSpace'.
617 (namespace_declaration): Likewise.
618 * class.cs (TypeContainer.ctor): Remove parent==ToplevelTypes
619 check. It can't happen now.
620 * decl.cs (DeclSpace.LookupType): Likewise.
621 * driver.cs (MainDriver): Sanity check.
623 2006-08-01 Raja R Harinath <rharinath@novell.com>
625 * decl.cs (DeclSpace.FindNestedType): Remove.
626 (DeclSpace.LookupNestedTypeINHierarchy): Use PartialContainer and
627 LookupTypeContainer to get the container of the nested type.
628 * class.cs (TypeContainer.FindNestedType): Make non-override.
630 2006-07-31 Raja R Harinath <rharinath@novell.com>
632 * decl.cs (DeclSpace.PartialContainer): Move field from ...
633 * class.cs (TypeContainer.PartialContainer): ... here.
634 (TypeContainer.AddBasesForPart): New helper.
635 (MemberBase.ParentContainer): Remove. Use Parent.PartialContainer
637 * cs-parser.jay (current_class): Convert to DeclSpace.
638 (struct_declaration, interface_declaration, class_declaration):
639 Use AddBasesForPart instead of .Bases directly.
640 * const.cs, iterators.cs: Update to changes.
642 2006-07-28 Raja R Harinath <rharinath@novell.com>
644 * class.cs (TypeContainer.AddMemberType): Rename from
646 (TypeContainer.AddMember): Rename from AddToMemberContainer.
647 (AddTypeContainer): New. Combine AddClassOrStruct and
649 (AddPartial): Update. Add 'is_partial' argument.
650 * roottypes.cs: Update to changes.
651 * cs-parser.jay (push_current_class): New helper for handling
652 current_container and current_class.
653 (struct_declaration, interface_declaration, class_declaration):
656 2006-07-26 Raja R Harinath <rharinath@novell.com>
658 * roottypes.cs: Rename from tree.cs.
660 Rename RootContext.Tree.Types to RootContext.ToplevelTypes.
661 * tree.cs (Tree, ITreeDump): Remove types.
662 * rootcontext.cs (tree, Tree): Remove fields.
663 (root, ToplevelTypes): New.
664 * *.cs: Update to rename.
666 * tree.cs (Tree.RecordDecl): Remove.
667 (RootTypes.AddToTypeContainer): Record the toplevel type in its
669 * class.cs, cs-parser.jay: Remove mention of RecordDecl.
671 2006-07-23 Raja R Harinath <harinath@gmail.com>
673 * codegen.cs (EmitContext.Flags): Move InCatch, InFinally,
674 DoFlowAnalysis and OmitStructFlowAnalysis here.
675 (ec.With): Rename from WithUnsafe and generalize.
676 (ec.WithCheckState): Remove. All users can be handled by 'With'.
677 (ec.WithFlowAnalyis): New.
678 * ecore.cs, expression.cs, statement.cs: Update.
680 2006-07-22 Raja R Harinath <harinath@gmail.com>
682 * statement.cs (Block.ResolveMeta): Simplify slightly.
684 * codegen.cs (EmitContext.Flags): New enum. Used to represent the
685 multiple boolean fields. Convert InUnsafe, constant_check_state,
686 check_state to flags.
687 (CheckState, ConstantCheckState): Update.
688 (InUnsafe): New read-only property.
689 (FlagsHandle): Rename from CheckStateHandle and convert to handle
691 (WithUnsafe): New helper similar to WithCheckState.
692 * statement.cs (Block.ResolveMeta): Use WithUnsafe.
693 (Unsafe.Resolve, Unsafe.DoEmit): Likewise.
695 2006-07-21 Raja R Harinath <rharinath@novell.com>
697 Make comparisons use the same IL irrespective of whether they're
698 in a 'checked' or 'unchecked' context: one of the issues in #78899
699 * codegen.cs (EmitContext.CheckState): Make read-only property.
700 (EmitContext.ConstantCheckState): Likewise.
701 (EmitContext.CheckStateHandle, EmitContext.WithCheckState): New
702 helper that implement a save/restore stack for CheckState
703 values. This is the only way to change check-state.
704 * ecore.cs (Expression.ExpressionToArrayArgument): Use WithCheckState.
705 * expression.cs (CheckedExpr.DoResolve, CheckedExpr.Emit): Likewise.
706 (CheckedExpr.EmitBranchable): New forwarding method.
707 (UnCheckedExpr): Likewise.
708 * statement.cs (Block.ResolveMeta): Use WithCheckState.
709 (Unchecked.Resolve, Unchecked.DoEmit): Likewise.
710 (Checked.Resolve, checked.DoEmit): Likewise.
712 2006-07-21 Martin Baulig <martin@ximian.com>
714 * generic.cs (TypeManager.InferType): When inferring an array
715 type, also allow IList<T> and ICollection<T>. Fixes #78900.
717 2006-07-21 Martin Baulig <martin@ximian.com>
719 * generic.cs (TypeManager.IsIEnumerable): Renamed into IsIList()
720 and allow IList`1 and all its base interfaces.
722 * convert.cs (Convert.ImplicitReferenceConversion): Allow
723 converting from an array-type of T to IList<T>.
725 2006-07-21 Martin Baulig <martin@ximian.com>
727 * ecore.cs (SimpleName.DoSimpleNameResolve): Added CS0307 check.
729 2006-07-20 Miguel de Icaza <miguel@novell.com>
731 * anonymous.cs: Cache the resolved anonymous delegate, and return
732 this so that the ResolveTopBlock is only triggered once, not
735 Currently we trigger ResolvetopBlock twice due to a first pass of
736 argument check compatibility, and a second pass that does the
739 2006-07-15 Marek Safar <marek.safar@seznam.cz>
741 * annonymous.cs (AnonymousMethod.CreateScopeType): Fixed nested type
743 * rootcontext.cs (Reset): Add helper_classes.
745 2006-07-15 Marek Safar <marek.safar@seznam.cz>
748 * statement.cs (Switch.SimpleSwitchEmit): Handle case null at any position
751 2006-07-13 Miguel de Icaza <miguel@novell.com>
753 * statement.cs (Lock): Handle expressions of type
754 TypeManager.null_type specially. Fixes #78770
756 2006-07-08 Marek Safar <marek.safar@seznam.cz>
758 * expression.cs (Binary.ResolveOperator): Don't crash when null is assigned
761 2006-07-08 Marek Safar <marek.safar@seznam.cz>
763 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Fixed to look
764 for accessors as well.
765 * ecore.cs (EventExpr): Add AccessorTable.
767 2006-07-03 Martin Baulig <martin@ximian.com>
769 * ecore.cs (UnboxCast.Emit): Also use `Unbox_Any' for generic
770 instances of value types.
772 * convert.cs (Convert.ExplicitConversion): Correctly handle
773 object->nullable conversions.
775 2006-07-01 Marek Safar <marek.safar@seznam.cz>
778 * attribute.cs, class.cs, ecore.cs : Add missing location of related symbol
779 for CS0122 where appropriate.
780 * typemanager.cs (IsNestedChildOf): Type can be null in the case of top
782 (Filter): Assembly can be null in the case of top level attributes.
784 2006-06-28 Raja R Harinath <rharinath@novell.com>
787 * generic.cs (TypeManager.InferParamsTypeArguments): If there are
788 no arguments, return 'false': nothing can be inferred.
790 2006-06-25 Marek Safar <marek.safar@seznam.cz>
794 * ecore.cs (Expression.MemberLookupFailed): Don't crash when failed lookup
795 is done at global level.
797 2006-06-24 Marek Safar <marek.safar@seznam.cz>
799 A fix for #77002, Implemented TypeForwarder support.
801 * attribute.cs (Attribute.GetArgumentType): Reads type argument.
802 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Add TypeForwarder
804 * expression.cs (TypeOf.TypeArgument): Exposes typeof type.
805 * typemanager.cs (): Add type_forwarder_attr_type.
807 2006-06-24 Marek Safar <marek.safar@seznam.cz>
809 * report.cs: Add CS0469 warning.
811 2006-06-22 Martin Baulig <martin@ximian.com>
814 (TypeContainer.GetNormalBases): Also use ResolveAsBaseTerminal()
815 for interfaces; fixes #78686, which is a modification of #78380
816 with interfaces instead of classes.
818 2006-06-21 Martin Baulig <martin@ximian.com>
820 * codegen.cs (CodeGen.Save): Moved the symbol file generation into
821 the `try'-block, so we also report CS0016 etc. there.
823 2006-06-21 Martin Baulig <martin@ximian.com>
825 * ecore.cs (FieldExpr.EmitAssign, FieldExpr.AddressOf): Correctly
826 handle SetAssigned() and SetMemberIsUsed() for generic types;
829 2006-06-21 Martin Baulig <martin@ximian.com>
832 (Delegate.VerifyMethod): Allow `params' methods; fixes #78678.
834 2006-06-21 Martin Baulig <martin@ximian.com>
836 * expression.cs (Unary.ResolveOperator): In `Operator.AddressOf',
837 also report CS1686 for parameters.
839 2006-06-21 Martin Baulig <martin@ximian.com>
841 * statement.cs (GotoCase.Resolve): Report a warning (CS0469)
842 instead of an error if the value is not implicitly convertible to
843 the switch types; fixes #77964.
845 2006-06-21 Raja R Harinath <rharinath@novell.com>
848 * class.cs (FieldBase.ResolveInitializer): Stop resolution if
849 FieldBuilder is null.
852 * expression.cs (Binary.CheckShiftArguments): Don't overwrite original
853 'left' and 'right' before error-checking.
855 2006-06-19 Martin Baulig <martin@ximian.com>
858 (Convert.ImplicitConversionStandard): Cleanup and correctly
859 implement nullable conversions.
860 (Convert.ImplicitStandardConversionExists): Likewise.
861 (Convert.ExplicitConversion): Likewise.
863 2006-06-19 Martin Baulig <martin@ximian.com>
866 (Nullable.Wrap.Create, Nullable.Unwrap.Create): New public static
867 methods; make the ctors protected.
869 2006-06-19 Martin Baulig <martin@ximian.com>
871 Fixed #78380; added gtest-273.cs.
874 (Expression.ResolveAsBaseTerminal): Move the constraint checking
875 into ResolveAsTypeTerminal().
878 (ConstraintChecker.HasDefaultConstructor): Use the non-cache based
879 TypeManager.FindMembers() to check for the default ctor.
881 2006-06-18 Marek Safar <marek.safar@seznam.cz>
883 * generic.cs: Fixed NullableInfo accessibility.
885 2006-06-16 Martin Baulig <martin@ximian.com>
888 (Constraints.InflatedConstraints.inflate): Correctly inflate
889 generic types; fixes #78400.
891 2006-06-16 Juraj Skripsky <js@hotfeet.ch>
893 * ecore.cs (SimpleName.Error_ObjectRefRequired): Do not truncate the name.
895 (MemberExpr.EmitInstance): Use GetSignatureForError () to get full name.
896 (FieldExpr.DoResolve): likewise.
897 (PropertyExpr.InstanceResolve): likewise.
898 (EventExpr.InstanceResolve): likewise.
900 2006-06-15 Martin Baulig <martin@ximian.com>
903 (SwitchLabel.ResolveAndReduce): Added `bool allow_nullable'
904 argument; always allow a `null' label if true.
905 (Switch.SwitchGoverningType): Take an `Expression expr' argument.
906 (Switch.TableSwitchEmit, Switch.SimpleSwitchEmit): Check whether
907 we have a `null' label and mark the new `null_target' label;
908 default to the `default' label.
909 (Switch.Resolve): Add support for nullable types. Fixes #78630.
911 2006-06-15 Martin Baulig <martin@ximian.com>
913 * class.cs (Operator.Define): Allow an implicit/explicit operator
914 to convert to/from a nullable value of the enclosing type.
916 * generic.cs (TypeManager.IsNullableTypeOf): New public method.
917 (Nullable.Unwrap, Nullable.Wrap): Make these classes public.
920 (Convert.ImplicitStandardConversionExists): Add support for lifted
921 implicit/explicit conversions.
922 (Convert.ImplicitConversionStandard): Likewise.
924 2006-06-13 Martin Baulig <martin@ximian.com>
926 * ecore.cs (SimpleName.DoSimpleNameResolve): Check whether we have
927 type arguments and create a ConstructedType if necessary. Fixes #78400.
929 2006-06-04 Marek Safar <marek.safar@seznam.cz>
931 * parameter.cs (Parameter.ApplyAttributeBuilder): More DefaultValue
932 attribute applicable tests for attribute argument.
934 2006-06-02 Raja R Harinath <rharinath@novell.com>
937 * expression.cs (Binary.DoNumericPromotions): Remove and rewrite.
938 (Binary.OverloadResolve_PredefinedIntegral): New.
939 (Binary.OverloadResolve_PredefinedFloating): New.
940 (Binary.OverloadResolve_PredefinedString): New.
941 (Binary.ResolveOperator): Use those instead of DoNumericPromotions.
942 Follow the standard more closely, and treat numeric promotions in
943 terms of overload resolution.
944 (Binary.CheckShiftArguments): Simplify.
946 2006-06-01 Raja R Harinath <rharinath@novell.com>
948 * flowanalysis.cs (MyBitVector): Simplify representation.
949 (MyBitVector.Clone): Avoid allocating BitArray.
950 (MyBitVector.operator&): Rename from MyBitVector.And and make symmetric.
951 (MyBitVector.operator|): Likewise, with MyBitVector.Or.
952 (*): Update. Change all references to MyBitVector.And and
953 MyBitVector.Or to &= and |=.
955 2006-05-31 Raja R Harinath <rharinath@novell.com>
957 * generic.cs (Nullable.LiftedBinaryOperator.EmitEquality):
958 Use bne.un instead of ceq+brfalse.
961 * typemanager.cs (IsUnmanagedType): Disallow generic types and
964 2006-05-29 Raja R Harinath <rharinath@novell.com>
967 * cs-parser.jay (formal_parameter_list): Extend the pattern below
968 to param arguments too.
970 2006-05-26 Miguel de Icaza <miguel@novell.com>
972 * cs-parser.jay: Catch another parsing form for arglist being
973 followed by other arguments. Fixes #78313.
975 2006-05-25 Raja R Harinath <rharinath@novell.com>
978 * expression.cs (Binary.DoResolve): Use Nullable.LiftedBinaryOperator
979 also when one of the operands is a null literal.
980 * generic.cs (Nullable.LiftedBinaryOperator.EmitEquality): Rewrite
981 to improve clarity, and generate slightly better code.
983 2006-05-24 Raja R Harinath <rharinath@novell.com>
985 * flowanalysis.cs (FlowBranchingToplevel.AddReturnOrigin): Move
986 checking of out parameters to ...
987 (FlowBranchingToplevel.Merge): ... here.
988 (FlowBranchingException.AddBreakOrigin): If 'finally_vector' is
989 set, propagate the origin upward, and only complain if there was
991 (FlowBranchingException.AddContinueOrigin): Likewise.
992 (FlowBranchingException.AddReturnOrigin): Likewise.
993 (FlowBranchingException.AddGotoOrigin): Likewise.
995 2006-05-23 Raja R Harinath <rharinath@novell.com>
997 * flowanalysis.cs (UsageVector.MergeOrigins): If an origin is
998 unreachable, skip it.
999 (FlowBranchingException.Merge): Always propagate jumps, even if
1000 the finally block renders subsequent code unreachable.
1002 2006-05-18 Raja R Harinath <rharinath@novell.com>
1005 * statement.cs (Goto.Resolve): Move responsibility for resolving
1006 'goto' to FlowBranching.AddGotoOrigin.
1007 (Goto.SetResolvedTarget): New. Callback to set the
1008 LabeledStatement that's the target of the goto.
1009 (Goto.DoEmit): Use Leave instead of Br when crossing an
1010 unwind-protect boundary.
1011 * flowanalysis.cs (FlowBranching.AddGotoOrigin): Rename from
1012 LookupLabel and adjust to new semantics.
1013 (FlowBranchingToplevel.AddGotoOrigin): Likewise.
1014 (FlowBranchingBlock.AddGotoOrigin): Likewise. Use
1015 Goto.SetResolvedTarget to update target.
1016 (FlowBranchingLabeled.AddGotoOrigin): Likewise.
1017 (FlowBranchingException.AddGotoOrigin): Rewrite to be similar to
1018 AddBreakOrigin & co. Delay propagation until ...
1019 (FlowBranchingException.Merge): ... this.
1021 * statement.cs (Block.Resolve): Always depend on flow-branching to
1022 determine unreachability. Kill workaround that originally emitted
1023 only one statement after an "unreachable" label (see infloop in
1026 Fix #77869, #76148, #77755, #75255 and a host of other bugs.
1027 This is still "wrong", but anything better would probably need a
1028 multi-pass algorithm.
1029 * flowanalysis.cs (FlowBranchingLabeled): Salt away a copy of the
1030 usage vector. Force current usage vector to be reachable, to
1031 optimistically signify backward jumps.
1032 (FlowBranchingLabeled.LookupLabel): Note if a backward jump is
1034 (FlowBranchingLabeled.Merge): New. If no backward jump was
1035 detected, return the original salted-away usage vector instead,
1036 updated with appropriate changes. Print unreachable warning if
1038 * statement.cs (Block.Resolve): Don't print unreachable warning on
1039 a labeled statement.
1041 2006-05-17 Gert Driesen <drieseng@users.sourceforge.net>
1043 * driver.cs: Pass filename without path to AssemblyBuilder's
1044 AddResourceFile. Fixes bug #78407.
1046 2006-05-17 Raja R Harinath <rharinath@novell.com>
1048 * statement.cs (LabeledStatement.Resolve): Move merging of origins ...
1049 * flowanalysis.cs (FlowBranchingLabeled): ... here.
1050 (FlowBranching.MergeChild): Overwrite
1051 reachability information from Labeled branchings too.
1053 2006-05-16 Raja R Harinath <rharinath@novell.com>
1055 * statement.cs (Goto.Resolve): Merge jump origins here ...
1056 * flowanalysis.cs (FlowBranching.Label): ... rather than here.
1058 * flowanalysis.cs (FlowBranching.LookupLabel): Move CS0159 check ...
1059 (FlowBranchingToplevel.LookupLabel): ... here. Add CS1632 check.
1060 (FlowBranchingGoto.LookupLabel): New. Handle back jumps.
1061 (FlowBranchingBlock.LookupLabel): Call LabeledStatement.AddReference
1063 * statement.cs (Goto.Resolve): ... not here.
1064 (Goto.Emit): Remove CS1632 check.
1066 2006-05-14 Marek Safar <marek.safar@seznam.cz>
1068 * ecore.cs (Expression.ResolveAsTypeTerminal): Fixed type in the obsolete
1071 2006-05-11 Raja R Harinath <rharinath@novell.com>
1073 * flowanalysis.cs (UsageVector.MergeJumpOrigins): Kill.
1074 (FlowBranchingBlock.Label): Use UsageVector.MergeOrigins.
1075 (FlowBranchingException.Label): Likewise.
1077 * flowanalysis.cs (MyBitVector.SetAll): New. Sets all bits to the
1079 (MyBitVector.Or): Use it to avoid losing information (Count).
1080 (FlowBranching.MergeOrigins): Likewise.
1082 * flowanalysis.cs (UsageVector.IsDirty): Remove.
1083 (UsageVector.Parameters, UsageVector.ParameterVector): Likewise.
1084 (UsageVector.Locals, UsageVector.LocalVector): Likewise.
1085 (UsageVector.ToString): Simplify.
1086 (UsageVector.MergeSiblings): Move here from ...
1087 (FlowBranching.Merge): ... here.
1088 (FlowBranchingToplevel.CheckOutParameters): Take an UsageVector,
1091 2006-05-10 Raja R Harinath <rharinath@novell.com>
1093 * flowanalysis.cs (UsageVector.MergeOrigins): Simplify, now that a
1094 null bitvector is treated as all-true.
1096 * flowanalysis.cs (MyBitVector.And, MyBitVector.Or): Make lazier.
1097 (MyBitVector): Rationalize invariants. 'vector != null' implies
1098 that we have our own copy of the bitvector. Otherwise,
1099 'InheritsFrom == null' implies all inherited bits are true.
1101 2006-05-09 Marek Safar <marek.safar@seznam.cz>
1103 * statement.cs (LocalInfo): Add IsConstant.
1104 (LocalInfo.DeclareLocal): Moved from EmitMeta and changed to don't emit
1105 local variable for constants.
1107 2006-05-09 Raja R Harinath <rharinath@novell.com>
1109 * flowanalysis.cs (MyBitVector.Empty): New.
1110 (MyBitVector): Don't allow InheritedFrom to be null.
1111 (MyBitVector.And, MyBitVector.Or): Treat 'null' as all-ones.
1112 (UsageVector, FlowBranching): Update to changes.
1114 * flowanalysis.cs (FlowBranching.InTryWithCatch): Don't terminate
1115 recursion. The 'Parent == null' condition isn't sufficient for
1117 (FlowBranching.AddBreakOrigin): Likewise.
1118 (FlowBranching.AddContinueOrigin): Likewise.
1119 (FlowBranching.AddReturnOrigin): Likewise.
1120 (FlowBranching.StealFinallyClauses): Likewise.
1121 (FlowBranching.MergeTopBlock): Move to FlowBranchingToplevel.
1122 (FlowBranching.CheckOutParameters): Likewise.
1123 (FlowBranchingToplevel): Terminate all the above recursions here.
1124 (FlowBranchingToplevel.End): Rename from MergeTopBlock.
1125 * codegen.cs (EmitContext.ResolveTopBlock): Update to changes.
1127 * flowanalysis.cs (BranchingType.Toplevel): New. Represents a
1129 (FlowBranchingToplevel): New. Empty for now.
1130 (FlowBranching.MergeTopBlock): Update.
1131 * codegen.cs (EmitContext.ResolveTopBlock): Create a Toplevel
1132 branching for the anonymous delegate.
1133 (EmitContext.StartFlowBranching): Add ToplevelBlock variant.
1135 * flowanalysis.cs (UsageVector.MergeOrigins): Reorganize.
1136 (UsageVector.MergeJumpOrigins): Don't ignore current reachability
1137 information at the start of the merge. Reorganize.
1139 2006-05-07 Marek Safar <marek.safar@seznam.cz>
1141 * class.cs (MethodData.Define): Method cannot implement interface accessor.
1143 2006-05-07 Marek Safar <marek.safar@seznam.cz>
1145 * expression.cs (QualifiedAliasMember.ResolveAsTypeStep): Pass location
1146 to newly introduced ctor.
1148 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Moved an error
1149 message to one place.
1150 (GlobalRootNamespace.Error_NamespaceDoesNotExist): Custom message for
1153 2006-05-07 Marek Safar <marek.safar@seznam.cz>
1155 * const.cs (Const.Error_ExpressionMustBeConstant): Better error message.
1157 * ecore.cs (Expression.ResolveAsConstant): Updated.
1159 * statement.cs (ResolveMeta): Updated.
1161 2006-05-06 Marek Safar <marek.safar@seznam.cz>
1163 * cs-parser.jay: __arglist cannot be used in initializer.
1165 2006-05-06 Marek Safar <marek.safar@seznam.cz>
1168 * namespace.cs (LocalAliasEntry.DoResolve): Don't allow to access nested
1171 2006-05-05 Raja R Harinath <rharinath@novell.com>
1173 * statement.cs (EmptyStatement.ResolveUnreachable): Override.
1174 (LabeledStatement): Add 'name' parameter.
1175 (LabeledStatement.Name, LabeledStatement.JumpOrigins): New.
1176 (Block.AddLabel): Update to changes.
1177 * cs-parser.jay (labeled_statement): Likewise.
1179 * flowanalysis.cs (BranchingType.Labeled): New.
1180 (UsageVector.MergeOrigins): Remove unused 'branching' argument.
1181 (FlowBranchingLabeled): New. Does nothing for now, but will
1182 eventually handle 'goto' flows.
1183 * codegen.cs (StartFlowBranching): Add new LabeledStatement variant.
1184 * statement.cs (LabeledStatement.Resolve): Create a FlowBranching
1185 that's terminated ...
1186 (Block.Resolve): ... here.
1188 * flowanalysis.cs (UsageVector.MergeFinally): Remove.
1189 (UsageVector.MergeFinallyOrigins): Likewise.
1190 (FlowBranching.InTryOrCatch): Likewise.
1191 (FlowBranching.AddFinallyVector): Likewise.
1192 (FlowBranchingException): Update to changes.
1195 * statement.cs (Return.Resolve): Move error checking to ...
1196 * flowbranching.cs (FlowBranching.AddReturnOrigin): ... this.
1197 (FlowBranchingException): Handle return origins like break and
1199 (FlowBranching.UsageVector.CheckOutParameters): Remove.
1201 2006-05-04 Marek Safar <marek.safar@seznam.cz>
1204 * class.cs (TypeContainer.FindMembers): Includes event method in the methods
1207 2006-05-04 Marek Safar <marek.safar@seznam.cz>
1210 * class.cs (MethodData.Define): Do public accessor check only when method
1211 implements an interface.
1213 2006-05-04 Raja R Harinath <rharinath@novell.com>
1215 Remove special handling of 'break'
1216 * flowanalysis.cs (Reachability): Remove all mention of 'breaks'.
1217 (Reachability.Meet): Simplify. Remove 'do_breaks' argument.
1218 (UsageVector.Break): Remove.
1219 (FlowBranching.Merge): Use 'Reachable.IsUnreachable' to determine
1221 (FlowBranchingBreakable.Merge): Don't ResetBreaks.
1223 * statement.cs (Break.Resolve): Call UsageVector.Goto (), not
1224 UsageVector.Breaks (). Don't set NeedsReturnLabel.
1226 2006-05-03 Marek Safar <marek.safar@seznam.cz>
1229 * pending.cs (PendingImplementation.BaseImplements): A found member cannot
1230 be the interface member.
1232 2006-05-03 Marek Safar <marek.safar@seznam.cz>
1235 * constant.cs (LongConstant.EmitLong): Fixed to catch also negative values
1236 for emitting small (int) values.
1238 2006-05-03 Raja R Harinath <rharinath@novell.com>
1241 * flowanalysis.cs (FlowBranchingException.Merge): Ensure
1242 control-flow passes through the 'finally' after merging-in all the
1243 control-flows from 'try' and the 'catch' clauses.
1245 * flowanalysis.cs (FlowBranching.IsLoop): Remove.
1246 (FlowBranching.IsTryOrCatch): Remove 'is_return' parameter. It's
1247 always true at the only non-recursive entry point.
1248 (FlowBranching.CreateBranching) [BranchingType.Loop]: Return a
1249 FlowBranchingBreakable.
1250 (FlowBranchingLoop): Remove.
1251 * statement.cs (Return.DoResolve): Update to changes.
1254 * flowanalysis.cs (FlowBranching.BranchingType.Embedded): New.
1255 (FlowBranching.CreateBranching): Handle it: create a
1256 FlowBranchingContinuable.
1257 (FlowBranching.BreakCrossesExceptionBoundary): Remove.
1258 (FlowBranching.AddContinueOrigin): Similar to AddBreakOrigin,
1259 except that it handles the 'continue' command.
1260 (FlowBranching.UsageVector.MergeOrigins): Rename from
1262 (FlowBranchingContinuable): Similar to FlowBranchingBreakable,
1263 except that it overrides AddContinueOrigin.
1264 (FlowBranchingException): Override AddContinueOrigin, similar to
1266 * statement.cs (While.Resolve, Foreach.ArrayForeach.Resolve):
1267 Create a new branching around the embedded statement.
1268 (Do.Resolve, For.Resolve): Likewise. Do reachability analysis for
1269 control flow after the embedded statement.
1270 (Continue.Resolve): Move all error checking to AddContinueOrigin.
1272 * flowanalysis.cs (FlowBranching.IsSwitch): Remove.
1273 (FlowBranching.CreateBranching) [BranchingType.Switch]: Create a
1274 FlowBranchingBreakable.
1275 (FlowBranchingSwitch): Remove.
1278 * statement.cs (Break.Resolve): Simplify. Move responsibility for
1279 error reporting to ...
1280 * flowanalysis.cs (FlowBranching.AddBreakOrigin) ... this.
1281 Rename from 'AddBreakVector'. Add new location argument. Return
1282 a bool indicating whether the 'break' crosses an unwind-protect.
1283 (FlowBranchingException.AddBreakOrigin): Add.
1284 (FlowBranchingException.Merge): Propagate 'break's to surrounding
1285 flowbranching after updating with the effects of the 'finally'
1287 (FlowBranchingBreakable): New common base class for
1288 FlowBranchingLoop and FlowBranchingSwitch.
1290 * statement.cs (Foreach.ArrayForeach.Resolve): Set barrier after
1292 (Foreach.CollectionForeach.Resolve): Remove extraneous flowbranching.
1294 2006-05-02 Raja R Harinath <rharinath@novell.com>
1296 * statement.cs (Do.Resolve): If the loop is infinite, set the
1298 (While.Resolve, For.Resolve): Set a barrier after the embedded
1299 statement. There's no direct control flow that goes from the end
1300 of the embedded statement to the end of the loop.
1301 * flowanalysis.cs (FlowBranching.Infinite): Remove.
1302 (FlowBranchingLoop.Merge): Don't look at 'Infinite'. The changes
1303 above ensure that the reachability is correctly computed.
1305 * flowanalysis.cs (Reachability.ResetBarrier): Remove.
1306 (UsageVector.MergeBreakOrigins): If the current path is
1307 unreachable, treat it as if all parameters/locals are initialized.
1308 (FlowBranchingLoop.Merge): Don't clear any barriers. Handle
1309 infinite loops before merging-in break origins.
1311 * flowanalysis.cs (Reachability.Meet): Simplify code handling 'returns'.
1312 (Reachability.Reachable): Split part into ...
1313 (Reachability.Unreachable): ... this. Simplify.
1314 (Reachability.IsUnreachable): Use 'Unreachable' instead.
1316 * flowanalysis.cs (Reachability.SetReturnsSometimes): Remove.
1317 (Reachability.SetThrowsSometimes): Likewise.
1318 (FlowBranchingBlock.MergeTopBlock): Don't compare against
1319 TriState.Always, use corresponding property.
1320 * statement.cs (Lock.Resolve, Try.Resolve, Using.Resolve): Likewise.
1321 (Block.Resolve): Likewise. Remove some redundant checks.
1323 2006-05-02 Raja R Harinath <harinath@gmail.com>
1325 * flowanalysis.cs (UsageVector.Throw): Set barrier too.
1326 (Reachability.Meet): Don't bother checking AlwaysThrows --
1327 barrier is always set.
1328 (FlowBranchingBlock.Merge): Likewise.
1330 2006-05-01 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
1332 * attribute.cs: fixed_buffer_cache is declared only if NET_2_0 is
1333 defined, so it's references should also compile only for NET_2_0
1334 (as occurs in mcs version)
1336 2006-05-01 Raja R Harinath <harinath@gmail.com>
1338 * codegen.cs (EmitContext.ResolveTopBlock): Remove redundant
1339 checks for unreachable.
1341 2006-05-01 Marek Safar <marek.safar@seznam.cz>
1344 * flowanalysis.cs (UsageVector.IsAssigned): Add flag to ignore short path.
1346 * statement.cs (Block.UsageWarning): Uses newly introduced flag to detect
1347 whether field is really assigned.
1349 2006-04-30 Raja R Harinath <harinath@gmail.com>
1351 * flowanalysis.cs (Reachability): Make 4-argument constructor
1353 (Reachability.Meet): Rename from 'And'. Remove static variant.
1354 (Reachability.Always): Rename from the highly misleading
1355 'Reachability.Never'.
1356 (FlowBranching.Merge): Update to changes. Mark an impossible
1357 situation with a 'throw'.
1358 (*): Update to changes.
1360 2006-04-29 Raja R Harinath <harinath@gmail.com>
1362 * flowanalysis.cs (TriState): Rename from FlowBranching.FlowReturns.
1364 (FlowBranching.TriState_Meet): Rename from AndFlowReturns. Simplify.
1365 (FlowBranching.TriState_Max): Rename from OrFlowReturns. Simplify.
1366 (*): Update to changes.
1367 * statement.cs: Update to changes.
1369 2006-04-28 Marek Safar <marek.safar@seznam.cz>
1372 *class.cs (Method.FindOutBaseMethod): Base method cannot be property method.
1374 2006-04-28 Raja R Harinath <harinath@gmail.com>
1376 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't create a
1379 * flowanalysis.cs (UsageVector.MergeChild): Change FlowBranching
1380 argument to two arguments: an usage-vector and a bool. Move call
1381 to FlowBranching.Merge () ...
1382 (FlowBranching.MergeChild, FlowBranching.MergeTopBlock): ... here.
1384 * flowanalysis.cs (UsageVector.MergeChild): Move special-case
1385 handling of loop and switch reachability to ...
1386 (FlowBranchingLoop.Merge, FlowBranchingSwitch.Merge): ... these.
1388 2006-04-27 Raja R Harinath <harinath@gmail.com>
1390 * flowanalysis.cs (FlowBranching.InLoop): Move special-case
1391 handling to FlowBranchingLoop.InLoop.
1392 (FlowBranching.InSwitch): Likewise, to FlowBranchingSwitch.
1394 2006-04-26 Marek Safar <marek.safar@seznam.cz>
1397 * anonymous.cs (AnonymousMethod.DoResolve): Moved the check whether
1398 anonymous method is allowed from AnonymousContainer here.
1400 * attribute.cs, codegen.cs (EmitContext): Add IsAnonymousMethodAllowed.
1402 2006-04-24 Raja R Harinath <rharinath@novell.com>
1405 * flowanalysis.cs (MyBitVector.Or): Add null check on argument.
1407 2006-04-23 Marek Safar <marek.safar@seznam.cz>
1410 * constant.cs (FloatConstant.Reduce): Add range checking for checked context.
1411 (DoubleConstant.Reduce): Ditto.
1413 2006-04-23 Raja R Harinath <rharinath@novell.com>
1415 * expression.cs (LocalVariableReference.DoResolveBase): Simplify.
1416 Remove 'lvalue_right_side' argument. Move parts to ...
1417 (LocalVariableReference.ResolveLocalInfo, LocalVariable.DoResolve)
1418 (LocalVariable.DoResolveLValue): ... these.
1420 2006-04-21 Raja R Harinath <rharinath@novell.com>
1423 * codegen.cs (EmitContext.InRefOutArgumentResolving): Remove.
1424 * expression.cs (EmptyExpression.LValueMemberOutAccess): New.
1425 (LocalVariableReference.DoResolveBase): Use it to implement new
1427 (IndexerAccess.DoResolveLValue): Handle LValueMemberOutAccess.
1428 (Argument.Resolve): Simplify. Move CS1510 check ...
1429 * ecore.cs (Expression.ResolveLValue): ... here.
1430 (UnboxCast.DoResolveLValue): Handle LValueMemberOutAccess.
1431 (PropertyExpr.DoResolveLValue): Likewise.
1432 (FieldExpr.Report_AssignToReadonly): Likewise.
1433 (FieldExpr.DoResolve): Add 'out_access' argument. Use
1434 LValueMemberAccess or LValueMemberOutAccess on instance depending
1436 (FieldExpr.DoResolveLValue): Pass 'out_access' argument to
1437 DoResolve as appropriate.
1439 2006-04-20 Raja R Harinath <rharinath@novell.com>
1442 * expression.cs (Invocation.VerifyArgumentsCompat): Don't try
1443 implicit conversions on 'out' and 'ref' arguments.
1445 * expression.cs (Invocation.VerifyArgumentsCompat): Reorganize to
1446 improve clarity. Remove dead code.
1449 * statement.cs (Block.UsageWarning): Allow VariableInfo to be null.
1450 (Catch.Resolve): Resolve VarBlock if it exists.
1452 2006-04-19 Miguel de Icaza <miguel@novell.com>
1454 * statement.cs (Foreach.EmitFinally): Do not emit the enumerator
1455 twice, this was some residual code, the enumerator was emitted
1456 properly in the two branche of if later.
1460 Thanks to Martin for finding the source of the problem
1462 2006-04-19 Raja R Harinath <rharinath@novell.com>
1464 * expression.cs (Cast.ResolveLValue): Remove. The result of a
1465 cast is never an lvalue.
1466 (Cast.DoResolve, Cast.ResolveRest): Combine.
1467 (Argument.Emit): Simplify slightly. Move 'Expr is
1468 IMemoryLocation' check ...
1469 (Argument.Resolve): ... here.
1470 (Argument.Error_LValueRequired): Remove. Inline into only user.
1472 Simplifications. Fix cs0191-2.cs
1473 * ecore.cs (FieldExpr.DoResolve): Move handling of CS0192, CS0198,
1474 CS1649 and CS1651 to ...
1475 (FieldExpr.Report_AssignToReadonly): ... this. Simplify by moving
1476 the actual selection of the error code and message to a lookup
1477 table. Add a dummy return value to simplify callsites.
1478 (FieldExpr.ResolveLValue): Don't allow a constructor to write to
1479 readonly fields of other instances of the same type. Move CS0197
1481 * expression.cs (Argument.Resolve): ... here. Simplify code.
1482 Ensure that ec.InRefOutArgumentResolving is only set during LValue
1483 resolution of an out or ref argument. The code simplification
1484 above uses this invariant.
1486 2006-04-18 Raja R Harinath <rharinath@novell.com>
1488 Possibly fix #77752. Fix cs1690-[4-7].cs.
1489 * ecore.cs (Expression.CheckMarshalByRefAccess): Renamed from
1490 CheckMarshallByRefAccess. Drop parameter.
1491 (FieldExpr.CheckMarshalByRefAccess): Update. Change CS1690 to a
1493 (FieldExpr.DoResolve): Call CheckMarshalByRefAccess on
1495 * report.cs (AllWarnings): Add CS1690.
1496 * expression.cs (Argument.Resolve): Use EmptyExpression.OutAccess
1498 (LocalVariableReference.DoResolveBase): Update.
1500 2006-04-09 Marek Safar <marek.safar@seznam.cz>
1502 * class.cs (MethodOrOperator): Moved common parts from method class.
1503 detect obsolete attributes.
1504 (Method.Define): Simplified as it reuses code from base.
1505 (Constructor.ValidAttributeTargets): Fixed issue found during
1507 (Destructor.ValidAttributeTargets): Fixed issue found during
1509 (Operator): Finished refactoring set off by #78020. Operator class is now
1510 ordinary method class.
1512 * anonymous.cs: Updated.
1514 2006-04-09 Marek Safar <marek.safar@seznam.cz>
1516 * class.cs (Constructor.Emit): Don't emit the attributes twice.
1518 2006-04-09 Marek Safar <marek.safar@seznam.cz>
1520 * class.cs (Operator.Emit): Extracted code from MethodData to correctly
1521 detect obsolete attributes.
1522 (Method.CreateEmitContext): Moved to MethodOrOperator.
1524 2006-04-09 Marek Safar <marek.safar@seznam.cz>
1527 * class.cs (TypeContainer.MemberCoreArrayList.DefineContainerMembers): Throw
1528 customized exception to make crash detection easier.
1529 (MethodOrOperator): Started to work on new base class for methods and
1531 (Method): Derives from MethodOrOperator.
1532 (Constructor.Emit): Emits its own attributes.
1533 (AbstractPropertyEventMethod.Emit): Ditto.
1534 (Operator): Derives from MethodOrOperator, will refactor fully in extra
1536 (Operator.Emit): It's temporary more tricky than should be.
1538 * doc.cs (GetMethodDocCommentName): Updated after operator changes.
1540 * report.cs (InternalErrorException): Add ctor with inner exception.
1542 2006-04-08 Marek Safar <marek.safar@seznam.cz>
1545 * ecore.cs (SimpleName.ResolveAsTypeStep): Report better error when type is
1548 2006-04-07 Marek Safar <marek.safar@seznam.cz>
1551 * expression.cs (ArrayCreation.GetAttributableValue): Creates correctly typed
1554 2006-04-06 Marek Safar <marek.safar@seznam.cz>
1556 * class.cs (Class.ApplyAttributeBuilder): Report an error when ComImport
1557 attribute is present and Guid not.
1558 (Interface.ApplyAttributeBuilder): Ditto.
1560 * attribute.cs: Add error message.
1562 2006-04-06 Marek Safar <marek.safar@seznam.cz>
1566 * attribute.cs (Attribute.AttachTo): The attribute can have multiple
1567 sources (it's composite) so hold them in extra array as they are used in
1568 Emit phase only. It worked in the previous versions by mistake.
1569 (Attribute.Emit): Emit attribute for more owners when exist.
1571 * codegen.cs, class.cs: Updated to don't re-attach attribute twice as now
1572 it has now different behaviour.
1574 2006-04-04 Marek Safar <marek.safar@seznam.cz>
1576 * constant.cs (Constant.IsDefaultInitializer): New method.
1578 * class.cs: Updated.
1580 * expression.cs (ArrayCreation.CheckIndices): Add an optimization to don't
1581 re-initialize default values. It saves KBs almost for every assembly.
1582 Thanks Zoltan for the idea.
1583 (ArrayCreation.ResolveInitializers): Renamed from ValidateInitializers.
1584 (ArrayCreation.DoResolve): Resolve only once.
1585 (ArrayCreation.Emit): Emit static initializer only when it is faster.
1586 (ArrayCreation.GetAttributableValue): Cope with optimized values.
1588 2006-04-03 Zoltan Varga <vargaz@gmail.com>
1590 * report.cs (Warning, Error): Add 0-, 1-, and 2- argument specializations.
1593 2006-04-01 Marek Safar <marek.safar@seznam.cz>
1595 * assign.cs (Assign.DoResolve): Assignment to same variable can occur
1596 in an embedded statement too.
1598 2006-04-01 Raja R Harinath <rharinath@novell.com>
1601 * typemanager.cs (IsNestedChildOf): Drop generic arguments before
1605 * statement.cs (Switch.EmitObjectInteger) [ulong]: Remove bad cast.
1608 * report.cs (SymbolRelatedToPreviousError): Drop generic type
1609 arguments before checking whether a type is reflected or not.
1612 * expression.cs (Invocation.IsApplicable): Ensure a generic method
1613 definition doesn't take part in overload resolution.
1614 (Invocation.IsParamsMethodApplicable): Likewise.
1615 (Invocation.OverloadResolve): When replacing a reflected override
1616 method with its base definition, ensure that type arguments are
1619 2006-04-01 Marek Safar <marek.safar@seznam.cz>
1623 * class.cs (TypeContainer.AddPartial): Don't report an error when modifier
1626 * modifiers.cs: Add DEFAULT_ACCESS_MODIFER.
1628 2006-03-31 Marek Safar <marek.safar@seznam.cz>
1630 * assign.cs (LocalTemporary): Don't require ILGenerator in the resolve
1633 * anonymous.cs, assign.cs, ecore.cs, expression.cs: Updated after
1634 LocalTemporary change.
1636 * class.cs (ClassOrStruct.DefineDefaultConstructor): Moved from
1638 (ClassOrStruct.DefineFieldInitializers): Implemented static field
1639 initializers optimization.
1640 (ClassOrStruct.TypeAttr): Moved from modifiers.
1641 (Constructor.CheckBase): Don't crash when static ctor has parameters.
1642 (FieldBase.ResolveInitializer): Resolves initializer.
1643 (FieldBase.HasDefaultInitializer): New property.
1645 * cs-parser.jay: Removed message.
1647 * expression.cs (CompilerGeneratedThis): New specialization.
1649 * modifiers.cs (TypeAttr): Moved to ClassOrStruct.TypeAttr
1651 2006-03-28 Marek Safar <marek.safar@seznam.cz>
1653 * cs-parser.jay, cs-tokenizer.cs: On demand Stack allocation.
1655 2006-03-27 Marek Safar <marek.safar@seznam.cz>
1657 * ecore.cs (Expression.ResolveAsConstant): Clean up, enum constants should
1658 be now EnumConstants only.
1660 2006-03-27 Marek Safar <marek.safar@seznam.cz>
1662 * attribute.cs, driver.cs: Reset more caches.
1664 2006-03-26 Marek Safar <marek.safar@seznam.cz>
1666 * cs-tokenizer.cs (adjust_real): Uses float.Parse for float literals.
1668 2006-03-26 Marek Safar <marek.safar@seznam.cz>
1670 * constant.cs (Constant.Reduce): Replaced EmitContext with single bool
1671 for easier reuse. Updated all overrides.
1672 (IntegralConstant): New base class for all integral constants.
1673 (IntegralConstant.Error_ValueCannotBeConverted): When assigned value if out
1674 of the constant range, report custom error.
1675 (UIntConstant.Reduce): Fixed uint conversion.
1677 * ecore.cs, literal.cs: Reduce updates.
1679 2006-03-26 Marek Safar <marek.safar@seznam.cz>
1683 * class.cs (Constructor.Define): Removed extra if for default ctors.
1684 A patch from Atsushi Enomoto.
1686 2006-03-26 Marek Safar <marek.safar@seznam.cz>
1688 * attribute.cs (Attribute.ResolveConstructor): Conversion was moved to
1689 GetAttributableValue.
1691 * constant.cs (Constant.GetAttributableValue): Does implicit conversion
1694 * convert.cs (ImplicitConversionRequired): Error message moved to
1697 * ecore.cs (Expression.GetAttributableValue): Add type parameter for
1698 automatic implicit conversion of an output value.
1699 (EnumConstant.GetAttributableValue): Don't reduce the enum constants.
1701 * expression.cs (ArrayCreation.GetAttributableValue): Add element type
1703 (TypeOf.GetAttributableValue): Add extra handling for object type.
1705 * literal.cs (DoubleLiteral.Error_ValueCannotBeConverted): Doubles can have
1706 special error message.
1708 2006-03-25 Marek Safar <marek.safar@seznam.cz>
1710 * class.cs (Constructor.Emit): Don't crash when struct ctor is
1712 (Constructor.ApplyAttributeBuilder): Transform MethodImplAttribute to be
1713 compatible with MS runtime.
1715 2006-03-23 Marek Safar <marek.safar@seznam.cz>
1717 * attribute.cs (Attribute.ResolveConstructor): Check for an invalid
1718 attribute arguments here.
1720 * class.cs (Indexer.Define): The check was moved to attribute class.
1722 2006-03-21 Marek Safar <marek.safar@seznam.cz>
1724 * expression.cs (StringConcat.Append): Reverted back to no warning state.
1726 2006-03-21 Marek Safar <marek.safar@seznam.cz>
1728 * const.cs (Error_ConstantCanBeInitializedWithNullOnly): Share a message.
1730 * statement.cs (Block.ResolveMeta): Look for wrong object constants in
1733 2006-03-21 Atsushi Enomoto <atsushi@ximian.com>
1735 * doc-bootstrap.cs : fix build.
1737 2006-03-20 Marek Safar <marek.safar@seznam.cz>
1739 * expression.cs (StringConcat.Append): Issue a warning when empty string
1742 2006-03-20 Marek Safar <marek.safar@seznam.cz>
1744 * assign.cs (CompoundAssign.ResolveSource): Removed.
1746 * attribute.cs (ResolvePossibleAttributeType): Updated after MemberAccess
1749 * class.cs (TypeContainer.FindMethods): Removed.
1750 (TypeContainer.CheckMemberUsage): Made static.
1752 * codegen.cs (GetAssemblyName): Uses Length for empty string test.
1754 * constant.cs (CheckRange): Removed unused type argument.
1755 (CheckUnsigned): Removed unused type argument.
1757 * cs-parser.jay: Updated after MemberAccess clean up.
1758 Uses Length for empty string test.
1760 * cs-tokenizer.cs: Uses Length for empty string test.
1761 (IsCastToken): Made static.
1762 (is_hex): Made static.
1763 (real_type_suffix): Made static.
1765 * decl.cs (SetupCache): Made static.
1766 (OnGenerateDocComment): Removed unused ds argument.
1768 * delegate.cs (VerifyDelegate): Removed unused argument.
1770 * doc.cs: Uses Length for empty string test.
1772 * driver.cs: Uses Length for empty string test.
1774 * enum.cs (IsValidEnumType): Made static
1776 * expression.cs (EnumLiftUp): Removed unused argument.
1777 (ResolveMethodGroup): Ditto.
1778 (BetterConversion): Ditto.
1779 (GetVarargsTypes): Ditto.
1780 (UpdateIndices): Ditto.
1781 (ValidateInitializers): Ditto.
1782 (MemberAccess.ctor): Ditto.
1783 (GetIndexersForType): Ditto.
1785 * flowanalysis.cs: (MergeFinally): Removed unused argument.
1787 * iterators.cs: Updated after MemberAccess clean up.
1789 * location.cs: Uses Length for empty string test.
1791 * namespace.cs: Uses Length for empty string test.
1793 * report.cs (CheckWarningCode): Made static.
1795 * statement.cs (LabeledStatement): Removed unused argument.
1797 * typemanager.cs (FilterNone): Removed.
1799 2006-03-18 Marek Safar <marek.safar@seznam.cz>
1801 * codegen.cs (EmitContext.TestObsoleteMethodUsage): Removed as it become
1804 * class.cs: Updated.
1806 2006-03-18 Marek Safar <marek.safar@seznam.cz>
1808 * cs-parser.jay.cs: __arglist is not allowed for delegates.
1810 2006-03-18 Marek Safar <marek.safar@seznam.cz>
1814 * anonymous.cs.cs (AnonymousMethod): Add host to allow access to
1816 (AnonymousMethod.ImplicitStandardConversionExists): New method.
1817 (AnonymousMethod.Compatible): Moved parameter resolving to DoResolve.
1818 Add more error reporting; Fixed issue with params.
1820 * convert.cs (ImplicitStandardConversionExists): Returned conversion check.
1822 * cs-parser.jay: AnonymousMethod requires host container.
1824 * delegate.cs (NewDelegate.DoResolve): Updated after Compatible changes.
1826 2006-03-18 Raja R Harinath <harinath@gmail.com>
1828 * class.cs: Change 'TypeContainer ds' constructor argument to
1829 'DeclSpace parent'. Some classes were missed below due to
1830 different naming convention.
1832 * class.cs (MemberCore.Parent): Delete. This makes the
1833 ParentContainer changes below enforceable by the compiler.
1835 Treat pointers to enclosing declaration space as 'DeclSpace', not
1837 * class.cs, const.cs, delegate.cs, enum.cs, iterator.cs: Change
1838 'TypeContainer parent' constructor argument to 'DeclSpace parent'.
1840 * statement.cs (LocalInfo..ctor): Use DeclSpace argument instead
1842 (Block.AddThisVariable): Likewise.
1843 * class.cs (MethodData.Define, MethodData.Emit): Likewise.
1844 (AbstractPropertyEventMethod.Emit): Likewise.
1845 (AbstractPropertyEventMethod.EmitMethod): Likewise.
1846 (GetMethod.Define, SetMethod.Define): Likewise.
1847 (PropertyMethod.Define, DelegateMethod.Define): Likewise.
1848 (DelegateMethod.EmitMethod): Likewise.
1850 Fix regression test-partial-13.cs.
1851 Rationalize use of PartialContainer. Ensure that the partial
1852 class semantics can be tied to type-correctness, i.e., any
1853 violation will cause a compile error.
1854 * class.cs, const.cs: Access all fields that belong to class
1855 TypeContainer via ParentContainer. Arguments of EmitContexts and
1856 Resolve()-like functions still use 'Parent'.
1858 * class.cs (SourceMethod): Use DeclSpace, not TypeContainer.
1859 (*.CreateEmitContext): Change TypeContainer argument to DeclSpace.
1860 (PropertyMethod.CheckModifiers): Remove unused argument.
1861 * codegen.cs (EmitContext..ctor): Change TypeContainer argument to
1864 2006-03-28 Raja R Harinath <rharinath@novell.com>
1866 * decl.cs (DeclSpace.LookupGeneric): Update to changes.
1868 2006-03-17 Raja R Harinath <harinath@gmail.com>
1870 Make semantics of PartialContainer simpler.
1871 * decl.cs (DeclSpace.IsPartial): Remove.
1872 * class.cs (TypeContainer.IsPartial): Likewise.
1873 (TypeContainer..ctor): Set PartialContainer to point to self.
1874 (TypeContainer.GetClsCompliantAttributeValue): Don't use IsPartial.
1875 (TypeContainer.FindNestedType): Likewise.
1876 (MemberCore.ParentContainer): Simplify. Remove deprecation.
1878 2006-03-17 Marek Safar <marek.safar@seznam.cz>
1880 * typemanager.cs.cs (GetInterfaces): Don't recreate 0-sized arrays.
1882 2006-03-15 Marek Safar <marek.safar@seznam.cz>
1884 * class.cs (FieldMember.Emit): ParentContainer is real parent for partial
1887 2006-03-15 Marek Safar <marek.safar@seznam.cz>
1889 * class.cs (Operator.Define): An error for base conversion was not
1892 2006-03-13 Marek Safar <marek.safar@seznam.cz>
1894 A fix for #77593, #77574.
1896 * class.cs (MethodCore.CheckBase): Another if for operator.
1898 2006-03-18 Marek Safar <marek.safar@seznam.cz>
1902 * expression.cs (VerifyArgumentsCompat): Reverted to double error
1903 reporting, it's more tricky than I thought.
1905 2006-03-09 Marek Safar <marek.safar@seznam.cz>
1907 * anonymous.cs (AnonymousMethod.Compatible): Don't crash when parameters
1910 * delegate.cs (Delegate.GetInvokeMethod): Use emitcontext free MemberLookup.
1911 (DelegateCreation.ImplicitStandardConversionExists): New method for just
1914 * ecore.cs (Expression.MemberLookup): Don't ask for emitcontext when it's
1917 2006-03-04 Marek Safar <marek.safar@seznam.cz>
1921 * class.cs (SetMethod.DefineParameters): Uses new parameters type ctor.
1922 (Event.Define): ditto
1923 (SetIndexerMethod.DefineParameters): Uses Parameters.MergeGenerated.
1925 * delegate.cs (Delegate.Define): Uses Parameters.MergeGenerated.
1926 Removed redundant code and set NewSlot for Invoke method too.
1928 * parameter.cs (Parameters.ctor): Add custom, type ctor.
1929 (Parameters.MergeGenerated): New method. Use this method when you merge
1930 compiler generated argument with user arguments.
1932 2006-03-03 Marek Safar <marek.safar@seznam.cz>
1934 * attribute.cs (ResolveAsTypeTerminal): Removed.
1936 * ecore.cs (Expression.ResolveAsTypeTerminal): Make virtual to allow
1937 specialization for predefined types; 30% speed up.
1938 Finally placed obsolete check to right place.
1939 (Expression.ResolveType): Removed.
1941 * enum.cs, expression.cs, parameter.cs, statement.cs, typemanager.cs:
1942 Updated after ResolveType was removed.
1944 * expression.cs (Cast.ctor): Check void cast.
1945 (Binary.ResolveAsTypeTerminal): Is never type.
1946 (Conditional.ResolveAsTypeTerminal): Is never type.
1948 * rootcontext.cs (ResolveCore): Set base type to simplify some code later.
1950 2006-03-26 Marek Safar <marek.safar@seznam.cz>
1952 * rootcontext.cs (ResolveCore): Removed System.INullableValue.
1954 2006-03-23 Martin Baulig <martin@ximian.com>
1956 * expression.cs (Is.DoResolve, As.DoResolve): Perform a dynamic
1957 type check if either of the types is an open generic type.
1959 2006-03-23 Martin Baulig <martin@ximian.com>
1962 (Convert.ExplicitTypeParameterConversion): New method; implement
1963 explicit type parameter conversions.
1965 2006-03-23 Martin Baulig <martin@ximian.com>
1967 * convert.cs (Convert.ImplicitTypeParameterConversion): Do not
1968 blindly allow all conversions if we do not have any constraints.
1970 2006-02-27 Marek Safar <marek.safar@seznam.cz>
1972 * attribute.cs (Attribute.PosArguments, Attribute.NamedArguments): Use
1973 these two separated members to simplify the code.
1974 (Attribute.Resolve): Refactored to use new fields and methods.
1975 (Attribute.ResolveConstructor): Extracted from ResolveArguments and
1976 implemented obsolete attribute checking.
1977 (Attribute.ResolveNamedArguments): Extracted from ResolveArguments and
1978 implemented obsolete checking again. It look line never ending quest ;-)
1979 (GlobalAttribute.ResolveConstructor): Need to override as the rest.
1981 * cfold.cs (BinaryFold): TryReduce throws an exception to indicate error.
1983 * constanct.cs (TryReduce): Throws OverflowException to indicate error.
1985 *class.cs (Property.Define): Add RegisterProperty call.
1987 * cs-parser.jay: Replaced ArrayList with fixed array for attribute
1988 argument groups (only 2).
1990 * ecore.cs (Expression.GetAttributableValue): New virtual method used for
1991 encoding expression to arguments.
1992 (Expression.ExprClassToResolveFlags): Just turned to property.
1994 * expression.cs (ArrayCreation.ValidateInitializers): Slightly optimized.
1995 (ArrayCreation.GetAttributableValue): Renamed from EncodeAsAttribute and
1996 optimized as well as implemented support for zero-length attributes.
1998 * typemanager.cs (TypeManager.RegisterProperty, TypeManager.GetProperty):
1999 Add caching of PropertyInfo's.
2001 2006-02-25 Marek Safar <marek.safar@seznam.cz>
2003 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Don't report
2004 error multiple times.
2006 2006-02-25 Marek Safar <marek.safar@seznam.cz>
2008 New partial class implementation.
2009 A fix for #77027, #77029, #77403
2011 * attribute.cs (Attributable): Made attributes protected.
2013 * class.cs (TypeContainer): Add PartialContainer and partial_parts as
2014 the replacements of ClassPart and PartialContainer.
2015 (TypeContainer.AddClassOrStruct): Call RecordDecl here.
2016 (TypeContainer.AddInterface): Ditto.
2017 (TypeContainer.AddPartial): The main method for partial classes. It checks
2018 for errors and merges ModFlags and attributes. At the end class is added to
2020 (TYpeContainer.DefineDefaultConstructor): Checks whether default ctor is
2022 (TypeContainer.GetClsCompliantAttributeValue): Cope with partial class too.
2023 (TypeContainer.GetNormalPartialBases): Resolves base classes and interfaces
2024 from the rest of partial classes.
2025 (TypeContainer.GetClassBases): Simplified.
2026 (TypeContainer.DefineTypeBuilder): New method, mostly extracted from
2028 (TypeContainer.DefineDefaultConstructor): Is used by derived classes.
2029 (TypeContainer.HasExplicitLayout): Uses Flags now.
2030 (PartialContainer): Removed.
2031 (ClassOrStruct.AddToContainer): Moved enclosing member name check here.
2032 (StaticClass): Was merged with Class.
2033 (Class.GetClassBases): class and static class bases are verified here.
2034 (Class.TypeAttr): Added static attributes when class is static.
2035 (Struct.RegisterFieldForInitialization): Moved from TypeContainer.
2036 (MemberBase): In some cases we need to call parent container for partial
2037 class. It should be eliminated but it's not easy now.
2039 * cs-parser.jay: Replaced all PartialContainer with AddPartial.
2041 * decls.cs (MemberCore.DocComment): Introduced new property as is used by
2042 partial classed to accumulate class comments.
2043 (MemberCore.GetClsCompliantAttributeValue): Moved from TypeContainer.
2045 * doc.cs (GenerateTypeDocComment): Partial classes clean up.
2047 * driver.cs (MainDriver): Tree.GetDecl was removed.
2049 * modifiers.cs (Modifiers): Add partial modifier.
2051 * tree.cs (Tree.decl): Removed.
2052 (RootTypes): Started to use this class more often for root types
2055 2006-03-23 Raja R Harinath <rharinath@novell.com>
2057 * generic.cs (TypeParameter.UpdateConstraints): Update
2058 'constraints' if null.
2060 2006-02-22 Marek Safar <marek.safar@seznam.cz>
2064 * attribute.cs (AttributeTester.GetCoClassAttribute): Don't crash when
2065 external interface does not have an attribute.
2067 2006-02-22 Marek Safar <marek.safar@seznam.cz>
2069 Another prerequisites for new partial classs implementation.
2071 * attribute.cs (Attribute.Equal): Implemented.
2072 (Attribute.Emit): Changed as attributes can be applied more than twice.
2073 (Attributes.Emit): Check for duplicate attributes here.
2075 * class.cs, decl.cs, delegate.cs, doc.cs, enum.cs: Don't pass DeclSpace
2076 as a parameter, clean-up.
2078 2006-02-11 Marek Safar <marek.safar@seznam.cz>
2082 * class.cs (TypeContainer.DefineType): Cannot use ResolveType because it
2083 contains obsolete attribute check which can in some cases look for base
2084 type of current class which is not initialized yet.
2085 (TypeContainer.BaseType): Replacement of ptype.
2087 * decl.cs (MemberCore.CheckObsoleteType): Reuse existing code.
2089 2006-02-11 Marek Safar <marek.safar@seznam.cz>
2091 First of prerequisites for new partial classs implemention.
2093 * attribute.cs (Attributable): Extended by ResolveContext;
2094 Attributes finally have correct context for resolving in all cases.
2095 (AttachTo): Attribute owner is assigned here.
2097 * codegen.cs (IResolveContext): Introduce new interface to hold
2098 all information needed in resolving phase.
2099 (EmitContext): Implements IResolveContext; more clean-up needed here.
2101 * decl.cs (MemberCore): Implemented IResolveContext.
2103 * anonymous.cs, attribute.cs, class.cs, codegen.cs, const.cs,
2104 decl.cs, ecore.cs, enum.cs, expression.cs, iterators.cs, namespace.cs,
2105 parameter.cs, statement.cs, tree.cs, typemanager.cs:
2106 Refactored to use new IResolveContext instead of EmitContext; cleanup
2108 2006-03-22 Raja R Harinath <rharinath@novell.com>
2110 Support ParameterDefaultValueAttribute in gmcs. Also applied to
2111 mcs to keep code differences small.
2112 * attribute.cs (Attribute.GetParameterDefaultValue): New.
2113 * typemanager.cs (parameter_default_value_attribute_type): New.
2114 * parameter.cs (Parameter.ApplyAttributeBuilder): Use them. Add
2117 2006-03-22 Martin Baulig <martin@ximian.com>
2120 (Nullable.NullableLiteral): Derive from `NullLiteral'.
2123 (Convert.TypeParameter_to_Null): Create a `Nullable.NullableLiteral'
2124 instead of the normal `NullLiteral'.
2126 2006-03-21 Martin Baulig <martin@ximian.com>
2129 * generic.cs (TypeManager.InferType): If `pt' is a generic
2130 parameter, don't check whether `pt == at'.
2132 2006-03-20 Raja R Harinath <rharinath@novell.com>
2135 * generic.cs (Constraints.Resolve): Change argument to IResolveContext.
2136 (TypeParameter.Resolve): Update to change.
2137 (ConstraintChecker.CheckConstraints): Resolve type-argument
2138 constraints before use.
2140 2006-03-16 Martin Baulig <martin@ximian.com>
2143 (ConstraintChecker.HasDefaultConstructor): If we're a TypeBuilder
2144 and don't have any instance constructors, also lookup in the base class.
2145 (TypeManager.IsNullableValueType): New public method.
2147 * typemanager.cs (TypeManager.MemberLookup_FindMembers): Clear the
2148 `BindingFlags.DeclaredOnly' flag and set `used_cache'.
2149 (TypeManager.TryGetBaseDefinition): Use DropGenericMethodArguments().
2151 * expression.cs (Unary.DoResolve): Use TypeManager.IsNullableValueType()
2152 instead of just TypeManager.IsNullableType() to determine whether
2153 a lifted operator exists.
2154 (UnaryMutator.DoResolve): Likewise.
2155 (Conditional.DoResolve): Likewise.
2156 (Binary.DoResolve): A lifted operator only exists if both operands
2157 are valuetypes and at least one of them is a nullable type.
2159 2006-03-14 Atsushi Enomoto <atsushi@ximian.com>
2161 * iterator.cs : yield break is allowed in try statement which has
2162 catch clauses. Fixed bug #77767.
2164 2006-03-12 Martin Baulig <martin@ximian.com>
2166 * typemanager.cs (TypeManager.ArrayContainsMethod): Use a new
2167 private IsSignatureEqual() to compare types; see the comment in
2168 that method; fixes #77674.
2170 2006-03-10 Raja R Harinath <rharinath@novell.com>
2172 * ecore.cs (Expression.ResolveAsTypeStep): Remove 1-argument wrapper.
2173 (Expression.ResolveAsTypeTerminal): Likewise.
2174 * class.cs, decl.cs, delegate.cs, ecore.cs: Update to changes.
2175 * expression.cs, generic.cs, iterators.cs: Likewise.
2176 * parameter.cs, statement.cs, typemanager.cs: Likewise.
2178 2006-03-09 Martin Baulig <martin@ximian.com>
2180 * generic.cs (ConstraintChecker.HasDefaultConstructor): Call
2181 TypeManager.DropGenericTypeArguments() on the `atype'; fixes #77548.
2183 2006-03-09 Martin Baulig <martin@ximian.com>
2185 * ecore.cs (FieldExpr.AddressOf): Don't emit the instance if the
2186 `prepared' flag is set.
2188 * generic.cs (LiftedBinaryOperator): Don't allow `||' or `&&' anymore.
2189 (LiftedBinaryOperator, LiftedUnaryMutator): Fix a few nullable
2190 issues; see gtest-254.cs.
2192 2006-03-07 Martin Baulig <martin@ximian.com>
2194 * generic.cs (TypeManager.InferType): Allow infering
2195 `IEnumerable<T>' with an array of T; see gtest-251.cs.
2197 2006-03-06 Martin Baulig <martin@ximian.com>
2200 (TypeManager.InferType): Fix gtest-250.cs.
2203 (TypeManager.IsSubclassOf): Also check the base class.
2206 (Invocation.IsAncestralType): Use TypeManager.IsSubclassOf();
2209 2006-03-01 Raja R Harinath <rharinath@novell.com>
2212 * expression.cs (ParameterReference.DoResolveBase): Change return
2214 (ParameterReference.DoResolve, ParameterReference.DoResolveLValue):
2218 * ecore.cs (PropertyExpr.InstanceResolve): Fix CS1540 check.
2221 * typemanager.cs (GetFullNameSignature): Don't nullref on
2222 protected accessors.
2224 2006-02-16 Martin Baulig <martin@ximian.com>
2227 (TypeManager.GetGenericFieldDefinition): New public method; use it
2228 instead of the `FieldInfo.Mono_GetGenericFieldDefinition()' icall.
2230 2006-02-14 Martin Baulig <martin@ximian.com>
2232 * *.cs: Use `Type.IsGenericType' instead of `Type.IsGenericInstance'.
2234 2006-02-14 Martin Baulig <martin@ximian.com>
2237 (TypeManager.DropGenericMethodArguments): New public method; don't
2238 use GetGenericMethodDefinition() on something which is not a
2241 2006-02-14 Martin Baulig <martin@ximian.com>
2244 (ConstraintChecker.CheckConstraints): If a type parameter has the
2245 `struct' constraint, the type must be a non-nullable valuetype.
2247 2006-02-10 Martin Baulig <martin@ximian.com>
2250 (TypeManager.IsOverride): Make this work for instantiated methods
2251 in a generic class; fixes #77509.
2252 (TypeManager.ExpandInterfaces): Use TypeManager.GetInterfaces()
2253 rather than calling it directly; fixes #77488.
2255 2006-02-08 Martin Baulig <martin@ximian.com>
2257 * generic.cs (ConstraintChecker.CheckConstraints): Move the error
2258 reporting into CheckConstraint() so we can use the correctly
2261 2006-02-08 Martin Baulig <martin@ximian.com>
2263 * expression.cs (BaseAccess): Add support for generic methods.
2265 * ecore.cs (MethodGroupExpr.ResolveGeneric): Propagate `IsBase' to
2266 the new MethodGroupExpr.
2268 2006-02-07 Martin Baulig <martin@ximian.com>
2270 * generic.cs (ConstraintChecker.CheckConstraints): Interfaces are
2271 also reference types; fixes #77483.
2273 2006-02-07 Martin Baulig <martin@ximian.com>
2276 (TypeManager.IsGenericMethod): We now return whether something is
2277 an instantiated generic method (and not a generic method def).
2278 (TypeManager.IsGenericMethodDefinition): New public method.
2281 (TypeManager.CSharpSignature): Only include type arguments for
2282 "real" generic methods, not for any instantiated method.
2283 (TypeManager.GetMethodName): Likewise, but also allow generic
2284 method definitions here.
2286 2006-02-06 Miguel de Icaza <miguel@novell.com>
2288 * codegen.cs (EmitScopeInitFromBlock): check here the
2289 capture_context, there is no need to make two calls to the
2292 * anonymous.cs: Add some debugging messages that might help me
2293 track other instances of this problem in the future (the
2294 regression of test 467).
2296 * cs-parser.jay: track the variable block, as we need to initalize
2297 any captured variables declared in this block for the "catch"
2298 portion of the "Try" statement.
2300 * statement.cs (Try.Emit): If the "Catch" has a VarBlock, emit any
2301 scope initialization for captured variables.
2303 Also, move the emit for the variables after the block location has
2306 2006-02-06 Marek Safar <marek.safar@seznam.cz>
2308 * ecore.cs (PropertyExpr.FindAccessors): Just made flags const.
2310 2006-02-06 Martin Baulig <martin@ximian.com>
2312 * class.cs (TypeContainer.DefineType): If we're a struct, pass
2313 `TypeManager.value_type' as parent type to
2314 ModuleBuilder.DefineType(). Fixes #77358.
2316 2006-02-02 Miguel de Icaza <miguel@novell.com>
2318 * anonymous.cs (CaptureContext.EmitInitScope): I was wrong in the
2319 commit yesterday, the initialization for the roots is necessary.
2320 What is not necessary is the scope activation.
2322 2006-02-02 Raja R Harinath <rharinath@novell.com>
2324 * ecore.cs (PropertyExpr.DoResolveLValue): Add CS0206 check.
2325 * expression.cs (IndexerAccess.DoResolveLValue): Add CS1612 and
2327 (Argument.Resolve): Remove CS0206 checks.
2329 2006-02-01 Miguel de Icaza <miguel@novell.com>
2331 * anonymous.cs (CaptureContext.EmitInitScope): Do not emit the
2332 scopes for all the roots, the scopes will now be emitted when the
2333 Blocks are entered. [This change was wrong, fixed on 2006-02-02]
2335 (CaptureContext.EmitScopeInitFromBlock): Simply emit the ScopeInfo
2336 code. This reduces a lot of existing cruft.
2338 * statement.cs (Block.Emit): Call EmitScopeInitFromBlock here, so
2339 that the ScopeInfo is generated as we enter the scope, not at the
2340 time of use, which is what we used to do before.
2342 * codegen.cs (EmitScopeInitFromBlock): New routine, this is called
2343 every time a Block is about to be emitted if we have a
2346 2006-02-01 Raja R Harinath <rharinath@novell.com>
2348 * codegen.cs (AssemblyClass.Emit): Emit RuntimeCompatibility
2349 attribute for mscorlib too.
2351 * typemanager.cs (NoTypes, NoTypeExprs): Remove.
2353 * *.cs: Use Type.EmptyTypes instead of TypeManager.NoTypes.
2355 * typemanager.cs (cons_param_array_attribute): Make private.
2356 (Reset): Set it to null.
2357 (InitCoreHelpers): Don't initialize it.
2358 (ConsParamArrayAttribute): New. Initialize it as needed.
2359 * parameter.cs (ParamsParameter.ApplyAttribute): Update to change.
2361 2006-01-31 Miguel de Icaza <miguel@novell.com>
2363 * expression.cs: There might be errors reported during the
2364 selection of applicable methods. If there are errors, do not
2365 continue execution as it will lead the compiler to crash.
2367 2006-01-30 Miguel de Icaza <miguel@novell.com>
2369 * expression.cs: Member access is not allowed on anonymous
2370 methods. Fixes #77402.
2372 2006-01-30 Raja R Harinath <rharinath@novell.com>
2375 * cs-parser.jay (VariableDeclaration): Don't set
2376 current_array_type to null.
2377 (field_declaration, event_declaration, declaration_statement):
2378 Set it to null here.
2380 2006-01-29 Raja R Harinath <harinath@gmail.com>
2383 * generic.cs (TypeManager.IsEqual): Handle pass-by-ref types.
2385 2006-01-28 Raja R Harinath <harinath@gmail.com>
2387 * typemanager.cs (GenericParameterPosition): New.
2390 2006-01-28 Atsushi Enomoto <atsushi@ximian.com>
2392 * doc.cs : To process "include" elements, first we should create
2393 another list than XmlNodeList, because it could result in node
2394 removal, which could result in that the XmlNodeList gives up
2397 2006-01-25 Miguel de Icaza <miguel@novell.com>
2399 * expression.cs: Introduce an error report that we were not
2400 catching before. Gonzalo ran into it.
2402 2006-01-23 Miguel de Icaza <miguel@novell.com>
2404 A fix for bug: #76957
2406 * iterators.cs (MoveNextMethod.CreateMethodHost): call
2407 ComputeMethodHost before creating the method, this is a new
2410 * anonymous.cs (AnonymousContainer): Now we track all the scopes
2411 that this method references (RegisterScope). The actual scope
2412 where the method is hosted is computed with the ComputeMethodHost
2413 before we create the method.
2415 Moved the Deepest routine here.
2417 (AnonymousContainer.ComputeMethodHost): New routine used to
2418 compute the proper ScopeInfo that will host the anonymous method.
2420 (ScopeInfo): Deal with multiple roots. The problem was that we
2421 did not have a unique root where all ScopeInfos could be hanged
2422 from. Remove `topmost' ScopeInfo, and instead keep an arraylist
2425 Remove AdjustMethodScope which is now computed at the end. Remove
2426 LinkScope which did a partial link, instead link all ScopeInfos
2427 before code generation from the new "LinkScopes" routine.
2429 Simplify all the Add* routines as they no longer need to maintain
2430 the tree, they just need to record that they are using variables
2433 (IsAncestor, GetAncestorScopes, GetParentScope, LinkScope): New
2434 routines to produce the forest of ScopeInfo trees.
2436 * class.cs (TypeContainer.AppendMethod): This is just like
2437 AddMethod, but ensures that an interface implementation method
2438 (IEnumerable.XXX) is not inserted at the beginning of the queue of
2439 methods, but at the end.
2441 We use this functionality to ensure that the generated MoveNext
2442 method in the iterator class is resolved/emitted before the
2443 enumerator methods created.
2445 This is required because the MoveNext method computes the right
2446 ScopeInfo for the method. And the other methods will eventually
2447 need to resolve and fetch information computed from the anonymous
2451 2006-01-23 Raja R Harinath <rharinath@novell.com>
2453 Improve implementation of section 14.4.2.2 (Better function member).
2454 * expression.cs (Invocation.MoreSpecific): Compare all type
2455 arguments before deciding if one type is more specific than
2456 another. Handle array types too. Return the more specific type.
2457 (Invocation.BetterFunction): Add more tie-breaking rules from
2458 section 14.4.2.2. Perform "more specific" check after
2459 other tie-breaking rules. Compare all parameter types before
2460 choosing the "more specific" method.
2462 2006-01-21 Raja R Harinath <harinath@gmail.com>
2463 Carlos Alberto Cortez <calberto.cortez@gmail.com>
2466 * namespace.cs (NamespaceEntry.UsingExternalAliases): Don't add to
2468 (NamespaceEntry.LookupAlias): Lookup 'extern_aliases' hash too.
2469 (NamespaceEntry.VerifyUsing): Resolve external aliases too.
2471 2006-01-18 Martin Baulig <martin@ximian.com>
2473 * class.cs (TypeContainer.AddToMemberContainer): Use
2474 `symbol.MemberName.MethodName' instead of just `symbol.Name';
2477 2006-01-18 Martin Baulig <martin@ximian.com>
2479 Fix #76417: a generic class may now have methods which may unify
2480 for some type parameter substitutions.
2482 * class.cs (Method.IsDuplicateImplementation): Don't report CS0408
2483 for methods which may unify anymore.
2485 * expression.cs (Invocation.MoreSpecific): New private static
2486 method; checks whether one method is more specific than another
2487 according to 14.4.2.2 of the spec.
2488 (Invocation.BetterFunction): Implement the tie-breaking rules from
2489 14.4.2.2 of the spec: if two methods unify for some type parameter
2490 substitution, we need to pick the more specific one.
2492 2006-01-18 Raja R Harinath <rharinath@novell.com>
2494 Fix #76656, cs0231-2.cs.
2495 * cs-parser.jay (formal_parameter_list): Make error case catch
2497 (parenthesized_expression_0): Add CS1026 check.
2498 (invocation_expression): Remove unused { $$ = lexer.Location }.
2500 2006-01-17 Raja R Harinath <rharinath@novell.com>
2503 * cs-parser.jay (statement_expression): Don't list out the
2504 individual statement-expressions. Convert syntax error into
2507 2006-01-16 Raja R Harinath <rharinath@novell.com>
2510 * ecore.cs (MemberAccess.CheckIntermediateModification): Remove.
2511 (UnboxCast.DoResolveLValue): New. Move CS0445 check from
2512 CheckIntermediateModification.
2513 (FieldExpr.DoResolve): Add new two-argument version that
2514 allows us to resolve the InstanceExpression as an lvalue.
2515 The one-argument variant is now just a wrapper.
2516 (FieldExpr.DoResolveLValue): Use two-argument DoResolve.
2517 Resolve the lhs as an lvalue if the it has a value type.
2518 (FieldExpr.AssignToReadonly): Move CS1648 and CS1650 checks
2519 from Assign.DoResolve.
2520 (PropertyExpr.InstanceResolve): Allow InstanceExpression to be
2521 resolved as an lvalue.
2522 (PropertyExpr.DoResolve): Update.
2523 (PropertyExpr.DoResolveLValue): Resolve the lhs as an lvalue if it
2524 has a value type. Move CS1612 check here from
2525 CheckIntermediateModification.
2526 * assign.cs (Assign.DoResolve): Remove CS1648 and CS1650 checks.
2527 * expression.cs (EmptyExpression.OutAccess): New. Used as the
2528 'right_side' of a ResolveLValue on an 'out' argument.
2529 (EmptyExpression.LValueMemberAccess): New. Used as the
2530 'right_side' of a propagated ResolveLValue on a value type.
2531 (LocalVariableReference.DoResolveBase): Recognize
2532 EmptyExpression.OutAccess and EmptyExpression.LValueMemberAccess.
2534 (Argument.Resolve): Use EmptyExpression.OutAccess rather than
2535 EmptyExpression.Null.
2537 2006-01-16 Atsushi Enomoto <atsushi@ximian.com>
2539 * typemanager.cs : added IsGenericParameter(). In gmcs it returns
2540 Type.IsGenericParameter(). Fixed bug #77183.
2541 * doc.cs : it is now identical to doc.cs in mcs.
2543 2006-01-16 Martin Baulig <martin@ximian.com>
2545 * generic.cs (ConstraintChecker.CheckConstraint): Fix #77167.
2547 2006-01-16 Martin Baulig <martin@ximian.com>
2549 * typemanager.cs (TypeManager.CSharpSignature): Make this work for
2550 ctors; fixes #77250.
2552 2006-01-12 Miguel de Icaza <miguel@novell.com>
2554 This fixes the problem where we used ldfld instead of ldflda to
2555 load the "THIS" pointer on captured parameters, when THIS is a
2556 value type. See bug #77205.
2558 * iterators.cs (CapturedThisReference.Emit): Pass false to
2559 EmitThis (we do not need the address).
2561 * codegen.cs (EmitThis): it needs to know whether we need the
2562 address of `this' or not. This is used by value types.
2564 * expression.cs (This.AddressOf): Pass true to the EmitThis call,
2565 every other call passes false.
2567 2006-01-12 Raja R Harinath <rharinath@novell.com>
2570 * typemanager.cs (TryGetBaseDefinition): Rename from the mis-named
2572 * expression.cs (Invocation.OverloadResolve): Update.
2573 (Invocation.DoResolve): Avoid double resolution of invocation.
2575 2006-01-11 Raja R Harinath <rharinath@novell.com>
2578 * expression.cs (Unary.Emit): When in /checked+ mode, don't emit
2579 unary negation of floating point types as 0-expr; negation cannot
2580 overflow in floating point types.
2583 * expression.cs (MemberAccess.DoResolve): Disallow the use of '.'
2584 on operands of 'void' type.
2587 * cfold.cs (BinaryFold): Implement folding of BinaryOr, BinaryAnd
2588 and ExclusiveOr for boolean constants too.
2590 2006-01-12 Ben Maurer <bmaurer@andrew.cmu.edu>
2592 * expression.cs: Fix Console.WriteLine ((this = x).foo);
2594 2006-01-12 Miguel de Icaza <miguel@novell.com>
2596 * cs-tokenizer.cs (Position): New class used to save and restore
2597 the position state in the tokenizer. Before this patch the save
2598 and restore was not complete enough so the line and columns would
2599 start to drift and the debugger and stack traces will get the
2602 2006-01-10 Martin Baulig <martin@ximian.com>
2605 (TypeParameter.InflateConstraints): New public method.
2607 * iterators.cs (Iterator.DefineNestedTypes): Also inflate the
2608 constraints; fixes #77042.
2610 2006-01-10 Martin Baulig <martin@ximian.com>
2612 * anonymous.cs (ScopeInfo.EmitScopeType): Use the `CurrentType'
2613 instead of the `TypeBuilder' for this "<>THIS" variable; fixes
2616 2006-01-09 Raja R Harinath <rharinath@novell.com>
2619 * expression.cs (Invocation.OverloadResolve): Replace reflected
2620 override methods with their base virtual methods, rather than
2622 * typemanager.cs (TypeManager.GetOverride): New.
2624 2005-12-21 Miguel de Icaza <miguel@novell.com>
2626 * driver.cs: Report the case of no source files and no -out:
2629 2005-12-20 Raja R Harinath <rharinath@novell.com>
2632 * expression.cs (ComposedCast.GetSignatureForError): Define.
2634 2006-01-05 Jb Evain <jbevain@gmail.com>
2636 * class.cs (Property.Define, Indexer.Define): do not tag the
2637 properties as SpecialName | RTSpecialName.
2639 2006-01-04 Miguel de Icaza <miguel@novell.com>
2641 * class.cs (MethodCore.IsDuplicateImplementation): This method was
2642 doing a low-level comparission of parameter types. It was lacking
2643 a check for __argslist.
2645 2005-12-30 Miguel de Icaza <miguel@novell.com>
2647 * expression.cs (ParameterReference.DoResolveBase): Allow
2648 reference parameters if they are local to this block.
2650 This allows the ref and out parameters of a delegate to be used in
2651 an anonymous method, for example:
2653 delegate void set (out int x);
2655 set s = delegate (out int x){
2659 This is used by functionality introduced late in the C# language.
2661 * anonymous.cs (AnonymousMethod.Compatible): Allow anonymous
2662 method that take ref and out parameters.
2664 Fixes #77119 which was a late change in the spec.
2666 2005-12-23 Miguel de Icaza <miguel@novell.com>
2668 * anonymous.cs (ScopeInfo.LinkScope): Do not link the scope to its
2669 parent if its the same scope. Fixes #77060.
2671 2005-12-22 Marek Safar <marek.safar@seznam.cz>
2673 * expression.cs (ComposedCast.DoResolveAsTypeStep): Fixed wrong merge.
2675 2005-12-21 Carlos Alberto Cortez <calberto.cortez@gmail.com>
2677 * codegen.cs (AssemblyClass.CheckInternalsVisibleAttribute): Generate
2678 errors 1726 for strong named assemblies with InternalsVisibleToAttribute
2679 that doesn't contain the full public key. This is a update of the
2680 friend assemblies in .Net 2.0 release.
2682 2005-12-18 Carlos Alberto Cortez <calberto.cortez@gmail.com>
2686 * namespace.cs (NamespaceEntry): Add extern_aliases as a
2687 ListDictionary, to contain the ExternAliasEntry entries (in
2688 addition to the NamespaceEntry.aliases hashtable). This field is
2689 shared between the original entry and its doppelganger (bodyless
2691 (NamespaceEntry.UsingExternalAlias): Add the extern alias entry to
2692 extern_aliases field.
2693 (NamespaceEntry.Lookup): Move the IsImplicit check after the
2694 lookup in extern_aliases.
2696 2005-12-16 Raja R Harinath <rharinath@novell.com>
2699 * class.cs (TypeContainer.Mark_HasEquals): New.
2700 (TypeContainer.Mark_HasGetHashCode): New.
2701 (ClassPart): Override them.
2702 (MethodCore.CheckBase): Use them instead of referring to Parent.Methods.
2704 * generic.cs (GenericMethod.DefineMembers): Update to changes.
2705 (TypeParameter.TypeParameter): Change type of 'parent' argument to
2709 * enum.cs (EnumMember.EnumMember): Pass the parent_enum as the
2710 'parent' argument to the base constructor.
2712 Remove all mention of TypeContainer from decl.cs.
2713 * decl.cs (MemberCore.Parent): Change into a DeclSpace.
2714 (MemberCore.MemberCore): Change type of 'parent' argument to DeclSpace.
2715 (DeclSpace.DeclSpace): Likewise.
2716 (DeclSpace.DefineMembers): Remove unused argument.
2717 * cs-parser.jay (pop_current_class): Update to changes. Simplify
2718 debugging check -- we don't care if the debug code throws an
2719 InvalidCastException instead of an InternalErrorException.
2720 * class.cs (TypeContainer.DefineMembers): Update to changes.
2721 (TypeContainer.DoDefineMembers): Likewise.
2722 (TypeContainer.GetMethods): Likewise.
2723 (PropertyMember.Define): Likewise.
2724 (MemberBase.Parent): New property that forwards to
2725 MemberCore.Parent, but ensures that we get a TypeContainer.
2726 * rootcontext.cs (RootContext.PopulateCoreType): Update to changes.
2727 (RootContext.PopulateTypes): Likewise. Remove special case code
2728 for !RootContext.StdLib: DefineMembers is idempotent.
2730 2005-12-13 Marek Safar <marek.safar@seznam.cz>
2732 * class.cs (Method.ApplyAttributeBuilder): Test out modifier properly.
2734 2005-12-11 Atsushi Enomoto <atsushi@ximian.com>
2736 * doc.cs : The search for referenced namespace was insufficient to
2737 get global one as it used to do. Fixed bug #76965.
2739 2005-12-10 Atsushi Enomoto <atsushi@ximian.com>
2741 * doc.cs : check name in cref in the last phase that whether it is
2744 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
2746 * cs-tokenizer.cs : reverted the latest change: it somehow broke
2749 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
2751 * doc.cs : so it turned out that we cannot skip override check for
2752 interface members. Fixed bug #76954.
2754 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
2756 * cs-tokenizer.cs : fixed bug #75984:
2757 - #warning and #error should not be handled when the source line
2759 - #line is not checked strictly when the source line is disabled.
2760 - #define and #undef is on the other hand checked strictly at any
2763 2005-12-08 Atsushi Enomoto <atsushi@ximian.com>
2765 * cs-tokenizer.cs : missing Location (actually, filename) in one of
2768 2005-12-15 Raja R Harinath <rharinath@novell.com>
2770 * generic.cs (TypeManager.IsGeneric): Remove unused method.
2772 * typemanager.cs (TypeManager.GetFullName): Rewrite to handle
2775 2005-12-14 Martin Baulig <martin@ximian.com>
2777 * typemanager.cs (TypeManager.GetFullName): Make this public;
2778 `Type.Fullname' now never returns null.
2780 * class.cs (Method.Define): Use TypeManager.GetFullName() for
2781 explicit interface implementations; we're now using the same
2782 naming convention than csc does.
2784 2005-12-14 Miguel de Icaza <miguel@novell.com>
2786 * convert.cs (ExplicitConversionCore): Check the return value from
2787 ExplicitConversionCore which can return null on failure. Fixes #76914
2789 2005-12-09 Raja R Harinath <rharinath@novell.com>
2791 * anonymous.cs (AnonymousMethod.Compatible): Use IsGenericType
2792 instead of IsGenericInstance.
2793 * generic.cs (TypeManager.IsEqual): Likewise. Delete redundant
2794 code that's now covered by the more general test.
2795 * typemanager.cs (TypeManager.IsPrivateAccessible): Likewise.
2797 * generic.cs (DropGenericTypeArguments): New. Captures the common
2798 pattern: if (t.IsGenericInstance) t = t.GetGenericTypeDefinition ();
2799 * attribute.cs, class.cs, decl.cs, ecore.cs: Use it.
2800 * generic.cs, report.cs, typemanager.cs: Likewise.
2802 2005-12-08 Martin Baulig <martin@ximian.com>
2804 * generic.cs (TypeArguments.Resolve): Added CS1547 check.
2806 * typemanager.cs (TypeManager.CSharpSignature): Include type
2807 arguments in the signature of a generic method.
2809 2005-12-07 Martin Baulig <martin@ximian.com>
2811 Add support for custom attributes on type parameters.
2813 * cs-parser.jay (type_arguments): Added `opt_attributes'.
2815 * generic.cs (TypeParameterName): New public class; we use this
2816 instead of a `string' to store the name of a type parameter, so we
2817 can also have `Attributes'.
2818 (TypeArguments.GetDeclarations): Return a `TypeParameterName[]'
2819 array instead of a `string[]' array.
2820 (TypeParameter.ctor): We now also take an `Attributes' argument.
2821 (TypeParameter.EmitAttributes): New public method; emit our
2822 `OptAttributes' here.
2823 (GenericMethod.EmitAttributes): New public method; emit the custom
2824 attributes on all our type parameters.
2826 * class.cs (TypeContainer.EmitType): Call EmitAttributes() on all
2827 our type parameters.
2828 (MethodData.Define): If we're a generic method, call
2829 EmitAttributes() on it.
2831 2005-12-07 Martin Baulig <martin@ximian.com>
2834 (ConstraintChecker): New public abstract class; move the
2835 constraint checking here from `ConstructedType' and also do
2836 constraint checking for generic methods here.
2838 * expression.cs (Invocation.OverloadResolve): Use
2839 ConstraintChecker.CheckConstraints() if we resolved to a generic
2842 2005-12-05 Marek Safar <marek.safar@seznam.cz>
2844 * attribute.cs (GlobalAttribute.ctor): Pass NamespaceEntry only.
2846 * class.cs (EmitFieldInitializers): Simplified and fixed to work with
2848 (FieldBase.EmitInitializer): Moved from TypeContainer and simplified.
2849 (FieldBase.Initializer): Initializer is now optional.
2850 (EventField.Define): Only event field can have initializer.
2852 * codegen.cs (EmitContext): DeclSpace is not readonly (small hack).
2854 * const.cs (Const): Reuse initializer.
2856 * cs-parser.jay: Updated after FieldBase changes.
2857 Added current_array_type to simplify array initializers.
2859 * ecore.cs (NullCast.IsDefaultValue): Implemented.
2861 * expression.cs, iterators.cs: Updated.
2863 * namespace.cs (NamespaceEntry): Made UsingFound private.
2865 2005-12-05 Marek Safar <marek.safar@seznam.cz>
2867 * parameterCollection.cs: Obsolete, removed.
2868 * parser.cs: Obsolete, removed.
2870 2005-12-05 Marek Safar <marek.safar@seznam.cz>
2873 * class.cs (Constructor.Emit): Set obsolete checking for whole context.
2875 * enum.cs (Enum.Define): Set obsolete context here.
2877 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
2880 - FindDocumentedMember() now expects 1) paramList as null
2881 when "we don't have to check the number of parameters" and
2882 2) Type.EmptyTypes when "there is no arguments".
2883 - Introduced FoundMember struct to hold the exact type which was
2884 used to find the documented member (the above change broke
2885 test-xml-044; it might be better just to use DeclaringType than
2886 what MS does, like this change does, but it depends on usage.)
2888 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
2890 * doc.cs : documented member might be from DeclaringType for nested
2891 types. Fixed bug #76782.
2893 2005-12-03 Ben Maurer <bmaurer@ximian.com>
2895 * anonymous.cs: Have the param code handle leaving copies on the
2896 stack etc. Allows anonymous params to take part in the assignment
2897 code (++, +=, etc). Fixes bug #76550
2899 * expression.cs: Handle the prepare_for_load/leave_copy by passing
2900 it down to the anon code.
2902 * iterators.cs: Use dummy var here
2904 * codegen.cs: Handle new vars
2906 2005-12-01 Marek Safar <marek.safar@seznam.cz>
2909 * class.cs (MethodData.Define): Set proper Obsolete context.
2911 * ecore.cs (FieldExpr.ResolveMemberAccess): Don't check [Obsolete] in
2913 (FieldExpr.DoResolve): Ditto.
2915 2005-12-01 Marek Safar <marek.safar@seznam.cz>
2918 * class.cs (MethodCore.DoDefineParameters): Test [Obsolete] only when
2919 parent is not obsolete.
2921 2005-12-01 Atsushi Enomoto <atsushi@ximian.com>
2923 * doc.cs : (FindDocumentedMember) find parameterless members first
2924 and get CS0419 in the early stage. Fixed first case of bug #76727.
2926 2005-11-30 Marek Safar <marek.safar@seznam.cz>
2929 * ecore.cs (Expression.ResolveAsConstant): Report constant error only when
2930 no error was reported.
2932 *expression.cs (Binary.DoResolve): left can be null.
2934 2005-12-06 Raja R Harinath <rharinath@novell.com>
2936 * class.cs (MethodCore.CheckGenericOverride): Delete unused
2937 abstract method and all overrides.
2938 * support.cs (ParameterData.GenericConstraints): Delete.
2939 (ReflectionParameters.type_params): Delete.
2940 (ReflectionParameters.ReflectionParameters): Make private.
2941 (ReflectionParameters.GetConstaints): New factory method.
2942 * generic.cs (TypeParameterDefineType): Use it.
2943 (TypeManager.GetTypeParameterConstraints): Likewise.
2945 2005-11-22 Marek Safar <marek.safar@seznam.cz>
2948 * class.cs (MethodData.Emit): Parameters should be labeled first.
2950 2005-11-21 Marek Safar <marek.safar@seznam.cz>
2953 * parameter.cs (Parameter.ApplyAttributeBuilder): Fixed `ref' detection.
2955 2005-11-18 Marek Safar <marek.safar@seznam.cz>
2957 * attribute.cs (AreParametersCompliant): Moved to Parameter.
2959 * class.cs (MethodCore): Parameter clean up.
2960 (IMethodData): Added ParameterInfo.
2961 (MethodData): Parameter clean up.
2962 (Indexer.Define): Parameter clean up.
2974 * typemanager.cs: Parameter clean up.
2976 * delegate.cs (Define): Get rid of duplicated code.
2978 * expression.cs (ParameterReference): Removed useless parameters
2980 (Invocation): Ditto.
2982 * parameter.cs (ParamsParameter): New class, params specialization.
2983 (ArglistParameter): Attemp to separate arglist.
2984 (Parameter): Refactored to be reusable and faster.
2985 (Parameter.Modifier): Made understandable.
2986 (Parameters): Changed to be used as a class for `this' assembly
2987 parameters. Refactored to use new specialized classes.
2989 * support.cs (ParameterData): Added Types property.
2990 (InternalParameters): Deleted.
2992 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
2994 * doc.cs : the previous patch does not actually fix the bug.
2995 PropertyInfo override check is now implemented and really fixed it.
2996 * expression.cs : Invocation.IsAncestralType() is used from doc.cs.
2998 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
3000 * doc.cs : apply "override filter" also to properties.
3003 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
3005 * doc.cs : renamed FindMembers() to FindMethodBase(). For interfaces,
3006 no need to check overrides. For classes, omit those results from
3007 interfaces since they must exist in the class. Fixed bug #76726.
3009 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
3011 * typemanager.cs : (GetFullNameSignature) differentiate indexers
3012 with different parameters. Fixed the second problem in #76685.
3014 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
3016 * doc.cs : (FindDocumentedMember) pass invocation_type as well (to
3017 get expected 'protected' access in CheckValidFamilyAccess()).
3020 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
3022 * doc.cs : (GenerateTypeDocComment) Fields could be FixedField.
3023 Fixed bug #76705. CS1569 was incorrectly commented out.
3025 2005-11-23 Martin Baulig <martin@ximian.com>
3027 * generic.cs (Constraints.Define): Removed.
3028 (TypeParameter.DefineConstraints): Removed.
3029 (TypeParameter.DefineType): Call SetGenericParameterAttributes()
3030 on the GenericTypeParameterBuilder here.
3032 2005-11-23 Martin Baulig <martin@ximian.com>
3034 * typemanager.cs (TypeManager.GetProperty): Make this public.
3036 * generic.cs (Nullable.NullableInfo.ctor): Use
3037 TypeManager.GetProperty() rather than using reflection directly.
3039 2005-11-17 Martin Baulig <martin@ximian.com>
3041 * expression.cs (Indexers.GetIndexersForType): Added support for
3042 generic parameters; fixes #76587.
3044 2005-11-17 Martin Baulig <martin@ximian.com>
3047 (CaptureContext.EmitMethodHostInstance): Use `Ldarg_0' if we
3048 inherit the scope from our parent. Fixes #76653.
3050 2005-11-15 Martin Baulig <martin@ximian.com>
3052 * anonymous.cs (ScopeInfo.ScopeType): New public field; use this
3053 instead of `ScopeTypeBuilder' to refer to the "current" type.
3054 (AnonymousMethod.CreateScopeType): Correctly create the helper
3055 class if we're inside a generic type definition.
3057 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
3059 * doc.cs : use Invocation.IsOverride() to do real override check.
3060 * expression.cs : made Invocation.IsOverride() internal.
3062 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
3064 * doc.cs : use TypeManager.FindMembers() instead of (possible)
3065 TypeBuilder.FindMembers() and filter overriden base members out.
3068 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
3070 * doc.cs : ref/out parameters are represented as '@' (instead of
3071 '&' in type FullName). Fixed bug #76630 (additionally crefs).
3073 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
3075 * doc.cs : when there was no '.' in cref to methods in doc comment,
3076 then parameters were missing in the output. Fixed bug #76691.
3078 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
3080 * driver.cs : don't output docs when there is an error.
3083 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
3086 Now it should detect indexers. Fixed primary concern in bug #76685.
3087 Fixed CS0419 message to not show the identical member signature in
3090 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
3092 * doc.cs : (FindDocumentedMember) use TypeManager.MemberLookup()
3093 instead of Type.FindMembers() since it does not handle events.
3096 2005-11-12 Gert Driesen <drieseng@users.sourceforge.net>
3098 * codegen.cs: Fixed typo (speficied -> specified).
3100 2005-11-11 Marek Safar <marek.safar@seznam.cz>
3103 * doc.cs (FindDocumentedTypeNonArray): Don't resolve again.
3105 2005-11-11 Marek Safar <marek.safar@seznam.cz>
3107 * attribute.cs: Changed error message.
3109 * cs-tokenizer.cs: One more check.
3111 2005-11-10 Marek Safar <marek.safar@seznam.cz>
3113 * statement.cs (Block.Resolve): Ignore empty statement.
3115 2005-11-10 Marek Safar <marek.safar@seznam.cz>
3117 * report.cs: Made error/warning methods more strict to avoid
3120 * anonymous.cs, attribute.cs, class.cs, codegen.cs, constant.cs,
3121 convert.cs, cs-parser.jay, cs-tokenizer.cs, decl.cs, delegate.cs,
3122 doc.cs, driver.cs, ecore.cs, expression.cs, location.cs,
3123 namespace.cs, parameter.cs, statement.cs, typemanager.cs: Updated.
3125 2005-11-11 Carlos Alberto Cortez <calberto.cortez@gmail.com>
3127 * codegen.cs (AssemblyClass.CheckInternalsVisibleAttribute):
3128 Use the more explicit AssemblyName.FullName instead of
3129 AssemblyName.Name to report errors.
3131 2005-11-11 Marek Safar <marek.safar@seznam.cz>
3133 * attribute.cs, class.cs, cs-tokenizer.cs, parameter.cs: Sync
3136 2005-11-10 Marek Safar <marek.safar@seznam.cz>
3146 * report.cs: Fixed error reporting and typos.
3148 * generic.cs (TypeParameter.GetSignatureForError): New method.
3149 (ConstructedType.GetSignatureForError): Instead of DeclarationName.
3151 * typemanager.cs (GetFullName): Refactored.
3153 2005-11-08 Marek Safar <marek.safar@seznam.cz>
3155 * attribute.cs (Attribute.GetCoClassAttributeValue): New method.
3156 (AttributeTester.GetCoClassAttribute): Get CoClassAttribute.
3158 * class.cs (TypeContainer.IsComImport): New property.
3159 (Constructor.Define): Create proper ctor for ComImport types.
3161 * expression.cs (New.CheckComImport): Fixed.
3163 2005-11-07 Miguel de Icaza <miguel@novell.com>
3165 * anonymous.cs (CaptureContext.AddParameterToContext): The fact
3166 that a parameter has been captured does not mean that we do not
3167 have to do the rest of the processing. This fixes the second part
3168 of #76592. If there was another anonymous method capturing
3169 values in the past, the Scope would never be set for the second
3170 method that captured the same parameter.
3172 (CaptureContext.EmitAssignParameter): When `leave_copy' is passed,
3173 properly manipulate the stack. Second part of fix for #76592.
3175 * expression.cs (New): Add support for invoking "new" on
3176 interfaces that have been flagged with the ComImport attribute and
3177 the CoClass. Fixes #76637
3179 * statement.cs (Try.DoEmit): When a variable is captured, do not
3180 try to emit the vi.LocalBuilder variable as it has been captured.
3181 Create a temporary variable and store the results on the
3182 FieldBuilder. Fixes #76642
3184 2005-11-07 Marek Safar <marek.safar@seznam.cz>
3186 * class.cs (CheckPairedOperators): Made compilable with csc 2.0.
3188 * ecore.cs (InstanceResolve): Fixed CS1540 detection.
3190 * expression.cs (Binary.DoResolve): Added && optimalization.
3192 * typemanager.cs (AddUserType): Removed useless argument.
3194 2005-11-04 Marek Safar <marek.safar@seznam.cz>
3196 * statement.cs (Block.variables): Uses ListDictionary.
3198 2005-11-03 Marek Safar <marek.safar@seznam.cz>
3201 * class.cs (PartialContainer.EmitType): Customized to emit
3202 security attributes.
3203 (ClassPart.ApplyAttributeBuilder): Transform security attribute
3204 for partial classes.
3206 2005-11-03 Marek Safar <marek.safar@seznam.cz>
3209 * expression.cs (ElementAccess.DoResolveLValue): Fixed buffer
3210 access has to be fixed.
3212 * typemanager.cs (IsUnmanagedType): Wrong common field type.
3214 2005-11-01 Marek Safar <marek.safar@seznam.cz>
3217 * ecore.cs (NullCast.Reduce): Implemented.
3219 * expression.cs (ArrayCreation.CheckIndices): Correcly check
3222 * statement.cs (SwitchLabel.ResolveAndReduce): Catch null
3224 (Foreach.Resolve): Catch null properly.
3226 2005-10-29 Marek Safar <marek.safar@seznam.cz>
3228 * cs-tokenizer.cs: Warning text fix.
3230 * driver.cs: AllWarningNumbers exposed on public interface.
3232 * report.cs (): Reviewed warning numbers.
3233 (IsValidWarning): Use binary search.
3235 2005-10-29 Marek Safar <marek.safar@seznam.cz>
3237 * driver.cs: Implemeted resource visibility.
3238 (Resources): New class for code sharing between /res: and
3241 2005-11-07 Marek Safar <marek.safar@seznam.cz>
3243 decl.cs (CurrentTypeParameters): Fixed to be public.
3245 2005-11-07 Marek Safar <marek.safar@seznam.cz>
3247 generic.cs, rootcontext.cs: Removed NewConstraintAttribute.
3249 2005-11-07 Marek Safar <marek.safar@seznam.cz>
3251 gmcs.exe.sources: Use CryptoConvert.cs from corlib.
3253 2005-11-05 Kornél Pál <kornelpal@hotmail.com>
3255 * gmcs.exe.config: Updated runtime version to v2.0.50727 (2.0 RTM).
3257 2005-11-04 Carlos Alberto Cortez <calberto.cortez@gmail.com>
3259 Add friend assembly access support.
3260 * typemanager.cs: assembly_internals_vis_attrs
3261 cache for friend assembly access.
3262 (TypeManager.IsFriendAssembly): New method for
3263 checking friend assembly access.
3264 (TypeManager.Error_FriendAccessNameNotMatching): New
3266 (TypeManager.CompareKeyTokens): Likewise.
3267 (TypeManager.Filter): Handle friend accessible
3270 * namespace.cs (RootNamespace.GetTypeInAssembly): Return
3271 friend accessible types.
3273 * ecore.cs (Expression.IsAccessorAccessible): Handle
3274 friend accessible properties.
3276 * decl.cs (DeclSpace.CheckAccessLevel): Handle friend
3279 2005-10-28 Marek Safar <marek.safar@seznam.cz>
3282 * cfold.cs (ConstantFold.BinaryFold): Implemented null cast
3285 * convert (Convert.ImplicitReferenceConversion): NullCast holds
3288 * ecore.cs (NullCast): Child is contant only.
3290 * literal.cs (NullLiteral.Reduce): null can be converted to any
3293 2005-10-28 Kornél Pál <kornelpal@hotmail.com>
3295 * driver.cs: Use Encoding.Default as default code page instead
3298 2005-10-27 Raja R Harinath <rharinath@novell.com>
3301 * expression.cs (Invocation.Error_InvalidArguments): Handle
3302 __arglist parameters.
3303 (Invocation.VerifyArgumentsCompat): Likewise.
3304 * support.cs (ReflectionParameters.GetSignatureForError): Print
3305 __arglist parameters.
3306 (InternalParamters.GetSignatureForError): Likewise.
3307 * parameter.cs (Parameters.GetSignatureForError): Likewise.
3309 2005-10-26 Marek Safar <marek.safar@seznam.cz>
3311 * attribute.cs (GetPropertyValue): Made public.
3313 * codegen.cs (AssemblyClass): ResolveClsCompliance renamed to
3315 Add new property WrapNonExceptionThrows to handle 2.0 assembly
3317 (AssemblyClass.Emit): Emit RuntimeCompatibilityAttribute when it
3320 * driver.cs: Reflect method name change.
3322 * statement.cs (Try.Resolve): Warn when try has both general
3325 * typemanager.cs: runtime_compatibility_attr_type new predefined
3328 2005-10-26 Raja R Harinath <harinath@gmail.com>
3331 * pending.cs (InterfaceMethod): Allow tm.args [i] to be null --
3332 treat it as an empty parameter list.
3334 2005-10-26 Raja R Harinath <rharinath@novell.com>
3337 * ecore.cs (SimpleName.DoSimpleNameResolve): Make fall-back
3338 ResolveAsTypeStep silent.
3339 * statement.cs (Block.AddConstant): Mark block as used.
3340 (Block.ResolveMeta): Avoid piling on error messages
3341 if a constant initializer resolution fails.
3343 2005-10-25 Raja R Harinath <rharinath@novell.com>
3345 * namespace.cs (RootNamespace.VerifyUsingForAll, Namespace.VerifyUsing):
3347 (NamespaceEntry.VerifyAllUsing): New.
3348 (NamespaceEntry.AliasEntry.Resolve): New. Handles common error
3349 behaviour. Delegates actual resolution of alias to ...
3350 (NamespaceEntry.DoResolve): ... this. Renamed from Resolve.
3351 (NamespaceEntry.LocalAliasEntry, NamespaceEntry.ExternAliasEntry):
3353 * driver.cs (Driver.MainDriver): Update.
3355 * namespace.cs (NamespaceEntry.DefineNamespace): Remove.
3356 (NamespaceEntry.SymbolFileID): Make into a on-demand computed
3358 (Namespace.DefineNamespaces, RootNamespace.DefineNamespacesForAll):
3360 * symbolwriter.cs (SymbolWriter.Initialize): Don't call
3361 RootNamespace.DefineNamespacesForAll.
3363 2005-10-24 Raja R Harinath <harinath@gmail.com>
3365 * typemanager.cs (assemblies, external_aliases, modules)
3366 (AddAssembly, AddExternAlias, AddModule GetAssemblies, Modules)
3367 (ComputeNamespaces, GetRootNamespace): Remove extra staging
3368 overhead. Move resposibility ...
3369 * namespace.cs (GlobalRootNamespace): ... here. Update to changes.
3370 * driver.cs, attribute.cs, codegen.cs: Update to changes.
3372 2005-10-23 Raja R Harinath <harinath@gmail.com>
3374 * namespace.cs (RootNamespace.all_namespaces): Renamed from
3375 cached_namespaces. Improve usage.
3376 (RootNamespace.Reset, RootNamespace.RegisterNamespace)
3377 (RootNamespace.VerifyUsingForAll, RootNamespace.DefineNamespacesForAll):
3378 Move from GlobalRootNamespace and simplify.
3379 (RootNamespace.Global): Make instance variable.
3380 (RootNamespace.RootNamespace): Add "alias name" parameter.
3381 (GlobalRootNamespace): Simplify drastically.
3382 (Namespace.Lookup): Don't use GetNamespace.
3383 * typemanager.cs (GetRootNamespace): Rename from
3384 ComputeNamespaceForAlias.
3385 (NamespaceClash): Use Global.IsNamespace instead of GetNamespace.
3387 2005-10-23 Marek Safar <marek.safar@seznam.cz>
3389 * anonymous.cs (AnonymousContainer): Don't crash when container
3392 2005-10-23 Marek Safar <marek.safar@seznam.cz>
3394 * expression.cs (Binary.DoResolve): Warn when comparing same
3397 2005-10-23 Marek Safar <marek.safar@seznam.cz>
3400 * expression.cs (Binary.DoResolve): It looks like there are no
3401 convetsion rules in enum context.
3403 2005-10-19 Carlos Alberto Cortez <calberto.cortez@gmail.com>
3405 Add support for extern alias qualifiers.
3406 * typemanager.cs: Move some LookupTypeReflection code
3407 to namespace.cs, to have cleaner code. Added some methods
3408 to help us keep track of the extern aliased references.
3409 * driver.cs: Add suport for extern alias assemblies on command
3410 line and check for their warnings/errors. Also keep track of the
3411 extern aliased assemblies.
3412 * namespace.cs: Move the global functionality of Namespace
3413 to GlobalRootNamespace/RootNamespace. Now the global namespace
3414 is GlobalRootNamespace.Globa. Also the code moved from
3415 typemanager.cs lives in GlobalRootNames.cs/RootNamespace.cs.
3416 Finally added LocalAliasEntry (AliasEntry before) and
3417 ExternAliasEntry, to handle alias statements.
3418 * cs-parser.jay: Add support in the grammar for extern alias
3420 * doc.cs, delegate.cs, expression.cs ecore.cs, symbolwriter.cs:
3421 Update callings to Namespace (now in GlobalRootNamespace).
3423 2005-10-25 Martin Baulig <martin@ximian.com>
3425 * convert.cs (ImplicitTypeParameterConversion): Make base
3426 interfaces actually work; fixes #76557.
3428 2005-10-25 Martin Baulig <martin@ximian.com>
3431 (GenericMethod.Define): Call TypeParameter.DefineConstraints() on
3432 all the type parameters; fixes #76551.
3434 2005-10-25 Martin Baulig <martin@ximian.com>
3439 (GenericMethod.ctor): Added `Expression return_type' and
3440 `Parameters parameters' arguments.
3441 (GenericMethod.DefineType): Call ResolveAsTypeTerminal() on the
3442 parameter and return types to check their constraints if they're
3445 * codegen.cs (EmitContext.ResolvingGenericMethod): New public
3448 * ecore.cs (Expression.ResolveAsTypeTerminal): Don't check the
3449 constraints of a generic type if `ec.ResolvingGenericMethod'.
3451 * class.cs (MethodCore.DoDefineParameters): Set
3452 `ec.ResolvingGenericMethod' if we're a generic method.
3453 (MemberBase.MemberType): Likewise.
3455 2005-10-25 Carlos Alberto Cortez <calberto.cortez@gmail.com>
3457 * typemanager.cs (TypeManager): Added
3458 TypeManager.internals_visible_attr_type to cache
3459 S.R.CompilerServices.InternalsVisibleToAttribute.
3461 * codegen.cs (AssemblyClass): Added checks for
3462 InternalsVisibleToAttribute in new method
3463 CheckInternalsVisibleAttribute () and also cache the
3464 AssemblyName in AssemblyClass.Name.
3466 2005-10-24 Martin Baulig <martin@ximian.com>
3469 (TypeManager.ExpandInterfaces): Added overloaded version which
3470 just takes a `Type[]' array.
3473 (Constraints.Resolve): Don't expand the interfaces here; ie. we
3474 just use the interfaces which were explicitly specified and not
3475 the interfaces they inherit. Fixes #76482.
3476 (TypeParameter.FindMembers): Expand the interfaces here.
3478 2005-10-21 Martin Baulig <martin@ximian.com>
3481 (Constraints.Resolve): Also resolve the actual types here.
3482 (Constraints.ResolveTypes): Just check the constraints here.
3483 Fixes #76363; see gtest-218.cs.
3485 2005-10-21 Martin Baulig <martin@ximian.com>
3488 (Convert.ImplicitTypeParameterConversion): Use a `ClassCast'
3489 instead of a `BoxedCast'; fixes gtest-217.cs.
3491 2005-10-20 Atsushi Enomoto <atsushi@ximian.com>
3493 * generic.cs : (ConstructedType.CheckConstraints) warn CS0310 when
3494 1) "new()" is specified as generic parameter constraint and 2) the
3495 type is TypeBuilder and 3) the type is abstract even if it has a
3496 default .ctor(). Now errors/gcs0310-3.cs is correctly rejected.
3498 2005-10-20 Martin Baulig <martin@ximian.com>
3501 (GenericConstraints.TypeParameter): New public property.
3502 (TypeParameter.ctor): Also take a `DeclSpace' argument.
3503 (TypeParameter.DeclSpace): New public property.
3504 (TypeParameter.DefineType): Inflate the constraints if our
3505 `DeclSpace' is an `Iterator'.
3507 2005-10-19 Atsushi Enomoto <atsushi@ximian.com>
3509 * class.cs, decl.cs : (MemberCache.FindMemberToOverride) added
3510 GenericMethod argument to compare methods' generic type arguments.
3513 2005-10-19 Martin Baulig <martin@ximian.com>
3515 * class.cs (TypeContainer.DefineType): Only use ResolveAsTypeStep(),
3516 not ResolveType() when resolving the base type, so we're not
3517 checking the constraints here.
3518 (TypeContainer.ResolveType): Call ResolveType() on our base_type
3521 2005-10-19 Martin Baulig <martin@ximian.com>
3523 * generic.cs (ConstructedType.CheckConstraints): Committing
3524 untested fix for #76441.
3526 2005-10-18 Raja R Harinath <rharinath@novell.com>
3529 * class.cs (TypeContainer.DefineType): Move updating of
3530 topological sort earlier in the code.
3531 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Don't use TypeBuilder.
3533 2005-10-18 Marek Safar <marek.safar@seznam.cz>
3536 * cfold.cs (BinaryFold): Reduce constant in enum conversion.
3538 * constant.cs (Constant.TryReduce): Moved from Cast class.
3539 (Reduce): Made little bit more OO and fixed missing conversions.
3541 * ecore.cs (Reduce): Implemented.
3542 (Binary.EnumLiftUp): New method to upgrade values to enum values.
3544 * literal.cs (Reduce): Implemented.
3546 * class.cs: Reverted Miguel's wrong commit.
3548 2005-10-14 Miguel de Icaza <miguel@novell.com>
3550 * ecore.cs (GetMemberType): Report the correct mapping for the MemberCore
3552 2005-10-14 Atsushi Enomoto <atsushi@ximian.com>
3554 * cs-parser.jay, expression.cs : CS0214 was missing error location
3555 for constants. Fixed bug #76404.
3557 2005-10-10 Raja R Harinath <rharinath@novell.com>
3559 * ecore.cs (PropertyExpr.Emit): Use Invocation.EmitCall to emit
3561 (PropertyExpr.EmitCall): Likewise.
3562 * expression.cs (Invocation.EmitArguments): Handle case where
3564 (Invocation.EmitCall): Avoid allocating temporary variable if
3565 there are no arguments.
3567 2005-10-11 Marek Safar <marek.safar@seznam.cz>
3570 * convert.cs (ExplicitConversionCore): Fixed object->enum
3573 2005-10-07 Raja R Harinath <rharinath@novell.com>
3576 * convert.cs (ImplicitConversionStandard): Move conversion of
3577 void* to arbitrary pointer types ...
3578 (ExplicitConversionStandard): .. here.
3579 * ecore.cs (Expression.Error_ValueCannotBeConverted): Fix CS0266
3580 error to always print typenames.
3582 2005-10-07 Raja R Harinath <rharinath@novell.com>
3584 * convert.cs (GetConversionOperator): Rename from
3585 GetConversionOperators. Move operator selection code from ...
3586 (UserDefinedConversion): ... here.
3588 2005-10-06 Marek Safar <marek.safar@seznam.cz>
3590 * convert.cs (ExplicitConversionCore): Removed duplicate enum
3593 2005-10-05 Marek Safar <marek.safar@seznam.cz>
3595 * assign.cs (Assign.DoResolve): Error method changed.
3597 * cfold.cs (DoConstantNumericPromotions): Error method changed.
3599 * const.cs (ResolveValue): Reset in_transit immediately.
3601 * constant.cs: Error method changed.
3603 * convert.cs: Removed useless location parameter.
3604 (ExplicitNumericConversion): Don't do double enum check.
3605 (ExplicitConversionCore): Renamed from ExplicitConversion.
3606 (ExplicitUnsafe): Extracted from ExplicitConversion.
3607 (ExplicitConversion): Uses for error reporting.
3609 * ecore.cs (Error_ValueCannotBeConverted): More logic for more
3611 (ResolveBoolean): Uses common error method.
3612 (CastToDecimal): Get rid of ec.
3613 (CastFromDecimal): Optimized.
3614 (ConvCast): Get rid of ec.
3616 * enum.cs (ResolveValue): Reset in_transit immediately.
3617 (Emit): Return after first error.
3619 * expression.cs: Convert changes.
3621 * literal.cs: Error method changed.
3623 * statement.cs: Error method changed.
3625 2005-10-06 Raja R Harinath <rharinath@novell.com>
3627 Fix gtest-131.cs and gtest-211.cs.
3628 * generic.cs (Nullable.LiftedBinaryOperator.EmitEquality):
3629 Only emit code for a label if it is used. Unreachable code can
3630 violate ECMA evaluation stack invariants.
3632 2005-09-27 Marek Safar <marek.safar@seznam.cz>
3634 * anonymous.cs: Implemented ExprClassName.
3636 * assign.cs (Assign.DoResolve): Don't chrash when type is not
3639 * attribute.cs (ResolveArguments): Enabled MethodImplOptions
3642 * class.cs (StaticClass.DefineContainerMembers): Report protected
3645 * codegen.cs: if(ed) PRODUCTION.
3647 * convert.cs (Error_CannotImplicitConversion): Better error
3650 * cs-parser.jay: More error checks.
3652 * cs-tokenizer.cs (consume_identifier): Fixed Miguel's revert.
3654 * driver.cs (CSCParseOption): Enabled wrong option check.
3656 * ecore.cs (Expression.ExprClassName): Turned to property.
3657 (MemberExpr.CheckIntermediateModification): For checking boxed
3658 value types modification.
3660 * statement.cs (Fixed.Resolve): Expression type must be
3661 convertible to fixed type.
3662 (CollectionForeach.GetEnumeratorFilter,TryType):
3663 Small refactoring for easier error checking.
3665 2005-09-26 Marek Safar <marek.safar@seznam.cz>
3667 * attribute.cs (Attribute.Resolve): Check Obsolete attribute for
3670 * class.cs (GeneratedBaseInitializer): New class for customization
3671 compiler generated initializers.
3672 (MemberBase.DoDefine): Check Obsolete attribute here.
3673 (FieldMember.DoDefine): Ditto.
3675 * const.cs (ExternalConstant.CreateDecimal): Builder for decimal
3678 * decl.cs (MemberCore.EmitContext): Returns valid current ec.
3679 (MemberCore.GetObsoleteAttribute): Removed argument.
3680 (MemberCore.CheckObsoleteness): Obsolete attributes are hierarchic.
3681 (MemberCore.CheckObsoleteType): New helper.
3685 * statement.cs: Updates after MemberCore changes.
3687 * ecore.cs (TypeExpr.ResolveType): Check type obsoleteness here.
3688 (FieldExpr.ResolveMemberAccess): Fixed decimal constants checks.
3690 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't check
3691 obsolete attribute for compiler construct.
3692 (As.DoResolve): Cache result.
3694 * iterators.cs (Define_Constructor): Use GeneratedBaseInitializer.
3696 2005-10-01 Miguel de Icaza <miguel@novell.com>
3698 * expression.cs (Probe): instead of having a "Type probe_type"
3699 keep the extra information as a TypeExpr probe_type_expr since the
3700 "As" operator needs to perform some type checks.
3702 * (As.DoResolve): If the type is a type parameter, ensure that it
3703 is constrained by a class.
3705 2005-09-22 Miguel de Icaza <miguel@novell.com>
3707 * statement.cs (Lock): Use the TemporaryVariable class instead of
3708 manually using local variables as those do not work when variables
3711 * ecore.cs: Moved the TemporaryVariable class from being a nested
3712 class inside Foreach to be a public class that can be employed in
3715 2005-09-19 Marek Safar <marek.safar@seznam.cz>
3717 * cs-parser.jay: interface_accessors replaced by
3718 accessor_declarations.
3720 * ecore.cs, literal.cs, statement.cs: NullLiteral holds null
3723 * statement.cs (GotoCase.Resolve): Convert null constant to
3725 (SwitchLabel.ResolveAndReduce): Ditto.
3726 (SwitchLabel.NullStringCase): Custom null stamp.
3727 (Switch.SimpleSwitchEmit): Fix from NullLiteral to NullStringCase.
3729 typemanager.cs (CSharpSignature): Don't skip first argument
3732 2005-09-16 Marek Safar <marek.safar@seznam.cz>
3734 * cfold.cs, constant.cs, convert.cs, ecore.cs,
3735 expression.cs, iterators.cs, literal.cs: Store constants and
3738 * class.cs (MemberBase.ShortName): Pass location.
3740 * cs-parser.jay: Some location fixes.
3742 * ecore.cs (Expression.Location): Made virtual.
3744 2005-09-27 Marek Safar <marek.safar@seznam.cz>
3747 * const.cs (Const.ResolveValue): Check for assigning non-null
3748 value to reference type.
3750 2005-09-26 Raja R Harinath <rharinath@novell.com>
3753 * expression.cs (This.VerifyFixed): In a value type T, the type of
3754 'this' is T&, iow, 'this' is either an out or ref parameter. In a
3755 value type R, 'this' is treated as a value parameter.
3757 2005-09-05 Miguel de Icaza <miguel@novell.com>
3759 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
3760 if the underlying types are the same, otherwise we need to produce
3761 code that will do the proper cast.
3763 This was exposed by Marek's constant rewrite which produced
3764 invalid code for the call site:
3767 void Method (X v) {}
3771 This fixes test-49.cs
3773 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
3775 * attribute.cs : (Attribute.IsValidArgumentType): array of string/
3776 Type/Object should be allowed as well. Fixed bug #75968.
3778 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
3780 * expression.cs : (Binary.DoResolve): when one is enum constant and
3781 another is constant 0, then return enum one *as enum type*.
3784 2005-10-04 Martin Baulig <martin@ximian.com>
3786 * ecore.cs (PropertyExpr.ResolveAccessors): Cosmetic fix; make the
3787 `SetMemberIsUsed()' work for generics, too.
3789 2005-10-04 Martin Baulig <martin@ximian.com>
3791 * expression.cs (DelegateInvocation.EmitStatement): Make this work
3792 for corlib. Fixes #75691.
3794 2005-09-28 Marek Safar <marek.safar@seznam.cz>
3797 * driver.cs: Fix compilation files with full root path.
3799 2005-09-25 Miguel de Icaza <miguel@novell.com>
3801 * report.cs (SymbolRelatedToPreviousError): Format the output so
3802 it does not use an open parenthesis that is never closed.
3804 * driver.cs: Follow coding guidelines
3806 2005-09-18 Miguel de Icaza <miguel@novell.com>
3808 * driver.cs: Set InEmacs based on the environment variable EMACS.
3810 * location.cs (InEmacs): in this mode, do not report column
3811 location as it confuses Emacs.
3813 2005-10-03 Raja R Harinath <rharinath@novell.com>
3815 * support.cs (SeekableStreamReader.Position): Don't error out when
3816 the requested position is just beyond the end of the current
3819 2005-09-28 Raja R Harinath <rharinath@novell.com>
3821 * support.cs (SeekableStreamReader): Simplify drastically. Don't
3822 try to keep in sync with the byte count of the underlying Stream.
3823 However, this limits us to a window size of 2048 characters: i.e.,
3824 the maximum lookahead of our lexer/parser can be 2048 characters.
3826 2005-09-22 Martin Baulig <martin@ximian.com>
3828 * driver.cs: Removed a debugging FIXME.
3830 2005-09-21 Raja R Harinath <rharinath@novell.com>
3832 * cs-parser.jay (type_arguments): Add CS1644 check.
3833 * decl.cs (DeclSpace.AddToContainer): Restore CS0694 check.
3835 2005-09-15 Raja R Harinath <rharinath@novell.com>
3837 * Makefile (PROGRAM): Make profile specific.
3838 (gmcs.exe) [PROFILE=net_2_0]: Add utility rule to copy gmcs.exe to
3839 the current directory.
3842 * expression.cs (Invocation.EmitCall): Remove optimization on
3843 this_call since it doesn't handle 'this' being a value type.
3845 2005-09-05 Geoff Norton <gnorton@customerdna.com>
3847 * driver.cs: Ensure file handles are closed after parsing
3849 2005-09-05 Miguel de Icaza <miguel@novell.com>
3851 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
3852 if the underlying types are the same, otherwise we need to produce
3853 code that will do the proper cast.
3855 This was exposed by Marek's constant rewrite which produced
3856 invalid code for the call site:
3859 void Method (X v) {}
3863 This fixes test-49.cs
3865 2005-09-05 Martin Baulig <martin@ximian.com>
3867 * expression.cs (As.DoResolve): Use `probe_type.IsValueType'
3868 instead of `TypeManager.IsValueType (probe_type)'; fixes #75668.
3870 * cs-parser.jay (delegate_declaration): Small fix for #75852.
3872 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
3874 * typemanager.cs: (IsUnmanagedType) : generic parameter is not allowed
3875 to be a pointer type due to the spec 25.2, so check if declaring
3876 type is generic type definition. Fixed bug #75772.
3878 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
3881 * generic.cs : (TypeManager.IsEqual(Type,Type)): it should work when
3882 both types are not defined by methods.
3883 * expression.cs : (Invocation.IsApplicable): it should work when
3884 the argument type is equal to the parameter type, not only when
3885 ImplicitConversionExists() returns true.
3887 2005-09-02 Raja R Harinath <rharinath@novell.com>
3889 * attribute.cs (GetMarshal): Work even if "DefineCustom" is
3893 * ecore.cs (SimpleNameResolve.DoSimpleNameResolve): Disable
3894 flow-branching for LocalVariableReferences in case we were invoked
3895 from a MemberAccess.
3896 * expression.cs (LocalVariableReference.VerifyAssigned): New.
3898 (LocalVariableReference.DoResolveBase): ... this.
3899 (MemberAccess.Resolve): Do the check that was disabled during
3902 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
3905 (PartialContainer.Create): check abstract/sealed/static strictly
3906 but abstract/sealed can exist only at one side. Fixed bug #75883.
3908 2005-09-01 Kornél Pál <kornelpal@hotmail.com>
3911 * attribute.cs (Attribute.GetMarshal): If ArraySubType is not
3912 specified, don't default to UnmanagedType.I4.
3914 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
3916 * expression.cs : conditional operator should check possibly
3917 incorrect assign expression. Fixed bug #75946.
3919 2005-08-30 Raja R Harinath <rharinath@novell.com>
3922 * anonymous.cs (ScopeInfo.MakeFieldName): New helper.
3923 (ScopeInfo.EmitScopeType): Use it to construct field names from
3924 names of captured locals.
3927 * ecore.cs (BoxedCast.BoxedCast) [1-argument variant]: Remove.
3928 * convert.cs (ImplicitReferenceConversion, TryImplicitIntConversion):
3929 Pass 'target_type' to BoxedCast. Don't default to 'object'.
3930 (ExplicitConversion): Remove enum cases already handled by
3931 implicit conversion. Move implicit conversion check to the beginning.
3932 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Update.
3933 * expression.cs (ArrayCreation.EmitDynamicInitializers):
3934 Don't treat System.Enum as a struct.
3936 2005-08-30 Jb Evain <jbevain@gmail.com>
3938 * attribute.cs: handles as expression in parameters.
3940 2005-08-30 Raja R Harinath <rharinath@novell.com>
3943 * class.cs (TypeContainer.VerifyClsName): Don't use a
3944 PartialContainer when verifying CLS compliance.
3945 (AbstractPropertyEventMethod): Set Parent here, ...
3946 (PropertyMethod): ... not here.
3948 2005-08-30 Atsushi Enomoto <atsushi@ximian.com>
3950 * attribute.cs : escaped attribute name should not be allowed to be
3951 resolved (e.g. @class as classAttribute). Fixed bug #75930.
3953 2005-08-29 Raja R Harinath <rharinath@novell.com>
3956 * convert.cs (ImplicitStandardConversionExists): Allow zero also
3957 when converting a long constant to unsigned long.
3958 * expression.cs (Invocation.OverloadResolve): Add sanity check to
3959 detect where IsApplicable and VerifyArgumentsCompat disagree.
3961 2005-08-29 Raja R Harinath <rharinath@novell.com>
3962 and Carlos Alberto Cortez <carlos@unixmexico.org>
3965 * class.cs (TypeContainer.CanElideInitializer): New helper.
3966 (TypeContainer.EmitFieldInitializers): Use it to determine if we
3967 can safely emitting the initializer of a field.
3969 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
3971 * statement.cs : (Continue.Resolve()) Unlike break, continue is not
3972 allowed inside a switch (without loop). Fixed bug #75433.
3974 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
3976 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
3977 * mcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
3979 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
3981 * driver.cs : kinda reverting the default encoding changes (not exact
3982 revert since I noticed that "codepage:reset" might not work fine).
3984 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
3986 * class.cs : (AbstractPropertyEventMethod) SetupName() now takes
3987 Location. Now getter and setter store location correctly.
3988 (errors/cs0111-12.cs now reports the expected location.)
3990 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
3992 * driver.cs : Use default encoding on the environment.
3993 Removed (now that) extra parameter for SeekableStreamReader.
3994 * support.cs : (SeekableStreamReader) third .ctor() argument for
3995 StreamReader is not required (always true). preamble size could
3996 be acquired in simpler and safe way.
3998 2005-08-24 Atsushi Enomoto <atsushi@ximian.com>
4000 * cs-parser.jay: report CS0642 at warning level 3
4001 and report CS0642 for an if else statement also
4002 fixes bug #74745. Patch by John Luke (and a bit
4004 Removed extra CS0642 warning check for "while",
4006 * statement.cs: In Block.Resolve(), CS0642 check
4007 is reimplemented to check a sequence of an empty
4008 statement and a block.
4010 Both fix bug #66777.
4012 2005-08-24 Marek Safar <marek.safar@seznam.cz>
4014 * attribute.cs (GetMethodObsoleteAttribute): Disabled obsolete properties
4015 detection until I fix it.
4017 * cs-tokenizer.cs: Changed error message.
4019 * cs-parser.jay: Fixed 2 error locations.
4021 * ecore.cs (Error_TypeDoesNotContainDefinition): Share error message.
4022 (PropertyExpr.Error_PropertyNotFound): First attempt to detect non C#
4025 * enum.cs (GetSignatureForError): Fixed.
4027 * expression.cs (Invocation.IsSpecialMethodInvocation): Improved special
4031 * typemanager.cs (RegisterProperty): Removed.
4033 * statement.cs (CheckInvariantMeaningInBlock): Changed error message.
4035 2005-08-24 Raja R Harinath <rharinath@novell.com>
4038 * expression.cs (ArrayAccess.EmitLoadOpcode): Emit ldelem.i for pointers.
4039 (ArrayAccess.GetStoreOpcode): Return stelem.i for pointers.
4041 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
4043 * expression.cs : tiny fix is required for not warning positive ulong.
4046 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
4048 * expression.cs : add CS0652 check for constant and integral
4049 expression. Fixed bug #53974.
4051 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
4053 * expression.cs : in DoNumericPromotions(), check if there is implicit
4054 conversion overload for string (to check CS0034). Fixed bug #52492.
4056 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
4058 * cs-tokenizer.cs : Check newline in char constant. Fixed bug #75245.
4060 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
4062 * ecore.cs : report location when it is *not* Null.
4064 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
4070 Added OmitStructFlowAnalysis to EmitContext to handle CS0165 check
4071 correctly. Fixed bug #75721.
4073 2005-08-23 Raja R Harinath <rharinath@novell.com>
4075 * support.cs (SeekableStreamReader.Position): Avoid an expensive
4076 loop that performs 'min (pos, char_count)'.
4079 * expression.cs (Unary.ResolveOperator): Don't discard implicit
4080 converted value in Operator.OnesComplement.
4082 2005-08-22 Ben Maurer <bmaurer@ximian.com>
4084 * anonymous.cs: If the anon method is pulled into a helper class,
4085 it needs to be `internal' not `private'. Fixes runtime behavior on
4088 2005-08-17 Marek Safar <marek.safar@seznam.cz>
4091 * decl.cs (DeclSpace.VerifyClsCompliance): Skip when collision object
4094 2005-08-16 Marek Safar <marek.safar@seznam.cz>
4096 The big constants rewrite
4097 Fix #75746, #75685 and more
4098 As a side effect saved 1MB for MWF ;-)
4100 * attribute.cs (GetAttributeArgumentExpression): Use ToType, GetTypedValue.
4101 (GetMarshal, GetMethodImplOptions, GetLayoutKindValue): Values are not
4102 enum based for corlib compilation.
4104 * cfold.cs (BinaryFold): Convert operand for enum additions. Fixed enum
4107 * class.cs (FixedField.Define): Use ResolveAsConstant.
4109 * const.cs (IConstant): Interface constants and enums.
4110 (Const.ResolveValue): New method for constant resolvning.
4111 (ExternalConstant): Constants from imported assemblies.
4113 * constant.cs (Constant.GetTypedValue): Used to get constant with forced
4114 conversion; like enums.
4115 (Constant.ToType): Converts this constant to different type.
4116 (Constant.Increment): Adds 1.
4118 * convert.cs (ImplicitConversionRequired): Simplified.
4120 * cs-parser.jay: Create EnumMember directly.
4122 * decl.cs (MemberCore.CheckObsoleteness): Checks for ObsoleteAttribute presence.
4124 * doc.cs (GenerateEnumDocComment): Removed.
4126 * ecore.cs (Expression.ResolveAsConstant): New constant specific method.
4127 (ConvertIntLiteral): Removed.
4128 (FieldExpr.ResolveMemberAccess): Refactored to remove constant specific if(s).
4130 * enum.cs (EnumMember): Implement IConstant.
4131 (Enum.IsValidEnumConstant): Removed.
4132 (Enum.GetNextDefaultValue): Removed.
4133 (Enum.FindMembers): Updated.
4134 (Enum.GenerateDocComment): Iterate enum members.
4136 * expression.cs (Cast.TryReduce): Handle enums correctly.
4137 (New.Constantify): Made public.
4138 (MemberAccess.DoResolve): Removed contant specific if(s).
4140 * literal.cs (NullLiteral): Implement new abstract methods.
4142 * statement.cs (GotoCase.Resolve): Use new constant methods.
4143 (SwitchLabel.ResolveAndReduce): Use new constant methods.
4145 * typemanager.cs (LookupEnum): Removed.
4146 (IsEnumType): Fixed to work with corlib.
4147 (RegisterConstant): Removed.
4148 (LookupConstant): Removed.
4149 (GetConstant): Changed to work with IConstant.
4151 2005-08-04 Atsushi Enomoto <atsushi@ximian.com>
4153 * location.cs : Fixed overflown (>255) column number.
4155 2005-08-03 Raja R Harinath <rharinath@novell.com>
4157 First cut of the qualified-alias-member feature.
4158 * cs-tokenizer.cs (Tokenizer.is_punct): Recognize the double-colon
4160 * cs-parser.jay (DOUBLE_COLON): New token.
4161 (namespace_or_type_name): Add rule for recognizing
4162 qualified-alias-members.
4163 (primary_expression): Likewise.
4164 (element_access): Allow QualifiedAliasMember as a possible
4165 type-bearing expression.
4166 (local_variable_type, local_variable_pointer_type): Likewise.
4167 * namespace.cs (NamespaceEntry.LookupAlias): New. Looks up
4168 aliases in the current and enclosing namespace declarations.
4169 (NamespaceEntry.UsingAlias): Add CS0440 warning.
4170 * decl.cs (MemberName.is_double_colon): New.
4171 (MemberName.MemberName): Add new constructor for alias-member.
4172 (MemberName.GetTypeExpression): Generate QualifiedAliasMember too.
4173 * expression.cs (QualifiedAliasMember): New expression type.
4175 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
4177 * location.cs : it borked when no argument was specified.
4179 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
4181 * location.cs : tiny ToString() format fix.
4183 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
4185 * statement.cs : oops, it was missing.
4187 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
4189 A set of fixes for precise line/column location.
4192 "token" field now holds a file/line "delta", a line number offset
4193 from the segment, and a column number. See also:
4194 http://lists.ximian.com/pipermail/mono-devel-list/2004-
4195 December/009508.html
4196 Removed static IsNull. Use instance IsNull property instead.
4198 For some tokens it stores Location. For Identifier it stores
4199 LocatedToken which is a pair of string name and location.
4200 Column numbers are adjusted only at getChar().
4202 Use Location.ToString() for reporting (it now contains column).
4204 Largely modified to use LocatedToken instead of
4205 string (IDENTIFIER), and to acquire Location from some tokens.
4206 * namespace.cs, decl.cs, ecore.cs, class.cs, delegate.cs,
4207 iterators.cs, const.cs, anonymous.cs, tree.cs, enum.cs,
4209 Now MemberName holds Location. DeclSpace.ctor() receives Location
4210 as a parameter. Removed extra parameters to all derived classes.
4211 Replaced Location.IsNull() with instance property.
4212 * assign.cs, expression.cs :
4213 Added .ctor() overload that omits Location.
4215 Added "nameEscaped" flag that indicates the identifier was escaped
4216 in the source file. This fixes bug #57047.
4218 2005-09-02 Martin Baulig <martin@ximian.com>
4220 * class.cs: Make CS3005 a warning, not an error.
4222 2005-08-02 Marek Safar <marek.safar@seznam.cz>
4224 * attribute.cs (AttributeTester.GetImportedIgnoreCaseClsType):
4225 New method, looking for lo-case imported cls type.
4227 * decl.cs (DeclSpace.VerifyClsCompliance): Check CS3005 for types
4230 * driver.cs: Removed VerifyTopLevelNameClsCompliance usage.
4232 * enum (Enum.VerifyClsCompliance): Hardcode non-compliant types.
4234 * typemanager.cs (TypeManager.AllClsTopLevelTypes): Renamed from
4236 (TypeManager.LoadAllImportedTypes): Lo-case imported types.
4238 Optimized to save 3.5 MB for SWF compilation.
4240 2005-08-01 Marek Safar <marek.safar@seznam.cz>
4242 * class.cs (AddToTypeContainer): Use inheritance insted of if(s).
4243 (PartialContainer.Create): Moved logic AddToContainer.
4244 (PartialContainer.MarkForDuplicationCheck): Shares name.
4246 * decl.cs (DeclSpace.AddToContainer): Check name collisions at one
4249 * namespace.cs (Namespace.AddDeclSpace): Lazy declspaces
4251 (Namespace.GetSignatureForError): New method.
4253 * tree.cs (Tree.RecordDecl): Moved to AddToContainer.
4254 (RootTypes.AddToTypeContainer): se inheritance insted of if(s).
4256 2005-08-01 Raja R Harinath <rharinath@novell.com>
4259 * ecore.cs (Expression.MemberLookupFailed): Use queried_type for
4260 member lookup rather than qualifier_type, since qualifier_type can
4263 2005-08-01 Marek Safar <marek.safar@seznam.cz>
4265 * enum.cs (Enum.VerifyClsName): Fixed to allow not CLSCompliant
4268 2005-07-31 Miguel de Icaza <miguel@novell.com>
4270 * statement.cs: Copy the local exception into the exception
4271 captured local. Fixes 75674
4273 2005-07-31 Raja R Harinath <harinath@gmail.com>
4276 * expression.cs (Invocation.OverloadResolve): Don't report error
4277 CS1501 if error CS1502 has been reported.
4278 (New.DoResolve): Delegate CS1501 reporting to
4279 Invocation.OverloadResolve.
4282 * statement.cs (Block.CheckInvariantMeaningInBlock): Verify
4283 invariant-meaning-in-block property in an enclosing block if
4286 2005-07-29 Marek Safar <marek.safar@seznam.cz>
4288 * statement.cs (SwitchLabel.ResolveAndReduce): Refactored.
4289 (SwitchLabel.Erorr_AlreadyOccurs): Share error message.
4290 (Switch.CheckSwitch): Just save 50kb for SWF.
4292 2005-07-27 Martin Baulig <martin@ximian.com>
4294 * anonymous.cs (CaptureContext.AddField): Added
4295 `AnonymousContainer am' argument; compute its toplevel scope if
4296 it's not already computed. Fixes #75649.
4298 2005-07-26 Raja R Harinath <rharinath@novell.com>
4301 * class.cs (Constructor.Emit): Reset block to null if the block
4304 2005-07-25 Marek Safar <marek.safar@seznam.cz>
4306 * class.cs (TypeContainer.VerifyMembers): Be compatible in warning 169.
4308 2005-07-25 Marek Safar <marek.safar@seznam.cz>
4310 * class.cs (MethodData.Define): Check whether accessor implementing
4311 interface is public.
4313 * driver.cs (Driver.parse): Try to be smart and check for `MZ' header.
4315 2005-07-22 Marek Safar <marek.safar@seznam.cz>
4318 * namespace.cs (LookupType): Moved same type check to...
4320 * typemanager.cs (LookupTypeReflection): Don't allow to import more types
4323 2005-07-21 Raja R Harinath <rharinath@novell.com>
4325 * namespace.cs (NamespaceLookupType): Avoid a string allocation when we
4326 already found a typebuilder.
4327 * class.cs (MethodCore.IsDuplicateImplementation): Compare
4328 MemberNames, not strings.
4330 * const.cs (Error_ExpressionMustBeConst):
4331 Rename from Error_EpressionMustBeConst.
4332 * const.cs, class.cs, statement.cd: Update.
4334 2005-07-21 Marek Safar <marek.safar@seznam.cz>
4338 * const.cs (Const.LookupConstantValue): Report missing contant expression
4340 (Error_EpressionMustBeConstant): Only one error method.
4342 * class.cs, statement.c: Updated.
4344 2005-07-20 Raja R Harinath <rharinath@novell.com>
4346 * statement.cs (Block.Flags): Add back HasVarargs.
4347 (Block.flags): Make protected.
4348 (ToplevelBlock.HasVarargs): Convert to a property that updates flags.
4350 * typemanager.cs (types, typecontainers, user_types): Remove.
4351 (UserTypes, TypeContainers): Likewise.
4352 (HandleDuplicate, AddDelegateType, AddEnumType): Likewise.
4353 (CleanUp, Reset): Update.
4354 (AddUserType): Combine variants. Now, only updates builder_to_declspace.
4355 (GetNestedType): Use Type.GetNestedType.
4356 (CoreLookupType): Take two arguments, the namespace and the
4357 basename of the type. Update to use the Namespace.Lookup
4359 (InitEnumUnderlyingTypes, InitCoreTypes): Update.
4360 (RealMemberLookup): Use IsNestedChildOf instead of playing with
4361 string concatenation and substring matches.
4362 * class.cs, enum.cs, delegate.cs: Update to changes.
4364 2005-07-20 Marek Safar <marek.safar@seznam.cz>
4366 * constant.cs (Constant.Error_ConstantValueCannotBeConverted): Moved from
4367 Expression and made virtual.
4369 * convert.cs (ImplicitReferenceConversionExists): Skip for value types.
4370 (ImplicitStandardConversionExists): Fixed `byte' typo ?
4372 * ecore.cs (Expression.Error_ConstantValueCannotBeConverted): Moved.
4374 * literal.cs (NullLiteral.Error_ConstantValueCannotBeConverted): Customize
4377 * convert.cs, ecore.cs, enum.cs: Reflect Error_ConstantValueCannotBeConverted
4380 2005-07-18 Marek Safar <marek.safar@seznam.cz>
4383 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Check whether
4384 AssemblyCultureAttribute is not used on executable.
4387 * typemanager.cs: Add System.Reflection.AssemblyCultureAttribute.
4389 2005-07-16 Raja R Harinath <rharinath@novell.com>
4392 * expression.cs (Binary.Warning_UnintendeReferenceComparison):
4393 New. Reports CS0252/CS0253.
4394 Mostly taken from preliminary patch by Duncak Mak.
4395 (Binary.DoResolveOperator): Store results of operator lookup.
4396 Use them to detect if we need to warn about unintended reference
4399 2005-07-15 Raja R Harinath <rharinath@novell.com>
4402 * namespace.cs (Namespace.Lookup): Add back location parameter.
4403 (Namespace.LookupType): Add CS0436 report. Add location parameter.
4404 * delegate.cs, ecore.cs, expression.cs: Update to changes.
4406 * codegen.cs (EmitContext.DeclSpace): Make readonly.
4407 * namespace.cs (Namespace.Lookup): Carve out type lookup into ...
4408 (Namespace.LookupType): ... this.
4409 (NamespaceEntry.GetUsingTable): Allocate only one zero-sized array
4411 * typemanager.cs (LookupTypeReflection): Remove buggy code that
4412 purported to handle pointers.
4413 (char_ptr_type, void_ptr_type): Use GetPointerType rather than
4416 2005-07-15 Marek Safar <marek.safar@seznam.cz>
4418 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
4421 2005-07-15 Raja R Harinath <rharinath@novell.com>
4423 * namespace.cs (Namespace.Lookup): Drop location parameter.
4424 (NamespaceEntry.LookupAlias): Remove. Merge into ...
4425 (NamespaceEntry.Lookup): ... this.
4426 (NamespaceEntry.Error_AmbiguousTypeReference):
4427 Move here from DeclSpace.
4428 (NamespaceEntry.LookupNamespaceOrType): Move support for dotted
4430 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): ... here.
4431 * decl.cs (DeclSpace.ErrorAmbiguousTypeReference):
4432 Move to NamespaceEntry.
4433 * delegate.cs, expression.cs: Update to changes.
4435 2005-08-31 Martin Baulig <martin@ximian.com>
4437 Committing a patch from Atsushi Enomoto for #75850.
4439 * statement.cs (Foreach.CollectionForeach.GetEnumeratorFilter):
4440 Prefer a generic enumerator over a non-generic one.
4442 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
4444 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
4445 * gmcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
4447 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
4449 * driver.cs : reverting default encoding change as well as mcs.
4451 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
4453 * driver.cs, support.cs : merged r48826.
4455 > could you integrate your mcs changes to gmcs otherwise
4456 > gmcs cannot compile some files.
4458 2005-08-20 Martin Baulig <martin@ximian.com>
4460 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
4461 scope if we don't already have it.
4463 * expression.cs (Invocation.EmitCall): Use `ec.EmitThis ()' rather
4464 than `ig.Emit (OpCodes.Ldarg_0)' to make it work inside iterators;
4467 2005-07-31 Miguel de Icaza <miguel@novell.com>
4469 * statement.cs: Copy the local exception into the exception
4470 captured local. Fixes 75674
4472 2005-07-15 Marek Safar <marek.safar@seznam.cz>
4474 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
4477 2005-08-12 Martin Baulig <martin@ximian.com>
4479 * expression.cs (MemberAccess.ResolveNamespaceOrType): Only search
4480 for nested types here to avoid hitting the cache too early.
4482 2005-08-09 Miguel de Icaza <miguel@novell.com>
4484 * enum.cs: On the new compiler CLS error 3005 is now a warning not
4487 2005-08-03 Martin Baulig <martin@ximian.com>
4489 Make iterators in generic methods work; see gtest-191.cs.
4492 (Constraints.Resolve): Protect against being called twice.
4495 (TypeContainer.GetClassBases): Make this `protected virtual'.
4497 * iterator.cs (Iterator.ctor): Added `GenericMethod' argument.
4498 (Iterator.GetClassBases): Override this and compute the base
4500 (Iterator.DefineNestedTypes): If we're a generic method, all our
4501 method type parameters become class type parameters on the proxy
4505 (ToplevelBlock.Parameters): Make this a property, not a field.
4506 (ToplevelBlock.ResolveMeta): Update the `parameters' from the `ip'.
4508 2005-08-03 Martin Baulig <martin@ximian.com>
4510 * typemanager.cs (TypeManager.IsSubclassOf): Use
4511 `TypeManager.IsEqual' instead of `Type.Equals'; fixes gtest-190.cs.
4512 (TypeManager.GetFullName_recursed): Improved.
4514 2005-07-27 Carlos Alberto Cortez <calberto.cortez@gmail.com>
4517 * ecore.cs (Expression.IsAccessorAccessible): Change the check for
4518 Private accessor case, using TypeManager.IsPrivateAccessible instead of
4519 invocation_type == mi.DeclaringType, since the first one also checks
4520 other condition used by generic instances.
4522 2005-07-27 Martin Baulig <martin@ximian.com>
4524 * anonymous.cs (CaptureContext.AddField): Added
4525 `AnonymousContainer am' argument; compute its toplevel scope if
4526 it's not already computed. Fixes #75649.
4528 2005-07-14 Marek Safar <marek.safar@seznam.cz>
4530 * attribute.cs (Attribute.ResolveAttributeType): Renamed from
4531 CheckAttributeType and refactored.
4532 (Attribute.ResolvePossibleAttributeType): Changed to reuse
4533 ResolveAsTypeTerminal error handling.
4534 (ResolveAsTypeTerminal): Introduced because of global attributes extra
4536 (GetSignatureForError): Print errors in same way.
4539 * codegen.cs: Reflect attribute GetSignatureForError change.
4542 * expression.cs: Add silent parameter to ResolveAsTypeStep.
4544 * namespace.cs (UsingEntry): Refactored to make fields private.
4547 statement.cs: Error_UnexpectedKind has extra parameter.
4549 2005-07-14 Raja R Harinath <rharinath@novell.com>
4551 * ecore.cs (IAlias): Remove.
4552 * decl.cs (DeclSpace): Don't derive from IAlias. Remove members
4553 that implement the interface.
4554 * namespace.cs (Namespace): Likewise.
4555 (Namespace.declspaces): Renamed from 'defined_names'.
4556 (Namespace.AddDeclSpace): Renamed from 'DefineName'. Take a
4557 DeclSpace instead of an IAlias.
4558 * tree.cs (Tree.AddDecl): Update.
4560 2005-07-12 Raja R Harinath <rharinath@novell.com>
4562 * statement.cs (Block.Flags); Remove HasVarargs.
4563 (Block.HasVarargs): Move to ToplevelBlock.
4564 (Block.ThisVariable, Block.AddThisVariable): Likewise.
4565 (Block.Variables): Make protected. Initialize variable hashtable
4567 (Block.AddVariable): Update.
4568 (Block.Resolve): Update to changes.
4569 (ToplevelBlock.HasVarargs): New boolean.
4570 (ToplevelBlock.ThisVariable): Move here from Block.
4571 (ToplevelBlock.AddThisVariable): Likewise.
4572 (ToplevelBlock.IsThisAssigned): New. Forwards call to this_variable.
4573 * expression.cs (This.ResolveBase): Update to changes.
4574 (ArglistAccess.DoResolve): Likewise.
4576 2005-07-11 Marek Safar <marek.safar@seznam.cz>
4579 * ecore.cs, class.cs: Use SetAssigned instead of direct access.
4581 * class.cs (TypeContainer.VerifyMembers): Distinguish between
4582 not used and not used & assigned.
4583 (FieldBase.ASSIGNED): Moved to MemberCore.Flags.
4585 2005-07-11 Marek Safar <marek.safar@seznam.cz>
4588 * expression.cs (Is.DoResolve): null is never provided type.
4590 2005-07-08 Marek Safar <marek.safar@seznam.cz>
4593 * cs-parser.jay: Less strict event error rule to catch more errors.
4595 2005-07-11 Martin Baulig <martin@ximian.com>
4597 * generic.cs (ConstructedType.CheckConstraints): Improve the check
4598 for the constructor constraint: we do not only have to check
4599 whether the class has a public constructor, but also ensure that
4600 it's parameterless. Fixes #75492.
4602 2005-07-11 Martin Baulig <martin@ximian.com>
4604 * expression.cs (Binary.ResolveOperator): Only allow `==' and `!='
4605 between type parameters if they either have the reference type
4606 constraint or the class constraint.
4608 2005-07-10 Kamil Skalski <nazgul@nemerle.org>
4610 * generic.cs: Use MakeGenericType instead of BindGenericParameters.
4612 2005-07-07 Marek Safar <marek.safar@seznam.cz>
4615 * attribute.cs (orig_sec_assembly): Holds original version of assembly.
4616 (ExtractSecurityPermissionSet): Cope with self referencing security
4617 attributes properly.
4619 * driver.cs (SetOutputFile): Made public property OutputFile.
4621 2005-07-07 Raja R Harinath <rharinath@novell.com>
4624 * class.cs (TypeContainer.first_nonstatic_field): Rename from
4625 has_nonstatic_fields. Make into a FieldBase pointer.
4626 (TypeContainer.AddField): Add CS0282 check.
4627 (TypeContainer.EmitType): Update.
4629 2005-07-06 Miguel de Icaza <miguel@novell.com>
4631 * cs-tokenizer.cs (consume_identifier): Do not create strings to
4632 compare if they start with __.
4634 2005-07-06 Raja R Harinath <rharinath@novell.com>
4636 * statement.cs (Switch.SwitchGoverningType): Only look at
4637 UserCasts that don't need implicit standard conversions to one of
4638 the allowed switch types (Fixes test-322.cs).
4639 (LocalInfo.Resolve): Re-enable sanity-test.
4641 2005-07-06 Marek Safar <marek.safar@seznam.cz>
4643 * cs-tokenizer.cs (consume_identifier): Detect double undescores
4645 * ecore.cs (FieldExpr.AddressOf): Changed volatile error to warning.
4647 * expression.cs (Invocation.DoResolve): Report error CS0245 here.
4649 2005-07-06 Raja R Harinath <rharinath@novell.com>
4652 * ecore.cs (SimpleName.GetSignatureForError): Add.
4653 * expression.cs (MemberAccess.DoResolve): Don't clobber 'expr' field.
4654 (MemberAccess.GetSignatureForError): Add.
4656 2005-07-05 Marek Safar <marek.safar@seznam.cz>
4658 The big error and warning messages review.
4688 * typemanager.cs: Updated.
4690 * class.cs: (MethodCore.SetYields): Moved here to share.
4691 (PropertyMethod.Define): Moved iterator setup here.
4693 * iterators.cs: Add orig_method to have full access to parent
4696 2005-07-05 Raja R Harinath <rharinath@novell.com>
4698 Make 'fixed variable' handling standards compliant. Fix #70807, #72729.
4699 * ecore.cs (IVariable.VerifyFixed): Remove 'is_expression' parameter.
4700 (FieldExpr.VerifyFixed): Ensure that the field is part of a fixed
4701 variable of struct type.
4702 * expression.cs (Unary.ResolveOperator): Update to change.
4703 (Indirection.VerifyFixed): Likewise.
4704 (LocalVariableReference.VerifyFixed): A local variable is always fixed.
4705 (ParameterReference.VerifyFixed): Value parameters are fixed.
4706 (This.VerifyFixed): Treat 'this' as a value parameter.
4707 * statement.cs (LocalInfo.IsFixed): Remove.
4709 2005-07-01 Martin Baulig <martin@ximian.com>
4711 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
4712 `ec.EmitThis ()' to get the correct scope.
4714 2005-07-01 Martin Baulig <martin@ximian.com>
4716 * ecore.cs (FieldExpr.DoResolve): Don't capture the field if it's
4717 instance is a ParameterReference; fixes #75299.
4719 2005-06-30 Raja R Harinath <rharinath@novell.com>
4722 * expression.cs (Indexers.map): Remove.
4723 (Indexers.Append): Filter out inaccessible setters and getters.
4724 (IndexerAccess.DoResolve, IndexerAccess.DoResolveLValue): Update.
4727 * ecore.cs (MemberExpr.EmitInstance): New. Add CS0120 check.
4729 (FieldExpr.EmitInstance, PropertyExpr.EmitInstance): ... these.
4730 (FieldExpr.Emit, PropertyExpr.Emit): Update.
4731 (FieldExpr.EmitAssign, PropertyExpr.EmitAssign): Update.
4732 * expression.cs (Invocation.EmitCall): Add CS0120 check.
4734 2005-06-30 Marek Safar <marek.safar@seznam.cz>
4737 * class.cs (FieldBase.GetInitializerExpression): One more field
4740 2005-06-28 Miguel de Icaza <miguel@novell.com>
4742 * pending.cs: Do not define a proxy if the base method is virtual,
4743 it will be picked up by the runtime (bug 75270).
4745 2005-07-08 Martin Baulig <martin@ximian.com>
4747 * anonymous.cs (CaptureContext.EmitParameterInstance): Correctly
4748 handle parameters in nested scopes; fixes #74808; see gtest-188.cs.
4750 2005-07-07 Martin Baulig <martin@ximian.com>
4752 * generic.cs (ConstructedType.CheckConstraint): Use
4753 ResolveAsTypeStep(), not ResolveAsTypeTerminal() so we're not
4754 called recursively; fixes #75329.
4756 2005-07-06 Martin Baulig <martin@ximian.com>
4758 * generic.cs (TypeManager.InferTypeArguments): Added support for
4759 anonymous methods; fixes #75461.
4761 2005-07-01 Martin Baulig <martin@ximian.com>
4763 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
4764 `ec.EmitThis ()' to get the correct scope.
4766 2005-07-01 Martin Baulig <martin@ximian.com>
4768 * ecore.cs (FieldExpr.DoResolve): Only capture the field if it's
4769 instance is `This'; fixes #75299.
4771 2005-06-30 Martin Baulig <martin@ximian.com>
4773 * class.cs (Indexer): Implement IIteratorContainer; added support
4774 for iterators in indexers.
4777 (EmitContext.CurrentIterator): Make this a property, not a field.
4779 * anonymous.cs (AnonymousContainer.Iterator): New public property.
4781 2005-06-28 Miguel de Icaza <miguel@novell.com>
4783 * pending.cs: Do not define a proxy if the base method is virtual,
4784 it will be picked up by the runtime (bug 75270).
4786 2005-06-28 Martin Baulig <martin@ximian.com>
4788 * cs-parser.jay (interface_method_declaration): Avoid a
4789 reduce/reduce conflict by moving some of the code into a separate
4790 `interface_method_declaration_body' rule; fixes #75368.
4792 2005-06-28 Martin Baulig <martin@ximian.com>
4794 * typemanager.cs (TypeManager.MemberLookup_FindMembers): Move the
4795 array check after the check for TypeBuilder's.
4797 2005-06-21 Raja R Harinath <rharinath@novell.com>
4799 * convert.cs (FindMostEncompassedType): Add two trivial special
4800 cases (number_of_types == 0 || number_of_types == 1).
4801 (FindMostEncompasingType): Likewise.
4803 2005-06-17 Raja R Harinath <rharinath@novell.com>
4805 Some cleanups preparing for the fix of #75283.
4806 * ecore.cs (PropertyExpr.InstanceResolve): Tighten conditions for
4808 (EventExpr.InstanceResolve): Likewise.
4809 (EventExpr.DoResolve): Remove redundant checks.
4811 2005-06-08 Miguel de Icaza <miguel@novell.com>
4813 * class.cs: Small fix.
4815 2005-06-08 Raja R Harinath <rharinath@novell.com>
4818 * class.cs (GetPartialBases): Fix return value check of
4821 2005-06-07 Raja R Harinath <rharinath@novell.com>
4823 Ensure that partial classes are registered in their enclosing
4824 namespace. Initial part of fix of #75160.
4825 * tree.cs (Tree.RecordDecl): Add new namespace argument.
4826 Register declspace with namespace here, not in
4827 DeclSpace.RecordDecl.
4828 * cs-parser.jay: Pass namespace to RecordDecl.
4829 * class.cs (PartialContainer.Create): Likewise.
4830 (ClassPart.DefineType): New sanity-check. Throws an exception if
4832 * decl.cs (Declspace.RecordDecl): Remove.
4833 * namespace.cs (NamespaceEntry.DefineName): Remove.
4835 2005-06-06 Marek Safar <marek.safar@seznam.cz>
4837 * rootcontext.cs: Reset TargetExt as well.
4839 2005-06-03 Raja R Harinath <rharinath@novell.com>
4841 * ecore.cs (Expression.Resolve): Emit CS0654 error when
4844 2005-06-02 Raja R Harinath <rharinath@novell.com>
4846 Fix #75080, cs0119.cs.
4847 * ecore.cs (Expression.ExprClassToResolveFlags): New. Broken out
4849 (Expression.Resolve): ... this. Use it. Remove bogus code
4850 allowing ExprClass.Type and ExprClass.Namespace for
4851 ResolveFlags.VariableOrValue.
4852 (Expression.Resolve) [1-argument variant]: Change default resolve
4853 flags based on language version.
4854 (Expression.Error_UnexpectedKind): Use a simple string array
4855 rather than an ArrayList.
4856 * expression.cs (TypeOf.DoResolve): Set eclass to ExprClass.Value,
4858 (TypeOfVoid.DoResolve): Likewise.
4859 (MemberAccess.DoResolve) [3-argument variant]: Make private. Drop
4860 flags argument -- it always has the same value.
4862 2005-05-31 Raja R Harinath <rharinath@novell.com>
4865 * ecore.cs (Expression.ResolveLValue): Add a Location parameter.
4866 Use it in the error message.
4867 * assign.cs, expression.cs, statement.cs: Update.
4869 2005-05-30 Raja R Harinath <rharinath@novell.com>
4872 * ecore.cs (Expression.MemberLookupFailed): Add CS0122 check in
4873 the "almostMatchedMember" case too.
4874 * typemanager.cs (Closure.CheckValidFamilyAccess): Add anything
4875 that failed the accessibility checks to 'almost_match'.
4877 2005-05-27 Vladimir Vukicevic <vladimir@pobox.com>
4879 * attribute.cs: Use internal MethodBuilder methods to set
4880 ExactSpelling and SetLastError on PInvoke methods, instead
4881 of passing them via charset. Fixes #75060.
4883 2005-05-27 Raja R Harinath <rharinath@novell.com>
4885 * parameter.cs (Parameter): Remove TODO comment.
4886 (Parameter.DefineParameter): Remove Location parameter.
4887 (Parameters.LabelParameters): Likewise.
4888 * class.cs (Constructor.Emit): Update to change.
4889 (MethodData.Emit): Likewise.
4890 * anonymous.cs (AnonymousMethod.EmitMethod): Likewise.
4891 * delegate.cs (Delegate.Define, Delegate.Emit): Likewise.
4893 2005-05-27 Atsushi Enomoto <atsushi@ximian.com>
4896 Removed Parameters.Location and added Parameter.Location instead.
4897 Removed Location parameter from Emit() and GetSignature().
4904 Modified all related calls.
4906 2005-06-21 Martin Baulig <martin@ximian.com>
4908 * generic.cs (NullCoalescingOperator.Emit): Make this work if the
4909 left-hand side is not a nullable type; fixes #75328.
4911 2005-06-21 Martin Baulig <martin@ximian.com>
4914 (TypeManager.CSharpName): Use GetFullName() instead of `t.FullName'.
4915 (TypeManager.GetFullNameSignature): Likewise.
4917 * convert.cs (Convert.Error_CannotImplicitConversion): Compare
4918 `source.FullName' and `target.FullName' to check whether there are
4919 two conflicting definitions.
4921 2005-06-21 Martin Baulig <martin@ximian.com>
4923 * convert.cs (Convert.ImplicitTypeParameterConversion): Always use
4924 a BoxedCast - also for reference types - to be compatible with csc.
4926 2005-06-21 Martin Baulig <martin@ximian.com>
4928 * expression.cs (MemberAccess.DoResolve): Add support for nested
4929 types in a generic instance; fixes #75320.
4931 2005-06-20 Martin Baulig <martin@ximian.com>
4933 * generic.cs (TypeManager.InferType): Also walk the class
4934 hierarchy for generic instances; fixes #75261.
4936 2005-06-17 Martin Baulig <martin@ximian.com>
4938 * typemanager.cs (TypeManager.IsBuiltinType): Use TypeToCoreType()
4939 to make things work for corlib.
4941 2005-06-15 Martin Baulig <martin@ximian.com>
4943 * attribute.cs (Attribute.CheckSecurityActionValidity): Remove the
4944 obsolete `SecurityAction' values.
4946 2005-06-06 Marek Safar <marek.safar@seznam.cz>
4948 * rootcontext.cs: Reset TargetExt as well.
4950 2005-06-09 Martin Baulig <martin@ximian.com>
4952 * delegate.cs (Delegate.VerifyMethod): Added
4953 `MethodGroupExpr old_mg' argument; inherit its
4954 `HasTypeParameters'; fix #75085.
4956 2005-06-09 Martin Baulig <martin@ximian.com>
4958 * expression.cs (Invocation.OverloadResolve): Correctly handle
4959 generic methods for the SetMemberIsUsed(); fix #75064.
4961 2005-06-09 Martin Baulig <martin@ximian.com>
4963 * statement.cs (Throw.Resolve): Use TypeManager.IsSubclassOf();
4966 2005-06-08 Martin Baulig <martin@ximian.com>
4968 * cs-parser.jay (nullable_type_or_conditional): If we put the
4969 nullable back and our `type' is a `ComposedCast', remove the
4970 nullable from it. Fixes #75156.
4972 * expression.cs (ComposedCast.RemoveNullable): New public method.
4974 2005-06-08 Martin Baulig <martin@ximian.com>
4976 The big Iterators rewrite :-)
4978 * iterators.cs: Rewrite this to use the anonymous methods framework.
4980 * rootcontext.cs (RootContext.DefineTypes): Define Delegates
4981 before the TypeContainers; see 2test-21.cs.
4984 (TypeContainer.DefineType): Don't create a new EmitContext if we
4985 already have one (this only happens if we're an Iterator).
4986 (TypeContainer.Define): Also call Define() on all our iterators.
4987 (Method.CreateEmitContext): Added support for iterators.
4990 (AnonymousContainer): New abstract base class for `AnonymousMethod'.
4991 (AnonymousContainer.CreateMethodHost): Moved here from
4992 AnonymousMethod and made abstract.
4993 (AnonymousContainer.CreateScopeType): New abstract method.
4994 (AnonymousContainer.IsIterator): New public property.
4995 (ScopeInfo.EmitScopeType): Call CreateScopeType() on our Host to
4996 get the ScopeTypeBuilder rather than manually defining it here.
4997 (ScopeInfo.EmitScopeInstance): New public method; correctly handle
5000 * driver.cs (Driver.MainDriver): Call TypeManager.InitCodeHelpers()
5001 before RootContext.DefineTypes().
5003 * codegen.cs (EmitContext.RemapToProxy): Removed.
5004 (EmitContext.CurrentAnonymousMethod): Changed type from
5005 AnonymousMethod -> AnonymousContainer.
5006 (EmitContext.ResolveTopBlock): Protect from being called twice.
5007 (EmitContext.MapVariable, RemapParameter(LValue)): Removed.
5008 (EmitContext.EmitThis): Removed the iterators hacks; use the
5009 anonymous methods framework for that.
5012 (ToplevelBlock.Container): Make this a property, not a field.
5013 (ToplevelBlock.ReParent): New public method; move the
5014 ToplevelBlock into a new container.
5015 (Foreach.TemporaryVariable): Simplify.
5017 2005-06-05 Martin Baulig <martin@ximian.com>
5019 * statement.cs (LocalInfo.CompilerGenerated): New flag.
5020 (Block.AddTemporaryVariable): New public method; creates a new
5021 `LocalInfo' for a temporary variable.
5022 (Block.EmitMeta): Create the LocalBuilders for all the temporary
5024 (Foreach.TemporaryVariable): Use Block.AddTemporaryVariable() for
5025 non-iterator variables.
5027 2005-06-05 Martin Baulig <martin@ximian.com>
5029 * statement.cs (Foreach.TemporaryVariable): Create the
5030 LocalBuilder in the Emit phase and not in Resolve since in some
5031 situations, we don't have an ILGenerator during Resolve; see
5032 2test-19.cs for an example.
5034 2005-06-04 Martin Baulig <martin@ximian.com>
5036 The big Foreach rewrite - Part II.
5038 * typemanager.cs (TypeManager.object_getcurrent_void): Replaced
5039 with `PropertyInfo ienumerator_getcurrent'.
5041 * codegen.cs (VariableStorage): Removed.
5044 (Foreach): Derive from Statement, not ExceptionStatement.
5045 (Foreach.CollectionForeach): New nested class. Moved all the code
5046 dealing with collection foreach here.
5047 (Foreach.ForeachHelperMethods): Removed.
5048 (Foreach.TemporaryVariable): Implement IMemoryLocation.
5050 2005-05-23 Martin Baulig <martin@ximian.com>
5052 * statement.cs (Try.DoResolve): Don't create a `finally' if we
5053 don't need to. Fix #75014.
5055 2005-05-26 Raja R Harinath <rharinath@novell.com>
5057 Improve user-defined conversion handling.
5058 * convert.cs (GetConversionOperators): Rewrite. Return only the
5059 applicable operators.
5060 (AddConversionOperators): New. Helper for GetConversionOperators.
5061 (FindMostEncompassedType, FindMostEncompassingType): Verify that
5062 there is only one most encompassed/encompassing type.
5063 (FindMostSpecificSource, FindMostSpecificTarget): Remove
5064 "applicable operator" handling.
5065 (UserConversion): Move cache here from GetConversionOperators.
5066 Directly cache the chosen operator, rather than the whole
5068 (ExplicitNumericConversion): Fix buggy implementation of Decimal
5069 case. Allow conversion of decimal to sbyte and byte too.
5070 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
5071 New static methods. Used to avoid allocating EmptyExpressions in
5074 2005-05-24 Duncan Mak <duncan@novell.com>
5076 * ecore.cs (CastFromDecimal): New class for casting a decimal to
5077 another class, used in Convert.ExplicitNumericConversion.
5078 (CastToDecimal): New class, similar to above, but casts to
5079 System.Decimal, used in Convert.ImplicitNumericConversion and also
5080 in explicit convesion from double/float to decimal.
5082 * convert.cs (ImplicitNumericConversion): Handle implicit
5083 conversions to System.Decimal.
5084 (ExplicitNumericConversion): handle explicit conversions to
5089 2005-05-20 Miguel de Icaza <miguel@novell.com>
5091 * typemanager.cs: Do not throw an exception in the TypeBuilder
5092 case, we take care of it on the TypeCode.
5094 2005-05-17 Marek Safar <marek.safar@seznam.cz>
5096 * attribute.cs (Attribute.ResolveArguments): GuidAttribute check
5099 * cs-parser.jay: Catch more lexical errors.
5101 * report.cs: Add one more Error method.
5104 * typemanager.cs: Register System.Runtime.InteropServices.GuidAttribute
5106 2005-05-20 Martin Baulig <martin@ximian.com>
5108 * class.cs (TypeContainer.CircularDepException): Removed.
5109 (TypeContainer.DefineType): Removed the `InTransit' stuff.
5110 (TypeContainer.CheckRecursiveDefinition): Check for circular class
5111 (CS0146) and interface (CS0529) dependencies here.
5113 2005-05-20 Martin Baulig <martin@ximian.com>
5115 * expression.cs (New.DoResolve): Move the CS0712 check above the
5116 CS0144 check; otherwise it can never be reached.
5118 2005-05-20 Martin Baulig <martin@ximian.com>
5120 * cs-parser.jay: Fix CS0080 check; add CS0231 and CS0257 from MCS.
5122 2005-05-20 Martin Baulig <martin@ximian.com>
5124 * class.cs (TypeContainer.DefineType): Fix CS0698 check.
5126 * typemanager.cs (TypeManager.IsAttributeType): New public method.
5128 2005-05-19 Martin Baulig <martin@ximian.com>
5131 (ImplicitDelegateCreation.Check): Added `bool check_only' argument
5132 to disable error reporting.
5134 * convert.cs (Convert.ImplicitStandardConversionExists): Use it
5135 here since we don't want to report an error; see the new test-336.cs.
5137 2005-05-19 Raja R Harinath <rharinath@novell.com>
5139 * statement.cs (ToplevelBlock.GetParameterReference)
5140 (ToplevelBlock.IsParameterReference,ToplevelBlock.IsLocalParameter):
5141 Move here from class Block.
5142 * ecore.cs (SimpleName.SimpleNameResolve): Update to changes.
5143 * expression.cs (ParameterReference.DoResolveBase): Likewise.
5145 2005-05-18 Martin Baulig <martin@ximian.com>
5150 (FlowBranching.Reachability): Add non-static public And() and Or()
5152 (FlowBranchingSwitch): New class; do the `break_origins' thing
5153 like in FlowBranchingLoop.
5154 (FlowBranching.UsageVector.MergeBreakOrigins): Also merge the
5155 reachability, not just locals and parameters.
5156 (FlowBranching.MergeChild): Remove some of the hacks for loop and
5157 switch; MergeBreakOrigins() now takes care of that.
5159 2005-05-18 Martin Baulig <martin@ximian.com>
5161 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
5162 a loop and may leave it, reset the barrier; fixes #74974.
5164 2005-05-16 Raja R Harinath <rharinath@novell.com>
5166 Fix test-382.cs. Emit values of decimal constants.
5167 * class.cs (TypeContainer.RegisterFieldForInitialization): New.
5169 (TypeContainer.AddField): ... this.
5170 (TypeContainer.EmitFieldInitializers): Allow the list of fields
5171 with initializers to include 'Const's.
5172 (ClassPart.RegisterFieldForInitialization): Forward to
5174 * const.cs (Const.Const): Pass initializer to base class.
5175 (Const.Define): In case of decimal constants, register them for
5176 initialization in a static constructor.
5178 2005-05-14 Martin Baulig <martin@ximian.com>
5180 * statement.cs (Block.Resolve): Correctly handle unreachable code;
5181 do not call ResolveUnreachable() on unreachable statements in
5182 here, see the comment in the source code.
5184 2005-05-13 Raja R Harinath <rharinath@novell.com>
5187 * expression.cs (BinaryResolveOperator): If one of the operands of
5188 an equality comparison is 'null' and the other is a pointer type,
5189 convert the null to a NullPointer.
5190 * convert.cs (ImplicitReferenceConversion): If the expression is a
5191 NullLiteral and the target type is a pointer type, return a
5192 NullPointer instead.
5193 (ImplicitConversionStandard): Likewise.
5195 2005-05-13 Marek Safar <marek.safar@seznam.cz>
5197 * cs-parser.jay: Set readonly context based on special constructs.
5199 * expression.cs (LocalVariableReference.DoResolveBase): Improved
5200 readonly variable error handling.
5202 * rootcontext.cs (EmitCode): Don't verify members when error
5205 * statement.cs (LocalInfo): Add reaodnly context information.
5206 (SetReadOnlyContext, GetReadOnlyContext): New methods.
5208 2005-05-17 Martin Baulig <martin@ximian.com>
5210 * expression.cs (Argument.Resolve): Turn on flow analysis; fix
5213 2005-05-13 Martin Baulig <martin@ximian.com>
5215 * statement.cs (Block.Resolve, ResolveUnreachable): Correctly
5216 handle unreachable blocks.
5218 2005-05-13 Martin Baulig <martin@ximian.com>
5221 (ConstructorInitializer.GetOverloadedConstructor): Don't crash.
5222 (MethodCore.CheckCore): Use TypeManager.IsEqual(); fix #74904 and
5225 2005-05-13 Martin Baulig <martin@ximian.com>
5227 * statement.cs (Block.Resolve): Make the `bool unresolved' flag an
5228 instance variable, not a local. Fix #74873.
5229 (Block.ResolveUnreachable): Set it to true here.
5231 2005-05-12 Martin Baulig <martin@ximian.com>
5233 * cs-parser.jay (property_declaration): Pass the `current_class',
5234 not the `current_container' to Property's .ctor. Fixes #74912.
5236 2005-05-11 Martin Baulig <martin@ximian.com>
5238 * typemanager.cs (Closure): Copy this from MCS and merge all the
5239 GMCS-specific changes into it.
5241 2005-05-12 Raja R Harinath <harinath@gmail.com>
5244 * typemanager.cs (unmanaged_enclosing_types): New.
5245 (IsUnmanagedType): Avoid infloops by using
5246 'unmanaged_enclosing_types' to talk with recursive invocations.
5248 2005-05-11 Duncan Mak <duncan@novell.com>
5250 * cs-tokenizer.cs (get_cmd_arg): Check that 'c' is not -1 before
5251 continuing to process for 'arg'.
5252 (handle_preprocessing_directive): Check the argument of the #endif
5253 directive and report error CS1025 if there are any trailing
5256 According to the C# spec, having even whitespace after the #endif
5257 directive is illegal; however, because we call arg.TrimEnd ()
5258 beforehand, we have the same behavior as csc, allowing whitespace
5259 after the directive.
5263 2005-05-11 Marek Safar <marek.safar@seznam.cz>
5267 * class.cs (ConstructorInitializer.GetOverloadedConstructor): Removed.
5268 (Constructor.GetObsoleteAttribute): Implemented correctly.
5270 2005-05-10 Martin Baulig <martin@ximian.com>
5272 * generic.cs (Constraints.Resolve): Report CS0246 if we cannot
5273 resolve the type; fixes #74864.
5274 (DefaultValueExpression): Create the LocalTemporary in Emit(), not
5275 in DoResolve(); fixes #74862.
5277 2005-05-10 Martin Baulig <martin@ximian.com>
5279 * support.cs (ReflectionParameters.ParameterModifier): Use
5280 `Parameter.Modifier.REF' if we both have `ParameterAttributes.Out'
5281 and `ParameterAttributes.In'. Fixes #74884.
5283 2005-05-10 Martin Baulig <martin@ximian.com>
5285 * typemanager.cs (TypeManager.MemberLookup_FindMembers): Don't use
5286 the cache if we're just looking for `MemberTypes.NestedType' in a
5289 * ecore.cs (Expression.ResolveAsTypeTerminal): Don't check the
5290 constraints if we're still resolving the type tree.
5291 (Expression.MemberLookup): If we're resolving the type tree, only
5292 look for `MemberTypes.NestedType' since we're only interested in
5295 * class.cs (TypeContainer.DefineType): Don't resolve the type
5296 parameters here; do this later in ResolveType() after the type
5297 tree has been resolved.
5298 (TypeContainer.ResolveType): New public method; this is called
5299 after the type tree is resolved and before the types are being
5300 populated. We resolve the generic constraints here.
5301 (TypeContainer.DoDefineMember): Check the constraints on our base
5302 class and interfaces.
5304 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Make this protected;
5305 set the `ResolvingTypeTree' flag on the EmitContext.
5307 * codegen.cs (EmitContext.ResolvingTypeTree): New public field.
5309 2005-05-10 Marek Safar <marek.safar@seznam.cz>
5311 * class.cs (Method.Define): Catch attempt for Finalizer declaration.
5313 * expression.cs (Argument.GetParameterModifier): Turned to property.
5314 (Invocation.Error_InvalidArguments): Add more descriptive errors.
5316 * parameter.cs (Parameter.GetModifierSignature): Translates modifier to
5319 2005-05-09 Raja R Harinath <rharinath@novell.com>
5322 * decl.cs (MemberCache.AddMethods): Register override methods,
5323 rather than non-override methods.
5324 * typemanager.cs (RegisterOverride): New.
5325 (IsOverride): Update.
5327 2005-05-09 Marek Safar <marek.safar@seznam.cz>
5329 * typemanager.cs (TypeManager): Moved InitGenerics to Reset method.
5331 2005-05-06 Martin Baulig <martin@ximian.com>
5334 (Attributable.IsClsComplianceRequired): Fix typo in the method name.
5335 (AttributeTester.AnalyzeTypeCompliance): Add generics support.
5337 2005-05-09 Marek Safar <marek.safar@seznam.cz>
5341 * ecore.cs (SimpleName.SimpleNameResolve): Add in_transit to catch
5342 recursive declaration.
5344 * statement.cs (Block.ResolveMeta): Report any error in resolving.
5346 2005-05-06 Marek Safar <marek.safar@seznam.cz>
5348 * cfold (DoConstantNumericPromotions): Don't try to convert 0 enum.
5350 * expression.cs (Binary.DoResolve): (x && 0) is always 0.
5352 2005-05-05 Raja R Harinath <rharinath@novell.com>
5355 * decl.cs (DeclSpace.FamilyAccessible):
5356 Use TypeManager.IsNestedFamilyAccessible.
5358 Fix reopened #64812.
5359 * typemanager.cs (Closure.Filter): Introduce checks for 'protected
5362 2005-05-04 Raja R Harinath <rharinath@novell.com>
5363 Abin Thomas <projectmonokochi@rediffmail.com>
5364 Anoob V E <projectmonokochi@rediffmail.com>
5365 Harilal P R <projectmonokochi@rediffmail.com>
5368 * typemanager.cs (Closure.CheckValidFamilyAccess): Don't blindly
5369 allow access to all static members.
5371 2005-05-04 Martin Baulig <martin@ximian.com>
5373 * ecore.cs (FieldExpr.DoResolveLValue): Always call fb.SetAssigned().
5375 2005-05-04 Martin Baulig <martin@ximian.com>
5379 * statement.cs (Switch.SimpleSwitchEmit): Always emit the default
5380 section at the end; make things work if `default' is not the last
5383 2005-05-04 Martin Baulig <martin@ximian.com>
5387 * statement.cs (Switch): Replaced the `got_default' field with a
5388 `default_section' one.
5389 (Switch.CheckSwitch): Set `default_section' here.
5390 (Switch.Resolve): If we're a constant switch and the constant is
5391 not found, use the default section.
5393 2005-05-03 Martin Baulig <martin@ximian.com>
5395 * expression.cs (ArrayAccess.EmitGetLength): New public method.
5397 * statement.cs (Foreach.ArrayForeach): New nested class.
5398 (Foreach.TemporaryVariable): New nested class.
5399 (Foreach.EmitArrayForeach): Removed; this is now in the new
5402 2005-05-03 Raja R Harinath <rharinath@novell.com>
5404 * pending.cs (BaseImplements): Move the #74773 fix here. This is
5406 (VerifyPendingMethods): Revert change below.
5408 * typemanager.cs (IsOverride, RegisterNonOverride): New.
5409 * decl.cs (MemberCache.AddMethod): Register "non-override" methods
5410 that used to trigger warning -28. Remove warning -28.
5411 * expression.cs (Invocation.OverloadResolve): Use
5412 TypeManager.IsOverride to distinguish override methods.
5415 * pending.cs (VerifyPendingMethods): If a base type implements the
5416 requested interface, don't bother checking individual methods of
5417 the base type. As a side-effect, this prevents the creation of
5418 unnecessary proxies.
5420 2005-05-02 Martin Baulig <martin@ximian.com>
5424 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
5425 Also `And' the locals if the old vector is null.
5426 (FlowBranching.UsageVector.BitVector.And): Allow `vector' being
5427 null; in this case we basically reset all the variables.
5429 2005-05-02 Martin Baulig <martin@ximian.com>
5433 * flowanalysis.cs (FlowBranching.UsageVector.MergeBreakOrigins):
5434 Added `FlowBranching branching' argument; always `and' the
5435 variables instead of `or'ing them unless we're an infinite loop.
5437 * statement.cs (While.Resolve): Create a new sibling unless we're
5440 2005-05-02 Martin Baulig <martin@ximian.com>
5444 * class.cs (ConstructorInitializer.Resolve): Added `Block block'
5445 arguments; use it instead of creating a new TopLevelBlock.
5446 (Constructor.Emit): Call `block.ResolveMeta ()' before resolving
5447 our ConstructorInitializer.
5450 (TopLevelBlock.TopLevelBranching): New public property.
5451 (TopLevelBlock.ResolveMeta): New public method; call ResolveMeta()
5452 and create our `TopLevelBranching'.
5454 * codegen.cs (EmitContext.ResolveTopBlock): If we're not an
5455 anonymous method host, use `block.TopLevelBranching' rather than
5456 creating a new branching.
5458 2005-04-20 Miguel de Icaza <miguel@novell.com>
5460 * anonymous.cs (ScopeInfo.AddChild): when adding a new child to
5461 a ScopeInfo, if any of the current children is a child of the new
5462 entry, move those children there.
5464 2005-04-30 Martin Baulig <martin@ximian.com>
5466 * statement.cs (Switch.SimpleSwitchEmit): Reset `default_at_end'
5467 at the beginning of a SwitchSection. Fix #73335.
5469 2005-04-27 Marek Safar <marek.safar@seznam.cz>
5472 * class.cs (EmitFieldInitializers): Use FieldExpr in initializer.
5474 * ecore.cs (FieldExpr): Add a new ctor with in_initializer.
5475 (FieldExpr.DoResolve): Obsolete members are ignored for field
5478 2005-04-26 Marek Safar <marek.safar@seznam.cz>
5480 * attribute.cs (AreOverloadedMethodParamsClsCompliant): Add array
5481 of arrays detection.
5483 * class.cs (Interface.VerifyClsCompliance): Add base interfaces
5485 (Field.VerifyClsCompliance): Volatile fields are not compliant.
5487 * decl.cs (MemberCache.VerifyClsParameterConflict): Add array of
5490 2005-04-25 Ben Maurer <bmaurer@ximian.com>
5492 * cs-parser.jay: Use the prefered version of -unsafe in error
5495 2005-04-22 Marek Safar <marek.safar@seznam.cz>
5497 * driver.cs (CompilerCallableEntryPoint.Invoke): Reset under any
5500 2005-04-20 John Luke <john.luke@gmail.com>
5502 * driver.cs: fix typo in error message, --outout to --output
5504 2005-04-30 Martin Baulig <martin@ximian.com>
5506 * attribute.cs (Attribute.CheckSecurityActionValidity): Correctly
5507 handle the .NET 2.x security attributes.
5509 2005-04-30 Martin Baulig <martin@ximian.com>
5512 (TypeManager.ExpandInterfaces): Don't add things twice.
5515 (TypeContainer.VerifyClsCompliance): Allow generic instances.
5517 2005-04-29 Martin Baulig <martin@ximian.com>
5519 * generic.cs (Constraints.ResolveTypes): Expand interfaces.
5521 * anonymous.cs: Added support for anonymous generic methods.
5523 2005-04-29 Martin Baulig <martin@ximian.com>
5525 * typemanager.cs (TypeManager.GetInterfaces): Correctly handle
5528 2005-04-29 Martin Baulig <martin@ximian.com>
5530 * generic.cs (TypeManager.HasConstructorConstraint): Removed.
5532 * expression.cs (New.DoResolve): Fix the CS0304 check.
5534 2005-04-29 Martin Baulig <martin@ximian.com>
5536 * typemanager.cs (TypeManager.GetFullName): Updated to the new
5539 * class.cs (MethodCore.IsDuplicateImplementation): If we're an
5540 explicit interface implementation, compare the interface types.
5541 (MethodData.Define): Use the new naming scheme from the latest
5543 (MemberBase.DoDefineBase): Resolve `InterfaceType' here.
5545 * decl.cs (MemberName.GetMemberName): Removed.
5546 (MemberName.MethodName, FullName): New properties.
5548 2005-04-25 Raja R Harinath <rharinath@novell.com>
5550 * gmcs.exe.config: Update v2.0.40607 -> v2.0.50215.
5552 2005-04-22 Martin Baulig <martin@ximian.com>
5554 * generic.cs (GenericMethod): Create the EmitContext in the
5555 `Define()'; in `Define(MethodBuilder)', create the type parameters
5556 before calling `Define()'. Fixes #73933.
5558 2005-04-22 Martin Baulig <martin@ximian.com>
5561 (Constraints.Resolve): Make things work wrt. the new type lookup system.
5562 (ConstructedType.ResolveAsTypeTerminal): Don't override this.
5564 * ecore.cs (Expression.ResolveAsTypeTerminal): If `te' is a
5565 ConstructedType, check its constraints.
5567 2005-04-20 Marek Safar <marek.safar@seznam.cz>
5569 * codegen.cs (InRefOutArgumentResolving): New field.
5571 * ecore.cs (FieldExpr.DoResolve): Check for assigning to readonly
5572 fields outside contructor.
5574 * expression.cs (Argument.Resolve): Set InRefOutArgumentResolving.
5576 2005-04-19 Miguel de Icaza <miguel@novell.com>
5578 * anonymous.cs (CaptureContext.EmitParameterInstance): The
5579 parameter code was not completed ever, so it was not as up-to-date
5580 as local variables. Must finish it.
5582 The bug fix was to compare the Toplevel of the block, not the
5583 current block. Thanks for Ben for pointing this out.
5585 2005-04-19 Raja R Harinath <rharinath@novell.com>
5587 * decl.cs (AddMethods): Use the declaring type of the problem
5588 method to determine if we want to squash a warning.
5590 2005-04-19 Marek Safar <marek.safar@seznam.cz>
5592 * attribute.cs: Removed debug output.
5594 * decl.cs (MemberCache.AddMethods): Fixed Finalize ignoring.
5596 * driver.cs (Driver.parse): Synchronize parser ErrorOutput with
5599 2005-04-18 Raja R Harinath <rharinath@novell.com>
5602 * expression.cs (Binary.EqualsNullIsReferenceEquals): New.
5603 (Binary.DoResolveOperator): Use it to avoid blindly optimizing out
5604 all null comparisons against reference types.
5606 2005-04-18 Marek Safar <marek.safar@seznam.cz>
5609 * class.cs (TypeContainer.CircularDepException) New nested
5611 (GetPartialBases, GetNormalBases, GetClassBases): Removed error.
5612 (TypeContainer.DefineType): Removed error, reset InTransit before
5614 (Class.DefineType): Throw exception when is in Transit.
5615 Catch exception and report error.
5616 (Struct.DefineType): Throw exception when is in Transit.
5617 Catch exception and report error.
5618 (Interface.DefineType): Throw exception when is in Transit.
5619 Catch exception and report error.
5621 * codegen.cs: Add InCatch,InFinally to EmitContext to easily
5622 handle nested exception handlers.
5624 * flowanalysis.cs (InTryWithCatch): New method, search for try with
5627 * iterators.cs (Yield.CheckContext): Add CS1626 report. Updated
5628 InFinally and InCatch storage.
5630 * statement.cs (Throw.Resolve): Use InCatch, InFinally from ec.
5631 (Catch.Resolve): Set and Restore ec.InCatch.
5632 (Try.Resolve): Set and Restore ec.InFinally.
5633 (Try.HasCatch): True when try has catch.
5635 2005-04-17 Atsushi Enomoto <atsushi@ximian.com>
5637 * doc.cs : In some cases FilterName returns MonoEvent and MonoField
5638 for the same event member, so exclude such cases from warning 419.
5641 2005-04-16 Miguel de Icaza <miguel@novell.com>
5643 * expression.cs (Binary.ResolveOperator): Apply patch from John
5644 Luke to fix bug 59864: operators &, | and ^ on enumerations
5645 require that the same enum type on both sides.
5647 * driver.cs: Add warnings to old flag usage, this is to assist
5648 people who produce Makefiles and hope that the Makefiles will be
5651 * class.cs (TypeContainer.EmitType): Moved the definition of the
5652 special $PRIVATE$ field from the resolve phase to the Emit phase.
5653 During resolve we do not know if we are a struct with
5654 HasExplicitLayout, we know this only after the attributes for the
5657 Set the FieldOffset to zero on the dummy field that we create for
5658 the class. Fixes 74590.
5660 2005-04-16 Raja R Harinath <rharinath@novell.com>
5663 * ecore.cs (PropertyExpr.resolved): New.
5664 (DoResolve): Use it to handle a case of double resolution here.
5665 Handle a case of identical-name-and-type-name.
5666 * expression.cs (ArrayCreation.CheckIndices): Avoid double
5667 resolution by storing the results of expression resolution back
5668 into the "probes" array.
5670 2005-04-15 Raja R Harinath <rharinath@novell.com>
5672 Fix cs0208-7.cs and cs0208-8.cs.
5673 * typemanager.cs (IsUnmanagedType): Arrays are not allowed
5674 (cf. ECMA standard, behaviour of CSC 1.1 and CSC 2.0). Improve
5675 error reporting to point out the reason a struct is not unmanaged.
5677 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
5679 * doc.cs : In FindDocumentedType(), avoid TypeExpr.ResolveType() and
5680 just use TypeExpr.Type. This fixes bug #74595 when merged to gmcs.
5682 2005-04-13 Raja R Harinath <rharinath@novell.com>
5685 * ecore.cs (PropertyExpr.InstanceResolve): Handle a case of
5686 IdenticalNameAndTypeName here.
5687 (EventExpr.InstanceResolve): Likewise.
5689 2005-04-13 Marek Safar <marek.safar@seznam.cz>
5691 C# 2.0 DefaultCharSetAttribute implementation
5693 * attribute.cs (Attribute.ResolveAsTypeStep): New protected method
5694 which allows us to set GlobalNamespace for every resolve.
5695 (Attribute.ResolveArguments): Cut from Resolve.
5696 (Attribute.GetCharSetValue): Returns CharSet named argument.
5697 (Attribute.DefinePInvokeMethod): Gets default charset from
5699 (GlobalAttribute.ResolveAsTypeStep): Override.
5700 (GlobalAttribute.ResolveArguments): Override.
5702 * class.cs (TypeAttr): Is protected.
5704 * codegen.cs (ModuleClass.DefaultCharSet): New member.
5705 (ModuleClass.DefaultCharSetType): New memeber.
5706 (ModuleClass.ResolveAttributes): Resolves DefaultCharSetAttribute.
5708 * decl.cs (Decl.TypeAttr): New protected virtual. Returns default
5709 charset from module.
5711 * delegate.cs (TypeAttr): Override.
5712 (Delegate.DefineType): Use this TypeAttr.
5714 * driver.cs (Driver.MainDriver): Call Module.ResolveAttributes
5715 at very early stage (before types are defined) to resolve model
5716 module attributes. It will probably not work with corlib but it
5719 * enum.cs (Enum.TypeAttr): New protected virtual. Returns default
5720 charset from module.
5722 * typemanager.cs (default_charset_type): New type.
5724 2005-04-13 Raja R Harinath <rharinath@novell.com>
5726 * decl.cs (MemberCache.AddMethods): Don't warn if
5727 System.Object.Finalize has buggy MethodAttributes.
5729 * typemanager.cs (IsUnmanagedType): Restore !IsValueType check
5732 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
5734 * doc.cs : detect ambiguous reference to overloaded members.
5735 Fixed bug #71603. MS 1.1 csc does not detect it.
5737 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
5739 * doc.cs : delegates must not be referenced with parameters.
5742 2005-04-12 Miguel de Icaza <miguel@novell.com>
5744 * typemanager.cs (IsUnmanagedType): Arrays are allowed.
5746 2005-04-10 Miguel de Icaza <miguel@novell.com>
5748 * driver.cs (MainDriver): Stop processing if the CLS stage found
5751 (CompilerCallableEntryPoint.InvokeCompiler): Always
5752 reset after execution; Take a TextWriter argument for the
5755 * report.cs: Use the error stream instead of hardcoding stderr.
5757 2005-04-09 Miguel de Icaza <miguel@novell.com>
5759 * class.cs: Reduce code paths to test, too small of an
5760 optimization to make it worth the extra testing. Always perform
5763 2005-04-08 Raja R Harinath <rharinath@novell.com>
5766 * class.cs (OperatorArrayList.CheckPairedOperators): Skip
5767 operators that had errors reported on them.
5769 2005-04-08 Marek Safar <marek.safar@seznam.cz>
5771 * attribute.cs (Attribute.IsValidArgumentType): Test valid named
5773 (Attribute.Resolve): Add named argument type checking.
5775 * class.cs (FixedField.Define): Use IsPrimitiveType
5777 * expression.cs (Binary.ResolveOperator): Reflect IsCLRType renaming.
5779 * iterators.cs (Iterator.DefineIterator): Add check for arglist and
5780 unsafe parameter types.
5782 * statement.cs (Using.ResolveExpression): Add better error description.
5784 * typemanager.cs (IsCLRType): Renamed to IsPrimitiveType.
5786 2005-04-08 Raja R Harinath <rharinath@novell.com>
5789 * attribute.cs (Attribute.GetAttributeUsage): Resolve
5790 AttributeUsageAttribute in the emitcontext of the attribute class,
5791 not in the emitcontext of the attributable entity it was attached to.
5792 * cs-parser.jay: Use 'current_class', not 'current_container',
5793 when creating a GlobalAttribute.
5795 2005-04-08 Alp Toker <alp@atoker.com>
5797 * pending.cs: The fix to #58413 failed to compile methods implementing
5798 interfaces with/without params modifiers and vice versa, even though
5799 params modifiers aren't part of the signature. Make the modifier check
5800 less strict as in csc.
5802 2005-04-07 Abin Thomas <projectmonokochi@rediffmail.com>
5803 Anoob V E <projectmonokochi@rediffmail.com>
5804 Harilal P R <projectmonokochi@rediffmail.com>
5807 * pending.cs (TypeAndMethods.mods): New. Store the parameter
5808 modifiers of pending methods.
5809 (PendingImplementation.PendingImplementation): Initialize it.
5810 Add Parameter.Modifier [][] mods and initialize it with ParameterData.
5811 (PendingImplementation.InterFaceMethod): Repalce Type[] argument
5812 with ParameterData. Add check for modifiers.
5813 * class.cs (MethodData.Define): Update to changes.
5815 2005-04-07 Raja R Harinath <rharinath@novell.com>
5817 * ecore.cs (Expression.IsAccessorAccessible): Clarify code somewhat.
5819 2005-04-07 Marek Safar <marek.safar@seznam.cz>
5821 * class.cs (PropertyMethod.Define): Check private accessor in abstract
5824 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't allow RequiredAttribute
5827 * typemanager.cs: Registered RequiredAttributeAttribute.
5829 2005-04-06 Marek Safar <marek.safar@seznam.cz>
5831 * class.cs (VerifyMembers): Doesn't need EmitContext argument.
5832 Warning CS0169 is back at level 3.
5833 (IMethodData.SetMemberIsUsed): New method.
5835 * decl.cs (IsUsed): New value; moved from FieldBase.Status
5836 (SetMemberIsUsed, IsUsed): New methods, encapsulate IsUsed.
5838 * delegate.cs (ResolveMethodGroupExpr): Call SetMemberIsUsed.
5840 * ecore.cs (FieldExpr.ResolveMemberAccess): Call SetMemberIsUsed for
5842 (PropertyExpr.ResolveAccessors): Call SetMemberIsUsed when delegate
5845 * expression.cs (OverloadResolve): Call SetMemberIsUsed. when method
5848 * rootcontext.cs (RootContext.EmitCode): Call VerifyMembers in extra run
5849 to avoid the problems with nested types.
5851 2005-04-05 Abin Thomas <projectmonokochi@rediffmail.com>
5852 Anoob V.E <projectmonokochi@rediffmail.com>
5853 Harilal P.R <projectmonokochi@rediffmail.com>
5854 Raja R Harinath <rharinath@novell.com>
5857 * delegate.cs (Define): Emit ParamArrayAttribute for 'params'
5859 * typemanager (GetConstructor): Make public.
5861 2005-04-05 John Luke <john.luke@gmail.com>
5862 Raja R Harinath <rharinath@novell.com>
5865 * typemanager.cs (IsUnmanagedType): Check non-public fields of a
5866 struct too. Return false quicker in a few cases.
5867 (VerifyUnManaged): Use it.
5869 2005-04-05 Raja R Harinath <rharinath@novell.com>
5872 * statement.cs (Block.Resolve): Initialize 'unreachable' to false,
5873 not 'unreachable_seen'.
5875 2005-04-04 Marek Safar <marek.safar@seznam.cz>
5877 * attribute.cs (Attribute.GetValue): Removed unused.
5879 * codegen.cs (CodeGen.TrimExt): Removed unused.
5881 * cs-parser.jay (output): Removed unused.
5883 * cs-tokenizer.cs (hex_digits): Removed unused.
5885 * enum.cs (MapToInternalType, GetEnumeratorName): Removed unused.
5887 * expression.cs (Indirection.LoadExprValue): Removed unused.
5888 (ArrayCreation.ExpressionToArrayArgument): Removed unused.
5890 * iterators.cs (Iterator.param_types): Removed unused.
5892 * statement.cs (Goto.block): Removed unused.
5893 (ToplevelBlock.did): Removed unused.
5894 (Switch.ResolveConstantSwitch): Removed unused.
5896 2005-04-01 Ben Maurer <bmaurer@ximian.com>
5898 * rootcontext.cs: Allow mcs to bootstrap with the compilation
5901 2005-04-19 Martin Baulig <martin@ximian.com>
5903 Merged r42462 from MCS and made it work for GMCS.
5905 * class.cs (MethodCore.ds): Moved this field to `MemberBase'.
5907 * generic.cs (GenericMethod.Define): Removed `return_type' argument.
5909 2005-04-01 Raja R Harinath <rharinath@novell.com>
5911 Fix #74232 and cs0208-3.cs.
5912 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0208 check.
5913 * typemanager.cs (IsUnmanagedType): Don't allow 'object' as an
5914 unmanaged type. Don't use FieldBuilders when 't' is a
5915 TypeBuilder. Use ModFlags and MemberType fields.
5916 * class.cs (MemberBase.member_type): Rename from MemberType.
5917 (MemberBase.MemberType): New property. Determines member_type on
5919 (MemberBase.DoDefine): Don't initialize MemberType here.
5920 (FieldMember.Define): Likewise.
5922 2005-04-01 Marek Safar <marek.safar@seznam.cz>
5925 * class.cs (Event.Emit): Call Add/Remove emit even for interfaces.
5926 Attributes are emitted there.
5928 2005-04-01 Raja R Harinath <rharinath@novell.com>
5930 * cs-tokenizer.cs (consume_identifier): Treat 'partial' as a
5931 keyword in 'partial enum' too.
5932 * cs-parser.jay (enum_declaration): Add CS0267 check ('partial enum'
5934 Report from Kamil Skalski <nazgul@omega.pl>.
5937 * rootcontext.cs (ResolveTree): The 'root.Interfaces' list can
5938 have partial containers too.
5940 * ecore.cs (SimpleName.SimpleNameResolve): Move 'invariant meaning
5941 in block' checks to Block.CheckInvariantMeaningInBlock.
5942 * statement.cs (Block.GetKnownVariableInfo): Make private.
5943 (Block.IsVariableUsedInChildBlock): Remove.
5944 (Block.IsVariableUsedInBlock): Likewise.
5945 (Block.CheckInvariantMeaningInBlock): New. Show location of
5946 conflicting declaration.
5947 (Block.AddVariable): Make error messages less long-winded and more
5948 specific. Show location of conflicting declaration.
5949 * parameter.cs (Parameters.Location): New readonly property.
5951 2005-03-31 Raja R Harinath <rharinath@novell.com>
5953 Clean up semantics of invoking ResolveMemberAccess.
5954 * ecore.cs (SimpleName.DoSimpleNameResolve): If a MemberExpression
5955 can have an instance, ensure that we pass in a non-TypeExpression
5956 to ResolveMemberAccess. Tighten up IdenticalNameAndTypeName checks.
5957 (MemberExpr.DoSimpleNameResolve): Remove type_is_inferred
5958 argument. Update to changes and simplify.
5959 (FieldExpr.Emitinstance): Remove CS0120 check.
5960 (PropertyExpr.EmitInstance): Likewise.
5961 * expression.cs (Argument.Resolve): Likewise.
5962 (Invocation.DoResolve): Update to changes in semantics of
5965 2005-03-31 Marek Safar <marek.safar@seznam.cz>
5968 * class.cs (AbstractPropertyEventMethod.EmitMethod): Enable emit method
5971 * decl.cs (MemberCache.AddMethods): Fix infinite loop.
5973 2005-03-31 Raja R Harinath <rharinath@novell.com>
5975 Fix difference in behaviour with commandline invocation.
5976 * driver.cs (Driver.Reset): New.
5977 (CompilerCallableEntryPoint): Call it.
5979 * statement.cs (If.Resolve): Avoid spurious "uninitialized
5980 variable" warnings if the boolean expression failed to resolve.
5982 2005-03-30 Sebastien Pouliot <sebastien@ximian.com>
5984 * attribute.cs: Fix the union of several permissions when some of them
5985 are unrestricted (so the result isn't an unrestricted permission set).
5988 2005-03-30 Raja R Harinath <rharinath@novell.com>
5990 * ecore.cs (MemberExpr): New class. Convert from interface
5992 (MemberExpr.ResolveMemberAccess): Refactor and move here from
5993 MemberAccess.ResolveMemberAccess. Tighten up pre-conditions and
5995 (MethodGroupExpr, FieldExpr, PropertyExpr, EventExpr): Update.
5996 (MethodGroupExpr.IsExplicitImpl): Remove.
5997 (Expression.GetFieldFromEvent): Remove.
5998 (SimpleName.MemberStaticCheck): Remove.
5999 (SimpleName.DoSimpleNameResolve): Update to changes.
6000 * expression.cs (MemberAccess.ResolveMemberAccess): Refactor.
6001 (MemberAccess.IdenticalNameAndTypeName): Remove.
6002 (MemberAccess.error176): Move to MemberExpr.
6003 (MemberAccess.DoResolve): Update to changes.
6004 (BaseAccess.DoResolve): Likewise.
6006 2005-03-30 Marek Safar <marek.safar@seznam.cz>
6008 C# 2.0 Conditional attribute class implementation
6010 * attribute.cs (AttributeTester.IsAttributeExcluded): New method.
6011 Analyzes class whether it has attribute which has ConditionalAttribute
6012 and its condition is not defined.
6014 * class.cs (Class.ApplyAttributeBuilder): Add IsAttributeExcluded check.
6015 (Class.IsExcluded): New method. Search for at least one defined
6016 condition in ConditionalAttribute of attribute class.
6018 2005-03-30 Raja R Harinath <rharinath@novell.com>
6020 * ecore.cs (PropertyExpr): Derive from Expression, not
6021 ExpressionStatement.
6022 (PropertyExpr.EmitStatement): Remove.
6024 2005-03-29 Raja R Harinath <rharinath@novell.com>
6027 * expression.cs (MemberAccess.ResolveMemberAccess): Allow the
6028 internal field "value__" of an enum be private. The examples for
6029 "value__" that I found on MSDN all used FieldAttributes.Private.
6031 * decl.cs (MemberCache.AddMethods): Use C# terminology in warning.
6032 Don't mention IL method attribute names.
6034 Fix #47991. Remove a TODO.
6035 * statement.cs (Block.Toplevel): Make into a field.
6036 (Block.Parameters): Move into ToplevelBlock.
6037 (Block.known_variables): Rename from child_variable_names.
6038 (Block.Block): Remove variants that take Parameters. Initialize
6039 'Toplevel' with the immediately surrounding toplevel block.
6040 (Block.AddKnownVariable): Rename from AddChildVariableName. Add a
6041 LocalInfo parameter.
6042 (Block.GetKnownVariableInfo): New.
6043 (Block.IsVariableNameUsedInChildBlock): Update.
6044 (Block.IsVariableNameUsedInBlock): New. Checks if a name is used in
6045 the block, even though it may not be in scope.
6046 (Block.AddVariable): Remove Parameters parameter. Use
6047 Toplevel.Parameters instead.
6048 (Block.AddConstant): Remove Parameters parameter.
6049 (Block.GetParameterReference): Update to use Toplevel.Parameters.
6050 (Block.IsParamaterReference): Likewise.
6051 (Block.IsLocalParameter): Likewise. Simplify a lot.
6052 (ToplevelBlock.Parameters): New. Moved from Block.
6053 (ToplevelBlock.ToplevelBlock): Update to changes. Always
6054 initialize Parameters to a non-null value.
6055 * cs-parser.jay: Update to changes.
6056 * ecore.cs (SimpleName.SimpleNameResolve): Emit cs0136 error for
6057 simple names that mean different things in the same block. Use
6058 Block.IsVariableNameUsedInBlock.
6060 2005-03-28 Raja R Harinath <rharinath@novell.com>
6062 * enum.cs (Enum.LookupEnumValue): Remove debugging code.
6064 2005-03-26 Raja R Harinath <harinath@acm.org>
6067 * assign.cs (Assign.DoResolve): When the RHS of an assignment
6068 fails to resolve, ensure that the LHS is still resolved as an
6071 2005-03-25 Raja R Harinath <harinath@acm.org>
6073 * enum.cs (Enum.DefineType): Set ec.InEnumContext and
6075 (Enum.current_ec): Remove.
6076 (Enum.LookupEnumValue): Remove EmitContext argument.
6077 Just uses the one created during DefineType.
6078 (Enum.FindMembers): Update.
6079 * expression.cs (MemberAccess.DoResolve): Update.
6081 2005-03-22 Marek Safar <marek.safar@seznam.cz>
6083 * assign.cs (Assign.DoResolve): Check for CS1717 when
6084 source and target are same (uses Equals).
6086 * expression.cs (LocalVariableReference, ParameterReference,
6087 This): Implemented Equals, GetHashCode.
6089 * statement.cs (Block.GetParameterReference): Removed useless
6092 2005-03-22 Raja R Harinath <rharinath@novell.com>
6095 * statement.cs (Block.AddVariable): Ensure that we skip implicit
6096 blocks before deciding whether the error is cs0136 or cs0128.
6098 * cs-parser.jay: Pass MemberName to RootContext.Tree.RecordDecl.
6099 (using_alias_directive, using_namespace_directive): Pass
6100 MemberName, not an expression to Namespace.UsingAlias and
6102 (MakeName): Use the MemberName of the namespace.
6103 * namespace.cs (Namespace.MemberName): New.
6104 (UsingEntry.UsingEntry): Take a MemberName, not an expression.
6105 (AliasEntry.AliasEntry, Namespace.Using, Namespace.UsingAlias):
6107 * decl.cs (MemberName.Name): Make readonly.
6108 (MemberName.FromDotted): New "constructor".
6109 (MemberName.Equals, MemberName.GetHashCode): Implement overrides.
6110 (MemberCore.Name): Compute from MemberName on demand.
6111 (MemberCore.SetMemberName): Provide a way to change the
6113 (MemberCore.AddToContainer): Don't take a fullname parameter.
6114 * class.cs (TypeContainer.AddToMemberContainer): Don't add the
6115 fully qualified name of the container to the member name.
6116 (TypeContainer.AddToTypeContainer): Use a fully qualified name
6117 only if the type is a member of the root container.
6118 (TypeContainer.AddMethod, TypeContainer.AddProperty): Use
6119 MemberName.Left rather than searching for an embedded ".".
6120 (PartialContainer.CreatePart): Update to changes in RootContext.
6121 (MemberBase.ShortName): Turn into a property. Use
6122 MemberCore.SetMemberName.
6123 (MemberBase.ExplicitInterfaceName): Remove.
6124 (MemberBase.UpdateMemberName): Remove.
6125 (AbstractPropertyEventMethod.UpdateName): Use SetMemberName.
6126 (PropertyBase.SetMemberName): New override.
6127 * tree.cs (Tree.RecordDecl): Take a MemberName and use it as hash key.
6128 (Tree.GetDecl): New.
6129 (Tree.AllDecls): Rename from Decls.
6130 * attribute.cs, enum.cs, report.cs: Update to changes.
6131 * driver.cs (MainDriver): Use MemberName.FromDotted on
6132 RootContext.MainClass.
6134 2005-03-21 Marek Safar <marek.safar@seznam.cz>
6136 * class.cs (FixedField.Define): Check for CS1664 and more sanity
6139 * expression.cs (ElementAccess.DoResolveLValue): Check for CS1708.
6141 2005-03-18 Marek Safar <marek.safar@seznam.cz>
6143 * modifiers.cs (Modifiers.PROPERTY_CUSTOM): New constant for
6144 property accessor modifiers.
6146 * class.cs (FieldMember.ApplyAttributeBuilder): Don't allow apply
6147 fixed buffer attribute (CS1716).
6148 (PropertyMethod.HasCustomAccessModifier): When property accessor
6149 has custom modifier.
6151 * ecore (PropertyExpr.DoResolve): Add CS0271 for custom accessor
6153 (PropertyExpr.DoResolveLValue): Add CS0272.
6155 2005-03-17 Miguel de Icaza <miguel@novell.com>
6157 * convert.cs: When converting to a pointer, use the proper Conv.U
6158 or Conv.I depending on the source data type.
6160 * cs-tokenizer.cs: Make the size for large decimal constants,
6163 2005-03-17 Martin Baulig <martin@ximian.com>
6165 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
6166 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
6168 2005-03-17 Martin Baulig <martin@ximian.com>
6170 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
6171 to bool so we can return an error condition.
6172 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
6175 2005-03-16 Zoltan Varga <vargaz@freemail.hu>
6177 * attribute.cs: Encode ThrowOnUnmappableChar and BestFitMapping
6180 2005-03-16 Raja R Harinath <rharinath@novell.com>
6182 Remove TypeManager.LookupType and TypeManager.LookupTypeDirect.
6183 Refactor to avoid traversing the list of assemblies, and to avoid
6184 string concatenation.
6185 * typemanager.cs (guid_attr_type): Remove.
6186 (negative_hits, pointers, references): Remove hashes.
6188 (GetConstructedType): New. Uses type_hash to handle constructed
6189 types (arrays, references, pointers).
6190 (GetReferenceType, GetPointerType): Use it.
6191 (GetNestedType): New. Uses type_hash to handle nested types of
6193 (LookupType, LookupTypeDirect): Remove.
6194 (CoreLookupType): Inline parts of old LookupTypeDirect code. Use
6195 'types' hash and LookupTypeReflection directly.
6196 (params_string, params_object): Use GetConstructedType.
6197 * namespace.cs (Namespace.cached_types): New. Cache of reflected
6199 (Namespace.Lookup): Use cached_types.
6200 (NamespaceEntry.LookupNamespaceOrType): Inline the functionality
6201 provided by old TypeManager.LookupType.
6202 * rootcontext.cs (MakeFQN): Remove.
6203 * decl.cs (DeclSpace.MakeFQN): Likewise.
6204 (DeclSpace.LookupType): Use TypeManager.GetNestedType.
6205 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
6206 TypeManager.GetConstructedType.
6207 * tree.cs (decl_ns_hash, LookupByNamespace): Remove.
6209 2005-04-16 Zoltan Varga <vargaz@freemail.hu>
6211 * cs-parser.jay: Fix build.
6213 2005-03-15 Marek Safar <marek.safar@seznam.cz>
6215 * class.cs (TypeContainer.CircularDepException) New nested
6216 (MethodCore.CheckBase): Report CS1715 for properties and indexers.
6218 * cs-parser.jay: Reports CS1527 for any namespace element.
6220 * delegate.cs (DelegateCreation.Error_NoMatchingMethodForDelegate):
6223 * expression.cs (ParameterReference.IsAssigned): Changed error to
6225 (Error_WrongNumArguments): Moved CS0245 detection here.
6227 * statement.cs (Return.Resolve): Add CS1622 report.
6229 2005-03-11 Marek Safar <marek.safar@seznam.cz>
6231 * class.cs (StaticClass.DefineContainerMembers): Added CS0720.
6233 2005-03-11 Zoltan Varga <vargaz@freemail.hu>
6235 * attribute.cs expression.cs: Get rid of some allocations.
6237 2004-03-11 Atsushi Enomoto <atsushi@ximian.com>
6239 * doc.cs : just eliminate the latest change.
6241 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
6243 * doc.cs : commented out the latest change. It breaks xml-030.cs
6245 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
6247 * doc.cs : When TypeBuilder did not create Type yet, GetEvents() will
6248 fail. So invoke CreateType() in FindDocumentedType().
6250 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
6252 * cs-tokenizer.cs : added IsKeyword().
6253 * doc.cs : Detect keyword incorrectly used as identifier.
6254 Allow identifiers prefixed by @.
6256 2005-03-10 Marek Safar <marek.safar@seznam.cz>
6258 * attributes.cs (Attributes.Emit): Continue after CheckTargets.
6259 It caused exception in namespace resolving (again!).
6261 * class.cs (Class.ctor): Removed exit.
6262 (PropertyMethod.ctor): ditto.
6264 * codegen.cs (Codegen.Reset): Reset static data.
6265 (Codegen.ResolveTopBlock): Forward error status from ResolveMeta.
6267 * cs-tokenizer.cs (Cleanup): Removed.
6269 * driver.cs (GetSystemDir): Rewrote to one line command.
6270 It caused problem with unloaded dynamic modules.
6271 (UnixParseOption): Removed Exit.
6272 (CompilerCallableEntryPoint.InvokeCompiler): Make static.
6273 (CompilerCallableEntryPoint.Reset): Reset suitable static data.
6274 Now can be mcs used as library.
6276 * ecore.cs (Expression.ResolveBoolean): Use Location.Null for
6279 * location.cs (Reset): Reset static data.
6281 * namespace.cs (Reset): Reset static data.
6283 * report.cs (Report.Reset): Reset static data.
6285 * rootcontext.cs (RootContext.Reset): Reset static data.
6287 * tree.cs (RootTypes.ctor): Use Location.Null
6289 * typemanager.cs (TypeManager.Reset): Reset static data.
6290 (CoreLookupType): Removed Exit.
6291 (TypeHandle.Reset): Reset static data.
6293 2005-03-10 Raja R Harinath <rharinath@novell.com>
6296 * typemanager.cs (ComputeNamespaces): Import namespaces from
6297 referenced modules too.
6299 2005-03-09 Raja R Harinath <rharinath@novell.com>
6301 * class.cs (TypeContainer.AddToMemberContainer): Use "." rather
6304 2005-03-09 Raja R Harinath <rharinath@novell.com>
6306 * decl.cs (DeclSpace.LookupType): Don't loop but recurse into
6307 enclosing DeclSpace. This ensures that a name-lookup populates
6308 more caches and there are fewer 'TypeExpression's. Carve out
6309 nested type lookup into ...
6310 (LookupNestedTypeInHierarchy): ... this.
6312 2005-04-15 Martin Baulig <martin@ximian.com>
6314 Merged r41590 from MCS and make it work in the generics land.
6316 * generic.cs (TypeParameter.UpdateConstraints): Removed the
6319 * class.cs (PartialContainer.UpdateConstraints): Removed.
6320 (PartialContainer.CheckConstraints): Removed.
6321 (PartialContainer.SetParameterInfo): Store the constraints here.
6322 (PartialContainer.DefineTypeParameters): New public method;
6323 resolve the type parameter's constraints here. Note that the
6324 PartialContainer doesn't have an EmitContext anymore, so we must
6325 do this in the ClassPart.
6327 2005-03-09 Raja R Harinath <rharinath@novell.com>
6329 Clean up a few partial-class semantics.
6330 Fixes test-357.cs and cs1618-2.cs.
6331 * cs-parser.jay (struct_declaration): Use 'current_class' as
6332 parent of newly-created struct. Remove call to Register ().
6333 Use 'pop_current_class' to complete handing the current struct.
6334 (interface_declaration): Likewise.
6335 (class_declaration): Likewise.
6336 (enum_declaration): Use 'current_class' as parent of newly created
6338 (delegate_declaration): Likewise.
6339 (pop_current_class): New function. This is used to handle closing
6340 up the 'current_class' and 'current_container', and pointing them
6341 to the enclosing class/container.
6342 (CSharpParser): Initialize 'current_class' too.
6343 * decl.cs (MemberCore): Add check for invariant: a partial
6344 container is not a parsed entity, and thus does not enclose any
6346 (DeclSpace.TypeResolveEmitContext): Expose 'type_resolve_ec'.
6347 (DeclSpace.BaseTypeExpr): Use it.
6348 (DeclSpace.LookupType): Add check for invariant.
6349 * class.cs (TypeContainer): Add check for invariant: a nested
6350 class should have the same NamespaceEntry as its enclosing class.
6351 (TypeContainer.EmitFieldInitializers): Make virtual.
6352 (TypeContainer.DefineDefaultConstructor): Adhere to invariant in
6354 (TypeContainer.Register): Remove.
6355 (TypeContainer.DefineType): Set the 'ec' of a PartialContainer to
6356 null. Use TypeResolveEmitContext for resolving base types and
6357 interfaces. Move initialization of Parts.TypeBuilder here from
6359 (TypeContainer.DefineNestedTypes): ... here.
6360 (PartialContainer): Take a Namespace not a NamespaceEntry.
6361 (PartialContainer.Create): Don't use Register. Call the
6362 appropriate Add... function directly.
6363 (ClassPart): Take both the PartialContainer and the enclosing
6364 class as constructor arguments.
6365 (ClassPart.EmitFieldInitializers): Override.
6366 (ClassPart.PartFindNestedTypes): Remove.
6367 (FieldBase.GetInitializerExpression): Resolve the initializer
6368 expression in the emit context of the enclosing class.
6369 * tree.cs (RootTypes): Remove Register ().
6371 2005-03-08 Marek Safar <marek.safar@seznam.cz>
6373 * cs-parser.jay: Removed CS0134.
6375 * driver.cs: Removed CS1901.
6377 * expression.cs (SizeOf.DoResolve): Don't report CS0233
6378 for predefined types.
6380 2005-03-07 Duncan Mak <duncan@novell.com>
6382 * codegen.cs (Save): Catch UnauthorizedAccessException as
6383 well. Fixes bug #73454.
6385 2005-03-07 Marek Safar <marek.safar@seznam.cz>
6387 * cs-tokenizer.cs (xtoken): Add CS1035.
6389 * class.cs (MethodData.Define): Add CS0683.
6390 (FieldMember.ctor): Add CS0681.
6392 2005-03-07 Raja R Harinath <rharinath@novell.com>
6394 * ecore.cs (SimpleName.DoResolve): Rename from
6395 SimpleName.DoResolveAllowStatic.
6396 (SimpleName.DoSimpleNameResolve): Remove 'allow_static' argument.
6397 Pass 'intermediate' flag to MemberStaticCheck.
6398 (SimpleName.MemberStaticCheck): Skip "static check" only in case
6399 of "intermediate" lookups via MemberAccess.
6400 (SimpleName.IdenticalNameAndTypeName): New. Carved out of ...
6401 * expression.cs (MemberAccess.IdenticalNameAndTypeName): ... this.
6403 2005-03-07 Raja R Harinath <rharinath@novell.com>
6406 * ecore.cs (FieldExpr.EmitInstance): Catch cases of CS0120 that
6407 slipped in because of variable names that are identical to a
6408 builtin type's BCL equivalent ('string String;', 'int Int32;').
6409 (PropertyExpr.EmitInstance): Likewise.
6411 2005-03-04 Marek Safar <marek.safar@seznam.cz>
6413 * cs-tokenizer.cs (PreProcessPragma): Add warning 1633, 1635.
6415 * report.cs (warning_ignore_table): Made public.
6417 2005-03-04 Raja R Harinath <rharinath@novell.com>
6420 * class.cs (MethodData.Emit): Pass 'container' to
6421 container.GetObsoleteAttribute instead of 'container.Parent'.
6423 2005-03-03 Marek Safar <marek.safar@seznam.cz>
6425 * cs-parser.jay: Add 1534 error test.
6427 * iterators.cs (Yield.CheckContext): Add error 1629.
6428 (Iterator.ctor): Save unsafe modifier.
6429 (MoveNextMethod.DoEmit): Restore unsafe context.
6431 * namespace.cs (UsingAlias): Better error message.
6433 2005-03-03 Dan Winship <danw@novell.com>
6435 * convert.cs (Error_CannotImplicitConversion): fix two bugs in
6436 the warning message [#73219]
6438 2005-03-03 Raja R Harinath <rharinath@novell.com>
6440 Fix compile with MCS 1.0.0.0.
6441 * cs-tokenizer.cs (PreProcessPragma): Simplify w_disable and
6442 w_restore to not depend on string constant folding.
6444 2005-03-03 Raja R Harinath <rharinath@novell.com>
6446 * decl.cs (DeclSpace.LookupType): Remove 'silent' argument. Move
6447 CS0246 check to users who passed 'silent = false'.
6448 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): Add CS0246
6450 (SimpleName.SimpleNameResolve): Update.
6451 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0246 check.
6452 (MemberAccess.IdenticalNameAndTypeName): Update.
6453 * doc.cs (FindDocumentedTypeNonArray): Update.
6455 2005-03-03 Raja R Harinath <rharinath@novell.com>
6457 * codegen.cs (EmitContext): Remove ResolvingTypeTree.
6458 * parameters.cs (ComputeAndDefineParameters): Remove.
6459 * decl.cs (ResolveBaseTypeExpr): Don't set ResolvingTypeTree.
6460 * delegate.cs (Define): Don't invoke ComputeAndDefineParameters.
6461 Use GetParameterInfo.
6463 2005-03-02 Marek Safar <marek.safar@seznam.cz>
6465 * report.cs (StaticClass.DefineContainerMembers): Add warning 628.
6467 2005-03-02 Raja R Harinath <rharinath@novell.com>
6469 Unify DeclSpace.LookupType and DeclSpace.FindType.
6470 * decl.cs (DeclSpace.FindNestedType): New virtual function. This
6471 is in charge of defining nested types on demand.
6472 (DeclSpace.LookupType): Use it when the current_type is a
6473 TypeBuilder. Use LookupTypeDirect for reflected types.
6474 (DeclSpace.FindType): Remove.
6475 (DeclSpace.LookupInterfaceOrClass): Likewise.
6476 (DeclSpace.DefineTypeAndParents): Likewise.
6477 * ecore.cs (SimpleName.ResolveAsTypeStep): Just call
6478 DeclSpace.LookupType.
6479 * doc.cs (FindDocumentedTypeNonArray): Use DeclSpace.LookupType.
6480 * typemanager.cs (LookupType): Simplify.
6481 (AddUserType): Remove type from negative_hits.
6482 * namespace.cs (Namespace.Lookup): Use TypeManager.LookupTypeDirect.
6483 * class.cs (TypeContainer.FindMembers): Move handling of nested
6485 (TypeContainer.FindMembers_NestedTypes): ... here.
6486 (TypeContainer.FindNestedType): Implement override.
6487 (ClassPart.FindNestedType): Delegate to PartialContainer.
6488 (ClassPart.PartFindNestedType): Looks up the nested types of the
6491 2005-04-14 Martin Baulig <martin@ximian.com>
6493 * generic.cs (ConstructedType): Moved all the type lookup and
6494 nested class logic into SimpleName.
6495 (ConstructedType.ResolveConstructedType): Our underlying type is
6496 already fully resolved; all the type lookup stuff is in
6499 * ecore.cs (SimpleName.ResolveAsTypeStep): Resolve nested
6500 constructed types here instead of in ConstructedType.
6502 * decl.cs (MemberName.GetTypeExpression): Always create a
6503 SimpleName, not a ConstructedType.
6504 (DeclSpace.ResolveNestedType): Removed; this is now in SimpleName.
6506 2005-03-02 Martin Baulig <martin@ximian.com>
6508 * class.cs (TypeContainer.DoDefineMembers): We also need a default
6509 static constructor in static classes.
6511 2005-03-01 Zoltan Varga <vargaz@freemail.hu>
6513 * attribute.cs: Pass -1 to DefineLPArrayInternal if sizeConst or
6514 sizeParamIndex is not specified.
6516 2005-03-01 Marek Safar <marek.safar@seznam.cz>
6519 * report.cs (WarningMessage.IsEnabled): Missing null check.
6521 2005-02-28 Marek Safar <marek.safar@seznam.cz>
6523 * attribute.cs (DefinePInvokeMethod): Fix, all data are stored
6524 in the fields and not in the properties.
6526 2005-02-28 Zoltan Varga <vargaz@freemail.hu>
6528 * attribute.cs (GetMarshal): Marshal SizeConst and SizeParamIndex
6531 2005-02-28 Marek Safar <marek.safar@seznam.cz>
6533 * attribute.cs: Small refactoring (improved robustness).
6534 (ImplOptions, UnmanagedType, UsageAttribute): Removed members.
6535 (ValidateGuid): Removed.
6536 (Resolve): Removed referenced to above mentioned.
6537 (GetAttributeUsage): Made private and changed to work without
6539 (GetIndexerAttributeValue): Don't crash.
6540 (GetConditionalAttributeValue): Ditto.
6541 (GetClsCompliantAttributeValue): Ditto.
6542 (ExtractSecurityPermissionSet): All attributes exceptions are
6544 (GetPropertyValue): New helper.
6545 (GetMethodImplOptions): New method.
6546 (DefinePInvokeMethod): Reuse common code. Implemented handling of
6547 some missing properties.
6549 * class.cs (ClassOrStruct.ApplyAttributeBuilder): Updated.
6550 (Method.ApplyAttributeBuilder): Updated.
6552 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't catch shared
6555 2005-02-28 Raja R Harinath <rharinath@novell.com>
6558 * report.cs (Report.SymbolRelatedToPreviousError): Handle
6559 non-simple types (array, pointer, reference).
6561 2005-02-28 Marek Safar <marek.safar@seznam.cz>
6563 * cs-parser.jay: Add errors 1617, 650, 1007, 531, 547, 548
6565 * class.cs (MethodCore.IsDuplicateImplementation): Special error
6567 (Method.CheckBase): Catch wrong destructor here.
6568 (MethodData.Define): Add errors 550, 668.
6570 * cs-tokenizer.cs (PreProcessPragma): Add warning 1634.
6572 * ecore.cs (PropertyExpr.DoResolveLValue): Fixed wrong error code.
6574 * pending.cs (VerifyPendingMethods): Add error 551.
6576 * typemanager.cs (CSharpName): Next error report helper.
6578 2005-02-25 Marek Safar <marek.safar@seznam.cz>
6580 * attribute.cs (Atttribute.Resolve): Add cache for parameter-less
6581 attributes. Removed useless attribute double check.
6582 It saves almost 2MBs for corlib.
6584 2005-02-25 Raja R Harinath <rharinath@novell.com>
6587 * statement.cs (ExpressionStatement.Resolve): Make robust to being
6588 called twice in case of error.
6590 2005-02-23 Chris Toshok <toshok@ximian.com>
6592 Fix compiler portions of #72827.
6593 * statement.cs (Block.Emit): call Begin/EndScope on the
6594 EmitContext instead of the ILGenerator.
6596 * codegen.cs (EmitContext.BeginScope): new method, call
6597 ILGenerator.BeginScope as well as the SymbolWriter's OpenScope (if
6599 (EmitContext.BeginScope): same, but EndScope and CloseScope
6601 * symbolwriter.cs (SymbolWriter.OpenScope): get the current il
6602 offset and call the superclass's OpenScope(int) with it.
6603 (SymbolWriter.CloseScope): get the current il
6604 offset and call superclass's CloseScope(int) with it.
6606 2005-02-23 Marek Safar <marek.safar@seznam.cz>
6608 * anonymous.cs (AnonymousMethod.Compatible): Fixed to report
6609 CS1677 for out and ref as well.
6611 * class.cs (Method.Define): Add error CS1599 detection.
6613 * cs-parser.jay: Add CS1609, CS1670, CS1627 detection.
6615 * cs-tokenizer.cs (xtoken): Add error CS1646 detection.
6617 * delegate.cs (Delegate.Define): Add error CS1599 detection.
6619 * support.cs.cs (ModifierDesc): New helper method.
6621 2005-02-23 Raja R Harinath <rharinath@novell.com>
6622 Abin Thomas <projectmonokochi@rediffmail.com>
6623 Anoob V E <projectmonokochi@rediffmail.com>
6624 Harilal P R <projectmonokochi@rediffmail.com>
6627 * class.cs (ConstructorBuilder.Resolve): Make sure that the second
6628 MemberLookup (used for error reporting) actually returns a result.
6629 Fix error report number (122, not 112).
6631 2005-02-22 Abin Thomas <projectmonokochi@rediffmail.com>
6632 Anoob V E <projectmonokochi@rediffmail.com>
6633 Harilal P R <projectmonokochi@rediffmail.com>
6636 * pending.cs (PendingImplementation.GetAbstractMethods):
6637 Find NonPublic members too.
6639 2005-02-22 Marek Safar <marek.safar@seznam.cz>
6641 * expression.cs.cs (ConditionalLogicalOperator.DoResolve):
6644 * class.cs (MethodCore.CheckMethodAgainstBase):
6645 Add error 239 report.
6647 2005-02-21 Marek Safar <marek.safar@seznam.cz>
6649 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
6651 * class.cs (Operator.Define): Add error 217 report.
6653 2005-02-21 Raja R Harinath <rharinath@novell.com>
6656 * expression.cs (Invocation.IsApplicable): Make public.
6657 (Invocation.IsParamsMethodApplicable): Likewise.
6658 * delegate.cs (Delegate.VerifyApplicability): Don't use
6659 Invocation.VerifyArgumentCompat for parameter applicability
6660 testing. Use Invocation.IsApplicable and
6661 Invocation.IsParamsMethodApplicable.
6663 2005-02-21 Marek Safar <marek.safar@seznam.cz>
6665 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
6667 * class.cs (Operator.Define): Add error 217 report.
6669 2005-02-21 Raja R Harinath <rharinath@novell.com>
6671 * namespace.cs (UsingEntry.Resolve): Undo change below.
6673 2005-02-21 Raja R Harinath <rharinath@novell.com>
6676 * ecore.cs (Expression.MemberLookupFailed): Add argument to
6677 disable the error message when the extended MemberLookup also
6679 (Expression.MemberLookupFinal): Update.
6680 (SimpleName.DoSimpleNameResolve): Update.
6681 * expression.cs (MemberAccess.ResolveNamespaceOrType):
6682 Don't use MemberLookupFinal.
6683 (New.DoResolve): Update.
6684 (BaseAccess.CommonResolve): Update.
6686 2005-02-21 Raja R Harinath <rharinath@novell.com>
6689 * attribute.cs (Attribute.ResolveType): If a 'resolve_error' had
6690 occured previously, don't resolve again.
6692 2005-02-21 Marek Safar <marek.safar@seznam.cz>
6695 * attribute.cs (Attribute.GetAttributeUsage): Add EmitContext
6696 argument. Call ResolveAttributeUsage for unresolved.
6697 when types doesn't match ctor arguments.
6699 * class.cs (DoDefineMembers.TypeContainer): Removed safety check
6700 for nested attribute classes.
6701 (Class.attribute_usage): Removed.
6702 (Class.ResolveAttributeUsage): Resolves AttributeUsageAttribute
6703 for attribute class.
6705 * ecore.cs (IsAttribute): Removed.
6707 * namespace.cs (UsingEntry.Resolve): Don't destroy NamespaceEntry.
6709 * rootcontext.cs (RegisterAttribute): Removed, attributes are
6711 (attribute_types): Removed.
6712 (EmitCode): Global attributes are emited as the latest.
6714 2005-02-18 Marek Safar <marek.safar@seznam.cz>
6716 * class.cs (EmitFieldInitializers): Don't emit field initializer
6717 for default values when optimilization is on.
6719 * constant.cs (Constant.IsDefaultValue): New property.
6721 * driver.cs: Add /optimize handling.
6725 * literal.cs: Implement new IsDefaultValue property.
6727 * rootcontext.cs (Optimize): New field, holds /optimize option.
6729 2005-02-18 Raja R Harinath <rharinath@novell.com>
6731 Fix crasher in re-opened #72347.
6732 * namespace.cs (Namespace.Lookup): Return null if
6733 DeclSpace.DefineType returns null.
6736 * expression.cs (Argument.Resolve): Handle a case of CS0120 here.
6738 2005-02-18 Raja R Harinath <rharinath@novell.com>
6740 Fix remainder of #63202. Change semantics of DoResolveLValue: it
6741 now returns null if it cannot resolve to an lvalue.
6742 * ecore.cs (Expression.DoResolveLValue): Return 'null' by default.
6743 (Expression.ResolveLValue): Emit CS0131 error if DoResolveLValue
6744 returned null. Remove check for SimpleName.
6745 (EventExpr.DoResolveLValue): New.
6746 * iterators.cs (Iterator.FieldExpression.DoResolveLValue): New.
6747 * expression.cs (Argument.Error_LValueRequired): New. Move CS1510
6749 (Argument.Resolve): ... here. Use it. Use DoResolveLValue to
6751 (Unary.ResolveOperator): Move CS0211 check ...
6752 (Unary.DoResolve): ... here. Use DoResolveLValue to avoid
6754 (Unary.DoResolveLValue): Simplify.
6755 (AddressOf.DoResolveLValue): New.
6756 (ArrayAccess.DoResolveLValue): New.
6758 2005-02-16 Marek Safar <marek.safar@seznam.cz>
6760 * attribute.cs (Attribute.Resolve): Add arguments casting for
6761 when types doesn't match ctor arguments.
6763 2005-02-16 Raja R Harinath <rharinath@novell.com>
6765 Fix parts of #63202.
6766 * expression.cs (UnaryMutator.ResolveOperator): Remove redundant
6767 lookup of operator in base type. Ensure that all checks happen
6768 when the operator resolves to an "op_..." method.
6770 2005-02-15 Raja R Harinath <rharinath@novell.com>
6773 * namespace.cs (NamespaceEntry.LookupNamespaceOrType): Add
6774 'ignore_cs0104' parameter. Pass it to ...
6775 (NamespaceEntry.Lookup): ... this.
6776 * decl.cs (DeclSpace.LookupType): Add 'ignore_cs0104' parameter.
6777 * ecore.cs (SimpleName.ResolveAsTypeStep): Update.
6778 (TypeLookupExpression.DoResolveAsTypeStep): Update.
6779 * expression.cs (MemberAccess.IdenticalNameAndTypeName):
6780 Update. Request that cs0104 errors be ignored.
6781 (ComposedCast.ResolveAsTypeStep): Update.
6783 2005-02-14 Raja R Harinath <rharinath@novell.com>
6786 * expression.cs (Invocation.BetterFunction): Remove support for
6787 comparing virtual functions and their overrides.
6788 (Invocation.IsOverride): New.
6789 (Invocation.OverloadResolve): Don't consider 'override' functions
6790 during candidate selection. Store them in a lookaside list.
6791 If the selected method is a 'virtual' function, use the list to
6792 find any overrides that are closer to the LHS type.
6794 2005-02-14 Marek Safar <marek.safar@seznam.cz>
6796 * expression.cs (New.DoResolve): Add complex core type reduction.
6797 (New.Constantify): Converts complex core type syntax like 'new int ()'
6800 2005-02-14 Raja R Harinath <rharinath@novell.com>
6802 * decl.cs (EntryType.EntryType): New constructor to create an
6803 updated copy of a cache entry.
6804 (MemberCache.AddMethods): Use it.
6805 (MemberCache.ClearDeclaredOnly): Remove.
6806 (MemberCache.MemberCache): Update.
6808 2005-02-11 Miguel de Icaza <miguel@novell.com>
6810 * codegen.cs (EmitContext): Introduce the `MethodIsStatic'
6811 variable. This one is represents the actual low-level declaration
6812 of the method, as opposed to the semantic level `IsStatic'.
6814 An anonymous method which is hosted into a static method might be
6815 actually an instance method. IsStatic would reflect the
6816 container, while MethodIsStatic represents the actual code
6819 * expression.cs (ParameterReference): Use the new MethodIsStatic
6820 instead of IsStatic.
6822 * anonymous.cs (AnonymousMethod.Compatible): Pass the
6823 Modifiers.STATIC to the Anonymous' Method EmitContext if static is
6824 set on the current EmitContext.
6826 * expression.cs (Cast): Overload DoResolveLValue so we can pass
6827 resolve our casted expression as an LValue. This triggers the
6828 proper LValue processing that is later required by Assign.
6832 * cs-tokenizer.cs (pp_and): recurse on pp_and, fixes #61903.
6834 2005-02-11 Marek Safar <marek.safar@seznam.cz>
6836 C# 2.0 Fixed buffer implementation
6838 * anonymous.cs: Update after RegisterHelperClass renaming.
6840 * attribute.cs (AttributeTester.fixed_buffer_cache):
6841 Cache of external fixed buffers.
6842 (AttributeTester.GetFixedBuffer): Returns IFixedBuffer
6843 implementation if field is fixed buffer else null.
6846 (TypeContainer.AddField): Accept FieldMember instead of Field.
6847 (FieldBase.IsFieldClsCompliant): Extracted code from
6848 VerifyClsCompliance descendant customization.
6849 (FixedField): New class handles fixed buffer fields.
6850 (FixedFieldExternal): Keeps information about imported fixed
6852 (IFixedField): Make access to internal or external fixed buffer
6855 * cs-parser.jay: Add fixed buffer parsing.
6857 * ecore.cs (FieldExpr.Emit): Add special emit case for fixed
6860 * expression.cs (Indirection): Extended implementation to accept
6862 (PointerArithmetic.Emit): Get element from fixed buffer as well.
6863 (ElementAccess.MakePointerAccess): Get type as parameter.
6864 (DoResolve): Add fixed buffer field expression conversion.
6865 (DoResolveLValue): Ditto.
6866 (FixedBufferPtr): New class. Moved most of original ArrayPtr.
6867 (ArrayPtr): Derives from FixedBufferPtr.
6868 (ArrayPtr.Emit): Add extra emit for array elements.
6870 * flowanalysis.cs.cs (StructInfo): Use FieldMember.
6872 * rootcontext.cs (CloseTypes): Emit CompilerGenerated attribute
6873 for compiler generated types.
6874 (RegisterCompilerGeneratedType): Renamed from RegisterHelperClass.
6876 * statement.cs (Fixed): Refactored to be easier add fixed buffer
6877 and consume less memory.
6878 (Fixed.Resolve): Add fixed buffer case.
6880 * typemanager.cs (compiler_generated_attr_ctor,
6881 fixed_buffer_attr_ctor): Add new 2.0 compiler attributes.
6882 (HasElementType): Add our own implementation to work on every
6885 2005-02-11 Miguel de Icaza <miguel@novell.com>
6887 * anonymous.cs (CaptureContext): Track whether `this' has been
6890 * expression.cs (This.ResolveBase): Call CaptureThis. Before we
6891 only captured `this' if it was implicitly done (instance
6892 methods/variables were used).
6894 * codegen.cs (EmitContext.CaptureThis): New method to flag that
6895 `this' must be captured.
6897 2005-01-30 Miguel de Icaza <miguel@novell.com>
6899 * anonymous.cs (CreateMethodHost): If there Scope.ScopeTypeBuilder
6900 is null it means that there has been no need to capture anything,
6901 so we just create a sibling.
6903 Renamed `EmitHelperClasses' to `EmitAnonymousHelperClasses'
6905 Just a partial fix. The other half is fairly elusive.
6907 2005-02-10 Raja R Harinath <rharinath@novell.com>
6909 Fix #52586, cs0121-4.cs.
6910 * decl.cs (MemberCache.DeepCopy): Rename from SetupCache. Take
6911 and return a hashtable.
6912 (MemberCache.ClearDeclaredOnly): New.
6913 (MemberCache.MemberCache): Update to change. Make a deep copy of
6914 the method_hash of a base type too.
6915 (MemberCache.AddMethods): Adapt to having a deep copy of the base
6916 type methods. Overwrite entries with the same MethodHandle so
6917 that the ReflectedType is correct. The process leaves in base
6918 virtual functions and their overrides as distinct entries.
6919 (CacheEntry): Now a class instead of a struct. It shouldn't alter
6920 matters since it was boxed in a ArrayList before.
6921 (CacheEntry.Member, CacheEntry.EntryType): Remove 'readonly'
6923 * expression.cs (Invocation.BetterFunction): Simplify. Handle the
6924 case of a virtual function and its override (choose the overload
6926 (Invocation.OverloadResolve): Avoid 'override' members during
6927 'applicable_type' calculation.
6929 2005-03-28 Raja R Harinath <rharinath@novell.com>
6931 * typemanager.cs (TypeHandle.BaseType): Make into an IMemberContainer.
6932 (TypeHandle.TypeHandle): Use LookupMemberCache rather than
6933 GetTypeHandle. It is possible for a reflected type to derive from
6934 a TypeBuilder (e.g., int[] derives from the TypeBuilder
6935 System.Array during mscorlib compilation).
6936 * decl.cs (MemberCache.MemberCache): If the base cache doesn't
6937 contain a method_hash, don't create one either. Don't create a
6938 deep copy of the base cache's method_hash.
6939 (MemberCache.SetupCache): Rename back from DeepCopy.
6940 (MemberCache.AddMethods): Rewrite, now that method_hash isn't
6941 already initialized. If we see an override function, add its
6942 underlying base virtual function to the member_hash too.
6944 2005-02-09 Raja R Harinath <rharinath@novell.com>
6946 Combine two near-redundant caches.
6947 * typemanager.cs (method_params): Rename from method_internal_params.
6948 (TypeManager.GetParameterData): New. Replace
6949 Invocation.GetParameterData.
6950 (TypeManager.LookupParametersByBuilder): Remove.
6951 * expression.cs (Invocation.method_parameter_cache): Remove.
6952 (Invocation.GetParameterData): Remove.
6954 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
6957 2005-02-08 Raja R Harinath <rharinath@novell.com>
6960 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
6961 TypeManager.multicast_delegate_type is null, resolve it by looking
6962 up "System.MulticastDelegate".
6963 * rootcontext.cs (RootContext.ResolveCore): Simplify.
6965 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
6966 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
6967 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
6970 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
6971 (LabeledStatement.AddReference): New. Set 'referenced'.
6972 (Goto.Resolve): Use it.
6974 2005-02-05 John Luke <john.luke@gmail.com>
6976 * driver.cs: remove duplicate -doc line in Usage ()
6978 2005-02-04 Raja R Harinath <rharinath@novell.com>
6980 * location.cs (Location.AddFile): Fix CS2002 error report.
6982 2005-02-02 Martin Baulig <martin@ximian.com>
6984 * delegate.cs (Delegate.DefineType): Report an internal error if
6985 TypeManager.multicast_delegate_type is null. See bug #72015 for
6988 2005-02-02 Raja R Harinath <rharinath@novell.com>
6990 Fix a crasher in a variant of #31984.
6991 * const.cs (Constant.CheckBase): New override that defers the
6992 new-or-override check in case the base type hasn't been populated
6994 (Constant.Define): Ensure the new-or-override check is performed.
6996 2005-02-01 Duncan Mak <duncan@ximian.com>
6998 * const.cs (LookupConstantValue): Check that `ce' is not null
6999 before calling GetValue ().
7001 2005-02-01 Raja R Harinath <rharinath@novell.com>
7003 Fix test-334.cs (#69519).
7004 * cs-parser.jay (using_alias_directive): Pass in an expression to
7005 NamespaceEntry.UsingAlias.
7006 (using_namespace_directive): Pass in an expression to
7007 NamespaceEntry.Using.
7008 (namespace_name): Don't flatten to a string.
7009 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
7010 (NamespaceEntry.AliasEntry.Resolve): Lookup using
7012 (NamespaceEntry.UsingEntry): Likewise.
7013 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
7015 (NamespaceEntry.LookupForUsing): Remove.
7016 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
7018 (NamespaceEntry.Lookup): Remove support for dotted names.
7020 2005-02-01 Raja R Harinath <rharinath@novell.com>
7022 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
7024 (NamespaceEntry.ImplicitParent): Compute on demand.
7025 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
7026 parallels the current.
7027 (NamespaceEntry.LookupForUsing): Use it.
7028 (NamespaceEntry.Lookup): If the current namespace-entry is
7029 implicit, don't search aliases and using tables.
7031 2005-02-01 Raja R Harinath <rharinath@novell.com>
7034 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
7036 (TypeContainer.BaseCache): Compute on demand.
7037 (TypeContainer.FindMembers): Define constants and types if they're
7038 not already created.
7039 (FieldMember.Define): Move resetting of ec.InUnsafe before error
7041 * const.cs (Constant.Define): Make idempotent.
7043 2005-01-29 Miguel de Icaza <miguel@novell.com>
7045 * pending.cs: Produce better code (no nops produced by using Ldarg
7048 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
7049 i - 1' it should be arg + 1.
7053 2005-01-28 Raja R Harinath <rharinath@novell.com>
7055 * attribute.cs (Attribute.CheckAttributeType): Make private
7057 (Attribute.ResolveType): Make virtual.
7058 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
7059 handling of RootContext.Tree.Types.
7061 2005-01-27 Raja R Harinath <rharinath@novell.com>
7063 Update attribute-handling to use the SimpleName/MemberAccess
7065 * cs-parser.jay (attribute): Pass in an expression to the
7066 constructors of Attribute and GlobalAttribute.
7067 * attribute.cs (Attribute): Take an expression for the name.
7068 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
7069 passed in attribute name expression.
7070 (Attribute.CheckAttributeType): Use it.
7071 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
7072 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
7073 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
7074 argument to prevent error messages if the lookup fails.
7076 2005-01-27 Marek Safar <marek.safar@seznam.cz>
7078 * expression.cs (Indirection): Implemented IVariable interface
7079 to support indirection in AddressOf operator.
7080 (PointerArithmetic.Emit): Add optimalization for case where
7081 result can be precomputed.
7083 2005-01-26 Martin Baulig <martin@ximian.com>
7085 * class.cs (TypeContainer.AttributeTargets): Return the correct
7086 AttributeTargets depending on our `Kind' instead of throwing an
7087 exception; fixes #71632.
7089 2005-01-26 Marek Safar <marek.safar@seznam.cz>
7092 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
7095 2005-03-17 Martin Baulig <martin@ximian.com>
7097 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
7098 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
7100 2005-03-17 Martin Baulig <martin@ximian.com>
7102 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
7103 to bool so we can return an error condition.
7104 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
7107 2005-03-17 Martin Baulig <martin@ximian.com>
7109 * generic.cs (TypeMananager.IsIEnumerable): New public method.
7111 * convert.cs (Convert.ImplicitReferenceConversion(Exists)): Allow
7112 converting from an array-type of T to `IEnumerable<T>'.
7114 2005-03-16 Martin Baulig <martin@ximian.com>
7116 * generic.cs (Nullable.Unwrap): Implement IAssignMethod.
7117 (Nullable.LiftedUnaryMutator): New public class.
7119 * expression.cs (UnaryMutator.DoResolve): Added support for
7122 2005-03-14 Martin Baulig <martin@ximian.com>
7124 * generic.cs (Nullable.NullCoalescingOperator): Implemented.
7126 2005-03-14 Martin Baulig <martin@ximian.com>
7128 * generic.cs (Nullable.LiftedBinaryOperator): Added support for
7129 the comparision operators `<', `>', `<=' and `>='.
7131 2005-03-13 Martin Baulig <martin@ximian.com>
7134 (Nullable.NullLiteral): Renamed to `Nullable.NullableLiteral' to
7135 avoid confusion with the `NullLiteral'.
7136 (Nullable.LiftedBinaryOperator): Correctly implement `==' and '!='.
7138 2005-03-13 Martin Baulig <martin@ximian.com>
7140 * expression.cs (Binary.ResolveOperator): For `==' and `!=', allow
7141 comparing arbitrary types with the null literal.
7143 2005-03-13 Martin Baulig <martin@ximian.com>
7145 * generic.cs (Nullable.LiftedBinaryOperator): Add support for the
7146 boolean operators '&&', '||', '&' and '|'.
7147 (Nullable.OperatorTrueOrFalse): New public class.
7149 * ecore.cs (Expression.GetOperatorTrue/False): Return an `Expression'
7150 instead of a `StaticCallExpr'; added support for nullables.
7152 2005-03-10 Martin Baulig <martin@ximian.com>
7155 (ArrayAccess.EmitDynamicInitializers): Use `etype.IsValueType'
7156 rather than `etype.IsSubclassOf (TypeManager.value_type)'.
7158 2005-03-07 Martin Baulig <martin@ximian.com>
7160 * generic.cs (Nullable.Unwrap): Implement IMemoryLocation and make
7161 it work if `expr' is not an IMemoryLocation.
7162 (Nullable.Lifted): Implement IMemoryLocation.
7163 (Nullable.LiftedConversion.ResolveUnderlying): Use the correct
7166 2005-03-05 Martin Baulig <martin@ximian.com>
7168 * generic.cs (Nullable.Unwrap, Wrap): New protected classes.
7169 (Nullable.Lifted): New abstract class; rewrote the lifted conversions.
7170 (Nullable): Added support for lifted unary and binary operators.
7172 * expression.cs (Unary.DoResolve): Added support for nullable types.
7173 (Binary.DoResolve): Likewise.
7174 (Conditional.DoResolve): Likewise.
7176 2005-03-02 Martin Baulig <martin@ximian.com>
7178 * decl.cs (DeclSpace.SetParameterInfo): Make this virtual.
7180 * class.cs (ClassPart.SetParameterInfo): Override this.
7181 (PartialContainer.SetParameterInfo): Override this.
7182 (TypeContainer.CheckConstraints): New protected method.
7183 (PartialContainer.CheckConstraints): Override this and check
7184 whether the same contraints were specified in all parts of a
7185 partial generic type definition.
7186 (PartialContainer.UpdateConstraints): New public method.
7188 * generic.cs (TypeParameter.UpdateConstraints): New public method.
7190 2005-03-02 Martin Baulig <martin@ximian.com>
7192 Committing a patch from Carlos Alberto Cortez to fix #72887.
7194 * convert.cs (Convert.ExplicitReferenceConversionExists): Allow
7195 casts from `T []' to `int []'.
7197 2005-03-02 Martin Baulig <martin@ximian.com>
7199 * generic.cs (TypeManager.IsEqual): Make this symmetric.
7201 * expression.cs (Binary.ResolveOperator): When resolving a
7202 BinaryDelegate, use `TypeManager.IsEqual (l, r)' rather than just
7203 `=='. Fixes #71866. See gen-127.cs.
7205 2005-03-02 Martin Baulig <martin@ximian.com>
7207 * class.cs (TypeContainer.DoDefineMembers): We also need a default
7208 static constructor in static classes.
7210 2005-03-02 Martin Baulig <martin@ximian.com>
7213 (NullableType.Name, NullableType.FullName): Add a "?" to the name.
7214 (Nullable.LiftedConversion): Added support for user-defined
7217 * cs-tokenizer.cs (Tokenizer.PutbackCloseParens): New public method.
7219 * cs-parser.jay: Use ComposedCast everywhere instead of
7220 NullableType, so we don't need to check for NullableType
7222 (conditional_expression): Added `INTERR CLOSE_PARENS' rule for the
7223 case where we'll be resolved into a `parenthesized_expression_0'
7227 (Convert.UserDefinedConversion): Added nullable conversions.
7229 2005-02-28 Martin Baulig <martin@ximian.com>
7231 * generic.cs (TypeManager.IsNullableType): New static method.
7232 (Nullable): New abstract class.
7233 (Nullable.NullLiteral): New public class.
7234 (Nullable.LiftedConversion): New public class.
7236 * cs-parser.jay (non_expression_type): Changed `builtin_types' to
7237 `builtin_types opt_nullable'.
7240 (Convert.ImplicitConversionStandard): Added nullable conversions.
7241 (Convert.ExplicitConversionStandard): Likewise.
7242 (Convert.ExplicitConversion): Likewise.
7244 2005-02-26 Martin Baulig <martin@ximian.com>
7246 * expression.cs (ComposedCast.DoResolveAsTypeStep): Allow `dim' to
7247 begin with a "?", for instance "?[]". Don't do a type lookup if
7250 2005-02-25 Martin Baulig <martin@ximian.com>
7252 The first part of Nullable Types :-)
7254 * generic.cs (NullableType): New public class.
7255 (NullCoalescingOperator): New public class.
7256 (TypeArguments.Resolve): Add a CS0306 check.
7258 * cs-parser.jay (opt_error_modifier): Removed, this was unused.
7259 (opt_nullable): New rule.
7260 (type): Added `opt_nullable' to `namespace_or_type_name',
7261 `builtin_types' and `pointer_type'.
7262 (array_type): Added `opt_nullable'.
7263 (opt_rank_specifier_or_nullable): New rule; this is the
7264 combination of `opt_rank_specifier' and `opt_nullable'.
7265 (opt_error): New rule; catch errors here.
7266 (nullable_type_or_conditional): New rule; we use this to check for
7267 nullable and still detect the conditional operator.
7268 (local_variable_type): Use `opt_rank_specifier_or_nullable'
7269 instead `opt_rank_specifier'.
7271 * expression.cs (ComposedCast.DoResolveAsTypeStep): Added support
7274 2005-02-24 Martin Baulig <martin@ximian.com>
7276 * README, README.Changes: Removed; they're old and obsolete.
7278 2005-02-22 Martin Baulig <martin@ximian.com>
7280 * generic.cs (TypeParameter.Resolve): If resolving the constraints
7281 returned an error, set `constraints' to null to avoid a crash
7283 (TypeParameter.ResolveType): Likewise.
7285 2005-02-22 Martin Baulig <martin@ximian.com>
7288 (Constraints.ResolveTypes): Protect against being called twice.
7289 (Constraints.CheckInterfaceMethod): Don't call ResolveTypes().
7290 (TypeParameter.ResolveType): New public method; calls
7291 constraints.ResolveTypes().
7292 (TypeParameter.DefineType): Moved constraints.ResolveType() out
7293 into the new ResolveType().
7294 (GenericMethod.Define): Call ResolveType() on all our
7297 2005-02-21 Martin Baulig <martin@ximian.com>
7300 (TypeManager.generic_nullable_type): New static public field.
7301 (TypeManager.InitGenericCoreType): Lookup "System.Nullable`1".
7304 (RootContext.ResolveCore): Resolve "System.Nullable`1".
7306 2005-02-15 Martin Baulig <martin@ximian.com>
7308 * generic.cs (ConstructedType.Constraints): Correctly check
7309 constraints if the argument type is a type parameter; fixes
7312 2005-02-02 Martin Baulig <martin@ximian.com>
7314 * delegate.cs (Delegate.DefineType): Report an internal error if
7315 TypeManager.multicast_delegate_type is null. See bug #72015 for
7318 2005-01-29 Miguel de Icaza <miguel@novell.com>
7320 * pending.cs: Produce better code (no nops produced by using Ldarg
7323 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
7324 i - 1' it should be arg + 1.
7328 2005-01-26 Martin Baulig <martin@ximian.com>
7330 * cs-parser.jay (indexer_declarator): Don't report an error if we
7331 have type parameters since we can be an explicit interface
7332 implementation; fixes #71449.
7334 2005-01-26 Martin Baulig <martin@ximian.com>
7336 * class.cs (TypeContainer.AttributeTargets): Return the correct
7337 AttributeTargets depending on our `Kind' instead of throwing an
7338 exception; fixes #71632.
7340 2005-01-26 Martin Baulig <martin@ximian.com>
7342 * delegate.cs (Delegate.DefineType): Correctly define our type
7343 parameters. Fixes #71483.
7345 2005-01-25 Raja R Harinath <rharinath@novell.com>
7348 * expression.cs (MemberAccess.DoResolve): Don't complain with
7349 cs0572 when the LHS of a member access has identical name and type
7352 2005-01-25 Marek Safar <marek.safar@seznam.cz>
7355 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
7357 Create custom PermissionSet only for PermissionSetAttribute.
7359 2005-01-24 Marek Safar <marek.safar@seznam.cz>
7362 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
7363 delegates in static class.
7365 2005-01-24 Martin Baulig <martin@ximian.com>
7367 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
7368 merging an implicit block, just use its reachability.
7370 * statement.cs (Block.Resolve): Make the unreachable code check
7371 work wrt. implicit blocks; see test-337 from #63842.
7373 2005-01-21 Alp Toker <alp@atoker.com>
7375 * cs-parser.jay: destructor_declaration's container is PartialContainer
7376 not Class when partial types are used, so use Kind prop instead of
7379 2005-01-22 Miguel de Icaza <miguel@ximian.com>
7381 * cs-parser.jay: Improve error reporting when an interface
7384 2005-01-20 Dick Porter <dick@ximian.com>
7386 * support.cs: SeekableStreamReader fix from Sandor Dobos
7387 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
7388 chars are read. Fixes bug 70369.
7390 2005-01-20 Raja R Harinath <rharinath@novell.com>
7392 * cs-parser.jay (catch_clause): Simplify current_block handling
7395 2005-01-17 Miguel de Icaza <miguel@ximian.com>
7397 * convert.cs (ImplicitStandardConversionExists): Synchronize the
7398 code with ImplicitStandardConversion to handle the implicit
7399 conversion of method groups into valid delegate invocations.
7401 The problem is that in parameter handling we were using this code
7402 path. Fixes bug #64698
7404 2005-01-19 Raja R Harinath <rharinath@novell.com>
7406 * cs-parser.jay: Fix several infelicities.
7407 - Avoid assigning to the parser value stack. Code like
7408 '$3 = null' is unclean. Synthesize a value for the code block
7410 - Avoid using oob_stack for storing location information. Use ...
7411 (_mark_): ... this. New (empty) rule. Saves the current location
7413 (foreach_statement): Avoid using oob_stack for current_block
7414 handling. Use technique used in for_statement and
7415 using_statement. Synthesize a value for the code block to store
7416 additional intermediate information.
7418 2005-01-13 Miguel de Icaza <miguel@ximian.com>
7420 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
7421 of a different type is only allowed to private fields of a
7422 containing type, not on fields of a base class.
7424 See test-174.cs and error cs0122-9.cs
7426 2005-01-13 Raja R Harinath <rharinath@novell.com>
7428 Fix test-335.cs (bug #58126).
7429 * cs-parser.jay (argument): Split out non-expression parts of the
7430 rule into 'non_simple_argument'.
7431 (invocation_expression): Support parenthesized invocations with
7432 multiple arguments, and with single non-simple arguments.
7434 2005-01-13 Raja R Harinath <rharinath@novell.com>
7436 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
7439 2005-01-12 Raja R Harinath <rharinath@novell.com>
7441 Fix cs0038-1.cs, cs1640-6.cs.
7442 * ecore.cs (Expression.Resolve): Remove special-case for
7443 SimpleName in error-handling.
7444 (Expression.almostMatchedMembers): Relax access permission to
7446 (Expression.MemberLookupFailed): Handle duplicates in
7447 almostMatchedMembers list.
7448 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
7449 * expression.cs (New.DoResolve): Report CS1540 for more cases.
7450 * typemanager.cs (GetFullNameSignature): Use the MethodBase
7451 overload if the passed in MemberInfo is a MethodBase.
7453 2005-01-25 Martin Baulig <martin@ximian.com>
7456 (DocUtil.emptyParamList): Removed; use `Type.EmptyTypes' instead.
7458 2005-01-12 Marek Safar <marek.safar@seznam.cz>
7461 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
7462 for non-CAS & merge permission sets properly.
7464 2005-01-11 Raja R Harinath <rharinath@novell.com>
7466 Improve standard-compliance of simple name and member access
7467 resolution. Fixes bugs #52697, #57200, #67520, #69519.
7468 * ecore.cs (FullNamedExpression): New abstract base class
7469 for Namespaces and TypeExpressions.
7470 (ResolveFlags.SimpleName): Remove.
7471 (SimpleName): Remove support for dotted names.
7472 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
7473 DeclSpace.FindType and DeclSpace.LookupType.
7474 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
7475 (Expression.ExprClassName): Make member function.
7476 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
7477 a namespace. Remove creation of dotted "SimpleName"s.
7478 (MemberAccess.DoResolve): Likewise.
7479 * decl.cs (DeclSpace.Cache): Make private.
7480 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
7481 (DeclSpace.FindType): Update.
7482 (DeclSpace.LookupType): Move here from RootContext. Return a
7483 FullNamedExpression.
7484 * namespace.cs (Namespace): Derive from FullNamedExpression
7485 so that it can be part of expression resolution.
7486 (Namespace.Lookup): Return an FullNamedExpression.
7487 (NamespaceEntry.LookupAlias): Lookup aliases only in current
7489 * rootcontext.cs (NamespaceLookup): Remove.
7490 (LookupType): Move to DeclSpace.
7491 * attribute.cs (CheckAttributeType): Update.
7492 * doc.cs (FindDocumentedType): Remove allowAlias argument.
7493 (FindDocumentedTypeNonArray): Likewise.
7495 2005-01-11 Raja R Harinath <rharinath@novell.com>
7497 Fix cs0509.cs, cs1632.cs.
7498 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
7499 is the same as IsInterface.
7500 (TypeContainer.GetClassBases): Likewise.
7501 * statement.cs (LabeledStatement.ig): New field.
7502 (LabeledStatement.LabelTarget): Save ILGenerator which created the
7504 (LabeledStatement.DoEmit): Check that the label was created with
7505 the same ILGenerator.
7507 2005-01-10 Marek Safar <marek.safar@seznam.cz>
7510 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
7511 accessors to its properties.
7513 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
7514 from accessors to property.
7516 2005-01-10 Marek Safar <marek.safar@seznam.cz>
7519 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
7522 2005-01-08 Miguel de Icaza <miguel@ximian.com>
7524 * attribute.cs: Check for null and empty strings.
7526 I have lost another battle to Paolo.
7528 2005-01-07 Marek Safar <marek.safar@seznam.cz>
7531 * class.cs (PropertyMethod): Set Parent field in ctors.
7532 (SetMethod.InternalParameters): Add unsafe switch hack.
7533 Override MarkForDuplicationCheck where it is appropriate.
7535 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
7536 It says whether container allows members with the same name.
7538 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
7539 Removed is_method parameter.
7541 2005-01-06 Duncan Mak <duncan@ximian.com>
7543 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
7544 because the previous change led to incorrect reporting of CS1032
7545 ("Cannot define/undefine preprocessor symbols after first token in
7546 file"). Instead of using `tokens_seen' as the only flag that
7547 triggers CS1040, introduce `comments_seen'. This new flag is used
7548 to signify having seen comments on the current line, so it is
7549 unset after a newline.
7551 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
7553 * doc.cs : When searching for a type, find nested type too.
7554 This fixes bug #71040.
7556 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
7559 - Warn missing member comment on those classes which also does not
7560 have doc comments. Fixed bug #71041.
7561 - Don't warn missing doc comment on default constructor.
7564 2005-01-06 Duncan Mak <duncan@ximian.com>
7566 * cs-tokenizer.cs (xtoken): After handling traditional C-style
7567 comments, set `tokens_seen' to true. This allows us to detect
7568 misplaced preprocessor directives (i.e. not at the beginning of
7569 the a line, nor after whitespaces). In that case, report error
7570 CS1040. This fixes bug #56460.
7572 * cs-parser.jay (interface_member_declaration): Add checks for
7573 IsExplicitImpl, and report CS0541 error if an interface member is
7574 defined as an explicit interface declaration.
7576 2005-01-06 Marek Safar <marek.safar@seznam.cz>
7579 * class.cs (PropertyMethod): Set Parent field in ctors.
7580 (SetMethod.InternalParameters): Add unsafe switch hack.
7582 * decl.cs (MemberCore.Parent): Cannot be readonly.
7584 2005-01-06 Raja R Harinath <rharinath@novell.com>
7586 * decl.cs (DeclSpace.ResolveType): Remove.
7587 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
7588 Merge in code from ...
7589 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
7590 * class.cs, enum.cs: Update to changes.
7592 2005-01-06 Miguel de Icaza <miguel@ximian.com>
7594 * anonymous.cs: Ensure that we init the scope of our parent if it
7595 has not been initialized yet.
7597 2004-12-30 Duncan Mak <duncan@ximian.com>
7599 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
7600 if field.FieldBuilder is null. Fixes #70758.
7602 * convert.cs: Fixed some typos and updated some of the comments.
7603 (ImplicitStandardConversionExists):
7604 (TryImplicitIntConversion): If `target_type' is an interface and
7605 the type of `ic' implements this interface, return true or a new
7606 BoxedCast instead of null. This fixes #70468.
7608 2004-12-29 Duncan Mak <duncan@ximian.com>
7610 * expression.cs (Argument.Emit): Check that Expr is
7611 IMemoryLocation before casting to it, and report CS1510 otherwise.
7615 2004-12-21 Ben Maurer <bmaurer@ximian.com>
7617 * statement.cs (Block.ThisVariable): remove the recursion here, to
7618 make the --profile more sane.
7620 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
7622 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
7623 assembly, by JB Evain.
7625 2004-12-17 Raja R Harinath <rharinath@novell.com>
7627 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
7628 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
7629 "parent" refers to enclosing type/class. "base" refers to superclass.
7631 2004-12-17 Raja R Harinath <rharinath@novell.com>
7633 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
7634 Ensure that we only have GlobalAttributes.
7635 * attribute.cs (Attribute.Emit): Make non-virtual.
7636 (GlobalAttribute.Emit): Remove.
7637 (Attribute.Resolve): Make virtual.
7638 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
7639 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
7640 the argument. Don't create one.
7641 (Attribute.GetObsoleteAttribute): Likewise.
7642 (Attribute.GetClsCompliantAttributeValue): Likewise.
7643 * class.cs, decl.cs: Update to changes.
7645 2004-12-17 Marek Safar <marek.safar@seznam.cz>
7647 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
7649 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
7651 * statement.cs (Foreach.Resolve): Add error 186 report.
7653 2004-12-16 Marek Safar <marek.safar@seznam.cz>
7655 * expression.cs (Conditional.DoResolve): Add warning 429.
7657 * statement.cs (If.Resolve): Add warning 665.
7659 2004-12-16 Raja R Harinath <rharinath@novell.com>
7661 New invariant: RootContext.Tree.Types.NamespaceEntry == null
7662 except when in the parser, and in GlobalAttribute.
7663 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
7664 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
7665 RootContext.Tree.Types.NamespaceEntry once work is done.
7666 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
7667 and resets RootContext.Tree.Types.NamespaceEntry.
7669 2004-12-15 Marek Safar <marek.safar@seznam.cz>
7671 * cs-parser.jay: Don't create a block for every variable.
7673 2004-12-14 Miguel de Icaza <miguel@ximian.com>
7675 * location.cs: Provide extra information.
7677 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
7678 variables from the captured environment, it is the ldarg_0.
7680 2004-12-14 Marek Safar <marek.safar@seznam.cz>
7682 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
7685 * class.cs: Changed warning level for 169 to avoid developer
7686 displeasure from warning flooding. It will be changed back when they
7687 fix most of current BCL warnings.
7689 * RootContext.cs: Pushed default WarningLevel to 3.
7691 * statement.cs: Removed unused variable.
7693 2004-12-14 Marek Safar <marek.safar@seznam.cz>
7695 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
7696 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
7697 Add error 502 report.
7698 (StaticClass.DefineType): Add error 441 report.
7699 (Class.AllowedModifiersProp): New virtual property as temporary
7700 extension to AllowedModifiers.
7701 (Class.DefineType): Add error 418 report. Moved ModFlags check here
7702 to share implementation with StaticClass and don't call virtual
7705 * driver.cs (MainDriver): Add error 1558 test.
7707 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
7708 report. Moved error 36 test here.
7710 * statement.cs (Throw.Resolve): Add error 724 report.
7712 * typemanager.cs: Add out_attribute_type core type.
7714 2004-12-13 Marek Safar <marek.safar@seznam.cz>
7716 * class.cs (TypeContainer.VerifyClsCompliance): Add error
7718 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
7720 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
7723 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
7725 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
7726 Add error 3023 report.
7727 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
7729 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
7732 2004-12-12 John Luke <john.luke@gmail.com>
7734 * driver.cs (AddArgs): take -- into account when
7735 adding arguments, fixes bug 65710
7737 2004-12-12 Martin Baulig <martin@ximian.com>
7739 * expression.cs (Unary.TryReduceNegative): Added support for
7740 SByteConstant and ByteConstant.
7741 (Unary.Reduce): Check error values from TryReduceNegative().
7743 2004-12-10 Marek Safar <marek.safar@seznam.cz>
7745 * attributes.cs (Attribute.Resolve): Avoid multiple error report
7746 and report exception as error 182.
7748 2004-12-10 Raja R Harinath <rharinath@novell.com>
7750 * driver.cs (Main): Fix message when there are warnings.
7752 2004-12-09 Miguel de Icaza <miguel@ximian.com>
7754 * delegate.cs: Fixed my fix from yesterday, sorry about that.
7756 2004-12-09 Marek Safar <marek.safar@seznam.cz>
7758 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
7759 Reduced number of warnings.
7761 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
7763 2004-12-08 Miguel de Icaza <miguel@ximian.com>
7765 * driver.cs: Removed message.
7767 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
7769 2004-12-08 <vargaz@freemail.hu>
7771 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
7773 2004-12-08 Martin Baulig <martin@ximian.com>
7775 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
7776 instead of a CS3002 for properties and indexer.
7778 2004-12-08 Martin Baulig <martin@ximian.com>
7780 * decl.cs (MemberName.ToString): Make this work again.
7782 2004-12-08 Marek Safar <marek.safar@seznam.cz>
7784 * attribute.cs (Resolve): Add error 591 detection.
7786 * class.cs (FieldMember.Define): Add error 1547 detection.
7787 (Indexer.Define): Add error 620 detection.
7788 (Operator.Define): Add error 590 detection.
7790 * ecore.cs: Missing argument for error 79.
7792 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
7795 2004-12-07 Marek Safar <marek.safar@seznam.cz>
7798 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
7801 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
7803 * cs-parser.jay : handle doc comments on implicit/explicit operators.
7804 Some operator comments were suppressed.
7805 * doc.cs : Implicit/explicit operator name in doc comments are like
7806 "op_Explicit(type)~returnType", so added suffix handling.
7808 2005-01-21 Alp Toker <alp@atoker.com>
7810 * cs-parser.jay: destructor_declaration's container is PartialContainer
7811 not Class when partial types are used, so use Kind prop instead of 'is'.
7813 2004-12-12 Martin Baulig <martin@ximian.com>
7815 * expression.cs (Unary.TryReduceNegative): Added support for
7816 SByteConstant and ByteConstant.
7817 (Unary.Reduce): Check error values from TryReduceNegative().
7819 2004-12-11 Martin Baulig <martin@ximian.com>
7821 * support.cs (ReflectionParameters.ParameterName): If we have a
7822 `gpd', call `ParameterName' on it.
7824 * parameter.cs (Parameter.GetParameterAttributes): New static method.
7826 * pending.cs (PendingImplementation.DefineProxy): Call
7827 DefineParameter() for all of the MethodBuilder's arguments.
7829 2004-12-09 Martin Baulig <martin@ximian.com>
7831 * doc.cs (DocUtil): Make this a static class.
7833 2004-12-09 Martin Baulig <martin@ximian.com>
7835 * expression.cs (Invocation.InferType): Moved the type inference
7836 implementation into TypeManager.
7838 * generics.cs (TypeManager): Moved the type inference
7839 implementation here.
7841 2004-12-09 Martin Baulig <martin@ximian.com>
7843 * typemanager.cs (TypeManager): Make this a partial class.
7846 (TypeManager): Move the generics part of `TypeManager' here.
7848 2004-12-08 Martin Baulig <martin@ximian.com>
7850 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
7851 instead of a CS3002 for properties and indexer. Added CS3024
7852 check for generic interfaces.
7854 * attributes.cs (AttributeTester.AnalyzeTypeCompliance): Generic
7855 instances are not CLS-compliant.
7857 2004-12-08 Martin Baulig <martin@ximian.com>
7860 (void_pointer_expression): New rule for `void*', `void**' etc.
7861 (typeof_expression): Add `void_pointer_expression'; fixes #66846.
7863 2004-12-08 Martin Baulig <martin@ximian.com>
7865 * expression.cs (Invocation.InferType): Removed the hack for
7866 MethodCore.MayUnify().
7868 * typemanager.cs (TypeManager.MayBecomeEqualGenericTypes): Make
7871 * class.cs (MethodCore.MayUnify): Use
7872 TypeManager.MayBecomeEqualGenericTypes().
7874 2004-12-08 Martin Baulig <martin@ximian.com>
7876 * expression.cs (Is.DoResolve, As.DoResolve): If we're a type
7877 parameter, box it. Fixes #69233.
7879 2004-12-08 Martin Baulig <martin@ximian.com>
7881 * generic.cs (ConstructedType.CheckConstraints): Valuetypes always
7882 have the ctor constraint. Fixes #68326.
7884 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
7886 * cs-parser.jay : interface comment was not consumed because of
7887 extra opt_semicolon before doc handling.
7889 2004-12-03 Raja R Harinath <rharinath@novell.com>
7891 Fix test-327.cs, test-328.cs, and put in early infrastructure
7892 for eventually fixing #52697.
7893 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
7894 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
7896 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
7897 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
7898 (VerifyUsing, error246): Update.
7899 * rootcontext.cs (RootContext.NamespaceLookup): Just use
7900 'NamespaceEntry.LookupNamespaceOrType'.
7902 2004-12-07 Martin Baulig <martin@ximian.com>
7904 * driver.cs: Call it "BETA SOFTWARE" :-)
7906 2004-12-06 Raja R Harinath <rharinath@novell.com>
7908 Fix crash on cs0657-17.cs.
7909 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
7910 Use RootContext.Tree.Types, not 'new RootTypes ()'.
7911 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
7912 the case where the NamespaceEntry gets overwritten.
7914 2004-12-06 Marek Safar <marek.safar@seznam.cz>
7916 Fixed #69195, #56821
7917 * ecore.cs (ResolveBoolean): Tiny refactoring.
7919 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
7920 of right expression resolving when left is false constant and
7921 operator is LogicalAnd OR true constant and operator is LogicalOr.
7923 * statement.cs (ResolveUnreachable): Always reports warning.
7925 2004-12-05 Miguel de Icaza <miguel@ximian.com>
7927 * class.cs: Distinguish between 1721 and 1722 (just a little help
7928 for the programmer).
7930 2004-12-03 Miguel de Icaza <miguel@ximian.com>
7932 * delegate.cs: Only allow this on new versions of the language.
7934 2004-12-02 Duncan Mak <duncan@ximian.com>
7936 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
7938 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
7939 here as a static method. Take an additional bool out parameter
7940 `must_do_cs1540_check' for signaling to InstanceResolve.
7941 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
7942 member field from PropertyExpr class and made it an argument of
7944 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
7945 check for MarshalByRefObject, and report CS0122 instead of CS1540.
7946 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
7947 and `remove_accessor' as well as InstanceResolve: report CS0122
7952 2004-12-07 Martin Baulig <martin@ximian.com>
7954 * decl.cs (DeclSpace.AddToContainer): Report correct errors CS0694
7955 and CS0692 where appropriate.
7957 2004-12-06 Martin Baulig <martin@ximian.com>
7959 * class.cs (MethodCore.MayUnify): Moved the CS0408 check here from
7960 IsDuplicateImplementation() and improved it.
7962 * expression.cs (Invocation.InferTypeArguments): Added
7963 `Type[] inferred_class_types' argument (for MethodCore.MayUnify)
7964 and removed the "ref" modifier from `infered_types'.
7966 * decl.cs (MemberName.ToString): Removed the exception.
7968 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
7970 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
7971 comments are allowed.
7973 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
7975 * delegate.cs: Add checks for subtypes in paramaters and return values
7976 in VerifyMethod () to add support for Covariance/Contravariance
7979 2004-12-02 Miguel de Icaza <miguel@ximian.com>
7981 * report.cs: Remove extra closing parenthesis.
7983 * convert.cs (Error_CannotImplicitConversion): If the name of the
7984 types are the same, provide some extra information.
7986 2004-12-02 Marek Safar <marek.safar@seznam.cz>
7989 * attribute.cs (Resolve): Improved implementation of params
7990 attribute arguments.
7992 * support.cs (ParameterData): Add HasParams to be faster.
7994 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
7996 all things are for /doc support:
7998 * doc.cs: new file that supports XML documentation generation.
7999 * mcs.exe.sources: added doc.cs.
8001 Handle /doc command line option.
8002 Report error 2006 instead of 5 for missing file name for /doc.
8003 Generate XML documentation when required, after type resolution.
8005 Added support for picking up documentation (/// and /** ... */),
8006 including a new XmlCommentState enumeration.
8008 Added lines to fill Documentation element for field, constant,
8009 property, indexer, method, constructor, destructor, operator, event
8010 and class, struct, interface, delegate, enum.
8011 Added lines to warn incorrect comment.
8013 Added Documentation field (passed only when /doc was specified).
8015 Added DocComment, DocCommentHeader, GenerateDocComment() and
8016 OnGenerateDocComment() and some supporting private members for
8017 /doc feature to MemberCore.
8019 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
8021 Added overriden DocCommentHeader.
8023 Added overriden DocCommentHeader and GenerateDocComment().
8025 2004-12-01 Miguel de Icaza <miguel@ximian.com>
8027 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
8028 unwrapping the enumeration values, chain to
8029 DoConstantNumericPromotions again, so we can promote things to the
8030 fundamental types (takes care of enums that are bytes, sbytes).
8034 2004-12-01 Raja R Harinath <rharinath@novell.com>
8036 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
8037 Fix long-standing bug in type-lookup. Use FindType instead of
8038 LookupType when ec.ResolvingTypeTree.
8039 (Attribute.ResolveType, Attribute.Resolve)
8040 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
8042 (Attributes.Search): Remove internal version. Update.
8043 (Attributes.SearchMulti): Update.
8044 (Attributes.GetClsCompliantAttribute): Remove.
8045 (Attributes.GetIndexerNameAttribute): Remove.
8046 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
8047 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
8048 * class.cs (Indexer.Define): Likewise.
8050 2004-12-01 Marek Safar <marek.safar@seznam.cz>
8053 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
8054 MarshallByReference members access.
8056 * expression.cs: Use CheckMarshallByRefAccess;
8057 Better error CS0197 message.
8059 * report.cs: Print whole related error message.
8061 2004-11-29 Marek Safar <marek.safar@seznam.cz>
8063 * class (GetClassBases): Better error 60 report.
8064 (EventProperty): Disabled warning 67 detection.
8066 2004-11-29 Marek Safar <marek.safar@seznam.cz>
8069 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
8071 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
8074 2004-11-29 Marek Safar <marek.safar@seznam.cz>
8077 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
8079 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
8081 2004-11-26 Miguel de Icaza <miguel@ximian.com>
8083 * attribute.cs (Attribute.Resolve): Refine error reporting and
8084 report a cs0117 if the identifier does not exist, to distinguish
8085 from 0617 which is a miss-use of the actual identifier.
8087 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
8088 between cs0070 and cs0079.
8090 * class.cs (MemberBase.DoDefine): When reporting a wrong
8091 accessibility level, we use MethodCore to compare instead of
8092 Method (this was a regression in some refactoring effort).
8094 So now we correctly report cs0056 again.
8096 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
8097 testing the target_type (which was known to be object_type) and
8098 not the source type (which is anonymous_method).
8100 Fixed reporting of error cs1660.
8102 * expression.cs (UserCast.Source): Expose the underlying cast.
8104 * statement.cs (Switch.SwitchGoverningType): Sort the list of
8105 allowed types to find a match to int32 first (most common).
8107 In addition, it ignores any ImplicitUserConversions that did an
8108 internal implicit conversion (as the switch statement allows only
8109 one integral conversion to exist).
8111 * class.cs (PartialContainer.Create): rename `name' to
8112 `member_name' for clarity. Then replace the string calls with a
8113 call to MemberName.GetPartialName, as now using
8114 MemberName.ToString is an error (this is due to the side effects
8115 it had, that were fixed in the past).
8117 This will restore the error reporting on a number of partial class
8118 errors that were missusing this (and getting an exception as a
8119 results, which is now just a plain textual warning, because
8120 yyparse debug output would crash otherwise).
8122 2004-11-26 Raja R Harinath <rharinath@novell.com>
8124 * Makefile (PROGRAM_INSTALL_DIR): Remove.
8126 2004-11-25 Ben Maurer <bmaurer@ximian.com>
8128 * rootcontext.cs (LookupType): Make sure to cache lookups that
8129 don't give us a negative result. This saves about 5% of corlib
8132 2004-11-25 Miguel de Icaza <miguel@ximian.com>
8134 * report.cs (AbstractMessage.Print): messages are sent to stderr
8136 * class.cs (TypeContainer.GetClassBases): It is an error to have a
8137 non-interface in the list of interfaces (at this point, either
8138 parent was properly set, or a base class is being listed in the
8139 interfaces section).
8141 This flags error 1722, and resolves the crash from bug 69259.
8143 2004-11-25 Ben Maurer <bmaurer@ximian.com>
8145 * statement.cs (Using.EmitExpressionFinally): make this work right
8146 for valuetypes. Fixes 69926.
8148 2004-11-25 Miguel de Icaza <miguel@ximian.com>
8150 * const.cs (Const.ChangeType): Cope with the "0 literal can be
8151 converted to an enum" here, before we try to change the underlying
8152 type. This code exists, but it is a different code path than the
8153 one used while encoding constants.
8155 (ImplicitReferenceConversionExists): In addition, resynchronized
8156 the code here, so it matches the same code in
8157 ImplicitReferenceConversionExists for the `from any class-type S
8158 to any interface-type T'.
8160 2004-11-25 Marek Safar <marek.safar@seznam.cz>
8162 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
8164 2004-11-24 Miguel de Icaza <miguel@ximian.com>
8166 * cs-parser.jay: Use verbosity accordingly.
8168 2004-11-24 Marek Safar <marek.safar@seznam.cz>
8170 * expression.cs (Unary.ResolveOperator): Do not report warning;
8171 AddressOf reads from variable.
8173 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
8175 2004-11-24 Marek Safar <marek.safar@seznam.cz>
8179 * attribute.cs (Attributable): Removed CheckTargets.
8180 (Attributes.Emit): Explicit attribute targets are tested here.
8182 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
8183 not enabled for interfaces.
8185 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
8186 (GetAssemblyName): Ouch next bug there.
8188 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
8190 * expression.cs: Error 275 added.
8192 2004-11-23 Marek Safar <marek.safar@seznam.cz>
8194 Fix bug #69177 (Implemented decimal constant support)
8196 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
8197 (BinaryFold): Add DecimalConstant.
8199 * const.cs (Define): Decimal constant
8201 (ChangeType): Add decimal type handling.
8202 (LookupConstantValue): Don't set value for decimal type but
8203 emit DecimalConstantAttribute. Needed for constant optimization.
8205 * constant.cs (ToDecimal): New method.
8206 (ConvertToDecimal): New method.
8207 (IntConstant): Implemented ConvertToDecimal.
8208 (DecimalConstant.Emit): Emit optimized version for decimals in
8211 * expression.cs (ResolveOperator): Changed order of constant
8212 reduction to work correctly with native types which have
8213 overloaded operators.
8214 (ResolveMemberAccess): Extract constant value from attribute
8217 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
8219 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
8220 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
8221 (ChangeType): Decimal is special.
8222 (TypeToCoreType): Add decimal type.
8224 2004-11-22 Marek Safar <marek.safar@seznam.cz>
8226 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
8229 2004-11-22 Marek Safar <marek.safar@seznam.cz>
8231 * class.cs (EventField.ApplyAttributeBuilder): Fix error
8234 2004-11-19 Marek Safar <marek.safar@seznam.cz>
8236 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
8238 * pending.cs (PendingImplementation): Grab only interfaces.
8240 2004-11-19 Marek Safar <marek.safar@seznam.cz>
8242 * statement.cs (ForeachHelperMethods): Add location member and
8243 error 202 detection.
8245 2004-11-18 Marek Safar <marek.safar@seznam.cz>
8247 * expression.cs (DoResolveBase): Fixed wrong warning for out
8250 2004-12-04 Martin Baulig <martin@ximian.com>
8252 * convert.cs (Convert.TypeParameter_to_Null): Use the constraints
8253 to check whether the conversion is ok.
8255 * typemanager.cs (TypeManager.GetTypeArguments): Just return
8256 `Type.EmptyTypes' if we're not a generic TypeContainer.
8258 2004-11-25 Miguel de Icaza <miguel@ximian.com>
8260 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
8261 old bug: when converting from the null literal to a pointer,
8262 return an EmptyCast, not the NullLiteral.
8264 This fixes #69921, the recent null_type changes probably made this
8267 2004-12-03 Martin Baulig <martin@ximian.com>
8269 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
8270 method as our child, call AnonymousMethod.Compatible() on it.
8272 2004-12-02 Miguel de Icaza <miguel@ximian.com>
8274 * class.cs (FieldBase): Use an unused bit field from the field to
8275 encode the `has_offset' property from the FieldMember. This saves
8276 a couple of Ks on bootstrap compilation.
8278 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
8279 method as our child, return the AnonymousMethod resolved
8282 * expression.cs (New.DoResolve): Allow return values from
8283 NewDelegate to also include AnonymousMethods.
8287 2004-11-29 Raja R Harinath <rharinath@novell.com>
8289 * decl.cs (MemberCore.MemberName): Remove readonly to fix an error
8291 * rootcontext.cs (ResolveCore::interfaces_first_stage): Add
8292 System.Runtime.InteropServices._Exception, since it's a base
8293 interface of the core type System.Exception in the net_2_0 profile.
8295 2004-11-27 Martin Baulig <martin@ximian.com>
8297 * ecore.cs (Expression.StoreFromPtr): Use `stobj' for generic parameters.
8299 2004-11-26 Raja R Harinath <rharinath@novell.com>
8301 * Makefile: Convert to use executable.make.
8302 * gmcs.exe.sources: New.
8304 2004-11-25 Martin Baulig <martin@ximian.com>
8306 * expression.cs (Invocation.InferType): Added support for byref types.
8308 2004-11-25 Martin Baulig <martin@ximian.com>
8310 * statement.cs (Foreach.FetchMethodMoveNext): Wrap `mi.ReturnType'
8311 in TypeManager.TypeToCoreType().
8313 2004-11-25 Martin Baulig <martin@ximian.com>
8315 * iterators.cs (Iterator.DoDefineMembers): Override and lookup the
8316 "Dispose" method from the `current_type'.
8317 (Iterator.EmitMoveNext): Use the `dispose_method' we looked up in
8318 DoDefineMembers() instead of using the MethodBuilder; this is
8319 required for generic iterators.
8321 * class.cs (TypeContainer.DoDefineMembers): Make this virtual.
8323 2004-11-24 Martin Baulig <martin@ximian.com>
8325 * ecore.cs (Expression.LoadFromPtr): Use `ldobj' for generic parameters.
8327 2004-11-20 Martin Baulig <martin@ximian.com>
8329 * expression.cs (Invocation.InferType): Correctly infer generic
8330 instances; see gen-103.cs.
8331 (Invocation.InferTypeArguments): If a generic method doesn't have
8332 any unbound type parameters, we don't need to infer anything.
8334 2004-11-19 Raja R Harinath <rharinath@novell.com>
8336 * Makefile (gmcs.exe): Update to new location of bootstrap mcs.exe.
8338 2004-11-17 Raja R Harinath <rharinath@novell.com>
8340 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
8341 (TypeHandle.GetMemberCache): New.
8342 (TypeHandle.TypeHandle): Update.
8343 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
8344 (TypeManager.LookupParentInterfacesCache):
8345 Rename from LookupInterfaceCache. Optimize slightly.
8346 (TypeManager.MemberLookup_FindMembers): Update.
8347 * decl.cs (MemberCache.MemberCache): Set Container to null in the
8349 (AddCacheContents): Rename from AddHashtable.
8350 * class.cs (TypeContainer.parent_container): Remove.
8351 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
8352 (TypeContainer.DoDefineMembers): Don't initialize it.
8353 Update to name changes.
8355 2004-11-17 Miguel de Icaza <miguel@ximian.com>
8357 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
8358 that factors the code to check access modifiers on override.
8360 (PropertyBase): Use the code here.
8362 Patch from Lluis S'anchez, fixes bug #69361.
8364 2004-11-15 Miguel de Icaza <miguel@ximian.com>
8366 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
8367 routine that is used to report the use of a captured variable
8368 whose address has been taken.
8370 There are two checks: one when variables are being captured and
8371 the other check is when the address of a variable is taken.
8373 (because an anonymous methods might be resolved before *or* after
8374 the address has been taken) and
8376 * expression.cs (Conditional.DoResolve): Remove the special
8377 casing that Martin added to trueExpr and falseExpr being both
8378 NullLiteral. We get the right behavior now just by introducing
8379 the null_type into the compiler.
8381 * convert.cs (ExplicitConversion): Change the code to use
8382 null_type instead of testing `expr is NullLiteral'.
8383 (ImplicitConversionStandard): use null_type too.
8384 (ImplicitReferenceConversionExists): use null_type too.
8385 (ImplicitReferenceConversion): use null_type too.
8387 * literal.cs: The type of `NullLiteral' is now null_type instead
8389 (Resolve): Set the type here.
8391 * typemanager.cs: Introduce null_type.
8393 2004-11-18 Martin Baulig <martin@ximian.com>
8396 (RootContext.LookupType): Return a `Type', not a `TypeExpr'.
8398 2004-11-18 Martin Baulig <martin@ximian.com>
8400 * ecore.cs (TypeExpr.DoResolveAsTypeStep): Make this protected.
8402 2004-11-18 Martin Baulig <martin@ximian.com>
8404 * generic.cs (Constraints.Resolve): Take an `EmitContext' instead
8405 of a `DeclSpace'. If one of our constraints is a `ConstructedType',
8406 call ResolveConstructedType() on it to resolve it without checking
8408 (Constraints.ResolveTypes): Check them here.
8409 (ConstructedType.DoResolveAsTypeStep): Fully resolve ourselves,
8410 but don't check constraints.
8411 (ConstructedType.ResolveAsTypeTerminal): Override this and also
8412 check constraints here.
8413 (ConstructedType.ResolveConstructedType): New public method. This
8414 is called from DoResolveAsTypeStep() and Constraints.Resolve() to
8415 resolve ourselves without checking constraints.
8417 * ecore.cs (Expression.ResolveAsTypeTerminal): Make this virtual.
8419 2004-11-18 Martin Baulig <martin@ximian.com>
8422 (DeclSpace.CurrentType): Changed type from `TypeExpr' to `Type'.
8424 * delegate.cs (Delegate.DefineType): Always create the EmitContext.
8426 2004-11-18 Martin Baulig <martin@ximian.com>
8428 * ecore.cs (TypeExpr.ResolveType): Removed.
8429 (Expression.ResolveAsTypeTerminal): We always return a fully
8430 resolved `TypeExpr', so we can just access its `Type'.
8432 * class.cs (TypeContainer.DefineType): Resolve `CurrentType' here.
8434 2004-11-17 Martin Baulig <martin@ximian.com>
8436 * ecore.cs (IAlias.Type): Replaced with ResolveAsType() to make
8437 sure we don't return any unresolved TypeExpr's.
8438 (TypeAliasExpression): The .ctor now takes an `IAlias' instead of
8440 (Expression.ResolveAsTypeTerminal): Make sure `te.Type != null'.
8442 * expression.cs (MemberAccess.ResolveAsTypeStep): Don't return any
8443 unresolved `ConstructedType's.
8445 2004-11-17 Martin Baulig <martin@ximian.com>
8447 * ecore.cs (TypeExpr.ResolveType): Don't make this virtual.
8449 2004-11-17 Martin Baulig <martin@ximian.com>
8452 (Expression.ResolveAsTypeTerminal): Removed the `bool silent' argument.
8454 * decl.cs (DeclSpace.ResolveType): Removed.
8455 (DeclSpace.ResolveTypeExpr): Removed the `bool silent' argument.
8457 2004-11-17 Martin Baulig <martin@ximian.com>
8459 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
8460 direction, like FindMembers() does. Fixes #69546, testcase is in
8463 2004-11-16 Martin Baulig <martin@ximian.com>
8465 This is based on a patch from Marek Safar, see bug #69082.
8466 Fixes bugs #63705 and #67130.
8468 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
8469 method; create a MemberCache for an interface type and cache the
8472 * decl.cs (IMemberContainer.ParentContainer): Removed.
8473 (IMemberContainer.ParentCache): New property.
8474 (MemberCache.SetupCacheForInterface): Removed.
8475 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
8476 to create a cache for an interface's "parent".
8478 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
8481 2004-11-14 Ben Maurer <bmaurer@ximian.com>
8483 * statement.cs: Avoid adding bools to a hashtable.
8485 2004-11-15 Martin Baulig <martin@ximian.com>
8487 * decl.cs (MemberName.GetPartialName): Removed, use GetTypeName() instead.
8489 2004-11-11 Martin Baulig <martin@ximian.com>
8491 * typemanager.cs (TypeManager.GetMethodName): New method.
8493 * class.cs (MethodData.Define): Include the generic arity in the
8494 name of an explicit interface; also add it to the method name.
8496 * pending.cs (PendingImplementation.InterfaceMethod): The method
8497 name now includes the generic arity.
8499 2004-11-07 Miguel de Icaza <miguel@ximian.com>
8501 * expression.cs (Invocation.OverloadResolve): Flag error if we are
8502 calling an unsafe method from a safe location.
8504 2004-11-06 Marek Safar <marek.safar@seznam.cz>
8507 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
8509 2004-11-06 Miguel de Icaza <miguel@ximian.com>
8511 * namespace.cs (VerifyUsing): use GetPartialName instead of
8514 2004-11-05 Miguel de Icaza <miguel@ximian.com>
8516 * statement.cs (Return.Resolve): Fix regression in typo: if
8517 `in_exc', we have to request a NeedReturnLabel, this was a typo
8518 introduced in the anonymous method check-in. Fixes #69131.
8520 * Indexers were using the ShortName when defining themselves,
8521 causing a regression in the compiler bootstrap when applying the
8522 patch from 2004-11-02 (first part), now they use their full name
8523 and the bug is gone.
8525 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
8527 * driver.cs: Strip the path from the names of embedded resources. Fixes
8530 2004-11-04 Raja R Harinath <rharinath@novell.com>
8532 Fix error message regression: cs0104-2.cs.
8533 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
8534 (AliasEntry.Resolve): Update.
8535 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
8537 (RootContext.LookupType): Update.
8539 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
8541 * cs-parser.jay: Add support for handling accessor modifiers
8542 * class: Add support port accessor modifiers and error checking,
8543 define PropertyMethod.Define as virtual (not abstract anymore)
8544 * ecore.cs: Add checking for proeprties access with access modifiers
8545 * iterators.cs: Modify Accessor constructor call based in the modified
8547 2004-11-02 Ben Maurer <bmaurer@ximian.com>
8549 * expression.cs (StringConcat): Handle being called twice,
8550 as when we have a concat in a field init with more than two
8553 2004-11-02 Miguel de Icaza <miguel@ximian.com>
8555 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
8556 special case explicit implementations, we should always produce
8557 the .property or .event declaration.
8559 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
8560 since it will not return correct data if people use this
8561 unresolved in the presence of using statements (see test-313).
8563 * class.cs (MethodData.Define): If we are an explicit interface
8564 implementation, set the method name to the full name of the
8565 interface plus the name of the method.
8567 Notice that using the method.MethodName.GetFullName() does not
8568 work, as it will only contain the name as declared on the source
8569 file (it can be a shorthand in the presence of using statements)
8570 and not the fully qualifed type name, for example:
8574 class D : ICloneable {
8575 object ICloneable.Clone () {
8579 Would produce a method called `ICloneable.Clone' instead of
8580 `System.ICloneable.Clone'.
8582 * namespace.cs (Alias.Resolve): Use GetPartialName.
8584 2004-11-01 Marek Safar <marek.safar@seznam.cz>
8586 * cs-parser.jay: Add error 1055 report.
8588 2004-11-01 Miguel de Icaza <miguel@ximian.com>
8590 * assign.cs (Assign.DoResolve): Only do the transform of
8591 assignment into a New if the types are compatible, if not, fall
8592 through and let the implicit code deal with the errors and with
8593 the necessary conversions.
8595 2004-11-01 Marek Safar <marek.safar@seznam.cz>
8597 * cs-parser.jay: Add error 1031 report.
8599 * cs-tokenizer.cs: Add location for error 1038.
8601 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8603 * cs-parser.jay: Add error 1016 report.
8605 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8607 * cs-parser.jay: Add errors 1575,1611 report.
8609 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8611 * cs-parser.jay: Add error 1001 report.
8613 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8616 * attribute.cs (GetMarshal): Add method argument for
8617 caller identification.
8619 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
8620 agument for GetMarshal and RuntimeMissingSupport.
8622 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8624 * attribute.cs (ExtractSecurityPermissionSet): Removed
8625 TypeManager.code_access_permission_type.
8627 * typemanager.cs: Removed TypeManager.code_access_permission_type.
8629 2004-10-27 Miguel de Icaza <miguel@ximian.com>
8631 * expression.cs (LocalVariableReference.DoResolveLValue): Check
8632 for obsolete use of a variable here. Fixes regression on errors
8633 cs0619-25 and cs0619-26.
8635 2004-10-27 Marek Safar <marek.safar@seznam.cz>
8637 Fix #62358, implemented security attribute encoding.
8639 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
8640 Tests permitted SecurityAction for assembly or other types.
8641 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
8642 data from SecurityPermissionAttribute to PermisionSet class.
8644 * class.cs (ApplyAttributeBuilder): Added special handling
8645 for System.Security.Permissions.SecurityAttribute based types.
8647 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
8648 special handling for System.Security.Permissions.SecurityAttribute
8651 * enum.cs (ApplyAttributeBuilder): Added special handling
8652 for System.Security.Permissions.SecurityAttribute based types.
8654 * parameter.cs (ApplyAttributeBuilder): Added special handling
8655 for System.Security.Permissions.SecurityAttribute based types.
8657 * rootcontext.cs: Next 2 core types.
8659 * typemanager.cs (TypeManager.security_permission_attr_type):
8660 Built in type for the SecurityPermission Attribute.
8661 (code_access_permission_type): Build in type.
8663 2004-10-17 Miguel de Icaza <miguel@ximian.com>
8665 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
8666 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
8667 all of this information into
8668 EmitContext.EmitCapturedVariableInstance.
8670 * codegen.cs (EmitCapturedVariableInstance): move here the
8671 funcionality of emitting an ldarg.0 in the presence of a
8672 remapping. This centralizes the instance emit code.
8674 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
8675 then emit a load of this: it means that we have reached the
8676 topmost ScopeInfo: the one that contains the pointer to the
8677 instance of the class hosting the anonymous method.
8679 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
8680 captures to the topmost CaptureContext.
8682 2004-10-12 Miguel de Icaza <miguel@ximian.com>
8684 * expression.cs (LocalVariableReference): Move the knowledge about
8685 the iterators into codegen's EmitCapturedVariableInstance.
8687 2004-10-11 Miguel de Icaza <miguel@ximian.com>
8689 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
8690 all code paths return a value from an anonymous method (it is the
8691 same as the 161 error, but for anonymous methods).
8693 2004-10-08 Miguel de Icaza <miguel@ximian.com>
8695 The introduction of anonymous methods in the compiler changed
8696 various ways of doing things in the compiler. The most
8697 significant one is the hard split between the resolution phase
8698 and the emission phases of the compiler.
8700 For instance, routines that referenced local variables no
8701 longer can safely create temporary variables during the
8702 resolution phase: they must do so from the emission phase,
8703 since the variable might have been "captured", hence access to
8704 it can not be done with the local-variable operations from the runtime.
8708 (Block.Flags): New flag `IsTopLevel' to indicate that this block
8709 is a toplevel block.
8711 (ToplevelBlock): A new kind of Block, these are the blocks that
8712 are created by the parser for all toplevel method bodies. These
8713 include methods, accessors and anonymous methods.
8715 These contain some extra information not found in regular blocks:
8716 A pointer to an optional CaptureContext (for tracking captured
8717 local variables and parameters). A pointer to the parent
8720 (Return.Resolve): Catch missmatches when returning a value from an
8721 anonymous method (error 1662).
8722 Invoke NeedReturnLabel from the Resolve phase instead of the emit
8725 (Break.Resolve): ditto.
8727 (SwitchLabel): instead of defining the labels during the
8728 resolution phase, we now turned the public ILLabel and ILLabelCode
8729 labels into methods called GetILLabelCode() and GetILLabel() that
8730 only define the label during the Emit phase.
8732 (GotoCase): Track the SwitchLabel instead of the computed label
8733 (its contained therein). Emit the code by using
8734 SwitchLabel.GetILLabelCode ().
8736 (LocalInfo.Flags.Captured): A new flag has been introduce to track
8737 whether the Local has been captured or not.
8739 (LocalInfo.IsCaptured): New property, used to tell whether the
8740 local has been captured.
8742 * anonymous.cs: Vastly updated to contain the anonymous method
8745 The main classes here are: CaptureContext which tracks any
8746 captured information for a toplevel block and ScopeInfo used to
8747 track the activation frames for various local variables.
8749 Each toplevel block has an optional capture context associated
8750 with it. When a method contains an anonymous method both the
8751 toplevel method and the anonymous method will create a capture
8752 context. When variables or parameters are captured, they are
8753 recorded on the CaptureContext that owns them, for example:
8757 MyDelegate d = delegate {
8762 Here `a' will be recorded as captured on the toplevel
8763 CapturedContext, the inner captured context will not have anything
8764 (it will only have data if local variables or parameters from it
8765 are captured in a nested anonymous method.
8767 The ScopeInfo is used to track the activation frames for local
8768 variables, for example:
8770 for (int i = 0; i < 10; i++)
8771 for (int j = 0; j < 10; j++){
8772 MyDelegate d = delegate {
8777 At runtime this captures a single captured variable `i', but it
8778 captures 10 different versions of the variable `j'. The variable
8779 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
8780 recorded on a child.
8782 The toplevel ScopeInfo will also track information like the `this'
8783 pointer if instance variables were referenced (this is necessary
8784 as the anonymous method lives inside a nested class in the host
8785 type of the method).
8787 (AnonymousMethod): Expanded to track the Toplevel, implement
8788 `AnonymousMethod.Compatible' to tell whether an anonymous method
8789 can be converted to a target delegate type.
8791 The routine now also produces the anonymous method content
8793 (AnonymousDelegate): A helper class that derives from
8794 DelegateCreation, this is used to generate the code necessary to
8795 produce the delegate for the anonymous method that was created.
8797 * assign.cs: API adjustments for new changes in
8798 Convert.ImplicitStandardConversionExists.
8800 * class.cs: Adjustments to cope with the fact that now toplevel
8801 blocks are of type `ToplevelBlock'.
8803 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
8804 insteda of standard blocks.
8806 Flag errors if params arguments are passed to anonymous methods.
8808 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
8809 `CurrentAnonymousMethod' which points to the current Anonymous
8810 Method. The variable points to the AnonymousMethod class that
8811 holds the code being compiled. It is set in the new EmitContext
8812 created for the anonymous method.
8814 (EmitContext.Phase): Introduce a variable and an enumeration to
8815 assist in enforcing some rules about when and where we are allowed
8816 to invoke certain methods (EmitContext.NeedsReturnLabel is the
8817 only one that enfonces this right now).
8819 (EmitContext.HaveCaptureInfo): new helper method that returns
8820 whether we have a CapturedContext initialized.
8822 (EmitContext.CaptureVariable): New method used to register that a
8823 LocalInfo must be flagged for capturing.
8825 (EmitContext.CapturedParameter): New method used to register that a
8826 parameters must be flagged for capturing.
8828 (EmitContext.CapturedField): New method used to register that a
8829 field must be flagged for capturing.
8831 (EmitContext.HaveCapturedVariables,
8832 EmitContext.HaveCapturedFields): Return whether there are captured
8833 variables or fields.
8835 (EmitContext.EmitMethodHostInstance): This is used to emit the
8836 instance for the anonymous method. The instance might be null
8837 (static methods), this (for anonymous methods that capture nothing
8838 and happen to live side-by-side with the current method body) or a
8839 more complicated expression if the method has a CaptureContext.
8841 (EmitContext.EmitTopBlock): Routine that drives the emission of
8842 code: it will first resolve the top block, then emit any metadata
8843 and then emit the code. The split is done so that we can extract
8844 any anonymous methods and flag any captured variables/parameters.
8846 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
8847 during this phase, the ILGenerator should not be used as labels
8848 and local variables declared here might not be accessible to any
8849 code that is part of an anonymous method.
8851 Exceptions to this include the temporary variables that are
8852 created by some statements internally for holding temporary
8855 (EmitContext.EmitMeta): New routine, in charge of emitting all the
8858 (EmitContext.TemporaryReturn): This method is typically called
8859 from the Emit phase, and its the only place where we allow the
8860 ReturnLabel to be defined other than the EmitMeta. The reason is
8861 that otherwise we would have to duplicate a lot of logic in the
8862 Resolve phases of various methods that today is on the Emit
8865 (EmitContext.NeedReturnLabel): This no longer creates the label,
8866 as the ILGenerator is not valid during the resolve phase.
8868 (EmitContext.EmitThis): Extended the knowledge in this class to
8869 work in anonymous methods in addition to iterators.
8871 (EmitContext.EmitCapturedVariableInstance): This emits whatever
8872 code is necessary on the stack to access the instance to a local
8873 variable (the variable will be accessed as a field).
8875 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
8876 EmitContext.EmitAddressOfParameter): Routines to support
8877 parameters (not completed at this point).
8879 Removals: Removed RemapLocal and RemapLocalLValue. We probably
8880 will also remove the parameters.
8882 * convert.cs (Convert): Define a `ConstantEC' which points to a
8883 null. This is just to prefity some code that uses
8884 ImplicitStandardConversion code and do not have an EmitContext
8887 The idea is to flag explicitly that at that point in time, it is
8888 known that the conversion will not trigger the delegate checking
8889 code in implicit conversions (which requires a valid
8892 Everywhere: pass new EmitContext parameter since
8893 ImplicitStandardConversionExists now requires it to check for
8894 anonymous method conversions.
8896 (Convert.ImplicitStandardConversionExists): If the type of an
8897 expression is the anonymous_method_type, and the type is a
8898 delegate, we invoke the AnonymousMethod.Compatible method to check
8899 whether an implicit conversion is possible.
8901 (Convert.ImplicitConversionStandard): Only do implicit method
8902 group conversions if the language level is not ISO_1.
8904 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
8905 MethodInfo for the Invoke method. used by Delegate and
8908 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
8909 method conversions if the target type is a delegate.
8911 Removed extra debugging nops.
8913 (LocalVariableReference): Turn the `local_info' into a public
8916 Add `prepared' field, the same hack used for FieldExprs to cope
8917 with composed assignments, as Local variables do not necessarily
8918 operate purely on the stack as they used to: they can be captured
8921 Add `temp' for a temporary result, like fields.
8923 Refactor DoResolve and DoResolveLValue into DoResolveBase.
8925 It now copes with Local variables that are captured and emits the
8926 proper instance variable to load it from a field in the captured
8929 (ParameterReference.DoResolveBase): During the resolve phase,
8930 capture parameters if we are in an anonymous method.
8932 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
8933 anonymous method, use the EmitContext helper routines to emit the
8934 parameter reference.
8936 * iterators.cs: Set RemapToProxy to true/false during the
8939 * parameters.cs (GetParameterByName): New helper method.
8941 * typemanager.cs (anonymous_method_type) a new type that
8942 represents an anonyous method. This is always an internal type,
8943 used as a fencepost to test against the anonymous-methodness of an
8946 2004-10-20 Marek Safar <marek.safar@seznam.cz>
8948 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
8950 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
8952 2004-11-10 Martin Baulig <martin@ximian.com>
8954 * expression.cs (Invocation.BetterFunction): If two methods have
8955 equal parameter types, but only one of them is generic, the
8956 non-generic one wins.
8957 (New.DoResolve): Don't set `is_struct' to false if we're a generic
8958 instance; just use `Type.IsValueType' to determine whether
8959 something is a struct or not.
8960 (MemberAccess.DoResolveAsTypeStep): Don't modify the `args' field,
8961 so we can be called multiple times.
8963 2004-11-10 Martin Baulig <martin@ximian.com>
8965 * generic.cs (TypeParameter.DefineConstraints): New public method.
8966 (TypeParameter.CheckAccessLevel): Override this and return true.
8967 (ConstructedType.ResolveType): Renamed to DoResolveType(), don't
8968 override ResolveType() anymore.
8969 (ConstructedType.DoResolveAsTypeStep): Call DoResolveType() here.
8971 2004-11-10 Martin Baulig <martin@ximian.com>
8973 * rootcontext.cs (RootContext.LookupType): If we're a nested type,
8974 call DeclSpace.ResolveNestedType() on it.
8976 2004-11-10 Martin Baulig <martin@ximian.com>
8978 * support.cs (ReflectionParameters.ParameterModifier): If `gpd' is
8979 non-null, call ParameterModifier() on it.
8981 2004-11-10 Martin Baulig <martin@ximian.com>
8984 (Iterators): Added `current_type' and `this_type' fields.
8985 (Iterators.DefineIterator): Create a new EmitContext and store it
8986 in `ec'; compute `this_type'.
8988 2004-11-10 Martin Baulig <martin@ximian.com>
8991 (TypeManager.IsPrivateAccessible): New public method.
8992 (Closure.Filter): Use IsPrivateAccessible() instead of IsEqual().
8994 2004-11-10 Martin Baulig <martin@ximian.com>
8996 * class.cs (TypeContainer.DefineType): Call
8997 TypeBuilder.DefineGenericParameters() before resolving the type
8999 (MethodData.parent_method): New protected field.
9000 (MethodData..ctor): Added `MethodInfo parent_method' argument.
9001 (MethodData.Define): Compute `parent_method'.
9004 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
9005 (MemberCore.GetClsCompliantAttributeValue): Likewise.
9006 (DeclSpace.ec): New protected field; store the EmitContext here.
9007 (DeclSpace.EmitContext): New public property.
9008 (DeclSpace.ResolveType): Un-comment from the [Obsolte] attribute.
9009 (DeclSpace.ResolveNestedType): New public method.
9010 (DeclSpace.ResolveTypeExpr): Just call ResolveAsTypeTerminal() here.
9011 (DeclSpace.NestedAccessible): Added `Type tb' argument.
9012 (DeclSpace.FamilyAccessible): Likewise.
9013 (DeclSpace.FindType): Call ResolveNestedType() for nested types.
9014 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
9017 * delegate.cs (Delegate.Define): Store the EmitContext in the `ec'
9020 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
9021 (Enum.Emit): Don't create a new EmitContext.
9023 2004-10-18 Martin Baulig <martin@ximian.com>
9025 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
9026 `Type' directly, but call ResolveType() on it.
9027 (Catch.Resolve): Likewise.
9028 (Foreach.Resolve): Likewise.
9030 2004-10-18 Martin Baulig <martin@ximian.com>
9032 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
9033 `Type' directly, but call ResolveType() on it.
9034 (Probe.DoResolve): Likewise.
9035 (ArrayCreation.LookupType): Likewise.
9036 (TypeOf.DoResolve): Likewise.
9037 (SizeOf.DoResolve): Likewise.
9039 2004-10-18 Raja R Harinath <rharinath@novell.com>
9041 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
9044 2004-10-17 John Luke <john.luke@gmail.com>
9046 * class.cs (Operator.GetSignatureForError): use CSharpName
9048 * parameter.cs (Parameter.GetSignatureForError): Returns
9049 correct name even if was not defined.
9051 2004-10-13 Raja R Harinath <rharinath@novell.com>
9054 * class.cs (TypeContainer.EmitContext): New property.
9055 (DefineNestedTypes): Create an emitcontext for each part.
9056 (MethodCore.DoDefineParameters): Use container's emitcontext.
9057 Pass type array to InternalParameters.
9058 (MemberBase.DoDefine): Use container's emitcontext.
9059 (FieldMember.Define): Likewise.
9060 (Event.Define): Likewise.
9061 (SetMethod.GetParameterInfo): Change argument to EmitContext.
9062 Pass type array to InternalParameters.
9063 (SetIndexerMethod.GetParameterInfo): Likewise.
9064 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
9065 * delegate.cs (Define): Pass emitcontext to
9066 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
9067 array to InternalParameters.
9068 * expression.cs (ParameterReference.DoResolveBase): Pass
9069 emitcontext to GetParameterInfo.
9070 (ComposedCast.DoResolveAsTypeStep): Remove check on
9071 ec.ResolvingTypeTree.
9072 * parameter.cs (Parameter.Resolve): Change argument to
9073 EmitContext. Use ResolveAsTypeTerminal.
9074 (Parameter.GetSignature): Change argument to EmitContext.
9075 (Parameters.ComputeSignature): Likewise.
9076 (Parameters.ComputeParameterTypes): Likewise.
9077 (Parameters.GetParameterInfo): Likewise.
9078 (Parameters.ComputeAndDefineParameterTypes): Likewise.
9079 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
9080 * support.cs (InternalParameters..ctor): Remove variant that takes
9082 * typemanager.cs (system_intptr_expr): New.
9083 (InitExpressionTypes): Initialize it.
9085 2004-10-12 Chris Toshok <toshok@ximian.com>
9087 * cs-parser.jay: fix location for try_statement and catch_clause.
9089 2004-10-18 Martin Baulig <martin@ximian.com>
9091 * class.cs (FieldMember.Define): Don't access the TypeExpr's
9092 `Type' directly, but call ResolveType() on it.
9093 (MemberBase.DoDefine): Likewise.
9095 * expression.cs (New.DoResolve): Don't access the TypeExpr's
9096 `Type' directly, but call ResolveType() on it.
9097 (ComposedCast.DoResolveAsTypeStep): Likewise.
9099 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
9100 `Type' directly, but call ResolveType() on it.
9102 2004-10-17 John Luke <john.luke@gmail.com>
9104 * class.cs (Operator.GetSignatureForError): use CSharpName
9106 * parameter.cs (Parameter.GetSignatureForError): Returns
9107 correct name even if was not defined.
9109 2004-10-13 Raja R Harinath <rharinath@novell.com>
9112 * class.cs (TypeContainer.EmitContext): New property.
9113 (DefineNestedTypes): Create an emitcontext for each part.
9114 (MethodCore.DoDefineParameters): Use container's emitcontext.
9115 Pass type array to InternalParameters.
9116 (MemberBase.DoDefine): Use container's emitcontext.
9117 (FieldMember.Define): Likewise.
9118 (Event.Define): Likewise.
9119 (SetMethod.GetParameterInfo): Change argument to EmitContext.
9120 Pass type array to InternalParameters.
9121 (SetIndexerMethod.GetParameterInfo): Likewise.
9122 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
9123 * delegate.cs (Define): Pass emitcontext to
9124 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
9125 array to InternalParameters.
9126 * expression.cs (ParameterReference.DoResolveBase): Pass
9127 emitcontext to GetParameterInfo.
9128 (ComposedCast.DoResolveAsTypeStep): Remove check on
9129 ec.ResolvingTypeTree.
9130 * parameter.cs (Parameter.Resolve): Change argument to
9131 EmitContext. Use ResolveAsTypeTerminal.
9132 (Parameter.GetSignature): Change argument to EmitContext.
9133 (Parameters.ComputeSignature): Likewise.
9134 (Parameters.ComputeParameterTypes): Likewise.
9135 (Parameters.GetParameterInfo): Likewise.
9136 (Parameters.ComputeAndDefineParameterTypes): Likewise.
9137 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
9138 * support.cs (InternalParameters..ctor): Remove variant that takes
9140 * typemanager.cs (system_intptr_expr): New.
9141 (InitExpressionTypes): Initialize it.
9143 2004-10-12 Chris Toshok <toshok@ximian.com>
9145 * cs-parser.jay: fix location for try_statement and catch_clause.
9147 2004-10-07 Raja R Harinath <rharinath@novell.com>
9149 More DeclSpace.ResolveType avoidance.
9150 * decl.cs (MemberCore.InUnsafe): New property.
9151 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
9152 with newly created EmitContext.
9153 (FieldMember.Define): Likewise.
9154 * delegate.cs (Delegate.Define): Likewise.
9155 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
9156 only if normal name-lookup fails.
9157 (TypeExpr.DoResolve): Enable error-checking.
9158 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
9159 (SizeOf.DoResolve): Likewise.
9160 (ComposedCast.DoResolveAsTypeStep): Likewise.
9161 (StackAlloc.DoResolve): Likewise.
9162 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
9163 (Block.Unsafe): New property.
9164 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
9165 (Unsafe): Set 'unsafe' flag of contained block.
9166 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
9167 (Fixed.Resolve): Likewise.
9168 (Catch.Resolve): Likewise.
9169 (Using.ResolveLocalVariableDecls): Likewise.
9170 (Foreach.Resolve): Likewise.
9172 2004-10-05 John Luke <john.luke@gmail.com>
9174 * cs-parser.jay: add location to error CS0175
9176 2004-10-04 Miguel de Icaza <miguel@ximian.com>
9178 * ecore.cs (Expression.Constantity): Add support for turning null
9181 * const.cs (Const.Define): Allow constants to be reference types
9182 as long as the value is Null.
9184 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
9186 * namespace.cs (NamespaceEntry.Using): No matter which warning
9187 level is set, check if this namespace name has already been added.
9189 2004-10-03 Ben Maurer <bmaurer@ximian.com>
9191 * expression.cs: reftype [!=]= null should always use br[true,false].
9194 2004-10-03 Marek Safar <marek.safar@seznam.cz>
9197 * attribute.cs: Enum conversion moved to
9198 GetAttributeArgumentExpression to be applied to the all
9201 2004-10-01 Raja R Harinath <rharinath@novell.com>
9203 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
9204 * class.c (TypeContainer.DefineType): Flag error if
9205 base types aren't accessible due to access permissions.
9206 * decl.cs (DeclSpace.ResolveType): Move logic to
9207 Expression.ResolveAsTypeTerminal.
9208 (DeclSpace.ResolveTypeExpr): Thin layer over
9209 Expression.ResolveAsTypeTerminal.
9210 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
9211 Refactor code into NestedAccess. Use it.
9212 (DeclSpace.NestedAccess): New.
9213 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
9214 argument to silence errors. Check access permissions.
9215 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
9216 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
9217 (Cast.DoResolve): Likewise.
9218 (New.DoResolve): Likewise.
9219 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
9220 (TypeOf.DoResolve): Likewise.
9222 * expression.cs (Invocation.BetterConversion): Return the Type of
9223 the better conversion. Implement section 14.4.2.3 more faithfully.
9224 (Invocation.BetterFunction): Make boolean. Make correspondence to
9225 section 14.4.2.2 explicit.
9226 (Invocation.OverloadResolve): Update.
9227 (Invocation): Remove is_base field.
9228 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
9229 (Invocation.Emit): Likewise.
9231 2004-09-24 Marek Safar <marek.safar@seznam.cz>
9233 * cs-parser.jay: Reverted 642 warning fix.
9235 2004-09-23 Marek Safar <marek.safar@seznam.cz>
9238 * decl.cs (FindMemberWithSameName): Indexer can have more than
9241 2004-09-23 Marek Safar <marek.safar@seznam.cz>
9243 * expression.cs (LocalVariableReference.DoResolveLValue):
9244 Do not report warning 219 for out values.
9245 (EmptyExpression.Null): New member to avoid extra allocations.
9247 2004-09-23 Marek Safar <marek.safar@seznam.cz>
9249 * cs-parser.jay: Fix wrong warning 642 report.
9251 * cs-tokenizer.cs (CheckNextToken): New helper;
9252 Inspect next character if is same as expected.
9254 2004-09-23 Martin Baulig <martin@ximian.com>
9256 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
9257 (Convert.ImplicitReferenceConversionExists): Likewise.
9259 2004-11-09 Raja R Harinath <rharinath@novell.com>
9261 * Makefile (DISTFILES): Comment out a few missing files.
9263 2004-10-29 Raja R Harinath <rharinath@novell.com>
9265 * Makefile (bootstrap_libs,bootstrap_libfiles): New.
9266 (bootstrap-libs): New target. Invokes the net_2_0_bootstrap profile.
9267 (gmcs.exe): Invoke bootstrap-libs.
9268 (clean-local): Clean the net_2_0_bootstrap profile too.
9269 (PROGRAM_INSTALL_DIR): New.
9270 (install-local): Use it.
9272 2004-10-13 Martin Baulig <martin@ximian.com>
9274 * generic.cs (TypeManager.InflatedConstraints): New nested class.
9275 (TypeParameter.DefineType): If we're a method type parameter and
9276 that method is overriding something, "inflate" its constraints.
9278 2004-10-12 Martin Baulig <martin@ximian.com>
9280 * expression.cs (MemberAccess.DoResolve): If we're a SimpleName
9281 and have type arguments, create and resolve a ConstructedType.
9283 2004-10-12 Martin Baulig <martin@ximian.com>
9285 * decl.cs (MemberCache.FindMemberToOverride): Use
9286 TypeManager.IsEqual() to compare the parameters and Type.Equals()
9287 to compare the invocationType.
9289 * typemanager.cs (TypeManager.IsEqual): Added support for arrays.
9290 When comparing two type parameters, only do the signature-only
9291 comparision for method type parameters.
9293 2004-10-11 Martin Baulig <martin@ximian.com>
9295 * report.cs: Don't make --fatal abort on warnings, we have
9296 -warnaserror for that.
9298 2004-10-11 Martin Baulig <martin@ximian.com>
9301 (TypeManager.IsEqualGenericType): Removed, use IsEqual() instead.
9302 (TypeManager.IsEqual): Call ourself recursively instead of using
9305 2004-10-11 Martin Baulig <martin@ximian.com>
9307 * class.cs (TypeContainer.DefineType): Only call TypeParameter.Define()
9308 on our own type parameters, not on the ones we inherit from a containing
9311 * expression.cs (Invocation.InferType): Use `==', not `Equals()' for
9314 * generic.cs (TypeParameter.Define): We may only be called once.
9316 * pending.cs (Pending.InterfaceMethod): Call TypeManager.Real_IsEqual()
9317 instead of TypeManager.IsEqual().
9319 2004-09-28 Martin Baulig <martin@ximian.com>
9322 (GenericConstraints.EffectiveBaseClass): New public property.
9323 (TypeParameter.GenericConstraints): New public property.
9324 (ConstructedType.CheckConstraints): Improved.
9326 * convert.cs (Convert.TypeParam_EffectiveBaseType): New private method.
9327 (Convert.TypeParameterConversion): New private method; use this in
9328 ImplicitReferenceConversion() and ImplicitReferenceConversionExists()
9329 for all conversions related to type parameters.
9331 2004-09-24 Martin Baulig <martin@ximian.com>
9333 * convert.cs (Convert.ImplicitReferenceConversion): Added implicit
9334 type parameter conversions for type parameters which are known to
9337 2004-09-24 Martin Baulig <martin@ximian.com>
9339 * generic.cs (GenericConstraints): Added `IsReferenceType' and
9340 `IsValueType' properties.
9342 * support.cs (ReflectionConstraints): Use
9343 Type.GetGenericParameterConstraints() instead of the old hack.
9345 2004-09-24 Martin Baulig <martin@ximian.com>
9347 * generic.cs (GenericConstraints): Moved here and made it an
9350 * support.cs (GenericConstraints): Moved to generic.cs.
9352 2004-09-24 Martin Baulig <martin@ximian.com>
9355 (ReflectionConstraints): Un-nested this class and made it public.
9358 (TypeManager.GetTypeParameterConstraints): New public method.
9359 (TypeManager.HasConstructorConstraint): Use the attributes.
9361 2004-09-24 Martin Baulig <martin@ximian.com>
9363 * support.cs (GenericConstraints): Replaced `HasConstructor',
9364 `IsReferenceType' and `IsValueType' with `Attributes'.
9365 (ReflectionParameters.ReflectionConstraints): Removed the Create()
9366 method and made the .ctor public.
9368 * generic.cs (Constraints.Attributes): New public property.
9369 (Constraints): Renamed `HasConstructor' -> `HasConstructorConstraint',
9370 `IsReferenceType' -> `HasReferenceTypeConstraint' and
9371 `IsValueType' -> `HasValueTypeConstraint'.
9373 2004-09-23 Martin Baulig <martin@ximian.com>
9375 * generic.cs (Constraints): Reflect latest runtime changes.
9377 2004-09-23 Martin Baulig <martin@ximian.com>
9379 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
9380 (Convert.ImplicitReferenceConversionExists): Likewise.
9382 2004-09-23 Marek Safar <marek.safar@seznam.cz>
9384 * class.cs (Operator.Define): Add error 448 and 559 report.
9386 2004-09-22 Marek Safar <marek.safar@seznam.cz>
9388 * class.cs (MemberBase.IsTypePermitted): New protected
9389 method for checking error CS0610.
9391 2004-09-22 Marek Safar <marek.safar@seznam.cz>
9393 * class.cs (TypeContainer.HasExplicitLayout): New property
9394 Returns whether container has StructLayout attribute set Explicit.
9395 (FieldMember): New abstract class for consts and fields.
9396 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
9397 (Field): Reuse FieldMember.
9399 * const.cs (Const): Reuse FieldMember.
9401 * rootcontext.cs: EmitConstants call moved to class.
9403 2004-09-22 Martin Baulig <martin@ximian.com>
9405 Marek and me just fixed one of our oldest bugs: #28562 :-)
9407 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
9409 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
9410 we're an EnumConstant, just return that.
9411 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
9412 an EnumConstant. In this case, we need to use GetValueAsEnumType()
9413 to get the value which'll actually be written into the attribute.
9414 However, we have to use GetValue() to access the attribute's value
9417 2004-09-22 Marek Safar <marek.safar@seznam.cz>
9419 * constant.cs (Constant.IsNegative): New abstract property
9422 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
9423 (StackAlloc.DoResolve): Reused IsNegative.
9425 2004-09-22 Martin Baulig <martin@ximian.com>
9427 * typemanager.cs (TypeManager.LookupGenericTypeContainer): New
9428 public method; like LookupTypeContainer, but also works for
9431 * report.cs (Report.SymbolRelatedToPreviousError): Use
9432 TypeManager.LookupGenericTypeContainer().
9434 2004-09-22 Martin Baulig <martin@ximian.com>
9436 Thanks to Peter Sestoft for this bug report.
9438 * expression.cs (Conditional): If both the `trueExpr' and the
9439 `falseExpr' is a NullLiteral, return a NullLiteral.
9441 2004-09-22 Martin Baulig <martin@ximian.com>
9443 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
9444 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
9445 for the "get_Current" call.
9447 2004-09-21 Martin Baulig <martin@ximian.com>
9449 * convert.cs (Convert.ImplicitReferenceConversion): When
9450 converting to an interface type, first check whether we're
9451 converting from a reference type.
9453 2004-09-14 Martin Baulig <martin@ximian.com>
9455 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
9457 2004-09-14 Marek Safar <marek.safar@seznam.cz>
9460 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
9461 called and is obsolete then this member suppress message
9462 when call is inside next [Obsolete] method or type.
9464 * expression.cs: Use TestObsoleteMethodUsage member.
9466 2004-09-14 Martin Baulig <martin@ximian.com>
9468 * genericparser.cs: Removed.
9470 2004-09-13 Marek Safar <marek.safar@seznam.cz>
9472 * class.cs (MethodCore.CheckBase): Fix bug #65757.
9474 2004-09-12 Marek Safar <marek.safar@seznam.cz>
9476 * attribute.cs (Attribute.Resolve): Add error 653 report.
9478 * class.cs (Class.ApplyAttributeBuilder): Add error 641
9480 (Method.ApplyAttributeBuilder): Add error 685 report.
9481 (Operator.Define): Add error 564 report.
9483 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
9485 * expression.cs (Invocation.DoResolve): Add error
9488 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
9491 2004-09-11 Marek Safar <marek.safar@seznam.cz>
9493 * class.cs (ConstructorInitializer.Resolve):
9494 Wrong error number (515->516).
9496 2004-09-11 Marek Safar <marek.safar@seznam.cz>
9498 * class.cs (Indexer.Define): Add error 631 report.
9500 2004-09-11 Marek Safar <marek.safar@seznam.cz>
9502 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
9504 2004-09-11 Marek Safar <marek.safar@seznam.cz>
9506 * expression.cs (Probe.DoResolve): Add error CS0241 report.
9508 2004-09-10 Marek Safar <marek.safar@seznam.cz>
9510 * cs-parser.jay: Added error CS0241 report.
9512 2004-09-10 Raja R Harinath <rharinath@novell.com>
9514 * cs-parser.jay (fixed_statement): Introduce a scope for the
9515 declaration in the 'fixed' statement.
9517 2004-09-09 Marek Safar <marek.safar@seznam.cz>
9519 * cs-parser.jay: Added CS0230 error report.
9521 2004-09-09 Marek Safar <marek.safar@seznam.cz>
9523 * cs-parser.jay: Added errors CS0231 and CS0257 report.
9525 2004-09-09 Marek Safar <marek.safar@seznam.cz>
9527 * expression.cs (Argument.Resolve): Added error CS0192 and
9530 2004-09-09 Marek Safar <marek.safar@seznam.cz>
9532 C# 2.0 #pragma warning feature
9534 * cs-tokenizer.cs (PreProcessPragma): New method;
9535 Handles #pragma directive.
9537 * report.cs (WarningRegions): New class; Support
9538 class for #pragma warning directive. It tests whether
9539 warning is enabled for a given line.
9541 2004-09-08 Miguel de Icaza <miguel@ximian.com>
9543 * const.cs: Add more descriptive error report, tahnks to
9546 2004-09-08 Marek Safar <marek.safar@seznam.cz>
9548 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
9550 2004-09-07 Miguel de Icaza <miguel@ximian.com>
9552 * expression.cs: Apply patch from Ben: Remove dead code from
9553 ArrayCreation, and remove the TurnintoConstant call in const.cs,
9554 as that code just threw an exception anwyays.
9556 * const.cs: Remove the call to the turnintoconstant, for details
9559 * literal.cs: The type of the null-literal is the null type; So
9560 we use a placeholder type (literal.cs:System.Null, defined here)
9563 * expression.cs (Conditional.DoResolve): Remove some old code that
9564 is no longer needed, conversions have been fixed.
9566 (ArrayCreationExpression.DoResolve): Return false if we fail to
9567 resolve the inner expression.
9569 2004-09-07 Raja R Harinath <rharinath@novell.com>
9572 * cs-parser.jay (delegate_declaration): Record a delegate
9573 declaration as a type declaration.
9574 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
9576 2004-09-06 Miguel de Icaza <miguel@ximian.com>
9578 * parameter.cs: Do not crash if the type can not be resolved.
9580 * expression.cs: Report errors with unsafe pointers, fixes #64896
9582 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
9584 * expression.cs: Pointer arith always needs to do a conv.i
9585 if the operand is a long. fix 65320
9587 2004-09-04 Marek Safar <marek.safar@seznam.cz>
9589 Fixed cs0619-37.cs, cs0619-38.cs
9591 * enum.cs (GetObsoleteAttribute): Removed.
9593 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
9594 on Enum member is double staged. The first is tested member
9597 2004-09-04 Marek Safar <marek.safar@seznam.cz>
9599 Fixed #56986, #63631, #65231
9601 * class.cs: (TypeContainer.AddToMemberContainer): New method,
9602 adds member to name container.
9603 (TypeContainer.AddToTypeContainer): New method, adds type to
9605 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
9606 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
9607 AddOperator): Simplified by reusing AddToMemberContainer.
9608 (TypeContainer.UserDefinedStaticConstructor): Changed to property
9610 (Method.CheckForDuplications): Fixed implementation to test all
9612 (MemberBase): Detection whether member is explicit interface
9613 implementation is now in constructor.
9614 (MemberBase.UpdateMemberName): Handles IndexerName.
9615 (Accessor): Changed to keep also location information.
9616 (AbstractPropertyEventMethod): Is derived from MemberCore.
9617 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
9618 will be emited or not.
9619 (PropertyBase.AreAccessorsDuplicateImplementation):
9620 Tests whether accessors are not in collision with some method.
9621 (Operator): Is derived from MethodCore to simplify common
9624 * decl.cs (Flags.TestMethodDuplication): Test for duplication
9626 (DeclSpace.AddToContainer): Adds the member to defined_names
9627 table. It tests for duplications and enclosing name conflicts.
9629 * enum.cs (EnumMember): Clean up to reuse the base structures
9631 2004-09-03 Martin Baulig <martin@ximian.com>
9633 Merged latest changes into gmcs. Please keep this comment in
9634 here, it makes it easier for me to see what changed in MCS since
9635 the last time I merged.
9637 2004-09-03 Martin Baulig <martin@ximian.com>
9639 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
9640 into TypeContainer, to make partial classes work again.
9642 2004-09-03 Martin Baulig <martin@ximian.com>
9644 * rootcontext.cs (RootContext.V2): Removed.
9646 2004-03-23 Martin Baulig <martin@ximian.com>
9648 * expression.cs (Invocation.OverloadResolve): Added `bool
9649 may_fail' argument and use it instead of the Location.IsNull() hack.
9651 2004-09-09 Martin Baulig <martin@ximian.com>
9653 * cs-parser.jay (namespace_declaration): Fixed CS0134 reporting.
9655 2004-09-09 Martin Baulig <martin@ximian.com>
9657 * generic.cs (TypeParameter.DefineType): Added support for
9658 explicit interface methods.
9660 2004-09-09 Martin Baulig <martin@ximian.com>
9662 * README.Changes: New document. Started to list important changes
9663 between MCS and GMCS here.
9665 2004-09-08 Martin Baulig <martin@ximian.com>
9668 (TypeContainer.CheckRecursiveDefinition): New protected method.
9669 (TypeContainer.DefineType): Move the CS0146 check into
9670 CheckRecursiveDefinition().
9672 2004-09-06 Martin Baulig <martin@ximian.com>
9674 * generic.cs (ConstructedType.CheckConstraints): Allow builtin
9675 types for the constructor constraint.
9677 2004-09-03 Martin Baulig <martin@ximian.com>
9679 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
9680 into TypeContainer, to make partial classes work again.
9682 2004-09-03 Martin Baulig <martin@ximian.com>
9684 * rootcontext.cs (RootContext.V2): Removed.
9686 2004-03-23 Martin Baulig <martin@ximian.com>
9688 * expression.cs (Invocation.OverloadResolve): Added `bool
9689 may_fail' argument and use it instead of the Location.IsNull() hack.
9691 2004-09-03 Martin Baulig <martin@ximian.com>
9693 Merged latest changes into gmcs. Please keep this comment in
9694 here, it makes it easier for me to see what changed in MCS since
9695 the last time I merged.
9697 2004-09-03 Raja R Harinath <rharinath@novell.com>
9700 * expression.cs (BetterConversion): Don't allow either conversion
9701 to be null. Remove redundant implicit conversion test when 'q ==
9702 null' -- when this function is invoked, we already know that the
9703 implicit conversion exists.
9704 (BetterFunction): Assume that 'best' is non-null. Remove
9705 redundant reimplementation of IsApplicable when 'best' is null.
9706 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
9707 number of arguments.
9708 (IsAncestralType): Extract from OverloadResolve.
9709 (OverloadResolve): Make robust to the MethodGroupExpr being
9710 unsorted. Implement all the logic of Section 14.5.5.1, and
9711 support overloading of methods from multiple applicable types.
9712 Clean up logic somewhat. Don't pass null methods to BetterFunction.
9714 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
9715 (RealError, Warning): Append type of report to related symbol.
9717 2004-09-03 Marek Safar <marek.safar@seznam.cz>
9719 * enum.cs: Fixed CLS-Compliance checks for enum members.
9720 Error tests cs3008-8.cs, cs3014-8.cs
9722 2004-09-02 Marek Safar <marek.safar@seznam.cz>
9724 Fixed bug #62342, #63102
9725 * class.cs: ImplementIndexer uses member.IsExplicitImpl
9726 like ImplementMethod.
9728 2004-09-02 Marek Safar <marek.safar@seznam.cz>
9730 * attribute.cs (Attribute.GetAttributeArgumentExpression):
9733 2004-09-02 Martin Baulig <martin@ximian.com>
9735 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
9736 TypeManager.GetArgumentTypes() rather than calling GetParameters()
9739 2004-09-01 Marek Safar <marek.safar@seznam.cz>
9741 C# 2.0 Static classes implemented
9743 * class.cs (TypeContainer): instance_constructors,
9744 initialized_fields, initialized_static_fields,
9745 default_constructor, base_inteface_types are protected to be
9746 accessible from StaticClass.
9747 (TypeContainer.DefineDefaultConstructor): New virtual method
9748 for custom default constructor generating
9749 (StaticClass): New class to handle "Static classes" feature.
9751 * cs-parser.jay: Handle static keyword on class like instance
9754 * driver.cs: Added "/langversion" command line switch with two
9755 options (iso-1, default).
9757 2004-08-31 Marek Safar <marek.safar@seznam.cz>
9759 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
9761 2004-08-31 Miguel de Icaza <miguel@ximian.com>
9763 * delegate.cs: Style.
9765 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
9767 * delegate.cs: Add seperate instance expr field for miguel.
9769 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
9771 * PointerArithmetic (Resolve): make sure we are not doing
9772 pointer arith on void*. Also, make sure we are resolved
9773 by not setting eclass until resolve.
9775 All callers: Make sure that PointerArithmetic gets resolved.
9777 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
9779 * ArrayCreation (LookupType): If the type does not resolve
9780 to an array, give an error.
9782 2004-08-27 Marek Safar <marek.safar@seznam.cz>
9784 * statement.cs (Try.Resolve): Fixed bug #64222
9786 2004-08-27 Martin Baulig <martin@ximian.com>
9789 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
9792 2004-08-26 Marek Safar <marek.safar@seznam.cz>
9794 * ecore.cs (Constantify): Get underlying type via
9795 System.Enum.GetUnderlyingType to avoid StackOverflow on the
9796 Windows in special cases.
9798 2004-08-26 Marek Safar <marek.safar@seznam.cz>
9800 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
9801 for obtaining also private methods.
9802 (GetRemoveMethod): Used GetRemoveMethod (true)
9803 for obtaining also private methods.
9805 2004-09-02 Martin Baulig <martin@ximian.com>
9807 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
9808 TypeManager.GetArgumentTypes() rather than calling GetParameters()
9811 2004-08-27 Martin Baulig <martin@ximian.com>
9814 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
9817 2004-08-25 Martin Baulig <martin@ximian.com>
9819 * support.cs (ReflectionParameters..ctor): If this is a generic
9820 method, retrieve and store its type parameters.
9821 (InternalParameters..ctor): Added `TypeParameter[]' argument.
9822 (ReflectionParameters.GenericConstraints): The argument specifies
9823 the type parameter, not the method parameter.
9824 (InternalParameters.GenericConstraints): Likewise.
9826 * generic.cs (TypeParameter.DefineType): Correctly handle
9827 constraints wrt. generic methods in interfaces and their
9830 2004-08-24 Martin Baulig <martin@ximian.com>
9832 * generic.cs (TypeParameter.IsSubclassOf): New public method.
9833 (Constraints.IsSubclassOf): New internal method.
9835 * typemanager.cs (TypeManager.FindMembers): Added special support
9836 for GenericTypeParameterBuilder's.
9837 (TypeManager.IsSubclassOf, IsFamilyAccessible): Added support for
9840 2004-08-24 Martin Baulig <martin@ximian.com>
9843 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
9844 this for accessibility checks.
9845 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
9846 IsNestedFamilyAccessible.
9847 (TypeManager.IsSubclassOf): New method, do what the name actually
9850 2004-08-24 Martin Baulig <martin@ximian.com>
9852 * expression.cs (MemberAccess.DoResolve): When resolving ourselves
9853 as a SimpleName, include the generic arity.
9855 2004-08-24 Martin Baulig <martin@ximian.com>
9857 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
9858 MethodAttributes.HideBySig for operators.
9860 2004-08-23 Martin Baulig <martin@ximian.com>
9862 Back to the old error reporting system :-)
9864 * report.cs (Message): Removed.
9865 (Report.MessageData, ErrorData, WarningData): Removed.
9866 (Report.Error, Warning): Back to the old system.
9868 2004-08-23 Martin Baulig <martin@ximian.com>
9870 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
9872 * class.cs (TypeContainer.ParentContainer): New public virtual
9873 method; replaces the explicit interface implementation.
9874 (ClassPart.ParentContainer): Override.
9876 2004-08-23 Martin Baulig <martin@ximian.com>
9878 * statement.cs (Switch): Added support for constant switches; see
9879 #59428 or test-285.cs.
9881 2004-08-22 Marek Safar <marek.safar@seznam.cz>
9884 * statement.cs (GetEnumeratorFilter): Removed useless
9885 logic because C# specs is strict. GetEnumerator must be
9888 2004-08-22 Martin Baulig <martin@ximian.com>
9890 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
9891 a switch and may break, reset the barrier. Fixes #59867.
9893 2004-08-22 Marek Safar <marek.safar@seznam.cz>
9895 CLS-Compliance speed up (~5% for corlib)
9897 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
9898 New method. Tests container for CLS-Compliant names
9900 * class.cs (TypeContainer.VerifyClsName): New method.
9901 Checks whether container name is CLS Compliant.
9902 (Constructor): Implements IMethodData.
9904 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
9905 low-case table for CLS Compliance test.
9906 (MemberCache.VerifyClsParameterConflict): New method.
9907 Checks method parameters for CS3006 error.
9909 * enum.cs (EnumMember): Is derived from MemberCore.
9910 (Enum.VerifyClsName): Optimized for better performance.
9912 2004-08-06 Marek Safar <marek.safar@seznam.cz>
9914 * report.cs: Renamed Error_T to Error and changed all
9917 2004-08-06 Marek Safar <marek.safar@seznam.cz>
9919 * class.cs (TypeContainer.IndexerArrayList): New inner class
9920 container for indexers.
9921 (TypeContainer.DefaultIndexerName): New constant for default
9922 indexer name. Replaced all "Item" with this constant.
9923 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
9925 * typemanager.cs (TypeManager.default_member_ctor): Cache here
9926 DefaultMemberAttribute constructor.
9928 2004-08-05 Martin Baulig <martin@ximian.com>
9930 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
9933 2004-08-05 Marek Safar <marek.safar@seznam.cz>
9935 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
9936 multi platforms problem.
9938 * compiler.csproj: Included shared files.
9940 2004-08-04 Marek Safar <marek.safar@seznam.cz>
9942 Fix bug 60333, 55971 in the more general way
9943 * attribute.cs (Attribute.GetAttributeArgumentExpression):
9944 Added arg_type argument for constant conversion.
9945 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
9947 2004-08-04 Marek Safar <marek.safar@seznam.cz>
9950 * class.cs (TypeContainer ): New inner classes MethodArrayList,
9951 OperatorArrayList, MethodCoreArrayList for typecontainer
9952 containers. Changed class member types to these new types.
9953 (MethodArrayList.DefineMembers): Added test for CS0659.
9955 2004-08-04 Miguel de Icaza <miguel@ximian.com>
9957 * cfold.cs: Synchronize the folding with the code in expression.cs
9958 Binary.DoNumericPromotions for uint operands.
9960 * attribute.cs: Revert patch from Raja, it introduced a regression
9961 while building Blam-1.2.1 (hard to isolate a test case).
9963 2004-08-04 Marek Safar <marek.safar@seznam.cz>
9967 (TypeContainer.Define): Renamed to DefineContainerMembers because of
9969 (MethodCore.parent_method): New member. The method we're overriding
9970 if this is an override method.
9971 (MethodCore.CheckBase): Moved from Method class and made common.
9972 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
9974 (MethodCore.CheckForDuplications): New abstract method. For custom
9975 member duplication search in a container
9976 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
9977 method and its return type.
9978 (Event.conflict_symbol): New member. Symbol with same name in the
9982 (MemberCache.FindMemberWithSameName): New method. The method
9983 is looking for conflict with inherited symbols.
9985 2004-08-04 Martin Baulig <martin@ximian.com>
9987 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
9989 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
9991 2004-08-03 Marek Safar <marek.safar@seznam.cz>
9993 * report.cs (Message): New enum for better error, warning reference in
9995 (MessageData): New inner abstract class. It generally handles printing of
9996 error and warning messages.
9997 Removed unused Error, Warning, Message methods.
9999 2004-08-03 Marek Safar <marek.safar@seznam.cz>
10001 Fix for cs0592-8.cs test
10003 (Attributable.ValidAttributeTargets): Made public.
10004 (Attribute.ExplicitTarget): New member for explicit target value.
10005 (Attribute.CheckTargets): Now we translate explicit attribute
10006 target to Target here.
10008 2004-08-03 Ben Maurer <bmaurer@ximian.com>
10010 * ecore.cs (MethodGroupExpr): new IsBase property.
10012 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
10014 * delegate.cs (DelegateCreation): store a MethodGroupExpr
10015 rather than an instance expr.
10017 (DelegateCreation.Emit): Use the method group rather than
10018 the instance expression. Also, if you have base.Foo as the
10019 method for a delegate, make sure to emit ldftn, not ldftnvirt.
10021 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
10023 (NewDelegate.DoResolve): Only check for the existance of Invoke
10024 if the method is going to be needed. Use MethodGroupExpr.
10026 (NewDelegate.Emit): Remove, DelegateCreation implements this.
10028 * expression.cs: For pointer arith., make sure to use
10029 the size of the type, not the size of the pointer to
10032 2004-08-03 Marek Safar <marek.safar@seznam.cz>
10035 * class.cs (Class): Added error CS0502 test.
10037 2004-08-03 John Luke <jluke@cfl.rr.com>
10038 Raja R Harinath <rharinath@novell.com>
10041 * attribute.cs (Attribute.complained_before): New flag.
10042 (Attribute.ResolveType, Attribute.Resolve),
10043 (Attribute.DefinePInvokeMethod): Set it.
10044 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
10046 2004-08-03 Martin Baulig <martin@ximian.com>
10048 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
10049 use a user-defined operator; we still need to do numeric
10050 promotions in case one argument is a builtin type and the other
10051 one has an implicit conversion to that type. Fixes #62322.
10053 2004-08-18 Martin Baulig <martin@ximian.com>
10055 * class.cs (Method.Define): Use the correct method name when
10056 creating the MethodBuilder for a generic method.
10058 2004-08-17 Martin Baulig <martin@ximian.com>
10060 * generic.cs (Constraints): Support type parameter constraints.
10062 2004-08-16 Martin Baulig <martin@ximian.com>
10064 * cs-tokenizer.cs (Tokenizer.TypeOfParsing): New public property.
10065 (Token.GENERIC_DIMENSION): New token; this is returned if we
10066 encounter an unbound generic type in a typeof() expression.
10068 * cs-parser.jay (opt_type_argument_list): Added GENERIC_DIMENSION;
10069 this token is only generated while parsing a typeof() expression.
10070 (typeof_expression): Removed the old unbound_type hack.
10072 * generic.cs (TypeArguments.IsUnbound): New public property.
10074 * decl.cs (MemberName): Added support for unbound types.
10076 2004-08-14 Martin Baulig <martin@ximian.com>
10079 (TypeManager.IsEqualGenericInstance): New static method.
10080 (TypeManager.IsSubclassOrNestedChildOf, IsSubclassOf): This is
10081 just used to check accessibility, so follow the rules of 26.1.6.
10083 * expression.cs (MemberAccess.ResolveAsTypeStep): Return a
10084 ConstructedType instead of a TypeExpression if we have type arguments.
10086 * cs-parser.jay (typeof_expression): Support unbound generic types.
10088 * ecore.cs (UnboundTypeExpression): New public class.
10090 2004-08-12 Martin Baulig <martin@ximian.com>
10092 * typemanager.cs (TypeManager.IsNestedChildOf): Use
10093 TypeManager.IsEqual() rather than `=='.
10095 * decl.cs (DeclSpace.CheckAccessLevel): Use `tb.FullName' for
10096 generic instances as well.
10098 2004-08-12 Martin Baulig <martin@ximian.com>
10100 * expression.cs (Invocation.InferType): We can only infer method
10101 type parameters. Fixes #62647.
10103 2004-08-11 Martin Baulig <martin@ximian.com>
10105 * class.cs (TypeContainer.DefineType): Create the TypeBuilder
10106 before resolving the base classes.
10108 2004-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10110 * Makefile: install .mdb file too.
10112 2004-08-05 Martin Baulig <martin@ximian.com>
10114 * ecore.cs (FieldExpr.DoResolveLValue): If we're resolving a field
10115 initializer, the current type is just the TypeBuilder, not the
10116 instantiated generic type.
10117 (FieldExpr.IsFieldInitializer): New public property.
10119 2004-08-04 Martin Baulig <martin@ximian.com>
10121 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
10123 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
10125 2004-08-03 Martin Baulig <martin@ximian.com>
10127 * class.cs (MethodData.Define): If we're an explicit
10128 implementation, remove the generic arity from the type name.
10130 2004-08-03 Martin Baulig <martin@ximian.com>
10132 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
10133 use a user-defined operator; we still need to do numeric
10134 promotions in case one argument is a builtin type and the other
10135 one has an implicit conversion to that type. Fixes #62322.
10137 2004-08-02 Martin Baulig <martin@ximian.com>
10139 * class.cs (TypeContainer.ifaces): Make this a `Type[]', not a
10140 `TypeExpr[]' array.
10141 (TypeContainer.GetClassBases): Return the unexpanded list of
10142 interfaces; we expand them later.
10143 (TypeContainer.DefineType): After creating the TypeBuilder, call
10144 TypeManager.ExpandInterfaces() to get an expanded and resolved
10145 list of interfaces.
10147 * ecore.cs (TypeExpr.GetInterfaces): Removed
10149 * generics.cs (Constraints.InterfaceConstraints): Remove.
10150 (TypeParameter.DefineType): Call TypeManager.RegisterBuilder() to
10151 register the interface constraints.
10154 (TypeManager.AddUserType): Removed the `ifaces' argument.
10155 (TypeManager.AddTypeParameter): Likewise.
10156 (TypeManager.AddUserInterface): Removed, was unused.
10157 (TypeManager.RegisterBuilder): Take a `Type[]' instead of a
10158 `TypeExpr[]' array for the interfaces.
10159 (TypeManager.ExpandInterfaces): Call this after the TypeBuilder
10160 has been defined, returns a list of the resolved interfaces types.
10161 (TypeManager.GetInterfaces): Return a `Type[]', not a `TypeExpr[]'.
10162 (TypeManager.GetExplicitInterfaces): Likewise.
10164 2004-08-02 Martin Baulig <martin@ximian.com>
10166 * expression.cs (Invocation.EmitCall): If we're invoking a method
10167 on a type parameter, use the new `Constrained' prefix opcode.
10169 2004-08-02 Martin Baulig <martin@ximian.com>
10171 * statement.cs (LocalInfo.Flags): Added `IsThis'.
10172 (LocalInfo.IsThis): New public property.
10173 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
10175 2004-08-01 Martin Baulig <martin@ximian.com>
10177 * class.cs (TypeContainer.GetClassBases): Don't set the default
10178 here since we may get called from GetPartialBases().
10179 (TypeContainer.DefineType): If GetClassBases() didn't return a
10180 parent, use the default one.
10182 2004-07-30 Martin Baulig <martin@ximian.com>
10184 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
10186 * class.cs (SourceMethod): New public class, derive from the
10187 symbol writer's ISourceMethod.
10188 (Method): Use the new symbol writer API.
10190 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
10191 as argument and use the new symbol writer.
10194 (SourceFile): Implement the symbol writer's ISourceFile.
10195 (Location.SymbolDocument): Removed.
10196 (Location.SourceFile): New public property.
10198 * symbolwriter.cs: Use the new symbol writer API.
10200 2004-07-30 Raja R Harinath <rharinath@novell.com>
10202 * Makefile (install-local): Remove. Functionality moved to
10205 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
10207 * Makefile: Install mcs.exe.config file together with mcs.exe.
10208 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
10209 correct runtime version.
10211 2004-07-25 Martin Baulig <martin@ximian.com>
10214 (TypeContainer.RegisterOrder): Removed, this was unused.
10215 (TypeContainer, interface_order): Removed.
10216 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
10217 TypeContainer as argument since we can also be called with a
10218 `PartialContainer' for a partial class/struct/interface.
10219 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
10220 of checking whether we're an `Interface' - we could be a
10221 `PartialContainer'.
10222 (PartialContainer.Register): Override; call
10223 AddClass()/AddStruct()/AddInterface() on our parent.
10225 * cs-parser.jay (interface_member_declaration): Add things to the
10226 `current_container', not the `current_class'.
10228 * rootcontext.cs (RegisterOrder): The overloaded version which
10229 takes an `Interface' was unused, removed.
10231 * typemanager.cs (TypeManager.LookupInterface): Return a
10232 `TypeContainer', not an `Interface'.
10233 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
10234 contain a `PartialContainer' for an interface, so check it's
10235 `Kind' to figure out what it is.
10237 2004-07-25 Martin Baulig <martin@ximian.com>
10239 * class.cs (Class.DefaultTypeAttributes): New public constant.
10240 (Struct.DefaultTypeAttributes): Likewise.
10241 (Interface.DefaultTypeAttributes): Likewise.
10242 (PartialContainer.TypeAttr): Override this and add the
10243 DefaultTypeAttributes.
10245 2004-07-25 Martin Baulig <martin@ximian.com>
10247 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
10248 we can just use the `Parent' field instead.
10250 2004-07-25 Martin Baulig <martin@ximian.com>
10252 * class.cs (TypeContainer.Emit): Renamed to EmitType().
10254 2004-07-25 Martin Baulig <martin@ximian.com>
10256 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
10257 our parts before defining any methods.
10258 (TypeContainer.VerifyImplements): Make this virtual.
10259 (ClassPart.VerifyImplements): Override and call VerifyImplements()
10260 on our PartialContainer.
10262 2004-07-25 Martin Baulig <martin@ximian.com>
10264 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
10266 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
10267 argument, we can just use the `Parent' field instead.
10270 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
10271 (MemberBase.DoDefine): Likewise.
10273 2004-07-24 Martin Baulig <martin@ximian.com>
10275 * decl.cs (MemberCore.Parent): New public field.
10276 (DeclSpace.Parent): Moved to MemberCore.
10278 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
10279 (MemberBase.ctor): Added TypeContainer argument, pass it to our
10281 (FieldBase, Field, Operator): Likewise.
10282 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
10283 (EventField, Event): Likewise.
10285 2004-07-23 Martin Baulig <martin@ximian.com>
10287 * class.cs (PartialContainer): New public class.
10288 (ClassPart): New public class.
10289 (TypeContainer): Added support for partial classes.
10290 (TypeContainer.GetClassBases): Splitted some of the functionality
10291 out into GetNormalBases() and GetPartialBases().
10293 * cs-tokenizer.cs (Token.PARTIAL): New token.
10294 (Tokenizer.consume_identifier): Added some hacks to recognize
10295 `partial', but only if it's immediately followed by `class',
10296 `struct' or `interface'.
10298 * cs-parser.jay: Added support for partial clases.
10300 2004-07-23 Martin Baulig <martin@ximian.com>
10302 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
10303 a `DeclSpace' and also made it readonly.
10304 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
10305 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
10306 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
10308 * cs-parser.jay: Pass the `current_class', not the
10309 `current_container' (at the moment, this is still the same thing)
10310 to a new Method, Property, Event, Indexer or Constructor.
10312 2004-07-23 Martin Baulig <martin@ximian.com>
10314 * cs-parser.jay (CSharpParser): Added a new `current_class' field
10315 and removed the `current_interface' one.
10316 (struct_declaration, class_declaration, interface_declaration):
10317 Set `current_class' to the newly created class/struct/interface;
10318 set their `Bases' and call Register() before parsing their body.
10320 2004-07-23 Martin Baulig <martin@ximian.com>
10322 * class.cs (Kind): New public enum.
10323 (TypeContainer): Made this class abstract.
10324 (TypeContainer.Kind): New public readonly field.
10325 (TypeContainer.CheckDef): New public method; moved here from
10327 (TypeContainer.Register): New public abstract method.
10328 (TypeContainer.GetPendingImplementations): New public abstract
10330 (TypeContainer.GetClassBases): Removed the `is_class' and
10331 `is_iface' parameters.
10332 (TypeContainer.DefineNestedTypes): Formerly known as
10334 (ClassOrStruct): Made this class abstract.
10336 * tree.cs (RootTypes): New public type.
10338 2004-07-20 Martin Baulig <martin@ximian.com>
10340 * tree.cs (Tree.RecordNamespace): Removed.
10341 (Tree.Namespaces): Removed.
10343 * rootcontext.cs (RootContext.IsNamespace): Removed.
10345 * cs-parser.jay (namespace_declaration): Just create a new
10346 NamespaceEntry here.
10348 2004-07-21 Lluis Sanchez Gual <lluis@novell.com>
10350 * Makefile: Install gmcs.exe.config file together with gmcs.exe.
10351 * gmcs.exe.config: Renamed from mcs.exe.config. Added supportedRuntime
10352 entry to make sure it runs in the correct runtime version.
10354 2004-07-18 Martin Baulig <martin@ximian.com>
10356 * generic.cs (ConstructedType.CheckConstraints): Improved
10357 constraints checking.
10359 2004-07-18 Martin Baulig <martin@ximian.com>
10361 * expression.cs (Invocation.BetterMethod): Call
10362 TypeManager.TypeToCoreType() on all types and removed my previous
10363 hack; we're already doig the right thing here.
10365 2004-07-17 Martin Baulig <martin@ximian.com>
10367 * decl.cs (MemberName.MakeName): Create the "class`1" names here.
10369 2004-07-16 Martin Baulig <martin@ximian.com>
10371 * iterators.cs: Added generics support.
10373 2004-07-16 Martin Baulig <martin@ximian.com>
10375 * iterators.cs: Rewrote this. We're now using one single Proxy
10376 class for both the IEnumerable and the IEnumerator interface and
10377 `Iterator' derives from Class so we can use the high-level API.
10379 * class.cs (TypeContainer.AddIterator): New method.
10380 (TypeContainer.DoDefineType): New protected virtual method, which
10381 is called from DefineType().
10382 (TypeContainer.DoDefineMembers): Call DefineType() and
10383 DefineMembers() on all our iterators.
10384 (TypeContainer.Emit): Call Emit() on all our iterators.
10385 (TypeContainer.CloseType): Call CloseType() on all our iterators.
10387 * codegen.cs (EmitContext.CurrentIterator): New public field.
10389 2004-07-15 Martin Baulig <martin@ximian.com>
10392 (TypeManager.not_supported_exception_type): New type.
10394 2004-07-14 Martin Baulig <martin@ximian.com>
10397 (TypeManager.generic_ienumerable_type): New type.
10398 (TypeManager.generic_ienumerator_type): New type.
10401 (RootContext.interfaces_first_stage): Added
10402 "System.Collections.Generic.IEnumerator`1" and
10403 "System.Collections.Generic.IEnumerable`1".
10405 2004-07-14 Martin Baulig <martin@ximian.com>
10407 * iterators.cs: Use real error numbers.
10409 2004-07-14 Martin Baulig <martin@ximian.com>
10411 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
10412 requires this to be a System.Collection.IEnumerable and not a
10413 class implementing that interface.
10414 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
10416 2004-07-13 Marek Safar <marek.safar@seznam.cz>
10418 * class.cs: Fixed previous fix, it broke some error tests.
10420 2004-07-12 Martin Baulig <martin@ximian.com>
10422 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
10425 2004-07-14 Martin Baulig <martin@ximian.com>
10427 * decl.cs, expression.cs, generic.cs: Use a backqoute (`) and not
10428 an exclamation mark (!) for the generic arity to reflect the
10429 latest spec changes; ie. use "System.Collections.Generic.IList`1".
10431 2004-07-13 Martin Baulig <martin@ximian.com>
10433 * cs-tokenizer.cs (Tokenizer.parse_less_than): Allow array rank
10434 specifiers being part of a type argument.
10436 2004-07-13 Martin Baulig <martin@ximian.com>
10438 * expression.cs (MemberAccess.ResolveAsTypeStep): Use the full `!'
10439 name for generic types.
10441 2004-07-13 Martin Baulig <martin@ximian.com>
10443 * assign.cs (Assign.DoResolve): Moved the CS0131 check up a little
10446 2004-07-09 Miguel de Icaza <miguel@ximian.com>
10448 * assign.cs (LocalTemporary): Add new argument: is_address,If
10449 `is_address' is true, then the value that we store is the address
10450 to the real value, and not the value itself.
10452 * ecore.cs (PropertyExpr): use the new local temporary
10453 stuff to allow us to handle X.Y += z (where X is a struct)
10455 2004-07-08 Martin Baulig <martin@ximian.com>
10457 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
10458 not always return, just like we're doing in Using.Resolve().
10460 2004-07-07 Miguel de Icaza <miguel@ximian.com>
10462 * cs-parser.jay (fixed_statement): flag this as Pinned.
10464 2004-07-06 Miguel de Icaza <miguel@ximian.com>
10466 * typemanager.cs (TypeManager): Removed MakePinned method, this
10467 mechanism is replaced with the .NET 2.x compatible mechanism of
10468 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
10470 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
10471 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
10472 `IsFixed' property which has a different meaning.
10474 2004-07-02 Raja R Harinath <rharinath@novell.com>
10476 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
10477 visible from inside a nested class, not just the names of the
10478 immediately enclosing class.
10479 Fix for bug #60730.
10481 2004-06-24 Raja R Harinath <rharinath@novell.com>
10483 * expression.cs (BetterConversion): Remove buggy special-case
10484 handling of "implicit constant expression conversions". At this
10485 point, we already know that the conversion is possible -- we're
10486 only checking to see which is better.
10488 2004-06-24 Marek Safar <marek.safar@seznam.cz>
10490 * cs-parser.jay: Added error CS0210 test.
10492 2004-06-24 Marek Safar <marek.safar@seznam.cz>
10494 * cs-parser.jay: Added error CS0134 test.
10496 2004-06-24 Marek Safar <marek.safar@seznam.cz>
10499 * cs-parser.jay: Added error CS0145 test.
10501 2004-06-24 Marek Safar <marek.safar@seznam.cz>
10503 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
10505 2004-06-23 Ben Maurer <bmaurer@ximian.com>
10507 * expression.cs (StackAlloc.Resolve): The argument may not
10508 be a constant; deal with this case.
10510 2004-06-23 Marek Safar <marek.safar@seznam.cz>
10512 * attribute.cs (IndexerName_GetIndexerName): Renamed to
10513 GetIndexerAttributeValue.
10514 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
10516 * class.cs (Indexer.Define): Added error tests for CS0415,
10519 2004-06-23 Miguel de Icaza <miguel@ximian.com>
10521 * attribute.cs (Attribute.Resolve): Keep field code in sync with
10524 2004-06-23 Martin Baulig <martin@ximian.com>
10526 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
10527 neither return nor throw, reset the barrier as well. Fixes #60457.
10529 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
10531 * class.cs : EventAttributes is now set to None by default.
10532 This fixes bug #60459.
10534 2004-06-18 Marek Safar <marek.safar@seznam.cz>
10537 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
10538 Don't throw exception but return null (it's sufficient now).
10540 2004-06-18 Marek Safar <marek.safar@seznam.cz>
10542 * typemanager.cs (GetArgumentTypes): Faster implementation.
10544 2004-06-18 Martin Baulig <martin@ximian.com>
10546 * attribute.cs (Attribute.Resolve): Check whether we're an
10547 EmptyCast which a Constant child. Fixes #60333.
10549 2004-06-17 Ben Maurer <bmaurer@ximian.com>
10551 * statement.cs (EmitCollectionForeach): Account for the fact that
10552 not all valuetypes are in areas which we can take the address of.
10553 For these variables, we store to a temporary variable. Also, make
10554 sure that we dont emit a `callvirt' on a valuetype method.
10556 2004-06-15 Marek Safar <marek.safar@seznam.cz>
10558 * expression.cs (StackAlloc.DoReSolve): Added test for
10559 negative parameter (CS0247).
10561 2004-06-15 Marek Safar <marek.safar@seznam.cz>
10564 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
10566 2004-06-15 Marek Safar <marek.safar@seznam.cz>
10569 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
10572 2004-06-14 Marek Safar <marek.safar@seznam.cz>
10574 Fix bug #58254 & cs1555.cs, cs1556.cs
10575 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
10577 2004-06-14 Marek Safar <marek.safar@seznam.cz>
10579 * cs-parser.jay: Added error CS1669 test for indexers.
10581 2004-06-18 Martin Baulig <martin@ximian.com>
10583 * generics.cs (GenericMethod.ctor): Don't take an Attributes
10584 argument. Fixes #60441.
10586 2004-06-16 Ben Maurer <bmaurer@ximian.com>
10587 * ecore.cs (MethodGroupExpr.Name): Revert Martin's patch.
10588 The name needs to have the actual name of the method in order
10589 for other tests (such as the one in OverloadResolve for Invoke
10590 on a delegate) to work. As well, it does not really help
10591 error reporting because the method group had multiple methods.
10592 * Makefile: Remove MCS_DEBUG, you can enable with the DEBUG_FLAGS.
10593 Make profiling work.
10595 2004-06-13 Martin Baulig <martin@ximian.com>
10597 * cs-parser.jay: Don't allow generic attributes.
10599 2004-06-13 Martin Baulig <martin@ximian.com>
10601 * class.cs (MemberBase.DoDefineBase): New protected method.
10602 (MemberBase.DoDefine): Compute the `flags' in the new
10603 DoDefineBase() which must be called first.
10604 (Method.Define): Call DoDefineBase() first so we have the flags
10605 when defining the generic method.
10607 * cs-parser.jay (interface_method_declaration): Support generic methods.
10609 2004-06-13 Martin Baulig <martin@ximian.com>
10611 * decl.cs (TypeName): Removed.
10612 (MemberName): Removed TypeName and MemberNow; now we just have
10615 * cs-parser.jay: Don't distinguish between type arguments and type
10616 parameters in the grammar and simplified the rules a bit. The
10617 reduce/reduce conflicts are now gone (except the one we inherited
10620 2004-06-11 Martin Baulig <martin@ximian.com>
10622 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
10623 call this twice: for params and varargs methods.
10625 2004-06-11 Marek Safar <marek.safar@seznam.cz>
10628 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
10630 2004-06-11 Marek Safar <marek.safar@seznam.cz>
10632 * attribute.cs (Attribute.GetValidTargets): Made public.
10635 (AbstractPropertyEventMethod): New class for better code sharing.
10636 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
10638 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
10640 2004-06-09 Martin Baulig <martin@ximian.com>
10642 * cs-parser.jay: Removed a reduce/reduce conflict.
10644 2004-06-03 Martin Baulig <martin@ximian.com>
10646 * generic.cs (ConstructedType.GetMemberAccess): Renamed to
10647 GetSimpleName() and return a SimpleName.
10649 * ecore.cs (SimpleName.Arguments): New public field.
10650 (SimpleName): Added overloaded ctor which takes an additional
10651 TypeArguments argument.
10652 (SimpleName.SimpleNameResolve): Added support for generic methods.
10653 (MethodGroupExpr.ResolveGeneric): New public method. The code was
10654 formerly in MemberAccess.DoResolve(), but we also need it in
10655 SimpleNameResolve().
10657 * expression.cs (MemberAccess.DoResolve): Use the new
10658 MethodGroupExpr.ResolveGeneric().
10660 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10662 * decl.cs: If possible, use lookuptypedirect here. We can only do
10663 this if there is no `.' after the namespace. Avoids using
10664 LookupType, which does lots of slow processing.
10665 (FindNestedType) New method, does what it says :-).
10666 * namespace.cs: use LookupTypeDirect.
10667 * rootcontext.cs: use membercache, if possible.
10668 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
10670 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10673 According to the spec,
10675 In a member access of the form E.I, if E is a single identifier,
10676 and if the meaning of E as a simple-name (§7.5.2) is a constant,
10677 field, property, localvariable, or parameter with the same type as
10678 the meaning of E as a type-name (§3.8), then both possible
10679 meanings of E are permitted.
10681 We did not check that E as a simple-name had the same type as E as
10684 This trivial check gives us 5-7% on bootstrap time.
10686 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10688 * expression.cs (Invocation.OverloadResolve): Avoid the
10689 use of hashtables and boxing here by allocating on demand.
10691 2004-05-30 Martin Baulig <martin@ximian.com>
10693 * rootcontext.cs (RootContext.LookupType): Don't cache things if
10694 we're doing a silent lookup. Don't try to lookup nested types in
10695 TypeManager.object_type (thanks to Ben Maurer).
10697 2004-05-30 Martin Baulig <martin@ximian.com>
10699 Committing a patch from Ben Maurer.
10701 * rootcontext.cs (RootContext.LookupType): Cache negative results.
10703 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10705 * convert.cs: add a trivial cache for overload operator resolution.
10707 2004-05-31 Marek Safar <marek.safar@seznam.cz>
10710 (AttributeTester.GetObsoleteAttribute): Returns instance of
10711 ObsoleteAttribute when type is obsolete.
10714 (TypeContainer.VerifyObsoleteAttribute): Override.
10715 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
10716 (MethodCode.VerifyObsoleteAttribute): Override.
10717 (MemberBase.VerifyObsoleteAttribute): Override.
10720 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
10721 and report proper error.
10724 (Delegate.VerifyObsoleteAttribute): Override.
10727 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
10728 and report proper error.
10729 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
10732 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
10736 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
10737 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
10738 Added test for ObsoleteAttribute.
10741 (Catch): Derived from Statement.
10743 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10745 * decl.cs: If possible, use lookuptypedirect here. We can only do
10746 this if there is no `.' after the namespace. Avoids using
10747 LookupType, which does lots of slow processing.
10748 (FindNestedType) New method, does what it says :-).
10749 * namespace.cs: use LookupTypeDirect.
10750 * rootcontext.cs: use membercache, if possible.
10751 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
10753 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10756 According to the spec,
10758 In a member access of the form E.I, if E is a single identifier,
10759 and if the meaning of E as a simple-name (§7.5.2) is a constant,
10760 field, property, localvariable, or parameter with the same type as
10761 the meaning of E as a type-name (§3.8), then both possible
10762 meanings of E are permitted.
10764 We did not check that E as a simple-name had the same type as E as
10767 This trivial check gives us 5-7% on bootstrap time.
10769 2004-05-30 Marek Safar <marek.safar@seznam.cz>
10771 Fixed bug #59071 & cs0160.cs
10772 * statement.cs (Try.Resolve): Check here whether order of catch
10773 clauses matches their dependencies.
10775 2004-05-30 Marek Safar <marek.safar@seznam.cz>
10778 * ecore.cs (SimpleName.SimpleNameResolve): Added test for
10781 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10783 * expression.cs (Invocation.OverloadResolve): Avoid the
10784 use of hashtables and boxing here by allocating on demand.
10786 2004-05-30 Martin Baulig <martin@ximian.com>
10788 * rootcontext.cs (RootContext.LookupType): Don't cache things if
10789 we're doing a silent lookup. Don't try to lookup nested types in
10790 TypeManager.object_type (thanks to Ben Maurer).
10792 2004-05-30 Martin Baulig <martin@ximian.com>
10794 Committing a patch from Ben Maurer.
10796 * rootcontext.cs (RootContext.LookupType): Cache negative results.
10798 2004-05-29 Martin Baulig <martin@ximian.com>
10800 * class.cs (IMethodData.ShouldIgnore): New method.
10802 * typemanager.cs (TypeManager.MethodFlags): Don't take a
10803 `Location' argument, we don't need it anywhere. Use
10804 `IMethodData.ShouldIgnore ()' instead of
10805 `MethodData.GetMethodFlags ()'.
10806 (TypeManager.AddMethod): Removed.
10807 (TypeManager.AddMethod2): Renamed to AddMethod.
10809 2004-05-29 Martin Baulig <martin@ximian.com>
10811 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
10813 * convert.cs (Convert.ImplicitReferenceConversion): If we're
10814 converting from a class type S to an interface type and we already
10815 have an object on the stack, don't box it again. Fixes #52578.
10817 2004-05-29 Martin Baulig <martin@ximian.com>
10819 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
10820 Added support for `params' parameters. Fixes #59267.
10822 2004-05-29 Martin Baulig <martin@ximian.com>
10824 * literal.cs (NullPointer): Provide a private .ctor which sets
10825 `type' to TypeManager.object_type. Fixes #59048.
10827 2004-05-29 Martin Baulig <martin@ximian.com>
10829 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
10830 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
10832 * ecore.cs (EventExpr.instance_expr): Make the field private.
10834 2004-05-26 Marek Safar <marek.safar@seznam.cz>
10836 Fixed bug #50080 & cs0214-2.cs
10837 * expression.cs (Cast.DoResolve): Check unsafe context here.
10839 * statement.cs (Resolve.DoResolve): Likewise.
10841 2004-05-26 Martin Baulig <martin@ximian.com>
10843 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
10845 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
10846 (RootContext.LookupType): Pass down the `silent' flag.
10848 2004-05-25 Martin Baulig <martin@ximian.com>
10851 (MethodGroupExpr.IdenticalTypeName): New public property.
10852 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
10853 expression actually refers to a type.
10855 2004-05-25 Martin Baulig <martin@ximian.com>
10857 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
10858 for #56176 and made it actually work.
10860 2004-05-25 Martin Baulig <martin@ximian.com>
10862 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
10863 (FieldExpr, PropertyExpr): Override and implement
10864 CacheTemporaries. Fixes #52279.
10866 2004-05-25 Miguel de Icaza <miguel@ximian.com>
10868 * location.cs: In the new compiler listing a file twice is a
10869 warning, not an error.
10871 2004-05-24 Martin Baulig <martin@ximian.com>
10873 * enum.cs (Enum.DefineType): For the `BaseType' to be a
10874 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
10876 2004-05-24 Martin Baulig <martin@ximian.com>
10878 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
10879 walking the `using' list. Fixes #53921.
10881 2004-05-24 Martin Baulig <martin@ximian.com>
10883 * const.cs (Const.LookupConstantValue): Added support for
10884 EmptyCast's; fixes #55251.
10886 2004-05-24 Martin Baulig <martin@ximian.com>
10888 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
10889 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
10890 which does the CS0135 check. The reason is that we first need to
10891 check whether the variable actually exists.
10893 2004-05-24 Martin Baulig <martin@ximian.com>
10895 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
10896 than RootContext.LookupType() to find the explicit interface
10897 type. Fixes #58584.
10899 2004-05-24 Raja R Harinath <rharinath@novell.com>
10901 * Makefile: Simplify. Use executable.make.
10902 * mcs.exe.sources: New file. List of sources of mcs.exe.
10904 2004-05-24 Anders Carlsson <andersca@gnome.org>
10908 Use the invariant culture when doing String.Compare for CLS case
10911 2004-05-23 Martin Baulig <martin@ximian.com>
10913 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
10914 don't have any dots. Fixes #52622, added cs0246-8.cs.
10916 * namespace.cs (NamespaceEntry.Lookup): Likewise.
10918 2004-05-23 Marek Safar <marek.safar@seznam.cz>
10920 * class.cs (MemberBase.Define): Reuse MemberType member for
10921 resolved type. Other methods can use it too.
10923 2004-05-23 Martin Baulig <martin@ximian.com>
10925 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
10926 the variable also exists in the current block (otherwise, we need
10927 to report a CS0103). Fixes #58670.
10929 2004-05-23 Martin Baulig <martin@ximian.com>
10931 * flowanalysis.cs (Reachability.Reachable): Compute this
10932 on-the-fly rather than storing it as a field.
10934 2004-05-23 Martin Baulig <martin@ximian.com>
10936 * flowanalysis.cs (Reachability.And): Manually compute the
10937 resulting `barrier' from the reachability.
10939 2004-05-23 Marek Safar <marek.safar@seznam.cz>
10942 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
10943 instance of ObsoleteAttribute when symbol is obsolete.
10946 (IMethodData): Extended interface for ObsoleteAttribute support.
10948 2004-05-22 Marek Safar <marek.safar@seznam.cz>
10950 * attribute.cs: Fix bug #55970
10952 2004-05-22 Marek Safar <marek.safar@seznam.cz>
10956 (GetObsoleteAttribute): New method. Creates the instance of
10958 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
10959 ObsoleteAttribute when member is obsolete.
10960 (AttributeTester.Report_ObsoleteMessage): Common method for
10961 Obsolete error/warning reporting.
10964 (TypeContainer.base_classs_type): New member for storing parent type.
10967 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
10968 for this MemberCore.
10970 2004-05-21 Marek Safar <marek.safar@seznam.cz>
10972 * attribute.cs, const.cs: Fix bug #58590
10974 2004-05-21 Martin Baulig <martin@ximian.com>
10976 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
10977 out parameters if the end of the method is unreachable. Fixes
10980 2004-05-21 Marek Safar <marek.safar@seznam.cz>
10982 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
10983 Hari was right, why extra method.
10985 2004-05-21 Marek Safar <marek.safar@seznam.cz>
10987 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
10989 2004-05-20 Martin Baulig <martin@ximian.com>
10991 * delegate.cs: Convert this file to Unix mode - like the original
10994 2004-05-20 Martin Baulig <martin@ximian.com>
10996 * attribute.cs: Convert this file to Unix mode - like the original
10999 2004-05-19 Marek Safar <marek.safar@seznam.cz>
11001 Fix bug #58688 (MCS does not report error when the same attribute
11004 * attribute.cs (Attribute.Emit): Distinction between null and default.
11006 2004-05-19 Raja R Harinath <rharinath@novell.com>
11008 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
11009 of a top-level attribute without an attribute target.
11010 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
11012 (Attribute.Conditional_GetConditionName),
11013 (Attribute.Obsolete_GetObsoleteMessage): Update.
11014 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
11015 part of ScanForIndexerName.
11016 (Attribute.CanIgnoreInvalidAttribute): New function.
11017 (Attribute.ScanForIndexerName): Move to ...
11018 (Attributes.ScanForIndexerName): ... here.
11019 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
11020 (Attributes.Search): New internal variant that can choose not to
11021 complain if types aren't resolved. The original signature now
11023 (Attributes.GetClsCompliantAttribute): Use internal variant, with
11024 complaints suppressed.
11025 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
11026 only if it not useful.
11027 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
11028 top-level for attributes that are shared between the assembly
11029 and a top-level class.
11030 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
11031 * class.cs: Update to reflect changes.
11032 (DefineIndexers): Fuse loops.
11033 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
11034 a couple more variants of attribute names.
11036 2004-05-18 Marek Safar <marek.safar@seznam.cz>
11038 Fix bug #52585 (Implemented explicit attribute declaration)
11041 (Attributable.ValidAttributeTargets): New abstract method. It gets
11042 list of valid attribute targets for explicit target declaration.
11043 (Attribute.Target): It holds target itself.
11044 (AttributeSection): Removed.
11045 (Attribute.CheckTargets): New method. It checks whether attribute
11046 target is valid for the current element.
11049 (EventProperty): New class. For events that are declared like
11050 property (with add and remove accessors).
11051 (EventField): New class. For events that are declared like field.
11054 * cs-parser.jay: Implemented explicit attribute target declaration.
11056 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
11057 Override ValidAttributeTargets.
11060 (ReturnParameter): Class for applying custom attributes on
11062 (ParameterAtribute): New class. Class for applying custom
11063 attributes on the parameter type.
11065 2004-05-17 Miguel de Icaza <miguel@ximian.com>
11067 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
11070 (Method): Allow UNSAFE here.
11072 * modifiers.cs: Support unsafe reporting.
11074 2004-05-17 Marek Safar <marek.safar@seznam.cz>
11076 * decl.cs: Fix bug #58478.
11078 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11080 * statement.cs: When checking for unreachable code on an EmptyStatement,
11081 set the location. Fixes bug #58488.
11083 2004-05-13 Miguel de Icaza <miguel@ximian.com>
11085 * driver.cs: Add -pkg handling.
11087 From Gonzalo: UseShelLExecute=false
11089 2004-05-12 Marek Safar <marek.safar@seznam.cz>
11092 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
11094 (Attribute.IsClsCompliaceRequired): Moved to base for better
11096 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
11097 when attribute is AttributeUsageAttribute.
11098 (Attribute.GetValidTargets): Simplified.
11099 (Attribute.GetAttributeUsage): New method returns AttributeUsage
11100 attribute for this type.
11101 (Attribute.ApplyAttributes): Method renamed to Emit and make
11103 (GlobalAttributeSection): New class for special handling of global
11104 attributes (assembly, module).
11105 (AttributeSection.Emit): New method.
11107 * class.cs: Implemented Attributable abstract methods.
11108 (MethodCore.LabelParameters): Moved to Parameter class.
11109 (Accessor): Is back simple class.
11110 (PropertyMethod): Implemented Attributable abstract class.
11111 (DelegateMethod): Implemented Attributable abstract class.
11112 (Event): New constructor for disctintion between normal Event
11113 and Event with accessors.
11115 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
11117 * codegen.cs, const.cs, decl.cs, delegate.cs:
11118 (CommonAssemblyModulClass): Implemented Attributable abstract class
11121 * enum.cs: Implement IAttributeSupport interface.
11122 (EnumMember): New class for emum members. Implemented Attributable
11126 (ParameterBase): Is abstract.
11127 (ReturnParameter): New class for easier [return:] attribute handling.
11129 * typemanager.cs: Removed builder_to_attr.
11131 2004-05-11 Raja R Harinath <rharinath@novell.com>
11134 * attribute.cs (Attribute.GetPositionalValue): New function.
11135 * class.cs (TypeContainer.VerifyMembers): New function.
11136 (TypeContainer.Emit): Use it.
11137 (ClassOrStruct): New base class for Class and Struct.
11138 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
11139 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
11141 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
11142 then each non-static field should have a FieldOffset attribute.
11143 Otherwise, none of the fields should have a FieldOffset attribute.
11144 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
11145 and FieldOffset attributes.
11146 * typemanager.cs (TypeManager.struct_layout_attribute_type)
11147 (TypeManager.field_offset_attribute_type): New core types.
11148 (TypeManager.InitCoreTypes): Initialize them.
11150 2004-05-11 Michal Moskal <malekith@pld-linux.org>
11152 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
11153 Return correct type.
11156 2004-05-09 Miguel de Icaza <miguel@ximian.com>
11158 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
11159 be implicitly converted to ulong.
11161 * expression.cs: The logic for allowing operator &, | and ^ worked
11162 was wrong, it worked before because we did not report an error in
11163 an else branch. Fixes 57895.
11165 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
11166 allow volatile fields to be reference types.
11168 2004-05-07 Miguel de Icaza <miguel@ximian.com>
11170 * driver.cs: Add support for /debug-
11172 2004-05-07 Raja R Harinath <rharinath@novell.com>
11174 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
11175 Add a 'complain' parameter to silence errors.
11176 (Attribute.Resolve): Update to changes. Put in sanity check to catch
11177 silently overlooked type-resolutions.
11178 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
11179 to reflect changes.
11180 (Attributes.Search): New function.
11181 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
11182 (Attributes.GetAttributeFullName): Remove hack.
11183 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
11184 Update to reflect changes.
11185 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
11186 Use Attributes.Search instead of nested loops.
11188 2004-05-07 Marek Safar <marek.safar@seznam.cz>
11191 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
11192 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
11193 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
11195 * report.cs: (Report.Warning): Renamed to Warning_T because of
11196 parameter collision.
11198 2004-05-05 Raja R Harinath <rharinath@novell.com>
11200 * expression.cs (MemberAccess.ResolveMemberAccess):
11201 Exit with non-zero status after Report.Error.
11202 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
11204 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
11206 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
11208 * support.cs: Don't hang when the file is empty.
11210 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
11212 * support.cs: In SeekableStreamReader, compute the preamble size of the
11213 underlying stream. Position changes should take into account that initial
11216 2004-05-03 Todd Berman <tberman@sevenl.net>
11218 * driver.cs: remove unused GetSysVersion function.
11220 2004-05-03 Todd Berman <tberman@sevenl.net>
11222 * driver.cs: Remove the hack from saturday, as well as the hack
11223 from jackson (LoadAssemblyFromGac), also adds the CWD to the
11224 link_paths to get that bit proper.
11226 2004-05-01 Todd Berman <tberman@sevenl.net>
11228 * driver.cs: Try a LoadFrom before a Load, this checks the current
11229 path. This is currently a bug in mono that is be fixed, however, this
11230 provides a workaround for now. This will be removed when the bug
11233 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
11235 * CryptoConvert.cs: Updated to latest version. Fix issue with
11236 incomplete key pairs (#57941).
11238 2004-05-01 Todd Berman <tberman@sevenl.net>
11240 * driver.cs: Remove '.' from path_chars, now System.* loads properly
11243 2004-04-30 Jackson Harper <jackson@ximian.com>
11245 * codegen.cs: Open keys readonly.
11247 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11249 * typemanager.cs: don't report cyclic struct layout when a struct
11250 contains 2 or more fields of the same type. Failed for Pango.AttrShape
11251 which has 2 Pango.Rectangle fields.
11253 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
11255 * expression.cs: Handle IntPtr comparisons with IL code
11256 rather than a method call.
11258 2004-04-29 Martin Baulig <martin@ximian.com>
11260 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
11261 the list of PropertyInfo's in class hierarchy and find the
11262 accessor. Fixes #56013.
11264 2004-04-29 Martin Baulig <martin@ximian.com>
11266 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
11268 2004-04-29 Martin Baulig <martin@ximian.com>
11270 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
11272 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
11274 2004-04-29 Martin Baulig <martin@ximian.com>
11276 * class.cs (ConstructorInitializer.Resolve): Check whether the
11277 parent .ctor is accessible. Fixes #52146.
11279 2004-04-29 Martin Baulig <martin@ximian.com>
11281 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
11283 * statement.cs (Using.EmitLocalVariableDecls): Use
11284 TypeManager.idisposable_type, not typeof (IDisposable).
11285 (Foreach.EmitCollectionForeach): Added support for valuetypes.
11287 2004-04-29 Martin Baulig <martin@ximian.com>
11289 * class.cs (Event.Define): Don't emit the field and don't set
11290 RTSpecialName and SpecialName for events on interfaces. Fixes
11293 2004-04-29 Raja R Harinath <rharinath@novell.com>
11295 Refactor Attribute.ApplyAttributes.
11296 * attribute.cs (Attributable): New base class for objects that can
11297 have Attributes applied on them.
11298 (Attribute): Make AttributeUsage fields public.
11299 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
11300 (Attribute.IsInternalCall): New property.
11301 (Attribute.UsageAttr): Convert to a public read-only property.
11302 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
11303 (Attribute.ResolveType, Attribute.Resolve)
11304 (Attribute.ScanForIndexerName): Update to reflect changes.
11305 (Attribute.CheckAttributeTarget): Re-format.
11306 (Attribute.ApplyAttributes): Refactor, to various
11307 Attributable.ApplyAttributeBuilder methods.
11308 * decl.cs (MemberCore): Make Attributable.
11309 * class.cs (Accessor): Make Attributable.
11310 (MethodData.ApplyAttributes): Use proper attribute types, not
11312 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
11313 (TypeContainer.ApplyAttributeBuilder)
11314 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
11315 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
11316 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
11317 (Operator.ApplyAttributeBuilder): New factored-out methods.
11318 * const.cs (Const.ApplyAttributeBuilder): Likewise.
11319 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
11320 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
11321 * parameter.cs (ParameterBase): New Attributable base class
11322 that can also represent Return types.
11323 (Parameter): Update to the changes.
11325 2004-04-29 Jackson Harper <jackson@ximian.com>
11327 * driver.cs: Prefer the corlib system version when looking for
11328 assemblies in the GAC. This is still a hack, but its a better hack
11331 2004-04-29 Marek Safar <marek.safar@seznam.cz>
11333 * decl.cs, enum.cs: Improved error 3005 reporting.
11335 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
11336 (related_symbols): New private member for list of symbols
11337 related to reported error/warning.
11339 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
11341 2004-04-29 Martin Baulig <martin@ximian.com>
11343 * ecore.cs (Expression.Constantify): If we're an enum and
11344 TypeManager.TypeToCoreType() doesn't give us another type, use
11345 t.UnderlyingSystemType. Fixes #56178.
11347 2004-04-29 Martin Baulig <martin@ximian.com>
11349 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
11350 interfaces and for each interface, only add members directly
11351 declared in that interface. Fixes #53255.
11353 2004-04-28 Martin Baulig <martin@ximian.com>
11355 * expression.cs (ConditionalLogicalOperator): Use a temporary
11356 variable for `left' to avoid that we evaluate it more than once;
11359 2004-04-28 Martin Baulig <martin@ximian.com>
11361 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
11364 2004-04-28 Martin Baulig <martin@ximian.com>
11366 * statement.cs (LocalInfo.Resolve): Check whether the type is not
11369 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
11370 whether the type is not void (CS1547).
11372 2004-04-28 Martin Baulig <martin@ximian.com>
11374 * expression.cs (Unary.DoResolveLValue): Override this and report
11375 CS0131 for anything but Operator.Indirection.
11377 2004-04-28 Martin Baulig <martin@ximian.com>
11379 Committing a patch from Ben Maurer; see bug #50820.
11381 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
11384 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
11387 2004-04-28 Martin Baulig <martin@ximian.com>
11389 Committing a patch from Ben Maurer; see bug #50820.
11391 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
11394 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
11397 2004-04-28 Martin Baulig <martin@ximian.com>
11399 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
11400 (Block.AddLabel): Call DoLookupLabel() to only search in the
11403 2004-04-28 Martin Baulig <martin@ximian.com>
11405 * cfold.cs (ConstantFold.BinaryFold): Added special support for
11406 comparing StringConstants and NullLiterals in Equality and Inequality.
11408 2004-04-28 Jackson Harper <jackson@ximian.com>
11410 * driver.cs: Attempt to load referenced assemblies from the
11411 GAC. This is the quick and dirty version of this method that
11412 doesnt take into account versions and just takes the first
11413 canidate found. Will be good enough for now as we will not have more
11414 then one version installed into the GAC until I update this method.
11416 2004-04-28 Martin Baulig <martin@ximian.com>
11418 * typemanager.cs (TypeManager.CheckStructCycles): New public
11419 static method to check for cycles in the struct layout.
11421 * rootcontext.cs (RootContext.PopulateTypes): Call
11422 TypeManager.CheckStructCycles() for each TypeContainer.
11423 [Note: We only need to visit each type once.]
11425 2004-04-28 Martin Baulig <martin@ximian.com>
11427 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
11429 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
11430 success and added `out object value'. Use a `bool resolved' field
11431 to check whether we've already been called rather than
11432 `ConstantValue != null' since this breaks for NullLiterals.
11434 2004-04-28 Raja R Harinath <rharinath@novell.com>
11436 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
11437 setting of this flag, since the 'set' method may be non-public.
11439 2004-04-28 Raja R Harinath <rharinath@novell.com>
11441 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
11442 check on current_vector.Block.
11444 2004-04-27 Martin Baulig <martin@ximian.com>
11446 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
11447 a field initializer. Fixes #56459.
11449 2004-04-27 Martin Baulig <martin@ximian.com>
11451 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
11452 we're not attempting to use an indexer. Fixes #52154.
11454 2004-04-27 Martin Baulig <martin@ximian.com>
11456 * statement.cs (Return): Don't create a return label if we don't
11457 need it; reverts my change from January 20th. Thanks to Ben
11460 2004-04-27 Martin Baulig <martin@ximian.com>
11462 According to the spec, `goto' can only leave a nested scope, but
11465 * statement.cs (Block.LookupLabel): Only lookup in the current
11466 block, don't recurse into parent or child blocks.
11467 (Block.AddLabel): Check in parent and child blocks, report
11468 CS0140/CS0158 if we find a duplicate.
11469 (Block): Removed this indexer for label lookups.
11470 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
11471 this already does the error reporting for us.
11474 (FlowBranching.UsageVector.Block): New public variable; may be null.
11475 (FlowBranching.CreateSibling): Added `Block' argument.
11476 (FlowBranching.LookupLabel): New public virtual method. Lookup a
11477 label for the target of a `goto' and check whether we're not
11478 leaving a `finally'.
11480 2004-04-27 Martin Baulig <martin@ximian.com>
11482 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
11483 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
11486 2004-04-27 Martin Baulig <martin@ximian.com>
11488 * statement.cs (Block.AddLabel): Also check for implicit blocks
11489 and added a CS0158 check.
11491 2004-04-27 Martin Baulig <martin@ximian.com>
11493 * flowanalysis.cs (FlowBranchingLoop): New class.
11494 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
11495 UsageVector's instead of an ArrayList.
11496 (FlowBranching.Label): Likewise.
11497 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
11498 (FlowBranching.AddBreakVector): New method.
11500 2004-04-27 Miguel de Icaza <miguel@ximian.com>
11502 * attribute.cs: Small regression fix: only convert the type if we
11503 the type is different, fixes System.Drawing build.
11505 2004-04-27 Martin Baulig <martin@ximian.com>
11507 * attribute.cs (Attribute.Resolve): If we have a constant value
11508 for a named field or property, implicity convert it to the correct
11511 2004-04-27 Raja R Harinath <rharinath@novell.com>
11513 * statement.cs (Block.Block): Implicit blocks share
11514 'child_variable_names' fields with parent blocks.
11515 (Block.AddChildVariableNames): Remove.
11516 (Block.AddVariable): Mark variable as "used by a child block" in
11517 every surrounding block.
11518 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
11519 been used in a child block, complain about violation of "Invariant
11520 meaning in blocks" rule.
11521 * cs-parser.jay (declare_local_variables): Don't use
11522 AddChildVariableNames.
11523 (foreach_statement): Don't create an implicit block: 'foreach'
11524 introduces a scope.
11526 2004-04-23 Miguel de Icaza <miguel@ximian.com>
11528 * convert.cs (ImplicitNumericConversion): 0 is also positive when
11529 converting from 0L to ulong. Fixes 57522.
11531 2004-04-22 Marek Safar <marek.safar@seznam.cz>
11533 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
11534 derived class hides via 'new' keyword field from base class (test-242.cs).
11535 TODO: Handle this in the more general way.
11537 * class.cs (CheckBase): Ditto.
11539 2004-04-22 Marek Safar <marek.safar@seznam.cz>
11541 * decl.cs (caching_flags): New member for storing cached values
11543 (MemberCore.Flags): New enum where bit flags for caching_flags
11545 (MemberCore.cls_compliance): Moved to caching_flags.
11546 (DeclSpace.Created): Moved to caching_flags.
11548 * class.cs: Use caching_flags instead of DeclSpace.Created
11550 2004-04-21 Miguel de Icaza <miguel@ximian.com>
11552 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
11553 if we are only a derived class, not a nested class.
11555 * typemanager.cs: Same as above, but do this at the MemberLookup
11556 level (used by field and methods, properties are handled in
11557 PropertyExpr). Allow for the qualified access if we are a nested
11560 2004-04-21 Marek Safar <marek.safar@seznam.cz>
11562 * class.cs: Refactoring.
11563 (IMethodData): New inteface; Holds links to parent members
11564 to avoid member duplication (reduced memory allocation).
11565 (Method): Implemented IMethodData interface.
11566 (PropertyBase): New inner classes for get/set methods.
11567 (PropertyBase.PropertyMethod): Implemented IMethodData interface
11568 (Event): New inner classes for add/remove methods.
11569 (Event.DelegateMethod): Implemented IMethodData interface.
11571 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
11572 EmitContext (related to class.cs refactoring).
11574 2004-04-21 Raja R Harinath <rharinath@novell.com>
11576 * delegate.cs (Delegate.VerifyApplicability): If the number of
11577 arguments are the same as the number of parameters, first try to
11578 verify applicability ignoring any 'params' modifier on the last
11582 2004-04-08 Martin Baulig <martin@ximian.com>
11584 Merged latest changes into gmcs. Please keep this comment in
11585 here, it makes it easier for me to see what changed in MCS since
11586 the last time I merged.
11588 2004-04-16 Raja R Harinath <rharinath@novell.com>
11590 * class.cs (TypeContainer.AddIndexer): Use
11591 'ExplicitInterfaceName' to determine if interface name was
11592 explicitly specified. 'InterfaceType' is not initialized at this time.
11593 (TypeContainer.DefineIndexers): Remove use of temporary list. The
11594 Indexers array is already in the required order. Initialize
11595 'IndexerName' only if there are normal indexers.
11596 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
11597 (TypeContainer.Emit): Emit DefaultMember attribute only if
11598 IndexerName is initialized.
11601 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
11603 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
11606 2004-04-15 Raja R Harinath <rharinath@novell.com>
11608 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
11612 * attribute.cs (Attribute.Resolve): Check for duplicate named
11616 2004-04-15 Miguel de Icaza <miguel@ximian.com>
11618 * iterators.cs (MarkYield): track whether we are in an exception,
11619 and generate code accordingly. Use a temporary value to store the
11620 result for our state.
11622 I had ignored a bit the interaction of try/catch with iterators
11623 since their behavior was not entirely obvious, but now it is
11624 possible to verify that our behavior is the same as MS .NET 2.0
11628 2004-04-14 Miguel de Icaza <miguel@ximian.com>
11630 * iterators.cs: Avoid creating temporaries if there is no work to
11633 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
11634 Enumerations, use TypeManager.EnumToUnderlying and call
11637 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
11640 (This.Emit): Use EmitContext.EmitThis to emit our
11643 (This.EmitAssign): Ditto.
11645 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
11646 codepaths, we will move all the functionality into
11649 (FieldExpr.EmitAssign): Ditto.
11651 This fixes several hidden bugs that I uncovered while doing a code
11652 review of this today.
11654 * codegen.cs (EmitThis): reworked so the semantics are more clear
11655 and also support value types "this" instances.
11657 * iterators.cs: Changed so that for iterators in value types, we
11658 do not pass the value type as a parameter.
11660 Initialization of the enumerator helpers is now done in the caller
11661 instead of passing the parameters to the constructors and having
11662 the constructor set the fields.
11664 The fields have now `assembly' visibility instead of private.
11666 2004-04-11 Miguel de Icaza <miguel@ximian.com>
11668 * expression.cs (Argument.Resolve): Check if fields passed as ref
11669 or out are contained in a MarshalByRefObject.
11671 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
11672 another compiler type.
11674 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
11676 * class.cs (Indexer.Define): use the new name checking method.
11677 Also, return false on an error.
11678 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
11679 (is_identifier_[start/part]_character): make static.
11681 2004-04-10 Miguel de Icaza <miguel@ximian.com>
11683 * expression.cs (Binary.ResolveOperator): Do no append strings
11684 twice: since we can be invoked more than once (array evaluation)
11685 on the same concatenation, take care of this here. Based on a fix
11686 from Ben (bug #56454)
11688 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
11690 * codegen.cs: Fix another case where CS1548 must be reported (when
11691 delay-sign isn't specified and no private is available #56564). Fix
11692 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
11693 error when MCS is used on the MS runtime and we need to delay-sign
11694 (which seems unsupported by AssemblyBuilder - see #56621).
11696 2004-04-08 Marek Safar <marek.safar@seznam.cz>
11698 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
11699 (TypeManager.ComputeNamespaces): Faster implementation for
11702 * compiler.csproj: Updated AssemblyName to mcs.
11704 2004-05-11 Jackson Harper <jackson@ximian.com>
11706 * Makefile: Preserve MONO_PATH
11708 2004-05-11 Jackson Harper <jackson@ximian.com>
11710 * Makefile: Use mono and mcs to build gmcs
11712 2004-05-03 Miguel de Icaza <miguel@ximian.com>
11714 * codegen.cs: Add patch from Robert Shade
11715 <rshade@dvsconsulting.com>, use FileAccess.Read on the keyfile, to
11718 2004-05-02 Sebastien Pouliot <sebastien@ximian.com>
11720 * CryptoConvert.cs: Updated to latest version. Fix issue with
11721 incomplete key pairs (#57941).
11723 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
11725 * codegen.cs: Fix another case where CS1548 must be reported (when
11726 delay-sign isn't specified and no private is available #56564). Fix
11727 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
11728 error when MCS is used on the MS runtime and we need to delay-sign
11729 (which seems unsupported by AssemblyBuilder - see #56621).
11731 2004-04-29 Jackson Harper <jackson@ximian.com>
11733 * Makefile: Set MONO_PATH to use the bootstrap corlib
11734 * driver.cs: Check the GAC for referenced assemblies.
11736 2004-04-29 Martin Baulig <martin@ximian.com>
11738 * Makefile (gmcs.exe): Set MONO_PATH to use `../class/lib/net_2_0'.
11740 2004-04-07 Martin Baulig <martin@ximian.com>
11742 * expression.cs (Binary.ResolveOperator): Added special case for
11743 Equality/Inequality between a type parameter and a null literal.
11745 2004-04-07 Martin Baulig <martin@ximian.com>
11747 * convert.cs: Check null literal -> type parameter conversions.
11749 2004-04-07 Martin Baulig <martin@ximian.com>
11751 * generic.cs (ConstructedType.CheckConstraints): Enforce the
11752 `class' and `struct' constraints.
11754 2004-04-07 Martin Baulig <martin@ximian.com>
11756 * generic.cs (SpecialConstraint): New public enum.
11757 (Constraints.Resolve): Added support for the `class' and `struct'
11760 * cs-parser.jay (type_parameter_constraint): Added support for the
11761 `class' and `struct' constraints.
11763 2004-04-07 Martin Baulig <martin@ximian.com>
11765 * support.cs (GenericConstraints): Replaced `Types' by
11766 `ClassConstraint' and `InterfaceConstraints'; added
11767 `HasClassConstraint'.
11769 2004-04-07 Martin Baulig <martin@ximian.com>
11772 (Constraints.InterfaceConstraints): New public property.
11773 (Constraints.Types): Make this property public
11774 (TypeParameter): Implement IMemberContainer.
11775 (TypeParameter.Define): Take a `GenericTypeParameterBuilder'
11776 instead of a TypeBuilder/MethodBuilder; pass the interface
11777 constraints to TypeManager.AddTypeParameter().
11778 (TypeParameter.DefineType): Just take an EmitContext and no
11779 TypeBuilder/MethodBuilder. Use the new public API.
11781 * typemanager.cs (TypeManager.AddTypeParameter): Added
11782 `TypeExpr[]' argument; add the interfaces to the
11783 `builder_to_ifaces' hash.
11784 (TypeManager.LookupMemberContainer): For
11785 GenericTypeParameterBuilders, get the TypeParameter from the
11786 `builder_to_type_param'.
11787 (TypeManager.FindMembers): For GenericTypeParameterBuilders, get
11788 the TypeParameter and call FindMembers on it.
11790 2004-04-07 Martin Baulig <martin@ximian.com>
11793 (MethodCore.GenericMethod): Moved this field here from Method.
11794 (MethodCore.IsDuplicateImplementation): Take the number of type
11795 parameters into account if we're a generic method.
11797 * expression.cs (Invocation.InferTypeArguments): Don't return true
11798 if `arguments' is null; we still need to check whether we actually
11799 don't need to infer anything in this case.
11800 (MemberAccess): Merged the functionality from GenericMemberAccess
11803 * generic.cs (GenericMemberAccess): Removed.
11805 2004-04-05 Martin Baulig <martin@ximian.com>
11807 * decl.cs (MemberCore): For generic classes, interfaces and
11808 structs, `Name' now includes the number of type parameters
11809 ("Stack!1.Node!1").
11810 (DeclSpace.FindType): Removed the `num_type_args' argument; we now
11811 encode the number of type arguments in the type name.
11813 * expression.cs (Expression.MemberLookup): Removed the
11814 `num_type_args' argument; we now encode the number of type
11815 arguments in the type name.
11817 * ecore.cs (SimpleName): Encode the number of type arguments in
11818 the type name itself.
11820 * generic.cs (ConstructedType): Likewise.
11822 * tree.cs (Tree.RecordDecl): Take a `string' instead of a
11823 `MemberName'; we now include the number of type parameters in the
11826 * typemanager.cs (TypeManager.CheckGeneric): Removed.
11827 (TypeManager.MemberLookup): Removed the
11828 `num_type_args' argument; we now encode the number of type
11829 arguments in the type name.
11831 2004-04-03 Martin Baulig <martin@ximian.com>
11833 * decl.cs (MemberCore.ctor): Take a MemberName instead of a sting.
11834 (MemberCore.MemberName): Moved here from MemberBase.
11835 (DeclSpace.SetParameterInfo): Just take the constraints as an
11836 ArrayList; we already have the type parameters in our
11837 `MemberName'; also do the CS0080 reporting here.
11839 * cs-parser.jay (struct_declaration): Use `member_name' instead of
11840 `IDENTIFIER opt_type_parameter_list'; when constructing our
11841 `MemberName', it'll already include our type parameters.
11842 (class_declaration, interface_declaration): Likewise.
11843 (delegate_declaration): Likewise.
11844 (MakeName): Take a MemberName and return a MemberName.
11845 The following two changes are required to avoid shift/reduce conflicts:
11846 (member_name): Don't include a TypeName anymore; ie. this is now
11847 just 'IDENTIFIER opt_type_parameter_list'.
11848 (property_declaration, event_declaration): Use a
11849 `namespace_or_type_name' instead of a `member_name'.
11851 2004-04-03 Martin Baulig <martin@ximian.com>
11853 * decl.cs (MemberName): Renamed to `TypeName' and created a new
11854 `MemberName' class.
11855 (TypeName): Formerly known as MemberName.
11857 * namespace.cs (NamespaceEntry.UsingAlias): Take a `TypeName'
11858 instead of a `MemberName'.
11860 * cs-parser.jay (namespace_or_type_name): Create a TypeName.
11861 (member_name): New rule; create a MemberName.
11863 2004-04-02 Martin Baulig <martin@ximian.com>
11865 * namespace.cs (NamespaceEntry.VerifyUsing): Added error checking
11866 (CS0305 and CS0308).
11868 2004-04-02 Martin Baulig <martin@ximian.com>
11870 * generic.cs (GenericMemberAccess.ResolveAsTypeStep): Added
11871 support for nested types.
11873 2004-04-02 Martin Baulig <martin@ximian.com>
11875 * ecore.cs (IAlias): New public interface.
11876 (TypeExpr, TypeExpression): Implement IAlias.
11877 (TypeAliasExpression): New public class.
11879 * namespace.cs (Namespace): Implement IAlias.
11880 (Namespace.Lookup): Return an IAlias instead on an object.
11881 (Namespace.DefineName): Take an IAlias instead of an object.
11882 (NamespaceEntry.AliasEntry.Resolve): Return an IAlias instead of
11884 (NamespaceEntry.UsingAlias): Take a Membername instead of an
11886 (NamespaceEntry.LookupAlias): Return an IAlias instead on an
11888 (NamespaceEntry.Lookup): Likewise.
11890 * rootcontext.cs (RootContext.LookupType): Return a TypeExpr
11893 * decl.cs (DeclSpace): Implement IAlias.
11894 (DeclSpace.LookupAlias): Return an IAlias instead of a string.
11896 * generic.cs (ConstructedType): Improved error checking.
11898 2004-04-02 Martin Baulig <martin@ximian.com>
11900 * convert.cs: Added type parameter conversions.
11903 (UnboxCast.Emit): Emit an `unbox.any' for type params.
11904 (ClassCast.Emit): If the source type is a type parameter, box it.
11905 If the target type is a type parameter, emit an `unbox.any'
11906 instead of a `classcast'.1
11908 2004-04-01 Martin Baulig <martin@ximian.com>
11910 * cs-tokenizer.cs (parse_less_than): Allow Token.DOT.
11912 2004-04-01 Martin Baulig <martin@ximian.com>
11914 * generic.cs (ConstructedType.CheckConstraints): Use
11915 Convert.ImplicitStandardConversionExists(); user-defined implicit
11916 conversions are not allowed according to the spec.
11918 2004-03-30 Martin Baulig <martin@ximian.com>
11920 * expression.cs (New): Added support for type parameters.
11923 (TypeManager.activator_type): New public static field.
11924 (TypeManager.activator_create_instance): Likewise.
11926 2004-03-30 Martin Baulig <martin@ximian.com>
11928 * typemanager.cs (TypeManager.HasConstructorConstraint): New
11931 2004-03-30 Martin Baulig <martin@ximian.com>
11933 * generic.cs (ConstructedType.CheckConstraints): Actually follow
11934 the spec here: the argument type must be convertible to the
11937 2004-03-30 Martin Baulig <martin@ximian.com>
11940 (TypeParameter.Define, TypeParameter.DefineMethod): Call
11941 TypeManager.AddTypeParameter().
11942 (ConstructedType.CheckConstraints): Re-enable this and actually
11943 check whether we have a constructor constraint.
11946 (TypeManager.builder_to_type_param): New static field.
11947 (TypeManager.AddTypeParameter): New static method.
11948 (TypeManager.LookupTypeParameter): New public method.
11950 2004-03-30 Martin Baulig <martin@ximian.com>
11952 * generic.cs (TypeParameter.DefineType): Return a boolean and use
11953 the new API to actually define the constructor constraint.
11956 (TypeManager.new_constraint_attr_type): New static field.
11957 (TypeManager.InitCoreTypes): Initialize it.
11959 2004-03-30 Martin Baulig <martin@ximian.com>
11961 * generic.cs (Constraints): Completed error checking, use correct
11964 2004-03-29 Martin Baulig <martin@ximian.com>
11966 * delegate.cs (Delegate.VerifyMethod): Infer type arguments.
11968 * expression.cs (Invocation.InferTypeArguments): Added overloaded
11969 public version which takes a `ParameterData pd' instead of an
11972 2004-03-29 Martin Baulig <martin@ximian.com>
11974 * typemanager.cs (TypeManager.IsGenericMethod): Take a MethodBase,
11977 2004-03-29 Martin Baulig <martin@ximian.com>
11979 * expression.cs (Argument.ResolveMethodGroup): If we're a
11980 ConstructedType, call GetMemberAccess() on it.
11982 2004-03-29 Martin Baulig <martin@ximian.com>
11984 * class.cs (MethodBase.CheckGenericOverride): New abstract method.
11985 (MethodCore.CheckGenericOverride): When overriding a generic
11986 method, check whether the constraints match.
11988 * support.cs (GenericConstraints): New public interface.
11989 (ParameterData.GenericConstraints): New public method.
11991 * parameter.cs (Parameter.Resolve): Check whether we're a generic
11992 method parameter and compute our constraints if appropriate.
11993 (Parameter.GenericConstraints): New public property.
11995 * generic.cs (Constraints): Implement GenericConstraints.
11997 2004-03-29 Martin Baulig <martin@ximian.com>
11999 * decl.cs (MemberCache.FindMemberToOverride): Use
12000 `paramTypes [j].Equals (cmpAttrs [j])' instead of `=='.
12002 2004-03-29 Martin Baulig <martin@ximian.com>
12004 * generic.cs (GenericMethod.Define): Resolve our type parameters.
12006 2004-03-29 Martin Baulig <martin@ximian.com>
12008 * cs-parser.jay: Report CS0080 instead of -200 ("Constraints are
12009 not allowed on non-generic declarations").
12011 2004-03-29 Martin Baulig <martin@ximian.com>
12013 * expression.cs (Invocation.InferTypeArguments): Added overloaded
12014 public version of this method.
12016 * class.cs (MethodCore.IsDuplicateImplementation): Use
12017 Invocation.InferTypeArguments() to check this.
12019 2004-03-29 Martin Baulig <martin@ximian.com>
12021 * convert.cs: Use TypeManager.IsDelegateType() instead of
12022 comparing types correctly.
12024 2004-03-29 Martin Baulig <martin@ximian.com>
12026 * convert.cs: Use TypeManager.IsSubclassOf() instead of comparing
12027 types directly to make it work for generic instances.
12029 * typemanager.cs (TypeManager.IsSubclassOf): New static method.
12031 2004-03-29 Martin Baulig <martin@ximian.com>
12033 * typemanager.cs (TypeManager.MayBecomeEqualGenericTypes): Added
12034 support for arrays.
12036 2004-03-24 Martin Baulig <martin@ximian.com>
12038 * decl.cs (DeclSpace.FindType): Also use
12039 TypeManager.CheckGeneric() for types from the using clauses.
12041 2004-03-23 Martin Baulig <martin@ximian.com>
12043 * expression.cs (Invocation.OverloadResolve): Added `bool
12044 may_fail' argument and use it instead of the Location.IsNull() hack.
12046 2004-03-23 Martin Baulig <martin@ximian.com>
12048 * expression.cs (Invocation.InferType): Use correct type inference
12051 2004-03-23 Martin Baulig <martin@ximian.com>
12053 * ecore.cs (MethodGroupExpr.Name): Use
12054 TypeManager.CSharpSignature() instead of just the name.
12056 * expression.cs (Invocation.OverloadResolve): Provide better error
12058 (Invocation.DoResolve): OverloadResolve() never returns null
12059 without reporting an error, so removed the error -6 reporting here.
12061 2004-03-23 Martin Baulig <martin@ximian.com>
12063 * typemanager.cs (TypeManager.GetMethodFlags): Fixed the FIXME for
12066 * cs-parser.jay (delegate_declaration): Support generic delegates.
12068 * delegate.cs: Support generic delegates.
12070 2004-03-22 Martin Baulig <martin@ximian.com>
12072 * expression.cs (Invocation.InferParamsTypeArguments): New static
12073 method; does type inference for params arguments.
12075 2004-03-21 Martin Baulig <martin@ximian.com>
12077 * typemanager.cs (TypeManager.IsGenericMethod): New public static
12078 method; checks whether a method is a generic method.
12080 * expression.cs (Invocation.InferTypeArguments): New static method;
12081 infer type arguments for generic method invocation.
12083 * ecore.cs (MethodGroupExpr.HasTypeArguments): New public
12084 property; we set this to true if we're resolving a generic method
12085 invocation and the user specified type arguments, ie. we're not
12086 doing type inference.
12088 2004-03-20 Martin Baulig <martin@ximian.com>
12090 * class.cs (MethodData.DeclaringType): New public property.
12091 (MethodData.Define): Set DeclaringType here.
12092 (Operator.Define): Use OperatorMethod.MethodData.DeclaringType
12093 instead of OperatorMethodBuilder.DeclaringType.
12095 2004-03-20 Martin Baulig <martin@ximian.com>
12097 * cs-tokenizer.cs (xtoken): Return a special
12098 Token.DEFAULT_OPEN_PARENS for "`default' followed by open parens".
12100 * cs-parser.jay (default_value_expression): Switch to the new
12103 2004-03-19 Martin Baulig <martin@ximian.com>
12105 * decl.cs (MemberName): New class. We use this to "construct"
12106 namespace_or_type_name's.
12108 * generics.cs (TypeArguments.GetDeclarations): New public method;
12109 returns the type arguments as a string[] and reports a CS0081 if
12110 one of them is not an identifier.
12112 * class.cs (MemberBase): The .ctor now takes the name as a
12113 MemberName instead of a string.
12114 (MemberBase.ExplicitInterfaceName): Changed type from string to
12116 (MemberBase.DoDefine): If we're an explicit implementation, the
12117 InterfaceType may be a generic instance.
12119 * cs-parser.jay (namespace_or_type_name): Return a MemberName.
12120 (namespace_name): Call MemberName.GetName () to transform the
12121 MemberName into a string and ensure we don't have any type
12123 (type_name): Call MemberName.GetTypeExpression() to transfrom the
12124 MemberName into an expression.
12125 (method_header): Use namespace_or_type_name instead of member_name.
12127 2004-04-07 Miguel de Icaza <miguel@ximian.com>
12129 * rootcontext.cs: Add new types to the boot resolution.
12131 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
12132 MulticastDelegate is not allowed.
12134 * typemanager.cs: Add new types to lookup: System.TypedReference
12137 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
12138 check for TypedReference or ArgIterator, they are not allowed.
12140 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
12141 makes us properly catch 1510 in some conditions (see bug 56016 for
12144 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
12146 * CryptoConvert.cs: update from corlib version
12149 2004-04-05 Miguel de Icaza <miguel@ximian.com>
12151 * class.cs (Indexer.Define): Check indexername declaration
12153 2004-04-05 Marek Safar <marek.safar@seznam.cz>
12155 * attribute.cs (IsClsCompliant): Fixed problem with handling
12156 all three states (compliant, not-compliant, undetected).
12158 2004-03-30 Marek Safar <marek.safar@seznam.cz>
12160 * attribute.cs (Attribute): Location is now public.
12161 (Resolve): Store resolved arguments (pos_values) in attribute class.
12162 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
12163 (GetClsCompliantAttributeValue): New method that gets
12164 CLSCompliantAttribute value.
12165 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
12166 if exists else null.
12167 (AttributeTester): New class for CLS-Compliant verification routines.
12169 * class.cs (Emit): Add CLS-Compliant verification.
12170 (Method.GetSignatureForError): Implemented.
12171 (Constructor.GetSignatureForError): Implemented
12172 (Constructor.HasCompliantArgs): Returns if constructor has
12173 CLS-Compliant arguments.
12174 (Constructor.Emit): Override.
12175 (Construcor.IsIdentifierClsCompliant): New method; For constructors
12176 is needed to test only parameters.
12177 (FieldBase.GetSignatureForError): Implemented.
12178 (TypeContainer): New member for storing base interfaces.
12179 (TypeContainer.FindMembers): Search in base interfaces too.
12181 * codegen.cs (GetClsComplianceAttribute): New method that gets
12182 assembly or module CLSCompliantAttribute value.
12183 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
12185 (ModuleClass.Emit): Add error 3012 test.
12187 * const.cs (Emit): Override and call base for CLS-Compliant tests.
12189 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
12190 state for all decl types.
12191 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
12192 if CLS-Compliant tests are required.
12193 (IsClsCompliaceRequired): New method. Analyze whether code
12194 must be CLS-Compliant.
12195 (IsExposedFromAssembly): New method. Returns true when MemberCore
12196 is exposed from assembly.
12197 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
12198 value or gets cached value.
12199 (HasClsCompliantAttribute): New method. Returns true if MemberCore
12200 is explicitly marked with CLSCompliantAttribute.
12201 (IsIdentifierClsCompliant): New abstract method. This method is
12202 used to testing error 3005.
12203 (IsIdentifierAndParamClsCompliant): New method. Common helper method
12204 for identifier and parameters CLS-Compliant testing.
12205 (VerifyClsCompliance): New method. The main virtual method for
12206 CLS-Compliant verifications.
12207 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
12208 null. I don't know why is null (too many public members !).
12209 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
12210 and get value of first CLSCompliantAttribute that found.
12212 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
12213 (VerifyClsCompliance): Override and add extra tests.
12215 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
12216 clscheck- disable CLS-Compliant verification event if assembly is has
12217 CLSCompliantAttribute(true).
12219 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
12220 ApllyAttribute is now called in emit section as in the other cases.
12221 Possible future Emit integration.
12222 (IsIdentifierClsCompliant): New override.
12223 (VerifyClsCompliance): New override.
12224 (GetEnumeratorName): Returns full enum name.
12226 * parameter.cs (GetSignatureForError): Implemented.
12228 * report.cs (WarningData): New struct for Warning message information.
12229 (LocationOfPreviousError): New method.
12230 (Warning): New method. Reports warning based on the warning table.
12231 (Error_T): New method. Reports error based on the error table.
12233 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
12234 verifications are done here.
12236 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
12238 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
12239 CLSCompliantAttribute.
12240 (all_imported_types): New member holds all imported types from other
12242 (LoadAllImportedTypes): New method fills static table with exported types
12243 from all referenced assemblies.
12244 (Modules): New property returns all assembly modules.
12246 2004-03-30 Miguel de Icaza <miguel@ximian.com>
12248 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
12249 throwing a parser error.
12251 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
12252 which removes the hardcoded get_/set_ prefixes for properties, as
12253 IL allows for the properties to be named something else.
12257 * expression.cs: Do not override operand before we know if it is
12258 non-null. Fix 56207
12260 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
12262 * typemanager.cs: support for pinned variables.
12264 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
12266 * decl.cs, typemanager.cs: Avoid using an arraylist
12267 as a buffer if there is only one result set.
12269 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
12271 * expression.cs: Make sure you cant call a static method
12272 with an instance expression, bug #56174.
12274 2004-03-29 Miguel de Icaza <miguel@ximian.com>
12276 * class.cs (IsDuplicateImplementation): Improve error reporting to
12277 flag 663 (method only differs in parameter modifier).
12279 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
12280 in preprocessor directives.
12282 * location.cs (LookupFile): Allow for the empty path.
12284 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
12285 better approach for some of that patch, but its failing with the
12286 CharSet enumeration. For now try/catch will do.
12288 * typemanager.cs: Do not crash if a struct does not have fields.
12291 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
12293 * expression.cs: cs0213, cant fix a fixed expression.
12296 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
12298 * cs-parser.jay: detect invalid embeded statements gracefully.
12301 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
12303 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
12306 the invocation type may not be a subclass of the tye of the item/
12307 The type of the item must be a subclass of the invocation item.
12312 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
12314 * attribute.cs: Added methods to get a string and a bool from an
12315 attribute. Required to information from AssemblyKeyFileAttribute,
12316 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
12317 * codegen.cs: Modified AssemblyName creation to include support for
12318 strongnames. Catch additional exceptions to report them as CS1548.
12319 * compiler.csproj: Updated include CryptoConvert.cs.
12320 * compiler.csproj.user: Removed file - user specific configuration.
12321 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
12322 Mono.Security assembly. The original class is maintained and tested in
12323 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
12324 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
12325 like CSC 8.0 (C# v2) supports.
12326 * Makefile: Added CryptoConvert.cs to mcs sources.
12327 * rootcontext.cs: Added new options for strongnames.
12329 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
12331 * driver.cs: For --expect-error, report error code `2'
12332 if the program compiled with no errors, error code `1' if
12333 it compiled with an error other than the one expected.
12335 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
12337 * compiler.csproj: Updated for Visual Studio .NET 2003.
12338 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
12339 * compiler.sln: Updated for Visual Studio .NET 2003.
12341 2004-03-24 Ravi Pratap M <ravi@ximian.com>
12343 * expression.cs: Fix bug #47234. We basically need to apply the
12344 rule that we prefer the conversion of null to a reference type
12345 when faced with a conversion to 'object' (csc behaviour).
12347 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
12349 * statement.cs: Shorter form for foreach, eliminates
12350 a local variable. r=Martin.
12352 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
12354 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
12355 checks if we can use brtrue/brfalse to test for 0.
12356 * expression.cs: use the above in the test for using brtrue/brfalse.
12357 cleanup code a bit.
12359 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
12361 * expression.cs: Rewrite string concat stuff. Benefits:
12363 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
12364 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
12365 rather than a concat chain.
12367 * typemanager.cs: Add lookups for more concat overloads.
12369 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
12371 * expression.cs: Emit shorter il code for array init.
12388 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
12390 * statement.cs: Before, two switch blocks would be merged if the
12391 total size of the blocks (end_item - begin_item + 1) was less than
12392 two times the combined sizes of the blocks.
12394 Now, it will only merge if after the merge at least half of the
12399 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
12401 * class.cs : csc build fix for GetMethods(). See bug #52503.
12403 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
12405 * expression.cs: Make sure fp comparisons work with NaN.
12406 This fixes bug #54303. Mig approved this patch a long
12407 time ago, but we were not able to test b/c the runtime
12410 2004-03-19 Miguel de Icaza <miguel@ximian.com>
12412 * ecore.cs (TypExpr.GetHashCode): implement this overload.
12414 2004-03-19 Martin Baulig <martin@ximian.com>
12416 * class.cs (MemberCore.IsDuplicateImplementation): Check whether
12417 two overloads may unify for some type parameter substitutions and
12418 report a CS0408 if appropriate.
12420 2004-03-19 Martin Baulig <martin@ximian.com>
12422 * class.cs (MemberCore.IsDuplicateImplementation): Report the
12423 error here and not in our caller.
12425 2004-03-19 Martin Baulig <martin@ximian.com>
12427 * interface.cs: Completely killed this file.
12428 (Interface): We're now a TypeContainer and live in class.cs.
12430 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
12431 argument; we're now also called for interfaces.
12432 (TypeContainer.DefineMembers): Allow this method being called
12434 (TypeContainer.GetMethods): New public method; formerly known as
12435 Interface.GetMethod(). This is used by PendingImplementation.
12436 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
12437 it's now private and non-static.
12438 (Interface): Moved this here; it's now implemented similar to
12440 (Method, Property, Event, Indexer): Added `bool is_interface'
12441 argument to their .ctor's.
12442 (MemberBase.IsInterface): New public field.
12444 * cs-parser.jay: Create normal Method, Property, Event, Indexer
12445 instances instead of InterfaceMethod, InterfaceProperty, etc.
12446 (opt_interface_base): Removed; we now use `opt_class_base' instead.
12447 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
12449 2004-03-19 Martin Baulig <martin@ximian.com>
12451 * class.cs (MethodCore.IsDuplicateImplementation): New private
12452 method which does the CS0111 checking.
12453 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
12454 Use IsDuplicateImplementation().
12456 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
12458 * decl.cs (FindMemberToOverride): New method to find the correct
12459 method or property to override in the base class.
12461 - Make Method/Property use the above method to find the
12462 version in the base class.
12463 - Remove the InheritableMemberSignatureCompare as it is now
12466 This patch makes large code bases much faster to compile, as it is
12467 O(n) rather than O(n^2) to do this validation.
12469 Also, it fixes bug 52458 which is that nested classes are not
12470 taken into account when finding the base class member.
12472 Reviewed/Approved by Martin.
12474 2004-03-17 Martin Baulig <martin@ximian.com>
12476 * expression.cs (MemberAccess.DoResolve): Take the parent's number
12477 of type arguments into account; use the `real_num_type_args'
12478 approach like in DoResolveAsTypeStep().
12480 * generic.cs (GenericMemberAccess.DoResolve): Make this work for
12483 2004-03-17 Marek Safar <marek.safar@seznam.cz>
12485 * interface.cs: In all interface classes removed redundant
12486 member initialization.
12488 2004-03-16 Martin Baulig <martin@ximian.com>
12490 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
12492 2004-03-15 Miguel de Icaza <miguel@ximian.com>
12494 * decl.cs (DefineTypeAndParents): New helper method to define a
12495 type's containers before the type itself is defined; This is a
12496 bug exposed by the recent changes to Windows.Forms when an
12497 implemented interface was defined inside a class that had not been
12500 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
12502 (Check): Loop correctly to report errors modifiers
12503 (UNSAFE was not in the loop, since it was the same as TOP).
12505 * interface.cs: Every interface member now takes a ModFlags,
12506 instead of a "is_new" bool, which we set on the base MemberCore.
12508 Every place where we called "UnsafeOk" in the interface, now we
12509 call the proper member (InterfaceMethod.UnsafeOK) instead to get
12510 the unsafe settings from the member declaration instead of the
12511 container interface.
12513 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
12515 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
12516 `set_indexer_name' to the pending bits (one per type).
12518 We fixed a bug today that was picking the wrong method to
12519 override, since for properties the existing InterfaceMethod code
12520 basically ignored the method name. Now we make sure that the
12521 method name is one of the valid indexer names.
12523 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
12525 * support.cs (SeekableStreamReader): Keep track of stream byte
12526 positions and don't mix them with character offsets to the buffer.
12528 Patch from Gustavo Giráldez
12530 2004-03-15 Marek Safar <marek.safar@seznam.cz>
12532 * interface.cs (InterfaceSetGetBase): Removed double member
12533 initialization, base class does it as well.
12535 2004-03-13 Martin Baulig <martin@ximian.com>
12537 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
12538 when compiling corlib.
12540 2004-03-13 Miguel de Icaza <miguel@ximian.com>
12542 * convert.cs (ExplicitConversion): We were reporting an error on
12543 certain conversions (object_type source to a value type, when the
12544 expression was `null') before we had a chance to pass it through
12545 the user defined conversions.
12547 * driver.cs: Replace / and \ in resource specifications to dots.
12550 * class.cs: Add check for duplicate operators. Fixes 52477
12552 2004-03-11 Miguel de Icaza <miguel@ximian.com>
12554 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
12555 that are in the middle of the statements, not only at the end.
12558 * class.cs (TypeContainer.AddField): No longer set the
12559 `HaveStaticConstructor' flag, now we call it
12560 `UserDefineStaticConstructor' to diferentiate the slightly
12561 semantic difference.
12563 The situation is that we were not adding BeforeFieldInit (from
12564 Modifiers.TypeAttr) to classes that could have it.
12565 BeforeFieldInit should be set to classes that have no static
12570 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
12572 And most importantly Zoltan's comment:
12574 http://bugzilla.ximian.com/show_bug.cgi?id=44229
12576 "I think beforefieldinit means 'it's ok to initialize the type sometime
12577 before its static fields are used', i.e. initialization does not need
12578 to be triggered by the first access to the type. Setting this flag
12579 helps the JIT to compile better code, since it can run the static
12580 constructor at JIT time, and does not need to generate code to call it
12581 (possibly lots of times) at runtime. Unfortunately, mcs does not set
12582 this flag for lots of classes like String.
12584 csc sets this flag if the type does not have an explicit static
12585 constructor. The reasoning seems to be that if there are only static
12586 initalizers for a type, and no static constructor, then the programmer
12587 does not care when this initialization happens, so beforefieldinit
12590 This bug prevents the AOT compiler from being usable, since it
12591 generates so many calls to mono_runtime_class_init that the AOT code
12592 is much slower than the JITted code. The JITted code is faster,
12593 because it does not generate these calls if the vtable is type is
12594 already initialized, which is true in the majority of cases. But the
12595 AOT compiler can't do this."
12597 2004-03-10 Miguel de Icaza <miguel@ximian.com>
12599 * class.cs (MethodData.Emit): Refactor the code so symbolic
12600 information is generated for destructors; For some reasons we
12601 were taking a code path that did not generate symbolic information
12604 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
12606 * class.cs: Create a Constructor.CheckBase method that
12607 takes care of all validation type code. The method
12608 contains some code that was moved from Define.
12610 It also includes new code that checks for duplicate ctors.
12611 This fixes bug #55148.
12613 2004-03-09 Joshua Tauberer <tauberer@for.net>
12615 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
12616 a { ... }-style array creation invokes EmitStaticInitializers
12617 which is not good for reference-type arrays. String, decimal
12618 and now null constants (NullCast) are not counted toward
12619 static initializers.
12621 2004-03-05 Martin Baulig <martin@ximian.com>
12623 * location.cs (SourceFile.HasLineDirective): New public field;
12624 specifies whether the file contains or is referenced by a "#line"
12626 (Location.DefineSymbolDocuments): Ignore source files which
12627 either contain or are referenced by a "#line" directive.
12629 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
12631 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
12632 direct access to our parent, so check the method inline there.
12634 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
12636 * expression.cs (Invocation.EmitCall): Miguel's last commit
12637 caused a regression. If you had:
12642 In Foo the implict this would be null.
12644 2004-02-27 Miguel de Icaza <miguel@ximian.com>
12646 * expression.cs (Invocation.EmitCall): If the method is not
12647 virtual, do not emit a CallVirt to it, use Call.
12649 * typemanager.cs (GetFullNameSignature): Improve the method to
12650 cope with ".ctor" and replace it with the type name.
12652 * class.cs (ConstructorInitializer.Resolve): Now the method takes
12653 as an argument the ConstructorBuilder where it is being defined,
12654 to catch the recursive constructor invocations.
12656 2004-03-16 Martin Baulig <martin@ximian.com>
12658 * expression.cs (MemberAccess.DoResolve): If `expr' resolved to a
12659 ConstructedType, call ResolveType() on it to get the type rather
12660 than just using `expr.Type'.
12662 2004-03-16 Martin Baulig <martin@ximian.com>
12664 * generics.cs (ConstructedType.GetMemberAccess): Take the
12665 EmitContext instead on the TypeExpr and use
12666 ec.TypeContainer.CurrentType/ec.ContainerType.
12668 2004-03-16 Martin Baulig <martin@ximian.com>
12670 * ecore.cs (SimpleName.DoResolveAsTypeStep): Lookup type
12671 parameters before aliases.
12673 2004-03-16 Martin Baulig <martin@ximian.com>
12675 * typemanager.cs (TypeManager.MayBecomeEqualGenericInstances):
12676 New oublic function; checks whether two generic instances may become
12677 equal under some instantiations (26.3.1).
12679 * class.cs (TypeContainer.Define): Call
12680 TypeManager.MayBecomeEqualGenericInstances() and report CS0695 on
12683 2004-03-16 Martin Baulig <martin@ximian.com>
12685 * class.cs (TypeContainer.GetClassBases): Moved
12686 Error_TypeParameterAsBase() here and also check whether the base
12687 class is not an attribute.
12689 2004-03-16 Martin Baulig <martin@ximian.com>
12691 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
12693 2004-03-16 Martin Baulig <martin@ximian.com>
12695 * class.cs (Error_TypeParameterAsBase): Use correct error number
12698 2004-03-16 Martin Baulig <martin@ximian.com>
12700 * decl.cs (DeclSpace.ResolveTypeExpr): Added more error checking
12703 * generics.cs (ConstructedType.DoResolveAsTypeStep): Added better
12706 2004-03-15 Martin Baulig <martin@ximian.com>
12708 * typemanager.cs (TypeManager.GetFullName): New public method.
12709 (TypeManager.MemberLookup): Added `int_num_type_arguments'
12710 argument; only return members with the correct number of type
12712 (TypeManager.CheckGeneric): Allow -1 to bypass the check.
12713 (TypeManager.FilterWithClosure): Call CheckGeneric() to check
12714 whether the number of type arguments matches.
12716 * generic.cs (GenericMemberAccess.ResolveAsTypeStep): Allow `expr'
12717 not being a ConstructedType; we can now do "typeof (Foo.Bar<U>)".
12719 * expression.cs (MemberAccess): Added public `NumTypeArguments'
12720 field; it's set by the protected .ctor when we're actually a
12721 GenericMemberAccess.
12722 (MemberAccess.ResolveAsTypeStep): Compute the total number of type
12723 arguments and pass it to MemberLookupFinal ().
12725 * ecore.cs (Expression.MemberLookup): Added `int
12726 num_type_arguments' argument; only return members with the correct
12727 number of type arguments.
12728 (Expression.MemberLookupFailed): Check whether the MemberLookup
12729 failed because we did not have the correct number of type
12730 arguments; report CS0305 in this case.
12732 * decl.cs (DeclSpace.ResolveTypeExpr): Don't report an error if
12733 `e.ResolveAsTypeTerminal()' already did so.
12735 2004-03-15 Martin Baulig <martin@ximian.com>
12737 * ecore.cs (Expression.ResolveLValue): Allow e.type being null if
12738 we're a ConstructedType; in this case, the caller must report an
12739 error (for instance CS0131).
12741 * generic.cs (TypeArguments): Added Location argument to the .ctor.
12742 (TypeArguments.Resolve): Actually report errors here.
12744 2004-03-15 Miguel de Icaza <miguel@ximian.com>
12746 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
12747 `set_indexer_name' to the pending bits (one per type).
12749 We fixed a bug today that was picking the wrong method to
12750 override, since for properties the existing InterfaceMethod code
12751 basically ignored the method name. Now we make sure that the
12752 method name is one of the valid indexer names.
12754 2004-03-15 Martin Baulig <martin@ximian.com>
12756 * typemanager.cs (TypeManager.IndexerPropertyName): Added support
12757 for generic instances.
12759 2004-03-13 Martin Baulig <martin@ximian.com>
12761 * class.cs (TypeContainer.DefineType): Call
12762 TypeManager.AddUserType() immediately after creating the
12763 TypeBuilder; pass all type parameters when creating the
12766 * decl.cs (DeclSpace.FindNestedType): New public method.
12767 (DeclSpace.FindType): Added `int num_type_args' argument; only
12768 return types with the correct number of type parameters.
12769 (DeclSpace.CountTypeParams): New public property.
12771 * ecore.cs (SimpleName.ctor): Added overloaded version which takes
12772 the number of type parameters; defaults to zero.
12774 * generic.cs (TypeArguments.Count): New public property.
12775 (ConstructedType.DoResolveAsTypeStep): First call
12776 ds.FindNestedType() to find out whether we're nested in the
12777 current generic type; in this case, we inherit all type parameters
12778 from the current class.
12780 * rootcontext.cs (RootContext.NamespaceLookup): Added `int
12781 num_type_args' argument.
12782 (RootContext.LookupType): Added overloaded version which takes the
12783 number of type arguments; only return types with the correct
12784 number of type arguments.
12786 * typemanager.cs (TypeManager.CheckGeneric): New public function;
12787 checks whether `Type t' has `int num_type_args'.
12789 2004-03-13 Martin Baulig <martin@ximian.com>
12791 * generic.cs (GenericMethod.DefineType): New method; calls
12792 DefineType() on all the type parameters.
12794 * class.cs (MethodData.ctor): Added `GenericMethod generic' argument.
12795 (MethodData.Define): If we're a generic method, call
12796 GenericMethod.DefineType() to define the type parameters.
12798 2004-03-10 Martin Baulig <martin@ximian.com>
12800 * pending.cs (Pending.InterfaceMethod): Use TypeManager.IsEqual()
12801 instead of IsAssignableFrom.
12803 2004-03-10 Martin Baulig <martin@ximian.com>
12805 * ecore.cs (FieldExpr.ctor): Use TypeManager.TypeToCoreType().
12807 * support.cs (ParameterData.HasArrayParameter): New property.
12808 (ReflectionParameters.ctor): Take a MethodBase instead of a
12809 ParameterInfo[]. If we have any type parameters, get the generic
12810 method definition and ask it whether we have variable arguments.
12812 2004-02-26 Miguel de Icaza <miguel@ximian.com>
12814 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
12815 routines to check if a type is an enumerable/enumerator allow
12816 classes that implement the IEnumerable or IEnumerator interfaces.
12818 * class.cs (Property, Operator): Implement IIteratorContainer, and
12819 implement SetYields.
12821 (Property.Define): Do the block swapping for get_methods in the
12822 context of iterators. We need to check if Properties also
12823 include indexers or not.
12825 (Operator): Assign the Block before invoking the
12826 OperatorMethod.Define, so we can trigger the Iterator code
12829 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
12830 Property and Operator classes are not created when we parse the
12831 declarator but until we have the block completed, so we use a
12832 singleton SimpleIteratorContainer.Simple to flag whether the
12833 SetYields has been invoked.
12835 We propagate this setting then to the Property or the Operator to
12836 allow the `yield' to function.
12838 2004-02-25 Marek Safar <marek.safar@seznam.cz>
12840 * codegen.cs: Implemented attribute support for modules.
12841 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
12842 Assembly/Module functionality.
12844 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
12845 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
12846 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
12848 2004-02-16 Marek Safar <marek.safar@seznam.cz>
12850 * interface.cs (FindMembers): The operation is performed on all base
12851 interfaces and not only on the first. It is required for future CLS Compliance patch.
12853 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
12855 * statement.cs, codegen.cs:
12856 This patch deals with patterns such as:
12858 public class List : IEnumerable {
12860 public MyEnumerator GetEnumerator () {
12861 return new MyEnumerator(this);
12864 IEnumerator IEnumerable.GetEnumerator () {
12868 public struct MyEnumerator : IEnumerator {
12873 Before, there were a few things we did wrong:
12874 1) we would emit callvirt on a struct, which is illegal
12875 2) we emited ldarg when we needed to emit ldarga
12876 3) we would mistakenly call the interface methods on an enumerator
12877 type that derived from IEnumerator and was in another assembly. For example:
12879 public class MyEnumerator : IEnumerator
12881 Would have the interface methods called, even if there were public impls of the
12882 method. In a struct, this lead to invalid IL code.
12884 2004-02-11 Marek Safar <marek.safar@seznam.cz>
12886 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
12889 * delegate.cs (Define): Fixed crash when delegate type is undefined.
12891 2004-02-11 Miguel de Icaza <miguel@ximian.com>
12893 * cs-parser.jay: Fix small regression: we were not testing V2
12894 compiler features correctly.
12896 * interface.cs: If the emit context is null, then create one
12898 2004-02-09 Marek Safar <marek.safar@seznam.cz>
12900 * decl.cs (GetSignatureForError): New virtual method to get full name
12901 for error messages.
12903 * attribute.cs (IAttributeSupport): New interface for attribute setting.
12904 Now it is possible to rewrite ApplyAttributes method to be less if/else.
12906 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
12907 Duplicated members and code in these classes has been removed.
12908 Better encapsulation in these classes.
12910 2004-02-07 Miguel de Icaza <miguel@ximian.com>
12912 * assign.cs (Assign.DoResolve): When dealing with compound
12913 assignments, there is a new rule in ECMA C# 2.4 (might have been
12914 there before, but it is documented here) that states that in:
12918 If b is of type int, and the `op' is a shift-operator, then the
12919 above is evaluated as:
12923 * expression.cs (Binary.ResolveOperator): Instead of testing for
12924 int/uint/long/ulong, try to implicitly convert to any of those
12925 types and use that in pointer arithmetic.
12927 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
12928 method to print information for from the type, not from the
12929 null-method we were given.
12931 2004-02-01 Duncan Mak <duncan@ximian.com>
12933 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
12934 parsing for cmd, fixes bug #53694.
12936 2004-02-04 Marek Safar <marek.safar@seznam.cz>
12938 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
12939 in the member name duplication tests. Property and operator name duplication
12940 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
12942 2004-02-03 Marek Safar <marek.safar@seznam.cz>
12944 * interface.cs (PopulateMethod): Fixed crash when interface method
12945 returns not existing type (error test cs0246-3.cs).
12947 2004-02-02 Ravi Pratap M <ravi@ximian.com>
12949 * cs-parser.jay (interface_accessors): Re-write actions to also
12950 store attributes attached to get and set methods. Fix spelling
12953 (inteface_property_declaration): Modify accordingly.
12955 (InterfaceAccessorInfo): New helper class to store information to pass
12956 around between rules that use interface_accessors.
12958 * interface.cs (Emit): Apply attributes on the get and set
12959 accessors of properties and indexers too.
12961 * attribute.cs (ApplyAttributes): Modify accordingly to use the
12962 right MethodBuilder when applying attributes to the get and set accessors.
12964 2004-01-31 Miguel de Icaza <miguel@ximian.com>
12966 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
12968 2004-01-26 Miguel de Icaza <miguel@ximian.com>
12970 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
12972 2004-01-25 Miguel de Icaza <miguel@ximian.com>
12974 * cs-parser.jay: Remove YIELD token, instead use the new grammar
12975 changes that treat `yield' specially when present before `break'
12976 or `return' tokens.
12978 * cs-tokenizer.cs: yield is no longer a keyword.
12980 2004-01-23 Marek Safar <marek.safar@seznam.cz>
12982 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
12983 setting for default constructors.
12984 For default constructors are almost every time set wrong Modifier. The
12985 generated IL code has been alright. But inside mcs this values was
12986 wrong and this was reason why several of my CLS Compliance tests
12989 2004-02-27 Martin Baulig <martin@ximian.com>
12991 * generics.cs (ConstructedType.ResolveType): Make the nested type
12992 stuff actually work.
12994 2004-02-25 Martin Baulig <martin@ximian.com>
12996 * decl.cs (DeclSpace.CurrentTypeParameters): New protected
12997 property; returns the type parameters just from the current type,
12998 ie. with the ones from outer classes.
12999 (DeclSpace.LookupGeneric): First search in the current class, then
13001 (DeclSpace.initialize_type_params): When hiding a type parameter
13002 from an outer class, put it into the `type_param_list' anyways.
13004 * expression.cs (MemberAccess.expr): Made this field protected.
13006 * class.cs (TypeContainer.Define): The `CurrentType' just contains
13007 the type parameters from the current class.
13009 * generic.cs (ConstructedType.ResolveType): Support nested generic
13010 types by taking the type parameters which we inherit from outer
13011 classes into account.
13012 (GenericMemberAccess.ResolveAsTypeStep): Override this and added
13013 support for nested generic types.
13015 2004-02-23 Martin Baulig <martin@ximian.com>
13017 * decl.cs (DeclSpace.IsGeneric): Make this a property instead of a
13018 field and check whether we're nested inside a generic type.
13019 (DeclSpace.ResolveType): If we're resolving to a generic type
13020 definition, create a ConstructedType and return its resolved type.
13021 (DeclSpace.initialize_type_params): New private method;
13022 initializes the `type_param_list' field from the type parameters
13023 from this and all enclosing classes.
13024 (DeclSpace.TypeParameters): Call initialize_type_params() unless
13025 we're already initialized.
13027 2004-02-23 Martin Baulig <martin@ximian.com>
13029 * class.cs (Method.Define): Create the generic method before
13030 calling DoDefine().
13031 (Memberbase.DoDefine): Added DeclSpace argument (in addition to
13032 the TypeContainer one); we use this for generic methods.
13034 * decl.cs (CheckAccessLevel): If we're a GenericMethod, use our
13035 parent's TypeBuilder.
13037 2004-02-18 Martin Baulig <martin@ximian.com>
13039 * ecore.cs (FieldExpr.DoResolveLValue): Use TypeManager.IsEqual()
13040 to check for equality.
13042 2004-02-05 Martin Baulig <martin@ximian.com>
13044 * ecore.cs (FieldExpr.DoResolveLValue): If we have an
13045 `ec.TypeContainer.CurrentType', use it instead of
13046 `ec.ContainerType' to check whether we're in the type's ctor.
13048 2004-01-29 Martin Baulig <martin@ximian.com>
13050 * expression.cs (Invocation.DoResolve): If we're a
13051 `ConstructedType', then we're actually a generic method, so
13052 rewrite the expr as a GenericMemberAccess.
13054 * cs-parser.jay (member_name): Don't use `namespace_or_type_name'
13055 here; manually parse it into a string.
13057 2004-01-28 Martin Baulig <martin@ximian.com>
13059 * typemanager.cs (TypeManager.IsEqual): New static method.
13060 (TypeManager.FilterWithClosure): Call TypeManager.IsEqual() to
13061 check for equality instead of using `=='.
13063 2004-01-26 Martin Baulig <martin@ximian.com>
13065 * decl.cs (DeclSpace.CurrentType): New public field.
13067 * expression.cs (This.ResolveBase): If we have an
13068 `ec.TypeContainer.CurrentType', use it instead of
13069 `ec.ContainerType'.
13071 * class.cs (TypeContainer.DefineType): If we're a generic type,
13072 create the `CurrentType' (unresolved).
13073 (TypeContainer.GenericType): New private field.
13074 (TypeContainer.DefineMembers): If we have a `CurrentType', resolve
13075 it and store it in `GenericType' before creating the MemberCache.
13076 (TypeContainer.GetMembers): If we have a `GenericType', call
13077 TypeManager.FindMembers() on it.
13079 * interface.cs (Interface.GenericType): New private field.
13080 (Interface.DefineType): If we're a generic type, create the
13081 `CurrentType' (unresolved).
13082 (Interface.DefineMembers): If we have a `CurrentType', resolve it
13083 and store it in `GenericType' before creating the MemberCache.
13084 (Interface.GetMembers): If we have a `GenericType', call
13085 TypeManager.FindMembers() on it.
13087 2004-01-22 Martin Baulig <martin@ximian.com>
13089 * cs-parser.jay (namespace_or_type_name): Return an Expression,
13090 not a QualifiedIdentifier. This is what `type_name_expression'
13091 was previously doing.
13092 (type_name_expression): Removed; the code is now in
13093 `namespace_or_type_name'.
13094 (qualified_identifier): Removed, use `namespace_or_type_name'
13096 (QualifiedIdentifier): Removed this class.
13098 2004-01-22 Martin Baulig <martin@ximian.com>
13100 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
13101 not a string as alias name.
13103 2004-01-21 Miguel de Icaza <miguel@ximian.com>
13105 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
13106 #52730 bug, and instead compute correctly the need to use a
13107 temporary variable when requesting an address based on the
13108 static/instace modified of the field and the constructor.
13110 2004-01-21 Martin Baulig <martin@ximian.com>
13112 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
13113 class and namespace before looking up aliases. Fixes #52517.
13115 2004-01-21 Martin Baulig <martin@ximian.com>
13117 * flowanalysis.cs (UsageVector.Merge): Allow variables being
13118 assinged in a 'try'; fixes exception4.cs.
13120 2004-01-21 Marek Safar <marek.safar@seznam.cz>
13121 * class.cs : Implemented parameter-less constructor for TypeContainer
13123 * decl.cs: Attributes are now stored here. New property OptAttributes
13125 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
13127 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
13129 2004-01-21 Marek Safar <marek.safar@seznam.cz>
13131 * typemanager.cs (CSharpSignature): Now reports also inner class name.
13132 (CSharpSignature): New method for indexer and property signature.
13134 2004-01-21 Marek Safar <marek.safar@seznam.cz>
13136 * pending.cs (IsVirtualFilter): Faster implementation.
13138 2004-01-21 Marek Safar <marek.safar@seznam.cz>
13140 * typemanager.cs: Avoid inclusion of same assembly more than once.
13142 2004-01-21 Marek Safar <marek.safar@seznam.cz>
13144 * cs-parser.jay: Fixed problem where the last assembly attribute
13145 has been applied also to following declaration (class, struct, etc.)
13147 2004-01-21 Marek Safar <marek.safar@seznam.cz>
13149 * class.cs: Added error CS0538, CS0539 reporting.
13150 Fixed crash on Microsoft runtime when field type is void.
13152 * cs-parser.jay: Added error CS0537 reporting.
13154 * pending.cs: Added error CS0535 reporting.
13155 Improved error report for errors CS0536, CS0534.
13157 2004-01-20 Miguel de Icaza <miguel@ximian.com>
13159 Merge a few bits from the Anonymous Method MCS tree.
13161 * statement.cs (ToplevelBlock): New class for toplevel methods,
13162 will hold anonymous methods, lifted variables.
13164 * cs-parser.jay: Create toplevel blocks for delegates and for
13165 regular blocks of code.
13167 2004-01-20 Martin Baulig <martin@ximian.com>
13169 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
13170 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
13171 and `NeedExplicitReturn'; added `IsLastStatement'.
13172 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
13173 have a `ReturnLabel' or we're not unreachable.
13175 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
13176 child's reachability; don't just override ours with it. Fixes
13177 #58058 (lluis's example).
13178 (FlowBranching): Added public InTryOrCatch(), InCatch(),
13179 InFinally(), InLoop(), InSwitch() and
13180 BreakCrossesTryCatchBoundary() methods.
13182 * statement.cs (Return): Do all error checking in Resolve().
13183 Unless we are the last statement in a top-level block, always
13184 create a return label and jump to it.
13185 (Break, Continue): Do all error checking in Resolve(); also make
13186 sure we aren't leaving a `finally'.
13187 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
13188 statement in a top-level block.
13189 (Block.Flags): Added `IsDestructor'.
13190 (Block.IsDestructor): New public property.
13192 2004-01-20 Martin Baulig <martin@ximian.com>
13194 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
13196 2004-01-20 Martin Baulig <martin@ximian.com>
13198 * statement.cs (Statement.ResolveUnreachable): New public method.
13199 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
13200 (Block.Resolve): Resolve unreachable statements.
13202 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
13204 * expression.cs: We need to fix the case where we do
13205 not have a temp variable here.
13207 * assign.cs: Only expression compound assignments need
13208 temporary variables.
13210 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
13212 * flowanalysis.cs: Reduce memory allocation in a few ways:
13213 - A block with no variables should not allocate a bit
13215 - A method with no out parameters does not need any tracking
13216 for assignment of the parameters, so we need not allocate
13219 public readonly Type[] VariableTypes;
13220 public readonly string[] VariableNames;
13221 Are redundant. The data is already stored in the variable
13222 map, so we need not allocate another array for it.
13223 - We need to add alot of checks for if (params | locals) == null
13224 due to the first two changes.
13226 2004-01-18 Miguel de Icaza <miguel@ximian.com>
13228 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
13229 implement IMemoryLocation, we store a copy on a local variable and
13230 take the address of it. Patch from Benjamin Jemlich
13232 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
13233 to use a special "type_name_expression" rule which reduces the
13234 number of "QualifiedIdentifier" classes created, and instead
13235 directly creates MemberAccess expressions.
13237 2004-01-17 Miguel de Icaza <miguel@ximian.com>
13239 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
13240 that fixes #52853. Null literal assignment to ValueType
13242 * class.cs (MethodData.Emit): Instead of checking the name of the
13243 method to determine if its a destructor, create a new derived
13244 class from Method called Destructor, and test for that.
13246 * cs-parser.jay: Create a Destructor object instead of a Method.
13248 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
13252 2004-01-16 Miguel de Icaza <miguel@ximian.com>
13254 * expression.cs (Binary.ResolveOperator): Perform an implicit
13255 conversion from MethodGroups to their delegate types on the
13256 Addition operation.
13258 * delegate.cs: Introduce a new class DelegateCreation that is the
13259 base class for `NewDelegate' and `ImplicitDelegateCreation',
13260 factor some code in here.
13262 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
13263 conversion from MethodGroups to compatible delegate types.
13265 * ecore.cs (Expression.Resolve): Do not flag error 654
13266 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
13267 we allow conversions from MethodGroups to delegate types now.
13269 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
13270 assignments in v2 either.
13272 2004-01-10 Miguel de Icaza <miguel@ximian.com>
13274 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
13275 static read-only fields in ctors.
13277 Applied patch from Benjamin Jemlich
13279 * expression.cs (UnaryMutator): Avoid leaking local variables.
13281 2004-01-09 Miguel de Icaza <miguel@ximian.com>
13283 * cs-tokenizer.cs (IsCastToken): Allow the various native types
13284 here to return true, as they can be used like this:
13286 (XXX) int.MEMBER ()
13288 Fixed 49836 and all the other dups
13290 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
13292 * driver.cs: Implement /win32res and /win32icon.
13294 2004-01-08 Miguel de Icaza <miguel@ximian.com>
13296 * cs-parser.jay: Add a rule to improve error handling for the
13297 common mistake of placing modifiers after the type.
13299 2004-01-07 Miguel de Icaza <miguel@ximian.com>
13301 * cs-parser.jay (interface_event_declaration): Catch
13302 initialization of events on interfaces, and report cs0068
13304 * cs-parser.jay (interface_event_declaration): Catch
13305 initialization of events.
13307 * ecore.cs: Better report missing constructors.
13309 * expression.cs (Binary.ResolveOperator): My previous bug fix had
13310 the error reporting done in the wrong place. Fix.
13312 * expression.cs (Binary.ResolveOperator): Catch the
13313 operator + (E x, E y) error earlier, and later allow for implicit
13314 conversions in operator +/- (E e, U x) from U to the underlying
13317 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
13318 52596, if the container class is abstract, the default constructor
13319 is protected otherwise its public (before, we were always public).
13321 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
13324 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
13325 Jemlich that fixes bug #52597, MCS was generating invalid code for
13326 idisposable structs. Thanks to Ben for following up with this
13329 2004-01-06 Miguel de Icaza <miguel@ximian.com>
13331 * driver.cs: Allow assemblies without code to be generated, fixes
13334 2004-01-07 Nick Drochak <ndrochak@gol.com>
13336 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
13338 2004-01-05 Miguel de Icaza <miguel@ximian.com>
13340 * cs-parser.jay: Add rules to improve error reporting if fields or
13341 methods are declared at the namespace level (error 116)
13343 * Add rules to catch event add/remove
13345 2004-01-04 David Sheldon <dave-mono@earth.li>
13347 * expression.cs: Added matching ")" to error message for
13350 2004-01-03 Todd Berman <tberman@gentoo.org>
13352 * ecore.cs, attribute.cs:
13353 Applying fix from #52429.
13355 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
13357 * ecore.cs, expression.cs, statement.cs:
13358 Total rewrite of how we handle branching. We
13359 now handle complex boolean expressions with fewer
13360 jumps. As well if (x == 0) no longer emits a ceq.
13362 if (x is Foo) is much faster now, because we generate
13365 Overall, we get a pretty big improvement on our benchmark
13366 tests. The code we generate is smaller and more readable.
13368 I did a full two-stage bootstrap. The patch was reviewed
13369 by Martin and Miguel.
13371 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
13373 * cs-parser.jay: Make primary_expression not take a QI.
13374 we dont need this because the member_access rule covers
13375 us here. So we replace the rule with just IDENTIFIER.
13377 This has two good effects. First, we remove a s/r conflict.
13378 Second, we allocate many fewer QualifiedIdentifier objects.
13380 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
13382 * attribute.cs: Handle MarshalAs attributes as pseudo, and
13383 set the correct information via SRE. This prevents
13384 hanging on the MS runtime. Fixes #29374.
13386 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
13388 * convert.cs: correctly handle conversions to value types
13389 from Enum and ValueType as unboxing conversions.
13391 Fixes bug #52569. Patch by Benjamin Jemlich.
13393 2004-01-02 Ravi Pratap <ravi@ximian.com>
13395 * expression.cs (BetterConversion): Prefer int -> uint
13396 over int -> ulong (csc's behaviour). This fixed bug #52046.
13398 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
13400 * decl.cs (MemberCache.FindMembers): now returns a
13403 * typemanager.cs: In general, go with with ^^.
13404 (CopyNewMethods): take an IList.
13405 (RealMemberLookup): Only allocate an arraylist
13406 if we copy from two sets of methods.
13408 This change basically does two things:
13409 1) Fewer array lists allocated due to CopyNewMethods.
13410 2) the explicit cast in MemberList costed ALOT.
13412 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
13414 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
13415 a hashtable to avoid needless string allocations when an identifier is
13416 used more than once (the common case).
13418 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
13420 * pending.cs: MS's TypeBuilder.GetInterfaces ()
13421 is broken, it will not return anything. So, we
13422 have to use the information we have in mcs to
13425 * typemanager.cs: Add a cache for GetInterfaces,
13426 since this will now be used more often (due to ^^)
13428 (GetExplicitInterfaces) New method that gets the
13429 declared, not effective, interfaces on a type
13430 builder (eg, if you have interface IFoo, interface
13431 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
13434 This patch makes MCS able to bootstrap itself on
13437 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
13439 * expression.cs: Remove the Nop's that Miguel put
13442 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
13444 * report.cs, codegen.cs: Give the real stack trace to
13445 the error when an exception is thrown.
13447 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
13449 * decl.cs: only allocate hashtables for ifaces if
13452 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
13454 * expression.cs: fix the error from cs0121-2.cs
13455 (a parent interface has two child interfaces that
13456 have a function with the same name and 0 params
13457 and the function is called through the parent).
13459 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
13461 * class.cs, rootcontext.cs, typmanager.cs: do not
13464 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
13466 * codegen.cs: remove stack for the ec flow branching.
13467 It is already a linked list, so no need.
13469 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
13471 * Makefile: Allow custom profiler here.
13473 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
13475 * typemanager.cs (LookupType):
13476 - Use a static char [], because split takes
13477 a param array for args, so it was allocating
13479 - Do not store true in a hashtable, it boxes.
13481 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
13483 * flowanalysis.cs: bytify common enums.
13485 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
13487 * modifiers.cs: Add a new set of flags for the
13488 flags allowed on explicit interface impls.
13489 * cs-parser.jay: catch the use of modifiers in
13490 interfaces correctly.
13491 * class.cs: catch private void IFoo.Blah ().
13493 All related to bug #50572.
13495 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
13497 * decl.cs: Rewrite the consistant accessability checking.
13498 Accessability is not linear, it must be implemented in
13499 a tableish way. Fixes #49704.
13501 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
13503 * expression.cs: Handle negation in a checked context.
13504 We must use subtraction from zero. Fixes #38674.
13506 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
13508 * class.cs: Ignore static void main in DLLs.
13509 * rootcontext.cs: Handle the target type here,
13510 since we are have to access it from class.cs
13511 * driver.cs: account for the above.
13513 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
13515 * report.cs: Give line numbers and files if available.
13517 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
13519 * driver.cs: Implement /addmodule.
13521 * typemanager.cs: Change 'modules' field so it now contains Modules not
13524 2003-12-20 Martin Baulig <martin@ximian.com>
13526 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
13527 (FieldBase.IsAssigned): Removed this field.
13528 (FieldBase.SetAssigned): New public method.
13529 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
13531 2003-12-20 Martin Baulig <martin@ximian.com>
13533 * expression.cs (LocalVariableReference.DoResolve): Don't set
13534 `vi.Used' if we're called from DoResolveLValue().
13536 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
13537 returns the usage vector it just merged into the current one -
13538 pass this one to UsageWarning().
13539 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
13540 of the `EmitContext', don't call this recursively on our children.
13542 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
13544 * driver.cs: Implement /target:module.
13546 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
13548 * support.cs (CharArrayHashtable): New helper class.
13550 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
13551 char arrays, not strings, so we can avoid creating a string in
13552 consume_identifier if the identifier is a keyword.
13554 2003-12-16 Martin Baulig <martin@ximian.com>
13556 * statement.cs (LocalInfo.Assigned): Removed this property.
13557 (LocalInfo.Flags): Removed `Assigned'.
13558 (LocalInfo.IsAssigned): New public method; takes the EmitContext
13559 and uses flow analysis.
13560 (Block.UsageWarning): Made this method private.
13561 (Block.Resolve): Call UsageWarning() if appropriate.
13563 * expression.cs (LocalVariableReference.DoResolve): Always set
13564 LocalInfo.Used here.
13566 2003-12-13 Martin Baulig <martin@ximian.com>
13568 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
13569 any value here; we're now using flow analysis to figure out
13570 whether a statement/block returns a value.
13572 2003-12-13 Martin Baulig <martin@ximian.com>
13574 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
13576 (FlowBranching.MergeFinally): Don't call
13577 `branching.CheckOutParameters()' here, this is called in
13579 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
13580 when adding the `finally' vector.
13582 2003-12-13 Martin Baulig <martin@ximian.com>
13585 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
13586 actually work and also fix #48962.
13588 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
13590 * decl.cs: Do not check System.Object for nested types,
13591 since we know it does not have any. Big bang for buck:
13594 Run 1: 8.35 seconds
13595 Run 2: 8.32 seconds
13596 corlib: 17.99 seconds
13598 Run 1: 8.17 seconds
13599 Run 2: 8.17 seconds
13600 corlib: 17.39 seconds
13602 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
13604 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
13605 time we are returning 0 members, so we save alot here.
13607 2003-12-11 Martin Baulig <martin@ximian.com>
13609 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
13610 `MergeChild()', also just take the `FlowBranching' as argument;
13611 call Merge() on it and return the result.
13612 (FlowBranching.Merge): We don't need to do anything if we just
13615 2003-12-11 Martin Baulig <martin@ximian.com>
13617 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
13618 them in an `ArrayList' to reduce memory usage. Thanks to Ben
13619 Maurer for this idea.
13621 2003-12-11 Martin Baulig <martin@ximian.com>
13623 * flowanalysis.cs (MergeResult): This class is now gone; we now
13624 use the `UsageVector' for this. The reason for this is that if a
13625 branching just has one sibling, we don't need to "merge" them at
13626 all - that's the next step to do.
13627 (FlowBranching.Merge): We now return a `UsageVector' instead of a
13630 2003-12-11 Martin Baulig <martin@ximian.com>
13632 Reworked flow analyis and made it more precise and bug-free. The
13633 most important change is that we're now using a special `Reachability'
13634 class instead of having "magic" meanings of `FlowReturns'. I'll
13635 do some more cleanups and optimizations and also add some more
13636 documentation this week.
13638 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
13639 largely reworked this class.
13640 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
13641 the new `Reachability' class instead of having "magic" values here.
13642 (FlowBranching): We're now using an instance of `Reachability'
13643 instead of having separate `Returns', `Breaks' etc. fields.
13645 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
13646 based on flow analysis; ignore the return value of block.Emit ().
13648 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
13650 * driver.cs typemanager.cs: Find the mono extensions to corlib even
13651 if they are private.
13653 2003-12-09 Martin Baulig <martin@ximian.com>
13655 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
13656 call them directly on the UsageVector.
13658 2003-12-09 Martin Baulig <martin@ximian.com>
13660 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
13661 Changed return type from `FlowReturns' to `Reachability'.
13663 2003-12-09 Martin Baulig <martin@ximian.com>
13665 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
13666 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
13667 `Reachable' fields with a single `Reachability' one.
13669 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
13671 * class.cs (FindMembers): Remove foreach's.
13676 Run 1: 8.74 seconds
13677 Run 2: 8.71 seconds
13680 Run 1: 8.64 seconds
13681 Run 2: 8.58 seconds
13684 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
13689 This patch does a few things:
13690 1. EmptyStatement is now a singleton, so it is never reallocated.
13691 2. All blah is EmptyStatement constructs have been changed to
13692 blah == EmptyStatement.Value, which is much faster and valid
13693 now that EmptyStatement is a singleton.
13694 3. When resolving a block, rather than allocating a new array for
13695 the non-empty statements, empty statements are replaced with
13696 EmptyStatement.Value
13697 4. Some recursive functions have been made non-recursive.
13698 Mainly the performance impact is from (3), however (1) and (2) are needed for
13699 this to work. (4) does not make a big difference in normal situations, however
13700 it makes the profile look saner.
13705 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
13706 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
13707 Total memory allocated: 56397 KB
13710 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
13711 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
13712 Total memory allocated: 55666 KB
13714 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
13716 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
13717 than the hashtable in a hashtable version
13719 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
13720 we always end up concating a string. This results in a huge perf
13721 loss, because many strings have to be tracked by the GC. In this
13722 patch, we first use a hashtable that works with two keys, so that
13723 the strings do not need to be concat'ed.
13727 Run 1: 8.74 seconds
13728 Run 2: 8.71 seconds
13731 Run 1: 8.65 seconds
13732 Run 2: 8.56 seconds
13734 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
13736 * Makefile: Add a new target `do-time' that does a quick and simple
13737 profile, leaving easy to parse output.
13739 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
13741 * codegen.cs (Init): Create the dynamic assembly with
13742 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
13744 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
13746 * support.cs: Make the PtrHashtable use only one
13747 instance of its comparer.
13749 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
13751 * typemanager.cs: Fix lookup of GetNamespaces.
13753 2003-11-29 Miguel de Icaza <miguel@ximian.com>
13755 * expression.cs: Removed redundant line.
13757 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
13758 ArrayLists, use for loops with bounds.
13760 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
13763 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
13764 arraylists, use for loop with bounds.
13766 The above three changes give us a 0.071 second performance
13767 improvement out of 3.294 seconds down to 3.223. On my machine
13768 the above changes reduced the memory usage by 1,387 KB during
13769 compiler bootstrap.
13771 * cs-parser.jay (QualifiedIdentifier): New class used to represent
13772 QualifiedIdentifiers. Before we created a new string through
13773 concatenation, and mostly later on, the result would be
13774 manipulated by DecomposeQI through string manipulation.
13776 This reduced the compiler memory usage for bootstrapping from
13777 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
13778 compile times in 0.05 seconds.
13780 2003-11-28 Dick Porter <dick@ximian.com>
13782 * support.cs: Do string compares with the Invariant culture.
13790 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
13791 the comparison is done with the Invariant culture.
13793 2003-11-27 Miguel de Icaza <miguel@ximian.com>
13795 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
13796 GetEnumerator method.
13798 (ProbeCollectionType): Iterate starting at the most specific type
13799 upwards looking for a GetEnumerator
13801 * expression.cs: Shift count can be up to 31 for int/uint and 63
13804 2003-11-26 Miguel de Icaza <miguel@ximian.com>
13806 * statement.cs (Block.LookupLabel): Also look for the label on the
13807 children blocks. Use a hash table to keep track of visited
13810 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
13811 we actually did transform the other operand, otherwise fall back
13812 to the common codepath that casts to long.
13814 * cs-tokenizer.cs: Use the same code pattern as the int case.
13815 Maybe I should do the parsing myself, and avoid depending on the
13816 Parse routines to get this done.
13818 2003-11-25 Miguel de Icaza <miguel@ximian.com>
13820 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
13821 which fixes bug 51347. This time test it.
13823 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
13824 attributes for example can not tell the difference between these.
13825 The difference was only a syntax feature of the language.
13827 * attribute.cs: Apply attributes to delegates.
13829 * delegate.cs: Call the apply attributes method.
13831 2003-11-24 Miguel de Icaza <miguel@ximian.com>
13833 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
13834 comparing 0 vs Byte.MinValue, not the value
13836 (ImplicitConversionRequired): When reporting a conversion error,
13837 use error 31 to print out the constant error instead of the
13840 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
13841 which fixes bug 51347.
13843 2003-11-22 Miguel de Icaza <miguel@ximian.com>
13845 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
13846 which fixes the -warnaserror command line option.
13848 2003-11-21 Miguel de Icaza <miguel@ximian.com>
13850 * cfold.cs (DoNumericPromotions): During constant folding of
13851 additions on UIntConstant, special case intconstants with
13852 IntConstants like we do on the expression binary operator.
13854 2003-11-12 Miguel de Icaza <miguel@ximian.com>
13856 * convert.cs (ImplicitReferenceConversion): We were missing a case
13857 (System.Enum are not value types or class types, so we need to
13858 classify them separatedly).
13860 * driver.cs: We do not support error 2007.
13862 2003-11-12 Jackson Harper <jackson@ximian.com>
13864 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
13865 system directory. Also use the full file name so users can
13866 libraries names mscorlib-o-tron.dll in a non system dir.
13868 2004-01-04 David Sheldon <dave-mono@earth.li>
13870 * expression.cs: Added matching ")" to error message for CS0077.
13872 2003-12-19 Martin Baulig <martin@ximian.com>
13874 * typemanager.cs (TypeManager.IsEqualGenericType): New public
13875 static method; see documentation in the method.
13876 (TypeManager.IsSubclassOrNestedChild): Allow IsEqualGenericType().
13878 * convert.cs (Convert.ImplicitReferenceConversion,
13879 Convert.ImplicitReferenceConversionExists): Add support for
13880 generic type declarations; see gen-36.cs.
13882 2003-12-19 Martin Baulig <martin@ximian.com>
13884 * pending.cs (Pending.InterfaceMethod): Use
13885 `Type.IsAssignableFrom()' instead of `=='.
13887 2003-12-18 Martin Baulig <martin@ximian.com>
13889 * decl.cs (DeclSpace.AsAccessible): Check for array, pointer and
13892 * convert.cs (Convert.ImplicitStandardConversionExists): Use
13893 `expr_type.Equals (target_type)' instead of `=='.
13895 2003-12-08 Martin Baulig <martin@ximian.com>
13897 * generics.cs (Constraints.Types): Removed.
13898 (Constraints.Resolve): Just resolve everything to TypeExpr's, not
13900 (Constraints.ResolveTypes): New public method; resolves the
13901 TypeExpr's to Type's.
13902 (TypeParameter.Define): TypeBuilder.DefineGenericParameter() no
13903 longer takes the constraints.
13904 (TypeParameter.DefineMethod): Likewise.
13905 (TypeParameter.DefineType): New public method. Calls
13906 `TypeBuilder/MethodBuilder.SetGenericParameterConstraints()' to set
13909 2003-12-08 Martin Baulig <martin@ximian.com>
13911 * convert.cs (Convert.ImplicitConversionStandard): Use
13912 `expr_type.Equals (target_type)' instead of `=='.
13914 2003-12-08 Martin Baulig <martin@ximian.com>
13916 * typemanager.cs (TypeManager.GetReferenceType): Call
13917 `Type.MakeByRefType ()'.
13919 2003-12-08 Martin Baulig <martin@ximian.com>
13921 * cs-parser.jay, cs-tokenizer.cs: `where' is not a keyword, it
13922 just has some special meaning in some situations. For instance,
13923 it is allowed to use `where' as the name of a variable etc.
13925 2003-12-04 Martin Baulig <martin@ximian.com>
13927 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
13928 `Type.MakeArrayType()' for array types.
13930 2003-11-18 Miguel de Icaza <miguel@ximian.com>
13932 * expression.cs (Invocation.VerifyArgumentsCompat): Remove
13935 (SizeOf.DoResolve): assign the `type_queried' field. This gets
13938 2003-11-16 Martin Baulig <martin@ximian.com>
13940 * codegen.cs (EmitContext.IsGeneric): Removed.
13942 * ecore.cs (SimpleName.ResolveAsTypeStep): Always call
13943 ResolveGeneric() on the DeclSpace.
13945 2003-11-16 Martin Baulig <martin@ximian.com>
13947 * generic.cs (TypeArguments.Resolve):
13948 `Expression.ResolveAsTypeTerminal()' returns a TypeExpr; call
13949 `ResolveType()' on it to get the Type.
13951 2003-11-15 Martin Baulig <martin@ximian.com>
13953 * generic.cs (ConstructedType.GetInterfaces): Override this.
13955 2003-11-14 Martin Baulig <martin@ximian.com>
13957 * interface.cs (Interface.DefineType): Define all type parameters
13958 before adding the interfaces we inherit.
13960 2003-11-11 Martin Baulig <martin@ximian.com>
13962 * generic.cs (ConstructedType.ResolveType): Always call
13963 `gt.BindGenericParameters (atypes)'; also if `args.HasTypeArguments'.
13965 2003-11-10 Martin Baulig <martin@ximian.com>
13967 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
13968 (TypeManager.InitCoreTypes): Initialize them here, but instead of
13969 calling `ResolveType()' on them, directly assign their `Type'.
13971 2003-11-08 Martin Baulig <martin@ximian.com>
13973 * generic.cs (ConstructedType): Override `IsClass' etc.
13975 2003-11-08 Martin Baulig <martin@ximian.com>
13977 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
13978 return value and the `out parent' parameter.
13979 (TypeContainer.DefineType): Moved the CS0644 check into
13980 GetClassBases(). Don't pass the interface types to the
13981 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
13982 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
13984 * ecore.cs (TypeExpr.IsAttribute): New property.
13985 (TypeExpr.GetInterfaces): New method.
13987 * interface.cs (Interface.GetInterfaceTypeByName): Return a
13988 TypeExpr instead of a Type.
13989 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
13990 (Interface.DefineType): Don't pass the interface types to the
13991 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
13992 them later and then call `TypeBulider.AddInterfaceImplementation()'.
13994 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
13995 instead of a `Type[]'.
13996 (TypeManager.RegisterBuilder): Likewise.
13997 (TypeManager.AddUserInterface): Likewise.
13998 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
13999 `Type[]' and also return a `TypeExpr[]'.
14000 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
14002 2003-11-08 Martin Baulig <martin@ximian.com>
14004 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
14007 2003-11-08 Martin Baulig <martin@ximian.com>
14009 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
14010 TypeManager.ResolveExpressionTypes().
14012 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
14013 instead of an Expression.
14014 (TypeExpr): This is now an abstract base class for `TypeExpression'.
14015 (TypeExpression): New public class; formerly known as `TypeExpr'.
14017 * expression.cs (ComposedCast): Derive from TypeExpr.
14019 * typemanager.cs (TypeManager.system_*_expr): These are now
14020 TypExpr's instead of Expression's.
14021 (TypeManager.ResolveExpressionTypes): New public static function;
14022 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
14025 2003-11-06 Miguel de Icaza <miguel@ximian.com>
14027 * expression.cs (New.DoResolve): Do not dereference value that
14028 might be a null return.
14030 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
14031 sure that the constant value has the right type. Fixes an
14032 unreported bug, similar to 50425.
14034 * const.cs (Const.LookupConstantValue): Call
14035 ImplicitStandardConversionExists before doing a conversion to
14036 avoid havng the TypeManager.ChangeType do conversions.
14038 Reduced the number of casts used
14040 (Const.ChangeType): New routine to enable reuse of the constant
14041 type changing code from statement.
14043 * typemanager.cs (ChangeType): Move common initialization to
14044 static global variables.
14048 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
14049 every value type to go through, even if it was void. Fix that.
14051 * cs-tokenizer.cs: Use is_identifier_start_character on the start
14052 character of the define, and the is_identifier_part_character for
14053 the rest of the string.
14055 2003-11-05 Miguel de Icaza <miguel@ximian.com>
14057 * expression.cs (UnaryMutator.EmitCode): When I updated
14058 LocalVariableReference.DoResolve, I overdid it, and dropped an
14059 optimization done on local variable references.
14061 2003-11-04 Miguel de Icaza <miguel@ximian.com>
14063 * ecore.cs: Convert the return from Ldlen into an int.
14065 2003-10-20 Miguel de Icaza <miguel@ximian.com>
14067 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
14068 the accessibility, this is a special case for toplevel non-public
14069 classes (internal for instance).
14071 2003-10-20 Nick Drochak <ndrochak@gol.com>
14073 * ecore.cs: Fix typo and build. Needed another right paren.
14075 2003-10-19 Miguel de Icaza <miguel@ximian.com>
14077 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
14078 `internal' case regular and protected, but not allowing protected
14079 to be evaluated later. Bug 49840
14081 2003-10-15 Miguel de Icaza <miguel@ximian.com>
14083 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
14084 to kb.Nlast, and not the kb.nFirst to isolate the switch
14087 Extract the underlying type, so enumerations of long/ulong are
14088 treated like long/ulong.
14090 2003-10-14 Miguel de Icaza <miguel@ximian.com>
14092 * expression.cs (New): Overload the meaning of RequestedType to
14093 track the possible creation of the NewDelegate type, since
14094 DoResolve is invoked more than once for new constructors on field
14097 See bugs: #48800 and #37014
14099 * cs-parser.jay (declare_local_constants): Take an arraylist
14100 instead of a single constant.
14102 (local_constant_declaration): It should take a
14103 constant_declarators, not a constant_declarator. Fixes 49487
14105 * convert.cs: Fix error report.
14107 2003-10-13 Jackson Harper <jackson@ximian.com>
14109 * typemanager.cs (TypeToCoreType): Add float and double this fixes
14112 2003-11-03 Martin Baulig <martin@ximian.com>
14114 * expression.cs (ArrayAccess.GetStoreOpcode): Added
14115 `out bool has_type_arg'; if set, we need to pass the type to
14117 (ArrayAccess.GetStoreOpcode, ArrayAccess.EmitLoadOpcode): Use
14118 Stelem_Any/Ldelem_Any for generic parameters.
14120 2003-11-02 Martin Baulig <martin@ximian.com>
14122 * expression.cs (Invocation.EmitCall): Use
14123 `TypeManager.IsValueType()' to check whether it's a value type.
14124 Don't set `struct_call' when calling a method on a type parameter.
14126 2003-11-02 Martin Baulig <martin@ximian.com>
14128 * generics.cs (ConstructedType.Resolve): Renamed to ResolveType()
14129 and removed the TypeBuilder argument.
14131 * typemanager.cs (TypeManager.IsValueType): Return
14132 `t.IsGenericParameter || t.IsValueType'.
14134 2003-10-25 Martin Baulig <martin@ximian.com>
14136 * decl.cs (DeclSpace.ResolveType): If we're a ConstructedType,
14137 call ConstructedType.Resolve() on it.
14139 * generic.cs (ConstructedType.Resolve): Set `type' on success.
14141 2003-10-25 Martin Baulig <martin@ximian.com>
14143 * class.cs (TypeContainer.GetClassBases): Changed
14144 `out Type parent' into `out TypeExpr parent'. Moved CS0644 and
14145 CS8214 reporting here.
14146 (TypeContainer.DefineType): GetClassBases() gives us a `TypeExpr'
14147 instead of a `Type' for our parent. In case of a recursive
14148 declaration (see tests/gen-23.cs for an example), our parent is a
14149 ConstructedType and it doesn't have its type set. So, first
14150 create our own TypeBuilder, then call constructed.Resolve() to get
14151 the parent's type and finally TypeBuilder.SetParent() it.
14153 * ecore.cs (TypeExpr.Name): New public virtual property.
14156 (ConstructedType): We're now a TypeExpr and not just an Expression.
14157 (ConstructedType.ResolveAsTypeStep): Don't resolve our type
14158 arguments here; this is done later.
14159 (ConstructedType.Resolve): New public method to resolve the type
14160 arguments and bind them.
14162 2003-10-21 Martin Baulig <martin@ximian.com>
14164 * convert.cs: Use `TypeManager.IsValueType' instead of
14165 'type.IsValueType' everywhere.
14167 * typemanager.cs (TypeManager.IsValueType): Return true for type
14168 parameters. The reason for this is that we need to box a type
14169 parameter when converting it to a reference type.
14171 * cs-parser.jay: Added support for default value expressions.
14173 * generics.cs (DefaultValueExpression): New public class.
14175 2003-10-17 Martin Baulig <martin@ximian.com>
14177 * generic.cs (Constraints.Resolve): Take a DecpSpace instead of a
14178 TypeContainer so we can also use this for Interfaces.
14179 (TypeParameter.Resolve): Likewise.
14181 * interface.cs (Interface.DefineType): Added support for generic
14184 * cs-parser.jay: Added support for generic structs and interfaces.
14186 2003-10-17 Martin Baulig <martin@ximian.com>
14188 * generic.cs (GenericMemberAccess.DoResolve): We can now actually
14189 call generic methods :-)
14191 2003-10-16 Martin Baulig <martin@ximian.com>
14193 * cs-parser.jay (namespace_or_type_name): Only create a
14194 GenericMemberAccess if we actually have type arguments.
14196 2003-10-13 Martin Baulig <martin@ximian.com>
14198 * class.cs (Method.Define): If we're a generic method, call
14199 TypeBuilder.DefineGenericMethod () before resolving
14201 (MethodData): Added .ctor which takes an additional MethodBuilder
14202 argument; this is used for generic methods.
14203 (MethodData.Define): Call `builder.SetGenericMethodSignature()' if
14204 we already have a MethodBuilder.
14206 2003-10-10 Martin Baulig <martin@ximian.com>
14208 * class.cs (Method): Added .ctor which takes a `GenericMethod'
14209 instead of a `DeclSpace'. This is used for generic methods.
14211 * cs-parser.jay (method_header): Added support for generic
14212 methods; create a `GenericMethod' instance and pass it to the
14213 `Method's .ctor; it'll be used as the `DeclSpace' to lookup
14214 parameters and locals.
14216 * decl.cs (DeclSpace.SetParameterInfo): Removed Location argument
14217 since we already have the location. Check whether we're a generic
14218 type declaration or a generic method and create the correct type
14221 * generic.cs (TypeParameter.DefineMethod): New public method.
14222 (GenericMethod): New public class; derives from DeclSpace and is
14223 used for generic methods.
14225 2003-10-09 Martin Baulig <martin@ximian.com>
14227 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
14229 (MethodCore.DoDefineParameters): Removed the TypeContainer
14230 argument; use the DeclSpace which was passed to the .ctor instead.
14231 (MethodCore.CheckParameter): Take a DeclSpace instead of a
14232 TypeContainer; we only need a DeclSpace here.
14234 2003-10-09 Martin Baulig <martin@ximian.com>
14236 * class.cs (MethodData): Added additional `DeclSpace ds' argument
14238 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
14239 EmitContext's .ctor.
14241 2003-10-09 Martin Baulig <martin@ximian.com>
14243 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
14244 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
14245 AsAccessible(), moved them as well.
14247 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
14249 2003-10-07 Miguel de Icaza <miguel@ximian.com>
14251 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
14252 generation for >=, as spotted by Paolo, bug 48679.
14253 Patch from David Waite.
14255 * cs-tokenizer.cs: Add handling for #pragma.
14257 * cs-parser.jay: Allow for both yield and yield return in the
14258 syntax. The anti-cobolization of C# fight will go on!
14260 * class.cs (TypeBuilder.DefineType): Catch error condition here
14261 (Parent.DefineType erroring out and returning null).
14263 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
14264 coping with enumerations variables, we were mistakenly processing
14265 them as a regular value type instead of built-in types. Fixes the
14268 * typemanager.cs (IsBuiltinOrEnum): New method.
14270 2003-09-30 Miguel de Icaza <miguel@ximian.com>
14272 * cs-parser.jay: Upgrade: yield now needs the return clause.
14274 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
14276 * cs-parser.jay : Renamed yyName to yyNames related to jay.
14278 2003-09-29 Martin Baulig <martin@ximian.com>
14280 * typemanager.cs (TypeManager.GetMethodFlags): Added support for
14281 inflated generic methods.
14283 * generics.cs (ConstructedType): Distinguish between open and
14284 closed constructed types; correctly resolve the arguments.
14286 2003-09-22 Martin Baulig <martin@ximian.com>
14288 * generic.cs (ConstructedType.ResolveAsTypeCheck): Check whether
14289 all type arguments meet their constraints.
14291 2003-09-19 Martin Baulig <martin@ximian.com>
14293 * decl.cs (MemberCache.SetupCacheForInterface): Take a
14294 `MemberCache parent' argument. Normally, an interface doesn't
14295 have a parent type except System.Object, but we use this in gmcs
14296 for generic type parameters.
14298 2003-09-18 Martin Baulig <martin@ximian.com>
14300 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
14301 on `type.IsInterface'; don't check whether the type has a parent
14302 to determine whether it's an interface.
14304 2003-09-17 Martin Baulig <martin@ximian.com>
14306 * generic.cs (ConstructedType.ToString): Always use `name' as the
14309 2003-09-15 Martin Baulig <martin@ximian.com>
14311 * cs-parser.jay: Fix grammar wrt. type_parameter_constraints.
14313 * generic.cs (Constraints.Resolve): New public method; this is
14314 called to resolve the constraint types and to check whether all
14315 the constraints are correct.
14316 (Constraints.Types): New public property.
14317 (TypeParameter.Resolve): New public method; resolves all the
14318 type's constraints.
14320 * class.cs (TypeContainer.DefineType): Call
14321 TypeParameter.Resolve() before actually defining the type.
14323 2003-09-15 Martin Baulig <martin@ximian.com>
14325 * class.cs (TypeContainer.DefineType): Added an error flag to
14326 avoid reporting duplicate CS0146's ("class definition is
14329 * driver.cs (Driver.MainDriver): Abort if
14330 RootContext.ResolveTree() reported any errors.
14332 2003-09-07 Martin Baulig <martin@ximian.com>
14334 * report.cs (Error, Warning): Added overloaded versions which take
14335 a `params object[] args' and call String.Format().
14337 2003-09-07 Martin Baulig <martin@ximian.com>
14339 * decl.cs (DeclSpace..ctor): Don't call
14340 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
14341 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
14342 (DeclSpace.RecordDecl): New method.
14344 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
14346 2003-09-02 Ravi Pratap <ravi@ximian.com>
14348 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
14349 value attributes to be applied to ParameterBuilders.
14351 * class.cs (MethodCore.LabelParameters): Make static and more
14352 generic so that it can be used from other places - like interface
14353 methods, for instance.
14355 * interface.cs (Interface.Emit): Call LabelParameters before
14356 emitting attributes on the InterfaceMethod.
14358 2003-09-07 Martin Baulig <martin@ximian.com>
14360 * generic.cs (ConstructedType.ResolveAsTypeStep): Report a CS8217
14361 if the number of type parameters doesn't match.
14363 2003-09-04 Martin Baulig <martin@ximian.com>
14365 * expression.cs (ComposedCast.ResolveAsTypeStep): Added support
14366 for arrays of generic type params (ie. `!0[]').
14368 2003-09-04 Martin Baulig <martin@ximian.com>
14370 * class.cs (TypeContainer.AsAccessible): Ignore generic parameters
14373 2003-09-04 Martin Baulig <martin@ximian.com>
14375 * decl.cs (DeclSpace.LookupGeneric): New method.
14376 (DeclSpace.CheckAccessLevel): Ignore generic parameters for the
14379 * generic.cs (TypeParameterExpr): Take a TypeParameter as
14380 argument, not just a string.
14381 (TypeParameter.Define): New public method; this is called to
14382 actually define the generic parameter; after this, you can use the
14383 new `Type' property to get the type.
14385 2003-09-04 Martin Baulig <martin@ximian.com>
14387 * decl.cs (DeclSpace.SetParameterInfo): The `constraints' argument
14388 is now an ArrayList; initialize the result of the `TypeParameters'
14390 (DeclSpace.GetGenericData): Removed.
14391 (DeclSpace.LookupGeneric): Temporarily removed; we need to
14392 implement this in a different way.
14393 (DeclSpace.GetTypeParameters): Removed; there's now a
14394 `TypeParameters' property.
14395 (DeclSpace.TypeParameters): New public property.
14397 * generic.cs (Constraints): Make this class public.
14398 (TypeParameter): New public class.
14400 2003-09-04 Martin Baulig <martin@ximian.com>
14402 * decl.cs (DeclSpace.GetTypeParameters): New method to return the
14403 generic parameters.
14405 * class.cs (TypeContainer.DefineType): Call
14406 TypeBuilder.DefineGenericParameter () on all generic parameters if
14407 this is a generic type.
14409 2003-08-28 Martin Baulig <martin@ximian.com>
14411 * sample-stack.il: Compile this with ilasm: "ilasm /dll
14414 * sample-hello.cs: Compile this with gmcs: "gmcs
14415 /r:sample-stack.dll sample-hello.cs".
14417 2003-08-28 Martin Baulig <martin@ximian.com>
14419 * generic.cs (ConstructedType.ResolveAsTypeStep): Actually bind
14420 the parameters to the generic type.
14422 2003-08-28 Martin Baulig <martin@ximian.com>
14424 * cs-tokenizer.cs (parse_less_than): Also allow all builtin types.
14426 2003-08-28 Martin Baulig <martin@ximian.com>
14428 * cs-parser.jay (opt_type_argument_list): Use
14429 `OP_GENERICS_LT type_arguments OP_GENERICS_GT'.
14430 (primary_expression): Replace `qualified_identifier' with `type_name'.
14431 (type_parameter_list): Use `OP_GENERICS_LT type_parameters OP_GENERICS_GT'.
14433 * cs-tokenizer.cs (is_punct): When reading a `<', invoke a custom
14434 parser to check whether it is syntactically a type parameter list;
14435 return OP_GENERICS_LT/OP_GENERICS_GT instead of OP_LT/OP_GT in
14438 2003-08-26 Martin Baulig <martin@ximian.com>
14440 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
14441 resolving aliases; fixes #47927.
14443 2003-08-26 Martin Baulig <martin@ximian.com>
14445 * statement.cs (Using.DoResolve): This is internally emitting a
14446 try/finally clause, so we need to set ec.NeedExplicitReturn if we
14447 do not always return. Fixes #47681.
14449 2003-08-26 Martin Baulig <martin@ximian.com>
14451 * decl.cs (MemberCore): Moved WarningNotHiding(),
14452 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
14454 (AdditionResult): Make this nested in DeclSpace.
14455 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
14456 argument; call NamespaceEntry.Define() unless we're nested in a
14459 * namespace.cs (Namespace.DefineName): New public function. This
14460 is called from DeclSpace's .ctor to add
14461 (Namespace.Lookup): Include DeclSpaces in the lookup.
14463 * class.cs (Operator): Derive from MemberBase, not MemberCore.
14465 * const.cs (Const): Derive from MemberBase, not MemberCore.
14467 2003-08-25 Martin Baulig <martin@ximian.com>
14469 * convert.cs (Convert.ExplicitReferenceConversion): When
14470 converting from an interface type to a class, unbox if the target
14471 type is a struct type. Fixes #47822.
14473 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
14475 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
14478 2003-08-22 Martin Baulig <martin@ximian.com>
14480 * class.cs (TypeManager.DefineType): When defining a nested type,
14481 call DefineType() on our parent; fixes #47801.
14483 2003-08-22 Martin Baulig <martin@ximian.com>
14485 * class.cs (MethodData.Define): While checking if a method is an
14486 interface implementation, improve the test a bit more to fix #47654.
14488 2003-08-22 Martin Baulig <martin@ximian.com>
14490 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
14491 correctly; fixes #47722.
14493 2003-08-22 Martin Baulig <martin@ximian.com>
14495 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
14496 LocalVariableReference, ensure it's not read-only. Fixes #47536.
14498 * statement.cs (Fixed.DoResolve): Make all variables read-only.
14500 2003-08-22 Martin Baulig <martin@ximian.com>
14502 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
14503 can only be assigned in static constructors. Fixes #47161.
14505 2003-08-22 Martin Baulig <martin@ximian.com>
14507 Rewrote and improved the flow analysis code.
14509 * flowbranching.cs (FlowBranching): Make this class abstract.
14510 (FlowBranching.CreateBranching): New static function to create a
14511 new flow branching.
14512 (FlowBranchingBlock, FlowBranchingException): New classes.
14513 (FlowBranching.UsageVector.Type): New public readonly field.
14514 (FlowBranching.UsageVector.Breaks): Removed the setter.
14515 (FlowBranching.UsageVector.Returns): Removed the setter.
14516 (FlowBranching.UsageVector): Added Break(), Return(),
14517 NeverReachable() and Throw() methods to modify the reachability.
14518 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
14519 done by FlowBranching.Merge().
14520 (FlowBranching.UsageVector.MergeChild): New method; merges the
14521 merge result into the current vector.
14522 (FlowBranching.Merge): New abstract method to merge a branching.
14524 2003-08-12 Martin Baulig <martin@ximian.com>
14526 * expression.cs (Indirection.CacheTemporaries): Create the
14527 LocalTemporary with the pointer type, not its element type.
14529 2003-08-10 Miguel de Icaza <miguel@ximian.com>
14531 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
14532 token was a keyword or not.
14534 Add `error' options where an IDENTIFIER was expected; Provide
14535 CheckToken and CheckIdentifierToken convenience error reporting
14538 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
14540 * decl.cs: Rename `NamespaceEntry Namespace' public field into
14541 NameSpaceEntry NameSpaceEntry.
14543 (LookupInterfaceOrClass): Avoid creating a full qualified name
14544 from namespace and name: avoid doing lookups when we know the
14545 namespace is non-existant. Use new Tree.LookupByNamespace which
14546 looks up DeclSpaces based on their namespace, name pair.
14548 * driver.cs: Provide a new `parser verbose' to display the
14549 exception thrown during parsing. This is turned off by default
14550 now, so the output of a failure from mcs is more graceful.
14552 * namespace.cs: Track all the namespaces defined in a hashtable
14555 (IsNamespace): New method
14557 2003-08-09 Miguel de Icaza <miguel@ximian.com>
14559 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
14560 we know that we need to concatenate (full typename can never be
14565 * statement.cs: Use a bitfield; Do not initialize to null things
14566 which are done by the constructor by default.
14568 * cs-parser.jay: bug fix, parameter was 4, not 3.
14570 * expression.cs: Just use the property;
14572 * statement.cs: No need for GetVariableInfo method.
14574 2003-08-08 Martin Baulig <martin@ximian.com>
14576 * flowanalysis.cs (FlowReturns): This is now nested in the
14577 `FlowBranching' class.
14578 (MyBitVector): Moved this here from statement.cs.
14579 (FlowBranching.SiblingType): New enum type.
14580 (FlowBranching.CreateSibling): Added `SiblingType' argument.
14582 2003-08-07 Martin Baulig <martin@ximian.com>
14584 * flowanalysis.cs (FlowBranchingType): This is now nested in the
14585 `FlowBranching' class and called `BranchingType'.
14587 2003-08-07 Martin Baulig <martin@ximian.com>
14589 * flowanalysis.cs: Moved all the control flow analysis code into
14592 2003-08-07 Martin Baulig <martin@ximian.com>
14594 * assign.cs (Assign.DoResolve): `target' must either be an
14595 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
14598 2003-08-07 Miguel de Icaza <miguel@ximian.com>
14600 * expression.cs (BinaryMethod): This kind of expression is created by the
14601 Binary class if it determines that the operator has to be handled
14604 (BinaryDelegate): This kind of expression is created if we are
14605 dealing with a + or - operator on delegates.
14607 (Binary): remove method, argumetns, and DelegateOperator: when
14608 dealing with methods,
14610 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
14612 * statement.cs (Block): use bitfields for the three extra booleans
14613 we had in use. Remove unused topblock parameter.
14615 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
14617 * assign.cs: Drop extra unneeded tests.
14619 2003-08-06 Miguel de Icaza <miguel@ximian.com>
14621 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
14623 * statement.cs (Foreach): Use VariableStorage instead of
14626 * codegen.cs (VariableStorage): New class used by clients that
14627 require a variable stored: locals or fields for variables that
14628 need to live across yield.
14630 Maybe provide a convenience api for EmitThis+EmitLoad?
14632 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
14635 2003-08-05 Miguel de Icaza <miguel@ximian.com>
14637 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
14638 RemapParameterLValue): New methods that are used to turn a
14639 precomputed FieldInfo into an expression like this:
14643 The idea is to use this instead of making LocalVariableReference
14644 have more than one meaning.
14646 * cs-parser.jay: Add error production to BASE.
14648 * ecore.cs: Deal with TypeManager.GetField returning null, which
14649 is now a valid return value.
14651 (FieldExprNoAddress): New expression for Fields whose address can
14654 * expression.cs (LocalVariableReference): During the resolve
14655 phases, create new expressions if we are in a remapping context.
14656 Remove code that dealt with remapping here.
14658 (ParameterReference): same.
14660 (ProxyInstance): New expression, like the `This' expression, but
14661 it is born fully resolved. We know what we are doing, so remove
14662 the errors that are targeted to user-provided uses of `this'.
14664 * statement.cs (Foreach): our variable is now stored as an
14665 Expression; During resolution, follow the protocol, dont just
14666 assume it will return this.
14668 2003-08-06 Martin Baulig <martin@ximian.com>
14670 * support.cs (SeekableStreamReader.cs): New public class.
14672 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
14673 SeekableStreamReader instead of the normal StreamReader.
14675 2003-08-04 Martin Baulig <martin@ximian.com>
14677 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
14678 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
14679 deambiguate casts and delegate invocations.
14680 (parenthesized_expression): Use the new tokens to ensure this is
14681 not a cast of method invocation.
14683 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
14684 when reading a `)' and Deambiguate_CloseParens () was previously
14687 * expression.cs (ParenthesizedExpression): New class. This is
14688 just used for the CS0075 test.
14689 (Binary.DoResolve): Check for CS0075.
14691 2003-07-29 Ravi Pratap <ravi@ximian.com>
14693 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
14694 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
14695 reference comparison.
14697 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
14698 examine the ReturnType for equality - this is necessary in the
14699 cases of implicit and explicit operators whose signature also
14700 includes the return type.
14702 2003-07-26 Miguel de Icaza <miguel@ximian.com>
14704 * namespace.cs: Cache the result of the namespace computation,
14705 instead of computing it every time.
14707 2003-07-24 Miguel de Icaza <miguel@ximian.com>
14709 * decl.cs: Use a global arraylist that we reuse over invocations
14710 to avoid excesive memory consumption. Reduces memory usage on an
14711 mcs compile by one meg (45 average).
14713 * typemanager.cs (LookupTypeReflection): In .NET pointers are
14714 private, work around that.
14716 2003-07-23 Miguel de Icaza <miguel@ximian.com>
14718 * literal.cs (IntLiteral): Define Zero and One static literals.
14720 * cs-parser.jay (integer_literal): use static literals to reduce
14721 memory usage for the most used literals (0, 1 and -1). 211kb
14722 reduced in memory usage.
14724 Replace all calls to `new ArrayList' with `new
14725 ArrayList(4)' which is a good average number for most allocations,
14726 and also requires only 16 bytes of memory for its buffer by
14729 This reduced MCS memory usage in seven megabytes for the RSS after
14732 2003-07-28 Ravi Pratap <ravi@ximian.com>
14734 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
14735 handle params methods the correct way by forming only one
14736 applicable set with params and normal methods in them. Earlier we
14737 were looking at params methods only if we found no normal methods
14738 which was not the correct thing to do.
14740 (Invocation.BetterFunction): Take separate arguments indicating
14741 when candidate and the best method are params methods in their
14744 This fixes bugs #43367 and #46199.
14746 * attribute.cs: Documentation updates.
14748 (CheckAttribute): Rename to CheckAttributeTarget.
14749 (GetValidPlaces): Rename to GetValidTargets.
14751 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
14752 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
14756 2003-07-28 Miguel de Icaza <miguel@ximian.com>
14758 * codegen.cs: Compute IsGeneric correctly.
14760 * cs-parser.jay: Introduce OP_GENERIC_LT for the grammar ambiguity
14763 Bring back (temporarily) OP_LEFT_SHIFT, OP_RIGHT_SHIFT,
14764 OP_SHIFT_RIGHT_ASSIGN, OP_SHIFT_LEFT_ASSIGN. There were too many
14765 regressions, and I was chasing more bugs than I required.
14767 * interface.cs: Use expressions for base type names (like classes
14768 and structs have been doing for a while now), and resolve that.
14769 This patch should probably go into head as well.
14771 This makes it one less user of FindType.
14773 2003-07-24 Miguel de Icaza <miguel@ximian.com>
14775 This compiler can not self host currently. Need to fix that.
14777 * Makefile: compile to `gmcs.exe'
14779 * driver.cs: Turn on v2 by default on gmcs.
14781 * generic.cs (ConstructedType): Does no longer take a container
14782 type argument; That will be taken care of later.
14784 (ConstructedType.DoResolve, ConstructedType.ResolveAsTypeStep):
14785 Use SimpleName to resolve for now, so we can continue the work on
14786 the parser, until we get Type.GetType that understands generics.
14788 (ConstructedType.ToString): Implement
14790 (TypeArguments.Resolve): Resolve the child expressions as types.
14792 * cs-parser.jay: Rename interface_constraints to
14793 type_parameter_constraints
14795 (namespace_or_type_name): Only use constructed types for the basic
14796 construction, we will deal with identifier<...> later.
14798 (type/type_name): No longer call DecomposeQI, as
14799 namespace_or_type_name is always decoded now.
14801 2003-07-22 Ravi Pratap <ravi@ximian.com>
14803 * expression.cs (Invocation.OverloadResolve): Follow the spec more
14804 closely: we eliminate methods in base types when we have an
14805 applicable method in a top-level type.
14807 Please see section 14.5.5.1 for an exact description of what goes
14810 This fixes bug #45127 and a host of other related to corlib compilation.
14812 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
14813 array is the method corresponding to the top-level type (this is
14814 because of the changes made to icall.c) so we change this
14817 (MethodGroupExpr.Name): This too.
14819 * typemanager.cs (GetElementType): New method which does the right
14820 thing when compiling corlib.
14822 * everywhere: Make use of the above in the relevant places.
14824 2003-07-22 Martin Baulig <martin@ximian.com>
14826 * cs-parser.jay (invocation_expression): Moved
14827 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
14828 `cast_expression', but create a InvocationOrCast which later
14829 resolves to either an Invocation or a Cast.
14831 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
14832 method; call this before EmitStatement() to make sure that this
14833 expression can be used as a statement.
14835 * expression.cs (InvocationOrCast): New class; resolves to either
14836 an Invocation or a Cast.
14838 * statement.cs (StatementExpression): Call ResolveStatement() on
14839 the ExpressionStatement before emitting it.
14841 2003-07-21 Martin Baulig <martin@ximian.com>
14843 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
14844 `ref' and `out' attributes match; fixes #46220.
14845 (MemberAccess.ResolveMemberAccess): You can't reference a type
14846 through an expression; fixes #33180.
14847 (Indexers.GetIndexersForType): Don't return the indexers from
14848 interfaces the class implements; fixes #46502.
14850 2003-07-21 Martin Baulig <martin@ximian.com>
14852 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
14853 CS0661 checks; fixes bug #30442.
14855 2003-07-21 Martin Baulig <martin@ximian.com>
14857 * decl.cs (AdditionResult): Added `Error'.
14859 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
14861 * typemanager.cs (TypeManager.ChangeType): Catch exceptions; makes
14862 cs0031.cs actually work.
14864 2003-07-20 Miguel de Icaza <miguel@ximian.com>
14866 * cs-parser.jay (namespace_name): do not use
14867 namespace_or_type_name, use qualified_identifier, because
14868 namespace_or_type_name will soon return a composed expression
14869 instead of a string.
14871 (namespace_or_type_name): Instead of returning a string, now this
14872 production returns an expression.
14874 * codegen.cs (EmitContext): Setup IsGeneric property based on
14875 whether our DeclSpace is generic, our the method is generic.
14877 * modifier.cs (Modifiers.METHOD_GENERIC): New definition, use if
14878 the method is generic.
14880 * cs-parser.jay (type_arguments, opt_type_argument_list,
14881 type_parameters, type_parameter_list, opt_type_parameter_list,
14882 type_parameter,, opt_type_parameter_constraints_clauses,
14883 type_parameter_constraints_clauses,
14884 type_parameter_constraint_clause, type_parameter_constraint,
14885 interface_constraints): Add new production
14887 * decl.cs (DeclSpace): IsGeneric, flag to track whether this
14888 DeclSpace is generic or not.
14890 (DeclSpace.SetParameterInfo): New routine, used to set the
14891 parameter info for a type.
14893 (DeclSpace.LookupGeneric): Lookups a name, and if it is a generic,
14894 returns a GenericTypeExpr
14896 * ecore.cs (SimpleName.ResolveAsTypeStep): If our container is
14897 generic, lookup the generic argument.
14899 * attribute.cs: Do not allow TypeParameterExpressions in
14902 * class.cs: Do not allow the Main method to be defined in a
14905 * expression.cs (SizeOf): Do not allow generic types to be used as
14906 arguments to sizeof.
14908 * typemanager.cs (IsGeneric): Wrapper for Reflection when we have
14909 it: whether a type is generic or not. Only works for types we are
14910 currently building for now.
14912 2003-07-20 Martin Baulig <martin@ximian.com>
14914 * namespace.cs: Fixed that bug which caused a crash when compiling
14915 the debugger's GUI.
14917 2003-07-20 Miguel de Icaza <miguel@ximian.com>
14919 * typemanager.cs (LookupTypeReflection): Never expose types which
14920 are NotPublic, NestedPrivate, NestedAssembly, or
14921 NestedFamANDAssem. We used to return these, and later do a check
14922 that would report a meaningful error, but the problem is that we
14923 would not get the real match, if there was a name override.
14925 2003-07-18 Miguel de Icaza <miguel@ximian.com>
14927 * namespace.cs (Namespace, Name): Do not compute the namespace
14928 name dynamically, compute it in the constructor. This reduced
14929 memory usage by 1697 KB.
14931 * driver.cs: Use --pause to pause at the end.
14933 2003-07-17 Peter Williams <peter@newton.cx>
14935 * Makefile: Change the name of the test target so that it doesn't
14936 conflict with the recursive test target.
14938 2003-07-17 Miguel de Icaza <miguel@ximian.com>
14940 * expression.cs (LocalVariableReference.Emit, EmitAssign,
14941 AddressOf): Do not use EmitThis, that was wrong, use the actual
14944 2003-07-15 Miguel de Icaza <miguel@ximian.com>
14946 * class.cs (MethodData.Define): While checking if a method is an
14947 interface implementation, improve the test: If we are not public
14948 (use new test here: use the computed MethodAttributes directly,
14949 instead of the parsed modifier flags) check if the `implementing'
14950 method comes from an interface or not.
14952 * pending.cs (VerifyPendingMethods): Slightly better error
14955 * makefile: add test target that does the mcs bootstrap.
14957 2003-07-16 Ravi Pratap <ravi@ximian.com>
14959 * interface.cs (Define): Do nothing here since there are no
14960 members to populate etc. Move the attribute emission out of here
14961 since this was just totally the wrong place to put it. Attribute
14962 application happens during the 'Emit' phase, not in the 'Define'
14965 (Emit): Add this method and move the attribute emission here
14967 * rootcontext.cs (EmitCode): Call the Emit method on interface
14970 2003-07-14 Ravi Pratap M <ravi@ximian.com>
14972 * expression.cs (OverloadResolve): Report error only if Location
14973 is not 'Null' which means that there was a probe going on.
14975 2003-07-14 Martin Baulig <martin@ximian.com>
14977 * expression.cs (ConditionalLogicalOperator): New public class to
14978 implement user defined conditional logical operators.
14979 This is section 14.11.2 in the spec and bug #40505.
14981 2003-07-14 Martin Baulig <martin@ximian.com>
14983 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
14985 2003-07-14 Martin Baulig <martin@ximian.com>
14987 * codegen.cs (EmitContext.InFixedInitializer): New public field.
14989 * ecore.cs (IVariable.VerifyFixed): New interface method.
14991 * expression.cs (Unary.ResolveOperator): When resolving the `&'
14992 operator, check whether the variable is actually fixed. Fixes bug
14993 #36055. Set a variable definitely assigned when taking its
14994 address as required by the spec.
14996 * statement.cs (LocalInfo.IsFixed): New field.
14997 (LocalInfo.MakePinned): Set `IsFixed' to true.
14999 2003-07-14 Ravi Pratap M <ravi@ximian.com>
15001 * attribute.cs (Attribute.Resolve): While doing a Member lookup
15002 for .ctors, ensure that we only ask for members declared in the
15003 attribute type (BindingFlags.DeclaredOnly).
15007 * expression.cs (Error_WrongNumArguments): Report error 1501
15008 correctly the way CSC does.
15010 2003-07-13 Martin Baulig <martin@ximian.com>
15012 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
15013 lookup on the fully qualified name, to make things like "X.X" work
15014 where "X.X" is a fully qualified type name, but we also have a
15015 namespace "X" in the using list. Fixes #41975.
15017 2003-07-13 Martin Baulig <martin@ximian.com>
15019 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
15020 function. If we're a CompoundAssign, we need to create an embedded
15021 CompoundAssign, not an embedded Assign.
15022 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
15025 2003-07-13 Martin Baulig <martin@ximian.com>
15027 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
15028 work to fix bug #46088.
15030 2003-07-13 Ravi Pratap <ravi@ximian.com>
15032 * class.cs (Operator.Emit): Do not emit attributes here - it is
15033 taken care of by the Method class that we delegate too. This takes
15034 care of bug #45876.
15036 2003-07-10 Martin Baulig <martin@ximian.com>
15038 * expression.cs (TypeOfVoid): New class.
15039 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
15041 2003-07-10 Martin Baulig <martin@ximian.com>
15043 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
15046 2003-07-10 Martin Baulig <martin@ximian.com>
15048 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
15049 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
15051 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
15053 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
15055 2003-07-10 Martin Baulig <martin@ximian.com>
15057 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
15058 of decimal. Fixes #42850.
15060 NOTE: I also fixed the created byte blob, but this doesn't work on
15061 the MS runtime and csc never produces any byte blobs for decimal
15064 2003-07-10 Martin Baulig <martin@ximian.com>
15066 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
15067 structs; fixes #32068.
15068 (Block.AddChildVariableNames): Fixed #44302.
15070 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
15072 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
15074 2003-07-07 Miguel de Icaza <miguel@ximian.com>
15076 * attribute.cs: And this test is onger needed.
15078 2003-07-08 Martin Baulig <martin@ximian.com>
15080 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
15081 inaccessible types. Fixes #36313.
15083 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
15085 * namespace.cs (NamespaceEntry): Create implicit entries for all
15086 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
15087 implicit entries for N1.N2 and N1.
15089 2003-07-08 Martin Baulig <martin@ximian.com>
15091 Rewrote the handling of namespaces to fix a lot of the issues
15092 wrt. `using' aliases etc.
15094 * namespace.cs (Namespace): Splitted this class into a
15095 per-assembly `Namespace' and a per-file `NamespaceEntry'.
15097 * typemanager.cs (TypeManager.IsNamespace): Removed.
15098 (TypeManager.ComputeNamespaces): Only compute namespaces from
15099 loaded assemblies here, not the namespaces from the assembly we're
15100 currently compiling.
15102 2003-07-08 Martin Baulig <martin@ximian.com>
15104 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
15106 2003-07-07 Miguel de Icaza <miguel@ximian.com>
15108 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
15111 I thought about the memory savings here, but LookupTypeReflection
15112 is used under already very constrained scenarios. Compiling
15113 corlib or mcs only exposes one hit, so it would not really reduce
15114 any memory consumption.
15116 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
15118 * typemanager.cs: fixes bug #45889 by only adding public types from
15119 other assemblies to the list of known types.
15121 2003-07-07 Miguel de Icaza <miguel@ximian.com>
15123 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
15124 on the type we resolved.
15126 2003-07-05 Martin Baulig <martin@ximian.com>
15128 * pending.cs (PendingImplementation.ParentImplements): Don't
15129 create the proxy if the parent is abstract.
15131 * class.cs (TypeContainer.DefineIndexers): Process explicit
15132 interface implementations first. Fixes #37714.
15134 2003-07-04 Miguel de Icaza <miguel@ximian.com>
15136 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
15137 defined recursively; but since we modify the input parameters
15138 (left is set to `this' temporarily), we reset this value if the
15139 left_is_explicit is false, which gives the original semantics to
15142 * literal.cs (NullPointer): new class used to represent a null
15143 literal in a pointer context.
15145 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
15146 type is a pointer, use a NullPointer object instead of a
15147 NullLiteral. Closes 43687
15149 (ExplicitConversion): Convert pointer values using
15150 the conv opcode to the proper type.
15152 * ecore.cs (New): change ValueTypeVariable property into a method,
15153 that returns whether the valuetype is suitable for being used.
15155 * expression.cs (Binary.DoNumericPromotions): Only return if we
15156 the int constant was a valid uint, and we can return both left and
15157 right as uints. If not, we continue processing, to trigger the
15158 type conversion. This fixes 39018.
15160 * statement.cs (Block.EmitMeta): During constant resolution, set
15161 the CurrentBlock property on the emitcontext, so that we resolve
15162 constants propertly.
15164 2003-07-02 Martin Baulig <martin@ximian.com>
15166 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
15167 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
15169 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
15170 than emitting it here.
15172 * statement.cs: Fixed some more flow analysis bugs.
15174 2003-07-02 Martin Baulig <martin@ximian.com>
15176 * class.cs (MethodData.Define): When implementing interface
15177 methods, set Final unless we're Virtual.
15179 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
15180 check work for interface methods.
15182 2003-07-01 Martin Baulig <martin@ximian.com>
15184 * ecore.cs (EmitContext.This): Replaced this property with a
15185 GetThis() method which takes a Location argument. This ensures
15186 that we get the correct error location for a CS0188.
15188 2003-07-01 Miguel de Icaza <miguel@ximian.com>
15190 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
15191 ImplicitStandardConversion.
15193 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
15195 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
15197 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
15200 2003-06-30 Miguel de Icaza <miguel@ximian.com>
15202 * class.cs (Constructor.Define): Turn off initlocals for unsafe
15205 (MethodData.Define): Turn off initlocals for unsafe methods.
15207 2003-06-29 Miguel de Icaza <miguel@ximian.com>
15209 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
15210 complete; Fixes #37521.
15212 * delegate.cs: Use Modifiers.TypeAttr to compute the
15213 TypeAttributes, instead of rolling our own. This makes the flags
15214 correct for the delegates.
15216 2003-06-28 Miguel de Icaza <miguel@ximian.com>
15218 * class.cs (Constructor.Define): Set the private flag for static
15219 constructors as well.
15221 * cs-parser.jay (statement_expression): Set the return value to
15222 null, to avoid a crash when we catch an error.
15224 2003-06-24 Miguel de Icaza <miguel@ximian.com>
15226 * cs-parser.jay: Applied patch from Jackson that adds support for
15227 extern and unsafe modifiers to destructor declarations.
15229 * expression.cs: Report error 21 if the user is trying to index a
15232 * driver.cs: Add an error message, suggested by the bug report.
15234 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
15235 if we do not have a ": this ()" constructor initializer. Fixes 45149
15237 2003-06-14 Miguel de Icaza <miguel@ximian.com>
15239 * namespace.cs: Add some information to reduce FAQs.
15241 2003-06-13 Miguel de Icaza <miguel@ximian.com>
15243 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
15244 underlying enumeration types. Fixes #43915.
15246 * expression.cs: Treat ushort/short as legal values to be used in
15247 bitwise operations.
15249 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
15251 * delegate.cs: transfer custom attributes for paramenters from
15252 the delegate declaration to Invoke and BeginInvoke.
15254 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
15256 * attribute.cs: handle custom marshalers and emit marshal info
15259 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
15261 * makefile.gnu: Added anonymous.cs to the compiler sources.
15263 2003-05-28 Miguel de Icaza <miguel@ximian.com>
15265 * iterators.cs: Change the name of the proxy class to include two
15268 * cs-parser.jay: Update grammar to include anonymous methods.
15270 * anonymous.cs: new file.
15272 2003-05-27 Miguel de Icaza <miguel@ximian.com>
15274 * class.cs (Field.Define): Add missing test for pointers and
15277 2003-05-27 Ravi Pratap <ravi@ximian.com>
15279 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
15280 we use the stobj opcode.
15282 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
15283 since it wasn't the correct fix.
15285 It still is puzzling that we are required to use stobj for IntPtr
15286 which seems to be a ValueType.
15288 2003-05-26 Miguel de Icaza <miguel@ximian.com>
15290 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
15291 during regular simple name resolution. Now, the trick is that
15292 instead of returning for processing the simplename, we do a
15293 TypeManager.LookupType (ie, a rooted lookup as opposed to a
15294 contextual lookup type). If a match is found, return that, if
15295 not, return for further composition.
15297 This fixes long-standing 30485.
15299 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
15300 using the address to initialize an object, do an Stobj instead of
15301 using the regular Stelem.
15303 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
15304 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
15305 Because if we are a BaseIndexerAccess that value will be true.
15308 * statement.cs (GotoCase.Resolve): Return after reporting an
15309 error, do not attempt to continue.
15311 * expression.cs (PointerArithmetic.Emit): If our operand is a
15312 long, convert our constants to match the operand before
15313 multiplying. Convert to I type before adding. Fixes 43670.
15315 2003-05-14 Ravi Pratap <ravi@ximian.com>
15317 * enum.cs (ImplicitConversionExists) : Rename to
15318 ImplicitEnumConversionExists to remove ambiguity.
15320 * ecore.cs (NullCast): New type of cast expression class which
15321 basically is very similar to EmptyCast with the difference being
15322 it still is a constant since it is used only to cast a null to
15324 (eg. (string) null)
15326 * convert.cs (ImplicitReferenceConversion): When casting a null
15327 literal, we return a NullCast.
15329 * literal.cs (NullLiteralTyped): Remove - I don't see why this
15330 should be around anymore.
15332 The renaming (reported was slightly wrong). Corrections:
15334 ConvertImplicitStandard -> ImplicitConversionStandard
15335 ConvertExplicitStandard -> ExplicitConversionStandard
15337 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
15338 before passing them in !
15340 * convert.cs (ImplicitConversionStandard): When comparing for
15341 equal expr and target types, ensure that expr is not a
15344 In general, we must not be checking (expr_type ==
15345 target_type) in the top level conversion methods
15346 (ImplicitConversion, ExplicitConversion etc). This checking is
15347 done in the methods that they delegate to.
15349 2003-05-20 Miguel de Icaza <miguel@ximian.com>
15351 * convert.cs: Move Error_CannotConvertType,
15352 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
15353 ImplicitNumericConversion, ImplicitConversionExists,
15354 ImplicitUserConversionExists, StandardConversionExists,
15355 FindMostEncompassedType, FindMostSpecificSource,
15356 FindMostSpecificTarget, ImplicitUserConversion,
15357 ExplicitUserConversion, GetConversionOperators,
15358 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
15359 TryImplicitIntConversion, Error_CannotConvertImplicit,
15360 ConvertImplicitRequired, ConvertNumericExplicit,
15361 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
15362 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
15365 Perform the following renames:
15367 StandardConversionExists -> ImplicitStandardConversionExists
15368 ConvertImplicit -> ImplicitConversion
15369 ConvertImplicitStandard -> ImplicitStandardConversion
15370 TryImplicitIntConversion -> ImplicitIntConversion
15371 ConvertImplicitRequired -> ImplicitConversionRequired
15372 ConvertNumericExplicit -> ExplicitNumericConversion
15373 ConvertReferenceExplicit -> ExplicitReferenceConversion
15374 ConvertExplicit -> ExplicitConversion
15375 ConvertExplicitStandard -> ExplicitStandardConversion
15377 2003-05-19 Martin Baulig <martin@ximian.com>
15379 * statement.cs (TypeInfo.StructInfo): Made this type protected.
15380 (TypeInfo): Added support for structs having structs as fields.
15382 * ecore.cs (FieldExpr): Implement IVariable.
15383 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
15384 VariableInfo for the field.
15386 2003-05-18 Martin Baulig <martin@ximian.com>
15388 * expression.cs (This.DoResolve): Report a CS0027 if we're
15389 emitting a field initializer.
15391 2003-05-18 Martin Baulig <martin@ximian.com>
15393 * expression.cs (This.ResolveBase): New public function.
15394 (This.DoResolve): Check for CS0188.
15396 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
15399 * ecore.cs (MethodGroupExpr.DoResolve): Set the
15400 `instance_expression' to null if we don't have any non-static
15403 2003-05-18 Martin Baulig <martin@ximian.com>
15405 Reworked the way how local variables and parameters are handled by
15406 the flow analysis code.
15408 * statement.cs (TypeInfo, VariableMap): New public classes.
15409 (VariableInfo): New public class. This is now responsible for
15410 checking whether a variable has been assigned. It is used for
15411 parameters and local variables.
15412 (Block.EmitMeta): Take the InternalParameters as argument; compute
15413 the layout of the flow vectors here.
15414 (Block.LocalMap, Block.ParameterMap): New public properties.
15415 (FlowBranching): The .ctor doesn't get the InternalParameters
15416 anymore since Block.EmitMeta() now computes the layout of the flow
15418 (MyStructInfo): This class is now known as `StructInfo' and nested
15419 in `TypeInfo'; we don't access this directly anymore.
15421 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
15422 property and removed IsAssigned(), IsFieldAssigned(),
15423 SetAssigned() and SetFieldAssigned(); we now call them on the
15424 VariableInfo so we don't need to duplicate this code everywhere.
15426 * expression.cs (ParameterReference): Added `Block block' argument
15428 (LocalVariableReference, ParameterReference, This): The new
15429 VariableInfo class is now responsible for all the definite
15432 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
15433 IsParameterAssigned, SetParameterAssigned): Removed.
15435 2003-05-18 Martin Baulig <martin@ximian.com>
15437 * typemanager.cs (InitCoreTypes): Try calling
15438 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
15439 the 3-args-version. Corlib now also needs our `void_type'.
15440 (GetMethod): Added overloaded version which takes an optional
15441 `bool report_errors' to allow lookups of optional methods.
15443 2003-05-12 Martin Baulig <martin@ximian.com>
15445 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
15446 only used for locals and not for parameters.
15448 2003-05-12 Miguel de Icaza <miguel@ximian.com>
15450 * support.cs (InternalParameters.ParameterType): Return the
15451 ExternalType of the parameter.
15453 * parameter.cs (Parameter.ExternalType): drop the two arguments,
15456 2003-05-11 Miguel de Icaza <miguel@ximian.com>
15458 * class.cs (MethodData.Define): Do not set the `newslot' on
15459 interface members, if they are also flagged as "override".
15461 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
15462 better code for ++i and i++. This only works for static fields
15463 and local variables.
15465 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
15466 want to pull the DeclSpace out of the builder_to_declspace instead
15467 of the TypeBuilder (like in TypeContainer.FindMembers).
15469 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
15470 instead of LookupTypeContainer. Fixes the crash on .NET for
15471 looking up interface members.
15473 * const.cs: Create our own emit context during the Definition
15474 stage, so that constants are evaluated in the proper context, when
15475 a recursive definition happens.
15477 2003-05-11 Martin Baulig <martin@ximian.com>
15479 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
15480 new block for a switch section.
15481 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
15482 the adding/lookup in the switch block. Fixes #39828.
15484 2003-05-09 Miguel de Icaza <miguel@ximian.com>
15486 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
15487 functionality: I needed to convert the data after I had performed
15488 the add/sub operation into the operands type size.
15490 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
15491 pass the type for the box operation, otherwise the resulting
15492 object would have been of type object.
15494 (BoxedCast): Add constructor to specify the type to box as.
15496 2003-05-07 Miguel de Icaza <miguel@ximian.com>
15498 * iterators.cs: I was reusing the `count' variable inadvertently,
15499 take steps to not allow this to happen.
15501 2003-05-06 Miguel de Icaza <miguel@ximian.com>
15503 * attribute.cs (Attribute.Resolve): Params attributes are encoded
15504 by creating an array at the point where the params starts and
15505 putting all those arguments there, then adjusting the size of the
15508 2003-05-05 Miguel de Icaza <miguel@ximian.com>
15510 * expression.cs (New.AddressOf): Implement interface
15511 IMemoryLocation. This is used when the `new' operator is used in
15512 the context of an invocation to a method on a value type.
15514 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
15517 * namespace.cs: Also check the using aliases here.
15519 * driver.cs: Move the test for using validity after the types have
15520 been entered, so we do a single pass that also includes the using
15523 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
15524 in the regular case. CreateSiblingForFinally is doing extra
15527 * attribute.cs (GetAttributeArgumentExpression): Store the result
15528 on an out value, and use the return value to indicate failure
15529 instead of using null (which is a valid return for Constant.GetValue).
15531 * statement.cs: Perform the analysis flow for the increment
15532 portion after the statement, because this will be the real flow of
15533 execution. Fixes #42385
15535 * codegen.cs (EmitContext.EmitArgument,
15536 EmitContext.EmitStoreArgument): New helper functions when the
15537 RemapToProxy flag is set.
15539 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
15542 Add support for remapping parameters.
15544 * iterators.cs: Propagate parameter values; Store parameter
15545 values in the proxy classes.
15547 2003-05-04 Miguel de Icaza <miguel@ximian.com>
15549 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
15550 need a proxy reference; I do not know what I was thinking
15552 * cs-parser.jay (constructor_initializer): catch another error,
15553 and display nice message.
15555 (field_declaration): catch void field declaration
15556 to flag a better error.
15558 * class.cs (MemberBase.CheckBase): Report an error instead of a
15559 warning if a new protected member is declared in a struct.
15560 (Field.Define): catch the error of readonly/volatile.
15562 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
15564 (FieldExpr.AddressOf): ditto. Catch error where the address of a
15565 volatile variable is taken
15567 2003-05-02 Miguel de Icaza <miguel@ximian.com>
15569 * statement.cs (Fixed.Resolve): Report an error if we are not in
15572 2003-05-01 Miguel de Icaza <miguel@ximian.com>
15574 * typemanager.cs: reuse the code that handles type clashes for
15575 delegates and enumerations.
15577 * class.cs (Report28): Always report.
15579 * expression.cs (EncodeAsAttribute): Allow nulls here.
15581 2003-04-28 Miguel de Icaza <miguel@ximian.com>
15583 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
15584 the functionality for testing whether an expression is valid for
15585 an attribute here. Also handle the case of arrays of elements
15588 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
15589 encoding a linear array into an array of objects that are suitable
15590 to be passed to an CustomAttributeBuilder.
15592 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
15594 * ecore.cs: (FieldExpr): Handle field remapping here.
15596 * iteratators.cs: Pass the instance variable (if the method is an
15597 instance method) to the constructors, so we can access the field
15598 variables on the class.
15600 TODO: Test this with structs. I think the THIS variable on
15601 structs might have to be a pointer, and not a refenrece
15603 2003-04-27 Miguel de Icaza <miguel@ximian.com>
15605 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
15606 local variables to fields in a proxy class.
15608 * iterators.cs (PopulateProxy): Rename our internal fields to
15610 Create a <THIS> field if we are an instance method, so we can
15611 reference our parent container variables.
15612 (MapVariable): Called back from the EmitContext code to enter a
15613 new variable to field mapping into the proxy class (we just create
15617 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
15618 for using the remapped locals to fields.
15620 I placed the code here, because that gives the same semantics to
15621 local variables, and only changes the Emit code.
15623 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
15624 statements inside iterators.
15625 (VariableInfo): Add a FieldBuilder for the cases when we are
15626 remapping local variables to fields in a proxy class
15628 * ecore.cs (SimpleNameResolve): Avoid testing two times for
15629 current_block != null.
15631 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
15632 not cope with strings, as it has been moved to the
15633 TableSwitchEmit. Fixed bug in switch generation.
15635 * expression.cs (New.DoResolve): Provide more context for the user
15636 when reporting an error.
15638 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
15641 * expression.cs (MemberAccess.DoResolve): When we get a type back,
15642 check the permissions for it. Note than in a type-resolution
15643 context the check was already present in DeclSpace.ResolveType,
15644 but was missing from the MemberAccess.
15646 (ArrayCreation.CheckIndices): warn if the user has
15647 more nested levels of expressions, but there are no more
15648 dimensions specified. Avoids crash on bug 41906.
15650 2003-04-26 Miguel de Icaza <miguel@ximian.com>
15652 * statement.cs (Block): replace Implicit bool, for a generic
15654 New flag: `Unchecked'. This is used during the EmitMeta phase
15655 (which is out-of-line with the regular Resolve/Emit process for a
15656 statement, as this is done ahead of time, but still gets a chance
15657 to call constant resolve).
15659 (Block.Flags): new enum for adding a new flag.
15661 (Block.EmitMeta): track the state of unchecked.
15663 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
15664 to enable constant resolution to work there as well.
15666 2003-04-22 Miguel de Icaza <miguel@ximian.com>
15668 * typemanager.cs (ienumerable_type): Also look up
15669 System.Collections.IEnumerable.
15671 2003-04-21 Miguel de Icaza <miguel@ximian.com>
15673 TODO: Test more than one conditional per method.
15675 * class.cs (Indexer.Define): Report the location where the user is
15676 referencing the unsupported feature.
15678 (MethodData): Overload the use of `conditionals' to
15679 minimize the creation of needless ArrayLists. This saves roughly
15680 212kb on my machine.
15682 (Method): Implement the new IIteratorContainer interface.
15683 (Method.SetYields): Implement the method by setting the ModFlags
15684 to contain METHOD_YIELDS.
15686 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
15687 which just got set to null.
15689 * iterators.cs: New file.
15691 (Yield, YieldBreak): New statements.
15693 * statement.cs (Return.Resolve): Flag an error if we are used in
15694 an iterator method.
15696 * codegen.cs (InIterator): New flag set if the code is being
15697 compiled in an iterator method.
15699 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
15700 internal modifier, and we just use it to avoid adding extra
15701 fields, as this is seldom used.
15703 * cs-parser.jay: Add yield_statement (yield and yield break).
15705 * driver.cs: New flag -v2 to turn on version 2 features.
15707 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
15708 hashtable when v2 is enabled.
15710 2003-04-20 Miguel de Icaza <miguel@ximian.com>
15712 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
15713 there is already a namespace defined with this name.
15715 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
15716 people upgraded their corlibs.
15718 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
15719 always use fully qualified types, no need to use the compiler
15722 (TypeManager.IsNamespace): Use binarysearch.
15724 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
15725 AddDelegate): I did not quite use the new IsValid API properly: I
15726 have to pass the short-name and the fullname. I was passing only
15727 the basename instead of the fullname sometimes.
15729 (TypeContainer.DefineType): call NamespaceClash.
15731 * interface.cs (Interface.DefineType): use NamespaceClash before
15734 * delegate.cs (Delegate.DefineType): use NamespaceClash before
15737 * enum.cs: (Enum.DefineType): use NamespaceClash before
15740 * typemanager.cs (: 3-line patch that gives us some tasty 11%
15741 speed increase. First, use the negative_hits cache when we get a
15742 negative. Second, add the type with its full original name
15743 instead of the new . and + encoded name (reflection uses + to
15744 separate type from a nested type). Use LookupTypeReflection
15745 directly which bypasses the type->name hashtable (that we already
15746 know does not contain the type.
15748 * decl.cs (DeclSpace.ResolveTypeExpr): track the
15749 location/container type.
15751 * driver.cs: When passing utf8, use directly the UTF8Encoding.
15753 2003-04-19 Miguel de Icaza <miguel@ximian.com>
15755 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
15757 * delegate.cs (NewDelegate.Resolve): Test whether an instance
15758 method is being referenced in the method group from a static
15759 context, and report error 120 if so.
15761 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
15764 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
15765 is created, we create the A namespace).
15767 * cs-parser.jay: A namespace also introduces a DeclarationFound.
15770 2003-04-18 Miguel de Icaza <miguel@ximian.com>
15772 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
15773 invocation to ModuleBuilder.GetType with the same values will
15774 return a new type instance, so we need to cache its return
15777 * expression.cs (Binary.ResolveOperator): Only allow the compare
15778 operators on enums if they are of the same type.
15780 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
15781 types of ValueType on their own case. Before we were giving them
15782 the same treatment as objects.
15784 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
15785 fullname. Short name is used to compare against container name.
15786 Fullname is used to check against defined namespace names.
15788 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
15789 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
15791 (Method.CheckBase): Call parent.
15792 (MemberBase.CheckBase): Check for protected members on sealed
15794 (PropertyBase.CheckBase): Call parent.
15795 (Field.Define): Call parent.
15797 * report.cs: Negative error codes are now mapped to 8000 - code,
15798 so that the display is render more nicely.
15800 * typemanager.cs: Do not use try/catch, instead report a regular
15803 (GetPointerType, GetReferenceType): These methods provide
15804 mechanisms to obtain the T* and T& from a T. We had the code
15805 previously scattered around the code base, and it also used
15806 TypeManager.LookupType that would go through plenty of caches.
15807 This one goes directly to the type source.
15809 In some places we did the Type.GetType followed by
15810 ModuleBuilder.GetType, but not in others, so this unifies the
15811 processing as well.
15813 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
15814 statements now that we have namespace information.
15816 * typemanager.cs (IsNamespace): New method, returns whether the
15817 string presented is a namespace or not.
15819 (ComputeNamespaces): New public entry point, computes the list of
15820 available namespaces, using the GetNamespaces API call in Mono, or
15821 the slower version in MS.NET.
15823 Now before we start the semantic analysis phase, we have a
15824 complete list of namespaces including everything that the user has
15827 Deleted old code to cache namespaces in .nsc files.
15829 2003-04-17 Miguel de Icaza <miguel@ximian.com>
15831 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
15832 class/struct location definition Location for the implicit
15833 constructor location.
15835 (Operator.Define): Use the location of the operator for the
15836 implicit Method definition.
15838 (Constructor.Emit): use the constructor location for the implicit
15839 base initializer constructor.
15841 * ecore.cs: Remove ITypeExpression. This interface is now gone,
15842 and the Expression class now contains two new methods:
15844 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
15845 isolate type lookup from the rest of the resolution process.
15847 Since we use Expressions to hold type definitions due to the way
15848 we parse the input we have historically overloaded Resolve to
15849 perform the Type lookups if a special flag is passed. Now this is
15850 eliminated and two methods take their place.
15852 The differences in the two methods between xStep and xTerminal is
15853 that xStep is involved in our current lookup system that uses
15854 SimpleNames to compose a name, while xTerminal is used just to
15855 catch the case where the simplename lookup failed.
15857 2003-04-16 Miguel de Icaza <miguel@ximian.com>
15859 * expression.cs (ResolveMemberAccess): Remove redundant code.
15860 TypeExpr expressions are always born fully resolved.
15862 * interface.cs (PopulateMethod): Do not lookup the types twice.
15863 We were doing it once during SemanticAnalysis and once during
15866 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
15867 in local variable type definitions, were being returned as a
15868 SimpleName (we decomposed everything into a string), that is
15869 because primary_expression was being used instead of a type in the
15870 grammar (reduce/reduce conflicts).
15872 The part that was wrong is that we converted the expression into a
15873 string (an oversimplification in one hand, compounded with primary
15874 expressions doing string concatenation).
15880 Would return "A.B.C[]" as a SimpleName. This stopped things like
15881 using clauses from working on this particular context. And a type
15882 was being matched directly against "A.B.C[]".
15884 We now use the correct approach, and allow for ComposedCast to be
15885 part of the unary expression. So the "A.B.C []" become a composed
15886 cast of "A.B.C" (as a nested group of MemberAccess with a
15887 SimpleName at the end) plus the rank composition "[]".
15891 2003-04-10 Miguel de Icaza <miguel@ximian.com>
15893 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
15894 for the access level checking.
15896 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
15897 `TypeContainer container', because I kept getting confused when I
15898 was debugging this code.
15900 * expression.cs (Indexers): Instead of tracking getters/setters,
15901 we now track them in parallel. We create one arraylist less, but
15902 most importantly it is possible now for the LValue code to find a
15903 matching get for a set.
15905 (IndexerAccess.DoResolveLValue): Update the code.
15906 GetIndexersForType has been modified already to extract all the
15907 indexers from a type. The code assumed it did not.
15909 Also make the code set the correct return type for the indexer.
15910 This was fixed a long time ago for properties, but was missing for
15911 indexers. It used to be void_type.
15913 (Binary.Emit): Test first for doubles instead of
15914 floats, as they are more common.
15916 (Binary.EmitBranchable): Use the .un version of the branch opcodes
15917 when dealing with floats and the <=, >= operators. This fixes bug
15920 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
15921 to load the array value by emitting a load on the foreach variable
15922 type. This was incorrect.
15924 We now emit the code to load an element using the the array
15925 variable type, and then we emit the conversion operator.
15929 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
15931 * attribute.cs: Avoid allocation of ArrayLists in the common case.
15933 2003-04-09 Miguel de Icaza <miguel@ximian.com>
15935 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
15936 test for protection before we test for signatures.
15938 (MethodSignature.ToString): implement.
15940 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
15941 to the case where we reduced into a LongConstant.
15943 * decl.cs (CheckAccessLevel): If the type is an array, we can not
15944 depend on whether the information is acurrate, because the
15945 Microsoft runtime will always claim that the array type is public,
15946 regardless of the real state.
15948 If the type is a pointer, another problem happens: the type is
15949 reported as non-public in Microsoft.
15951 In both cases we have to call CheckAccessLevel recursively with
15952 the underlying type as the argument to be tested.
15954 2003-04-08 Miguel de Icaza <miguel@ximian.com>
15956 * assign.cs (Assign.Emit): If we are dealing with a compound
15957 assignment expression, we should use the code path that stores the
15958 intermediate result in a temporary value. This fixes #40903.
15960 *expression.cs (Indirection.ToString): Provide ToString method for
15963 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
15965 * class.cs: Null out fields holding references to Block objects so
15966 they can be garbage collected.
15968 * expression.cs (OverloadResolve): Remove unused local.
15970 2003-04-07 Martin Baulig <martin@ximian.com>
15972 * codegen.cs (EmitContext.CurrentFile): New public field.
15973 (EmitContext.Mark): Use the CurrentFile to check whether the
15974 location is in the correct file.
15975 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
15977 2003-04-07 Martin Baulig <martin@ximian.com>
15979 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
15981 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
15982 location. [FIXME: The location argument which gets passed to this
15983 method is sometimes wrong!]
15985 2003-04-07 Nick Drochak <ndrochak@gol.com>
15987 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
15989 2003-04-07 Miguel de Icaza <miguel@ximian.com>
15991 * expression.cs (Indirection.EmitAssign): We were using the
15992 temporary, but returning immediately instead of continuing the
15995 2003-04-06 Martin Baulig <martin@ximian.com>
15997 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
15998 if it's a nested child, but also deriving from the outer class.
16001 * typemanager.cs (IsNestedChildOf): Make this work if it's a
16002 nested child, but also deriving from the outer class. See
16004 (FilterWithClosure): We may access private members of the outer
16005 class if we're a nested child and deriving from the outer class.
16006 (RealMemberLookup): Only set `closure_private_ok' if the
16007 `original_bf' contained BindingFlags.NonPublic.
16009 2003-04-05 Martin Baulig <martin@ximian.com>
16011 * expression.cs (SizeOf.DoResolve): Use ResolveTypeExpr, so we can
16012 probe if its a type parameter, and if so, flag an error.
16014 * decl.cs: Move here the SetParameterInfo code from class.cs.
16015 Handle IsGeneric here.
16017 Handle a variety of errors in the parameter info definition.
16019 * ecore.cs (SimpleName.DoResolveType): Handle look ups for generic
16020 type parameters here.
16022 * cs-parser.jay (class_declaration): report errors for parameters
16025 2003-01-21 Miguel de Icaza <miguel@ximian.com>
16027 * generic.cs: New file, contains support code for generics.
16029 * cs-parser.jay: Remove OP_SHIFT_LEFT, OP_SHIFT_RIGHT,
16030 OP_SHIFT_LEFT_ASSIGN, OP_SHIFT_RIGHT_ASSIGN.
16032 Update parser for the above removals.
16034 * cs-tokenizer.cs: Do not handle <<= or >>= specially. This is
16035 now taken care of in the parser.
16037 2003-04-02 Miguel de Icaza <miguel@ximian.com>
16039 * class.cs (Event.Define): Do not allow abstract events to have
16042 2003-04-01 Miguel de Icaza <miguel@ximian.com>
16044 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
16045 block in event declarations.
16047 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
16048 value type, get its address.
16050 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
16051 leaving a class on the stack instead of a boolean value (int
16052 0/1). Change the code so we compare against null, and then the
16053 result against zero.
16055 * class.cs (TypeContainer.GetClassBases): We were checking for the
16056 parent class being sealed too late.
16058 * expression.cs (Binary.Emit): For <= and >= when dealing with
16059 floating point values, use cgt.un and clt.un instead of cgt and
16062 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
16064 * statement.cs: Apply the same optimization as MS: skip the
16065 GetEnumerator returning an IEnumerator, and use the one returning a
16066 CharEnumerator instead. This allows us to avoid the try-finally block
16069 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
16071 * cs-parser.jay: Attributes cannot be applied to
16072 namespaces. Fixes #40473
16074 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16077 (Add*): check if the name is valid using the full name for constants,
16078 fields, properties and events.
16080 2003-03-28 Miguel de Icaza <miguel@ximian.com>
16082 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
16083 char constants to be part of the enumeration.
16085 * expression.cs (Conditional.DoResolve): Add support for operator
16086 true. Implements the missing functionality from 14.12
16088 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
16089 operator true/false as required by the spec.
16091 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
16092 implicit conversion to boolean.
16094 * statement.cs (Statement.ResolveBoolean): A boolean expression is
16095 also one where the type implements `operator true'.
16097 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
16098 get an expression that will invoke operator true based on an
16101 (GetConversionOperators): Removed the hack that called op_True
16104 (Expression.ResolveBoolean): Move this from Statement.
16106 2003-03-17 Miguel de Icaza <miguel@ximian.com>
16108 * ecore.cs (FieldExpr): do not allow initialization of initonly
16109 fields on derived classes
16111 2003-03-13 Martin Baulig <martin@ximian.com>
16113 * statement.cs (Block.Emit): Call ig.BeginScope() and
16114 ig.EndScope() when compiling with debugging info; call
16115 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
16117 2003-03-08 Miguel de Icaza <miguel@ximian.com>
16119 * expression.cs (Indexers): Do not construct immediately, allow
16120 for new members to be appended as we go. Fixes 38143
16122 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16124 * expression.cs: save/restore context when resolving an unchecked
16127 2003-03-05 Miguel de Icaza <miguel@ximian.com>
16129 * cfold.cs: Catch division by zero in modulus operator during
16132 2003-03-03 Miguel de Icaza <miguel@ximian.com>
16134 * interface.cs (Interface.DefineMembers): Avoid defining members
16137 2003-02-27 Miguel de Icaza <miguel@ximian.com>
16139 * driver.cs: handle the +/- options for -noconfig
16141 * statement.cs (Unckeched.Resolve): Also track the state of
16142 unchecked in the Resolve phase.
16144 2003-02-27 Martin Baulig <martin@ximian.com>
16146 * ecore.cs (Expression.MemberLookup): Don't create a
16147 MethodGroupExpr for something which is not a method. Fixes #38291.
16149 2003-02-25 Miguel de Icaza <miguel@ximian.com>
16151 * class.cs (MemberBase.CheckParameters): Also check that the type
16152 is unmanaged if it is a pointer.
16154 * expression.cs (SizeOf.Resolve): Add location information.
16156 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
16157 a managed type is declared.
16159 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
16160 parameter modifiers as well. Fixes bug 38606
16162 * class.cs: Very sad. Am backing out the speed up changes
16163 introduced by the ArrayList -> Array in the TypeContainer, as they
16164 were not actually that much faster, and introduced a bug (no error
16165 reports on duplicated methods).
16167 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
16168 source first, this will guarantee that we have a valid expression
16169 before calling in lower levels functions that will require a
16170 resolved object. Then use this original_source in the
16171 target.ResolveLValue instead of the original source that was
16174 Another change. Use target.Resolve instead of LValueResolve.
16175 Although we are resolving for LValues, we will let the Assign code
16176 take care of that (it will be called again from Resolve). This
16177 basically allows code like this:
16179 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
16180 class Y { void A (X x) { x [0] += o; }
16182 The problem was that the indexer was trying to resolve for
16183 set_Item (idx, object o) and never finding one. The real set_Item
16184 was set_Item (idx, X). By delaying the process we get the right
16189 2003-02-23 Martin Baulig <martin@ximian.com>
16191 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
16192 while calling DoEmit ().
16194 * codegen.cs (EmitContext.Mark): Don't mark locations in other
16195 source files; if you use the #line directive inside a method, the
16196 compiler stops emitting line numbers for the debugger until it
16197 reaches the end of the method or another #line directive which
16198 restores the original file.
16200 2003-02-23 Martin Baulig <martin@ximian.com>
16202 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
16204 2003-02-23 Martin Baulig <martin@ximian.com>
16206 * statement.cs (Block.AddChildVariableNames): We need to call this
16207 recursively, not just for our immediate children.
16209 2003-02-23 Martin Baulig <martin@ximian.com>
16211 * class.cs (Event.Define): Always make the field private, like csc does.
16213 * typemanager.cs (TypeManager.RealMemberLookup): Make events
16214 actually work, fixes bug #37521.
16216 2003-02-23 Miguel de Icaza <miguel@ximian.com>
16218 * delegate.cs: When creating the various temporary "Parameters"
16219 classes, make sure that we call the ComputeAndDefineParameterTypes
16220 on those new parameters (just like we do with the formal ones), to
16221 allow them to be resolved in the context of the DeclSpace.
16223 This fixes the bug that Dick observed in Bugzilla #38530.
16225 2003-02-22 Miguel de Icaza <miguel@ximian.com>
16227 * expression.cs (ResolveMemberAccess): When resolving a constant,
16228 do not attempt to pull a constant if the value was not able to
16229 generate a valid constant.
16231 * const.cs (LookupConstantValue): Do not report more errors than required.
16233 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16235 * expression.cs: fixes bug #38328.
16237 2003-02-18 Miguel de Icaza <miguel@ximian.com>
16239 * class.cs: Changed all the various members that can be part of a
16240 class from being an ArrayList to be an Array of the right type.
16241 During the DefineType type_list, interface_list, delegate_list and
16242 enum_list are turned into types, interfaces, delegates and enums
16245 And during the member population, indexer_list, event_list,
16246 constant_list, field_list, instance_constructor_list, method_list,
16247 operator_list and property_list are turned into their real arrays.
16249 Although we could probably perform this operation earlier, for
16250 good error reporting we need to keep the lists and remove the
16251 lists for longer than required.
16253 This optimization was triggered by Paolo profiling the compiler
16254 speed on the output of `gen-sample-program.pl' perl script.
16256 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
16257 not crash in methods like MemberLookupFailed that use this field.
16259 This problem arises when the compiler fails to resolve a type
16260 during interface type definition for example.
16262 2003-02-18 Miguel de Icaza <miguel@ximian.com>
16264 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
16265 inherit from System.Object, so we have to stop at null, not only
16266 when reaching System.Object.
16268 2003-02-17 Miguel de Icaza <miguel@ximian.com>
16270 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
16271 DeclaredOnly because the parent indexer might have had a different
16272 name, but did not loop until the top of the hierarchy was reached.
16274 The problem this one fixes is 35492: when a class implemented an
16275 indexer from an interface, we were getting the interface method
16276 (which was abstract) and we were flagging an error (can not invoke
16279 This also keeps bug 33089 functioning, and test-148 functioning.
16281 * typemanager.cs (IsSpecialMethod): The correct way of figuring
16282 out if a method is special is to see if it is declared in a
16283 property or event, or whether it is one of the predefined operator
16284 names. This should fix correctly #36804.
16286 2003-02-15 Miguel de Icaza <miguel@ximian.com>
16288 The goal here is to remove the dependency on EmptyCast.Peel ().
16289 Killing it completely.
16291 The problem is that currently in a number of places where
16292 constants are expected, we have to "probe" for an EmptyCast, and
16293 Peel, which is not the correct thing to do, as this will be
16294 repetitive and will likely lead to errors.
16296 The idea is to remove any EmptyCasts that are used in casts that
16297 can be reduced to constants, so we only have to cope with
16300 This bug hunt was triggered by Bug 37363 and the desire to remove
16301 the duplicate pattern where we were "peeling" emptycasts to check
16302 whether they were constants. Now constants will always be
16305 * ecore.cs: Use an enumconstant here instead of wrapping with
16308 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
16309 throwing me off. By handling this we can get rid of a few hacks.
16311 * statement.cs (Switch): Removed Peel() code.
16313 2003-02-14 Miguel de Icaza <miguel@ximian.com>
16315 * class.cs: Location information for error 508
16317 * expression.cs (New.DoResolve): Add a guard against double
16318 resolution of an expression.
16320 The New DoResolve might be called twice when initializing field
16321 expressions (see EmitFieldInitializers, the call to
16322 GetInitializerExpression will perform a resolve on the expression,
16323 and later the assign will trigger another resolution
16325 This leads to bugs (#37014)
16327 * delegate.cs: The signature for EndInvoke should contain any ref
16328 or out parameters as well. We were not doing this in the past.
16330 * class.cs (Field.Define): Do not overwrite the type definition
16331 inside the `volatile' group. Turns out that volatile enumerations
16332 were changing the type here to perform a validity test, which
16335 2003-02-12 Miguel de Icaza <miguel@ximian.com>
16337 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
16338 and structs, we do not want to load the instance variable
16340 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
16341 enum_type has to be handled like an object reference (implicit
16342 conversions exists from this to object), but the regular IsClass
16343 and IsValueType tests will never return true for this one.
16345 Also we use TypeManager.IsValueType instead of type.IsValueType,
16346 just for consistency with the rest of the code (this is only
16347 needed if we ever use the construct exposed by test-180.cs inside
16348 corlib, which we dont today).
16350 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
16352 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
16355 2003-02-09 Martin Baulig <martin@ximian.com>
16357 * namespace.cs (Namespace..ctor): Added SourceFile argument.
16358 (Namespace.DefineNamespaces): New static public method; this is
16359 called when we're compiling with debugging to add all namespaces
16360 to the symbol file.
16362 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
16363 pass it to the Namespace's .ctor.
16365 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
16366 and MethodBase arguments; pass the namespace ID to the symwriter;
16367 pass the MethodBase instead of the token to the symwriter.
16368 (SymbolWriter.DefineNamespace): New method to add a namespace to
16371 2003-02-09 Martin Baulig <martin@ximian.com>
16373 * symbolwriter.cs: New file. This is a wrapper around
16374 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
16375 methods here in near future.
16377 2003-02-09 Martin Baulig <martin@ximian.com>
16379 * codegen.cs (EmitContext.Mark): Just pass the arguments to
16380 ILGenerator.MarkSequencePoint() which are actually used by the
16383 2003-02-09 Martin Baulig <martin@ximian.com>
16385 * location.cs (SourceFile): New public sealed class. This
16386 contains the name and an index which is used in the location's token.
16387 (Location): Reserve an appropriate number of bits in the token for
16388 the source file instead of walking over that list, this gives us a
16389 really huge performance improvement when compiling with debugging.
16391 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
16392 `SourceFile' argument instead of a string.
16393 (Driver.ProcessFile): Add all the files via Location.AddFile(),
16394 but don't parse/tokenize here, we need to generate the list of all
16395 source files before we do that.
16396 (Driver.ProcessFiles): New static function. Parses/tokenizes all
16399 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
16400 instead of a string.
16402 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
16405 2003-02-09 Martin Baulig <martin@ximian.com>
16407 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
16408 filename on `#line default'.
16410 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
16412 * statement.cs: don't clear the pinned var when the fixed statement
16413 returns from the method (fixes bug#37752).
16415 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
16417 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
16420 2003-02-07 Martin Baulig <martin@ximian.com>
16422 * driver.cs: Removed the `--debug-args' command line argument.
16424 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
16425 automatically by the AsssemblyBuilder.
16426 (CodeGen.InitializeSymbolWriter): We don't need to call any
16427 initialization function on the symbol writer anymore. This method
16428 doesn't take any arguments.
16430 2003-02-03 Miguel de Icaza <miguel@ximian.com>
16432 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
16433 from referenced assemblies as well.
16435 2003-02-02 Martin Baulig <martin@ximian.com>
16437 * class.cs (MethodData.Emit): Generate debugging info for external methods.
16439 2003-02-02 Martin Baulig <martin@ximian.com>
16441 * class.cs (Constructor.Emit): Open the symbol writer before
16442 emitting the constructor initializer.
16443 (ConstructorInitializer.Emit): Call ec.Mark() to allow
16444 single-stepping through constructor initializers.
16446 2003-01-30 Miguel de Icaza <miguel@ximian.com>
16448 * class.cs: Handle error 549: do not allow virtual methods in
16451 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
16453 * decl.cs: Check access levels when resolving types
16455 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
16457 * statement.cs: Add parameters and locals set in catch blocks that might
16458 return to set vector
16460 2003-01-29 Miguel de Icaza <miguel@ximian.com>
16462 * class.cs (Operator): Set the SpecialName flags for operators.
16464 * expression.cs (Invocation.DoResolve): Only block calls to
16465 accessors and operators on SpecialName methods.
16467 (Cast.TryReduce): Handle conversions from char constants.
16470 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
16472 * statement.cs: small memory and time optimization in FlowBranching.
16474 2003-01-28 Pedro Mart <yoros@wanadoo.es>
16476 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
16477 problem that the last fix but in the other sid (Set).
16479 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
16480 access when there is no indexer in the hierarchy.
16482 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
16484 * class.cs: Combine some if statements.
16486 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16488 * driver.cs: fixed bug #37187.
16490 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
16492 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
16493 any indexer, it's needed to build a list with all the indexers in the
16494 hierarchy (AllGetters), else we have problems. Fixes #35653.
16496 2003-01-23 Miguel de Icaza <miguel@ximian.com>
16498 * class.cs (MethodData.Define): It is wrong for an interface
16499 implementation to be static in both cases: explicit and implicit.
16500 We were only handling this in one case.
16502 Improve the if situation there to not have negations.
16504 * class.cs (Field.Define): Turns out that we do not need to check
16505 the unsafe bit on field definition, only on usage. Remove the test.
16507 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16509 * driver.cs: use assembly.Location instead of Codebase (the latest
16510 patch made mcs fail when using MS assemblies).
16512 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
16514 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
16515 get the path to *corlib.dll.
16517 2003-01-21 Nick Drochak <ndrochak@gol.com>
16521 * typemanager.cs: Remove compiler warnings
16523 2003-01-20 Duncan Mak <duncan@ximian.com>
16525 * AssemblyInfo.cs: Bump the version number to 0.19.
16527 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16529 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
16531 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
16533 * class.cs (Constructor::Emit): Emit debugging info for constructors.
16535 2003-01-17 Miguel de Icaza <miguel@ximian.com>
16537 * cs-parser.jay: Small fix: we were not comparing the constructor
16538 name correctly. Thanks to Zoltan for the initial pointer.
16540 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
16542 * cs-tokenizer.cs: Set file name when specified with #line
16544 2003-01-15 Miguel de Icaza <miguel@ximian.com>
16546 * cs-parser.jay: Only perform the constructor checks here if we
16547 are named like the class; This will help provider a better
16548 error. The constructor path is taken when a type definition is
16549 not found, but most likely the user forgot to add the type, so
16550 report that rather than the constructor error.
16552 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
16554 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
16557 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
16559 * cs-parser.jay: Add cleanup call.
16561 2003-01-13 Duncan Mak <duncan@ximian.com>
16563 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
16564 consistent with other methods.
16566 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
16568 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
16570 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
16572 * attribute.cs: only set GuidAttr to true when we have a
16575 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16579 * typemanager.cs: fixes to allow mcs compile corlib with the new
16580 Type.IsSubclassOf fix.
16582 2003-01-08 Miguel de Icaza <miguel@ximian.com>
16584 * expression.cs (LocalVariableReference.DoResolve): Classify a
16585 constant as a value, not as a variable. Also, set the type for
16588 * cs-parser.jay (fixed_statement): take a type instead of a
16589 pointer_type, so we can produce a better error message later.
16591 * statement.cs (Fixed.Resolve): Flag types that are not pointers
16594 (For.DoEmit): Make inifinite loops have a
16595 non-conditional branch back.
16597 (Fixed.DoEmit): First populate the pinned variables, then emit the
16598 statement, then clear the variables. Before I was emitting the
16599 code once for each fixed piece.
16602 2003-01-08 Martin Baulig <martin@ximian.com>
16604 * statement.cs (FlowBranching.MergeChild): A break in a
16605 SWITCH_SECTION does not leave a loop. Fixes #36155.
16607 2003-01-08 Martin Baulig <martin@ximian.com>
16609 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
16610 lives in the same number space than `param_map'. Fixes #36154.
16612 2003-01-07 Miguel de Icaza <miguel@ximian.com>
16614 * cs-parser.jay (constructor_declaration): Set the
16615 Constructor.ModFlags before probing for it. This makes the
16616 compiler report 514, 515 and 132 (the code was there, but got
16619 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
16620 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
16621 (GotoCase.Resolve): Set `Returns' to ALWAYS.
16623 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
16625 * enum.cs: create the enum static fields using the enum type.
16627 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
16629 * class.cs: don't try to create the ParamBuilder for the return
16630 type if it's not needed (and handle it breaking for the ms runtime
16633 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
16635 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
16637 2002-12-29 Miguel de Icaza <miguel@ximian.com>
16639 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
16640 the command. This showed up while compiling the JANET source
16641 code, which used \r as its only newline separator.
16643 2002-12-28 Miguel de Icaza <miguel@ximian.com>
16645 * class.cs (Method.Define): If we are an operator (because it
16646 reuses our code), then set the SpecialName and HideBySig. #36128
16648 2002-12-22 Miguel de Icaza <miguel@ximian.com>
16650 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
16651 exception, report error 120 `object reference required'.
16653 * driver.cs: Add --pause option, used during to measure the size
16654 of the process as it goes with --timestamp.
16656 * expression.cs (Invocation.DoResolve): Do not allow methods with
16657 SpecialName to be invoked.
16659 2002-12-21 Miguel de Icaza <miguel@ximian.com>
16661 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
16662 number before adding it.
16664 2002-12-21 Ravi Pratap <ravi@ximian.com>
16666 * ecore.cs (StandardImplicitConversion): When in an unsafe
16667 context, we allow conversion between void * to any other pointer
16668 type. This fixes bug #35973.
16670 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
16672 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
16673 is not thrown when extensionless outputs are used
16675 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16677 * rootcontext.cs: fixed compilation of corlib.
16679 2002-12-19 Miguel de Icaza <miguel@ximian.com>
16681 * attribute.cs (Attributes.Contains): Add new method.
16683 * class.cs (MethodCore.LabelParameters): if the parameter is an
16684 `out' parameter, check that no attribute `[In]' has been passed.
16686 * enum.cs: Handle the `value__' name in an enumeration.
16688 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
16690 * decl.cs: Added special case to allow overrides on "protected
16693 2002-12-18 Ravi Pratap <ravi@ximian.com>
16695 * attribute.cs (Attributes.AddAttributeSection): Rename to this
16696 since it makes much more sense.
16698 (Attributes.ctor): Don't require a Location parameter.
16700 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
16702 * attribute.cs (ApplyAttributes): Remove extra Location parameters
16703 since we already have that information per attribute.
16705 * everywhere : make appropriate changes.
16707 * class.cs (LabelParameters): Write the code which actually
16708 applies attributes to the return type. We can't do this on the MS
16709 .NET runtime so we flag a warning in the case an exception is
16712 2002-12-18 Miguel de Icaza <miguel@ximian.com>
16714 * const.cs: Handle implicit null conversions here too.
16716 2002-12-17 Ravi Pratap <ravi@ximian.com>
16718 * class.cs (MethodCore.LabelParameters): Remove the extra
16719 Type [] parameter since it is completely unnecessary. Instead
16720 pass in the method's attributes so that we can extract
16721 the "return" attribute.
16723 2002-12-17 Miguel de Icaza <miguel@ximian.com>
16725 * cs-parser.jay (parse): Use Report.Error to flag errors instead
16726 of ignoring it and letting the compile continue.
16728 * typemanager.cs (ChangeType): use an extra argument to return an
16729 error condition instead of throwing an exception.
16731 2002-12-15 Miguel de Icaza <miguel@ximian.com>
16733 * expression.cs (Unary.TryReduce): mimic the code for the regular
16734 code path. Perform an implicit cast in the cases where we can
16735 implicitly convert to one of the integral types, and then reduce
16736 based on that constant. This fixes bug #35483.
16738 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16740 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
16742 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16744 * namespace.cs: fixed bug #35489.
16746 2002-12-12 Miguel de Icaza <miguel@ximian.com>
16748 * class.cs: Remove some dead code.
16750 * cs-parser.jay: Estimate the number of methods needed
16751 (RootContext.MethodCount);
16753 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
16754 numbers instead of StringBuilders.
16756 * support.cs (PtrHashtable): Add constructor with initial size;
16757 We can now reduce reallocations of the method table.
16759 2002-12-10 Ravi Pratap <ravi@ximian.com>
16761 * attribute.cs (ApplyAttributes): Keep track of the emitted
16762 attributes on a per-target basis. This fixes bug #35413.
16764 2002-12-10 Miguel de Icaza <miguel@ximian.com>
16766 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
16767 default to the Windows 1252 encoding.
16769 (UnixParseOption): Support version, thanks to Alp for the missing
16772 * AssemblyInfo.cs: Add nice assembly information.
16774 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
16777 * cs-parser.jay: Allow a trailing comma before the close bracked
16778 in the attribute_section production.
16780 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
16781 address of the instance was being taken, I will take this out,
16782 because we take the address of the object immediately here.
16784 2002-12-09 Ravi Pratap <ravi@ximian.com>
16786 * typemanager.cs (AreMultipleAllowed): Take care of the most
16787 obvious case where attribute type is not in the current assembly -
16790 2002-12-08 Miguel de Icaza <miguel@ximian.com>
16792 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
16793 definitions, instead of doing that afterwards.
16795 Also we use a nice little hack, depending on the constructor, we
16796 know if we are a "composed" name or a simple name. Hence, we
16797 avoid the IndexOf test, and we avoid
16799 * codegen.cs: Add code to assist in a bug reporter to track down
16800 the source of a compiler crash.
16802 2002-12-07 Ravi Pratap <ravi@ximian.com>
16804 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
16805 types have been emitted for a given element and flag an error
16806 if something which does not have AllowMultiple set is used more
16809 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
16810 attribute types and their corresponding AllowMultiple properties
16812 (AreMultipleAllowed): Check the property for a given type.
16814 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
16815 property in the case we have a TypeContainer.
16817 (Attributes.AddAttribute): Detect duplicates and just skip on
16818 adding them. This trivial fix catches a pretty gross error in our
16819 attribute emission - global attributes were being emitted twice!
16821 Bugzilla bug #33187 is now fixed.
16823 2002-12-06 Miguel de Icaza <miguel@ximian.com>
16825 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
16826 instead of pp_and).
16828 * expression.cs (Binary.ResolveOperator): I can only use the
16829 Concat (string, string, string) and Concat (string, string,
16830 string, string) if the child is actually a concatenation of
16833 2002-12-04 Miguel de Icaza <miguel@ximian.com>
16835 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
16836 context where we need a 2-character lookahead.
16838 * pending.cs (PendingImplementation): Rework so we can keep track
16839 of interface types all the time, and flag those which were
16840 implemented by parents as optional.
16842 2002-12-03 Miguel de Icaza <miguel@ximian.com>
16844 * expression.cs (Binary.ResolveOperator): Use
16845 String.Concat(string,string,string) or
16846 String.Concat(string,string,string,string) when possible.
16848 * typemanager: More helper methods.
16851 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
16853 * pending.cs: remove the bogus return from GetMissingInterfaces()
16854 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
16856 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16858 * namespace.cs: avoid duplicated 'using xxx' being added to
16859 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
16860 when we get more than one 'using' statement for the same namespace.
16861 Report a CS0105 warning for it.
16863 2002-11-30 Miguel de Icaza <miguel@ximian.com>
16865 * cs-tokenizer.cs (consume_identifier): use read directly, instead
16866 of calling getChar/putback, uses internal knowledge of it.
16868 (xtoken): Reorder tokenizer so most common patterns are checked
16869 first. This reduces the compilation time in another 5% (from 8.11s
16870 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
16872 The parsing time is 22% of the compilation in mcs, and from that
16873 64% is spent on the tokenization process.
16875 I tried using a binary search for keywords, but this is slower
16876 than the hashtable. Another option would be to do a couple of
16879 * Not use a StringBuilder, instead use an array of chars,
16880 with a set value. Notice that this way we could catch
16881 the 645 error without having to do it *afterwards*.
16883 * We could write a hand-parser to avoid the hashtable
16884 compares altogether.
16886 The identifier consumption process takes 37% of the tokenization
16887 time. Another 15% is spent on is_number. 56% of the time spent
16888 on is_number is spent on Int64.Parse:
16890 * We could probably choose based on the string length to
16891 use Int32.Parse or Int64.Parse and avoid all the 64-bit
16894 Another 3% is spend on wrapping `xtoken' in the `token' function.
16896 Handle 0xa0 as whitespace (#34752)
16898 2002-11-26 Miguel de Icaza <miguel@ximian.com>
16900 * typemanager.cs (IsCLRType): New routine to tell whether a type
16901 is one of the builtin types.
16903 Maybe it needs to use TypeCodes to be faster. Maybe we could use
16904 typecode in more places instead of doing pointer comparissions.
16905 We could leverage some knowledge about the way the typecodes are
16908 New code to cache namespaces in assemblies, it is currently not
16909 invoked, to be used soon.
16911 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
16913 * expression.cs (Binary.ResolveOperator): specially handle
16914 strings, and do not perform user-defined operator overloading for
16917 2002-11-24 Miguel de Icaza <miguel@ximian.com>
16919 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
16920 internalcall as it is a pretty simple operation; Avoid whenever
16921 possible to call Char.IsLetter.
16923 (consume_identifier): Cut by half the number of
16924 hashtable calls by merging the is_keyword and GetKeyword behavior.
16926 Do not short-circuit, because if we do, we
16927 report errors (ie, #if false && true would produce an invalid
16931 2002-11-24 Martin Baulig <martin@ximian.com>
16933 * expression.cs (Cast.TryReduce): If we're in checked syntax,
16934 check constant ranges and report a CS0221. Fixes #33186.
16936 2002-11-24 Martin Baulig <martin@ximian.com>
16938 * cs-parser.jay: Make this work for uninitialized variable
16939 declarations in the `for' initializer. Fixes #32416.
16941 2002-11-24 Martin Baulig <martin@ximian.com>
16943 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
16944 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
16946 2002-11-24 Martin Baulig <martin@ximian.com>
16948 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
16949 argument; if true, we also check for user-defined conversions.
16950 This is only needed if both arguments are of a user-defined type.
16951 Fixes #30443, added test-175.cs.
16952 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
16954 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
16956 2002-11-24 Martin Baulig <martin@ximian.com>
16958 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
16959 function to get the store opcode.
16960 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
16961 only emit the Ldelema if the store opcode is Stobj. You must run
16962 both test-34 and test-167 to test this. Fixes #34529.
16964 2002-11-23 Martin Baulig <martin@ximian.com>
16966 * ecore.cs (Expression.MemberLookup): Added additional
16967 `qualifier_type' argument which is used when we're being called
16968 from MemberAccess.DoResolve() and null if we're called from a
16970 (Expression.MemberLookupFailed): New method to report errors; this
16971 does the CS1540 check and reports the correct error message.
16973 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
16974 argument for the CS1540 check and redone the way how we're dealing
16975 with private members. See the comment in the source code for details.
16976 (FilterWithClosure): Reverted this back to revision 1.197; renamed
16977 `closure_start_type' to `closure_qualifier_type' and check whether
16978 it's not null. It was not this filter being broken, it was just
16979 being called with the wrong arguments.
16981 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
16982 and pass it the correct `qualifier_type'; this also does the error
16985 2002-11-22 Miguel de Icaza <miguel@ximian.com>
16987 * expression.cs (Invocation.EmitParams): If the we are dealing
16988 with a non-built-in value type, load its address as well.
16990 (ArrayCreation): Use a a pretty constant instead
16991 of the hardcoded value 2. Use 6 instead of 2 for the number of
16992 static initializers.
16994 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
16995 because they are not really value types, just glorified integers.
16997 * driver.cs: Do not append .exe, the CSC compiler does not do it.
16999 * ecore.cs: Remove redundant code for enumerations, make them use
17000 the same code path as everything else, fixes the casting issue
17001 with enumerations in Windows.Forms.
17003 * attribute.cs: Do only cast to string if it is a string, the
17004 validation happens later.
17006 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
17007 people upgrade their corlibs.
17009 * ecore.cs: Oops, enumerations were not following the entire code path
17011 2002-11-21 Miguel de Icaza <miguel@ximian.com>
17013 * typemanager.cs (FilterWithClosure): Commented out the test for
17014 1540 in typemanager.cs, as it has problems when accessing
17015 protected methods from a parent class (see test-174.cs).
17017 * attribute.cs (Attribute.ValidateGuid): new method.
17018 (Attribute.Resolve): Use above.
17020 2002-11-19 Miguel de Icaza <miguel@ximian.com>
17022 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
17024 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
17025 handling for enumerations, as we only needed the TypeContainer
17026 functionality to begin with (this is required for the fix below to
17027 work for enums that reference constants in a container class for
17030 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
17032 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
17033 a valid TypeBuilder to perform lookups on.o
17035 * class.cs (InheritableMemberSignatureCompare): Use true in the
17036 call to GetGetMethod and GetSetMethod, because we are comparing
17037 the signature, and we need to get the methods *even* if they are
17040 (PropertyBase.CheckBase): ditto.
17042 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
17043 GotoCase.Resolve): Use Peel on EmpytCasts.
17045 * ecore.cs (EmptyCast): drop child, add Peel method.
17047 2002-11-17 Martin Baulig <martin@ximian.com>
17049 * ecore.cs (EmptyCast.Child): New public property.
17051 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
17052 label resolved to an EmptyCast. Fixes #34162.
17053 (GotoCase.Resolve): Likewise.
17054 (Block.EmitMeta): Likewise.
17056 2002-11-17 Martin Baulig <martin@ximian.com>
17058 * expression.cs (Invocation.BetterConversion): Prefer int over
17059 uint; short over ushort; long over ulong for integer literals.
17060 Use ImplicitConversionExists instead of StandardConversionExists
17061 since we also need to check for user-defined implicit conversions.
17062 Fixes #34165. Added test-173.cs.
17064 2002-11-16 Martin Baulig <martin@ximian.com>
17066 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
17067 with the `true' and `false' literals. Fixes #33151.
17069 2002-11-16 Martin Baulig <martin@ximian.com>
17071 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
17072 October 22nd; don't do the cs1540 check for static members.
17074 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
17075 now using our own filter here and doing the cs1540 check again.
17077 2002-11-16 Martin Baulig <martin@ximian.com>
17079 * support.cs (InternalParameters): Don't crash if we don't have
17080 any fixed parameters. Fixes #33532.
17082 2002-11-16 Martin Baulig <martin@ximian.com>
17084 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
17085 when looking up static methods to make this work on Windows.
17088 2002-11-16 Martin Baulig <martin@ximian.com>
17090 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
17091 a setter rather than using PropertyInfo.CanWrite.
17093 2002-11-15 Nick Drochak <ndrochak@gol.com>
17095 * class.cs: Allow acces to block member by subclasses. Fixes build
17098 2002-11-14 Martin Baulig <martin@ximian.com>
17100 * class.cs (Constructor.Emit): Added the extern/block check.
17103 2002-11-14 Martin Baulig <martin@ximian.com>
17105 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
17106 iteration while looking for indexers, this is needed because the
17107 indexer may have a different name in our base classes. Fixed the
17108 error reporting (no indexers at all, not get accessor, no
17109 overloaded match). Fixes bug #33089.
17110 (IndexerAccess.DoResolveLValue): Likewise.
17112 2002-11-14 Martin Baulig <martin@ximian.com>
17114 * class.cs (PropertyBase.CheckBase): Make this work for multiple
17115 indexers. Fixes the first part of bug #33089.
17116 (MethodSignature.InheritableMemberSignatureCompare): Added support
17119 2002-11-13 Ravi Pratap <ravi@ximian.com>
17121 * attribute.cs (Attribute.Resolve): Catch the
17122 NullReferenceException and report it since it isn't supposed to
17125 2002-11-12 Miguel de Icaza <miguel@ximian.com>
17127 * expression.cs (Binary.EmitBranchable): Also handle the cases for
17128 LogicalOr and LogicalAnd that can benefit from recursively
17129 handling EmitBranchable. The code now should be nice for Paolo.
17131 2002-11-08 Miguel de Icaza <miguel@ximian.com>
17133 * typemanager.cs (LookupType): Added a negative-hit hashtable for
17134 the Type lookups, as we perform quite a number of lookups on
17135 non-Types. This can be removed once we can deterministically tell
17136 whether we have a type or a namespace in advance.
17138 But this might require special hacks from our corlib.
17142 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
17143 and double which avoids a conversion from an integer to a double.
17145 * expression.cs: tiny optimization, avoid calling IsConstant,
17146 because it effectively performs the lookup twice.
17148 2002-11-06 Miguel de Icaza <miguel@ximian.com>
17150 But a bogus return here to keep the semantics of the old code
17151 until the Mono runtime is fixed.
17153 * pending.cs (GetMissingInterfaces): New method used to remove all
17154 the interfaces that are already implemented by our parent
17155 classes from the list of pending methods.
17157 * interface.cs: Add checks for calls after ResolveTypeExpr.
17159 2002-11-05 Miguel de Icaza <miguel@ximian.com>
17161 * class.cs (Class.Emit): Report warning 67: event not used if the
17162 warning level is beyond 3.
17164 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
17165 being a NullLiteral.
17167 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
17170 * class.cs (TypeContainer.GetClassBases): Cover a missing code
17171 path that might fail if a type can not be resolved.
17173 * expression.cs (Binary.Emit): Emit unsigned versions of the
17176 * driver.cs: use error 5.
17178 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
17180 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
17182 2002-11-01 Miguel de Icaza <miguel@ximian.com>
17184 * cs-parser.jay (switch_section): A beautiful patch from Martin
17185 Baulig that fixed 33094.
17187 2002-10-31 Miguel de Icaza <miguel@ximian.com>
17189 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
17190 Check whether the base is abstract and report an error if so.
17192 * expression.cs (IndexerAccess.DoResolveLValue,
17193 IndexerAccess.DoResolve): ditto.
17195 (Invocation.DoResolve): ditto.
17197 (Invocation.FullMethodDesc): Improve the report string.
17199 * statement.cs (Block): Eliminate IsVariableDefined as it is
17200 basically just a wrapper for GetVariableInfo.
17202 * ecore.cs (SimpleName): Use new
17204 * support.cs (ReflectionParamter.ParameterType): We unwrap the
17205 type, as we return the actual parameter ref/unref state on a
17208 2002-10-30 Miguel de Icaza <miguel@ximian.com>
17210 * support.cs: Return proper flags REF/OUT fixing the previous
17213 * expression.cs: Reverted last patch, that was wrong. Is_ref is
17214 not used to mean `ref' but `ref or out' in ParameterReference
17216 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
17217 full type signature instead of calling TypeManger.CSharpName
17220 * support.cs (InternalParameters.ParameterDesc): Do not compare
17221 directly to the modflags, because REF/OUT will actually be bitsets
17224 * delegate.cs (VerifyMethod): Check also the modifiers.
17226 * cs-tokenizer.cs: Fix bug where floating point values with an
17227 exponent where a sign was missing was ignored.
17229 * driver.cs: Allow multiple assemblies to be specified in a single
17232 2002-10-28 Miguel de Icaza <miguel@ximian.com>
17234 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
17235 because identifiers after a parenthesis would end up in this kind
17236 of production, and we needed to desamiguate it for having casts
17239 (UserDefinedType *) xxx
17241 2002-10-24 Miguel de Icaza <miguel@ximian.com>
17243 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
17244 we should set on the Bindingflags.NonPublic, but not turn on
17245 private_ok. private_ok controls whether a Private member is
17246 returned (this is chekced on the filter routine), while the
17247 BindingFlags.NonPublic just controls whether private/protected
17248 will be allowed. This fixes the problem part of the problem of
17249 private properties being allowed to be used in derived classes.
17251 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
17252 so we can call the children DoResolveLValue method (this will
17253 properly signal errors on lvalue assignments to base properties)
17255 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
17256 getter are null, and we have a property info, we know that this
17257 happened because the lookup failed, so we report an error 122 for
17258 protection level violation.
17260 We also silently return if setter and getter are null in the
17261 resolve functions, this condition only happens if we have flagged
17262 the error before. This is the other half of the problem.
17264 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
17265 not have accessibility information, that is why we were returning
17266 true in the filter function in typemanager.cs.
17268 To properly report 122 (property is inaccessible because of its
17269 protection level) correctly, we report this error in ResolveAccess
17270 by failing if both the setter and the getter are lacking (ie, the
17273 DoResolve and DoLResolve have been modified to check for both
17274 setter/getter being null and returning silently, the reason being
17275 that I did not want to put the knowledge about this error in upper
17278 int old = Report.Errors;
17279 x = new PropertyExpr (...);
17280 if (old != Report.Errors)
17285 So the property expr is returned, but it is invalid, so the error
17286 will be flagged during the resolve process.
17288 * class.cs: Remove InheritablePropertySignatureCompare from the
17289 class, as we no longer depend on the property signature to compute
17290 whether it is possible to implement a method or not.
17292 The reason is that calling PropertyInfo.GetGetMethod will return
17293 null (in .NET, in Mono it works, and we should change this), in
17294 cases where the Get Method does not exist in that particular
17299 class X { public virtual int A { get { return 1; } } }
17301 class Z : Y { public override int A { get { return 2; } } }
17303 Would fail in Z because the parent (Y) would not have the property
17304 defined. So we avoid this completely now (because the alternative
17305 fix was ugly and slow), and we now depend exclusively on the
17308 (PropertyBase.CheckBase): Use a method-base mechanism to find our
17309 reference method, instead of using the property.
17311 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
17312 routines are gone now.
17314 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
17315 names, they were incorrectly named.
17317 * cs-tokenizer.cs: Return are more gentle token on failure.
17319 * pending.cs (PendingImplementation.InterfaceMethod): This routine
17320 had an out-of-sync index variable, which caused it to remove from
17321 the list of pending methods the wrong method sometimes.
17323 2002-10-22 Miguel de Icaza <miguel@ximian.com>
17325 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
17326 CanWrite, because those refer to this particular instance of the
17327 property, and do not take into account the fact that we can
17328 override single members of a property.
17330 Constructor requires an EmitContext. The resolution process does
17331 not happen here, but we need to compute the accessors before,
17332 because the resolution does not always happen for properties.
17334 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
17335 subclass, before we did not update this flag, but we did update
17338 (GetAccessors): Drop this routine, as it did not work in the
17339 presence of partially overwritten set/get methods.
17341 Notice that this broke the cs1540 detection, but that will require
17344 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17348 * driver.cs: issue a warning instead of an error if we don't support
17349 debugging for the platform. Also ignore a couple of errors that may
17350 arise when trying to write the symbols. Undo my previous patch.
17352 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17354 * driver.cs: ignore /debug switch except for Unix platforms.
17356 2002-10-23 Nick Drochak <ndrochak@gol.com>
17358 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
17360 2002-10-21 Miguel de Icaza <miguel@ximian.com>
17362 * driver.cs: Do not make mcs-debug conditional, so we do not break
17363 builds that use it.
17365 * statement.cs (UsageVector.MergeChildren): I would like Martin to
17366 review this patch. But basically after all the children variables
17367 have been merged, the value of "Breaks" was not being set to
17368 new_breaks for Switch blocks. I think that it should be set after
17369 it has executed. Currently I set this to the value of new_breaks,
17370 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
17371 conservative, but I do not understand this code very well.
17373 I did not break anything in the build, so that is good ;-)
17375 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
17377 2002-10-20 Mark Crichton <crichton@gimp.org>
17379 * cfold.cs: Fixed compile blocker. Really fixed it this time.
17381 2002-10-20 Nick Drochak <ndrochak@gol.com>
17383 * cfold.cs: Fixed compile blocker.
17385 2002-10-20 Miguel de Icaza <miguel@ximian.com>
17387 * driver.cs: I was chekcing the key, not the file.
17389 2002-10-19 Ravi Pratap <ravi@ximian.com>
17391 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
17392 message that we were generating - we just need to silently return
17395 2002-10-19 Miguel de Icaza <miguel@ximian.com>
17397 * class.cs (Event.Define): Change my previous commit, as this
17398 breaks the debugger. This is a temporary hack, as it seems like
17399 the compiler is generating events incorrectly to begin with.
17401 * expression.cs (Binary.ResolveOperator): Added support for
17402 "U operator - (E x, E y)"
17404 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
17407 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
17408 init-only variables, but this path did not take into account that
17409 there might be also instance readonly variables. Correct this
17412 This fixes bug 32253
17414 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
17417 * driver.cs: Change the extension for modules to `netmodule'
17419 * cs-parser.jay: Improved slightly the location tracking for
17420 the debugger symbols.
17422 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
17423 modifiers that were specified instead of the hardcoded value
17424 (FamAndAssem). This was basically ignoring the static modifier,
17425 and others. Fixes 32429.
17427 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
17428 fixed a bug in the process (32476)
17430 * expression.cs (ArrayAccess.EmitAssign): Patch from
17431 hwang_rob@yahoo.ca that fixes bug 31834.3
17433 2002-10-18 Miguel de Icaza <miguel@ximian.com>
17435 * driver.cs: Make the module extension .netmodule.
17437 2002-10-16 Miguel de Icaza <miguel@ximian.com>
17439 * driver.cs: Report an error if the resource file is not found
17440 instead of crashing.
17442 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
17443 false, like Emit does.
17445 2002-10-16 Nick Drochak <ndrochak@gol.com>
17447 * typemanager.cs: Remove unused private member. Also reported mcs
17448 bug to report this as a warning like csc.
17450 2002-10-15 Martin Baulig <martin@gnome.org>
17452 * statement.cs (Statement.Emit): Made this a virtual method; emits
17453 the line number info and calls DoEmit().
17454 (Statement.DoEmit): New protected abstract method, formerly knows
17455 as Statement.Emit().
17457 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
17459 2002-10-11 Miguel de Icaza <miguel@ximian.com>
17461 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
17462 have fixed a remaining problem: not every AddXXXX was adding a
17463 fully qualified name.
17465 Now everyone registers a fully qualified name in the DeclSpace as
17466 being defined instead of the partial name.
17468 Downsides: we are slower than we need to be due to the excess
17469 copies and the names being registered this way.
17471 The reason for this is that we currently depend (on the corlib
17472 bootstrap for instance) that types are fully qualified, because
17473 we dump all the types in the namespace, and we should really have
17474 types inserted into the proper namespace, so we can only store the
17475 basenames in the defined_names array.
17477 2002-10-10 Martin Baulig <martin@gnome.org>
17479 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
17480 from bug #31834, see the bug report for a testcase which is
17483 2002-10-10 Martin Baulig <martin@gnome.org>
17485 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
17486 flow analysis code for this.
17488 * statement.cs (Do, While, For): Tell the flow analysis code about
17490 (FlowBranching.UsageVector): Added support for infinite loops.
17491 (Block.Resolve): Moved the dead code elimination here and use flow
17494 2002-10-09 Miguel de Icaza <miguel@ximian.com>
17496 * class.cs (Field.Define): Catch cycles on struct type
17499 * typemanager.cs (IsUnmanagedtype): Do not recursively check
17500 fields if the fields are static. We only need to check instance
17503 * expression.cs (As.DoResolve): Test for reference type.
17505 * statement.cs (Using.ResolveExpression): Use
17506 ConvertImplicitRequired, not ConvertImplicit which reports an
17508 (Using.ResolveLocalVariableDecls): ditto.
17510 * expression.cs (Binary.ResolveOperator): Report errors in a few
17511 places where we had to.
17513 * typemanager.cs (IsUnmanagedtype): Finish implementation.
17515 2002-10-08 Miguel de Icaza <miguel@ximian.com>
17517 * expression.cs: Use StoreFromPtr instead of extracting the type
17518 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
17520 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
17521 an enumeration value to a System.Enum, but System.Enum is not a
17522 value type, but an class type, so we need to box.
17524 (Expression.ConvertExplicit): One codepath could return
17525 errors but not flag them. Fix this. Fixes #31853
17527 * parameter.cs (Resolve): Do not allow void as a parameter type.
17529 2002-10-06 Martin Baulig <martin@gnome.org>
17531 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
17532 if it's a class type and not a struct. Fixes #31815.
17534 2002-10-06 Martin Baulig <martin@gnome.org>
17536 * statement.cs: Reworked the flow analysis code a bit to make it
17537 usable for dead code elimination.
17539 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17541 * cs-parser.jay: allow empty source files. Fixes bug #31781.
17543 2002-10-04 Miguel de Icaza <miguel@ximian.com>
17545 * expression.cs (ComposedCast.DoResolveType): A quick workaround
17546 to fix the test 165, will investigate deeper.
17548 2002-10-04 Martin Baulig <martin@gnome.org>
17550 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
17551 finally blocks actually work.
17552 (Try.Resolve): We don't need to create a sibling for `finally' if
17553 there is no finally block.
17555 2002-10-04 Martin Baulig <martin@gnome.org>
17557 * class.cs (Constructor.Define): The default accessibility for a
17558 non-default constructor is private, not public.
17560 2002-10-04 Miguel de Icaza <miguel@ximian.com>
17562 * class.cs (Constructor): Make AllowedModifiers public, add
17565 * cs-parser.jay: Perform the modifiers test here, as the
17566 constructor for the Constructor class usually receives a zero
17567 because of the way we create it (first we create, later we
17568 customize, and we were never checking the modifiers).
17570 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
17571 is a version of LookupTypeReflection that includes the type-name
17572 cache. This can be used as a fast path for functions that know
17573 the fully qualified name and are only calling into *.GetType() to
17574 obtain a composed type.
17576 This is also used by TypeManager.LookupType during its type
17579 (LookupType): We now also track the real type name, as sometimes
17580 we can get a quey for the real type name from things like
17581 ComposedCast. This fixes bug 31422.
17583 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
17584 complete type fullname, it does not have to go through the type
17585 resolution system to obtain the composed version of the type (for
17586 obtaining arrays or pointers).
17588 (Conditional.Emit): Use the EmitBoolExpression to
17589 generate nicer code, as requested by Paolo.
17591 (ArrayCreation.CheckIndices): Use the patch from
17592 hwang_rob@yahoo.ca to validate the array initializers.
17594 2002-10-03 Miguel de Icaza <miguel@ximian.com>
17596 * class.cs (ConstructorInitializer.Emit): simplify code by using
17597 Invocation.EmitCall, and at the same time, fix the bugs in calling
17598 parent constructors that took variable arguments.
17600 * ecore.cs (Expression.ConvertNumericExplicit,
17601 Expression.ImplicitNumericConversion): Remove the code that
17602 manually wrapped decimal (InternalTypeConstructor call is now gone
17605 * expression.cs (Cast.TryReduce): Also handle decimal types when
17606 trying to perform a constant fold on the type.
17608 * typemanager.cs (IsUnmanagedtype): Partially implemented.
17610 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
17611 that only turned off an error report, and did nothing else.
17613 2002-10-02 Miguel de Icaza <miguel@ximian.com>
17615 * driver.cs: Handle and ignore /fullpaths
17617 2002-10-01 Miguel de Icaza <miguel@ximian.com>
17619 * expression.cs (Binary.ResolveOperator): Catch the case where
17620 DoNumericPromotions returns true,
17622 (Binary.DoNumericPromotions): Simplify the code, and the tests.
17624 2002-09-27 Miguel de Icaza <miguel@ximian.com>
17626 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
17629 2002-09-26 Miguel de Icaza <miguel@ximian.com>
17631 * ecore.cs (ConvertNumericExplicit): It is not enough that the
17632 conversion exists, but it is also required that the conversion be
17633 performed. This manifested in "(Type64Enum) 2".
17635 * class.cs (TypeManager.AddMethod): The fix is not to change
17636 AddEnum, because that one was using a fully qualified name (every
17637 DeclSpace derivative does), but to change the AddMethod routine
17638 that was using an un-namespaced name. This now correctly reports
17639 the duplicated name.
17641 Revert patch until I can properly fix it. The issue
17642 is that we have a shared Type space across all namespaces
17643 currently, which is wrong.
17645 Options include making the Namespace a DeclSpace, and merge
17646 current_namespace/current_container in the parser.
17648 2002-09-25 Miguel de Icaza <miguel@ximian.com>
17650 * cs-parser.jay: Improve error reporting when we get a different
17651 kind of expression in local_variable_type and
17652 local_variable_pointer_type.
17654 Propagate this to avoid missleading errors being reported.
17656 * ecore.cs (ImplicitReferenceConversion): treat
17657 TypeManager.value_type as a target just like object_type. As
17662 Is valid, and needs to result in the int 1 being boxed before it
17663 is assigned to the value type v.
17665 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
17666 to validate the enumeration name.
17668 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
17669 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
17670 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
17672 * ecore.cs (TryImplicitIntConversion): When doing an
17673 implicit-enumeration-conversion, check if the type is 64-bits and
17674 perform a conversion before passing to EnumConstant.
17676 2002-09-23 Miguel de Icaza <miguel@ximian.com>
17678 * decl.cs (Error_AmbiguousTypeReference); New routine used to
17679 report ambiguous type references. Unlike the MS version, we
17680 report what the ambiguity is. Innovation at work ;-)
17682 (DeclSpace.FindType): Require a location argument to
17683 display when we display an ambiguous error.
17685 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
17687 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
17689 * expression.cs (EmitDynamicInitializers): Apply patch from
17690 hwang_rob@yahoo.ca that fixes the order in which we emit our
17693 2002-09-21 Martin Baulig <martin@gnome.org>
17695 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
17696 delegate takes no arguments.
17698 2002-09-20 Miguel de Icaza <miguel@ximian.com>
17700 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
17703 * expression.cs: Extract the underlying type.
17705 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
17707 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
17709 2002-09-19 Miguel de Icaza <miguel@ximian.com>
17711 * class.cs (TypeContainer.DefineType): We can not use the nice
17712 PackingSize with the size set to 1 DefineType method, because it
17713 will not allow us to define the interfaces that the struct
17716 This completes the fixing of bug 27287
17718 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
17719 means also structs. This fixes part of the problem.
17720 (Expresion.ImplicitReferenceConversionExists): ditto.
17722 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
17723 error if there were no errors reported during the type lookup
17724 process, to avoid duplicates or redundant errors. Without this
17725 you would get an ambiguous errors plus a type not found. We have
17726 beaten the user enough with the first error.
17728 (DeclSparce.FindType): Emit a warning if we have an ambiguous
17731 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
17732 during the resolution process, stop the lookup, this avoids
17733 repeated error reports (same error twice).
17735 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
17737 * typemanager.cs (LookupType): Redo the type lookup code to match
17738 the needs of System.Reflection.
17740 The issue is that System.Reflection requires references to nested
17741 types to begin with a "+" sign instead of a dot. So toplevel
17742 types look like: "NameSpace.TopLevelClass", and nested ones look
17743 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
17746 2002-09-19 Martin Baulig <martin@gnome.org>
17748 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
17749 says that a method always returns or always throws an exception,
17750 don't report the CS0161.
17752 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
17753 set `Returns = new_returns'.
17755 2002-09-19 Martin Baulig <martin@gnome.org>
17757 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
17758 to an enum constant, check for a CS0176.
17760 2002-09-18 Miguel de Icaza <miguel@ximian.com>
17762 * class.cs (TypeContainer.CheckPairedOperators): Now we check
17763 for operators that must be in pairs and report errors.
17765 * ecore.cs (SimpleName.DoResolveType): During the initial type
17766 resolution process, when we define types recursively, we must
17767 check first for types in our current scope before we perform
17768 lookups in the enclosing scopes.
17770 * expression.cs (MakeByteBlob): Handle Decimal blobs.
17772 (Invocation.VerifyArgumentsCompat): Call
17773 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
17774 I thought we were supposed to always call this, but there are a
17775 few places in the code where we dont do it.
17777 2002-09-17 Miguel de Icaza <miguel@ximian.com>
17779 * driver.cs: Add support in -linkres and -resource to specify the
17780 name of the identifier.
17782 2002-09-16 Miguel de Icaza <miguel@ximian.com>
17784 * ecore.cs (StandardConversionExists): Sync with the conversion
17785 code: allow anything-* to void* conversions.
17787 (FindMostSpecificSource): Use an Expression argument
17788 instead of a Type, because we might be handed over a Literal which
17789 gets a few more implicit conversions that plain types do not. So
17790 this information was being lost.
17792 Also, we drop the temporary type-holder expression when not
17795 2002-09-17 Martin Baulig <martin@gnome.org>
17797 * class.cs (PropertyBase.CheckBase): Don't check the base class if
17798 this is an explicit interface implementation.
17800 2002-09-17 Martin Baulig <martin@gnome.org>
17802 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
17803 different `IndexerName' attributes.
17805 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
17806 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
17807 virtual CommonResolve().
17809 2002-09-16 Miguel de Icaza <miguel@ximian.com>
17811 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
17812 and convert that to the UnderlyingType.
17814 * statement.cs (Foreach.Resolve): Indexers are just like variables
17815 or PropertyAccesses.
17817 * cs-tokenizer.cs (consume_string): Track line numbers and columns
17818 inside quoted strings, we were not doing this before.
17820 2002-09-16 Martin Baulig <martin@gnome.org>
17822 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
17823 resolve it. This is needed for the definite assignment check of the
17824 instance expression, fixes bug #29846.
17825 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
17827 2002-09-16 Nick Drochak <ndrochak@gol.com>
17829 * parameter.cs: Fix compile error. Cannot reference static member
17830 from an instance object. Is this an mcs bug?
17832 2002-09-14 Martin Baulig <martin@gnome.org>
17834 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
17835 multiple times. Fixes bug #30295, added test-166.cs.
17837 2002-09-14 Martin Baulig <martin@gnome.org>
17839 * statement.cs (Block.Emit): Don't emit unreachable code.
17840 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
17841 `break' statements.
17842 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
17844 2002-09-14 Martin Baulig <martin@gnome.org>
17846 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
17849 2002-09-14 Martin Baulig <martin@gnome.org>
17851 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
17852 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
17853 be false on the ms runtime.
17855 2002-09-13 Martin Baulig <martin@gnome.org>
17857 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
17858 the CS0038 error message.
17860 2002-09-12 Miguel de Icaza <miguel@ximian.com>
17862 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
17863 constant inside, return it.
17865 2002-09-12 Martin Baulig <martin@gnome.org>
17867 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
17868 implicit conversion can be done between enum types.
17870 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
17871 check whether an implicit conversion to the current enum's UnderlyingType
17872 exists and report an error if not.
17874 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
17875 without debugging support.
17877 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
17878 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
17880 2002-09-12 Martin Baulig <martin@gnome.org>
17882 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
17884 * ecore.cs (IMemberExpr.DeclaringType): New property.
17885 (SimpleName.SimpleNameResolve): Check whether we're accessing a
17886 nonstatic member of an outer type (CS0038).
17888 2002-09-11 Miguel de Icaza <miguel@ximian.com>
17890 * driver.cs: Activate the using-error detector at warning level
17891 4 (at least for MS-compatible APIs).
17893 * namespace.cs (VerifyUsing): Small buglett fix.
17895 * pending.cs (PendingImplementation): pass the container pointer.
17897 * interface.cs (GetMethods): Allow for recursive definition. Long
17898 term, I would like to move every type to support recursive
17899 definitions, not the current ordering mechanism that we have right
17902 The situation is this: Attributes are handled before interfaces,
17903 so we can apply attributes to interfaces. But some attributes
17904 implement interfaces, we will now handle the simple cases
17905 (recursive definitions will just get an error).
17907 * parameter.cs: Only invalidate types at the end if we fail to
17910 2002-09-09 Martin Baulig <martin@gnome.org>
17912 * ecore.cs (PropertyExpr.Emit): Also check for
17913 TypeManager.system_int_array_get_length so this'll also work when
17914 compiling corlib. Fixes #30003.
17916 2002-09-09 Martin Baulig <martin@gnome.org>
17918 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
17919 and throw an exception if we can't get the type's size. Fixed #30040,
17922 2002-09-09 Martin Baulig <martin@gnome.org>
17924 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
17926 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
17927 context. Fixes bug #30027.
17929 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
17930 virtual functions. Fixes bug #30043, added test-164.cs.
17932 2002-09-08 Ravi Pratap <ravi@ximian.com>
17934 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
17936 2002-09-08 Nick Drochak <ndrochak@gol.com>
17938 * driver.cs: Use an object to get the windows codepage since it's not a
17941 2002-09-08 Miguel de Icaza <miguel@ximian.com>
17943 * statement.cs (For.Emit): for infinite loops (test == null)
17944 return whether there is a break inside, not always "true".
17946 * namespace.cs (UsingEntry): New struct to hold the name of the
17947 using definition, the location where it is defined, and whether it
17948 has been used in a successful type lookup.
17950 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
17955 2002-09-06 Ravi Pratap <ravi@ximian.com>
17957 * attribute.cs : Fix incorrect code which relied on catching
17958 a NullReferenceException to detect a null being passed in
17959 where an object was expected.
17961 2002-09-06 Miguel de Icaza <miguel@ximian.com>
17963 * statement.cs (Try): flag the catch variable as assigned
17965 * expression.cs (Cast): Simplified by using ResolveType instead of
17966 manually resolving.
17968 * statement.cs (Catch): Fix bug by using ResolveType.
17970 2002-09-06 Ravi Pratap <ravi@ximian.com>
17972 * expression.cs (BetterConversion): Special case for when we have
17973 a NullLiteral as the argument and we have to choose between string
17974 and object types - we choose string the way csc does.
17976 * attribute.cs (Attribute.Resolve): Catch the
17977 NullReferenceException and report error #182 since the Mono
17978 runtime no more has the bug and having this exception raised means
17979 we tried to select a constructor which takes an object and is
17982 2002-09-05 Ravi Pratap <ravi@ximian.com>
17984 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
17985 message (1502, 1503) when we can't locate a method after overload
17986 resolution. This is much more informative and closes the bug
17989 * interface.cs (PopulateMethod): Return if there are no argument
17990 types. Fixes a NullReferenceException bug.
17992 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
17993 expressions too. Previously we were checking only in one place for
17994 positional arguments leaving out named arguments.
17996 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
17997 type to the enum type is not allowed. Remove code corresponding to
18000 (ConvertNumericExplicit): Allow explicit conversions from
18001 the underlying type to enum type. This precisely follows the spec
18002 and closes a bug filed by Gonzalo.
18004 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18007 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
18009 2002-09-03 Miguel de Icaza <miguel@ximian.com>
18011 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
18012 it was important that we stored the right value after the
18013 reduction in `converted'.
18015 2002-09-04 Martin Baulig <martin@gnome.org>
18017 * location.cs (Location.SymbolDocument): Use full pathnames for the
18020 2002-08-30 Miguel de Icaza <miguel@ximian.com>
18022 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
18023 of the expression resolve mechanism, because that will catch the
18024 SimpleName error failures.
18026 (Conditional): If we can not resolve the
18027 expression, return, do not crash.
18029 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18032 (location): display token name instead of its number.
18034 2002-08-28 Martin Baulig <martin@gnome.org>
18036 * expression.cs (Binary.ResolveOperator): Don't silently return
18037 but return an error if an operator cannot be applied between two
18040 2002-08-28 Martin Baulig <martin@gnome.org>
18042 * class.cs (Constructor.Define): Set the permission attributes
18043 correctly instead of making all constructors public.
18045 2002-08-28 Martin Baulig <martin@gnome.org>
18047 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
18048 for private members before reporting a CS0103; if we find anything,
18051 2002-08-28 Martin Baulig <martin@gnome.org>
18053 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
18054 to check whether `closure_start_type == closure_invocation_type',
18055 we also need to check whether `m.DeclaringType == closure_invocation_type'
18056 before bypassing the permission checks. We might be accessing
18057 protected/private members from the base class.
18058 (TypeManager.RealMemberLookup): Only set private_ok if private
18059 members were requested via BindingFlags.NonPublic.
18061 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
18063 * expression.cs (MemberAccess.ResolveMemberAccess): Set
18064 MethodGroupExpr.IsExplicitImpl if appropriate.
18065 (Invocation.DoResolve): Don't report the CS0120 for explicit
18066 interface implementations.
18068 2002-08-27 Martin Baulig <martin@gnome.org>
18070 * expression.cs (Invocation.DoResolve): If this is a static
18071 method and we don't have an InstanceExpression, we must report
18074 2002-08-25 Martin Baulig <martin@gnome.org>
18076 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
18077 `==' between a valuetype and an object.
18079 2002-08-25 Miguel de Icaza <miguel@ximian.com>
18081 * ecore.cs (TypeExpr): Provide a ToString method.
18083 2002-08-24 Martin Baulig <martin@gnome.org>
18085 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
18086 now called proggie.dbg and it's a binary file.
18088 2002-08-23 Martin Baulig <martin@gnome.org>
18090 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
18092 2002-08-23 Martin Baulig <martin@gnome.org>
18094 * struct.cs (MyStructInfo.ctor): Make this work with empty
18095 structs; it's not allowed to use foreach() on null.
18097 2002-08-23 Martin Baulig <martin@gnome.org>
18099 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
18100 writer the full pathname of the generated assembly.
18102 2002-08-23 Martin Baulig <martin@gnome.org>
18104 * statements.cs (FlowBranching.UsageVector.MergeChildren):
18105 A `finally' block never returns or breaks; improved handling of
18108 2002-08-23 Martin Baulig <martin@gnome.org>
18110 * statement.cs (Throw.Resolve): Allow `throw null'.
18112 2002-08-23 Martin Baulig <martin@gnome.org>
18114 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
18115 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
18116 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
18117 MemberLookup would return a wrong event if this is an explicit
18118 interface implementation and the class has an event with the same
18121 2002-08-23 Martin Baulig <martin@gnome.org>
18123 * statement.cs (Block.AddChildVariableNames): New public method.
18124 (Block.AddChildVariableName): Likewise.
18125 (Block.IsVariableNameUsedInChildBlock): Likewise.
18126 (Block.AddVariable): Check whether a variable name has already
18127 been used in a child block.
18129 * cs-parser.jay (declare_local_variables): Mark all variable names
18130 from the current block as being used in a child block in the
18133 2002-08-23 Martin Baulig <martin@gnome.org>
18135 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
18136 find the symbol writer.
18138 * driver.cs: csc also allows the arguments to /define being
18139 separated by commas, not only by semicolons.
18141 2002-08-23 Martin Baulig <martin@gnome.org>
18143 * interface.cs (Interface.GetMembers): Added static check for events.
18145 2002-08-15 Martin Baulig <martin@gnome.org>
18147 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
18148 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
18150 * ecore.cs (Expression.MemberLookup): Added documentation and explained
18151 why the MethodData.EmitDestructor() change was necessary.
18153 2002-08-20 Martin Baulig <martin@gnome.org>
18155 * class.cs (TypeContainer.FindMembers): Added static check for events.
18157 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
18159 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
18160 use Type.GetEvents(), not Type.FindMembers().
18162 2002-08-20 Martin Baulig <martin@gnome.org>
18164 * decl.cs (MemberCache): Added a special method cache which will
18165 be used for method-only searched. This ensures that a method
18166 search will return a MethodInfo with the correct ReflectedType for
18169 2002-08-20 Martin Baulig <martin@gnome.org>
18171 * decl.cs (DeclSpace.FindMembers): Made this public.
18173 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18175 * delegate.cs: fixed build on windows.
18176 [FIXME: Filed as bug #29150: MCS must report these errors.]
18178 2002-08-19 Ravi Pratap <ravi@ximian.com>
18180 * ecore.cs (StandardConversionExists): Return a false
18181 if we are trying to convert the void type to anything else
18182 since that is not allowed.
18184 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
18185 we flag error 70 in the event an event is trying to be accessed
18186 directly from outside the declaring type.
18188 2002-08-20 Martin Baulig <martin@gnome.org>
18190 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
18191 MemberCache from typemanager.cs to decl.cs.
18193 2002-08-19 Martin Baulig <martin@gnome.org>
18195 * class.cs (TypeContainer): Implement IMemberContainer.
18196 (TypeContainer.DefineMembers): Create the MemberCache.
18197 (TypeContainer.FindMembers): Do better BindingFlags checking; only
18198 return public members if BindingFlags.Public was given, check
18199 whether members are static.
18201 2002-08-16 Martin Baulig <martin@gnome.org>
18203 * decl.cs (DeclSpace.Define): Splitted this in Define and
18204 DefineMembers. DefineMembers is called first and initializes the
18207 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
18208 DefineMembers() on all our DeclSpaces.
18210 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
18211 but call DefineMembers() on all nested interfaces. We call their
18212 Define() in our new Define() function.
18214 * interface.cs (Interface): Implement IMemberContainer.
18215 (Interface.Define): Moved all code except the attribute stuf to
18217 (Interface.DefineMembers): Initialize the member cache.
18219 * typemanager.cs (IMemberFinder): Removed this interface, we don't
18220 need this anymore since we can use MemberCache.FindMembers directly.
18222 2002-08-19 Martin Baulig <martin@gnome.org>
18224 * typemanager.cs (MemberCache): When creating the cache for an
18225 interface type, add all inherited members.
18226 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
18227 to `out bool used_cache' and documented it.
18228 (TypeManager.MemberLookup): If we already used the cache in the first
18229 iteration, we don't need to do the interfaces check.
18231 2002-08-19 Martin Baulig <martin@gnome.org>
18233 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
18234 here from IMemberFinder and don't implement this interface anymore.
18235 (DeclSpace.MemberCache): Moved here from IMemberFinder.
18237 * typemanager.cs (IMemberFinder): This interface is now only used by
18238 classes which actually support the member cache.
18239 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
18240 since we only put DeclSpaces into this Hashtable.
18241 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
18242 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
18244 2002-08-16 Martin Baulig <martin@gnome.org>
18246 * typemanager.cs (ICachingMemberFinder): Removed.
18247 (IMemberFinder.MemberCache): New property.
18248 (TypeManager.FindMembers): Merged this with RealFindMembers().
18249 This function will never be called from TypeManager.MemberLookup()
18250 so we can't use the cache here, just the IMemberFinder.
18251 (TypeManager.MemberLookup_FindMembers): Check whether the
18252 IMemberFinder has a MemberCache and call the cache's FindMembers
18254 (MemberCache): Rewrote larger parts of this yet another time and
18255 cleaned it up a bit.
18257 2002-08-15 Miguel de Icaza <miguel@ximian.com>
18259 * driver.cs (LoadArgs): Support quoting.
18261 (Usage): Show the CSC-like command line arguments.
18263 Improved a few error messages.
18265 2002-08-15 Martin Baulig <martin@gnome.org>
18267 * typemanager.cs (IMemberContainer.Type): New property.
18268 (IMemberContainer.IsInterface): New property.
18270 The following changes are conditional to BROKEN_RUNTIME, which is
18271 defined at the top of the file.
18273 * typemanager.cs (MemberCache.MemberCache): Don't add the base
18274 class'es members, but add all members from TypeHandle.ObjectType
18275 if we're an interface.
18276 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
18277 is the current type.
18278 (MemberCache.CacheEntry.Container): Removed this field.
18279 (TypeHandle.GetMembers): Include inherited members.
18281 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18283 * typemanager.cs: fixed compilation and added a comment on a field that
18286 2002-08-15 Martin Baulig <martin@gnome.org>
18288 * class.cs (ConstructorInitializer.Resolve): In the
18289 Expression.MemberLookup call, use the queried_type as
18292 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
18293 declared' attribute, it's always true.
18294 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
18295 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
18296 temporary wrapper for FindMembers which tells MemberLookup whether
18297 members from the base classes are included in the return value.
18298 This will go away soon.
18299 (TypeManager.MemberLookup): Use this temporary hack here; once the
18300 new MemberCache is completed, we don't need to do the DeclaredOnly
18301 looping here anymore since the MemberCache will take care of this.
18302 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
18303 (MemberCache): When creating the MemberCache for a class, get
18304 members from the current class and all its base classes.
18305 (MemberCache.CacheEntry.Container): New field. This is a
18306 temporary hack until the Mono runtime is fixed to distinguish
18307 between ReflectedType and DeclaringType. It allows us to use MCS
18308 with both the MS runtime and the unfixed Mono runtime without
18309 problems and without accecting performance.
18310 (MemberCache.SearchMembers): The DeclaredOnly looping from
18311 TypeManager.MemberLookup is now done here.
18313 2002-08-14 Martin Baulig <martin@gnome.org>
18315 * statement.cs (MyStructInfo.MyStructInfo): Don't call
18316 Type.GetFields on dynamic types but get the fields from the
18317 corresponding TypeContainer.
18318 (MyStructInfo.GetStructInfo): Added check for enum types.
18320 * typemanager.cs (MemberList.IsSynchronized): Implemented.
18321 (MemberList.SyncRoot): Implemented.
18322 (TypeManager.FilterWithClosure): No need to check permissions if
18323 closure_start_type == closure_invocation_type, don't crash if
18324 closure_invocation_type is null.
18326 2002-08-13 Martin Baulig <martin@gnome.org>
18328 Rewrote TypeContainer.FindMembers to use a member cache. This
18329 gives us a speed increase of about 35% for the self-hosting MCS
18330 build and of about 15-20% for the class libs (both on GNU/Linux).
18332 * report.cs (Timer): New class to get enhanced profiling. This
18333 whole class is "TIMER" conditional since it remarkably slows down
18336 * class.cs (MemberList): New class. This is an IList wrapper
18337 which we're now using instead of passing MemberInfo[]'s around to
18338 avoid copying this array unnecessarily.
18339 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
18340 (ICachingMemberFinder, IMemberContainer): New interface.
18341 (TypeManager.FilterWithClosure): If `criteria' is null, the name
18342 has already been checked, otherwise use it for the name comparision.
18343 (TypeManager.FindMembers): Renamed to RealMemberFinder and
18344 provided wrapper which tries to use ICachingMemberFinder.FindMembers
18345 if possible. Returns a MemberList, not a MemberInfo [].
18346 (TypeHandle): New class, implements IMemberContainer. We create
18347 one instance of this class per type, it contains a MemberCache
18348 which is used to do the member lookups.
18349 (MemberCache): New class. Each instance of this class contains
18350 all members of a type and a name-based hash table.
18351 (MemberCache.FindMembers): This is our new member lookup
18352 function. First, it looks up all members of the requested name in
18353 the hash table. Then, it walks this list and sorts out all
18354 applicable members and returns them.
18356 2002-08-13 Martin Baulig <martin@gnome.org>
18358 In addition to a nice code cleanup, this gives us a performance
18359 increase of about 1.4% on GNU/Linux - not much, but it's already
18360 half a second for the self-hosting MCS compilation.
18362 * typemanager.cs (IMemberFinder): New interface. It is used by
18363 TypeManager.FindMembers to call FindMembers on a TypeContainer,
18364 Enum, Delegate or Interface.
18365 (TypeManager.finder_to_member_finder): New PtrHashtable.
18366 (TypeManager.finder_to_container): Removed.
18367 (TypeManager.finder_to_delegate): Removed.
18368 (TypeManager.finder_to_interface): Removed.
18369 (TypeManager.finder_to_enum): Removed.
18371 * interface.cs (Interface): Implement IMemberFinder.
18373 * delegate.cs (Delegate): Implement IMemberFinder.
18375 * enum.cs (Enum): Implement IMemberFinder.
18377 * class.cs (TypeContainer): Implement IMemberFinder.
18379 2002-08-12 Martin Baulig <martin@gnome.org>
18381 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
18383 2002-08-12 Martin Baulig <martin@gnome.org>
18385 * ecore.cs (ITypeExpression): New interface for expressions which
18387 (TypeExpression): Renamed to TypeLookupExpression.
18388 (Expression.DoResolve): If we're doing a types-only lookup, the
18389 expression must implement the ITypeExpression interface and we
18390 call DoResolveType() on it.
18391 (SimpleName): Implement the new ITypeExpression interface.
18392 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
18393 hack, the situation that we're only looking up types can't happen
18394 anymore when this method is called. Moved the type lookup code to
18395 DoResolveType() and call it.
18396 (SimpleName.DoResolveType): This ITypeExpression interface method
18397 is now doing the types-only lookup.
18398 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
18399 (ResolveFlags): Added MaskExprClass.
18401 * expression.cs (MemberAccess): Implement the ITypeExpression
18403 (MemberAccess.DoResolve): Added support for a types-only lookup
18404 when we're called via ITypeExpression.DoResolveType().
18405 (ComposedCast): Implement the ITypeExpression interface.
18407 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
18408 Expression.Resolve() with ResolveFlags.Type instead.
18410 2002-08-12 Martin Baulig <martin@gnome.org>
18412 * interface.cs (Interface.Define): Apply attributes.
18414 * attribute.cs (Attribute.ApplyAttributes): Added support for
18415 interface attributes.
18417 2002-08-11 Martin Baulig <martin@gnome.org>
18419 * statement.cs (Block.Emit): Only check the "this" variable if we
18420 do not always throw an exception.
18422 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
18423 whether the property has a set accessor.
18425 2002-08-11 Martin Baulig <martin@gnome.org>
18427 Added control flow analysis support for structs.
18429 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
18430 with control flow analysis turned off.
18431 (IVariable): New interface.
18432 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
18433 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
18434 (FieldExpr.DoResolve): Resolve the instance expression with flow
18435 analysis turned off and do the definite assignment check after the
18436 resolving when we know what the expression will resolve to.
18438 * expression.cs (LocalVariableReference, ParameterReference):
18439 Implement the new IVariable interface, only call the flow analysis
18440 code if ec.DoFlowAnalysis is true.
18441 (This): Added constructor which takes a Block argument. Implement
18442 the new IVariable interface.
18443 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
18444 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
18445 This does the definite assignment checks for struct members.
18447 * class.cs (Constructor.Emit): If this is a non-static `struct'
18448 constructor which doesn't have any initializer, call
18449 Block.AddThisVariable() to tell the flow analysis code that all
18450 struct elements must be initialized before control returns from
18453 * statement.cs (MyStructInfo): New public class.
18454 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
18455 argument to this indexer. If non-zero, check an individual struct
18456 member, not the whole struct.
18457 (FlowBranching.CheckOutParameters): Check struct members.
18458 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
18459 overloaded versions of these methods which take an additional
18460 `int field_idx' argument to check struct members.
18461 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
18462 overloaded versions of these methods which take an additional
18463 `string field_name' argument to check struct member.s
18464 (VariableInfo): Implement the IVariable interface.
18465 (VariableInfo.StructInfo): New public property. Returns the
18466 MyStructInfo instance of the variable if it's a struct or null.
18467 (Block.AddThisVariable): New public method. This is called from
18468 Constructor.Emit() for non-static `struct' constructor which do
18469 not have any initializer. It creates a special variable for the
18470 "this" instance variable which will be checked by the flow
18471 analysis code to ensure that all of the struct's fields are
18472 initialized before control returns from the constructor.
18473 (UsageVector): Added support for struct members. If a
18474 variable/parameter is a struct with N members, we reserve a slot
18475 in the usage vector for each member. A struct is considered fully
18476 initialized if either the struct itself (slot 0) or all its
18477 members are initialized.
18479 2002-08-08 Martin Baulig <martin@gnome.org>
18481 * driver.cs (Driver.MainDriver): Only report an error CS5001
18482 if there were no compilation errors.
18484 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
18485 `UnsafeContext' property to determine whether the parent is in
18486 unsafe context rather than checking the parent's ModFlags:
18487 classes nested in an unsafe class are unsafe as well.
18489 2002-08-08 Martin Baulig <martin@gnome.org>
18491 * statement.cs (UsageVector.MergeChildren): Distinguish between
18492 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
18493 we return. Added test17() and test18() to test-154.cs.
18495 2002-08-08 Martin Baulig <martin@gnome.org>
18497 * typemanager.cs (TypeManager.FilterWithClosure): If we have
18498 Family access, make sure the invoking type isn't a subclass of the
18499 queried type (that'd be a CS1540).
18501 * ecore.cs (Expression.MemberLookup): Added overloaded version of
18502 this method which takes an additional `Type invocation_type'.
18504 * expression.cs (BaseAccess.DoResolve): Use the base type as
18505 invocation and query type.
18506 (MemberAccess.DoResolve): If the lookup failed and we're about to
18507 report a CS0122, try a lookup with the ec.ContainerType - if this
18508 succeeds, we must report a CS1540.
18510 2002-08-08 Martin Baulig <martin@gnome.org>
18512 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
18513 (MethodGroupExpr): Implement the IMemberExpr interface.
18515 * expression (MemberAccess.ResolveMemberAccess): No need to have
18516 any special code for MethodGroupExprs anymore, they're now
18519 2002-08-08 Martin Baulig <martin@gnome.org>
18521 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
18522 Family, FamANDAssem and FamORAssem permissions.
18523 (TypeManager.IsSubclassOrNestedChildOf): New public method.
18525 2002-08-08 Martin Baulig <martin@gnome.org>
18527 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
18528 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
18531 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
18533 * driver.cs: implemented /resource option to embed managed resources.
18535 2002-08-07 Martin Baulig <martin@gnome.org>
18537 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
18538 (FieldBase.HasFieldInitializer): New public property.
18539 (FieldBase.GetInitializerExpression): New public method. Resolves and
18540 returns the field initializer and makes sure it is only resolved once.
18541 (TypeContainer.EmitFieldInitializers): Call
18542 FieldBase.GetInitializerExpression to get the initializer, this ensures
18543 that it isn't resolved multiple times.
18545 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
18546 the resolving process (SimpleName/MemberLookup) that we're currently
18547 emitting a field initializer (which must not access any instance members,
18548 this is an error CS0236).
18550 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
18551 argument, if the `IsFieldInitializer' flag is set, we must report and
18552 error CS0236 and not an error CS0120.
18554 2002-08-07 Martin Baulig <martin@gnome.org>
18556 * ecore.cs (IMemberExpr): New public interface.
18557 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
18558 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
18559 if the expression is an IMemberExpr.
18561 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
18562 to be null, implicitly default to `this' if we're non-static in
18563 this case. Simplified the code a lot by using the new IMemberExpr
18564 interface. Also fixed bug #28176 here.
18566 2002-08-06 Martin Baulig <martin@gnome.org>
18568 * cs-parser.jay (SimpleLookup): Removed. We need to create
18569 ParameterReferences during semantic analysis so that we can do a
18570 type-only search when resolving Cast, TypeOf and SizeOf.
18571 (block): Pass the `current_local_parameters' to the Block's
18574 * class.cs (ConstructorInitializer): Added `Parameters parameters'
18575 argument to the constructor.
18576 (ConstructorInitializer.Resolve): Create a temporary implicit
18577 block with the parameters.
18579 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
18580 references here if we aren't doing a type-only search.
18582 * statement.cs (Block): Added constructor which takes a
18583 `Parameters parameters' argument.
18584 (Block.Parameters): New public property.
18586 * support.cs (InternalParameters.Parameters): Renamed `parameters'
18587 to `Parameters' and made it public readonly.
18589 2002-08-06 Martin Baulig <martin@gnome.org>
18591 * ecore.cs (Expression.Warning): Made this public as well.
18593 * report.cs (Report.Debug): Print the contents of collections.
18595 2002-08-06 Martin Baulig <martin@gnome.org>
18597 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
18598 used to tell Resolve() which kinds of expressions it may return.
18599 (Expression.Resolve): Added overloaded version of this method which
18600 takes a `ResolveFlags flags' argument. This can be used to tell
18601 Resolve() which kinds of expressions it may return. Reports a
18603 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
18604 ResolveFlags.SimpleName.
18605 (Expression.Error118): Added overloaded version of this method which
18606 takes a `ResolveFlags flags' argument. It uses the flags to determine
18607 which kinds of expressions are allowed.
18609 * expression.cs (Argument.ResolveMethodGroup): New public method.
18610 Resolves an argument, but allows a MethodGroup to be returned.
18611 This is used when invoking a delegate.
18613 * TODO: Updated a bit.
18615 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18617 Fixed compilation with csc.
18619 * ecore.cs: Expression.Error made public. Is this correct? Should
18620 Warning be made public too?
18622 * expression.cs: use ea.Location instead of ea.loc.
18623 [FIXME: Filed as bug #28607: MCS must report these errors.]
18625 2002-08-06 Martin Baulig <martin@gnome.org>
18627 * ecore.cs (Expression.loc): Moved the location here instead of
18628 duplicating it in all derived classes.
18629 (Expression.Location): New public property.
18630 (Expression.Error, Expression.Warning): Made them non-static and
18631 removed the location argument.
18632 (Expression.Warning): Added overloaded version which takes an
18633 `int level' argument.
18634 (Expression.Error118): Make this non-static and removed the
18635 expression and location arguments.
18636 (TypeExpr): Added location argument to the constructor.
18638 * expression.cs (StaticCallExpr): Added location argument to
18640 (Indirection, PointerArithmetic): Likewise.
18641 (CheckedExpr, UnCheckedExpr): Likewise.
18642 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
18643 (StringPtr): Likewise.
18646 2002-08-05 Martin Baulig <martin@gnome.org>
18648 * expression.cs (BaseAccess.DoResolve): Actually report errors.
18650 * assign.cs (Assign.DoResolve): Check whether the source
18651 expression is a value or variable.
18653 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
18654 while resolving the corresponding blocks.
18656 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
18657 an error, don't silently return null.
18659 * statement.cs (Block.AddVariable): Do the error reporting here
18660 and distinguish between CS0128 and CS0136.
18661 (Block.DoResolve): Report all unused labels (warning CS0164).
18662 (LabeledStatement): Pass the location to the constructor.
18663 (LabeledStatement.HasBeenReferenced): New property.
18664 (LabeledStatement.Resolve): Set it to true here.
18666 * statement.cs (Return.Emit): Return success even after reporting
18667 a type mismatch error (CS0126 or CS0127), this is what csc does and
18668 it avoids confusing the users with any consecutive errors.
18670 2002-08-05 Martin Baulig <martin@gnome.org>
18672 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
18674 * const.cs (Const.LookupConstantValue): Catch circular definitions.
18676 * expression.cs (MemberAccess.DoResolve): Silently return if an
18677 error has already been reported.
18679 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
18680 error has already been reported.
18682 2002-08-05 Martin Baulig <martin@gnome.org>
18684 * statement.cs (UsageVector): Only initialize the `parameters'
18685 vector if we actually have any "out" parameters.
18687 2002-08-05 Martin Baulig <martin@gnome.org>
18689 * expression.cs (Binary.ResolveOperator): When combining delegates,
18690 they must have the same type.
18692 2002-08-05 Martin Baulig <martin@gnome.org>
18694 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
18695 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
18696 work with the ms runtime and we also don't need it: if we're a
18697 PropertyBuilder and not in the `indexer_arguments' hash, then we
18698 are a property and not an indexer.
18700 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
18701 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
18702 since the latter one doesn't work with the ms runtime.
18704 2002-08-03 Martin Baulig <martin@gnome.org>
18706 Fixed bugs #27998 and #22735.
18708 * class.cs (Method.IsOperator): New public field.
18709 (Method.CheckBase): Report CS0111 if there's already a method
18710 with the same parameters in the current class. Report CS0508 when
18711 attempting to change the return type of an inherited method.
18712 (MethodData.Emit): Report CS0179 if a method doesn't have a body
18713 and it's not marked abstract or extern.
18714 (PropertyBase): New abstract base class for Property and Indexer.
18715 (PropertyBase.CheckBase): Moved here from Property and made it work
18717 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
18718 the same so we can reuse it there.
18719 (Property, Indexer): Derive from PropertyBase.
18720 (MethodSignature.inheritable_property_signature_filter): New delegate
18721 to find properties and indexers.
18723 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
18724 argument and improved error reporting.
18726 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
18727 EmptyReadOnlyParameters and made it a property.
18729 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
18730 version of this method which takes a `PropertyInfo indexer'.
18731 (TypeManager.RegisterIndexer): New method.
18733 * class.cs: Added myself as author of this file :-)
18735 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18737 * class.cs: fixed compilation on windoze.
18739 2002-08-03 Martin Baulig <martin@gnome.org>
18741 * interface.cs (Interface.GetInterfaceBases): Check whether all
18742 base interfaces are at least as accessible than the current one.
18744 * class.cs (TypeContainer.GetClassBases): Check whether base types
18745 are at least as accessible than the current type.
18746 (TypeContainer.AsAccessible): Implemented and made non-static.
18747 (MemberBase.CheckParameters): Report errors if the accessibility
18750 * delegate.cs (Delegate.Delegate): The default visibility is
18751 internal for top-level types and private for nested types.
18752 (Delegate.Define): Report errors if the accessibility checks fail.
18754 * enum.cs (Enum.Enum): The default visibility is internal for
18755 top-level types and private for nested types.
18756 (Enum.DefineType): Compute the correct visibility.
18758 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
18759 function which takes a `bool is_toplevel' instead of a TypeContainer.
18761 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
18764 2002-08-02 Martin Baulig <martin@gnome.org>
18766 * expression.cs (LocalVariableReferenc): Added constructor which
18767 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
18768 (LocalVariableReference.IsReadOnly): New property.
18769 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
18770 variable is readonly, use our own readonly flag to do this; you can
18771 use the new constructor to get a writable reference to a read-only
18774 * cs-parser.jay (foreach_statement, using_statement): Get a writable
18775 reference to the local variable.
18777 2002-08-01 Miguel de Icaza <miguel@ximian.com>
18779 * rootcontext.cs (ResolveCore): Also include System.Exception
18781 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
18782 we reach an EmptyStatement.
18784 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
18787 * expression.cs (Binary.ResolveOperator): Check error result in
18790 use brtrue/brfalse directly and avoid compares to null.
18792 2002-08-02 Martin Baulig <martin@gnome.org>
18794 * class.cs (TypeContainer.Define): Define all nested interfaces here.
18795 Fixes bug #28407, added test-155.cs.
18797 2002-08-01 Martin Baulig <martin@gnome.org>
18799 * class.cs (Event.EmitDefaultMethod): Make this work with static
18800 events. Fixes #28311, added verify-3.cs.
18802 2002-08-01 Martin Baulig <martin@gnome.org>
18804 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
18805 `is_disposable' fields.
18806 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
18807 `hm.is_disposable' if we're using the collection pattern.
18808 (Foreach.EmitCollectionForeach): Use the correct type for the
18809 enumerator's local variable, only emit the try/finally block if
18810 necessary (fixes #27713).
18812 2002-08-01 Martin Baulig <martin@gnome.org>
18814 * ecore.cs (Expression.report118): Renamed to Error118 and made
18817 * statement.cs (Throw.Resolve): Check whether the expression is of
18818 the correct type (CS0118) and whether the type derives from
18819 System.Exception (CS0155).
18820 (Catch.Resolve): New method. Do the type lookup here and check
18821 whether it derives from System.Exception (CS0155).
18822 (Catch.CatchType, Catch.IsGeneral): New public properties.
18824 * typemanager.cs (TypeManager.exception_type): Added.
18826 2002-07-31 Miguel de Icaza <miguel@ximian.com>
18828 * driver.cs: Updated About function.
18830 2002-07-31 Martin Baulig <martin@gnome.org>
18832 Implemented Control Flow Analysis.
18834 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
18835 (EmitContext.CurrentBranching): Added.
18836 (EmitContext.StartFlowBranching): Added.
18837 (EmitContext.EndFlowBranching): Added.
18838 (EmitContext.KillFlowBranching): Added.
18839 (EmitContext.IsVariableAssigned): Added.
18840 (EmitContext.SetVariableAssigned): Added.
18841 (EmitContext.IsParameterAssigned): Added.
18842 (EmitContext.SetParameterAssigned): Added.
18843 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
18844 Added control flow analysis stuff here.
18846 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
18847 resolve the expression as lvalue.
18848 (LocalVariableReference.DoResolve): Check whether the variable has
18849 already been assigned.
18850 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
18851 the parameter as assigned here.
18852 (ParameterReference.DoResolve): Check whether the parameter has already
18854 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
18855 expression as lvalue.
18857 * statement.cs (FlowBranching): New class for the flow analysis code.
18858 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
18859 (LabeledStatement.IsDefined): New public property.
18860 (LabeledStatement.AddUsageVector): New public method to tell flow
18861 analyis that the label may be reached via a forward jump.
18862 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
18864 (VariableInfo.Number): New public field. This is used by flow analysis
18865 to number all locals of a block.
18866 (Block.CountVariables): New public property. This is the number of
18867 local variables in this block (including the locals from all parent
18869 (Block.EmitMeta): Number all the variables.
18871 * statement.cs: Added flow analysis support to all classes.
18873 2002-07-31 Martin Baulig <martin@gnome.org>
18875 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
18876 To get debugging messages, compile mcs with /define:MCS_DEBUG and
18877 then use this argument.
18879 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
18881 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
18882 use this to specify /define options.
18884 2002-07-29 Martin Baulig <martin@gnome.org>
18886 * statement.cs (Fixed): Moved all code that does variable lookups
18887 and resolvings from Emit to Resolve.
18889 * statement.cs (For): Moved all code that does variable lookups
18890 and resolvings from Emit to Resolve.
18892 * statement.cs (Using): Moved all code that does variable lookups
18893 and resolvings from Emit to Resolve.
18895 2002-07-29 Martin Baulig <martin@gnome.org>
18897 * attribute.cs (Attribute.Resolve): Explicitly catch a
18898 System.NullReferenceException when creating the
18899 CustromAttributeBuilder and report a different warning message.
18901 2002-07-29 Martin Baulig <martin@gnome.org>
18903 * support.cs (ParameterData.ParameterName): Added method to
18904 get the name of a parameter.
18906 * typemanager.cs (TypeManager.IsValueType): New public method.
18908 2002-07-29 Martin Baulig <martin@gnome.org>
18910 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
18911 is a flag which specifies that it's either ref or out.
18912 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
18913 the out parameter to `out Parameter.Modifier mod', also set the
18914 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
18916 * support.cs (InternalParameters.ParameterModifier): Distinguish
18917 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
18918 Parameter.Modifier.ISBYREF flag if it's either ref or out.
18920 * expression.cs (Argument.GetParameterModifier): Distinguish
18921 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
18922 Parameter.Modifier.ISBYREF flag if it's either ref or out.
18924 2002-07-29 Martin Baulig <martin@gnome.org>
18926 * expression.cs (ParameterReference.ParameterReference): Added
18927 `Location loc' argument to the constructor.
18929 * cs-parser.jay: Pass location to ParameterReference.
18931 2002-07-28 Miguel de Icaza <miguel@ximian.com>
18933 * statement.cs (Try): Initialize the location.
18935 * cs-parser.jay: pass location to Try.
18937 * expression.cs (Unary.Reduce): Change the prototype to return
18938 whether a constant fold could be performed or not. The result is
18939 returned in an out parameters. In the case of Indirection and
18940 AddressOf, we want to perform the full tests.
18942 2002-07-26 Miguel de Icaza <miguel@ximian.com>
18944 * statement.cs (Statement.Emit): Flag dead code.
18946 2002-07-27 Andrew Birkett <andy@nobugs.org>
18948 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
18950 2002-07-27 Martin Baulig <martin@gnome.org>
18952 * class.cs (MethodData.Define): Put back call to
18953 TypeManager.AddMethod(), accidentally commented this out.
18955 * report.cs (Debug): New public method to print debugging information,
18956 this is `[Conditional ("DEBUG")]'.
18958 2002-07-26 Martin Baulig <martin@gnome.org>
18960 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
18961 (switch_statement): Push the current_block to the switch_stack and
18962 pop it again when we're done with the switch.
18963 (switch_section): The new block is a child of the current_block.
18964 Fixes bug #24007, added test-152.cs.
18966 2002-07-27 Martin Baulig <martin@gnome.org>
18968 * expression.cs (Invocation.EmitArguments): When calling a varargs
18969 function with only its fixed arguments, we need to pass an empty
18972 2002-07-27 Martin Baulig <martin@gnome.org>
18974 Mono 0.13 has been released.
18976 2002-07-25 Miguel de Icaza <miguel@ximian.com>
18978 * driver.cs: Rename --resource to --linkres, because that is what
18979 we do currently, we dont support --resource yet.
18981 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
18983 2002-07-25 Martin Baulig <martin@gnome.org>
18985 * class.cs (MethodData): New public class. This is a `method builder'
18986 class for a method or one accessor of a Property/Indexer/Event.
18987 (MethodData.GetMethodFlags): Moved here from MemberBase.
18988 (MethodData.ApplyAttributes): Likewise.
18989 (MethodData.ApplyObsoleteAttribute): Likewise.
18990 (MethodData.ApplyConditionalAttribute): Likewise.
18991 (MethodData.ApplyDllImportAttribute): Likewise.
18992 (MethodData.CheckAbstractAndExternal): Likewise.
18993 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
18994 (MethodData.Emit): Formerly known as Method.Emit().
18995 (MemberBase): Moved everything which was specific to a single
18996 accessor/method to MethodData.
18997 (Method): Create a new MethodData and call Define() and Emit() on it.
18998 (Property, Indexer, Event): Create a new MethodData objects for each
18999 accessor and call Define() and Emit() on them.
19001 2002-07-25 Martin Baulig <martin@gnome.org>
19003 Made MethodCore derive from MemberBase to reuse the code from there.
19004 MemberBase now also checks for attributes.
19006 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
19007 (MemberBase.GetMethodFlags): Moved here from class Method and marked
19009 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
19010 `CallingConventions cc' and `Attributes opt_attrs' arguments.
19011 (MemberBase.ApplyAttributes): New virtual method; applies the
19012 attributes to a method or accessor.
19013 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
19014 (MemberBase.ApplyConditionalAttribute): Likewise.
19015 (MemberBase.ApplyDllImportAttribute): Likewise.
19016 (MemberBase.CheckAbstractAndExternal): Likewise.
19017 (MethodCore.ParameterTypes): This is now a property instead of a
19018 method, it's initialized from DoDefineParameters().
19019 (MethodCore.ParameterInfo): Removed the set accessor.
19020 (MethodCore.DoDefineParameters): New protected virtual method to
19021 initialize ParameterTypes and ParameterInfo.
19022 (Method.GetReturnType): We can now simply return the MemberType.
19023 (Method.GetMethodFlags): Override the MemberBase version and add
19024 the conditional flags.
19025 (Method.CheckBase): Moved some code from Define() here, call
19026 DoDefineParameters() here.
19027 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
19028 here to avoid some larger code duplication.
19029 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
19030 ensure that abstract and external accessors don't declare a body.
19032 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
19033 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
19034 lookup in the attribute's parent classes, so we need to abort as soon
19035 as we found the first match.
19036 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
19037 the attribute has no arguments.
19039 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
19042 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19044 * cs-parser.jay: reverted previous patch.
19046 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19048 * cs-parser.jay: fixed bug #22119.
19050 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19052 * attribute.cs: fixed compilation. The error was:
19053 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
19054 be assigned to before control leaves the current method."
19055 [FIXME: Filed as bug #28186: MCS must report this error.]
19057 2002-07-25 Martin Baulig <martin@gnome.org>
19059 * attribute.cs (Attribute.Conditional_GetConditionName): New static
19060 method to pull the condition name ouf of a Conditional attribute.
19061 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
19062 the obsolete message and error flag out of an Obsolete attribute.
19064 * class.cs (Method.GetMethodFlags): New public method to get the
19065 TypeManager.MethodFlags for this method.
19066 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
19068 (Method.Define): Get and apply the Obsolete and Conditional attributes;
19069 if we're overriding a virtual function, set the new private variable
19070 `parent_method'; call the new TypeManager.AddMethod().
19072 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
19073 the MethodBuilder and the Method in a PtrHashtable.
19074 (TypeManager.builder_to_method): Added for this purpose.
19075 (TypeManager.MethodFlags): Added IsObsoleteError.
19076 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
19077 Obsolete and Conditional arguments in MethodBuilders. If we discover
19078 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
19079 the message from the attribute.
19081 2002-07-24 Martin Baulig <martin@gnome.org>
19083 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
19084 preprocessor directives, ensure that the argument to #define/#undef is
19085 exactly one identifier and that it's actually an identifier.
19087 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
19090 2002-07-24 Martin Baulig <martin@gnome.org>
19092 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
19093 initialize it to TypeManager.object_type in the constructor.
19094 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
19095 of the `hm.get_current' method if we're using the collection pattern.
19096 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
19097 for the explicit conversion to make it work when we're using the collection
19098 pattern and the `Current' property has a different return type than `object'.
19101 2002-07-24 Martin Baulig <martin@gnome.org>
19103 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
19104 does not match, but don't report any errors. This method is called in
19105 order for all methods in a MethodGroupExpr until a matching method is
19106 found, so we don't want to bail out if the first method doesn't match.
19107 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
19108 matches, report the 123. Fixes #28070.
19110 2002-07-24 Martin Baulig <martin@gnome.org>
19112 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
19113 TypeManager.TypeToCoreType() to the top of the method so the
19114 following equality checks will work. Fixes #28107.
19116 2002-07-24 Martin Baulig <martin@gnome.org>
19118 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
19119 operand is of type uint, and the other operand is of type sbyte,
19120 short or int, the operands are converted to type long." -
19121 Actually do what this comment already told us. Fixes bug #28106,
19124 2002-07-24 Martin Baulig <martin@gnome.org>
19126 * class.cs (MethodBase): New abstract class. This is now a base
19127 class for Property, Indexer and Event to avoid some code duplication
19128 in their Define() and DefineMethods() methods.
19129 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
19130 generic methods for Define() and DefineMethods().
19131 (FieldBase): Derive from MemberBase, not MemberCore.
19132 (Property): Derive from MemberBase, not MemberCore.
19133 (Property.DefineMethod): Moved all the code from this method to the
19134 new MethodBase.DefineAccessor(), just call it with appropriate
19136 (Property.Define): Call the new Property.DoDefine(), this does some
19137 sanity checks and we don't need to duplicate the code everywhere.
19138 (Event): Derive from MemberBase, not MemberCore.
19139 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
19140 accessors, this will also make them work with interface events.
19141 (Indexer): Derive from MemberBase, not MemberCore.
19142 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
19143 (Indexer.Define): Use the new MethodBase functions.
19145 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
19146 argument to the constructor.
19147 (Interface.FindMembers): Added support for interface events.
19148 (Interface.PopluateEvent): Implemented.
19150 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
19152 2002-07-22 Miguel de Icaza <miguel@ximian.com>
19154 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
19155 but this is required to check for a method name being the same as
19156 the containing class.
19160 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19162 * interface.cs: initialize variable.
19164 2002-07-23 Martin Baulig <martin@gnome.org>
19166 Implemented the IndexerName attribute in interfaces.
19168 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
19169 name if this is an explicit interface implementation.
19170 (Indexer.InterfaceIndexerName): New public variable. If we're
19171 implementing an interface indexer, this is the IndexerName in that
19172 interface. Otherwise, it's the IndexerName.
19173 (Indexer.DefineMethod): If we're implementing interface indexer,
19174 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
19175 and Pending.ImplementIndexer methods.
19176 (Indexer.Define): Also define the PropertyBuilder if we're
19177 implementing an interface indexer and this is neither an explicit
19178 interface implementation nor do the IndexerName match the one in
19181 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
19182 If a method is defined here, then we always need to create a proxy
19183 for it. This is used when implementing interface indexers.
19184 (Pending.IsInterfaceIndexer): New public method.
19185 (Pending.ImplementIndexer): New public method.
19186 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
19187 This is used when implementing interface indexers to define a proxy
19189 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
19190 define a proxy if necessary.
19192 * interface.cs (Interface.IndexerName): New public variable.
19193 (Interface.PopulateIndexer): Set the IndexerName.
19194 (Interface.DefineIndexers): New private method. Populate all the
19195 indexers and make sure their IndexerNames match.
19197 * typemanager.cs (IndexerPropertyName): Added support for interface
19200 2002-07-22 Martin Baulig <martin@gnome.org>
19202 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
19203 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
19204 ret if HasReturnLabel.
19205 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
19208 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
19209 and set the ec.LoopBeginTryCatchLevel.
19210 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
19211 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
19212 the current ec.TryCatchLevel, the branch goes out of an exception
19213 block. In this case, we need to use Leave and not Br.
19215 2002-07-22 Martin Baulig <martin@gnome.org>
19217 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
19218 block unless the block does not always return or it is contained in
19219 another try { ... } catch { ... } block. Fixes bug #26506.
19220 Added verify-1.cs to the test suite.
19222 2002-07-22 Martin Baulig <martin@gnome.org>
19224 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
19225 then we do not always return. Fixes bug #24985.
19227 2002-07-22 Martin Baulig <martin@gnome.org>
19229 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
19230 lookup on a per-class level; ie. walk up the class hierarchy until we
19231 found at least one applicable method, then choose the best among them.
19232 Fixes bug #24463 and test-29.cs.
19234 2002-07-22 Martin Baulig <martin@gnome.org>
19236 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
19237 return types of the methods. The return type is not part of the
19238 signature and we must not check it to make the `new' modifier work.
19239 Fixes bug #27999, also added test-147.cs.
19240 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
19242 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
19243 on the method's return type.
19245 2002-07-21 Martin Baulig <martin@gnome.org>
19247 * assign.cs: Make this work if the rightmost source is a constant and
19248 we need to do an implicit type conversion. Also adding a few more tests
19249 to test-38.cs which should have caught this.
19251 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
19252 target in the makefile for this. The makefile.gnu is primarily intended
19253 for end-users who don't want to debug the compiler.
19255 2002-07-21 Martin Baulig <martin@gnome.org>
19257 * assign.cs: Improved the Assign class so it can now handle embedded
19258 assignments (X = Y = Z = something). As a side-effect this'll now also
19259 consume less local variables. test-38.cs now passes with MCS, added
19260 a few new test cases to that test.
19262 2002-07-20 Martin Baulig <martin@gnome.org>
19264 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
19265 instructions. Fixes bug #27977, also added test-146.cs.
19267 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19269 * cs-tokenizer.cs: fixed getHex ().
19271 2002-07-19 Martin Baulig <martin@gnome.org>
19273 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
19274 not Type.GetType() to lookup the array type. This is needed when
19275 we're constructing an array of a user-defined type.
19276 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
19277 single-dimensional arrays, but also for single-dimensial arrays of
19280 2002-07-19 Martin Baulig <martin@gnome.org>
19282 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
19283 this function is called, it's not allowed to share LocalBuilders
19284 among ILGenerators.
19286 2002-07-19 Martin Baulig <martin@gnome.org>
19288 * expression.cs (Argument.Resolve): Report an error 118 when trying
19289 to pass a type as argument.
19291 2002-07-18 Martin Baulig <martin@gnome.org>
19293 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
19294 Conv_R_Un for the signed `long' type.
19296 2002-07-15 Miguel de Icaza <miguel@ximian.com>
19298 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
19299 `expr' for the temporary result, as that will fail if we do
19300 multiple resolves on the same expression.
19302 2002-07-05 Miguel de Icaza <miguel@ximian.com>
19304 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
19305 ec.TypeContainer for looking up aliases.
19307 * class.cs (TypeContainer): Remove LookupAlias from here.
19309 * decl.cs (DeclSpace); Move here.
19311 2002-07-01 Miguel de Icaza <miguel@ximian.com>
19313 * class.cs (FindMembers): Only call filter if the constructor
19314 bulider is not null.
19316 Also handle delegates in `NestedTypes' now. Now we will perform
19317 type lookups using the standard resolution process. This also
19320 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
19321 This uses Expressions (the limited kind that can be parsed by the
19322 tree) instead of strings.
19324 * expression.cs (ComposedCast.ToString): Implement, used to flag
19325 errors since now we have to render expressions.
19327 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
19330 * ecore.cs (SimpleName.ToString): ditto.
19332 * cs-parser.jay: Instead of using strings to assemble types, use
19333 Expressions to assemble the type (using SimpleName, ComposedCast,
19334 MemberAccess). This should fix the type lookups in declarations,
19335 because we were using a different code path for this.
19337 * statement.cs (Block.Resolve): Continue processing statements
19338 even when there is an error.
19340 2002-07-17 Miguel de Icaza <miguel@ximian.com>
19342 * class.cs (Event.Define): Also remove the `remove' method from
19343 the list of pending items.
19345 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
19346 generate more compact code.
19348 2002-07-17 Martin Baulig <martin@gnome.org>
19350 * const.cs (Const.LookupConstantValue): Add support for constant
19351 `unchecked' and `checked' expressions.
19352 Also adding test case test-140.cs for this.
19354 2002-07-17 Martin Baulig <martin@gnome.org>
19356 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
19357 check whether mi.ReturnType implements the IEnumerator interface; the
19358 `==' and the IsAssignableFrom() will fail in this situation.
19360 2002-07-16 Ravi Pratap <ravi@ximian.com>
19362 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
19365 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19367 * expression.cs: fixed bug #27811.
19369 2002-07-14 Miguel de Icaza <miguel@ximian.com>
19371 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
19372 Molaro: when we are a ref, the value already contains a pointer
19373 value, do not take the address of it.
19375 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
19376 * removed mb-parser.jay and mb-tokenizer.cs
19378 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
19380 * expression.cs: check against the building corlib void type.
19382 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
19384 * ecore.cs: fix for valuetype static readonly fields: when
19385 initializing them, we need their address, not the address of a copy.
19387 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
19389 * typemanager.cs: register also enum_type in corlib.
19391 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
19393 * class.cs: allow calling this (but not base) initializers in structs.
19395 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
19397 * ecore.cs: make sure we compare against the building base types
19400 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
19402 * typemanager.cs: fix TypeToCoreType() to handle void and object
19403 (corlib gets no more typerefs after this change).
19405 2002-07-12 Miguel de Icaza <miguel@ximian.com>
19407 * expression.cs (ArrayCreation.EmitArrayArguments): use
19408 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
19410 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
19411 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
19412 array indexes, the runtime actually forbids them.
19414 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
19415 for array arguments here.
19417 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
19418 instead of the default for ValueTypes.
19420 (New.DoEmit): Use IsValueType instead of
19421 IsSubclassOf (value_type)
19422 (New.DoResolve): ditto.
19423 (Invocation.EmitCall): ditto.
19425 * assign.cs (Assign): ditto.
19427 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
19428 Statements *are* currently doing part of their resolution during
19431 Expressions do always resolve during resolve, but statements are
19432 only required to propagate resolution to their children.
19434 2002-07-11 Miguel de Icaza <miguel@ximian.com>
19436 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
19438 (LoadAssembly): Do not add the dll if it is already specified
19440 (MainDriver): Add the System directory to the link path at the end,
19441 after all the other -L arguments.
19443 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
19444 wrong opcode for loading bytes and bools (ldelem.i1 instead of
19445 ldelem.u1) and using the opposite for sbytes.
19447 This fixes Digger, and we can finally run it.
19449 * driver.cs (UnixParseOption): Move the option parsing here.
19450 (CSCParseOption): Implement CSC-like parsing of options.
19452 We now support both modes of operation, the old Unix way, and the
19453 new CSC-like way. This should help those who wanted to make cross
19454 platform makefiles.
19456 The only thing broken is that /r:, /reference: and /lib: are not
19457 implemented, because I want to make those have the same semantics
19458 as the CSC compiler has, and kill once and for all the confussion
19459 around this. Will be doing this tomorrow.
19461 * statement.cs (Unsafe.Resolve): The state is checked during
19462 resolve, not emit, so we have to set the flags for IsUnsfe here.
19464 2002-07-10 Miguel de Icaza <miguel@ximian.com>
19466 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
19467 not catch the Error_ObjectRefRequired in SimpleName (as it is
19468 possible to have a class/instance variable name that later gets
19469 deambiguated), we have to check this here.
19471 2002-07-10 Ravi Pratap <ravi@ximian.com>
19473 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
19474 make static and put into Expression.
19476 (Event.Define): Register the private field of the event with the
19477 TypeManager so that GetFieldFromEvent can get at it.
19479 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
19480 keep track of the private field associated with an event which
19483 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
19486 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
19488 2002-07-10 Miguel de Icaza <miguel@ximian.com>
19490 * expression.cs (Binary.EmitBranchable): this routine emits the
19491 Binary expression in a branchable context. This basically means:
19492 we need to branch somewhere, not just get the value on the stack.
19494 This works together with Statement.EmitBoolExpression.
19496 * statement.cs (Statement.EmitBoolExpression): Use
19499 2002-07-09 Miguel de Icaza <miguel@ximian.com>
19501 * statement.cs (For): Reduce the number of jumps in loops.
19503 (For): Implement loop inversion for the For statement.
19505 (Break): We can be breaking out of a Try/Catch controlled section
19506 (foreach might have an implicit try/catch clause), so we need to
19507 use Leave instead of Br.
19509 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
19510 now). If the instace expression supports IMemoryLocation, we use
19511 the AddressOf method from the IMemoryLocation to extract the
19512 address instead of emitting the instance.
19514 This showed up with `This', as we were emitting the instance
19515 always (Emit) instead of the Address of This. Particularly
19516 interesting when This is a value type, as we dont want the Emit
19517 effect (which was to load the object).
19519 2002-07-08 Miguel de Icaza <miguel@ximian.com>
19521 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
19523 * statement.cs (Checked): Set the CheckedState during the resolve
19524 process too, as the ConvCast operations track the checked state on
19525 the resolve process, and not emit.
19527 * cs-parser.jay (namespace_member_declaration): Flag that we have
19528 found a declaration when we do. This is used to flag error 1529
19530 * driver.cs: Report ok when we display the help only.
19532 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
19534 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
19536 2002-07-04 Miguel de Icaza <miguel@ximian.com>
19538 * cs-tokenizer.cs (define): We also have to track locally the
19539 defines. AllDefines is just used for the Conditional Attribute,
19540 but we also need the local defines for the current source code.
19542 2002-07-03 Miguel de Icaza <miguel@ximian.com>
19544 * statement.cs (While, For, Do): These loops can exit through a
19545 Break statement, use this information to tell whether the
19546 statement is the last piece of code.
19548 (Break): Flag that we break.
19550 * codegen.cs (EmitContexts): New `Breaks' state variable.
19552 2002-07-03 Martin Baulig <martin@gnome.org>
19554 * class.cs (TypeContainer.MethodModifiersValid): Allow override
19555 modifiers in method declarations in structs. Otherwise, you won't
19556 be able to override things like Object.Equals().
19558 2002-07-02 Miguel de Icaza <miguel@ximian.com>
19560 * class.cs (Method, Property, Indexer): Do not allow the public
19561 modifier to be used in explicit interface implementations.
19563 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
19564 override modifiers in method declarations in structs
19566 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
19568 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
19569 integer or real overflow, report an error
19571 2002-07-02 Martin Baulig <martin@gnome.org>
19573 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
19574 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
19575 to tell the runtime about our newly created System.Object and
19576 System.ValueType types.
19578 2002-07-02 Miguel de Icaza <miguel@ximian.com>
19580 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
19581 struct instead of Ldarg/Starg.
19583 2002-07-02 Martin Baulig <martin@gnome.org>
19585 * expression.cs (Indirection.Indirection): Call
19586 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
19588 2002-07-02 Martin Baulig <martin@gnome.org>
19590 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
19591 ValueType, call TypeManager.TypeToCoreType() on it.
19592 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
19593 the OpCodes.Newarr argument.
19595 2002-07-02 Martin Baulig <martin@gnome.org>
19597 * expression.cs (Invocation.EmitCall): When compiling corlib,
19598 replace all calls to the system's System.Array type to calls to
19599 the newly created one.
19601 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
19602 System.Array methods.
19603 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
19604 from the system's System.Array type which must be replaced.
19606 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
19608 * typemanager.cs: load unverifiable_code_ctor so we can build
19609 corlib using the correct type. Avoid using GetTypeCode() with
19611 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
19612 TypeManager.object_type to allow building corlib.
19614 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
19616 * ecore.cs: handle System.Enum separately in LoadFromPtr().
19618 2002-07-01 Martin Baulig <martin@gnome.org>
19620 * class.cs: Make the last change actually work, we need to check
19621 whether `ifaces != null' to avoid a crash.
19623 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
19625 * class.cs: when we build structs without fields that implement
19626 interfaces, we need to add the interfaces separately, since there is
19627 no API to both set the size and add the interfaces at type creation
19630 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
19632 * expression.cs: the dimension arguments to the array constructors
19633 need to be converted if they are a long.
19635 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
19637 * class.cs: don't emit ldarg.0 if there is no parent constructor
19638 (fixes showstopper for corlib).
19640 2002-06-29 Martin Baulig <martin@gnome.org>
19642 MCS now compiles corlib on GNU/Linux :-)
19644 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
19645 ie. check for MethodImplOptions.InternalCall.
19647 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
19648 and TypeManager.attribute_type are null, so we must explicitly check
19649 whether parent is not null to find out whether it's an attribute type.
19650 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
19651 and SetBuilder, not only if the property is neither abstract nor external.
19652 This is necessary to set the MethodImplOptions on the accessor methods.
19653 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
19654 SetBuilder, see Property.Emit().
19656 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
19657 populate "System.Object", "System.ValueType" and "System.Attribute" since
19658 they've already been populated from BootCorlib_PopulateCoreTypes().
19660 2002-06-29 Martin Baulig <martin@gnome.org>
19662 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
19663 is the NullLiteral, we also need to make sure that target_type is not
19666 2002-06-29 Martin Baulig <martin@gnome.org>
19668 * rootcontext.cs (RootContext.ResolveCore): We must initialize
19669 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
19670 before calling BootstrapCorlib_ResolveDelegate ().
19672 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19674 * statement.cs: fixed build-breaker. All tests passed ok.
19676 2002-06-27 Martin Baulig <martin@gnome.org>
19678 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
19679 for System.Decimal when compiling corlib.
19681 2002-06-27 Martin Baulig <martin@gnome.org>
19683 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
19684 switch blocks which contain nothing but a default clause.
19686 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
19688 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
19690 2002-06-27 Martin Baulig <martin@gnome.org>
19692 * ecore.cs (PropertyExpr.PropertyExpr): Call
19693 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
19695 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
19696 is already a TypeBuilder.
19698 2002-06-27 Martin Baulig <martin@gnome.org>
19700 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
19701 `target_type == TypeManager.array_type', not IsAssignableFrom() in
19702 the "from an array-type to System.Array" case. This makes it work
19703 when compiling corlib.
19705 2002-06-27 Martin Baulig <martin@gnome.org>
19707 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
19708 non-static PropertyExpr, set its InstanceExpression. This makes
19709 the `ICollection.Count' property work in System/Array.cs.
19711 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
19713 * driver.cs: Made error handling more consistent. Errors now
19714 tracked by Report class, so many methods which used to return int
19715 now return void. Main() now prints success/failure and
19716 errors/warnings message.
19718 Renamed '--probe' compiler argument to '--expect-error'. Removed
19719 the magic number return values (123 and 124). Now, if the
19720 expected error occurs, the compiler exits with success (exit value
19721 0). If the compilation completes without seeing that particular
19722 error, the compiler exits with failure (exit value 1). The
19723 makefile in mcs/errors has been changed to handle the new behaviour.
19725 * report.cs: Made 'expected error' number a property and renamed
19726 it from 'Probe' to 'ExpectedError'.
19728 * genericparser.cs: Removed error handling support, since it is
19729 now all done by Report class.
19731 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
19732 class, so parse() no longer returns an int.
19734 * namespace.cs: Use Report.Error instead of GenericParser.error
19736 2002-06-22 Miguel de Icaza <miguel@ximian.com>
19738 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
19739 TypeContainer.AddOperator): At the front of the list put the
19740 explicit implementations, so they get resolved/defined first.
19742 2002-06-21 Miguel de Icaza <miguel@ximian.com>
19744 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
19745 interface type is implemented by this TypeContainer. Used during
19746 explicit interface implementation.
19748 (Property.Define, Indexer.Define, Method.Define): Validate that
19749 the given interface in the explicit implementation is one of the
19750 base classes for the containing type.
19752 Also if we are explicitly implementing an interface, but there is
19753 no match in the pending implementation table, report an error.
19755 (Property.Define): Only define the property if we are
19756 not explicitly implementing a property from an interface. Use the
19757 correct name also for those properties (the same CSC uses,
19758 although that is really not needed).
19760 (Property.Emit): Do not emit attributes for explicitly implemented
19761 properties, as there is no TypeBuilder.
19763 (Indexer.Emit): ditto.
19765 Hiding then means that we do not really *implement* a pending
19766 implementation, which makes code fail.
19768 2002-06-22 Martin Baulig <martin@gnome.org>
19770 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
19771 the return value of Object.GetType(). [FIXME: we need to do this whenever
19772 we get a type back from the reflection library].
19774 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
19776 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
19778 2002-06-20 Miguel de Icaza <miguel@ximian.com>
19780 * attribute.cs: Return null if we can not look up the type.
19782 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
19783 the interface types found.
19785 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
19786 interface types found.
19788 * typemanager.cs (GetInterfaces): Make this routine returns alll
19789 the interfaces and work around the lame differences between
19790 System.Type and System.Reflection.Emit.TypeBuilder in the results
19791 result for GetInterfaces.
19793 (ExpandInterfaces): Given an array of interface types, expand and
19794 eliminate repeated ocurrences of an interface. This expands in
19795 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
19798 2002-06-21 Martin Baulig <martin@gnome.org>
19800 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
19803 2002-06-21 Martin Baulig <martin@gnome.org>
19805 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
19806 and called with one of the core types, return the corresponding typebuilder for
19809 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
19812 2002-06-21 Martin Baulig <martin@gnome.org>
19814 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
19815 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
19816 (Expression.ConvertReferenceExplicit): Likewise.
19818 * expression.cs (ElementAccess.DoResolve): Likewise.
19819 (ElementAccess.DoResolveLValue): Likewise.
19821 2002-06-10 Martin Baulig <martin@gnome.org>
19823 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
19824 add the "value" parameter to the parameter list.
19826 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
19829 2002-06-19 Miguel de Icaza <miguel@ximian.com>
19831 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
19832 the argument to an int, uint, long or ulong, per the spec. Also
19833 catch negative constants in array creation.
19835 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
19837 * class.cs: do not allow the same interface to appear twice in
19838 the definition list.
19840 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
19842 * ecore.cs: don't use ldlen with System.Array.
19844 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
19846 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
19848 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
19850 * modifiers.cs: produce correct field attributes for protected
19851 internal. Easy fix so miguel can work on ther harder stuff:-)
19853 2002-06-18 Miguel de Icaza <miguel@ximian.com>
19855 * pending.cs: New file. Move the code from class.cs here.
19856 Support clearning the pending flag for all methods (when not doing
19857 explicit interface implementation).
19859 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
19861 * rootcontext.cs: added a couple more types needed to bootstrap.
19863 2002-06-17 Miguel de Icaza <miguel@ximian.com>
19865 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
19866 constructor in the type, instead of any constructor in the type
19867 hierarchy. Thanks to Paolo for finding this bug (it showed up as
19868 a bug in the Mono runtime when applying the params attribute).
19870 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
19871 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
19873 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
19875 * expression.cs (Unary.ResolveOperator): Use TypeManager
19876 to resolve the type.
19878 2002-06-13 Ravi Pratap <ravi@ximian.com>
19880 * cs-parser.jay (enum_member_declaration): Pass in the attributes
19883 * enum.cs (AddEnumMember): Add support to store the attributes associated
19884 with each member too.
19886 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
19887 field builders too - this takes care of the enum member case.
19889 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
19891 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
19892 address-of operator on both value types and pointers.
19894 2002-06-10 Martin Baulig <martin@gnome.org>
19896 * interface.cs (Interface.PopulateIndexer): Add the indexer's
19897 PropertyBuilder to the `property_builders' list.
19899 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
19900 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
19901 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
19902 find any indexers which are inherited from an interface.
19904 2002-06-09 Martin Baulig <martin@gnome.org>
19906 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
19907 the same type as the constant if necessary. There's also a test-130.cs
19910 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
19912 * typemanager.cs (TypeManager.ChangeType): Previously known as
19913 Enum.ChangeEnumType().
19915 2002-06-09 Martin Baulig <martin@gnome.org>
19917 * expression.cs (Cast.TryReduce): Added support for consts.
19919 2002-06-08 Ravi Pratap <ravi@ximian.com>
19921 * class.cs (Accessor): Hold attributes information so we can pass
19924 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
19925 Modify to pass in attributes attached to the methods.
19927 (add_accessor_declaration, remove_accessor_declaration): Ditto.
19929 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
19930 to handle the Accessor kind :-)
19932 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
19934 2002-06-08 Martin Baulig <martin@gnome.org>
19936 * expression.cs (Unary.TryReduceNegative): Added support for
19939 2002-06-08 Martin Baulig <martin@gnome.org>
19941 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
19942 name can't be found in the `defined_names' - the caller will do a
19943 MemberLookup in this case and thus find methods in System.Enum
19944 such as Enum.IsDefined().
19946 2002-06-08 Martin Baulig <martin@gnome.org>
19948 * enum.cs (Enum.ChangeEnumType): This is a custom version of
19949 Convert.ChangeType() which works with TypeBuilder created types.
19950 (Enum.LookupEnumValue, Enum.Define): Use it here.
19952 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
19953 `TypeBuilder.BaseType != null' check.
19954 (TypeContainer.FindMembers): Only lookup parent members if we
19955 actually have a parent.
19956 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
19957 (ConstructorInitializer.Resolve): Likewise.
19959 * interface.cs (Interface.FindMembers): Added
19960 `TypeBuilder.BaseType != null' check.
19962 * rootcontext.cs (RootContext.ResolveCore): Added
19963 "System.Runtime.CompilerServices.IndexerNameAttribute" to
19964 classes_second_stage.
19966 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
19967 debug_type and trace_type when compiling with --nostdlib.
19969 2002-06-07 Martin Baulig <martin@gnome.org>
19971 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
19972 (AddField): Set it to true when adding a non-static field.
19973 (DefineType): Use `have_nonstatic_fields' to find out whether we
19974 have non-static fields, not `Fields != null'.
19976 2002-06-02 Miguel de Icaza <miguel@ximian.com>
19978 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
19979 dereferencing a null on the static-field code path)
19981 2002-05-30 Martin Baulig <martin@gnome.org>
19983 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
19984 to take command line arguments. Use reflection to call the new
19985 custom `Initialize' function on the symbol writer and pass it the
19986 command line arguments.
19988 * driver.cs (--debug-args): New command line argument to pass command
19989 line arguments to the symbol writer.
19991 2002-05-28 Miguel de Icaza <miguel@ximian.com>
19993 * assign.cs (DoResolve): Forgot to do the implicit conversion to
19994 the target type for indexers and properties. Thanks to Joe for
19997 2002-05-27 Miguel de Icaza <miguel@ximian.com>
19999 * typemanager.cs (MethodFlags): returns the method flags
20000 (Obsolete/ShouldIgnore) that control warning emission and whether
20001 the invocation should be made, or ignored.
20003 * expression.cs (Invocation.Emit): Remove previous hack, we should
20004 not do this on matching a base type, we should do this based on an attribute
20006 Only emit calls to System.Diagnostics.Debug and
20007 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
20008 on the command line.
20010 * rootcontext.cs: Global settings for tracing and debugging.
20012 * cs-tokenizer.cs (define): New utility function to track
20013 defines. Set the global settings for TRACE and DEBUG if found.
20015 2002-05-25 Ravi Pratap <ravi@ximian.com>
20017 * interface.cs (Populate*): Pass in the TypeContainer as well as
20018 the DeclSpace as parameters so that we can create EmitContexts and
20019 then use that to apply attributes etc.
20021 (PopulateMethod, PopulateEvent, PopulateProperty)
20022 (PopulateIndexer): Apply attributes everywhere.
20024 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
20027 (ApplyAttributes): Update accordingly.
20029 We now apply interface attributes for all members too.
20031 2002-05-26 Miguel de Icaza <miguel@ximian.com>
20033 * class.cs (Indexer.Define); Correctly check if we are explicit
20034 implementation (instead of checking the Name for a ".", we
20035 directly look up if the InterfaceType was specified).
20037 Delay the creation of the PropertyBuilder.
20039 Only create the PropertyBuilder if we are not an explicit
20040 interface implementation. This means that explicit interface
20041 implementation members do not participate in regular function
20042 lookups, and hence fixes another major ambiguity problem in
20043 overload resolution (that was the visible effect).
20045 (DefineMethod): Return whether we are doing an interface
20048 * typemanager.cs: Temporary hack until we get attributes in
20049 interfaces (Ravi is working on that) and we get IndexerName
20050 support in interfaces.
20052 * interface.cs: Register the indexers as properties.
20054 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
20055 warning, I have verified that this is a bug in the .NET runtime
20056 (JavaScript suffers of the same problem).
20058 * typemanager.cs (MemberLookup): When looking up members for
20059 interfaces, the parent of an interface is the implicit
20060 System.Object (so we succeed in searches of Object methods in an
20061 interface method invocation. Example: IEnumerable x; x.ToString
20064 2002-05-25 Miguel de Icaza <miguel@ximian.com>
20066 * class.cs (Event): Events should also register if they do
20067 implement the methods that an interface requires.
20069 * typemanager.cs (MemberLookup); use the new GetInterfaces
20072 (GetInterfaces): The code used to lookup interfaces for a type is
20073 used in more than one place, factor it here.
20075 * driver.cs: Track the errors at the bottom of the file, we kept
20078 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
20079 instance if the method we are calling is static!
20081 2002-05-24 Miguel de Icaza <miguel@ximian.com>
20083 * attribute.cs (ApplyAttributes): Make this function filter out
20084 the IndexerName attribute (as that attribute in reality is never
20085 applied) and return the string constant for the IndexerName
20088 * class.cs (TypeContainer.Emit): Validate that all the indexers
20089 have the same IndexerName attribute, and if so, set the
20090 DefaultName attribute on the class.
20092 * typemanager.cs: The return value might contain other stuff (not
20093 only methods). For instance, consider a method with an "Item"
20094 property and an Item method.
20096 * class.cs: If there is a problem with the parameter types,
20099 2002-05-24 Ravi Pratap <ravi@ximian.com>
20101 * ecore.cs (ImplicitConversionExists): Wrapper function which also
20102 looks at user defined conversion after making a call to
20103 StandardConversionExists - we need this for overload resolution.
20105 * expression.cs : Update accordingly the various method calls.
20107 This fixes 2 bugs filed against implicit user defined conversions
20109 2002-05-22 Miguel de Icaza <miguel@ximian.com>
20111 * statement.cs: Track the result of the assignment.
20113 2002-05-21 Miguel de Icaza <miguel@ximian.com>
20115 * expression.cs (MemberAccess): Improved error reporting for
20116 inaccessible members.
20118 2002-05-22 Martin Baulig <martin@gnome.org>
20120 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
20121 itself with debugging support.
20123 2002-05-22 Martin Baulig <martin@gnome.org>
20125 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
20126 Removed, this isn't needed anymore.
20128 2002-05-20 Martin Baulig <martin@gnome.org>
20130 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
20131 be underlying type for an enum.
20133 2002-05-20 Miguel de Icaza <miguel@ximian.com>
20135 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
20136 that splits out the loading of just the core types.
20138 * rootcontext.cs (ResolveCore): Split the struct resolution in
20139 two, so we can load the enumeration underlying types before any
20142 * expression.cs (Is): Bandaid until we fix properly Switch (see
20143 bug #24985 for details).
20145 * typemanager.cs (ImplementsInterface): The hashtable will contain
20146 a null if there are no interfaces implemented.
20148 2002-05-18 Miguel de Icaza <miguel@ximian.com>
20150 * cs-parser.jay (indexer_declarator): It is fine to have array
20153 2002-05-17 Miguel de Icaza <miguel@ximian.com>
20155 * typemanager.cs: (RegisterBuilder): New function used to register
20156 TypeBuilders that implement interfaces. Since
20157 TypeBuilder.GetInterfaces (as usual) does not work with lame
20159 (AddUserType): register interfaces.
20161 (ImplementsInterface): Use the builder_to_ifaces hash if we are
20162 dealing with TypeBuilder. Also, arrays are showing up as
20163 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
20164 methods can not be invoked on them!
20166 * ecore.cs (ExplicitReferenceConversionExists): Made public.
20167 (ImplicitReferenceConversionExists): Split out from
20168 StandardConversionExists.
20170 * expression.cs (As): We were only implementing one of the three
20171 cases for the as operator. We now implement them all.
20172 (Is): Implement the various other cases for Is as well.
20174 * typemanager.cs (CACHE): New define used to control if we want or
20175 not the FindMembers cache. Seems to have a negative impact on
20176 performance currently
20178 (MemberLookup): Nested types have full acess to
20179 enclosing type members
20181 Remove code that coped with instance/static returns for events, we
20182 now catch this in RealFindMembers.
20184 (RealFindMembers): only perform static lookup if the instance
20185 lookup did not return a type or an event.
20187 2002-05-17 Miguel de Icaza <miguel@ximian.com>
20189 * assign.cs (CompoundAssign): We pass more semantic information
20190 now to Compound Assignments than we did before: now we have all
20191 the information at hand, and now we resolve the target *before* we
20192 do the expression expansion, which allows the "CacheValue" method
20193 to have the effect we intended (before, a [x] += 1 would generate
20194 two differen ArrayAccess expressions from the ElementAccess,
20195 during the resolution process).
20197 (CompoundAssign.DoResolve): Resolve target and original_source here.
20199 2002-05-16 Miguel de Icaza <miguel@ximian.com>
20201 * expression.cs (ArrayAccess): dropped debugging information.
20203 * typemanager.cs: Small bug fix: I was always returning i_members,
20204 instead of one of i_members or s_members (depending on which had
20207 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
20208 method is invoked before any code generation takes place, and it
20209 is a mechanism to inform that the expression will be invoked more
20210 than once, and that the method should use temporary values to
20211 avoid having side effects
20213 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
20215 * ecore.cs (Expression.CacheTemporaries): Provide empty default
20218 * expression.cs (Indirection, ArrayAccess): Add support for
20219 CacheTemporaries in these two bad boys.
20221 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
20222 ldobj or ldind_ref.
20223 (StoreFromPtr): Handle stobj as well.
20225 * expression.cs (UnaryMutator): Share more code.
20227 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
20228 down: I was not tracking the Filter function as well, which
20229 was affecting the results of the cache.
20231 2002-05-15 Miguel de Icaza <miguel@ximian.com>
20233 * attribute.cs: Remove the hack to handle the CharSet property on
20236 2002-05-14 Miguel de Icaza <miguel@ximian.com>
20238 * attribute.cs (DoResolve): More uglyness, we now only try to
20239 resolve the attribute partially, to extract the CharSet
20240 information (only if we are a StructLayout attribute). Otherwise
20242 (GetExtraTypeInfo): Add some code to conditionally kill in the
20243 future this. I am more and more convinced that the .NET
20244 framework has special code to handle the attribute setting on
20247 * expression.cs (IsParamsMethodApplicable): Revert my previous
20248 foreach change here, it was wrong.
20250 2002-05-13 Miguel de Icaza <miguel@ximian.com>
20252 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
20253 (pp_expr): do not abort on unknown input, just return.
20254 (eval): abort if there are pending chars.
20256 * attribute.cs (Attribute.Resolve): Positional parameters are
20257 optional. Deal with that case.
20259 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
20260 the Ansi/Unicode/Auto information for the type.
20262 (TypeContainer.DefineType): instantiate the EmitContext here, as
20263 we will be using it during the type definition (to resolve
20264 attributes) and during the emit phase.
20266 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
20267 to pull type information out of the attributes
20269 (Attribute.Resolve): track the constructor builder, and allow for
20270 multiple invocations (structs and classes will use this).
20272 * ecore.cs (MemberLookupFinal): new version with all the
20273 parameters customizable.
20275 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
20276 constructors. Return if the result value is null (as the error
20277 would have been flagged already by MemberLookupFinal)
20279 Do not allow instances of abstract classes or interfaces to be
20282 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
20283 We have to compare the assembly property here when dealing with
20284 FamANDAssem and Assembly access modifiers, because we might be
20285 creating an assembly from *modules* (that means that we are not
20286 getting TypeBuilders for types defined in other modules that are
20287 part of this assembly).
20289 (Method.Emit): If the method is marked abstract and has a body,
20292 (TypeContainer.DefineMembers): If both the defined member and the
20293 parent name match are methods, then do not emit any warnings: let
20294 the Method.Define routine take care of flagging warnings. But if
20295 there is a mismatch (method overrides something else, or method is
20296 overriwritten by something, then emit warning).
20298 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
20299 set to null, this means `do not check for the return type on the
20302 (Method.Define): set the return type for the method signature to
20303 null, so that we get methods with the same name and parameters and
20304 different return types. This is used to flag warning 114 (you are
20305 hiding a method, and you probably want to use the new/override
20308 * typemanager.cs (MemberLookup): Implemented proper access
20309 control, closing a long standing set of bug reports. The problem
20310 was that the Framework only has two bits: Public and NonPublic,
20311 and NonPublic includes private and protected methods, but we need
20312 to enforce the FamANDAssem, FamOrAssem and Family.
20314 2002-05-11 Miguel de Icaza <miguel@ximian.com>
20316 * statement.cs (GotoCase): Return true: Ammounts to giving up
20317 knowledge on whether we return or not, and letting the other case
20318 be responsible for it.
20320 2002-05-10 Miguel de Icaza <miguel@ximian.com>
20322 * driver.cs: Do not load directories for each file processed, only
20323 do it if there is a pattern.
20325 * ecore.cs: Report readonly assigns here as well, as we might have
20326 been resolved only by MemberAccess.
20328 (SimpleName.SimpleNameResolve): Also be useful for LValue
20329 resolution. We need this to propagate assign to local readonly variables
20331 * typemanager.cs: Use a ptrhashtable for the criteria, because we
20332 do not want to reuse potential criteria memory.
20334 * class.cs (MyEventBuilder): Set reflected_type;
20336 * ecore.cs (Constantify): Added support for constifying bools.
20338 (RootContext.LookupType): Added a cache for values looked up in
20339 the declaration space.
20341 * typemanager.cs (FindMembers): Now is a front-end to
20342 RealFindMembers, and provides a two-level hashtable-based cache to
20345 15% performance improvement: from 22.5 to 19.2 seconds.
20347 * expression.cs (IsParamsMethodApplicable): use foreach.
20348 (Invocation.DoResolve): ditto.
20349 (New.DoResolve): ditto.
20350 (ArrayCreation.DoResolve): ditto.
20352 * ecore.cs (FindMostEncompassingType): use foreach.
20354 * delegate.cs (NewDelegate.DoResolve): Use foreach
20356 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
20357 (RemoveMethods): use foreach.
20359 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
20360 nested foreach statements instead of for, and also break out of
20361 the inner loop once a match is found.
20363 (Invocation.OverloadResolve): Use foreach, simplify the code.
20365 2002-05-08 Miguel de Icaza <miguel@ximian.com>
20367 * cfold.cs (BinaryFold): During an enumeration evaluation context,
20368 we actually unwrap the expression to allow for extra information
20371 * expression.cs: Use Shr_Un on unsigned operations.
20373 2002-05-08 Ravi Pratap <ravi@ximian.com>
20375 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
20376 applicable operators was not being considered correctly. This closes
20377 the bug Miguel reported.
20379 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
20381 * attribute.cs: check that the type derives from System.Attribute
20382 and report the correct error in that case (moved the duplicate code to
20383 its own method, too).
20385 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
20387 * attribute.cs: lookup attribute type name as the spec says: first the
20388 bare attribute name and then name + "Attribute" (nant compiles with
20389 mcs after this fix).
20391 2002-05-07 Miguel de Icaza <miguel@ximian.com>
20393 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
20394 Because of the way we parse things, we should try to see if a
20395 UIntConstant can fit in an integer.
20397 2002-05-07 Ravi Pratap <ravi@ximian.com>
20399 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
20400 when we are in an explicit context.
20402 (ConvertReferenceExplicit): When converting from Iface type S to Class
20403 T make sure the rules are implemented as an OR.
20405 * parameter.cs (ParameterType): Make it a property for now although the
20406 purpose really isn't anything immediate.
20408 * expression.cs (Is*Applicable): Do better checking on the parameter type
20409 of a ref/out parameter. The ones from the system assemblies are already
20410 marked with the correct type so we don't need to do any correction.
20412 * ecore.cs (StandardConversionExists): Conversion from Interface types to
20413 the object type is standard too so include that.
20415 2002-05-06 Miguel de Icaza <miguel@ximian.com>
20417 * ecore.cs (StandardConversionExists): Augment with missing code:
20418 deal with IntConstant, LongConstants and Enumerations.
20420 * assign.cs: Report the error, instead of failing silently
20422 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
20423 typecontainer that they are declared, because the
20424 typecontainer/namespace will have the list of using clauses that
20425 need to be applied.
20427 Assembly Attributes were escaping the normal registration
20430 (EmitCode): Apply attributes within an EmitContext that represents
20431 the container they were declared on.
20433 * cs-parser.jay: Track bases for structs. How did I get this wrong?
20435 2002-05-06 Ravi Pratap <ravi@ximian.com>
20437 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
20438 Revamp completely - make much cleaner as we now operate only
20441 (FindMostSpecificSource, FindMostSpecificTarget): New methods
20442 to implement the logic detailed in the spec more correctly.
20444 (UserDefinedConversion): Update accordingly.
20446 2002-05-06 Miguel de Icaza <miguel@ximian.com>
20448 * statement.cs: Return flow analysis information up.
20450 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
20453 (token): Do not consume an extra character before calling
20456 2002-05-06 Piers Haken <piersh@friskit.com>
20458 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
20460 2002-05-06 Miguel de Icaza <miguel@ximian.com>
20462 * class.cs (Constructor.Emit): Set the IsStatic flag in the
20463 EmitContext during the instance constructor initializer
20464 resolution, to stop access to instance variables.
20466 This is mandated by the spec, last paragraph of the `constructor
20467 initializers' section.
20469 2002-05-05 Miguel de Icaza <miguel@ximian.com>
20471 * cs-parser.jay, class.cs (Accessor): new class used to represent
20472 an accessor (get or set). In the past we used `null' to represent
20473 a missing accessor. But this is ambiguous because there was no
20474 way to tell in abstract indexers/properties if one of them was
20477 Now there is a way of addressing that.
20479 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
20480 instead of FindMembers.
20482 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
20483 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
20485 * attribute.cs: Treat indexers and properties as the same in terms
20486 of applying attributes
20488 * ecore.cs (FindMostEncompassedType): Use statically initialized
20489 EmptyExpressions()s like we do elsewhere to avoid creating useless
20490 objects (and we take this out of the tight loop).
20492 (GetConversionOperators): Move the code to extract the actual
20493 operators to a separate routine to clean things up.
20495 2002-05-04 Miguel de Icaza <miguel@ximian.com>
20497 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
20498 events are always registered FieldBuilders.
20500 * class.cs (FieldBase): New class shared by Fields
20502 * delegate.cs: If we are a toplevel delegate, use our full name.
20503 If we are a nested delegate, then only use our tail name.
20505 2002-05-02 Ravi Pratap <ravi@ximian.com>
20507 * expression.cs (IsApplicable): Ensure that we add the "&" to
20508 ref/out types before comparing it with the type of the argument.
20510 (IsParamsMethodApplicable): Ditto.
20512 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
20515 * delegate.cs : Handle the case when we have more than one applicable
20516 method. Flag an error only when we finish checking all.
20518 2002-05-02 Miguel de Icaza <miguel@ximian.com>
20520 * expression.cs: Add support for boolean static initializers.
20522 2002-05-01 Miguel de Icaza <miguel@ximian.com>
20524 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
20526 * parameter.cs (ComputeParameterTypes,
20527 ComputeAndDefineParameterTypes): Better error handling: now we
20528 clear the `types' cache if we fail during any of the type lookups.
20529 We also return the status code correctly to our caller
20531 * delegate.cs: If we fail to define a delegate, abort the extra
20534 * expression.cs (Binary.ResolveOperator): for
20535 operator==(object,object) and operator !=(object, object) we also
20536 have to verify that there is an implicit conversion from one to
20539 (ArrayAccess.DoResolve): Array Access can operate on
20542 2002-04-30 Miguel de Icaza <miguel@ximian.com>
20544 * assign.cs (CompoundAssign): A new class used as a "flag" that
20545 the assignment actually is happening as part of a compound
20546 assignment operator.
20548 During compound assignment, a few new rules exist to enable things
20555 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
20556 to the type of x) if y is implicitly convertible to the type of x,
20557 and the operator is a builtin operator and the return type of the
20558 operator is explicitly convertible to the type of x.
20560 * rootcontext.cs: Reset warning level to 2. 4 catches various
20561 "interesting" features in mcs, we must clean this up at some
20562 point, but currently am trying to kill other bugs ;-)
20564 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
20565 in container classes as well.
20567 * expression.cs (Binary.ResolveOperator): Handle string case
20568 before anything else (as operator overloading does emit an error
20569 before doing anything else).
20571 This code could go away when we move to a table driven model, but
20572 i could not come up with a good plan last night.
20574 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
20576 * typemanager.cs (CSharpName): reimplementation using regex.
20577 * class.cs: added null check for fields in Emit
20578 * rootcontext.cs: set warninglevel to 4
20580 2002-04-29 Miguel de Icaza <miguel@ximian.com>
20582 * typemanager.cs (CSharpName): reimplemented with Lupus
20585 2002-04-28 Miguel de Icaza <miguel@ximian.com>
20587 * statement.cs (If): correclty implement Resolve, because we were
20588 not catching sem errors in there. The same process is needed
20590 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
20593 (Statement.Warning_DeadCodeFound): Factorize code.
20594 (While): Report dead code here too.
20596 (Statement): Added Resolve virtual method to allow
20597 for resolution split from the emit code.
20599 2002-04-26 Miguel de Icaza <miguel@ximian.com>
20601 * statement.cs (EmitBoolExpression): No longer try to resolve the
20603 (MakeBoolean): New utility function that resolve, implicitly
20604 converts to boolean and tags the expression.
20607 (If, Do): Implement dead code elimination.
20608 (While): Implement loop inversion
20610 (Do, While, For, If): Resolve the expression prior to calling our
20613 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
20616 - added method Report28 (warning: program has more than one entry point)
20617 - added method IsEntryPoint, implements paragraph 10.1 of the spec
20618 - modified method Method.Define, the part at the end of the method
20620 * rootcontext.cs: added static public Location EntryPointLocation;
20622 * ../errors/cs0028.cs : Add test case for the above warning.
20625 - modified method CSharpName to allow arrays of primitive type to
20626 be printed nicely (e.g. instead of System.Int32[][] it now prints
20628 - added method CSharpSignature: returns the signature of a method
20629 in string format to be used in reporting errors, warnings, etc.
20631 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
20634 2002-04-26 Ravi Pratap <ravi@ximian.com>
20636 * delegate.cs (Define): Fix extremely silly bug where I was
20637 setting the type of the 'object' parameter of the BeginInvoke
20638 method to System.IAsyncResult instead of System.Object ;-)
20640 2002-04-26 Miguel de Icaza <miguel@ximian.com>
20642 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
20645 (Constructor.Emit): return if we fail to initialize the
20646 constructor. Another door closed!
20648 * expression.cs (New.DoResolve): Improve error message (from -6 to
20649 1501). Use DeclaredOnly lookup to find the exact constructor.
20651 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
20652 loop. This is useful.
20654 * cs-parser.jay: Adjust the default parameters so that destructors
20655 have the proper signature.
20657 2002-04-26 Martin Baulig <martin@gnome.org>
20659 * driver.cs (LoadAssembly): If `assembly' contains any characters
20660 which are only valid in path names and not in assembly names
20661 (currently slash, backslash and point), use Assembly.LoadFrom ()
20662 instead of Assembly.Load () on the `assembly' (before iteration
20663 over the link_paths).
20665 2002-04-26 Martin Baulig <martin@gnome.org>
20667 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
20669 2002-04-25 Miguel de Icaza <miguel@ximian.com>
20671 * class.cs (Property): use the new typemanager.MemberLookup
20673 (TypeContainer.MemberLookup): Implement using the
20674 TypeManager.MemberLookup now.
20676 * typemanager.cs: Make MemberLookup a function of the TypeManager,
20677 and return MemberInfos, so that these can be used without an
20678 EmitContext (what we had before).
20680 2002-04-24 Miguel de Icaza <miguel@ximian.com>
20682 * expression.cs: Fix the case where the argument to params if the
20683 type of the params. I omitted handling this before. Fixed
20685 2002-04-22 Miguel de Icaza <miguel@ximian.com>
20687 * driver.cs: Call BootCorlib_PopulateCoreType
20689 * class.cs (Property.CheckBase): Check for properties only, not
20692 * interface.cs: Temporary hack: try/catch around the
20693 CustomAttributeBuilder, because I am getting an exception that I
20696 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
20697 types whose definitions are required to be there (attributes are
20698 defined before standard types).
20700 Compute definitions as we boot the various types, as they are used
20701 immediately (value_type class will need object_type, but if we do
20702 not initialize object_type, we will pass a null, which will let
20703 the runtime pick the System.Object from the existing corlib, which
20704 is not what we want).
20706 2002-04-22 Patrik Torstensson <totte@labs2.com>
20708 * cs-tokenizer.cs: fixed a number of trim() issues.
20710 2002-04-22 Ravi Pratap <ravi@ximian.com>
20712 * expression.cs (Argument.Type): Ensure that we return the correct
20713 type when we have out or ref parameters [in which case we
20716 2002-04-22 Miguel de Icaza <miguel@ximian.com>
20718 * class.cs (Property, Indexer): Allow extern modifier in there.
20720 * typemanager.cs (InitBaseTypes): Initializes object_type and
20721 value_type, since those will be used early on during the bootstrap
20722 process to compile corlib.
20724 (InitCoreTypes): Move code from here to InitBaseTypes.
20726 2002-04-21 Miguel de Icaza <miguel@ximian.com>
20728 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
20729 single-dimension arrays as using the ldlen opcode.
20731 Daniel Lewis discovered this optimization.
20733 * typemanager.cs: Add signature for System.Array::get_Length
20735 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20737 * statement.cs: report the error when the foreach does not apply to an
20738 array nor a collection.
20740 2002-04-19 Miguel de Icaza <miguel@ximian.com>
20742 * expression.cs: Add implicit conversions to the operator ~.
20744 * constant.cs (DecimalConstant.Emit): Emit decimal value.
20746 * typemanager.cs: Locate the decimal constructor.
20748 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20750 * attribute.cs: use the new property of TypeOf.
20751 * expression.cs: added 'get' property around typearg.
20753 These changes fix a build breaker reported by NickD. Is this the
20754 correct way to fix? If not, please, revert my changes and make it
20757 2002-04-17 Miguel de Icaza <miguel@ximian.com>
20759 * attribute.cs: Add support for typeof in attribute invocations.
20760 I am not sure that this is right though.
20762 2002-04-14 Duncan Mak <duncan@ximian.com>
20764 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
20765 Binary.Operator.Division case.
20767 2002-04-13 Ravi Pratap <ravi@ximian.com>
20769 * class.cs (DefineType): Ensure that we do a proper check on
20770 attribute types and also register it with the TypeManager.
20772 (TypeContainer.Targets): The default for attribute types is
20773 AttributeTargets.All.
20775 * attribute.cs (ApplyAttributes): Registering the attribute type
20776 is done elsewhere, not when we discover we have a Usage attribute.
20778 2002-04-12 Ravi Pratap <ravi@ximian.com>
20780 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
20781 and get rid of is_delegate parameter.
20783 * everywhere : update.
20785 2002-04-12 Ravi Pratap <ravi@ximian.com>
20787 * cs-parser.jay (compilation_unit): Revamp completely to use
20788 some new ideas that I got from Rhys' grammar to solve the problems
20789 with assembly level attributes.
20791 (outer_declaration): New grammar production.
20793 (attribute_sections): Add.
20795 (opt_attributes): Base on attribute_sections
20797 (namespace_declaration): Allow opt_attributes to tackle the case
20798 when we have assembly level attributes - we are clever in this
20801 * attribute.cs (ApplyAttributes): Do not worry about assembly
20802 attributes in the non-global context.
20804 * rootcontext.cs (AddGlobalAttributes): Go back to using this
20805 instead of SetGlobalAttributes.
20807 * class.cs, rootcontext.cs : Ensure we define and generate
20808 attribute types before anything else.
20810 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
20811 and flag the new error -20 for the case when the attribute type
20812 does not have valid targets specified. csc does not catch this.
20814 * ../errors/errors.txt : update for error # -20
20816 2002-04-11 Ravi Pratap <ravi@ximian.com>
20818 * support.cs (InternalParameters.ParameterModifier): Do some null
20819 checking and return sane values.
20821 * class.cs (Method.Define): If we are a PInvoke method, ensure
20822 that we are static and extern. Report error # 601
20824 * ../errors/cs0601.cs : Add test case for the above error.
20826 2002-04-07 Ravi Pratap <ravi@ximian.com>
20828 * rootcontext.cs (attribute_types): We need to keep type of
20829 all attribute types separately and emit code for them first.
20831 (RegisterAttribute) : Implement.
20833 * class.cs (DefineType): Check if the current Type is a custom
20834 attribute type and register it accordingly.
20836 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
20837 adding the first attribute twice and rename to
20839 (SetGlobalAttributes): this.
20841 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
20844 * attribute.cs (ApplyAttributes): Take an additional argument telling us
20845 if we are processing global arguments. Hmm, I am unsure of this.
20847 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20849 * expression.cs: added static array of strings to avoid calling
20850 Enum.ToString () for Operator in Binary. Significant recover of
20853 2002-04-10 Miguel de Icaza <miguel@ximian.com>
20855 * class.cs (FindMembers): Allow the Builders of the various
20856 members to be null. If they are skip them. This only happens
20857 during the PInvoke declaration.
20859 2002-04-09 Miguel de Icaza <miguel@ximian.com>
20861 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
20862 failure, so we do not keep going afterwards.
20864 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
20865 wanted to pass `false' as the `is_delegate' argument. If this is
20866 the case, why not use delegate_type == null to mean `is_delegate =
20867 false' and anything else as is_delegate = true.
20869 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
20871 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
20872 code for the section, not the beginning of the tests.
20874 2002-04-08 Miguel de Icaza <miguel@ximian.com>
20876 * cfold.cs: Handle operator + (Enum x, Underlying x)
20878 * expression.cs (Binary): same. Warn about errors where we have
20879 Enum/Enum in operator + as well.
20881 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
20884 - added support for switch(bool)
20885 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
20886 - add TableSwitchEmit() to handle table-based switch statements
20888 2002-04-05 Ravi Pratap <ravi@ximian.com>
20890 * expression.cs (Invocation.OverloadResolve): Factor out code which
20891 does parameter compatibility checking with arguments so that we can
20892 re-use the code even from Delegate.VerifyApplicability
20894 (VerifyArgumentsCompat): Move above code here.
20896 * delegate.cs (VerifyApplicability): Get rid of duplicate code
20897 and instead make a call to the above method.
20899 2002-03-31 Ravi Pratap <ravi@ximian.com>
20901 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
20902 We use it to keep track of classes which are attribute types.
20904 2002-04-02 Miguel de Icaza <miguel@ximian.com>
20906 * delegate.cs (Delegate.Define): Correctly define the types in the
20907 presence of fixed and array parameters.
20909 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
20912 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
20913 include NonPublic after the first iteration.
20915 * class.cs (Indexer.CheckBase): Only check if both parents are
20918 * cs-parser.jay (accessor_body): If empty, set to null.
20920 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
20921 same code path here to resolve constants names that we did have in
20922 MemberAccess.DoResolve. There is too much code duplicated here.
20924 2002-04-01 Miguel de Icaza <miguel@ximian.com>
20926 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
20928 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
20931 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
20932 tokens, numbers and strings.
20934 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
20937 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
20938 asyncronous parameters and the regular parameters.
20940 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
20941 specify the target directory.
20943 * expression.cs: (This.DoResolve): Simplify
20944 (As.Emit): Optimize, do not generate IsInst if the expression is
20945 always of the given type.
20947 (Is.DoResolve): Bug fix, we were reporting both always/never for
20950 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
20951 creating too many unnecessary arrays.
20953 2002-03-31 Miguel de Icaza <miguel@ximian.com>
20955 * class.cs (EmitFieldInitializer): Use Assign expression to assign
20956 fields instead of rolling our own initializer. Takes care of all
20957 implicit conversions, and drops unnecessary static checks/argument.
20959 2002-03-31 Dick Porter <dick@ximian.com>
20961 * driver.cs: use the GetDirectories() return values properly, and
20962 use "/" as path separator.
20964 2002-03-30 Miguel de Icaza <miguel@ximian.com>
20966 * expression.cs (Unary): Optimize - - expr into expr.
20967 (Binary): Optimize a + (-b) into a -b.
20969 * codegen.cs (CodeGen): Made all methods static.
20971 2002-03-29 Miguel de Icaza <miguel@ximian.com>
20975 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
20976 TypeBuilder property.
20978 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
20981 * tree.cs: Removed the various RecordXXXX, and replaced with a
20982 single RecordDecl. Removed all the accessor methods, and just
20983 left a single access point Type
20985 * enum.cs: Rename DefineEnum to DefineType.
20987 * decl.cs: New abstract method `DefineType' used to unify the
20988 Defines for Enumerations, Interfaces, TypeContainers and
20991 (FindType): Moved LookupInterfaceOrClass here. Moved the
20992 LookupBaseClasses method that used to live in class.cs and
20993 interface.cs here, and renamed to FindType.
20995 * delegate.cs: Implement DefineType. Take advantage of the
20996 refactored pattern for locating the parent builder without taking
20997 the parent_builder argument (which we know does not work if we are
20998 nested, and triggering a toplevel definition).
21000 2002-03-28 Miguel de Icaza <miguel@ximian.com>
21002 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
21003 accessibility of a member has changed during override and report
21006 * class.cs (Method.Define, Property.Define): Only complain on
21007 overrides if the method is private, any other accessibility is
21008 fine (and since we just checked the permission is the same, we are
21011 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
21012 and elif are processed always. The other pre-processing
21013 directives are only processed if we are "taking" the path
21015 2002-03-29 Martin Baulig <martin@gnome.org>
21017 * class.cs (Method.Emit): Only emit symbolic debugging info if the
21018 current location is not Null.
21020 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
21021 a separate method so we can profile it.
21023 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
21024 `span.Seconds' are just seconds, but no minutes or hours.
21025 (MainDriver): Profile the CodeGen.SaveSymbols calls.
21027 2002-03-28 Miguel de Icaza <miguel@ximian.com>
21029 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
21030 Remove the gratuitous set of Final:
21032 // If an interface implementation, then we can set Final.
21033 if (((flags & MethodAttributes.Abstract) == 0) &&
21034 implementing.DeclaringType.IsInterface)
21035 flags |= MethodAttributes.Final;
21037 I do not know what I was smoking when I used that.
21040 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
21041 step into fixing the name resolution issues for delegates and
21042 unifying the toplevel name resolution.
21044 2002-03-28 Martin Baulig <martin@gnome.org>
21046 * class.cs (Method.Emit): If we have a symbol writer, call its
21047 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
21048 tell it about the current method.
21050 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
21051 writer that we're going to emit the first byte of IL code for a new
21052 statement (a new source line).
21053 (EmitContext.EmitTopBlock): If we have a symbol writer, call
21054 EmitContext.Mark() before emitting any code.
21056 * location.cs (SymbolDocument): Return null when we're Null.
21058 * statement.cs (Statement): Moved the `Location loc' variable here.
21059 (Statement.EmitBoolExpression): If we have a symbol writer, call
21060 ec.Mark() before emitting any code to tell it that we're at the
21061 beginning of a new statement.
21062 (StatementExpression): Added `Location' argument to the constructor.
21063 (Block): Added public readonly variable `StartLocation' and public
21064 variable `EndLocation'. The latter is to be set using SetEndLocation().
21065 (Block): Added constructor which takes a start and end location.
21066 (Block.SetEndLocation): New method. This sets the end location.
21067 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
21068 local variables we create.
21069 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
21070 each statement and do also mark the begin and end of the block.
21072 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
21073 tell it the current lexer.Location, use Location.Null for the end of the
21075 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
21076 current block, set its end location using SetEndLocation().
21077 (statement_expression): StatementExpression constructor now takes the
21078 lexer.Location as additional argument.
21079 (for_statement, declare_local_variables): Likewise.
21080 (declare_local_variables): When creating a new implicit block, use the
21081 new Block constructor and pass it the lexer.Location.
21083 2002-03-28 Miguel de Icaza <miguel@ximian.com>
21085 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
21086 members also on the parent interfaces recursively.
21088 2002-03-27 Miguel de Icaza <miguel@ximian.com>
21090 * report.cs: Use new formats, since Gonzalo finished the missing
21093 * expression.cs (Binary.ResolveOperator): added missing operator|
21094 operator& and operator^ for bool/bool.
21096 * cs-parser.jay: CheckDef now takes a Location argument that is
21097 used to report errors more precisly (instead of reporting the end
21098 of a definition, we try to track something which is a lot closer
21099 to the source of the problem).
21101 * cs-tokenizer.cs: Track global token use, so we can properly flag
21102 the use of #define/#undef after the first token has been seen.
21104 Also, rename the reportXXXX to Error_DescriptiveName
21106 * decl.cs (DeclSpace.IsTopLevel): Move property here from
21107 TypeContainer, so that Enum and Interface can use this too.
21109 * class.cs (TypeContainer.LookupInterfaceOrClass,
21110 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
21111 `builder' argument. Typically this was used to pass the parent
21112 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
21115 The problem is that a nested class could trigger the definition of
21116 a toplevel class, and the builder would be obviously wrong in that
21119 So we drop this argument, and we compute dynamically the
21120 TypeBuilder/ModuleBuilder (the correct information was available
21121 to us anyways from DeclSpace.Parent)
21123 * interface.cs (Interface.DefineInterface): Drop builder
21124 parameter cleanup like class.cs
21126 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
21129 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
21132 (Try.Emit): Propagate the returns value from the statement.
21134 (Return.Emit): Even if we are leavning
21136 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
21138 * modifiers.cs: Fix the computation of MethodAttributes flags.
21140 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
21142 * driver.cs: allow compilation of files that start with '/'.
21143 Add a default case when checking the argument of --target.
21145 2002-03-25 Miguel de Icaza <miguel@ximian.com>
21147 * interface.cs: Implement the same search algorithm for types in
21148 the interface code.
21150 * delegate.cs: Do not allow multiple definition.
21152 * Recovered ChangeLog that got accidentally amputated
21154 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
21156 * rootcontext.cs: Load manually enum to allow core classes to
21157 contain enumerations.
21159 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
21160 Update to new static methods in TypeManager.
21162 * typemanager.cs (GetMethod, GetConstructor): Use our
21163 implementation of FindMembers to find the members, since during
21164 corlib compilation, the types are TypeBuilders and GetMethod and
21165 GetConstructor do not work.
21167 Make all methods in TypeManager static.
21169 (InitCodeHelpers): Split the functionality from
21170 the InitCodeTypes function.
21172 * driver.cs: Call InitCodeHelpers after we have populated the
21175 * cs-parser.jay (delegate_declaration): we did not used to compute
21176 the delegate name correctly for void delegates.
21178 2002-03-24 Miguel de Icaza <miguel@ximian.com>
21180 * rootcontext.cs (RootContext): Init the interface_resolve_order
21181 and type_container_resolve_order always.
21183 (ResolveCore, BootstrapCorlib_ResolveClass,
21184 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
21185 compiler when compiling with --nostdlib
21187 * class.cs (TypeContainer.DefineType): Check that our parent is
21188 not null. This test is most important when we are bootstraping
21191 * codegen.cs: Split out the symbol writing code.
21193 2002-03-25 Martin Baulig <martin@gnome.org>
21195 * driver.cs (-g): Made -g an alias for --debug.
21197 2002-03-24 Martin Baulig <martin@gnome.org>
21199 * codegen.cs (SymbolWriter): New public variable. Returns the
21200 current symbol writer.
21201 (CodeGen): Added `bool want_debugging_support' argument to the
21202 constructor. If true, tell the ModuleBuild that we want debugging
21203 support and ask it for the ISymbolWriter.
21204 (Save): If we have a symbol writer, call it's Close() method after
21205 saving the assembly.
21207 * driver.c (--debug): New command line argument to create a
21208 debugger information file.
21210 * location.cs (SymbolDocument): New public property. Returns an
21211 ISymbolDocumentWriter object for the current source file or null
21212 if we don't have a symbol writer.
21214 2002-03-21 Miguel de Icaza <miguel@ximian.com>
21216 * driver.cs (LoadAssembly): Correctly return when all the paths
21217 have been tried and not before.
21219 * statement.cs (Switch.Emit): return the actual coverage for this
21220 statement (returns/not-returns)
21222 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
21223 switch of the statement if we are the last switch section. That
21224 kills two problems: try/catch problems (we used to emit an empty
21225 nop at the end) and switch statements where all branches would
21228 2002-03-19 Miguel de Icaza <miguel@ximian.com>
21230 * driver.cs: Add default assemblies (the equivalent to the
21231 Microsoft CSC.RSP file)
21233 * cs-tokenizer.cs: When updating `cols and setting it to zero,
21234 also update tokens_seen and set it to false.
21236 * driver.cs: Implement --recurse for Mike.
21238 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
21239 correctly splitting out the paths.
21241 2002-03-18 Miguel de Icaza <miguel@ximian.com>
21243 * interface.cs (Interface.PopulateProperty): Instead of using
21244 `parent' as the declaration space for the set parameters, use
21247 * support.cs (InternalParameters): InternalParameters constructor
21248 takes a DeclSpace instead of a TypeContainer.
21250 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
21251 types are being initialized, load the address of it before calling
21254 (New): Provide a mechanism to disable the generation of local
21255 value type temporaries when the caller will be providing us with
21256 an address to store it.
21258 (ArrayCreation.EmitDynamicInitializers): Use it.
21260 2002-03-17 Miguel de Icaza <miguel@ximian.com>
21262 * expression.cs (Invocation.EmitArguments): Only probe for array
21263 property if there is more than one argument. Sorry about that.
21265 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
21266 empty param arrays.
21268 * class.cs (Method.LabelParameters): Fix incorrect code path that
21269 prevented the `ParamArrayAttribute' from being applied to the
21272 2002-03-16 Miguel de Icaza <miguel@ximian.com>
21274 * support.cs (ReflectionParameters): Correctly compute whether the
21275 last argument is a params array. Fixes the problem with
21278 * typemanager.cs: Make the assemblies array always be non-null
21279 (empty, but non-null)
21281 * tree.cs (RecordDecl): New function that abstracts the recording
21282 of names. This reports error 101, and provides a pointer to the
21283 previous declaration. Fixes a crash in the compiler.
21285 * cs-parser.jay (constructor_declaration): Update to new grammar,
21286 and provide a constructor_body that can be empty.
21288 2002-03-15 Miguel de Icaza <miguel@ximian.com>
21290 * driver.cs: Add support for --resources.
21292 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
21293 Make all types for the various array helper methods be integer.
21295 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
21296 CheckState to ConvCast.
21298 (ConvCast): Now it takes a `checked' state argument, to avoid
21299 depending on the emit context for the conversion, and just using
21300 the resolve time setting.
21302 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
21303 instead of Invocation.EmitArguments. We do not emit the original
21304 arguments, instead we emit those which have been converted to
21305 unsigned int expressions.
21307 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
21309 * codegen.cs: ditto.
21311 * expression.cs (LocalVariableReference): Drop the use of the
21312 Store function that depended on the variable index.
21314 * statement.cs (VariableInfo): Drop the `Idx' property from this
21315 class, as this is not taking into account the indexes for
21316 temporaries tat we generate during the execution, getting the
21319 * class.cs: First emit class initializers, then call the parent
21322 * expression.cs (Binary): Fix opcode emision.
21323 (UnaryMutator.EmitCode): Support checked code generation
21325 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
21326 matches for events for both the Static and Instance scans,
21327 pointing to the same element. Fix that.
21329 2002-03-14 Miguel de Icaza <miguel@ximian.com>
21331 * rootcontext.cs (ResolveTree): Always set the
21332 interface_resolve_order, because nested interfaces will be calling
21335 * class.cs (GetInterfaceOrClass): Track the same resolution
21336 process used by TypeManager.LookupType. This fixes the nested
21337 type lookups in class declarations (separate path from
21340 (TypeContainer.DefineType): Also define nested interfaces.
21341 (TypeContainer.RegisterOrder): New public function used to
21342 register the order in which child interfaces need to be closed.
21344 Nested interfaces need to be closed after their parents have been
21347 * interface.cs (InterfaceAttr): Put all the logic for computing
21348 the interface attribute here.
21350 (DefineInterface): Register our interface order with the
21351 RootContext or with the TypeContainer depending on the case.
21353 2002-03-12 Miguel de Icaza <miguel@ximian.com>
21355 * cs-parser.jay: rework foreach statement to work with the new
21356 changes to the policy on SimpleNames.
21358 * report.cs: support Stacktrace on warnings as well.
21360 * makefile: drop --unsafe and /unsafe from the compile.
21362 2002-03-13 Ravi Pratap <ravi@ximian.com>
21364 * ecore.cs (StandardConversionExists): Modify to take an Expression
21365 as the first parameter. Ensure we do null -> reference type conversion
21368 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
21369 temporary Expression objects.
21371 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
21373 * interface.cs: workaround bug in method overloading resolution
21374 (there is already a bugzilla bug for it).
21376 2002-03-12 Miguel de Icaza <miguel@ximian.com>
21378 We could also solve this problem by having a separate path for
21379 performing type lookups, instead of DoResolve, we could have a
21380 ResolveType entry point, and only participating pieces of the
21381 production (simplename, deref, array) would implement this.
21383 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
21384 signal SimpleName to only resolve type names and not attempt to
21385 resolve anything else.
21387 * expression.cs (Cast): Set the flag.
21389 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
21391 * class.cs: Only report 108 if there is no `new' modifier.
21393 * cs-parser.jay: rework foreach statement to work with the new
21394 changes to the policy on SimpleNames.
21396 * report.cs: support Stacktrace on warnings as well.
21398 * makefile: drop --unsafe and /unsafe from the compile.
21400 2002-03-11 Miguel de Icaza <miguel@ximian.com>
21402 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
21403 lookups here, instead of doing that at parse time. This means
21404 that our grammar will not introduce `LocalVariableReferences' as
21405 expressions at this point. That solves the problem of code like
21409 static void Main ()
21413 This is only half the fix. The full fix requires parameters to
21414 also be handled in this way.
21416 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
21417 makes the use more obvious of the DeclSpace. The
21418 ec.TypeContainer.TypeBuilder is now only used to pull the
21419 TypeBuilder for it.
21421 My theory is that I can get rid of the TypeBuilder completely from
21422 the EmitContext, and have typecasts where it is used (from
21423 DeclSpace to where it matters).
21425 The only pending problem is that the code that implements Aliases
21426 is on TypeContainer, and probably should go in DeclSpace.
21428 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
21429 lookups here, instead of doing that at parse time. This means
21430 that our grammar will not introduce `LocalVariableReferences' as
21431 expressions at this point. That solves the problem of code like
21435 static void Main ()
21439 This is only half the fix. The full fix requires parameters to
21440 also be handled in this way.
21442 * class.cs (Property.DefineMethod): When implementing an interface
21443 method, set newslot, when implementing an abstract method, do not
21444 set the flag (before we tried never setting it, or always setting
21445 it, which is the difference).
21446 (Indexer.DefineMethod): same.
21447 (Method.DefineMethod): same.
21449 * ecore.cs: Only set the status used flag if we get back a Field.
21451 * attribute.cs: Temporary hack, so Paolo can keep working.
21453 2002-03-08 Ravi Pratap <ravi@ximian.com>
21455 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
21456 the unmanaged type in the case we have a MarshalAs attribute.
21458 (Resolve): Handle the case when we are parsing the special MarshalAs
21459 attribute [we need to store the unmanaged type to use later]
21461 * typemanager.cs (marshal_as_attr_type): Built in type for the
21462 MarshalAs Attribute.
21464 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
21465 on parameters and accordingly set the marshalling info.
21467 2002-03-09 Miguel de Icaza <miguel@ximian.com>
21469 * class.cs: Optimizing slightly by removing redundant code after
21470 we switched to the `NoTypes' return value.
21471 (Property.DefineMethod): use NoTypes here too.
21473 This fixes the bug I introduced in my last batch of changes.
21475 2002-03-05 Ravi Pratap <ravi@ximian.com>
21477 * tree.cs (RecordEnum): Add. We now keep track of enums too.
21479 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
21480 Enums since those are types too.
21482 * cs-parser.jay (enum_declaration): Record enums as we parse them.
21484 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
21485 thanks to a call during the lookup process.
21487 2002-03-07 Miguel de Icaza <miguel@ximian.com>
21489 * statement.cs (Foreach): Lots of work to accomodate a particular
21490 kind of foreach statement that I had not kept in mind. It is
21491 possible to have foreachs on classes that provide a GetEnumerator
21492 method that return objects that implement the "pattern" for using
21493 a foreach, there is no need to support GetEnumerator
21496 This is needed to compile nant.
21498 * decl.cs: Only report 114 if the member is not `Finalize' and if
21499 the warning level is at least 2.
21501 * class.cs: Moved the compare function from Method to
21504 (MethodSignature.InheritableMemberSignatureCompare): Add new
21505 filter function that is used to extract inheritable methods from a
21508 (Method.Define): Use the new `inheritable_method_signature_filter'
21511 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
21514 2002-03-06 Miguel de Icaza <miguel@ximian.com>
21516 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
21518 * cs-parser.jay: Add opt_semicolon to the interface declaration.
21520 * expression.cs: Pass location information to
21521 ConvertImplicitStandard.
21523 * class.cs: Added debugging code to track return values from
21526 2002-03-05 Miguel de Icaza <miguel@ximian.com>
21528 * expression.cs (Is.DoResolve): If either side of the `is' is an
21529 interface, do not flag the warning.
21531 * ecore.cs (ImplicitReferenceConversion): We need a separate test
21534 * report.cs: Allow for --fatal to be used with --probe.
21536 * typemanager.cs (NoTypes): Move the definition for the empty Type
21539 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
21541 (TypeContainer.DefineProxy): New function used to proxy to parent
21542 implementations when implementing interfaces.
21543 (TypeContainer.ParentImplements): used to lookup if our parent
21544 implements a public function that is required by an interface.
21545 (TypeContainer.VerifyPendingMethods): Hook this up.
21547 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
21548 `modules' and `assemblies' arraylists into arrays. We only grow
21549 these are the very early start up of the program, so this improves
21550 the speedof LookupType (nicely measured).
21552 * expression.cs (MakeByteBlob): Replaced unsafe code with
21553 BitConverter, as suggested by Paolo.
21555 * cfold.cs (ConstantFold.Binary): Special case: perform constant
21556 folding of string concatenation, but if either side is a string,
21557 and the other is not, then return null, and let the runtime use
21558 the concatenation on the string plus the object (using
21559 `Object.ToString').
21561 2002-03-04 Miguel de Icaza <miguel@ximian.com>
21563 Constant Folding has been implemented now.
21565 * expression.cs (Unary.Reduce): Do not throw an exception, catch
21566 the error instead on types that are not supported in one's
21569 * constant.cs (Constant and all children): New set of functions to
21570 perform implict and explicit conversions.
21572 * ecore.cs (EnumConstant): Implement the new functions to perform
21573 conversion by proxying to the child expression.
21575 * codegen.cs: (ConstantCheckState): Constant evaluation has its
21576 own separate setting that can not be turned off from the command
21577 line using --unchecked or --checked and is only controlled using
21578 the checked/unchecked statements and expressions. This setting is
21579 used by the constant folder to flag errors.
21581 * expression.cs (CheckedExpr, UncheckedExpr): Set the
21582 ConstantCheckState as well.
21584 During Resolve, they also have to flag the state, because the
21585 constant folder runs completely in the Resolve phase.
21587 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
21590 2002-03-01 Miguel de Icaza <miguel@ximian.com>
21592 * cfold.cs: New file, this file contains the constant folder.
21594 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
21595 argument to track whether we are using the resulting address to
21596 load or store a value and provide better error messages.
21598 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
21599 new AddressOf arguments.
21601 * statement.cs (Foreach.EmitCollectionForeach): Update
21603 * expression.cs (Argument.Emit): Call AddressOf with proper
21604 arguments to track usage.
21606 (New.DoEmit): Call AddressOf with new arguments.
21608 (Unary.Emit): Adjust AddressOf call.
21610 2002-03-01 Ravi Pratap <ravi@ximian.com>
21612 * cs-parser.jay (member_access): Change the case for pre-defined types
21613 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
21616 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
21619 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
21620 essentially like methods and apply attributes like MethodImplOptions to them too.
21622 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
21625 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
21626 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
21629 * Update code everywhere accordingly.
21631 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
21633 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
21635 2002-02-28 Ravi Pratap <ravi@ximian.com>
21637 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
21638 try performing lookups against those instead of jumping straight into using
21639 the 'using' clauses.
21641 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
21643 (LookupType): Perform lookups in implicit parents too.
21645 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
21646 sequence as RootContext.LookupType.
21648 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
21649 the various cases of namespace lookups into this method.
21651 2002-03-01 Miguel de Icaza <miguel@ximian.com>
21653 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
21654 in positional arguments)
21656 * class.cs (Operator): Update the AllowedModifiers to contain
21659 * cs-parser.jay: Update operator declaration to allow for the
21660 operator body to be empty.
21662 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
21665 2002-02-27 Miguel de Icaza <miguel@ximian.com>
21667 * class.cs (Method.Emit): Label parameters.
21669 * driver.cs: Return 1 or 0 as the program exit code.
21671 2002-02-26 Miguel de Icaza <miguel@ximian.com>
21673 * expression.cs: Special case the `null' object when trying to
21674 auto-compute the type, as anything can be explicitly converted to
21677 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
21678 spotting this Paolo.
21680 (Expression.ImplicitNumericConversion): Perform comparissions of
21681 the type using the underlying type in the case of an enumeration
21682 rather than using the enumeration type for the compare.
21684 Cope with the underlying == type case, which is not possible to
21687 (Expression.ConvertNumericExplicit): Perform comparissions of
21688 the type using the underlying type in the case of an enumeration
21689 rather than using the enumeration type for the compare.
21691 * driver.cs: If the user does not supply an extension, assume .exe
21693 * cs-parser.jay (if_statement): Rewrote so that we can track the
21694 location for the if statement.
21696 * expression.cs (Binary.ConstantFold): Only concat strings when
21697 the operation is "+", not everything ;-)
21699 * statement.cs (Statement.EmitBoolExpression): Take a location
21701 (If, While, Do): Track location.
21703 * expression.cs (Binary.ResolveOperator): In the object + string
21704 case, I was missing a call to ConvertImplicit
21706 2002-02-25 Ravi Pratap <ravi@ximian.com>
21708 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
21709 Location arguments. Ensure we use RootContext.LookupType to do our work
21710 and not try to do a direct Type.GetType and ModuleBuilder.GetType
21712 * interface.cs (PopulateMethod): Handle the type of the parameter being
21715 * expression.cs (Invocation.BetterFunction): Handle the case when we
21716 have a params method with no fixed arguments and a call is made with no
21719 2002-02-25 Miguel de Icaza <miguel@ximian.com>
21721 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
21722 the verbatim-string-literal
21724 * support.cs (InternalParameters.ParameterModifier): handle null
21726 (InternalParameters.ParameterType): ditto.
21728 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
21729 duplicating the name of the variable parameter.
21730 (GetParameterByName): Fix bug where we were not looking up array
21731 paramters if they were the only present (thanks Paolo!).
21732 (GetParameterInfo): We only have an empty set of types if both
21733 fixed and array are set to null.
21734 (GetParameterInfo-idx): Handle FixedParameter == null
21736 * cs-parser.jay: Handle the case where there is no catch
21737 statements (missing null test).
21739 2002-02-22 Miguel de Icaza <miguel@ximian.com>
21741 * driver.cs (MainDriver): Be conservative on our command line
21744 Catch DirectoryNotFoundException when calling GetFiles.
21746 (SplitPathAndPattern): Used to split the input specification into
21747 a path and a pattern that we can feed to Directory.GetFiles.
21749 2002-02-21 Miguel de Icaza <miguel@ximian.com>
21751 * statement.cs (Fixed): Implement the last case of the Fixed
21752 statement (string handling).
21754 * expression.cs (StringPtr): New class used to return a char * to
21755 a string; Used by the Fixed statement.
21757 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
21759 * expression.cs (Binary.ResolveOperator): Remove redundant
21760 MemberLookup pn parent type.
21761 Optimize union call, we do not need a union if the types are the same.
21762 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
21765 Specialize the use of MemberLookup everywhere, instead of using
21766 the default settings.
21768 (StackAlloc): Implement stackalloc keyword.
21770 * cs-parser.jay: Add rule to parse stackalloc.
21772 * driver.cs: Handle /h, /help, /?
21774 * expression.cs (MakeByteBlob): Removed the hacks we had in place
21775 before we supported unsafe code.
21777 * makefile: add --unsafe to the self compilation of mcs.
21779 2002-02-20 Miguel de Icaza <miguel@ximian.com>
21781 * expression.cs (PointerArithmetic): New class that is used to
21782 perform pointer arithmetic.
21783 (Binary.Resolve): Handle pointer arithmetic
21784 Handle pointer comparission.
21785 (ArrayPtr): Utility expression class that is used to take the
21786 address of an array.
21788 (ElementAccess): Implement array access for pointers
21790 * statement.cs (Fixed): Implement fixed statement for arrays, we
21791 are missing one more case before we are done.
21793 * expression.cs (Indirection): Implement EmitAssign and set the
21794 ExprClass to Variable. This allows pointer dereferences to be
21795 treated as variables, and to have values assigned to them.
21797 * ecore.cs (Expression.StoreFromPtr): New utility function to
21798 store values dereferencing.
21800 2002-02-20 Ravi Pratap <ravi@ximian.com>
21802 * expression.cs (Binary.ResolveOperator): Ensure that we are
21803 not trying to operate on a void type - this fixes the reported
21806 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
21807 the parent implementation is sealed.
21809 * ../errors/cs0239.cs : Add.
21811 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
21813 * typemanager.cs (unverifiable_code_type): Corresponds to
21814 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
21815 which have unsafe code in them.
21817 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
21820 2002-02-19 Miguel de Icaza <miguel@ximian.com>
21822 * cs-tokenizer.cs: Add support for @"litreal strings"
21824 Make tokenizer accept pre-processor directives
21825 on any column (remove the old C-like limitation).
21827 * rootcontext.cs (EmitCode): Emit any global attributes.
21828 (AddGlobalAttributes): Used to keep track of assembly attributes.
21830 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
21832 * cs-parser.jay: Add support for global attributes.
21834 2002-02-17 Miguel de Icaza <miguel@ximian.com>
21836 * expression.cs (Indirection): New helper class. Unary will
21837 create Indirection classes to be able to implement the
21838 IMemoryLocation interface on it.
21840 2002-02-16 Miguel de Icaza <miguel@ximian.com>
21842 * cs-parser.jay (fixed_statement): reference the right statement.
21844 * statement.cs (Fixed.Emit): Finish implementing the fixed
21845 statement for the &x case.
21847 2002-02-14 Miguel de Icaza <miguel@ximian.com>
21849 * class.cs (Property.Define, Method.Define): Remove newslot when
21852 * modifiers.cs: My use of NewSlot when `Abstract' was set was
21853 wrong. NewSlot should only be used if the `new' keyword is present.
21855 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
21856 locating our system dir. Sorry about this.
21858 2002-02-13 Miguel de Icaza <miguel@ximian.com>
21860 * driver.cs (GetSystemDir): Compute correctly the location of our
21861 system assemblies. I was using the compiler directory instead of
21862 the library directory.
21864 2002-02-13 Ravi Pratap <ravi@ximian.com>
21866 * expression.cs (BetterFunction): Put back in what Miguel commented out
21867 since it is the correct fix. The problem is elsewhere ;-)
21869 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
21870 parameters of the parms method are themselves compatible or not !
21872 (StandardConversionExists): Fix very dangerous bug where we were forgetting
21873 to check that a class implements an interface before saying that an implicit
21874 conversion was allowed. Use ImplementsInterface to do the checking.
21876 2002-02-13 Miguel de Icaza <miguel@ximian.com>
21878 * class.cs (Method.Define): Track whether we are an explicit
21879 implementation or not. And only call DefineMethodOverride if we
21880 are an explicit implementation.
21882 (Property.DefineMethod): Ditto.
21884 2002-02-11 Ravi Pratap <ravi@ximian.com>
21886 * expression.cs (BetterFunction): Catch hideous bug which was
21887 preventing us from detecting ambiguous calls due to implicit casts i.e
21890 2002-01-29 Miguel de Icaza <miguel@ximian.com>
21892 * support.cs (Pair): Remove un-needed method. I figured why I was
21893 getting the error in cs-parser.jay, the variable in a foreach loop
21894 is readonly, and the compiler does not really treat this as a variable.
21896 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
21897 instead of EQUALS in grammar.
21899 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
21901 * expression.cs (Unary.DoResolve): Check whether the argument is
21904 2002-01-28 Miguel de Icaza <miguel@ximian.com>
21906 * support.cs: Api for Pair to set a value. Despite the fact that
21907 the variables are public the MS C# compiler refuses to compile
21908 code that accesses the field if the variable is part of a foreach
21911 * statement.cs (Fixed): Begin implementation of the fixed
21914 (Block.AddVariable): Return the VariableInfo on success and null
21915 on failure instead of true/false.
21917 * cs-parser.jay (foreach): Catch errors on variables already
21918 defined (we were ignoring this value before) and properly unwind
21919 the block hierarchy
21921 (fixed_statement): grammar for the fixed statement.
21923 2002-01-25 Miguel de Icaza <miguel@ximian.com>
21925 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
21926 pointer types to be incretemented.
21928 (SizeOf): Implement.
21930 * cs-parser.jay (pointer_member_access): Implement
21931 expr->IDENTIFIER production.
21933 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
21934 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
21937 (Unary): Implement indirection.
21939 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
21940 use in non-unsafe context).
21942 (SimpleName.DoResolve): Check for pointers in field access on safe
21945 (Expression.LoadFromPtr): Factor the load-indirect code in this
21946 function. This was duplicated in UnboxCast and ParameterReference
21948 2002-01-24 Miguel de Icaza <miguel@ximian.com>
21950 * expression.cs (ComposedCast): report an error if a pointer cast
21951 is used in a safe region.
21953 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
21954 pointer type casts in unsafe context.
21956 * codegen.cs (EmitContext): Set up IsUnsafe.
21958 * cs-parser.jay (non_expression_type): Add productions for pointer
21961 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
21962 code. We should not use force into static mode if the method is
21963 not virtual. Fixes bug in MIS
21965 * statement.cs (Do.Emit, While.Emit, For.Emit,
21966 Statement.EmitBoolExpression): Add support to Do and While to
21967 propagate infinite loop as `I do return' semantics.
21969 Improve the For case to also test for boolean constants.
21971 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
21972 to the list of attributes we can add.
21974 Remove `EmitContext' argument.
21976 * class.cs (Method.Define): Apply parameter attributes.
21977 (Constructor.Define): Apply parameter attributes.
21978 (MethodCore.LabelParameters): Move here the core of labeling
21981 * support.cs (ReflectionParameters.ParameterModifier,
21982 InternalParameters.ParameterModifier): Use IsByRef on the type and
21983 only return the OUT bit for these parameters instead of in/out/ref
21986 This is because I miss-understood things. The ParameterInfo.IsIn
21987 and IsOut represent whether the parameter has the [In] and [Out]
21990 2002-01-22 Miguel de Icaza <miguel@ximian.com>
21992 * ecore.cs (FieldExpr.Emit): Release temporaries.
21994 * assign.cs (LocalTemporary.Release): new function.
21996 * codegen.cs (EmitContext.GetTemporaryStorage,
21997 EmitContext.FreeTemporaryStorage): Rework the way we deal with
21998 temporary storage. Now we can "put back" localbuilders when we
22001 2002-01-21 Miguel de Icaza <miguel@ximian.com>
22003 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
22004 need to make a copy of the variable to generate verifiable code.
22006 2002-01-19 Miguel de Icaza <miguel@ximian.com>
22008 * driver.cs: Compute dynamically the system directory.
22010 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
22011 Slower, but more generally useful. Used by the abstract
22012 registering implementation.
22014 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
22015 the rules for the special rule on Type/instances. First check if
22016 we have the same name, and if so, try that special static path
22017 rather than the instance path.
22019 2002-01-18 Miguel de Icaza <miguel@ximian.com>
22021 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
22024 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
22025 Enum, ValueType, Delegate or Array for non-corlib compiles.
22027 * cs-tokenizer.cs: Catch long identifiers (645)
22029 * typemanager.cs (IndexerPropetyName): Ravi never tested this
22032 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
22033 fix, we were returning too early, so we were not registering
22034 pending methods from abstract classes.
22036 Do not register pending methods if the class is abstract.
22038 * expression.cs (Conditional.DoResolve): Report circular implicit
22039 conversions when we neecd to compute it for conditional
22042 (Is.DoResolve): If the expression is always of the provided type,
22043 flag warning 183. If the expression can not ever be of the
22044 provided type flag warning 184.
22046 * class.cs: Catch 169 as well.
22048 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
22051 2002-01-18 Nick Drochak <ndrochak@gol.com>
22053 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
22055 2002-01-17 Miguel de Icaza <miguel@ximian.com>
22057 * interface.cs: (PopulateMethod): Check for pointers being defined
22058 only if the unsafe context is active.
22059 (PopulateProperty): ditto.
22060 (PopulateIndexer): ditto.
22062 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
22063 specified. If pointers are present, make sure that they are
22064 present in an unsafe context.
22065 (Constructor, Constructor.Define): ditto.
22066 (Field, Field.Define): ditto.
22067 (Property, Property.Define): ditto.
22068 (Event, Event.Define): ditto.
22070 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
22071 hashtable if there are classes or structs defined.
22073 * expression.cs (LocalVariableReference.DoResolve): Simplify this
22074 code, as the constant resolution moved.
22076 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
22077 the metadata, so we can flag error 133.
22079 * decl.cs (MemberCore.UnsafeOK): New function to test that a
22080 pointer is being declared in an unsafe context.
22082 2002-01-16 Miguel de Icaza <miguel@ximian.com>
22084 * modifiers.cs (Modifiers.Check): Require a Location argument.
22085 Report error 227 for Unsafe use.
22087 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
22089 * statement.cs (For.Emit): If the test is null, then report that
22090 we do `return', as we wont reach anything afterwards.
22092 (Switch.SwitchGoverningType): Track the expression that matched
22095 * driver.cs: Allow negative numbers as an error code to flag.
22097 * cs-parser.jay: Handle 1551.
22099 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
22101 2002-01-15 Miguel de Icaza <miguel@ximian.com>
22103 * cs-parser.jay: Report 1518 (type declaration can only contain
22104 class, struct, interface, enum or delegate)
22106 (switch_label): Report 1523 (keywords `case' or `default' must
22109 (opt_switch_sections): Report 1522 (empty switch)
22111 * driver.cs: Report 1515 (response file specified multiple times)
22112 Report 1516 (Source file specified multiple times).
22114 * expression.cs (Argument.Resolve): Signal 1510
22116 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
22117 access not allowed in static code)
22119 2002-01-11 Ravi Pratap <ravi@ximian.com>
22121 * typemanager.cs (IsPointerType): Utility method which we are going
22124 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
22125 the object type, so we take care of that.
22127 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
22129 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
22130 added to non-params parameters :-)
22132 * typemanager.cs (CSharpName): Include 'void' type too.
22134 (void_ptr_type): Include in the set of core types.
22136 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
22139 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
22142 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
22143 completely forgotten about it.
22145 2002-01-10 Ravi Pratap <ravi@ximian.com>
22147 * cs-parser.jay (pointer_type): Add. This begins our implementation
22148 of parsing rules for unsafe code.
22150 (unsafe_statement): Implement.
22152 (embedded_statement): Modify to include the above.
22154 * statement.cs (Unsafe): Implement new class for unsafe blocks.
22156 * codegen.cs (EmitContext.InUnsafe): Add. This determines
22157 if the current context is an unsafe one.
22159 * cs-parser.jay (local_variable_pointer_type): Since local variable types
22160 are handled differently, we need separate rules for them.
22162 (local_variable_declaration): Update to use local_variable_pointer_type
22163 to allow variable declarations of unmanaged pointer types.
22165 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
22166 in unsafe contexts.
22168 * ../errors/cs0214.cs : Add.
22170 2002-01-16 Nick Drochak <ndrochak@gol.com>
22172 * makefile: remove 'response' file when cleaning.
22174 2002-01-15 Miguel de Icaza <miguel@ximian.com>
22176 * cs-parser.jay: Report 1524.
22178 2002-01-14 Miguel de Icaza <miguel@ximian.com>
22180 * typemanager.cs (RegisterMethod): drop checking if we have
22181 registered this from here
22183 2002-01-12 Miguel de Icaza <miguel@ximian.com>
22185 * class.cs (Method.EmitDestructor): Implement calling our base
22188 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
22189 value of InFinally.
22191 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
22192 this routine and will wrap the call in a try/catch block. Deal
22195 2002-01-11 Miguel de Icaza <miguel@ximian.com>
22197 * ecore.cs (Expression.MemberLookup): instead of taking a
22198 parameter `same_type' that was used to tell whether we could
22199 access private members we compute our containing type from the
22202 (FieldExpr): Added partial support for volatile fields. This does
22203 not work for volatile fields exposed from assemblies, as I can not
22204 figure out how to extract the modreq from it.
22206 Updated all the source files to use this.
22208 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
22209 because it is referenced by MemberLookup very often.
22211 2002-01-09 Ravi Pratap <ravi@ximian.com>
22213 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
22214 TypeBuilder.GetCustomAttributes to retrieve what we need.
22216 Get rid of redundant default_member_attr_type as this is the same as
22217 default_member_type which already exists.
22219 * interface.cs, attribute.cs : Update accordingly.
22221 2002-01-08 Miguel de Icaza <miguel@ximian.com>
22223 * typemanager.cs: Enable IndexerPropertyName again. It does not
22224 work for TYpeBuilders though. Ravi, can you please fix this?
22226 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
22228 * expression.cs (Argument.Emit): Handle the case of ref objects
22229 being passed to ref functions;
22231 (ParameterReference.EmitLoad): Loads the content of the pointer
22232 without dereferencing.
22234 2002-01-07 Miguel de Icaza <miguel@ximian.com>
22236 * cs-tokenizer.cs: Implemented the pre-processing expressions.
22238 2002-01-08 Ravi Pratap <ravi@ximian.com>
22240 * class.cs (Indexer.DefineMethod): Incorporate the interface
22241 type in the name of the method if we are doing explicit interface
22244 * expression.cs (ConversionExists): Remove as it is completely obsolete.
22246 (BetterConversion): Fix extremely trivial bug where we were referring to
22247 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
22250 * ../errors/bug16.cs : Add although we have fixed it.
22252 2002-01-07 Miguel de Icaza <miguel@ximian.com>
22254 * expression.cs (BaseIndexer): Begin implementation.
22256 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
22258 * cs-parser.jay (indexer_declarator): Use qualified_identifier
22259 production directly to remove a shift/reduce, and implement
22260 explicit interface implementation.
22262 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
22263 after a floating point suffix.
22265 * expression.cs (DoNumericPromotions): Improved the conversion for
22266 uint/uint. If we have a constant, we avoid doing a typecast to a
22269 * class.cs (Indexer): Implement explicit interface implementation
22272 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
22274 * class.cs: make the default instance constructor public and hidebysig.
22276 2001-01-03 Ravi Pratap <ravi@ximian.com>
22278 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
22279 so we can call it from elsewhere.
22281 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
22282 we emit it internally if the class has a defined indexer; otherwise the user
22283 emits it by decorating the class definition with the DefaultMemberAttribute.
22285 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
22286 attribute is not used on a type which defines an indexer.
22288 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
22289 character when we skip whitespace.
22291 * ../errors/cs0646.cs : Add.
22293 2002-01-03 Miguel de Icaza <miguel@ximian.com>
22295 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
22298 * makefile: Add practical target `mcs3.exe' which builds the third
22299 generation compiler.
22301 * expression.cs (New): Fix structures constructor calling.
22303 * class.cs (Property, Method, Indexer): Emit Final flag on the
22304 method if we are an interface implementation and we are not
22307 * ecore.cs (PropertyExpr): New public field `IsBase', tells
22308 whether this property is referencing a `base' method.
22310 * expression.cs (Invocation.EmitCall): take an extra argument:
22311 is_base, this is used to determine whether the `call' or
22312 `callvirt' opcode should be used.
22315 * delegate.cs: update EmitCall.
22317 * class.cs (Method.Define): Set NewSlot for the cases where we are
22318 not implementing an interface method.
22320 (Property.Define): ditto.
22322 2002-01-02 Miguel de Icaza <miguel@ximian.com>
22324 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
22325 'r'. Allows mcs to parse itself fully.
22327 2002-01-02 Ravi Pratap <ravi@ximian.com>
22329 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
22330 of the number of initializers that require the InitializeArray method.
22332 (CheckIndices): Store the Expression in all cases - not the plain value. Also
22333 update the above field where necessary.
22335 (MakeByteBlob): Update accordingly.
22337 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
22340 (EmitDynamicInitializers): Update in accordance with the new optimization.
22342 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
22343 same OpCode applies.
22345 * cs-parser.jay : Fix some glaring errors I introduced.
22347 2002-01-01 Ravi Pratap <ravi@ximian.com>
22349 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
22350 so that we can check for name clashes there too.
22352 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
22353 for interface indexers.
22355 * interfaces.cs (Define): Emit the default member attribute.
22357 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
22358 variable was being referred to while setting the value ;-)
22360 2002-01-01 Miguel de Icaza <miguel@ximian.com>
22362 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
22363 byte-by-byte information when we know the data is zero.
22365 Make the block always a multiple of 4, because
22366 DefineInitializedData has a bug.
22368 * assign.cs: Fix, we should assign from the temporary, not from
22371 * expression.cs (MakeByteBlob): Fix my incorrect code.
22373 2001-12-31 Miguel de Icaza <miguel@ximian.com>
22375 * typemanager.cs (EnumToUnderlying): This function is used to get
22376 the underlying type from an enumeration, because it does not
22379 * constant.cs: Use the I4_S form for values between -128 and 127.
22381 * statement.cs (Block.LookupLabel): Looks up a label.
22382 (Block): Drop support for labeled blocks.
22384 (LabeledStatement): New kind of statement that represents a label
22387 (Goto): Finally implement this bad boy.
22389 * cs-parser.jay: Update to reflect new mechanism to implement
22392 2001-12-30 Miguel de Icaza <miguel@ximian.com>
22394 * codegen.cs (EmitContext.This): a codegen property that keeps the
22395 a single instance of this instead of creating many different this
22398 * delegate.cs (Delegate.DoResolve): Update to use the property;
22400 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
22402 * expression.cs (BaseAccess.DoResolve): Ditto.
22404 2001-12-29 Ravi Pratap <ravi@ximian.com>
22406 * typemanager.cs (methodimpl_attr_type): Add to hold the type
22407 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
22409 (InitCoreTypes): Update accordingly.
22411 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
22412 so we can quickly store the state.
22414 (ApplyAttributes): Set the correct implementation flags
22415 for InternalCall methods.
22417 2001-12-29 Miguel de Icaza <miguel@ximian.com>
22419 * expression.cs (EmitCall): if a method is not virtual, then do
22420 not use callvirt on it.
22422 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
22423 user defined stuff) requires the use of stobj, which takes an
22424 address on the stack instead of an array and an index. So emit
22425 the Ldelema operation for it.
22427 (EmitStoreOpcode): Use stobj for valuetypes.
22429 (UnaryMutator.EmitCode): Use the right 1 value depending on
22430 whether we are dealing with int64/uint64, float or doubles.
22432 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
22433 constructors that I implemented last night.
22435 (Constructor.IsDefault): Fix to work properly for static
22438 * cs-parser.jay (CheckDef): report method signature errors.
22439 Update error number 103 to be 132.
22441 * decl.cs: New AdditionResult enumeration value: MethodExists.
22442 Although we do this check for methods later on in the semantic
22443 analysis, catching repeated default constructors is so easy that
22444 we catch these here.
22446 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
22449 (ParameterReference.EmitAssign, Emit): handle
22452 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
22453 (ArrayAccess.EmitStoreOpcode): ditto.
22455 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
22457 * expression.cs (MakeByteBlob): Complete all the missing types
22458 (uint, short, ushort, byte, sbyte)
22460 * class.cs: Only init instance field initializers on instance
22463 Rename `constructors' to instance_constructors.
22465 (TypeContainer.AddConstructor): Only add constructors to the list
22466 if it is not static.
22468 Make sure that we handle default_static_constructor independently
22469 everywhere where we handle instance_constructors
22471 2001-12-28 Miguel de Icaza <miguel@ximian.com>
22473 * class.cs: Do not lookup or create a base initializer for a
22474 static constructor.
22476 (ConstructorInitializer.Resolve): use the proper type to lookup
22479 * cs-parser.jay: Report error 1585 (modifiers between type and name).
22481 * enum.cs, interface.cs: Remove CloseType, this is taken care by
22484 * decl.cs: CloseType is now an virtual method, the default
22485 implementation just closes this type.
22487 2001-12-28 Ravi Pratap <ravi@ximian.com>
22489 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
22490 to PreserveSig by default. Also emit HideBySig on such methods.
22492 Basically, set the defaults to standard values.
22494 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
22495 argument, if candidate is better, it can't be worse than the best !
22497 (Invocation): Re-write bits to differentiate between methods being
22498 applicable in their expanded form and their normal form - for params
22501 Get rid of use_standard everywhere as only standard conversions are allowed
22502 in overload resolution.
22504 More spec conformance.
22506 2001-12-27 Miguel de Icaza <miguel@ximian.com>
22508 * driver.cs: Add --timestamp, to see where the compiler spends
22511 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
22512 `this' in static code.
22514 (SimpleName.DoResolve): Implement in terms of a helper function
22515 that allows static-references to be passed upstream to
22518 (Expression.ResolveWithSimpleName): Resolve specially simple
22519 names when called by MemberAccess to implement the special
22522 (Expression.ImplicitReferenceConversion): Handle conversions from
22523 Null to reference types before others, as Null's type is
22526 * expression.cs (Invocation.EmitCall): Handle the special case of
22527 calling methods declared on a reference type from a ValueType
22528 (Base classes System.Object and System.Enum)
22530 (MemberAccess.Resolve): Only perform lookups on Enumerations if
22531 the left hand side is a TypeExpr, not on every enumeration.
22533 (Binary.Resolve): If types are reference types, then do a cast to
22534 object on operators != and == of both arguments.
22536 * typemanager.cs (FindMembers): Extract instance and static
22537 members if requested.
22539 * interface.cs (PopulateProperty): Use void_type instead of null
22540 as the return type for the setter method.
22542 (PopulateIndexer): ditto.
22544 2001-12-27 Ravi Pratap <ravi@ximian.com>
22546 * support.cs (ReflectionParameters): Fix minor bug where we
22547 were examining the wrong parameter for the ParamArray attribute.
22549 Cope with requests for the type of the parameter at position
22550 greater than the params parameter's. We now return the element
22551 type of the params array as that makes more sense.
22553 * expression.cs (Invocation.IsParamsMethodApplicable): Update
22554 accordingly as we no longer have to extract the element type
22557 (Invocation.OverloadResolve): Update.
22559 2001-12-27 Miguel de Icaza <miguel@ximian.com>
22561 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
22562 against IEnumerator, test whether the return value is a descendant
22563 of the IEnumerator interface.
22565 * class.cs (Indexer.Define): Use an auxiliary method to implement
22566 the other bits of the method definition. Begin support for
22567 explicit interface implementation.
22569 (Property.DefineMethod): Use TypeManager.void_type instead of null
22570 for an empty return value.
22572 2001-12-26 Miguel de Icaza <miguel@ximian.com>
22574 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
22575 dealing with a FieldExpr which is composed of a FieldBuilder, in
22576 the code path we did extract the constant, but we should have
22577 obtained the underlying value to be able to cast it (otherwise we
22578 end up in an infinite loop, this is what Ravi was running into).
22580 (ArrayCreation.UpdateIndices): Arrays might be empty.
22582 (MemberAccess.ResolveMemberAccess): Add support for section
22583 14.5.4.1 that deals with the special case of E.I when E is a type
22584 and something else, that I can be a reference to a static member.
22586 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
22587 handle a particular array type to create byte blobs, it is just
22588 something we dont generate byteblobs for.
22590 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
22593 * location.cs (Push): remove the key from the hashtable that we
22594 are about to add. This happens for empty files.
22596 * driver.cs: Dispose files after we have parsed them.
22598 (tokenize): new function that only runs the tokenizer on its
22599 input, for speed testing.
22601 2001-12-26 Ravi Pratap <ravi@ximian.com>
22603 * class.cs (Event.Define): Define the private field only if there
22604 are no accessors defined.
22606 * expression.cs (ResolveMemberAccess): If there is no associated
22607 field with the event, that means we have an event defined with its
22608 own accessors and we should flag error cs0070 since transforming
22609 ourselves into a field is not valid in that case.
22611 * ecore.cs (SimpleName.DoResolve): Same as above.
22613 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
22614 and charset to sane values.
22616 2001-12-25 Ravi Pratap <ravi@ximian.com>
22618 * assign.cs (DoResolve): Perform check on events only if they
22619 are being accessed outside the declaring type.
22621 * cs-parser.jay (event_declarations): Update rules to correctly
22622 set the type of the implicit parameter etc.
22624 (add_accessor, remove_accessor): Set current local parameters.
22626 * expression.cs (Binary): For delegate addition and subtraction,
22627 cast the return value from the method into the appropriate delegate
22630 2001-12-24 Ravi Pratap <ravi@ximian.com>
22632 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
22633 of these as the workaround is unnecessary.
22635 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
22636 delegate data - none of that is needed at all.
22638 Re-write bits to extract the instance expression and the delegate method
22641 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
22644 * attribute.cs (ApplyAttributes): New method to take care of common tasks
22645 of attaching attributes instead of duplicating code everywhere.
22647 * everywhere : Update code to do attribute emission using the above method.
22649 2001-12-23 Miguel de Icaza <miguel@ximian.com>
22651 * expression.cs (IsParamsMethodApplicable): if there are not
22652 parameters, return immediately.
22654 * ecore.cs: The 0 literal can be implicity converted to an enum
22657 (SimpleName.DoResolve): First lookup the type, then lookup the
22660 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
22661 want to get its address. If the InstanceExpression is not
22662 addressable, store the result in a temporary variable, then get
22665 * codegen.cs: Only display 219 errors on warning level or above.
22667 * expression.cs (ArrayAccess): Make it implement the
22668 IMemoryLocation interface.
22670 (Binary.DoResolve): handle the operator == (object a, object b)
22671 and operator != (object a, object b) without incurring into a
22672 BoxedCast (because 5 != o should never be performed).
22674 Handle binary enumerator operators.
22676 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
22677 value type, otherwise use Ldelem_ref.
22679 Use precomputed names;
22681 (AddressOf): Implement address of
22683 * cs-parser.jay (labeled_statement): Fix recursive block
22684 addition by reworking the production.
22686 * expression.cs (New.DoEmit): New has a special case:
22688 If we are dealing with a ValueType, we have a few
22689 situations to deal with:
22691 * The target of New is a ValueType variable, that is
22692 easy, we just pass this as the variable reference
22694 * The target of New is being passed as an argument,
22695 to a boxing operation or a function that takes a
22698 In this case, we need to create a temporary variable
22699 that is the argument of New.
22702 2001-12-23 Ravi Pratap <ravi@ximian.com>
22704 * rootcontext.cs (LookupType): Check that current_type is not null before
22705 going about looking at nested types.
22707 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
22708 not implement the IAssignMethod interface any more.
22710 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
22711 where we tranform them into FieldExprs if they are being resolved from within
22712 the declaring type.
22714 * ecore.cs (SimpleName.DoResolve): Do the same here.
22716 * assign.cs (DoResolve, Emit): Clean up code considerably.
22718 * ../errors/bug10.cs : Add.
22720 * ../errors/cs0070.cs : Add.
22722 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
22724 * assign.cs : Get rid of EventIsLocal everywhere.
22726 2001-12-23 Miguel de Icaza <miguel@ximian.com>
22728 * ecore.cs (ConvertIntLiteral): finished the implementation.
22730 * statement.cs (SwitchLabel): Convert the value we are using as a
22731 key before looking up the table.
22733 2001-12-22 Miguel de Icaza <miguel@ximian.com>
22735 * codegen.cs (EmitTopBlock): Require a Location argument now.
22737 * cs-parser.jay (constructor_declarator): We need to setup
22738 current_local_parameters before we parse the
22739 opt_constructor_initializer, to allow the variables to be bound
22740 to the constructor arguments.
22742 * rootcontext.cs (LookupType): First lookup nested classes in our
22743 class and our parents before we go looking outside our class.
22745 * expression.cs (ConstantFold): Extract/debox the values at the
22748 * rootcontext.cs (EmitCode): Resolve the constants first before we
22749 resolve the types. This is not really needed, but it helps debugging.
22751 * statement.cs: report location.
22753 * cs-parser.jay: pass location to throw statement.
22755 * driver.cs: Small bug fix.
22757 * report.cs: Updated format to be 4-zero filled digits.
22759 2001-12-22 Ravi Pratap <ravi@ximian.com>
22761 * expression.cs (CheckIndices): Fix minor bug where the wrong
22762 variable was being referred to ;-)
22764 (DoEmit): Do not call EmitStaticInitializers when the
22765 underlying type is System.Object.
22767 2001-12-21 Ravi Pratap <ravi@ximian.com>
22769 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
22770 and do the usual workaround for SRE.
22772 * class.cs (MyEventBuilder.EventType): New member to get at the type
22773 of the event, quickly.
22775 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
22777 * assign.cs (Assign.DoResolve): Handle the case when the target
22778 is an EventExpr and perform the necessary checks.
22780 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
22783 (SimpleName.MemberStaticCheck): Include check for EventExpr.
22785 (EventExpr): Set the type in the constructor itself since we
22786 are meant to be born fully resolved.
22788 (EventExpr.Define): Revert code I wrote earlier.
22790 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
22791 instance expression is null. The instance expression is a This in that case
22792 or a null, depending on whether it is a static method or not.
22794 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
22795 refers to more than one method.
22797 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
22798 and accordingly flag errors.
22800 2001-12-21 Miguel de Icaza <miguel@ximian.com>
22802 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
22804 2001-12-22 Miguel de Icaza <miguel@ximian.com>
22806 * location.cs (ToString): Provide useful rutine.
22808 2001-12-21 Miguel de Icaza <miguel@ximian.com>
22810 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
22811 objects, return the actual integral boxed.
22813 * statement.cs (SwitchLabel): define an ILLabel for each
22816 (Switch.CheckSwitch): If the value is a Literal, extract
22817 the underlying literal.
22819 Also in the unused hashtable we had, add the SwitchLabel so we can
22820 quickly look this value up.
22822 * constant.cs: Implement a bunch of new constants. Rewrite
22823 Literal based on this. Made changes everywhere to adapt to this.
22825 * expression.cs (Expression.MakeByteBlob): Optimize routine by
22826 dereferencing array only once, and also copes with enumrations.
22828 bytes are two bytes wide, not one.
22830 (Cast): Perform constant conversions.
22832 * ecore.cs (TryImplicitIntConversion): Return literals instead of
22833 wrappers to the literals here.
22835 * expression.cs (DoNumericPromotions): long literals can converted
22836 to ulong implicity (this is taken care of elsewhere, but I was
22837 missing this spot).
22839 * ecore.cs (Expression.Literalize): Make the return type Literal,
22840 to improve type checking.
22842 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
22844 2001-12-20 Miguel de Icaza <miguel@ximian.com>
22846 * literal.cs: Revert code from ravi that checked the bounds. The
22847 bounds are sane by the definition of the type itself.
22849 * typemanager.cs: Fix implementation of ImplementsInterface. We
22850 need to actually look up in our parent hierarchy for interfaces
22853 * const.cs: Use the underlying type for enumerations
22855 * delegate.cs: Compute the basename for the delegate creation,
22856 that should fix the delegate test case, and restore the correct
22857 Type Lookup semantics in rootcontext
22859 * rootcontext.cs: Revert Ravi's last patch. The correct way of
22860 referencing a nested type with the Reflection API is using the "+"
22863 * cs-parser.jay: Do not require EOF token at the end.
22865 2001-12-20 Ravi Pratap <ravi@ximian.com>
22867 * rootcontext.cs (LookupType): Concatenate type names with
22868 a '.' instead of a '+' The test suite passes again.
22870 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
22871 field of the enumeration.
22873 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
22874 the case when the member is an EventExpr.
22876 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
22877 static has an associated instance expression.
22879 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
22881 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
22883 * class.cs (Event.Define): Register event and perform appropriate checks
22886 We define the Add and Remove methods even if the use provides none because
22887 in that case, we provide default implementations ourselves.
22889 Define a private field of the type of the event. This is done by the CSC compiler
22890 and we should be doing it too ;-)
22892 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
22893 More methods we use in code we generate.
22895 (multicast_delegate_type, delegate_type): Two separate types since the distinction
22898 (InitCoreTypes): Update accordingly for the above.
22900 * class.cs (Event.Emit): Generate code for default accessors that we provide
22902 (EmitDefaultMethod): Do the job in the above.
22904 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
22907 2001-12-20 Miguel de Icaza <miguel@ximian.com>
22909 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
22910 builders even if we were missing one.
22912 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
22913 pass the Basename as our class name instead of the Name. The
22914 basename will be correctly composed for us.
22916 * parameter.cs (Paramters): Now takes a Location argument.
22918 * decl.cs (DeclSpace.LookupType): Removed convenience function and
22919 make all the code call directly LookupType in RootContext and take
22920 this chance to pass the Location information everywhere.
22922 * Everywhere: pass Location information.
22924 2001-12-19 Miguel de Icaza <miguel@ximian.com>
22926 * class.cs (Constructor.Define): Updated way of detecting the
22927 length of the parameters.
22929 (TypeContainer.DefineType): Use basename as the type name for
22932 (TypeContainer.Define): Do not recursively define types here, as
22933 definition is taken care in order by the RootContext.
22935 * tree.cs: Keep track of namespaces in a per-file basis.
22937 * parameter.cs (Parameter.ComputeSignature): Update to use
22940 (Parameters.GetSignature): ditto.
22942 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
22943 instead of a TypeContainer.
22945 (Interface.SemanticAnalysis): Use `this' instead of our parent to
22946 resolve names. Because we need to be resolve in our context, not
22949 * driver.cs: Implement response files.
22951 * class.cs (TypeContainer.DefineType): If we are defined, do not
22952 redefine ourselves.
22954 (Event.Emit): Emit the code for add/remove handlers.
22955 (Event.Define): Save the MethodBuilders for add/remove.
22957 * typemanager.cs: Use pair here too.
22959 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
22960 DictionaryEntry requires the first argument to be non-null.
22962 (enum_declaration): Compute full name for registering the
22965 (delegate_declaration): Instead of using
22966 formal_parameter_list, use opt_formal_parameter_list as the list
22969 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
22970 (EventParsing): New property that controls whether `add' and
22971 `remove' are returned as tokens or identifiers (for events);
22973 2001-12-19 Ravi Pratap <ravi@ximian.com>
22975 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
22976 use MyEventBuilder only and let it wrap the real builder for us.
22978 (MyEventBuilder): Revamp constructor etc.
22980 Implement all operations that we perform on EventBuilder in precisely the same
22983 (FindMembers): Update to use the EventBuilder member.
22985 (Event.Emit): Update accordingly.
22987 2001-12-18 Ravi Pratap <ravi@ximian.com>
22989 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
22990 by calling the appropriate methods.
22992 (GetCustomAttributes): Make stubs as they cannot possibly do anything
22995 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
22997 2001-12-17 Ravi Pratap <ravi@ximian.com>
22999 * delegate.cs (Delegate.Populate): Check that the return type
23000 and various parameters types are indeed accessible.
23002 * class.cs (Constructor.Define): Same here.
23004 (Field.Define): Ditto.
23006 (Event.Define): Ditto.
23008 (Operator.Define): Check that the underlying Method defined itself
23009 correctly - so it's MethodBuilder should not be null.
23011 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
23012 expression happens to be null.
23014 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
23015 members but as of now we don't seem to be able to do anything really useful with it.
23017 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
23018 not the EventBuilder.
23020 2001-12-18 Miguel de Icaza <miguel@ximian.com>
23022 * cs-tokenizer.cs: Add support for defines.
23023 Add support for #if, #elif, #else, #endif
23025 (eval_var): evaluates a variable.
23026 (eval): stubbed for evaluating functions.
23028 * cs-parser.jay: Pass the defines information
23030 * driver.cs: Add --define command line option.
23032 * decl.cs: Move MemberCore here.
23034 Make it the base class for DeclSpace. This allows us to catch and
23035 report 108 and 109 for everything now.
23037 * class.cs (TypeContainer.Define): Extract all the members
23038 before populating and emit the warning 108 (new keyword required
23039 to override) instead of having each member implement this.
23041 (MemberCore.Define): New abstract method, we will be using this in
23042 the warning reporting engine in Populate.
23044 (Operator.Define): Adjust to new MemberCore protocol.
23046 * const.cs (Const): This does not derive from Expression, it is a
23047 temporary object we use to create fields, it is a MemberCore.
23049 * class.cs (Method.Define): Allow the entry point to be in a
23052 * driver.cs: Rewrite the argument handler to clean it up a bit.
23054 * rootcontext.cs: Made it just an auxiliary namespace feature by
23055 making everything static.
23057 * driver.cs: Adapt code to use RootContext type name instead of
23060 * delegate.cs: Remove RootContext argument.
23062 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
23065 * class.cs (Event.Define): The lookup can fail.
23067 * cs-tokenizer.cs: Begin implementation of pre-procesor.
23069 * expression.cs: Resolve the this instance before invoking the code.
23071 2001-12-17 Miguel de Icaza <miguel@ximian.com>
23073 * cs-parser.jay: Add a production in element_access that allows
23074 the thing to become a "type" reference. This way we can parse
23075 things like "(string [])" as a type.
23077 Note that this still does not handle the more complex rules of
23081 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
23083 * ecore.cs: (CopyNewMethods): new utility function used to
23084 assemble the list of methods from running FindMembers.
23086 (MemberLookup): Rework FindMembers so that
23088 2001-12-16 Miguel de Icaza <miguel@ximian.com>
23090 * class.cs (TypeContainer): Remove Delegates who fail to be
23093 * delegate.cs (Populate): Verify that we dont get null return
23094 values. TODO: Check for AsAccessible.
23096 * cs-parser.jay: Use basename to emit error 574 (destructor should
23097 have the same name as container class), not the full name.
23099 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
23100 possible representation.
23102 Also implements integer type suffixes U and L.
23104 2001-12-15 Miguel de Icaza <miguel@ximian.com>
23106 * expression.cs (ArrayCreation.DoResolve): We need to do the
23107 argument resolution *always*.
23109 * decl.cs: Make this hold the namespace. Hold the root context as
23111 (LookupType): Move here.
23113 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
23115 * location.cs (Row, Name): Fixed the code, it was always returning
23116 references to the first file.
23118 * interface.cs: Register properties defined through interfaces.
23120 * driver.cs: Add support for globbing on the command line
23122 * class.cs (Field): Make it derive from MemberCore as well.
23125 2001-12-15 Ravi Pratap <ravi@ximian.com>
23127 * class.cs (Event::Define): Check that the type of the event is a delegate
23128 type else flag error #66.
23130 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
23133 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
23134 values of EntryPoint, CharSet etc etc.
23136 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
23138 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
23139 be null and we should ignore this. I am not sure if this is really clean. Apparently,
23140 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
23141 which needs this to do its work.
23143 * ../errors/cs0066.cs : Add.
23145 2001-12-14 Miguel de Icaza <miguel@ximian.com>
23147 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
23150 * class.cs: (MethodSignature.MethodSignature): Removed hack that
23151 clears out the parameters field.
23152 (MemberSignatureCompare): Cleanup
23154 (MemberCore): New base class used to share code between MethodCore
23157 (RegisterRequiredImplementations) BindingFlags.Public requires
23158 either BindingFlags.Instace or Static. Use instance here.
23160 (Property): Refactored code to cope better with the full spec.
23162 * parameter.cs (GetParameterInfo): Return an empty array instead
23165 * class.cs (Property): Abstract or extern properties have no bodies.
23167 * parameter.cs (GetParameterInfo): return a zero-sized array.
23169 * class.cs (TypeContainer.MethodModifiersValid): Move all the
23170 method modifier validation to the typecontainer so we can reuse
23171 this on properties.
23173 (MethodCore.ParameterTypes): return an empty sized array of types.
23175 (Property.Define): Test property modifier validity.
23177 Add tests for sealed/override too.
23179 (Method.Emit): abstract or extern methods have no bodies.
23181 2001-12-14 Ravi Pratap <ravi@ximian.com>
23183 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
23186 (Method::Define, ::Emit): Modify accordingly.
23188 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
23190 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
23192 * makefile: Pass in /unsafe.
23194 2001-12-13 Miguel de Icaza <miguel@ximian.com>
23196 * class.cs (MakeKey): Kill routine.
23198 * class.cs (TypeContainer.Define): Correctly define explicit
23199 method implementations (they require the full interface name plus
23202 * typemanager.cs: Deply the PtrHashtable here and stop using the
23203 lame keys. Things work so much better.
23205 This of course broke everyone who depended on `RegisterMethod' to
23206 do the `test for existance' test. This has to be done elsewhere.
23208 * support.cs (PtrHashtable): A hashtable that avoid comparing with
23209 the object stupid Equals method (because, that like fails all over
23210 the place). We still do not use it.
23212 * class.cs (TypeContainer.SetRequiredInterface,
23213 TypeContainer.RequireMethods): Killed these two routines and moved
23214 all the functionality to RegisterRequiredImplementations.
23216 (TypeContainer.RegisterRequiredImplementations): This routine now
23217 registers all the implementations required in an array for the
23218 interfaces and abstract methods. We use an array of structures
23219 which can be computed ahead of time to reduce memory usage and we
23220 also assume that lookups are cheap as most classes will not
23221 implement too many interfaces.
23223 We also avoid creating too many MethodSignatures.
23225 (TypeContainer.IsInterfaceMethod): Update and optionally does not
23226 clear the "pending" bit if we find that there are problems with
23229 (TypeContainer.VerifyPendingMethods): Update to report errors of
23230 methods that look like implementations but are not.
23232 (TypeContainer.Define): Add support for explicit interface method
23235 2001-12-12 Miguel de Icaza <miguel@ximian.com>
23237 * typemanager.cs: Keep track of the parameters here instead of
23238 being a feature of the TypeContainer.
23240 * class.cs: Drop the registration of parameters here, as
23241 InterfaceMethods are also interface declarations.
23243 * delegate.cs: Register methods with the TypeManager not only with
23244 the TypeContainer. This code was buggy.
23246 * interface.cs: Full registation here.
23248 2001-12-11 Miguel de Icaza <miguel@ximian.com>
23250 * expression.cs: Remove reducer for binary expressions, it can not
23253 * const.cs: Put here the code that used to go into constant.cs
23255 * constant.cs: Put here the code for constants, this is a new base
23256 class for Literals.
23258 * literal.cs: Make Literal derive from Constant.
23260 2001-12-09 Miguel de Icaza <miguel@ximian.com>
23262 * statement.cs (Return.Emit): Report error 157 if the user
23263 attempts to return from a finally block.
23265 (Return.Emit): Instead of emitting a return, jump to the end of
23268 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
23269 LocalBuilder to store the result of the function. ReturnLabel is
23270 the target where we jump.
23273 2001-12-09 Radek Doulik <rodo@ximian.com>
23275 * cs-parser.jay: remember alias in current namespace
23277 * ecore.cs (SimpleName::DoResolve): use aliases for types or
23280 * class.cs (LookupAlias): lookup alias in my_namespace
23282 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
23284 (LookupAlias): lookup alias in this and if needed in parent
23287 2001-12-08 Miguel de Icaza <miguel@ximian.com>
23291 * rootcontext.cs: (ModuleBuilder) Made static, first step into
23292 making things static. I need this to avoid passing the
23293 TypeContainer when calling ParameterType.
23295 * support.cs (InternalParameters.ParameterType): Remove ugly hack
23296 that did string manipulation to compute the type and then call
23297 GetType. Use Parameter.ParameterType instead.
23299 * cs-tokenizer.cs: Consume the suffix for floating values.
23301 * expression.cs (ParameterReference): figure out whether this is a
23302 reference parameter or not. Kill an extra variable by computing
23303 the arg_idx during emission.
23305 * parameter.cs (Parameters.GetParameterInfo): New overloaded
23306 function that returns whether a parameter is an out/ref value or not.
23308 (Parameter.ParameterType): The type of the parameter (base,
23309 without ref/out applied).
23311 (Parameter.Resolve): Perform resolution here.
23312 (Parameter.ExternalType): The full type (with ref/out applied).
23314 * statement.cs (Using.Emit, Using.EmitExpression): Implement
23315 support for expressions on the using statement.
23317 2001-12-07 Miguel de Icaza <miguel@ximian.com>
23319 * statement.cs (Using.EmitLocalVariableDecls): Split the
23320 localvariable handling of the using statement.
23322 (Block.EmitMeta): Keep track of variable count across blocks. We
23323 were reusing slots on separate branches of blocks.
23325 (Try.Emit): Emit the general code block, we were not emitting it.
23327 Check the type of the declaration to be an IDisposable or
23328 something that can be implicity converted to it.
23330 Emit conversions if required.
23332 * ecore.cs (EmptyExpression): New utility class.
23333 (Expression.ImplicitConversionExists): New utility function.
23335 2001-12-06 Miguel de Icaza <miguel@ximian.com>
23337 * statement.cs (Using): Implement.
23339 * expression.cs (LocalVariableReference): Support read only variables.
23341 * statement.cs: Remove the explicit emit for the Leave opcode.
23342 (VariableInfo): Add a readonly field.
23344 2001-12-05 Miguel de Icaza <miguel@ximian.com>
23346 * ecore.cs (ConvCast): new class used to encapsulate the various
23347 explicit integer conversions that works in both checked and
23348 unchecked contexts.
23350 (Expression.ConvertNumericExplicit): Use new ConvCast class to
23351 properly generate the overflow opcodes.
23353 2001-12-04 Miguel de Icaza <miguel@ximian.com>
23355 * statement.cs: The correct type for the EmptyExpression is the
23356 element_type, not the variable type. Ravi pointed this out.
23358 2001-12-04 Ravi Pratap <ravi@ximian.com>
23360 * class.cs (Method::Define): Handle PInvoke methods specially
23361 by using DefinePInvokeMethod instead of the usual one.
23363 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
23364 above to do the task of extracting information and defining the method.
23366 2001-12-04 Ravi Pratap <ravi@ximian.com>
23368 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
23369 of the condition for string type.
23371 (Emit): Move that here.
23373 (ArrayCreation::CheckIndices): Keep string literals in their expression
23376 (EmitDynamicInitializers): Handle strings appropriately.
23378 2001-12-04 Miguel de Icaza <miguel@ximian.com>
23380 * codegen.cs (EmitContext): Replace multiple variables with a
23381 single pointer to the current Switch statement.
23383 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
23386 2001-12-03 Miguel de Icaza <miguel@ximian.com>
23390 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
23393 (Foreach.Emit): Foreach on arrays was not setting
23394 up the loop variables (for break/continue).
23396 (GotoCase): Semi-implented.
23398 2001-12-03 Ravi Pratap <ravi@ximian.com>
23400 * attribute.cs (CheckAttribute): Handle system attributes by using
23401 Attribute.GetAttributes to examine information we need.
23403 (GetValidPlaces): Same here.
23405 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
23407 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
23409 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
23411 (Method::Define): Set appropriate flags if we have a DllImport attribute.
23413 (Method::Emit): Handle the case when we are a PInvoke method.
23415 2001-12-03 Miguel de Icaza <miguel@ximian.com>
23417 * expression.cs: Use ResolveWithSimpleName on compound names.
23419 2001-12-02 Ravi Pratap <ravi@ximian.com>
23421 * constant.cs (EmitConstant): Make sure we resolve the associated expression
23422 before trying to reduce it.
23424 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
23426 * constant.cs (LookupConstantValue): Implement.
23428 (EmitConstant): Use the above in emitting the constant.
23430 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
23431 that are user-defined by doing a LookupConstantValue on them.
23433 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
23436 2001-11-29 Miguel de Icaza <miguel@ximian.com>
23438 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
23440 (BaseAccess.DoResolve): Implement.
23442 (MemberAccess.DoResolve): Split this routine into a
23443 ResolveMemberAccess routine that can be used independently
23445 2001-11-28 Miguel de Icaza <miguel@ximian.com>
23447 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
23448 As that share bits of the implementation. Is returns a boolean,
23449 while As returns the Type that is being probed.
23451 2001-12-01 Ravi Pratap <ravi@ximian.com>
23453 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
23454 instead of a Literal - much easier.
23456 (EnumInTransit): Remove - utterly useless :-)
23458 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
23460 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
23462 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
23463 chain when we have no associated expression.
23465 2001-11-30 Ravi Pratap <ravi@ximian.com>
23467 * constant.cs (Define): Use Location while reporting the errror.
23469 Also emit a warning when 'new' is used and there is no inherited
23472 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
23475 (LookupEnumValue): Implement to lookup an enum member's value and define it
23478 (Populate): Re-write accordingly to use the above routine.
23480 2001-11-27 Miguel de Icaza <miguel@ximian.com>
23482 * expression.cs (This): Fix prototype for DoResolveLValue to
23483 override the base class DoResolveLValue.
23485 * cs-parser.cs: Report errors cs574 and cs575 (destructor
23488 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
23489 (we need to load the address of the field here). This fixes
23492 (FieldExpr.DoResolveLValue): Call the DoResolve
23493 function to initialize the Instance expression.
23495 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
23496 correctly the GetEnumerator operation on a value type.
23498 * cs-parser.jay: Add more simple parsing error catches.
23500 * statement.cs (Switch): Add support for string switches.
23501 Handle null specially.
23503 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
23505 2001-11-28 Ravi Pratap <ravi@ximian.com>
23507 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
23509 (declare_local_constant): New helper function.
23511 * statement.cs (AddConstant): Keep a separate record of constants
23513 (IsConstant): Implement to determine if a variable is a constant.
23515 (GetConstantExpression): Implement.
23517 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
23519 * statement.cs (IsVariableDefined): Re-write.
23521 2001-11-27 Ravi Pratap <ravi@ximian.com>
23523 * class.cs (TypeContainer::FindMembers): Look for constants
23524 in the case when we are looking for MemberTypes.Field
23526 * expression.cs (MemberAccess::DoResolve): Check that in the
23527 case we are a FieldExpr and a Literal, we are not being accessed
23528 by an instance reference.
23530 * cs-parser.jay (local_constant_declaration): Implement.
23532 (declaration_statement): Implement for constant declarations.
23534 2001-11-26 Miguel de Icaza <miguel@ximian.com>
23536 * statement.cs (Switch): Catch double defaults.
23538 (Switch): More work on the switch() statement
23539 implementation. It works for integral values now, need to finish
23543 2001-11-24 Miguel de Icaza <miguel@ximian.com>
23545 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
23546 integer literals into other integer literals. To be used by
23549 2001-11-24 Ravi Pratap <ravi@ximian.com>
23551 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
23554 (EmitDynamicInitializers): Cope with the above since we extract data
23555 directly from ArrayData now.
23557 (ExpectInitializers): Keep track of whether initializers are mandatory
23560 (Bounds): Make it a hashtable to prevent the same dimension being
23561 recorded for every element in that dimension.
23563 (EmitDynamicInitializers): Fix bug which prevented the Set array method
23566 Also fix bug which was causing the indices to be emitted in the reverse
23569 2001-11-24 Miguel de Icaza <miguel@ximian.com>
23571 * expression.cs (ArrayCreation): Implement the bits that Ravi left
23572 unfinished. They do not work, because the underlying code is
23575 2001-11-22 Miguel de Icaza <miguel@ximian.com>
23577 * cs-parser.jay: Remove bogus fixme.
23579 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
23580 on Switch statement.
23582 2001-11-23 Ravi Pratap <ravi@ximian.com>
23584 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
23587 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
23588 parameter. Apparently, any expression is allowed.
23590 (ValidateInitializers): Update accordingly.
23592 (CheckIndices): Fix some tricky bugs thanks to recursion.
23594 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
23595 I was being completely brain-dead.
23597 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
23598 and re-write acordingly.
23600 (DelegateInvocation): Re-write accordingly.
23602 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
23604 (MakeByteBlob): Handle types more correctly.
23606 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
23607 initialization from expressions but it is incomplete because I am a complete
23610 2001-11-22 Miguel de Icaza <miguel@ximian.com>
23612 * statement.cs (If.Emit): Fix a bug that generated incorrect code
23613 on If. Basically, we have to return `true' (ie, we do return to
23614 our caller) only if both branches of the if return.
23616 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
23617 short-circuit operators, handle them as short circuit operators.
23619 (Cast.DoResolve): Resolve type.
23620 (Cast.Cast): Take an expression as the target type.
23622 * cs-parser.jay (cast_expression): Remove old hack that only
23623 allowed a limited set of types to be handled. Now we take a
23624 unary_expression and we resolve to a type during semantic
23627 Use the grammar productions from Rhys to handle casts (this is
23628 not complete like Rhys syntax yet, we fail to handle that corner
23629 case that C# has regarding (-x), but we will get there.
23631 2001-11-22 Ravi Pratap <ravi@ximian.com>
23633 * class.cs (EmitFieldInitializer): Take care of the case when we have a
23634 field which is an array type.
23636 * cs-parser.jay (declare_local_variables): Support array initialization too.
23638 * typemanager.cs (MakeKey): Implement.
23640 (everywhere): Use the above appropriately.
23642 * cs-parser.jay (for_statement): Update for array initialization while
23643 declaring variables.
23645 * ecore.cs : The error message was correct, it's the variable's names that
23646 were misleading ;-) Make the code more readable.
23648 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
23649 the correct type etc.
23651 (ConvertExplicit): Handle Enum types by examining the underlying type.
23653 2001-11-21 Ravi Pratap <ravi@ximian.com>
23655 * parameter.cs (GetCallingConvention): Always return
23656 CallingConventions.Standard for now.
23658 2001-11-22 Miguel de Icaza <miguel@ximian.com>
23660 * expression.cs (Binary.ResolveOperator): Update the values of `l'
23661 and `r' after calling DoNumericPromotions.
23663 * ecore.cs: Fix error message (the types were in the wrong order).
23665 * statement.cs (Foreach.ProbeCollectionType): Need to pass
23666 BindingFlags.Instance as well
23668 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
23669 implicit int literal conversion in an empty cast so that we
23670 propagate the right type upstream.
23672 (UnboxCast): new class used to unbox value types.
23673 (Expression.ConvertExplicit): Add explicit type conversions done
23676 (Expression.ImplicitNumericConversion): Oops, forgot to test for
23677 the target type before applying the implicit LongLiterals to ULong
23680 2001-11-21 Miguel de Icaza <miguel@ximian.com>
23682 * cs-parser.jay (for_statement): Reworked the way For works: now
23683 we declare manually any variables that are introduced in
23684 for_initializer to solve the problem of having out-of-band code
23685 emition (that is what got for broken).
23687 (declaration_statement): Perform the actual variable declaration
23688 that used to be done in local_variable_declaration here.
23690 (local_variable_declaration): Do not declare anything, just pass
23691 the information on a DictionaryEntry
23693 2001-11-20 Ravi Pratap <ravi@ximian.com>
23695 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
23696 re-write of the logic to now make it recursive.
23698 (UpdateIndices): Re-write accordingly.
23700 Store element data in a separate ArrayData list in the above methods.
23702 (MakeByteBlob): Implement to dump the array data into a byte array.
23704 2001-11-19 Ravi Pratap <ravi@ximian.com>
23706 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
23709 * constant.cs (Define): Implement.
23711 (EmitConstant): Re-write fully.
23713 Pass in location info.
23715 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
23718 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
23719 DictionaryEntry since we need location info too.
23721 (constant_declaration): Update accordingly.
23723 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
23724 code into another method : UpdateIndices.
23726 2001-11-18 Ravi Pratap <ravi@ximian.com>
23728 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
23729 some type checking etc.
23731 2001-11-17 Ravi Pratap <ravi@ximian.com>
23733 * expression.cs (ArrayCreation::ValidateInitializers): Implement
23734 bits to provide dimension info if the user skips doing that.
23736 Update second constructor to store the rank correctly.
23738 2001-11-16 Ravi Pratap <ravi@ximian.com>
23740 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
23741 and try to implement.
23743 * ../errors/cs0150.cs : Add.
23745 * ../errors/cs0178.cs : Add.
23747 2001-11-16 Miguel de Icaza <miguel@ximian.com>
23749 * statement.cs: Implement foreach on multi-dimensional arrays.
23751 * parameter.cs (Parameters.GetParameterByName): Also lookup the
23752 name of the params argument.
23754 * expression.cs: Use EmitStoreOpcode to get the right opcode while
23755 initializing the array.
23757 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
23758 we can use this elsewhere.
23760 * statement.cs: Finish implementation of foreach for single
23763 * cs-parser.jay: Use an out-of-band stack to pass information
23764 around, I wonder why I need this.
23766 foreach_block: Make the new foreach_block the current_block.
23768 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
23769 function used to return a static Parameters structure. Used for
23770 empty parameters, as those are created very frequently.
23772 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
23774 2001-11-15 Ravi Pratap <ravi@ximian.com>
23776 * interface.cs : Default modifier is private, not public. The
23777 make verify test passes again.
23779 2001-11-15 Ravi Pratap <ravi@ximian.com>
23781 * support.cs (ReflectionParameters): Fix logic to determine
23782 whether the last parameter is a params one. Test 9 passes again.
23784 * delegate.cs (Populate): Register the builders we define with
23785 RegisterParameterForBuilder. Test 19 passes again.
23787 * cs-parser.jay (property_declaration): Reference $6 instead
23788 of $$ to get at the location.
23790 (indexer_declaration): Similar stuff.
23792 (attribute): Ditto.
23794 * class.cs (Property): Register parameters for the Get and Set methods
23795 if they exist. Test 23 passes again.
23797 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
23798 call to EmitArguments as we are sure there aren't any params arguments.
23799 Test 32 passes again.
23801 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
23802 IndexOutOfRangeException.
23804 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
23805 Test 33 now passes again.
23807 2001-11-15 Miguel de Icaza <miguel@ximian.com>
23809 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
23810 broke a bunch of things. Will have to come up with a better way
23811 of tracking locations.
23813 * statement.cs: Implemented foreach for single dimension arrays.
23815 2001-11-09 Miguel de Icaza <miguel@ximian.com>
23817 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
23818 an error. This removes the lookup from the critical path.
23820 * cs-parser.jay: Removed use of temporary_loc, which is completely
23823 2001-11-14 Miguel de Icaza <miguel@ximian.com>
23825 * support.cs (ReflectionParameters.ParameterModifier): Report
23826 whether the argument is a PARAMS argument or not.
23828 * class.cs: Set the attribute `ParamArrayAttribute' on the
23829 parameter argument.
23831 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
23832 and cons_param_array_attribute (ConstructorInfo for
23833 ParamArrayAttribute).,
23835 * codegen.cs: Emit the return using the `Return' statement, that
23836 way we can report the error correctly for missing return values.
23838 * class.cs (Method.Emit): Clean up.
23840 * expression.cs (Argument.Resolve): Take another argument: the
23841 location where this argument is used. Notice that this is not
23842 part of the "Argument" class as to reduce the size of the
23843 structure (we know the approximate location anyways).
23845 Test if the argument is a variable-reference, if not, then
23846 complain with a 206.
23848 (Argument.Emit): Emit addresses of variables.
23850 (Argument.FullDesc): Simplify.
23852 (Invocation.DoResolve): Update for Argument.Resolve.
23854 (ElementAccess.DoResolve): ditto.
23856 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
23857 method should be virtual, as this method is always virtual.
23859 (NewDelegate.DoResolve): Update for Argument.Resolve.
23861 * class.cs (ConstructorInitializer.DoResolve): ditto.
23863 * attribute.cs (Attribute.Resolve): ditto.
23865 2001-11-13 Miguel de Icaza <miguel@ximian.com>
23867 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
23869 * expression.cs (ParameterReference): Drop IStackStorage and implement
23870 IAssignMethod instead.
23872 (LocalVariableReference): ditto.
23874 * ecore.cs (FieldExpr): Drop IStackStorage and implement
23875 IAssignMethod instead.
23877 2001-11-13 Miguel de Icaza <miguel@ximian.com>
23879 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
23880 enumerations that are used in heavily used structures derive from
23881 byte in a laughable and pathetic attempt to reduce memory usage.
23882 This is the kind of pre-optimzations that you should not do at
23883 home without adult supervision.
23885 * expression.cs (UnaryMutator): New class, used to handle ++ and
23886 -- separatedly from the other unary operators. Cleans up the
23887 code, and kills the ExpressionStatement dependency in Unary.
23889 (Unary): Removed `method' and `Arguments' from this class, making
23890 it smaller, and moving it all to SimpleCall, so I can reuse this
23891 code in other locations and avoid creating a lot of transient data
23892 strucutres when not required.
23894 * cs-parser.jay: Adjust for new changes.
23896 2001-11-11 Miguel de Icaza <miguel@ximian.com>
23898 * enum.cs (Enum.Populate): If there is a failure during
23901 * cs-parser.jay (opt_enum_base): we used to catch type errors
23902 here, but this is really incorrect. The type error should be
23903 catched during semantic analysis.
23905 2001-12-11 Ravi Pratap <ravi@ximian.com>
23907 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
23908 current_local_parameters as expected since I, in my stupidity, had forgotten
23911 * attribute.cs (GetValidPlaces): Fix stupid bug.
23913 * class.cs (Method::Emit): Perform check on applicability of attributes.
23915 (Constructor::Emit): Ditto.
23917 (Field::Emit): Ditto.
23919 (Field.Location): Store location information.
23921 (Property, Event, Indexer, Operator): Ditto.
23923 * cs-parser.jay (field_declaration): Pass in location for each field.
23925 * ../errors/cs0592.cs : Add.
23927 2001-11-12 Ravi Pratap <ravi@ximian.com>
23929 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
23931 (InitCoreTypes): Update accordingly.
23933 (RegisterAttrType, LookupAttr): Implement.
23935 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
23936 info about the same.
23938 (Resolve): Update to populate the above as necessary.
23940 (Error592): Helper.
23942 (GetValidPlaces): Helper to the above.
23944 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
23946 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
23948 2001-11-12 Ravi Pratap <ravi@ximian.com>
23950 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
23952 * ../errors/cs0617.cs : Add.
23954 2001-11-11 Ravi Pratap <ravi@ximian.com>
23956 * enum.cs (Emit): Rename to Populate to be more consistent with what
23957 we expect it to do and when exactly it is called.
23959 * class.cs, rootcontext.cs : Update accordingly.
23961 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
23962 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
23964 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
23966 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
23967 of a fieldinfo using the above, when dealing with a FieldBuilder.
23969 2001-11-10 Ravi Pratap <ravi@ximian.com>
23971 * ../errors/cs0031.cs : Add.
23973 * ../errors/cs1008.cs : Add.
23975 * ../errrors/cs0543.cs : Add.
23977 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
23980 (FindMembers): Implement.
23982 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
23983 enums and delegates too.
23985 (enum_types): Rename to builder_to_enum.
23987 (delegate_types): Rename to builder_to_delegate.
23989 * delegate.cs (FindMembers): Implement.
23991 2001-11-09 Ravi Pratap <ravi@ximian.com>
23993 * typemanager.cs (IsEnumType): Implement.
23995 * enum.cs (Emit): Re-write parts to account for the underlying type
23996 better and perform checking etc.
23998 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
23999 of the underlying type.
24001 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
24004 * enum.cs (error31): Helper to report error #31.
24006 * cs-parser.jay (enum_declaration): Store location of each member too.
24008 * enum.cs (member_to_location): New hashtable.
24010 (AddEnumMember): Update location hashtable.
24012 (Emit): Use the location of each member while reporting errors.
24014 2001-11-09 Miguel de Icaza <miguel@ximian.com>
24016 * cs-parser.jay: A for_initializer if is a
24017 local_variable_declaration really ammount to have an implicit
24018 block with the variable declaration and no initializer for for.
24020 * statement.cs (For.Emit): Cope with null initializers.
24022 This fixes the infinite loop on for initializers.
24024 2001-11-08 Miguel de Icaza <miguel@ximian.com>
24026 * enum.cs: More cleanup.
24028 * ecore.cs: Remove dead code.
24030 * class.cs (Property.Emit): More simplification.
24031 (Event.Emit): ditto.
24033 Reworked to have less levels of indentation.
24035 2001-11-08 Ravi Pratap <ravi@ximian.com>
24037 * class.cs (Property): Emit attributes.
24047 * enum.cs (Emit): Ditto.
24049 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
24052 * class.cs (Field, Event, etc.): Move attribute generation into the
24053 Emit method everywhere.
24055 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
24056 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
24057 as we had no way of defining nested enums !
24059 * rootcontext.cs : Adjust code accordingly.
24061 * typemanager.cs (AddEnumType): To keep track of enum types separately.
24063 2001-11-07 Ravi Pratap <ravi@ximian.com>
24065 * expression.cs (EvalConstantExpression): Move into ecore.cs
24067 * enum.cs (Enum): Rename some members and make them public and readonly
24068 according to our convention.
24070 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
24073 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
24075 (Enum::Emit): Write a simple version for now which doesn't try to compute
24076 expressions. I shall modify this to be more robust in just a while.
24078 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
24080 (TypeContainer::CloseType): Create the Enum types too.
24082 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
24084 * expression.cs (EvalConstantExpression): Get rid of completely.
24086 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
24087 user-defined values and other cases.
24089 (IsValidEnumLiteral): Helper function.
24091 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
24092 out there in the case we had a literal FieldExpr.
24094 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
24096 (Literalize): Revamp a bit to take two arguments.
24098 (EnumLiteral): New class which derives from Literal to wrap enum literals.
24100 2001-11-06 Ravi Pratap <ravi@ximian.com>
24102 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
24104 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
24106 (Resolve): Use the above to ensure we have proper initializers.
24108 2001-11-05 Ravi Pratap <ravi@ximian.com>
24110 * expression.cs (Expression::EvalConstantExpression): New method to
24111 evaluate constant expressions.
24113 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
24115 2001-11-07 Miguel de Icaza <miguel@ximian.com>
24117 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
24120 (Binary.ResolveOperator): Handle operator != (object a, object b)
24121 and operator == (object a, object b);
24123 (Binary.DoNumericPromotions): Indicate whether the numeric
24124 promotion was possible.
24126 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
24129 Made the ArrayAccess implement interface IAssignMethod instead of
24130 IStackStore as the order in which arguments are passed reflects
24133 * assign.cs: Instead of using expr.ExprClass to select the way of
24134 assinging, probe for the IStackStore/IAssignMethod interfaces.
24136 * typemanager.cs: Load InitializeArray definition.
24138 * rootcontext.cs (RootContext.MakeStaticData): Used to define
24139 static data that can be used to initialize arrays.
24141 2001-11-05 Miguel de Icaza <miguel@ximian.com>
24143 * expression.cs: Handle operator== and operator!= for booleans.
24145 (Conditioal.Reduce): Implement reducer for the ?: operator.
24147 (Conditional.Resolve): Implement dead code elimination.
24149 (Binary.Resolve): Catch string literals and return a new
24150 concatenated string.
24152 (Unary.Reduce): Implement reduction of unary expressions.
24154 * ecore.cs: Split out the expression core handling here.
24156 (Expression.Reduce): New method used to perform constant folding
24157 and CSE. This is needed to support constant-expressions.
24159 * statement.cs (Statement.EmitBoolExpression): Pass true and false
24160 targets, and optimize for !x.
24162 2001-11-04 Ravi Pratap <ravi@ximian.com>
24164 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
24165 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
24166 set custom atttributes.
24168 * literal.cs (Literal::GetValue): New abstract method to return the actual
24169 value of the literal, cast as an object.
24171 (*Literal): Implement GetValue method.
24173 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
24174 expressions to the arraylist but objects of type Argument.
24176 * class.cs (TypeContainer::Emit): Emit our attributes too.
24178 (Method::Emit, Constructor::Emit): Ditto.
24180 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
24181 to be ignoring earlier.
24183 2001-11-03 Ravi Pratap <ravi@ximian.com>
24185 * attribute.cs (AttributeSection::Define): Implement to do the business
24186 of constructing a CustomAttributeBuilder.
24188 (Attribute): New trivial class. Increases readability of code.
24190 * cs-parser.jay : Update accordingly.
24192 (positional_argument_list, named_argument_list, named_argument): New rules
24194 (attribute_arguments): Use the above so that we are more correct.
24196 2001-11-02 Ravi Pratap <ravi@ximian.com>
24198 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
24199 to perform all checks for a method with a params parameter.
24201 (Invocation::OverloadResolve): Update to use the above method and therefore
24202 cope correctly with params method invocations.
24204 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
24207 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
24208 constructors in our parent too because we can't afford to miss out on
24211 * attribute.cs (AttributeSection): New name for the class Attribute
24213 Other trivial changes to improve readability.
24215 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
24216 use the new class names.
24218 2001-11-01 Ravi Pratap <ravi@ximian.com>
24220 * class.cs (Method::Define): Complete definition for params types too
24222 (Indexer::Define): Ditto.
24224 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
24225 Cope everywhere with a request for info about the array parameter.
24227 2001-11-01 Ravi Pratap <ravi@ximian.com>
24229 * tree.cs (RecordNamespace): Fix up to check for the correct key.
24231 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
24232 local_variable_type to extract the string corresponding to the type.
24234 (local_variable_type): Fixup the action to use the new helper method.
24236 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
24239 * expression.cs : Clean out code which uses the above.
24241 2001-10-31 Ravi Pratap <ravi@ximian.com>
24243 * typemanager.cs (RegisterMethod): Check if we already have an existing key
24244 and bale out if necessary by returning a false.
24246 (RegisterProperty): Ditto.
24248 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
24249 and print out appropriate error messages.
24251 * interface.cs (everywhere): Ditto.
24253 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
24254 location to constructor.
24256 * class.cs (Property, Event, Indexer): Update accordingly.
24258 * ../errors/cs111.cs : Added.
24260 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
24261 of a method, as laid down by the spec.
24263 (Invocation::OverloadResolve): Use the above method.
24265 2001-10-31 Ravi Pratap <ravi@ximian.com>
24267 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
24268 now take a TypeContainer and a Parameters object.
24270 (ParameterData): Modify return type of ParameterModifier method to be
24271 Parameter.Modifier and not a string.
24273 (ReflectionParameters, InternalParameters): Update accordingly.
24275 * expression.cs (Argument::GetParameterModifier): Same here.
24277 * support.cs (InternalParameters::ParameterType): Find a better way of determining
24278 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
24279 symbol in it at all so maybe this is only for now.
24281 2001-10-30 Ravi Pratap <ravi@ximian.com>
24283 * support.cs (InternalParameters): Constructor now takes an extra argument
24284 which is the actual Parameters class.
24286 (ParameterDesc): Update to provide info on ref/out modifiers.
24288 * class.cs (everywhere): Update call to InternalParameters to pass in
24289 the second argument too.
24291 * support.cs (ParameterData): Add ParameterModifier, which is a method
24292 to return the modifier info [ref/out etc]
24294 (InternalParameters, ReflectionParameters): Implement the above.
24296 * expression.cs (Argument::ParameterModifier): Similar function to return
24297 info about the argument's modifiers.
24299 (Invocation::OverloadResolve): Update to take into account matching modifiers
24302 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
24303 a new SetFormalParameters object which we pass to InternalParameters.
24305 2001-10-30 Ravi Pratap <ravi@ximian.com>
24307 * expression.cs (NewArray): Merge into the ArrayCreation class.
24309 2001-10-29 Ravi Pratap <ravi@ximian.com>
24311 * expression.cs (NewArray): Merge classes NewBuiltinArray and
24312 NewUserdefinedArray into one as there wasn't much of a use in having
24315 * expression.cs (Argument): Change field's name to ArgType from Type.
24317 (Type): New readonly property which returns the proper type, taking into
24318 account ref/out modifiers.
24320 (everywhere): Adjust code accordingly for the above.
24322 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
24323 whether we are emitting for a ref or out parameter.
24325 * expression.cs (Argument::Emit): Use the above field to set the state.
24327 (LocalVariableReference::Emit): Update to honour the flag and emit the
24330 * parameter.cs (Attributes): Set the correct flags for ref parameters.
24332 * expression.cs (Argument::FullDesc): New function to provide a full desc.
24334 * support.cs (ParameterData): Add method ParameterDesc to the interface.
24336 (ReflectionParameters, InternalParameters): Implement the above method.
24338 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
24341 (Invocation::FullMethodDesc): Ditto.
24343 2001-10-29 Miguel de Icaza <miguel@ximian.com>
24345 * cs-parser.jay: Add extra production for the second form of array
24348 * expression.cs (ArrayCreation): Update to reflect the above
24351 * Small changes to prepare for Array initialization.
24353 2001-10-28 Miguel de Icaza <miguel@ximian.com>
24355 * typemanager.cs (ImplementsInterface): interface might be null;
24356 Deal with this problem;
24358 Also, we do store negative hits on the cache (null values), so use
24359 this instead of calling t.GetInterfaces on the type everytime.
24361 2001-10-28 Ravi Pratap <ravi@ximian.com>
24363 * typemanager.cs (IsBuiltinType): New method to help determine the same.
24365 * expression.cs (New::DoResolve): Get rid of array creation code and instead
24366 split functionality out into different classes.
24368 (New::FormArrayType): Move into NewBuiltinArray.
24370 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
24373 (NewBuiltinArray): New class to handle creation of built-in arrays.
24375 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
24376 account creation of one-dimensional arrays.
24378 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
24380 (NewUserdefinedArray::DoResolve): Implement.
24382 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
24384 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
24385 we maintain inside the TypeManager. This is necessary to perform lookups on the
24388 (LookupType): Update to perform GetType on the module builders too.
24390 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
24392 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
24394 2001-10-23 Ravi Pratap <ravi@ximian.com>
24396 * expression.cs (New::DoResolve): Implement guts of array creation.
24398 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
24400 2001-10-27 Miguel de Icaza <miguel@ximian.com>
24402 * expression.cs: Fix bug I introduced lsat night that broke
24405 (Expression.Resolve): Report a 246 error (can not resolve name)
24406 if we find a SimpleName in the stream.
24408 (Expression.ResolveLValue): Ditto.
24410 (Expression.ResolveWithSimpleName): This function is a variant of
24411 ResolveName, this one allows SimpleNames to be returned without a
24412 warning. The only consumer of SimpleNames is MemberAccess
24414 2001-10-26 Miguel de Icaza <miguel@ximian.com>
24416 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
24417 might arrive here. I have my doubts that this is correct.
24419 * statement.cs (Lock): Implement lock statement.
24421 * cs-parser.jay: Small fixes to support `lock' and `using'
24423 * cs-tokenizer.cs: Remove extra space
24425 * driver.cs: New flag --checked, allows to turn on integer math
24428 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
24429 Threading.Monitor.Exit
24431 2001-10-23 Miguel de Icaza <miguel@ximian.com>
24433 * expression.cs (IndexerAccess::DoResolveLValue): Set the
24434 Expression Class to be IndexerAccess.
24436 Notice that Indexer::DoResolve sets the eclass to Value.
24438 2001-10-22 Miguel de Icaza <miguel@ximian.com>
24440 * class.cs (TypeContainer::Emit): Emit code for indexers.
24442 * assign.cs (IAssignMethod): New interface implemented by Indexers
24443 and Properties for handling assignment.
24445 (Assign::Emit): Simplify and reuse code.
24447 * expression.cs (IndexerAccess, PropertyExpr): Implement
24448 IAssignMethod, clean up old code.
24450 2001-10-22 Ravi Pratap <ravi@ximian.com>
24452 * typemanager.cs (ImplementsInterface): New method to determine if a type
24453 implements a given interface. Provides a nice cache too.
24455 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
24458 (ConvertReferenceExplicit): Ditto.
24460 * delegate.cs (Delegate::Populate): Update to define the parameters on the
24461 various methods, with correct names etc.
24463 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
24464 Operator.UnaryNegation.
24466 * cs-parser.jay (operator_declarator): Be a little clever in the case where
24467 we have a unary plus or minus operator.
24469 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
24472 * everywhere : update accordingly.
24474 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
24477 * class.cs (Method::Define): For the case where we are implementing a method
24478 inherited from an interface, we need to set the MethodAttributes.Final flag too.
24479 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
24481 2001-10-21 Ravi Pratap <ravi@ximian.com>
24483 * interface.cs (FindMembers): Implement to work around S.R.E
24486 * typemanager.cs (IsInterfaceType): Implement.
24488 (FindMembers): Update to handle interface types too.
24490 * expression.cs (ImplicitReferenceConversion): Re-write bits which
24491 use IsAssignableFrom as that is not correct - it doesn't work.
24493 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
24494 and accordingly override EmitStatement.
24496 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
24497 using the correct logic :-)
24499 2001-10-19 Ravi Pratap <ravi@ximian.com>
24501 * ../errors/cs-11.cs : Add to demonstrate error -11
24503 2001-10-17 Miguel de Icaza <miguel@ximian.com>
24505 * assign.cs (Assign::Resolve): Resolve right hand side first, and
24506 then pass this as a hint to ResolveLValue.
24508 * expression.cs (FieldExpr): Add Location information
24510 (FieldExpr::LValueResolve): Report assignment to readonly
24513 (Expression::ExprClassFromMemberInfo): Pass location information.
24515 (Expression::ResolveLValue): Add new method that resolves an
24518 (Expression::DoResolveLValue): Default invocation calls
24521 (Indexers): New class used to keep track of indexers in a given
24524 (IStackStore): Renamed from LValue, as it did not really describe
24525 what this did. Also ResolveLValue is gone from this interface and
24526 now is part of Expression.
24528 (ElementAccess): Depending on the element access type
24530 * typemanager.cs: Add `indexer_name_type' as a Core type
24531 (System.Runtime.CompilerServices.IndexerNameAttribute)
24533 * statement.cs (Goto): Take a location.
24535 2001-10-18 Ravi Pratap <ravi@ximian.com>
24537 * delegate.cs (Delegate::VerifyDelegate): New method to verify
24538 if two delegates are compatible.
24540 (NewDelegate::DoResolve): Update to take care of the case when
24541 we instantiate a delegate from another delegate.
24543 * typemanager.cs (FindMembers): Don't even try to look up members
24544 of Delegate types for now.
24546 2001-10-18 Ravi Pratap <ravi@ximian.com>
24548 * delegate.cs (NewDelegate): New class to take care of delegate
24551 * expression.cs (New): Split the delegate related code out into
24552 the NewDelegate class.
24554 * delegate.cs (DelegateInvocation): New class to handle delegate
24557 * expression.cs (Invocation): Split out delegate related code into
24558 the DelegateInvocation class.
24560 2001-10-17 Ravi Pratap <ravi@ximian.com>
24562 * expression.cs (New::DoResolve): Implement delegate creation fully
24563 and according to the spec.
24565 (New::DoEmit): Update to handle delegates differently.
24567 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
24568 because of which we were printing out arguments in reverse order !
24570 * delegate.cs (VerifyMethod): Implement to check if the given method
24571 matches the delegate.
24573 (FullDelegateDesc): Implement.
24575 (VerifyApplicability): Implement.
24577 * expression.cs (Invocation::DoResolve): Update to accordingly handle
24578 delegate invocations too.
24580 (Invocation::Emit): Ditto.
24582 * ../errors/cs1593.cs : Added.
24584 * ../errors/cs1594.cs : Added.
24586 * delegate.cs (InstanceExpression, TargetMethod): New properties.
24588 2001-10-16 Ravi Pratap <ravi@ximian.com>
24590 * typemanager.cs (intptr_type): Core type for System.IntPtr
24592 (InitCoreTypes): Update for the same.
24594 (iasyncresult_type, asynccallback_type): Ditto.
24596 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
24599 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
24602 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
24603 the builders for the 4 members of a delegate type :-)
24605 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
24608 * expression.cs (New::DoResolve): Implement guts for delegate creation.
24610 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
24612 2001-10-15 Miguel de Icaza <miguel@ximian.com>
24614 * statement.cs (Break::Emit): Implement.
24615 (Continue::Emit): Implement.
24617 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
24618 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
24619 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
24620 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
24623 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
24624 properties that track the label for the current loop (begin of the
24625 loop and end of the loop).
24627 2001-10-15 Ravi Pratap <ravi@ximian.com>
24629 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
24630 use of emitting anything at all.
24632 * class.cs, rootcontext.cs : Get rid of calls to the same.
24634 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
24636 (Populate): Define the constructor correctly and set the implementation
24639 * typemanager.cs (delegate_types): New hashtable to hold delegates that
24642 (AddDelegateType): Implement.
24644 (IsDelegateType): Implement helper method.
24646 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
24648 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
24649 and accordingly handle it.
24651 * delegate.cs (Populate): Take TypeContainer argument.
24652 Implement bits to define the Invoke method. However, I still haven't figured out
24653 how to take care of the native int bit :-(
24655 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
24656 Qualify the name of the delegate, not its return type !
24658 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
24661 (StandardConversionExists): Checking for array types turns out to be recursive.
24663 (ConvertReferenceExplicit): Implement array conversion.
24665 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
24667 2001-10-12 Ravi Pratap <ravi@ximian.com>
24669 * cs-parser.jay (delegate_declaration): Store the fully qualified
24670 name as it is a type declaration.
24672 * delegate.cs (ReturnType, Name): Rename members to these. Make them
24675 (DefineDelegate): Renamed from Define. Does the same thing essentially,
24676 as TypeContainer::DefineType.
24678 (Populate): Method in which all the definition of the various methods (Invoke)
24681 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
24684 (CloseDelegate): Finally creates the delegate.
24686 * class.cs (TypeContainer::DefineType): Update to define delegates.
24687 (Populate, Emit and CloseType): Do the same thing here too.
24689 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
24690 delegates in all these operations.
24692 2001-10-14 Miguel de Icaza <miguel@ximian.com>
24694 * expression.cs: LocalTemporary: a new expression used to
24695 reference a temporary that has been created.
24697 * assign.cs: Handle PropertyAccess back here, so that we can
24698 provide the proper semantic access to properties.
24700 * expression.cs (Expression::ConvertReferenceExplicit): Implement
24701 a few more explicit conversions.
24703 * modifiers.cs: `NEW' modifier maps to HideBySig.
24705 * expression.cs (PropertyExpr): Make this into an
24706 ExpressionStatement, and support the EmitStatement code path.
24708 Perform get/set error checking, clean up the interface.
24710 * assign.cs: recognize PropertyExprs as targets, and if so, turn
24711 them into toplevel access objects.
24713 2001-10-12 Miguel de Icaza <miguel@ximian.com>
24715 * expression.cs: PropertyExpr::PropertyExpr: use work around the
24718 * typemanager.cs: Keep track here of our PropertyBuilders again to
24719 work around lameness in SRE.
24721 2001-10-11 Miguel de Icaza <miguel@ximian.com>
24723 * expression.cs (LValue::LValueResolve): New method in the
24724 interface, used to perform a second resolution pass for LValues.
24726 (This::DoResolve): Catch the use of this in static methods.
24728 (This::LValueResolve): Implement.
24730 (This::Store): Remove warning, assigning to `this' in structures
24733 (Invocation::Emit): Deal with invocation of
24734 methods on value types. We need to pass the address to structure
24735 methods rather than the object itself. (The equivalent code to
24736 emit "this" for structures leaves the entire structure on the
24737 stack instead of a pointer to it).
24739 (ParameterReference::DoResolve): Compute the real index for the
24740 argument based on whether the method takes or not a `this' pointer
24741 (ie, the method is static).
24743 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
24744 value types returned from functions when we need to invoke a
24745 method on the sturcture.
24748 2001-10-11 Ravi Pratap <ravi@ximian.com>
24750 * class.cs (TypeContainer::DefineType): Method to actually do the business of
24751 defining the type in the Modulebuilder or Typebuilder. This is to take
24752 care of nested types which need to be defined on the TypeBuilder using
24753 DefineNestedMethod.
24755 (TypeContainer::GetClassBases): Implement. Essentially the code from the
24756 methods in RootContext, only ported to be part of TypeContainer.
24758 (TypeContainer::GetInterfaceOrClass): Ditto.
24760 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
24762 * interface.cs (Interface::DefineInterface): New method. Does exactly
24763 what RootContext.CreateInterface did earlier, only it takes care of nested types
24766 (Interface::GetInterfaces): Move from RootContext here and port.
24768 (Interface::GetInterfaceByName): Same here.
24770 * rootcontext.cs (ResolveTree): Re-write.
24772 (PopulateTypes): Re-write.
24774 * class.cs (TypeContainer::Populate): Populate nested types too.
24775 (TypeContainer::Emit): Emit nested members too.
24777 * typemanager.cs (AddUserType): Do not make use of the FullName property,
24778 instead just use the name argument passed in as it is already fully
24781 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
24782 to TypeContainer mapping to see if a type is user-defined.
24784 * class.cs (TypeContainer::CloseType): Implement.
24786 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
24787 the default constructor.
24789 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
24792 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
24794 * interface.cs (CloseType): Create the type here.
24796 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
24799 Remove all the methods which are now in TypeContainer.
24801 2001-10-10 Ravi Pratap <ravi@ximian.com>
24803 * delegate.cs (Define): Re-write bits to define the delegate
24806 2001-10-10 Miguel de Icaza <miguel@ximian.com>
24808 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
24810 * expression.cs (ImplicitReferenceConversion): handle null as well
24811 as a source to convert to any reference type.
24813 * statement.cs (Return): Perform any implicit conversions to
24814 expected return type.
24816 Validate use of return statement.
24818 * codegen.cs (EmitContext): Pass the expected return type here.
24820 * class.cs (Method, Constructor, Property): Pass expected return
24821 type to EmitContext.
24823 2001-10-09 Miguel de Icaza <miguel@ximian.com>
24825 * expression.cs: Make DoResolve take an EmitContext instead of a
24828 Replaced `l' and `location' for `loc', for consistency.
24830 (Error, Warning): Remove unneeded Tc argument.
24832 * assign.cs, literal.cs, constant.cs: Update to new calling
24835 * codegen.cs: EmitContext now contains a flag indicating whether
24836 code is being generated in a static method or not.
24838 * cs-parser.jay: DecomposeQI, new function that replaces the old
24839 QualifiedIdentifier. Now we always decompose the assembled
24840 strings from qualified_identifier productions into a group of
24843 2001-10-08 Miguel de Icaza <miguel@ximian.com>
24845 * rootcontext.cs: Deal with field-less struct types correctly now
24846 by passing the size option to Define Type.
24848 * class.cs: Removed hack that created one static field.
24850 2001-10-07 Miguel de Icaza <miguel@ximian.com>
24852 * statement.cs: Moved most of the code generation here.
24854 2001-10-09 Ravi Pratap <ravi@ximian.com>
24856 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
24859 (ElementAccess): Remove useless bits for now - keep checks as the spec
24862 2001-10-08 Ravi Pratap <ravi@ximian.com>
24864 * expression.cs (ElementAccess::DoResolve): Remove my crap code
24865 and start performing checks according to the spec.
24867 2001-10-07 Ravi Pratap <ravi@ximian.com>
24869 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
24870 rank_specifiers instead.
24872 (rank_specifiers): Change the order in which the rank specifiers are stored
24874 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
24876 * expression.cs (ElementAccess): Implement the LValue interface too.
24878 2001-10-06 Ravi Pratap <ravi@ximian.com>
24880 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
24881 except that user defined conversions are not included.
24883 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
24884 perform the conversion of the return type, if necessary.
24886 (New::DoResolve): Check whether we are creating an array or an object
24887 and accordingly do the needful.
24889 (New::Emit): Same here.
24891 (New::DoResolve): Implement guts of array creation.
24893 (New::FormLookupType): Helper function.
24895 2001-10-07 Miguel de Icaza <miguel@ximian.com>
24897 * codegen.cs: Removed most of the code generation here, and move the
24898 corresponding code generation bits to the statement classes.
24900 Added support for try/catch/finalize and throw.
24902 * cs-parser.jay: Added support for try/catch/finalize.
24904 * class.cs: Catch static methods having the flags override,
24905 virtual or abstract.
24907 * expression.cs (UserCast): This user cast was not really doing
24908 what it was supposed to do. Which is to be born in fully resolved
24909 state. Parts of the resolution were being performed at Emit time!
24913 2001-10-05 Miguel de Icaza <miguel@ximian.com>
24915 * expression.cs: Implicity convert the result from UserCast.
24917 2001-10-05 Ravi Pratap <ravi@ximian.com>
24919 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
24920 prevented it from working correctly.
24922 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
24923 merely ConvertImplicit.
24925 2001-10-05 Miguel de Icaza <miguel@ximian.com>
24927 * typemanager.cs: Make the LookupTypeContainer function static,
24928 and not per-instance.
24930 * class.cs: Make static FindMembers (the one that takes a Type
24933 * codegen.cs: Add EmitForeach here.
24935 * cs-parser.jay: Make foreach a toplevel object instead of the
24936 inline expansion, as we need to perform semantic analysis on it.
24938 2001-10-05 Ravi Pratap <ravi@ximian.com>
24940 * expression.cs (Expression::ImplicitUserConversion): Rename to
24941 UserDefinedConversion.
24943 (Expression::UserDefinedConversion): Take an extra argument specifying
24944 whether we look for explicit user conversions too.
24946 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
24948 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
24950 (ExplicitUserConversion): Make it a call to UserDefinedConversion
24951 with the appropriate arguments.
24953 * cs-parser.jay (cast_expression): Record location too.
24955 * expression.cs (Cast): Record location info.
24957 (Expression::ConvertExplicit): Take location argument.
24959 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
24960 to determine if we are doing explicit conversions.
24962 (UserCast::Emit): Update accordingly.
24964 (Expression::ConvertExplicit): Report an error if everything fails.
24966 * ../errors/cs0030.cs : Add.
24968 2001-10-04 Miguel de Icaza <miguel@ximian.com>
24970 * modifiers.cs: If the ABSTRACT keyword is present, also set the
24971 virtual and newslot bits.
24973 * class.cs (TypeContainer::RegisterRequiredImplementations):
24974 Record methods we need.
24976 (TypeContainer::MakeKey): Helper function to make keys for
24977 MethodBases, since the Methodbase key is useless.
24979 (TypeContainer::Populate): Call RegisterRequiredImplementations
24980 before defining the methods.
24982 Create a mapping for method_builders_to_methods ahead of time
24983 instead of inside a tight loop.
24985 (::RequireMethods): Accept an object as the data to set into the
24986 hashtable so we can report interface vs abstract method mismatch.
24988 2001-10-03 Miguel de Icaza <miguel@ximian.com>
24990 * report.cs: Make all of it static.
24992 * rootcontext.cs: Drop object_type and value_type computations, as
24993 we have those in the TypeManager anyways.
24995 Drop report instance variable too, now it is a global.
24997 * driver.cs: Use try/catch on command line handling.
24999 Add --probe option to debug the error reporting system with a test
25002 * report.cs: Add support for exiting program when a probe
25003 condition is reached.
25005 2001-10-03 Ravi Pratap <ravi@ximian.com>
25007 * expression.cs (Binary::DoNumericPromotions): Fix the case when
25008 we do a forcible conversion regardless of type, to check if
25009 ForceConversion returns a null.
25011 (Binary::error19): Use location to report error.
25013 (Unary::error23): Use location here too.
25015 * ../errors/cs0019.cs : Check in.
25017 * ../errors/cs0023.cs : Check in.
25019 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
25020 case of a non-null MethodInfo object with a length of 0 !
25022 (Binary::ResolveOperator): Flag error if overload resolution fails to find
25023 an applicable member - according to the spec :-)
25024 Also fix logic to find members in base types.
25026 (Unary::ResolveOperator): Same here.
25028 (Unary::report23): Change name to error23 and make first argument a TypeContainer
25029 as I was getting thoroughly confused between this and error19 :-)
25031 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
25032 (::FindMostEncompassedType): Implement.
25033 (::FindMostEncompassingType): Implement.
25034 (::StandardConversionExists): Implement.
25036 (UserImplicitCast): Re-vamp. We now need info about most specific
25037 source and target types so that we can do the necessary conversions.
25039 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
25040 mathematical union with no duplicates.
25042 2001-10-03 Miguel de Icaza <miguel@ximian.com>
25044 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
25045 in order from base classes to child classes, so that we can in
25046 child classes look up in our parent for method names and
25047 attributes (required for handling abstract, virtual, new, override
25048 constructs: we need to instrospect our base class, and if we dont
25049 populate the classes in order, the introspection might be
25050 incorrect. For example, a method could query its parent before
25051 the parent has any methods and would determine that the parent has
25052 no abstract methods (while it could have had them)).
25054 (RootContext::CreateType): Record the order in which we define the
25057 2001-10-02 Miguel de Icaza <miguel@ximian.com>
25059 * class.cs (TypeContainer::Populate): Also method definitions can
25060 fail now, keep track of this.
25062 (TypeContainer::FindMembers): Implement support for
25063 DeclaredOnly/noDeclaredOnly flag.
25065 (Constructor::Emit) Return the ConstructorBuilder.
25067 (Method::Emit) Return the MethodBuilder.
25068 Check for abstract or virtual methods to be public.
25070 * rootcontext.cs (RootContext::CreateType): Register all the
25071 abstract methods required for the class to be complete and the
25072 interface methods that must be implemented.
25074 * cs-parser.jay: Report error 501 (method requires body if it is
25075 not marked abstract or extern).
25077 * expression.cs (TypeOf::Emit): Implement.
25079 * typemanager.cs: runtime_handle_type, new global type.
25081 * class.cs (Property::Emit): Generate code for properties.
25083 2001-10-02 Ravi Pratap <ravi@ximian.com>
25085 * expression.cs (Unary::ResolveOperator): Find operators on base type
25086 too - we now conform exactly to the spec.
25088 (Binary::ResolveOperator): Same here.
25090 * class.cs (Operator::Define): Fix minor quirk in the tests.
25092 * ../errors/cs0215.cs : Added.
25094 * ../errors/cs0556.cs : Added.
25096 * ../errors/cs0555.cs : Added.
25098 2001-10-01 Miguel de Icaza <miguel@ximian.com>
25100 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
25101 single integer which is really efficient
25103 2001-10-01 Ravi Pratap <ravi@ximian.com>
25105 * expression.cs (Expression::ImplicitUserConversion): Use location
25106 even in the case when we are examining True operators.
25108 * class.cs (Operator::Define): Perform extensive checks to conform
25109 with the rules for operator overloading in the spec.
25111 * expression.cs (Expression::ImplicitReferenceConversion): Implement
25112 some of the other conversions mentioned in the spec.
25114 * typemanager.cs (array_type): New static member for the System.Array built-in
25117 (cloneable_interface): For System.ICloneable interface.
25119 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
25120 we start resolving the tree and populating types.
25122 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
25124 2001-10-01 Miguel de Icaza <miguel@ximian.com>
25126 * expression.cs (Expression::ExprClassFromMemberInfo,
25127 Expression::Literalize): Create literal expressions from
25128 FieldInfos which are literals.
25130 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
25131 type casts, because they were wrong. The test suite in tests
25134 (ImplicitNumericConversion): ushort to ulong requires a widening
25137 Int32 constant to long requires widening cast as well.
25139 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
25140 for integers because the type on the stack is not i4.
25142 2001-09-30 Miguel de Icaza <miguel@ximian.com>
25144 * expression.cs (report118): require location argument.
25146 * parameter.cs: Do not dereference potential null value.
25148 * class.cs: Catch methods that lack the `new' keyword when
25149 overriding a name. Report warnings when `new' is used without
25150 anything being there to override.
25152 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
25154 * class.cs: Only add constructor to hashtable if it is non-null
25155 (as now constructors can fail on define).
25157 (TypeManager, Class, Struct): Take location arguments.
25159 Catch field instance initialization in structs as errors.
25161 accepting_filter: a new filter for FindMembers that is static so
25162 that we dont create an instance per invocation.
25164 (Constructor::Define): Catch errors where a struct constructor is
25167 * cs-parser.jay: Pass location information for various new
25170 * delegate.cs (Delegate): take a location argument.
25172 * driver.cs: Do not call EmitCode if there were problesm in the
25173 Definition of the types, as many Builders wont be there.
25175 * decl.cs (Decl::Decl): Require a location argument.
25177 * cs-tokenizer.cs: Handle properly hex constants that can not fit
25178 into integers, and find the most appropiate integer for it.
25180 * literal.cs: Implement ULongLiteral.
25182 * rootcontext.cs: Provide better information about the location of
25183 failure when CreateType fails.
25185 2001-09-29 Miguel de Icaza <miguel@ximian.com>
25187 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
25190 * expression.cs (Binary::CheckShiftArguments): Add missing type
25192 (Binary::ResolveOperator): Add type to the logical and and logical
25193 or, Bitwise And/Or and Exclusive Or code paths, it was missing
25196 (Binary::DoNumericPromotions): In the case where either argument
25197 is ulong (and most signed types combined with ulong cause an
25198 error) perform implicit integer constant conversions as well.
25200 2001-09-28 Miguel de Icaza <miguel@ximian.com>
25202 * expression.cs (UserImplicitCast): Method should always be
25204 (Invocation::BetterConversion): Simplified test for IntLiteral.
25206 (Expression::ImplicitNumericConversion): Split this routine out.
25207 Put the code that performs implicit constant integer conversions
25210 (Expression::Resolve): Become a wrapper around DoResolve so we can
25211 check eclass and type being set after resolve.
25213 (Invocation::Badness): Remove this dead function
25215 (Binary::ResolveOperator): Do not compute the expensive argumnets
25216 unless we have a union for it.
25218 (Probe::Emit): Is needs to do an isinst and then
25219 compare against null.
25221 (::CanConvert): Added Location argument. If the Location argument
25222 is null (Location.Null), then we do not report errors. This is
25223 used by the `probe' mechanism of the Explicit conversion. We do
25224 not want to generate an error for something that the user
25225 explicitly requested to be casted. But the pipeline for an
25226 explicit cast first tests for potential implicit casts.
25228 So for now, if the Location is null, it means `Probe only' to
25229 avoid adding another argument. Might have to revise this
25232 (ClassCast): New class used to type cast objects into arbitrary
25233 classes (used in Explicit Reference Conversions).
25235 Implement `as' as well.
25237 Reverted all the patches from Ravi below: they were broken:
25239 * The use of `level' as a mechanism to stop recursive
25240 invocations is wrong. That was there just to catch the
25241 bug with a strack trace but not as a way of addressing
25244 To fix the problem we have to *understand* what is going
25245 on and the interactions and come up with a plan, not
25246 just get things going.
25248 * The use of the type conversion cache that I proposed
25249 last night had an open topic: How does this work across
25250 protection domains. A user defined conversion might not
25251 be public in the location where we are applying the
25252 conversion, a different conversion might be selected
25253 (ie, private A->B (better) but public B->A (worse),
25254 inside A, A->B applies, but outside it, B->A will
25257 * On top of that (ie, even if the above is solved),
25258 conversions in a cache need to be abstract. Ie, `To
25259 convert from an Int to a Short use an OpcodeCast', not
25260 `To convert from an Int to a Short use the OpcodeCast on
25261 the variable 5' (which is what this patch was doing).
25263 2001-09-28 Ravi Pratap <ravi@ximian.com>
25265 * expression.cs (Invocation::ConversionExists): Re-write to use
25266 the conversion cache
25268 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
25269 cache all conversions done, not just user-defined ones.
25271 (Invocation::BetterConversion): The real culprit. Use ConversionExists
25272 to determine if a conversion exists instead of acutually trying to
25273 perform the conversion. It's faster too.
25275 (Expression::ConvertExplicit): Modify to use ConversionExists to check
25276 and only then attempt the implicit conversion.
25278 2001-09-28 Ravi Pratap <ravi@ximian.com>
25280 * expression.cs (ConvertImplicit): Use a cache for conversions
25281 already found. Check level of recursion and bail out if necessary.
25283 2001-09-28 Miguel de Icaza <miguel@ximian.com>
25285 * typemanager.cs (string_concat_string_string, string_concat_object_object):
25286 Export standard methods that we expect for string operations.
25288 * statement.cs (Block::UsageWarning): Track usage of variables and
25289 report the errors for not used variables.
25291 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
25294 2001-09-27 Miguel de Icaza <miguel@ximian.com>
25296 * codegen.cs: remove unnneded code
25298 * expression.cs: Removed BuiltinTypeAccess class
25300 Fix the order in which implicit conversions are
25303 The previous fixed dropped support for boxed conversions (adding a
25304 test to the test suite now)
25306 (UserImplicitCast::CanConvert): Remove test for source being null,
25307 that code is broken. We should not feed a null to begin with, if
25308 we do, then we should track the bug where the problem originates
25309 and not try to cover it up here.
25311 Return a resolved expression of type UserImplicitCast on success
25312 rather than true/false. Ravi: this is what I was talking about,
25313 the pattern is to use a static method as a "constructor" for
25316 Also, do not create arguments until the very last minute,
25317 otherwise we always create the arguments even for lookups that
25318 will never be performed.
25320 (UserImplicitCast::Resolve): Eliminate, objects of type
25321 UserImplicitCast are born in a fully resolved state.
25323 * typemanager.cs (InitCoreTypes): Init also value_type
25324 (System.ValueType).
25326 * expression.cs (Cast::Resolve): First resolve the child expression.
25328 (LValue): Add new method AddressOf to be used by
25331 Change the argument of Store to take an EmitContext instead of an
25332 ILGenerator, because things like FieldExpr need to be able to call
25333 their children expression to generate the instance code.
25335 (Expression::Error, Expression::Warning): Sugar functions for
25338 (Expression::MemberLookup): Accept a TypeContainer instead of a
25339 Report as the first argument.
25341 (Expression::ResolvePrimary): Killed. I still want to improve
25342 this as currently the code is just not right.
25344 (Expression::ResolveMemberAccess): Simplify, but it is still
25347 (Unary::Resolve): Catch errors in AddressOf operators.
25349 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
25350 index to a byte for the short-version, or the compiler will choose
25351 the wrong Emit call, which generates the wrong data.
25353 (ParameterReference::Emit, ::Store): same.
25355 (FieldExpr::AddressOf): Implement.
25357 * typemanager.cs: TypeManager: made public variable instead of
25360 * driver.cs: document --fatal.
25362 * report.cs (ErrorMessage, WarningMessage): new names for the old
25363 Error and Warning classes.
25365 * cs-parser.jay (member_access): Turn built-in access to types
25366 into a normal simplename
25368 2001-09-27 Ravi Pratap <ravi@ximian.com>
25370 * expression.cs (Invocation::BetterConversion): Fix to cope
25371 with q being null, since this was introducing a bug.
25373 * expression.cs (ConvertImplicit): Do built-in conversions first.
25375 2001-09-27 Ravi Pratap <ravi@ximian.com>
25377 * expression.cs (UserImplicitCast::Resolve): Fix bug.
25379 2001-09-27 Ravi Pratap <ravi@ximian.com>
25381 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
25382 I had introduced long ago (what's new ?).
25384 * expression.cs (UserImplicitCast::CanConvert): Static method to do
25385 the work of all the checking.
25386 (ConvertImplicit): Call CanConvert and only then create object if necessary.
25387 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
25389 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
25390 that is the right way.
25392 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
25393 overloading resolution. Use everywhere instead of cutting and pasting code.
25395 (Binary::ResolveOperator): Use MakeUnionSet.
25397 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
25398 we have to convert to bool types. Not complete yet.
25400 2001-09-27 Miguel de Icaza <miguel@ximian.com>
25402 * typemanager.cs (TypeManager::CSharpName): support ushort.
25404 * expression.cs (Expression::TryImplicitIntConversion): Attempts
25405 to provide an expression that performsn an implicit constant int
25406 conversion (section 6.1.6).
25407 (Expression::ConvertImplicitRequired): Reworked to include
25408 implicit constant expression conversions.
25410 (Expression::ConvertNumericExplicit): Finished.
25412 (Invocation::Emit): If InstanceExpression is null, then it means
25413 that we perform a call on this.
25415 2001-09-26 Miguel de Icaza <miguel@ximian.com>
25417 * expression.cs (Unary::Emit): Remove some dead code.
25418 (Probe): Implement Resolve and Emit for `is'.
25419 (Expression::ConvertImplicitRequired): Attempt to do constant
25420 expression conversions here. Maybe should be moved to
25421 ConvertImplicit, but I am not sure.
25422 (Expression::ImplicitLongConstantConversionPossible,
25423 Expression::ImplicitIntConstantConversionPossible): New functions
25424 that tell whether is it possible to apply an implicit constant
25425 expression conversion.
25427 (ConvertNumericExplicit): Started work on explicit numeric
25430 * cs-parser.jay: Update operator constants.
25432 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
25433 (Parameters::GetSignature): Hook up VerifyArgs here.
25434 (Parameters::VerifyArgs): Verifies that no two arguments have the
25437 * class.cs (Operator): Update the operator names to reflect the
25438 ones that the spec expects (as we are just stringizing the
25441 * expression.cs (Unary::ResolveOperator): Fix bug: Use
25442 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
25443 previous usage did only work for our methods.
25444 (Expression::ConvertImplicit): Handle decimal implicit numeric
25445 conversions as well.
25446 (Expression::InternalTypeConstructor): Used to invoke constructors
25447 on internal types for default promotions.
25449 (Unary::Emit): Implement special handling for the pre/post
25450 increment/decrement for overloaded operators, as they need to have
25451 the same semantics as the other operators.
25453 (Binary::ResolveOperator): ditto.
25454 (Invocation::ConversionExists): ditto.
25455 (UserImplicitCast::Resolve): ditto.
25457 2001-09-26 Ravi Pratap <ravi@ximian.com>
25459 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
25460 operator, return after emitting body. Regression tests pass again !
25462 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
25463 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
25464 (Invocation::OverloadResolve): Ditto.
25465 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
25467 * everywhere : update calls to the above methods accordingly.
25469 2001-09-26 Miguel de Icaza <miguel@ximian.com>
25471 * assign.cs (Assign): Make it inherit from ExpressionStatement.
25473 * expression.cs (ExpressionStatement): New base class used for
25474 expressions that can appear in statements, so that we can provide
25475 an alternate path to generate expression that do not leave a value
25478 (Expression::Emit, and all the derivatives): We no longer return
25479 whether a value is left on the stack or not. Every expression
25480 after being emitted leaves a single value on the stack.
25482 * codegen.cs (EmitContext::EmitStatementExpression): Use the
25483 facilties of ExpressionStatement if possible.
25485 * cs-parser.jay: Update statement_expression.
25487 2001-09-25 Miguel de Icaza <miguel@ximian.com>
25489 * driver.cs: Change the wording of message
25491 2001-09-25 Ravi Pratap <ravi@ximian.com>
25493 * expression.cs (Binary::ResolveOperator): Had forgottten to set
25494 the type of the expression to the return type of the method if
25495 we have an overloaded operator match ! The regression tests pass again !
25496 (Unary::ResolveOperator): Ditto.
25498 * expression.cs (Invocation::ConversionExists): Correct the member lookup
25499 to find "op_Implicit", not "implicit" ;-)
25500 (UserImplicitCast): New class to take care of user-defined implicit conversions.
25501 (ConvertImplicit, ForceConversion): Take TypeContainer argument
25503 * everywhere : Correct calls to the above accordingly.
25505 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
25506 (ConvertImplicit): Do user-defined conversion if it exists.
25508 2001-09-24 Miguel de Icaza <miguel@ximian.com>
25510 * assign.cs: track location.
25511 (Resolve): Use implicit conversions on assignment.
25513 * literal.cs: Oops. Not good, Emit of short access values should
25514 pass (Bytes) or the wrong argument will be selected.
25516 * expression.cs (Unary::Emit): Emit code for -expr.
25518 (Unary::ResolveOperator): Handle `Substract' for non-constants
25519 (substract from zero from the non-constants).
25520 Deal with Doubles as well.
25522 (Expression::ConvertImplicitRequired): New routine that reports an
25523 error if no implicit conversion exists.
25525 (Invocation::OverloadResolve): Store the converted implicit
25526 expressions if we make them
25528 2001-09-24 Ravi Pratap <ravi@ximian.com>
25530 * class.cs (ConstructorInitializer): Take a Location argument.
25531 (ConstructorBaseInitializer): Same here.
25532 (ConstructorThisInitializer): Same here.
25534 * cs-parser.jay : Update all calls accordingly.
25536 * expression.cs (Unary, Binary, New): Take location argument.
25537 Update accordingly everywhere.
25539 * cs-parser.jay : Update all calls to the above to take a location
25542 * class.cs : Ditto.
25544 2001-09-24 Ravi Pratap <ravi@ximian.com>
25546 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
25547 (Invocation::BetterConversion): Same here
25548 (Invocation::ConversionExists): Ditto.
25550 (Invocation::ConversionExists): Implement.
25552 2001-09-22 Ravi Pratap <ravi@ximian.com>
25554 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
25555 Also take an additional TypeContainer argument.
25557 * All over : Pass in TypeContainer as argument to OverloadResolve.
25559 * typemanager.cs (CSharpName): Update to check for the string type and return
25562 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
25565 2001-09-21 Ravi Pratap <ravi@ximian.com>
25567 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
25568 (Invocation::BetterFunction): Implement.
25569 (Invocation::BetterConversion): Implement.
25570 (Invocation::ConversionExists): Skeleton, no implementation yet.
25572 Okay, things work fine !
25574 2001-09-21 Miguel de Icaza <miguel@ximian.com>
25576 * typemanager.cs: declare and load enum_type, delegate_type and
25579 * expression.cs (Expression::Emit): Now emit returns a value that
25580 tells whether a value is left on the stack or not. This strategy
25581 might be reveted tomorrow with a mechanism that would address
25582 multiple assignments.
25583 (Expression::report118): Utility routine to report mismatches on
25586 (Unary::Report23): Report impossible type/operator combination
25589 (Unary::IsIncrementableNumber): Whether the type can be
25590 incremented or decremented with add.
25591 (Unary::ResolveOperator): Also allow enumerations to be bitwise
25593 (Unary::ResolveOperator): Implement ++, !, ~,
25595 (Invocation::Emit): Deal with new Emit convetion.
25597 * All Expression derivatives: Updated their Emit method to return
25598 whether they leave values on the stack or not.
25600 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
25601 stack for expressions that are statements.
25603 2001-09-20 Miguel de Icaza <miguel@ximian.com>
25605 * expression.cs (LValue): New interface. Must be implemented by
25607 (LocalVariableReference, ParameterReference, FieldExpr): Implement
25610 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
25611 interface for generating code, simplifies the code.
25613 2001-09-20 Ravi Pratap <ravi@ximian.com>
25615 * expression.cs (everywhere): Comment out return statements in ::Resolve
25616 methods to avoid the warnings.
25618 2001-09-20 Miguel de Icaza <miguel@ximian.com>
25620 * driver.cs (parse): Report error 2001 if we can not open the
25623 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
25626 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
25629 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
25630 otherwise nested blocks end up with the same index.
25632 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
25634 * expression.cs: Instead of having FIXMEs in the Resolve
25635 functions, throw exceptions so it is obvious that we are facing a
25638 * cs-parser.jay (invocation_expression): Pass Location information.
25640 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
25641 Use a basename for those routines because .NET does not like paths
25644 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
25647 2001-09-19 Miguel de Icaza <miguel@ximian.com>
25649 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
25650 are loading the correct data types (throws an exception if not).
25651 (TypeManager::InitCoreTypes): Use CoreLookupType
25653 * expression.cs (Unary::ResolveOperator): return the child
25654 expression for expressions which are just +expr.
25655 (Unary::ResolveOperator): Return negative literals for -LITERAL
25656 expressions (otherwise they are Unary {Literal}).
25657 (Invocation::Badness): Take into account `Implicit constant
25658 expression conversions'.
25660 * literal.cs (LongLiteral): Implement long literal class.
25661 (IntLiteral): export the `Value' of the intliteral.
25663 2001-09-19 Ravi Pratap <ravi@ximian.com>
25665 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
25667 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
25668 instead of 'Operator'
25670 * expression.cs (Binary::ResolveOperator): Update accordingly.
25671 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
25674 * cs-parser.jay (unary_expression): Update to use the new names.
25676 * gen-treedump.cs (GetUnary): Same here.
25678 * expression.cs (Unary::Resolve): Implement.
25679 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
25680 operators are found instead of making noise ;-)
25681 (Unary::ResolveOperator): New method to do precisely the same thing which
25682 Binary::ResolveOperator does for Binary expressions.
25683 (Unary.method, .Arguments): Add.
25684 (Unary::OperName): Implement.
25685 (Unary::ForceConversion): Copy and Paste !
25687 * class.cs (Operator::Define): Fix a small bug for the case when we have
25690 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
25691 for the inbuilt operators. Only overloading works for now ;-)
25693 2001-09-18 Miguel de Icaza <miguel@ximian.com>
25695 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
25696 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
25698 * expression.cs (This::Emit): Implement.
25699 (This::Resolve): Implement.
25700 (TypeOf:Resolve): Implement.
25701 (Expression::ResolveSimpleName): Add an implicit this to instance
25703 (MemberAccess::Resolve): Deal with Parameters and Fields.
25704 Bind instance variable to Field expressions.
25705 (FieldExpr::Instance): New field used to track the expression that
25706 represents the object instance.
25707 (FieldExpr::Resolve): Track potential errors from MemberLookup not
25709 (FieldExpr::Emit): Implement.
25711 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
25712 the last instruction contains a return opcode to avoid generating
25713 the last `ret' instruction (this generates correct code, and it is
25714 nice to pass the peverify output).
25716 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
25717 initializer for static and instance variables.
25718 (Constructor::Emit): Allow initializer to be null in the case of
25719 static constructors. Only emit initializer for instance
25722 (TypeContainer::FindMembers): Return a null array if there are no
25725 Also fix the code for the MemberTypes.Method branch, as it was not
25726 scanning that for operators (or tried to access null variables before).
25728 * assign.cs (Assign::Emit): Handle instance and static fields.
25732 * driver.cs: Stop compilation if there are parse errors.
25734 * cs-parser.jay (constructor_declaration): Provide default base
25735 initializer for non-static constructors.
25736 (constructor_declarator): Do not provide a default base
25737 initializers if none was specified.
25738 Catch the fact that constructors should not have parameters.
25740 * class.cs: Do not emit parent class initializers for static
25741 constructors, that should be flagged as an error.
25743 2001-09-18 Ravi Pratap <ravi@ximian.com>
25745 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
25746 Move back code into TypeContainer::Populate.
25748 2001-09-18 Ravi Pratap <ravi@ximian.com>
25750 * class.cs (TypeContainer::AddConstructor): Fix the check to
25751 compare against Name, not Basename.
25752 (Operator::OpType): Change Plus and Minus to Add and Subtract.
25754 * cs-parser.jay : Update accordingly.
25756 * class.cs (TypeContainer::FindMembers): For the case where we are searching
25757 for methods, don't forget to look into the operators too.
25758 (RegisterMethodBuilder): Helper method to take care of this for
25759 methods, constructors and operators.
25760 (Operator::Define): Completely revamp.
25761 (Operator.OperatorMethod, MethodName): New fields.
25762 (TypeContainer::Populate): Move the registering of builders into
25763 RegisterMethodBuilder.
25764 (Operator::Emit): Re-write.
25766 * expression.cs (Binary::Emit): Comment out code path to emit method
25767 invocation stuff for the case when we have a user defined operator. I am
25768 just not able to get it right !
25770 2001-09-17 Miguel de Icaza <miguel@ximian.com>
25772 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
25775 (Expression::MemberLookup): Provide a version that allows to
25776 specify the MemberTypes and BindingFlags.
25778 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
25779 so it was not fetching variable information from outer blocks.
25781 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
25782 Beforefieldinit as it was buggy.
25784 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
25785 that Ravi put here.
25787 * class.cs (Constructor::Emit): Only emit if block is not null.
25788 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
25789 deal with this by semantically definining it as if the user had
25792 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
25793 constructors as we now "emit" them at a higher level.
25795 (TypeContainer::DefineDefaultConstructor): Used to define the
25796 default constructors if none was provided.
25798 (ConstructorInitializer): Add methods Resolve and Emit.
25800 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
25802 2001-09-17 Ravi Pratap <ravi@ximian.com>
25804 * class.cs (TypeContainer::EmitDefaultConstructor): Register
25805 the default constructor builder with our hashtable for methodbuilders
25808 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
25809 and argument_count is 0 in which case we have a match.
25810 (Binary::ResolveOperator): More null checking and miscellaneous coding
25813 2001-09-17 Ravi Pratap <ravi@ximian.com>
25815 * rootcontext.cs (IsNameSpace): Compare against null.
25817 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
25819 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
25820 and Unary::Operator.
25822 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
25825 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
25826 we have overloaded operators.
25827 (Binary::ResolveOperator): Implement the part which does the operator overload
25830 * class.cs (Operator::Emit): Implement.
25831 (TypeContainer::Emit): Emit the operators we have too.
25833 * expression.cs (Binary::Emit): Update to emit the appropriate code for
25834 the case when we have a user-defined operator.
25836 2001-09-17 Miguel de Icaza <miguel@ximian.com>
25838 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
25840 2001-09-16 Ravi Pratap <ravi@ximian.com>
25842 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
25843 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
25844 (Constructor::Emit): Implement.
25845 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
25846 if we have no work to do.
25847 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
25850 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
25851 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
25853 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
25856 2001-09-15 Ravi Pratap <ravi@ximian.com>
25858 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
25860 (Tree::RecordNamespace): Method to do what the name says ;-)
25861 (Tree::Namespaces): Property to get at the namespaces hashtable.
25863 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
25866 * rootcontext.cs (IsNamespace): Fixed it :-)
25868 2001-09-14 Miguel de Icaza <miguel@ximian.com>
25870 * class.cs (TypeContainer::FindMembers): Add support for
25872 (MethodCore): New class that encapsulates both the shared aspects
25873 of a Constructor and a Method.
25874 (Method, Constructor): Factored pieces into MethodCore.
25876 * driver.cs: Added --fatal which makes errors throw exceptions.
25877 Load System assembly as well as part of the standard library.
25879 * report.cs: Allow throwing exceptions on errors for debugging.
25881 * modifiers.cs: Do not use `parent', instead use the real type
25882 container to evaluate permission settings.
25884 * class.cs: Put Ravi's patch back in. He is right, and we will
25885 have to cope with the
25887 2001-09-14 Ravi Pratap <ravi@ximian.com>
25889 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
25890 FamORAssem, not FamANDAssem.
25892 2001-09-14 Miguel de Icaza <miguel@ximian.com>
25894 * driver.cs: Added --parse option that only parses its input files
25897 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
25898 incorrect. IsTopLevel is not used to tell whether an object is
25899 root_types or not (that can be achieved by testing this ==
25900 root_types). But to see if this is a top-level *class* (not
25901 necessarly our "toplevel" container).
25903 2001-09-14 Ravi Pratap <ravi@ximian.com>
25905 * enum.cs (Enum::Define): Modify to call the Lookup method on the
25906 parent instead of a direct call to GetType.
25908 2001-09-14 Ravi Pratap <ravi@ximian.com>
25910 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
25911 Modifiers.TypeAttr. This should just be a call to that method.
25913 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
25914 object so that we can determine if we are top-level or not.
25916 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
25919 * enum.cs (Enum::Define): Ditto.
25921 * modifiers.cs (FieldAttr): Re-write.
25923 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
25924 (TypeContainer::HaveStaticConstructor): New property to provide access
25925 to precisely that info.
25927 * modifiers.cs (MethodAttr): Re-write.
25928 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
25930 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
25931 of top-level types as claimed.
25933 2001-09-13 Miguel de Icaza <miguel@ximian.com>
25935 * expression.cs (MemberLookup): Fruitless attempt to lookup
25936 constructors. Maybe I need to emit default constructors? That
25937 might be it (currently .NET emits this for me automatically).
25938 (Invocation::OverloadResolve): Cope with Arguments == null.
25939 (Invocation::EmitArguments): new function, shared by the new
25940 constructor and us.
25941 (Invocation::Emit): Handle static and instance methods. Emit
25942 proper call instruction for virtual or non-virtual invocations.
25943 (New::Emit): Implement.
25944 (New::Resolve): Implement.
25945 (MemberAccess:Resolve): Implement.
25946 (MethodGroupExpr::InstanceExpression): used conforming to the spec
25947 to track instances.
25948 (FieldExpr::Resolve): Set type.
25950 * support.cs: Handle empty arguments.
25952 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
25953 SimpleLookup): Auxiliary routines to help parse a qualifier
25956 Update qualifier_identifier rule.
25958 * codegen.cs: Removed debugging messages.
25960 * class.cs: Make this a global thing, this acts just as a "key" to
25961 objects that we might have around.
25963 (Populate): Only initialize method_builders_to_methods once.
25965 * expression.cs (PropertyExpr): Initialize type from the
25968 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
25969 Resolve pattern. Attempt to implicitly convert value to boolean.
25972 * expression.cs: Set the type for the int32/int32 argument case.
25973 (Binary::ResolveOperator): Set the return type to boolean for
25974 comparission operators
25976 * typemanager.cs: Remove debugging print code.
25978 (Invocation::Resolve): resolve type.
25980 * class.cs: Allocate a MemberInfo of the correct size, as the code
25981 elsewhere depends on the test to reflect the correct contents.
25983 (Method::) Keep track of parameters, due to System.Reflection holes
25985 (TypeContainer::Populate): Keep track of MethodBuilders to Method
25988 (TypeContainer::FindMembers): Use ArrayList and then copy an array
25989 of the exact size and return that.
25991 (Class::LookupMethodByBuilder): New function that maps
25992 MethodBuilders to its methods. Required to locate the information
25993 on methods because System.Reflection bit us again.
25995 * support.cs: New file, contains an interface ParameterData and
25996 two implementations: ReflectionParameters and InternalParameters
25997 used to access Parameter information. We will need to grow this
26000 * expression.cs (Invocation::GetParameterData): implement a cache
26001 and a wrapper around the ParameterData creation for methods.
26002 (Invocation::OverloadResolve): Use new code.
26004 2001-09-13 Ravi Pratap <ravi@ximian.com>
26006 * class.cs (TypeContainer::EmitField): Remove and move into
26007 (Field::Define): here and modify accordingly.
26008 (Field.FieldBuilder): New member.
26009 (TypeContainer::Populate): Update accordingly.
26010 (TypeContainer::FindMembers): Implement.
26012 2001-09-13 Miguel de Icaza <miguel@ximian.com>
26014 * statement.cs: (VariableInfo::VariableType): New field to be
26015 initialized with the full type once it is resolved.
26017 2001-09-12 Miguel de Icaza <miguel@ximian.com>
26019 * parameter.cs (GetParameterInfo): Use a type cache to compute
26020 things only once, and to reuse this information
26022 * expression.cs (LocalVariableReference::Emit): Implement.
26023 (OpcodeCast::Emit): fix.
26025 (ParameterReference::Resolve): Implement.
26026 (ParameterReference::Emit): Implement.
26028 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
26029 that are expressions need to stay as Expressions.
26031 * typemanager.cs (CSharpName): Returns the C# name of a type if
26034 * expression.cs (Expression::ConvertImplicit): New function that
26035 implements implicit type conversions.
26037 (Expression::ImplicitReferenceConversion): Implements implicit
26038 reference conversions.
26040 (EmptyCast): New type for transparent casts.
26042 (OpcodeCast): New type for casts of types that are performed with
26043 a sequence of bytecodes.
26045 (BoxedCast): New type used for casting value types into reference
26046 types. Emits a box opcode.
26048 (Binary::DoNumericPromotions): Implements numeric promotions of
26049 and computation of the Binary::Type.
26051 (Binary::EmitBranchable): Optimization.
26053 (Binary::Emit): Implement code emission for expressions.
26055 * typemanager.cs (TypeManager): Added two new core types: sbyte
26058 2001-09-12 Ravi Pratap <ravi@ximian.com>
26060 * class.cs (TypeContainer::FindMembers): Method which does exactly
26061 what Type.FindMembers does, only we don't have to use reflection. No
26062 implementation yet.
26064 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
26065 typecontainer objects as we need to get at them.
26066 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
26068 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
26069 typecontainer object.
26071 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
26072 of just a Report object.
26074 2001-09-11 Ravi Pratap <ravi@ximian.com>
26076 * class.cs (Event::Define): Go back to using the prefixes "add_" and
26078 (TypeContainer::Populate): Now define the delegates of the type too.
26079 (TypeContainer.Delegates): Property to access the list of delegates defined
26082 * delegates.cs (Delegate::Define): Implement partially.
26084 * modifiers.cs (TypeAttr): Handle more flags.
26086 2001-09-11 Ravi Pratap <ravi@ximian.com>
26088 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
26090 (Operator::Define): Re-write logic to get types by using the LookupType method
26091 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
26092 (Indexer::Define): Ditto.
26093 (Event::Define): Ditto.
26094 (Property::Define): Ditto.
26096 2001-09-10 Ravi Pratap <ravi@ximian.com>
26098 * class.cs (TypeContainer::Populate): Now define operators too.
26099 (TypeContainer.Operators): New property to access the list of operators
26101 (Operator.OperatorMethodBuilder): New member to hold the method builder
26102 for the operator we are defining.
26103 (Operator::Define): Implement.
26105 2001-09-10 Ravi Pratap <ravi@ximian.com>
26107 * class.cs (Event::Define): Make the prefixes of the accessor methods
26108 addOn_ and removeOn_
26110 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
26111 of the location being passed in too. Ideally, this should go later since all
26112 error reporting should be done through the Report object.
26114 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
26115 (Populate): Iterate thru the indexers we have and define them too.
26116 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
26117 for the get and set accessors.
26118 (Indexer::Define): Implement.
26120 2001-09-09 Miguel de Icaza <miguel@ximian.com>
26122 * expression.cs (Binary::Resolve): Beginning of it. I scratched
26123 my previous implementation, did not work.
26125 * typemanager.cs: Add a couple of missing types (the longs).
26127 * literal.cs: Use TypeManager.bool_type instead of getting it.
26129 * expression.cs (EventExpr): New kind of expressions.
26130 (Expressio::ExprClassFromMemberInfo): finish
26132 2001-09-08 Miguel de Icaza <miguel@ximian.com>
26134 * assign.cs: Emit stores to static fields differently.
26136 2001-09-08 Ravi Pratap <ravi@ximian.com>
26138 * Merge in changes and adjust code to tackle conflicts. Backed out my
26139 code in Assign::Resolve ;-)
26141 2001-09-08 Ravi Pratap <ravi@ximian.com>
26143 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
26144 instead Report.Error and also pass in the location.
26145 (CSharpParser::Lexer): New readonly property to return the reference
26146 to the Tokenizer object.
26147 (declare_local_variables): Use Report.Error with location instead of plain
26151 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
26152 (Operator.CheckBinaryOperator): Ditto.
26154 * cs-parser.jay (operator_declarator): Update accordingly.
26156 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
26157 (CheckBinaryOperator): Same here.
26159 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
26160 on the name without any prefixes of namespace names etc. This is because we
26161 already might have something already fully qualified like
26162 'System.Console.WriteLine'
26164 * assign.cs (Resolve): Begin implementation. Stuck ;-)
26166 2001-09-07 Ravi Pratap <ravi@ximian.com>
26168 * cs-tokenizer.cs (location): Return a string which also contains
26171 * expression.cs (ElementAccess): New class for expressions of the
26172 type 'element access.'
26173 (BaseAccess): New class for expressions of the type 'base access.'
26174 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
26177 * cs-parser.jay (element_access): Implement action.
26178 (base_access): Implement actions.
26179 (checked_expression, unchecked_expression): Implement.
26181 * cs-parser.jay (local_variable_type): Correct and implement.
26182 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
26184 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
26186 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
26187 name and the specifiers.
26189 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
26191 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
26192 making them all public ;-)
26194 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
26197 2001-09-07 Miguel de Icaza <miguel@ximian.com>
26199 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
26201 (FieldExpr, PropertyExprs): New resolved expressions.
26202 (SimpleName::MemberStaticCheck): Perform static checks for access
26203 to non-static fields on static methods. Maybe this should be
26204 generalized for MemberAccesses.
26205 (SimpleName::ResolveSimpleName): More work on simple name
26208 * cs-parser.jay (primary_expression/qualified_identifier): track
26209 the parameter index.
26211 * codegen.cs (CodeGen::Save): Catch save exception, report error.
26212 (EmitContext::EmitBoolExpression): Chain to expression generation
26213 instead of temporary hack.
26214 (::EmitStatementExpression): Put generic expression code generation.
26216 * assign.cs (Assign::Emit): Implement variable assignments to
26217 local variables, parameters and fields.
26219 2001-09-06 Miguel de Icaza <miguel@ximian.com>
26221 * statement.cs (Block::GetVariableInfo): New method, returns the
26222 VariableInfo for a variable name in a block.
26223 (Block::GetVariableType): Implement in terms of GetVariableInfo
26225 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
26226 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
26228 2001-09-06 Ravi Pratap <ravi@ximian.com>
26230 * cs-parser.jay (operator_declaration): Continue on my quest : update
26231 to take attributes argument.
26232 (event_declaration): Ditto.
26233 (enum_declaration): Ditto.
26234 (indexer_declaration): Ditto.
26236 * class.cs (Operator::Operator): Update constructor accordingly.
26237 (Event::Event): Ditto.
26239 * delegate.cs (Delegate::Delegate): Same here.
26241 * enum.cs (Enum::Enum): Same here.
26243 2001-09-05 Ravi Pratap <ravi@ximian.com>
26245 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
26247 * ../tests/cs0658.cs : New file to demonstrate error 0658.
26249 * attribute.cs (Attributes): New class to encapsulate all attributes which were
26250 being passed around as an arraylist.
26251 (Attributes::AddAttribute): Method to add attribute sections.
26253 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
26254 (struct_declaration): Update accordingly.
26255 (constant_declaration): Update.
26256 (field_declaration): Update.
26257 (method_header): Update.
26258 (fixed_parameter): Update.
26259 (parameter_array): Ditto.
26260 (property_declaration): Ditto.
26261 (destructor_declaration): Ditto.
26263 * class.cs (Struct::Struct): Update constructors accordingly.
26264 (Class::Class): Ditto.
26265 (Field::Field): Ditto.
26266 (Method::Method): Ditto.
26267 (Property::Property): Ditto.
26268 (TypeContainer::OptAttribute): update property's return type.
26270 * interface.cs (Interface.opt_attributes): New member.
26271 (Interface::Interface): Update to take the extra Attributes argument.
26273 * parameter.cs (Parameter::Parameter): Ditto.
26275 * constant.cs (Constant::Constant): Ditto.
26277 * interface.cs (InterfaceMemberBase): New OptAttributes field.
26278 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
26279 the attributes as a parameter.
26280 (InterfaceProperty): Update constructor call.
26281 (InterfaceEvent): Ditto.
26282 (InterfaceMethod): Ditto.
26283 (InterfaceIndexer): Ditto.
26285 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
26286 pass the attributes too.
26287 (interface_event_declaration): Ditto.
26288 (interface_property_declaration): Ditto.
26289 (interface_method_declaration): Ditto.
26290 (interface_declaration): Ditto.
26292 2001-09-05 Miguel de Icaza <miguel@ximian.com>
26294 * class.cs (Method::Define): Track the "static Main" definition to
26295 create an entry point.
26297 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
26298 EntryPoint if we find it.
26300 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
26301 (EmitContext::ig): Make this variable public.
26303 * driver.cs: Make the default output file be the first file name
26304 with the .exe extension.
26306 Detect empty compilations
26308 Handle various kinds of output targets. Handle --target and
26309 rename -t to --dumper.
26311 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
26312 methods inherited from Expression return now an Expression. This
26313 will is used during the tree rewriting as we resolve them during
26316 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
26317 the spec. Missing entirely is the information about
26318 accessability of elements of it.
26320 (Expression::ExprClassFromMemberInfo): New constructor for
26321 Expressions that creates a fully initialized Expression based on
26322 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
26325 (Invocation::Resolve): Begin implementing resolution of invocations.
26327 * literal.cs (StringLiteral): Implement Emit.
26329 2001-09-05 Ravi Pratap <ravi@ximian.com>
26331 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
26334 2001-09-04 Ravi Pratap <ravi@ximian.com>
26336 * cs-parser.jay (attribute_arguments): Implement actions.
26337 (attribute): Fix bug in production. Implement action.
26338 (attribute_list): Implement.
26339 (attribute_target): Implement.
26340 (attribute_target_specifier, opt_target_specifier): Implement
26341 (CheckAttributeTarget): New method to check if the attribute target
26343 (attribute_section): Implement.
26344 (opt_attributes): Implement.
26346 * attribute.cs : New file to handle attributes.
26347 (Attribute): Class to hold attribute info.
26349 * cs-parser.jay (opt_attribute_target_specifier): Remove production
26350 (attribute_section): Modify production to use 2 different rules to
26351 achieve the same thing. 1 s/r conflict down !
26352 Clean out commented, useless, non-reducing dimension_separator rules.
26354 * class.cs (TypeContainer.attributes): New member to hold list
26355 of attributes for a type.
26356 (Struct::Struct): Modify to take one more argument, the attribute list.
26357 (Class::Class): Ditto.
26358 (Field::Field): Ditto.
26359 (Method::Method): Ditto.
26360 (Property::Property): Ditto.
26362 * cs-parser.jay (struct_declaration): Update constructor call to
26363 pass in the attributes too.
26364 (class_declaration): Ditto.
26365 (constant_declaration): Ditto.
26366 (field_declaration): Ditto.
26367 (method_header): Ditto.
26368 (fixed_parameter): Ditto.
26369 (parameter_array): Ditto.
26370 (property_declaration): Ditto.
26372 * constant.cs (Constant::Constant): Update constructor similarly.
26373 Use System.Collections.
26375 * parameter.cs (Parameter::Parameter): Update as above.
26377 2001-09-02 Ravi Pratap <ravi@ximian.com>
26379 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
26380 (TypeContainer.delegates): New member to hold list of delegates.
26382 * cs-parser.jay (delegate_declaration): Implement the action correctly
26383 this time as I seem to be on crack ;-)
26385 2001-09-02 Miguel de Icaza <miguel@ximian.com>
26387 * rootcontext.cs (RootContext::IsNamespace): new function, used to
26388 tell whether an identifier represents a namespace.
26390 * expression.cs (NamespaceExpr): A namespace expression, used only
26391 temporarly during expression resolution.
26392 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
26393 utility functions to resolve names on expressions.
26395 2001-09-01 Miguel de Icaza <miguel@ximian.com>
26397 * codegen.cs: Add hook for StatementExpressions.
26399 * class.cs: Fix inverted test for static flag in methods.
26401 2001-09-02 Ravi Pratap <ravi@ximian.com>
26403 * class.cs (Operator::CheckUnaryOperator): Correct error number used
26404 to make it coincide with MS' number.
26405 (Operator::CheckBinaryOperator): Ditto.
26407 * ../errors/errors.txt : Remove error numbers added earlier.
26409 * ../errors/cs1019.cs : Test case for error # 1019
26411 * ../errros/cs1020.cs : Test case for error # 1020
26413 * cs-parser.jay : Clean out commented cruft.
26414 (dimension_separators, dimension_separator): Comment out. Ostensibly not
26415 used anywhere - non-reducing rule.
26416 (namespace_declarations): Non-reducing rule - comment out.
26418 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
26419 with TypeContainer::AddEnum.
26421 * delegate.cs : New file for delegate handling classes.
26422 (Delegate): Class for declaring delegates.
26424 * makefile : Update.
26426 * cs-parser.jay (delegate_declaration): Implement.
26428 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
26430 * class.cs (Event::Define): Implement.
26431 (Event.EventBuilder): New member.
26433 * class.cs (TypeContainer::Populate): Update to define all enums and events
26435 (Events): New property for the events arraylist we hold. Shouldn't we move to using
26436 readonly fields for all these cases ?
26438 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
26440 * class.cs (Property): Revamp to use the convention of making fields readonly.
26441 Accordingly modify code elsewhere.
26443 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
26444 the Define method of the Property class.
26446 * class.cs : Clean up applied patch and update references to variables etc. Fix
26448 (TypeContainer::Populate): Update to define all the properties we have. Also
26449 define all enumerations.
26451 * enum.cs (Define): Implement.
26453 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
26455 * cs-parser.jay (overloadable_operator): The semantic value is an
26456 enum of the Operator class.
26457 (operator_declarator): Implement actions.
26458 (operator_declaration): Implement.
26460 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
26461 validity of definitions.
26462 (Operator::CheckBinaryOperator): Static method to check for binary operators
26463 (TypeContainer::AddOperator): New method to add an operator to a type.
26465 * cs-parser.jay (indexer_declaration): Added line to actually call the
26466 AddIndexer method so it gets added ;-)
26468 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
26469 already taken care of by the MS compiler ?
26471 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
26473 * class.cs (Operator): New class for operator declarations.
26474 (Operator::OpType): Enum for the various operators.
26476 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
26478 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
26479 ostensibly handle this in semantic analysis.
26481 * cs-parser.jay (general_catch_clause): Comment out
26482 (specific_catch_clauses, specific_catch_clause): Ditto.
26483 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
26484 (catch_args, opt_catch_args): New productions.
26485 (catch_clause): Rewrite to use the new productions above
26486 (catch_clauses): Modify accordingly.
26487 (opt_catch_clauses): New production to use in try_statement
26488 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
26489 and re-write the code in the actions to extract the specific and
26490 general catch clauses by being a little smart ;-)
26492 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
26493 Hooray, try and catch statements parse fine !
26495 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
26497 * statement.cs (Block::GetVariableType): Fix logic to extract the type
26498 string from the hashtable of variables.
26500 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
26501 I end up making that mistake ;-)
26502 (catch_clauses): Fixed gross error which made Key and Value of the
26503 DictionaryEntry the same : $1 !!
26505 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
26507 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
26509 * cs-parser.jay (event_declaration): Correct to remove the semicolon
26510 when the add and remove accessors are specified.
26512 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
26514 * cs-parser.jay (IndexerDeclaration): New helper class to hold
26515 information about indexer_declarator.
26516 (indexer_declarator): Implement actions.
26517 (parsing_indexer): New local boolean used to keep track of whether
26518 we are parsing indexers or properties. This is necessary because
26519 implicit_parameters come into picture even for the get accessor in the
26520 case of an indexer.
26521 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
26523 * class.cs (Indexer): New class for indexer declarations.
26524 (TypeContainer::AddIndexer): New method to add an indexer to a type.
26525 (TypeContainer::indexers): New member to hold list of indexers for the
26528 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
26530 * cs-parser.jay (add_accessor_declaration): Implement action.
26531 (remove_accessor_declaration): Implement action.
26532 (event_accessors_declaration): Implement
26533 (variable_declarators): swap statements for first rule - trivial.
26535 * class.cs (Event): New class to hold information about event
26537 (TypeContainer::AddEvent): New method to add an event to a type
26538 (TypeContainer::events): New member to hold list of events.
26540 * cs-parser.jay (event_declaration): Implement actions.
26542 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
26544 * cs-parser.jay (dim_separators): Implement. Make it a string
26545 concatenating all the commas together, just as they appear.
26546 (opt_dim_separators): Modify accordingly
26547 (rank_specifiers): Update accordingly. Basically do the same
26548 thing - instead, collect the brackets here.
26549 (opt_rank_sepcifiers): Modify accordingly.
26550 (array_type): Modify to actually return the complete type string
26551 instead of ignoring the rank_specifiers.
26552 (expression_list): Implement to collect the expressions
26553 (variable_initializer): Implement. We make it a list of expressions
26554 essentially so that we can handle the array_initializer case neatly too.
26555 (variable_initializer_list): Implement.
26556 (array_initializer): Make it a list of variable_initializers
26557 (opt_array_initializer): Modify accordingly.
26559 * expression.cs (New::NType): Add enumeration to help us
26560 keep track of whether we have an object/delegate creation
26561 or an array creation.
26562 (New:NewType, New::Rank, New::Indices, New::Initializers): New
26563 members to hold data about array creation.
26564 (New:New): Modify to update NewType
26565 (New:New): New Overloaded contructor for the array creation
26568 * cs-parser.jay (array_creation_expression): Implement to call
26569 the overloaded New constructor.
26571 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
26573 * class.cs (TypeContainer::Constructors): Return member
26574 constructors instead of returning null.
26576 2001-08-26 Miguel de Icaza <miguel@ximian.com>
26578 * typemanager.cs (InitCoreTypes): Initialize the various core
26579 types after we have populated the type manager with the user
26580 defined types (this distinction will be important later while
26581 compiling corlib.dll)
26583 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
26584 on Expression Classification. Now all expressions have a method
26585 `Resolve' and a method `Emit'.
26587 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
26588 generation from working. Also add some temporary debugging
26591 2001-08-24 Miguel de Icaza <miguel@ximian.com>
26593 * codegen.cs: Lots of code generation pieces. This is only the
26594 beginning, will continue tomorrow with more touches of polish. We
26595 handle the fundamentals of if, while, do, for, return. Others are
26596 trickier and I need to start working on invocations soon.
26598 * gen-treedump.cs: Bug fix, use s.Increment here instead of
26601 * codegen.cs (EmitContext): New struct, used during code
26602 emission to keep a context. Most of the code generation will be
26605 * cs-parser.jay: Add embedded blocks to the list of statements of
26606 this block. So code generation proceeds in a top down fashion.
26608 2001-08-23 Miguel de Icaza <miguel@ximian.com>
26610 * statement.cs: Add support for multiple child blocks.
26612 2001-08-22 Miguel de Icaza <miguel@ximian.com>
26614 * codegen.cs (EmitCode): New function, will emit the code for a
26615 Block of code given a TypeContainer and its ILGenerator.
26617 * statement.cs (Block): Standard public readonly optimization.
26618 (Block::Block constructors): Link children.
26619 (Block::Child): Child Linker.
26620 (Block::EmitVariables): Emits IL variable declarations.
26622 * class.cs: Drop support for MethodGroups here, delay until
26624 (Method::): Applied the same simplification that I did before, and
26625 move from Properties to public readonly fields.
26626 (Method::ParameterTypes): Returns the parameter types for the
26627 function, and implements a cache that will be useful later when I
26628 do error checking and the semantic analysis on the methods is
26630 (Constructor::GetCallingConvention): Renamed from CallingConvetion
26631 and made a method, optional argument tells whether this is a class
26632 or a structure to apply the `has-this' bit.
26633 (Method::GetCallingConvention): Implement, returns the calling
26635 (Method::Define): Defines the type, a second pass is performed
26636 later to populate the methods.
26638 (Constructor::ParameterTypes): implement a cache similar to the
26639 one on Method::ParameterTypes, useful later when we do semantic
26642 (TypeContainer::EmitMethod): New method. Emits methods.
26644 * expression.cs: Removed MethodGroup class from here.
26646 * parameter.cs (Parameters::GetCallingConvention): new method.
26648 2001-08-21 Miguel de Icaza <miguel@ximian.com>
26650 * class.cs (TypeContainer::Populate): Drop RootContext from the
26653 (Constructor::CallingConvention): Returns the calling convention.
26654 (Constructor::ParameterTypes): Returns the constructor parameter
26657 (TypeContainer::AddConstructor): Keep track of default constructor
26658 and the default static constructor.
26660 (Constructor::) Another class that starts using `public readonly'
26661 instead of properties.
26663 (Constructor::IsDefault): Whether this is a default constructor.
26665 (Field::) use readonly public fields instead of properties also.
26667 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
26668 track of static constructors; If none is used, turn on
26669 BeforeFieldInit in the TypeAttributes.
26671 * cs-parser.jay (opt_argument_list): now the return can be null
26672 for the cases where there are no arguments.
26674 (constructor_declarator): If there is no implicit `base' or
26675 `this', then invoke the default parent constructor.
26677 * modifiers.cs (MethodAttr): New static function maps a set of
26678 modifiers flags into a MethodAttributes enum
26679 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
26680 MethodAttr, TypeAttr to represent the various mappings where the
26681 modifiers are used.
26682 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
26684 2001-08-19 Miguel de Icaza <miguel@ximian.com>
26686 * parameter.cs (GetParameterInfo): Fix bug where there would be no
26689 * interface.cs (PopulateIndexer): Implemented the code generator
26690 for interface indexers.
26692 2001-08-17 Miguel de Icaza <miguel@ximian.com>
26694 * interface.cs (InterfaceMemberBase): Now we track the new status
26697 (PopulateProperty): Implement property population. Woohoo! Got
26698 Methods and Properties going today.
26700 Removed all the properties for interfaces, and replaced them with
26701 `public readonly' fields.
26703 2001-08-16 Miguel de Icaza <miguel@ximian.com>
26705 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
26706 initialize their hashtables/arraylists only when they are needed
26707 instead of doing this always.
26709 * parameter.cs: Handle refs and out parameters.
26711 * cs-parser.jay: Use an ArrayList to construct the arguments
26712 instead of the ParameterCollection, and then cast that to a
26715 * parameter.cs: Drop the use of ParameterCollection and use
26716 instead arrays of Parameters.
26718 (GetParameterInfo): Use the Type, not the Name when resolving
26721 2001-08-13 Miguel de Icaza <miguel@ximian.com>
26723 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
26724 and instead use public readonly fields.
26726 * class.cs: Put back walking code for type containers.
26728 2001-08-11 Miguel de Icaza <miguel@ximian.com>
26730 * class.cs (MakeConstant): Code to define constants.
26732 * rootcontext.cs (LookupType): New function. Used to locate types
26735 2001-08-08 Miguel de Icaza <miguel@ximian.com>
26737 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
26738 this System.Reflection code is. Kudos to Microsoft
26740 * typemanager.cs: Implement a type cache and avoid loading all
26741 types at boot time. Wrap in LookupType the internals. This made
26742 the compiler so much faster. Wow. I rule!
26744 * driver.cs: Make sure we always load mscorlib first (for
26745 debugging purposes, nothing really important).
26747 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
26748 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
26750 * rootcontext.cs: Lookup types on their namespace; Lookup types
26751 on namespaces that have been imported using the `using' keyword.
26753 * class.cs (TypeContainer::TypeAttr): Virtualize.
26754 (Class::TypeAttr): Return attributes suitable for this bad boy.
26755 (Struct::TypeAttr): ditto.
26756 Handle nested classes.
26757 (TypeContainer::) Remove all the type visiting code, it is now
26758 replaced with the rootcontext.cs code
26760 * rootcontext.cs (GetClassBases): Added support for structs.
26762 2001-08-06 Miguel de Icaza <miguel@ximian.com>
26764 * interface.cs, statement.cs, class.cs, parameter.cs,
26765 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
26766 Drop use of TypeRefs, and use strings instead.
26768 2001-08-04 Miguel de Icaza <miguel@ximian.com>
26772 * class.cs (Struct::Struct): set the SEALED flags after
26773 checking the modifiers.
26774 (TypeContainer::TypeAttr): new property, returns the
26775 TypeAttributes for a class.
26777 * cs-parser.jay (type_list): Oops, list production was creating a
26778 new list of base types.
26780 * rootcontext.cs (StdLib): New property.
26781 (GetInterfaceTypeByName): returns an interface by type name, and
26782 encapsulates error handling here.
26783 (GetInterfaces): simplified.
26784 (ResolveTree): Encapsulated all the tree resolution here.
26785 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
26788 * driver.cs: Add support for --nostdlib, to avoid loading the
26789 default assemblies.
26790 (Main): Do not put tree resolution here.
26792 * rootcontext.cs: Beginning of the class resolution.
26794 2001-08-03 Miguel de Icaza <miguel@ximian.com>
26796 * rootcontext.cs: Provide better error reporting.
26798 * cs-parser.jay (interface_base): set our $$ to be interfaces.
26800 * rootcontext.cs (CreateInterface): Handle the case where there
26801 are no parent interfaces.
26803 (CloseTypes): Routine to flush types at the end.
26804 (CreateInterface): Track types.
26805 (GetInterfaces): Returns an array of Types from the list of
26806 defined interfaces.
26808 * typemanager.c (AddUserType): Mechanism to track user types (puts
26809 the type on the global type hash, and allows us to close it at the
26812 2001-08-02 Miguel de Icaza <miguel@ximian.com>
26814 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
26815 RecordInterface instead.
26817 * cs-parser.jay: Updated to reflect changes above.
26819 * decl.cs (Definition): Keep track of the TypeBuilder type that
26820 represents this type here. Not sure we will use it in the long
26821 run, but wont hurt for now.
26823 * driver.cs: Smaller changes to accomodate the new code.
26825 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
26828 * rootcontext.cs (CreateInterface): New method, used to create
26829 the System.TypeBuilder type for interfaces.
26830 (ResolveInterfaces): new entry point to resolve the interface
26832 (CodeGen): Property, used to keep track of the code generator.
26834 2001-07-26 Miguel de Icaza <miguel@ximian.com>
26836 * cs-parser.jay: Add a second production for delegate_declaration
26839 (enum_body): Put an opt_comma here instead of putting it on
26840 enum_body or enum_member_declarations so we can handle trailing
26841 commas on enumeration members. Gets rid of a shift/reduce.
26843 (type_list): Need a COMMA in the middle.
26845 (indexer_declaration): Tell tokenizer to recognize get/set
26847 * Remove old targets.
26849 * Re-add the parser target.
26851 2001-07-13 Simon Cozens <simon@simon-cozens.org>
26853 * cs-parser.jay: Add precendence rules for a number of operators
26854 ot reduce the number of shift/reduce conflicts in the grammar.
26856 2001-07-17 Miguel de Icaza <miguel@ximian.com>
26858 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
26861 Get rid of old crufty code.
26863 * rootcontext.cs: Use this to keep track of the parsed
26864 representation and the defined types available to the program.
26866 * gen-treedump.cs: adjust for new convention.
26868 * type.cs: Split out the type manager, and the assembly builder
26871 * typemanager.cs: the type manager will live here now.
26873 * cil-codegen.cs: And the code generator here.
26875 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
26877 * makefile: Fixed up for easy making.
26879 2001-07-13 Simon Cozens <simon@simon-cozens.org>
26881 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
26884 (unary_expression): Expand pre_increment_expression and
26885 post_decrement_expression to reduce a shift/reduce.
26887 2001-07-11 Simon Cozens
26889 * cs-tokenizer.cs: Hex numbers should begin with a 0.
26891 Improve allow_keyword_as_indent name.
26893 2001-06-19 Miguel de Icaza <miguel@ximian.com>
26895 * Adjustments for Beta2.
26897 2001-06-13 Miguel de Icaza <miguel@ximian.com>
26899 * decl.cs: Added `Define' abstract method.
26900 (InTransit): new property, used to catch recursive definitions.
26902 * interface.cs: Implement `Define'.
26904 * modifiers.cs: Map Modifiers.constants to
26905 System.Reflection.TypeAttribute flags.
26907 * class.cs: Keep track of types and user-defined types.
26908 (BuilderInit): New method for creating an assembly
26909 (ResolveType): New function to launch the resolution process, only
26910 used by interfaces for now.
26912 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
26913 that are inserted into the name space.
26915 2001-06-08 Miguel de Icaza <miguel@ximian.com>
26917 * ARGH. I have screwed up my tree so many times due to the use of
26918 rsync rather than using CVS. Going to fix this at once.
26920 * driver.cs: Objetify driver. Load assemblies, use assemblies to
26923 2001-06-07 Miguel de Icaza <miguel@ximian.com>
26925 * Experiment successful: Use System.Type rather that our own
26928 2001-05-25 Miguel de Icaza <miguel@ximian.com>
26930 * cs-parser.jay: Removed nsAliases from here.
26932 Use new namespaces, handle `using XXX;'
26934 * namespace.cs: Reimplemented namespace handling, use a recursive
26935 definition of the class. Now we can keep track of using clauses
26936 and catch invalid using clauses.
26938 2001-05-24 Miguel de Icaza <miguel@ximian.com>
26940 * gen-treedump.cs: Adapted for all the renaming.
26942 * expression.cs (Expression): this class now has a Type property
26943 which returns an expression Type.
26945 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
26946 `Type', as this has a different meaning now in the base
26948 2001-05-22 Miguel de Icaza <miguel@ximian.com>
26950 * interface.cs, class.cs: Removed from all the sources the
26951 references to signature computation, as we can not do method
26952 signature computation during the parsing time, as we are not
26953 trying to solve at that point distinguishing:
26957 void a (NS.Blah x) {}
26960 Which depending on the context might be valid or not, as we do not
26961 know if Blah is the same thing as NS.Blah at that point.
26963 * Redid everything so the code uses TypeRefs now instead of
26964 Types. TypeRefs are just temporary type placeholders, that need
26965 to be resolved. They initially have a pointer to a string and the
26966 current scope in which they are used. This is used later by the
26967 compiler to resolve the reference to an actual Type.
26969 * DeclSpace is no longer a CIR.Type, and neither are
26970 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
26971 are all DeclSpaces, but no Types.
26973 * type.cs (TypeRefManager): This implements the TypeRef manager,
26974 which keeps track of all the types that need to be resolved after
26975 the parsing has finished.
26977 2001-05-13 Miguel de Icaza <miguel@ximian.com>
26979 * ARGH. We are going to have to store `foreach' as a class rather
26980 than resolving it, as we need to verify error 1579 after name
26981 resolution. *OR* we could keep a flag that says `This request to
26982 IEnumerator comes from a foreach statement' which we can then use
26983 to generate the error.
26985 2001-05-10 Miguel de Icaza <miguel@ximian.com>
26987 * class.cs (TypeContainer.AddMethod): we now add methods to the
26988 MethodGroup instead of the method hashtable.
26990 * expression.cs: Add MethodGroup abstraction, which gets us one
26991 step closer to the specification in the way we handle method
26994 * cs-parser.jay (primary_expression): qualified_identifier now
26995 tried to match up an identifier to a local variable reference or
26996 to a parameter reference.
26998 current_local_parameters is now a parser global variable that
26999 points to the current parameters for the block, used during name
27002 (property_declaration): Now creates an implicit `value' argument to
27005 2001-05-09 Miguel de Icaza <miguel@ximian.com>
27007 * parameter.cs: Do not use `param' arguments as part of the
27008 signature, per the spec.
27010 2001-05-08 Miguel de Icaza <miguel@ximian.com>
27012 * decl.cs: Base class for classes, structs and interfaces. This
27013 is the "Declaration Space"
27015 * cs-parser.jay: Use CheckDef for checking declaration errors
27016 instead of having one on each function.
27018 * class.cs: Factor out some code for handling error handling in
27019 accordance to the "Declarations" section in the "Basic Concepts"
27020 chapter in the ECMA C# spec.
27022 * interface.cs: Make all interface member classes derive from
27023 InterfaceMemberBase.
27025 2001-05-07 Miguel de Icaza <miguel@ximian.com>
27027 * Many things: all interfaces are parsed and generated in
27028 gen-treedump. Support for member variables, constructors,
27029 destructors, properties, constants is there.
27031 Beginning of the IL backend, but very little done, just there for
27034 2001-04-29 Miguel de Icaza <miguel@ximian.com>
27036 * cs-parser.jay: Fix labeled statement.
27038 * cs-tokenizer.cs (escape): Escape " and ' always.
27039 ref_line, ref_name: keep track of the line/filename as instructed
27040 by #line by the compiler.
27043 2001-04-27 Miguel de Icaza <miguel@ximian.com>
27045 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
27046 to match the values in System.CodeDOM.
27048 Divid renamed to Divide.
27050 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
27052 (Statements.set): remove.
27054 * System.CodeDOM/CodeCatchClause.cs: always have a valid
27057 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
27058 falseStatements always have valid values.
27060 * cs-parser.jay: Use System.CodeDOM now.