1 2006-05-16 Raja R Harinath <rharinath@novell.com>
3 * statement.cs (Goto.Resolve): Merge jump origins here ...
4 * flowanalysis.cs (FlowBranching.Label): ... rather than here.
6 * flowanalysis.cs (FlowBranching.LookupLabel): Move CS0159 check ...
7 (FlowBranchingToplevel.LookupLabel): ... here. Add CS1632 check.
8 (FlowBranchingGoto.LookupLabel): New. Handle back jumps.
9 (FlowBranchingBlock.LookupLabel): Call LabeledStatement.AddReference
11 * statement.cs (Goto.Resolve): ... not here.
12 (Goto.Emit): Remove CS1632 check.
14 2006-05-14 Marek Safar <marek.safar@seznam.cz>
16 * ecore.cs (Expression.ResolveAsTypeTerminal): Fixed type in the obsolete
19 2006-05-11 Raja R Harinath <rharinath@novell.com>
21 * flowanalysis.cs (UsageVector.MergeJumpOrigins): Kill.
22 (FlowBranchingBlock.Label): Use UsageVector.MergeOrigins.
23 (FlowBranchingException.Label): Likewise.
25 * flowanalysis.cs (MyBitVector.SetAll): New. Sets all bits to the
27 (MyBitVector.Or): Use it to avoid losing information (Count).
28 (FlowBranching.MergeOrigins): Likewise.
30 * flowanalysis.cs (UsageVector.IsDirty): Remove.
31 (UsageVector.Parameters, UsageVector.ParameterVector): Likewise.
32 (UsageVector.Locals, UsageVector.LocalVector): Likewise.
33 (UsageVector.ToString): Simplify.
34 (UsageVector.MergeSiblings): Move here from ...
35 (FlowBranching.Merge): ... here.
36 (FlowBranchingToplevel.CheckOutParameters): Take an UsageVector,
39 2006-05-10 Raja R Harinath <rharinath@novell.com>
41 * flowanalysis.cs (UsageVector.MergeOrigins): Simplify, now that a
42 null bitvector is treated as all-true.
44 * flowanalysis.cs (MyBitVector.And, MyBitVector.Or): Make lazier.
45 (MyBitVector): Rationalize invariants. 'vector != null' implies
46 that we have our own copy of the bitvector. Otherwise,
47 'InheritsFrom == null' implies all inherited bits are true.
49 2006-05-09 Marek Safar <marek.safar@seznam.cz>
51 * statement.cs (LocalInfo): Add IsConstant.
52 (LocalInfo.DeclareLocal): Moved from EmitMeta and changed to don't emit
53 local variable for constants.
55 2006-05-09 Raja R Harinath <rharinath@novell.com>
57 * flowanalysis.cs (MyBitVector.Empty): New.
58 (MyBitVector): Don't allow InheritedFrom to be null.
59 (MyBitVector.And, MyBitVector.Or): Treat 'null' as all-ones.
60 (UsageVector, FlowBranching): Update to changes.
62 * flowanalysis.cs (FlowBranching.InTryWithCatch): Don't terminate
63 recursion. The 'Parent == null' condition isn't sufficient for
65 (FlowBranching.AddBreakOrigin): Likewise.
66 (FlowBranching.AddContinueOrigin): Likewise.
67 (FlowBranching.AddReturnOrigin): Likewise.
68 (FlowBranching.StealFinallyClauses): Likewise.
69 (FlowBranching.MergeTopBlock): Move to FlowBranchingToplevel.
70 (FlowBranching.CheckOutParameters): Likewise.
71 (FlowBranchingToplevel): Terminate all the above recursions here.
72 (FlowBranchingToplevel.End): Rename from MergeTopBlock.
73 * codegen.cs (EmitContext.ResolveTopBlock): Update to changes.
75 * flowanalysis.cs (BranchingType.Toplevel): New. Represents a
77 (FlowBranchingToplevel): New. Empty for now.
78 (FlowBranching.MergeTopBlock): Update.
79 * codegen.cs (EmitContext.ResolveTopBlock): Create a Toplevel
80 branching for the anonymous delegate.
81 (EmitContext.StartFlowBranching): Add ToplevelBlock variant.
83 * flowanalysis.cs (UsageVector.MergeOrigins): Reorganize.
84 (UsageVector.MergeJumpOrigins): Don't ignore current reachability
85 information at the start of the merge. Reorganize.
87 2006-05-07 Marek Safar <marek.safar@seznam.cz>
89 * class.cs (MethodData.Define): Method cannot implement interface accessor.
91 2006-05-07 Marek Safar <marek.safar@seznam.cz>
93 * expression.cs (QualifiedAliasMember.ResolveAsTypeStep): Pass location
94 to newly introduced ctor.
96 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Moved an error
98 (GlobalRootNamespace.Error_NamespaceDoesNotExist): Custom message for
101 2006-05-07 Marek Safar <marek.safar@seznam.cz>
103 * const.cs (Const.Error_ExpressionMustBeConstant): Better error message.
105 * ecore.cs (Expression.ResolveAsConstant): Updated.
107 * statement.cs (ResolveMeta): Updated.
109 2006-05-06 Marek Safar <marek.safar@seznam.cz>
111 * cs-parser.jay: __arglist cannot be used in initializer.
113 2006-05-06 Marek Safar <marek.safar@seznam.cz>
116 * namespace.cs (LocalAliasEntry.DoResolve): Don't allow to access nested
119 2006-05-05 Raja R Harinath <rharinath@novell.com>
121 * statement.cs (EmptyStatement.ResolveUnreachable): Override.
122 (LabeledStatement): Add 'name' parameter.
123 (LabeledStatement.Name, LabeledStatement.JumpOrigins): New.
124 (Block.AddLabel): Update to changes.
125 * cs-parser.jay (labeled_statement): Likewise.
127 * flowanalysis.cs (BranchingType.Labeled): New.
128 (UsageVector.MergeOrigins): Remove unused 'branching' argument.
129 (FlowBranchingLabeled): New. Does nothing for now, but will
130 eventually handle 'goto' flows.
131 * codegen.cs (StartFlowBranching): Add new LabeledStatement variant.
132 * statement.cs (LabeledStatement.Resolve): Create a FlowBranching
133 that's terminated ...
134 (Block.Resolve): ... here.
136 * flowanalysis.cs (UsageVector.MergeFinally): Remove.
137 (UsageVector.MergeFinallyOrigins): Likewise.
138 (FlowBranching.InTryOrCatch): Likewise.
139 (FlowBranching.AddFinallyVector): Likewise.
140 (FlowBranchingException): Update to changes.
143 * statement.cs (Return.Resolve): Move error checking to ...
144 * flowbranching.cs (FlowBranching.AddReturnOrigin): ... this.
145 (FlowBranchingException): Handle return origins like break and
147 (FlowBranching.UsageVector.CheckOutParameters): Remove.
149 2006-05-04 Marek Safar <marek.safar@seznam.cz>
152 * class.cs (TypeContainer.FindMembers): Includes event method in the methods
155 2006-05-04 Marek Safar <marek.safar@seznam.cz>
158 * class.cs (MethodData.Define): Do public accessor check only when method
159 implements an interface.
161 2006-05-04 Raja R Harinath <rharinath@novell.com>
163 Remove special handling of 'break'
164 * flowanalysis.cs (Reachability): Remove all mention of 'breaks'.
165 (Reachability.Meet): Simplify. Remove 'do_breaks' argument.
166 (UsageVector.Break): Remove.
167 (FlowBranching.Merge): Use 'Reachable.IsUnreachable' to determine
169 (FlowBranchingBreakable.Merge): Don't ResetBreaks.
171 * statement.cs (Break.Resolve): Call UsageVector.Goto (), not
172 UsageVector.Breaks (). Don't set NeedsReturnLabel.
174 2006-05-03 Marek Safar <marek.safar@seznam.cz>
177 * pending.cs (PendingImplementation.BaseImplements): A found member cannot
178 be the interface member.
180 2006-05-03 Marek Safar <marek.safar@seznam.cz>
183 * constant.cs (LongConstant.EmitLong): Fixed to catch also negative values
184 for emitting small (int) values.
186 2006-05-03 Raja R Harinath <rharinath@novell.com>
189 * flowanalysis.cs (FlowBranchingException.Merge): Ensure
190 control-flow passes through the 'finally' after merging-in all the
191 control-flows from 'try' and the 'catch' clauses.
193 * flowanalysis.cs (FlowBranching.IsLoop): Remove.
194 (FlowBranching.IsTryOrCatch): Remove 'is_return' parameter. It's
195 always true at the only non-recursive entry point.
196 (FlowBranching.CreateBranching) [BranchingType.Loop]: Return a
197 FlowBranchingBreakable.
198 (FlowBranchingLoop): Remove.
199 * statement.cs (Return.DoResolve): Update to changes.
202 * flowanalysis.cs (FlowBranching.BranchingType.Embedded): New.
203 (FlowBranching.CreateBranching): Handle it: create a
204 FlowBranchingContinuable.
205 (FlowBranching.BreakCrossesExceptionBoundary): Remove.
206 (FlowBranching.AddContinueOrigin): Similar to AddBreakOrigin,
207 except that it handles the 'continue' command.
208 (FlowBranching.UsageVector.MergeOrigins): Rename from
210 (FlowBranchingContinuable): Similar to FlowBranchingBreakable,
211 except that it overrides AddContinueOrigin.
212 (FlowBranchingException): Override AddContinueOrigin, similar to
214 * statement.cs (While.Resolve, Foreach.ArrayForeach.Resolve):
215 Create a new branching around the embedded statement.
216 (Do.Resolve, For.Resolve): Likewise. Do reachability analysis for
217 control flow after the embedded statement.
218 (Continue.Resolve): Move all error checking to AddContinueOrigin.
220 * flowanalysis.cs (FlowBranching.IsSwitch): Remove.
221 (FlowBranching.CreateBranching) [BranchingType.Switch]: Create a
222 FlowBranchingBreakable.
223 (FlowBranchingSwitch): Remove.
226 * statement.cs (Break.Resolve): Simplify. Move responsibility for
227 error reporting to ...
228 * flowanalysis.cs (FlowBranching.AddBreakOrigin) ... this.
229 Rename from 'AddBreakVector'. Add new location argument. Return
230 a bool indicating whether the 'break' crosses an unwind-protect.
231 (FlowBranchingException.AddBreakOrigin): Add.
232 (FlowBranchingException.Merge): Propagate 'break's to surrounding
233 flowbranching after updating with the effects of the 'finally'
235 (FlowBranchingBreakable): New common base class for
236 FlowBranchingLoop and FlowBranchingSwitch.
238 * statement.cs (Foreach.ArrayForeach.Resolve): Set barrier after
240 (Foreach.CollectionForeach.Resolve): Remove extraneous flowbranching.
242 2006-05-02 Raja R Harinath <rharinath@novell.com>
244 * statement.cs (Do.Resolve): If the loop is infinite, set the
246 (While.Resolve, For.Resolve): Set a barrier after the embedded
247 statement. There's no direct control flow that goes from the end
248 of the embedded statement to the end of the loop.
249 * flowanalysis.cs (FlowBranching.Infinite): Remove.
250 (FlowBranchingLoop.Merge): Don't look at 'Infinite'. The changes
251 above ensure that the reachability is correctly computed.
253 * flowanalysis.cs (Reachability.ResetBarrier): Remove.
254 (UsageVector.MergeBreakOrigins): If the current path is
255 unreachable, treat it as if all parameters/locals are initialized.
256 (FlowBranchingLoop.Merge): Don't clear any barriers. Handle
257 infinite loops before merging-in break origins.
259 * flowanalysis.cs (Reachability.Meet): Simplify code handling 'returns'.
260 (Reachability.Reachable): Split part into ...
261 (Reachability.Unreachable): ... this. Simplify.
262 (Reachability.IsUnreachable): Use 'Unreachable' instead.
264 * flowanalysis.cs (Reachability.SetReturnsSometimes): Remove.
265 (Reachability.SetThrowsSometimes): Likewise.
266 (FlowBranchingBlock.MergeTopBlock): Don't compare against
267 TriState.Always, use corresponding property.
268 * statement.cs (Lock.Resolve, Try.Resolve, Using.Resolve): Likewise.
269 (Block.Resolve): Likewise. Remove some redundant checks.
271 2006-05-02 Raja R Harinath <harinath@gmail.com>
273 * flowanalysis.cs (UsageVector.Throw): Set barrier too.
274 (Reachability.Meet): Don't bother checking AlwaysThrows --
275 barrier is always set.
276 (FlowBranchingBlock.Merge): Likewise.
278 2006-05-01 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
280 * attribute.cs: fixed_buffer_cache is declared only if NET_2_0 is
281 defined, so it's references should also compile only for NET_2_0
282 (as occurs in mcs version)
284 2006-05-01 Raja R Harinath <harinath@gmail.com>
286 * codegen.cs (EmitContext.ResolveTopBlock): Remove redundant
287 checks for unreachable.
289 2006-05-01 Marek Safar <marek.safar@seznam.cz>
292 * flowanalysis.cs (UsageVector.IsAssigned): Add flag to ignore short path.
294 * statement.cs (Block.UsageWarning): Uses newly introduced flag to detect
295 whether field is really assigned.
297 2006-04-30 Raja R Harinath <harinath@gmail.com>
299 * flowanalysis.cs (Reachability): Make 4-argument constructor
301 (Reachability.Meet): Rename from 'And'. Remove static variant.
302 (Reachability.Always): Rename from the highly misleading
303 'Reachability.Never'.
304 (FlowBranching.Merge): Update to changes. Mark an impossible
305 situation with a 'throw'.
306 (*): Update to changes.
308 2006-04-29 Raja R Harinath <harinath@gmail.com>
310 * flowanalysis.cs (TriState): Rename from FlowBranching.FlowReturns.
312 (FlowBranching.TriState_Meet): Rename from AndFlowReturns. Simplify.
313 (FlowBranching.TriState_Max): Rename from OrFlowReturns. Simplify.
314 (*): Update to changes.
315 * statement.cs: Update to changes.
317 2006-04-28 Marek Safar <marek.safar@seznam.cz>
320 *class.cs (Method.FindOutBaseMethod): Base method cannot be property method.
322 2006-04-28 Raja R Harinath <harinath@gmail.com>
324 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't create a
327 * flowanalysis.cs (UsageVector.MergeChild): Change FlowBranching
328 argument to two arguments: an usage-vector and a bool. Move call
329 to FlowBranching.Merge () ...
330 (FlowBranching.MergeChild, FlowBranching.MergeTopBlock): ... here.
332 * flowanalysis.cs (UsageVector.MergeChild): Move special-case
333 handling of loop and switch reachability to ...
334 (FlowBranchingLoop.Merge, FlowBranchingSwitch.Merge): ... these.
336 2006-04-27 Raja R Harinath <harinath@gmail.com>
338 * flowanalysis.cs (FlowBranching.InLoop): Move special-case
339 handling to FlowBranchingLoop.InLoop.
340 (FlowBranching.InSwitch): Likewise, to FlowBranchingSwitch.
342 2006-04-26 Marek Safar <marek.safar@seznam.cz>
345 * anonymous.cs (AnonymousMethod.DoResolve): Moved the check whether
346 anonymous method is allowed from AnonymousContainer here.
348 * attribute.cs, codegen.cs (EmitContext): Add IsAnonymousMethodAllowed.
350 2006-04-24 Raja R Harinath <rharinath@novell.com>
353 * flowanalysis.cs (MyBitVector.Or): Add null check on argument.
355 2006-04-23 Marek Safar <marek.safar@seznam.cz>
358 * constant.cs (FloatConstant.Reduce): Add range checking for checked context.
359 (DoubleConstant.Reduce): Ditto.
361 2006-04-23 Raja R Harinath <rharinath@novell.com>
363 * expression.cs (LocalVariableReference.DoResolveBase): Simplify.
364 Remove 'lvalue_right_side' argument. Move parts to ...
365 (LocalVariableReference.ResolveLocalInfo, LocalVariable.DoResolve)
366 (LocalVariable.DoResolveLValue): ... these.
368 2006-04-21 Raja R Harinath <rharinath@novell.com>
371 * codegen.cs (EmitContext.InRefOutArgumentResolving): Remove.
372 * expression.cs (EmptyExpression.LValueMemberOutAccess): New.
373 (LocalVariableReference.DoResolveBase): Use it to implement new
375 (IndexerAccess.DoResolveLValue): Handle LValueMemberOutAccess.
376 (Argument.Resolve): Simplify. Move CS1510 check ...
377 * ecore.cs (Expression.ResolveLValue): ... here.
378 (UnboxCast.DoResolveLValue): Handle LValueMemberOutAccess.
379 (PropertyExpr.DoResolveLValue): Likewise.
380 (FieldExpr.Report_AssignToReadonly): Likewise.
381 (FieldExpr.DoResolve): Add 'out_access' argument. Use
382 LValueMemberAccess or LValueMemberOutAccess on instance depending
384 (FieldExpr.DoResolveLValue): Pass 'out_access' argument to
385 DoResolve as appropriate.
387 2006-04-20 Raja R Harinath <rharinath@novell.com>
390 * expression.cs (Invocation.VerifyArgumentsCompat): Don't try
391 implicit conversions on 'out' and 'ref' arguments.
393 * expression.cs (Invocation.VerifyArgumentsCompat): Reorganize to
394 improve clarity. Remove dead code.
397 * statement.cs (Block.UsageWarning): Allow VariableInfo to be null.
398 (Catch.Resolve): Resolve VarBlock if it exists.
400 2006-04-19 Miguel de Icaza <miguel@novell.com>
402 * statement.cs (Foreach.EmitFinally): Do not emit the enumerator
403 twice, this was some residual code, the enumerator was emitted
404 properly in the two branche of if later.
408 Thanks to Martin for finding the source of the problem
410 2006-04-19 Raja R Harinath <rharinath@novell.com>
412 * expression.cs (Cast.ResolveLValue): Remove. The result of a
413 cast is never an lvalue.
414 (Cast.DoResolve, Cast.ResolveRest): Combine.
415 (Argument.Emit): Simplify slightly. Move 'Expr is
416 IMemoryLocation' check ...
417 (Argument.Resolve): ... here.
418 (Argument.Error_LValueRequired): Remove. Inline into only user.
420 Simplifications. Fix cs0191-2.cs
421 * ecore.cs (FieldExpr.DoResolve): Move handling of CS0192, CS0198,
422 CS1649 and CS1651 to ...
423 (FieldExpr.Report_AssignToReadonly): ... this. Simplify by moving
424 the actual selection of the error code and message to a lookup
425 table. Add a dummy return value to simplify callsites.
426 (FieldExpr.ResolveLValue): Don't allow a constructor to write to
427 readonly fields of other instances of the same type. Move CS0197
429 * expression.cs (Argument.Resolve): ... here. Simplify code.
430 Ensure that ec.InRefOutArgumentResolving is only set during LValue
431 resolution of an out or ref argument. The code simplification
432 above uses this invariant.
434 2006-04-18 Raja R Harinath <rharinath@novell.com>
436 Possibly fix #77752. Fix cs1690-[4-7].cs.
437 * ecore.cs (Expression.CheckMarshalByRefAccess): Renamed from
438 CheckMarshallByRefAccess. Drop parameter.
439 (FieldExpr.CheckMarshalByRefAccess): Update. Change CS1690 to a
441 (FieldExpr.DoResolve): Call CheckMarshalByRefAccess on
443 * report.cs (AllWarnings): Add CS1690.
444 * expression.cs (Argument.Resolve): Use EmptyExpression.OutAccess
446 (LocalVariableReference.DoResolveBase): Update.
448 2006-04-09 Marek Safar <marek.safar@seznam.cz>
450 * class.cs (MethodOrOperator): Moved common parts from method class.
451 detect obsolete attributes.
452 (Method.Define): Simplified as it reuses code from base.
453 (Constructor.ValidAttributeTargets): Fixed issue found during
455 (Destructor.ValidAttributeTargets): Fixed issue found during
457 (Operator): Finished refactoring set off by #78020. Operator class is now
458 ordinary method class.
460 * anonymous.cs: Updated.
462 2006-04-09 Marek Safar <marek.safar@seznam.cz>
464 * class.cs (Constructor.Emit): Don't emit the attributes twice.
466 2006-04-09 Marek Safar <marek.safar@seznam.cz>
468 * class.cs (Operator.Emit): Extracted code from MethodData to correctly
469 detect obsolete attributes.
470 (Method.CreateEmitContext): Moved to MethodOrOperator.
472 2006-04-09 Marek Safar <marek.safar@seznam.cz>
475 * class.cs (TypeContainer.MemberCoreArrayList.DefineContainerMembers): Throw
476 customized exception to make crash detection easier.
477 (MethodOrOperator): Started to work on new base class for methods and
479 (Method): Derives from MethodOrOperator.
480 (Constructor.Emit): Emits its own attributes.
481 (AbstractPropertyEventMethod.Emit): Ditto.
482 (Operator): Derives from MethodOrOperator, will refactor fully in extra
484 (Operator.Emit): It's temporary more tricky than should be.
486 * doc.cs (GetMethodDocCommentName): Updated after operator changes.
488 * report.cs (InternalErrorException): Add ctor with inner exception.
490 2006-04-08 Marek Safar <marek.safar@seznam.cz>
493 * ecore.cs (SimpleName.ResolveAsTypeStep): Report better error when type is
496 2006-04-07 Marek Safar <marek.safar@seznam.cz>
499 * expression.cs (ArrayCreation.GetAttributableValue): Creates correctly typed
502 2006-04-06 Marek Safar <marek.safar@seznam.cz>
504 * class.cs (Class.ApplyAttributeBuilder): Report an error when ComImport
505 attribute is present and Guid not.
506 (Interface.ApplyAttributeBuilder): Ditto.
508 * attribute.cs: Add error message.
510 2006-04-06 Marek Safar <marek.safar@seznam.cz>
514 * attribute.cs (Attribute.AttachTo): The attribute can have multiple
515 sources (it's composite) so hold them in extra array as they are used in
516 Emit phase only. It worked in the previous versions by mistake.
517 (Attribute.Emit): Emit attribute for more owners when exist.
519 * codegen.cs, class.cs: Updated to don't re-attach attribute twice as now
520 it has now different behaviour.
522 2006-04-04 Marek Safar <marek.safar@seznam.cz>
524 * constant.cs (Constant.IsDefaultInitializer): New method.
528 * expression.cs (ArrayCreation.CheckIndices): Add an optimization to don't
529 re-initialize default values. It saves KBs almost for every assembly.
530 Thanks Zoltan for the idea.
531 (ArrayCreation.ResolveInitializers): Renamed from ValidateInitializers.
532 (ArrayCreation.DoResolve): Resolve only once.
533 (ArrayCreation.Emit): Emit static initializer only when it is faster.
534 (ArrayCreation.GetAttributableValue): Cope with optimized values.
536 2006-04-03 Zoltan Varga <vargaz@gmail.com>
538 * report.cs (Warning, Error): Add 0-, 1-, and 2- argument specializations.
541 2006-04-01 Marek Safar <marek.safar@seznam.cz>
543 * assign.cs (Assign.DoResolve): Assignment to same variable can occur
544 in an embedded statement too.
546 2006-04-01 Raja R Harinath <rharinath@novell.com>
549 * typemanager.cs (IsNestedChildOf): Drop generic arguments before
553 * statement.cs (Switch.EmitObjectInteger) [ulong]: Remove bad cast.
556 * report.cs (SymbolRelatedToPreviousError): Drop generic type
557 arguments before checking whether a type is reflected or not.
560 * expression.cs (Invocation.IsApplicable): Ensure a generic method
561 definition doesn't take part in overload resolution.
562 (Invocation.IsParamsMethodApplicable): Likewise.
563 (Invocation.OverloadResolve): When replacing a reflected override
564 method with its base definition, ensure that type arguments are
567 2006-04-01 Marek Safar <marek.safar@seznam.cz>
571 * class.cs (TypeContainer.AddPartial): Don't report an error when modifier
574 * modifiers.cs: Add DEFAULT_ACCESS_MODIFER.
576 2006-03-31 Marek Safar <marek.safar@seznam.cz>
578 * assign.cs (LocalTemporary): Don't require ILGenerator in the resolve
581 * anonymous.cs, assign.cs, ecore.cs, expression.cs: Updated after
582 LocalTemporary change.
584 * class.cs (ClassOrStruct.DefineDefaultConstructor): Moved from
586 (ClassOrStruct.DefineFieldInitializers): Implemented static field
587 initializers optimization.
588 (ClassOrStruct.TypeAttr): Moved from modifiers.
589 (Constructor.CheckBase): Don't crash when static ctor has parameters.
590 (FieldBase.ResolveInitializer): Resolves initializer.
591 (FieldBase.HasDefaultInitializer): New property.
593 * cs-parser.jay: Removed message.
595 * expression.cs (CompilerGeneratedThis): New specialization.
597 * modifiers.cs (TypeAttr): Moved to ClassOrStruct.TypeAttr
599 2006-03-28 Marek Safar <marek.safar@seznam.cz>
601 * cs-parser.jay, cs-tokenizer.cs: On demand Stack allocation.
603 2006-03-27 Marek Safar <marek.safar@seznam.cz>
605 * ecore.cs (Expression.ResolveAsConstant): Clean up, enum constants should
606 be now EnumConstants only.
608 2006-03-27 Marek Safar <marek.safar@seznam.cz>
610 * attribute.cs, driver.cs: Reset more caches.
612 2006-03-26 Marek Safar <marek.safar@seznam.cz>
614 * cs-tokenizer.cs (adjust_real): Uses float.Parse for float literals.
616 2006-03-26 Marek Safar <marek.safar@seznam.cz>
618 * constant.cs (Constant.Reduce): Replaced EmitContext with single bool
619 for easier reuse. Updated all overrides.
620 (IntegralConstant): New base class for all integral constants.
621 (IntegralConstant.Error_ValueCannotBeConverted): When assigned value if out
622 of the constant range, report custom error.
623 (UIntConstant.Reduce): Fixed uint conversion.
625 * ecore.cs, literal.cs: Reduce updates.
627 2006-03-26 Marek Safar <marek.safar@seznam.cz>
631 * class.cs (Constructor.Define): Removed extra if for default ctors.
632 A patch from Atsushi Enomoto.
634 2006-03-26 Marek Safar <marek.safar@seznam.cz>
636 * attribute.cs (Attribute.ResolveConstructor): Conversion was moved to
637 GetAttributableValue.
639 * constant.cs (Constant.GetAttributableValue): Does implicit conversion
642 * convert.cs (ImplicitConversionRequired): Error message moved to
645 * ecore.cs (Expression.GetAttributableValue): Add type parameter for
646 automatic implicit conversion of an output value.
647 (EnumConstant.GetAttributableValue): Don't reduce the enum constants.
649 * expression.cs (ArrayCreation.GetAttributableValue): Add element type
651 (TypeOf.GetAttributableValue): Add extra handling for object type.
653 * literal.cs (DoubleLiteral.Error_ValueCannotBeConverted): Doubles can have
654 special error message.
656 2006-03-25 Marek Safar <marek.safar@seznam.cz>
658 * class.cs (Constructor.Emit): Don't crash when struct ctor is
660 (Constructor.ApplyAttributeBuilder): Transform MethodImplAttribute to be
661 compatible with MS runtime.
663 2006-03-23 Marek Safar <marek.safar@seznam.cz>
665 * attribute.cs (Attribute.ResolveConstructor): Check for an invalid
666 attribute arguments here.
668 * class.cs (Indexer.Define): The check was moved to attribute class.
670 2006-03-21 Marek Safar <marek.safar@seznam.cz>
672 * expression.cs (StringConcat.Append): Reverted back to no warning state.
674 2006-03-21 Marek Safar <marek.safar@seznam.cz>
676 * const.cs (Error_ConstantCanBeInitializedWithNullOnly): Share a message.
678 * statement.cs (Block.ResolveMeta): Look for wrong object constants in
681 2006-03-21 Atsushi Enomoto <atsushi@ximian.com>
683 * doc-bootstrap.cs : fix build.
685 2006-03-20 Marek Safar <marek.safar@seznam.cz>
687 * expression.cs (StringConcat.Append): Issue a warning when empty string
690 2006-03-20 Marek Safar <marek.safar@seznam.cz>
692 * assign.cs (CompoundAssign.ResolveSource): Removed.
694 * attribute.cs (ResolvePossibleAttributeType): Updated after MemberAccess
697 * class.cs (TypeContainer.FindMethods): Removed.
698 (TypeContainer.CheckMemberUsage): Made static.
700 * codegen.cs (GetAssemblyName): Uses Length for empty string test.
702 * constant.cs (CheckRange): Removed unused type argument.
703 (CheckUnsigned): Removed unused type argument.
705 * cs-parser.jay: Updated after MemberAccess clean up.
706 Uses Length for empty string test.
708 * cs-tokenizer.cs: Uses Length for empty string test.
709 (IsCastToken): Made static.
710 (is_hex): Made static.
711 (real_type_suffix): Made static.
713 * decl.cs (SetupCache): Made static.
714 (OnGenerateDocComment): Removed unused ds argument.
716 * delegate.cs (VerifyDelegate): Removed unused argument.
718 * doc.cs: Uses Length for empty string test.
720 * driver.cs: Uses Length for empty string test.
722 * enum.cs (IsValidEnumType): Made static
724 * expression.cs (EnumLiftUp): Removed unused argument.
725 (ResolveMethodGroup): Ditto.
726 (BetterConversion): Ditto.
727 (GetVarargsTypes): Ditto.
728 (UpdateIndices): Ditto.
729 (ValidateInitializers): Ditto.
730 (MemberAccess.ctor): Ditto.
731 (GetIndexersForType): Ditto.
733 * flowanalysis.cs: (MergeFinally): Removed unused argument.
735 * iterators.cs: Updated after MemberAccess clean up.
737 * location.cs: Uses Length for empty string test.
739 * namespace.cs: Uses Length for empty string test.
741 * report.cs (CheckWarningCode): Made static.
743 * statement.cs (LabeledStatement): Removed unused argument.
745 * typemanager.cs (FilterNone): Removed.
747 2006-03-18 Marek Safar <marek.safar@seznam.cz>
749 * codegen.cs (EmitContext.TestObsoleteMethodUsage): Removed as it become
754 2006-03-18 Marek Safar <marek.safar@seznam.cz>
756 * cs-parser.jay.cs: __arglist is not allowed for delegates.
758 2006-03-18 Marek Safar <marek.safar@seznam.cz>
762 * anonymous.cs.cs (AnonymousMethod): Add host to allow access to
764 (AnonymousMethod.ImplicitStandardConversionExists): New method.
765 (AnonymousMethod.Compatible): Moved parameter resolving to DoResolve.
766 Add more error reporting; Fixed issue with params.
768 * convert.cs (ImplicitStandardConversionExists): Returned conversion check.
770 * cs-parser.jay: AnonymousMethod requires host container.
772 * delegate.cs (NewDelegate.DoResolve): Updated after Compatible changes.
774 2006-03-18 Raja R Harinath <harinath@gmail.com>
776 * class.cs: Change 'TypeContainer ds' constructor argument to
777 'DeclSpace parent'. Some classes were missed below due to
778 different naming convention.
780 * class.cs (MemberCore.Parent): Delete. This makes the
781 ParentContainer changes below enforceable by the compiler.
783 Treat pointers to enclosing declaration space as 'DeclSpace', not
785 * class.cs, const.cs, delegate.cs, enum.cs, iterator.cs: Change
786 'TypeContainer parent' constructor argument to 'DeclSpace parent'.
788 * statement.cs (LocalInfo..ctor): Use DeclSpace argument instead
790 (Block.AddThisVariable): Likewise.
791 * class.cs (MethodData.Define, MethodData.Emit): Likewise.
792 (AbstractPropertyEventMethod.Emit): Likewise.
793 (AbstractPropertyEventMethod.EmitMethod): Likewise.
794 (GetMethod.Define, SetMethod.Define): Likewise.
795 (PropertyMethod.Define, DelegateMethod.Define): Likewise.
796 (DelegateMethod.EmitMethod): Likewise.
798 Fix regression test-partial-13.cs.
799 Rationalize use of PartialContainer. Ensure that the partial
800 class semantics can be tied to type-correctness, i.e., any
801 violation will cause a compile error.
802 * class.cs, const.cs: Access all fields that belong to class
803 TypeContainer via ParentContainer. Arguments of EmitContexts and
804 Resolve()-like functions still use 'Parent'.
806 * class.cs (SourceMethod): Use DeclSpace, not TypeContainer.
807 (*.CreateEmitContext): Change TypeContainer argument to DeclSpace.
808 (PropertyMethod.CheckModifiers): Remove unused argument.
809 * codegen.cs (EmitContext..ctor): Change TypeContainer argument to
812 2006-03-28 Raja R Harinath <rharinath@novell.com>
814 * decl.cs (DeclSpace.LookupGeneric): Update to changes.
816 2006-03-17 Raja R Harinath <harinath@gmail.com>
818 Make semantics of PartialContainer simpler.
819 * decl.cs (DeclSpace.IsPartial): Remove.
820 * class.cs (TypeContainer.IsPartial): Likewise.
821 (TypeContainer..ctor): Set PartialContainer to point to self.
822 (TypeContainer.GetClsCompliantAttributeValue): Don't use IsPartial.
823 (TypeContainer.FindNestedType): Likewise.
824 (MemberCore.ParentContainer): Simplify. Remove deprecation.
826 2006-03-17 Marek Safar <marek.safar@seznam.cz>
828 * typemanager.cs.cs (GetInterfaces): Don't recreate 0-sized arrays.
830 2006-03-15 Marek Safar <marek.safar@seznam.cz>
832 * class.cs (FieldMember.Emit): ParentContainer is real parent for partial
835 2006-03-15 Marek Safar <marek.safar@seznam.cz>
837 * class.cs (Operator.Define): An error for base conversion was not
840 2006-03-13 Marek Safar <marek.safar@seznam.cz>
842 A fix for #77593, #77574.
844 * class.cs (MethodCore.CheckBase): Another if for operator.
846 2006-03-18 Marek Safar <marek.safar@seznam.cz>
850 * expression.cs (VerifyArgumentsCompat): Reverted to double error
851 reporting, it's more tricky than I thought.
853 2006-03-09 Marek Safar <marek.safar@seznam.cz>
855 * anonymous.cs (AnonymousMethod.Compatible): Don't crash when parameters
858 * delegate.cs (Delegate.GetInvokeMethod): Use emitcontext free MemberLookup.
859 (DelegateCreation.ImplicitStandardConversionExists): New method for just
862 * ecore.cs (Expression.MemberLookup): Don't ask for emitcontext when it's
865 2006-03-04 Marek Safar <marek.safar@seznam.cz>
869 * class.cs (SetMethod.DefineParameters): Uses new parameters type ctor.
870 (Event.Define): ditto
871 (SetIndexerMethod.DefineParameters): Uses Parameters.MergeGenerated.
873 * delegate.cs (Delegate.Define): Uses Parameters.MergeGenerated.
874 Removed redundant code and set NewSlot for Invoke method too.
876 * parameter.cs (Parameters.ctor): Add custom, type ctor.
877 (Parameters.MergeGenerated): New method. Use this method when you merge
878 compiler generated argument with user arguments.
880 2006-03-03 Marek Safar <marek.safar@seznam.cz>
882 * attribute.cs (ResolveAsTypeTerminal): Removed.
884 * ecore.cs (Expression.ResolveAsTypeTerminal): Make virtual to allow
885 specialization for predefined types; 30% speed up.
886 Finally placed obsolete check to right place.
887 (Expression.ResolveType): Removed.
889 * enum.cs, expression.cs, parameter.cs, statement.cs, typemanager.cs:
890 Updated after ResolveType was removed.
892 * expression.cs (Cast.ctor): Check void cast.
893 (Binary.ResolveAsTypeTerminal): Is never type.
894 (Conditional.ResolveAsTypeTerminal): Is never type.
896 * rootcontext.cs (ResolveCore): Set base type to simplify some code later.
898 2006-03-26 Marek Safar <marek.safar@seznam.cz>
900 * rootcontext.cs (ResolveCore): Removed System.INullableValue.
902 2006-03-23 Martin Baulig <martin@ximian.com>
904 * expression.cs (Is.DoResolve, As.DoResolve): Perform a dynamic
905 type check if either of the types is an open generic type.
907 2006-03-23 Martin Baulig <martin@ximian.com>
910 (Convert.ExplicitTypeParameterConversion): New method; implement
911 explicit type parameter conversions.
913 2006-03-23 Martin Baulig <martin@ximian.com>
915 * convert.cs (Convert.ImplicitTypeParameterConversion): Do not
916 blindly allow all conversions if we do not have any constraints.
918 2006-02-27 Marek Safar <marek.safar@seznam.cz>
920 * attribute.cs (Attribute.PosArguments, Attribute.NamedArguments): Use
921 these two separated members to simplify the code.
922 (Attribute.Resolve): Refactored to use new fields and methods.
923 (Attribute.ResolveConstructor): Extracted from ResolveArguments and
924 implemented obsolete attribute checking.
925 (Attribute.ResolveNamedArguments): Extracted from ResolveArguments and
926 implemented obsolete checking again. It look line never ending quest ;-)
927 (GlobalAttribute.ResolveConstructor): Need to override as the rest.
929 * cfold.cs (BinaryFold): TryReduce throws an exception to indicate error.
931 * constanct.cs (TryReduce): Throws OverflowException to indicate error.
933 *class.cs (Property.Define): Add RegisterProperty call.
935 * cs-parser.jay: Replaced ArrayList with fixed array for attribute
936 argument groups (only 2).
938 * ecore.cs (Expression.GetAttributableValue): New virtual method used for
939 encoding expression to arguments.
940 (Expression.ExprClassToResolveFlags): Just turned to property.
942 * expression.cs (ArrayCreation.ValidateInitializers): Slightly optimized.
943 (ArrayCreation.GetAttributableValue): Renamed from EncodeAsAttribute and
944 optimized as well as implemented support for zero-length attributes.
946 * typemanager.cs (TypeManager.RegisterProperty, TypeManager.GetProperty):
947 Add caching of PropertyInfo's.
949 2006-02-25 Marek Safar <marek.safar@seznam.cz>
951 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Don't report
952 error multiple times.
954 2006-02-25 Marek Safar <marek.safar@seznam.cz>
956 New partial class implementation.
957 A fix for #77027, #77029, #77403
959 * attribute.cs (Attributable): Made attributes protected.
961 * class.cs (TypeContainer): Add PartialContainer and partial_parts as
962 the replacements of ClassPart and PartialContainer.
963 (TypeContainer.AddClassOrStruct): Call RecordDecl here.
964 (TypeContainer.AddInterface): Ditto.
965 (TypeContainer.AddPartial): The main method for partial classes. It checks
966 for errors and merges ModFlags and attributes. At the end class is added to
968 (TYpeContainer.DefineDefaultConstructor): Checks whether default ctor is
970 (TypeContainer.GetClsCompliantAttributeValue): Cope with partial class too.
971 (TypeContainer.GetNormalPartialBases): Resolves base classes and interfaces
972 from the rest of partial classes.
973 (TypeContainer.GetClassBases): Simplified.
974 (TypeContainer.DefineTypeBuilder): New method, mostly extracted from
976 (TypeContainer.DefineDefaultConstructor): Is used by derived classes.
977 (TypeContainer.HasExplicitLayout): Uses Flags now.
978 (PartialContainer): Removed.
979 (ClassOrStruct.AddToContainer): Moved enclosing member name check here.
980 (StaticClass): Was merged with Class.
981 (Class.GetClassBases): class and static class bases are verified here.
982 (Class.TypeAttr): Added static attributes when class is static.
983 (Struct.RegisterFieldForInitialization): Moved from TypeContainer.
984 (MemberBase): In some cases we need to call parent container for partial
985 class. It should be eliminated but it's not easy now.
987 * cs-parser.jay: Replaced all PartialContainer with AddPartial.
989 * decls.cs (MemberCore.DocComment): Introduced new property as is used by
990 partial classed to accumulate class comments.
991 (MemberCore.GetClsCompliantAttributeValue): Moved from TypeContainer.
993 * doc.cs (GenerateTypeDocComment): Partial classes clean up.
995 * driver.cs (MainDriver): Tree.GetDecl was removed.
997 * modifiers.cs (Modifiers): Add partial modifier.
999 * tree.cs (Tree.decl): Removed.
1000 (RootTypes): Started to use this class more often for root types
1003 2006-03-23 Raja R Harinath <rharinath@novell.com>
1005 * generic.cs (TypeParameter.UpdateConstraints): Update
1006 'constraints' if null.
1008 2006-02-22 Marek Safar <marek.safar@seznam.cz>
1012 * attribute.cs (AttributeTester.GetCoClassAttribute): Don't crash when
1013 external interface does not have an attribute.
1015 2006-02-22 Marek Safar <marek.safar@seznam.cz>
1017 Another prerequisites for new partial classs implementation.
1019 * attribute.cs (Attribute.Equal): Implemented.
1020 (Attribute.Emit): Changed as attributes can be applied more than twice.
1021 (Attributes.Emit): Check for duplicate attributes here.
1023 * class.cs, decl.cs, delegate.cs, doc.cs, enum.cs: Don't pass DeclSpace
1024 as a parameter, clean-up.
1026 2006-02-11 Marek Safar <marek.safar@seznam.cz>
1030 * class.cs (TypeContainer.DefineType): Cannot use ResolveType because it
1031 contains obsolete attribute check which can in some cases look for base
1032 type of current class which is not initialized yet.
1033 (TypeContainer.BaseType): Replacement of ptype.
1035 * decl.cs (MemberCore.CheckObsoleteType): Reuse existing code.
1037 2006-02-11 Marek Safar <marek.safar@seznam.cz>
1039 First of prerequisites for new partial classs implemention.
1041 * attribute.cs (Attributable): Extended by ResolveContext;
1042 Attributes finally have correct context for resolving in all cases.
1043 (AttachTo): Attribute owner is assigned here.
1045 * codegen.cs (IResolveContext): Introduce new interface to hold
1046 all information needed in resolving phase.
1047 (EmitContext): Implements IResolveContext; more clean-up needed here.
1049 * decl.cs (MemberCore): Implemented IResolveContext.
1051 * anonymous.cs, attribute.cs, class.cs, codegen.cs, const.cs,
1052 decl.cs, ecore.cs, enum.cs, expression.cs, iterators.cs, namespace.cs,
1053 parameter.cs, statement.cs, tree.cs, typemanager.cs:
1054 Refactored to use new IResolveContext instead of EmitContext; cleanup
1056 2006-03-22 Raja R Harinath <rharinath@novell.com>
1058 Support ParameterDefaultValueAttribute in gmcs. Also applied to
1059 mcs to keep code differences small.
1060 * attribute.cs (Attribute.GetParameterDefaultValue): New.
1061 * typemanager.cs (parameter_default_value_attribute_type): New.
1062 * parameter.cs (Parameter.ApplyAttributeBuilder): Use them. Add
1065 2006-03-22 Martin Baulig <martin@ximian.com>
1068 (Nullable.NullableLiteral): Derive from `NullLiteral'.
1071 (Convert.TypeParameter_to_Null): Create a `Nullable.NullableLiteral'
1072 instead of the normal `NullLiteral'.
1074 2006-03-21 Martin Baulig <martin@ximian.com>
1077 * generic.cs (TypeManager.InferType): If `pt' is a generic
1078 parameter, don't check whether `pt == at'.
1080 2006-03-20 Raja R Harinath <rharinath@novell.com>
1083 * generic.cs (Constraints.Resolve): Change argument to IResolveContext.
1084 (TypeParameter.Resolve): Update to change.
1085 (ConstraintChecker.CheckConstraints): Resolve type-argument
1086 constraints before use.
1088 2006-03-16 Martin Baulig <martin@ximian.com>
1091 (ConstraintChecker.HasDefaultConstructor): If we're a TypeBuilder
1092 and don't have any instance constructors, also lookup in the base class.
1093 (TypeManager.IsNullableValueType): New public method.
1095 * typemanager.cs (TypeManager.MemberLookup_FindMembers): Clear the
1096 `BindingFlags.DeclaredOnly' flag and set `used_cache'.
1097 (TypeManager.TryGetBaseDefinition): Use DropGenericMethodArguments().
1099 * expression.cs (Unary.DoResolve): Use TypeManager.IsNullableValueType()
1100 instead of just TypeManager.IsNullableType() to determine whether
1101 a lifted operator exists.
1102 (UnaryMutator.DoResolve): Likewise.
1103 (Conditional.DoResolve): Likewise.
1104 (Binary.DoResolve): A lifted operator only exists if both operands
1105 are valuetypes and at least one of them is a nullable type.
1107 2006-03-14 Atsushi Enomoto <atsushi@ximian.com>
1109 * iterator.cs : yield break is allowed in try statement which has
1110 catch clauses. Fixed bug #77767.
1112 2006-03-12 Martin Baulig <martin@ximian.com>
1114 * typemanager.cs (TypeManager.ArrayContainsMethod): Use a new
1115 private IsSignatureEqual() to compare types; see the comment in
1116 that method; fixes #77674.
1118 2006-03-10 Raja R Harinath <rharinath@novell.com>
1120 * ecore.cs (Expression.ResolveAsTypeStep): Remove 1-argument wrapper.
1121 (Expression.ResolveAsTypeTerminal): Likewise.
1122 * class.cs, decl.cs, delegate.cs, ecore.cs: Update to changes.
1123 * expression.cs, generic.cs, iterators.cs: Likewise.
1124 * parameter.cs, statement.cs, typemanager.cs: Likewise.
1126 2006-03-09 Martin Baulig <martin@ximian.com>
1128 * generic.cs (ConstraintChecker.HasDefaultConstructor): Call
1129 TypeManager.DropGenericTypeArguments() on the `atype'; fixes #77548.
1131 2006-03-09 Martin Baulig <martin@ximian.com>
1133 * ecore.cs (FieldExpr.AddressOf): Don't emit the instance if the
1134 `prepared' flag is set.
1136 * generic.cs (LiftedBinaryOperator): Don't allow `||' or `&&' anymore.
1137 (LiftedBinaryOperator, LiftedUnaryMutator): Fix a few nullable
1138 issues; see gtest-254.cs.
1140 2006-03-07 Martin Baulig <martin@ximian.com>
1142 * generic.cs (TypeManager.InferType): Allow infering
1143 `IEnumerable<T>' with an array of T; see gtest-251.cs.
1145 2006-03-06 Martin Baulig <martin@ximian.com>
1148 (TypeManager.InferType): Fix gtest-250.cs.
1151 (TypeManager.IsSubclassOf): Also check the base class.
1154 (Invocation.IsAncestralType): Use TypeManager.IsSubclassOf();
1157 2006-03-01 Raja R Harinath <rharinath@novell.com>
1160 * expression.cs (ParameterReference.DoResolveBase): Change return
1162 (ParameterReference.DoResolve, ParameterReference.DoResolveLValue):
1166 * ecore.cs (PropertyExpr.InstanceResolve): Fix CS1540 check.
1169 * typemanager.cs (GetFullNameSignature): Don't nullref on
1170 protected accessors.
1172 2006-02-16 Martin Baulig <martin@ximian.com>
1175 (TypeManager.GetGenericFieldDefinition): New public method; use it
1176 instead of the `FieldInfo.Mono_GetGenericFieldDefinition()' icall.
1178 2006-02-14 Martin Baulig <martin@ximian.com>
1180 * *.cs: Use `Type.IsGenericType' instead of `Type.IsGenericInstance'.
1182 2006-02-14 Martin Baulig <martin@ximian.com>
1185 (TypeManager.DropGenericMethodArguments): New public method; don't
1186 use GetGenericMethodDefinition() on something which is not a
1189 2006-02-14 Martin Baulig <martin@ximian.com>
1192 (ConstraintChecker.CheckConstraints): If a type parameter has the
1193 `struct' constraint, the type must be a non-nullable valuetype.
1195 2006-02-10 Martin Baulig <martin@ximian.com>
1198 (TypeManager.IsOverride): Make this work for instantiated methods
1199 in a generic class; fixes #77509.
1200 (TypeManager.ExpandInterfaces): Use TypeManager.GetInterfaces()
1201 rather than calling it directly; fixes #77488.
1203 2006-02-08 Martin Baulig <martin@ximian.com>
1205 * generic.cs (ConstraintChecker.CheckConstraints): Move the error
1206 reporting into CheckConstraint() so we can use the correctly
1209 2006-02-08 Martin Baulig <martin@ximian.com>
1211 * expression.cs (BaseAccess): Add support for generic methods.
1213 * ecore.cs (MethodGroupExpr.ResolveGeneric): Propagate `IsBase' to
1214 the new MethodGroupExpr.
1216 2006-02-07 Martin Baulig <martin@ximian.com>
1218 * generic.cs (ConstraintChecker.CheckConstraints): Interfaces are
1219 also reference types; fixes #77483.
1221 2006-02-07 Martin Baulig <martin@ximian.com>
1224 (TypeManager.IsGenericMethod): We now return whether something is
1225 an instantiated generic method (and not a generic method def).
1226 (TypeManager.IsGenericMethodDefinition): New public method.
1229 (TypeManager.CSharpSignature): Only include type arguments for
1230 "real" generic methods, not for any instantiated method.
1231 (TypeManager.GetMethodName): Likewise, but also allow generic
1232 method definitions here.
1234 2006-02-06 Miguel de Icaza <miguel@novell.com>
1236 * codegen.cs (EmitScopeInitFromBlock): check here the
1237 capture_context, there is no need to make two calls to the
1240 * anonymous.cs: Add some debugging messages that might help me
1241 track other instances of this problem in the future (the
1242 regression of test 467).
1244 * cs-parser.jay: track the variable block, as we need to initalize
1245 any captured variables declared in this block for the "catch"
1246 portion of the "Try" statement.
1248 * statement.cs (Try.Emit): If the "Catch" has a VarBlock, emit any
1249 scope initialization for captured variables.
1251 Also, move the emit for the variables after the block location has
1254 2006-02-06 Marek Safar <marek.safar@seznam.cz>
1256 * ecore.cs (PropertyExpr.FindAccessors): Just made flags const.
1258 2006-02-06 Martin Baulig <martin@ximian.com>
1260 * class.cs (TypeContainer.DefineType): If we're a struct, pass
1261 `TypeManager.value_type' as parent type to
1262 ModuleBuilder.DefineType(). Fixes #77358.
1264 2006-02-02 Miguel de Icaza <miguel@novell.com>
1266 * anonymous.cs (CaptureContext.EmitInitScope): I was wrong in the
1267 commit yesterday, the initialization for the roots is necessary.
1268 What is not necessary is the scope activation.
1270 2006-02-02 Raja R Harinath <rharinath@novell.com>
1272 * ecore.cs (PropertyExpr.DoResolveLValue): Add CS0206 check.
1273 * expression.cs (IndexerAccess.DoResolveLValue): Add CS1612 and
1275 (Argument.Resolve): Remove CS0206 checks.
1277 2006-02-01 Miguel de Icaza <miguel@novell.com>
1279 * anonymous.cs (CaptureContext.EmitInitScope): Do not emit the
1280 scopes for all the roots, the scopes will now be emitted when the
1281 Blocks are entered. [This change was wrong, fixed on 2006-02-02]
1283 (CaptureContext.EmitScopeInitFromBlock): Simply emit the ScopeInfo
1284 code. This reduces a lot of existing cruft.
1286 * statement.cs (Block.Emit): Call EmitScopeInitFromBlock here, so
1287 that the ScopeInfo is generated as we enter the scope, not at the
1288 time of use, which is what we used to do before.
1290 * codegen.cs (EmitScopeInitFromBlock): New routine, this is called
1291 every time a Block is about to be emitted if we have a
1294 2006-02-01 Raja R Harinath <rharinath@novell.com>
1296 * codegen.cs (AssemblyClass.Emit): Emit RuntimeCompatibility
1297 attribute for mscorlib too.
1299 * typemanager.cs (NoTypes, NoTypeExprs): Remove.
1301 * *.cs: Use Type.EmptyTypes instead of TypeManager.NoTypes.
1303 * typemanager.cs (cons_param_array_attribute): Make private.
1304 (Reset): Set it to null.
1305 (InitCoreHelpers): Don't initialize it.
1306 (ConsParamArrayAttribute): New. Initialize it as needed.
1307 * parameter.cs (ParamsParameter.ApplyAttribute): Update to change.
1309 2006-01-31 Miguel de Icaza <miguel@novell.com>
1311 * expression.cs: There might be errors reported during the
1312 selection of applicable methods. If there are errors, do not
1313 continue execution as it will lead the compiler to crash.
1315 2006-01-30 Miguel de Icaza <miguel@novell.com>
1317 * expression.cs: Member access is not allowed on anonymous
1318 methods. Fixes #77402.
1320 2006-01-30 Raja R Harinath <rharinath@novell.com>
1323 * cs-parser.jay (VariableDeclaration): Don't set
1324 current_array_type to null.
1325 (field_declaration, event_declaration, declaration_statement):
1326 Set it to null here.
1328 2006-01-29 Raja R Harinath <harinath@gmail.com>
1331 * generic.cs (TypeManager.IsEqual): Handle pass-by-ref types.
1333 2006-01-28 Raja R Harinath <harinath@gmail.com>
1335 * typemanager.cs (GenericParameterPosition): New.
1338 2006-01-28 Atsushi Enomoto <atsushi@ximian.com>
1340 * doc.cs : To process "include" elements, first we should create
1341 another list than XmlNodeList, because it could result in node
1342 removal, which could result in that the XmlNodeList gives up
1345 2006-01-25 Miguel de Icaza <miguel@novell.com>
1347 * expression.cs: Introduce an error report that we were not
1348 catching before. Gonzalo ran into it.
1350 2006-01-23 Miguel de Icaza <miguel@novell.com>
1352 A fix for bug: #76957
1354 * iterators.cs (MoveNextMethod.CreateMethodHost): call
1355 ComputeMethodHost before creating the method, this is a new
1358 * anonymous.cs (AnonymousContainer): Now we track all the scopes
1359 that this method references (RegisterScope). The actual scope
1360 where the method is hosted is computed with the ComputeMethodHost
1361 before we create the method.
1363 Moved the Deepest routine here.
1365 (AnonymousContainer.ComputeMethodHost): New routine used to
1366 compute the proper ScopeInfo that will host the anonymous method.
1368 (ScopeInfo): Deal with multiple roots. The problem was that we
1369 did not have a unique root where all ScopeInfos could be hanged
1370 from. Remove `topmost' ScopeInfo, and instead keep an arraylist
1373 Remove AdjustMethodScope which is now computed at the end. Remove
1374 LinkScope which did a partial link, instead link all ScopeInfos
1375 before code generation from the new "LinkScopes" routine.
1377 Simplify all the Add* routines as they no longer need to maintain
1378 the tree, they just need to record that they are using variables
1381 (IsAncestor, GetAncestorScopes, GetParentScope, LinkScope): New
1382 routines to produce the forest of ScopeInfo trees.
1384 * class.cs (TypeContainer.AppendMethod): This is just like
1385 AddMethod, but ensures that an interface implementation method
1386 (IEnumerable.XXX) is not inserted at the beginning of the queue of
1387 methods, but at the end.
1389 We use this functionality to ensure that the generated MoveNext
1390 method in the iterator class is resolved/emitted before the
1391 enumerator methods created.
1393 This is required because the MoveNext method computes the right
1394 ScopeInfo for the method. And the other methods will eventually
1395 need to resolve and fetch information computed from the anonymous
1399 2006-01-23 Raja R Harinath <rharinath@novell.com>
1401 Improve implementation of section 14.4.2.2 (Better function member).
1402 * expression.cs (Invocation.MoreSpecific): Compare all type
1403 arguments before deciding if one type is more specific than
1404 another. Handle array types too. Return the more specific type.
1405 (Invocation.BetterFunction): Add more tie-breaking rules from
1406 section 14.4.2.2. Perform "more specific" check after
1407 other tie-breaking rules. Compare all parameter types before
1408 choosing the "more specific" method.
1410 2006-01-21 Raja R Harinath <harinath@gmail.com>
1411 Carlos Alberto Cortez <calberto.cortez@gmail.com>
1414 * namespace.cs (NamespaceEntry.UsingExternalAliases): Don't add to
1416 (NamespaceEntry.LookupAlias): Lookup 'extern_aliases' hash too.
1417 (NamespaceEntry.VerifyUsing): Resolve external aliases too.
1419 2006-01-18 Martin Baulig <martin@ximian.com>
1421 * class.cs (TypeContainer.AddToMemberContainer): Use
1422 `symbol.MemberName.MethodName' instead of just `symbol.Name';
1425 2006-01-18 Martin Baulig <martin@ximian.com>
1427 Fix #76417: a generic class may now have methods which may unify
1428 for some type parameter substitutions.
1430 * class.cs (Method.IsDuplicateImplementation): Don't report CS0408
1431 for methods which may unify anymore.
1433 * expression.cs (Invocation.MoreSpecific): New private static
1434 method; checks whether one method is more specific than another
1435 according to 14.4.2.2 of the spec.
1436 (Invocation.BetterFunction): Implement the tie-breaking rules from
1437 14.4.2.2 of the spec: if two methods unify for some type parameter
1438 substitution, we need to pick the more specific one.
1440 2006-01-18 Raja R Harinath <rharinath@novell.com>
1442 Fix #76656, cs0231-2.cs.
1443 * cs-parser.jay (formal_parameter_list): Make error case catch
1445 (parenthesized_expression_0): Add CS1026 check.
1446 (invocation_expression): Remove unused { $$ = lexer.Location }.
1448 2006-01-17 Raja R Harinath <rharinath@novell.com>
1451 * cs-parser.jay (statement_expression): Don't list out the
1452 individual statement-expressions. Convert syntax error into
1455 2006-01-16 Raja R Harinath <rharinath@novell.com>
1458 * ecore.cs (MemberAccess.CheckIntermediateModification): Remove.
1459 (UnboxCast.DoResolveLValue): New. Move CS0445 check from
1460 CheckIntermediateModification.
1461 (FieldExpr.DoResolve): Add new two-argument version that
1462 allows us to resolve the InstanceExpression as an lvalue.
1463 The one-argument variant is now just a wrapper.
1464 (FieldExpr.DoResolveLValue): Use two-argument DoResolve.
1465 Resolve the lhs as an lvalue if the it has a value type.
1466 (FieldExpr.AssignToReadonly): Move CS1648 and CS1650 checks
1467 from Assign.DoResolve.
1468 (PropertyExpr.InstanceResolve): Allow InstanceExpression to be
1469 resolved as an lvalue.
1470 (PropertyExpr.DoResolve): Update.
1471 (PropertyExpr.DoResolveLValue): Resolve the lhs as an lvalue if it
1472 has a value type. Move CS1612 check here from
1473 CheckIntermediateModification.
1474 * assign.cs (Assign.DoResolve): Remove CS1648 and CS1650 checks.
1475 * expression.cs (EmptyExpression.OutAccess): New. Used as the
1476 'right_side' of a ResolveLValue on an 'out' argument.
1477 (EmptyExpression.LValueMemberAccess): New. Used as the
1478 'right_side' of a propagated ResolveLValue on a value type.
1479 (LocalVariableReference.DoResolveBase): Recognize
1480 EmptyExpression.OutAccess and EmptyExpression.LValueMemberAccess.
1482 (Argument.Resolve): Use EmptyExpression.OutAccess rather than
1483 EmptyExpression.Null.
1485 2006-01-16 Atsushi Enomoto <atsushi@ximian.com>
1487 * typemanager.cs : added IsGenericParameter(). In gmcs it returns
1488 Type.IsGenericParameter(). Fixed bug #77183.
1489 * doc.cs : it is now identical to doc.cs in mcs.
1491 2006-01-16 Martin Baulig <martin@ximian.com>
1493 * generic.cs (ConstraintChecker.CheckConstraint): Fix #77167.
1495 2006-01-16 Martin Baulig <martin@ximian.com>
1497 * typemanager.cs (TypeManager.CSharpSignature): Make this work for
1498 ctors; fixes #77250.
1500 2006-01-12 Miguel de Icaza <miguel@novell.com>
1502 This fixes the problem where we used ldfld instead of ldflda to
1503 load the "THIS" pointer on captured parameters, when THIS is a
1504 value type. See bug #77205.
1506 * iterators.cs (CapturedThisReference.Emit): Pass false to
1507 EmitThis (we do not need the address).
1509 * codegen.cs (EmitThis): it needs to know whether we need the
1510 address of `this' or not. This is used by value types.
1512 * expression.cs (This.AddressOf): Pass true to the EmitThis call,
1513 every other call passes false.
1515 2006-01-12 Raja R Harinath <rharinath@novell.com>
1518 * typemanager.cs (TryGetBaseDefinition): Rename from the mis-named
1520 * expression.cs (Invocation.OverloadResolve): Update.
1521 (Invocation.DoResolve): Avoid double resolution of invocation.
1523 2006-01-11 Raja R Harinath <rharinath@novell.com>
1526 * expression.cs (Unary.Emit): When in /checked+ mode, don't emit
1527 unary negation of floating point types as 0-expr; negation cannot
1528 overflow in floating point types.
1531 * expression.cs (MemberAccess.DoResolve): Disallow the use of '.'
1532 on operands of 'void' type.
1535 * cfold.cs (BinaryFold): Implement folding of BinaryOr, BinaryAnd
1536 and ExclusiveOr for boolean constants too.
1538 2006-01-12 Ben Maurer <bmaurer@andrew.cmu.edu>
1540 * expression.cs: Fix Console.WriteLine ((this = x).foo);
1542 2006-01-12 Miguel de Icaza <miguel@novell.com>
1544 * cs-tokenizer.cs (Position): New class used to save and restore
1545 the position state in the tokenizer. Before this patch the save
1546 and restore was not complete enough so the line and columns would
1547 start to drift and the debugger and stack traces will get the
1550 2006-01-10 Martin Baulig <martin@ximian.com>
1553 (TypeParameter.InflateConstraints): New public method.
1555 * iterators.cs (Iterator.DefineNestedTypes): Also inflate the
1556 constraints; fixes #77042.
1558 2006-01-10 Martin Baulig <martin@ximian.com>
1560 * anonymous.cs (ScopeInfo.EmitScopeType): Use the `CurrentType'
1561 instead of the `TypeBuilder' for this "<>THIS" variable; fixes
1564 2006-01-09 Raja R Harinath <rharinath@novell.com>
1567 * expression.cs (Invocation.OverloadResolve): Replace reflected
1568 override methods with their base virtual methods, rather than
1570 * typemanager.cs (TypeManager.GetOverride): New.
1572 2005-12-21 Miguel de Icaza <miguel@novell.com>
1574 * driver.cs: Report the case of no source files and no -out:
1577 2005-12-20 Raja R Harinath <rharinath@novell.com>
1580 * expression.cs (ComposedCast.GetSignatureForError): Define.
1582 2006-01-05 Jb Evain <jbevain@gmail.com>
1584 * class.cs (Property.Define, Indexer.Define): do not tag the
1585 properties as SpecialName | RTSpecialName.
1587 2006-01-04 Miguel de Icaza <miguel@novell.com>
1589 * class.cs (MethodCore.IsDuplicateImplementation): This method was
1590 doing a low-level comparission of parameter types. It was lacking
1591 a check for __argslist.
1593 2005-12-30 Miguel de Icaza <miguel@novell.com>
1595 * expression.cs (ParameterReference.DoResolveBase): Allow
1596 reference parameters if they are local to this block.
1598 This allows the ref and out parameters of a delegate to be used in
1599 an anonymous method, for example:
1601 delegate void set (out int x);
1603 set s = delegate (out int x){
1607 This is used by functionality introduced late in the C# language.
1609 * anonymous.cs (AnonymousMethod.Compatible): Allow anonymous
1610 method that take ref and out parameters.
1612 Fixes #77119 which was a late change in the spec.
1614 2005-12-23 Miguel de Icaza <miguel@novell.com>
1616 * anonymous.cs (ScopeInfo.LinkScope): Do not link the scope to its
1617 parent if its the same scope. Fixes #77060.
1619 2005-12-22 Marek Safar <marek.safar@seznam.cz>
1621 * expression.cs (ComposedCast.DoResolveAsTypeStep): Fixed wrong merge.
1623 2005-12-21 Carlos Alberto Cortez <calberto.cortez@gmail.com>
1625 * codegen.cs (AssemblyClass.CheckInternalsVisibleAttribute): Generate
1626 errors 1726 for strong named assemblies with InternalsVisibleToAttribute
1627 that doesn't contain the full public key. This is a update of the
1628 friend assemblies in .Net 2.0 release.
1630 2005-12-18 Carlos Alberto Cortez <calberto.cortez@gmail.com>
1634 * namespace.cs (NamespaceEntry): Add extern_aliases as a
1635 ListDictionary, to contain the ExternAliasEntry entries (in
1636 addition to the NamespaceEntry.aliases hashtable). This field is
1637 shared between the original entry and its doppelganger (bodyless
1639 (NamespaceEntry.UsingExternalAlias): Add the extern alias entry to
1640 extern_aliases field.
1641 (NamespaceEntry.Lookup): Move the IsImplicit check after the
1642 lookup in extern_aliases.
1644 2005-12-16 Raja R Harinath <rharinath@novell.com>
1647 * class.cs (TypeContainer.Mark_HasEquals): New.
1648 (TypeContainer.Mark_HasGetHashCode): New.
1649 (ClassPart): Override them.
1650 (MethodCore.CheckBase): Use them instead of referring to Parent.Methods.
1652 * generic.cs (GenericMethod.DefineMembers): Update to changes.
1653 (TypeParameter.TypeParameter): Change type of 'parent' argument to
1657 * enum.cs (EnumMember.EnumMember): Pass the parent_enum as the
1658 'parent' argument to the base constructor.
1660 Remove all mention of TypeContainer from decl.cs.
1661 * decl.cs (MemberCore.Parent): Change into a DeclSpace.
1662 (MemberCore.MemberCore): Change type of 'parent' argument to DeclSpace.
1663 (DeclSpace.DeclSpace): Likewise.
1664 (DeclSpace.DefineMembers): Remove unused argument.
1665 * cs-parser.jay (pop_current_class): Update to changes. Simplify
1666 debugging check -- we don't care if the debug code throws an
1667 InvalidCastException instead of an InternalErrorException.
1668 * class.cs (TypeContainer.DefineMembers): Update to changes.
1669 (TypeContainer.DoDefineMembers): Likewise.
1670 (TypeContainer.GetMethods): Likewise.
1671 (PropertyMember.Define): Likewise.
1672 (MemberBase.Parent): New property that forwards to
1673 MemberCore.Parent, but ensures that we get a TypeContainer.
1674 * rootcontext.cs (RootContext.PopulateCoreType): Update to changes.
1675 (RootContext.PopulateTypes): Likewise. Remove special case code
1676 for !RootContext.StdLib: DefineMembers is idempotent.
1678 2005-12-13 Marek Safar <marek.safar@seznam.cz>
1680 * class.cs (Method.ApplyAttributeBuilder): Test out modifier properly.
1682 2005-12-11 Atsushi Enomoto <atsushi@ximian.com>
1684 * doc.cs : The search for referenced namespace was insufficient to
1685 get global one as it used to do. Fixed bug #76965.
1687 2005-12-10 Atsushi Enomoto <atsushi@ximian.com>
1689 * doc.cs : check name in cref in the last phase that whether it is
1692 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
1694 * cs-tokenizer.cs : reverted the latest change: it somehow broke
1697 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
1699 * doc.cs : so it turned out that we cannot skip override check for
1700 interface members. Fixed bug #76954.
1702 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
1704 * cs-tokenizer.cs : fixed bug #75984:
1705 - #warning and #error should not be handled when the source line
1707 - #line is not checked strictly when the source line is disabled.
1708 - #define and #undef is on the other hand checked strictly at any
1711 2005-12-08 Atsushi Enomoto <atsushi@ximian.com>
1713 * cs-tokenizer.cs : missing Location (actually, filename) in one of
1716 2005-12-15 Raja R Harinath <rharinath@novell.com>
1718 * generic.cs (TypeManager.IsGeneric): Remove unused method.
1720 * typemanager.cs (TypeManager.GetFullName): Rewrite to handle
1723 2005-12-14 Martin Baulig <martin@ximian.com>
1725 * typemanager.cs (TypeManager.GetFullName): Make this public;
1726 `Type.Fullname' now never returns null.
1728 * class.cs (Method.Define): Use TypeManager.GetFullName() for
1729 explicit interface implementations; we're now using the same
1730 naming convention than csc does.
1732 2005-12-14 Miguel de Icaza <miguel@novell.com>
1734 * convert.cs (ExplicitConversionCore): Check the return value from
1735 ExplicitConversionCore which can return null on failure. Fixes #76914
1737 2005-12-09 Raja R Harinath <rharinath@novell.com>
1739 * anonymous.cs (AnonymousMethod.Compatible): Use IsGenericType
1740 instead of IsGenericInstance.
1741 * generic.cs (TypeManager.IsEqual): Likewise. Delete redundant
1742 code that's now covered by the more general test.
1743 * typemanager.cs (TypeManager.IsPrivateAccessible): Likewise.
1745 * generic.cs (DropGenericTypeArguments): New. Captures the common
1746 pattern: if (t.IsGenericInstance) t = t.GetGenericTypeDefinition ();
1747 * attribute.cs, class.cs, decl.cs, ecore.cs: Use it.
1748 * generic.cs, report.cs, typemanager.cs: Likewise.
1750 2005-12-08 Martin Baulig <martin@ximian.com>
1752 * generic.cs (TypeArguments.Resolve): Added CS1547 check.
1754 * typemanager.cs (TypeManager.CSharpSignature): Include type
1755 arguments in the signature of a generic method.
1757 2005-12-07 Martin Baulig <martin@ximian.com>
1759 Add support for custom attributes on type parameters.
1761 * cs-parser.jay (type_arguments): Added `opt_attributes'.
1763 * generic.cs (TypeParameterName): New public class; we use this
1764 instead of a `string' to store the name of a type parameter, so we
1765 can also have `Attributes'.
1766 (TypeArguments.GetDeclarations): Return a `TypeParameterName[]'
1767 array instead of a `string[]' array.
1768 (TypeParameter.ctor): We now also take an `Attributes' argument.
1769 (TypeParameter.EmitAttributes): New public method; emit our
1770 `OptAttributes' here.
1771 (GenericMethod.EmitAttributes): New public method; emit the custom
1772 attributes on all our type parameters.
1774 * class.cs (TypeContainer.EmitType): Call EmitAttributes() on all
1775 our type parameters.
1776 (MethodData.Define): If we're a generic method, call
1777 EmitAttributes() on it.
1779 2005-12-07 Martin Baulig <martin@ximian.com>
1782 (ConstraintChecker): New public abstract class; move the
1783 constraint checking here from `ConstructedType' and also do
1784 constraint checking for generic methods here.
1786 * expression.cs (Invocation.OverloadResolve): Use
1787 ConstraintChecker.CheckConstraints() if we resolved to a generic
1790 2005-12-05 Marek Safar <marek.safar@seznam.cz>
1792 * attribute.cs (GlobalAttribute.ctor): Pass NamespaceEntry only.
1794 * class.cs (EmitFieldInitializers): Simplified and fixed to work with
1796 (FieldBase.EmitInitializer): Moved from TypeContainer and simplified.
1797 (FieldBase.Initializer): Initializer is now optional.
1798 (EventField.Define): Only event field can have initializer.
1800 * codegen.cs (EmitContext): DeclSpace is not readonly (small hack).
1802 * const.cs (Const): Reuse initializer.
1804 * cs-parser.jay: Updated after FieldBase changes.
1805 Added current_array_type to simplify array initializers.
1807 * ecore.cs (NullCast.IsDefaultValue): Implemented.
1809 * expression.cs, iterators.cs: Updated.
1811 * namespace.cs (NamespaceEntry): Made UsingFound private.
1813 2005-12-05 Marek Safar <marek.safar@seznam.cz>
1815 * parameterCollection.cs: Obsolete, removed.
1816 * parser.cs: Obsolete, removed.
1818 2005-12-05 Marek Safar <marek.safar@seznam.cz>
1821 * class.cs (Constructor.Emit): Set obsolete checking for whole context.
1823 * enum.cs (Enum.Define): Set obsolete context here.
1825 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
1828 - FindDocumentedMember() now expects 1) paramList as null
1829 when "we don't have to check the number of parameters" and
1830 2) Type.EmptyTypes when "there is no arguments".
1831 - Introduced FoundMember struct to hold the exact type which was
1832 used to find the documented member (the above change broke
1833 test-xml-044; it might be better just to use DeclaringType than
1834 what MS does, like this change does, but it depends on usage.)
1836 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
1838 * doc.cs : documented member might be from DeclaringType for nested
1839 types. Fixed bug #76782.
1841 2005-12-03 Ben Maurer <bmaurer@ximian.com>
1843 * anonymous.cs: Have the param code handle leaving copies on the
1844 stack etc. Allows anonymous params to take part in the assignment
1845 code (++, +=, etc). Fixes bug #76550
1847 * expression.cs: Handle the prepare_for_load/leave_copy by passing
1848 it down to the anon code.
1850 * iterators.cs: Use dummy var here
1852 * codegen.cs: Handle new vars
1854 2005-12-01 Marek Safar <marek.safar@seznam.cz>
1857 * class.cs (MethodData.Define): Set proper Obsolete context.
1859 * ecore.cs (FieldExpr.ResolveMemberAccess): Don't check [Obsolete] in
1861 (FieldExpr.DoResolve): Ditto.
1863 2005-12-01 Marek Safar <marek.safar@seznam.cz>
1866 * class.cs (MethodCore.DoDefineParameters): Test [Obsolete] only when
1867 parent is not obsolete.
1869 2005-12-01 Atsushi Enomoto <atsushi@ximian.com>
1871 * doc.cs : (FindDocumentedMember) find parameterless members first
1872 and get CS0419 in the early stage. Fixed first case of bug #76727.
1874 2005-11-30 Marek Safar <marek.safar@seznam.cz>
1877 * ecore.cs (Expression.ResolveAsConstant): Report constant error only when
1878 no error was reported.
1880 *expression.cs (Binary.DoResolve): left can be null.
1882 2005-12-06 Raja R Harinath <rharinath@novell.com>
1884 * class.cs (MethodCore.CheckGenericOverride): Delete unused
1885 abstract method and all overrides.
1886 * support.cs (ParameterData.GenericConstraints): Delete.
1887 (ReflectionParameters.type_params): Delete.
1888 (ReflectionParameters.ReflectionParameters): Make private.
1889 (ReflectionParameters.GetConstaints): New factory method.
1890 * generic.cs (TypeParameterDefineType): Use it.
1891 (TypeManager.GetTypeParameterConstraints): Likewise.
1893 2005-11-22 Marek Safar <marek.safar@seznam.cz>
1896 * class.cs (MethodData.Emit): Parameters should be labeled first.
1898 2005-11-21 Marek Safar <marek.safar@seznam.cz>
1901 * parameter.cs (Parameter.ApplyAttributeBuilder): Fixed `ref' detection.
1903 2005-11-18 Marek Safar <marek.safar@seznam.cz>
1905 * attribute.cs (AreParametersCompliant): Moved to Parameter.
1907 * class.cs (MethodCore): Parameter clean up.
1908 (IMethodData): Added ParameterInfo.
1909 (MethodData): Parameter clean up.
1910 (Indexer.Define): Parameter clean up.
1922 * typemanager.cs: Parameter clean up.
1924 * delegate.cs (Define): Get rid of duplicated code.
1926 * expression.cs (ParameterReference): Removed useless parameters
1928 (Invocation): Ditto.
1930 * parameter.cs (ParamsParameter): New class, params specialization.
1931 (ArglistParameter): Attemp to separate arglist.
1932 (Parameter): Refactored to be reusable and faster.
1933 (Parameter.Modifier): Made understandable.
1934 (Parameters): Changed to be used as a class for `this' assembly
1935 parameters. Refactored to use new specialized classes.
1937 * support.cs (ParameterData): Added Types property.
1938 (InternalParameters): Deleted.
1940 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
1942 * doc.cs : the previous patch does not actually fix the bug.
1943 PropertyInfo override check is now implemented and really fixed it.
1944 * expression.cs : Invocation.IsAncestralType() is used from doc.cs.
1946 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
1948 * doc.cs : apply "override filter" also to properties.
1951 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
1953 * doc.cs : renamed FindMembers() to FindMethodBase(). For interfaces,
1954 no need to check overrides. For classes, omit those results from
1955 interfaces since they must exist in the class. Fixed bug #76726.
1957 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
1959 * typemanager.cs : (GetFullNameSignature) differentiate indexers
1960 with different parameters. Fixed the second problem in #76685.
1962 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
1964 * doc.cs : (FindDocumentedMember) pass invocation_type as well (to
1965 get expected 'protected' access in CheckValidFamilyAccess()).
1968 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
1970 * doc.cs : (GenerateTypeDocComment) Fields could be FixedField.
1971 Fixed bug #76705. CS1569 was incorrectly commented out.
1973 2005-11-23 Martin Baulig <martin@ximian.com>
1975 * generic.cs (Constraints.Define): Removed.
1976 (TypeParameter.DefineConstraints): Removed.
1977 (TypeParameter.DefineType): Call SetGenericParameterAttributes()
1978 on the GenericTypeParameterBuilder here.
1980 2005-11-23 Martin Baulig <martin@ximian.com>
1982 * typemanager.cs (TypeManager.GetProperty): Make this public.
1984 * generic.cs (Nullable.NullableInfo.ctor): Use
1985 TypeManager.GetProperty() rather than using reflection directly.
1987 2005-11-17 Martin Baulig <martin@ximian.com>
1989 * expression.cs (Indexers.GetIndexersForType): Added support for
1990 generic parameters; fixes #76587.
1992 2005-11-17 Martin Baulig <martin@ximian.com>
1995 (CaptureContext.EmitMethodHostInstance): Use `Ldarg_0' if we
1996 inherit the scope from our parent. Fixes #76653.
1998 2005-11-15 Martin Baulig <martin@ximian.com>
2000 * anonymous.cs (ScopeInfo.ScopeType): New public field; use this
2001 instead of `ScopeTypeBuilder' to refer to the "current" type.
2002 (AnonymousMethod.CreateScopeType): Correctly create the helper
2003 class if we're inside a generic type definition.
2005 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
2007 * doc.cs : use Invocation.IsOverride() to do real override check.
2008 * expression.cs : made Invocation.IsOverride() internal.
2010 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
2012 * doc.cs : use TypeManager.FindMembers() instead of (possible)
2013 TypeBuilder.FindMembers() and filter overriden base members out.
2016 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
2018 * doc.cs : ref/out parameters are represented as '@' (instead of
2019 '&' in type FullName). Fixed bug #76630 (additionally crefs).
2021 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
2023 * doc.cs : when there was no '.' in cref to methods in doc comment,
2024 then parameters were missing in the output. Fixed bug #76691.
2026 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
2028 * driver.cs : don't output docs when there is an error.
2031 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
2034 Now it should detect indexers. Fixed primary concern in bug #76685.
2035 Fixed CS0419 message to not show the identical member signature in
2038 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
2040 * doc.cs : (FindDocumentedMember) use TypeManager.MemberLookup()
2041 instead of Type.FindMembers() since it does not handle events.
2044 2005-11-12 Gert Driesen <drieseng@users.sourceforge.net>
2046 * codegen.cs: Fixed typo (speficied -> specified).
2048 2005-11-11 Marek Safar <marek.safar@seznam.cz>
2051 * doc.cs (FindDocumentedTypeNonArray): Don't resolve again.
2053 2005-11-11 Marek Safar <marek.safar@seznam.cz>
2055 * attribute.cs: Changed error message.
2057 * cs-tokenizer.cs: One more check.
2059 2005-11-10 Marek Safar <marek.safar@seznam.cz>
2061 * statement.cs (Block.Resolve): Ignore empty statement.
2063 2005-11-10 Marek Safar <marek.safar@seznam.cz>
2065 * report.cs: Made error/warning methods more strict to avoid
2068 * anonymous.cs, attribute.cs, class.cs, codegen.cs, constant.cs,
2069 convert.cs, cs-parser.jay, cs-tokenizer.cs, decl.cs, delegate.cs,
2070 doc.cs, driver.cs, ecore.cs, expression.cs, location.cs,
2071 namespace.cs, parameter.cs, statement.cs, typemanager.cs: Updated.
2073 2005-11-11 Carlos Alberto Cortez <calberto.cortez@gmail.com>
2075 * codegen.cs (AssemblyClass.CheckInternalsVisibleAttribute):
2076 Use the more explicit AssemblyName.FullName instead of
2077 AssemblyName.Name to report errors.
2079 2005-11-11 Marek Safar <marek.safar@seznam.cz>
2081 * attribute.cs, class.cs, cs-tokenizer.cs, parameter.cs: Sync
2084 2005-11-10 Marek Safar <marek.safar@seznam.cz>
2094 * report.cs: Fixed error reporting and typos.
2096 * generic.cs (TypeParameter.GetSignatureForError): New method.
2097 (ConstructedType.GetSignatureForError): Instead of DeclarationName.
2099 * typemanager.cs (GetFullName): Refactored.
2101 2005-11-08 Marek Safar <marek.safar@seznam.cz>
2103 * attribute.cs (Attribute.GetCoClassAttributeValue): New method.
2104 (AttributeTester.GetCoClassAttribute): Get CoClassAttribute.
2106 * class.cs (TypeContainer.IsComImport): New property.
2107 (Constructor.Define): Create proper ctor for ComImport types.
2109 * expression.cs (New.CheckComImport): Fixed.
2111 2005-11-07 Miguel de Icaza <miguel@novell.com>
2113 * anonymous.cs (CaptureContext.AddParameterToContext): The fact
2114 that a parameter has been captured does not mean that we do not
2115 have to do the rest of the processing. This fixes the second part
2116 of #76592. If there was another anonymous method capturing
2117 values in the past, the Scope would never be set for the second
2118 method that captured the same parameter.
2120 (CaptureContext.EmitAssignParameter): When `leave_copy' is passed,
2121 properly manipulate the stack. Second part of fix for #76592.
2123 * expression.cs (New): Add support for invoking "new" on
2124 interfaces that have been flagged with the ComImport attribute and
2125 the CoClass. Fixes #76637
2127 * statement.cs (Try.DoEmit): When a variable is captured, do not
2128 try to emit the vi.LocalBuilder variable as it has been captured.
2129 Create a temporary variable and store the results on the
2130 FieldBuilder. Fixes #76642
2132 2005-11-07 Marek Safar <marek.safar@seznam.cz>
2134 * class.cs (CheckPairedOperators): Made compilable with csc 2.0.
2136 * ecore.cs (InstanceResolve): Fixed CS1540 detection.
2138 * expression.cs (Binary.DoResolve): Added && optimalization.
2140 * typemanager.cs (AddUserType): Removed useless argument.
2142 2005-11-04 Marek Safar <marek.safar@seznam.cz>
2144 * statement.cs (Block.variables): Uses ListDictionary.
2146 2005-11-03 Marek Safar <marek.safar@seznam.cz>
2149 * class.cs (PartialContainer.EmitType): Customized to emit
2150 security attributes.
2151 (ClassPart.ApplyAttributeBuilder): Transform security attribute
2152 for partial classes.
2154 2005-11-03 Marek Safar <marek.safar@seznam.cz>
2157 * expression.cs (ElementAccess.DoResolveLValue): Fixed buffer
2158 access has to be fixed.
2160 * typemanager.cs (IsUnmanagedType): Wrong common field type.
2162 2005-11-01 Marek Safar <marek.safar@seznam.cz>
2165 * ecore.cs (NullCast.Reduce): Implemented.
2167 * expression.cs (ArrayCreation.CheckIndices): Correcly check
2170 * statement.cs (SwitchLabel.ResolveAndReduce): Catch null
2172 (Foreach.Resolve): Catch null properly.
2174 2005-10-29 Marek Safar <marek.safar@seznam.cz>
2176 * cs-tokenizer.cs: Warning text fix.
2178 * driver.cs: AllWarningNumbers exposed on public interface.
2180 * report.cs (): Reviewed warning numbers.
2181 (IsValidWarning): Use binary search.
2183 2005-10-29 Marek Safar <marek.safar@seznam.cz>
2185 * driver.cs: Implemeted resource visibility.
2186 (Resources): New class for code sharing between /res: and
2189 2005-11-07 Marek Safar <marek.safar@seznam.cz>
2191 decl.cs (CurrentTypeParameters): Fixed to be public.
2193 2005-11-07 Marek Safar <marek.safar@seznam.cz>
2195 generic.cs, rootcontext.cs: Removed NewConstraintAttribute.
2197 2005-11-07 Marek Safar <marek.safar@seznam.cz>
2199 gmcs.exe.sources: Use CryptoConvert.cs from corlib.
2201 2005-11-05 Kornél Pál <kornelpal@hotmail.com>
2203 * gmcs.exe.config: Updated runtime version to v2.0.50727 (2.0 RTM).
2205 2005-11-04 Carlos Alberto Cortez <calberto.cortez@gmail.com>
2207 Add friend assembly access support.
2208 * typemanager.cs: assembly_internals_vis_attrs
2209 cache for friend assembly access.
2210 (TypeManager.IsFriendAssembly): New method for
2211 checking friend assembly access.
2212 (TypeManager.Error_FriendAccessNameNotMatching): New
2214 (TypeManager.CompareKeyTokens): Likewise.
2215 (TypeManager.Filter): Handle friend accessible
2218 * namespace.cs (RootNamespace.GetTypeInAssembly): Return
2219 friend accessible types.
2221 * ecore.cs (Expression.IsAccessorAccessible): Handle
2222 friend accessible properties.
2224 * decl.cs (DeclSpace.CheckAccessLevel): Handle friend
2227 2005-10-28 Marek Safar <marek.safar@seznam.cz>
2230 * cfold.cs (ConstantFold.BinaryFold): Implemented null cast
2233 * convert (Convert.ImplicitReferenceConversion): NullCast holds
2236 * ecore.cs (NullCast): Child is contant only.
2238 * literal.cs (NullLiteral.Reduce): null can be converted to any
2241 2005-10-28 Kornél Pál <kornelpal@hotmail.com>
2243 * driver.cs: Use Encoding.Default as default code page instead
2246 2005-10-27 Raja R Harinath <rharinath@novell.com>
2249 * expression.cs (Invocation.Error_InvalidArguments): Handle
2250 __arglist parameters.
2251 (Invocation.VerifyArgumentsCompat): Likewise.
2252 * support.cs (ReflectionParameters.GetSignatureForError): Print
2253 __arglist parameters.
2254 (InternalParamters.GetSignatureForError): Likewise.
2255 * parameter.cs (Parameters.GetSignatureForError): Likewise.
2257 2005-10-26 Marek Safar <marek.safar@seznam.cz>
2259 * attribute.cs (GetPropertyValue): Made public.
2261 * codegen.cs (AssemblyClass): ResolveClsCompliance renamed to
2263 Add new property WrapNonExceptionThrows to handle 2.0 assembly
2265 (AssemblyClass.Emit): Emit RuntimeCompatibilityAttribute when it
2268 * driver.cs: Reflect method name change.
2270 * statement.cs (Try.Resolve): Warn when try has both general
2273 * typemanager.cs: runtime_compatibility_attr_type new predefined
2276 2005-10-26 Raja R Harinath <harinath@gmail.com>
2279 * pending.cs (InterfaceMethod): Allow tm.args [i] to be null --
2280 treat it as an empty parameter list.
2282 2005-10-26 Raja R Harinath <rharinath@novell.com>
2285 * ecore.cs (SimpleName.DoSimpleNameResolve): Make fall-back
2286 ResolveAsTypeStep silent.
2287 * statement.cs (Block.AddConstant): Mark block as used.
2288 (Block.ResolveMeta): Avoid piling on error messages
2289 if a constant initializer resolution fails.
2291 2005-10-25 Raja R Harinath <rharinath@novell.com>
2293 * namespace.cs (RootNamespace.VerifyUsingForAll, Namespace.VerifyUsing):
2295 (NamespaceEntry.VerifyAllUsing): New.
2296 (NamespaceEntry.AliasEntry.Resolve): New. Handles common error
2297 behaviour. Delegates actual resolution of alias to ...
2298 (NamespaceEntry.DoResolve): ... this. Renamed from Resolve.
2299 (NamespaceEntry.LocalAliasEntry, NamespaceEntry.ExternAliasEntry):
2301 * driver.cs (Driver.MainDriver): Update.
2303 * namespace.cs (NamespaceEntry.DefineNamespace): Remove.
2304 (NamespaceEntry.SymbolFileID): Make into a on-demand computed
2306 (Namespace.DefineNamespaces, RootNamespace.DefineNamespacesForAll):
2308 * symbolwriter.cs (SymbolWriter.Initialize): Don't call
2309 RootNamespace.DefineNamespacesForAll.
2311 2005-10-24 Raja R Harinath <harinath@gmail.com>
2313 * typemanager.cs (assemblies, external_aliases, modules)
2314 (AddAssembly, AddExternAlias, AddModule GetAssemblies, Modules)
2315 (ComputeNamespaces, GetRootNamespace): Remove extra staging
2316 overhead. Move resposibility ...
2317 * namespace.cs (GlobalRootNamespace): ... here. Update to changes.
2318 * driver.cs, attribute.cs, codegen.cs: Update to changes.
2320 2005-10-23 Raja R Harinath <harinath@gmail.com>
2322 * namespace.cs (RootNamespace.all_namespaces): Renamed from
2323 cached_namespaces. Improve usage.
2324 (RootNamespace.Reset, RootNamespace.RegisterNamespace)
2325 (RootNamespace.VerifyUsingForAll, RootNamespace.DefineNamespacesForAll):
2326 Move from GlobalRootNamespace and simplify.
2327 (RootNamespace.Global): Make instance variable.
2328 (RootNamespace.RootNamespace): Add "alias name" parameter.
2329 (GlobalRootNamespace): Simplify drastically.
2330 (Namespace.Lookup): Don't use GetNamespace.
2331 * typemanager.cs (GetRootNamespace): Rename from
2332 ComputeNamespaceForAlias.
2333 (NamespaceClash): Use Global.IsNamespace instead of GetNamespace.
2335 2005-10-23 Marek Safar <marek.safar@seznam.cz>
2337 * anonymous.cs (AnonymousContainer): Don't crash when container
2340 2005-10-23 Marek Safar <marek.safar@seznam.cz>
2342 * expression.cs (Binary.DoResolve): Warn when comparing same
2345 2005-10-23 Marek Safar <marek.safar@seznam.cz>
2348 * expression.cs (Binary.DoResolve): It looks like there are no
2349 convetsion rules in enum context.
2351 2005-10-19 Carlos Alberto Cortez <calberto.cortez@gmail.com>
2353 Add support for extern alias qualifiers.
2354 * typemanager.cs: Move some LookupTypeReflection code
2355 to namespace.cs, to have cleaner code. Added some methods
2356 to help us keep track of the extern aliased references.
2357 * driver.cs: Add suport for extern alias assemblies on command
2358 line and check for their warnings/errors. Also keep track of the
2359 extern aliased assemblies.
2360 * namespace.cs: Move the global functionality of Namespace
2361 to GlobalRootNamespace/RootNamespace. Now the global namespace
2362 is GlobalRootNamespace.Globa. Also the code moved from
2363 typemanager.cs lives in GlobalRootNames.cs/RootNamespace.cs.
2364 Finally added LocalAliasEntry (AliasEntry before) and
2365 ExternAliasEntry, to handle alias statements.
2366 * cs-parser.jay: Add support in the grammar for extern alias
2368 * doc.cs, delegate.cs, expression.cs ecore.cs, symbolwriter.cs:
2369 Update callings to Namespace (now in GlobalRootNamespace).
2371 2005-10-25 Martin Baulig <martin@ximian.com>
2373 * convert.cs (ImplicitTypeParameterConversion): Make base
2374 interfaces actually work; fixes #76557.
2376 2005-10-25 Martin Baulig <martin@ximian.com>
2379 (GenericMethod.Define): Call TypeParameter.DefineConstraints() on
2380 all the type parameters; fixes #76551.
2382 2005-10-25 Martin Baulig <martin@ximian.com>
2387 (GenericMethod.ctor): Added `Expression return_type' and
2388 `Parameters parameters' arguments.
2389 (GenericMethod.DefineType): Call ResolveAsTypeTerminal() on the
2390 parameter and return types to check their constraints if they're
2393 * codegen.cs (EmitContext.ResolvingGenericMethod): New public
2396 * ecore.cs (Expression.ResolveAsTypeTerminal): Don't check the
2397 constraints of a generic type if `ec.ResolvingGenericMethod'.
2399 * class.cs (MethodCore.DoDefineParameters): Set
2400 `ec.ResolvingGenericMethod' if we're a generic method.
2401 (MemberBase.MemberType): Likewise.
2403 2005-10-25 Carlos Alberto Cortez <calberto.cortez@gmail.com>
2405 * typemanager.cs (TypeManager): Added
2406 TypeManager.internals_visible_attr_type to cache
2407 S.R.CompilerServices.InternalsVisibleToAttribute.
2409 * codegen.cs (AssemblyClass): Added checks for
2410 InternalsVisibleToAttribute in new method
2411 CheckInternalsVisibleAttribute () and also cache the
2412 AssemblyName in AssemblyClass.Name.
2414 2005-10-24 Martin Baulig <martin@ximian.com>
2417 (TypeManager.ExpandInterfaces): Added overloaded version which
2418 just takes a `Type[]' array.
2421 (Constraints.Resolve): Don't expand the interfaces here; ie. we
2422 just use the interfaces which were explicitly specified and not
2423 the interfaces they inherit. Fixes #76482.
2424 (TypeParameter.FindMembers): Expand the interfaces here.
2426 2005-10-21 Martin Baulig <martin@ximian.com>
2429 (Constraints.Resolve): Also resolve the actual types here.
2430 (Constraints.ResolveTypes): Just check the constraints here.
2431 Fixes #76363; see gtest-218.cs.
2433 2005-10-21 Martin Baulig <martin@ximian.com>
2436 (Convert.ImplicitTypeParameterConversion): Use a `ClassCast'
2437 instead of a `BoxedCast'; fixes gtest-217.cs.
2439 2005-10-20 Atsushi Enomoto <atsushi@ximian.com>
2441 * generic.cs : (ConstructedType.CheckConstraints) warn CS0310 when
2442 1) "new()" is specified as generic parameter constraint and 2) the
2443 type is TypeBuilder and 3) the type is abstract even if it has a
2444 default .ctor(). Now errors/gcs0310-3.cs is correctly rejected.
2446 2005-10-20 Martin Baulig <martin@ximian.com>
2449 (GenericConstraints.TypeParameter): New public property.
2450 (TypeParameter.ctor): Also take a `DeclSpace' argument.
2451 (TypeParameter.DeclSpace): New public property.
2452 (TypeParameter.DefineType): Inflate the constraints if our
2453 `DeclSpace' is an `Iterator'.
2455 2005-10-19 Atsushi Enomoto <atsushi@ximian.com>
2457 * class.cs, decl.cs : (MemberCache.FindMemberToOverride) added
2458 GenericMethod argument to compare methods' generic type arguments.
2461 2005-10-19 Martin Baulig <martin@ximian.com>
2463 * class.cs (TypeContainer.DefineType): Only use ResolveAsTypeStep(),
2464 not ResolveType() when resolving the base type, so we're not
2465 checking the constraints here.
2466 (TypeContainer.ResolveType): Call ResolveType() on our base_type
2469 2005-10-19 Martin Baulig <martin@ximian.com>
2471 * generic.cs (ConstructedType.CheckConstraints): Committing
2472 untested fix for #76441.
2474 2005-10-18 Raja R Harinath <rharinath@novell.com>
2477 * class.cs (TypeContainer.DefineType): Move updating of
2478 topological sort earlier in the code.
2479 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Don't use TypeBuilder.
2481 2005-10-18 Marek Safar <marek.safar@seznam.cz>
2484 * cfold.cs (BinaryFold): Reduce constant in enum conversion.
2486 * constant.cs (Constant.TryReduce): Moved from Cast class.
2487 (Reduce): Made little bit more OO and fixed missing conversions.
2489 * ecore.cs (Reduce): Implemented.
2490 (Binary.EnumLiftUp): New method to upgrade values to enum values.
2492 * literal.cs (Reduce): Implemented.
2494 * class.cs: Reverted Miguel's wrong commit.
2496 2005-10-14 Miguel de Icaza <miguel@novell.com>
2498 * ecore.cs (GetMemberType): Report the correct mapping for the MemberCore
2500 2005-10-14 Atsushi Enomoto <atsushi@ximian.com>
2502 * cs-parser.jay, expression.cs : CS0214 was missing error location
2503 for constants. Fixed bug #76404.
2505 2005-10-10 Raja R Harinath <rharinath@novell.com>
2507 * ecore.cs (PropertyExpr.Emit): Use Invocation.EmitCall to emit
2509 (PropertyExpr.EmitCall): Likewise.
2510 * expression.cs (Invocation.EmitArguments): Handle case where
2512 (Invocation.EmitCall): Avoid allocating temporary variable if
2513 there are no arguments.
2515 2005-10-11 Marek Safar <marek.safar@seznam.cz>
2518 * convert.cs (ExplicitConversionCore): Fixed object->enum
2521 2005-10-07 Raja R Harinath <rharinath@novell.com>
2524 * convert.cs (ImplicitConversionStandard): Move conversion of
2525 void* to arbitrary pointer types ...
2526 (ExplicitConversionStandard): .. here.
2527 * ecore.cs (Expression.Error_ValueCannotBeConverted): Fix CS0266
2528 error to always print typenames.
2530 2005-10-07 Raja R Harinath <rharinath@novell.com>
2532 * convert.cs (GetConversionOperator): Rename from
2533 GetConversionOperators. Move operator selection code from ...
2534 (UserDefinedConversion): ... here.
2536 2005-10-06 Marek Safar <marek.safar@seznam.cz>
2538 * convert.cs (ExplicitConversionCore): Removed duplicate enum
2541 2005-10-05 Marek Safar <marek.safar@seznam.cz>
2543 * assign.cs (Assign.DoResolve): Error method changed.
2545 * cfold.cs (DoConstantNumericPromotions): Error method changed.
2547 * const.cs (ResolveValue): Reset in_transit immediately.
2549 * constant.cs: Error method changed.
2551 * convert.cs: Removed useless location parameter.
2552 (ExplicitNumericConversion): Don't do double enum check.
2553 (ExplicitConversionCore): Renamed from ExplicitConversion.
2554 (ExplicitUnsafe): Extracted from ExplicitConversion.
2555 (ExplicitConversion): Uses for error reporting.
2557 * ecore.cs (Error_ValueCannotBeConverted): More logic for more
2559 (ResolveBoolean): Uses common error method.
2560 (CastToDecimal): Get rid of ec.
2561 (CastFromDecimal): Optimized.
2562 (ConvCast): Get rid of ec.
2564 * enum.cs (ResolveValue): Reset in_transit immediately.
2565 (Emit): Return after first error.
2567 * expression.cs: Convert changes.
2569 * literal.cs: Error method changed.
2571 * statement.cs: Error method changed.
2573 2005-10-06 Raja R Harinath <rharinath@novell.com>
2575 Fix gtest-131.cs and gtest-211.cs.
2576 * generic.cs (Nullable.LiftedBinaryOperator.EmitEquality):
2577 Only emit code for a label if it is used. Unreachable code can
2578 violate ECMA evaluation stack invariants.
2580 2005-09-27 Marek Safar <marek.safar@seznam.cz>
2582 * anonymous.cs: Implemented ExprClassName.
2584 * assign.cs (Assign.DoResolve): Don't chrash when type is not
2587 * attribute.cs (ResolveArguments): Enabled MethodImplOptions
2590 * class.cs (StaticClass.DefineContainerMembers): Report protected
2593 * codegen.cs: if(ed) PRODUCTION.
2595 * convert.cs (Error_CannotImplicitConversion): Better error
2598 * cs-parser.jay: More error checks.
2600 * cs-tokenizer.cs (consume_identifier): Fixed Miguel's revert.
2602 * driver.cs (CSCParseOption): Enabled wrong option check.
2604 * ecore.cs (Expression.ExprClassName): Turned to property.
2605 (MemberExpr.CheckIntermediateModification): For checking boxed
2606 value types modification.
2608 * statement.cs (Fixed.Resolve): Expression type must be
2609 convertible to fixed type.
2610 (CollectionForeach.GetEnumeratorFilter,TryType):
2611 Small refactoring for easier error checking.
2613 2005-09-26 Marek Safar <marek.safar@seznam.cz>
2615 * attribute.cs (Attribute.Resolve): Check Obsolete attribute for
2618 * class.cs (GeneratedBaseInitializer): New class for customization
2619 compiler generated initializers.
2620 (MemberBase.DoDefine): Check Obsolete attribute here.
2621 (FieldMember.DoDefine): Ditto.
2623 * const.cs (ExternalConstant.CreateDecimal): Builder for decimal
2626 * decl.cs (MemberCore.EmitContext): Returns valid current ec.
2627 (MemberCore.GetObsoleteAttribute): Removed argument.
2628 (MemberCore.CheckObsoleteness): Obsolete attributes are hierarchic.
2629 (MemberCore.CheckObsoleteType): New helper.
2633 * statement.cs: Updates after MemberCore changes.
2635 * ecore.cs (TypeExpr.ResolveType): Check type obsoleteness here.
2636 (FieldExpr.ResolveMemberAccess): Fixed decimal constants checks.
2638 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't check
2639 obsolete attribute for compiler construct.
2640 (As.DoResolve): Cache result.
2642 * iterators.cs (Define_Constructor): Use GeneratedBaseInitializer.
2644 2005-10-01 Miguel de Icaza <miguel@novell.com>
2646 * expression.cs (Probe): instead of having a "Type probe_type"
2647 keep the extra information as a TypeExpr probe_type_expr since the
2648 "As" operator needs to perform some type checks.
2650 * (As.DoResolve): If the type is a type parameter, ensure that it
2651 is constrained by a class.
2653 2005-09-22 Miguel de Icaza <miguel@novell.com>
2655 * statement.cs (Lock): Use the TemporaryVariable class instead of
2656 manually using local variables as those do not work when variables
2659 * ecore.cs: Moved the TemporaryVariable class from being a nested
2660 class inside Foreach to be a public class that can be employed in
2663 2005-09-19 Marek Safar <marek.safar@seznam.cz>
2665 * cs-parser.jay: interface_accessors replaced by
2666 accessor_declarations.
2668 * ecore.cs, literal.cs, statement.cs: NullLiteral holds null
2671 * statement.cs (GotoCase.Resolve): Convert null constant to
2673 (SwitchLabel.ResolveAndReduce): Ditto.
2674 (SwitchLabel.NullStringCase): Custom null stamp.
2675 (Switch.SimpleSwitchEmit): Fix from NullLiteral to NullStringCase.
2677 typemanager.cs (CSharpSignature): Don't skip first argument
2680 2005-09-16 Marek Safar <marek.safar@seznam.cz>
2682 * cfold.cs, constant.cs, convert.cs, ecore.cs,
2683 expression.cs, iterators.cs, literal.cs: Store constants and
2686 * class.cs (MemberBase.ShortName): Pass location.
2688 * cs-parser.jay: Some location fixes.
2690 * ecore.cs (Expression.Location): Made virtual.
2692 2005-09-27 Marek Safar <marek.safar@seznam.cz>
2695 * const.cs (Const.ResolveValue): Check for assigning non-null
2696 value to reference type.
2698 2005-09-26 Raja R Harinath <rharinath@novell.com>
2701 * expression.cs (This.VerifyFixed): In a value type T, the type of
2702 'this' is T&, iow, 'this' is either an out or ref parameter. In a
2703 value type R, 'this' is treated as a value parameter.
2705 2005-09-05 Miguel de Icaza <miguel@novell.com>
2707 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
2708 if the underlying types are the same, otherwise we need to produce
2709 code that will do the proper cast.
2711 This was exposed by Marek's constant rewrite which produced
2712 invalid code for the call site:
2715 void Method (X v) {}
2719 This fixes test-49.cs
2721 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
2723 * attribute.cs : (Attribute.IsValidArgumentType): array of string/
2724 Type/Object should be allowed as well. Fixed bug #75968.
2726 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
2728 * expression.cs : (Binary.DoResolve): when one is enum constant and
2729 another is constant 0, then return enum one *as enum type*.
2732 2005-10-04 Martin Baulig <martin@ximian.com>
2734 * ecore.cs (PropertyExpr.ResolveAccessors): Cosmetic fix; make the
2735 `SetMemberIsUsed()' work for generics, too.
2737 2005-10-04 Martin Baulig <martin@ximian.com>
2739 * expression.cs (DelegateInvocation.EmitStatement): Make this work
2740 for corlib. Fixes #75691.
2742 2005-09-28 Marek Safar <marek.safar@seznam.cz>
2745 * driver.cs: Fix compilation files with full root path.
2747 2005-09-25 Miguel de Icaza <miguel@novell.com>
2749 * report.cs (SymbolRelatedToPreviousError): Format the output so
2750 it does not use an open parenthesis that is never closed.
2752 * driver.cs: Follow coding guidelines
2754 2005-09-18 Miguel de Icaza <miguel@novell.com>
2756 * driver.cs: Set InEmacs based on the environment variable EMACS.
2758 * location.cs (InEmacs): in this mode, do not report column
2759 location as it confuses Emacs.
2761 2005-10-03 Raja R Harinath <rharinath@novell.com>
2763 * support.cs (SeekableStreamReader.Position): Don't error out when
2764 the requested position is just beyond the end of the current
2767 2005-09-28 Raja R Harinath <rharinath@novell.com>
2769 * support.cs (SeekableStreamReader): Simplify drastically. Don't
2770 try to keep in sync with the byte count of the underlying Stream.
2771 However, this limits us to a window size of 2048 characters: i.e.,
2772 the maximum lookahead of our lexer/parser can be 2048 characters.
2774 2005-09-22 Martin Baulig <martin@ximian.com>
2776 * driver.cs: Removed a debugging FIXME.
2778 2005-09-21 Raja R Harinath <rharinath@novell.com>
2780 * cs-parser.jay (type_arguments): Add CS1644 check.
2781 * decl.cs (DeclSpace.AddToContainer): Restore CS0694 check.
2783 2005-09-15 Raja R Harinath <rharinath@novell.com>
2785 * Makefile (PROGRAM): Make profile specific.
2786 (gmcs.exe) [PROFILE=net_2_0]: Add utility rule to copy gmcs.exe to
2787 the current directory.
2790 * expression.cs (Invocation.EmitCall): Remove optimization on
2791 this_call since it doesn't handle 'this' being a value type.
2793 2005-09-05 Geoff Norton <gnorton@customerdna.com>
2795 * driver.cs: Ensure file handles are closed after parsing
2797 2005-09-05 Miguel de Icaza <miguel@novell.com>
2799 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
2800 if the underlying types are the same, otherwise we need to produce
2801 code that will do the proper cast.
2803 This was exposed by Marek's constant rewrite which produced
2804 invalid code for the call site:
2807 void Method (X v) {}
2811 This fixes test-49.cs
2813 2005-09-05 Martin Baulig <martin@ximian.com>
2815 * expression.cs (As.DoResolve): Use `probe_type.IsValueType'
2816 instead of `TypeManager.IsValueType (probe_type)'; fixes #75668.
2818 * cs-parser.jay (delegate_declaration): Small fix for #75852.
2820 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
2822 * typemanager.cs: (IsUnmanagedType) : generic parameter is not allowed
2823 to be a pointer type due to the spec 25.2, so check if declaring
2824 type is generic type definition. Fixed bug #75772.
2826 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
2829 * generic.cs : (TypeManager.IsEqual(Type,Type)): it should work when
2830 both types are not defined by methods.
2831 * expression.cs : (Invocation.IsApplicable): it should work when
2832 the argument type is equal to the parameter type, not only when
2833 ImplicitConversionExists() returns true.
2835 2005-09-02 Raja R Harinath <rharinath@novell.com>
2837 * attribute.cs (GetMarshal): Work even if "DefineCustom" is
2841 * ecore.cs (SimpleNameResolve.DoSimpleNameResolve): Disable
2842 flow-branching for LocalVariableReferences in case we were invoked
2843 from a MemberAccess.
2844 * expression.cs (LocalVariableReference.VerifyAssigned): New.
2846 (LocalVariableReference.DoResolveBase): ... this.
2847 (MemberAccess.Resolve): Do the check that was disabled during
2850 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
2853 (PartialContainer.Create): check abstract/sealed/static strictly
2854 but abstract/sealed can exist only at one side. Fixed bug #75883.
2856 2005-09-01 Kornél Pál <kornelpal@hotmail.com>
2859 * attribute.cs (Attribute.GetMarshal): If ArraySubType is not
2860 specified, don't default to UnmanagedType.I4.
2862 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
2864 * expression.cs : conditional operator should check possibly
2865 incorrect assign expression. Fixed bug #75946.
2867 2005-08-30 Raja R Harinath <rharinath@novell.com>
2870 * anonymous.cs (ScopeInfo.MakeFieldName): New helper.
2871 (ScopeInfo.EmitScopeType): Use it to construct field names from
2872 names of captured locals.
2875 * ecore.cs (BoxedCast.BoxedCast) [1-argument variant]: Remove.
2876 * convert.cs (ImplicitReferenceConversion, TryImplicitIntConversion):
2877 Pass 'target_type' to BoxedCast. Don't default to 'object'.
2878 (ExplicitConversion): Remove enum cases already handled by
2879 implicit conversion. Move implicit conversion check to the beginning.
2880 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Update.
2881 * expression.cs (ArrayCreation.EmitDynamicInitializers):
2882 Don't treat System.Enum as a struct.
2884 2005-08-30 Jb Evain <jbevain@gmail.com>
2886 * attribute.cs: handles as expression in parameters.
2888 2005-08-30 Raja R Harinath <rharinath@novell.com>
2891 * class.cs (TypeContainer.VerifyClsName): Don't use a
2892 PartialContainer when verifying CLS compliance.
2893 (AbstractPropertyEventMethod): Set Parent here, ...
2894 (PropertyMethod): ... not here.
2896 2005-08-30 Atsushi Enomoto <atsushi@ximian.com>
2898 * attribute.cs : escaped attribute name should not be allowed to be
2899 resolved (e.g. @class as classAttribute). Fixed bug #75930.
2901 2005-08-29 Raja R Harinath <rharinath@novell.com>
2904 * convert.cs (ImplicitStandardConversionExists): Allow zero also
2905 when converting a long constant to unsigned long.
2906 * expression.cs (Invocation.OverloadResolve): Add sanity check to
2907 detect where IsApplicable and VerifyArgumentsCompat disagree.
2909 2005-08-29 Raja R Harinath <rharinath@novell.com>
2910 and Carlos Alberto Cortez <carlos@unixmexico.org>
2913 * class.cs (TypeContainer.CanElideInitializer): New helper.
2914 (TypeContainer.EmitFieldInitializers): Use it to determine if we
2915 can safely emitting the initializer of a field.
2917 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
2919 * statement.cs : (Continue.Resolve()) Unlike break, continue is not
2920 allowed inside a switch (without loop). Fixed bug #75433.
2922 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
2924 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
2925 * mcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
2927 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
2929 * driver.cs : kinda reverting the default encoding changes (not exact
2930 revert since I noticed that "codepage:reset" might not work fine).
2932 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
2934 * class.cs : (AbstractPropertyEventMethod) SetupName() now takes
2935 Location. Now getter and setter store location correctly.
2936 (errors/cs0111-12.cs now reports the expected location.)
2938 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
2940 * driver.cs : Use default encoding on the environment.
2941 Removed (now that) extra parameter for SeekableStreamReader.
2942 * support.cs : (SeekableStreamReader) third .ctor() argument for
2943 StreamReader is not required (always true). preamble size could
2944 be acquired in simpler and safe way.
2946 2005-08-24 Atsushi Enomoto <atsushi@ximian.com>
2948 * cs-parser.jay: report CS0642 at warning level 3
2949 and report CS0642 for an if else statement also
2950 fixes bug #74745. Patch by John Luke (and a bit
2952 Removed extra CS0642 warning check for "while",
2954 * statement.cs: In Block.Resolve(), CS0642 check
2955 is reimplemented to check a sequence of an empty
2956 statement and a block.
2958 Both fix bug #66777.
2960 2005-08-24 Marek Safar <marek.safar@seznam.cz>
2962 * attribute.cs (GetMethodObsoleteAttribute): Disabled obsolete properties
2963 detection until I fix it.
2965 * cs-tokenizer.cs: Changed error message.
2967 * cs-parser.jay: Fixed 2 error locations.
2969 * ecore.cs (Error_TypeDoesNotContainDefinition): Share error message.
2970 (PropertyExpr.Error_PropertyNotFound): First attempt to detect non C#
2973 * enum.cs (GetSignatureForError): Fixed.
2975 * expression.cs (Invocation.IsSpecialMethodInvocation): Improved special
2979 * typemanager.cs (RegisterProperty): Removed.
2981 * statement.cs (CheckInvariantMeaningInBlock): Changed error message.
2983 2005-08-24 Raja R Harinath <rharinath@novell.com>
2986 * expression.cs (ArrayAccess.EmitLoadOpcode): Emit ldelem.i for pointers.
2987 (ArrayAccess.GetStoreOpcode): Return stelem.i for pointers.
2989 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
2991 * expression.cs : tiny fix is required for not warning positive ulong.
2994 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
2996 * expression.cs : add CS0652 check for constant and integral
2997 expression. Fixed bug #53974.
2999 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
3001 * expression.cs : in DoNumericPromotions(), check if there is implicit
3002 conversion overload for string (to check CS0034). Fixed bug #52492.
3004 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
3006 * cs-tokenizer.cs : Check newline in char constant. Fixed bug #75245.
3008 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
3010 * ecore.cs : report location when it is *not* Null.
3012 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
3018 Added OmitStructFlowAnalysis to EmitContext to handle CS0165 check
3019 correctly. Fixed bug #75721.
3021 2005-08-23 Raja R Harinath <rharinath@novell.com>
3023 * support.cs (SeekableStreamReader.Position): Avoid an expensive
3024 loop that performs 'min (pos, char_count)'.
3027 * expression.cs (Unary.ResolveOperator): Don't discard implicit
3028 converted value in Operator.OnesComplement.
3030 2005-08-22 Ben Maurer <bmaurer@ximian.com>
3032 * anonymous.cs: If the anon method is pulled into a helper class,
3033 it needs to be `internal' not `private'. Fixes runtime behavior on
3036 2005-08-17 Marek Safar <marek.safar@seznam.cz>
3039 * decl.cs (DeclSpace.VerifyClsCompliance): Skip when collision object
3042 2005-08-16 Marek Safar <marek.safar@seznam.cz>
3044 The big constants rewrite
3045 Fix #75746, #75685 and more
3046 As a side effect saved 1MB for MWF ;-)
3048 * attribute.cs (GetAttributeArgumentExpression): Use ToType, GetTypedValue.
3049 (GetMarshal, GetMethodImplOptions, GetLayoutKindValue): Values are not
3050 enum based for corlib compilation.
3052 * cfold.cs (BinaryFold): Convert operand for enum additions. Fixed enum
3055 * class.cs (FixedField.Define): Use ResolveAsConstant.
3057 * const.cs (IConstant): Interface constants and enums.
3058 (Const.ResolveValue): New method for constant resolvning.
3059 (ExternalConstant): Constants from imported assemblies.
3061 * constant.cs (Constant.GetTypedValue): Used to get constant with forced
3062 conversion; like enums.
3063 (Constant.ToType): Converts this constant to different type.
3064 (Constant.Increment): Adds 1.
3066 * convert.cs (ImplicitConversionRequired): Simplified.
3068 * cs-parser.jay: Create EnumMember directly.
3070 * decl.cs (MemberCore.CheckObsoleteness): Checks for ObsoleteAttribute presence.
3072 * doc.cs (GenerateEnumDocComment): Removed.
3074 * ecore.cs (Expression.ResolveAsConstant): New constant specific method.
3075 (ConvertIntLiteral): Removed.
3076 (FieldExpr.ResolveMemberAccess): Refactored to remove constant specific if(s).
3078 * enum.cs (EnumMember): Implement IConstant.
3079 (Enum.IsValidEnumConstant): Removed.
3080 (Enum.GetNextDefaultValue): Removed.
3081 (Enum.FindMembers): Updated.
3082 (Enum.GenerateDocComment): Iterate enum members.
3084 * expression.cs (Cast.TryReduce): Handle enums correctly.
3085 (New.Constantify): Made public.
3086 (MemberAccess.DoResolve): Removed contant specific if(s).
3088 * literal.cs (NullLiteral): Implement new abstract methods.
3090 * statement.cs (GotoCase.Resolve): Use new constant methods.
3091 (SwitchLabel.ResolveAndReduce): Use new constant methods.
3093 * typemanager.cs (LookupEnum): Removed.
3094 (IsEnumType): Fixed to work with corlib.
3095 (RegisterConstant): Removed.
3096 (LookupConstant): Removed.
3097 (GetConstant): Changed to work with IConstant.
3099 2005-08-04 Atsushi Enomoto <atsushi@ximian.com>
3101 * location.cs : Fixed overflown (>255) column number.
3103 2005-08-03 Raja R Harinath <rharinath@novell.com>
3105 First cut of the qualified-alias-member feature.
3106 * cs-tokenizer.cs (Tokenizer.is_punct): Recognize the double-colon
3108 * cs-parser.jay (DOUBLE_COLON): New token.
3109 (namespace_or_type_name): Add rule for recognizing
3110 qualified-alias-members.
3111 (primary_expression): Likewise.
3112 (element_access): Allow QualifiedAliasMember as a possible
3113 type-bearing expression.
3114 (local_variable_type, local_variable_pointer_type): Likewise.
3115 * namespace.cs (NamespaceEntry.LookupAlias): New. Looks up
3116 aliases in the current and enclosing namespace declarations.
3117 (NamespaceEntry.UsingAlias): Add CS0440 warning.
3118 * decl.cs (MemberName.is_double_colon): New.
3119 (MemberName.MemberName): Add new constructor for alias-member.
3120 (MemberName.GetTypeExpression): Generate QualifiedAliasMember too.
3121 * expression.cs (QualifiedAliasMember): New expression type.
3123 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
3125 * location.cs : it borked when no argument was specified.
3127 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
3129 * location.cs : tiny ToString() format fix.
3131 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
3133 * statement.cs : oops, it was missing.
3135 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
3137 A set of fixes for precise line/column location.
3140 "token" field now holds a file/line "delta", a line number offset
3141 from the segment, and a column number. See also:
3142 http://lists.ximian.com/pipermail/mono-devel-list/2004-
3143 December/009508.html
3144 Removed static IsNull. Use instance IsNull property instead.
3146 For some tokens it stores Location. For Identifier it stores
3147 LocatedToken which is a pair of string name and location.
3148 Column numbers are adjusted only at getChar().
3150 Use Location.ToString() for reporting (it now contains column).
3152 Largely modified to use LocatedToken instead of
3153 string (IDENTIFIER), and to acquire Location from some tokens.
3154 * namespace.cs, decl.cs, ecore.cs, class.cs, delegate.cs,
3155 iterators.cs, const.cs, anonymous.cs, tree.cs, enum.cs,
3157 Now MemberName holds Location. DeclSpace.ctor() receives Location
3158 as a parameter. Removed extra parameters to all derived classes.
3159 Replaced Location.IsNull() with instance property.
3160 * assign.cs, expression.cs :
3161 Added .ctor() overload that omits Location.
3163 Added "nameEscaped" flag that indicates the identifier was escaped
3164 in the source file. This fixes bug #57047.
3166 2005-09-02 Martin Baulig <martin@ximian.com>
3168 * class.cs: Make CS3005 a warning, not an error.
3170 2005-08-02 Marek Safar <marek.safar@seznam.cz>
3172 * attribute.cs (AttributeTester.GetImportedIgnoreCaseClsType):
3173 New method, looking for lo-case imported cls type.
3175 * decl.cs (DeclSpace.VerifyClsCompliance): Check CS3005 for types
3178 * driver.cs: Removed VerifyTopLevelNameClsCompliance usage.
3180 * enum (Enum.VerifyClsCompliance): Hardcode non-compliant types.
3182 * typemanager.cs (TypeManager.AllClsTopLevelTypes): Renamed from
3184 (TypeManager.LoadAllImportedTypes): Lo-case imported types.
3186 Optimized to save 3.5 MB for SWF compilation.
3188 2005-08-01 Marek Safar <marek.safar@seznam.cz>
3190 * class.cs (AddToTypeContainer): Use inheritance insted of if(s).
3191 (PartialContainer.Create): Moved logic AddToContainer.
3192 (PartialContainer.MarkForDuplicationCheck): Shares name.
3194 * decl.cs (DeclSpace.AddToContainer): Check name collisions at one
3197 * namespace.cs (Namespace.AddDeclSpace): Lazy declspaces
3199 (Namespace.GetSignatureForError): New method.
3201 * tree.cs (Tree.RecordDecl): Moved to AddToContainer.
3202 (RootTypes.AddToTypeContainer): se inheritance insted of if(s).
3204 2005-08-01 Raja R Harinath <rharinath@novell.com>
3207 * ecore.cs (Expression.MemberLookupFailed): Use queried_type for
3208 member lookup rather than qualifier_type, since qualifier_type can
3211 2005-08-01 Marek Safar <marek.safar@seznam.cz>
3213 * enum.cs (Enum.VerifyClsName): Fixed to allow not CLSCompliant
3216 2005-07-31 Miguel de Icaza <miguel@novell.com>
3218 * statement.cs: Copy the local exception into the exception
3219 captured local. Fixes 75674
3221 2005-07-31 Raja R Harinath <harinath@gmail.com>
3224 * expression.cs (Invocation.OverloadResolve): Don't report error
3225 CS1501 if error CS1502 has been reported.
3226 (New.DoResolve): Delegate CS1501 reporting to
3227 Invocation.OverloadResolve.
3230 * statement.cs (Block.CheckInvariantMeaningInBlock): Verify
3231 invariant-meaning-in-block property in an enclosing block if
3234 2005-07-29 Marek Safar <marek.safar@seznam.cz>
3236 * statement.cs (SwitchLabel.ResolveAndReduce): Refactored.
3237 (SwitchLabel.Erorr_AlreadyOccurs): Share error message.
3238 (Switch.CheckSwitch): Just save 50kb for SWF.
3240 2005-07-27 Martin Baulig <martin@ximian.com>
3242 * anonymous.cs (CaptureContext.AddField): Added
3243 `AnonymousContainer am' argument; compute its toplevel scope if
3244 it's not already computed. Fixes #75649.
3246 2005-07-26 Raja R Harinath <rharinath@novell.com>
3249 * class.cs (Constructor.Emit): Reset block to null if the block
3252 2005-07-25 Marek Safar <marek.safar@seznam.cz>
3254 * class.cs (TypeContainer.VerifyMembers): Be compatible in warning 169.
3256 2005-07-25 Marek Safar <marek.safar@seznam.cz>
3258 * class.cs (MethodData.Define): Check whether accessor implementing
3259 interface is public.
3261 * driver.cs (Driver.parse): Try to be smart and check for `MZ' header.
3263 2005-07-22 Marek Safar <marek.safar@seznam.cz>
3266 * namespace.cs (LookupType): Moved same type check to...
3268 * typemanager.cs (LookupTypeReflection): Don't allow to import more types
3271 2005-07-21 Raja R Harinath <rharinath@novell.com>
3273 * namespace.cs (NamespaceLookupType): Avoid a string allocation when we
3274 already found a typebuilder.
3275 * class.cs (MethodCore.IsDuplicateImplementation): Compare
3276 MemberNames, not strings.
3278 * const.cs (Error_ExpressionMustBeConst):
3279 Rename from Error_EpressionMustBeConst.
3280 * const.cs, class.cs, statement.cd: Update.
3282 2005-07-21 Marek Safar <marek.safar@seznam.cz>
3286 * const.cs (Const.LookupConstantValue): Report missing contant expression
3288 (Error_EpressionMustBeConstant): Only one error method.
3290 * class.cs, statement.c: Updated.
3292 2005-07-20 Raja R Harinath <rharinath@novell.com>
3294 * statement.cs (Block.Flags): Add back HasVarargs.
3295 (Block.flags): Make protected.
3296 (ToplevelBlock.HasVarargs): Convert to a property that updates flags.
3298 * typemanager.cs (types, typecontainers, user_types): Remove.
3299 (UserTypes, TypeContainers): Likewise.
3300 (HandleDuplicate, AddDelegateType, AddEnumType): Likewise.
3301 (CleanUp, Reset): Update.
3302 (AddUserType): Combine variants. Now, only updates builder_to_declspace.
3303 (GetNestedType): Use Type.GetNestedType.
3304 (CoreLookupType): Take two arguments, the namespace and the
3305 basename of the type. Update to use the Namespace.Lookup
3307 (InitEnumUnderlyingTypes, InitCoreTypes): Update.
3308 (RealMemberLookup): Use IsNestedChildOf instead of playing with
3309 string concatenation and substring matches.
3310 * class.cs, enum.cs, delegate.cs: Update to changes.
3312 2005-07-20 Marek Safar <marek.safar@seznam.cz>
3314 * constant.cs (Constant.Error_ConstantValueCannotBeConverted): Moved from
3315 Expression and made virtual.
3317 * convert.cs (ImplicitReferenceConversionExists): Skip for value types.
3318 (ImplicitStandardConversionExists): Fixed `byte' typo ?
3320 * ecore.cs (Expression.Error_ConstantValueCannotBeConverted): Moved.
3322 * literal.cs (NullLiteral.Error_ConstantValueCannotBeConverted): Customize
3325 * convert.cs, ecore.cs, enum.cs: Reflect Error_ConstantValueCannotBeConverted
3328 2005-07-18 Marek Safar <marek.safar@seznam.cz>
3331 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Check whether
3332 AssemblyCultureAttribute is not used on executable.
3335 * typemanager.cs: Add System.Reflection.AssemblyCultureAttribute.
3337 2005-07-16 Raja R Harinath <rharinath@novell.com>
3340 * expression.cs (Binary.Warning_UnintendeReferenceComparison):
3341 New. Reports CS0252/CS0253.
3342 Mostly taken from preliminary patch by Duncak Mak.
3343 (Binary.DoResolveOperator): Store results of operator lookup.
3344 Use them to detect if we need to warn about unintended reference
3347 2005-07-15 Raja R Harinath <rharinath@novell.com>
3350 * namespace.cs (Namespace.Lookup): Add back location parameter.
3351 (Namespace.LookupType): Add CS0436 report. Add location parameter.
3352 * delegate.cs, ecore.cs, expression.cs: Update to changes.
3354 * codegen.cs (EmitContext.DeclSpace): Make readonly.
3355 * namespace.cs (Namespace.Lookup): Carve out type lookup into ...
3356 (Namespace.LookupType): ... this.
3357 (NamespaceEntry.GetUsingTable): Allocate only one zero-sized array
3359 * typemanager.cs (LookupTypeReflection): Remove buggy code that
3360 purported to handle pointers.
3361 (char_ptr_type, void_ptr_type): Use GetPointerType rather than
3364 2005-07-15 Marek Safar <marek.safar@seznam.cz>
3366 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
3369 2005-07-15 Raja R Harinath <rharinath@novell.com>
3371 * namespace.cs (Namespace.Lookup): Drop location parameter.
3372 (NamespaceEntry.LookupAlias): Remove. Merge into ...
3373 (NamespaceEntry.Lookup): ... this.
3374 (NamespaceEntry.Error_AmbiguousTypeReference):
3375 Move here from DeclSpace.
3376 (NamespaceEntry.LookupNamespaceOrType): Move support for dotted
3378 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): ... here.
3379 * decl.cs (DeclSpace.ErrorAmbiguousTypeReference):
3380 Move to NamespaceEntry.
3381 * delegate.cs, expression.cs: Update to changes.
3383 2005-08-31 Martin Baulig <martin@ximian.com>
3385 Committing a patch from Atsushi Enomoto for #75850.
3387 * statement.cs (Foreach.CollectionForeach.GetEnumeratorFilter):
3388 Prefer a generic enumerator over a non-generic one.
3390 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
3392 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
3393 * gmcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
3395 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
3397 * driver.cs : reverting default encoding change as well as mcs.
3399 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
3401 * driver.cs, support.cs : merged r48826.
3403 > could you integrate your mcs changes to gmcs otherwise
3404 > gmcs cannot compile some files.
3406 2005-08-20 Martin Baulig <martin@ximian.com>
3408 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
3409 scope if we don't already have it.
3411 * expression.cs (Invocation.EmitCall): Use `ec.EmitThis ()' rather
3412 than `ig.Emit (OpCodes.Ldarg_0)' to make it work inside iterators;
3415 2005-07-31 Miguel de Icaza <miguel@novell.com>
3417 * statement.cs: Copy the local exception into the exception
3418 captured local. Fixes 75674
3420 2005-07-15 Marek Safar <marek.safar@seznam.cz>
3422 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
3425 2005-08-12 Martin Baulig <martin@ximian.com>
3427 * expression.cs (MemberAccess.ResolveNamespaceOrType): Only search
3428 for nested types here to avoid hitting the cache too early.
3430 2005-08-09 Miguel de Icaza <miguel@novell.com>
3432 * enum.cs: On the new compiler CLS error 3005 is now a warning not
3435 2005-08-03 Martin Baulig <martin@ximian.com>
3437 Make iterators in generic methods work; see gtest-191.cs.
3440 (Constraints.Resolve): Protect against being called twice.
3443 (TypeContainer.GetClassBases): Make this `protected virtual'.
3445 * iterator.cs (Iterator.ctor): Added `GenericMethod' argument.
3446 (Iterator.GetClassBases): Override this and compute the base
3448 (Iterator.DefineNestedTypes): If we're a generic method, all our
3449 method type parameters become class type parameters on the proxy
3453 (ToplevelBlock.Parameters): Make this a property, not a field.
3454 (ToplevelBlock.ResolveMeta): Update the `parameters' from the `ip'.
3456 2005-08-03 Martin Baulig <martin@ximian.com>
3458 * typemanager.cs (TypeManager.IsSubclassOf): Use
3459 `TypeManager.IsEqual' instead of `Type.Equals'; fixes gtest-190.cs.
3460 (TypeManager.GetFullName_recursed): Improved.
3462 2005-07-27 Carlos Alberto Cortez <calberto.cortez@gmail.com>
3465 * ecore.cs (Expression.IsAccessorAccessible): Change the check for
3466 Private accessor case, using TypeManager.IsPrivateAccessible instead of
3467 invocation_type == mi.DeclaringType, since the first one also checks
3468 other condition used by generic instances.
3470 2005-07-27 Martin Baulig <martin@ximian.com>
3472 * anonymous.cs (CaptureContext.AddField): Added
3473 `AnonymousContainer am' argument; compute its toplevel scope if
3474 it's not already computed. Fixes #75649.
3476 2005-07-14 Marek Safar <marek.safar@seznam.cz>
3478 * attribute.cs (Attribute.ResolveAttributeType): Renamed from
3479 CheckAttributeType and refactored.
3480 (Attribute.ResolvePossibleAttributeType): Changed to reuse
3481 ResolveAsTypeTerminal error handling.
3482 (ResolveAsTypeTerminal): Introduced because of global attributes extra
3484 (GetSignatureForError): Print errors in same way.
3487 * codegen.cs: Reflect attribute GetSignatureForError change.
3490 * expression.cs: Add silent parameter to ResolveAsTypeStep.
3492 * namespace.cs (UsingEntry): Refactored to make fields private.
3495 statement.cs: Error_UnexpectedKind has extra parameter.
3497 2005-07-14 Raja R Harinath <rharinath@novell.com>
3499 * ecore.cs (IAlias): Remove.
3500 * decl.cs (DeclSpace): Don't derive from IAlias. Remove members
3501 that implement the interface.
3502 * namespace.cs (Namespace): Likewise.
3503 (Namespace.declspaces): Renamed from 'defined_names'.
3504 (Namespace.AddDeclSpace): Renamed from 'DefineName'. Take a
3505 DeclSpace instead of an IAlias.
3506 * tree.cs (Tree.AddDecl): Update.
3508 2005-07-12 Raja R Harinath <rharinath@novell.com>
3510 * statement.cs (Block.Flags); Remove HasVarargs.
3511 (Block.HasVarargs): Move to ToplevelBlock.
3512 (Block.ThisVariable, Block.AddThisVariable): Likewise.
3513 (Block.Variables): Make protected. Initialize variable hashtable
3515 (Block.AddVariable): Update.
3516 (Block.Resolve): Update to changes.
3517 (ToplevelBlock.HasVarargs): New boolean.
3518 (ToplevelBlock.ThisVariable): Move here from Block.
3519 (ToplevelBlock.AddThisVariable): Likewise.
3520 (ToplevelBlock.IsThisAssigned): New. Forwards call to this_variable.
3521 * expression.cs (This.ResolveBase): Update to changes.
3522 (ArglistAccess.DoResolve): Likewise.
3524 2005-07-11 Marek Safar <marek.safar@seznam.cz>
3527 * ecore.cs, class.cs: Use SetAssigned instead of direct access.
3529 * class.cs (TypeContainer.VerifyMembers): Distinguish between
3530 not used and not used & assigned.
3531 (FieldBase.ASSIGNED): Moved to MemberCore.Flags.
3533 2005-07-11 Marek Safar <marek.safar@seznam.cz>
3536 * expression.cs (Is.DoResolve): null is never provided type.
3538 2005-07-08 Marek Safar <marek.safar@seznam.cz>
3541 * cs-parser.jay: Less strict event error rule to catch more errors.
3543 2005-07-11 Martin Baulig <martin@ximian.com>
3545 * generic.cs (ConstructedType.CheckConstraints): Improve the check
3546 for the constructor constraint: we do not only have to check
3547 whether the class has a public constructor, but also ensure that
3548 it's parameterless. Fixes #75492.
3550 2005-07-11 Martin Baulig <martin@ximian.com>
3552 * expression.cs (Binary.ResolveOperator): Only allow `==' and `!='
3553 between type parameters if they either have the reference type
3554 constraint or the class constraint.
3556 2005-07-10 Kamil Skalski <nazgul@nemerle.org>
3558 * generic.cs: Use MakeGenericType instead of BindGenericParameters.
3560 2005-07-07 Marek Safar <marek.safar@seznam.cz>
3563 * attribute.cs (orig_sec_assembly): Holds original version of assembly.
3564 (ExtractSecurityPermissionSet): Cope with self referencing security
3565 attributes properly.
3567 * driver.cs (SetOutputFile): Made public property OutputFile.
3569 2005-07-07 Raja R Harinath <rharinath@novell.com>
3572 * class.cs (TypeContainer.first_nonstatic_field): Rename from
3573 has_nonstatic_fields. Make into a FieldBase pointer.
3574 (TypeContainer.AddField): Add CS0282 check.
3575 (TypeContainer.EmitType): Update.
3577 2005-07-06 Miguel de Icaza <miguel@novell.com>
3579 * cs-tokenizer.cs (consume_identifier): Do not create strings to
3580 compare if they start with __.
3582 2005-07-06 Raja R Harinath <rharinath@novell.com>
3584 * statement.cs (Switch.SwitchGoverningType): Only look at
3585 UserCasts that don't need implicit standard conversions to one of
3586 the allowed switch types (Fixes test-322.cs).
3587 (LocalInfo.Resolve): Re-enable sanity-test.
3589 2005-07-06 Marek Safar <marek.safar@seznam.cz>
3591 * cs-tokenizer.cs (consume_identifier): Detect double undescores
3593 * ecore.cs (FieldExpr.AddressOf): Changed volatile error to warning.
3595 * expression.cs (Invocation.DoResolve): Report error CS0245 here.
3597 2005-07-06 Raja R Harinath <rharinath@novell.com>
3600 * ecore.cs (SimpleName.GetSignatureForError): Add.
3601 * expression.cs (MemberAccess.DoResolve): Don't clobber 'expr' field.
3602 (MemberAccess.GetSignatureForError): Add.
3604 2005-07-05 Marek Safar <marek.safar@seznam.cz>
3606 The big error and warning messages review.
3636 * typemanager.cs: Updated.
3638 * class.cs: (MethodCore.SetYields): Moved here to share.
3639 (PropertyMethod.Define): Moved iterator setup here.
3641 * iterators.cs: Add orig_method to have full access to parent
3644 2005-07-05 Raja R Harinath <rharinath@novell.com>
3646 Make 'fixed variable' handling standards compliant. Fix #70807, #72729.
3647 * ecore.cs (IVariable.VerifyFixed): Remove 'is_expression' parameter.
3648 (FieldExpr.VerifyFixed): Ensure that the field is part of a fixed
3649 variable of struct type.
3650 * expression.cs (Unary.ResolveOperator): Update to change.
3651 (Indirection.VerifyFixed): Likewise.
3652 (LocalVariableReference.VerifyFixed): A local variable is always fixed.
3653 (ParameterReference.VerifyFixed): Value parameters are fixed.
3654 (This.VerifyFixed): Treat 'this' as a value parameter.
3655 * statement.cs (LocalInfo.IsFixed): Remove.
3657 2005-07-01 Martin Baulig <martin@ximian.com>
3659 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
3660 `ec.EmitThis ()' to get the correct scope.
3662 2005-07-01 Martin Baulig <martin@ximian.com>
3664 * ecore.cs (FieldExpr.DoResolve): Don't capture the field if it's
3665 instance is a ParameterReference; fixes #75299.
3667 2005-06-30 Raja R Harinath <rharinath@novell.com>
3670 * expression.cs (Indexers.map): Remove.
3671 (Indexers.Append): Filter out inaccessible setters and getters.
3672 (IndexerAccess.DoResolve, IndexerAccess.DoResolveLValue): Update.
3675 * ecore.cs (MemberExpr.EmitInstance): New. Add CS0120 check.
3677 (FieldExpr.EmitInstance, PropertyExpr.EmitInstance): ... these.
3678 (FieldExpr.Emit, PropertyExpr.Emit): Update.
3679 (FieldExpr.EmitAssign, PropertyExpr.EmitAssign): Update.
3680 * expression.cs (Invocation.EmitCall): Add CS0120 check.
3682 2005-06-30 Marek Safar <marek.safar@seznam.cz>
3685 * class.cs (FieldBase.GetInitializerExpression): One more field
3688 2005-06-28 Miguel de Icaza <miguel@novell.com>
3690 * pending.cs: Do not define a proxy if the base method is virtual,
3691 it will be picked up by the runtime (bug 75270).
3693 2005-07-08 Martin Baulig <martin@ximian.com>
3695 * anonymous.cs (CaptureContext.EmitParameterInstance): Correctly
3696 handle parameters in nested scopes; fixes #74808; see gtest-188.cs.
3698 2005-07-07 Martin Baulig <martin@ximian.com>
3700 * generic.cs (ConstructedType.CheckConstraint): Use
3701 ResolveAsTypeStep(), not ResolveAsTypeTerminal() so we're not
3702 called recursively; fixes #75329.
3704 2005-07-06 Martin Baulig <martin@ximian.com>
3706 * generic.cs (TypeManager.InferTypeArguments): Added support for
3707 anonymous methods; fixes #75461.
3709 2005-07-01 Martin Baulig <martin@ximian.com>
3711 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
3712 `ec.EmitThis ()' to get the correct scope.
3714 2005-07-01 Martin Baulig <martin@ximian.com>
3716 * ecore.cs (FieldExpr.DoResolve): Only capture the field if it's
3717 instance is `This'; fixes #75299.
3719 2005-06-30 Martin Baulig <martin@ximian.com>
3721 * class.cs (Indexer): Implement IIteratorContainer; added support
3722 for iterators in indexers.
3725 (EmitContext.CurrentIterator): Make this a property, not a field.
3727 * anonymous.cs (AnonymousContainer.Iterator): New public property.
3729 2005-06-28 Miguel de Icaza <miguel@novell.com>
3731 * pending.cs: Do not define a proxy if the base method is virtual,
3732 it will be picked up by the runtime (bug 75270).
3734 2005-06-28 Martin Baulig <martin@ximian.com>
3736 * cs-parser.jay (interface_method_declaration): Avoid a
3737 reduce/reduce conflict by moving some of the code into a separate
3738 `interface_method_declaration_body' rule; fixes #75368.
3740 2005-06-28 Martin Baulig <martin@ximian.com>
3742 * typemanager.cs (TypeManager.MemberLookup_FindMembers): Move the
3743 array check after the check for TypeBuilder's.
3745 2005-06-21 Raja R Harinath <rharinath@novell.com>
3747 * convert.cs (FindMostEncompassedType): Add two trivial special
3748 cases (number_of_types == 0 || number_of_types == 1).
3749 (FindMostEncompasingType): Likewise.
3751 2005-06-17 Raja R Harinath <rharinath@novell.com>
3753 Some cleanups preparing for the fix of #75283.
3754 * ecore.cs (PropertyExpr.InstanceResolve): Tighten conditions for
3756 (EventExpr.InstanceResolve): Likewise.
3757 (EventExpr.DoResolve): Remove redundant checks.
3759 2005-06-08 Miguel de Icaza <miguel@novell.com>
3761 * class.cs: Small fix.
3763 2005-06-08 Raja R Harinath <rharinath@novell.com>
3766 * class.cs (GetPartialBases): Fix return value check of
3769 2005-06-07 Raja R Harinath <rharinath@novell.com>
3771 Ensure that partial classes are registered in their enclosing
3772 namespace. Initial part of fix of #75160.
3773 * tree.cs (Tree.RecordDecl): Add new namespace argument.
3774 Register declspace with namespace here, not in
3775 DeclSpace.RecordDecl.
3776 * cs-parser.jay: Pass namespace to RecordDecl.
3777 * class.cs (PartialContainer.Create): Likewise.
3778 (ClassPart.DefineType): New sanity-check. Throws an exception if
3780 * decl.cs (Declspace.RecordDecl): Remove.
3781 * namespace.cs (NamespaceEntry.DefineName): Remove.
3783 2005-06-06 Marek Safar <marek.safar@seznam.cz>
3785 * rootcontext.cs: Reset TargetExt as well.
3787 2005-06-03 Raja R Harinath <rharinath@novell.com>
3789 * ecore.cs (Expression.Resolve): Emit CS0654 error when
3792 2005-06-02 Raja R Harinath <rharinath@novell.com>
3794 Fix #75080, cs0119.cs.
3795 * ecore.cs (Expression.ExprClassToResolveFlags): New. Broken out
3797 (Expression.Resolve): ... this. Use it. Remove bogus code
3798 allowing ExprClass.Type and ExprClass.Namespace for
3799 ResolveFlags.VariableOrValue.
3800 (Expression.Resolve) [1-argument variant]: Change default resolve
3801 flags based on language version.
3802 (Expression.Error_UnexpectedKind): Use a simple string array
3803 rather than an ArrayList.
3804 * expression.cs (TypeOf.DoResolve): Set eclass to ExprClass.Value,
3806 (TypeOfVoid.DoResolve): Likewise.
3807 (MemberAccess.DoResolve) [3-argument variant]: Make private. Drop
3808 flags argument -- it always has the same value.
3810 2005-05-31 Raja R Harinath <rharinath@novell.com>
3813 * ecore.cs (Expression.ResolveLValue): Add a Location parameter.
3814 Use it in the error message.
3815 * assign.cs, expression.cs, statement.cs: Update.
3817 2005-05-30 Raja R Harinath <rharinath@novell.com>
3820 * ecore.cs (Expression.MemberLookupFailed): Add CS0122 check in
3821 the "almostMatchedMember" case too.
3822 * typemanager.cs (Closure.CheckValidFamilyAccess): Add anything
3823 that failed the accessibility checks to 'almost_match'.
3825 2005-05-27 Vladimir Vukicevic <vladimir@pobox.com>
3827 * attribute.cs: Use internal MethodBuilder methods to set
3828 ExactSpelling and SetLastError on PInvoke methods, instead
3829 of passing them via charset. Fixes #75060.
3831 2005-05-27 Raja R Harinath <rharinath@novell.com>
3833 * parameter.cs (Parameter): Remove TODO comment.
3834 (Parameter.DefineParameter): Remove Location parameter.
3835 (Parameters.LabelParameters): Likewise.
3836 * class.cs (Constructor.Emit): Update to change.
3837 (MethodData.Emit): Likewise.
3838 * anonymous.cs (AnonymousMethod.EmitMethod): Likewise.
3839 * delegate.cs (Delegate.Define, Delegate.Emit): Likewise.
3841 2005-05-27 Atsushi Enomoto <atsushi@ximian.com>
3844 Removed Parameters.Location and added Parameter.Location instead.
3845 Removed Location parameter from Emit() and GetSignature().
3852 Modified all related calls.
3854 2005-06-21 Martin Baulig <martin@ximian.com>
3856 * generic.cs (NullCoalescingOperator.Emit): Make this work if the
3857 left-hand side is not a nullable type; fixes #75328.
3859 2005-06-21 Martin Baulig <martin@ximian.com>
3862 (TypeManager.CSharpName): Use GetFullName() instead of `t.FullName'.
3863 (TypeManager.GetFullNameSignature): Likewise.
3865 * convert.cs (Convert.Error_CannotImplicitConversion): Compare
3866 `source.FullName' and `target.FullName' to check whether there are
3867 two conflicting definitions.
3869 2005-06-21 Martin Baulig <martin@ximian.com>
3871 * convert.cs (Convert.ImplicitTypeParameterConversion): Always use
3872 a BoxedCast - also for reference types - to be compatible with csc.
3874 2005-06-21 Martin Baulig <martin@ximian.com>
3876 * expression.cs (MemberAccess.DoResolve): Add support for nested
3877 types in a generic instance; fixes #75320.
3879 2005-06-20 Martin Baulig <martin@ximian.com>
3881 * generic.cs (TypeManager.InferType): Also walk the class
3882 hierarchy for generic instances; fixes #75261.
3884 2005-06-17 Martin Baulig <martin@ximian.com>
3886 * typemanager.cs (TypeManager.IsBuiltinType): Use TypeToCoreType()
3887 to make things work for corlib.
3889 2005-06-15 Martin Baulig <martin@ximian.com>
3891 * attribute.cs (Attribute.CheckSecurityActionValidity): Remove the
3892 obsolete `SecurityAction' values.
3894 2005-06-06 Marek Safar <marek.safar@seznam.cz>
3896 * rootcontext.cs: Reset TargetExt as well.
3898 2005-06-09 Martin Baulig <martin@ximian.com>
3900 * delegate.cs (Delegate.VerifyMethod): Added
3901 `MethodGroupExpr old_mg' argument; inherit its
3902 `HasTypeParameters'; fix #75085.
3904 2005-06-09 Martin Baulig <martin@ximian.com>
3906 * expression.cs (Invocation.OverloadResolve): Correctly handle
3907 generic methods for the SetMemberIsUsed(); fix #75064.
3909 2005-06-09 Martin Baulig <martin@ximian.com>
3911 * statement.cs (Throw.Resolve): Use TypeManager.IsSubclassOf();
3914 2005-06-08 Martin Baulig <martin@ximian.com>
3916 * cs-parser.jay (nullable_type_or_conditional): If we put the
3917 nullable back and our `type' is a `ComposedCast', remove the
3918 nullable from it. Fixes #75156.
3920 * expression.cs (ComposedCast.RemoveNullable): New public method.
3922 2005-06-08 Martin Baulig <martin@ximian.com>
3924 The big Iterators rewrite :-)
3926 * iterators.cs: Rewrite this to use the anonymous methods framework.
3928 * rootcontext.cs (RootContext.DefineTypes): Define Delegates
3929 before the TypeContainers; see 2test-21.cs.
3932 (TypeContainer.DefineType): Don't create a new EmitContext if we
3933 already have one (this only happens if we're an Iterator).
3934 (TypeContainer.Define): Also call Define() on all our iterators.
3935 (Method.CreateEmitContext): Added support for iterators.
3938 (AnonymousContainer): New abstract base class for `AnonymousMethod'.
3939 (AnonymousContainer.CreateMethodHost): Moved here from
3940 AnonymousMethod and made abstract.
3941 (AnonymousContainer.CreateScopeType): New abstract method.
3942 (AnonymousContainer.IsIterator): New public property.
3943 (ScopeInfo.EmitScopeType): Call CreateScopeType() on our Host to
3944 get the ScopeTypeBuilder rather than manually defining it here.
3945 (ScopeInfo.EmitScopeInstance): New public method; correctly handle
3948 * driver.cs (Driver.MainDriver): Call TypeManager.InitCodeHelpers()
3949 before RootContext.DefineTypes().
3951 * codegen.cs (EmitContext.RemapToProxy): Removed.
3952 (EmitContext.CurrentAnonymousMethod): Changed type from
3953 AnonymousMethod -> AnonymousContainer.
3954 (EmitContext.ResolveTopBlock): Protect from being called twice.
3955 (EmitContext.MapVariable, RemapParameter(LValue)): Removed.
3956 (EmitContext.EmitThis): Removed the iterators hacks; use the
3957 anonymous methods framework for that.
3960 (ToplevelBlock.Container): Make this a property, not a field.
3961 (ToplevelBlock.ReParent): New public method; move the
3962 ToplevelBlock into a new container.
3963 (Foreach.TemporaryVariable): Simplify.
3965 2005-06-05 Martin Baulig <martin@ximian.com>
3967 * statement.cs (LocalInfo.CompilerGenerated): New flag.
3968 (Block.AddTemporaryVariable): New public method; creates a new
3969 `LocalInfo' for a temporary variable.
3970 (Block.EmitMeta): Create the LocalBuilders for all the temporary
3972 (Foreach.TemporaryVariable): Use Block.AddTemporaryVariable() for
3973 non-iterator variables.
3975 2005-06-05 Martin Baulig <martin@ximian.com>
3977 * statement.cs (Foreach.TemporaryVariable): Create the
3978 LocalBuilder in the Emit phase and not in Resolve since in some
3979 situations, we don't have an ILGenerator during Resolve; see
3980 2test-19.cs for an example.
3982 2005-06-04 Martin Baulig <martin@ximian.com>
3984 The big Foreach rewrite - Part II.
3986 * typemanager.cs (TypeManager.object_getcurrent_void): Replaced
3987 with `PropertyInfo ienumerator_getcurrent'.
3989 * codegen.cs (VariableStorage): Removed.
3992 (Foreach): Derive from Statement, not ExceptionStatement.
3993 (Foreach.CollectionForeach): New nested class. Moved all the code
3994 dealing with collection foreach here.
3995 (Foreach.ForeachHelperMethods): Removed.
3996 (Foreach.TemporaryVariable): Implement IMemoryLocation.
3998 2005-05-23 Martin Baulig <martin@ximian.com>
4000 * statement.cs (Try.DoResolve): Don't create a `finally' if we
4001 don't need to. Fix #75014.
4003 2005-05-26 Raja R Harinath <rharinath@novell.com>
4005 Improve user-defined conversion handling.
4006 * convert.cs (GetConversionOperators): Rewrite. Return only the
4007 applicable operators.
4008 (AddConversionOperators): New. Helper for GetConversionOperators.
4009 (FindMostEncompassedType, FindMostEncompassingType): Verify that
4010 there is only one most encompassed/encompassing type.
4011 (FindMostSpecificSource, FindMostSpecificTarget): Remove
4012 "applicable operator" handling.
4013 (UserConversion): Move cache here from GetConversionOperators.
4014 Directly cache the chosen operator, rather than the whole
4016 (ExplicitNumericConversion): Fix buggy implementation of Decimal
4017 case. Allow conversion of decimal to sbyte and byte too.
4018 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
4019 New static methods. Used to avoid allocating EmptyExpressions in
4022 2005-05-24 Duncan Mak <duncan@novell.com>
4024 * ecore.cs (CastFromDecimal): New class for casting a decimal to
4025 another class, used in Convert.ExplicitNumericConversion.
4026 (CastToDecimal): New class, similar to above, but casts to
4027 System.Decimal, used in Convert.ImplicitNumericConversion and also
4028 in explicit convesion from double/float to decimal.
4030 * convert.cs (ImplicitNumericConversion): Handle implicit
4031 conversions to System.Decimal.
4032 (ExplicitNumericConversion): handle explicit conversions to
4037 2005-05-20 Miguel de Icaza <miguel@novell.com>
4039 * typemanager.cs: Do not throw an exception in the TypeBuilder
4040 case, we take care of it on the TypeCode.
4042 2005-05-17 Marek Safar <marek.safar@seznam.cz>
4044 * attribute.cs (Attribute.ResolveArguments): GuidAttribute check
4047 * cs-parser.jay: Catch more lexical errors.
4049 * report.cs: Add one more Error method.
4052 * typemanager.cs: Register System.Runtime.InteropServices.GuidAttribute
4054 2005-05-20 Martin Baulig <martin@ximian.com>
4056 * class.cs (TypeContainer.CircularDepException): Removed.
4057 (TypeContainer.DefineType): Removed the `InTransit' stuff.
4058 (TypeContainer.CheckRecursiveDefinition): Check for circular class
4059 (CS0146) and interface (CS0529) dependencies here.
4061 2005-05-20 Martin Baulig <martin@ximian.com>
4063 * expression.cs (New.DoResolve): Move the CS0712 check above the
4064 CS0144 check; otherwise it can never be reached.
4066 2005-05-20 Martin Baulig <martin@ximian.com>
4068 * cs-parser.jay: Fix CS0080 check; add CS0231 and CS0257 from MCS.
4070 2005-05-20 Martin Baulig <martin@ximian.com>
4072 * class.cs (TypeContainer.DefineType): Fix CS0698 check.
4074 * typemanager.cs (TypeManager.IsAttributeType): New public method.
4076 2005-05-19 Martin Baulig <martin@ximian.com>
4079 (ImplicitDelegateCreation.Check): Added `bool check_only' argument
4080 to disable error reporting.
4082 * convert.cs (Convert.ImplicitStandardConversionExists): Use it
4083 here since we don't want to report an error; see the new test-336.cs.
4085 2005-05-19 Raja R Harinath <rharinath@novell.com>
4087 * statement.cs (ToplevelBlock.GetParameterReference)
4088 (ToplevelBlock.IsParameterReference,ToplevelBlock.IsLocalParameter):
4089 Move here from class Block.
4090 * ecore.cs (SimpleName.SimpleNameResolve): Update to changes.
4091 * expression.cs (ParameterReference.DoResolveBase): Likewise.
4093 2005-05-18 Martin Baulig <martin@ximian.com>
4098 (FlowBranching.Reachability): Add non-static public And() and Or()
4100 (FlowBranchingSwitch): New class; do the `break_origins' thing
4101 like in FlowBranchingLoop.
4102 (FlowBranching.UsageVector.MergeBreakOrigins): Also merge the
4103 reachability, not just locals and parameters.
4104 (FlowBranching.MergeChild): Remove some of the hacks for loop and
4105 switch; MergeBreakOrigins() now takes care of that.
4107 2005-05-18 Martin Baulig <martin@ximian.com>
4109 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
4110 a loop and may leave it, reset the barrier; fixes #74974.
4112 2005-05-16 Raja R Harinath <rharinath@novell.com>
4114 Fix test-382.cs. Emit values of decimal constants.
4115 * class.cs (TypeContainer.RegisterFieldForInitialization): New.
4117 (TypeContainer.AddField): ... this.
4118 (TypeContainer.EmitFieldInitializers): Allow the list of fields
4119 with initializers to include 'Const's.
4120 (ClassPart.RegisterFieldForInitialization): Forward to
4122 * const.cs (Const.Const): Pass initializer to base class.
4123 (Const.Define): In case of decimal constants, register them for
4124 initialization in a static constructor.
4126 2005-05-14 Martin Baulig <martin@ximian.com>
4128 * statement.cs (Block.Resolve): Correctly handle unreachable code;
4129 do not call ResolveUnreachable() on unreachable statements in
4130 here, see the comment in the source code.
4132 2005-05-13 Raja R Harinath <rharinath@novell.com>
4135 * expression.cs (BinaryResolveOperator): If one of the operands of
4136 an equality comparison is 'null' and the other is a pointer type,
4137 convert the null to a NullPointer.
4138 * convert.cs (ImplicitReferenceConversion): If the expression is a
4139 NullLiteral and the target type is a pointer type, return a
4140 NullPointer instead.
4141 (ImplicitConversionStandard): Likewise.
4143 2005-05-13 Marek Safar <marek.safar@seznam.cz>
4145 * cs-parser.jay: Set readonly context based on special constructs.
4147 * expression.cs (LocalVariableReference.DoResolveBase): Improved
4148 readonly variable error handling.
4150 * rootcontext.cs (EmitCode): Don't verify members when error
4153 * statement.cs (LocalInfo): Add reaodnly context information.
4154 (SetReadOnlyContext, GetReadOnlyContext): New methods.
4156 2005-05-17 Martin Baulig <martin@ximian.com>
4158 * expression.cs (Argument.Resolve): Turn on flow analysis; fix
4161 2005-05-13 Martin Baulig <martin@ximian.com>
4163 * statement.cs (Block.Resolve, ResolveUnreachable): Correctly
4164 handle unreachable blocks.
4166 2005-05-13 Martin Baulig <martin@ximian.com>
4169 (ConstructorInitializer.GetOverloadedConstructor): Don't crash.
4170 (MethodCore.CheckCore): Use TypeManager.IsEqual(); fix #74904 and
4173 2005-05-13 Martin Baulig <martin@ximian.com>
4175 * statement.cs (Block.Resolve): Make the `bool unresolved' flag an
4176 instance variable, not a local. Fix #74873.
4177 (Block.ResolveUnreachable): Set it to true here.
4179 2005-05-12 Martin Baulig <martin@ximian.com>
4181 * cs-parser.jay (property_declaration): Pass the `current_class',
4182 not the `current_container' to Property's .ctor. Fixes #74912.
4184 2005-05-11 Martin Baulig <martin@ximian.com>
4186 * typemanager.cs (Closure): Copy this from MCS and merge all the
4187 GMCS-specific changes into it.
4189 2005-05-12 Raja R Harinath <harinath@gmail.com>
4192 * typemanager.cs (unmanaged_enclosing_types): New.
4193 (IsUnmanagedType): Avoid infloops by using
4194 'unmanaged_enclosing_types' to talk with recursive invocations.
4196 2005-05-11 Duncan Mak <duncan@novell.com>
4198 * cs-tokenizer.cs (get_cmd_arg): Check that 'c' is not -1 before
4199 continuing to process for 'arg'.
4200 (handle_preprocessing_directive): Check the argument of the #endif
4201 directive and report error CS1025 if there are any trailing
4204 According to the C# spec, having even whitespace after the #endif
4205 directive is illegal; however, because we call arg.TrimEnd ()
4206 beforehand, we have the same behavior as csc, allowing whitespace
4207 after the directive.
4211 2005-05-11 Marek Safar <marek.safar@seznam.cz>
4215 * class.cs (ConstructorInitializer.GetOverloadedConstructor): Removed.
4216 (Constructor.GetObsoleteAttribute): Implemented correctly.
4218 2005-05-10 Martin Baulig <martin@ximian.com>
4220 * generic.cs (Constraints.Resolve): Report CS0246 if we cannot
4221 resolve the type; fixes #74864.
4222 (DefaultValueExpression): Create the LocalTemporary in Emit(), not
4223 in DoResolve(); fixes #74862.
4225 2005-05-10 Martin Baulig <martin@ximian.com>
4227 * support.cs (ReflectionParameters.ParameterModifier): Use
4228 `Parameter.Modifier.REF' if we both have `ParameterAttributes.Out'
4229 and `ParameterAttributes.In'. Fixes #74884.
4231 2005-05-10 Martin Baulig <martin@ximian.com>
4233 * typemanager.cs (TypeManager.MemberLookup_FindMembers): Don't use
4234 the cache if we're just looking for `MemberTypes.NestedType' in a
4237 * ecore.cs (Expression.ResolveAsTypeTerminal): Don't check the
4238 constraints if we're still resolving the type tree.
4239 (Expression.MemberLookup): If we're resolving the type tree, only
4240 look for `MemberTypes.NestedType' since we're only interested in
4243 * class.cs (TypeContainer.DefineType): Don't resolve the type
4244 parameters here; do this later in ResolveType() after the type
4245 tree has been resolved.
4246 (TypeContainer.ResolveType): New public method; this is called
4247 after the type tree is resolved and before the types are being
4248 populated. We resolve the generic constraints here.
4249 (TypeContainer.DoDefineMember): Check the constraints on our base
4250 class and interfaces.
4252 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Make this protected;
4253 set the `ResolvingTypeTree' flag on the EmitContext.
4255 * codegen.cs (EmitContext.ResolvingTypeTree): New public field.
4257 2005-05-10 Marek Safar <marek.safar@seznam.cz>
4259 * class.cs (Method.Define): Catch attempt for Finalizer declaration.
4261 * expression.cs (Argument.GetParameterModifier): Turned to property.
4262 (Invocation.Error_InvalidArguments): Add more descriptive errors.
4264 * parameter.cs (Parameter.GetModifierSignature): Translates modifier to
4267 2005-05-09 Raja R Harinath <rharinath@novell.com>
4270 * decl.cs (MemberCache.AddMethods): Register override methods,
4271 rather than non-override methods.
4272 * typemanager.cs (RegisterOverride): New.
4273 (IsOverride): Update.
4275 2005-05-09 Marek Safar <marek.safar@seznam.cz>
4277 * typemanager.cs (TypeManager): Moved InitGenerics to Reset method.
4279 2005-05-06 Martin Baulig <martin@ximian.com>
4282 (Attributable.IsClsComplianceRequired): Fix typo in the method name.
4283 (AttributeTester.AnalyzeTypeCompliance): Add generics support.
4285 2005-05-09 Marek Safar <marek.safar@seznam.cz>
4289 * ecore.cs (SimpleName.SimpleNameResolve): Add in_transit to catch
4290 recursive declaration.
4292 * statement.cs (Block.ResolveMeta): Report any error in resolving.
4294 2005-05-06 Marek Safar <marek.safar@seznam.cz>
4296 * cfold (DoConstantNumericPromotions): Don't try to convert 0 enum.
4298 * expression.cs (Binary.DoResolve): (x && 0) is always 0.
4300 2005-05-05 Raja R Harinath <rharinath@novell.com>
4303 * decl.cs (DeclSpace.FamilyAccessible):
4304 Use TypeManager.IsNestedFamilyAccessible.
4306 Fix reopened #64812.
4307 * typemanager.cs (Closure.Filter): Introduce checks for 'protected
4310 2005-05-04 Raja R Harinath <rharinath@novell.com>
4311 Abin Thomas <projectmonokochi@rediffmail.com>
4312 Anoob V E <projectmonokochi@rediffmail.com>
4313 Harilal P R <projectmonokochi@rediffmail.com>
4316 * typemanager.cs (Closure.CheckValidFamilyAccess): Don't blindly
4317 allow access to all static members.
4319 2005-05-04 Martin Baulig <martin@ximian.com>
4321 * ecore.cs (FieldExpr.DoResolveLValue): Always call fb.SetAssigned().
4323 2005-05-04 Martin Baulig <martin@ximian.com>
4327 * statement.cs (Switch.SimpleSwitchEmit): Always emit the default
4328 section at the end; make things work if `default' is not the last
4331 2005-05-04 Martin Baulig <martin@ximian.com>
4335 * statement.cs (Switch): Replaced the `got_default' field with a
4336 `default_section' one.
4337 (Switch.CheckSwitch): Set `default_section' here.
4338 (Switch.Resolve): If we're a constant switch and the constant is
4339 not found, use the default section.
4341 2005-05-03 Martin Baulig <martin@ximian.com>
4343 * expression.cs (ArrayAccess.EmitGetLength): New public method.
4345 * statement.cs (Foreach.ArrayForeach): New nested class.
4346 (Foreach.TemporaryVariable): New nested class.
4347 (Foreach.EmitArrayForeach): Removed; this is now in the new
4350 2005-05-03 Raja R Harinath <rharinath@novell.com>
4352 * pending.cs (BaseImplements): Move the #74773 fix here. This is
4354 (VerifyPendingMethods): Revert change below.
4356 * typemanager.cs (IsOverride, RegisterNonOverride): New.
4357 * decl.cs (MemberCache.AddMethod): Register "non-override" methods
4358 that used to trigger warning -28. Remove warning -28.
4359 * expression.cs (Invocation.OverloadResolve): Use
4360 TypeManager.IsOverride to distinguish override methods.
4363 * pending.cs (VerifyPendingMethods): If a base type implements the
4364 requested interface, don't bother checking individual methods of
4365 the base type. As a side-effect, this prevents the creation of
4366 unnecessary proxies.
4368 2005-05-02 Martin Baulig <martin@ximian.com>
4372 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
4373 Also `And' the locals if the old vector is null.
4374 (FlowBranching.UsageVector.BitVector.And): Allow `vector' being
4375 null; in this case we basically reset all the variables.
4377 2005-05-02 Martin Baulig <martin@ximian.com>
4381 * flowanalysis.cs (FlowBranching.UsageVector.MergeBreakOrigins):
4382 Added `FlowBranching branching' argument; always `and' the
4383 variables instead of `or'ing them unless we're an infinite loop.
4385 * statement.cs (While.Resolve): Create a new sibling unless we're
4388 2005-05-02 Martin Baulig <martin@ximian.com>
4392 * class.cs (ConstructorInitializer.Resolve): Added `Block block'
4393 arguments; use it instead of creating a new TopLevelBlock.
4394 (Constructor.Emit): Call `block.ResolveMeta ()' before resolving
4395 our ConstructorInitializer.
4398 (TopLevelBlock.TopLevelBranching): New public property.
4399 (TopLevelBlock.ResolveMeta): New public method; call ResolveMeta()
4400 and create our `TopLevelBranching'.
4402 * codegen.cs (EmitContext.ResolveTopBlock): If we're not an
4403 anonymous method host, use `block.TopLevelBranching' rather than
4404 creating a new branching.
4406 2005-04-20 Miguel de Icaza <miguel@novell.com>
4408 * anonymous.cs (ScopeInfo.AddChild): when adding a new child to
4409 a ScopeInfo, if any of the current children is a child of the new
4410 entry, move those children there.
4412 2005-04-30 Martin Baulig <martin@ximian.com>
4414 * statement.cs (Switch.SimpleSwitchEmit): Reset `default_at_end'
4415 at the beginning of a SwitchSection. Fix #73335.
4417 2005-04-27 Marek Safar <marek.safar@seznam.cz>
4420 * class.cs (EmitFieldInitializers): Use FieldExpr in initializer.
4422 * ecore.cs (FieldExpr): Add a new ctor with in_initializer.
4423 (FieldExpr.DoResolve): Obsolete members are ignored for field
4426 2005-04-26 Marek Safar <marek.safar@seznam.cz>
4428 * attribute.cs (AreOverloadedMethodParamsClsCompliant): Add array
4429 of arrays detection.
4431 * class.cs (Interface.VerifyClsCompliance): Add base interfaces
4433 (Field.VerifyClsCompliance): Volatile fields are not compliant.
4435 * decl.cs (MemberCache.VerifyClsParameterConflict): Add array of
4438 2005-04-25 Ben Maurer <bmaurer@ximian.com>
4440 * cs-parser.jay: Use the prefered version of -unsafe in error
4443 2005-04-22 Marek Safar <marek.safar@seznam.cz>
4445 * driver.cs (CompilerCallableEntryPoint.Invoke): Reset under any
4448 2005-04-20 John Luke <john.luke@gmail.com>
4450 * driver.cs: fix typo in error message, --outout to --output
4452 2005-04-30 Martin Baulig <martin@ximian.com>
4454 * attribute.cs (Attribute.CheckSecurityActionValidity): Correctly
4455 handle the .NET 2.x security attributes.
4457 2005-04-30 Martin Baulig <martin@ximian.com>
4460 (TypeManager.ExpandInterfaces): Don't add things twice.
4463 (TypeContainer.VerifyClsCompliance): Allow generic instances.
4465 2005-04-29 Martin Baulig <martin@ximian.com>
4467 * generic.cs (Constraints.ResolveTypes): Expand interfaces.
4469 * anonymous.cs: Added support for anonymous generic methods.
4471 2005-04-29 Martin Baulig <martin@ximian.com>
4473 * typemanager.cs (TypeManager.GetInterfaces): Correctly handle
4476 2005-04-29 Martin Baulig <martin@ximian.com>
4478 * generic.cs (TypeManager.HasConstructorConstraint): Removed.
4480 * expression.cs (New.DoResolve): Fix the CS0304 check.
4482 2005-04-29 Martin Baulig <martin@ximian.com>
4484 * typemanager.cs (TypeManager.GetFullName): Updated to the new
4487 * class.cs (MethodCore.IsDuplicateImplementation): If we're an
4488 explicit interface implementation, compare the interface types.
4489 (MethodData.Define): Use the new naming scheme from the latest
4491 (MemberBase.DoDefineBase): Resolve `InterfaceType' here.
4493 * decl.cs (MemberName.GetMemberName): Removed.
4494 (MemberName.MethodName, FullName): New properties.
4496 2005-04-25 Raja R Harinath <rharinath@novell.com>
4498 * gmcs.exe.config: Update v2.0.40607 -> v2.0.50215.
4500 2005-04-22 Martin Baulig <martin@ximian.com>
4502 * generic.cs (GenericMethod): Create the EmitContext in the
4503 `Define()'; in `Define(MethodBuilder)', create the type parameters
4504 before calling `Define()'. Fixes #73933.
4506 2005-04-22 Martin Baulig <martin@ximian.com>
4509 (Constraints.Resolve): Make things work wrt. the new type lookup system.
4510 (ConstructedType.ResolveAsTypeTerminal): Don't override this.
4512 * ecore.cs (Expression.ResolveAsTypeTerminal): If `te' is a
4513 ConstructedType, check its constraints.
4515 2005-04-20 Marek Safar <marek.safar@seznam.cz>
4517 * codegen.cs (InRefOutArgumentResolving): New field.
4519 * ecore.cs (FieldExpr.DoResolve): Check for assigning to readonly
4520 fields outside contructor.
4522 * expression.cs (Argument.Resolve): Set InRefOutArgumentResolving.
4524 2005-04-19 Miguel de Icaza <miguel@novell.com>
4526 * anonymous.cs (CaptureContext.EmitParameterInstance): The
4527 parameter code was not completed ever, so it was not as up-to-date
4528 as local variables. Must finish it.
4530 The bug fix was to compare the Toplevel of the block, not the
4531 current block. Thanks for Ben for pointing this out.
4533 2005-04-19 Raja R Harinath <rharinath@novell.com>
4535 * decl.cs (AddMethods): Use the declaring type of the problem
4536 method to determine if we want to squash a warning.
4538 2005-04-19 Marek Safar <marek.safar@seznam.cz>
4540 * attribute.cs: Removed debug output.
4542 * decl.cs (MemberCache.AddMethods): Fixed Finalize ignoring.
4544 * driver.cs (Driver.parse): Synchronize parser ErrorOutput with
4547 2005-04-18 Raja R Harinath <rharinath@novell.com>
4550 * expression.cs (Binary.EqualsNullIsReferenceEquals): New.
4551 (Binary.DoResolveOperator): Use it to avoid blindly optimizing out
4552 all null comparisons against reference types.
4554 2005-04-18 Marek Safar <marek.safar@seznam.cz>
4557 * class.cs (TypeContainer.CircularDepException) New nested
4559 (GetPartialBases, GetNormalBases, GetClassBases): Removed error.
4560 (TypeContainer.DefineType): Removed error, reset InTransit before
4562 (Class.DefineType): Throw exception when is in Transit.
4563 Catch exception and report error.
4564 (Struct.DefineType): Throw exception when is in Transit.
4565 Catch exception and report error.
4566 (Interface.DefineType): Throw exception when is in Transit.
4567 Catch exception and report error.
4569 * codegen.cs: Add InCatch,InFinally to EmitContext to easily
4570 handle nested exception handlers.
4572 * flowanalysis.cs (InTryWithCatch): New method, search for try with
4575 * iterators.cs (Yield.CheckContext): Add CS1626 report. Updated
4576 InFinally and InCatch storage.
4578 * statement.cs (Throw.Resolve): Use InCatch, InFinally from ec.
4579 (Catch.Resolve): Set and Restore ec.InCatch.
4580 (Try.Resolve): Set and Restore ec.InFinally.
4581 (Try.HasCatch): True when try has catch.
4583 2005-04-17 Atsushi Enomoto <atsushi@ximian.com>
4585 * doc.cs : In some cases FilterName returns MonoEvent and MonoField
4586 for the same event member, so exclude such cases from warning 419.
4589 2005-04-16 Miguel de Icaza <miguel@novell.com>
4591 * expression.cs (Binary.ResolveOperator): Apply patch from John
4592 Luke to fix bug 59864: operators &, | and ^ on enumerations
4593 require that the same enum type on both sides.
4595 * driver.cs: Add warnings to old flag usage, this is to assist
4596 people who produce Makefiles and hope that the Makefiles will be
4599 * class.cs (TypeContainer.EmitType): Moved the definition of the
4600 special $PRIVATE$ field from the resolve phase to the Emit phase.
4601 During resolve we do not know if we are a struct with
4602 HasExplicitLayout, we know this only after the attributes for the
4605 Set the FieldOffset to zero on the dummy field that we create for
4606 the class. Fixes 74590.
4608 2005-04-16 Raja R Harinath <rharinath@novell.com>
4611 * ecore.cs (PropertyExpr.resolved): New.
4612 (DoResolve): Use it to handle a case of double resolution here.
4613 Handle a case of identical-name-and-type-name.
4614 * expression.cs (ArrayCreation.CheckIndices): Avoid double
4615 resolution by storing the results of expression resolution back
4616 into the "probes" array.
4618 2005-04-15 Raja R Harinath <rharinath@novell.com>
4620 Fix cs0208-7.cs and cs0208-8.cs.
4621 * typemanager.cs (IsUnmanagedType): Arrays are not allowed
4622 (cf. ECMA standard, behaviour of CSC 1.1 and CSC 2.0). Improve
4623 error reporting to point out the reason a struct is not unmanaged.
4625 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
4627 * doc.cs : In FindDocumentedType(), avoid TypeExpr.ResolveType() and
4628 just use TypeExpr.Type. This fixes bug #74595 when merged to gmcs.
4630 2005-04-13 Raja R Harinath <rharinath@novell.com>
4633 * ecore.cs (PropertyExpr.InstanceResolve): Handle a case of
4634 IdenticalNameAndTypeName here.
4635 (EventExpr.InstanceResolve): Likewise.
4637 2005-04-13 Marek Safar <marek.safar@seznam.cz>
4639 C# 2.0 DefaultCharSetAttribute implementation
4641 * attribute.cs (Attribute.ResolveAsTypeStep): New protected method
4642 which allows us to set GlobalNamespace for every resolve.
4643 (Attribute.ResolveArguments): Cut from Resolve.
4644 (Attribute.GetCharSetValue): Returns CharSet named argument.
4645 (Attribute.DefinePInvokeMethod): Gets default charset from
4647 (GlobalAttribute.ResolveAsTypeStep): Override.
4648 (GlobalAttribute.ResolveArguments): Override.
4650 * class.cs (TypeAttr): Is protected.
4652 * codegen.cs (ModuleClass.DefaultCharSet): New member.
4653 (ModuleClass.DefaultCharSetType): New memeber.
4654 (ModuleClass.ResolveAttributes): Resolves DefaultCharSetAttribute.
4656 * decl.cs (Decl.TypeAttr): New protected virtual. Returns default
4657 charset from module.
4659 * delegate.cs (TypeAttr): Override.
4660 (Delegate.DefineType): Use this TypeAttr.
4662 * driver.cs (Driver.MainDriver): Call Module.ResolveAttributes
4663 at very early stage (before types are defined) to resolve model
4664 module attributes. It will probably not work with corlib but it
4667 * enum.cs (Enum.TypeAttr): New protected virtual. Returns default
4668 charset from module.
4670 * typemanager.cs (default_charset_type): New type.
4672 2005-04-13 Raja R Harinath <rharinath@novell.com>
4674 * decl.cs (MemberCache.AddMethods): Don't warn if
4675 System.Object.Finalize has buggy MethodAttributes.
4677 * typemanager.cs (IsUnmanagedType): Restore !IsValueType check
4680 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
4682 * doc.cs : detect ambiguous reference to overloaded members.
4683 Fixed bug #71603. MS 1.1 csc does not detect it.
4685 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
4687 * doc.cs : delegates must not be referenced with parameters.
4690 2005-04-12 Miguel de Icaza <miguel@novell.com>
4692 * typemanager.cs (IsUnmanagedType): Arrays are allowed.
4694 2005-04-10 Miguel de Icaza <miguel@novell.com>
4696 * driver.cs (MainDriver): Stop processing if the CLS stage found
4699 (CompilerCallableEntryPoint.InvokeCompiler): Always
4700 reset after execution; Take a TextWriter argument for the
4703 * report.cs: Use the error stream instead of hardcoding stderr.
4705 2005-04-09 Miguel de Icaza <miguel@novell.com>
4707 * class.cs: Reduce code paths to test, too small of an
4708 optimization to make it worth the extra testing. Always perform
4711 2005-04-08 Raja R Harinath <rharinath@novell.com>
4714 * class.cs (OperatorArrayList.CheckPairedOperators): Skip
4715 operators that had errors reported on them.
4717 2005-04-08 Marek Safar <marek.safar@seznam.cz>
4719 * attribute.cs (Attribute.IsValidArgumentType): Test valid named
4721 (Attribute.Resolve): Add named argument type checking.
4723 * class.cs (FixedField.Define): Use IsPrimitiveType
4725 * expression.cs (Binary.ResolveOperator): Reflect IsCLRType renaming.
4727 * iterators.cs (Iterator.DefineIterator): Add check for arglist and
4728 unsafe parameter types.
4730 * statement.cs (Using.ResolveExpression): Add better error description.
4732 * typemanager.cs (IsCLRType): Renamed to IsPrimitiveType.
4734 2005-04-08 Raja R Harinath <rharinath@novell.com>
4737 * attribute.cs (Attribute.GetAttributeUsage): Resolve
4738 AttributeUsageAttribute in the emitcontext of the attribute class,
4739 not in the emitcontext of the attributable entity it was attached to.
4740 * cs-parser.jay: Use 'current_class', not 'current_container',
4741 when creating a GlobalAttribute.
4743 2005-04-08 Alp Toker <alp@atoker.com>
4745 * pending.cs: The fix to #58413 failed to compile methods implementing
4746 interfaces with/without params modifiers and vice versa, even though
4747 params modifiers aren't part of the signature. Make the modifier check
4748 less strict as in csc.
4750 2005-04-07 Abin Thomas <projectmonokochi@rediffmail.com>
4751 Anoob V E <projectmonokochi@rediffmail.com>
4752 Harilal P R <projectmonokochi@rediffmail.com>
4755 * pending.cs (TypeAndMethods.mods): New. Store the parameter
4756 modifiers of pending methods.
4757 (PendingImplementation.PendingImplementation): Initialize it.
4758 Add Parameter.Modifier [][] mods and initialize it with ParameterData.
4759 (PendingImplementation.InterFaceMethod): Repalce Type[] argument
4760 with ParameterData. Add check for modifiers.
4761 * class.cs (MethodData.Define): Update to changes.
4763 2005-04-07 Raja R Harinath <rharinath@novell.com>
4765 * ecore.cs (Expression.IsAccessorAccessible): Clarify code somewhat.
4767 2005-04-07 Marek Safar <marek.safar@seznam.cz>
4769 * class.cs (PropertyMethod.Define): Check private accessor in abstract
4772 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't allow RequiredAttribute
4775 * typemanager.cs: Registered RequiredAttributeAttribute.
4777 2005-04-06 Marek Safar <marek.safar@seznam.cz>
4779 * class.cs (VerifyMembers): Doesn't need EmitContext argument.
4780 Warning CS0169 is back at level 3.
4781 (IMethodData.SetMemberIsUsed): New method.
4783 * decl.cs (IsUsed): New value; moved from FieldBase.Status
4784 (SetMemberIsUsed, IsUsed): New methods, encapsulate IsUsed.
4786 * delegate.cs (ResolveMethodGroupExpr): Call SetMemberIsUsed.
4788 * ecore.cs (FieldExpr.ResolveMemberAccess): Call SetMemberIsUsed for
4790 (PropertyExpr.ResolveAccessors): Call SetMemberIsUsed when delegate
4793 * expression.cs (OverloadResolve): Call SetMemberIsUsed. when method
4796 * rootcontext.cs (RootContext.EmitCode): Call VerifyMembers in extra run
4797 to avoid the problems with nested types.
4799 2005-04-05 Abin Thomas <projectmonokochi@rediffmail.com>
4800 Anoob V.E <projectmonokochi@rediffmail.com>
4801 Harilal P.R <projectmonokochi@rediffmail.com>
4802 Raja R Harinath <rharinath@novell.com>
4805 * delegate.cs (Define): Emit ParamArrayAttribute for 'params'
4807 * typemanager (GetConstructor): Make public.
4809 2005-04-05 John Luke <john.luke@gmail.com>
4810 Raja R Harinath <rharinath@novell.com>
4813 * typemanager.cs (IsUnmanagedType): Check non-public fields of a
4814 struct too. Return false quicker in a few cases.
4815 (VerifyUnManaged): Use it.
4817 2005-04-05 Raja R Harinath <rharinath@novell.com>
4820 * statement.cs (Block.Resolve): Initialize 'unreachable' to false,
4821 not 'unreachable_seen'.
4823 2005-04-04 Marek Safar <marek.safar@seznam.cz>
4825 * attribute.cs (Attribute.GetValue): Removed unused.
4827 * codegen.cs (CodeGen.TrimExt): Removed unused.
4829 * cs-parser.jay (output): Removed unused.
4831 * cs-tokenizer.cs (hex_digits): Removed unused.
4833 * enum.cs (MapToInternalType, GetEnumeratorName): Removed unused.
4835 * expression.cs (Indirection.LoadExprValue): Removed unused.
4836 (ArrayCreation.ExpressionToArrayArgument): Removed unused.
4838 * iterators.cs (Iterator.param_types): Removed unused.
4840 * statement.cs (Goto.block): Removed unused.
4841 (ToplevelBlock.did): Removed unused.
4842 (Switch.ResolveConstantSwitch): Removed unused.
4844 2005-04-01 Ben Maurer <bmaurer@ximian.com>
4846 * rootcontext.cs: Allow mcs to bootstrap with the compilation
4849 2005-04-19 Martin Baulig <martin@ximian.com>
4851 Merged r42462 from MCS and made it work for GMCS.
4853 * class.cs (MethodCore.ds): Moved this field to `MemberBase'.
4855 * generic.cs (GenericMethod.Define): Removed `return_type' argument.
4857 2005-04-01 Raja R Harinath <rharinath@novell.com>
4859 Fix #74232 and cs0208-3.cs.
4860 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0208 check.
4861 * typemanager.cs (IsUnmanagedType): Don't allow 'object' as an
4862 unmanaged type. Don't use FieldBuilders when 't' is a
4863 TypeBuilder. Use ModFlags and MemberType fields.
4864 * class.cs (MemberBase.member_type): Rename from MemberType.
4865 (MemberBase.MemberType): New property. Determines member_type on
4867 (MemberBase.DoDefine): Don't initialize MemberType here.
4868 (FieldMember.Define): Likewise.
4870 2005-04-01 Marek Safar <marek.safar@seznam.cz>
4873 * class.cs (Event.Emit): Call Add/Remove emit even for interfaces.
4874 Attributes are emitted there.
4876 2005-04-01 Raja R Harinath <rharinath@novell.com>
4878 * cs-tokenizer.cs (consume_identifier): Treat 'partial' as a
4879 keyword in 'partial enum' too.
4880 * cs-parser.jay (enum_declaration): Add CS0267 check ('partial enum'
4882 Report from Kamil Skalski <nazgul@omega.pl>.
4885 * rootcontext.cs (ResolveTree): The 'root.Interfaces' list can
4886 have partial containers too.
4888 * ecore.cs (SimpleName.SimpleNameResolve): Move 'invariant meaning
4889 in block' checks to Block.CheckInvariantMeaningInBlock.
4890 * statement.cs (Block.GetKnownVariableInfo): Make private.
4891 (Block.IsVariableUsedInChildBlock): Remove.
4892 (Block.IsVariableUsedInBlock): Likewise.
4893 (Block.CheckInvariantMeaningInBlock): New. Show location of
4894 conflicting declaration.
4895 (Block.AddVariable): Make error messages less long-winded and more
4896 specific. Show location of conflicting declaration.
4897 * parameter.cs (Parameters.Location): New readonly property.
4899 2005-03-31 Raja R Harinath <rharinath@novell.com>
4901 Clean up semantics of invoking ResolveMemberAccess.
4902 * ecore.cs (SimpleName.DoSimpleNameResolve): If a MemberExpression
4903 can have an instance, ensure that we pass in a non-TypeExpression
4904 to ResolveMemberAccess. Tighten up IdenticalNameAndTypeName checks.
4905 (MemberExpr.DoSimpleNameResolve): Remove type_is_inferred
4906 argument. Update to changes and simplify.
4907 (FieldExpr.Emitinstance): Remove CS0120 check.
4908 (PropertyExpr.EmitInstance): Likewise.
4909 * expression.cs (Argument.Resolve): Likewise.
4910 (Invocation.DoResolve): Update to changes in semantics of
4913 2005-03-31 Marek Safar <marek.safar@seznam.cz>
4916 * class.cs (AbstractPropertyEventMethod.EmitMethod): Enable emit method
4919 * decl.cs (MemberCache.AddMethods): Fix infinite loop.
4921 2005-03-31 Raja R Harinath <rharinath@novell.com>
4923 Fix difference in behaviour with commandline invocation.
4924 * driver.cs (Driver.Reset): New.
4925 (CompilerCallableEntryPoint): Call it.
4927 * statement.cs (If.Resolve): Avoid spurious "uninitialized
4928 variable" warnings if the boolean expression failed to resolve.
4930 2005-03-30 Sebastien Pouliot <sebastien@ximian.com>
4932 * attribute.cs: Fix the union of several permissions when some of them
4933 are unrestricted (so the result isn't an unrestricted permission set).
4936 2005-03-30 Raja R Harinath <rharinath@novell.com>
4938 * ecore.cs (MemberExpr): New class. Convert from interface
4940 (MemberExpr.ResolveMemberAccess): Refactor and move here from
4941 MemberAccess.ResolveMemberAccess. Tighten up pre-conditions and
4943 (MethodGroupExpr, FieldExpr, PropertyExpr, EventExpr): Update.
4944 (MethodGroupExpr.IsExplicitImpl): Remove.
4945 (Expression.GetFieldFromEvent): Remove.
4946 (SimpleName.MemberStaticCheck): Remove.
4947 (SimpleName.DoSimpleNameResolve): Update to changes.
4948 * expression.cs (MemberAccess.ResolveMemberAccess): Refactor.
4949 (MemberAccess.IdenticalNameAndTypeName): Remove.
4950 (MemberAccess.error176): Move to MemberExpr.
4951 (MemberAccess.DoResolve): Update to changes.
4952 (BaseAccess.DoResolve): Likewise.
4954 2005-03-30 Marek Safar <marek.safar@seznam.cz>
4956 C# 2.0 Conditional attribute class implementation
4958 * attribute.cs (AttributeTester.IsAttributeExcluded): New method.
4959 Analyzes class whether it has attribute which has ConditionalAttribute
4960 and its condition is not defined.
4962 * class.cs (Class.ApplyAttributeBuilder): Add IsAttributeExcluded check.
4963 (Class.IsExcluded): New method. Search for at least one defined
4964 condition in ConditionalAttribute of attribute class.
4966 2005-03-30 Raja R Harinath <rharinath@novell.com>
4968 * ecore.cs (PropertyExpr): Derive from Expression, not
4969 ExpressionStatement.
4970 (PropertyExpr.EmitStatement): Remove.
4972 2005-03-29 Raja R Harinath <rharinath@novell.com>
4975 * expression.cs (MemberAccess.ResolveMemberAccess): Allow the
4976 internal field "value__" of an enum be private. The examples for
4977 "value__" that I found on MSDN all used FieldAttributes.Private.
4979 * decl.cs (MemberCache.AddMethods): Use C# terminology in warning.
4980 Don't mention IL method attribute names.
4982 Fix #47991. Remove a TODO.
4983 * statement.cs (Block.Toplevel): Make into a field.
4984 (Block.Parameters): Move into ToplevelBlock.
4985 (Block.known_variables): Rename from child_variable_names.
4986 (Block.Block): Remove variants that take Parameters. Initialize
4987 'Toplevel' with the immediately surrounding toplevel block.
4988 (Block.AddKnownVariable): Rename from AddChildVariableName. Add a
4989 LocalInfo parameter.
4990 (Block.GetKnownVariableInfo): New.
4991 (Block.IsVariableNameUsedInChildBlock): Update.
4992 (Block.IsVariableNameUsedInBlock): New. Checks if a name is used in
4993 the block, even though it may not be in scope.
4994 (Block.AddVariable): Remove Parameters parameter. Use
4995 Toplevel.Parameters instead.
4996 (Block.AddConstant): Remove Parameters parameter.
4997 (Block.GetParameterReference): Update to use Toplevel.Parameters.
4998 (Block.IsParamaterReference): Likewise.
4999 (Block.IsLocalParameter): Likewise. Simplify a lot.
5000 (ToplevelBlock.Parameters): New. Moved from Block.
5001 (ToplevelBlock.ToplevelBlock): Update to changes. Always
5002 initialize Parameters to a non-null value.
5003 * cs-parser.jay: Update to changes.
5004 * ecore.cs (SimpleName.SimpleNameResolve): Emit cs0136 error for
5005 simple names that mean different things in the same block. Use
5006 Block.IsVariableNameUsedInBlock.
5008 2005-03-28 Raja R Harinath <rharinath@novell.com>
5010 * enum.cs (Enum.LookupEnumValue): Remove debugging code.
5012 2005-03-26 Raja R Harinath <harinath@acm.org>
5015 * assign.cs (Assign.DoResolve): When the RHS of an assignment
5016 fails to resolve, ensure that the LHS is still resolved as an
5019 2005-03-25 Raja R Harinath <harinath@acm.org>
5021 * enum.cs (Enum.DefineType): Set ec.InEnumContext and
5023 (Enum.current_ec): Remove.
5024 (Enum.LookupEnumValue): Remove EmitContext argument.
5025 Just uses the one created during DefineType.
5026 (Enum.FindMembers): Update.
5027 * expression.cs (MemberAccess.DoResolve): Update.
5029 2005-03-22 Marek Safar <marek.safar@seznam.cz>
5031 * assign.cs (Assign.DoResolve): Check for CS1717 when
5032 source and target are same (uses Equals).
5034 * expression.cs (LocalVariableReference, ParameterReference,
5035 This): Implemented Equals, GetHashCode.
5037 * statement.cs (Block.GetParameterReference): Removed useless
5040 2005-03-22 Raja R Harinath <rharinath@novell.com>
5043 * statement.cs (Block.AddVariable): Ensure that we skip implicit
5044 blocks before deciding whether the error is cs0136 or cs0128.
5046 * cs-parser.jay: Pass MemberName to RootContext.Tree.RecordDecl.
5047 (using_alias_directive, using_namespace_directive): Pass
5048 MemberName, not an expression to Namespace.UsingAlias and
5050 (MakeName): Use the MemberName of the namespace.
5051 * namespace.cs (Namespace.MemberName): New.
5052 (UsingEntry.UsingEntry): Take a MemberName, not an expression.
5053 (AliasEntry.AliasEntry, Namespace.Using, Namespace.UsingAlias):
5055 * decl.cs (MemberName.Name): Make readonly.
5056 (MemberName.FromDotted): New "constructor".
5057 (MemberName.Equals, MemberName.GetHashCode): Implement overrides.
5058 (MemberCore.Name): Compute from MemberName on demand.
5059 (MemberCore.SetMemberName): Provide a way to change the
5061 (MemberCore.AddToContainer): Don't take a fullname parameter.
5062 * class.cs (TypeContainer.AddToMemberContainer): Don't add the
5063 fully qualified name of the container to the member name.
5064 (TypeContainer.AddToTypeContainer): Use a fully qualified name
5065 only if the type is a member of the root container.
5066 (TypeContainer.AddMethod, TypeContainer.AddProperty): Use
5067 MemberName.Left rather than searching for an embedded ".".
5068 (PartialContainer.CreatePart): Update to changes in RootContext.
5069 (MemberBase.ShortName): Turn into a property. Use
5070 MemberCore.SetMemberName.
5071 (MemberBase.ExplicitInterfaceName): Remove.
5072 (MemberBase.UpdateMemberName): Remove.
5073 (AbstractPropertyEventMethod.UpdateName): Use SetMemberName.
5074 (PropertyBase.SetMemberName): New override.
5075 * tree.cs (Tree.RecordDecl): Take a MemberName and use it as hash key.
5076 (Tree.GetDecl): New.
5077 (Tree.AllDecls): Rename from Decls.
5078 * attribute.cs, enum.cs, report.cs: Update to changes.
5079 * driver.cs (MainDriver): Use MemberName.FromDotted on
5080 RootContext.MainClass.
5082 2005-03-21 Marek Safar <marek.safar@seznam.cz>
5084 * class.cs (FixedField.Define): Check for CS1664 and more sanity
5087 * expression.cs (ElementAccess.DoResolveLValue): Check for CS1708.
5089 2005-03-18 Marek Safar <marek.safar@seznam.cz>
5091 * modifiers.cs (Modifiers.PROPERTY_CUSTOM): New constant for
5092 property accessor modifiers.
5094 * class.cs (FieldMember.ApplyAttributeBuilder): Don't allow apply
5095 fixed buffer attribute (CS1716).
5096 (PropertyMethod.HasCustomAccessModifier): When property accessor
5097 has custom modifier.
5099 * ecore (PropertyExpr.DoResolve): Add CS0271 for custom accessor
5101 (PropertyExpr.DoResolveLValue): Add CS0272.
5103 2005-03-17 Miguel de Icaza <miguel@novell.com>
5105 * convert.cs: When converting to a pointer, use the proper Conv.U
5106 or Conv.I depending on the source data type.
5108 * cs-tokenizer.cs: Make the size for large decimal constants,
5111 2005-03-17 Martin Baulig <martin@ximian.com>
5113 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
5114 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
5116 2005-03-17 Martin Baulig <martin@ximian.com>
5118 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
5119 to bool so we can return an error condition.
5120 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
5123 2005-03-16 Zoltan Varga <vargaz@freemail.hu>
5125 * attribute.cs: Encode ThrowOnUnmappableChar and BestFitMapping
5128 2005-03-16 Raja R Harinath <rharinath@novell.com>
5130 Remove TypeManager.LookupType and TypeManager.LookupTypeDirect.
5131 Refactor to avoid traversing the list of assemblies, and to avoid
5132 string concatenation.
5133 * typemanager.cs (guid_attr_type): Remove.
5134 (negative_hits, pointers, references): Remove hashes.
5136 (GetConstructedType): New. Uses type_hash to handle constructed
5137 types (arrays, references, pointers).
5138 (GetReferenceType, GetPointerType): Use it.
5139 (GetNestedType): New. Uses type_hash to handle nested types of
5141 (LookupType, LookupTypeDirect): Remove.
5142 (CoreLookupType): Inline parts of old LookupTypeDirect code. Use
5143 'types' hash and LookupTypeReflection directly.
5144 (params_string, params_object): Use GetConstructedType.
5145 * namespace.cs (Namespace.cached_types): New. Cache of reflected
5147 (Namespace.Lookup): Use cached_types.
5148 (NamespaceEntry.LookupNamespaceOrType): Inline the functionality
5149 provided by old TypeManager.LookupType.
5150 * rootcontext.cs (MakeFQN): Remove.
5151 * decl.cs (DeclSpace.MakeFQN): Likewise.
5152 (DeclSpace.LookupType): Use TypeManager.GetNestedType.
5153 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
5154 TypeManager.GetConstructedType.
5155 * tree.cs (decl_ns_hash, LookupByNamespace): Remove.
5157 2005-04-16 Zoltan Varga <vargaz@freemail.hu>
5159 * cs-parser.jay: Fix build.
5161 2005-03-15 Marek Safar <marek.safar@seznam.cz>
5163 * class.cs (TypeContainer.CircularDepException) New nested
5164 (MethodCore.CheckBase): Report CS1715 for properties and indexers.
5166 * cs-parser.jay: Reports CS1527 for any namespace element.
5168 * delegate.cs (DelegateCreation.Error_NoMatchingMethodForDelegate):
5171 * expression.cs (ParameterReference.IsAssigned): Changed error to
5173 (Error_WrongNumArguments): Moved CS0245 detection here.
5175 * statement.cs (Return.Resolve): Add CS1622 report.
5177 2005-03-11 Marek Safar <marek.safar@seznam.cz>
5179 * class.cs (StaticClass.DefineContainerMembers): Added CS0720.
5181 2005-03-11 Zoltan Varga <vargaz@freemail.hu>
5183 * attribute.cs expression.cs: Get rid of some allocations.
5185 2004-03-11 Atsushi Enomoto <atsushi@ximian.com>
5187 * doc.cs : just eliminate the latest change.
5189 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
5191 * doc.cs : commented out the latest change. It breaks xml-030.cs
5193 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
5195 * doc.cs : When TypeBuilder did not create Type yet, GetEvents() will
5196 fail. So invoke CreateType() in FindDocumentedType().
5198 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
5200 * cs-tokenizer.cs : added IsKeyword().
5201 * doc.cs : Detect keyword incorrectly used as identifier.
5202 Allow identifiers prefixed by @.
5204 2005-03-10 Marek Safar <marek.safar@seznam.cz>
5206 * attributes.cs (Attributes.Emit): Continue after CheckTargets.
5207 It caused exception in namespace resolving (again!).
5209 * class.cs (Class.ctor): Removed exit.
5210 (PropertyMethod.ctor): ditto.
5212 * codegen.cs (Codegen.Reset): Reset static data.
5213 (Codegen.ResolveTopBlock): Forward error status from ResolveMeta.
5215 * cs-tokenizer.cs (Cleanup): Removed.
5217 * driver.cs (GetSystemDir): Rewrote to one line command.
5218 It caused problem with unloaded dynamic modules.
5219 (UnixParseOption): Removed Exit.
5220 (CompilerCallableEntryPoint.InvokeCompiler): Make static.
5221 (CompilerCallableEntryPoint.Reset): Reset suitable static data.
5222 Now can be mcs used as library.
5224 * ecore.cs (Expression.ResolveBoolean): Use Location.Null for
5227 * location.cs (Reset): Reset static data.
5229 * namespace.cs (Reset): Reset static data.
5231 * report.cs (Report.Reset): Reset static data.
5233 * rootcontext.cs (RootContext.Reset): Reset static data.
5235 * tree.cs (RootTypes.ctor): Use Location.Null
5237 * typemanager.cs (TypeManager.Reset): Reset static data.
5238 (CoreLookupType): Removed Exit.
5239 (TypeHandle.Reset): Reset static data.
5241 2005-03-10 Raja R Harinath <rharinath@novell.com>
5244 * typemanager.cs (ComputeNamespaces): Import namespaces from
5245 referenced modules too.
5247 2005-03-09 Raja R Harinath <rharinath@novell.com>
5249 * class.cs (TypeContainer.AddToMemberContainer): Use "." rather
5252 2005-03-09 Raja R Harinath <rharinath@novell.com>
5254 * decl.cs (DeclSpace.LookupType): Don't loop but recurse into
5255 enclosing DeclSpace. This ensures that a name-lookup populates
5256 more caches and there are fewer 'TypeExpression's. Carve out
5257 nested type lookup into ...
5258 (LookupNestedTypeInHierarchy): ... this.
5260 2005-04-15 Martin Baulig <martin@ximian.com>
5262 Merged r41590 from MCS and make it work in the generics land.
5264 * generic.cs (TypeParameter.UpdateConstraints): Removed the
5267 * class.cs (PartialContainer.UpdateConstraints): Removed.
5268 (PartialContainer.CheckConstraints): Removed.
5269 (PartialContainer.SetParameterInfo): Store the constraints here.
5270 (PartialContainer.DefineTypeParameters): New public method;
5271 resolve the type parameter's constraints here. Note that the
5272 PartialContainer doesn't have an EmitContext anymore, so we must
5273 do this in the ClassPart.
5275 2005-03-09 Raja R Harinath <rharinath@novell.com>
5277 Clean up a few partial-class semantics.
5278 Fixes test-357.cs and cs1618-2.cs.
5279 * cs-parser.jay (struct_declaration): Use 'current_class' as
5280 parent of newly-created struct. Remove call to Register ().
5281 Use 'pop_current_class' to complete handing the current struct.
5282 (interface_declaration): Likewise.
5283 (class_declaration): Likewise.
5284 (enum_declaration): Use 'current_class' as parent of newly created
5286 (delegate_declaration): Likewise.
5287 (pop_current_class): New function. This is used to handle closing
5288 up the 'current_class' and 'current_container', and pointing them
5289 to the enclosing class/container.
5290 (CSharpParser): Initialize 'current_class' too.
5291 * decl.cs (MemberCore): Add check for invariant: a partial
5292 container is not a parsed entity, and thus does not enclose any
5294 (DeclSpace.TypeResolveEmitContext): Expose 'type_resolve_ec'.
5295 (DeclSpace.BaseTypeExpr): Use it.
5296 (DeclSpace.LookupType): Add check for invariant.
5297 * class.cs (TypeContainer): Add check for invariant: a nested
5298 class should have the same NamespaceEntry as its enclosing class.
5299 (TypeContainer.EmitFieldInitializers): Make virtual.
5300 (TypeContainer.DefineDefaultConstructor): Adhere to invariant in
5302 (TypeContainer.Register): Remove.
5303 (TypeContainer.DefineType): Set the 'ec' of a PartialContainer to
5304 null. Use TypeResolveEmitContext for resolving base types and
5305 interfaces. Move initialization of Parts.TypeBuilder here from
5307 (TypeContainer.DefineNestedTypes): ... here.
5308 (PartialContainer): Take a Namespace not a NamespaceEntry.
5309 (PartialContainer.Create): Don't use Register. Call the
5310 appropriate Add... function directly.
5311 (ClassPart): Take both the PartialContainer and the enclosing
5312 class as constructor arguments.
5313 (ClassPart.EmitFieldInitializers): Override.
5314 (ClassPart.PartFindNestedTypes): Remove.
5315 (FieldBase.GetInitializerExpression): Resolve the initializer
5316 expression in the emit context of the enclosing class.
5317 * tree.cs (RootTypes): Remove Register ().
5319 2005-03-08 Marek Safar <marek.safar@seznam.cz>
5321 * cs-parser.jay: Removed CS0134.
5323 * driver.cs: Removed CS1901.
5325 * expression.cs (SizeOf.DoResolve): Don't report CS0233
5326 for predefined types.
5328 2005-03-07 Duncan Mak <duncan@novell.com>
5330 * codegen.cs (Save): Catch UnauthorizedAccessException as
5331 well. Fixes bug #73454.
5333 2005-03-07 Marek Safar <marek.safar@seznam.cz>
5335 * cs-tokenizer.cs (xtoken): Add CS1035.
5337 * class.cs (MethodData.Define): Add CS0683.
5338 (FieldMember.ctor): Add CS0681.
5340 2005-03-07 Raja R Harinath <rharinath@novell.com>
5342 * ecore.cs (SimpleName.DoResolve): Rename from
5343 SimpleName.DoResolveAllowStatic.
5344 (SimpleName.DoSimpleNameResolve): Remove 'allow_static' argument.
5345 Pass 'intermediate' flag to MemberStaticCheck.
5346 (SimpleName.MemberStaticCheck): Skip "static check" only in case
5347 of "intermediate" lookups via MemberAccess.
5348 (SimpleName.IdenticalNameAndTypeName): New. Carved out of ...
5349 * expression.cs (MemberAccess.IdenticalNameAndTypeName): ... this.
5351 2005-03-07 Raja R Harinath <rharinath@novell.com>
5354 * ecore.cs (FieldExpr.EmitInstance): Catch cases of CS0120 that
5355 slipped in because of variable names that are identical to a
5356 builtin type's BCL equivalent ('string String;', 'int Int32;').
5357 (PropertyExpr.EmitInstance): Likewise.
5359 2005-03-04 Marek Safar <marek.safar@seznam.cz>
5361 * cs-tokenizer.cs (PreProcessPragma): Add warning 1633, 1635.
5363 * report.cs (warning_ignore_table): Made public.
5365 2005-03-04 Raja R Harinath <rharinath@novell.com>
5368 * class.cs (MethodData.Emit): Pass 'container' to
5369 container.GetObsoleteAttribute instead of 'container.Parent'.
5371 2005-03-03 Marek Safar <marek.safar@seznam.cz>
5373 * cs-parser.jay: Add 1534 error test.
5375 * iterators.cs (Yield.CheckContext): Add error 1629.
5376 (Iterator.ctor): Save unsafe modifier.
5377 (MoveNextMethod.DoEmit): Restore unsafe context.
5379 * namespace.cs (UsingAlias): Better error message.
5381 2005-03-03 Dan Winship <danw@novell.com>
5383 * convert.cs (Error_CannotImplicitConversion): fix two bugs in
5384 the warning message [#73219]
5386 2005-03-03 Raja R Harinath <rharinath@novell.com>
5388 Fix compile with MCS 1.0.0.0.
5389 * cs-tokenizer.cs (PreProcessPragma): Simplify w_disable and
5390 w_restore to not depend on string constant folding.
5392 2005-03-03 Raja R Harinath <rharinath@novell.com>
5394 * decl.cs (DeclSpace.LookupType): Remove 'silent' argument. Move
5395 CS0246 check to users who passed 'silent = false'.
5396 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): Add CS0246
5398 (SimpleName.SimpleNameResolve): Update.
5399 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0246 check.
5400 (MemberAccess.IdenticalNameAndTypeName): Update.
5401 * doc.cs (FindDocumentedTypeNonArray): Update.
5403 2005-03-03 Raja R Harinath <rharinath@novell.com>
5405 * codegen.cs (EmitContext): Remove ResolvingTypeTree.
5406 * parameters.cs (ComputeAndDefineParameters): Remove.
5407 * decl.cs (ResolveBaseTypeExpr): Don't set ResolvingTypeTree.
5408 * delegate.cs (Define): Don't invoke ComputeAndDefineParameters.
5409 Use GetParameterInfo.
5411 2005-03-02 Marek Safar <marek.safar@seznam.cz>
5413 * report.cs (StaticClass.DefineContainerMembers): Add warning 628.
5415 2005-03-02 Raja R Harinath <rharinath@novell.com>
5417 Unify DeclSpace.LookupType and DeclSpace.FindType.
5418 * decl.cs (DeclSpace.FindNestedType): New virtual function. This
5419 is in charge of defining nested types on demand.
5420 (DeclSpace.LookupType): Use it when the current_type is a
5421 TypeBuilder. Use LookupTypeDirect for reflected types.
5422 (DeclSpace.FindType): Remove.
5423 (DeclSpace.LookupInterfaceOrClass): Likewise.
5424 (DeclSpace.DefineTypeAndParents): Likewise.
5425 * ecore.cs (SimpleName.ResolveAsTypeStep): Just call
5426 DeclSpace.LookupType.
5427 * doc.cs (FindDocumentedTypeNonArray): Use DeclSpace.LookupType.
5428 * typemanager.cs (LookupType): Simplify.
5429 (AddUserType): Remove type from negative_hits.
5430 * namespace.cs (Namespace.Lookup): Use TypeManager.LookupTypeDirect.
5431 * class.cs (TypeContainer.FindMembers): Move handling of nested
5433 (TypeContainer.FindMembers_NestedTypes): ... here.
5434 (TypeContainer.FindNestedType): Implement override.
5435 (ClassPart.FindNestedType): Delegate to PartialContainer.
5436 (ClassPart.PartFindNestedType): Looks up the nested types of the
5439 2005-04-14 Martin Baulig <martin@ximian.com>
5441 * generic.cs (ConstructedType): Moved all the type lookup and
5442 nested class logic into SimpleName.
5443 (ConstructedType.ResolveConstructedType): Our underlying type is
5444 already fully resolved; all the type lookup stuff is in
5447 * ecore.cs (SimpleName.ResolveAsTypeStep): Resolve nested
5448 constructed types here instead of in ConstructedType.
5450 * decl.cs (MemberName.GetTypeExpression): Always create a
5451 SimpleName, not a ConstructedType.
5452 (DeclSpace.ResolveNestedType): Removed; this is now in SimpleName.
5454 2005-03-02 Martin Baulig <martin@ximian.com>
5456 * class.cs (TypeContainer.DoDefineMembers): We also need a default
5457 static constructor in static classes.
5459 2005-03-01 Zoltan Varga <vargaz@freemail.hu>
5461 * attribute.cs: Pass -1 to DefineLPArrayInternal if sizeConst or
5462 sizeParamIndex is not specified.
5464 2005-03-01 Marek Safar <marek.safar@seznam.cz>
5467 * report.cs (WarningMessage.IsEnabled): Missing null check.
5469 2005-02-28 Marek Safar <marek.safar@seznam.cz>
5471 * attribute.cs (DefinePInvokeMethod): Fix, all data are stored
5472 in the fields and not in the properties.
5474 2005-02-28 Zoltan Varga <vargaz@freemail.hu>
5476 * attribute.cs (GetMarshal): Marshal SizeConst and SizeParamIndex
5479 2005-02-28 Marek Safar <marek.safar@seznam.cz>
5481 * attribute.cs: Small refactoring (improved robustness).
5482 (ImplOptions, UnmanagedType, UsageAttribute): Removed members.
5483 (ValidateGuid): Removed.
5484 (Resolve): Removed referenced to above mentioned.
5485 (GetAttributeUsage): Made private and changed to work without
5487 (GetIndexerAttributeValue): Don't crash.
5488 (GetConditionalAttributeValue): Ditto.
5489 (GetClsCompliantAttributeValue): Ditto.
5490 (ExtractSecurityPermissionSet): All attributes exceptions are
5492 (GetPropertyValue): New helper.
5493 (GetMethodImplOptions): New method.
5494 (DefinePInvokeMethod): Reuse common code. Implemented handling of
5495 some missing properties.
5497 * class.cs (ClassOrStruct.ApplyAttributeBuilder): Updated.
5498 (Method.ApplyAttributeBuilder): Updated.
5500 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't catch shared
5503 2005-02-28 Raja R Harinath <rharinath@novell.com>
5506 * report.cs (Report.SymbolRelatedToPreviousError): Handle
5507 non-simple types (array, pointer, reference).
5509 2005-02-28 Marek Safar <marek.safar@seznam.cz>
5511 * cs-parser.jay: Add errors 1617, 650, 1007, 531, 547, 548
5513 * class.cs (MethodCore.IsDuplicateImplementation): Special error
5515 (Method.CheckBase): Catch wrong destructor here.
5516 (MethodData.Define): Add errors 550, 668.
5518 * cs-tokenizer.cs (PreProcessPragma): Add warning 1634.
5520 * ecore.cs (PropertyExpr.DoResolveLValue): Fixed wrong error code.
5522 * pending.cs (VerifyPendingMethods): Add error 551.
5524 * typemanager.cs (CSharpName): Next error report helper.
5526 2005-02-25 Marek Safar <marek.safar@seznam.cz>
5528 * attribute.cs (Atttribute.Resolve): Add cache for parameter-less
5529 attributes. Removed useless attribute double check.
5530 It saves almost 2MBs for corlib.
5532 2005-02-25 Raja R Harinath <rharinath@novell.com>
5535 * statement.cs (ExpressionStatement.Resolve): Make robust to being
5536 called twice in case of error.
5538 2005-02-23 Chris Toshok <toshok@ximian.com>
5540 Fix compiler portions of #72827.
5541 * statement.cs (Block.Emit): call Begin/EndScope on the
5542 EmitContext instead of the ILGenerator.
5544 * codegen.cs (EmitContext.BeginScope): new method, call
5545 ILGenerator.BeginScope as well as the SymbolWriter's OpenScope (if
5547 (EmitContext.BeginScope): same, but EndScope and CloseScope
5549 * symbolwriter.cs (SymbolWriter.OpenScope): get the current il
5550 offset and call the superclass's OpenScope(int) with it.
5551 (SymbolWriter.CloseScope): get the current il
5552 offset and call superclass's CloseScope(int) with it.
5554 2005-02-23 Marek Safar <marek.safar@seznam.cz>
5556 * anonymous.cs (AnonymousMethod.Compatible): Fixed to report
5557 CS1677 for out and ref as well.
5559 * class.cs (Method.Define): Add error CS1599 detection.
5561 * cs-parser.jay: Add CS1609, CS1670, CS1627 detection.
5563 * cs-tokenizer.cs (xtoken): Add error CS1646 detection.
5565 * delegate.cs (Delegate.Define): Add error CS1599 detection.
5567 * support.cs.cs (ModifierDesc): New helper method.
5569 2005-02-23 Raja R Harinath <rharinath@novell.com>
5570 Abin Thomas <projectmonokochi@rediffmail.com>
5571 Anoob V E <projectmonokochi@rediffmail.com>
5572 Harilal P R <projectmonokochi@rediffmail.com>
5575 * class.cs (ConstructorBuilder.Resolve): Make sure that the second
5576 MemberLookup (used for error reporting) actually returns a result.
5577 Fix error report number (122, not 112).
5579 2005-02-22 Abin Thomas <projectmonokochi@rediffmail.com>
5580 Anoob V E <projectmonokochi@rediffmail.com>
5581 Harilal P R <projectmonokochi@rediffmail.com>
5584 * pending.cs (PendingImplementation.GetAbstractMethods):
5585 Find NonPublic members too.
5587 2005-02-22 Marek Safar <marek.safar@seznam.cz>
5589 * expression.cs.cs (ConditionalLogicalOperator.DoResolve):
5592 * class.cs (MethodCore.CheckMethodAgainstBase):
5593 Add error 239 report.
5595 2005-02-21 Marek Safar <marek.safar@seznam.cz>
5597 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
5599 * class.cs (Operator.Define): Add error 217 report.
5601 2005-02-21 Raja R Harinath <rharinath@novell.com>
5604 * expression.cs (Invocation.IsApplicable): Make public.
5605 (Invocation.IsParamsMethodApplicable): Likewise.
5606 * delegate.cs (Delegate.VerifyApplicability): Don't use
5607 Invocation.VerifyArgumentCompat for parameter applicability
5608 testing. Use Invocation.IsApplicable and
5609 Invocation.IsParamsMethodApplicable.
5611 2005-02-21 Marek Safar <marek.safar@seznam.cz>
5613 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
5615 * class.cs (Operator.Define): Add error 217 report.
5617 2005-02-21 Raja R Harinath <rharinath@novell.com>
5619 * namespace.cs (UsingEntry.Resolve): Undo change below.
5621 2005-02-21 Raja R Harinath <rharinath@novell.com>
5624 * ecore.cs (Expression.MemberLookupFailed): Add argument to
5625 disable the error message when the extended MemberLookup also
5627 (Expression.MemberLookupFinal): Update.
5628 (SimpleName.DoSimpleNameResolve): Update.
5629 * expression.cs (MemberAccess.ResolveNamespaceOrType):
5630 Don't use MemberLookupFinal.
5631 (New.DoResolve): Update.
5632 (BaseAccess.CommonResolve): Update.
5634 2005-02-21 Raja R Harinath <rharinath@novell.com>
5637 * attribute.cs (Attribute.ResolveType): If a 'resolve_error' had
5638 occured previously, don't resolve again.
5640 2005-02-21 Marek Safar <marek.safar@seznam.cz>
5643 * attribute.cs (Attribute.GetAttributeUsage): Add EmitContext
5644 argument. Call ResolveAttributeUsage for unresolved.
5645 when types doesn't match ctor arguments.
5647 * class.cs (DoDefineMembers.TypeContainer): Removed safety check
5648 for nested attribute classes.
5649 (Class.attribute_usage): Removed.
5650 (Class.ResolveAttributeUsage): Resolves AttributeUsageAttribute
5651 for attribute class.
5653 * ecore.cs (IsAttribute): Removed.
5655 * namespace.cs (UsingEntry.Resolve): Don't destroy NamespaceEntry.
5657 * rootcontext.cs (RegisterAttribute): Removed, attributes are
5659 (attribute_types): Removed.
5660 (EmitCode): Global attributes are emited as the latest.
5662 2005-02-18 Marek Safar <marek.safar@seznam.cz>
5664 * class.cs (EmitFieldInitializers): Don't emit field initializer
5665 for default values when optimilization is on.
5667 * constant.cs (Constant.IsDefaultValue): New property.
5669 * driver.cs: Add /optimize handling.
5673 * literal.cs: Implement new IsDefaultValue property.
5675 * rootcontext.cs (Optimize): New field, holds /optimize option.
5677 2005-02-18 Raja R Harinath <rharinath@novell.com>
5679 Fix crasher in re-opened #72347.
5680 * namespace.cs (Namespace.Lookup): Return null if
5681 DeclSpace.DefineType returns null.
5684 * expression.cs (Argument.Resolve): Handle a case of CS0120 here.
5686 2005-02-18 Raja R Harinath <rharinath@novell.com>
5688 Fix remainder of #63202. Change semantics of DoResolveLValue: it
5689 now returns null if it cannot resolve to an lvalue.
5690 * ecore.cs (Expression.DoResolveLValue): Return 'null' by default.
5691 (Expression.ResolveLValue): Emit CS0131 error if DoResolveLValue
5692 returned null. Remove check for SimpleName.
5693 (EventExpr.DoResolveLValue): New.
5694 * iterators.cs (Iterator.FieldExpression.DoResolveLValue): New.
5695 * expression.cs (Argument.Error_LValueRequired): New. Move CS1510
5697 (Argument.Resolve): ... here. Use it. Use DoResolveLValue to
5699 (Unary.ResolveOperator): Move CS0211 check ...
5700 (Unary.DoResolve): ... here. Use DoResolveLValue to avoid
5702 (Unary.DoResolveLValue): Simplify.
5703 (AddressOf.DoResolveLValue): New.
5704 (ArrayAccess.DoResolveLValue): New.
5706 2005-02-16 Marek Safar <marek.safar@seznam.cz>
5708 * attribute.cs (Attribute.Resolve): Add arguments casting for
5709 when types doesn't match ctor arguments.
5711 2005-02-16 Raja R Harinath <rharinath@novell.com>
5713 Fix parts of #63202.
5714 * expression.cs (UnaryMutator.ResolveOperator): Remove redundant
5715 lookup of operator in base type. Ensure that all checks happen
5716 when the operator resolves to an "op_..." method.
5718 2005-02-15 Raja R Harinath <rharinath@novell.com>
5721 * namespace.cs (NamespaceEntry.LookupNamespaceOrType): Add
5722 'ignore_cs0104' parameter. Pass it to ...
5723 (NamespaceEntry.Lookup): ... this.
5724 * decl.cs (DeclSpace.LookupType): Add 'ignore_cs0104' parameter.
5725 * ecore.cs (SimpleName.ResolveAsTypeStep): Update.
5726 (TypeLookupExpression.DoResolveAsTypeStep): Update.
5727 * expression.cs (MemberAccess.IdenticalNameAndTypeName):
5728 Update. Request that cs0104 errors be ignored.
5729 (ComposedCast.ResolveAsTypeStep): Update.
5731 2005-02-14 Raja R Harinath <rharinath@novell.com>
5734 * expression.cs (Invocation.BetterFunction): Remove support for
5735 comparing virtual functions and their overrides.
5736 (Invocation.IsOverride): New.
5737 (Invocation.OverloadResolve): Don't consider 'override' functions
5738 during candidate selection. Store them in a lookaside list.
5739 If the selected method is a 'virtual' function, use the list to
5740 find any overrides that are closer to the LHS type.
5742 2005-02-14 Marek Safar <marek.safar@seznam.cz>
5744 * expression.cs (New.DoResolve): Add complex core type reduction.
5745 (New.Constantify): Converts complex core type syntax like 'new int ()'
5748 2005-02-14 Raja R Harinath <rharinath@novell.com>
5750 * decl.cs (EntryType.EntryType): New constructor to create an
5751 updated copy of a cache entry.
5752 (MemberCache.AddMethods): Use it.
5753 (MemberCache.ClearDeclaredOnly): Remove.
5754 (MemberCache.MemberCache): Update.
5756 2005-02-11 Miguel de Icaza <miguel@novell.com>
5758 * codegen.cs (EmitContext): Introduce the `MethodIsStatic'
5759 variable. This one is represents the actual low-level declaration
5760 of the method, as opposed to the semantic level `IsStatic'.
5762 An anonymous method which is hosted into a static method might be
5763 actually an instance method. IsStatic would reflect the
5764 container, while MethodIsStatic represents the actual code
5767 * expression.cs (ParameterReference): Use the new MethodIsStatic
5768 instead of IsStatic.
5770 * anonymous.cs (AnonymousMethod.Compatible): Pass the
5771 Modifiers.STATIC to the Anonymous' Method EmitContext if static is
5772 set on the current EmitContext.
5774 * expression.cs (Cast): Overload DoResolveLValue so we can pass
5775 resolve our casted expression as an LValue. This triggers the
5776 proper LValue processing that is later required by Assign.
5780 * cs-tokenizer.cs (pp_and): recurse on pp_and, fixes #61903.
5782 2005-02-11 Marek Safar <marek.safar@seznam.cz>
5784 C# 2.0 Fixed buffer implementation
5786 * anonymous.cs: Update after RegisterHelperClass renaming.
5788 * attribute.cs (AttributeTester.fixed_buffer_cache):
5789 Cache of external fixed buffers.
5790 (AttributeTester.GetFixedBuffer): Returns IFixedBuffer
5791 implementation if field is fixed buffer else null.
5794 (TypeContainer.AddField): Accept FieldMember instead of Field.
5795 (FieldBase.IsFieldClsCompliant): Extracted code from
5796 VerifyClsCompliance descendant customization.
5797 (FixedField): New class handles fixed buffer fields.
5798 (FixedFieldExternal): Keeps information about imported fixed
5800 (IFixedField): Make access to internal or external fixed buffer
5803 * cs-parser.jay: Add fixed buffer parsing.
5805 * ecore.cs (FieldExpr.Emit): Add special emit case for fixed
5808 * expression.cs (Indirection): Extended implementation to accept
5810 (PointerArithmetic.Emit): Get element from fixed buffer as well.
5811 (ElementAccess.MakePointerAccess): Get type as parameter.
5812 (DoResolve): Add fixed buffer field expression conversion.
5813 (DoResolveLValue): Ditto.
5814 (FixedBufferPtr): New class. Moved most of original ArrayPtr.
5815 (ArrayPtr): Derives from FixedBufferPtr.
5816 (ArrayPtr.Emit): Add extra emit for array elements.
5818 * flowanalysis.cs.cs (StructInfo): Use FieldMember.
5820 * rootcontext.cs (CloseTypes): Emit CompilerGenerated attribute
5821 for compiler generated types.
5822 (RegisterCompilerGeneratedType): Renamed from RegisterHelperClass.
5824 * statement.cs (Fixed): Refactored to be easier add fixed buffer
5825 and consume less memory.
5826 (Fixed.Resolve): Add fixed buffer case.
5828 * typemanager.cs (compiler_generated_attr_ctor,
5829 fixed_buffer_attr_ctor): Add new 2.0 compiler attributes.
5830 (HasElementType): Add our own implementation to work on every
5833 2005-02-11 Miguel de Icaza <miguel@novell.com>
5835 * anonymous.cs (CaptureContext): Track whether `this' has been
5838 * expression.cs (This.ResolveBase): Call CaptureThis. Before we
5839 only captured `this' if it was implicitly done (instance
5840 methods/variables were used).
5842 * codegen.cs (EmitContext.CaptureThis): New method to flag that
5843 `this' must be captured.
5845 2005-01-30 Miguel de Icaza <miguel@novell.com>
5847 * anonymous.cs (CreateMethodHost): If there Scope.ScopeTypeBuilder
5848 is null it means that there has been no need to capture anything,
5849 so we just create a sibling.
5851 Renamed `EmitHelperClasses' to `EmitAnonymousHelperClasses'
5853 Just a partial fix. The other half is fairly elusive.
5855 2005-02-10 Raja R Harinath <rharinath@novell.com>
5857 Fix #52586, cs0121-4.cs.
5858 * decl.cs (MemberCache.DeepCopy): Rename from SetupCache. Take
5859 and return a hashtable.
5860 (MemberCache.ClearDeclaredOnly): New.
5861 (MemberCache.MemberCache): Update to change. Make a deep copy of
5862 the method_hash of a base type too.
5863 (MemberCache.AddMethods): Adapt to having a deep copy of the base
5864 type methods. Overwrite entries with the same MethodHandle so
5865 that the ReflectedType is correct. The process leaves in base
5866 virtual functions and their overrides as distinct entries.
5867 (CacheEntry): Now a class instead of a struct. It shouldn't alter
5868 matters since it was boxed in a ArrayList before.
5869 (CacheEntry.Member, CacheEntry.EntryType): Remove 'readonly'
5871 * expression.cs (Invocation.BetterFunction): Simplify. Handle the
5872 case of a virtual function and its override (choose the overload
5874 (Invocation.OverloadResolve): Avoid 'override' members during
5875 'applicable_type' calculation.
5877 2005-03-28 Raja R Harinath <rharinath@novell.com>
5879 * typemanager.cs (TypeHandle.BaseType): Make into an IMemberContainer.
5880 (TypeHandle.TypeHandle): Use LookupMemberCache rather than
5881 GetTypeHandle. It is possible for a reflected type to derive from
5882 a TypeBuilder (e.g., int[] derives from the TypeBuilder
5883 System.Array during mscorlib compilation).
5884 * decl.cs (MemberCache.MemberCache): If the base cache doesn't
5885 contain a method_hash, don't create one either. Don't create a
5886 deep copy of the base cache's method_hash.
5887 (MemberCache.SetupCache): Rename back from DeepCopy.
5888 (MemberCache.AddMethods): Rewrite, now that method_hash isn't
5889 already initialized. If we see an override function, add its
5890 underlying base virtual function to the member_hash too.
5892 2005-02-09 Raja R Harinath <rharinath@novell.com>
5894 Combine two near-redundant caches.
5895 * typemanager.cs (method_params): Rename from method_internal_params.
5896 (TypeManager.GetParameterData): New. Replace
5897 Invocation.GetParameterData.
5898 (TypeManager.LookupParametersByBuilder): Remove.
5899 * expression.cs (Invocation.method_parameter_cache): Remove.
5900 (Invocation.GetParameterData): Remove.
5902 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
5905 2005-02-08 Raja R Harinath <rharinath@novell.com>
5908 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
5909 TypeManager.multicast_delegate_type is null, resolve it by looking
5910 up "System.MulticastDelegate".
5911 * rootcontext.cs (RootContext.ResolveCore): Simplify.
5913 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
5914 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
5915 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
5918 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
5919 (LabeledStatement.AddReference): New. Set 'referenced'.
5920 (Goto.Resolve): Use it.
5922 2005-02-05 John Luke <john.luke@gmail.com>
5924 * driver.cs: remove duplicate -doc line in Usage ()
5926 2005-02-04 Raja R Harinath <rharinath@novell.com>
5928 * location.cs (Location.AddFile): Fix CS2002 error report.
5930 2005-02-02 Martin Baulig <martin@ximian.com>
5932 * delegate.cs (Delegate.DefineType): Report an internal error if
5933 TypeManager.multicast_delegate_type is null. See bug #72015 for
5936 2005-02-02 Raja R Harinath <rharinath@novell.com>
5938 Fix a crasher in a variant of #31984.
5939 * const.cs (Constant.CheckBase): New override that defers the
5940 new-or-override check in case the base type hasn't been populated
5942 (Constant.Define): Ensure the new-or-override check is performed.
5944 2005-02-01 Duncan Mak <duncan@ximian.com>
5946 * const.cs (LookupConstantValue): Check that `ce' is not null
5947 before calling GetValue ().
5949 2005-02-01 Raja R Harinath <rharinath@novell.com>
5951 Fix test-334.cs (#69519).
5952 * cs-parser.jay (using_alias_directive): Pass in an expression to
5953 NamespaceEntry.UsingAlias.
5954 (using_namespace_directive): Pass in an expression to
5955 NamespaceEntry.Using.
5956 (namespace_name): Don't flatten to a string.
5957 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
5958 (NamespaceEntry.AliasEntry.Resolve): Lookup using
5960 (NamespaceEntry.UsingEntry): Likewise.
5961 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
5963 (NamespaceEntry.LookupForUsing): Remove.
5964 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
5966 (NamespaceEntry.Lookup): Remove support for dotted names.
5968 2005-02-01 Raja R Harinath <rharinath@novell.com>
5970 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
5972 (NamespaceEntry.ImplicitParent): Compute on demand.
5973 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
5974 parallels the current.
5975 (NamespaceEntry.LookupForUsing): Use it.
5976 (NamespaceEntry.Lookup): If the current namespace-entry is
5977 implicit, don't search aliases and using tables.
5979 2005-02-01 Raja R Harinath <rharinath@novell.com>
5982 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
5984 (TypeContainer.BaseCache): Compute on demand.
5985 (TypeContainer.FindMembers): Define constants and types if they're
5986 not already created.
5987 (FieldMember.Define): Move resetting of ec.InUnsafe before error
5989 * const.cs (Constant.Define): Make idempotent.
5991 2005-01-29 Miguel de Icaza <miguel@novell.com>
5993 * pending.cs: Produce better code (no nops produced by using Ldarg
5996 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
5997 i - 1' it should be arg + 1.
6001 2005-01-28 Raja R Harinath <rharinath@novell.com>
6003 * attribute.cs (Attribute.CheckAttributeType): Make private
6005 (Attribute.ResolveType): Make virtual.
6006 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
6007 handling of RootContext.Tree.Types.
6009 2005-01-27 Raja R Harinath <rharinath@novell.com>
6011 Update attribute-handling to use the SimpleName/MemberAccess
6013 * cs-parser.jay (attribute): Pass in an expression to the
6014 constructors of Attribute and GlobalAttribute.
6015 * attribute.cs (Attribute): Take an expression for the name.
6016 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
6017 passed in attribute name expression.
6018 (Attribute.CheckAttributeType): Use it.
6019 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
6020 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
6021 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
6022 argument to prevent error messages if the lookup fails.
6024 2005-01-27 Marek Safar <marek.safar@seznam.cz>
6026 * expression.cs (Indirection): Implemented IVariable interface
6027 to support indirection in AddressOf operator.
6028 (PointerArithmetic.Emit): Add optimalization for case where
6029 result can be precomputed.
6031 2005-01-26 Martin Baulig <martin@ximian.com>
6033 * class.cs (TypeContainer.AttributeTargets): Return the correct
6034 AttributeTargets depending on our `Kind' instead of throwing an
6035 exception; fixes #71632.
6037 2005-01-26 Marek Safar <marek.safar@seznam.cz>
6040 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
6043 2005-03-17 Martin Baulig <martin@ximian.com>
6045 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
6046 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
6048 2005-03-17 Martin Baulig <martin@ximian.com>
6050 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
6051 to bool so we can return an error condition.
6052 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
6055 2005-03-17 Martin Baulig <martin@ximian.com>
6057 * generic.cs (TypeMananager.IsIEnumerable): New public method.
6059 * convert.cs (Convert.ImplicitReferenceConversion(Exists)): Allow
6060 converting from an array-type of T to `IEnumerable<T>'.
6062 2005-03-16 Martin Baulig <martin@ximian.com>
6064 * generic.cs (Nullable.Unwrap): Implement IAssignMethod.
6065 (Nullable.LiftedUnaryMutator): New public class.
6067 * expression.cs (UnaryMutator.DoResolve): Added support for
6070 2005-03-14 Martin Baulig <martin@ximian.com>
6072 * generic.cs (Nullable.NullCoalescingOperator): Implemented.
6074 2005-03-14 Martin Baulig <martin@ximian.com>
6076 * generic.cs (Nullable.LiftedBinaryOperator): Added support for
6077 the comparision operators `<', `>', `<=' and `>='.
6079 2005-03-13 Martin Baulig <martin@ximian.com>
6082 (Nullable.NullLiteral): Renamed to `Nullable.NullableLiteral' to
6083 avoid confusion with the `NullLiteral'.
6084 (Nullable.LiftedBinaryOperator): Correctly implement `==' and '!='.
6086 2005-03-13 Martin Baulig <martin@ximian.com>
6088 * expression.cs (Binary.ResolveOperator): For `==' and `!=', allow
6089 comparing arbitrary types with the null literal.
6091 2005-03-13 Martin Baulig <martin@ximian.com>
6093 * generic.cs (Nullable.LiftedBinaryOperator): Add support for the
6094 boolean operators '&&', '||', '&' and '|'.
6095 (Nullable.OperatorTrueOrFalse): New public class.
6097 * ecore.cs (Expression.GetOperatorTrue/False): Return an `Expression'
6098 instead of a `StaticCallExpr'; added support for nullables.
6100 2005-03-10 Martin Baulig <martin@ximian.com>
6103 (ArrayAccess.EmitDynamicInitializers): Use `etype.IsValueType'
6104 rather than `etype.IsSubclassOf (TypeManager.value_type)'.
6106 2005-03-07 Martin Baulig <martin@ximian.com>
6108 * generic.cs (Nullable.Unwrap): Implement IMemoryLocation and make
6109 it work if `expr' is not an IMemoryLocation.
6110 (Nullable.Lifted): Implement IMemoryLocation.
6111 (Nullable.LiftedConversion.ResolveUnderlying): Use the correct
6114 2005-03-05 Martin Baulig <martin@ximian.com>
6116 * generic.cs (Nullable.Unwrap, Wrap): New protected classes.
6117 (Nullable.Lifted): New abstract class; rewrote the lifted conversions.
6118 (Nullable): Added support for lifted unary and binary operators.
6120 * expression.cs (Unary.DoResolve): Added support for nullable types.
6121 (Binary.DoResolve): Likewise.
6122 (Conditional.DoResolve): Likewise.
6124 2005-03-02 Martin Baulig <martin@ximian.com>
6126 * decl.cs (DeclSpace.SetParameterInfo): Make this virtual.
6128 * class.cs (ClassPart.SetParameterInfo): Override this.
6129 (PartialContainer.SetParameterInfo): Override this.
6130 (TypeContainer.CheckConstraints): New protected method.
6131 (PartialContainer.CheckConstraints): Override this and check
6132 whether the same contraints were specified in all parts of a
6133 partial generic type definition.
6134 (PartialContainer.UpdateConstraints): New public method.
6136 * generic.cs (TypeParameter.UpdateConstraints): New public method.
6138 2005-03-02 Martin Baulig <martin@ximian.com>
6140 Committing a patch from Carlos Alberto Cortez to fix #72887.
6142 * convert.cs (Convert.ExplicitReferenceConversionExists): Allow
6143 casts from `T []' to `int []'.
6145 2005-03-02 Martin Baulig <martin@ximian.com>
6147 * generic.cs (TypeManager.IsEqual): Make this symmetric.
6149 * expression.cs (Binary.ResolveOperator): When resolving a
6150 BinaryDelegate, use `TypeManager.IsEqual (l, r)' rather than just
6151 `=='. Fixes #71866. See gen-127.cs.
6153 2005-03-02 Martin Baulig <martin@ximian.com>
6155 * class.cs (TypeContainer.DoDefineMembers): We also need a default
6156 static constructor in static classes.
6158 2005-03-02 Martin Baulig <martin@ximian.com>
6161 (NullableType.Name, NullableType.FullName): Add a "?" to the name.
6162 (Nullable.LiftedConversion): Added support for user-defined
6165 * cs-tokenizer.cs (Tokenizer.PutbackCloseParens): New public method.
6167 * cs-parser.jay: Use ComposedCast everywhere instead of
6168 NullableType, so we don't need to check for NullableType
6170 (conditional_expression): Added `INTERR CLOSE_PARENS' rule for the
6171 case where we'll be resolved into a `parenthesized_expression_0'
6175 (Convert.UserDefinedConversion): Added nullable conversions.
6177 2005-02-28 Martin Baulig <martin@ximian.com>
6179 * generic.cs (TypeManager.IsNullableType): New static method.
6180 (Nullable): New abstract class.
6181 (Nullable.NullLiteral): New public class.
6182 (Nullable.LiftedConversion): New public class.
6184 * cs-parser.jay (non_expression_type): Changed `builtin_types' to
6185 `builtin_types opt_nullable'.
6188 (Convert.ImplicitConversionStandard): Added nullable conversions.
6189 (Convert.ExplicitConversionStandard): Likewise.
6190 (Convert.ExplicitConversion): Likewise.
6192 2005-02-26 Martin Baulig <martin@ximian.com>
6194 * expression.cs (ComposedCast.DoResolveAsTypeStep): Allow `dim' to
6195 begin with a "?", for instance "?[]". Don't do a type lookup if
6198 2005-02-25 Martin Baulig <martin@ximian.com>
6200 The first part of Nullable Types :-)
6202 * generic.cs (NullableType): New public class.
6203 (NullCoalescingOperator): New public class.
6204 (TypeArguments.Resolve): Add a CS0306 check.
6206 * cs-parser.jay (opt_error_modifier): Removed, this was unused.
6207 (opt_nullable): New rule.
6208 (type): Added `opt_nullable' to `namespace_or_type_name',
6209 `builtin_types' and `pointer_type'.
6210 (array_type): Added `opt_nullable'.
6211 (opt_rank_specifier_or_nullable): New rule; this is the
6212 combination of `opt_rank_specifier' and `opt_nullable'.
6213 (opt_error): New rule; catch errors here.
6214 (nullable_type_or_conditional): New rule; we use this to check for
6215 nullable and still detect the conditional operator.
6216 (local_variable_type): Use `opt_rank_specifier_or_nullable'
6217 instead `opt_rank_specifier'.
6219 * expression.cs (ComposedCast.DoResolveAsTypeStep): Added support
6222 2005-02-24 Martin Baulig <martin@ximian.com>
6224 * README, README.Changes: Removed; they're old and obsolete.
6226 2005-02-22 Martin Baulig <martin@ximian.com>
6228 * generic.cs (TypeParameter.Resolve): If resolving the constraints
6229 returned an error, set `constraints' to null to avoid a crash
6231 (TypeParameter.ResolveType): Likewise.
6233 2005-02-22 Martin Baulig <martin@ximian.com>
6236 (Constraints.ResolveTypes): Protect against being called twice.
6237 (Constraints.CheckInterfaceMethod): Don't call ResolveTypes().
6238 (TypeParameter.ResolveType): New public method; calls
6239 constraints.ResolveTypes().
6240 (TypeParameter.DefineType): Moved constraints.ResolveType() out
6241 into the new ResolveType().
6242 (GenericMethod.Define): Call ResolveType() on all our
6245 2005-02-21 Martin Baulig <martin@ximian.com>
6248 (TypeManager.generic_nullable_type): New static public field.
6249 (TypeManager.InitGenericCoreType): Lookup "System.Nullable`1".
6252 (RootContext.ResolveCore): Resolve "System.Nullable`1".
6254 2005-02-15 Martin Baulig <martin@ximian.com>
6256 * generic.cs (ConstructedType.Constraints): Correctly check
6257 constraints if the argument type is a type parameter; fixes
6260 2005-02-02 Martin Baulig <martin@ximian.com>
6262 * delegate.cs (Delegate.DefineType): Report an internal error if
6263 TypeManager.multicast_delegate_type is null. See bug #72015 for
6266 2005-01-29 Miguel de Icaza <miguel@novell.com>
6268 * pending.cs: Produce better code (no nops produced by using Ldarg
6271 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
6272 i - 1' it should be arg + 1.
6276 2005-01-26 Martin Baulig <martin@ximian.com>
6278 * cs-parser.jay (indexer_declarator): Don't report an error if we
6279 have type parameters since we can be an explicit interface
6280 implementation; fixes #71449.
6282 2005-01-26 Martin Baulig <martin@ximian.com>
6284 * class.cs (TypeContainer.AttributeTargets): Return the correct
6285 AttributeTargets depending on our `Kind' instead of throwing an
6286 exception; fixes #71632.
6288 2005-01-26 Martin Baulig <martin@ximian.com>
6290 * delegate.cs (Delegate.DefineType): Correctly define our type
6291 parameters. Fixes #71483.
6293 2005-01-25 Raja R Harinath <rharinath@novell.com>
6296 * expression.cs (MemberAccess.DoResolve): Don't complain with
6297 cs0572 when the LHS of a member access has identical name and type
6300 2005-01-25 Marek Safar <marek.safar@seznam.cz>
6303 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
6305 Create custom PermissionSet only for PermissionSetAttribute.
6307 2005-01-24 Marek Safar <marek.safar@seznam.cz>
6310 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
6311 delegates in static class.
6313 2005-01-24 Martin Baulig <martin@ximian.com>
6315 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
6316 merging an implicit block, just use its reachability.
6318 * statement.cs (Block.Resolve): Make the unreachable code check
6319 work wrt. implicit blocks; see test-337 from #63842.
6321 2005-01-21 Alp Toker <alp@atoker.com>
6323 * cs-parser.jay: destructor_declaration's container is PartialContainer
6324 not Class when partial types are used, so use Kind prop instead of
6327 2005-01-22 Miguel de Icaza <miguel@ximian.com>
6329 * cs-parser.jay: Improve error reporting when an interface
6332 2005-01-20 Dick Porter <dick@ximian.com>
6334 * support.cs: SeekableStreamReader fix from Sandor Dobos
6335 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
6336 chars are read. Fixes bug 70369.
6338 2005-01-20 Raja R Harinath <rharinath@novell.com>
6340 * cs-parser.jay (catch_clause): Simplify current_block handling
6343 2005-01-17 Miguel de Icaza <miguel@ximian.com>
6345 * convert.cs (ImplicitStandardConversionExists): Synchronize the
6346 code with ImplicitStandardConversion to handle the implicit
6347 conversion of method groups into valid delegate invocations.
6349 The problem is that in parameter handling we were using this code
6350 path. Fixes bug #64698
6352 2005-01-19 Raja R Harinath <rharinath@novell.com>
6354 * cs-parser.jay: Fix several infelicities.
6355 - Avoid assigning to the parser value stack. Code like
6356 '$3 = null' is unclean. Synthesize a value for the code block
6358 - Avoid using oob_stack for storing location information. Use ...
6359 (_mark_): ... this. New (empty) rule. Saves the current location
6361 (foreach_statement): Avoid using oob_stack for current_block
6362 handling. Use technique used in for_statement and
6363 using_statement. Synthesize a value for the code block to store
6364 additional intermediate information.
6366 2005-01-13 Miguel de Icaza <miguel@ximian.com>
6368 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
6369 of a different type is only allowed to private fields of a
6370 containing type, not on fields of a base class.
6372 See test-174.cs and error cs0122-9.cs
6374 2005-01-13 Raja R Harinath <rharinath@novell.com>
6376 Fix test-335.cs (bug #58126).
6377 * cs-parser.jay (argument): Split out non-expression parts of the
6378 rule into 'non_simple_argument'.
6379 (invocation_expression): Support parenthesized invocations with
6380 multiple arguments, and with single non-simple arguments.
6382 2005-01-13 Raja R Harinath <rharinath@novell.com>
6384 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
6387 2005-01-12 Raja R Harinath <rharinath@novell.com>
6389 Fix cs0038-1.cs, cs1640-6.cs.
6390 * ecore.cs (Expression.Resolve): Remove special-case for
6391 SimpleName in error-handling.
6392 (Expression.almostMatchedMembers): Relax access permission to
6394 (Expression.MemberLookupFailed): Handle duplicates in
6395 almostMatchedMembers list.
6396 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
6397 * expression.cs (New.DoResolve): Report CS1540 for more cases.
6398 * typemanager.cs (GetFullNameSignature): Use the MethodBase
6399 overload if the passed in MemberInfo is a MethodBase.
6401 2005-01-25 Martin Baulig <martin@ximian.com>
6404 (DocUtil.emptyParamList): Removed; use `Type.EmptyTypes' instead.
6406 2005-01-12 Marek Safar <marek.safar@seznam.cz>
6409 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
6410 for non-CAS & merge permission sets properly.
6412 2005-01-11 Raja R Harinath <rharinath@novell.com>
6414 Improve standard-compliance of simple name and member access
6415 resolution. Fixes bugs #52697, #57200, #67520, #69519.
6416 * ecore.cs (FullNamedExpression): New abstract base class
6417 for Namespaces and TypeExpressions.
6418 (ResolveFlags.SimpleName): Remove.
6419 (SimpleName): Remove support for dotted names.
6420 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
6421 DeclSpace.FindType and DeclSpace.LookupType.
6422 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
6423 (Expression.ExprClassName): Make member function.
6424 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
6425 a namespace. Remove creation of dotted "SimpleName"s.
6426 (MemberAccess.DoResolve): Likewise.
6427 * decl.cs (DeclSpace.Cache): Make private.
6428 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
6429 (DeclSpace.FindType): Update.
6430 (DeclSpace.LookupType): Move here from RootContext. Return a
6431 FullNamedExpression.
6432 * namespace.cs (Namespace): Derive from FullNamedExpression
6433 so that it can be part of expression resolution.
6434 (Namespace.Lookup): Return an FullNamedExpression.
6435 (NamespaceEntry.LookupAlias): Lookup aliases only in current
6437 * rootcontext.cs (NamespaceLookup): Remove.
6438 (LookupType): Move to DeclSpace.
6439 * attribute.cs (CheckAttributeType): Update.
6440 * doc.cs (FindDocumentedType): Remove allowAlias argument.
6441 (FindDocumentedTypeNonArray): Likewise.
6443 2005-01-11 Raja R Harinath <rharinath@novell.com>
6445 Fix cs0509.cs, cs1632.cs.
6446 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
6447 is the same as IsInterface.
6448 (TypeContainer.GetClassBases): Likewise.
6449 * statement.cs (LabeledStatement.ig): New field.
6450 (LabeledStatement.LabelTarget): Save ILGenerator which created the
6452 (LabeledStatement.DoEmit): Check that the label was created with
6453 the same ILGenerator.
6455 2005-01-10 Marek Safar <marek.safar@seznam.cz>
6458 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
6459 accessors to its properties.
6461 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
6462 from accessors to property.
6464 2005-01-10 Marek Safar <marek.safar@seznam.cz>
6467 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
6470 2005-01-08 Miguel de Icaza <miguel@ximian.com>
6472 * attribute.cs: Check for null and empty strings.
6474 I have lost another battle to Paolo.
6476 2005-01-07 Marek Safar <marek.safar@seznam.cz>
6479 * class.cs (PropertyMethod): Set Parent field in ctors.
6480 (SetMethod.InternalParameters): Add unsafe switch hack.
6481 Override MarkForDuplicationCheck where it is appropriate.
6483 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
6484 It says whether container allows members with the same name.
6486 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
6487 Removed is_method parameter.
6489 2005-01-06 Duncan Mak <duncan@ximian.com>
6491 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
6492 because the previous change led to incorrect reporting of CS1032
6493 ("Cannot define/undefine preprocessor symbols after first token in
6494 file"). Instead of using `tokens_seen' as the only flag that
6495 triggers CS1040, introduce `comments_seen'. This new flag is used
6496 to signify having seen comments on the current line, so it is
6497 unset after a newline.
6499 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
6501 * doc.cs : When searching for a type, find nested type too.
6502 This fixes bug #71040.
6504 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
6507 - Warn missing member comment on those classes which also does not
6508 have doc comments. Fixed bug #71041.
6509 - Don't warn missing doc comment on default constructor.
6512 2005-01-06 Duncan Mak <duncan@ximian.com>
6514 * cs-tokenizer.cs (xtoken): After handling traditional C-style
6515 comments, set `tokens_seen' to true. This allows us to detect
6516 misplaced preprocessor directives (i.e. not at the beginning of
6517 the a line, nor after whitespaces). In that case, report error
6518 CS1040. This fixes bug #56460.
6520 * cs-parser.jay (interface_member_declaration): Add checks for
6521 IsExplicitImpl, and report CS0541 error if an interface member is
6522 defined as an explicit interface declaration.
6524 2005-01-06 Marek Safar <marek.safar@seznam.cz>
6527 * class.cs (PropertyMethod): Set Parent field in ctors.
6528 (SetMethod.InternalParameters): Add unsafe switch hack.
6530 * decl.cs (MemberCore.Parent): Cannot be readonly.
6532 2005-01-06 Raja R Harinath <rharinath@novell.com>
6534 * decl.cs (DeclSpace.ResolveType): Remove.
6535 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
6536 Merge in code from ...
6537 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
6538 * class.cs, enum.cs: Update to changes.
6540 2005-01-06 Miguel de Icaza <miguel@ximian.com>
6542 * anonymous.cs: Ensure that we init the scope of our parent if it
6543 has not been initialized yet.
6545 2004-12-30 Duncan Mak <duncan@ximian.com>
6547 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
6548 if field.FieldBuilder is null. Fixes #70758.
6550 * convert.cs: Fixed some typos and updated some of the comments.
6551 (ImplicitStandardConversionExists):
6552 (TryImplicitIntConversion): If `target_type' is an interface and
6553 the type of `ic' implements this interface, return true or a new
6554 BoxedCast instead of null. This fixes #70468.
6556 2004-12-29 Duncan Mak <duncan@ximian.com>
6558 * expression.cs (Argument.Emit): Check that Expr is
6559 IMemoryLocation before casting to it, and report CS1510 otherwise.
6563 2004-12-21 Ben Maurer <bmaurer@ximian.com>
6565 * statement.cs (Block.ThisVariable): remove the recursion here, to
6566 make the --profile more sane.
6568 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
6570 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
6571 assembly, by JB Evain.
6573 2004-12-17 Raja R Harinath <rharinath@novell.com>
6575 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
6576 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
6577 "parent" refers to enclosing type/class. "base" refers to superclass.
6579 2004-12-17 Raja R Harinath <rharinath@novell.com>
6581 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
6582 Ensure that we only have GlobalAttributes.
6583 * attribute.cs (Attribute.Emit): Make non-virtual.
6584 (GlobalAttribute.Emit): Remove.
6585 (Attribute.Resolve): Make virtual.
6586 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
6587 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
6588 the argument. Don't create one.
6589 (Attribute.GetObsoleteAttribute): Likewise.
6590 (Attribute.GetClsCompliantAttributeValue): Likewise.
6591 * class.cs, decl.cs: Update to changes.
6593 2004-12-17 Marek Safar <marek.safar@seznam.cz>
6595 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
6597 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
6599 * statement.cs (Foreach.Resolve): Add error 186 report.
6601 2004-12-16 Marek Safar <marek.safar@seznam.cz>
6603 * expression.cs (Conditional.DoResolve): Add warning 429.
6605 * statement.cs (If.Resolve): Add warning 665.
6607 2004-12-16 Raja R Harinath <rharinath@novell.com>
6609 New invariant: RootContext.Tree.Types.NamespaceEntry == null
6610 except when in the parser, and in GlobalAttribute.
6611 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
6612 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
6613 RootContext.Tree.Types.NamespaceEntry once work is done.
6614 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
6615 and resets RootContext.Tree.Types.NamespaceEntry.
6617 2004-12-15 Marek Safar <marek.safar@seznam.cz>
6619 * cs-parser.jay: Don't create a block for every variable.
6621 2004-12-14 Miguel de Icaza <miguel@ximian.com>
6623 * location.cs: Provide extra information.
6625 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
6626 variables from the captured environment, it is the ldarg_0.
6628 2004-12-14 Marek Safar <marek.safar@seznam.cz>
6630 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
6633 * class.cs: Changed warning level for 169 to avoid developer
6634 displeasure from warning flooding. It will be changed back when they
6635 fix most of current BCL warnings.
6637 * RootContext.cs: Pushed default WarningLevel to 3.
6639 * statement.cs: Removed unused variable.
6641 2004-12-14 Marek Safar <marek.safar@seznam.cz>
6643 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
6644 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
6645 Add error 502 report.
6646 (StaticClass.DefineType): Add error 441 report.
6647 (Class.AllowedModifiersProp): New virtual property as temporary
6648 extension to AllowedModifiers.
6649 (Class.DefineType): Add error 418 report. Moved ModFlags check here
6650 to share implementation with StaticClass and don't call virtual
6653 * driver.cs (MainDriver): Add error 1558 test.
6655 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
6656 report. Moved error 36 test here.
6658 * statement.cs (Throw.Resolve): Add error 724 report.
6660 * typemanager.cs: Add out_attribute_type core type.
6662 2004-12-13 Marek Safar <marek.safar@seznam.cz>
6664 * class.cs (TypeContainer.VerifyClsCompliance): Add error
6666 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
6668 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
6671 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
6673 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
6674 Add error 3023 report.
6675 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
6677 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
6680 2004-12-12 John Luke <john.luke@gmail.com>
6682 * driver.cs (AddArgs): take -- into account when
6683 adding arguments, fixes bug 65710
6685 2004-12-12 Martin Baulig <martin@ximian.com>
6687 * expression.cs (Unary.TryReduceNegative): Added support for
6688 SByteConstant and ByteConstant.
6689 (Unary.Reduce): Check error values from TryReduceNegative().
6691 2004-12-10 Marek Safar <marek.safar@seznam.cz>
6693 * attributes.cs (Attribute.Resolve): Avoid multiple error report
6694 and report exception as error 182.
6696 2004-12-10 Raja R Harinath <rharinath@novell.com>
6698 * driver.cs (Main): Fix message when there are warnings.
6700 2004-12-09 Miguel de Icaza <miguel@ximian.com>
6702 * delegate.cs: Fixed my fix from yesterday, sorry about that.
6704 2004-12-09 Marek Safar <marek.safar@seznam.cz>
6706 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
6707 Reduced number of warnings.
6709 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
6711 2004-12-08 Miguel de Icaza <miguel@ximian.com>
6713 * driver.cs: Removed message.
6715 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
6717 2004-12-08 <vargaz@freemail.hu>
6719 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
6721 2004-12-08 Martin Baulig <martin@ximian.com>
6723 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
6724 instead of a CS3002 for properties and indexer.
6726 2004-12-08 Martin Baulig <martin@ximian.com>
6728 * decl.cs (MemberName.ToString): Make this work again.
6730 2004-12-08 Marek Safar <marek.safar@seznam.cz>
6732 * attribute.cs (Resolve): Add error 591 detection.
6734 * class.cs (FieldMember.Define): Add error 1547 detection.
6735 (Indexer.Define): Add error 620 detection.
6736 (Operator.Define): Add error 590 detection.
6738 * ecore.cs: Missing argument for error 79.
6740 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
6743 2004-12-07 Marek Safar <marek.safar@seznam.cz>
6746 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
6749 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
6751 * cs-parser.jay : handle doc comments on implicit/explicit operators.
6752 Some operator comments were suppressed.
6753 * doc.cs : Implicit/explicit operator name in doc comments are like
6754 "op_Explicit(type)~returnType", so added suffix handling.
6756 2005-01-21 Alp Toker <alp@atoker.com>
6758 * cs-parser.jay: destructor_declaration's container is PartialContainer
6759 not Class when partial types are used, so use Kind prop instead of 'is'.
6761 2004-12-12 Martin Baulig <martin@ximian.com>
6763 * expression.cs (Unary.TryReduceNegative): Added support for
6764 SByteConstant and ByteConstant.
6765 (Unary.Reduce): Check error values from TryReduceNegative().
6767 2004-12-11 Martin Baulig <martin@ximian.com>
6769 * support.cs (ReflectionParameters.ParameterName): If we have a
6770 `gpd', call `ParameterName' on it.
6772 * parameter.cs (Parameter.GetParameterAttributes): New static method.
6774 * pending.cs (PendingImplementation.DefineProxy): Call
6775 DefineParameter() for all of the MethodBuilder's arguments.
6777 2004-12-09 Martin Baulig <martin@ximian.com>
6779 * doc.cs (DocUtil): Make this a static class.
6781 2004-12-09 Martin Baulig <martin@ximian.com>
6783 * expression.cs (Invocation.InferType): Moved the type inference
6784 implementation into TypeManager.
6786 * generics.cs (TypeManager): Moved the type inference
6787 implementation here.
6789 2004-12-09 Martin Baulig <martin@ximian.com>
6791 * typemanager.cs (TypeManager): Make this a partial class.
6794 (TypeManager): Move the generics part of `TypeManager' here.
6796 2004-12-08 Martin Baulig <martin@ximian.com>
6798 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
6799 instead of a CS3002 for properties and indexer. Added CS3024
6800 check for generic interfaces.
6802 * attributes.cs (AttributeTester.AnalyzeTypeCompliance): Generic
6803 instances are not CLS-compliant.
6805 2004-12-08 Martin Baulig <martin@ximian.com>
6808 (void_pointer_expression): New rule for `void*', `void**' etc.
6809 (typeof_expression): Add `void_pointer_expression'; fixes #66846.
6811 2004-12-08 Martin Baulig <martin@ximian.com>
6813 * expression.cs (Invocation.InferType): Removed the hack for
6814 MethodCore.MayUnify().
6816 * typemanager.cs (TypeManager.MayBecomeEqualGenericTypes): Make
6819 * class.cs (MethodCore.MayUnify): Use
6820 TypeManager.MayBecomeEqualGenericTypes().
6822 2004-12-08 Martin Baulig <martin@ximian.com>
6824 * expression.cs (Is.DoResolve, As.DoResolve): If we're a type
6825 parameter, box it. Fixes #69233.
6827 2004-12-08 Martin Baulig <martin@ximian.com>
6829 * generic.cs (ConstructedType.CheckConstraints): Valuetypes always
6830 have the ctor constraint. Fixes #68326.
6832 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
6834 * cs-parser.jay : interface comment was not consumed because of
6835 extra opt_semicolon before doc handling.
6837 2004-12-03 Raja R Harinath <rharinath@novell.com>
6839 Fix test-327.cs, test-328.cs, and put in early infrastructure
6840 for eventually fixing #52697.
6841 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
6842 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
6844 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
6845 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
6846 (VerifyUsing, error246): Update.
6847 * rootcontext.cs (RootContext.NamespaceLookup): Just use
6848 'NamespaceEntry.LookupNamespaceOrType'.
6850 2004-12-07 Martin Baulig <martin@ximian.com>
6852 * driver.cs: Call it "BETA SOFTWARE" :-)
6854 2004-12-06 Raja R Harinath <rharinath@novell.com>
6856 Fix crash on cs0657-17.cs.
6857 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
6858 Use RootContext.Tree.Types, not 'new RootTypes ()'.
6859 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
6860 the case where the NamespaceEntry gets overwritten.
6862 2004-12-06 Marek Safar <marek.safar@seznam.cz>
6864 Fixed #69195, #56821
6865 * ecore.cs (ResolveBoolean): Tiny refactoring.
6867 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
6868 of right expression resolving when left is false constant and
6869 operator is LogicalAnd OR true constant and operator is LogicalOr.
6871 * statement.cs (ResolveUnreachable): Always reports warning.
6873 2004-12-05 Miguel de Icaza <miguel@ximian.com>
6875 * class.cs: Distinguish between 1721 and 1722 (just a little help
6876 for the programmer).
6878 2004-12-03 Miguel de Icaza <miguel@ximian.com>
6880 * delegate.cs: Only allow this on new versions of the language.
6882 2004-12-02 Duncan Mak <duncan@ximian.com>
6884 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
6886 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
6887 here as a static method. Take an additional bool out parameter
6888 `must_do_cs1540_check' for signaling to InstanceResolve.
6889 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
6890 member field from PropertyExpr class and made it an argument of
6892 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
6893 check for MarshalByRefObject, and report CS0122 instead of CS1540.
6894 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
6895 and `remove_accessor' as well as InstanceResolve: report CS0122
6900 2004-12-07 Martin Baulig <martin@ximian.com>
6902 * decl.cs (DeclSpace.AddToContainer): Report correct errors CS0694
6903 and CS0692 where appropriate.
6905 2004-12-06 Martin Baulig <martin@ximian.com>
6907 * class.cs (MethodCore.MayUnify): Moved the CS0408 check here from
6908 IsDuplicateImplementation() and improved it.
6910 * expression.cs (Invocation.InferTypeArguments): Added
6911 `Type[] inferred_class_types' argument (for MethodCore.MayUnify)
6912 and removed the "ref" modifier from `infered_types'.
6914 * decl.cs (MemberName.ToString): Removed the exception.
6916 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
6918 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
6919 comments are allowed.
6921 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
6923 * delegate.cs: Add checks for subtypes in paramaters and return values
6924 in VerifyMethod () to add support for Covariance/Contravariance
6927 2004-12-02 Miguel de Icaza <miguel@ximian.com>
6929 * report.cs: Remove extra closing parenthesis.
6931 * convert.cs (Error_CannotImplicitConversion): If the name of the
6932 types are the same, provide some extra information.
6934 2004-12-02 Marek Safar <marek.safar@seznam.cz>
6937 * attribute.cs (Resolve): Improved implementation of params
6938 attribute arguments.
6940 * support.cs (ParameterData): Add HasParams to be faster.
6942 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
6944 all things are for /doc support:
6946 * doc.cs: new file that supports XML documentation generation.
6947 * mcs.exe.sources: added doc.cs.
6949 Handle /doc command line option.
6950 Report error 2006 instead of 5 for missing file name for /doc.
6951 Generate XML documentation when required, after type resolution.
6953 Added support for picking up documentation (/// and /** ... */),
6954 including a new XmlCommentState enumeration.
6956 Added lines to fill Documentation element for field, constant,
6957 property, indexer, method, constructor, destructor, operator, event
6958 and class, struct, interface, delegate, enum.
6959 Added lines to warn incorrect comment.
6961 Added Documentation field (passed only when /doc was specified).
6963 Added DocComment, DocCommentHeader, GenerateDocComment() and
6964 OnGenerateDocComment() and some supporting private members for
6965 /doc feature to MemberCore.
6967 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
6969 Added overriden DocCommentHeader.
6971 Added overriden DocCommentHeader and GenerateDocComment().
6973 2004-12-01 Miguel de Icaza <miguel@ximian.com>
6975 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
6976 unwrapping the enumeration values, chain to
6977 DoConstantNumericPromotions again, so we can promote things to the
6978 fundamental types (takes care of enums that are bytes, sbytes).
6982 2004-12-01 Raja R Harinath <rharinath@novell.com>
6984 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
6985 Fix long-standing bug in type-lookup. Use FindType instead of
6986 LookupType when ec.ResolvingTypeTree.
6987 (Attribute.ResolveType, Attribute.Resolve)
6988 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
6990 (Attributes.Search): Remove internal version. Update.
6991 (Attributes.SearchMulti): Update.
6992 (Attributes.GetClsCompliantAttribute): Remove.
6993 (Attributes.GetIndexerNameAttribute): Remove.
6994 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
6995 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
6996 * class.cs (Indexer.Define): Likewise.
6998 2004-12-01 Marek Safar <marek.safar@seznam.cz>
7001 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
7002 MarshallByReference members access.
7004 * expression.cs: Use CheckMarshallByRefAccess;
7005 Better error CS0197 message.
7007 * report.cs: Print whole related error message.
7009 2004-11-29 Marek Safar <marek.safar@seznam.cz>
7011 * class (GetClassBases): Better error 60 report.
7012 (EventProperty): Disabled warning 67 detection.
7014 2004-11-29 Marek Safar <marek.safar@seznam.cz>
7017 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
7019 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
7022 2004-11-29 Marek Safar <marek.safar@seznam.cz>
7025 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
7027 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
7029 2004-11-26 Miguel de Icaza <miguel@ximian.com>
7031 * attribute.cs (Attribute.Resolve): Refine error reporting and
7032 report a cs0117 if the identifier does not exist, to distinguish
7033 from 0617 which is a miss-use of the actual identifier.
7035 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
7036 between cs0070 and cs0079.
7038 * class.cs (MemberBase.DoDefine): When reporting a wrong
7039 accessibility level, we use MethodCore to compare instead of
7040 Method (this was a regression in some refactoring effort).
7042 So now we correctly report cs0056 again.
7044 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
7045 testing the target_type (which was known to be object_type) and
7046 not the source type (which is anonymous_method).
7048 Fixed reporting of error cs1660.
7050 * expression.cs (UserCast.Source): Expose the underlying cast.
7052 * statement.cs (Switch.SwitchGoverningType): Sort the list of
7053 allowed types to find a match to int32 first (most common).
7055 In addition, it ignores any ImplicitUserConversions that did an
7056 internal implicit conversion (as the switch statement allows only
7057 one integral conversion to exist).
7059 * class.cs (PartialContainer.Create): rename `name' to
7060 `member_name' for clarity. Then replace the string calls with a
7061 call to MemberName.GetPartialName, as now using
7062 MemberName.ToString is an error (this is due to the side effects
7063 it had, that were fixed in the past).
7065 This will restore the error reporting on a number of partial class
7066 errors that were missusing this (and getting an exception as a
7067 results, which is now just a plain textual warning, because
7068 yyparse debug output would crash otherwise).
7070 2004-11-26 Raja R Harinath <rharinath@novell.com>
7072 * Makefile (PROGRAM_INSTALL_DIR): Remove.
7074 2004-11-25 Ben Maurer <bmaurer@ximian.com>
7076 * rootcontext.cs (LookupType): Make sure to cache lookups that
7077 don't give us a negative result. This saves about 5% of corlib
7080 2004-11-25 Miguel de Icaza <miguel@ximian.com>
7082 * report.cs (AbstractMessage.Print): messages are sent to stderr
7084 * class.cs (TypeContainer.GetClassBases): It is an error to have a
7085 non-interface in the list of interfaces (at this point, either
7086 parent was properly set, or a base class is being listed in the
7087 interfaces section).
7089 This flags error 1722, and resolves the crash from bug 69259.
7091 2004-11-25 Ben Maurer <bmaurer@ximian.com>
7093 * statement.cs (Using.EmitExpressionFinally): make this work right
7094 for valuetypes. Fixes 69926.
7096 2004-11-25 Miguel de Icaza <miguel@ximian.com>
7098 * const.cs (Const.ChangeType): Cope with the "0 literal can be
7099 converted to an enum" here, before we try to change the underlying
7100 type. This code exists, but it is a different code path than the
7101 one used while encoding constants.
7103 (ImplicitReferenceConversionExists): In addition, resynchronized
7104 the code here, so it matches the same code in
7105 ImplicitReferenceConversionExists for the `from any class-type S
7106 to any interface-type T'.
7108 2004-11-25 Marek Safar <marek.safar@seznam.cz>
7110 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
7112 2004-11-24 Miguel de Icaza <miguel@ximian.com>
7114 * cs-parser.jay: Use verbosity accordingly.
7116 2004-11-24 Marek Safar <marek.safar@seznam.cz>
7118 * expression.cs (Unary.ResolveOperator): Do not report warning;
7119 AddressOf reads from variable.
7121 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
7123 2004-11-24 Marek Safar <marek.safar@seznam.cz>
7127 * attribute.cs (Attributable): Removed CheckTargets.
7128 (Attributes.Emit): Explicit attribute targets are tested here.
7130 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
7131 not enabled for interfaces.
7133 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
7134 (GetAssemblyName): Ouch next bug there.
7136 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
7138 * expression.cs: Error 275 added.
7140 2004-11-23 Marek Safar <marek.safar@seznam.cz>
7142 Fix bug #69177 (Implemented decimal constant support)
7144 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
7145 (BinaryFold): Add DecimalConstant.
7147 * const.cs (Define): Decimal constant
7149 (ChangeType): Add decimal type handling.
7150 (LookupConstantValue): Don't set value for decimal type but
7151 emit DecimalConstantAttribute. Needed for constant optimization.
7153 * constant.cs (ToDecimal): New method.
7154 (ConvertToDecimal): New method.
7155 (IntConstant): Implemented ConvertToDecimal.
7156 (DecimalConstant.Emit): Emit optimized version for decimals in
7159 * expression.cs (ResolveOperator): Changed order of constant
7160 reduction to work correctly with native types which have
7161 overloaded operators.
7162 (ResolveMemberAccess): Extract constant value from attribute
7165 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
7167 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
7168 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
7169 (ChangeType): Decimal is special.
7170 (TypeToCoreType): Add decimal type.
7172 2004-11-22 Marek Safar <marek.safar@seznam.cz>
7174 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
7177 2004-11-22 Marek Safar <marek.safar@seznam.cz>
7179 * class.cs (EventField.ApplyAttributeBuilder): Fix error
7182 2004-11-19 Marek Safar <marek.safar@seznam.cz>
7184 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
7186 * pending.cs (PendingImplementation): Grab only interfaces.
7188 2004-11-19 Marek Safar <marek.safar@seznam.cz>
7190 * statement.cs (ForeachHelperMethods): Add location member and
7191 error 202 detection.
7193 2004-11-18 Marek Safar <marek.safar@seznam.cz>
7195 * expression.cs (DoResolveBase): Fixed wrong warning for out
7198 2004-12-04 Martin Baulig <martin@ximian.com>
7200 * convert.cs (Convert.TypeParameter_to_Null): Use the constraints
7201 to check whether the conversion is ok.
7203 * typemanager.cs (TypeManager.GetTypeArguments): Just return
7204 `Type.EmptyTypes' if we're not a generic TypeContainer.
7206 2004-11-25 Miguel de Icaza <miguel@ximian.com>
7208 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
7209 old bug: when converting from the null literal to a pointer,
7210 return an EmptyCast, not the NullLiteral.
7212 This fixes #69921, the recent null_type changes probably made this
7215 2004-12-03 Martin Baulig <martin@ximian.com>
7217 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
7218 method as our child, call AnonymousMethod.Compatible() on it.
7220 2004-12-02 Miguel de Icaza <miguel@ximian.com>
7222 * class.cs (FieldBase): Use an unused bit field from the field to
7223 encode the `has_offset' property from the FieldMember. This saves
7224 a couple of Ks on bootstrap compilation.
7226 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
7227 method as our child, return the AnonymousMethod resolved
7230 * expression.cs (New.DoResolve): Allow return values from
7231 NewDelegate to also include AnonymousMethods.
7235 2004-11-29 Raja R Harinath <rharinath@novell.com>
7237 * decl.cs (MemberCore.MemberName): Remove readonly to fix an error
7239 * rootcontext.cs (ResolveCore::interfaces_first_stage): Add
7240 System.Runtime.InteropServices._Exception, since it's a base
7241 interface of the core type System.Exception in the net_2_0 profile.
7243 2004-11-27 Martin Baulig <martin@ximian.com>
7245 * ecore.cs (Expression.StoreFromPtr): Use `stobj' for generic parameters.
7247 2004-11-26 Raja R Harinath <rharinath@novell.com>
7249 * Makefile: Convert to use executable.make.
7250 * gmcs.exe.sources: New.
7252 2004-11-25 Martin Baulig <martin@ximian.com>
7254 * expression.cs (Invocation.InferType): Added support for byref types.
7256 2004-11-25 Martin Baulig <martin@ximian.com>
7258 * statement.cs (Foreach.FetchMethodMoveNext): Wrap `mi.ReturnType'
7259 in TypeManager.TypeToCoreType().
7261 2004-11-25 Martin Baulig <martin@ximian.com>
7263 * iterators.cs (Iterator.DoDefineMembers): Override and lookup the
7264 "Dispose" method from the `current_type'.
7265 (Iterator.EmitMoveNext): Use the `dispose_method' we looked up in
7266 DoDefineMembers() instead of using the MethodBuilder; this is
7267 required for generic iterators.
7269 * class.cs (TypeContainer.DoDefineMembers): Make this virtual.
7271 2004-11-24 Martin Baulig <martin@ximian.com>
7273 * ecore.cs (Expression.LoadFromPtr): Use `ldobj' for generic parameters.
7275 2004-11-20 Martin Baulig <martin@ximian.com>
7277 * expression.cs (Invocation.InferType): Correctly infer generic
7278 instances; see gen-103.cs.
7279 (Invocation.InferTypeArguments): If a generic method doesn't have
7280 any unbound type parameters, we don't need to infer anything.
7282 2004-11-19 Raja R Harinath <rharinath@novell.com>
7284 * Makefile (gmcs.exe): Update to new location of bootstrap mcs.exe.
7286 2004-11-17 Raja R Harinath <rharinath@novell.com>
7288 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
7289 (TypeHandle.GetMemberCache): New.
7290 (TypeHandle.TypeHandle): Update.
7291 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
7292 (TypeManager.LookupParentInterfacesCache):
7293 Rename from LookupInterfaceCache. Optimize slightly.
7294 (TypeManager.MemberLookup_FindMembers): Update.
7295 * decl.cs (MemberCache.MemberCache): Set Container to null in the
7297 (AddCacheContents): Rename from AddHashtable.
7298 * class.cs (TypeContainer.parent_container): Remove.
7299 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
7300 (TypeContainer.DoDefineMembers): Don't initialize it.
7301 Update to name changes.
7303 2004-11-17 Miguel de Icaza <miguel@ximian.com>
7305 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
7306 that factors the code to check access modifiers on override.
7308 (PropertyBase): Use the code here.
7310 Patch from Lluis S'anchez, fixes bug #69361.
7312 2004-11-15 Miguel de Icaza <miguel@ximian.com>
7314 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
7315 routine that is used to report the use of a captured variable
7316 whose address has been taken.
7318 There are two checks: one when variables are being captured and
7319 the other check is when the address of a variable is taken.
7321 (because an anonymous methods might be resolved before *or* after
7322 the address has been taken) and
7324 * expression.cs (Conditional.DoResolve): Remove the special
7325 casing that Martin added to trueExpr and falseExpr being both
7326 NullLiteral. We get the right behavior now just by introducing
7327 the null_type into the compiler.
7329 * convert.cs (ExplicitConversion): Change the code to use
7330 null_type instead of testing `expr is NullLiteral'.
7331 (ImplicitConversionStandard): use null_type too.
7332 (ImplicitReferenceConversionExists): use null_type too.
7333 (ImplicitReferenceConversion): use null_type too.
7335 * literal.cs: The type of `NullLiteral' is now null_type instead
7337 (Resolve): Set the type here.
7339 * typemanager.cs: Introduce null_type.
7341 2004-11-18 Martin Baulig <martin@ximian.com>
7344 (RootContext.LookupType): Return a `Type', not a `TypeExpr'.
7346 2004-11-18 Martin Baulig <martin@ximian.com>
7348 * ecore.cs (TypeExpr.DoResolveAsTypeStep): Make this protected.
7350 2004-11-18 Martin Baulig <martin@ximian.com>
7352 * generic.cs (Constraints.Resolve): Take an `EmitContext' instead
7353 of a `DeclSpace'. If one of our constraints is a `ConstructedType',
7354 call ResolveConstructedType() on it to resolve it without checking
7356 (Constraints.ResolveTypes): Check them here.
7357 (ConstructedType.DoResolveAsTypeStep): Fully resolve ourselves,
7358 but don't check constraints.
7359 (ConstructedType.ResolveAsTypeTerminal): Override this and also
7360 check constraints here.
7361 (ConstructedType.ResolveConstructedType): New public method. This
7362 is called from DoResolveAsTypeStep() and Constraints.Resolve() to
7363 resolve ourselves without checking constraints.
7365 * ecore.cs (Expression.ResolveAsTypeTerminal): Make this virtual.
7367 2004-11-18 Martin Baulig <martin@ximian.com>
7370 (DeclSpace.CurrentType): Changed type from `TypeExpr' to `Type'.
7372 * delegate.cs (Delegate.DefineType): Always create the EmitContext.
7374 2004-11-18 Martin Baulig <martin@ximian.com>
7376 * ecore.cs (TypeExpr.ResolveType): Removed.
7377 (Expression.ResolveAsTypeTerminal): We always return a fully
7378 resolved `TypeExpr', so we can just access its `Type'.
7380 * class.cs (TypeContainer.DefineType): Resolve `CurrentType' here.
7382 2004-11-17 Martin Baulig <martin@ximian.com>
7384 * ecore.cs (IAlias.Type): Replaced with ResolveAsType() to make
7385 sure we don't return any unresolved TypeExpr's.
7386 (TypeAliasExpression): The .ctor now takes an `IAlias' instead of
7388 (Expression.ResolveAsTypeTerminal): Make sure `te.Type != null'.
7390 * expression.cs (MemberAccess.ResolveAsTypeStep): Don't return any
7391 unresolved `ConstructedType's.
7393 2004-11-17 Martin Baulig <martin@ximian.com>
7395 * ecore.cs (TypeExpr.ResolveType): Don't make this virtual.
7397 2004-11-17 Martin Baulig <martin@ximian.com>
7400 (Expression.ResolveAsTypeTerminal): Removed the `bool silent' argument.
7402 * decl.cs (DeclSpace.ResolveType): Removed.
7403 (DeclSpace.ResolveTypeExpr): Removed the `bool silent' argument.
7405 2004-11-17 Martin Baulig <martin@ximian.com>
7407 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
7408 direction, like FindMembers() does. Fixes #69546, testcase is in
7411 2004-11-16 Martin Baulig <martin@ximian.com>
7413 This is based on a patch from Marek Safar, see bug #69082.
7414 Fixes bugs #63705 and #67130.
7416 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
7417 method; create a MemberCache for an interface type and cache the
7420 * decl.cs (IMemberContainer.ParentContainer): Removed.
7421 (IMemberContainer.ParentCache): New property.
7422 (MemberCache.SetupCacheForInterface): Removed.
7423 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
7424 to create a cache for an interface's "parent".
7426 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
7429 2004-11-14 Ben Maurer <bmaurer@ximian.com>
7431 * statement.cs: Avoid adding bools to a hashtable.
7433 2004-11-15 Martin Baulig <martin@ximian.com>
7435 * decl.cs (MemberName.GetPartialName): Removed, use GetTypeName() instead.
7437 2004-11-11 Martin Baulig <martin@ximian.com>
7439 * typemanager.cs (TypeManager.GetMethodName): New method.
7441 * class.cs (MethodData.Define): Include the generic arity in the
7442 name of an explicit interface; also add it to the method name.
7444 * pending.cs (PendingImplementation.InterfaceMethod): The method
7445 name now includes the generic arity.
7447 2004-11-07 Miguel de Icaza <miguel@ximian.com>
7449 * expression.cs (Invocation.OverloadResolve): Flag error if we are
7450 calling an unsafe method from a safe location.
7452 2004-11-06 Marek Safar <marek.safar@seznam.cz>
7455 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
7457 2004-11-06 Miguel de Icaza <miguel@ximian.com>
7459 * namespace.cs (VerifyUsing): use GetPartialName instead of
7462 2004-11-05 Miguel de Icaza <miguel@ximian.com>
7464 * statement.cs (Return.Resolve): Fix regression in typo: if
7465 `in_exc', we have to request a NeedReturnLabel, this was a typo
7466 introduced in the anonymous method check-in. Fixes #69131.
7468 * Indexers were using the ShortName when defining themselves,
7469 causing a regression in the compiler bootstrap when applying the
7470 patch from 2004-11-02 (first part), now they use their full name
7471 and the bug is gone.
7473 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
7475 * driver.cs: Strip the path from the names of embedded resources. Fixes
7478 2004-11-04 Raja R Harinath <rharinath@novell.com>
7480 Fix error message regression: cs0104-2.cs.
7481 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
7482 (AliasEntry.Resolve): Update.
7483 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
7485 (RootContext.LookupType): Update.
7487 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
7489 * cs-parser.jay: Add support for handling accessor modifiers
7490 * class: Add support port accessor modifiers and error checking,
7491 define PropertyMethod.Define as virtual (not abstract anymore)
7492 * ecore.cs: Add checking for proeprties access with access modifiers
7493 * iterators.cs: Modify Accessor constructor call based in the modified
7495 2004-11-02 Ben Maurer <bmaurer@ximian.com>
7497 * expression.cs (StringConcat): Handle being called twice,
7498 as when we have a concat in a field init with more than two
7501 2004-11-02 Miguel de Icaza <miguel@ximian.com>
7503 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
7504 special case explicit implementations, we should always produce
7505 the .property or .event declaration.
7507 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
7508 since it will not return correct data if people use this
7509 unresolved in the presence of using statements (see test-313).
7511 * class.cs (MethodData.Define): If we are an explicit interface
7512 implementation, set the method name to the full name of the
7513 interface plus the name of the method.
7515 Notice that using the method.MethodName.GetFullName() does not
7516 work, as it will only contain the name as declared on the source
7517 file (it can be a shorthand in the presence of using statements)
7518 and not the fully qualifed type name, for example:
7522 class D : ICloneable {
7523 object ICloneable.Clone () {
7527 Would produce a method called `ICloneable.Clone' instead of
7528 `System.ICloneable.Clone'.
7530 * namespace.cs (Alias.Resolve): Use GetPartialName.
7532 2004-11-01 Marek Safar <marek.safar@seznam.cz>
7534 * cs-parser.jay: Add error 1055 report.
7536 2004-11-01 Miguel de Icaza <miguel@ximian.com>
7538 * assign.cs (Assign.DoResolve): Only do the transform of
7539 assignment into a New if the types are compatible, if not, fall
7540 through and let the implicit code deal with the errors and with
7541 the necessary conversions.
7543 2004-11-01 Marek Safar <marek.safar@seznam.cz>
7545 * cs-parser.jay: Add error 1031 report.
7547 * cs-tokenizer.cs: Add location for error 1038.
7549 2004-10-31 Marek Safar <marek.safar@seznam.cz>
7551 * cs-parser.jay: Add error 1016 report.
7553 2004-10-31 Marek Safar <marek.safar@seznam.cz>
7555 * cs-parser.jay: Add errors 1575,1611 report.
7557 2004-10-31 Marek Safar <marek.safar@seznam.cz>
7559 * cs-parser.jay: Add error 1001 report.
7561 2004-10-31 Marek Safar <marek.safar@seznam.cz>
7564 * attribute.cs (GetMarshal): Add method argument for
7565 caller identification.
7567 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
7568 agument for GetMarshal and RuntimeMissingSupport.
7570 2004-10-31 Marek Safar <marek.safar@seznam.cz>
7572 * attribute.cs (ExtractSecurityPermissionSet): Removed
7573 TypeManager.code_access_permission_type.
7575 * typemanager.cs: Removed TypeManager.code_access_permission_type.
7577 2004-10-27 Miguel de Icaza <miguel@ximian.com>
7579 * expression.cs (LocalVariableReference.DoResolveLValue): Check
7580 for obsolete use of a variable here. Fixes regression on errors
7581 cs0619-25 and cs0619-26.
7583 2004-10-27 Marek Safar <marek.safar@seznam.cz>
7585 Fix #62358, implemented security attribute encoding.
7587 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
7588 Tests permitted SecurityAction for assembly or other types.
7589 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
7590 data from SecurityPermissionAttribute to PermisionSet class.
7592 * class.cs (ApplyAttributeBuilder): Added special handling
7593 for System.Security.Permissions.SecurityAttribute based types.
7595 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
7596 special handling for System.Security.Permissions.SecurityAttribute
7599 * enum.cs (ApplyAttributeBuilder): Added special handling
7600 for System.Security.Permissions.SecurityAttribute based types.
7602 * parameter.cs (ApplyAttributeBuilder): Added special handling
7603 for System.Security.Permissions.SecurityAttribute based types.
7605 * rootcontext.cs: Next 2 core types.
7607 * typemanager.cs (TypeManager.security_permission_attr_type):
7608 Built in type for the SecurityPermission Attribute.
7609 (code_access_permission_type): Build in type.
7611 2004-10-17 Miguel de Icaza <miguel@ximian.com>
7613 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
7614 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
7615 all of this information into
7616 EmitContext.EmitCapturedVariableInstance.
7618 * codegen.cs (EmitCapturedVariableInstance): move here the
7619 funcionality of emitting an ldarg.0 in the presence of a
7620 remapping. This centralizes the instance emit code.
7622 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
7623 then emit a load of this: it means that we have reached the
7624 topmost ScopeInfo: the one that contains the pointer to the
7625 instance of the class hosting the anonymous method.
7627 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
7628 captures to the topmost CaptureContext.
7630 2004-10-12 Miguel de Icaza <miguel@ximian.com>
7632 * expression.cs (LocalVariableReference): Move the knowledge about
7633 the iterators into codegen's EmitCapturedVariableInstance.
7635 2004-10-11 Miguel de Icaza <miguel@ximian.com>
7637 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
7638 all code paths return a value from an anonymous method (it is the
7639 same as the 161 error, but for anonymous methods).
7641 2004-10-08 Miguel de Icaza <miguel@ximian.com>
7643 The introduction of anonymous methods in the compiler changed
7644 various ways of doing things in the compiler. The most
7645 significant one is the hard split between the resolution phase
7646 and the emission phases of the compiler.
7648 For instance, routines that referenced local variables no
7649 longer can safely create temporary variables during the
7650 resolution phase: they must do so from the emission phase,
7651 since the variable might have been "captured", hence access to
7652 it can not be done with the local-variable operations from the runtime.
7656 (Block.Flags): New flag `IsTopLevel' to indicate that this block
7657 is a toplevel block.
7659 (ToplevelBlock): A new kind of Block, these are the blocks that
7660 are created by the parser for all toplevel method bodies. These
7661 include methods, accessors and anonymous methods.
7663 These contain some extra information not found in regular blocks:
7664 A pointer to an optional CaptureContext (for tracking captured
7665 local variables and parameters). A pointer to the parent
7668 (Return.Resolve): Catch missmatches when returning a value from an
7669 anonymous method (error 1662).
7670 Invoke NeedReturnLabel from the Resolve phase instead of the emit
7673 (Break.Resolve): ditto.
7675 (SwitchLabel): instead of defining the labels during the
7676 resolution phase, we now turned the public ILLabel and ILLabelCode
7677 labels into methods called GetILLabelCode() and GetILLabel() that
7678 only define the label during the Emit phase.
7680 (GotoCase): Track the SwitchLabel instead of the computed label
7681 (its contained therein). Emit the code by using
7682 SwitchLabel.GetILLabelCode ().
7684 (LocalInfo.Flags.Captured): A new flag has been introduce to track
7685 whether the Local has been captured or not.
7687 (LocalInfo.IsCaptured): New property, used to tell whether the
7688 local has been captured.
7690 * anonymous.cs: Vastly updated to contain the anonymous method
7693 The main classes here are: CaptureContext which tracks any
7694 captured information for a toplevel block and ScopeInfo used to
7695 track the activation frames for various local variables.
7697 Each toplevel block has an optional capture context associated
7698 with it. When a method contains an anonymous method both the
7699 toplevel method and the anonymous method will create a capture
7700 context. When variables or parameters are captured, they are
7701 recorded on the CaptureContext that owns them, for example:
7705 MyDelegate d = delegate {
7710 Here `a' will be recorded as captured on the toplevel
7711 CapturedContext, the inner captured context will not have anything
7712 (it will only have data if local variables or parameters from it
7713 are captured in a nested anonymous method.
7715 The ScopeInfo is used to track the activation frames for local
7716 variables, for example:
7718 for (int i = 0; i < 10; i++)
7719 for (int j = 0; j < 10; j++){
7720 MyDelegate d = delegate {
7725 At runtime this captures a single captured variable `i', but it
7726 captures 10 different versions of the variable `j'. The variable
7727 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
7728 recorded on a child.
7730 The toplevel ScopeInfo will also track information like the `this'
7731 pointer if instance variables were referenced (this is necessary
7732 as the anonymous method lives inside a nested class in the host
7733 type of the method).
7735 (AnonymousMethod): Expanded to track the Toplevel, implement
7736 `AnonymousMethod.Compatible' to tell whether an anonymous method
7737 can be converted to a target delegate type.
7739 The routine now also produces the anonymous method content
7741 (AnonymousDelegate): A helper class that derives from
7742 DelegateCreation, this is used to generate the code necessary to
7743 produce the delegate for the anonymous method that was created.
7745 * assign.cs: API adjustments for new changes in
7746 Convert.ImplicitStandardConversionExists.
7748 * class.cs: Adjustments to cope with the fact that now toplevel
7749 blocks are of type `ToplevelBlock'.
7751 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
7752 insteda of standard blocks.
7754 Flag errors if params arguments are passed to anonymous methods.
7756 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
7757 `CurrentAnonymousMethod' which points to the current Anonymous
7758 Method. The variable points to the AnonymousMethod class that
7759 holds the code being compiled. It is set in the new EmitContext
7760 created for the anonymous method.
7762 (EmitContext.Phase): Introduce a variable and an enumeration to
7763 assist in enforcing some rules about when and where we are allowed
7764 to invoke certain methods (EmitContext.NeedsReturnLabel is the
7765 only one that enfonces this right now).
7767 (EmitContext.HaveCaptureInfo): new helper method that returns
7768 whether we have a CapturedContext initialized.
7770 (EmitContext.CaptureVariable): New method used to register that a
7771 LocalInfo must be flagged for capturing.
7773 (EmitContext.CapturedParameter): New method used to register that a
7774 parameters must be flagged for capturing.
7776 (EmitContext.CapturedField): New method used to register that a
7777 field must be flagged for capturing.
7779 (EmitContext.HaveCapturedVariables,
7780 EmitContext.HaveCapturedFields): Return whether there are captured
7781 variables or fields.
7783 (EmitContext.EmitMethodHostInstance): This is used to emit the
7784 instance for the anonymous method. The instance might be null
7785 (static methods), this (for anonymous methods that capture nothing
7786 and happen to live side-by-side with the current method body) or a
7787 more complicated expression if the method has a CaptureContext.
7789 (EmitContext.EmitTopBlock): Routine that drives the emission of
7790 code: it will first resolve the top block, then emit any metadata
7791 and then emit the code. The split is done so that we can extract
7792 any anonymous methods and flag any captured variables/parameters.
7794 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
7795 during this phase, the ILGenerator should not be used as labels
7796 and local variables declared here might not be accessible to any
7797 code that is part of an anonymous method.
7799 Exceptions to this include the temporary variables that are
7800 created by some statements internally for holding temporary
7803 (EmitContext.EmitMeta): New routine, in charge of emitting all the
7806 (EmitContext.TemporaryReturn): This method is typically called
7807 from the Emit phase, and its the only place where we allow the
7808 ReturnLabel to be defined other than the EmitMeta. The reason is
7809 that otherwise we would have to duplicate a lot of logic in the
7810 Resolve phases of various methods that today is on the Emit
7813 (EmitContext.NeedReturnLabel): This no longer creates the label,
7814 as the ILGenerator is not valid during the resolve phase.
7816 (EmitContext.EmitThis): Extended the knowledge in this class to
7817 work in anonymous methods in addition to iterators.
7819 (EmitContext.EmitCapturedVariableInstance): This emits whatever
7820 code is necessary on the stack to access the instance to a local
7821 variable (the variable will be accessed as a field).
7823 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
7824 EmitContext.EmitAddressOfParameter): Routines to support
7825 parameters (not completed at this point).
7827 Removals: Removed RemapLocal and RemapLocalLValue. We probably
7828 will also remove the parameters.
7830 * convert.cs (Convert): Define a `ConstantEC' which points to a
7831 null. This is just to prefity some code that uses
7832 ImplicitStandardConversion code and do not have an EmitContext
7835 The idea is to flag explicitly that at that point in time, it is
7836 known that the conversion will not trigger the delegate checking
7837 code in implicit conversions (which requires a valid
7840 Everywhere: pass new EmitContext parameter since
7841 ImplicitStandardConversionExists now requires it to check for
7842 anonymous method conversions.
7844 (Convert.ImplicitStandardConversionExists): If the type of an
7845 expression is the anonymous_method_type, and the type is a
7846 delegate, we invoke the AnonymousMethod.Compatible method to check
7847 whether an implicit conversion is possible.
7849 (Convert.ImplicitConversionStandard): Only do implicit method
7850 group conversions if the language level is not ISO_1.
7852 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
7853 MethodInfo for the Invoke method. used by Delegate and
7856 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
7857 method conversions if the target type is a delegate.
7859 Removed extra debugging nops.
7861 (LocalVariableReference): Turn the `local_info' into a public
7864 Add `prepared' field, the same hack used for FieldExprs to cope
7865 with composed assignments, as Local variables do not necessarily
7866 operate purely on the stack as they used to: they can be captured
7869 Add `temp' for a temporary result, like fields.
7871 Refactor DoResolve and DoResolveLValue into DoResolveBase.
7873 It now copes with Local variables that are captured and emits the
7874 proper instance variable to load it from a field in the captured
7877 (ParameterReference.DoResolveBase): During the resolve phase,
7878 capture parameters if we are in an anonymous method.
7880 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
7881 anonymous method, use the EmitContext helper routines to emit the
7882 parameter reference.
7884 * iterators.cs: Set RemapToProxy to true/false during the
7887 * parameters.cs (GetParameterByName): New helper method.
7889 * typemanager.cs (anonymous_method_type) a new type that
7890 represents an anonyous method. This is always an internal type,
7891 used as a fencepost to test against the anonymous-methodness of an
7894 2004-10-20 Marek Safar <marek.safar@seznam.cz>
7896 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
7898 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
7900 2004-11-10 Martin Baulig <martin@ximian.com>
7902 * expression.cs (Invocation.BetterFunction): If two methods have
7903 equal parameter types, but only one of them is generic, the
7904 non-generic one wins.
7905 (New.DoResolve): Don't set `is_struct' to false if we're a generic
7906 instance; just use `Type.IsValueType' to determine whether
7907 something is a struct or not.
7908 (MemberAccess.DoResolveAsTypeStep): Don't modify the `args' field,
7909 so we can be called multiple times.
7911 2004-11-10 Martin Baulig <martin@ximian.com>
7913 * generic.cs (TypeParameter.DefineConstraints): New public method.
7914 (TypeParameter.CheckAccessLevel): Override this and return true.
7915 (ConstructedType.ResolveType): Renamed to DoResolveType(), don't
7916 override ResolveType() anymore.
7917 (ConstructedType.DoResolveAsTypeStep): Call DoResolveType() here.
7919 2004-11-10 Martin Baulig <martin@ximian.com>
7921 * rootcontext.cs (RootContext.LookupType): If we're a nested type,
7922 call DeclSpace.ResolveNestedType() on it.
7924 2004-11-10 Martin Baulig <martin@ximian.com>
7926 * support.cs (ReflectionParameters.ParameterModifier): If `gpd' is
7927 non-null, call ParameterModifier() on it.
7929 2004-11-10 Martin Baulig <martin@ximian.com>
7932 (Iterators): Added `current_type' and `this_type' fields.
7933 (Iterators.DefineIterator): Create a new EmitContext and store it
7934 in `ec'; compute `this_type'.
7936 2004-11-10 Martin Baulig <martin@ximian.com>
7939 (TypeManager.IsPrivateAccessible): New public method.
7940 (Closure.Filter): Use IsPrivateAccessible() instead of IsEqual().
7942 2004-11-10 Martin Baulig <martin@ximian.com>
7944 * class.cs (TypeContainer.DefineType): Call
7945 TypeBuilder.DefineGenericParameters() before resolving the type
7947 (MethodData.parent_method): New protected field.
7948 (MethodData..ctor): Added `MethodInfo parent_method' argument.
7949 (MethodData.Define): Compute `parent_method'.
7952 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
7953 (MemberCore.GetClsCompliantAttributeValue): Likewise.
7954 (DeclSpace.ec): New protected field; store the EmitContext here.
7955 (DeclSpace.EmitContext): New public property.
7956 (DeclSpace.ResolveType): Un-comment from the [Obsolte] attribute.
7957 (DeclSpace.ResolveNestedType): New public method.
7958 (DeclSpace.ResolveTypeExpr): Just call ResolveAsTypeTerminal() here.
7959 (DeclSpace.NestedAccessible): Added `Type tb' argument.
7960 (DeclSpace.FamilyAccessible): Likewise.
7961 (DeclSpace.FindType): Call ResolveNestedType() for nested types.
7962 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
7965 * delegate.cs (Delegate.Define): Store the EmitContext in the `ec'
7968 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
7969 (Enum.Emit): Don't create a new EmitContext.
7971 2004-10-18 Martin Baulig <martin@ximian.com>
7973 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
7974 `Type' directly, but call ResolveType() on it.
7975 (Catch.Resolve): Likewise.
7976 (Foreach.Resolve): Likewise.
7978 2004-10-18 Martin Baulig <martin@ximian.com>
7980 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
7981 `Type' directly, but call ResolveType() on it.
7982 (Probe.DoResolve): Likewise.
7983 (ArrayCreation.LookupType): Likewise.
7984 (TypeOf.DoResolve): Likewise.
7985 (SizeOf.DoResolve): Likewise.
7987 2004-10-18 Raja R Harinath <rharinath@novell.com>
7989 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
7992 2004-10-17 John Luke <john.luke@gmail.com>
7994 * class.cs (Operator.GetSignatureForError): use CSharpName
7996 * parameter.cs (Parameter.GetSignatureForError): Returns
7997 correct name even if was not defined.
7999 2004-10-13 Raja R Harinath <rharinath@novell.com>
8002 * class.cs (TypeContainer.EmitContext): New property.
8003 (DefineNestedTypes): Create an emitcontext for each part.
8004 (MethodCore.DoDefineParameters): Use container's emitcontext.
8005 Pass type array to InternalParameters.
8006 (MemberBase.DoDefine): Use container's emitcontext.
8007 (FieldMember.Define): Likewise.
8008 (Event.Define): Likewise.
8009 (SetMethod.GetParameterInfo): Change argument to EmitContext.
8010 Pass type array to InternalParameters.
8011 (SetIndexerMethod.GetParameterInfo): Likewise.
8012 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
8013 * delegate.cs (Define): Pass emitcontext to
8014 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
8015 array to InternalParameters.
8016 * expression.cs (ParameterReference.DoResolveBase): Pass
8017 emitcontext to GetParameterInfo.
8018 (ComposedCast.DoResolveAsTypeStep): Remove check on
8019 ec.ResolvingTypeTree.
8020 * parameter.cs (Parameter.Resolve): Change argument to
8021 EmitContext. Use ResolveAsTypeTerminal.
8022 (Parameter.GetSignature): Change argument to EmitContext.
8023 (Parameters.ComputeSignature): Likewise.
8024 (Parameters.ComputeParameterTypes): Likewise.
8025 (Parameters.GetParameterInfo): Likewise.
8026 (Parameters.ComputeAndDefineParameterTypes): Likewise.
8027 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
8028 * support.cs (InternalParameters..ctor): Remove variant that takes
8030 * typemanager.cs (system_intptr_expr): New.
8031 (InitExpressionTypes): Initialize it.
8033 2004-10-12 Chris Toshok <toshok@ximian.com>
8035 * cs-parser.jay: fix location for try_statement and catch_clause.
8037 2004-10-18 Martin Baulig <martin@ximian.com>
8039 * class.cs (FieldMember.Define): Don't access the TypeExpr's
8040 `Type' directly, but call ResolveType() on it.
8041 (MemberBase.DoDefine): Likewise.
8043 * expression.cs (New.DoResolve): Don't access the TypeExpr's
8044 `Type' directly, but call ResolveType() on it.
8045 (ComposedCast.DoResolveAsTypeStep): Likewise.
8047 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
8048 `Type' directly, but call ResolveType() on it.
8050 2004-10-17 John Luke <john.luke@gmail.com>
8052 * class.cs (Operator.GetSignatureForError): use CSharpName
8054 * parameter.cs (Parameter.GetSignatureForError): Returns
8055 correct name even if was not defined.
8057 2004-10-13 Raja R Harinath <rharinath@novell.com>
8060 * class.cs (TypeContainer.EmitContext): New property.
8061 (DefineNestedTypes): Create an emitcontext for each part.
8062 (MethodCore.DoDefineParameters): Use container's emitcontext.
8063 Pass type array to InternalParameters.
8064 (MemberBase.DoDefine): Use container's emitcontext.
8065 (FieldMember.Define): Likewise.
8066 (Event.Define): Likewise.
8067 (SetMethod.GetParameterInfo): Change argument to EmitContext.
8068 Pass type array to InternalParameters.
8069 (SetIndexerMethod.GetParameterInfo): Likewise.
8070 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
8071 * delegate.cs (Define): Pass emitcontext to
8072 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
8073 array to InternalParameters.
8074 * expression.cs (ParameterReference.DoResolveBase): Pass
8075 emitcontext to GetParameterInfo.
8076 (ComposedCast.DoResolveAsTypeStep): Remove check on
8077 ec.ResolvingTypeTree.
8078 * parameter.cs (Parameter.Resolve): Change argument to
8079 EmitContext. Use ResolveAsTypeTerminal.
8080 (Parameter.GetSignature): Change argument to EmitContext.
8081 (Parameters.ComputeSignature): Likewise.
8082 (Parameters.ComputeParameterTypes): Likewise.
8083 (Parameters.GetParameterInfo): Likewise.
8084 (Parameters.ComputeAndDefineParameterTypes): Likewise.
8085 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
8086 * support.cs (InternalParameters..ctor): Remove variant that takes
8088 * typemanager.cs (system_intptr_expr): New.
8089 (InitExpressionTypes): Initialize it.
8091 2004-10-12 Chris Toshok <toshok@ximian.com>
8093 * cs-parser.jay: fix location for try_statement and catch_clause.
8095 2004-10-07 Raja R Harinath <rharinath@novell.com>
8097 More DeclSpace.ResolveType avoidance.
8098 * decl.cs (MemberCore.InUnsafe): New property.
8099 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
8100 with newly created EmitContext.
8101 (FieldMember.Define): Likewise.
8102 * delegate.cs (Delegate.Define): Likewise.
8103 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
8104 only if normal name-lookup fails.
8105 (TypeExpr.DoResolve): Enable error-checking.
8106 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
8107 (SizeOf.DoResolve): Likewise.
8108 (ComposedCast.DoResolveAsTypeStep): Likewise.
8109 (StackAlloc.DoResolve): Likewise.
8110 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
8111 (Block.Unsafe): New property.
8112 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
8113 (Unsafe): Set 'unsafe' flag of contained block.
8114 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
8115 (Fixed.Resolve): Likewise.
8116 (Catch.Resolve): Likewise.
8117 (Using.ResolveLocalVariableDecls): Likewise.
8118 (Foreach.Resolve): Likewise.
8120 2004-10-05 John Luke <john.luke@gmail.com>
8122 * cs-parser.jay: add location to error CS0175
8124 2004-10-04 Miguel de Icaza <miguel@ximian.com>
8126 * ecore.cs (Expression.Constantity): Add support for turning null
8129 * const.cs (Const.Define): Allow constants to be reference types
8130 as long as the value is Null.
8132 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
8134 * namespace.cs (NamespaceEntry.Using): No matter which warning
8135 level is set, check if this namespace name has already been added.
8137 2004-10-03 Ben Maurer <bmaurer@ximian.com>
8139 * expression.cs: reftype [!=]= null should always use br[true,false].
8142 2004-10-03 Marek Safar <marek.safar@seznam.cz>
8145 * attribute.cs: Enum conversion moved to
8146 GetAttributeArgumentExpression to be applied to the all
8149 2004-10-01 Raja R Harinath <rharinath@novell.com>
8151 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
8152 * class.c (TypeContainer.DefineType): Flag error if
8153 base types aren't accessible due to access permissions.
8154 * decl.cs (DeclSpace.ResolveType): Move logic to
8155 Expression.ResolveAsTypeTerminal.
8156 (DeclSpace.ResolveTypeExpr): Thin layer over
8157 Expression.ResolveAsTypeTerminal.
8158 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
8159 Refactor code into NestedAccess. Use it.
8160 (DeclSpace.NestedAccess): New.
8161 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
8162 argument to silence errors. Check access permissions.
8163 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
8164 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
8165 (Cast.DoResolve): Likewise.
8166 (New.DoResolve): Likewise.
8167 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
8168 (TypeOf.DoResolve): Likewise.
8170 * expression.cs (Invocation.BetterConversion): Return the Type of
8171 the better conversion. Implement section 14.4.2.3 more faithfully.
8172 (Invocation.BetterFunction): Make boolean. Make correspondence to
8173 section 14.4.2.2 explicit.
8174 (Invocation.OverloadResolve): Update.
8175 (Invocation): Remove is_base field.
8176 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
8177 (Invocation.Emit): Likewise.
8179 2004-09-24 Marek Safar <marek.safar@seznam.cz>
8181 * cs-parser.jay: Reverted 642 warning fix.
8183 2004-09-23 Marek Safar <marek.safar@seznam.cz>
8186 * decl.cs (FindMemberWithSameName): Indexer can have more than
8189 2004-09-23 Marek Safar <marek.safar@seznam.cz>
8191 * expression.cs (LocalVariableReference.DoResolveLValue):
8192 Do not report warning 219 for out values.
8193 (EmptyExpression.Null): New member to avoid extra allocations.
8195 2004-09-23 Marek Safar <marek.safar@seznam.cz>
8197 * cs-parser.jay: Fix wrong warning 642 report.
8199 * cs-tokenizer.cs (CheckNextToken): New helper;
8200 Inspect next character if is same as expected.
8202 2004-09-23 Martin Baulig <martin@ximian.com>
8204 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
8205 (Convert.ImplicitReferenceConversionExists): Likewise.
8207 2004-11-09 Raja R Harinath <rharinath@novell.com>
8209 * Makefile (DISTFILES): Comment out a few missing files.
8211 2004-10-29 Raja R Harinath <rharinath@novell.com>
8213 * Makefile (bootstrap_libs,bootstrap_libfiles): New.
8214 (bootstrap-libs): New target. Invokes the net_2_0_bootstrap profile.
8215 (gmcs.exe): Invoke bootstrap-libs.
8216 (clean-local): Clean the net_2_0_bootstrap profile too.
8217 (PROGRAM_INSTALL_DIR): New.
8218 (install-local): Use it.
8220 2004-10-13 Martin Baulig <martin@ximian.com>
8222 * generic.cs (TypeManager.InflatedConstraints): New nested class.
8223 (TypeParameter.DefineType): If we're a method type parameter and
8224 that method is overriding something, "inflate" its constraints.
8226 2004-10-12 Martin Baulig <martin@ximian.com>
8228 * expression.cs (MemberAccess.DoResolve): If we're a SimpleName
8229 and have type arguments, create and resolve a ConstructedType.
8231 2004-10-12 Martin Baulig <martin@ximian.com>
8233 * decl.cs (MemberCache.FindMemberToOverride): Use
8234 TypeManager.IsEqual() to compare the parameters and Type.Equals()
8235 to compare the invocationType.
8237 * typemanager.cs (TypeManager.IsEqual): Added support for arrays.
8238 When comparing two type parameters, only do the signature-only
8239 comparision for method type parameters.
8241 2004-10-11 Martin Baulig <martin@ximian.com>
8243 * report.cs: Don't make --fatal abort on warnings, we have
8244 -warnaserror for that.
8246 2004-10-11 Martin Baulig <martin@ximian.com>
8249 (TypeManager.IsEqualGenericType): Removed, use IsEqual() instead.
8250 (TypeManager.IsEqual): Call ourself recursively instead of using
8253 2004-10-11 Martin Baulig <martin@ximian.com>
8255 * class.cs (TypeContainer.DefineType): Only call TypeParameter.Define()
8256 on our own type parameters, not on the ones we inherit from a containing
8259 * expression.cs (Invocation.InferType): Use `==', not `Equals()' for
8262 * generic.cs (TypeParameter.Define): We may only be called once.
8264 * pending.cs (Pending.InterfaceMethod): Call TypeManager.Real_IsEqual()
8265 instead of TypeManager.IsEqual().
8267 2004-09-28 Martin Baulig <martin@ximian.com>
8270 (GenericConstraints.EffectiveBaseClass): New public property.
8271 (TypeParameter.GenericConstraints): New public property.
8272 (ConstructedType.CheckConstraints): Improved.
8274 * convert.cs (Convert.TypeParam_EffectiveBaseType): New private method.
8275 (Convert.TypeParameterConversion): New private method; use this in
8276 ImplicitReferenceConversion() and ImplicitReferenceConversionExists()
8277 for all conversions related to type parameters.
8279 2004-09-24 Martin Baulig <martin@ximian.com>
8281 * convert.cs (Convert.ImplicitReferenceConversion): Added implicit
8282 type parameter conversions for type parameters which are known to
8285 2004-09-24 Martin Baulig <martin@ximian.com>
8287 * generic.cs (GenericConstraints): Added `IsReferenceType' and
8288 `IsValueType' properties.
8290 * support.cs (ReflectionConstraints): Use
8291 Type.GetGenericParameterConstraints() instead of the old hack.
8293 2004-09-24 Martin Baulig <martin@ximian.com>
8295 * generic.cs (GenericConstraints): Moved here and made it an
8298 * support.cs (GenericConstraints): Moved to generic.cs.
8300 2004-09-24 Martin Baulig <martin@ximian.com>
8303 (ReflectionConstraints): Un-nested this class and made it public.
8306 (TypeManager.GetTypeParameterConstraints): New public method.
8307 (TypeManager.HasConstructorConstraint): Use the attributes.
8309 2004-09-24 Martin Baulig <martin@ximian.com>
8311 * support.cs (GenericConstraints): Replaced `HasConstructor',
8312 `IsReferenceType' and `IsValueType' with `Attributes'.
8313 (ReflectionParameters.ReflectionConstraints): Removed the Create()
8314 method and made the .ctor public.
8316 * generic.cs (Constraints.Attributes): New public property.
8317 (Constraints): Renamed `HasConstructor' -> `HasConstructorConstraint',
8318 `IsReferenceType' -> `HasReferenceTypeConstraint' and
8319 `IsValueType' -> `HasValueTypeConstraint'.
8321 2004-09-23 Martin Baulig <martin@ximian.com>
8323 * generic.cs (Constraints): Reflect latest runtime changes.
8325 2004-09-23 Martin Baulig <martin@ximian.com>
8327 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
8328 (Convert.ImplicitReferenceConversionExists): Likewise.
8330 2004-09-23 Marek Safar <marek.safar@seznam.cz>
8332 * class.cs (Operator.Define): Add error 448 and 559 report.
8334 2004-09-22 Marek Safar <marek.safar@seznam.cz>
8336 * class.cs (MemberBase.IsTypePermitted): New protected
8337 method for checking error CS0610.
8339 2004-09-22 Marek Safar <marek.safar@seznam.cz>
8341 * class.cs (TypeContainer.HasExplicitLayout): New property
8342 Returns whether container has StructLayout attribute set Explicit.
8343 (FieldMember): New abstract class for consts and fields.
8344 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
8345 (Field): Reuse FieldMember.
8347 * const.cs (Const): Reuse FieldMember.
8349 * rootcontext.cs: EmitConstants call moved to class.
8351 2004-09-22 Martin Baulig <martin@ximian.com>
8353 Marek and me just fixed one of our oldest bugs: #28562 :-)
8355 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
8357 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
8358 we're an EnumConstant, just return that.
8359 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
8360 an EnumConstant. In this case, we need to use GetValueAsEnumType()
8361 to get the value which'll actually be written into the attribute.
8362 However, we have to use GetValue() to access the attribute's value
8365 2004-09-22 Marek Safar <marek.safar@seznam.cz>
8367 * constant.cs (Constant.IsNegative): New abstract property
8370 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
8371 (StackAlloc.DoResolve): Reused IsNegative.
8373 2004-09-22 Martin Baulig <martin@ximian.com>
8375 * typemanager.cs (TypeManager.LookupGenericTypeContainer): New
8376 public method; like LookupTypeContainer, but also works for
8379 * report.cs (Report.SymbolRelatedToPreviousError): Use
8380 TypeManager.LookupGenericTypeContainer().
8382 2004-09-22 Martin Baulig <martin@ximian.com>
8384 Thanks to Peter Sestoft for this bug report.
8386 * expression.cs (Conditional): If both the `trueExpr' and the
8387 `falseExpr' is a NullLiteral, return a NullLiteral.
8389 2004-09-22 Martin Baulig <martin@ximian.com>
8391 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
8392 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
8393 for the "get_Current" call.
8395 2004-09-21 Martin Baulig <martin@ximian.com>
8397 * convert.cs (Convert.ImplicitReferenceConversion): When
8398 converting to an interface type, first check whether we're
8399 converting from a reference type.
8401 2004-09-14 Martin Baulig <martin@ximian.com>
8403 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
8405 2004-09-14 Marek Safar <marek.safar@seznam.cz>
8408 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
8409 called and is obsolete then this member suppress message
8410 when call is inside next [Obsolete] method or type.
8412 * expression.cs: Use TestObsoleteMethodUsage member.
8414 2004-09-14 Martin Baulig <martin@ximian.com>
8416 * genericparser.cs: Removed.
8418 2004-09-13 Marek Safar <marek.safar@seznam.cz>
8420 * class.cs (MethodCore.CheckBase): Fix bug #65757.
8422 2004-09-12 Marek Safar <marek.safar@seznam.cz>
8424 * attribute.cs (Attribute.Resolve): Add error 653 report.
8426 * class.cs (Class.ApplyAttributeBuilder): Add error 641
8428 (Method.ApplyAttributeBuilder): Add error 685 report.
8429 (Operator.Define): Add error 564 report.
8431 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
8433 * expression.cs (Invocation.DoResolve): Add error
8436 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
8439 2004-09-11 Marek Safar <marek.safar@seznam.cz>
8441 * class.cs (ConstructorInitializer.Resolve):
8442 Wrong error number (515->516).
8444 2004-09-11 Marek Safar <marek.safar@seznam.cz>
8446 * class.cs (Indexer.Define): Add error 631 report.
8448 2004-09-11 Marek Safar <marek.safar@seznam.cz>
8450 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
8452 2004-09-11 Marek Safar <marek.safar@seznam.cz>
8454 * expression.cs (Probe.DoResolve): Add error CS0241 report.
8456 2004-09-10 Marek Safar <marek.safar@seznam.cz>
8458 * cs-parser.jay: Added error CS0241 report.
8460 2004-09-10 Raja R Harinath <rharinath@novell.com>
8462 * cs-parser.jay (fixed_statement): Introduce a scope for the
8463 declaration in the 'fixed' statement.
8465 2004-09-09 Marek Safar <marek.safar@seznam.cz>
8467 * cs-parser.jay: Added CS0230 error report.
8469 2004-09-09 Marek Safar <marek.safar@seznam.cz>
8471 * cs-parser.jay: Added errors CS0231 and CS0257 report.
8473 2004-09-09 Marek Safar <marek.safar@seznam.cz>
8475 * expression.cs (Argument.Resolve): Added error CS0192 and
8478 2004-09-09 Marek Safar <marek.safar@seznam.cz>
8480 C# 2.0 #pragma warning feature
8482 * cs-tokenizer.cs (PreProcessPragma): New method;
8483 Handles #pragma directive.
8485 * report.cs (WarningRegions): New class; Support
8486 class for #pragma warning directive. It tests whether
8487 warning is enabled for a given line.
8489 2004-09-08 Miguel de Icaza <miguel@ximian.com>
8491 * const.cs: Add more descriptive error report, tahnks to
8494 2004-09-08 Marek Safar <marek.safar@seznam.cz>
8496 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
8498 2004-09-07 Miguel de Icaza <miguel@ximian.com>
8500 * expression.cs: Apply patch from Ben: Remove dead code from
8501 ArrayCreation, and remove the TurnintoConstant call in const.cs,
8502 as that code just threw an exception anwyays.
8504 * const.cs: Remove the call to the turnintoconstant, for details
8507 * literal.cs: The type of the null-literal is the null type; So
8508 we use a placeholder type (literal.cs:System.Null, defined here)
8511 * expression.cs (Conditional.DoResolve): Remove some old code that
8512 is no longer needed, conversions have been fixed.
8514 (ArrayCreationExpression.DoResolve): Return false if we fail to
8515 resolve the inner expression.
8517 2004-09-07 Raja R Harinath <rharinath@novell.com>
8520 * cs-parser.jay (delegate_declaration): Record a delegate
8521 declaration as a type declaration.
8522 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
8524 2004-09-06 Miguel de Icaza <miguel@ximian.com>
8526 * parameter.cs: Do not crash if the type can not be resolved.
8528 * expression.cs: Report errors with unsafe pointers, fixes #64896
8530 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
8532 * expression.cs: Pointer arith always needs to do a conv.i
8533 if the operand is a long. fix 65320
8535 2004-09-04 Marek Safar <marek.safar@seznam.cz>
8537 Fixed cs0619-37.cs, cs0619-38.cs
8539 * enum.cs (GetObsoleteAttribute): Removed.
8541 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
8542 on Enum member is double staged. The first is tested member
8545 2004-09-04 Marek Safar <marek.safar@seznam.cz>
8547 Fixed #56986, #63631, #65231
8549 * class.cs: (TypeContainer.AddToMemberContainer): New method,
8550 adds member to name container.
8551 (TypeContainer.AddToTypeContainer): New method, adds type to
8553 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
8554 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
8555 AddOperator): Simplified by reusing AddToMemberContainer.
8556 (TypeContainer.UserDefinedStaticConstructor): Changed to property
8558 (Method.CheckForDuplications): Fixed implementation to test all
8560 (MemberBase): Detection whether member is explicit interface
8561 implementation is now in constructor.
8562 (MemberBase.UpdateMemberName): Handles IndexerName.
8563 (Accessor): Changed to keep also location information.
8564 (AbstractPropertyEventMethod): Is derived from MemberCore.
8565 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
8566 will be emited or not.
8567 (PropertyBase.AreAccessorsDuplicateImplementation):
8568 Tests whether accessors are not in collision with some method.
8569 (Operator): Is derived from MethodCore to simplify common
8572 * decl.cs (Flags.TestMethodDuplication): Test for duplication
8574 (DeclSpace.AddToContainer): Adds the member to defined_names
8575 table. It tests for duplications and enclosing name conflicts.
8577 * enum.cs (EnumMember): Clean up to reuse the base structures
8579 2004-09-03 Martin Baulig <martin@ximian.com>
8581 Merged latest changes into gmcs. Please keep this comment in
8582 here, it makes it easier for me to see what changed in MCS since
8583 the last time I merged.
8585 2004-09-03 Martin Baulig <martin@ximian.com>
8587 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
8588 into TypeContainer, to make partial classes work again.
8590 2004-09-03 Martin Baulig <martin@ximian.com>
8592 * rootcontext.cs (RootContext.V2): Removed.
8594 2004-03-23 Martin Baulig <martin@ximian.com>
8596 * expression.cs (Invocation.OverloadResolve): Added `bool
8597 may_fail' argument and use it instead of the Location.IsNull() hack.
8599 2004-09-09 Martin Baulig <martin@ximian.com>
8601 * cs-parser.jay (namespace_declaration): Fixed CS0134 reporting.
8603 2004-09-09 Martin Baulig <martin@ximian.com>
8605 * generic.cs (TypeParameter.DefineType): Added support for
8606 explicit interface methods.
8608 2004-09-09 Martin Baulig <martin@ximian.com>
8610 * README.Changes: New document. Started to list important changes
8611 between MCS and GMCS here.
8613 2004-09-08 Martin Baulig <martin@ximian.com>
8616 (TypeContainer.CheckRecursiveDefinition): New protected method.
8617 (TypeContainer.DefineType): Move the CS0146 check into
8618 CheckRecursiveDefinition().
8620 2004-09-06 Martin Baulig <martin@ximian.com>
8622 * generic.cs (ConstructedType.CheckConstraints): Allow builtin
8623 types for the constructor constraint.
8625 2004-09-03 Martin Baulig <martin@ximian.com>
8627 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
8628 into TypeContainer, to make partial classes work again.
8630 2004-09-03 Martin Baulig <martin@ximian.com>
8632 * rootcontext.cs (RootContext.V2): Removed.
8634 2004-03-23 Martin Baulig <martin@ximian.com>
8636 * expression.cs (Invocation.OverloadResolve): Added `bool
8637 may_fail' argument and use it instead of the Location.IsNull() hack.
8639 2004-09-03 Martin Baulig <martin@ximian.com>
8641 Merged latest changes into gmcs. Please keep this comment in
8642 here, it makes it easier for me to see what changed in MCS since
8643 the last time I merged.
8645 2004-09-03 Raja R Harinath <rharinath@novell.com>
8648 * expression.cs (BetterConversion): Don't allow either conversion
8649 to be null. Remove redundant implicit conversion test when 'q ==
8650 null' -- when this function is invoked, we already know that the
8651 implicit conversion exists.
8652 (BetterFunction): Assume that 'best' is non-null. Remove
8653 redundant reimplementation of IsApplicable when 'best' is null.
8654 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
8655 number of arguments.
8656 (IsAncestralType): Extract from OverloadResolve.
8657 (OverloadResolve): Make robust to the MethodGroupExpr being
8658 unsorted. Implement all the logic of Section 14.5.5.1, and
8659 support overloading of methods from multiple applicable types.
8660 Clean up logic somewhat. Don't pass null methods to BetterFunction.
8662 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
8663 (RealError, Warning): Append type of report to related symbol.
8665 2004-09-03 Marek Safar <marek.safar@seznam.cz>
8667 * enum.cs: Fixed CLS-Compliance checks for enum members.
8668 Error tests cs3008-8.cs, cs3014-8.cs
8670 2004-09-02 Marek Safar <marek.safar@seznam.cz>
8672 Fixed bug #62342, #63102
8673 * class.cs: ImplementIndexer uses member.IsExplicitImpl
8674 like ImplementMethod.
8676 2004-09-02 Marek Safar <marek.safar@seznam.cz>
8678 * attribute.cs (Attribute.GetAttributeArgumentExpression):
8681 2004-09-02 Martin Baulig <martin@ximian.com>
8683 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
8684 TypeManager.GetArgumentTypes() rather than calling GetParameters()
8687 2004-09-01 Marek Safar <marek.safar@seznam.cz>
8689 C# 2.0 Static classes implemented
8691 * class.cs (TypeContainer): instance_constructors,
8692 initialized_fields, initialized_static_fields,
8693 default_constructor, base_inteface_types are protected to be
8694 accessible from StaticClass.
8695 (TypeContainer.DefineDefaultConstructor): New virtual method
8696 for custom default constructor generating
8697 (StaticClass): New class to handle "Static classes" feature.
8699 * cs-parser.jay: Handle static keyword on class like instance
8702 * driver.cs: Added "/langversion" command line switch with two
8703 options (iso-1, default).
8705 2004-08-31 Marek Safar <marek.safar@seznam.cz>
8707 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
8709 2004-08-31 Miguel de Icaza <miguel@ximian.com>
8711 * delegate.cs: Style.
8713 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
8715 * delegate.cs: Add seperate instance expr field for miguel.
8717 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
8719 * PointerArithmetic (Resolve): make sure we are not doing
8720 pointer arith on void*. Also, make sure we are resolved
8721 by not setting eclass until resolve.
8723 All callers: Make sure that PointerArithmetic gets resolved.
8725 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
8727 * ArrayCreation (LookupType): If the type does not resolve
8728 to an array, give an error.
8730 2004-08-27 Marek Safar <marek.safar@seznam.cz>
8732 * statement.cs (Try.Resolve): Fixed bug #64222
8734 2004-08-27 Martin Baulig <martin@ximian.com>
8737 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
8740 2004-08-26 Marek Safar <marek.safar@seznam.cz>
8742 * ecore.cs (Constantify): Get underlying type via
8743 System.Enum.GetUnderlyingType to avoid StackOverflow on the
8744 Windows in special cases.
8746 2004-08-26 Marek Safar <marek.safar@seznam.cz>
8748 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
8749 for obtaining also private methods.
8750 (GetRemoveMethod): Used GetRemoveMethod (true)
8751 for obtaining also private methods.
8753 2004-09-02 Martin Baulig <martin@ximian.com>
8755 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
8756 TypeManager.GetArgumentTypes() rather than calling GetParameters()
8759 2004-08-27 Martin Baulig <martin@ximian.com>
8762 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
8765 2004-08-25 Martin Baulig <martin@ximian.com>
8767 * support.cs (ReflectionParameters..ctor): If this is a generic
8768 method, retrieve and store its type parameters.
8769 (InternalParameters..ctor): Added `TypeParameter[]' argument.
8770 (ReflectionParameters.GenericConstraints): The argument specifies
8771 the type parameter, not the method parameter.
8772 (InternalParameters.GenericConstraints): Likewise.
8774 * generic.cs (TypeParameter.DefineType): Correctly handle
8775 constraints wrt. generic methods in interfaces and their
8778 2004-08-24 Martin Baulig <martin@ximian.com>
8780 * generic.cs (TypeParameter.IsSubclassOf): New public method.
8781 (Constraints.IsSubclassOf): New internal method.
8783 * typemanager.cs (TypeManager.FindMembers): Added special support
8784 for GenericTypeParameterBuilder's.
8785 (TypeManager.IsSubclassOf, IsFamilyAccessible): Added support for
8788 2004-08-24 Martin Baulig <martin@ximian.com>
8791 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
8792 this for accessibility checks.
8793 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
8794 IsNestedFamilyAccessible.
8795 (TypeManager.IsSubclassOf): New method, do what the name actually
8798 2004-08-24 Martin Baulig <martin@ximian.com>
8800 * expression.cs (MemberAccess.DoResolve): When resolving ourselves
8801 as a SimpleName, include the generic arity.
8803 2004-08-24 Martin Baulig <martin@ximian.com>
8805 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
8806 MethodAttributes.HideBySig for operators.
8808 2004-08-23 Martin Baulig <martin@ximian.com>
8810 Back to the old error reporting system :-)
8812 * report.cs (Message): Removed.
8813 (Report.MessageData, ErrorData, WarningData): Removed.
8814 (Report.Error, Warning): Back to the old system.
8816 2004-08-23 Martin Baulig <martin@ximian.com>
8818 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
8820 * class.cs (TypeContainer.ParentContainer): New public virtual
8821 method; replaces the explicit interface implementation.
8822 (ClassPart.ParentContainer): Override.
8824 2004-08-23 Martin Baulig <martin@ximian.com>
8826 * statement.cs (Switch): Added support for constant switches; see
8827 #59428 or test-285.cs.
8829 2004-08-22 Marek Safar <marek.safar@seznam.cz>
8832 * statement.cs (GetEnumeratorFilter): Removed useless
8833 logic because C# specs is strict. GetEnumerator must be
8836 2004-08-22 Martin Baulig <martin@ximian.com>
8838 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
8839 a switch and may break, reset the barrier. Fixes #59867.
8841 2004-08-22 Marek Safar <marek.safar@seznam.cz>
8843 CLS-Compliance speed up (~5% for corlib)
8845 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
8846 New method. Tests container for CLS-Compliant names
8848 * class.cs (TypeContainer.VerifyClsName): New method.
8849 Checks whether container name is CLS Compliant.
8850 (Constructor): Implements IMethodData.
8852 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
8853 low-case table for CLS Compliance test.
8854 (MemberCache.VerifyClsParameterConflict): New method.
8855 Checks method parameters for CS3006 error.
8857 * enum.cs (EnumMember): Is derived from MemberCore.
8858 (Enum.VerifyClsName): Optimized for better performance.
8860 2004-08-06 Marek Safar <marek.safar@seznam.cz>
8862 * report.cs: Renamed Error_T to Error and changed all
8865 2004-08-06 Marek Safar <marek.safar@seznam.cz>
8867 * class.cs (TypeContainer.IndexerArrayList): New inner class
8868 container for indexers.
8869 (TypeContainer.DefaultIndexerName): New constant for default
8870 indexer name. Replaced all "Item" with this constant.
8871 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
8873 * typemanager.cs (TypeManager.default_member_ctor): Cache here
8874 DefaultMemberAttribute constructor.
8876 2004-08-05 Martin Baulig <martin@ximian.com>
8878 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
8881 2004-08-05 Marek Safar <marek.safar@seznam.cz>
8883 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
8884 multi platforms problem.
8886 * compiler.csproj: Included shared files.
8888 2004-08-04 Marek Safar <marek.safar@seznam.cz>
8890 Fix bug 60333, 55971 in the more general way
8891 * attribute.cs (Attribute.GetAttributeArgumentExpression):
8892 Added arg_type argument for constant conversion.
8893 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
8895 2004-08-04 Marek Safar <marek.safar@seznam.cz>
8898 * class.cs (TypeContainer ): New inner classes MethodArrayList,
8899 OperatorArrayList, MethodCoreArrayList for typecontainer
8900 containers. Changed class member types to these new types.
8901 (MethodArrayList.DefineMembers): Added test for CS0659.
8903 2004-08-04 Miguel de Icaza <miguel@ximian.com>
8905 * cfold.cs: Synchronize the folding with the code in expression.cs
8906 Binary.DoNumericPromotions for uint operands.
8908 * attribute.cs: Revert patch from Raja, it introduced a regression
8909 while building Blam-1.2.1 (hard to isolate a test case).
8911 2004-08-04 Marek Safar <marek.safar@seznam.cz>
8915 (TypeContainer.Define): Renamed to DefineContainerMembers because of
8917 (MethodCore.parent_method): New member. The method we're overriding
8918 if this is an override method.
8919 (MethodCore.CheckBase): Moved from Method class and made common.
8920 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
8922 (MethodCore.CheckForDuplications): New abstract method. For custom
8923 member duplication search in a container
8924 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
8925 method and its return type.
8926 (Event.conflict_symbol): New member. Symbol with same name in the
8930 (MemberCache.FindMemberWithSameName): New method. The method
8931 is looking for conflict with inherited symbols.
8933 2004-08-04 Martin Baulig <martin@ximian.com>
8935 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
8937 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
8939 2004-08-03 Marek Safar <marek.safar@seznam.cz>
8941 * report.cs (Message): New enum for better error, warning reference in
8943 (MessageData): New inner abstract class. It generally handles printing of
8944 error and warning messages.
8945 Removed unused Error, Warning, Message methods.
8947 2004-08-03 Marek Safar <marek.safar@seznam.cz>
8949 Fix for cs0592-8.cs test
8951 (Attributable.ValidAttributeTargets): Made public.
8952 (Attribute.ExplicitTarget): New member for explicit target value.
8953 (Attribute.CheckTargets): Now we translate explicit attribute
8954 target to Target here.
8956 2004-08-03 Ben Maurer <bmaurer@ximian.com>
8958 * ecore.cs (MethodGroupExpr): new IsBase property.
8960 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
8962 * delegate.cs (DelegateCreation): store a MethodGroupExpr
8963 rather than an instance expr.
8965 (DelegateCreation.Emit): Use the method group rather than
8966 the instance expression. Also, if you have base.Foo as the
8967 method for a delegate, make sure to emit ldftn, not ldftnvirt.
8969 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
8971 (NewDelegate.DoResolve): Only check for the existance of Invoke
8972 if the method is going to be needed. Use MethodGroupExpr.
8974 (NewDelegate.Emit): Remove, DelegateCreation implements this.
8976 * expression.cs: For pointer arith., make sure to use
8977 the size of the type, not the size of the pointer to
8980 2004-08-03 Marek Safar <marek.safar@seznam.cz>
8983 * class.cs (Class): Added error CS0502 test.
8985 2004-08-03 John Luke <jluke@cfl.rr.com>
8986 Raja R Harinath <rharinath@novell.com>
8989 * attribute.cs (Attribute.complained_before): New flag.
8990 (Attribute.ResolveType, Attribute.Resolve),
8991 (Attribute.DefinePInvokeMethod): Set it.
8992 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
8994 2004-08-03 Martin Baulig <martin@ximian.com>
8996 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
8997 use a user-defined operator; we still need to do numeric
8998 promotions in case one argument is a builtin type and the other
8999 one has an implicit conversion to that type. Fixes #62322.
9001 2004-08-18 Martin Baulig <martin@ximian.com>
9003 * class.cs (Method.Define): Use the correct method name when
9004 creating the MethodBuilder for a generic method.
9006 2004-08-17 Martin Baulig <martin@ximian.com>
9008 * generic.cs (Constraints): Support type parameter constraints.
9010 2004-08-16 Martin Baulig <martin@ximian.com>
9012 * cs-tokenizer.cs (Tokenizer.TypeOfParsing): New public property.
9013 (Token.GENERIC_DIMENSION): New token; this is returned if we
9014 encounter an unbound generic type in a typeof() expression.
9016 * cs-parser.jay (opt_type_argument_list): Added GENERIC_DIMENSION;
9017 this token is only generated while parsing a typeof() expression.
9018 (typeof_expression): Removed the old unbound_type hack.
9020 * generic.cs (TypeArguments.IsUnbound): New public property.
9022 * decl.cs (MemberName): Added support for unbound types.
9024 2004-08-14 Martin Baulig <martin@ximian.com>
9027 (TypeManager.IsEqualGenericInstance): New static method.
9028 (TypeManager.IsSubclassOrNestedChildOf, IsSubclassOf): This is
9029 just used to check accessibility, so follow the rules of 26.1.6.
9031 * expression.cs (MemberAccess.ResolveAsTypeStep): Return a
9032 ConstructedType instead of a TypeExpression if we have type arguments.
9034 * cs-parser.jay (typeof_expression): Support unbound generic types.
9036 * ecore.cs (UnboundTypeExpression): New public class.
9038 2004-08-12 Martin Baulig <martin@ximian.com>
9040 * typemanager.cs (TypeManager.IsNestedChildOf): Use
9041 TypeManager.IsEqual() rather than `=='.
9043 * decl.cs (DeclSpace.CheckAccessLevel): Use `tb.FullName' for
9044 generic instances as well.
9046 2004-08-12 Martin Baulig <martin@ximian.com>
9048 * expression.cs (Invocation.InferType): We can only infer method
9049 type parameters. Fixes #62647.
9051 2004-08-11 Martin Baulig <martin@ximian.com>
9053 * class.cs (TypeContainer.DefineType): Create the TypeBuilder
9054 before resolving the base classes.
9056 2004-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9058 * Makefile: install .mdb file too.
9060 2004-08-05 Martin Baulig <martin@ximian.com>
9062 * ecore.cs (FieldExpr.DoResolveLValue): If we're resolving a field
9063 initializer, the current type is just the TypeBuilder, not the
9064 instantiated generic type.
9065 (FieldExpr.IsFieldInitializer): New public property.
9067 2004-08-04 Martin Baulig <martin@ximian.com>
9069 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
9071 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
9073 2004-08-03 Martin Baulig <martin@ximian.com>
9075 * class.cs (MethodData.Define): If we're an explicit
9076 implementation, remove the generic arity from the type name.
9078 2004-08-03 Martin Baulig <martin@ximian.com>
9080 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
9081 use a user-defined operator; we still need to do numeric
9082 promotions in case one argument is a builtin type and the other
9083 one has an implicit conversion to that type. Fixes #62322.
9085 2004-08-02 Martin Baulig <martin@ximian.com>
9087 * class.cs (TypeContainer.ifaces): Make this a `Type[]', not a
9089 (TypeContainer.GetClassBases): Return the unexpanded list of
9090 interfaces; we expand them later.
9091 (TypeContainer.DefineType): After creating the TypeBuilder, call
9092 TypeManager.ExpandInterfaces() to get an expanded and resolved
9095 * ecore.cs (TypeExpr.GetInterfaces): Removed
9097 * generics.cs (Constraints.InterfaceConstraints): Remove.
9098 (TypeParameter.DefineType): Call TypeManager.RegisterBuilder() to
9099 register the interface constraints.
9102 (TypeManager.AddUserType): Removed the `ifaces' argument.
9103 (TypeManager.AddTypeParameter): Likewise.
9104 (TypeManager.AddUserInterface): Removed, was unused.
9105 (TypeManager.RegisterBuilder): Take a `Type[]' instead of a
9106 `TypeExpr[]' array for the interfaces.
9107 (TypeManager.ExpandInterfaces): Call this after the TypeBuilder
9108 has been defined, returns a list of the resolved interfaces types.
9109 (TypeManager.GetInterfaces): Return a `Type[]', not a `TypeExpr[]'.
9110 (TypeManager.GetExplicitInterfaces): Likewise.
9112 2004-08-02 Martin Baulig <martin@ximian.com>
9114 * expression.cs (Invocation.EmitCall): If we're invoking a method
9115 on a type parameter, use the new `Constrained' prefix opcode.
9117 2004-08-02 Martin Baulig <martin@ximian.com>
9119 * statement.cs (LocalInfo.Flags): Added `IsThis'.
9120 (LocalInfo.IsThis): New public property.
9121 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
9123 2004-08-01 Martin Baulig <martin@ximian.com>
9125 * class.cs (TypeContainer.GetClassBases): Don't set the default
9126 here since we may get called from GetPartialBases().
9127 (TypeContainer.DefineType): If GetClassBases() didn't return a
9128 parent, use the default one.
9130 2004-07-30 Martin Baulig <martin@ximian.com>
9132 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
9134 * class.cs (SourceMethod): New public class, derive from the
9135 symbol writer's ISourceMethod.
9136 (Method): Use the new symbol writer API.
9138 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
9139 as argument and use the new symbol writer.
9142 (SourceFile): Implement the symbol writer's ISourceFile.
9143 (Location.SymbolDocument): Removed.
9144 (Location.SourceFile): New public property.
9146 * symbolwriter.cs: Use the new symbol writer API.
9148 2004-07-30 Raja R Harinath <rharinath@novell.com>
9150 * Makefile (install-local): Remove. Functionality moved to
9153 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
9155 * Makefile: Install mcs.exe.config file together with mcs.exe.
9156 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
9157 correct runtime version.
9159 2004-07-25 Martin Baulig <martin@ximian.com>
9162 (TypeContainer.RegisterOrder): Removed, this was unused.
9163 (TypeContainer, interface_order): Removed.
9164 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
9165 TypeContainer as argument since we can also be called with a
9166 `PartialContainer' for a partial class/struct/interface.
9167 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
9168 of checking whether we're an `Interface' - we could be a
9170 (PartialContainer.Register): Override; call
9171 AddClass()/AddStruct()/AddInterface() on our parent.
9173 * cs-parser.jay (interface_member_declaration): Add things to the
9174 `current_container', not the `current_class'.
9176 * rootcontext.cs (RegisterOrder): The overloaded version which
9177 takes an `Interface' was unused, removed.
9179 * typemanager.cs (TypeManager.LookupInterface): Return a
9180 `TypeContainer', not an `Interface'.
9181 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
9182 contain a `PartialContainer' for an interface, so check it's
9183 `Kind' to figure out what it is.
9185 2004-07-25 Martin Baulig <martin@ximian.com>
9187 * class.cs (Class.DefaultTypeAttributes): New public constant.
9188 (Struct.DefaultTypeAttributes): Likewise.
9189 (Interface.DefaultTypeAttributes): Likewise.
9190 (PartialContainer.TypeAttr): Override this and add the
9191 DefaultTypeAttributes.
9193 2004-07-25 Martin Baulig <martin@ximian.com>
9195 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
9196 we can just use the `Parent' field instead.
9198 2004-07-25 Martin Baulig <martin@ximian.com>
9200 * class.cs (TypeContainer.Emit): Renamed to EmitType().
9202 2004-07-25 Martin Baulig <martin@ximian.com>
9204 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
9205 our parts before defining any methods.
9206 (TypeContainer.VerifyImplements): Make this virtual.
9207 (ClassPart.VerifyImplements): Override and call VerifyImplements()
9208 on our PartialContainer.
9210 2004-07-25 Martin Baulig <martin@ximian.com>
9212 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
9214 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
9215 argument, we can just use the `Parent' field instead.
9218 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
9219 (MemberBase.DoDefine): Likewise.
9221 2004-07-24 Martin Baulig <martin@ximian.com>
9223 * decl.cs (MemberCore.Parent): New public field.
9224 (DeclSpace.Parent): Moved to MemberCore.
9226 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
9227 (MemberBase.ctor): Added TypeContainer argument, pass it to our
9229 (FieldBase, Field, Operator): Likewise.
9230 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
9231 (EventField, Event): Likewise.
9233 2004-07-23 Martin Baulig <martin@ximian.com>
9235 * class.cs (PartialContainer): New public class.
9236 (ClassPart): New public class.
9237 (TypeContainer): Added support for partial classes.
9238 (TypeContainer.GetClassBases): Splitted some of the functionality
9239 out into GetNormalBases() and GetPartialBases().
9241 * cs-tokenizer.cs (Token.PARTIAL): New token.
9242 (Tokenizer.consume_identifier): Added some hacks to recognize
9243 `partial', but only if it's immediately followed by `class',
9244 `struct' or `interface'.
9246 * cs-parser.jay: Added support for partial clases.
9248 2004-07-23 Martin Baulig <martin@ximian.com>
9250 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
9251 a `DeclSpace' and also made it readonly.
9252 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
9253 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
9254 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
9256 * cs-parser.jay: Pass the `current_class', not the
9257 `current_container' (at the moment, this is still the same thing)
9258 to a new Method, Property, Event, Indexer or Constructor.
9260 2004-07-23 Martin Baulig <martin@ximian.com>
9262 * cs-parser.jay (CSharpParser): Added a new `current_class' field
9263 and removed the `current_interface' one.
9264 (struct_declaration, class_declaration, interface_declaration):
9265 Set `current_class' to the newly created class/struct/interface;
9266 set their `Bases' and call Register() before parsing their body.
9268 2004-07-23 Martin Baulig <martin@ximian.com>
9270 * class.cs (Kind): New public enum.
9271 (TypeContainer): Made this class abstract.
9272 (TypeContainer.Kind): New public readonly field.
9273 (TypeContainer.CheckDef): New public method; moved here from
9275 (TypeContainer.Register): New public abstract method.
9276 (TypeContainer.GetPendingImplementations): New public abstract
9278 (TypeContainer.GetClassBases): Removed the `is_class' and
9279 `is_iface' parameters.
9280 (TypeContainer.DefineNestedTypes): Formerly known as
9282 (ClassOrStruct): Made this class abstract.
9284 * tree.cs (RootTypes): New public type.
9286 2004-07-20 Martin Baulig <martin@ximian.com>
9288 * tree.cs (Tree.RecordNamespace): Removed.
9289 (Tree.Namespaces): Removed.
9291 * rootcontext.cs (RootContext.IsNamespace): Removed.
9293 * cs-parser.jay (namespace_declaration): Just create a new
9294 NamespaceEntry here.
9296 2004-07-21 Lluis Sanchez Gual <lluis@novell.com>
9298 * Makefile: Install gmcs.exe.config file together with gmcs.exe.
9299 * gmcs.exe.config: Renamed from mcs.exe.config. Added supportedRuntime
9300 entry to make sure it runs in the correct runtime version.
9302 2004-07-18 Martin Baulig <martin@ximian.com>
9304 * generic.cs (ConstructedType.CheckConstraints): Improved
9305 constraints checking.
9307 2004-07-18 Martin Baulig <martin@ximian.com>
9309 * expression.cs (Invocation.BetterMethod): Call
9310 TypeManager.TypeToCoreType() on all types and removed my previous
9311 hack; we're already doig the right thing here.
9313 2004-07-17 Martin Baulig <martin@ximian.com>
9315 * decl.cs (MemberName.MakeName): Create the "class`1" names here.
9317 2004-07-16 Martin Baulig <martin@ximian.com>
9319 * iterators.cs: Added generics support.
9321 2004-07-16 Martin Baulig <martin@ximian.com>
9323 * iterators.cs: Rewrote this. We're now using one single Proxy
9324 class for both the IEnumerable and the IEnumerator interface and
9325 `Iterator' derives from Class so we can use the high-level API.
9327 * class.cs (TypeContainer.AddIterator): New method.
9328 (TypeContainer.DoDefineType): New protected virtual method, which
9329 is called from DefineType().
9330 (TypeContainer.DoDefineMembers): Call DefineType() and
9331 DefineMembers() on all our iterators.
9332 (TypeContainer.Emit): Call Emit() on all our iterators.
9333 (TypeContainer.CloseType): Call CloseType() on all our iterators.
9335 * codegen.cs (EmitContext.CurrentIterator): New public field.
9337 2004-07-15 Martin Baulig <martin@ximian.com>
9340 (TypeManager.not_supported_exception_type): New type.
9342 2004-07-14 Martin Baulig <martin@ximian.com>
9345 (TypeManager.generic_ienumerable_type): New type.
9346 (TypeManager.generic_ienumerator_type): New type.
9349 (RootContext.interfaces_first_stage): Added
9350 "System.Collections.Generic.IEnumerator`1" and
9351 "System.Collections.Generic.IEnumerable`1".
9353 2004-07-14 Martin Baulig <martin@ximian.com>
9355 * iterators.cs: Use real error numbers.
9357 2004-07-14 Martin Baulig <martin@ximian.com>
9359 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
9360 requires this to be a System.Collection.IEnumerable and not a
9361 class implementing that interface.
9362 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
9364 2004-07-13 Marek Safar <marek.safar@seznam.cz>
9366 * class.cs: Fixed previous fix, it broke some error tests.
9368 2004-07-12 Martin Baulig <martin@ximian.com>
9370 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
9373 2004-07-14 Martin Baulig <martin@ximian.com>
9375 * decl.cs, expression.cs, generic.cs: Use a backqoute (`) and not
9376 an exclamation mark (!) for the generic arity to reflect the
9377 latest spec changes; ie. use "System.Collections.Generic.IList`1".
9379 2004-07-13 Martin Baulig <martin@ximian.com>
9381 * cs-tokenizer.cs (Tokenizer.parse_less_than): Allow array rank
9382 specifiers being part of a type argument.
9384 2004-07-13 Martin Baulig <martin@ximian.com>
9386 * expression.cs (MemberAccess.ResolveAsTypeStep): Use the full `!'
9387 name for generic types.
9389 2004-07-13 Martin Baulig <martin@ximian.com>
9391 * assign.cs (Assign.DoResolve): Moved the CS0131 check up a little
9394 2004-07-09 Miguel de Icaza <miguel@ximian.com>
9396 * assign.cs (LocalTemporary): Add new argument: is_address,If
9397 `is_address' is true, then the value that we store is the address
9398 to the real value, and not the value itself.
9400 * ecore.cs (PropertyExpr): use the new local temporary
9401 stuff to allow us to handle X.Y += z (where X is a struct)
9403 2004-07-08 Martin Baulig <martin@ximian.com>
9405 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
9406 not always return, just like we're doing in Using.Resolve().
9408 2004-07-07 Miguel de Icaza <miguel@ximian.com>
9410 * cs-parser.jay (fixed_statement): flag this as Pinned.
9412 2004-07-06 Miguel de Icaza <miguel@ximian.com>
9414 * typemanager.cs (TypeManager): Removed MakePinned method, this
9415 mechanism is replaced with the .NET 2.x compatible mechanism of
9416 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
9418 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
9419 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
9420 `IsFixed' property which has a different meaning.
9422 2004-07-02 Raja R Harinath <rharinath@novell.com>
9424 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
9425 visible from inside a nested class, not just the names of the
9426 immediately enclosing class.
9429 2004-06-24 Raja R Harinath <rharinath@novell.com>
9431 * expression.cs (BetterConversion): Remove buggy special-case
9432 handling of "implicit constant expression conversions". At this
9433 point, we already know that the conversion is possible -- we're
9434 only checking to see which is better.
9436 2004-06-24 Marek Safar <marek.safar@seznam.cz>
9438 * cs-parser.jay: Added error CS0210 test.
9440 2004-06-24 Marek Safar <marek.safar@seznam.cz>
9442 * cs-parser.jay: Added error CS0134 test.
9444 2004-06-24 Marek Safar <marek.safar@seznam.cz>
9447 * cs-parser.jay: Added error CS0145 test.
9449 2004-06-24 Marek Safar <marek.safar@seznam.cz>
9451 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
9453 2004-06-23 Ben Maurer <bmaurer@ximian.com>
9455 * expression.cs (StackAlloc.Resolve): The argument may not
9456 be a constant; deal with this case.
9458 2004-06-23 Marek Safar <marek.safar@seznam.cz>
9460 * attribute.cs (IndexerName_GetIndexerName): Renamed to
9461 GetIndexerAttributeValue.
9462 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
9464 * class.cs (Indexer.Define): Added error tests for CS0415,
9467 2004-06-23 Miguel de Icaza <miguel@ximian.com>
9469 * attribute.cs (Attribute.Resolve): Keep field code in sync with
9472 2004-06-23 Martin Baulig <martin@ximian.com>
9474 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
9475 neither return nor throw, reset the barrier as well. Fixes #60457.
9477 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
9479 * class.cs : EventAttributes is now set to None by default.
9480 This fixes bug #60459.
9482 2004-06-18 Marek Safar <marek.safar@seznam.cz>
9485 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
9486 Don't throw exception but return null (it's sufficient now).
9488 2004-06-18 Marek Safar <marek.safar@seznam.cz>
9490 * typemanager.cs (GetArgumentTypes): Faster implementation.
9492 2004-06-18 Martin Baulig <martin@ximian.com>
9494 * attribute.cs (Attribute.Resolve): Check whether we're an
9495 EmptyCast which a Constant child. Fixes #60333.
9497 2004-06-17 Ben Maurer <bmaurer@ximian.com>
9499 * statement.cs (EmitCollectionForeach): Account for the fact that
9500 not all valuetypes are in areas which we can take the address of.
9501 For these variables, we store to a temporary variable. Also, make
9502 sure that we dont emit a `callvirt' on a valuetype method.
9504 2004-06-15 Marek Safar <marek.safar@seznam.cz>
9506 * expression.cs (StackAlloc.DoReSolve): Added test for
9507 negative parameter (CS0247).
9509 2004-06-15 Marek Safar <marek.safar@seznam.cz>
9512 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
9514 2004-06-15 Marek Safar <marek.safar@seznam.cz>
9517 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
9520 2004-06-14 Marek Safar <marek.safar@seznam.cz>
9522 Fix bug #58254 & cs1555.cs, cs1556.cs
9523 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
9525 2004-06-14 Marek Safar <marek.safar@seznam.cz>
9527 * cs-parser.jay: Added error CS1669 test for indexers.
9529 2004-06-18 Martin Baulig <martin@ximian.com>
9531 * generics.cs (GenericMethod.ctor): Don't take an Attributes
9532 argument. Fixes #60441.
9534 2004-06-16 Ben Maurer <bmaurer@ximian.com>
9535 * ecore.cs (MethodGroupExpr.Name): Revert Martin's patch.
9536 The name needs to have the actual name of the method in order
9537 for other tests (such as the one in OverloadResolve for Invoke
9538 on a delegate) to work. As well, it does not really help
9539 error reporting because the method group had multiple methods.
9540 * Makefile: Remove MCS_DEBUG, you can enable with the DEBUG_FLAGS.
9541 Make profiling work.
9543 2004-06-13 Martin Baulig <martin@ximian.com>
9545 * cs-parser.jay: Don't allow generic attributes.
9547 2004-06-13 Martin Baulig <martin@ximian.com>
9549 * class.cs (MemberBase.DoDefineBase): New protected method.
9550 (MemberBase.DoDefine): Compute the `flags' in the new
9551 DoDefineBase() which must be called first.
9552 (Method.Define): Call DoDefineBase() first so we have the flags
9553 when defining the generic method.
9555 * cs-parser.jay (interface_method_declaration): Support generic methods.
9557 2004-06-13 Martin Baulig <martin@ximian.com>
9559 * decl.cs (TypeName): Removed.
9560 (MemberName): Removed TypeName and MemberNow; now we just have
9563 * cs-parser.jay: Don't distinguish between type arguments and type
9564 parameters in the grammar and simplified the rules a bit. The
9565 reduce/reduce conflicts are now gone (except the one we inherited
9568 2004-06-11 Martin Baulig <martin@ximian.com>
9570 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
9571 call this twice: for params and varargs methods.
9573 2004-06-11 Marek Safar <marek.safar@seznam.cz>
9576 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
9578 2004-06-11 Marek Safar <marek.safar@seznam.cz>
9580 * attribute.cs (Attribute.GetValidTargets): Made public.
9583 (AbstractPropertyEventMethod): New class for better code sharing.
9584 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
9586 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
9588 2004-06-09 Martin Baulig <martin@ximian.com>
9590 * cs-parser.jay: Removed a reduce/reduce conflict.
9592 2004-06-03 Martin Baulig <martin@ximian.com>
9594 * generic.cs (ConstructedType.GetMemberAccess): Renamed to
9595 GetSimpleName() and return a SimpleName.
9597 * ecore.cs (SimpleName.Arguments): New public field.
9598 (SimpleName): Added overloaded ctor which takes an additional
9599 TypeArguments argument.
9600 (SimpleName.SimpleNameResolve): Added support for generic methods.
9601 (MethodGroupExpr.ResolveGeneric): New public method. The code was
9602 formerly in MemberAccess.DoResolve(), but we also need it in
9603 SimpleNameResolve().
9605 * expression.cs (MemberAccess.DoResolve): Use the new
9606 MethodGroupExpr.ResolveGeneric().
9608 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
9610 * decl.cs: If possible, use lookuptypedirect here. We can only do
9611 this if there is no `.' after the namespace. Avoids using
9612 LookupType, which does lots of slow processing.
9613 (FindNestedType) New method, does what it says :-).
9614 * namespace.cs: use LookupTypeDirect.
9615 * rootcontext.cs: use membercache, if possible.
9616 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
9618 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
9621 According to the spec,
9623 In a member access of the form E.I, if E is a single identifier,
9624 and if the meaning of E as a simple-name (§7.5.2) is a constant,
9625 field, property, localvariable, or parameter with the same type as
9626 the meaning of E as a type-name (§3.8), then both possible
9627 meanings of E are permitted.
9629 We did not check that E as a simple-name had the same type as E as
9632 This trivial check gives us 5-7% on bootstrap time.
9634 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
9636 * expression.cs (Invocation.OverloadResolve): Avoid the
9637 use of hashtables and boxing here by allocating on demand.
9639 2004-05-30 Martin Baulig <martin@ximian.com>
9641 * rootcontext.cs (RootContext.LookupType): Don't cache things if
9642 we're doing a silent lookup. Don't try to lookup nested types in
9643 TypeManager.object_type (thanks to Ben Maurer).
9645 2004-05-30 Martin Baulig <martin@ximian.com>
9647 Committing a patch from Ben Maurer.
9649 * rootcontext.cs (RootContext.LookupType): Cache negative results.
9651 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
9653 * convert.cs: add a trivial cache for overload operator resolution.
9655 2004-05-31 Marek Safar <marek.safar@seznam.cz>
9658 (AttributeTester.GetObsoleteAttribute): Returns instance of
9659 ObsoleteAttribute when type is obsolete.
9662 (TypeContainer.VerifyObsoleteAttribute): Override.
9663 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
9664 (MethodCode.VerifyObsoleteAttribute): Override.
9665 (MemberBase.VerifyObsoleteAttribute): Override.
9668 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
9669 and report proper error.
9672 (Delegate.VerifyObsoleteAttribute): Override.
9675 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
9676 and report proper error.
9677 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
9680 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
9684 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
9685 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
9686 Added test for ObsoleteAttribute.
9689 (Catch): Derived from Statement.
9691 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
9693 * decl.cs: If possible, use lookuptypedirect here. We can only do
9694 this if there is no `.' after the namespace. Avoids using
9695 LookupType, which does lots of slow processing.
9696 (FindNestedType) New method, does what it says :-).
9697 * namespace.cs: use LookupTypeDirect.
9698 * rootcontext.cs: use membercache, if possible.
9699 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
9701 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
9704 According to the spec,
9706 In a member access of the form E.I, if E is a single identifier,
9707 and if the meaning of E as a simple-name (§7.5.2) is a constant,
9708 field, property, localvariable, or parameter with the same type as
9709 the meaning of E as a type-name (§3.8), then both possible
9710 meanings of E are permitted.
9712 We did not check that E as a simple-name had the same type as E as
9715 This trivial check gives us 5-7% on bootstrap time.
9717 2004-05-30 Marek Safar <marek.safar@seznam.cz>
9719 Fixed bug #59071 & cs0160.cs
9720 * statement.cs (Try.Resolve): Check here whether order of catch
9721 clauses matches their dependencies.
9723 2004-05-30 Marek Safar <marek.safar@seznam.cz>
9726 * ecore.cs (SimpleName.SimpleNameResolve): Added test for
9729 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
9731 * expression.cs (Invocation.OverloadResolve): Avoid the
9732 use of hashtables and boxing here by allocating on demand.
9734 2004-05-30 Martin Baulig <martin@ximian.com>
9736 * rootcontext.cs (RootContext.LookupType): Don't cache things if
9737 we're doing a silent lookup. Don't try to lookup nested types in
9738 TypeManager.object_type (thanks to Ben Maurer).
9740 2004-05-30 Martin Baulig <martin@ximian.com>
9742 Committing a patch from Ben Maurer.
9744 * rootcontext.cs (RootContext.LookupType): Cache negative results.
9746 2004-05-29 Martin Baulig <martin@ximian.com>
9748 * class.cs (IMethodData.ShouldIgnore): New method.
9750 * typemanager.cs (TypeManager.MethodFlags): Don't take a
9751 `Location' argument, we don't need it anywhere. Use
9752 `IMethodData.ShouldIgnore ()' instead of
9753 `MethodData.GetMethodFlags ()'.
9754 (TypeManager.AddMethod): Removed.
9755 (TypeManager.AddMethod2): Renamed to AddMethod.
9757 2004-05-29 Martin Baulig <martin@ximian.com>
9759 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
9761 * convert.cs (Convert.ImplicitReferenceConversion): If we're
9762 converting from a class type S to an interface type and we already
9763 have an object on the stack, don't box it again. Fixes #52578.
9765 2004-05-29 Martin Baulig <martin@ximian.com>
9767 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
9768 Added support for `params' parameters. Fixes #59267.
9770 2004-05-29 Martin Baulig <martin@ximian.com>
9772 * literal.cs (NullPointer): Provide a private .ctor which sets
9773 `type' to TypeManager.object_type. Fixes #59048.
9775 2004-05-29 Martin Baulig <martin@ximian.com>
9777 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
9778 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
9780 * ecore.cs (EventExpr.instance_expr): Make the field private.
9782 2004-05-26 Marek Safar <marek.safar@seznam.cz>
9784 Fixed bug #50080 & cs0214-2.cs
9785 * expression.cs (Cast.DoResolve): Check unsafe context here.
9787 * statement.cs (Resolve.DoResolve): Likewise.
9789 2004-05-26 Martin Baulig <martin@ximian.com>
9791 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
9793 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
9794 (RootContext.LookupType): Pass down the `silent' flag.
9796 2004-05-25 Martin Baulig <martin@ximian.com>
9799 (MethodGroupExpr.IdenticalTypeName): New public property.
9800 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
9801 expression actually refers to a type.
9803 2004-05-25 Martin Baulig <martin@ximian.com>
9805 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
9806 for #56176 and made it actually work.
9808 2004-05-25 Martin Baulig <martin@ximian.com>
9810 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
9811 (FieldExpr, PropertyExpr): Override and implement
9812 CacheTemporaries. Fixes #52279.
9814 2004-05-25 Miguel de Icaza <miguel@ximian.com>
9816 * location.cs: In the new compiler listing a file twice is a
9817 warning, not an error.
9819 2004-05-24 Martin Baulig <martin@ximian.com>
9821 * enum.cs (Enum.DefineType): For the `BaseType' to be a
9822 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
9824 2004-05-24 Martin Baulig <martin@ximian.com>
9826 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
9827 walking the `using' list. Fixes #53921.
9829 2004-05-24 Martin Baulig <martin@ximian.com>
9831 * const.cs (Const.LookupConstantValue): Added support for
9832 EmptyCast's; fixes #55251.
9834 2004-05-24 Martin Baulig <martin@ximian.com>
9836 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
9837 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
9838 which does the CS0135 check. The reason is that we first need to
9839 check whether the variable actually exists.
9841 2004-05-24 Martin Baulig <martin@ximian.com>
9843 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
9844 than RootContext.LookupType() to find the explicit interface
9847 2004-05-24 Raja R Harinath <rharinath@novell.com>
9849 * Makefile: Simplify. Use executable.make.
9850 * mcs.exe.sources: New file. List of sources of mcs.exe.
9852 2004-05-24 Anders Carlsson <andersca@gnome.org>
9856 Use the invariant culture when doing String.Compare for CLS case
9859 2004-05-23 Martin Baulig <martin@ximian.com>
9861 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
9862 don't have any dots. Fixes #52622, added cs0246-8.cs.
9864 * namespace.cs (NamespaceEntry.Lookup): Likewise.
9866 2004-05-23 Marek Safar <marek.safar@seznam.cz>
9868 * class.cs (MemberBase.Define): Reuse MemberType member for
9869 resolved type. Other methods can use it too.
9871 2004-05-23 Martin Baulig <martin@ximian.com>
9873 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
9874 the variable also exists in the current block (otherwise, we need
9875 to report a CS0103). Fixes #58670.
9877 2004-05-23 Martin Baulig <martin@ximian.com>
9879 * flowanalysis.cs (Reachability.Reachable): Compute this
9880 on-the-fly rather than storing it as a field.
9882 2004-05-23 Martin Baulig <martin@ximian.com>
9884 * flowanalysis.cs (Reachability.And): Manually compute the
9885 resulting `barrier' from the reachability.
9887 2004-05-23 Marek Safar <marek.safar@seznam.cz>
9890 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
9891 instance of ObsoleteAttribute when symbol is obsolete.
9894 (IMethodData): Extended interface for ObsoleteAttribute support.
9896 2004-05-22 Marek Safar <marek.safar@seznam.cz>
9898 * attribute.cs: Fix bug #55970
9900 2004-05-22 Marek Safar <marek.safar@seznam.cz>
9904 (GetObsoleteAttribute): New method. Creates the instance of
9906 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
9907 ObsoleteAttribute when member is obsolete.
9908 (AttributeTester.Report_ObsoleteMessage): Common method for
9909 Obsolete error/warning reporting.
9912 (TypeContainer.base_classs_type): New member for storing parent type.
9915 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
9916 for this MemberCore.
9918 2004-05-21 Marek Safar <marek.safar@seznam.cz>
9920 * attribute.cs, const.cs: Fix bug #58590
9922 2004-05-21 Martin Baulig <martin@ximian.com>
9924 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
9925 out parameters if the end of the method is unreachable. Fixes
9928 2004-05-21 Marek Safar <marek.safar@seznam.cz>
9930 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
9931 Hari was right, why extra method.
9933 2004-05-21 Marek Safar <marek.safar@seznam.cz>
9935 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
9937 2004-05-20 Martin Baulig <martin@ximian.com>
9939 * delegate.cs: Convert this file to Unix mode - like the original
9942 2004-05-20 Martin Baulig <martin@ximian.com>
9944 * attribute.cs: Convert this file to Unix mode - like the original
9947 2004-05-19 Marek Safar <marek.safar@seznam.cz>
9949 Fix bug #58688 (MCS does not report error when the same attribute
9952 * attribute.cs (Attribute.Emit): Distinction between null and default.
9954 2004-05-19 Raja R Harinath <rharinath@novell.com>
9956 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
9957 of a top-level attribute without an attribute target.
9958 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
9960 (Attribute.Conditional_GetConditionName),
9961 (Attribute.Obsolete_GetObsoleteMessage): Update.
9962 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
9963 part of ScanForIndexerName.
9964 (Attribute.CanIgnoreInvalidAttribute): New function.
9965 (Attribute.ScanForIndexerName): Move to ...
9966 (Attributes.ScanForIndexerName): ... here.
9967 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
9968 (Attributes.Search): New internal variant that can choose not to
9969 complain if types aren't resolved. The original signature now
9971 (Attributes.GetClsCompliantAttribute): Use internal variant, with
9972 complaints suppressed.
9973 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
9974 only if it not useful.
9975 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
9976 top-level for attributes that are shared between the assembly
9977 and a top-level class.
9978 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
9979 * class.cs: Update to reflect changes.
9980 (DefineIndexers): Fuse loops.
9981 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
9982 a couple more variants of attribute names.
9984 2004-05-18 Marek Safar <marek.safar@seznam.cz>
9986 Fix bug #52585 (Implemented explicit attribute declaration)
9989 (Attributable.ValidAttributeTargets): New abstract method. It gets
9990 list of valid attribute targets for explicit target declaration.
9991 (Attribute.Target): It holds target itself.
9992 (AttributeSection): Removed.
9993 (Attribute.CheckTargets): New method. It checks whether attribute
9994 target is valid for the current element.
9997 (EventProperty): New class. For events that are declared like
9998 property (with add and remove accessors).
9999 (EventField): New class. For events that are declared like field.
10002 * cs-parser.jay: Implemented explicit attribute target declaration.
10004 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
10005 Override ValidAttributeTargets.
10008 (ReturnParameter): Class for applying custom attributes on
10010 (ParameterAtribute): New class. Class for applying custom
10011 attributes on the parameter type.
10013 2004-05-17 Miguel de Icaza <miguel@ximian.com>
10015 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
10018 (Method): Allow UNSAFE here.
10020 * modifiers.cs: Support unsafe reporting.
10022 2004-05-17 Marek Safar <marek.safar@seznam.cz>
10024 * decl.cs: Fix bug #58478.
10026 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10028 * statement.cs: When checking for unreachable code on an EmptyStatement,
10029 set the location. Fixes bug #58488.
10031 2004-05-13 Miguel de Icaza <miguel@ximian.com>
10033 * driver.cs: Add -pkg handling.
10035 From Gonzalo: UseShelLExecute=false
10037 2004-05-12 Marek Safar <marek.safar@seznam.cz>
10040 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
10042 (Attribute.IsClsCompliaceRequired): Moved to base for better
10044 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
10045 when attribute is AttributeUsageAttribute.
10046 (Attribute.GetValidTargets): Simplified.
10047 (Attribute.GetAttributeUsage): New method returns AttributeUsage
10048 attribute for this type.
10049 (Attribute.ApplyAttributes): Method renamed to Emit and make
10051 (GlobalAttributeSection): New class for special handling of global
10052 attributes (assembly, module).
10053 (AttributeSection.Emit): New method.
10055 * class.cs: Implemented Attributable abstract methods.
10056 (MethodCore.LabelParameters): Moved to Parameter class.
10057 (Accessor): Is back simple class.
10058 (PropertyMethod): Implemented Attributable abstract class.
10059 (DelegateMethod): Implemented Attributable abstract class.
10060 (Event): New constructor for disctintion between normal Event
10061 and Event with accessors.
10063 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
10065 * codegen.cs, const.cs, decl.cs, delegate.cs:
10066 (CommonAssemblyModulClass): Implemented Attributable abstract class
10069 * enum.cs: Implement IAttributeSupport interface.
10070 (EnumMember): New class for emum members. Implemented Attributable
10074 (ParameterBase): Is abstract.
10075 (ReturnParameter): New class for easier [return:] attribute handling.
10077 * typemanager.cs: Removed builder_to_attr.
10079 2004-05-11 Raja R Harinath <rharinath@novell.com>
10082 * attribute.cs (Attribute.GetPositionalValue): New function.
10083 * class.cs (TypeContainer.VerifyMembers): New function.
10084 (TypeContainer.Emit): Use it.
10085 (ClassOrStruct): New base class for Class and Struct.
10086 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
10087 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
10089 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
10090 then each non-static field should have a FieldOffset attribute.
10091 Otherwise, none of the fields should have a FieldOffset attribute.
10092 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
10093 and FieldOffset attributes.
10094 * typemanager.cs (TypeManager.struct_layout_attribute_type)
10095 (TypeManager.field_offset_attribute_type): New core types.
10096 (TypeManager.InitCoreTypes): Initialize them.
10098 2004-05-11 Michal Moskal <malekith@pld-linux.org>
10100 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
10101 Return correct type.
10104 2004-05-09 Miguel de Icaza <miguel@ximian.com>
10106 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
10107 be implicitly converted to ulong.
10109 * expression.cs: The logic for allowing operator &, | and ^ worked
10110 was wrong, it worked before because we did not report an error in
10111 an else branch. Fixes 57895.
10113 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
10114 allow volatile fields to be reference types.
10116 2004-05-07 Miguel de Icaza <miguel@ximian.com>
10118 * driver.cs: Add support for /debug-
10120 2004-05-07 Raja R Harinath <rharinath@novell.com>
10122 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
10123 Add a 'complain' parameter to silence errors.
10124 (Attribute.Resolve): Update to changes. Put in sanity check to catch
10125 silently overlooked type-resolutions.
10126 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
10127 to reflect changes.
10128 (Attributes.Search): New function.
10129 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
10130 (Attributes.GetAttributeFullName): Remove hack.
10131 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
10132 Update to reflect changes.
10133 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
10134 Use Attributes.Search instead of nested loops.
10136 2004-05-07 Marek Safar <marek.safar@seznam.cz>
10139 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
10140 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
10141 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
10143 * report.cs: (Report.Warning): Renamed to Warning_T because of
10144 parameter collision.
10146 2004-05-05 Raja R Harinath <rharinath@novell.com>
10148 * expression.cs (MemberAccess.ResolveMemberAccess):
10149 Exit with non-zero status after Report.Error.
10150 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
10152 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
10154 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
10156 * support.cs: Don't hang when the file is empty.
10158 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
10160 * support.cs: In SeekableStreamReader, compute the preamble size of the
10161 underlying stream. Position changes should take into account that initial
10164 2004-05-03 Todd Berman <tberman@sevenl.net>
10166 * driver.cs: remove unused GetSysVersion function.
10168 2004-05-03 Todd Berman <tberman@sevenl.net>
10170 * driver.cs: Remove the hack from saturday, as well as the hack
10171 from jackson (LoadAssemblyFromGac), also adds the CWD to the
10172 link_paths to get that bit proper.
10174 2004-05-01 Todd Berman <tberman@sevenl.net>
10176 * driver.cs: Try a LoadFrom before a Load, this checks the current
10177 path. This is currently a bug in mono that is be fixed, however, this
10178 provides a workaround for now. This will be removed when the bug
10181 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
10183 * CryptoConvert.cs: Updated to latest version. Fix issue with
10184 incomplete key pairs (#57941).
10186 2004-05-01 Todd Berman <tberman@sevenl.net>
10188 * driver.cs: Remove '.' from path_chars, now System.* loads properly
10191 2004-04-30 Jackson Harper <jackson@ximian.com>
10193 * codegen.cs: Open keys readonly.
10195 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10197 * typemanager.cs: don't report cyclic struct layout when a struct
10198 contains 2 or more fields of the same type. Failed for Pango.AttrShape
10199 which has 2 Pango.Rectangle fields.
10201 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
10203 * expression.cs: Handle IntPtr comparisons with IL code
10204 rather than a method call.
10206 2004-04-29 Martin Baulig <martin@ximian.com>
10208 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
10209 the list of PropertyInfo's in class hierarchy and find the
10210 accessor. Fixes #56013.
10212 2004-04-29 Martin Baulig <martin@ximian.com>
10214 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
10216 2004-04-29 Martin Baulig <martin@ximian.com>
10218 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
10220 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
10222 2004-04-29 Martin Baulig <martin@ximian.com>
10224 * class.cs (ConstructorInitializer.Resolve): Check whether the
10225 parent .ctor is accessible. Fixes #52146.
10227 2004-04-29 Martin Baulig <martin@ximian.com>
10229 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
10231 * statement.cs (Using.EmitLocalVariableDecls): Use
10232 TypeManager.idisposable_type, not typeof (IDisposable).
10233 (Foreach.EmitCollectionForeach): Added support for valuetypes.
10235 2004-04-29 Martin Baulig <martin@ximian.com>
10237 * class.cs (Event.Define): Don't emit the field and don't set
10238 RTSpecialName and SpecialName for events on interfaces. Fixes
10241 2004-04-29 Raja R Harinath <rharinath@novell.com>
10243 Refactor Attribute.ApplyAttributes.
10244 * attribute.cs (Attributable): New base class for objects that can
10245 have Attributes applied on them.
10246 (Attribute): Make AttributeUsage fields public.
10247 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
10248 (Attribute.IsInternalCall): New property.
10249 (Attribute.UsageAttr): Convert to a public read-only property.
10250 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
10251 (Attribute.ResolveType, Attribute.Resolve)
10252 (Attribute.ScanForIndexerName): Update to reflect changes.
10253 (Attribute.CheckAttributeTarget): Re-format.
10254 (Attribute.ApplyAttributes): Refactor, to various
10255 Attributable.ApplyAttributeBuilder methods.
10256 * decl.cs (MemberCore): Make Attributable.
10257 * class.cs (Accessor): Make Attributable.
10258 (MethodData.ApplyAttributes): Use proper attribute types, not
10260 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
10261 (TypeContainer.ApplyAttributeBuilder)
10262 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
10263 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
10264 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
10265 (Operator.ApplyAttributeBuilder): New factored-out methods.
10266 * const.cs (Const.ApplyAttributeBuilder): Likewise.
10267 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
10268 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
10269 * parameter.cs (ParameterBase): New Attributable base class
10270 that can also represent Return types.
10271 (Parameter): Update to the changes.
10273 2004-04-29 Jackson Harper <jackson@ximian.com>
10275 * driver.cs: Prefer the corlib system version when looking for
10276 assemblies in the GAC. This is still a hack, but its a better hack
10279 2004-04-29 Marek Safar <marek.safar@seznam.cz>
10281 * decl.cs, enum.cs: Improved error 3005 reporting.
10283 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
10284 (related_symbols): New private member for list of symbols
10285 related to reported error/warning.
10287 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
10289 2004-04-29 Martin Baulig <martin@ximian.com>
10291 * ecore.cs (Expression.Constantify): If we're an enum and
10292 TypeManager.TypeToCoreType() doesn't give us another type, use
10293 t.UnderlyingSystemType. Fixes #56178.
10295 2004-04-29 Martin Baulig <martin@ximian.com>
10297 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
10298 interfaces and for each interface, only add members directly
10299 declared in that interface. Fixes #53255.
10301 2004-04-28 Martin Baulig <martin@ximian.com>
10303 * expression.cs (ConditionalLogicalOperator): Use a temporary
10304 variable for `left' to avoid that we evaluate it more than once;
10307 2004-04-28 Martin Baulig <martin@ximian.com>
10309 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
10312 2004-04-28 Martin Baulig <martin@ximian.com>
10314 * statement.cs (LocalInfo.Resolve): Check whether the type is not
10317 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
10318 whether the type is not void (CS1547).
10320 2004-04-28 Martin Baulig <martin@ximian.com>
10322 * expression.cs (Unary.DoResolveLValue): Override this and report
10323 CS0131 for anything but Operator.Indirection.
10325 2004-04-28 Martin Baulig <martin@ximian.com>
10327 Committing a patch from Ben Maurer; see bug #50820.
10329 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
10332 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
10335 2004-04-28 Martin Baulig <martin@ximian.com>
10337 Committing a patch from Ben Maurer; see bug #50820.
10339 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
10342 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
10345 2004-04-28 Martin Baulig <martin@ximian.com>
10347 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
10348 (Block.AddLabel): Call DoLookupLabel() to only search in the
10351 2004-04-28 Martin Baulig <martin@ximian.com>
10353 * cfold.cs (ConstantFold.BinaryFold): Added special support for
10354 comparing StringConstants and NullLiterals in Equality and Inequality.
10356 2004-04-28 Jackson Harper <jackson@ximian.com>
10358 * driver.cs: Attempt to load referenced assemblies from the
10359 GAC. This is the quick and dirty version of this method that
10360 doesnt take into account versions and just takes the first
10361 canidate found. Will be good enough for now as we will not have more
10362 then one version installed into the GAC until I update this method.
10364 2004-04-28 Martin Baulig <martin@ximian.com>
10366 * typemanager.cs (TypeManager.CheckStructCycles): New public
10367 static method to check for cycles in the struct layout.
10369 * rootcontext.cs (RootContext.PopulateTypes): Call
10370 TypeManager.CheckStructCycles() for each TypeContainer.
10371 [Note: We only need to visit each type once.]
10373 2004-04-28 Martin Baulig <martin@ximian.com>
10375 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
10377 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
10378 success and added `out object value'. Use a `bool resolved' field
10379 to check whether we've already been called rather than
10380 `ConstantValue != null' since this breaks for NullLiterals.
10382 2004-04-28 Raja R Harinath <rharinath@novell.com>
10384 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
10385 setting of this flag, since the 'set' method may be non-public.
10387 2004-04-28 Raja R Harinath <rharinath@novell.com>
10389 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
10390 check on current_vector.Block.
10392 2004-04-27 Martin Baulig <martin@ximian.com>
10394 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
10395 a field initializer. Fixes #56459.
10397 2004-04-27 Martin Baulig <martin@ximian.com>
10399 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
10400 we're not attempting to use an indexer. Fixes #52154.
10402 2004-04-27 Martin Baulig <martin@ximian.com>
10404 * statement.cs (Return): Don't create a return label if we don't
10405 need it; reverts my change from January 20th. Thanks to Ben
10408 2004-04-27 Martin Baulig <martin@ximian.com>
10410 According to the spec, `goto' can only leave a nested scope, but
10413 * statement.cs (Block.LookupLabel): Only lookup in the current
10414 block, don't recurse into parent or child blocks.
10415 (Block.AddLabel): Check in parent and child blocks, report
10416 CS0140/CS0158 if we find a duplicate.
10417 (Block): Removed this indexer for label lookups.
10418 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
10419 this already does the error reporting for us.
10422 (FlowBranching.UsageVector.Block): New public variable; may be null.
10423 (FlowBranching.CreateSibling): Added `Block' argument.
10424 (FlowBranching.LookupLabel): New public virtual method. Lookup a
10425 label for the target of a `goto' and check whether we're not
10426 leaving a `finally'.
10428 2004-04-27 Martin Baulig <martin@ximian.com>
10430 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
10431 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
10434 2004-04-27 Martin Baulig <martin@ximian.com>
10436 * statement.cs (Block.AddLabel): Also check for implicit blocks
10437 and added a CS0158 check.
10439 2004-04-27 Martin Baulig <martin@ximian.com>
10441 * flowanalysis.cs (FlowBranchingLoop): New class.
10442 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
10443 UsageVector's instead of an ArrayList.
10444 (FlowBranching.Label): Likewise.
10445 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
10446 (FlowBranching.AddBreakVector): New method.
10448 2004-04-27 Miguel de Icaza <miguel@ximian.com>
10450 * attribute.cs: Small regression fix: only convert the type if we
10451 the type is different, fixes System.Drawing build.
10453 2004-04-27 Martin Baulig <martin@ximian.com>
10455 * attribute.cs (Attribute.Resolve): If we have a constant value
10456 for a named field or property, implicity convert it to the correct
10459 2004-04-27 Raja R Harinath <rharinath@novell.com>
10461 * statement.cs (Block.Block): Implicit blocks share
10462 'child_variable_names' fields with parent blocks.
10463 (Block.AddChildVariableNames): Remove.
10464 (Block.AddVariable): Mark variable as "used by a child block" in
10465 every surrounding block.
10466 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
10467 been used in a child block, complain about violation of "Invariant
10468 meaning in blocks" rule.
10469 * cs-parser.jay (declare_local_variables): Don't use
10470 AddChildVariableNames.
10471 (foreach_statement): Don't create an implicit block: 'foreach'
10472 introduces a scope.
10474 2004-04-23 Miguel de Icaza <miguel@ximian.com>
10476 * convert.cs (ImplicitNumericConversion): 0 is also positive when
10477 converting from 0L to ulong. Fixes 57522.
10479 2004-04-22 Marek Safar <marek.safar@seznam.cz>
10481 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
10482 derived class hides via 'new' keyword field from base class (test-242.cs).
10483 TODO: Handle this in the more general way.
10485 * class.cs (CheckBase): Ditto.
10487 2004-04-22 Marek Safar <marek.safar@seznam.cz>
10489 * decl.cs (caching_flags): New member for storing cached values
10491 (MemberCore.Flags): New enum where bit flags for caching_flags
10493 (MemberCore.cls_compliance): Moved to caching_flags.
10494 (DeclSpace.Created): Moved to caching_flags.
10496 * class.cs: Use caching_flags instead of DeclSpace.Created
10498 2004-04-21 Miguel de Icaza <miguel@ximian.com>
10500 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
10501 if we are only a derived class, not a nested class.
10503 * typemanager.cs: Same as above, but do this at the MemberLookup
10504 level (used by field and methods, properties are handled in
10505 PropertyExpr). Allow for the qualified access if we are a nested
10508 2004-04-21 Marek Safar <marek.safar@seznam.cz>
10510 * class.cs: Refactoring.
10511 (IMethodData): New inteface; Holds links to parent members
10512 to avoid member duplication (reduced memory allocation).
10513 (Method): Implemented IMethodData interface.
10514 (PropertyBase): New inner classes for get/set methods.
10515 (PropertyBase.PropertyMethod): Implemented IMethodData interface
10516 (Event): New inner classes for add/remove methods.
10517 (Event.DelegateMethod): Implemented IMethodData interface.
10519 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
10520 EmitContext (related to class.cs refactoring).
10522 2004-04-21 Raja R Harinath <rharinath@novell.com>
10524 * delegate.cs (Delegate.VerifyApplicability): If the number of
10525 arguments are the same as the number of parameters, first try to
10526 verify applicability ignoring any 'params' modifier on the last
10530 2004-04-08 Martin Baulig <martin@ximian.com>
10532 Merged latest changes into gmcs. Please keep this comment in
10533 here, it makes it easier for me to see what changed in MCS since
10534 the last time I merged.
10536 2004-04-16 Raja R Harinath <rharinath@novell.com>
10538 * class.cs (TypeContainer.AddIndexer): Use
10539 'ExplicitInterfaceName' to determine if interface name was
10540 explicitly specified. 'InterfaceType' is not initialized at this time.
10541 (TypeContainer.DefineIndexers): Remove use of temporary list. The
10542 Indexers array is already in the required order. Initialize
10543 'IndexerName' only if there are normal indexers.
10544 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
10545 (TypeContainer.Emit): Emit DefaultMember attribute only if
10546 IndexerName is initialized.
10549 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
10551 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
10554 2004-04-15 Raja R Harinath <rharinath@novell.com>
10556 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
10560 * attribute.cs (Attribute.Resolve): Check for duplicate named
10564 2004-04-15 Miguel de Icaza <miguel@ximian.com>
10566 * iterators.cs (MarkYield): track whether we are in an exception,
10567 and generate code accordingly. Use a temporary value to store the
10568 result for our state.
10570 I had ignored a bit the interaction of try/catch with iterators
10571 since their behavior was not entirely obvious, but now it is
10572 possible to verify that our behavior is the same as MS .NET 2.0
10576 2004-04-14 Miguel de Icaza <miguel@ximian.com>
10578 * iterators.cs: Avoid creating temporaries if there is no work to
10581 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
10582 Enumerations, use TypeManager.EnumToUnderlying and call
10585 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
10588 (This.Emit): Use EmitContext.EmitThis to emit our
10591 (This.EmitAssign): Ditto.
10593 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
10594 codepaths, we will move all the functionality into
10597 (FieldExpr.EmitAssign): Ditto.
10599 This fixes several hidden bugs that I uncovered while doing a code
10600 review of this today.
10602 * codegen.cs (EmitThis): reworked so the semantics are more clear
10603 and also support value types "this" instances.
10605 * iterators.cs: Changed so that for iterators in value types, we
10606 do not pass the value type as a parameter.
10608 Initialization of the enumerator helpers is now done in the caller
10609 instead of passing the parameters to the constructors and having
10610 the constructor set the fields.
10612 The fields have now `assembly' visibility instead of private.
10614 2004-04-11 Miguel de Icaza <miguel@ximian.com>
10616 * expression.cs (Argument.Resolve): Check if fields passed as ref
10617 or out are contained in a MarshalByRefObject.
10619 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
10620 another compiler type.
10622 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
10624 * class.cs (Indexer.Define): use the new name checking method.
10625 Also, return false on an error.
10626 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
10627 (is_identifier_[start/part]_character): make static.
10629 2004-04-10 Miguel de Icaza <miguel@ximian.com>
10631 * expression.cs (Binary.ResolveOperator): Do no append strings
10632 twice: since we can be invoked more than once (array evaluation)
10633 on the same concatenation, take care of this here. Based on a fix
10634 from Ben (bug #56454)
10636 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
10638 * codegen.cs: Fix another case where CS1548 must be reported (when
10639 delay-sign isn't specified and no private is available #56564). Fix
10640 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
10641 error when MCS is used on the MS runtime and we need to delay-sign
10642 (which seems unsupported by AssemblyBuilder - see #56621).
10644 2004-04-08 Marek Safar <marek.safar@seznam.cz>
10646 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
10647 (TypeManager.ComputeNamespaces): Faster implementation for
10650 * compiler.csproj: Updated AssemblyName to mcs.
10652 2004-05-11 Jackson Harper <jackson@ximian.com>
10654 * Makefile: Preserve MONO_PATH
10656 2004-05-11 Jackson Harper <jackson@ximian.com>
10658 * Makefile: Use mono and mcs to build gmcs
10660 2004-05-03 Miguel de Icaza <miguel@ximian.com>
10662 * codegen.cs: Add patch from Robert Shade
10663 <rshade@dvsconsulting.com>, use FileAccess.Read on the keyfile, to
10666 2004-05-02 Sebastien Pouliot <sebastien@ximian.com>
10668 * CryptoConvert.cs: Updated to latest version. Fix issue with
10669 incomplete key pairs (#57941).
10671 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
10673 * codegen.cs: Fix another case where CS1548 must be reported (when
10674 delay-sign isn't specified and no private is available #56564). Fix
10675 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
10676 error when MCS is used on the MS runtime and we need to delay-sign
10677 (which seems unsupported by AssemblyBuilder - see #56621).
10679 2004-04-29 Jackson Harper <jackson@ximian.com>
10681 * Makefile: Set MONO_PATH to use the bootstrap corlib
10682 * driver.cs: Check the GAC for referenced assemblies.
10684 2004-04-29 Martin Baulig <martin@ximian.com>
10686 * Makefile (gmcs.exe): Set MONO_PATH to use `../class/lib/net_2_0'.
10688 2004-04-07 Martin Baulig <martin@ximian.com>
10690 * expression.cs (Binary.ResolveOperator): Added special case for
10691 Equality/Inequality between a type parameter and a null literal.
10693 2004-04-07 Martin Baulig <martin@ximian.com>
10695 * convert.cs: Check null literal -> type parameter conversions.
10697 2004-04-07 Martin Baulig <martin@ximian.com>
10699 * generic.cs (ConstructedType.CheckConstraints): Enforce the
10700 `class' and `struct' constraints.
10702 2004-04-07 Martin Baulig <martin@ximian.com>
10704 * generic.cs (SpecialConstraint): New public enum.
10705 (Constraints.Resolve): Added support for the `class' and `struct'
10708 * cs-parser.jay (type_parameter_constraint): Added support for the
10709 `class' and `struct' constraints.
10711 2004-04-07 Martin Baulig <martin@ximian.com>
10713 * support.cs (GenericConstraints): Replaced `Types' by
10714 `ClassConstraint' and `InterfaceConstraints'; added
10715 `HasClassConstraint'.
10717 2004-04-07 Martin Baulig <martin@ximian.com>
10720 (Constraints.InterfaceConstraints): New public property.
10721 (Constraints.Types): Make this property public
10722 (TypeParameter): Implement IMemberContainer.
10723 (TypeParameter.Define): Take a `GenericTypeParameterBuilder'
10724 instead of a TypeBuilder/MethodBuilder; pass the interface
10725 constraints to TypeManager.AddTypeParameter().
10726 (TypeParameter.DefineType): Just take an EmitContext and no
10727 TypeBuilder/MethodBuilder. Use the new public API.
10729 * typemanager.cs (TypeManager.AddTypeParameter): Added
10730 `TypeExpr[]' argument; add the interfaces to the
10731 `builder_to_ifaces' hash.
10732 (TypeManager.LookupMemberContainer): For
10733 GenericTypeParameterBuilders, get the TypeParameter from the
10734 `builder_to_type_param'.
10735 (TypeManager.FindMembers): For GenericTypeParameterBuilders, get
10736 the TypeParameter and call FindMembers on it.
10738 2004-04-07 Martin Baulig <martin@ximian.com>
10741 (MethodCore.GenericMethod): Moved this field here from Method.
10742 (MethodCore.IsDuplicateImplementation): Take the number of type
10743 parameters into account if we're a generic method.
10745 * expression.cs (Invocation.InferTypeArguments): Don't return true
10746 if `arguments' is null; we still need to check whether we actually
10747 don't need to infer anything in this case.
10748 (MemberAccess): Merged the functionality from GenericMemberAccess
10751 * generic.cs (GenericMemberAccess): Removed.
10753 2004-04-05 Martin Baulig <martin@ximian.com>
10755 * decl.cs (MemberCore): For generic classes, interfaces and
10756 structs, `Name' now includes the number of type parameters
10757 ("Stack!1.Node!1").
10758 (DeclSpace.FindType): Removed the `num_type_args' argument; we now
10759 encode the number of type arguments in the type name.
10761 * expression.cs (Expression.MemberLookup): Removed the
10762 `num_type_args' argument; we now encode the number of type
10763 arguments in the type name.
10765 * ecore.cs (SimpleName): Encode the number of type arguments in
10766 the type name itself.
10768 * generic.cs (ConstructedType): Likewise.
10770 * tree.cs (Tree.RecordDecl): Take a `string' instead of a
10771 `MemberName'; we now include the number of type parameters in the
10774 * typemanager.cs (TypeManager.CheckGeneric): Removed.
10775 (TypeManager.MemberLookup): Removed the
10776 `num_type_args' argument; we now encode the number of type
10777 arguments in the type name.
10779 2004-04-03 Martin Baulig <martin@ximian.com>
10781 * decl.cs (MemberCore.ctor): Take a MemberName instead of a sting.
10782 (MemberCore.MemberName): Moved here from MemberBase.
10783 (DeclSpace.SetParameterInfo): Just take the constraints as an
10784 ArrayList; we already have the type parameters in our
10785 `MemberName'; also do the CS0080 reporting here.
10787 * cs-parser.jay (struct_declaration): Use `member_name' instead of
10788 `IDENTIFIER opt_type_parameter_list'; when constructing our
10789 `MemberName', it'll already include our type parameters.
10790 (class_declaration, interface_declaration): Likewise.
10791 (delegate_declaration): Likewise.
10792 (MakeName): Take a MemberName and return a MemberName.
10793 The following two changes are required to avoid shift/reduce conflicts:
10794 (member_name): Don't include a TypeName anymore; ie. this is now
10795 just 'IDENTIFIER opt_type_parameter_list'.
10796 (property_declaration, event_declaration): Use a
10797 `namespace_or_type_name' instead of a `member_name'.
10799 2004-04-03 Martin Baulig <martin@ximian.com>
10801 * decl.cs (MemberName): Renamed to `TypeName' and created a new
10802 `MemberName' class.
10803 (TypeName): Formerly known as MemberName.
10805 * namespace.cs (NamespaceEntry.UsingAlias): Take a `TypeName'
10806 instead of a `MemberName'.
10808 * cs-parser.jay (namespace_or_type_name): Create a TypeName.
10809 (member_name): New rule; create a MemberName.
10811 2004-04-02 Martin Baulig <martin@ximian.com>
10813 * namespace.cs (NamespaceEntry.VerifyUsing): Added error checking
10814 (CS0305 and CS0308).
10816 2004-04-02 Martin Baulig <martin@ximian.com>
10818 * generic.cs (GenericMemberAccess.ResolveAsTypeStep): Added
10819 support for nested types.
10821 2004-04-02 Martin Baulig <martin@ximian.com>
10823 * ecore.cs (IAlias): New public interface.
10824 (TypeExpr, TypeExpression): Implement IAlias.
10825 (TypeAliasExpression): New public class.
10827 * namespace.cs (Namespace): Implement IAlias.
10828 (Namespace.Lookup): Return an IAlias instead on an object.
10829 (Namespace.DefineName): Take an IAlias instead of an object.
10830 (NamespaceEntry.AliasEntry.Resolve): Return an IAlias instead of
10832 (NamespaceEntry.UsingAlias): Take a Membername instead of an
10834 (NamespaceEntry.LookupAlias): Return an IAlias instead on an
10836 (NamespaceEntry.Lookup): Likewise.
10838 * rootcontext.cs (RootContext.LookupType): Return a TypeExpr
10841 * decl.cs (DeclSpace): Implement IAlias.
10842 (DeclSpace.LookupAlias): Return an IAlias instead of a string.
10844 * generic.cs (ConstructedType): Improved error checking.
10846 2004-04-02 Martin Baulig <martin@ximian.com>
10848 * convert.cs: Added type parameter conversions.
10851 (UnboxCast.Emit): Emit an `unbox.any' for type params.
10852 (ClassCast.Emit): If the source type is a type parameter, box it.
10853 If the target type is a type parameter, emit an `unbox.any'
10854 instead of a `classcast'.1
10856 2004-04-01 Martin Baulig <martin@ximian.com>
10858 * cs-tokenizer.cs (parse_less_than): Allow Token.DOT.
10860 2004-04-01 Martin Baulig <martin@ximian.com>
10862 * generic.cs (ConstructedType.CheckConstraints): Use
10863 Convert.ImplicitStandardConversionExists(); user-defined implicit
10864 conversions are not allowed according to the spec.
10866 2004-03-30 Martin Baulig <martin@ximian.com>
10868 * expression.cs (New): Added support for type parameters.
10871 (TypeManager.activator_type): New public static field.
10872 (TypeManager.activator_create_instance): Likewise.
10874 2004-03-30 Martin Baulig <martin@ximian.com>
10876 * typemanager.cs (TypeManager.HasConstructorConstraint): New
10879 2004-03-30 Martin Baulig <martin@ximian.com>
10881 * generic.cs (ConstructedType.CheckConstraints): Actually follow
10882 the spec here: the argument type must be convertible to the
10885 2004-03-30 Martin Baulig <martin@ximian.com>
10888 (TypeParameter.Define, TypeParameter.DefineMethod): Call
10889 TypeManager.AddTypeParameter().
10890 (ConstructedType.CheckConstraints): Re-enable this and actually
10891 check whether we have a constructor constraint.
10894 (TypeManager.builder_to_type_param): New static field.
10895 (TypeManager.AddTypeParameter): New static method.
10896 (TypeManager.LookupTypeParameter): New public method.
10898 2004-03-30 Martin Baulig <martin@ximian.com>
10900 * generic.cs (TypeParameter.DefineType): Return a boolean and use
10901 the new API to actually define the constructor constraint.
10904 (TypeManager.new_constraint_attr_type): New static field.
10905 (TypeManager.InitCoreTypes): Initialize it.
10907 2004-03-30 Martin Baulig <martin@ximian.com>
10909 * generic.cs (Constraints): Completed error checking, use correct
10912 2004-03-29 Martin Baulig <martin@ximian.com>
10914 * delegate.cs (Delegate.VerifyMethod): Infer type arguments.
10916 * expression.cs (Invocation.InferTypeArguments): Added overloaded
10917 public version which takes a `ParameterData pd' instead of an
10920 2004-03-29 Martin Baulig <martin@ximian.com>
10922 * typemanager.cs (TypeManager.IsGenericMethod): Take a MethodBase,
10925 2004-03-29 Martin Baulig <martin@ximian.com>
10927 * expression.cs (Argument.ResolveMethodGroup): If we're a
10928 ConstructedType, call GetMemberAccess() on it.
10930 2004-03-29 Martin Baulig <martin@ximian.com>
10932 * class.cs (MethodBase.CheckGenericOverride): New abstract method.
10933 (MethodCore.CheckGenericOverride): When overriding a generic
10934 method, check whether the constraints match.
10936 * support.cs (GenericConstraints): New public interface.
10937 (ParameterData.GenericConstraints): New public method.
10939 * parameter.cs (Parameter.Resolve): Check whether we're a generic
10940 method parameter and compute our constraints if appropriate.
10941 (Parameter.GenericConstraints): New public property.
10943 * generic.cs (Constraints): Implement GenericConstraints.
10945 2004-03-29 Martin Baulig <martin@ximian.com>
10947 * decl.cs (MemberCache.FindMemberToOverride): Use
10948 `paramTypes [j].Equals (cmpAttrs [j])' instead of `=='.
10950 2004-03-29 Martin Baulig <martin@ximian.com>
10952 * generic.cs (GenericMethod.Define): Resolve our type parameters.
10954 2004-03-29 Martin Baulig <martin@ximian.com>
10956 * cs-parser.jay: Report CS0080 instead of -200 ("Constraints are
10957 not allowed on non-generic declarations").
10959 2004-03-29 Martin Baulig <martin@ximian.com>
10961 * expression.cs (Invocation.InferTypeArguments): Added overloaded
10962 public version of this method.
10964 * class.cs (MethodCore.IsDuplicateImplementation): Use
10965 Invocation.InferTypeArguments() to check this.
10967 2004-03-29 Martin Baulig <martin@ximian.com>
10969 * convert.cs: Use TypeManager.IsDelegateType() instead of
10970 comparing types correctly.
10972 2004-03-29 Martin Baulig <martin@ximian.com>
10974 * convert.cs: Use TypeManager.IsSubclassOf() instead of comparing
10975 types directly to make it work for generic instances.
10977 * typemanager.cs (TypeManager.IsSubclassOf): New static method.
10979 2004-03-29 Martin Baulig <martin@ximian.com>
10981 * typemanager.cs (TypeManager.MayBecomeEqualGenericTypes): Added
10982 support for arrays.
10984 2004-03-24 Martin Baulig <martin@ximian.com>
10986 * decl.cs (DeclSpace.FindType): Also use
10987 TypeManager.CheckGeneric() for types from the using clauses.
10989 2004-03-23 Martin Baulig <martin@ximian.com>
10991 * expression.cs (Invocation.OverloadResolve): Added `bool
10992 may_fail' argument and use it instead of the Location.IsNull() hack.
10994 2004-03-23 Martin Baulig <martin@ximian.com>
10996 * expression.cs (Invocation.InferType): Use correct type inference
10999 2004-03-23 Martin Baulig <martin@ximian.com>
11001 * ecore.cs (MethodGroupExpr.Name): Use
11002 TypeManager.CSharpSignature() instead of just the name.
11004 * expression.cs (Invocation.OverloadResolve): Provide better error
11006 (Invocation.DoResolve): OverloadResolve() never returns null
11007 without reporting an error, so removed the error -6 reporting here.
11009 2004-03-23 Martin Baulig <martin@ximian.com>
11011 * typemanager.cs (TypeManager.GetMethodFlags): Fixed the FIXME for
11014 * cs-parser.jay (delegate_declaration): Support generic delegates.
11016 * delegate.cs: Support generic delegates.
11018 2004-03-22 Martin Baulig <martin@ximian.com>
11020 * expression.cs (Invocation.InferParamsTypeArguments): New static
11021 method; does type inference for params arguments.
11023 2004-03-21 Martin Baulig <martin@ximian.com>
11025 * typemanager.cs (TypeManager.IsGenericMethod): New public static
11026 method; checks whether a method is a generic method.
11028 * expression.cs (Invocation.InferTypeArguments): New static method;
11029 infer type arguments for generic method invocation.
11031 * ecore.cs (MethodGroupExpr.HasTypeArguments): New public
11032 property; we set this to true if we're resolving a generic method
11033 invocation and the user specified type arguments, ie. we're not
11034 doing type inference.
11036 2004-03-20 Martin Baulig <martin@ximian.com>
11038 * class.cs (MethodData.DeclaringType): New public property.
11039 (MethodData.Define): Set DeclaringType here.
11040 (Operator.Define): Use OperatorMethod.MethodData.DeclaringType
11041 instead of OperatorMethodBuilder.DeclaringType.
11043 2004-03-20 Martin Baulig <martin@ximian.com>
11045 * cs-tokenizer.cs (xtoken): Return a special
11046 Token.DEFAULT_OPEN_PARENS for "`default' followed by open parens".
11048 * cs-parser.jay (default_value_expression): Switch to the new
11051 2004-03-19 Martin Baulig <martin@ximian.com>
11053 * decl.cs (MemberName): New class. We use this to "construct"
11054 namespace_or_type_name's.
11056 * generics.cs (TypeArguments.GetDeclarations): New public method;
11057 returns the type arguments as a string[] and reports a CS0081 if
11058 one of them is not an identifier.
11060 * class.cs (MemberBase): The .ctor now takes the name as a
11061 MemberName instead of a string.
11062 (MemberBase.ExplicitInterfaceName): Changed type from string to
11064 (MemberBase.DoDefine): If we're an explicit implementation, the
11065 InterfaceType may be a generic instance.
11067 * cs-parser.jay (namespace_or_type_name): Return a MemberName.
11068 (namespace_name): Call MemberName.GetName () to transform the
11069 MemberName into a string and ensure we don't have any type
11071 (type_name): Call MemberName.GetTypeExpression() to transfrom the
11072 MemberName into an expression.
11073 (method_header): Use namespace_or_type_name instead of member_name.
11075 2004-04-07 Miguel de Icaza <miguel@ximian.com>
11077 * rootcontext.cs: Add new types to the boot resolution.
11079 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
11080 MulticastDelegate is not allowed.
11082 * typemanager.cs: Add new types to lookup: System.TypedReference
11085 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
11086 check for TypedReference or ArgIterator, they are not allowed.
11088 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
11089 makes us properly catch 1510 in some conditions (see bug 56016 for
11092 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
11094 * CryptoConvert.cs: update from corlib version
11097 2004-04-05 Miguel de Icaza <miguel@ximian.com>
11099 * class.cs (Indexer.Define): Check indexername declaration
11101 2004-04-05 Marek Safar <marek.safar@seznam.cz>
11103 * attribute.cs (IsClsCompliant): Fixed problem with handling
11104 all three states (compliant, not-compliant, undetected).
11106 2004-03-30 Marek Safar <marek.safar@seznam.cz>
11108 * attribute.cs (Attribute): Location is now public.
11109 (Resolve): Store resolved arguments (pos_values) in attribute class.
11110 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
11111 (GetClsCompliantAttributeValue): New method that gets
11112 CLSCompliantAttribute value.
11113 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
11114 if exists else null.
11115 (AttributeTester): New class for CLS-Compliant verification routines.
11117 * class.cs (Emit): Add CLS-Compliant verification.
11118 (Method.GetSignatureForError): Implemented.
11119 (Constructor.GetSignatureForError): Implemented
11120 (Constructor.HasCompliantArgs): Returns if constructor has
11121 CLS-Compliant arguments.
11122 (Constructor.Emit): Override.
11123 (Construcor.IsIdentifierClsCompliant): New method; For constructors
11124 is needed to test only parameters.
11125 (FieldBase.GetSignatureForError): Implemented.
11126 (TypeContainer): New member for storing base interfaces.
11127 (TypeContainer.FindMembers): Search in base interfaces too.
11129 * codegen.cs (GetClsComplianceAttribute): New method that gets
11130 assembly or module CLSCompliantAttribute value.
11131 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
11133 (ModuleClass.Emit): Add error 3012 test.
11135 * const.cs (Emit): Override and call base for CLS-Compliant tests.
11137 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
11138 state for all decl types.
11139 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
11140 if CLS-Compliant tests are required.
11141 (IsClsCompliaceRequired): New method. Analyze whether code
11142 must be CLS-Compliant.
11143 (IsExposedFromAssembly): New method. Returns true when MemberCore
11144 is exposed from assembly.
11145 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
11146 value or gets cached value.
11147 (HasClsCompliantAttribute): New method. Returns true if MemberCore
11148 is explicitly marked with CLSCompliantAttribute.
11149 (IsIdentifierClsCompliant): New abstract method. This method is
11150 used to testing error 3005.
11151 (IsIdentifierAndParamClsCompliant): New method. Common helper method
11152 for identifier and parameters CLS-Compliant testing.
11153 (VerifyClsCompliance): New method. The main virtual method for
11154 CLS-Compliant verifications.
11155 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
11156 null. I don't know why is null (too many public members !).
11157 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
11158 and get value of first CLSCompliantAttribute that found.
11160 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
11161 (VerifyClsCompliance): Override and add extra tests.
11163 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
11164 clscheck- disable CLS-Compliant verification event if assembly is has
11165 CLSCompliantAttribute(true).
11167 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
11168 ApllyAttribute is now called in emit section as in the other cases.
11169 Possible future Emit integration.
11170 (IsIdentifierClsCompliant): New override.
11171 (VerifyClsCompliance): New override.
11172 (GetEnumeratorName): Returns full enum name.
11174 * parameter.cs (GetSignatureForError): Implemented.
11176 * report.cs (WarningData): New struct for Warning message information.
11177 (LocationOfPreviousError): New method.
11178 (Warning): New method. Reports warning based on the warning table.
11179 (Error_T): New method. Reports error based on the error table.
11181 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
11182 verifications are done here.
11184 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
11186 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
11187 CLSCompliantAttribute.
11188 (all_imported_types): New member holds all imported types from other
11190 (LoadAllImportedTypes): New method fills static table with exported types
11191 from all referenced assemblies.
11192 (Modules): New property returns all assembly modules.
11194 2004-03-30 Miguel de Icaza <miguel@ximian.com>
11196 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
11197 throwing a parser error.
11199 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
11200 which removes the hardcoded get_/set_ prefixes for properties, as
11201 IL allows for the properties to be named something else.
11205 * expression.cs: Do not override operand before we know if it is
11206 non-null. Fix 56207
11208 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
11210 * typemanager.cs: support for pinned variables.
11212 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
11214 * decl.cs, typemanager.cs: Avoid using an arraylist
11215 as a buffer if there is only one result set.
11217 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
11219 * expression.cs: Make sure you cant call a static method
11220 with an instance expression, bug #56174.
11222 2004-03-29 Miguel de Icaza <miguel@ximian.com>
11224 * class.cs (IsDuplicateImplementation): Improve error reporting to
11225 flag 663 (method only differs in parameter modifier).
11227 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
11228 in preprocessor directives.
11230 * location.cs (LookupFile): Allow for the empty path.
11232 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
11233 better approach for some of that patch, but its failing with the
11234 CharSet enumeration. For now try/catch will do.
11236 * typemanager.cs: Do not crash if a struct does not have fields.
11239 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
11241 * expression.cs: cs0213, cant fix a fixed expression.
11244 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
11246 * cs-parser.jay: detect invalid embeded statements gracefully.
11249 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
11251 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
11254 the invocation type may not be a subclass of the tye of the item/
11255 The type of the item must be a subclass of the invocation item.
11260 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
11262 * attribute.cs: Added methods to get a string and a bool from an
11263 attribute. Required to information from AssemblyKeyFileAttribute,
11264 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
11265 * codegen.cs: Modified AssemblyName creation to include support for
11266 strongnames. Catch additional exceptions to report them as CS1548.
11267 * compiler.csproj: Updated include CryptoConvert.cs.
11268 * compiler.csproj.user: Removed file - user specific configuration.
11269 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
11270 Mono.Security assembly. The original class is maintained and tested in
11271 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
11272 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
11273 like CSC 8.0 (C# v2) supports.
11274 * Makefile: Added CryptoConvert.cs to mcs sources.
11275 * rootcontext.cs: Added new options for strongnames.
11277 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
11279 * driver.cs: For --expect-error, report error code `2'
11280 if the program compiled with no errors, error code `1' if
11281 it compiled with an error other than the one expected.
11283 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
11285 * compiler.csproj: Updated for Visual Studio .NET 2003.
11286 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
11287 * compiler.sln: Updated for Visual Studio .NET 2003.
11289 2004-03-24 Ravi Pratap M <ravi@ximian.com>
11291 * expression.cs: Fix bug #47234. We basically need to apply the
11292 rule that we prefer the conversion of null to a reference type
11293 when faced with a conversion to 'object' (csc behaviour).
11295 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
11297 * statement.cs: Shorter form for foreach, eliminates
11298 a local variable. r=Martin.
11300 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
11302 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
11303 checks if we can use brtrue/brfalse to test for 0.
11304 * expression.cs: use the above in the test for using brtrue/brfalse.
11305 cleanup code a bit.
11307 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
11309 * expression.cs: Rewrite string concat stuff. Benefits:
11311 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
11312 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
11313 rather than a concat chain.
11315 * typemanager.cs: Add lookups for more concat overloads.
11317 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
11319 * expression.cs: Emit shorter il code for array init.
11336 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
11338 * statement.cs: Before, two switch blocks would be merged if the
11339 total size of the blocks (end_item - begin_item + 1) was less than
11340 two times the combined sizes of the blocks.
11342 Now, it will only merge if after the merge at least half of the
11347 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
11349 * class.cs : csc build fix for GetMethods(). See bug #52503.
11351 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
11353 * expression.cs: Make sure fp comparisons work with NaN.
11354 This fixes bug #54303. Mig approved this patch a long
11355 time ago, but we were not able to test b/c the runtime
11358 2004-03-19 Miguel de Icaza <miguel@ximian.com>
11360 * ecore.cs (TypExpr.GetHashCode): implement this overload.
11362 2004-03-19 Martin Baulig <martin@ximian.com>
11364 * class.cs (MemberCore.IsDuplicateImplementation): Check whether
11365 two overloads may unify for some type parameter substitutions and
11366 report a CS0408 if appropriate.
11368 2004-03-19 Martin Baulig <martin@ximian.com>
11370 * class.cs (MemberCore.IsDuplicateImplementation): Report the
11371 error here and not in our caller.
11373 2004-03-19 Martin Baulig <martin@ximian.com>
11375 * interface.cs: Completely killed this file.
11376 (Interface): We're now a TypeContainer and live in class.cs.
11378 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
11379 argument; we're now also called for interfaces.
11380 (TypeContainer.DefineMembers): Allow this method being called
11382 (TypeContainer.GetMethods): New public method; formerly known as
11383 Interface.GetMethod(). This is used by PendingImplementation.
11384 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
11385 it's now private and non-static.
11386 (Interface): Moved this here; it's now implemented similar to
11388 (Method, Property, Event, Indexer): Added `bool is_interface'
11389 argument to their .ctor's.
11390 (MemberBase.IsInterface): New public field.
11392 * cs-parser.jay: Create normal Method, Property, Event, Indexer
11393 instances instead of InterfaceMethod, InterfaceProperty, etc.
11394 (opt_interface_base): Removed; we now use `opt_class_base' instead.
11395 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
11397 2004-03-19 Martin Baulig <martin@ximian.com>
11399 * class.cs (MethodCore.IsDuplicateImplementation): New private
11400 method which does the CS0111 checking.
11401 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
11402 Use IsDuplicateImplementation().
11404 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
11406 * decl.cs (FindMemberToOverride): New method to find the correct
11407 method or property to override in the base class.
11409 - Make Method/Property use the above method to find the
11410 version in the base class.
11411 - Remove the InheritableMemberSignatureCompare as it is now
11414 This patch makes large code bases much faster to compile, as it is
11415 O(n) rather than O(n^2) to do this validation.
11417 Also, it fixes bug 52458 which is that nested classes are not
11418 taken into account when finding the base class member.
11420 Reviewed/Approved by Martin.
11422 2004-03-17 Martin Baulig <martin@ximian.com>
11424 * expression.cs (MemberAccess.DoResolve): Take the parent's number
11425 of type arguments into account; use the `real_num_type_args'
11426 approach like in DoResolveAsTypeStep().
11428 * generic.cs (GenericMemberAccess.DoResolve): Make this work for
11431 2004-03-17 Marek Safar <marek.safar@seznam.cz>
11433 * interface.cs: In all interface classes removed redundant
11434 member initialization.
11436 2004-03-16 Martin Baulig <martin@ximian.com>
11438 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
11440 2004-03-15 Miguel de Icaza <miguel@ximian.com>
11442 * decl.cs (DefineTypeAndParents): New helper method to define a
11443 type's containers before the type itself is defined; This is a
11444 bug exposed by the recent changes to Windows.Forms when an
11445 implemented interface was defined inside a class that had not been
11448 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
11450 (Check): Loop correctly to report errors modifiers
11451 (UNSAFE was not in the loop, since it was the same as TOP).
11453 * interface.cs: Every interface member now takes a ModFlags,
11454 instead of a "is_new" bool, which we set on the base MemberCore.
11456 Every place where we called "UnsafeOk" in the interface, now we
11457 call the proper member (InterfaceMethod.UnsafeOK) instead to get
11458 the unsafe settings from the member declaration instead of the
11459 container interface.
11461 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
11463 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
11464 `set_indexer_name' to the pending bits (one per type).
11466 We fixed a bug today that was picking the wrong method to
11467 override, since for properties the existing InterfaceMethod code
11468 basically ignored the method name. Now we make sure that the
11469 method name is one of the valid indexer names.
11471 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
11473 * support.cs (SeekableStreamReader): Keep track of stream byte
11474 positions and don't mix them with character offsets to the buffer.
11476 Patch from Gustavo Giráldez
11478 2004-03-15 Marek Safar <marek.safar@seznam.cz>
11480 * interface.cs (InterfaceSetGetBase): Removed double member
11481 initialization, base class does it as well.
11483 2004-03-13 Martin Baulig <martin@ximian.com>
11485 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
11486 when compiling corlib.
11488 2004-03-13 Miguel de Icaza <miguel@ximian.com>
11490 * convert.cs (ExplicitConversion): We were reporting an error on
11491 certain conversions (object_type source to a value type, when the
11492 expression was `null') before we had a chance to pass it through
11493 the user defined conversions.
11495 * driver.cs: Replace / and \ in resource specifications to dots.
11498 * class.cs: Add check for duplicate operators. Fixes 52477
11500 2004-03-11 Miguel de Icaza <miguel@ximian.com>
11502 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
11503 that are in the middle of the statements, not only at the end.
11506 * class.cs (TypeContainer.AddField): No longer set the
11507 `HaveStaticConstructor' flag, now we call it
11508 `UserDefineStaticConstructor' to diferentiate the slightly
11509 semantic difference.
11511 The situation is that we were not adding BeforeFieldInit (from
11512 Modifiers.TypeAttr) to classes that could have it.
11513 BeforeFieldInit should be set to classes that have no static
11518 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
11520 And most importantly Zoltan's comment:
11522 http://bugzilla.ximian.com/show_bug.cgi?id=44229
11524 "I think beforefieldinit means 'it's ok to initialize the type sometime
11525 before its static fields are used', i.e. initialization does not need
11526 to be triggered by the first access to the type. Setting this flag
11527 helps the JIT to compile better code, since it can run the static
11528 constructor at JIT time, and does not need to generate code to call it
11529 (possibly lots of times) at runtime. Unfortunately, mcs does not set
11530 this flag for lots of classes like String.
11532 csc sets this flag if the type does not have an explicit static
11533 constructor. The reasoning seems to be that if there are only static
11534 initalizers for a type, and no static constructor, then the programmer
11535 does not care when this initialization happens, so beforefieldinit
11538 This bug prevents the AOT compiler from being usable, since it
11539 generates so many calls to mono_runtime_class_init that the AOT code
11540 is much slower than the JITted code. The JITted code is faster,
11541 because it does not generate these calls if the vtable is type is
11542 already initialized, which is true in the majority of cases. But the
11543 AOT compiler can't do this."
11545 2004-03-10 Miguel de Icaza <miguel@ximian.com>
11547 * class.cs (MethodData.Emit): Refactor the code so symbolic
11548 information is generated for destructors; For some reasons we
11549 were taking a code path that did not generate symbolic information
11552 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
11554 * class.cs: Create a Constructor.CheckBase method that
11555 takes care of all validation type code. The method
11556 contains some code that was moved from Define.
11558 It also includes new code that checks for duplicate ctors.
11559 This fixes bug #55148.
11561 2004-03-09 Joshua Tauberer <tauberer@for.net>
11563 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
11564 a { ... }-style array creation invokes EmitStaticInitializers
11565 which is not good for reference-type arrays. String, decimal
11566 and now null constants (NullCast) are not counted toward
11567 static initializers.
11569 2004-03-05 Martin Baulig <martin@ximian.com>
11571 * location.cs (SourceFile.HasLineDirective): New public field;
11572 specifies whether the file contains or is referenced by a "#line"
11574 (Location.DefineSymbolDocuments): Ignore source files which
11575 either contain or are referenced by a "#line" directive.
11577 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
11579 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
11580 direct access to our parent, so check the method inline there.
11582 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
11584 * expression.cs (Invocation.EmitCall): Miguel's last commit
11585 caused a regression. If you had:
11590 In Foo the implict this would be null.
11592 2004-02-27 Miguel de Icaza <miguel@ximian.com>
11594 * expression.cs (Invocation.EmitCall): If the method is not
11595 virtual, do not emit a CallVirt to it, use Call.
11597 * typemanager.cs (GetFullNameSignature): Improve the method to
11598 cope with ".ctor" and replace it with the type name.
11600 * class.cs (ConstructorInitializer.Resolve): Now the method takes
11601 as an argument the ConstructorBuilder where it is being defined,
11602 to catch the recursive constructor invocations.
11604 2004-03-16 Martin Baulig <martin@ximian.com>
11606 * expression.cs (MemberAccess.DoResolve): If `expr' resolved to a
11607 ConstructedType, call ResolveType() on it to get the type rather
11608 than just using `expr.Type'.
11610 2004-03-16 Martin Baulig <martin@ximian.com>
11612 * generics.cs (ConstructedType.GetMemberAccess): Take the
11613 EmitContext instead on the TypeExpr and use
11614 ec.TypeContainer.CurrentType/ec.ContainerType.
11616 2004-03-16 Martin Baulig <martin@ximian.com>
11618 * ecore.cs (SimpleName.DoResolveAsTypeStep): Lookup type
11619 parameters before aliases.
11621 2004-03-16 Martin Baulig <martin@ximian.com>
11623 * typemanager.cs (TypeManager.MayBecomeEqualGenericInstances):
11624 New oublic function; checks whether two generic instances may become
11625 equal under some instantiations (26.3.1).
11627 * class.cs (TypeContainer.Define): Call
11628 TypeManager.MayBecomeEqualGenericInstances() and report CS0695 on
11631 2004-03-16 Martin Baulig <martin@ximian.com>
11633 * class.cs (TypeContainer.GetClassBases): Moved
11634 Error_TypeParameterAsBase() here and also check whether the base
11635 class is not an attribute.
11637 2004-03-16 Martin Baulig <martin@ximian.com>
11639 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
11641 2004-03-16 Martin Baulig <martin@ximian.com>
11643 * class.cs (Error_TypeParameterAsBase): Use correct error number
11646 2004-03-16 Martin Baulig <martin@ximian.com>
11648 * decl.cs (DeclSpace.ResolveTypeExpr): Added more error checking
11651 * generics.cs (ConstructedType.DoResolveAsTypeStep): Added better
11654 2004-03-15 Martin Baulig <martin@ximian.com>
11656 * typemanager.cs (TypeManager.GetFullName): New public method.
11657 (TypeManager.MemberLookup): Added `int_num_type_arguments'
11658 argument; only return members with the correct number of type
11660 (TypeManager.CheckGeneric): Allow -1 to bypass the check.
11661 (TypeManager.FilterWithClosure): Call CheckGeneric() to check
11662 whether the number of type arguments matches.
11664 * generic.cs (GenericMemberAccess.ResolveAsTypeStep): Allow `expr'
11665 not being a ConstructedType; we can now do "typeof (Foo.Bar<U>)".
11667 * expression.cs (MemberAccess): Added public `NumTypeArguments'
11668 field; it's set by the protected .ctor when we're actually a
11669 GenericMemberAccess.
11670 (MemberAccess.ResolveAsTypeStep): Compute the total number of type
11671 arguments and pass it to MemberLookupFinal ().
11673 * ecore.cs (Expression.MemberLookup): Added `int
11674 num_type_arguments' argument; only return members with the correct
11675 number of type arguments.
11676 (Expression.MemberLookupFailed): Check whether the MemberLookup
11677 failed because we did not have the correct number of type
11678 arguments; report CS0305 in this case.
11680 * decl.cs (DeclSpace.ResolveTypeExpr): Don't report an error if
11681 `e.ResolveAsTypeTerminal()' already did so.
11683 2004-03-15 Martin Baulig <martin@ximian.com>
11685 * ecore.cs (Expression.ResolveLValue): Allow e.type being null if
11686 we're a ConstructedType; in this case, the caller must report an
11687 error (for instance CS0131).
11689 * generic.cs (TypeArguments): Added Location argument to the .ctor.
11690 (TypeArguments.Resolve): Actually report errors here.
11692 2004-03-15 Miguel de Icaza <miguel@ximian.com>
11694 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
11695 `set_indexer_name' to the pending bits (one per type).
11697 We fixed a bug today that was picking the wrong method to
11698 override, since for properties the existing InterfaceMethod code
11699 basically ignored the method name. Now we make sure that the
11700 method name is one of the valid indexer names.
11702 2004-03-15 Martin Baulig <martin@ximian.com>
11704 * typemanager.cs (TypeManager.IndexerPropertyName): Added support
11705 for generic instances.
11707 2004-03-13 Martin Baulig <martin@ximian.com>
11709 * class.cs (TypeContainer.DefineType): Call
11710 TypeManager.AddUserType() immediately after creating the
11711 TypeBuilder; pass all type parameters when creating the
11714 * decl.cs (DeclSpace.FindNestedType): New public method.
11715 (DeclSpace.FindType): Added `int num_type_args' argument; only
11716 return types with the correct number of type parameters.
11717 (DeclSpace.CountTypeParams): New public property.
11719 * ecore.cs (SimpleName.ctor): Added overloaded version which takes
11720 the number of type parameters; defaults to zero.
11722 * generic.cs (TypeArguments.Count): New public property.
11723 (ConstructedType.DoResolveAsTypeStep): First call
11724 ds.FindNestedType() to find out whether we're nested in the
11725 current generic type; in this case, we inherit all type parameters
11726 from the current class.
11728 * rootcontext.cs (RootContext.NamespaceLookup): Added `int
11729 num_type_args' argument.
11730 (RootContext.LookupType): Added overloaded version which takes the
11731 number of type arguments; only return types with the correct
11732 number of type arguments.
11734 * typemanager.cs (TypeManager.CheckGeneric): New public function;
11735 checks whether `Type t' has `int num_type_args'.
11737 2004-03-13 Martin Baulig <martin@ximian.com>
11739 * generic.cs (GenericMethod.DefineType): New method; calls
11740 DefineType() on all the type parameters.
11742 * class.cs (MethodData.ctor): Added `GenericMethod generic' argument.
11743 (MethodData.Define): If we're a generic method, call
11744 GenericMethod.DefineType() to define the type parameters.
11746 2004-03-10 Martin Baulig <martin@ximian.com>
11748 * pending.cs (Pending.InterfaceMethod): Use TypeManager.IsEqual()
11749 instead of IsAssignableFrom.
11751 2004-03-10 Martin Baulig <martin@ximian.com>
11753 * ecore.cs (FieldExpr.ctor): Use TypeManager.TypeToCoreType().
11755 * support.cs (ParameterData.HasArrayParameter): New property.
11756 (ReflectionParameters.ctor): Take a MethodBase instead of a
11757 ParameterInfo[]. If we have any type parameters, get the generic
11758 method definition and ask it whether we have variable arguments.
11760 2004-02-26 Miguel de Icaza <miguel@ximian.com>
11762 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
11763 routines to check if a type is an enumerable/enumerator allow
11764 classes that implement the IEnumerable or IEnumerator interfaces.
11766 * class.cs (Property, Operator): Implement IIteratorContainer, and
11767 implement SetYields.
11769 (Property.Define): Do the block swapping for get_methods in the
11770 context of iterators. We need to check if Properties also
11771 include indexers or not.
11773 (Operator): Assign the Block before invoking the
11774 OperatorMethod.Define, so we can trigger the Iterator code
11777 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
11778 Property and Operator classes are not created when we parse the
11779 declarator but until we have the block completed, so we use a
11780 singleton SimpleIteratorContainer.Simple to flag whether the
11781 SetYields has been invoked.
11783 We propagate this setting then to the Property or the Operator to
11784 allow the `yield' to function.
11786 2004-02-25 Marek Safar <marek.safar@seznam.cz>
11788 * codegen.cs: Implemented attribute support for modules.
11789 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
11790 Assembly/Module functionality.
11792 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
11793 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
11794 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
11796 2004-02-16 Marek Safar <marek.safar@seznam.cz>
11798 * interface.cs (FindMembers): The operation is performed on all base
11799 interfaces and not only on the first. It is required for future CLS Compliance patch.
11801 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
11803 * statement.cs, codegen.cs:
11804 This patch deals with patterns such as:
11806 public class List : IEnumerable {
11808 public MyEnumerator GetEnumerator () {
11809 return new MyEnumerator(this);
11812 IEnumerator IEnumerable.GetEnumerator () {
11816 public struct MyEnumerator : IEnumerator {
11821 Before, there were a few things we did wrong:
11822 1) we would emit callvirt on a struct, which is illegal
11823 2) we emited ldarg when we needed to emit ldarga
11824 3) we would mistakenly call the interface methods on an enumerator
11825 type that derived from IEnumerator and was in another assembly. For example:
11827 public class MyEnumerator : IEnumerator
11829 Would have the interface methods called, even if there were public impls of the
11830 method. In a struct, this lead to invalid IL code.
11832 2004-02-11 Marek Safar <marek.safar@seznam.cz>
11834 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
11837 * delegate.cs (Define): Fixed crash when delegate type is undefined.
11839 2004-02-11 Miguel de Icaza <miguel@ximian.com>
11841 * cs-parser.jay: Fix small regression: we were not testing V2
11842 compiler features correctly.
11844 * interface.cs: If the emit context is null, then create one
11846 2004-02-09 Marek Safar <marek.safar@seznam.cz>
11848 * decl.cs (GetSignatureForError): New virtual method to get full name
11849 for error messages.
11851 * attribute.cs (IAttributeSupport): New interface for attribute setting.
11852 Now it is possible to rewrite ApplyAttributes method to be less if/else.
11854 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
11855 Duplicated members and code in these classes has been removed.
11856 Better encapsulation in these classes.
11858 2004-02-07 Miguel de Icaza <miguel@ximian.com>
11860 * assign.cs (Assign.DoResolve): When dealing with compound
11861 assignments, there is a new rule in ECMA C# 2.4 (might have been
11862 there before, but it is documented here) that states that in:
11866 If b is of type int, and the `op' is a shift-operator, then the
11867 above is evaluated as:
11871 * expression.cs (Binary.ResolveOperator): Instead of testing for
11872 int/uint/long/ulong, try to implicitly convert to any of those
11873 types and use that in pointer arithmetic.
11875 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
11876 method to print information for from the type, not from the
11877 null-method we were given.
11879 2004-02-01 Duncan Mak <duncan@ximian.com>
11881 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
11882 parsing for cmd, fixes bug #53694.
11884 2004-02-04 Marek Safar <marek.safar@seznam.cz>
11886 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
11887 in the member name duplication tests. Property and operator name duplication
11888 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
11890 2004-02-03 Marek Safar <marek.safar@seznam.cz>
11892 * interface.cs (PopulateMethod): Fixed crash when interface method
11893 returns not existing type (error test cs0246-3.cs).
11895 2004-02-02 Ravi Pratap M <ravi@ximian.com>
11897 * cs-parser.jay (interface_accessors): Re-write actions to also
11898 store attributes attached to get and set methods. Fix spelling
11901 (inteface_property_declaration): Modify accordingly.
11903 (InterfaceAccessorInfo): New helper class to store information to pass
11904 around between rules that use interface_accessors.
11906 * interface.cs (Emit): Apply attributes on the get and set
11907 accessors of properties and indexers too.
11909 * attribute.cs (ApplyAttributes): Modify accordingly to use the
11910 right MethodBuilder when applying attributes to the get and set accessors.
11912 2004-01-31 Miguel de Icaza <miguel@ximian.com>
11914 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
11916 2004-01-26 Miguel de Icaza <miguel@ximian.com>
11918 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
11920 2004-01-25 Miguel de Icaza <miguel@ximian.com>
11922 * cs-parser.jay: Remove YIELD token, instead use the new grammar
11923 changes that treat `yield' specially when present before `break'
11924 or `return' tokens.
11926 * cs-tokenizer.cs: yield is no longer a keyword.
11928 2004-01-23 Marek Safar <marek.safar@seznam.cz>
11930 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
11931 setting for default constructors.
11932 For default constructors are almost every time set wrong Modifier. The
11933 generated IL code has been alright. But inside mcs this values was
11934 wrong and this was reason why several of my CLS Compliance tests
11937 2004-02-27 Martin Baulig <martin@ximian.com>
11939 * generics.cs (ConstructedType.ResolveType): Make the nested type
11940 stuff actually work.
11942 2004-02-25 Martin Baulig <martin@ximian.com>
11944 * decl.cs (DeclSpace.CurrentTypeParameters): New protected
11945 property; returns the type parameters just from the current type,
11946 ie. with the ones from outer classes.
11947 (DeclSpace.LookupGeneric): First search in the current class, then
11949 (DeclSpace.initialize_type_params): When hiding a type parameter
11950 from an outer class, put it into the `type_param_list' anyways.
11952 * expression.cs (MemberAccess.expr): Made this field protected.
11954 * class.cs (TypeContainer.Define): The `CurrentType' just contains
11955 the type parameters from the current class.
11957 * generic.cs (ConstructedType.ResolveType): Support nested generic
11958 types by taking the type parameters which we inherit from outer
11959 classes into account.
11960 (GenericMemberAccess.ResolveAsTypeStep): Override this and added
11961 support for nested generic types.
11963 2004-02-23 Martin Baulig <martin@ximian.com>
11965 * decl.cs (DeclSpace.IsGeneric): Make this a property instead of a
11966 field and check whether we're nested inside a generic type.
11967 (DeclSpace.ResolveType): If we're resolving to a generic type
11968 definition, create a ConstructedType and return its resolved type.
11969 (DeclSpace.initialize_type_params): New private method;
11970 initializes the `type_param_list' field from the type parameters
11971 from this and all enclosing classes.
11972 (DeclSpace.TypeParameters): Call initialize_type_params() unless
11973 we're already initialized.
11975 2004-02-23 Martin Baulig <martin@ximian.com>
11977 * class.cs (Method.Define): Create the generic method before
11978 calling DoDefine().
11979 (Memberbase.DoDefine): Added DeclSpace argument (in addition to
11980 the TypeContainer one); we use this for generic methods.
11982 * decl.cs (CheckAccessLevel): If we're a GenericMethod, use our
11983 parent's TypeBuilder.
11985 2004-02-18 Martin Baulig <martin@ximian.com>
11987 * ecore.cs (FieldExpr.DoResolveLValue): Use TypeManager.IsEqual()
11988 to check for equality.
11990 2004-02-05 Martin Baulig <martin@ximian.com>
11992 * ecore.cs (FieldExpr.DoResolveLValue): If we have an
11993 `ec.TypeContainer.CurrentType', use it instead of
11994 `ec.ContainerType' to check whether we're in the type's ctor.
11996 2004-01-29 Martin Baulig <martin@ximian.com>
11998 * expression.cs (Invocation.DoResolve): If we're a
11999 `ConstructedType', then we're actually a generic method, so
12000 rewrite the expr as a GenericMemberAccess.
12002 * cs-parser.jay (member_name): Don't use `namespace_or_type_name'
12003 here; manually parse it into a string.
12005 2004-01-28 Martin Baulig <martin@ximian.com>
12007 * typemanager.cs (TypeManager.IsEqual): New static method.
12008 (TypeManager.FilterWithClosure): Call TypeManager.IsEqual() to
12009 check for equality instead of using `=='.
12011 2004-01-26 Martin Baulig <martin@ximian.com>
12013 * decl.cs (DeclSpace.CurrentType): New public field.
12015 * expression.cs (This.ResolveBase): If we have an
12016 `ec.TypeContainer.CurrentType', use it instead of
12017 `ec.ContainerType'.
12019 * class.cs (TypeContainer.DefineType): If we're a generic type,
12020 create the `CurrentType' (unresolved).
12021 (TypeContainer.GenericType): New private field.
12022 (TypeContainer.DefineMembers): If we have a `CurrentType', resolve
12023 it and store it in `GenericType' before creating the MemberCache.
12024 (TypeContainer.GetMembers): If we have a `GenericType', call
12025 TypeManager.FindMembers() on it.
12027 * interface.cs (Interface.GenericType): New private field.
12028 (Interface.DefineType): If we're a generic type, create the
12029 `CurrentType' (unresolved).
12030 (Interface.DefineMembers): If we have a `CurrentType', resolve it
12031 and store it in `GenericType' before creating the MemberCache.
12032 (Interface.GetMembers): If we have a `GenericType', call
12033 TypeManager.FindMembers() on it.
12035 2004-01-22 Martin Baulig <martin@ximian.com>
12037 * cs-parser.jay (namespace_or_type_name): Return an Expression,
12038 not a QualifiedIdentifier. This is what `type_name_expression'
12039 was previously doing.
12040 (type_name_expression): Removed; the code is now in
12041 `namespace_or_type_name'.
12042 (qualified_identifier): Removed, use `namespace_or_type_name'
12044 (QualifiedIdentifier): Removed this class.
12046 2004-01-22 Martin Baulig <martin@ximian.com>
12048 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
12049 not a string as alias name.
12051 2004-01-21 Miguel de Icaza <miguel@ximian.com>
12053 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
12054 #52730 bug, and instead compute correctly the need to use a
12055 temporary variable when requesting an address based on the
12056 static/instace modified of the field and the constructor.
12058 2004-01-21 Martin Baulig <martin@ximian.com>
12060 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
12061 class and namespace before looking up aliases. Fixes #52517.
12063 2004-01-21 Martin Baulig <martin@ximian.com>
12065 * flowanalysis.cs (UsageVector.Merge): Allow variables being
12066 assinged in a 'try'; fixes exception4.cs.
12068 2004-01-21 Marek Safar <marek.safar@seznam.cz>
12069 * class.cs : Implemented parameter-less constructor for TypeContainer
12071 * decl.cs: Attributes are now stored here. New property OptAttributes
12073 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
12075 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
12077 2004-01-21 Marek Safar <marek.safar@seznam.cz>
12079 * typemanager.cs (CSharpSignature): Now reports also inner class name.
12080 (CSharpSignature): New method for indexer and property signature.
12082 2004-01-21 Marek Safar <marek.safar@seznam.cz>
12084 * pending.cs (IsVirtualFilter): Faster implementation.
12086 2004-01-21 Marek Safar <marek.safar@seznam.cz>
12088 * typemanager.cs: Avoid inclusion of same assembly more than once.
12090 2004-01-21 Marek Safar <marek.safar@seznam.cz>
12092 * cs-parser.jay: Fixed problem where the last assembly attribute
12093 has been applied also to following declaration (class, struct, etc.)
12095 2004-01-21 Marek Safar <marek.safar@seznam.cz>
12097 * class.cs: Added error CS0538, CS0539 reporting.
12098 Fixed crash on Microsoft runtime when field type is void.
12100 * cs-parser.jay: Added error CS0537 reporting.
12102 * pending.cs: Added error CS0535 reporting.
12103 Improved error report for errors CS0536, CS0534.
12105 2004-01-20 Miguel de Icaza <miguel@ximian.com>
12107 Merge a few bits from the Anonymous Method MCS tree.
12109 * statement.cs (ToplevelBlock): New class for toplevel methods,
12110 will hold anonymous methods, lifted variables.
12112 * cs-parser.jay: Create toplevel blocks for delegates and for
12113 regular blocks of code.
12115 2004-01-20 Martin Baulig <martin@ximian.com>
12117 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
12118 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
12119 and `NeedExplicitReturn'; added `IsLastStatement'.
12120 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
12121 have a `ReturnLabel' or we're not unreachable.
12123 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
12124 child's reachability; don't just override ours with it. Fixes
12125 #58058 (lluis's example).
12126 (FlowBranching): Added public InTryOrCatch(), InCatch(),
12127 InFinally(), InLoop(), InSwitch() and
12128 BreakCrossesTryCatchBoundary() methods.
12130 * statement.cs (Return): Do all error checking in Resolve().
12131 Unless we are the last statement in a top-level block, always
12132 create a return label and jump to it.
12133 (Break, Continue): Do all error checking in Resolve(); also make
12134 sure we aren't leaving a `finally'.
12135 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
12136 statement in a top-level block.
12137 (Block.Flags): Added `IsDestructor'.
12138 (Block.IsDestructor): New public property.
12140 2004-01-20 Martin Baulig <martin@ximian.com>
12142 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
12144 2004-01-20 Martin Baulig <martin@ximian.com>
12146 * statement.cs (Statement.ResolveUnreachable): New public method.
12147 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
12148 (Block.Resolve): Resolve unreachable statements.
12150 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
12152 * expression.cs: We need to fix the case where we do
12153 not have a temp variable here.
12155 * assign.cs: Only expression compound assignments need
12156 temporary variables.
12158 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
12160 * flowanalysis.cs: Reduce memory allocation in a few ways:
12161 - A block with no variables should not allocate a bit
12163 - A method with no out parameters does not need any tracking
12164 for assignment of the parameters, so we need not allocate
12167 public readonly Type[] VariableTypes;
12168 public readonly string[] VariableNames;
12169 Are redundant. The data is already stored in the variable
12170 map, so we need not allocate another array for it.
12171 - We need to add alot of checks for if (params | locals) == null
12172 due to the first two changes.
12174 2004-01-18 Miguel de Icaza <miguel@ximian.com>
12176 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
12177 implement IMemoryLocation, we store a copy on a local variable and
12178 take the address of it. Patch from Benjamin Jemlich
12180 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
12181 to use a special "type_name_expression" rule which reduces the
12182 number of "QualifiedIdentifier" classes created, and instead
12183 directly creates MemberAccess expressions.
12185 2004-01-17 Miguel de Icaza <miguel@ximian.com>
12187 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
12188 that fixes #52853. Null literal assignment to ValueType
12190 * class.cs (MethodData.Emit): Instead of checking the name of the
12191 method to determine if its a destructor, create a new derived
12192 class from Method called Destructor, and test for that.
12194 * cs-parser.jay: Create a Destructor object instead of a Method.
12196 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
12200 2004-01-16 Miguel de Icaza <miguel@ximian.com>
12202 * expression.cs (Binary.ResolveOperator): Perform an implicit
12203 conversion from MethodGroups to their delegate types on the
12204 Addition operation.
12206 * delegate.cs: Introduce a new class DelegateCreation that is the
12207 base class for `NewDelegate' and `ImplicitDelegateCreation',
12208 factor some code in here.
12210 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
12211 conversion from MethodGroups to compatible delegate types.
12213 * ecore.cs (Expression.Resolve): Do not flag error 654
12214 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
12215 we allow conversions from MethodGroups to delegate types now.
12217 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
12218 assignments in v2 either.
12220 2004-01-10 Miguel de Icaza <miguel@ximian.com>
12222 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
12223 static read-only fields in ctors.
12225 Applied patch from Benjamin Jemlich
12227 * expression.cs (UnaryMutator): Avoid leaking local variables.
12229 2004-01-09 Miguel de Icaza <miguel@ximian.com>
12231 * cs-tokenizer.cs (IsCastToken): Allow the various native types
12232 here to return true, as they can be used like this:
12234 (XXX) int.MEMBER ()
12236 Fixed 49836 and all the other dups
12238 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
12240 * driver.cs: Implement /win32res and /win32icon.
12242 2004-01-08 Miguel de Icaza <miguel@ximian.com>
12244 * cs-parser.jay: Add a rule to improve error handling for the
12245 common mistake of placing modifiers after the type.
12247 2004-01-07 Miguel de Icaza <miguel@ximian.com>
12249 * cs-parser.jay (interface_event_declaration): Catch
12250 initialization of events on interfaces, and report cs0068
12252 * cs-parser.jay (interface_event_declaration): Catch
12253 initialization of events.
12255 * ecore.cs: Better report missing constructors.
12257 * expression.cs (Binary.ResolveOperator): My previous bug fix had
12258 the error reporting done in the wrong place. Fix.
12260 * expression.cs (Binary.ResolveOperator): Catch the
12261 operator + (E x, E y) error earlier, and later allow for implicit
12262 conversions in operator +/- (E e, U x) from U to the underlying
12265 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
12266 52596, if the container class is abstract, the default constructor
12267 is protected otherwise its public (before, we were always public).
12269 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
12272 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
12273 Jemlich that fixes bug #52597, MCS was generating invalid code for
12274 idisposable structs. Thanks to Ben for following up with this
12277 2004-01-06 Miguel de Icaza <miguel@ximian.com>
12279 * driver.cs: Allow assemblies without code to be generated, fixes
12282 2004-01-07 Nick Drochak <ndrochak@gol.com>
12284 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
12286 2004-01-05 Miguel de Icaza <miguel@ximian.com>
12288 * cs-parser.jay: Add rules to improve error reporting if fields or
12289 methods are declared at the namespace level (error 116)
12291 * Add rules to catch event add/remove
12293 2004-01-04 David Sheldon <dave-mono@earth.li>
12295 * expression.cs: Added matching ")" to error message for
12298 2004-01-03 Todd Berman <tberman@gentoo.org>
12300 * ecore.cs, attribute.cs:
12301 Applying fix from #52429.
12303 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
12305 * ecore.cs, expression.cs, statement.cs:
12306 Total rewrite of how we handle branching. We
12307 now handle complex boolean expressions with fewer
12308 jumps. As well if (x == 0) no longer emits a ceq.
12310 if (x is Foo) is much faster now, because we generate
12313 Overall, we get a pretty big improvement on our benchmark
12314 tests. The code we generate is smaller and more readable.
12316 I did a full two-stage bootstrap. The patch was reviewed
12317 by Martin and Miguel.
12319 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
12321 * cs-parser.jay: Make primary_expression not take a QI.
12322 we dont need this because the member_access rule covers
12323 us here. So we replace the rule with just IDENTIFIER.
12325 This has two good effects. First, we remove a s/r conflict.
12326 Second, we allocate many fewer QualifiedIdentifier objects.
12328 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
12330 * attribute.cs: Handle MarshalAs attributes as pseudo, and
12331 set the correct information via SRE. This prevents
12332 hanging on the MS runtime. Fixes #29374.
12334 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
12336 * convert.cs: correctly handle conversions to value types
12337 from Enum and ValueType as unboxing conversions.
12339 Fixes bug #52569. Patch by Benjamin Jemlich.
12341 2004-01-02 Ravi Pratap <ravi@ximian.com>
12343 * expression.cs (BetterConversion): Prefer int -> uint
12344 over int -> ulong (csc's behaviour). This fixed bug #52046.
12346 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
12348 * decl.cs (MemberCache.FindMembers): now returns a
12351 * typemanager.cs: In general, go with with ^^.
12352 (CopyNewMethods): take an IList.
12353 (RealMemberLookup): Only allocate an arraylist
12354 if we copy from two sets of methods.
12356 This change basically does two things:
12357 1) Fewer array lists allocated due to CopyNewMethods.
12358 2) the explicit cast in MemberList costed ALOT.
12360 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
12362 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
12363 a hashtable to avoid needless string allocations when an identifier is
12364 used more than once (the common case).
12366 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
12368 * pending.cs: MS's TypeBuilder.GetInterfaces ()
12369 is broken, it will not return anything. So, we
12370 have to use the information we have in mcs to
12373 * typemanager.cs: Add a cache for GetInterfaces,
12374 since this will now be used more often (due to ^^)
12376 (GetExplicitInterfaces) New method that gets the
12377 declared, not effective, interfaces on a type
12378 builder (eg, if you have interface IFoo, interface
12379 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
12382 This patch makes MCS able to bootstrap itself on
12385 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
12387 * expression.cs: Remove the Nop's that Miguel put
12390 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
12392 * report.cs, codegen.cs: Give the real stack trace to
12393 the error when an exception is thrown.
12395 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
12397 * decl.cs: only allocate hashtables for ifaces if
12400 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
12402 * expression.cs: fix the error from cs0121-2.cs
12403 (a parent interface has two child interfaces that
12404 have a function with the same name and 0 params
12405 and the function is called through the parent).
12407 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
12409 * class.cs, rootcontext.cs, typmanager.cs: do not
12412 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
12414 * codegen.cs: remove stack for the ec flow branching.
12415 It is already a linked list, so no need.
12417 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
12419 * Makefile: Allow custom profiler here.
12421 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
12423 * typemanager.cs (LookupType):
12424 - Use a static char [], because split takes
12425 a param array for args, so it was allocating
12427 - Do not store true in a hashtable, it boxes.
12429 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
12431 * flowanalysis.cs: bytify common enums.
12433 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
12435 * modifiers.cs: Add a new set of flags for the
12436 flags allowed on explicit interface impls.
12437 * cs-parser.jay: catch the use of modifiers in
12438 interfaces correctly.
12439 * class.cs: catch private void IFoo.Blah ().
12441 All related to bug #50572.
12443 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
12445 * decl.cs: Rewrite the consistant accessability checking.
12446 Accessability is not linear, it must be implemented in
12447 a tableish way. Fixes #49704.
12449 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
12451 * expression.cs: Handle negation in a checked context.
12452 We must use subtraction from zero. Fixes #38674.
12454 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
12456 * class.cs: Ignore static void main in DLLs.
12457 * rootcontext.cs: Handle the target type here,
12458 since we are have to access it from class.cs
12459 * driver.cs: account for the above.
12461 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
12463 * report.cs: Give line numbers and files if available.
12465 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
12467 * driver.cs: Implement /addmodule.
12469 * typemanager.cs: Change 'modules' field so it now contains Modules not
12472 2003-12-20 Martin Baulig <martin@ximian.com>
12474 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
12475 (FieldBase.IsAssigned): Removed this field.
12476 (FieldBase.SetAssigned): New public method.
12477 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
12479 2003-12-20 Martin Baulig <martin@ximian.com>
12481 * expression.cs (LocalVariableReference.DoResolve): Don't set
12482 `vi.Used' if we're called from DoResolveLValue().
12484 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
12485 returns the usage vector it just merged into the current one -
12486 pass this one to UsageWarning().
12487 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
12488 of the `EmitContext', don't call this recursively on our children.
12490 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
12492 * driver.cs: Implement /target:module.
12494 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
12496 * support.cs (CharArrayHashtable): New helper class.
12498 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
12499 char arrays, not strings, so we can avoid creating a string in
12500 consume_identifier if the identifier is a keyword.
12502 2003-12-16 Martin Baulig <martin@ximian.com>
12504 * statement.cs (LocalInfo.Assigned): Removed this property.
12505 (LocalInfo.Flags): Removed `Assigned'.
12506 (LocalInfo.IsAssigned): New public method; takes the EmitContext
12507 and uses flow analysis.
12508 (Block.UsageWarning): Made this method private.
12509 (Block.Resolve): Call UsageWarning() if appropriate.
12511 * expression.cs (LocalVariableReference.DoResolve): Always set
12512 LocalInfo.Used here.
12514 2003-12-13 Martin Baulig <martin@ximian.com>
12516 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
12517 any value here; we're now using flow analysis to figure out
12518 whether a statement/block returns a value.
12520 2003-12-13 Martin Baulig <martin@ximian.com>
12522 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
12524 (FlowBranching.MergeFinally): Don't call
12525 `branching.CheckOutParameters()' here, this is called in
12527 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
12528 when adding the `finally' vector.
12530 2003-12-13 Martin Baulig <martin@ximian.com>
12533 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
12534 actually work and also fix #48962.
12536 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
12538 * decl.cs: Do not check System.Object for nested types,
12539 since we know it does not have any. Big bang for buck:
12542 Run 1: 8.35 seconds
12543 Run 2: 8.32 seconds
12544 corlib: 17.99 seconds
12546 Run 1: 8.17 seconds
12547 Run 2: 8.17 seconds
12548 corlib: 17.39 seconds
12550 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
12552 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
12553 time we are returning 0 members, so we save alot here.
12555 2003-12-11 Martin Baulig <martin@ximian.com>
12557 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
12558 `MergeChild()', also just take the `FlowBranching' as argument;
12559 call Merge() on it and return the result.
12560 (FlowBranching.Merge): We don't need to do anything if we just
12563 2003-12-11 Martin Baulig <martin@ximian.com>
12565 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
12566 them in an `ArrayList' to reduce memory usage. Thanks to Ben
12567 Maurer for this idea.
12569 2003-12-11 Martin Baulig <martin@ximian.com>
12571 * flowanalysis.cs (MergeResult): This class is now gone; we now
12572 use the `UsageVector' for this. The reason for this is that if a
12573 branching just has one sibling, we don't need to "merge" them at
12574 all - that's the next step to do.
12575 (FlowBranching.Merge): We now return a `UsageVector' instead of a
12578 2003-12-11 Martin Baulig <martin@ximian.com>
12580 Reworked flow analyis and made it more precise and bug-free. The
12581 most important change is that we're now using a special `Reachability'
12582 class instead of having "magic" meanings of `FlowReturns'. I'll
12583 do some more cleanups and optimizations and also add some more
12584 documentation this week.
12586 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
12587 largely reworked this class.
12588 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
12589 the new `Reachability' class instead of having "magic" values here.
12590 (FlowBranching): We're now using an instance of `Reachability'
12591 instead of having separate `Returns', `Breaks' etc. fields.
12593 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
12594 based on flow analysis; ignore the return value of block.Emit ().
12596 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
12598 * driver.cs typemanager.cs: Find the mono extensions to corlib even
12599 if they are private.
12601 2003-12-09 Martin Baulig <martin@ximian.com>
12603 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
12604 call them directly on the UsageVector.
12606 2003-12-09 Martin Baulig <martin@ximian.com>
12608 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
12609 Changed return type from `FlowReturns' to `Reachability'.
12611 2003-12-09 Martin Baulig <martin@ximian.com>
12613 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
12614 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
12615 `Reachable' fields with a single `Reachability' one.
12617 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
12619 * class.cs (FindMembers): Remove foreach's.
12624 Run 1: 8.74 seconds
12625 Run 2: 8.71 seconds
12628 Run 1: 8.64 seconds
12629 Run 2: 8.58 seconds
12632 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
12637 This patch does a few things:
12638 1. EmptyStatement is now a singleton, so it is never reallocated.
12639 2. All blah is EmptyStatement constructs have been changed to
12640 blah == EmptyStatement.Value, which is much faster and valid
12641 now that EmptyStatement is a singleton.
12642 3. When resolving a block, rather than allocating a new array for
12643 the non-empty statements, empty statements are replaced with
12644 EmptyStatement.Value
12645 4. Some recursive functions have been made non-recursive.
12646 Mainly the performance impact is from (3), however (1) and (2) are needed for
12647 this to work. (4) does not make a big difference in normal situations, however
12648 it makes the profile look saner.
12653 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
12654 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
12655 Total memory allocated: 56397 KB
12658 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
12659 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
12660 Total memory allocated: 55666 KB
12662 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
12664 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
12665 than the hashtable in a hashtable version
12667 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
12668 we always end up concating a string. This results in a huge perf
12669 loss, because many strings have to be tracked by the GC. In this
12670 patch, we first use a hashtable that works with two keys, so that
12671 the strings do not need to be concat'ed.
12675 Run 1: 8.74 seconds
12676 Run 2: 8.71 seconds
12679 Run 1: 8.65 seconds
12680 Run 2: 8.56 seconds
12682 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
12684 * Makefile: Add a new target `do-time' that does a quick and simple
12685 profile, leaving easy to parse output.
12687 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
12689 * codegen.cs (Init): Create the dynamic assembly with
12690 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
12692 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
12694 * support.cs: Make the PtrHashtable use only one
12695 instance of its comparer.
12697 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
12699 * typemanager.cs: Fix lookup of GetNamespaces.
12701 2003-11-29 Miguel de Icaza <miguel@ximian.com>
12703 * expression.cs: Removed redundant line.
12705 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
12706 ArrayLists, use for loops with bounds.
12708 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
12711 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
12712 arraylists, use for loop with bounds.
12714 The above three changes give us a 0.071 second performance
12715 improvement out of 3.294 seconds down to 3.223. On my machine
12716 the above changes reduced the memory usage by 1,387 KB during
12717 compiler bootstrap.
12719 * cs-parser.jay (QualifiedIdentifier): New class used to represent
12720 QualifiedIdentifiers. Before we created a new string through
12721 concatenation, and mostly later on, the result would be
12722 manipulated by DecomposeQI through string manipulation.
12724 This reduced the compiler memory usage for bootstrapping from
12725 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
12726 compile times in 0.05 seconds.
12728 2003-11-28 Dick Porter <dick@ximian.com>
12730 * support.cs: Do string compares with the Invariant culture.
12738 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
12739 the comparison is done with the Invariant culture.
12741 2003-11-27 Miguel de Icaza <miguel@ximian.com>
12743 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
12744 GetEnumerator method.
12746 (ProbeCollectionType): Iterate starting at the most specific type
12747 upwards looking for a GetEnumerator
12749 * expression.cs: Shift count can be up to 31 for int/uint and 63
12752 2003-11-26 Miguel de Icaza <miguel@ximian.com>
12754 * statement.cs (Block.LookupLabel): Also look for the label on the
12755 children blocks. Use a hash table to keep track of visited
12758 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
12759 we actually did transform the other operand, otherwise fall back
12760 to the common codepath that casts to long.
12762 * cs-tokenizer.cs: Use the same code pattern as the int case.
12763 Maybe I should do the parsing myself, and avoid depending on the
12764 Parse routines to get this done.
12766 2003-11-25 Miguel de Icaza <miguel@ximian.com>
12768 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
12769 which fixes bug 51347. This time test it.
12771 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
12772 attributes for example can not tell the difference between these.
12773 The difference was only a syntax feature of the language.
12775 * attribute.cs: Apply attributes to delegates.
12777 * delegate.cs: Call the apply attributes method.
12779 2003-11-24 Miguel de Icaza <miguel@ximian.com>
12781 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
12782 comparing 0 vs Byte.MinValue, not the value
12784 (ImplicitConversionRequired): When reporting a conversion error,
12785 use error 31 to print out the constant error instead of the
12788 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
12789 which fixes bug 51347.
12791 2003-11-22 Miguel de Icaza <miguel@ximian.com>
12793 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
12794 which fixes the -warnaserror command line option.
12796 2003-11-21 Miguel de Icaza <miguel@ximian.com>
12798 * cfold.cs (DoNumericPromotions): During constant folding of
12799 additions on UIntConstant, special case intconstants with
12800 IntConstants like we do on the expression binary operator.
12802 2003-11-12 Miguel de Icaza <miguel@ximian.com>
12804 * convert.cs (ImplicitReferenceConversion): We were missing a case
12805 (System.Enum are not value types or class types, so we need to
12806 classify them separatedly).
12808 * driver.cs: We do not support error 2007.
12810 2003-11-12 Jackson Harper <jackson@ximian.com>
12812 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
12813 system directory. Also use the full file name so users can
12814 libraries names mscorlib-o-tron.dll in a non system dir.
12816 2004-01-04 David Sheldon <dave-mono@earth.li>
12818 * expression.cs: Added matching ")" to error message for CS0077.
12820 2003-12-19 Martin Baulig <martin@ximian.com>
12822 * typemanager.cs (TypeManager.IsEqualGenericType): New public
12823 static method; see documentation in the method.
12824 (TypeManager.IsSubclassOrNestedChild): Allow IsEqualGenericType().
12826 * convert.cs (Convert.ImplicitReferenceConversion,
12827 Convert.ImplicitReferenceConversionExists): Add support for
12828 generic type declarations; see gen-36.cs.
12830 2003-12-19 Martin Baulig <martin@ximian.com>
12832 * pending.cs (Pending.InterfaceMethod): Use
12833 `Type.IsAssignableFrom()' instead of `=='.
12835 2003-12-18 Martin Baulig <martin@ximian.com>
12837 * decl.cs (DeclSpace.AsAccessible): Check for array, pointer and
12840 * convert.cs (Convert.ImplicitStandardConversionExists): Use
12841 `expr_type.Equals (target_type)' instead of `=='.
12843 2003-12-08 Martin Baulig <martin@ximian.com>
12845 * generics.cs (Constraints.Types): Removed.
12846 (Constraints.Resolve): Just resolve everything to TypeExpr's, not
12848 (Constraints.ResolveTypes): New public method; resolves the
12849 TypeExpr's to Type's.
12850 (TypeParameter.Define): TypeBuilder.DefineGenericParameter() no
12851 longer takes the constraints.
12852 (TypeParameter.DefineMethod): Likewise.
12853 (TypeParameter.DefineType): New public method. Calls
12854 `TypeBuilder/MethodBuilder.SetGenericParameterConstraints()' to set
12857 2003-12-08 Martin Baulig <martin@ximian.com>
12859 * convert.cs (Convert.ImplicitConversionStandard): Use
12860 `expr_type.Equals (target_type)' instead of `=='.
12862 2003-12-08 Martin Baulig <martin@ximian.com>
12864 * typemanager.cs (TypeManager.GetReferenceType): Call
12865 `Type.MakeByRefType ()'.
12867 2003-12-08 Martin Baulig <martin@ximian.com>
12869 * cs-parser.jay, cs-tokenizer.cs: `where' is not a keyword, it
12870 just has some special meaning in some situations. For instance,
12871 it is allowed to use `where' as the name of a variable etc.
12873 2003-12-04 Martin Baulig <martin@ximian.com>
12875 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
12876 `Type.MakeArrayType()' for array types.
12878 2003-11-18 Miguel de Icaza <miguel@ximian.com>
12880 * expression.cs (Invocation.VerifyArgumentsCompat): Remove
12883 (SizeOf.DoResolve): assign the `type_queried' field. This gets
12886 2003-11-16 Martin Baulig <martin@ximian.com>
12888 * codegen.cs (EmitContext.IsGeneric): Removed.
12890 * ecore.cs (SimpleName.ResolveAsTypeStep): Always call
12891 ResolveGeneric() on the DeclSpace.
12893 2003-11-16 Martin Baulig <martin@ximian.com>
12895 * generic.cs (TypeArguments.Resolve):
12896 `Expression.ResolveAsTypeTerminal()' returns a TypeExpr; call
12897 `ResolveType()' on it to get the Type.
12899 2003-11-15 Martin Baulig <martin@ximian.com>
12901 * generic.cs (ConstructedType.GetInterfaces): Override this.
12903 2003-11-14 Martin Baulig <martin@ximian.com>
12905 * interface.cs (Interface.DefineType): Define all type parameters
12906 before adding the interfaces we inherit.
12908 2003-11-11 Martin Baulig <martin@ximian.com>
12910 * generic.cs (ConstructedType.ResolveType): Always call
12911 `gt.BindGenericParameters (atypes)'; also if `args.HasTypeArguments'.
12913 2003-11-10 Martin Baulig <martin@ximian.com>
12915 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
12916 (TypeManager.InitCoreTypes): Initialize them here, but instead of
12917 calling `ResolveType()' on them, directly assign their `Type'.
12919 2003-11-08 Martin Baulig <martin@ximian.com>
12921 * generic.cs (ConstructedType): Override `IsClass' etc.
12923 2003-11-08 Martin Baulig <martin@ximian.com>
12925 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
12926 return value and the `out parent' parameter.
12927 (TypeContainer.DefineType): Moved the CS0644 check into
12928 GetClassBases(). Don't pass the interface types to the
12929 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
12930 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
12932 * ecore.cs (TypeExpr.IsAttribute): New property.
12933 (TypeExpr.GetInterfaces): New method.
12935 * interface.cs (Interface.GetInterfaceTypeByName): Return a
12936 TypeExpr instead of a Type.
12937 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
12938 (Interface.DefineType): Don't pass the interface types to the
12939 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
12940 them later and then call `TypeBulider.AddInterfaceImplementation()'.
12942 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
12943 instead of a `Type[]'.
12944 (TypeManager.RegisterBuilder): Likewise.
12945 (TypeManager.AddUserInterface): Likewise.
12946 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
12947 `Type[]' and also return a `TypeExpr[]'.
12948 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
12950 2003-11-08 Martin Baulig <martin@ximian.com>
12952 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
12955 2003-11-08 Martin Baulig <martin@ximian.com>
12957 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
12958 TypeManager.ResolveExpressionTypes().
12960 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
12961 instead of an Expression.
12962 (TypeExpr): This is now an abstract base class for `TypeExpression'.
12963 (TypeExpression): New public class; formerly known as `TypeExpr'.
12965 * expression.cs (ComposedCast): Derive from TypeExpr.
12967 * typemanager.cs (TypeManager.system_*_expr): These are now
12968 TypExpr's instead of Expression's.
12969 (TypeManager.ResolveExpressionTypes): New public static function;
12970 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
12973 2003-11-06 Miguel de Icaza <miguel@ximian.com>
12975 * expression.cs (New.DoResolve): Do not dereference value that
12976 might be a null return.
12978 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
12979 sure that the constant value has the right type. Fixes an
12980 unreported bug, similar to 50425.
12982 * const.cs (Const.LookupConstantValue): Call
12983 ImplicitStandardConversionExists before doing a conversion to
12984 avoid havng the TypeManager.ChangeType do conversions.
12986 Reduced the number of casts used
12988 (Const.ChangeType): New routine to enable reuse of the constant
12989 type changing code from statement.
12991 * typemanager.cs (ChangeType): Move common initialization to
12992 static global variables.
12996 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
12997 every value type to go through, even if it was void. Fix that.
12999 * cs-tokenizer.cs: Use is_identifier_start_character on the start
13000 character of the define, and the is_identifier_part_character for
13001 the rest of the string.
13003 2003-11-05 Miguel de Icaza <miguel@ximian.com>
13005 * expression.cs (UnaryMutator.EmitCode): When I updated
13006 LocalVariableReference.DoResolve, I overdid it, and dropped an
13007 optimization done on local variable references.
13009 2003-11-04 Miguel de Icaza <miguel@ximian.com>
13011 * ecore.cs: Convert the return from Ldlen into an int.
13013 2003-10-20 Miguel de Icaza <miguel@ximian.com>
13015 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
13016 the accessibility, this is a special case for toplevel non-public
13017 classes (internal for instance).
13019 2003-10-20 Nick Drochak <ndrochak@gol.com>
13021 * ecore.cs: Fix typo and build. Needed another right paren.
13023 2003-10-19 Miguel de Icaza <miguel@ximian.com>
13025 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
13026 `internal' case regular and protected, but not allowing protected
13027 to be evaluated later. Bug 49840
13029 2003-10-15 Miguel de Icaza <miguel@ximian.com>
13031 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
13032 to kb.Nlast, and not the kb.nFirst to isolate the switch
13035 Extract the underlying type, so enumerations of long/ulong are
13036 treated like long/ulong.
13038 2003-10-14 Miguel de Icaza <miguel@ximian.com>
13040 * expression.cs (New): Overload the meaning of RequestedType to
13041 track the possible creation of the NewDelegate type, since
13042 DoResolve is invoked more than once for new constructors on field
13045 See bugs: #48800 and #37014
13047 * cs-parser.jay (declare_local_constants): Take an arraylist
13048 instead of a single constant.
13050 (local_constant_declaration): It should take a
13051 constant_declarators, not a constant_declarator. Fixes 49487
13053 * convert.cs: Fix error report.
13055 2003-10-13 Jackson Harper <jackson@ximian.com>
13057 * typemanager.cs (TypeToCoreType): Add float and double this fixes
13060 2003-11-03 Martin Baulig <martin@ximian.com>
13062 * expression.cs (ArrayAccess.GetStoreOpcode): Added
13063 `out bool has_type_arg'; if set, we need to pass the type to
13065 (ArrayAccess.GetStoreOpcode, ArrayAccess.EmitLoadOpcode): Use
13066 Stelem_Any/Ldelem_Any for generic parameters.
13068 2003-11-02 Martin Baulig <martin@ximian.com>
13070 * expression.cs (Invocation.EmitCall): Use
13071 `TypeManager.IsValueType()' to check whether it's a value type.
13072 Don't set `struct_call' when calling a method on a type parameter.
13074 2003-11-02 Martin Baulig <martin@ximian.com>
13076 * generics.cs (ConstructedType.Resolve): Renamed to ResolveType()
13077 and removed the TypeBuilder argument.
13079 * typemanager.cs (TypeManager.IsValueType): Return
13080 `t.IsGenericParameter || t.IsValueType'.
13082 2003-10-25 Martin Baulig <martin@ximian.com>
13084 * decl.cs (DeclSpace.ResolveType): If we're a ConstructedType,
13085 call ConstructedType.Resolve() on it.
13087 * generic.cs (ConstructedType.Resolve): Set `type' on success.
13089 2003-10-25 Martin Baulig <martin@ximian.com>
13091 * class.cs (TypeContainer.GetClassBases): Changed
13092 `out Type parent' into `out TypeExpr parent'. Moved CS0644 and
13093 CS8214 reporting here.
13094 (TypeContainer.DefineType): GetClassBases() gives us a `TypeExpr'
13095 instead of a `Type' for our parent. In case of a recursive
13096 declaration (see tests/gen-23.cs for an example), our parent is a
13097 ConstructedType and it doesn't have its type set. So, first
13098 create our own TypeBuilder, then call constructed.Resolve() to get
13099 the parent's type and finally TypeBuilder.SetParent() it.
13101 * ecore.cs (TypeExpr.Name): New public virtual property.
13104 (ConstructedType): We're now a TypeExpr and not just an Expression.
13105 (ConstructedType.ResolveAsTypeStep): Don't resolve our type
13106 arguments here; this is done later.
13107 (ConstructedType.Resolve): New public method to resolve the type
13108 arguments and bind them.
13110 2003-10-21 Martin Baulig <martin@ximian.com>
13112 * convert.cs: Use `TypeManager.IsValueType' instead of
13113 'type.IsValueType' everywhere.
13115 * typemanager.cs (TypeManager.IsValueType): Return true for type
13116 parameters. The reason for this is that we need to box a type
13117 parameter when converting it to a reference type.
13119 * cs-parser.jay: Added support for default value expressions.
13121 * generics.cs (DefaultValueExpression): New public class.
13123 2003-10-17 Martin Baulig <martin@ximian.com>
13125 * generic.cs (Constraints.Resolve): Take a DecpSpace instead of a
13126 TypeContainer so we can also use this for Interfaces.
13127 (TypeParameter.Resolve): Likewise.
13129 * interface.cs (Interface.DefineType): Added support for generic
13132 * cs-parser.jay: Added support for generic structs and interfaces.
13134 2003-10-17 Martin Baulig <martin@ximian.com>
13136 * generic.cs (GenericMemberAccess.DoResolve): We can now actually
13137 call generic methods :-)
13139 2003-10-16 Martin Baulig <martin@ximian.com>
13141 * cs-parser.jay (namespace_or_type_name): Only create a
13142 GenericMemberAccess if we actually have type arguments.
13144 2003-10-13 Martin Baulig <martin@ximian.com>
13146 * class.cs (Method.Define): If we're a generic method, call
13147 TypeBuilder.DefineGenericMethod () before resolving
13149 (MethodData): Added .ctor which takes an additional MethodBuilder
13150 argument; this is used for generic methods.
13151 (MethodData.Define): Call `builder.SetGenericMethodSignature()' if
13152 we already have a MethodBuilder.
13154 2003-10-10 Martin Baulig <martin@ximian.com>
13156 * class.cs (Method): Added .ctor which takes a `GenericMethod'
13157 instead of a `DeclSpace'. This is used for generic methods.
13159 * cs-parser.jay (method_header): Added support for generic
13160 methods; create a `GenericMethod' instance and pass it to the
13161 `Method's .ctor; it'll be used as the `DeclSpace' to lookup
13162 parameters and locals.
13164 * decl.cs (DeclSpace.SetParameterInfo): Removed Location argument
13165 since we already have the location. Check whether we're a generic
13166 type declaration or a generic method and create the correct type
13169 * generic.cs (TypeParameter.DefineMethod): New public method.
13170 (GenericMethod): New public class; derives from DeclSpace and is
13171 used for generic methods.
13173 2003-10-09 Martin Baulig <martin@ximian.com>
13175 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
13177 (MethodCore.DoDefineParameters): Removed the TypeContainer
13178 argument; use the DeclSpace which was passed to the .ctor instead.
13179 (MethodCore.CheckParameter): Take a DeclSpace instead of a
13180 TypeContainer; we only need a DeclSpace here.
13182 2003-10-09 Martin Baulig <martin@ximian.com>
13184 * class.cs (MethodData): Added additional `DeclSpace ds' argument
13186 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
13187 EmitContext's .ctor.
13189 2003-10-09 Martin Baulig <martin@ximian.com>
13191 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
13192 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
13193 AsAccessible(), moved them as well.
13195 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
13197 2003-10-07 Miguel de Icaza <miguel@ximian.com>
13199 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
13200 generation for >=, as spotted by Paolo, bug 48679.
13201 Patch from David Waite.
13203 * cs-tokenizer.cs: Add handling for #pragma.
13205 * cs-parser.jay: Allow for both yield and yield return in the
13206 syntax. The anti-cobolization of C# fight will go on!
13208 * class.cs (TypeBuilder.DefineType): Catch error condition here
13209 (Parent.DefineType erroring out and returning null).
13211 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
13212 coping with enumerations variables, we were mistakenly processing
13213 them as a regular value type instead of built-in types. Fixes the
13216 * typemanager.cs (IsBuiltinOrEnum): New method.
13218 2003-09-30 Miguel de Icaza <miguel@ximian.com>
13220 * cs-parser.jay: Upgrade: yield now needs the return clause.
13222 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
13224 * cs-parser.jay : Renamed yyName to yyNames related to jay.
13226 2003-09-29 Martin Baulig <martin@ximian.com>
13228 * typemanager.cs (TypeManager.GetMethodFlags): Added support for
13229 inflated generic methods.
13231 * generics.cs (ConstructedType): Distinguish between open and
13232 closed constructed types; correctly resolve the arguments.
13234 2003-09-22 Martin Baulig <martin@ximian.com>
13236 * generic.cs (ConstructedType.ResolveAsTypeCheck): Check whether
13237 all type arguments meet their constraints.
13239 2003-09-19 Martin Baulig <martin@ximian.com>
13241 * decl.cs (MemberCache.SetupCacheForInterface): Take a
13242 `MemberCache parent' argument. Normally, an interface doesn't
13243 have a parent type except System.Object, but we use this in gmcs
13244 for generic type parameters.
13246 2003-09-18 Martin Baulig <martin@ximian.com>
13248 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
13249 on `type.IsInterface'; don't check whether the type has a parent
13250 to determine whether it's an interface.
13252 2003-09-17 Martin Baulig <martin@ximian.com>
13254 * generic.cs (ConstructedType.ToString): Always use `name' as the
13257 2003-09-15 Martin Baulig <martin@ximian.com>
13259 * cs-parser.jay: Fix grammar wrt. type_parameter_constraints.
13261 * generic.cs (Constraints.Resolve): New public method; this is
13262 called to resolve the constraint types and to check whether all
13263 the constraints are correct.
13264 (Constraints.Types): New public property.
13265 (TypeParameter.Resolve): New public method; resolves all the
13266 type's constraints.
13268 * class.cs (TypeContainer.DefineType): Call
13269 TypeParameter.Resolve() before actually defining the type.
13271 2003-09-15 Martin Baulig <martin@ximian.com>
13273 * class.cs (TypeContainer.DefineType): Added an error flag to
13274 avoid reporting duplicate CS0146's ("class definition is
13277 * driver.cs (Driver.MainDriver): Abort if
13278 RootContext.ResolveTree() reported any errors.
13280 2003-09-07 Martin Baulig <martin@ximian.com>
13282 * report.cs (Error, Warning): Added overloaded versions which take
13283 a `params object[] args' and call String.Format().
13285 2003-09-07 Martin Baulig <martin@ximian.com>
13287 * decl.cs (DeclSpace..ctor): Don't call
13288 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
13289 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
13290 (DeclSpace.RecordDecl): New method.
13292 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
13294 2003-09-02 Ravi Pratap <ravi@ximian.com>
13296 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
13297 value attributes to be applied to ParameterBuilders.
13299 * class.cs (MethodCore.LabelParameters): Make static and more
13300 generic so that it can be used from other places - like interface
13301 methods, for instance.
13303 * interface.cs (Interface.Emit): Call LabelParameters before
13304 emitting attributes on the InterfaceMethod.
13306 2003-09-07 Martin Baulig <martin@ximian.com>
13308 * generic.cs (ConstructedType.ResolveAsTypeStep): Report a CS8217
13309 if the number of type parameters doesn't match.
13311 2003-09-04 Martin Baulig <martin@ximian.com>
13313 * expression.cs (ComposedCast.ResolveAsTypeStep): Added support
13314 for arrays of generic type params (ie. `!0[]').
13316 2003-09-04 Martin Baulig <martin@ximian.com>
13318 * class.cs (TypeContainer.AsAccessible): Ignore generic parameters
13321 2003-09-04 Martin Baulig <martin@ximian.com>
13323 * decl.cs (DeclSpace.LookupGeneric): New method.
13324 (DeclSpace.CheckAccessLevel): Ignore generic parameters for the
13327 * generic.cs (TypeParameterExpr): Take a TypeParameter as
13328 argument, not just a string.
13329 (TypeParameter.Define): New public method; this is called to
13330 actually define the generic parameter; after this, you can use the
13331 new `Type' property to get the type.
13333 2003-09-04 Martin Baulig <martin@ximian.com>
13335 * decl.cs (DeclSpace.SetParameterInfo): The `constraints' argument
13336 is now an ArrayList; initialize the result of the `TypeParameters'
13338 (DeclSpace.GetGenericData): Removed.
13339 (DeclSpace.LookupGeneric): Temporarily removed; we need to
13340 implement this in a different way.
13341 (DeclSpace.GetTypeParameters): Removed; there's now a
13342 `TypeParameters' property.
13343 (DeclSpace.TypeParameters): New public property.
13345 * generic.cs (Constraints): Make this class public.
13346 (TypeParameter): New public class.
13348 2003-09-04 Martin Baulig <martin@ximian.com>
13350 * decl.cs (DeclSpace.GetTypeParameters): New method to return the
13351 generic parameters.
13353 * class.cs (TypeContainer.DefineType): Call
13354 TypeBuilder.DefineGenericParameter () on all generic parameters if
13355 this is a generic type.
13357 2003-08-28 Martin Baulig <martin@ximian.com>
13359 * sample-stack.il: Compile this with ilasm: "ilasm /dll
13362 * sample-hello.cs: Compile this with gmcs: "gmcs
13363 /r:sample-stack.dll sample-hello.cs".
13365 2003-08-28 Martin Baulig <martin@ximian.com>
13367 * generic.cs (ConstructedType.ResolveAsTypeStep): Actually bind
13368 the parameters to the generic type.
13370 2003-08-28 Martin Baulig <martin@ximian.com>
13372 * cs-tokenizer.cs (parse_less_than): Also allow all builtin types.
13374 2003-08-28 Martin Baulig <martin@ximian.com>
13376 * cs-parser.jay (opt_type_argument_list): Use
13377 `OP_GENERICS_LT type_arguments OP_GENERICS_GT'.
13378 (primary_expression): Replace `qualified_identifier' with `type_name'.
13379 (type_parameter_list): Use `OP_GENERICS_LT type_parameters OP_GENERICS_GT'.
13381 * cs-tokenizer.cs (is_punct): When reading a `<', invoke a custom
13382 parser to check whether it is syntactically a type parameter list;
13383 return OP_GENERICS_LT/OP_GENERICS_GT instead of OP_LT/OP_GT in
13386 2003-08-26 Martin Baulig <martin@ximian.com>
13388 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
13389 resolving aliases; fixes #47927.
13391 2003-08-26 Martin Baulig <martin@ximian.com>
13393 * statement.cs (Using.DoResolve): This is internally emitting a
13394 try/finally clause, so we need to set ec.NeedExplicitReturn if we
13395 do not always return. Fixes #47681.
13397 2003-08-26 Martin Baulig <martin@ximian.com>
13399 * decl.cs (MemberCore): Moved WarningNotHiding(),
13400 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
13402 (AdditionResult): Make this nested in DeclSpace.
13403 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
13404 argument; call NamespaceEntry.Define() unless we're nested in a
13407 * namespace.cs (Namespace.DefineName): New public function. This
13408 is called from DeclSpace's .ctor to add
13409 (Namespace.Lookup): Include DeclSpaces in the lookup.
13411 * class.cs (Operator): Derive from MemberBase, not MemberCore.
13413 * const.cs (Const): Derive from MemberBase, not MemberCore.
13415 2003-08-25 Martin Baulig <martin@ximian.com>
13417 * convert.cs (Convert.ExplicitReferenceConversion): When
13418 converting from an interface type to a class, unbox if the target
13419 type is a struct type. Fixes #47822.
13421 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
13423 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
13426 2003-08-22 Martin Baulig <martin@ximian.com>
13428 * class.cs (TypeManager.DefineType): When defining a nested type,
13429 call DefineType() on our parent; fixes #47801.
13431 2003-08-22 Martin Baulig <martin@ximian.com>
13433 * class.cs (MethodData.Define): While checking if a method is an
13434 interface implementation, improve the test a bit more to fix #47654.
13436 2003-08-22 Martin Baulig <martin@ximian.com>
13438 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
13439 correctly; fixes #47722.
13441 2003-08-22 Martin Baulig <martin@ximian.com>
13443 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
13444 LocalVariableReference, ensure it's not read-only. Fixes #47536.
13446 * statement.cs (Fixed.DoResolve): Make all variables read-only.
13448 2003-08-22 Martin Baulig <martin@ximian.com>
13450 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
13451 can only be assigned in static constructors. Fixes #47161.
13453 2003-08-22 Martin Baulig <martin@ximian.com>
13455 Rewrote and improved the flow analysis code.
13457 * flowbranching.cs (FlowBranching): Make this class abstract.
13458 (FlowBranching.CreateBranching): New static function to create a
13459 new flow branching.
13460 (FlowBranchingBlock, FlowBranchingException): New classes.
13461 (FlowBranching.UsageVector.Type): New public readonly field.
13462 (FlowBranching.UsageVector.Breaks): Removed the setter.
13463 (FlowBranching.UsageVector.Returns): Removed the setter.
13464 (FlowBranching.UsageVector): Added Break(), Return(),
13465 NeverReachable() and Throw() methods to modify the reachability.
13466 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
13467 done by FlowBranching.Merge().
13468 (FlowBranching.UsageVector.MergeChild): New method; merges the
13469 merge result into the current vector.
13470 (FlowBranching.Merge): New abstract method to merge a branching.
13472 2003-08-12 Martin Baulig <martin@ximian.com>
13474 * expression.cs (Indirection.CacheTemporaries): Create the
13475 LocalTemporary with the pointer type, not its element type.
13477 2003-08-10 Miguel de Icaza <miguel@ximian.com>
13479 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
13480 token was a keyword or not.
13482 Add `error' options where an IDENTIFIER was expected; Provide
13483 CheckToken and CheckIdentifierToken convenience error reporting
13486 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
13488 * decl.cs: Rename `NamespaceEntry Namespace' public field into
13489 NameSpaceEntry NameSpaceEntry.
13491 (LookupInterfaceOrClass): Avoid creating a full qualified name
13492 from namespace and name: avoid doing lookups when we know the
13493 namespace is non-existant. Use new Tree.LookupByNamespace which
13494 looks up DeclSpaces based on their namespace, name pair.
13496 * driver.cs: Provide a new `parser verbose' to display the
13497 exception thrown during parsing. This is turned off by default
13498 now, so the output of a failure from mcs is more graceful.
13500 * namespace.cs: Track all the namespaces defined in a hashtable
13503 (IsNamespace): New method
13505 2003-08-09 Miguel de Icaza <miguel@ximian.com>
13507 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
13508 we know that we need to concatenate (full typename can never be
13513 * statement.cs: Use a bitfield; Do not initialize to null things
13514 which are done by the constructor by default.
13516 * cs-parser.jay: bug fix, parameter was 4, not 3.
13518 * expression.cs: Just use the property;
13520 * statement.cs: No need for GetVariableInfo method.
13522 2003-08-08 Martin Baulig <martin@ximian.com>
13524 * flowanalysis.cs (FlowReturns): This is now nested in the
13525 `FlowBranching' class.
13526 (MyBitVector): Moved this here from statement.cs.
13527 (FlowBranching.SiblingType): New enum type.
13528 (FlowBranching.CreateSibling): Added `SiblingType' argument.
13530 2003-08-07 Martin Baulig <martin@ximian.com>
13532 * flowanalysis.cs (FlowBranchingType): This is now nested in the
13533 `FlowBranching' class and called `BranchingType'.
13535 2003-08-07 Martin Baulig <martin@ximian.com>
13537 * flowanalysis.cs: Moved all the control flow analysis code into
13540 2003-08-07 Martin Baulig <martin@ximian.com>
13542 * assign.cs (Assign.DoResolve): `target' must either be an
13543 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
13546 2003-08-07 Miguel de Icaza <miguel@ximian.com>
13548 * expression.cs (BinaryMethod): This kind of expression is created by the
13549 Binary class if it determines that the operator has to be handled
13552 (BinaryDelegate): This kind of expression is created if we are
13553 dealing with a + or - operator on delegates.
13555 (Binary): remove method, argumetns, and DelegateOperator: when
13556 dealing with methods,
13558 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
13560 * statement.cs (Block): use bitfields for the three extra booleans
13561 we had in use. Remove unused topblock parameter.
13563 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
13565 * assign.cs: Drop extra unneeded tests.
13567 2003-08-06 Miguel de Icaza <miguel@ximian.com>
13569 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
13571 * statement.cs (Foreach): Use VariableStorage instead of
13574 * codegen.cs (VariableStorage): New class used by clients that
13575 require a variable stored: locals or fields for variables that
13576 need to live across yield.
13578 Maybe provide a convenience api for EmitThis+EmitLoad?
13580 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
13583 2003-08-05 Miguel de Icaza <miguel@ximian.com>
13585 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
13586 RemapParameterLValue): New methods that are used to turn a
13587 precomputed FieldInfo into an expression like this:
13591 The idea is to use this instead of making LocalVariableReference
13592 have more than one meaning.
13594 * cs-parser.jay: Add error production to BASE.
13596 * ecore.cs: Deal with TypeManager.GetField returning null, which
13597 is now a valid return value.
13599 (FieldExprNoAddress): New expression for Fields whose address can
13602 * expression.cs (LocalVariableReference): During the resolve
13603 phases, create new expressions if we are in a remapping context.
13604 Remove code that dealt with remapping here.
13606 (ParameterReference): same.
13608 (ProxyInstance): New expression, like the `This' expression, but
13609 it is born fully resolved. We know what we are doing, so remove
13610 the errors that are targeted to user-provided uses of `this'.
13612 * statement.cs (Foreach): our variable is now stored as an
13613 Expression; During resolution, follow the protocol, dont just
13614 assume it will return this.
13616 2003-08-06 Martin Baulig <martin@ximian.com>
13618 * support.cs (SeekableStreamReader.cs): New public class.
13620 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
13621 SeekableStreamReader instead of the normal StreamReader.
13623 2003-08-04 Martin Baulig <martin@ximian.com>
13625 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
13626 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
13627 deambiguate casts and delegate invocations.
13628 (parenthesized_expression): Use the new tokens to ensure this is
13629 not a cast of method invocation.
13631 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
13632 when reading a `)' and Deambiguate_CloseParens () was previously
13635 * expression.cs (ParenthesizedExpression): New class. This is
13636 just used for the CS0075 test.
13637 (Binary.DoResolve): Check for CS0075.
13639 2003-07-29 Ravi Pratap <ravi@ximian.com>
13641 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
13642 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
13643 reference comparison.
13645 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
13646 examine the ReturnType for equality - this is necessary in the
13647 cases of implicit and explicit operators whose signature also
13648 includes the return type.
13650 2003-07-26 Miguel de Icaza <miguel@ximian.com>
13652 * namespace.cs: Cache the result of the namespace computation,
13653 instead of computing it every time.
13655 2003-07-24 Miguel de Icaza <miguel@ximian.com>
13657 * decl.cs: Use a global arraylist that we reuse over invocations
13658 to avoid excesive memory consumption. Reduces memory usage on an
13659 mcs compile by one meg (45 average).
13661 * typemanager.cs (LookupTypeReflection): In .NET pointers are
13662 private, work around that.
13664 2003-07-23 Miguel de Icaza <miguel@ximian.com>
13666 * literal.cs (IntLiteral): Define Zero and One static literals.
13668 * cs-parser.jay (integer_literal): use static literals to reduce
13669 memory usage for the most used literals (0, 1 and -1). 211kb
13670 reduced in memory usage.
13672 Replace all calls to `new ArrayList' with `new
13673 ArrayList(4)' which is a good average number for most allocations,
13674 and also requires only 16 bytes of memory for its buffer by
13677 This reduced MCS memory usage in seven megabytes for the RSS after
13680 2003-07-28 Ravi Pratap <ravi@ximian.com>
13682 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
13683 handle params methods the correct way by forming only one
13684 applicable set with params and normal methods in them. Earlier we
13685 were looking at params methods only if we found no normal methods
13686 which was not the correct thing to do.
13688 (Invocation.BetterFunction): Take separate arguments indicating
13689 when candidate and the best method are params methods in their
13692 This fixes bugs #43367 and #46199.
13694 * attribute.cs: Documentation updates.
13696 (CheckAttribute): Rename to CheckAttributeTarget.
13697 (GetValidPlaces): Rename to GetValidTargets.
13699 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
13700 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
13704 2003-07-28 Miguel de Icaza <miguel@ximian.com>
13706 * codegen.cs: Compute IsGeneric correctly.
13708 * cs-parser.jay: Introduce OP_GENERIC_LT for the grammar ambiguity
13711 Bring back (temporarily) OP_LEFT_SHIFT, OP_RIGHT_SHIFT,
13712 OP_SHIFT_RIGHT_ASSIGN, OP_SHIFT_LEFT_ASSIGN. There were too many
13713 regressions, and I was chasing more bugs than I required.
13715 * interface.cs: Use expressions for base type names (like classes
13716 and structs have been doing for a while now), and resolve that.
13717 This patch should probably go into head as well.
13719 This makes it one less user of FindType.
13721 2003-07-24 Miguel de Icaza <miguel@ximian.com>
13723 This compiler can not self host currently. Need to fix that.
13725 * Makefile: compile to `gmcs.exe'
13727 * driver.cs: Turn on v2 by default on gmcs.
13729 * generic.cs (ConstructedType): Does no longer take a container
13730 type argument; That will be taken care of later.
13732 (ConstructedType.DoResolve, ConstructedType.ResolveAsTypeStep):
13733 Use SimpleName to resolve for now, so we can continue the work on
13734 the parser, until we get Type.GetType that understands generics.
13736 (ConstructedType.ToString): Implement
13738 (TypeArguments.Resolve): Resolve the child expressions as types.
13740 * cs-parser.jay: Rename interface_constraints to
13741 type_parameter_constraints
13743 (namespace_or_type_name): Only use constructed types for the basic
13744 construction, we will deal with identifier<...> later.
13746 (type/type_name): No longer call DecomposeQI, as
13747 namespace_or_type_name is always decoded now.
13749 2003-07-22 Ravi Pratap <ravi@ximian.com>
13751 * expression.cs (Invocation.OverloadResolve): Follow the spec more
13752 closely: we eliminate methods in base types when we have an
13753 applicable method in a top-level type.
13755 Please see section 14.5.5.1 for an exact description of what goes
13758 This fixes bug #45127 and a host of other related to corlib compilation.
13760 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
13761 array is the method corresponding to the top-level type (this is
13762 because of the changes made to icall.c) so we change this
13765 (MethodGroupExpr.Name): This too.
13767 * typemanager.cs (GetElementType): New method which does the right
13768 thing when compiling corlib.
13770 * everywhere: Make use of the above in the relevant places.
13772 2003-07-22 Martin Baulig <martin@ximian.com>
13774 * cs-parser.jay (invocation_expression): Moved
13775 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
13776 `cast_expression', but create a InvocationOrCast which later
13777 resolves to either an Invocation or a Cast.
13779 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
13780 method; call this before EmitStatement() to make sure that this
13781 expression can be used as a statement.
13783 * expression.cs (InvocationOrCast): New class; resolves to either
13784 an Invocation or a Cast.
13786 * statement.cs (StatementExpression): Call ResolveStatement() on
13787 the ExpressionStatement before emitting it.
13789 2003-07-21 Martin Baulig <martin@ximian.com>
13791 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
13792 `ref' and `out' attributes match; fixes #46220.
13793 (MemberAccess.ResolveMemberAccess): You can't reference a type
13794 through an expression; fixes #33180.
13795 (Indexers.GetIndexersForType): Don't return the indexers from
13796 interfaces the class implements; fixes #46502.
13798 2003-07-21 Martin Baulig <martin@ximian.com>
13800 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
13801 CS0661 checks; fixes bug #30442.
13803 2003-07-21 Martin Baulig <martin@ximian.com>
13805 * decl.cs (AdditionResult): Added `Error'.
13807 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
13809 * typemanager.cs (TypeManager.ChangeType): Catch exceptions; makes
13810 cs0031.cs actually work.
13812 2003-07-20 Miguel de Icaza <miguel@ximian.com>
13814 * cs-parser.jay (namespace_name): do not use
13815 namespace_or_type_name, use qualified_identifier, because
13816 namespace_or_type_name will soon return a composed expression
13817 instead of a string.
13819 (namespace_or_type_name): Instead of returning a string, now this
13820 production returns an expression.
13822 * codegen.cs (EmitContext): Setup IsGeneric property based on
13823 whether our DeclSpace is generic, our the method is generic.
13825 * modifier.cs (Modifiers.METHOD_GENERIC): New definition, use if
13826 the method is generic.
13828 * cs-parser.jay (type_arguments, opt_type_argument_list,
13829 type_parameters, type_parameter_list, opt_type_parameter_list,
13830 type_parameter,, opt_type_parameter_constraints_clauses,
13831 type_parameter_constraints_clauses,
13832 type_parameter_constraint_clause, type_parameter_constraint,
13833 interface_constraints): Add new production
13835 * decl.cs (DeclSpace): IsGeneric, flag to track whether this
13836 DeclSpace is generic or not.
13838 (DeclSpace.SetParameterInfo): New routine, used to set the
13839 parameter info for a type.
13841 (DeclSpace.LookupGeneric): Lookups a name, and if it is a generic,
13842 returns a GenericTypeExpr
13844 * ecore.cs (SimpleName.ResolveAsTypeStep): If our container is
13845 generic, lookup the generic argument.
13847 * attribute.cs: Do not allow TypeParameterExpressions in
13850 * class.cs: Do not allow the Main method to be defined in a
13853 * expression.cs (SizeOf): Do not allow generic types to be used as
13854 arguments to sizeof.
13856 * typemanager.cs (IsGeneric): Wrapper for Reflection when we have
13857 it: whether a type is generic or not. Only works for types we are
13858 currently building for now.
13860 2003-07-20 Martin Baulig <martin@ximian.com>
13862 * namespace.cs: Fixed that bug which caused a crash when compiling
13863 the debugger's GUI.
13865 2003-07-20 Miguel de Icaza <miguel@ximian.com>
13867 * typemanager.cs (LookupTypeReflection): Never expose types which
13868 are NotPublic, NestedPrivate, NestedAssembly, or
13869 NestedFamANDAssem. We used to return these, and later do a check
13870 that would report a meaningful error, but the problem is that we
13871 would not get the real match, if there was a name override.
13873 2003-07-18 Miguel de Icaza <miguel@ximian.com>
13875 * namespace.cs (Namespace, Name): Do not compute the namespace
13876 name dynamically, compute it in the constructor. This reduced
13877 memory usage by 1697 KB.
13879 * driver.cs: Use --pause to pause at the end.
13881 2003-07-17 Peter Williams <peter@newton.cx>
13883 * Makefile: Change the name of the test target so that it doesn't
13884 conflict with the recursive test target.
13886 2003-07-17 Miguel de Icaza <miguel@ximian.com>
13888 * expression.cs (LocalVariableReference.Emit, EmitAssign,
13889 AddressOf): Do not use EmitThis, that was wrong, use the actual
13892 2003-07-15 Miguel de Icaza <miguel@ximian.com>
13894 * class.cs (MethodData.Define): While checking if a method is an
13895 interface implementation, improve the test: If we are not public
13896 (use new test here: use the computed MethodAttributes directly,
13897 instead of the parsed modifier flags) check if the `implementing'
13898 method comes from an interface or not.
13900 * pending.cs (VerifyPendingMethods): Slightly better error
13903 * makefile: add test target that does the mcs bootstrap.
13905 2003-07-16 Ravi Pratap <ravi@ximian.com>
13907 * interface.cs (Define): Do nothing here since there are no
13908 members to populate etc. Move the attribute emission out of here
13909 since this was just totally the wrong place to put it. Attribute
13910 application happens during the 'Emit' phase, not in the 'Define'
13913 (Emit): Add this method and move the attribute emission here
13915 * rootcontext.cs (EmitCode): Call the Emit method on interface
13918 2003-07-14 Ravi Pratap M <ravi@ximian.com>
13920 * expression.cs (OverloadResolve): Report error only if Location
13921 is not 'Null' which means that there was a probe going on.
13923 2003-07-14 Martin Baulig <martin@ximian.com>
13925 * expression.cs (ConditionalLogicalOperator): New public class to
13926 implement user defined conditional logical operators.
13927 This is section 14.11.2 in the spec and bug #40505.
13929 2003-07-14 Martin Baulig <martin@ximian.com>
13931 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
13933 2003-07-14 Martin Baulig <martin@ximian.com>
13935 * codegen.cs (EmitContext.InFixedInitializer): New public field.
13937 * ecore.cs (IVariable.VerifyFixed): New interface method.
13939 * expression.cs (Unary.ResolveOperator): When resolving the `&'
13940 operator, check whether the variable is actually fixed. Fixes bug
13941 #36055. Set a variable definitely assigned when taking its
13942 address as required by the spec.
13944 * statement.cs (LocalInfo.IsFixed): New field.
13945 (LocalInfo.MakePinned): Set `IsFixed' to true.
13947 2003-07-14 Ravi Pratap M <ravi@ximian.com>
13949 * attribute.cs (Attribute.Resolve): While doing a Member lookup
13950 for .ctors, ensure that we only ask for members declared in the
13951 attribute type (BindingFlags.DeclaredOnly).
13955 * expression.cs (Error_WrongNumArguments): Report error 1501
13956 correctly the way CSC does.
13958 2003-07-13 Martin Baulig <martin@ximian.com>
13960 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
13961 lookup on the fully qualified name, to make things like "X.X" work
13962 where "X.X" is a fully qualified type name, but we also have a
13963 namespace "X" in the using list. Fixes #41975.
13965 2003-07-13 Martin Baulig <martin@ximian.com>
13967 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
13968 function. If we're a CompoundAssign, we need to create an embedded
13969 CompoundAssign, not an embedded Assign.
13970 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
13973 2003-07-13 Martin Baulig <martin@ximian.com>
13975 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
13976 work to fix bug #46088.
13978 2003-07-13 Ravi Pratap <ravi@ximian.com>
13980 * class.cs (Operator.Emit): Do not emit attributes here - it is
13981 taken care of by the Method class that we delegate too. This takes
13982 care of bug #45876.
13984 2003-07-10 Martin Baulig <martin@ximian.com>
13986 * expression.cs (TypeOfVoid): New class.
13987 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
13989 2003-07-10 Martin Baulig <martin@ximian.com>
13991 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
13994 2003-07-10 Martin Baulig <martin@ximian.com>
13996 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
13997 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
13999 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
14001 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
14003 2003-07-10 Martin Baulig <martin@ximian.com>
14005 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
14006 of decimal. Fixes #42850.
14008 NOTE: I also fixed the created byte blob, but this doesn't work on
14009 the MS runtime and csc never produces any byte blobs for decimal
14012 2003-07-10 Martin Baulig <martin@ximian.com>
14014 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
14015 structs; fixes #32068.
14016 (Block.AddChildVariableNames): Fixed #44302.
14018 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
14020 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
14022 2003-07-07 Miguel de Icaza <miguel@ximian.com>
14024 * attribute.cs: And this test is onger needed.
14026 2003-07-08 Martin Baulig <martin@ximian.com>
14028 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
14029 inaccessible types. Fixes #36313.
14031 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
14033 * namespace.cs (NamespaceEntry): Create implicit entries for all
14034 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
14035 implicit entries for N1.N2 and N1.
14037 2003-07-08 Martin Baulig <martin@ximian.com>
14039 Rewrote the handling of namespaces to fix a lot of the issues
14040 wrt. `using' aliases etc.
14042 * namespace.cs (Namespace): Splitted this class into a
14043 per-assembly `Namespace' and a per-file `NamespaceEntry'.
14045 * typemanager.cs (TypeManager.IsNamespace): Removed.
14046 (TypeManager.ComputeNamespaces): Only compute namespaces from
14047 loaded assemblies here, not the namespaces from the assembly we're
14048 currently compiling.
14050 2003-07-08 Martin Baulig <martin@ximian.com>
14052 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
14054 2003-07-07 Miguel de Icaza <miguel@ximian.com>
14056 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
14059 I thought about the memory savings here, but LookupTypeReflection
14060 is used under already very constrained scenarios. Compiling
14061 corlib or mcs only exposes one hit, so it would not really reduce
14062 any memory consumption.
14064 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
14066 * typemanager.cs: fixes bug #45889 by only adding public types from
14067 other assemblies to the list of known types.
14069 2003-07-07 Miguel de Icaza <miguel@ximian.com>
14071 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
14072 on the type we resolved.
14074 2003-07-05 Martin Baulig <martin@ximian.com>
14076 * pending.cs (PendingImplementation.ParentImplements): Don't
14077 create the proxy if the parent is abstract.
14079 * class.cs (TypeContainer.DefineIndexers): Process explicit
14080 interface implementations first. Fixes #37714.
14082 2003-07-04 Miguel de Icaza <miguel@ximian.com>
14084 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
14085 defined recursively; but since we modify the input parameters
14086 (left is set to `this' temporarily), we reset this value if the
14087 left_is_explicit is false, which gives the original semantics to
14090 * literal.cs (NullPointer): new class used to represent a null
14091 literal in a pointer context.
14093 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
14094 type is a pointer, use a NullPointer object instead of a
14095 NullLiteral. Closes 43687
14097 (ExplicitConversion): Convert pointer values using
14098 the conv opcode to the proper type.
14100 * ecore.cs (New): change ValueTypeVariable property into a method,
14101 that returns whether the valuetype is suitable for being used.
14103 * expression.cs (Binary.DoNumericPromotions): Only return if we
14104 the int constant was a valid uint, and we can return both left and
14105 right as uints. If not, we continue processing, to trigger the
14106 type conversion. This fixes 39018.
14108 * statement.cs (Block.EmitMeta): During constant resolution, set
14109 the CurrentBlock property on the emitcontext, so that we resolve
14110 constants propertly.
14112 2003-07-02 Martin Baulig <martin@ximian.com>
14114 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
14115 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
14117 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
14118 than emitting it here.
14120 * statement.cs: Fixed some more flow analysis bugs.
14122 2003-07-02 Martin Baulig <martin@ximian.com>
14124 * class.cs (MethodData.Define): When implementing interface
14125 methods, set Final unless we're Virtual.
14127 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
14128 check work for interface methods.
14130 2003-07-01 Martin Baulig <martin@ximian.com>
14132 * ecore.cs (EmitContext.This): Replaced this property with a
14133 GetThis() method which takes a Location argument. This ensures
14134 that we get the correct error location for a CS0188.
14136 2003-07-01 Miguel de Icaza <miguel@ximian.com>
14138 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
14139 ImplicitStandardConversion.
14141 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
14143 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
14145 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
14148 2003-06-30 Miguel de Icaza <miguel@ximian.com>
14150 * class.cs (Constructor.Define): Turn off initlocals for unsafe
14153 (MethodData.Define): Turn off initlocals for unsafe methods.
14155 2003-06-29 Miguel de Icaza <miguel@ximian.com>
14157 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
14158 complete; Fixes #37521.
14160 * delegate.cs: Use Modifiers.TypeAttr to compute the
14161 TypeAttributes, instead of rolling our own. This makes the flags
14162 correct for the delegates.
14164 2003-06-28 Miguel de Icaza <miguel@ximian.com>
14166 * class.cs (Constructor.Define): Set the private flag for static
14167 constructors as well.
14169 * cs-parser.jay (statement_expression): Set the return value to
14170 null, to avoid a crash when we catch an error.
14172 2003-06-24 Miguel de Icaza <miguel@ximian.com>
14174 * cs-parser.jay: Applied patch from Jackson that adds support for
14175 extern and unsafe modifiers to destructor declarations.
14177 * expression.cs: Report error 21 if the user is trying to index a
14180 * driver.cs: Add an error message, suggested by the bug report.
14182 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
14183 if we do not have a ": this ()" constructor initializer. Fixes 45149
14185 2003-06-14 Miguel de Icaza <miguel@ximian.com>
14187 * namespace.cs: Add some information to reduce FAQs.
14189 2003-06-13 Miguel de Icaza <miguel@ximian.com>
14191 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
14192 underlying enumeration types. Fixes #43915.
14194 * expression.cs: Treat ushort/short as legal values to be used in
14195 bitwise operations.
14197 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
14199 * delegate.cs: transfer custom attributes for paramenters from
14200 the delegate declaration to Invoke and BeginInvoke.
14202 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
14204 * attribute.cs: handle custom marshalers and emit marshal info
14207 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
14209 * makefile.gnu: Added anonymous.cs to the compiler sources.
14211 2003-05-28 Miguel de Icaza <miguel@ximian.com>
14213 * iterators.cs: Change the name of the proxy class to include two
14216 * cs-parser.jay: Update grammar to include anonymous methods.
14218 * anonymous.cs: new file.
14220 2003-05-27 Miguel de Icaza <miguel@ximian.com>
14222 * class.cs (Field.Define): Add missing test for pointers and
14225 2003-05-27 Ravi Pratap <ravi@ximian.com>
14227 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
14228 we use the stobj opcode.
14230 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
14231 since it wasn't the correct fix.
14233 It still is puzzling that we are required to use stobj for IntPtr
14234 which seems to be a ValueType.
14236 2003-05-26 Miguel de Icaza <miguel@ximian.com>
14238 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
14239 during regular simple name resolution. Now, the trick is that
14240 instead of returning for processing the simplename, we do a
14241 TypeManager.LookupType (ie, a rooted lookup as opposed to a
14242 contextual lookup type). If a match is found, return that, if
14243 not, return for further composition.
14245 This fixes long-standing 30485.
14247 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
14248 using the address to initialize an object, do an Stobj instead of
14249 using the regular Stelem.
14251 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
14252 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
14253 Because if we are a BaseIndexerAccess that value will be true.
14256 * statement.cs (GotoCase.Resolve): Return after reporting an
14257 error, do not attempt to continue.
14259 * expression.cs (PointerArithmetic.Emit): If our operand is a
14260 long, convert our constants to match the operand before
14261 multiplying. Convert to I type before adding. Fixes 43670.
14263 2003-05-14 Ravi Pratap <ravi@ximian.com>
14265 * enum.cs (ImplicitConversionExists) : Rename to
14266 ImplicitEnumConversionExists to remove ambiguity.
14268 * ecore.cs (NullCast): New type of cast expression class which
14269 basically is very similar to EmptyCast with the difference being
14270 it still is a constant since it is used only to cast a null to
14272 (eg. (string) null)
14274 * convert.cs (ImplicitReferenceConversion): When casting a null
14275 literal, we return a NullCast.
14277 * literal.cs (NullLiteralTyped): Remove - I don't see why this
14278 should be around anymore.
14280 The renaming (reported was slightly wrong). Corrections:
14282 ConvertImplicitStandard -> ImplicitConversionStandard
14283 ConvertExplicitStandard -> ExplicitConversionStandard
14285 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
14286 before passing them in !
14288 * convert.cs (ImplicitConversionStandard): When comparing for
14289 equal expr and target types, ensure that expr is not a
14292 In general, we must not be checking (expr_type ==
14293 target_type) in the top level conversion methods
14294 (ImplicitConversion, ExplicitConversion etc). This checking is
14295 done in the methods that they delegate to.
14297 2003-05-20 Miguel de Icaza <miguel@ximian.com>
14299 * convert.cs: Move Error_CannotConvertType,
14300 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
14301 ImplicitNumericConversion, ImplicitConversionExists,
14302 ImplicitUserConversionExists, StandardConversionExists,
14303 FindMostEncompassedType, FindMostSpecificSource,
14304 FindMostSpecificTarget, ImplicitUserConversion,
14305 ExplicitUserConversion, GetConversionOperators,
14306 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
14307 TryImplicitIntConversion, Error_CannotConvertImplicit,
14308 ConvertImplicitRequired, ConvertNumericExplicit,
14309 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
14310 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
14313 Perform the following renames:
14315 StandardConversionExists -> ImplicitStandardConversionExists
14316 ConvertImplicit -> ImplicitConversion
14317 ConvertImplicitStandard -> ImplicitStandardConversion
14318 TryImplicitIntConversion -> ImplicitIntConversion
14319 ConvertImplicitRequired -> ImplicitConversionRequired
14320 ConvertNumericExplicit -> ExplicitNumericConversion
14321 ConvertReferenceExplicit -> ExplicitReferenceConversion
14322 ConvertExplicit -> ExplicitConversion
14323 ConvertExplicitStandard -> ExplicitStandardConversion
14325 2003-05-19 Martin Baulig <martin@ximian.com>
14327 * statement.cs (TypeInfo.StructInfo): Made this type protected.
14328 (TypeInfo): Added support for structs having structs as fields.
14330 * ecore.cs (FieldExpr): Implement IVariable.
14331 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
14332 VariableInfo for the field.
14334 2003-05-18 Martin Baulig <martin@ximian.com>
14336 * expression.cs (This.DoResolve): Report a CS0027 if we're
14337 emitting a field initializer.
14339 2003-05-18 Martin Baulig <martin@ximian.com>
14341 * expression.cs (This.ResolveBase): New public function.
14342 (This.DoResolve): Check for CS0188.
14344 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
14347 * ecore.cs (MethodGroupExpr.DoResolve): Set the
14348 `instance_expression' to null if we don't have any non-static
14351 2003-05-18 Martin Baulig <martin@ximian.com>
14353 Reworked the way how local variables and parameters are handled by
14354 the flow analysis code.
14356 * statement.cs (TypeInfo, VariableMap): New public classes.
14357 (VariableInfo): New public class. This is now responsible for
14358 checking whether a variable has been assigned. It is used for
14359 parameters and local variables.
14360 (Block.EmitMeta): Take the InternalParameters as argument; compute
14361 the layout of the flow vectors here.
14362 (Block.LocalMap, Block.ParameterMap): New public properties.
14363 (FlowBranching): The .ctor doesn't get the InternalParameters
14364 anymore since Block.EmitMeta() now computes the layout of the flow
14366 (MyStructInfo): This class is now known as `StructInfo' and nested
14367 in `TypeInfo'; we don't access this directly anymore.
14369 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
14370 property and removed IsAssigned(), IsFieldAssigned(),
14371 SetAssigned() and SetFieldAssigned(); we now call them on the
14372 VariableInfo so we don't need to duplicate this code everywhere.
14374 * expression.cs (ParameterReference): Added `Block block' argument
14376 (LocalVariableReference, ParameterReference, This): The new
14377 VariableInfo class is now responsible for all the definite
14380 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
14381 IsParameterAssigned, SetParameterAssigned): Removed.
14383 2003-05-18 Martin Baulig <martin@ximian.com>
14385 * typemanager.cs (InitCoreTypes): Try calling
14386 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
14387 the 3-args-version. Corlib now also needs our `void_type'.
14388 (GetMethod): Added overloaded version which takes an optional
14389 `bool report_errors' to allow lookups of optional methods.
14391 2003-05-12 Martin Baulig <martin@ximian.com>
14393 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
14394 only used for locals and not for parameters.
14396 2003-05-12 Miguel de Icaza <miguel@ximian.com>
14398 * support.cs (InternalParameters.ParameterType): Return the
14399 ExternalType of the parameter.
14401 * parameter.cs (Parameter.ExternalType): drop the two arguments,
14404 2003-05-11 Miguel de Icaza <miguel@ximian.com>
14406 * class.cs (MethodData.Define): Do not set the `newslot' on
14407 interface members, if they are also flagged as "override".
14409 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
14410 better code for ++i and i++. This only works for static fields
14411 and local variables.
14413 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
14414 want to pull the DeclSpace out of the builder_to_declspace instead
14415 of the TypeBuilder (like in TypeContainer.FindMembers).
14417 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
14418 instead of LookupTypeContainer. Fixes the crash on .NET for
14419 looking up interface members.
14421 * const.cs: Create our own emit context during the Definition
14422 stage, so that constants are evaluated in the proper context, when
14423 a recursive definition happens.
14425 2003-05-11 Martin Baulig <martin@ximian.com>
14427 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
14428 new block for a switch section.
14429 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
14430 the adding/lookup in the switch block. Fixes #39828.
14432 2003-05-09 Miguel de Icaza <miguel@ximian.com>
14434 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
14435 functionality: I needed to convert the data after I had performed
14436 the add/sub operation into the operands type size.
14438 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
14439 pass the type for the box operation, otherwise the resulting
14440 object would have been of type object.
14442 (BoxedCast): Add constructor to specify the type to box as.
14444 2003-05-07 Miguel de Icaza <miguel@ximian.com>
14446 * iterators.cs: I was reusing the `count' variable inadvertently,
14447 take steps to not allow this to happen.
14449 2003-05-06 Miguel de Icaza <miguel@ximian.com>
14451 * attribute.cs (Attribute.Resolve): Params attributes are encoded
14452 by creating an array at the point where the params starts and
14453 putting all those arguments there, then adjusting the size of the
14456 2003-05-05 Miguel de Icaza <miguel@ximian.com>
14458 * expression.cs (New.AddressOf): Implement interface
14459 IMemoryLocation. This is used when the `new' operator is used in
14460 the context of an invocation to a method on a value type.
14462 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
14465 * namespace.cs: Also check the using aliases here.
14467 * driver.cs: Move the test for using validity after the types have
14468 been entered, so we do a single pass that also includes the using
14471 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
14472 in the regular case. CreateSiblingForFinally is doing extra
14475 * attribute.cs (GetAttributeArgumentExpression): Store the result
14476 on an out value, and use the return value to indicate failure
14477 instead of using null (which is a valid return for Constant.GetValue).
14479 * statement.cs: Perform the analysis flow for the increment
14480 portion after the statement, because this will be the real flow of
14481 execution. Fixes #42385
14483 * codegen.cs (EmitContext.EmitArgument,
14484 EmitContext.EmitStoreArgument): New helper functions when the
14485 RemapToProxy flag is set.
14487 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
14490 Add support for remapping parameters.
14492 * iterators.cs: Propagate parameter values; Store parameter
14493 values in the proxy classes.
14495 2003-05-04 Miguel de Icaza <miguel@ximian.com>
14497 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
14498 need a proxy reference; I do not know what I was thinking
14500 * cs-parser.jay (constructor_initializer): catch another error,
14501 and display nice message.
14503 (field_declaration): catch void field declaration
14504 to flag a better error.
14506 * class.cs (MemberBase.CheckBase): Report an error instead of a
14507 warning if a new protected member is declared in a struct.
14508 (Field.Define): catch the error of readonly/volatile.
14510 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
14512 (FieldExpr.AddressOf): ditto. Catch error where the address of a
14513 volatile variable is taken
14515 2003-05-02 Miguel de Icaza <miguel@ximian.com>
14517 * statement.cs (Fixed.Resolve): Report an error if we are not in
14520 2003-05-01 Miguel de Icaza <miguel@ximian.com>
14522 * typemanager.cs: reuse the code that handles type clashes for
14523 delegates and enumerations.
14525 * class.cs (Report28): Always report.
14527 * expression.cs (EncodeAsAttribute): Allow nulls here.
14529 2003-04-28 Miguel de Icaza <miguel@ximian.com>
14531 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
14532 the functionality for testing whether an expression is valid for
14533 an attribute here. Also handle the case of arrays of elements
14536 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
14537 encoding a linear array into an array of objects that are suitable
14538 to be passed to an CustomAttributeBuilder.
14540 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
14542 * ecore.cs: (FieldExpr): Handle field remapping here.
14544 * iteratators.cs: Pass the instance variable (if the method is an
14545 instance method) to the constructors, so we can access the field
14546 variables on the class.
14548 TODO: Test this with structs. I think the THIS variable on
14549 structs might have to be a pointer, and not a refenrece
14551 2003-04-27 Miguel de Icaza <miguel@ximian.com>
14553 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
14554 local variables to fields in a proxy class.
14556 * iterators.cs (PopulateProxy): Rename our internal fields to
14558 Create a <THIS> field if we are an instance method, so we can
14559 reference our parent container variables.
14560 (MapVariable): Called back from the EmitContext code to enter a
14561 new variable to field mapping into the proxy class (we just create
14565 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
14566 for using the remapped locals to fields.
14568 I placed the code here, because that gives the same semantics to
14569 local variables, and only changes the Emit code.
14571 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
14572 statements inside iterators.
14573 (VariableInfo): Add a FieldBuilder for the cases when we are
14574 remapping local variables to fields in a proxy class
14576 * ecore.cs (SimpleNameResolve): Avoid testing two times for
14577 current_block != null.
14579 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
14580 not cope with strings, as it has been moved to the
14581 TableSwitchEmit. Fixed bug in switch generation.
14583 * expression.cs (New.DoResolve): Provide more context for the user
14584 when reporting an error.
14586 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
14589 * expression.cs (MemberAccess.DoResolve): When we get a type back,
14590 check the permissions for it. Note than in a type-resolution
14591 context the check was already present in DeclSpace.ResolveType,
14592 but was missing from the MemberAccess.
14594 (ArrayCreation.CheckIndices): warn if the user has
14595 more nested levels of expressions, but there are no more
14596 dimensions specified. Avoids crash on bug 41906.
14598 2003-04-26 Miguel de Icaza <miguel@ximian.com>
14600 * statement.cs (Block): replace Implicit bool, for a generic
14602 New flag: `Unchecked'. This is used during the EmitMeta phase
14603 (which is out-of-line with the regular Resolve/Emit process for a
14604 statement, as this is done ahead of time, but still gets a chance
14605 to call constant resolve).
14607 (Block.Flags): new enum for adding a new flag.
14609 (Block.EmitMeta): track the state of unchecked.
14611 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
14612 to enable constant resolution to work there as well.
14614 2003-04-22 Miguel de Icaza <miguel@ximian.com>
14616 * typemanager.cs (ienumerable_type): Also look up
14617 System.Collections.IEnumerable.
14619 2003-04-21 Miguel de Icaza <miguel@ximian.com>
14621 TODO: Test more than one conditional per method.
14623 * class.cs (Indexer.Define): Report the location where the user is
14624 referencing the unsupported feature.
14626 (MethodData): Overload the use of `conditionals' to
14627 minimize the creation of needless ArrayLists. This saves roughly
14628 212kb on my machine.
14630 (Method): Implement the new IIteratorContainer interface.
14631 (Method.SetYields): Implement the method by setting the ModFlags
14632 to contain METHOD_YIELDS.
14634 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
14635 which just got set to null.
14637 * iterators.cs: New file.
14639 (Yield, YieldBreak): New statements.
14641 * statement.cs (Return.Resolve): Flag an error if we are used in
14642 an iterator method.
14644 * codegen.cs (InIterator): New flag set if the code is being
14645 compiled in an iterator method.
14647 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
14648 internal modifier, and we just use it to avoid adding extra
14649 fields, as this is seldom used.
14651 * cs-parser.jay: Add yield_statement (yield and yield break).
14653 * driver.cs: New flag -v2 to turn on version 2 features.
14655 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
14656 hashtable when v2 is enabled.
14658 2003-04-20 Miguel de Icaza <miguel@ximian.com>
14660 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
14661 there is already a namespace defined with this name.
14663 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
14664 people upgraded their corlibs.
14666 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
14667 always use fully qualified types, no need to use the compiler
14670 (TypeManager.IsNamespace): Use binarysearch.
14672 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
14673 AddDelegate): I did not quite use the new IsValid API properly: I
14674 have to pass the short-name and the fullname. I was passing only
14675 the basename instead of the fullname sometimes.
14677 (TypeContainer.DefineType): call NamespaceClash.
14679 * interface.cs (Interface.DefineType): use NamespaceClash before
14682 * delegate.cs (Delegate.DefineType): use NamespaceClash before
14685 * enum.cs: (Enum.DefineType): use NamespaceClash before
14688 * typemanager.cs (: 3-line patch that gives us some tasty 11%
14689 speed increase. First, use the negative_hits cache when we get a
14690 negative. Second, add the type with its full original name
14691 instead of the new . and + encoded name (reflection uses + to
14692 separate type from a nested type). Use LookupTypeReflection
14693 directly which bypasses the type->name hashtable (that we already
14694 know does not contain the type.
14696 * decl.cs (DeclSpace.ResolveTypeExpr): track the
14697 location/container type.
14699 * driver.cs: When passing utf8, use directly the UTF8Encoding.
14701 2003-04-19 Miguel de Icaza <miguel@ximian.com>
14703 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
14705 * delegate.cs (NewDelegate.Resolve): Test whether an instance
14706 method is being referenced in the method group from a static
14707 context, and report error 120 if so.
14709 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
14712 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
14713 is created, we create the A namespace).
14715 * cs-parser.jay: A namespace also introduces a DeclarationFound.
14718 2003-04-18 Miguel de Icaza <miguel@ximian.com>
14720 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
14721 invocation to ModuleBuilder.GetType with the same values will
14722 return a new type instance, so we need to cache its return
14725 * expression.cs (Binary.ResolveOperator): Only allow the compare
14726 operators on enums if they are of the same type.
14728 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
14729 types of ValueType on their own case. Before we were giving them
14730 the same treatment as objects.
14732 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
14733 fullname. Short name is used to compare against container name.
14734 Fullname is used to check against defined namespace names.
14736 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
14737 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
14739 (Method.CheckBase): Call parent.
14740 (MemberBase.CheckBase): Check for protected members on sealed
14742 (PropertyBase.CheckBase): Call parent.
14743 (Field.Define): Call parent.
14745 * report.cs: Negative error codes are now mapped to 8000 - code,
14746 so that the display is render more nicely.
14748 * typemanager.cs: Do not use try/catch, instead report a regular
14751 (GetPointerType, GetReferenceType): These methods provide
14752 mechanisms to obtain the T* and T& from a T. We had the code
14753 previously scattered around the code base, and it also used
14754 TypeManager.LookupType that would go through plenty of caches.
14755 This one goes directly to the type source.
14757 In some places we did the Type.GetType followed by
14758 ModuleBuilder.GetType, but not in others, so this unifies the
14759 processing as well.
14761 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
14762 statements now that we have namespace information.
14764 * typemanager.cs (IsNamespace): New method, returns whether the
14765 string presented is a namespace or not.
14767 (ComputeNamespaces): New public entry point, computes the list of
14768 available namespaces, using the GetNamespaces API call in Mono, or
14769 the slower version in MS.NET.
14771 Now before we start the semantic analysis phase, we have a
14772 complete list of namespaces including everything that the user has
14775 Deleted old code to cache namespaces in .nsc files.
14777 2003-04-17 Miguel de Icaza <miguel@ximian.com>
14779 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
14780 class/struct location definition Location for the implicit
14781 constructor location.
14783 (Operator.Define): Use the location of the operator for the
14784 implicit Method definition.
14786 (Constructor.Emit): use the constructor location for the implicit
14787 base initializer constructor.
14789 * ecore.cs: Remove ITypeExpression. This interface is now gone,
14790 and the Expression class now contains two new methods:
14792 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
14793 isolate type lookup from the rest of the resolution process.
14795 Since we use Expressions to hold type definitions due to the way
14796 we parse the input we have historically overloaded Resolve to
14797 perform the Type lookups if a special flag is passed. Now this is
14798 eliminated and two methods take their place.
14800 The differences in the two methods between xStep and xTerminal is
14801 that xStep is involved in our current lookup system that uses
14802 SimpleNames to compose a name, while xTerminal is used just to
14803 catch the case where the simplename lookup failed.
14805 2003-04-16 Miguel de Icaza <miguel@ximian.com>
14807 * expression.cs (ResolveMemberAccess): Remove redundant code.
14808 TypeExpr expressions are always born fully resolved.
14810 * interface.cs (PopulateMethod): Do not lookup the types twice.
14811 We were doing it once during SemanticAnalysis and once during
14814 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
14815 in local variable type definitions, were being returned as a
14816 SimpleName (we decomposed everything into a string), that is
14817 because primary_expression was being used instead of a type in the
14818 grammar (reduce/reduce conflicts).
14820 The part that was wrong is that we converted the expression into a
14821 string (an oversimplification in one hand, compounded with primary
14822 expressions doing string concatenation).
14828 Would return "A.B.C[]" as a SimpleName. This stopped things like
14829 using clauses from working on this particular context. And a type
14830 was being matched directly against "A.B.C[]".
14832 We now use the correct approach, and allow for ComposedCast to be
14833 part of the unary expression. So the "A.B.C []" become a composed
14834 cast of "A.B.C" (as a nested group of MemberAccess with a
14835 SimpleName at the end) plus the rank composition "[]".
14839 2003-04-10 Miguel de Icaza <miguel@ximian.com>
14841 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
14842 for the access level checking.
14844 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
14845 `TypeContainer container', because I kept getting confused when I
14846 was debugging this code.
14848 * expression.cs (Indexers): Instead of tracking getters/setters,
14849 we now track them in parallel. We create one arraylist less, but
14850 most importantly it is possible now for the LValue code to find a
14851 matching get for a set.
14853 (IndexerAccess.DoResolveLValue): Update the code.
14854 GetIndexersForType has been modified already to extract all the
14855 indexers from a type. The code assumed it did not.
14857 Also make the code set the correct return type for the indexer.
14858 This was fixed a long time ago for properties, but was missing for
14859 indexers. It used to be void_type.
14861 (Binary.Emit): Test first for doubles instead of
14862 floats, as they are more common.
14864 (Binary.EmitBranchable): Use the .un version of the branch opcodes
14865 when dealing with floats and the <=, >= operators. This fixes bug
14868 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
14869 to load the array value by emitting a load on the foreach variable
14870 type. This was incorrect.
14872 We now emit the code to load an element using the the array
14873 variable type, and then we emit the conversion operator.
14877 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
14879 * attribute.cs: Avoid allocation of ArrayLists in the common case.
14881 2003-04-09 Miguel de Icaza <miguel@ximian.com>
14883 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
14884 test for protection before we test for signatures.
14886 (MethodSignature.ToString): implement.
14888 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
14889 to the case where we reduced into a LongConstant.
14891 * decl.cs (CheckAccessLevel): If the type is an array, we can not
14892 depend on whether the information is acurrate, because the
14893 Microsoft runtime will always claim that the array type is public,
14894 regardless of the real state.
14896 If the type is a pointer, another problem happens: the type is
14897 reported as non-public in Microsoft.
14899 In both cases we have to call CheckAccessLevel recursively with
14900 the underlying type as the argument to be tested.
14902 2003-04-08 Miguel de Icaza <miguel@ximian.com>
14904 * assign.cs (Assign.Emit): If we are dealing with a compound
14905 assignment expression, we should use the code path that stores the
14906 intermediate result in a temporary value. This fixes #40903.
14908 *expression.cs (Indirection.ToString): Provide ToString method for
14911 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
14913 * class.cs: Null out fields holding references to Block objects so
14914 they can be garbage collected.
14916 * expression.cs (OverloadResolve): Remove unused local.
14918 2003-04-07 Martin Baulig <martin@ximian.com>
14920 * codegen.cs (EmitContext.CurrentFile): New public field.
14921 (EmitContext.Mark): Use the CurrentFile to check whether the
14922 location is in the correct file.
14923 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
14925 2003-04-07 Martin Baulig <martin@ximian.com>
14927 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
14929 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
14930 location. [FIXME: The location argument which gets passed to this
14931 method is sometimes wrong!]
14933 2003-04-07 Nick Drochak <ndrochak@gol.com>
14935 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
14937 2003-04-07 Miguel de Icaza <miguel@ximian.com>
14939 * expression.cs (Indirection.EmitAssign): We were using the
14940 temporary, but returning immediately instead of continuing the
14943 2003-04-06 Martin Baulig <martin@ximian.com>
14945 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
14946 if it's a nested child, but also deriving from the outer class.
14949 * typemanager.cs (IsNestedChildOf): Make this work if it's a
14950 nested child, but also deriving from the outer class. See
14952 (FilterWithClosure): We may access private members of the outer
14953 class if we're a nested child and deriving from the outer class.
14954 (RealMemberLookup): Only set `closure_private_ok' if the
14955 `original_bf' contained BindingFlags.NonPublic.
14957 2003-04-05 Martin Baulig <martin@ximian.com>
14959 * expression.cs (SizeOf.DoResolve): Use ResolveTypeExpr, so we can
14960 probe if its a type parameter, and if so, flag an error.
14962 * decl.cs: Move here the SetParameterInfo code from class.cs.
14963 Handle IsGeneric here.
14965 Handle a variety of errors in the parameter info definition.
14967 * ecore.cs (SimpleName.DoResolveType): Handle look ups for generic
14968 type parameters here.
14970 * cs-parser.jay (class_declaration): report errors for parameters
14973 2003-01-21 Miguel de Icaza <miguel@ximian.com>
14975 * generic.cs: New file, contains support code for generics.
14977 * cs-parser.jay: Remove OP_SHIFT_LEFT, OP_SHIFT_RIGHT,
14978 OP_SHIFT_LEFT_ASSIGN, OP_SHIFT_RIGHT_ASSIGN.
14980 Update parser for the above removals.
14982 * cs-tokenizer.cs: Do not handle <<= or >>= specially. This is
14983 now taken care of in the parser.
14985 2003-04-02 Miguel de Icaza <miguel@ximian.com>
14987 * class.cs (Event.Define): Do not allow abstract events to have
14990 2003-04-01 Miguel de Icaza <miguel@ximian.com>
14992 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
14993 block in event declarations.
14995 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
14996 value type, get its address.
14998 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
14999 leaving a class on the stack instead of a boolean value (int
15000 0/1). Change the code so we compare against null, and then the
15001 result against zero.
15003 * class.cs (TypeContainer.GetClassBases): We were checking for the
15004 parent class being sealed too late.
15006 * expression.cs (Binary.Emit): For <= and >= when dealing with
15007 floating point values, use cgt.un and clt.un instead of cgt and
15010 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
15012 * statement.cs: Apply the same optimization as MS: skip the
15013 GetEnumerator returning an IEnumerator, and use the one returning a
15014 CharEnumerator instead. This allows us to avoid the try-finally block
15017 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
15019 * cs-parser.jay: Attributes cannot be applied to
15020 namespaces. Fixes #40473
15022 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
15025 (Add*): check if the name is valid using the full name for constants,
15026 fields, properties and events.
15028 2003-03-28 Miguel de Icaza <miguel@ximian.com>
15030 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
15031 char constants to be part of the enumeration.
15033 * expression.cs (Conditional.DoResolve): Add support for operator
15034 true. Implements the missing functionality from 14.12
15036 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
15037 operator true/false as required by the spec.
15039 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
15040 implicit conversion to boolean.
15042 * statement.cs (Statement.ResolveBoolean): A boolean expression is
15043 also one where the type implements `operator true'.
15045 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
15046 get an expression that will invoke operator true based on an
15049 (GetConversionOperators): Removed the hack that called op_True
15052 (Expression.ResolveBoolean): Move this from Statement.
15054 2003-03-17 Miguel de Icaza <miguel@ximian.com>
15056 * ecore.cs (FieldExpr): do not allow initialization of initonly
15057 fields on derived classes
15059 2003-03-13 Martin Baulig <martin@ximian.com>
15061 * statement.cs (Block.Emit): Call ig.BeginScope() and
15062 ig.EndScope() when compiling with debugging info; call
15063 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
15065 2003-03-08 Miguel de Icaza <miguel@ximian.com>
15067 * expression.cs (Indexers): Do not construct immediately, allow
15068 for new members to be appended as we go. Fixes 38143
15070 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
15072 * expression.cs: save/restore context when resolving an unchecked
15075 2003-03-05 Miguel de Icaza <miguel@ximian.com>
15077 * cfold.cs: Catch division by zero in modulus operator during
15080 2003-03-03 Miguel de Icaza <miguel@ximian.com>
15082 * interface.cs (Interface.DefineMembers): Avoid defining members
15085 2003-02-27 Miguel de Icaza <miguel@ximian.com>
15087 * driver.cs: handle the +/- options for -noconfig
15089 * statement.cs (Unckeched.Resolve): Also track the state of
15090 unchecked in the Resolve phase.
15092 2003-02-27 Martin Baulig <martin@ximian.com>
15094 * ecore.cs (Expression.MemberLookup): Don't create a
15095 MethodGroupExpr for something which is not a method. Fixes #38291.
15097 2003-02-25 Miguel de Icaza <miguel@ximian.com>
15099 * class.cs (MemberBase.CheckParameters): Also check that the type
15100 is unmanaged if it is a pointer.
15102 * expression.cs (SizeOf.Resolve): Add location information.
15104 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
15105 a managed type is declared.
15107 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
15108 parameter modifiers as well. Fixes bug 38606
15110 * class.cs: Very sad. Am backing out the speed up changes
15111 introduced by the ArrayList -> Array in the TypeContainer, as they
15112 were not actually that much faster, and introduced a bug (no error
15113 reports on duplicated methods).
15115 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
15116 source first, this will guarantee that we have a valid expression
15117 before calling in lower levels functions that will require a
15118 resolved object. Then use this original_source in the
15119 target.ResolveLValue instead of the original source that was
15122 Another change. Use target.Resolve instead of LValueResolve.
15123 Although we are resolving for LValues, we will let the Assign code
15124 take care of that (it will be called again from Resolve). This
15125 basically allows code like this:
15127 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
15128 class Y { void A (X x) { x [0] += o; }
15130 The problem was that the indexer was trying to resolve for
15131 set_Item (idx, object o) and never finding one. The real set_Item
15132 was set_Item (idx, X). By delaying the process we get the right
15137 2003-02-23 Martin Baulig <martin@ximian.com>
15139 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
15140 while calling DoEmit ().
15142 * codegen.cs (EmitContext.Mark): Don't mark locations in other
15143 source files; if you use the #line directive inside a method, the
15144 compiler stops emitting line numbers for the debugger until it
15145 reaches the end of the method or another #line directive which
15146 restores the original file.
15148 2003-02-23 Martin Baulig <martin@ximian.com>
15150 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
15152 2003-02-23 Martin Baulig <martin@ximian.com>
15154 * statement.cs (Block.AddChildVariableNames): We need to call this
15155 recursively, not just for our immediate children.
15157 2003-02-23 Martin Baulig <martin@ximian.com>
15159 * class.cs (Event.Define): Always make the field private, like csc does.
15161 * typemanager.cs (TypeManager.RealMemberLookup): Make events
15162 actually work, fixes bug #37521.
15164 2003-02-23 Miguel de Icaza <miguel@ximian.com>
15166 * delegate.cs: When creating the various temporary "Parameters"
15167 classes, make sure that we call the ComputeAndDefineParameterTypes
15168 on those new parameters (just like we do with the formal ones), to
15169 allow them to be resolved in the context of the DeclSpace.
15171 This fixes the bug that Dick observed in Bugzilla #38530.
15173 2003-02-22 Miguel de Icaza <miguel@ximian.com>
15175 * expression.cs (ResolveMemberAccess): When resolving a constant,
15176 do not attempt to pull a constant if the value was not able to
15177 generate a valid constant.
15179 * const.cs (LookupConstantValue): Do not report more errors than required.
15181 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
15183 * expression.cs: fixes bug #38328.
15185 2003-02-18 Miguel de Icaza <miguel@ximian.com>
15187 * class.cs: Changed all the various members that can be part of a
15188 class from being an ArrayList to be an Array of the right type.
15189 During the DefineType type_list, interface_list, delegate_list and
15190 enum_list are turned into types, interfaces, delegates and enums
15193 And during the member population, indexer_list, event_list,
15194 constant_list, field_list, instance_constructor_list, method_list,
15195 operator_list and property_list are turned into their real arrays.
15197 Although we could probably perform this operation earlier, for
15198 good error reporting we need to keep the lists and remove the
15199 lists for longer than required.
15201 This optimization was triggered by Paolo profiling the compiler
15202 speed on the output of `gen-sample-program.pl' perl script.
15204 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
15205 not crash in methods like MemberLookupFailed that use this field.
15207 This problem arises when the compiler fails to resolve a type
15208 during interface type definition for example.
15210 2003-02-18 Miguel de Icaza <miguel@ximian.com>
15212 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
15213 inherit from System.Object, so we have to stop at null, not only
15214 when reaching System.Object.
15216 2003-02-17 Miguel de Icaza <miguel@ximian.com>
15218 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
15219 DeclaredOnly because the parent indexer might have had a different
15220 name, but did not loop until the top of the hierarchy was reached.
15222 The problem this one fixes is 35492: when a class implemented an
15223 indexer from an interface, we were getting the interface method
15224 (which was abstract) and we were flagging an error (can not invoke
15227 This also keeps bug 33089 functioning, and test-148 functioning.
15229 * typemanager.cs (IsSpecialMethod): The correct way of figuring
15230 out if a method is special is to see if it is declared in a
15231 property or event, or whether it is one of the predefined operator
15232 names. This should fix correctly #36804.
15234 2003-02-15 Miguel de Icaza <miguel@ximian.com>
15236 The goal here is to remove the dependency on EmptyCast.Peel ().
15237 Killing it completely.
15239 The problem is that currently in a number of places where
15240 constants are expected, we have to "probe" for an EmptyCast, and
15241 Peel, which is not the correct thing to do, as this will be
15242 repetitive and will likely lead to errors.
15244 The idea is to remove any EmptyCasts that are used in casts that
15245 can be reduced to constants, so we only have to cope with
15248 This bug hunt was triggered by Bug 37363 and the desire to remove
15249 the duplicate pattern where we were "peeling" emptycasts to check
15250 whether they were constants. Now constants will always be
15253 * ecore.cs: Use an enumconstant here instead of wrapping with
15256 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
15257 throwing me off. By handling this we can get rid of a few hacks.
15259 * statement.cs (Switch): Removed Peel() code.
15261 2003-02-14 Miguel de Icaza <miguel@ximian.com>
15263 * class.cs: Location information for error 508
15265 * expression.cs (New.DoResolve): Add a guard against double
15266 resolution of an expression.
15268 The New DoResolve might be called twice when initializing field
15269 expressions (see EmitFieldInitializers, the call to
15270 GetInitializerExpression will perform a resolve on the expression,
15271 and later the assign will trigger another resolution
15273 This leads to bugs (#37014)
15275 * delegate.cs: The signature for EndInvoke should contain any ref
15276 or out parameters as well. We were not doing this in the past.
15278 * class.cs (Field.Define): Do not overwrite the type definition
15279 inside the `volatile' group. Turns out that volatile enumerations
15280 were changing the type here to perform a validity test, which
15283 2003-02-12 Miguel de Icaza <miguel@ximian.com>
15285 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
15286 and structs, we do not want to load the instance variable
15288 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
15289 enum_type has to be handled like an object reference (implicit
15290 conversions exists from this to object), but the regular IsClass
15291 and IsValueType tests will never return true for this one.
15293 Also we use TypeManager.IsValueType instead of type.IsValueType,
15294 just for consistency with the rest of the code (this is only
15295 needed if we ever use the construct exposed by test-180.cs inside
15296 corlib, which we dont today).
15298 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
15300 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
15303 2003-02-09 Martin Baulig <martin@ximian.com>
15305 * namespace.cs (Namespace..ctor): Added SourceFile argument.
15306 (Namespace.DefineNamespaces): New static public method; this is
15307 called when we're compiling with debugging to add all namespaces
15308 to the symbol file.
15310 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
15311 pass it to the Namespace's .ctor.
15313 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
15314 and MethodBase arguments; pass the namespace ID to the symwriter;
15315 pass the MethodBase instead of the token to the symwriter.
15316 (SymbolWriter.DefineNamespace): New method to add a namespace to
15319 2003-02-09 Martin Baulig <martin@ximian.com>
15321 * symbolwriter.cs: New file. This is a wrapper around
15322 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
15323 methods here in near future.
15325 2003-02-09 Martin Baulig <martin@ximian.com>
15327 * codegen.cs (EmitContext.Mark): Just pass the arguments to
15328 ILGenerator.MarkSequencePoint() which are actually used by the
15331 2003-02-09 Martin Baulig <martin@ximian.com>
15333 * location.cs (SourceFile): New public sealed class. This
15334 contains the name and an index which is used in the location's token.
15335 (Location): Reserve an appropriate number of bits in the token for
15336 the source file instead of walking over that list, this gives us a
15337 really huge performance improvement when compiling with debugging.
15339 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
15340 `SourceFile' argument instead of a string.
15341 (Driver.ProcessFile): Add all the files via Location.AddFile(),
15342 but don't parse/tokenize here, we need to generate the list of all
15343 source files before we do that.
15344 (Driver.ProcessFiles): New static function. Parses/tokenizes all
15347 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
15348 instead of a string.
15350 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
15353 2003-02-09 Martin Baulig <martin@ximian.com>
15355 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
15356 filename on `#line default'.
15358 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
15360 * statement.cs: don't clear the pinned var when the fixed statement
15361 returns from the method (fixes bug#37752).
15363 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
15365 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
15368 2003-02-07 Martin Baulig <martin@ximian.com>
15370 * driver.cs: Removed the `--debug-args' command line argument.
15372 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
15373 automatically by the AsssemblyBuilder.
15374 (CodeGen.InitializeSymbolWriter): We don't need to call any
15375 initialization function on the symbol writer anymore. This method
15376 doesn't take any arguments.
15378 2003-02-03 Miguel de Icaza <miguel@ximian.com>
15380 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
15381 from referenced assemblies as well.
15383 2003-02-02 Martin Baulig <martin@ximian.com>
15385 * class.cs (MethodData.Emit): Generate debugging info for external methods.
15387 2003-02-02 Martin Baulig <martin@ximian.com>
15389 * class.cs (Constructor.Emit): Open the symbol writer before
15390 emitting the constructor initializer.
15391 (ConstructorInitializer.Emit): Call ec.Mark() to allow
15392 single-stepping through constructor initializers.
15394 2003-01-30 Miguel de Icaza <miguel@ximian.com>
15396 * class.cs: Handle error 549: do not allow virtual methods in
15399 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
15401 * decl.cs: Check access levels when resolving types
15403 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
15405 * statement.cs: Add parameters and locals set in catch blocks that might
15406 return to set vector
15408 2003-01-29 Miguel de Icaza <miguel@ximian.com>
15410 * class.cs (Operator): Set the SpecialName flags for operators.
15412 * expression.cs (Invocation.DoResolve): Only block calls to
15413 accessors and operators on SpecialName methods.
15415 (Cast.TryReduce): Handle conversions from char constants.
15418 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
15420 * statement.cs: small memory and time optimization in FlowBranching.
15422 2003-01-28 Pedro Mart <yoros@wanadoo.es>
15424 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
15425 problem that the last fix but in the other sid (Set).
15427 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
15428 access when there is no indexer in the hierarchy.
15430 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
15432 * class.cs: Combine some if statements.
15434 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
15436 * driver.cs: fixed bug #37187.
15438 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
15440 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
15441 any indexer, it's needed to build a list with all the indexers in the
15442 hierarchy (AllGetters), else we have problems. Fixes #35653.
15444 2003-01-23 Miguel de Icaza <miguel@ximian.com>
15446 * class.cs (MethodData.Define): It is wrong for an interface
15447 implementation to be static in both cases: explicit and implicit.
15448 We were only handling this in one case.
15450 Improve the if situation there to not have negations.
15452 * class.cs (Field.Define): Turns out that we do not need to check
15453 the unsafe bit on field definition, only on usage. Remove the test.
15455 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
15457 * driver.cs: use assembly.Location instead of Codebase (the latest
15458 patch made mcs fail when using MS assemblies).
15460 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
15462 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
15463 get the path to *corlib.dll.
15465 2003-01-21 Nick Drochak <ndrochak@gol.com>
15469 * typemanager.cs: Remove compiler warnings
15471 2003-01-20 Duncan Mak <duncan@ximian.com>
15473 * AssemblyInfo.cs: Bump the version number to 0.19.
15475 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
15477 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
15479 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
15481 * class.cs (Constructor::Emit): Emit debugging info for constructors.
15483 2003-01-17 Miguel de Icaza <miguel@ximian.com>
15485 * cs-parser.jay: Small fix: we were not comparing the constructor
15486 name correctly. Thanks to Zoltan for the initial pointer.
15488 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
15490 * cs-tokenizer.cs: Set file name when specified with #line
15492 2003-01-15 Miguel de Icaza <miguel@ximian.com>
15494 * cs-parser.jay: Only perform the constructor checks here if we
15495 are named like the class; This will help provider a better
15496 error. The constructor path is taken when a type definition is
15497 not found, but most likely the user forgot to add the type, so
15498 report that rather than the constructor error.
15500 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
15502 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
15505 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
15507 * cs-parser.jay: Add cleanup call.
15509 2003-01-13 Duncan Mak <duncan@ximian.com>
15511 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
15512 consistent with other methods.
15514 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
15516 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
15518 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
15520 * attribute.cs: only set GuidAttr to true when we have a
15523 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
15527 * typemanager.cs: fixes to allow mcs compile corlib with the new
15528 Type.IsSubclassOf fix.
15530 2003-01-08 Miguel de Icaza <miguel@ximian.com>
15532 * expression.cs (LocalVariableReference.DoResolve): Classify a
15533 constant as a value, not as a variable. Also, set the type for
15536 * cs-parser.jay (fixed_statement): take a type instead of a
15537 pointer_type, so we can produce a better error message later.
15539 * statement.cs (Fixed.Resolve): Flag types that are not pointers
15542 (For.DoEmit): Make inifinite loops have a
15543 non-conditional branch back.
15545 (Fixed.DoEmit): First populate the pinned variables, then emit the
15546 statement, then clear the variables. Before I was emitting the
15547 code once for each fixed piece.
15550 2003-01-08 Martin Baulig <martin@ximian.com>
15552 * statement.cs (FlowBranching.MergeChild): A break in a
15553 SWITCH_SECTION does not leave a loop. Fixes #36155.
15555 2003-01-08 Martin Baulig <martin@ximian.com>
15557 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
15558 lives in the same number space than `param_map'. Fixes #36154.
15560 2003-01-07 Miguel de Icaza <miguel@ximian.com>
15562 * cs-parser.jay (constructor_declaration): Set the
15563 Constructor.ModFlags before probing for it. This makes the
15564 compiler report 514, 515 and 132 (the code was there, but got
15567 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
15568 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
15569 (GotoCase.Resolve): Set `Returns' to ALWAYS.
15571 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
15573 * enum.cs: create the enum static fields using the enum type.
15575 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
15577 * class.cs: don't try to create the ParamBuilder for the return
15578 type if it's not needed (and handle it breaking for the ms runtime
15581 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
15583 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
15585 2002-12-29 Miguel de Icaza <miguel@ximian.com>
15587 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
15588 the command. This showed up while compiling the JANET source
15589 code, which used \r as its only newline separator.
15591 2002-12-28 Miguel de Icaza <miguel@ximian.com>
15593 * class.cs (Method.Define): If we are an operator (because it
15594 reuses our code), then set the SpecialName and HideBySig. #36128
15596 2002-12-22 Miguel de Icaza <miguel@ximian.com>
15598 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
15599 exception, report error 120 `object reference required'.
15601 * driver.cs: Add --pause option, used during to measure the size
15602 of the process as it goes with --timestamp.
15604 * expression.cs (Invocation.DoResolve): Do not allow methods with
15605 SpecialName to be invoked.
15607 2002-12-21 Miguel de Icaza <miguel@ximian.com>
15609 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
15610 number before adding it.
15612 2002-12-21 Ravi Pratap <ravi@ximian.com>
15614 * ecore.cs (StandardImplicitConversion): When in an unsafe
15615 context, we allow conversion between void * to any other pointer
15616 type. This fixes bug #35973.
15618 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
15620 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
15621 is not thrown when extensionless outputs are used
15623 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
15625 * rootcontext.cs: fixed compilation of corlib.
15627 2002-12-19 Miguel de Icaza <miguel@ximian.com>
15629 * attribute.cs (Attributes.Contains): Add new method.
15631 * class.cs (MethodCore.LabelParameters): if the parameter is an
15632 `out' parameter, check that no attribute `[In]' has been passed.
15634 * enum.cs: Handle the `value__' name in an enumeration.
15636 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
15638 * decl.cs: Added special case to allow overrides on "protected
15641 2002-12-18 Ravi Pratap <ravi@ximian.com>
15643 * attribute.cs (Attributes.AddAttributeSection): Rename to this
15644 since it makes much more sense.
15646 (Attributes.ctor): Don't require a Location parameter.
15648 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
15650 * attribute.cs (ApplyAttributes): Remove extra Location parameters
15651 since we already have that information per attribute.
15653 * everywhere : make appropriate changes.
15655 * class.cs (LabelParameters): Write the code which actually
15656 applies attributes to the return type. We can't do this on the MS
15657 .NET runtime so we flag a warning in the case an exception is
15660 2002-12-18 Miguel de Icaza <miguel@ximian.com>
15662 * const.cs: Handle implicit null conversions here too.
15664 2002-12-17 Ravi Pratap <ravi@ximian.com>
15666 * class.cs (MethodCore.LabelParameters): Remove the extra
15667 Type [] parameter since it is completely unnecessary. Instead
15668 pass in the method's attributes so that we can extract
15669 the "return" attribute.
15671 2002-12-17 Miguel de Icaza <miguel@ximian.com>
15673 * cs-parser.jay (parse): Use Report.Error to flag errors instead
15674 of ignoring it and letting the compile continue.
15676 * typemanager.cs (ChangeType): use an extra argument to return an
15677 error condition instead of throwing an exception.
15679 2002-12-15 Miguel de Icaza <miguel@ximian.com>
15681 * expression.cs (Unary.TryReduce): mimic the code for the regular
15682 code path. Perform an implicit cast in the cases where we can
15683 implicitly convert to one of the integral types, and then reduce
15684 based on that constant. This fixes bug #35483.
15686 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
15688 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
15690 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
15692 * namespace.cs: fixed bug #35489.
15694 2002-12-12 Miguel de Icaza <miguel@ximian.com>
15696 * class.cs: Remove some dead code.
15698 * cs-parser.jay: Estimate the number of methods needed
15699 (RootContext.MethodCount);
15701 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
15702 numbers instead of StringBuilders.
15704 * support.cs (PtrHashtable): Add constructor with initial size;
15705 We can now reduce reallocations of the method table.
15707 2002-12-10 Ravi Pratap <ravi@ximian.com>
15709 * attribute.cs (ApplyAttributes): Keep track of the emitted
15710 attributes on a per-target basis. This fixes bug #35413.
15712 2002-12-10 Miguel de Icaza <miguel@ximian.com>
15714 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
15715 default to the Windows 1252 encoding.
15717 (UnixParseOption): Support version, thanks to Alp for the missing
15720 * AssemblyInfo.cs: Add nice assembly information.
15722 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
15725 * cs-parser.jay: Allow a trailing comma before the close bracked
15726 in the attribute_section production.
15728 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
15729 address of the instance was being taken, I will take this out,
15730 because we take the address of the object immediately here.
15732 2002-12-09 Ravi Pratap <ravi@ximian.com>
15734 * typemanager.cs (AreMultipleAllowed): Take care of the most
15735 obvious case where attribute type is not in the current assembly -
15738 2002-12-08 Miguel de Icaza <miguel@ximian.com>
15740 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
15741 definitions, instead of doing that afterwards.
15743 Also we use a nice little hack, depending on the constructor, we
15744 know if we are a "composed" name or a simple name. Hence, we
15745 avoid the IndexOf test, and we avoid
15747 * codegen.cs: Add code to assist in a bug reporter to track down
15748 the source of a compiler crash.
15750 2002-12-07 Ravi Pratap <ravi@ximian.com>
15752 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
15753 types have been emitted for a given element and flag an error
15754 if something which does not have AllowMultiple set is used more
15757 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
15758 attribute types and their corresponding AllowMultiple properties
15760 (AreMultipleAllowed): Check the property for a given type.
15762 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
15763 property in the case we have a TypeContainer.
15765 (Attributes.AddAttribute): Detect duplicates and just skip on
15766 adding them. This trivial fix catches a pretty gross error in our
15767 attribute emission - global attributes were being emitted twice!
15769 Bugzilla bug #33187 is now fixed.
15771 2002-12-06 Miguel de Icaza <miguel@ximian.com>
15773 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
15774 instead of pp_and).
15776 * expression.cs (Binary.ResolveOperator): I can only use the
15777 Concat (string, string, string) and Concat (string, string,
15778 string, string) if the child is actually a concatenation of
15781 2002-12-04 Miguel de Icaza <miguel@ximian.com>
15783 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
15784 context where we need a 2-character lookahead.
15786 * pending.cs (PendingImplementation): Rework so we can keep track
15787 of interface types all the time, and flag those which were
15788 implemented by parents as optional.
15790 2002-12-03 Miguel de Icaza <miguel@ximian.com>
15792 * expression.cs (Binary.ResolveOperator): Use
15793 String.Concat(string,string,string) or
15794 String.Concat(string,string,string,string) when possible.
15796 * typemanager: More helper methods.
15799 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
15801 * pending.cs: remove the bogus return from GetMissingInterfaces()
15802 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
15804 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
15806 * namespace.cs: avoid duplicated 'using xxx' being added to
15807 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
15808 when we get more than one 'using' statement for the same namespace.
15809 Report a CS0105 warning for it.
15811 2002-11-30 Miguel de Icaza <miguel@ximian.com>
15813 * cs-tokenizer.cs (consume_identifier): use read directly, instead
15814 of calling getChar/putback, uses internal knowledge of it.
15816 (xtoken): Reorder tokenizer so most common patterns are checked
15817 first. This reduces the compilation time in another 5% (from 8.11s
15818 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
15820 The parsing time is 22% of the compilation in mcs, and from that
15821 64% is spent on the tokenization process.
15823 I tried using a binary search for keywords, but this is slower
15824 than the hashtable. Another option would be to do a couple of
15827 * Not use a StringBuilder, instead use an array of chars,
15828 with a set value. Notice that this way we could catch
15829 the 645 error without having to do it *afterwards*.
15831 * We could write a hand-parser to avoid the hashtable
15832 compares altogether.
15834 The identifier consumption process takes 37% of the tokenization
15835 time. Another 15% is spent on is_number. 56% of the time spent
15836 on is_number is spent on Int64.Parse:
15838 * We could probably choose based on the string length to
15839 use Int32.Parse or Int64.Parse and avoid all the 64-bit
15842 Another 3% is spend on wrapping `xtoken' in the `token' function.
15844 Handle 0xa0 as whitespace (#34752)
15846 2002-11-26 Miguel de Icaza <miguel@ximian.com>
15848 * typemanager.cs (IsCLRType): New routine to tell whether a type
15849 is one of the builtin types.
15851 Maybe it needs to use TypeCodes to be faster. Maybe we could use
15852 typecode in more places instead of doing pointer comparissions.
15853 We could leverage some knowledge about the way the typecodes are
15856 New code to cache namespaces in assemblies, it is currently not
15857 invoked, to be used soon.
15859 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
15861 * expression.cs (Binary.ResolveOperator): specially handle
15862 strings, and do not perform user-defined operator overloading for
15865 2002-11-24 Miguel de Icaza <miguel@ximian.com>
15867 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
15868 internalcall as it is a pretty simple operation; Avoid whenever
15869 possible to call Char.IsLetter.
15871 (consume_identifier): Cut by half the number of
15872 hashtable calls by merging the is_keyword and GetKeyword behavior.
15874 Do not short-circuit, because if we do, we
15875 report errors (ie, #if false && true would produce an invalid
15879 2002-11-24 Martin Baulig <martin@ximian.com>
15881 * expression.cs (Cast.TryReduce): If we're in checked syntax,
15882 check constant ranges and report a CS0221. Fixes #33186.
15884 2002-11-24 Martin Baulig <martin@ximian.com>
15886 * cs-parser.jay: Make this work for uninitialized variable
15887 declarations in the `for' initializer. Fixes #32416.
15889 2002-11-24 Martin Baulig <martin@ximian.com>
15891 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
15892 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
15894 2002-11-24 Martin Baulig <martin@ximian.com>
15896 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
15897 argument; if true, we also check for user-defined conversions.
15898 This is only needed if both arguments are of a user-defined type.
15899 Fixes #30443, added test-175.cs.
15900 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
15902 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
15904 2002-11-24 Martin Baulig <martin@ximian.com>
15906 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
15907 function to get the store opcode.
15908 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
15909 only emit the Ldelema if the store opcode is Stobj. You must run
15910 both test-34 and test-167 to test this. Fixes #34529.
15912 2002-11-23 Martin Baulig <martin@ximian.com>
15914 * ecore.cs (Expression.MemberLookup): Added additional
15915 `qualifier_type' argument which is used when we're being called
15916 from MemberAccess.DoResolve() and null if we're called from a
15918 (Expression.MemberLookupFailed): New method to report errors; this
15919 does the CS1540 check and reports the correct error message.
15921 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
15922 argument for the CS1540 check and redone the way how we're dealing
15923 with private members. See the comment in the source code for details.
15924 (FilterWithClosure): Reverted this back to revision 1.197; renamed
15925 `closure_start_type' to `closure_qualifier_type' and check whether
15926 it's not null. It was not this filter being broken, it was just
15927 being called with the wrong arguments.
15929 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
15930 and pass it the correct `qualifier_type'; this also does the error
15933 2002-11-22 Miguel de Icaza <miguel@ximian.com>
15935 * expression.cs (Invocation.EmitParams): If the we are dealing
15936 with a non-built-in value type, load its address as well.
15938 (ArrayCreation): Use a a pretty constant instead
15939 of the hardcoded value 2. Use 6 instead of 2 for the number of
15940 static initializers.
15942 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
15943 because they are not really value types, just glorified integers.
15945 * driver.cs: Do not append .exe, the CSC compiler does not do it.
15947 * ecore.cs: Remove redundant code for enumerations, make them use
15948 the same code path as everything else, fixes the casting issue
15949 with enumerations in Windows.Forms.
15951 * attribute.cs: Do only cast to string if it is a string, the
15952 validation happens later.
15954 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
15955 people upgrade their corlibs.
15957 * ecore.cs: Oops, enumerations were not following the entire code path
15959 2002-11-21 Miguel de Icaza <miguel@ximian.com>
15961 * typemanager.cs (FilterWithClosure): Commented out the test for
15962 1540 in typemanager.cs, as it has problems when accessing
15963 protected methods from a parent class (see test-174.cs).
15965 * attribute.cs (Attribute.ValidateGuid): new method.
15966 (Attribute.Resolve): Use above.
15968 2002-11-19 Miguel de Icaza <miguel@ximian.com>
15970 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
15972 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
15973 handling for enumerations, as we only needed the TypeContainer
15974 functionality to begin with (this is required for the fix below to
15975 work for enums that reference constants in a container class for
15978 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
15980 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
15981 a valid TypeBuilder to perform lookups on.o
15983 * class.cs (InheritableMemberSignatureCompare): Use true in the
15984 call to GetGetMethod and GetSetMethod, because we are comparing
15985 the signature, and we need to get the methods *even* if they are
15988 (PropertyBase.CheckBase): ditto.
15990 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
15991 GotoCase.Resolve): Use Peel on EmpytCasts.
15993 * ecore.cs (EmptyCast): drop child, add Peel method.
15995 2002-11-17 Martin Baulig <martin@ximian.com>
15997 * ecore.cs (EmptyCast.Child): New public property.
15999 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
16000 label resolved to an EmptyCast. Fixes #34162.
16001 (GotoCase.Resolve): Likewise.
16002 (Block.EmitMeta): Likewise.
16004 2002-11-17 Martin Baulig <martin@ximian.com>
16006 * expression.cs (Invocation.BetterConversion): Prefer int over
16007 uint; short over ushort; long over ulong for integer literals.
16008 Use ImplicitConversionExists instead of StandardConversionExists
16009 since we also need to check for user-defined implicit conversions.
16010 Fixes #34165. Added test-173.cs.
16012 2002-11-16 Martin Baulig <martin@ximian.com>
16014 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
16015 with the `true' and `false' literals. Fixes #33151.
16017 2002-11-16 Martin Baulig <martin@ximian.com>
16019 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
16020 October 22nd; don't do the cs1540 check for static members.
16022 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
16023 now using our own filter here and doing the cs1540 check again.
16025 2002-11-16 Martin Baulig <martin@ximian.com>
16027 * support.cs (InternalParameters): Don't crash if we don't have
16028 any fixed parameters. Fixes #33532.
16030 2002-11-16 Martin Baulig <martin@ximian.com>
16032 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
16033 when looking up static methods to make this work on Windows.
16036 2002-11-16 Martin Baulig <martin@ximian.com>
16038 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
16039 a setter rather than using PropertyInfo.CanWrite.
16041 2002-11-15 Nick Drochak <ndrochak@gol.com>
16043 * class.cs: Allow acces to block member by subclasses. Fixes build
16046 2002-11-14 Martin Baulig <martin@ximian.com>
16048 * class.cs (Constructor.Emit): Added the extern/block check.
16051 2002-11-14 Martin Baulig <martin@ximian.com>
16053 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
16054 iteration while looking for indexers, this is needed because the
16055 indexer may have a different name in our base classes. Fixed the
16056 error reporting (no indexers at all, not get accessor, no
16057 overloaded match). Fixes bug #33089.
16058 (IndexerAccess.DoResolveLValue): Likewise.
16060 2002-11-14 Martin Baulig <martin@ximian.com>
16062 * class.cs (PropertyBase.CheckBase): Make this work for multiple
16063 indexers. Fixes the first part of bug #33089.
16064 (MethodSignature.InheritableMemberSignatureCompare): Added support
16067 2002-11-13 Ravi Pratap <ravi@ximian.com>
16069 * attribute.cs (Attribute.Resolve): Catch the
16070 NullReferenceException and report it since it isn't supposed to
16073 2002-11-12 Miguel de Icaza <miguel@ximian.com>
16075 * expression.cs (Binary.EmitBranchable): Also handle the cases for
16076 LogicalOr and LogicalAnd that can benefit from recursively
16077 handling EmitBranchable. The code now should be nice for Paolo.
16079 2002-11-08 Miguel de Icaza <miguel@ximian.com>
16081 * typemanager.cs (LookupType): Added a negative-hit hashtable for
16082 the Type lookups, as we perform quite a number of lookups on
16083 non-Types. This can be removed once we can deterministically tell
16084 whether we have a type or a namespace in advance.
16086 But this might require special hacks from our corlib.
16090 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
16091 and double which avoids a conversion from an integer to a double.
16093 * expression.cs: tiny optimization, avoid calling IsConstant,
16094 because it effectively performs the lookup twice.
16096 2002-11-06 Miguel de Icaza <miguel@ximian.com>
16098 But a bogus return here to keep the semantics of the old code
16099 until the Mono runtime is fixed.
16101 * pending.cs (GetMissingInterfaces): New method used to remove all
16102 the interfaces that are already implemented by our parent
16103 classes from the list of pending methods.
16105 * interface.cs: Add checks for calls after ResolveTypeExpr.
16107 2002-11-05 Miguel de Icaza <miguel@ximian.com>
16109 * class.cs (Class.Emit): Report warning 67: event not used if the
16110 warning level is beyond 3.
16112 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
16113 being a NullLiteral.
16115 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
16118 * class.cs (TypeContainer.GetClassBases): Cover a missing code
16119 path that might fail if a type can not be resolved.
16121 * expression.cs (Binary.Emit): Emit unsigned versions of the
16124 * driver.cs: use error 5.
16126 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
16128 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
16130 2002-11-01 Miguel de Icaza <miguel@ximian.com>
16132 * cs-parser.jay (switch_section): A beautiful patch from Martin
16133 Baulig that fixed 33094.
16135 2002-10-31 Miguel de Icaza <miguel@ximian.com>
16137 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
16138 Check whether the base is abstract and report an error if so.
16140 * expression.cs (IndexerAccess.DoResolveLValue,
16141 IndexerAccess.DoResolve): ditto.
16143 (Invocation.DoResolve): ditto.
16145 (Invocation.FullMethodDesc): Improve the report string.
16147 * statement.cs (Block): Eliminate IsVariableDefined as it is
16148 basically just a wrapper for GetVariableInfo.
16150 * ecore.cs (SimpleName): Use new
16152 * support.cs (ReflectionParamter.ParameterType): We unwrap the
16153 type, as we return the actual parameter ref/unref state on a
16156 2002-10-30 Miguel de Icaza <miguel@ximian.com>
16158 * support.cs: Return proper flags REF/OUT fixing the previous
16161 * expression.cs: Reverted last patch, that was wrong. Is_ref is
16162 not used to mean `ref' but `ref or out' in ParameterReference
16164 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
16165 full type signature instead of calling TypeManger.CSharpName
16168 * support.cs (InternalParameters.ParameterDesc): Do not compare
16169 directly to the modflags, because REF/OUT will actually be bitsets
16172 * delegate.cs (VerifyMethod): Check also the modifiers.
16174 * cs-tokenizer.cs: Fix bug where floating point values with an
16175 exponent where a sign was missing was ignored.
16177 * driver.cs: Allow multiple assemblies to be specified in a single
16180 2002-10-28 Miguel de Icaza <miguel@ximian.com>
16182 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
16183 because identifiers after a parenthesis would end up in this kind
16184 of production, and we needed to desamiguate it for having casts
16187 (UserDefinedType *) xxx
16189 2002-10-24 Miguel de Icaza <miguel@ximian.com>
16191 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
16192 we should set on the Bindingflags.NonPublic, but not turn on
16193 private_ok. private_ok controls whether a Private member is
16194 returned (this is chekced on the filter routine), while the
16195 BindingFlags.NonPublic just controls whether private/protected
16196 will be allowed. This fixes the problem part of the problem of
16197 private properties being allowed to be used in derived classes.
16199 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
16200 so we can call the children DoResolveLValue method (this will
16201 properly signal errors on lvalue assignments to base properties)
16203 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
16204 getter are null, and we have a property info, we know that this
16205 happened because the lookup failed, so we report an error 122 for
16206 protection level violation.
16208 We also silently return if setter and getter are null in the
16209 resolve functions, this condition only happens if we have flagged
16210 the error before. This is the other half of the problem.
16212 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
16213 not have accessibility information, that is why we were returning
16214 true in the filter function in typemanager.cs.
16216 To properly report 122 (property is inaccessible because of its
16217 protection level) correctly, we report this error in ResolveAccess
16218 by failing if both the setter and the getter are lacking (ie, the
16221 DoResolve and DoLResolve have been modified to check for both
16222 setter/getter being null and returning silently, the reason being
16223 that I did not want to put the knowledge about this error in upper
16226 int old = Report.Errors;
16227 x = new PropertyExpr (...);
16228 if (old != Report.Errors)
16233 So the property expr is returned, but it is invalid, so the error
16234 will be flagged during the resolve process.
16236 * class.cs: Remove InheritablePropertySignatureCompare from the
16237 class, as we no longer depend on the property signature to compute
16238 whether it is possible to implement a method or not.
16240 The reason is that calling PropertyInfo.GetGetMethod will return
16241 null (in .NET, in Mono it works, and we should change this), in
16242 cases where the Get Method does not exist in that particular
16247 class X { public virtual int A { get { return 1; } } }
16249 class Z : Y { public override int A { get { return 2; } } }
16251 Would fail in Z because the parent (Y) would not have the property
16252 defined. So we avoid this completely now (because the alternative
16253 fix was ugly and slow), and we now depend exclusively on the
16256 (PropertyBase.CheckBase): Use a method-base mechanism to find our
16257 reference method, instead of using the property.
16259 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
16260 routines are gone now.
16262 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
16263 names, they were incorrectly named.
16265 * cs-tokenizer.cs: Return are more gentle token on failure.
16267 * pending.cs (PendingImplementation.InterfaceMethod): This routine
16268 had an out-of-sync index variable, which caused it to remove from
16269 the list of pending methods the wrong method sometimes.
16271 2002-10-22 Miguel de Icaza <miguel@ximian.com>
16273 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
16274 CanWrite, because those refer to this particular instance of the
16275 property, and do not take into account the fact that we can
16276 override single members of a property.
16278 Constructor requires an EmitContext. The resolution process does
16279 not happen here, but we need to compute the accessors before,
16280 because the resolution does not always happen for properties.
16282 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
16283 subclass, before we did not update this flag, but we did update
16286 (GetAccessors): Drop this routine, as it did not work in the
16287 presence of partially overwritten set/get methods.
16289 Notice that this broke the cs1540 detection, but that will require
16292 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16296 * driver.cs: issue a warning instead of an error if we don't support
16297 debugging for the platform. Also ignore a couple of errors that may
16298 arise when trying to write the symbols. Undo my previous patch.
16300 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16302 * driver.cs: ignore /debug switch except for Unix platforms.
16304 2002-10-23 Nick Drochak <ndrochak@gol.com>
16306 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
16308 2002-10-21 Miguel de Icaza <miguel@ximian.com>
16310 * driver.cs: Do not make mcs-debug conditional, so we do not break
16311 builds that use it.
16313 * statement.cs (UsageVector.MergeChildren): I would like Martin to
16314 review this patch. But basically after all the children variables
16315 have been merged, the value of "Breaks" was not being set to
16316 new_breaks for Switch blocks. I think that it should be set after
16317 it has executed. Currently I set this to the value of new_breaks,
16318 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
16319 conservative, but I do not understand this code very well.
16321 I did not break anything in the build, so that is good ;-)
16323 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
16325 2002-10-20 Mark Crichton <crichton@gimp.org>
16327 * cfold.cs: Fixed compile blocker. Really fixed it this time.
16329 2002-10-20 Nick Drochak <ndrochak@gol.com>
16331 * cfold.cs: Fixed compile blocker.
16333 2002-10-20 Miguel de Icaza <miguel@ximian.com>
16335 * driver.cs: I was chekcing the key, not the file.
16337 2002-10-19 Ravi Pratap <ravi@ximian.com>
16339 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
16340 message that we were generating - we just need to silently return
16343 2002-10-19 Miguel de Icaza <miguel@ximian.com>
16345 * class.cs (Event.Define): Change my previous commit, as this
16346 breaks the debugger. This is a temporary hack, as it seems like
16347 the compiler is generating events incorrectly to begin with.
16349 * expression.cs (Binary.ResolveOperator): Added support for
16350 "U operator - (E x, E y)"
16352 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
16355 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
16356 init-only variables, but this path did not take into account that
16357 there might be also instance readonly variables. Correct this
16360 This fixes bug 32253
16362 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
16365 * driver.cs: Change the extension for modules to `netmodule'
16367 * cs-parser.jay: Improved slightly the location tracking for
16368 the debugger symbols.
16370 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
16371 modifiers that were specified instead of the hardcoded value
16372 (FamAndAssem). This was basically ignoring the static modifier,
16373 and others. Fixes 32429.
16375 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
16376 fixed a bug in the process (32476)
16378 * expression.cs (ArrayAccess.EmitAssign): Patch from
16379 hwang_rob@yahoo.ca that fixes bug 31834.3
16381 2002-10-18 Miguel de Icaza <miguel@ximian.com>
16383 * driver.cs: Make the module extension .netmodule.
16385 2002-10-16 Miguel de Icaza <miguel@ximian.com>
16387 * driver.cs: Report an error if the resource file is not found
16388 instead of crashing.
16390 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
16391 false, like Emit does.
16393 2002-10-16 Nick Drochak <ndrochak@gol.com>
16395 * typemanager.cs: Remove unused private member. Also reported mcs
16396 bug to report this as a warning like csc.
16398 2002-10-15 Martin Baulig <martin@gnome.org>
16400 * statement.cs (Statement.Emit): Made this a virtual method; emits
16401 the line number info and calls DoEmit().
16402 (Statement.DoEmit): New protected abstract method, formerly knows
16403 as Statement.Emit().
16405 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
16407 2002-10-11 Miguel de Icaza <miguel@ximian.com>
16409 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
16410 have fixed a remaining problem: not every AddXXXX was adding a
16411 fully qualified name.
16413 Now everyone registers a fully qualified name in the DeclSpace as
16414 being defined instead of the partial name.
16416 Downsides: we are slower than we need to be due to the excess
16417 copies and the names being registered this way.
16419 The reason for this is that we currently depend (on the corlib
16420 bootstrap for instance) that types are fully qualified, because
16421 we dump all the types in the namespace, and we should really have
16422 types inserted into the proper namespace, so we can only store the
16423 basenames in the defined_names array.
16425 2002-10-10 Martin Baulig <martin@gnome.org>
16427 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
16428 from bug #31834, see the bug report for a testcase which is
16431 2002-10-10 Martin Baulig <martin@gnome.org>
16433 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
16434 flow analysis code for this.
16436 * statement.cs (Do, While, For): Tell the flow analysis code about
16438 (FlowBranching.UsageVector): Added support for infinite loops.
16439 (Block.Resolve): Moved the dead code elimination here and use flow
16442 2002-10-09 Miguel de Icaza <miguel@ximian.com>
16444 * class.cs (Field.Define): Catch cycles on struct type
16447 * typemanager.cs (IsUnmanagedtype): Do not recursively check
16448 fields if the fields are static. We only need to check instance
16451 * expression.cs (As.DoResolve): Test for reference type.
16453 * statement.cs (Using.ResolveExpression): Use
16454 ConvertImplicitRequired, not ConvertImplicit which reports an
16456 (Using.ResolveLocalVariableDecls): ditto.
16458 * expression.cs (Binary.ResolveOperator): Report errors in a few
16459 places where we had to.
16461 * typemanager.cs (IsUnmanagedtype): Finish implementation.
16463 2002-10-08 Miguel de Icaza <miguel@ximian.com>
16465 * expression.cs: Use StoreFromPtr instead of extracting the type
16466 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
16468 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
16469 an enumeration value to a System.Enum, but System.Enum is not a
16470 value type, but an class type, so we need to box.
16472 (Expression.ConvertExplicit): One codepath could return
16473 errors but not flag them. Fix this. Fixes #31853
16475 * parameter.cs (Resolve): Do not allow void as a parameter type.
16477 2002-10-06 Martin Baulig <martin@gnome.org>
16479 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
16480 if it's a class type and not a struct. Fixes #31815.
16482 2002-10-06 Martin Baulig <martin@gnome.org>
16484 * statement.cs: Reworked the flow analysis code a bit to make it
16485 usable for dead code elimination.
16487 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16489 * cs-parser.jay: allow empty source files. Fixes bug #31781.
16491 2002-10-04 Miguel de Icaza <miguel@ximian.com>
16493 * expression.cs (ComposedCast.DoResolveType): A quick workaround
16494 to fix the test 165, will investigate deeper.
16496 2002-10-04 Martin Baulig <martin@gnome.org>
16498 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
16499 finally blocks actually work.
16500 (Try.Resolve): We don't need to create a sibling for `finally' if
16501 there is no finally block.
16503 2002-10-04 Martin Baulig <martin@gnome.org>
16505 * class.cs (Constructor.Define): The default accessibility for a
16506 non-default constructor is private, not public.
16508 2002-10-04 Miguel de Icaza <miguel@ximian.com>
16510 * class.cs (Constructor): Make AllowedModifiers public, add
16513 * cs-parser.jay: Perform the modifiers test here, as the
16514 constructor for the Constructor class usually receives a zero
16515 because of the way we create it (first we create, later we
16516 customize, and we were never checking the modifiers).
16518 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
16519 is a version of LookupTypeReflection that includes the type-name
16520 cache. This can be used as a fast path for functions that know
16521 the fully qualified name and are only calling into *.GetType() to
16522 obtain a composed type.
16524 This is also used by TypeManager.LookupType during its type
16527 (LookupType): We now also track the real type name, as sometimes
16528 we can get a quey for the real type name from things like
16529 ComposedCast. This fixes bug 31422.
16531 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
16532 complete type fullname, it does not have to go through the type
16533 resolution system to obtain the composed version of the type (for
16534 obtaining arrays or pointers).
16536 (Conditional.Emit): Use the EmitBoolExpression to
16537 generate nicer code, as requested by Paolo.
16539 (ArrayCreation.CheckIndices): Use the patch from
16540 hwang_rob@yahoo.ca to validate the array initializers.
16542 2002-10-03 Miguel de Icaza <miguel@ximian.com>
16544 * class.cs (ConstructorInitializer.Emit): simplify code by using
16545 Invocation.EmitCall, and at the same time, fix the bugs in calling
16546 parent constructors that took variable arguments.
16548 * ecore.cs (Expression.ConvertNumericExplicit,
16549 Expression.ImplicitNumericConversion): Remove the code that
16550 manually wrapped decimal (InternalTypeConstructor call is now gone
16553 * expression.cs (Cast.TryReduce): Also handle decimal types when
16554 trying to perform a constant fold on the type.
16556 * typemanager.cs (IsUnmanagedtype): Partially implemented.
16558 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
16559 that only turned off an error report, and did nothing else.
16561 2002-10-02 Miguel de Icaza <miguel@ximian.com>
16563 * driver.cs: Handle and ignore /fullpaths
16565 2002-10-01 Miguel de Icaza <miguel@ximian.com>
16567 * expression.cs (Binary.ResolveOperator): Catch the case where
16568 DoNumericPromotions returns true,
16570 (Binary.DoNumericPromotions): Simplify the code, and the tests.
16572 2002-09-27 Miguel de Icaza <miguel@ximian.com>
16574 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
16577 2002-09-26 Miguel de Icaza <miguel@ximian.com>
16579 * ecore.cs (ConvertNumericExplicit): It is not enough that the
16580 conversion exists, but it is also required that the conversion be
16581 performed. This manifested in "(Type64Enum) 2".
16583 * class.cs (TypeManager.AddMethod): The fix is not to change
16584 AddEnum, because that one was using a fully qualified name (every
16585 DeclSpace derivative does), but to change the AddMethod routine
16586 that was using an un-namespaced name. This now correctly reports
16587 the duplicated name.
16589 Revert patch until I can properly fix it. The issue
16590 is that we have a shared Type space across all namespaces
16591 currently, which is wrong.
16593 Options include making the Namespace a DeclSpace, and merge
16594 current_namespace/current_container in the parser.
16596 2002-09-25 Miguel de Icaza <miguel@ximian.com>
16598 * cs-parser.jay: Improve error reporting when we get a different
16599 kind of expression in local_variable_type and
16600 local_variable_pointer_type.
16602 Propagate this to avoid missleading errors being reported.
16604 * ecore.cs (ImplicitReferenceConversion): treat
16605 TypeManager.value_type as a target just like object_type. As
16610 Is valid, and needs to result in the int 1 being boxed before it
16611 is assigned to the value type v.
16613 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
16614 to validate the enumeration name.
16616 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
16617 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
16618 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
16620 * ecore.cs (TryImplicitIntConversion): When doing an
16621 implicit-enumeration-conversion, check if the type is 64-bits and
16622 perform a conversion before passing to EnumConstant.
16624 2002-09-23 Miguel de Icaza <miguel@ximian.com>
16626 * decl.cs (Error_AmbiguousTypeReference); New routine used to
16627 report ambiguous type references. Unlike the MS version, we
16628 report what the ambiguity is. Innovation at work ;-)
16630 (DeclSpace.FindType): Require a location argument to
16631 display when we display an ambiguous error.
16633 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
16635 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
16637 * expression.cs (EmitDynamicInitializers): Apply patch from
16638 hwang_rob@yahoo.ca that fixes the order in which we emit our
16641 2002-09-21 Martin Baulig <martin@gnome.org>
16643 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
16644 delegate takes no arguments.
16646 2002-09-20 Miguel de Icaza <miguel@ximian.com>
16648 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
16651 * expression.cs: Extract the underlying type.
16653 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
16655 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
16657 2002-09-19 Miguel de Icaza <miguel@ximian.com>
16659 * class.cs (TypeContainer.DefineType): We can not use the nice
16660 PackingSize with the size set to 1 DefineType method, because it
16661 will not allow us to define the interfaces that the struct
16664 This completes the fixing of bug 27287
16666 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
16667 means also structs. This fixes part of the problem.
16668 (Expresion.ImplicitReferenceConversionExists): ditto.
16670 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
16671 error if there were no errors reported during the type lookup
16672 process, to avoid duplicates or redundant errors. Without this
16673 you would get an ambiguous errors plus a type not found. We have
16674 beaten the user enough with the first error.
16676 (DeclSparce.FindType): Emit a warning if we have an ambiguous
16679 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
16680 during the resolution process, stop the lookup, this avoids
16681 repeated error reports (same error twice).
16683 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
16685 * typemanager.cs (LookupType): Redo the type lookup code to match
16686 the needs of System.Reflection.
16688 The issue is that System.Reflection requires references to nested
16689 types to begin with a "+" sign instead of a dot. So toplevel
16690 types look like: "NameSpace.TopLevelClass", and nested ones look
16691 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
16694 2002-09-19 Martin Baulig <martin@gnome.org>
16696 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
16697 says that a method always returns or always throws an exception,
16698 don't report the CS0161.
16700 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
16701 set `Returns = new_returns'.
16703 2002-09-19 Martin Baulig <martin@gnome.org>
16705 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
16706 to an enum constant, check for a CS0176.
16708 2002-09-18 Miguel de Icaza <miguel@ximian.com>
16710 * class.cs (TypeContainer.CheckPairedOperators): Now we check
16711 for operators that must be in pairs and report errors.
16713 * ecore.cs (SimpleName.DoResolveType): During the initial type
16714 resolution process, when we define types recursively, we must
16715 check first for types in our current scope before we perform
16716 lookups in the enclosing scopes.
16718 * expression.cs (MakeByteBlob): Handle Decimal blobs.
16720 (Invocation.VerifyArgumentsCompat): Call
16721 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
16722 I thought we were supposed to always call this, but there are a
16723 few places in the code where we dont do it.
16725 2002-09-17 Miguel de Icaza <miguel@ximian.com>
16727 * driver.cs: Add support in -linkres and -resource to specify the
16728 name of the identifier.
16730 2002-09-16 Miguel de Icaza <miguel@ximian.com>
16732 * ecore.cs (StandardConversionExists): Sync with the conversion
16733 code: allow anything-* to void* conversions.
16735 (FindMostSpecificSource): Use an Expression argument
16736 instead of a Type, because we might be handed over a Literal which
16737 gets a few more implicit conversions that plain types do not. So
16738 this information was being lost.
16740 Also, we drop the temporary type-holder expression when not
16743 2002-09-17 Martin Baulig <martin@gnome.org>
16745 * class.cs (PropertyBase.CheckBase): Don't check the base class if
16746 this is an explicit interface implementation.
16748 2002-09-17 Martin Baulig <martin@gnome.org>
16750 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
16751 different `IndexerName' attributes.
16753 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
16754 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
16755 virtual CommonResolve().
16757 2002-09-16 Miguel de Icaza <miguel@ximian.com>
16759 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
16760 and convert that to the UnderlyingType.
16762 * statement.cs (Foreach.Resolve): Indexers are just like variables
16763 or PropertyAccesses.
16765 * cs-tokenizer.cs (consume_string): Track line numbers and columns
16766 inside quoted strings, we were not doing this before.
16768 2002-09-16 Martin Baulig <martin@gnome.org>
16770 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
16771 resolve it. This is needed for the definite assignment check of the
16772 instance expression, fixes bug #29846.
16773 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
16775 2002-09-16 Nick Drochak <ndrochak@gol.com>
16777 * parameter.cs: Fix compile error. Cannot reference static member
16778 from an instance object. Is this an mcs bug?
16780 2002-09-14 Martin Baulig <martin@gnome.org>
16782 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
16783 multiple times. Fixes bug #30295, added test-166.cs.
16785 2002-09-14 Martin Baulig <martin@gnome.org>
16787 * statement.cs (Block.Emit): Don't emit unreachable code.
16788 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
16789 `break' statements.
16790 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
16792 2002-09-14 Martin Baulig <martin@gnome.org>
16794 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
16797 2002-09-14 Martin Baulig <martin@gnome.org>
16799 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
16800 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
16801 be false on the ms runtime.
16803 2002-09-13 Martin Baulig <martin@gnome.org>
16805 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
16806 the CS0038 error message.
16808 2002-09-12 Miguel de Icaza <miguel@ximian.com>
16810 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
16811 constant inside, return it.
16813 2002-09-12 Martin Baulig <martin@gnome.org>
16815 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
16816 implicit conversion can be done between enum types.
16818 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
16819 check whether an implicit conversion to the current enum's UnderlyingType
16820 exists and report an error if not.
16822 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
16823 without debugging support.
16825 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
16826 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
16828 2002-09-12 Martin Baulig <martin@gnome.org>
16830 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
16832 * ecore.cs (IMemberExpr.DeclaringType): New property.
16833 (SimpleName.SimpleNameResolve): Check whether we're accessing a
16834 nonstatic member of an outer type (CS0038).
16836 2002-09-11 Miguel de Icaza <miguel@ximian.com>
16838 * driver.cs: Activate the using-error detector at warning level
16839 4 (at least for MS-compatible APIs).
16841 * namespace.cs (VerifyUsing): Small buglett fix.
16843 * pending.cs (PendingImplementation): pass the container pointer.
16845 * interface.cs (GetMethods): Allow for recursive definition. Long
16846 term, I would like to move every type to support recursive
16847 definitions, not the current ordering mechanism that we have right
16850 The situation is this: Attributes are handled before interfaces,
16851 so we can apply attributes to interfaces. But some attributes
16852 implement interfaces, we will now handle the simple cases
16853 (recursive definitions will just get an error).
16855 * parameter.cs: Only invalidate types at the end if we fail to
16858 2002-09-09 Martin Baulig <martin@gnome.org>
16860 * ecore.cs (PropertyExpr.Emit): Also check for
16861 TypeManager.system_int_array_get_length so this'll also work when
16862 compiling corlib. Fixes #30003.
16864 2002-09-09 Martin Baulig <martin@gnome.org>
16866 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
16867 and throw an exception if we can't get the type's size. Fixed #30040,
16870 2002-09-09 Martin Baulig <martin@gnome.org>
16872 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
16874 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
16875 context. Fixes bug #30027.
16877 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
16878 virtual functions. Fixes bug #30043, added test-164.cs.
16880 2002-09-08 Ravi Pratap <ravi@ximian.com>
16882 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
16884 2002-09-08 Nick Drochak <ndrochak@gol.com>
16886 * driver.cs: Use an object to get the windows codepage since it's not a
16889 2002-09-08 Miguel de Icaza <miguel@ximian.com>
16891 * statement.cs (For.Emit): for infinite loops (test == null)
16892 return whether there is a break inside, not always "true".
16894 * namespace.cs (UsingEntry): New struct to hold the name of the
16895 using definition, the location where it is defined, and whether it
16896 has been used in a successful type lookup.
16898 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
16903 2002-09-06 Ravi Pratap <ravi@ximian.com>
16905 * attribute.cs : Fix incorrect code which relied on catching
16906 a NullReferenceException to detect a null being passed in
16907 where an object was expected.
16909 2002-09-06 Miguel de Icaza <miguel@ximian.com>
16911 * statement.cs (Try): flag the catch variable as assigned
16913 * expression.cs (Cast): Simplified by using ResolveType instead of
16914 manually resolving.
16916 * statement.cs (Catch): Fix bug by using ResolveType.
16918 2002-09-06 Ravi Pratap <ravi@ximian.com>
16920 * expression.cs (BetterConversion): Special case for when we have
16921 a NullLiteral as the argument and we have to choose between string
16922 and object types - we choose string the way csc does.
16924 * attribute.cs (Attribute.Resolve): Catch the
16925 NullReferenceException and report error #182 since the Mono
16926 runtime no more has the bug and having this exception raised means
16927 we tried to select a constructor which takes an object and is
16930 2002-09-05 Ravi Pratap <ravi@ximian.com>
16932 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
16933 message (1502, 1503) when we can't locate a method after overload
16934 resolution. This is much more informative and closes the bug
16937 * interface.cs (PopulateMethod): Return if there are no argument
16938 types. Fixes a NullReferenceException bug.
16940 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
16941 expressions too. Previously we were checking only in one place for
16942 positional arguments leaving out named arguments.
16944 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
16945 type to the enum type is not allowed. Remove code corresponding to
16948 (ConvertNumericExplicit): Allow explicit conversions from
16949 the underlying type to enum type. This precisely follows the spec
16950 and closes a bug filed by Gonzalo.
16952 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16955 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
16957 2002-09-03 Miguel de Icaza <miguel@ximian.com>
16959 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
16960 it was important that we stored the right value after the
16961 reduction in `converted'.
16963 2002-09-04 Martin Baulig <martin@gnome.org>
16965 * location.cs (Location.SymbolDocument): Use full pathnames for the
16968 2002-08-30 Miguel de Icaza <miguel@ximian.com>
16970 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
16971 of the expression resolve mechanism, because that will catch the
16972 SimpleName error failures.
16974 (Conditional): If we can not resolve the
16975 expression, return, do not crash.
16977 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16980 (location): display token name instead of its number.
16982 2002-08-28 Martin Baulig <martin@gnome.org>
16984 * expression.cs (Binary.ResolveOperator): Don't silently return
16985 but return an error if an operator cannot be applied between two
16988 2002-08-28 Martin Baulig <martin@gnome.org>
16990 * class.cs (Constructor.Define): Set the permission attributes
16991 correctly instead of making all constructors public.
16993 2002-08-28 Martin Baulig <martin@gnome.org>
16995 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
16996 for private members before reporting a CS0103; if we find anything,
16999 2002-08-28 Martin Baulig <martin@gnome.org>
17001 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
17002 to check whether `closure_start_type == closure_invocation_type',
17003 we also need to check whether `m.DeclaringType == closure_invocation_type'
17004 before bypassing the permission checks. We might be accessing
17005 protected/private members from the base class.
17006 (TypeManager.RealMemberLookup): Only set private_ok if private
17007 members were requested via BindingFlags.NonPublic.
17009 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
17011 * expression.cs (MemberAccess.ResolveMemberAccess): Set
17012 MethodGroupExpr.IsExplicitImpl if appropriate.
17013 (Invocation.DoResolve): Don't report the CS0120 for explicit
17014 interface implementations.
17016 2002-08-27 Martin Baulig <martin@gnome.org>
17018 * expression.cs (Invocation.DoResolve): If this is a static
17019 method and we don't have an InstanceExpression, we must report
17022 2002-08-25 Martin Baulig <martin@gnome.org>
17024 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
17025 `==' between a valuetype and an object.
17027 2002-08-25 Miguel de Icaza <miguel@ximian.com>
17029 * ecore.cs (TypeExpr): Provide a ToString method.
17031 2002-08-24 Martin Baulig <martin@gnome.org>
17033 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
17034 now called proggie.dbg and it's a binary file.
17036 2002-08-23 Martin Baulig <martin@gnome.org>
17038 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
17040 2002-08-23 Martin Baulig <martin@gnome.org>
17042 * struct.cs (MyStructInfo.ctor): Make this work with empty
17043 structs; it's not allowed to use foreach() on null.
17045 2002-08-23 Martin Baulig <martin@gnome.org>
17047 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
17048 writer the full pathname of the generated assembly.
17050 2002-08-23 Martin Baulig <martin@gnome.org>
17052 * statements.cs (FlowBranching.UsageVector.MergeChildren):
17053 A `finally' block never returns or breaks; improved handling of
17056 2002-08-23 Martin Baulig <martin@gnome.org>
17058 * statement.cs (Throw.Resolve): Allow `throw null'.
17060 2002-08-23 Martin Baulig <martin@gnome.org>
17062 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
17063 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
17064 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
17065 MemberLookup would return a wrong event if this is an explicit
17066 interface implementation and the class has an event with the same
17069 2002-08-23 Martin Baulig <martin@gnome.org>
17071 * statement.cs (Block.AddChildVariableNames): New public method.
17072 (Block.AddChildVariableName): Likewise.
17073 (Block.IsVariableNameUsedInChildBlock): Likewise.
17074 (Block.AddVariable): Check whether a variable name has already
17075 been used in a child block.
17077 * cs-parser.jay (declare_local_variables): Mark all variable names
17078 from the current block as being used in a child block in the
17081 2002-08-23 Martin Baulig <martin@gnome.org>
17083 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
17084 find the symbol writer.
17086 * driver.cs: csc also allows the arguments to /define being
17087 separated by commas, not only by semicolons.
17089 2002-08-23 Martin Baulig <martin@gnome.org>
17091 * interface.cs (Interface.GetMembers): Added static check for events.
17093 2002-08-15 Martin Baulig <martin@gnome.org>
17095 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
17096 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
17098 * ecore.cs (Expression.MemberLookup): Added documentation and explained
17099 why the MethodData.EmitDestructor() change was necessary.
17101 2002-08-20 Martin Baulig <martin@gnome.org>
17103 * class.cs (TypeContainer.FindMembers): Added static check for events.
17105 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
17107 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
17108 use Type.GetEvents(), not Type.FindMembers().
17110 2002-08-20 Martin Baulig <martin@gnome.org>
17112 * decl.cs (MemberCache): Added a special method cache which will
17113 be used for method-only searched. This ensures that a method
17114 search will return a MethodInfo with the correct ReflectedType for
17117 2002-08-20 Martin Baulig <martin@gnome.org>
17119 * decl.cs (DeclSpace.FindMembers): Made this public.
17121 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17123 * delegate.cs: fixed build on windows.
17124 [FIXME: Filed as bug #29150: MCS must report these errors.]
17126 2002-08-19 Ravi Pratap <ravi@ximian.com>
17128 * ecore.cs (StandardConversionExists): Return a false
17129 if we are trying to convert the void type to anything else
17130 since that is not allowed.
17132 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
17133 we flag error 70 in the event an event is trying to be accessed
17134 directly from outside the declaring type.
17136 2002-08-20 Martin Baulig <martin@gnome.org>
17138 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
17139 MemberCache from typemanager.cs to decl.cs.
17141 2002-08-19 Martin Baulig <martin@gnome.org>
17143 * class.cs (TypeContainer): Implement IMemberContainer.
17144 (TypeContainer.DefineMembers): Create the MemberCache.
17145 (TypeContainer.FindMembers): Do better BindingFlags checking; only
17146 return public members if BindingFlags.Public was given, check
17147 whether members are static.
17149 2002-08-16 Martin Baulig <martin@gnome.org>
17151 * decl.cs (DeclSpace.Define): Splitted this in Define and
17152 DefineMembers. DefineMembers is called first and initializes the
17155 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
17156 DefineMembers() on all our DeclSpaces.
17158 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
17159 but call DefineMembers() on all nested interfaces. We call their
17160 Define() in our new Define() function.
17162 * interface.cs (Interface): Implement IMemberContainer.
17163 (Interface.Define): Moved all code except the attribute stuf to
17165 (Interface.DefineMembers): Initialize the member cache.
17167 * typemanager.cs (IMemberFinder): Removed this interface, we don't
17168 need this anymore since we can use MemberCache.FindMembers directly.
17170 2002-08-19 Martin Baulig <martin@gnome.org>
17172 * typemanager.cs (MemberCache): When creating the cache for an
17173 interface type, add all inherited members.
17174 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
17175 to `out bool used_cache' and documented it.
17176 (TypeManager.MemberLookup): If we already used the cache in the first
17177 iteration, we don't need to do the interfaces check.
17179 2002-08-19 Martin Baulig <martin@gnome.org>
17181 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
17182 here from IMemberFinder and don't implement this interface anymore.
17183 (DeclSpace.MemberCache): Moved here from IMemberFinder.
17185 * typemanager.cs (IMemberFinder): This interface is now only used by
17186 classes which actually support the member cache.
17187 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
17188 since we only put DeclSpaces into this Hashtable.
17189 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
17190 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
17192 2002-08-16 Martin Baulig <martin@gnome.org>
17194 * typemanager.cs (ICachingMemberFinder): Removed.
17195 (IMemberFinder.MemberCache): New property.
17196 (TypeManager.FindMembers): Merged this with RealFindMembers().
17197 This function will never be called from TypeManager.MemberLookup()
17198 so we can't use the cache here, just the IMemberFinder.
17199 (TypeManager.MemberLookup_FindMembers): Check whether the
17200 IMemberFinder has a MemberCache and call the cache's FindMembers
17202 (MemberCache): Rewrote larger parts of this yet another time and
17203 cleaned it up a bit.
17205 2002-08-15 Miguel de Icaza <miguel@ximian.com>
17207 * driver.cs (LoadArgs): Support quoting.
17209 (Usage): Show the CSC-like command line arguments.
17211 Improved a few error messages.
17213 2002-08-15 Martin Baulig <martin@gnome.org>
17215 * typemanager.cs (IMemberContainer.Type): New property.
17216 (IMemberContainer.IsInterface): New property.
17218 The following changes are conditional to BROKEN_RUNTIME, which is
17219 defined at the top of the file.
17221 * typemanager.cs (MemberCache.MemberCache): Don't add the base
17222 class'es members, but add all members from TypeHandle.ObjectType
17223 if we're an interface.
17224 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
17225 is the current type.
17226 (MemberCache.CacheEntry.Container): Removed this field.
17227 (TypeHandle.GetMembers): Include inherited members.
17229 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17231 * typemanager.cs: fixed compilation and added a comment on a field that
17234 2002-08-15 Martin Baulig <martin@gnome.org>
17236 * class.cs (ConstructorInitializer.Resolve): In the
17237 Expression.MemberLookup call, use the queried_type as
17240 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
17241 declared' attribute, it's always true.
17242 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
17243 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
17244 temporary wrapper for FindMembers which tells MemberLookup whether
17245 members from the base classes are included in the return value.
17246 This will go away soon.
17247 (TypeManager.MemberLookup): Use this temporary hack here; once the
17248 new MemberCache is completed, we don't need to do the DeclaredOnly
17249 looping here anymore since the MemberCache will take care of this.
17250 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
17251 (MemberCache): When creating the MemberCache for a class, get
17252 members from the current class and all its base classes.
17253 (MemberCache.CacheEntry.Container): New field. This is a
17254 temporary hack until the Mono runtime is fixed to distinguish
17255 between ReflectedType and DeclaringType. It allows us to use MCS
17256 with both the MS runtime and the unfixed Mono runtime without
17257 problems and without accecting performance.
17258 (MemberCache.SearchMembers): The DeclaredOnly looping from
17259 TypeManager.MemberLookup is now done here.
17261 2002-08-14 Martin Baulig <martin@gnome.org>
17263 * statement.cs (MyStructInfo.MyStructInfo): Don't call
17264 Type.GetFields on dynamic types but get the fields from the
17265 corresponding TypeContainer.
17266 (MyStructInfo.GetStructInfo): Added check for enum types.
17268 * typemanager.cs (MemberList.IsSynchronized): Implemented.
17269 (MemberList.SyncRoot): Implemented.
17270 (TypeManager.FilterWithClosure): No need to check permissions if
17271 closure_start_type == closure_invocation_type, don't crash if
17272 closure_invocation_type is null.
17274 2002-08-13 Martin Baulig <martin@gnome.org>
17276 Rewrote TypeContainer.FindMembers to use a member cache. This
17277 gives us a speed increase of about 35% for the self-hosting MCS
17278 build and of about 15-20% for the class libs (both on GNU/Linux).
17280 * report.cs (Timer): New class to get enhanced profiling. This
17281 whole class is "TIMER" conditional since it remarkably slows down
17284 * class.cs (MemberList): New class. This is an IList wrapper
17285 which we're now using instead of passing MemberInfo[]'s around to
17286 avoid copying this array unnecessarily.
17287 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
17288 (ICachingMemberFinder, IMemberContainer): New interface.
17289 (TypeManager.FilterWithClosure): If `criteria' is null, the name
17290 has already been checked, otherwise use it for the name comparision.
17291 (TypeManager.FindMembers): Renamed to RealMemberFinder and
17292 provided wrapper which tries to use ICachingMemberFinder.FindMembers
17293 if possible. Returns a MemberList, not a MemberInfo [].
17294 (TypeHandle): New class, implements IMemberContainer. We create
17295 one instance of this class per type, it contains a MemberCache
17296 which is used to do the member lookups.
17297 (MemberCache): New class. Each instance of this class contains
17298 all members of a type and a name-based hash table.
17299 (MemberCache.FindMembers): This is our new member lookup
17300 function. First, it looks up all members of the requested name in
17301 the hash table. Then, it walks this list and sorts out all
17302 applicable members and returns them.
17304 2002-08-13 Martin Baulig <martin@gnome.org>
17306 In addition to a nice code cleanup, this gives us a performance
17307 increase of about 1.4% on GNU/Linux - not much, but it's already
17308 half a second for the self-hosting MCS compilation.
17310 * typemanager.cs (IMemberFinder): New interface. It is used by
17311 TypeManager.FindMembers to call FindMembers on a TypeContainer,
17312 Enum, Delegate or Interface.
17313 (TypeManager.finder_to_member_finder): New PtrHashtable.
17314 (TypeManager.finder_to_container): Removed.
17315 (TypeManager.finder_to_delegate): Removed.
17316 (TypeManager.finder_to_interface): Removed.
17317 (TypeManager.finder_to_enum): Removed.
17319 * interface.cs (Interface): Implement IMemberFinder.
17321 * delegate.cs (Delegate): Implement IMemberFinder.
17323 * enum.cs (Enum): Implement IMemberFinder.
17325 * class.cs (TypeContainer): Implement IMemberFinder.
17327 2002-08-12 Martin Baulig <martin@gnome.org>
17329 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
17331 2002-08-12 Martin Baulig <martin@gnome.org>
17333 * ecore.cs (ITypeExpression): New interface for expressions which
17335 (TypeExpression): Renamed to TypeLookupExpression.
17336 (Expression.DoResolve): If we're doing a types-only lookup, the
17337 expression must implement the ITypeExpression interface and we
17338 call DoResolveType() on it.
17339 (SimpleName): Implement the new ITypeExpression interface.
17340 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
17341 hack, the situation that we're only looking up types can't happen
17342 anymore when this method is called. Moved the type lookup code to
17343 DoResolveType() and call it.
17344 (SimpleName.DoResolveType): This ITypeExpression interface method
17345 is now doing the types-only lookup.
17346 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
17347 (ResolveFlags): Added MaskExprClass.
17349 * expression.cs (MemberAccess): Implement the ITypeExpression
17351 (MemberAccess.DoResolve): Added support for a types-only lookup
17352 when we're called via ITypeExpression.DoResolveType().
17353 (ComposedCast): Implement the ITypeExpression interface.
17355 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
17356 Expression.Resolve() with ResolveFlags.Type instead.
17358 2002-08-12 Martin Baulig <martin@gnome.org>
17360 * interface.cs (Interface.Define): Apply attributes.
17362 * attribute.cs (Attribute.ApplyAttributes): Added support for
17363 interface attributes.
17365 2002-08-11 Martin Baulig <martin@gnome.org>
17367 * statement.cs (Block.Emit): Only check the "this" variable if we
17368 do not always throw an exception.
17370 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
17371 whether the property has a set accessor.
17373 2002-08-11 Martin Baulig <martin@gnome.org>
17375 Added control flow analysis support for structs.
17377 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
17378 with control flow analysis turned off.
17379 (IVariable): New interface.
17380 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
17381 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
17382 (FieldExpr.DoResolve): Resolve the instance expression with flow
17383 analysis turned off and do the definite assignment check after the
17384 resolving when we know what the expression will resolve to.
17386 * expression.cs (LocalVariableReference, ParameterReference):
17387 Implement the new IVariable interface, only call the flow analysis
17388 code if ec.DoFlowAnalysis is true.
17389 (This): Added constructor which takes a Block argument. Implement
17390 the new IVariable interface.
17391 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
17392 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
17393 This does the definite assignment checks for struct members.
17395 * class.cs (Constructor.Emit): If this is a non-static `struct'
17396 constructor which doesn't have any initializer, call
17397 Block.AddThisVariable() to tell the flow analysis code that all
17398 struct elements must be initialized before control returns from
17401 * statement.cs (MyStructInfo): New public class.
17402 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
17403 argument to this indexer. If non-zero, check an individual struct
17404 member, not the whole struct.
17405 (FlowBranching.CheckOutParameters): Check struct members.
17406 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
17407 overloaded versions of these methods which take an additional
17408 `int field_idx' argument to check struct members.
17409 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
17410 overloaded versions of these methods which take an additional
17411 `string field_name' argument to check struct member.s
17412 (VariableInfo): Implement the IVariable interface.
17413 (VariableInfo.StructInfo): New public property. Returns the
17414 MyStructInfo instance of the variable if it's a struct or null.
17415 (Block.AddThisVariable): New public method. This is called from
17416 Constructor.Emit() for non-static `struct' constructor which do
17417 not have any initializer. It creates a special variable for the
17418 "this" instance variable which will be checked by the flow
17419 analysis code to ensure that all of the struct's fields are
17420 initialized before control returns from the constructor.
17421 (UsageVector): Added support for struct members. If a
17422 variable/parameter is a struct with N members, we reserve a slot
17423 in the usage vector for each member. A struct is considered fully
17424 initialized if either the struct itself (slot 0) or all its
17425 members are initialized.
17427 2002-08-08 Martin Baulig <martin@gnome.org>
17429 * driver.cs (Driver.MainDriver): Only report an error CS5001
17430 if there were no compilation errors.
17432 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
17433 `UnsafeContext' property to determine whether the parent is in
17434 unsafe context rather than checking the parent's ModFlags:
17435 classes nested in an unsafe class are unsafe as well.
17437 2002-08-08 Martin Baulig <martin@gnome.org>
17439 * statement.cs (UsageVector.MergeChildren): Distinguish between
17440 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
17441 we return. Added test17() and test18() to test-154.cs.
17443 2002-08-08 Martin Baulig <martin@gnome.org>
17445 * typemanager.cs (TypeManager.FilterWithClosure): If we have
17446 Family access, make sure the invoking type isn't a subclass of the
17447 queried type (that'd be a CS1540).
17449 * ecore.cs (Expression.MemberLookup): Added overloaded version of
17450 this method which takes an additional `Type invocation_type'.
17452 * expression.cs (BaseAccess.DoResolve): Use the base type as
17453 invocation and query type.
17454 (MemberAccess.DoResolve): If the lookup failed and we're about to
17455 report a CS0122, try a lookup with the ec.ContainerType - if this
17456 succeeds, we must report a CS1540.
17458 2002-08-08 Martin Baulig <martin@gnome.org>
17460 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
17461 (MethodGroupExpr): Implement the IMemberExpr interface.
17463 * expression (MemberAccess.ResolveMemberAccess): No need to have
17464 any special code for MethodGroupExprs anymore, they're now
17467 2002-08-08 Martin Baulig <martin@gnome.org>
17469 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
17470 Family, FamANDAssem and FamORAssem permissions.
17471 (TypeManager.IsSubclassOrNestedChildOf): New public method.
17473 2002-08-08 Martin Baulig <martin@gnome.org>
17475 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
17476 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
17479 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
17481 * driver.cs: implemented /resource option to embed managed resources.
17483 2002-08-07 Martin Baulig <martin@gnome.org>
17485 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
17486 (FieldBase.HasFieldInitializer): New public property.
17487 (FieldBase.GetInitializerExpression): New public method. Resolves and
17488 returns the field initializer and makes sure it is only resolved once.
17489 (TypeContainer.EmitFieldInitializers): Call
17490 FieldBase.GetInitializerExpression to get the initializer, this ensures
17491 that it isn't resolved multiple times.
17493 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
17494 the resolving process (SimpleName/MemberLookup) that we're currently
17495 emitting a field initializer (which must not access any instance members,
17496 this is an error CS0236).
17498 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
17499 argument, if the `IsFieldInitializer' flag is set, we must report and
17500 error CS0236 and not an error CS0120.
17502 2002-08-07 Martin Baulig <martin@gnome.org>
17504 * ecore.cs (IMemberExpr): New public interface.
17505 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
17506 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
17507 if the expression is an IMemberExpr.
17509 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
17510 to be null, implicitly default to `this' if we're non-static in
17511 this case. Simplified the code a lot by using the new IMemberExpr
17512 interface. Also fixed bug #28176 here.
17514 2002-08-06 Martin Baulig <martin@gnome.org>
17516 * cs-parser.jay (SimpleLookup): Removed. We need to create
17517 ParameterReferences during semantic analysis so that we can do a
17518 type-only search when resolving Cast, TypeOf and SizeOf.
17519 (block): Pass the `current_local_parameters' to the Block's
17522 * class.cs (ConstructorInitializer): Added `Parameters parameters'
17523 argument to the constructor.
17524 (ConstructorInitializer.Resolve): Create a temporary implicit
17525 block with the parameters.
17527 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
17528 references here if we aren't doing a type-only search.
17530 * statement.cs (Block): Added constructor which takes a
17531 `Parameters parameters' argument.
17532 (Block.Parameters): New public property.
17534 * support.cs (InternalParameters.Parameters): Renamed `parameters'
17535 to `Parameters' and made it public readonly.
17537 2002-08-06 Martin Baulig <martin@gnome.org>
17539 * ecore.cs (Expression.Warning): Made this public as well.
17541 * report.cs (Report.Debug): Print the contents of collections.
17543 2002-08-06 Martin Baulig <martin@gnome.org>
17545 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
17546 used to tell Resolve() which kinds of expressions it may return.
17547 (Expression.Resolve): Added overloaded version of this method which
17548 takes a `ResolveFlags flags' argument. This can be used to tell
17549 Resolve() which kinds of expressions it may return. Reports a
17551 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
17552 ResolveFlags.SimpleName.
17553 (Expression.Error118): Added overloaded version of this method which
17554 takes a `ResolveFlags flags' argument. It uses the flags to determine
17555 which kinds of expressions are allowed.
17557 * expression.cs (Argument.ResolveMethodGroup): New public method.
17558 Resolves an argument, but allows a MethodGroup to be returned.
17559 This is used when invoking a delegate.
17561 * TODO: Updated a bit.
17563 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17565 Fixed compilation with csc.
17567 * ecore.cs: Expression.Error made public. Is this correct? Should
17568 Warning be made public too?
17570 * expression.cs: use ea.Location instead of ea.loc.
17571 [FIXME: Filed as bug #28607: MCS must report these errors.]
17573 2002-08-06 Martin Baulig <martin@gnome.org>
17575 * ecore.cs (Expression.loc): Moved the location here instead of
17576 duplicating it in all derived classes.
17577 (Expression.Location): New public property.
17578 (Expression.Error, Expression.Warning): Made them non-static and
17579 removed the location argument.
17580 (Expression.Warning): Added overloaded version which takes an
17581 `int level' argument.
17582 (Expression.Error118): Make this non-static and removed the
17583 expression and location arguments.
17584 (TypeExpr): Added location argument to the constructor.
17586 * expression.cs (StaticCallExpr): Added location argument to
17588 (Indirection, PointerArithmetic): Likewise.
17589 (CheckedExpr, UnCheckedExpr): Likewise.
17590 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
17591 (StringPtr): Likewise.
17594 2002-08-05 Martin Baulig <martin@gnome.org>
17596 * expression.cs (BaseAccess.DoResolve): Actually report errors.
17598 * assign.cs (Assign.DoResolve): Check whether the source
17599 expression is a value or variable.
17601 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
17602 while resolving the corresponding blocks.
17604 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
17605 an error, don't silently return null.
17607 * statement.cs (Block.AddVariable): Do the error reporting here
17608 and distinguish between CS0128 and CS0136.
17609 (Block.DoResolve): Report all unused labels (warning CS0164).
17610 (LabeledStatement): Pass the location to the constructor.
17611 (LabeledStatement.HasBeenReferenced): New property.
17612 (LabeledStatement.Resolve): Set it to true here.
17614 * statement.cs (Return.Emit): Return success even after reporting
17615 a type mismatch error (CS0126 or CS0127), this is what csc does and
17616 it avoids confusing the users with any consecutive errors.
17618 2002-08-05 Martin Baulig <martin@gnome.org>
17620 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
17622 * const.cs (Const.LookupConstantValue): Catch circular definitions.
17624 * expression.cs (MemberAccess.DoResolve): Silently return if an
17625 error has already been reported.
17627 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
17628 error has already been reported.
17630 2002-08-05 Martin Baulig <martin@gnome.org>
17632 * statement.cs (UsageVector): Only initialize the `parameters'
17633 vector if we actually have any "out" parameters.
17635 2002-08-05 Martin Baulig <martin@gnome.org>
17637 * expression.cs (Binary.ResolveOperator): When combining delegates,
17638 they must have the same type.
17640 2002-08-05 Martin Baulig <martin@gnome.org>
17642 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
17643 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
17644 work with the ms runtime and we also don't need it: if we're a
17645 PropertyBuilder and not in the `indexer_arguments' hash, then we
17646 are a property and not an indexer.
17648 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
17649 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
17650 since the latter one doesn't work with the ms runtime.
17652 2002-08-03 Martin Baulig <martin@gnome.org>
17654 Fixed bugs #27998 and #22735.
17656 * class.cs (Method.IsOperator): New public field.
17657 (Method.CheckBase): Report CS0111 if there's already a method
17658 with the same parameters in the current class. Report CS0508 when
17659 attempting to change the return type of an inherited method.
17660 (MethodData.Emit): Report CS0179 if a method doesn't have a body
17661 and it's not marked abstract or extern.
17662 (PropertyBase): New abstract base class for Property and Indexer.
17663 (PropertyBase.CheckBase): Moved here from Property and made it work
17665 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
17666 the same so we can reuse it there.
17667 (Property, Indexer): Derive from PropertyBase.
17668 (MethodSignature.inheritable_property_signature_filter): New delegate
17669 to find properties and indexers.
17671 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
17672 argument and improved error reporting.
17674 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
17675 EmptyReadOnlyParameters and made it a property.
17677 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
17678 version of this method which takes a `PropertyInfo indexer'.
17679 (TypeManager.RegisterIndexer): New method.
17681 * class.cs: Added myself as author of this file :-)
17683 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17685 * class.cs: fixed compilation on windoze.
17687 2002-08-03 Martin Baulig <martin@gnome.org>
17689 * interface.cs (Interface.GetInterfaceBases): Check whether all
17690 base interfaces are at least as accessible than the current one.
17692 * class.cs (TypeContainer.GetClassBases): Check whether base types
17693 are at least as accessible than the current type.
17694 (TypeContainer.AsAccessible): Implemented and made non-static.
17695 (MemberBase.CheckParameters): Report errors if the accessibility
17698 * delegate.cs (Delegate.Delegate): The default visibility is
17699 internal for top-level types and private for nested types.
17700 (Delegate.Define): Report errors if the accessibility checks fail.
17702 * enum.cs (Enum.Enum): The default visibility is internal for
17703 top-level types and private for nested types.
17704 (Enum.DefineType): Compute the correct visibility.
17706 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
17707 function which takes a `bool is_toplevel' instead of a TypeContainer.
17709 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
17712 2002-08-02 Martin Baulig <martin@gnome.org>
17714 * expression.cs (LocalVariableReferenc): Added constructor which
17715 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
17716 (LocalVariableReference.IsReadOnly): New property.
17717 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
17718 variable is readonly, use our own readonly flag to do this; you can
17719 use the new constructor to get a writable reference to a read-only
17722 * cs-parser.jay (foreach_statement, using_statement): Get a writable
17723 reference to the local variable.
17725 2002-08-01 Miguel de Icaza <miguel@ximian.com>
17727 * rootcontext.cs (ResolveCore): Also include System.Exception
17729 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
17730 we reach an EmptyStatement.
17732 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
17735 * expression.cs (Binary.ResolveOperator): Check error result in
17738 use brtrue/brfalse directly and avoid compares to null.
17740 2002-08-02 Martin Baulig <martin@gnome.org>
17742 * class.cs (TypeContainer.Define): Define all nested interfaces here.
17743 Fixes bug #28407, added test-155.cs.
17745 2002-08-01 Martin Baulig <martin@gnome.org>
17747 * class.cs (Event.EmitDefaultMethod): Make this work with static
17748 events. Fixes #28311, added verify-3.cs.
17750 2002-08-01 Martin Baulig <martin@gnome.org>
17752 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
17753 `is_disposable' fields.
17754 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
17755 `hm.is_disposable' if we're using the collection pattern.
17756 (Foreach.EmitCollectionForeach): Use the correct type for the
17757 enumerator's local variable, only emit the try/finally block if
17758 necessary (fixes #27713).
17760 2002-08-01 Martin Baulig <martin@gnome.org>
17762 * ecore.cs (Expression.report118): Renamed to Error118 and made
17765 * statement.cs (Throw.Resolve): Check whether the expression is of
17766 the correct type (CS0118) and whether the type derives from
17767 System.Exception (CS0155).
17768 (Catch.Resolve): New method. Do the type lookup here and check
17769 whether it derives from System.Exception (CS0155).
17770 (Catch.CatchType, Catch.IsGeneral): New public properties.
17772 * typemanager.cs (TypeManager.exception_type): Added.
17774 2002-07-31 Miguel de Icaza <miguel@ximian.com>
17776 * driver.cs: Updated About function.
17778 2002-07-31 Martin Baulig <martin@gnome.org>
17780 Implemented Control Flow Analysis.
17782 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
17783 (EmitContext.CurrentBranching): Added.
17784 (EmitContext.StartFlowBranching): Added.
17785 (EmitContext.EndFlowBranching): Added.
17786 (EmitContext.KillFlowBranching): Added.
17787 (EmitContext.IsVariableAssigned): Added.
17788 (EmitContext.SetVariableAssigned): Added.
17789 (EmitContext.IsParameterAssigned): Added.
17790 (EmitContext.SetParameterAssigned): Added.
17791 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
17792 Added control flow analysis stuff here.
17794 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
17795 resolve the expression as lvalue.
17796 (LocalVariableReference.DoResolve): Check whether the variable has
17797 already been assigned.
17798 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
17799 the parameter as assigned here.
17800 (ParameterReference.DoResolve): Check whether the parameter has already
17802 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
17803 expression as lvalue.
17805 * statement.cs (FlowBranching): New class for the flow analysis code.
17806 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
17807 (LabeledStatement.IsDefined): New public property.
17808 (LabeledStatement.AddUsageVector): New public method to tell flow
17809 analyis that the label may be reached via a forward jump.
17810 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
17812 (VariableInfo.Number): New public field. This is used by flow analysis
17813 to number all locals of a block.
17814 (Block.CountVariables): New public property. This is the number of
17815 local variables in this block (including the locals from all parent
17817 (Block.EmitMeta): Number all the variables.
17819 * statement.cs: Added flow analysis support to all classes.
17821 2002-07-31 Martin Baulig <martin@gnome.org>
17823 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
17824 To get debugging messages, compile mcs with /define:MCS_DEBUG and
17825 then use this argument.
17827 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
17829 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
17830 use this to specify /define options.
17832 2002-07-29 Martin Baulig <martin@gnome.org>
17834 * statement.cs (Fixed): Moved all code that does variable lookups
17835 and resolvings from Emit to Resolve.
17837 * statement.cs (For): Moved all code that does variable lookups
17838 and resolvings from Emit to Resolve.
17840 * statement.cs (Using): Moved all code that does variable lookups
17841 and resolvings from Emit to Resolve.
17843 2002-07-29 Martin Baulig <martin@gnome.org>
17845 * attribute.cs (Attribute.Resolve): Explicitly catch a
17846 System.NullReferenceException when creating the
17847 CustromAttributeBuilder and report a different warning message.
17849 2002-07-29 Martin Baulig <martin@gnome.org>
17851 * support.cs (ParameterData.ParameterName): Added method to
17852 get the name of a parameter.
17854 * typemanager.cs (TypeManager.IsValueType): New public method.
17856 2002-07-29 Martin Baulig <martin@gnome.org>
17858 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
17859 is a flag which specifies that it's either ref or out.
17860 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
17861 the out parameter to `out Parameter.Modifier mod', also set the
17862 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
17864 * support.cs (InternalParameters.ParameterModifier): Distinguish
17865 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
17866 Parameter.Modifier.ISBYREF flag if it's either ref or out.
17868 * expression.cs (Argument.GetParameterModifier): Distinguish
17869 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
17870 Parameter.Modifier.ISBYREF flag if it's either ref or out.
17872 2002-07-29 Martin Baulig <martin@gnome.org>
17874 * expression.cs (ParameterReference.ParameterReference): Added
17875 `Location loc' argument to the constructor.
17877 * cs-parser.jay: Pass location to ParameterReference.
17879 2002-07-28 Miguel de Icaza <miguel@ximian.com>
17881 * statement.cs (Try): Initialize the location.
17883 * cs-parser.jay: pass location to Try.
17885 * expression.cs (Unary.Reduce): Change the prototype to return
17886 whether a constant fold could be performed or not. The result is
17887 returned in an out parameters. In the case of Indirection and
17888 AddressOf, we want to perform the full tests.
17890 2002-07-26 Miguel de Icaza <miguel@ximian.com>
17892 * statement.cs (Statement.Emit): Flag dead code.
17894 2002-07-27 Andrew Birkett <andy@nobugs.org>
17896 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
17898 2002-07-27 Martin Baulig <martin@gnome.org>
17900 * class.cs (MethodData.Define): Put back call to
17901 TypeManager.AddMethod(), accidentally commented this out.
17903 * report.cs (Debug): New public method to print debugging information,
17904 this is `[Conditional ("DEBUG")]'.
17906 2002-07-26 Martin Baulig <martin@gnome.org>
17908 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
17909 (switch_statement): Push the current_block to the switch_stack and
17910 pop it again when we're done with the switch.
17911 (switch_section): The new block is a child of the current_block.
17912 Fixes bug #24007, added test-152.cs.
17914 2002-07-27 Martin Baulig <martin@gnome.org>
17916 * expression.cs (Invocation.EmitArguments): When calling a varargs
17917 function with only its fixed arguments, we need to pass an empty
17920 2002-07-27 Martin Baulig <martin@gnome.org>
17922 Mono 0.13 has been released.
17924 2002-07-25 Miguel de Icaza <miguel@ximian.com>
17926 * driver.cs: Rename --resource to --linkres, because that is what
17927 we do currently, we dont support --resource yet.
17929 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
17931 2002-07-25 Martin Baulig <martin@gnome.org>
17933 * class.cs (MethodData): New public class. This is a `method builder'
17934 class for a method or one accessor of a Property/Indexer/Event.
17935 (MethodData.GetMethodFlags): Moved here from MemberBase.
17936 (MethodData.ApplyAttributes): Likewise.
17937 (MethodData.ApplyObsoleteAttribute): Likewise.
17938 (MethodData.ApplyConditionalAttribute): Likewise.
17939 (MethodData.ApplyDllImportAttribute): Likewise.
17940 (MethodData.CheckAbstractAndExternal): Likewise.
17941 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
17942 (MethodData.Emit): Formerly known as Method.Emit().
17943 (MemberBase): Moved everything which was specific to a single
17944 accessor/method to MethodData.
17945 (Method): Create a new MethodData and call Define() and Emit() on it.
17946 (Property, Indexer, Event): Create a new MethodData objects for each
17947 accessor and call Define() and Emit() on them.
17949 2002-07-25 Martin Baulig <martin@gnome.org>
17951 Made MethodCore derive from MemberBase to reuse the code from there.
17952 MemberBase now also checks for attributes.
17954 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
17955 (MemberBase.GetMethodFlags): Moved here from class Method and marked
17957 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
17958 `CallingConventions cc' and `Attributes opt_attrs' arguments.
17959 (MemberBase.ApplyAttributes): New virtual method; applies the
17960 attributes to a method or accessor.
17961 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
17962 (MemberBase.ApplyConditionalAttribute): Likewise.
17963 (MemberBase.ApplyDllImportAttribute): Likewise.
17964 (MemberBase.CheckAbstractAndExternal): Likewise.
17965 (MethodCore.ParameterTypes): This is now a property instead of a
17966 method, it's initialized from DoDefineParameters().
17967 (MethodCore.ParameterInfo): Removed the set accessor.
17968 (MethodCore.DoDefineParameters): New protected virtual method to
17969 initialize ParameterTypes and ParameterInfo.
17970 (Method.GetReturnType): We can now simply return the MemberType.
17971 (Method.GetMethodFlags): Override the MemberBase version and add
17972 the conditional flags.
17973 (Method.CheckBase): Moved some code from Define() here, call
17974 DoDefineParameters() here.
17975 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
17976 here to avoid some larger code duplication.
17977 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
17978 ensure that abstract and external accessors don't declare a body.
17980 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
17981 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
17982 lookup in the attribute's parent classes, so we need to abort as soon
17983 as we found the first match.
17984 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
17985 the attribute has no arguments.
17987 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
17990 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17992 * cs-parser.jay: reverted previous patch.
17994 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17996 * cs-parser.jay: fixed bug #22119.
17998 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18000 * attribute.cs: fixed compilation. The error was:
18001 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
18002 be assigned to before control leaves the current method."
18003 [FIXME: Filed as bug #28186: MCS must report this error.]
18005 2002-07-25 Martin Baulig <martin@gnome.org>
18007 * attribute.cs (Attribute.Conditional_GetConditionName): New static
18008 method to pull the condition name ouf of a Conditional attribute.
18009 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
18010 the obsolete message and error flag out of an Obsolete attribute.
18012 * class.cs (Method.GetMethodFlags): New public method to get the
18013 TypeManager.MethodFlags for this method.
18014 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
18016 (Method.Define): Get and apply the Obsolete and Conditional attributes;
18017 if we're overriding a virtual function, set the new private variable
18018 `parent_method'; call the new TypeManager.AddMethod().
18020 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
18021 the MethodBuilder and the Method in a PtrHashtable.
18022 (TypeManager.builder_to_method): Added for this purpose.
18023 (TypeManager.MethodFlags): Added IsObsoleteError.
18024 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
18025 Obsolete and Conditional arguments in MethodBuilders. If we discover
18026 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
18027 the message from the attribute.
18029 2002-07-24 Martin Baulig <martin@gnome.org>
18031 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
18032 preprocessor directives, ensure that the argument to #define/#undef is
18033 exactly one identifier and that it's actually an identifier.
18035 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
18038 2002-07-24 Martin Baulig <martin@gnome.org>
18040 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
18041 initialize it to TypeManager.object_type in the constructor.
18042 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
18043 of the `hm.get_current' method if we're using the collection pattern.
18044 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
18045 for the explicit conversion to make it work when we're using the collection
18046 pattern and the `Current' property has a different return type than `object'.
18049 2002-07-24 Martin Baulig <martin@gnome.org>
18051 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
18052 does not match, but don't report any errors. This method is called in
18053 order for all methods in a MethodGroupExpr until a matching method is
18054 found, so we don't want to bail out if the first method doesn't match.
18055 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
18056 matches, report the 123. Fixes #28070.
18058 2002-07-24 Martin Baulig <martin@gnome.org>
18060 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
18061 TypeManager.TypeToCoreType() to the top of the method so the
18062 following equality checks will work. Fixes #28107.
18064 2002-07-24 Martin Baulig <martin@gnome.org>
18066 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
18067 operand is of type uint, and the other operand is of type sbyte,
18068 short or int, the operands are converted to type long." -
18069 Actually do what this comment already told us. Fixes bug #28106,
18072 2002-07-24 Martin Baulig <martin@gnome.org>
18074 * class.cs (MethodBase): New abstract class. This is now a base
18075 class for Property, Indexer and Event to avoid some code duplication
18076 in their Define() and DefineMethods() methods.
18077 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
18078 generic methods for Define() and DefineMethods().
18079 (FieldBase): Derive from MemberBase, not MemberCore.
18080 (Property): Derive from MemberBase, not MemberCore.
18081 (Property.DefineMethod): Moved all the code from this method to the
18082 new MethodBase.DefineAccessor(), just call it with appropriate
18084 (Property.Define): Call the new Property.DoDefine(), this does some
18085 sanity checks and we don't need to duplicate the code everywhere.
18086 (Event): Derive from MemberBase, not MemberCore.
18087 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
18088 accessors, this will also make them work with interface events.
18089 (Indexer): Derive from MemberBase, not MemberCore.
18090 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
18091 (Indexer.Define): Use the new MethodBase functions.
18093 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
18094 argument to the constructor.
18095 (Interface.FindMembers): Added support for interface events.
18096 (Interface.PopluateEvent): Implemented.
18098 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
18100 2002-07-22 Miguel de Icaza <miguel@ximian.com>
18102 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
18103 but this is required to check for a method name being the same as
18104 the containing class.
18108 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18110 * interface.cs: initialize variable.
18112 2002-07-23 Martin Baulig <martin@gnome.org>
18114 Implemented the IndexerName attribute in interfaces.
18116 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
18117 name if this is an explicit interface implementation.
18118 (Indexer.InterfaceIndexerName): New public variable. If we're
18119 implementing an interface indexer, this is the IndexerName in that
18120 interface. Otherwise, it's the IndexerName.
18121 (Indexer.DefineMethod): If we're implementing interface indexer,
18122 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
18123 and Pending.ImplementIndexer methods.
18124 (Indexer.Define): Also define the PropertyBuilder if we're
18125 implementing an interface indexer and this is neither an explicit
18126 interface implementation nor do the IndexerName match the one in
18129 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
18130 If a method is defined here, then we always need to create a proxy
18131 for it. This is used when implementing interface indexers.
18132 (Pending.IsInterfaceIndexer): New public method.
18133 (Pending.ImplementIndexer): New public method.
18134 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
18135 This is used when implementing interface indexers to define a proxy
18137 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
18138 define a proxy if necessary.
18140 * interface.cs (Interface.IndexerName): New public variable.
18141 (Interface.PopulateIndexer): Set the IndexerName.
18142 (Interface.DefineIndexers): New private method. Populate all the
18143 indexers and make sure their IndexerNames match.
18145 * typemanager.cs (IndexerPropertyName): Added support for interface
18148 2002-07-22 Martin Baulig <martin@gnome.org>
18150 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
18151 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
18152 ret if HasReturnLabel.
18153 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
18156 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
18157 and set the ec.LoopBeginTryCatchLevel.
18158 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
18159 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
18160 the current ec.TryCatchLevel, the branch goes out of an exception
18161 block. In this case, we need to use Leave and not Br.
18163 2002-07-22 Martin Baulig <martin@gnome.org>
18165 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
18166 block unless the block does not always return or it is contained in
18167 another try { ... } catch { ... } block. Fixes bug #26506.
18168 Added verify-1.cs to the test suite.
18170 2002-07-22 Martin Baulig <martin@gnome.org>
18172 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
18173 then we do not always return. Fixes bug #24985.
18175 2002-07-22 Martin Baulig <martin@gnome.org>
18177 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
18178 lookup on a per-class level; ie. walk up the class hierarchy until we
18179 found at least one applicable method, then choose the best among them.
18180 Fixes bug #24463 and test-29.cs.
18182 2002-07-22 Martin Baulig <martin@gnome.org>
18184 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
18185 return types of the methods. The return type is not part of the
18186 signature and we must not check it to make the `new' modifier work.
18187 Fixes bug #27999, also added test-147.cs.
18188 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
18190 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
18191 on the method's return type.
18193 2002-07-21 Martin Baulig <martin@gnome.org>
18195 * assign.cs: Make this work if the rightmost source is a constant and
18196 we need to do an implicit type conversion. Also adding a few more tests
18197 to test-38.cs which should have caught this.
18199 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
18200 target in the makefile for this. The makefile.gnu is primarily intended
18201 for end-users who don't want to debug the compiler.
18203 2002-07-21 Martin Baulig <martin@gnome.org>
18205 * assign.cs: Improved the Assign class so it can now handle embedded
18206 assignments (X = Y = Z = something). As a side-effect this'll now also
18207 consume less local variables. test-38.cs now passes with MCS, added
18208 a few new test cases to that test.
18210 2002-07-20 Martin Baulig <martin@gnome.org>
18212 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
18213 instructions. Fixes bug #27977, also added test-146.cs.
18215 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18217 * cs-tokenizer.cs: fixed getHex ().
18219 2002-07-19 Martin Baulig <martin@gnome.org>
18221 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
18222 not Type.GetType() to lookup the array type. This is needed when
18223 we're constructing an array of a user-defined type.
18224 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
18225 single-dimensional arrays, but also for single-dimensial arrays of
18228 2002-07-19 Martin Baulig <martin@gnome.org>
18230 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
18231 this function is called, it's not allowed to share LocalBuilders
18232 among ILGenerators.
18234 2002-07-19 Martin Baulig <martin@gnome.org>
18236 * expression.cs (Argument.Resolve): Report an error 118 when trying
18237 to pass a type as argument.
18239 2002-07-18 Martin Baulig <martin@gnome.org>
18241 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
18242 Conv_R_Un for the signed `long' type.
18244 2002-07-15 Miguel de Icaza <miguel@ximian.com>
18246 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
18247 `expr' for the temporary result, as that will fail if we do
18248 multiple resolves on the same expression.
18250 2002-07-05 Miguel de Icaza <miguel@ximian.com>
18252 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
18253 ec.TypeContainer for looking up aliases.
18255 * class.cs (TypeContainer): Remove LookupAlias from here.
18257 * decl.cs (DeclSpace); Move here.
18259 2002-07-01 Miguel de Icaza <miguel@ximian.com>
18261 * class.cs (FindMembers): Only call filter if the constructor
18262 bulider is not null.
18264 Also handle delegates in `NestedTypes' now. Now we will perform
18265 type lookups using the standard resolution process. This also
18268 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
18269 This uses Expressions (the limited kind that can be parsed by the
18270 tree) instead of strings.
18272 * expression.cs (ComposedCast.ToString): Implement, used to flag
18273 errors since now we have to render expressions.
18275 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
18278 * ecore.cs (SimpleName.ToString): ditto.
18280 * cs-parser.jay: Instead of using strings to assemble types, use
18281 Expressions to assemble the type (using SimpleName, ComposedCast,
18282 MemberAccess). This should fix the type lookups in declarations,
18283 because we were using a different code path for this.
18285 * statement.cs (Block.Resolve): Continue processing statements
18286 even when there is an error.
18288 2002-07-17 Miguel de Icaza <miguel@ximian.com>
18290 * class.cs (Event.Define): Also remove the `remove' method from
18291 the list of pending items.
18293 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
18294 generate more compact code.
18296 2002-07-17 Martin Baulig <martin@gnome.org>
18298 * const.cs (Const.LookupConstantValue): Add support for constant
18299 `unchecked' and `checked' expressions.
18300 Also adding test case test-140.cs for this.
18302 2002-07-17 Martin Baulig <martin@gnome.org>
18304 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
18305 check whether mi.ReturnType implements the IEnumerator interface; the
18306 `==' and the IsAssignableFrom() will fail in this situation.
18308 2002-07-16 Ravi Pratap <ravi@ximian.com>
18310 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
18313 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18315 * expression.cs: fixed bug #27811.
18317 2002-07-14 Miguel de Icaza <miguel@ximian.com>
18319 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
18320 Molaro: when we are a ref, the value already contains a pointer
18321 value, do not take the address of it.
18323 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
18324 * removed mb-parser.jay and mb-tokenizer.cs
18326 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
18328 * expression.cs: check against the building corlib void type.
18330 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
18332 * ecore.cs: fix for valuetype static readonly fields: when
18333 initializing them, we need their address, not the address of a copy.
18335 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
18337 * typemanager.cs: register also enum_type in corlib.
18339 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
18341 * class.cs: allow calling this (but not base) initializers in structs.
18343 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
18345 * ecore.cs: make sure we compare against the building base types
18348 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
18350 * typemanager.cs: fix TypeToCoreType() to handle void and object
18351 (corlib gets no more typerefs after this change).
18353 2002-07-12 Miguel de Icaza <miguel@ximian.com>
18355 * expression.cs (ArrayCreation.EmitArrayArguments): use
18356 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
18358 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
18359 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
18360 array indexes, the runtime actually forbids them.
18362 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
18363 for array arguments here.
18365 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
18366 instead of the default for ValueTypes.
18368 (New.DoEmit): Use IsValueType instead of
18369 IsSubclassOf (value_type)
18370 (New.DoResolve): ditto.
18371 (Invocation.EmitCall): ditto.
18373 * assign.cs (Assign): ditto.
18375 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
18376 Statements *are* currently doing part of their resolution during
18379 Expressions do always resolve during resolve, but statements are
18380 only required to propagate resolution to their children.
18382 2002-07-11 Miguel de Icaza <miguel@ximian.com>
18384 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
18386 (LoadAssembly): Do not add the dll if it is already specified
18388 (MainDriver): Add the System directory to the link path at the end,
18389 after all the other -L arguments.
18391 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
18392 wrong opcode for loading bytes and bools (ldelem.i1 instead of
18393 ldelem.u1) and using the opposite for sbytes.
18395 This fixes Digger, and we can finally run it.
18397 * driver.cs (UnixParseOption): Move the option parsing here.
18398 (CSCParseOption): Implement CSC-like parsing of options.
18400 We now support both modes of operation, the old Unix way, and the
18401 new CSC-like way. This should help those who wanted to make cross
18402 platform makefiles.
18404 The only thing broken is that /r:, /reference: and /lib: are not
18405 implemented, because I want to make those have the same semantics
18406 as the CSC compiler has, and kill once and for all the confussion
18407 around this. Will be doing this tomorrow.
18409 * statement.cs (Unsafe.Resolve): The state is checked during
18410 resolve, not emit, so we have to set the flags for IsUnsfe here.
18412 2002-07-10 Miguel de Icaza <miguel@ximian.com>
18414 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
18415 not catch the Error_ObjectRefRequired in SimpleName (as it is
18416 possible to have a class/instance variable name that later gets
18417 deambiguated), we have to check this here.
18419 2002-07-10 Ravi Pratap <ravi@ximian.com>
18421 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
18422 make static and put into Expression.
18424 (Event.Define): Register the private field of the event with the
18425 TypeManager so that GetFieldFromEvent can get at it.
18427 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
18428 keep track of the private field associated with an event which
18431 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
18434 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
18436 2002-07-10 Miguel de Icaza <miguel@ximian.com>
18438 * expression.cs (Binary.EmitBranchable): this routine emits the
18439 Binary expression in a branchable context. This basically means:
18440 we need to branch somewhere, not just get the value on the stack.
18442 This works together with Statement.EmitBoolExpression.
18444 * statement.cs (Statement.EmitBoolExpression): Use
18447 2002-07-09 Miguel de Icaza <miguel@ximian.com>
18449 * statement.cs (For): Reduce the number of jumps in loops.
18451 (For): Implement loop inversion for the For statement.
18453 (Break): We can be breaking out of a Try/Catch controlled section
18454 (foreach might have an implicit try/catch clause), so we need to
18455 use Leave instead of Br.
18457 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
18458 now). If the instace expression supports IMemoryLocation, we use
18459 the AddressOf method from the IMemoryLocation to extract the
18460 address instead of emitting the instance.
18462 This showed up with `This', as we were emitting the instance
18463 always (Emit) instead of the Address of This. Particularly
18464 interesting when This is a value type, as we dont want the Emit
18465 effect (which was to load the object).
18467 2002-07-08 Miguel de Icaza <miguel@ximian.com>
18469 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
18471 * statement.cs (Checked): Set the CheckedState during the resolve
18472 process too, as the ConvCast operations track the checked state on
18473 the resolve process, and not emit.
18475 * cs-parser.jay (namespace_member_declaration): Flag that we have
18476 found a declaration when we do. This is used to flag error 1529
18478 * driver.cs: Report ok when we display the help only.
18480 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
18482 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
18484 2002-07-04 Miguel de Icaza <miguel@ximian.com>
18486 * cs-tokenizer.cs (define): We also have to track locally the
18487 defines. AllDefines is just used for the Conditional Attribute,
18488 but we also need the local defines for the current source code.
18490 2002-07-03 Miguel de Icaza <miguel@ximian.com>
18492 * statement.cs (While, For, Do): These loops can exit through a
18493 Break statement, use this information to tell whether the
18494 statement is the last piece of code.
18496 (Break): Flag that we break.
18498 * codegen.cs (EmitContexts): New `Breaks' state variable.
18500 2002-07-03 Martin Baulig <martin@gnome.org>
18502 * class.cs (TypeContainer.MethodModifiersValid): Allow override
18503 modifiers in method declarations in structs. Otherwise, you won't
18504 be able to override things like Object.Equals().
18506 2002-07-02 Miguel de Icaza <miguel@ximian.com>
18508 * class.cs (Method, Property, Indexer): Do not allow the public
18509 modifier to be used in explicit interface implementations.
18511 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
18512 override modifiers in method declarations in structs
18514 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
18516 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
18517 integer or real overflow, report an error
18519 2002-07-02 Martin Baulig <martin@gnome.org>
18521 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
18522 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
18523 to tell the runtime about our newly created System.Object and
18524 System.ValueType types.
18526 2002-07-02 Miguel de Icaza <miguel@ximian.com>
18528 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
18529 struct instead of Ldarg/Starg.
18531 2002-07-02 Martin Baulig <martin@gnome.org>
18533 * expression.cs (Indirection.Indirection): Call
18534 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
18536 2002-07-02 Martin Baulig <martin@gnome.org>
18538 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
18539 ValueType, call TypeManager.TypeToCoreType() on it.
18540 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
18541 the OpCodes.Newarr argument.
18543 2002-07-02 Martin Baulig <martin@gnome.org>
18545 * expression.cs (Invocation.EmitCall): When compiling corlib,
18546 replace all calls to the system's System.Array type to calls to
18547 the newly created one.
18549 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
18550 System.Array methods.
18551 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
18552 from the system's System.Array type which must be replaced.
18554 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
18556 * typemanager.cs: load unverifiable_code_ctor so we can build
18557 corlib using the correct type. Avoid using GetTypeCode() with
18559 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
18560 TypeManager.object_type to allow building corlib.
18562 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
18564 * ecore.cs: handle System.Enum separately in LoadFromPtr().
18566 2002-07-01 Martin Baulig <martin@gnome.org>
18568 * class.cs: Make the last change actually work, we need to check
18569 whether `ifaces != null' to avoid a crash.
18571 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
18573 * class.cs: when we build structs without fields that implement
18574 interfaces, we need to add the interfaces separately, since there is
18575 no API to both set the size and add the interfaces at type creation
18578 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
18580 * expression.cs: the dimension arguments to the array constructors
18581 need to be converted if they are a long.
18583 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
18585 * class.cs: don't emit ldarg.0 if there is no parent constructor
18586 (fixes showstopper for corlib).
18588 2002-06-29 Martin Baulig <martin@gnome.org>
18590 MCS now compiles corlib on GNU/Linux :-)
18592 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
18593 ie. check for MethodImplOptions.InternalCall.
18595 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
18596 and TypeManager.attribute_type are null, so we must explicitly check
18597 whether parent is not null to find out whether it's an attribute type.
18598 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
18599 and SetBuilder, not only if the property is neither abstract nor external.
18600 This is necessary to set the MethodImplOptions on the accessor methods.
18601 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
18602 SetBuilder, see Property.Emit().
18604 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
18605 populate "System.Object", "System.ValueType" and "System.Attribute" since
18606 they've already been populated from BootCorlib_PopulateCoreTypes().
18608 2002-06-29 Martin Baulig <martin@gnome.org>
18610 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
18611 is the NullLiteral, we also need to make sure that target_type is not
18614 2002-06-29 Martin Baulig <martin@gnome.org>
18616 * rootcontext.cs (RootContext.ResolveCore): We must initialize
18617 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
18618 before calling BootstrapCorlib_ResolveDelegate ().
18620 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18622 * statement.cs: fixed build-breaker. All tests passed ok.
18624 2002-06-27 Martin Baulig <martin@gnome.org>
18626 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
18627 for System.Decimal when compiling corlib.
18629 2002-06-27 Martin Baulig <martin@gnome.org>
18631 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
18632 switch blocks which contain nothing but a default clause.
18634 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
18636 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
18638 2002-06-27 Martin Baulig <martin@gnome.org>
18640 * ecore.cs (PropertyExpr.PropertyExpr): Call
18641 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
18643 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
18644 is already a TypeBuilder.
18646 2002-06-27 Martin Baulig <martin@gnome.org>
18648 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
18649 `target_type == TypeManager.array_type', not IsAssignableFrom() in
18650 the "from an array-type to System.Array" case. This makes it work
18651 when compiling corlib.
18653 2002-06-27 Martin Baulig <martin@gnome.org>
18655 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
18656 non-static PropertyExpr, set its InstanceExpression. This makes
18657 the `ICollection.Count' property work in System/Array.cs.
18659 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
18661 * driver.cs: Made error handling more consistent. Errors now
18662 tracked by Report class, so many methods which used to return int
18663 now return void. Main() now prints success/failure and
18664 errors/warnings message.
18666 Renamed '--probe' compiler argument to '--expect-error'. Removed
18667 the magic number return values (123 and 124). Now, if the
18668 expected error occurs, the compiler exits with success (exit value
18669 0). If the compilation completes without seeing that particular
18670 error, the compiler exits with failure (exit value 1). The
18671 makefile in mcs/errors has been changed to handle the new behaviour.
18673 * report.cs: Made 'expected error' number a property and renamed
18674 it from 'Probe' to 'ExpectedError'.
18676 * genericparser.cs: Removed error handling support, since it is
18677 now all done by Report class.
18679 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
18680 class, so parse() no longer returns an int.
18682 * namespace.cs: Use Report.Error instead of GenericParser.error
18684 2002-06-22 Miguel de Icaza <miguel@ximian.com>
18686 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
18687 TypeContainer.AddOperator): At the front of the list put the
18688 explicit implementations, so they get resolved/defined first.
18690 2002-06-21 Miguel de Icaza <miguel@ximian.com>
18692 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
18693 interface type is implemented by this TypeContainer. Used during
18694 explicit interface implementation.
18696 (Property.Define, Indexer.Define, Method.Define): Validate that
18697 the given interface in the explicit implementation is one of the
18698 base classes for the containing type.
18700 Also if we are explicitly implementing an interface, but there is
18701 no match in the pending implementation table, report an error.
18703 (Property.Define): Only define the property if we are
18704 not explicitly implementing a property from an interface. Use the
18705 correct name also for those properties (the same CSC uses,
18706 although that is really not needed).
18708 (Property.Emit): Do not emit attributes for explicitly implemented
18709 properties, as there is no TypeBuilder.
18711 (Indexer.Emit): ditto.
18713 Hiding then means that we do not really *implement* a pending
18714 implementation, which makes code fail.
18716 2002-06-22 Martin Baulig <martin@gnome.org>
18718 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
18719 the return value of Object.GetType(). [FIXME: we need to do this whenever
18720 we get a type back from the reflection library].
18722 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
18724 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
18726 2002-06-20 Miguel de Icaza <miguel@ximian.com>
18728 * attribute.cs: Return null if we can not look up the type.
18730 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
18731 the interface types found.
18733 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
18734 interface types found.
18736 * typemanager.cs (GetInterfaces): Make this routine returns alll
18737 the interfaces and work around the lame differences between
18738 System.Type and System.Reflection.Emit.TypeBuilder in the results
18739 result for GetInterfaces.
18741 (ExpandInterfaces): Given an array of interface types, expand and
18742 eliminate repeated ocurrences of an interface. This expands in
18743 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
18746 2002-06-21 Martin Baulig <martin@gnome.org>
18748 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
18751 2002-06-21 Martin Baulig <martin@gnome.org>
18753 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
18754 and called with one of the core types, return the corresponding typebuilder for
18757 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
18760 2002-06-21 Martin Baulig <martin@gnome.org>
18762 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
18763 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
18764 (Expression.ConvertReferenceExplicit): Likewise.
18766 * expression.cs (ElementAccess.DoResolve): Likewise.
18767 (ElementAccess.DoResolveLValue): Likewise.
18769 2002-06-10 Martin Baulig <martin@gnome.org>
18771 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
18772 add the "value" parameter to the parameter list.
18774 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
18777 2002-06-19 Miguel de Icaza <miguel@ximian.com>
18779 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
18780 the argument to an int, uint, long or ulong, per the spec. Also
18781 catch negative constants in array creation.
18783 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
18785 * class.cs: do not allow the same interface to appear twice in
18786 the definition list.
18788 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
18790 * ecore.cs: don't use ldlen with System.Array.
18792 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
18794 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
18796 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
18798 * modifiers.cs: produce correct field attributes for protected
18799 internal. Easy fix so miguel can work on ther harder stuff:-)
18801 2002-06-18 Miguel de Icaza <miguel@ximian.com>
18803 * pending.cs: New file. Move the code from class.cs here.
18804 Support clearning the pending flag for all methods (when not doing
18805 explicit interface implementation).
18807 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
18809 * rootcontext.cs: added a couple more types needed to bootstrap.
18811 2002-06-17 Miguel de Icaza <miguel@ximian.com>
18813 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
18814 constructor in the type, instead of any constructor in the type
18815 hierarchy. Thanks to Paolo for finding this bug (it showed up as
18816 a bug in the Mono runtime when applying the params attribute).
18818 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
18819 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
18821 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
18823 * expression.cs (Unary.ResolveOperator): Use TypeManager
18824 to resolve the type.
18826 2002-06-13 Ravi Pratap <ravi@ximian.com>
18828 * cs-parser.jay (enum_member_declaration): Pass in the attributes
18831 * enum.cs (AddEnumMember): Add support to store the attributes associated
18832 with each member too.
18834 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
18835 field builders too - this takes care of the enum member case.
18837 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
18839 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
18840 address-of operator on both value types and pointers.
18842 2002-06-10 Martin Baulig <martin@gnome.org>
18844 * interface.cs (Interface.PopulateIndexer): Add the indexer's
18845 PropertyBuilder to the `property_builders' list.
18847 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
18848 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
18849 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
18850 find any indexers which are inherited from an interface.
18852 2002-06-09 Martin Baulig <martin@gnome.org>
18854 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
18855 the same type as the constant if necessary. There's also a test-130.cs
18858 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
18860 * typemanager.cs (TypeManager.ChangeType): Previously known as
18861 Enum.ChangeEnumType().
18863 2002-06-09 Martin Baulig <martin@gnome.org>
18865 * expression.cs (Cast.TryReduce): Added support for consts.
18867 2002-06-08 Ravi Pratap <ravi@ximian.com>
18869 * class.cs (Accessor): Hold attributes information so we can pass
18872 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
18873 Modify to pass in attributes attached to the methods.
18875 (add_accessor_declaration, remove_accessor_declaration): Ditto.
18877 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
18878 to handle the Accessor kind :-)
18880 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
18882 2002-06-08 Martin Baulig <martin@gnome.org>
18884 * expression.cs (Unary.TryReduceNegative): Added support for
18887 2002-06-08 Martin Baulig <martin@gnome.org>
18889 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
18890 name can't be found in the `defined_names' - the caller will do a
18891 MemberLookup in this case and thus find methods in System.Enum
18892 such as Enum.IsDefined().
18894 2002-06-08 Martin Baulig <martin@gnome.org>
18896 * enum.cs (Enum.ChangeEnumType): This is a custom version of
18897 Convert.ChangeType() which works with TypeBuilder created types.
18898 (Enum.LookupEnumValue, Enum.Define): Use it here.
18900 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
18901 `TypeBuilder.BaseType != null' check.
18902 (TypeContainer.FindMembers): Only lookup parent members if we
18903 actually have a parent.
18904 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
18905 (ConstructorInitializer.Resolve): Likewise.
18907 * interface.cs (Interface.FindMembers): Added
18908 `TypeBuilder.BaseType != null' check.
18910 * rootcontext.cs (RootContext.ResolveCore): Added
18911 "System.Runtime.CompilerServices.IndexerNameAttribute" to
18912 classes_second_stage.
18914 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
18915 debug_type and trace_type when compiling with --nostdlib.
18917 2002-06-07 Martin Baulig <martin@gnome.org>
18919 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
18920 (AddField): Set it to true when adding a non-static field.
18921 (DefineType): Use `have_nonstatic_fields' to find out whether we
18922 have non-static fields, not `Fields != null'.
18924 2002-06-02 Miguel de Icaza <miguel@ximian.com>
18926 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
18927 dereferencing a null on the static-field code path)
18929 2002-05-30 Martin Baulig <martin@gnome.org>
18931 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
18932 to take command line arguments. Use reflection to call the new
18933 custom `Initialize' function on the symbol writer and pass it the
18934 command line arguments.
18936 * driver.cs (--debug-args): New command line argument to pass command
18937 line arguments to the symbol writer.
18939 2002-05-28 Miguel de Icaza <miguel@ximian.com>
18941 * assign.cs (DoResolve): Forgot to do the implicit conversion to
18942 the target type for indexers and properties. Thanks to Joe for
18945 2002-05-27 Miguel de Icaza <miguel@ximian.com>
18947 * typemanager.cs (MethodFlags): returns the method flags
18948 (Obsolete/ShouldIgnore) that control warning emission and whether
18949 the invocation should be made, or ignored.
18951 * expression.cs (Invocation.Emit): Remove previous hack, we should
18952 not do this on matching a base type, we should do this based on an attribute
18954 Only emit calls to System.Diagnostics.Debug and
18955 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
18956 on the command line.
18958 * rootcontext.cs: Global settings for tracing and debugging.
18960 * cs-tokenizer.cs (define): New utility function to track
18961 defines. Set the global settings for TRACE and DEBUG if found.
18963 2002-05-25 Ravi Pratap <ravi@ximian.com>
18965 * interface.cs (Populate*): Pass in the TypeContainer as well as
18966 the DeclSpace as parameters so that we can create EmitContexts and
18967 then use that to apply attributes etc.
18969 (PopulateMethod, PopulateEvent, PopulateProperty)
18970 (PopulateIndexer): Apply attributes everywhere.
18972 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
18975 (ApplyAttributes): Update accordingly.
18977 We now apply interface attributes for all members too.
18979 2002-05-26 Miguel de Icaza <miguel@ximian.com>
18981 * class.cs (Indexer.Define); Correctly check if we are explicit
18982 implementation (instead of checking the Name for a ".", we
18983 directly look up if the InterfaceType was specified).
18985 Delay the creation of the PropertyBuilder.
18987 Only create the PropertyBuilder if we are not an explicit
18988 interface implementation. This means that explicit interface
18989 implementation members do not participate in regular function
18990 lookups, and hence fixes another major ambiguity problem in
18991 overload resolution (that was the visible effect).
18993 (DefineMethod): Return whether we are doing an interface
18996 * typemanager.cs: Temporary hack until we get attributes in
18997 interfaces (Ravi is working on that) and we get IndexerName
18998 support in interfaces.
19000 * interface.cs: Register the indexers as properties.
19002 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
19003 warning, I have verified that this is a bug in the .NET runtime
19004 (JavaScript suffers of the same problem).
19006 * typemanager.cs (MemberLookup): When looking up members for
19007 interfaces, the parent of an interface is the implicit
19008 System.Object (so we succeed in searches of Object methods in an
19009 interface method invocation. Example: IEnumerable x; x.ToString
19012 2002-05-25 Miguel de Icaza <miguel@ximian.com>
19014 * class.cs (Event): Events should also register if they do
19015 implement the methods that an interface requires.
19017 * typemanager.cs (MemberLookup); use the new GetInterfaces
19020 (GetInterfaces): The code used to lookup interfaces for a type is
19021 used in more than one place, factor it here.
19023 * driver.cs: Track the errors at the bottom of the file, we kept
19026 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
19027 instance if the method we are calling is static!
19029 2002-05-24 Miguel de Icaza <miguel@ximian.com>
19031 * attribute.cs (ApplyAttributes): Make this function filter out
19032 the IndexerName attribute (as that attribute in reality is never
19033 applied) and return the string constant for the IndexerName
19036 * class.cs (TypeContainer.Emit): Validate that all the indexers
19037 have the same IndexerName attribute, and if so, set the
19038 DefaultName attribute on the class.
19040 * typemanager.cs: The return value might contain other stuff (not
19041 only methods). For instance, consider a method with an "Item"
19042 property and an Item method.
19044 * class.cs: If there is a problem with the parameter types,
19047 2002-05-24 Ravi Pratap <ravi@ximian.com>
19049 * ecore.cs (ImplicitConversionExists): Wrapper function which also
19050 looks at user defined conversion after making a call to
19051 StandardConversionExists - we need this for overload resolution.
19053 * expression.cs : Update accordingly the various method calls.
19055 This fixes 2 bugs filed against implicit user defined conversions
19057 2002-05-22 Miguel de Icaza <miguel@ximian.com>
19059 * statement.cs: Track the result of the assignment.
19061 2002-05-21 Miguel de Icaza <miguel@ximian.com>
19063 * expression.cs (MemberAccess): Improved error reporting for
19064 inaccessible members.
19066 2002-05-22 Martin Baulig <martin@gnome.org>
19068 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
19069 itself with debugging support.
19071 2002-05-22 Martin Baulig <martin@gnome.org>
19073 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
19074 Removed, this isn't needed anymore.
19076 2002-05-20 Martin Baulig <martin@gnome.org>
19078 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
19079 be underlying type for an enum.
19081 2002-05-20 Miguel de Icaza <miguel@ximian.com>
19083 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
19084 that splits out the loading of just the core types.
19086 * rootcontext.cs (ResolveCore): Split the struct resolution in
19087 two, so we can load the enumeration underlying types before any
19090 * expression.cs (Is): Bandaid until we fix properly Switch (see
19091 bug #24985 for details).
19093 * typemanager.cs (ImplementsInterface): The hashtable will contain
19094 a null if there are no interfaces implemented.
19096 2002-05-18 Miguel de Icaza <miguel@ximian.com>
19098 * cs-parser.jay (indexer_declarator): It is fine to have array
19101 2002-05-17 Miguel de Icaza <miguel@ximian.com>
19103 * typemanager.cs: (RegisterBuilder): New function used to register
19104 TypeBuilders that implement interfaces. Since
19105 TypeBuilder.GetInterfaces (as usual) does not work with lame
19107 (AddUserType): register interfaces.
19109 (ImplementsInterface): Use the builder_to_ifaces hash if we are
19110 dealing with TypeBuilder. Also, arrays are showing up as
19111 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
19112 methods can not be invoked on them!
19114 * ecore.cs (ExplicitReferenceConversionExists): Made public.
19115 (ImplicitReferenceConversionExists): Split out from
19116 StandardConversionExists.
19118 * expression.cs (As): We were only implementing one of the three
19119 cases for the as operator. We now implement them all.
19120 (Is): Implement the various other cases for Is as well.
19122 * typemanager.cs (CACHE): New define used to control if we want or
19123 not the FindMembers cache. Seems to have a negative impact on
19124 performance currently
19126 (MemberLookup): Nested types have full acess to
19127 enclosing type members
19129 Remove code that coped with instance/static returns for events, we
19130 now catch this in RealFindMembers.
19132 (RealFindMembers): only perform static lookup if the instance
19133 lookup did not return a type or an event.
19135 2002-05-17 Miguel de Icaza <miguel@ximian.com>
19137 * assign.cs (CompoundAssign): We pass more semantic information
19138 now to Compound Assignments than we did before: now we have all
19139 the information at hand, and now we resolve the target *before* we
19140 do the expression expansion, which allows the "CacheValue" method
19141 to have the effect we intended (before, a [x] += 1 would generate
19142 two differen ArrayAccess expressions from the ElementAccess,
19143 during the resolution process).
19145 (CompoundAssign.DoResolve): Resolve target and original_source here.
19147 2002-05-16 Miguel de Icaza <miguel@ximian.com>
19149 * expression.cs (ArrayAccess): dropped debugging information.
19151 * typemanager.cs: Small bug fix: I was always returning i_members,
19152 instead of one of i_members or s_members (depending on which had
19155 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
19156 method is invoked before any code generation takes place, and it
19157 is a mechanism to inform that the expression will be invoked more
19158 than once, and that the method should use temporary values to
19159 avoid having side effects
19161 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
19163 * ecore.cs (Expression.CacheTemporaries): Provide empty default
19166 * expression.cs (Indirection, ArrayAccess): Add support for
19167 CacheTemporaries in these two bad boys.
19169 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
19170 ldobj or ldind_ref.
19171 (StoreFromPtr): Handle stobj as well.
19173 * expression.cs (UnaryMutator): Share more code.
19175 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
19176 down: I was not tracking the Filter function as well, which
19177 was affecting the results of the cache.
19179 2002-05-15 Miguel de Icaza <miguel@ximian.com>
19181 * attribute.cs: Remove the hack to handle the CharSet property on
19184 2002-05-14 Miguel de Icaza <miguel@ximian.com>
19186 * attribute.cs (DoResolve): More uglyness, we now only try to
19187 resolve the attribute partially, to extract the CharSet
19188 information (only if we are a StructLayout attribute). Otherwise
19190 (GetExtraTypeInfo): Add some code to conditionally kill in the
19191 future this. I am more and more convinced that the .NET
19192 framework has special code to handle the attribute setting on
19195 * expression.cs (IsParamsMethodApplicable): Revert my previous
19196 foreach change here, it was wrong.
19198 2002-05-13 Miguel de Icaza <miguel@ximian.com>
19200 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
19201 (pp_expr): do not abort on unknown input, just return.
19202 (eval): abort if there are pending chars.
19204 * attribute.cs (Attribute.Resolve): Positional parameters are
19205 optional. Deal with that case.
19207 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
19208 the Ansi/Unicode/Auto information for the type.
19210 (TypeContainer.DefineType): instantiate the EmitContext here, as
19211 we will be using it during the type definition (to resolve
19212 attributes) and during the emit phase.
19214 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
19215 to pull type information out of the attributes
19217 (Attribute.Resolve): track the constructor builder, and allow for
19218 multiple invocations (structs and classes will use this).
19220 * ecore.cs (MemberLookupFinal): new version with all the
19221 parameters customizable.
19223 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
19224 constructors. Return if the result value is null (as the error
19225 would have been flagged already by MemberLookupFinal)
19227 Do not allow instances of abstract classes or interfaces to be
19230 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
19231 We have to compare the assembly property here when dealing with
19232 FamANDAssem and Assembly access modifiers, because we might be
19233 creating an assembly from *modules* (that means that we are not
19234 getting TypeBuilders for types defined in other modules that are
19235 part of this assembly).
19237 (Method.Emit): If the method is marked abstract and has a body,
19240 (TypeContainer.DefineMembers): If both the defined member and the
19241 parent name match are methods, then do not emit any warnings: let
19242 the Method.Define routine take care of flagging warnings. But if
19243 there is a mismatch (method overrides something else, or method is
19244 overriwritten by something, then emit warning).
19246 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
19247 set to null, this means `do not check for the return type on the
19250 (Method.Define): set the return type for the method signature to
19251 null, so that we get methods with the same name and parameters and
19252 different return types. This is used to flag warning 114 (you are
19253 hiding a method, and you probably want to use the new/override
19256 * typemanager.cs (MemberLookup): Implemented proper access
19257 control, closing a long standing set of bug reports. The problem
19258 was that the Framework only has two bits: Public and NonPublic,
19259 and NonPublic includes private and protected methods, but we need
19260 to enforce the FamANDAssem, FamOrAssem and Family.
19262 2002-05-11 Miguel de Icaza <miguel@ximian.com>
19264 * statement.cs (GotoCase): Return true: Ammounts to giving up
19265 knowledge on whether we return or not, and letting the other case
19266 be responsible for it.
19268 2002-05-10 Miguel de Icaza <miguel@ximian.com>
19270 * driver.cs: Do not load directories for each file processed, only
19271 do it if there is a pattern.
19273 * ecore.cs: Report readonly assigns here as well, as we might have
19274 been resolved only by MemberAccess.
19276 (SimpleName.SimpleNameResolve): Also be useful for LValue
19277 resolution. We need this to propagate assign to local readonly variables
19279 * typemanager.cs: Use a ptrhashtable for the criteria, because we
19280 do not want to reuse potential criteria memory.
19282 * class.cs (MyEventBuilder): Set reflected_type;
19284 * ecore.cs (Constantify): Added support for constifying bools.
19286 (RootContext.LookupType): Added a cache for values looked up in
19287 the declaration space.
19289 * typemanager.cs (FindMembers): Now is a front-end to
19290 RealFindMembers, and provides a two-level hashtable-based cache to
19293 15% performance improvement: from 22.5 to 19.2 seconds.
19295 * expression.cs (IsParamsMethodApplicable): use foreach.
19296 (Invocation.DoResolve): ditto.
19297 (New.DoResolve): ditto.
19298 (ArrayCreation.DoResolve): ditto.
19300 * ecore.cs (FindMostEncompassingType): use foreach.
19302 * delegate.cs (NewDelegate.DoResolve): Use foreach
19304 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
19305 (RemoveMethods): use foreach.
19307 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
19308 nested foreach statements instead of for, and also break out of
19309 the inner loop once a match is found.
19311 (Invocation.OverloadResolve): Use foreach, simplify the code.
19313 2002-05-08 Miguel de Icaza <miguel@ximian.com>
19315 * cfold.cs (BinaryFold): During an enumeration evaluation context,
19316 we actually unwrap the expression to allow for extra information
19319 * expression.cs: Use Shr_Un on unsigned operations.
19321 2002-05-08 Ravi Pratap <ravi@ximian.com>
19323 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
19324 applicable operators was not being considered correctly. This closes
19325 the bug Miguel reported.
19327 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
19329 * attribute.cs: check that the type derives from System.Attribute
19330 and report the correct error in that case (moved the duplicate code to
19331 its own method, too).
19333 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
19335 * attribute.cs: lookup attribute type name as the spec says: first the
19336 bare attribute name and then name + "Attribute" (nant compiles with
19337 mcs after this fix).
19339 2002-05-07 Miguel de Icaza <miguel@ximian.com>
19341 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
19342 Because of the way we parse things, we should try to see if a
19343 UIntConstant can fit in an integer.
19345 2002-05-07 Ravi Pratap <ravi@ximian.com>
19347 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
19348 when we are in an explicit context.
19350 (ConvertReferenceExplicit): When converting from Iface type S to Class
19351 T make sure the rules are implemented as an OR.
19353 * parameter.cs (ParameterType): Make it a property for now although the
19354 purpose really isn't anything immediate.
19356 * expression.cs (Is*Applicable): Do better checking on the parameter type
19357 of a ref/out parameter. The ones from the system assemblies are already
19358 marked with the correct type so we don't need to do any correction.
19360 * ecore.cs (StandardConversionExists): Conversion from Interface types to
19361 the object type is standard too so include that.
19363 2002-05-06 Miguel de Icaza <miguel@ximian.com>
19365 * ecore.cs (StandardConversionExists): Augment with missing code:
19366 deal with IntConstant, LongConstants and Enumerations.
19368 * assign.cs: Report the error, instead of failing silently
19370 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
19371 typecontainer that they are declared, because the
19372 typecontainer/namespace will have the list of using clauses that
19373 need to be applied.
19375 Assembly Attributes were escaping the normal registration
19378 (EmitCode): Apply attributes within an EmitContext that represents
19379 the container they were declared on.
19381 * cs-parser.jay: Track bases for structs. How did I get this wrong?
19383 2002-05-06 Ravi Pratap <ravi@ximian.com>
19385 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
19386 Revamp completely - make much cleaner as we now operate only
19389 (FindMostSpecificSource, FindMostSpecificTarget): New methods
19390 to implement the logic detailed in the spec more correctly.
19392 (UserDefinedConversion): Update accordingly.
19394 2002-05-06 Miguel de Icaza <miguel@ximian.com>
19396 * statement.cs: Return flow analysis information up.
19398 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
19401 (token): Do not consume an extra character before calling
19404 2002-05-06 Piers Haken <piersh@friskit.com>
19406 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
19408 2002-05-06 Miguel de Icaza <miguel@ximian.com>
19410 * class.cs (Constructor.Emit): Set the IsStatic flag in the
19411 EmitContext during the instance constructor initializer
19412 resolution, to stop access to instance variables.
19414 This is mandated by the spec, last paragraph of the `constructor
19415 initializers' section.
19417 2002-05-05 Miguel de Icaza <miguel@ximian.com>
19419 * cs-parser.jay, class.cs (Accessor): new class used to represent
19420 an accessor (get or set). In the past we used `null' to represent
19421 a missing accessor. But this is ambiguous because there was no
19422 way to tell in abstract indexers/properties if one of them was
19425 Now there is a way of addressing that.
19427 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
19428 instead of FindMembers.
19430 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
19431 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
19433 * attribute.cs: Treat indexers and properties as the same in terms
19434 of applying attributes
19436 * ecore.cs (FindMostEncompassedType): Use statically initialized
19437 EmptyExpressions()s like we do elsewhere to avoid creating useless
19438 objects (and we take this out of the tight loop).
19440 (GetConversionOperators): Move the code to extract the actual
19441 operators to a separate routine to clean things up.
19443 2002-05-04 Miguel de Icaza <miguel@ximian.com>
19445 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
19446 events are always registered FieldBuilders.
19448 * class.cs (FieldBase): New class shared by Fields
19450 * delegate.cs: If we are a toplevel delegate, use our full name.
19451 If we are a nested delegate, then only use our tail name.
19453 2002-05-02 Ravi Pratap <ravi@ximian.com>
19455 * expression.cs (IsApplicable): Ensure that we add the "&" to
19456 ref/out types before comparing it with the type of the argument.
19458 (IsParamsMethodApplicable): Ditto.
19460 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
19463 * delegate.cs : Handle the case when we have more than one applicable
19464 method. Flag an error only when we finish checking all.
19466 2002-05-02 Miguel de Icaza <miguel@ximian.com>
19468 * expression.cs: Add support for boolean static initializers.
19470 2002-05-01 Miguel de Icaza <miguel@ximian.com>
19472 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
19474 * parameter.cs (ComputeParameterTypes,
19475 ComputeAndDefineParameterTypes): Better error handling: now we
19476 clear the `types' cache if we fail during any of the type lookups.
19477 We also return the status code correctly to our caller
19479 * delegate.cs: If we fail to define a delegate, abort the extra
19482 * expression.cs (Binary.ResolveOperator): for
19483 operator==(object,object) and operator !=(object, object) we also
19484 have to verify that there is an implicit conversion from one to
19487 (ArrayAccess.DoResolve): Array Access can operate on
19490 2002-04-30 Miguel de Icaza <miguel@ximian.com>
19492 * assign.cs (CompoundAssign): A new class used as a "flag" that
19493 the assignment actually is happening as part of a compound
19494 assignment operator.
19496 During compound assignment, a few new rules exist to enable things
19503 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
19504 to the type of x) if y is implicitly convertible to the type of x,
19505 and the operator is a builtin operator and the return type of the
19506 operator is explicitly convertible to the type of x.
19508 * rootcontext.cs: Reset warning level to 2. 4 catches various
19509 "interesting" features in mcs, we must clean this up at some
19510 point, but currently am trying to kill other bugs ;-)
19512 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
19513 in container classes as well.
19515 * expression.cs (Binary.ResolveOperator): Handle string case
19516 before anything else (as operator overloading does emit an error
19517 before doing anything else).
19519 This code could go away when we move to a table driven model, but
19520 i could not come up with a good plan last night.
19522 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
19524 * typemanager.cs (CSharpName): reimplementation using regex.
19525 * class.cs: added null check for fields in Emit
19526 * rootcontext.cs: set warninglevel to 4
19528 2002-04-29 Miguel de Icaza <miguel@ximian.com>
19530 * typemanager.cs (CSharpName): reimplemented with Lupus
19533 2002-04-28 Miguel de Icaza <miguel@ximian.com>
19535 * statement.cs (If): correclty implement Resolve, because we were
19536 not catching sem errors in there. The same process is needed
19538 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
19541 (Statement.Warning_DeadCodeFound): Factorize code.
19542 (While): Report dead code here too.
19544 (Statement): Added Resolve virtual method to allow
19545 for resolution split from the emit code.
19547 2002-04-26 Miguel de Icaza <miguel@ximian.com>
19549 * statement.cs (EmitBoolExpression): No longer try to resolve the
19551 (MakeBoolean): New utility function that resolve, implicitly
19552 converts to boolean and tags the expression.
19555 (If, Do): Implement dead code elimination.
19556 (While): Implement loop inversion
19558 (Do, While, For, If): Resolve the expression prior to calling our
19561 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
19564 - added method Report28 (warning: program has more than one entry point)
19565 - added method IsEntryPoint, implements paragraph 10.1 of the spec
19566 - modified method Method.Define, the part at the end of the method
19568 * rootcontext.cs: added static public Location EntryPointLocation;
19570 * ../errors/cs0028.cs : Add test case for the above warning.
19573 - modified method CSharpName to allow arrays of primitive type to
19574 be printed nicely (e.g. instead of System.Int32[][] it now prints
19576 - added method CSharpSignature: returns the signature of a method
19577 in string format to be used in reporting errors, warnings, etc.
19579 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
19582 2002-04-26 Ravi Pratap <ravi@ximian.com>
19584 * delegate.cs (Define): Fix extremely silly bug where I was
19585 setting the type of the 'object' parameter of the BeginInvoke
19586 method to System.IAsyncResult instead of System.Object ;-)
19588 2002-04-26 Miguel de Icaza <miguel@ximian.com>
19590 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
19593 (Constructor.Emit): return if we fail to initialize the
19594 constructor. Another door closed!
19596 * expression.cs (New.DoResolve): Improve error message (from -6 to
19597 1501). Use DeclaredOnly lookup to find the exact constructor.
19599 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
19600 loop. This is useful.
19602 * cs-parser.jay: Adjust the default parameters so that destructors
19603 have the proper signature.
19605 2002-04-26 Martin Baulig <martin@gnome.org>
19607 * driver.cs (LoadAssembly): If `assembly' contains any characters
19608 which are only valid in path names and not in assembly names
19609 (currently slash, backslash and point), use Assembly.LoadFrom ()
19610 instead of Assembly.Load () on the `assembly' (before iteration
19611 over the link_paths).
19613 2002-04-26 Martin Baulig <martin@gnome.org>
19615 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
19617 2002-04-25 Miguel de Icaza <miguel@ximian.com>
19619 * class.cs (Property): use the new typemanager.MemberLookup
19621 (TypeContainer.MemberLookup): Implement using the
19622 TypeManager.MemberLookup now.
19624 * typemanager.cs: Make MemberLookup a function of the TypeManager,
19625 and return MemberInfos, so that these can be used without an
19626 EmitContext (what we had before).
19628 2002-04-24 Miguel de Icaza <miguel@ximian.com>
19630 * expression.cs: Fix the case where the argument to params if the
19631 type of the params. I omitted handling this before. Fixed
19633 2002-04-22 Miguel de Icaza <miguel@ximian.com>
19635 * driver.cs: Call BootCorlib_PopulateCoreType
19637 * class.cs (Property.CheckBase): Check for properties only, not
19640 * interface.cs: Temporary hack: try/catch around the
19641 CustomAttributeBuilder, because I am getting an exception that I
19644 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
19645 types whose definitions are required to be there (attributes are
19646 defined before standard types).
19648 Compute definitions as we boot the various types, as they are used
19649 immediately (value_type class will need object_type, but if we do
19650 not initialize object_type, we will pass a null, which will let
19651 the runtime pick the System.Object from the existing corlib, which
19652 is not what we want).
19654 2002-04-22 Patrik Torstensson <totte@labs2.com>
19656 * cs-tokenizer.cs: fixed a number of trim() issues.
19658 2002-04-22 Ravi Pratap <ravi@ximian.com>
19660 * expression.cs (Argument.Type): Ensure that we return the correct
19661 type when we have out or ref parameters [in which case we
19664 2002-04-22 Miguel de Icaza <miguel@ximian.com>
19666 * class.cs (Property, Indexer): Allow extern modifier in there.
19668 * typemanager.cs (InitBaseTypes): Initializes object_type and
19669 value_type, since those will be used early on during the bootstrap
19670 process to compile corlib.
19672 (InitCoreTypes): Move code from here to InitBaseTypes.
19674 2002-04-21 Miguel de Icaza <miguel@ximian.com>
19676 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
19677 single-dimension arrays as using the ldlen opcode.
19679 Daniel Lewis discovered this optimization.
19681 * typemanager.cs: Add signature for System.Array::get_Length
19683 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19685 * statement.cs: report the error when the foreach does not apply to an
19686 array nor a collection.
19688 2002-04-19 Miguel de Icaza <miguel@ximian.com>
19690 * expression.cs: Add implicit conversions to the operator ~.
19692 * constant.cs (DecimalConstant.Emit): Emit decimal value.
19694 * typemanager.cs: Locate the decimal constructor.
19696 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19698 * attribute.cs: use the new property of TypeOf.
19699 * expression.cs: added 'get' property around typearg.
19701 These changes fix a build breaker reported by NickD. Is this the
19702 correct way to fix? If not, please, revert my changes and make it
19705 2002-04-17 Miguel de Icaza <miguel@ximian.com>
19707 * attribute.cs: Add support for typeof in attribute invocations.
19708 I am not sure that this is right though.
19710 2002-04-14 Duncan Mak <duncan@ximian.com>
19712 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
19713 Binary.Operator.Division case.
19715 2002-04-13 Ravi Pratap <ravi@ximian.com>
19717 * class.cs (DefineType): Ensure that we do a proper check on
19718 attribute types and also register it with the TypeManager.
19720 (TypeContainer.Targets): The default for attribute types is
19721 AttributeTargets.All.
19723 * attribute.cs (ApplyAttributes): Registering the attribute type
19724 is done elsewhere, not when we discover we have a Usage attribute.
19726 2002-04-12 Ravi Pratap <ravi@ximian.com>
19728 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
19729 and get rid of is_delegate parameter.
19731 * everywhere : update.
19733 2002-04-12 Ravi Pratap <ravi@ximian.com>
19735 * cs-parser.jay (compilation_unit): Revamp completely to use
19736 some new ideas that I got from Rhys' grammar to solve the problems
19737 with assembly level attributes.
19739 (outer_declaration): New grammar production.
19741 (attribute_sections): Add.
19743 (opt_attributes): Base on attribute_sections
19745 (namespace_declaration): Allow opt_attributes to tackle the case
19746 when we have assembly level attributes - we are clever in this
19749 * attribute.cs (ApplyAttributes): Do not worry about assembly
19750 attributes in the non-global context.
19752 * rootcontext.cs (AddGlobalAttributes): Go back to using this
19753 instead of SetGlobalAttributes.
19755 * class.cs, rootcontext.cs : Ensure we define and generate
19756 attribute types before anything else.
19758 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
19759 and flag the new error -20 for the case when the attribute type
19760 does not have valid targets specified. csc does not catch this.
19762 * ../errors/errors.txt : update for error # -20
19764 2002-04-11 Ravi Pratap <ravi@ximian.com>
19766 * support.cs (InternalParameters.ParameterModifier): Do some null
19767 checking and return sane values.
19769 * class.cs (Method.Define): If we are a PInvoke method, ensure
19770 that we are static and extern. Report error # 601
19772 * ../errors/cs0601.cs : Add test case for the above error.
19774 2002-04-07 Ravi Pratap <ravi@ximian.com>
19776 * rootcontext.cs (attribute_types): We need to keep type of
19777 all attribute types separately and emit code for them first.
19779 (RegisterAttribute) : Implement.
19781 * class.cs (DefineType): Check if the current Type is a custom
19782 attribute type and register it accordingly.
19784 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
19785 adding the first attribute twice and rename to
19787 (SetGlobalAttributes): this.
19789 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
19792 * attribute.cs (ApplyAttributes): Take an additional argument telling us
19793 if we are processing global arguments. Hmm, I am unsure of this.
19795 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19797 * expression.cs: added static array of strings to avoid calling
19798 Enum.ToString () for Operator in Binary. Significant recover of
19801 2002-04-10 Miguel de Icaza <miguel@ximian.com>
19803 * class.cs (FindMembers): Allow the Builders of the various
19804 members to be null. If they are skip them. This only happens
19805 during the PInvoke declaration.
19807 2002-04-09 Miguel de Icaza <miguel@ximian.com>
19809 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
19810 failure, so we do not keep going afterwards.
19812 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
19813 wanted to pass `false' as the `is_delegate' argument. If this is
19814 the case, why not use delegate_type == null to mean `is_delegate =
19815 false' and anything else as is_delegate = true.
19817 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
19819 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
19820 code for the section, not the beginning of the tests.
19822 2002-04-08 Miguel de Icaza <miguel@ximian.com>
19824 * cfold.cs: Handle operator + (Enum x, Underlying x)
19826 * expression.cs (Binary): same. Warn about errors where we have
19827 Enum/Enum in operator + as well.
19829 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
19832 - added support for switch(bool)
19833 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
19834 - add TableSwitchEmit() to handle table-based switch statements
19836 2002-04-05 Ravi Pratap <ravi@ximian.com>
19838 * expression.cs (Invocation.OverloadResolve): Factor out code which
19839 does parameter compatibility checking with arguments so that we can
19840 re-use the code even from Delegate.VerifyApplicability
19842 (VerifyArgumentsCompat): Move above code here.
19844 * delegate.cs (VerifyApplicability): Get rid of duplicate code
19845 and instead make a call to the above method.
19847 2002-03-31 Ravi Pratap <ravi@ximian.com>
19849 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
19850 We use it to keep track of classes which are attribute types.
19852 2002-04-02 Miguel de Icaza <miguel@ximian.com>
19854 * delegate.cs (Delegate.Define): Correctly define the types in the
19855 presence of fixed and array parameters.
19857 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
19860 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
19861 include NonPublic after the first iteration.
19863 * class.cs (Indexer.CheckBase): Only check if both parents are
19866 * cs-parser.jay (accessor_body): If empty, set to null.
19868 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
19869 same code path here to resolve constants names that we did have in
19870 MemberAccess.DoResolve. There is too much code duplicated here.
19872 2002-04-01 Miguel de Icaza <miguel@ximian.com>
19874 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
19876 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
19879 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
19880 tokens, numbers and strings.
19882 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
19885 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
19886 asyncronous parameters and the regular parameters.
19888 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
19889 specify the target directory.
19891 * expression.cs: (This.DoResolve): Simplify
19892 (As.Emit): Optimize, do not generate IsInst if the expression is
19893 always of the given type.
19895 (Is.DoResolve): Bug fix, we were reporting both always/never for
19898 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
19899 creating too many unnecessary arrays.
19901 2002-03-31 Miguel de Icaza <miguel@ximian.com>
19903 * class.cs (EmitFieldInitializer): Use Assign expression to assign
19904 fields instead of rolling our own initializer. Takes care of all
19905 implicit conversions, and drops unnecessary static checks/argument.
19907 2002-03-31 Dick Porter <dick@ximian.com>
19909 * driver.cs: use the GetDirectories() return values properly, and
19910 use "/" as path separator.
19912 2002-03-30 Miguel de Icaza <miguel@ximian.com>
19914 * expression.cs (Unary): Optimize - - expr into expr.
19915 (Binary): Optimize a + (-b) into a -b.
19917 * codegen.cs (CodeGen): Made all methods static.
19919 2002-03-29 Miguel de Icaza <miguel@ximian.com>
19923 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
19924 TypeBuilder property.
19926 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
19929 * tree.cs: Removed the various RecordXXXX, and replaced with a
19930 single RecordDecl. Removed all the accessor methods, and just
19931 left a single access point Type
19933 * enum.cs: Rename DefineEnum to DefineType.
19935 * decl.cs: New abstract method `DefineType' used to unify the
19936 Defines for Enumerations, Interfaces, TypeContainers and
19939 (FindType): Moved LookupInterfaceOrClass here. Moved the
19940 LookupBaseClasses method that used to live in class.cs and
19941 interface.cs here, and renamed to FindType.
19943 * delegate.cs: Implement DefineType. Take advantage of the
19944 refactored pattern for locating the parent builder without taking
19945 the parent_builder argument (which we know does not work if we are
19946 nested, and triggering a toplevel definition).
19948 2002-03-28 Miguel de Icaza <miguel@ximian.com>
19950 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
19951 accessibility of a member has changed during override and report
19954 * class.cs (Method.Define, Property.Define): Only complain on
19955 overrides if the method is private, any other accessibility is
19956 fine (and since we just checked the permission is the same, we are
19959 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
19960 and elif are processed always. The other pre-processing
19961 directives are only processed if we are "taking" the path
19963 2002-03-29 Martin Baulig <martin@gnome.org>
19965 * class.cs (Method.Emit): Only emit symbolic debugging info if the
19966 current location is not Null.
19968 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
19969 a separate method so we can profile it.
19971 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
19972 `span.Seconds' are just seconds, but no minutes or hours.
19973 (MainDriver): Profile the CodeGen.SaveSymbols calls.
19975 2002-03-28 Miguel de Icaza <miguel@ximian.com>
19977 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
19978 Remove the gratuitous set of Final:
19980 // If an interface implementation, then we can set Final.
19981 if (((flags & MethodAttributes.Abstract) == 0) &&
19982 implementing.DeclaringType.IsInterface)
19983 flags |= MethodAttributes.Final;
19985 I do not know what I was smoking when I used that.
19988 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
19989 step into fixing the name resolution issues for delegates and
19990 unifying the toplevel name resolution.
19992 2002-03-28 Martin Baulig <martin@gnome.org>
19994 * class.cs (Method.Emit): If we have a symbol writer, call its
19995 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
19996 tell it about the current method.
19998 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
19999 writer that we're going to emit the first byte of IL code for a new
20000 statement (a new source line).
20001 (EmitContext.EmitTopBlock): If we have a symbol writer, call
20002 EmitContext.Mark() before emitting any code.
20004 * location.cs (SymbolDocument): Return null when we're Null.
20006 * statement.cs (Statement): Moved the `Location loc' variable here.
20007 (Statement.EmitBoolExpression): If we have a symbol writer, call
20008 ec.Mark() before emitting any code to tell it that we're at the
20009 beginning of a new statement.
20010 (StatementExpression): Added `Location' argument to the constructor.
20011 (Block): Added public readonly variable `StartLocation' and public
20012 variable `EndLocation'. The latter is to be set using SetEndLocation().
20013 (Block): Added constructor which takes a start and end location.
20014 (Block.SetEndLocation): New method. This sets the end location.
20015 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
20016 local variables we create.
20017 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
20018 each statement and do also mark the begin and end of the block.
20020 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
20021 tell it the current lexer.Location, use Location.Null for the end of the
20023 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
20024 current block, set its end location using SetEndLocation().
20025 (statement_expression): StatementExpression constructor now takes the
20026 lexer.Location as additional argument.
20027 (for_statement, declare_local_variables): Likewise.
20028 (declare_local_variables): When creating a new implicit block, use the
20029 new Block constructor and pass it the lexer.Location.
20031 2002-03-28 Miguel de Icaza <miguel@ximian.com>
20033 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
20034 members also on the parent interfaces recursively.
20036 2002-03-27 Miguel de Icaza <miguel@ximian.com>
20038 * report.cs: Use new formats, since Gonzalo finished the missing
20041 * expression.cs (Binary.ResolveOperator): added missing operator|
20042 operator& and operator^ for bool/bool.
20044 * cs-parser.jay: CheckDef now takes a Location argument that is
20045 used to report errors more precisly (instead of reporting the end
20046 of a definition, we try to track something which is a lot closer
20047 to the source of the problem).
20049 * cs-tokenizer.cs: Track global token use, so we can properly flag
20050 the use of #define/#undef after the first token has been seen.
20052 Also, rename the reportXXXX to Error_DescriptiveName
20054 * decl.cs (DeclSpace.IsTopLevel): Move property here from
20055 TypeContainer, so that Enum and Interface can use this too.
20057 * class.cs (TypeContainer.LookupInterfaceOrClass,
20058 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
20059 `builder' argument. Typically this was used to pass the parent
20060 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
20063 The problem is that a nested class could trigger the definition of
20064 a toplevel class, and the builder would be obviously wrong in that
20067 So we drop this argument, and we compute dynamically the
20068 TypeBuilder/ModuleBuilder (the correct information was available
20069 to us anyways from DeclSpace.Parent)
20071 * interface.cs (Interface.DefineInterface): Drop builder
20072 parameter cleanup like class.cs
20074 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
20077 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
20080 (Try.Emit): Propagate the returns value from the statement.
20082 (Return.Emit): Even if we are leavning
20084 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
20086 * modifiers.cs: Fix the computation of MethodAttributes flags.
20088 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
20090 * driver.cs: allow compilation of files that start with '/'.
20091 Add a default case when checking the argument of --target.
20093 2002-03-25 Miguel de Icaza <miguel@ximian.com>
20095 * interface.cs: Implement the same search algorithm for types in
20096 the interface code.
20098 * delegate.cs: Do not allow multiple definition.
20100 * Recovered ChangeLog that got accidentally amputated
20102 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
20104 * rootcontext.cs: Load manually enum to allow core classes to
20105 contain enumerations.
20107 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
20108 Update to new static methods in TypeManager.
20110 * typemanager.cs (GetMethod, GetConstructor): Use our
20111 implementation of FindMembers to find the members, since during
20112 corlib compilation, the types are TypeBuilders and GetMethod and
20113 GetConstructor do not work.
20115 Make all methods in TypeManager static.
20117 (InitCodeHelpers): Split the functionality from
20118 the InitCodeTypes function.
20120 * driver.cs: Call InitCodeHelpers after we have populated the
20123 * cs-parser.jay (delegate_declaration): we did not used to compute
20124 the delegate name correctly for void delegates.
20126 2002-03-24 Miguel de Icaza <miguel@ximian.com>
20128 * rootcontext.cs (RootContext): Init the interface_resolve_order
20129 and type_container_resolve_order always.
20131 (ResolveCore, BootstrapCorlib_ResolveClass,
20132 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
20133 compiler when compiling with --nostdlib
20135 * class.cs (TypeContainer.DefineType): Check that our parent is
20136 not null. This test is most important when we are bootstraping
20139 * codegen.cs: Split out the symbol writing code.
20141 2002-03-25 Martin Baulig <martin@gnome.org>
20143 * driver.cs (-g): Made -g an alias for --debug.
20145 2002-03-24 Martin Baulig <martin@gnome.org>
20147 * codegen.cs (SymbolWriter): New public variable. Returns the
20148 current symbol writer.
20149 (CodeGen): Added `bool want_debugging_support' argument to the
20150 constructor. If true, tell the ModuleBuild that we want debugging
20151 support and ask it for the ISymbolWriter.
20152 (Save): If we have a symbol writer, call it's Close() method after
20153 saving the assembly.
20155 * driver.c (--debug): New command line argument to create a
20156 debugger information file.
20158 * location.cs (SymbolDocument): New public property. Returns an
20159 ISymbolDocumentWriter object for the current source file or null
20160 if we don't have a symbol writer.
20162 2002-03-21 Miguel de Icaza <miguel@ximian.com>
20164 * driver.cs (LoadAssembly): Correctly return when all the paths
20165 have been tried and not before.
20167 * statement.cs (Switch.Emit): return the actual coverage for this
20168 statement (returns/not-returns)
20170 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
20171 switch of the statement if we are the last switch section. That
20172 kills two problems: try/catch problems (we used to emit an empty
20173 nop at the end) and switch statements where all branches would
20176 2002-03-19 Miguel de Icaza <miguel@ximian.com>
20178 * driver.cs: Add default assemblies (the equivalent to the
20179 Microsoft CSC.RSP file)
20181 * cs-tokenizer.cs: When updating `cols and setting it to zero,
20182 also update tokens_seen and set it to false.
20184 * driver.cs: Implement --recurse for Mike.
20186 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
20187 correctly splitting out the paths.
20189 2002-03-18 Miguel de Icaza <miguel@ximian.com>
20191 * interface.cs (Interface.PopulateProperty): Instead of using
20192 `parent' as the declaration space for the set parameters, use
20195 * support.cs (InternalParameters): InternalParameters constructor
20196 takes a DeclSpace instead of a TypeContainer.
20198 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
20199 types are being initialized, load the address of it before calling
20202 (New): Provide a mechanism to disable the generation of local
20203 value type temporaries when the caller will be providing us with
20204 an address to store it.
20206 (ArrayCreation.EmitDynamicInitializers): Use it.
20208 2002-03-17 Miguel de Icaza <miguel@ximian.com>
20210 * expression.cs (Invocation.EmitArguments): Only probe for array
20211 property if there is more than one argument. Sorry about that.
20213 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
20214 empty param arrays.
20216 * class.cs (Method.LabelParameters): Fix incorrect code path that
20217 prevented the `ParamArrayAttribute' from being applied to the
20220 2002-03-16 Miguel de Icaza <miguel@ximian.com>
20222 * support.cs (ReflectionParameters): Correctly compute whether the
20223 last argument is a params array. Fixes the problem with
20226 * typemanager.cs: Make the assemblies array always be non-null
20227 (empty, but non-null)
20229 * tree.cs (RecordDecl): New function that abstracts the recording
20230 of names. This reports error 101, and provides a pointer to the
20231 previous declaration. Fixes a crash in the compiler.
20233 * cs-parser.jay (constructor_declaration): Update to new grammar,
20234 and provide a constructor_body that can be empty.
20236 2002-03-15 Miguel de Icaza <miguel@ximian.com>
20238 * driver.cs: Add support for --resources.
20240 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
20241 Make all types for the various array helper methods be integer.
20243 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
20244 CheckState to ConvCast.
20246 (ConvCast): Now it takes a `checked' state argument, to avoid
20247 depending on the emit context for the conversion, and just using
20248 the resolve time setting.
20250 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
20251 instead of Invocation.EmitArguments. We do not emit the original
20252 arguments, instead we emit those which have been converted to
20253 unsigned int expressions.
20255 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
20257 * codegen.cs: ditto.
20259 * expression.cs (LocalVariableReference): Drop the use of the
20260 Store function that depended on the variable index.
20262 * statement.cs (VariableInfo): Drop the `Idx' property from this
20263 class, as this is not taking into account the indexes for
20264 temporaries tat we generate during the execution, getting the
20267 * class.cs: First emit class initializers, then call the parent
20270 * expression.cs (Binary): Fix opcode emision.
20271 (UnaryMutator.EmitCode): Support checked code generation
20273 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
20274 matches for events for both the Static and Instance scans,
20275 pointing to the same element. Fix that.
20277 2002-03-14 Miguel de Icaza <miguel@ximian.com>
20279 * rootcontext.cs (ResolveTree): Always set the
20280 interface_resolve_order, because nested interfaces will be calling
20283 * class.cs (GetInterfaceOrClass): Track the same resolution
20284 process used by TypeManager.LookupType. This fixes the nested
20285 type lookups in class declarations (separate path from
20288 (TypeContainer.DefineType): Also define nested interfaces.
20289 (TypeContainer.RegisterOrder): New public function used to
20290 register the order in which child interfaces need to be closed.
20292 Nested interfaces need to be closed after their parents have been
20295 * interface.cs (InterfaceAttr): Put all the logic for computing
20296 the interface attribute here.
20298 (DefineInterface): Register our interface order with the
20299 RootContext or with the TypeContainer depending on the case.
20301 2002-03-12 Miguel de Icaza <miguel@ximian.com>
20303 * cs-parser.jay: rework foreach statement to work with the new
20304 changes to the policy on SimpleNames.
20306 * report.cs: support Stacktrace on warnings as well.
20308 * makefile: drop --unsafe and /unsafe from the compile.
20310 2002-03-13 Ravi Pratap <ravi@ximian.com>
20312 * ecore.cs (StandardConversionExists): Modify to take an Expression
20313 as the first parameter. Ensure we do null -> reference type conversion
20316 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
20317 temporary Expression objects.
20319 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
20321 * interface.cs: workaround bug in method overloading resolution
20322 (there is already a bugzilla bug for it).
20324 2002-03-12 Miguel de Icaza <miguel@ximian.com>
20326 We could also solve this problem by having a separate path for
20327 performing type lookups, instead of DoResolve, we could have a
20328 ResolveType entry point, and only participating pieces of the
20329 production (simplename, deref, array) would implement this.
20331 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
20332 signal SimpleName to only resolve type names and not attempt to
20333 resolve anything else.
20335 * expression.cs (Cast): Set the flag.
20337 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
20339 * class.cs: Only report 108 if there is no `new' modifier.
20341 * cs-parser.jay: rework foreach statement to work with the new
20342 changes to the policy on SimpleNames.
20344 * report.cs: support Stacktrace on warnings as well.
20346 * makefile: drop --unsafe and /unsafe from the compile.
20348 2002-03-11 Miguel de Icaza <miguel@ximian.com>
20350 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
20351 lookups here, instead of doing that at parse time. This means
20352 that our grammar will not introduce `LocalVariableReferences' as
20353 expressions at this point. That solves the problem of code like
20357 static void Main ()
20361 This is only half the fix. The full fix requires parameters to
20362 also be handled in this way.
20364 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
20365 makes the use more obvious of the DeclSpace. The
20366 ec.TypeContainer.TypeBuilder is now only used to pull the
20367 TypeBuilder for it.
20369 My theory is that I can get rid of the TypeBuilder completely from
20370 the EmitContext, and have typecasts where it is used (from
20371 DeclSpace to where it matters).
20373 The only pending problem is that the code that implements Aliases
20374 is on TypeContainer, and probably should go in DeclSpace.
20376 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
20377 lookups here, instead of doing that at parse time. This means
20378 that our grammar will not introduce `LocalVariableReferences' as
20379 expressions at this point. That solves the problem of code like
20383 static void Main ()
20387 This is only half the fix. The full fix requires parameters to
20388 also be handled in this way.
20390 * class.cs (Property.DefineMethod): When implementing an interface
20391 method, set newslot, when implementing an abstract method, do not
20392 set the flag (before we tried never setting it, or always setting
20393 it, which is the difference).
20394 (Indexer.DefineMethod): same.
20395 (Method.DefineMethod): same.
20397 * ecore.cs: Only set the status used flag if we get back a Field.
20399 * attribute.cs: Temporary hack, so Paolo can keep working.
20401 2002-03-08 Ravi Pratap <ravi@ximian.com>
20403 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
20404 the unmanaged type in the case we have a MarshalAs attribute.
20406 (Resolve): Handle the case when we are parsing the special MarshalAs
20407 attribute [we need to store the unmanaged type to use later]
20409 * typemanager.cs (marshal_as_attr_type): Built in type for the
20410 MarshalAs Attribute.
20412 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
20413 on parameters and accordingly set the marshalling info.
20415 2002-03-09 Miguel de Icaza <miguel@ximian.com>
20417 * class.cs: Optimizing slightly by removing redundant code after
20418 we switched to the `NoTypes' return value.
20419 (Property.DefineMethod): use NoTypes here too.
20421 This fixes the bug I introduced in my last batch of changes.
20423 2002-03-05 Ravi Pratap <ravi@ximian.com>
20425 * tree.cs (RecordEnum): Add. We now keep track of enums too.
20427 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
20428 Enums since those are types too.
20430 * cs-parser.jay (enum_declaration): Record enums as we parse them.
20432 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
20433 thanks to a call during the lookup process.
20435 2002-03-07 Miguel de Icaza <miguel@ximian.com>
20437 * statement.cs (Foreach): Lots of work to accomodate a particular
20438 kind of foreach statement that I had not kept in mind. It is
20439 possible to have foreachs on classes that provide a GetEnumerator
20440 method that return objects that implement the "pattern" for using
20441 a foreach, there is no need to support GetEnumerator
20444 This is needed to compile nant.
20446 * decl.cs: Only report 114 if the member is not `Finalize' and if
20447 the warning level is at least 2.
20449 * class.cs: Moved the compare function from Method to
20452 (MethodSignature.InheritableMemberSignatureCompare): Add new
20453 filter function that is used to extract inheritable methods from a
20456 (Method.Define): Use the new `inheritable_method_signature_filter'
20459 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
20462 2002-03-06 Miguel de Icaza <miguel@ximian.com>
20464 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
20466 * cs-parser.jay: Add opt_semicolon to the interface declaration.
20468 * expression.cs: Pass location information to
20469 ConvertImplicitStandard.
20471 * class.cs: Added debugging code to track return values from
20474 2002-03-05 Miguel de Icaza <miguel@ximian.com>
20476 * expression.cs (Is.DoResolve): If either side of the `is' is an
20477 interface, do not flag the warning.
20479 * ecore.cs (ImplicitReferenceConversion): We need a separate test
20482 * report.cs: Allow for --fatal to be used with --probe.
20484 * typemanager.cs (NoTypes): Move the definition for the empty Type
20487 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
20489 (TypeContainer.DefineProxy): New function used to proxy to parent
20490 implementations when implementing interfaces.
20491 (TypeContainer.ParentImplements): used to lookup if our parent
20492 implements a public function that is required by an interface.
20493 (TypeContainer.VerifyPendingMethods): Hook this up.
20495 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
20496 `modules' and `assemblies' arraylists into arrays. We only grow
20497 these are the very early start up of the program, so this improves
20498 the speedof LookupType (nicely measured).
20500 * expression.cs (MakeByteBlob): Replaced unsafe code with
20501 BitConverter, as suggested by Paolo.
20503 * cfold.cs (ConstantFold.Binary): Special case: perform constant
20504 folding of string concatenation, but if either side is a string,
20505 and the other is not, then return null, and let the runtime use
20506 the concatenation on the string plus the object (using
20507 `Object.ToString').
20509 2002-03-04 Miguel de Icaza <miguel@ximian.com>
20511 Constant Folding has been implemented now.
20513 * expression.cs (Unary.Reduce): Do not throw an exception, catch
20514 the error instead on types that are not supported in one's
20517 * constant.cs (Constant and all children): New set of functions to
20518 perform implict and explicit conversions.
20520 * ecore.cs (EnumConstant): Implement the new functions to perform
20521 conversion by proxying to the child expression.
20523 * codegen.cs: (ConstantCheckState): Constant evaluation has its
20524 own separate setting that can not be turned off from the command
20525 line using --unchecked or --checked and is only controlled using
20526 the checked/unchecked statements and expressions. This setting is
20527 used by the constant folder to flag errors.
20529 * expression.cs (CheckedExpr, UncheckedExpr): Set the
20530 ConstantCheckState as well.
20532 During Resolve, they also have to flag the state, because the
20533 constant folder runs completely in the Resolve phase.
20535 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
20538 2002-03-01 Miguel de Icaza <miguel@ximian.com>
20540 * cfold.cs: New file, this file contains the constant folder.
20542 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
20543 argument to track whether we are using the resulting address to
20544 load or store a value and provide better error messages.
20546 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
20547 new AddressOf arguments.
20549 * statement.cs (Foreach.EmitCollectionForeach): Update
20551 * expression.cs (Argument.Emit): Call AddressOf with proper
20552 arguments to track usage.
20554 (New.DoEmit): Call AddressOf with new arguments.
20556 (Unary.Emit): Adjust AddressOf call.
20558 2002-03-01 Ravi Pratap <ravi@ximian.com>
20560 * cs-parser.jay (member_access): Change the case for pre-defined types
20561 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
20564 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
20567 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
20568 essentially like methods and apply attributes like MethodImplOptions to them too.
20570 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
20573 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
20574 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
20577 * Update code everywhere accordingly.
20579 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
20581 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
20583 2002-02-28 Ravi Pratap <ravi@ximian.com>
20585 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
20586 try performing lookups against those instead of jumping straight into using
20587 the 'using' clauses.
20589 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
20591 (LookupType): Perform lookups in implicit parents too.
20593 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
20594 sequence as RootContext.LookupType.
20596 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
20597 the various cases of namespace lookups into this method.
20599 2002-03-01 Miguel de Icaza <miguel@ximian.com>
20601 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
20602 in positional arguments)
20604 * class.cs (Operator): Update the AllowedModifiers to contain
20607 * cs-parser.jay: Update operator declaration to allow for the
20608 operator body to be empty.
20610 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
20613 2002-02-27 Miguel de Icaza <miguel@ximian.com>
20615 * class.cs (Method.Emit): Label parameters.
20617 * driver.cs: Return 1 or 0 as the program exit code.
20619 2002-02-26 Miguel de Icaza <miguel@ximian.com>
20621 * expression.cs: Special case the `null' object when trying to
20622 auto-compute the type, as anything can be explicitly converted to
20625 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
20626 spotting this Paolo.
20628 (Expression.ImplicitNumericConversion): Perform comparissions of
20629 the type using the underlying type in the case of an enumeration
20630 rather than using the enumeration type for the compare.
20632 Cope with the underlying == type case, which is not possible to
20635 (Expression.ConvertNumericExplicit): Perform comparissions of
20636 the type using the underlying type in the case of an enumeration
20637 rather than using the enumeration type for the compare.
20639 * driver.cs: If the user does not supply an extension, assume .exe
20641 * cs-parser.jay (if_statement): Rewrote so that we can track the
20642 location for the if statement.
20644 * expression.cs (Binary.ConstantFold): Only concat strings when
20645 the operation is "+", not everything ;-)
20647 * statement.cs (Statement.EmitBoolExpression): Take a location
20649 (If, While, Do): Track location.
20651 * expression.cs (Binary.ResolveOperator): In the object + string
20652 case, I was missing a call to ConvertImplicit
20654 2002-02-25 Ravi Pratap <ravi@ximian.com>
20656 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
20657 Location arguments. Ensure we use RootContext.LookupType to do our work
20658 and not try to do a direct Type.GetType and ModuleBuilder.GetType
20660 * interface.cs (PopulateMethod): Handle the type of the parameter being
20663 * expression.cs (Invocation.BetterFunction): Handle the case when we
20664 have a params method with no fixed arguments and a call is made with no
20667 2002-02-25 Miguel de Icaza <miguel@ximian.com>
20669 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
20670 the verbatim-string-literal
20672 * support.cs (InternalParameters.ParameterModifier): handle null
20674 (InternalParameters.ParameterType): ditto.
20676 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
20677 duplicating the name of the variable parameter.
20678 (GetParameterByName): Fix bug where we were not looking up array
20679 paramters if they were the only present (thanks Paolo!).
20680 (GetParameterInfo): We only have an empty set of types if both
20681 fixed and array are set to null.
20682 (GetParameterInfo-idx): Handle FixedParameter == null
20684 * cs-parser.jay: Handle the case where there is no catch
20685 statements (missing null test).
20687 2002-02-22 Miguel de Icaza <miguel@ximian.com>
20689 * driver.cs (MainDriver): Be conservative on our command line
20692 Catch DirectoryNotFoundException when calling GetFiles.
20694 (SplitPathAndPattern): Used to split the input specification into
20695 a path and a pattern that we can feed to Directory.GetFiles.
20697 2002-02-21 Miguel de Icaza <miguel@ximian.com>
20699 * statement.cs (Fixed): Implement the last case of the Fixed
20700 statement (string handling).
20702 * expression.cs (StringPtr): New class used to return a char * to
20703 a string; Used by the Fixed statement.
20705 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
20707 * expression.cs (Binary.ResolveOperator): Remove redundant
20708 MemberLookup pn parent type.
20709 Optimize union call, we do not need a union if the types are the same.
20710 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
20713 Specialize the use of MemberLookup everywhere, instead of using
20714 the default settings.
20716 (StackAlloc): Implement stackalloc keyword.
20718 * cs-parser.jay: Add rule to parse stackalloc.
20720 * driver.cs: Handle /h, /help, /?
20722 * expression.cs (MakeByteBlob): Removed the hacks we had in place
20723 before we supported unsafe code.
20725 * makefile: add --unsafe to the self compilation of mcs.
20727 2002-02-20 Miguel de Icaza <miguel@ximian.com>
20729 * expression.cs (PointerArithmetic): New class that is used to
20730 perform pointer arithmetic.
20731 (Binary.Resolve): Handle pointer arithmetic
20732 Handle pointer comparission.
20733 (ArrayPtr): Utility expression class that is used to take the
20734 address of an array.
20736 (ElementAccess): Implement array access for pointers
20738 * statement.cs (Fixed): Implement fixed statement for arrays, we
20739 are missing one more case before we are done.
20741 * expression.cs (Indirection): Implement EmitAssign and set the
20742 ExprClass to Variable. This allows pointer dereferences to be
20743 treated as variables, and to have values assigned to them.
20745 * ecore.cs (Expression.StoreFromPtr): New utility function to
20746 store values dereferencing.
20748 2002-02-20 Ravi Pratap <ravi@ximian.com>
20750 * expression.cs (Binary.ResolveOperator): Ensure that we are
20751 not trying to operate on a void type - this fixes the reported
20754 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
20755 the parent implementation is sealed.
20757 * ../errors/cs0239.cs : Add.
20759 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
20761 * typemanager.cs (unverifiable_code_type): Corresponds to
20762 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
20763 which have unsafe code in them.
20765 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
20768 2002-02-19 Miguel de Icaza <miguel@ximian.com>
20770 * cs-tokenizer.cs: Add support for @"litreal strings"
20772 Make tokenizer accept pre-processor directives
20773 on any column (remove the old C-like limitation).
20775 * rootcontext.cs (EmitCode): Emit any global attributes.
20776 (AddGlobalAttributes): Used to keep track of assembly attributes.
20778 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
20780 * cs-parser.jay: Add support for global attributes.
20782 2002-02-17 Miguel de Icaza <miguel@ximian.com>
20784 * expression.cs (Indirection): New helper class. Unary will
20785 create Indirection classes to be able to implement the
20786 IMemoryLocation interface on it.
20788 2002-02-16 Miguel de Icaza <miguel@ximian.com>
20790 * cs-parser.jay (fixed_statement): reference the right statement.
20792 * statement.cs (Fixed.Emit): Finish implementing the fixed
20793 statement for the &x case.
20795 2002-02-14 Miguel de Icaza <miguel@ximian.com>
20797 * class.cs (Property.Define, Method.Define): Remove newslot when
20800 * modifiers.cs: My use of NewSlot when `Abstract' was set was
20801 wrong. NewSlot should only be used if the `new' keyword is present.
20803 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
20804 locating our system dir. Sorry about this.
20806 2002-02-13 Miguel de Icaza <miguel@ximian.com>
20808 * driver.cs (GetSystemDir): Compute correctly the location of our
20809 system assemblies. I was using the compiler directory instead of
20810 the library directory.
20812 2002-02-13 Ravi Pratap <ravi@ximian.com>
20814 * expression.cs (BetterFunction): Put back in what Miguel commented out
20815 since it is the correct fix. The problem is elsewhere ;-)
20817 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
20818 parameters of the parms method are themselves compatible or not !
20820 (StandardConversionExists): Fix very dangerous bug where we were forgetting
20821 to check that a class implements an interface before saying that an implicit
20822 conversion was allowed. Use ImplementsInterface to do the checking.
20824 2002-02-13 Miguel de Icaza <miguel@ximian.com>
20826 * class.cs (Method.Define): Track whether we are an explicit
20827 implementation or not. And only call DefineMethodOverride if we
20828 are an explicit implementation.
20830 (Property.DefineMethod): Ditto.
20832 2002-02-11 Ravi Pratap <ravi@ximian.com>
20834 * expression.cs (BetterFunction): Catch hideous bug which was
20835 preventing us from detecting ambiguous calls due to implicit casts i.e
20838 2002-01-29 Miguel de Icaza <miguel@ximian.com>
20840 * support.cs (Pair): Remove un-needed method. I figured why I was
20841 getting the error in cs-parser.jay, the variable in a foreach loop
20842 is readonly, and the compiler does not really treat this as a variable.
20844 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
20845 instead of EQUALS in grammar.
20847 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
20849 * expression.cs (Unary.DoResolve): Check whether the argument is
20852 2002-01-28 Miguel de Icaza <miguel@ximian.com>
20854 * support.cs: Api for Pair to set a value. Despite the fact that
20855 the variables are public the MS C# compiler refuses to compile
20856 code that accesses the field if the variable is part of a foreach
20859 * statement.cs (Fixed): Begin implementation of the fixed
20862 (Block.AddVariable): Return the VariableInfo on success and null
20863 on failure instead of true/false.
20865 * cs-parser.jay (foreach): Catch errors on variables already
20866 defined (we were ignoring this value before) and properly unwind
20867 the block hierarchy
20869 (fixed_statement): grammar for the fixed statement.
20871 2002-01-25 Miguel de Icaza <miguel@ximian.com>
20873 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
20874 pointer types to be incretemented.
20876 (SizeOf): Implement.
20878 * cs-parser.jay (pointer_member_access): Implement
20879 expr->IDENTIFIER production.
20881 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
20882 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
20885 (Unary): Implement indirection.
20887 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
20888 use in non-unsafe context).
20890 (SimpleName.DoResolve): Check for pointers in field access on safe
20893 (Expression.LoadFromPtr): Factor the load-indirect code in this
20894 function. This was duplicated in UnboxCast and ParameterReference
20896 2002-01-24 Miguel de Icaza <miguel@ximian.com>
20898 * expression.cs (ComposedCast): report an error if a pointer cast
20899 is used in a safe region.
20901 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
20902 pointer type casts in unsafe context.
20904 * codegen.cs (EmitContext): Set up IsUnsafe.
20906 * cs-parser.jay (non_expression_type): Add productions for pointer
20909 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
20910 code. We should not use force into static mode if the method is
20911 not virtual. Fixes bug in MIS
20913 * statement.cs (Do.Emit, While.Emit, For.Emit,
20914 Statement.EmitBoolExpression): Add support to Do and While to
20915 propagate infinite loop as `I do return' semantics.
20917 Improve the For case to also test for boolean constants.
20919 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
20920 to the list of attributes we can add.
20922 Remove `EmitContext' argument.
20924 * class.cs (Method.Define): Apply parameter attributes.
20925 (Constructor.Define): Apply parameter attributes.
20926 (MethodCore.LabelParameters): Move here the core of labeling
20929 * support.cs (ReflectionParameters.ParameterModifier,
20930 InternalParameters.ParameterModifier): Use IsByRef on the type and
20931 only return the OUT bit for these parameters instead of in/out/ref
20934 This is because I miss-understood things. The ParameterInfo.IsIn
20935 and IsOut represent whether the parameter has the [In] and [Out]
20938 2002-01-22 Miguel de Icaza <miguel@ximian.com>
20940 * ecore.cs (FieldExpr.Emit): Release temporaries.
20942 * assign.cs (LocalTemporary.Release): new function.
20944 * codegen.cs (EmitContext.GetTemporaryStorage,
20945 EmitContext.FreeTemporaryStorage): Rework the way we deal with
20946 temporary storage. Now we can "put back" localbuilders when we
20949 2002-01-21 Miguel de Icaza <miguel@ximian.com>
20951 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
20952 need to make a copy of the variable to generate verifiable code.
20954 2002-01-19 Miguel de Icaza <miguel@ximian.com>
20956 * driver.cs: Compute dynamically the system directory.
20958 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
20959 Slower, but more generally useful. Used by the abstract
20960 registering implementation.
20962 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
20963 the rules for the special rule on Type/instances. First check if
20964 we have the same name, and if so, try that special static path
20965 rather than the instance path.
20967 2002-01-18 Miguel de Icaza <miguel@ximian.com>
20969 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
20972 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
20973 Enum, ValueType, Delegate or Array for non-corlib compiles.
20975 * cs-tokenizer.cs: Catch long identifiers (645)
20977 * typemanager.cs (IndexerPropetyName): Ravi never tested this
20980 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
20981 fix, we were returning too early, so we were not registering
20982 pending methods from abstract classes.
20984 Do not register pending methods if the class is abstract.
20986 * expression.cs (Conditional.DoResolve): Report circular implicit
20987 conversions when we neecd to compute it for conditional
20990 (Is.DoResolve): If the expression is always of the provided type,
20991 flag warning 183. If the expression can not ever be of the
20992 provided type flag warning 184.
20994 * class.cs: Catch 169 as well.
20996 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
20999 2002-01-18 Nick Drochak <ndrochak@gol.com>
21001 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
21003 2002-01-17 Miguel de Icaza <miguel@ximian.com>
21005 * interface.cs: (PopulateMethod): Check for pointers being defined
21006 only if the unsafe context is active.
21007 (PopulateProperty): ditto.
21008 (PopulateIndexer): ditto.
21010 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
21011 specified. If pointers are present, make sure that they are
21012 present in an unsafe context.
21013 (Constructor, Constructor.Define): ditto.
21014 (Field, Field.Define): ditto.
21015 (Property, Property.Define): ditto.
21016 (Event, Event.Define): ditto.
21018 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
21019 hashtable if there are classes or structs defined.
21021 * expression.cs (LocalVariableReference.DoResolve): Simplify this
21022 code, as the constant resolution moved.
21024 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
21025 the metadata, so we can flag error 133.
21027 * decl.cs (MemberCore.UnsafeOK): New function to test that a
21028 pointer is being declared in an unsafe context.
21030 2002-01-16 Miguel de Icaza <miguel@ximian.com>
21032 * modifiers.cs (Modifiers.Check): Require a Location argument.
21033 Report error 227 for Unsafe use.
21035 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
21037 * statement.cs (For.Emit): If the test is null, then report that
21038 we do `return', as we wont reach anything afterwards.
21040 (Switch.SwitchGoverningType): Track the expression that matched
21043 * driver.cs: Allow negative numbers as an error code to flag.
21045 * cs-parser.jay: Handle 1551.
21047 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
21049 2002-01-15 Miguel de Icaza <miguel@ximian.com>
21051 * cs-parser.jay: Report 1518 (type declaration can only contain
21052 class, struct, interface, enum or delegate)
21054 (switch_label): Report 1523 (keywords `case' or `default' must
21057 (opt_switch_sections): Report 1522 (empty switch)
21059 * driver.cs: Report 1515 (response file specified multiple times)
21060 Report 1516 (Source file specified multiple times).
21062 * expression.cs (Argument.Resolve): Signal 1510
21064 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
21065 access not allowed in static code)
21067 2002-01-11 Ravi Pratap <ravi@ximian.com>
21069 * typemanager.cs (IsPointerType): Utility method which we are going
21072 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
21073 the object type, so we take care of that.
21075 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
21077 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
21078 added to non-params parameters :-)
21080 * typemanager.cs (CSharpName): Include 'void' type too.
21082 (void_ptr_type): Include in the set of core types.
21084 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
21087 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
21090 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
21091 completely forgotten about it.
21093 2002-01-10 Ravi Pratap <ravi@ximian.com>
21095 * cs-parser.jay (pointer_type): Add. This begins our implementation
21096 of parsing rules for unsafe code.
21098 (unsafe_statement): Implement.
21100 (embedded_statement): Modify to include the above.
21102 * statement.cs (Unsafe): Implement new class for unsafe blocks.
21104 * codegen.cs (EmitContext.InUnsafe): Add. This determines
21105 if the current context is an unsafe one.
21107 * cs-parser.jay (local_variable_pointer_type): Since local variable types
21108 are handled differently, we need separate rules for them.
21110 (local_variable_declaration): Update to use local_variable_pointer_type
21111 to allow variable declarations of unmanaged pointer types.
21113 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
21114 in unsafe contexts.
21116 * ../errors/cs0214.cs : Add.
21118 2002-01-16 Nick Drochak <ndrochak@gol.com>
21120 * makefile: remove 'response' file when cleaning.
21122 2002-01-15 Miguel de Icaza <miguel@ximian.com>
21124 * cs-parser.jay: Report 1524.
21126 2002-01-14 Miguel de Icaza <miguel@ximian.com>
21128 * typemanager.cs (RegisterMethod): drop checking if we have
21129 registered this from here
21131 2002-01-12 Miguel de Icaza <miguel@ximian.com>
21133 * class.cs (Method.EmitDestructor): Implement calling our base
21136 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
21137 value of InFinally.
21139 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
21140 this routine and will wrap the call in a try/catch block. Deal
21143 2002-01-11 Miguel de Icaza <miguel@ximian.com>
21145 * ecore.cs (Expression.MemberLookup): instead of taking a
21146 parameter `same_type' that was used to tell whether we could
21147 access private members we compute our containing type from the
21150 (FieldExpr): Added partial support for volatile fields. This does
21151 not work for volatile fields exposed from assemblies, as I can not
21152 figure out how to extract the modreq from it.
21154 Updated all the source files to use this.
21156 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
21157 because it is referenced by MemberLookup very often.
21159 2002-01-09 Ravi Pratap <ravi@ximian.com>
21161 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
21162 TypeBuilder.GetCustomAttributes to retrieve what we need.
21164 Get rid of redundant default_member_attr_type as this is the same as
21165 default_member_type which already exists.
21167 * interface.cs, attribute.cs : Update accordingly.
21169 2002-01-08 Miguel de Icaza <miguel@ximian.com>
21171 * typemanager.cs: Enable IndexerPropertyName again. It does not
21172 work for TYpeBuilders though. Ravi, can you please fix this?
21174 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
21176 * expression.cs (Argument.Emit): Handle the case of ref objects
21177 being passed to ref functions;
21179 (ParameterReference.EmitLoad): Loads the content of the pointer
21180 without dereferencing.
21182 2002-01-07 Miguel de Icaza <miguel@ximian.com>
21184 * cs-tokenizer.cs: Implemented the pre-processing expressions.
21186 2002-01-08 Ravi Pratap <ravi@ximian.com>
21188 * class.cs (Indexer.DefineMethod): Incorporate the interface
21189 type in the name of the method if we are doing explicit interface
21192 * expression.cs (ConversionExists): Remove as it is completely obsolete.
21194 (BetterConversion): Fix extremely trivial bug where we were referring to
21195 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
21198 * ../errors/bug16.cs : Add although we have fixed it.
21200 2002-01-07 Miguel de Icaza <miguel@ximian.com>
21202 * expression.cs (BaseIndexer): Begin implementation.
21204 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
21206 * cs-parser.jay (indexer_declarator): Use qualified_identifier
21207 production directly to remove a shift/reduce, and implement
21208 explicit interface implementation.
21210 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
21211 after a floating point suffix.
21213 * expression.cs (DoNumericPromotions): Improved the conversion for
21214 uint/uint. If we have a constant, we avoid doing a typecast to a
21217 * class.cs (Indexer): Implement explicit interface implementation
21220 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
21222 * class.cs: make the default instance constructor public and hidebysig.
21224 2001-01-03 Ravi Pratap <ravi@ximian.com>
21226 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
21227 so we can call it from elsewhere.
21229 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
21230 we emit it internally if the class has a defined indexer; otherwise the user
21231 emits it by decorating the class definition with the DefaultMemberAttribute.
21233 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
21234 attribute is not used on a type which defines an indexer.
21236 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
21237 character when we skip whitespace.
21239 * ../errors/cs0646.cs : Add.
21241 2002-01-03 Miguel de Icaza <miguel@ximian.com>
21243 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
21246 * makefile: Add practical target `mcs3.exe' which builds the third
21247 generation compiler.
21249 * expression.cs (New): Fix structures constructor calling.
21251 * class.cs (Property, Method, Indexer): Emit Final flag on the
21252 method if we are an interface implementation and we are not
21255 * ecore.cs (PropertyExpr): New public field `IsBase', tells
21256 whether this property is referencing a `base' method.
21258 * expression.cs (Invocation.EmitCall): take an extra argument:
21259 is_base, this is used to determine whether the `call' or
21260 `callvirt' opcode should be used.
21263 * delegate.cs: update EmitCall.
21265 * class.cs (Method.Define): Set NewSlot for the cases where we are
21266 not implementing an interface method.
21268 (Property.Define): ditto.
21270 2002-01-02 Miguel de Icaza <miguel@ximian.com>
21272 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
21273 'r'. Allows mcs to parse itself fully.
21275 2002-01-02 Ravi Pratap <ravi@ximian.com>
21277 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
21278 of the number of initializers that require the InitializeArray method.
21280 (CheckIndices): Store the Expression in all cases - not the plain value. Also
21281 update the above field where necessary.
21283 (MakeByteBlob): Update accordingly.
21285 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
21288 (EmitDynamicInitializers): Update in accordance with the new optimization.
21290 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
21291 same OpCode applies.
21293 * cs-parser.jay : Fix some glaring errors I introduced.
21295 2002-01-01 Ravi Pratap <ravi@ximian.com>
21297 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
21298 so that we can check for name clashes there too.
21300 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
21301 for interface indexers.
21303 * interfaces.cs (Define): Emit the default member attribute.
21305 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
21306 variable was being referred to while setting the value ;-)
21308 2002-01-01 Miguel de Icaza <miguel@ximian.com>
21310 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
21311 byte-by-byte information when we know the data is zero.
21313 Make the block always a multiple of 4, because
21314 DefineInitializedData has a bug.
21316 * assign.cs: Fix, we should assign from the temporary, not from
21319 * expression.cs (MakeByteBlob): Fix my incorrect code.
21321 2001-12-31 Miguel de Icaza <miguel@ximian.com>
21323 * typemanager.cs (EnumToUnderlying): This function is used to get
21324 the underlying type from an enumeration, because it does not
21327 * constant.cs: Use the I4_S form for values between -128 and 127.
21329 * statement.cs (Block.LookupLabel): Looks up a label.
21330 (Block): Drop support for labeled blocks.
21332 (LabeledStatement): New kind of statement that represents a label
21335 (Goto): Finally implement this bad boy.
21337 * cs-parser.jay: Update to reflect new mechanism to implement
21340 2001-12-30 Miguel de Icaza <miguel@ximian.com>
21342 * codegen.cs (EmitContext.This): a codegen property that keeps the
21343 a single instance of this instead of creating many different this
21346 * delegate.cs (Delegate.DoResolve): Update to use the property;
21348 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
21350 * expression.cs (BaseAccess.DoResolve): Ditto.
21352 2001-12-29 Ravi Pratap <ravi@ximian.com>
21354 * typemanager.cs (methodimpl_attr_type): Add to hold the type
21355 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
21357 (InitCoreTypes): Update accordingly.
21359 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
21360 so we can quickly store the state.
21362 (ApplyAttributes): Set the correct implementation flags
21363 for InternalCall methods.
21365 2001-12-29 Miguel de Icaza <miguel@ximian.com>
21367 * expression.cs (EmitCall): if a method is not virtual, then do
21368 not use callvirt on it.
21370 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
21371 user defined stuff) requires the use of stobj, which takes an
21372 address on the stack instead of an array and an index. So emit
21373 the Ldelema operation for it.
21375 (EmitStoreOpcode): Use stobj for valuetypes.
21377 (UnaryMutator.EmitCode): Use the right 1 value depending on
21378 whether we are dealing with int64/uint64, float or doubles.
21380 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
21381 constructors that I implemented last night.
21383 (Constructor.IsDefault): Fix to work properly for static
21386 * cs-parser.jay (CheckDef): report method signature errors.
21387 Update error number 103 to be 132.
21389 * decl.cs: New AdditionResult enumeration value: MethodExists.
21390 Although we do this check for methods later on in the semantic
21391 analysis, catching repeated default constructors is so easy that
21392 we catch these here.
21394 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
21397 (ParameterReference.EmitAssign, Emit): handle
21400 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
21401 (ArrayAccess.EmitStoreOpcode): ditto.
21403 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
21405 * expression.cs (MakeByteBlob): Complete all the missing types
21406 (uint, short, ushort, byte, sbyte)
21408 * class.cs: Only init instance field initializers on instance
21411 Rename `constructors' to instance_constructors.
21413 (TypeContainer.AddConstructor): Only add constructors to the list
21414 if it is not static.
21416 Make sure that we handle default_static_constructor independently
21417 everywhere where we handle instance_constructors
21419 2001-12-28 Miguel de Icaza <miguel@ximian.com>
21421 * class.cs: Do not lookup or create a base initializer for a
21422 static constructor.
21424 (ConstructorInitializer.Resolve): use the proper type to lookup
21427 * cs-parser.jay: Report error 1585 (modifiers between type and name).
21429 * enum.cs, interface.cs: Remove CloseType, this is taken care by
21432 * decl.cs: CloseType is now an virtual method, the default
21433 implementation just closes this type.
21435 2001-12-28 Ravi Pratap <ravi@ximian.com>
21437 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
21438 to PreserveSig by default. Also emit HideBySig on such methods.
21440 Basically, set the defaults to standard values.
21442 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
21443 argument, if candidate is better, it can't be worse than the best !
21445 (Invocation): Re-write bits to differentiate between methods being
21446 applicable in their expanded form and their normal form - for params
21449 Get rid of use_standard everywhere as only standard conversions are allowed
21450 in overload resolution.
21452 More spec conformance.
21454 2001-12-27 Miguel de Icaza <miguel@ximian.com>
21456 * driver.cs: Add --timestamp, to see where the compiler spends
21459 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
21460 `this' in static code.
21462 (SimpleName.DoResolve): Implement in terms of a helper function
21463 that allows static-references to be passed upstream to
21466 (Expression.ResolveWithSimpleName): Resolve specially simple
21467 names when called by MemberAccess to implement the special
21470 (Expression.ImplicitReferenceConversion): Handle conversions from
21471 Null to reference types before others, as Null's type is
21474 * expression.cs (Invocation.EmitCall): Handle the special case of
21475 calling methods declared on a reference type from a ValueType
21476 (Base classes System.Object and System.Enum)
21478 (MemberAccess.Resolve): Only perform lookups on Enumerations if
21479 the left hand side is a TypeExpr, not on every enumeration.
21481 (Binary.Resolve): If types are reference types, then do a cast to
21482 object on operators != and == of both arguments.
21484 * typemanager.cs (FindMembers): Extract instance and static
21485 members if requested.
21487 * interface.cs (PopulateProperty): Use void_type instead of null
21488 as the return type for the setter method.
21490 (PopulateIndexer): ditto.
21492 2001-12-27 Ravi Pratap <ravi@ximian.com>
21494 * support.cs (ReflectionParameters): Fix minor bug where we
21495 were examining the wrong parameter for the ParamArray attribute.
21497 Cope with requests for the type of the parameter at position
21498 greater than the params parameter's. We now return the element
21499 type of the params array as that makes more sense.
21501 * expression.cs (Invocation.IsParamsMethodApplicable): Update
21502 accordingly as we no longer have to extract the element type
21505 (Invocation.OverloadResolve): Update.
21507 2001-12-27 Miguel de Icaza <miguel@ximian.com>
21509 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
21510 against IEnumerator, test whether the return value is a descendant
21511 of the IEnumerator interface.
21513 * class.cs (Indexer.Define): Use an auxiliary method to implement
21514 the other bits of the method definition. Begin support for
21515 explicit interface implementation.
21517 (Property.DefineMethod): Use TypeManager.void_type instead of null
21518 for an empty return value.
21520 2001-12-26 Miguel de Icaza <miguel@ximian.com>
21522 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
21523 dealing with a FieldExpr which is composed of a FieldBuilder, in
21524 the code path we did extract the constant, but we should have
21525 obtained the underlying value to be able to cast it (otherwise we
21526 end up in an infinite loop, this is what Ravi was running into).
21528 (ArrayCreation.UpdateIndices): Arrays might be empty.
21530 (MemberAccess.ResolveMemberAccess): Add support for section
21531 14.5.4.1 that deals with the special case of E.I when E is a type
21532 and something else, that I can be a reference to a static member.
21534 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
21535 handle a particular array type to create byte blobs, it is just
21536 something we dont generate byteblobs for.
21538 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
21541 * location.cs (Push): remove the key from the hashtable that we
21542 are about to add. This happens for empty files.
21544 * driver.cs: Dispose files after we have parsed them.
21546 (tokenize): new function that only runs the tokenizer on its
21547 input, for speed testing.
21549 2001-12-26 Ravi Pratap <ravi@ximian.com>
21551 * class.cs (Event.Define): Define the private field only if there
21552 are no accessors defined.
21554 * expression.cs (ResolveMemberAccess): If there is no associated
21555 field with the event, that means we have an event defined with its
21556 own accessors and we should flag error cs0070 since transforming
21557 ourselves into a field is not valid in that case.
21559 * ecore.cs (SimpleName.DoResolve): Same as above.
21561 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
21562 and charset to sane values.
21564 2001-12-25 Ravi Pratap <ravi@ximian.com>
21566 * assign.cs (DoResolve): Perform check on events only if they
21567 are being accessed outside the declaring type.
21569 * cs-parser.jay (event_declarations): Update rules to correctly
21570 set the type of the implicit parameter etc.
21572 (add_accessor, remove_accessor): Set current local parameters.
21574 * expression.cs (Binary): For delegate addition and subtraction,
21575 cast the return value from the method into the appropriate delegate
21578 2001-12-24 Ravi Pratap <ravi@ximian.com>
21580 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
21581 of these as the workaround is unnecessary.
21583 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
21584 delegate data - none of that is needed at all.
21586 Re-write bits to extract the instance expression and the delegate method
21589 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
21592 * attribute.cs (ApplyAttributes): New method to take care of common tasks
21593 of attaching attributes instead of duplicating code everywhere.
21595 * everywhere : Update code to do attribute emission using the above method.
21597 2001-12-23 Miguel de Icaza <miguel@ximian.com>
21599 * expression.cs (IsParamsMethodApplicable): if there are not
21600 parameters, return immediately.
21602 * ecore.cs: The 0 literal can be implicity converted to an enum
21605 (SimpleName.DoResolve): First lookup the type, then lookup the
21608 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
21609 want to get its address. If the InstanceExpression is not
21610 addressable, store the result in a temporary variable, then get
21613 * codegen.cs: Only display 219 errors on warning level or above.
21615 * expression.cs (ArrayAccess): Make it implement the
21616 IMemoryLocation interface.
21618 (Binary.DoResolve): handle the operator == (object a, object b)
21619 and operator != (object a, object b) without incurring into a
21620 BoxedCast (because 5 != o should never be performed).
21622 Handle binary enumerator operators.
21624 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
21625 value type, otherwise use Ldelem_ref.
21627 Use precomputed names;
21629 (AddressOf): Implement address of
21631 * cs-parser.jay (labeled_statement): Fix recursive block
21632 addition by reworking the production.
21634 * expression.cs (New.DoEmit): New has a special case:
21636 If we are dealing with a ValueType, we have a few
21637 situations to deal with:
21639 * The target of New is a ValueType variable, that is
21640 easy, we just pass this as the variable reference
21642 * The target of New is being passed as an argument,
21643 to a boxing operation or a function that takes a
21646 In this case, we need to create a temporary variable
21647 that is the argument of New.
21650 2001-12-23 Ravi Pratap <ravi@ximian.com>
21652 * rootcontext.cs (LookupType): Check that current_type is not null before
21653 going about looking at nested types.
21655 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
21656 not implement the IAssignMethod interface any more.
21658 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
21659 where we tranform them into FieldExprs if they are being resolved from within
21660 the declaring type.
21662 * ecore.cs (SimpleName.DoResolve): Do the same here.
21664 * assign.cs (DoResolve, Emit): Clean up code considerably.
21666 * ../errors/bug10.cs : Add.
21668 * ../errors/cs0070.cs : Add.
21670 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
21672 * assign.cs : Get rid of EventIsLocal everywhere.
21674 2001-12-23 Miguel de Icaza <miguel@ximian.com>
21676 * ecore.cs (ConvertIntLiteral): finished the implementation.
21678 * statement.cs (SwitchLabel): Convert the value we are using as a
21679 key before looking up the table.
21681 2001-12-22 Miguel de Icaza <miguel@ximian.com>
21683 * codegen.cs (EmitTopBlock): Require a Location argument now.
21685 * cs-parser.jay (constructor_declarator): We need to setup
21686 current_local_parameters before we parse the
21687 opt_constructor_initializer, to allow the variables to be bound
21688 to the constructor arguments.
21690 * rootcontext.cs (LookupType): First lookup nested classes in our
21691 class and our parents before we go looking outside our class.
21693 * expression.cs (ConstantFold): Extract/debox the values at the
21696 * rootcontext.cs (EmitCode): Resolve the constants first before we
21697 resolve the types. This is not really needed, but it helps debugging.
21699 * statement.cs: report location.
21701 * cs-parser.jay: pass location to throw statement.
21703 * driver.cs: Small bug fix.
21705 * report.cs: Updated format to be 4-zero filled digits.
21707 2001-12-22 Ravi Pratap <ravi@ximian.com>
21709 * expression.cs (CheckIndices): Fix minor bug where the wrong
21710 variable was being referred to ;-)
21712 (DoEmit): Do not call EmitStaticInitializers when the
21713 underlying type is System.Object.
21715 2001-12-21 Ravi Pratap <ravi@ximian.com>
21717 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
21718 and do the usual workaround for SRE.
21720 * class.cs (MyEventBuilder.EventType): New member to get at the type
21721 of the event, quickly.
21723 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
21725 * assign.cs (Assign.DoResolve): Handle the case when the target
21726 is an EventExpr and perform the necessary checks.
21728 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
21731 (SimpleName.MemberStaticCheck): Include check for EventExpr.
21733 (EventExpr): Set the type in the constructor itself since we
21734 are meant to be born fully resolved.
21736 (EventExpr.Define): Revert code I wrote earlier.
21738 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
21739 instance expression is null. The instance expression is a This in that case
21740 or a null, depending on whether it is a static method or not.
21742 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
21743 refers to more than one method.
21745 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
21746 and accordingly flag errors.
21748 2001-12-21 Miguel de Icaza <miguel@ximian.com>
21750 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
21752 2001-12-22 Miguel de Icaza <miguel@ximian.com>
21754 * location.cs (ToString): Provide useful rutine.
21756 2001-12-21 Miguel de Icaza <miguel@ximian.com>
21758 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
21759 objects, return the actual integral boxed.
21761 * statement.cs (SwitchLabel): define an ILLabel for each
21764 (Switch.CheckSwitch): If the value is a Literal, extract
21765 the underlying literal.
21767 Also in the unused hashtable we had, add the SwitchLabel so we can
21768 quickly look this value up.
21770 * constant.cs: Implement a bunch of new constants. Rewrite
21771 Literal based on this. Made changes everywhere to adapt to this.
21773 * expression.cs (Expression.MakeByteBlob): Optimize routine by
21774 dereferencing array only once, and also copes with enumrations.
21776 bytes are two bytes wide, not one.
21778 (Cast): Perform constant conversions.
21780 * ecore.cs (TryImplicitIntConversion): Return literals instead of
21781 wrappers to the literals here.
21783 * expression.cs (DoNumericPromotions): long literals can converted
21784 to ulong implicity (this is taken care of elsewhere, but I was
21785 missing this spot).
21787 * ecore.cs (Expression.Literalize): Make the return type Literal,
21788 to improve type checking.
21790 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
21792 2001-12-20 Miguel de Icaza <miguel@ximian.com>
21794 * literal.cs: Revert code from ravi that checked the bounds. The
21795 bounds are sane by the definition of the type itself.
21797 * typemanager.cs: Fix implementation of ImplementsInterface. We
21798 need to actually look up in our parent hierarchy for interfaces
21801 * const.cs: Use the underlying type for enumerations
21803 * delegate.cs: Compute the basename for the delegate creation,
21804 that should fix the delegate test case, and restore the correct
21805 Type Lookup semantics in rootcontext
21807 * rootcontext.cs: Revert Ravi's last patch. The correct way of
21808 referencing a nested type with the Reflection API is using the "+"
21811 * cs-parser.jay: Do not require EOF token at the end.
21813 2001-12-20 Ravi Pratap <ravi@ximian.com>
21815 * rootcontext.cs (LookupType): Concatenate type names with
21816 a '.' instead of a '+' The test suite passes again.
21818 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
21819 field of the enumeration.
21821 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
21822 the case when the member is an EventExpr.
21824 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
21825 static has an associated instance expression.
21827 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
21829 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
21831 * class.cs (Event.Define): Register event and perform appropriate checks
21834 We define the Add and Remove methods even if the use provides none because
21835 in that case, we provide default implementations ourselves.
21837 Define a private field of the type of the event. This is done by the CSC compiler
21838 and we should be doing it too ;-)
21840 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
21841 More methods we use in code we generate.
21843 (multicast_delegate_type, delegate_type): Two separate types since the distinction
21846 (InitCoreTypes): Update accordingly for the above.
21848 * class.cs (Event.Emit): Generate code for default accessors that we provide
21850 (EmitDefaultMethod): Do the job in the above.
21852 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
21855 2001-12-20 Miguel de Icaza <miguel@ximian.com>
21857 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
21858 builders even if we were missing one.
21860 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
21861 pass the Basename as our class name instead of the Name. The
21862 basename will be correctly composed for us.
21864 * parameter.cs (Paramters): Now takes a Location argument.
21866 * decl.cs (DeclSpace.LookupType): Removed convenience function and
21867 make all the code call directly LookupType in RootContext and take
21868 this chance to pass the Location information everywhere.
21870 * Everywhere: pass Location information.
21872 2001-12-19 Miguel de Icaza <miguel@ximian.com>
21874 * class.cs (Constructor.Define): Updated way of detecting the
21875 length of the parameters.
21877 (TypeContainer.DefineType): Use basename as the type name for
21880 (TypeContainer.Define): Do not recursively define types here, as
21881 definition is taken care in order by the RootContext.
21883 * tree.cs: Keep track of namespaces in a per-file basis.
21885 * parameter.cs (Parameter.ComputeSignature): Update to use
21888 (Parameters.GetSignature): ditto.
21890 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
21891 instead of a TypeContainer.
21893 (Interface.SemanticAnalysis): Use `this' instead of our parent to
21894 resolve names. Because we need to be resolve in our context, not
21897 * driver.cs: Implement response files.
21899 * class.cs (TypeContainer.DefineType): If we are defined, do not
21900 redefine ourselves.
21902 (Event.Emit): Emit the code for add/remove handlers.
21903 (Event.Define): Save the MethodBuilders for add/remove.
21905 * typemanager.cs: Use pair here too.
21907 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
21908 DictionaryEntry requires the first argument to be non-null.
21910 (enum_declaration): Compute full name for registering the
21913 (delegate_declaration): Instead of using
21914 formal_parameter_list, use opt_formal_parameter_list as the list
21917 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
21918 (EventParsing): New property that controls whether `add' and
21919 `remove' are returned as tokens or identifiers (for events);
21921 2001-12-19 Ravi Pratap <ravi@ximian.com>
21923 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
21924 use MyEventBuilder only and let it wrap the real builder for us.
21926 (MyEventBuilder): Revamp constructor etc.
21928 Implement all operations that we perform on EventBuilder in precisely the same
21931 (FindMembers): Update to use the EventBuilder member.
21933 (Event.Emit): Update accordingly.
21935 2001-12-18 Ravi Pratap <ravi@ximian.com>
21937 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
21938 by calling the appropriate methods.
21940 (GetCustomAttributes): Make stubs as they cannot possibly do anything
21943 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
21945 2001-12-17 Ravi Pratap <ravi@ximian.com>
21947 * delegate.cs (Delegate.Populate): Check that the return type
21948 and various parameters types are indeed accessible.
21950 * class.cs (Constructor.Define): Same here.
21952 (Field.Define): Ditto.
21954 (Event.Define): Ditto.
21956 (Operator.Define): Check that the underlying Method defined itself
21957 correctly - so it's MethodBuilder should not be null.
21959 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
21960 expression happens to be null.
21962 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
21963 members but as of now we don't seem to be able to do anything really useful with it.
21965 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
21966 not the EventBuilder.
21968 2001-12-18 Miguel de Icaza <miguel@ximian.com>
21970 * cs-tokenizer.cs: Add support for defines.
21971 Add support for #if, #elif, #else, #endif
21973 (eval_var): evaluates a variable.
21974 (eval): stubbed for evaluating functions.
21976 * cs-parser.jay: Pass the defines information
21978 * driver.cs: Add --define command line option.
21980 * decl.cs: Move MemberCore here.
21982 Make it the base class for DeclSpace. This allows us to catch and
21983 report 108 and 109 for everything now.
21985 * class.cs (TypeContainer.Define): Extract all the members
21986 before populating and emit the warning 108 (new keyword required
21987 to override) instead of having each member implement this.
21989 (MemberCore.Define): New abstract method, we will be using this in
21990 the warning reporting engine in Populate.
21992 (Operator.Define): Adjust to new MemberCore protocol.
21994 * const.cs (Const): This does not derive from Expression, it is a
21995 temporary object we use to create fields, it is a MemberCore.
21997 * class.cs (Method.Define): Allow the entry point to be in a
22000 * driver.cs: Rewrite the argument handler to clean it up a bit.
22002 * rootcontext.cs: Made it just an auxiliary namespace feature by
22003 making everything static.
22005 * driver.cs: Adapt code to use RootContext type name instead of
22008 * delegate.cs: Remove RootContext argument.
22010 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
22013 * class.cs (Event.Define): The lookup can fail.
22015 * cs-tokenizer.cs: Begin implementation of pre-procesor.
22017 * expression.cs: Resolve the this instance before invoking the code.
22019 2001-12-17 Miguel de Icaza <miguel@ximian.com>
22021 * cs-parser.jay: Add a production in element_access that allows
22022 the thing to become a "type" reference. This way we can parse
22023 things like "(string [])" as a type.
22025 Note that this still does not handle the more complex rules of
22029 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
22031 * ecore.cs: (CopyNewMethods): new utility function used to
22032 assemble the list of methods from running FindMembers.
22034 (MemberLookup): Rework FindMembers so that
22036 2001-12-16 Miguel de Icaza <miguel@ximian.com>
22038 * class.cs (TypeContainer): Remove Delegates who fail to be
22041 * delegate.cs (Populate): Verify that we dont get null return
22042 values. TODO: Check for AsAccessible.
22044 * cs-parser.jay: Use basename to emit error 574 (destructor should
22045 have the same name as container class), not the full name.
22047 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
22048 possible representation.
22050 Also implements integer type suffixes U and L.
22052 2001-12-15 Miguel de Icaza <miguel@ximian.com>
22054 * expression.cs (ArrayCreation.DoResolve): We need to do the
22055 argument resolution *always*.
22057 * decl.cs: Make this hold the namespace. Hold the root context as
22059 (LookupType): Move here.
22061 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
22063 * location.cs (Row, Name): Fixed the code, it was always returning
22064 references to the first file.
22066 * interface.cs: Register properties defined through interfaces.
22068 * driver.cs: Add support for globbing on the command line
22070 * class.cs (Field): Make it derive from MemberCore as well.
22073 2001-12-15 Ravi Pratap <ravi@ximian.com>
22075 * class.cs (Event::Define): Check that the type of the event is a delegate
22076 type else flag error #66.
22078 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
22081 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
22082 values of EntryPoint, CharSet etc etc.
22084 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
22086 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
22087 be null and we should ignore this. I am not sure if this is really clean. Apparently,
22088 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
22089 which needs this to do its work.
22091 * ../errors/cs0066.cs : Add.
22093 2001-12-14 Miguel de Icaza <miguel@ximian.com>
22095 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
22098 * class.cs: (MethodSignature.MethodSignature): Removed hack that
22099 clears out the parameters field.
22100 (MemberSignatureCompare): Cleanup
22102 (MemberCore): New base class used to share code between MethodCore
22105 (RegisterRequiredImplementations) BindingFlags.Public requires
22106 either BindingFlags.Instace or Static. Use instance here.
22108 (Property): Refactored code to cope better with the full spec.
22110 * parameter.cs (GetParameterInfo): Return an empty array instead
22113 * class.cs (Property): Abstract or extern properties have no bodies.
22115 * parameter.cs (GetParameterInfo): return a zero-sized array.
22117 * class.cs (TypeContainer.MethodModifiersValid): Move all the
22118 method modifier validation to the typecontainer so we can reuse
22119 this on properties.
22121 (MethodCore.ParameterTypes): return an empty sized array of types.
22123 (Property.Define): Test property modifier validity.
22125 Add tests for sealed/override too.
22127 (Method.Emit): abstract or extern methods have no bodies.
22129 2001-12-14 Ravi Pratap <ravi@ximian.com>
22131 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
22134 (Method::Define, ::Emit): Modify accordingly.
22136 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
22138 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
22140 * makefile: Pass in /unsafe.
22142 2001-12-13 Miguel de Icaza <miguel@ximian.com>
22144 * class.cs (MakeKey): Kill routine.
22146 * class.cs (TypeContainer.Define): Correctly define explicit
22147 method implementations (they require the full interface name plus
22150 * typemanager.cs: Deply the PtrHashtable here and stop using the
22151 lame keys. Things work so much better.
22153 This of course broke everyone who depended on `RegisterMethod' to
22154 do the `test for existance' test. This has to be done elsewhere.
22156 * support.cs (PtrHashtable): A hashtable that avoid comparing with
22157 the object stupid Equals method (because, that like fails all over
22158 the place). We still do not use it.
22160 * class.cs (TypeContainer.SetRequiredInterface,
22161 TypeContainer.RequireMethods): Killed these two routines and moved
22162 all the functionality to RegisterRequiredImplementations.
22164 (TypeContainer.RegisterRequiredImplementations): This routine now
22165 registers all the implementations required in an array for the
22166 interfaces and abstract methods. We use an array of structures
22167 which can be computed ahead of time to reduce memory usage and we
22168 also assume that lookups are cheap as most classes will not
22169 implement too many interfaces.
22171 We also avoid creating too many MethodSignatures.
22173 (TypeContainer.IsInterfaceMethod): Update and optionally does not
22174 clear the "pending" bit if we find that there are problems with
22177 (TypeContainer.VerifyPendingMethods): Update to report errors of
22178 methods that look like implementations but are not.
22180 (TypeContainer.Define): Add support for explicit interface method
22183 2001-12-12 Miguel de Icaza <miguel@ximian.com>
22185 * typemanager.cs: Keep track of the parameters here instead of
22186 being a feature of the TypeContainer.
22188 * class.cs: Drop the registration of parameters here, as
22189 InterfaceMethods are also interface declarations.
22191 * delegate.cs: Register methods with the TypeManager not only with
22192 the TypeContainer. This code was buggy.
22194 * interface.cs: Full registation here.
22196 2001-12-11 Miguel de Icaza <miguel@ximian.com>
22198 * expression.cs: Remove reducer for binary expressions, it can not
22201 * const.cs: Put here the code that used to go into constant.cs
22203 * constant.cs: Put here the code for constants, this is a new base
22204 class for Literals.
22206 * literal.cs: Make Literal derive from Constant.
22208 2001-12-09 Miguel de Icaza <miguel@ximian.com>
22210 * statement.cs (Return.Emit): Report error 157 if the user
22211 attempts to return from a finally block.
22213 (Return.Emit): Instead of emitting a return, jump to the end of
22216 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
22217 LocalBuilder to store the result of the function. ReturnLabel is
22218 the target where we jump.
22221 2001-12-09 Radek Doulik <rodo@ximian.com>
22223 * cs-parser.jay: remember alias in current namespace
22225 * ecore.cs (SimpleName::DoResolve): use aliases for types or
22228 * class.cs (LookupAlias): lookup alias in my_namespace
22230 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
22232 (LookupAlias): lookup alias in this and if needed in parent
22235 2001-12-08 Miguel de Icaza <miguel@ximian.com>
22239 * rootcontext.cs: (ModuleBuilder) Made static, first step into
22240 making things static. I need this to avoid passing the
22241 TypeContainer when calling ParameterType.
22243 * support.cs (InternalParameters.ParameterType): Remove ugly hack
22244 that did string manipulation to compute the type and then call
22245 GetType. Use Parameter.ParameterType instead.
22247 * cs-tokenizer.cs: Consume the suffix for floating values.
22249 * expression.cs (ParameterReference): figure out whether this is a
22250 reference parameter or not. Kill an extra variable by computing
22251 the arg_idx during emission.
22253 * parameter.cs (Parameters.GetParameterInfo): New overloaded
22254 function that returns whether a parameter is an out/ref value or not.
22256 (Parameter.ParameterType): The type of the parameter (base,
22257 without ref/out applied).
22259 (Parameter.Resolve): Perform resolution here.
22260 (Parameter.ExternalType): The full type (with ref/out applied).
22262 * statement.cs (Using.Emit, Using.EmitExpression): Implement
22263 support for expressions on the using statement.
22265 2001-12-07 Miguel de Icaza <miguel@ximian.com>
22267 * statement.cs (Using.EmitLocalVariableDecls): Split the
22268 localvariable handling of the using statement.
22270 (Block.EmitMeta): Keep track of variable count across blocks. We
22271 were reusing slots on separate branches of blocks.
22273 (Try.Emit): Emit the general code block, we were not emitting it.
22275 Check the type of the declaration to be an IDisposable or
22276 something that can be implicity converted to it.
22278 Emit conversions if required.
22280 * ecore.cs (EmptyExpression): New utility class.
22281 (Expression.ImplicitConversionExists): New utility function.
22283 2001-12-06 Miguel de Icaza <miguel@ximian.com>
22285 * statement.cs (Using): Implement.
22287 * expression.cs (LocalVariableReference): Support read only variables.
22289 * statement.cs: Remove the explicit emit for the Leave opcode.
22290 (VariableInfo): Add a readonly field.
22292 2001-12-05 Miguel de Icaza <miguel@ximian.com>
22294 * ecore.cs (ConvCast): new class used to encapsulate the various
22295 explicit integer conversions that works in both checked and
22296 unchecked contexts.
22298 (Expression.ConvertNumericExplicit): Use new ConvCast class to
22299 properly generate the overflow opcodes.
22301 2001-12-04 Miguel de Icaza <miguel@ximian.com>
22303 * statement.cs: The correct type for the EmptyExpression is the
22304 element_type, not the variable type. Ravi pointed this out.
22306 2001-12-04 Ravi Pratap <ravi@ximian.com>
22308 * class.cs (Method::Define): Handle PInvoke methods specially
22309 by using DefinePInvokeMethod instead of the usual one.
22311 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
22312 above to do the task of extracting information and defining the method.
22314 2001-12-04 Ravi Pratap <ravi@ximian.com>
22316 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
22317 of the condition for string type.
22319 (Emit): Move that here.
22321 (ArrayCreation::CheckIndices): Keep string literals in their expression
22324 (EmitDynamicInitializers): Handle strings appropriately.
22326 2001-12-04 Miguel de Icaza <miguel@ximian.com>
22328 * codegen.cs (EmitContext): Replace multiple variables with a
22329 single pointer to the current Switch statement.
22331 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
22334 2001-12-03 Miguel de Icaza <miguel@ximian.com>
22338 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
22341 (Foreach.Emit): Foreach on arrays was not setting
22342 up the loop variables (for break/continue).
22344 (GotoCase): Semi-implented.
22346 2001-12-03 Ravi Pratap <ravi@ximian.com>
22348 * attribute.cs (CheckAttribute): Handle system attributes by using
22349 Attribute.GetAttributes to examine information we need.
22351 (GetValidPlaces): Same here.
22353 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
22355 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
22357 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
22359 (Method::Define): Set appropriate flags if we have a DllImport attribute.
22361 (Method::Emit): Handle the case when we are a PInvoke method.
22363 2001-12-03 Miguel de Icaza <miguel@ximian.com>
22365 * expression.cs: Use ResolveWithSimpleName on compound names.
22367 2001-12-02 Ravi Pratap <ravi@ximian.com>
22369 * constant.cs (EmitConstant): Make sure we resolve the associated expression
22370 before trying to reduce it.
22372 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
22374 * constant.cs (LookupConstantValue): Implement.
22376 (EmitConstant): Use the above in emitting the constant.
22378 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
22379 that are user-defined by doing a LookupConstantValue on them.
22381 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
22384 2001-11-29 Miguel de Icaza <miguel@ximian.com>
22386 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
22388 (BaseAccess.DoResolve): Implement.
22390 (MemberAccess.DoResolve): Split this routine into a
22391 ResolveMemberAccess routine that can be used independently
22393 2001-11-28 Miguel de Icaza <miguel@ximian.com>
22395 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
22396 As that share bits of the implementation. Is returns a boolean,
22397 while As returns the Type that is being probed.
22399 2001-12-01 Ravi Pratap <ravi@ximian.com>
22401 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
22402 instead of a Literal - much easier.
22404 (EnumInTransit): Remove - utterly useless :-)
22406 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
22408 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
22410 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
22411 chain when we have no associated expression.
22413 2001-11-30 Ravi Pratap <ravi@ximian.com>
22415 * constant.cs (Define): Use Location while reporting the errror.
22417 Also emit a warning when 'new' is used and there is no inherited
22420 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
22423 (LookupEnumValue): Implement to lookup an enum member's value and define it
22426 (Populate): Re-write accordingly to use the above routine.
22428 2001-11-27 Miguel de Icaza <miguel@ximian.com>
22430 * expression.cs (This): Fix prototype for DoResolveLValue to
22431 override the base class DoResolveLValue.
22433 * cs-parser.cs: Report errors cs574 and cs575 (destructor
22436 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
22437 (we need to load the address of the field here). This fixes
22440 (FieldExpr.DoResolveLValue): Call the DoResolve
22441 function to initialize the Instance expression.
22443 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
22444 correctly the GetEnumerator operation on a value type.
22446 * cs-parser.jay: Add more simple parsing error catches.
22448 * statement.cs (Switch): Add support for string switches.
22449 Handle null specially.
22451 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
22453 2001-11-28 Ravi Pratap <ravi@ximian.com>
22455 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
22457 (declare_local_constant): New helper function.
22459 * statement.cs (AddConstant): Keep a separate record of constants
22461 (IsConstant): Implement to determine if a variable is a constant.
22463 (GetConstantExpression): Implement.
22465 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
22467 * statement.cs (IsVariableDefined): Re-write.
22469 2001-11-27 Ravi Pratap <ravi@ximian.com>
22471 * class.cs (TypeContainer::FindMembers): Look for constants
22472 in the case when we are looking for MemberTypes.Field
22474 * expression.cs (MemberAccess::DoResolve): Check that in the
22475 case we are a FieldExpr and a Literal, we are not being accessed
22476 by an instance reference.
22478 * cs-parser.jay (local_constant_declaration): Implement.
22480 (declaration_statement): Implement for constant declarations.
22482 2001-11-26 Miguel de Icaza <miguel@ximian.com>
22484 * statement.cs (Switch): Catch double defaults.
22486 (Switch): More work on the switch() statement
22487 implementation. It works for integral values now, need to finish
22491 2001-11-24 Miguel de Icaza <miguel@ximian.com>
22493 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
22494 integer literals into other integer literals. To be used by
22497 2001-11-24 Ravi Pratap <ravi@ximian.com>
22499 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
22502 (EmitDynamicInitializers): Cope with the above since we extract data
22503 directly from ArrayData now.
22505 (ExpectInitializers): Keep track of whether initializers are mandatory
22508 (Bounds): Make it a hashtable to prevent the same dimension being
22509 recorded for every element in that dimension.
22511 (EmitDynamicInitializers): Fix bug which prevented the Set array method
22514 Also fix bug which was causing the indices to be emitted in the reverse
22517 2001-11-24 Miguel de Icaza <miguel@ximian.com>
22519 * expression.cs (ArrayCreation): Implement the bits that Ravi left
22520 unfinished. They do not work, because the underlying code is
22523 2001-11-22 Miguel de Icaza <miguel@ximian.com>
22525 * cs-parser.jay: Remove bogus fixme.
22527 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
22528 on Switch statement.
22530 2001-11-23 Ravi Pratap <ravi@ximian.com>
22532 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
22535 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
22536 parameter. Apparently, any expression is allowed.
22538 (ValidateInitializers): Update accordingly.
22540 (CheckIndices): Fix some tricky bugs thanks to recursion.
22542 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
22543 I was being completely brain-dead.
22545 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
22546 and re-write acordingly.
22548 (DelegateInvocation): Re-write accordingly.
22550 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
22552 (MakeByteBlob): Handle types more correctly.
22554 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
22555 initialization from expressions but it is incomplete because I am a complete
22558 2001-11-22 Miguel de Icaza <miguel@ximian.com>
22560 * statement.cs (If.Emit): Fix a bug that generated incorrect code
22561 on If. Basically, we have to return `true' (ie, we do return to
22562 our caller) only if both branches of the if return.
22564 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
22565 short-circuit operators, handle them as short circuit operators.
22567 (Cast.DoResolve): Resolve type.
22568 (Cast.Cast): Take an expression as the target type.
22570 * cs-parser.jay (cast_expression): Remove old hack that only
22571 allowed a limited set of types to be handled. Now we take a
22572 unary_expression and we resolve to a type during semantic
22575 Use the grammar productions from Rhys to handle casts (this is
22576 not complete like Rhys syntax yet, we fail to handle that corner
22577 case that C# has regarding (-x), but we will get there.
22579 2001-11-22 Ravi Pratap <ravi@ximian.com>
22581 * class.cs (EmitFieldInitializer): Take care of the case when we have a
22582 field which is an array type.
22584 * cs-parser.jay (declare_local_variables): Support array initialization too.
22586 * typemanager.cs (MakeKey): Implement.
22588 (everywhere): Use the above appropriately.
22590 * cs-parser.jay (for_statement): Update for array initialization while
22591 declaring variables.
22593 * ecore.cs : The error message was correct, it's the variable's names that
22594 were misleading ;-) Make the code more readable.
22596 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
22597 the correct type etc.
22599 (ConvertExplicit): Handle Enum types by examining the underlying type.
22601 2001-11-21 Ravi Pratap <ravi@ximian.com>
22603 * parameter.cs (GetCallingConvention): Always return
22604 CallingConventions.Standard for now.
22606 2001-11-22 Miguel de Icaza <miguel@ximian.com>
22608 * expression.cs (Binary.ResolveOperator): Update the values of `l'
22609 and `r' after calling DoNumericPromotions.
22611 * ecore.cs: Fix error message (the types were in the wrong order).
22613 * statement.cs (Foreach.ProbeCollectionType): Need to pass
22614 BindingFlags.Instance as well
22616 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
22617 implicit int literal conversion in an empty cast so that we
22618 propagate the right type upstream.
22620 (UnboxCast): new class used to unbox value types.
22621 (Expression.ConvertExplicit): Add explicit type conversions done
22624 (Expression.ImplicitNumericConversion): Oops, forgot to test for
22625 the target type before applying the implicit LongLiterals to ULong
22628 2001-11-21 Miguel de Icaza <miguel@ximian.com>
22630 * cs-parser.jay (for_statement): Reworked the way For works: now
22631 we declare manually any variables that are introduced in
22632 for_initializer to solve the problem of having out-of-band code
22633 emition (that is what got for broken).
22635 (declaration_statement): Perform the actual variable declaration
22636 that used to be done in local_variable_declaration here.
22638 (local_variable_declaration): Do not declare anything, just pass
22639 the information on a DictionaryEntry
22641 2001-11-20 Ravi Pratap <ravi@ximian.com>
22643 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
22644 re-write of the logic to now make it recursive.
22646 (UpdateIndices): Re-write accordingly.
22648 Store element data in a separate ArrayData list in the above methods.
22650 (MakeByteBlob): Implement to dump the array data into a byte array.
22652 2001-11-19 Ravi Pratap <ravi@ximian.com>
22654 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
22657 * constant.cs (Define): Implement.
22659 (EmitConstant): Re-write fully.
22661 Pass in location info.
22663 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
22666 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
22667 DictionaryEntry since we need location info too.
22669 (constant_declaration): Update accordingly.
22671 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
22672 code into another method : UpdateIndices.
22674 2001-11-18 Ravi Pratap <ravi@ximian.com>
22676 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
22677 some type checking etc.
22679 2001-11-17 Ravi Pratap <ravi@ximian.com>
22681 * expression.cs (ArrayCreation::ValidateInitializers): Implement
22682 bits to provide dimension info if the user skips doing that.
22684 Update second constructor to store the rank correctly.
22686 2001-11-16 Ravi Pratap <ravi@ximian.com>
22688 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
22689 and try to implement.
22691 * ../errors/cs0150.cs : Add.
22693 * ../errors/cs0178.cs : Add.
22695 2001-11-16 Miguel de Icaza <miguel@ximian.com>
22697 * statement.cs: Implement foreach on multi-dimensional arrays.
22699 * parameter.cs (Parameters.GetParameterByName): Also lookup the
22700 name of the params argument.
22702 * expression.cs: Use EmitStoreOpcode to get the right opcode while
22703 initializing the array.
22705 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
22706 we can use this elsewhere.
22708 * statement.cs: Finish implementation of foreach for single
22711 * cs-parser.jay: Use an out-of-band stack to pass information
22712 around, I wonder why I need this.
22714 foreach_block: Make the new foreach_block the current_block.
22716 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
22717 function used to return a static Parameters structure. Used for
22718 empty parameters, as those are created very frequently.
22720 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
22722 2001-11-15 Ravi Pratap <ravi@ximian.com>
22724 * interface.cs : Default modifier is private, not public. The
22725 make verify test passes again.
22727 2001-11-15 Ravi Pratap <ravi@ximian.com>
22729 * support.cs (ReflectionParameters): Fix logic to determine
22730 whether the last parameter is a params one. Test 9 passes again.
22732 * delegate.cs (Populate): Register the builders we define with
22733 RegisterParameterForBuilder. Test 19 passes again.
22735 * cs-parser.jay (property_declaration): Reference $6 instead
22736 of $$ to get at the location.
22738 (indexer_declaration): Similar stuff.
22740 (attribute): Ditto.
22742 * class.cs (Property): Register parameters for the Get and Set methods
22743 if they exist. Test 23 passes again.
22745 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
22746 call to EmitArguments as we are sure there aren't any params arguments.
22747 Test 32 passes again.
22749 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
22750 IndexOutOfRangeException.
22752 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
22753 Test 33 now passes again.
22755 2001-11-15 Miguel de Icaza <miguel@ximian.com>
22757 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
22758 broke a bunch of things. Will have to come up with a better way
22759 of tracking locations.
22761 * statement.cs: Implemented foreach for single dimension arrays.
22763 2001-11-09 Miguel de Icaza <miguel@ximian.com>
22765 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
22766 an error. This removes the lookup from the critical path.
22768 * cs-parser.jay: Removed use of temporary_loc, which is completely
22771 2001-11-14 Miguel de Icaza <miguel@ximian.com>
22773 * support.cs (ReflectionParameters.ParameterModifier): Report
22774 whether the argument is a PARAMS argument or not.
22776 * class.cs: Set the attribute `ParamArrayAttribute' on the
22777 parameter argument.
22779 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
22780 and cons_param_array_attribute (ConstructorInfo for
22781 ParamArrayAttribute).,
22783 * codegen.cs: Emit the return using the `Return' statement, that
22784 way we can report the error correctly for missing return values.
22786 * class.cs (Method.Emit): Clean up.
22788 * expression.cs (Argument.Resolve): Take another argument: the
22789 location where this argument is used. Notice that this is not
22790 part of the "Argument" class as to reduce the size of the
22791 structure (we know the approximate location anyways).
22793 Test if the argument is a variable-reference, if not, then
22794 complain with a 206.
22796 (Argument.Emit): Emit addresses of variables.
22798 (Argument.FullDesc): Simplify.
22800 (Invocation.DoResolve): Update for Argument.Resolve.
22802 (ElementAccess.DoResolve): ditto.
22804 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
22805 method should be virtual, as this method is always virtual.
22807 (NewDelegate.DoResolve): Update for Argument.Resolve.
22809 * class.cs (ConstructorInitializer.DoResolve): ditto.
22811 * attribute.cs (Attribute.Resolve): ditto.
22813 2001-11-13 Miguel de Icaza <miguel@ximian.com>
22815 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
22817 * expression.cs (ParameterReference): Drop IStackStorage and implement
22818 IAssignMethod instead.
22820 (LocalVariableReference): ditto.
22822 * ecore.cs (FieldExpr): Drop IStackStorage and implement
22823 IAssignMethod instead.
22825 2001-11-13 Miguel de Icaza <miguel@ximian.com>
22827 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
22828 enumerations that are used in heavily used structures derive from
22829 byte in a laughable and pathetic attempt to reduce memory usage.
22830 This is the kind of pre-optimzations that you should not do at
22831 home without adult supervision.
22833 * expression.cs (UnaryMutator): New class, used to handle ++ and
22834 -- separatedly from the other unary operators. Cleans up the
22835 code, and kills the ExpressionStatement dependency in Unary.
22837 (Unary): Removed `method' and `Arguments' from this class, making
22838 it smaller, and moving it all to SimpleCall, so I can reuse this
22839 code in other locations and avoid creating a lot of transient data
22840 strucutres when not required.
22842 * cs-parser.jay: Adjust for new changes.
22844 2001-11-11 Miguel de Icaza <miguel@ximian.com>
22846 * enum.cs (Enum.Populate): If there is a failure during
22849 * cs-parser.jay (opt_enum_base): we used to catch type errors
22850 here, but this is really incorrect. The type error should be
22851 catched during semantic analysis.
22853 2001-12-11 Ravi Pratap <ravi@ximian.com>
22855 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
22856 current_local_parameters as expected since I, in my stupidity, had forgotten
22859 * attribute.cs (GetValidPlaces): Fix stupid bug.
22861 * class.cs (Method::Emit): Perform check on applicability of attributes.
22863 (Constructor::Emit): Ditto.
22865 (Field::Emit): Ditto.
22867 (Field.Location): Store location information.
22869 (Property, Event, Indexer, Operator): Ditto.
22871 * cs-parser.jay (field_declaration): Pass in location for each field.
22873 * ../errors/cs0592.cs : Add.
22875 2001-11-12 Ravi Pratap <ravi@ximian.com>
22877 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
22879 (InitCoreTypes): Update accordingly.
22881 (RegisterAttrType, LookupAttr): Implement.
22883 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
22884 info about the same.
22886 (Resolve): Update to populate the above as necessary.
22888 (Error592): Helper.
22890 (GetValidPlaces): Helper to the above.
22892 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
22894 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
22896 2001-11-12 Ravi Pratap <ravi@ximian.com>
22898 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
22900 * ../errors/cs0617.cs : Add.
22902 2001-11-11 Ravi Pratap <ravi@ximian.com>
22904 * enum.cs (Emit): Rename to Populate to be more consistent with what
22905 we expect it to do and when exactly it is called.
22907 * class.cs, rootcontext.cs : Update accordingly.
22909 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
22910 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
22912 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
22914 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
22915 of a fieldinfo using the above, when dealing with a FieldBuilder.
22917 2001-11-10 Ravi Pratap <ravi@ximian.com>
22919 * ../errors/cs0031.cs : Add.
22921 * ../errors/cs1008.cs : Add.
22923 * ../errrors/cs0543.cs : Add.
22925 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
22928 (FindMembers): Implement.
22930 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
22931 enums and delegates too.
22933 (enum_types): Rename to builder_to_enum.
22935 (delegate_types): Rename to builder_to_delegate.
22937 * delegate.cs (FindMembers): Implement.
22939 2001-11-09 Ravi Pratap <ravi@ximian.com>
22941 * typemanager.cs (IsEnumType): Implement.
22943 * enum.cs (Emit): Re-write parts to account for the underlying type
22944 better and perform checking etc.
22946 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
22947 of the underlying type.
22949 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
22952 * enum.cs (error31): Helper to report error #31.
22954 * cs-parser.jay (enum_declaration): Store location of each member too.
22956 * enum.cs (member_to_location): New hashtable.
22958 (AddEnumMember): Update location hashtable.
22960 (Emit): Use the location of each member while reporting errors.
22962 2001-11-09 Miguel de Icaza <miguel@ximian.com>
22964 * cs-parser.jay: A for_initializer if is a
22965 local_variable_declaration really ammount to have an implicit
22966 block with the variable declaration and no initializer for for.
22968 * statement.cs (For.Emit): Cope with null initializers.
22970 This fixes the infinite loop on for initializers.
22972 2001-11-08 Miguel de Icaza <miguel@ximian.com>
22974 * enum.cs: More cleanup.
22976 * ecore.cs: Remove dead code.
22978 * class.cs (Property.Emit): More simplification.
22979 (Event.Emit): ditto.
22981 Reworked to have less levels of indentation.
22983 2001-11-08 Ravi Pratap <ravi@ximian.com>
22985 * class.cs (Property): Emit attributes.
22995 * enum.cs (Emit): Ditto.
22997 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
23000 * class.cs (Field, Event, etc.): Move attribute generation into the
23001 Emit method everywhere.
23003 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
23004 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
23005 as we had no way of defining nested enums !
23007 * rootcontext.cs : Adjust code accordingly.
23009 * typemanager.cs (AddEnumType): To keep track of enum types separately.
23011 2001-11-07 Ravi Pratap <ravi@ximian.com>
23013 * expression.cs (EvalConstantExpression): Move into ecore.cs
23015 * enum.cs (Enum): Rename some members and make them public and readonly
23016 according to our convention.
23018 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
23021 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
23023 (Enum::Emit): Write a simple version for now which doesn't try to compute
23024 expressions. I shall modify this to be more robust in just a while.
23026 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
23028 (TypeContainer::CloseType): Create the Enum types too.
23030 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
23032 * expression.cs (EvalConstantExpression): Get rid of completely.
23034 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
23035 user-defined values and other cases.
23037 (IsValidEnumLiteral): Helper function.
23039 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
23040 out there in the case we had a literal FieldExpr.
23042 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
23044 (Literalize): Revamp a bit to take two arguments.
23046 (EnumLiteral): New class which derives from Literal to wrap enum literals.
23048 2001-11-06 Ravi Pratap <ravi@ximian.com>
23050 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
23052 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
23054 (Resolve): Use the above to ensure we have proper initializers.
23056 2001-11-05 Ravi Pratap <ravi@ximian.com>
23058 * expression.cs (Expression::EvalConstantExpression): New method to
23059 evaluate constant expressions.
23061 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
23063 2001-11-07 Miguel de Icaza <miguel@ximian.com>
23065 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
23068 (Binary.ResolveOperator): Handle operator != (object a, object b)
23069 and operator == (object a, object b);
23071 (Binary.DoNumericPromotions): Indicate whether the numeric
23072 promotion was possible.
23074 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
23077 Made the ArrayAccess implement interface IAssignMethod instead of
23078 IStackStore as the order in which arguments are passed reflects
23081 * assign.cs: Instead of using expr.ExprClass to select the way of
23082 assinging, probe for the IStackStore/IAssignMethod interfaces.
23084 * typemanager.cs: Load InitializeArray definition.
23086 * rootcontext.cs (RootContext.MakeStaticData): Used to define
23087 static data that can be used to initialize arrays.
23089 2001-11-05 Miguel de Icaza <miguel@ximian.com>
23091 * expression.cs: Handle operator== and operator!= for booleans.
23093 (Conditioal.Reduce): Implement reducer for the ?: operator.
23095 (Conditional.Resolve): Implement dead code elimination.
23097 (Binary.Resolve): Catch string literals and return a new
23098 concatenated string.
23100 (Unary.Reduce): Implement reduction of unary expressions.
23102 * ecore.cs: Split out the expression core handling here.
23104 (Expression.Reduce): New method used to perform constant folding
23105 and CSE. This is needed to support constant-expressions.
23107 * statement.cs (Statement.EmitBoolExpression): Pass true and false
23108 targets, and optimize for !x.
23110 2001-11-04 Ravi Pratap <ravi@ximian.com>
23112 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
23113 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
23114 set custom atttributes.
23116 * literal.cs (Literal::GetValue): New abstract method to return the actual
23117 value of the literal, cast as an object.
23119 (*Literal): Implement GetValue method.
23121 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
23122 expressions to the arraylist but objects of type Argument.
23124 * class.cs (TypeContainer::Emit): Emit our attributes too.
23126 (Method::Emit, Constructor::Emit): Ditto.
23128 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
23129 to be ignoring earlier.
23131 2001-11-03 Ravi Pratap <ravi@ximian.com>
23133 * attribute.cs (AttributeSection::Define): Implement to do the business
23134 of constructing a CustomAttributeBuilder.
23136 (Attribute): New trivial class. Increases readability of code.
23138 * cs-parser.jay : Update accordingly.
23140 (positional_argument_list, named_argument_list, named_argument): New rules
23142 (attribute_arguments): Use the above so that we are more correct.
23144 2001-11-02 Ravi Pratap <ravi@ximian.com>
23146 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
23147 to perform all checks for a method with a params parameter.
23149 (Invocation::OverloadResolve): Update to use the above method and therefore
23150 cope correctly with params method invocations.
23152 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
23155 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
23156 constructors in our parent too because we can't afford to miss out on
23159 * attribute.cs (AttributeSection): New name for the class Attribute
23161 Other trivial changes to improve readability.
23163 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
23164 use the new class names.
23166 2001-11-01 Ravi Pratap <ravi@ximian.com>
23168 * class.cs (Method::Define): Complete definition for params types too
23170 (Indexer::Define): Ditto.
23172 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
23173 Cope everywhere with a request for info about the array parameter.
23175 2001-11-01 Ravi Pratap <ravi@ximian.com>
23177 * tree.cs (RecordNamespace): Fix up to check for the correct key.
23179 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
23180 local_variable_type to extract the string corresponding to the type.
23182 (local_variable_type): Fixup the action to use the new helper method.
23184 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
23187 * expression.cs : Clean out code which uses the above.
23189 2001-10-31 Ravi Pratap <ravi@ximian.com>
23191 * typemanager.cs (RegisterMethod): Check if we already have an existing key
23192 and bale out if necessary by returning a false.
23194 (RegisterProperty): Ditto.
23196 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
23197 and print out appropriate error messages.
23199 * interface.cs (everywhere): Ditto.
23201 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
23202 location to constructor.
23204 * class.cs (Property, Event, Indexer): Update accordingly.
23206 * ../errors/cs111.cs : Added.
23208 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
23209 of a method, as laid down by the spec.
23211 (Invocation::OverloadResolve): Use the above method.
23213 2001-10-31 Ravi Pratap <ravi@ximian.com>
23215 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
23216 now take a TypeContainer and a Parameters object.
23218 (ParameterData): Modify return type of ParameterModifier method to be
23219 Parameter.Modifier and not a string.
23221 (ReflectionParameters, InternalParameters): Update accordingly.
23223 * expression.cs (Argument::GetParameterModifier): Same here.
23225 * support.cs (InternalParameters::ParameterType): Find a better way of determining
23226 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
23227 symbol in it at all so maybe this is only for now.
23229 2001-10-30 Ravi Pratap <ravi@ximian.com>
23231 * support.cs (InternalParameters): Constructor now takes an extra argument
23232 which is the actual Parameters class.
23234 (ParameterDesc): Update to provide info on ref/out modifiers.
23236 * class.cs (everywhere): Update call to InternalParameters to pass in
23237 the second argument too.
23239 * support.cs (ParameterData): Add ParameterModifier, which is a method
23240 to return the modifier info [ref/out etc]
23242 (InternalParameters, ReflectionParameters): Implement the above.
23244 * expression.cs (Argument::ParameterModifier): Similar function to return
23245 info about the argument's modifiers.
23247 (Invocation::OverloadResolve): Update to take into account matching modifiers
23250 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
23251 a new SetFormalParameters object which we pass to InternalParameters.
23253 2001-10-30 Ravi Pratap <ravi@ximian.com>
23255 * expression.cs (NewArray): Merge into the ArrayCreation class.
23257 2001-10-29 Ravi Pratap <ravi@ximian.com>
23259 * expression.cs (NewArray): Merge classes NewBuiltinArray and
23260 NewUserdefinedArray into one as there wasn't much of a use in having
23263 * expression.cs (Argument): Change field's name to ArgType from Type.
23265 (Type): New readonly property which returns the proper type, taking into
23266 account ref/out modifiers.
23268 (everywhere): Adjust code accordingly for the above.
23270 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
23271 whether we are emitting for a ref or out parameter.
23273 * expression.cs (Argument::Emit): Use the above field to set the state.
23275 (LocalVariableReference::Emit): Update to honour the flag and emit the
23278 * parameter.cs (Attributes): Set the correct flags for ref parameters.
23280 * expression.cs (Argument::FullDesc): New function to provide a full desc.
23282 * support.cs (ParameterData): Add method ParameterDesc to the interface.
23284 (ReflectionParameters, InternalParameters): Implement the above method.
23286 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
23289 (Invocation::FullMethodDesc): Ditto.
23291 2001-10-29 Miguel de Icaza <miguel@ximian.com>
23293 * cs-parser.jay: Add extra production for the second form of array
23296 * expression.cs (ArrayCreation): Update to reflect the above
23299 * Small changes to prepare for Array initialization.
23301 2001-10-28 Miguel de Icaza <miguel@ximian.com>
23303 * typemanager.cs (ImplementsInterface): interface might be null;
23304 Deal with this problem;
23306 Also, we do store negative hits on the cache (null values), so use
23307 this instead of calling t.GetInterfaces on the type everytime.
23309 2001-10-28 Ravi Pratap <ravi@ximian.com>
23311 * typemanager.cs (IsBuiltinType): New method to help determine the same.
23313 * expression.cs (New::DoResolve): Get rid of array creation code and instead
23314 split functionality out into different classes.
23316 (New::FormArrayType): Move into NewBuiltinArray.
23318 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
23321 (NewBuiltinArray): New class to handle creation of built-in arrays.
23323 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
23324 account creation of one-dimensional arrays.
23326 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
23328 (NewUserdefinedArray::DoResolve): Implement.
23330 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
23332 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
23333 we maintain inside the TypeManager. This is necessary to perform lookups on the
23336 (LookupType): Update to perform GetType on the module builders too.
23338 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
23340 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
23342 2001-10-23 Ravi Pratap <ravi@ximian.com>
23344 * expression.cs (New::DoResolve): Implement guts of array creation.
23346 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
23348 2001-10-27 Miguel de Icaza <miguel@ximian.com>
23350 * expression.cs: Fix bug I introduced lsat night that broke
23353 (Expression.Resolve): Report a 246 error (can not resolve name)
23354 if we find a SimpleName in the stream.
23356 (Expression.ResolveLValue): Ditto.
23358 (Expression.ResolveWithSimpleName): This function is a variant of
23359 ResolveName, this one allows SimpleNames to be returned without a
23360 warning. The only consumer of SimpleNames is MemberAccess
23362 2001-10-26 Miguel de Icaza <miguel@ximian.com>
23364 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
23365 might arrive here. I have my doubts that this is correct.
23367 * statement.cs (Lock): Implement lock statement.
23369 * cs-parser.jay: Small fixes to support `lock' and `using'
23371 * cs-tokenizer.cs: Remove extra space
23373 * driver.cs: New flag --checked, allows to turn on integer math
23376 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
23377 Threading.Monitor.Exit
23379 2001-10-23 Miguel de Icaza <miguel@ximian.com>
23381 * expression.cs (IndexerAccess::DoResolveLValue): Set the
23382 Expression Class to be IndexerAccess.
23384 Notice that Indexer::DoResolve sets the eclass to Value.
23386 2001-10-22 Miguel de Icaza <miguel@ximian.com>
23388 * class.cs (TypeContainer::Emit): Emit code for indexers.
23390 * assign.cs (IAssignMethod): New interface implemented by Indexers
23391 and Properties for handling assignment.
23393 (Assign::Emit): Simplify and reuse code.
23395 * expression.cs (IndexerAccess, PropertyExpr): Implement
23396 IAssignMethod, clean up old code.
23398 2001-10-22 Ravi Pratap <ravi@ximian.com>
23400 * typemanager.cs (ImplementsInterface): New method to determine if a type
23401 implements a given interface. Provides a nice cache too.
23403 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
23406 (ConvertReferenceExplicit): Ditto.
23408 * delegate.cs (Delegate::Populate): Update to define the parameters on the
23409 various methods, with correct names etc.
23411 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
23412 Operator.UnaryNegation.
23414 * cs-parser.jay (operator_declarator): Be a little clever in the case where
23415 we have a unary plus or minus operator.
23417 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
23420 * everywhere : update accordingly.
23422 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
23425 * class.cs (Method::Define): For the case where we are implementing a method
23426 inherited from an interface, we need to set the MethodAttributes.Final flag too.
23427 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
23429 2001-10-21 Ravi Pratap <ravi@ximian.com>
23431 * interface.cs (FindMembers): Implement to work around S.R.E
23434 * typemanager.cs (IsInterfaceType): Implement.
23436 (FindMembers): Update to handle interface types too.
23438 * expression.cs (ImplicitReferenceConversion): Re-write bits which
23439 use IsAssignableFrom as that is not correct - it doesn't work.
23441 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
23442 and accordingly override EmitStatement.
23444 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
23445 using the correct logic :-)
23447 2001-10-19 Ravi Pratap <ravi@ximian.com>
23449 * ../errors/cs-11.cs : Add to demonstrate error -11
23451 2001-10-17 Miguel de Icaza <miguel@ximian.com>
23453 * assign.cs (Assign::Resolve): Resolve right hand side first, and
23454 then pass this as a hint to ResolveLValue.
23456 * expression.cs (FieldExpr): Add Location information
23458 (FieldExpr::LValueResolve): Report assignment to readonly
23461 (Expression::ExprClassFromMemberInfo): Pass location information.
23463 (Expression::ResolveLValue): Add new method that resolves an
23466 (Expression::DoResolveLValue): Default invocation calls
23469 (Indexers): New class used to keep track of indexers in a given
23472 (IStackStore): Renamed from LValue, as it did not really describe
23473 what this did. Also ResolveLValue is gone from this interface and
23474 now is part of Expression.
23476 (ElementAccess): Depending on the element access type
23478 * typemanager.cs: Add `indexer_name_type' as a Core type
23479 (System.Runtime.CompilerServices.IndexerNameAttribute)
23481 * statement.cs (Goto): Take a location.
23483 2001-10-18 Ravi Pratap <ravi@ximian.com>
23485 * delegate.cs (Delegate::VerifyDelegate): New method to verify
23486 if two delegates are compatible.
23488 (NewDelegate::DoResolve): Update to take care of the case when
23489 we instantiate a delegate from another delegate.
23491 * typemanager.cs (FindMembers): Don't even try to look up members
23492 of Delegate types for now.
23494 2001-10-18 Ravi Pratap <ravi@ximian.com>
23496 * delegate.cs (NewDelegate): New class to take care of delegate
23499 * expression.cs (New): Split the delegate related code out into
23500 the NewDelegate class.
23502 * delegate.cs (DelegateInvocation): New class to handle delegate
23505 * expression.cs (Invocation): Split out delegate related code into
23506 the DelegateInvocation class.
23508 2001-10-17 Ravi Pratap <ravi@ximian.com>
23510 * expression.cs (New::DoResolve): Implement delegate creation fully
23511 and according to the spec.
23513 (New::DoEmit): Update to handle delegates differently.
23515 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
23516 because of which we were printing out arguments in reverse order !
23518 * delegate.cs (VerifyMethod): Implement to check if the given method
23519 matches the delegate.
23521 (FullDelegateDesc): Implement.
23523 (VerifyApplicability): Implement.
23525 * expression.cs (Invocation::DoResolve): Update to accordingly handle
23526 delegate invocations too.
23528 (Invocation::Emit): Ditto.
23530 * ../errors/cs1593.cs : Added.
23532 * ../errors/cs1594.cs : Added.
23534 * delegate.cs (InstanceExpression, TargetMethod): New properties.
23536 2001-10-16 Ravi Pratap <ravi@ximian.com>
23538 * typemanager.cs (intptr_type): Core type for System.IntPtr
23540 (InitCoreTypes): Update for the same.
23542 (iasyncresult_type, asynccallback_type): Ditto.
23544 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
23547 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
23550 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
23551 the builders for the 4 members of a delegate type :-)
23553 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
23556 * expression.cs (New::DoResolve): Implement guts for delegate creation.
23558 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
23560 2001-10-15 Miguel de Icaza <miguel@ximian.com>
23562 * statement.cs (Break::Emit): Implement.
23563 (Continue::Emit): Implement.
23565 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
23566 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
23567 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
23568 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
23571 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
23572 properties that track the label for the current loop (begin of the
23573 loop and end of the loop).
23575 2001-10-15 Ravi Pratap <ravi@ximian.com>
23577 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
23578 use of emitting anything at all.
23580 * class.cs, rootcontext.cs : Get rid of calls to the same.
23582 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
23584 (Populate): Define the constructor correctly and set the implementation
23587 * typemanager.cs (delegate_types): New hashtable to hold delegates that
23590 (AddDelegateType): Implement.
23592 (IsDelegateType): Implement helper method.
23594 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
23596 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
23597 and accordingly handle it.
23599 * delegate.cs (Populate): Take TypeContainer argument.
23600 Implement bits to define the Invoke method. However, I still haven't figured out
23601 how to take care of the native int bit :-(
23603 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
23604 Qualify the name of the delegate, not its return type !
23606 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
23609 (StandardConversionExists): Checking for array types turns out to be recursive.
23611 (ConvertReferenceExplicit): Implement array conversion.
23613 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
23615 2001-10-12 Ravi Pratap <ravi@ximian.com>
23617 * cs-parser.jay (delegate_declaration): Store the fully qualified
23618 name as it is a type declaration.
23620 * delegate.cs (ReturnType, Name): Rename members to these. Make them
23623 (DefineDelegate): Renamed from Define. Does the same thing essentially,
23624 as TypeContainer::DefineType.
23626 (Populate): Method in which all the definition of the various methods (Invoke)
23629 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
23632 (CloseDelegate): Finally creates the delegate.
23634 * class.cs (TypeContainer::DefineType): Update to define delegates.
23635 (Populate, Emit and CloseType): Do the same thing here too.
23637 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
23638 delegates in all these operations.
23640 2001-10-14 Miguel de Icaza <miguel@ximian.com>
23642 * expression.cs: LocalTemporary: a new expression used to
23643 reference a temporary that has been created.
23645 * assign.cs: Handle PropertyAccess back here, so that we can
23646 provide the proper semantic access to properties.
23648 * expression.cs (Expression::ConvertReferenceExplicit): Implement
23649 a few more explicit conversions.
23651 * modifiers.cs: `NEW' modifier maps to HideBySig.
23653 * expression.cs (PropertyExpr): Make this into an
23654 ExpressionStatement, and support the EmitStatement code path.
23656 Perform get/set error checking, clean up the interface.
23658 * assign.cs: recognize PropertyExprs as targets, and if so, turn
23659 them into toplevel access objects.
23661 2001-10-12 Miguel de Icaza <miguel@ximian.com>
23663 * expression.cs: PropertyExpr::PropertyExpr: use work around the
23666 * typemanager.cs: Keep track here of our PropertyBuilders again to
23667 work around lameness in SRE.
23669 2001-10-11 Miguel de Icaza <miguel@ximian.com>
23671 * expression.cs (LValue::LValueResolve): New method in the
23672 interface, used to perform a second resolution pass for LValues.
23674 (This::DoResolve): Catch the use of this in static methods.
23676 (This::LValueResolve): Implement.
23678 (This::Store): Remove warning, assigning to `this' in structures
23681 (Invocation::Emit): Deal with invocation of
23682 methods on value types. We need to pass the address to structure
23683 methods rather than the object itself. (The equivalent code to
23684 emit "this" for structures leaves the entire structure on the
23685 stack instead of a pointer to it).
23687 (ParameterReference::DoResolve): Compute the real index for the
23688 argument based on whether the method takes or not a `this' pointer
23689 (ie, the method is static).
23691 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
23692 value types returned from functions when we need to invoke a
23693 method on the sturcture.
23696 2001-10-11 Ravi Pratap <ravi@ximian.com>
23698 * class.cs (TypeContainer::DefineType): Method to actually do the business of
23699 defining the type in the Modulebuilder or Typebuilder. This is to take
23700 care of nested types which need to be defined on the TypeBuilder using
23701 DefineNestedMethod.
23703 (TypeContainer::GetClassBases): Implement. Essentially the code from the
23704 methods in RootContext, only ported to be part of TypeContainer.
23706 (TypeContainer::GetInterfaceOrClass): Ditto.
23708 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
23710 * interface.cs (Interface::DefineInterface): New method. Does exactly
23711 what RootContext.CreateInterface did earlier, only it takes care of nested types
23714 (Interface::GetInterfaces): Move from RootContext here and port.
23716 (Interface::GetInterfaceByName): Same here.
23718 * rootcontext.cs (ResolveTree): Re-write.
23720 (PopulateTypes): Re-write.
23722 * class.cs (TypeContainer::Populate): Populate nested types too.
23723 (TypeContainer::Emit): Emit nested members too.
23725 * typemanager.cs (AddUserType): Do not make use of the FullName property,
23726 instead just use the name argument passed in as it is already fully
23729 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
23730 to TypeContainer mapping to see if a type is user-defined.
23732 * class.cs (TypeContainer::CloseType): Implement.
23734 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
23735 the default constructor.
23737 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
23740 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
23742 * interface.cs (CloseType): Create the type here.
23744 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
23747 Remove all the methods which are now in TypeContainer.
23749 2001-10-10 Ravi Pratap <ravi@ximian.com>
23751 * delegate.cs (Define): Re-write bits to define the delegate
23754 2001-10-10 Miguel de Icaza <miguel@ximian.com>
23756 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
23758 * expression.cs (ImplicitReferenceConversion): handle null as well
23759 as a source to convert to any reference type.
23761 * statement.cs (Return): Perform any implicit conversions to
23762 expected return type.
23764 Validate use of return statement.
23766 * codegen.cs (EmitContext): Pass the expected return type here.
23768 * class.cs (Method, Constructor, Property): Pass expected return
23769 type to EmitContext.
23771 2001-10-09 Miguel de Icaza <miguel@ximian.com>
23773 * expression.cs: Make DoResolve take an EmitContext instead of a
23776 Replaced `l' and `location' for `loc', for consistency.
23778 (Error, Warning): Remove unneeded Tc argument.
23780 * assign.cs, literal.cs, constant.cs: Update to new calling
23783 * codegen.cs: EmitContext now contains a flag indicating whether
23784 code is being generated in a static method or not.
23786 * cs-parser.jay: DecomposeQI, new function that replaces the old
23787 QualifiedIdentifier. Now we always decompose the assembled
23788 strings from qualified_identifier productions into a group of
23791 2001-10-08 Miguel de Icaza <miguel@ximian.com>
23793 * rootcontext.cs: Deal with field-less struct types correctly now
23794 by passing the size option to Define Type.
23796 * class.cs: Removed hack that created one static field.
23798 2001-10-07 Miguel de Icaza <miguel@ximian.com>
23800 * statement.cs: Moved most of the code generation here.
23802 2001-10-09 Ravi Pratap <ravi@ximian.com>
23804 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
23807 (ElementAccess): Remove useless bits for now - keep checks as the spec
23810 2001-10-08 Ravi Pratap <ravi@ximian.com>
23812 * expression.cs (ElementAccess::DoResolve): Remove my crap code
23813 and start performing checks according to the spec.
23815 2001-10-07 Ravi Pratap <ravi@ximian.com>
23817 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
23818 rank_specifiers instead.
23820 (rank_specifiers): Change the order in which the rank specifiers are stored
23822 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
23824 * expression.cs (ElementAccess): Implement the LValue interface too.
23826 2001-10-06 Ravi Pratap <ravi@ximian.com>
23828 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
23829 except that user defined conversions are not included.
23831 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
23832 perform the conversion of the return type, if necessary.
23834 (New::DoResolve): Check whether we are creating an array or an object
23835 and accordingly do the needful.
23837 (New::Emit): Same here.
23839 (New::DoResolve): Implement guts of array creation.
23841 (New::FormLookupType): Helper function.
23843 2001-10-07 Miguel de Icaza <miguel@ximian.com>
23845 * codegen.cs: Removed most of the code generation here, and move the
23846 corresponding code generation bits to the statement classes.
23848 Added support for try/catch/finalize and throw.
23850 * cs-parser.jay: Added support for try/catch/finalize.
23852 * class.cs: Catch static methods having the flags override,
23853 virtual or abstract.
23855 * expression.cs (UserCast): This user cast was not really doing
23856 what it was supposed to do. Which is to be born in fully resolved
23857 state. Parts of the resolution were being performed at Emit time!
23861 2001-10-05 Miguel de Icaza <miguel@ximian.com>
23863 * expression.cs: Implicity convert the result from UserCast.
23865 2001-10-05 Ravi Pratap <ravi@ximian.com>
23867 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
23868 prevented it from working correctly.
23870 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
23871 merely ConvertImplicit.
23873 2001-10-05 Miguel de Icaza <miguel@ximian.com>
23875 * typemanager.cs: Make the LookupTypeContainer function static,
23876 and not per-instance.
23878 * class.cs: Make static FindMembers (the one that takes a Type
23881 * codegen.cs: Add EmitForeach here.
23883 * cs-parser.jay: Make foreach a toplevel object instead of the
23884 inline expansion, as we need to perform semantic analysis on it.
23886 2001-10-05 Ravi Pratap <ravi@ximian.com>
23888 * expression.cs (Expression::ImplicitUserConversion): Rename to
23889 UserDefinedConversion.
23891 (Expression::UserDefinedConversion): Take an extra argument specifying
23892 whether we look for explicit user conversions too.
23894 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
23896 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
23898 (ExplicitUserConversion): Make it a call to UserDefinedConversion
23899 with the appropriate arguments.
23901 * cs-parser.jay (cast_expression): Record location too.
23903 * expression.cs (Cast): Record location info.
23905 (Expression::ConvertExplicit): Take location argument.
23907 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
23908 to determine if we are doing explicit conversions.
23910 (UserCast::Emit): Update accordingly.
23912 (Expression::ConvertExplicit): Report an error if everything fails.
23914 * ../errors/cs0030.cs : Add.
23916 2001-10-04 Miguel de Icaza <miguel@ximian.com>
23918 * modifiers.cs: If the ABSTRACT keyword is present, also set the
23919 virtual and newslot bits.
23921 * class.cs (TypeContainer::RegisterRequiredImplementations):
23922 Record methods we need.
23924 (TypeContainer::MakeKey): Helper function to make keys for
23925 MethodBases, since the Methodbase key is useless.
23927 (TypeContainer::Populate): Call RegisterRequiredImplementations
23928 before defining the methods.
23930 Create a mapping for method_builders_to_methods ahead of time
23931 instead of inside a tight loop.
23933 (::RequireMethods): Accept an object as the data to set into the
23934 hashtable so we can report interface vs abstract method mismatch.
23936 2001-10-03 Miguel de Icaza <miguel@ximian.com>
23938 * report.cs: Make all of it static.
23940 * rootcontext.cs: Drop object_type and value_type computations, as
23941 we have those in the TypeManager anyways.
23943 Drop report instance variable too, now it is a global.
23945 * driver.cs: Use try/catch on command line handling.
23947 Add --probe option to debug the error reporting system with a test
23950 * report.cs: Add support for exiting program when a probe
23951 condition is reached.
23953 2001-10-03 Ravi Pratap <ravi@ximian.com>
23955 * expression.cs (Binary::DoNumericPromotions): Fix the case when
23956 we do a forcible conversion regardless of type, to check if
23957 ForceConversion returns a null.
23959 (Binary::error19): Use location to report error.
23961 (Unary::error23): Use location here too.
23963 * ../errors/cs0019.cs : Check in.
23965 * ../errors/cs0023.cs : Check in.
23967 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
23968 case of a non-null MethodInfo object with a length of 0 !
23970 (Binary::ResolveOperator): Flag error if overload resolution fails to find
23971 an applicable member - according to the spec :-)
23972 Also fix logic to find members in base types.
23974 (Unary::ResolveOperator): Same here.
23976 (Unary::report23): Change name to error23 and make first argument a TypeContainer
23977 as I was getting thoroughly confused between this and error19 :-)
23979 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
23980 (::FindMostEncompassedType): Implement.
23981 (::FindMostEncompassingType): Implement.
23982 (::StandardConversionExists): Implement.
23984 (UserImplicitCast): Re-vamp. We now need info about most specific
23985 source and target types so that we can do the necessary conversions.
23987 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
23988 mathematical union with no duplicates.
23990 2001-10-03 Miguel de Icaza <miguel@ximian.com>
23992 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
23993 in order from base classes to child classes, so that we can in
23994 child classes look up in our parent for method names and
23995 attributes (required for handling abstract, virtual, new, override
23996 constructs: we need to instrospect our base class, and if we dont
23997 populate the classes in order, the introspection might be
23998 incorrect. For example, a method could query its parent before
23999 the parent has any methods and would determine that the parent has
24000 no abstract methods (while it could have had them)).
24002 (RootContext::CreateType): Record the order in which we define the
24005 2001-10-02 Miguel de Icaza <miguel@ximian.com>
24007 * class.cs (TypeContainer::Populate): Also method definitions can
24008 fail now, keep track of this.
24010 (TypeContainer::FindMembers): Implement support for
24011 DeclaredOnly/noDeclaredOnly flag.
24013 (Constructor::Emit) Return the ConstructorBuilder.
24015 (Method::Emit) Return the MethodBuilder.
24016 Check for abstract or virtual methods to be public.
24018 * rootcontext.cs (RootContext::CreateType): Register all the
24019 abstract methods required for the class to be complete and the
24020 interface methods that must be implemented.
24022 * cs-parser.jay: Report error 501 (method requires body if it is
24023 not marked abstract or extern).
24025 * expression.cs (TypeOf::Emit): Implement.
24027 * typemanager.cs: runtime_handle_type, new global type.
24029 * class.cs (Property::Emit): Generate code for properties.
24031 2001-10-02 Ravi Pratap <ravi@ximian.com>
24033 * expression.cs (Unary::ResolveOperator): Find operators on base type
24034 too - we now conform exactly to the spec.
24036 (Binary::ResolveOperator): Same here.
24038 * class.cs (Operator::Define): Fix minor quirk in the tests.
24040 * ../errors/cs0215.cs : Added.
24042 * ../errors/cs0556.cs : Added.
24044 * ../errors/cs0555.cs : Added.
24046 2001-10-01 Miguel de Icaza <miguel@ximian.com>
24048 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
24049 single integer which is really efficient
24051 2001-10-01 Ravi Pratap <ravi@ximian.com>
24053 * expression.cs (Expression::ImplicitUserConversion): Use location
24054 even in the case when we are examining True operators.
24056 * class.cs (Operator::Define): Perform extensive checks to conform
24057 with the rules for operator overloading in the spec.
24059 * expression.cs (Expression::ImplicitReferenceConversion): Implement
24060 some of the other conversions mentioned in the spec.
24062 * typemanager.cs (array_type): New static member for the System.Array built-in
24065 (cloneable_interface): For System.ICloneable interface.
24067 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
24068 we start resolving the tree and populating types.
24070 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
24072 2001-10-01 Miguel de Icaza <miguel@ximian.com>
24074 * expression.cs (Expression::ExprClassFromMemberInfo,
24075 Expression::Literalize): Create literal expressions from
24076 FieldInfos which are literals.
24078 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
24079 type casts, because they were wrong. The test suite in tests
24082 (ImplicitNumericConversion): ushort to ulong requires a widening
24085 Int32 constant to long requires widening cast as well.
24087 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
24088 for integers because the type on the stack is not i4.
24090 2001-09-30 Miguel de Icaza <miguel@ximian.com>
24092 * expression.cs (report118): require location argument.
24094 * parameter.cs: Do not dereference potential null value.
24096 * class.cs: Catch methods that lack the `new' keyword when
24097 overriding a name. Report warnings when `new' is used without
24098 anything being there to override.
24100 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
24102 * class.cs: Only add constructor to hashtable if it is non-null
24103 (as now constructors can fail on define).
24105 (TypeManager, Class, Struct): Take location arguments.
24107 Catch field instance initialization in structs as errors.
24109 accepting_filter: a new filter for FindMembers that is static so
24110 that we dont create an instance per invocation.
24112 (Constructor::Define): Catch errors where a struct constructor is
24115 * cs-parser.jay: Pass location information for various new
24118 * delegate.cs (Delegate): take a location argument.
24120 * driver.cs: Do not call EmitCode if there were problesm in the
24121 Definition of the types, as many Builders wont be there.
24123 * decl.cs (Decl::Decl): Require a location argument.
24125 * cs-tokenizer.cs: Handle properly hex constants that can not fit
24126 into integers, and find the most appropiate integer for it.
24128 * literal.cs: Implement ULongLiteral.
24130 * rootcontext.cs: Provide better information about the location of
24131 failure when CreateType fails.
24133 2001-09-29 Miguel de Icaza <miguel@ximian.com>
24135 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
24138 * expression.cs (Binary::CheckShiftArguments): Add missing type
24140 (Binary::ResolveOperator): Add type to the logical and and logical
24141 or, Bitwise And/Or and Exclusive Or code paths, it was missing
24144 (Binary::DoNumericPromotions): In the case where either argument
24145 is ulong (and most signed types combined with ulong cause an
24146 error) perform implicit integer constant conversions as well.
24148 2001-09-28 Miguel de Icaza <miguel@ximian.com>
24150 * expression.cs (UserImplicitCast): Method should always be
24152 (Invocation::BetterConversion): Simplified test for IntLiteral.
24154 (Expression::ImplicitNumericConversion): Split this routine out.
24155 Put the code that performs implicit constant integer conversions
24158 (Expression::Resolve): Become a wrapper around DoResolve so we can
24159 check eclass and type being set after resolve.
24161 (Invocation::Badness): Remove this dead function
24163 (Binary::ResolveOperator): Do not compute the expensive argumnets
24164 unless we have a union for it.
24166 (Probe::Emit): Is needs to do an isinst and then
24167 compare against null.
24169 (::CanConvert): Added Location argument. If the Location argument
24170 is null (Location.Null), then we do not report errors. This is
24171 used by the `probe' mechanism of the Explicit conversion. We do
24172 not want to generate an error for something that the user
24173 explicitly requested to be casted. But the pipeline for an
24174 explicit cast first tests for potential implicit casts.
24176 So for now, if the Location is null, it means `Probe only' to
24177 avoid adding another argument. Might have to revise this
24180 (ClassCast): New class used to type cast objects into arbitrary
24181 classes (used in Explicit Reference Conversions).
24183 Implement `as' as well.
24185 Reverted all the patches from Ravi below: they were broken:
24187 * The use of `level' as a mechanism to stop recursive
24188 invocations is wrong. That was there just to catch the
24189 bug with a strack trace but not as a way of addressing
24192 To fix the problem we have to *understand* what is going
24193 on and the interactions and come up with a plan, not
24194 just get things going.
24196 * The use of the type conversion cache that I proposed
24197 last night had an open topic: How does this work across
24198 protection domains. A user defined conversion might not
24199 be public in the location where we are applying the
24200 conversion, a different conversion might be selected
24201 (ie, private A->B (better) but public B->A (worse),
24202 inside A, A->B applies, but outside it, B->A will
24205 * On top of that (ie, even if the above is solved),
24206 conversions in a cache need to be abstract. Ie, `To
24207 convert from an Int to a Short use an OpcodeCast', not
24208 `To convert from an Int to a Short use the OpcodeCast on
24209 the variable 5' (which is what this patch was doing).
24211 2001-09-28 Ravi Pratap <ravi@ximian.com>
24213 * expression.cs (Invocation::ConversionExists): Re-write to use
24214 the conversion cache
24216 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
24217 cache all conversions done, not just user-defined ones.
24219 (Invocation::BetterConversion): The real culprit. Use ConversionExists
24220 to determine if a conversion exists instead of acutually trying to
24221 perform the conversion. It's faster too.
24223 (Expression::ConvertExplicit): Modify to use ConversionExists to check
24224 and only then attempt the implicit conversion.
24226 2001-09-28 Ravi Pratap <ravi@ximian.com>
24228 * expression.cs (ConvertImplicit): Use a cache for conversions
24229 already found. Check level of recursion and bail out if necessary.
24231 2001-09-28 Miguel de Icaza <miguel@ximian.com>
24233 * typemanager.cs (string_concat_string_string, string_concat_object_object):
24234 Export standard methods that we expect for string operations.
24236 * statement.cs (Block::UsageWarning): Track usage of variables and
24237 report the errors for not used variables.
24239 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
24242 2001-09-27 Miguel de Icaza <miguel@ximian.com>
24244 * codegen.cs: remove unnneded code
24246 * expression.cs: Removed BuiltinTypeAccess class
24248 Fix the order in which implicit conversions are
24251 The previous fixed dropped support for boxed conversions (adding a
24252 test to the test suite now)
24254 (UserImplicitCast::CanConvert): Remove test for source being null,
24255 that code is broken. We should not feed a null to begin with, if
24256 we do, then we should track the bug where the problem originates
24257 and not try to cover it up here.
24259 Return a resolved expression of type UserImplicitCast on success
24260 rather than true/false. Ravi: this is what I was talking about,
24261 the pattern is to use a static method as a "constructor" for
24264 Also, do not create arguments until the very last minute,
24265 otherwise we always create the arguments even for lookups that
24266 will never be performed.
24268 (UserImplicitCast::Resolve): Eliminate, objects of type
24269 UserImplicitCast are born in a fully resolved state.
24271 * typemanager.cs (InitCoreTypes): Init also value_type
24272 (System.ValueType).
24274 * expression.cs (Cast::Resolve): First resolve the child expression.
24276 (LValue): Add new method AddressOf to be used by
24279 Change the argument of Store to take an EmitContext instead of an
24280 ILGenerator, because things like FieldExpr need to be able to call
24281 their children expression to generate the instance code.
24283 (Expression::Error, Expression::Warning): Sugar functions for
24286 (Expression::MemberLookup): Accept a TypeContainer instead of a
24287 Report as the first argument.
24289 (Expression::ResolvePrimary): Killed. I still want to improve
24290 this as currently the code is just not right.
24292 (Expression::ResolveMemberAccess): Simplify, but it is still
24295 (Unary::Resolve): Catch errors in AddressOf operators.
24297 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
24298 index to a byte for the short-version, or the compiler will choose
24299 the wrong Emit call, which generates the wrong data.
24301 (ParameterReference::Emit, ::Store): same.
24303 (FieldExpr::AddressOf): Implement.
24305 * typemanager.cs: TypeManager: made public variable instead of
24308 * driver.cs: document --fatal.
24310 * report.cs (ErrorMessage, WarningMessage): new names for the old
24311 Error and Warning classes.
24313 * cs-parser.jay (member_access): Turn built-in access to types
24314 into a normal simplename
24316 2001-09-27 Ravi Pratap <ravi@ximian.com>
24318 * expression.cs (Invocation::BetterConversion): Fix to cope
24319 with q being null, since this was introducing a bug.
24321 * expression.cs (ConvertImplicit): Do built-in conversions first.
24323 2001-09-27 Ravi Pratap <ravi@ximian.com>
24325 * expression.cs (UserImplicitCast::Resolve): Fix bug.
24327 2001-09-27 Ravi Pratap <ravi@ximian.com>
24329 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
24330 I had introduced long ago (what's new ?).
24332 * expression.cs (UserImplicitCast::CanConvert): Static method to do
24333 the work of all the checking.
24334 (ConvertImplicit): Call CanConvert and only then create object if necessary.
24335 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
24337 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
24338 that is the right way.
24340 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
24341 overloading resolution. Use everywhere instead of cutting and pasting code.
24343 (Binary::ResolveOperator): Use MakeUnionSet.
24345 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
24346 we have to convert to bool types. Not complete yet.
24348 2001-09-27 Miguel de Icaza <miguel@ximian.com>
24350 * typemanager.cs (TypeManager::CSharpName): support ushort.
24352 * expression.cs (Expression::TryImplicitIntConversion): Attempts
24353 to provide an expression that performsn an implicit constant int
24354 conversion (section 6.1.6).
24355 (Expression::ConvertImplicitRequired): Reworked to include
24356 implicit constant expression conversions.
24358 (Expression::ConvertNumericExplicit): Finished.
24360 (Invocation::Emit): If InstanceExpression is null, then it means
24361 that we perform a call on this.
24363 2001-09-26 Miguel de Icaza <miguel@ximian.com>
24365 * expression.cs (Unary::Emit): Remove some dead code.
24366 (Probe): Implement Resolve and Emit for `is'.
24367 (Expression::ConvertImplicitRequired): Attempt to do constant
24368 expression conversions here. Maybe should be moved to
24369 ConvertImplicit, but I am not sure.
24370 (Expression::ImplicitLongConstantConversionPossible,
24371 Expression::ImplicitIntConstantConversionPossible): New functions
24372 that tell whether is it possible to apply an implicit constant
24373 expression conversion.
24375 (ConvertNumericExplicit): Started work on explicit numeric
24378 * cs-parser.jay: Update operator constants.
24380 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
24381 (Parameters::GetSignature): Hook up VerifyArgs here.
24382 (Parameters::VerifyArgs): Verifies that no two arguments have the
24385 * class.cs (Operator): Update the operator names to reflect the
24386 ones that the spec expects (as we are just stringizing the
24389 * expression.cs (Unary::ResolveOperator): Fix bug: Use
24390 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
24391 previous usage did only work for our methods.
24392 (Expression::ConvertImplicit): Handle decimal implicit numeric
24393 conversions as well.
24394 (Expression::InternalTypeConstructor): Used to invoke constructors
24395 on internal types for default promotions.
24397 (Unary::Emit): Implement special handling for the pre/post
24398 increment/decrement for overloaded operators, as they need to have
24399 the same semantics as the other operators.
24401 (Binary::ResolveOperator): ditto.
24402 (Invocation::ConversionExists): ditto.
24403 (UserImplicitCast::Resolve): ditto.
24405 2001-09-26 Ravi Pratap <ravi@ximian.com>
24407 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
24408 operator, return after emitting body. Regression tests pass again !
24410 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
24411 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
24412 (Invocation::OverloadResolve): Ditto.
24413 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
24415 * everywhere : update calls to the above methods accordingly.
24417 2001-09-26 Miguel de Icaza <miguel@ximian.com>
24419 * assign.cs (Assign): Make it inherit from ExpressionStatement.
24421 * expression.cs (ExpressionStatement): New base class used for
24422 expressions that can appear in statements, so that we can provide
24423 an alternate path to generate expression that do not leave a value
24426 (Expression::Emit, and all the derivatives): We no longer return
24427 whether a value is left on the stack or not. Every expression
24428 after being emitted leaves a single value on the stack.
24430 * codegen.cs (EmitContext::EmitStatementExpression): Use the
24431 facilties of ExpressionStatement if possible.
24433 * cs-parser.jay: Update statement_expression.
24435 2001-09-25 Miguel de Icaza <miguel@ximian.com>
24437 * driver.cs: Change the wording of message
24439 2001-09-25 Ravi Pratap <ravi@ximian.com>
24441 * expression.cs (Binary::ResolveOperator): Had forgottten to set
24442 the type of the expression to the return type of the method if
24443 we have an overloaded operator match ! The regression tests pass again !
24444 (Unary::ResolveOperator): Ditto.
24446 * expression.cs (Invocation::ConversionExists): Correct the member lookup
24447 to find "op_Implicit", not "implicit" ;-)
24448 (UserImplicitCast): New class to take care of user-defined implicit conversions.
24449 (ConvertImplicit, ForceConversion): Take TypeContainer argument
24451 * everywhere : Correct calls to the above accordingly.
24453 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
24454 (ConvertImplicit): Do user-defined conversion if it exists.
24456 2001-09-24 Miguel de Icaza <miguel@ximian.com>
24458 * assign.cs: track location.
24459 (Resolve): Use implicit conversions on assignment.
24461 * literal.cs: Oops. Not good, Emit of short access values should
24462 pass (Bytes) or the wrong argument will be selected.
24464 * expression.cs (Unary::Emit): Emit code for -expr.
24466 (Unary::ResolveOperator): Handle `Substract' for non-constants
24467 (substract from zero from the non-constants).
24468 Deal with Doubles as well.
24470 (Expression::ConvertImplicitRequired): New routine that reports an
24471 error if no implicit conversion exists.
24473 (Invocation::OverloadResolve): Store the converted implicit
24474 expressions if we make them
24476 2001-09-24 Ravi Pratap <ravi@ximian.com>
24478 * class.cs (ConstructorInitializer): Take a Location argument.
24479 (ConstructorBaseInitializer): Same here.
24480 (ConstructorThisInitializer): Same here.
24482 * cs-parser.jay : Update all calls accordingly.
24484 * expression.cs (Unary, Binary, New): Take location argument.
24485 Update accordingly everywhere.
24487 * cs-parser.jay : Update all calls to the above to take a location
24490 * class.cs : Ditto.
24492 2001-09-24 Ravi Pratap <ravi@ximian.com>
24494 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
24495 (Invocation::BetterConversion): Same here
24496 (Invocation::ConversionExists): Ditto.
24498 (Invocation::ConversionExists): Implement.
24500 2001-09-22 Ravi Pratap <ravi@ximian.com>
24502 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
24503 Also take an additional TypeContainer argument.
24505 * All over : Pass in TypeContainer as argument to OverloadResolve.
24507 * typemanager.cs (CSharpName): Update to check for the string type and return
24510 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
24513 2001-09-21 Ravi Pratap <ravi@ximian.com>
24515 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
24516 (Invocation::BetterFunction): Implement.
24517 (Invocation::BetterConversion): Implement.
24518 (Invocation::ConversionExists): Skeleton, no implementation yet.
24520 Okay, things work fine !
24522 2001-09-21 Miguel de Icaza <miguel@ximian.com>
24524 * typemanager.cs: declare and load enum_type, delegate_type and
24527 * expression.cs (Expression::Emit): Now emit returns a value that
24528 tells whether a value is left on the stack or not. This strategy
24529 might be reveted tomorrow with a mechanism that would address
24530 multiple assignments.
24531 (Expression::report118): Utility routine to report mismatches on
24534 (Unary::Report23): Report impossible type/operator combination
24537 (Unary::IsIncrementableNumber): Whether the type can be
24538 incremented or decremented with add.
24539 (Unary::ResolveOperator): Also allow enumerations to be bitwise
24541 (Unary::ResolveOperator): Implement ++, !, ~,
24543 (Invocation::Emit): Deal with new Emit convetion.
24545 * All Expression derivatives: Updated their Emit method to return
24546 whether they leave values on the stack or not.
24548 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
24549 stack for expressions that are statements.
24551 2001-09-20 Miguel de Icaza <miguel@ximian.com>
24553 * expression.cs (LValue): New interface. Must be implemented by
24555 (LocalVariableReference, ParameterReference, FieldExpr): Implement
24558 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
24559 interface for generating code, simplifies the code.
24561 2001-09-20 Ravi Pratap <ravi@ximian.com>
24563 * expression.cs (everywhere): Comment out return statements in ::Resolve
24564 methods to avoid the warnings.
24566 2001-09-20 Miguel de Icaza <miguel@ximian.com>
24568 * driver.cs (parse): Report error 2001 if we can not open the
24571 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
24574 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
24577 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
24578 otherwise nested blocks end up with the same index.
24580 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
24582 * expression.cs: Instead of having FIXMEs in the Resolve
24583 functions, throw exceptions so it is obvious that we are facing a
24586 * cs-parser.jay (invocation_expression): Pass Location information.
24588 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
24589 Use a basename for those routines because .NET does not like paths
24592 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
24595 2001-09-19 Miguel de Icaza <miguel@ximian.com>
24597 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
24598 are loading the correct data types (throws an exception if not).
24599 (TypeManager::InitCoreTypes): Use CoreLookupType
24601 * expression.cs (Unary::ResolveOperator): return the child
24602 expression for expressions which are just +expr.
24603 (Unary::ResolveOperator): Return negative literals for -LITERAL
24604 expressions (otherwise they are Unary {Literal}).
24605 (Invocation::Badness): Take into account `Implicit constant
24606 expression conversions'.
24608 * literal.cs (LongLiteral): Implement long literal class.
24609 (IntLiteral): export the `Value' of the intliteral.
24611 2001-09-19 Ravi Pratap <ravi@ximian.com>
24613 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
24615 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
24616 instead of 'Operator'
24618 * expression.cs (Binary::ResolveOperator): Update accordingly.
24619 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
24622 * cs-parser.jay (unary_expression): Update to use the new names.
24624 * gen-treedump.cs (GetUnary): Same here.
24626 * expression.cs (Unary::Resolve): Implement.
24627 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
24628 operators are found instead of making noise ;-)
24629 (Unary::ResolveOperator): New method to do precisely the same thing which
24630 Binary::ResolveOperator does for Binary expressions.
24631 (Unary.method, .Arguments): Add.
24632 (Unary::OperName): Implement.
24633 (Unary::ForceConversion): Copy and Paste !
24635 * class.cs (Operator::Define): Fix a small bug for the case when we have
24638 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
24639 for the inbuilt operators. Only overloading works for now ;-)
24641 2001-09-18 Miguel de Icaza <miguel@ximian.com>
24643 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
24644 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
24646 * expression.cs (This::Emit): Implement.
24647 (This::Resolve): Implement.
24648 (TypeOf:Resolve): Implement.
24649 (Expression::ResolveSimpleName): Add an implicit this to instance
24651 (MemberAccess::Resolve): Deal with Parameters and Fields.
24652 Bind instance variable to Field expressions.
24653 (FieldExpr::Instance): New field used to track the expression that
24654 represents the object instance.
24655 (FieldExpr::Resolve): Track potential errors from MemberLookup not
24657 (FieldExpr::Emit): Implement.
24659 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
24660 the last instruction contains a return opcode to avoid generating
24661 the last `ret' instruction (this generates correct code, and it is
24662 nice to pass the peverify output).
24664 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
24665 initializer for static and instance variables.
24666 (Constructor::Emit): Allow initializer to be null in the case of
24667 static constructors. Only emit initializer for instance
24670 (TypeContainer::FindMembers): Return a null array if there are no
24673 Also fix the code for the MemberTypes.Method branch, as it was not
24674 scanning that for operators (or tried to access null variables before).
24676 * assign.cs (Assign::Emit): Handle instance and static fields.
24680 * driver.cs: Stop compilation if there are parse errors.
24682 * cs-parser.jay (constructor_declaration): Provide default base
24683 initializer for non-static constructors.
24684 (constructor_declarator): Do not provide a default base
24685 initializers if none was specified.
24686 Catch the fact that constructors should not have parameters.
24688 * class.cs: Do not emit parent class initializers for static
24689 constructors, that should be flagged as an error.
24691 2001-09-18 Ravi Pratap <ravi@ximian.com>
24693 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
24694 Move back code into TypeContainer::Populate.
24696 2001-09-18 Ravi Pratap <ravi@ximian.com>
24698 * class.cs (TypeContainer::AddConstructor): Fix the check to
24699 compare against Name, not Basename.
24700 (Operator::OpType): Change Plus and Minus to Add and Subtract.
24702 * cs-parser.jay : Update accordingly.
24704 * class.cs (TypeContainer::FindMembers): For the case where we are searching
24705 for methods, don't forget to look into the operators too.
24706 (RegisterMethodBuilder): Helper method to take care of this for
24707 methods, constructors and operators.
24708 (Operator::Define): Completely revamp.
24709 (Operator.OperatorMethod, MethodName): New fields.
24710 (TypeContainer::Populate): Move the registering of builders into
24711 RegisterMethodBuilder.
24712 (Operator::Emit): Re-write.
24714 * expression.cs (Binary::Emit): Comment out code path to emit method
24715 invocation stuff for the case when we have a user defined operator. I am
24716 just not able to get it right !
24718 2001-09-17 Miguel de Icaza <miguel@ximian.com>
24720 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
24723 (Expression::MemberLookup): Provide a version that allows to
24724 specify the MemberTypes and BindingFlags.
24726 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
24727 so it was not fetching variable information from outer blocks.
24729 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
24730 Beforefieldinit as it was buggy.
24732 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
24733 that Ravi put here.
24735 * class.cs (Constructor::Emit): Only emit if block is not null.
24736 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
24737 deal with this by semantically definining it as if the user had
24740 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
24741 constructors as we now "emit" them at a higher level.
24743 (TypeContainer::DefineDefaultConstructor): Used to define the
24744 default constructors if none was provided.
24746 (ConstructorInitializer): Add methods Resolve and Emit.
24748 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
24750 2001-09-17 Ravi Pratap <ravi@ximian.com>
24752 * class.cs (TypeContainer::EmitDefaultConstructor): Register
24753 the default constructor builder with our hashtable for methodbuilders
24756 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
24757 and argument_count is 0 in which case we have a match.
24758 (Binary::ResolveOperator): More null checking and miscellaneous coding
24761 2001-09-17 Ravi Pratap <ravi@ximian.com>
24763 * rootcontext.cs (IsNameSpace): Compare against null.
24765 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
24767 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
24768 and Unary::Operator.
24770 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
24773 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
24774 we have overloaded operators.
24775 (Binary::ResolveOperator): Implement the part which does the operator overload
24778 * class.cs (Operator::Emit): Implement.
24779 (TypeContainer::Emit): Emit the operators we have too.
24781 * expression.cs (Binary::Emit): Update to emit the appropriate code for
24782 the case when we have a user-defined operator.
24784 2001-09-17 Miguel de Icaza <miguel@ximian.com>
24786 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
24788 2001-09-16 Ravi Pratap <ravi@ximian.com>
24790 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
24791 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
24792 (Constructor::Emit): Implement.
24793 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
24794 if we have no work to do.
24795 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
24798 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
24799 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
24801 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
24804 2001-09-15 Ravi Pratap <ravi@ximian.com>
24806 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
24808 (Tree::RecordNamespace): Method to do what the name says ;-)
24809 (Tree::Namespaces): Property to get at the namespaces hashtable.
24811 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
24814 * rootcontext.cs (IsNamespace): Fixed it :-)
24816 2001-09-14 Miguel de Icaza <miguel@ximian.com>
24818 * class.cs (TypeContainer::FindMembers): Add support for
24820 (MethodCore): New class that encapsulates both the shared aspects
24821 of a Constructor and a Method.
24822 (Method, Constructor): Factored pieces into MethodCore.
24824 * driver.cs: Added --fatal which makes errors throw exceptions.
24825 Load System assembly as well as part of the standard library.
24827 * report.cs: Allow throwing exceptions on errors for debugging.
24829 * modifiers.cs: Do not use `parent', instead use the real type
24830 container to evaluate permission settings.
24832 * class.cs: Put Ravi's patch back in. He is right, and we will
24833 have to cope with the
24835 2001-09-14 Ravi Pratap <ravi@ximian.com>
24837 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
24838 FamORAssem, not FamANDAssem.
24840 2001-09-14 Miguel de Icaza <miguel@ximian.com>
24842 * driver.cs: Added --parse option that only parses its input files
24845 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
24846 incorrect. IsTopLevel is not used to tell whether an object is
24847 root_types or not (that can be achieved by testing this ==
24848 root_types). But to see if this is a top-level *class* (not
24849 necessarly our "toplevel" container).
24851 2001-09-14 Ravi Pratap <ravi@ximian.com>
24853 * enum.cs (Enum::Define): Modify to call the Lookup method on the
24854 parent instead of a direct call to GetType.
24856 2001-09-14 Ravi Pratap <ravi@ximian.com>
24858 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
24859 Modifiers.TypeAttr. This should just be a call to that method.
24861 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
24862 object so that we can determine if we are top-level or not.
24864 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
24867 * enum.cs (Enum::Define): Ditto.
24869 * modifiers.cs (FieldAttr): Re-write.
24871 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
24872 (TypeContainer::HaveStaticConstructor): New property to provide access
24873 to precisely that info.
24875 * modifiers.cs (MethodAttr): Re-write.
24876 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
24878 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
24879 of top-level types as claimed.
24881 2001-09-13 Miguel de Icaza <miguel@ximian.com>
24883 * expression.cs (MemberLookup): Fruitless attempt to lookup
24884 constructors. Maybe I need to emit default constructors? That
24885 might be it (currently .NET emits this for me automatically).
24886 (Invocation::OverloadResolve): Cope with Arguments == null.
24887 (Invocation::EmitArguments): new function, shared by the new
24888 constructor and us.
24889 (Invocation::Emit): Handle static and instance methods. Emit
24890 proper call instruction for virtual or non-virtual invocations.
24891 (New::Emit): Implement.
24892 (New::Resolve): Implement.
24893 (MemberAccess:Resolve): Implement.
24894 (MethodGroupExpr::InstanceExpression): used conforming to the spec
24895 to track instances.
24896 (FieldExpr::Resolve): Set type.
24898 * support.cs: Handle empty arguments.
24900 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
24901 SimpleLookup): Auxiliary routines to help parse a qualifier
24904 Update qualifier_identifier rule.
24906 * codegen.cs: Removed debugging messages.
24908 * class.cs: Make this a global thing, this acts just as a "key" to
24909 objects that we might have around.
24911 (Populate): Only initialize method_builders_to_methods once.
24913 * expression.cs (PropertyExpr): Initialize type from the
24916 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
24917 Resolve pattern. Attempt to implicitly convert value to boolean.
24920 * expression.cs: Set the type for the int32/int32 argument case.
24921 (Binary::ResolveOperator): Set the return type to boolean for
24922 comparission operators
24924 * typemanager.cs: Remove debugging print code.
24926 (Invocation::Resolve): resolve type.
24928 * class.cs: Allocate a MemberInfo of the correct size, as the code
24929 elsewhere depends on the test to reflect the correct contents.
24931 (Method::) Keep track of parameters, due to System.Reflection holes
24933 (TypeContainer::Populate): Keep track of MethodBuilders to Method
24936 (TypeContainer::FindMembers): Use ArrayList and then copy an array
24937 of the exact size and return that.
24939 (Class::LookupMethodByBuilder): New function that maps
24940 MethodBuilders to its methods. Required to locate the information
24941 on methods because System.Reflection bit us again.
24943 * support.cs: New file, contains an interface ParameterData and
24944 two implementations: ReflectionParameters and InternalParameters
24945 used to access Parameter information. We will need to grow this
24948 * expression.cs (Invocation::GetParameterData): implement a cache
24949 and a wrapper around the ParameterData creation for methods.
24950 (Invocation::OverloadResolve): Use new code.
24952 2001-09-13 Ravi Pratap <ravi@ximian.com>
24954 * class.cs (TypeContainer::EmitField): Remove and move into
24955 (Field::Define): here and modify accordingly.
24956 (Field.FieldBuilder): New member.
24957 (TypeContainer::Populate): Update accordingly.
24958 (TypeContainer::FindMembers): Implement.
24960 2001-09-13 Miguel de Icaza <miguel@ximian.com>
24962 * statement.cs: (VariableInfo::VariableType): New field to be
24963 initialized with the full type once it is resolved.
24965 2001-09-12 Miguel de Icaza <miguel@ximian.com>
24967 * parameter.cs (GetParameterInfo): Use a type cache to compute
24968 things only once, and to reuse this information
24970 * expression.cs (LocalVariableReference::Emit): Implement.
24971 (OpcodeCast::Emit): fix.
24973 (ParameterReference::Resolve): Implement.
24974 (ParameterReference::Emit): Implement.
24976 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
24977 that are expressions need to stay as Expressions.
24979 * typemanager.cs (CSharpName): Returns the C# name of a type if
24982 * expression.cs (Expression::ConvertImplicit): New function that
24983 implements implicit type conversions.
24985 (Expression::ImplicitReferenceConversion): Implements implicit
24986 reference conversions.
24988 (EmptyCast): New type for transparent casts.
24990 (OpcodeCast): New type for casts of types that are performed with
24991 a sequence of bytecodes.
24993 (BoxedCast): New type used for casting value types into reference
24994 types. Emits a box opcode.
24996 (Binary::DoNumericPromotions): Implements numeric promotions of
24997 and computation of the Binary::Type.
24999 (Binary::EmitBranchable): Optimization.
25001 (Binary::Emit): Implement code emission for expressions.
25003 * typemanager.cs (TypeManager): Added two new core types: sbyte
25006 2001-09-12 Ravi Pratap <ravi@ximian.com>
25008 * class.cs (TypeContainer::FindMembers): Method which does exactly
25009 what Type.FindMembers does, only we don't have to use reflection. No
25010 implementation yet.
25012 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
25013 typecontainer objects as we need to get at them.
25014 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
25016 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
25017 typecontainer object.
25019 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
25020 of just a Report object.
25022 2001-09-11 Ravi Pratap <ravi@ximian.com>
25024 * class.cs (Event::Define): Go back to using the prefixes "add_" and
25026 (TypeContainer::Populate): Now define the delegates of the type too.
25027 (TypeContainer.Delegates): Property to access the list of delegates defined
25030 * delegates.cs (Delegate::Define): Implement partially.
25032 * modifiers.cs (TypeAttr): Handle more flags.
25034 2001-09-11 Ravi Pratap <ravi@ximian.com>
25036 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
25038 (Operator::Define): Re-write logic to get types by using the LookupType method
25039 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
25040 (Indexer::Define): Ditto.
25041 (Event::Define): Ditto.
25042 (Property::Define): Ditto.
25044 2001-09-10 Ravi Pratap <ravi@ximian.com>
25046 * class.cs (TypeContainer::Populate): Now define operators too.
25047 (TypeContainer.Operators): New property to access the list of operators
25049 (Operator.OperatorMethodBuilder): New member to hold the method builder
25050 for the operator we are defining.
25051 (Operator::Define): Implement.
25053 2001-09-10 Ravi Pratap <ravi@ximian.com>
25055 * class.cs (Event::Define): Make the prefixes of the accessor methods
25056 addOn_ and removeOn_
25058 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
25059 of the location being passed in too. Ideally, this should go later since all
25060 error reporting should be done through the Report object.
25062 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
25063 (Populate): Iterate thru the indexers we have and define them too.
25064 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
25065 for the get and set accessors.
25066 (Indexer::Define): Implement.
25068 2001-09-09 Miguel de Icaza <miguel@ximian.com>
25070 * expression.cs (Binary::Resolve): Beginning of it. I scratched
25071 my previous implementation, did not work.
25073 * typemanager.cs: Add a couple of missing types (the longs).
25075 * literal.cs: Use TypeManager.bool_type instead of getting it.
25077 * expression.cs (EventExpr): New kind of expressions.
25078 (Expressio::ExprClassFromMemberInfo): finish
25080 2001-09-08 Miguel de Icaza <miguel@ximian.com>
25082 * assign.cs: Emit stores to static fields differently.
25084 2001-09-08 Ravi Pratap <ravi@ximian.com>
25086 * Merge in changes and adjust code to tackle conflicts. Backed out my
25087 code in Assign::Resolve ;-)
25089 2001-09-08 Ravi Pratap <ravi@ximian.com>
25091 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
25092 instead Report.Error and also pass in the location.
25093 (CSharpParser::Lexer): New readonly property to return the reference
25094 to the Tokenizer object.
25095 (declare_local_variables): Use Report.Error with location instead of plain
25099 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
25100 (Operator.CheckBinaryOperator): Ditto.
25102 * cs-parser.jay (operator_declarator): Update accordingly.
25104 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
25105 (CheckBinaryOperator): Same here.
25107 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
25108 on the name without any prefixes of namespace names etc. This is because we
25109 already might have something already fully qualified like
25110 'System.Console.WriteLine'
25112 * assign.cs (Resolve): Begin implementation. Stuck ;-)
25114 2001-09-07 Ravi Pratap <ravi@ximian.com>
25116 * cs-tokenizer.cs (location): Return a string which also contains
25119 * expression.cs (ElementAccess): New class for expressions of the
25120 type 'element access.'
25121 (BaseAccess): New class for expressions of the type 'base access.'
25122 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
25125 * cs-parser.jay (element_access): Implement action.
25126 (base_access): Implement actions.
25127 (checked_expression, unchecked_expression): Implement.
25129 * cs-parser.jay (local_variable_type): Correct and implement.
25130 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
25132 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
25134 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
25135 name and the specifiers.
25137 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
25139 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
25140 making them all public ;-)
25142 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
25145 2001-09-07 Miguel de Icaza <miguel@ximian.com>
25147 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
25149 (FieldExpr, PropertyExprs): New resolved expressions.
25150 (SimpleName::MemberStaticCheck): Perform static checks for access
25151 to non-static fields on static methods. Maybe this should be
25152 generalized for MemberAccesses.
25153 (SimpleName::ResolveSimpleName): More work on simple name
25156 * cs-parser.jay (primary_expression/qualified_identifier): track
25157 the parameter index.
25159 * codegen.cs (CodeGen::Save): Catch save exception, report error.
25160 (EmitContext::EmitBoolExpression): Chain to expression generation
25161 instead of temporary hack.
25162 (::EmitStatementExpression): Put generic expression code generation.
25164 * assign.cs (Assign::Emit): Implement variable assignments to
25165 local variables, parameters and fields.
25167 2001-09-06 Miguel de Icaza <miguel@ximian.com>
25169 * statement.cs (Block::GetVariableInfo): New method, returns the
25170 VariableInfo for a variable name in a block.
25171 (Block::GetVariableType): Implement in terms of GetVariableInfo
25173 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
25174 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
25176 2001-09-06 Ravi Pratap <ravi@ximian.com>
25178 * cs-parser.jay (operator_declaration): Continue on my quest : update
25179 to take attributes argument.
25180 (event_declaration): Ditto.
25181 (enum_declaration): Ditto.
25182 (indexer_declaration): Ditto.
25184 * class.cs (Operator::Operator): Update constructor accordingly.
25185 (Event::Event): Ditto.
25187 * delegate.cs (Delegate::Delegate): Same here.
25189 * enum.cs (Enum::Enum): Same here.
25191 2001-09-05 Ravi Pratap <ravi@ximian.com>
25193 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
25195 * ../tests/cs0658.cs : New file to demonstrate error 0658.
25197 * attribute.cs (Attributes): New class to encapsulate all attributes which were
25198 being passed around as an arraylist.
25199 (Attributes::AddAttribute): Method to add attribute sections.
25201 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
25202 (struct_declaration): Update accordingly.
25203 (constant_declaration): Update.
25204 (field_declaration): Update.
25205 (method_header): Update.
25206 (fixed_parameter): Update.
25207 (parameter_array): Ditto.
25208 (property_declaration): Ditto.
25209 (destructor_declaration): Ditto.
25211 * class.cs (Struct::Struct): Update constructors accordingly.
25212 (Class::Class): Ditto.
25213 (Field::Field): Ditto.
25214 (Method::Method): Ditto.
25215 (Property::Property): Ditto.
25216 (TypeContainer::OptAttribute): update property's return type.
25218 * interface.cs (Interface.opt_attributes): New member.
25219 (Interface::Interface): Update to take the extra Attributes argument.
25221 * parameter.cs (Parameter::Parameter): Ditto.
25223 * constant.cs (Constant::Constant): Ditto.
25225 * interface.cs (InterfaceMemberBase): New OptAttributes field.
25226 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
25227 the attributes as a parameter.
25228 (InterfaceProperty): Update constructor call.
25229 (InterfaceEvent): Ditto.
25230 (InterfaceMethod): Ditto.
25231 (InterfaceIndexer): Ditto.
25233 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
25234 pass the attributes too.
25235 (interface_event_declaration): Ditto.
25236 (interface_property_declaration): Ditto.
25237 (interface_method_declaration): Ditto.
25238 (interface_declaration): Ditto.
25240 2001-09-05 Miguel de Icaza <miguel@ximian.com>
25242 * class.cs (Method::Define): Track the "static Main" definition to
25243 create an entry point.
25245 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
25246 EntryPoint if we find it.
25248 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
25249 (EmitContext::ig): Make this variable public.
25251 * driver.cs: Make the default output file be the first file name
25252 with the .exe extension.
25254 Detect empty compilations
25256 Handle various kinds of output targets. Handle --target and
25257 rename -t to --dumper.
25259 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
25260 methods inherited from Expression return now an Expression. This
25261 will is used during the tree rewriting as we resolve them during
25264 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
25265 the spec. Missing entirely is the information about
25266 accessability of elements of it.
25268 (Expression::ExprClassFromMemberInfo): New constructor for
25269 Expressions that creates a fully initialized Expression based on
25270 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
25273 (Invocation::Resolve): Begin implementing resolution of invocations.
25275 * literal.cs (StringLiteral): Implement Emit.
25277 2001-09-05 Ravi Pratap <ravi@ximian.com>
25279 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
25282 2001-09-04 Ravi Pratap <ravi@ximian.com>
25284 * cs-parser.jay (attribute_arguments): Implement actions.
25285 (attribute): Fix bug in production. Implement action.
25286 (attribute_list): Implement.
25287 (attribute_target): Implement.
25288 (attribute_target_specifier, opt_target_specifier): Implement
25289 (CheckAttributeTarget): New method to check if the attribute target
25291 (attribute_section): Implement.
25292 (opt_attributes): Implement.
25294 * attribute.cs : New file to handle attributes.
25295 (Attribute): Class to hold attribute info.
25297 * cs-parser.jay (opt_attribute_target_specifier): Remove production
25298 (attribute_section): Modify production to use 2 different rules to
25299 achieve the same thing. 1 s/r conflict down !
25300 Clean out commented, useless, non-reducing dimension_separator rules.
25302 * class.cs (TypeContainer.attributes): New member to hold list
25303 of attributes for a type.
25304 (Struct::Struct): Modify to take one more argument, the attribute list.
25305 (Class::Class): Ditto.
25306 (Field::Field): Ditto.
25307 (Method::Method): Ditto.
25308 (Property::Property): Ditto.
25310 * cs-parser.jay (struct_declaration): Update constructor call to
25311 pass in the attributes too.
25312 (class_declaration): Ditto.
25313 (constant_declaration): Ditto.
25314 (field_declaration): Ditto.
25315 (method_header): Ditto.
25316 (fixed_parameter): Ditto.
25317 (parameter_array): Ditto.
25318 (property_declaration): Ditto.
25320 * constant.cs (Constant::Constant): Update constructor similarly.
25321 Use System.Collections.
25323 * parameter.cs (Parameter::Parameter): Update as above.
25325 2001-09-02 Ravi Pratap <ravi@ximian.com>
25327 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
25328 (TypeContainer.delegates): New member to hold list of delegates.
25330 * cs-parser.jay (delegate_declaration): Implement the action correctly
25331 this time as I seem to be on crack ;-)
25333 2001-09-02 Miguel de Icaza <miguel@ximian.com>
25335 * rootcontext.cs (RootContext::IsNamespace): new function, used to
25336 tell whether an identifier represents a namespace.
25338 * expression.cs (NamespaceExpr): A namespace expression, used only
25339 temporarly during expression resolution.
25340 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
25341 utility functions to resolve names on expressions.
25343 2001-09-01 Miguel de Icaza <miguel@ximian.com>
25345 * codegen.cs: Add hook for StatementExpressions.
25347 * class.cs: Fix inverted test for static flag in methods.
25349 2001-09-02 Ravi Pratap <ravi@ximian.com>
25351 * class.cs (Operator::CheckUnaryOperator): Correct error number used
25352 to make it coincide with MS' number.
25353 (Operator::CheckBinaryOperator): Ditto.
25355 * ../errors/errors.txt : Remove error numbers added earlier.
25357 * ../errors/cs1019.cs : Test case for error # 1019
25359 * ../errros/cs1020.cs : Test case for error # 1020
25361 * cs-parser.jay : Clean out commented cruft.
25362 (dimension_separators, dimension_separator): Comment out. Ostensibly not
25363 used anywhere - non-reducing rule.
25364 (namespace_declarations): Non-reducing rule - comment out.
25366 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
25367 with TypeContainer::AddEnum.
25369 * delegate.cs : New file for delegate handling classes.
25370 (Delegate): Class for declaring delegates.
25372 * makefile : Update.
25374 * cs-parser.jay (delegate_declaration): Implement.
25376 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
25378 * class.cs (Event::Define): Implement.
25379 (Event.EventBuilder): New member.
25381 * class.cs (TypeContainer::Populate): Update to define all enums and events
25383 (Events): New property for the events arraylist we hold. Shouldn't we move to using
25384 readonly fields for all these cases ?
25386 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
25388 * class.cs (Property): Revamp to use the convention of making fields readonly.
25389 Accordingly modify code elsewhere.
25391 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
25392 the Define method of the Property class.
25394 * class.cs : Clean up applied patch and update references to variables etc. Fix
25396 (TypeContainer::Populate): Update to define all the properties we have. Also
25397 define all enumerations.
25399 * enum.cs (Define): Implement.
25401 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
25403 * cs-parser.jay (overloadable_operator): The semantic value is an
25404 enum of the Operator class.
25405 (operator_declarator): Implement actions.
25406 (operator_declaration): Implement.
25408 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
25409 validity of definitions.
25410 (Operator::CheckBinaryOperator): Static method to check for binary operators
25411 (TypeContainer::AddOperator): New method to add an operator to a type.
25413 * cs-parser.jay (indexer_declaration): Added line to actually call the
25414 AddIndexer method so it gets added ;-)
25416 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
25417 already taken care of by the MS compiler ?
25419 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
25421 * class.cs (Operator): New class for operator declarations.
25422 (Operator::OpType): Enum for the various operators.
25424 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
25426 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
25427 ostensibly handle this in semantic analysis.
25429 * cs-parser.jay (general_catch_clause): Comment out
25430 (specific_catch_clauses, specific_catch_clause): Ditto.
25431 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
25432 (catch_args, opt_catch_args): New productions.
25433 (catch_clause): Rewrite to use the new productions above
25434 (catch_clauses): Modify accordingly.
25435 (opt_catch_clauses): New production to use in try_statement
25436 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
25437 and re-write the code in the actions to extract the specific and
25438 general catch clauses by being a little smart ;-)
25440 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
25441 Hooray, try and catch statements parse fine !
25443 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
25445 * statement.cs (Block::GetVariableType): Fix logic to extract the type
25446 string from the hashtable of variables.
25448 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
25449 I end up making that mistake ;-)
25450 (catch_clauses): Fixed gross error which made Key and Value of the
25451 DictionaryEntry the same : $1 !!
25453 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
25455 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
25457 * cs-parser.jay (event_declaration): Correct to remove the semicolon
25458 when the add and remove accessors are specified.
25460 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
25462 * cs-parser.jay (IndexerDeclaration): New helper class to hold
25463 information about indexer_declarator.
25464 (indexer_declarator): Implement actions.
25465 (parsing_indexer): New local boolean used to keep track of whether
25466 we are parsing indexers or properties. This is necessary because
25467 implicit_parameters come into picture even for the get accessor in the
25468 case of an indexer.
25469 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
25471 * class.cs (Indexer): New class for indexer declarations.
25472 (TypeContainer::AddIndexer): New method to add an indexer to a type.
25473 (TypeContainer::indexers): New member to hold list of indexers for the
25476 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
25478 * cs-parser.jay (add_accessor_declaration): Implement action.
25479 (remove_accessor_declaration): Implement action.
25480 (event_accessors_declaration): Implement
25481 (variable_declarators): swap statements for first rule - trivial.
25483 * class.cs (Event): New class to hold information about event
25485 (TypeContainer::AddEvent): New method to add an event to a type
25486 (TypeContainer::events): New member to hold list of events.
25488 * cs-parser.jay (event_declaration): Implement actions.
25490 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
25492 * cs-parser.jay (dim_separators): Implement. Make it a string
25493 concatenating all the commas together, just as they appear.
25494 (opt_dim_separators): Modify accordingly
25495 (rank_specifiers): Update accordingly. Basically do the same
25496 thing - instead, collect the brackets here.
25497 (opt_rank_sepcifiers): Modify accordingly.
25498 (array_type): Modify to actually return the complete type string
25499 instead of ignoring the rank_specifiers.
25500 (expression_list): Implement to collect the expressions
25501 (variable_initializer): Implement. We make it a list of expressions
25502 essentially so that we can handle the array_initializer case neatly too.
25503 (variable_initializer_list): Implement.
25504 (array_initializer): Make it a list of variable_initializers
25505 (opt_array_initializer): Modify accordingly.
25507 * expression.cs (New::NType): Add enumeration to help us
25508 keep track of whether we have an object/delegate creation
25509 or an array creation.
25510 (New:NewType, New::Rank, New::Indices, New::Initializers): New
25511 members to hold data about array creation.
25512 (New:New): Modify to update NewType
25513 (New:New): New Overloaded contructor for the array creation
25516 * cs-parser.jay (array_creation_expression): Implement to call
25517 the overloaded New constructor.
25519 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
25521 * class.cs (TypeContainer::Constructors): Return member
25522 constructors instead of returning null.
25524 2001-08-26 Miguel de Icaza <miguel@ximian.com>
25526 * typemanager.cs (InitCoreTypes): Initialize the various core
25527 types after we have populated the type manager with the user
25528 defined types (this distinction will be important later while
25529 compiling corlib.dll)
25531 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
25532 on Expression Classification. Now all expressions have a method
25533 `Resolve' and a method `Emit'.
25535 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
25536 generation from working. Also add some temporary debugging
25539 2001-08-24 Miguel de Icaza <miguel@ximian.com>
25541 * codegen.cs: Lots of code generation pieces. This is only the
25542 beginning, will continue tomorrow with more touches of polish. We
25543 handle the fundamentals of if, while, do, for, return. Others are
25544 trickier and I need to start working on invocations soon.
25546 * gen-treedump.cs: Bug fix, use s.Increment here instead of
25549 * codegen.cs (EmitContext): New struct, used during code
25550 emission to keep a context. Most of the code generation will be
25553 * cs-parser.jay: Add embedded blocks to the list of statements of
25554 this block. So code generation proceeds in a top down fashion.
25556 2001-08-23 Miguel de Icaza <miguel@ximian.com>
25558 * statement.cs: Add support for multiple child blocks.
25560 2001-08-22 Miguel de Icaza <miguel@ximian.com>
25562 * codegen.cs (EmitCode): New function, will emit the code for a
25563 Block of code given a TypeContainer and its ILGenerator.
25565 * statement.cs (Block): Standard public readonly optimization.
25566 (Block::Block constructors): Link children.
25567 (Block::Child): Child Linker.
25568 (Block::EmitVariables): Emits IL variable declarations.
25570 * class.cs: Drop support for MethodGroups here, delay until
25572 (Method::): Applied the same simplification that I did before, and
25573 move from Properties to public readonly fields.
25574 (Method::ParameterTypes): Returns the parameter types for the
25575 function, and implements a cache that will be useful later when I
25576 do error checking and the semantic analysis on the methods is
25578 (Constructor::GetCallingConvention): Renamed from CallingConvetion
25579 and made a method, optional argument tells whether this is a class
25580 or a structure to apply the `has-this' bit.
25581 (Method::GetCallingConvention): Implement, returns the calling
25583 (Method::Define): Defines the type, a second pass is performed
25584 later to populate the methods.
25586 (Constructor::ParameterTypes): implement a cache similar to the
25587 one on Method::ParameterTypes, useful later when we do semantic
25590 (TypeContainer::EmitMethod): New method. Emits methods.
25592 * expression.cs: Removed MethodGroup class from here.
25594 * parameter.cs (Parameters::GetCallingConvention): new method.
25596 2001-08-21 Miguel de Icaza <miguel@ximian.com>
25598 * class.cs (TypeContainer::Populate): Drop RootContext from the
25601 (Constructor::CallingConvention): Returns the calling convention.
25602 (Constructor::ParameterTypes): Returns the constructor parameter
25605 (TypeContainer::AddConstructor): Keep track of default constructor
25606 and the default static constructor.
25608 (Constructor::) Another class that starts using `public readonly'
25609 instead of properties.
25611 (Constructor::IsDefault): Whether this is a default constructor.
25613 (Field::) use readonly public fields instead of properties also.
25615 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
25616 track of static constructors; If none is used, turn on
25617 BeforeFieldInit in the TypeAttributes.
25619 * cs-parser.jay (opt_argument_list): now the return can be null
25620 for the cases where there are no arguments.
25622 (constructor_declarator): If there is no implicit `base' or
25623 `this', then invoke the default parent constructor.
25625 * modifiers.cs (MethodAttr): New static function maps a set of
25626 modifiers flags into a MethodAttributes enum
25627 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
25628 MethodAttr, TypeAttr to represent the various mappings where the
25629 modifiers are used.
25630 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
25632 2001-08-19 Miguel de Icaza <miguel@ximian.com>
25634 * parameter.cs (GetParameterInfo): Fix bug where there would be no
25637 * interface.cs (PopulateIndexer): Implemented the code generator
25638 for interface indexers.
25640 2001-08-17 Miguel de Icaza <miguel@ximian.com>
25642 * interface.cs (InterfaceMemberBase): Now we track the new status
25645 (PopulateProperty): Implement property population. Woohoo! Got
25646 Methods and Properties going today.
25648 Removed all the properties for interfaces, and replaced them with
25649 `public readonly' fields.
25651 2001-08-16 Miguel de Icaza <miguel@ximian.com>
25653 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
25654 initialize their hashtables/arraylists only when they are needed
25655 instead of doing this always.
25657 * parameter.cs: Handle refs and out parameters.
25659 * cs-parser.jay: Use an ArrayList to construct the arguments
25660 instead of the ParameterCollection, and then cast that to a
25663 * parameter.cs: Drop the use of ParameterCollection and use
25664 instead arrays of Parameters.
25666 (GetParameterInfo): Use the Type, not the Name when resolving
25669 2001-08-13 Miguel de Icaza <miguel@ximian.com>
25671 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
25672 and instead use public readonly fields.
25674 * class.cs: Put back walking code for type containers.
25676 2001-08-11 Miguel de Icaza <miguel@ximian.com>
25678 * class.cs (MakeConstant): Code to define constants.
25680 * rootcontext.cs (LookupType): New function. Used to locate types
25683 2001-08-08 Miguel de Icaza <miguel@ximian.com>
25685 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
25686 this System.Reflection code is. Kudos to Microsoft
25688 * typemanager.cs: Implement a type cache and avoid loading all
25689 types at boot time. Wrap in LookupType the internals. This made
25690 the compiler so much faster. Wow. I rule!
25692 * driver.cs: Make sure we always load mscorlib first (for
25693 debugging purposes, nothing really important).
25695 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
25696 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
25698 * rootcontext.cs: Lookup types on their namespace; Lookup types
25699 on namespaces that have been imported using the `using' keyword.
25701 * class.cs (TypeContainer::TypeAttr): Virtualize.
25702 (Class::TypeAttr): Return attributes suitable for this bad boy.
25703 (Struct::TypeAttr): ditto.
25704 Handle nested classes.
25705 (TypeContainer::) Remove all the type visiting code, it is now
25706 replaced with the rootcontext.cs code
25708 * rootcontext.cs (GetClassBases): Added support for structs.
25710 2001-08-06 Miguel de Icaza <miguel@ximian.com>
25712 * interface.cs, statement.cs, class.cs, parameter.cs,
25713 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
25714 Drop use of TypeRefs, and use strings instead.
25716 2001-08-04 Miguel de Icaza <miguel@ximian.com>
25720 * class.cs (Struct::Struct): set the SEALED flags after
25721 checking the modifiers.
25722 (TypeContainer::TypeAttr): new property, returns the
25723 TypeAttributes for a class.
25725 * cs-parser.jay (type_list): Oops, list production was creating a
25726 new list of base types.
25728 * rootcontext.cs (StdLib): New property.
25729 (GetInterfaceTypeByName): returns an interface by type name, and
25730 encapsulates error handling here.
25731 (GetInterfaces): simplified.
25732 (ResolveTree): Encapsulated all the tree resolution here.
25733 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
25736 * driver.cs: Add support for --nostdlib, to avoid loading the
25737 default assemblies.
25738 (Main): Do not put tree resolution here.
25740 * rootcontext.cs: Beginning of the class resolution.
25742 2001-08-03 Miguel de Icaza <miguel@ximian.com>
25744 * rootcontext.cs: Provide better error reporting.
25746 * cs-parser.jay (interface_base): set our $$ to be interfaces.
25748 * rootcontext.cs (CreateInterface): Handle the case where there
25749 are no parent interfaces.
25751 (CloseTypes): Routine to flush types at the end.
25752 (CreateInterface): Track types.
25753 (GetInterfaces): Returns an array of Types from the list of
25754 defined interfaces.
25756 * typemanager.c (AddUserType): Mechanism to track user types (puts
25757 the type on the global type hash, and allows us to close it at the
25760 2001-08-02 Miguel de Icaza <miguel@ximian.com>
25762 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
25763 RecordInterface instead.
25765 * cs-parser.jay: Updated to reflect changes above.
25767 * decl.cs (Definition): Keep track of the TypeBuilder type that
25768 represents this type here. Not sure we will use it in the long
25769 run, but wont hurt for now.
25771 * driver.cs: Smaller changes to accomodate the new code.
25773 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
25776 * rootcontext.cs (CreateInterface): New method, used to create
25777 the System.TypeBuilder type for interfaces.
25778 (ResolveInterfaces): new entry point to resolve the interface
25780 (CodeGen): Property, used to keep track of the code generator.
25782 2001-07-26 Miguel de Icaza <miguel@ximian.com>
25784 * cs-parser.jay: Add a second production for delegate_declaration
25787 (enum_body): Put an opt_comma here instead of putting it on
25788 enum_body or enum_member_declarations so we can handle trailing
25789 commas on enumeration members. Gets rid of a shift/reduce.
25791 (type_list): Need a COMMA in the middle.
25793 (indexer_declaration): Tell tokenizer to recognize get/set
25795 * Remove old targets.
25797 * Re-add the parser target.
25799 2001-07-13 Simon Cozens <simon@simon-cozens.org>
25801 * cs-parser.jay: Add precendence rules for a number of operators
25802 ot reduce the number of shift/reduce conflicts in the grammar.
25804 2001-07-17 Miguel de Icaza <miguel@ximian.com>
25806 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
25809 Get rid of old crufty code.
25811 * rootcontext.cs: Use this to keep track of the parsed
25812 representation and the defined types available to the program.
25814 * gen-treedump.cs: adjust for new convention.
25816 * type.cs: Split out the type manager, and the assembly builder
25819 * typemanager.cs: the type manager will live here now.
25821 * cil-codegen.cs: And the code generator here.
25823 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
25825 * makefile: Fixed up for easy making.
25827 2001-07-13 Simon Cozens <simon@simon-cozens.org>
25829 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
25832 (unary_expression): Expand pre_increment_expression and
25833 post_decrement_expression to reduce a shift/reduce.
25835 2001-07-11 Simon Cozens
25837 * cs-tokenizer.cs: Hex numbers should begin with a 0.
25839 Improve allow_keyword_as_indent name.
25841 2001-06-19 Miguel de Icaza <miguel@ximian.com>
25843 * Adjustments for Beta2.
25845 2001-06-13 Miguel de Icaza <miguel@ximian.com>
25847 * decl.cs: Added `Define' abstract method.
25848 (InTransit): new property, used to catch recursive definitions.
25850 * interface.cs: Implement `Define'.
25852 * modifiers.cs: Map Modifiers.constants to
25853 System.Reflection.TypeAttribute flags.
25855 * class.cs: Keep track of types and user-defined types.
25856 (BuilderInit): New method for creating an assembly
25857 (ResolveType): New function to launch the resolution process, only
25858 used by interfaces for now.
25860 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
25861 that are inserted into the name space.
25863 2001-06-08 Miguel de Icaza <miguel@ximian.com>
25865 * ARGH. I have screwed up my tree so many times due to the use of
25866 rsync rather than using CVS. Going to fix this at once.
25868 * driver.cs: Objetify driver. Load assemblies, use assemblies to
25871 2001-06-07 Miguel de Icaza <miguel@ximian.com>
25873 * Experiment successful: Use System.Type rather that our own
25876 2001-05-25 Miguel de Icaza <miguel@ximian.com>
25878 * cs-parser.jay: Removed nsAliases from here.
25880 Use new namespaces, handle `using XXX;'
25882 * namespace.cs: Reimplemented namespace handling, use a recursive
25883 definition of the class. Now we can keep track of using clauses
25884 and catch invalid using clauses.
25886 2001-05-24 Miguel de Icaza <miguel@ximian.com>
25888 * gen-treedump.cs: Adapted for all the renaming.
25890 * expression.cs (Expression): this class now has a Type property
25891 which returns an expression Type.
25893 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
25894 `Type', as this has a different meaning now in the base
25896 2001-05-22 Miguel de Icaza <miguel@ximian.com>
25898 * interface.cs, class.cs: Removed from all the sources the
25899 references to signature computation, as we can not do method
25900 signature computation during the parsing time, as we are not
25901 trying to solve at that point distinguishing:
25905 void a (NS.Blah x) {}
25908 Which depending on the context might be valid or not, as we do not
25909 know if Blah is the same thing as NS.Blah at that point.
25911 * Redid everything so the code uses TypeRefs now instead of
25912 Types. TypeRefs are just temporary type placeholders, that need
25913 to be resolved. They initially have a pointer to a string and the
25914 current scope in which they are used. This is used later by the
25915 compiler to resolve the reference to an actual Type.
25917 * DeclSpace is no longer a CIR.Type, and neither are
25918 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
25919 are all DeclSpaces, but no Types.
25921 * type.cs (TypeRefManager): This implements the TypeRef manager,
25922 which keeps track of all the types that need to be resolved after
25923 the parsing has finished.
25925 2001-05-13 Miguel de Icaza <miguel@ximian.com>
25927 * ARGH. We are going to have to store `foreach' as a class rather
25928 than resolving it, as we need to verify error 1579 after name
25929 resolution. *OR* we could keep a flag that says `This request to
25930 IEnumerator comes from a foreach statement' which we can then use
25931 to generate the error.
25933 2001-05-10 Miguel de Icaza <miguel@ximian.com>
25935 * class.cs (TypeContainer.AddMethod): we now add methods to the
25936 MethodGroup instead of the method hashtable.
25938 * expression.cs: Add MethodGroup abstraction, which gets us one
25939 step closer to the specification in the way we handle method
25942 * cs-parser.jay (primary_expression): qualified_identifier now
25943 tried to match up an identifier to a local variable reference or
25944 to a parameter reference.
25946 current_local_parameters is now a parser global variable that
25947 points to the current parameters for the block, used during name
25950 (property_declaration): Now creates an implicit `value' argument to
25953 2001-05-09 Miguel de Icaza <miguel@ximian.com>
25955 * parameter.cs: Do not use `param' arguments as part of the
25956 signature, per the spec.
25958 2001-05-08 Miguel de Icaza <miguel@ximian.com>
25960 * decl.cs: Base class for classes, structs and interfaces. This
25961 is the "Declaration Space"
25963 * cs-parser.jay: Use CheckDef for checking declaration errors
25964 instead of having one on each function.
25966 * class.cs: Factor out some code for handling error handling in
25967 accordance to the "Declarations" section in the "Basic Concepts"
25968 chapter in the ECMA C# spec.
25970 * interface.cs: Make all interface member classes derive from
25971 InterfaceMemberBase.
25973 2001-05-07 Miguel de Icaza <miguel@ximian.com>
25975 * Many things: all interfaces are parsed and generated in
25976 gen-treedump. Support for member variables, constructors,
25977 destructors, properties, constants is there.
25979 Beginning of the IL backend, but very little done, just there for
25982 2001-04-29 Miguel de Icaza <miguel@ximian.com>
25984 * cs-parser.jay: Fix labeled statement.
25986 * cs-tokenizer.cs (escape): Escape " and ' always.
25987 ref_line, ref_name: keep track of the line/filename as instructed
25988 by #line by the compiler.
25991 2001-04-27 Miguel de Icaza <miguel@ximian.com>
25993 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
25994 to match the values in System.CodeDOM.
25996 Divid renamed to Divide.
25998 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
26000 (Statements.set): remove.
26002 * System.CodeDOM/CodeCatchClause.cs: always have a valid
26005 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
26006 falseStatements always have valid values.
26008 * cs-parser.jay: Use System.CodeDOM now.