1 2004-11-29 Raja R Harinath <rharinath@novell.com>
3 * decl.cs (MemberCore.MemberName): Remove readonly to fix an error
5 * rootcontext.cs (ResolveCore::interfaces_first_stage): Add
6 System.Runtime.InteropServices._Exception, since it's a base
7 interface of the core type System.Exception in the net_2_0 profile.
9 2004-11-27 Martin Baulig <martin@ximian.com>
11 * ecore.cs (Expression.StoreFromPtr): Use `stobj' for generic parameters.
13 2004-11-26 Raja R Harinath <rharinath@novell.com>
15 * Makefile: Convert to use executable.make.
16 * gmcs.exe.sources: New.
18 2004-11-25 Martin Baulig <martin@ximian.com>
20 * expression.cs (Invocation.InferType): Added support for byref types.
22 2004-11-25 Martin Baulig <martin@ximian.com>
24 * statement.cs (Foreach.FetchMethodMoveNext): Wrap `mi.ReturnType'
25 in TypeManager.TypeToCoreType().
27 2004-11-25 Martin Baulig <martin@ximian.com>
29 * iterators.cs (Iterator.DoDefineMembers): Override and lookup the
30 "Dispose" method from the `current_type'.
31 (Iterator.EmitMoveNext): Use the `dispose_method' we looked up in
32 DoDefineMembers() instead of using the MethodBuilder; this is
33 required for generic iterators.
35 * class.cs (TypeContainer.DoDefineMembers): Make this virtual.
37 2004-11-24 Martin Baulig <martin@ximian.com>
39 * ecore.cs (Expression.LoadFromPtr): Use `ldobj' for generic parameters.
41 2004-11-20 Martin Baulig <martin@ximian.com>
43 * expression.cs (Invocation.InferType): Correctly infer generic
44 instances; see gen-103.cs.
45 (Invocation.InferTypeArguments): If a generic method doesn't have
46 any unbound type parameters, we don't need to infer anything.
48 2004-11-19 Raja R Harinath <rharinath@novell.com>
50 * Makefile (gmcs.exe): Update to new location of bootstrap mcs.exe.
52 2004-11-17 Raja R Harinath <rharinath@novell.com>
54 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
55 (TypeHandle.GetMemberCache): New.
56 (TypeHandle.TypeHandle): Update.
57 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
58 (TypeManager.LookupParentInterfacesCache):
59 Rename from LookupInterfaceCache. Optimize slightly.
60 (TypeManager.MemberLookup_FindMembers): Update.
61 * decl.cs (MemberCache.MemberCache): Set Container to null in the
63 (AddCacheContents): Rename from AddHashtable.
64 * class.cs (TypeContainer.parent_container): Remove.
65 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
66 (TypeContainer.DoDefineMembers): Don't initialize it.
67 Update to name changes.
69 2004-11-17 Miguel de Icaza <miguel@ximian.com>
71 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
72 that factors the code to check access modifiers on override.
74 (PropertyBase): Use the code here.
76 Patch from Lluis S'anchez, fixes bug #69361.
78 2004-11-15 Miguel de Icaza <miguel@ximian.com>
80 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
81 routine that is used to report the use of a captured variable
82 whose address has been taken.
84 There are two checks: one when variables are being captured and
85 the other check is when the address of a variable is taken.
87 (because an anonymous methods might be resolved before *or* after
88 the address has been taken) and
90 * expression.cs (Conditional.DoResolve): Remove the special
91 casing that Martin added to trueExpr and falseExpr being both
92 NullLiteral. We get the right behavior now just by introducing
93 the null_type into the compiler.
95 * convert.cs (ExplicitConversion): Change the code to use
96 null_type instead of testing `expr is NullLiteral'.
97 (ImplicitConversionStandard): use null_type too.
98 (ImplicitReferenceConversionExists): use null_type too.
99 (ImplicitReferenceConversion): use null_type too.
101 * literal.cs: The type of `NullLiteral' is now null_type instead
103 (Resolve): Set the type here.
105 * typemanager.cs: Introduce null_type.
107 2004-11-18 Martin Baulig <martin@ximian.com>
110 (RootContext.LookupType): Return a `Type', not a `TypeExpr'.
112 2004-11-18 Martin Baulig <martin@ximian.com>
114 * ecore.cs (TypeExpr.DoResolveAsTypeStep): Make this protected.
116 2004-11-18 Martin Baulig <martin@ximian.com>
118 * generic.cs (Constraints.Resolve): Take an `EmitContext' instead
119 of a `DeclSpace'. If one of our constraints is a `ConstructedType',
120 call ResolveConstructedType() on it to resolve it without checking
122 (Constraints.ResolveTypes): Check them here.
123 (ConstructedType.DoResolveAsTypeStep): Fully resolve ourselves,
124 but don't check constraints.
125 (ConstructedType.ResolveAsTypeTerminal): Override this and also
126 check constraints here.
127 (ConstructedType.ResolveConstructedType): New public method. This
128 is called from DoResolveAsTypeStep() and Constraints.Resolve() to
129 resolve ourselves without checking constraints.
131 * ecore.cs (Expression.ResolveAsTypeTerminal): Make this virtual.
133 2004-11-18 Martin Baulig <martin@ximian.com>
136 (DeclSpace.CurrentType): Changed type from `TypeExpr' to `Type'.
138 * delegate.cs (Delegate.DefineType): Always create the EmitContext.
140 2004-11-18 Martin Baulig <martin@ximian.com>
142 * ecore.cs (TypeExpr.ResolveType): Removed.
143 (Expression.ResolveAsTypeTerminal): We always return a fully
144 resolved `TypeExpr', so we can just access its `Type'.
146 * class.cs (TypeContainer.DefineType): Resolve `CurrentType' here.
148 2004-11-17 Martin Baulig <martin@ximian.com>
150 * ecore.cs (IAlias.Type): Replaced with ResolveAsType() to make
151 sure we don't return any unresolved TypeExpr's.
152 (TypeAliasExpression): The .ctor now takes an `IAlias' instead of
154 (Expression.ResolveAsTypeTerminal): Make sure `te.Type != null'.
156 * expression.cs (MemberAccess.ResolveAsTypeStep): Don't return any
157 unresolved `ConstructedType's.
159 2004-11-17 Martin Baulig <martin@ximian.com>
161 * ecore.cs (TypeExpr.ResolveType): Don't make this virtual.
163 2004-11-17 Martin Baulig <martin@ximian.com>
166 (Expression.ResolveAsTypeTerminal): Removed the `bool silent' argument.
168 * decl.cs (DeclSpace.ResolveType): Removed.
169 (DeclSpace.ResolveTypeExpr): Removed the `bool silent' argument.
171 2004-11-17 Martin Baulig <martin@ximian.com>
173 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
174 direction, like FindMembers() does. Fixes #69546, testcase is in
177 2004-11-16 Martin Baulig <martin@ximian.com>
179 This is based on a patch from Marek Safar, see bug #69082.
180 Fixes bugs #63705 and #67130.
182 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
183 method; create a MemberCache for an interface type and cache the
186 * decl.cs (IMemberContainer.ParentContainer): Removed.
187 (IMemberContainer.ParentCache): New property.
188 (MemberCache.SetupCacheForInterface): Removed.
189 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
190 to create a cache for an interface's "parent".
192 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
195 2004-11-14 Ben Maurer <bmaurer@ximian.com>
197 * statement.cs: Avoid adding bools to a hashtable.
199 2004-11-15 Martin Baulig <martin@ximian.com>
201 * decl.cs (MemberName.GetPartialName): Removed, use GetTypeName() instead.
203 2004-11-11 Martin Baulig <martin@ximian.com>
205 * typemanager.cs (TypeManager.GetMethodName): New method.
207 * class.cs (MethodData.Define): Include the generic arity in the
208 name of an explicit interface; also add it to the method name.
210 * pending.cs (PendingImplementation.InterfaceMethod): The method
211 name now includes the generic arity.
213 2004-11-07 Miguel de Icaza <miguel@ximian.com>
215 * expression.cs (Invocation.OverloadResolve): Flag error if we are
216 calling an unsafe method from a safe location.
218 2004-11-06 Marek Safar <marek.safar@seznam.cz>
221 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
223 2004-11-06 Miguel de Icaza <miguel@ximian.com>
225 * namespace.cs (VerifyUsing): use GetPartialName instead of
228 2004-11-05 Miguel de Icaza <miguel@ximian.com>
230 * statement.cs (Return.Resolve): Fix regression in typo: if
231 `in_exc', we have to request a NeedReturnLabel, this was a typo
232 introduced in the anonymous method check-in. Fixes #69131.
234 * Indexers were using the ShortName when defining themselves,
235 causing a regression in the compiler bootstrap when applying the
236 patch from 2004-11-02 (first part), now they use their full name
239 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
241 * driver.cs: Strip the path from the names of embedded resources. Fixes
244 2004-11-04 Raja R Harinath <rharinath@novell.com>
246 Fix error message regression: cs0104-2.cs.
247 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
248 (AliasEntry.Resolve): Update.
249 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
251 (RootContext.LookupType): Update.
253 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
255 * cs-parser.jay: Add support for handling accessor modifiers
256 * class: Add support port accessor modifiers and error checking,
257 define PropertyMethod.Define as virtual (not abstract anymore)
258 * ecore.cs: Add checking for proeprties access with access modifiers
259 * iterators.cs: Modify Accessor constructor call based in the modified
261 2004-11-02 Ben Maurer <bmaurer@ximian.com>
263 * expression.cs (StringConcat): Handle being called twice,
264 as when we have a concat in a field init with more than two
267 2004-11-02 Miguel de Icaza <miguel@ximian.com>
269 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
270 special case explicit implementations, we should always produce
271 the .property or .event declaration.
273 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
274 since it will not return correct data if people use this
275 unresolved in the presence of using statements (see test-313).
277 * class.cs (MethodData.Define): If we are an explicit interface
278 implementation, set the method name to the full name of the
279 interface plus the name of the method.
281 Notice that using the method.MethodName.GetFullName() does not
282 work, as it will only contain the name as declared on the source
283 file (it can be a shorthand in the presence of using statements)
284 and not the fully qualifed type name, for example:
288 class D : ICloneable {
289 object ICloneable.Clone () {
293 Would produce a method called `ICloneable.Clone' instead of
294 `System.ICloneable.Clone'.
296 * namespace.cs (Alias.Resolve): Use GetPartialName.
298 2004-11-01 Marek Safar <marek.safar@seznam.cz>
300 * cs-parser.jay: Add error 1055 report.
302 2004-11-01 Miguel de Icaza <miguel@ximian.com>
304 * assign.cs (Assign.DoResolve): Only do the transform of
305 assignment into a New if the types are compatible, if not, fall
306 through and let the implicit code deal with the errors and with
307 the necessary conversions.
309 2004-11-01 Marek Safar <marek.safar@seznam.cz>
311 * cs-parser.jay: Add error 1031 report.
313 * cs-tokenizer.cs: Add location for error 1038.
315 2004-10-31 Marek Safar <marek.safar@seznam.cz>
317 * cs-parser.jay: Add error 1016 report.
319 2004-10-31 Marek Safar <marek.safar@seznam.cz>
321 * cs-parser.jay: Add errors 1575,1611 report.
323 2004-10-31 Marek Safar <marek.safar@seznam.cz>
325 * cs-parser.jay: Add error 1001 report.
327 2004-10-31 Marek Safar <marek.safar@seznam.cz>
330 * attribute.cs (GetMarshal): Add method argument for
331 caller identification.
333 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
334 agument for GetMarshal and RuntimeMissingSupport.
336 2004-10-31 Marek Safar <marek.safar@seznam.cz>
338 * attribute.cs (ExtractSecurityPermissionSet): Removed
339 TypeManager.code_access_permission_type.
341 * typemanager.cs: Removed TypeManager.code_access_permission_type.
343 2004-10-27 Miguel de Icaza <miguel@ximian.com>
345 * expression.cs (LocalVariableReference.DoResolveLValue): Check
346 for obsolete use of a variable here. Fixes regression on errors
347 cs0619-25 and cs0619-26.
349 2004-10-27 Marek Safar <marek.safar@seznam.cz>
351 Fix #62358, implemented security attribute encoding.
353 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
354 Tests permitted SecurityAction for assembly or other types.
355 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
356 data from SecurityPermissionAttribute to PermisionSet class.
358 * class.cs (ApplyAttributeBuilder): Added special handling
359 for System.Security.Permissions.SecurityAttribute based types.
361 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
362 special handling for System.Security.Permissions.SecurityAttribute
365 * enum.cs (ApplyAttributeBuilder): Added special handling
366 for System.Security.Permissions.SecurityAttribute based types.
368 * parameter.cs (ApplyAttributeBuilder): Added special handling
369 for System.Security.Permissions.SecurityAttribute based types.
371 * rootcontext.cs: Next 2 core types.
373 * typemanager.cs (TypeManager.security_permission_attr_type):
374 Built in type for the SecurityPermission Attribute.
375 (code_access_permission_type): Build in type.
377 2004-10-17 Miguel de Icaza <miguel@ximian.com>
379 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
380 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
381 all of this information into
382 EmitContext.EmitCapturedVariableInstance.
384 * codegen.cs (EmitCapturedVariableInstance): move here the
385 funcionality of emitting an ldarg.0 in the presence of a
386 remapping. This centralizes the instance emit code.
388 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
389 then emit a load of this: it means that we have reached the
390 topmost ScopeInfo: the one that contains the pointer to the
391 instance of the class hosting the anonymous method.
393 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
394 captures to the topmost CaptureContext.
396 2004-10-12 Miguel de Icaza <miguel@ximian.com>
398 * expression.cs (LocalVariableReference): Move the knowledge about
399 the iterators into codegen's EmitCapturedVariableInstance.
401 2004-10-11 Miguel de Icaza <miguel@ximian.com>
403 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
404 all code paths return a value from an anonymous method (it is the
405 same as the 161 error, but for anonymous methods).
407 2004-10-08 Miguel de Icaza <miguel@ximian.com>
409 The introduction of anonymous methods in the compiler changed
410 various ways of doing things in the compiler. The most
411 significant one is the hard split between the resolution phase
412 and the emission phases of the compiler.
414 For instance, routines that referenced local variables no
415 longer can safely create temporary variables during the
416 resolution phase: they must do so from the emission phase,
417 since the variable might have been "captured", hence access to
418 it can not be done with the local-variable operations from the runtime.
422 (Block.Flags): New flag `IsTopLevel' to indicate that this block
425 (ToplevelBlock): A new kind of Block, these are the blocks that
426 are created by the parser for all toplevel method bodies. These
427 include methods, accessors and anonymous methods.
429 These contain some extra information not found in regular blocks:
430 A pointer to an optional CaptureContext (for tracking captured
431 local variables and parameters). A pointer to the parent
434 (Return.Resolve): Catch missmatches when returning a value from an
435 anonymous method (error 1662).
436 Invoke NeedReturnLabel from the Resolve phase instead of the emit
439 (Break.Resolve): ditto.
441 (SwitchLabel): instead of defining the labels during the
442 resolution phase, we now turned the public ILLabel and ILLabelCode
443 labels into methods called GetILLabelCode() and GetILLabel() that
444 only define the label during the Emit phase.
446 (GotoCase): Track the SwitchLabel instead of the computed label
447 (its contained therein). Emit the code by using
448 SwitchLabel.GetILLabelCode ().
450 (LocalInfo.Flags.Captured): A new flag has been introduce to track
451 whether the Local has been captured or not.
453 (LocalInfo.IsCaptured): New property, used to tell whether the
454 local has been captured.
456 * anonymous.cs: Vastly updated to contain the anonymous method
459 The main classes here are: CaptureContext which tracks any
460 captured information for a toplevel block and ScopeInfo used to
461 track the activation frames for various local variables.
463 Each toplevel block has an optional capture context associated
464 with it. When a method contains an anonymous method both the
465 toplevel method and the anonymous method will create a capture
466 context. When variables or parameters are captured, they are
467 recorded on the CaptureContext that owns them, for example:
471 MyDelegate d = delegate {
476 Here `a' will be recorded as captured on the toplevel
477 CapturedContext, the inner captured context will not have anything
478 (it will only have data if local variables or parameters from it
479 are captured in a nested anonymous method.
481 The ScopeInfo is used to track the activation frames for local
482 variables, for example:
484 for (int i = 0; i < 10; i++)
485 for (int j = 0; j < 10; j++){
486 MyDelegate d = delegate {
491 At runtime this captures a single captured variable `i', but it
492 captures 10 different versions of the variable `j'. The variable
493 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
496 The toplevel ScopeInfo will also track information like the `this'
497 pointer if instance variables were referenced (this is necessary
498 as the anonymous method lives inside a nested class in the host
501 (AnonymousMethod): Expanded to track the Toplevel, implement
502 `AnonymousMethod.Compatible' to tell whether an anonymous method
503 can be converted to a target delegate type.
505 The routine now also produces the anonymous method content
507 (AnonymousDelegate): A helper class that derives from
508 DelegateCreation, this is used to generate the code necessary to
509 produce the delegate for the anonymous method that was created.
511 * assign.cs: API adjustments for new changes in
512 Convert.ImplicitStandardConversionExists.
514 * class.cs: Adjustments to cope with the fact that now toplevel
515 blocks are of type `ToplevelBlock'.
517 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
518 insteda of standard blocks.
520 Flag errors if params arguments are passed to anonymous methods.
522 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
523 `CurrentAnonymousMethod' which points to the current Anonymous
524 Method. The variable points to the AnonymousMethod class that
525 holds the code being compiled. It is set in the new EmitContext
526 created for the anonymous method.
528 (EmitContext.Phase): Introduce a variable and an enumeration to
529 assist in enforcing some rules about when and where we are allowed
530 to invoke certain methods (EmitContext.NeedsReturnLabel is the
531 only one that enfonces this right now).
533 (EmitContext.HaveCaptureInfo): new helper method that returns
534 whether we have a CapturedContext initialized.
536 (EmitContext.CaptureVariable): New method used to register that a
537 LocalInfo must be flagged for capturing.
539 (EmitContext.CapturedParameter): New method used to register that a
540 parameters must be flagged for capturing.
542 (EmitContext.CapturedField): New method used to register that a
543 field must be flagged for capturing.
545 (EmitContext.HaveCapturedVariables,
546 EmitContext.HaveCapturedFields): Return whether there are captured
549 (EmitContext.EmitMethodHostInstance): This is used to emit the
550 instance for the anonymous method. The instance might be null
551 (static methods), this (for anonymous methods that capture nothing
552 and happen to live side-by-side with the current method body) or a
553 more complicated expression if the method has a CaptureContext.
555 (EmitContext.EmitTopBlock): Routine that drives the emission of
556 code: it will first resolve the top block, then emit any metadata
557 and then emit the code. The split is done so that we can extract
558 any anonymous methods and flag any captured variables/parameters.
560 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
561 during this phase, the ILGenerator should not be used as labels
562 and local variables declared here might not be accessible to any
563 code that is part of an anonymous method.
565 Exceptions to this include the temporary variables that are
566 created by some statements internally for holding temporary
569 (EmitContext.EmitMeta): New routine, in charge of emitting all the
572 (EmitContext.TemporaryReturn): This method is typically called
573 from the Emit phase, and its the only place where we allow the
574 ReturnLabel to be defined other than the EmitMeta. The reason is
575 that otherwise we would have to duplicate a lot of logic in the
576 Resolve phases of various methods that today is on the Emit
579 (EmitContext.NeedReturnLabel): This no longer creates the label,
580 as the ILGenerator is not valid during the resolve phase.
582 (EmitContext.EmitThis): Extended the knowledge in this class to
583 work in anonymous methods in addition to iterators.
585 (EmitContext.EmitCapturedVariableInstance): This emits whatever
586 code is necessary on the stack to access the instance to a local
587 variable (the variable will be accessed as a field).
589 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
590 EmitContext.EmitAddressOfParameter): Routines to support
591 parameters (not completed at this point).
593 Removals: Removed RemapLocal and RemapLocalLValue. We probably
594 will also remove the parameters.
596 * convert.cs (Convert): Define a `ConstantEC' which points to a
597 null. This is just to prefity some code that uses
598 ImplicitStandardConversion code and do not have an EmitContext
601 The idea is to flag explicitly that at that point in time, it is
602 known that the conversion will not trigger the delegate checking
603 code in implicit conversions (which requires a valid
606 Everywhere: pass new EmitContext parameter since
607 ImplicitStandardConversionExists now requires it to check for
608 anonymous method conversions.
610 (Convert.ImplicitStandardConversionExists): If the type of an
611 expression is the anonymous_method_type, and the type is a
612 delegate, we invoke the AnonymousMethod.Compatible method to check
613 whether an implicit conversion is possible.
615 (Convert.ImplicitConversionStandard): Only do implicit method
616 group conversions if the language level is not ISO_1.
618 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
619 MethodInfo for the Invoke method. used by Delegate and
622 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
623 method conversions if the target type is a delegate.
625 Removed extra debugging nops.
627 (LocalVariableReference): Turn the `local_info' into a public
630 Add `prepared' field, the same hack used for FieldExprs to cope
631 with composed assignments, as Local variables do not necessarily
632 operate purely on the stack as they used to: they can be captured
635 Add `temp' for a temporary result, like fields.
637 Refactor DoResolve and DoResolveLValue into DoResolveBase.
639 It now copes with Local variables that are captured and emits the
640 proper instance variable to load it from a field in the captured
643 (ParameterReference.DoResolveBase): During the resolve phase,
644 capture parameters if we are in an anonymous method.
646 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
647 anonymous method, use the EmitContext helper routines to emit the
650 * iterators.cs: Set RemapToProxy to true/false during the
653 * parameters.cs (GetParameterByName): New helper method.
655 * typemanager.cs (anonymous_method_type) a new type that
656 represents an anonyous method. This is always an internal type,
657 used as a fencepost to test against the anonymous-methodness of an
660 2004-10-20 Marek Safar <marek.safar@seznam.cz>
662 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
664 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
666 2004-11-10 Martin Baulig <martin@ximian.com>
668 * expression.cs (Invocation.BetterFunction): If two methods have
669 equal parameter types, but only one of them is generic, the
670 non-generic one wins.
671 (New.DoResolve): Don't set `is_struct' to false if we're a generic
672 instance; just use `Type.IsValueType' to determine whether
673 something is a struct or not.
674 (MemberAccess.DoResolveAsTypeStep): Don't modify the `args' field,
675 so we can be called multiple times.
677 2004-11-10 Martin Baulig <martin@ximian.com>
679 * generic.cs (TypeParameter.DefineConstraints): New public method.
680 (TypeParameter.CheckAccessLevel): Override this and return true.
681 (ConstructedType.ResolveType): Renamed to DoResolveType(), don't
682 override ResolveType() anymore.
683 (ConstructedType.DoResolveAsTypeStep): Call DoResolveType() here.
685 2004-11-10 Martin Baulig <martin@ximian.com>
687 * rootcontext.cs (RootContext.LookupType): If we're a nested type,
688 call DeclSpace.ResolveNestedType() on it.
690 2004-11-10 Martin Baulig <martin@ximian.com>
692 * support.cs (ReflectionParameters.ParameterModifier): If `gpd' is
693 non-null, call ParameterModifier() on it.
695 2004-11-10 Martin Baulig <martin@ximian.com>
698 (Iterators): Added `current_type' and `this_type' fields.
699 (Iterators.DefineIterator): Create a new EmitContext and store it
700 in `ec'; compute `this_type'.
702 2004-11-10 Martin Baulig <martin@ximian.com>
705 (TypeManager.IsPrivateAccessible): New public method.
706 (Closure.Filter): Use IsPrivateAccessible() instead of IsEqual().
708 2004-11-10 Martin Baulig <martin@ximian.com>
710 * class.cs (TypeContainer.DefineType): Call
711 TypeBuilder.DefineGenericParameters() before resolving the type
713 (MethodData.parent_method): New protected field.
714 (MethodData..ctor): Added `MethodInfo parent_method' argument.
715 (MethodData.Define): Compute `parent_method'.
718 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
719 (MemberCore.GetClsCompliantAttributeValue): Likewise.
720 (DeclSpace.ec): New protected field; store the EmitContext here.
721 (DeclSpace.EmitContext): New public property.
722 (DeclSpace.ResolveType): Un-comment from the [Obsolte] attribute.
723 (DeclSpace.ResolveNestedType): New public method.
724 (DeclSpace.ResolveTypeExpr): Just call ResolveAsTypeTerminal() here.
725 (DeclSpace.NestedAccessible): Added `Type tb' argument.
726 (DeclSpace.FamilyAccessible): Likewise.
727 (DeclSpace.FindType): Call ResolveNestedType() for nested types.
728 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
731 * delegate.cs (Delegate.Define): Store the EmitContext in the `ec'
734 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
735 (Enum.Emit): Don't create a new EmitContext.
737 2004-10-18 Martin Baulig <martin@ximian.com>
739 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
740 `Type' directly, but call ResolveType() on it.
741 (Catch.Resolve): Likewise.
742 (Foreach.Resolve): Likewise.
744 2004-10-18 Martin Baulig <martin@ximian.com>
746 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
747 `Type' directly, but call ResolveType() on it.
748 (Probe.DoResolve): Likewise.
749 (ArrayCreation.LookupType): Likewise.
750 (TypeOf.DoResolve): Likewise.
751 (SizeOf.DoResolve): Likewise.
753 2004-10-18 Raja R Harinath <rharinath@novell.com>
755 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
758 2004-10-17 John Luke <john.luke@gmail.com>
760 * class.cs (Operator.GetSignatureForError): use CSharpName
762 * parameter.cs (Parameter.GetSignatureForError): Returns
763 correct name even if was not defined.
765 2004-10-13 Raja R Harinath <rharinath@novell.com>
768 * class.cs (TypeContainer.EmitContext): New property.
769 (DefineNestedTypes): Create an emitcontext for each part.
770 (MethodCore.DoDefineParameters): Use container's emitcontext.
771 Pass type array to InternalParameters.
772 (MemberBase.DoDefine): Use container's emitcontext.
773 (FieldMember.Define): Likewise.
774 (Event.Define): Likewise.
775 (SetMethod.GetParameterInfo): Change argument to EmitContext.
776 Pass type array to InternalParameters.
777 (SetIndexerMethod.GetParameterInfo): Likewise.
778 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
779 * delegate.cs (Define): Pass emitcontext to
780 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
781 array to InternalParameters.
782 * expression.cs (ParameterReference.DoResolveBase): Pass
783 emitcontext to GetParameterInfo.
784 (ComposedCast.DoResolveAsTypeStep): Remove check on
785 ec.ResolvingTypeTree.
786 * parameter.cs (Parameter.Resolve): Change argument to
787 EmitContext. Use ResolveAsTypeTerminal.
788 (Parameter.GetSignature): Change argument to EmitContext.
789 (Parameters.ComputeSignature): Likewise.
790 (Parameters.ComputeParameterTypes): Likewise.
791 (Parameters.GetParameterInfo): Likewise.
792 (Parameters.ComputeAndDefineParameterTypes): Likewise.
793 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
794 * support.cs (InternalParameters..ctor): Remove variant that takes
796 * typemanager.cs (system_intptr_expr): New.
797 (InitExpressionTypes): Initialize it.
799 2004-10-12 Chris Toshok <toshok@ximian.com>
801 * cs-parser.jay: fix location for try_statement and catch_clause.
803 2004-10-18 Martin Baulig <martin@ximian.com>
805 * class.cs (FieldMember.Define): Don't access the TypeExpr's
806 `Type' directly, but call ResolveType() on it.
807 (MemberBase.DoDefine): Likewise.
809 * expression.cs (New.DoResolve): Don't access the TypeExpr's
810 `Type' directly, but call ResolveType() on it.
811 (ComposedCast.DoResolveAsTypeStep): Likewise.
813 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
814 `Type' directly, but call ResolveType() on it.
816 2004-10-17 John Luke <john.luke@gmail.com>
818 * class.cs (Operator.GetSignatureForError): use CSharpName
820 * parameter.cs (Parameter.GetSignatureForError): Returns
821 correct name even if was not defined.
823 2004-10-13 Raja R Harinath <rharinath@novell.com>
826 * class.cs (TypeContainer.EmitContext): New property.
827 (DefineNestedTypes): Create an emitcontext for each part.
828 (MethodCore.DoDefineParameters): Use container's emitcontext.
829 Pass type array to InternalParameters.
830 (MemberBase.DoDefine): Use container's emitcontext.
831 (FieldMember.Define): Likewise.
832 (Event.Define): Likewise.
833 (SetMethod.GetParameterInfo): Change argument to EmitContext.
834 Pass type array to InternalParameters.
835 (SetIndexerMethod.GetParameterInfo): Likewise.
836 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
837 * delegate.cs (Define): Pass emitcontext to
838 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
839 array to InternalParameters.
840 * expression.cs (ParameterReference.DoResolveBase): Pass
841 emitcontext to GetParameterInfo.
842 (ComposedCast.DoResolveAsTypeStep): Remove check on
843 ec.ResolvingTypeTree.
844 * parameter.cs (Parameter.Resolve): Change argument to
845 EmitContext. Use ResolveAsTypeTerminal.
846 (Parameter.GetSignature): Change argument to EmitContext.
847 (Parameters.ComputeSignature): Likewise.
848 (Parameters.ComputeParameterTypes): Likewise.
849 (Parameters.GetParameterInfo): Likewise.
850 (Parameters.ComputeAndDefineParameterTypes): Likewise.
851 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
852 * support.cs (InternalParameters..ctor): Remove variant that takes
854 * typemanager.cs (system_intptr_expr): New.
855 (InitExpressionTypes): Initialize it.
857 2004-10-12 Chris Toshok <toshok@ximian.com>
859 * cs-parser.jay: fix location for try_statement and catch_clause.
861 2004-10-07 Raja R Harinath <rharinath@novell.com>
863 More DeclSpace.ResolveType avoidance.
864 * decl.cs (MemberCore.InUnsafe): New property.
865 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
866 with newly created EmitContext.
867 (FieldMember.Define): Likewise.
868 * delegate.cs (Delegate.Define): Likewise.
869 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
870 only if normal name-lookup fails.
871 (TypeExpr.DoResolve): Enable error-checking.
872 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
873 (SizeOf.DoResolve): Likewise.
874 (ComposedCast.DoResolveAsTypeStep): Likewise.
875 (StackAlloc.DoResolve): Likewise.
876 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
877 (Block.Unsafe): New property.
878 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
879 (Unsafe): Set 'unsafe' flag of contained block.
880 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
881 (Fixed.Resolve): Likewise.
882 (Catch.Resolve): Likewise.
883 (Using.ResolveLocalVariableDecls): Likewise.
884 (Foreach.Resolve): Likewise.
886 2004-10-05 John Luke <john.luke@gmail.com>
888 * cs-parser.jay: add location to error CS0175
890 2004-10-04 Miguel de Icaza <miguel@ximian.com>
892 * ecore.cs (Expression.Constantity): Add support for turning null
895 * const.cs (Const.Define): Allow constants to be reference types
896 as long as the value is Null.
898 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
900 * namespace.cs (NamespaceEntry.Using): No matter which warning
901 level is set, check if this namespace name has already been added.
903 2004-10-03 Ben Maurer <bmaurer@ximian.com>
905 * expression.cs: reftype [!=]= null should always use br[true,false].
908 2004-10-03 Marek Safar <marek.safar@seznam.cz>
911 * attribute.cs: Enum conversion moved to
912 GetAttributeArgumentExpression to be applied to the all
915 2004-10-01 Raja R Harinath <rharinath@novell.com>
917 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
918 * class.c (TypeContainer.DefineType): Flag error if
919 base types aren't accessible due to access permissions.
920 * decl.cs (DeclSpace.ResolveType): Move logic to
921 Expression.ResolveAsTypeTerminal.
922 (DeclSpace.ResolveTypeExpr): Thin layer over
923 Expression.ResolveAsTypeTerminal.
924 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
925 Refactor code into NestedAccess. Use it.
926 (DeclSpace.NestedAccess): New.
927 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
928 argument to silence errors. Check access permissions.
929 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
930 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
931 (Cast.DoResolve): Likewise.
932 (New.DoResolve): Likewise.
933 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
934 (TypeOf.DoResolve): Likewise.
936 * expression.cs (Invocation.BetterConversion): Return the Type of
937 the better conversion. Implement section 14.4.2.3 more faithfully.
938 (Invocation.BetterFunction): Make boolean. Make correspondence to
939 section 14.4.2.2 explicit.
940 (Invocation.OverloadResolve): Update.
941 (Invocation): Remove is_base field.
942 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
943 (Invocation.Emit): Likewise.
945 2004-09-24 Marek Safar <marek.safar@seznam.cz>
947 * cs-parser.jay: Reverted 642 warning fix.
949 2004-09-23 Marek Safar <marek.safar@seznam.cz>
952 * decl.cs (FindMemberWithSameName): Indexer can have more than
955 2004-09-23 Marek Safar <marek.safar@seznam.cz>
957 * expression.cs (LocalVariableReference.DoResolveLValue):
958 Do not report warning 219 for out values.
959 (EmptyExpression.Null): New member to avoid extra allocations.
961 2004-09-23 Marek Safar <marek.safar@seznam.cz>
963 * cs-parser.jay: Fix wrong warning 642 report.
965 * cs-tokenizer.cs (CheckNextToken): New helper;
966 Inspect next character if is same as expected.
968 2004-09-23 Martin Baulig <martin@ximian.com>
970 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
971 (Convert.ImplicitReferenceConversionExists): Likewise.
973 2004-11-09 Raja R Harinath <rharinath@novell.com>
975 * Makefile (DISTFILES): Comment out a few missing files.
977 2004-10-29 Raja R Harinath <rharinath@novell.com>
979 * Makefile (bootstrap_libs,bootstrap_libfiles): New.
980 (bootstrap-libs): New target. Invokes the net_2_0_bootstrap profile.
981 (gmcs.exe): Invoke bootstrap-libs.
982 (clean-local): Clean the net_2_0_bootstrap profile too.
983 (PROGRAM_INSTALL_DIR): New.
984 (install-local): Use it.
986 2004-10-13 Martin Baulig <martin@ximian.com>
988 * generic.cs (TypeManager.InflatedConstraints): New nested class.
989 (TypeParameter.DefineType): If we're a method type parameter and
990 that method is overriding something, "inflate" its constraints.
992 2004-10-12 Martin Baulig <martin@ximian.com>
994 * expression.cs (MemberAccess.DoResolve): If we're a SimpleName
995 and have type arguments, create and resolve a ConstructedType.
997 2004-10-12 Martin Baulig <martin@ximian.com>
999 * decl.cs (MemberCache.FindMemberToOverride): Use
1000 TypeManager.IsEqual() to compare the parameters and Type.Equals()
1001 to compare the invocationType.
1003 * typemanager.cs (TypeManager.IsEqual): Added support for arrays.
1004 When comparing two type parameters, only do the signature-only
1005 comparision for method type parameters.
1007 2004-10-11 Martin Baulig <martin@ximian.com>
1009 * report.cs: Don't make --fatal abort on warnings, we have
1010 -warnaserror for that.
1012 2004-10-11 Martin Baulig <martin@ximian.com>
1015 (TypeManager.IsEqualGenericType): Removed, use IsEqual() instead.
1016 (TypeManager.IsEqual): Call ourself recursively instead of using
1019 2004-10-11 Martin Baulig <martin@ximian.com>
1021 * class.cs (TypeContainer.DefineType): Only call TypeParameter.Define()
1022 on our own type parameters, not on the ones we inherit from a containing
1025 * expression.cs (Invocation.InferType): Use `==', not `Equals()' for
1028 * generic.cs (TypeParameter.Define): We may only be called once.
1030 * pending.cs (Pending.InterfaceMethod): Call TypeManager.Real_IsEqual()
1031 instead of TypeManager.IsEqual().
1033 2004-09-28 Martin Baulig <martin@ximian.com>
1036 (GenericConstraints.EffectiveBaseClass): New public property.
1037 (TypeParameter.GenericConstraints): New public property.
1038 (ConstructedType.CheckConstraints): Improved.
1040 * convert.cs (Convert.TypeParam_EffectiveBaseType): New private method.
1041 (Convert.TypeParameterConversion): New private method; use this in
1042 ImplicitReferenceConversion() and ImplicitReferenceConversionExists()
1043 for all conversions related to type parameters.
1045 2004-09-24 Martin Baulig <martin@ximian.com>
1047 * convert.cs (Convert.ImplicitReferenceConversion): Added implicit
1048 type parameter conversions for type parameters which are known to
1051 2004-09-24 Martin Baulig <martin@ximian.com>
1053 * generic.cs (GenericConstraints): Added `IsReferenceType' and
1054 `IsValueType' properties.
1056 * support.cs (ReflectionConstraints): Use
1057 Type.GetGenericParameterConstraints() instead of the old hack.
1059 2004-09-24 Martin Baulig <martin@ximian.com>
1061 * generic.cs (GenericConstraints): Moved here and made it an
1064 * support.cs (GenericConstraints): Moved to generic.cs.
1066 2004-09-24 Martin Baulig <martin@ximian.com>
1069 (ReflectionConstraints): Un-nested this class and made it public.
1072 (TypeManager.GetTypeParameterConstraints): New public method.
1073 (TypeManager.HasConstructorConstraint): Use the attributes.
1075 2004-09-24 Martin Baulig <martin@ximian.com>
1077 * support.cs (GenericConstraints): Replaced `HasConstructor',
1078 `IsReferenceType' and `IsValueType' with `Attributes'.
1079 (ReflectionParameters.ReflectionConstraints): Removed the Create()
1080 method and made the .ctor public.
1082 * generic.cs (Constraints.Attributes): New public property.
1083 (Constraints): Renamed `HasConstructor' -> `HasConstructorConstraint',
1084 `IsReferenceType' -> `HasReferenceTypeConstraint' and
1085 `IsValueType' -> `HasValueTypeConstraint'.
1087 2004-09-23 Martin Baulig <martin@ximian.com>
1089 * generic.cs (Constraints): Reflect latest runtime changes.
1091 2004-09-23 Martin Baulig <martin@ximian.com>
1093 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
1094 (Convert.ImplicitReferenceConversionExists): Likewise.
1096 2004-09-23 Marek Safar <marek.safar@seznam.cz>
1098 * class.cs (Operator.Define): Add error 448 and 559 report.
1100 2004-09-22 Marek Safar <marek.safar@seznam.cz>
1102 * class.cs (MemberBase.IsTypePermitted): New protected
1103 method for checking error CS0610.
1105 2004-09-22 Marek Safar <marek.safar@seznam.cz>
1107 * class.cs (TypeContainer.HasExplicitLayout): New property
1108 Returns whether container has StructLayout attribute set Explicit.
1109 (FieldMember): New abstract class for consts and fields.
1110 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
1111 (Field): Reuse FieldMember.
1113 * const.cs (Const): Reuse FieldMember.
1115 * rootcontext.cs: EmitConstants call moved to class.
1117 2004-09-22 Martin Baulig <martin@ximian.com>
1119 Marek and me just fixed one of our oldest bugs: #28562 :-)
1121 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
1123 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
1124 we're an EnumConstant, just return that.
1125 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
1126 an EnumConstant. In this case, we need to use GetValueAsEnumType()
1127 to get the value which'll actually be written into the attribute.
1128 However, we have to use GetValue() to access the attribute's value
1131 2004-09-22 Marek Safar <marek.safar@seznam.cz>
1133 * constant.cs (Constant.IsNegative): New abstract property
1136 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
1137 (StackAlloc.DoResolve): Reused IsNegative.
1139 2004-09-22 Martin Baulig <martin@ximian.com>
1141 * typemanager.cs (TypeManager.LookupGenericTypeContainer): New
1142 public method; like LookupTypeContainer, but also works for
1145 * report.cs (Report.SymbolRelatedToPreviousError): Use
1146 TypeManager.LookupGenericTypeContainer().
1148 2004-09-22 Martin Baulig <martin@ximian.com>
1150 Thanks to Peter Sestoft for this bug report.
1152 * expression.cs (Conditional): If both the `trueExpr' and the
1153 `falseExpr' is a NullLiteral, return a NullLiteral.
1155 2004-09-22 Martin Baulig <martin@ximian.com>
1157 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
1158 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
1159 for the "get_Current" call.
1161 2004-09-21 Martin Baulig <martin@ximian.com>
1163 * convert.cs (Convert.ImplicitReferenceConversion): When
1164 converting to an interface type, first check whether we're
1165 converting from a reference type.
1167 2004-09-14 Martin Baulig <martin@ximian.com>
1169 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
1171 2004-09-14 Marek Safar <marek.safar@seznam.cz>
1174 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
1175 called and is obsolete then this member suppress message
1176 when call is inside next [Obsolete] method or type.
1178 * expression.cs: Use TestObsoleteMethodUsage member.
1180 2004-09-14 Martin Baulig <martin@ximian.com>
1182 * genericparser.cs: Removed.
1184 2004-09-13 Marek Safar <marek.safar@seznam.cz>
1186 * class.cs (MethodCore.CheckBase): Fix bug #65757.
1188 2004-09-12 Marek Safar <marek.safar@seznam.cz>
1190 * attribute.cs (Attribute.Resolve): Add error 653 report.
1192 * class.cs (Class.ApplyAttributeBuilder): Add error 641
1194 (Method.ApplyAttributeBuilder): Add error 685 report.
1195 (Operator.Define): Add error 564 report.
1197 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
1199 * expression.cs (Invocation.DoResolve): Add error
1202 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
1205 2004-09-11 Marek Safar <marek.safar@seznam.cz>
1207 * class.cs (ConstructorInitializer.Resolve):
1208 Wrong error number (515->516).
1210 2004-09-11 Marek Safar <marek.safar@seznam.cz>
1212 * class.cs (Indexer.Define): Add error 631 report.
1214 2004-09-11 Marek Safar <marek.safar@seznam.cz>
1216 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
1218 2004-09-11 Marek Safar <marek.safar@seznam.cz>
1220 * expression.cs (Probe.DoResolve): Add error CS0241 report.
1222 2004-09-10 Marek Safar <marek.safar@seznam.cz>
1224 * cs-parser.jay: Added error CS0241 report.
1226 2004-09-10 Raja R Harinath <rharinath@novell.com>
1228 * cs-parser.jay (fixed_statement): Introduce a scope for the
1229 declaration in the 'fixed' statement.
1231 2004-09-09 Marek Safar <marek.safar@seznam.cz>
1233 * cs-parser.jay: Added CS0230 error report.
1235 2004-09-09 Marek Safar <marek.safar@seznam.cz>
1237 * cs-parser.jay: Added errors CS0231 and CS0257 report.
1239 2004-09-09 Marek Safar <marek.safar@seznam.cz>
1241 * expression.cs (Argument.Resolve): Added error CS0192 and
1244 2004-09-09 Marek Safar <marek.safar@seznam.cz>
1246 C# 2.0 #pragma warning feature
1248 * cs-tokenizer.cs (PreProcessPragma): New method;
1249 Handles #pragma directive.
1251 * report.cs (WarningRegions): New class; Support
1252 class for #pragma warning directive. It tests whether
1253 warning is enabled for a given line.
1255 2004-09-08 Miguel de Icaza <miguel@ximian.com>
1257 * const.cs: Add more descriptive error report, tahnks to
1260 2004-09-08 Marek Safar <marek.safar@seznam.cz>
1262 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
1264 2004-09-07 Miguel de Icaza <miguel@ximian.com>
1266 * expression.cs: Apply patch from Ben: Remove dead code from
1267 ArrayCreation, and remove the TurnintoConstant call in const.cs,
1268 as that code just threw an exception anwyays.
1270 * const.cs: Remove the call to the turnintoconstant, for details
1273 * literal.cs: The type of the null-literal is the null type; So
1274 we use a placeholder type (literal.cs:System.Null, defined here)
1277 * expression.cs (Conditional.DoResolve): Remove some old code that
1278 is no longer needed, conversions have been fixed.
1280 (ArrayCreationExpression.DoResolve): Return false if we fail to
1281 resolve the inner expression.
1283 2004-09-07 Raja R Harinath <rharinath@novell.com>
1286 * cs-parser.jay (delegate_declaration): Record a delegate
1287 declaration as a type declaration.
1288 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
1290 2004-09-06 Miguel de Icaza <miguel@ximian.com>
1292 * parameter.cs: Do not crash if the type can not be resolved.
1294 * expression.cs: Report errors with unsafe pointers, fixes #64896
1296 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
1298 * expression.cs: Pointer arith always needs to do a conv.i
1299 if the operand is a long. fix 65320
1301 2004-09-04 Marek Safar <marek.safar@seznam.cz>
1303 Fixed cs0619-37.cs, cs0619-38.cs
1305 * enum.cs (GetObsoleteAttribute): Removed.
1307 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
1308 on Enum member is double staged. The first is tested member
1311 2004-09-04 Marek Safar <marek.safar@seznam.cz>
1313 Fixed #56986, #63631, #65231
1315 * class.cs: (TypeContainer.AddToMemberContainer): New method,
1316 adds member to name container.
1317 (TypeContainer.AddToTypeContainer): New method, adds type to
1319 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
1320 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
1321 AddOperator): Simplified by reusing AddToMemberContainer.
1322 (TypeContainer.UserDefinedStaticConstructor): Changed to property
1324 (Method.CheckForDuplications): Fixed implementation to test all
1326 (MemberBase): Detection whether member is explicit interface
1327 implementation is now in constructor.
1328 (MemberBase.UpdateMemberName): Handles IndexerName.
1329 (Accessor): Changed to keep also location information.
1330 (AbstractPropertyEventMethod): Is derived from MemberCore.
1331 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
1332 will be emited or not.
1333 (PropertyBase.AreAccessorsDuplicateImplementation):
1334 Tests whether accessors are not in collision with some method.
1335 (Operator): Is derived from MethodCore to simplify common
1338 * decl.cs (Flags.TestMethodDuplication): Test for duplication
1340 (DeclSpace.AddToContainer): Adds the member to defined_names
1341 table. It tests for duplications and enclosing name conflicts.
1343 * enum.cs (EnumMember): Clean up to reuse the base structures
1345 2004-09-03 Martin Baulig <martin@ximian.com>
1347 Merged latest changes into gmcs. Please keep this comment in
1348 here, it makes it easier for me to see what changed in MCS since
1349 the last time I merged.
1351 2004-09-03 Martin Baulig <martin@ximian.com>
1353 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
1354 into TypeContainer, to make partial classes work again.
1356 2004-09-03 Martin Baulig <martin@ximian.com>
1358 * rootcontext.cs (RootContext.V2): Removed.
1360 2004-03-23 Martin Baulig <martin@ximian.com>
1362 * expression.cs (Invocation.OverloadResolve): Added `bool
1363 may_fail' argument and use it instead of the Location.IsNull() hack.
1365 2004-09-09 Martin Baulig <martin@ximian.com>
1367 * cs-parser.jay (namespace_declaration): Fixed CS0134 reporting.
1369 2004-09-09 Martin Baulig <martin@ximian.com>
1371 * generic.cs (TypeParameter.DefineType): Added support for
1372 explicit interface methods.
1374 2004-09-09 Martin Baulig <martin@ximian.com>
1376 * README.Changes: New document. Started to list important changes
1377 between MCS and GMCS here.
1379 2004-09-08 Martin Baulig <martin@ximian.com>
1382 (TypeContainer.CheckRecursiveDefinition): New protected method.
1383 (TypeContainer.DefineType): Move the CS0146 check into
1384 CheckRecursiveDefinition().
1386 2004-09-06 Martin Baulig <martin@ximian.com>
1388 * generic.cs (ConstructedType.CheckConstraints): Allow builtin
1389 types for the constructor constraint.
1391 2004-09-03 Martin Baulig <martin@ximian.com>
1393 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
1394 into TypeContainer, to make partial classes work again.
1396 2004-09-03 Martin Baulig <martin@ximian.com>
1398 * rootcontext.cs (RootContext.V2): Removed.
1400 2004-03-23 Martin Baulig <martin@ximian.com>
1402 * expression.cs (Invocation.OverloadResolve): Added `bool
1403 may_fail' argument and use it instead of the Location.IsNull() hack.
1405 2004-09-03 Martin Baulig <martin@ximian.com>
1407 Merged latest changes into gmcs. Please keep this comment in
1408 here, it makes it easier for me to see what changed in MCS since
1409 the last time I merged.
1411 2004-09-03 Raja R Harinath <rharinath@novell.com>
1414 * expression.cs (BetterConversion): Don't allow either conversion
1415 to be null. Remove redundant implicit conversion test when 'q ==
1416 null' -- when this function is invoked, we already know that the
1417 implicit conversion exists.
1418 (BetterFunction): Assume that 'best' is non-null. Remove
1419 redundant reimplementation of IsApplicable when 'best' is null.
1420 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
1421 number of arguments.
1422 (IsAncestralType): Extract from OverloadResolve.
1423 (OverloadResolve): Make robust to the MethodGroupExpr being
1424 unsorted. Implement all the logic of Section 14.5.5.1, and
1425 support overloading of methods from multiple applicable types.
1426 Clean up logic somewhat. Don't pass null methods to BetterFunction.
1428 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
1429 (RealError, Warning): Append type of report to related symbol.
1431 2004-09-03 Marek Safar <marek.safar@seznam.cz>
1433 * enum.cs: Fixed CLS-Compliance checks for enum members.
1434 Error tests cs3008-8.cs, cs3014-8.cs
1436 2004-09-02 Marek Safar <marek.safar@seznam.cz>
1438 Fixed bug #62342, #63102
1439 * class.cs: ImplementIndexer uses member.IsExplicitImpl
1440 like ImplementMethod.
1442 2004-09-02 Marek Safar <marek.safar@seznam.cz>
1444 * attribute.cs (Attribute.GetAttributeArgumentExpression):
1447 2004-09-02 Martin Baulig <martin@ximian.com>
1449 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
1450 TypeManager.GetArgumentTypes() rather than calling GetParameters()
1453 2004-09-01 Marek Safar <marek.safar@seznam.cz>
1455 C# 2.0 Static classes implemented
1457 * class.cs (TypeContainer): instance_constructors,
1458 initialized_fields, initialized_static_fields,
1459 default_constructor, base_inteface_types are protected to be
1460 accessible from StaticClass.
1461 (TypeContainer.DefineDefaultConstructor): New virtual method
1462 for custom default constructor generating
1463 (StaticClass): New class to handle "Static classes" feature.
1465 * cs-parser.jay: Handle static keyword on class like instance
1468 * driver.cs: Added "/langversion" command line switch with two
1469 options (iso-1, default).
1471 2004-08-31 Marek Safar <marek.safar@seznam.cz>
1473 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
1475 2004-08-31 Miguel de Icaza <miguel@ximian.com>
1477 * delegate.cs: Style.
1479 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
1481 * delegate.cs: Add seperate instance expr field for miguel.
1483 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
1485 * PointerArithmetic (Resolve): make sure we are not doing
1486 pointer arith on void*. Also, make sure we are resolved
1487 by not setting eclass until resolve.
1489 All callers: Make sure that PointerArithmetic gets resolved.
1491 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
1493 * ArrayCreation (LookupType): If the type does not resolve
1494 to an array, give an error.
1496 2004-08-27 Marek Safar <marek.safar@seznam.cz>
1498 * statement.cs (Try.Resolve): Fixed bug #64222
1500 2004-08-27 Martin Baulig <martin@ximian.com>
1503 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
1506 2004-08-26 Marek Safar <marek.safar@seznam.cz>
1508 * ecore.cs (Constantify): Get underlying type via
1509 System.Enum.GetUnderlyingType to avoid StackOverflow on the
1510 Windows in special cases.
1512 2004-08-26 Marek Safar <marek.safar@seznam.cz>
1514 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
1515 for obtaining also private methods.
1516 (GetRemoveMethod): Used GetRemoveMethod (true)
1517 for obtaining also private methods.
1519 2004-09-02 Martin Baulig <martin@ximian.com>
1521 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
1522 TypeManager.GetArgumentTypes() rather than calling GetParameters()
1525 2004-08-27 Martin Baulig <martin@ximian.com>
1528 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
1531 2004-08-25 Martin Baulig <martin@ximian.com>
1533 * support.cs (ReflectionParameters..ctor): If this is a generic
1534 method, retrieve and store its type parameters.
1535 (InternalParameters..ctor): Added `TypeParameter[]' argument.
1536 (ReflectionParameters.GenericConstraints): The argument specifies
1537 the type parameter, not the method parameter.
1538 (InternalParameters.GenericConstraints): Likewise.
1540 * generic.cs (TypeParameter.DefineType): Correctly handle
1541 constraints wrt. generic methods in interfaces and their
1544 2004-08-24 Martin Baulig <martin@ximian.com>
1546 * generic.cs (TypeParameter.IsSubclassOf): New public method.
1547 (Constraints.IsSubclassOf): New internal method.
1549 * typemanager.cs (TypeManager.FindMembers): Added special support
1550 for GenericTypeParameterBuilder's.
1551 (TypeManager.IsSubclassOf, IsFamilyAccessible): Added support for
1554 2004-08-24 Martin Baulig <martin@ximian.com>
1557 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
1558 this for accessibility checks.
1559 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
1560 IsNestedFamilyAccessible.
1561 (TypeManager.IsSubclassOf): New method, do what the name actually
1564 2004-08-24 Martin Baulig <martin@ximian.com>
1566 * expression.cs (MemberAccess.DoResolve): When resolving ourselves
1567 as a SimpleName, include the generic arity.
1569 2004-08-24 Martin Baulig <martin@ximian.com>
1571 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
1572 MethodAttributes.HideBySig for operators.
1574 2004-08-23 Martin Baulig <martin@ximian.com>
1576 Back to the old error reporting system :-)
1578 * report.cs (Message): Removed.
1579 (Report.MessageData, ErrorData, WarningData): Removed.
1580 (Report.Error, Warning): Back to the old system.
1582 2004-08-23 Martin Baulig <martin@ximian.com>
1584 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
1586 * class.cs (TypeContainer.ParentContainer): New public virtual
1587 method; replaces the explicit interface implementation.
1588 (ClassPart.ParentContainer): Override.
1590 2004-08-23 Martin Baulig <martin@ximian.com>
1592 * statement.cs (Switch): Added support for constant switches; see
1593 #59428 or test-285.cs.
1595 2004-08-22 Marek Safar <marek.safar@seznam.cz>
1598 * statement.cs (GetEnumeratorFilter): Removed useless
1599 logic because C# specs is strict. GetEnumerator must be
1602 2004-08-22 Martin Baulig <martin@ximian.com>
1604 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
1605 a switch and may break, reset the barrier. Fixes #59867.
1607 2004-08-22 Marek Safar <marek.safar@seznam.cz>
1609 CLS-Compliance speed up (~5% for corlib)
1611 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
1612 New method. Tests container for CLS-Compliant names
1614 * class.cs (TypeContainer.VerifyClsName): New method.
1615 Checks whether container name is CLS Compliant.
1616 (Constructor): Implements IMethodData.
1618 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
1619 low-case table for CLS Compliance test.
1620 (MemberCache.VerifyClsParameterConflict): New method.
1621 Checks method parameters for CS3006 error.
1623 * enum.cs (EnumMember): Is derived from MemberCore.
1624 (Enum.VerifyClsName): Optimized for better performance.
1626 2004-08-06 Marek Safar <marek.safar@seznam.cz>
1628 * report.cs: Renamed Error_T to Error and changed all
1631 2004-08-06 Marek Safar <marek.safar@seznam.cz>
1633 * class.cs (TypeContainer.IndexerArrayList): New inner class
1634 container for indexers.
1635 (TypeContainer.DefaultIndexerName): New constant for default
1636 indexer name. Replaced all "Item" with this constant.
1637 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
1639 * typemanager.cs (TypeManager.default_member_ctor): Cache here
1640 DefaultMemberAttribute constructor.
1642 2004-08-05 Martin Baulig <martin@ximian.com>
1644 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
1647 2004-08-05 Marek Safar <marek.safar@seznam.cz>
1649 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
1650 multi platforms problem.
1652 * compiler.csproj: Included shared files.
1654 2004-08-04 Marek Safar <marek.safar@seznam.cz>
1656 Fix bug 60333, 55971 in the more general way
1657 * attribute.cs (Attribute.GetAttributeArgumentExpression):
1658 Added arg_type argument for constant conversion.
1659 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
1661 2004-08-04 Marek Safar <marek.safar@seznam.cz>
1664 * class.cs (TypeContainer ): New inner classes MethodArrayList,
1665 OperatorArrayList, MethodCoreArrayList for typecontainer
1666 containers. Changed class member types to these new types.
1667 (MethodArrayList.DefineMembers): Added test for CS0659.
1669 2004-08-04 Miguel de Icaza <miguel@ximian.com>
1671 * cfold.cs: Synchronize the folding with the code in expression.cs
1672 Binary.DoNumericPromotions for uint operands.
1674 * attribute.cs: Revert patch from Raja, it introduced a regression
1675 while building Blam-1.2.1 (hard to isolate a test case).
1677 2004-08-04 Marek Safar <marek.safar@seznam.cz>
1681 (TypeContainer.Define): Renamed to DefineContainerMembers because of
1683 (MethodCore.parent_method): New member. The method we're overriding
1684 if this is an override method.
1685 (MethodCore.CheckBase): Moved from Method class and made common.
1686 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
1688 (MethodCore.CheckForDuplications): New abstract method. For custom
1689 member duplication search in a container
1690 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
1691 method and its return type.
1692 (Event.conflict_symbol): New member. Symbol with same name in the
1696 (MemberCache.FindMemberWithSameName): New method. The method
1697 is looking for conflict with inherited symbols.
1699 2004-08-04 Martin Baulig <martin@ximian.com>
1701 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
1703 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
1705 2004-08-03 Marek Safar <marek.safar@seznam.cz>
1707 * report.cs (Message): New enum for better error, warning reference in
1709 (MessageData): New inner abstract class. It generally handles printing of
1710 error and warning messages.
1711 Removed unused Error, Warning, Message methods.
1713 2004-08-03 Marek Safar <marek.safar@seznam.cz>
1715 Fix for cs0592-8.cs test
1717 (Attributable.ValidAttributeTargets): Made public.
1718 (Attribute.ExplicitTarget): New member for explicit target value.
1719 (Attribute.CheckTargets): Now we translate explicit attribute
1720 target to Target here.
1722 2004-08-03 Ben Maurer <bmaurer@ximian.com>
1724 * ecore.cs (MethodGroupExpr): new IsBase property.
1726 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
1728 * delegate.cs (DelegateCreation): store a MethodGroupExpr
1729 rather than an instance expr.
1731 (DelegateCreation.Emit): Use the method group rather than
1732 the instance expression. Also, if you have base.Foo as the
1733 method for a delegate, make sure to emit ldftn, not ldftnvirt.
1735 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
1737 (NewDelegate.DoResolve): Only check for the existance of Invoke
1738 if the method is going to be needed. Use MethodGroupExpr.
1740 (NewDelegate.Emit): Remove, DelegateCreation implements this.
1742 * expression.cs: For pointer arith., make sure to use
1743 the size of the type, not the size of the pointer to
1746 2004-08-03 Marek Safar <marek.safar@seznam.cz>
1749 * class.cs (Class): Added error CS0502 test.
1751 2004-08-03 John Luke <jluke@cfl.rr.com>
1752 Raja R Harinath <rharinath@novell.com>
1755 * attribute.cs (Attribute.complained_before): New flag.
1756 (Attribute.ResolveType, Attribute.Resolve),
1757 (Attribute.DefinePInvokeMethod): Set it.
1758 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
1760 2004-08-03 Martin Baulig <martin@ximian.com>
1762 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
1763 use a user-defined operator; we still need to do numeric
1764 promotions in case one argument is a builtin type and the other
1765 one has an implicit conversion to that type. Fixes #62322.
1767 2004-08-18 Martin Baulig <martin@ximian.com>
1769 * class.cs (Method.Define): Use the correct method name when
1770 creating the MethodBuilder for a generic method.
1772 2004-08-17 Martin Baulig <martin@ximian.com>
1774 * generic.cs (Constraints): Support type parameter constraints.
1776 2004-08-16 Martin Baulig <martin@ximian.com>
1778 * cs-tokenizer.cs (Tokenizer.TypeOfParsing): New public property.
1779 (Token.GENERIC_DIMENSION): New token; this is returned if we
1780 encounter an unbound generic type in a typeof() expression.
1782 * cs-parser.jay (opt_type_argument_list): Added GENERIC_DIMENSION;
1783 this token is only generated while parsing a typeof() expression.
1784 (typeof_expression): Removed the old unbound_type hack.
1786 * generic.cs (TypeArguments.IsUnbound): New public property.
1788 * decl.cs (MemberName): Added support for unbound types.
1790 2004-08-14 Martin Baulig <martin@ximian.com>
1793 (TypeManager.IsEqualGenericInstance): New static method.
1794 (TypeManager.IsSubclassOrNestedChildOf, IsSubclassOf): This is
1795 just used to check accessibility, so follow the rules of 26.1.6.
1797 * expression.cs (MemberAccess.ResolveAsTypeStep): Return a
1798 ConstructedType instead of a TypeExpression if we have type arguments.
1800 * cs-parser.jay (typeof_expression): Support unbound generic types.
1802 * ecore.cs (UnboundTypeExpression): New public class.
1804 2004-08-12 Martin Baulig <martin@ximian.com>
1806 * typemanager.cs (TypeManager.IsNestedChildOf): Use
1807 TypeManager.IsEqual() rather than `=='.
1809 * decl.cs (DeclSpace.CheckAccessLevel): Use `tb.FullName' for
1810 generic instances as well.
1812 2004-08-12 Martin Baulig <martin@ximian.com>
1814 * expression.cs (Invocation.InferType): We can only infer method
1815 type parameters. Fixes #62647.
1817 2004-08-11 Martin Baulig <martin@ximian.com>
1819 * class.cs (TypeContainer.DefineType): Create the TypeBuilder
1820 before resolving the base classes.
1822 2004-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
1824 * Makefile: install .mdb file too.
1826 2004-08-05 Martin Baulig <martin@ximian.com>
1828 * ecore.cs (FieldExpr.DoResolveLValue): If we're resolving a field
1829 initializer, the current type is just the TypeBuilder, not the
1830 instantiated generic type.
1831 (FieldExpr.IsFieldInitializer): New public property.
1833 2004-08-04 Martin Baulig <martin@ximian.com>
1835 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
1837 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
1839 2004-08-03 Martin Baulig <martin@ximian.com>
1841 * class.cs (MethodData.Define): If we're an explicit
1842 implementation, remove the generic arity from the type name.
1844 2004-08-03 Martin Baulig <martin@ximian.com>
1846 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
1847 use a user-defined operator; we still need to do numeric
1848 promotions in case one argument is a builtin type and the other
1849 one has an implicit conversion to that type. Fixes #62322.
1851 2004-08-02 Martin Baulig <martin@ximian.com>
1853 * class.cs (TypeContainer.ifaces): Make this a `Type[]', not a
1855 (TypeContainer.GetClassBases): Return the unexpanded list of
1856 interfaces; we expand them later.
1857 (TypeContainer.DefineType): After creating the TypeBuilder, call
1858 TypeManager.ExpandInterfaces() to get an expanded and resolved
1861 * ecore.cs (TypeExpr.GetInterfaces): Removed
1863 * generics.cs (Constraints.InterfaceConstraints): Remove.
1864 (TypeParameter.DefineType): Call TypeManager.RegisterBuilder() to
1865 register the interface constraints.
1868 (TypeManager.AddUserType): Removed the `ifaces' argument.
1869 (TypeManager.AddTypeParameter): Likewise.
1870 (TypeManager.AddUserInterface): Removed, was unused.
1871 (TypeManager.RegisterBuilder): Take a `Type[]' instead of a
1872 `TypeExpr[]' array for the interfaces.
1873 (TypeManager.ExpandInterfaces): Call this after the TypeBuilder
1874 has been defined, returns a list of the resolved interfaces types.
1875 (TypeManager.GetInterfaces): Return a `Type[]', not a `TypeExpr[]'.
1876 (TypeManager.GetExplicitInterfaces): Likewise.
1878 2004-08-02 Martin Baulig <martin@ximian.com>
1880 * expression.cs (Invocation.EmitCall): If we're invoking a method
1881 on a type parameter, use the new `Constrained' prefix opcode.
1883 2004-08-02 Martin Baulig <martin@ximian.com>
1885 * statement.cs (LocalInfo.Flags): Added `IsThis'.
1886 (LocalInfo.IsThis): New public property.
1887 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
1889 2004-08-01 Martin Baulig <martin@ximian.com>
1891 * class.cs (TypeContainer.GetClassBases): Don't set the default
1892 here since we may get called from GetPartialBases().
1893 (TypeContainer.DefineType): If GetClassBases() didn't return a
1894 parent, use the default one.
1896 2004-07-30 Martin Baulig <martin@ximian.com>
1898 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
1900 * class.cs (SourceMethod): New public class, derive from the
1901 symbol writer's ISourceMethod.
1902 (Method): Use the new symbol writer API.
1904 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
1905 as argument and use the new symbol writer.
1908 (SourceFile): Implement the symbol writer's ISourceFile.
1909 (Location.SymbolDocument): Removed.
1910 (Location.SourceFile): New public property.
1912 * symbolwriter.cs: Use the new symbol writer API.
1914 2004-07-30 Raja R Harinath <rharinath@novell.com>
1916 * Makefile (install-local): Remove. Functionality moved to
1919 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
1921 * Makefile: Install mcs.exe.config file together with mcs.exe.
1922 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
1923 correct runtime version.
1925 2004-07-25 Martin Baulig <martin@ximian.com>
1928 (TypeContainer.RegisterOrder): Removed, this was unused.
1929 (TypeContainer, interface_order): Removed.
1930 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
1931 TypeContainer as argument since we can also be called with a
1932 `PartialContainer' for a partial class/struct/interface.
1933 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
1934 of checking whether we're an `Interface' - we could be a
1936 (PartialContainer.Register): Override; call
1937 AddClass()/AddStruct()/AddInterface() on our parent.
1939 * cs-parser.jay (interface_member_declaration): Add things to the
1940 `current_container', not the `current_class'.
1942 * rootcontext.cs (RegisterOrder): The overloaded version which
1943 takes an `Interface' was unused, removed.
1945 * typemanager.cs (TypeManager.LookupInterface): Return a
1946 `TypeContainer', not an `Interface'.
1947 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
1948 contain a `PartialContainer' for an interface, so check it's
1949 `Kind' to figure out what it is.
1951 2004-07-25 Martin Baulig <martin@ximian.com>
1953 * class.cs (Class.DefaultTypeAttributes): New public constant.
1954 (Struct.DefaultTypeAttributes): Likewise.
1955 (Interface.DefaultTypeAttributes): Likewise.
1956 (PartialContainer.TypeAttr): Override this and add the
1957 DefaultTypeAttributes.
1959 2004-07-25 Martin Baulig <martin@ximian.com>
1961 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
1962 we can just use the `Parent' field instead.
1964 2004-07-25 Martin Baulig <martin@ximian.com>
1966 * class.cs (TypeContainer.Emit): Renamed to EmitType().
1968 2004-07-25 Martin Baulig <martin@ximian.com>
1970 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
1971 our parts before defining any methods.
1972 (TypeContainer.VerifyImplements): Make this virtual.
1973 (ClassPart.VerifyImplements): Override and call VerifyImplements()
1974 on our PartialContainer.
1976 2004-07-25 Martin Baulig <martin@ximian.com>
1978 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
1980 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
1981 argument, we can just use the `Parent' field instead.
1984 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
1985 (MemberBase.DoDefine): Likewise.
1987 2004-07-24 Martin Baulig <martin@ximian.com>
1989 * decl.cs (MemberCore.Parent): New public field.
1990 (DeclSpace.Parent): Moved to MemberCore.
1992 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
1993 (MemberBase.ctor): Added TypeContainer argument, pass it to our
1995 (FieldBase, Field, Operator): Likewise.
1996 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
1997 (EventField, Event): Likewise.
1999 2004-07-23 Martin Baulig <martin@ximian.com>
2001 * class.cs (PartialContainer): New public class.
2002 (ClassPart): New public class.
2003 (TypeContainer): Added support for partial classes.
2004 (TypeContainer.GetClassBases): Splitted some of the functionality
2005 out into GetNormalBases() and GetPartialBases().
2007 * cs-tokenizer.cs (Token.PARTIAL): New token.
2008 (Tokenizer.consume_identifier): Added some hacks to recognize
2009 `partial', but only if it's immediately followed by `class',
2010 `struct' or `interface'.
2012 * cs-parser.jay: Added support for partial clases.
2014 2004-07-23 Martin Baulig <martin@ximian.com>
2016 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
2017 a `DeclSpace' and also made it readonly.
2018 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
2019 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
2020 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
2022 * cs-parser.jay: Pass the `current_class', not the
2023 `current_container' (at the moment, this is still the same thing)
2024 to a new Method, Property, Event, Indexer or Constructor.
2026 2004-07-23 Martin Baulig <martin@ximian.com>
2028 * cs-parser.jay (CSharpParser): Added a new `current_class' field
2029 and removed the `current_interface' one.
2030 (struct_declaration, class_declaration, interface_declaration):
2031 Set `current_class' to the newly created class/struct/interface;
2032 set their `Bases' and call Register() before parsing their body.
2034 2004-07-23 Martin Baulig <martin@ximian.com>
2036 * class.cs (Kind): New public enum.
2037 (TypeContainer): Made this class abstract.
2038 (TypeContainer.Kind): New public readonly field.
2039 (TypeContainer.CheckDef): New public method; moved here from
2041 (TypeContainer.Register): New public abstract method.
2042 (TypeContainer.GetPendingImplementations): New public abstract
2044 (TypeContainer.GetClassBases): Removed the `is_class' and
2045 `is_iface' parameters.
2046 (TypeContainer.DefineNestedTypes): Formerly known as
2048 (ClassOrStruct): Made this class abstract.
2050 * tree.cs (RootTypes): New public type.
2052 2004-07-20 Martin Baulig <martin@ximian.com>
2054 * tree.cs (Tree.RecordNamespace): Removed.
2055 (Tree.Namespaces): Removed.
2057 * rootcontext.cs (RootContext.IsNamespace): Removed.
2059 * cs-parser.jay (namespace_declaration): Just create a new
2060 NamespaceEntry here.
2062 2004-07-21 Lluis Sanchez Gual <lluis@novell.com>
2064 * Makefile: Install gmcs.exe.config file together with gmcs.exe.
2065 * gmcs.exe.config: Renamed from mcs.exe.config. Added supportedRuntime
2066 entry to make sure it runs in the correct runtime version.
2068 2004-07-18 Martin Baulig <martin@ximian.com>
2070 * generic.cs (ConstructedType.CheckConstraints): Improved
2071 constraints checking.
2073 2004-07-18 Martin Baulig <martin@ximian.com>
2075 * expression.cs (Invocation.BetterMethod): Call
2076 TypeManager.TypeToCoreType() on all types and removed my previous
2077 hack; we're already doig the right thing here.
2079 2004-07-17 Martin Baulig <martin@ximian.com>
2081 * decl.cs (MemberName.MakeName): Create the "class`1" names here.
2083 2004-07-16 Martin Baulig <martin@ximian.com>
2085 * iterators.cs: Added generics support.
2087 2004-07-16 Martin Baulig <martin@ximian.com>
2089 * iterators.cs: Rewrote this. We're now using one single Proxy
2090 class for both the IEnumerable and the IEnumerator interface and
2091 `Iterator' derives from Class so we can use the high-level API.
2093 * class.cs (TypeContainer.AddIterator): New method.
2094 (TypeContainer.DoDefineType): New protected virtual method, which
2095 is called from DefineType().
2096 (TypeContainer.DoDefineMembers): Call DefineType() and
2097 DefineMembers() on all our iterators.
2098 (TypeContainer.Emit): Call Emit() on all our iterators.
2099 (TypeContainer.CloseType): Call CloseType() on all our iterators.
2101 * codegen.cs (EmitContext.CurrentIterator): New public field.
2103 2004-07-15 Martin Baulig <martin@ximian.com>
2106 (TypeManager.not_supported_exception_type): New type.
2108 2004-07-14 Martin Baulig <martin@ximian.com>
2111 (TypeManager.generic_ienumerable_type): New type.
2112 (TypeManager.generic_ienumerator_type): New type.
2115 (RootContext.interfaces_first_stage): Added
2116 "System.Collections.Generic.IEnumerator`1" and
2117 "System.Collections.Generic.IEnumerable`1".
2119 2004-07-14 Martin Baulig <martin@ximian.com>
2121 * iterators.cs: Use real error numbers.
2123 2004-07-14 Martin Baulig <martin@ximian.com>
2125 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
2126 requires this to be a System.Collection.IEnumerable and not a
2127 class implementing that interface.
2128 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
2130 2004-07-13 Marek Safar <marek.safar@seznam.cz>
2132 * class.cs: Fixed previous fix, it broke some error tests.
2134 2004-07-12 Martin Baulig <martin@ximian.com>
2136 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
2139 2004-07-14 Martin Baulig <martin@ximian.com>
2141 * decl.cs, expression.cs, generic.cs: Use a backqoute (`) and not
2142 an exclamation mark (!) for the generic arity to reflect the
2143 latest spec changes; ie. use "System.Collections.Generic.IList`1".
2145 2004-07-13 Martin Baulig <martin@ximian.com>
2147 * cs-tokenizer.cs (Tokenizer.parse_less_than): Allow array rank
2148 specifiers being part of a type argument.
2150 2004-07-13 Martin Baulig <martin@ximian.com>
2152 * expression.cs (MemberAccess.ResolveAsTypeStep): Use the full `!'
2153 name for generic types.
2155 2004-07-13 Martin Baulig <martin@ximian.com>
2157 * assign.cs (Assign.DoResolve): Moved the CS0131 check up a little
2160 2004-07-09 Miguel de Icaza <miguel@ximian.com>
2162 * assign.cs (LocalTemporary): Add new argument: is_address,If
2163 `is_address' is true, then the value that we store is the address
2164 to the real value, and not the value itself.
2166 * ecore.cs (PropertyExpr): use the new local temporary
2167 stuff to allow us to handle X.Y += z (where X is a struct)
2169 2004-07-08 Martin Baulig <martin@ximian.com>
2171 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
2172 not always return, just like we're doing in Using.Resolve().
2174 2004-07-07 Miguel de Icaza <miguel@ximian.com>
2176 * cs-parser.jay (fixed_statement): flag this as Pinned.
2178 2004-07-06 Miguel de Icaza <miguel@ximian.com>
2180 * typemanager.cs (TypeManager): Removed MakePinned method, this
2181 mechanism is replaced with the .NET 2.x compatible mechanism of
2182 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
2184 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
2185 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
2186 `IsFixed' property which has a different meaning.
2188 2004-07-02 Raja R Harinath <rharinath@novell.com>
2190 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
2191 visible from inside a nested class, not just the names of the
2192 immediately enclosing class.
2195 2004-06-24 Raja R Harinath <rharinath@novell.com>
2197 * expression.cs (BetterConversion): Remove buggy special-case
2198 handling of "implicit constant expression conversions". At this
2199 point, we already know that the conversion is possible -- we're
2200 only checking to see which is better.
2202 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2204 * cs-parser.jay: Added error CS0210 test.
2206 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2208 * cs-parser.jay: Added error CS0134 test.
2210 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2213 * cs-parser.jay: Added error CS0145 test.
2215 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2217 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
2219 2004-06-23 Ben Maurer <bmaurer@ximian.com>
2221 * expression.cs (StackAlloc.Resolve): The argument may not
2222 be a constant; deal with this case.
2224 2004-06-23 Marek Safar <marek.safar@seznam.cz>
2226 * attribute.cs (IndexerName_GetIndexerName): Renamed to
2227 GetIndexerAttributeValue.
2228 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
2230 * class.cs (Indexer.Define): Added error tests for CS0415,
2233 2004-06-23 Miguel de Icaza <miguel@ximian.com>
2235 * attribute.cs (Attribute.Resolve): Keep field code in sync with
2238 2004-06-23 Martin Baulig <martin@ximian.com>
2240 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
2241 neither return nor throw, reset the barrier as well. Fixes #60457.
2243 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
2245 * class.cs : EventAttributes is now set to None by default.
2246 This fixes bug #60459.
2248 2004-06-18 Marek Safar <marek.safar@seznam.cz>
2251 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
2252 Don't throw exception but return null (it's sufficient now).
2254 2004-06-18 Marek Safar <marek.safar@seznam.cz>
2256 * typemanager.cs (GetArgumentTypes): Faster implementation.
2258 2004-06-18 Martin Baulig <martin@ximian.com>
2260 * attribute.cs (Attribute.Resolve): Check whether we're an
2261 EmptyCast which a Constant child. Fixes #60333.
2263 2004-06-17 Ben Maurer <bmaurer@ximian.com>
2265 * statement.cs (EmitCollectionForeach): Account for the fact that
2266 not all valuetypes are in areas which we can take the address of.
2267 For these variables, we store to a temporary variable. Also, make
2268 sure that we dont emit a `callvirt' on a valuetype method.
2270 2004-06-15 Marek Safar <marek.safar@seznam.cz>
2272 * expression.cs (StackAlloc.DoReSolve): Added test for
2273 negative parameter (CS0247).
2275 2004-06-15 Marek Safar <marek.safar@seznam.cz>
2278 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
2280 2004-06-15 Marek Safar <marek.safar@seznam.cz>
2283 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
2286 2004-06-14 Marek Safar <marek.safar@seznam.cz>
2288 Fix bug #58254 & cs1555.cs, cs1556.cs
2289 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
2291 2004-06-14 Marek Safar <marek.safar@seznam.cz>
2293 * cs-parser.jay: Added error CS1669 test for indexers.
2295 2004-06-18 Martin Baulig <martin@ximian.com>
2297 * generics.cs (GenericMethod.ctor): Don't take an Attributes
2298 argument. Fixes #60441.
2300 2004-06-16 Ben Maurer <bmaurer@ximian.com>
2301 * ecore.cs (MethodGroupExpr.Name): Revert Martin's patch.
2302 The name needs to have the actual name of the method in order
2303 for other tests (such as the one in OverloadResolve for Invoke
2304 on a delegate) to work. As well, it does not really help
2305 error reporting because the method group had multiple methods.
2306 * Makefile: Remove MCS_DEBUG, you can enable with the DEBUG_FLAGS.
2307 Make profiling work.
2309 2004-06-13 Martin Baulig <martin@ximian.com>
2311 * cs-parser.jay: Don't allow generic attributes.
2313 2004-06-13 Martin Baulig <martin@ximian.com>
2315 * class.cs (MemberBase.DoDefineBase): New protected method.
2316 (MemberBase.DoDefine): Compute the `flags' in the new
2317 DoDefineBase() which must be called first.
2318 (Method.Define): Call DoDefineBase() first so we have the flags
2319 when defining the generic method.
2321 * cs-parser.jay (interface_method_declaration): Support generic methods.
2323 2004-06-13 Martin Baulig <martin@ximian.com>
2325 * decl.cs (TypeName): Removed.
2326 (MemberName): Removed TypeName and MemberNow; now we just have
2329 * cs-parser.jay: Don't distinguish between type arguments and type
2330 parameters in the grammar and simplified the rules a bit. The
2331 reduce/reduce conflicts are now gone (except the one we inherited
2334 2004-06-11 Martin Baulig <martin@ximian.com>
2336 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
2337 call this twice: for params and varargs methods.
2339 2004-06-11 Marek Safar <marek.safar@seznam.cz>
2342 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
2344 2004-06-11 Marek Safar <marek.safar@seznam.cz>
2346 * attribute.cs (Attribute.GetValidTargets): Made public.
2349 (AbstractPropertyEventMethod): New class for better code sharing.
2350 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
2352 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
2354 2004-06-09 Martin Baulig <martin@ximian.com>
2356 * cs-parser.jay: Removed a reduce/reduce conflict.
2358 2004-06-03 Martin Baulig <martin@ximian.com>
2360 * generic.cs (ConstructedType.GetMemberAccess): Renamed to
2361 GetSimpleName() and return a SimpleName.
2363 * ecore.cs (SimpleName.Arguments): New public field.
2364 (SimpleName): Added overloaded ctor which takes an additional
2365 TypeArguments argument.
2366 (SimpleName.SimpleNameResolve): Added support for generic methods.
2367 (MethodGroupExpr.ResolveGeneric): New public method. The code was
2368 formerly in MemberAccess.DoResolve(), but we also need it in
2369 SimpleNameResolve().
2371 * expression.cs (MemberAccess.DoResolve): Use the new
2372 MethodGroupExpr.ResolveGeneric().
2374 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2376 * decl.cs: If possible, use lookuptypedirect here. We can only do
2377 this if there is no `.' after the namespace. Avoids using
2378 LookupType, which does lots of slow processing.
2379 (FindNestedType) New method, does what it says :-).
2380 * namespace.cs: use LookupTypeDirect.
2381 * rootcontext.cs: use membercache, if possible.
2382 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
2384 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2387 According to the spec,
2389 In a member access of the form E.I, if E is a single identifier,
2390 and if the meaning of E as a simple-name (§7.5.2) is a constant,
2391 field, property, localvariable, or parameter with the same type as
2392 the meaning of E as a type-name (§3.8), then both possible
2393 meanings of E are permitted.
2395 We did not check that E as a simple-name had the same type as E as
2398 This trivial check gives us 5-7% on bootstrap time.
2400 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2402 * expression.cs (Invocation.OverloadResolve): Avoid the
2403 use of hashtables and boxing here by allocating on demand.
2405 2004-05-30 Martin Baulig <martin@ximian.com>
2407 * rootcontext.cs (RootContext.LookupType): Don't cache things if
2408 we're doing a silent lookup. Don't try to lookup nested types in
2409 TypeManager.object_type (thanks to Ben Maurer).
2411 2004-05-30 Martin Baulig <martin@ximian.com>
2413 Committing a patch from Ben Maurer.
2415 * rootcontext.cs (RootContext.LookupType): Cache negative results.
2417 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2419 * convert.cs: add a trivial cache for overload operator resolution.
2421 2004-05-31 Marek Safar <marek.safar@seznam.cz>
2424 (AttributeTester.GetObsoleteAttribute): Returns instance of
2425 ObsoleteAttribute when type is obsolete.
2428 (TypeContainer.VerifyObsoleteAttribute): Override.
2429 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
2430 (MethodCode.VerifyObsoleteAttribute): Override.
2431 (MemberBase.VerifyObsoleteAttribute): Override.
2434 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
2435 and report proper error.
2438 (Delegate.VerifyObsoleteAttribute): Override.
2441 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
2442 and report proper error.
2443 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
2446 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
2450 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
2451 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
2452 Added test for ObsoleteAttribute.
2455 (Catch): Derived from Statement.
2457 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2459 * decl.cs: If possible, use lookuptypedirect here. We can only do
2460 this if there is no `.' after the namespace. Avoids using
2461 LookupType, which does lots of slow processing.
2462 (FindNestedType) New method, does what it says :-).
2463 * namespace.cs: use LookupTypeDirect.
2464 * rootcontext.cs: use membercache, if possible.
2465 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
2467 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2470 According to the spec,
2472 In a member access of the form E.I, if E is a single identifier,
2473 and if the meaning of E as a simple-name (§7.5.2) is a constant,
2474 field, property, localvariable, or parameter with the same type as
2475 the meaning of E as a type-name (§3.8), then both possible
2476 meanings of E are permitted.
2478 We did not check that E as a simple-name had the same type as E as
2481 This trivial check gives us 5-7% on bootstrap time.
2483 2004-05-30 Marek Safar <marek.safar@seznam.cz>
2485 Fixed bug #59071 & cs0160.cs
2486 * statement.cs (Try.Resolve): Check here whether order of catch
2487 clauses matches their dependencies.
2489 2004-05-30 Marek Safar <marek.safar@seznam.cz>
2492 * ecore.cs (SimpleName.SimpleNameResolve): Added test for
2495 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2497 * expression.cs (Invocation.OverloadResolve): Avoid the
2498 use of hashtables and boxing here by allocating on demand.
2500 2004-05-30 Martin Baulig <martin@ximian.com>
2502 * rootcontext.cs (RootContext.LookupType): Don't cache things if
2503 we're doing a silent lookup. Don't try to lookup nested types in
2504 TypeManager.object_type (thanks to Ben Maurer).
2506 2004-05-30 Martin Baulig <martin@ximian.com>
2508 Committing a patch from Ben Maurer.
2510 * rootcontext.cs (RootContext.LookupType): Cache negative results.
2512 2004-05-29 Martin Baulig <martin@ximian.com>
2514 * class.cs (IMethodData.ShouldIgnore): New method.
2516 * typemanager.cs (TypeManager.MethodFlags): Don't take a
2517 `Location' argument, we don't need it anywhere. Use
2518 `IMethodData.ShouldIgnore ()' instead of
2519 `MethodData.GetMethodFlags ()'.
2520 (TypeManager.AddMethod): Removed.
2521 (TypeManager.AddMethod2): Renamed to AddMethod.
2523 2004-05-29 Martin Baulig <martin@ximian.com>
2525 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
2527 * convert.cs (Convert.ImplicitReferenceConversion): If we're
2528 converting from a class type S to an interface type and we already
2529 have an object on the stack, don't box it again. Fixes #52578.
2531 2004-05-29 Martin Baulig <martin@ximian.com>
2533 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
2534 Added support for `params' parameters. Fixes #59267.
2536 2004-05-29 Martin Baulig <martin@ximian.com>
2538 * literal.cs (NullPointer): Provide a private .ctor which sets
2539 `type' to TypeManager.object_type. Fixes #59048.
2541 2004-05-29 Martin Baulig <martin@ximian.com>
2543 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
2544 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
2546 * ecore.cs (EventExpr.instance_expr): Make the field private.
2548 2004-05-26 Marek Safar <marek.safar@seznam.cz>
2550 Fixed bug #50080 & cs0214-2.cs
2551 * expression.cs (Cast.DoResolve): Check unsafe context here.
2553 * statement.cs (Resolve.DoResolve): Likewise.
2555 2004-05-26 Martin Baulig <martin@ximian.com>
2557 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
2559 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
2560 (RootContext.LookupType): Pass down the `silent' flag.
2562 2004-05-25 Martin Baulig <martin@ximian.com>
2565 (MethodGroupExpr.IdenticalTypeName): New public property.
2566 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
2567 expression actually refers to a type.
2569 2004-05-25 Martin Baulig <martin@ximian.com>
2571 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
2572 for #56176 and made it actually work.
2574 2004-05-25 Martin Baulig <martin@ximian.com>
2576 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
2577 (FieldExpr, PropertyExpr): Override and implement
2578 CacheTemporaries. Fixes #52279.
2580 2004-05-25 Miguel de Icaza <miguel@ximian.com>
2582 * location.cs: In the new compiler listing a file twice is a
2583 warning, not an error.
2585 2004-05-24 Martin Baulig <martin@ximian.com>
2587 * enum.cs (Enum.DefineType): For the `BaseType' to be a
2588 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
2590 2004-05-24 Martin Baulig <martin@ximian.com>
2592 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
2593 walking the `using' list. Fixes #53921.
2595 2004-05-24 Martin Baulig <martin@ximian.com>
2597 * const.cs (Const.LookupConstantValue): Added support for
2598 EmptyCast's; fixes #55251.
2600 2004-05-24 Martin Baulig <martin@ximian.com>
2602 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
2603 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
2604 which does the CS0135 check. The reason is that we first need to
2605 check whether the variable actually exists.
2607 2004-05-24 Martin Baulig <martin@ximian.com>
2609 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
2610 than RootContext.LookupType() to find the explicit interface
2613 2004-05-24 Raja R Harinath <rharinath@novell.com>
2615 * Makefile: Simplify. Use executable.make.
2616 * mcs.exe.sources: New file. List of sources of mcs.exe.
2618 2004-05-24 Anders Carlsson <andersca@gnome.org>
2622 Use the invariant culture when doing String.Compare for CLS case
2625 2004-05-23 Martin Baulig <martin@ximian.com>
2627 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
2628 don't have any dots. Fixes #52622, added cs0246-8.cs.
2630 * namespace.cs (NamespaceEntry.Lookup): Likewise.
2632 2004-05-23 Marek Safar <marek.safar@seznam.cz>
2634 * class.cs (MemberBase.Define): Reuse MemberType member for
2635 resolved type. Other methods can use it too.
2637 2004-05-23 Martin Baulig <martin@ximian.com>
2639 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
2640 the variable also exists in the current block (otherwise, we need
2641 to report a CS0103). Fixes #58670.
2643 2004-05-23 Martin Baulig <martin@ximian.com>
2645 * flowanalysis.cs (Reachability.Reachable): Compute this
2646 on-the-fly rather than storing it as a field.
2648 2004-05-23 Martin Baulig <martin@ximian.com>
2650 * flowanalysis.cs (Reachability.And): Manually compute the
2651 resulting `barrier' from the reachability.
2653 2004-05-23 Marek Safar <marek.safar@seznam.cz>
2656 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
2657 instance of ObsoleteAttribute when symbol is obsolete.
2660 (IMethodData): Extended interface for ObsoleteAttribute support.
2662 2004-05-22 Marek Safar <marek.safar@seznam.cz>
2664 * attribute.cs: Fix bug #55970
2666 2004-05-22 Marek Safar <marek.safar@seznam.cz>
2670 (GetObsoleteAttribute): New method. Creates the instance of
2672 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
2673 ObsoleteAttribute when member is obsolete.
2674 (AttributeTester.Report_ObsoleteMessage): Common method for
2675 Obsolete error/warning reporting.
2678 (TypeContainer.base_classs_type): New member for storing parent type.
2681 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
2682 for this MemberCore.
2684 2004-05-21 Marek Safar <marek.safar@seznam.cz>
2686 * attribute.cs, const.cs: Fix bug #58590
2688 2004-05-21 Martin Baulig <martin@ximian.com>
2690 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
2691 out parameters if the end of the method is unreachable. Fixes
2694 2004-05-21 Marek Safar <marek.safar@seznam.cz>
2696 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
2697 Hari was right, why extra method.
2699 2004-05-21 Marek Safar <marek.safar@seznam.cz>
2701 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
2703 2004-05-20 Martin Baulig <martin@ximian.com>
2705 * delegate.cs: Convert this file to Unix mode - like the original
2708 2004-05-20 Martin Baulig <martin@ximian.com>
2710 * attribute.cs: Convert this file to Unix mode - like the original
2713 2004-05-19 Marek Safar <marek.safar@seznam.cz>
2715 Fix bug #58688 (MCS does not report error when the same attribute
2718 * attribute.cs (Attribute.Emit): Distinction between null and default.
2720 2004-05-19 Raja R Harinath <rharinath@novell.com>
2722 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
2723 of a top-level attribute without an attribute target.
2724 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
2726 (Attribute.Conditional_GetConditionName),
2727 (Attribute.Obsolete_GetObsoleteMessage): Update.
2728 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
2729 part of ScanForIndexerName.
2730 (Attribute.CanIgnoreInvalidAttribute): New function.
2731 (Attribute.ScanForIndexerName): Move to ...
2732 (Attributes.ScanForIndexerName): ... here.
2733 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
2734 (Attributes.Search): New internal variant that can choose not to
2735 complain if types aren't resolved. The original signature now
2737 (Attributes.GetClsCompliantAttribute): Use internal variant, with
2738 complaints suppressed.
2739 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
2740 only if it not useful.
2741 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
2742 top-level for attributes that are shared between the assembly
2743 and a top-level class.
2744 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
2745 * class.cs: Update to reflect changes.
2746 (DefineIndexers): Fuse loops.
2747 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
2748 a couple more variants of attribute names.
2750 2004-05-18 Marek Safar <marek.safar@seznam.cz>
2752 Fix bug #52585 (Implemented explicit attribute declaration)
2755 (Attributable.ValidAttributeTargets): New abstract method. It gets
2756 list of valid attribute targets for explicit target declaration.
2757 (Attribute.Target): It holds target itself.
2758 (AttributeSection): Removed.
2759 (Attribute.CheckTargets): New method. It checks whether attribute
2760 target is valid for the current element.
2763 (EventProperty): New class. For events that are declared like
2764 property (with add and remove accessors).
2765 (EventField): New class. For events that are declared like field.
2768 * cs-parser.jay: Implemented explicit attribute target declaration.
2770 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
2771 Override ValidAttributeTargets.
2774 (ReturnParameter): Class for applying custom attributes on
2776 (ParameterAtribute): New class. Class for applying custom
2777 attributes on the parameter type.
2779 2004-05-17 Miguel de Icaza <miguel@ximian.com>
2781 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
2784 (Method): Allow UNSAFE here.
2786 * modifiers.cs: Support unsafe reporting.
2788 2004-05-17 Marek Safar <marek.safar@seznam.cz>
2790 * decl.cs: Fix bug #58478.
2792 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
2794 * statement.cs: When checking for unreachable code on an EmptyStatement,
2795 set the location. Fixes bug #58488.
2797 2004-05-13 Miguel de Icaza <miguel@ximian.com>
2799 * driver.cs: Add -pkg handling.
2801 From Gonzalo: UseShelLExecute=false
2803 2004-05-12 Marek Safar <marek.safar@seznam.cz>
2806 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
2808 (Attribute.IsClsCompliaceRequired): Moved to base for better
2810 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
2811 when attribute is AttributeUsageAttribute.
2812 (Attribute.GetValidTargets): Simplified.
2813 (Attribute.GetAttributeUsage): New method returns AttributeUsage
2814 attribute for this type.
2815 (Attribute.ApplyAttributes): Method renamed to Emit and make
2817 (GlobalAttributeSection): New class for special handling of global
2818 attributes (assembly, module).
2819 (AttributeSection.Emit): New method.
2821 * class.cs: Implemented Attributable abstract methods.
2822 (MethodCore.LabelParameters): Moved to Parameter class.
2823 (Accessor): Is back simple class.
2824 (PropertyMethod): Implemented Attributable abstract class.
2825 (DelegateMethod): Implemented Attributable abstract class.
2826 (Event): New constructor for disctintion between normal Event
2827 and Event with accessors.
2829 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
2831 * codegen.cs, const.cs, decl.cs, delegate.cs:
2832 (CommonAssemblyModulClass): Implemented Attributable abstract class
2835 * enum.cs: Implement IAttributeSupport interface.
2836 (EnumMember): New class for emum members. Implemented Attributable
2840 (ParameterBase): Is abstract.
2841 (ReturnParameter): New class for easier [return:] attribute handling.
2843 * typemanager.cs: Removed builder_to_attr.
2845 2004-05-11 Raja R Harinath <rharinath@novell.com>
2848 * attribute.cs (Attribute.GetPositionalValue): New function.
2849 * class.cs (TypeContainer.VerifyMembers): New function.
2850 (TypeContainer.Emit): Use it.
2851 (ClassOrStruct): New base class for Class and Struct.
2852 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
2853 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
2855 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
2856 then each non-static field should have a FieldOffset attribute.
2857 Otherwise, none of the fields should have a FieldOffset attribute.
2858 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
2859 and FieldOffset attributes.
2860 * typemanager.cs (TypeManager.struct_layout_attribute_type)
2861 (TypeManager.field_offset_attribute_type): New core types.
2862 (TypeManager.InitCoreTypes): Initialize them.
2864 2004-05-11 Michal Moskal <malekith@pld-linux.org>
2866 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
2867 Return correct type.
2870 2004-05-09 Miguel de Icaza <miguel@ximian.com>
2872 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
2873 be implicitly converted to ulong.
2875 * expression.cs: The logic for allowing operator &, | and ^ worked
2876 was wrong, it worked before because we did not report an error in
2877 an else branch. Fixes 57895.
2879 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
2880 allow volatile fields to be reference types.
2882 2004-05-07 Miguel de Icaza <miguel@ximian.com>
2884 * driver.cs: Add support for /debug-
2886 2004-05-07 Raja R Harinath <rharinath@novell.com>
2888 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
2889 Add a 'complain' parameter to silence errors.
2890 (Attribute.Resolve): Update to changes. Put in sanity check to catch
2891 silently overlooked type-resolutions.
2892 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
2894 (Attributes.Search): New function.
2895 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
2896 (Attributes.GetAttributeFullName): Remove hack.
2897 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
2898 Update to reflect changes.
2899 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
2900 Use Attributes.Search instead of nested loops.
2902 2004-05-07 Marek Safar <marek.safar@seznam.cz>
2905 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
2906 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
2907 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
2909 * report.cs: (Report.Warning): Renamed to Warning_T because of
2910 parameter collision.
2912 2004-05-05 Raja R Harinath <rharinath@novell.com>
2914 * expression.cs (MemberAccess.ResolveMemberAccess):
2915 Exit with non-zero status after Report.Error.
2916 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
2918 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
2920 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
2922 * support.cs: Don't hang when the file is empty.
2924 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
2926 * support.cs: In SeekableStreamReader, compute the preamble size of the
2927 underlying stream. Position changes should take into account that initial
2930 2004-05-03 Todd Berman <tberman@sevenl.net>
2932 * driver.cs: remove unused GetSysVersion function.
2934 2004-05-03 Todd Berman <tberman@sevenl.net>
2936 * driver.cs: Remove the hack from saturday, as well as the hack
2937 from jackson (LoadAssemblyFromGac), also adds the CWD to the
2938 link_paths to get that bit proper.
2940 2004-05-01 Todd Berman <tberman@sevenl.net>
2942 * driver.cs: Try a LoadFrom before a Load, this checks the current
2943 path. This is currently a bug in mono that is be fixed, however, this
2944 provides a workaround for now. This will be removed when the bug
2947 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
2949 * CryptoConvert.cs: Updated to latest version. Fix issue with
2950 incomplete key pairs (#57941).
2952 2004-05-01 Todd Berman <tberman@sevenl.net>
2954 * driver.cs: Remove '.' from path_chars, now System.* loads properly
2957 2004-04-30 Jackson Harper <jackson@ximian.com>
2959 * codegen.cs: Open keys readonly.
2961 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
2963 * typemanager.cs: don't report cyclic struct layout when a struct
2964 contains 2 or more fields of the same type. Failed for Pango.AttrShape
2965 which has 2 Pango.Rectangle fields.
2967 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
2969 * expression.cs: Handle IntPtr comparisons with IL code
2970 rather than a method call.
2972 2004-04-29 Martin Baulig <martin@ximian.com>
2974 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
2975 the list of PropertyInfo's in class hierarchy and find the
2976 accessor. Fixes #56013.
2978 2004-04-29 Martin Baulig <martin@ximian.com>
2980 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
2982 2004-04-29 Martin Baulig <martin@ximian.com>
2984 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
2986 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
2988 2004-04-29 Martin Baulig <martin@ximian.com>
2990 * class.cs (ConstructorInitializer.Resolve): Check whether the
2991 parent .ctor is accessible. Fixes #52146.
2993 2004-04-29 Martin Baulig <martin@ximian.com>
2995 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
2997 * statement.cs (Using.EmitLocalVariableDecls): Use
2998 TypeManager.idisposable_type, not typeof (IDisposable).
2999 (Foreach.EmitCollectionForeach): Added support for valuetypes.
3001 2004-04-29 Martin Baulig <martin@ximian.com>
3003 * class.cs (Event.Define): Don't emit the field and don't set
3004 RTSpecialName and SpecialName for events on interfaces. Fixes
3007 2004-04-29 Raja R Harinath <rharinath@novell.com>
3009 Refactor Attribute.ApplyAttributes.
3010 * attribute.cs (Attributable): New base class for objects that can
3011 have Attributes applied on them.
3012 (Attribute): Make AttributeUsage fields public.
3013 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
3014 (Attribute.IsInternalCall): New property.
3015 (Attribute.UsageAttr): Convert to a public read-only property.
3016 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
3017 (Attribute.ResolveType, Attribute.Resolve)
3018 (Attribute.ScanForIndexerName): Update to reflect changes.
3019 (Attribute.CheckAttributeTarget): Re-format.
3020 (Attribute.ApplyAttributes): Refactor, to various
3021 Attributable.ApplyAttributeBuilder methods.
3022 * decl.cs (MemberCore): Make Attributable.
3023 * class.cs (Accessor): Make Attributable.
3024 (MethodData.ApplyAttributes): Use proper attribute types, not
3026 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
3027 (TypeContainer.ApplyAttributeBuilder)
3028 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
3029 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
3030 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
3031 (Operator.ApplyAttributeBuilder): New factored-out methods.
3032 * const.cs (Const.ApplyAttributeBuilder): Likewise.
3033 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
3034 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
3035 * parameter.cs (ParameterBase): New Attributable base class
3036 that can also represent Return types.
3037 (Parameter): Update to the changes.
3039 2004-04-29 Jackson Harper <jackson@ximian.com>
3041 * driver.cs: Prefer the corlib system version when looking for
3042 assemblies in the GAC. This is still a hack, but its a better hack
3045 2004-04-29 Marek Safar <marek.safar@seznam.cz>
3047 * decl.cs, enum.cs: Improved error 3005 reporting.
3049 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
3050 (related_symbols): New private member for list of symbols
3051 related to reported error/warning.
3053 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
3055 2004-04-29 Martin Baulig <martin@ximian.com>
3057 * ecore.cs (Expression.Constantify): If we're an enum and
3058 TypeManager.TypeToCoreType() doesn't give us another type, use
3059 t.UnderlyingSystemType. Fixes #56178.
3061 2004-04-29 Martin Baulig <martin@ximian.com>
3063 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
3064 interfaces and for each interface, only add members directly
3065 declared in that interface. Fixes #53255.
3067 2004-04-28 Martin Baulig <martin@ximian.com>
3069 * expression.cs (ConditionalLogicalOperator): Use a temporary
3070 variable for `left' to avoid that we evaluate it more than once;
3073 2004-04-28 Martin Baulig <martin@ximian.com>
3075 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
3078 2004-04-28 Martin Baulig <martin@ximian.com>
3080 * statement.cs (LocalInfo.Resolve): Check whether the type is not
3083 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
3084 whether the type is not void (CS1547).
3086 2004-04-28 Martin Baulig <martin@ximian.com>
3088 * expression.cs (Unary.DoResolveLValue): Override this and report
3089 CS0131 for anything but Operator.Indirection.
3091 2004-04-28 Martin Baulig <martin@ximian.com>
3093 Committing a patch from Ben Maurer; see bug #50820.
3095 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
3098 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
3101 2004-04-28 Martin Baulig <martin@ximian.com>
3103 Committing a patch from Ben Maurer; see bug #50820.
3105 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
3108 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
3111 2004-04-28 Martin Baulig <martin@ximian.com>
3113 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
3114 (Block.AddLabel): Call DoLookupLabel() to only search in the
3117 2004-04-28 Martin Baulig <martin@ximian.com>
3119 * cfold.cs (ConstantFold.BinaryFold): Added special support for
3120 comparing StringConstants and NullLiterals in Equality and Inequality.
3122 2004-04-28 Jackson Harper <jackson@ximian.com>
3124 * driver.cs: Attempt to load referenced assemblies from the
3125 GAC. This is the quick and dirty version of this method that
3126 doesnt take into account versions and just takes the first
3127 canidate found. Will be good enough for now as we will not have more
3128 then one version installed into the GAC until I update this method.
3130 2004-04-28 Martin Baulig <martin@ximian.com>
3132 * typemanager.cs (TypeManager.CheckStructCycles): New public
3133 static method to check for cycles in the struct layout.
3135 * rootcontext.cs (RootContext.PopulateTypes): Call
3136 TypeManager.CheckStructCycles() for each TypeContainer.
3137 [Note: We only need to visit each type once.]
3139 2004-04-28 Martin Baulig <martin@ximian.com>
3141 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
3143 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
3144 success and added `out object value'. Use a `bool resolved' field
3145 to check whether we've already been called rather than
3146 `ConstantValue != null' since this breaks for NullLiterals.
3148 2004-04-28 Raja R Harinath <rharinath@novell.com>
3150 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
3151 setting of this flag, since the 'set' method may be non-public.
3153 2004-04-28 Raja R Harinath <rharinath@novell.com>
3155 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
3156 check on current_vector.Block.
3158 2004-04-27 Martin Baulig <martin@ximian.com>
3160 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
3161 a field initializer. Fixes #56459.
3163 2004-04-27 Martin Baulig <martin@ximian.com>
3165 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
3166 we're not attempting to use an indexer. Fixes #52154.
3168 2004-04-27 Martin Baulig <martin@ximian.com>
3170 * statement.cs (Return): Don't create a return label if we don't
3171 need it; reverts my change from January 20th. Thanks to Ben
3174 2004-04-27 Martin Baulig <martin@ximian.com>
3176 According to the spec, `goto' can only leave a nested scope, but
3179 * statement.cs (Block.LookupLabel): Only lookup in the current
3180 block, don't recurse into parent or child blocks.
3181 (Block.AddLabel): Check in parent and child blocks, report
3182 CS0140/CS0158 if we find a duplicate.
3183 (Block): Removed this indexer for label lookups.
3184 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
3185 this already does the error reporting for us.
3188 (FlowBranching.UsageVector.Block): New public variable; may be null.
3189 (FlowBranching.CreateSibling): Added `Block' argument.
3190 (FlowBranching.LookupLabel): New public virtual method. Lookup a
3191 label for the target of a `goto' and check whether we're not
3192 leaving a `finally'.
3194 2004-04-27 Martin Baulig <martin@ximian.com>
3196 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
3197 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
3200 2004-04-27 Martin Baulig <martin@ximian.com>
3202 * statement.cs (Block.AddLabel): Also check for implicit blocks
3203 and added a CS0158 check.
3205 2004-04-27 Martin Baulig <martin@ximian.com>
3207 * flowanalysis.cs (FlowBranchingLoop): New class.
3208 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
3209 UsageVector's instead of an ArrayList.
3210 (FlowBranching.Label): Likewise.
3211 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
3212 (FlowBranching.AddBreakVector): New method.
3214 2004-04-27 Miguel de Icaza <miguel@ximian.com>
3216 * attribute.cs: Small regression fix: only convert the type if we
3217 the type is different, fixes System.Drawing build.
3219 2004-04-27 Martin Baulig <martin@ximian.com>
3221 * attribute.cs (Attribute.Resolve): If we have a constant value
3222 for a named field or property, implicity convert it to the correct
3225 2004-04-27 Raja R Harinath <rharinath@novell.com>
3227 * statement.cs (Block.Block): Implicit blocks share
3228 'child_variable_names' fields with parent blocks.
3229 (Block.AddChildVariableNames): Remove.
3230 (Block.AddVariable): Mark variable as "used by a child block" in
3231 every surrounding block.
3232 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
3233 been used in a child block, complain about violation of "Invariant
3234 meaning in blocks" rule.
3235 * cs-parser.jay (declare_local_variables): Don't use
3236 AddChildVariableNames.
3237 (foreach_statement): Don't create an implicit block: 'foreach'
3240 2004-04-23 Miguel de Icaza <miguel@ximian.com>
3242 * convert.cs (ImplicitNumericConversion): 0 is also positive when
3243 converting from 0L to ulong. Fixes 57522.
3245 2004-04-22 Marek Safar <marek.safar@seznam.cz>
3247 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
3248 derived class hides via 'new' keyword field from base class (test-242.cs).
3249 TODO: Handle this in the more general way.
3251 * class.cs (CheckBase): Ditto.
3253 2004-04-22 Marek Safar <marek.safar@seznam.cz>
3255 * decl.cs (caching_flags): New member for storing cached values
3257 (MemberCore.Flags): New enum where bit flags for caching_flags
3259 (MemberCore.cls_compliance): Moved to caching_flags.
3260 (DeclSpace.Created): Moved to caching_flags.
3262 * class.cs: Use caching_flags instead of DeclSpace.Created
3264 2004-04-21 Miguel de Icaza <miguel@ximian.com>
3266 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
3267 if we are only a derived class, not a nested class.
3269 * typemanager.cs: Same as above, but do this at the MemberLookup
3270 level (used by field and methods, properties are handled in
3271 PropertyExpr). Allow for the qualified access if we are a nested
3274 2004-04-21 Marek Safar <marek.safar@seznam.cz>
3276 * class.cs: Refactoring.
3277 (IMethodData): New inteface; Holds links to parent members
3278 to avoid member duplication (reduced memory allocation).
3279 (Method): Implemented IMethodData interface.
3280 (PropertyBase): New inner classes for get/set methods.
3281 (PropertyBase.PropertyMethod): Implemented IMethodData interface
3282 (Event): New inner classes for add/remove methods.
3283 (Event.DelegateMethod): Implemented IMethodData interface.
3285 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
3286 EmitContext (related to class.cs refactoring).
3288 2004-04-21 Raja R Harinath <rharinath@novell.com>
3290 * delegate.cs (Delegate.VerifyApplicability): If the number of
3291 arguments are the same as the number of parameters, first try to
3292 verify applicability ignoring any 'params' modifier on the last
3296 2004-04-08 Martin Baulig <martin@ximian.com>
3298 Merged latest changes into gmcs. Please keep this comment in
3299 here, it makes it easier for me to see what changed in MCS since
3300 the last time I merged.
3302 2004-04-16 Raja R Harinath <rharinath@novell.com>
3304 * class.cs (TypeContainer.AddIndexer): Use
3305 'ExplicitInterfaceName' to determine if interface name was
3306 explicitly specified. 'InterfaceType' is not initialized at this time.
3307 (TypeContainer.DefineIndexers): Remove use of temporary list. The
3308 Indexers array is already in the required order. Initialize
3309 'IndexerName' only if there are normal indexers.
3310 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
3311 (TypeContainer.Emit): Emit DefaultMember attribute only if
3312 IndexerName is initialized.
3315 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
3317 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
3320 2004-04-15 Raja R Harinath <rharinath@novell.com>
3322 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
3326 * attribute.cs (Attribute.Resolve): Check for duplicate named
3330 2004-04-15 Miguel de Icaza <miguel@ximian.com>
3332 * iterators.cs (MarkYield): track whether we are in an exception,
3333 and generate code accordingly. Use a temporary value to store the
3334 result for our state.
3336 I had ignored a bit the interaction of try/catch with iterators
3337 since their behavior was not entirely obvious, but now it is
3338 possible to verify that our behavior is the same as MS .NET 2.0
3342 2004-04-14 Miguel de Icaza <miguel@ximian.com>
3344 * iterators.cs: Avoid creating temporaries if there is no work to
3347 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
3348 Enumerations, use TypeManager.EnumToUnderlying and call
3351 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
3354 (This.Emit): Use EmitContext.EmitThis to emit our
3357 (This.EmitAssign): Ditto.
3359 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
3360 codepaths, we will move all the functionality into
3363 (FieldExpr.EmitAssign): Ditto.
3365 This fixes several hidden bugs that I uncovered while doing a code
3366 review of this today.
3368 * codegen.cs (EmitThis): reworked so the semantics are more clear
3369 and also support value types "this" instances.
3371 * iterators.cs: Changed so that for iterators in value types, we
3372 do not pass the value type as a parameter.
3374 Initialization of the enumerator helpers is now done in the caller
3375 instead of passing the parameters to the constructors and having
3376 the constructor set the fields.
3378 The fields have now `assembly' visibility instead of private.
3380 2004-04-11 Miguel de Icaza <miguel@ximian.com>
3382 * expression.cs (Argument.Resolve): Check if fields passed as ref
3383 or out are contained in a MarshalByRefObject.
3385 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
3386 another compiler type.
3388 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
3390 * class.cs (Indexer.Define): use the new name checking method.
3391 Also, return false on an error.
3392 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
3393 (is_identifier_[start/part]_character): make static.
3395 2004-04-10 Miguel de Icaza <miguel@ximian.com>
3397 * expression.cs (Binary.ResolveOperator): Do no append strings
3398 twice: since we can be invoked more than once (array evaluation)
3399 on the same concatenation, take care of this here. Based on a fix
3400 from Ben (bug #56454)
3402 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
3404 * codegen.cs: Fix another case where CS1548 must be reported (when
3405 delay-sign isn't specified and no private is available #56564). Fix
3406 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
3407 error when MCS is used on the MS runtime and we need to delay-sign
3408 (which seems unsupported by AssemblyBuilder - see #56621).
3410 2004-04-08 Marek Safar <marek.safar@seznam.cz>
3412 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
3413 (TypeManager.ComputeNamespaces): Faster implementation for
3416 * compiler.csproj: Updated AssemblyName to mcs.
3418 2004-05-11 Jackson Harper <jackson@ximian.com>
3420 * Makefile: Preserve MONO_PATH
3422 2004-05-11 Jackson Harper <jackson@ximian.com>
3424 * Makefile: Use mono and mcs to build gmcs
3426 2004-05-03 Miguel de Icaza <miguel@ximian.com>
3428 * codegen.cs: Add patch from Robert Shade
3429 <rshade@dvsconsulting.com>, use FileAccess.Read on the keyfile, to
3432 2004-05-02 Sebastien Pouliot <sebastien@ximian.com>
3434 * CryptoConvert.cs: Updated to latest version. Fix issue with
3435 incomplete key pairs (#57941).
3437 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
3439 * codegen.cs: Fix another case where CS1548 must be reported (when
3440 delay-sign isn't specified and no private is available #56564). Fix
3441 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
3442 error when MCS is used on the MS runtime and we need to delay-sign
3443 (which seems unsupported by AssemblyBuilder - see #56621).
3445 2004-04-29 Jackson Harper <jackson@ximian.com>
3447 * Makefile: Set MONO_PATH to use the bootstrap corlib
3448 * driver.cs: Check the GAC for referenced assemblies.
3450 2004-04-29 Martin Baulig <martin@ximian.com>
3452 * Makefile (gmcs.exe): Set MONO_PATH to use `../class/lib/net_2_0'.
3454 2004-04-07 Martin Baulig <martin@ximian.com>
3456 * expression.cs (Binary.ResolveOperator): Added special case for
3457 Equality/Inequality between a type parameter and a null literal.
3459 2004-04-07 Martin Baulig <martin@ximian.com>
3461 * convert.cs: Check null literal -> type parameter conversions.
3463 2004-04-07 Martin Baulig <martin@ximian.com>
3465 * generic.cs (ConstructedType.CheckConstraints): Enforce the
3466 `class' and `struct' constraints.
3468 2004-04-07 Martin Baulig <martin@ximian.com>
3470 * generic.cs (SpecialConstraint): New public enum.
3471 (Constraints.Resolve): Added support for the `class' and `struct'
3474 * cs-parser.jay (type_parameter_constraint): Added support for the
3475 `class' and `struct' constraints.
3477 2004-04-07 Martin Baulig <martin@ximian.com>
3479 * support.cs (GenericConstraints): Replaced `Types' by
3480 `ClassConstraint' and `InterfaceConstraints'; added
3481 `HasClassConstraint'.
3483 2004-04-07 Martin Baulig <martin@ximian.com>
3486 (Constraints.InterfaceConstraints): New public property.
3487 (Constraints.Types): Make this property public
3488 (TypeParameter): Implement IMemberContainer.
3489 (TypeParameter.Define): Take a `GenericTypeParameterBuilder'
3490 instead of a TypeBuilder/MethodBuilder; pass the interface
3491 constraints to TypeManager.AddTypeParameter().
3492 (TypeParameter.DefineType): Just take an EmitContext and no
3493 TypeBuilder/MethodBuilder. Use the new public API.
3495 * typemanager.cs (TypeManager.AddTypeParameter): Added
3496 `TypeExpr[]' argument; add the interfaces to the
3497 `builder_to_ifaces' hash.
3498 (TypeManager.LookupMemberContainer): For
3499 GenericTypeParameterBuilders, get the TypeParameter from the
3500 `builder_to_type_param'.
3501 (TypeManager.FindMembers): For GenericTypeParameterBuilders, get
3502 the TypeParameter and call FindMembers on it.
3504 2004-04-07 Martin Baulig <martin@ximian.com>
3507 (MethodCore.GenericMethod): Moved this field here from Method.
3508 (MethodCore.IsDuplicateImplementation): Take the number of type
3509 parameters into account if we're a generic method.
3511 * expression.cs (Invocation.InferTypeArguments): Don't return true
3512 if `arguments' is null; we still need to check whether we actually
3513 don't need to infer anything in this case.
3514 (MemberAccess): Merged the functionality from GenericMemberAccess
3517 * generic.cs (GenericMemberAccess): Removed.
3519 2004-04-05 Martin Baulig <martin@ximian.com>
3521 * decl.cs (MemberCore): For generic classes, interfaces and
3522 structs, `Name' now includes the number of type parameters
3524 (DeclSpace.FindType): Removed the `num_type_args' argument; we now
3525 encode the number of type arguments in the type name.
3527 * expression.cs (Expression.MemberLookup): Removed the
3528 `num_type_args' argument; we now encode the number of type
3529 arguments in the type name.
3531 * ecore.cs (SimpleName): Encode the number of type arguments in
3532 the type name itself.
3534 * generic.cs (ConstructedType): Likewise.
3536 * tree.cs (Tree.RecordDecl): Take a `string' instead of a
3537 `MemberName'; we now include the number of type parameters in the
3540 * typemanager.cs (TypeManager.CheckGeneric): Removed.
3541 (TypeManager.MemberLookup): Removed the
3542 `num_type_args' argument; we now encode the number of type
3543 arguments in the type name.
3545 2004-04-03 Martin Baulig <martin@ximian.com>
3547 * decl.cs (MemberCore.ctor): Take a MemberName instead of a sting.
3548 (MemberCore.MemberName): Moved here from MemberBase.
3549 (DeclSpace.SetParameterInfo): Just take the constraints as an
3550 ArrayList; we already have the type parameters in our
3551 `MemberName'; also do the CS0080 reporting here.
3553 * cs-parser.jay (struct_declaration): Use `member_name' instead of
3554 `IDENTIFIER opt_type_parameter_list'; when constructing our
3555 `MemberName', it'll already include our type parameters.
3556 (class_declaration, interface_declaration): Likewise.
3557 (delegate_declaration): Likewise.
3558 (MakeName): Take a MemberName and return a MemberName.
3559 The following two changes are required to avoid shift/reduce conflicts:
3560 (member_name): Don't include a TypeName anymore; ie. this is now
3561 just 'IDENTIFIER opt_type_parameter_list'.
3562 (property_declaration, event_declaration): Use a
3563 `namespace_or_type_name' instead of a `member_name'.
3565 2004-04-03 Martin Baulig <martin@ximian.com>
3567 * decl.cs (MemberName): Renamed to `TypeName' and created a new
3569 (TypeName): Formerly known as MemberName.
3571 * namespace.cs (NamespaceEntry.UsingAlias): Take a `TypeName'
3572 instead of a `MemberName'.
3574 * cs-parser.jay (namespace_or_type_name): Create a TypeName.
3575 (member_name): New rule; create a MemberName.
3577 2004-04-02 Martin Baulig <martin@ximian.com>
3579 * namespace.cs (NamespaceEntry.VerifyUsing): Added error checking
3580 (CS0305 and CS0308).
3582 2004-04-02 Martin Baulig <martin@ximian.com>
3584 * generic.cs (GenericMemberAccess.ResolveAsTypeStep): Added
3585 support for nested types.
3587 2004-04-02 Martin Baulig <martin@ximian.com>
3589 * ecore.cs (IAlias): New public interface.
3590 (TypeExpr, TypeExpression): Implement IAlias.
3591 (TypeAliasExpression): New public class.
3593 * namespace.cs (Namespace): Implement IAlias.
3594 (Namespace.Lookup): Return an IAlias instead on an object.
3595 (Namespace.DefineName): Take an IAlias instead of an object.
3596 (NamespaceEntry.AliasEntry.Resolve): Return an IAlias instead of
3598 (NamespaceEntry.UsingAlias): Take a Membername instead of an
3600 (NamespaceEntry.LookupAlias): Return an IAlias instead on an
3602 (NamespaceEntry.Lookup): Likewise.
3604 * rootcontext.cs (RootContext.LookupType): Return a TypeExpr
3607 * decl.cs (DeclSpace): Implement IAlias.
3608 (DeclSpace.LookupAlias): Return an IAlias instead of a string.
3610 * generic.cs (ConstructedType): Improved error checking.
3612 2004-04-02 Martin Baulig <martin@ximian.com>
3614 * convert.cs: Added type parameter conversions.
3617 (UnboxCast.Emit): Emit an `unbox.any' for type params.
3618 (ClassCast.Emit): If the source type is a type parameter, box it.
3619 If the target type is a type parameter, emit an `unbox.any'
3620 instead of a `classcast'.1
3622 2004-04-01 Martin Baulig <martin@ximian.com>
3624 * cs-tokenizer.cs (parse_less_than): Allow Token.DOT.
3626 2004-04-01 Martin Baulig <martin@ximian.com>
3628 * generic.cs (ConstructedType.CheckConstraints): Use
3629 Convert.ImplicitStandardConversionExists(); user-defined implicit
3630 conversions are not allowed according to the spec.
3632 2004-03-30 Martin Baulig <martin@ximian.com>
3634 * expression.cs (New): Added support for type parameters.
3637 (TypeManager.activator_type): New public static field.
3638 (TypeManager.activator_create_instance): Likewise.
3640 2004-03-30 Martin Baulig <martin@ximian.com>
3642 * typemanager.cs (TypeManager.HasConstructorConstraint): New
3645 2004-03-30 Martin Baulig <martin@ximian.com>
3647 * generic.cs (ConstructedType.CheckConstraints): Actually follow
3648 the spec here: the argument type must be convertible to the
3651 2004-03-30 Martin Baulig <martin@ximian.com>
3654 (TypeParameter.Define, TypeParameter.DefineMethod): Call
3655 TypeManager.AddTypeParameter().
3656 (ConstructedType.CheckConstraints): Re-enable this and actually
3657 check whether we have a constructor constraint.
3660 (TypeManager.builder_to_type_param): New static field.
3661 (TypeManager.AddTypeParameter): New static method.
3662 (TypeManager.LookupTypeParameter): New public method.
3664 2004-03-30 Martin Baulig <martin@ximian.com>
3666 * generic.cs (TypeParameter.DefineType): Return a boolean and use
3667 the new API to actually define the constructor constraint.
3670 (TypeManager.new_constraint_attr_type): New static field.
3671 (TypeManager.InitCoreTypes): Initialize it.
3673 2004-03-30 Martin Baulig <martin@ximian.com>
3675 * generic.cs (Constraints): Completed error checking, use correct
3678 2004-03-29 Martin Baulig <martin@ximian.com>
3680 * delegate.cs (Delegate.VerifyMethod): Infer type arguments.
3682 * expression.cs (Invocation.InferTypeArguments): Added overloaded
3683 public version which takes a `ParameterData pd' instead of an
3686 2004-03-29 Martin Baulig <martin@ximian.com>
3688 * typemanager.cs (TypeManager.IsGenericMethod): Take a MethodBase,
3691 2004-03-29 Martin Baulig <martin@ximian.com>
3693 * expression.cs (Argument.ResolveMethodGroup): If we're a
3694 ConstructedType, call GetMemberAccess() on it.
3696 2004-03-29 Martin Baulig <martin@ximian.com>
3698 * class.cs (MethodBase.CheckGenericOverride): New abstract method.
3699 (MethodCore.CheckGenericOverride): When overriding a generic
3700 method, check whether the constraints match.
3702 * support.cs (GenericConstraints): New public interface.
3703 (ParameterData.GenericConstraints): New public method.
3705 * parameter.cs (Parameter.Resolve): Check whether we're a generic
3706 method parameter and compute our constraints if appropriate.
3707 (Parameter.GenericConstraints): New public property.
3709 * generic.cs (Constraints): Implement GenericConstraints.
3711 2004-03-29 Martin Baulig <martin@ximian.com>
3713 * decl.cs (MemberCache.FindMemberToOverride): Use
3714 `paramTypes [j].Equals (cmpAttrs [j])' instead of `=='.
3716 2004-03-29 Martin Baulig <martin@ximian.com>
3718 * generic.cs (GenericMethod.Define): Resolve our type parameters.
3720 2004-03-29 Martin Baulig <martin@ximian.com>
3722 * cs-parser.jay: Report CS0080 instead of -200 ("Constraints are
3723 not allowed on non-generic declarations").
3725 2004-03-29 Martin Baulig <martin@ximian.com>
3727 * expression.cs (Invocation.InferTypeArguments): Added overloaded
3728 public version of this method.
3730 * class.cs (MethodCore.IsDuplicateImplementation): Use
3731 Invocation.InferTypeArguments() to check this.
3733 2004-03-29 Martin Baulig <martin@ximian.com>
3735 * convert.cs: Use TypeManager.IsDelegateType() instead of
3736 comparing types correctly.
3738 2004-03-29 Martin Baulig <martin@ximian.com>
3740 * convert.cs: Use TypeManager.IsSubclassOf() instead of comparing
3741 types directly to make it work for generic instances.
3743 * typemanager.cs (TypeManager.IsSubclassOf): New static method.
3745 2004-03-29 Martin Baulig <martin@ximian.com>
3747 * typemanager.cs (TypeManager.MayBecomeEqualGenericTypes): Added
3750 2004-03-24 Martin Baulig <martin@ximian.com>
3752 * decl.cs (DeclSpace.FindType): Also use
3753 TypeManager.CheckGeneric() for types from the using clauses.
3755 2004-03-23 Martin Baulig <martin@ximian.com>
3757 * expression.cs (Invocation.OverloadResolve): Added `bool
3758 may_fail' argument and use it instead of the Location.IsNull() hack.
3760 2004-03-23 Martin Baulig <martin@ximian.com>
3762 * expression.cs (Invocation.InferType): Use correct type inference
3765 2004-03-23 Martin Baulig <martin@ximian.com>
3767 * ecore.cs (MethodGroupExpr.Name): Use
3768 TypeManager.CSharpSignature() instead of just the name.
3770 * expression.cs (Invocation.OverloadResolve): Provide better error
3772 (Invocation.DoResolve): OverloadResolve() never returns null
3773 without reporting an error, so removed the error -6 reporting here.
3775 2004-03-23 Martin Baulig <martin@ximian.com>
3777 * typemanager.cs (TypeManager.GetMethodFlags): Fixed the FIXME for
3780 * cs-parser.jay (delegate_declaration): Support generic delegates.
3782 * delegate.cs: Support generic delegates.
3784 2004-03-22 Martin Baulig <martin@ximian.com>
3786 * expression.cs (Invocation.InferParamsTypeArguments): New static
3787 method; does type inference for params arguments.
3789 2004-03-21 Martin Baulig <martin@ximian.com>
3791 * typemanager.cs (TypeManager.IsGenericMethod): New public static
3792 method; checks whether a method is a generic method.
3794 * expression.cs (Invocation.InferTypeArguments): New static method;
3795 infer type arguments for generic method invocation.
3797 * ecore.cs (MethodGroupExpr.HasTypeArguments): New public
3798 property; we set this to true if we're resolving a generic method
3799 invocation and the user specified type arguments, ie. we're not
3800 doing type inference.
3802 2004-03-20 Martin Baulig <martin@ximian.com>
3804 * class.cs (MethodData.DeclaringType): New public property.
3805 (MethodData.Define): Set DeclaringType here.
3806 (Operator.Define): Use OperatorMethod.MethodData.DeclaringType
3807 instead of OperatorMethodBuilder.DeclaringType.
3809 2004-03-20 Martin Baulig <martin@ximian.com>
3811 * cs-tokenizer.cs (xtoken): Return a special
3812 Token.DEFAULT_OPEN_PARENS for "`default' followed by open parens".
3814 * cs-parser.jay (default_value_expression): Switch to the new
3817 2004-03-19 Martin Baulig <martin@ximian.com>
3819 * decl.cs (MemberName): New class. We use this to "construct"
3820 namespace_or_type_name's.
3822 * generics.cs (TypeArguments.GetDeclarations): New public method;
3823 returns the type arguments as a string[] and reports a CS0081 if
3824 one of them is not an identifier.
3826 * class.cs (MemberBase): The .ctor now takes the name as a
3827 MemberName instead of a string.
3828 (MemberBase.ExplicitInterfaceName): Changed type from string to
3830 (MemberBase.DoDefine): If we're an explicit implementation, the
3831 InterfaceType may be a generic instance.
3833 * cs-parser.jay (namespace_or_type_name): Return a MemberName.
3834 (namespace_name): Call MemberName.GetName () to transform the
3835 MemberName into a string and ensure we don't have any type
3837 (type_name): Call MemberName.GetTypeExpression() to transfrom the
3838 MemberName into an expression.
3839 (method_header): Use namespace_or_type_name instead of member_name.
3841 2004-04-07 Miguel de Icaza <miguel@ximian.com>
3843 * rootcontext.cs: Add new types to the boot resolution.
3845 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
3846 MulticastDelegate is not allowed.
3848 * typemanager.cs: Add new types to lookup: System.TypedReference
3851 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
3852 check for TypedReference or ArgIterator, they are not allowed.
3854 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
3855 makes us properly catch 1510 in some conditions (see bug 56016 for
3858 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
3860 * CryptoConvert.cs: update from corlib version
3863 2004-04-05 Miguel de Icaza <miguel@ximian.com>
3865 * class.cs (Indexer.Define): Check indexername declaration
3867 2004-04-05 Marek Safar <marek.safar@seznam.cz>
3869 * attribute.cs (IsClsCompliant): Fixed problem with handling
3870 all three states (compliant, not-compliant, undetected).
3872 2004-03-30 Marek Safar <marek.safar@seznam.cz>
3874 * attribute.cs (Attribute): Location is now public.
3875 (Resolve): Store resolved arguments (pos_values) in attribute class.
3876 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
3877 (GetClsCompliantAttributeValue): New method that gets
3878 CLSCompliantAttribute value.
3879 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
3880 if exists else null.
3881 (AttributeTester): New class for CLS-Compliant verification routines.
3883 * class.cs (Emit): Add CLS-Compliant verification.
3884 (Method.GetSignatureForError): Implemented.
3885 (Constructor.GetSignatureForError): Implemented
3886 (Constructor.HasCompliantArgs): Returns if constructor has
3887 CLS-Compliant arguments.
3888 (Constructor.Emit): Override.
3889 (Construcor.IsIdentifierClsCompliant): New method; For constructors
3890 is needed to test only parameters.
3891 (FieldBase.GetSignatureForError): Implemented.
3892 (TypeContainer): New member for storing base interfaces.
3893 (TypeContainer.FindMembers): Search in base interfaces too.
3895 * codegen.cs (GetClsComplianceAttribute): New method that gets
3896 assembly or module CLSCompliantAttribute value.
3897 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
3899 (ModuleClass.Emit): Add error 3012 test.
3901 * const.cs (Emit): Override and call base for CLS-Compliant tests.
3903 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
3904 state for all decl types.
3905 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
3906 if CLS-Compliant tests are required.
3907 (IsClsCompliaceRequired): New method. Analyze whether code
3908 must be CLS-Compliant.
3909 (IsExposedFromAssembly): New method. Returns true when MemberCore
3910 is exposed from assembly.
3911 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
3912 value or gets cached value.
3913 (HasClsCompliantAttribute): New method. Returns true if MemberCore
3914 is explicitly marked with CLSCompliantAttribute.
3915 (IsIdentifierClsCompliant): New abstract method. This method is
3916 used to testing error 3005.
3917 (IsIdentifierAndParamClsCompliant): New method. Common helper method
3918 for identifier and parameters CLS-Compliant testing.
3919 (VerifyClsCompliance): New method. The main virtual method for
3920 CLS-Compliant verifications.
3921 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
3922 null. I don't know why is null (too many public members !).
3923 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
3924 and get value of first CLSCompliantAttribute that found.
3926 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
3927 (VerifyClsCompliance): Override and add extra tests.
3929 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
3930 clscheck- disable CLS-Compliant verification event if assembly is has
3931 CLSCompliantAttribute(true).
3933 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
3934 ApllyAttribute is now called in emit section as in the other cases.
3935 Possible future Emit integration.
3936 (IsIdentifierClsCompliant): New override.
3937 (VerifyClsCompliance): New override.
3938 (GetEnumeratorName): Returns full enum name.
3940 * parameter.cs (GetSignatureForError): Implemented.
3942 * report.cs (WarningData): New struct for Warning message information.
3943 (LocationOfPreviousError): New method.
3944 (Warning): New method. Reports warning based on the warning table.
3945 (Error_T): New method. Reports error based on the error table.
3947 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
3948 verifications are done here.
3950 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
3952 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
3953 CLSCompliantAttribute.
3954 (all_imported_types): New member holds all imported types from other
3956 (LoadAllImportedTypes): New method fills static table with exported types
3957 from all referenced assemblies.
3958 (Modules): New property returns all assembly modules.
3960 2004-03-30 Miguel de Icaza <miguel@ximian.com>
3962 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
3963 throwing a parser error.
3965 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
3966 which removes the hardcoded get_/set_ prefixes for properties, as
3967 IL allows for the properties to be named something else.
3971 * expression.cs: Do not override operand before we know if it is
3974 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
3976 * typemanager.cs: support for pinned variables.
3978 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
3980 * decl.cs, typemanager.cs: Avoid using an arraylist
3981 as a buffer if there is only one result set.
3983 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
3985 * expression.cs: Make sure you cant call a static method
3986 with an instance expression, bug #56174.
3988 2004-03-29 Miguel de Icaza <miguel@ximian.com>
3990 * class.cs (IsDuplicateImplementation): Improve error reporting to
3991 flag 663 (method only differs in parameter modifier).
3993 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
3994 in preprocessor directives.
3996 * location.cs (LookupFile): Allow for the empty path.
3998 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
3999 better approach for some of that patch, but its failing with the
4000 CharSet enumeration. For now try/catch will do.
4002 * typemanager.cs: Do not crash if a struct does not have fields.
4005 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
4007 * expression.cs: cs0213, cant fix a fixed expression.
4010 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
4012 * cs-parser.jay: detect invalid embeded statements gracefully.
4015 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
4017 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
4020 the invocation type may not be a subclass of the tye of the item/
4021 The type of the item must be a subclass of the invocation item.
4026 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
4028 * attribute.cs: Added methods to get a string and a bool from an
4029 attribute. Required to information from AssemblyKeyFileAttribute,
4030 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
4031 * codegen.cs: Modified AssemblyName creation to include support for
4032 strongnames. Catch additional exceptions to report them as CS1548.
4033 * compiler.csproj: Updated include CryptoConvert.cs.
4034 * compiler.csproj.user: Removed file - user specific configuration.
4035 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
4036 Mono.Security assembly. The original class is maintained and tested in
4037 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
4038 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
4039 like CSC 8.0 (C# v2) supports.
4040 * Makefile: Added CryptoConvert.cs to mcs sources.
4041 * rootcontext.cs: Added new options for strongnames.
4043 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
4045 * driver.cs: For --expect-error, report error code `2'
4046 if the program compiled with no errors, error code `1' if
4047 it compiled with an error other than the one expected.
4049 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
4051 * compiler.csproj: Updated for Visual Studio .NET 2003.
4052 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
4053 * compiler.sln: Updated for Visual Studio .NET 2003.
4055 2004-03-24 Ravi Pratap M <ravi@ximian.com>
4057 * expression.cs: Fix bug #47234. We basically need to apply the
4058 rule that we prefer the conversion of null to a reference type
4059 when faced with a conversion to 'object' (csc behaviour).
4061 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
4063 * statement.cs: Shorter form for foreach, eliminates
4064 a local variable. r=Martin.
4066 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
4068 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
4069 checks if we can use brtrue/brfalse to test for 0.
4070 * expression.cs: use the above in the test for using brtrue/brfalse.
4073 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
4075 * expression.cs: Rewrite string concat stuff. Benefits:
4077 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
4078 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
4079 rather than a concat chain.
4081 * typemanager.cs: Add lookups for more concat overloads.
4083 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
4085 * expression.cs: Emit shorter il code for array init.
4102 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
4104 * statement.cs: Before, two switch blocks would be merged if the
4105 total size of the blocks (end_item - begin_item + 1) was less than
4106 two times the combined sizes of the blocks.
4108 Now, it will only merge if after the merge at least half of the
4113 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
4115 * class.cs : csc build fix for GetMethods(). See bug #52503.
4117 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
4119 * expression.cs: Make sure fp comparisons work with NaN.
4120 This fixes bug #54303. Mig approved this patch a long
4121 time ago, but we were not able to test b/c the runtime
4124 2004-03-19 Miguel de Icaza <miguel@ximian.com>
4126 * ecore.cs (TypExpr.GetHashCode): implement this overload.
4128 2004-03-19 Martin Baulig <martin@ximian.com>
4130 * class.cs (MemberCore.IsDuplicateImplementation): Check whether
4131 two overloads may unify for some type parameter substitutions and
4132 report a CS0408 if appropriate.
4134 2004-03-19 Martin Baulig <martin@ximian.com>
4136 * class.cs (MemberCore.IsDuplicateImplementation): Report the
4137 error here and not in our caller.
4139 2004-03-19 Martin Baulig <martin@ximian.com>
4141 * interface.cs: Completely killed this file.
4142 (Interface): We're now a TypeContainer and live in class.cs.
4144 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
4145 argument; we're now also called for interfaces.
4146 (TypeContainer.DefineMembers): Allow this method being called
4148 (TypeContainer.GetMethods): New public method; formerly known as
4149 Interface.GetMethod(). This is used by PendingImplementation.
4150 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
4151 it's now private and non-static.
4152 (Interface): Moved this here; it's now implemented similar to
4154 (Method, Property, Event, Indexer): Added `bool is_interface'
4155 argument to their .ctor's.
4156 (MemberBase.IsInterface): New public field.
4158 * cs-parser.jay: Create normal Method, Property, Event, Indexer
4159 instances instead of InterfaceMethod, InterfaceProperty, etc.
4160 (opt_interface_base): Removed; we now use `opt_class_base' instead.
4161 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
4163 2004-03-19 Martin Baulig <martin@ximian.com>
4165 * class.cs (MethodCore.IsDuplicateImplementation): New private
4166 method which does the CS0111 checking.
4167 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
4168 Use IsDuplicateImplementation().
4170 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
4172 * decl.cs (FindMemberToOverride): New method to find the correct
4173 method or property to override in the base class.
4175 - Make Method/Property use the above method to find the
4176 version in the base class.
4177 - Remove the InheritableMemberSignatureCompare as it is now
4180 This patch makes large code bases much faster to compile, as it is
4181 O(n) rather than O(n^2) to do this validation.
4183 Also, it fixes bug 52458 which is that nested classes are not
4184 taken into account when finding the base class member.
4186 Reviewed/Approved by Martin.
4188 2004-03-17 Martin Baulig <martin@ximian.com>
4190 * expression.cs (MemberAccess.DoResolve): Take the parent's number
4191 of type arguments into account; use the `real_num_type_args'
4192 approach like in DoResolveAsTypeStep().
4194 * generic.cs (GenericMemberAccess.DoResolve): Make this work for
4197 2004-03-17 Marek Safar <marek.safar@seznam.cz>
4199 * interface.cs: In all interface classes removed redundant
4200 member initialization.
4202 2004-03-16 Martin Baulig <martin@ximian.com>
4204 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
4206 2004-03-15 Miguel de Icaza <miguel@ximian.com>
4208 * decl.cs (DefineTypeAndParents): New helper method to define a
4209 type's containers before the type itself is defined; This is a
4210 bug exposed by the recent changes to Windows.Forms when an
4211 implemented interface was defined inside a class that had not been
4214 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
4216 (Check): Loop correctly to report errors modifiers
4217 (UNSAFE was not in the loop, since it was the same as TOP).
4219 * interface.cs: Every interface member now takes a ModFlags,
4220 instead of a "is_new" bool, which we set on the base MemberCore.
4222 Every place where we called "UnsafeOk" in the interface, now we
4223 call the proper member (InterfaceMethod.UnsafeOK) instead to get
4224 the unsafe settings from the member declaration instead of the
4225 container interface.
4227 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
4229 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
4230 `set_indexer_name' to the pending bits (one per type).
4232 We fixed a bug today that was picking the wrong method to
4233 override, since for properties the existing InterfaceMethod code
4234 basically ignored the method name. Now we make sure that the
4235 method name is one of the valid indexer names.
4237 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
4239 * support.cs (SeekableStreamReader): Keep track of stream byte
4240 positions and don't mix them with character offsets to the buffer.
4242 Patch from Gustavo Giráldez
4244 2004-03-15 Marek Safar <marek.safar@seznam.cz>
4246 * interface.cs (InterfaceSetGetBase): Removed double member
4247 initialization, base class does it as well.
4249 2004-03-13 Martin Baulig <martin@ximian.com>
4251 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
4252 when compiling corlib.
4254 2004-03-13 Miguel de Icaza <miguel@ximian.com>
4256 * convert.cs (ExplicitConversion): We were reporting an error on
4257 certain conversions (object_type source to a value type, when the
4258 expression was `null') before we had a chance to pass it through
4259 the user defined conversions.
4261 * driver.cs: Replace / and \ in resource specifications to dots.
4264 * class.cs: Add check for duplicate operators. Fixes 52477
4266 2004-03-11 Miguel de Icaza <miguel@ximian.com>
4268 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
4269 that are in the middle of the statements, not only at the end.
4272 * class.cs (TypeContainer.AddField): No longer set the
4273 `HaveStaticConstructor' flag, now we call it
4274 `UserDefineStaticConstructor' to diferentiate the slightly
4275 semantic difference.
4277 The situation is that we were not adding BeforeFieldInit (from
4278 Modifiers.TypeAttr) to classes that could have it.
4279 BeforeFieldInit should be set to classes that have no static
4284 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
4286 And most importantly Zoltan's comment:
4288 http://bugzilla.ximian.com/show_bug.cgi?id=44229
4290 "I think beforefieldinit means 'it's ok to initialize the type sometime
4291 before its static fields are used', i.e. initialization does not need
4292 to be triggered by the first access to the type. Setting this flag
4293 helps the JIT to compile better code, since it can run the static
4294 constructor at JIT time, and does not need to generate code to call it
4295 (possibly lots of times) at runtime. Unfortunately, mcs does not set
4296 this flag for lots of classes like String.
4298 csc sets this flag if the type does not have an explicit static
4299 constructor. The reasoning seems to be that if there are only static
4300 initalizers for a type, and no static constructor, then the programmer
4301 does not care when this initialization happens, so beforefieldinit
4304 This bug prevents the AOT compiler from being usable, since it
4305 generates so many calls to mono_runtime_class_init that the AOT code
4306 is much slower than the JITted code. The JITted code is faster,
4307 because it does not generate these calls if the vtable is type is
4308 already initialized, which is true in the majority of cases. But the
4309 AOT compiler can't do this."
4311 2004-03-10 Miguel de Icaza <miguel@ximian.com>
4313 * class.cs (MethodData.Emit): Refactor the code so symbolic
4314 information is generated for destructors; For some reasons we
4315 were taking a code path that did not generate symbolic information
4318 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
4320 * class.cs: Create a Constructor.CheckBase method that
4321 takes care of all validation type code. The method
4322 contains some code that was moved from Define.
4324 It also includes new code that checks for duplicate ctors.
4325 This fixes bug #55148.
4327 2004-03-09 Joshua Tauberer <tauberer@for.net>
4329 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
4330 a { ... }-style array creation invokes EmitStaticInitializers
4331 which is not good for reference-type arrays. String, decimal
4332 and now null constants (NullCast) are not counted toward
4333 static initializers.
4335 2004-03-05 Martin Baulig <martin@ximian.com>
4337 * location.cs (SourceFile.HasLineDirective): New public field;
4338 specifies whether the file contains or is referenced by a "#line"
4340 (Location.DefineSymbolDocuments): Ignore source files which
4341 either contain or are referenced by a "#line" directive.
4343 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
4345 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
4346 direct access to our parent, so check the method inline there.
4348 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
4350 * expression.cs (Invocation.EmitCall): Miguel's last commit
4351 caused a regression. If you had:
4356 In Foo the implict this would be null.
4358 2004-02-27 Miguel de Icaza <miguel@ximian.com>
4360 * expression.cs (Invocation.EmitCall): If the method is not
4361 virtual, do not emit a CallVirt to it, use Call.
4363 * typemanager.cs (GetFullNameSignature): Improve the method to
4364 cope with ".ctor" and replace it with the type name.
4366 * class.cs (ConstructorInitializer.Resolve): Now the method takes
4367 as an argument the ConstructorBuilder where it is being defined,
4368 to catch the recursive constructor invocations.
4370 2004-03-16 Martin Baulig <martin@ximian.com>
4372 * expression.cs (MemberAccess.DoResolve): If `expr' resolved to a
4373 ConstructedType, call ResolveType() on it to get the type rather
4374 than just using `expr.Type'.
4376 2004-03-16 Martin Baulig <martin@ximian.com>
4378 * generics.cs (ConstructedType.GetMemberAccess): Take the
4379 EmitContext instead on the TypeExpr and use
4380 ec.TypeContainer.CurrentType/ec.ContainerType.
4382 2004-03-16 Martin Baulig <martin@ximian.com>
4384 * ecore.cs (SimpleName.DoResolveAsTypeStep): Lookup type
4385 parameters before aliases.
4387 2004-03-16 Martin Baulig <martin@ximian.com>
4389 * typemanager.cs (TypeManager.MayBecomeEqualGenericInstances):
4390 New oublic function; checks whether two generic instances may become
4391 equal under some instantiations (26.3.1).
4393 * class.cs (TypeContainer.Define): Call
4394 TypeManager.MayBecomeEqualGenericInstances() and report CS0695 on
4397 2004-03-16 Martin Baulig <martin@ximian.com>
4399 * class.cs (TypeContainer.GetClassBases): Moved
4400 Error_TypeParameterAsBase() here and also check whether the base
4401 class is not an attribute.
4403 2004-03-16 Martin Baulig <martin@ximian.com>
4405 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
4407 2004-03-16 Martin Baulig <martin@ximian.com>
4409 * class.cs (Error_TypeParameterAsBase): Use correct error number
4412 2004-03-16 Martin Baulig <martin@ximian.com>
4414 * decl.cs (DeclSpace.ResolveTypeExpr): Added more error checking
4417 * generics.cs (ConstructedType.DoResolveAsTypeStep): Added better
4420 2004-03-15 Martin Baulig <martin@ximian.com>
4422 * typemanager.cs (TypeManager.GetFullName): New public method.
4423 (TypeManager.MemberLookup): Added `int_num_type_arguments'
4424 argument; only return members with the correct number of type
4426 (TypeManager.CheckGeneric): Allow -1 to bypass the check.
4427 (TypeManager.FilterWithClosure): Call CheckGeneric() to check
4428 whether the number of type arguments matches.
4430 * generic.cs (GenericMemberAccess.ResolveAsTypeStep): Allow `expr'
4431 not being a ConstructedType; we can now do "typeof (Foo.Bar<U>)".
4433 * expression.cs (MemberAccess): Added public `NumTypeArguments'
4434 field; it's set by the protected .ctor when we're actually a
4435 GenericMemberAccess.
4436 (MemberAccess.ResolveAsTypeStep): Compute the total number of type
4437 arguments and pass it to MemberLookupFinal ().
4439 * ecore.cs (Expression.MemberLookup): Added `int
4440 num_type_arguments' argument; only return members with the correct
4441 number of type arguments.
4442 (Expression.MemberLookupFailed): Check whether the MemberLookup
4443 failed because we did not have the correct number of type
4444 arguments; report CS0305 in this case.
4446 * decl.cs (DeclSpace.ResolveTypeExpr): Don't report an error if
4447 `e.ResolveAsTypeTerminal()' already did so.
4449 2004-03-15 Martin Baulig <martin@ximian.com>
4451 * ecore.cs (Expression.ResolveLValue): Allow e.type being null if
4452 we're a ConstructedType; in this case, the caller must report an
4453 error (for instance CS0131).
4455 * generic.cs (TypeArguments): Added Location argument to the .ctor.
4456 (TypeArguments.Resolve): Actually report errors here.
4458 2004-03-15 Miguel de Icaza <miguel@ximian.com>
4460 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
4461 `set_indexer_name' to the pending bits (one per type).
4463 We fixed a bug today that was picking the wrong method to
4464 override, since for properties the existing InterfaceMethod code
4465 basically ignored the method name. Now we make sure that the
4466 method name is one of the valid indexer names.
4468 2004-03-15 Martin Baulig <martin@ximian.com>
4470 * typemanager.cs (TypeManager.IndexerPropertyName): Added support
4471 for generic instances.
4473 2004-03-13 Martin Baulig <martin@ximian.com>
4475 * class.cs (TypeContainer.DefineType): Call
4476 TypeManager.AddUserType() immediately after creating the
4477 TypeBuilder; pass all type parameters when creating the
4480 * decl.cs (DeclSpace.FindNestedType): New public method.
4481 (DeclSpace.FindType): Added `int num_type_args' argument; only
4482 return types with the correct number of type parameters.
4483 (DeclSpace.CountTypeParams): New public property.
4485 * ecore.cs (SimpleName.ctor): Added overloaded version which takes
4486 the number of type parameters; defaults to zero.
4488 * generic.cs (TypeArguments.Count): New public property.
4489 (ConstructedType.DoResolveAsTypeStep): First call
4490 ds.FindNestedType() to find out whether we're nested in the
4491 current generic type; in this case, we inherit all type parameters
4492 from the current class.
4494 * rootcontext.cs (RootContext.NamespaceLookup): Added `int
4495 num_type_args' argument.
4496 (RootContext.LookupType): Added overloaded version which takes the
4497 number of type arguments; only return types with the correct
4498 number of type arguments.
4500 * typemanager.cs (TypeManager.CheckGeneric): New public function;
4501 checks whether `Type t' has `int num_type_args'.
4503 2004-03-13 Martin Baulig <martin@ximian.com>
4505 * generic.cs (GenericMethod.DefineType): New method; calls
4506 DefineType() on all the type parameters.
4508 * class.cs (MethodData.ctor): Added `GenericMethod generic' argument.
4509 (MethodData.Define): If we're a generic method, call
4510 GenericMethod.DefineType() to define the type parameters.
4512 2004-03-10 Martin Baulig <martin@ximian.com>
4514 * pending.cs (Pending.InterfaceMethod): Use TypeManager.IsEqual()
4515 instead of IsAssignableFrom.
4517 2004-03-10 Martin Baulig <martin@ximian.com>
4519 * ecore.cs (FieldExpr.ctor): Use TypeManager.TypeToCoreType().
4521 * support.cs (ParameterData.HasArrayParameter): New property.
4522 (ReflectionParameters.ctor): Take a MethodBase instead of a
4523 ParameterInfo[]. If we have any type parameters, get the generic
4524 method definition and ask it whether we have variable arguments.
4526 2004-02-26 Miguel de Icaza <miguel@ximian.com>
4528 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
4529 routines to check if a type is an enumerable/enumerator allow
4530 classes that implement the IEnumerable or IEnumerator interfaces.
4532 * class.cs (Property, Operator): Implement IIteratorContainer, and
4533 implement SetYields.
4535 (Property.Define): Do the block swapping for get_methods in the
4536 context of iterators. We need to check if Properties also
4537 include indexers or not.
4539 (Operator): Assign the Block before invoking the
4540 OperatorMethod.Define, so we can trigger the Iterator code
4543 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
4544 Property and Operator classes are not created when we parse the
4545 declarator but until we have the block completed, so we use a
4546 singleton SimpleIteratorContainer.Simple to flag whether the
4547 SetYields has been invoked.
4549 We propagate this setting then to the Property or the Operator to
4550 allow the `yield' to function.
4552 2004-02-25 Marek Safar <marek.safar@seznam.cz>
4554 * codegen.cs: Implemented attribute support for modules.
4555 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
4556 Assembly/Module functionality.
4558 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
4559 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
4560 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
4562 2004-02-16 Marek Safar <marek.safar@seznam.cz>
4564 * interface.cs (FindMembers): The operation is performed on all base
4565 interfaces and not only on the first. It is required for future CLS Compliance patch.
4567 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
4569 * statement.cs, codegen.cs:
4570 This patch deals with patterns such as:
4572 public class List : IEnumerable {
4574 public MyEnumerator GetEnumerator () {
4575 return new MyEnumerator(this);
4578 IEnumerator IEnumerable.GetEnumerator () {
4582 public struct MyEnumerator : IEnumerator {
4587 Before, there were a few things we did wrong:
4588 1) we would emit callvirt on a struct, which is illegal
4589 2) we emited ldarg when we needed to emit ldarga
4590 3) we would mistakenly call the interface methods on an enumerator
4591 type that derived from IEnumerator and was in another assembly. For example:
4593 public class MyEnumerator : IEnumerator
4595 Would have the interface methods called, even if there were public impls of the
4596 method. In a struct, this lead to invalid IL code.
4598 2004-02-11 Marek Safar <marek.safar@seznam.cz>
4600 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
4603 * delegate.cs (Define): Fixed crash when delegate type is undefined.
4605 2004-02-11 Miguel de Icaza <miguel@ximian.com>
4607 * cs-parser.jay: Fix small regression: we were not testing V2
4608 compiler features correctly.
4610 * interface.cs: If the emit context is null, then create one
4612 2004-02-09 Marek Safar <marek.safar@seznam.cz>
4614 * decl.cs (GetSignatureForError): New virtual method to get full name
4617 * attribute.cs (IAttributeSupport): New interface for attribute setting.
4618 Now it is possible to rewrite ApplyAttributes method to be less if/else.
4620 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
4621 Duplicated members and code in these classes has been removed.
4622 Better encapsulation in these classes.
4624 2004-02-07 Miguel de Icaza <miguel@ximian.com>
4626 * assign.cs (Assign.DoResolve): When dealing with compound
4627 assignments, there is a new rule in ECMA C# 2.4 (might have been
4628 there before, but it is documented here) that states that in:
4632 If b is of type int, and the `op' is a shift-operator, then the
4633 above is evaluated as:
4637 * expression.cs (Binary.ResolveOperator): Instead of testing for
4638 int/uint/long/ulong, try to implicitly convert to any of those
4639 types and use that in pointer arithmetic.
4641 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
4642 method to print information for from the type, not from the
4643 null-method we were given.
4645 2004-02-01 Duncan Mak <duncan@ximian.com>
4647 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
4648 parsing for cmd, fixes bug #53694.
4650 2004-02-04 Marek Safar <marek.safar@seznam.cz>
4652 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
4653 in the member name duplication tests. Property and operator name duplication
4654 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
4656 2004-02-03 Marek Safar <marek.safar@seznam.cz>
4658 * interface.cs (PopulateMethod): Fixed crash when interface method
4659 returns not existing type (error test cs0246-3.cs).
4661 2004-02-02 Ravi Pratap M <ravi@ximian.com>
4663 * cs-parser.jay (interface_accessors): Re-write actions to also
4664 store attributes attached to get and set methods. Fix spelling
4667 (inteface_property_declaration): Modify accordingly.
4669 (InterfaceAccessorInfo): New helper class to store information to pass
4670 around between rules that use interface_accessors.
4672 * interface.cs (Emit): Apply attributes on the get and set
4673 accessors of properties and indexers too.
4675 * attribute.cs (ApplyAttributes): Modify accordingly to use the
4676 right MethodBuilder when applying attributes to the get and set accessors.
4678 2004-01-31 Miguel de Icaza <miguel@ximian.com>
4680 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
4682 2004-01-26 Miguel de Icaza <miguel@ximian.com>
4684 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
4686 2004-01-25 Miguel de Icaza <miguel@ximian.com>
4688 * cs-parser.jay: Remove YIELD token, instead use the new grammar
4689 changes that treat `yield' specially when present before `break'
4692 * cs-tokenizer.cs: yield is no longer a keyword.
4694 2004-01-23 Marek Safar <marek.safar@seznam.cz>
4696 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
4697 setting for default constructors.
4698 For default constructors are almost every time set wrong Modifier. The
4699 generated IL code has been alright. But inside mcs this values was
4700 wrong and this was reason why several of my CLS Compliance tests
4703 2004-02-27 Martin Baulig <martin@ximian.com>
4705 * generics.cs (ConstructedType.ResolveType): Make the nested type
4706 stuff actually work.
4708 2004-02-25 Martin Baulig <martin@ximian.com>
4710 * decl.cs (DeclSpace.CurrentTypeParameters): New protected
4711 property; returns the type parameters just from the current type,
4712 ie. with the ones from outer classes.
4713 (DeclSpace.LookupGeneric): First search in the current class, then
4715 (DeclSpace.initialize_type_params): When hiding a type parameter
4716 from an outer class, put it into the `type_param_list' anyways.
4718 * expression.cs (MemberAccess.expr): Made this field protected.
4720 * class.cs (TypeContainer.Define): The `CurrentType' just contains
4721 the type parameters from the current class.
4723 * generic.cs (ConstructedType.ResolveType): Support nested generic
4724 types by taking the type parameters which we inherit from outer
4725 classes into account.
4726 (GenericMemberAccess.ResolveAsTypeStep): Override this and added
4727 support for nested generic types.
4729 2004-02-23 Martin Baulig <martin@ximian.com>
4731 * decl.cs (DeclSpace.IsGeneric): Make this a property instead of a
4732 field and check whether we're nested inside a generic type.
4733 (DeclSpace.ResolveType): If we're resolving to a generic type
4734 definition, create a ConstructedType and return its resolved type.
4735 (DeclSpace.initialize_type_params): New private method;
4736 initializes the `type_param_list' field from the type parameters
4737 from this and all enclosing classes.
4738 (DeclSpace.TypeParameters): Call initialize_type_params() unless
4739 we're already initialized.
4741 2004-02-23 Martin Baulig <martin@ximian.com>
4743 * class.cs (Method.Define): Create the generic method before
4745 (Memberbase.DoDefine): Added DeclSpace argument (in addition to
4746 the TypeContainer one); we use this for generic methods.
4748 * decl.cs (CheckAccessLevel): If we're a GenericMethod, use our
4749 parent's TypeBuilder.
4751 2004-02-18 Martin Baulig <martin@ximian.com>
4753 * ecore.cs (FieldExpr.DoResolveLValue): Use TypeManager.IsEqual()
4754 to check for equality.
4756 2004-02-05 Martin Baulig <martin@ximian.com>
4758 * ecore.cs (FieldExpr.DoResolveLValue): If we have an
4759 `ec.TypeContainer.CurrentType', use it instead of
4760 `ec.ContainerType' to check whether we're in the type's ctor.
4762 2004-01-29 Martin Baulig <martin@ximian.com>
4764 * expression.cs (Invocation.DoResolve): If we're a
4765 `ConstructedType', then we're actually a generic method, so
4766 rewrite the expr as a GenericMemberAccess.
4768 * cs-parser.jay (member_name): Don't use `namespace_or_type_name'
4769 here; manually parse it into a string.
4771 2004-01-28 Martin Baulig <martin@ximian.com>
4773 * typemanager.cs (TypeManager.IsEqual): New static method.
4774 (TypeManager.FilterWithClosure): Call TypeManager.IsEqual() to
4775 check for equality instead of using `=='.
4777 2004-01-26 Martin Baulig <martin@ximian.com>
4779 * decl.cs (DeclSpace.CurrentType): New public field.
4781 * expression.cs (This.ResolveBase): If we have an
4782 `ec.TypeContainer.CurrentType', use it instead of
4785 * class.cs (TypeContainer.DefineType): If we're a generic type,
4786 create the `CurrentType' (unresolved).
4787 (TypeContainer.GenericType): New private field.
4788 (TypeContainer.DefineMembers): If we have a `CurrentType', resolve
4789 it and store it in `GenericType' before creating the MemberCache.
4790 (TypeContainer.GetMembers): If we have a `GenericType', call
4791 TypeManager.FindMembers() on it.
4793 * interface.cs (Interface.GenericType): New private field.
4794 (Interface.DefineType): If we're a generic type, create the
4795 `CurrentType' (unresolved).
4796 (Interface.DefineMembers): If we have a `CurrentType', resolve it
4797 and store it in `GenericType' before creating the MemberCache.
4798 (Interface.GetMembers): If we have a `GenericType', call
4799 TypeManager.FindMembers() on it.
4801 2004-01-22 Martin Baulig <martin@ximian.com>
4803 * cs-parser.jay (namespace_or_type_name): Return an Expression,
4804 not a QualifiedIdentifier. This is what `type_name_expression'
4805 was previously doing.
4806 (type_name_expression): Removed; the code is now in
4807 `namespace_or_type_name'.
4808 (qualified_identifier): Removed, use `namespace_or_type_name'
4810 (QualifiedIdentifier): Removed this class.
4812 2004-01-22 Martin Baulig <martin@ximian.com>
4814 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
4815 not a string as alias name.
4817 2004-01-21 Miguel de Icaza <miguel@ximian.com>
4819 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
4820 #52730 bug, and instead compute correctly the need to use a
4821 temporary variable when requesting an address based on the
4822 static/instace modified of the field and the constructor.
4824 2004-01-21 Martin Baulig <martin@ximian.com>
4826 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
4827 class and namespace before looking up aliases. Fixes #52517.
4829 2004-01-21 Martin Baulig <martin@ximian.com>
4831 * flowanalysis.cs (UsageVector.Merge): Allow variables being
4832 assinged in a 'try'; fixes exception4.cs.
4834 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4835 * class.cs : Implemented parameter-less constructor for TypeContainer
4837 * decl.cs: Attributes are now stored here. New property OptAttributes
4839 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
4841 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
4843 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4845 * typemanager.cs (CSharpSignature): Now reports also inner class name.
4846 (CSharpSignature): New method for indexer and property signature.
4848 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4850 * pending.cs (IsVirtualFilter): Faster implementation.
4852 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4854 * typemanager.cs: Avoid inclusion of same assembly more than once.
4856 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4858 * cs-parser.jay: Fixed problem where the last assembly attribute
4859 has been applied also to following declaration (class, struct, etc.)
4861 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4863 * class.cs: Added error CS0538, CS0539 reporting.
4864 Fixed crash on Microsoft runtime when field type is void.
4866 * cs-parser.jay: Added error CS0537 reporting.
4868 * pending.cs: Added error CS0535 reporting.
4869 Improved error report for errors CS0536, CS0534.
4871 2004-01-20 Miguel de Icaza <miguel@ximian.com>
4873 Merge a few bits from the Anonymous Method MCS tree.
4875 * statement.cs (ToplevelBlock): New class for toplevel methods,
4876 will hold anonymous methods, lifted variables.
4878 * cs-parser.jay: Create toplevel blocks for delegates and for
4879 regular blocks of code.
4881 2004-01-20 Martin Baulig <martin@ximian.com>
4883 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
4884 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
4885 and `NeedExplicitReturn'; added `IsLastStatement'.
4886 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
4887 have a `ReturnLabel' or we're not unreachable.
4889 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
4890 child's reachability; don't just override ours with it. Fixes
4891 #58058 (lluis's example).
4892 (FlowBranching): Added public InTryOrCatch(), InCatch(),
4893 InFinally(), InLoop(), InSwitch() and
4894 BreakCrossesTryCatchBoundary() methods.
4896 * statement.cs (Return): Do all error checking in Resolve().
4897 Unless we are the last statement in a top-level block, always
4898 create a return label and jump to it.
4899 (Break, Continue): Do all error checking in Resolve(); also make
4900 sure we aren't leaving a `finally'.
4901 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
4902 statement in a top-level block.
4903 (Block.Flags): Added `IsDestructor'.
4904 (Block.IsDestructor): New public property.
4906 2004-01-20 Martin Baulig <martin@ximian.com>
4908 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
4910 2004-01-20 Martin Baulig <martin@ximian.com>
4912 * statement.cs (Statement.ResolveUnreachable): New public method.
4913 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
4914 (Block.Resolve): Resolve unreachable statements.
4916 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
4918 * expression.cs: We need to fix the case where we do
4919 not have a temp variable here.
4921 * assign.cs: Only expression compound assignments need
4922 temporary variables.
4924 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
4926 * flowanalysis.cs: Reduce memory allocation in a few ways:
4927 - A block with no variables should not allocate a bit
4929 - A method with no out parameters does not need any tracking
4930 for assignment of the parameters, so we need not allocate
4933 public readonly Type[] VariableTypes;
4934 public readonly string[] VariableNames;
4935 Are redundant. The data is already stored in the variable
4936 map, so we need not allocate another array for it.
4937 - We need to add alot of checks for if (params | locals) == null
4938 due to the first two changes.
4940 2004-01-18 Miguel de Icaza <miguel@ximian.com>
4942 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
4943 implement IMemoryLocation, we store a copy on a local variable and
4944 take the address of it. Patch from Benjamin Jemlich
4946 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
4947 to use a special "type_name_expression" rule which reduces the
4948 number of "QualifiedIdentifier" classes created, and instead
4949 directly creates MemberAccess expressions.
4951 2004-01-17 Miguel de Icaza <miguel@ximian.com>
4953 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
4954 that fixes #52853. Null literal assignment to ValueType
4956 * class.cs (MethodData.Emit): Instead of checking the name of the
4957 method to determine if its a destructor, create a new derived
4958 class from Method called Destructor, and test for that.
4960 * cs-parser.jay: Create a Destructor object instead of a Method.
4962 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
4966 2004-01-16 Miguel de Icaza <miguel@ximian.com>
4968 * expression.cs (Binary.ResolveOperator): Perform an implicit
4969 conversion from MethodGroups to their delegate types on the
4972 * delegate.cs: Introduce a new class DelegateCreation that is the
4973 base class for `NewDelegate' and `ImplicitDelegateCreation',
4974 factor some code in here.
4976 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
4977 conversion from MethodGroups to compatible delegate types.
4979 * ecore.cs (Expression.Resolve): Do not flag error 654
4980 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
4981 we allow conversions from MethodGroups to delegate types now.
4983 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
4984 assignments in v2 either.
4986 2004-01-10 Miguel de Icaza <miguel@ximian.com>
4988 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
4989 static read-only fields in ctors.
4991 Applied patch from Benjamin Jemlich
4993 * expression.cs (UnaryMutator): Avoid leaking local variables.
4995 2004-01-09 Miguel de Icaza <miguel@ximian.com>
4997 * cs-tokenizer.cs (IsCastToken): Allow the various native types
4998 here to return true, as they can be used like this:
5002 Fixed 49836 and all the other dups
5004 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
5006 * driver.cs: Implement /win32res and /win32icon.
5008 2004-01-08 Miguel de Icaza <miguel@ximian.com>
5010 * cs-parser.jay: Add a rule to improve error handling for the
5011 common mistake of placing modifiers after the type.
5013 2004-01-07 Miguel de Icaza <miguel@ximian.com>
5015 * cs-parser.jay (interface_event_declaration): Catch
5016 initialization of events on interfaces, and report cs0068
5018 * cs-parser.jay (interface_event_declaration): Catch
5019 initialization of events.
5021 * ecore.cs: Better report missing constructors.
5023 * expression.cs (Binary.ResolveOperator): My previous bug fix had
5024 the error reporting done in the wrong place. Fix.
5026 * expression.cs (Binary.ResolveOperator): Catch the
5027 operator + (E x, E y) error earlier, and later allow for implicit
5028 conversions in operator +/- (E e, U x) from U to the underlying
5031 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
5032 52596, if the container class is abstract, the default constructor
5033 is protected otherwise its public (before, we were always public).
5035 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
5038 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
5039 Jemlich that fixes bug #52597, MCS was generating invalid code for
5040 idisposable structs. Thanks to Ben for following up with this
5043 2004-01-06 Miguel de Icaza <miguel@ximian.com>
5045 * driver.cs: Allow assemblies without code to be generated, fixes
5048 2004-01-07 Nick Drochak <ndrochak@gol.com>
5050 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
5052 2004-01-05 Miguel de Icaza <miguel@ximian.com>
5054 * cs-parser.jay: Add rules to improve error reporting if fields or
5055 methods are declared at the namespace level (error 116)
5057 * Add rules to catch event add/remove
5059 2004-01-04 David Sheldon <dave-mono@earth.li>
5061 * expression.cs: Added matching ")" to error message for
5064 2004-01-03 Todd Berman <tberman@gentoo.org>
5066 * ecore.cs, attribute.cs:
5067 Applying fix from #52429.
5069 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
5071 * ecore.cs, expression.cs, statement.cs:
5072 Total rewrite of how we handle branching. We
5073 now handle complex boolean expressions with fewer
5074 jumps. As well if (x == 0) no longer emits a ceq.
5076 if (x is Foo) is much faster now, because we generate
5079 Overall, we get a pretty big improvement on our benchmark
5080 tests. The code we generate is smaller and more readable.
5082 I did a full two-stage bootstrap. The patch was reviewed
5083 by Martin and Miguel.
5085 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
5087 * cs-parser.jay: Make primary_expression not take a QI.
5088 we dont need this because the member_access rule covers
5089 us here. So we replace the rule with just IDENTIFIER.
5091 This has two good effects. First, we remove a s/r conflict.
5092 Second, we allocate many fewer QualifiedIdentifier objects.
5094 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
5096 * attribute.cs: Handle MarshalAs attributes as pseudo, and
5097 set the correct information via SRE. This prevents
5098 hanging on the MS runtime. Fixes #29374.
5100 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
5102 * convert.cs: correctly handle conversions to value types
5103 from Enum and ValueType as unboxing conversions.
5105 Fixes bug #52569. Patch by Benjamin Jemlich.
5107 2004-01-02 Ravi Pratap <ravi@ximian.com>
5109 * expression.cs (BetterConversion): Prefer int -> uint
5110 over int -> ulong (csc's behaviour). This fixed bug #52046.
5112 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
5114 * decl.cs (MemberCache.FindMembers): now returns a
5117 * typemanager.cs: In general, go with with ^^.
5118 (CopyNewMethods): take an IList.
5119 (RealMemberLookup): Only allocate an arraylist
5120 if we copy from two sets of methods.
5122 This change basically does two things:
5123 1) Fewer array lists allocated due to CopyNewMethods.
5124 2) the explicit cast in MemberList costed ALOT.
5126 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
5128 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
5129 a hashtable to avoid needless string allocations when an identifier is
5130 used more than once (the common case).
5132 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
5134 * pending.cs: MS's TypeBuilder.GetInterfaces ()
5135 is broken, it will not return anything. So, we
5136 have to use the information we have in mcs to
5139 * typemanager.cs: Add a cache for GetInterfaces,
5140 since this will now be used more often (due to ^^)
5142 (GetExplicitInterfaces) New method that gets the
5143 declared, not effective, interfaces on a type
5144 builder (eg, if you have interface IFoo, interface
5145 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
5148 This patch makes MCS able to bootstrap itself on
5151 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
5153 * expression.cs: Remove the Nop's that Miguel put
5156 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
5158 * report.cs, codegen.cs: Give the real stack trace to
5159 the error when an exception is thrown.
5161 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
5163 * decl.cs: only allocate hashtables for ifaces if
5166 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
5168 * expression.cs: fix the error from cs0121-2.cs
5169 (a parent interface has two child interfaces that
5170 have a function with the same name and 0 params
5171 and the function is called through the parent).
5173 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
5175 * class.cs, rootcontext.cs, typmanager.cs: do not
5178 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
5180 * codegen.cs: remove stack for the ec flow branching.
5181 It is already a linked list, so no need.
5183 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
5185 * Makefile: Allow custom profiler here.
5187 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
5189 * typemanager.cs (LookupType):
5190 - Use a static char [], because split takes
5191 a param array for args, so it was allocating
5193 - Do not store true in a hashtable, it boxes.
5195 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
5197 * flowanalysis.cs: bytify common enums.
5199 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
5201 * modifiers.cs: Add a new set of flags for the
5202 flags allowed on explicit interface impls.
5203 * cs-parser.jay: catch the use of modifiers in
5204 interfaces correctly.
5205 * class.cs: catch private void IFoo.Blah ().
5207 All related to bug #50572.
5209 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
5211 * decl.cs: Rewrite the consistant accessability checking.
5212 Accessability is not linear, it must be implemented in
5213 a tableish way. Fixes #49704.
5215 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
5217 * expression.cs: Handle negation in a checked context.
5218 We must use subtraction from zero. Fixes #38674.
5220 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
5222 * class.cs: Ignore static void main in DLLs.
5223 * rootcontext.cs: Handle the target type here,
5224 since we are have to access it from class.cs
5225 * driver.cs: account for the above.
5227 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
5229 * report.cs: Give line numbers and files if available.
5231 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
5233 * driver.cs: Implement /addmodule.
5235 * typemanager.cs: Change 'modules' field so it now contains Modules not
5238 2003-12-20 Martin Baulig <martin@ximian.com>
5240 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
5241 (FieldBase.IsAssigned): Removed this field.
5242 (FieldBase.SetAssigned): New public method.
5243 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
5245 2003-12-20 Martin Baulig <martin@ximian.com>
5247 * expression.cs (LocalVariableReference.DoResolve): Don't set
5248 `vi.Used' if we're called from DoResolveLValue().
5250 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
5251 returns the usage vector it just merged into the current one -
5252 pass this one to UsageWarning().
5253 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
5254 of the `EmitContext', don't call this recursively on our children.
5256 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
5258 * driver.cs: Implement /target:module.
5260 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
5262 * support.cs (CharArrayHashtable): New helper class.
5264 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
5265 char arrays, not strings, so we can avoid creating a string in
5266 consume_identifier if the identifier is a keyword.
5268 2003-12-16 Martin Baulig <martin@ximian.com>
5270 * statement.cs (LocalInfo.Assigned): Removed this property.
5271 (LocalInfo.Flags): Removed `Assigned'.
5272 (LocalInfo.IsAssigned): New public method; takes the EmitContext
5273 and uses flow analysis.
5274 (Block.UsageWarning): Made this method private.
5275 (Block.Resolve): Call UsageWarning() if appropriate.
5277 * expression.cs (LocalVariableReference.DoResolve): Always set
5278 LocalInfo.Used here.
5280 2003-12-13 Martin Baulig <martin@ximian.com>
5282 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
5283 any value here; we're now using flow analysis to figure out
5284 whether a statement/block returns a value.
5286 2003-12-13 Martin Baulig <martin@ximian.com>
5288 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
5290 (FlowBranching.MergeFinally): Don't call
5291 `branching.CheckOutParameters()' here, this is called in
5293 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
5294 when adding the `finally' vector.
5296 2003-12-13 Martin Baulig <martin@ximian.com>
5299 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
5300 actually work and also fix #48962.
5302 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
5304 * decl.cs: Do not check System.Object for nested types,
5305 since we know it does not have any. Big bang for buck:
5310 corlib: 17.99 seconds
5314 corlib: 17.39 seconds
5316 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
5318 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
5319 time we are returning 0 members, so we save alot here.
5321 2003-12-11 Martin Baulig <martin@ximian.com>
5323 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
5324 `MergeChild()', also just take the `FlowBranching' as argument;
5325 call Merge() on it and return the result.
5326 (FlowBranching.Merge): We don't need to do anything if we just
5329 2003-12-11 Martin Baulig <martin@ximian.com>
5331 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
5332 them in an `ArrayList' to reduce memory usage. Thanks to Ben
5333 Maurer for this idea.
5335 2003-12-11 Martin Baulig <martin@ximian.com>
5337 * flowanalysis.cs (MergeResult): This class is now gone; we now
5338 use the `UsageVector' for this. The reason for this is that if a
5339 branching just has one sibling, we don't need to "merge" them at
5340 all - that's the next step to do.
5341 (FlowBranching.Merge): We now return a `UsageVector' instead of a
5344 2003-12-11 Martin Baulig <martin@ximian.com>
5346 Reworked flow analyis and made it more precise and bug-free. The
5347 most important change is that we're now using a special `Reachability'
5348 class instead of having "magic" meanings of `FlowReturns'. I'll
5349 do some more cleanups and optimizations and also add some more
5350 documentation this week.
5352 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
5353 largely reworked this class.
5354 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
5355 the new `Reachability' class instead of having "magic" values here.
5356 (FlowBranching): We're now using an instance of `Reachability'
5357 instead of having separate `Returns', `Breaks' etc. fields.
5359 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
5360 based on flow analysis; ignore the return value of block.Emit ().
5362 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
5364 * driver.cs typemanager.cs: Find the mono extensions to corlib even
5365 if they are private.
5367 2003-12-09 Martin Baulig <martin@ximian.com>
5369 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
5370 call them directly on the UsageVector.
5372 2003-12-09 Martin Baulig <martin@ximian.com>
5374 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
5375 Changed return type from `FlowReturns' to `Reachability'.
5377 2003-12-09 Martin Baulig <martin@ximian.com>
5379 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
5380 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
5381 `Reachable' fields with a single `Reachability' one.
5383 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
5385 * class.cs (FindMembers): Remove foreach's.
5398 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
5403 This patch does a few things:
5404 1. EmptyStatement is now a singleton, so it is never reallocated.
5405 2. All blah is EmptyStatement constructs have been changed to
5406 blah == EmptyStatement.Value, which is much faster and valid
5407 now that EmptyStatement is a singleton.
5408 3. When resolving a block, rather than allocating a new array for
5409 the non-empty statements, empty statements are replaced with
5410 EmptyStatement.Value
5411 4. Some recursive functions have been made non-recursive.
5412 Mainly the performance impact is from (3), however (1) and (2) are needed for
5413 this to work. (4) does not make a big difference in normal situations, however
5414 it makes the profile look saner.
5419 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
5420 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
5421 Total memory allocated: 56397 KB
5424 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
5425 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
5426 Total memory allocated: 55666 KB
5428 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
5430 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
5431 than the hashtable in a hashtable version
5433 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
5434 we always end up concating a string. This results in a huge perf
5435 loss, because many strings have to be tracked by the GC. In this
5436 patch, we first use a hashtable that works with two keys, so that
5437 the strings do not need to be concat'ed.
5448 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
5450 * Makefile: Add a new target `do-time' that does a quick and simple
5451 profile, leaving easy to parse output.
5453 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
5455 * codegen.cs (Init): Create the dynamic assembly with
5456 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
5458 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
5460 * support.cs: Make the PtrHashtable use only one
5461 instance of its comparer.
5463 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
5465 * typemanager.cs: Fix lookup of GetNamespaces.
5467 2003-11-29 Miguel de Icaza <miguel@ximian.com>
5469 * expression.cs: Removed redundant line.
5471 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
5472 ArrayLists, use for loops with bounds.
5474 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
5477 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
5478 arraylists, use for loop with bounds.
5480 The above three changes give us a 0.071 second performance
5481 improvement out of 3.294 seconds down to 3.223. On my machine
5482 the above changes reduced the memory usage by 1,387 KB during
5485 * cs-parser.jay (QualifiedIdentifier): New class used to represent
5486 QualifiedIdentifiers. Before we created a new string through
5487 concatenation, and mostly later on, the result would be
5488 manipulated by DecomposeQI through string manipulation.
5490 This reduced the compiler memory usage for bootstrapping from
5491 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
5492 compile times in 0.05 seconds.
5494 2003-11-28 Dick Porter <dick@ximian.com>
5496 * support.cs: Do string compares with the Invariant culture.
5504 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
5505 the comparison is done with the Invariant culture.
5507 2003-11-27 Miguel de Icaza <miguel@ximian.com>
5509 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
5510 GetEnumerator method.
5512 (ProbeCollectionType): Iterate starting at the most specific type
5513 upwards looking for a GetEnumerator
5515 * expression.cs: Shift count can be up to 31 for int/uint and 63
5518 2003-11-26 Miguel de Icaza <miguel@ximian.com>
5520 * statement.cs (Block.LookupLabel): Also look for the label on the
5521 children blocks. Use a hash table to keep track of visited
5524 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
5525 we actually did transform the other operand, otherwise fall back
5526 to the common codepath that casts to long.
5528 * cs-tokenizer.cs: Use the same code pattern as the int case.
5529 Maybe I should do the parsing myself, and avoid depending on the
5530 Parse routines to get this done.
5532 2003-11-25 Miguel de Icaza <miguel@ximian.com>
5534 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
5535 which fixes bug 51347. This time test it.
5537 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
5538 attributes for example can not tell the difference between these.
5539 The difference was only a syntax feature of the language.
5541 * attribute.cs: Apply attributes to delegates.
5543 * delegate.cs: Call the apply attributes method.
5545 2003-11-24 Miguel de Icaza <miguel@ximian.com>
5547 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
5548 comparing 0 vs Byte.MinValue, not the value
5550 (ImplicitConversionRequired): When reporting a conversion error,
5551 use error 31 to print out the constant error instead of the
5554 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
5555 which fixes bug 51347.
5557 2003-11-22 Miguel de Icaza <miguel@ximian.com>
5559 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
5560 which fixes the -warnaserror command line option.
5562 2003-11-21 Miguel de Icaza <miguel@ximian.com>
5564 * cfold.cs (DoNumericPromotions): During constant folding of
5565 additions on UIntConstant, special case intconstants with
5566 IntConstants like we do on the expression binary operator.
5568 2003-11-12 Miguel de Icaza <miguel@ximian.com>
5570 * convert.cs (ImplicitReferenceConversion): We were missing a case
5571 (System.Enum are not value types or class types, so we need to
5572 classify them separatedly).
5574 * driver.cs: We do not support error 2007.
5576 2003-11-12 Jackson Harper <jackson@ximian.com>
5578 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
5579 system directory. Also use the full file name so users can
5580 libraries names mscorlib-o-tron.dll in a non system dir.
5582 2004-01-04 David Sheldon <dave-mono@earth.li>
5584 * expression.cs: Added matching ")" to error message for CS0077.
5586 2003-12-19 Martin Baulig <martin@ximian.com>
5588 * typemanager.cs (TypeManager.IsEqualGenericType): New public
5589 static method; see documentation in the method.
5590 (TypeManager.IsSubclassOrNestedChild): Allow IsEqualGenericType().
5592 * convert.cs (Convert.ImplicitReferenceConversion,
5593 Convert.ImplicitReferenceConversionExists): Add support for
5594 generic type declarations; see gen-36.cs.
5596 2003-12-19 Martin Baulig <martin@ximian.com>
5598 * pending.cs (Pending.InterfaceMethod): Use
5599 `Type.IsAssignableFrom()' instead of `=='.
5601 2003-12-18 Martin Baulig <martin@ximian.com>
5603 * decl.cs (DeclSpace.AsAccessible): Check for array, pointer and
5606 * convert.cs (Convert.ImplicitStandardConversionExists): Use
5607 `expr_type.Equals (target_type)' instead of `=='.
5609 2003-12-08 Martin Baulig <martin@ximian.com>
5611 * generics.cs (Constraints.Types): Removed.
5612 (Constraints.Resolve): Just resolve everything to TypeExpr's, not
5614 (Constraints.ResolveTypes): New public method; resolves the
5615 TypeExpr's to Type's.
5616 (TypeParameter.Define): TypeBuilder.DefineGenericParameter() no
5617 longer takes the constraints.
5618 (TypeParameter.DefineMethod): Likewise.
5619 (TypeParameter.DefineType): New public method. Calls
5620 `TypeBuilder/MethodBuilder.SetGenericParameterConstraints()' to set
5623 2003-12-08 Martin Baulig <martin@ximian.com>
5625 * convert.cs (Convert.ImplicitConversionStandard): Use
5626 `expr_type.Equals (target_type)' instead of `=='.
5628 2003-12-08 Martin Baulig <martin@ximian.com>
5630 * typemanager.cs (TypeManager.GetReferenceType): Call
5631 `Type.MakeByRefType ()'.
5633 2003-12-08 Martin Baulig <martin@ximian.com>
5635 * cs-parser.jay, cs-tokenizer.cs: `where' is not a keyword, it
5636 just has some special meaning in some situations. For instance,
5637 it is allowed to use `where' as the name of a variable etc.
5639 2003-12-04 Martin Baulig <martin@ximian.com>
5641 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
5642 `Type.MakeArrayType()' for array types.
5644 2003-11-18 Miguel de Icaza <miguel@ximian.com>
5646 * expression.cs (Invocation.VerifyArgumentsCompat): Remove
5649 (SizeOf.DoResolve): assign the `type_queried' field. This gets
5652 2003-11-16 Martin Baulig <martin@ximian.com>
5654 * codegen.cs (EmitContext.IsGeneric): Removed.
5656 * ecore.cs (SimpleName.ResolveAsTypeStep): Always call
5657 ResolveGeneric() on the DeclSpace.
5659 2003-11-16 Martin Baulig <martin@ximian.com>
5661 * generic.cs (TypeArguments.Resolve):
5662 `Expression.ResolveAsTypeTerminal()' returns a TypeExpr; call
5663 `ResolveType()' on it to get the Type.
5665 2003-11-15 Martin Baulig <martin@ximian.com>
5667 * generic.cs (ConstructedType.GetInterfaces): Override this.
5669 2003-11-14 Martin Baulig <martin@ximian.com>
5671 * interface.cs (Interface.DefineType): Define all type parameters
5672 before adding the interfaces we inherit.
5674 2003-11-11 Martin Baulig <martin@ximian.com>
5676 * generic.cs (ConstructedType.ResolveType): Always call
5677 `gt.BindGenericParameters (atypes)'; also if `args.HasTypeArguments'.
5679 2003-11-10 Martin Baulig <martin@ximian.com>
5681 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
5682 (TypeManager.InitCoreTypes): Initialize them here, but instead of
5683 calling `ResolveType()' on them, directly assign their `Type'.
5685 2003-11-08 Martin Baulig <martin@ximian.com>
5687 * generic.cs (ConstructedType): Override `IsClass' etc.
5689 2003-11-08 Martin Baulig <martin@ximian.com>
5691 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
5692 return value and the `out parent' parameter.
5693 (TypeContainer.DefineType): Moved the CS0644 check into
5694 GetClassBases(). Don't pass the interface types to the
5695 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
5696 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
5698 * ecore.cs (TypeExpr.IsAttribute): New property.
5699 (TypeExpr.GetInterfaces): New method.
5701 * interface.cs (Interface.GetInterfaceTypeByName): Return a
5702 TypeExpr instead of a Type.
5703 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
5704 (Interface.DefineType): Don't pass the interface types to the
5705 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
5706 them later and then call `TypeBulider.AddInterfaceImplementation()'.
5708 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
5709 instead of a `Type[]'.
5710 (TypeManager.RegisterBuilder): Likewise.
5711 (TypeManager.AddUserInterface): Likewise.
5712 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
5713 `Type[]' and also return a `TypeExpr[]'.
5714 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
5716 2003-11-08 Martin Baulig <martin@ximian.com>
5718 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
5721 2003-11-08 Martin Baulig <martin@ximian.com>
5723 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
5724 TypeManager.ResolveExpressionTypes().
5726 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
5727 instead of an Expression.
5728 (TypeExpr): This is now an abstract base class for `TypeExpression'.
5729 (TypeExpression): New public class; formerly known as `TypeExpr'.
5731 * expression.cs (ComposedCast): Derive from TypeExpr.
5733 * typemanager.cs (TypeManager.system_*_expr): These are now
5734 TypExpr's instead of Expression's.
5735 (TypeManager.ResolveExpressionTypes): New public static function;
5736 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
5739 2003-11-06 Miguel de Icaza <miguel@ximian.com>
5741 * expression.cs (New.DoResolve): Do not dereference value that
5742 might be a null return.
5744 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
5745 sure that the constant value has the right type. Fixes an
5746 unreported bug, similar to 50425.
5748 * const.cs (Const.LookupConstantValue): Call
5749 ImplicitStandardConversionExists before doing a conversion to
5750 avoid havng the TypeManager.ChangeType do conversions.
5752 Reduced the number of casts used
5754 (Const.ChangeType): New routine to enable reuse of the constant
5755 type changing code from statement.
5757 * typemanager.cs (ChangeType): Move common initialization to
5758 static global variables.
5762 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
5763 every value type to go through, even if it was void. Fix that.
5765 * cs-tokenizer.cs: Use is_identifier_start_character on the start
5766 character of the define, and the is_identifier_part_character for
5767 the rest of the string.
5769 2003-11-05 Miguel de Icaza <miguel@ximian.com>
5771 * expression.cs (UnaryMutator.EmitCode): When I updated
5772 LocalVariableReference.DoResolve, I overdid it, and dropped an
5773 optimization done on local variable references.
5775 2003-11-04 Miguel de Icaza <miguel@ximian.com>
5777 * ecore.cs: Convert the return from Ldlen into an int.
5779 2003-10-20 Miguel de Icaza <miguel@ximian.com>
5781 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
5782 the accessibility, this is a special case for toplevel non-public
5783 classes (internal for instance).
5785 2003-10-20 Nick Drochak <ndrochak@gol.com>
5787 * ecore.cs: Fix typo and build. Needed another right paren.
5789 2003-10-19 Miguel de Icaza <miguel@ximian.com>
5791 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
5792 `internal' case regular and protected, but not allowing protected
5793 to be evaluated later. Bug 49840
5795 2003-10-15 Miguel de Icaza <miguel@ximian.com>
5797 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
5798 to kb.Nlast, and not the kb.nFirst to isolate the switch
5801 Extract the underlying type, so enumerations of long/ulong are
5802 treated like long/ulong.
5804 2003-10-14 Miguel de Icaza <miguel@ximian.com>
5806 * expression.cs (New): Overload the meaning of RequestedType to
5807 track the possible creation of the NewDelegate type, since
5808 DoResolve is invoked more than once for new constructors on field
5811 See bugs: #48800 and #37014
5813 * cs-parser.jay (declare_local_constants): Take an arraylist
5814 instead of a single constant.
5816 (local_constant_declaration): It should take a
5817 constant_declarators, not a constant_declarator. Fixes 49487
5819 * convert.cs: Fix error report.
5821 2003-10-13 Jackson Harper <jackson@ximian.com>
5823 * typemanager.cs (TypeToCoreType): Add float and double this fixes
5826 2003-11-03 Martin Baulig <martin@ximian.com>
5828 * expression.cs (ArrayAccess.GetStoreOpcode): Added
5829 `out bool has_type_arg'; if set, we need to pass the type to
5831 (ArrayAccess.GetStoreOpcode, ArrayAccess.EmitLoadOpcode): Use
5832 Stelem_Any/Ldelem_Any for generic parameters.
5834 2003-11-02 Martin Baulig <martin@ximian.com>
5836 * expression.cs (Invocation.EmitCall): Use
5837 `TypeManager.IsValueType()' to check whether it's a value type.
5838 Don't set `struct_call' when calling a method on a type parameter.
5840 2003-11-02 Martin Baulig <martin@ximian.com>
5842 * generics.cs (ConstructedType.Resolve): Renamed to ResolveType()
5843 and removed the TypeBuilder argument.
5845 * typemanager.cs (TypeManager.IsValueType): Return
5846 `t.IsGenericParameter || t.IsValueType'.
5848 2003-10-25 Martin Baulig <martin@ximian.com>
5850 * decl.cs (DeclSpace.ResolveType): If we're a ConstructedType,
5851 call ConstructedType.Resolve() on it.
5853 * generic.cs (ConstructedType.Resolve): Set `type' on success.
5855 2003-10-25 Martin Baulig <martin@ximian.com>
5857 * class.cs (TypeContainer.GetClassBases): Changed
5858 `out Type parent' into `out TypeExpr parent'. Moved CS0644 and
5859 CS8214 reporting here.
5860 (TypeContainer.DefineType): GetClassBases() gives us a `TypeExpr'
5861 instead of a `Type' for our parent. In case of a recursive
5862 declaration (see tests/gen-23.cs for an example), our parent is a
5863 ConstructedType and it doesn't have its type set. So, first
5864 create our own TypeBuilder, then call constructed.Resolve() to get
5865 the parent's type and finally TypeBuilder.SetParent() it.
5867 * ecore.cs (TypeExpr.Name): New public virtual property.
5870 (ConstructedType): We're now a TypeExpr and not just an Expression.
5871 (ConstructedType.ResolveAsTypeStep): Don't resolve our type
5872 arguments here; this is done later.
5873 (ConstructedType.Resolve): New public method to resolve the type
5874 arguments and bind them.
5876 2003-10-21 Martin Baulig <martin@ximian.com>
5878 * convert.cs: Use `TypeManager.IsValueType' instead of
5879 'type.IsValueType' everywhere.
5881 * typemanager.cs (TypeManager.IsValueType): Return true for type
5882 parameters. The reason for this is that we need to box a type
5883 parameter when converting it to a reference type.
5885 * cs-parser.jay: Added support for default value expressions.
5887 * generics.cs (DefaultValueExpression): New public class.
5889 2003-10-17 Martin Baulig <martin@ximian.com>
5891 * generic.cs (Constraints.Resolve): Take a DecpSpace instead of a
5892 TypeContainer so we can also use this for Interfaces.
5893 (TypeParameter.Resolve): Likewise.
5895 * interface.cs (Interface.DefineType): Added support for generic
5898 * cs-parser.jay: Added support for generic structs and interfaces.
5900 2003-10-17 Martin Baulig <martin@ximian.com>
5902 * generic.cs (GenericMemberAccess.DoResolve): We can now actually
5903 call generic methods :-)
5905 2003-10-16 Martin Baulig <martin@ximian.com>
5907 * cs-parser.jay (namespace_or_type_name): Only create a
5908 GenericMemberAccess if we actually have type arguments.
5910 2003-10-13 Martin Baulig <martin@ximian.com>
5912 * class.cs (Method.Define): If we're a generic method, call
5913 TypeBuilder.DefineGenericMethod () before resolving
5915 (MethodData): Added .ctor which takes an additional MethodBuilder
5916 argument; this is used for generic methods.
5917 (MethodData.Define): Call `builder.SetGenericMethodSignature()' if
5918 we already have a MethodBuilder.
5920 2003-10-10 Martin Baulig <martin@ximian.com>
5922 * class.cs (Method): Added .ctor which takes a `GenericMethod'
5923 instead of a `DeclSpace'. This is used for generic methods.
5925 * cs-parser.jay (method_header): Added support for generic
5926 methods; create a `GenericMethod' instance and pass it to the
5927 `Method's .ctor; it'll be used as the `DeclSpace' to lookup
5928 parameters and locals.
5930 * decl.cs (DeclSpace.SetParameterInfo): Removed Location argument
5931 since we already have the location. Check whether we're a generic
5932 type declaration or a generic method and create the correct type
5935 * generic.cs (TypeParameter.DefineMethod): New public method.
5936 (GenericMethod): New public class; derives from DeclSpace and is
5937 used for generic methods.
5939 2003-10-09 Martin Baulig <martin@ximian.com>
5941 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
5943 (MethodCore.DoDefineParameters): Removed the TypeContainer
5944 argument; use the DeclSpace which was passed to the .ctor instead.
5945 (MethodCore.CheckParameter): Take a DeclSpace instead of a
5946 TypeContainer; we only need a DeclSpace here.
5948 2003-10-09 Martin Baulig <martin@ximian.com>
5950 * class.cs (MethodData): Added additional `DeclSpace ds' argument
5952 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
5953 EmitContext's .ctor.
5955 2003-10-09 Martin Baulig <martin@ximian.com>
5957 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
5958 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
5959 AsAccessible(), moved them as well.
5961 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
5963 2003-10-07 Miguel de Icaza <miguel@ximian.com>
5965 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
5966 generation for >=, as spotted by Paolo, bug 48679.
5967 Patch from David Waite.
5969 * cs-tokenizer.cs: Add handling for #pragma.
5971 * cs-parser.jay: Allow for both yield and yield return in the
5972 syntax. The anti-cobolization of C# fight will go on!
5974 * class.cs (TypeBuilder.DefineType): Catch error condition here
5975 (Parent.DefineType erroring out and returning null).
5977 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
5978 coping with enumerations variables, we were mistakenly processing
5979 them as a regular value type instead of built-in types. Fixes the
5982 * typemanager.cs (IsBuiltinOrEnum): New method.
5984 2003-09-30 Miguel de Icaza <miguel@ximian.com>
5986 * cs-parser.jay: Upgrade: yield now needs the return clause.
5988 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
5990 * cs-parser.jay : Renamed yyName to yyNames related to jay.
5992 2003-09-29 Martin Baulig <martin@ximian.com>
5994 * typemanager.cs (TypeManager.GetMethodFlags): Added support for
5995 inflated generic methods.
5997 * generics.cs (ConstructedType): Distinguish between open and
5998 closed constructed types; correctly resolve the arguments.
6000 2003-09-22 Martin Baulig <martin@ximian.com>
6002 * generic.cs (ConstructedType.ResolveAsTypeCheck): Check whether
6003 all type arguments meet their constraints.
6005 2003-09-19 Martin Baulig <martin@ximian.com>
6007 * decl.cs (MemberCache.SetupCacheForInterface): Take a
6008 `MemberCache parent' argument. Normally, an interface doesn't
6009 have a parent type except System.Object, but we use this in gmcs
6010 for generic type parameters.
6012 2003-09-18 Martin Baulig <martin@ximian.com>
6014 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
6015 on `type.IsInterface'; don't check whether the type has a parent
6016 to determine whether it's an interface.
6018 2003-09-17 Martin Baulig <martin@ximian.com>
6020 * generic.cs (ConstructedType.ToString): Always use `name' as the
6023 2003-09-15 Martin Baulig <martin@ximian.com>
6025 * cs-parser.jay: Fix grammar wrt. type_parameter_constraints.
6027 * generic.cs (Constraints.Resolve): New public method; this is
6028 called to resolve the constraint types and to check whether all
6029 the constraints are correct.
6030 (Constraints.Types): New public property.
6031 (TypeParameter.Resolve): New public method; resolves all the
6034 * class.cs (TypeContainer.DefineType): Call
6035 TypeParameter.Resolve() before actually defining the type.
6037 2003-09-15 Martin Baulig <martin@ximian.com>
6039 * class.cs (TypeContainer.DefineType): Added an error flag to
6040 avoid reporting duplicate CS0146's ("class definition is
6043 * driver.cs (Driver.MainDriver): Abort if
6044 RootContext.ResolveTree() reported any errors.
6046 2003-09-07 Martin Baulig <martin@ximian.com>
6048 * report.cs (Error, Warning): Added overloaded versions which take
6049 a `params object[] args' and call String.Format().
6051 2003-09-07 Martin Baulig <martin@ximian.com>
6053 * decl.cs (DeclSpace..ctor): Don't call
6054 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
6055 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
6056 (DeclSpace.RecordDecl): New method.
6058 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
6060 2003-09-02 Ravi Pratap <ravi@ximian.com>
6062 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
6063 value attributes to be applied to ParameterBuilders.
6065 * class.cs (MethodCore.LabelParameters): Make static and more
6066 generic so that it can be used from other places - like interface
6067 methods, for instance.
6069 * interface.cs (Interface.Emit): Call LabelParameters before
6070 emitting attributes on the InterfaceMethod.
6072 2003-09-07 Martin Baulig <martin@ximian.com>
6074 * generic.cs (ConstructedType.ResolveAsTypeStep): Report a CS8217
6075 if the number of type parameters doesn't match.
6077 2003-09-04 Martin Baulig <martin@ximian.com>
6079 * expression.cs (ComposedCast.ResolveAsTypeStep): Added support
6080 for arrays of generic type params (ie. `!0[]').
6082 2003-09-04 Martin Baulig <martin@ximian.com>
6084 * class.cs (TypeContainer.AsAccessible): Ignore generic parameters
6087 2003-09-04 Martin Baulig <martin@ximian.com>
6089 * decl.cs (DeclSpace.LookupGeneric): New method.
6090 (DeclSpace.CheckAccessLevel): Ignore generic parameters for the
6093 * generic.cs (TypeParameterExpr): Take a TypeParameter as
6094 argument, not just a string.
6095 (TypeParameter.Define): New public method; this is called to
6096 actually define the generic parameter; after this, you can use the
6097 new `Type' property to get the type.
6099 2003-09-04 Martin Baulig <martin@ximian.com>
6101 * decl.cs (DeclSpace.SetParameterInfo): The `constraints' argument
6102 is now an ArrayList; initialize the result of the `TypeParameters'
6104 (DeclSpace.GetGenericData): Removed.
6105 (DeclSpace.LookupGeneric): Temporarily removed; we need to
6106 implement this in a different way.
6107 (DeclSpace.GetTypeParameters): Removed; there's now a
6108 `TypeParameters' property.
6109 (DeclSpace.TypeParameters): New public property.
6111 * generic.cs (Constraints): Make this class public.
6112 (TypeParameter): New public class.
6114 2003-09-04 Martin Baulig <martin@ximian.com>
6116 * decl.cs (DeclSpace.GetTypeParameters): New method to return the
6119 * class.cs (TypeContainer.DefineType): Call
6120 TypeBuilder.DefineGenericParameter () on all generic parameters if
6121 this is a generic type.
6123 2003-08-28 Martin Baulig <martin@ximian.com>
6125 * sample-stack.il: Compile this with ilasm: "ilasm /dll
6128 * sample-hello.cs: Compile this with gmcs: "gmcs
6129 /r:sample-stack.dll sample-hello.cs".
6131 2003-08-28 Martin Baulig <martin@ximian.com>
6133 * generic.cs (ConstructedType.ResolveAsTypeStep): Actually bind
6134 the parameters to the generic type.
6136 2003-08-28 Martin Baulig <martin@ximian.com>
6138 * cs-tokenizer.cs (parse_less_than): Also allow all builtin types.
6140 2003-08-28 Martin Baulig <martin@ximian.com>
6142 * cs-parser.jay (opt_type_argument_list): Use
6143 `OP_GENERICS_LT type_arguments OP_GENERICS_GT'.
6144 (primary_expression): Replace `qualified_identifier' with `type_name'.
6145 (type_parameter_list): Use `OP_GENERICS_LT type_parameters OP_GENERICS_GT'.
6147 * cs-tokenizer.cs (is_punct): When reading a `<', invoke a custom
6148 parser to check whether it is syntactically a type parameter list;
6149 return OP_GENERICS_LT/OP_GENERICS_GT instead of OP_LT/OP_GT in
6152 2003-08-26 Martin Baulig <martin@ximian.com>
6154 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
6155 resolving aliases; fixes #47927.
6157 2003-08-26 Martin Baulig <martin@ximian.com>
6159 * statement.cs (Using.DoResolve): This is internally emitting a
6160 try/finally clause, so we need to set ec.NeedExplicitReturn if we
6161 do not always return. Fixes #47681.
6163 2003-08-26 Martin Baulig <martin@ximian.com>
6165 * decl.cs (MemberCore): Moved WarningNotHiding(),
6166 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
6168 (AdditionResult): Make this nested in DeclSpace.
6169 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
6170 argument; call NamespaceEntry.Define() unless we're nested in a
6173 * namespace.cs (Namespace.DefineName): New public function. This
6174 is called from DeclSpace's .ctor to add
6175 (Namespace.Lookup): Include DeclSpaces in the lookup.
6177 * class.cs (Operator): Derive from MemberBase, not MemberCore.
6179 * const.cs (Const): Derive from MemberBase, not MemberCore.
6181 2003-08-25 Martin Baulig <martin@ximian.com>
6183 * convert.cs (Convert.ExplicitReferenceConversion): When
6184 converting from an interface type to a class, unbox if the target
6185 type is a struct type. Fixes #47822.
6187 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6189 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
6192 2003-08-22 Martin Baulig <martin@ximian.com>
6194 * class.cs (TypeManager.DefineType): When defining a nested type,
6195 call DefineType() on our parent; fixes #47801.
6197 2003-08-22 Martin Baulig <martin@ximian.com>
6199 * class.cs (MethodData.Define): While checking if a method is an
6200 interface implementation, improve the test a bit more to fix #47654.
6202 2003-08-22 Martin Baulig <martin@ximian.com>
6204 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
6205 correctly; fixes #47722.
6207 2003-08-22 Martin Baulig <martin@ximian.com>
6209 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
6210 LocalVariableReference, ensure it's not read-only. Fixes #47536.
6212 * statement.cs (Fixed.DoResolve): Make all variables read-only.
6214 2003-08-22 Martin Baulig <martin@ximian.com>
6216 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
6217 can only be assigned in static constructors. Fixes #47161.
6219 2003-08-22 Martin Baulig <martin@ximian.com>
6221 Rewrote and improved the flow analysis code.
6223 * flowbranching.cs (FlowBranching): Make this class abstract.
6224 (FlowBranching.CreateBranching): New static function to create a
6226 (FlowBranchingBlock, FlowBranchingException): New classes.
6227 (FlowBranching.UsageVector.Type): New public readonly field.
6228 (FlowBranching.UsageVector.Breaks): Removed the setter.
6229 (FlowBranching.UsageVector.Returns): Removed the setter.
6230 (FlowBranching.UsageVector): Added Break(), Return(),
6231 NeverReachable() and Throw() methods to modify the reachability.
6232 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
6233 done by FlowBranching.Merge().
6234 (FlowBranching.UsageVector.MergeChild): New method; merges the
6235 merge result into the current vector.
6236 (FlowBranching.Merge): New abstract method to merge a branching.
6238 2003-08-12 Martin Baulig <martin@ximian.com>
6240 * expression.cs (Indirection.CacheTemporaries): Create the
6241 LocalTemporary with the pointer type, not its element type.
6243 2003-08-10 Miguel de Icaza <miguel@ximian.com>
6245 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
6246 token was a keyword or not.
6248 Add `error' options where an IDENTIFIER was expected; Provide
6249 CheckToken and CheckIdentifierToken convenience error reporting
6252 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
6254 * decl.cs: Rename `NamespaceEntry Namespace' public field into
6255 NameSpaceEntry NameSpaceEntry.
6257 (LookupInterfaceOrClass): Avoid creating a full qualified name
6258 from namespace and name: avoid doing lookups when we know the
6259 namespace is non-existant. Use new Tree.LookupByNamespace which
6260 looks up DeclSpaces based on their namespace, name pair.
6262 * driver.cs: Provide a new `parser verbose' to display the
6263 exception thrown during parsing. This is turned off by default
6264 now, so the output of a failure from mcs is more graceful.
6266 * namespace.cs: Track all the namespaces defined in a hashtable
6269 (IsNamespace): New method
6271 2003-08-09 Miguel de Icaza <miguel@ximian.com>
6273 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
6274 we know that we need to concatenate (full typename can never be
6279 * statement.cs: Use a bitfield; Do not initialize to null things
6280 which are done by the constructor by default.
6282 * cs-parser.jay: bug fix, parameter was 4, not 3.
6284 * expression.cs: Just use the property;
6286 * statement.cs: No need for GetVariableInfo method.
6288 2003-08-08 Martin Baulig <martin@ximian.com>
6290 * flowanalysis.cs (FlowReturns): This is now nested in the
6291 `FlowBranching' class.
6292 (MyBitVector): Moved this here from statement.cs.
6293 (FlowBranching.SiblingType): New enum type.
6294 (FlowBranching.CreateSibling): Added `SiblingType' argument.
6296 2003-08-07 Martin Baulig <martin@ximian.com>
6298 * flowanalysis.cs (FlowBranchingType): This is now nested in the
6299 `FlowBranching' class and called `BranchingType'.
6301 2003-08-07 Martin Baulig <martin@ximian.com>
6303 * flowanalysis.cs: Moved all the control flow analysis code into
6306 2003-08-07 Martin Baulig <martin@ximian.com>
6308 * assign.cs (Assign.DoResolve): `target' must either be an
6309 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
6312 2003-08-07 Miguel de Icaza <miguel@ximian.com>
6314 * expression.cs (BinaryMethod): This kind of expression is created by the
6315 Binary class if it determines that the operator has to be handled
6318 (BinaryDelegate): This kind of expression is created if we are
6319 dealing with a + or - operator on delegates.
6321 (Binary): remove method, argumetns, and DelegateOperator: when
6322 dealing with methods,
6324 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
6326 * statement.cs (Block): use bitfields for the three extra booleans
6327 we had in use. Remove unused topblock parameter.
6329 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
6331 * assign.cs: Drop extra unneeded tests.
6333 2003-08-06 Miguel de Icaza <miguel@ximian.com>
6335 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
6337 * statement.cs (Foreach): Use VariableStorage instead of
6340 * codegen.cs (VariableStorage): New class used by clients that
6341 require a variable stored: locals or fields for variables that
6342 need to live across yield.
6344 Maybe provide a convenience api for EmitThis+EmitLoad?
6346 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
6349 2003-08-05 Miguel de Icaza <miguel@ximian.com>
6351 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
6352 RemapParameterLValue): New methods that are used to turn a
6353 precomputed FieldInfo into an expression like this:
6357 The idea is to use this instead of making LocalVariableReference
6358 have more than one meaning.
6360 * cs-parser.jay: Add error production to BASE.
6362 * ecore.cs: Deal with TypeManager.GetField returning null, which
6363 is now a valid return value.
6365 (FieldExprNoAddress): New expression for Fields whose address can
6368 * expression.cs (LocalVariableReference): During the resolve
6369 phases, create new expressions if we are in a remapping context.
6370 Remove code that dealt with remapping here.
6372 (ParameterReference): same.
6374 (ProxyInstance): New expression, like the `This' expression, but
6375 it is born fully resolved. We know what we are doing, so remove
6376 the errors that are targeted to user-provided uses of `this'.
6378 * statement.cs (Foreach): our variable is now stored as an
6379 Expression; During resolution, follow the protocol, dont just
6380 assume it will return this.
6382 2003-08-06 Martin Baulig <martin@ximian.com>
6384 * support.cs (SeekableStreamReader.cs): New public class.
6386 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
6387 SeekableStreamReader instead of the normal StreamReader.
6389 2003-08-04 Martin Baulig <martin@ximian.com>
6391 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
6392 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
6393 deambiguate casts and delegate invocations.
6394 (parenthesized_expression): Use the new tokens to ensure this is
6395 not a cast of method invocation.
6397 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
6398 when reading a `)' and Deambiguate_CloseParens () was previously
6401 * expression.cs (ParenthesizedExpression): New class. This is
6402 just used for the CS0075 test.
6403 (Binary.DoResolve): Check for CS0075.
6405 2003-07-29 Ravi Pratap <ravi@ximian.com>
6407 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
6408 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
6409 reference comparison.
6411 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
6412 examine the ReturnType for equality - this is necessary in the
6413 cases of implicit and explicit operators whose signature also
6414 includes the return type.
6416 2003-07-26 Miguel de Icaza <miguel@ximian.com>
6418 * namespace.cs: Cache the result of the namespace computation,
6419 instead of computing it every time.
6421 2003-07-24 Miguel de Icaza <miguel@ximian.com>
6423 * decl.cs: Use a global arraylist that we reuse over invocations
6424 to avoid excesive memory consumption. Reduces memory usage on an
6425 mcs compile by one meg (45 average).
6427 * typemanager.cs (LookupTypeReflection): In .NET pointers are
6428 private, work around that.
6430 2003-07-23 Miguel de Icaza <miguel@ximian.com>
6432 * literal.cs (IntLiteral): Define Zero and One static literals.
6434 * cs-parser.jay (integer_literal): use static literals to reduce
6435 memory usage for the most used literals (0, 1 and -1). 211kb
6436 reduced in memory usage.
6438 Replace all calls to `new ArrayList' with `new
6439 ArrayList(4)' which is a good average number for most allocations,
6440 and also requires only 16 bytes of memory for its buffer by
6443 This reduced MCS memory usage in seven megabytes for the RSS after
6446 2003-07-28 Ravi Pratap <ravi@ximian.com>
6448 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
6449 handle params methods the correct way by forming only one
6450 applicable set with params and normal methods in them. Earlier we
6451 were looking at params methods only if we found no normal methods
6452 which was not the correct thing to do.
6454 (Invocation.BetterFunction): Take separate arguments indicating
6455 when candidate and the best method are params methods in their
6458 This fixes bugs #43367 and #46199.
6460 * attribute.cs: Documentation updates.
6462 (CheckAttribute): Rename to CheckAttributeTarget.
6463 (GetValidPlaces): Rename to GetValidTargets.
6465 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
6466 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
6470 2003-07-28 Miguel de Icaza <miguel@ximian.com>
6472 * codegen.cs: Compute IsGeneric correctly.
6474 * cs-parser.jay: Introduce OP_GENERIC_LT for the grammar ambiguity
6477 Bring back (temporarily) OP_LEFT_SHIFT, OP_RIGHT_SHIFT,
6478 OP_SHIFT_RIGHT_ASSIGN, OP_SHIFT_LEFT_ASSIGN. There were too many
6479 regressions, and I was chasing more bugs than I required.
6481 * interface.cs: Use expressions for base type names (like classes
6482 and structs have been doing for a while now), and resolve that.
6483 This patch should probably go into head as well.
6485 This makes it one less user of FindType.
6487 2003-07-24 Miguel de Icaza <miguel@ximian.com>
6489 This compiler can not self host currently. Need to fix that.
6491 * Makefile: compile to `gmcs.exe'
6493 * driver.cs: Turn on v2 by default on gmcs.
6495 * generic.cs (ConstructedType): Does no longer take a container
6496 type argument; That will be taken care of later.
6498 (ConstructedType.DoResolve, ConstructedType.ResolveAsTypeStep):
6499 Use SimpleName to resolve for now, so we can continue the work on
6500 the parser, until we get Type.GetType that understands generics.
6502 (ConstructedType.ToString): Implement
6504 (TypeArguments.Resolve): Resolve the child expressions as types.
6506 * cs-parser.jay: Rename interface_constraints to
6507 type_parameter_constraints
6509 (namespace_or_type_name): Only use constructed types for the basic
6510 construction, we will deal with identifier<...> later.
6512 (type/type_name): No longer call DecomposeQI, as
6513 namespace_or_type_name is always decoded now.
6515 2003-07-22 Ravi Pratap <ravi@ximian.com>
6517 * expression.cs (Invocation.OverloadResolve): Follow the spec more
6518 closely: we eliminate methods in base types when we have an
6519 applicable method in a top-level type.
6521 Please see section 14.5.5.1 for an exact description of what goes
6524 This fixes bug #45127 and a host of other related to corlib compilation.
6526 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
6527 array is the method corresponding to the top-level type (this is
6528 because of the changes made to icall.c) so we change this
6531 (MethodGroupExpr.Name): This too.
6533 * typemanager.cs (GetElementType): New method which does the right
6534 thing when compiling corlib.
6536 * everywhere: Make use of the above in the relevant places.
6538 2003-07-22 Martin Baulig <martin@ximian.com>
6540 * cs-parser.jay (invocation_expression): Moved
6541 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
6542 `cast_expression', but create a InvocationOrCast which later
6543 resolves to either an Invocation or a Cast.
6545 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
6546 method; call this before EmitStatement() to make sure that this
6547 expression can be used as a statement.
6549 * expression.cs (InvocationOrCast): New class; resolves to either
6550 an Invocation or a Cast.
6552 * statement.cs (StatementExpression): Call ResolveStatement() on
6553 the ExpressionStatement before emitting it.
6555 2003-07-21 Martin Baulig <martin@ximian.com>
6557 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
6558 `ref' and `out' attributes match; fixes #46220.
6559 (MemberAccess.ResolveMemberAccess): You can't reference a type
6560 through an expression; fixes #33180.
6561 (Indexers.GetIndexersForType): Don't return the indexers from
6562 interfaces the class implements; fixes #46502.
6564 2003-07-21 Martin Baulig <martin@ximian.com>
6566 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
6567 CS0661 checks; fixes bug #30442.
6569 2003-07-21 Martin Baulig <martin@ximian.com>
6571 * decl.cs (AdditionResult): Added `Error'.
6573 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
6575 * typemanager.cs (TypeManager.ChangeType): Catch exceptions; makes
6576 cs0031.cs actually work.
6578 2003-07-20 Miguel de Icaza <miguel@ximian.com>
6580 * cs-parser.jay (namespace_name): do not use
6581 namespace_or_type_name, use qualified_identifier, because
6582 namespace_or_type_name will soon return a composed expression
6583 instead of a string.
6585 (namespace_or_type_name): Instead of returning a string, now this
6586 production returns an expression.
6588 * codegen.cs (EmitContext): Setup IsGeneric property based on
6589 whether our DeclSpace is generic, our the method is generic.
6591 * modifier.cs (Modifiers.METHOD_GENERIC): New definition, use if
6592 the method is generic.
6594 * cs-parser.jay (type_arguments, opt_type_argument_list,
6595 type_parameters, type_parameter_list, opt_type_parameter_list,
6596 type_parameter,, opt_type_parameter_constraints_clauses,
6597 type_parameter_constraints_clauses,
6598 type_parameter_constraint_clause, type_parameter_constraint,
6599 interface_constraints): Add new production
6601 * decl.cs (DeclSpace): IsGeneric, flag to track whether this
6602 DeclSpace is generic or not.
6604 (DeclSpace.SetParameterInfo): New routine, used to set the
6605 parameter info for a type.
6607 (DeclSpace.LookupGeneric): Lookups a name, and if it is a generic,
6608 returns a GenericTypeExpr
6610 * ecore.cs (SimpleName.ResolveAsTypeStep): If our container is
6611 generic, lookup the generic argument.
6613 * attribute.cs: Do not allow TypeParameterExpressions in
6616 * class.cs: Do not allow the Main method to be defined in a
6619 * expression.cs (SizeOf): Do not allow generic types to be used as
6620 arguments to sizeof.
6622 * typemanager.cs (IsGeneric): Wrapper for Reflection when we have
6623 it: whether a type is generic or not. Only works for types we are
6624 currently building for now.
6626 2003-07-20 Martin Baulig <martin@ximian.com>
6628 * namespace.cs: Fixed that bug which caused a crash when compiling
6631 2003-07-20 Miguel de Icaza <miguel@ximian.com>
6633 * typemanager.cs (LookupTypeReflection): Never expose types which
6634 are NotPublic, NestedPrivate, NestedAssembly, or
6635 NestedFamANDAssem. We used to return these, and later do a check
6636 that would report a meaningful error, but the problem is that we
6637 would not get the real match, if there was a name override.
6639 2003-07-18 Miguel de Icaza <miguel@ximian.com>
6641 * namespace.cs (Namespace, Name): Do not compute the namespace
6642 name dynamically, compute it in the constructor. This reduced
6643 memory usage by 1697 KB.
6645 * driver.cs: Use --pause to pause at the end.
6647 2003-07-17 Peter Williams <peter@newton.cx>
6649 * Makefile: Change the name of the test target so that it doesn't
6650 conflict with the recursive test target.
6652 2003-07-17 Miguel de Icaza <miguel@ximian.com>
6654 * expression.cs (LocalVariableReference.Emit, EmitAssign,
6655 AddressOf): Do not use EmitThis, that was wrong, use the actual
6658 2003-07-15 Miguel de Icaza <miguel@ximian.com>
6660 * class.cs (MethodData.Define): While checking if a method is an
6661 interface implementation, improve the test: If we are not public
6662 (use new test here: use the computed MethodAttributes directly,
6663 instead of the parsed modifier flags) check if the `implementing'
6664 method comes from an interface or not.
6666 * pending.cs (VerifyPendingMethods): Slightly better error
6669 * makefile: add test target that does the mcs bootstrap.
6671 2003-07-16 Ravi Pratap <ravi@ximian.com>
6673 * interface.cs (Define): Do nothing here since there are no
6674 members to populate etc. Move the attribute emission out of here
6675 since this was just totally the wrong place to put it. Attribute
6676 application happens during the 'Emit' phase, not in the 'Define'
6679 (Emit): Add this method and move the attribute emission here
6681 * rootcontext.cs (EmitCode): Call the Emit method on interface
6684 2003-07-14 Ravi Pratap M <ravi@ximian.com>
6686 * expression.cs (OverloadResolve): Report error only if Location
6687 is not 'Null' which means that there was a probe going on.
6689 2003-07-14 Martin Baulig <martin@ximian.com>
6691 * expression.cs (ConditionalLogicalOperator): New public class to
6692 implement user defined conditional logical operators.
6693 This is section 14.11.2 in the spec and bug #40505.
6695 2003-07-14 Martin Baulig <martin@ximian.com>
6697 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
6699 2003-07-14 Martin Baulig <martin@ximian.com>
6701 * codegen.cs (EmitContext.InFixedInitializer): New public field.
6703 * ecore.cs (IVariable.VerifyFixed): New interface method.
6705 * expression.cs (Unary.ResolveOperator): When resolving the `&'
6706 operator, check whether the variable is actually fixed. Fixes bug
6707 #36055. Set a variable definitely assigned when taking its
6708 address as required by the spec.
6710 * statement.cs (LocalInfo.IsFixed): New field.
6711 (LocalInfo.MakePinned): Set `IsFixed' to true.
6713 2003-07-14 Ravi Pratap M <ravi@ximian.com>
6715 * attribute.cs (Attribute.Resolve): While doing a Member lookup
6716 for .ctors, ensure that we only ask for members declared in the
6717 attribute type (BindingFlags.DeclaredOnly).
6721 * expression.cs (Error_WrongNumArguments): Report error 1501
6722 correctly the way CSC does.
6724 2003-07-13 Martin Baulig <martin@ximian.com>
6726 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
6727 lookup on the fully qualified name, to make things like "X.X" work
6728 where "X.X" is a fully qualified type name, but we also have a
6729 namespace "X" in the using list. Fixes #41975.
6731 2003-07-13 Martin Baulig <martin@ximian.com>
6733 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
6734 function. If we're a CompoundAssign, we need to create an embedded
6735 CompoundAssign, not an embedded Assign.
6736 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
6739 2003-07-13 Martin Baulig <martin@ximian.com>
6741 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
6742 work to fix bug #46088.
6744 2003-07-13 Ravi Pratap <ravi@ximian.com>
6746 * class.cs (Operator.Emit): Do not emit attributes here - it is
6747 taken care of by the Method class that we delegate too. This takes
6750 2003-07-10 Martin Baulig <martin@ximian.com>
6752 * expression.cs (TypeOfVoid): New class.
6753 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
6755 2003-07-10 Martin Baulig <martin@ximian.com>
6757 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
6760 2003-07-10 Martin Baulig <martin@ximian.com>
6762 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
6763 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
6765 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
6767 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
6769 2003-07-10 Martin Baulig <martin@ximian.com>
6771 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
6772 of decimal. Fixes #42850.
6774 NOTE: I also fixed the created byte blob, but this doesn't work on
6775 the MS runtime and csc never produces any byte blobs for decimal
6778 2003-07-10 Martin Baulig <martin@ximian.com>
6780 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
6781 structs; fixes #32068.
6782 (Block.AddChildVariableNames): Fixed #44302.
6784 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6786 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
6788 2003-07-07 Miguel de Icaza <miguel@ximian.com>
6790 * attribute.cs: And this test is onger needed.
6792 2003-07-08 Martin Baulig <martin@ximian.com>
6794 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
6795 inaccessible types. Fixes #36313.
6797 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
6799 * namespace.cs (NamespaceEntry): Create implicit entries for all
6800 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
6801 implicit entries for N1.N2 and N1.
6803 2003-07-08 Martin Baulig <martin@ximian.com>
6805 Rewrote the handling of namespaces to fix a lot of the issues
6806 wrt. `using' aliases etc.
6808 * namespace.cs (Namespace): Splitted this class into a
6809 per-assembly `Namespace' and a per-file `NamespaceEntry'.
6811 * typemanager.cs (TypeManager.IsNamespace): Removed.
6812 (TypeManager.ComputeNamespaces): Only compute namespaces from
6813 loaded assemblies here, not the namespaces from the assembly we're
6814 currently compiling.
6816 2003-07-08 Martin Baulig <martin@ximian.com>
6818 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
6820 2003-07-07 Miguel de Icaza <miguel@ximian.com>
6822 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
6825 I thought about the memory savings here, but LookupTypeReflection
6826 is used under already very constrained scenarios. Compiling
6827 corlib or mcs only exposes one hit, so it would not really reduce
6828 any memory consumption.
6830 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6832 * typemanager.cs: fixes bug #45889 by only adding public types from
6833 other assemblies to the list of known types.
6835 2003-07-07 Miguel de Icaza <miguel@ximian.com>
6837 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
6838 on the type we resolved.
6840 2003-07-05 Martin Baulig <martin@ximian.com>
6842 * pending.cs (PendingImplementation.ParentImplements): Don't
6843 create the proxy if the parent is abstract.
6845 * class.cs (TypeContainer.DefineIndexers): Process explicit
6846 interface implementations first. Fixes #37714.
6848 2003-07-04 Miguel de Icaza <miguel@ximian.com>
6850 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
6851 defined recursively; but since we modify the input parameters
6852 (left is set to `this' temporarily), we reset this value if the
6853 left_is_explicit is false, which gives the original semantics to
6856 * literal.cs (NullPointer): new class used to represent a null
6857 literal in a pointer context.
6859 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
6860 type is a pointer, use a NullPointer object instead of a
6861 NullLiteral. Closes 43687
6863 (ExplicitConversion): Convert pointer values using
6864 the conv opcode to the proper type.
6866 * ecore.cs (New): change ValueTypeVariable property into a method,
6867 that returns whether the valuetype is suitable for being used.
6869 * expression.cs (Binary.DoNumericPromotions): Only return if we
6870 the int constant was a valid uint, and we can return both left and
6871 right as uints. If not, we continue processing, to trigger the
6872 type conversion. This fixes 39018.
6874 * statement.cs (Block.EmitMeta): During constant resolution, set
6875 the CurrentBlock property on the emitcontext, so that we resolve
6876 constants propertly.
6878 2003-07-02 Martin Baulig <martin@ximian.com>
6880 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
6881 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
6883 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
6884 than emitting it here.
6886 * statement.cs: Fixed some more flow analysis bugs.
6888 2003-07-02 Martin Baulig <martin@ximian.com>
6890 * class.cs (MethodData.Define): When implementing interface
6891 methods, set Final unless we're Virtual.
6893 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
6894 check work for interface methods.
6896 2003-07-01 Martin Baulig <martin@ximian.com>
6898 * ecore.cs (EmitContext.This): Replaced this property with a
6899 GetThis() method which takes a Location argument. This ensures
6900 that we get the correct error location for a CS0188.
6902 2003-07-01 Miguel de Icaza <miguel@ximian.com>
6904 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
6905 ImplicitStandardConversion.
6907 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
6909 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
6911 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
6914 2003-06-30 Miguel de Icaza <miguel@ximian.com>
6916 * class.cs (Constructor.Define): Turn off initlocals for unsafe
6919 (MethodData.Define): Turn off initlocals for unsafe methods.
6921 2003-06-29 Miguel de Icaza <miguel@ximian.com>
6923 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
6924 complete; Fixes #37521.
6926 * delegate.cs: Use Modifiers.TypeAttr to compute the
6927 TypeAttributes, instead of rolling our own. This makes the flags
6928 correct for the delegates.
6930 2003-06-28 Miguel de Icaza <miguel@ximian.com>
6932 * class.cs (Constructor.Define): Set the private flag for static
6933 constructors as well.
6935 * cs-parser.jay (statement_expression): Set the return value to
6936 null, to avoid a crash when we catch an error.
6938 2003-06-24 Miguel de Icaza <miguel@ximian.com>
6940 * cs-parser.jay: Applied patch from Jackson that adds support for
6941 extern and unsafe modifiers to destructor declarations.
6943 * expression.cs: Report error 21 if the user is trying to index a
6946 * driver.cs: Add an error message, suggested by the bug report.
6948 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
6949 if we do not have a ": this ()" constructor initializer. Fixes 45149
6951 2003-06-14 Miguel de Icaza <miguel@ximian.com>
6953 * namespace.cs: Add some information to reduce FAQs.
6955 2003-06-13 Miguel de Icaza <miguel@ximian.com>
6957 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
6958 underlying enumeration types. Fixes #43915.
6960 * expression.cs: Treat ushort/short as legal values to be used in
6963 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
6965 * delegate.cs: transfer custom attributes for paramenters from
6966 the delegate declaration to Invoke and BeginInvoke.
6968 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
6970 * attribute.cs: handle custom marshalers and emit marshal info
6973 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
6975 * makefile.gnu: Added anonymous.cs to the compiler sources.
6977 2003-05-28 Miguel de Icaza <miguel@ximian.com>
6979 * iterators.cs: Change the name of the proxy class to include two
6982 * cs-parser.jay: Update grammar to include anonymous methods.
6984 * anonymous.cs: new file.
6986 2003-05-27 Miguel de Icaza <miguel@ximian.com>
6988 * class.cs (Field.Define): Add missing test for pointers and
6991 2003-05-27 Ravi Pratap <ravi@ximian.com>
6993 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
6994 we use the stobj opcode.
6996 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
6997 since it wasn't the correct fix.
6999 It still is puzzling that we are required to use stobj for IntPtr
7000 which seems to be a ValueType.
7002 2003-05-26 Miguel de Icaza <miguel@ximian.com>
7004 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
7005 during regular simple name resolution. Now, the trick is that
7006 instead of returning for processing the simplename, we do a
7007 TypeManager.LookupType (ie, a rooted lookup as opposed to a
7008 contextual lookup type). If a match is found, return that, if
7009 not, return for further composition.
7011 This fixes long-standing 30485.
7013 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
7014 using the address to initialize an object, do an Stobj instead of
7015 using the regular Stelem.
7017 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
7018 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
7019 Because if we are a BaseIndexerAccess that value will be true.
7022 * statement.cs (GotoCase.Resolve): Return after reporting an
7023 error, do not attempt to continue.
7025 * expression.cs (PointerArithmetic.Emit): If our operand is a
7026 long, convert our constants to match the operand before
7027 multiplying. Convert to I type before adding. Fixes 43670.
7029 2003-05-14 Ravi Pratap <ravi@ximian.com>
7031 * enum.cs (ImplicitConversionExists) : Rename to
7032 ImplicitEnumConversionExists to remove ambiguity.
7034 * ecore.cs (NullCast): New type of cast expression class which
7035 basically is very similar to EmptyCast with the difference being
7036 it still is a constant since it is used only to cast a null to
7040 * convert.cs (ImplicitReferenceConversion): When casting a null
7041 literal, we return a NullCast.
7043 * literal.cs (NullLiteralTyped): Remove - I don't see why this
7044 should be around anymore.
7046 The renaming (reported was slightly wrong). Corrections:
7048 ConvertImplicitStandard -> ImplicitConversionStandard
7049 ConvertExplicitStandard -> ExplicitConversionStandard
7051 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
7052 before passing them in !
7054 * convert.cs (ImplicitConversionStandard): When comparing for
7055 equal expr and target types, ensure that expr is not a
7058 In general, we must not be checking (expr_type ==
7059 target_type) in the top level conversion methods
7060 (ImplicitConversion, ExplicitConversion etc). This checking is
7061 done in the methods that they delegate to.
7063 2003-05-20 Miguel de Icaza <miguel@ximian.com>
7065 * convert.cs: Move Error_CannotConvertType,
7066 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
7067 ImplicitNumericConversion, ImplicitConversionExists,
7068 ImplicitUserConversionExists, StandardConversionExists,
7069 FindMostEncompassedType, FindMostSpecificSource,
7070 FindMostSpecificTarget, ImplicitUserConversion,
7071 ExplicitUserConversion, GetConversionOperators,
7072 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
7073 TryImplicitIntConversion, Error_CannotConvertImplicit,
7074 ConvertImplicitRequired, ConvertNumericExplicit,
7075 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
7076 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
7079 Perform the following renames:
7081 StandardConversionExists -> ImplicitStandardConversionExists
7082 ConvertImplicit -> ImplicitConversion
7083 ConvertImplicitStandard -> ImplicitStandardConversion
7084 TryImplicitIntConversion -> ImplicitIntConversion
7085 ConvertImplicitRequired -> ImplicitConversionRequired
7086 ConvertNumericExplicit -> ExplicitNumericConversion
7087 ConvertReferenceExplicit -> ExplicitReferenceConversion
7088 ConvertExplicit -> ExplicitConversion
7089 ConvertExplicitStandard -> ExplicitStandardConversion
7091 2003-05-19 Martin Baulig <martin@ximian.com>
7093 * statement.cs (TypeInfo.StructInfo): Made this type protected.
7094 (TypeInfo): Added support for structs having structs as fields.
7096 * ecore.cs (FieldExpr): Implement IVariable.
7097 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
7098 VariableInfo for the field.
7100 2003-05-18 Martin Baulig <martin@ximian.com>
7102 * expression.cs (This.DoResolve): Report a CS0027 if we're
7103 emitting a field initializer.
7105 2003-05-18 Martin Baulig <martin@ximian.com>
7107 * expression.cs (This.ResolveBase): New public function.
7108 (This.DoResolve): Check for CS0188.
7110 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
7113 * ecore.cs (MethodGroupExpr.DoResolve): Set the
7114 `instance_expression' to null if we don't have any non-static
7117 2003-05-18 Martin Baulig <martin@ximian.com>
7119 Reworked the way how local variables and parameters are handled by
7120 the flow analysis code.
7122 * statement.cs (TypeInfo, VariableMap): New public classes.
7123 (VariableInfo): New public class. This is now responsible for
7124 checking whether a variable has been assigned. It is used for
7125 parameters and local variables.
7126 (Block.EmitMeta): Take the InternalParameters as argument; compute
7127 the layout of the flow vectors here.
7128 (Block.LocalMap, Block.ParameterMap): New public properties.
7129 (FlowBranching): The .ctor doesn't get the InternalParameters
7130 anymore since Block.EmitMeta() now computes the layout of the flow
7132 (MyStructInfo): This class is now known as `StructInfo' and nested
7133 in `TypeInfo'; we don't access this directly anymore.
7135 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
7136 property and removed IsAssigned(), IsFieldAssigned(),
7137 SetAssigned() and SetFieldAssigned(); we now call them on the
7138 VariableInfo so we don't need to duplicate this code everywhere.
7140 * expression.cs (ParameterReference): Added `Block block' argument
7142 (LocalVariableReference, ParameterReference, This): The new
7143 VariableInfo class is now responsible for all the definite
7146 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
7147 IsParameterAssigned, SetParameterAssigned): Removed.
7149 2003-05-18 Martin Baulig <martin@ximian.com>
7151 * typemanager.cs (InitCoreTypes): Try calling
7152 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
7153 the 3-args-version. Corlib now also needs our `void_type'.
7154 (GetMethod): Added overloaded version which takes an optional
7155 `bool report_errors' to allow lookups of optional methods.
7157 2003-05-12 Martin Baulig <martin@ximian.com>
7159 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
7160 only used for locals and not for parameters.
7162 2003-05-12 Miguel de Icaza <miguel@ximian.com>
7164 * support.cs (InternalParameters.ParameterType): Return the
7165 ExternalType of the parameter.
7167 * parameter.cs (Parameter.ExternalType): drop the two arguments,
7170 2003-05-11 Miguel de Icaza <miguel@ximian.com>
7172 * class.cs (MethodData.Define): Do not set the `newslot' on
7173 interface members, if they are also flagged as "override".
7175 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
7176 better code for ++i and i++. This only works for static fields
7177 and local variables.
7179 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
7180 want to pull the DeclSpace out of the builder_to_declspace instead
7181 of the TypeBuilder (like in TypeContainer.FindMembers).
7183 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
7184 instead of LookupTypeContainer. Fixes the crash on .NET for
7185 looking up interface members.
7187 * const.cs: Create our own emit context during the Definition
7188 stage, so that constants are evaluated in the proper context, when
7189 a recursive definition happens.
7191 2003-05-11 Martin Baulig <martin@ximian.com>
7193 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
7194 new block for a switch section.
7195 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
7196 the adding/lookup in the switch block. Fixes #39828.
7198 2003-05-09 Miguel de Icaza <miguel@ximian.com>
7200 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
7201 functionality: I needed to convert the data after I had performed
7202 the add/sub operation into the operands type size.
7204 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
7205 pass the type for the box operation, otherwise the resulting
7206 object would have been of type object.
7208 (BoxedCast): Add constructor to specify the type to box as.
7210 2003-05-07 Miguel de Icaza <miguel@ximian.com>
7212 * iterators.cs: I was reusing the `count' variable inadvertently,
7213 take steps to not allow this to happen.
7215 2003-05-06 Miguel de Icaza <miguel@ximian.com>
7217 * attribute.cs (Attribute.Resolve): Params attributes are encoded
7218 by creating an array at the point where the params starts and
7219 putting all those arguments there, then adjusting the size of the
7222 2003-05-05 Miguel de Icaza <miguel@ximian.com>
7224 * expression.cs (New.AddressOf): Implement interface
7225 IMemoryLocation. This is used when the `new' operator is used in
7226 the context of an invocation to a method on a value type.
7228 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
7231 * namespace.cs: Also check the using aliases here.
7233 * driver.cs: Move the test for using validity after the types have
7234 been entered, so we do a single pass that also includes the using
7237 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
7238 in the regular case. CreateSiblingForFinally is doing extra
7241 * attribute.cs (GetAttributeArgumentExpression): Store the result
7242 on an out value, and use the return value to indicate failure
7243 instead of using null (which is a valid return for Constant.GetValue).
7245 * statement.cs: Perform the analysis flow for the increment
7246 portion after the statement, because this will be the real flow of
7247 execution. Fixes #42385
7249 * codegen.cs (EmitContext.EmitArgument,
7250 EmitContext.EmitStoreArgument): New helper functions when the
7251 RemapToProxy flag is set.
7253 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
7256 Add support for remapping parameters.
7258 * iterators.cs: Propagate parameter values; Store parameter
7259 values in the proxy classes.
7261 2003-05-04 Miguel de Icaza <miguel@ximian.com>
7263 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
7264 need a proxy reference; I do not know what I was thinking
7266 * cs-parser.jay (constructor_initializer): catch another error,
7267 and display nice message.
7269 (field_declaration): catch void field declaration
7270 to flag a better error.
7272 * class.cs (MemberBase.CheckBase): Report an error instead of a
7273 warning if a new protected member is declared in a struct.
7274 (Field.Define): catch the error of readonly/volatile.
7276 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
7278 (FieldExpr.AddressOf): ditto. Catch error where the address of a
7279 volatile variable is taken
7281 2003-05-02 Miguel de Icaza <miguel@ximian.com>
7283 * statement.cs (Fixed.Resolve): Report an error if we are not in
7286 2003-05-01 Miguel de Icaza <miguel@ximian.com>
7288 * typemanager.cs: reuse the code that handles type clashes for
7289 delegates and enumerations.
7291 * class.cs (Report28): Always report.
7293 * expression.cs (EncodeAsAttribute): Allow nulls here.
7295 2003-04-28 Miguel de Icaza <miguel@ximian.com>
7297 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
7298 the functionality for testing whether an expression is valid for
7299 an attribute here. Also handle the case of arrays of elements
7302 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
7303 encoding a linear array into an array of objects that are suitable
7304 to be passed to an CustomAttributeBuilder.
7306 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
7308 * ecore.cs: (FieldExpr): Handle field remapping here.
7310 * iteratators.cs: Pass the instance variable (if the method is an
7311 instance method) to the constructors, so we can access the field
7312 variables on the class.
7314 TODO: Test this with structs. I think the THIS variable on
7315 structs might have to be a pointer, and not a refenrece
7317 2003-04-27 Miguel de Icaza <miguel@ximian.com>
7319 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
7320 local variables to fields in a proxy class.
7322 * iterators.cs (PopulateProxy): Rename our internal fields to
7324 Create a <THIS> field if we are an instance method, so we can
7325 reference our parent container variables.
7326 (MapVariable): Called back from the EmitContext code to enter a
7327 new variable to field mapping into the proxy class (we just create
7331 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
7332 for using the remapped locals to fields.
7334 I placed the code here, because that gives the same semantics to
7335 local variables, and only changes the Emit code.
7337 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
7338 statements inside iterators.
7339 (VariableInfo): Add a FieldBuilder for the cases when we are
7340 remapping local variables to fields in a proxy class
7342 * ecore.cs (SimpleNameResolve): Avoid testing two times for
7343 current_block != null.
7345 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
7346 not cope with strings, as it has been moved to the
7347 TableSwitchEmit. Fixed bug in switch generation.
7349 * expression.cs (New.DoResolve): Provide more context for the user
7350 when reporting an error.
7352 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
7355 * expression.cs (MemberAccess.DoResolve): When we get a type back,
7356 check the permissions for it. Note than in a type-resolution
7357 context the check was already present in DeclSpace.ResolveType,
7358 but was missing from the MemberAccess.
7360 (ArrayCreation.CheckIndices): warn if the user has
7361 more nested levels of expressions, but there are no more
7362 dimensions specified. Avoids crash on bug 41906.
7364 2003-04-26 Miguel de Icaza <miguel@ximian.com>
7366 * statement.cs (Block): replace Implicit bool, for a generic
7368 New flag: `Unchecked'. This is used during the EmitMeta phase
7369 (which is out-of-line with the regular Resolve/Emit process for a
7370 statement, as this is done ahead of time, but still gets a chance
7371 to call constant resolve).
7373 (Block.Flags): new enum for adding a new flag.
7375 (Block.EmitMeta): track the state of unchecked.
7377 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
7378 to enable constant resolution to work there as well.
7380 2003-04-22 Miguel de Icaza <miguel@ximian.com>
7382 * typemanager.cs (ienumerable_type): Also look up
7383 System.Collections.IEnumerable.
7385 2003-04-21 Miguel de Icaza <miguel@ximian.com>
7387 TODO: Test more than one conditional per method.
7389 * class.cs (Indexer.Define): Report the location where the user is
7390 referencing the unsupported feature.
7392 (MethodData): Overload the use of `conditionals' to
7393 minimize the creation of needless ArrayLists. This saves roughly
7394 212kb on my machine.
7396 (Method): Implement the new IIteratorContainer interface.
7397 (Method.SetYields): Implement the method by setting the ModFlags
7398 to contain METHOD_YIELDS.
7400 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
7401 which just got set to null.
7403 * iterators.cs: New file.
7405 (Yield, YieldBreak): New statements.
7407 * statement.cs (Return.Resolve): Flag an error if we are used in
7410 * codegen.cs (InIterator): New flag set if the code is being
7411 compiled in an iterator method.
7413 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
7414 internal modifier, and we just use it to avoid adding extra
7415 fields, as this is seldom used.
7417 * cs-parser.jay: Add yield_statement (yield and yield break).
7419 * driver.cs: New flag -v2 to turn on version 2 features.
7421 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
7422 hashtable when v2 is enabled.
7424 2003-04-20 Miguel de Icaza <miguel@ximian.com>
7426 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
7427 there is already a namespace defined with this name.
7429 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
7430 people upgraded their corlibs.
7432 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
7433 always use fully qualified types, no need to use the compiler
7436 (TypeManager.IsNamespace): Use binarysearch.
7438 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
7439 AddDelegate): I did not quite use the new IsValid API properly: I
7440 have to pass the short-name and the fullname. I was passing only
7441 the basename instead of the fullname sometimes.
7443 (TypeContainer.DefineType): call NamespaceClash.
7445 * interface.cs (Interface.DefineType): use NamespaceClash before
7448 * delegate.cs (Delegate.DefineType): use NamespaceClash before
7451 * enum.cs: (Enum.DefineType): use NamespaceClash before
7454 * typemanager.cs (: 3-line patch that gives us some tasty 11%
7455 speed increase. First, use the negative_hits cache when we get a
7456 negative. Second, add the type with its full original name
7457 instead of the new . and + encoded name (reflection uses + to
7458 separate type from a nested type). Use LookupTypeReflection
7459 directly which bypasses the type->name hashtable (that we already
7460 know does not contain the type.
7462 * decl.cs (DeclSpace.ResolveTypeExpr): track the
7463 location/container type.
7465 * driver.cs: When passing utf8, use directly the UTF8Encoding.
7467 2003-04-19 Miguel de Icaza <miguel@ximian.com>
7469 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
7471 * delegate.cs (NewDelegate.Resolve): Test whether an instance
7472 method is being referenced in the method group from a static
7473 context, and report error 120 if so.
7475 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
7478 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
7479 is created, we create the A namespace).
7481 * cs-parser.jay: A namespace also introduces a DeclarationFound.
7484 2003-04-18 Miguel de Icaza <miguel@ximian.com>
7486 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
7487 invocation to ModuleBuilder.GetType with the same values will
7488 return a new type instance, so we need to cache its return
7491 * expression.cs (Binary.ResolveOperator): Only allow the compare
7492 operators on enums if they are of the same type.
7494 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
7495 types of ValueType on their own case. Before we were giving them
7496 the same treatment as objects.
7498 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
7499 fullname. Short name is used to compare against container name.
7500 Fullname is used to check against defined namespace names.
7502 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
7503 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
7505 (Method.CheckBase): Call parent.
7506 (MemberBase.CheckBase): Check for protected members on sealed
7508 (PropertyBase.CheckBase): Call parent.
7509 (Field.Define): Call parent.
7511 * report.cs: Negative error codes are now mapped to 8000 - code,
7512 so that the display is render more nicely.
7514 * typemanager.cs: Do not use try/catch, instead report a regular
7517 (GetPointerType, GetReferenceType): These methods provide
7518 mechanisms to obtain the T* and T& from a T. We had the code
7519 previously scattered around the code base, and it also used
7520 TypeManager.LookupType that would go through plenty of caches.
7521 This one goes directly to the type source.
7523 In some places we did the Type.GetType followed by
7524 ModuleBuilder.GetType, but not in others, so this unifies the
7527 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
7528 statements now that we have namespace information.
7530 * typemanager.cs (IsNamespace): New method, returns whether the
7531 string presented is a namespace or not.
7533 (ComputeNamespaces): New public entry point, computes the list of
7534 available namespaces, using the GetNamespaces API call in Mono, or
7535 the slower version in MS.NET.
7537 Now before we start the semantic analysis phase, we have a
7538 complete list of namespaces including everything that the user has
7541 Deleted old code to cache namespaces in .nsc files.
7543 2003-04-17 Miguel de Icaza <miguel@ximian.com>
7545 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
7546 class/struct location definition Location for the implicit
7547 constructor location.
7549 (Operator.Define): Use the location of the operator for the
7550 implicit Method definition.
7552 (Constructor.Emit): use the constructor location for the implicit
7553 base initializer constructor.
7555 * ecore.cs: Remove ITypeExpression. This interface is now gone,
7556 and the Expression class now contains two new methods:
7558 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
7559 isolate type lookup from the rest of the resolution process.
7561 Since we use Expressions to hold type definitions due to the way
7562 we parse the input we have historically overloaded Resolve to
7563 perform the Type lookups if a special flag is passed. Now this is
7564 eliminated and two methods take their place.
7566 The differences in the two methods between xStep and xTerminal is
7567 that xStep is involved in our current lookup system that uses
7568 SimpleNames to compose a name, while xTerminal is used just to
7569 catch the case where the simplename lookup failed.
7571 2003-04-16 Miguel de Icaza <miguel@ximian.com>
7573 * expression.cs (ResolveMemberAccess): Remove redundant code.
7574 TypeExpr expressions are always born fully resolved.
7576 * interface.cs (PopulateMethod): Do not lookup the types twice.
7577 We were doing it once during SemanticAnalysis and once during
7580 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
7581 in local variable type definitions, were being returned as a
7582 SimpleName (we decomposed everything into a string), that is
7583 because primary_expression was being used instead of a type in the
7584 grammar (reduce/reduce conflicts).
7586 The part that was wrong is that we converted the expression into a
7587 string (an oversimplification in one hand, compounded with primary
7588 expressions doing string concatenation).
7594 Would return "A.B.C[]" as a SimpleName. This stopped things like
7595 using clauses from working on this particular context. And a type
7596 was being matched directly against "A.B.C[]".
7598 We now use the correct approach, and allow for ComposedCast to be
7599 part of the unary expression. So the "A.B.C []" become a composed
7600 cast of "A.B.C" (as a nested group of MemberAccess with a
7601 SimpleName at the end) plus the rank composition "[]".
7605 2003-04-10 Miguel de Icaza <miguel@ximian.com>
7607 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
7608 for the access level checking.
7610 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
7611 `TypeContainer container', because I kept getting confused when I
7612 was debugging this code.
7614 * expression.cs (Indexers): Instead of tracking getters/setters,
7615 we now track them in parallel. We create one arraylist less, but
7616 most importantly it is possible now for the LValue code to find a
7617 matching get for a set.
7619 (IndexerAccess.DoResolveLValue): Update the code.
7620 GetIndexersForType has been modified already to extract all the
7621 indexers from a type. The code assumed it did not.
7623 Also make the code set the correct return type for the indexer.
7624 This was fixed a long time ago for properties, but was missing for
7625 indexers. It used to be void_type.
7627 (Binary.Emit): Test first for doubles instead of
7628 floats, as they are more common.
7630 (Binary.EmitBranchable): Use the .un version of the branch opcodes
7631 when dealing with floats and the <=, >= operators. This fixes bug
7634 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
7635 to load the array value by emitting a load on the foreach variable
7636 type. This was incorrect.
7638 We now emit the code to load an element using the the array
7639 variable type, and then we emit the conversion operator.
7643 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
7645 * attribute.cs: Avoid allocation of ArrayLists in the common case.
7647 2003-04-09 Miguel de Icaza <miguel@ximian.com>
7649 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
7650 test for protection before we test for signatures.
7652 (MethodSignature.ToString): implement.
7654 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
7655 to the case where we reduced into a LongConstant.
7657 * decl.cs (CheckAccessLevel): If the type is an array, we can not
7658 depend on whether the information is acurrate, because the
7659 Microsoft runtime will always claim that the array type is public,
7660 regardless of the real state.
7662 If the type is a pointer, another problem happens: the type is
7663 reported as non-public in Microsoft.
7665 In both cases we have to call CheckAccessLevel recursively with
7666 the underlying type as the argument to be tested.
7668 2003-04-08 Miguel de Icaza <miguel@ximian.com>
7670 * assign.cs (Assign.Emit): If we are dealing with a compound
7671 assignment expression, we should use the code path that stores the
7672 intermediate result in a temporary value. This fixes #40903.
7674 *expression.cs (Indirection.ToString): Provide ToString method for
7677 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
7679 * class.cs: Null out fields holding references to Block objects so
7680 they can be garbage collected.
7682 * expression.cs (OverloadResolve): Remove unused local.
7684 2003-04-07 Martin Baulig <martin@ximian.com>
7686 * codegen.cs (EmitContext.CurrentFile): New public field.
7687 (EmitContext.Mark): Use the CurrentFile to check whether the
7688 location is in the correct file.
7689 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
7691 2003-04-07 Martin Baulig <martin@ximian.com>
7693 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
7695 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
7696 location. [FIXME: The location argument which gets passed to this
7697 method is sometimes wrong!]
7699 2003-04-07 Nick Drochak <ndrochak@gol.com>
7701 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
7703 2003-04-07 Miguel de Icaza <miguel@ximian.com>
7705 * expression.cs (Indirection.EmitAssign): We were using the
7706 temporary, but returning immediately instead of continuing the
7709 2003-04-06 Martin Baulig <martin@ximian.com>
7711 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
7712 if it's a nested child, but also deriving from the outer class.
7715 * typemanager.cs (IsNestedChildOf): Make this work if it's a
7716 nested child, but also deriving from the outer class. See
7718 (FilterWithClosure): We may access private members of the outer
7719 class if we're a nested child and deriving from the outer class.
7720 (RealMemberLookup): Only set `closure_private_ok' if the
7721 `original_bf' contained BindingFlags.NonPublic.
7723 2003-04-05 Martin Baulig <martin@ximian.com>
7725 * expression.cs (SizeOf.DoResolve): Use ResolveTypeExpr, so we can
7726 probe if its a type parameter, and if so, flag an error.
7728 * decl.cs: Move here the SetParameterInfo code from class.cs.
7729 Handle IsGeneric here.
7731 Handle a variety of errors in the parameter info definition.
7733 * ecore.cs (SimpleName.DoResolveType): Handle look ups for generic
7734 type parameters here.
7736 * cs-parser.jay (class_declaration): report errors for parameters
7739 2003-01-21 Miguel de Icaza <miguel@ximian.com>
7741 * generic.cs: New file, contains support code for generics.
7743 * cs-parser.jay: Remove OP_SHIFT_LEFT, OP_SHIFT_RIGHT,
7744 OP_SHIFT_LEFT_ASSIGN, OP_SHIFT_RIGHT_ASSIGN.
7746 Update parser for the above removals.
7748 * cs-tokenizer.cs: Do not handle <<= or >>= specially. This is
7749 now taken care of in the parser.
7751 2003-04-02 Miguel de Icaza <miguel@ximian.com>
7753 * class.cs (Event.Define): Do not allow abstract events to have
7756 2003-04-01 Miguel de Icaza <miguel@ximian.com>
7758 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
7759 block in event declarations.
7761 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
7762 value type, get its address.
7764 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
7765 leaving a class on the stack instead of a boolean value (int
7766 0/1). Change the code so we compare against null, and then the
7767 result against zero.
7769 * class.cs (TypeContainer.GetClassBases): We were checking for the
7770 parent class being sealed too late.
7772 * expression.cs (Binary.Emit): For <= and >= when dealing with
7773 floating point values, use cgt.un and clt.un instead of cgt and
7776 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
7778 * statement.cs: Apply the same optimization as MS: skip the
7779 GetEnumerator returning an IEnumerator, and use the one returning a
7780 CharEnumerator instead. This allows us to avoid the try-finally block
7783 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
7785 * cs-parser.jay: Attributes cannot be applied to
7786 namespaces. Fixes #40473
7788 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7791 (Add*): check if the name is valid using the full name for constants,
7792 fields, properties and events.
7794 2003-03-28 Miguel de Icaza <miguel@ximian.com>
7796 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
7797 char constants to be part of the enumeration.
7799 * expression.cs (Conditional.DoResolve): Add support for operator
7800 true. Implements the missing functionality from 14.12
7802 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
7803 operator true/false as required by the spec.
7805 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
7806 implicit conversion to boolean.
7808 * statement.cs (Statement.ResolveBoolean): A boolean expression is
7809 also one where the type implements `operator true'.
7811 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
7812 get an expression that will invoke operator true based on an
7815 (GetConversionOperators): Removed the hack that called op_True
7818 (Expression.ResolveBoolean): Move this from Statement.
7820 2003-03-17 Miguel de Icaza <miguel@ximian.com>
7822 * ecore.cs (FieldExpr): do not allow initialization of initonly
7823 fields on derived classes
7825 2003-03-13 Martin Baulig <martin@ximian.com>
7827 * statement.cs (Block.Emit): Call ig.BeginScope() and
7828 ig.EndScope() when compiling with debugging info; call
7829 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
7831 2003-03-08 Miguel de Icaza <miguel@ximian.com>
7833 * expression.cs (Indexers): Do not construct immediately, allow
7834 for new members to be appended as we go. Fixes 38143
7836 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7838 * expression.cs: save/restore context when resolving an unchecked
7841 2003-03-05 Miguel de Icaza <miguel@ximian.com>
7843 * cfold.cs: Catch division by zero in modulus operator during
7846 2003-03-03 Miguel de Icaza <miguel@ximian.com>
7848 * interface.cs (Interface.DefineMembers): Avoid defining members
7851 2003-02-27 Miguel de Icaza <miguel@ximian.com>
7853 * driver.cs: handle the +/- options for -noconfig
7855 * statement.cs (Unckeched.Resolve): Also track the state of
7856 unchecked in the Resolve phase.
7858 2003-02-27 Martin Baulig <martin@ximian.com>
7860 * ecore.cs (Expression.MemberLookup): Don't create a
7861 MethodGroupExpr for something which is not a method. Fixes #38291.
7863 2003-02-25 Miguel de Icaza <miguel@ximian.com>
7865 * class.cs (MemberBase.CheckParameters): Also check that the type
7866 is unmanaged if it is a pointer.
7868 * expression.cs (SizeOf.Resolve): Add location information.
7870 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
7871 a managed type is declared.
7873 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
7874 parameter modifiers as well. Fixes bug 38606
7876 * class.cs: Very sad. Am backing out the speed up changes
7877 introduced by the ArrayList -> Array in the TypeContainer, as they
7878 were not actually that much faster, and introduced a bug (no error
7879 reports on duplicated methods).
7881 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
7882 source first, this will guarantee that we have a valid expression
7883 before calling in lower levels functions that will require a
7884 resolved object. Then use this original_source in the
7885 target.ResolveLValue instead of the original source that was
7888 Another change. Use target.Resolve instead of LValueResolve.
7889 Although we are resolving for LValues, we will let the Assign code
7890 take care of that (it will be called again from Resolve). This
7891 basically allows code like this:
7893 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
7894 class Y { void A (X x) { x [0] += o; }
7896 The problem was that the indexer was trying to resolve for
7897 set_Item (idx, object o) and never finding one. The real set_Item
7898 was set_Item (idx, X). By delaying the process we get the right
7903 2003-02-23 Martin Baulig <martin@ximian.com>
7905 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
7906 while calling DoEmit ().
7908 * codegen.cs (EmitContext.Mark): Don't mark locations in other
7909 source files; if you use the #line directive inside a method, the
7910 compiler stops emitting line numbers for the debugger until it
7911 reaches the end of the method or another #line directive which
7912 restores the original file.
7914 2003-02-23 Martin Baulig <martin@ximian.com>
7916 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
7918 2003-02-23 Martin Baulig <martin@ximian.com>
7920 * statement.cs (Block.AddChildVariableNames): We need to call this
7921 recursively, not just for our immediate children.
7923 2003-02-23 Martin Baulig <martin@ximian.com>
7925 * class.cs (Event.Define): Always make the field private, like csc does.
7927 * typemanager.cs (TypeManager.RealMemberLookup): Make events
7928 actually work, fixes bug #37521.
7930 2003-02-23 Miguel de Icaza <miguel@ximian.com>
7932 * delegate.cs: When creating the various temporary "Parameters"
7933 classes, make sure that we call the ComputeAndDefineParameterTypes
7934 on those new parameters (just like we do with the formal ones), to
7935 allow them to be resolved in the context of the DeclSpace.
7937 This fixes the bug that Dick observed in Bugzilla #38530.
7939 2003-02-22 Miguel de Icaza <miguel@ximian.com>
7941 * expression.cs (ResolveMemberAccess): When resolving a constant,
7942 do not attempt to pull a constant if the value was not able to
7943 generate a valid constant.
7945 * const.cs (LookupConstantValue): Do not report more errors than required.
7947 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7949 * expression.cs: fixes bug #38328.
7951 2003-02-18 Miguel de Icaza <miguel@ximian.com>
7953 * class.cs: Changed all the various members that can be part of a
7954 class from being an ArrayList to be an Array of the right type.
7955 During the DefineType type_list, interface_list, delegate_list and
7956 enum_list are turned into types, interfaces, delegates and enums
7959 And during the member population, indexer_list, event_list,
7960 constant_list, field_list, instance_constructor_list, method_list,
7961 operator_list and property_list are turned into their real arrays.
7963 Although we could probably perform this operation earlier, for
7964 good error reporting we need to keep the lists and remove the
7965 lists for longer than required.
7967 This optimization was triggered by Paolo profiling the compiler
7968 speed on the output of `gen-sample-program.pl' perl script.
7970 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
7971 not crash in methods like MemberLookupFailed that use this field.
7973 This problem arises when the compiler fails to resolve a type
7974 during interface type definition for example.
7976 2003-02-18 Miguel de Icaza <miguel@ximian.com>
7978 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
7979 inherit from System.Object, so we have to stop at null, not only
7980 when reaching System.Object.
7982 2003-02-17 Miguel de Icaza <miguel@ximian.com>
7984 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
7985 DeclaredOnly because the parent indexer might have had a different
7986 name, but did not loop until the top of the hierarchy was reached.
7988 The problem this one fixes is 35492: when a class implemented an
7989 indexer from an interface, we were getting the interface method
7990 (which was abstract) and we were flagging an error (can not invoke
7993 This also keeps bug 33089 functioning, and test-148 functioning.
7995 * typemanager.cs (IsSpecialMethod): The correct way of figuring
7996 out if a method is special is to see if it is declared in a
7997 property or event, or whether it is one of the predefined operator
7998 names. This should fix correctly #36804.
8000 2003-02-15 Miguel de Icaza <miguel@ximian.com>
8002 The goal here is to remove the dependency on EmptyCast.Peel ().
8003 Killing it completely.
8005 The problem is that currently in a number of places where
8006 constants are expected, we have to "probe" for an EmptyCast, and
8007 Peel, which is not the correct thing to do, as this will be
8008 repetitive and will likely lead to errors.
8010 The idea is to remove any EmptyCasts that are used in casts that
8011 can be reduced to constants, so we only have to cope with
8014 This bug hunt was triggered by Bug 37363 and the desire to remove
8015 the duplicate pattern where we were "peeling" emptycasts to check
8016 whether they were constants. Now constants will always be
8019 * ecore.cs: Use an enumconstant here instead of wrapping with
8022 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
8023 throwing me off. By handling this we can get rid of a few hacks.
8025 * statement.cs (Switch): Removed Peel() code.
8027 2003-02-14 Miguel de Icaza <miguel@ximian.com>
8029 * class.cs: Location information for error 508
8031 * expression.cs (New.DoResolve): Add a guard against double
8032 resolution of an expression.
8034 The New DoResolve might be called twice when initializing field
8035 expressions (see EmitFieldInitializers, the call to
8036 GetInitializerExpression will perform a resolve on the expression,
8037 and later the assign will trigger another resolution
8039 This leads to bugs (#37014)
8041 * delegate.cs: The signature for EndInvoke should contain any ref
8042 or out parameters as well. We were not doing this in the past.
8044 * class.cs (Field.Define): Do not overwrite the type definition
8045 inside the `volatile' group. Turns out that volatile enumerations
8046 were changing the type here to perform a validity test, which
8049 2003-02-12 Miguel de Icaza <miguel@ximian.com>
8051 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
8052 and structs, we do not want to load the instance variable
8054 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
8055 enum_type has to be handled like an object reference (implicit
8056 conversions exists from this to object), but the regular IsClass
8057 and IsValueType tests will never return true for this one.
8059 Also we use TypeManager.IsValueType instead of type.IsValueType,
8060 just for consistency with the rest of the code (this is only
8061 needed if we ever use the construct exposed by test-180.cs inside
8062 corlib, which we dont today).
8064 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
8066 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
8069 2003-02-09 Martin Baulig <martin@ximian.com>
8071 * namespace.cs (Namespace..ctor): Added SourceFile argument.
8072 (Namespace.DefineNamespaces): New static public method; this is
8073 called when we're compiling with debugging to add all namespaces
8076 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
8077 pass it to the Namespace's .ctor.
8079 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
8080 and MethodBase arguments; pass the namespace ID to the symwriter;
8081 pass the MethodBase instead of the token to the symwriter.
8082 (SymbolWriter.DefineNamespace): New method to add a namespace to
8085 2003-02-09 Martin Baulig <martin@ximian.com>
8087 * symbolwriter.cs: New file. This is a wrapper around
8088 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
8089 methods here in near future.
8091 2003-02-09 Martin Baulig <martin@ximian.com>
8093 * codegen.cs (EmitContext.Mark): Just pass the arguments to
8094 ILGenerator.MarkSequencePoint() which are actually used by the
8097 2003-02-09 Martin Baulig <martin@ximian.com>
8099 * location.cs (SourceFile): New public sealed class. This
8100 contains the name and an index which is used in the location's token.
8101 (Location): Reserve an appropriate number of bits in the token for
8102 the source file instead of walking over that list, this gives us a
8103 really huge performance improvement when compiling with debugging.
8105 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
8106 `SourceFile' argument instead of a string.
8107 (Driver.ProcessFile): Add all the files via Location.AddFile(),
8108 but don't parse/tokenize here, we need to generate the list of all
8109 source files before we do that.
8110 (Driver.ProcessFiles): New static function. Parses/tokenizes all
8113 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
8114 instead of a string.
8116 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
8119 2003-02-09 Martin Baulig <martin@ximian.com>
8121 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
8122 filename on `#line default'.
8124 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
8126 * statement.cs: don't clear the pinned var when the fixed statement
8127 returns from the method (fixes bug#37752).
8129 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
8131 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
8134 2003-02-07 Martin Baulig <martin@ximian.com>
8136 * driver.cs: Removed the `--debug-args' command line argument.
8138 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
8139 automatically by the AsssemblyBuilder.
8140 (CodeGen.InitializeSymbolWriter): We don't need to call any
8141 initialization function on the symbol writer anymore. This method
8142 doesn't take any arguments.
8144 2003-02-03 Miguel de Icaza <miguel@ximian.com>
8146 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
8147 from referenced assemblies as well.
8149 2003-02-02 Martin Baulig <martin@ximian.com>
8151 * class.cs (MethodData.Emit): Generate debugging info for external methods.
8153 2003-02-02 Martin Baulig <martin@ximian.com>
8155 * class.cs (Constructor.Emit): Open the symbol writer before
8156 emitting the constructor initializer.
8157 (ConstructorInitializer.Emit): Call ec.Mark() to allow
8158 single-stepping through constructor initializers.
8160 2003-01-30 Miguel de Icaza <miguel@ximian.com>
8162 * class.cs: Handle error 549: do not allow virtual methods in
8165 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
8167 * decl.cs: Check access levels when resolving types
8169 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
8171 * statement.cs: Add parameters and locals set in catch blocks that might
8172 return to set vector
8174 2003-01-29 Miguel de Icaza <miguel@ximian.com>
8176 * class.cs (Operator): Set the SpecialName flags for operators.
8178 * expression.cs (Invocation.DoResolve): Only block calls to
8179 accessors and operators on SpecialName methods.
8181 (Cast.TryReduce): Handle conversions from char constants.
8184 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
8186 * statement.cs: small memory and time optimization in FlowBranching.
8188 2003-01-28 Pedro Mart <yoros@wanadoo.es>
8190 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
8191 problem that the last fix but in the other sid (Set).
8193 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
8194 access when there is no indexer in the hierarchy.
8196 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
8198 * class.cs: Combine some if statements.
8200 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8202 * driver.cs: fixed bug #37187.
8204 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
8206 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
8207 any indexer, it's needed to build a list with all the indexers in the
8208 hierarchy (AllGetters), else we have problems. Fixes #35653.
8210 2003-01-23 Miguel de Icaza <miguel@ximian.com>
8212 * class.cs (MethodData.Define): It is wrong for an interface
8213 implementation to be static in both cases: explicit and implicit.
8214 We were only handling this in one case.
8216 Improve the if situation there to not have negations.
8218 * class.cs (Field.Define): Turns out that we do not need to check
8219 the unsafe bit on field definition, only on usage. Remove the test.
8221 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8223 * driver.cs: use assembly.Location instead of Codebase (the latest
8224 patch made mcs fail when using MS assemblies).
8226 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
8228 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
8229 get the path to *corlib.dll.
8231 2003-01-21 Nick Drochak <ndrochak@gol.com>
8235 * typemanager.cs: Remove compiler warnings
8237 2003-01-20 Duncan Mak <duncan@ximian.com>
8239 * AssemblyInfo.cs: Bump the version number to 0.19.
8241 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8243 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
8245 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
8247 * class.cs (Constructor::Emit): Emit debugging info for constructors.
8249 2003-01-17 Miguel de Icaza <miguel@ximian.com>
8251 * cs-parser.jay: Small fix: we were not comparing the constructor
8252 name correctly. Thanks to Zoltan for the initial pointer.
8254 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
8256 * cs-tokenizer.cs: Set file name when specified with #line
8258 2003-01-15 Miguel de Icaza <miguel@ximian.com>
8260 * cs-parser.jay: Only perform the constructor checks here if we
8261 are named like the class; This will help provider a better
8262 error. The constructor path is taken when a type definition is
8263 not found, but most likely the user forgot to add the type, so
8264 report that rather than the constructor error.
8266 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
8268 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
8271 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
8273 * cs-parser.jay: Add cleanup call.
8275 2003-01-13 Duncan Mak <duncan@ximian.com>
8277 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
8278 consistent with other methods.
8280 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
8282 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
8284 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
8286 * attribute.cs: only set GuidAttr to true when we have a
8289 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8293 * typemanager.cs: fixes to allow mcs compile corlib with the new
8294 Type.IsSubclassOf fix.
8296 2003-01-08 Miguel de Icaza <miguel@ximian.com>
8298 * expression.cs (LocalVariableReference.DoResolve): Classify a
8299 constant as a value, not as a variable. Also, set the type for
8302 * cs-parser.jay (fixed_statement): take a type instead of a
8303 pointer_type, so we can produce a better error message later.
8305 * statement.cs (Fixed.Resolve): Flag types that are not pointers
8308 (For.DoEmit): Make inifinite loops have a
8309 non-conditional branch back.
8311 (Fixed.DoEmit): First populate the pinned variables, then emit the
8312 statement, then clear the variables. Before I was emitting the
8313 code once for each fixed piece.
8316 2003-01-08 Martin Baulig <martin@ximian.com>
8318 * statement.cs (FlowBranching.MergeChild): A break in a
8319 SWITCH_SECTION does not leave a loop. Fixes #36155.
8321 2003-01-08 Martin Baulig <martin@ximian.com>
8323 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
8324 lives in the same number space than `param_map'. Fixes #36154.
8326 2003-01-07 Miguel de Icaza <miguel@ximian.com>
8328 * cs-parser.jay (constructor_declaration): Set the
8329 Constructor.ModFlags before probing for it. This makes the
8330 compiler report 514, 515 and 132 (the code was there, but got
8333 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
8334 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
8335 (GotoCase.Resolve): Set `Returns' to ALWAYS.
8337 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
8339 * enum.cs: create the enum static fields using the enum type.
8341 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
8343 * class.cs: don't try to create the ParamBuilder for the return
8344 type if it's not needed (and handle it breaking for the ms runtime
8347 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
8349 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
8351 2002-12-29 Miguel de Icaza <miguel@ximian.com>
8353 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
8354 the command. This showed up while compiling the JANET source
8355 code, which used \r as its only newline separator.
8357 2002-12-28 Miguel de Icaza <miguel@ximian.com>
8359 * class.cs (Method.Define): If we are an operator (because it
8360 reuses our code), then set the SpecialName and HideBySig. #36128
8362 2002-12-22 Miguel de Icaza <miguel@ximian.com>
8364 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
8365 exception, report error 120 `object reference required'.
8367 * driver.cs: Add --pause option, used during to measure the size
8368 of the process as it goes with --timestamp.
8370 * expression.cs (Invocation.DoResolve): Do not allow methods with
8371 SpecialName to be invoked.
8373 2002-12-21 Miguel de Icaza <miguel@ximian.com>
8375 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
8376 number before adding it.
8378 2002-12-21 Ravi Pratap <ravi@ximian.com>
8380 * ecore.cs (StandardImplicitConversion): When in an unsafe
8381 context, we allow conversion between void * to any other pointer
8382 type. This fixes bug #35973.
8384 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
8386 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
8387 is not thrown when extensionless outputs are used
8389 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8391 * rootcontext.cs: fixed compilation of corlib.
8393 2002-12-19 Miguel de Icaza <miguel@ximian.com>
8395 * attribute.cs (Attributes.Contains): Add new method.
8397 * class.cs (MethodCore.LabelParameters): if the parameter is an
8398 `out' parameter, check that no attribute `[In]' has been passed.
8400 * enum.cs: Handle the `value__' name in an enumeration.
8402 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
8404 * decl.cs: Added special case to allow overrides on "protected
8407 2002-12-18 Ravi Pratap <ravi@ximian.com>
8409 * attribute.cs (Attributes.AddAttributeSection): Rename to this
8410 since it makes much more sense.
8412 (Attributes.ctor): Don't require a Location parameter.
8414 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
8416 * attribute.cs (ApplyAttributes): Remove extra Location parameters
8417 since we already have that information per attribute.
8419 * everywhere : make appropriate changes.
8421 * class.cs (LabelParameters): Write the code which actually
8422 applies attributes to the return type. We can't do this on the MS
8423 .NET runtime so we flag a warning in the case an exception is
8426 2002-12-18 Miguel de Icaza <miguel@ximian.com>
8428 * const.cs: Handle implicit null conversions here too.
8430 2002-12-17 Ravi Pratap <ravi@ximian.com>
8432 * class.cs (MethodCore.LabelParameters): Remove the extra
8433 Type [] parameter since it is completely unnecessary. Instead
8434 pass in the method's attributes so that we can extract
8435 the "return" attribute.
8437 2002-12-17 Miguel de Icaza <miguel@ximian.com>
8439 * cs-parser.jay (parse): Use Report.Error to flag errors instead
8440 of ignoring it and letting the compile continue.
8442 * typemanager.cs (ChangeType): use an extra argument to return an
8443 error condition instead of throwing an exception.
8445 2002-12-15 Miguel de Icaza <miguel@ximian.com>
8447 * expression.cs (Unary.TryReduce): mimic the code for the regular
8448 code path. Perform an implicit cast in the cases where we can
8449 implicitly convert to one of the integral types, and then reduce
8450 based on that constant. This fixes bug #35483.
8452 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8454 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
8456 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8458 * namespace.cs: fixed bug #35489.
8460 2002-12-12 Miguel de Icaza <miguel@ximian.com>
8462 * class.cs: Remove some dead code.
8464 * cs-parser.jay: Estimate the number of methods needed
8465 (RootContext.MethodCount);
8467 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
8468 numbers instead of StringBuilders.
8470 * support.cs (PtrHashtable): Add constructor with initial size;
8471 We can now reduce reallocations of the method table.
8473 2002-12-10 Ravi Pratap <ravi@ximian.com>
8475 * attribute.cs (ApplyAttributes): Keep track of the emitted
8476 attributes on a per-target basis. This fixes bug #35413.
8478 2002-12-10 Miguel de Icaza <miguel@ximian.com>
8480 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
8481 default to the Windows 1252 encoding.
8483 (UnixParseOption): Support version, thanks to Alp for the missing
8486 * AssemblyInfo.cs: Add nice assembly information.
8488 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
8491 * cs-parser.jay: Allow a trailing comma before the close bracked
8492 in the attribute_section production.
8494 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
8495 address of the instance was being taken, I will take this out,
8496 because we take the address of the object immediately here.
8498 2002-12-09 Ravi Pratap <ravi@ximian.com>
8500 * typemanager.cs (AreMultipleAllowed): Take care of the most
8501 obvious case where attribute type is not in the current assembly -
8504 2002-12-08 Miguel de Icaza <miguel@ximian.com>
8506 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
8507 definitions, instead of doing that afterwards.
8509 Also we use a nice little hack, depending on the constructor, we
8510 know if we are a "composed" name or a simple name. Hence, we
8511 avoid the IndexOf test, and we avoid
8513 * codegen.cs: Add code to assist in a bug reporter to track down
8514 the source of a compiler crash.
8516 2002-12-07 Ravi Pratap <ravi@ximian.com>
8518 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
8519 types have been emitted for a given element and flag an error
8520 if something which does not have AllowMultiple set is used more
8523 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
8524 attribute types and their corresponding AllowMultiple properties
8526 (AreMultipleAllowed): Check the property for a given type.
8528 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
8529 property in the case we have a TypeContainer.
8531 (Attributes.AddAttribute): Detect duplicates and just skip on
8532 adding them. This trivial fix catches a pretty gross error in our
8533 attribute emission - global attributes were being emitted twice!
8535 Bugzilla bug #33187 is now fixed.
8537 2002-12-06 Miguel de Icaza <miguel@ximian.com>
8539 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
8542 * expression.cs (Binary.ResolveOperator): I can only use the
8543 Concat (string, string, string) and Concat (string, string,
8544 string, string) if the child is actually a concatenation of
8547 2002-12-04 Miguel de Icaza <miguel@ximian.com>
8549 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
8550 context where we need a 2-character lookahead.
8552 * pending.cs (PendingImplementation): Rework so we can keep track
8553 of interface types all the time, and flag those which were
8554 implemented by parents as optional.
8556 2002-12-03 Miguel de Icaza <miguel@ximian.com>
8558 * expression.cs (Binary.ResolveOperator): Use
8559 String.Concat(string,string,string) or
8560 String.Concat(string,string,string,string) when possible.
8562 * typemanager: More helper methods.
8565 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
8567 * pending.cs: remove the bogus return from GetMissingInterfaces()
8568 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
8570 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8572 * namespace.cs: avoid duplicated 'using xxx' being added to
8573 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
8574 when we get more than one 'using' statement for the same namespace.
8575 Report a CS0105 warning for it.
8577 2002-11-30 Miguel de Icaza <miguel@ximian.com>
8579 * cs-tokenizer.cs (consume_identifier): use read directly, instead
8580 of calling getChar/putback, uses internal knowledge of it.
8582 (xtoken): Reorder tokenizer so most common patterns are checked
8583 first. This reduces the compilation time in another 5% (from 8.11s
8584 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
8586 The parsing time is 22% of the compilation in mcs, and from that
8587 64% is spent on the tokenization process.
8589 I tried using a binary search for keywords, but this is slower
8590 than the hashtable. Another option would be to do a couple of
8593 * Not use a StringBuilder, instead use an array of chars,
8594 with a set value. Notice that this way we could catch
8595 the 645 error without having to do it *afterwards*.
8597 * We could write a hand-parser to avoid the hashtable
8598 compares altogether.
8600 The identifier consumption process takes 37% of the tokenization
8601 time. Another 15% is spent on is_number. 56% of the time spent
8602 on is_number is spent on Int64.Parse:
8604 * We could probably choose based on the string length to
8605 use Int32.Parse or Int64.Parse and avoid all the 64-bit
8608 Another 3% is spend on wrapping `xtoken' in the `token' function.
8610 Handle 0xa0 as whitespace (#34752)
8612 2002-11-26 Miguel de Icaza <miguel@ximian.com>
8614 * typemanager.cs (IsCLRType): New routine to tell whether a type
8615 is one of the builtin types.
8617 Maybe it needs to use TypeCodes to be faster. Maybe we could use
8618 typecode in more places instead of doing pointer comparissions.
8619 We could leverage some knowledge about the way the typecodes are
8622 New code to cache namespaces in assemblies, it is currently not
8623 invoked, to be used soon.
8625 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
8627 * expression.cs (Binary.ResolveOperator): specially handle
8628 strings, and do not perform user-defined operator overloading for
8631 2002-11-24 Miguel de Icaza <miguel@ximian.com>
8633 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
8634 internalcall as it is a pretty simple operation; Avoid whenever
8635 possible to call Char.IsLetter.
8637 (consume_identifier): Cut by half the number of
8638 hashtable calls by merging the is_keyword and GetKeyword behavior.
8640 Do not short-circuit, because if we do, we
8641 report errors (ie, #if false && true would produce an invalid
8645 2002-11-24 Martin Baulig <martin@ximian.com>
8647 * expression.cs (Cast.TryReduce): If we're in checked syntax,
8648 check constant ranges and report a CS0221. Fixes #33186.
8650 2002-11-24 Martin Baulig <martin@ximian.com>
8652 * cs-parser.jay: Make this work for uninitialized variable
8653 declarations in the `for' initializer. Fixes #32416.
8655 2002-11-24 Martin Baulig <martin@ximian.com>
8657 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
8658 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
8660 2002-11-24 Martin Baulig <martin@ximian.com>
8662 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
8663 argument; if true, we also check for user-defined conversions.
8664 This is only needed if both arguments are of a user-defined type.
8665 Fixes #30443, added test-175.cs.
8666 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
8668 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
8670 2002-11-24 Martin Baulig <martin@ximian.com>
8672 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
8673 function to get the store opcode.
8674 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
8675 only emit the Ldelema if the store opcode is Stobj. You must run
8676 both test-34 and test-167 to test this. Fixes #34529.
8678 2002-11-23 Martin Baulig <martin@ximian.com>
8680 * ecore.cs (Expression.MemberLookup): Added additional
8681 `qualifier_type' argument which is used when we're being called
8682 from MemberAccess.DoResolve() and null if we're called from a
8684 (Expression.MemberLookupFailed): New method to report errors; this
8685 does the CS1540 check and reports the correct error message.
8687 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
8688 argument for the CS1540 check and redone the way how we're dealing
8689 with private members. See the comment in the source code for details.
8690 (FilterWithClosure): Reverted this back to revision 1.197; renamed
8691 `closure_start_type' to `closure_qualifier_type' and check whether
8692 it's not null. It was not this filter being broken, it was just
8693 being called with the wrong arguments.
8695 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
8696 and pass it the correct `qualifier_type'; this also does the error
8699 2002-11-22 Miguel de Icaza <miguel@ximian.com>
8701 * expression.cs (Invocation.EmitParams): If the we are dealing
8702 with a non-built-in value type, load its address as well.
8704 (ArrayCreation): Use a a pretty constant instead
8705 of the hardcoded value 2. Use 6 instead of 2 for the number of
8706 static initializers.
8708 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
8709 because they are not really value types, just glorified integers.
8711 * driver.cs: Do not append .exe, the CSC compiler does not do it.
8713 * ecore.cs: Remove redundant code for enumerations, make them use
8714 the same code path as everything else, fixes the casting issue
8715 with enumerations in Windows.Forms.
8717 * attribute.cs: Do only cast to string if it is a string, the
8718 validation happens later.
8720 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
8721 people upgrade their corlibs.
8723 * ecore.cs: Oops, enumerations were not following the entire code path
8725 2002-11-21 Miguel de Icaza <miguel@ximian.com>
8727 * typemanager.cs (FilterWithClosure): Commented out the test for
8728 1540 in typemanager.cs, as it has problems when accessing
8729 protected methods from a parent class (see test-174.cs).
8731 * attribute.cs (Attribute.ValidateGuid): new method.
8732 (Attribute.Resolve): Use above.
8734 2002-11-19 Miguel de Icaza <miguel@ximian.com>
8736 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
8738 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
8739 handling for enumerations, as we only needed the TypeContainer
8740 functionality to begin with (this is required for the fix below to
8741 work for enums that reference constants in a container class for
8744 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
8746 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
8747 a valid TypeBuilder to perform lookups on.o
8749 * class.cs (InheritableMemberSignatureCompare): Use true in the
8750 call to GetGetMethod and GetSetMethod, because we are comparing
8751 the signature, and we need to get the methods *even* if they are
8754 (PropertyBase.CheckBase): ditto.
8756 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
8757 GotoCase.Resolve): Use Peel on EmpytCasts.
8759 * ecore.cs (EmptyCast): drop child, add Peel method.
8761 2002-11-17 Martin Baulig <martin@ximian.com>
8763 * ecore.cs (EmptyCast.Child): New public property.
8765 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
8766 label resolved to an EmptyCast. Fixes #34162.
8767 (GotoCase.Resolve): Likewise.
8768 (Block.EmitMeta): Likewise.
8770 2002-11-17 Martin Baulig <martin@ximian.com>
8772 * expression.cs (Invocation.BetterConversion): Prefer int over
8773 uint; short over ushort; long over ulong for integer literals.
8774 Use ImplicitConversionExists instead of StandardConversionExists
8775 since we also need to check for user-defined implicit conversions.
8776 Fixes #34165. Added test-173.cs.
8778 2002-11-16 Martin Baulig <martin@ximian.com>
8780 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
8781 with the `true' and `false' literals. Fixes #33151.
8783 2002-11-16 Martin Baulig <martin@ximian.com>
8785 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
8786 October 22nd; don't do the cs1540 check for static members.
8788 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
8789 now using our own filter here and doing the cs1540 check again.
8791 2002-11-16 Martin Baulig <martin@ximian.com>
8793 * support.cs (InternalParameters): Don't crash if we don't have
8794 any fixed parameters. Fixes #33532.
8796 2002-11-16 Martin Baulig <martin@ximian.com>
8798 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
8799 when looking up static methods to make this work on Windows.
8802 2002-11-16 Martin Baulig <martin@ximian.com>
8804 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
8805 a setter rather than using PropertyInfo.CanWrite.
8807 2002-11-15 Nick Drochak <ndrochak@gol.com>
8809 * class.cs: Allow acces to block member by subclasses. Fixes build
8812 2002-11-14 Martin Baulig <martin@ximian.com>
8814 * class.cs (Constructor.Emit): Added the extern/block check.
8817 2002-11-14 Martin Baulig <martin@ximian.com>
8819 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
8820 iteration while looking for indexers, this is needed because the
8821 indexer may have a different name in our base classes. Fixed the
8822 error reporting (no indexers at all, not get accessor, no
8823 overloaded match). Fixes bug #33089.
8824 (IndexerAccess.DoResolveLValue): Likewise.
8826 2002-11-14 Martin Baulig <martin@ximian.com>
8828 * class.cs (PropertyBase.CheckBase): Make this work for multiple
8829 indexers. Fixes the first part of bug #33089.
8830 (MethodSignature.InheritableMemberSignatureCompare): Added support
8833 2002-11-13 Ravi Pratap <ravi@ximian.com>
8835 * attribute.cs (Attribute.Resolve): Catch the
8836 NullReferenceException and report it since it isn't supposed to
8839 2002-11-12 Miguel de Icaza <miguel@ximian.com>
8841 * expression.cs (Binary.EmitBranchable): Also handle the cases for
8842 LogicalOr and LogicalAnd that can benefit from recursively
8843 handling EmitBranchable. The code now should be nice for Paolo.
8845 2002-11-08 Miguel de Icaza <miguel@ximian.com>
8847 * typemanager.cs (LookupType): Added a negative-hit hashtable for
8848 the Type lookups, as we perform quite a number of lookups on
8849 non-Types. This can be removed once we can deterministically tell
8850 whether we have a type or a namespace in advance.
8852 But this might require special hacks from our corlib.
8856 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
8857 and double which avoids a conversion from an integer to a double.
8859 * expression.cs: tiny optimization, avoid calling IsConstant,
8860 because it effectively performs the lookup twice.
8862 2002-11-06 Miguel de Icaza <miguel@ximian.com>
8864 But a bogus return here to keep the semantics of the old code
8865 until the Mono runtime is fixed.
8867 * pending.cs (GetMissingInterfaces): New method used to remove all
8868 the interfaces that are already implemented by our parent
8869 classes from the list of pending methods.
8871 * interface.cs: Add checks for calls after ResolveTypeExpr.
8873 2002-11-05 Miguel de Icaza <miguel@ximian.com>
8875 * class.cs (Class.Emit): Report warning 67: event not used if the
8876 warning level is beyond 3.
8878 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
8879 being a NullLiteral.
8881 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
8884 * class.cs (TypeContainer.GetClassBases): Cover a missing code
8885 path that might fail if a type can not be resolved.
8887 * expression.cs (Binary.Emit): Emit unsigned versions of the
8890 * driver.cs: use error 5.
8892 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
8894 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
8896 2002-11-01 Miguel de Icaza <miguel@ximian.com>
8898 * cs-parser.jay (switch_section): A beautiful patch from Martin
8899 Baulig that fixed 33094.
8901 2002-10-31 Miguel de Icaza <miguel@ximian.com>
8903 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
8904 Check whether the base is abstract and report an error if so.
8906 * expression.cs (IndexerAccess.DoResolveLValue,
8907 IndexerAccess.DoResolve): ditto.
8909 (Invocation.DoResolve): ditto.
8911 (Invocation.FullMethodDesc): Improve the report string.
8913 * statement.cs (Block): Eliminate IsVariableDefined as it is
8914 basically just a wrapper for GetVariableInfo.
8916 * ecore.cs (SimpleName): Use new
8918 * support.cs (ReflectionParamter.ParameterType): We unwrap the
8919 type, as we return the actual parameter ref/unref state on a
8922 2002-10-30 Miguel de Icaza <miguel@ximian.com>
8924 * support.cs: Return proper flags REF/OUT fixing the previous
8927 * expression.cs: Reverted last patch, that was wrong. Is_ref is
8928 not used to mean `ref' but `ref or out' in ParameterReference
8930 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
8931 full type signature instead of calling TypeManger.CSharpName
8934 * support.cs (InternalParameters.ParameterDesc): Do not compare
8935 directly to the modflags, because REF/OUT will actually be bitsets
8938 * delegate.cs (VerifyMethod): Check also the modifiers.
8940 * cs-tokenizer.cs: Fix bug where floating point values with an
8941 exponent where a sign was missing was ignored.
8943 * driver.cs: Allow multiple assemblies to be specified in a single
8946 2002-10-28 Miguel de Icaza <miguel@ximian.com>
8948 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
8949 because identifiers after a parenthesis would end up in this kind
8950 of production, and we needed to desamiguate it for having casts
8953 (UserDefinedType *) xxx
8955 2002-10-24 Miguel de Icaza <miguel@ximian.com>
8957 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
8958 we should set on the Bindingflags.NonPublic, but not turn on
8959 private_ok. private_ok controls whether a Private member is
8960 returned (this is chekced on the filter routine), while the
8961 BindingFlags.NonPublic just controls whether private/protected
8962 will be allowed. This fixes the problem part of the problem of
8963 private properties being allowed to be used in derived classes.
8965 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
8966 so we can call the children DoResolveLValue method (this will
8967 properly signal errors on lvalue assignments to base properties)
8969 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
8970 getter are null, and we have a property info, we know that this
8971 happened because the lookup failed, so we report an error 122 for
8972 protection level violation.
8974 We also silently return if setter and getter are null in the
8975 resolve functions, this condition only happens if we have flagged
8976 the error before. This is the other half of the problem.
8978 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
8979 not have accessibility information, that is why we were returning
8980 true in the filter function in typemanager.cs.
8982 To properly report 122 (property is inaccessible because of its
8983 protection level) correctly, we report this error in ResolveAccess
8984 by failing if both the setter and the getter are lacking (ie, the
8987 DoResolve and DoLResolve have been modified to check for both
8988 setter/getter being null and returning silently, the reason being
8989 that I did not want to put the knowledge about this error in upper
8992 int old = Report.Errors;
8993 x = new PropertyExpr (...);
8994 if (old != Report.Errors)
8999 So the property expr is returned, but it is invalid, so the error
9000 will be flagged during the resolve process.
9002 * class.cs: Remove InheritablePropertySignatureCompare from the
9003 class, as we no longer depend on the property signature to compute
9004 whether it is possible to implement a method or not.
9006 The reason is that calling PropertyInfo.GetGetMethod will return
9007 null (in .NET, in Mono it works, and we should change this), in
9008 cases where the Get Method does not exist in that particular
9013 class X { public virtual int A { get { return 1; } } }
9015 class Z : Y { public override int A { get { return 2; } } }
9017 Would fail in Z because the parent (Y) would not have the property
9018 defined. So we avoid this completely now (because the alternative
9019 fix was ugly and slow), and we now depend exclusively on the
9022 (PropertyBase.CheckBase): Use a method-base mechanism to find our
9023 reference method, instead of using the property.
9025 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
9026 routines are gone now.
9028 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
9029 names, they were incorrectly named.
9031 * cs-tokenizer.cs: Return are more gentle token on failure.
9033 * pending.cs (PendingImplementation.InterfaceMethod): This routine
9034 had an out-of-sync index variable, which caused it to remove from
9035 the list of pending methods the wrong method sometimes.
9037 2002-10-22 Miguel de Icaza <miguel@ximian.com>
9039 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
9040 CanWrite, because those refer to this particular instance of the
9041 property, and do not take into account the fact that we can
9042 override single members of a property.
9044 Constructor requires an EmitContext. The resolution process does
9045 not happen here, but we need to compute the accessors before,
9046 because the resolution does not always happen for properties.
9048 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
9049 subclass, before we did not update this flag, but we did update
9052 (GetAccessors): Drop this routine, as it did not work in the
9053 presence of partially overwritten set/get methods.
9055 Notice that this broke the cs1540 detection, but that will require
9058 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9062 * driver.cs: issue a warning instead of an error if we don't support
9063 debugging for the platform. Also ignore a couple of errors that may
9064 arise when trying to write the symbols. Undo my previous patch.
9066 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9068 * driver.cs: ignore /debug switch except for Unix platforms.
9070 2002-10-23 Nick Drochak <ndrochak@gol.com>
9072 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
9074 2002-10-21 Miguel de Icaza <miguel@ximian.com>
9076 * driver.cs: Do not make mcs-debug conditional, so we do not break
9079 * statement.cs (UsageVector.MergeChildren): I would like Martin to
9080 review this patch. But basically after all the children variables
9081 have been merged, the value of "Breaks" was not being set to
9082 new_breaks for Switch blocks. I think that it should be set after
9083 it has executed. Currently I set this to the value of new_breaks,
9084 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
9085 conservative, but I do not understand this code very well.
9087 I did not break anything in the build, so that is good ;-)
9089 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
9091 2002-10-20 Mark Crichton <crichton@gimp.org>
9093 * cfold.cs: Fixed compile blocker. Really fixed it this time.
9095 2002-10-20 Nick Drochak <ndrochak@gol.com>
9097 * cfold.cs: Fixed compile blocker.
9099 2002-10-20 Miguel de Icaza <miguel@ximian.com>
9101 * driver.cs: I was chekcing the key, not the file.
9103 2002-10-19 Ravi Pratap <ravi@ximian.com>
9105 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
9106 message that we were generating - we just need to silently return
9109 2002-10-19 Miguel de Icaza <miguel@ximian.com>
9111 * class.cs (Event.Define): Change my previous commit, as this
9112 breaks the debugger. This is a temporary hack, as it seems like
9113 the compiler is generating events incorrectly to begin with.
9115 * expression.cs (Binary.ResolveOperator): Added support for
9116 "U operator - (E x, E y)"
9118 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
9121 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
9122 init-only variables, but this path did not take into account that
9123 there might be also instance readonly variables. Correct this
9126 This fixes bug 32253
9128 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
9131 * driver.cs: Change the extension for modules to `netmodule'
9133 * cs-parser.jay: Improved slightly the location tracking for
9134 the debugger symbols.
9136 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
9137 modifiers that were specified instead of the hardcoded value
9138 (FamAndAssem). This was basically ignoring the static modifier,
9139 and others. Fixes 32429.
9141 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
9142 fixed a bug in the process (32476)
9144 * expression.cs (ArrayAccess.EmitAssign): Patch from
9145 hwang_rob@yahoo.ca that fixes bug 31834.3
9147 2002-10-18 Miguel de Icaza <miguel@ximian.com>
9149 * driver.cs: Make the module extension .netmodule.
9151 2002-10-16 Miguel de Icaza <miguel@ximian.com>
9153 * driver.cs: Report an error if the resource file is not found
9154 instead of crashing.
9156 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
9157 false, like Emit does.
9159 2002-10-16 Nick Drochak <ndrochak@gol.com>
9161 * typemanager.cs: Remove unused private member. Also reported mcs
9162 bug to report this as a warning like csc.
9164 2002-10-15 Martin Baulig <martin@gnome.org>
9166 * statement.cs (Statement.Emit): Made this a virtual method; emits
9167 the line number info and calls DoEmit().
9168 (Statement.DoEmit): New protected abstract method, formerly knows
9169 as Statement.Emit().
9171 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
9173 2002-10-11 Miguel de Icaza <miguel@ximian.com>
9175 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
9176 have fixed a remaining problem: not every AddXXXX was adding a
9177 fully qualified name.
9179 Now everyone registers a fully qualified name in the DeclSpace as
9180 being defined instead of the partial name.
9182 Downsides: we are slower than we need to be due to the excess
9183 copies and the names being registered this way.
9185 The reason for this is that we currently depend (on the corlib
9186 bootstrap for instance) that types are fully qualified, because
9187 we dump all the types in the namespace, and we should really have
9188 types inserted into the proper namespace, so we can only store the
9189 basenames in the defined_names array.
9191 2002-10-10 Martin Baulig <martin@gnome.org>
9193 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
9194 from bug #31834, see the bug report for a testcase which is
9197 2002-10-10 Martin Baulig <martin@gnome.org>
9199 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
9200 flow analysis code for this.
9202 * statement.cs (Do, While, For): Tell the flow analysis code about
9204 (FlowBranching.UsageVector): Added support for infinite loops.
9205 (Block.Resolve): Moved the dead code elimination here and use flow
9208 2002-10-09 Miguel de Icaza <miguel@ximian.com>
9210 * class.cs (Field.Define): Catch cycles on struct type
9213 * typemanager.cs (IsUnmanagedtype): Do not recursively check
9214 fields if the fields are static. We only need to check instance
9217 * expression.cs (As.DoResolve): Test for reference type.
9219 * statement.cs (Using.ResolveExpression): Use
9220 ConvertImplicitRequired, not ConvertImplicit which reports an
9222 (Using.ResolveLocalVariableDecls): ditto.
9224 * expression.cs (Binary.ResolveOperator): Report errors in a few
9225 places where we had to.
9227 * typemanager.cs (IsUnmanagedtype): Finish implementation.
9229 2002-10-08 Miguel de Icaza <miguel@ximian.com>
9231 * expression.cs: Use StoreFromPtr instead of extracting the type
9232 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
9234 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
9235 an enumeration value to a System.Enum, but System.Enum is not a
9236 value type, but an class type, so we need to box.
9238 (Expression.ConvertExplicit): One codepath could return
9239 errors but not flag them. Fix this. Fixes #31853
9241 * parameter.cs (Resolve): Do not allow void as a parameter type.
9243 2002-10-06 Martin Baulig <martin@gnome.org>
9245 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
9246 if it's a class type and not a struct. Fixes #31815.
9248 2002-10-06 Martin Baulig <martin@gnome.org>
9250 * statement.cs: Reworked the flow analysis code a bit to make it
9251 usable for dead code elimination.
9253 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9255 * cs-parser.jay: allow empty source files. Fixes bug #31781.
9257 2002-10-04 Miguel de Icaza <miguel@ximian.com>
9259 * expression.cs (ComposedCast.DoResolveType): A quick workaround
9260 to fix the test 165, will investigate deeper.
9262 2002-10-04 Martin Baulig <martin@gnome.org>
9264 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
9265 finally blocks actually work.
9266 (Try.Resolve): We don't need to create a sibling for `finally' if
9267 there is no finally block.
9269 2002-10-04 Martin Baulig <martin@gnome.org>
9271 * class.cs (Constructor.Define): The default accessibility for a
9272 non-default constructor is private, not public.
9274 2002-10-04 Miguel de Icaza <miguel@ximian.com>
9276 * class.cs (Constructor): Make AllowedModifiers public, add
9279 * cs-parser.jay: Perform the modifiers test here, as the
9280 constructor for the Constructor class usually receives a zero
9281 because of the way we create it (first we create, later we
9282 customize, and we were never checking the modifiers).
9284 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
9285 is a version of LookupTypeReflection that includes the type-name
9286 cache. This can be used as a fast path for functions that know
9287 the fully qualified name and are only calling into *.GetType() to
9288 obtain a composed type.
9290 This is also used by TypeManager.LookupType during its type
9293 (LookupType): We now also track the real type name, as sometimes
9294 we can get a quey for the real type name from things like
9295 ComposedCast. This fixes bug 31422.
9297 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
9298 complete type fullname, it does not have to go through the type
9299 resolution system to obtain the composed version of the type (for
9300 obtaining arrays or pointers).
9302 (Conditional.Emit): Use the EmitBoolExpression to
9303 generate nicer code, as requested by Paolo.
9305 (ArrayCreation.CheckIndices): Use the patch from
9306 hwang_rob@yahoo.ca to validate the array initializers.
9308 2002-10-03 Miguel de Icaza <miguel@ximian.com>
9310 * class.cs (ConstructorInitializer.Emit): simplify code by using
9311 Invocation.EmitCall, and at the same time, fix the bugs in calling
9312 parent constructors that took variable arguments.
9314 * ecore.cs (Expression.ConvertNumericExplicit,
9315 Expression.ImplicitNumericConversion): Remove the code that
9316 manually wrapped decimal (InternalTypeConstructor call is now gone
9319 * expression.cs (Cast.TryReduce): Also handle decimal types when
9320 trying to perform a constant fold on the type.
9322 * typemanager.cs (IsUnmanagedtype): Partially implemented.
9324 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
9325 that only turned off an error report, and did nothing else.
9327 2002-10-02 Miguel de Icaza <miguel@ximian.com>
9329 * driver.cs: Handle and ignore /fullpaths
9331 2002-10-01 Miguel de Icaza <miguel@ximian.com>
9333 * expression.cs (Binary.ResolveOperator): Catch the case where
9334 DoNumericPromotions returns true,
9336 (Binary.DoNumericPromotions): Simplify the code, and the tests.
9338 2002-09-27 Miguel de Icaza <miguel@ximian.com>
9340 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
9343 2002-09-26 Miguel de Icaza <miguel@ximian.com>
9345 * ecore.cs (ConvertNumericExplicit): It is not enough that the
9346 conversion exists, but it is also required that the conversion be
9347 performed. This manifested in "(Type64Enum) 2".
9349 * class.cs (TypeManager.AddMethod): The fix is not to change
9350 AddEnum, because that one was using a fully qualified name (every
9351 DeclSpace derivative does), but to change the AddMethod routine
9352 that was using an un-namespaced name. This now correctly reports
9353 the duplicated name.
9355 Revert patch until I can properly fix it. The issue
9356 is that we have a shared Type space across all namespaces
9357 currently, which is wrong.
9359 Options include making the Namespace a DeclSpace, and merge
9360 current_namespace/current_container in the parser.
9362 2002-09-25 Miguel de Icaza <miguel@ximian.com>
9364 * cs-parser.jay: Improve error reporting when we get a different
9365 kind of expression in local_variable_type and
9366 local_variable_pointer_type.
9368 Propagate this to avoid missleading errors being reported.
9370 * ecore.cs (ImplicitReferenceConversion): treat
9371 TypeManager.value_type as a target just like object_type. As
9376 Is valid, and needs to result in the int 1 being boxed before it
9377 is assigned to the value type v.
9379 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
9380 to validate the enumeration name.
9382 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
9383 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
9384 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
9386 * ecore.cs (TryImplicitIntConversion): When doing an
9387 implicit-enumeration-conversion, check if the type is 64-bits and
9388 perform a conversion before passing to EnumConstant.
9390 2002-09-23 Miguel de Icaza <miguel@ximian.com>
9392 * decl.cs (Error_AmbiguousTypeReference); New routine used to
9393 report ambiguous type references. Unlike the MS version, we
9394 report what the ambiguity is. Innovation at work ;-)
9396 (DeclSpace.FindType): Require a location argument to
9397 display when we display an ambiguous error.
9399 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
9401 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
9403 * expression.cs (EmitDynamicInitializers): Apply patch from
9404 hwang_rob@yahoo.ca that fixes the order in which we emit our
9407 2002-09-21 Martin Baulig <martin@gnome.org>
9409 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
9410 delegate takes no arguments.
9412 2002-09-20 Miguel de Icaza <miguel@ximian.com>
9414 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
9417 * expression.cs: Extract the underlying type.
9419 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
9421 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
9423 2002-09-19 Miguel de Icaza <miguel@ximian.com>
9425 * class.cs (TypeContainer.DefineType): We can not use the nice
9426 PackingSize with the size set to 1 DefineType method, because it
9427 will not allow us to define the interfaces that the struct
9430 This completes the fixing of bug 27287
9432 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
9433 means also structs. This fixes part of the problem.
9434 (Expresion.ImplicitReferenceConversionExists): ditto.
9436 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
9437 error if there were no errors reported during the type lookup
9438 process, to avoid duplicates or redundant errors. Without this
9439 you would get an ambiguous errors plus a type not found. We have
9440 beaten the user enough with the first error.
9442 (DeclSparce.FindType): Emit a warning if we have an ambiguous
9445 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
9446 during the resolution process, stop the lookup, this avoids
9447 repeated error reports (same error twice).
9449 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
9451 * typemanager.cs (LookupType): Redo the type lookup code to match
9452 the needs of System.Reflection.
9454 The issue is that System.Reflection requires references to nested
9455 types to begin with a "+" sign instead of a dot. So toplevel
9456 types look like: "NameSpace.TopLevelClass", and nested ones look
9457 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
9460 2002-09-19 Martin Baulig <martin@gnome.org>
9462 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
9463 says that a method always returns or always throws an exception,
9464 don't report the CS0161.
9466 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
9467 set `Returns = new_returns'.
9469 2002-09-19 Martin Baulig <martin@gnome.org>
9471 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
9472 to an enum constant, check for a CS0176.
9474 2002-09-18 Miguel de Icaza <miguel@ximian.com>
9476 * class.cs (TypeContainer.CheckPairedOperators): Now we check
9477 for operators that must be in pairs and report errors.
9479 * ecore.cs (SimpleName.DoResolveType): During the initial type
9480 resolution process, when we define types recursively, we must
9481 check first for types in our current scope before we perform
9482 lookups in the enclosing scopes.
9484 * expression.cs (MakeByteBlob): Handle Decimal blobs.
9486 (Invocation.VerifyArgumentsCompat): Call
9487 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
9488 I thought we were supposed to always call this, but there are a
9489 few places in the code where we dont do it.
9491 2002-09-17 Miguel de Icaza <miguel@ximian.com>
9493 * driver.cs: Add support in -linkres and -resource to specify the
9494 name of the identifier.
9496 2002-09-16 Miguel de Icaza <miguel@ximian.com>
9498 * ecore.cs (StandardConversionExists): Sync with the conversion
9499 code: allow anything-* to void* conversions.
9501 (FindMostSpecificSource): Use an Expression argument
9502 instead of a Type, because we might be handed over a Literal which
9503 gets a few more implicit conversions that plain types do not. So
9504 this information was being lost.
9506 Also, we drop the temporary type-holder expression when not
9509 2002-09-17 Martin Baulig <martin@gnome.org>
9511 * class.cs (PropertyBase.CheckBase): Don't check the base class if
9512 this is an explicit interface implementation.
9514 2002-09-17 Martin Baulig <martin@gnome.org>
9516 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
9517 different `IndexerName' attributes.
9519 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
9520 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
9521 virtual CommonResolve().
9523 2002-09-16 Miguel de Icaza <miguel@ximian.com>
9525 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
9526 and convert that to the UnderlyingType.
9528 * statement.cs (Foreach.Resolve): Indexers are just like variables
9529 or PropertyAccesses.
9531 * cs-tokenizer.cs (consume_string): Track line numbers and columns
9532 inside quoted strings, we were not doing this before.
9534 2002-09-16 Martin Baulig <martin@gnome.org>
9536 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
9537 resolve it. This is needed for the definite assignment check of the
9538 instance expression, fixes bug #29846.
9539 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
9541 2002-09-16 Nick Drochak <ndrochak@gol.com>
9543 * parameter.cs: Fix compile error. Cannot reference static member
9544 from an instance object. Is this an mcs bug?
9546 2002-09-14 Martin Baulig <martin@gnome.org>
9548 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
9549 multiple times. Fixes bug #30295, added test-166.cs.
9551 2002-09-14 Martin Baulig <martin@gnome.org>
9553 * statement.cs (Block.Emit): Don't emit unreachable code.
9554 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
9556 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
9558 2002-09-14 Martin Baulig <martin@gnome.org>
9560 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
9563 2002-09-14 Martin Baulig <martin@gnome.org>
9565 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
9566 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
9567 be false on the ms runtime.
9569 2002-09-13 Martin Baulig <martin@gnome.org>
9571 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
9572 the CS0038 error message.
9574 2002-09-12 Miguel de Icaza <miguel@ximian.com>
9576 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
9577 constant inside, return it.
9579 2002-09-12 Martin Baulig <martin@gnome.org>
9581 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
9582 implicit conversion can be done between enum types.
9584 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
9585 check whether an implicit conversion to the current enum's UnderlyingType
9586 exists and report an error if not.
9588 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
9589 without debugging support.
9591 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
9592 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
9594 2002-09-12 Martin Baulig <martin@gnome.org>
9596 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
9598 * ecore.cs (IMemberExpr.DeclaringType): New property.
9599 (SimpleName.SimpleNameResolve): Check whether we're accessing a
9600 nonstatic member of an outer type (CS0038).
9602 2002-09-11 Miguel de Icaza <miguel@ximian.com>
9604 * driver.cs: Activate the using-error detector at warning level
9605 4 (at least for MS-compatible APIs).
9607 * namespace.cs (VerifyUsing): Small buglett fix.
9609 * pending.cs (PendingImplementation): pass the container pointer.
9611 * interface.cs (GetMethods): Allow for recursive definition. Long
9612 term, I would like to move every type to support recursive
9613 definitions, not the current ordering mechanism that we have right
9616 The situation is this: Attributes are handled before interfaces,
9617 so we can apply attributes to interfaces. But some attributes
9618 implement interfaces, we will now handle the simple cases
9619 (recursive definitions will just get an error).
9621 * parameter.cs: Only invalidate types at the end if we fail to
9624 2002-09-09 Martin Baulig <martin@gnome.org>
9626 * ecore.cs (PropertyExpr.Emit): Also check for
9627 TypeManager.system_int_array_get_length so this'll also work when
9628 compiling corlib. Fixes #30003.
9630 2002-09-09 Martin Baulig <martin@gnome.org>
9632 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
9633 and throw an exception if we can't get the type's size. Fixed #30040,
9636 2002-09-09 Martin Baulig <martin@gnome.org>
9638 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
9640 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
9641 context. Fixes bug #30027.
9643 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
9644 virtual functions. Fixes bug #30043, added test-164.cs.
9646 2002-09-08 Ravi Pratap <ravi@ximian.com>
9648 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
9650 2002-09-08 Nick Drochak <ndrochak@gol.com>
9652 * driver.cs: Use an object to get the windows codepage since it's not a
9655 2002-09-08 Miguel de Icaza <miguel@ximian.com>
9657 * statement.cs (For.Emit): for infinite loops (test == null)
9658 return whether there is a break inside, not always "true".
9660 * namespace.cs (UsingEntry): New struct to hold the name of the
9661 using definition, the location where it is defined, and whether it
9662 has been used in a successful type lookup.
9664 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
9669 2002-09-06 Ravi Pratap <ravi@ximian.com>
9671 * attribute.cs : Fix incorrect code which relied on catching
9672 a NullReferenceException to detect a null being passed in
9673 where an object was expected.
9675 2002-09-06 Miguel de Icaza <miguel@ximian.com>
9677 * statement.cs (Try): flag the catch variable as assigned
9679 * expression.cs (Cast): Simplified by using ResolveType instead of
9682 * statement.cs (Catch): Fix bug by using ResolveType.
9684 2002-09-06 Ravi Pratap <ravi@ximian.com>
9686 * expression.cs (BetterConversion): Special case for when we have
9687 a NullLiteral as the argument and we have to choose between string
9688 and object types - we choose string the way csc does.
9690 * attribute.cs (Attribute.Resolve): Catch the
9691 NullReferenceException and report error #182 since the Mono
9692 runtime no more has the bug and having this exception raised means
9693 we tried to select a constructor which takes an object and is
9696 2002-09-05 Ravi Pratap <ravi@ximian.com>
9698 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
9699 message (1502, 1503) when we can't locate a method after overload
9700 resolution. This is much more informative and closes the bug
9703 * interface.cs (PopulateMethod): Return if there are no argument
9704 types. Fixes a NullReferenceException bug.
9706 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
9707 expressions too. Previously we were checking only in one place for
9708 positional arguments leaving out named arguments.
9710 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
9711 type to the enum type is not allowed. Remove code corresponding to
9714 (ConvertNumericExplicit): Allow explicit conversions from
9715 the underlying type to enum type. This precisely follows the spec
9716 and closes a bug filed by Gonzalo.
9718 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9721 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
9723 2002-09-03 Miguel de Icaza <miguel@ximian.com>
9725 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
9726 it was important that we stored the right value after the
9727 reduction in `converted'.
9729 2002-09-04 Martin Baulig <martin@gnome.org>
9731 * location.cs (Location.SymbolDocument): Use full pathnames for the
9734 2002-08-30 Miguel de Icaza <miguel@ximian.com>
9736 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
9737 of the expression resolve mechanism, because that will catch the
9738 SimpleName error failures.
9740 (Conditional): If we can not resolve the
9741 expression, return, do not crash.
9743 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9746 (location): display token name instead of its number.
9748 2002-08-28 Martin Baulig <martin@gnome.org>
9750 * expression.cs (Binary.ResolveOperator): Don't silently return
9751 but return an error if an operator cannot be applied between two
9754 2002-08-28 Martin Baulig <martin@gnome.org>
9756 * class.cs (Constructor.Define): Set the permission attributes
9757 correctly instead of making all constructors public.
9759 2002-08-28 Martin Baulig <martin@gnome.org>
9761 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
9762 for private members before reporting a CS0103; if we find anything,
9765 2002-08-28 Martin Baulig <martin@gnome.org>
9767 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
9768 to check whether `closure_start_type == closure_invocation_type',
9769 we also need to check whether `m.DeclaringType == closure_invocation_type'
9770 before bypassing the permission checks. We might be accessing
9771 protected/private members from the base class.
9772 (TypeManager.RealMemberLookup): Only set private_ok if private
9773 members were requested via BindingFlags.NonPublic.
9775 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
9777 * expression.cs (MemberAccess.ResolveMemberAccess): Set
9778 MethodGroupExpr.IsExplicitImpl if appropriate.
9779 (Invocation.DoResolve): Don't report the CS0120 for explicit
9780 interface implementations.
9782 2002-08-27 Martin Baulig <martin@gnome.org>
9784 * expression.cs (Invocation.DoResolve): If this is a static
9785 method and we don't have an InstanceExpression, we must report
9788 2002-08-25 Martin Baulig <martin@gnome.org>
9790 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
9791 `==' between a valuetype and an object.
9793 2002-08-25 Miguel de Icaza <miguel@ximian.com>
9795 * ecore.cs (TypeExpr): Provide a ToString method.
9797 2002-08-24 Martin Baulig <martin@gnome.org>
9799 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
9800 now called proggie.dbg and it's a binary file.
9802 2002-08-23 Martin Baulig <martin@gnome.org>
9804 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
9806 2002-08-23 Martin Baulig <martin@gnome.org>
9808 * struct.cs (MyStructInfo.ctor): Make this work with empty
9809 structs; it's not allowed to use foreach() on null.
9811 2002-08-23 Martin Baulig <martin@gnome.org>
9813 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
9814 writer the full pathname of the generated assembly.
9816 2002-08-23 Martin Baulig <martin@gnome.org>
9818 * statements.cs (FlowBranching.UsageVector.MergeChildren):
9819 A `finally' block never returns or breaks; improved handling of
9822 2002-08-23 Martin Baulig <martin@gnome.org>
9824 * statement.cs (Throw.Resolve): Allow `throw null'.
9826 2002-08-23 Martin Baulig <martin@gnome.org>
9828 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
9829 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
9830 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
9831 MemberLookup would return a wrong event if this is an explicit
9832 interface implementation and the class has an event with the same
9835 2002-08-23 Martin Baulig <martin@gnome.org>
9837 * statement.cs (Block.AddChildVariableNames): New public method.
9838 (Block.AddChildVariableName): Likewise.
9839 (Block.IsVariableNameUsedInChildBlock): Likewise.
9840 (Block.AddVariable): Check whether a variable name has already
9841 been used in a child block.
9843 * cs-parser.jay (declare_local_variables): Mark all variable names
9844 from the current block as being used in a child block in the
9847 2002-08-23 Martin Baulig <martin@gnome.org>
9849 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
9850 find the symbol writer.
9852 * driver.cs: csc also allows the arguments to /define being
9853 separated by commas, not only by semicolons.
9855 2002-08-23 Martin Baulig <martin@gnome.org>
9857 * interface.cs (Interface.GetMembers): Added static check for events.
9859 2002-08-15 Martin Baulig <martin@gnome.org>
9861 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
9862 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
9864 * ecore.cs (Expression.MemberLookup): Added documentation and explained
9865 why the MethodData.EmitDestructor() change was necessary.
9867 2002-08-20 Martin Baulig <martin@gnome.org>
9869 * class.cs (TypeContainer.FindMembers): Added static check for events.
9871 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
9873 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
9874 use Type.GetEvents(), not Type.FindMembers().
9876 2002-08-20 Martin Baulig <martin@gnome.org>
9878 * decl.cs (MemberCache): Added a special method cache which will
9879 be used for method-only searched. This ensures that a method
9880 search will return a MethodInfo with the correct ReflectedType for
9883 2002-08-20 Martin Baulig <martin@gnome.org>
9885 * decl.cs (DeclSpace.FindMembers): Made this public.
9887 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9889 * delegate.cs: fixed build on windows.
9890 [FIXME: Filed as bug #29150: MCS must report these errors.]
9892 2002-08-19 Ravi Pratap <ravi@ximian.com>
9894 * ecore.cs (StandardConversionExists): Return a false
9895 if we are trying to convert the void type to anything else
9896 since that is not allowed.
9898 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
9899 we flag error 70 in the event an event is trying to be accessed
9900 directly from outside the declaring type.
9902 2002-08-20 Martin Baulig <martin@gnome.org>
9904 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
9905 MemberCache from typemanager.cs to decl.cs.
9907 2002-08-19 Martin Baulig <martin@gnome.org>
9909 * class.cs (TypeContainer): Implement IMemberContainer.
9910 (TypeContainer.DefineMembers): Create the MemberCache.
9911 (TypeContainer.FindMembers): Do better BindingFlags checking; only
9912 return public members if BindingFlags.Public was given, check
9913 whether members are static.
9915 2002-08-16 Martin Baulig <martin@gnome.org>
9917 * decl.cs (DeclSpace.Define): Splitted this in Define and
9918 DefineMembers. DefineMembers is called first and initializes the
9921 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
9922 DefineMembers() on all our DeclSpaces.
9924 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
9925 but call DefineMembers() on all nested interfaces. We call their
9926 Define() in our new Define() function.
9928 * interface.cs (Interface): Implement IMemberContainer.
9929 (Interface.Define): Moved all code except the attribute stuf to
9931 (Interface.DefineMembers): Initialize the member cache.
9933 * typemanager.cs (IMemberFinder): Removed this interface, we don't
9934 need this anymore since we can use MemberCache.FindMembers directly.
9936 2002-08-19 Martin Baulig <martin@gnome.org>
9938 * typemanager.cs (MemberCache): When creating the cache for an
9939 interface type, add all inherited members.
9940 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
9941 to `out bool used_cache' and documented it.
9942 (TypeManager.MemberLookup): If we already used the cache in the first
9943 iteration, we don't need to do the interfaces check.
9945 2002-08-19 Martin Baulig <martin@gnome.org>
9947 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
9948 here from IMemberFinder and don't implement this interface anymore.
9949 (DeclSpace.MemberCache): Moved here from IMemberFinder.
9951 * typemanager.cs (IMemberFinder): This interface is now only used by
9952 classes which actually support the member cache.
9953 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
9954 since we only put DeclSpaces into this Hashtable.
9955 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
9956 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
9958 2002-08-16 Martin Baulig <martin@gnome.org>
9960 * typemanager.cs (ICachingMemberFinder): Removed.
9961 (IMemberFinder.MemberCache): New property.
9962 (TypeManager.FindMembers): Merged this with RealFindMembers().
9963 This function will never be called from TypeManager.MemberLookup()
9964 so we can't use the cache here, just the IMemberFinder.
9965 (TypeManager.MemberLookup_FindMembers): Check whether the
9966 IMemberFinder has a MemberCache and call the cache's FindMembers
9968 (MemberCache): Rewrote larger parts of this yet another time and
9969 cleaned it up a bit.
9971 2002-08-15 Miguel de Icaza <miguel@ximian.com>
9973 * driver.cs (LoadArgs): Support quoting.
9975 (Usage): Show the CSC-like command line arguments.
9977 Improved a few error messages.
9979 2002-08-15 Martin Baulig <martin@gnome.org>
9981 * typemanager.cs (IMemberContainer.Type): New property.
9982 (IMemberContainer.IsInterface): New property.
9984 The following changes are conditional to BROKEN_RUNTIME, which is
9985 defined at the top of the file.
9987 * typemanager.cs (MemberCache.MemberCache): Don't add the base
9988 class'es members, but add all members from TypeHandle.ObjectType
9989 if we're an interface.
9990 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
9991 is the current type.
9992 (MemberCache.CacheEntry.Container): Removed this field.
9993 (TypeHandle.GetMembers): Include inherited members.
9995 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9997 * typemanager.cs: fixed compilation and added a comment on a field that
10000 2002-08-15 Martin Baulig <martin@gnome.org>
10002 * class.cs (ConstructorInitializer.Resolve): In the
10003 Expression.MemberLookup call, use the queried_type as
10006 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
10007 declared' attribute, it's always true.
10008 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
10009 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
10010 temporary wrapper for FindMembers which tells MemberLookup whether
10011 members from the base classes are included in the return value.
10012 This will go away soon.
10013 (TypeManager.MemberLookup): Use this temporary hack here; once the
10014 new MemberCache is completed, we don't need to do the DeclaredOnly
10015 looping here anymore since the MemberCache will take care of this.
10016 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
10017 (MemberCache): When creating the MemberCache for a class, get
10018 members from the current class and all its base classes.
10019 (MemberCache.CacheEntry.Container): New field. This is a
10020 temporary hack until the Mono runtime is fixed to distinguish
10021 between ReflectedType and DeclaringType. It allows us to use MCS
10022 with both the MS runtime and the unfixed Mono runtime without
10023 problems and without accecting performance.
10024 (MemberCache.SearchMembers): The DeclaredOnly looping from
10025 TypeManager.MemberLookup is now done here.
10027 2002-08-14 Martin Baulig <martin@gnome.org>
10029 * statement.cs (MyStructInfo.MyStructInfo): Don't call
10030 Type.GetFields on dynamic types but get the fields from the
10031 corresponding TypeContainer.
10032 (MyStructInfo.GetStructInfo): Added check for enum types.
10034 * typemanager.cs (MemberList.IsSynchronized): Implemented.
10035 (MemberList.SyncRoot): Implemented.
10036 (TypeManager.FilterWithClosure): No need to check permissions if
10037 closure_start_type == closure_invocation_type, don't crash if
10038 closure_invocation_type is null.
10040 2002-08-13 Martin Baulig <martin@gnome.org>
10042 Rewrote TypeContainer.FindMembers to use a member cache. This
10043 gives us a speed increase of about 35% for the self-hosting MCS
10044 build and of about 15-20% for the class libs (both on GNU/Linux).
10046 * report.cs (Timer): New class to get enhanced profiling. This
10047 whole class is "TIMER" conditional since it remarkably slows down
10050 * class.cs (MemberList): New class. This is an IList wrapper
10051 which we're now using instead of passing MemberInfo[]'s around to
10052 avoid copying this array unnecessarily.
10053 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
10054 (ICachingMemberFinder, IMemberContainer): New interface.
10055 (TypeManager.FilterWithClosure): If `criteria' is null, the name
10056 has already been checked, otherwise use it for the name comparision.
10057 (TypeManager.FindMembers): Renamed to RealMemberFinder and
10058 provided wrapper which tries to use ICachingMemberFinder.FindMembers
10059 if possible. Returns a MemberList, not a MemberInfo [].
10060 (TypeHandle): New class, implements IMemberContainer. We create
10061 one instance of this class per type, it contains a MemberCache
10062 which is used to do the member lookups.
10063 (MemberCache): New class. Each instance of this class contains
10064 all members of a type and a name-based hash table.
10065 (MemberCache.FindMembers): This is our new member lookup
10066 function. First, it looks up all members of the requested name in
10067 the hash table. Then, it walks this list and sorts out all
10068 applicable members and returns them.
10070 2002-08-13 Martin Baulig <martin@gnome.org>
10072 In addition to a nice code cleanup, this gives us a performance
10073 increase of about 1.4% on GNU/Linux - not much, but it's already
10074 half a second for the self-hosting MCS compilation.
10076 * typemanager.cs (IMemberFinder): New interface. It is used by
10077 TypeManager.FindMembers to call FindMembers on a TypeContainer,
10078 Enum, Delegate or Interface.
10079 (TypeManager.finder_to_member_finder): New PtrHashtable.
10080 (TypeManager.finder_to_container): Removed.
10081 (TypeManager.finder_to_delegate): Removed.
10082 (TypeManager.finder_to_interface): Removed.
10083 (TypeManager.finder_to_enum): Removed.
10085 * interface.cs (Interface): Implement IMemberFinder.
10087 * delegate.cs (Delegate): Implement IMemberFinder.
10089 * enum.cs (Enum): Implement IMemberFinder.
10091 * class.cs (TypeContainer): Implement IMemberFinder.
10093 2002-08-12 Martin Baulig <martin@gnome.org>
10095 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
10097 2002-08-12 Martin Baulig <martin@gnome.org>
10099 * ecore.cs (ITypeExpression): New interface for expressions which
10101 (TypeExpression): Renamed to TypeLookupExpression.
10102 (Expression.DoResolve): If we're doing a types-only lookup, the
10103 expression must implement the ITypeExpression interface and we
10104 call DoResolveType() on it.
10105 (SimpleName): Implement the new ITypeExpression interface.
10106 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
10107 hack, the situation that we're only looking up types can't happen
10108 anymore when this method is called. Moved the type lookup code to
10109 DoResolveType() and call it.
10110 (SimpleName.DoResolveType): This ITypeExpression interface method
10111 is now doing the types-only lookup.
10112 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
10113 (ResolveFlags): Added MaskExprClass.
10115 * expression.cs (MemberAccess): Implement the ITypeExpression
10117 (MemberAccess.DoResolve): Added support for a types-only lookup
10118 when we're called via ITypeExpression.DoResolveType().
10119 (ComposedCast): Implement the ITypeExpression interface.
10121 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
10122 Expression.Resolve() with ResolveFlags.Type instead.
10124 2002-08-12 Martin Baulig <martin@gnome.org>
10126 * interface.cs (Interface.Define): Apply attributes.
10128 * attribute.cs (Attribute.ApplyAttributes): Added support for
10129 interface attributes.
10131 2002-08-11 Martin Baulig <martin@gnome.org>
10133 * statement.cs (Block.Emit): Only check the "this" variable if we
10134 do not always throw an exception.
10136 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
10137 whether the property has a set accessor.
10139 2002-08-11 Martin Baulig <martin@gnome.org>
10141 Added control flow analysis support for structs.
10143 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
10144 with control flow analysis turned off.
10145 (IVariable): New interface.
10146 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
10147 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
10148 (FieldExpr.DoResolve): Resolve the instance expression with flow
10149 analysis turned off and do the definite assignment check after the
10150 resolving when we know what the expression will resolve to.
10152 * expression.cs (LocalVariableReference, ParameterReference):
10153 Implement the new IVariable interface, only call the flow analysis
10154 code if ec.DoFlowAnalysis is true.
10155 (This): Added constructor which takes a Block argument. Implement
10156 the new IVariable interface.
10157 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
10158 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
10159 This does the definite assignment checks for struct members.
10161 * class.cs (Constructor.Emit): If this is a non-static `struct'
10162 constructor which doesn't have any initializer, call
10163 Block.AddThisVariable() to tell the flow analysis code that all
10164 struct elements must be initialized before control returns from
10167 * statement.cs (MyStructInfo): New public class.
10168 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
10169 argument to this indexer. If non-zero, check an individual struct
10170 member, not the whole struct.
10171 (FlowBranching.CheckOutParameters): Check struct members.
10172 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
10173 overloaded versions of these methods which take an additional
10174 `int field_idx' argument to check struct members.
10175 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
10176 overloaded versions of these methods which take an additional
10177 `string field_name' argument to check struct member.s
10178 (VariableInfo): Implement the IVariable interface.
10179 (VariableInfo.StructInfo): New public property. Returns the
10180 MyStructInfo instance of the variable if it's a struct or null.
10181 (Block.AddThisVariable): New public method. This is called from
10182 Constructor.Emit() for non-static `struct' constructor which do
10183 not have any initializer. It creates a special variable for the
10184 "this" instance variable which will be checked by the flow
10185 analysis code to ensure that all of the struct's fields are
10186 initialized before control returns from the constructor.
10187 (UsageVector): Added support for struct members. If a
10188 variable/parameter is a struct with N members, we reserve a slot
10189 in the usage vector for each member. A struct is considered fully
10190 initialized if either the struct itself (slot 0) or all its
10191 members are initialized.
10193 2002-08-08 Martin Baulig <martin@gnome.org>
10195 * driver.cs (Driver.MainDriver): Only report an error CS5001
10196 if there were no compilation errors.
10198 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
10199 `UnsafeContext' property to determine whether the parent is in
10200 unsafe context rather than checking the parent's ModFlags:
10201 classes nested in an unsafe class are unsafe as well.
10203 2002-08-08 Martin Baulig <martin@gnome.org>
10205 * statement.cs (UsageVector.MergeChildren): Distinguish between
10206 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
10207 we return. Added test17() and test18() to test-154.cs.
10209 2002-08-08 Martin Baulig <martin@gnome.org>
10211 * typemanager.cs (TypeManager.FilterWithClosure): If we have
10212 Family access, make sure the invoking type isn't a subclass of the
10213 queried type (that'd be a CS1540).
10215 * ecore.cs (Expression.MemberLookup): Added overloaded version of
10216 this method which takes an additional `Type invocation_type'.
10218 * expression.cs (BaseAccess.DoResolve): Use the base type as
10219 invocation and query type.
10220 (MemberAccess.DoResolve): If the lookup failed and we're about to
10221 report a CS0122, try a lookup with the ec.ContainerType - if this
10222 succeeds, we must report a CS1540.
10224 2002-08-08 Martin Baulig <martin@gnome.org>
10226 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
10227 (MethodGroupExpr): Implement the IMemberExpr interface.
10229 * expression (MemberAccess.ResolveMemberAccess): No need to have
10230 any special code for MethodGroupExprs anymore, they're now
10233 2002-08-08 Martin Baulig <martin@gnome.org>
10235 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
10236 Family, FamANDAssem and FamORAssem permissions.
10237 (TypeManager.IsSubclassOrNestedChildOf): New public method.
10239 2002-08-08 Martin Baulig <martin@gnome.org>
10241 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
10242 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
10245 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
10247 * driver.cs: implemented /resource option to embed managed resources.
10249 2002-08-07 Martin Baulig <martin@gnome.org>
10251 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
10252 (FieldBase.HasFieldInitializer): New public property.
10253 (FieldBase.GetInitializerExpression): New public method. Resolves and
10254 returns the field initializer and makes sure it is only resolved once.
10255 (TypeContainer.EmitFieldInitializers): Call
10256 FieldBase.GetInitializerExpression to get the initializer, this ensures
10257 that it isn't resolved multiple times.
10259 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
10260 the resolving process (SimpleName/MemberLookup) that we're currently
10261 emitting a field initializer (which must not access any instance members,
10262 this is an error CS0236).
10264 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
10265 argument, if the `IsFieldInitializer' flag is set, we must report and
10266 error CS0236 and not an error CS0120.
10268 2002-08-07 Martin Baulig <martin@gnome.org>
10270 * ecore.cs (IMemberExpr): New public interface.
10271 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
10272 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
10273 if the expression is an IMemberExpr.
10275 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
10276 to be null, implicitly default to `this' if we're non-static in
10277 this case. Simplified the code a lot by using the new IMemberExpr
10278 interface. Also fixed bug #28176 here.
10280 2002-08-06 Martin Baulig <martin@gnome.org>
10282 * cs-parser.jay (SimpleLookup): Removed. We need to create
10283 ParameterReferences during semantic analysis so that we can do a
10284 type-only search when resolving Cast, TypeOf and SizeOf.
10285 (block): Pass the `current_local_parameters' to the Block's
10288 * class.cs (ConstructorInitializer): Added `Parameters parameters'
10289 argument to the constructor.
10290 (ConstructorInitializer.Resolve): Create a temporary implicit
10291 block with the parameters.
10293 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
10294 references here if we aren't doing a type-only search.
10296 * statement.cs (Block): Added constructor which takes a
10297 `Parameters parameters' argument.
10298 (Block.Parameters): New public property.
10300 * support.cs (InternalParameters.Parameters): Renamed `parameters'
10301 to `Parameters' and made it public readonly.
10303 2002-08-06 Martin Baulig <martin@gnome.org>
10305 * ecore.cs (Expression.Warning): Made this public as well.
10307 * report.cs (Report.Debug): Print the contents of collections.
10309 2002-08-06 Martin Baulig <martin@gnome.org>
10311 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
10312 used to tell Resolve() which kinds of expressions it may return.
10313 (Expression.Resolve): Added overloaded version of this method which
10314 takes a `ResolveFlags flags' argument. This can be used to tell
10315 Resolve() which kinds of expressions it may return. Reports a
10317 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
10318 ResolveFlags.SimpleName.
10319 (Expression.Error118): Added overloaded version of this method which
10320 takes a `ResolveFlags flags' argument. It uses the flags to determine
10321 which kinds of expressions are allowed.
10323 * expression.cs (Argument.ResolveMethodGroup): New public method.
10324 Resolves an argument, but allows a MethodGroup to be returned.
10325 This is used when invoking a delegate.
10327 * TODO: Updated a bit.
10329 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10331 Fixed compilation with csc.
10333 * ecore.cs: Expression.Error made public. Is this correct? Should
10334 Warning be made public too?
10336 * expression.cs: use ea.Location instead of ea.loc.
10337 [FIXME: Filed as bug #28607: MCS must report these errors.]
10339 2002-08-06 Martin Baulig <martin@gnome.org>
10341 * ecore.cs (Expression.loc): Moved the location here instead of
10342 duplicating it in all derived classes.
10343 (Expression.Location): New public property.
10344 (Expression.Error, Expression.Warning): Made them non-static and
10345 removed the location argument.
10346 (Expression.Warning): Added overloaded version which takes an
10347 `int level' argument.
10348 (Expression.Error118): Make this non-static and removed the
10349 expression and location arguments.
10350 (TypeExpr): Added location argument to the constructor.
10352 * expression.cs (StaticCallExpr): Added location argument to
10354 (Indirection, PointerArithmetic): Likewise.
10355 (CheckedExpr, UnCheckedExpr): Likewise.
10356 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
10357 (StringPtr): Likewise.
10360 2002-08-05 Martin Baulig <martin@gnome.org>
10362 * expression.cs (BaseAccess.DoResolve): Actually report errors.
10364 * assign.cs (Assign.DoResolve): Check whether the source
10365 expression is a value or variable.
10367 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
10368 while resolving the corresponding blocks.
10370 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
10371 an error, don't silently return null.
10373 * statement.cs (Block.AddVariable): Do the error reporting here
10374 and distinguish between CS0128 and CS0136.
10375 (Block.DoResolve): Report all unused labels (warning CS0164).
10376 (LabeledStatement): Pass the location to the constructor.
10377 (LabeledStatement.HasBeenReferenced): New property.
10378 (LabeledStatement.Resolve): Set it to true here.
10380 * statement.cs (Return.Emit): Return success even after reporting
10381 a type mismatch error (CS0126 or CS0127), this is what csc does and
10382 it avoids confusing the users with any consecutive errors.
10384 2002-08-05 Martin Baulig <martin@gnome.org>
10386 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
10388 * const.cs (Const.LookupConstantValue): Catch circular definitions.
10390 * expression.cs (MemberAccess.DoResolve): Silently return if an
10391 error has already been reported.
10393 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
10394 error has already been reported.
10396 2002-08-05 Martin Baulig <martin@gnome.org>
10398 * statement.cs (UsageVector): Only initialize the `parameters'
10399 vector if we actually have any "out" parameters.
10401 2002-08-05 Martin Baulig <martin@gnome.org>
10403 * expression.cs (Binary.ResolveOperator): When combining delegates,
10404 they must have the same type.
10406 2002-08-05 Martin Baulig <martin@gnome.org>
10408 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
10409 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
10410 work with the ms runtime and we also don't need it: if we're a
10411 PropertyBuilder and not in the `indexer_arguments' hash, then we
10412 are a property and not an indexer.
10414 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
10415 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
10416 since the latter one doesn't work with the ms runtime.
10418 2002-08-03 Martin Baulig <martin@gnome.org>
10420 Fixed bugs #27998 and #22735.
10422 * class.cs (Method.IsOperator): New public field.
10423 (Method.CheckBase): Report CS0111 if there's already a method
10424 with the same parameters in the current class. Report CS0508 when
10425 attempting to change the return type of an inherited method.
10426 (MethodData.Emit): Report CS0179 if a method doesn't have a body
10427 and it's not marked abstract or extern.
10428 (PropertyBase): New abstract base class for Property and Indexer.
10429 (PropertyBase.CheckBase): Moved here from Property and made it work
10431 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
10432 the same so we can reuse it there.
10433 (Property, Indexer): Derive from PropertyBase.
10434 (MethodSignature.inheritable_property_signature_filter): New delegate
10435 to find properties and indexers.
10437 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
10438 argument and improved error reporting.
10440 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
10441 EmptyReadOnlyParameters and made it a property.
10443 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
10444 version of this method which takes a `PropertyInfo indexer'.
10445 (TypeManager.RegisterIndexer): New method.
10447 * class.cs: Added myself as author of this file :-)
10449 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10451 * class.cs: fixed compilation on windoze.
10453 2002-08-03 Martin Baulig <martin@gnome.org>
10455 * interface.cs (Interface.GetInterfaceBases): Check whether all
10456 base interfaces are at least as accessible than the current one.
10458 * class.cs (TypeContainer.GetClassBases): Check whether base types
10459 are at least as accessible than the current type.
10460 (TypeContainer.AsAccessible): Implemented and made non-static.
10461 (MemberBase.CheckParameters): Report errors if the accessibility
10464 * delegate.cs (Delegate.Delegate): The default visibility is
10465 internal for top-level types and private for nested types.
10466 (Delegate.Define): Report errors if the accessibility checks fail.
10468 * enum.cs (Enum.Enum): The default visibility is internal for
10469 top-level types and private for nested types.
10470 (Enum.DefineType): Compute the correct visibility.
10472 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
10473 function which takes a `bool is_toplevel' instead of a TypeContainer.
10475 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
10478 2002-08-02 Martin Baulig <martin@gnome.org>
10480 * expression.cs (LocalVariableReferenc): Added constructor which
10481 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
10482 (LocalVariableReference.IsReadOnly): New property.
10483 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
10484 variable is readonly, use our own readonly flag to do this; you can
10485 use the new constructor to get a writable reference to a read-only
10488 * cs-parser.jay (foreach_statement, using_statement): Get a writable
10489 reference to the local variable.
10491 2002-08-01 Miguel de Icaza <miguel@ximian.com>
10493 * rootcontext.cs (ResolveCore): Also include System.Exception
10495 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
10496 we reach an EmptyStatement.
10498 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
10501 * expression.cs (Binary.ResolveOperator): Check error result in
10504 use brtrue/brfalse directly and avoid compares to null.
10506 2002-08-02 Martin Baulig <martin@gnome.org>
10508 * class.cs (TypeContainer.Define): Define all nested interfaces here.
10509 Fixes bug #28407, added test-155.cs.
10511 2002-08-01 Martin Baulig <martin@gnome.org>
10513 * class.cs (Event.EmitDefaultMethod): Make this work with static
10514 events. Fixes #28311, added verify-3.cs.
10516 2002-08-01 Martin Baulig <martin@gnome.org>
10518 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
10519 `is_disposable' fields.
10520 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
10521 `hm.is_disposable' if we're using the collection pattern.
10522 (Foreach.EmitCollectionForeach): Use the correct type for the
10523 enumerator's local variable, only emit the try/finally block if
10524 necessary (fixes #27713).
10526 2002-08-01 Martin Baulig <martin@gnome.org>
10528 * ecore.cs (Expression.report118): Renamed to Error118 and made
10531 * statement.cs (Throw.Resolve): Check whether the expression is of
10532 the correct type (CS0118) and whether the type derives from
10533 System.Exception (CS0155).
10534 (Catch.Resolve): New method. Do the type lookup here and check
10535 whether it derives from System.Exception (CS0155).
10536 (Catch.CatchType, Catch.IsGeneral): New public properties.
10538 * typemanager.cs (TypeManager.exception_type): Added.
10540 2002-07-31 Miguel de Icaza <miguel@ximian.com>
10542 * driver.cs: Updated About function.
10544 2002-07-31 Martin Baulig <martin@gnome.org>
10546 Implemented Control Flow Analysis.
10548 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
10549 (EmitContext.CurrentBranching): Added.
10550 (EmitContext.StartFlowBranching): Added.
10551 (EmitContext.EndFlowBranching): Added.
10552 (EmitContext.KillFlowBranching): Added.
10553 (EmitContext.IsVariableAssigned): Added.
10554 (EmitContext.SetVariableAssigned): Added.
10555 (EmitContext.IsParameterAssigned): Added.
10556 (EmitContext.SetParameterAssigned): Added.
10557 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
10558 Added control flow analysis stuff here.
10560 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
10561 resolve the expression as lvalue.
10562 (LocalVariableReference.DoResolve): Check whether the variable has
10563 already been assigned.
10564 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
10565 the parameter as assigned here.
10566 (ParameterReference.DoResolve): Check whether the parameter has already
10568 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
10569 expression as lvalue.
10571 * statement.cs (FlowBranching): New class for the flow analysis code.
10572 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
10573 (LabeledStatement.IsDefined): New public property.
10574 (LabeledStatement.AddUsageVector): New public method to tell flow
10575 analyis that the label may be reached via a forward jump.
10576 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
10578 (VariableInfo.Number): New public field. This is used by flow analysis
10579 to number all locals of a block.
10580 (Block.CountVariables): New public property. This is the number of
10581 local variables in this block (including the locals from all parent
10583 (Block.EmitMeta): Number all the variables.
10585 * statement.cs: Added flow analysis support to all classes.
10587 2002-07-31 Martin Baulig <martin@gnome.org>
10589 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
10590 To get debugging messages, compile mcs with /define:MCS_DEBUG and
10591 then use this argument.
10593 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
10595 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
10596 use this to specify /define options.
10598 2002-07-29 Martin Baulig <martin@gnome.org>
10600 * statement.cs (Fixed): Moved all code that does variable lookups
10601 and resolvings from Emit to Resolve.
10603 * statement.cs (For): Moved all code that does variable lookups
10604 and resolvings from Emit to Resolve.
10606 * statement.cs (Using): Moved all code that does variable lookups
10607 and resolvings from Emit to Resolve.
10609 2002-07-29 Martin Baulig <martin@gnome.org>
10611 * attribute.cs (Attribute.Resolve): Explicitly catch a
10612 System.NullReferenceException when creating the
10613 CustromAttributeBuilder and report a different warning message.
10615 2002-07-29 Martin Baulig <martin@gnome.org>
10617 * support.cs (ParameterData.ParameterName): Added method to
10618 get the name of a parameter.
10620 * typemanager.cs (TypeManager.IsValueType): New public method.
10622 2002-07-29 Martin Baulig <martin@gnome.org>
10624 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
10625 is a flag which specifies that it's either ref or out.
10626 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
10627 the out parameter to `out Parameter.Modifier mod', also set the
10628 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
10630 * support.cs (InternalParameters.ParameterModifier): Distinguish
10631 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
10632 Parameter.Modifier.ISBYREF flag if it's either ref or out.
10634 * expression.cs (Argument.GetParameterModifier): Distinguish
10635 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
10636 Parameter.Modifier.ISBYREF flag if it's either ref or out.
10638 2002-07-29 Martin Baulig <martin@gnome.org>
10640 * expression.cs (ParameterReference.ParameterReference): Added
10641 `Location loc' argument to the constructor.
10643 * cs-parser.jay: Pass location to ParameterReference.
10645 2002-07-28 Miguel de Icaza <miguel@ximian.com>
10647 * statement.cs (Try): Initialize the location.
10649 * cs-parser.jay: pass location to Try.
10651 * expression.cs (Unary.Reduce): Change the prototype to return
10652 whether a constant fold could be performed or not. The result is
10653 returned in an out parameters. In the case of Indirection and
10654 AddressOf, we want to perform the full tests.
10656 2002-07-26 Miguel de Icaza <miguel@ximian.com>
10658 * statement.cs (Statement.Emit): Flag dead code.
10660 2002-07-27 Andrew Birkett <andy@nobugs.org>
10662 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
10664 2002-07-27 Martin Baulig <martin@gnome.org>
10666 * class.cs (MethodData.Define): Put back call to
10667 TypeManager.AddMethod(), accidentally commented this out.
10669 * report.cs (Debug): New public method to print debugging information,
10670 this is `[Conditional ("DEBUG")]'.
10672 2002-07-26 Martin Baulig <martin@gnome.org>
10674 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
10675 (switch_statement): Push the current_block to the switch_stack and
10676 pop it again when we're done with the switch.
10677 (switch_section): The new block is a child of the current_block.
10678 Fixes bug #24007, added test-152.cs.
10680 2002-07-27 Martin Baulig <martin@gnome.org>
10682 * expression.cs (Invocation.EmitArguments): When calling a varargs
10683 function with only its fixed arguments, we need to pass an empty
10686 2002-07-27 Martin Baulig <martin@gnome.org>
10688 Mono 0.13 has been released.
10690 2002-07-25 Miguel de Icaza <miguel@ximian.com>
10692 * driver.cs: Rename --resource to --linkres, because that is what
10693 we do currently, we dont support --resource yet.
10695 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
10697 2002-07-25 Martin Baulig <martin@gnome.org>
10699 * class.cs (MethodData): New public class. This is a `method builder'
10700 class for a method or one accessor of a Property/Indexer/Event.
10701 (MethodData.GetMethodFlags): Moved here from MemberBase.
10702 (MethodData.ApplyAttributes): Likewise.
10703 (MethodData.ApplyObsoleteAttribute): Likewise.
10704 (MethodData.ApplyConditionalAttribute): Likewise.
10705 (MethodData.ApplyDllImportAttribute): Likewise.
10706 (MethodData.CheckAbstractAndExternal): Likewise.
10707 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
10708 (MethodData.Emit): Formerly known as Method.Emit().
10709 (MemberBase): Moved everything which was specific to a single
10710 accessor/method to MethodData.
10711 (Method): Create a new MethodData and call Define() and Emit() on it.
10712 (Property, Indexer, Event): Create a new MethodData objects for each
10713 accessor and call Define() and Emit() on them.
10715 2002-07-25 Martin Baulig <martin@gnome.org>
10717 Made MethodCore derive from MemberBase to reuse the code from there.
10718 MemberBase now also checks for attributes.
10720 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
10721 (MemberBase.GetMethodFlags): Moved here from class Method and marked
10723 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
10724 `CallingConventions cc' and `Attributes opt_attrs' arguments.
10725 (MemberBase.ApplyAttributes): New virtual method; applies the
10726 attributes to a method or accessor.
10727 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
10728 (MemberBase.ApplyConditionalAttribute): Likewise.
10729 (MemberBase.ApplyDllImportAttribute): Likewise.
10730 (MemberBase.CheckAbstractAndExternal): Likewise.
10731 (MethodCore.ParameterTypes): This is now a property instead of a
10732 method, it's initialized from DoDefineParameters().
10733 (MethodCore.ParameterInfo): Removed the set accessor.
10734 (MethodCore.DoDefineParameters): New protected virtual method to
10735 initialize ParameterTypes and ParameterInfo.
10736 (Method.GetReturnType): We can now simply return the MemberType.
10737 (Method.GetMethodFlags): Override the MemberBase version and add
10738 the conditional flags.
10739 (Method.CheckBase): Moved some code from Define() here, call
10740 DoDefineParameters() here.
10741 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
10742 here to avoid some larger code duplication.
10743 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
10744 ensure that abstract and external accessors don't declare a body.
10746 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
10747 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
10748 lookup in the attribute's parent classes, so we need to abort as soon
10749 as we found the first match.
10750 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
10751 the attribute has no arguments.
10753 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
10756 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10758 * cs-parser.jay: reverted previous patch.
10760 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10762 * cs-parser.jay: fixed bug #22119.
10764 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10766 * attribute.cs: fixed compilation. The error was:
10767 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
10768 be assigned to before control leaves the current method."
10769 [FIXME: Filed as bug #28186: MCS must report this error.]
10771 2002-07-25 Martin Baulig <martin@gnome.org>
10773 * attribute.cs (Attribute.Conditional_GetConditionName): New static
10774 method to pull the condition name ouf of a Conditional attribute.
10775 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
10776 the obsolete message and error flag out of an Obsolete attribute.
10778 * class.cs (Method.GetMethodFlags): New public method to get the
10779 TypeManager.MethodFlags for this method.
10780 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
10782 (Method.Define): Get and apply the Obsolete and Conditional attributes;
10783 if we're overriding a virtual function, set the new private variable
10784 `parent_method'; call the new TypeManager.AddMethod().
10786 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
10787 the MethodBuilder and the Method in a PtrHashtable.
10788 (TypeManager.builder_to_method): Added for this purpose.
10789 (TypeManager.MethodFlags): Added IsObsoleteError.
10790 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
10791 Obsolete and Conditional arguments in MethodBuilders. If we discover
10792 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
10793 the message from the attribute.
10795 2002-07-24 Martin Baulig <martin@gnome.org>
10797 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
10798 preprocessor directives, ensure that the argument to #define/#undef is
10799 exactly one identifier and that it's actually an identifier.
10801 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
10804 2002-07-24 Martin Baulig <martin@gnome.org>
10806 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
10807 initialize it to TypeManager.object_type in the constructor.
10808 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
10809 of the `hm.get_current' method if we're using the collection pattern.
10810 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
10811 for the explicit conversion to make it work when we're using the collection
10812 pattern and the `Current' property has a different return type than `object'.
10815 2002-07-24 Martin Baulig <martin@gnome.org>
10817 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
10818 does not match, but don't report any errors. This method is called in
10819 order for all methods in a MethodGroupExpr until a matching method is
10820 found, so we don't want to bail out if the first method doesn't match.
10821 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
10822 matches, report the 123. Fixes #28070.
10824 2002-07-24 Martin Baulig <martin@gnome.org>
10826 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
10827 TypeManager.TypeToCoreType() to the top of the method so the
10828 following equality checks will work. Fixes #28107.
10830 2002-07-24 Martin Baulig <martin@gnome.org>
10832 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
10833 operand is of type uint, and the other operand is of type sbyte,
10834 short or int, the operands are converted to type long." -
10835 Actually do what this comment already told us. Fixes bug #28106,
10838 2002-07-24 Martin Baulig <martin@gnome.org>
10840 * class.cs (MethodBase): New abstract class. This is now a base
10841 class for Property, Indexer and Event to avoid some code duplication
10842 in their Define() and DefineMethods() methods.
10843 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
10844 generic methods for Define() and DefineMethods().
10845 (FieldBase): Derive from MemberBase, not MemberCore.
10846 (Property): Derive from MemberBase, not MemberCore.
10847 (Property.DefineMethod): Moved all the code from this method to the
10848 new MethodBase.DefineAccessor(), just call it with appropriate
10850 (Property.Define): Call the new Property.DoDefine(), this does some
10851 sanity checks and we don't need to duplicate the code everywhere.
10852 (Event): Derive from MemberBase, not MemberCore.
10853 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
10854 accessors, this will also make them work with interface events.
10855 (Indexer): Derive from MemberBase, not MemberCore.
10856 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
10857 (Indexer.Define): Use the new MethodBase functions.
10859 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
10860 argument to the constructor.
10861 (Interface.FindMembers): Added support for interface events.
10862 (Interface.PopluateEvent): Implemented.
10864 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
10866 2002-07-22 Miguel de Icaza <miguel@ximian.com>
10868 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
10869 but this is required to check for a method name being the same as
10870 the containing class.
10874 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10876 * interface.cs: initialize variable.
10878 2002-07-23 Martin Baulig <martin@gnome.org>
10880 Implemented the IndexerName attribute in interfaces.
10882 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
10883 name if this is an explicit interface implementation.
10884 (Indexer.InterfaceIndexerName): New public variable. If we're
10885 implementing an interface indexer, this is the IndexerName in that
10886 interface. Otherwise, it's the IndexerName.
10887 (Indexer.DefineMethod): If we're implementing interface indexer,
10888 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
10889 and Pending.ImplementIndexer methods.
10890 (Indexer.Define): Also define the PropertyBuilder if we're
10891 implementing an interface indexer and this is neither an explicit
10892 interface implementation nor do the IndexerName match the one in
10895 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
10896 If a method is defined here, then we always need to create a proxy
10897 for it. This is used when implementing interface indexers.
10898 (Pending.IsInterfaceIndexer): New public method.
10899 (Pending.ImplementIndexer): New public method.
10900 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
10901 This is used when implementing interface indexers to define a proxy
10903 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
10904 define a proxy if necessary.
10906 * interface.cs (Interface.IndexerName): New public variable.
10907 (Interface.PopulateIndexer): Set the IndexerName.
10908 (Interface.DefineIndexers): New private method. Populate all the
10909 indexers and make sure their IndexerNames match.
10911 * typemanager.cs (IndexerPropertyName): Added support for interface
10914 2002-07-22 Martin Baulig <martin@gnome.org>
10916 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
10917 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
10918 ret if HasReturnLabel.
10919 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
10922 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
10923 and set the ec.LoopBeginTryCatchLevel.
10924 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
10925 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
10926 the current ec.TryCatchLevel, the branch goes out of an exception
10927 block. In this case, we need to use Leave and not Br.
10929 2002-07-22 Martin Baulig <martin@gnome.org>
10931 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
10932 block unless the block does not always return or it is contained in
10933 another try { ... } catch { ... } block. Fixes bug #26506.
10934 Added verify-1.cs to the test suite.
10936 2002-07-22 Martin Baulig <martin@gnome.org>
10938 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
10939 then we do not always return. Fixes bug #24985.
10941 2002-07-22 Martin Baulig <martin@gnome.org>
10943 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
10944 lookup on a per-class level; ie. walk up the class hierarchy until we
10945 found at least one applicable method, then choose the best among them.
10946 Fixes bug #24463 and test-29.cs.
10948 2002-07-22 Martin Baulig <martin@gnome.org>
10950 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
10951 return types of the methods. The return type is not part of the
10952 signature and we must not check it to make the `new' modifier work.
10953 Fixes bug #27999, also added test-147.cs.
10954 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
10956 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
10957 on the method's return type.
10959 2002-07-21 Martin Baulig <martin@gnome.org>
10961 * assign.cs: Make this work if the rightmost source is a constant and
10962 we need to do an implicit type conversion. Also adding a few more tests
10963 to test-38.cs which should have caught this.
10965 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
10966 target in the makefile for this. The makefile.gnu is primarily intended
10967 for end-users who don't want to debug the compiler.
10969 2002-07-21 Martin Baulig <martin@gnome.org>
10971 * assign.cs: Improved the Assign class so it can now handle embedded
10972 assignments (X = Y = Z = something). As a side-effect this'll now also
10973 consume less local variables. test-38.cs now passes with MCS, added
10974 a few new test cases to that test.
10976 2002-07-20 Martin Baulig <martin@gnome.org>
10978 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
10979 instructions. Fixes bug #27977, also added test-146.cs.
10981 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10983 * cs-tokenizer.cs: fixed getHex ().
10985 2002-07-19 Martin Baulig <martin@gnome.org>
10987 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
10988 not Type.GetType() to lookup the array type. This is needed when
10989 we're constructing an array of a user-defined type.
10990 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
10991 single-dimensional arrays, but also for single-dimensial arrays of
10994 2002-07-19 Martin Baulig <martin@gnome.org>
10996 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
10997 this function is called, it's not allowed to share LocalBuilders
10998 among ILGenerators.
11000 2002-07-19 Martin Baulig <martin@gnome.org>
11002 * expression.cs (Argument.Resolve): Report an error 118 when trying
11003 to pass a type as argument.
11005 2002-07-18 Martin Baulig <martin@gnome.org>
11007 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
11008 Conv_R_Un for the signed `long' type.
11010 2002-07-15 Miguel de Icaza <miguel@ximian.com>
11012 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
11013 `expr' for the temporary result, as that will fail if we do
11014 multiple resolves on the same expression.
11016 2002-07-05 Miguel de Icaza <miguel@ximian.com>
11018 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
11019 ec.TypeContainer for looking up aliases.
11021 * class.cs (TypeContainer): Remove LookupAlias from here.
11023 * decl.cs (DeclSpace); Move here.
11025 2002-07-01 Miguel de Icaza <miguel@ximian.com>
11027 * class.cs (FindMembers): Only call filter if the constructor
11028 bulider is not null.
11030 Also handle delegates in `NestedTypes' now. Now we will perform
11031 type lookups using the standard resolution process. This also
11034 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
11035 This uses Expressions (the limited kind that can be parsed by the
11036 tree) instead of strings.
11038 * expression.cs (ComposedCast.ToString): Implement, used to flag
11039 errors since now we have to render expressions.
11041 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
11044 * ecore.cs (SimpleName.ToString): ditto.
11046 * cs-parser.jay: Instead of using strings to assemble types, use
11047 Expressions to assemble the type (using SimpleName, ComposedCast,
11048 MemberAccess). This should fix the type lookups in declarations,
11049 because we were using a different code path for this.
11051 * statement.cs (Block.Resolve): Continue processing statements
11052 even when there is an error.
11054 2002-07-17 Miguel de Icaza <miguel@ximian.com>
11056 * class.cs (Event.Define): Also remove the `remove' method from
11057 the list of pending items.
11059 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
11060 generate more compact code.
11062 2002-07-17 Martin Baulig <martin@gnome.org>
11064 * const.cs (Const.LookupConstantValue): Add support for constant
11065 `unchecked' and `checked' expressions.
11066 Also adding test case test-140.cs for this.
11068 2002-07-17 Martin Baulig <martin@gnome.org>
11070 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
11071 check whether mi.ReturnType implements the IEnumerator interface; the
11072 `==' and the IsAssignableFrom() will fail in this situation.
11074 2002-07-16 Ravi Pratap <ravi@ximian.com>
11076 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
11079 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11081 * expression.cs: fixed bug #27811.
11083 2002-07-14 Miguel de Icaza <miguel@ximian.com>
11085 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
11086 Molaro: when we are a ref, the value already contains a pointer
11087 value, do not take the address of it.
11089 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
11090 * removed mb-parser.jay and mb-tokenizer.cs
11092 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
11094 * expression.cs: check against the building corlib void type.
11096 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
11098 * ecore.cs: fix for valuetype static readonly fields: when
11099 initializing them, we need their address, not the address of a copy.
11101 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
11103 * typemanager.cs: register also enum_type in corlib.
11105 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
11107 * class.cs: allow calling this (but not base) initializers in structs.
11109 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
11111 * ecore.cs: make sure we compare against the building base types
11114 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
11116 * typemanager.cs: fix TypeToCoreType() to handle void and object
11117 (corlib gets no more typerefs after this change).
11119 2002-07-12 Miguel de Icaza <miguel@ximian.com>
11121 * expression.cs (ArrayCreation.EmitArrayArguments): use
11122 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
11124 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
11125 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
11126 array indexes, the runtime actually forbids them.
11128 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
11129 for array arguments here.
11131 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
11132 instead of the default for ValueTypes.
11134 (New.DoEmit): Use IsValueType instead of
11135 IsSubclassOf (value_type)
11136 (New.DoResolve): ditto.
11137 (Invocation.EmitCall): ditto.
11139 * assign.cs (Assign): ditto.
11141 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
11142 Statements *are* currently doing part of their resolution during
11145 Expressions do always resolve during resolve, but statements are
11146 only required to propagate resolution to their children.
11148 2002-07-11 Miguel de Icaza <miguel@ximian.com>
11150 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
11152 (LoadAssembly): Do not add the dll if it is already specified
11154 (MainDriver): Add the System directory to the link path at the end,
11155 after all the other -L arguments.
11157 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
11158 wrong opcode for loading bytes and bools (ldelem.i1 instead of
11159 ldelem.u1) and using the opposite for sbytes.
11161 This fixes Digger, and we can finally run it.
11163 * driver.cs (UnixParseOption): Move the option parsing here.
11164 (CSCParseOption): Implement CSC-like parsing of options.
11166 We now support both modes of operation, the old Unix way, and the
11167 new CSC-like way. This should help those who wanted to make cross
11168 platform makefiles.
11170 The only thing broken is that /r:, /reference: and /lib: are not
11171 implemented, because I want to make those have the same semantics
11172 as the CSC compiler has, and kill once and for all the confussion
11173 around this. Will be doing this tomorrow.
11175 * statement.cs (Unsafe.Resolve): The state is checked during
11176 resolve, not emit, so we have to set the flags for IsUnsfe here.
11178 2002-07-10 Miguel de Icaza <miguel@ximian.com>
11180 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
11181 not catch the Error_ObjectRefRequired in SimpleName (as it is
11182 possible to have a class/instance variable name that later gets
11183 deambiguated), we have to check this here.
11185 2002-07-10 Ravi Pratap <ravi@ximian.com>
11187 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
11188 make static and put into Expression.
11190 (Event.Define): Register the private field of the event with the
11191 TypeManager so that GetFieldFromEvent can get at it.
11193 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
11194 keep track of the private field associated with an event which
11197 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
11200 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
11202 2002-07-10 Miguel de Icaza <miguel@ximian.com>
11204 * expression.cs (Binary.EmitBranchable): this routine emits the
11205 Binary expression in a branchable context. This basically means:
11206 we need to branch somewhere, not just get the value on the stack.
11208 This works together with Statement.EmitBoolExpression.
11210 * statement.cs (Statement.EmitBoolExpression): Use
11213 2002-07-09 Miguel de Icaza <miguel@ximian.com>
11215 * statement.cs (For): Reduce the number of jumps in loops.
11217 (For): Implement loop inversion for the For statement.
11219 (Break): We can be breaking out of a Try/Catch controlled section
11220 (foreach might have an implicit try/catch clause), so we need to
11221 use Leave instead of Br.
11223 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
11224 now). If the instace expression supports IMemoryLocation, we use
11225 the AddressOf method from the IMemoryLocation to extract the
11226 address instead of emitting the instance.
11228 This showed up with `This', as we were emitting the instance
11229 always (Emit) instead of the Address of This. Particularly
11230 interesting when This is a value type, as we dont want the Emit
11231 effect (which was to load the object).
11233 2002-07-08 Miguel de Icaza <miguel@ximian.com>
11235 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
11237 * statement.cs (Checked): Set the CheckedState during the resolve
11238 process too, as the ConvCast operations track the checked state on
11239 the resolve process, and not emit.
11241 * cs-parser.jay (namespace_member_declaration): Flag that we have
11242 found a declaration when we do. This is used to flag error 1529
11244 * driver.cs: Report ok when we display the help only.
11246 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
11248 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
11250 2002-07-04 Miguel de Icaza <miguel@ximian.com>
11252 * cs-tokenizer.cs (define): We also have to track locally the
11253 defines. AllDefines is just used for the Conditional Attribute,
11254 but we also need the local defines for the current source code.
11256 2002-07-03 Miguel de Icaza <miguel@ximian.com>
11258 * statement.cs (While, For, Do): These loops can exit through a
11259 Break statement, use this information to tell whether the
11260 statement is the last piece of code.
11262 (Break): Flag that we break.
11264 * codegen.cs (EmitContexts): New `Breaks' state variable.
11266 2002-07-03 Martin Baulig <martin@gnome.org>
11268 * class.cs (TypeContainer.MethodModifiersValid): Allow override
11269 modifiers in method declarations in structs. Otherwise, you won't
11270 be able to override things like Object.Equals().
11272 2002-07-02 Miguel de Icaza <miguel@ximian.com>
11274 * class.cs (Method, Property, Indexer): Do not allow the public
11275 modifier to be used in explicit interface implementations.
11277 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
11278 override modifiers in method declarations in structs
11280 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
11282 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
11283 integer or real overflow, report an error
11285 2002-07-02 Martin Baulig <martin@gnome.org>
11287 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
11288 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
11289 to tell the runtime about our newly created System.Object and
11290 System.ValueType types.
11292 2002-07-02 Miguel de Icaza <miguel@ximian.com>
11294 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
11295 struct instead of Ldarg/Starg.
11297 2002-07-02 Martin Baulig <martin@gnome.org>
11299 * expression.cs (Indirection.Indirection): Call
11300 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
11302 2002-07-02 Martin Baulig <martin@gnome.org>
11304 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
11305 ValueType, call TypeManager.TypeToCoreType() on it.
11306 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
11307 the OpCodes.Newarr argument.
11309 2002-07-02 Martin Baulig <martin@gnome.org>
11311 * expression.cs (Invocation.EmitCall): When compiling corlib,
11312 replace all calls to the system's System.Array type to calls to
11313 the newly created one.
11315 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
11316 System.Array methods.
11317 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
11318 from the system's System.Array type which must be replaced.
11320 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
11322 * typemanager.cs: load unverifiable_code_ctor so we can build
11323 corlib using the correct type. Avoid using GetTypeCode() with
11325 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
11326 TypeManager.object_type to allow building corlib.
11328 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
11330 * ecore.cs: handle System.Enum separately in LoadFromPtr().
11332 2002-07-01 Martin Baulig <martin@gnome.org>
11334 * class.cs: Make the last change actually work, we need to check
11335 whether `ifaces != null' to avoid a crash.
11337 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
11339 * class.cs: when we build structs without fields that implement
11340 interfaces, we need to add the interfaces separately, since there is
11341 no API to both set the size and add the interfaces at type creation
11344 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
11346 * expression.cs: the dimension arguments to the array constructors
11347 need to be converted if they are a long.
11349 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
11351 * class.cs: don't emit ldarg.0 if there is no parent constructor
11352 (fixes showstopper for corlib).
11354 2002-06-29 Martin Baulig <martin@gnome.org>
11356 MCS now compiles corlib on GNU/Linux :-)
11358 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
11359 ie. check for MethodImplOptions.InternalCall.
11361 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
11362 and TypeManager.attribute_type are null, so we must explicitly check
11363 whether parent is not null to find out whether it's an attribute type.
11364 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
11365 and SetBuilder, not only if the property is neither abstract nor external.
11366 This is necessary to set the MethodImplOptions on the accessor methods.
11367 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
11368 SetBuilder, see Property.Emit().
11370 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
11371 populate "System.Object", "System.ValueType" and "System.Attribute" since
11372 they've already been populated from BootCorlib_PopulateCoreTypes().
11374 2002-06-29 Martin Baulig <martin@gnome.org>
11376 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
11377 is the NullLiteral, we also need to make sure that target_type is not
11380 2002-06-29 Martin Baulig <martin@gnome.org>
11382 * rootcontext.cs (RootContext.ResolveCore): We must initialize
11383 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
11384 before calling BootstrapCorlib_ResolveDelegate ().
11386 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11388 * statement.cs: fixed build-breaker. All tests passed ok.
11390 2002-06-27 Martin Baulig <martin@gnome.org>
11392 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
11393 for System.Decimal when compiling corlib.
11395 2002-06-27 Martin Baulig <martin@gnome.org>
11397 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
11398 switch blocks which contain nothing but a default clause.
11400 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
11402 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
11404 2002-06-27 Martin Baulig <martin@gnome.org>
11406 * ecore.cs (PropertyExpr.PropertyExpr): Call
11407 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
11409 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
11410 is already a TypeBuilder.
11412 2002-06-27 Martin Baulig <martin@gnome.org>
11414 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
11415 `target_type == TypeManager.array_type', not IsAssignableFrom() in
11416 the "from an array-type to System.Array" case. This makes it work
11417 when compiling corlib.
11419 2002-06-27 Martin Baulig <martin@gnome.org>
11421 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
11422 non-static PropertyExpr, set its InstanceExpression. This makes
11423 the `ICollection.Count' property work in System/Array.cs.
11425 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
11427 * driver.cs: Made error handling more consistent. Errors now
11428 tracked by Report class, so many methods which used to return int
11429 now return void. Main() now prints success/failure and
11430 errors/warnings message.
11432 Renamed '--probe' compiler argument to '--expect-error'. Removed
11433 the magic number return values (123 and 124). Now, if the
11434 expected error occurs, the compiler exits with success (exit value
11435 0). If the compilation completes without seeing that particular
11436 error, the compiler exits with failure (exit value 1). The
11437 makefile in mcs/errors has been changed to handle the new behaviour.
11439 * report.cs: Made 'expected error' number a property and renamed
11440 it from 'Probe' to 'ExpectedError'.
11442 * genericparser.cs: Removed error handling support, since it is
11443 now all done by Report class.
11445 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
11446 class, so parse() no longer returns an int.
11448 * namespace.cs: Use Report.Error instead of GenericParser.error
11450 2002-06-22 Miguel de Icaza <miguel@ximian.com>
11452 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
11453 TypeContainer.AddOperator): At the front of the list put the
11454 explicit implementations, so they get resolved/defined first.
11456 2002-06-21 Miguel de Icaza <miguel@ximian.com>
11458 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
11459 interface type is implemented by this TypeContainer. Used during
11460 explicit interface implementation.
11462 (Property.Define, Indexer.Define, Method.Define): Validate that
11463 the given interface in the explicit implementation is one of the
11464 base classes for the containing type.
11466 Also if we are explicitly implementing an interface, but there is
11467 no match in the pending implementation table, report an error.
11469 (Property.Define): Only define the property if we are
11470 not explicitly implementing a property from an interface. Use the
11471 correct name also for those properties (the same CSC uses,
11472 although that is really not needed).
11474 (Property.Emit): Do not emit attributes for explicitly implemented
11475 properties, as there is no TypeBuilder.
11477 (Indexer.Emit): ditto.
11479 Hiding then means that we do not really *implement* a pending
11480 implementation, which makes code fail.
11482 2002-06-22 Martin Baulig <martin@gnome.org>
11484 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
11485 the return value of Object.GetType(). [FIXME: we need to do this whenever
11486 we get a type back from the reflection library].
11488 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
11490 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
11492 2002-06-20 Miguel de Icaza <miguel@ximian.com>
11494 * attribute.cs: Return null if we can not look up the type.
11496 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
11497 the interface types found.
11499 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
11500 interface types found.
11502 * typemanager.cs (GetInterfaces): Make this routine returns alll
11503 the interfaces and work around the lame differences between
11504 System.Type and System.Reflection.Emit.TypeBuilder in the results
11505 result for GetInterfaces.
11507 (ExpandInterfaces): Given an array of interface types, expand and
11508 eliminate repeated ocurrences of an interface. This expands in
11509 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
11512 2002-06-21 Martin Baulig <martin@gnome.org>
11514 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
11517 2002-06-21 Martin Baulig <martin@gnome.org>
11519 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
11520 and called with one of the core types, return the corresponding typebuilder for
11523 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
11526 2002-06-21 Martin Baulig <martin@gnome.org>
11528 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
11529 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
11530 (Expression.ConvertReferenceExplicit): Likewise.
11532 * expression.cs (ElementAccess.DoResolve): Likewise.
11533 (ElementAccess.DoResolveLValue): Likewise.
11535 2002-06-10 Martin Baulig <martin@gnome.org>
11537 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
11538 add the "value" parameter to the parameter list.
11540 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
11543 2002-06-19 Miguel de Icaza <miguel@ximian.com>
11545 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
11546 the argument to an int, uint, long or ulong, per the spec. Also
11547 catch negative constants in array creation.
11549 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
11551 * class.cs: do not allow the same interface to appear twice in
11552 the definition list.
11554 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
11556 * ecore.cs: don't use ldlen with System.Array.
11558 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
11560 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
11562 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
11564 * modifiers.cs: produce correct field attributes for protected
11565 internal. Easy fix so miguel can work on ther harder stuff:-)
11567 2002-06-18 Miguel de Icaza <miguel@ximian.com>
11569 * pending.cs: New file. Move the code from class.cs here.
11570 Support clearning the pending flag for all methods (when not doing
11571 explicit interface implementation).
11573 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
11575 * rootcontext.cs: added a couple more types needed to bootstrap.
11577 2002-06-17 Miguel de Icaza <miguel@ximian.com>
11579 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
11580 constructor in the type, instead of any constructor in the type
11581 hierarchy. Thanks to Paolo for finding this bug (it showed up as
11582 a bug in the Mono runtime when applying the params attribute).
11584 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
11585 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
11587 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
11589 * expression.cs (Unary.ResolveOperator): Use TypeManager
11590 to resolve the type.
11592 2002-06-13 Ravi Pratap <ravi@ximian.com>
11594 * cs-parser.jay (enum_member_declaration): Pass in the attributes
11597 * enum.cs (AddEnumMember): Add support to store the attributes associated
11598 with each member too.
11600 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
11601 field builders too - this takes care of the enum member case.
11603 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
11605 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
11606 address-of operator on both value types and pointers.
11608 2002-06-10 Martin Baulig <martin@gnome.org>
11610 * interface.cs (Interface.PopulateIndexer): Add the indexer's
11611 PropertyBuilder to the `property_builders' list.
11613 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
11614 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
11615 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
11616 find any indexers which are inherited from an interface.
11618 2002-06-09 Martin Baulig <martin@gnome.org>
11620 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
11621 the same type as the constant if necessary. There's also a test-130.cs
11624 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
11626 * typemanager.cs (TypeManager.ChangeType): Previously known as
11627 Enum.ChangeEnumType().
11629 2002-06-09 Martin Baulig <martin@gnome.org>
11631 * expression.cs (Cast.TryReduce): Added support for consts.
11633 2002-06-08 Ravi Pratap <ravi@ximian.com>
11635 * class.cs (Accessor): Hold attributes information so we can pass
11638 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
11639 Modify to pass in attributes attached to the methods.
11641 (add_accessor_declaration, remove_accessor_declaration): Ditto.
11643 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
11644 to handle the Accessor kind :-)
11646 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
11648 2002-06-08 Martin Baulig <martin@gnome.org>
11650 * expression.cs (Unary.TryReduceNegative): Added support for
11653 2002-06-08 Martin Baulig <martin@gnome.org>
11655 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
11656 name can't be found in the `defined_names' - the caller will do a
11657 MemberLookup in this case and thus find methods in System.Enum
11658 such as Enum.IsDefined().
11660 2002-06-08 Martin Baulig <martin@gnome.org>
11662 * enum.cs (Enum.ChangeEnumType): This is a custom version of
11663 Convert.ChangeType() which works with TypeBuilder created types.
11664 (Enum.LookupEnumValue, Enum.Define): Use it here.
11666 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
11667 `TypeBuilder.BaseType != null' check.
11668 (TypeContainer.FindMembers): Only lookup parent members if we
11669 actually have a parent.
11670 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
11671 (ConstructorInitializer.Resolve): Likewise.
11673 * interface.cs (Interface.FindMembers): Added
11674 `TypeBuilder.BaseType != null' check.
11676 * rootcontext.cs (RootContext.ResolveCore): Added
11677 "System.Runtime.CompilerServices.IndexerNameAttribute" to
11678 classes_second_stage.
11680 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
11681 debug_type and trace_type when compiling with --nostdlib.
11683 2002-06-07 Martin Baulig <martin@gnome.org>
11685 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
11686 (AddField): Set it to true when adding a non-static field.
11687 (DefineType): Use `have_nonstatic_fields' to find out whether we
11688 have non-static fields, not `Fields != null'.
11690 2002-06-02 Miguel de Icaza <miguel@ximian.com>
11692 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
11693 dereferencing a null on the static-field code path)
11695 2002-05-30 Martin Baulig <martin@gnome.org>
11697 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
11698 to take command line arguments. Use reflection to call the new
11699 custom `Initialize' function on the symbol writer and pass it the
11700 command line arguments.
11702 * driver.cs (--debug-args): New command line argument to pass command
11703 line arguments to the symbol writer.
11705 2002-05-28 Miguel de Icaza <miguel@ximian.com>
11707 * assign.cs (DoResolve): Forgot to do the implicit conversion to
11708 the target type for indexers and properties. Thanks to Joe for
11711 2002-05-27 Miguel de Icaza <miguel@ximian.com>
11713 * typemanager.cs (MethodFlags): returns the method flags
11714 (Obsolete/ShouldIgnore) that control warning emission and whether
11715 the invocation should be made, or ignored.
11717 * expression.cs (Invocation.Emit): Remove previous hack, we should
11718 not do this on matching a base type, we should do this based on an attribute
11720 Only emit calls to System.Diagnostics.Debug and
11721 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
11722 on the command line.
11724 * rootcontext.cs: Global settings for tracing and debugging.
11726 * cs-tokenizer.cs (define): New utility function to track
11727 defines. Set the global settings for TRACE and DEBUG if found.
11729 2002-05-25 Ravi Pratap <ravi@ximian.com>
11731 * interface.cs (Populate*): Pass in the TypeContainer as well as
11732 the DeclSpace as parameters so that we can create EmitContexts and
11733 then use that to apply attributes etc.
11735 (PopulateMethod, PopulateEvent, PopulateProperty)
11736 (PopulateIndexer): Apply attributes everywhere.
11738 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
11741 (ApplyAttributes): Update accordingly.
11743 We now apply interface attributes for all members too.
11745 2002-05-26 Miguel de Icaza <miguel@ximian.com>
11747 * class.cs (Indexer.Define); Correctly check if we are explicit
11748 implementation (instead of checking the Name for a ".", we
11749 directly look up if the InterfaceType was specified).
11751 Delay the creation of the PropertyBuilder.
11753 Only create the PropertyBuilder if we are not an explicit
11754 interface implementation. This means that explicit interface
11755 implementation members do not participate in regular function
11756 lookups, and hence fixes another major ambiguity problem in
11757 overload resolution (that was the visible effect).
11759 (DefineMethod): Return whether we are doing an interface
11762 * typemanager.cs: Temporary hack until we get attributes in
11763 interfaces (Ravi is working on that) and we get IndexerName
11764 support in interfaces.
11766 * interface.cs: Register the indexers as properties.
11768 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
11769 warning, I have verified that this is a bug in the .NET runtime
11770 (JavaScript suffers of the same problem).
11772 * typemanager.cs (MemberLookup): When looking up members for
11773 interfaces, the parent of an interface is the implicit
11774 System.Object (so we succeed in searches of Object methods in an
11775 interface method invocation. Example: IEnumerable x; x.ToString
11778 2002-05-25 Miguel de Icaza <miguel@ximian.com>
11780 * class.cs (Event): Events should also register if they do
11781 implement the methods that an interface requires.
11783 * typemanager.cs (MemberLookup); use the new GetInterfaces
11786 (GetInterfaces): The code used to lookup interfaces for a type is
11787 used in more than one place, factor it here.
11789 * driver.cs: Track the errors at the bottom of the file, we kept
11792 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
11793 instance if the method we are calling is static!
11795 2002-05-24 Miguel de Icaza <miguel@ximian.com>
11797 * attribute.cs (ApplyAttributes): Make this function filter out
11798 the IndexerName attribute (as that attribute in reality is never
11799 applied) and return the string constant for the IndexerName
11802 * class.cs (TypeContainer.Emit): Validate that all the indexers
11803 have the same IndexerName attribute, and if so, set the
11804 DefaultName attribute on the class.
11806 * typemanager.cs: The return value might contain other stuff (not
11807 only methods). For instance, consider a method with an "Item"
11808 property and an Item method.
11810 * class.cs: If there is a problem with the parameter types,
11813 2002-05-24 Ravi Pratap <ravi@ximian.com>
11815 * ecore.cs (ImplicitConversionExists): Wrapper function which also
11816 looks at user defined conversion after making a call to
11817 StandardConversionExists - we need this for overload resolution.
11819 * expression.cs : Update accordingly the various method calls.
11821 This fixes 2 bugs filed against implicit user defined conversions
11823 2002-05-22 Miguel de Icaza <miguel@ximian.com>
11825 * statement.cs: Track the result of the assignment.
11827 2002-05-21 Miguel de Icaza <miguel@ximian.com>
11829 * expression.cs (MemberAccess): Improved error reporting for
11830 inaccessible members.
11832 2002-05-22 Martin Baulig <martin@gnome.org>
11834 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
11835 itself with debugging support.
11837 2002-05-22 Martin Baulig <martin@gnome.org>
11839 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
11840 Removed, this isn't needed anymore.
11842 2002-05-20 Martin Baulig <martin@gnome.org>
11844 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
11845 be underlying type for an enum.
11847 2002-05-20 Miguel de Icaza <miguel@ximian.com>
11849 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
11850 that splits out the loading of just the core types.
11852 * rootcontext.cs (ResolveCore): Split the struct resolution in
11853 two, so we can load the enumeration underlying types before any
11856 * expression.cs (Is): Bandaid until we fix properly Switch (see
11857 bug #24985 for details).
11859 * typemanager.cs (ImplementsInterface): The hashtable will contain
11860 a null if there are no interfaces implemented.
11862 2002-05-18 Miguel de Icaza <miguel@ximian.com>
11864 * cs-parser.jay (indexer_declarator): It is fine to have array
11867 2002-05-17 Miguel de Icaza <miguel@ximian.com>
11869 * typemanager.cs: (RegisterBuilder): New function used to register
11870 TypeBuilders that implement interfaces. Since
11871 TypeBuilder.GetInterfaces (as usual) does not work with lame
11873 (AddUserType): register interfaces.
11875 (ImplementsInterface): Use the builder_to_ifaces hash if we are
11876 dealing with TypeBuilder. Also, arrays are showing up as
11877 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
11878 methods can not be invoked on them!
11880 * ecore.cs (ExplicitReferenceConversionExists): Made public.
11881 (ImplicitReferenceConversionExists): Split out from
11882 StandardConversionExists.
11884 * expression.cs (As): We were only implementing one of the three
11885 cases for the as operator. We now implement them all.
11886 (Is): Implement the various other cases for Is as well.
11888 * typemanager.cs (CACHE): New define used to control if we want or
11889 not the FindMembers cache. Seems to have a negative impact on
11890 performance currently
11892 (MemberLookup): Nested types have full acess to
11893 enclosing type members
11895 Remove code that coped with instance/static returns for events, we
11896 now catch this in RealFindMembers.
11898 (RealFindMembers): only perform static lookup if the instance
11899 lookup did not return a type or an event.
11901 2002-05-17 Miguel de Icaza <miguel@ximian.com>
11903 * assign.cs (CompoundAssign): We pass more semantic information
11904 now to Compound Assignments than we did before: now we have all
11905 the information at hand, and now we resolve the target *before* we
11906 do the expression expansion, which allows the "CacheValue" method
11907 to have the effect we intended (before, a [x] += 1 would generate
11908 two differen ArrayAccess expressions from the ElementAccess,
11909 during the resolution process).
11911 (CompoundAssign.DoResolve): Resolve target and original_source here.
11913 2002-05-16 Miguel de Icaza <miguel@ximian.com>
11915 * expression.cs (ArrayAccess): dropped debugging information.
11917 * typemanager.cs: Small bug fix: I was always returning i_members,
11918 instead of one of i_members or s_members (depending on which had
11921 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
11922 method is invoked before any code generation takes place, and it
11923 is a mechanism to inform that the expression will be invoked more
11924 than once, and that the method should use temporary values to
11925 avoid having side effects
11927 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
11929 * ecore.cs (Expression.CacheTemporaries): Provide empty default
11932 * expression.cs (Indirection, ArrayAccess): Add support for
11933 CacheTemporaries in these two bad boys.
11935 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
11936 ldobj or ldind_ref.
11937 (StoreFromPtr): Handle stobj as well.
11939 * expression.cs (UnaryMutator): Share more code.
11941 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
11942 down: I was not tracking the Filter function as well, which
11943 was affecting the results of the cache.
11945 2002-05-15 Miguel de Icaza <miguel@ximian.com>
11947 * attribute.cs: Remove the hack to handle the CharSet property on
11950 2002-05-14 Miguel de Icaza <miguel@ximian.com>
11952 * attribute.cs (DoResolve): More uglyness, we now only try to
11953 resolve the attribute partially, to extract the CharSet
11954 information (only if we are a StructLayout attribute). Otherwise
11956 (GetExtraTypeInfo): Add some code to conditionally kill in the
11957 future this. I am more and more convinced that the .NET
11958 framework has special code to handle the attribute setting on
11961 * expression.cs (IsParamsMethodApplicable): Revert my previous
11962 foreach change here, it was wrong.
11964 2002-05-13 Miguel de Icaza <miguel@ximian.com>
11966 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
11967 (pp_expr): do not abort on unknown input, just return.
11968 (eval): abort if there are pending chars.
11970 * attribute.cs (Attribute.Resolve): Positional parameters are
11971 optional. Deal with that case.
11973 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
11974 the Ansi/Unicode/Auto information for the type.
11976 (TypeContainer.DefineType): instantiate the EmitContext here, as
11977 we will be using it during the type definition (to resolve
11978 attributes) and during the emit phase.
11980 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
11981 to pull type information out of the attributes
11983 (Attribute.Resolve): track the constructor builder, and allow for
11984 multiple invocations (structs and classes will use this).
11986 * ecore.cs (MemberLookupFinal): new version with all the
11987 parameters customizable.
11989 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
11990 constructors. Return if the result value is null (as the error
11991 would have been flagged already by MemberLookupFinal)
11993 Do not allow instances of abstract classes or interfaces to be
11996 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
11997 We have to compare the assembly property here when dealing with
11998 FamANDAssem and Assembly access modifiers, because we might be
11999 creating an assembly from *modules* (that means that we are not
12000 getting TypeBuilders for types defined in other modules that are
12001 part of this assembly).
12003 (Method.Emit): If the method is marked abstract and has a body,
12006 (TypeContainer.DefineMembers): If both the defined member and the
12007 parent name match are methods, then do not emit any warnings: let
12008 the Method.Define routine take care of flagging warnings. But if
12009 there is a mismatch (method overrides something else, or method is
12010 overriwritten by something, then emit warning).
12012 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
12013 set to null, this means `do not check for the return type on the
12016 (Method.Define): set the return type for the method signature to
12017 null, so that we get methods with the same name and parameters and
12018 different return types. This is used to flag warning 114 (you are
12019 hiding a method, and you probably want to use the new/override
12022 * typemanager.cs (MemberLookup): Implemented proper access
12023 control, closing a long standing set of bug reports. The problem
12024 was that the Framework only has two bits: Public and NonPublic,
12025 and NonPublic includes private and protected methods, but we need
12026 to enforce the FamANDAssem, FamOrAssem and Family.
12028 2002-05-11 Miguel de Icaza <miguel@ximian.com>
12030 * statement.cs (GotoCase): Return true: Ammounts to giving up
12031 knowledge on whether we return or not, and letting the other case
12032 be responsible for it.
12034 2002-05-10 Miguel de Icaza <miguel@ximian.com>
12036 * driver.cs: Do not load directories for each file processed, only
12037 do it if there is a pattern.
12039 * ecore.cs: Report readonly assigns here as well, as we might have
12040 been resolved only by MemberAccess.
12042 (SimpleName.SimpleNameResolve): Also be useful for LValue
12043 resolution. We need this to propagate assign to local readonly variables
12045 * typemanager.cs: Use a ptrhashtable for the criteria, because we
12046 do not want to reuse potential criteria memory.
12048 * class.cs (MyEventBuilder): Set reflected_type;
12050 * ecore.cs (Constantify): Added support for constifying bools.
12052 (RootContext.LookupType): Added a cache for values looked up in
12053 the declaration space.
12055 * typemanager.cs (FindMembers): Now is a front-end to
12056 RealFindMembers, and provides a two-level hashtable-based cache to
12059 15% performance improvement: from 22.5 to 19.2 seconds.
12061 * expression.cs (IsParamsMethodApplicable): use foreach.
12062 (Invocation.DoResolve): ditto.
12063 (New.DoResolve): ditto.
12064 (ArrayCreation.DoResolve): ditto.
12066 * ecore.cs (FindMostEncompassingType): use foreach.
12068 * delegate.cs (NewDelegate.DoResolve): Use foreach
12070 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
12071 (RemoveMethods): use foreach.
12073 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
12074 nested foreach statements instead of for, and also break out of
12075 the inner loop once a match is found.
12077 (Invocation.OverloadResolve): Use foreach, simplify the code.
12079 2002-05-08 Miguel de Icaza <miguel@ximian.com>
12081 * cfold.cs (BinaryFold): During an enumeration evaluation context,
12082 we actually unwrap the expression to allow for extra information
12085 * expression.cs: Use Shr_Un on unsigned operations.
12087 2002-05-08 Ravi Pratap <ravi@ximian.com>
12089 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
12090 applicable operators was not being considered correctly. This closes
12091 the bug Miguel reported.
12093 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
12095 * attribute.cs: check that the type derives from System.Attribute
12096 and report the correct error in that case (moved the duplicate code to
12097 its own method, too).
12099 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
12101 * attribute.cs: lookup attribute type name as the spec says: first the
12102 bare attribute name and then name + "Attribute" (nant compiles with
12103 mcs after this fix).
12105 2002-05-07 Miguel de Icaza <miguel@ximian.com>
12107 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
12108 Because of the way we parse things, we should try to see if a
12109 UIntConstant can fit in an integer.
12111 2002-05-07 Ravi Pratap <ravi@ximian.com>
12113 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
12114 when we are in an explicit context.
12116 (ConvertReferenceExplicit): When converting from Iface type S to Class
12117 T make sure the rules are implemented as an OR.
12119 * parameter.cs (ParameterType): Make it a property for now although the
12120 purpose really isn't anything immediate.
12122 * expression.cs (Is*Applicable): Do better checking on the parameter type
12123 of a ref/out parameter. The ones from the system assemblies are already
12124 marked with the correct type so we don't need to do any correction.
12126 * ecore.cs (StandardConversionExists): Conversion from Interface types to
12127 the object type is standard too so include that.
12129 2002-05-06 Miguel de Icaza <miguel@ximian.com>
12131 * ecore.cs (StandardConversionExists): Augment with missing code:
12132 deal with IntConstant, LongConstants and Enumerations.
12134 * assign.cs: Report the error, instead of failing silently
12136 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
12137 typecontainer that they are declared, because the
12138 typecontainer/namespace will have the list of using clauses that
12139 need to be applied.
12141 Assembly Attributes were escaping the normal registration
12144 (EmitCode): Apply attributes within an EmitContext that represents
12145 the container they were declared on.
12147 * cs-parser.jay: Track bases for structs. How did I get this wrong?
12149 2002-05-06 Ravi Pratap <ravi@ximian.com>
12151 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
12152 Revamp completely - make much cleaner as we now operate only
12155 (FindMostSpecificSource, FindMostSpecificTarget): New methods
12156 to implement the logic detailed in the spec more correctly.
12158 (UserDefinedConversion): Update accordingly.
12160 2002-05-06 Miguel de Icaza <miguel@ximian.com>
12162 * statement.cs: Return flow analysis information up.
12164 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
12167 (token): Do not consume an extra character before calling
12170 2002-05-06 Piers Haken <piersh@friskit.com>
12172 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
12174 2002-05-06 Miguel de Icaza <miguel@ximian.com>
12176 * class.cs (Constructor.Emit): Set the IsStatic flag in the
12177 EmitContext during the instance constructor initializer
12178 resolution, to stop access to instance variables.
12180 This is mandated by the spec, last paragraph of the `constructor
12181 initializers' section.
12183 2002-05-05 Miguel de Icaza <miguel@ximian.com>
12185 * cs-parser.jay, class.cs (Accessor): new class used to represent
12186 an accessor (get or set). In the past we used `null' to represent
12187 a missing accessor. But this is ambiguous because there was no
12188 way to tell in abstract indexers/properties if one of them was
12191 Now there is a way of addressing that.
12193 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
12194 instead of FindMembers.
12196 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
12197 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
12199 * attribute.cs: Treat indexers and properties as the same in terms
12200 of applying attributes
12202 * ecore.cs (FindMostEncompassedType): Use statically initialized
12203 EmptyExpressions()s like we do elsewhere to avoid creating useless
12204 objects (and we take this out of the tight loop).
12206 (GetConversionOperators): Move the code to extract the actual
12207 operators to a separate routine to clean things up.
12209 2002-05-04 Miguel de Icaza <miguel@ximian.com>
12211 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
12212 events are always registered FieldBuilders.
12214 * class.cs (FieldBase): New class shared by Fields
12216 * delegate.cs: If we are a toplevel delegate, use our full name.
12217 If we are a nested delegate, then only use our tail name.
12219 2002-05-02 Ravi Pratap <ravi@ximian.com>
12221 * expression.cs (IsApplicable): Ensure that we add the "&" to
12222 ref/out types before comparing it with the type of the argument.
12224 (IsParamsMethodApplicable): Ditto.
12226 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
12229 * delegate.cs : Handle the case when we have more than one applicable
12230 method. Flag an error only when we finish checking all.
12232 2002-05-02 Miguel de Icaza <miguel@ximian.com>
12234 * expression.cs: Add support for boolean static initializers.
12236 2002-05-01 Miguel de Icaza <miguel@ximian.com>
12238 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
12240 * parameter.cs (ComputeParameterTypes,
12241 ComputeAndDefineParameterTypes): Better error handling: now we
12242 clear the `types' cache if we fail during any of the type lookups.
12243 We also return the status code correctly to our caller
12245 * delegate.cs: If we fail to define a delegate, abort the extra
12248 * expression.cs (Binary.ResolveOperator): for
12249 operator==(object,object) and operator !=(object, object) we also
12250 have to verify that there is an implicit conversion from one to
12253 (ArrayAccess.DoResolve): Array Access can operate on
12256 2002-04-30 Miguel de Icaza <miguel@ximian.com>
12258 * assign.cs (CompoundAssign): A new class used as a "flag" that
12259 the assignment actually is happening as part of a compound
12260 assignment operator.
12262 During compound assignment, a few new rules exist to enable things
12269 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
12270 to the type of x) if y is implicitly convertible to the type of x,
12271 and the operator is a builtin operator and the return type of the
12272 operator is explicitly convertible to the type of x.
12274 * rootcontext.cs: Reset warning level to 2. 4 catches various
12275 "interesting" features in mcs, we must clean this up at some
12276 point, but currently am trying to kill other bugs ;-)
12278 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
12279 in container classes as well.
12281 * expression.cs (Binary.ResolveOperator): Handle string case
12282 before anything else (as operator overloading does emit an error
12283 before doing anything else).
12285 This code could go away when we move to a table driven model, but
12286 i could not come up with a good plan last night.
12288 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
12290 * typemanager.cs (CSharpName): reimplementation using regex.
12291 * class.cs: added null check for fields in Emit
12292 * rootcontext.cs: set warninglevel to 4
12294 2002-04-29 Miguel de Icaza <miguel@ximian.com>
12296 * typemanager.cs (CSharpName): reimplemented with Lupus
12299 2002-04-28 Miguel de Icaza <miguel@ximian.com>
12301 * statement.cs (If): correclty implement Resolve, because we were
12302 not catching sem errors in there. The same process is needed
12304 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
12307 (Statement.Warning_DeadCodeFound): Factorize code.
12308 (While): Report dead code here too.
12310 (Statement): Added Resolve virtual method to allow
12311 for resolution split from the emit code.
12313 2002-04-26 Miguel de Icaza <miguel@ximian.com>
12315 * statement.cs (EmitBoolExpression): No longer try to resolve the
12317 (MakeBoolean): New utility function that resolve, implicitly
12318 converts to boolean and tags the expression.
12321 (If, Do): Implement dead code elimination.
12322 (While): Implement loop inversion
12324 (Do, While, For, If): Resolve the expression prior to calling our
12327 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
12330 - added method Report28 (warning: program has more than one entry point)
12331 - added method IsEntryPoint, implements paragraph 10.1 of the spec
12332 - modified method Method.Define, the part at the end of the method
12334 * rootcontext.cs: added static public Location EntryPointLocation;
12336 * ../errors/cs0028.cs : Add test case for the above warning.
12339 - modified method CSharpName to allow arrays of primitive type to
12340 be printed nicely (e.g. instead of System.Int32[][] it now prints
12342 - added method CSharpSignature: returns the signature of a method
12343 in string format to be used in reporting errors, warnings, etc.
12345 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
12348 2002-04-26 Ravi Pratap <ravi@ximian.com>
12350 * delegate.cs (Define): Fix extremely silly bug where I was
12351 setting the type of the 'object' parameter of the BeginInvoke
12352 method to System.IAsyncResult instead of System.Object ;-)
12354 2002-04-26 Miguel de Icaza <miguel@ximian.com>
12356 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
12359 (Constructor.Emit): return if we fail to initialize the
12360 constructor. Another door closed!
12362 * expression.cs (New.DoResolve): Improve error message (from -6 to
12363 1501). Use DeclaredOnly lookup to find the exact constructor.
12365 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
12366 loop. This is useful.
12368 * cs-parser.jay: Adjust the default parameters so that destructors
12369 have the proper signature.
12371 2002-04-26 Martin Baulig <martin@gnome.org>
12373 * driver.cs (LoadAssembly): If `assembly' contains any characters
12374 which are only valid in path names and not in assembly names
12375 (currently slash, backslash and point), use Assembly.LoadFrom ()
12376 instead of Assembly.Load () on the `assembly' (before iteration
12377 over the link_paths).
12379 2002-04-26 Martin Baulig <martin@gnome.org>
12381 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
12383 2002-04-25 Miguel de Icaza <miguel@ximian.com>
12385 * class.cs (Property): use the new typemanager.MemberLookup
12387 (TypeContainer.MemberLookup): Implement using the
12388 TypeManager.MemberLookup now.
12390 * typemanager.cs: Make MemberLookup a function of the TypeManager,
12391 and return MemberInfos, so that these can be used without an
12392 EmitContext (what we had before).
12394 2002-04-24 Miguel de Icaza <miguel@ximian.com>
12396 * expression.cs: Fix the case where the argument to params if the
12397 type of the params. I omitted handling this before. Fixed
12399 2002-04-22 Miguel de Icaza <miguel@ximian.com>
12401 * driver.cs: Call BootCorlib_PopulateCoreType
12403 * class.cs (Property.CheckBase): Check for properties only, not
12406 * interface.cs: Temporary hack: try/catch around the
12407 CustomAttributeBuilder, because I am getting an exception that I
12410 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
12411 types whose definitions are required to be there (attributes are
12412 defined before standard types).
12414 Compute definitions as we boot the various types, as they are used
12415 immediately (value_type class will need object_type, but if we do
12416 not initialize object_type, we will pass a null, which will let
12417 the runtime pick the System.Object from the existing corlib, which
12418 is not what we want).
12420 2002-04-22 Patrik Torstensson <totte@labs2.com>
12422 * cs-tokenizer.cs: fixed a number of trim() issues.
12424 2002-04-22 Ravi Pratap <ravi@ximian.com>
12426 * expression.cs (Argument.Type): Ensure that we return the correct
12427 type when we have out or ref parameters [in which case we
12430 2002-04-22 Miguel de Icaza <miguel@ximian.com>
12432 * class.cs (Property, Indexer): Allow extern modifier in there.
12434 * typemanager.cs (InitBaseTypes): Initializes object_type and
12435 value_type, since those will be used early on during the bootstrap
12436 process to compile corlib.
12438 (InitCoreTypes): Move code from here to InitBaseTypes.
12440 2002-04-21 Miguel de Icaza <miguel@ximian.com>
12442 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
12443 single-dimension arrays as using the ldlen opcode.
12445 Daniel Lewis discovered this optimization.
12447 * typemanager.cs: Add signature for System.Array::get_Length
12449 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
12451 * statement.cs: report the error when the foreach does not apply to an
12452 array nor a collection.
12454 2002-04-19 Miguel de Icaza <miguel@ximian.com>
12456 * expression.cs: Add implicit conversions to the operator ~.
12458 * constant.cs (DecimalConstant.Emit): Emit decimal value.
12460 * typemanager.cs: Locate the decimal constructor.
12462 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
12464 * attribute.cs: use the new property of TypeOf.
12465 * expression.cs: added 'get' property around typearg.
12467 These changes fix a build breaker reported by NickD. Is this the
12468 correct way to fix? If not, please, revert my changes and make it
12471 2002-04-17 Miguel de Icaza <miguel@ximian.com>
12473 * attribute.cs: Add support for typeof in attribute invocations.
12474 I am not sure that this is right though.
12476 2002-04-14 Duncan Mak <duncan@ximian.com>
12478 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
12479 Binary.Operator.Division case.
12481 2002-04-13 Ravi Pratap <ravi@ximian.com>
12483 * class.cs (DefineType): Ensure that we do a proper check on
12484 attribute types and also register it with the TypeManager.
12486 (TypeContainer.Targets): The default for attribute types is
12487 AttributeTargets.All.
12489 * attribute.cs (ApplyAttributes): Registering the attribute type
12490 is done elsewhere, not when we discover we have a Usage attribute.
12492 2002-04-12 Ravi Pratap <ravi@ximian.com>
12494 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
12495 and get rid of is_delegate parameter.
12497 * everywhere : update.
12499 2002-04-12 Ravi Pratap <ravi@ximian.com>
12501 * cs-parser.jay (compilation_unit): Revamp completely to use
12502 some new ideas that I got from Rhys' grammar to solve the problems
12503 with assembly level attributes.
12505 (outer_declaration): New grammar production.
12507 (attribute_sections): Add.
12509 (opt_attributes): Base on attribute_sections
12511 (namespace_declaration): Allow opt_attributes to tackle the case
12512 when we have assembly level attributes - we are clever in this
12515 * attribute.cs (ApplyAttributes): Do not worry about assembly
12516 attributes in the non-global context.
12518 * rootcontext.cs (AddGlobalAttributes): Go back to using this
12519 instead of SetGlobalAttributes.
12521 * class.cs, rootcontext.cs : Ensure we define and generate
12522 attribute types before anything else.
12524 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
12525 and flag the new error -20 for the case when the attribute type
12526 does not have valid targets specified. csc does not catch this.
12528 * ../errors/errors.txt : update for error # -20
12530 2002-04-11 Ravi Pratap <ravi@ximian.com>
12532 * support.cs (InternalParameters.ParameterModifier): Do some null
12533 checking and return sane values.
12535 * class.cs (Method.Define): If we are a PInvoke method, ensure
12536 that we are static and extern. Report error # 601
12538 * ../errors/cs0601.cs : Add test case for the above error.
12540 2002-04-07 Ravi Pratap <ravi@ximian.com>
12542 * rootcontext.cs (attribute_types): We need to keep type of
12543 all attribute types separately and emit code for them first.
12545 (RegisterAttribute) : Implement.
12547 * class.cs (DefineType): Check if the current Type is a custom
12548 attribute type and register it accordingly.
12550 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
12551 adding the first attribute twice and rename to
12553 (SetGlobalAttributes): this.
12555 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
12558 * attribute.cs (ApplyAttributes): Take an additional argument telling us
12559 if we are processing global arguments. Hmm, I am unsure of this.
12561 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
12563 * expression.cs: added static array of strings to avoid calling
12564 Enum.ToString () for Operator in Binary. Significant recover of
12567 2002-04-10 Miguel de Icaza <miguel@ximian.com>
12569 * class.cs (FindMembers): Allow the Builders of the various
12570 members to be null. If they are skip them. This only happens
12571 during the PInvoke declaration.
12573 2002-04-09 Miguel de Icaza <miguel@ximian.com>
12575 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
12576 failure, so we do not keep going afterwards.
12578 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
12579 wanted to pass `false' as the `is_delegate' argument. If this is
12580 the case, why not use delegate_type == null to mean `is_delegate =
12581 false' and anything else as is_delegate = true.
12583 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
12585 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
12586 code for the section, not the beginning of the tests.
12588 2002-04-08 Miguel de Icaza <miguel@ximian.com>
12590 * cfold.cs: Handle operator + (Enum x, Underlying x)
12592 * expression.cs (Binary): same. Warn about errors where we have
12593 Enum/Enum in operator + as well.
12595 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
12598 - added support for switch(bool)
12599 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
12600 - add TableSwitchEmit() to handle table-based switch statements
12602 2002-04-05 Ravi Pratap <ravi@ximian.com>
12604 * expression.cs (Invocation.OverloadResolve): Factor out code which
12605 does parameter compatibility checking with arguments so that we can
12606 re-use the code even from Delegate.VerifyApplicability
12608 (VerifyArgumentsCompat): Move above code here.
12610 * delegate.cs (VerifyApplicability): Get rid of duplicate code
12611 and instead make a call to the above method.
12613 2002-03-31 Ravi Pratap <ravi@ximian.com>
12615 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
12616 We use it to keep track of classes which are attribute types.
12618 2002-04-02 Miguel de Icaza <miguel@ximian.com>
12620 * delegate.cs (Delegate.Define): Correctly define the types in the
12621 presence of fixed and array parameters.
12623 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
12626 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
12627 include NonPublic after the first iteration.
12629 * class.cs (Indexer.CheckBase): Only check if both parents are
12632 * cs-parser.jay (accessor_body): If empty, set to null.
12634 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
12635 same code path here to resolve constants names that we did have in
12636 MemberAccess.DoResolve. There is too much code duplicated here.
12638 2002-04-01 Miguel de Icaza <miguel@ximian.com>
12640 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
12642 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
12645 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
12646 tokens, numbers and strings.
12648 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
12651 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
12652 asyncronous parameters and the regular parameters.
12654 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
12655 specify the target directory.
12657 * expression.cs: (This.DoResolve): Simplify
12658 (As.Emit): Optimize, do not generate IsInst if the expression is
12659 always of the given type.
12661 (Is.DoResolve): Bug fix, we were reporting both always/never for
12664 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
12665 creating too many unnecessary arrays.
12667 2002-03-31 Miguel de Icaza <miguel@ximian.com>
12669 * class.cs (EmitFieldInitializer): Use Assign expression to assign
12670 fields instead of rolling our own initializer. Takes care of all
12671 implicit conversions, and drops unnecessary static checks/argument.
12673 2002-03-31 Dick Porter <dick@ximian.com>
12675 * driver.cs: use the GetDirectories() return values properly, and
12676 use "/" as path separator.
12678 2002-03-30 Miguel de Icaza <miguel@ximian.com>
12680 * expression.cs (Unary): Optimize - - expr into expr.
12681 (Binary): Optimize a + (-b) into a -b.
12683 * codegen.cs (CodeGen): Made all methods static.
12685 2002-03-29 Miguel de Icaza <miguel@ximian.com>
12689 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
12690 TypeBuilder property.
12692 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
12695 * tree.cs: Removed the various RecordXXXX, and replaced with a
12696 single RecordDecl. Removed all the accessor methods, and just
12697 left a single access point Type
12699 * enum.cs: Rename DefineEnum to DefineType.
12701 * decl.cs: New abstract method `DefineType' used to unify the
12702 Defines for Enumerations, Interfaces, TypeContainers and
12705 (FindType): Moved LookupInterfaceOrClass here. Moved the
12706 LookupBaseClasses method that used to live in class.cs and
12707 interface.cs here, and renamed to FindType.
12709 * delegate.cs: Implement DefineType. Take advantage of the
12710 refactored pattern for locating the parent builder without taking
12711 the parent_builder argument (which we know does not work if we are
12712 nested, and triggering a toplevel definition).
12714 2002-03-28 Miguel de Icaza <miguel@ximian.com>
12716 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
12717 accessibility of a member has changed during override and report
12720 * class.cs (Method.Define, Property.Define): Only complain on
12721 overrides if the method is private, any other accessibility is
12722 fine (and since we just checked the permission is the same, we are
12725 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
12726 and elif are processed always. The other pre-processing
12727 directives are only processed if we are "taking" the path
12729 2002-03-29 Martin Baulig <martin@gnome.org>
12731 * class.cs (Method.Emit): Only emit symbolic debugging info if the
12732 current location is not Null.
12734 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
12735 a separate method so we can profile it.
12737 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
12738 `span.Seconds' are just seconds, but no minutes or hours.
12739 (MainDriver): Profile the CodeGen.SaveSymbols calls.
12741 2002-03-28 Miguel de Icaza <miguel@ximian.com>
12743 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
12744 Remove the gratuitous set of Final:
12746 // If an interface implementation, then we can set Final.
12747 if (((flags & MethodAttributes.Abstract) == 0) &&
12748 implementing.DeclaringType.IsInterface)
12749 flags |= MethodAttributes.Final;
12751 I do not know what I was smoking when I used that.
12754 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
12755 step into fixing the name resolution issues for delegates and
12756 unifying the toplevel name resolution.
12758 2002-03-28 Martin Baulig <martin@gnome.org>
12760 * class.cs (Method.Emit): If we have a symbol writer, call its
12761 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
12762 tell it about the current method.
12764 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
12765 writer that we're going to emit the first byte of IL code for a new
12766 statement (a new source line).
12767 (EmitContext.EmitTopBlock): If we have a symbol writer, call
12768 EmitContext.Mark() before emitting any code.
12770 * location.cs (SymbolDocument): Return null when we're Null.
12772 * statement.cs (Statement): Moved the `Location loc' variable here.
12773 (Statement.EmitBoolExpression): If we have a symbol writer, call
12774 ec.Mark() before emitting any code to tell it that we're at the
12775 beginning of a new statement.
12776 (StatementExpression): Added `Location' argument to the constructor.
12777 (Block): Added public readonly variable `StartLocation' and public
12778 variable `EndLocation'. The latter is to be set using SetEndLocation().
12779 (Block): Added constructor which takes a start and end location.
12780 (Block.SetEndLocation): New method. This sets the end location.
12781 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
12782 local variables we create.
12783 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
12784 each statement and do also mark the begin and end of the block.
12786 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
12787 tell it the current lexer.Location, use Location.Null for the end of the
12789 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
12790 current block, set its end location using SetEndLocation().
12791 (statement_expression): StatementExpression constructor now takes the
12792 lexer.Location as additional argument.
12793 (for_statement, declare_local_variables): Likewise.
12794 (declare_local_variables): When creating a new implicit block, use the
12795 new Block constructor and pass it the lexer.Location.
12797 2002-03-28 Miguel de Icaza <miguel@ximian.com>
12799 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
12800 members also on the parent interfaces recursively.
12802 2002-03-27 Miguel de Icaza <miguel@ximian.com>
12804 * report.cs: Use new formats, since Gonzalo finished the missing
12807 * expression.cs (Binary.ResolveOperator): added missing operator|
12808 operator& and operator^ for bool/bool.
12810 * cs-parser.jay: CheckDef now takes a Location argument that is
12811 used to report errors more precisly (instead of reporting the end
12812 of a definition, we try to track something which is a lot closer
12813 to the source of the problem).
12815 * cs-tokenizer.cs: Track global token use, so we can properly flag
12816 the use of #define/#undef after the first token has been seen.
12818 Also, rename the reportXXXX to Error_DescriptiveName
12820 * decl.cs (DeclSpace.IsTopLevel): Move property here from
12821 TypeContainer, so that Enum and Interface can use this too.
12823 * class.cs (TypeContainer.LookupInterfaceOrClass,
12824 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
12825 `builder' argument. Typically this was used to pass the parent
12826 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
12829 The problem is that a nested class could trigger the definition of
12830 a toplevel class, and the builder would be obviously wrong in that
12833 So we drop this argument, and we compute dynamically the
12834 TypeBuilder/ModuleBuilder (the correct information was available
12835 to us anyways from DeclSpace.Parent)
12837 * interface.cs (Interface.DefineInterface): Drop builder
12838 parameter cleanup like class.cs
12840 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
12843 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
12846 (Try.Emit): Propagate the returns value from the statement.
12848 (Return.Emit): Even if we are leavning
12850 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
12852 * modifiers.cs: Fix the computation of MethodAttributes flags.
12854 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
12856 * driver.cs: allow compilation of files that start with '/'.
12857 Add a default case when checking the argument of --target.
12859 2002-03-25 Miguel de Icaza <miguel@ximian.com>
12861 * interface.cs: Implement the same search algorithm for types in
12862 the interface code.
12864 * delegate.cs: Do not allow multiple definition.
12866 * Recovered ChangeLog that got accidentally amputated
12868 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
12870 * rootcontext.cs: Load manually enum to allow core classes to
12871 contain enumerations.
12873 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
12874 Update to new static methods in TypeManager.
12876 * typemanager.cs (GetMethod, GetConstructor): Use our
12877 implementation of FindMembers to find the members, since during
12878 corlib compilation, the types are TypeBuilders and GetMethod and
12879 GetConstructor do not work.
12881 Make all methods in TypeManager static.
12883 (InitCodeHelpers): Split the functionality from
12884 the InitCodeTypes function.
12886 * driver.cs: Call InitCodeHelpers after we have populated the
12889 * cs-parser.jay (delegate_declaration): we did not used to compute
12890 the delegate name correctly for void delegates.
12892 2002-03-24 Miguel de Icaza <miguel@ximian.com>
12894 * rootcontext.cs (RootContext): Init the interface_resolve_order
12895 and type_container_resolve_order always.
12897 (ResolveCore, BootstrapCorlib_ResolveClass,
12898 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
12899 compiler when compiling with --nostdlib
12901 * class.cs (TypeContainer.DefineType): Check that our parent is
12902 not null. This test is most important when we are bootstraping
12905 * codegen.cs: Split out the symbol writing code.
12907 2002-03-25 Martin Baulig <martin@gnome.org>
12909 * driver.cs (-g): Made -g an alias for --debug.
12911 2002-03-24 Martin Baulig <martin@gnome.org>
12913 * codegen.cs (SymbolWriter): New public variable. Returns the
12914 current symbol writer.
12915 (CodeGen): Added `bool want_debugging_support' argument to the
12916 constructor. If true, tell the ModuleBuild that we want debugging
12917 support and ask it for the ISymbolWriter.
12918 (Save): If we have a symbol writer, call it's Close() method after
12919 saving the assembly.
12921 * driver.c (--debug): New command line argument to create a
12922 debugger information file.
12924 * location.cs (SymbolDocument): New public property. Returns an
12925 ISymbolDocumentWriter object for the current source file or null
12926 if we don't have a symbol writer.
12928 2002-03-21 Miguel de Icaza <miguel@ximian.com>
12930 * driver.cs (LoadAssembly): Correctly return when all the paths
12931 have been tried and not before.
12933 * statement.cs (Switch.Emit): return the actual coverage for this
12934 statement (returns/not-returns)
12936 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
12937 switch of the statement if we are the last switch section. That
12938 kills two problems: try/catch problems (we used to emit an empty
12939 nop at the end) and switch statements where all branches would
12942 2002-03-19 Miguel de Icaza <miguel@ximian.com>
12944 * driver.cs: Add default assemblies (the equivalent to the
12945 Microsoft CSC.RSP file)
12947 * cs-tokenizer.cs: When updating `cols and setting it to zero,
12948 also update tokens_seen and set it to false.
12950 * driver.cs: Implement --recurse for Mike.
12952 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
12953 correctly splitting out the paths.
12955 2002-03-18 Miguel de Icaza <miguel@ximian.com>
12957 * interface.cs (Interface.PopulateProperty): Instead of using
12958 `parent' as the declaration space for the set parameters, use
12961 * support.cs (InternalParameters): InternalParameters constructor
12962 takes a DeclSpace instead of a TypeContainer.
12964 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
12965 types are being initialized, load the address of it before calling
12968 (New): Provide a mechanism to disable the generation of local
12969 value type temporaries when the caller will be providing us with
12970 an address to store it.
12972 (ArrayCreation.EmitDynamicInitializers): Use it.
12974 2002-03-17 Miguel de Icaza <miguel@ximian.com>
12976 * expression.cs (Invocation.EmitArguments): Only probe for array
12977 property if there is more than one argument. Sorry about that.
12979 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
12980 empty param arrays.
12982 * class.cs (Method.LabelParameters): Fix incorrect code path that
12983 prevented the `ParamArrayAttribute' from being applied to the
12986 2002-03-16 Miguel de Icaza <miguel@ximian.com>
12988 * support.cs (ReflectionParameters): Correctly compute whether the
12989 last argument is a params array. Fixes the problem with
12992 * typemanager.cs: Make the assemblies array always be non-null
12993 (empty, but non-null)
12995 * tree.cs (RecordDecl): New function that abstracts the recording
12996 of names. This reports error 101, and provides a pointer to the
12997 previous declaration. Fixes a crash in the compiler.
12999 * cs-parser.jay (constructor_declaration): Update to new grammar,
13000 and provide a constructor_body that can be empty.
13002 2002-03-15 Miguel de Icaza <miguel@ximian.com>
13004 * driver.cs: Add support for --resources.
13006 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
13007 Make all types for the various array helper methods be integer.
13009 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
13010 CheckState to ConvCast.
13012 (ConvCast): Now it takes a `checked' state argument, to avoid
13013 depending on the emit context for the conversion, and just using
13014 the resolve time setting.
13016 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
13017 instead of Invocation.EmitArguments. We do not emit the original
13018 arguments, instead we emit those which have been converted to
13019 unsigned int expressions.
13021 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
13023 * codegen.cs: ditto.
13025 * expression.cs (LocalVariableReference): Drop the use of the
13026 Store function that depended on the variable index.
13028 * statement.cs (VariableInfo): Drop the `Idx' property from this
13029 class, as this is not taking into account the indexes for
13030 temporaries tat we generate during the execution, getting the
13033 * class.cs: First emit class initializers, then call the parent
13036 * expression.cs (Binary): Fix opcode emision.
13037 (UnaryMutator.EmitCode): Support checked code generation
13039 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
13040 matches for events for both the Static and Instance scans,
13041 pointing to the same element. Fix that.
13043 2002-03-14 Miguel de Icaza <miguel@ximian.com>
13045 * rootcontext.cs (ResolveTree): Always set the
13046 interface_resolve_order, because nested interfaces will be calling
13049 * class.cs (GetInterfaceOrClass): Track the same resolution
13050 process used by TypeManager.LookupType. This fixes the nested
13051 type lookups in class declarations (separate path from
13054 (TypeContainer.DefineType): Also define nested interfaces.
13055 (TypeContainer.RegisterOrder): New public function used to
13056 register the order in which child interfaces need to be closed.
13058 Nested interfaces need to be closed after their parents have been
13061 * interface.cs (InterfaceAttr): Put all the logic for computing
13062 the interface attribute here.
13064 (DefineInterface): Register our interface order with the
13065 RootContext or with the TypeContainer depending on the case.
13067 2002-03-12 Miguel de Icaza <miguel@ximian.com>
13069 * cs-parser.jay: rework foreach statement to work with the new
13070 changes to the policy on SimpleNames.
13072 * report.cs: support Stacktrace on warnings as well.
13074 * makefile: drop --unsafe and /unsafe from the compile.
13076 2002-03-13 Ravi Pratap <ravi@ximian.com>
13078 * ecore.cs (StandardConversionExists): Modify to take an Expression
13079 as the first parameter. Ensure we do null -> reference type conversion
13082 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
13083 temporary Expression objects.
13085 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
13087 * interface.cs: workaround bug in method overloading resolution
13088 (there is already a bugzilla bug for it).
13090 2002-03-12 Miguel de Icaza <miguel@ximian.com>
13092 We could also solve this problem by having a separate path for
13093 performing type lookups, instead of DoResolve, we could have a
13094 ResolveType entry point, and only participating pieces of the
13095 production (simplename, deref, array) would implement this.
13097 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
13098 signal SimpleName to only resolve type names and not attempt to
13099 resolve anything else.
13101 * expression.cs (Cast): Set the flag.
13103 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
13105 * class.cs: Only report 108 if there is no `new' modifier.
13107 * cs-parser.jay: rework foreach statement to work with the new
13108 changes to the policy on SimpleNames.
13110 * report.cs: support Stacktrace on warnings as well.
13112 * makefile: drop --unsafe and /unsafe from the compile.
13114 2002-03-11 Miguel de Icaza <miguel@ximian.com>
13116 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
13117 lookups here, instead of doing that at parse time. This means
13118 that our grammar will not introduce `LocalVariableReferences' as
13119 expressions at this point. That solves the problem of code like
13123 static void Main ()
13127 This is only half the fix. The full fix requires parameters to
13128 also be handled in this way.
13130 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
13131 makes the use more obvious of the DeclSpace. The
13132 ec.TypeContainer.TypeBuilder is now only used to pull the
13133 TypeBuilder for it.
13135 My theory is that I can get rid of the TypeBuilder completely from
13136 the EmitContext, and have typecasts where it is used (from
13137 DeclSpace to where it matters).
13139 The only pending problem is that the code that implements Aliases
13140 is on TypeContainer, and probably should go in DeclSpace.
13142 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
13143 lookups here, instead of doing that at parse time. This means
13144 that our grammar will not introduce `LocalVariableReferences' as
13145 expressions at this point. That solves the problem of code like
13149 static void Main ()
13153 This is only half the fix. The full fix requires parameters to
13154 also be handled in this way.
13156 * class.cs (Property.DefineMethod): When implementing an interface
13157 method, set newslot, when implementing an abstract method, do not
13158 set the flag (before we tried never setting it, or always setting
13159 it, which is the difference).
13160 (Indexer.DefineMethod): same.
13161 (Method.DefineMethod): same.
13163 * ecore.cs: Only set the status used flag if we get back a Field.
13165 * attribute.cs: Temporary hack, so Paolo can keep working.
13167 2002-03-08 Ravi Pratap <ravi@ximian.com>
13169 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
13170 the unmanaged type in the case we have a MarshalAs attribute.
13172 (Resolve): Handle the case when we are parsing the special MarshalAs
13173 attribute [we need to store the unmanaged type to use later]
13175 * typemanager.cs (marshal_as_attr_type): Built in type for the
13176 MarshalAs Attribute.
13178 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
13179 on parameters and accordingly set the marshalling info.
13181 2002-03-09 Miguel de Icaza <miguel@ximian.com>
13183 * class.cs: Optimizing slightly by removing redundant code after
13184 we switched to the `NoTypes' return value.
13185 (Property.DefineMethod): use NoTypes here too.
13187 This fixes the bug I introduced in my last batch of changes.
13189 2002-03-05 Ravi Pratap <ravi@ximian.com>
13191 * tree.cs (RecordEnum): Add. We now keep track of enums too.
13193 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
13194 Enums since those are types too.
13196 * cs-parser.jay (enum_declaration): Record enums as we parse them.
13198 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
13199 thanks to a call during the lookup process.
13201 2002-03-07 Miguel de Icaza <miguel@ximian.com>
13203 * statement.cs (Foreach): Lots of work to accomodate a particular
13204 kind of foreach statement that I had not kept in mind. It is
13205 possible to have foreachs on classes that provide a GetEnumerator
13206 method that return objects that implement the "pattern" for using
13207 a foreach, there is no need to support GetEnumerator
13210 This is needed to compile nant.
13212 * decl.cs: Only report 114 if the member is not `Finalize' and if
13213 the warning level is at least 2.
13215 * class.cs: Moved the compare function from Method to
13218 (MethodSignature.InheritableMemberSignatureCompare): Add new
13219 filter function that is used to extract inheritable methods from a
13222 (Method.Define): Use the new `inheritable_method_signature_filter'
13225 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
13228 2002-03-06 Miguel de Icaza <miguel@ximian.com>
13230 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
13232 * cs-parser.jay: Add opt_semicolon to the interface declaration.
13234 * expression.cs: Pass location information to
13235 ConvertImplicitStandard.
13237 * class.cs: Added debugging code to track return values from
13240 2002-03-05 Miguel de Icaza <miguel@ximian.com>
13242 * expression.cs (Is.DoResolve): If either side of the `is' is an
13243 interface, do not flag the warning.
13245 * ecore.cs (ImplicitReferenceConversion): We need a separate test
13248 * report.cs: Allow for --fatal to be used with --probe.
13250 * typemanager.cs (NoTypes): Move the definition for the empty Type
13253 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
13255 (TypeContainer.DefineProxy): New function used to proxy to parent
13256 implementations when implementing interfaces.
13257 (TypeContainer.ParentImplements): used to lookup if our parent
13258 implements a public function that is required by an interface.
13259 (TypeContainer.VerifyPendingMethods): Hook this up.
13261 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
13262 `modules' and `assemblies' arraylists into arrays. We only grow
13263 these are the very early start up of the program, so this improves
13264 the speedof LookupType (nicely measured).
13266 * expression.cs (MakeByteBlob): Replaced unsafe code with
13267 BitConverter, as suggested by Paolo.
13269 * cfold.cs (ConstantFold.Binary): Special case: perform constant
13270 folding of string concatenation, but if either side is a string,
13271 and the other is not, then return null, and let the runtime use
13272 the concatenation on the string plus the object (using
13273 `Object.ToString').
13275 2002-03-04 Miguel de Icaza <miguel@ximian.com>
13277 Constant Folding has been implemented now.
13279 * expression.cs (Unary.Reduce): Do not throw an exception, catch
13280 the error instead on types that are not supported in one's
13283 * constant.cs (Constant and all children): New set of functions to
13284 perform implict and explicit conversions.
13286 * ecore.cs (EnumConstant): Implement the new functions to perform
13287 conversion by proxying to the child expression.
13289 * codegen.cs: (ConstantCheckState): Constant evaluation has its
13290 own separate setting that can not be turned off from the command
13291 line using --unchecked or --checked and is only controlled using
13292 the checked/unchecked statements and expressions. This setting is
13293 used by the constant folder to flag errors.
13295 * expression.cs (CheckedExpr, UncheckedExpr): Set the
13296 ConstantCheckState as well.
13298 During Resolve, they also have to flag the state, because the
13299 constant folder runs completely in the Resolve phase.
13301 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
13304 2002-03-01 Miguel de Icaza <miguel@ximian.com>
13306 * cfold.cs: New file, this file contains the constant folder.
13308 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
13309 argument to track whether we are using the resulting address to
13310 load or store a value and provide better error messages.
13312 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
13313 new AddressOf arguments.
13315 * statement.cs (Foreach.EmitCollectionForeach): Update
13317 * expression.cs (Argument.Emit): Call AddressOf with proper
13318 arguments to track usage.
13320 (New.DoEmit): Call AddressOf with new arguments.
13322 (Unary.Emit): Adjust AddressOf call.
13324 2002-03-01 Ravi Pratap <ravi@ximian.com>
13326 * cs-parser.jay (member_access): Change the case for pre-defined types
13327 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
13330 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
13333 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
13334 essentially like methods and apply attributes like MethodImplOptions to them too.
13336 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
13339 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
13340 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
13343 * Update code everywhere accordingly.
13345 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
13347 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
13349 2002-02-28 Ravi Pratap <ravi@ximian.com>
13351 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
13352 try performing lookups against those instead of jumping straight into using
13353 the 'using' clauses.
13355 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
13357 (LookupType): Perform lookups in implicit parents too.
13359 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
13360 sequence as RootContext.LookupType.
13362 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
13363 the various cases of namespace lookups into this method.
13365 2002-03-01 Miguel de Icaza <miguel@ximian.com>
13367 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
13368 in positional arguments)
13370 * class.cs (Operator): Update the AllowedModifiers to contain
13373 * cs-parser.jay: Update operator declaration to allow for the
13374 operator body to be empty.
13376 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
13379 2002-02-27 Miguel de Icaza <miguel@ximian.com>
13381 * class.cs (Method.Emit): Label parameters.
13383 * driver.cs: Return 1 or 0 as the program exit code.
13385 2002-02-26 Miguel de Icaza <miguel@ximian.com>
13387 * expression.cs: Special case the `null' object when trying to
13388 auto-compute the type, as anything can be explicitly converted to
13391 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
13392 spotting this Paolo.
13394 (Expression.ImplicitNumericConversion): Perform comparissions of
13395 the type using the underlying type in the case of an enumeration
13396 rather than using the enumeration type for the compare.
13398 Cope with the underlying == type case, which is not possible to
13401 (Expression.ConvertNumericExplicit): Perform comparissions of
13402 the type using the underlying type in the case of an enumeration
13403 rather than using the enumeration type for the compare.
13405 * driver.cs: If the user does not supply an extension, assume .exe
13407 * cs-parser.jay (if_statement): Rewrote so that we can track the
13408 location for the if statement.
13410 * expression.cs (Binary.ConstantFold): Only concat strings when
13411 the operation is "+", not everything ;-)
13413 * statement.cs (Statement.EmitBoolExpression): Take a location
13415 (If, While, Do): Track location.
13417 * expression.cs (Binary.ResolveOperator): In the object + string
13418 case, I was missing a call to ConvertImplicit
13420 2002-02-25 Ravi Pratap <ravi@ximian.com>
13422 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
13423 Location arguments. Ensure we use RootContext.LookupType to do our work
13424 and not try to do a direct Type.GetType and ModuleBuilder.GetType
13426 * interface.cs (PopulateMethod): Handle the type of the parameter being
13429 * expression.cs (Invocation.BetterFunction): Handle the case when we
13430 have a params method with no fixed arguments and a call is made with no
13433 2002-02-25 Miguel de Icaza <miguel@ximian.com>
13435 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
13436 the verbatim-string-literal
13438 * support.cs (InternalParameters.ParameterModifier): handle null
13440 (InternalParameters.ParameterType): ditto.
13442 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
13443 duplicating the name of the variable parameter.
13444 (GetParameterByName): Fix bug where we were not looking up array
13445 paramters if they were the only present (thanks Paolo!).
13446 (GetParameterInfo): We only have an empty set of types if both
13447 fixed and array are set to null.
13448 (GetParameterInfo-idx): Handle FixedParameter == null
13450 * cs-parser.jay: Handle the case where there is no catch
13451 statements (missing null test).
13453 2002-02-22 Miguel de Icaza <miguel@ximian.com>
13455 * driver.cs (MainDriver): Be conservative on our command line
13458 Catch DirectoryNotFoundException when calling GetFiles.
13460 (SplitPathAndPattern): Used to split the input specification into
13461 a path and a pattern that we can feed to Directory.GetFiles.
13463 2002-02-21 Miguel de Icaza <miguel@ximian.com>
13465 * statement.cs (Fixed): Implement the last case of the Fixed
13466 statement (string handling).
13468 * expression.cs (StringPtr): New class used to return a char * to
13469 a string; Used by the Fixed statement.
13471 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
13473 * expression.cs (Binary.ResolveOperator): Remove redundant
13474 MemberLookup pn parent type.
13475 Optimize union call, we do not need a union if the types are the same.
13476 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
13479 Specialize the use of MemberLookup everywhere, instead of using
13480 the default settings.
13482 (StackAlloc): Implement stackalloc keyword.
13484 * cs-parser.jay: Add rule to parse stackalloc.
13486 * driver.cs: Handle /h, /help, /?
13488 * expression.cs (MakeByteBlob): Removed the hacks we had in place
13489 before we supported unsafe code.
13491 * makefile: add --unsafe to the self compilation of mcs.
13493 2002-02-20 Miguel de Icaza <miguel@ximian.com>
13495 * expression.cs (PointerArithmetic): New class that is used to
13496 perform pointer arithmetic.
13497 (Binary.Resolve): Handle pointer arithmetic
13498 Handle pointer comparission.
13499 (ArrayPtr): Utility expression class that is used to take the
13500 address of an array.
13502 (ElementAccess): Implement array access for pointers
13504 * statement.cs (Fixed): Implement fixed statement for arrays, we
13505 are missing one more case before we are done.
13507 * expression.cs (Indirection): Implement EmitAssign and set the
13508 ExprClass to Variable. This allows pointer dereferences to be
13509 treated as variables, and to have values assigned to them.
13511 * ecore.cs (Expression.StoreFromPtr): New utility function to
13512 store values dereferencing.
13514 2002-02-20 Ravi Pratap <ravi@ximian.com>
13516 * expression.cs (Binary.ResolveOperator): Ensure that we are
13517 not trying to operate on a void type - this fixes the reported
13520 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
13521 the parent implementation is sealed.
13523 * ../errors/cs0239.cs : Add.
13525 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
13527 * typemanager.cs (unverifiable_code_type): Corresponds to
13528 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
13529 which have unsafe code in them.
13531 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
13534 2002-02-19 Miguel de Icaza <miguel@ximian.com>
13536 * cs-tokenizer.cs: Add support for @"litreal strings"
13538 Make tokenizer accept pre-processor directives
13539 on any column (remove the old C-like limitation).
13541 * rootcontext.cs (EmitCode): Emit any global attributes.
13542 (AddGlobalAttributes): Used to keep track of assembly attributes.
13544 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
13546 * cs-parser.jay: Add support for global attributes.
13548 2002-02-17 Miguel de Icaza <miguel@ximian.com>
13550 * expression.cs (Indirection): New helper class. Unary will
13551 create Indirection classes to be able to implement the
13552 IMemoryLocation interface on it.
13554 2002-02-16 Miguel de Icaza <miguel@ximian.com>
13556 * cs-parser.jay (fixed_statement): reference the right statement.
13558 * statement.cs (Fixed.Emit): Finish implementing the fixed
13559 statement for the &x case.
13561 2002-02-14 Miguel de Icaza <miguel@ximian.com>
13563 * class.cs (Property.Define, Method.Define): Remove newslot when
13566 * modifiers.cs: My use of NewSlot when `Abstract' was set was
13567 wrong. NewSlot should only be used if the `new' keyword is present.
13569 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
13570 locating our system dir. Sorry about this.
13572 2002-02-13 Miguel de Icaza <miguel@ximian.com>
13574 * driver.cs (GetSystemDir): Compute correctly the location of our
13575 system assemblies. I was using the compiler directory instead of
13576 the library directory.
13578 2002-02-13 Ravi Pratap <ravi@ximian.com>
13580 * expression.cs (BetterFunction): Put back in what Miguel commented out
13581 since it is the correct fix. The problem is elsewhere ;-)
13583 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
13584 parameters of the parms method are themselves compatible or not !
13586 (StandardConversionExists): Fix very dangerous bug where we were forgetting
13587 to check that a class implements an interface before saying that an implicit
13588 conversion was allowed. Use ImplementsInterface to do the checking.
13590 2002-02-13 Miguel de Icaza <miguel@ximian.com>
13592 * class.cs (Method.Define): Track whether we are an explicit
13593 implementation or not. And only call DefineMethodOverride if we
13594 are an explicit implementation.
13596 (Property.DefineMethod): Ditto.
13598 2002-02-11 Ravi Pratap <ravi@ximian.com>
13600 * expression.cs (BetterFunction): Catch hideous bug which was
13601 preventing us from detecting ambiguous calls due to implicit casts i.e
13604 2002-01-29 Miguel de Icaza <miguel@ximian.com>
13606 * support.cs (Pair): Remove un-needed method. I figured why I was
13607 getting the error in cs-parser.jay, the variable in a foreach loop
13608 is readonly, and the compiler does not really treat this as a variable.
13610 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
13611 instead of EQUALS in grammar.
13613 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
13615 * expression.cs (Unary.DoResolve): Check whether the argument is
13618 2002-01-28 Miguel de Icaza <miguel@ximian.com>
13620 * support.cs: Api for Pair to set a value. Despite the fact that
13621 the variables are public the MS C# compiler refuses to compile
13622 code that accesses the field if the variable is part of a foreach
13625 * statement.cs (Fixed): Begin implementation of the fixed
13628 (Block.AddVariable): Return the VariableInfo on success and null
13629 on failure instead of true/false.
13631 * cs-parser.jay (foreach): Catch errors on variables already
13632 defined (we were ignoring this value before) and properly unwind
13633 the block hierarchy
13635 (fixed_statement): grammar for the fixed statement.
13637 2002-01-25 Miguel de Icaza <miguel@ximian.com>
13639 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
13640 pointer types to be incretemented.
13642 (SizeOf): Implement.
13644 * cs-parser.jay (pointer_member_access): Implement
13645 expr->IDENTIFIER production.
13647 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
13648 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
13651 (Unary): Implement indirection.
13653 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
13654 use in non-unsafe context).
13656 (SimpleName.DoResolve): Check for pointers in field access on safe
13659 (Expression.LoadFromPtr): Factor the load-indirect code in this
13660 function. This was duplicated in UnboxCast and ParameterReference
13662 2002-01-24 Miguel de Icaza <miguel@ximian.com>
13664 * expression.cs (ComposedCast): report an error if a pointer cast
13665 is used in a safe region.
13667 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
13668 pointer type casts in unsafe context.
13670 * codegen.cs (EmitContext): Set up IsUnsafe.
13672 * cs-parser.jay (non_expression_type): Add productions for pointer
13675 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
13676 code. We should not use force into static mode if the method is
13677 not virtual. Fixes bug in MIS
13679 * statement.cs (Do.Emit, While.Emit, For.Emit,
13680 Statement.EmitBoolExpression): Add support to Do and While to
13681 propagate infinite loop as `I do return' semantics.
13683 Improve the For case to also test for boolean constants.
13685 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
13686 to the list of attributes we can add.
13688 Remove `EmitContext' argument.
13690 * class.cs (Method.Define): Apply parameter attributes.
13691 (Constructor.Define): Apply parameter attributes.
13692 (MethodCore.LabelParameters): Move here the core of labeling
13695 * support.cs (ReflectionParameters.ParameterModifier,
13696 InternalParameters.ParameterModifier): Use IsByRef on the type and
13697 only return the OUT bit for these parameters instead of in/out/ref
13700 This is because I miss-understood things. The ParameterInfo.IsIn
13701 and IsOut represent whether the parameter has the [In] and [Out]
13704 2002-01-22 Miguel de Icaza <miguel@ximian.com>
13706 * ecore.cs (FieldExpr.Emit): Release temporaries.
13708 * assign.cs (LocalTemporary.Release): new function.
13710 * codegen.cs (EmitContext.GetTemporaryStorage,
13711 EmitContext.FreeTemporaryStorage): Rework the way we deal with
13712 temporary storage. Now we can "put back" localbuilders when we
13715 2002-01-21 Miguel de Icaza <miguel@ximian.com>
13717 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
13718 need to make a copy of the variable to generate verifiable code.
13720 2002-01-19 Miguel de Icaza <miguel@ximian.com>
13722 * driver.cs: Compute dynamically the system directory.
13724 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
13725 Slower, but more generally useful. Used by the abstract
13726 registering implementation.
13728 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
13729 the rules for the special rule on Type/instances. First check if
13730 we have the same name, and if so, try that special static path
13731 rather than the instance path.
13733 2002-01-18 Miguel de Icaza <miguel@ximian.com>
13735 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
13738 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
13739 Enum, ValueType, Delegate or Array for non-corlib compiles.
13741 * cs-tokenizer.cs: Catch long identifiers (645)
13743 * typemanager.cs (IndexerPropetyName): Ravi never tested this
13746 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
13747 fix, we were returning too early, so we were not registering
13748 pending methods from abstract classes.
13750 Do not register pending methods if the class is abstract.
13752 * expression.cs (Conditional.DoResolve): Report circular implicit
13753 conversions when we neecd to compute it for conditional
13756 (Is.DoResolve): If the expression is always of the provided type,
13757 flag warning 183. If the expression can not ever be of the
13758 provided type flag warning 184.
13760 * class.cs: Catch 169 as well.
13762 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
13765 2002-01-18 Nick Drochak <ndrochak@gol.com>
13767 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
13769 2002-01-17 Miguel de Icaza <miguel@ximian.com>
13771 * interface.cs: (PopulateMethod): Check for pointers being defined
13772 only if the unsafe context is active.
13773 (PopulateProperty): ditto.
13774 (PopulateIndexer): ditto.
13776 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
13777 specified. If pointers are present, make sure that they are
13778 present in an unsafe context.
13779 (Constructor, Constructor.Define): ditto.
13780 (Field, Field.Define): ditto.
13781 (Property, Property.Define): ditto.
13782 (Event, Event.Define): ditto.
13784 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
13785 hashtable if there are classes or structs defined.
13787 * expression.cs (LocalVariableReference.DoResolve): Simplify this
13788 code, as the constant resolution moved.
13790 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
13791 the metadata, so we can flag error 133.
13793 * decl.cs (MemberCore.UnsafeOK): New function to test that a
13794 pointer is being declared in an unsafe context.
13796 2002-01-16 Miguel de Icaza <miguel@ximian.com>
13798 * modifiers.cs (Modifiers.Check): Require a Location argument.
13799 Report error 227 for Unsafe use.
13801 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
13803 * statement.cs (For.Emit): If the test is null, then report that
13804 we do `return', as we wont reach anything afterwards.
13806 (Switch.SwitchGoverningType): Track the expression that matched
13809 * driver.cs: Allow negative numbers as an error code to flag.
13811 * cs-parser.jay: Handle 1551.
13813 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
13815 2002-01-15 Miguel de Icaza <miguel@ximian.com>
13817 * cs-parser.jay: Report 1518 (type declaration can only contain
13818 class, struct, interface, enum or delegate)
13820 (switch_label): Report 1523 (keywords `case' or `default' must
13823 (opt_switch_sections): Report 1522 (empty switch)
13825 * driver.cs: Report 1515 (response file specified multiple times)
13826 Report 1516 (Source file specified multiple times).
13828 * expression.cs (Argument.Resolve): Signal 1510
13830 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
13831 access not allowed in static code)
13833 2002-01-11 Ravi Pratap <ravi@ximian.com>
13835 * typemanager.cs (IsPointerType): Utility method which we are going
13838 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
13839 the object type, so we take care of that.
13841 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
13843 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
13844 added to non-params parameters :-)
13846 * typemanager.cs (CSharpName): Include 'void' type too.
13848 (void_ptr_type): Include in the set of core types.
13850 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
13853 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
13856 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
13857 completely forgotten about it.
13859 2002-01-10 Ravi Pratap <ravi@ximian.com>
13861 * cs-parser.jay (pointer_type): Add. This begins our implementation
13862 of parsing rules for unsafe code.
13864 (unsafe_statement): Implement.
13866 (embedded_statement): Modify to include the above.
13868 * statement.cs (Unsafe): Implement new class for unsafe blocks.
13870 * codegen.cs (EmitContext.InUnsafe): Add. This determines
13871 if the current context is an unsafe one.
13873 * cs-parser.jay (local_variable_pointer_type): Since local variable types
13874 are handled differently, we need separate rules for them.
13876 (local_variable_declaration): Update to use local_variable_pointer_type
13877 to allow variable declarations of unmanaged pointer types.
13879 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
13880 in unsafe contexts.
13882 * ../errors/cs0214.cs : Add.
13884 2002-01-16 Nick Drochak <ndrochak@gol.com>
13886 * makefile: remove 'response' file when cleaning.
13888 2002-01-15 Miguel de Icaza <miguel@ximian.com>
13890 * cs-parser.jay: Report 1524.
13892 2002-01-14 Miguel de Icaza <miguel@ximian.com>
13894 * typemanager.cs (RegisterMethod): drop checking if we have
13895 registered this from here
13897 2002-01-12 Miguel de Icaza <miguel@ximian.com>
13899 * class.cs (Method.EmitDestructor): Implement calling our base
13902 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
13903 value of InFinally.
13905 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
13906 this routine and will wrap the call in a try/catch block. Deal
13909 2002-01-11 Miguel de Icaza <miguel@ximian.com>
13911 * ecore.cs (Expression.MemberLookup): instead of taking a
13912 parameter `same_type' that was used to tell whether we could
13913 access private members we compute our containing type from the
13916 (FieldExpr): Added partial support for volatile fields. This does
13917 not work for volatile fields exposed from assemblies, as I can not
13918 figure out how to extract the modreq from it.
13920 Updated all the source files to use this.
13922 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
13923 because it is referenced by MemberLookup very often.
13925 2002-01-09 Ravi Pratap <ravi@ximian.com>
13927 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
13928 TypeBuilder.GetCustomAttributes to retrieve what we need.
13930 Get rid of redundant default_member_attr_type as this is the same as
13931 default_member_type which already exists.
13933 * interface.cs, attribute.cs : Update accordingly.
13935 2002-01-08 Miguel de Icaza <miguel@ximian.com>
13937 * typemanager.cs: Enable IndexerPropertyName again. It does not
13938 work for TYpeBuilders though. Ravi, can you please fix this?
13940 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
13942 * expression.cs (Argument.Emit): Handle the case of ref objects
13943 being passed to ref functions;
13945 (ParameterReference.EmitLoad): Loads the content of the pointer
13946 without dereferencing.
13948 2002-01-07 Miguel de Icaza <miguel@ximian.com>
13950 * cs-tokenizer.cs: Implemented the pre-processing expressions.
13952 2002-01-08 Ravi Pratap <ravi@ximian.com>
13954 * class.cs (Indexer.DefineMethod): Incorporate the interface
13955 type in the name of the method if we are doing explicit interface
13958 * expression.cs (ConversionExists): Remove as it is completely obsolete.
13960 (BetterConversion): Fix extremely trivial bug where we were referring to
13961 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
13964 * ../errors/bug16.cs : Add although we have fixed it.
13966 2002-01-07 Miguel de Icaza <miguel@ximian.com>
13968 * expression.cs (BaseIndexer): Begin implementation.
13970 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
13972 * cs-parser.jay (indexer_declarator): Use qualified_identifier
13973 production directly to remove a shift/reduce, and implement
13974 explicit interface implementation.
13976 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
13977 after a floating point suffix.
13979 * expression.cs (DoNumericPromotions): Improved the conversion for
13980 uint/uint. If we have a constant, we avoid doing a typecast to a
13983 * class.cs (Indexer): Implement explicit interface implementation
13986 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
13988 * class.cs: make the default instance constructor public and hidebysig.
13990 2001-01-03 Ravi Pratap <ravi@ximian.com>
13992 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
13993 so we can call it from elsewhere.
13995 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
13996 we emit it internally if the class has a defined indexer; otherwise the user
13997 emits it by decorating the class definition with the DefaultMemberAttribute.
13999 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
14000 attribute is not used on a type which defines an indexer.
14002 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
14003 character when we skip whitespace.
14005 * ../errors/cs0646.cs : Add.
14007 2002-01-03 Miguel de Icaza <miguel@ximian.com>
14009 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
14012 * makefile: Add practical target `mcs3.exe' which builds the third
14013 generation compiler.
14015 * expression.cs (New): Fix structures constructor calling.
14017 * class.cs (Property, Method, Indexer): Emit Final flag on the
14018 method if we are an interface implementation and we are not
14021 * ecore.cs (PropertyExpr): New public field `IsBase', tells
14022 whether this property is referencing a `base' method.
14024 * expression.cs (Invocation.EmitCall): take an extra argument:
14025 is_base, this is used to determine whether the `call' or
14026 `callvirt' opcode should be used.
14029 * delegate.cs: update EmitCall.
14031 * class.cs (Method.Define): Set NewSlot for the cases where we are
14032 not implementing an interface method.
14034 (Property.Define): ditto.
14036 2002-01-02 Miguel de Icaza <miguel@ximian.com>
14038 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
14039 'r'. Allows mcs to parse itself fully.
14041 2002-01-02 Ravi Pratap <ravi@ximian.com>
14043 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
14044 of the number of initializers that require the InitializeArray method.
14046 (CheckIndices): Store the Expression in all cases - not the plain value. Also
14047 update the above field where necessary.
14049 (MakeByteBlob): Update accordingly.
14051 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
14054 (EmitDynamicInitializers): Update in accordance with the new optimization.
14056 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
14057 same OpCode applies.
14059 * cs-parser.jay : Fix some glaring errors I introduced.
14061 2002-01-01 Ravi Pratap <ravi@ximian.com>
14063 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
14064 so that we can check for name clashes there too.
14066 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
14067 for interface indexers.
14069 * interfaces.cs (Define): Emit the default member attribute.
14071 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
14072 variable was being referred to while setting the value ;-)
14074 2002-01-01 Miguel de Icaza <miguel@ximian.com>
14076 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
14077 byte-by-byte information when we know the data is zero.
14079 Make the block always a multiple of 4, because
14080 DefineInitializedData has a bug.
14082 * assign.cs: Fix, we should assign from the temporary, not from
14085 * expression.cs (MakeByteBlob): Fix my incorrect code.
14087 2001-12-31 Miguel de Icaza <miguel@ximian.com>
14089 * typemanager.cs (EnumToUnderlying): This function is used to get
14090 the underlying type from an enumeration, because it does not
14093 * constant.cs: Use the I4_S form for values between -128 and 127.
14095 * statement.cs (Block.LookupLabel): Looks up a label.
14096 (Block): Drop support for labeled blocks.
14098 (LabeledStatement): New kind of statement that represents a label
14101 (Goto): Finally implement this bad boy.
14103 * cs-parser.jay: Update to reflect new mechanism to implement
14106 2001-12-30 Miguel de Icaza <miguel@ximian.com>
14108 * codegen.cs (EmitContext.This): a codegen property that keeps the
14109 a single instance of this instead of creating many different this
14112 * delegate.cs (Delegate.DoResolve): Update to use the property;
14114 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
14116 * expression.cs (BaseAccess.DoResolve): Ditto.
14118 2001-12-29 Ravi Pratap <ravi@ximian.com>
14120 * typemanager.cs (methodimpl_attr_type): Add to hold the type
14121 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
14123 (InitCoreTypes): Update accordingly.
14125 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
14126 so we can quickly store the state.
14128 (ApplyAttributes): Set the correct implementation flags
14129 for InternalCall methods.
14131 2001-12-29 Miguel de Icaza <miguel@ximian.com>
14133 * expression.cs (EmitCall): if a method is not virtual, then do
14134 not use callvirt on it.
14136 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
14137 user defined stuff) requires the use of stobj, which takes an
14138 address on the stack instead of an array and an index. So emit
14139 the Ldelema operation for it.
14141 (EmitStoreOpcode): Use stobj for valuetypes.
14143 (UnaryMutator.EmitCode): Use the right 1 value depending on
14144 whether we are dealing with int64/uint64, float or doubles.
14146 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
14147 constructors that I implemented last night.
14149 (Constructor.IsDefault): Fix to work properly for static
14152 * cs-parser.jay (CheckDef): report method signature errors.
14153 Update error number 103 to be 132.
14155 * decl.cs: New AdditionResult enumeration value: MethodExists.
14156 Although we do this check for methods later on in the semantic
14157 analysis, catching repeated default constructors is so easy that
14158 we catch these here.
14160 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
14163 (ParameterReference.EmitAssign, Emit): handle
14166 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
14167 (ArrayAccess.EmitStoreOpcode): ditto.
14169 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
14171 * expression.cs (MakeByteBlob): Complete all the missing types
14172 (uint, short, ushort, byte, sbyte)
14174 * class.cs: Only init instance field initializers on instance
14177 Rename `constructors' to instance_constructors.
14179 (TypeContainer.AddConstructor): Only add constructors to the list
14180 if it is not static.
14182 Make sure that we handle default_static_constructor independently
14183 everywhere where we handle instance_constructors
14185 2001-12-28 Miguel de Icaza <miguel@ximian.com>
14187 * class.cs: Do not lookup or create a base initializer for a
14188 static constructor.
14190 (ConstructorInitializer.Resolve): use the proper type to lookup
14193 * cs-parser.jay: Report error 1585 (modifiers between type and name).
14195 * enum.cs, interface.cs: Remove CloseType, this is taken care by
14198 * decl.cs: CloseType is now an virtual method, the default
14199 implementation just closes this type.
14201 2001-12-28 Ravi Pratap <ravi@ximian.com>
14203 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
14204 to PreserveSig by default. Also emit HideBySig on such methods.
14206 Basically, set the defaults to standard values.
14208 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
14209 argument, if candidate is better, it can't be worse than the best !
14211 (Invocation): Re-write bits to differentiate between methods being
14212 applicable in their expanded form and their normal form - for params
14215 Get rid of use_standard everywhere as only standard conversions are allowed
14216 in overload resolution.
14218 More spec conformance.
14220 2001-12-27 Miguel de Icaza <miguel@ximian.com>
14222 * driver.cs: Add --timestamp, to see where the compiler spends
14225 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
14226 `this' in static code.
14228 (SimpleName.DoResolve): Implement in terms of a helper function
14229 that allows static-references to be passed upstream to
14232 (Expression.ResolveWithSimpleName): Resolve specially simple
14233 names when called by MemberAccess to implement the special
14236 (Expression.ImplicitReferenceConversion): Handle conversions from
14237 Null to reference types before others, as Null's type is
14240 * expression.cs (Invocation.EmitCall): Handle the special case of
14241 calling methods declared on a reference type from a ValueType
14242 (Base classes System.Object and System.Enum)
14244 (MemberAccess.Resolve): Only perform lookups on Enumerations if
14245 the left hand side is a TypeExpr, not on every enumeration.
14247 (Binary.Resolve): If types are reference types, then do a cast to
14248 object on operators != and == of both arguments.
14250 * typemanager.cs (FindMembers): Extract instance and static
14251 members if requested.
14253 * interface.cs (PopulateProperty): Use void_type instead of null
14254 as the return type for the setter method.
14256 (PopulateIndexer): ditto.
14258 2001-12-27 Ravi Pratap <ravi@ximian.com>
14260 * support.cs (ReflectionParameters): Fix minor bug where we
14261 were examining the wrong parameter for the ParamArray attribute.
14263 Cope with requests for the type of the parameter at position
14264 greater than the params parameter's. We now return the element
14265 type of the params array as that makes more sense.
14267 * expression.cs (Invocation.IsParamsMethodApplicable): Update
14268 accordingly as we no longer have to extract the element type
14271 (Invocation.OverloadResolve): Update.
14273 2001-12-27 Miguel de Icaza <miguel@ximian.com>
14275 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
14276 against IEnumerator, test whether the return value is a descendant
14277 of the IEnumerator interface.
14279 * class.cs (Indexer.Define): Use an auxiliary method to implement
14280 the other bits of the method definition. Begin support for
14281 explicit interface implementation.
14283 (Property.DefineMethod): Use TypeManager.void_type instead of null
14284 for an empty return value.
14286 2001-12-26 Miguel de Icaza <miguel@ximian.com>
14288 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
14289 dealing with a FieldExpr which is composed of a FieldBuilder, in
14290 the code path we did extract the constant, but we should have
14291 obtained the underlying value to be able to cast it (otherwise we
14292 end up in an infinite loop, this is what Ravi was running into).
14294 (ArrayCreation.UpdateIndices): Arrays might be empty.
14296 (MemberAccess.ResolveMemberAccess): Add support for section
14297 14.5.4.1 that deals with the special case of E.I when E is a type
14298 and something else, that I can be a reference to a static member.
14300 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
14301 handle a particular array type to create byte blobs, it is just
14302 something we dont generate byteblobs for.
14304 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
14307 * location.cs (Push): remove the key from the hashtable that we
14308 are about to add. This happens for empty files.
14310 * driver.cs: Dispose files after we have parsed them.
14312 (tokenize): new function that only runs the tokenizer on its
14313 input, for speed testing.
14315 2001-12-26 Ravi Pratap <ravi@ximian.com>
14317 * class.cs (Event.Define): Define the private field only if there
14318 are no accessors defined.
14320 * expression.cs (ResolveMemberAccess): If there is no associated
14321 field with the event, that means we have an event defined with its
14322 own accessors and we should flag error cs0070 since transforming
14323 ourselves into a field is not valid in that case.
14325 * ecore.cs (SimpleName.DoResolve): Same as above.
14327 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
14328 and charset to sane values.
14330 2001-12-25 Ravi Pratap <ravi@ximian.com>
14332 * assign.cs (DoResolve): Perform check on events only if they
14333 are being accessed outside the declaring type.
14335 * cs-parser.jay (event_declarations): Update rules to correctly
14336 set the type of the implicit parameter etc.
14338 (add_accessor, remove_accessor): Set current local parameters.
14340 * expression.cs (Binary): For delegate addition and subtraction,
14341 cast the return value from the method into the appropriate delegate
14344 2001-12-24 Ravi Pratap <ravi@ximian.com>
14346 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
14347 of these as the workaround is unnecessary.
14349 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
14350 delegate data - none of that is needed at all.
14352 Re-write bits to extract the instance expression and the delegate method
14355 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
14358 * attribute.cs (ApplyAttributes): New method to take care of common tasks
14359 of attaching attributes instead of duplicating code everywhere.
14361 * everywhere : Update code to do attribute emission using the above method.
14363 2001-12-23 Miguel de Icaza <miguel@ximian.com>
14365 * expression.cs (IsParamsMethodApplicable): if there are not
14366 parameters, return immediately.
14368 * ecore.cs: The 0 literal can be implicity converted to an enum
14371 (SimpleName.DoResolve): First lookup the type, then lookup the
14374 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
14375 want to get its address. If the InstanceExpression is not
14376 addressable, store the result in a temporary variable, then get
14379 * codegen.cs: Only display 219 errors on warning level or above.
14381 * expression.cs (ArrayAccess): Make it implement the
14382 IMemoryLocation interface.
14384 (Binary.DoResolve): handle the operator == (object a, object b)
14385 and operator != (object a, object b) without incurring into a
14386 BoxedCast (because 5 != o should never be performed).
14388 Handle binary enumerator operators.
14390 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
14391 value type, otherwise use Ldelem_ref.
14393 Use precomputed names;
14395 (AddressOf): Implement address of
14397 * cs-parser.jay (labeled_statement): Fix recursive block
14398 addition by reworking the production.
14400 * expression.cs (New.DoEmit): New has a special case:
14402 If we are dealing with a ValueType, we have a few
14403 situations to deal with:
14405 * The target of New is a ValueType variable, that is
14406 easy, we just pass this as the variable reference
14408 * The target of New is being passed as an argument,
14409 to a boxing operation or a function that takes a
14412 In this case, we need to create a temporary variable
14413 that is the argument of New.
14416 2001-12-23 Ravi Pratap <ravi@ximian.com>
14418 * rootcontext.cs (LookupType): Check that current_type is not null before
14419 going about looking at nested types.
14421 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
14422 not implement the IAssignMethod interface any more.
14424 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
14425 where we tranform them into FieldExprs if they are being resolved from within
14426 the declaring type.
14428 * ecore.cs (SimpleName.DoResolve): Do the same here.
14430 * assign.cs (DoResolve, Emit): Clean up code considerably.
14432 * ../errors/bug10.cs : Add.
14434 * ../errors/cs0070.cs : Add.
14436 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
14438 * assign.cs : Get rid of EventIsLocal everywhere.
14440 2001-12-23 Miguel de Icaza <miguel@ximian.com>
14442 * ecore.cs (ConvertIntLiteral): finished the implementation.
14444 * statement.cs (SwitchLabel): Convert the value we are using as a
14445 key before looking up the table.
14447 2001-12-22 Miguel de Icaza <miguel@ximian.com>
14449 * codegen.cs (EmitTopBlock): Require a Location argument now.
14451 * cs-parser.jay (constructor_declarator): We need to setup
14452 current_local_parameters before we parse the
14453 opt_constructor_initializer, to allow the variables to be bound
14454 to the constructor arguments.
14456 * rootcontext.cs (LookupType): First lookup nested classes in our
14457 class and our parents before we go looking outside our class.
14459 * expression.cs (ConstantFold): Extract/debox the values at the
14462 * rootcontext.cs (EmitCode): Resolve the constants first before we
14463 resolve the types. This is not really needed, but it helps debugging.
14465 * statement.cs: report location.
14467 * cs-parser.jay: pass location to throw statement.
14469 * driver.cs: Small bug fix.
14471 * report.cs: Updated format to be 4-zero filled digits.
14473 2001-12-22 Ravi Pratap <ravi@ximian.com>
14475 * expression.cs (CheckIndices): Fix minor bug where the wrong
14476 variable was being referred to ;-)
14478 (DoEmit): Do not call EmitStaticInitializers when the
14479 underlying type is System.Object.
14481 2001-12-21 Ravi Pratap <ravi@ximian.com>
14483 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
14484 and do the usual workaround for SRE.
14486 * class.cs (MyEventBuilder.EventType): New member to get at the type
14487 of the event, quickly.
14489 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
14491 * assign.cs (Assign.DoResolve): Handle the case when the target
14492 is an EventExpr and perform the necessary checks.
14494 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
14497 (SimpleName.MemberStaticCheck): Include check for EventExpr.
14499 (EventExpr): Set the type in the constructor itself since we
14500 are meant to be born fully resolved.
14502 (EventExpr.Define): Revert code I wrote earlier.
14504 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
14505 instance expression is null. The instance expression is a This in that case
14506 or a null, depending on whether it is a static method or not.
14508 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
14509 refers to more than one method.
14511 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
14512 and accordingly flag errors.
14514 2001-12-21 Miguel de Icaza <miguel@ximian.com>
14516 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
14518 2001-12-22 Miguel de Icaza <miguel@ximian.com>
14520 * location.cs (ToString): Provide useful rutine.
14522 2001-12-21 Miguel de Icaza <miguel@ximian.com>
14524 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
14525 objects, return the actual integral boxed.
14527 * statement.cs (SwitchLabel): define an ILLabel for each
14530 (Switch.CheckSwitch): If the value is a Literal, extract
14531 the underlying literal.
14533 Also in the unused hashtable we had, add the SwitchLabel so we can
14534 quickly look this value up.
14536 * constant.cs: Implement a bunch of new constants. Rewrite
14537 Literal based on this. Made changes everywhere to adapt to this.
14539 * expression.cs (Expression.MakeByteBlob): Optimize routine by
14540 dereferencing array only once, and also copes with enumrations.
14542 bytes are two bytes wide, not one.
14544 (Cast): Perform constant conversions.
14546 * ecore.cs (TryImplicitIntConversion): Return literals instead of
14547 wrappers to the literals here.
14549 * expression.cs (DoNumericPromotions): long literals can converted
14550 to ulong implicity (this is taken care of elsewhere, but I was
14551 missing this spot).
14553 * ecore.cs (Expression.Literalize): Make the return type Literal,
14554 to improve type checking.
14556 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
14558 2001-12-20 Miguel de Icaza <miguel@ximian.com>
14560 * literal.cs: Revert code from ravi that checked the bounds. The
14561 bounds are sane by the definition of the type itself.
14563 * typemanager.cs: Fix implementation of ImplementsInterface. We
14564 need to actually look up in our parent hierarchy for interfaces
14567 * const.cs: Use the underlying type for enumerations
14569 * delegate.cs: Compute the basename for the delegate creation,
14570 that should fix the delegate test case, and restore the correct
14571 Type Lookup semantics in rootcontext
14573 * rootcontext.cs: Revert Ravi's last patch. The correct way of
14574 referencing a nested type with the Reflection API is using the "+"
14577 * cs-parser.jay: Do not require EOF token at the end.
14579 2001-12-20 Ravi Pratap <ravi@ximian.com>
14581 * rootcontext.cs (LookupType): Concatenate type names with
14582 a '.' instead of a '+' The test suite passes again.
14584 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
14585 field of the enumeration.
14587 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
14588 the case when the member is an EventExpr.
14590 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
14591 static has an associated instance expression.
14593 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
14595 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
14597 * class.cs (Event.Define): Register event and perform appropriate checks
14600 We define the Add and Remove methods even if the use provides none because
14601 in that case, we provide default implementations ourselves.
14603 Define a private field of the type of the event. This is done by the CSC compiler
14604 and we should be doing it too ;-)
14606 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
14607 More methods we use in code we generate.
14609 (multicast_delegate_type, delegate_type): Two separate types since the distinction
14612 (InitCoreTypes): Update accordingly for the above.
14614 * class.cs (Event.Emit): Generate code for default accessors that we provide
14616 (EmitDefaultMethod): Do the job in the above.
14618 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
14621 2001-12-20 Miguel de Icaza <miguel@ximian.com>
14623 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
14624 builders even if we were missing one.
14626 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
14627 pass the Basename as our class name instead of the Name. The
14628 basename will be correctly composed for us.
14630 * parameter.cs (Paramters): Now takes a Location argument.
14632 * decl.cs (DeclSpace.LookupType): Removed convenience function and
14633 make all the code call directly LookupType in RootContext and take
14634 this chance to pass the Location information everywhere.
14636 * Everywhere: pass Location information.
14638 2001-12-19 Miguel de Icaza <miguel@ximian.com>
14640 * class.cs (Constructor.Define): Updated way of detecting the
14641 length of the parameters.
14643 (TypeContainer.DefineType): Use basename as the type name for
14646 (TypeContainer.Define): Do not recursively define types here, as
14647 definition is taken care in order by the RootContext.
14649 * tree.cs: Keep track of namespaces in a per-file basis.
14651 * parameter.cs (Parameter.ComputeSignature): Update to use
14654 (Parameters.GetSignature): ditto.
14656 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
14657 instead of a TypeContainer.
14659 (Interface.SemanticAnalysis): Use `this' instead of our parent to
14660 resolve names. Because we need to be resolve in our context, not
14663 * driver.cs: Implement response files.
14665 * class.cs (TypeContainer.DefineType): If we are defined, do not
14666 redefine ourselves.
14668 (Event.Emit): Emit the code for add/remove handlers.
14669 (Event.Define): Save the MethodBuilders for add/remove.
14671 * typemanager.cs: Use pair here too.
14673 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
14674 DictionaryEntry requires the first argument to be non-null.
14676 (enum_declaration): Compute full name for registering the
14679 (delegate_declaration): Instead of using
14680 formal_parameter_list, use opt_formal_parameter_list as the list
14683 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
14684 (EventParsing): New property that controls whether `add' and
14685 `remove' are returned as tokens or identifiers (for events);
14687 2001-12-19 Ravi Pratap <ravi@ximian.com>
14689 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
14690 use MyEventBuilder only and let it wrap the real builder for us.
14692 (MyEventBuilder): Revamp constructor etc.
14694 Implement all operations that we perform on EventBuilder in precisely the same
14697 (FindMembers): Update to use the EventBuilder member.
14699 (Event.Emit): Update accordingly.
14701 2001-12-18 Ravi Pratap <ravi@ximian.com>
14703 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
14704 by calling the appropriate methods.
14706 (GetCustomAttributes): Make stubs as they cannot possibly do anything
14709 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
14711 2001-12-17 Ravi Pratap <ravi@ximian.com>
14713 * delegate.cs (Delegate.Populate): Check that the return type
14714 and various parameters types are indeed accessible.
14716 * class.cs (Constructor.Define): Same here.
14718 (Field.Define): Ditto.
14720 (Event.Define): Ditto.
14722 (Operator.Define): Check that the underlying Method defined itself
14723 correctly - so it's MethodBuilder should not be null.
14725 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
14726 expression happens to be null.
14728 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
14729 members but as of now we don't seem to be able to do anything really useful with it.
14731 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
14732 not the EventBuilder.
14734 2001-12-18 Miguel de Icaza <miguel@ximian.com>
14736 * cs-tokenizer.cs: Add support for defines.
14737 Add support for #if, #elif, #else, #endif
14739 (eval_var): evaluates a variable.
14740 (eval): stubbed for evaluating functions.
14742 * cs-parser.jay: Pass the defines information
14744 * driver.cs: Add --define command line option.
14746 * decl.cs: Move MemberCore here.
14748 Make it the base class for DeclSpace. This allows us to catch and
14749 report 108 and 109 for everything now.
14751 * class.cs (TypeContainer.Define): Extract all the members
14752 before populating and emit the warning 108 (new keyword required
14753 to override) instead of having each member implement this.
14755 (MemberCore.Define): New abstract method, we will be using this in
14756 the warning reporting engine in Populate.
14758 (Operator.Define): Adjust to new MemberCore protocol.
14760 * const.cs (Const): This does not derive from Expression, it is a
14761 temporary object we use to create fields, it is a MemberCore.
14763 * class.cs (Method.Define): Allow the entry point to be in a
14766 * driver.cs: Rewrite the argument handler to clean it up a bit.
14768 * rootcontext.cs: Made it just an auxiliary namespace feature by
14769 making everything static.
14771 * driver.cs: Adapt code to use RootContext type name instead of
14774 * delegate.cs: Remove RootContext argument.
14776 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
14779 * class.cs (Event.Define): The lookup can fail.
14781 * cs-tokenizer.cs: Begin implementation of pre-procesor.
14783 * expression.cs: Resolve the this instance before invoking the code.
14785 2001-12-17 Miguel de Icaza <miguel@ximian.com>
14787 * cs-parser.jay: Add a production in element_access that allows
14788 the thing to become a "type" reference. This way we can parse
14789 things like "(string [])" as a type.
14791 Note that this still does not handle the more complex rules of
14795 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
14797 * ecore.cs: (CopyNewMethods): new utility function used to
14798 assemble the list of methods from running FindMembers.
14800 (MemberLookup): Rework FindMembers so that
14802 2001-12-16 Miguel de Icaza <miguel@ximian.com>
14804 * class.cs (TypeContainer): Remove Delegates who fail to be
14807 * delegate.cs (Populate): Verify that we dont get null return
14808 values. TODO: Check for AsAccessible.
14810 * cs-parser.jay: Use basename to emit error 574 (destructor should
14811 have the same name as container class), not the full name.
14813 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
14814 possible representation.
14816 Also implements integer type suffixes U and L.
14818 2001-12-15 Miguel de Icaza <miguel@ximian.com>
14820 * expression.cs (ArrayCreation.DoResolve): We need to do the
14821 argument resolution *always*.
14823 * decl.cs: Make this hold the namespace. Hold the root context as
14825 (LookupType): Move here.
14827 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
14829 * location.cs (Row, Name): Fixed the code, it was always returning
14830 references to the first file.
14832 * interface.cs: Register properties defined through interfaces.
14834 * driver.cs: Add support for globbing on the command line
14836 * class.cs (Field): Make it derive from MemberCore as well.
14839 2001-12-15 Ravi Pratap <ravi@ximian.com>
14841 * class.cs (Event::Define): Check that the type of the event is a delegate
14842 type else flag error #66.
14844 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
14847 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
14848 values of EntryPoint, CharSet etc etc.
14850 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
14852 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
14853 be null and we should ignore this. I am not sure if this is really clean. Apparently,
14854 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
14855 which needs this to do its work.
14857 * ../errors/cs0066.cs : Add.
14859 2001-12-14 Miguel de Icaza <miguel@ximian.com>
14861 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
14864 * class.cs: (MethodSignature.MethodSignature): Removed hack that
14865 clears out the parameters field.
14866 (MemberSignatureCompare): Cleanup
14868 (MemberCore): New base class used to share code between MethodCore
14871 (RegisterRequiredImplementations) BindingFlags.Public requires
14872 either BindingFlags.Instace or Static. Use instance here.
14874 (Property): Refactored code to cope better with the full spec.
14876 * parameter.cs (GetParameterInfo): Return an empty array instead
14879 * class.cs (Property): Abstract or extern properties have no bodies.
14881 * parameter.cs (GetParameterInfo): return a zero-sized array.
14883 * class.cs (TypeContainer.MethodModifiersValid): Move all the
14884 method modifier validation to the typecontainer so we can reuse
14885 this on properties.
14887 (MethodCore.ParameterTypes): return an empty sized array of types.
14889 (Property.Define): Test property modifier validity.
14891 Add tests for sealed/override too.
14893 (Method.Emit): abstract or extern methods have no bodies.
14895 2001-12-14 Ravi Pratap <ravi@ximian.com>
14897 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
14900 (Method::Define, ::Emit): Modify accordingly.
14902 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
14904 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
14906 * makefile: Pass in /unsafe.
14908 2001-12-13 Miguel de Icaza <miguel@ximian.com>
14910 * class.cs (MakeKey): Kill routine.
14912 * class.cs (TypeContainer.Define): Correctly define explicit
14913 method implementations (they require the full interface name plus
14916 * typemanager.cs: Deply the PtrHashtable here and stop using the
14917 lame keys. Things work so much better.
14919 This of course broke everyone who depended on `RegisterMethod' to
14920 do the `test for existance' test. This has to be done elsewhere.
14922 * support.cs (PtrHashtable): A hashtable that avoid comparing with
14923 the object stupid Equals method (because, that like fails all over
14924 the place). We still do not use it.
14926 * class.cs (TypeContainer.SetRequiredInterface,
14927 TypeContainer.RequireMethods): Killed these two routines and moved
14928 all the functionality to RegisterRequiredImplementations.
14930 (TypeContainer.RegisterRequiredImplementations): This routine now
14931 registers all the implementations required in an array for the
14932 interfaces and abstract methods. We use an array of structures
14933 which can be computed ahead of time to reduce memory usage and we
14934 also assume that lookups are cheap as most classes will not
14935 implement too many interfaces.
14937 We also avoid creating too many MethodSignatures.
14939 (TypeContainer.IsInterfaceMethod): Update and optionally does not
14940 clear the "pending" bit if we find that there are problems with
14943 (TypeContainer.VerifyPendingMethods): Update to report errors of
14944 methods that look like implementations but are not.
14946 (TypeContainer.Define): Add support for explicit interface method
14949 2001-12-12 Miguel de Icaza <miguel@ximian.com>
14951 * typemanager.cs: Keep track of the parameters here instead of
14952 being a feature of the TypeContainer.
14954 * class.cs: Drop the registration of parameters here, as
14955 InterfaceMethods are also interface declarations.
14957 * delegate.cs: Register methods with the TypeManager not only with
14958 the TypeContainer. This code was buggy.
14960 * interface.cs: Full registation here.
14962 2001-12-11 Miguel de Icaza <miguel@ximian.com>
14964 * expression.cs: Remove reducer for binary expressions, it can not
14967 * const.cs: Put here the code that used to go into constant.cs
14969 * constant.cs: Put here the code for constants, this is a new base
14970 class for Literals.
14972 * literal.cs: Make Literal derive from Constant.
14974 2001-12-09 Miguel de Icaza <miguel@ximian.com>
14976 * statement.cs (Return.Emit): Report error 157 if the user
14977 attempts to return from a finally block.
14979 (Return.Emit): Instead of emitting a return, jump to the end of
14982 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
14983 LocalBuilder to store the result of the function. ReturnLabel is
14984 the target where we jump.
14987 2001-12-09 Radek Doulik <rodo@ximian.com>
14989 * cs-parser.jay: remember alias in current namespace
14991 * ecore.cs (SimpleName::DoResolve): use aliases for types or
14994 * class.cs (LookupAlias): lookup alias in my_namespace
14996 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
14998 (LookupAlias): lookup alias in this and if needed in parent
15001 2001-12-08 Miguel de Icaza <miguel@ximian.com>
15005 * rootcontext.cs: (ModuleBuilder) Made static, first step into
15006 making things static. I need this to avoid passing the
15007 TypeContainer when calling ParameterType.
15009 * support.cs (InternalParameters.ParameterType): Remove ugly hack
15010 that did string manipulation to compute the type and then call
15011 GetType. Use Parameter.ParameterType instead.
15013 * cs-tokenizer.cs: Consume the suffix for floating values.
15015 * expression.cs (ParameterReference): figure out whether this is a
15016 reference parameter or not. Kill an extra variable by computing
15017 the arg_idx during emission.
15019 * parameter.cs (Parameters.GetParameterInfo): New overloaded
15020 function that returns whether a parameter is an out/ref value or not.
15022 (Parameter.ParameterType): The type of the parameter (base,
15023 without ref/out applied).
15025 (Parameter.Resolve): Perform resolution here.
15026 (Parameter.ExternalType): The full type (with ref/out applied).
15028 * statement.cs (Using.Emit, Using.EmitExpression): Implement
15029 support for expressions on the using statement.
15031 2001-12-07 Miguel de Icaza <miguel@ximian.com>
15033 * statement.cs (Using.EmitLocalVariableDecls): Split the
15034 localvariable handling of the using statement.
15036 (Block.EmitMeta): Keep track of variable count across blocks. We
15037 were reusing slots on separate branches of blocks.
15039 (Try.Emit): Emit the general code block, we were not emitting it.
15041 Check the type of the declaration to be an IDisposable or
15042 something that can be implicity converted to it.
15044 Emit conversions if required.
15046 * ecore.cs (EmptyExpression): New utility class.
15047 (Expression.ImplicitConversionExists): New utility function.
15049 2001-12-06 Miguel de Icaza <miguel@ximian.com>
15051 * statement.cs (Using): Implement.
15053 * expression.cs (LocalVariableReference): Support read only variables.
15055 * statement.cs: Remove the explicit emit for the Leave opcode.
15056 (VariableInfo): Add a readonly field.
15058 2001-12-05 Miguel de Icaza <miguel@ximian.com>
15060 * ecore.cs (ConvCast): new class used to encapsulate the various
15061 explicit integer conversions that works in both checked and
15062 unchecked contexts.
15064 (Expression.ConvertNumericExplicit): Use new ConvCast class to
15065 properly generate the overflow opcodes.
15067 2001-12-04 Miguel de Icaza <miguel@ximian.com>
15069 * statement.cs: The correct type for the EmptyExpression is the
15070 element_type, not the variable type. Ravi pointed this out.
15072 2001-12-04 Ravi Pratap <ravi@ximian.com>
15074 * class.cs (Method::Define): Handle PInvoke methods specially
15075 by using DefinePInvokeMethod instead of the usual one.
15077 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
15078 above to do the task of extracting information and defining the method.
15080 2001-12-04 Ravi Pratap <ravi@ximian.com>
15082 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
15083 of the condition for string type.
15085 (Emit): Move that here.
15087 (ArrayCreation::CheckIndices): Keep string literals in their expression
15090 (EmitDynamicInitializers): Handle strings appropriately.
15092 2001-12-04 Miguel de Icaza <miguel@ximian.com>
15094 * codegen.cs (EmitContext): Replace multiple variables with a
15095 single pointer to the current Switch statement.
15097 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
15100 2001-12-03 Miguel de Icaza <miguel@ximian.com>
15104 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
15107 (Foreach.Emit): Foreach on arrays was not setting
15108 up the loop variables (for break/continue).
15110 (GotoCase): Semi-implented.
15112 2001-12-03 Ravi Pratap <ravi@ximian.com>
15114 * attribute.cs (CheckAttribute): Handle system attributes by using
15115 Attribute.GetAttributes to examine information we need.
15117 (GetValidPlaces): Same here.
15119 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
15121 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
15123 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
15125 (Method::Define): Set appropriate flags if we have a DllImport attribute.
15127 (Method::Emit): Handle the case when we are a PInvoke method.
15129 2001-12-03 Miguel de Icaza <miguel@ximian.com>
15131 * expression.cs: Use ResolveWithSimpleName on compound names.
15133 2001-12-02 Ravi Pratap <ravi@ximian.com>
15135 * constant.cs (EmitConstant): Make sure we resolve the associated expression
15136 before trying to reduce it.
15138 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
15140 * constant.cs (LookupConstantValue): Implement.
15142 (EmitConstant): Use the above in emitting the constant.
15144 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
15145 that are user-defined by doing a LookupConstantValue on them.
15147 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
15150 2001-11-29 Miguel de Icaza <miguel@ximian.com>
15152 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
15154 (BaseAccess.DoResolve): Implement.
15156 (MemberAccess.DoResolve): Split this routine into a
15157 ResolveMemberAccess routine that can be used independently
15159 2001-11-28 Miguel de Icaza <miguel@ximian.com>
15161 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
15162 As that share bits of the implementation. Is returns a boolean,
15163 while As returns the Type that is being probed.
15165 2001-12-01 Ravi Pratap <ravi@ximian.com>
15167 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
15168 instead of a Literal - much easier.
15170 (EnumInTransit): Remove - utterly useless :-)
15172 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
15174 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
15176 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
15177 chain when we have no associated expression.
15179 2001-11-30 Ravi Pratap <ravi@ximian.com>
15181 * constant.cs (Define): Use Location while reporting the errror.
15183 Also emit a warning when 'new' is used and there is no inherited
15186 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
15189 (LookupEnumValue): Implement to lookup an enum member's value and define it
15192 (Populate): Re-write accordingly to use the above routine.
15194 2001-11-27 Miguel de Icaza <miguel@ximian.com>
15196 * expression.cs (This): Fix prototype for DoResolveLValue to
15197 override the base class DoResolveLValue.
15199 * cs-parser.cs: Report errors cs574 and cs575 (destructor
15202 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
15203 (we need to load the address of the field here). This fixes
15206 (FieldExpr.DoResolveLValue): Call the DoResolve
15207 function to initialize the Instance expression.
15209 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
15210 correctly the GetEnumerator operation on a value type.
15212 * cs-parser.jay: Add more simple parsing error catches.
15214 * statement.cs (Switch): Add support for string switches.
15215 Handle null specially.
15217 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
15219 2001-11-28 Ravi Pratap <ravi@ximian.com>
15221 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
15223 (declare_local_constant): New helper function.
15225 * statement.cs (AddConstant): Keep a separate record of constants
15227 (IsConstant): Implement to determine if a variable is a constant.
15229 (GetConstantExpression): Implement.
15231 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
15233 * statement.cs (IsVariableDefined): Re-write.
15235 2001-11-27 Ravi Pratap <ravi@ximian.com>
15237 * class.cs (TypeContainer::FindMembers): Look for constants
15238 in the case when we are looking for MemberTypes.Field
15240 * expression.cs (MemberAccess::DoResolve): Check that in the
15241 case we are a FieldExpr and a Literal, we are not being accessed
15242 by an instance reference.
15244 * cs-parser.jay (local_constant_declaration): Implement.
15246 (declaration_statement): Implement for constant declarations.
15248 2001-11-26 Miguel de Icaza <miguel@ximian.com>
15250 * statement.cs (Switch): Catch double defaults.
15252 (Switch): More work on the switch() statement
15253 implementation. It works for integral values now, need to finish
15257 2001-11-24 Miguel de Icaza <miguel@ximian.com>
15259 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
15260 integer literals into other integer literals. To be used by
15263 2001-11-24 Ravi Pratap <ravi@ximian.com>
15265 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
15268 (EmitDynamicInitializers): Cope with the above since we extract data
15269 directly from ArrayData now.
15271 (ExpectInitializers): Keep track of whether initializers are mandatory
15274 (Bounds): Make it a hashtable to prevent the same dimension being
15275 recorded for every element in that dimension.
15277 (EmitDynamicInitializers): Fix bug which prevented the Set array method
15280 Also fix bug which was causing the indices to be emitted in the reverse
15283 2001-11-24 Miguel de Icaza <miguel@ximian.com>
15285 * expression.cs (ArrayCreation): Implement the bits that Ravi left
15286 unfinished. They do not work, because the underlying code is
15289 2001-11-22 Miguel de Icaza <miguel@ximian.com>
15291 * cs-parser.jay: Remove bogus fixme.
15293 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
15294 on Switch statement.
15296 2001-11-23 Ravi Pratap <ravi@ximian.com>
15298 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
15301 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
15302 parameter. Apparently, any expression is allowed.
15304 (ValidateInitializers): Update accordingly.
15306 (CheckIndices): Fix some tricky bugs thanks to recursion.
15308 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
15309 I was being completely brain-dead.
15311 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
15312 and re-write acordingly.
15314 (DelegateInvocation): Re-write accordingly.
15316 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
15318 (MakeByteBlob): Handle types more correctly.
15320 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
15321 initialization from expressions but it is incomplete because I am a complete
15324 2001-11-22 Miguel de Icaza <miguel@ximian.com>
15326 * statement.cs (If.Emit): Fix a bug that generated incorrect code
15327 on If. Basically, we have to return `true' (ie, we do return to
15328 our caller) only if both branches of the if return.
15330 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
15331 short-circuit operators, handle them as short circuit operators.
15333 (Cast.DoResolve): Resolve type.
15334 (Cast.Cast): Take an expression as the target type.
15336 * cs-parser.jay (cast_expression): Remove old hack that only
15337 allowed a limited set of types to be handled. Now we take a
15338 unary_expression and we resolve to a type during semantic
15341 Use the grammar productions from Rhys to handle casts (this is
15342 not complete like Rhys syntax yet, we fail to handle that corner
15343 case that C# has regarding (-x), but we will get there.
15345 2001-11-22 Ravi Pratap <ravi@ximian.com>
15347 * class.cs (EmitFieldInitializer): Take care of the case when we have a
15348 field which is an array type.
15350 * cs-parser.jay (declare_local_variables): Support array initialization too.
15352 * typemanager.cs (MakeKey): Implement.
15354 (everywhere): Use the above appropriately.
15356 * cs-parser.jay (for_statement): Update for array initialization while
15357 declaring variables.
15359 * ecore.cs : The error message was correct, it's the variable's names that
15360 were misleading ;-) Make the code more readable.
15362 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
15363 the correct type etc.
15365 (ConvertExplicit): Handle Enum types by examining the underlying type.
15367 2001-11-21 Ravi Pratap <ravi@ximian.com>
15369 * parameter.cs (GetCallingConvention): Always return
15370 CallingConventions.Standard for now.
15372 2001-11-22 Miguel de Icaza <miguel@ximian.com>
15374 * expression.cs (Binary.ResolveOperator): Update the values of `l'
15375 and `r' after calling DoNumericPromotions.
15377 * ecore.cs: Fix error message (the types were in the wrong order).
15379 * statement.cs (Foreach.ProbeCollectionType): Need to pass
15380 BindingFlags.Instance as well
15382 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
15383 implicit int literal conversion in an empty cast so that we
15384 propagate the right type upstream.
15386 (UnboxCast): new class used to unbox value types.
15387 (Expression.ConvertExplicit): Add explicit type conversions done
15390 (Expression.ImplicitNumericConversion): Oops, forgot to test for
15391 the target type before applying the implicit LongLiterals to ULong
15394 2001-11-21 Miguel de Icaza <miguel@ximian.com>
15396 * cs-parser.jay (for_statement): Reworked the way For works: now
15397 we declare manually any variables that are introduced in
15398 for_initializer to solve the problem of having out-of-band code
15399 emition (that is what got for broken).
15401 (declaration_statement): Perform the actual variable declaration
15402 that used to be done in local_variable_declaration here.
15404 (local_variable_declaration): Do not declare anything, just pass
15405 the information on a DictionaryEntry
15407 2001-11-20 Ravi Pratap <ravi@ximian.com>
15409 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
15410 re-write of the logic to now make it recursive.
15412 (UpdateIndices): Re-write accordingly.
15414 Store element data in a separate ArrayData list in the above methods.
15416 (MakeByteBlob): Implement to dump the array data into a byte array.
15418 2001-11-19 Ravi Pratap <ravi@ximian.com>
15420 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
15423 * constant.cs (Define): Implement.
15425 (EmitConstant): Re-write fully.
15427 Pass in location info.
15429 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
15432 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
15433 DictionaryEntry since we need location info too.
15435 (constant_declaration): Update accordingly.
15437 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
15438 code into another method : UpdateIndices.
15440 2001-11-18 Ravi Pratap <ravi@ximian.com>
15442 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
15443 some type checking etc.
15445 2001-11-17 Ravi Pratap <ravi@ximian.com>
15447 * expression.cs (ArrayCreation::ValidateInitializers): Implement
15448 bits to provide dimension info if the user skips doing that.
15450 Update second constructor to store the rank correctly.
15452 2001-11-16 Ravi Pratap <ravi@ximian.com>
15454 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
15455 and try to implement.
15457 * ../errors/cs0150.cs : Add.
15459 * ../errors/cs0178.cs : Add.
15461 2001-11-16 Miguel de Icaza <miguel@ximian.com>
15463 * statement.cs: Implement foreach on multi-dimensional arrays.
15465 * parameter.cs (Parameters.GetParameterByName): Also lookup the
15466 name of the params argument.
15468 * expression.cs: Use EmitStoreOpcode to get the right opcode while
15469 initializing the array.
15471 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
15472 we can use this elsewhere.
15474 * statement.cs: Finish implementation of foreach for single
15477 * cs-parser.jay: Use an out-of-band stack to pass information
15478 around, I wonder why I need this.
15480 foreach_block: Make the new foreach_block the current_block.
15482 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
15483 function used to return a static Parameters structure. Used for
15484 empty parameters, as those are created very frequently.
15486 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
15488 2001-11-15 Ravi Pratap <ravi@ximian.com>
15490 * interface.cs : Default modifier is private, not public. The
15491 make verify test passes again.
15493 2001-11-15 Ravi Pratap <ravi@ximian.com>
15495 * support.cs (ReflectionParameters): Fix logic to determine
15496 whether the last parameter is a params one. Test 9 passes again.
15498 * delegate.cs (Populate): Register the builders we define with
15499 RegisterParameterForBuilder. Test 19 passes again.
15501 * cs-parser.jay (property_declaration): Reference $6 instead
15502 of $$ to get at the location.
15504 (indexer_declaration): Similar stuff.
15506 (attribute): Ditto.
15508 * class.cs (Property): Register parameters for the Get and Set methods
15509 if they exist. Test 23 passes again.
15511 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
15512 call to EmitArguments as we are sure there aren't any params arguments.
15513 Test 32 passes again.
15515 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
15516 IndexOutOfRangeException.
15518 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
15519 Test 33 now passes again.
15521 2001-11-15 Miguel de Icaza <miguel@ximian.com>
15523 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
15524 broke a bunch of things. Will have to come up with a better way
15525 of tracking locations.
15527 * statement.cs: Implemented foreach for single dimension arrays.
15529 2001-11-09 Miguel de Icaza <miguel@ximian.com>
15531 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
15532 an error. This removes the lookup from the critical path.
15534 * cs-parser.jay: Removed use of temporary_loc, which is completely
15537 2001-11-14 Miguel de Icaza <miguel@ximian.com>
15539 * support.cs (ReflectionParameters.ParameterModifier): Report
15540 whether the argument is a PARAMS argument or not.
15542 * class.cs: Set the attribute `ParamArrayAttribute' on the
15543 parameter argument.
15545 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
15546 and cons_param_array_attribute (ConstructorInfo for
15547 ParamArrayAttribute).,
15549 * codegen.cs: Emit the return using the `Return' statement, that
15550 way we can report the error correctly for missing return values.
15552 * class.cs (Method.Emit): Clean up.
15554 * expression.cs (Argument.Resolve): Take another argument: the
15555 location where this argument is used. Notice that this is not
15556 part of the "Argument" class as to reduce the size of the
15557 structure (we know the approximate location anyways).
15559 Test if the argument is a variable-reference, if not, then
15560 complain with a 206.
15562 (Argument.Emit): Emit addresses of variables.
15564 (Argument.FullDesc): Simplify.
15566 (Invocation.DoResolve): Update for Argument.Resolve.
15568 (ElementAccess.DoResolve): ditto.
15570 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
15571 method should be virtual, as this method is always virtual.
15573 (NewDelegate.DoResolve): Update for Argument.Resolve.
15575 * class.cs (ConstructorInitializer.DoResolve): ditto.
15577 * attribute.cs (Attribute.Resolve): ditto.
15579 2001-11-13 Miguel de Icaza <miguel@ximian.com>
15581 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
15583 * expression.cs (ParameterReference): Drop IStackStorage and implement
15584 IAssignMethod instead.
15586 (LocalVariableReference): ditto.
15588 * ecore.cs (FieldExpr): Drop IStackStorage and implement
15589 IAssignMethod instead.
15591 2001-11-13 Miguel de Icaza <miguel@ximian.com>
15593 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
15594 enumerations that are used in heavily used structures derive from
15595 byte in a laughable and pathetic attempt to reduce memory usage.
15596 This is the kind of pre-optimzations that you should not do at
15597 home without adult supervision.
15599 * expression.cs (UnaryMutator): New class, used to handle ++ and
15600 -- separatedly from the other unary operators. Cleans up the
15601 code, and kills the ExpressionStatement dependency in Unary.
15603 (Unary): Removed `method' and `Arguments' from this class, making
15604 it smaller, and moving it all to SimpleCall, so I can reuse this
15605 code in other locations and avoid creating a lot of transient data
15606 strucutres when not required.
15608 * cs-parser.jay: Adjust for new changes.
15610 2001-11-11 Miguel de Icaza <miguel@ximian.com>
15612 * enum.cs (Enum.Populate): If there is a failure during
15615 * cs-parser.jay (opt_enum_base): we used to catch type errors
15616 here, but this is really incorrect. The type error should be
15617 catched during semantic analysis.
15619 2001-12-11 Ravi Pratap <ravi@ximian.com>
15621 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
15622 current_local_parameters as expected since I, in my stupidity, had forgotten
15625 * attribute.cs (GetValidPlaces): Fix stupid bug.
15627 * class.cs (Method::Emit): Perform check on applicability of attributes.
15629 (Constructor::Emit): Ditto.
15631 (Field::Emit): Ditto.
15633 (Field.Location): Store location information.
15635 (Property, Event, Indexer, Operator): Ditto.
15637 * cs-parser.jay (field_declaration): Pass in location for each field.
15639 * ../errors/cs0592.cs : Add.
15641 2001-11-12 Ravi Pratap <ravi@ximian.com>
15643 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
15645 (InitCoreTypes): Update accordingly.
15647 (RegisterAttrType, LookupAttr): Implement.
15649 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
15650 info about the same.
15652 (Resolve): Update to populate the above as necessary.
15654 (Error592): Helper.
15656 (GetValidPlaces): Helper to the above.
15658 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
15660 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
15662 2001-11-12 Ravi Pratap <ravi@ximian.com>
15664 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
15666 * ../errors/cs0617.cs : Add.
15668 2001-11-11 Ravi Pratap <ravi@ximian.com>
15670 * enum.cs (Emit): Rename to Populate to be more consistent with what
15671 we expect it to do and when exactly it is called.
15673 * class.cs, rootcontext.cs : Update accordingly.
15675 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
15676 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
15678 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
15680 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
15681 of a fieldinfo using the above, when dealing with a FieldBuilder.
15683 2001-11-10 Ravi Pratap <ravi@ximian.com>
15685 * ../errors/cs0031.cs : Add.
15687 * ../errors/cs1008.cs : Add.
15689 * ../errrors/cs0543.cs : Add.
15691 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
15694 (FindMembers): Implement.
15696 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
15697 enums and delegates too.
15699 (enum_types): Rename to builder_to_enum.
15701 (delegate_types): Rename to builder_to_delegate.
15703 * delegate.cs (FindMembers): Implement.
15705 2001-11-09 Ravi Pratap <ravi@ximian.com>
15707 * typemanager.cs (IsEnumType): Implement.
15709 * enum.cs (Emit): Re-write parts to account for the underlying type
15710 better and perform checking etc.
15712 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
15713 of the underlying type.
15715 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
15718 * enum.cs (error31): Helper to report error #31.
15720 * cs-parser.jay (enum_declaration): Store location of each member too.
15722 * enum.cs (member_to_location): New hashtable.
15724 (AddEnumMember): Update location hashtable.
15726 (Emit): Use the location of each member while reporting errors.
15728 2001-11-09 Miguel de Icaza <miguel@ximian.com>
15730 * cs-parser.jay: A for_initializer if is a
15731 local_variable_declaration really ammount to have an implicit
15732 block with the variable declaration and no initializer for for.
15734 * statement.cs (For.Emit): Cope with null initializers.
15736 This fixes the infinite loop on for initializers.
15738 2001-11-08 Miguel de Icaza <miguel@ximian.com>
15740 * enum.cs: More cleanup.
15742 * ecore.cs: Remove dead code.
15744 * class.cs (Property.Emit): More simplification.
15745 (Event.Emit): ditto.
15747 Reworked to have less levels of indentation.
15749 2001-11-08 Ravi Pratap <ravi@ximian.com>
15751 * class.cs (Property): Emit attributes.
15761 * enum.cs (Emit): Ditto.
15763 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
15766 * class.cs (Field, Event, etc.): Move attribute generation into the
15767 Emit method everywhere.
15769 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
15770 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
15771 as we had no way of defining nested enums !
15773 * rootcontext.cs : Adjust code accordingly.
15775 * typemanager.cs (AddEnumType): To keep track of enum types separately.
15777 2001-11-07 Ravi Pratap <ravi@ximian.com>
15779 * expression.cs (EvalConstantExpression): Move into ecore.cs
15781 * enum.cs (Enum): Rename some members and make them public and readonly
15782 according to our convention.
15784 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
15787 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
15789 (Enum::Emit): Write a simple version for now which doesn't try to compute
15790 expressions. I shall modify this to be more robust in just a while.
15792 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
15794 (TypeContainer::CloseType): Create the Enum types too.
15796 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
15798 * expression.cs (EvalConstantExpression): Get rid of completely.
15800 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
15801 user-defined values and other cases.
15803 (IsValidEnumLiteral): Helper function.
15805 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
15806 out there in the case we had a literal FieldExpr.
15808 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
15810 (Literalize): Revamp a bit to take two arguments.
15812 (EnumLiteral): New class which derives from Literal to wrap enum literals.
15814 2001-11-06 Ravi Pratap <ravi@ximian.com>
15816 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
15818 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
15820 (Resolve): Use the above to ensure we have proper initializers.
15822 2001-11-05 Ravi Pratap <ravi@ximian.com>
15824 * expression.cs (Expression::EvalConstantExpression): New method to
15825 evaluate constant expressions.
15827 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
15829 2001-11-07 Miguel de Icaza <miguel@ximian.com>
15831 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
15834 (Binary.ResolveOperator): Handle operator != (object a, object b)
15835 and operator == (object a, object b);
15837 (Binary.DoNumericPromotions): Indicate whether the numeric
15838 promotion was possible.
15840 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
15843 Made the ArrayAccess implement interface IAssignMethod instead of
15844 IStackStore as the order in which arguments are passed reflects
15847 * assign.cs: Instead of using expr.ExprClass to select the way of
15848 assinging, probe for the IStackStore/IAssignMethod interfaces.
15850 * typemanager.cs: Load InitializeArray definition.
15852 * rootcontext.cs (RootContext.MakeStaticData): Used to define
15853 static data that can be used to initialize arrays.
15855 2001-11-05 Miguel de Icaza <miguel@ximian.com>
15857 * expression.cs: Handle operator== and operator!= for booleans.
15859 (Conditioal.Reduce): Implement reducer for the ?: operator.
15861 (Conditional.Resolve): Implement dead code elimination.
15863 (Binary.Resolve): Catch string literals and return a new
15864 concatenated string.
15866 (Unary.Reduce): Implement reduction of unary expressions.
15868 * ecore.cs: Split out the expression core handling here.
15870 (Expression.Reduce): New method used to perform constant folding
15871 and CSE. This is needed to support constant-expressions.
15873 * statement.cs (Statement.EmitBoolExpression): Pass true and false
15874 targets, and optimize for !x.
15876 2001-11-04 Ravi Pratap <ravi@ximian.com>
15878 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
15879 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
15880 set custom atttributes.
15882 * literal.cs (Literal::GetValue): New abstract method to return the actual
15883 value of the literal, cast as an object.
15885 (*Literal): Implement GetValue method.
15887 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
15888 expressions to the arraylist but objects of type Argument.
15890 * class.cs (TypeContainer::Emit): Emit our attributes too.
15892 (Method::Emit, Constructor::Emit): Ditto.
15894 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
15895 to be ignoring earlier.
15897 2001-11-03 Ravi Pratap <ravi@ximian.com>
15899 * attribute.cs (AttributeSection::Define): Implement to do the business
15900 of constructing a CustomAttributeBuilder.
15902 (Attribute): New trivial class. Increases readability of code.
15904 * cs-parser.jay : Update accordingly.
15906 (positional_argument_list, named_argument_list, named_argument): New rules
15908 (attribute_arguments): Use the above so that we are more correct.
15910 2001-11-02 Ravi Pratap <ravi@ximian.com>
15912 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
15913 to perform all checks for a method with a params parameter.
15915 (Invocation::OverloadResolve): Update to use the above method and therefore
15916 cope correctly with params method invocations.
15918 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
15921 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
15922 constructors in our parent too because we can't afford to miss out on
15925 * attribute.cs (AttributeSection): New name for the class Attribute
15927 Other trivial changes to improve readability.
15929 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
15930 use the new class names.
15932 2001-11-01 Ravi Pratap <ravi@ximian.com>
15934 * class.cs (Method::Define): Complete definition for params types too
15936 (Indexer::Define): Ditto.
15938 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
15939 Cope everywhere with a request for info about the array parameter.
15941 2001-11-01 Ravi Pratap <ravi@ximian.com>
15943 * tree.cs (RecordNamespace): Fix up to check for the correct key.
15945 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
15946 local_variable_type to extract the string corresponding to the type.
15948 (local_variable_type): Fixup the action to use the new helper method.
15950 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
15953 * expression.cs : Clean out code which uses the above.
15955 2001-10-31 Ravi Pratap <ravi@ximian.com>
15957 * typemanager.cs (RegisterMethod): Check if we already have an existing key
15958 and bale out if necessary by returning a false.
15960 (RegisterProperty): Ditto.
15962 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
15963 and print out appropriate error messages.
15965 * interface.cs (everywhere): Ditto.
15967 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
15968 location to constructor.
15970 * class.cs (Property, Event, Indexer): Update accordingly.
15972 * ../errors/cs111.cs : Added.
15974 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
15975 of a method, as laid down by the spec.
15977 (Invocation::OverloadResolve): Use the above method.
15979 2001-10-31 Ravi Pratap <ravi@ximian.com>
15981 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
15982 now take a TypeContainer and a Parameters object.
15984 (ParameterData): Modify return type of ParameterModifier method to be
15985 Parameter.Modifier and not a string.
15987 (ReflectionParameters, InternalParameters): Update accordingly.
15989 * expression.cs (Argument::GetParameterModifier): Same here.
15991 * support.cs (InternalParameters::ParameterType): Find a better way of determining
15992 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
15993 symbol in it at all so maybe this is only for now.
15995 2001-10-30 Ravi Pratap <ravi@ximian.com>
15997 * support.cs (InternalParameters): Constructor now takes an extra argument
15998 which is the actual Parameters class.
16000 (ParameterDesc): Update to provide info on ref/out modifiers.
16002 * class.cs (everywhere): Update call to InternalParameters to pass in
16003 the second argument too.
16005 * support.cs (ParameterData): Add ParameterModifier, which is a method
16006 to return the modifier info [ref/out etc]
16008 (InternalParameters, ReflectionParameters): Implement the above.
16010 * expression.cs (Argument::ParameterModifier): Similar function to return
16011 info about the argument's modifiers.
16013 (Invocation::OverloadResolve): Update to take into account matching modifiers
16016 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
16017 a new SetFormalParameters object which we pass to InternalParameters.
16019 2001-10-30 Ravi Pratap <ravi@ximian.com>
16021 * expression.cs (NewArray): Merge into the ArrayCreation class.
16023 2001-10-29 Ravi Pratap <ravi@ximian.com>
16025 * expression.cs (NewArray): Merge classes NewBuiltinArray and
16026 NewUserdefinedArray into one as there wasn't much of a use in having
16029 * expression.cs (Argument): Change field's name to ArgType from Type.
16031 (Type): New readonly property which returns the proper type, taking into
16032 account ref/out modifiers.
16034 (everywhere): Adjust code accordingly for the above.
16036 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
16037 whether we are emitting for a ref or out parameter.
16039 * expression.cs (Argument::Emit): Use the above field to set the state.
16041 (LocalVariableReference::Emit): Update to honour the flag and emit the
16044 * parameter.cs (Attributes): Set the correct flags for ref parameters.
16046 * expression.cs (Argument::FullDesc): New function to provide a full desc.
16048 * support.cs (ParameterData): Add method ParameterDesc to the interface.
16050 (ReflectionParameters, InternalParameters): Implement the above method.
16052 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
16055 (Invocation::FullMethodDesc): Ditto.
16057 2001-10-29 Miguel de Icaza <miguel@ximian.com>
16059 * cs-parser.jay: Add extra production for the second form of array
16062 * expression.cs (ArrayCreation): Update to reflect the above
16065 * Small changes to prepare for Array initialization.
16067 2001-10-28 Miguel de Icaza <miguel@ximian.com>
16069 * typemanager.cs (ImplementsInterface): interface might be null;
16070 Deal with this problem;
16072 Also, we do store negative hits on the cache (null values), so use
16073 this instead of calling t.GetInterfaces on the type everytime.
16075 2001-10-28 Ravi Pratap <ravi@ximian.com>
16077 * typemanager.cs (IsBuiltinType): New method to help determine the same.
16079 * expression.cs (New::DoResolve): Get rid of array creation code and instead
16080 split functionality out into different classes.
16082 (New::FormArrayType): Move into NewBuiltinArray.
16084 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
16087 (NewBuiltinArray): New class to handle creation of built-in arrays.
16089 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
16090 account creation of one-dimensional arrays.
16092 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
16094 (NewUserdefinedArray::DoResolve): Implement.
16096 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
16098 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
16099 we maintain inside the TypeManager. This is necessary to perform lookups on the
16102 (LookupType): Update to perform GetType on the module builders too.
16104 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
16106 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
16108 2001-10-23 Ravi Pratap <ravi@ximian.com>
16110 * expression.cs (New::DoResolve): Implement guts of array creation.
16112 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
16114 2001-10-27 Miguel de Icaza <miguel@ximian.com>
16116 * expression.cs: Fix bug I introduced lsat night that broke
16119 (Expression.Resolve): Report a 246 error (can not resolve name)
16120 if we find a SimpleName in the stream.
16122 (Expression.ResolveLValue): Ditto.
16124 (Expression.ResolveWithSimpleName): This function is a variant of
16125 ResolveName, this one allows SimpleNames to be returned without a
16126 warning. The only consumer of SimpleNames is MemberAccess
16128 2001-10-26 Miguel de Icaza <miguel@ximian.com>
16130 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
16131 might arrive here. I have my doubts that this is correct.
16133 * statement.cs (Lock): Implement lock statement.
16135 * cs-parser.jay: Small fixes to support `lock' and `using'
16137 * cs-tokenizer.cs: Remove extra space
16139 * driver.cs: New flag --checked, allows to turn on integer math
16142 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
16143 Threading.Monitor.Exit
16145 2001-10-23 Miguel de Icaza <miguel@ximian.com>
16147 * expression.cs (IndexerAccess::DoResolveLValue): Set the
16148 Expression Class to be IndexerAccess.
16150 Notice that Indexer::DoResolve sets the eclass to Value.
16152 2001-10-22 Miguel de Icaza <miguel@ximian.com>
16154 * class.cs (TypeContainer::Emit): Emit code for indexers.
16156 * assign.cs (IAssignMethod): New interface implemented by Indexers
16157 and Properties for handling assignment.
16159 (Assign::Emit): Simplify and reuse code.
16161 * expression.cs (IndexerAccess, PropertyExpr): Implement
16162 IAssignMethod, clean up old code.
16164 2001-10-22 Ravi Pratap <ravi@ximian.com>
16166 * typemanager.cs (ImplementsInterface): New method to determine if a type
16167 implements a given interface. Provides a nice cache too.
16169 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
16172 (ConvertReferenceExplicit): Ditto.
16174 * delegate.cs (Delegate::Populate): Update to define the parameters on the
16175 various methods, with correct names etc.
16177 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
16178 Operator.UnaryNegation.
16180 * cs-parser.jay (operator_declarator): Be a little clever in the case where
16181 we have a unary plus or minus operator.
16183 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
16186 * everywhere : update accordingly.
16188 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
16191 * class.cs (Method::Define): For the case where we are implementing a method
16192 inherited from an interface, we need to set the MethodAttributes.Final flag too.
16193 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
16195 2001-10-21 Ravi Pratap <ravi@ximian.com>
16197 * interface.cs (FindMembers): Implement to work around S.R.E
16200 * typemanager.cs (IsInterfaceType): Implement.
16202 (FindMembers): Update to handle interface types too.
16204 * expression.cs (ImplicitReferenceConversion): Re-write bits which
16205 use IsAssignableFrom as that is not correct - it doesn't work.
16207 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
16208 and accordingly override EmitStatement.
16210 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
16211 using the correct logic :-)
16213 2001-10-19 Ravi Pratap <ravi@ximian.com>
16215 * ../errors/cs-11.cs : Add to demonstrate error -11
16217 2001-10-17 Miguel de Icaza <miguel@ximian.com>
16219 * assign.cs (Assign::Resolve): Resolve right hand side first, and
16220 then pass this as a hint to ResolveLValue.
16222 * expression.cs (FieldExpr): Add Location information
16224 (FieldExpr::LValueResolve): Report assignment to readonly
16227 (Expression::ExprClassFromMemberInfo): Pass location information.
16229 (Expression::ResolveLValue): Add new method that resolves an
16232 (Expression::DoResolveLValue): Default invocation calls
16235 (Indexers): New class used to keep track of indexers in a given
16238 (IStackStore): Renamed from LValue, as it did not really describe
16239 what this did. Also ResolveLValue is gone from this interface and
16240 now is part of Expression.
16242 (ElementAccess): Depending on the element access type
16244 * typemanager.cs: Add `indexer_name_type' as a Core type
16245 (System.Runtime.CompilerServices.IndexerNameAttribute)
16247 * statement.cs (Goto): Take a location.
16249 2001-10-18 Ravi Pratap <ravi@ximian.com>
16251 * delegate.cs (Delegate::VerifyDelegate): New method to verify
16252 if two delegates are compatible.
16254 (NewDelegate::DoResolve): Update to take care of the case when
16255 we instantiate a delegate from another delegate.
16257 * typemanager.cs (FindMembers): Don't even try to look up members
16258 of Delegate types for now.
16260 2001-10-18 Ravi Pratap <ravi@ximian.com>
16262 * delegate.cs (NewDelegate): New class to take care of delegate
16265 * expression.cs (New): Split the delegate related code out into
16266 the NewDelegate class.
16268 * delegate.cs (DelegateInvocation): New class to handle delegate
16271 * expression.cs (Invocation): Split out delegate related code into
16272 the DelegateInvocation class.
16274 2001-10-17 Ravi Pratap <ravi@ximian.com>
16276 * expression.cs (New::DoResolve): Implement delegate creation fully
16277 and according to the spec.
16279 (New::DoEmit): Update to handle delegates differently.
16281 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
16282 because of which we were printing out arguments in reverse order !
16284 * delegate.cs (VerifyMethod): Implement to check if the given method
16285 matches the delegate.
16287 (FullDelegateDesc): Implement.
16289 (VerifyApplicability): Implement.
16291 * expression.cs (Invocation::DoResolve): Update to accordingly handle
16292 delegate invocations too.
16294 (Invocation::Emit): Ditto.
16296 * ../errors/cs1593.cs : Added.
16298 * ../errors/cs1594.cs : Added.
16300 * delegate.cs (InstanceExpression, TargetMethod): New properties.
16302 2001-10-16 Ravi Pratap <ravi@ximian.com>
16304 * typemanager.cs (intptr_type): Core type for System.IntPtr
16306 (InitCoreTypes): Update for the same.
16308 (iasyncresult_type, asynccallback_type): Ditto.
16310 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
16313 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
16316 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
16317 the builders for the 4 members of a delegate type :-)
16319 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
16322 * expression.cs (New::DoResolve): Implement guts for delegate creation.
16324 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
16326 2001-10-15 Miguel de Icaza <miguel@ximian.com>
16328 * statement.cs (Break::Emit): Implement.
16329 (Continue::Emit): Implement.
16331 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
16332 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
16333 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
16334 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
16337 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
16338 properties that track the label for the current loop (begin of the
16339 loop and end of the loop).
16341 2001-10-15 Ravi Pratap <ravi@ximian.com>
16343 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
16344 use of emitting anything at all.
16346 * class.cs, rootcontext.cs : Get rid of calls to the same.
16348 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
16350 (Populate): Define the constructor correctly and set the implementation
16353 * typemanager.cs (delegate_types): New hashtable to hold delegates that
16356 (AddDelegateType): Implement.
16358 (IsDelegateType): Implement helper method.
16360 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
16362 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
16363 and accordingly handle it.
16365 * delegate.cs (Populate): Take TypeContainer argument.
16366 Implement bits to define the Invoke method. However, I still haven't figured out
16367 how to take care of the native int bit :-(
16369 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
16370 Qualify the name of the delegate, not its return type !
16372 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
16375 (StandardConversionExists): Checking for array types turns out to be recursive.
16377 (ConvertReferenceExplicit): Implement array conversion.
16379 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
16381 2001-10-12 Ravi Pratap <ravi@ximian.com>
16383 * cs-parser.jay (delegate_declaration): Store the fully qualified
16384 name as it is a type declaration.
16386 * delegate.cs (ReturnType, Name): Rename members to these. Make them
16389 (DefineDelegate): Renamed from Define. Does the same thing essentially,
16390 as TypeContainer::DefineType.
16392 (Populate): Method in which all the definition of the various methods (Invoke)
16395 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
16398 (CloseDelegate): Finally creates the delegate.
16400 * class.cs (TypeContainer::DefineType): Update to define delegates.
16401 (Populate, Emit and CloseType): Do the same thing here too.
16403 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
16404 delegates in all these operations.
16406 2001-10-14 Miguel de Icaza <miguel@ximian.com>
16408 * expression.cs: LocalTemporary: a new expression used to
16409 reference a temporary that has been created.
16411 * assign.cs: Handle PropertyAccess back here, so that we can
16412 provide the proper semantic access to properties.
16414 * expression.cs (Expression::ConvertReferenceExplicit): Implement
16415 a few more explicit conversions.
16417 * modifiers.cs: `NEW' modifier maps to HideBySig.
16419 * expression.cs (PropertyExpr): Make this into an
16420 ExpressionStatement, and support the EmitStatement code path.
16422 Perform get/set error checking, clean up the interface.
16424 * assign.cs: recognize PropertyExprs as targets, and if so, turn
16425 them into toplevel access objects.
16427 2001-10-12 Miguel de Icaza <miguel@ximian.com>
16429 * expression.cs: PropertyExpr::PropertyExpr: use work around the
16432 * typemanager.cs: Keep track here of our PropertyBuilders again to
16433 work around lameness in SRE.
16435 2001-10-11 Miguel de Icaza <miguel@ximian.com>
16437 * expression.cs (LValue::LValueResolve): New method in the
16438 interface, used to perform a second resolution pass for LValues.
16440 (This::DoResolve): Catch the use of this in static methods.
16442 (This::LValueResolve): Implement.
16444 (This::Store): Remove warning, assigning to `this' in structures
16447 (Invocation::Emit): Deal with invocation of
16448 methods on value types. We need to pass the address to structure
16449 methods rather than the object itself. (The equivalent code to
16450 emit "this" for structures leaves the entire structure on the
16451 stack instead of a pointer to it).
16453 (ParameterReference::DoResolve): Compute the real index for the
16454 argument based on whether the method takes or not a `this' pointer
16455 (ie, the method is static).
16457 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
16458 value types returned from functions when we need to invoke a
16459 method on the sturcture.
16462 2001-10-11 Ravi Pratap <ravi@ximian.com>
16464 * class.cs (TypeContainer::DefineType): Method to actually do the business of
16465 defining the type in the Modulebuilder or Typebuilder. This is to take
16466 care of nested types which need to be defined on the TypeBuilder using
16467 DefineNestedMethod.
16469 (TypeContainer::GetClassBases): Implement. Essentially the code from the
16470 methods in RootContext, only ported to be part of TypeContainer.
16472 (TypeContainer::GetInterfaceOrClass): Ditto.
16474 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
16476 * interface.cs (Interface::DefineInterface): New method. Does exactly
16477 what RootContext.CreateInterface did earlier, only it takes care of nested types
16480 (Interface::GetInterfaces): Move from RootContext here and port.
16482 (Interface::GetInterfaceByName): Same here.
16484 * rootcontext.cs (ResolveTree): Re-write.
16486 (PopulateTypes): Re-write.
16488 * class.cs (TypeContainer::Populate): Populate nested types too.
16489 (TypeContainer::Emit): Emit nested members too.
16491 * typemanager.cs (AddUserType): Do not make use of the FullName property,
16492 instead just use the name argument passed in as it is already fully
16495 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
16496 to TypeContainer mapping to see if a type is user-defined.
16498 * class.cs (TypeContainer::CloseType): Implement.
16500 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
16501 the default constructor.
16503 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
16506 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
16508 * interface.cs (CloseType): Create the type here.
16510 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
16513 Remove all the methods which are now in TypeContainer.
16515 2001-10-10 Ravi Pratap <ravi@ximian.com>
16517 * delegate.cs (Define): Re-write bits to define the delegate
16520 2001-10-10 Miguel de Icaza <miguel@ximian.com>
16522 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
16524 * expression.cs (ImplicitReferenceConversion): handle null as well
16525 as a source to convert to any reference type.
16527 * statement.cs (Return): Perform any implicit conversions to
16528 expected return type.
16530 Validate use of return statement.
16532 * codegen.cs (EmitContext): Pass the expected return type here.
16534 * class.cs (Method, Constructor, Property): Pass expected return
16535 type to EmitContext.
16537 2001-10-09 Miguel de Icaza <miguel@ximian.com>
16539 * expression.cs: Make DoResolve take an EmitContext instead of a
16542 Replaced `l' and `location' for `loc', for consistency.
16544 (Error, Warning): Remove unneeded Tc argument.
16546 * assign.cs, literal.cs, constant.cs: Update to new calling
16549 * codegen.cs: EmitContext now contains a flag indicating whether
16550 code is being generated in a static method or not.
16552 * cs-parser.jay: DecomposeQI, new function that replaces the old
16553 QualifiedIdentifier. Now we always decompose the assembled
16554 strings from qualified_identifier productions into a group of
16557 2001-10-08 Miguel de Icaza <miguel@ximian.com>
16559 * rootcontext.cs: Deal with field-less struct types correctly now
16560 by passing the size option to Define Type.
16562 * class.cs: Removed hack that created one static field.
16564 2001-10-07 Miguel de Icaza <miguel@ximian.com>
16566 * statement.cs: Moved most of the code generation here.
16568 2001-10-09 Ravi Pratap <ravi@ximian.com>
16570 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
16573 (ElementAccess): Remove useless bits for now - keep checks as the spec
16576 2001-10-08 Ravi Pratap <ravi@ximian.com>
16578 * expression.cs (ElementAccess::DoResolve): Remove my crap code
16579 and start performing checks according to the spec.
16581 2001-10-07 Ravi Pratap <ravi@ximian.com>
16583 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
16584 rank_specifiers instead.
16586 (rank_specifiers): Change the order in which the rank specifiers are stored
16588 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
16590 * expression.cs (ElementAccess): Implement the LValue interface too.
16592 2001-10-06 Ravi Pratap <ravi@ximian.com>
16594 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
16595 except that user defined conversions are not included.
16597 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
16598 perform the conversion of the return type, if necessary.
16600 (New::DoResolve): Check whether we are creating an array or an object
16601 and accordingly do the needful.
16603 (New::Emit): Same here.
16605 (New::DoResolve): Implement guts of array creation.
16607 (New::FormLookupType): Helper function.
16609 2001-10-07 Miguel de Icaza <miguel@ximian.com>
16611 * codegen.cs: Removed most of the code generation here, and move the
16612 corresponding code generation bits to the statement classes.
16614 Added support for try/catch/finalize and throw.
16616 * cs-parser.jay: Added support for try/catch/finalize.
16618 * class.cs: Catch static methods having the flags override,
16619 virtual or abstract.
16621 * expression.cs (UserCast): This user cast was not really doing
16622 what it was supposed to do. Which is to be born in fully resolved
16623 state. Parts of the resolution were being performed at Emit time!
16627 2001-10-05 Miguel de Icaza <miguel@ximian.com>
16629 * expression.cs: Implicity convert the result from UserCast.
16631 2001-10-05 Ravi Pratap <ravi@ximian.com>
16633 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
16634 prevented it from working correctly.
16636 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
16637 merely ConvertImplicit.
16639 2001-10-05 Miguel de Icaza <miguel@ximian.com>
16641 * typemanager.cs: Make the LookupTypeContainer function static,
16642 and not per-instance.
16644 * class.cs: Make static FindMembers (the one that takes a Type
16647 * codegen.cs: Add EmitForeach here.
16649 * cs-parser.jay: Make foreach a toplevel object instead of the
16650 inline expansion, as we need to perform semantic analysis on it.
16652 2001-10-05 Ravi Pratap <ravi@ximian.com>
16654 * expression.cs (Expression::ImplicitUserConversion): Rename to
16655 UserDefinedConversion.
16657 (Expression::UserDefinedConversion): Take an extra argument specifying
16658 whether we look for explicit user conversions too.
16660 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
16662 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
16664 (ExplicitUserConversion): Make it a call to UserDefinedConversion
16665 with the appropriate arguments.
16667 * cs-parser.jay (cast_expression): Record location too.
16669 * expression.cs (Cast): Record location info.
16671 (Expression::ConvertExplicit): Take location argument.
16673 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
16674 to determine if we are doing explicit conversions.
16676 (UserCast::Emit): Update accordingly.
16678 (Expression::ConvertExplicit): Report an error if everything fails.
16680 * ../errors/cs0030.cs : Add.
16682 2001-10-04 Miguel de Icaza <miguel@ximian.com>
16684 * modifiers.cs: If the ABSTRACT keyword is present, also set the
16685 virtual and newslot bits.
16687 * class.cs (TypeContainer::RegisterRequiredImplementations):
16688 Record methods we need.
16690 (TypeContainer::MakeKey): Helper function to make keys for
16691 MethodBases, since the Methodbase key is useless.
16693 (TypeContainer::Populate): Call RegisterRequiredImplementations
16694 before defining the methods.
16696 Create a mapping for method_builders_to_methods ahead of time
16697 instead of inside a tight loop.
16699 (::RequireMethods): Accept an object as the data to set into the
16700 hashtable so we can report interface vs abstract method mismatch.
16702 2001-10-03 Miguel de Icaza <miguel@ximian.com>
16704 * report.cs: Make all of it static.
16706 * rootcontext.cs: Drop object_type and value_type computations, as
16707 we have those in the TypeManager anyways.
16709 Drop report instance variable too, now it is a global.
16711 * driver.cs: Use try/catch on command line handling.
16713 Add --probe option to debug the error reporting system with a test
16716 * report.cs: Add support for exiting program when a probe
16717 condition is reached.
16719 2001-10-03 Ravi Pratap <ravi@ximian.com>
16721 * expression.cs (Binary::DoNumericPromotions): Fix the case when
16722 we do a forcible conversion regardless of type, to check if
16723 ForceConversion returns a null.
16725 (Binary::error19): Use location to report error.
16727 (Unary::error23): Use location here too.
16729 * ../errors/cs0019.cs : Check in.
16731 * ../errors/cs0023.cs : Check in.
16733 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
16734 case of a non-null MethodInfo object with a length of 0 !
16736 (Binary::ResolveOperator): Flag error if overload resolution fails to find
16737 an applicable member - according to the spec :-)
16738 Also fix logic to find members in base types.
16740 (Unary::ResolveOperator): Same here.
16742 (Unary::report23): Change name to error23 and make first argument a TypeContainer
16743 as I was getting thoroughly confused between this and error19 :-)
16745 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
16746 (::FindMostEncompassedType): Implement.
16747 (::FindMostEncompassingType): Implement.
16748 (::StandardConversionExists): Implement.
16750 (UserImplicitCast): Re-vamp. We now need info about most specific
16751 source and target types so that we can do the necessary conversions.
16753 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
16754 mathematical union with no duplicates.
16756 2001-10-03 Miguel de Icaza <miguel@ximian.com>
16758 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
16759 in order from base classes to child classes, so that we can in
16760 child classes look up in our parent for method names and
16761 attributes (required for handling abstract, virtual, new, override
16762 constructs: we need to instrospect our base class, and if we dont
16763 populate the classes in order, the introspection might be
16764 incorrect. For example, a method could query its parent before
16765 the parent has any methods and would determine that the parent has
16766 no abstract methods (while it could have had them)).
16768 (RootContext::CreateType): Record the order in which we define the
16771 2001-10-02 Miguel de Icaza <miguel@ximian.com>
16773 * class.cs (TypeContainer::Populate): Also method definitions can
16774 fail now, keep track of this.
16776 (TypeContainer::FindMembers): Implement support for
16777 DeclaredOnly/noDeclaredOnly flag.
16779 (Constructor::Emit) Return the ConstructorBuilder.
16781 (Method::Emit) Return the MethodBuilder.
16782 Check for abstract or virtual methods to be public.
16784 * rootcontext.cs (RootContext::CreateType): Register all the
16785 abstract methods required for the class to be complete and the
16786 interface methods that must be implemented.
16788 * cs-parser.jay: Report error 501 (method requires body if it is
16789 not marked abstract or extern).
16791 * expression.cs (TypeOf::Emit): Implement.
16793 * typemanager.cs: runtime_handle_type, new global type.
16795 * class.cs (Property::Emit): Generate code for properties.
16797 2001-10-02 Ravi Pratap <ravi@ximian.com>
16799 * expression.cs (Unary::ResolveOperator): Find operators on base type
16800 too - we now conform exactly to the spec.
16802 (Binary::ResolveOperator): Same here.
16804 * class.cs (Operator::Define): Fix minor quirk in the tests.
16806 * ../errors/cs0215.cs : Added.
16808 * ../errors/cs0556.cs : Added.
16810 * ../errors/cs0555.cs : Added.
16812 2001-10-01 Miguel de Icaza <miguel@ximian.com>
16814 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
16815 single integer which is really efficient
16817 2001-10-01 Ravi Pratap <ravi@ximian.com>
16819 * expression.cs (Expression::ImplicitUserConversion): Use location
16820 even in the case when we are examining True operators.
16822 * class.cs (Operator::Define): Perform extensive checks to conform
16823 with the rules for operator overloading in the spec.
16825 * expression.cs (Expression::ImplicitReferenceConversion): Implement
16826 some of the other conversions mentioned in the spec.
16828 * typemanager.cs (array_type): New static member for the System.Array built-in
16831 (cloneable_interface): For System.ICloneable interface.
16833 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
16834 we start resolving the tree and populating types.
16836 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
16838 2001-10-01 Miguel de Icaza <miguel@ximian.com>
16840 * expression.cs (Expression::ExprClassFromMemberInfo,
16841 Expression::Literalize): Create literal expressions from
16842 FieldInfos which are literals.
16844 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
16845 type casts, because they were wrong. The test suite in tests
16848 (ImplicitNumericConversion): ushort to ulong requires a widening
16851 Int32 constant to long requires widening cast as well.
16853 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
16854 for integers because the type on the stack is not i4.
16856 2001-09-30 Miguel de Icaza <miguel@ximian.com>
16858 * expression.cs (report118): require location argument.
16860 * parameter.cs: Do not dereference potential null value.
16862 * class.cs: Catch methods that lack the `new' keyword when
16863 overriding a name. Report warnings when `new' is used without
16864 anything being there to override.
16866 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
16868 * class.cs: Only add constructor to hashtable if it is non-null
16869 (as now constructors can fail on define).
16871 (TypeManager, Class, Struct): Take location arguments.
16873 Catch field instance initialization in structs as errors.
16875 accepting_filter: a new filter for FindMembers that is static so
16876 that we dont create an instance per invocation.
16878 (Constructor::Define): Catch errors where a struct constructor is
16881 * cs-parser.jay: Pass location information for various new
16884 * delegate.cs (Delegate): take a location argument.
16886 * driver.cs: Do not call EmitCode if there were problesm in the
16887 Definition of the types, as many Builders wont be there.
16889 * decl.cs (Decl::Decl): Require a location argument.
16891 * cs-tokenizer.cs: Handle properly hex constants that can not fit
16892 into integers, and find the most appropiate integer for it.
16894 * literal.cs: Implement ULongLiteral.
16896 * rootcontext.cs: Provide better information about the location of
16897 failure when CreateType fails.
16899 2001-09-29 Miguel de Icaza <miguel@ximian.com>
16901 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
16904 * expression.cs (Binary::CheckShiftArguments): Add missing type
16906 (Binary::ResolveOperator): Add type to the logical and and logical
16907 or, Bitwise And/Or and Exclusive Or code paths, it was missing
16910 (Binary::DoNumericPromotions): In the case where either argument
16911 is ulong (and most signed types combined with ulong cause an
16912 error) perform implicit integer constant conversions as well.
16914 2001-09-28 Miguel de Icaza <miguel@ximian.com>
16916 * expression.cs (UserImplicitCast): Method should always be
16918 (Invocation::BetterConversion): Simplified test for IntLiteral.
16920 (Expression::ImplicitNumericConversion): Split this routine out.
16921 Put the code that performs implicit constant integer conversions
16924 (Expression::Resolve): Become a wrapper around DoResolve so we can
16925 check eclass and type being set after resolve.
16927 (Invocation::Badness): Remove this dead function
16929 (Binary::ResolveOperator): Do not compute the expensive argumnets
16930 unless we have a union for it.
16932 (Probe::Emit): Is needs to do an isinst and then
16933 compare against null.
16935 (::CanConvert): Added Location argument. If the Location argument
16936 is null (Location.Null), then we do not report errors. This is
16937 used by the `probe' mechanism of the Explicit conversion. We do
16938 not want to generate an error for something that the user
16939 explicitly requested to be casted. But the pipeline for an
16940 explicit cast first tests for potential implicit casts.
16942 So for now, if the Location is null, it means `Probe only' to
16943 avoid adding another argument. Might have to revise this
16946 (ClassCast): New class used to type cast objects into arbitrary
16947 classes (used in Explicit Reference Conversions).
16949 Implement `as' as well.
16951 Reverted all the patches from Ravi below: they were broken:
16953 * The use of `level' as a mechanism to stop recursive
16954 invocations is wrong. That was there just to catch the
16955 bug with a strack trace but not as a way of addressing
16958 To fix the problem we have to *understand* what is going
16959 on and the interactions and come up with a plan, not
16960 just get things going.
16962 * The use of the type conversion cache that I proposed
16963 last night had an open topic: How does this work across
16964 protection domains. A user defined conversion might not
16965 be public in the location where we are applying the
16966 conversion, a different conversion might be selected
16967 (ie, private A->B (better) but public B->A (worse),
16968 inside A, A->B applies, but outside it, B->A will
16971 * On top of that (ie, even if the above is solved),
16972 conversions in a cache need to be abstract. Ie, `To
16973 convert from an Int to a Short use an OpcodeCast', not
16974 `To convert from an Int to a Short use the OpcodeCast on
16975 the variable 5' (which is what this patch was doing).
16977 2001-09-28 Ravi Pratap <ravi@ximian.com>
16979 * expression.cs (Invocation::ConversionExists): Re-write to use
16980 the conversion cache
16982 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
16983 cache all conversions done, not just user-defined ones.
16985 (Invocation::BetterConversion): The real culprit. Use ConversionExists
16986 to determine if a conversion exists instead of acutually trying to
16987 perform the conversion. It's faster too.
16989 (Expression::ConvertExplicit): Modify to use ConversionExists to check
16990 and only then attempt the implicit conversion.
16992 2001-09-28 Ravi Pratap <ravi@ximian.com>
16994 * expression.cs (ConvertImplicit): Use a cache for conversions
16995 already found. Check level of recursion and bail out if necessary.
16997 2001-09-28 Miguel de Icaza <miguel@ximian.com>
16999 * typemanager.cs (string_concat_string_string, string_concat_object_object):
17000 Export standard methods that we expect for string operations.
17002 * statement.cs (Block::UsageWarning): Track usage of variables and
17003 report the errors for not used variables.
17005 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
17008 2001-09-27 Miguel de Icaza <miguel@ximian.com>
17010 * codegen.cs: remove unnneded code
17012 * expression.cs: Removed BuiltinTypeAccess class
17014 Fix the order in which implicit conversions are
17017 The previous fixed dropped support for boxed conversions (adding a
17018 test to the test suite now)
17020 (UserImplicitCast::CanConvert): Remove test for source being null,
17021 that code is broken. We should not feed a null to begin with, if
17022 we do, then we should track the bug where the problem originates
17023 and not try to cover it up here.
17025 Return a resolved expression of type UserImplicitCast on success
17026 rather than true/false. Ravi: this is what I was talking about,
17027 the pattern is to use a static method as a "constructor" for
17030 Also, do not create arguments until the very last minute,
17031 otherwise we always create the arguments even for lookups that
17032 will never be performed.
17034 (UserImplicitCast::Resolve): Eliminate, objects of type
17035 UserImplicitCast are born in a fully resolved state.
17037 * typemanager.cs (InitCoreTypes): Init also value_type
17038 (System.ValueType).
17040 * expression.cs (Cast::Resolve): First resolve the child expression.
17042 (LValue): Add new method AddressOf to be used by
17045 Change the argument of Store to take an EmitContext instead of an
17046 ILGenerator, because things like FieldExpr need to be able to call
17047 their children expression to generate the instance code.
17049 (Expression::Error, Expression::Warning): Sugar functions for
17052 (Expression::MemberLookup): Accept a TypeContainer instead of a
17053 Report as the first argument.
17055 (Expression::ResolvePrimary): Killed. I still want to improve
17056 this as currently the code is just not right.
17058 (Expression::ResolveMemberAccess): Simplify, but it is still
17061 (Unary::Resolve): Catch errors in AddressOf operators.
17063 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
17064 index to a byte for the short-version, or the compiler will choose
17065 the wrong Emit call, which generates the wrong data.
17067 (ParameterReference::Emit, ::Store): same.
17069 (FieldExpr::AddressOf): Implement.
17071 * typemanager.cs: TypeManager: made public variable instead of
17074 * driver.cs: document --fatal.
17076 * report.cs (ErrorMessage, WarningMessage): new names for the old
17077 Error and Warning classes.
17079 * cs-parser.jay (member_access): Turn built-in access to types
17080 into a normal simplename
17082 2001-09-27 Ravi Pratap <ravi@ximian.com>
17084 * expression.cs (Invocation::BetterConversion): Fix to cope
17085 with q being null, since this was introducing a bug.
17087 * expression.cs (ConvertImplicit): Do built-in conversions first.
17089 2001-09-27 Ravi Pratap <ravi@ximian.com>
17091 * expression.cs (UserImplicitCast::Resolve): Fix bug.
17093 2001-09-27 Ravi Pratap <ravi@ximian.com>
17095 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
17096 I had introduced long ago (what's new ?).
17098 * expression.cs (UserImplicitCast::CanConvert): Static method to do
17099 the work of all the checking.
17100 (ConvertImplicit): Call CanConvert and only then create object if necessary.
17101 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
17103 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
17104 that is the right way.
17106 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
17107 overloading resolution. Use everywhere instead of cutting and pasting code.
17109 (Binary::ResolveOperator): Use MakeUnionSet.
17111 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
17112 we have to convert to bool types. Not complete yet.
17114 2001-09-27 Miguel de Icaza <miguel@ximian.com>
17116 * typemanager.cs (TypeManager::CSharpName): support ushort.
17118 * expression.cs (Expression::TryImplicitIntConversion): Attempts
17119 to provide an expression that performsn an implicit constant int
17120 conversion (section 6.1.6).
17121 (Expression::ConvertImplicitRequired): Reworked to include
17122 implicit constant expression conversions.
17124 (Expression::ConvertNumericExplicit): Finished.
17126 (Invocation::Emit): If InstanceExpression is null, then it means
17127 that we perform a call on this.
17129 2001-09-26 Miguel de Icaza <miguel@ximian.com>
17131 * expression.cs (Unary::Emit): Remove some dead code.
17132 (Probe): Implement Resolve and Emit for `is'.
17133 (Expression::ConvertImplicitRequired): Attempt to do constant
17134 expression conversions here. Maybe should be moved to
17135 ConvertImplicit, but I am not sure.
17136 (Expression::ImplicitLongConstantConversionPossible,
17137 Expression::ImplicitIntConstantConversionPossible): New functions
17138 that tell whether is it possible to apply an implicit constant
17139 expression conversion.
17141 (ConvertNumericExplicit): Started work on explicit numeric
17144 * cs-parser.jay: Update operator constants.
17146 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
17147 (Parameters::GetSignature): Hook up VerifyArgs here.
17148 (Parameters::VerifyArgs): Verifies that no two arguments have the
17151 * class.cs (Operator): Update the operator names to reflect the
17152 ones that the spec expects (as we are just stringizing the
17155 * expression.cs (Unary::ResolveOperator): Fix bug: Use
17156 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
17157 previous usage did only work for our methods.
17158 (Expression::ConvertImplicit): Handle decimal implicit numeric
17159 conversions as well.
17160 (Expression::InternalTypeConstructor): Used to invoke constructors
17161 on internal types for default promotions.
17163 (Unary::Emit): Implement special handling for the pre/post
17164 increment/decrement for overloaded operators, as they need to have
17165 the same semantics as the other operators.
17167 (Binary::ResolveOperator): ditto.
17168 (Invocation::ConversionExists): ditto.
17169 (UserImplicitCast::Resolve): ditto.
17171 2001-09-26 Ravi Pratap <ravi@ximian.com>
17173 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
17174 operator, return after emitting body. Regression tests pass again !
17176 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
17177 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
17178 (Invocation::OverloadResolve): Ditto.
17179 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
17181 * everywhere : update calls to the above methods accordingly.
17183 2001-09-26 Miguel de Icaza <miguel@ximian.com>
17185 * assign.cs (Assign): Make it inherit from ExpressionStatement.
17187 * expression.cs (ExpressionStatement): New base class used for
17188 expressions that can appear in statements, so that we can provide
17189 an alternate path to generate expression that do not leave a value
17192 (Expression::Emit, and all the derivatives): We no longer return
17193 whether a value is left on the stack or not. Every expression
17194 after being emitted leaves a single value on the stack.
17196 * codegen.cs (EmitContext::EmitStatementExpression): Use the
17197 facilties of ExpressionStatement if possible.
17199 * cs-parser.jay: Update statement_expression.
17201 2001-09-25 Miguel de Icaza <miguel@ximian.com>
17203 * driver.cs: Change the wording of message
17205 2001-09-25 Ravi Pratap <ravi@ximian.com>
17207 * expression.cs (Binary::ResolveOperator): Had forgottten to set
17208 the type of the expression to the return type of the method if
17209 we have an overloaded operator match ! The regression tests pass again !
17210 (Unary::ResolveOperator): Ditto.
17212 * expression.cs (Invocation::ConversionExists): Correct the member lookup
17213 to find "op_Implicit", not "implicit" ;-)
17214 (UserImplicitCast): New class to take care of user-defined implicit conversions.
17215 (ConvertImplicit, ForceConversion): Take TypeContainer argument
17217 * everywhere : Correct calls to the above accordingly.
17219 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
17220 (ConvertImplicit): Do user-defined conversion if it exists.
17222 2001-09-24 Miguel de Icaza <miguel@ximian.com>
17224 * assign.cs: track location.
17225 (Resolve): Use implicit conversions on assignment.
17227 * literal.cs: Oops. Not good, Emit of short access values should
17228 pass (Bytes) or the wrong argument will be selected.
17230 * expression.cs (Unary::Emit): Emit code for -expr.
17232 (Unary::ResolveOperator): Handle `Substract' for non-constants
17233 (substract from zero from the non-constants).
17234 Deal with Doubles as well.
17236 (Expression::ConvertImplicitRequired): New routine that reports an
17237 error if no implicit conversion exists.
17239 (Invocation::OverloadResolve): Store the converted implicit
17240 expressions if we make them
17242 2001-09-24 Ravi Pratap <ravi@ximian.com>
17244 * class.cs (ConstructorInitializer): Take a Location argument.
17245 (ConstructorBaseInitializer): Same here.
17246 (ConstructorThisInitializer): Same here.
17248 * cs-parser.jay : Update all calls accordingly.
17250 * expression.cs (Unary, Binary, New): Take location argument.
17251 Update accordingly everywhere.
17253 * cs-parser.jay : Update all calls to the above to take a location
17256 * class.cs : Ditto.
17258 2001-09-24 Ravi Pratap <ravi@ximian.com>
17260 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
17261 (Invocation::BetterConversion): Same here
17262 (Invocation::ConversionExists): Ditto.
17264 (Invocation::ConversionExists): Implement.
17266 2001-09-22 Ravi Pratap <ravi@ximian.com>
17268 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
17269 Also take an additional TypeContainer argument.
17271 * All over : Pass in TypeContainer as argument to OverloadResolve.
17273 * typemanager.cs (CSharpName): Update to check for the string type and return
17276 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
17279 2001-09-21 Ravi Pratap <ravi@ximian.com>
17281 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
17282 (Invocation::BetterFunction): Implement.
17283 (Invocation::BetterConversion): Implement.
17284 (Invocation::ConversionExists): Skeleton, no implementation yet.
17286 Okay, things work fine !
17288 2001-09-21 Miguel de Icaza <miguel@ximian.com>
17290 * typemanager.cs: declare and load enum_type, delegate_type and
17293 * expression.cs (Expression::Emit): Now emit returns a value that
17294 tells whether a value is left on the stack or not. This strategy
17295 might be reveted tomorrow with a mechanism that would address
17296 multiple assignments.
17297 (Expression::report118): Utility routine to report mismatches on
17300 (Unary::Report23): Report impossible type/operator combination
17303 (Unary::IsIncrementableNumber): Whether the type can be
17304 incremented or decremented with add.
17305 (Unary::ResolveOperator): Also allow enumerations to be bitwise
17307 (Unary::ResolveOperator): Implement ++, !, ~,
17309 (Invocation::Emit): Deal with new Emit convetion.
17311 * All Expression derivatives: Updated their Emit method to return
17312 whether they leave values on the stack or not.
17314 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
17315 stack for expressions that are statements.
17317 2001-09-20 Miguel de Icaza <miguel@ximian.com>
17319 * expression.cs (LValue): New interface. Must be implemented by
17321 (LocalVariableReference, ParameterReference, FieldExpr): Implement
17324 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
17325 interface for generating code, simplifies the code.
17327 2001-09-20 Ravi Pratap <ravi@ximian.com>
17329 * expression.cs (everywhere): Comment out return statements in ::Resolve
17330 methods to avoid the warnings.
17332 2001-09-20 Miguel de Icaza <miguel@ximian.com>
17334 * driver.cs (parse): Report error 2001 if we can not open the
17337 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
17340 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
17343 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
17344 otherwise nested blocks end up with the same index.
17346 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
17348 * expression.cs: Instead of having FIXMEs in the Resolve
17349 functions, throw exceptions so it is obvious that we are facing a
17352 * cs-parser.jay (invocation_expression): Pass Location information.
17354 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
17355 Use a basename for those routines because .NET does not like paths
17358 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
17361 2001-09-19 Miguel de Icaza <miguel@ximian.com>
17363 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
17364 are loading the correct data types (throws an exception if not).
17365 (TypeManager::InitCoreTypes): Use CoreLookupType
17367 * expression.cs (Unary::ResolveOperator): return the child
17368 expression for expressions which are just +expr.
17369 (Unary::ResolveOperator): Return negative literals for -LITERAL
17370 expressions (otherwise they are Unary {Literal}).
17371 (Invocation::Badness): Take into account `Implicit constant
17372 expression conversions'.
17374 * literal.cs (LongLiteral): Implement long literal class.
17375 (IntLiteral): export the `Value' of the intliteral.
17377 2001-09-19 Ravi Pratap <ravi@ximian.com>
17379 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
17381 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
17382 instead of 'Operator'
17384 * expression.cs (Binary::ResolveOperator): Update accordingly.
17385 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
17388 * cs-parser.jay (unary_expression): Update to use the new names.
17390 * gen-treedump.cs (GetUnary): Same here.
17392 * expression.cs (Unary::Resolve): Implement.
17393 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
17394 operators are found instead of making noise ;-)
17395 (Unary::ResolveOperator): New method to do precisely the same thing which
17396 Binary::ResolveOperator does for Binary expressions.
17397 (Unary.method, .Arguments): Add.
17398 (Unary::OperName): Implement.
17399 (Unary::ForceConversion): Copy and Paste !
17401 * class.cs (Operator::Define): Fix a small bug for the case when we have
17404 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
17405 for the inbuilt operators. Only overloading works for now ;-)
17407 2001-09-18 Miguel de Icaza <miguel@ximian.com>
17409 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
17410 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
17412 * expression.cs (This::Emit): Implement.
17413 (This::Resolve): Implement.
17414 (TypeOf:Resolve): Implement.
17415 (Expression::ResolveSimpleName): Add an implicit this to instance
17417 (MemberAccess::Resolve): Deal with Parameters and Fields.
17418 Bind instance variable to Field expressions.
17419 (FieldExpr::Instance): New field used to track the expression that
17420 represents the object instance.
17421 (FieldExpr::Resolve): Track potential errors from MemberLookup not
17423 (FieldExpr::Emit): Implement.
17425 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
17426 the last instruction contains a return opcode to avoid generating
17427 the last `ret' instruction (this generates correct code, and it is
17428 nice to pass the peverify output).
17430 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
17431 initializer for static and instance variables.
17432 (Constructor::Emit): Allow initializer to be null in the case of
17433 static constructors. Only emit initializer for instance
17436 (TypeContainer::FindMembers): Return a null array if there are no
17439 Also fix the code for the MemberTypes.Method branch, as it was not
17440 scanning that for operators (or tried to access null variables before).
17442 * assign.cs (Assign::Emit): Handle instance and static fields.
17446 * driver.cs: Stop compilation if there are parse errors.
17448 * cs-parser.jay (constructor_declaration): Provide default base
17449 initializer for non-static constructors.
17450 (constructor_declarator): Do not provide a default base
17451 initializers if none was specified.
17452 Catch the fact that constructors should not have parameters.
17454 * class.cs: Do not emit parent class initializers for static
17455 constructors, that should be flagged as an error.
17457 2001-09-18 Ravi Pratap <ravi@ximian.com>
17459 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
17460 Move back code into TypeContainer::Populate.
17462 2001-09-18 Ravi Pratap <ravi@ximian.com>
17464 * class.cs (TypeContainer::AddConstructor): Fix the check to
17465 compare against Name, not Basename.
17466 (Operator::OpType): Change Plus and Minus to Add and Subtract.
17468 * cs-parser.jay : Update accordingly.
17470 * class.cs (TypeContainer::FindMembers): For the case where we are searching
17471 for methods, don't forget to look into the operators too.
17472 (RegisterMethodBuilder): Helper method to take care of this for
17473 methods, constructors and operators.
17474 (Operator::Define): Completely revamp.
17475 (Operator.OperatorMethod, MethodName): New fields.
17476 (TypeContainer::Populate): Move the registering of builders into
17477 RegisterMethodBuilder.
17478 (Operator::Emit): Re-write.
17480 * expression.cs (Binary::Emit): Comment out code path to emit method
17481 invocation stuff for the case when we have a user defined operator. I am
17482 just not able to get it right !
17484 2001-09-17 Miguel de Icaza <miguel@ximian.com>
17486 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
17489 (Expression::MemberLookup): Provide a version that allows to
17490 specify the MemberTypes and BindingFlags.
17492 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
17493 so it was not fetching variable information from outer blocks.
17495 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
17496 Beforefieldinit as it was buggy.
17498 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
17499 that Ravi put here.
17501 * class.cs (Constructor::Emit): Only emit if block is not null.
17502 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
17503 deal with this by semantically definining it as if the user had
17506 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
17507 constructors as we now "emit" them at a higher level.
17509 (TypeContainer::DefineDefaultConstructor): Used to define the
17510 default constructors if none was provided.
17512 (ConstructorInitializer): Add methods Resolve and Emit.
17514 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
17516 2001-09-17 Ravi Pratap <ravi@ximian.com>
17518 * class.cs (TypeContainer::EmitDefaultConstructor): Register
17519 the default constructor builder with our hashtable for methodbuilders
17522 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
17523 and argument_count is 0 in which case we have a match.
17524 (Binary::ResolveOperator): More null checking and miscellaneous coding
17527 2001-09-17 Ravi Pratap <ravi@ximian.com>
17529 * rootcontext.cs (IsNameSpace): Compare against null.
17531 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
17533 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
17534 and Unary::Operator.
17536 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
17539 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
17540 we have overloaded operators.
17541 (Binary::ResolveOperator): Implement the part which does the operator overload
17544 * class.cs (Operator::Emit): Implement.
17545 (TypeContainer::Emit): Emit the operators we have too.
17547 * expression.cs (Binary::Emit): Update to emit the appropriate code for
17548 the case when we have a user-defined operator.
17550 2001-09-17 Miguel de Icaza <miguel@ximian.com>
17552 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
17554 2001-09-16 Ravi Pratap <ravi@ximian.com>
17556 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
17557 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
17558 (Constructor::Emit): Implement.
17559 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
17560 if we have no work to do.
17561 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
17564 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
17565 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
17567 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
17570 2001-09-15 Ravi Pratap <ravi@ximian.com>
17572 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
17574 (Tree::RecordNamespace): Method to do what the name says ;-)
17575 (Tree::Namespaces): Property to get at the namespaces hashtable.
17577 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
17580 * rootcontext.cs (IsNamespace): Fixed it :-)
17582 2001-09-14 Miguel de Icaza <miguel@ximian.com>
17584 * class.cs (TypeContainer::FindMembers): Add support for
17586 (MethodCore): New class that encapsulates both the shared aspects
17587 of a Constructor and a Method.
17588 (Method, Constructor): Factored pieces into MethodCore.
17590 * driver.cs: Added --fatal which makes errors throw exceptions.
17591 Load System assembly as well as part of the standard library.
17593 * report.cs: Allow throwing exceptions on errors for debugging.
17595 * modifiers.cs: Do not use `parent', instead use the real type
17596 container to evaluate permission settings.
17598 * class.cs: Put Ravi's patch back in. He is right, and we will
17599 have to cope with the
17601 2001-09-14 Ravi Pratap <ravi@ximian.com>
17603 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
17604 FamORAssem, not FamANDAssem.
17606 2001-09-14 Miguel de Icaza <miguel@ximian.com>
17608 * driver.cs: Added --parse option that only parses its input files
17611 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
17612 incorrect. IsTopLevel is not used to tell whether an object is
17613 root_types or not (that can be achieved by testing this ==
17614 root_types). But to see if this is a top-level *class* (not
17615 necessarly our "toplevel" container).
17617 2001-09-14 Ravi Pratap <ravi@ximian.com>
17619 * enum.cs (Enum::Define): Modify to call the Lookup method on the
17620 parent instead of a direct call to GetType.
17622 2001-09-14 Ravi Pratap <ravi@ximian.com>
17624 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
17625 Modifiers.TypeAttr. This should just be a call to that method.
17627 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
17628 object so that we can determine if we are top-level or not.
17630 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
17633 * enum.cs (Enum::Define): Ditto.
17635 * modifiers.cs (FieldAttr): Re-write.
17637 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
17638 (TypeContainer::HaveStaticConstructor): New property to provide access
17639 to precisely that info.
17641 * modifiers.cs (MethodAttr): Re-write.
17642 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
17644 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
17645 of top-level types as claimed.
17647 2001-09-13 Miguel de Icaza <miguel@ximian.com>
17649 * expression.cs (MemberLookup): Fruitless attempt to lookup
17650 constructors. Maybe I need to emit default constructors? That
17651 might be it (currently .NET emits this for me automatically).
17652 (Invocation::OverloadResolve): Cope with Arguments == null.
17653 (Invocation::EmitArguments): new function, shared by the new
17654 constructor and us.
17655 (Invocation::Emit): Handle static and instance methods. Emit
17656 proper call instruction for virtual or non-virtual invocations.
17657 (New::Emit): Implement.
17658 (New::Resolve): Implement.
17659 (MemberAccess:Resolve): Implement.
17660 (MethodGroupExpr::InstanceExpression): used conforming to the spec
17661 to track instances.
17662 (FieldExpr::Resolve): Set type.
17664 * support.cs: Handle empty arguments.
17666 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
17667 SimpleLookup): Auxiliary routines to help parse a qualifier
17670 Update qualifier_identifier rule.
17672 * codegen.cs: Removed debugging messages.
17674 * class.cs: Make this a global thing, this acts just as a "key" to
17675 objects that we might have around.
17677 (Populate): Only initialize method_builders_to_methods once.
17679 * expression.cs (PropertyExpr): Initialize type from the
17682 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
17683 Resolve pattern. Attempt to implicitly convert value to boolean.
17686 * expression.cs: Set the type for the int32/int32 argument case.
17687 (Binary::ResolveOperator): Set the return type to boolean for
17688 comparission operators
17690 * typemanager.cs: Remove debugging print code.
17692 (Invocation::Resolve): resolve type.
17694 * class.cs: Allocate a MemberInfo of the correct size, as the code
17695 elsewhere depends on the test to reflect the correct contents.
17697 (Method::) Keep track of parameters, due to System.Reflection holes
17699 (TypeContainer::Populate): Keep track of MethodBuilders to Method
17702 (TypeContainer::FindMembers): Use ArrayList and then copy an array
17703 of the exact size and return that.
17705 (Class::LookupMethodByBuilder): New function that maps
17706 MethodBuilders to its methods. Required to locate the information
17707 on methods because System.Reflection bit us again.
17709 * support.cs: New file, contains an interface ParameterData and
17710 two implementations: ReflectionParameters and InternalParameters
17711 used to access Parameter information. We will need to grow this
17714 * expression.cs (Invocation::GetParameterData): implement a cache
17715 and a wrapper around the ParameterData creation for methods.
17716 (Invocation::OverloadResolve): Use new code.
17718 2001-09-13 Ravi Pratap <ravi@ximian.com>
17720 * class.cs (TypeContainer::EmitField): Remove and move into
17721 (Field::Define): here and modify accordingly.
17722 (Field.FieldBuilder): New member.
17723 (TypeContainer::Populate): Update accordingly.
17724 (TypeContainer::FindMembers): Implement.
17726 2001-09-13 Miguel de Icaza <miguel@ximian.com>
17728 * statement.cs: (VariableInfo::VariableType): New field to be
17729 initialized with the full type once it is resolved.
17731 2001-09-12 Miguel de Icaza <miguel@ximian.com>
17733 * parameter.cs (GetParameterInfo): Use a type cache to compute
17734 things only once, and to reuse this information
17736 * expression.cs (LocalVariableReference::Emit): Implement.
17737 (OpcodeCast::Emit): fix.
17739 (ParameterReference::Resolve): Implement.
17740 (ParameterReference::Emit): Implement.
17742 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
17743 that are expressions need to stay as Expressions.
17745 * typemanager.cs (CSharpName): Returns the C# name of a type if
17748 * expression.cs (Expression::ConvertImplicit): New function that
17749 implements implicit type conversions.
17751 (Expression::ImplicitReferenceConversion): Implements implicit
17752 reference conversions.
17754 (EmptyCast): New type for transparent casts.
17756 (OpcodeCast): New type for casts of types that are performed with
17757 a sequence of bytecodes.
17759 (BoxedCast): New type used for casting value types into reference
17760 types. Emits a box opcode.
17762 (Binary::DoNumericPromotions): Implements numeric promotions of
17763 and computation of the Binary::Type.
17765 (Binary::EmitBranchable): Optimization.
17767 (Binary::Emit): Implement code emission for expressions.
17769 * typemanager.cs (TypeManager): Added two new core types: sbyte
17772 2001-09-12 Ravi Pratap <ravi@ximian.com>
17774 * class.cs (TypeContainer::FindMembers): Method which does exactly
17775 what Type.FindMembers does, only we don't have to use reflection. No
17776 implementation yet.
17778 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
17779 typecontainer objects as we need to get at them.
17780 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
17782 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
17783 typecontainer object.
17785 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
17786 of just a Report object.
17788 2001-09-11 Ravi Pratap <ravi@ximian.com>
17790 * class.cs (Event::Define): Go back to using the prefixes "add_" and
17792 (TypeContainer::Populate): Now define the delegates of the type too.
17793 (TypeContainer.Delegates): Property to access the list of delegates defined
17796 * delegates.cs (Delegate::Define): Implement partially.
17798 * modifiers.cs (TypeAttr): Handle more flags.
17800 2001-09-11 Ravi Pratap <ravi@ximian.com>
17802 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
17804 (Operator::Define): Re-write logic to get types by using the LookupType method
17805 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
17806 (Indexer::Define): Ditto.
17807 (Event::Define): Ditto.
17808 (Property::Define): Ditto.
17810 2001-09-10 Ravi Pratap <ravi@ximian.com>
17812 * class.cs (TypeContainer::Populate): Now define operators too.
17813 (TypeContainer.Operators): New property to access the list of operators
17815 (Operator.OperatorMethodBuilder): New member to hold the method builder
17816 for the operator we are defining.
17817 (Operator::Define): Implement.
17819 2001-09-10 Ravi Pratap <ravi@ximian.com>
17821 * class.cs (Event::Define): Make the prefixes of the accessor methods
17822 addOn_ and removeOn_
17824 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
17825 of the location being passed in too. Ideally, this should go later since all
17826 error reporting should be done through the Report object.
17828 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
17829 (Populate): Iterate thru the indexers we have and define them too.
17830 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
17831 for the get and set accessors.
17832 (Indexer::Define): Implement.
17834 2001-09-09 Miguel de Icaza <miguel@ximian.com>
17836 * expression.cs (Binary::Resolve): Beginning of it. I scratched
17837 my previous implementation, did not work.
17839 * typemanager.cs: Add a couple of missing types (the longs).
17841 * literal.cs: Use TypeManager.bool_type instead of getting it.
17843 * expression.cs (EventExpr): New kind of expressions.
17844 (Expressio::ExprClassFromMemberInfo): finish
17846 2001-09-08 Miguel de Icaza <miguel@ximian.com>
17848 * assign.cs: Emit stores to static fields differently.
17850 2001-09-08 Ravi Pratap <ravi@ximian.com>
17852 * Merge in changes and adjust code to tackle conflicts. Backed out my
17853 code in Assign::Resolve ;-)
17855 2001-09-08 Ravi Pratap <ravi@ximian.com>
17857 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
17858 instead Report.Error and also pass in the location.
17859 (CSharpParser::Lexer): New readonly property to return the reference
17860 to the Tokenizer object.
17861 (declare_local_variables): Use Report.Error with location instead of plain
17865 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
17866 (Operator.CheckBinaryOperator): Ditto.
17868 * cs-parser.jay (operator_declarator): Update accordingly.
17870 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
17871 (CheckBinaryOperator): Same here.
17873 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
17874 on the name without any prefixes of namespace names etc. This is because we
17875 already might have something already fully qualified like
17876 'System.Console.WriteLine'
17878 * assign.cs (Resolve): Begin implementation. Stuck ;-)
17880 2001-09-07 Ravi Pratap <ravi@ximian.com>
17882 * cs-tokenizer.cs (location): Return a string which also contains
17885 * expression.cs (ElementAccess): New class for expressions of the
17886 type 'element access.'
17887 (BaseAccess): New class for expressions of the type 'base access.'
17888 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
17891 * cs-parser.jay (element_access): Implement action.
17892 (base_access): Implement actions.
17893 (checked_expression, unchecked_expression): Implement.
17895 * cs-parser.jay (local_variable_type): Correct and implement.
17896 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
17898 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
17900 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
17901 name and the specifiers.
17903 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
17905 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
17906 making them all public ;-)
17908 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
17911 2001-09-07 Miguel de Icaza <miguel@ximian.com>
17913 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
17915 (FieldExpr, PropertyExprs): New resolved expressions.
17916 (SimpleName::MemberStaticCheck): Perform static checks for access
17917 to non-static fields on static methods. Maybe this should be
17918 generalized for MemberAccesses.
17919 (SimpleName::ResolveSimpleName): More work on simple name
17922 * cs-parser.jay (primary_expression/qualified_identifier): track
17923 the parameter index.
17925 * codegen.cs (CodeGen::Save): Catch save exception, report error.
17926 (EmitContext::EmitBoolExpression): Chain to expression generation
17927 instead of temporary hack.
17928 (::EmitStatementExpression): Put generic expression code generation.
17930 * assign.cs (Assign::Emit): Implement variable assignments to
17931 local variables, parameters and fields.
17933 2001-09-06 Miguel de Icaza <miguel@ximian.com>
17935 * statement.cs (Block::GetVariableInfo): New method, returns the
17936 VariableInfo for a variable name in a block.
17937 (Block::GetVariableType): Implement in terms of GetVariableInfo
17939 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
17940 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
17942 2001-09-06 Ravi Pratap <ravi@ximian.com>
17944 * cs-parser.jay (operator_declaration): Continue on my quest : update
17945 to take attributes argument.
17946 (event_declaration): Ditto.
17947 (enum_declaration): Ditto.
17948 (indexer_declaration): Ditto.
17950 * class.cs (Operator::Operator): Update constructor accordingly.
17951 (Event::Event): Ditto.
17953 * delegate.cs (Delegate::Delegate): Same here.
17955 * enum.cs (Enum::Enum): Same here.
17957 2001-09-05 Ravi Pratap <ravi@ximian.com>
17959 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
17961 * ../tests/cs0658.cs : New file to demonstrate error 0658.
17963 * attribute.cs (Attributes): New class to encapsulate all attributes which were
17964 being passed around as an arraylist.
17965 (Attributes::AddAttribute): Method to add attribute sections.
17967 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
17968 (struct_declaration): Update accordingly.
17969 (constant_declaration): Update.
17970 (field_declaration): Update.
17971 (method_header): Update.
17972 (fixed_parameter): Update.
17973 (parameter_array): Ditto.
17974 (property_declaration): Ditto.
17975 (destructor_declaration): Ditto.
17977 * class.cs (Struct::Struct): Update constructors accordingly.
17978 (Class::Class): Ditto.
17979 (Field::Field): Ditto.
17980 (Method::Method): Ditto.
17981 (Property::Property): Ditto.
17982 (TypeContainer::OptAttribute): update property's return type.
17984 * interface.cs (Interface.opt_attributes): New member.
17985 (Interface::Interface): Update to take the extra Attributes argument.
17987 * parameter.cs (Parameter::Parameter): Ditto.
17989 * constant.cs (Constant::Constant): Ditto.
17991 * interface.cs (InterfaceMemberBase): New OptAttributes field.
17992 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
17993 the attributes as a parameter.
17994 (InterfaceProperty): Update constructor call.
17995 (InterfaceEvent): Ditto.
17996 (InterfaceMethod): Ditto.
17997 (InterfaceIndexer): Ditto.
17999 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
18000 pass the attributes too.
18001 (interface_event_declaration): Ditto.
18002 (interface_property_declaration): Ditto.
18003 (interface_method_declaration): Ditto.
18004 (interface_declaration): Ditto.
18006 2001-09-05 Miguel de Icaza <miguel@ximian.com>
18008 * class.cs (Method::Define): Track the "static Main" definition to
18009 create an entry point.
18011 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
18012 EntryPoint if we find it.
18014 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
18015 (EmitContext::ig): Make this variable public.
18017 * driver.cs: Make the default output file be the first file name
18018 with the .exe extension.
18020 Detect empty compilations
18022 Handle various kinds of output targets. Handle --target and
18023 rename -t to --dumper.
18025 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
18026 methods inherited from Expression return now an Expression. This
18027 will is used during the tree rewriting as we resolve them during
18030 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
18031 the spec. Missing entirely is the information about
18032 accessability of elements of it.
18034 (Expression::ExprClassFromMemberInfo): New constructor for
18035 Expressions that creates a fully initialized Expression based on
18036 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
18039 (Invocation::Resolve): Begin implementing resolution of invocations.
18041 * literal.cs (StringLiteral): Implement Emit.
18043 2001-09-05 Ravi Pratap <ravi@ximian.com>
18045 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
18048 2001-09-04 Ravi Pratap <ravi@ximian.com>
18050 * cs-parser.jay (attribute_arguments): Implement actions.
18051 (attribute): Fix bug in production. Implement action.
18052 (attribute_list): Implement.
18053 (attribute_target): Implement.
18054 (attribute_target_specifier, opt_target_specifier): Implement
18055 (CheckAttributeTarget): New method to check if the attribute target
18057 (attribute_section): Implement.
18058 (opt_attributes): Implement.
18060 * attribute.cs : New file to handle attributes.
18061 (Attribute): Class to hold attribute info.
18063 * cs-parser.jay (opt_attribute_target_specifier): Remove production
18064 (attribute_section): Modify production to use 2 different rules to
18065 achieve the same thing. 1 s/r conflict down !
18066 Clean out commented, useless, non-reducing dimension_separator rules.
18068 * class.cs (TypeContainer.attributes): New member to hold list
18069 of attributes for a type.
18070 (Struct::Struct): Modify to take one more argument, the attribute list.
18071 (Class::Class): Ditto.
18072 (Field::Field): Ditto.
18073 (Method::Method): Ditto.
18074 (Property::Property): Ditto.
18076 * cs-parser.jay (struct_declaration): Update constructor call to
18077 pass in the attributes too.
18078 (class_declaration): Ditto.
18079 (constant_declaration): Ditto.
18080 (field_declaration): Ditto.
18081 (method_header): Ditto.
18082 (fixed_parameter): Ditto.
18083 (parameter_array): Ditto.
18084 (property_declaration): Ditto.
18086 * constant.cs (Constant::Constant): Update constructor similarly.
18087 Use System.Collections.
18089 * parameter.cs (Parameter::Parameter): Update as above.
18091 2001-09-02 Ravi Pratap <ravi@ximian.com>
18093 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
18094 (TypeContainer.delegates): New member to hold list of delegates.
18096 * cs-parser.jay (delegate_declaration): Implement the action correctly
18097 this time as I seem to be on crack ;-)
18099 2001-09-02 Miguel de Icaza <miguel@ximian.com>
18101 * rootcontext.cs (RootContext::IsNamespace): new function, used to
18102 tell whether an identifier represents a namespace.
18104 * expression.cs (NamespaceExpr): A namespace expression, used only
18105 temporarly during expression resolution.
18106 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
18107 utility functions to resolve names on expressions.
18109 2001-09-01 Miguel de Icaza <miguel@ximian.com>
18111 * codegen.cs: Add hook for StatementExpressions.
18113 * class.cs: Fix inverted test for static flag in methods.
18115 2001-09-02 Ravi Pratap <ravi@ximian.com>
18117 * class.cs (Operator::CheckUnaryOperator): Correct error number used
18118 to make it coincide with MS' number.
18119 (Operator::CheckBinaryOperator): Ditto.
18121 * ../errors/errors.txt : Remove error numbers added earlier.
18123 * ../errors/cs1019.cs : Test case for error # 1019
18125 * ../errros/cs1020.cs : Test case for error # 1020
18127 * cs-parser.jay : Clean out commented cruft.
18128 (dimension_separators, dimension_separator): Comment out. Ostensibly not
18129 used anywhere - non-reducing rule.
18130 (namespace_declarations): Non-reducing rule - comment out.
18132 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
18133 with TypeContainer::AddEnum.
18135 * delegate.cs : New file for delegate handling classes.
18136 (Delegate): Class for declaring delegates.
18138 * makefile : Update.
18140 * cs-parser.jay (delegate_declaration): Implement.
18142 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
18144 * class.cs (Event::Define): Implement.
18145 (Event.EventBuilder): New member.
18147 * class.cs (TypeContainer::Populate): Update to define all enums and events
18149 (Events): New property for the events arraylist we hold. Shouldn't we move to using
18150 readonly fields for all these cases ?
18152 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
18154 * class.cs (Property): Revamp to use the convention of making fields readonly.
18155 Accordingly modify code elsewhere.
18157 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
18158 the Define method of the Property class.
18160 * class.cs : Clean up applied patch and update references to variables etc. Fix
18162 (TypeContainer::Populate): Update to define all the properties we have. Also
18163 define all enumerations.
18165 * enum.cs (Define): Implement.
18167 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
18169 * cs-parser.jay (overloadable_operator): The semantic value is an
18170 enum of the Operator class.
18171 (operator_declarator): Implement actions.
18172 (operator_declaration): Implement.
18174 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
18175 validity of definitions.
18176 (Operator::CheckBinaryOperator): Static method to check for binary operators
18177 (TypeContainer::AddOperator): New method to add an operator to a type.
18179 * cs-parser.jay (indexer_declaration): Added line to actually call the
18180 AddIndexer method so it gets added ;-)
18182 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
18183 already taken care of by the MS compiler ?
18185 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
18187 * class.cs (Operator): New class for operator declarations.
18188 (Operator::OpType): Enum for the various operators.
18190 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
18192 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
18193 ostensibly handle this in semantic analysis.
18195 * cs-parser.jay (general_catch_clause): Comment out
18196 (specific_catch_clauses, specific_catch_clause): Ditto.
18197 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
18198 (catch_args, opt_catch_args): New productions.
18199 (catch_clause): Rewrite to use the new productions above
18200 (catch_clauses): Modify accordingly.
18201 (opt_catch_clauses): New production to use in try_statement
18202 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
18203 and re-write the code in the actions to extract the specific and
18204 general catch clauses by being a little smart ;-)
18206 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
18207 Hooray, try and catch statements parse fine !
18209 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
18211 * statement.cs (Block::GetVariableType): Fix logic to extract the type
18212 string from the hashtable of variables.
18214 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
18215 I end up making that mistake ;-)
18216 (catch_clauses): Fixed gross error which made Key and Value of the
18217 DictionaryEntry the same : $1 !!
18219 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
18221 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
18223 * cs-parser.jay (event_declaration): Correct to remove the semicolon
18224 when the add and remove accessors are specified.
18226 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
18228 * cs-parser.jay (IndexerDeclaration): New helper class to hold
18229 information about indexer_declarator.
18230 (indexer_declarator): Implement actions.
18231 (parsing_indexer): New local boolean used to keep track of whether
18232 we are parsing indexers or properties. This is necessary because
18233 implicit_parameters come into picture even for the get accessor in the
18234 case of an indexer.
18235 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
18237 * class.cs (Indexer): New class for indexer declarations.
18238 (TypeContainer::AddIndexer): New method to add an indexer to a type.
18239 (TypeContainer::indexers): New member to hold list of indexers for the
18242 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
18244 * cs-parser.jay (add_accessor_declaration): Implement action.
18245 (remove_accessor_declaration): Implement action.
18246 (event_accessors_declaration): Implement
18247 (variable_declarators): swap statements for first rule - trivial.
18249 * class.cs (Event): New class to hold information about event
18251 (TypeContainer::AddEvent): New method to add an event to a type
18252 (TypeContainer::events): New member to hold list of events.
18254 * cs-parser.jay (event_declaration): Implement actions.
18256 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
18258 * cs-parser.jay (dim_separators): Implement. Make it a string
18259 concatenating all the commas together, just as they appear.
18260 (opt_dim_separators): Modify accordingly
18261 (rank_specifiers): Update accordingly. Basically do the same
18262 thing - instead, collect the brackets here.
18263 (opt_rank_sepcifiers): Modify accordingly.
18264 (array_type): Modify to actually return the complete type string
18265 instead of ignoring the rank_specifiers.
18266 (expression_list): Implement to collect the expressions
18267 (variable_initializer): Implement. We make it a list of expressions
18268 essentially so that we can handle the array_initializer case neatly too.
18269 (variable_initializer_list): Implement.
18270 (array_initializer): Make it a list of variable_initializers
18271 (opt_array_initializer): Modify accordingly.
18273 * expression.cs (New::NType): Add enumeration to help us
18274 keep track of whether we have an object/delegate creation
18275 or an array creation.
18276 (New:NewType, New::Rank, New::Indices, New::Initializers): New
18277 members to hold data about array creation.
18278 (New:New): Modify to update NewType
18279 (New:New): New Overloaded contructor for the array creation
18282 * cs-parser.jay (array_creation_expression): Implement to call
18283 the overloaded New constructor.
18285 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
18287 * class.cs (TypeContainer::Constructors): Return member
18288 constructors instead of returning null.
18290 2001-08-26 Miguel de Icaza <miguel@ximian.com>
18292 * typemanager.cs (InitCoreTypes): Initialize the various core
18293 types after we have populated the type manager with the user
18294 defined types (this distinction will be important later while
18295 compiling corlib.dll)
18297 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
18298 on Expression Classification. Now all expressions have a method
18299 `Resolve' and a method `Emit'.
18301 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
18302 generation from working. Also add some temporary debugging
18305 2001-08-24 Miguel de Icaza <miguel@ximian.com>
18307 * codegen.cs: Lots of code generation pieces. This is only the
18308 beginning, will continue tomorrow with more touches of polish. We
18309 handle the fundamentals of if, while, do, for, return. Others are
18310 trickier and I need to start working on invocations soon.
18312 * gen-treedump.cs: Bug fix, use s.Increment here instead of
18315 * codegen.cs (EmitContext): New struct, used during code
18316 emission to keep a context. Most of the code generation will be
18319 * cs-parser.jay: Add embedded blocks to the list of statements of
18320 this block. So code generation proceeds in a top down fashion.
18322 2001-08-23 Miguel de Icaza <miguel@ximian.com>
18324 * statement.cs: Add support for multiple child blocks.
18326 2001-08-22 Miguel de Icaza <miguel@ximian.com>
18328 * codegen.cs (EmitCode): New function, will emit the code for a
18329 Block of code given a TypeContainer and its ILGenerator.
18331 * statement.cs (Block): Standard public readonly optimization.
18332 (Block::Block constructors): Link children.
18333 (Block::Child): Child Linker.
18334 (Block::EmitVariables): Emits IL variable declarations.
18336 * class.cs: Drop support for MethodGroups here, delay until
18338 (Method::): Applied the same simplification that I did before, and
18339 move from Properties to public readonly fields.
18340 (Method::ParameterTypes): Returns the parameter types for the
18341 function, and implements a cache that will be useful later when I
18342 do error checking and the semantic analysis on the methods is
18344 (Constructor::GetCallingConvention): Renamed from CallingConvetion
18345 and made a method, optional argument tells whether this is a class
18346 or a structure to apply the `has-this' bit.
18347 (Method::GetCallingConvention): Implement, returns the calling
18349 (Method::Define): Defines the type, a second pass is performed
18350 later to populate the methods.
18352 (Constructor::ParameterTypes): implement a cache similar to the
18353 one on Method::ParameterTypes, useful later when we do semantic
18356 (TypeContainer::EmitMethod): New method. Emits methods.
18358 * expression.cs: Removed MethodGroup class from here.
18360 * parameter.cs (Parameters::GetCallingConvention): new method.
18362 2001-08-21 Miguel de Icaza <miguel@ximian.com>
18364 * class.cs (TypeContainer::Populate): Drop RootContext from the
18367 (Constructor::CallingConvention): Returns the calling convention.
18368 (Constructor::ParameterTypes): Returns the constructor parameter
18371 (TypeContainer::AddConstructor): Keep track of default constructor
18372 and the default static constructor.
18374 (Constructor::) Another class that starts using `public readonly'
18375 instead of properties.
18377 (Constructor::IsDefault): Whether this is a default constructor.
18379 (Field::) use readonly public fields instead of properties also.
18381 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
18382 track of static constructors; If none is used, turn on
18383 BeforeFieldInit in the TypeAttributes.
18385 * cs-parser.jay (opt_argument_list): now the return can be null
18386 for the cases where there are no arguments.
18388 (constructor_declarator): If there is no implicit `base' or
18389 `this', then invoke the default parent constructor.
18391 * modifiers.cs (MethodAttr): New static function maps a set of
18392 modifiers flags into a MethodAttributes enum
18393 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
18394 MethodAttr, TypeAttr to represent the various mappings where the
18395 modifiers are used.
18396 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
18398 2001-08-19 Miguel de Icaza <miguel@ximian.com>
18400 * parameter.cs (GetParameterInfo): Fix bug where there would be no
18403 * interface.cs (PopulateIndexer): Implemented the code generator
18404 for interface indexers.
18406 2001-08-17 Miguel de Icaza <miguel@ximian.com>
18408 * interface.cs (InterfaceMemberBase): Now we track the new status
18411 (PopulateProperty): Implement property population. Woohoo! Got
18412 Methods and Properties going today.
18414 Removed all the properties for interfaces, and replaced them with
18415 `public readonly' fields.
18417 2001-08-16 Miguel de Icaza <miguel@ximian.com>
18419 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
18420 initialize their hashtables/arraylists only when they are needed
18421 instead of doing this always.
18423 * parameter.cs: Handle refs and out parameters.
18425 * cs-parser.jay: Use an ArrayList to construct the arguments
18426 instead of the ParameterCollection, and then cast that to a
18429 * parameter.cs: Drop the use of ParameterCollection and use
18430 instead arrays of Parameters.
18432 (GetParameterInfo): Use the Type, not the Name when resolving
18435 2001-08-13 Miguel de Icaza <miguel@ximian.com>
18437 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
18438 and instead use public readonly fields.
18440 * class.cs: Put back walking code for type containers.
18442 2001-08-11 Miguel de Icaza <miguel@ximian.com>
18444 * class.cs (MakeConstant): Code to define constants.
18446 * rootcontext.cs (LookupType): New function. Used to locate types
18449 2001-08-08 Miguel de Icaza <miguel@ximian.com>
18451 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
18452 this System.Reflection code is. Kudos to Microsoft
18454 * typemanager.cs: Implement a type cache and avoid loading all
18455 types at boot time. Wrap in LookupType the internals. This made
18456 the compiler so much faster. Wow. I rule!
18458 * driver.cs: Make sure we always load mscorlib first (for
18459 debugging purposes, nothing really important).
18461 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
18462 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
18464 * rootcontext.cs: Lookup types on their namespace; Lookup types
18465 on namespaces that have been imported using the `using' keyword.
18467 * class.cs (TypeContainer::TypeAttr): Virtualize.
18468 (Class::TypeAttr): Return attributes suitable for this bad boy.
18469 (Struct::TypeAttr): ditto.
18470 Handle nested classes.
18471 (TypeContainer::) Remove all the type visiting code, it is now
18472 replaced with the rootcontext.cs code
18474 * rootcontext.cs (GetClassBases): Added support for structs.
18476 2001-08-06 Miguel de Icaza <miguel@ximian.com>
18478 * interface.cs, statement.cs, class.cs, parameter.cs,
18479 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
18480 Drop use of TypeRefs, and use strings instead.
18482 2001-08-04 Miguel de Icaza <miguel@ximian.com>
18486 * class.cs (Struct::Struct): set the SEALED flags after
18487 checking the modifiers.
18488 (TypeContainer::TypeAttr): new property, returns the
18489 TypeAttributes for a class.
18491 * cs-parser.jay (type_list): Oops, list production was creating a
18492 new list of base types.
18494 * rootcontext.cs (StdLib): New property.
18495 (GetInterfaceTypeByName): returns an interface by type name, and
18496 encapsulates error handling here.
18497 (GetInterfaces): simplified.
18498 (ResolveTree): Encapsulated all the tree resolution here.
18499 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
18502 * driver.cs: Add support for --nostdlib, to avoid loading the
18503 default assemblies.
18504 (Main): Do not put tree resolution here.
18506 * rootcontext.cs: Beginning of the class resolution.
18508 2001-08-03 Miguel de Icaza <miguel@ximian.com>
18510 * rootcontext.cs: Provide better error reporting.
18512 * cs-parser.jay (interface_base): set our $$ to be interfaces.
18514 * rootcontext.cs (CreateInterface): Handle the case where there
18515 are no parent interfaces.
18517 (CloseTypes): Routine to flush types at the end.
18518 (CreateInterface): Track types.
18519 (GetInterfaces): Returns an array of Types from the list of
18520 defined interfaces.
18522 * typemanager.c (AddUserType): Mechanism to track user types (puts
18523 the type on the global type hash, and allows us to close it at the
18526 2001-08-02 Miguel de Icaza <miguel@ximian.com>
18528 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
18529 RecordInterface instead.
18531 * cs-parser.jay: Updated to reflect changes above.
18533 * decl.cs (Definition): Keep track of the TypeBuilder type that
18534 represents this type here. Not sure we will use it in the long
18535 run, but wont hurt for now.
18537 * driver.cs: Smaller changes to accomodate the new code.
18539 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
18542 * rootcontext.cs (CreateInterface): New method, used to create
18543 the System.TypeBuilder type for interfaces.
18544 (ResolveInterfaces): new entry point to resolve the interface
18546 (CodeGen): Property, used to keep track of the code generator.
18548 2001-07-26 Miguel de Icaza <miguel@ximian.com>
18550 * cs-parser.jay: Add a second production for delegate_declaration
18553 (enum_body): Put an opt_comma here instead of putting it on
18554 enum_body or enum_member_declarations so we can handle trailing
18555 commas on enumeration members. Gets rid of a shift/reduce.
18557 (type_list): Need a COMMA in the middle.
18559 (indexer_declaration): Tell tokenizer to recognize get/set
18561 * Remove old targets.
18563 * Re-add the parser target.
18565 2001-07-13 Simon Cozens <simon@simon-cozens.org>
18567 * cs-parser.jay: Add precendence rules for a number of operators
18568 ot reduce the number of shift/reduce conflicts in the grammar.
18570 2001-07-17 Miguel de Icaza <miguel@ximian.com>
18572 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
18575 Get rid of old crufty code.
18577 * rootcontext.cs: Use this to keep track of the parsed
18578 representation and the defined types available to the program.
18580 * gen-treedump.cs: adjust for new convention.
18582 * type.cs: Split out the type manager, and the assembly builder
18585 * typemanager.cs: the type manager will live here now.
18587 * cil-codegen.cs: And the code generator here.
18589 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
18591 * makefile: Fixed up for easy making.
18593 2001-07-13 Simon Cozens <simon@simon-cozens.org>
18595 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
18598 (unary_expression): Expand pre_increment_expression and
18599 post_decrement_expression to reduce a shift/reduce.
18601 2001-07-11 Simon Cozens
18603 * cs-tokenizer.cs: Hex numbers should begin with a 0.
18605 Improve allow_keyword_as_indent name.
18607 2001-06-19 Miguel de Icaza <miguel@ximian.com>
18609 * Adjustments for Beta2.
18611 2001-06-13 Miguel de Icaza <miguel@ximian.com>
18613 * decl.cs: Added `Define' abstract method.
18614 (InTransit): new property, used to catch recursive definitions.
18616 * interface.cs: Implement `Define'.
18618 * modifiers.cs: Map Modifiers.constants to
18619 System.Reflection.TypeAttribute flags.
18621 * class.cs: Keep track of types and user-defined types.
18622 (BuilderInit): New method for creating an assembly
18623 (ResolveType): New function to launch the resolution process, only
18624 used by interfaces for now.
18626 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
18627 that are inserted into the name space.
18629 2001-06-08 Miguel de Icaza <miguel@ximian.com>
18631 * ARGH. I have screwed up my tree so many times due to the use of
18632 rsync rather than using CVS. Going to fix this at once.
18634 * driver.cs: Objetify driver. Load assemblies, use assemblies to
18637 2001-06-07 Miguel de Icaza <miguel@ximian.com>
18639 * Experiment successful: Use System.Type rather that our own
18642 2001-05-25 Miguel de Icaza <miguel@ximian.com>
18644 * cs-parser.jay: Removed nsAliases from here.
18646 Use new namespaces, handle `using XXX;'
18648 * namespace.cs: Reimplemented namespace handling, use a recursive
18649 definition of the class. Now we can keep track of using clauses
18650 and catch invalid using clauses.
18652 2001-05-24 Miguel de Icaza <miguel@ximian.com>
18654 * gen-treedump.cs: Adapted for all the renaming.
18656 * expression.cs (Expression): this class now has a Type property
18657 which returns an expression Type.
18659 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
18660 `Type', as this has a different meaning now in the base
18662 2001-05-22 Miguel de Icaza <miguel@ximian.com>
18664 * interface.cs, class.cs: Removed from all the sources the
18665 references to signature computation, as we can not do method
18666 signature computation during the parsing time, as we are not
18667 trying to solve at that point distinguishing:
18671 void a (NS.Blah x) {}
18674 Which depending on the context might be valid or not, as we do not
18675 know if Blah is the same thing as NS.Blah at that point.
18677 * Redid everything so the code uses TypeRefs now instead of
18678 Types. TypeRefs are just temporary type placeholders, that need
18679 to be resolved. They initially have a pointer to a string and the
18680 current scope in which they are used. This is used later by the
18681 compiler to resolve the reference to an actual Type.
18683 * DeclSpace is no longer a CIR.Type, and neither are
18684 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
18685 are all DeclSpaces, but no Types.
18687 * type.cs (TypeRefManager): This implements the TypeRef manager,
18688 which keeps track of all the types that need to be resolved after
18689 the parsing has finished.
18691 2001-05-13 Miguel de Icaza <miguel@ximian.com>
18693 * ARGH. We are going to have to store `foreach' as a class rather
18694 than resolving it, as we need to verify error 1579 after name
18695 resolution. *OR* we could keep a flag that says `This request to
18696 IEnumerator comes from a foreach statement' which we can then use
18697 to generate the error.
18699 2001-05-10 Miguel de Icaza <miguel@ximian.com>
18701 * class.cs (TypeContainer.AddMethod): we now add methods to the
18702 MethodGroup instead of the method hashtable.
18704 * expression.cs: Add MethodGroup abstraction, which gets us one
18705 step closer to the specification in the way we handle method
18708 * cs-parser.jay (primary_expression): qualified_identifier now
18709 tried to match up an identifier to a local variable reference or
18710 to a parameter reference.
18712 current_local_parameters is now a parser global variable that
18713 points to the current parameters for the block, used during name
18716 (property_declaration): Now creates an implicit `value' argument to
18719 2001-05-09 Miguel de Icaza <miguel@ximian.com>
18721 * parameter.cs: Do not use `param' arguments as part of the
18722 signature, per the spec.
18724 2001-05-08 Miguel de Icaza <miguel@ximian.com>
18726 * decl.cs: Base class for classes, structs and interfaces. This
18727 is the "Declaration Space"
18729 * cs-parser.jay: Use CheckDef for checking declaration errors
18730 instead of having one on each function.
18732 * class.cs: Factor out some code for handling error handling in
18733 accordance to the "Declarations" section in the "Basic Concepts"
18734 chapter in the ECMA C# spec.
18736 * interface.cs: Make all interface member classes derive from
18737 InterfaceMemberBase.
18739 2001-05-07 Miguel de Icaza <miguel@ximian.com>
18741 * Many things: all interfaces are parsed and generated in
18742 gen-treedump. Support for member variables, constructors,
18743 destructors, properties, constants is there.
18745 Beginning of the IL backend, but very little done, just there for
18748 2001-04-29 Miguel de Icaza <miguel@ximian.com>
18750 * cs-parser.jay: Fix labeled statement.
18752 * cs-tokenizer.cs (escape): Escape " and ' always.
18753 ref_line, ref_name: keep track of the line/filename as instructed
18754 by #line by the compiler.
18757 2001-04-27 Miguel de Icaza <miguel@ximian.com>
18759 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
18760 to match the values in System.CodeDOM.
18762 Divid renamed to Divide.
18764 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
18766 (Statements.set): remove.
18768 * System.CodeDOM/CodeCatchClause.cs: always have a valid
18771 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
18772 falseStatements always have valid values.
18774 * cs-parser.jay: Use System.CodeDOM now.