1 2005-02-02 Martin Baulig <martin@ximian.com>
3 * delegate.cs (Delegate.DefineType): Report an internal error if
4 TypeManager.multicast_delegate_type is null. See bug #72015 for
7 2005-01-29 Miguel de Icaza <miguel@novell.com>
9 * pending.cs: Produce better code (no nops produced by using Ldarg
12 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
13 i - 1' it should be arg + 1.
17 2005-01-26 Martin Baulig <martin@ximian.com>
19 * cs-parser.jay (indexer_declarator): Don't report an error if we
20 have type parameters since we can be an explicit interface
21 implementation; fixes #71449.
23 2005-01-26 Martin Baulig <martin@ximian.com>
25 * class.cs (TypeContainer.AttributeTargets): Return the correct
26 AttributeTargets depending on our `Kind' instead of throwing an
27 exception; fixes #71632.
29 2005-01-26 Martin Baulig <martin@ximian.com>
31 * delegate.cs (Delegate.DefineType): Correctly define our type
32 parameters. Fixes #71483.
34 2005-01-25 Raja R Harinath <rharinath@novell.com>
37 * expression.cs (MemberAccess.DoResolve): Don't complain with
38 cs0572 when the LHS of a member access has identical name and type
41 2005-01-25 Marek Safar <marek.safar@seznam.cz>
44 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
46 Create custom PermissionSet only for PermissionSetAttribute.
48 2005-01-24 Marek Safar <marek.safar@seznam.cz>
51 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
52 delegates in static class.
54 2005-01-24 Martin Baulig <martin@ximian.com>
56 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
57 merging an implicit block, just use its reachability.
59 * statement.cs (Block.Resolve): Make the unreachable code check
60 work wrt. implicit blocks; see test-337 from #63842.
62 2005-01-21 Alp Toker <alp@atoker.com>
64 * cs-parser.jay: destructor_declaration's container is PartialContainer
65 not Class when partial types are used, so use Kind prop instead of
68 2005-01-22 Miguel de Icaza <miguel@ximian.com>
70 * cs-parser.jay: Improve error reporting when an interface
73 2005-01-20 Dick Porter <dick@ximian.com>
75 * support.cs: SeekableStreamReader fix from Sandor Dobos
76 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
77 chars are read. Fixes bug 70369.
79 2005-01-20 Raja R Harinath <rharinath@novell.com>
81 * cs-parser.jay (catch_clause): Simplify current_block handling
84 2005-01-17 Miguel de Icaza <miguel@ximian.com>
86 * convert.cs (ImplicitStandardConversionExists): Synchronize the
87 code with ImplicitStandardConversion to handle the implicit
88 conversion of method groups into valid delegate invocations.
90 The problem is that in parameter handling we were using this code
91 path. Fixes bug #64698
93 2005-01-19 Raja R Harinath <rharinath@novell.com>
95 * cs-parser.jay: Fix several infelicities.
96 - Avoid assigning to the parser value stack. Code like
97 '$3 = null' is unclean. Synthesize a value for the code block
99 - Avoid using oob_stack for storing location information. Use ...
100 (_mark_): ... this. New (empty) rule. Saves the current location
102 (foreach_statement): Avoid using oob_stack for current_block
103 handling. Use technique used in for_statement and
104 using_statement. Synthesize a value for the code block to store
105 additional intermediate information.
107 2005-01-13 Miguel de Icaza <miguel@ximian.com>
109 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
110 of a different type is only allowed to private fields of a
111 containing type, not on fields of a base class.
113 See test-174.cs and error cs0122-9.cs
115 2005-01-13 Raja R Harinath <rharinath@novell.com>
117 Fix test-335.cs (bug #58126).
118 * cs-parser.jay (argument): Split out non-expression parts of the
119 rule into 'non_simple_argument'.
120 (invocation_expression): Support parenthesized invocations with
121 multiple arguments, and with single non-simple arguments.
123 2005-01-13 Raja R Harinath <rharinath@novell.com>
125 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
128 2005-01-12 Raja R Harinath <rharinath@novell.com>
130 Fix cs0038-1.cs, cs1640-6.cs.
131 * ecore.cs (Expression.Resolve): Remove special-case for
132 SimpleName in error-handling.
133 (Expression.almostMatchedMembers): Relax access permission to
135 (Expression.MemberLookupFailed): Handle duplicates in
136 almostMatchedMembers list.
137 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
138 * expression.cs (New.DoResolve): Report CS1540 for more cases.
139 * typemanager.cs (GetFullNameSignature): Use the MethodBase
140 overload if the passed in MemberInfo is a MethodBase.
142 2005-01-25 Martin Baulig <martin@ximian.com>
145 (DocUtil.emptyParamList): Removed; use `Type.EmptyTypes' instead.
147 2005-01-12 Marek Safar <marek.safar@seznam.cz>
150 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
151 for non-CAS & merge permission sets properly.
153 2005-01-11 Raja R Harinath <rharinath@novell.com>
155 Improve standard-compliance of simple name and member access
156 resolution. Fixes bugs #52697, #57200, #67520, #69519.
157 * ecore.cs (FullNamedExpression): New abstract base class
158 for Namespaces and TypeExpressions.
159 (ResolveFlags.SimpleName): Remove.
160 (SimpleName): Remove support for dotted names.
161 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
162 DeclSpace.FindType and DeclSpace.LookupType.
163 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
164 (Expression.ExprClassName): Make member function.
165 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
166 a namespace. Remove creation of dotted "SimpleName"s.
167 (MemberAccess.DoResolve): Likewise.
168 * decl.cs (DeclSpace.Cache): Make private.
169 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
170 (DeclSpace.FindType): Update.
171 (DeclSpace.LookupType): Move here from RootContext. Return a
173 * namespace.cs (Namespace): Derive from FullNamedExpression
174 so that it can be part of expression resolution.
175 (Namespace.Lookup): Return an FullNamedExpression.
176 (NamespaceEntry.LookupAlias): Lookup aliases only in current
178 * rootcontext.cs (NamespaceLookup): Remove.
179 (LookupType): Move to DeclSpace.
180 * attribute.cs (CheckAttributeType): Update.
181 * doc.cs (FindDocumentedType): Remove allowAlias argument.
182 (FindDocumentedTypeNonArray): Likewise.
184 2005-01-11 Raja R Harinath <rharinath@novell.com>
186 Fix cs0509.cs, cs1632.cs.
187 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
188 is the same as IsInterface.
189 (TypeContainer.GetClassBases): Likewise.
190 * statement.cs (LabeledStatement.ig): New field.
191 (LabeledStatement.LabelTarget): Save ILGenerator which created the
193 (LabeledStatement.DoEmit): Check that the label was created with
194 the same ILGenerator.
196 2005-01-10 Marek Safar <marek.safar@seznam.cz>
199 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
200 accessors to its properties.
202 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
203 from accessors to property.
205 2005-01-10 Marek Safar <marek.safar@seznam.cz>
208 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
211 2005-01-08 Miguel de Icaza <miguel@ximian.com>
213 * attribute.cs: Check for null and empty strings.
215 I have lost another battle to Paolo.
217 2005-01-07 Marek Safar <marek.safar@seznam.cz>
220 * class.cs (PropertyMethod): Set Parent field in ctors.
221 (SetMethod.InternalParameters): Add unsafe switch hack.
222 Override MarkForDuplicationCheck where it is appropriate.
224 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
225 It says whether container allows members with the same name.
227 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
228 Removed is_method parameter.
230 2005-01-06 Duncan Mak <duncan@ximian.com>
232 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
233 because the previous change led to incorrect reporting of CS1032
234 ("Cannot define/undefine preprocessor symbols after first token in
235 file"). Instead of using `tokens_seen' as the only flag that
236 triggers CS1040, introduce `comments_seen'. This new flag is used
237 to signify having seen comments on the current line, so it is
238 unset after a newline.
240 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
242 * doc.cs : When searching for a type, find nested type too.
243 This fixes bug #71040.
245 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
248 - Warn missing member comment on those classes which also does not
249 have doc comments. Fixed bug #71041.
250 - Don't warn missing doc comment on default constructor.
253 2005-01-06 Duncan Mak <duncan@ximian.com>
255 * cs-tokenizer.cs (xtoken): After handling traditional C-style
256 comments, set `tokens_seen' to true. This allows us to detect
257 misplaced preprocessor directives (i.e. not at the beginning of
258 the a line, nor after whitespaces). In that case, report error
259 CS1040. This fixes bug #56460.
261 * cs-parser.jay (interface_member_declaration): Add checks for
262 IsExplicitImpl, and report CS0541 error if an interface member is
263 defined as an explicit interface declaration.
265 2005-01-06 Marek Safar <marek.safar@seznam.cz>
268 * class.cs (PropertyMethod): Set Parent field in ctors.
269 (SetMethod.InternalParameters): Add unsafe switch hack.
271 * decl.cs (MemberCore.Parent): Cannot be readonly.
273 2005-01-06 Raja R Harinath <rharinath@novell.com>
275 * decl.cs (DeclSpace.ResolveType): Remove.
276 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
277 Merge in code from ...
278 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
279 * class.cs, enum.cs: Update to changes.
281 2005-01-06 Miguel de Icaza <miguel@ximian.com>
283 * anonymous.cs: Ensure that we init the scope of our parent if it
284 has not been initialized yet.
286 2004-12-30 Duncan Mak <duncan@ximian.com>
288 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
289 if field.FieldBuilder is null. Fixes #70758.
291 * convert.cs: Fixed some typos and updated some of the comments.
292 (ImplicitStandardConversionExists):
293 (TryImplicitIntConversion): If `target_type' is an interface and
294 the type of `ic' implements this interface, return true or a new
295 BoxedCast instead of null. This fixes #70468.
297 2004-12-29 Duncan Mak <duncan@ximian.com>
299 * expression.cs (Argument.Emit): Check that Expr is
300 IMemoryLocation before casting to it, and report CS1510 otherwise.
304 2004-12-21 Ben Maurer <bmaurer@ximian.com>
306 * statement.cs (Block.ThisVariable): remove the recursion here, to
307 make the --profile more sane.
309 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
311 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
312 assembly, by JB Evain.
314 2004-12-17 Raja R Harinath <rharinath@novell.com>
316 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
317 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
318 "parent" refers to enclosing type/class. "base" refers to superclass.
320 2004-12-17 Raja R Harinath <rharinath@novell.com>
322 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
323 Ensure that we only have GlobalAttributes.
324 * attribute.cs (Attribute.Emit): Make non-virtual.
325 (GlobalAttribute.Emit): Remove.
326 (Attribute.Resolve): Make virtual.
327 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
328 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
329 the argument. Don't create one.
330 (Attribute.GetObsoleteAttribute): Likewise.
331 (Attribute.GetClsCompliantAttributeValue): Likewise.
332 * class.cs, decl.cs: Update to changes.
334 2004-12-17 Marek Safar <marek.safar@seznam.cz>
336 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
338 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
340 * statement.cs (Foreach.Resolve): Add error 186 report.
342 2004-12-16 Marek Safar <marek.safar@seznam.cz>
344 * expression.cs (Conditional.DoResolve): Add warning 429.
346 * statement.cs (If.Resolve): Add warning 665.
348 2004-12-16 Raja R Harinath <rharinath@novell.com>
350 New invariant: RootContext.Tree.Types.NamespaceEntry == null
351 except when in the parser, and in GlobalAttribute.
352 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
353 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
354 RootContext.Tree.Types.NamespaceEntry once work is done.
355 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
356 and resets RootContext.Tree.Types.NamespaceEntry.
358 2004-12-15 Marek Safar <marek.safar@seznam.cz>
360 * cs-parser.jay: Don't create a block for every variable.
362 2004-12-14 Miguel de Icaza <miguel@ximian.com>
364 * location.cs: Provide extra information.
366 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
367 variables from the captured environment, it is the ldarg_0.
369 2004-12-14 Marek Safar <marek.safar@seznam.cz>
371 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
374 * class.cs: Changed warning level for 169 to avoid developer
375 displeasure from warning flooding. It will be changed back when they
376 fix most of current BCL warnings.
378 * RootContext.cs: Pushed default WarningLevel to 3.
380 * statement.cs: Removed unused variable.
382 2004-12-14 Marek Safar <marek.safar@seznam.cz>
384 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
385 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
386 Add error 502 report.
387 (StaticClass.DefineType): Add error 441 report.
388 (Class.AllowedModifiersProp): New virtual property as temporary
389 extension to AllowedModifiers.
390 (Class.DefineType): Add error 418 report. Moved ModFlags check here
391 to share implementation with StaticClass and don't call virtual
394 * driver.cs (MainDriver): Add error 1558 test.
396 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
397 report. Moved error 36 test here.
399 * statement.cs (Throw.Resolve): Add error 724 report.
401 * typemanager.cs: Add out_attribute_type core type.
403 2004-12-13 Marek Safar <marek.safar@seznam.cz>
405 * class.cs (TypeContainer.VerifyClsCompliance): Add error
407 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
409 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
412 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
414 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
415 Add error 3023 report.
416 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
418 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
421 2004-12-12 John Luke <john.luke@gmail.com>
423 * driver.cs (AddArgs): take -- into account when
424 adding arguments, fixes bug 65710
426 2004-12-12 Martin Baulig <martin@ximian.com>
428 * expression.cs (Unary.TryReduceNegative): Added support for
429 SByteConstant and ByteConstant.
430 (Unary.Reduce): Check error values from TryReduceNegative().
432 2004-12-10 Marek Safar <marek.safar@seznam.cz>
434 * attributes.cs (Attribute.Resolve): Avoid multiple error report
435 and report exception as error 182.
437 2004-12-10 Raja R Harinath <rharinath@novell.com>
439 * driver.cs (Main): Fix message when there are warnings.
441 2004-12-09 Miguel de Icaza <miguel@ximian.com>
443 * delegate.cs: Fixed my fix from yesterday, sorry about that.
445 2004-12-09 Marek Safar <marek.safar@seznam.cz>
447 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
448 Reduced number of warnings.
450 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
452 2004-12-08 Miguel de Icaza <miguel@ximian.com>
454 * driver.cs: Removed message.
456 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
458 2004-12-08 <vargaz@freemail.hu>
460 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
462 2004-12-08 Martin Baulig <martin@ximian.com>
464 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
465 instead of a CS3002 for properties and indexer.
467 2004-12-08 Martin Baulig <martin@ximian.com>
469 * decl.cs (MemberName.ToString): Make this work again.
471 2004-12-08 Marek Safar <marek.safar@seznam.cz>
473 * attribute.cs (Resolve): Add error 591 detection.
475 * class.cs (FieldMember.Define): Add error 1547 detection.
476 (Indexer.Define): Add error 620 detection.
477 (Operator.Define): Add error 590 detection.
479 * ecore.cs: Missing argument for error 79.
481 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
484 2004-12-07 Marek Safar <marek.safar@seznam.cz>
487 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
490 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
492 * cs-parser.jay : handle doc comments on implicit/explicit operators.
493 Some operator comments were suppressed.
494 * doc.cs : Implicit/explicit operator name in doc comments are like
495 "op_Explicit(type)~returnType", so added suffix handling.
497 2005-01-21 Alp Toker <alp@atoker.com>
499 * cs-parser.jay: destructor_declaration's container is PartialContainer
500 not Class when partial types are used, so use Kind prop instead of 'is'.
502 2004-12-12 Martin Baulig <martin@ximian.com>
504 * expression.cs (Unary.TryReduceNegative): Added support for
505 SByteConstant and ByteConstant.
506 (Unary.Reduce): Check error values from TryReduceNegative().
508 2004-12-11 Martin Baulig <martin@ximian.com>
510 * support.cs (ReflectionParameters.ParameterName): If we have a
511 `gpd', call `ParameterName' on it.
513 * parameter.cs (Parameter.GetParameterAttributes): New static method.
515 * pending.cs (PendingImplementation.DefineProxy): Call
516 DefineParameter() for all of the MethodBuilder's arguments.
518 2004-12-09 Martin Baulig <martin@ximian.com>
520 * doc.cs (DocUtil): Make this a static class.
522 2004-12-09 Martin Baulig <martin@ximian.com>
524 * expression.cs (Invocation.InferType): Moved the type inference
525 implementation into TypeManager.
527 * generics.cs (TypeManager): Moved the type inference
530 2004-12-09 Martin Baulig <martin@ximian.com>
532 * typemanager.cs (TypeManager): Make this a partial class.
535 (TypeManager): Move the generics part of `TypeManager' here.
537 2004-12-08 Martin Baulig <martin@ximian.com>
539 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
540 instead of a CS3002 for properties and indexer. Added CS3024
541 check for generic interfaces.
543 * attributes.cs (AttributeTester.AnalyzeTypeCompliance): Generic
544 instances are not CLS-compliant.
546 2004-12-08 Martin Baulig <martin@ximian.com>
549 (void_pointer_expression): New rule for `void*', `void**' etc.
550 (typeof_expression): Add `void_pointer_expression'; fixes #66846.
552 2004-12-08 Martin Baulig <martin@ximian.com>
554 * expression.cs (Invocation.InferType): Removed the hack for
555 MethodCore.MayUnify().
557 * typemanager.cs (TypeManager.MayBecomeEqualGenericTypes): Make
560 * class.cs (MethodCore.MayUnify): Use
561 TypeManager.MayBecomeEqualGenericTypes().
563 2004-12-08 Martin Baulig <martin@ximian.com>
565 * expression.cs (Is.DoResolve, As.DoResolve): If we're a type
566 parameter, box it. Fixes #69233.
568 2004-12-08 Martin Baulig <martin@ximian.com>
570 * generic.cs (ConstructedType.CheckConstraints): Valuetypes always
571 have the ctor constraint. Fixes #68326.
573 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
575 * cs-parser.jay : interface comment was not consumed because of
576 extra opt_semicolon before doc handling.
578 2004-12-03 Raja R Harinath <rharinath@novell.com>
580 Fix test-327.cs, test-328.cs, and put in early infrastructure
581 for eventually fixing #52697.
582 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
583 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
585 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
586 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
587 (VerifyUsing, error246): Update.
588 * rootcontext.cs (RootContext.NamespaceLookup): Just use
589 'NamespaceEntry.LookupNamespaceOrType'.
591 2004-12-07 Martin Baulig <martin@ximian.com>
593 * driver.cs: Call it "BETA SOFTWARE" :-)
595 2004-12-06 Raja R Harinath <rharinath@novell.com>
597 Fix crash on cs0657-17.cs.
598 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
599 Use RootContext.Tree.Types, not 'new RootTypes ()'.
600 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
601 the case where the NamespaceEntry gets overwritten.
603 2004-12-06 Marek Safar <marek.safar@seznam.cz>
606 * ecore.cs (ResolveBoolean): Tiny refactoring.
608 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
609 of right expression resolving when left is false constant and
610 operator is LogicalAnd OR true constant and operator is LogicalOr.
612 * statement.cs (ResolveUnreachable): Always reports warning.
614 2004-12-05 Miguel de Icaza <miguel@ximian.com>
616 * class.cs: Distinguish between 1721 and 1722 (just a little help
619 2004-12-03 Miguel de Icaza <miguel@ximian.com>
621 * delegate.cs: Only allow this on new versions of the language.
623 2004-12-02 Duncan Mak <duncan@ximian.com>
625 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
627 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
628 here as a static method. Take an additional bool out parameter
629 `must_do_cs1540_check' for signaling to InstanceResolve.
630 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
631 member field from PropertyExpr class and made it an argument of
633 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
634 check for MarshalByRefObject, and report CS0122 instead of CS1540.
635 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
636 and `remove_accessor' as well as InstanceResolve: report CS0122
641 2004-12-07 Martin Baulig <martin@ximian.com>
643 * decl.cs (DeclSpace.AddToContainer): Report correct errors CS0694
644 and CS0692 where appropriate.
646 2004-12-06 Martin Baulig <martin@ximian.com>
648 * class.cs (MethodCore.MayUnify): Moved the CS0408 check here from
649 IsDuplicateImplementation() and improved it.
651 * expression.cs (Invocation.InferTypeArguments): Added
652 `Type[] inferred_class_types' argument (for MethodCore.MayUnify)
653 and removed the "ref" modifier from `infered_types'.
655 * decl.cs (MemberName.ToString): Removed the exception.
657 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
659 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
660 comments are allowed.
662 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
664 * delegate.cs: Add checks for subtypes in paramaters and return values
665 in VerifyMethod () to add support for Covariance/Contravariance
668 2004-12-02 Miguel de Icaza <miguel@ximian.com>
670 * report.cs: Remove extra closing parenthesis.
672 * convert.cs (Error_CannotImplicitConversion): If the name of the
673 types are the same, provide some extra information.
675 2004-12-02 Marek Safar <marek.safar@seznam.cz>
678 * attribute.cs (Resolve): Improved implementation of params
681 * support.cs (ParameterData): Add HasParams to be faster.
683 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
685 all things are for /doc support:
687 * doc.cs: new file that supports XML documentation generation.
688 * mcs.exe.sources: added doc.cs.
690 Handle /doc command line option.
691 Report error 2006 instead of 5 for missing file name for /doc.
692 Generate XML documentation when required, after type resolution.
694 Added support for picking up documentation (/// and /** ... */),
695 including a new XmlCommentState enumeration.
697 Added lines to fill Documentation element for field, constant,
698 property, indexer, method, constructor, destructor, operator, event
699 and class, struct, interface, delegate, enum.
700 Added lines to warn incorrect comment.
702 Added Documentation field (passed only when /doc was specified).
704 Added DocComment, DocCommentHeader, GenerateDocComment() and
705 OnGenerateDocComment() and some supporting private members for
706 /doc feature to MemberCore.
708 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
710 Added overriden DocCommentHeader.
712 Added overriden DocCommentHeader and GenerateDocComment().
714 2004-12-01 Miguel de Icaza <miguel@ximian.com>
716 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
717 unwrapping the enumeration values, chain to
718 DoConstantNumericPromotions again, so we can promote things to the
719 fundamental types (takes care of enums that are bytes, sbytes).
723 2004-12-01 Raja R Harinath <rharinath@novell.com>
725 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
726 Fix long-standing bug in type-lookup. Use FindType instead of
727 LookupType when ec.ResolvingTypeTree.
728 (Attribute.ResolveType, Attribute.Resolve)
729 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
731 (Attributes.Search): Remove internal version. Update.
732 (Attributes.SearchMulti): Update.
733 (Attributes.GetClsCompliantAttribute): Remove.
734 (Attributes.GetIndexerNameAttribute): Remove.
735 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
736 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
737 * class.cs (Indexer.Define): Likewise.
739 2004-12-01 Marek Safar <marek.safar@seznam.cz>
742 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
743 MarshallByReference members access.
745 * expression.cs: Use CheckMarshallByRefAccess;
746 Better error CS0197 message.
748 * report.cs: Print whole related error message.
750 2004-11-29 Marek Safar <marek.safar@seznam.cz>
752 * class (GetClassBases): Better error 60 report.
753 (EventProperty): Disabled warning 67 detection.
755 2004-11-29 Marek Safar <marek.safar@seznam.cz>
758 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
760 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
763 2004-11-29 Marek Safar <marek.safar@seznam.cz>
766 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
768 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
770 2004-11-26 Miguel de Icaza <miguel@ximian.com>
772 * attribute.cs (Attribute.Resolve): Refine error reporting and
773 report a cs0117 if the identifier does not exist, to distinguish
774 from 0617 which is a miss-use of the actual identifier.
776 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
777 between cs0070 and cs0079.
779 * class.cs (MemberBase.DoDefine): When reporting a wrong
780 accessibility level, we use MethodCore to compare instead of
781 Method (this was a regression in some refactoring effort).
783 So now we correctly report cs0056 again.
785 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
786 testing the target_type (which was known to be object_type) and
787 not the source type (which is anonymous_method).
789 Fixed reporting of error cs1660.
791 * expression.cs (UserCast.Source): Expose the underlying cast.
793 * statement.cs (Switch.SwitchGoverningType): Sort the list of
794 allowed types to find a match to int32 first (most common).
796 In addition, it ignores any ImplicitUserConversions that did an
797 internal implicit conversion (as the switch statement allows only
798 one integral conversion to exist).
800 * class.cs (PartialContainer.Create): rename `name' to
801 `member_name' for clarity. Then replace the string calls with a
802 call to MemberName.GetPartialName, as now using
803 MemberName.ToString is an error (this is due to the side effects
804 it had, that were fixed in the past).
806 This will restore the error reporting on a number of partial class
807 errors that were missusing this (and getting an exception as a
808 results, which is now just a plain textual warning, because
809 yyparse debug output would crash otherwise).
811 2004-11-26 Raja R Harinath <rharinath@novell.com>
813 * Makefile (PROGRAM_INSTALL_DIR): Remove.
815 2004-11-25 Ben Maurer <bmaurer@ximian.com>
817 * rootcontext.cs (LookupType): Make sure to cache lookups that
818 don't give us a negative result. This saves about 5% of corlib
821 2004-11-25 Miguel de Icaza <miguel@ximian.com>
823 * report.cs (AbstractMessage.Print): messages are sent to stderr
825 * class.cs (TypeContainer.GetClassBases): It is an error to have a
826 non-interface in the list of interfaces (at this point, either
827 parent was properly set, or a base class is being listed in the
830 This flags error 1722, and resolves the crash from bug 69259.
832 2004-11-25 Ben Maurer <bmaurer@ximian.com>
834 * statement.cs (Using.EmitExpressionFinally): make this work right
835 for valuetypes. Fixes 69926.
837 2004-11-25 Miguel de Icaza <miguel@ximian.com>
839 * const.cs (Const.ChangeType): Cope with the "0 literal can be
840 converted to an enum" here, before we try to change the underlying
841 type. This code exists, but it is a different code path than the
842 one used while encoding constants.
844 (ImplicitReferenceConversionExists): In addition, resynchronized
845 the code here, so it matches the same code in
846 ImplicitReferenceConversionExists for the `from any class-type S
847 to any interface-type T'.
849 2004-11-25 Marek Safar <marek.safar@seznam.cz>
851 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
853 2004-11-24 Miguel de Icaza <miguel@ximian.com>
855 * cs-parser.jay: Use verbosity accordingly.
857 2004-11-24 Marek Safar <marek.safar@seznam.cz>
859 * expression.cs (Unary.ResolveOperator): Do not report warning;
860 AddressOf reads from variable.
862 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
864 2004-11-24 Marek Safar <marek.safar@seznam.cz>
868 * attribute.cs (Attributable): Removed CheckTargets.
869 (Attributes.Emit): Explicit attribute targets are tested here.
871 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
872 not enabled for interfaces.
874 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
875 (GetAssemblyName): Ouch next bug there.
877 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
879 * expression.cs: Error 275 added.
881 2004-11-23 Marek Safar <marek.safar@seznam.cz>
883 Fix bug #69177 (Implemented decimal constant support)
885 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
886 (BinaryFold): Add DecimalConstant.
888 * const.cs (Define): Decimal constant
890 (ChangeType): Add decimal type handling.
891 (LookupConstantValue): Don't set value for decimal type but
892 emit DecimalConstantAttribute. Needed for constant optimization.
894 * constant.cs (ToDecimal): New method.
895 (ConvertToDecimal): New method.
896 (IntConstant): Implemented ConvertToDecimal.
897 (DecimalConstant.Emit): Emit optimized version for decimals in
900 * expression.cs (ResolveOperator): Changed order of constant
901 reduction to work correctly with native types which have
902 overloaded operators.
903 (ResolveMemberAccess): Extract constant value from attribute
906 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
908 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
909 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
910 (ChangeType): Decimal is special.
911 (TypeToCoreType): Add decimal type.
913 2004-11-22 Marek Safar <marek.safar@seznam.cz>
915 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
918 2004-11-22 Marek Safar <marek.safar@seznam.cz>
920 * class.cs (EventField.ApplyAttributeBuilder): Fix error
923 2004-11-19 Marek Safar <marek.safar@seznam.cz>
925 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
927 * pending.cs (PendingImplementation): Grab only interfaces.
929 2004-11-19 Marek Safar <marek.safar@seznam.cz>
931 * statement.cs (ForeachHelperMethods): Add location member and
934 2004-11-18 Marek Safar <marek.safar@seznam.cz>
936 * expression.cs (DoResolveBase): Fixed wrong warning for out
939 2004-12-04 Martin Baulig <martin@ximian.com>
941 * convert.cs (Convert.TypeParameter_to_Null): Use the constraints
942 to check whether the conversion is ok.
944 * typemanager.cs (TypeManager.GetTypeArguments): Just return
945 `Type.EmptyTypes' if we're not a generic TypeContainer.
947 2004-11-25 Miguel de Icaza <miguel@ximian.com>
949 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
950 old bug: when converting from the null literal to a pointer,
951 return an EmptyCast, not the NullLiteral.
953 This fixes #69921, the recent null_type changes probably made this
956 2004-12-03 Martin Baulig <martin@ximian.com>
958 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
959 method as our child, call AnonymousMethod.Compatible() on it.
961 2004-12-02 Miguel de Icaza <miguel@ximian.com>
963 * class.cs (FieldBase): Use an unused bit field from the field to
964 encode the `has_offset' property from the FieldMember. This saves
965 a couple of Ks on bootstrap compilation.
967 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
968 method as our child, return the AnonymousMethod resolved
971 * expression.cs (New.DoResolve): Allow return values from
972 NewDelegate to also include AnonymousMethods.
976 2004-11-29 Raja R Harinath <rharinath@novell.com>
978 * decl.cs (MemberCore.MemberName): Remove readonly to fix an error
980 * rootcontext.cs (ResolveCore::interfaces_first_stage): Add
981 System.Runtime.InteropServices._Exception, since it's a base
982 interface of the core type System.Exception in the net_2_0 profile.
984 2004-11-27 Martin Baulig <martin@ximian.com>
986 * ecore.cs (Expression.StoreFromPtr): Use `stobj' for generic parameters.
988 2004-11-26 Raja R Harinath <rharinath@novell.com>
990 * Makefile: Convert to use executable.make.
991 * gmcs.exe.sources: New.
993 2004-11-25 Martin Baulig <martin@ximian.com>
995 * expression.cs (Invocation.InferType): Added support for byref types.
997 2004-11-25 Martin Baulig <martin@ximian.com>
999 * statement.cs (Foreach.FetchMethodMoveNext): Wrap `mi.ReturnType'
1000 in TypeManager.TypeToCoreType().
1002 2004-11-25 Martin Baulig <martin@ximian.com>
1004 * iterators.cs (Iterator.DoDefineMembers): Override and lookup the
1005 "Dispose" method from the `current_type'.
1006 (Iterator.EmitMoveNext): Use the `dispose_method' we looked up in
1007 DoDefineMembers() instead of using the MethodBuilder; this is
1008 required for generic iterators.
1010 * class.cs (TypeContainer.DoDefineMembers): Make this virtual.
1012 2004-11-24 Martin Baulig <martin@ximian.com>
1014 * ecore.cs (Expression.LoadFromPtr): Use `ldobj' for generic parameters.
1016 2004-11-20 Martin Baulig <martin@ximian.com>
1018 * expression.cs (Invocation.InferType): Correctly infer generic
1019 instances; see gen-103.cs.
1020 (Invocation.InferTypeArguments): If a generic method doesn't have
1021 any unbound type parameters, we don't need to infer anything.
1023 2004-11-19 Raja R Harinath <rharinath@novell.com>
1025 * Makefile (gmcs.exe): Update to new location of bootstrap mcs.exe.
1027 2004-11-17 Raja R Harinath <rharinath@novell.com>
1029 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
1030 (TypeHandle.GetMemberCache): New.
1031 (TypeHandle.TypeHandle): Update.
1032 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
1033 (TypeManager.LookupParentInterfacesCache):
1034 Rename from LookupInterfaceCache. Optimize slightly.
1035 (TypeManager.MemberLookup_FindMembers): Update.
1036 * decl.cs (MemberCache.MemberCache): Set Container to null in the
1038 (AddCacheContents): Rename from AddHashtable.
1039 * class.cs (TypeContainer.parent_container): Remove.
1040 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
1041 (TypeContainer.DoDefineMembers): Don't initialize it.
1042 Update to name changes.
1044 2004-11-17 Miguel de Icaza <miguel@ximian.com>
1046 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
1047 that factors the code to check access modifiers on override.
1049 (PropertyBase): Use the code here.
1051 Patch from Lluis S'anchez, fixes bug #69361.
1053 2004-11-15 Miguel de Icaza <miguel@ximian.com>
1055 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
1056 routine that is used to report the use of a captured variable
1057 whose address has been taken.
1059 There are two checks: one when variables are being captured and
1060 the other check is when the address of a variable is taken.
1062 (because an anonymous methods might be resolved before *or* after
1063 the address has been taken) and
1065 * expression.cs (Conditional.DoResolve): Remove the special
1066 casing that Martin added to trueExpr and falseExpr being both
1067 NullLiteral. We get the right behavior now just by introducing
1068 the null_type into the compiler.
1070 * convert.cs (ExplicitConversion): Change the code to use
1071 null_type instead of testing `expr is NullLiteral'.
1072 (ImplicitConversionStandard): use null_type too.
1073 (ImplicitReferenceConversionExists): use null_type too.
1074 (ImplicitReferenceConversion): use null_type too.
1076 * literal.cs: The type of `NullLiteral' is now null_type instead
1078 (Resolve): Set the type here.
1080 * typemanager.cs: Introduce null_type.
1082 2004-11-18 Martin Baulig <martin@ximian.com>
1085 (RootContext.LookupType): Return a `Type', not a `TypeExpr'.
1087 2004-11-18 Martin Baulig <martin@ximian.com>
1089 * ecore.cs (TypeExpr.DoResolveAsTypeStep): Make this protected.
1091 2004-11-18 Martin Baulig <martin@ximian.com>
1093 * generic.cs (Constraints.Resolve): Take an `EmitContext' instead
1094 of a `DeclSpace'. If one of our constraints is a `ConstructedType',
1095 call ResolveConstructedType() on it to resolve it without checking
1097 (Constraints.ResolveTypes): Check them here.
1098 (ConstructedType.DoResolveAsTypeStep): Fully resolve ourselves,
1099 but don't check constraints.
1100 (ConstructedType.ResolveAsTypeTerminal): Override this and also
1101 check constraints here.
1102 (ConstructedType.ResolveConstructedType): New public method. This
1103 is called from DoResolveAsTypeStep() and Constraints.Resolve() to
1104 resolve ourselves without checking constraints.
1106 * ecore.cs (Expression.ResolveAsTypeTerminal): Make this virtual.
1108 2004-11-18 Martin Baulig <martin@ximian.com>
1111 (DeclSpace.CurrentType): Changed type from `TypeExpr' to `Type'.
1113 * delegate.cs (Delegate.DefineType): Always create the EmitContext.
1115 2004-11-18 Martin Baulig <martin@ximian.com>
1117 * ecore.cs (TypeExpr.ResolveType): Removed.
1118 (Expression.ResolveAsTypeTerminal): We always return a fully
1119 resolved `TypeExpr', so we can just access its `Type'.
1121 * class.cs (TypeContainer.DefineType): Resolve `CurrentType' here.
1123 2004-11-17 Martin Baulig <martin@ximian.com>
1125 * ecore.cs (IAlias.Type): Replaced with ResolveAsType() to make
1126 sure we don't return any unresolved TypeExpr's.
1127 (TypeAliasExpression): The .ctor now takes an `IAlias' instead of
1129 (Expression.ResolveAsTypeTerminal): Make sure `te.Type != null'.
1131 * expression.cs (MemberAccess.ResolveAsTypeStep): Don't return any
1132 unresolved `ConstructedType's.
1134 2004-11-17 Martin Baulig <martin@ximian.com>
1136 * ecore.cs (TypeExpr.ResolveType): Don't make this virtual.
1138 2004-11-17 Martin Baulig <martin@ximian.com>
1141 (Expression.ResolveAsTypeTerminal): Removed the `bool silent' argument.
1143 * decl.cs (DeclSpace.ResolveType): Removed.
1144 (DeclSpace.ResolveTypeExpr): Removed the `bool silent' argument.
1146 2004-11-17 Martin Baulig <martin@ximian.com>
1148 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
1149 direction, like FindMembers() does. Fixes #69546, testcase is in
1152 2004-11-16 Martin Baulig <martin@ximian.com>
1154 This is based on a patch from Marek Safar, see bug #69082.
1155 Fixes bugs #63705 and #67130.
1157 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
1158 method; create a MemberCache for an interface type and cache the
1161 * decl.cs (IMemberContainer.ParentContainer): Removed.
1162 (IMemberContainer.ParentCache): New property.
1163 (MemberCache.SetupCacheForInterface): Removed.
1164 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
1165 to create a cache for an interface's "parent".
1167 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
1170 2004-11-14 Ben Maurer <bmaurer@ximian.com>
1172 * statement.cs: Avoid adding bools to a hashtable.
1174 2004-11-15 Martin Baulig <martin@ximian.com>
1176 * decl.cs (MemberName.GetPartialName): Removed, use GetTypeName() instead.
1178 2004-11-11 Martin Baulig <martin@ximian.com>
1180 * typemanager.cs (TypeManager.GetMethodName): New method.
1182 * class.cs (MethodData.Define): Include the generic arity in the
1183 name of an explicit interface; also add it to the method name.
1185 * pending.cs (PendingImplementation.InterfaceMethod): The method
1186 name now includes the generic arity.
1188 2004-11-07 Miguel de Icaza <miguel@ximian.com>
1190 * expression.cs (Invocation.OverloadResolve): Flag error if we are
1191 calling an unsafe method from a safe location.
1193 2004-11-06 Marek Safar <marek.safar@seznam.cz>
1196 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
1198 2004-11-06 Miguel de Icaza <miguel@ximian.com>
1200 * namespace.cs (VerifyUsing): use GetPartialName instead of
1203 2004-11-05 Miguel de Icaza <miguel@ximian.com>
1205 * statement.cs (Return.Resolve): Fix regression in typo: if
1206 `in_exc', we have to request a NeedReturnLabel, this was a typo
1207 introduced in the anonymous method check-in. Fixes #69131.
1209 * Indexers were using the ShortName when defining themselves,
1210 causing a regression in the compiler bootstrap when applying the
1211 patch from 2004-11-02 (first part), now they use their full name
1212 and the bug is gone.
1214 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
1216 * driver.cs: Strip the path from the names of embedded resources. Fixes
1219 2004-11-04 Raja R Harinath <rharinath@novell.com>
1221 Fix error message regression: cs0104-2.cs.
1222 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
1223 (AliasEntry.Resolve): Update.
1224 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
1226 (RootContext.LookupType): Update.
1228 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
1230 * cs-parser.jay: Add support for handling accessor modifiers
1231 * class: Add support port accessor modifiers and error checking,
1232 define PropertyMethod.Define as virtual (not abstract anymore)
1233 * ecore.cs: Add checking for proeprties access with access modifiers
1234 * iterators.cs: Modify Accessor constructor call based in the modified
1236 2004-11-02 Ben Maurer <bmaurer@ximian.com>
1238 * expression.cs (StringConcat): Handle being called twice,
1239 as when we have a concat in a field init with more than two
1242 2004-11-02 Miguel de Icaza <miguel@ximian.com>
1244 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
1245 special case explicit implementations, we should always produce
1246 the .property or .event declaration.
1248 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
1249 since it will not return correct data if people use this
1250 unresolved in the presence of using statements (see test-313).
1252 * class.cs (MethodData.Define): If we are an explicit interface
1253 implementation, set the method name to the full name of the
1254 interface plus the name of the method.
1256 Notice that using the method.MethodName.GetFullName() does not
1257 work, as it will only contain the name as declared on the source
1258 file (it can be a shorthand in the presence of using statements)
1259 and not the fully qualifed type name, for example:
1263 class D : ICloneable {
1264 object ICloneable.Clone () {
1268 Would produce a method called `ICloneable.Clone' instead of
1269 `System.ICloneable.Clone'.
1271 * namespace.cs (Alias.Resolve): Use GetPartialName.
1273 2004-11-01 Marek Safar <marek.safar@seznam.cz>
1275 * cs-parser.jay: Add error 1055 report.
1277 2004-11-01 Miguel de Icaza <miguel@ximian.com>
1279 * assign.cs (Assign.DoResolve): Only do the transform of
1280 assignment into a New if the types are compatible, if not, fall
1281 through and let the implicit code deal with the errors and with
1282 the necessary conversions.
1284 2004-11-01 Marek Safar <marek.safar@seznam.cz>
1286 * cs-parser.jay: Add error 1031 report.
1288 * cs-tokenizer.cs: Add location for error 1038.
1290 2004-10-31 Marek Safar <marek.safar@seznam.cz>
1292 * cs-parser.jay: Add error 1016 report.
1294 2004-10-31 Marek Safar <marek.safar@seznam.cz>
1296 * cs-parser.jay: Add errors 1575,1611 report.
1298 2004-10-31 Marek Safar <marek.safar@seznam.cz>
1300 * cs-parser.jay: Add error 1001 report.
1302 2004-10-31 Marek Safar <marek.safar@seznam.cz>
1305 * attribute.cs (GetMarshal): Add method argument for
1306 caller identification.
1308 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
1309 agument for GetMarshal and RuntimeMissingSupport.
1311 2004-10-31 Marek Safar <marek.safar@seznam.cz>
1313 * attribute.cs (ExtractSecurityPermissionSet): Removed
1314 TypeManager.code_access_permission_type.
1316 * typemanager.cs: Removed TypeManager.code_access_permission_type.
1318 2004-10-27 Miguel de Icaza <miguel@ximian.com>
1320 * expression.cs (LocalVariableReference.DoResolveLValue): Check
1321 for obsolete use of a variable here. Fixes regression on errors
1322 cs0619-25 and cs0619-26.
1324 2004-10-27 Marek Safar <marek.safar@seznam.cz>
1326 Fix #62358, implemented security attribute encoding.
1328 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
1329 Tests permitted SecurityAction for assembly or other types.
1330 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
1331 data from SecurityPermissionAttribute to PermisionSet class.
1333 * class.cs (ApplyAttributeBuilder): Added special handling
1334 for System.Security.Permissions.SecurityAttribute based types.
1336 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
1337 special handling for System.Security.Permissions.SecurityAttribute
1340 * enum.cs (ApplyAttributeBuilder): Added special handling
1341 for System.Security.Permissions.SecurityAttribute based types.
1343 * parameter.cs (ApplyAttributeBuilder): Added special handling
1344 for System.Security.Permissions.SecurityAttribute based types.
1346 * rootcontext.cs: Next 2 core types.
1348 * typemanager.cs (TypeManager.security_permission_attr_type):
1349 Built in type for the SecurityPermission Attribute.
1350 (code_access_permission_type): Build in type.
1352 2004-10-17 Miguel de Icaza <miguel@ximian.com>
1354 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
1355 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
1356 all of this information into
1357 EmitContext.EmitCapturedVariableInstance.
1359 * codegen.cs (EmitCapturedVariableInstance): move here the
1360 funcionality of emitting an ldarg.0 in the presence of a
1361 remapping. This centralizes the instance emit code.
1363 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
1364 then emit a load of this: it means that we have reached the
1365 topmost ScopeInfo: the one that contains the pointer to the
1366 instance of the class hosting the anonymous method.
1368 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
1369 captures to the topmost CaptureContext.
1371 2004-10-12 Miguel de Icaza <miguel@ximian.com>
1373 * expression.cs (LocalVariableReference): Move the knowledge about
1374 the iterators into codegen's EmitCapturedVariableInstance.
1376 2004-10-11 Miguel de Icaza <miguel@ximian.com>
1378 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
1379 all code paths return a value from an anonymous method (it is the
1380 same as the 161 error, but for anonymous methods).
1382 2004-10-08 Miguel de Icaza <miguel@ximian.com>
1384 The introduction of anonymous methods in the compiler changed
1385 various ways of doing things in the compiler. The most
1386 significant one is the hard split between the resolution phase
1387 and the emission phases of the compiler.
1389 For instance, routines that referenced local variables no
1390 longer can safely create temporary variables during the
1391 resolution phase: they must do so from the emission phase,
1392 since the variable might have been "captured", hence access to
1393 it can not be done with the local-variable operations from the runtime.
1397 (Block.Flags): New flag `IsTopLevel' to indicate that this block
1398 is a toplevel block.
1400 (ToplevelBlock): A new kind of Block, these are the blocks that
1401 are created by the parser for all toplevel method bodies. These
1402 include methods, accessors and anonymous methods.
1404 These contain some extra information not found in regular blocks:
1405 A pointer to an optional CaptureContext (for tracking captured
1406 local variables and parameters). A pointer to the parent
1409 (Return.Resolve): Catch missmatches when returning a value from an
1410 anonymous method (error 1662).
1411 Invoke NeedReturnLabel from the Resolve phase instead of the emit
1414 (Break.Resolve): ditto.
1416 (SwitchLabel): instead of defining the labels during the
1417 resolution phase, we now turned the public ILLabel and ILLabelCode
1418 labels into methods called GetILLabelCode() and GetILLabel() that
1419 only define the label during the Emit phase.
1421 (GotoCase): Track the SwitchLabel instead of the computed label
1422 (its contained therein). Emit the code by using
1423 SwitchLabel.GetILLabelCode ().
1425 (LocalInfo.Flags.Captured): A new flag has been introduce to track
1426 whether the Local has been captured or not.
1428 (LocalInfo.IsCaptured): New property, used to tell whether the
1429 local has been captured.
1431 * anonymous.cs: Vastly updated to contain the anonymous method
1434 The main classes here are: CaptureContext which tracks any
1435 captured information for a toplevel block and ScopeInfo used to
1436 track the activation frames for various local variables.
1438 Each toplevel block has an optional capture context associated
1439 with it. When a method contains an anonymous method both the
1440 toplevel method and the anonymous method will create a capture
1441 context. When variables or parameters are captured, they are
1442 recorded on the CaptureContext that owns them, for example:
1446 MyDelegate d = delegate {
1451 Here `a' will be recorded as captured on the toplevel
1452 CapturedContext, the inner captured context will not have anything
1453 (it will only have data if local variables or parameters from it
1454 are captured in a nested anonymous method.
1456 The ScopeInfo is used to track the activation frames for local
1457 variables, for example:
1459 for (int i = 0; i < 10; i++)
1460 for (int j = 0; j < 10; j++){
1461 MyDelegate d = delegate {
1466 At runtime this captures a single captured variable `i', but it
1467 captures 10 different versions of the variable `j'. The variable
1468 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
1469 recorded on a child.
1471 The toplevel ScopeInfo will also track information like the `this'
1472 pointer if instance variables were referenced (this is necessary
1473 as the anonymous method lives inside a nested class in the host
1474 type of the method).
1476 (AnonymousMethod): Expanded to track the Toplevel, implement
1477 `AnonymousMethod.Compatible' to tell whether an anonymous method
1478 can be converted to a target delegate type.
1480 The routine now also produces the anonymous method content
1482 (AnonymousDelegate): A helper class that derives from
1483 DelegateCreation, this is used to generate the code necessary to
1484 produce the delegate for the anonymous method that was created.
1486 * assign.cs: API adjustments for new changes in
1487 Convert.ImplicitStandardConversionExists.
1489 * class.cs: Adjustments to cope with the fact that now toplevel
1490 blocks are of type `ToplevelBlock'.
1492 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
1493 insteda of standard blocks.
1495 Flag errors if params arguments are passed to anonymous methods.
1497 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
1498 `CurrentAnonymousMethod' which points to the current Anonymous
1499 Method. The variable points to the AnonymousMethod class that
1500 holds the code being compiled. It is set in the new EmitContext
1501 created for the anonymous method.
1503 (EmitContext.Phase): Introduce a variable and an enumeration to
1504 assist in enforcing some rules about when and where we are allowed
1505 to invoke certain methods (EmitContext.NeedsReturnLabel is the
1506 only one that enfonces this right now).
1508 (EmitContext.HaveCaptureInfo): new helper method that returns
1509 whether we have a CapturedContext initialized.
1511 (EmitContext.CaptureVariable): New method used to register that a
1512 LocalInfo must be flagged for capturing.
1514 (EmitContext.CapturedParameter): New method used to register that a
1515 parameters must be flagged for capturing.
1517 (EmitContext.CapturedField): New method used to register that a
1518 field must be flagged for capturing.
1520 (EmitContext.HaveCapturedVariables,
1521 EmitContext.HaveCapturedFields): Return whether there are captured
1522 variables or fields.
1524 (EmitContext.EmitMethodHostInstance): This is used to emit the
1525 instance for the anonymous method. The instance might be null
1526 (static methods), this (for anonymous methods that capture nothing
1527 and happen to live side-by-side with the current method body) or a
1528 more complicated expression if the method has a CaptureContext.
1530 (EmitContext.EmitTopBlock): Routine that drives the emission of
1531 code: it will first resolve the top block, then emit any metadata
1532 and then emit the code. The split is done so that we can extract
1533 any anonymous methods and flag any captured variables/parameters.
1535 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
1536 during this phase, the ILGenerator should not be used as labels
1537 and local variables declared here might not be accessible to any
1538 code that is part of an anonymous method.
1540 Exceptions to this include the temporary variables that are
1541 created by some statements internally for holding temporary
1544 (EmitContext.EmitMeta): New routine, in charge of emitting all the
1547 (EmitContext.TemporaryReturn): This method is typically called
1548 from the Emit phase, and its the only place where we allow the
1549 ReturnLabel to be defined other than the EmitMeta. The reason is
1550 that otherwise we would have to duplicate a lot of logic in the
1551 Resolve phases of various methods that today is on the Emit
1554 (EmitContext.NeedReturnLabel): This no longer creates the label,
1555 as the ILGenerator is not valid during the resolve phase.
1557 (EmitContext.EmitThis): Extended the knowledge in this class to
1558 work in anonymous methods in addition to iterators.
1560 (EmitContext.EmitCapturedVariableInstance): This emits whatever
1561 code is necessary on the stack to access the instance to a local
1562 variable (the variable will be accessed as a field).
1564 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
1565 EmitContext.EmitAddressOfParameter): Routines to support
1566 parameters (not completed at this point).
1568 Removals: Removed RemapLocal and RemapLocalLValue. We probably
1569 will also remove the parameters.
1571 * convert.cs (Convert): Define a `ConstantEC' which points to a
1572 null. This is just to prefity some code that uses
1573 ImplicitStandardConversion code and do not have an EmitContext
1576 The idea is to flag explicitly that at that point in time, it is
1577 known that the conversion will not trigger the delegate checking
1578 code in implicit conversions (which requires a valid
1581 Everywhere: pass new EmitContext parameter since
1582 ImplicitStandardConversionExists now requires it to check for
1583 anonymous method conversions.
1585 (Convert.ImplicitStandardConversionExists): If the type of an
1586 expression is the anonymous_method_type, and the type is a
1587 delegate, we invoke the AnonymousMethod.Compatible method to check
1588 whether an implicit conversion is possible.
1590 (Convert.ImplicitConversionStandard): Only do implicit method
1591 group conversions if the language level is not ISO_1.
1593 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
1594 MethodInfo for the Invoke method. used by Delegate and
1597 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
1598 method conversions if the target type is a delegate.
1600 Removed extra debugging nops.
1602 (LocalVariableReference): Turn the `local_info' into a public
1605 Add `prepared' field, the same hack used for FieldExprs to cope
1606 with composed assignments, as Local variables do not necessarily
1607 operate purely on the stack as they used to: they can be captured
1610 Add `temp' for a temporary result, like fields.
1612 Refactor DoResolve and DoResolveLValue into DoResolveBase.
1614 It now copes with Local variables that are captured and emits the
1615 proper instance variable to load it from a field in the captured
1618 (ParameterReference.DoResolveBase): During the resolve phase,
1619 capture parameters if we are in an anonymous method.
1621 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
1622 anonymous method, use the EmitContext helper routines to emit the
1623 parameter reference.
1625 * iterators.cs: Set RemapToProxy to true/false during the
1628 * parameters.cs (GetParameterByName): New helper method.
1630 * typemanager.cs (anonymous_method_type) a new type that
1631 represents an anonyous method. This is always an internal type,
1632 used as a fencepost to test against the anonymous-methodness of an
1635 2004-10-20 Marek Safar <marek.safar@seznam.cz>
1637 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
1639 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
1641 2004-11-10 Martin Baulig <martin@ximian.com>
1643 * expression.cs (Invocation.BetterFunction): If two methods have
1644 equal parameter types, but only one of them is generic, the
1645 non-generic one wins.
1646 (New.DoResolve): Don't set `is_struct' to false if we're a generic
1647 instance; just use `Type.IsValueType' to determine whether
1648 something is a struct or not.
1649 (MemberAccess.DoResolveAsTypeStep): Don't modify the `args' field,
1650 so we can be called multiple times.
1652 2004-11-10 Martin Baulig <martin@ximian.com>
1654 * generic.cs (TypeParameter.DefineConstraints): New public method.
1655 (TypeParameter.CheckAccessLevel): Override this and return true.
1656 (ConstructedType.ResolveType): Renamed to DoResolveType(), don't
1657 override ResolveType() anymore.
1658 (ConstructedType.DoResolveAsTypeStep): Call DoResolveType() here.
1660 2004-11-10 Martin Baulig <martin@ximian.com>
1662 * rootcontext.cs (RootContext.LookupType): If we're a nested type,
1663 call DeclSpace.ResolveNestedType() on it.
1665 2004-11-10 Martin Baulig <martin@ximian.com>
1667 * support.cs (ReflectionParameters.ParameterModifier): If `gpd' is
1668 non-null, call ParameterModifier() on it.
1670 2004-11-10 Martin Baulig <martin@ximian.com>
1673 (Iterators): Added `current_type' and `this_type' fields.
1674 (Iterators.DefineIterator): Create a new EmitContext and store it
1675 in `ec'; compute `this_type'.
1677 2004-11-10 Martin Baulig <martin@ximian.com>
1680 (TypeManager.IsPrivateAccessible): New public method.
1681 (Closure.Filter): Use IsPrivateAccessible() instead of IsEqual().
1683 2004-11-10 Martin Baulig <martin@ximian.com>
1685 * class.cs (TypeContainer.DefineType): Call
1686 TypeBuilder.DefineGenericParameters() before resolving the type
1688 (MethodData.parent_method): New protected field.
1689 (MethodData..ctor): Added `MethodInfo parent_method' argument.
1690 (MethodData.Define): Compute `parent_method'.
1693 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
1694 (MemberCore.GetClsCompliantAttributeValue): Likewise.
1695 (DeclSpace.ec): New protected field; store the EmitContext here.
1696 (DeclSpace.EmitContext): New public property.
1697 (DeclSpace.ResolveType): Un-comment from the [Obsolte] attribute.
1698 (DeclSpace.ResolveNestedType): New public method.
1699 (DeclSpace.ResolveTypeExpr): Just call ResolveAsTypeTerminal() here.
1700 (DeclSpace.NestedAccessible): Added `Type tb' argument.
1701 (DeclSpace.FamilyAccessible): Likewise.
1702 (DeclSpace.FindType): Call ResolveNestedType() for nested types.
1703 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
1706 * delegate.cs (Delegate.Define): Store the EmitContext in the `ec'
1709 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
1710 (Enum.Emit): Don't create a new EmitContext.
1712 2004-10-18 Martin Baulig <martin@ximian.com>
1714 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
1715 `Type' directly, but call ResolveType() on it.
1716 (Catch.Resolve): Likewise.
1717 (Foreach.Resolve): Likewise.
1719 2004-10-18 Martin Baulig <martin@ximian.com>
1721 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
1722 `Type' directly, but call ResolveType() on it.
1723 (Probe.DoResolve): Likewise.
1724 (ArrayCreation.LookupType): Likewise.
1725 (TypeOf.DoResolve): Likewise.
1726 (SizeOf.DoResolve): Likewise.
1728 2004-10-18 Raja R Harinath <rharinath@novell.com>
1730 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
1733 2004-10-17 John Luke <john.luke@gmail.com>
1735 * class.cs (Operator.GetSignatureForError): use CSharpName
1737 * parameter.cs (Parameter.GetSignatureForError): Returns
1738 correct name even if was not defined.
1740 2004-10-13 Raja R Harinath <rharinath@novell.com>
1743 * class.cs (TypeContainer.EmitContext): New property.
1744 (DefineNestedTypes): Create an emitcontext for each part.
1745 (MethodCore.DoDefineParameters): Use container's emitcontext.
1746 Pass type array to InternalParameters.
1747 (MemberBase.DoDefine): Use container's emitcontext.
1748 (FieldMember.Define): Likewise.
1749 (Event.Define): Likewise.
1750 (SetMethod.GetParameterInfo): Change argument to EmitContext.
1751 Pass type array to InternalParameters.
1752 (SetIndexerMethod.GetParameterInfo): Likewise.
1753 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
1754 * delegate.cs (Define): Pass emitcontext to
1755 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
1756 array to InternalParameters.
1757 * expression.cs (ParameterReference.DoResolveBase): Pass
1758 emitcontext to GetParameterInfo.
1759 (ComposedCast.DoResolveAsTypeStep): Remove check on
1760 ec.ResolvingTypeTree.
1761 * parameter.cs (Parameter.Resolve): Change argument to
1762 EmitContext. Use ResolveAsTypeTerminal.
1763 (Parameter.GetSignature): Change argument to EmitContext.
1764 (Parameters.ComputeSignature): Likewise.
1765 (Parameters.ComputeParameterTypes): Likewise.
1766 (Parameters.GetParameterInfo): Likewise.
1767 (Parameters.ComputeAndDefineParameterTypes): Likewise.
1768 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
1769 * support.cs (InternalParameters..ctor): Remove variant that takes
1771 * typemanager.cs (system_intptr_expr): New.
1772 (InitExpressionTypes): Initialize it.
1774 2004-10-12 Chris Toshok <toshok@ximian.com>
1776 * cs-parser.jay: fix location for try_statement and catch_clause.
1778 2004-10-18 Martin Baulig <martin@ximian.com>
1780 * class.cs (FieldMember.Define): Don't access the TypeExpr's
1781 `Type' directly, but call ResolveType() on it.
1782 (MemberBase.DoDefine): Likewise.
1784 * expression.cs (New.DoResolve): Don't access the TypeExpr's
1785 `Type' directly, but call ResolveType() on it.
1786 (ComposedCast.DoResolveAsTypeStep): Likewise.
1788 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
1789 `Type' directly, but call ResolveType() on it.
1791 2004-10-17 John Luke <john.luke@gmail.com>
1793 * class.cs (Operator.GetSignatureForError): use CSharpName
1795 * parameter.cs (Parameter.GetSignatureForError): Returns
1796 correct name even if was not defined.
1798 2004-10-13 Raja R Harinath <rharinath@novell.com>
1801 * class.cs (TypeContainer.EmitContext): New property.
1802 (DefineNestedTypes): Create an emitcontext for each part.
1803 (MethodCore.DoDefineParameters): Use container's emitcontext.
1804 Pass type array to InternalParameters.
1805 (MemberBase.DoDefine): Use container's emitcontext.
1806 (FieldMember.Define): Likewise.
1807 (Event.Define): Likewise.
1808 (SetMethod.GetParameterInfo): Change argument to EmitContext.
1809 Pass type array to InternalParameters.
1810 (SetIndexerMethod.GetParameterInfo): Likewise.
1811 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
1812 * delegate.cs (Define): Pass emitcontext to
1813 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
1814 array to InternalParameters.
1815 * expression.cs (ParameterReference.DoResolveBase): Pass
1816 emitcontext to GetParameterInfo.
1817 (ComposedCast.DoResolveAsTypeStep): Remove check on
1818 ec.ResolvingTypeTree.
1819 * parameter.cs (Parameter.Resolve): Change argument to
1820 EmitContext. Use ResolveAsTypeTerminal.
1821 (Parameter.GetSignature): Change argument to EmitContext.
1822 (Parameters.ComputeSignature): Likewise.
1823 (Parameters.ComputeParameterTypes): Likewise.
1824 (Parameters.GetParameterInfo): Likewise.
1825 (Parameters.ComputeAndDefineParameterTypes): Likewise.
1826 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
1827 * support.cs (InternalParameters..ctor): Remove variant that takes
1829 * typemanager.cs (system_intptr_expr): New.
1830 (InitExpressionTypes): Initialize it.
1832 2004-10-12 Chris Toshok <toshok@ximian.com>
1834 * cs-parser.jay: fix location for try_statement and catch_clause.
1836 2004-10-07 Raja R Harinath <rharinath@novell.com>
1838 More DeclSpace.ResolveType avoidance.
1839 * decl.cs (MemberCore.InUnsafe): New property.
1840 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
1841 with newly created EmitContext.
1842 (FieldMember.Define): Likewise.
1843 * delegate.cs (Delegate.Define): Likewise.
1844 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
1845 only if normal name-lookup fails.
1846 (TypeExpr.DoResolve): Enable error-checking.
1847 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
1848 (SizeOf.DoResolve): Likewise.
1849 (ComposedCast.DoResolveAsTypeStep): Likewise.
1850 (StackAlloc.DoResolve): Likewise.
1851 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
1852 (Block.Unsafe): New property.
1853 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
1854 (Unsafe): Set 'unsafe' flag of contained block.
1855 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
1856 (Fixed.Resolve): Likewise.
1857 (Catch.Resolve): Likewise.
1858 (Using.ResolveLocalVariableDecls): Likewise.
1859 (Foreach.Resolve): Likewise.
1861 2004-10-05 John Luke <john.luke@gmail.com>
1863 * cs-parser.jay: add location to error CS0175
1865 2004-10-04 Miguel de Icaza <miguel@ximian.com>
1867 * ecore.cs (Expression.Constantity): Add support for turning null
1870 * const.cs (Const.Define): Allow constants to be reference types
1871 as long as the value is Null.
1873 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
1875 * namespace.cs (NamespaceEntry.Using): No matter which warning
1876 level is set, check if this namespace name has already been added.
1878 2004-10-03 Ben Maurer <bmaurer@ximian.com>
1880 * expression.cs: reftype [!=]= null should always use br[true,false].
1883 2004-10-03 Marek Safar <marek.safar@seznam.cz>
1886 * attribute.cs: Enum conversion moved to
1887 GetAttributeArgumentExpression to be applied to the all
1890 2004-10-01 Raja R Harinath <rharinath@novell.com>
1892 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
1893 * class.c (TypeContainer.DefineType): Flag error if
1894 base types aren't accessible due to access permissions.
1895 * decl.cs (DeclSpace.ResolveType): Move logic to
1896 Expression.ResolveAsTypeTerminal.
1897 (DeclSpace.ResolveTypeExpr): Thin layer over
1898 Expression.ResolveAsTypeTerminal.
1899 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
1900 Refactor code into NestedAccess. Use it.
1901 (DeclSpace.NestedAccess): New.
1902 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
1903 argument to silence errors. Check access permissions.
1904 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
1905 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
1906 (Cast.DoResolve): Likewise.
1907 (New.DoResolve): Likewise.
1908 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
1909 (TypeOf.DoResolve): Likewise.
1911 * expression.cs (Invocation.BetterConversion): Return the Type of
1912 the better conversion. Implement section 14.4.2.3 more faithfully.
1913 (Invocation.BetterFunction): Make boolean. Make correspondence to
1914 section 14.4.2.2 explicit.
1915 (Invocation.OverloadResolve): Update.
1916 (Invocation): Remove is_base field.
1917 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
1918 (Invocation.Emit): Likewise.
1920 2004-09-24 Marek Safar <marek.safar@seznam.cz>
1922 * cs-parser.jay: Reverted 642 warning fix.
1924 2004-09-23 Marek Safar <marek.safar@seznam.cz>
1927 * decl.cs (FindMemberWithSameName): Indexer can have more than
1930 2004-09-23 Marek Safar <marek.safar@seznam.cz>
1932 * expression.cs (LocalVariableReference.DoResolveLValue):
1933 Do not report warning 219 for out values.
1934 (EmptyExpression.Null): New member to avoid extra allocations.
1936 2004-09-23 Marek Safar <marek.safar@seznam.cz>
1938 * cs-parser.jay: Fix wrong warning 642 report.
1940 * cs-tokenizer.cs (CheckNextToken): New helper;
1941 Inspect next character if is same as expected.
1943 2004-09-23 Martin Baulig <martin@ximian.com>
1945 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
1946 (Convert.ImplicitReferenceConversionExists): Likewise.
1948 2004-11-09 Raja R Harinath <rharinath@novell.com>
1950 * Makefile (DISTFILES): Comment out a few missing files.
1952 2004-10-29 Raja R Harinath <rharinath@novell.com>
1954 * Makefile (bootstrap_libs,bootstrap_libfiles): New.
1955 (bootstrap-libs): New target. Invokes the net_2_0_bootstrap profile.
1956 (gmcs.exe): Invoke bootstrap-libs.
1957 (clean-local): Clean the net_2_0_bootstrap profile too.
1958 (PROGRAM_INSTALL_DIR): New.
1959 (install-local): Use it.
1961 2004-10-13 Martin Baulig <martin@ximian.com>
1963 * generic.cs (TypeManager.InflatedConstraints): New nested class.
1964 (TypeParameter.DefineType): If we're a method type parameter and
1965 that method is overriding something, "inflate" its constraints.
1967 2004-10-12 Martin Baulig <martin@ximian.com>
1969 * expression.cs (MemberAccess.DoResolve): If we're a SimpleName
1970 and have type arguments, create and resolve a ConstructedType.
1972 2004-10-12 Martin Baulig <martin@ximian.com>
1974 * decl.cs (MemberCache.FindMemberToOverride): Use
1975 TypeManager.IsEqual() to compare the parameters and Type.Equals()
1976 to compare the invocationType.
1978 * typemanager.cs (TypeManager.IsEqual): Added support for arrays.
1979 When comparing two type parameters, only do the signature-only
1980 comparision for method type parameters.
1982 2004-10-11 Martin Baulig <martin@ximian.com>
1984 * report.cs: Don't make --fatal abort on warnings, we have
1985 -warnaserror for that.
1987 2004-10-11 Martin Baulig <martin@ximian.com>
1990 (TypeManager.IsEqualGenericType): Removed, use IsEqual() instead.
1991 (TypeManager.IsEqual): Call ourself recursively instead of using
1994 2004-10-11 Martin Baulig <martin@ximian.com>
1996 * class.cs (TypeContainer.DefineType): Only call TypeParameter.Define()
1997 on our own type parameters, not on the ones we inherit from a containing
2000 * expression.cs (Invocation.InferType): Use `==', not `Equals()' for
2003 * generic.cs (TypeParameter.Define): We may only be called once.
2005 * pending.cs (Pending.InterfaceMethod): Call TypeManager.Real_IsEqual()
2006 instead of TypeManager.IsEqual().
2008 2004-09-28 Martin Baulig <martin@ximian.com>
2011 (GenericConstraints.EffectiveBaseClass): New public property.
2012 (TypeParameter.GenericConstraints): New public property.
2013 (ConstructedType.CheckConstraints): Improved.
2015 * convert.cs (Convert.TypeParam_EffectiveBaseType): New private method.
2016 (Convert.TypeParameterConversion): New private method; use this in
2017 ImplicitReferenceConversion() and ImplicitReferenceConversionExists()
2018 for all conversions related to type parameters.
2020 2004-09-24 Martin Baulig <martin@ximian.com>
2022 * convert.cs (Convert.ImplicitReferenceConversion): Added implicit
2023 type parameter conversions for type parameters which are known to
2026 2004-09-24 Martin Baulig <martin@ximian.com>
2028 * generic.cs (GenericConstraints): Added `IsReferenceType' and
2029 `IsValueType' properties.
2031 * support.cs (ReflectionConstraints): Use
2032 Type.GetGenericParameterConstraints() instead of the old hack.
2034 2004-09-24 Martin Baulig <martin@ximian.com>
2036 * generic.cs (GenericConstraints): Moved here and made it an
2039 * support.cs (GenericConstraints): Moved to generic.cs.
2041 2004-09-24 Martin Baulig <martin@ximian.com>
2044 (ReflectionConstraints): Un-nested this class and made it public.
2047 (TypeManager.GetTypeParameterConstraints): New public method.
2048 (TypeManager.HasConstructorConstraint): Use the attributes.
2050 2004-09-24 Martin Baulig <martin@ximian.com>
2052 * support.cs (GenericConstraints): Replaced `HasConstructor',
2053 `IsReferenceType' and `IsValueType' with `Attributes'.
2054 (ReflectionParameters.ReflectionConstraints): Removed the Create()
2055 method and made the .ctor public.
2057 * generic.cs (Constraints.Attributes): New public property.
2058 (Constraints): Renamed `HasConstructor' -> `HasConstructorConstraint',
2059 `IsReferenceType' -> `HasReferenceTypeConstraint' and
2060 `IsValueType' -> `HasValueTypeConstraint'.
2062 2004-09-23 Martin Baulig <martin@ximian.com>
2064 * generic.cs (Constraints): Reflect latest runtime changes.
2066 2004-09-23 Martin Baulig <martin@ximian.com>
2068 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
2069 (Convert.ImplicitReferenceConversionExists): Likewise.
2071 2004-09-23 Marek Safar <marek.safar@seznam.cz>
2073 * class.cs (Operator.Define): Add error 448 and 559 report.
2075 2004-09-22 Marek Safar <marek.safar@seznam.cz>
2077 * class.cs (MemberBase.IsTypePermitted): New protected
2078 method for checking error CS0610.
2080 2004-09-22 Marek Safar <marek.safar@seznam.cz>
2082 * class.cs (TypeContainer.HasExplicitLayout): New property
2083 Returns whether container has StructLayout attribute set Explicit.
2084 (FieldMember): New abstract class for consts and fields.
2085 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
2086 (Field): Reuse FieldMember.
2088 * const.cs (Const): Reuse FieldMember.
2090 * rootcontext.cs: EmitConstants call moved to class.
2092 2004-09-22 Martin Baulig <martin@ximian.com>
2094 Marek and me just fixed one of our oldest bugs: #28562 :-)
2096 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
2098 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
2099 we're an EnumConstant, just return that.
2100 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
2101 an EnumConstant. In this case, we need to use GetValueAsEnumType()
2102 to get the value which'll actually be written into the attribute.
2103 However, we have to use GetValue() to access the attribute's value
2106 2004-09-22 Marek Safar <marek.safar@seznam.cz>
2108 * constant.cs (Constant.IsNegative): New abstract property
2111 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
2112 (StackAlloc.DoResolve): Reused IsNegative.
2114 2004-09-22 Martin Baulig <martin@ximian.com>
2116 * typemanager.cs (TypeManager.LookupGenericTypeContainer): New
2117 public method; like LookupTypeContainer, but also works for
2120 * report.cs (Report.SymbolRelatedToPreviousError): Use
2121 TypeManager.LookupGenericTypeContainer().
2123 2004-09-22 Martin Baulig <martin@ximian.com>
2125 Thanks to Peter Sestoft for this bug report.
2127 * expression.cs (Conditional): If both the `trueExpr' and the
2128 `falseExpr' is a NullLiteral, return a NullLiteral.
2130 2004-09-22 Martin Baulig <martin@ximian.com>
2132 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
2133 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
2134 for the "get_Current" call.
2136 2004-09-21 Martin Baulig <martin@ximian.com>
2138 * convert.cs (Convert.ImplicitReferenceConversion): When
2139 converting to an interface type, first check whether we're
2140 converting from a reference type.
2142 2004-09-14 Martin Baulig <martin@ximian.com>
2144 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
2146 2004-09-14 Marek Safar <marek.safar@seznam.cz>
2149 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
2150 called and is obsolete then this member suppress message
2151 when call is inside next [Obsolete] method or type.
2153 * expression.cs: Use TestObsoleteMethodUsage member.
2155 2004-09-14 Martin Baulig <martin@ximian.com>
2157 * genericparser.cs: Removed.
2159 2004-09-13 Marek Safar <marek.safar@seznam.cz>
2161 * class.cs (MethodCore.CheckBase): Fix bug #65757.
2163 2004-09-12 Marek Safar <marek.safar@seznam.cz>
2165 * attribute.cs (Attribute.Resolve): Add error 653 report.
2167 * class.cs (Class.ApplyAttributeBuilder): Add error 641
2169 (Method.ApplyAttributeBuilder): Add error 685 report.
2170 (Operator.Define): Add error 564 report.
2172 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
2174 * expression.cs (Invocation.DoResolve): Add error
2177 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
2180 2004-09-11 Marek Safar <marek.safar@seznam.cz>
2182 * class.cs (ConstructorInitializer.Resolve):
2183 Wrong error number (515->516).
2185 2004-09-11 Marek Safar <marek.safar@seznam.cz>
2187 * class.cs (Indexer.Define): Add error 631 report.
2189 2004-09-11 Marek Safar <marek.safar@seznam.cz>
2191 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
2193 2004-09-11 Marek Safar <marek.safar@seznam.cz>
2195 * expression.cs (Probe.DoResolve): Add error CS0241 report.
2197 2004-09-10 Marek Safar <marek.safar@seznam.cz>
2199 * cs-parser.jay: Added error CS0241 report.
2201 2004-09-10 Raja R Harinath <rharinath@novell.com>
2203 * cs-parser.jay (fixed_statement): Introduce a scope for the
2204 declaration in the 'fixed' statement.
2206 2004-09-09 Marek Safar <marek.safar@seznam.cz>
2208 * cs-parser.jay: Added CS0230 error report.
2210 2004-09-09 Marek Safar <marek.safar@seznam.cz>
2212 * cs-parser.jay: Added errors CS0231 and CS0257 report.
2214 2004-09-09 Marek Safar <marek.safar@seznam.cz>
2216 * expression.cs (Argument.Resolve): Added error CS0192 and
2219 2004-09-09 Marek Safar <marek.safar@seznam.cz>
2221 C# 2.0 #pragma warning feature
2223 * cs-tokenizer.cs (PreProcessPragma): New method;
2224 Handles #pragma directive.
2226 * report.cs (WarningRegions): New class; Support
2227 class for #pragma warning directive. It tests whether
2228 warning is enabled for a given line.
2230 2004-09-08 Miguel de Icaza <miguel@ximian.com>
2232 * const.cs: Add more descriptive error report, tahnks to
2235 2004-09-08 Marek Safar <marek.safar@seznam.cz>
2237 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
2239 2004-09-07 Miguel de Icaza <miguel@ximian.com>
2241 * expression.cs: Apply patch from Ben: Remove dead code from
2242 ArrayCreation, and remove the TurnintoConstant call in const.cs,
2243 as that code just threw an exception anwyays.
2245 * const.cs: Remove the call to the turnintoconstant, for details
2248 * literal.cs: The type of the null-literal is the null type; So
2249 we use a placeholder type (literal.cs:System.Null, defined here)
2252 * expression.cs (Conditional.DoResolve): Remove some old code that
2253 is no longer needed, conversions have been fixed.
2255 (ArrayCreationExpression.DoResolve): Return false if we fail to
2256 resolve the inner expression.
2258 2004-09-07 Raja R Harinath <rharinath@novell.com>
2261 * cs-parser.jay (delegate_declaration): Record a delegate
2262 declaration as a type declaration.
2263 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
2265 2004-09-06 Miguel de Icaza <miguel@ximian.com>
2267 * parameter.cs: Do not crash if the type can not be resolved.
2269 * expression.cs: Report errors with unsafe pointers, fixes #64896
2271 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
2273 * expression.cs: Pointer arith always needs to do a conv.i
2274 if the operand is a long. fix 65320
2276 2004-09-04 Marek Safar <marek.safar@seznam.cz>
2278 Fixed cs0619-37.cs, cs0619-38.cs
2280 * enum.cs (GetObsoleteAttribute): Removed.
2282 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
2283 on Enum member is double staged. The first is tested member
2286 2004-09-04 Marek Safar <marek.safar@seznam.cz>
2288 Fixed #56986, #63631, #65231
2290 * class.cs: (TypeContainer.AddToMemberContainer): New method,
2291 adds member to name container.
2292 (TypeContainer.AddToTypeContainer): New method, adds type to
2294 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
2295 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
2296 AddOperator): Simplified by reusing AddToMemberContainer.
2297 (TypeContainer.UserDefinedStaticConstructor): Changed to property
2299 (Method.CheckForDuplications): Fixed implementation to test all
2301 (MemberBase): Detection whether member is explicit interface
2302 implementation is now in constructor.
2303 (MemberBase.UpdateMemberName): Handles IndexerName.
2304 (Accessor): Changed to keep also location information.
2305 (AbstractPropertyEventMethod): Is derived from MemberCore.
2306 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
2307 will be emited or not.
2308 (PropertyBase.AreAccessorsDuplicateImplementation):
2309 Tests whether accessors are not in collision with some method.
2310 (Operator): Is derived from MethodCore to simplify common
2313 * decl.cs (Flags.TestMethodDuplication): Test for duplication
2315 (DeclSpace.AddToContainer): Adds the member to defined_names
2316 table. It tests for duplications and enclosing name conflicts.
2318 * enum.cs (EnumMember): Clean up to reuse the base structures
2320 2004-09-03 Martin Baulig <martin@ximian.com>
2322 Merged latest changes into gmcs. Please keep this comment in
2323 here, it makes it easier for me to see what changed in MCS since
2324 the last time I merged.
2326 2004-09-03 Martin Baulig <martin@ximian.com>
2328 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
2329 into TypeContainer, to make partial classes work again.
2331 2004-09-03 Martin Baulig <martin@ximian.com>
2333 * rootcontext.cs (RootContext.V2): Removed.
2335 2004-03-23 Martin Baulig <martin@ximian.com>
2337 * expression.cs (Invocation.OverloadResolve): Added `bool
2338 may_fail' argument and use it instead of the Location.IsNull() hack.
2340 2004-09-09 Martin Baulig <martin@ximian.com>
2342 * cs-parser.jay (namespace_declaration): Fixed CS0134 reporting.
2344 2004-09-09 Martin Baulig <martin@ximian.com>
2346 * generic.cs (TypeParameter.DefineType): Added support for
2347 explicit interface methods.
2349 2004-09-09 Martin Baulig <martin@ximian.com>
2351 * README.Changes: New document. Started to list important changes
2352 between MCS and GMCS here.
2354 2004-09-08 Martin Baulig <martin@ximian.com>
2357 (TypeContainer.CheckRecursiveDefinition): New protected method.
2358 (TypeContainer.DefineType): Move the CS0146 check into
2359 CheckRecursiveDefinition().
2361 2004-09-06 Martin Baulig <martin@ximian.com>
2363 * generic.cs (ConstructedType.CheckConstraints): Allow builtin
2364 types for the constructor constraint.
2366 2004-09-03 Martin Baulig <martin@ximian.com>
2368 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
2369 into TypeContainer, to make partial classes work again.
2371 2004-09-03 Martin Baulig <martin@ximian.com>
2373 * rootcontext.cs (RootContext.V2): Removed.
2375 2004-03-23 Martin Baulig <martin@ximian.com>
2377 * expression.cs (Invocation.OverloadResolve): Added `bool
2378 may_fail' argument and use it instead of the Location.IsNull() hack.
2380 2004-09-03 Martin Baulig <martin@ximian.com>
2382 Merged latest changes into gmcs. Please keep this comment in
2383 here, it makes it easier for me to see what changed in MCS since
2384 the last time I merged.
2386 2004-09-03 Raja R Harinath <rharinath@novell.com>
2389 * expression.cs (BetterConversion): Don't allow either conversion
2390 to be null. Remove redundant implicit conversion test when 'q ==
2391 null' -- when this function is invoked, we already know that the
2392 implicit conversion exists.
2393 (BetterFunction): Assume that 'best' is non-null. Remove
2394 redundant reimplementation of IsApplicable when 'best' is null.
2395 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
2396 number of arguments.
2397 (IsAncestralType): Extract from OverloadResolve.
2398 (OverloadResolve): Make robust to the MethodGroupExpr being
2399 unsorted. Implement all the logic of Section 14.5.5.1, and
2400 support overloading of methods from multiple applicable types.
2401 Clean up logic somewhat. Don't pass null methods to BetterFunction.
2403 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
2404 (RealError, Warning): Append type of report to related symbol.
2406 2004-09-03 Marek Safar <marek.safar@seznam.cz>
2408 * enum.cs: Fixed CLS-Compliance checks for enum members.
2409 Error tests cs3008-8.cs, cs3014-8.cs
2411 2004-09-02 Marek Safar <marek.safar@seznam.cz>
2413 Fixed bug #62342, #63102
2414 * class.cs: ImplementIndexer uses member.IsExplicitImpl
2415 like ImplementMethod.
2417 2004-09-02 Marek Safar <marek.safar@seznam.cz>
2419 * attribute.cs (Attribute.GetAttributeArgumentExpression):
2422 2004-09-02 Martin Baulig <martin@ximian.com>
2424 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
2425 TypeManager.GetArgumentTypes() rather than calling GetParameters()
2428 2004-09-01 Marek Safar <marek.safar@seznam.cz>
2430 C# 2.0 Static classes implemented
2432 * class.cs (TypeContainer): instance_constructors,
2433 initialized_fields, initialized_static_fields,
2434 default_constructor, base_inteface_types are protected to be
2435 accessible from StaticClass.
2436 (TypeContainer.DefineDefaultConstructor): New virtual method
2437 for custom default constructor generating
2438 (StaticClass): New class to handle "Static classes" feature.
2440 * cs-parser.jay: Handle static keyword on class like instance
2443 * driver.cs: Added "/langversion" command line switch with two
2444 options (iso-1, default).
2446 2004-08-31 Marek Safar <marek.safar@seznam.cz>
2448 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
2450 2004-08-31 Miguel de Icaza <miguel@ximian.com>
2452 * delegate.cs: Style.
2454 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
2456 * delegate.cs: Add seperate instance expr field for miguel.
2458 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
2460 * PointerArithmetic (Resolve): make sure we are not doing
2461 pointer arith on void*. Also, make sure we are resolved
2462 by not setting eclass until resolve.
2464 All callers: Make sure that PointerArithmetic gets resolved.
2466 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
2468 * ArrayCreation (LookupType): If the type does not resolve
2469 to an array, give an error.
2471 2004-08-27 Marek Safar <marek.safar@seznam.cz>
2473 * statement.cs (Try.Resolve): Fixed bug #64222
2475 2004-08-27 Martin Baulig <martin@ximian.com>
2478 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
2481 2004-08-26 Marek Safar <marek.safar@seznam.cz>
2483 * ecore.cs (Constantify): Get underlying type via
2484 System.Enum.GetUnderlyingType to avoid StackOverflow on the
2485 Windows in special cases.
2487 2004-08-26 Marek Safar <marek.safar@seznam.cz>
2489 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
2490 for obtaining also private methods.
2491 (GetRemoveMethod): Used GetRemoveMethod (true)
2492 for obtaining also private methods.
2494 2004-09-02 Martin Baulig <martin@ximian.com>
2496 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
2497 TypeManager.GetArgumentTypes() rather than calling GetParameters()
2500 2004-08-27 Martin Baulig <martin@ximian.com>
2503 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
2506 2004-08-25 Martin Baulig <martin@ximian.com>
2508 * support.cs (ReflectionParameters..ctor): If this is a generic
2509 method, retrieve and store its type parameters.
2510 (InternalParameters..ctor): Added `TypeParameter[]' argument.
2511 (ReflectionParameters.GenericConstraints): The argument specifies
2512 the type parameter, not the method parameter.
2513 (InternalParameters.GenericConstraints): Likewise.
2515 * generic.cs (TypeParameter.DefineType): Correctly handle
2516 constraints wrt. generic methods in interfaces and their
2519 2004-08-24 Martin Baulig <martin@ximian.com>
2521 * generic.cs (TypeParameter.IsSubclassOf): New public method.
2522 (Constraints.IsSubclassOf): New internal method.
2524 * typemanager.cs (TypeManager.FindMembers): Added special support
2525 for GenericTypeParameterBuilder's.
2526 (TypeManager.IsSubclassOf, IsFamilyAccessible): Added support for
2529 2004-08-24 Martin Baulig <martin@ximian.com>
2532 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
2533 this for accessibility checks.
2534 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
2535 IsNestedFamilyAccessible.
2536 (TypeManager.IsSubclassOf): New method, do what the name actually
2539 2004-08-24 Martin Baulig <martin@ximian.com>
2541 * expression.cs (MemberAccess.DoResolve): When resolving ourselves
2542 as a SimpleName, include the generic arity.
2544 2004-08-24 Martin Baulig <martin@ximian.com>
2546 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
2547 MethodAttributes.HideBySig for operators.
2549 2004-08-23 Martin Baulig <martin@ximian.com>
2551 Back to the old error reporting system :-)
2553 * report.cs (Message): Removed.
2554 (Report.MessageData, ErrorData, WarningData): Removed.
2555 (Report.Error, Warning): Back to the old system.
2557 2004-08-23 Martin Baulig <martin@ximian.com>
2559 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
2561 * class.cs (TypeContainer.ParentContainer): New public virtual
2562 method; replaces the explicit interface implementation.
2563 (ClassPart.ParentContainer): Override.
2565 2004-08-23 Martin Baulig <martin@ximian.com>
2567 * statement.cs (Switch): Added support for constant switches; see
2568 #59428 or test-285.cs.
2570 2004-08-22 Marek Safar <marek.safar@seznam.cz>
2573 * statement.cs (GetEnumeratorFilter): Removed useless
2574 logic because C# specs is strict. GetEnumerator must be
2577 2004-08-22 Martin Baulig <martin@ximian.com>
2579 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
2580 a switch and may break, reset the barrier. Fixes #59867.
2582 2004-08-22 Marek Safar <marek.safar@seznam.cz>
2584 CLS-Compliance speed up (~5% for corlib)
2586 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
2587 New method. Tests container for CLS-Compliant names
2589 * class.cs (TypeContainer.VerifyClsName): New method.
2590 Checks whether container name is CLS Compliant.
2591 (Constructor): Implements IMethodData.
2593 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
2594 low-case table for CLS Compliance test.
2595 (MemberCache.VerifyClsParameterConflict): New method.
2596 Checks method parameters for CS3006 error.
2598 * enum.cs (EnumMember): Is derived from MemberCore.
2599 (Enum.VerifyClsName): Optimized for better performance.
2601 2004-08-06 Marek Safar <marek.safar@seznam.cz>
2603 * report.cs: Renamed Error_T to Error and changed all
2606 2004-08-06 Marek Safar <marek.safar@seznam.cz>
2608 * class.cs (TypeContainer.IndexerArrayList): New inner class
2609 container for indexers.
2610 (TypeContainer.DefaultIndexerName): New constant for default
2611 indexer name. Replaced all "Item" with this constant.
2612 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
2614 * typemanager.cs (TypeManager.default_member_ctor): Cache here
2615 DefaultMemberAttribute constructor.
2617 2004-08-05 Martin Baulig <martin@ximian.com>
2619 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
2622 2004-08-05 Marek Safar <marek.safar@seznam.cz>
2624 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
2625 multi platforms problem.
2627 * compiler.csproj: Included shared files.
2629 2004-08-04 Marek Safar <marek.safar@seznam.cz>
2631 Fix bug 60333, 55971 in the more general way
2632 * attribute.cs (Attribute.GetAttributeArgumentExpression):
2633 Added arg_type argument for constant conversion.
2634 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
2636 2004-08-04 Marek Safar <marek.safar@seznam.cz>
2639 * class.cs (TypeContainer ): New inner classes MethodArrayList,
2640 OperatorArrayList, MethodCoreArrayList for typecontainer
2641 containers. Changed class member types to these new types.
2642 (MethodArrayList.DefineMembers): Added test for CS0659.
2644 2004-08-04 Miguel de Icaza <miguel@ximian.com>
2646 * cfold.cs: Synchronize the folding with the code in expression.cs
2647 Binary.DoNumericPromotions for uint operands.
2649 * attribute.cs: Revert patch from Raja, it introduced a regression
2650 while building Blam-1.2.1 (hard to isolate a test case).
2652 2004-08-04 Marek Safar <marek.safar@seznam.cz>
2656 (TypeContainer.Define): Renamed to DefineContainerMembers because of
2658 (MethodCore.parent_method): New member. The method we're overriding
2659 if this is an override method.
2660 (MethodCore.CheckBase): Moved from Method class and made common.
2661 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
2663 (MethodCore.CheckForDuplications): New abstract method. For custom
2664 member duplication search in a container
2665 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
2666 method and its return type.
2667 (Event.conflict_symbol): New member. Symbol with same name in the
2671 (MemberCache.FindMemberWithSameName): New method. The method
2672 is looking for conflict with inherited symbols.
2674 2004-08-04 Martin Baulig <martin@ximian.com>
2676 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
2678 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
2680 2004-08-03 Marek Safar <marek.safar@seznam.cz>
2682 * report.cs (Message): New enum for better error, warning reference in
2684 (MessageData): New inner abstract class. It generally handles printing of
2685 error and warning messages.
2686 Removed unused Error, Warning, Message methods.
2688 2004-08-03 Marek Safar <marek.safar@seznam.cz>
2690 Fix for cs0592-8.cs test
2692 (Attributable.ValidAttributeTargets): Made public.
2693 (Attribute.ExplicitTarget): New member for explicit target value.
2694 (Attribute.CheckTargets): Now we translate explicit attribute
2695 target to Target here.
2697 2004-08-03 Ben Maurer <bmaurer@ximian.com>
2699 * ecore.cs (MethodGroupExpr): new IsBase property.
2701 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
2703 * delegate.cs (DelegateCreation): store a MethodGroupExpr
2704 rather than an instance expr.
2706 (DelegateCreation.Emit): Use the method group rather than
2707 the instance expression. Also, if you have base.Foo as the
2708 method for a delegate, make sure to emit ldftn, not ldftnvirt.
2710 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
2712 (NewDelegate.DoResolve): Only check for the existance of Invoke
2713 if the method is going to be needed. Use MethodGroupExpr.
2715 (NewDelegate.Emit): Remove, DelegateCreation implements this.
2717 * expression.cs: For pointer arith., make sure to use
2718 the size of the type, not the size of the pointer to
2721 2004-08-03 Marek Safar <marek.safar@seznam.cz>
2724 * class.cs (Class): Added error CS0502 test.
2726 2004-08-03 John Luke <jluke@cfl.rr.com>
2727 Raja R Harinath <rharinath@novell.com>
2730 * attribute.cs (Attribute.complained_before): New flag.
2731 (Attribute.ResolveType, Attribute.Resolve),
2732 (Attribute.DefinePInvokeMethod): Set it.
2733 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
2735 2004-08-03 Martin Baulig <martin@ximian.com>
2737 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
2738 use a user-defined operator; we still need to do numeric
2739 promotions in case one argument is a builtin type and the other
2740 one has an implicit conversion to that type. Fixes #62322.
2742 2004-08-18 Martin Baulig <martin@ximian.com>
2744 * class.cs (Method.Define): Use the correct method name when
2745 creating the MethodBuilder for a generic method.
2747 2004-08-17 Martin Baulig <martin@ximian.com>
2749 * generic.cs (Constraints): Support type parameter constraints.
2751 2004-08-16 Martin Baulig <martin@ximian.com>
2753 * cs-tokenizer.cs (Tokenizer.TypeOfParsing): New public property.
2754 (Token.GENERIC_DIMENSION): New token; this is returned if we
2755 encounter an unbound generic type in a typeof() expression.
2757 * cs-parser.jay (opt_type_argument_list): Added GENERIC_DIMENSION;
2758 this token is only generated while parsing a typeof() expression.
2759 (typeof_expression): Removed the old unbound_type hack.
2761 * generic.cs (TypeArguments.IsUnbound): New public property.
2763 * decl.cs (MemberName): Added support for unbound types.
2765 2004-08-14 Martin Baulig <martin@ximian.com>
2768 (TypeManager.IsEqualGenericInstance): New static method.
2769 (TypeManager.IsSubclassOrNestedChildOf, IsSubclassOf): This is
2770 just used to check accessibility, so follow the rules of 26.1.6.
2772 * expression.cs (MemberAccess.ResolveAsTypeStep): Return a
2773 ConstructedType instead of a TypeExpression if we have type arguments.
2775 * cs-parser.jay (typeof_expression): Support unbound generic types.
2777 * ecore.cs (UnboundTypeExpression): New public class.
2779 2004-08-12 Martin Baulig <martin@ximian.com>
2781 * typemanager.cs (TypeManager.IsNestedChildOf): Use
2782 TypeManager.IsEqual() rather than `=='.
2784 * decl.cs (DeclSpace.CheckAccessLevel): Use `tb.FullName' for
2785 generic instances as well.
2787 2004-08-12 Martin Baulig <martin@ximian.com>
2789 * expression.cs (Invocation.InferType): We can only infer method
2790 type parameters. Fixes #62647.
2792 2004-08-11 Martin Baulig <martin@ximian.com>
2794 * class.cs (TypeContainer.DefineType): Create the TypeBuilder
2795 before resolving the base classes.
2797 2004-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
2799 * Makefile: install .mdb file too.
2801 2004-08-05 Martin Baulig <martin@ximian.com>
2803 * ecore.cs (FieldExpr.DoResolveLValue): If we're resolving a field
2804 initializer, the current type is just the TypeBuilder, not the
2805 instantiated generic type.
2806 (FieldExpr.IsFieldInitializer): New public property.
2808 2004-08-04 Martin Baulig <martin@ximian.com>
2810 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
2812 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
2814 2004-08-03 Martin Baulig <martin@ximian.com>
2816 * class.cs (MethodData.Define): If we're an explicit
2817 implementation, remove the generic arity from the type name.
2819 2004-08-03 Martin Baulig <martin@ximian.com>
2821 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
2822 use a user-defined operator; we still need to do numeric
2823 promotions in case one argument is a builtin type and the other
2824 one has an implicit conversion to that type. Fixes #62322.
2826 2004-08-02 Martin Baulig <martin@ximian.com>
2828 * class.cs (TypeContainer.ifaces): Make this a `Type[]', not a
2830 (TypeContainer.GetClassBases): Return the unexpanded list of
2831 interfaces; we expand them later.
2832 (TypeContainer.DefineType): After creating the TypeBuilder, call
2833 TypeManager.ExpandInterfaces() to get an expanded and resolved
2836 * ecore.cs (TypeExpr.GetInterfaces): Removed
2838 * generics.cs (Constraints.InterfaceConstraints): Remove.
2839 (TypeParameter.DefineType): Call TypeManager.RegisterBuilder() to
2840 register the interface constraints.
2843 (TypeManager.AddUserType): Removed the `ifaces' argument.
2844 (TypeManager.AddTypeParameter): Likewise.
2845 (TypeManager.AddUserInterface): Removed, was unused.
2846 (TypeManager.RegisterBuilder): Take a `Type[]' instead of a
2847 `TypeExpr[]' array for the interfaces.
2848 (TypeManager.ExpandInterfaces): Call this after the TypeBuilder
2849 has been defined, returns a list of the resolved interfaces types.
2850 (TypeManager.GetInterfaces): Return a `Type[]', not a `TypeExpr[]'.
2851 (TypeManager.GetExplicitInterfaces): Likewise.
2853 2004-08-02 Martin Baulig <martin@ximian.com>
2855 * expression.cs (Invocation.EmitCall): If we're invoking a method
2856 on a type parameter, use the new `Constrained' prefix opcode.
2858 2004-08-02 Martin Baulig <martin@ximian.com>
2860 * statement.cs (LocalInfo.Flags): Added `IsThis'.
2861 (LocalInfo.IsThis): New public property.
2862 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
2864 2004-08-01 Martin Baulig <martin@ximian.com>
2866 * class.cs (TypeContainer.GetClassBases): Don't set the default
2867 here since we may get called from GetPartialBases().
2868 (TypeContainer.DefineType): If GetClassBases() didn't return a
2869 parent, use the default one.
2871 2004-07-30 Martin Baulig <martin@ximian.com>
2873 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
2875 * class.cs (SourceMethod): New public class, derive from the
2876 symbol writer's ISourceMethod.
2877 (Method): Use the new symbol writer API.
2879 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
2880 as argument and use the new symbol writer.
2883 (SourceFile): Implement the symbol writer's ISourceFile.
2884 (Location.SymbolDocument): Removed.
2885 (Location.SourceFile): New public property.
2887 * symbolwriter.cs: Use the new symbol writer API.
2889 2004-07-30 Raja R Harinath <rharinath@novell.com>
2891 * Makefile (install-local): Remove. Functionality moved to
2894 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
2896 * Makefile: Install mcs.exe.config file together with mcs.exe.
2897 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
2898 correct runtime version.
2900 2004-07-25 Martin Baulig <martin@ximian.com>
2903 (TypeContainer.RegisterOrder): Removed, this was unused.
2904 (TypeContainer, interface_order): Removed.
2905 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
2906 TypeContainer as argument since we can also be called with a
2907 `PartialContainer' for a partial class/struct/interface.
2908 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
2909 of checking whether we're an `Interface' - we could be a
2911 (PartialContainer.Register): Override; call
2912 AddClass()/AddStruct()/AddInterface() on our parent.
2914 * cs-parser.jay (interface_member_declaration): Add things to the
2915 `current_container', not the `current_class'.
2917 * rootcontext.cs (RegisterOrder): The overloaded version which
2918 takes an `Interface' was unused, removed.
2920 * typemanager.cs (TypeManager.LookupInterface): Return a
2921 `TypeContainer', not an `Interface'.
2922 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
2923 contain a `PartialContainer' for an interface, so check it's
2924 `Kind' to figure out what it is.
2926 2004-07-25 Martin Baulig <martin@ximian.com>
2928 * class.cs (Class.DefaultTypeAttributes): New public constant.
2929 (Struct.DefaultTypeAttributes): Likewise.
2930 (Interface.DefaultTypeAttributes): Likewise.
2931 (PartialContainer.TypeAttr): Override this and add the
2932 DefaultTypeAttributes.
2934 2004-07-25 Martin Baulig <martin@ximian.com>
2936 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
2937 we can just use the `Parent' field instead.
2939 2004-07-25 Martin Baulig <martin@ximian.com>
2941 * class.cs (TypeContainer.Emit): Renamed to EmitType().
2943 2004-07-25 Martin Baulig <martin@ximian.com>
2945 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
2946 our parts before defining any methods.
2947 (TypeContainer.VerifyImplements): Make this virtual.
2948 (ClassPart.VerifyImplements): Override and call VerifyImplements()
2949 on our PartialContainer.
2951 2004-07-25 Martin Baulig <martin@ximian.com>
2953 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
2955 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
2956 argument, we can just use the `Parent' field instead.
2959 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
2960 (MemberBase.DoDefine): Likewise.
2962 2004-07-24 Martin Baulig <martin@ximian.com>
2964 * decl.cs (MemberCore.Parent): New public field.
2965 (DeclSpace.Parent): Moved to MemberCore.
2967 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
2968 (MemberBase.ctor): Added TypeContainer argument, pass it to our
2970 (FieldBase, Field, Operator): Likewise.
2971 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
2972 (EventField, Event): Likewise.
2974 2004-07-23 Martin Baulig <martin@ximian.com>
2976 * class.cs (PartialContainer): New public class.
2977 (ClassPart): New public class.
2978 (TypeContainer): Added support for partial classes.
2979 (TypeContainer.GetClassBases): Splitted some of the functionality
2980 out into GetNormalBases() and GetPartialBases().
2982 * cs-tokenizer.cs (Token.PARTIAL): New token.
2983 (Tokenizer.consume_identifier): Added some hacks to recognize
2984 `partial', but only if it's immediately followed by `class',
2985 `struct' or `interface'.
2987 * cs-parser.jay: Added support for partial clases.
2989 2004-07-23 Martin Baulig <martin@ximian.com>
2991 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
2992 a `DeclSpace' and also made it readonly.
2993 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
2994 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
2995 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
2997 * cs-parser.jay: Pass the `current_class', not the
2998 `current_container' (at the moment, this is still the same thing)
2999 to a new Method, Property, Event, Indexer or Constructor.
3001 2004-07-23 Martin Baulig <martin@ximian.com>
3003 * cs-parser.jay (CSharpParser): Added a new `current_class' field
3004 and removed the `current_interface' one.
3005 (struct_declaration, class_declaration, interface_declaration):
3006 Set `current_class' to the newly created class/struct/interface;
3007 set their `Bases' and call Register() before parsing their body.
3009 2004-07-23 Martin Baulig <martin@ximian.com>
3011 * class.cs (Kind): New public enum.
3012 (TypeContainer): Made this class abstract.
3013 (TypeContainer.Kind): New public readonly field.
3014 (TypeContainer.CheckDef): New public method; moved here from
3016 (TypeContainer.Register): New public abstract method.
3017 (TypeContainer.GetPendingImplementations): New public abstract
3019 (TypeContainer.GetClassBases): Removed the `is_class' and
3020 `is_iface' parameters.
3021 (TypeContainer.DefineNestedTypes): Formerly known as
3023 (ClassOrStruct): Made this class abstract.
3025 * tree.cs (RootTypes): New public type.
3027 2004-07-20 Martin Baulig <martin@ximian.com>
3029 * tree.cs (Tree.RecordNamespace): Removed.
3030 (Tree.Namespaces): Removed.
3032 * rootcontext.cs (RootContext.IsNamespace): Removed.
3034 * cs-parser.jay (namespace_declaration): Just create a new
3035 NamespaceEntry here.
3037 2004-07-21 Lluis Sanchez Gual <lluis@novell.com>
3039 * Makefile: Install gmcs.exe.config file together with gmcs.exe.
3040 * gmcs.exe.config: Renamed from mcs.exe.config. Added supportedRuntime
3041 entry to make sure it runs in the correct runtime version.
3043 2004-07-18 Martin Baulig <martin@ximian.com>
3045 * generic.cs (ConstructedType.CheckConstraints): Improved
3046 constraints checking.
3048 2004-07-18 Martin Baulig <martin@ximian.com>
3050 * expression.cs (Invocation.BetterMethod): Call
3051 TypeManager.TypeToCoreType() on all types and removed my previous
3052 hack; we're already doig the right thing here.
3054 2004-07-17 Martin Baulig <martin@ximian.com>
3056 * decl.cs (MemberName.MakeName): Create the "class`1" names here.
3058 2004-07-16 Martin Baulig <martin@ximian.com>
3060 * iterators.cs: Added generics support.
3062 2004-07-16 Martin Baulig <martin@ximian.com>
3064 * iterators.cs: Rewrote this. We're now using one single Proxy
3065 class for both the IEnumerable and the IEnumerator interface and
3066 `Iterator' derives from Class so we can use the high-level API.
3068 * class.cs (TypeContainer.AddIterator): New method.
3069 (TypeContainer.DoDefineType): New protected virtual method, which
3070 is called from DefineType().
3071 (TypeContainer.DoDefineMembers): Call DefineType() and
3072 DefineMembers() on all our iterators.
3073 (TypeContainer.Emit): Call Emit() on all our iterators.
3074 (TypeContainer.CloseType): Call CloseType() on all our iterators.
3076 * codegen.cs (EmitContext.CurrentIterator): New public field.
3078 2004-07-15 Martin Baulig <martin@ximian.com>
3081 (TypeManager.not_supported_exception_type): New type.
3083 2004-07-14 Martin Baulig <martin@ximian.com>
3086 (TypeManager.generic_ienumerable_type): New type.
3087 (TypeManager.generic_ienumerator_type): New type.
3090 (RootContext.interfaces_first_stage): Added
3091 "System.Collections.Generic.IEnumerator`1" and
3092 "System.Collections.Generic.IEnumerable`1".
3094 2004-07-14 Martin Baulig <martin@ximian.com>
3096 * iterators.cs: Use real error numbers.
3098 2004-07-14 Martin Baulig <martin@ximian.com>
3100 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
3101 requires this to be a System.Collection.IEnumerable and not a
3102 class implementing that interface.
3103 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
3105 2004-07-13 Marek Safar <marek.safar@seznam.cz>
3107 * class.cs: Fixed previous fix, it broke some error tests.
3109 2004-07-12 Martin Baulig <martin@ximian.com>
3111 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
3114 2004-07-14 Martin Baulig <martin@ximian.com>
3116 * decl.cs, expression.cs, generic.cs: Use a backqoute (`) and not
3117 an exclamation mark (!) for the generic arity to reflect the
3118 latest spec changes; ie. use "System.Collections.Generic.IList`1".
3120 2004-07-13 Martin Baulig <martin@ximian.com>
3122 * cs-tokenizer.cs (Tokenizer.parse_less_than): Allow array rank
3123 specifiers being part of a type argument.
3125 2004-07-13 Martin Baulig <martin@ximian.com>
3127 * expression.cs (MemberAccess.ResolveAsTypeStep): Use the full `!'
3128 name for generic types.
3130 2004-07-13 Martin Baulig <martin@ximian.com>
3132 * assign.cs (Assign.DoResolve): Moved the CS0131 check up a little
3135 2004-07-09 Miguel de Icaza <miguel@ximian.com>
3137 * assign.cs (LocalTemporary): Add new argument: is_address,If
3138 `is_address' is true, then the value that we store is the address
3139 to the real value, and not the value itself.
3141 * ecore.cs (PropertyExpr): use the new local temporary
3142 stuff to allow us to handle X.Y += z (where X is a struct)
3144 2004-07-08 Martin Baulig <martin@ximian.com>
3146 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
3147 not always return, just like we're doing in Using.Resolve().
3149 2004-07-07 Miguel de Icaza <miguel@ximian.com>
3151 * cs-parser.jay (fixed_statement): flag this as Pinned.
3153 2004-07-06 Miguel de Icaza <miguel@ximian.com>
3155 * typemanager.cs (TypeManager): Removed MakePinned method, this
3156 mechanism is replaced with the .NET 2.x compatible mechanism of
3157 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
3159 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
3160 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
3161 `IsFixed' property which has a different meaning.
3163 2004-07-02 Raja R Harinath <rharinath@novell.com>
3165 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
3166 visible from inside a nested class, not just the names of the
3167 immediately enclosing class.
3170 2004-06-24 Raja R Harinath <rharinath@novell.com>
3172 * expression.cs (BetterConversion): Remove buggy special-case
3173 handling of "implicit constant expression conversions". At this
3174 point, we already know that the conversion is possible -- we're
3175 only checking to see which is better.
3177 2004-06-24 Marek Safar <marek.safar@seznam.cz>
3179 * cs-parser.jay: Added error CS0210 test.
3181 2004-06-24 Marek Safar <marek.safar@seznam.cz>
3183 * cs-parser.jay: Added error CS0134 test.
3185 2004-06-24 Marek Safar <marek.safar@seznam.cz>
3188 * cs-parser.jay: Added error CS0145 test.
3190 2004-06-24 Marek Safar <marek.safar@seznam.cz>
3192 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
3194 2004-06-23 Ben Maurer <bmaurer@ximian.com>
3196 * expression.cs (StackAlloc.Resolve): The argument may not
3197 be a constant; deal with this case.
3199 2004-06-23 Marek Safar <marek.safar@seznam.cz>
3201 * attribute.cs (IndexerName_GetIndexerName): Renamed to
3202 GetIndexerAttributeValue.
3203 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
3205 * class.cs (Indexer.Define): Added error tests for CS0415,
3208 2004-06-23 Miguel de Icaza <miguel@ximian.com>
3210 * attribute.cs (Attribute.Resolve): Keep field code in sync with
3213 2004-06-23 Martin Baulig <martin@ximian.com>
3215 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
3216 neither return nor throw, reset the barrier as well. Fixes #60457.
3218 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
3220 * class.cs : EventAttributes is now set to None by default.
3221 This fixes bug #60459.
3223 2004-06-18 Marek Safar <marek.safar@seznam.cz>
3226 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
3227 Don't throw exception but return null (it's sufficient now).
3229 2004-06-18 Marek Safar <marek.safar@seznam.cz>
3231 * typemanager.cs (GetArgumentTypes): Faster implementation.
3233 2004-06-18 Martin Baulig <martin@ximian.com>
3235 * attribute.cs (Attribute.Resolve): Check whether we're an
3236 EmptyCast which a Constant child. Fixes #60333.
3238 2004-06-17 Ben Maurer <bmaurer@ximian.com>
3240 * statement.cs (EmitCollectionForeach): Account for the fact that
3241 not all valuetypes are in areas which we can take the address of.
3242 For these variables, we store to a temporary variable. Also, make
3243 sure that we dont emit a `callvirt' on a valuetype method.
3245 2004-06-15 Marek Safar <marek.safar@seznam.cz>
3247 * expression.cs (StackAlloc.DoReSolve): Added test for
3248 negative parameter (CS0247).
3250 2004-06-15 Marek Safar <marek.safar@seznam.cz>
3253 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
3255 2004-06-15 Marek Safar <marek.safar@seznam.cz>
3258 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
3261 2004-06-14 Marek Safar <marek.safar@seznam.cz>
3263 Fix bug #58254 & cs1555.cs, cs1556.cs
3264 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
3266 2004-06-14 Marek Safar <marek.safar@seznam.cz>
3268 * cs-parser.jay: Added error CS1669 test for indexers.
3270 2004-06-18 Martin Baulig <martin@ximian.com>
3272 * generics.cs (GenericMethod.ctor): Don't take an Attributes
3273 argument. Fixes #60441.
3275 2004-06-16 Ben Maurer <bmaurer@ximian.com>
3276 * ecore.cs (MethodGroupExpr.Name): Revert Martin's patch.
3277 The name needs to have the actual name of the method in order
3278 for other tests (such as the one in OverloadResolve for Invoke
3279 on a delegate) to work. As well, it does not really help
3280 error reporting because the method group had multiple methods.
3281 * Makefile: Remove MCS_DEBUG, you can enable with the DEBUG_FLAGS.
3282 Make profiling work.
3284 2004-06-13 Martin Baulig <martin@ximian.com>
3286 * cs-parser.jay: Don't allow generic attributes.
3288 2004-06-13 Martin Baulig <martin@ximian.com>
3290 * class.cs (MemberBase.DoDefineBase): New protected method.
3291 (MemberBase.DoDefine): Compute the `flags' in the new
3292 DoDefineBase() which must be called first.
3293 (Method.Define): Call DoDefineBase() first so we have the flags
3294 when defining the generic method.
3296 * cs-parser.jay (interface_method_declaration): Support generic methods.
3298 2004-06-13 Martin Baulig <martin@ximian.com>
3300 * decl.cs (TypeName): Removed.
3301 (MemberName): Removed TypeName and MemberNow; now we just have
3304 * cs-parser.jay: Don't distinguish between type arguments and type
3305 parameters in the grammar and simplified the rules a bit. The
3306 reduce/reduce conflicts are now gone (except the one we inherited
3309 2004-06-11 Martin Baulig <martin@ximian.com>
3311 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
3312 call this twice: for params and varargs methods.
3314 2004-06-11 Marek Safar <marek.safar@seznam.cz>
3317 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
3319 2004-06-11 Marek Safar <marek.safar@seznam.cz>
3321 * attribute.cs (Attribute.GetValidTargets): Made public.
3324 (AbstractPropertyEventMethod): New class for better code sharing.
3325 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
3327 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
3329 2004-06-09 Martin Baulig <martin@ximian.com>
3331 * cs-parser.jay: Removed a reduce/reduce conflict.
3333 2004-06-03 Martin Baulig <martin@ximian.com>
3335 * generic.cs (ConstructedType.GetMemberAccess): Renamed to
3336 GetSimpleName() and return a SimpleName.
3338 * ecore.cs (SimpleName.Arguments): New public field.
3339 (SimpleName): Added overloaded ctor which takes an additional
3340 TypeArguments argument.
3341 (SimpleName.SimpleNameResolve): Added support for generic methods.
3342 (MethodGroupExpr.ResolveGeneric): New public method. The code was
3343 formerly in MemberAccess.DoResolve(), but we also need it in
3344 SimpleNameResolve().
3346 * expression.cs (MemberAccess.DoResolve): Use the new
3347 MethodGroupExpr.ResolveGeneric().
3349 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
3351 * decl.cs: If possible, use lookuptypedirect here. We can only do
3352 this if there is no `.' after the namespace. Avoids using
3353 LookupType, which does lots of slow processing.
3354 (FindNestedType) New method, does what it says :-).
3355 * namespace.cs: use LookupTypeDirect.
3356 * rootcontext.cs: use membercache, if possible.
3357 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
3359 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
3362 According to the spec,
3364 In a member access of the form E.I, if E is a single identifier,
3365 and if the meaning of E as a simple-name (§7.5.2) is a constant,
3366 field, property, localvariable, or parameter with the same type as
3367 the meaning of E as a type-name (§3.8), then both possible
3368 meanings of E are permitted.
3370 We did not check that E as a simple-name had the same type as E as
3373 This trivial check gives us 5-7% on bootstrap time.
3375 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
3377 * expression.cs (Invocation.OverloadResolve): Avoid the
3378 use of hashtables and boxing here by allocating on demand.
3380 2004-05-30 Martin Baulig <martin@ximian.com>
3382 * rootcontext.cs (RootContext.LookupType): Don't cache things if
3383 we're doing a silent lookup. Don't try to lookup nested types in
3384 TypeManager.object_type (thanks to Ben Maurer).
3386 2004-05-30 Martin Baulig <martin@ximian.com>
3388 Committing a patch from Ben Maurer.
3390 * rootcontext.cs (RootContext.LookupType): Cache negative results.
3392 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
3394 * convert.cs: add a trivial cache for overload operator resolution.
3396 2004-05-31 Marek Safar <marek.safar@seznam.cz>
3399 (AttributeTester.GetObsoleteAttribute): Returns instance of
3400 ObsoleteAttribute when type is obsolete.
3403 (TypeContainer.VerifyObsoleteAttribute): Override.
3404 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
3405 (MethodCode.VerifyObsoleteAttribute): Override.
3406 (MemberBase.VerifyObsoleteAttribute): Override.
3409 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
3410 and report proper error.
3413 (Delegate.VerifyObsoleteAttribute): Override.
3416 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
3417 and report proper error.
3418 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
3421 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
3425 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
3426 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
3427 Added test for ObsoleteAttribute.
3430 (Catch): Derived from Statement.
3432 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
3434 * decl.cs: If possible, use lookuptypedirect here. We can only do
3435 this if there is no `.' after the namespace. Avoids using
3436 LookupType, which does lots of slow processing.
3437 (FindNestedType) New method, does what it says :-).
3438 * namespace.cs: use LookupTypeDirect.
3439 * rootcontext.cs: use membercache, if possible.
3440 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
3442 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
3445 According to the spec,
3447 In a member access of the form E.I, if E is a single identifier,
3448 and if the meaning of E as a simple-name (§7.5.2) is a constant,
3449 field, property, localvariable, or parameter with the same type as
3450 the meaning of E as a type-name (§3.8), then both possible
3451 meanings of E are permitted.
3453 We did not check that E as a simple-name had the same type as E as
3456 This trivial check gives us 5-7% on bootstrap time.
3458 2004-05-30 Marek Safar <marek.safar@seznam.cz>
3460 Fixed bug #59071 & cs0160.cs
3461 * statement.cs (Try.Resolve): Check here whether order of catch
3462 clauses matches their dependencies.
3464 2004-05-30 Marek Safar <marek.safar@seznam.cz>
3467 * ecore.cs (SimpleName.SimpleNameResolve): Added test for
3470 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
3472 * expression.cs (Invocation.OverloadResolve): Avoid the
3473 use of hashtables and boxing here by allocating on demand.
3475 2004-05-30 Martin Baulig <martin@ximian.com>
3477 * rootcontext.cs (RootContext.LookupType): Don't cache things if
3478 we're doing a silent lookup. Don't try to lookup nested types in
3479 TypeManager.object_type (thanks to Ben Maurer).
3481 2004-05-30 Martin Baulig <martin@ximian.com>
3483 Committing a patch from Ben Maurer.
3485 * rootcontext.cs (RootContext.LookupType): Cache negative results.
3487 2004-05-29 Martin Baulig <martin@ximian.com>
3489 * class.cs (IMethodData.ShouldIgnore): New method.
3491 * typemanager.cs (TypeManager.MethodFlags): Don't take a
3492 `Location' argument, we don't need it anywhere. Use
3493 `IMethodData.ShouldIgnore ()' instead of
3494 `MethodData.GetMethodFlags ()'.
3495 (TypeManager.AddMethod): Removed.
3496 (TypeManager.AddMethod2): Renamed to AddMethod.
3498 2004-05-29 Martin Baulig <martin@ximian.com>
3500 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
3502 * convert.cs (Convert.ImplicitReferenceConversion): If we're
3503 converting from a class type S to an interface type and we already
3504 have an object on the stack, don't box it again. Fixes #52578.
3506 2004-05-29 Martin Baulig <martin@ximian.com>
3508 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
3509 Added support for `params' parameters. Fixes #59267.
3511 2004-05-29 Martin Baulig <martin@ximian.com>
3513 * literal.cs (NullPointer): Provide a private .ctor which sets
3514 `type' to TypeManager.object_type. Fixes #59048.
3516 2004-05-29 Martin Baulig <martin@ximian.com>
3518 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
3519 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
3521 * ecore.cs (EventExpr.instance_expr): Make the field private.
3523 2004-05-26 Marek Safar <marek.safar@seznam.cz>
3525 Fixed bug #50080 & cs0214-2.cs
3526 * expression.cs (Cast.DoResolve): Check unsafe context here.
3528 * statement.cs (Resolve.DoResolve): Likewise.
3530 2004-05-26 Martin Baulig <martin@ximian.com>
3532 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
3534 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
3535 (RootContext.LookupType): Pass down the `silent' flag.
3537 2004-05-25 Martin Baulig <martin@ximian.com>
3540 (MethodGroupExpr.IdenticalTypeName): New public property.
3541 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
3542 expression actually refers to a type.
3544 2004-05-25 Martin Baulig <martin@ximian.com>
3546 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
3547 for #56176 and made it actually work.
3549 2004-05-25 Martin Baulig <martin@ximian.com>
3551 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
3552 (FieldExpr, PropertyExpr): Override and implement
3553 CacheTemporaries. Fixes #52279.
3555 2004-05-25 Miguel de Icaza <miguel@ximian.com>
3557 * location.cs: In the new compiler listing a file twice is a
3558 warning, not an error.
3560 2004-05-24 Martin Baulig <martin@ximian.com>
3562 * enum.cs (Enum.DefineType): For the `BaseType' to be a
3563 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
3565 2004-05-24 Martin Baulig <martin@ximian.com>
3567 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
3568 walking the `using' list. Fixes #53921.
3570 2004-05-24 Martin Baulig <martin@ximian.com>
3572 * const.cs (Const.LookupConstantValue): Added support for
3573 EmptyCast's; fixes #55251.
3575 2004-05-24 Martin Baulig <martin@ximian.com>
3577 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
3578 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
3579 which does the CS0135 check. The reason is that we first need to
3580 check whether the variable actually exists.
3582 2004-05-24 Martin Baulig <martin@ximian.com>
3584 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
3585 than RootContext.LookupType() to find the explicit interface
3588 2004-05-24 Raja R Harinath <rharinath@novell.com>
3590 * Makefile: Simplify. Use executable.make.
3591 * mcs.exe.sources: New file. List of sources of mcs.exe.
3593 2004-05-24 Anders Carlsson <andersca@gnome.org>
3597 Use the invariant culture when doing String.Compare for CLS case
3600 2004-05-23 Martin Baulig <martin@ximian.com>
3602 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
3603 don't have any dots. Fixes #52622, added cs0246-8.cs.
3605 * namespace.cs (NamespaceEntry.Lookup): Likewise.
3607 2004-05-23 Marek Safar <marek.safar@seznam.cz>
3609 * class.cs (MemberBase.Define): Reuse MemberType member for
3610 resolved type. Other methods can use it too.
3612 2004-05-23 Martin Baulig <martin@ximian.com>
3614 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
3615 the variable also exists in the current block (otherwise, we need
3616 to report a CS0103). Fixes #58670.
3618 2004-05-23 Martin Baulig <martin@ximian.com>
3620 * flowanalysis.cs (Reachability.Reachable): Compute this
3621 on-the-fly rather than storing it as a field.
3623 2004-05-23 Martin Baulig <martin@ximian.com>
3625 * flowanalysis.cs (Reachability.And): Manually compute the
3626 resulting `barrier' from the reachability.
3628 2004-05-23 Marek Safar <marek.safar@seznam.cz>
3631 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
3632 instance of ObsoleteAttribute when symbol is obsolete.
3635 (IMethodData): Extended interface for ObsoleteAttribute support.
3637 2004-05-22 Marek Safar <marek.safar@seznam.cz>
3639 * attribute.cs: Fix bug #55970
3641 2004-05-22 Marek Safar <marek.safar@seznam.cz>
3645 (GetObsoleteAttribute): New method. Creates the instance of
3647 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
3648 ObsoleteAttribute when member is obsolete.
3649 (AttributeTester.Report_ObsoleteMessage): Common method for
3650 Obsolete error/warning reporting.
3653 (TypeContainer.base_classs_type): New member for storing parent type.
3656 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
3657 for this MemberCore.
3659 2004-05-21 Marek Safar <marek.safar@seznam.cz>
3661 * attribute.cs, const.cs: Fix bug #58590
3663 2004-05-21 Martin Baulig <martin@ximian.com>
3665 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
3666 out parameters if the end of the method is unreachable. Fixes
3669 2004-05-21 Marek Safar <marek.safar@seznam.cz>
3671 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
3672 Hari was right, why extra method.
3674 2004-05-21 Marek Safar <marek.safar@seznam.cz>
3676 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
3678 2004-05-20 Martin Baulig <martin@ximian.com>
3680 * delegate.cs: Convert this file to Unix mode - like the original
3683 2004-05-20 Martin Baulig <martin@ximian.com>
3685 * attribute.cs: Convert this file to Unix mode - like the original
3688 2004-05-19 Marek Safar <marek.safar@seznam.cz>
3690 Fix bug #58688 (MCS does not report error when the same attribute
3693 * attribute.cs (Attribute.Emit): Distinction between null and default.
3695 2004-05-19 Raja R Harinath <rharinath@novell.com>
3697 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
3698 of a top-level attribute without an attribute target.
3699 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
3701 (Attribute.Conditional_GetConditionName),
3702 (Attribute.Obsolete_GetObsoleteMessage): Update.
3703 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
3704 part of ScanForIndexerName.
3705 (Attribute.CanIgnoreInvalidAttribute): New function.
3706 (Attribute.ScanForIndexerName): Move to ...
3707 (Attributes.ScanForIndexerName): ... here.
3708 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
3709 (Attributes.Search): New internal variant that can choose not to
3710 complain if types aren't resolved. The original signature now
3712 (Attributes.GetClsCompliantAttribute): Use internal variant, with
3713 complaints suppressed.
3714 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
3715 only if it not useful.
3716 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
3717 top-level for attributes that are shared between the assembly
3718 and a top-level class.
3719 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
3720 * class.cs: Update to reflect changes.
3721 (DefineIndexers): Fuse loops.
3722 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
3723 a couple more variants of attribute names.
3725 2004-05-18 Marek Safar <marek.safar@seznam.cz>
3727 Fix bug #52585 (Implemented explicit attribute declaration)
3730 (Attributable.ValidAttributeTargets): New abstract method. It gets
3731 list of valid attribute targets for explicit target declaration.
3732 (Attribute.Target): It holds target itself.
3733 (AttributeSection): Removed.
3734 (Attribute.CheckTargets): New method. It checks whether attribute
3735 target is valid for the current element.
3738 (EventProperty): New class. For events that are declared like
3739 property (with add and remove accessors).
3740 (EventField): New class. For events that are declared like field.
3743 * cs-parser.jay: Implemented explicit attribute target declaration.
3745 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
3746 Override ValidAttributeTargets.
3749 (ReturnParameter): Class for applying custom attributes on
3751 (ParameterAtribute): New class. Class for applying custom
3752 attributes on the parameter type.
3754 2004-05-17 Miguel de Icaza <miguel@ximian.com>
3756 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
3759 (Method): Allow UNSAFE here.
3761 * modifiers.cs: Support unsafe reporting.
3763 2004-05-17 Marek Safar <marek.safar@seznam.cz>
3765 * decl.cs: Fix bug #58478.
3767 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
3769 * statement.cs: When checking for unreachable code on an EmptyStatement,
3770 set the location. Fixes bug #58488.
3772 2004-05-13 Miguel de Icaza <miguel@ximian.com>
3774 * driver.cs: Add -pkg handling.
3776 From Gonzalo: UseShelLExecute=false
3778 2004-05-12 Marek Safar <marek.safar@seznam.cz>
3781 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
3783 (Attribute.IsClsCompliaceRequired): Moved to base for better
3785 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
3786 when attribute is AttributeUsageAttribute.
3787 (Attribute.GetValidTargets): Simplified.
3788 (Attribute.GetAttributeUsage): New method returns AttributeUsage
3789 attribute for this type.
3790 (Attribute.ApplyAttributes): Method renamed to Emit and make
3792 (GlobalAttributeSection): New class for special handling of global
3793 attributes (assembly, module).
3794 (AttributeSection.Emit): New method.
3796 * class.cs: Implemented Attributable abstract methods.
3797 (MethodCore.LabelParameters): Moved to Parameter class.
3798 (Accessor): Is back simple class.
3799 (PropertyMethod): Implemented Attributable abstract class.
3800 (DelegateMethod): Implemented Attributable abstract class.
3801 (Event): New constructor for disctintion between normal Event
3802 and Event with accessors.
3804 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
3806 * codegen.cs, const.cs, decl.cs, delegate.cs:
3807 (CommonAssemblyModulClass): Implemented Attributable abstract class
3810 * enum.cs: Implement IAttributeSupport interface.
3811 (EnumMember): New class for emum members. Implemented Attributable
3815 (ParameterBase): Is abstract.
3816 (ReturnParameter): New class for easier [return:] attribute handling.
3818 * typemanager.cs: Removed builder_to_attr.
3820 2004-05-11 Raja R Harinath <rharinath@novell.com>
3823 * attribute.cs (Attribute.GetPositionalValue): New function.
3824 * class.cs (TypeContainer.VerifyMembers): New function.
3825 (TypeContainer.Emit): Use it.
3826 (ClassOrStruct): New base class for Class and Struct.
3827 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
3828 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
3830 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
3831 then each non-static field should have a FieldOffset attribute.
3832 Otherwise, none of the fields should have a FieldOffset attribute.
3833 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
3834 and FieldOffset attributes.
3835 * typemanager.cs (TypeManager.struct_layout_attribute_type)
3836 (TypeManager.field_offset_attribute_type): New core types.
3837 (TypeManager.InitCoreTypes): Initialize them.
3839 2004-05-11 Michal Moskal <malekith@pld-linux.org>
3841 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
3842 Return correct type.
3845 2004-05-09 Miguel de Icaza <miguel@ximian.com>
3847 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
3848 be implicitly converted to ulong.
3850 * expression.cs: The logic for allowing operator &, | and ^ worked
3851 was wrong, it worked before because we did not report an error in
3852 an else branch. Fixes 57895.
3854 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
3855 allow volatile fields to be reference types.
3857 2004-05-07 Miguel de Icaza <miguel@ximian.com>
3859 * driver.cs: Add support for /debug-
3861 2004-05-07 Raja R Harinath <rharinath@novell.com>
3863 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
3864 Add a 'complain' parameter to silence errors.
3865 (Attribute.Resolve): Update to changes. Put in sanity check to catch
3866 silently overlooked type-resolutions.
3867 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
3869 (Attributes.Search): New function.
3870 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
3871 (Attributes.GetAttributeFullName): Remove hack.
3872 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
3873 Update to reflect changes.
3874 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
3875 Use Attributes.Search instead of nested loops.
3877 2004-05-07 Marek Safar <marek.safar@seznam.cz>
3880 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
3881 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
3882 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
3884 * report.cs: (Report.Warning): Renamed to Warning_T because of
3885 parameter collision.
3887 2004-05-05 Raja R Harinath <rharinath@novell.com>
3889 * expression.cs (MemberAccess.ResolveMemberAccess):
3890 Exit with non-zero status after Report.Error.
3891 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
3893 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
3895 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
3897 * support.cs: Don't hang when the file is empty.
3899 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
3901 * support.cs: In SeekableStreamReader, compute the preamble size of the
3902 underlying stream. Position changes should take into account that initial
3905 2004-05-03 Todd Berman <tberman@sevenl.net>
3907 * driver.cs: remove unused GetSysVersion function.
3909 2004-05-03 Todd Berman <tberman@sevenl.net>
3911 * driver.cs: Remove the hack from saturday, as well as the hack
3912 from jackson (LoadAssemblyFromGac), also adds the CWD to the
3913 link_paths to get that bit proper.
3915 2004-05-01 Todd Berman <tberman@sevenl.net>
3917 * driver.cs: Try a LoadFrom before a Load, this checks the current
3918 path. This is currently a bug in mono that is be fixed, however, this
3919 provides a workaround for now. This will be removed when the bug
3922 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
3924 * CryptoConvert.cs: Updated to latest version. Fix issue with
3925 incomplete key pairs (#57941).
3927 2004-05-01 Todd Berman <tberman@sevenl.net>
3929 * driver.cs: Remove '.' from path_chars, now System.* loads properly
3932 2004-04-30 Jackson Harper <jackson@ximian.com>
3934 * codegen.cs: Open keys readonly.
3936 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
3938 * typemanager.cs: don't report cyclic struct layout when a struct
3939 contains 2 or more fields of the same type. Failed for Pango.AttrShape
3940 which has 2 Pango.Rectangle fields.
3942 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
3944 * expression.cs: Handle IntPtr comparisons with IL code
3945 rather than a method call.
3947 2004-04-29 Martin Baulig <martin@ximian.com>
3949 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
3950 the list of PropertyInfo's in class hierarchy and find the
3951 accessor. Fixes #56013.
3953 2004-04-29 Martin Baulig <martin@ximian.com>
3955 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
3957 2004-04-29 Martin Baulig <martin@ximian.com>
3959 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
3961 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
3963 2004-04-29 Martin Baulig <martin@ximian.com>
3965 * class.cs (ConstructorInitializer.Resolve): Check whether the
3966 parent .ctor is accessible. Fixes #52146.
3968 2004-04-29 Martin Baulig <martin@ximian.com>
3970 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
3972 * statement.cs (Using.EmitLocalVariableDecls): Use
3973 TypeManager.idisposable_type, not typeof (IDisposable).
3974 (Foreach.EmitCollectionForeach): Added support for valuetypes.
3976 2004-04-29 Martin Baulig <martin@ximian.com>
3978 * class.cs (Event.Define): Don't emit the field and don't set
3979 RTSpecialName and SpecialName for events on interfaces. Fixes
3982 2004-04-29 Raja R Harinath <rharinath@novell.com>
3984 Refactor Attribute.ApplyAttributes.
3985 * attribute.cs (Attributable): New base class for objects that can
3986 have Attributes applied on them.
3987 (Attribute): Make AttributeUsage fields public.
3988 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
3989 (Attribute.IsInternalCall): New property.
3990 (Attribute.UsageAttr): Convert to a public read-only property.
3991 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
3992 (Attribute.ResolveType, Attribute.Resolve)
3993 (Attribute.ScanForIndexerName): Update to reflect changes.
3994 (Attribute.CheckAttributeTarget): Re-format.
3995 (Attribute.ApplyAttributes): Refactor, to various
3996 Attributable.ApplyAttributeBuilder methods.
3997 * decl.cs (MemberCore): Make Attributable.
3998 * class.cs (Accessor): Make Attributable.
3999 (MethodData.ApplyAttributes): Use proper attribute types, not
4001 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
4002 (TypeContainer.ApplyAttributeBuilder)
4003 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
4004 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
4005 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
4006 (Operator.ApplyAttributeBuilder): New factored-out methods.
4007 * const.cs (Const.ApplyAttributeBuilder): Likewise.
4008 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
4009 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
4010 * parameter.cs (ParameterBase): New Attributable base class
4011 that can also represent Return types.
4012 (Parameter): Update to the changes.
4014 2004-04-29 Jackson Harper <jackson@ximian.com>
4016 * driver.cs: Prefer the corlib system version when looking for
4017 assemblies in the GAC. This is still a hack, but its a better hack
4020 2004-04-29 Marek Safar <marek.safar@seznam.cz>
4022 * decl.cs, enum.cs: Improved error 3005 reporting.
4024 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
4025 (related_symbols): New private member for list of symbols
4026 related to reported error/warning.
4028 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
4030 2004-04-29 Martin Baulig <martin@ximian.com>
4032 * ecore.cs (Expression.Constantify): If we're an enum and
4033 TypeManager.TypeToCoreType() doesn't give us another type, use
4034 t.UnderlyingSystemType. Fixes #56178.
4036 2004-04-29 Martin Baulig <martin@ximian.com>
4038 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
4039 interfaces and for each interface, only add members directly
4040 declared in that interface. Fixes #53255.
4042 2004-04-28 Martin Baulig <martin@ximian.com>
4044 * expression.cs (ConditionalLogicalOperator): Use a temporary
4045 variable for `left' to avoid that we evaluate it more than once;
4048 2004-04-28 Martin Baulig <martin@ximian.com>
4050 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
4053 2004-04-28 Martin Baulig <martin@ximian.com>
4055 * statement.cs (LocalInfo.Resolve): Check whether the type is not
4058 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
4059 whether the type is not void (CS1547).
4061 2004-04-28 Martin Baulig <martin@ximian.com>
4063 * expression.cs (Unary.DoResolveLValue): Override this and report
4064 CS0131 for anything but Operator.Indirection.
4066 2004-04-28 Martin Baulig <martin@ximian.com>
4068 Committing a patch from Ben Maurer; see bug #50820.
4070 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
4073 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
4076 2004-04-28 Martin Baulig <martin@ximian.com>
4078 Committing a patch from Ben Maurer; see bug #50820.
4080 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
4083 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
4086 2004-04-28 Martin Baulig <martin@ximian.com>
4088 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
4089 (Block.AddLabel): Call DoLookupLabel() to only search in the
4092 2004-04-28 Martin Baulig <martin@ximian.com>
4094 * cfold.cs (ConstantFold.BinaryFold): Added special support for
4095 comparing StringConstants and NullLiterals in Equality and Inequality.
4097 2004-04-28 Jackson Harper <jackson@ximian.com>
4099 * driver.cs: Attempt to load referenced assemblies from the
4100 GAC. This is the quick and dirty version of this method that
4101 doesnt take into account versions and just takes the first
4102 canidate found. Will be good enough for now as we will not have more
4103 then one version installed into the GAC until I update this method.
4105 2004-04-28 Martin Baulig <martin@ximian.com>
4107 * typemanager.cs (TypeManager.CheckStructCycles): New public
4108 static method to check for cycles in the struct layout.
4110 * rootcontext.cs (RootContext.PopulateTypes): Call
4111 TypeManager.CheckStructCycles() for each TypeContainer.
4112 [Note: We only need to visit each type once.]
4114 2004-04-28 Martin Baulig <martin@ximian.com>
4116 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
4118 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
4119 success and added `out object value'. Use a `bool resolved' field
4120 to check whether we've already been called rather than
4121 `ConstantValue != null' since this breaks for NullLiterals.
4123 2004-04-28 Raja R Harinath <rharinath@novell.com>
4125 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
4126 setting of this flag, since the 'set' method may be non-public.
4128 2004-04-28 Raja R Harinath <rharinath@novell.com>
4130 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
4131 check on current_vector.Block.
4133 2004-04-27 Martin Baulig <martin@ximian.com>
4135 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
4136 a field initializer. Fixes #56459.
4138 2004-04-27 Martin Baulig <martin@ximian.com>
4140 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
4141 we're not attempting to use an indexer. Fixes #52154.
4143 2004-04-27 Martin Baulig <martin@ximian.com>
4145 * statement.cs (Return): Don't create a return label if we don't
4146 need it; reverts my change from January 20th. Thanks to Ben
4149 2004-04-27 Martin Baulig <martin@ximian.com>
4151 According to the spec, `goto' can only leave a nested scope, but
4154 * statement.cs (Block.LookupLabel): Only lookup in the current
4155 block, don't recurse into parent or child blocks.
4156 (Block.AddLabel): Check in parent and child blocks, report
4157 CS0140/CS0158 if we find a duplicate.
4158 (Block): Removed this indexer for label lookups.
4159 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
4160 this already does the error reporting for us.
4163 (FlowBranching.UsageVector.Block): New public variable; may be null.
4164 (FlowBranching.CreateSibling): Added `Block' argument.
4165 (FlowBranching.LookupLabel): New public virtual method. Lookup a
4166 label for the target of a `goto' and check whether we're not
4167 leaving a `finally'.
4169 2004-04-27 Martin Baulig <martin@ximian.com>
4171 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
4172 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
4175 2004-04-27 Martin Baulig <martin@ximian.com>
4177 * statement.cs (Block.AddLabel): Also check for implicit blocks
4178 and added a CS0158 check.
4180 2004-04-27 Martin Baulig <martin@ximian.com>
4182 * flowanalysis.cs (FlowBranchingLoop): New class.
4183 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
4184 UsageVector's instead of an ArrayList.
4185 (FlowBranching.Label): Likewise.
4186 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
4187 (FlowBranching.AddBreakVector): New method.
4189 2004-04-27 Miguel de Icaza <miguel@ximian.com>
4191 * attribute.cs: Small regression fix: only convert the type if we
4192 the type is different, fixes System.Drawing build.
4194 2004-04-27 Martin Baulig <martin@ximian.com>
4196 * attribute.cs (Attribute.Resolve): If we have a constant value
4197 for a named field or property, implicity convert it to the correct
4200 2004-04-27 Raja R Harinath <rharinath@novell.com>
4202 * statement.cs (Block.Block): Implicit blocks share
4203 'child_variable_names' fields with parent blocks.
4204 (Block.AddChildVariableNames): Remove.
4205 (Block.AddVariable): Mark variable as "used by a child block" in
4206 every surrounding block.
4207 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
4208 been used in a child block, complain about violation of "Invariant
4209 meaning in blocks" rule.
4210 * cs-parser.jay (declare_local_variables): Don't use
4211 AddChildVariableNames.
4212 (foreach_statement): Don't create an implicit block: 'foreach'
4215 2004-04-23 Miguel de Icaza <miguel@ximian.com>
4217 * convert.cs (ImplicitNumericConversion): 0 is also positive when
4218 converting from 0L to ulong. Fixes 57522.
4220 2004-04-22 Marek Safar <marek.safar@seznam.cz>
4222 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
4223 derived class hides via 'new' keyword field from base class (test-242.cs).
4224 TODO: Handle this in the more general way.
4226 * class.cs (CheckBase): Ditto.
4228 2004-04-22 Marek Safar <marek.safar@seznam.cz>
4230 * decl.cs (caching_flags): New member for storing cached values
4232 (MemberCore.Flags): New enum where bit flags for caching_flags
4234 (MemberCore.cls_compliance): Moved to caching_flags.
4235 (DeclSpace.Created): Moved to caching_flags.
4237 * class.cs: Use caching_flags instead of DeclSpace.Created
4239 2004-04-21 Miguel de Icaza <miguel@ximian.com>
4241 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
4242 if we are only a derived class, not a nested class.
4244 * typemanager.cs: Same as above, but do this at the MemberLookup
4245 level (used by field and methods, properties are handled in
4246 PropertyExpr). Allow for the qualified access if we are a nested
4249 2004-04-21 Marek Safar <marek.safar@seznam.cz>
4251 * class.cs: Refactoring.
4252 (IMethodData): New inteface; Holds links to parent members
4253 to avoid member duplication (reduced memory allocation).
4254 (Method): Implemented IMethodData interface.
4255 (PropertyBase): New inner classes for get/set methods.
4256 (PropertyBase.PropertyMethod): Implemented IMethodData interface
4257 (Event): New inner classes for add/remove methods.
4258 (Event.DelegateMethod): Implemented IMethodData interface.
4260 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
4261 EmitContext (related to class.cs refactoring).
4263 2004-04-21 Raja R Harinath <rharinath@novell.com>
4265 * delegate.cs (Delegate.VerifyApplicability): If the number of
4266 arguments are the same as the number of parameters, first try to
4267 verify applicability ignoring any 'params' modifier on the last
4271 2004-04-08 Martin Baulig <martin@ximian.com>
4273 Merged latest changes into gmcs. Please keep this comment in
4274 here, it makes it easier for me to see what changed in MCS since
4275 the last time I merged.
4277 2004-04-16 Raja R Harinath <rharinath@novell.com>
4279 * class.cs (TypeContainer.AddIndexer): Use
4280 'ExplicitInterfaceName' to determine if interface name was
4281 explicitly specified. 'InterfaceType' is not initialized at this time.
4282 (TypeContainer.DefineIndexers): Remove use of temporary list. The
4283 Indexers array is already in the required order. Initialize
4284 'IndexerName' only if there are normal indexers.
4285 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
4286 (TypeContainer.Emit): Emit DefaultMember attribute only if
4287 IndexerName is initialized.
4290 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
4292 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
4295 2004-04-15 Raja R Harinath <rharinath@novell.com>
4297 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
4301 * attribute.cs (Attribute.Resolve): Check for duplicate named
4305 2004-04-15 Miguel de Icaza <miguel@ximian.com>
4307 * iterators.cs (MarkYield): track whether we are in an exception,
4308 and generate code accordingly. Use a temporary value to store the
4309 result for our state.
4311 I had ignored a bit the interaction of try/catch with iterators
4312 since their behavior was not entirely obvious, but now it is
4313 possible to verify that our behavior is the same as MS .NET 2.0
4317 2004-04-14 Miguel de Icaza <miguel@ximian.com>
4319 * iterators.cs: Avoid creating temporaries if there is no work to
4322 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
4323 Enumerations, use TypeManager.EnumToUnderlying and call
4326 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
4329 (This.Emit): Use EmitContext.EmitThis to emit our
4332 (This.EmitAssign): Ditto.
4334 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
4335 codepaths, we will move all the functionality into
4338 (FieldExpr.EmitAssign): Ditto.
4340 This fixes several hidden bugs that I uncovered while doing a code
4341 review of this today.
4343 * codegen.cs (EmitThis): reworked so the semantics are more clear
4344 and also support value types "this" instances.
4346 * iterators.cs: Changed so that for iterators in value types, we
4347 do not pass the value type as a parameter.
4349 Initialization of the enumerator helpers is now done in the caller
4350 instead of passing the parameters to the constructors and having
4351 the constructor set the fields.
4353 The fields have now `assembly' visibility instead of private.
4355 2004-04-11 Miguel de Icaza <miguel@ximian.com>
4357 * expression.cs (Argument.Resolve): Check if fields passed as ref
4358 or out are contained in a MarshalByRefObject.
4360 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
4361 another compiler type.
4363 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
4365 * class.cs (Indexer.Define): use the new name checking method.
4366 Also, return false on an error.
4367 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
4368 (is_identifier_[start/part]_character): make static.
4370 2004-04-10 Miguel de Icaza <miguel@ximian.com>
4372 * expression.cs (Binary.ResolveOperator): Do no append strings
4373 twice: since we can be invoked more than once (array evaluation)
4374 on the same concatenation, take care of this here. Based on a fix
4375 from Ben (bug #56454)
4377 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
4379 * codegen.cs: Fix another case where CS1548 must be reported (when
4380 delay-sign isn't specified and no private is available #56564). Fix
4381 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
4382 error when MCS is used on the MS runtime and we need to delay-sign
4383 (which seems unsupported by AssemblyBuilder - see #56621).
4385 2004-04-08 Marek Safar <marek.safar@seznam.cz>
4387 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
4388 (TypeManager.ComputeNamespaces): Faster implementation for
4391 * compiler.csproj: Updated AssemblyName to mcs.
4393 2004-05-11 Jackson Harper <jackson@ximian.com>
4395 * Makefile: Preserve MONO_PATH
4397 2004-05-11 Jackson Harper <jackson@ximian.com>
4399 * Makefile: Use mono and mcs to build gmcs
4401 2004-05-03 Miguel de Icaza <miguel@ximian.com>
4403 * codegen.cs: Add patch from Robert Shade
4404 <rshade@dvsconsulting.com>, use FileAccess.Read on the keyfile, to
4407 2004-05-02 Sebastien Pouliot <sebastien@ximian.com>
4409 * CryptoConvert.cs: Updated to latest version. Fix issue with
4410 incomplete key pairs (#57941).
4412 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
4414 * codegen.cs: Fix another case where CS1548 must be reported (when
4415 delay-sign isn't specified and no private is available #56564). Fix
4416 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
4417 error when MCS is used on the MS runtime and we need to delay-sign
4418 (which seems unsupported by AssemblyBuilder - see #56621).
4420 2004-04-29 Jackson Harper <jackson@ximian.com>
4422 * Makefile: Set MONO_PATH to use the bootstrap corlib
4423 * driver.cs: Check the GAC for referenced assemblies.
4425 2004-04-29 Martin Baulig <martin@ximian.com>
4427 * Makefile (gmcs.exe): Set MONO_PATH to use `../class/lib/net_2_0'.
4429 2004-04-07 Martin Baulig <martin@ximian.com>
4431 * expression.cs (Binary.ResolveOperator): Added special case for
4432 Equality/Inequality between a type parameter and a null literal.
4434 2004-04-07 Martin Baulig <martin@ximian.com>
4436 * convert.cs: Check null literal -> type parameter conversions.
4438 2004-04-07 Martin Baulig <martin@ximian.com>
4440 * generic.cs (ConstructedType.CheckConstraints): Enforce the
4441 `class' and `struct' constraints.
4443 2004-04-07 Martin Baulig <martin@ximian.com>
4445 * generic.cs (SpecialConstraint): New public enum.
4446 (Constraints.Resolve): Added support for the `class' and `struct'
4449 * cs-parser.jay (type_parameter_constraint): Added support for the
4450 `class' and `struct' constraints.
4452 2004-04-07 Martin Baulig <martin@ximian.com>
4454 * support.cs (GenericConstraints): Replaced `Types' by
4455 `ClassConstraint' and `InterfaceConstraints'; added
4456 `HasClassConstraint'.
4458 2004-04-07 Martin Baulig <martin@ximian.com>
4461 (Constraints.InterfaceConstraints): New public property.
4462 (Constraints.Types): Make this property public
4463 (TypeParameter): Implement IMemberContainer.
4464 (TypeParameter.Define): Take a `GenericTypeParameterBuilder'
4465 instead of a TypeBuilder/MethodBuilder; pass the interface
4466 constraints to TypeManager.AddTypeParameter().
4467 (TypeParameter.DefineType): Just take an EmitContext and no
4468 TypeBuilder/MethodBuilder. Use the new public API.
4470 * typemanager.cs (TypeManager.AddTypeParameter): Added
4471 `TypeExpr[]' argument; add the interfaces to the
4472 `builder_to_ifaces' hash.
4473 (TypeManager.LookupMemberContainer): For
4474 GenericTypeParameterBuilders, get the TypeParameter from the
4475 `builder_to_type_param'.
4476 (TypeManager.FindMembers): For GenericTypeParameterBuilders, get
4477 the TypeParameter and call FindMembers on it.
4479 2004-04-07 Martin Baulig <martin@ximian.com>
4482 (MethodCore.GenericMethod): Moved this field here from Method.
4483 (MethodCore.IsDuplicateImplementation): Take the number of type
4484 parameters into account if we're a generic method.
4486 * expression.cs (Invocation.InferTypeArguments): Don't return true
4487 if `arguments' is null; we still need to check whether we actually
4488 don't need to infer anything in this case.
4489 (MemberAccess): Merged the functionality from GenericMemberAccess
4492 * generic.cs (GenericMemberAccess): Removed.
4494 2004-04-05 Martin Baulig <martin@ximian.com>
4496 * decl.cs (MemberCore): For generic classes, interfaces and
4497 structs, `Name' now includes the number of type parameters
4499 (DeclSpace.FindType): Removed the `num_type_args' argument; we now
4500 encode the number of type arguments in the type name.
4502 * expression.cs (Expression.MemberLookup): Removed the
4503 `num_type_args' argument; we now encode the number of type
4504 arguments in the type name.
4506 * ecore.cs (SimpleName): Encode the number of type arguments in
4507 the type name itself.
4509 * generic.cs (ConstructedType): Likewise.
4511 * tree.cs (Tree.RecordDecl): Take a `string' instead of a
4512 `MemberName'; we now include the number of type parameters in the
4515 * typemanager.cs (TypeManager.CheckGeneric): Removed.
4516 (TypeManager.MemberLookup): Removed the
4517 `num_type_args' argument; we now encode the number of type
4518 arguments in the type name.
4520 2004-04-03 Martin Baulig <martin@ximian.com>
4522 * decl.cs (MemberCore.ctor): Take a MemberName instead of a sting.
4523 (MemberCore.MemberName): Moved here from MemberBase.
4524 (DeclSpace.SetParameterInfo): Just take the constraints as an
4525 ArrayList; we already have the type parameters in our
4526 `MemberName'; also do the CS0080 reporting here.
4528 * cs-parser.jay (struct_declaration): Use `member_name' instead of
4529 `IDENTIFIER opt_type_parameter_list'; when constructing our
4530 `MemberName', it'll already include our type parameters.
4531 (class_declaration, interface_declaration): Likewise.
4532 (delegate_declaration): Likewise.
4533 (MakeName): Take a MemberName and return a MemberName.
4534 The following two changes are required to avoid shift/reduce conflicts:
4535 (member_name): Don't include a TypeName anymore; ie. this is now
4536 just 'IDENTIFIER opt_type_parameter_list'.
4537 (property_declaration, event_declaration): Use a
4538 `namespace_or_type_name' instead of a `member_name'.
4540 2004-04-03 Martin Baulig <martin@ximian.com>
4542 * decl.cs (MemberName): Renamed to `TypeName' and created a new
4544 (TypeName): Formerly known as MemberName.
4546 * namespace.cs (NamespaceEntry.UsingAlias): Take a `TypeName'
4547 instead of a `MemberName'.
4549 * cs-parser.jay (namespace_or_type_name): Create a TypeName.
4550 (member_name): New rule; create a MemberName.
4552 2004-04-02 Martin Baulig <martin@ximian.com>
4554 * namespace.cs (NamespaceEntry.VerifyUsing): Added error checking
4555 (CS0305 and CS0308).
4557 2004-04-02 Martin Baulig <martin@ximian.com>
4559 * generic.cs (GenericMemberAccess.ResolveAsTypeStep): Added
4560 support for nested types.
4562 2004-04-02 Martin Baulig <martin@ximian.com>
4564 * ecore.cs (IAlias): New public interface.
4565 (TypeExpr, TypeExpression): Implement IAlias.
4566 (TypeAliasExpression): New public class.
4568 * namespace.cs (Namespace): Implement IAlias.
4569 (Namespace.Lookup): Return an IAlias instead on an object.
4570 (Namespace.DefineName): Take an IAlias instead of an object.
4571 (NamespaceEntry.AliasEntry.Resolve): Return an IAlias instead of
4573 (NamespaceEntry.UsingAlias): Take a Membername instead of an
4575 (NamespaceEntry.LookupAlias): Return an IAlias instead on an
4577 (NamespaceEntry.Lookup): Likewise.
4579 * rootcontext.cs (RootContext.LookupType): Return a TypeExpr
4582 * decl.cs (DeclSpace): Implement IAlias.
4583 (DeclSpace.LookupAlias): Return an IAlias instead of a string.
4585 * generic.cs (ConstructedType): Improved error checking.
4587 2004-04-02 Martin Baulig <martin@ximian.com>
4589 * convert.cs: Added type parameter conversions.
4592 (UnboxCast.Emit): Emit an `unbox.any' for type params.
4593 (ClassCast.Emit): If the source type is a type parameter, box it.
4594 If the target type is a type parameter, emit an `unbox.any'
4595 instead of a `classcast'.1
4597 2004-04-01 Martin Baulig <martin@ximian.com>
4599 * cs-tokenizer.cs (parse_less_than): Allow Token.DOT.
4601 2004-04-01 Martin Baulig <martin@ximian.com>
4603 * generic.cs (ConstructedType.CheckConstraints): Use
4604 Convert.ImplicitStandardConversionExists(); user-defined implicit
4605 conversions are not allowed according to the spec.
4607 2004-03-30 Martin Baulig <martin@ximian.com>
4609 * expression.cs (New): Added support for type parameters.
4612 (TypeManager.activator_type): New public static field.
4613 (TypeManager.activator_create_instance): Likewise.
4615 2004-03-30 Martin Baulig <martin@ximian.com>
4617 * typemanager.cs (TypeManager.HasConstructorConstraint): New
4620 2004-03-30 Martin Baulig <martin@ximian.com>
4622 * generic.cs (ConstructedType.CheckConstraints): Actually follow
4623 the spec here: the argument type must be convertible to the
4626 2004-03-30 Martin Baulig <martin@ximian.com>
4629 (TypeParameter.Define, TypeParameter.DefineMethod): Call
4630 TypeManager.AddTypeParameter().
4631 (ConstructedType.CheckConstraints): Re-enable this and actually
4632 check whether we have a constructor constraint.
4635 (TypeManager.builder_to_type_param): New static field.
4636 (TypeManager.AddTypeParameter): New static method.
4637 (TypeManager.LookupTypeParameter): New public method.
4639 2004-03-30 Martin Baulig <martin@ximian.com>
4641 * generic.cs (TypeParameter.DefineType): Return a boolean and use
4642 the new API to actually define the constructor constraint.
4645 (TypeManager.new_constraint_attr_type): New static field.
4646 (TypeManager.InitCoreTypes): Initialize it.
4648 2004-03-30 Martin Baulig <martin@ximian.com>
4650 * generic.cs (Constraints): Completed error checking, use correct
4653 2004-03-29 Martin Baulig <martin@ximian.com>
4655 * delegate.cs (Delegate.VerifyMethod): Infer type arguments.
4657 * expression.cs (Invocation.InferTypeArguments): Added overloaded
4658 public version which takes a `ParameterData pd' instead of an
4661 2004-03-29 Martin Baulig <martin@ximian.com>
4663 * typemanager.cs (TypeManager.IsGenericMethod): Take a MethodBase,
4666 2004-03-29 Martin Baulig <martin@ximian.com>
4668 * expression.cs (Argument.ResolveMethodGroup): If we're a
4669 ConstructedType, call GetMemberAccess() on it.
4671 2004-03-29 Martin Baulig <martin@ximian.com>
4673 * class.cs (MethodBase.CheckGenericOverride): New abstract method.
4674 (MethodCore.CheckGenericOverride): When overriding a generic
4675 method, check whether the constraints match.
4677 * support.cs (GenericConstraints): New public interface.
4678 (ParameterData.GenericConstraints): New public method.
4680 * parameter.cs (Parameter.Resolve): Check whether we're a generic
4681 method parameter and compute our constraints if appropriate.
4682 (Parameter.GenericConstraints): New public property.
4684 * generic.cs (Constraints): Implement GenericConstraints.
4686 2004-03-29 Martin Baulig <martin@ximian.com>
4688 * decl.cs (MemberCache.FindMemberToOverride): Use
4689 `paramTypes [j].Equals (cmpAttrs [j])' instead of `=='.
4691 2004-03-29 Martin Baulig <martin@ximian.com>
4693 * generic.cs (GenericMethod.Define): Resolve our type parameters.
4695 2004-03-29 Martin Baulig <martin@ximian.com>
4697 * cs-parser.jay: Report CS0080 instead of -200 ("Constraints are
4698 not allowed on non-generic declarations").
4700 2004-03-29 Martin Baulig <martin@ximian.com>
4702 * expression.cs (Invocation.InferTypeArguments): Added overloaded
4703 public version of this method.
4705 * class.cs (MethodCore.IsDuplicateImplementation): Use
4706 Invocation.InferTypeArguments() to check this.
4708 2004-03-29 Martin Baulig <martin@ximian.com>
4710 * convert.cs: Use TypeManager.IsDelegateType() instead of
4711 comparing types correctly.
4713 2004-03-29 Martin Baulig <martin@ximian.com>
4715 * convert.cs: Use TypeManager.IsSubclassOf() instead of comparing
4716 types directly to make it work for generic instances.
4718 * typemanager.cs (TypeManager.IsSubclassOf): New static method.
4720 2004-03-29 Martin Baulig <martin@ximian.com>
4722 * typemanager.cs (TypeManager.MayBecomeEqualGenericTypes): Added
4725 2004-03-24 Martin Baulig <martin@ximian.com>
4727 * decl.cs (DeclSpace.FindType): Also use
4728 TypeManager.CheckGeneric() for types from the using clauses.
4730 2004-03-23 Martin Baulig <martin@ximian.com>
4732 * expression.cs (Invocation.OverloadResolve): Added `bool
4733 may_fail' argument and use it instead of the Location.IsNull() hack.
4735 2004-03-23 Martin Baulig <martin@ximian.com>
4737 * expression.cs (Invocation.InferType): Use correct type inference
4740 2004-03-23 Martin Baulig <martin@ximian.com>
4742 * ecore.cs (MethodGroupExpr.Name): Use
4743 TypeManager.CSharpSignature() instead of just the name.
4745 * expression.cs (Invocation.OverloadResolve): Provide better error
4747 (Invocation.DoResolve): OverloadResolve() never returns null
4748 without reporting an error, so removed the error -6 reporting here.
4750 2004-03-23 Martin Baulig <martin@ximian.com>
4752 * typemanager.cs (TypeManager.GetMethodFlags): Fixed the FIXME for
4755 * cs-parser.jay (delegate_declaration): Support generic delegates.
4757 * delegate.cs: Support generic delegates.
4759 2004-03-22 Martin Baulig <martin@ximian.com>
4761 * expression.cs (Invocation.InferParamsTypeArguments): New static
4762 method; does type inference for params arguments.
4764 2004-03-21 Martin Baulig <martin@ximian.com>
4766 * typemanager.cs (TypeManager.IsGenericMethod): New public static
4767 method; checks whether a method is a generic method.
4769 * expression.cs (Invocation.InferTypeArguments): New static method;
4770 infer type arguments for generic method invocation.
4772 * ecore.cs (MethodGroupExpr.HasTypeArguments): New public
4773 property; we set this to true if we're resolving a generic method
4774 invocation and the user specified type arguments, ie. we're not
4775 doing type inference.
4777 2004-03-20 Martin Baulig <martin@ximian.com>
4779 * class.cs (MethodData.DeclaringType): New public property.
4780 (MethodData.Define): Set DeclaringType here.
4781 (Operator.Define): Use OperatorMethod.MethodData.DeclaringType
4782 instead of OperatorMethodBuilder.DeclaringType.
4784 2004-03-20 Martin Baulig <martin@ximian.com>
4786 * cs-tokenizer.cs (xtoken): Return a special
4787 Token.DEFAULT_OPEN_PARENS for "`default' followed by open parens".
4789 * cs-parser.jay (default_value_expression): Switch to the new
4792 2004-03-19 Martin Baulig <martin@ximian.com>
4794 * decl.cs (MemberName): New class. We use this to "construct"
4795 namespace_or_type_name's.
4797 * generics.cs (TypeArguments.GetDeclarations): New public method;
4798 returns the type arguments as a string[] and reports a CS0081 if
4799 one of them is not an identifier.
4801 * class.cs (MemberBase): The .ctor now takes the name as a
4802 MemberName instead of a string.
4803 (MemberBase.ExplicitInterfaceName): Changed type from string to
4805 (MemberBase.DoDefine): If we're an explicit implementation, the
4806 InterfaceType may be a generic instance.
4808 * cs-parser.jay (namespace_or_type_name): Return a MemberName.
4809 (namespace_name): Call MemberName.GetName () to transform the
4810 MemberName into a string and ensure we don't have any type
4812 (type_name): Call MemberName.GetTypeExpression() to transfrom the
4813 MemberName into an expression.
4814 (method_header): Use namespace_or_type_name instead of member_name.
4816 2004-04-07 Miguel de Icaza <miguel@ximian.com>
4818 * rootcontext.cs: Add new types to the boot resolution.
4820 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
4821 MulticastDelegate is not allowed.
4823 * typemanager.cs: Add new types to lookup: System.TypedReference
4826 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
4827 check for TypedReference or ArgIterator, they are not allowed.
4829 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
4830 makes us properly catch 1510 in some conditions (see bug 56016 for
4833 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
4835 * CryptoConvert.cs: update from corlib version
4838 2004-04-05 Miguel de Icaza <miguel@ximian.com>
4840 * class.cs (Indexer.Define): Check indexername declaration
4842 2004-04-05 Marek Safar <marek.safar@seznam.cz>
4844 * attribute.cs (IsClsCompliant): Fixed problem with handling
4845 all three states (compliant, not-compliant, undetected).
4847 2004-03-30 Marek Safar <marek.safar@seznam.cz>
4849 * attribute.cs (Attribute): Location is now public.
4850 (Resolve): Store resolved arguments (pos_values) in attribute class.
4851 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
4852 (GetClsCompliantAttributeValue): New method that gets
4853 CLSCompliantAttribute value.
4854 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
4855 if exists else null.
4856 (AttributeTester): New class for CLS-Compliant verification routines.
4858 * class.cs (Emit): Add CLS-Compliant verification.
4859 (Method.GetSignatureForError): Implemented.
4860 (Constructor.GetSignatureForError): Implemented
4861 (Constructor.HasCompliantArgs): Returns if constructor has
4862 CLS-Compliant arguments.
4863 (Constructor.Emit): Override.
4864 (Construcor.IsIdentifierClsCompliant): New method; For constructors
4865 is needed to test only parameters.
4866 (FieldBase.GetSignatureForError): Implemented.
4867 (TypeContainer): New member for storing base interfaces.
4868 (TypeContainer.FindMembers): Search in base interfaces too.
4870 * codegen.cs (GetClsComplianceAttribute): New method that gets
4871 assembly or module CLSCompliantAttribute value.
4872 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
4874 (ModuleClass.Emit): Add error 3012 test.
4876 * const.cs (Emit): Override and call base for CLS-Compliant tests.
4878 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
4879 state for all decl types.
4880 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
4881 if CLS-Compliant tests are required.
4882 (IsClsCompliaceRequired): New method. Analyze whether code
4883 must be CLS-Compliant.
4884 (IsExposedFromAssembly): New method. Returns true when MemberCore
4885 is exposed from assembly.
4886 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
4887 value or gets cached value.
4888 (HasClsCompliantAttribute): New method. Returns true if MemberCore
4889 is explicitly marked with CLSCompliantAttribute.
4890 (IsIdentifierClsCompliant): New abstract method. This method is
4891 used to testing error 3005.
4892 (IsIdentifierAndParamClsCompliant): New method. Common helper method
4893 for identifier and parameters CLS-Compliant testing.
4894 (VerifyClsCompliance): New method. The main virtual method for
4895 CLS-Compliant verifications.
4896 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
4897 null. I don't know why is null (too many public members !).
4898 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
4899 and get value of first CLSCompliantAttribute that found.
4901 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
4902 (VerifyClsCompliance): Override and add extra tests.
4904 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
4905 clscheck- disable CLS-Compliant verification event if assembly is has
4906 CLSCompliantAttribute(true).
4908 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
4909 ApllyAttribute is now called in emit section as in the other cases.
4910 Possible future Emit integration.
4911 (IsIdentifierClsCompliant): New override.
4912 (VerifyClsCompliance): New override.
4913 (GetEnumeratorName): Returns full enum name.
4915 * parameter.cs (GetSignatureForError): Implemented.
4917 * report.cs (WarningData): New struct for Warning message information.
4918 (LocationOfPreviousError): New method.
4919 (Warning): New method. Reports warning based on the warning table.
4920 (Error_T): New method. Reports error based on the error table.
4922 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
4923 verifications are done here.
4925 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
4927 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
4928 CLSCompliantAttribute.
4929 (all_imported_types): New member holds all imported types from other
4931 (LoadAllImportedTypes): New method fills static table with exported types
4932 from all referenced assemblies.
4933 (Modules): New property returns all assembly modules.
4935 2004-03-30 Miguel de Icaza <miguel@ximian.com>
4937 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
4938 throwing a parser error.
4940 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
4941 which removes the hardcoded get_/set_ prefixes for properties, as
4942 IL allows for the properties to be named something else.
4946 * expression.cs: Do not override operand before we know if it is
4949 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
4951 * typemanager.cs: support for pinned variables.
4953 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
4955 * decl.cs, typemanager.cs: Avoid using an arraylist
4956 as a buffer if there is only one result set.
4958 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
4960 * expression.cs: Make sure you cant call a static method
4961 with an instance expression, bug #56174.
4963 2004-03-29 Miguel de Icaza <miguel@ximian.com>
4965 * class.cs (IsDuplicateImplementation): Improve error reporting to
4966 flag 663 (method only differs in parameter modifier).
4968 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
4969 in preprocessor directives.
4971 * location.cs (LookupFile): Allow for the empty path.
4973 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
4974 better approach for some of that patch, but its failing with the
4975 CharSet enumeration. For now try/catch will do.
4977 * typemanager.cs: Do not crash if a struct does not have fields.
4980 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
4982 * expression.cs: cs0213, cant fix a fixed expression.
4985 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
4987 * cs-parser.jay: detect invalid embeded statements gracefully.
4990 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
4992 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
4995 the invocation type may not be a subclass of the tye of the item/
4996 The type of the item must be a subclass of the invocation item.
5001 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
5003 * attribute.cs: Added methods to get a string and a bool from an
5004 attribute. Required to information from AssemblyKeyFileAttribute,
5005 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
5006 * codegen.cs: Modified AssemblyName creation to include support for
5007 strongnames. Catch additional exceptions to report them as CS1548.
5008 * compiler.csproj: Updated include CryptoConvert.cs.
5009 * compiler.csproj.user: Removed file - user specific configuration.
5010 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
5011 Mono.Security assembly. The original class is maintained and tested in
5012 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
5013 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
5014 like CSC 8.0 (C# v2) supports.
5015 * Makefile: Added CryptoConvert.cs to mcs sources.
5016 * rootcontext.cs: Added new options for strongnames.
5018 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
5020 * driver.cs: For --expect-error, report error code `2'
5021 if the program compiled with no errors, error code `1' if
5022 it compiled with an error other than the one expected.
5024 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
5026 * compiler.csproj: Updated for Visual Studio .NET 2003.
5027 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
5028 * compiler.sln: Updated for Visual Studio .NET 2003.
5030 2004-03-24 Ravi Pratap M <ravi@ximian.com>
5032 * expression.cs: Fix bug #47234. We basically need to apply the
5033 rule that we prefer the conversion of null to a reference type
5034 when faced with a conversion to 'object' (csc behaviour).
5036 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
5038 * statement.cs: Shorter form for foreach, eliminates
5039 a local variable. r=Martin.
5041 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
5043 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
5044 checks if we can use brtrue/brfalse to test for 0.
5045 * expression.cs: use the above in the test for using brtrue/brfalse.
5048 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
5050 * expression.cs: Rewrite string concat stuff. Benefits:
5052 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
5053 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
5054 rather than a concat chain.
5056 * typemanager.cs: Add lookups for more concat overloads.
5058 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
5060 * expression.cs: Emit shorter il code for array init.
5077 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
5079 * statement.cs: Before, two switch blocks would be merged if the
5080 total size of the blocks (end_item - begin_item + 1) was less than
5081 two times the combined sizes of the blocks.
5083 Now, it will only merge if after the merge at least half of the
5088 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
5090 * class.cs : csc build fix for GetMethods(). See bug #52503.
5092 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
5094 * expression.cs: Make sure fp comparisons work with NaN.
5095 This fixes bug #54303. Mig approved this patch a long
5096 time ago, but we were not able to test b/c the runtime
5099 2004-03-19 Miguel de Icaza <miguel@ximian.com>
5101 * ecore.cs (TypExpr.GetHashCode): implement this overload.
5103 2004-03-19 Martin Baulig <martin@ximian.com>
5105 * class.cs (MemberCore.IsDuplicateImplementation): Check whether
5106 two overloads may unify for some type parameter substitutions and
5107 report a CS0408 if appropriate.
5109 2004-03-19 Martin Baulig <martin@ximian.com>
5111 * class.cs (MemberCore.IsDuplicateImplementation): Report the
5112 error here and not in our caller.
5114 2004-03-19 Martin Baulig <martin@ximian.com>
5116 * interface.cs: Completely killed this file.
5117 (Interface): We're now a TypeContainer and live in class.cs.
5119 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
5120 argument; we're now also called for interfaces.
5121 (TypeContainer.DefineMembers): Allow this method being called
5123 (TypeContainer.GetMethods): New public method; formerly known as
5124 Interface.GetMethod(). This is used by PendingImplementation.
5125 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
5126 it's now private and non-static.
5127 (Interface): Moved this here; it's now implemented similar to
5129 (Method, Property, Event, Indexer): Added `bool is_interface'
5130 argument to their .ctor's.
5131 (MemberBase.IsInterface): New public field.
5133 * cs-parser.jay: Create normal Method, Property, Event, Indexer
5134 instances instead of InterfaceMethod, InterfaceProperty, etc.
5135 (opt_interface_base): Removed; we now use `opt_class_base' instead.
5136 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
5138 2004-03-19 Martin Baulig <martin@ximian.com>
5140 * class.cs (MethodCore.IsDuplicateImplementation): New private
5141 method which does the CS0111 checking.
5142 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
5143 Use IsDuplicateImplementation().
5145 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
5147 * decl.cs (FindMemberToOverride): New method to find the correct
5148 method or property to override in the base class.
5150 - Make Method/Property use the above method to find the
5151 version in the base class.
5152 - Remove the InheritableMemberSignatureCompare as it is now
5155 This patch makes large code bases much faster to compile, as it is
5156 O(n) rather than O(n^2) to do this validation.
5158 Also, it fixes bug 52458 which is that nested classes are not
5159 taken into account when finding the base class member.
5161 Reviewed/Approved by Martin.
5163 2004-03-17 Martin Baulig <martin@ximian.com>
5165 * expression.cs (MemberAccess.DoResolve): Take the parent's number
5166 of type arguments into account; use the `real_num_type_args'
5167 approach like in DoResolveAsTypeStep().
5169 * generic.cs (GenericMemberAccess.DoResolve): Make this work for
5172 2004-03-17 Marek Safar <marek.safar@seznam.cz>
5174 * interface.cs: In all interface classes removed redundant
5175 member initialization.
5177 2004-03-16 Martin Baulig <martin@ximian.com>
5179 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
5181 2004-03-15 Miguel de Icaza <miguel@ximian.com>
5183 * decl.cs (DefineTypeAndParents): New helper method to define a
5184 type's containers before the type itself is defined; This is a
5185 bug exposed by the recent changes to Windows.Forms when an
5186 implemented interface was defined inside a class that had not been
5189 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
5191 (Check): Loop correctly to report errors modifiers
5192 (UNSAFE was not in the loop, since it was the same as TOP).
5194 * interface.cs: Every interface member now takes a ModFlags,
5195 instead of a "is_new" bool, which we set on the base MemberCore.
5197 Every place where we called "UnsafeOk" in the interface, now we
5198 call the proper member (InterfaceMethod.UnsafeOK) instead to get
5199 the unsafe settings from the member declaration instead of the
5200 container interface.
5202 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
5204 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
5205 `set_indexer_name' to the pending bits (one per type).
5207 We fixed a bug today that was picking the wrong method to
5208 override, since for properties the existing InterfaceMethod code
5209 basically ignored the method name. Now we make sure that the
5210 method name is one of the valid indexer names.
5212 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
5214 * support.cs (SeekableStreamReader): Keep track of stream byte
5215 positions and don't mix them with character offsets to the buffer.
5217 Patch from Gustavo Giráldez
5219 2004-03-15 Marek Safar <marek.safar@seznam.cz>
5221 * interface.cs (InterfaceSetGetBase): Removed double member
5222 initialization, base class does it as well.
5224 2004-03-13 Martin Baulig <martin@ximian.com>
5226 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
5227 when compiling corlib.
5229 2004-03-13 Miguel de Icaza <miguel@ximian.com>
5231 * convert.cs (ExplicitConversion): We were reporting an error on
5232 certain conversions (object_type source to a value type, when the
5233 expression was `null') before we had a chance to pass it through
5234 the user defined conversions.
5236 * driver.cs: Replace / and \ in resource specifications to dots.
5239 * class.cs: Add check for duplicate operators. Fixes 52477
5241 2004-03-11 Miguel de Icaza <miguel@ximian.com>
5243 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
5244 that are in the middle of the statements, not only at the end.
5247 * class.cs (TypeContainer.AddField): No longer set the
5248 `HaveStaticConstructor' flag, now we call it
5249 `UserDefineStaticConstructor' to diferentiate the slightly
5250 semantic difference.
5252 The situation is that we were not adding BeforeFieldInit (from
5253 Modifiers.TypeAttr) to classes that could have it.
5254 BeforeFieldInit should be set to classes that have no static
5259 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
5261 And most importantly Zoltan's comment:
5263 http://bugzilla.ximian.com/show_bug.cgi?id=44229
5265 "I think beforefieldinit means 'it's ok to initialize the type sometime
5266 before its static fields are used', i.e. initialization does not need
5267 to be triggered by the first access to the type. Setting this flag
5268 helps the JIT to compile better code, since it can run the static
5269 constructor at JIT time, and does not need to generate code to call it
5270 (possibly lots of times) at runtime. Unfortunately, mcs does not set
5271 this flag for lots of classes like String.
5273 csc sets this flag if the type does not have an explicit static
5274 constructor. The reasoning seems to be that if there are only static
5275 initalizers for a type, and no static constructor, then the programmer
5276 does not care when this initialization happens, so beforefieldinit
5279 This bug prevents the AOT compiler from being usable, since it
5280 generates so many calls to mono_runtime_class_init that the AOT code
5281 is much slower than the JITted code. The JITted code is faster,
5282 because it does not generate these calls if the vtable is type is
5283 already initialized, which is true in the majority of cases. But the
5284 AOT compiler can't do this."
5286 2004-03-10 Miguel de Icaza <miguel@ximian.com>
5288 * class.cs (MethodData.Emit): Refactor the code so symbolic
5289 information is generated for destructors; For some reasons we
5290 were taking a code path that did not generate symbolic information
5293 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
5295 * class.cs: Create a Constructor.CheckBase method that
5296 takes care of all validation type code. The method
5297 contains some code that was moved from Define.
5299 It also includes new code that checks for duplicate ctors.
5300 This fixes bug #55148.
5302 2004-03-09 Joshua Tauberer <tauberer@for.net>
5304 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
5305 a { ... }-style array creation invokes EmitStaticInitializers
5306 which is not good for reference-type arrays. String, decimal
5307 and now null constants (NullCast) are not counted toward
5308 static initializers.
5310 2004-03-05 Martin Baulig <martin@ximian.com>
5312 * location.cs (SourceFile.HasLineDirective): New public field;
5313 specifies whether the file contains or is referenced by a "#line"
5315 (Location.DefineSymbolDocuments): Ignore source files which
5316 either contain or are referenced by a "#line" directive.
5318 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
5320 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
5321 direct access to our parent, so check the method inline there.
5323 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
5325 * expression.cs (Invocation.EmitCall): Miguel's last commit
5326 caused a regression. If you had:
5331 In Foo the implict this would be null.
5333 2004-02-27 Miguel de Icaza <miguel@ximian.com>
5335 * expression.cs (Invocation.EmitCall): If the method is not
5336 virtual, do not emit a CallVirt to it, use Call.
5338 * typemanager.cs (GetFullNameSignature): Improve the method to
5339 cope with ".ctor" and replace it with the type name.
5341 * class.cs (ConstructorInitializer.Resolve): Now the method takes
5342 as an argument the ConstructorBuilder where it is being defined,
5343 to catch the recursive constructor invocations.
5345 2004-03-16 Martin Baulig <martin@ximian.com>
5347 * expression.cs (MemberAccess.DoResolve): If `expr' resolved to a
5348 ConstructedType, call ResolveType() on it to get the type rather
5349 than just using `expr.Type'.
5351 2004-03-16 Martin Baulig <martin@ximian.com>
5353 * generics.cs (ConstructedType.GetMemberAccess): Take the
5354 EmitContext instead on the TypeExpr and use
5355 ec.TypeContainer.CurrentType/ec.ContainerType.
5357 2004-03-16 Martin Baulig <martin@ximian.com>
5359 * ecore.cs (SimpleName.DoResolveAsTypeStep): Lookup type
5360 parameters before aliases.
5362 2004-03-16 Martin Baulig <martin@ximian.com>
5364 * typemanager.cs (TypeManager.MayBecomeEqualGenericInstances):
5365 New oublic function; checks whether two generic instances may become
5366 equal under some instantiations (26.3.1).
5368 * class.cs (TypeContainer.Define): Call
5369 TypeManager.MayBecomeEqualGenericInstances() and report CS0695 on
5372 2004-03-16 Martin Baulig <martin@ximian.com>
5374 * class.cs (TypeContainer.GetClassBases): Moved
5375 Error_TypeParameterAsBase() here and also check whether the base
5376 class is not an attribute.
5378 2004-03-16 Martin Baulig <martin@ximian.com>
5380 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
5382 2004-03-16 Martin Baulig <martin@ximian.com>
5384 * class.cs (Error_TypeParameterAsBase): Use correct error number
5387 2004-03-16 Martin Baulig <martin@ximian.com>
5389 * decl.cs (DeclSpace.ResolveTypeExpr): Added more error checking
5392 * generics.cs (ConstructedType.DoResolveAsTypeStep): Added better
5395 2004-03-15 Martin Baulig <martin@ximian.com>
5397 * typemanager.cs (TypeManager.GetFullName): New public method.
5398 (TypeManager.MemberLookup): Added `int_num_type_arguments'
5399 argument; only return members with the correct number of type
5401 (TypeManager.CheckGeneric): Allow -1 to bypass the check.
5402 (TypeManager.FilterWithClosure): Call CheckGeneric() to check
5403 whether the number of type arguments matches.
5405 * generic.cs (GenericMemberAccess.ResolveAsTypeStep): Allow `expr'
5406 not being a ConstructedType; we can now do "typeof (Foo.Bar<U>)".
5408 * expression.cs (MemberAccess): Added public `NumTypeArguments'
5409 field; it's set by the protected .ctor when we're actually a
5410 GenericMemberAccess.
5411 (MemberAccess.ResolveAsTypeStep): Compute the total number of type
5412 arguments and pass it to MemberLookupFinal ().
5414 * ecore.cs (Expression.MemberLookup): Added `int
5415 num_type_arguments' argument; only return members with the correct
5416 number of type arguments.
5417 (Expression.MemberLookupFailed): Check whether the MemberLookup
5418 failed because we did not have the correct number of type
5419 arguments; report CS0305 in this case.
5421 * decl.cs (DeclSpace.ResolveTypeExpr): Don't report an error if
5422 `e.ResolveAsTypeTerminal()' already did so.
5424 2004-03-15 Martin Baulig <martin@ximian.com>
5426 * ecore.cs (Expression.ResolveLValue): Allow e.type being null if
5427 we're a ConstructedType; in this case, the caller must report an
5428 error (for instance CS0131).
5430 * generic.cs (TypeArguments): Added Location argument to the .ctor.
5431 (TypeArguments.Resolve): Actually report errors here.
5433 2004-03-15 Miguel de Icaza <miguel@ximian.com>
5435 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
5436 `set_indexer_name' to the pending bits (one per type).
5438 We fixed a bug today that was picking the wrong method to
5439 override, since for properties the existing InterfaceMethod code
5440 basically ignored the method name. Now we make sure that the
5441 method name is one of the valid indexer names.
5443 2004-03-15 Martin Baulig <martin@ximian.com>
5445 * typemanager.cs (TypeManager.IndexerPropertyName): Added support
5446 for generic instances.
5448 2004-03-13 Martin Baulig <martin@ximian.com>
5450 * class.cs (TypeContainer.DefineType): Call
5451 TypeManager.AddUserType() immediately after creating the
5452 TypeBuilder; pass all type parameters when creating the
5455 * decl.cs (DeclSpace.FindNestedType): New public method.
5456 (DeclSpace.FindType): Added `int num_type_args' argument; only
5457 return types with the correct number of type parameters.
5458 (DeclSpace.CountTypeParams): New public property.
5460 * ecore.cs (SimpleName.ctor): Added overloaded version which takes
5461 the number of type parameters; defaults to zero.
5463 * generic.cs (TypeArguments.Count): New public property.
5464 (ConstructedType.DoResolveAsTypeStep): First call
5465 ds.FindNestedType() to find out whether we're nested in the
5466 current generic type; in this case, we inherit all type parameters
5467 from the current class.
5469 * rootcontext.cs (RootContext.NamespaceLookup): Added `int
5470 num_type_args' argument.
5471 (RootContext.LookupType): Added overloaded version which takes the
5472 number of type arguments; only return types with the correct
5473 number of type arguments.
5475 * typemanager.cs (TypeManager.CheckGeneric): New public function;
5476 checks whether `Type t' has `int num_type_args'.
5478 2004-03-13 Martin Baulig <martin@ximian.com>
5480 * generic.cs (GenericMethod.DefineType): New method; calls
5481 DefineType() on all the type parameters.
5483 * class.cs (MethodData.ctor): Added `GenericMethod generic' argument.
5484 (MethodData.Define): If we're a generic method, call
5485 GenericMethod.DefineType() to define the type parameters.
5487 2004-03-10 Martin Baulig <martin@ximian.com>
5489 * pending.cs (Pending.InterfaceMethod): Use TypeManager.IsEqual()
5490 instead of IsAssignableFrom.
5492 2004-03-10 Martin Baulig <martin@ximian.com>
5494 * ecore.cs (FieldExpr.ctor): Use TypeManager.TypeToCoreType().
5496 * support.cs (ParameterData.HasArrayParameter): New property.
5497 (ReflectionParameters.ctor): Take a MethodBase instead of a
5498 ParameterInfo[]. If we have any type parameters, get the generic
5499 method definition and ask it whether we have variable arguments.
5501 2004-02-26 Miguel de Icaza <miguel@ximian.com>
5503 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
5504 routines to check if a type is an enumerable/enumerator allow
5505 classes that implement the IEnumerable or IEnumerator interfaces.
5507 * class.cs (Property, Operator): Implement IIteratorContainer, and
5508 implement SetYields.
5510 (Property.Define): Do the block swapping for get_methods in the
5511 context of iterators. We need to check if Properties also
5512 include indexers or not.
5514 (Operator): Assign the Block before invoking the
5515 OperatorMethod.Define, so we can trigger the Iterator code
5518 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
5519 Property and Operator classes are not created when we parse the
5520 declarator but until we have the block completed, so we use a
5521 singleton SimpleIteratorContainer.Simple to flag whether the
5522 SetYields has been invoked.
5524 We propagate this setting then to the Property or the Operator to
5525 allow the `yield' to function.
5527 2004-02-25 Marek Safar <marek.safar@seznam.cz>
5529 * codegen.cs: Implemented attribute support for modules.
5530 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
5531 Assembly/Module functionality.
5533 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
5534 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
5535 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
5537 2004-02-16 Marek Safar <marek.safar@seznam.cz>
5539 * interface.cs (FindMembers): The operation is performed on all base
5540 interfaces and not only on the first. It is required for future CLS Compliance patch.
5542 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
5544 * statement.cs, codegen.cs:
5545 This patch deals with patterns such as:
5547 public class List : IEnumerable {
5549 public MyEnumerator GetEnumerator () {
5550 return new MyEnumerator(this);
5553 IEnumerator IEnumerable.GetEnumerator () {
5557 public struct MyEnumerator : IEnumerator {
5562 Before, there were a few things we did wrong:
5563 1) we would emit callvirt on a struct, which is illegal
5564 2) we emited ldarg when we needed to emit ldarga
5565 3) we would mistakenly call the interface methods on an enumerator
5566 type that derived from IEnumerator and was in another assembly. For example:
5568 public class MyEnumerator : IEnumerator
5570 Would have the interface methods called, even if there were public impls of the
5571 method. In a struct, this lead to invalid IL code.
5573 2004-02-11 Marek Safar <marek.safar@seznam.cz>
5575 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
5578 * delegate.cs (Define): Fixed crash when delegate type is undefined.
5580 2004-02-11 Miguel de Icaza <miguel@ximian.com>
5582 * cs-parser.jay: Fix small regression: we were not testing V2
5583 compiler features correctly.
5585 * interface.cs: If the emit context is null, then create one
5587 2004-02-09 Marek Safar <marek.safar@seznam.cz>
5589 * decl.cs (GetSignatureForError): New virtual method to get full name
5592 * attribute.cs (IAttributeSupport): New interface for attribute setting.
5593 Now it is possible to rewrite ApplyAttributes method to be less if/else.
5595 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
5596 Duplicated members and code in these classes has been removed.
5597 Better encapsulation in these classes.
5599 2004-02-07 Miguel de Icaza <miguel@ximian.com>
5601 * assign.cs (Assign.DoResolve): When dealing with compound
5602 assignments, there is a new rule in ECMA C# 2.4 (might have been
5603 there before, but it is documented here) that states that in:
5607 If b is of type int, and the `op' is a shift-operator, then the
5608 above is evaluated as:
5612 * expression.cs (Binary.ResolveOperator): Instead of testing for
5613 int/uint/long/ulong, try to implicitly convert to any of those
5614 types and use that in pointer arithmetic.
5616 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
5617 method to print information for from the type, not from the
5618 null-method we were given.
5620 2004-02-01 Duncan Mak <duncan@ximian.com>
5622 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
5623 parsing for cmd, fixes bug #53694.
5625 2004-02-04 Marek Safar <marek.safar@seznam.cz>
5627 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
5628 in the member name duplication tests. Property and operator name duplication
5629 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
5631 2004-02-03 Marek Safar <marek.safar@seznam.cz>
5633 * interface.cs (PopulateMethod): Fixed crash when interface method
5634 returns not existing type (error test cs0246-3.cs).
5636 2004-02-02 Ravi Pratap M <ravi@ximian.com>
5638 * cs-parser.jay (interface_accessors): Re-write actions to also
5639 store attributes attached to get and set methods. Fix spelling
5642 (inteface_property_declaration): Modify accordingly.
5644 (InterfaceAccessorInfo): New helper class to store information to pass
5645 around between rules that use interface_accessors.
5647 * interface.cs (Emit): Apply attributes on the get and set
5648 accessors of properties and indexers too.
5650 * attribute.cs (ApplyAttributes): Modify accordingly to use the
5651 right MethodBuilder when applying attributes to the get and set accessors.
5653 2004-01-31 Miguel de Icaza <miguel@ximian.com>
5655 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
5657 2004-01-26 Miguel de Icaza <miguel@ximian.com>
5659 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
5661 2004-01-25 Miguel de Icaza <miguel@ximian.com>
5663 * cs-parser.jay: Remove YIELD token, instead use the new grammar
5664 changes that treat `yield' specially when present before `break'
5667 * cs-tokenizer.cs: yield is no longer a keyword.
5669 2004-01-23 Marek Safar <marek.safar@seznam.cz>
5671 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
5672 setting for default constructors.
5673 For default constructors are almost every time set wrong Modifier. The
5674 generated IL code has been alright. But inside mcs this values was
5675 wrong and this was reason why several of my CLS Compliance tests
5678 2004-02-27 Martin Baulig <martin@ximian.com>
5680 * generics.cs (ConstructedType.ResolveType): Make the nested type
5681 stuff actually work.
5683 2004-02-25 Martin Baulig <martin@ximian.com>
5685 * decl.cs (DeclSpace.CurrentTypeParameters): New protected
5686 property; returns the type parameters just from the current type,
5687 ie. with the ones from outer classes.
5688 (DeclSpace.LookupGeneric): First search in the current class, then
5690 (DeclSpace.initialize_type_params): When hiding a type parameter
5691 from an outer class, put it into the `type_param_list' anyways.
5693 * expression.cs (MemberAccess.expr): Made this field protected.
5695 * class.cs (TypeContainer.Define): The `CurrentType' just contains
5696 the type parameters from the current class.
5698 * generic.cs (ConstructedType.ResolveType): Support nested generic
5699 types by taking the type parameters which we inherit from outer
5700 classes into account.
5701 (GenericMemberAccess.ResolveAsTypeStep): Override this and added
5702 support for nested generic types.
5704 2004-02-23 Martin Baulig <martin@ximian.com>
5706 * decl.cs (DeclSpace.IsGeneric): Make this a property instead of a
5707 field and check whether we're nested inside a generic type.
5708 (DeclSpace.ResolveType): If we're resolving to a generic type
5709 definition, create a ConstructedType and return its resolved type.
5710 (DeclSpace.initialize_type_params): New private method;
5711 initializes the `type_param_list' field from the type parameters
5712 from this and all enclosing classes.
5713 (DeclSpace.TypeParameters): Call initialize_type_params() unless
5714 we're already initialized.
5716 2004-02-23 Martin Baulig <martin@ximian.com>
5718 * class.cs (Method.Define): Create the generic method before
5720 (Memberbase.DoDefine): Added DeclSpace argument (in addition to
5721 the TypeContainer one); we use this for generic methods.
5723 * decl.cs (CheckAccessLevel): If we're a GenericMethod, use our
5724 parent's TypeBuilder.
5726 2004-02-18 Martin Baulig <martin@ximian.com>
5728 * ecore.cs (FieldExpr.DoResolveLValue): Use TypeManager.IsEqual()
5729 to check for equality.
5731 2004-02-05 Martin Baulig <martin@ximian.com>
5733 * ecore.cs (FieldExpr.DoResolveLValue): If we have an
5734 `ec.TypeContainer.CurrentType', use it instead of
5735 `ec.ContainerType' to check whether we're in the type's ctor.
5737 2004-01-29 Martin Baulig <martin@ximian.com>
5739 * expression.cs (Invocation.DoResolve): If we're a
5740 `ConstructedType', then we're actually a generic method, so
5741 rewrite the expr as a GenericMemberAccess.
5743 * cs-parser.jay (member_name): Don't use `namespace_or_type_name'
5744 here; manually parse it into a string.
5746 2004-01-28 Martin Baulig <martin@ximian.com>
5748 * typemanager.cs (TypeManager.IsEqual): New static method.
5749 (TypeManager.FilterWithClosure): Call TypeManager.IsEqual() to
5750 check for equality instead of using `=='.
5752 2004-01-26 Martin Baulig <martin@ximian.com>
5754 * decl.cs (DeclSpace.CurrentType): New public field.
5756 * expression.cs (This.ResolveBase): If we have an
5757 `ec.TypeContainer.CurrentType', use it instead of
5760 * class.cs (TypeContainer.DefineType): If we're a generic type,
5761 create the `CurrentType' (unresolved).
5762 (TypeContainer.GenericType): New private field.
5763 (TypeContainer.DefineMembers): If we have a `CurrentType', resolve
5764 it and store it in `GenericType' before creating the MemberCache.
5765 (TypeContainer.GetMembers): If we have a `GenericType', call
5766 TypeManager.FindMembers() on it.
5768 * interface.cs (Interface.GenericType): New private field.
5769 (Interface.DefineType): If we're a generic type, create the
5770 `CurrentType' (unresolved).
5771 (Interface.DefineMembers): If we have a `CurrentType', resolve it
5772 and store it in `GenericType' before creating the MemberCache.
5773 (Interface.GetMembers): If we have a `GenericType', call
5774 TypeManager.FindMembers() on it.
5776 2004-01-22 Martin Baulig <martin@ximian.com>
5778 * cs-parser.jay (namespace_or_type_name): Return an Expression,
5779 not a QualifiedIdentifier. This is what `type_name_expression'
5780 was previously doing.
5781 (type_name_expression): Removed; the code is now in
5782 `namespace_or_type_name'.
5783 (qualified_identifier): Removed, use `namespace_or_type_name'
5785 (QualifiedIdentifier): Removed this class.
5787 2004-01-22 Martin Baulig <martin@ximian.com>
5789 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
5790 not a string as alias name.
5792 2004-01-21 Miguel de Icaza <miguel@ximian.com>
5794 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
5795 #52730 bug, and instead compute correctly the need to use a
5796 temporary variable when requesting an address based on the
5797 static/instace modified of the field and the constructor.
5799 2004-01-21 Martin Baulig <martin@ximian.com>
5801 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
5802 class and namespace before looking up aliases. Fixes #52517.
5804 2004-01-21 Martin Baulig <martin@ximian.com>
5806 * flowanalysis.cs (UsageVector.Merge): Allow variables being
5807 assinged in a 'try'; fixes exception4.cs.
5809 2004-01-21 Marek Safar <marek.safar@seznam.cz>
5810 * class.cs : Implemented parameter-less constructor for TypeContainer
5812 * decl.cs: Attributes are now stored here. New property OptAttributes
5814 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
5816 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
5818 2004-01-21 Marek Safar <marek.safar@seznam.cz>
5820 * typemanager.cs (CSharpSignature): Now reports also inner class name.
5821 (CSharpSignature): New method for indexer and property signature.
5823 2004-01-21 Marek Safar <marek.safar@seznam.cz>
5825 * pending.cs (IsVirtualFilter): Faster implementation.
5827 2004-01-21 Marek Safar <marek.safar@seznam.cz>
5829 * typemanager.cs: Avoid inclusion of same assembly more than once.
5831 2004-01-21 Marek Safar <marek.safar@seznam.cz>
5833 * cs-parser.jay: Fixed problem where the last assembly attribute
5834 has been applied also to following declaration (class, struct, etc.)
5836 2004-01-21 Marek Safar <marek.safar@seznam.cz>
5838 * class.cs: Added error CS0538, CS0539 reporting.
5839 Fixed crash on Microsoft runtime when field type is void.
5841 * cs-parser.jay: Added error CS0537 reporting.
5843 * pending.cs: Added error CS0535 reporting.
5844 Improved error report for errors CS0536, CS0534.
5846 2004-01-20 Miguel de Icaza <miguel@ximian.com>
5848 Merge a few bits from the Anonymous Method MCS tree.
5850 * statement.cs (ToplevelBlock): New class for toplevel methods,
5851 will hold anonymous methods, lifted variables.
5853 * cs-parser.jay: Create toplevel blocks for delegates and for
5854 regular blocks of code.
5856 2004-01-20 Martin Baulig <martin@ximian.com>
5858 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
5859 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
5860 and `NeedExplicitReturn'; added `IsLastStatement'.
5861 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
5862 have a `ReturnLabel' or we're not unreachable.
5864 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
5865 child's reachability; don't just override ours with it. Fixes
5866 #58058 (lluis's example).
5867 (FlowBranching): Added public InTryOrCatch(), InCatch(),
5868 InFinally(), InLoop(), InSwitch() and
5869 BreakCrossesTryCatchBoundary() methods.
5871 * statement.cs (Return): Do all error checking in Resolve().
5872 Unless we are the last statement in a top-level block, always
5873 create a return label and jump to it.
5874 (Break, Continue): Do all error checking in Resolve(); also make
5875 sure we aren't leaving a `finally'.
5876 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
5877 statement in a top-level block.
5878 (Block.Flags): Added `IsDestructor'.
5879 (Block.IsDestructor): New public property.
5881 2004-01-20 Martin Baulig <martin@ximian.com>
5883 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
5885 2004-01-20 Martin Baulig <martin@ximian.com>
5887 * statement.cs (Statement.ResolveUnreachable): New public method.
5888 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
5889 (Block.Resolve): Resolve unreachable statements.
5891 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
5893 * expression.cs: We need to fix the case where we do
5894 not have a temp variable here.
5896 * assign.cs: Only expression compound assignments need
5897 temporary variables.
5899 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
5901 * flowanalysis.cs: Reduce memory allocation in a few ways:
5902 - A block with no variables should not allocate a bit
5904 - A method with no out parameters does not need any tracking
5905 for assignment of the parameters, so we need not allocate
5908 public readonly Type[] VariableTypes;
5909 public readonly string[] VariableNames;
5910 Are redundant. The data is already stored in the variable
5911 map, so we need not allocate another array for it.
5912 - We need to add alot of checks for if (params | locals) == null
5913 due to the first two changes.
5915 2004-01-18 Miguel de Icaza <miguel@ximian.com>
5917 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
5918 implement IMemoryLocation, we store a copy on a local variable and
5919 take the address of it. Patch from Benjamin Jemlich
5921 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
5922 to use a special "type_name_expression" rule which reduces the
5923 number of "QualifiedIdentifier" classes created, and instead
5924 directly creates MemberAccess expressions.
5926 2004-01-17 Miguel de Icaza <miguel@ximian.com>
5928 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
5929 that fixes #52853. Null literal assignment to ValueType
5931 * class.cs (MethodData.Emit): Instead of checking the name of the
5932 method to determine if its a destructor, create a new derived
5933 class from Method called Destructor, and test for that.
5935 * cs-parser.jay: Create a Destructor object instead of a Method.
5937 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
5941 2004-01-16 Miguel de Icaza <miguel@ximian.com>
5943 * expression.cs (Binary.ResolveOperator): Perform an implicit
5944 conversion from MethodGroups to their delegate types on the
5947 * delegate.cs: Introduce a new class DelegateCreation that is the
5948 base class for `NewDelegate' and `ImplicitDelegateCreation',
5949 factor some code in here.
5951 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
5952 conversion from MethodGroups to compatible delegate types.
5954 * ecore.cs (Expression.Resolve): Do not flag error 654
5955 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
5956 we allow conversions from MethodGroups to delegate types now.
5958 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
5959 assignments in v2 either.
5961 2004-01-10 Miguel de Icaza <miguel@ximian.com>
5963 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
5964 static read-only fields in ctors.
5966 Applied patch from Benjamin Jemlich
5968 * expression.cs (UnaryMutator): Avoid leaking local variables.
5970 2004-01-09 Miguel de Icaza <miguel@ximian.com>
5972 * cs-tokenizer.cs (IsCastToken): Allow the various native types
5973 here to return true, as they can be used like this:
5977 Fixed 49836 and all the other dups
5979 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
5981 * driver.cs: Implement /win32res and /win32icon.
5983 2004-01-08 Miguel de Icaza <miguel@ximian.com>
5985 * cs-parser.jay: Add a rule to improve error handling for the
5986 common mistake of placing modifiers after the type.
5988 2004-01-07 Miguel de Icaza <miguel@ximian.com>
5990 * cs-parser.jay (interface_event_declaration): Catch
5991 initialization of events on interfaces, and report cs0068
5993 * cs-parser.jay (interface_event_declaration): Catch
5994 initialization of events.
5996 * ecore.cs: Better report missing constructors.
5998 * expression.cs (Binary.ResolveOperator): My previous bug fix had
5999 the error reporting done in the wrong place. Fix.
6001 * expression.cs (Binary.ResolveOperator): Catch the
6002 operator + (E x, E y) error earlier, and later allow for implicit
6003 conversions in operator +/- (E e, U x) from U to the underlying
6006 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
6007 52596, if the container class is abstract, the default constructor
6008 is protected otherwise its public (before, we were always public).
6010 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
6013 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
6014 Jemlich that fixes bug #52597, MCS was generating invalid code for
6015 idisposable structs. Thanks to Ben for following up with this
6018 2004-01-06 Miguel de Icaza <miguel@ximian.com>
6020 * driver.cs: Allow assemblies without code to be generated, fixes
6023 2004-01-07 Nick Drochak <ndrochak@gol.com>
6025 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
6027 2004-01-05 Miguel de Icaza <miguel@ximian.com>
6029 * cs-parser.jay: Add rules to improve error reporting if fields or
6030 methods are declared at the namespace level (error 116)
6032 * Add rules to catch event add/remove
6034 2004-01-04 David Sheldon <dave-mono@earth.li>
6036 * expression.cs: Added matching ")" to error message for
6039 2004-01-03 Todd Berman <tberman@gentoo.org>
6041 * ecore.cs, attribute.cs:
6042 Applying fix from #52429.
6044 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
6046 * ecore.cs, expression.cs, statement.cs:
6047 Total rewrite of how we handle branching. We
6048 now handle complex boolean expressions with fewer
6049 jumps. As well if (x == 0) no longer emits a ceq.
6051 if (x is Foo) is much faster now, because we generate
6054 Overall, we get a pretty big improvement on our benchmark
6055 tests. The code we generate is smaller and more readable.
6057 I did a full two-stage bootstrap. The patch was reviewed
6058 by Martin and Miguel.
6060 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
6062 * cs-parser.jay: Make primary_expression not take a QI.
6063 we dont need this because the member_access rule covers
6064 us here. So we replace the rule with just IDENTIFIER.
6066 This has two good effects. First, we remove a s/r conflict.
6067 Second, we allocate many fewer QualifiedIdentifier objects.
6069 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
6071 * attribute.cs: Handle MarshalAs attributes as pseudo, and
6072 set the correct information via SRE. This prevents
6073 hanging on the MS runtime. Fixes #29374.
6075 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
6077 * convert.cs: correctly handle conversions to value types
6078 from Enum and ValueType as unboxing conversions.
6080 Fixes bug #52569. Patch by Benjamin Jemlich.
6082 2004-01-02 Ravi Pratap <ravi@ximian.com>
6084 * expression.cs (BetterConversion): Prefer int -> uint
6085 over int -> ulong (csc's behaviour). This fixed bug #52046.
6087 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
6089 * decl.cs (MemberCache.FindMembers): now returns a
6092 * typemanager.cs: In general, go with with ^^.
6093 (CopyNewMethods): take an IList.
6094 (RealMemberLookup): Only allocate an arraylist
6095 if we copy from two sets of methods.
6097 This change basically does two things:
6098 1) Fewer array lists allocated due to CopyNewMethods.
6099 2) the explicit cast in MemberList costed ALOT.
6101 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
6103 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
6104 a hashtable to avoid needless string allocations when an identifier is
6105 used more than once (the common case).
6107 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
6109 * pending.cs: MS's TypeBuilder.GetInterfaces ()
6110 is broken, it will not return anything. So, we
6111 have to use the information we have in mcs to
6114 * typemanager.cs: Add a cache for GetInterfaces,
6115 since this will now be used more often (due to ^^)
6117 (GetExplicitInterfaces) New method that gets the
6118 declared, not effective, interfaces on a type
6119 builder (eg, if you have interface IFoo, interface
6120 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
6123 This patch makes MCS able to bootstrap itself on
6126 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
6128 * expression.cs: Remove the Nop's that Miguel put
6131 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
6133 * report.cs, codegen.cs: Give the real stack trace to
6134 the error when an exception is thrown.
6136 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
6138 * decl.cs: only allocate hashtables for ifaces if
6141 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
6143 * expression.cs: fix the error from cs0121-2.cs
6144 (a parent interface has two child interfaces that
6145 have a function with the same name and 0 params
6146 and the function is called through the parent).
6148 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
6150 * class.cs, rootcontext.cs, typmanager.cs: do not
6153 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
6155 * codegen.cs: remove stack for the ec flow branching.
6156 It is already a linked list, so no need.
6158 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
6160 * Makefile: Allow custom profiler here.
6162 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
6164 * typemanager.cs (LookupType):
6165 - Use a static char [], because split takes
6166 a param array for args, so it was allocating
6168 - Do not store true in a hashtable, it boxes.
6170 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
6172 * flowanalysis.cs: bytify common enums.
6174 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
6176 * modifiers.cs: Add a new set of flags for the
6177 flags allowed on explicit interface impls.
6178 * cs-parser.jay: catch the use of modifiers in
6179 interfaces correctly.
6180 * class.cs: catch private void IFoo.Blah ().
6182 All related to bug #50572.
6184 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
6186 * decl.cs: Rewrite the consistant accessability checking.
6187 Accessability is not linear, it must be implemented in
6188 a tableish way. Fixes #49704.
6190 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
6192 * expression.cs: Handle negation in a checked context.
6193 We must use subtraction from zero. Fixes #38674.
6195 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
6197 * class.cs: Ignore static void main in DLLs.
6198 * rootcontext.cs: Handle the target type here,
6199 since we are have to access it from class.cs
6200 * driver.cs: account for the above.
6202 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
6204 * report.cs: Give line numbers and files if available.
6206 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
6208 * driver.cs: Implement /addmodule.
6210 * typemanager.cs: Change 'modules' field so it now contains Modules not
6213 2003-12-20 Martin Baulig <martin@ximian.com>
6215 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
6216 (FieldBase.IsAssigned): Removed this field.
6217 (FieldBase.SetAssigned): New public method.
6218 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
6220 2003-12-20 Martin Baulig <martin@ximian.com>
6222 * expression.cs (LocalVariableReference.DoResolve): Don't set
6223 `vi.Used' if we're called from DoResolveLValue().
6225 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
6226 returns the usage vector it just merged into the current one -
6227 pass this one to UsageWarning().
6228 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
6229 of the `EmitContext', don't call this recursively on our children.
6231 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
6233 * driver.cs: Implement /target:module.
6235 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
6237 * support.cs (CharArrayHashtable): New helper class.
6239 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
6240 char arrays, not strings, so we can avoid creating a string in
6241 consume_identifier if the identifier is a keyword.
6243 2003-12-16 Martin Baulig <martin@ximian.com>
6245 * statement.cs (LocalInfo.Assigned): Removed this property.
6246 (LocalInfo.Flags): Removed `Assigned'.
6247 (LocalInfo.IsAssigned): New public method; takes the EmitContext
6248 and uses flow analysis.
6249 (Block.UsageWarning): Made this method private.
6250 (Block.Resolve): Call UsageWarning() if appropriate.
6252 * expression.cs (LocalVariableReference.DoResolve): Always set
6253 LocalInfo.Used here.
6255 2003-12-13 Martin Baulig <martin@ximian.com>
6257 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
6258 any value here; we're now using flow analysis to figure out
6259 whether a statement/block returns a value.
6261 2003-12-13 Martin Baulig <martin@ximian.com>
6263 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
6265 (FlowBranching.MergeFinally): Don't call
6266 `branching.CheckOutParameters()' here, this is called in
6268 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
6269 when adding the `finally' vector.
6271 2003-12-13 Martin Baulig <martin@ximian.com>
6274 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
6275 actually work and also fix #48962.
6277 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
6279 * decl.cs: Do not check System.Object for nested types,
6280 since we know it does not have any. Big bang for buck:
6285 corlib: 17.99 seconds
6289 corlib: 17.39 seconds
6291 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
6293 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
6294 time we are returning 0 members, so we save alot here.
6296 2003-12-11 Martin Baulig <martin@ximian.com>
6298 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
6299 `MergeChild()', also just take the `FlowBranching' as argument;
6300 call Merge() on it and return the result.
6301 (FlowBranching.Merge): We don't need to do anything if we just
6304 2003-12-11 Martin Baulig <martin@ximian.com>
6306 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
6307 them in an `ArrayList' to reduce memory usage. Thanks to Ben
6308 Maurer for this idea.
6310 2003-12-11 Martin Baulig <martin@ximian.com>
6312 * flowanalysis.cs (MergeResult): This class is now gone; we now
6313 use the `UsageVector' for this. The reason for this is that if a
6314 branching just has one sibling, we don't need to "merge" them at
6315 all - that's the next step to do.
6316 (FlowBranching.Merge): We now return a `UsageVector' instead of a
6319 2003-12-11 Martin Baulig <martin@ximian.com>
6321 Reworked flow analyis and made it more precise and bug-free. The
6322 most important change is that we're now using a special `Reachability'
6323 class instead of having "magic" meanings of `FlowReturns'. I'll
6324 do some more cleanups and optimizations and also add some more
6325 documentation this week.
6327 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
6328 largely reworked this class.
6329 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
6330 the new `Reachability' class instead of having "magic" values here.
6331 (FlowBranching): We're now using an instance of `Reachability'
6332 instead of having separate `Returns', `Breaks' etc. fields.
6334 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
6335 based on flow analysis; ignore the return value of block.Emit ().
6337 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
6339 * driver.cs typemanager.cs: Find the mono extensions to corlib even
6340 if they are private.
6342 2003-12-09 Martin Baulig <martin@ximian.com>
6344 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
6345 call them directly on the UsageVector.
6347 2003-12-09 Martin Baulig <martin@ximian.com>
6349 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
6350 Changed return type from `FlowReturns' to `Reachability'.
6352 2003-12-09 Martin Baulig <martin@ximian.com>
6354 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
6355 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
6356 `Reachable' fields with a single `Reachability' one.
6358 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
6360 * class.cs (FindMembers): Remove foreach's.
6373 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
6378 This patch does a few things:
6379 1. EmptyStatement is now a singleton, so it is never reallocated.
6380 2. All blah is EmptyStatement constructs have been changed to
6381 blah == EmptyStatement.Value, which is much faster and valid
6382 now that EmptyStatement is a singleton.
6383 3. When resolving a block, rather than allocating a new array for
6384 the non-empty statements, empty statements are replaced with
6385 EmptyStatement.Value
6386 4. Some recursive functions have been made non-recursive.
6387 Mainly the performance impact is from (3), however (1) and (2) are needed for
6388 this to work. (4) does not make a big difference in normal situations, however
6389 it makes the profile look saner.
6394 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
6395 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
6396 Total memory allocated: 56397 KB
6399 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
6400 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
6401 Total memory allocated: 55666 KB
6403 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
6405 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
6406 than the hashtable in a hashtable version
6408 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
6409 we always end up concating a string. This results in a huge perf
6410 loss, because many strings have to be tracked by the GC. In this
6411 patch, we first use a hashtable that works with two keys, so that
6412 the strings do not need to be concat'ed.
6423 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
6425 * Makefile: Add a new target `do-time' that does a quick and simple
6426 profile, leaving easy to parse output.
6428 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
6430 * codegen.cs (Init): Create the dynamic assembly with
6431 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
6433 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
6435 * support.cs: Make the PtrHashtable use only one
6436 instance of its comparer.
6438 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
6440 * typemanager.cs: Fix lookup of GetNamespaces.
6442 2003-11-29 Miguel de Icaza <miguel@ximian.com>
6444 * expression.cs: Removed redundant line.
6446 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
6447 ArrayLists, use for loops with bounds.
6449 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
6452 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
6453 arraylists, use for loop with bounds.
6455 The above three changes give us a 0.071 second performance
6456 improvement out of 3.294 seconds down to 3.223. On my machine
6457 the above changes reduced the memory usage by 1,387 KB during
6460 * cs-parser.jay (QualifiedIdentifier): New class used to represent
6461 QualifiedIdentifiers. Before we created a new string through
6462 concatenation, and mostly later on, the result would be
6463 manipulated by DecomposeQI through string manipulation.
6465 This reduced the compiler memory usage for bootstrapping from
6466 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
6467 compile times in 0.05 seconds.
6469 2003-11-28 Dick Porter <dick@ximian.com>
6471 * support.cs: Do string compares with the Invariant culture.
6479 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
6480 the comparison is done with the Invariant culture.
6482 2003-11-27 Miguel de Icaza <miguel@ximian.com>
6484 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
6485 GetEnumerator method.
6487 (ProbeCollectionType): Iterate starting at the most specific type
6488 upwards looking for a GetEnumerator
6490 * expression.cs: Shift count can be up to 31 for int/uint and 63
6493 2003-11-26 Miguel de Icaza <miguel@ximian.com>
6495 * statement.cs (Block.LookupLabel): Also look for the label on the
6496 children blocks. Use a hash table to keep track of visited
6499 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
6500 we actually did transform the other operand, otherwise fall back
6501 to the common codepath that casts to long.
6503 * cs-tokenizer.cs: Use the same code pattern as the int case.
6504 Maybe I should do the parsing myself, and avoid depending on the
6505 Parse routines to get this done.
6507 2003-11-25 Miguel de Icaza <miguel@ximian.com>
6509 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
6510 which fixes bug 51347. This time test it.
6512 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
6513 attributes for example can not tell the difference between these.
6514 The difference was only a syntax feature of the language.
6516 * attribute.cs: Apply attributes to delegates.
6518 * delegate.cs: Call the apply attributes method.
6520 2003-11-24 Miguel de Icaza <miguel@ximian.com>
6522 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
6523 comparing 0 vs Byte.MinValue, not the value
6525 (ImplicitConversionRequired): When reporting a conversion error,
6526 use error 31 to print out the constant error instead of the
6529 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
6530 which fixes bug 51347.
6532 2003-11-22 Miguel de Icaza <miguel@ximian.com>
6534 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
6535 which fixes the -warnaserror command line option.
6537 2003-11-21 Miguel de Icaza <miguel@ximian.com>
6539 * cfold.cs (DoNumericPromotions): During constant folding of
6540 additions on UIntConstant, special case intconstants with
6541 IntConstants like we do on the expression binary operator.
6543 2003-11-12 Miguel de Icaza <miguel@ximian.com>
6545 * convert.cs (ImplicitReferenceConversion): We were missing a case
6546 (System.Enum are not value types or class types, so we need to
6547 classify them separatedly).
6549 * driver.cs: We do not support error 2007.
6551 2003-11-12 Jackson Harper <jackson@ximian.com>
6553 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
6554 system directory. Also use the full file name so users can
6555 libraries names mscorlib-o-tron.dll in a non system dir.
6557 2004-01-04 David Sheldon <dave-mono@earth.li>
6559 * expression.cs: Added matching ")" to error message for CS0077.
6561 2003-12-19 Martin Baulig <martin@ximian.com>
6563 * typemanager.cs (TypeManager.IsEqualGenericType): New public
6564 static method; see documentation in the method.
6565 (TypeManager.IsSubclassOrNestedChild): Allow IsEqualGenericType().
6567 * convert.cs (Convert.ImplicitReferenceConversion,
6568 Convert.ImplicitReferenceConversionExists): Add support for
6569 generic type declarations; see gen-36.cs.
6571 2003-12-19 Martin Baulig <martin@ximian.com>
6573 * pending.cs (Pending.InterfaceMethod): Use
6574 `Type.IsAssignableFrom()' instead of `=='.
6576 2003-12-18 Martin Baulig <martin@ximian.com>
6578 * decl.cs (DeclSpace.AsAccessible): Check for array, pointer and
6581 * convert.cs (Convert.ImplicitStandardConversionExists): Use
6582 `expr_type.Equals (target_type)' instead of `=='.
6584 2003-12-08 Martin Baulig <martin@ximian.com>
6586 * generics.cs (Constraints.Types): Removed.
6587 (Constraints.Resolve): Just resolve everything to TypeExpr's, not
6589 (Constraints.ResolveTypes): New public method; resolves the
6590 TypeExpr's to Type's.
6591 (TypeParameter.Define): TypeBuilder.DefineGenericParameter() no
6592 longer takes the constraints.
6593 (TypeParameter.DefineMethod): Likewise.
6594 (TypeParameter.DefineType): New public method. Calls
6595 `TypeBuilder/MethodBuilder.SetGenericParameterConstraints()' to set
6598 2003-12-08 Martin Baulig <martin@ximian.com>
6600 * convert.cs (Convert.ImplicitConversionStandard): Use
6601 `expr_type.Equals (target_type)' instead of `=='.
6603 2003-12-08 Martin Baulig <martin@ximian.com>
6605 * typemanager.cs (TypeManager.GetReferenceType): Call
6606 `Type.MakeByRefType ()'.
6608 2003-12-08 Martin Baulig <martin@ximian.com>
6610 * cs-parser.jay, cs-tokenizer.cs: `where' is not a keyword, it
6611 just has some special meaning in some situations. For instance,
6612 it is allowed to use `where' as the name of a variable etc.
6614 2003-12-04 Martin Baulig <martin@ximian.com>
6616 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
6617 `Type.MakeArrayType()' for array types.
6619 2003-11-18 Miguel de Icaza <miguel@ximian.com>
6621 * expression.cs (Invocation.VerifyArgumentsCompat): Remove
6624 (SizeOf.DoResolve): assign the `type_queried' field. This gets
6627 2003-11-16 Martin Baulig <martin@ximian.com>
6629 * codegen.cs (EmitContext.IsGeneric): Removed.
6631 * ecore.cs (SimpleName.ResolveAsTypeStep): Always call
6632 ResolveGeneric() on the DeclSpace.
6634 2003-11-16 Martin Baulig <martin@ximian.com>
6636 * generic.cs (TypeArguments.Resolve):
6637 `Expression.ResolveAsTypeTerminal()' returns a TypeExpr; call
6638 `ResolveType()' on it to get the Type.
6640 2003-11-15 Martin Baulig <martin@ximian.com>
6642 * generic.cs (ConstructedType.GetInterfaces): Override this.
6644 2003-11-14 Martin Baulig <martin@ximian.com>
6646 * interface.cs (Interface.DefineType): Define all type parameters
6647 before adding the interfaces we inherit.
6649 2003-11-11 Martin Baulig <martin@ximian.com>
6651 * generic.cs (ConstructedType.ResolveType): Always call
6652 `gt.BindGenericParameters (atypes)'; also if `args.HasTypeArguments'.
6654 2003-11-10 Martin Baulig <martin@ximian.com>
6656 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
6657 (TypeManager.InitCoreTypes): Initialize them here, but instead of
6658 calling `ResolveType()' on them, directly assign their `Type'.
6660 2003-11-08 Martin Baulig <martin@ximian.com>
6662 * generic.cs (ConstructedType): Override `IsClass' etc.
6664 2003-11-08 Martin Baulig <martin@ximian.com>
6666 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
6667 return value and the `out parent' parameter.
6668 (TypeContainer.DefineType): Moved the CS0644 check into
6669 GetClassBases(). Don't pass the interface types to the
6670 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
6671 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
6673 * ecore.cs (TypeExpr.IsAttribute): New property.
6674 (TypeExpr.GetInterfaces): New method.
6676 * interface.cs (Interface.GetInterfaceTypeByName): Return a
6677 TypeExpr instead of a Type.
6678 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
6679 (Interface.DefineType): Don't pass the interface types to the
6680 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
6681 them later and then call `TypeBulider.AddInterfaceImplementation()'.
6683 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
6684 instead of a `Type[]'.
6685 (TypeManager.RegisterBuilder): Likewise.
6686 (TypeManager.AddUserInterface): Likewise.
6687 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
6688 `Type[]' and also return a `TypeExpr[]'.
6689 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
6691 2003-11-08 Martin Baulig <martin@ximian.com>
6693 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
6696 2003-11-08 Martin Baulig <martin@ximian.com>
6698 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
6699 TypeManager.ResolveExpressionTypes().
6701 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
6702 instead of an Expression.
6703 (TypeExpr): This is now an abstract base class for `TypeExpression'.
6704 (TypeExpression): New public class; formerly known as `TypeExpr'.
6706 * expression.cs (ComposedCast): Derive from TypeExpr.
6708 * typemanager.cs (TypeManager.system_*_expr): These are now
6709 TypExpr's instead of Expression's.
6710 (TypeManager.ResolveExpressionTypes): New public static function;
6711 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
6714 2003-11-06 Miguel de Icaza <miguel@ximian.com>
6716 * expression.cs (New.DoResolve): Do not dereference value that
6717 might be a null return.
6719 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
6720 sure that the constant value has the right type. Fixes an
6721 unreported bug, similar to 50425.
6723 * const.cs (Const.LookupConstantValue): Call
6724 ImplicitStandardConversionExists before doing a conversion to
6725 avoid havng the TypeManager.ChangeType do conversions.
6727 Reduced the number of casts used
6729 (Const.ChangeType): New routine to enable reuse of the constant
6730 type changing code from statement.
6732 * typemanager.cs (ChangeType): Move common initialization to
6733 static global variables.
6737 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
6738 every value type to go through, even if it was void. Fix that.
6740 * cs-tokenizer.cs: Use is_identifier_start_character on the start
6741 character of the define, and the is_identifier_part_character for
6742 the rest of the string.
6744 2003-11-05 Miguel de Icaza <miguel@ximian.com>
6746 * expression.cs (UnaryMutator.EmitCode): When I updated
6747 LocalVariableReference.DoResolve, I overdid it, and dropped an
6748 optimization done on local variable references.
6750 2003-11-04 Miguel de Icaza <miguel@ximian.com>
6752 * ecore.cs: Convert the return from Ldlen into an int.
6754 2003-10-20 Miguel de Icaza <miguel@ximian.com>
6756 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
6757 the accessibility, this is a special case for toplevel non-public
6758 classes (internal for instance).
6760 2003-10-20 Nick Drochak <ndrochak@gol.com>
6762 * ecore.cs: Fix typo and build. Needed another right paren.
6764 2003-10-19 Miguel de Icaza <miguel@ximian.com>
6766 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
6767 `internal' case regular and protected, but not allowing protected
6768 to be evaluated later. Bug 49840
6770 2003-10-15 Miguel de Icaza <miguel@ximian.com>
6772 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
6773 to kb.Nlast, and not the kb.nFirst to isolate the switch
6776 Extract the underlying type, so enumerations of long/ulong are
6777 treated like long/ulong.
6779 2003-10-14 Miguel de Icaza <miguel@ximian.com>
6781 * expression.cs (New): Overload the meaning of RequestedType to
6782 track the possible creation of the NewDelegate type, since
6783 DoResolve is invoked more than once for new constructors on field
6786 See bugs: #48800 and #37014
6788 * cs-parser.jay (declare_local_constants): Take an arraylist
6789 instead of a single constant.
6791 (local_constant_declaration): It should take a
6792 constant_declarators, not a constant_declarator. Fixes 49487
6794 * convert.cs: Fix error report.
6796 2003-10-13 Jackson Harper <jackson@ximian.com>
6798 * typemanager.cs (TypeToCoreType): Add float and double this fixes
6801 2003-11-03 Martin Baulig <martin@ximian.com>
6803 * expression.cs (ArrayAccess.GetStoreOpcode): Added
6804 `out bool has_type_arg'; if set, we need to pass the type to
6806 (ArrayAccess.GetStoreOpcode, ArrayAccess.EmitLoadOpcode): Use
6807 Stelem_Any/Ldelem_Any for generic parameters.
6809 2003-11-02 Martin Baulig <martin@ximian.com>
6811 * expression.cs (Invocation.EmitCall): Use
6812 `TypeManager.IsValueType()' to check whether it's a value type.
6813 Don't set `struct_call' when calling a method on a type parameter.
6815 2003-11-02 Martin Baulig <martin@ximian.com>
6817 * generics.cs (ConstructedType.Resolve): Renamed to ResolveType()
6818 and removed the TypeBuilder argument.
6820 * typemanager.cs (TypeManager.IsValueType): Return
6821 `t.IsGenericParameter || t.IsValueType'.
6823 2003-10-25 Martin Baulig <martin@ximian.com>
6825 * decl.cs (DeclSpace.ResolveType): If we're a ConstructedType,
6826 call ConstructedType.Resolve() on it.
6828 * generic.cs (ConstructedType.Resolve): Set `type' on success.
6830 2003-10-25 Martin Baulig <martin@ximian.com>
6832 * class.cs (TypeContainer.GetClassBases): Changed
6833 `out Type parent' into `out TypeExpr parent'. Moved CS0644 and
6834 CS8214 reporting here.
6835 (TypeContainer.DefineType): GetClassBases() gives us a `TypeExpr'
6836 instead of a `Type' for our parent. In case of a recursive
6837 declaration (see tests/gen-23.cs for an example), our parent is a
6838 ConstructedType and it doesn't have its type set. So, first
6839 create our own TypeBuilder, then call constructed.Resolve() to get
6840 the parent's type and finally TypeBuilder.SetParent() it.
6842 * ecore.cs (TypeExpr.Name): New public virtual property.
6845 (ConstructedType): We're now a TypeExpr and not just an Expression.
6846 (ConstructedType.ResolveAsTypeStep): Don't resolve our type
6847 arguments here; this is done later.
6848 (ConstructedType.Resolve): New public method to resolve the type
6849 arguments and bind them.
6851 2003-10-21 Martin Baulig <martin@ximian.com>
6853 * convert.cs: Use `TypeManager.IsValueType' instead of
6854 'type.IsValueType' everywhere.
6856 * typemanager.cs (TypeManager.IsValueType): Return true for type
6857 parameters. The reason for this is that we need to box a type
6858 parameter when converting it to a reference type.
6860 * cs-parser.jay: Added support for default value expressions.
6862 * generics.cs (DefaultValueExpression): New public class.
6864 2003-10-17 Martin Baulig <martin@ximian.com>
6866 * generic.cs (Constraints.Resolve): Take a DecpSpace instead of a
6867 TypeContainer so we can also use this for Interfaces.
6868 (TypeParameter.Resolve): Likewise.
6870 * interface.cs (Interface.DefineType): Added support for generic
6873 * cs-parser.jay: Added support for generic structs and interfaces.
6875 2003-10-17 Martin Baulig <martin@ximian.com>
6877 * generic.cs (GenericMemberAccess.DoResolve): We can now actually
6878 call generic methods :-)
6880 2003-10-16 Martin Baulig <martin@ximian.com>
6882 * cs-parser.jay (namespace_or_type_name): Only create a
6883 GenericMemberAccess if we actually have type arguments.
6885 2003-10-13 Martin Baulig <martin@ximian.com>
6887 * class.cs (Method.Define): If we're a generic method, call
6888 TypeBuilder.DefineGenericMethod () before resolving
6890 (MethodData): Added .ctor which takes an additional MethodBuilder
6891 argument; this is used for generic methods.
6892 (MethodData.Define): Call `builder.SetGenericMethodSignature()' if
6893 we already have a MethodBuilder.
6895 2003-10-10 Martin Baulig <martin@ximian.com>
6897 * class.cs (Method): Added .ctor which takes a `GenericMethod'
6898 instead of a `DeclSpace'. This is used for generic methods.
6900 * cs-parser.jay (method_header): Added support for generic
6901 methods; create a `GenericMethod' instance and pass it to the
6902 `Method's .ctor; it'll be used as the `DeclSpace' to lookup
6903 parameters and locals.
6905 * decl.cs (DeclSpace.SetParameterInfo): Removed Location argument
6906 since we already have the location. Check whether we're a generic
6907 type declaration or a generic method and create the correct type
6910 * generic.cs (TypeParameter.DefineMethod): New public method.
6911 (GenericMethod): New public class; derives from DeclSpace and is
6912 used for generic methods.
6914 2003-10-09 Martin Baulig <martin@ximian.com>
6916 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
6918 (MethodCore.DoDefineParameters): Removed the TypeContainer
6919 argument; use the DeclSpace which was passed to the .ctor instead.
6920 (MethodCore.CheckParameter): Take a DeclSpace instead of a
6921 TypeContainer; we only need a DeclSpace here.
6923 2003-10-09 Martin Baulig <martin@ximian.com>
6925 * class.cs (MethodData): Added additional `DeclSpace ds' argument
6927 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
6928 EmitContext's .ctor.
6930 2003-10-09 Martin Baulig <martin@ximian.com>
6932 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
6933 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
6934 AsAccessible(), moved them as well.
6936 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
6938 2003-10-07 Miguel de Icaza <miguel@ximian.com>
6940 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
6941 generation for >=, as spotted by Paolo, bug 48679.
6942 Patch from David Waite.
6944 * cs-tokenizer.cs: Add handling for #pragma.
6946 * cs-parser.jay: Allow for both yield and yield return in the
6947 syntax. The anti-cobolization of C# fight will go on!
6949 * class.cs (TypeBuilder.DefineType): Catch error condition here
6950 (Parent.DefineType erroring out and returning null).
6952 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
6953 coping with enumerations variables, we were mistakenly processing
6954 them as a regular value type instead of built-in types. Fixes the
6957 * typemanager.cs (IsBuiltinOrEnum): New method.
6959 2003-09-30 Miguel de Icaza <miguel@ximian.com>
6961 * cs-parser.jay: Upgrade: yield now needs the return clause.
6963 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
6965 * cs-parser.jay : Renamed yyName to yyNames related to jay.
6967 2003-09-29 Martin Baulig <martin@ximian.com>
6969 * typemanager.cs (TypeManager.GetMethodFlags): Added support for
6970 inflated generic methods.
6972 * generics.cs (ConstructedType): Distinguish between open and
6973 closed constructed types; correctly resolve the arguments.
6975 2003-09-22 Martin Baulig <martin@ximian.com>
6977 * generic.cs (ConstructedType.ResolveAsTypeCheck): Check whether
6978 all type arguments meet their constraints.
6980 2003-09-19 Martin Baulig <martin@ximian.com>
6982 * decl.cs (MemberCache.SetupCacheForInterface): Take a
6983 `MemberCache parent' argument. Normally, an interface doesn't
6984 have a parent type except System.Object, but we use this in gmcs
6985 for generic type parameters.
6987 2003-09-18 Martin Baulig <martin@ximian.com>
6989 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
6990 on `type.IsInterface'; don't check whether the type has a parent
6991 to determine whether it's an interface.
6993 2003-09-17 Martin Baulig <martin@ximian.com>
6995 * generic.cs (ConstructedType.ToString): Always use `name' as the
6998 2003-09-15 Martin Baulig <martin@ximian.com>
7000 * cs-parser.jay: Fix grammar wrt. type_parameter_constraints.
7002 * generic.cs (Constraints.Resolve): New public method; this is
7003 called to resolve the constraint types and to check whether all
7004 the constraints are correct.
7005 (Constraints.Types): New public property.
7006 (TypeParameter.Resolve): New public method; resolves all the
7009 * class.cs (TypeContainer.DefineType): Call
7010 TypeParameter.Resolve() before actually defining the type.
7012 2003-09-15 Martin Baulig <martin@ximian.com>
7014 * class.cs (TypeContainer.DefineType): Added an error flag to
7015 avoid reporting duplicate CS0146's ("class definition is
7018 * driver.cs (Driver.MainDriver): Abort if
7019 RootContext.ResolveTree() reported any errors.
7021 2003-09-07 Martin Baulig <martin@ximian.com>
7023 * report.cs (Error, Warning): Added overloaded versions which take
7024 a `params object[] args' and call String.Format().
7026 2003-09-07 Martin Baulig <martin@ximian.com>
7028 * decl.cs (DeclSpace..ctor): Don't call
7029 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
7030 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
7031 (DeclSpace.RecordDecl): New method.
7033 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
7035 2003-09-02 Ravi Pratap <ravi@ximian.com>
7037 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
7038 value attributes to be applied to ParameterBuilders.
7040 * class.cs (MethodCore.LabelParameters): Make static and more
7041 generic so that it can be used from other places - like interface
7042 methods, for instance.
7044 * interface.cs (Interface.Emit): Call LabelParameters before
7045 emitting attributes on the InterfaceMethod.
7047 2003-09-07 Martin Baulig <martin@ximian.com>
7049 * generic.cs (ConstructedType.ResolveAsTypeStep): Report a CS8217
7050 if the number of type parameters doesn't match.
7052 2003-09-04 Martin Baulig <martin@ximian.com>
7054 * expression.cs (ComposedCast.ResolveAsTypeStep): Added support
7055 for arrays of generic type params (ie. `!0[]').
7057 2003-09-04 Martin Baulig <martin@ximian.com>
7059 * class.cs (TypeContainer.AsAccessible): Ignore generic parameters
7062 2003-09-04 Martin Baulig <martin@ximian.com>
7064 * decl.cs (DeclSpace.LookupGeneric): New method.
7065 (DeclSpace.CheckAccessLevel): Ignore generic parameters for the
7068 * generic.cs (TypeParameterExpr): Take a TypeParameter as
7069 argument, not just a string.
7070 (TypeParameter.Define): New public method; this is called to
7071 actually define the generic parameter; after this, you can use the
7072 new `Type' property to get the type.
7074 2003-09-04 Martin Baulig <martin@ximian.com>
7076 * decl.cs (DeclSpace.SetParameterInfo): The `constraints' argument
7077 is now an ArrayList; initialize the result of the `TypeParameters'
7079 (DeclSpace.GetGenericData): Removed.
7080 (DeclSpace.LookupGeneric): Temporarily removed; we need to
7081 implement this in a different way.
7082 (DeclSpace.GetTypeParameters): Removed; there's now a
7083 `TypeParameters' property.
7084 (DeclSpace.TypeParameters): New public property.
7086 * generic.cs (Constraints): Make this class public.
7087 (TypeParameter): New public class.
7089 2003-09-04 Martin Baulig <martin@ximian.com>
7091 * decl.cs (DeclSpace.GetTypeParameters): New method to return the
7094 * class.cs (TypeContainer.DefineType): Call
7095 TypeBuilder.DefineGenericParameter () on all generic parameters if
7096 this is a generic type.
7098 2003-08-28 Martin Baulig <martin@ximian.com>
7100 * sample-stack.il: Compile this with ilasm: "ilasm /dll
7103 * sample-hello.cs: Compile this with gmcs: "gmcs
7104 /r:sample-stack.dll sample-hello.cs".
7106 2003-08-28 Martin Baulig <martin@ximian.com>
7108 * generic.cs (ConstructedType.ResolveAsTypeStep): Actually bind
7109 the parameters to the generic type.
7111 2003-08-28 Martin Baulig <martin@ximian.com>
7113 * cs-tokenizer.cs (parse_less_than): Also allow all builtin types.
7115 2003-08-28 Martin Baulig <martin@ximian.com>
7117 * cs-parser.jay (opt_type_argument_list): Use
7118 `OP_GENERICS_LT type_arguments OP_GENERICS_GT'.
7119 (primary_expression): Replace `qualified_identifier' with `type_name'.
7120 (type_parameter_list): Use `OP_GENERICS_LT type_parameters OP_GENERICS_GT'.
7122 * cs-tokenizer.cs (is_punct): When reading a `<', invoke a custom
7123 parser to check whether it is syntactically a type parameter list;
7124 return OP_GENERICS_LT/OP_GENERICS_GT instead of OP_LT/OP_GT in
7127 2003-08-26 Martin Baulig <martin@ximian.com>
7129 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
7130 resolving aliases; fixes #47927.
7132 2003-08-26 Martin Baulig <martin@ximian.com>
7134 * statement.cs (Using.DoResolve): This is internally emitting a
7135 try/finally clause, so we need to set ec.NeedExplicitReturn if we
7136 do not always return. Fixes #47681.
7138 2003-08-26 Martin Baulig <martin@ximian.com>
7140 * decl.cs (MemberCore): Moved WarningNotHiding(),
7141 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
7143 (AdditionResult): Make this nested in DeclSpace.
7144 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
7145 argument; call NamespaceEntry.Define() unless we're nested in a
7148 * namespace.cs (Namespace.DefineName): New public function. This
7149 is called from DeclSpace's .ctor to add
7150 (Namespace.Lookup): Include DeclSpaces in the lookup.
7152 * class.cs (Operator): Derive from MemberBase, not MemberCore.
7154 * const.cs (Const): Derive from MemberBase, not MemberCore.
7156 2003-08-25 Martin Baulig <martin@ximian.com>
7158 * convert.cs (Convert.ExplicitReferenceConversion): When
7159 converting from an interface type to a class, unbox if the target
7160 type is a struct type. Fixes #47822.
7162 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7164 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
7167 2003-08-22 Martin Baulig <martin@ximian.com>
7169 * class.cs (TypeManager.DefineType): When defining a nested type,
7170 call DefineType() on our parent; fixes #47801.
7172 2003-08-22 Martin Baulig <martin@ximian.com>
7174 * class.cs (MethodData.Define): While checking if a method is an
7175 interface implementation, improve the test a bit more to fix #47654.
7177 2003-08-22 Martin Baulig <martin@ximian.com>
7179 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
7180 correctly; fixes #47722.
7182 2003-08-22 Martin Baulig <martin@ximian.com>
7184 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
7185 LocalVariableReference, ensure it's not read-only. Fixes #47536.
7187 * statement.cs (Fixed.DoResolve): Make all variables read-only.
7189 2003-08-22 Martin Baulig <martin@ximian.com>
7191 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
7192 can only be assigned in static constructors. Fixes #47161.
7194 2003-08-22 Martin Baulig <martin@ximian.com>
7196 Rewrote and improved the flow analysis code.
7198 * flowbranching.cs (FlowBranching): Make this class abstract.
7199 (FlowBranching.CreateBranching): New static function to create a
7201 (FlowBranchingBlock, FlowBranchingException): New classes.
7202 (FlowBranching.UsageVector.Type): New public readonly field.
7203 (FlowBranching.UsageVector.Breaks): Removed the setter.
7204 (FlowBranching.UsageVector.Returns): Removed the setter.
7205 (FlowBranching.UsageVector): Added Break(), Return(),
7206 NeverReachable() and Throw() methods to modify the reachability.
7207 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
7208 done by FlowBranching.Merge().
7209 (FlowBranching.UsageVector.MergeChild): New method; merges the
7210 merge result into the current vector.
7211 (FlowBranching.Merge): New abstract method to merge a branching.
7213 2003-08-12 Martin Baulig <martin@ximian.com>
7215 * expression.cs (Indirection.CacheTemporaries): Create the
7216 LocalTemporary with the pointer type, not its element type.
7218 2003-08-10 Miguel de Icaza <miguel@ximian.com>
7220 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
7221 token was a keyword or not.
7223 Add `error' options where an IDENTIFIER was expected; Provide
7224 CheckToken and CheckIdentifierToken convenience error reporting
7227 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
7229 * decl.cs: Rename `NamespaceEntry Namespace' public field into
7230 NameSpaceEntry NameSpaceEntry.
7232 (LookupInterfaceOrClass): Avoid creating a full qualified name
7233 from namespace and name: avoid doing lookups when we know the
7234 namespace is non-existant. Use new Tree.LookupByNamespace which
7235 looks up DeclSpaces based on their namespace, name pair.
7237 * driver.cs: Provide a new `parser verbose' to display the
7238 exception thrown during parsing. This is turned off by default
7239 now, so the output of a failure from mcs is more graceful.
7241 * namespace.cs: Track all the namespaces defined in a hashtable
7244 (IsNamespace): New method
7246 2003-08-09 Miguel de Icaza <miguel@ximian.com>
7248 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
7249 we know that we need to concatenate (full typename can never be
7254 * statement.cs: Use a bitfield; Do not initialize to null things
7255 which are done by the constructor by default.
7257 * cs-parser.jay: bug fix, parameter was 4, not 3.
7259 * expression.cs: Just use the property;
7261 * statement.cs: No need for GetVariableInfo method.
7263 2003-08-08 Martin Baulig <martin@ximian.com>
7265 * flowanalysis.cs (FlowReturns): This is now nested in the
7266 `FlowBranching' class.
7267 (MyBitVector): Moved this here from statement.cs.
7268 (FlowBranching.SiblingType): New enum type.
7269 (FlowBranching.CreateSibling): Added `SiblingType' argument.
7271 2003-08-07 Martin Baulig <martin@ximian.com>
7273 * flowanalysis.cs (FlowBranchingType): This is now nested in the
7274 `FlowBranching' class and called `BranchingType'.
7276 2003-08-07 Martin Baulig <martin@ximian.com>
7278 * flowanalysis.cs: Moved all the control flow analysis code into
7281 2003-08-07 Martin Baulig <martin@ximian.com>
7283 * assign.cs (Assign.DoResolve): `target' must either be an
7284 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
7287 2003-08-07 Miguel de Icaza <miguel@ximian.com>
7289 * expression.cs (BinaryMethod): This kind of expression is created by the
7290 Binary class if it determines that the operator has to be handled
7293 (BinaryDelegate): This kind of expression is created if we are
7294 dealing with a + or - operator on delegates.
7296 (Binary): remove method, argumetns, and DelegateOperator: when
7297 dealing with methods,
7299 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
7301 * statement.cs (Block): use bitfields for the three extra booleans
7302 we had in use. Remove unused topblock parameter.
7304 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
7306 * assign.cs: Drop extra unneeded tests.
7308 2003-08-06 Miguel de Icaza <miguel@ximian.com>
7310 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
7312 * statement.cs (Foreach): Use VariableStorage instead of
7315 * codegen.cs (VariableStorage): New class used by clients that
7316 require a variable stored: locals or fields for variables that
7317 need to live across yield.
7319 Maybe provide a convenience api for EmitThis+EmitLoad?
7321 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
7324 2003-08-05 Miguel de Icaza <miguel@ximian.com>
7326 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
7327 RemapParameterLValue): New methods that are used to turn a
7328 precomputed FieldInfo into an expression like this:
7332 The idea is to use this instead of making LocalVariableReference
7333 have more than one meaning.
7335 * cs-parser.jay: Add error production to BASE.
7337 * ecore.cs: Deal with TypeManager.GetField returning null, which
7338 is now a valid return value.
7340 (FieldExprNoAddress): New expression for Fields whose address can
7343 * expression.cs (LocalVariableReference): During the resolve
7344 phases, create new expressions if we are in a remapping context.
7345 Remove code that dealt with remapping here.
7347 (ParameterReference): same.
7349 (ProxyInstance): New expression, like the `This' expression, but
7350 it is born fully resolved. We know what we are doing, so remove
7351 the errors that are targeted to user-provided uses of `this'.
7353 * statement.cs (Foreach): our variable is now stored as an
7354 Expression; During resolution, follow the protocol, dont just
7355 assume it will return this.
7357 2003-08-06 Martin Baulig <martin@ximian.com>
7359 * support.cs (SeekableStreamReader.cs): New public class.
7361 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
7362 SeekableStreamReader instead of the normal StreamReader.
7364 2003-08-04 Martin Baulig <martin@ximian.com>
7366 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
7367 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
7368 deambiguate casts and delegate invocations.
7369 (parenthesized_expression): Use the new tokens to ensure this is
7370 not a cast of method invocation.
7372 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
7373 when reading a `)' and Deambiguate_CloseParens () was previously
7376 * expression.cs (ParenthesizedExpression): New class. This is
7377 just used for the CS0075 test.
7378 (Binary.DoResolve): Check for CS0075.
7380 2003-07-29 Ravi Pratap <ravi@ximian.com>
7382 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
7383 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
7384 reference comparison.
7386 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
7387 examine the ReturnType for equality - this is necessary in the
7388 cases of implicit and explicit operators whose signature also
7389 includes the return type.
7391 2003-07-26 Miguel de Icaza <miguel@ximian.com>
7393 * namespace.cs: Cache the result of the namespace computation,
7394 instead of computing it every time.
7396 2003-07-24 Miguel de Icaza <miguel@ximian.com>
7398 * decl.cs: Use a global arraylist that we reuse over invocations
7399 to avoid excesive memory consumption. Reduces memory usage on an
7400 mcs compile by one meg (45 average).
7402 * typemanager.cs (LookupTypeReflection): In .NET pointers are
7403 private, work around that.
7405 2003-07-23 Miguel de Icaza <miguel@ximian.com>
7407 * literal.cs (IntLiteral): Define Zero and One static literals.
7409 * cs-parser.jay (integer_literal): use static literals to reduce
7410 memory usage for the most used literals (0, 1 and -1). 211kb
7411 reduced in memory usage.
7413 Replace all calls to `new ArrayList' with `new
7414 ArrayList(4)' which is a good average number for most allocations,
7415 and also requires only 16 bytes of memory for its buffer by
7418 This reduced MCS memory usage in seven megabytes for the RSS after
7421 2003-07-28 Ravi Pratap <ravi@ximian.com>
7423 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
7424 handle params methods the correct way by forming only one
7425 applicable set with params and normal methods in them. Earlier we
7426 were looking at params methods only if we found no normal methods
7427 which was not the correct thing to do.
7429 (Invocation.BetterFunction): Take separate arguments indicating
7430 when candidate and the best method are params methods in their
7433 This fixes bugs #43367 and #46199.
7435 * attribute.cs: Documentation updates.
7437 (CheckAttribute): Rename to CheckAttributeTarget.
7438 (GetValidPlaces): Rename to GetValidTargets.
7440 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
7441 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
7445 2003-07-28 Miguel de Icaza <miguel@ximian.com>
7447 * codegen.cs: Compute IsGeneric correctly.
7449 * cs-parser.jay: Introduce OP_GENERIC_LT for the grammar ambiguity
7452 Bring back (temporarily) OP_LEFT_SHIFT, OP_RIGHT_SHIFT,
7453 OP_SHIFT_RIGHT_ASSIGN, OP_SHIFT_LEFT_ASSIGN. There were too many
7454 regressions, and I was chasing more bugs than I required.
7456 * interface.cs: Use expressions for base type names (like classes
7457 and structs have been doing for a while now), and resolve that.
7458 This patch should probably go into head as well.
7460 This makes it one less user of FindType.
7462 2003-07-24 Miguel de Icaza <miguel@ximian.com>
7464 This compiler can not self host currently. Need to fix that.
7466 * Makefile: compile to `gmcs.exe'
7468 * driver.cs: Turn on v2 by default on gmcs.
7470 * generic.cs (ConstructedType): Does no longer take a container
7471 type argument; That will be taken care of later.
7473 (ConstructedType.DoResolve, ConstructedType.ResolveAsTypeStep):
7474 Use SimpleName to resolve for now, so we can continue the work on
7475 the parser, until we get Type.GetType that understands generics.
7477 (ConstructedType.ToString): Implement
7479 (TypeArguments.Resolve): Resolve the child expressions as types.
7481 * cs-parser.jay: Rename interface_constraints to
7482 type_parameter_constraints
7484 (namespace_or_type_name): Only use constructed types for the basic
7485 construction, we will deal with identifier<...> later.
7487 (type/type_name): No longer call DecomposeQI, as
7488 namespace_or_type_name is always decoded now.
7490 2003-07-22 Ravi Pratap <ravi@ximian.com>
7492 * expression.cs (Invocation.OverloadResolve): Follow the spec more
7493 closely: we eliminate methods in base types when we have an
7494 applicable method in a top-level type.
7496 Please see section 14.5.5.1 for an exact description of what goes
7499 This fixes bug #45127 and a host of other related to corlib compilation.
7501 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
7502 array is the method corresponding to the top-level type (this is
7503 because of the changes made to icall.c) so we change this
7506 (MethodGroupExpr.Name): This too.
7508 * typemanager.cs (GetElementType): New method which does the right
7509 thing when compiling corlib.
7511 * everywhere: Make use of the above in the relevant places.
7513 2003-07-22 Martin Baulig <martin@ximian.com>
7515 * cs-parser.jay (invocation_expression): Moved
7516 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
7517 `cast_expression', but create a InvocationOrCast which later
7518 resolves to either an Invocation or a Cast.
7520 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
7521 method; call this before EmitStatement() to make sure that this
7522 expression can be used as a statement.
7524 * expression.cs (InvocationOrCast): New class; resolves to either
7525 an Invocation or a Cast.
7527 * statement.cs (StatementExpression): Call ResolveStatement() on
7528 the ExpressionStatement before emitting it.
7530 2003-07-21 Martin Baulig <martin@ximian.com>
7532 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
7533 `ref' and `out' attributes match; fixes #46220.
7534 (MemberAccess.ResolveMemberAccess): You can't reference a type
7535 through an expression; fixes #33180.
7536 (Indexers.GetIndexersForType): Don't return the indexers from
7537 interfaces the class implements; fixes #46502.
7539 2003-07-21 Martin Baulig <martin@ximian.com>
7541 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
7542 CS0661 checks; fixes bug #30442.
7544 2003-07-21 Martin Baulig <martin@ximian.com>
7546 * decl.cs (AdditionResult): Added `Error'.
7548 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
7550 * typemanager.cs (TypeManager.ChangeType): Catch exceptions; makes
7551 cs0031.cs actually work.
7553 2003-07-20 Miguel de Icaza <miguel@ximian.com>
7555 * cs-parser.jay (namespace_name): do not use
7556 namespace_or_type_name, use qualified_identifier, because
7557 namespace_or_type_name will soon return a composed expression
7558 instead of a string.
7560 (namespace_or_type_name): Instead of returning a string, now this
7561 production returns an expression.
7563 * codegen.cs (EmitContext): Setup IsGeneric property based on
7564 whether our DeclSpace is generic, our the method is generic.
7566 * modifier.cs (Modifiers.METHOD_GENERIC): New definition, use if
7567 the method is generic.
7569 * cs-parser.jay (type_arguments, opt_type_argument_list,
7570 type_parameters, type_parameter_list, opt_type_parameter_list,
7571 type_parameter,, opt_type_parameter_constraints_clauses,
7572 type_parameter_constraints_clauses,
7573 type_parameter_constraint_clause, type_parameter_constraint,
7574 interface_constraints): Add new production
7576 * decl.cs (DeclSpace): IsGeneric, flag to track whether this
7577 DeclSpace is generic or not.
7579 (DeclSpace.SetParameterInfo): New routine, used to set the
7580 parameter info for a type.
7582 (DeclSpace.LookupGeneric): Lookups a name, and if it is a generic,
7583 returns a GenericTypeExpr
7585 * ecore.cs (SimpleName.ResolveAsTypeStep): If our container is
7586 generic, lookup the generic argument.
7588 * attribute.cs: Do not allow TypeParameterExpressions in
7591 * class.cs: Do not allow the Main method to be defined in a
7594 * expression.cs (SizeOf): Do not allow generic types to be used as
7595 arguments to sizeof.
7597 * typemanager.cs (IsGeneric): Wrapper for Reflection when we have
7598 it: whether a type is generic or not. Only works for types we are
7599 currently building for now.
7601 2003-07-20 Martin Baulig <martin@ximian.com>
7603 * namespace.cs: Fixed that bug which caused a crash when compiling
7606 2003-07-20 Miguel de Icaza <miguel@ximian.com>
7608 * typemanager.cs (LookupTypeReflection): Never expose types which
7609 are NotPublic, NestedPrivate, NestedAssembly, or
7610 NestedFamANDAssem. We used to return these, and later do a check
7611 that would report a meaningful error, but the problem is that we
7612 would not get the real match, if there was a name override.
7614 2003-07-18 Miguel de Icaza <miguel@ximian.com>
7616 * namespace.cs (Namespace, Name): Do not compute the namespace
7617 name dynamically, compute it in the constructor. This reduced
7618 memory usage by 1697 KB.
7620 * driver.cs: Use --pause to pause at the end.
7622 2003-07-17 Peter Williams <peter@newton.cx>
7624 * Makefile: Change the name of the test target so that it doesn't
7625 conflict with the recursive test target.
7627 2003-07-17 Miguel de Icaza <miguel@ximian.com>
7629 * expression.cs (LocalVariableReference.Emit, EmitAssign,
7630 AddressOf): Do not use EmitThis, that was wrong, use the actual
7633 2003-07-15 Miguel de Icaza <miguel@ximian.com>
7635 * class.cs (MethodData.Define): While checking if a method is an
7636 interface implementation, improve the test: If we are not public
7637 (use new test here: use the computed MethodAttributes directly,
7638 instead of the parsed modifier flags) check if the `implementing'
7639 method comes from an interface or not.
7641 * pending.cs (VerifyPendingMethods): Slightly better error
7644 * makefile: add test target that does the mcs bootstrap.
7646 2003-07-16 Ravi Pratap <ravi@ximian.com>
7648 * interface.cs (Define): Do nothing here since there are no
7649 members to populate etc. Move the attribute emission out of here
7650 since this was just totally the wrong place to put it. Attribute
7651 application happens during the 'Emit' phase, not in the 'Define'
7654 (Emit): Add this method and move the attribute emission here
7656 * rootcontext.cs (EmitCode): Call the Emit method on interface
7659 2003-07-14 Ravi Pratap M <ravi@ximian.com>
7661 * expression.cs (OverloadResolve): Report error only if Location
7662 is not 'Null' which means that there was a probe going on.
7664 2003-07-14 Martin Baulig <martin@ximian.com>
7666 * expression.cs (ConditionalLogicalOperator): New public class to
7667 implement user defined conditional logical operators.
7668 This is section 14.11.2 in the spec and bug #40505.
7670 2003-07-14 Martin Baulig <martin@ximian.com>
7672 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
7674 2003-07-14 Martin Baulig <martin@ximian.com>
7676 * codegen.cs (EmitContext.InFixedInitializer): New public field.
7678 * ecore.cs (IVariable.VerifyFixed): New interface method.
7680 * expression.cs (Unary.ResolveOperator): When resolving the `&'
7681 operator, check whether the variable is actually fixed. Fixes bug
7682 #36055. Set a variable definitely assigned when taking its
7683 address as required by the spec.
7685 * statement.cs (LocalInfo.IsFixed): New field.
7686 (LocalInfo.MakePinned): Set `IsFixed' to true.
7688 2003-07-14 Ravi Pratap M <ravi@ximian.com>
7690 * attribute.cs (Attribute.Resolve): While doing a Member lookup
7691 for .ctors, ensure that we only ask for members declared in the
7692 attribute type (BindingFlags.DeclaredOnly).
7696 * expression.cs (Error_WrongNumArguments): Report error 1501
7697 correctly the way CSC does.
7699 2003-07-13 Martin Baulig <martin@ximian.com>
7701 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
7702 lookup on the fully qualified name, to make things like "X.X" work
7703 where "X.X" is a fully qualified type name, but we also have a
7704 namespace "X" in the using list. Fixes #41975.
7706 2003-07-13 Martin Baulig <martin@ximian.com>
7708 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
7709 function. If we're a CompoundAssign, we need to create an embedded
7710 CompoundAssign, not an embedded Assign.
7711 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
7714 2003-07-13 Martin Baulig <martin@ximian.com>
7716 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
7717 work to fix bug #46088.
7719 2003-07-13 Ravi Pratap <ravi@ximian.com>
7721 * class.cs (Operator.Emit): Do not emit attributes here - it is
7722 taken care of by the Method class that we delegate too. This takes
7725 2003-07-10 Martin Baulig <martin@ximian.com>
7727 * expression.cs (TypeOfVoid): New class.
7728 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
7730 2003-07-10 Martin Baulig <martin@ximian.com>
7732 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
7735 2003-07-10 Martin Baulig <martin@ximian.com>
7737 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
7738 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
7740 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
7742 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
7744 2003-07-10 Martin Baulig <martin@ximian.com>
7746 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
7747 of decimal. Fixes #42850.
7749 NOTE: I also fixed the created byte blob, but this doesn't work on
7750 the MS runtime and csc never produces any byte blobs for decimal
7753 2003-07-10 Martin Baulig <martin@ximian.com>
7755 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
7756 structs; fixes #32068.
7757 (Block.AddChildVariableNames): Fixed #44302.
7759 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7761 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
7763 2003-07-07 Miguel de Icaza <miguel@ximian.com>
7765 * attribute.cs: And this test is onger needed.
7767 2003-07-08 Martin Baulig <martin@ximian.com>
7769 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
7770 inaccessible types. Fixes #36313.
7772 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
7774 * namespace.cs (NamespaceEntry): Create implicit entries for all
7775 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
7776 implicit entries for N1.N2 and N1.
7778 2003-07-08 Martin Baulig <martin@ximian.com>
7780 Rewrote the handling of namespaces to fix a lot of the issues
7781 wrt. `using' aliases etc.
7783 * namespace.cs (Namespace): Splitted this class into a
7784 per-assembly `Namespace' and a per-file `NamespaceEntry'.
7786 * typemanager.cs (TypeManager.IsNamespace): Removed.
7787 (TypeManager.ComputeNamespaces): Only compute namespaces from
7788 loaded assemblies here, not the namespaces from the assembly we're
7789 currently compiling.
7791 2003-07-08 Martin Baulig <martin@ximian.com>
7793 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
7795 2003-07-07 Miguel de Icaza <miguel@ximian.com>
7797 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
7800 I thought about the memory savings here, but LookupTypeReflection
7801 is used under already very constrained scenarios. Compiling
7802 corlib or mcs only exposes one hit, so it would not really reduce
7803 any memory consumption.
7805 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7807 * typemanager.cs: fixes bug #45889 by only adding public types from
7808 other assemblies to the list of known types.
7810 2003-07-07 Miguel de Icaza <miguel@ximian.com>
7812 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
7813 on the type we resolved.
7815 2003-07-05 Martin Baulig <martin@ximian.com>
7817 * pending.cs (PendingImplementation.ParentImplements): Don't
7818 create the proxy if the parent is abstract.
7820 * class.cs (TypeContainer.DefineIndexers): Process explicit
7821 interface implementations first. Fixes #37714.
7823 2003-07-04 Miguel de Icaza <miguel@ximian.com>
7825 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
7826 defined recursively; but since we modify the input parameters
7827 (left is set to `this' temporarily), we reset this value if the
7828 left_is_explicit is false, which gives the original semantics to
7831 * literal.cs (NullPointer): new class used to represent a null
7832 literal in a pointer context.
7834 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
7835 type is a pointer, use a NullPointer object instead of a
7836 NullLiteral. Closes 43687
7838 (ExplicitConversion): Convert pointer values using
7839 the conv opcode to the proper type.
7841 * ecore.cs (New): change ValueTypeVariable property into a method,
7842 that returns whether the valuetype is suitable for being used.
7844 * expression.cs (Binary.DoNumericPromotions): Only return if we
7845 the int constant was a valid uint, and we can return both left and
7846 right as uints. If not, we continue processing, to trigger the
7847 type conversion. This fixes 39018.
7849 * statement.cs (Block.EmitMeta): During constant resolution, set
7850 the CurrentBlock property on the emitcontext, so that we resolve
7851 constants propertly.
7853 2003-07-02 Martin Baulig <martin@ximian.com>
7855 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
7856 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
7858 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
7859 than emitting it here.
7861 * statement.cs: Fixed some more flow analysis bugs.
7863 2003-07-02 Martin Baulig <martin@ximian.com>
7865 * class.cs (MethodData.Define): When implementing interface
7866 methods, set Final unless we're Virtual.
7868 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
7869 check work for interface methods.
7871 2003-07-01 Martin Baulig <martin@ximian.com>
7873 * ecore.cs (EmitContext.This): Replaced this property with a
7874 GetThis() method which takes a Location argument. This ensures
7875 that we get the correct error location for a CS0188.
7877 2003-07-01 Miguel de Icaza <miguel@ximian.com>
7879 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
7880 ImplicitStandardConversion.
7882 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
7884 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
7886 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
7889 2003-06-30 Miguel de Icaza <miguel@ximian.com>
7891 * class.cs (Constructor.Define): Turn off initlocals for unsafe
7894 (MethodData.Define): Turn off initlocals for unsafe methods.
7896 2003-06-29 Miguel de Icaza <miguel@ximian.com>
7898 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
7899 complete; Fixes #37521.
7901 * delegate.cs: Use Modifiers.TypeAttr to compute the
7902 TypeAttributes, instead of rolling our own. This makes the flags
7903 correct for the delegates.
7905 2003-06-28 Miguel de Icaza <miguel@ximian.com>
7907 * class.cs (Constructor.Define): Set the private flag for static
7908 constructors as well.
7910 * cs-parser.jay (statement_expression): Set the return value to
7911 null, to avoid a crash when we catch an error.
7913 2003-06-24 Miguel de Icaza <miguel@ximian.com>
7915 * cs-parser.jay: Applied patch from Jackson that adds support for
7916 extern and unsafe modifiers to destructor declarations.
7918 * expression.cs: Report error 21 if the user is trying to index a
7921 * driver.cs: Add an error message, suggested by the bug report.
7923 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
7924 if we do not have a ": this ()" constructor initializer. Fixes 45149
7926 2003-06-14 Miguel de Icaza <miguel@ximian.com>
7928 * namespace.cs: Add some information to reduce FAQs.
7930 2003-06-13 Miguel de Icaza <miguel@ximian.com>
7932 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
7933 underlying enumeration types. Fixes #43915.
7935 * expression.cs: Treat ushort/short as legal values to be used in
7938 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
7940 * delegate.cs: transfer custom attributes for paramenters from
7941 the delegate declaration to Invoke and BeginInvoke.
7943 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
7945 * attribute.cs: handle custom marshalers and emit marshal info
7948 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
7950 * makefile.gnu: Added anonymous.cs to the compiler sources.
7952 2003-05-28 Miguel de Icaza <miguel@ximian.com>
7954 * iterators.cs: Change the name of the proxy class to include two
7957 * cs-parser.jay: Update grammar to include anonymous methods.
7959 * anonymous.cs: new file.
7961 2003-05-27 Miguel de Icaza <miguel@ximian.com>
7963 * class.cs (Field.Define): Add missing test for pointers and
7966 2003-05-27 Ravi Pratap <ravi@ximian.com>
7968 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
7969 we use the stobj opcode.
7971 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
7972 since it wasn't the correct fix.
7974 It still is puzzling that we are required to use stobj for IntPtr
7975 which seems to be a ValueType.
7977 2003-05-26 Miguel de Icaza <miguel@ximian.com>
7979 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
7980 during regular simple name resolution. Now, the trick is that
7981 instead of returning for processing the simplename, we do a
7982 TypeManager.LookupType (ie, a rooted lookup as opposed to a
7983 contextual lookup type). If a match is found, return that, if
7984 not, return for further composition.
7986 This fixes long-standing 30485.
7988 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
7989 using the address to initialize an object, do an Stobj instead of
7990 using the regular Stelem.
7992 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
7993 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
7994 Because if we are a BaseIndexerAccess that value will be true.
7997 * statement.cs (GotoCase.Resolve): Return after reporting an
7998 error, do not attempt to continue.
8000 * expression.cs (PointerArithmetic.Emit): If our operand is a
8001 long, convert our constants to match the operand before
8002 multiplying. Convert to I type before adding. Fixes 43670.
8004 2003-05-14 Ravi Pratap <ravi@ximian.com>
8006 * enum.cs (ImplicitConversionExists) : Rename to
8007 ImplicitEnumConversionExists to remove ambiguity.
8009 * ecore.cs (NullCast): New type of cast expression class which
8010 basically is very similar to EmptyCast with the difference being
8011 it still is a constant since it is used only to cast a null to
8015 * convert.cs (ImplicitReferenceConversion): When casting a null
8016 literal, we return a NullCast.
8018 * literal.cs (NullLiteralTyped): Remove - I don't see why this
8019 should be around anymore.
8021 The renaming (reported was slightly wrong). Corrections:
8023 ConvertImplicitStandard -> ImplicitConversionStandard
8024 ConvertExplicitStandard -> ExplicitConversionStandard
8026 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
8027 before passing them in !
8029 * convert.cs (ImplicitConversionStandard): When comparing for
8030 equal expr and target types, ensure that expr is not a
8033 In general, we must not be checking (expr_type ==
8034 target_type) in the top level conversion methods
8035 (ImplicitConversion, ExplicitConversion etc). This checking is
8036 done in the methods that they delegate to.
8038 2003-05-20 Miguel de Icaza <miguel@ximian.com>
8040 * convert.cs: Move Error_CannotConvertType,
8041 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
8042 ImplicitNumericConversion, ImplicitConversionExists,
8043 ImplicitUserConversionExists, StandardConversionExists,
8044 FindMostEncompassedType, FindMostSpecificSource,
8045 FindMostSpecificTarget, ImplicitUserConversion,
8046 ExplicitUserConversion, GetConversionOperators,
8047 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
8048 TryImplicitIntConversion, Error_CannotConvertImplicit,
8049 ConvertImplicitRequired, ConvertNumericExplicit,
8050 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
8051 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
8054 Perform the following renames:
8056 StandardConversionExists -> ImplicitStandardConversionExists
8057 ConvertImplicit -> ImplicitConversion
8058 ConvertImplicitStandard -> ImplicitStandardConversion
8059 TryImplicitIntConversion -> ImplicitIntConversion
8060 ConvertImplicitRequired -> ImplicitConversionRequired
8061 ConvertNumericExplicit -> ExplicitNumericConversion
8062 ConvertReferenceExplicit -> ExplicitReferenceConversion
8063 ConvertExplicit -> ExplicitConversion
8064 ConvertExplicitStandard -> ExplicitStandardConversion
8066 2003-05-19 Martin Baulig <martin@ximian.com>
8068 * statement.cs (TypeInfo.StructInfo): Made this type protected.
8069 (TypeInfo): Added support for structs having structs as fields.
8071 * ecore.cs (FieldExpr): Implement IVariable.
8072 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
8073 VariableInfo for the field.
8075 2003-05-18 Martin Baulig <martin@ximian.com>
8077 * expression.cs (This.DoResolve): Report a CS0027 if we're
8078 emitting a field initializer.
8080 2003-05-18 Martin Baulig <martin@ximian.com>
8082 * expression.cs (This.ResolveBase): New public function.
8083 (This.DoResolve): Check for CS0188.
8085 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
8088 * ecore.cs (MethodGroupExpr.DoResolve): Set the
8089 `instance_expression' to null if we don't have any non-static
8092 2003-05-18 Martin Baulig <martin@ximian.com>
8094 Reworked the way how local variables and parameters are handled by
8095 the flow analysis code.
8097 * statement.cs (TypeInfo, VariableMap): New public classes.
8098 (VariableInfo): New public class. This is now responsible for
8099 checking whether a variable has been assigned. It is used for
8100 parameters and local variables.
8101 (Block.EmitMeta): Take the InternalParameters as argument; compute
8102 the layout of the flow vectors here.
8103 (Block.LocalMap, Block.ParameterMap): New public properties.
8104 (FlowBranching): The .ctor doesn't get the InternalParameters
8105 anymore since Block.EmitMeta() now computes the layout of the flow
8107 (MyStructInfo): This class is now known as `StructInfo' and nested
8108 in `TypeInfo'; we don't access this directly anymore.
8110 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
8111 property and removed IsAssigned(), IsFieldAssigned(),
8112 SetAssigned() and SetFieldAssigned(); we now call them on the
8113 VariableInfo so we don't need to duplicate this code everywhere.
8115 * expression.cs (ParameterReference): Added `Block block' argument
8117 (LocalVariableReference, ParameterReference, This): The new
8118 VariableInfo class is now responsible for all the definite
8121 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
8122 IsParameterAssigned, SetParameterAssigned): Removed.
8124 2003-05-18 Martin Baulig <martin@ximian.com>
8126 * typemanager.cs (InitCoreTypes): Try calling
8127 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
8128 the 3-args-version. Corlib now also needs our `void_type'.
8129 (GetMethod): Added overloaded version which takes an optional
8130 `bool report_errors' to allow lookups of optional methods.
8132 2003-05-12 Martin Baulig <martin@ximian.com>
8134 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
8135 only used for locals and not for parameters.
8137 2003-05-12 Miguel de Icaza <miguel@ximian.com>
8139 * support.cs (InternalParameters.ParameterType): Return the
8140 ExternalType of the parameter.
8142 * parameter.cs (Parameter.ExternalType): drop the two arguments,
8145 2003-05-11 Miguel de Icaza <miguel@ximian.com>
8147 * class.cs (MethodData.Define): Do not set the `newslot' on
8148 interface members, if they are also flagged as "override".
8150 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
8151 better code for ++i and i++. This only works for static fields
8152 and local variables.
8154 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
8155 want to pull the DeclSpace out of the builder_to_declspace instead
8156 of the TypeBuilder (like in TypeContainer.FindMembers).
8158 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
8159 instead of LookupTypeContainer. Fixes the crash on .NET for
8160 looking up interface members.
8162 * const.cs: Create our own emit context during the Definition
8163 stage, so that constants are evaluated in the proper context, when
8164 a recursive definition happens.
8166 2003-05-11 Martin Baulig <martin@ximian.com>
8168 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
8169 new block for a switch section.
8170 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
8171 the adding/lookup in the switch block. Fixes #39828.
8173 2003-05-09 Miguel de Icaza <miguel@ximian.com>
8175 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
8176 functionality: I needed to convert the data after I had performed
8177 the add/sub operation into the operands type size.
8179 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
8180 pass the type for the box operation, otherwise the resulting
8181 object would have been of type object.
8183 (BoxedCast): Add constructor to specify the type to box as.
8185 2003-05-07 Miguel de Icaza <miguel@ximian.com>
8187 * iterators.cs: I was reusing the `count' variable inadvertently,
8188 take steps to not allow this to happen.
8190 2003-05-06 Miguel de Icaza <miguel@ximian.com>
8192 * attribute.cs (Attribute.Resolve): Params attributes are encoded
8193 by creating an array at the point where the params starts and
8194 putting all those arguments there, then adjusting the size of the
8197 2003-05-05 Miguel de Icaza <miguel@ximian.com>
8199 * expression.cs (New.AddressOf): Implement interface
8200 IMemoryLocation. This is used when the `new' operator is used in
8201 the context of an invocation to a method on a value type.
8203 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
8206 * namespace.cs: Also check the using aliases here.
8208 * driver.cs: Move the test for using validity after the types have
8209 been entered, so we do a single pass that also includes the using
8212 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
8213 in the regular case. CreateSiblingForFinally is doing extra
8216 * attribute.cs (GetAttributeArgumentExpression): Store the result
8217 on an out value, and use the return value to indicate failure
8218 instead of using null (which is a valid return for Constant.GetValue).
8220 * statement.cs: Perform the analysis flow for the increment
8221 portion after the statement, because this will be the real flow of
8222 execution. Fixes #42385
8224 * codegen.cs (EmitContext.EmitArgument,
8225 EmitContext.EmitStoreArgument): New helper functions when the
8226 RemapToProxy flag is set.
8228 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
8231 Add support for remapping parameters.
8233 * iterators.cs: Propagate parameter values; Store parameter
8234 values in the proxy classes.
8236 2003-05-04 Miguel de Icaza <miguel@ximian.com>
8238 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
8239 need a proxy reference; I do not know what I was thinking
8241 * cs-parser.jay (constructor_initializer): catch another error,
8242 and display nice message.
8244 (field_declaration): catch void field declaration
8245 to flag a better error.
8247 * class.cs (MemberBase.CheckBase): Report an error instead of a
8248 warning if a new protected member is declared in a struct.
8249 (Field.Define): catch the error of readonly/volatile.
8251 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
8253 (FieldExpr.AddressOf): ditto. Catch error where the address of a
8254 volatile variable is taken
8256 2003-05-02 Miguel de Icaza <miguel@ximian.com>
8258 * statement.cs (Fixed.Resolve): Report an error if we are not in
8261 2003-05-01 Miguel de Icaza <miguel@ximian.com>
8263 * typemanager.cs: reuse the code that handles type clashes for
8264 delegates and enumerations.
8266 * class.cs (Report28): Always report.
8268 * expression.cs (EncodeAsAttribute): Allow nulls here.
8270 2003-04-28 Miguel de Icaza <miguel@ximian.com>
8272 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
8273 the functionality for testing whether an expression is valid for
8274 an attribute here. Also handle the case of arrays of elements
8277 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
8278 encoding a linear array into an array of objects that are suitable
8279 to be passed to an CustomAttributeBuilder.
8281 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
8283 * ecore.cs: (FieldExpr): Handle field remapping here.
8285 * iteratators.cs: Pass the instance variable (if the method is an
8286 instance method) to the constructors, so we can access the field
8287 variables on the class.
8289 TODO: Test this with structs. I think the THIS variable on
8290 structs might have to be a pointer, and not a refenrece
8292 2003-04-27 Miguel de Icaza <miguel@ximian.com>
8294 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
8295 local variables to fields in a proxy class.
8297 * iterators.cs (PopulateProxy): Rename our internal fields to
8299 Create a <THIS> field if we are an instance method, so we can
8300 reference our parent container variables.
8301 (MapVariable): Called back from the EmitContext code to enter a
8302 new variable to field mapping into the proxy class (we just create
8306 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
8307 for using the remapped locals to fields.
8309 I placed the code here, because that gives the same semantics to
8310 local variables, and only changes the Emit code.
8312 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
8313 statements inside iterators.
8314 (VariableInfo): Add a FieldBuilder for the cases when we are
8315 remapping local variables to fields in a proxy class
8317 * ecore.cs (SimpleNameResolve): Avoid testing two times for
8318 current_block != null.
8320 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
8321 not cope with strings, as it has been moved to the
8322 TableSwitchEmit. Fixed bug in switch generation.
8324 * expression.cs (New.DoResolve): Provide more context for the user
8325 when reporting an error.
8327 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
8330 * expression.cs (MemberAccess.DoResolve): When we get a type back,
8331 check the permissions for it. Note than in a type-resolution
8332 context the check was already present in DeclSpace.ResolveType,
8333 but was missing from the MemberAccess.
8335 (ArrayCreation.CheckIndices): warn if the user has
8336 more nested levels of expressions, but there are no more
8337 dimensions specified. Avoids crash on bug 41906.
8339 2003-04-26 Miguel de Icaza <miguel@ximian.com>
8341 * statement.cs (Block): replace Implicit bool, for a generic
8343 New flag: `Unchecked'. This is used during the EmitMeta phase
8344 (which is out-of-line with the regular Resolve/Emit process for a
8345 statement, as this is done ahead of time, but still gets a chance
8346 to call constant resolve).
8348 (Block.Flags): new enum for adding a new flag.
8350 (Block.EmitMeta): track the state of unchecked.
8352 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
8353 to enable constant resolution to work there as well.
8355 2003-04-22 Miguel de Icaza <miguel@ximian.com>
8357 * typemanager.cs (ienumerable_type): Also look up
8358 System.Collections.IEnumerable.
8360 2003-04-21 Miguel de Icaza <miguel@ximian.com>
8362 TODO: Test more than one conditional per method.
8364 * class.cs (Indexer.Define): Report the location where the user is
8365 referencing the unsupported feature.
8367 (MethodData): Overload the use of `conditionals' to
8368 minimize the creation of needless ArrayLists. This saves roughly
8369 212kb on my machine.
8371 (Method): Implement the new IIteratorContainer interface.
8372 (Method.SetYields): Implement the method by setting the ModFlags
8373 to contain METHOD_YIELDS.
8375 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
8376 which just got set to null.
8378 * iterators.cs: New file.
8380 (Yield, YieldBreak): New statements.
8382 * statement.cs (Return.Resolve): Flag an error if we are used in
8385 * codegen.cs (InIterator): New flag set if the code is being
8386 compiled in an iterator method.
8388 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
8389 internal modifier, and we just use it to avoid adding extra
8390 fields, as this is seldom used.
8392 * cs-parser.jay: Add yield_statement (yield and yield break).
8394 * driver.cs: New flag -v2 to turn on version 2 features.
8396 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
8397 hashtable when v2 is enabled.
8399 2003-04-20 Miguel de Icaza <miguel@ximian.com>
8401 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
8402 there is already a namespace defined with this name.
8404 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
8405 people upgraded their corlibs.
8407 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
8408 always use fully qualified types, no need to use the compiler
8411 (TypeManager.IsNamespace): Use binarysearch.
8413 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
8414 AddDelegate): I did not quite use the new IsValid API properly: I
8415 have to pass the short-name and the fullname. I was passing only
8416 the basename instead of the fullname sometimes.
8418 (TypeContainer.DefineType): call NamespaceClash.
8420 * interface.cs (Interface.DefineType): use NamespaceClash before
8423 * delegate.cs (Delegate.DefineType): use NamespaceClash before
8426 * enum.cs: (Enum.DefineType): use NamespaceClash before
8429 * typemanager.cs (: 3-line patch that gives us some tasty 11%
8430 speed increase. First, use the negative_hits cache when we get a
8431 negative. Second, add the type with its full original name
8432 instead of the new . and + encoded name (reflection uses + to
8433 separate type from a nested type). Use LookupTypeReflection
8434 directly which bypasses the type->name hashtable (that we already
8435 know does not contain the type.
8437 * decl.cs (DeclSpace.ResolveTypeExpr): track the
8438 location/container type.
8440 * driver.cs: When passing utf8, use directly the UTF8Encoding.
8442 2003-04-19 Miguel de Icaza <miguel@ximian.com>
8444 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
8446 * delegate.cs (NewDelegate.Resolve): Test whether an instance
8447 method is being referenced in the method group from a static
8448 context, and report error 120 if so.
8450 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
8453 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
8454 is created, we create the A namespace).
8456 * cs-parser.jay: A namespace also introduces a DeclarationFound.
8459 2003-04-18 Miguel de Icaza <miguel@ximian.com>
8461 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
8462 invocation to ModuleBuilder.GetType with the same values will
8463 return a new type instance, so we need to cache its return
8466 * expression.cs (Binary.ResolveOperator): Only allow the compare
8467 operators on enums if they are of the same type.
8469 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
8470 types of ValueType on their own case. Before we were giving them
8471 the same treatment as objects.
8473 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
8474 fullname. Short name is used to compare against container name.
8475 Fullname is used to check against defined namespace names.
8477 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
8478 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
8480 (Method.CheckBase): Call parent.
8481 (MemberBase.CheckBase): Check for protected members on sealed
8483 (PropertyBase.CheckBase): Call parent.
8484 (Field.Define): Call parent.
8486 * report.cs: Negative error codes are now mapped to 8000 - code,
8487 so that the display is render more nicely.
8489 * typemanager.cs: Do not use try/catch, instead report a regular
8492 (GetPointerType, GetReferenceType): These methods provide
8493 mechanisms to obtain the T* and T& from a T. We had the code
8494 previously scattered around the code base, and it also used
8495 TypeManager.LookupType that would go through plenty of caches.
8496 This one goes directly to the type source.
8498 In some places we did the Type.GetType followed by
8499 ModuleBuilder.GetType, but not in others, so this unifies the
8502 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
8503 statements now that we have namespace information.
8505 * typemanager.cs (IsNamespace): New method, returns whether the
8506 string presented is a namespace or not.
8508 (ComputeNamespaces): New public entry point, computes the list of
8509 available namespaces, using the GetNamespaces API call in Mono, or
8510 the slower version in MS.NET.
8512 Now before we start the semantic analysis phase, we have a
8513 complete list of namespaces including everything that the user has
8516 Deleted old code to cache namespaces in .nsc files.
8518 2003-04-17 Miguel de Icaza <miguel@ximian.com>
8520 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
8521 class/struct location definition Location for the implicit
8522 constructor location.
8524 (Operator.Define): Use the location of the operator for the
8525 implicit Method definition.
8527 (Constructor.Emit): use the constructor location for the implicit
8528 base initializer constructor.
8530 * ecore.cs: Remove ITypeExpression. This interface is now gone,
8531 and the Expression class now contains two new methods:
8533 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
8534 isolate type lookup from the rest of the resolution process.
8536 Since we use Expressions to hold type definitions due to the way
8537 we parse the input we have historically overloaded Resolve to
8538 perform the Type lookups if a special flag is passed. Now this is
8539 eliminated and two methods take their place.
8541 The differences in the two methods between xStep and xTerminal is
8542 that xStep is involved in our current lookup system that uses
8543 SimpleNames to compose a name, while xTerminal is used just to
8544 catch the case where the simplename lookup failed.
8546 2003-04-16 Miguel de Icaza <miguel@ximian.com>
8548 * expression.cs (ResolveMemberAccess): Remove redundant code.
8549 TypeExpr expressions are always born fully resolved.
8551 * interface.cs (PopulateMethod): Do not lookup the types twice.
8552 We were doing it once during SemanticAnalysis and once during
8555 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
8556 in local variable type definitions, were being returned as a
8557 SimpleName (we decomposed everything into a string), that is
8558 because primary_expression was being used instead of a type in the
8559 grammar (reduce/reduce conflicts).
8561 The part that was wrong is that we converted the expression into a
8562 string (an oversimplification in one hand, compounded with primary
8563 expressions doing string concatenation).
8569 Would return "A.B.C[]" as a SimpleName. This stopped things like
8570 using clauses from working on this particular context. And a type
8571 was being matched directly against "A.B.C[]".
8573 We now use the correct approach, and allow for ComposedCast to be
8574 part of the unary expression. So the "A.B.C []" become a composed
8575 cast of "A.B.C" (as a nested group of MemberAccess with a
8576 SimpleName at the end) plus the rank composition "[]".
8580 2003-04-10 Miguel de Icaza <miguel@ximian.com>
8582 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
8583 for the access level checking.
8585 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
8586 `TypeContainer container', because I kept getting confused when I
8587 was debugging this code.
8589 * expression.cs (Indexers): Instead of tracking getters/setters,
8590 we now track them in parallel. We create one arraylist less, but
8591 most importantly it is possible now for the LValue code to find a
8592 matching get for a set.
8594 (IndexerAccess.DoResolveLValue): Update the code.
8595 GetIndexersForType has been modified already to extract all the
8596 indexers from a type. The code assumed it did not.
8598 Also make the code set the correct return type for the indexer.
8599 This was fixed a long time ago for properties, but was missing for
8600 indexers. It used to be void_type.
8602 (Binary.Emit): Test first for doubles instead of
8603 floats, as they are more common.
8605 (Binary.EmitBranchable): Use the .un version of the branch opcodes
8606 when dealing with floats and the <=, >= operators. This fixes bug
8609 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
8610 to load the array value by emitting a load on the foreach variable
8611 type. This was incorrect.
8613 We now emit the code to load an element using the the array
8614 variable type, and then we emit the conversion operator.
8618 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
8620 * attribute.cs: Avoid allocation of ArrayLists in the common case.
8622 2003-04-09 Miguel de Icaza <miguel@ximian.com>
8624 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
8625 test for protection before we test for signatures.
8627 (MethodSignature.ToString): implement.
8629 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
8630 to the case where we reduced into a LongConstant.
8632 * decl.cs (CheckAccessLevel): If the type is an array, we can not
8633 depend on whether the information is acurrate, because the
8634 Microsoft runtime will always claim that the array type is public,
8635 regardless of the real state.
8637 If the type is a pointer, another problem happens: the type is
8638 reported as non-public in Microsoft.
8640 In both cases we have to call CheckAccessLevel recursively with
8641 the underlying type as the argument to be tested.
8643 2003-04-08 Miguel de Icaza <miguel@ximian.com>
8645 * assign.cs (Assign.Emit): If we are dealing with a compound
8646 assignment expression, we should use the code path that stores the
8647 intermediate result in a temporary value. This fixes #40903.
8649 *expression.cs (Indirection.ToString): Provide ToString method for
8652 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
8654 * class.cs: Null out fields holding references to Block objects so
8655 they can be garbage collected.
8657 * expression.cs (OverloadResolve): Remove unused local.
8659 2003-04-07 Martin Baulig <martin@ximian.com>
8661 * codegen.cs (EmitContext.CurrentFile): New public field.
8662 (EmitContext.Mark): Use the CurrentFile to check whether the
8663 location is in the correct file.
8664 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
8666 2003-04-07 Martin Baulig <martin@ximian.com>
8668 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
8670 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
8671 location. [FIXME: The location argument which gets passed to this
8672 method is sometimes wrong!]
8674 2003-04-07 Nick Drochak <ndrochak@gol.com>
8676 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
8678 2003-04-07 Miguel de Icaza <miguel@ximian.com>
8680 * expression.cs (Indirection.EmitAssign): We were using the
8681 temporary, but returning immediately instead of continuing the
8684 2003-04-06 Martin Baulig <martin@ximian.com>
8686 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
8687 if it's a nested child, but also deriving from the outer class.
8690 * typemanager.cs (IsNestedChildOf): Make this work if it's a
8691 nested child, but also deriving from the outer class. See
8693 (FilterWithClosure): We may access private members of the outer
8694 class if we're a nested child and deriving from the outer class.
8695 (RealMemberLookup): Only set `closure_private_ok' if the
8696 `original_bf' contained BindingFlags.NonPublic.
8698 2003-04-05 Martin Baulig <martin@ximian.com>
8700 * expression.cs (SizeOf.DoResolve): Use ResolveTypeExpr, so we can
8701 probe if its a type parameter, and if so, flag an error.
8703 * decl.cs: Move here the SetParameterInfo code from class.cs.
8704 Handle IsGeneric here.
8706 Handle a variety of errors in the parameter info definition.
8708 * ecore.cs (SimpleName.DoResolveType): Handle look ups for generic
8709 type parameters here.
8711 * cs-parser.jay (class_declaration): report errors for parameters
8714 2003-01-21 Miguel de Icaza <miguel@ximian.com>
8716 * generic.cs: New file, contains support code for generics.
8718 * cs-parser.jay: Remove OP_SHIFT_LEFT, OP_SHIFT_RIGHT,
8719 OP_SHIFT_LEFT_ASSIGN, OP_SHIFT_RIGHT_ASSIGN.
8721 Update parser for the above removals.
8723 * cs-tokenizer.cs: Do not handle <<= or >>= specially. This is
8724 now taken care of in the parser.
8726 2003-04-02 Miguel de Icaza <miguel@ximian.com>
8728 * class.cs (Event.Define): Do not allow abstract events to have
8731 2003-04-01 Miguel de Icaza <miguel@ximian.com>
8733 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
8734 block in event declarations.
8736 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
8737 value type, get its address.
8739 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
8740 leaving a class on the stack instead of a boolean value (int
8741 0/1). Change the code so we compare against null, and then the
8742 result against zero.
8744 * class.cs (TypeContainer.GetClassBases): We were checking for the
8745 parent class being sealed too late.
8747 * expression.cs (Binary.Emit): For <= and >= when dealing with
8748 floating point values, use cgt.un and clt.un instead of cgt and
8751 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
8753 * statement.cs: Apply the same optimization as MS: skip the
8754 GetEnumerator returning an IEnumerator, and use the one returning a
8755 CharEnumerator instead. This allows us to avoid the try-finally block
8758 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
8760 * cs-parser.jay: Attributes cannot be applied to
8761 namespaces. Fixes #40473
8763 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8766 (Add*): check if the name is valid using the full name for constants,
8767 fields, properties and events.
8769 2003-03-28 Miguel de Icaza <miguel@ximian.com>
8771 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
8772 char constants to be part of the enumeration.
8774 * expression.cs (Conditional.DoResolve): Add support for operator
8775 true. Implements the missing functionality from 14.12
8777 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
8778 operator true/false as required by the spec.
8780 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
8781 implicit conversion to boolean.
8783 * statement.cs (Statement.ResolveBoolean): A boolean expression is
8784 also one where the type implements `operator true'.
8786 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
8787 get an expression that will invoke operator true based on an
8790 (GetConversionOperators): Removed the hack that called op_True
8793 (Expression.ResolveBoolean): Move this from Statement.
8795 2003-03-17 Miguel de Icaza <miguel@ximian.com>
8797 * ecore.cs (FieldExpr): do not allow initialization of initonly
8798 fields on derived classes
8800 2003-03-13 Martin Baulig <martin@ximian.com>
8802 * statement.cs (Block.Emit): Call ig.BeginScope() and
8803 ig.EndScope() when compiling with debugging info; call
8804 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
8806 2003-03-08 Miguel de Icaza <miguel@ximian.com>
8808 * expression.cs (Indexers): Do not construct immediately, allow
8809 for new members to be appended as we go. Fixes 38143
8811 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8813 * expression.cs: save/restore context when resolving an unchecked
8816 2003-03-05 Miguel de Icaza <miguel@ximian.com>
8818 * cfold.cs: Catch division by zero in modulus operator during
8821 2003-03-03 Miguel de Icaza <miguel@ximian.com>
8823 * interface.cs (Interface.DefineMembers): Avoid defining members
8826 2003-02-27 Miguel de Icaza <miguel@ximian.com>
8828 * driver.cs: handle the +/- options for -noconfig
8830 * statement.cs (Unckeched.Resolve): Also track the state of
8831 unchecked in the Resolve phase.
8833 2003-02-27 Martin Baulig <martin@ximian.com>
8835 * ecore.cs (Expression.MemberLookup): Don't create a
8836 MethodGroupExpr for something which is not a method. Fixes #38291.
8838 2003-02-25 Miguel de Icaza <miguel@ximian.com>
8840 * class.cs (MemberBase.CheckParameters): Also check that the type
8841 is unmanaged if it is a pointer.
8843 * expression.cs (SizeOf.Resolve): Add location information.
8845 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
8846 a managed type is declared.
8848 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
8849 parameter modifiers as well. Fixes bug 38606
8851 * class.cs: Very sad. Am backing out the speed up changes
8852 introduced by the ArrayList -> Array in the TypeContainer, as they
8853 were not actually that much faster, and introduced a bug (no error
8854 reports on duplicated methods).
8856 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
8857 source first, this will guarantee that we have a valid expression
8858 before calling in lower levels functions that will require a
8859 resolved object. Then use this original_source in the
8860 target.ResolveLValue instead of the original source that was
8863 Another change. Use target.Resolve instead of LValueResolve.
8864 Although we are resolving for LValues, we will let the Assign code
8865 take care of that (it will be called again from Resolve). This
8866 basically allows code like this:
8868 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
8869 class Y { void A (X x) { x [0] += o; }
8871 The problem was that the indexer was trying to resolve for
8872 set_Item (idx, object o) and never finding one. The real set_Item
8873 was set_Item (idx, X). By delaying the process we get the right
8878 2003-02-23 Martin Baulig <martin@ximian.com>
8880 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
8881 while calling DoEmit ().
8883 * codegen.cs (EmitContext.Mark): Don't mark locations in other
8884 source files; if you use the #line directive inside a method, the
8885 compiler stops emitting line numbers for the debugger until it
8886 reaches the end of the method or another #line directive which
8887 restores the original file.
8889 2003-02-23 Martin Baulig <martin@ximian.com>
8891 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
8893 2003-02-23 Martin Baulig <martin@ximian.com>
8895 * statement.cs (Block.AddChildVariableNames): We need to call this
8896 recursively, not just for our immediate children.
8898 2003-02-23 Martin Baulig <martin@ximian.com>
8900 * class.cs (Event.Define): Always make the field private, like csc does.
8902 * typemanager.cs (TypeManager.RealMemberLookup): Make events
8903 actually work, fixes bug #37521.
8905 2003-02-23 Miguel de Icaza <miguel@ximian.com>
8907 * delegate.cs: When creating the various temporary "Parameters"
8908 classes, make sure that we call the ComputeAndDefineParameterTypes
8909 on those new parameters (just like we do with the formal ones), to
8910 allow them to be resolved in the context of the DeclSpace.
8912 This fixes the bug that Dick observed in Bugzilla #38530.
8914 2003-02-22 Miguel de Icaza <miguel@ximian.com>
8916 * expression.cs (ResolveMemberAccess): When resolving a constant,
8917 do not attempt to pull a constant if the value was not able to
8918 generate a valid constant.
8920 * const.cs (LookupConstantValue): Do not report more errors than required.
8922 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8924 * expression.cs: fixes bug #38328.
8926 2003-02-18 Miguel de Icaza <miguel@ximian.com>
8928 * class.cs: Changed all the various members that can be part of a
8929 class from being an ArrayList to be an Array of the right type.
8930 During the DefineType type_list, interface_list, delegate_list and
8931 enum_list are turned into types, interfaces, delegates and enums
8934 And during the member population, indexer_list, event_list,
8935 constant_list, field_list, instance_constructor_list, method_list,
8936 operator_list and property_list are turned into their real arrays.
8938 Although we could probably perform this operation earlier, for
8939 good error reporting we need to keep the lists and remove the
8940 lists for longer than required.
8942 This optimization was triggered by Paolo profiling the compiler
8943 speed on the output of `gen-sample-program.pl' perl script.
8945 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
8946 not crash in methods like MemberLookupFailed that use this field.
8948 This problem arises when the compiler fails to resolve a type
8949 during interface type definition for example.
8951 2003-02-18 Miguel de Icaza <miguel@ximian.com>
8953 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
8954 inherit from System.Object, so we have to stop at null, not only
8955 when reaching System.Object.
8957 2003-02-17 Miguel de Icaza <miguel@ximian.com>
8959 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
8960 DeclaredOnly because the parent indexer might have had a different
8961 name, but did not loop until the top of the hierarchy was reached.
8963 The problem this one fixes is 35492: when a class implemented an
8964 indexer from an interface, we were getting the interface method
8965 (which was abstract) and we were flagging an error (can not invoke
8968 This also keeps bug 33089 functioning, and test-148 functioning.
8970 * typemanager.cs (IsSpecialMethod): The correct way of figuring
8971 out if a method is special is to see if it is declared in a
8972 property or event, or whether it is one of the predefined operator
8973 names. This should fix correctly #36804.
8975 2003-02-15 Miguel de Icaza <miguel@ximian.com>
8977 The goal here is to remove the dependency on EmptyCast.Peel ().
8978 Killing it completely.
8980 The problem is that currently in a number of places where
8981 constants are expected, we have to "probe" for an EmptyCast, and
8982 Peel, which is not the correct thing to do, as this will be
8983 repetitive and will likely lead to errors.
8985 The idea is to remove any EmptyCasts that are used in casts that
8986 can be reduced to constants, so we only have to cope with
8989 This bug hunt was triggered by Bug 37363 and the desire to remove
8990 the duplicate pattern where we were "peeling" emptycasts to check
8991 whether they were constants. Now constants will always be
8994 * ecore.cs: Use an enumconstant here instead of wrapping with
8997 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
8998 throwing me off. By handling this we can get rid of a few hacks.
9000 * statement.cs (Switch): Removed Peel() code.
9002 2003-02-14 Miguel de Icaza <miguel@ximian.com>
9004 * class.cs: Location information for error 508
9006 * expression.cs (New.DoResolve): Add a guard against double
9007 resolution of an expression.
9009 The New DoResolve might be called twice when initializing field
9010 expressions (see EmitFieldInitializers, the call to
9011 GetInitializerExpression will perform a resolve on the expression,
9012 and later the assign will trigger another resolution
9014 This leads to bugs (#37014)
9016 * delegate.cs: The signature for EndInvoke should contain any ref
9017 or out parameters as well. We were not doing this in the past.
9019 * class.cs (Field.Define): Do not overwrite the type definition
9020 inside the `volatile' group. Turns out that volatile enumerations
9021 were changing the type here to perform a validity test, which
9024 2003-02-12 Miguel de Icaza <miguel@ximian.com>
9026 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
9027 and structs, we do not want to load the instance variable
9029 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
9030 enum_type has to be handled like an object reference (implicit
9031 conversions exists from this to object), but the regular IsClass
9032 and IsValueType tests will never return true for this one.
9034 Also we use TypeManager.IsValueType instead of type.IsValueType,
9035 just for consistency with the rest of the code (this is only
9036 needed if we ever use the construct exposed by test-180.cs inside
9037 corlib, which we dont today).
9039 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
9041 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
9044 2003-02-09 Martin Baulig <martin@ximian.com>
9046 * namespace.cs (Namespace..ctor): Added SourceFile argument.
9047 (Namespace.DefineNamespaces): New static public method; this is
9048 called when we're compiling with debugging to add all namespaces
9051 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
9052 pass it to the Namespace's .ctor.
9054 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
9055 and MethodBase arguments; pass the namespace ID to the symwriter;
9056 pass the MethodBase instead of the token to the symwriter.
9057 (SymbolWriter.DefineNamespace): New method to add a namespace to
9060 2003-02-09 Martin Baulig <martin@ximian.com>
9062 * symbolwriter.cs: New file. This is a wrapper around
9063 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
9064 methods here in near future.
9066 2003-02-09 Martin Baulig <martin@ximian.com>
9068 * codegen.cs (EmitContext.Mark): Just pass the arguments to
9069 ILGenerator.MarkSequencePoint() which are actually used by the
9072 2003-02-09 Martin Baulig <martin@ximian.com>
9074 * location.cs (SourceFile): New public sealed class. This
9075 contains the name and an index which is used in the location's token.
9076 (Location): Reserve an appropriate number of bits in the token for
9077 the source file instead of walking over that list, this gives us a
9078 really huge performance improvement when compiling with debugging.
9080 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
9081 `SourceFile' argument instead of a string.
9082 (Driver.ProcessFile): Add all the files via Location.AddFile(),
9083 but don't parse/tokenize here, we need to generate the list of all
9084 source files before we do that.
9085 (Driver.ProcessFiles): New static function. Parses/tokenizes all
9088 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
9089 instead of a string.
9091 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
9094 2003-02-09 Martin Baulig <martin@ximian.com>
9096 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
9097 filename on `#line default'.
9099 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
9101 * statement.cs: don't clear the pinned var when the fixed statement
9102 returns from the method (fixes bug#37752).
9104 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
9106 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
9109 2003-02-07 Martin Baulig <martin@ximian.com>
9111 * driver.cs: Removed the `--debug-args' command line argument.
9113 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
9114 automatically by the AsssemblyBuilder.
9115 (CodeGen.InitializeSymbolWriter): We don't need to call any
9116 initialization function on the symbol writer anymore. This method
9117 doesn't take any arguments.
9119 2003-02-03 Miguel de Icaza <miguel@ximian.com>
9121 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
9122 from referenced assemblies as well.
9124 2003-02-02 Martin Baulig <martin@ximian.com>
9126 * class.cs (MethodData.Emit): Generate debugging info for external methods.
9128 2003-02-02 Martin Baulig <martin@ximian.com>
9130 * class.cs (Constructor.Emit): Open the symbol writer before
9131 emitting the constructor initializer.
9132 (ConstructorInitializer.Emit): Call ec.Mark() to allow
9133 single-stepping through constructor initializers.
9135 2003-01-30 Miguel de Icaza <miguel@ximian.com>
9137 * class.cs: Handle error 549: do not allow virtual methods in
9140 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
9142 * decl.cs: Check access levels when resolving types
9144 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
9146 * statement.cs: Add parameters and locals set in catch blocks that might
9147 return to set vector
9149 2003-01-29 Miguel de Icaza <miguel@ximian.com>
9151 * class.cs (Operator): Set the SpecialName flags for operators.
9153 * expression.cs (Invocation.DoResolve): Only block calls to
9154 accessors and operators on SpecialName methods.
9156 (Cast.TryReduce): Handle conversions from char constants.
9159 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
9161 * statement.cs: small memory and time optimization in FlowBranching.
9163 2003-01-28 Pedro Mart <yoros@wanadoo.es>
9165 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
9166 problem that the last fix but in the other sid (Set).
9168 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
9169 access when there is no indexer in the hierarchy.
9171 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
9173 * class.cs: Combine some if statements.
9175 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9177 * driver.cs: fixed bug #37187.
9179 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
9181 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
9182 any indexer, it's needed to build a list with all the indexers in the
9183 hierarchy (AllGetters), else we have problems. Fixes #35653.
9185 2003-01-23 Miguel de Icaza <miguel@ximian.com>
9187 * class.cs (MethodData.Define): It is wrong for an interface
9188 implementation to be static in both cases: explicit and implicit.
9189 We were only handling this in one case.
9191 Improve the if situation there to not have negations.
9193 * class.cs (Field.Define): Turns out that we do not need to check
9194 the unsafe bit on field definition, only on usage. Remove the test.
9196 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9198 * driver.cs: use assembly.Location instead of Codebase (the latest
9199 patch made mcs fail when using MS assemblies).
9201 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
9203 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
9204 get the path to *corlib.dll.
9206 2003-01-21 Nick Drochak <ndrochak@gol.com>
9210 * typemanager.cs: Remove compiler warnings
9212 2003-01-20 Duncan Mak <duncan@ximian.com>
9214 * AssemblyInfo.cs: Bump the version number to 0.19.
9216 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9218 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
9220 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
9222 * class.cs (Constructor::Emit): Emit debugging info for constructors.
9224 2003-01-17 Miguel de Icaza <miguel@ximian.com>
9226 * cs-parser.jay: Small fix: we were not comparing the constructor
9227 name correctly. Thanks to Zoltan for the initial pointer.
9229 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
9231 * cs-tokenizer.cs: Set file name when specified with #line
9233 2003-01-15 Miguel de Icaza <miguel@ximian.com>
9235 * cs-parser.jay: Only perform the constructor checks here if we
9236 are named like the class; This will help provider a better
9237 error. The constructor path is taken when a type definition is
9238 not found, but most likely the user forgot to add the type, so
9239 report that rather than the constructor error.
9241 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
9243 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
9246 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
9248 * cs-parser.jay: Add cleanup call.
9250 2003-01-13 Duncan Mak <duncan@ximian.com>
9252 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
9253 consistent with other methods.
9255 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
9257 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
9259 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
9261 * attribute.cs: only set GuidAttr to true when we have a
9264 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9268 * typemanager.cs: fixes to allow mcs compile corlib with the new
9269 Type.IsSubclassOf fix.
9271 2003-01-08 Miguel de Icaza <miguel@ximian.com>
9273 * expression.cs (LocalVariableReference.DoResolve): Classify a
9274 constant as a value, not as a variable. Also, set the type for
9277 * cs-parser.jay (fixed_statement): take a type instead of a
9278 pointer_type, so we can produce a better error message later.
9280 * statement.cs (Fixed.Resolve): Flag types that are not pointers
9283 (For.DoEmit): Make inifinite loops have a
9284 non-conditional branch back.
9286 (Fixed.DoEmit): First populate the pinned variables, then emit the
9287 statement, then clear the variables. Before I was emitting the
9288 code once for each fixed piece.
9291 2003-01-08 Martin Baulig <martin@ximian.com>
9293 * statement.cs (FlowBranching.MergeChild): A break in a
9294 SWITCH_SECTION does not leave a loop. Fixes #36155.
9296 2003-01-08 Martin Baulig <martin@ximian.com>
9298 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
9299 lives in the same number space than `param_map'. Fixes #36154.
9301 2003-01-07 Miguel de Icaza <miguel@ximian.com>
9303 * cs-parser.jay (constructor_declaration): Set the
9304 Constructor.ModFlags before probing for it. This makes the
9305 compiler report 514, 515 and 132 (the code was there, but got
9308 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
9309 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
9310 (GotoCase.Resolve): Set `Returns' to ALWAYS.
9312 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
9314 * enum.cs: create the enum static fields using the enum type.
9316 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
9318 * class.cs: don't try to create the ParamBuilder for the return
9319 type if it's not needed (and handle it breaking for the ms runtime
9322 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
9324 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
9326 2002-12-29 Miguel de Icaza <miguel@ximian.com>
9328 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
9329 the command. This showed up while compiling the JANET source
9330 code, which used \r as its only newline separator.
9332 2002-12-28 Miguel de Icaza <miguel@ximian.com>
9334 * class.cs (Method.Define): If we are an operator (because it
9335 reuses our code), then set the SpecialName and HideBySig. #36128
9337 2002-12-22 Miguel de Icaza <miguel@ximian.com>
9339 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
9340 exception, report error 120 `object reference required'.
9342 * driver.cs: Add --pause option, used during to measure the size
9343 of the process as it goes with --timestamp.
9345 * expression.cs (Invocation.DoResolve): Do not allow methods with
9346 SpecialName to be invoked.
9348 2002-12-21 Miguel de Icaza <miguel@ximian.com>
9350 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
9351 number before adding it.
9353 2002-12-21 Ravi Pratap <ravi@ximian.com>
9355 * ecore.cs (StandardImplicitConversion): When in an unsafe
9356 context, we allow conversion between void * to any other pointer
9357 type. This fixes bug #35973.
9359 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
9361 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
9362 is not thrown when extensionless outputs are used
9364 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9366 * rootcontext.cs: fixed compilation of corlib.
9368 2002-12-19 Miguel de Icaza <miguel@ximian.com>
9370 * attribute.cs (Attributes.Contains): Add new method.
9372 * class.cs (MethodCore.LabelParameters): if the parameter is an
9373 `out' parameter, check that no attribute `[In]' has been passed.
9375 * enum.cs: Handle the `value__' name in an enumeration.
9377 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
9379 * decl.cs: Added special case to allow overrides on "protected
9382 2002-12-18 Ravi Pratap <ravi@ximian.com>
9384 * attribute.cs (Attributes.AddAttributeSection): Rename to this
9385 since it makes much more sense.
9387 (Attributes.ctor): Don't require a Location parameter.
9389 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
9391 * attribute.cs (ApplyAttributes): Remove extra Location parameters
9392 since we already have that information per attribute.
9394 * everywhere : make appropriate changes.
9396 * class.cs (LabelParameters): Write the code which actually
9397 applies attributes to the return type. We can't do this on the MS
9398 .NET runtime so we flag a warning in the case an exception is
9401 2002-12-18 Miguel de Icaza <miguel@ximian.com>
9403 * const.cs: Handle implicit null conversions here too.
9405 2002-12-17 Ravi Pratap <ravi@ximian.com>
9407 * class.cs (MethodCore.LabelParameters): Remove the extra
9408 Type [] parameter since it is completely unnecessary. Instead
9409 pass in the method's attributes so that we can extract
9410 the "return" attribute.
9412 2002-12-17 Miguel de Icaza <miguel@ximian.com>
9414 * cs-parser.jay (parse): Use Report.Error to flag errors instead
9415 of ignoring it and letting the compile continue.
9417 * typemanager.cs (ChangeType): use an extra argument to return an
9418 error condition instead of throwing an exception.
9420 2002-12-15 Miguel de Icaza <miguel@ximian.com>
9422 * expression.cs (Unary.TryReduce): mimic the code for the regular
9423 code path. Perform an implicit cast in the cases where we can
9424 implicitly convert to one of the integral types, and then reduce
9425 based on that constant. This fixes bug #35483.
9427 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9429 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
9431 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9433 * namespace.cs: fixed bug #35489.
9435 2002-12-12 Miguel de Icaza <miguel@ximian.com>
9437 * class.cs: Remove some dead code.
9439 * cs-parser.jay: Estimate the number of methods needed
9440 (RootContext.MethodCount);
9442 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
9443 numbers instead of StringBuilders.
9445 * support.cs (PtrHashtable): Add constructor with initial size;
9446 We can now reduce reallocations of the method table.
9448 2002-12-10 Ravi Pratap <ravi@ximian.com>
9450 * attribute.cs (ApplyAttributes): Keep track of the emitted
9451 attributes on a per-target basis. This fixes bug #35413.
9453 2002-12-10 Miguel de Icaza <miguel@ximian.com>
9455 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
9456 default to the Windows 1252 encoding.
9458 (UnixParseOption): Support version, thanks to Alp for the missing
9461 * AssemblyInfo.cs: Add nice assembly information.
9463 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
9466 * cs-parser.jay: Allow a trailing comma before the close bracked
9467 in the attribute_section production.
9469 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
9470 address of the instance was being taken, I will take this out,
9471 because we take the address of the object immediately here.
9473 2002-12-09 Ravi Pratap <ravi@ximian.com>
9475 * typemanager.cs (AreMultipleAllowed): Take care of the most
9476 obvious case where attribute type is not in the current assembly -
9479 2002-12-08 Miguel de Icaza <miguel@ximian.com>
9481 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
9482 definitions, instead of doing that afterwards.
9484 Also we use a nice little hack, depending on the constructor, we
9485 know if we are a "composed" name or a simple name. Hence, we
9486 avoid the IndexOf test, and we avoid
9488 * codegen.cs: Add code to assist in a bug reporter to track down
9489 the source of a compiler crash.
9491 2002-12-07 Ravi Pratap <ravi@ximian.com>
9493 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
9494 types have been emitted for a given element and flag an error
9495 if something which does not have AllowMultiple set is used more
9498 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
9499 attribute types and their corresponding AllowMultiple properties
9501 (AreMultipleAllowed): Check the property for a given type.
9503 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
9504 property in the case we have a TypeContainer.
9506 (Attributes.AddAttribute): Detect duplicates and just skip on
9507 adding them. This trivial fix catches a pretty gross error in our
9508 attribute emission - global attributes were being emitted twice!
9510 Bugzilla bug #33187 is now fixed.
9512 2002-12-06 Miguel de Icaza <miguel@ximian.com>
9514 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
9517 * expression.cs (Binary.ResolveOperator): I can only use the
9518 Concat (string, string, string) and Concat (string, string,
9519 string, string) if the child is actually a concatenation of
9522 2002-12-04 Miguel de Icaza <miguel@ximian.com>
9524 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
9525 context where we need a 2-character lookahead.
9527 * pending.cs (PendingImplementation): Rework so we can keep track
9528 of interface types all the time, and flag those which were
9529 implemented by parents as optional.
9531 2002-12-03 Miguel de Icaza <miguel@ximian.com>
9533 * expression.cs (Binary.ResolveOperator): Use
9534 String.Concat(string,string,string) or
9535 String.Concat(string,string,string,string) when possible.
9537 * typemanager: More helper methods.
9540 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
9542 * pending.cs: remove the bogus return from GetMissingInterfaces()
9543 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
9545 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9547 * namespace.cs: avoid duplicated 'using xxx' being added to
9548 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
9549 when we get more than one 'using' statement for the same namespace.
9550 Report a CS0105 warning for it.
9552 2002-11-30 Miguel de Icaza <miguel@ximian.com>
9554 * cs-tokenizer.cs (consume_identifier): use read directly, instead
9555 of calling getChar/putback, uses internal knowledge of it.
9557 (xtoken): Reorder tokenizer so most common patterns are checked
9558 first. This reduces the compilation time in another 5% (from 8.11s
9559 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
9561 The parsing time is 22% of the compilation in mcs, and from that
9562 64% is spent on the tokenization process.
9564 I tried using a binary search for keywords, but this is slower
9565 than the hashtable. Another option would be to do a couple of
9568 * Not use a StringBuilder, instead use an array of chars,
9569 with a set value. Notice that this way we could catch
9570 the 645 error without having to do it *afterwards*.
9572 * We could write a hand-parser to avoid the hashtable
9573 compares altogether.
9575 The identifier consumption process takes 37% of the tokenization
9576 time. Another 15% is spent on is_number. 56% of the time spent
9577 on is_number is spent on Int64.Parse:
9579 * We could probably choose based on the string length to
9580 use Int32.Parse or Int64.Parse and avoid all the 64-bit
9583 Another 3% is spend on wrapping `xtoken' in the `token' function.
9585 Handle 0xa0 as whitespace (#34752)
9587 2002-11-26 Miguel de Icaza <miguel@ximian.com>
9589 * typemanager.cs (IsCLRType): New routine to tell whether a type
9590 is one of the builtin types.
9592 Maybe it needs to use TypeCodes to be faster. Maybe we could use
9593 typecode in more places instead of doing pointer comparissions.
9594 We could leverage some knowledge about the way the typecodes are
9597 New code to cache namespaces in assemblies, it is currently not
9598 invoked, to be used soon.
9600 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
9602 * expression.cs (Binary.ResolveOperator): specially handle
9603 strings, and do not perform user-defined operator overloading for
9606 2002-11-24 Miguel de Icaza <miguel@ximian.com>
9608 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
9609 internalcall as it is a pretty simple operation; Avoid whenever
9610 possible to call Char.IsLetter.
9612 (consume_identifier): Cut by half the number of
9613 hashtable calls by merging the is_keyword and GetKeyword behavior.
9615 Do not short-circuit, because if we do, we
9616 report errors (ie, #if false && true would produce an invalid
9620 2002-11-24 Martin Baulig <martin@ximian.com>
9622 * expression.cs (Cast.TryReduce): If we're in checked syntax,
9623 check constant ranges and report a CS0221. Fixes #33186.
9625 2002-11-24 Martin Baulig <martin@ximian.com>
9627 * cs-parser.jay: Make this work for uninitialized variable
9628 declarations in the `for' initializer. Fixes #32416.
9630 2002-11-24 Martin Baulig <martin@ximian.com>
9632 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
9633 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
9635 2002-11-24 Martin Baulig <martin@ximian.com>
9637 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
9638 argument; if true, we also check for user-defined conversions.
9639 This is only needed if both arguments are of a user-defined type.
9640 Fixes #30443, added test-175.cs.
9641 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
9643 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
9645 2002-11-24 Martin Baulig <martin@ximian.com>
9647 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
9648 function to get the store opcode.
9649 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
9650 only emit the Ldelema if the store opcode is Stobj. You must run
9651 both test-34 and test-167 to test this. Fixes #34529.
9653 2002-11-23 Martin Baulig <martin@ximian.com>
9655 * ecore.cs (Expression.MemberLookup): Added additional
9656 `qualifier_type' argument which is used when we're being called
9657 from MemberAccess.DoResolve() and null if we're called from a
9659 (Expression.MemberLookupFailed): New method to report errors; this
9660 does the CS1540 check and reports the correct error message.
9662 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
9663 argument for the CS1540 check and redone the way how we're dealing
9664 with private members. See the comment in the source code for details.
9665 (FilterWithClosure): Reverted this back to revision 1.197; renamed
9666 `closure_start_type' to `closure_qualifier_type' and check whether
9667 it's not null. It was not this filter being broken, it was just
9668 being called with the wrong arguments.
9670 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
9671 and pass it the correct `qualifier_type'; this also does the error
9674 2002-11-22 Miguel de Icaza <miguel@ximian.com>
9676 * expression.cs (Invocation.EmitParams): If the we are dealing
9677 with a non-built-in value type, load its address as well.
9679 (ArrayCreation): Use a a pretty constant instead
9680 of the hardcoded value 2. Use 6 instead of 2 for the number of
9681 static initializers.
9683 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
9684 because they are not really value types, just glorified integers.
9686 * driver.cs: Do not append .exe, the CSC compiler does not do it.
9688 * ecore.cs: Remove redundant code for enumerations, make them use
9689 the same code path as everything else, fixes the casting issue
9690 with enumerations in Windows.Forms.
9692 * attribute.cs: Do only cast to string if it is a string, the
9693 validation happens later.
9695 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
9696 people upgrade their corlibs.
9698 * ecore.cs: Oops, enumerations were not following the entire code path
9700 2002-11-21 Miguel de Icaza <miguel@ximian.com>
9702 * typemanager.cs (FilterWithClosure): Commented out the test for
9703 1540 in typemanager.cs, as it has problems when accessing
9704 protected methods from a parent class (see test-174.cs).
9706 * attribute.cs (Attribute.ValidateGuid): new method.
9707 (Attribute.Resolve): Use above.
9709 2002-11-19 Miguel de Icaza <miguel@ximian.com>
9711 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
9713 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
9714 handling for enumerations, as we only needed the TypeContainer
9715 functionality to begin with (this is required for the fix below to
9716 work for enums that reference constants in a container class for
9719 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
9721 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
9722 a valid TypeBuilder to perform lookups on.o
9724 * class.cs (InheritableMemberSignatureCompare): Use true in the
9725 call to GetGetMethod and GetSetMethod, because we are comparing
9726 the signature, and we need to get the methods *even* if they are
9729 (PropertyBase.CheckBase): ditto.
9731 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
9732 GotoCase.Resolve): Use Peel on EmpytCasts.
9734 * ecore.cs (EmptyCast): drop child, add Peel method.
9736 2002-11-17 Martin Baulig <martin@ximian.com>
9738 * ecore.cs (EmptyCast.Child): New public property.
9740 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
9741 label resolved to an EmptyCast. Fixes #34162.
9742 (GotoCase.Resolve): Likewise.
9743 (Block.EmitMeta): Likewise.
9745 2002-11-17 Martin Baulig <martin@ximian.com>
9747 * expression.cs (Invocation.BetterConversion): Prefer int over
9748 uint; short over ushort; long over ulong for integer literals.
9749 Use ImplicitConversionExists instead of StandardConversionExists
9750 since we also need to check for user-defined implicit conversions.
9751 Fixes #34165. Added test-173.cs.
9753 2002-11-16 Martin Baulig <martin@ximian.com>
9755 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
9756 with the `true' and `false' literals. Fixes #33151.
9758 2002-11-16 Martin Baulig <martin@ximian.com>
9760 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
9761 October 22nd; don't do the cs1540 check for static members.
9763 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
9764 now using our own filter here and doing the cs1540 check again.
9766 2002-11-16 Martin Baulig <martin@ximian.com>
9768 * support.cs (InternalParameters): Don't crash if we don't have
9769 any fixed parameters. Fixes #33532.
9771 2002-11-16 Martin Baulig <martin@ximian.com>
9773 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
9774 when looking up static methods to make this work on Windows.
9777 2002-11-16 Martin Baulig <martin@ximian.com>
9779 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
9780 a setter rather than using PropertyInfo.CanWrite.
9782 2002-11-15 Nick Drochak <ndrochak@gol.com>
9784 * class.cs: Allow acces to block member by subclasses. Fixes build
9787 2002-11-14 Martin Baulig <martin@ximian.com>
9789 * class.cs (Constructor.Emit): Added the extern/block check.
9792 2002-11-14 Martin Baulig <martin@ximian.com>
9794 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
9795 iteration while looking for indexers, this is needed because the
9796 indexer may have a different name in our base classes. Fixed the
9797 error reporting (no indexers at all, not get accessor, no
9798 overloaded match). Fixes bug #33089.
9799 (IndexerAccess.DoResolveLValue): Likewise.
9801 2002-11-14 Martin Baulig <martin@ximian.com>
9803 * class.cs (PropertyBase.CheckBase): Make this work for multiple
9804 indexers. Fixes the first part of bug #33089.
9805 (MethodSignature.InheritableMemberSignatureCompare): Added support
9808 2002-11-13 Ravi Pratap <ravi@ximian.com>
9810 * attribute.cs (Attribute.Resolve): Catch the
9811 NullReferenceException and report it since it isn't supposed to
9814 2002-11-12 Miguel de Icaza <miguel@ximian.com>
9816 * expression.cs (Binary.EmitBranchable): Also handle the cases for
9817 LogicalOr and LogicalAnd that can benefit from recursively
9818 handling EmitBranchable. The code now should be nice for Paolo.
9820 2002-11-08 Miguel de Icaza <miguel@ximian.com>
9822 * typemanager.cs (LookupType): Added a negative-hit hashtable for
9823 the Type lookups, as we perform quite a number of lookups on
9824 non-Types. This can be removed once we can deterministically tell
9825 whether we have a type or a namespace in advance.
9827 But this might require special hacks from our corlib.
9831 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
9832 and double which avoids a conversion from an integer to a double.
9834 * expression.cs: tiny optimization, avoid calling IsConstant,
9835 because it effectively performs the lookup twice.
9837 2002-11-06 Miguel de Icaza <miguel@ximian.com>
9839 But a bogus return here to keep the semantics of the old code
9840 until the Mono runtime is fixed.
9842 * pending.cs (GetMissingInterfaces): New method used to remove all
9843 the interfaces that are already implemented by our parent
9844 classes from the list of pending methods.
9846 * interface.cs: Add checks for calls after ResolveTypeExpr.
9848 2002-11-05 Miguel de Icaza <miguel@ximian.com>
9850 * class.cs (Class.Emit): Report warning 67: event not used if the
9851 warning level is beyond 3.
9853 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
9854 being a NullLiteral.
9856 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
9859 * class.cs (TypeContainer.GetClassBases): Cover a missing code
9860 path that might fail if a type can not be resolved.
9862 * expression.cs (Binary.Emit): Emit unsigned versions of the
9865 * driver.cs: use error 5.
9867 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
9869 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
9871 2002-11-01 Miguel de Icaza <miguel@ximian.com>
9873 * cs-parser.jay (switch_section): A beautiful patch from Martin
9874 Baulig that fixed 33094.
9876 2002-10-31 Miguel de Icaza <miguel@ximian.com>
9878 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
9879 Check whether the base is abstract and report an error if so.
9881 * expression.cs (IndexerAccess.DoResolveLValue,
9882 IndexerAccess.DoResolve): ditto.
9884 (Invocation.DoResolve): ditto.
9886 (Invocation.FullMethodDesc): Improve the report string.
9888 * statement.cs (Block): Eliminate IsVariableDefined as it is
9889 basically just a wrapper for GetVariableInfo.
9891 * ecore.cs (SimpleName): Use new
9893 * support.cs (ReflectionParamter.ParameterType): We unwrap the
9894 type, as we return the actual parameter ref/unref state on a
9897 2002-10-30 Miguel de Icaza <miguel@ximian.com>
9899 * support.cs: Return proper flags REF/OUT fixing the previous
9902 * expression.cs: Reverted last patch, that was wrong. Is_ref is
9903 not used to mean `ref' but `ref or out' in ParameterReference
9905 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
9906 full type signature instead of calling TypeManger.CSharpName
9909 * support.cs (InternalParameters.ParameterDesc): Do not compare
9910 directly to the modflags, because REF/OUT will actually be bitsets
9913 * delegate.cs (VerifyMethod): Check also the modifiers.
9915 * cs-tokenizer.cs: Fix bug where floating point values with an
9916 exponent where a sign was missing was ignored.
9918 * driver.cs: Allow multiple assemblies to be specified in a single
9921 2002-10-28 Miguel de Icaza <miguel@ximian.com>
9923 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
9924 because identifiers after a parenthesis would end up in this kind
9925 of production, and we needed to desamiguate it for having casts
9928 (UserDefinedType *) xxx
9930 2002-10-24 Miguel de Icaza <miguel@ximian.com>
9932 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
9933 we should set on the Bindingflags.NonPublic, but not turn on
9934 private_ok. private_ok controls whether a Private member is
9935 returned (this is chekced on the filter routine), while the
9936 BindingFlags.NonPublic just controls whether private/protected
9937 will be allowed. This fixes the problem part of the problem of
9938 private properties being allowed to be used in derived classes.
9940 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
9941 so we can call the children DoResolveLValue method (this will
9942 properly signal errors on lvalue assignments to base properties)
9944 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
9945 getter are null, and we have a property info, we know that this
9946 happened because the lookup failed, so we report an error 122 for
9947 protection level violation.
9949 We also silently return if setter and getter are null in the
9950 resolve functions, this condition only happens if we have flagged
9951 the error before. This is the other half of the problem.
9953 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
9954 not have accessibility information, that is why we were returning
9955 true in the filter function in typemanager.cs.
9957 To properly report 122 (property is inaccessible because of its
9958 protection level) correctly, we report this error in ResolveAccess
9959 by failing if both the setter and the getter are lacking (ie, the
9962 DoResolve and DoLResolve have been modified to check for both
9963 setter/getter being null and returning silently, the reason being
9964 that I did not want to put the knowledge about this error in upper
9967 int old = Report.Errors;
9968 x = new PropertyExpr (...);
9969 if (old != Report.Errors)
9974 So the property expr is returned, but it is invalid, so the error
9975 will be flagged during the resolve process.
9977 * class.cs: Remove InheritablePropertySignatureCompare from the
9978 class, as we no longer depend on the property signature to compute
9979 whether it is possible to implement a method or not.
9981 The reason is that calling PropertyInfo.GetGetMethod will return
9982 null (in .NET, in Mono it works, and we should change this), in
9983 cases where the Get Method does not exist in that particular
9988 class X { public virtual int A { get { return 1; } } }
9990 class Z : Y { public override int A { get { return 2; } } }
9992 Would fail in Z because the parent (Y) would not have the property
9993 defined. So we avoid this completely now (because the alternative
9994 fix was ugly and slow), and we now depend exclusively on the
9997 (PropertyBase.CheckBase): Use a method-base mechanism to find our
9998 reference method, instead of using the property.
10000 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
10001 routines are gone now.
10003 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
10004 names, they were incorrectly named.
10006 * cs-tokenizer.cs: Return are more gentle token on failure.
10008 * pending.cs (PendingImplementation.InterfaceMethod): This routine
10009 had an out-of-sync index variable, which caused it to remove from
10010 the list of pending methods the wrong method sometimes.
10012 2002-10-22 Miguel de Icaza <miguel@ximian.com>
10014 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
10015 CanWrite, because those refer to this particular instance of the
10016 property, and do not take into account the fact that we can
10017 override single members of a property.
10019 Constructor requires an EmitContext. The resolution process does
10020 not happen here, but we need to compute the accessors before,
10021 because the resolution does not always happen for properties.
10023 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
10024 subclass, before we did not update this flag, but we did update
10027 (GetAccessors): Drop this routine, as it did not work in the
10028 presence of partially overwritten set/get methods.
10030 Notice that this broke the cs1540 detection, but that will require
10033 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10037 * driver.cs: issue a warning instead of an error if we don't support
10038 debugging for the platform. Also ignore a couple of errors that may
10039 arise when trying to write the symbols. Undo my previous patch.
10041 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10043 * driver.cs: ignore /debug switch except for Unix platforms.
10045 2002-10-23 Nick Drochak <ndrochak@gol.com>
10047 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
10049 2002-10-21 Miguel de Icaza <miguel@ximian.com>
10051 * driver.cs: Do not make mcs-debug conditional, so we do not break
10052 builds that use it.
10054 * statement.cs (UsageVector.MergeChildren): I would like Martin to
10055 review this patch. But basically after all the children variables
10056 have been merged, the value of "Breaks" was not being set to
10057 new_breaks for Switch blocks. I think that it should be set after
10058 it has executed. Currently I set this to the value of new_breaks,
10059 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
10060 conservative, but I do not understand this code very well.
10062 I did not break anything in the build, so that is good ;-)
10064 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
10066 2002-10-20 Mark Crichton <crichton@gimp.org>
10068 * cfold.cs: Fixed compile blocker. Really fixed it this time.
10070 2002-10-20 Nick Drochak <ndrochak@gol.com>
10072 * cfold.cs: Fixed compile blocker.
10074 2002-10-20 Miguel de Icaza <miguel@ximian.com>
10076 * driver.cs: I was chekcing the key, not the file.
10078 2002-10-19 Ravi Pratap <ravi@ximian.com>
10080 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
10081 message that we were generating - we just need to silently return
10084 2002-10-19 Miguel de Icaza <miguel@ximian.com>
10086 * class.cs (Event.Define): Change my previous commit, as this
10087 breaks the debugger. This is a temporary hack, as it seems like
10088 the compiler is generating events incorrectly to begin with.
10090 * expression.cs (Binary.ResolveOperator): Added support for
10091 "U operator - (E x, E y)"
10093 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
10096 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
10097 init-only variables, but this path did not take into account that
10098 there might be also instance readonly variables. Correct this
10101 This fixes bug 32253
10103 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
10106 * driver.cs: Change the extension for modules to `netmodule'
10108 * cs-parser.jay: Improved slightly the location tracking for
10109 the debugger symbols.
10111 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
10112 modifiers that were specified instead of the hardcoded value
10113 (FamAndAssem). This was basically ignoring the static modifier,
10114 and others. Fixes 32429.
10116 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
10117 fixed a bug in the process (32476)
10119 * expression.cs (ArrayAccess.EmitAssign): Patch from
10120 hwang_rob@yahoo.ca that fixes bug 31834.3
10122 2002-10-18 Miguel de Icaza <miguel@ximian.com>
10124 * driver.cs: Make the module extension .netmodule.
10126 2002-10-16 Miguel de Icaza <miguel@ximian.com>
10128 * driver.cs: Report an error if the resource file is not found
10129 instead of crashing.
10131 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
10132 false, like Emit does.
10134 2002-10-16 Nick Drochak <ndrochak@gol.com>
10136 * typemanager.cs: Remove unused private member. Also reported mcs
10137 bug to report this as a warning like csc.
10139 2002-10-15 Martin Baulig <martin@gnome.org>
10141 * statement.cs (Statement.Emit): Made this a virtual method; emits
10142 the line number info and calls DoEmit().
10143 (Statement.DoEmit): New protected abstract method, formerly knows
10144 as Statement.Emit().
10146 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
10148 2002-10-11 Miguel de Icaza <miguel@ximian.com>
10150 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
10151 have fixed a remaining problem: not every AddXXXX was adding a
10152 fully qualified name.
10154 Now everyone registers a fully qualified name in the DeclSpace as
10155 being defined instead of the partial name.
10157 Downsides: we are slower than we need to be due to the excess
10158 copies and the names being registered this way.
10160 The reason for this is that we currently depend (on the corlib
10161 bootstrap for instance) that types are fully qualified, because
10162 we dump all the types in the namespace, and we should really have
10163 types inserted into the proper namespace, so we can only store the
10164 basenames in the defined_names array.
10166 2002-10-10 Martin Baulig <martin@gnome.org>
10168 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
10169 from bug #31834, see the bug report for a testcase which is
10172 2002-10-10 Martin Baulig <martin@gnome.org>
10174 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
10175 flow analysis code for this.
10177 * statement.cs (Do, While, For): Tell the flow analysis code about
10179 (FlowBranching.UsageVector): Added support for infinite loops.
10180 (Block.Resolve): Moved the dead code elimination here and use flow
10183 2002-10-09 Miguel de Icaza <miguel@ximian.com>
10185 * class.cs (Field.Define): Catch cycles on struct type
10188 * typemanager.cs (IsUnmanagedtype): Do not recursively check
10189 fields if the fields are static. We only need to check instance
10192 * expression.cs (As.DoResolve): Test for reference type.
10194 * statement.cs (Using.ResolveExpression): Use
10195 ConvertImplicitRequired, not ConvertImplicit which reports an
10197 (Using.ResolveLocalVariableDecls): ditto.
10199 * expression.cs (Binary.ResolveOperator): Report errors in a few
10200 places where we had to.
10202 * typemanager.cs (IsUnmanagedtype): Finish implementation.
10204 2002-10-08 Miguel de Icaza <miguel@ximian.com>
10206 * expression.cs: Use StoreFromPtr instead of extracting the type
10207 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
10209 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
10210 an enumeration value to a System.Enum, but System.Enum is not a
10211 value type, but an class type, so we need to box.
10213 (Expression.ConvertExplicit): One codepath could return
10214 errors but not flag them. Fix this. Fixes #31853
10216 * parameter.cs (Resolve): Do not allow void as a parameter type.
10218 2002-10-06 Martin Baulig <martin@gnome.org>
10220 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
10221 if it's a class type and not a struct. Fixes #31815.
10223 2002-10-06 Martin Baulig <martin@gnome.org>
10225 * statement.cs: Reworked the flow analysis code a bit to make it
10226 usable for dead code elimination.
10228 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10230 * cs-parser.jay: allow empty source files. Fixes bug #31781.
10232 2002-10-04 Miguel de Icaza <miguel@ximian.com>
10234 * expression.cs (ComposedCast.DoResolveType): A quick workaround
10235 to fix the test 165, will investigate deeper.
10237 2002-10-04 Martin Baulig <martin@gnome.org>
10239 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
10240 finally blocks actually work.
10241 (Try.Resolve): We don't need to create a sibling for `finally' if
10242 there is no finally block.
10244 2002-10-04 Martin Baulig <martin@gnome.org>
10246 * class.cs (Constructor.Define): The default accessibility for a
10247 non-default constructor is private, not public.
10249 2002-10-04 Miguel de Icaza <miguel@ximian.com>
10251 * class.cs (Constructor): Make AllowedModifiers public, add
10254 * cs-parser.jay: Perform the modifiers test here, as the
10255 constructor for the Constructor class usually receives a zero
10256 because of the way we create it (first we create, later we
10257 customize, and we were never checking the modifiers).
10259 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
10260 is a version of LookupTypeReflection that includes the type-name
10261 cache. This can be used as a fast path for functions that know
10262 the fully qualified name and are only calling into *.GetType() to
10263 obtain a composed type.
10265 This is also used by TypeManager.LookupType during its type
10268 (LookupType): We now also track the real type name, as sometimes
10269 we can get a quey for the real type name from things like
10270 ComposedCast. This fixes bug 31422.
10272 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
10273 complete type fullname, it does not have to go through the type
10274 resolution system to obtain the composed version of the type (for
10275 obtaining arrays or pointers).
10277 (Conditional.Emit): Use the EmitBoolExpression to
10278 generate nicer code, as requested by Paolo.
10280 (ArrayCreation.CheckIndices): Use the patch from
10281 hwang_rob@yahoo.ca to validate the array initializers.
10283 2002-10-03 Miguel de Icaza <miguel@ximian.com>
10285 * class.cs (ConstructorInitializer.Emit): simplify code by using
10286 Invocation.EmitCall, and at the same time, fix the bugs in calling
10287 parent constructors that took variable arguments.
10289 * ecore.cs (Expression.ConvertNumericExplicit,
10290 Expression.ImplicitNumericConversion): Remove the code that
10291 manually wrapped decimal (InternalTypeConstructor call is now gone
10294 * expression.cs (Cast.TryReduce): Also handle decimal types when
10295 trying to perform a constant fold on the type.
10297 * typemanager.cs (IsUnmanagedtype): Partially implemented.
10299 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
10300 that only turned off an error report, and did nothing else.
10302 2002-10-02 Miguel de Icaza <miguel@ximian.com>
10304 * driver.cs: Handle and ignore /fullpaths
10306 2002-10-01 Miguel de Icaza <miguel@ximian.com>
10308 * expression.cs (Binary.ResolveOperator): Catch the case where
10309 DoNumericPromotions returns true,
10311 (Binary.DoNumericPromotions): Simplify the code, and the tests.
10313 2002-09-27 Miguel de Icaza <miguel@ximian.com>
10315 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
10318 2002-09-26 Miguel de Icaza <miguel@ximian.com>
10320 * ecore.cs (ConvertNumericExplicit): It is not enough that the
10321 conversion exists, but it is also required that the conversion be
10322 performed. This manifested in "(Type64Enum) 2".
10324 * class.cs (TypeManager.AddMethod): The fix is not to change
10325 AddEnum, because that one was using a fully qualified name (every
10326 DeclSpace derivative does), but to change the AddMethod routine
10327 that was using an un-namespaced name. This now correctly reports
10328 the duplicated name.
10330 Revert patch until I can properly fix it. The issue
10331 is that we have a shared Type space across all namespaces
10332 currently, which is wrong.
10334 Options include making the Namespace a DeclSpace, and merge
10335 current_namespace/current_container in the parser.
10337 2002-09-25 Miguel de Icaza <miguel@ximian.com>
10339 * cs-parser.jay: Improve error reporting when we get a different
10340 kind of expression in local_variable_type and
10341 local_variable_pointer_type.
10343 Propagate this to avoid missleading errors being reported.
10345 * ecore.cs (ImplicitReferenceConversion): treat
10346 TypeManager.value_type as a target just like object_type. As
10351 Is valid, and needs to result in the int 1 being boxed before it
10352 is assigned to the value type v.
10354 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
10355 to validate the enumeration name.
10357 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
10358 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
10359 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
10361 * ecore.cs (TryImplicitIntConversion): When doing an
10362 implicit-enumeration-conversion, check if the type is 64-bits and
10363 perform a conversion before passing to EnumConstant.
10365 2002-09-23 Miguel de Icaza <miguel@ximian.com>
10367 * decl.cs (Error_AmbiguousTypeReference); New routine used to
10368 report ambiguous type references. Unlike the MS version, we
10369 report what the ambiguity is. Innovation at work ;-)
10371 (DeclSpace.FindType): Require a location argument to
10372 display when we display an ambiguous error.
10374 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
10376 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
10378 * expression.cs (EmitDynamicInitializers): Apply patch from
10379 hwang_rob@yahoo.ca that fixes the order in which we emit our
10382 2002-09-21 Martin Baulig <martin@gnome.org>
10384 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
10385 delegate takes no arguments.
10387 2002-09-20 Miguel de Icaza <miguel@ximian.com>
10389 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
10392 * expression.cs: Extract the underlying type.
10394 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
10396 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
10398 2002-09-19 Miguel de Icaza <miguel@ximian.com>
10400 * class.cs (TypeContainer.DefineType): We can not use the nice
10401 PackingSize with the size set to 1 DefineType method, because it
10402 will not allow us to define the interfaces that the struct
10405 This completes the fixing of bug 27287
10407 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
10408 means also structs. This fixes part of the problem.
10409 (Expresion.ImplicitReferenceConversionExists): ditto.
10411 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
10412 error if there were no errors reported during the type lookup
10413 process, to avoid duplicates or redundant errors. Without this
10414 you would get an ambiguous errors plus a type not found. We have
10415 beaten the user enough with the first error.
10417 (DeclSparce.FindType): Emit a warning if we have an ambiguous
10420 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
10421 during the resolution process, stop the lookup, this avoids
10422 repeated error reports (same error twice).
10424 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
10426 * typemanager.cs (LookupType): Redo the type lookup code to match
10427 the needs of System.Reflection.
10429 The issue is that System.Reflection requires references to nested
10430 types to begin with a "+" sign instead of a dot. So toplevel
10431 types look like: "NameSpace.TopLevelClass", and nested ones look
10432 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
10435 2002-09-19 Martin Baulig <martin@gnome.org>
10437 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
10438 says that a method always returns or always throws an exception,
10439 don't report the CS0161.
10441 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
10442 set `Returns = new_returns'.
10444 2002-09-19 Martin Baulig <martin@gnome.org>
10446 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
10447 to an enum constant, check for a CS0176.
10449 2002-09-18 Miguel de Icaza <miguel@ximian.com>
10451 * class.cs (TypeContainer.CheckPairedOperators): Now we check
10452 for operators that must be in pairs and report errors.
10454 * ecore.cs (SimpleName.DoResolveType): During the initial type
10455 resolution process, when we define types recursively, we must
10456 check first for types in our current scope before we perform
10457 lookups in the enclosing scopes.
10459 * expression.cs (MakeByteBlob): Handle Decimal blobs.
10461 (Invocation.VerifyArgumentsCompat): Call
10462 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
10463 I thought we were supposed to always call this, but there are a
10464 few places in the code where we dont do it.
10466 2002-09-17 Miguel de Icaza <miguel@ximian.com>
10468 * driver.cs: Add support in -linkres and -resource to specify the
10469 name of the identifier.
10471 2002-09-16 Miguel de Icaza <miguel@ximian.com>
10473 * ecore.cs (StandardConversionExists): Sync with the conversion
10474 code: allow anything-* to void* conversions.
10476 (FindMostSpecificSource): Use an Expression argument
10477 instead of a Type, because we might be handed over a Literal which
10478 gets a few more implicit conversions that plain types do not. So
10479 this information was being lost.
10481 Also, we drop the temporary type-holder expression when not
10484 2002-09-17 Martin Baulig <martin@gnome.org>
10486 * class.cs (PropertyBase.CheckBase): Don't check the base class if
10487 this is an explicit interface implementation.
10489 2002-09-17 Martin Baulig <martin@gnome.org>
10491 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
10492 different `IndexerName' attributes.
10494 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
10495 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
10496 virtual CommonResolve().
10498 2002-09-16 Miguel de Icaza <miguel@ximian.com>
10500 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
10501 and convert that to the UnderlyingType.
10503 * statement.cs (Foreach.Resolve): Indexers are just like variables
10504 or PropertyAccesses.
10506 * cs-tokenizer.cs (consume_string): Track line numbers and columns
10507 inside quoted strings, we were not doing this before.
10509 2002-09-16 Martin Baulig <martin@gnome.org>
10511 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
10512 resolve it. This is needed for the definite assignment check of the
10513 instance expression, fixes bug #29846.
10514 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
10516 2002-09-16 Nick Drochak <ndrochak@gol.com>
10518 * parameter.cs: Fix compile error. Cannot reference static member
10519 from an instance object. Is this an mcs bug?
10521 2002-09-14 Martin Baulig <martin@gnome.org>
10523 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
10524 multiple times. Fixes bug #30295, added test-166.cs.
10526 2002-09-14 Martin Baulig <martin@gnome.org>
10528 * statement.cs (Block.Emit): Don't emit unreachable code.
10529 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
10530 `break' statements.
10531 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
10533 2002-09-14 Martin Baulig <martin@gnome.org>
10535 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
10538 2002-09-14 Martin Baulig <martin@gnome.org>
10540 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
10541 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
10542 be false on the ms runtime.
10544 2002-09-13 Martin Baulig <martin@gnome.org>
10546 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
10547 the CS0038 error message.
10549 2002-09-12 Miguel de Icaza <miguel@ximian.com>
10551 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
10552 constant inside, return it.
10554 2002-09-12 Martin Baulig <martin@gnome.org>
10556 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
10557 implicit conversion can be done between enum types.
10559 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
10560 check whether an implicit conversion to the current enum's UnderlyingType
10561 exists and report an error if not.
10563 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
10564 without debugging support.
10566 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
10567 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
10569 2002-09-12 Martin Baulig <martin@gnome.org>
10571 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
10573 * ecore.cs (IMemberExpr.DeclaringType): New property.
10574 (SimpleName.SimpleNameResolve): Check whether we're accessing a
10575 nonstatic member of an outer type (CS0038).
10577 2002-09-11 Miguel de Icaza <miguel@ximian.com>
10579 * driver.cs: Activate the using-error detector at warning level
10580 4 (at least for MS-compatible APIs).
10582 * namespace.cs (VerifyUsing): Small buglett fix.
10584 * pending.cs (PendingImplementation): pass the container pointer.
10586 * interface.cs (GetMethods): Allow for recursive definition. Long
10587 term, I would like to move every type to support recursive
10588 definitions, not the current ordering mechanism that we have right
10591 The situation is this: Attributes are handled before interfaces,
10592 so we can apply attributes to interfaces. But some attributes
10593 implement interfaces, we will now handle the simple cases
10594 (recursive definitions will just get an error).
10596 * parameter.cs: Only invalidate types at the end if we fail to
10599 2002-09-09 Martin Baulig <martin@gnome.org>
10601 * ecore.cs (PropertyExpr.Emit): Also check for
10602 TypeManager.system_int_array_get_length so this'll also work when
10603 compiling corlib. Fixes #30003.
10605 2002-09-09 Martin Baulig <martin@gnome.org>
10607 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
10608 and throw an exception if we can't get the type's size. Fixed #30040,
10611 2002-09-09 Martin Baulig <martin@gnome.org>
10613 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
10615 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
10616 context. Fixes bug #30027.
10618 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
10619 virtual functions. Fixes bug #30043, added test-164.cs.
10621 2002-09-08 Ravi Pratap <ravi@ximian.com>
10623 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
10625 2002-09-08 Nick Drochak <ndrochak@gol.com>
10627 * driver.cs: Use an object to get the windows codepage since it's not a
10630 2002-09-08 Miguel de Icaza <miguel@ximian.com>
10632 * statement.cs (For.Emit): for infinite loops (test == null)
10633 return whether there is a break inside, not always "true".
10635 * namespace.cs (UsingEntry): New struct to hold the name of the
10636 using definition, the location where it is defined, and whether it
10637 has been used in a successful type lookup.
10639 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
10644 2002-09-06 Ravi Pratap <ravi@ximian.com>
10646 * attribute.cs : Fix incorrect code which relied on catching
10647 a NullReferenceException to detect a null being passed in
10648 where an object was expected.
10650 2002-09-06 Miguel de Icaza <miguel@ximian.com>
10652 * statement.cs (Try): flag the catch variable as assigned
10654 * expression.cs (Cast): Simplified by using ResolveType instead of
10655 manually resolving.
10657 * statement.cs (Catch): Fix bug by using ResolveType.
10659 2002-09-06 Ravi Pratap <ravi@ximian.com>
10661 * expression.cs (BetterConversion): Special case for when we have
10662 a NullLiteral as the argument and we have to choose between string
10663 and object types - we choose string the way csc does.
10665 * attribute.cs (Attribute.Resolve): Catch the
10666 NullReferenceException and report error #182 since the Mono
10667 runtime no more has the bug and having this exception raised means
10668 we tried to select a constructor which takes an object and is
10671 2002-09-05 Ravi Pratap <ravi@ximian.com>
10673 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
10674 message (1502, 1503) when we can't locate a method after overload
10675 resolution. This is much more informative and closes the bug
10678 * interface.cs (PopulateMethod): Return if there are no argument
10679 types. Fixes a NullReferenceException bug.
10681 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
10682 expressions too. Previously we were checking only in one place for
10683 positional arguments leaving out named arguments.
10685 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
10686 type to the enum type is not allowed. Remove code corresponding to
10689 (ConvertNumericExplicit): Allow explicit conversions from
10690 the underlying type to enum type. This precisely follows the spec
10691 and closes a bug filed by Gonzalo.
10693 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10696 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
10698 2002-09-03 Miguel de Icaza <miguel@ximian.com>
10700 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
10701 it was important that we stored the right value after the
10702 reduction in `converted'.
10704 2002-09-04 Martin Baulig <martin@gnome.org>
10706 * location.cs (Location.SymbolDocument): Use full pathnames for the
10709 2002-08-30 Miguel de Icaza <miguel@ximian.com>
10711 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
10712 of the expression resolve mechanism, because that will catch the
10713 SimpleName error failures.
10715 (Conditional): If we can not resolve the
10716 expression, return, do not crash.
10718 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10721 (location): display token name instead of its number.
10723 2002-08-28 Martin Baulig <martin@gnome.org>
10725 * expression.cs (Binary.ResolveOperator): Don't silently return
10726 but return an error if an operator cannot be applied between two
10729 2002-08-28 Martin Baulig <martin@gnome.org>
10731 * class.cs (Constructor.Define): Set the permission attributes
10732 correctly instead of making all constructors public.
10734 2002-08-28 Martin Baulig <martin@gnome.org>
10736 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
10737 for private members before reporting a CS0103; if we find anything,
10740 2002-08-28 Martin Baulig <martin@gnome.org>
10742 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
10743 to check whether `closure_start_type == closure_invocation_type',
10744 we also need to check whether `m.DeclaringType == closure_invocation_type'
10745 before bypassing the permission checks. We might be accessing
10746 protected/private members from the base class.
10747 (TypeManager.RealMemberLookup): Only set private_ok if private
10748 members were requested via BindingFlags.NonPublic.
10750 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
10752 * expression.cs (MemberAccess.ResolveMemberAccess): Set
10753 MethodGroupExpr.IsExplicitImpl if appropriate.
10754 (Invocation.DoResolve): Don't report the CS0120 for explicit
10755 interface implementations.
10757 2002-08-27 Martin Baulig <martin@gnome.org>
10759 * expression.cs (Invocation.DoResolve): If this is a static
10760 method and we don't have an InstanceExpression, we must report
10763 2002-08-25 Martin Baulig <martin@gnome.org>
10765 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
10766 `==' between a valuetype and an object.
10768 2002-08-25 Miguel de Icaza <miguel@ximian.com>
10770 * ecore.cs (TypeExpr): Provide a ToString method.
10772 2002-08-24 Martin Baulig <martin@gnome.org>
10774 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
10775 now called proggie.dbg and it's a binary file.
10777 2002-08-23 Martin Baulig <martin@gnome.org>
10779 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
10781 2002-08-23 Martin Baulig <martin@gnome.org>
10783 * struct.cs (MyStructInfo.ctor): Make this work with empty
10784 structs; it's not allowed to use foreach() on null.
10786 2002-08-23 Martin Baulig <martin@gnome.org>
10788 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
10789 writer the full pathname of the generated assembly.
10791 2002-08-23 Martin Baulig <martin@gnome.org>
10793 * statements.cs (FlowBranching.UsageVector.MergeChildren):
10794 A `finally' block never returns or breaks; improved handling of
10797 2002-08-23 Martin Baulig <martin@gnome.org>
10799 * statement.cs (Throw.Resolve): Allow `throw null'.
10801 2002-08-23 Martin Baulig <martin@gnome.org>
10803 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
10804 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
10805 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
10806 MemberLookup would return a wrong event if this is an explicit
10807 interface implementation and the class has an event with the same
10810 2002-08-23 Martin Baulig <martin@gnome.org>
10812 * statement.cs (Block.AddChildVariableNames): New public method.
10813 (Block.AddChildVariableName): Likewise.
10814 (Block.IsVariableNameUsedInChildBlock): Likewise.
10815 (Block.AddVariable): Check whether a variable name has already
10816 been used in a child block.
10818 * cs-parser.jay (declare_local_variables): Mark all variable names
10819 from the current block as being used in a child block in the
10822 2002-08-23 Martin Baulig <martin@gnome.org>
10824 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
10825 find the symbol writer.
10827 * driver.cs: csc also allows the arguments to /define being
10828 separated by commas, not only by semicolons.
10830 2002-08-23 Martin Baulig <martin@gnome.org>
10832 * interface.cs (Interface.GetMembers): Added static check for events.
10834 2002-08-15 Martin Baulig <martin@gnome.org>
10836 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
10837 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
10839 * ecore.cs (Expression.MemberLookup): Added documentation and explained
10840 why the MethodData.EmitDestructor() change was necessary.
10842 2002-08-20 Martin Baulig <martin@gnome.org>
10844 * class.cs (TypeContainer.FindMembers): Added static check for events.
10846 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
10848 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
10849 use Type.GetEvents(), not Type.FindMembers().
10851 2002-08-20 Martin Baulig <martin@gnome.org>
10853 * decl.cs (MemberCache): Added a special method cache which will
10854 be used for method-only searched. This ensures that a method
10855 search will return a MethodInfo with the correct ReflectedType for
10858 2002-08-20 Martin Baulig <martin@gnome.org>
10860 * decl.cs (DeclSpace.FindMembers): Made this public.
10862 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10864 * delegate.cs: fixed build on windows.
10865 [FIXME: Filed as bug #29150: MCS must report these errors.]
10867 2002-08-19 Ravi Pratap <ravi@ximian.com>
10869 * ecore.cs (StandardConversionExists): Return a false
10870 if we are trying to convert the void type to anything else
10871 since that is not allowed.
10873 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
10874 we flag error 70 in the event an event is trying to be accessed
10875 directly from outside the declaring type.
10877 2002-08-20 Martin Baulig <martin@gnome.org>
10879 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
10880 MemberCache from typemanager.cs to decl.cs.
10882 2002-08-19 Martin Baulig <martin@gnome.org>
10884 * class.cs (TypeContainer): Implement IMemberContainer.
10885 (TypeContainer.DefineMembers): Create the MemberCache.
10886 (TypeContainer.FindMembers): Do better BindingFlags checking; only
10887 return public members if BindingFlags.Public was given, check
10888 whether members are static.
10890 2002-08-16 Martin Baulig <martin@gnome.org>
10892 * decl.cs (DeclSpace.Define): Splitted this in Define and
10893 DefineMembers. DefineMembers is called first and initializes the
10896 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
10897 DefineMembers() on all our DeclSpaces.
10899 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
10900 but call DefineMembers() on all nested interfaces. We call their
10901 Define() in our new Define() function.
10903 * interface.cs (Interface): Implement IMemberContainer.
10904 (Interface.Define): Moved all code except the attribute stuf to
10906 (Interface.DefineMembers): Initialize the member cache.
10908 * typemanager.cs (IMemberFinder): Removed this interface, we don't
10909 need this anymore since we can use MemberCache.FindMembers directly.
10911 2002-08-19 Martin Baulig <martin@gnome.org>
10913 * typemanager.cs (MemberCache): When creating the cache for an
10914 interface type, add all inherited members.
10915 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
10916 to `out bool used_cache' and documented it.
10917 (TypeManager.MemberLookup): If we already used the cache in the first
10918 iteration, we don't need to do the interfaces check.
10920 2002-08-19 Martin Baulig <martin@gnome.org>
10922 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
10923 here from IMemberFinder and don't implement this interface anymore.
10924 (DeclSpace.MemberCache): Moved here from IMemberFinder.
10926 * typemanager.cs (IMemberFinder): This interface is now only used by
10927 classes which actually support the member cache.
10928 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
10929 since we only put DeclSpaces into this Hashtable.
10930 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
10931 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
10933 2002-08-16 Martin Baulig <martin@gnome.org>
10935 * typemanager.cs (ICachingMemberFinder): Removed.
10936 (IMemberFinder.MemberCache): New property.
10937 (TypeManager.FindMembers): Merged this with RealFindMembers().
10938 This function will never be called from TypeManager.MemberLookup()
10939 so we can't use the cache here, just the IMemberFinder.
10940 (TypeManager.MemberLookup_FindMembers): Check whether the
10941 IMemberFinder has a MemberCache and call the cache's FindMembers
10943 (MemberCache): Rewrote larger parts of this yet another time and
10944 cleaned it up a bit.
10946 2002-08-15 Miguel de Icaza <miguel@ximian.com>
10948 * driver.cs (LoadArgs): Support quoting.
10950 (Usage): Show the CSC-like command line arguments.
10952 Improved a few error messages.
10954 2002-08-15 Martin Baulig <martin@gnome.org>
10956 * typemanager.cs (IMemberContainer.Type): New property.
10957 (IMemberContainer.IsInterface): New property.
10959 The following changes are conditional to BROKEN_RUNTIME, which is
10960 defined at the top of the file.
10962 * typemanager.cs (MemberCache.MemberCache): Don't add the base
10963 class'es members, but add all members from TypeHandle.ObjectType
10964 if we're an interface.
10965 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
10966 is the current type.
10967 (MemberCache.CacheEntry.Container): Removed this field.
10968 (TypeHandle.GetMembers): Include inherited members.
10970 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10972 * typemanager.cs: fixed compilation and added a comment on a field that
10975 2002-08-15 Martin Baulig <martin@gnome.org>
10977 * class.cs (ConstructorInitializer.Resolve): In the
10978 Expression.MemberLookup call, use the queried_type as
10981 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
10982 declared' attribute, it's always true.
10983 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
10984 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
10985 temporary wrapper for FindMembers which tells MemberLookup whether
10986 members from the base classes are included in the return value.
10987 This will go away soon.
10988 (TypeManager.MemberLookup): Use this temporary hack here; once the
10989 new MemberCache is completed, we don't need to do the DeclaredOnly
10990 looping here anymore since the MemberCache will take care of this.
10991 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
10992 (MemberCache): When creating the MemberCache for a class, get
10993 members from the current class and all its base classes.
10994 (MemberCache.CacheEntry.Container): New field. This is a
10995 temporary hack until the Mono runtime is fixed to distinguish
10996 between ReflectedType and DeclaringType. It allows us to use MCS
10997 with both the MS runtime and the unfixed Mono runtime without
10998 problems and without accecting performance.
10999 (MemberCache.SearchMembers): The DeclaredOnly looping from
11000 TypeManager.MemberLookup is now done here.
11002 2002-08-14 Martin Baulig <martin@gnome.org>
11004 * statement.cs (MyStructInfo.MyStructInfo): Don't call
11005 Type.GetFields on dynamic types but get the fields from the
11006 corresponding TypeContainer.
11007 (MyStructInfo.GetStructInfo): Added check for enum types.
11009 * typemanager.cs (MemberList.IsSynchronized): Implemented.
11010 (MemberList.SyncRoot): Implemented.
11011 (TypeManager.FilterWithClosure): No need to check permissions if
11012 closure_start_type == closure_invocation_type, don't crash if
11013 closure_invocation_type is null.
11015 2002-08-13 Martin Baulig <martin@gnome.org>
11017 Rewrote TypeContainer.FindMembers to use a member cache. This
11018 gives us a speed increase of about 35% for the self-hosting MCS
11019 build and of about 15-20% for the class libs (both on GNU/Linux).
11021 * report.cs (Timer): New class to get enhanced profiling. This
11022 whole class is "TIMER" conditional since it remarkably slows down
11025 * class.cs (MemberList): New class. This is an IList wrapper
11026 which we're now using instead of passing MemberInfo[]'s around to
11027 avoid copying this array unnecessarily.
11028 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
11029 (ICachingMemberFinder, IMemberContainer): New interface.
11030 (TypeManager.FilterWithClosure): If `criteria' is null, the name
11031 has already been checked, otherwise use it for the name comparision.
11032 (TypeManager.FindMembers): Renamed to RealMemberFinder and
11033 provided wrapper which tries to use ICachingMemberFinder.FindMembers
11034 if possible. Returns a MemberList, not a MemberInfo [].
11035 (TypeHandle): New class, implements IMemberContainer. We create
11036 one instance of this class per type, it contains a MemberCache
11037 which is used to do the member lookups.
11038 (MemberCache): New class. Each instance of this class contains
11039 all members of a type and a name-based hash table.
11040 (MemberCache.FindMembers): This is our new member lookup
11041 function. First, it looks up all members of the requested name in
11042 the hash table. Then, it walks this list and sorts out all
11043 applicable members and returns them.
11045 2002-08-13 Martin Baulig <martin@gnome.org>
11047 In addition to a nice code cleanup, this gives us a performance
11048 increase of about 1.4% on GNU/Linux - not much, but it's already
11049 half a second for the self-hosting MCS compilation.
11051 * typemanager.cs (IMemberFinder): New interface. It is used by
11052 TypeManager.FindMembers to call FindMembers on a TypeContainer,
11053 Enum, Delegate or Interface.
11054 (TypeManager.finder_to_member_finder): New PtrHashtable.
11055 (TypeManager.finder_to_container): Removed.
11056 (TypeManager.finder_to_delegate): Removed.
11057 (TypeManager.finder_to_interface): Removed.
11058 (TypeManager.finder_to_enum): Removed.
11060 * interface.cs (Interface): Implement IMemberFinder.
11062 * delegate.cs (Delegate): Implement IMemberFinder.
11064 * enum.cs (Enum): Implement IMemberFinder.
11066 * class.cs (TypeContainer): Implement IMemberFinder.
11068 2002-08-12 Martin Baulig <martin@gnome.org>
11070 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
11072 2002-08-12 Martin Baulig <martin@gnome.org>
11074 * ecore.cs (ITypeExpression): New interface for expressions which
11076 (TypeExpression): Renamed to TypeLookupExpression.
11077 (Expression.DoResolve): If we're doing a types-only lookup, the
11078 expression must implement the ITypeExpression interface and we
11079 call DoResolveType() on it.
11080 (SimpleName): Implement the new ITypeExpression interface.
11081 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
11082 hack, the situation that we're only looking up types can't happen
11083 anymore when this method is called. Moved the type lookup code to
11084 DoResolveType() and call it.
11085 (SimpleName.DoResolveType): This ITypeExpression interface method
11086 is now doing the types-only lookup.
11087 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
11088 (ResolveFlags): Added MaskExprClass.
11090 * expression.cs (MemberAccess): Implement the ITypeExpression
11092 (MemberAccess.DoResolve): Added support for a types-only lookup
11093 when we're called via ITypeExpression.DoResolveType().
11094 (ComposedCast): Implement the ITypeExpression interface.
11096 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
11097 Expression.Resolve() with ResolveFlags.Type instead.
11099 2002-08-12 Martin Baulig <martin@gnome.org>
11101 * interface.cs (Interface.Define): Apply attributes.
11103 * attribute.cs (Attribute.ApplyAttributes): Added support for
11104 interface attributes.
11106 2002-08-11 Martin Baulig <martin@gnome.org>
11108 * statement.cs (Block.Emit): Only check the "this" variable if we
11109 do not always throw an exception.
11111 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
11112 whether the property has a set accessor.
11114 2002-08-11 Martin Baulig <martin@gnome.org>
11116 Added control flow analysis support for structs.
11118 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
11119 with control flow analysis turned off.
11120 (IVariable): New interface.
11121 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
11122 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
11123 (FieldExpr.DoResolve): Resolve the instance expression with flow
11124 analysis turned off and do the definite assignment check after the
11125 resolving when we know what the expression will resolve to.
11127 * expression.cs (LocalVariableReference, ParameterReference):
11128 Implement the new IVariable interface, only call the flow analysis
11129 code if ec.DoFlowAnalysis is true.
11130 (This): Added constructor which takes a Block argument. Implement
11131 the new IVariable interface.
11132 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
11133 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
11134 This does the definite assignment checks for struct members.
11136 * class.cs (Constructor.Emit): If this is a non-static `struct'
11137 constructor which doesn't have any initializer, call
11138 Block.AddThisVariable() to tell the flow analysis code that all
11139 struct elements must be initialized before control returns from
11142 * statement.cs (MyStructInfo): New public class.
11143 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
11144 argument to this indexer. If non-zero, check an individual struct
11145 member, not the whole struct.
11146 (FlowBranching.CheckOutParameters): Check struct members.
11147 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
11148 overloaded versions of these methods which take an additional
11149 `int field_idx' argument to check struct members.
11150 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
11151 overloaded versions of these methods which take an additional
11152 `string field_name' argument to check struct member.s
11153 (VariableInfo): Implement the IVariable interface.
11154 (VariableInfo.StructInfo): New public property. Returns the
11155 MyStructInfo instance of the variable if it's a struct or null.
11156 (Block.AddThisVariable): New public method. This is called from
11157 Constructor.Emit() for non-static `struct' constructor which do
11158 not have any initializer. It creates a special variable for the
11159 "this" instance variable which will be checked by the flow
11160 analysis code to ensure that all of the struct's fields are
11161 initialized before control returns from the constructor.
11162 (UsageVector): Added support for struct members. If a
11163 variable/parameter is a struct with N members, we reserve a slot
11164 in the usage vector for each member. A struct is considered fully
11165 initialized if either the struct itself (slot 0) or all its
11166 members are initialized.
11168 2002-08-08 Martin Baulig <martin@gnome.org>
11170 * driver.cs (Driver.MainDriver): Only report an error CS5001
11171 if there were no compilation errors.
11173 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
11174 `UnsafeContext' property to determine whether the parent is in
11175 unsafe context rather than checking the parent's ModFlags:
11176 classes nested in an unsafe class are unsafe as well.
11178 2002-08-08 Martin Baulig <martin@gnome.org>
11180 * statement.cs (UsageVector.MergeChildren): Distinguish between
11181 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
11182 we return. Added test17() and test18() to test-154.cs.
11184 2002-08-08 Martin Baulig <martin@gnome.org>
11186 * typemanager.cs (TypeManager.FilterWithClosure): If we have
11187 Family access, make sure the invoking type isn't a subclass of the
11188 queried type (that'd be a CS1540).
11190 * ecore.cs (Expression.MemberLookup): Added overloaded version of
11191 this method which takes an additional `Type invocation_type'.
11193 * expression.cs (BaseAccess.DoResolve): Use the base type as
11194 invocation and query type.
11195 (MemberAccess.DoResolve): If the lookup failed and we're about to
11196 report a CS0122, try a lookup with the ec.ContainerType - if this
11197 succeeds, we must report a CS1540.
11199 2002-08-08 Martin Baulig <martin@gnome.org>
11201 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
11202 (MethodGroupExpr): Implement the IMemberExpr interface.
11204 * expression (MemberAccess.ResolveMemberAccess): No need to have
11205 any special code for MethodGroupExprs anymore, they're now
11208 2002-08-08 Martin Baulig <martin@gnome.org>
11210 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
11211 Family, FamANDAssem and FamORAssem permissions.
11212 (TypeManager.IsSubclassOrNestedChildOf): New public method.
11214 2002-08-08 Martin Baulig <martin@gnome.org>
11216 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
11217 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
11220 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
11222 * driver.cs: implemented /resource option to embed managed resources.
11224 2002-08-07 Martin Baulig <martin@gnome.org>
11226 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
11227 (FieldBase.HasFieldInitializer): New public property.
11228 (FieldBase.GetInitializerExpression): New public method. Resolves and
11229 returns the field initializer and makes sure it is only resolved once.
11230 (TypeContainer.EmitFieldInitializers): Call
11231 FieldBase.GetInitializerExpression to get the initializer, this ensures
11232 that it isn't resolved multiple times.
11234 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
11235 the resolving process (SimpleName/MemberLookup) that we're currently
11236 emitting a field initializer (which must not access any instance members,
11237 this is an error CS0236).
11239 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
11240 argument, if the `IsFieldInitializer' flag is set, we must report and
11241 error CS0236 and not an error CS0120.
11243 2002-08-07 Martin Baulig <martin@gnome.org>
11245 * ecore.cs (IMemberExpr): New public interface.
11246 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
11247 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
11248 if the expression is an IMemberExpr.
11250 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
11251 to be null, implicitly default to `this' if we're non-static in
11252 this case. Simplified the code a lot by using the new IMemberExpr
11253 interface. Also fixed bug #28176 here.
11255 2002-08-06 Martin Baulig <martin@gnome.org>
11257 * cs-parser.jay (SimpleLookup): Removed. We need to create
11258 ParameterReferences during semantic analysis so that we can do a
11259 type-only search when resolving Cast, TypeOf and SizeOf.
11260 (block): Pass the `current_local_parameters' to the Block's
11263 * class.cs (ConstructorInitializer): Added `Parameters parameters'
11264 argument to the constructor.
11265 (ConstructorInitializer.Resolve): Create a temporary implicit
11266 block with the parameters.
11268 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
11269 references here if we aren't doing a type-only search.
11271 * statement.cs (Block): Added constructor which takes a
11272 `Parameters parameters' argument.
11273 (Block.Parameters): New public property.
11275 * support.cs (InternalParameters.Parameters): Renamed `parameters'
11276 to `Parameters' and made it public readonly.
11278 2002-08-06 Martin Baulig <martin@gnome.org>
11280 * ecore.cs (Expression.Warning): Made this public as well.
11282 * report.cs (Report.Debug): Print the contents of collections.
11284 2002-08-06 Martin Baulig <martin@gnome.org>
11286 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
11287 used to tell Resolve() which kinds of expressions it may return.
11288 (Expression.Resolve): Added overloaded version of this method which
11289 takes a `ResolveFlags flags' argument. This can be used to tell
11290 Resolve() which kinds of expressions it may return. Reports a
11292 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
11293 ResolveFlags.SimpleName.
11294 (Expression.Error118): Added overloaded version of this method which
11295 takes a `ResolveFlags flags' argument. It uses the flags to determine
11296 which kinds of expressions are allowed.
11298 * expression.cs (Argument.ResolveMethodGroup): New public method.
11299 Resolves an argument, but allows a MethodGroup to be returned.
11300 This is used when invoking a delegate.
11302 * TODO: Updated a bit.
11304 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11306 Fixed compilation with csc.
11308 * ecore.cs: Expression.Error made public. Is this correct? Should
11309 Warning be made public too?
11311 * expression.cs: use ea.Location instead of ea.loc.
11312 [FIXME: Filed as bug #28607: MCS must report these errors.]
11314 2002-08-06 Martin Baulig <martin@gnome.org>
11316 * ecore.cs (Expression.loc): Moved the location here instead of
11317 duplicating it in all derived classes.
11318 (Expression.Location): New public property.
11319 (Expression.Error, Expression.Warning): Made them non-static and
11320 removed the location argument.
11321 (Expression.Warning): Added overloaded version which takes an
11322 `int level' argument.
11323 (Expression.Error118): Make this non-static and removed the
11324 expression and location arguments.
11325 (TypeExpr): Added location argument to the constructor.
11327 * expression.cs (StaticCallExpr): Added location argument to
11329 (Indirection, PointerArithmetic): Likewise.
11330 (CheckedExpr, UnCheckedExpr): Likewise.
11331 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
11332 (StringPtr): Likewise.
11335 2002-08-05 Martin Baulig <martin@gnome.org>
11337 * expression.cs (BaseAccess.DoResolve): Actually report errors.
11339 * assign.cs (Assign.DoResolve): Check whether the source
11340 expression is a value or variable.
11342 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
11343 while resolving the corresponding blocks.
11345 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
11346 an error, don't silently return null.
11348 * statement.cs (Block.AddVariable): Do the error reporting here
11349 and distinguish between CS0128 and CS0136.
11350 (Block.DoResolve): Report all unused labels (warning CS0164).
11351 (LabeledStatement): Pass the location to the constructor.
11352 (LabeledStatement.HasBeenReferenced): New property.
11353 (LabeledStatement.Resolve): Set it to true here.
11355 * statement.cs (Return.Emit): Return success even after reporting
11356 a type mismatch error (CS0126 or CS0127), this is what csc does and
11357 it avoids confusing the users with any consecutive errors.
11359 2002-08-05 Martin Baulig <martin@gnome.org>
11361 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
11363 * const.cs (Const.LookupConstantValue): Catch circular definitions.
11365 * expression.cs (MemberAccess.DoResolve): Silently return if an
11366 error has already been reported.
11368 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
11369 error has already been reported.
11371 2002-08-05 Martin Baulig <martin@gnome.org>
11373 * statement.cs (UsageVector): Only initialize the `parameters'
11374 vector if we actually have any "out" parameters.
11376 2002-08-05 Martin Baulig <martin@gnome.org>
11378 * expression.cs (Binary.ResolveOperator): When combining delegates,
11379 they must have the same type.
11381 2002-08-05 Martin Baulig <martin@gnome.org>
11383 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
11384 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
11385 work with the ms runtime and we also don't need it: if we're a
11386 PropertyBuilder and not in the `indexer_arguments' hash, then we
11387 are a property and not an indexer.
11389 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
11390 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
11391 since the latter one doesn't work with the ms runtime.
11393 2002-08-03 Martin Baulig <martin@gnome.org>
11395 Fixed bugs #27998 and #22735.
11397 * class.cs (Method.IsOperator): New public field.
11398 (Method.CheckBase): Report CS0111 if there's already a method
11399 with the same parameters in the current class. Report CS0508 when
11400 attempting to change the return type of an inherited method.
11401 (MethodData.Emit): Report CS0179 if a method doesn't have a body
11402 and it's not marked abstract or extern.
11403 (PropertyBase): New abstract base class for Property and Indexer.
11404 (PropertyBase.CheckBase): Moved here from Property and made it work
11406 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
11407 the same so we can reuse it there.
11408 (Property, Indexer): Derive from PropertyBase.
11409 (MethodSignature.inheritable_property_signature_filter): New delegate
11410 to find properties and indexers.
11412 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
11413 argument and improved error reporting.
11415 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
11416 EmptyReadOnlyParameters and made it a property.
11418 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
11419 version of this method which takes a `PropertyInfo indexer'.
11420 (TypeManager.RegisterIndexer): New method.
11422 * class.cs: Added myself as author of this file :-)
11424 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11426 * class.cs: fixed compilation on windoze.
11428 2002-08-03 Martin Baulig <martin@gnome.org>
11430 * interface.cs (Interface.GetInterfaceBases): Check whether all
11431 base interfaces are at least as accessible than the current one.
11433 * class.cs (TypeContainer.GetClassBases): Check whether base types
11434 are at least as accessible than the current type.
11435 (TypeContainer.AsAccessible): Implemented and made non-static.
11436 (MemberBase.CheckParameters): Report errors if the accessibility
11439 * delegate.cs (Delegate.Delegate): The default visibility is
11440 internal for top-level types and private for nested types.
11441 (Delegate.Define): Report errors if the accessibility checks fail.
11443 * enum.cs (Enum.Enum): The default visibility is internal for
11444 top-level types and private for nested types.
11445 (Enum.DefineType): Compute the correct visibility.
11447 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
11448 function which takes a `bool is_toplevel' instead of a TypeContainer.
11450 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
11453 2002-08-02 Martin Baulig <martin@gnome.org>
11455 * expression.cs (LocalVariableReferenc): Added constructor which
11456 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
11457 (LocalVariableReference.IsReadOnly): New property.
11458 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
11459 variable is readonly, use our own readonly flag to do this; you can
11460 use the new constructor to get a writable reference to a read-only
11463 * cs-parser.jay (foreach_statement, using_statement): Get a writable
11464 reference to the local variable.
11466 2002-08-01 Miguel de Icaza <miguel@ximian.com>
11468 * rootcontext.cs (ResolveCore): Also include System.Exception
11470 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
11471 we reach an EmptyStatement.
11473 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
11476 * expression.cs (Binary.ResolveOperator): Check error result in
11479 use brtrue/brfalse directly and avoid compares to null.
11481 2002-08-02 Martin Baulig <martin@gnome.org>
11483 * class.cs (TypeContainer.Define): Define all nested interfaces here.
11484 Fixes bug #28407, added test-155.cs.
11486 2002-08-01 Martin Baulig <martin@gnome.org>
11488 * class.cs (Event.EmitDefaultMethod): Make this work with static
11489 events. Fixes #28311, added verify-3.cs.
11491 2002-08-01 Martin Baulig <martin@gnome.org>
11493 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
11494 `is_disposable' fields.
11495 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
11496 `hm.is_disposable' if we're using the collection pattern.
11497 (Foreach.EmitCollectionForeach): Use the correct type for the
11498 enumerator's local variable, only emit the try/finally block if
11499 necessary (fixes #27713).
11501 2002-08-01 Martin Baulig <martin@gnome.org>
11503 * ecore.cs (Expression.report118): Renamed to Error118 and made
11506 * statement.cs (Throw.Resolve): Check whether the expression is of
11507 the correct type (CS0118) and whether the type derives from
11508 System.Exception (CS0155).
11509 (Catch.Resolve): New method. Do the type lookup here and check
11510 whether it derives from System.Exception (CS0155).
11511 (Catch.CatchType, Catch.IsGeneral): New public properties.
11513 * typemanager.cs (TypeManager.exception_type): Added.
11515 2002-07-31 Miguel de Icaza <miguel@ximian.com>
11517 * driver.cs: Updated About function.
11519 2002-07-31 Martin Baulig <martin@gnome.org>
11521 Implemented Control Flow Analysis.
11523 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
11524 (EmitContext.CurrentBranching): Added.
11525 (EmitContext.StartFlowBranching): Added.
11526 (EmitContext.EndFlowBranching): Added.
11527 (EmitContext.KillFlowBranching): Added.
11528 (EmitContext.IsVariableAssigned): Added.
11529 (EmitContext.SetVariableAssigned): Added.
11530 (EmitContext.IsParameterAssigned): Added.
11531 (EmitContext.SetParameterAssigned): Added.
11532 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
11533 Added control flow analysis stuff here.
11535 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
11536 resolve the expression as lvalue.
11537 (LocalVariableReference.DoResolve): Check whether the variable has
11538 already been assigned.
11539 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
11540 the parameter as assigned here.
11541 (ParameterReference.DoResolve): Check whether the parameter has already
11543 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
11544 expression as lvalue.
11546 * statement.cs (FlowBranching): New class for the flow analysis code.
11547 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
11548 (LabeledStatement.IsDefined): New public property.
11549 (LabeledStatement.AddUsageVector): New public method to tell flow
11550 analyis that the label may be reached via a forward jump.
11551 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
11553 (VariableInfo.Number): New public field. This is used by flow analysis
11554 to number all locals of a block.
11555 (Block.CountVariables): New public property. This is the number of
11556 local variables in this block (including the locals from all parent
11558 (Block.EmitMeta): Number all the variables.
11560 * statement.cs: Added flow analysis support to all classes.
11562 2002-07-31 Martin Baulig <martin@gnome.org>
11564 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
11565 To get debugging messages, compile mcs with /define:MCS_DEBUG and
11566 then use this argument.
11568 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
11570 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
11571 use this to specify /define options.
11573 2002-07-29 Martin Baulig <martin@gnome.org>
11575 * statement.cs (Fixed): Moved all code that does variable lookups
11576 and resolvings from Emit to Resolve.
11578 * statement.cs (For): Moved all code that does variable lookups
11579 and resolvings from Emit to Resolve.
11581 * statement.cs (Using): Moved all code that does variable lookups
11582 and resolvings from Emit to Resolve.
11584 2002-07-29 Martin Baulig <martin@gnome.org>
11586 * attribute.cs (Attribute.Resolve): Explicitly catch a
11587 System.NullReferenceException when creating the
11588 CustromAttributeBuilder and report a different warning message.
11590 2002-07-29 Martin Baulig <martin@gnome.org>
11592 * support.cs (ParameterData.ParameterName): Added method to
11593 get the name of a parameter.
11595 * typemanager.cs (TypeManager.IsValueType): New public method.
11597 2002-07-29 Martin Baulig <martin@gnome.org>
11599 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
11600 is a flag which specifies that it's either ref or out.
11601 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
11602 the out parameter to `out Parameter.Modifier mod', also set the
11603 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
11605 * support.cs (InternalParameters.ParameterModifier): Distinguish
11606 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
11607 Parameter.Modifier.ISBYREF flag if it's either ref or out.
11609 * expression.cs (Argument.GetParameterModifier): Distinguish
11610 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
11611 Parameter.Modifier.ISBYREF flag if it's either ref or out.
11613 2002-07-29 Martin Baulig <martin@gnome.org>
11615 * expression.cs (ParameterReference.ParameterReference): Added
11616 `Location loc' argument to the constructor.
11618 * cs-parser.jay: Pass location to ParameterReference.
11620 2002-07-28 Miguel de Icaza <miguel@ximian.com>
11622 * statement.cs (Try): Initialize the location.
11624 * cs-parser.jay: pass location to Try.
11626 * expression.cs (Unary.Reduce): Change the prototype to return
11627 whether a constant fold could be performed or not. The result is
11628 returned in an out parameters. In the case of Indirection and
11629 AddressOf, we want to perform the full tests.
11631 2002-07-26 Miguel de Icaza <miguel@ximian.com>
11633 * statement.cs (Statement.Emit): Flag dead code.
11635 2002-07-27 Andrew Birkett <andy@nobugs.org>
11637 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
11639 2002-07-27 Martin Baulig <martin@gnome.org>
11641 * class.cs (MethodData.Define): Put back call to
11642 TypeManager.AddMethod(), accidentally commented this out.
11644 * report.cs (Debug): New public method to print debugging information,
11645 this is `[Conditional ("DEBUG")]'.
11647 2002-07-26 Martin Baulig <martin@gnome.org>
11649 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
11650 (switch_statement): Push the current_block to the switch_stack and
11651 pop it again when we're done with the switch.
11652 (switch_section): The new block is a child of the current_block.
11653 Fixes bug #24007, added test-152.cs.
11655 2002-07-27 Martin Baulig <martin@gnome.org>
11657 * expression.cs (Invocation.EmitArguments): When calling a varargs
11658 function with only its fixed arguments, we need to pass an empty
11661 2002-07-27 Martin Baulig <martin@gnome.org>
11663 Mono 0.13 has been released.
11665 2002-07-25 Miguel de Icaza <miguel@ximian.com>
11667 * driver.cs: Rename --resource to --linkres, because that is what
11668 we do currently, we dont support --resource yet.
11670 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
11672 2002-07-25 Martin Baulig <martin@gnome.org>
11674 * class.cs (MethodData): New public class. This is a `method builder'
11675 class for a method or one accessor of a Property/Indexer/Event.
11676 (MethodData.GetMethodFlags): Moved here from MemberBase.
11677 (MethodData.ApplyAttributes): Likewise.
11678 (MethodData.ApplyObsoleteAttribute): Likewise.
11679 (MethodData.ApplyConditionalAttribute): Likewise.
11680 (MethodData.ApplyDllImportAttribute): Likewise.
11681 (MethodData.CheckAbstractAndExternal): Likewise.
11682 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
11683 (MethodData.Emit): Formerly known as Method.Emit().
11684 (MemberBase): Moved everything which was specific to a single
11685 accessor/method to MethodData.
11686 (Method): Create a new MethodData and call Define() and Emit() on it.
11687 (Property, Indexer, Event): Create a new MethodData objects for each
11688 accessor and call Define() and Emit() on them.
11690 2002-07-25 Martin Baulig <martin@gnome.org>
11692 Made MethodCore derive from MemberBase to reuse the code from there.
11693 MemberBase now also checks for attributes.
11695 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
11696 (MemberBase.GetMethodFlags): Moved here from class Method and marked
11698 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
11699 `CallingConventions cc' and `Attributes opt_attrs' arguments.
11700 (MemberBase.ApplyAttributes): New virtual method; applies the
11701 attributes to a method or accessor.
11702 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
11703 (MemberBase.ApplyConditionalAttribute): Likewise.
11704 (MemberBase.ApplyDllImportAttribute): Likewise.
11705 (MemberBase.CheckAbstractAndExternal): Likewise.
11706 (MethodCore.ParameterTypes): This is now a property instead of a
11707 method, it's initialized from DoDefineParameters().
11708 (MethodCore.ParameterInfo): Removed the set accessor.
11709 (MethodCore.DoDefineParameters): New protected virtual method to
11710 initialize ParameterTypes and ParameterInfo.
11711 (Method.GetReturnType): We can now simply return the MemberType.
11712 (Method.GetMethodFlags): Override the MemberBase version and add
11713 the conditional flags.
11714 (Method.CheckBase): Moved some code from Define() here, call
11715 DoDefineParameters() here.
11716 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
11717 here to avoid some larger code duplication.
11718 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
11719 ensure that abstract and external accessors don't declare a body.
11721 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
11722 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
11723 lookup in the attribute's parent classes, so we need to abort as soon
11724 as we found the first match.
11725 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
11726 the attribute has no arguments.
11728 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
11731 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11733 * cs-parser.jay: reverted previous patch.
11735 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11737 * cs-parser.jay: fixed bug #22119.
11739 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11741 * attribute.cs: fixed compilation. The error was:
11742 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
11743 be assigned to before control leaves the current method."
11744 [FIXME: Filed as bug #28186: MCS must report this error.]
11746 2002-07-25 Martin Baulig <martin@gnome.org>
11748 * attribute.cs (Attribute.Conditional_GetConditionName): New static
11749 method to pull the condition name ouf of a Conditional attribute.
11750 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
11751 the obsolete message and error flag out of an Obsolete attribute.
11753 * class.cs (Method.GetMethodFlags): New public method to get the
11754 TypeManager.MethodFlags for this method.
11755 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
11757 (Method.Define): Get and apply the Obsolete and Conditional attributes;
11758 if we're overriding a virtual function, set the new private variable
11759 `parent_method'; call the new TypeManager.AddMethod().
11761 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
11762 the MethodBuilder and the Method in a PtrHashtable.
11763 (TypeManager.builder_to_method): Added for this purpose.
11764 (TypeManager.MethodFlags): Added IsObsoleteError.
11765 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
11766 Obsolete and Conditional arguments in MethodBuilders. If we discover
11767 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
11768 the message from the attribute.
11770 2002-07-24 Martin Baulig <martin@gnome.org>
11772 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
11773 preprocessor directives, ensure that the argument to #define/#undef is
11774 exactly one identifier and that it's actually an identifier.
11776 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
11779 2002-07-24 Martin Baulig <martin@gnome.org>
11781 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
11782 initialize it to TypeManager.object_type in the constructor.
11783 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
11784 of the `hm.get_current' method if we're using the collection pattern.
11785 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
11786 for the explicit conversion to make it work when we're using the collection
11787 pattern and the `Current' property has a different return type than `object'.
11790 2002-07-24 Martin Baulig <martin@gnome.org>
11792 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
11793 does not match, but don't report any errors. This method is called in
11794 order for all methods in a MethodGroupExpr until a matching method is
11795 found, so we don't want to bail out if the first method doesn't match.
11796 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
11797 matches, report the 123. Fixes #28070.
11799 2002-07-24 Martin Baulig <martin@gnome.org>
11801 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
11802 TypeManager.TypeToCoreType() to the top of the method so the
11803 following equality checks will work. Fixes #28107.
11805 2002-07-24 Martin Baulig <martin@gnome.org>
11807 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
11808 operand is of type uint, and the other operand is of type sbyte,
11809 short or int, the operands are converted to type long." -
11810 Actually do what this comment already told us. Fixes bug #28106,
11813 2002-07-24 Martin Baulig <martin@gnome.org>
11815 * class.cs (MethodBase): New abstract class. This is now a base
11816 class for Property, Indexer and Event to avoid some code duplication
11817 in their Define() and DefineMethods() methods.
11818 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
11819 generic methods for Define() and DefineMethods().
11820 (FieldBase): Derive from MemberBase, not MemberCore.
11821 (Property): Derive from MemberBase, not MemberCore.
11822 (Property.DefineMethod): Moved all the code from this method to the
11823 new MethodBase.DefineAccessor(), just call it with appropriate
11825 (Property.Define): Call the new Property.DoDefine(), this does some
11826 sanity checks and we don't need to duplicate the code everywhere.
11827 (Event): Derive from MemberBase, not MemberCore.
11828 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
11829 accessors, this will also make them work with interface events.
11830 (Indexer): Derive from MemberBase, not MemberCore.
11831 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
11832 (Indexer.Define): Use the new MethodBase functions.
11834 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
11835 argument to the constructor.
11836 (Interface.FindMembers): Added support for interface events.
11837 (Interface.PopluateEvent): Implemented.
11839 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
11841 2002-07-22 Miguel de Icaza <miguel@ximian.com>
11843 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
11844 but this is required to check for a method name being the same as
11845 the containing class.
11849 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11851 * interface.cs: initialize variable.
11853 2002-07-23 Martin Baulig <martin@gnome.org>
11855 Implemented the IndexerName attribute in interfaces.
11857 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
11858 name if this is an explicit interface implementation.
11859 (Indexer.InterfaceIndexerName): New public variable. If we're
11860 implementing an interface indexer, this is the IndexerName in that
11861 interface. Otherwise, it's the IndexerName.
11862 (Indexer.DefineMethod): If we're implementing interface indexer,
11863 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
11864 and Pending.ImplementIndexer methods.
11865 (Indexer.Define): Also define the PropertyBuilder if we're
11866 implementing an interface indexer and this is neither an explicit
11867 interface implementation nor do the IndexerName match the one in
11870 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
11871 If a method is defined here, then we always need to create a proxy
11872 for it. This is used when implementing interface indexers.
11873 (Pending.IsInterfaceIndexer): New public method.
11874 (Pending.ImplementIndexer): New public method.
11875 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
11876 This is used when implementing interface indexers to define a proxy
11878 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
11879 define a proxy if necessary.
11881 * interface.cs (Interface.IndexerName): New public variable.
11882 (Interface.PopulateIndexer): Set the IndexerName.
11883 (Interface.DefineIndexers): New private method. Populate all the
11884 indexers and make sure their IndexerNames match.
11886 * typemanager.cs (IndexerPropertyName): Added support for interface
11889 2002-07-22 Martin Baulig <martin@gnome.org>
11891 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
11892 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
11893 ret if HasReturnLabel.
11894 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
11897 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
11898 and set the ec.LoopBeginTryCatchLevel.
11899 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
11900 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
11901 the current ec.TryCatchLevel, the branch goes out of an exception
11902 block. In this case, we need to use Leave and not Br.
11904 2002-07-22 Martin Baulig <martin@gnome.org>
11906 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
11907 block unless the block does not always return or it is contained in
11908 another try { ... } catch { ... } block. Fixes bug #26506.
11909 Added verify-1.cs to the test suite.
11911 2002-07-22 Martin Baulig <martin@gnome.org>
11913 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
11914 then we do not always return. Fixes bug #24985.
11916 2002-07-22 Martin Baulig <martin@gnome.org>
11918 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
11919 lookup on a per-class level; ie. walk up the class hierarchy until we
11920 found at least one applicable method, then choose the best among them.
11921 Fixes bug #24463 and test-29.cs.
11923 2002-07-22 Martin Baulig <martin@gnome.org>
11925 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
11926 return types of the methods. The return type is not part of the
11927 signature and we must not check it to make the `new' modifier work.
11928 Fixes bug #27999, also added test-147.cs.
11929 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
11931 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
11932 on the method's return type.
11934 2002-07-21 Martin Baulig <martin@gnome.org>
11936 * assign.cs: Make this work if the rightmost source is a constant and
11937 we need to do an implicit type conversion. Also adding a few more tests
11938 to test-38.cs which should have caught this.
11940 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
11941 target in the makefile for this. The makefile.gnu is primarily intended
11942 for end-users who don't want to debug the compiler.
11944 2002-07-21 Martin Baulig <martin@gnome.org>
11946 * assign.cs: Improved the Assign class so it can now handle embedded
11947 assignments (X = Y = Z = something). As a side-effect this'll now also
11948 consume less local variables. test-38.cs now passes with MCS, added
11949 a few new test cases to that test.
11951 2002-07-20 Martin Baulig <martin@gnome.org>
11953 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
11954 instructions. Fixes bug #27977, also added test-146.cs.
11956 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11958 * cs-tokenizer.cs: fixed getHex ().
11960 2002-07-19 Martin Baulig <martin@gnome.org>
11962 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
11963 not Type.GetType() to lookup the array type. This is needed when
11964 we're constructing an array of a user-defined type.
11965 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
11966 single-dimensional arrays, but also for single-dimensial arrays of
11969 2002-07-19 Martin Baulig <martin@gnome.org>
11971 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
11972 this function is called, it's not allowed to share LocalBuilders
11973 among ILGenerators.
11975 2002-07-19 Martin Baulig <martin@gnome.org>
11977 * expression.cs (Argument.Resolve): Report an error 118 when trying
11978 to pass a type as argument.
11980 2002-07-18 Martin Baulig <martin@gnome.org>
11982 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
11983 Conv_R_Un for the signed `long' type.
11985 2002-07-15 Miguel de Icaza <miguel@ximian.com>
11987 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
11988 `expr' for the temporary result, as that will fail if we do
11989 multiple resolves on the same expression.
11991 2002-07-05 Miguel de Icaza <miguel@ximian.com>
11993 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
11994 ec.TypeContainer for looking up aliases.
11996 * class.cs (TypeContainer): Remove LookupAlias from here.
11998 * decl.cs (DeclSpace); Move here.
12000 2002-07-01 Miguel de Icaza <miguel@ximian.com>
12002 * class.cs (FindMembers): Only call filter if the constructor
12003 bulider is not null.
12005 Also handle delegates in `NestedTypes' now. Now we will perform
12006 type lookups using the standard resolution process. This also
12009 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
12010 This uses Expressions (the limited kind that can be parsed by the
12011 tree) instead of strings.
12013 * expression.cs (ComposedCast.ToString): Implement, used to flag
12014 errors since now we have to render expressions.
12016 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
12019 * ecore.cs (SimpleName.ToString): ditto.
12021 * cs-parser.jay: Instead of using strings to assemble types, use
12022 Expressions to assemble the type (using SimpleName, ComposedCast,
12023 MemberAccess). This should fix the type lookups in declarations,
12024 because we were using a different code path for this.
12026 * statement.cs (Block.Resolve): Continue processing statements
12027 even when there is an error.
12029 2002-07-17 Miguel de Icaza <miguel@ximian.com>
12031 * class.cs (Event.Define): Also remove the `remove' method from
12032 the list of pending items.
12034 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
12035 generate more compact code.
12037 2002-07-17 Martin Baulig <martin@gnome.org>
12039 * const.cs (Const.LookupConstantValue): Add support for constant
12040 `unchecked' and `checked' expressions.
12041 Also adding test case test-140.cs for this.
12043 2002-07-17 Martin Baulig <martin@gnome.org>
12045 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
12046 check whether mi.ReturnType implements the IEnumerator interface; the
12047 `==' and the IsAssignableFrom() will fail in this situation.
12049 2002-07-16 Ravi Pratap <ravi@ximian.com>
12051 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
12054 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
12056 * expression.cs: fixed bug #27811.
12058 2002-07-14 Miguel de Icaza <miguel@ximian.com>
12060 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
12061 Molaro: when we are a ref, the value already contains a pointer
12062 value, do not take the address of it.
12064 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
12065 * removed mb-parser.jay and mb-tokenizer.cs
12067 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
12069 * expression.cs: check against the building corlib void type.
12071 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
12073 * ecore.cs: fix for valuetype static readonly fields: when
12074 initializing them, we need their address, not the address of a copy.
12076 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
12078 * typemanager.cs: register also enum_type in corlib.
12080 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
12082 * class.cs: allow calling this (but not base) initializers in structs.
12084 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
12086 * ecore.cs: make sure we compare against the building base types
12089 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
12091 * typemanager.cs: fix TypeToCoreType() to handle void and object
12092 (corlib gets no more typerefs after this change).
12094 2002-07-12 Miguel de Icaza <miguel@ximian.com>
12096 * expression.cs (ArrayCreation.EmitArrayArguments): use
12097 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
12099 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
12100 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
12101 array indexes, the runtime actually forbids them.
12103 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
12104 for array arguments here.
12106 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
12107 instead of the default for ValueTypes.
12109 (New.DoEmit): Use IsValueType instead of
12110 IsSubclassOf (value_type)
12111 (New.DoResolve): ditto.
12112 (Invocation.EmitCall): ditto.
12114 * assign.cs (Assign): ditto.
12116 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
12117 Statements *are* currently doing part of their resolution during
12120 Expressions do always resolve during resolve, but statements are
12121 only required to propagate resolution to their children.
12123 2002-07-11 Miguel de Icaza <miguel@ximian.com>
12125 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
12127 (LoadAssembly): Do not add the dll if it is already specified
12129 (MainDriver): Add the System directory to the link path at the end,
12130 after all the other -L arguments.
12132 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
12133 wrong opcode for loading bytes and bools (ldelem.i1 instead of
12134 ldelem.u1) and using the opposite for sbytes.
12136 This fixes Digger, and we can finally run it.
12138 * driver.cs (UnixParseOption): Move the option parsing here.
12139 (CSCParseOption): Implement CSC-like parsing of options.
12141 We now support both modes of operation, the old Unix way, and the
12142 new CSC-like way. This should help those who wanted to make cross
12143 platform makefiles.
12145 The only thing broken is that /r:, /reference: and /lib: are not
12146 implemented, because I want to make those have the same semantics
12147 as the CSC compiler has, and kill once and for all the confussion
12148 around this. Will be doing this tomorrow.
12150 * statement.cs (Unsafe.Resolve): The state is checked during
12151 resolve, not emit, so we have to set the flags for IsUnsfe here.
12153 2002-07-10 Miguel de Icaza <miguel@ximian.com>
12155 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
12156 not catch the Error_ObjectRefRequired in SimpleName (as it is
12157 possible to have a class/instance variable name that later gets
12158 deambiguated), we have to check this here.
12160 2002-07-10 Ravi Pratap <ravi@ximian.com>
12162 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
12163 make static and put into Expression.
12165 (Event.Define): Register the private field of the event with the
12166 TypeManager so that GetFieldFromEvent can get at it.
12168 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
12169 keep track of the private field associated with an event which
12172 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
12175 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
12177 2002-07-10 Miguel de Icaza <miguel@ximian.com>
12179 * expression.cs (Binary.EmitBranchable): this routine emits the
12180 Binary expression in a branchable context. This basically means:
12181 we need to branch somewhere, not just get the value on the stack.
12183 This works together with Statement.EmitBoolExpression.
12185 * statement.cs (Statement.EmitBoolExpression): Use
12188 2002-07-09 Miguel de Icaza <miguel@ximian.com>
12190 * statement.cs (For): Reduce the number of jumps in loops.
12192 (For): Implement loop inversion for the For statement.
12194 (Break): We can be breaking out of a Try/Catch controlled section
12195 (foreach might have an implicit try/catch clause), so we need to
12196 use Leave instead of Br.
12198 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
12199 now). If the instace expression supports IMemoryLocation, we use
12200 the AddressOf method from the IMemoryLocation to extract the
12201 address instead of emitting the instance.
12203 This showed up with `This', as we were emitting the instance
12204 always (Emit) instead of the Address of This. Particularly
12205 interesting when This is a value type, as we dont want the Emit
12206 effect (which was to load the object).
12208 2002-07-08 Miguel de Icaza <miguel@ximian.com>
12210 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
12212 * statement.cs (Checked): Set the CheckedState during the resolve
12213 process too, as the ConvCast operations track the checked state on
12214 the resolve process, and not emit.
12216 * cs-parser.jay (namespace_member_declaration): Flag that we have
12217 found a declaration when we do. This is used to flag error 1529
12219 * driver.cs: Report ok when we display the help only.
12221 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
12223 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
12225 2002-07-04 Miguel de Icaza <miguel@ximian.com>
12227 * cs-tokenizer.cs (define): We also have to track locally the
12228 defines. AllDefines is just used for the Conditional Attribute,
12229 but we also need the local defines for the current source code.
12231 2002-07-03 Miguel de Icaza <miguel@ximian.com>
12233 * statement.cs (While, For, Do): These loops can exit through a
12234 Break statement, use this information to tell whether the
12235 statement is the last piece of code.
12237 (Break): Flag that we break.
12239 * codegen.cs (EmitContexts): New `Breaks' state variable.
12241 2002-07-03 Martin Baulig <martin@gnome.org>
12243 * class.cs (TypeContainer.MethodModifiersValid): Allow override
12244 modifiers in method declarations in structs. Otherwise, you won't
12245 be able to override things like Object.Equals().
12247 2002-07-02 Miguel de Icaza <miguel@ximian.com>
12249 * class.cs (Method, Property, Indexer): Do not allow the public
12250 modifier to be used in explicit interface implementations.
12252 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
12253 override modifiers in method declarations in structs
12255 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
12257 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
12258 integer or real overflow, report an error
12260 2002-07-02 Martin Baulig <martin@gnome.org>
12262 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
12263 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
12264 to tell the runtime about our newly created System.Object and
12265 System.ValueType types.
12267 2002-07-02 Miguel de Icaza <miguel@ximian.com>
12269 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
12270 struct instead of Ldarg/Starg.
12272 2002-07-02 Martin Baulig <martin@gnome.org>
12274 * expression.cs (Indirection.Indirection): Call
12275 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
12277 2002-07-02 Martin Baulig <martin@gnome.org>
12279 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
12280 ValueType, call TypeManager.TypeToCoreType() on it.
12281 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
12282 the OpCodes.Newarr argument.
12284 2002-07-02 Martin Baulig <martin@gnome.org>
12286 * expression.cs (Invocation.EmitCall): When compiling corlib,
12287 replace all calls to the system's System.Array type to calls to
12288 the newly created one.
12290 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
12291 System.Array methods.
12292 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
12293 from the system's System.Array type which must be replaced.
12295 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
12297 * typemanager.cs: load unverifiable_code_ctor so we can build
12298 corlib using the correct type. Avoid using GetTypeCode() with
12300 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
12301 TypeManager.object_type to allow building corlib.
12303 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
12305 * ecore.cs: handle System.Enum separately in LoadFromPtr().
12307 2002-07-01 Martin Baulig <martin@gnome.org>
12309 * class.cs: Make the last change actually work, we need to check
12310 whether `ifaces != null' to avoid a crash.
12312 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
12314 * class.cs: when we build structs without fields that implement
12315 interfaces, we need to add the interfaces separately, since there is
12316 no API to both set the size and add the interfaces at type creation
12319 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
12321 * expression.cs: the dimension arguments to the array constructors
12322 need to be converted if they are a long.
12324 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
12326 * class.cs: don't emit ldarg.0 if there is no parent constructor
12327 (fixes showstopper for corlib).
12329 2002-06-29 Martin Baulig <martin@gnome.org>
12331 MCS now compiles corlib on GNU/Linux :-)
12333 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
12334 ie. check for MethodImplOptions.InternalCall.
12336 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
12337 and TypeManager.attribute_type are null, so we must explicitly check
12338 whether parent is not null to find out whether it's an attribute type.
12339 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
12340 and SetBuilder, not only if the property is neither abstract nor external.
12341 This is necessary to set the MethodImplOptions on the accessor methods.
12342 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
12343 SetBuilder, see Property.Emit().
12345 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
12346 populate "System.Object", "System.ValueType" and "System.Attribute" since
12347 they've already been populated from BootCorlib_PopulateCoreTypes().
12349 2002-06-29 Martin Baulig <martin@gnome.org>
12351 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
12352 is the NullLiteral, we also need to make sure that target_type is not
12355 2002-06-29 Martin Baulig <martin@gnome.org>
12357 * rootcontext.cs (RootContext.ResolveCore): We must initialize
12358 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
12359 before calling BootstrapCorlib_ResolveDelegate ().
12361 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
12363 * statement.cs: fixed build-breaker. All tests passed ok.
12365 2002-06-27 Martin Baulig <martin@gnome.org>
12367 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
12368 for System.Decimal when compiling corlib.
12370 2002-06-27 Martin Baulig <martin@gnome.org>
12372 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
12373 switch blocks which contain nothing but a default clause.
12375 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
12377 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
12379 2002-06-27 Martin Baulig <martin@gnome.org>
12381 * ecore.cs (PropertyExpr.PropertyExpr): Call
12382 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
12384 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
12385 is already a TypeBuilder.
12387 2002-06-27 Martin Baulig <martin@gnome.org>
12389 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
12390 `target_type == TypeManager.array_type', not IsAssignableFrom() in
12391 the "from an array-type to System.Array" case. This makes it work
12392 when compiling corlib.
12394 2002-06-27 Martin Baulig <martin@gnome.org>
12396 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
12397 non-static PropertyExpr, set its InstanceExpression. This makes
12398 the `ICollection.Count' property work in System/Array.cs.
12400 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
12402 * driver.cs: Made error handling more consistent. Errors now
12403 tracked by Report class, so many methods which used to return int
12404 now return void. Main() now prints success/failure and
12405 errors/warnings message.
12407 Renamed '--probe' compiler argument to '--expect-error'. Removed
12408 the magic number return values (123 and 124). Now, if the
12409 expected error occurs, the compiler exits with success (exit value
12410 0). If the compilation completes without seeing that particular
12411 error, the compiler exits with failure (exit value 1). The
12412 makefile in mcs/errors has been changed to handle the new behaviour.
12414 * report.cs: Made 'expected error' number a property and renamed
12415 it from 'Probe' to 'ExpectedError'.
12417 * genericparser.cs: Removed error handling support, since it is
12418 now all done by Report class.
12420 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
12421 class, so parse() no longer returns an int.
12423 * namespace.cs: Use Report.Error instead of GenericParser.error
12425 2002-06-22 Miguel de Icaza <miguel@ximian.com>
12427 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
12428 TypeContainer.AddOperator): At the front of the list put the
12429 explicit implementations, so they get resolved/defined first.
12431 2002-06-21 Miguel de Icaza <miguel@ximian.com>
12433 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
12434 interface type is implemented by this TypeContainer. Used during
12435 explicit interface implementation.
12437 (Property.Define, Indexer.Define, Method.Define): Validate that
12438 the given interface in the explicit implementation is one of the
12439 base classes for the containing type.
12441 Also if we are explicitly implementing an interface, but there is
12442 no match in the pending implementation table, report an error.
12444 (Property.Define): Only define the property if we are
12445 not explicitly implementing a property from an interface. Use the
12446 correct name also for those properties (the same CSC uses,
12447 although that is really not needed).
12449 (Property.Emit): Do not emit attributes for explicitly implemented
12450 properties, as there is no TypeBuilder.
12452 (Indexer.Emit): ditto.
12454 Hiding then means that we do not really *implement* a pending
12455 implementation, which makes code fail.
12457 2002-06-22 Martin Baulig <martin@gnome.org>
12459 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
12460 the return value of Object.GetType(). [FIXME: we need to do this whenever
12461 we get a type back from the reflection library].
12463 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
12465 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
12467 2002-06-20 Miguel de Icaza <miguel@ximian.com>
12469 * attribute.cs: Return null if we can not look up the type.
12471 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
12472 the interface types found.
12474 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
12475 interface types found.
12477 * typemanager.cs (GetInterfaces): Make this routine returns alll
12478 the interfaces and work around the lame differences between
12479 System.Type and System.Reflection.Emit.TypeBuilder in the results
12480 result for GetInterfaces.
12482 (ExpandInterfaces): Given an array of interface types, expand and
12483 eliminate repeated ocurrences of an interface. This expands in
12484 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
12487 2002-06-21 Martin Baulig <martin@gnome.org>
12489 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
12492 2002-06-21 Martin Baulig <martin@gnome.org>
12494 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
12495 and called with one of the core types, return the corresponding typebuilder for
12498 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
12501 2002-06-21 Martin Baulig <martin@gnome.org>
12503 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
12504 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
12505 (Expression.ConvertReferenceExplicit): Likewise.
12507 * expression.cs (ElementAccess.DoResolve): Likewise.
12508 (ElementAccess.DoResolveLValue): Likewise.
12510 2002-06-10 Martin Baulig <martin@gnome.org>
12512 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
12513 add the "value" parameter to the parameter list.
12515 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
12518 2002-06-19 Miguel de Icaza <miguel@ximian.com>
12520 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
12521 the argument to an int, uint, long or ulong, per the spec. Also
12522 catch negative constants in array creation.
12524 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
12526 * class.cs: do not allow the same interface to appear twice in
12527 the definition list.
12529 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
12531 * ecore.cs: don't use ldlen with System.Array.
12533 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
12535 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
12537 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
12539 * modifiers.cs: produce correct field attributes for protected
12540 internal. Easy fix so miguel can work on ther harder stuff:-)
12542 2002-06-18 Miguel de Icaza <miguel@ximian.com>
12544 * pending.cs: New file. Move the code from class.cs here.
12545 Support clearning the pending flag for all methods (when not doing
12546 explicit interface implementation).
12548 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
12550 * rootcontext.cs: added a couple more types needed to bootstrap.
12552 2002-06-17 Miguel de Icaza <miguel@ximian.com>
12554 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
12555 constructor in the type, instead of any constructor in the type
12556 hierarchy. Thanks to Paolo for finding this bug (it showed up as
12557 a bug in the Mono runtime when applying the params attribute).
12559 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
12560 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
12562 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
12564 * expression.cs (Unary.ResolveOperator): Use TypeManager
12565 to resolve the type.
12567 2002-06-13 Ravi Pratap <ravi@ximian.com>
12569 * cs-parser.jay (enum_member_declaration): Pass in the attributes
12572 * enum.cs (AddEnumMember): Add support to store the attributes associated
12573 with each member too.
12575 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
12576 field builders too - this takes care of the enum member case.
12578 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
12580 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
12581 address-of operator on both value types and pointers.
12583 2002-06-10 Martin Baulig <martin@gnome.org>
12585 * interface.cs (Interface.PopulateIndexer): Add the indexer's
12586 PropertyBuilder to the `property_builders' list.
12588 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
12589 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
12590 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
12591 find any indexers which are inherited from an interface.
12593 2002-06-09 Martin Baulig <martin@gnome.org>
12595 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
12596 the same type as the constant if necessary. There's also a test-130.cs
12599 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
12601 * typemanager.cs (TypeManager.ChangeType): Previously known as
12602 Enum.ChangeEnumType().
12604 2002-06-09 Martin Baulig <martin@gnome.org>
12606 * expression.cs (Cast.TryReduce): Added support for consts.
12608 2002-06-08 Ravi Pratap <ravi@ximian.com>
12610 * class.cs (Accessor): Hold attributes information so we can pass
12613 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
12614 Modify to pass in attributes attached to the methods.
12616 (add_accessor_declaration, remove_accessor_declaration): Ditto.
12618 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
12619 to handle the Accessor kind :-)
12621 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
12623 2002-06-08 Martin Baulig <martin@gnome.org>
12625 * expression.cs (Unary.TryReduceNegative): Added support for
12628 2002-06-08 Martin Baulig <martin@gnome.org>
12630 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
12631 name can't be found in the `defined_names' - the caller will do a
12632 MemberLookup in this case and thus find methods in System.Enum
12633 such as Enum.IsDefined().
12635 2002-06-08 Martin Baulig <martin@gnome.org>
12637 * enum.cs (Enum.ChangeEnumType): This is a custom version of
12638 Convert.ChangeType() which works with TypeBuilder created types.
12639 (Enum.LookupEnumValue, Enum.Define): Use it here.
12641 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
12642 `TypeBuilder.BaseType != null' check.
12643 (TypeContainer.FindMembers): Only lookup parent members if we
12644 actually have a parent.
12645 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
12646 (ConstructorInitializer.Resolve): Likewise.
12648 * interface.cs (Interface.FindMembers): Added
12649 `TypeBuilder.BaseType != null' check.
12651 * rootcontext.cs (RootContext.ResolveCore): Added
12652 "System.Runtime.CompilerServices.IndexerNameAttribute" to
12653 classes_second_stage.
12655 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
12656 debug_type and trace_type when compiling with --nostdlib.
12658 2002-06-07 Martin Baulig <martin@gnome.org>
12660 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
12661 (AddField): Set it to true when adding a non-static field.
12662 (DefineType): Use `have_nonstatic_fields' to find out whether we
12663 have non-static fields, not `Fields != null'.
12665 2002-06-02 Miguel de Icaza <miguel@ximian.com>
12667 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
12668 dereferencing a null on the static-field code path)
12670 2002-05-30 Martin Baulig <martin@gnome.org>
12672 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
12673 to take command line arguments. Use reflection to call the new
12674 custom `Initialize' function on the symbol writer and pass it the
12675 command line arguments.
12677 * driver.cs (--debug-args): New command line argument to pass command
12678 line arguments to the symbol writer.
12680 2002-05-28 Miguel de Icaza <miguel@ximian.com>
12682 * assign.cs (DoResolve): Forgot to do the implicit conversion to
12683 the target type for indexers and properties. Thanks to Joe for
12686 2002-05-27 Miguel de Icaza <miguel@ximian.com>
12688 * typemanager.cs (MethodFlags): returns the method flags
12689 (Obsolete/ShouldIgnore) that control warning emission and whether
12690 the invocation should be made, or ignored.
12692 * expression.cs (Invocation.Emit): Remove previous hack, we should
12693 not do this on matching a base type, we should do this based on an attribute
12695 Only emit calls to System.Diagnostics.Debug and
12696 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
12697 on the command line.
12699 * rootcontext.cs: Global settings for tracing and debugging.
12701 * cs-tokenizer.cs (define): New utility function to track
12702 defines. Set the global settings for TRACE and DEBUG if found.
12704 2002-05-25 Ravi Pratap <ravi@ximian.com>
12706 * interface.cs (Populate*): Pass in the TypeContainer as well as
12707 the DeclSpace as parameters so that we can create EmitContexts and
12708 then use that to apply attributes etc.
12710 (PopulateMethod, PopulateEvent, PopulateProperty)
12711 (PopulateIndexer): Apply attributes everywhere.
12713 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
12716 (ApplyAttributes): Update accordingly.
12718 We now apply interface attributes for all members too.
12720 2002-05-26 Miguel de Icaza <miguel@ximian.com>
12722 * class.cs (Indexer.Define); Correctly check if we are explicit
12723 implementation (instead of checking the Name for a ".", we
12724 directly look up if the InterfaceType was specified).
12726 Delay the creation of the PropertyBuilder.
12728 Only create the PropertyBuilder if we are not an explicit
12729 interface implementation. This means that explicit interface
12730 implementation members do not participate in regular function
12731 lookups, and hence fixes another major ambiguity problem in
12732 overload resolution (that was the visible effect).
12734 (DefineMethod): Return whether we are doing an interface
12737 * typemanager.cs: Temporary hack until we get attributes in
12738 interfaces (Ravi is working on that) and we get IndexerName
12739 support in interfaces.
12741 * interface.cs: Register the indexers as properties.
12743 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
12744 warning, I have verified that this is a bug in the .NET runtime
12745 (JavaScript suffers of the same problem).
12747 * typemanager.cs (MemberLookup): When looking up members for
12748 interfaces, the parent of an interface is the implicit
12749 System.Object (so we succeed in searches of Object methods in an
12750 interface method invocation. Example: IEnumerable x; x.ToString
12753 2002-05-25 Miguel de Icaza <miguel@ximian.com>
12755 * class.cs (Event): Events should also register if they do
12756 implement the methods that an interface requires.
12758 * typemanager.cs (MemberLookup); use the new GetInterfaces
12761 (GetInterfaces): The code used to lookup interfaces for a type is
12762 used in more than one place, factor it here.
12764 * driver.cs: Track the errors at the bottom of the file, we kept
12767 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
12768 instance if the method we are calling is static!
12770 2002-05-24 Miguel de Icaza <miguel@ximian.com>
12772 * attribute.cs (ApplyAttributes): Make this function filter out
12773 the IndexerName attribute (as that attribute in reality is never
12774 applied) and return the string constant for the IndexerName
12777 * class.cs (TypeContainer.Emit): Validate that all the indexers
12778 have the same IndexerName attribute, and if so, set the
12779 DefaultName attribute on the class.
12781 * typemanager.cs: The return value might contain other stuff (not
12782 only methods). For instance, consider a method with an "Item"
12783 property and an Item method.
12785 * class.cs: If there is a problem with the parameter types,
12788 2002-05-24 Ravi Pratap <ravi@ximian.com>
12790 * ecore.cs (ImplicitConversionExists): Wrapper function which also
12791 looks at user defined conversion after making a call to
12792 StandardConversionExists - we need this for overload resolution.
12794 * expression.cs : Update accordingly the various method calls.
12796 This fixes 2 bugs filed against implicit user defined conversions
12798 2002-05-22 Miguel de Icaza <miguel@ximian.com>
12800 * statement.cs: Track the result of the assignment.
12802 2002-05-21 Miguel de Icaza <miguel@ximian.com>
12804 * expression.cs (MemberAccess): Improved error reporting for
12805 inaccessible members.
12807 2002-05-22 Martin Baulig <martin@gnome.org>
12809 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
12810 itself with debugging support.
12812 2002-05-22 Martin Baulig <martin@gnome.org>
12814 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
12815 Removed, this isn't needed anymore.
12817 2002-05-20 Martin Baulig <martin@gnome.org>
12819 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
12820 be underlying type for an enum.
12822 2002-05-20 Miguel de Icaza <miguel@ximian.com>
12824 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
12825 that splits out the loading of just the core types.
12827 * rootcontext.cs (ResolveCore): Split the struct resolution in
12828 two, so we can load the enumeration underlying types before any
12831 * expression.cs (Is): Bandaid until we fix properly Switch (see
12832 bug #24985 for details).
12834 * typemanager.cs (ImplementsInterface): The hashtable will contain
12835 a null if there are no interfaces implemented.
12837 2002-05-18 Miguel de Icaza <miguel@ximian.com>
12839 * cs-parser.jay (indexer_declarator): It is fine to have array
12842 2002-05-17 Miguel de Icaza <miguel@ximian.com>
12844 * typemanager.cs: (RegisterBuilder): New function used to register
12845 TypeBuilders that implement interfaces. Since
12846 TypeBuilder.GetInterfaces (as usual) does not work with lame
12848 (AddUserType): register interfaces.
12850 (ImplementsInterface): Use the builder_to_ifaces hash if we are
12851 dealing with TypeBuilder. Also, arrays are showing up as
12852 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
12853 methods can not be invoked on them!
12855 * ecore.cs (ExplicitReferenceConversionExists): Made public.
12856 (ImplicitReferenceConversionExists): Split out from
12857 StandardConversionExists.
12859 * expression.cs (As): We were only implementing one of the three
12860 cases for the as operator. We now implement them all.
12861 (Is): Implement the various other cases for Is as well.
12863 * typemanager.cs (CACHE): New define used to control if we want or
12864 not the FindMembers cache. Seems to have a negative impact on
12865 performance currently
12867 (MemberLookup): Nested types have full acess to
12868 enclosing type members
12870 Remove code that coped with instance/static returns for events, we
12871 now catch this in RealFindMembers.
12873 (RealFindMembers): only perform static lookup if the instance
12874 lookup did not return a type or an event.
12876 2002-05-17 Miguel de Icaza <miguel@ximian.com>
12878 * assign.cs (CompoundAssign): We pass more semantic information
12879 now to Compound Assignments than we did before: now we have all
12880 the information at hand, and now we resolve the target *before* we
12881 do the expression expansion, which allows the "CacheValue" method
12882 to have the effect we intended (before, a [x] += 1 would generate
12883 two differen ArrayAccess expressions from the ElementAccess,
12884 during the resolution process).
12886 (CompoundAssign.DoResolve): Resolve target and original_source here.
12888 2002-05-16 Miguel de Icaza <miguel@ximian.com>
12890 * expression.cs (ArrayAccess): dropped debugging information.
12892 * typemanager.cs: Small bug fix: I was always returning i_members,
12893 instead of one of i_members or s_members (depending on which had
12896 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
12897 method is invoked before any code generation takes place, and it
12898 is a mechanism to inform that the expression will be invoked more
12899 than once, and that the method should use temporary values to
12900 avoid having side effects
12902 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
12904 * ecore.cs (Expression.CacheTemporaries): Provide empty default
12907 * expression.cs (Indirection, ArrayAccess): Add support for
12908 CacheTemporaries in these two bad boys.
12910 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
12911 ldobj or ldind_ref.
12912 (StoreFromPtr): Handle stobj as well.
12914 * expression.cs (UnaryMutator): Share more code.
12916 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
12917 down: I was not tracking the Filter function as well, which
12918 was affecting the results of the cache.
12920 2002-05-15 Miguel de Icaza <miguel@ximian.com>
12922 * attribute.cs: Remove the hack to handle the CharSet property on
12925 2002-05-14 Miguel de Icaza <miguel@ximian.com>
12927 * attribute.cs (DoResolve): More uglyness, we now only try to
12928 resolve the attribute partially, to extract the CharSet
12929 information (only if we are a StructLayout attribute). Otherwise
12931 (GetExtraTypeInfo): Add some code to conditionally kill in the
12932 future this. I am more and more convinced that the .NET
12933 framework has special code to handle the attribute setting on
12936 * expression.cs (IsParamsMethodApplicable): Revert my previous
12937 foreach change here, it was wrong.
12939 2002-05-13 Miguel de Icaza <miguel@ximian.com>
12941 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
12942 (pp_expr): do not abort on unknown input, just return.
12943 (eval): abort if there are pending chars.
12945 * attribute.cs (Attribute.Resolve): Positional parameters are
12946 optional. Deal with that case.
12948 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
12949 the Ansi/Unicode/Auto information for the type.
12951 (TypeContainer.DefineType): instantiate the EmitContext here, as
12952 we will be using it during the type definition (to resolve
12953 attributes) and during the emit phase.
12955 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
12956 to pull type information out of the attributes
12958 (Attribute.Resolve): track the constructor builder, and allow for
12959 multiple invocations (structs and classes will use this).
12961 * ecore.cs (MemberLookupFinal): new version with all the
12962 parameters customizable.
12964 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
12965 constructors. Return if the result value is null (as the error
12966 would have been flagged already by MemberLookupFinal)
12968 Do not allow instances of abstract classes or interfaces to be
12971 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
12972 We have to compare the assembly property here when dealing with
12973 FamANDAssem and Assembly access modifiers, because we might be
12974 creating an assembly from *modules* (that means that we are not
12975 getting TypeBuilders for types defined in other modules that are
12976 part of this assembly).
12978 (Method.Emit): If the method is marked abstract and has a body,
12981 (TypeContainer.DefineMembers): If both the defined member and the
12982 parent name match are methods, then do not emit any warnings: let
12983 the Method.Define routine take care of flagging warnings. But if
12984 there is a mismatch (method overrides something else, or method is
12985 overriwritten by something, then emit warning).
12987 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
12988 set to null, this means `do not check for the return type on the
12991 (Method.Define): set the return type for the method signature to
12992 null, so that we get methods with the same name and parameters and
12993 different return types. This is used to flag warning 114 (you are
12994 hiding a method, and you probably want to use the new/override
12997 * typemanager.cs (MemberLookup): Implemented proper access
12998 control, closing a long standing set of bug reports. The problem
12999 was that the Framework only has two bits: Public and NonPublic,
13000 and NonPublic includes private and protected methods, but we need
13001 to enforce the FamANDAssem, FamOrAssem and Family.
13003 2002-05-11 Miguel de Icaza <miguel@ximian.com>
13005 * statement.cs (GotoCase): Return true: Ammounts to giving up
13006 knowledge on whether we return or not, and letting the other case
13007 be responsible for it.
13009 2002-05-10 Miguel de Icaza <miguel@ximian.com>
13011 * driver.cs: Do not load directories for each file processed, only
13012 do it if there is a pattern.
13014 * ecore.cs: Report readonly assigns here as well, as we might have
13015 been resolved only by MemberAccess.
13017 (SimpleName.SimpleNameResolve): Also be useful for LValue
13018 resolution. We need this to propagate assign to local readonly variables
13020 * typemanager.cs: Use a ptrhashtable for the criteria, because we
13021 do not want to reuse potential criteria memory.
13023 * class.cs (MyEventBuilder): Set reflected_type;
13025 * ecore.cs (Constantify): Added support for constifying bools.
13027 (RootContext.LookupType): Added a cache for values looked up in
13028 the declaration space.
13030 * typemanager.cs (FindMembers): Now is a front-end to
13031 RealFindMembers, and provides a two-level hashtable-based cache to
13034 15% performance improvement: from 22.5 to 19.2 seconds.
13036 * expression.cs (IsParamsMethodApplicable): use foreach.
13037 (Invocation.DoResolve): ditto.
13038 (New.DoResolve): ditto.
13039 (ArrayCreation.DoResolve): ditto.
13041 * ecore.cs (FindMostEncompassingType): use foreach.
13043 * delegate.cs (NewDelegate.DoResolve): Use foreach
13045 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
13046 (RemoveMethods): use foreach.
13048 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
13049 nested foreach statements instead of for, and also break out of
13050 the inner loop once a match is found.
13052 (Invocation.OverloadResolve): Use foreach, simplify the code.
13054 2002-05-08 Miguel de Icaza <miguel@ximian.com>
13056 * cfold.cs (BinaryFold): During an enumeration evaluation context,
13057 we actually unwrap the expression to allow for extra information
13060 * expression.cs: Use Shr_Un on unsigned operations.
13062 2002-05-08 Ravi Pratap <ravi@ximian.com>
13064 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
13065 applicable operators was not being considered correctly. This closes
13066 the bug Miguel reported.
13068 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
13070 * attribute.cs: check that the type derives from System.Attribute
13071 and report the correct error in that case (moved the duplicate code to
13072 its own method, too).
13074 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
13076 * attribute.cs: lookup attribute type name as the spec says: first the
13077 bare attribute name and then name + "Attribute" (nant compiles with
13078 mcs after this fix).
13080 2002-05-07 Miguel de Icaza <miguel@ximian.com>
13082 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
13083 Because of the way we parse things, we should try to see if a
13084 UIntConstant can fit in an integer.
13086 2002-05-07 Ravi Pratap <ravi@ximian.com>
13088 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
13089 when we are in an explicit context.
13091 (ConvertReferenceExplicit): When converting from Iface type S to Class
13092 T make sure the rules are implemented as an OR.
13094 * parameter.cs (ParameterType): Make it a property for now although the
13095 purpose really isn't anything immediate.
13097 * expression.cs (Is*Applicable): Do better checking on the parameter type
13098 of a ref/out parameter. The ones from the system assemblies are already
13099 marked with the correct type so we don't need to do any correction.
13101 * ecore.cs (StandardConversionExists): Conversion from Interface types to
13102 the object type is standard too so include that.
13104 2002-05-06 Miguel de Icaza <miguel@ximian.com>
13106 * ecore.cs (StandardConversionExists): Augment with missing code:
13107 deal with IntConstant, LongConstants and Enumerations.
13109 * assign.cs: Report the error, instead of failing silently
13111 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
13112 typecontainer that they are declared, because the
13113 typecontainer/namespace will have the list of using clauses that
13114 need to be applied.
13116 Assembly Attributes were escaping the normal registration
13119 (EmitCode): Apply attributes within an EmitContext that represents
13120 the container they were declared on.
13122 * cs-parser.jay: Track bases for structs. How did I get this wrong?
13124 2002-05-06 Ravi Pratap <ravi@ximian.com>
13126 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
13127 Revamp completely - make much cleaner as we now operate only
13130 (FindMostSpecificSource, FindMostSpecificTarget): New methods
13131 to implement the logic detailed in the spec more correctly.
13133 (UserDefinedConversion): Update accordingly.
13135 2002-05-06 Miguel de Icaza <miguel@ximian.com>
13137 * statement.cs: Return flow analysis information up.
13139 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
13142 (token): Do not consume an extra character before calling
13145 2002-05-06 Piers Haken <piersh@friskit.com>
13147 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
13149 2002-05-06 Miguel de Icaza <miguel@ximian.com>
13151 * class.cs (Constructor.Emit): Set the IsStatic flag in the
13152 EmitContext during the instance constructor initializer
13153 resolution, to stop access to instance variables.
13155 This is mandated by the spec, last paragraph of the `constructor
13156 initializers' section.
13158 2002-05-05 Miguel de Icaza <miguel@ximian.com>
13160 * cs-parser.jay, class.cs (Accessor): new class used to represent
13161 an accessor (get or set). In the past we used `null' to represent
13162 a missing accessor. But this is ambiguous because there was no
13163 way to tell in abstract indexers/properties if one of them was
13166 Now there is a way of addressing that.
13168 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
13169 instead of FindMembers.
13171 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
13172 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
13174 * attribute.cs: Treat indexers and properties as the same in terms
13175 of applying attributes
13177 * ecore.cs (FindMostEncompassedType): Use statically initialized
13178 EmptyExpressions()s like we do elsewhere to avoid creating useless
13179 objects (and we take this out of the tight loop).
13181 (GetConversionOperators): Move the code to extract the actual
13182 operators to a separate routine to clean things up.
13184 2002-05-04 Miguel de Icaza <miguel@ximian.com>
13186 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
13187 events are always registered FieldBuilders.
13189 * class.cs (FieldBase): New class shared by Fields
13191 * delegate.cs: If we are a toplevel delegate, use our full name.
13192 If we are a nested delegate, then only use our tail name.
13194 2002-05-02 Ravi Pratap <ravi@ximian.com>
13196 * expression.cs (IsApplicable): Ensure that we add the "&" to
13197 ref/out types before comparing it with the type of the argument.
13199 (IsParamsMethodApplicable): Ditto.
13201 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
13204 * delegate.cs : Handle the case when we have more than one applicable
13205 method. Flag an error only when we finish checking all.
13207 2002-05-02 Miguel de Icaza <miguel@ximian.com>
13209 * expression.cs: Add support for boolean static initializers.
13211 2002-05-01 Miguel de Icaza <miguel@ximian.com>
13213 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
13215 * parameter.cs (ComputeParameterTypes,
13216 ComputeAndDefineParameterTypes): Better error handling: now we
13217 clear the `types' cache if we fail during any of the type lookups.
13218 We also return the status code correctly to our caller
13220 * delegate.cs: If we fail to define a delegate, abort the extra
13223 * expression.cs (Binary.ResolveOperator): for
13224 operator==(object,object) and operator !=(object, object) we also
13225 have to verify that there is an implicit conversion from one to
13228 (ArrayAccess.DoResolve): Array Access can operate on
13231 2002-04-30 Miguel de Icaza <miguel@ximian.com>
13233 * assign.cs (CompoundAssign): A new class used as a "flag" that
13234 the assignment actually is happening as part of a compound
13235 assignment operator.
13237 During compound assignment, a few new rules exist to enable things
13244 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
13245 to the type of x) if y is implicitly convertible to the type of x,
13246 and the operator is a builtin operator and the return type of the
13247 operator is explicitly convertible to the type of x.
13249 * rootcontext.cs: Reset warning level to 2. 4 catches various
13250 "interesting" features in mcs, we must clean this up at some
13251 point, but currently am trying to kill other bugs ;-)
13253 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
13254 in container classes as well.
13256 * expression.cs (Binary.ResolveOperator): Handle string case
13257 before anything else (as operator overloading does emit an error
13258 before doing anything else).
13260 This code could go away when we move to a table driven model, but
13261 i could not come up with a good plan last night.
13263 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
13265 * typemanager.cs (CSharpName): reimplementation using regex.
13266 * class.cs: added null check for fields in Emit
13267 * rootcontext.cs: set warninglevel to 4
13269 2002-04-29 Miguel de Icaza <miguel@ximian.com>
13271 * typemanager.cs (CSharpName): reimplemented with Lupus
13274 2002-04-28 Miguel de Icaza <miguel@ximian.com>
13276 * statement.cs (If): correclty implement Resolve, because we were
13277 not catching sem errors in there. The same process is needed
13279 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
13282 (Statement.Warning_DeadCodeFound): Factorize code.
13283 (While): Report dead code here too.
13285 (Statement): Added Resolve virtual method to allow
13286 for resolution split from the emit code.
13288 2002-04-26 Miguel de Icaza <miguel@ximian.com>
13290 * statement.cs (EmitBoolExpression): No longer try to resolve the
13292 (MakeBoolean): New utility function that resolve, implicitly
13293 converts to boolean and tags the expression.
13296 (If, Do): Implement dead code elimination.
13297 (While): Implement loop inversion
13299 (Do, While, For, If): Resolve the expression prior to calling our
13302 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
13305 - added method Report28 (warning: program has more than one entry point)
13306 - added method IsEntryPoint, implements paragraph 10.1 of the spec
13307 - modified method Method.Define, the part at the end of the method
13309 * rootcontext.cs: added static public Location EntryPointLocation;
13311 * ../errors/cs0028.cs : Add test case for the above warning.
13314 - modified method CSharpName to allow arrays of primitive type to
13315 be printed nicely (e.g. instead of System.Int32[][] it now prints
13317 - added method CSharpSignature: returns the signature of a method
13318 in string format to be used in reporting errors, warnings, etc.
13320 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
13323 2002-04-26 Ravi Pratap <ravi@ximian.com>
13325 * delegate.cs (Define): Fix extremely silly bug where I was
13326 setting the type of the 'object' parameter of the BeginInvoke
13327 method to System.IAsyncResult instead of System.Object ;-)
13329 2002-04-26 Miguel de Icaza <miguel@ximian.com>
13331 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
13334 (Constructor.Emit): return if we fail to initialize the
13335 constructor. Another door closed!
13337 * expression.cs (New.DoResolve): Improve error message (from -6 to
13338 1501). Use DeclaredOnly lookup to find the exact constructor.
13340 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
13341 loop. This is useful.
13343 * cs-parser.jay: Adjust the default parameters so that destructors
13344 have the proper signature.
13346 2002-04-26 Martin Baulig <martin@gnome.org>
13348 * driver.cs (LoadAssembly): If `assembly' contains any characters
13349 which are only valid in path names and not in assembly names
13350 (currently slash, backslash and point), use Assembly.LoadFrom ()
13351 instead of Assembly.Load () on the `assembly' (before iteration
13352 over the link_paths).
13354 2002-04-26 Martin Baulig <martin@gnome.org>
13356 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
13358 2002-04-25 Miguel de Icaza <miguel@ximian.com>
13360 * class.cs (Property): use the new typemanager.MemberLookup
13362 (TypeContainer.MemberLookup): Implement using the
13363 TypeManager.MemberLookup now.
13365 * typemanager.cs: Make MemberLookup a function of the TypeManager,
13366 and return MemberInfos, so that these can be used without an
13367 EmitContext (what we had before).
13369 2002-04-24 Miguel de Icaza <miguel@ximian.com>
13371 * expression.cs: Fix the case where the argument to params if the
13372 type of the params. I omitted handling this before. Fixed
13374 2002-04-22 Miguel de Icaza <miguel@ximian.com>
13376 * driver.cs: Call BootCorlib_PopulateCoreType
13378 * class.cs (Property.CheckBase): Check for properties only, not
13381 * interface.cs: Temporary hack: try/catch around the
13382 CustomAttributeBuilder, because I am getting an exception that I
13385 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
13386 types whose definitions are required to be there (attributes are
13387 defined before standard types).
13389 Compute definitions as we boot the various types, as they are used
13390 immediately (value_type class will need object_type, but if we do
13391 not initialize object_type, we will pass a null, which will let
13392 the runtime pick the System.Object from the existing corlib, which
13393 is not what we want).
13395 2002-04-22 Patrik Torstensson <totte@labs2.com>
13397 * cs-tokenizer.cs: fixed a number of trim() issues.
13399 2002-04-22 Ravi Pratap <ravi@ximian.com>
13401 * expression.cs (Argument.Type): Ensure that we return the correct
13402 type when we have out or ref parameters [in which case we
13405 2002-04-22 Miguel de Icaza <miguel@ximian.com>
13407 * class.cs (Property, Indexer): Allow extern modifier in there.
13409 * typemanager.cs (InitBaseTypes): Initializes object_type and
13410 value_type, since those will be used early on during the bootstrap
13411 process to compile corlib.
13413 (InitCoreTypes): Move code from here to InitBaseTypes.
13415 2002-04-21 Miguel de Icaza <miguel@ximian.com>
13417 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
13418 single-dimension arrays as using the ldlen opcode.
13420 Daniel Lewis discovered this optimization.
13422 * typemanager.cs: Add signature for System.Array::get_Length
13424 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
13426 * statement.cs: report the error when the foreach does not apply to an
13427 array nor a collection.
13429 2002-04-19 Miguel de Icaza <miguel@ximian.com>
13431 * expression.cs: Add implicit conversions to the operator ~.
13433 * constant.cs (DecimalConstant.Emit): Emit decimal value.
13435 * typemanager.cs: Locate the decimal constructor.
13437 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
13439 * attribute.cs: use the new property of TypeOf.
13440 * expression.cs: added 'get' property around typearg.
13442 These changes fix a build breaker reported by NickD. Is this the
13443 correct way to fix? If not, please, revert my changes and make it
13446 2002-04-17 Miguel de Icaza <miguel@ximian.com>
13448 * attribute.cs: Add support for typeof in attribute invocations.
13449 I am not sure that this is right though.
13451 2002-04-14 Duncan Mak <duncan@ximian.com>
13453 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
13454 Binary.Operator.Division case.
13456 2002-04-13 Ravi Pratap <ravi@ximian.com>
13458 * class.cs (DefineType): Ensure that we do a proper check on
13459 attribute types and also register it with the TypeManager.
13461 (TypeContainer.Targets): The default for attribute types is
13462 AttributeTargets.All.
13464 * attribute.cs (ApplyAttributes): Registering the attribute type
13465 is done elsewhere, not when we discover we have a Usage attribute.
13467 2002-04-12 Ravi Pratap <ravi@ximian.com>
13469 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
13470 and get rid of is_delegate parameter.
13472 * everywhere : update.
13474 2002-04-12 Ravi Pratap <ravi@ximian.com>
13476 * cs-parser.jay (compilation_unit): Revamp completely to use
13477 some new ideas that I got from Rhys' grammar to solve the problems
13478 with assembly level attributes.
13480 (outer_declaration): New grammar production.
13482 (attribute_sections): Add.
13484 (opt_attributes): Base on attribute_sections
13486 (namespace_declaration): Allow opt_attributes to tackle the case
13487 when we have assembly level attributes - we are clever in this
13490 * attribute.cs (ApplyAttributes): Do not worry about assembly
13491 attributes in the non-global context.
13493 * rootcontext.cs (AddGlobalAttributes): Go back to using this
13494 instead of SetGlobalAttributes.
13496 * class.cs, rootcontext.cs : Ensure we define and generate
13497 attribute types before anything else.
13499 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
13500 and flag the new error -20 for the case when the attribute type
13501 does not have valid targets specified. csc does not catch this.
13503 * ../errors/errors.txt : update for error # -20
13505 2002-04-11 Ravi Pratap <ravi@ximian.com>
13507 * support.cs (InternalParameters.ParameterModifier): Do some null
13508 checking and return sane values.
13510 * class.cs (Method.Define): If we are a PInvoke method, ensure
13511 that we are static and extern. Report error # 601
13513 * ../errors/cs0601.cs : Add test case for the above error.
13515 2002-04-07 Ravi Pratap <ravi@ximian.com>
13517 * rootcontext.cs (attribute_types): We need to keep type of
13518 all attribute types separately and emit code for them first.
13520 (RegisterAttribute) : Implement.
13522 * class.cs (DefineType): Check if the current Type is a custom
13523 attribute type and register it accordingly.
13525 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
13526 adding the first attribute twice and rename to
13528 (SetGlobalAttributes): this.
13530 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
13533 * attribute.cs (ApplyAttributes): Take an additional argument telling us
13534 if we are processing global arguments. Hmm, I am unsure of this.
13536 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
13538 * expression.cs: added static array of strings to avoid calling
13539 Enum.ToString () for Operator in Binary. Significant recover of
13542 2002-04-10 Miguel de Icaza <miguel@ximian.com>
13544 * class.cs (FindMembers): Allow the Builders of the various
13545 members to be null. If they are skip them. This only happens
13546 during the PInvoke declaration.
13548 2002-04-09 Miguel de Icaza <miguel@ximian.com>
13550 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
13551 failure, so we do not keep going afterwards.
13553 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
13554 wanted to pass `false' as the `is_delegate' argument. If this is
13555 the case, why not use delegate_type == null to mean `is_delegate =
13556 false' and anything else as is_delegate = true.
13558 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
13560 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
13561 code for the section, not the beginning of the tests.
13563 2002-04-08 Miguel de Icaza <miguel@ximian.com>
13565 * cfold.cs: Handle operator + (Enum x, Underlying x)
13567 * expression.cs (Binary): same. Warn about errors where we have
13568 Enum/Enum in operator + as well.
13570 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
13573 - added support for switch(bool)
13574 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
13575 - add TableSwitchEmit() to handle table-based switch statements
13577 2002-04-05 Ravi Pratap <ravi@ximian.com>
13579 * expression.cs (Invocation.OverloadResolve): Factor out code which
13580 does parameter compatibility checking with arguments so that we can
13581 re-use the code even from Delegate.VerifyApplicability
13583 (VerifyArgumentsCompat): Move above code here.
13585 * delegate.cs (VerifyApplicability): Get rid of duplicate code
13586 and instead make a call to the above method.
13588 2002-03-31 Ravi Pratap <ravi@ximian.com>
13590 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
13591 We use it to keep track of classes which are attribute types.
13593 2002-04-02 Miguel de Icaza <miguel@ximian.com>
13595 * delegate.cs (Delegate.Define): Correctly define the types in the
13596 presence of fixed and array parameters.
13598 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
13601 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
13602 include NonPublic after the first iteration.
13604 * class.cs (Indexer.CheckBase): Only check if both parents are
13607 * cs-parser.jay (accessor_body): If empty, set to null.
13609 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
13610 same code path here to resolve constants names that we did have in
13611 MemberAccess.DoResolve. There is too much code duplicated here.
13613 2002-04-01 Miguel de Icaza <miguel@ximian.com>
13615 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
13617 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
13620 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
13621 tokens, numbers and strings.
13623 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
13626 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
13627 asyncronous parameters and the regular parameters.
13629 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
13630 specify the target directory.
13632 * expression.cs: (This.DoResolve): Simplify
13633 (As.Emit): Optimize, do not generate IsInst if the expression is
13634 always of the given type.
13636 (Is.DoResolve): Bug fix, we were reporting both always/never for
13639 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
13640 creating too many unnecessary arrays.
13642 2002-03-31 Miguel de Icaza <miguel@ximian.com>
13644 * class.cs (EmitFieldInitializer): Use Assign expression to assign
13645 fields instead of rolling our own initializer. Takes care of all
13646 implicit conversions, and drops unnecessary static checks/argument.
13648 2002-03-31 Dick Porter <dick@ximian.com>
13650 * driver.cs: use the GetDirectories() return values properly, and
13651 use "/" as path separator.
13653 2002-03-30 Miguel de Icaza <miguel@ximian.com>
13655 * expression.cs (Unary): Optimize - - expr into expr.
13656 (Binary): Optimize a + (-b) into a -b.
13658 * codegen.cs (CodeGen): Made all methods static.
13660 2002-03-29 Miguel de Icaza <miguel@ximian.com>
13664 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
13665 TypeBuilder property.
13667 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
13670 * tree.cs: Removed the various RecordXXXX, and replaced with a
13671 single RecordDecl. Removed all the accessor methods, and just
13672 left a single access point Type
13674 * enum.cs: Rename DefineEnum to DefineType.
13676 * decl.cs: New abstract method `DefineType' used to unify the
13677 Defines for Enumerations, Interfaces, TypeContainers and
13680 (FindType): Moved LookupInterfaceOrClass here. Moved the
13681 LookupBaseClasses method that used to live in class.cs and
13682 interface.cs here, and renamed to FindType.
13684 * delegate.cs: Implement DefineType. Take advantage of the
13685 refactored pattern for locating the parent builder without taking
13686 the parent_builder argument (which we know does not work if we are
13687 nested, and triggering a toplevel definition).
13689 2002-03-28 Miguel de Icaza <miguel@ximian.com>
13691 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
13692 accessibility of a member has changed during override and report
13695 * class.cs (Method.Define, Property.Define): Only complain on
13696 overrides if the method is private, any other accessibility is
13697 fine (and since we just checked the permission is the same, we are
13700 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
13701 and elif are processed always. The other pre-processing
13702 directives are only processed if we are "taking" the path
13704 2002-03-29 Martin Baulig <martin@gnome.org>
13706 * class.cs (Method.Emit): Only emit symbolic debugging info if the
13707 current location is not Null.
13709 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
13710 a separate method so we can profile it.
13712 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
13713 `span.Seconds' are just seconds, but no minutes or hours.
13714 (MainDriver): Profile the CodeGen.SaveSymbols calls.
13716 2002-03-28 Miguel de Icaza <miguel@ximian.com>
13718 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
13719 Remove the gratuitous set of Final:
13721 // If an interface implementation, then we can set Final.
13722 if (((flags & MethodAttributes.Abstract) == 0) &&
13723 implementing.DeclaringType.IsInterface)
13724 flags |= MethodAttributes.Final;
13726 I do not know what I was smoking when I used that.
13729 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
13730 step into fixing the name resolution issues for delegates and
13731 unifying the toplevel name resolution.
13733 2002-03-28 Martin Baulig <martin@gnome.org>
13735 * class.cs (Method.Emit): If we have a symbol writer, call its
13736 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
13737 tell it about the current method.
13739 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
13740 writer that we're going to emit the first byte of IL code for a new
13741 statement (a new source line).
13742 (EmitContext.EmitTopBlock): If we have a symbol writer, call
13743 EmitContext.Mark() before emitting any code.
13745 * location.cs (SymbolDocument): Return null when we're Null.
13747 * statement.cs (Statement): Moved the `Location loc' variable here.
13748 (Statement.EmitBoolExpression): If we have a symbol writer, call
13749 ec.Mark() before emitting any code to tell it that we're at the
13750 beginning of a new statement.
13751 (StatementExpression): Added `Location' argument to the constructor.
13752 (Block): Added public readonly variable `StartLocation' and public
13753 variable `EndLocation'. The latter is to be set using SetEndLocation().
13754 (Block): Added constructor which takes a start and end location.
13755 (Block.SetEndLocation): New method. This sets the end location.
13756 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
13757 local variables we create.
13758 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
13759 each statement and do also mark the begin and end of the block.
13761 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
13762 tell it the current lexer.Location, use Location.Null for the end of the
13764 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
13765 current block, set its end location using SetEndLocation().
13766 (statement_expression): StatementExpression constructor now takes the
13767 lexer.Location as additional argument.
13768 (for_statement, declare_local_variables): Likewise.
13769 (declare_local_variables): When creating a new implicit block, use the
13770 new Block constructor and pass it the lexer.Location.
13772 2002-03-28 Miguel de Icaza <miguel@ximian.com>
13774 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
13775 members also on the parent interfaces recursively.
13777 2002-03-27 Miguel de Icaza <miguel@ximian.com>
13779 * report.cs: Use new formats, since Gonzalo finished the missing
13782 * expression.cs (Binary.ResolveOperator): added missing operator|
13783 operator& and operator^ for bool/bool.
13785 * cs-parser.jay: CheckDef now takes a Location argument that is
13786 used to report errors more precisly (instead of reporting the end
13787 of a definition, we try to track something which is a lot closer
13788 to the source of the problem).
13790 * cs-tokenizer.cs: Track global token use, so we can properly flag
13791 the use of #define/#undef after the first token has been seen.
13793 Also, rename the reportXXXX to Error_DescriptiveName
13795 * decl.cs (DeclSpace.IsTopLevel): Move property here from
13796 TypeContainer, so that Enum and Interface can use this too.
13798 * class.cs (TypeContainer.LookupInterfaceOrClass,
13799 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
13800 `builder' argument. Typically this was used to pass the parent
13801 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
13804 The problem is that a nested class could trigger the definition of
13805 a toplevel class, and the builder would be obviously wrong in that
13808 So we drop this argument, and we compute dynamically the
13809 TypeBuilder/ModuleBuilder (the correct information was available
13810 to us anyways from DeclSpace.Parent)
13812 * interface.cs (Interface.DefineInterface): Drop builder
13813 parameter cleanup like class.cs
13815 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
13818 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
13821 (Try.Emit): Propagate the returns value from the statement.
13823 (Return.Emit): Even if we are leavning
13825 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
13827 * modifiers.cs: Fix the computation of MethodAttributes flags.
13829 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
13831 * driver.cs: allow compilation of files that start with '/'.
13832 Add a default case when checking the argument of --target.
13834 2002-03-25 Miguel de Icaza <miguel@ximian.com>
13836 * interface.cs: Implement the same search algorithm for types in
13837 the interface code.
13839 * delegate.cs: Do not allow multiple definition.
13841 * Recovered ChangeLog that got accidentally amputated
13843 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
13845 * rootcontext.cs: Load manually enum to allow core classes to
13846 contain enumerations.
13848 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
13849 Update to new static methods in TypeManager.
13851 * typemanager.cs (GetMethod, GetConstructor): Use our
13852 implementation of FindMembers to find the members, since during
13853 corlib compilation, the types are TypeBuilders and GetMethod and
13854 GetConstructor do not work.
13856 Make all methods in TypeManager static.
13858 (InitCodeHelpers): Split the functionality from
13859 the InitCodeTypes function.
13861 * driver.cs: Call InitCodeHelpers after we have populated the
13864 * cs-parser.jay (delegate_declaration): we did not used to compute
13865 the delegate name correctly for void delegates.
13867 2002-03-24 Miguel de Icaza <miguel@ximian.com>
13869 * rootcontext.cs (RootContext): Init the interface_resolve_order
13870 and type_container_resolve_order always.
13872 (ResolveCore, BootstrapCorlib_ResolveClass,
13873 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
13874 compiler when compiling with --nostdlib
13876 * class.cs (TypeContainer.DefineType): Check that our parent is
13877 not null. This test is most important when we are bootstraping
13880 * codegen.cs: Split out the symbol writing code.
13882 2002-03-25 Martin Baulig <martin@gnome.org>
13884 * driver.cs (-g): Made -g an alias for --debug.
13886 2002-03-24 Martin Baulig <martin@gnome.org>
13888 * codegen.cs (SymbolWriter): New public variable. Returns the
13889 current symbol writer.
13890 (CodeGen): Added `bool want_debugging_support' argument to the
13891 constructor. If true, tell the ModuleBuild that we want debugging
13892 support and ask it for the ISymbolWriter.
13893 (Save): If we have a symbol writer, call it's Close() method after
13894 saving the assembly.
13896 * driver.c (--debug): New command line argument to create a
13897 debugger information file.
13899 * location.cs (SymbolDocument): New public property. Returns an
13900 ISymbolDocumentWriter object for the current source file or null
13901 if we don't have a symbol writer.
13903 2002-03-21 Miguel de Icaza <miguel@ximian.com>
13905 * driver.cs (LoadAssembly): Correctly return when all the paths
13906 have been tried and not before.
13908 * statement.cs (Switch.Emit): return the actual coverage for this
13909 statement (returns/not-returns)
13911 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
13912 switch of the statement if we are the last switch section. That
13913 kills two problems: try/catch problems (we used to emit an empty
13914 nop at the end) and switch statements where all branches would
13917 2002-03-19 Miguel de Icaza <miguel@ximian.com>
13919 * driver.cs: Add default assemblies (the equivalent to the
13920 Microsoft CSC.RSP file)
13922 * cs-tokenizer.cs: When updating `cols and setting it to zero,
13923 also update tokens_seen and set it to false.
13925 * driver.cs: Implement --recurse for Mike.
13927 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
13928 correctly splitting out the paths.
13930 2002-03-18 Miguel de Icaza <miguel@ximian.com>
13932 * interface.cs (Interface.PopulateProperty): Instead of using
13933 `parent' as the declaration space for the set parameters, use
13936 * support.cs (InternalParameters): InternalParameters constructor
13937 takes a DeclSpace instead of a TypeContainer.
13939 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
13940 types are being initialized, load the address of it before calling
13943 (New): Provide a mechanism to disable the generation of local
13944 value type temporaries when the caller will be providing us with
13945 an address to store it.
13947 (ArrayCreation.EmitDynamicInitializers): Use it.
13949 2002-03-17 Miguel de Icaza <miguel@ximian.com>
13951 * expression.cs (Invocation.EmitArguments): Only probe for array
13952 property if there is more than one argument. Sorry about that.
13954 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
13955 empty param arrays.
13957 * class.cs (Method.LabelParameters): Fix incorrect code path that
13958 prevented the `ParamArrayAttribute' from being applied to the
13961 2002-03-16 Miguel de Icaza <miguel@ximian.com>
13963 * support.cs (ReflectionParameters): Correctly compute whether the
13964 last argument is a params array. Fixes the problem with
13967 * typemanager.cs: Make the assemblies array always be non-null
13968 (empty, but non-null)
13970 * tree.cs (RecordDecl): New function that abstracts the recording
13971 of names. This reports error 101, and provides a pointer to the
13972 previous declaration. Fixes a crash in the compiler.
13974 * cs-parser.jay (constructor_declaration): Update to new grammar,
13975 and provide a constructor_body that can be empty.
13977 2002-03-15 Miguel de Icaza <miguel@ximian.com>
13979 * driver.cs: Add support for --resources.
13981 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
13982 Make all types for the various array helper methods be integer.
13984 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
13985 CheckState to ConvCast.
13987 (ConvCast): Now it takes a `checked' state argument, to avoid
13988 depending on the emit context for the conversion, and just using
13989 the resolve time setting.
13991 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
13992 instead of Invocation.EmitArguments. We do not emit the original
13993 arguments, instead we emit those which have been converted to
13994 unsigned int expressions.
13996 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
13998 * codegen.cs: ditto.
14000 * expression.cs (LocalVariableReference): Drop the use of the
14001 Store function that depended on the variable index.
14003 * statement.cs (VariableInfo): Drop the `Idx' property from this
14004 class, as this is not taking into account the indexes for
14005 temporaries tat we generate during the execution, getting the
14008 * class.cs: First emit class initializers, then call the parent
14011 * expression.cs (Binary): Fix opcode emision.
14012 (UnaryMutator.EmitCode): Support checked code generation
14014 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
14015 matches for events for both the Static and Instance scans,
14016 pointing to the same element. Fix that.
14018 2002-03-14 Miguel de Icaza <miguel@ximian.com>
14020 * rootcontext.cs (ResolveTree): Always set the
14021 interface_resolve_order, because nested interfaces will be calling
14024 * class.cs (GetInterfaceOrClass): Track the same resolution
14025 process used by TypeManager.LookupType. This fixes the nested
14026 type lookups in class declarations (separate path from
14029 (TypeContainer.DefineType): Also define nested interfaces.
14030 (TypeContainer.RegisterOrder): New public function used to
14031 register the order in which child interfaces need to be closed.
14033 Nested interfaces need to be closed after their parents have been
14036 * interface.cs (InterfaceAttr): Put all the logic for computing
14037 the interface attribute here.
14039 (DefineInterface): Register our interface order with the
14040 RootContext or with the TypeContainer depending on the case.
14042 2002-03-12 Miguel de Icaza <miguel@ximian.com>
14044 * cs-parser.jay: rework foreach statement to work with the new
14045 changes to the policy on SimpleNames.
14047 * report.cs: support Stacktrace on warnings as well.
14049 * makefile: drop --unsafe and /unsafe from the compile.
14051 2002-03-13 Ravi Pratap <ravi@ximian.com>
14053 * ecore.cs (StandardConversionExists): Modify to take an Expression
14054 as the first parameter. Ensure we do null -> reference type conversion
14057 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
14058 temporary Expression objects.
14060 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
14062 * interface.cs: workaround bug in method overloading resolution
14063 (there is already a bugzilla bug for it).
14065 2002-03-12 Miguel de Icaza <miguel@ximian.com>
14067 We could also solve this problem by having a separate path for
14068 performing type lookups, instead of DoResolve, we could have a
14069 ResolveType entry point, and only participating pieces of the
14070 production (simplename, deref, array) would implement this.
14072 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
14073 signal SimpleName to only resolve type names and not attempt to
14074 resolve anything else.
14076 * expression.cs (Cast): Set the flag.
14078 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
14080 * class.cs: Only report 108 if there is no `new' modifier.
14082 * cs-parser.jay: rework foreach statement to work with the new
14083 changes to the policy on SimpleNames.
14085 * report.cs: support Stacktrace on warnings as well.
14087 * makefile: drop --unsafe and /unsafe from the compile.
14089 2002-03-11 Miguel de Icaza <miguel@ximian.com>
14091 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
14092 lookups here, instead of doing that at parse time. This means
14093 that our grammar will not introduce `LocalVariableReferences' as
14094 expressions at this point. That solves the problem of code like
14098 static void Main ()
14102 This is only half the fix. The full fix requires parameters to
14103 also be handled in this way.
14105 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
14106 makes the use more obvious of the DeclSpace. The
14107 ec.TypeContainer.TypeBuilder is now only used to pull the
14108 TypeBuilder for it.
14110 My theory is that I can get rid of the TypeBuilder completely from
14111 the EmitContext, and have typecasts where it is used (from
14112 DeclSpace to where it matters).
14114 The only pending problem is that the code that implements Aliases
14115 is on TypeContainer, and probably should go in DeclSpace.
14117 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
14118 lookups here, instead of doing that at parse time. This means
14119 that our grammar will not introduce `LocalVariableReferences' as
14120 expressions at this point. That solves the problem of code like
14124 static void Main ()
14128 This is only half the fix. The full fix requires parameters to
14129 also be handled in this way.
14131 * class.cs (Property.DefineMethod): When implementing an interface
14132 method, set newslot, when implementing an abstract method, do not
14133 set the flag (before we tried never setting it, or always setting
14134 it, which is the difference).
14135 (Indexer.DefineMethod): same.
14136 (Method.DefineMethod): same.
14138 * ecore.cs: Only set the status used flag if we get back a Field.
14140 * attribute.cs: Temporary hack, so Paolo can keep working.
14142 2002-03-08 Ravi Pratap <ravi@ximian.com>
14144 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
14145 the unmanaged type in the case we have a MarshalAs attribute.
14147 (Resolve): Handle the case when we are parsing the special MarshalAs
14148 attribute [we need to store the unmanaged type to use later]
14150 * typemanager.cs (marshal_as_attr_type): Built in type for the
14151 MarshalAs Attribute.
14153 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
14154 on parameters and accordingly set the marshalling info.
14156 2002-03-09 Miguel de Icaza <miguel@ximian.com>
14158 * class.cs: Optimizing slightly by removing redundant code after
14159 we switched to the `NoTypes' return value.
14160 (Property.DefineMethod): use NoTypes here too.
14162 This fixes the bug I introduced in my last batch of changes.
14164 2002-03-05 Ravi Pratap <ravi@ximian.com>
14166 * tree.cs (RecordEnum): Add. We now keep track of enums too.
14168 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
14169 Enums since those are types too.
14171 * cs-parser.jay (enum_declaration): Record enums as we parse them.
14173 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
14174 thanks to a call during the lookup process.
14176 2002-03-07 Miguel de Icaza <miguel@ximian.com>
14178 * statement.cs (Foreach): Lots of work to accomodate a particular
14179 kind of foreach statement that I had not kept in mind. It is
14180 possible to have foreachs on classes that provide a GetEnumerator
14181 method that return objects that implement the "pattern" for using
14182 a foreach, there is no need to support GetEnumerator
14185 This is needed to compile nant.
14187 * decl.cs: Only report 114 if the member is not `Finalize' and if
14188 the warning level is at least 2.
14190 * class.cs: Moved the compare function from Method to
14193 (MethodSignature.InheritableMemberSignatureCompare): Add new
14194 filter function that is used to extract inheritable methods from a
14197 (Method.Define): Use the new `inheritable_method_signature_filter'
14200 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
14203 2002-03-06 Miguel de Icaza <miguel@ximian.com>
14205 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
14207 * cs-parser.jay: Add opt_semicolon to the interface declaration.
14209 * expression.cs: Pass location information to
14210 ConvertImplicitStandard.
14212 * class.cs: Added debugging code to track return values from
14215 2002-03-05 Miguel de Icaza <miguel@ximian.com>
14217 * expression.cs (Is.DoResolve): If either side of the `is' is an
14218 interface, do not flag the warning.
14220 * ecore.cs (ImplicitReferenceConversion): We need a separate test
14223 * report.cs: Allow for --fatal to be used with --probe.
14225 * typemanager.cs (NoTypes): Move the definition for the empty Type
14228 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
14230 (TypeContainer.DefineProxy): New function used to proxy to parent
14231 implementations when implementing interfaces.
14232 (TypeContainer.ParentImplements): used to lookup if our parent
14233 implements a public function that is required by an interface.
14234 (TypeContainer.VerifyPendingMethods): Hook this up.
14236 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
14237 `modules' and `assemblies' arraylists into arrays. We only grow
14238 these are the very early start up of the program, so this improves
14239 the speedof LookupType (nicely measured).
14241 * expression.cs (MakeByteBlob): Replaced unsafe code with
14242 BitConverter, as suggested by Paolo.
14244 * cfold.cs (ConstantFold.Binary): Special case: perform constant
14245 folding of string concatenation, but if either side is a string,
14246 and the other is not, then return null, and let the runtime use
14247 the concatenation on the string plus the object (using
14248 `Object.ToString').
14250 2002-03-04 Miguel de Icaza <miguel@ximian.com>
14252 Constant Folding has been implemented now.
14254 * expression.cs (Unary.Reduce): Do not throw an exception, catch
14255 the error instead on types that are not supported in one's
14258 * constant.cs (Constant and all children): New set of functions to
14259 perform implict and explicit conversions.
14261 * ecore.cs (EnumConstant): Implement the new functions to perform
14262 conversion by proxying to the child expression.
14264 * codegen.cs: (ConstantCheckState): Constant evaluation has its
14265 own separate setting that can not be turned off from the command
14266 line using --unchecked or --checked and is only controlled using
14267 the checked/unchecked statements and expressions. This setting is
14268 used by the constant folder to flag errors.
14270 * expression.cs (CheckedExpr, UncheckedExpr): Set the
14271 ConstantCheckState as well.
14273 During Resolve, they also have to flag the state, because the
14274 constant folder runs completely in the Resolve phase.
14276 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
14279 2002-03-01 Miguel de Icaza <miguel@ximian.com>
14281 * cfold.cs: New file, this file contains the constant folder.
14283 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
14284 argument to track whether we are using the resulting address to
14285 load or store a value and provide better error messages.
14287 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
14288 new AddressOf arguments.
14290 * statement.cs (Foreach.EmitCollectionForeach): Update
14292 * expression.cs (Argument.Emit): Call AddressOf with proper
14293 arguments to track usage.
14295 (New.DoEmit): Call AddressOf with new arguments.
14297 (Unary.Emit): Adjust AddressOf call.
14299 2002-03-01 Ravi Pratap <ravi@ximian.com>
14301 * cs-parser.jay (member_access): Change the case for pre-defined types
14302 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
14305 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
14308 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
14309 essentially like methods and apply attributes like MethodImplOptions to them too.
14311 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
14314 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
14315 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
14318 * Update code everywhere accordingly.
14320 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
14322 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
14324 2002-02-28 Ravi Pratap <ravi@ximian.com>
14326 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
14327 try performing lookups against those instead of jumping straight into using
14328 the 'using' clauses.
14330 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
14332 (LookupType): Perform lookups in implicit parents too.
14334 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
14335 sequence as RootContext.LookupType.
14337 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
14338 the various cases of namespace lookups into this method.
14340 2002-03-01 Miguel de Icaza <miguel@ximian.com>
14342 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
14343 in positional arguments)
14345 * class.cs (Operator): Update the AllowedModifiers to contain
14348 * cs-parser.jay: Update operator declaration to allow for the
14349 operator body to be empty.
14351 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
14354 2002-02-27 Miguel de Icaza <miguel@ximian.com>
14356 * class.cs (Method.Emit): Label parameters.
14358 * driver.cs: Return 1 or 0 as the program exit code.
14360 2002-02-26 Miguel de Icaza <miguel@ximian.com>
14362 * expression.cs: Special case the `null' object when trying to
14363 auto-compute the type, as anything can be explicitly converted to
14366 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
14367 spotting this Paolo.
14369 (Expression.ImplicitNumericConversion): Perform comparissions of
14370 the type using the underlying type in the case of an enumeration
14371 rather than using the enumeration type for the compare.
14373 Cope with the underlying == type case, which is not possible to
14376 (Expression.ConvertNumericExplicit): Perform comparissions of
14377 the type using the underlying type in the case of an enumeration
14378 rather than using the enumeration type for the compare.
14380 * driver.cs: If the user does not supply an extension, assume .exe
14382 * cs-parser.jay (if_statement): Rewrote so that we can track the
14383 location for the if statement.
14385 * expression.cs (Binary.ConstantFold): Only concat strings when
14386 the operation is "+", not everything ;-)
14388 * statement.cs (Statement.EmitBoolExpression): Take a location
14390 (If, While, Do): Track location.
14392 * expression.cs (Binary.ResolveOperator): In the object + string
14393 case, I was missing a call to ConvertImplicit
14395 2002-02-25 Ravi Pratap <ravi@ximian.com>
14397 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
14398 Location arguments. Ensure we use RootContext.LookupType to do our work
14399 and not try to do a direct Type.GetType and ModuleBuilder.GetType
14401 * interface.cs (PopulateMethod): Handle the type of the parameter being
14404 * expression.cs (Invocation.BetterFunction): Handle the case when we
14405 have a params method with no fixed arguments and a call is made with no
14408 2002-02-25 Miguel de Icaza <miguel@ximian.com>
14410 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
14411 the verbatim-string-literal
14413 * support.cs (InternalParameters.ParameterModifier): handle null
14415 (InternalParameters.ParameterType): ditto.
14417 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
14418 duplicating the name of the variable parameter.
14419 (GetParameterByName): Fix bug where we were not looking up array
14420 paramters if they were the only present (thanks Paolo!).
14421 (GetParameterInfo): We only have an empty set of types if both
14422 fixed and array are set to null.
14423 (GetParameterInfo-idx): Handle FixedParameter == null
14425 * cs-parser.jay: Handle the case where there is no catch
14426 statements (missing null test).
14428 2002-02-22 Miguel de Icaza <miguel@ximian.com>
14430 * driver.cs (MainDriver): Be conservative on our command line
14433 Catch DirectoryNotFoundException when calling GetFiles.
14435 (SplitPathAndPattern): Used to split the input specification into
14436 a path and a pattern that we can feed to Directory.GetFiles.
14438 2002-02-21 Miguel de Icaza <miguel@ximian.com>
14440 * statement.cs (Fixed): Implement the last case of the Fixed
14441 statement (string handling).
14443 * expression.cs (StringPtr): New class used to return a char * to
14444 a string; Used by the Fixed statement.
14446 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
14448 * expression.cs (Binary.ResolveOperator): Remove redundant
14449 MemberLookup pn parent type.
14450 Optimize union call, we do not need a union if the types are the same.
14451 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
14454 Specialize the use of MemberLookup everywhere, instead of using
14455 the default settings.
14457 (StackAlloc): Implement stackalloc keyword.
14459 * cs-parser.jay: Add rule to parse stackalloc.
14461 * driver.cs: Handle /h, /help, /?
14463 * expression.cs (MakeByteBlob): Removed the hacks we had in place
14464 before we supported unsafe code.
14466 * makefile: add --unsafe to the self compilation of mcs.
14468 2002-02-20 Miguel de Icaza <miguel@ximian.com>
14470 * expression.cs (PointerArithmetic): New class that is used to
14471 perform pointer arithmetic.
14472 (Binary.Resolve): Handle pointer arithmetic
14473 Handle pointer comparission.
14474 (ArrayPtr): Utility expression class that is used to take the
14475 address of an array.
14477 (ElementAccess): Implement array access for pointers
14479 * statement.cs (Fixed): Implement fixed statement for arrays, we
14480 are missing one more case before we are done.
14482 * expression.cs (Indirection): Implement EmitAssign and set the
14483 ExprClass to Variable. This allows pointer dereferences to be
14484 treated as variables, and to have values assigned to them.
14486 * ecore.cs (Expression.StoreFromPtr): New utility function to
14487 store values dereferencing.
14489 2002-02-20 Ravi Pratap <ravi@ximian.com>
14491 * expression.cs (Binary.ResolveOperator): Ensure that we are
14492 not trying to operate on a void type - this fixes the reported
14495 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
14496 the parent implementation is sealed.
14498 * ../errors/cs0239.cs : Add.
14500 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
14502 * typemanager.cs (unverifiable_code_type): Corresponds to
14503 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
14504 which have unsafe code in them.
14506 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
14509 2002-02-19 Miguel de Icaza <miguel@ximian.com>
14511 * cs-tokenizer.cs: Add support for @"litreal strings"
14513 Make tokenizer accept pre-processor directives
14514 on any column (remove the old C-like limitation).
14516 * rootcontext.cs (EmitCode): Emit any global attributes.
14517 (AddGlobalAttributes): Used to keep track of assembly attributes.
14519 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
14521 * cs-parser.jay: Add support for global attributes.
14523 2002-02-17 Miguel de Icaza <miguel@ximian.com>
14525 * expression.cs (Indirection): New helper class. Unary will
14526 create Indirection classes to be able to implement the
14527 IMemoryLocation interface on it.
14529 2002-02-16 Miguel de Icaza <miguel@ximian.com>
14531 * cs-parser.jay (fixed_statement): reference the right statement.
14533 * statement.cs (Fixed.Emit): Finish implementing the fixed
14534 statement for the &x case.
14536 2002-02-14 Miguel de Icaza <miguel@ximian.com>
14538 * class.cs (Property.Define, Method.Define): Remove newslot when
14541 * modifiers.cs: My use of NewSlot when `Abstract' was set was
14542 wrong. NewSlot should only be used if the `new' keyword is present.
14544 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
14545 locating our system dir. Sorry about this.
14547 2002-02-13 Miguel de Icaza <miguel@ximian.com>
14549 * driver.cs (GetSystemDir): Compute correctly the location of our
14550 system assemblies. I was using the compiler directory instead of
14551 the library directory.
14553 2002-02-13 Ravi Pratap <ravi@ximian.com>
14555 * expression.cs (BetterFunction): Put back in what Miguel commented out
14556 since it is the correct fix. The problem is elsewhere ;-)
14558 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
14559 parameters of the parms method are themselves compatible or not !
14561 (StandardConversionExists): Fix very dangerous bug where we were forgetting
14562 to check that a class implements an interface before saying that an implicit
14563 conversion was allowed. Use ImplementsInterface to do the checking.
14565 2002-02-13 Miguel de Icaza <miguel@ximian.com>
14567 * class.cs (Method.Define): Track whether we are an explicit
14568 implementation or not. And only call DefineMethodOverride if we
14569 are an explicit implementation.
14571 (Property.DefineMethod): Ditto.
14573 2002-02-11 Ravi Pratap <ravi@ximian.com>
14575 * expression.cs (BetterFunction): Catch hideous bug which was
14576 preventing us from detecting ambiguous calls due to implicit casts i.e
14579 2002-01-29 Miguel de Icaza <miguel@ximian.com>
14581 * support.cs (Pair): Remove un-needed method. I figured why I was
14582 getting the error in cs-parser.jay, the variable in a foreach loop
14583 is readonly, and the compiler does not really treat this as a variable.
14585 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
14586 instead of EQUALS in grammar.
14588 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
14590 * expression.cs (Unary.DoResolve): Check whether the argument is
14593 2002-01-28 Miguel de Icaza <miguel@ximian.com>
14595 * support.cs: Api for Pair to set a value. Despite the fact that
14596 the variables are public the MS C# compiler refuses to compile
14597 code that accesses the field if the variable is part of a foreach
14600 * statement.cs (Fixed): Begin implementation of the fixed
14603 (Block.AddVariable): Return the VariableInfo on success and null
14604 on failure instead of true/false.
14606 * cs-parser.jay (foreach): Catch errors on variables already
14607 defined (we were ignoring this value before) and properly unwind
14608 the block hierarchy
14610 (fixed_statement): grammar for the fixed statement.
14612 2002-01-25 Miguel de Icaza <miguel@ximian.com>
14614 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
14615 pointer types to be incretemented.
14617 (SizeOf): Implement.
14619 * cs-parser.jay (pointer_member_access): Implement
14620 expr->IDENTIFIER production.
14622 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
14623 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
14626 (Unary): Implement indirection.
14628 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
14629 use in non-unsafe context).
14631 (SimpleName.DoResolve): Check for pointers in field access on safe
14634 (Expression.LoadFromPtr): Factor the load-indirect code in this
14635 function. This was duplicated in UnboxCast and ParameterReference
14637 2002-01-24 Miguel de Icaza <miguel@ximian.com>
14639 * expression.cs (ComposedCast): report an error if a pointer cast
14640 is used in a safe region.
14642 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
14643 pointer type casts in unsafe context.
14645 * codegen.cs (EmitContext): Set up IsUnsafe.
14647 * cs-parser.jay (non_expression_type): Add productions for pointer
14650 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
14651 code. We should not use force into static mode if the method is
14652 not virtual. Fixes bug in MIS
14654 * statement.cs (Do.Emit, While.Emit, For.Emit,
14655 Statement.EmitBoolExpression): Add support to Do and While to
14656 propagate infinite loop as `I do return' semantics.
14658 Improve the For case to also test for boolean constants.
14660 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
14661 to the list of attributes we can add.
14663 Remove `EmitContext' argument.
14665 * class.cs (Method.Define): Apply parameter attributes.
14666 (Constructor.Define): Apply parameter attributes.
14667 (MethodCore.LabelParameters): Move here the core of labeling
14670 * support.cs (ReflectionParameters.ParameterModifier,
14671 InternalParameters.ParameterModifier): Use IsByRef on the type and
14672 only return the OUT bit for these parameters instead of in/out/ref
14675 This is because I miss-understood things. The ParameterInfo.IsIn
14676 and IsOut represent whether the parameter has the [In] and [Out]
14679 2002-01-22 Miguel de Icaza <miguel@ximian.com>
14681 * ecore.cs (FieldExpr.Emit): Release temporaries.
14683 * assign.cs (LocalTemporary.Release): new function.
14685 * codegen.cs (EmitContext.GetTemporaryStorage,
14686 EmitContext.FreeTemporaryStorage): Rework the way we deal with
14687 temporary storage. Now we can "put back" localbuilders when we
14690 2002-01-21 Miguel de Icaza <miguel@ximian.com>
14692 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
14693 need to make a copy of the variable to generate verifiable code.
14695 2002-01-19 Miguel de Icaza <miguel@ximian.com>
14697 * driver.cs: Compute dynamically the system directory.
14699 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
14700 Slower, but more generally useful. Used by the abstract
14701 registering implementation.
14703 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
14704 the rules for the special rule on Type/instances. First check if
14705 we have the same name, and if so, try that special static path
14706 rather than the instance path.
14708 2002-01-18 Miguel de Icaza <miguel@ximian.com>
14710 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
14713 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
14714 Enum, ValueType, Delegate or Array for non-corlib compiles.
14716 * cs-tokenizer.cs: Catch long identifiers (645)
14718 * typemanager.cs (IndexerPropetyName): Ravi never tested this
14721 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
14722 fix, we were returning too early, so we were not registering
14723 pending methods from abstract classes.
14725 Do not register pending methods if the class is abstract.
14727 * expression.cs (Conditional.DoResolve): Report circular implicit
14728 conversions when we neecd to compute it for conditional
14731 (Is.DoResolve): If the expression is always of the provided type,
14732 flag warning 183. If the expression can not ever be of the
14733 provided type flag warning 184.
14735 * class.cs: Catch 169 as well.
14737 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
14740 2002-01-18 Nick Drochak <ndrochak@gol.com>
14742 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
14744 2002-01-17 Miguel de Icaza <miguel@ximian.com>
14746 * interface.cs: (PopulateMethod): Check for pointers being defined
14747 only if the unsafe context is active.
14748 (PopulateProperty): ditto.
14749 (PopulateIndexer): ditto.
14751 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
14752 specified. If pointers are present, make sure that they are
14753 present in an unsafe context.
14754 (Constructor, Constructor.Define): ditto.
14755 (Field, Field.Define): ditto.
14756 (Property, Property.Define): ditto.
14757 (Event, Event.Define): ditto.
14759 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
14760 hashtable if there are classes or structs defined.
14762 * expression.cs (LocalVariableReference.DoResolve): Simplify this
14763 code, as the constant resolution moved.
14765 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
14766 the metadata, so we can flag error 133.
14768 * decl.cs (MemberCore.UnsafeOK): New function to test that a
14769 pointer is being declared in an unsafe context.
14771 2002-01-16 Miguel de Icaza <miguel@ximian.com>
14773 * modifiers.cs (Modifiers.Check): Require a Location argument.
14774 Report error 227 for Unsafe use.
14776 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
14778 * statement.cs (For.Emit): If the test is null, then report that
14779 we do `return', as we wont reach anything afterwards.
14781 (Switch.SwitchGoverningType): Track the expression that matched
14784 * driver.cs: Allow negative numbers as an error code to flag.
14786 * cs-parser.jay: Handle 1551.
14788 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
14790 2002-01-15 Miguel de Icaza <miguel@ximian.com>
14792 * cs-parser.jay: Report 1518 (type declaration can only contain
14793 class, struct, interface, enum or delegate)
14795 (switch_label): Report 1523 (keywords `case' or `default' must
14798 (opt_switch_sections): Report 1522 (empty switch)
14800 * driver.cs: Report 1515 (response file specified multiple times)
14801 Report 1516 (Source file specified multiple times).
14803 * expression.cs (Argument.Resolve): Signal 1510
14805 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
14806 access not allowed in static code)
14808 2002-01-11 Ravi Pratap <ravi@ximian.com>
14810 * typemanager.cs (IsPointerType): Utility method which we are going
14813 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
14814 the object type, so we take care of that.
14816 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
14818 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
14819 added to non-params parameters :-)
14821 * typemanager.cs (CSharpName): Include 'void' type too.
14823 (void_ptr_type): Include in the set of core types.
14825 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
14828 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
14831 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
14832 completely forgotten about it.
14834 2002-01-10 Ravi Pratap <ravi@ximian.com>
14836 * cs-parser.jay (pointer_type): Add. This begins our implementation
14837 of parsing rules for unsafe code.
14839 (unsafe_statement): Implement.
14841 (embedded_statement): Modify to include the above.
14843 * statement.cs (Unsafe): Implement new class for unsafe blocks.
14845 * codegen.cs (EmitContext.InUnsafe): Add. This determines
14846 if the current context is an unsafe one.
14848 * cs-parser.jay (local_variable_pointer_type): Since local variable types
14849 are handled differently, we need separate rules for them.
14851 (local_variable_declaration): Update to use local_variable_pointer_type
14852 to allow variable declarations of unmanaged pointer types.
14854 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
14855 in unsafe contexts.
14857 * ../errors/cs0214.cs : Add.
14859 2002-01-16 Nick Drochak <ndrochak@gol.com>
14861 * makefile: remove 'response' file when cleaning.
14863 2002-01-15 Miguel de Icaza <miguel@ximian.com>
14865 * cs-parser.jay: Report 1524.
14867 2002-01-14 Miguel de Icaza <miguel@ximian.com>
14869 * typemanager.cs (RegisterMethod): drop checking if we have
14870 registered this from here
14872 2002-01-12 Miguel de Icaza <miguel@ximian.com>
14874 * class.cs (Method.EmitDestructor): Implement calling our base
14877 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
14878 value of InFinally.
14880 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
14881 this routine and will wrap the call in a try/catch block. Deal
14884 2002-01-11 Miguel de Icaza <miguel@ximian.com>
14886 * ecore.cs (Expression.MemberLookup): instead of taking a
14887 parameter `same_type' that was used to tell whether we could
14888 access private members we compute our containing type from the
14891 (FieldExpr): Added partial support for volatile fields. This does
14892 not work for volatile fields exposed from assemblies, as I can not
14893 figure out how to extract the modreq from it.
14895 Updated all the source files to use this.
14897 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
14898 because it is referenced by MemberLookup very often.
14900 2002-01-09 Ravi Pratap <ravi@ximian.com>
14902 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
14903 TypeBuilder.GetCustomAttributes to retrieve what we need.
14905 Get rid of redundant default_member_attr_type as this is the same as
14906 default_member_type which already exists.
14908 * interface.cs, attribute.cs : Update accordingly.
14910 2002-01-08 Miguel de Icaza <miguel@ximian.com>
14912 * typemanager.cs: Enable IndexerPropertyName again. It does not
14913 work for TYpeBuilders though. Ravi, can you please fix this?
14915 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
14917 * expression.cs (Argument.Emit): Handle the case of ref objects
14918 being passed to ref functions;
14920 (ParameterReference.EmitLoad): Loads the content of the pointer
14921 without dereferencing.
14923 2002-01-07 Miguel de Icaza <miguel@ximian.com>
14925 * cs-tokenizer.cs: Implemented the pre-processing expressions.
14927 2002-01-08 Ravi Pratap <ravi@ximian.com>
14929 * class.cs (Indexer.DefineMethod): Incorporate the interface
14930 type in the name of the method if we are doing explicit interface
14933 * expression.cs (ConversionExists): Remove as it is completely obsolete.
14935 (BetterConversion): Fix extremely trivial bug where we were referring to
14936 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
14939 * ../errors/bug16.cs : Add although we have fixed it.
14941 2002-01-07 Miguel de Icaza <miguel@ximian.com>
14943 * expression.cs (BaseIndexer): Begin implementation.
14945 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
14947 * cs-parser.jay (indexer_declarator): Use qualified_identifier
14948 production directly to remove a shift/reduce, and implement
14949 explicit interface implementation.
14951 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
14952 after a floating point suffix.
14954 * expression.cs (DoNumericPromotions): Improved the conversion for
14955 uint/uint. If we have a constant, we avoid doing a typecast to a
14958 * class.cs (Indexer): Implement explicit interface implementation
14961 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
14963 * class.cs: make the default instance constructor public and hidebysig.
14965 2001-01-03 Ravi Pratap <ravi@ximian.com>
14967 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
14968 so we can call it from elsewhere.
14970 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
14971 we emit it internally if the class has a defined indexer; otherwise the user
14972 emits it by decorating the class definition with the DefaultMemberAttribute.
14974 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
14975 attribute is not used on a type which defines an indexer.
14977 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
14978 character when we skip whitespace.
14980 * ../errors/cs0646.cs : Add.
14982 2002-01-03 Miguel de Icaza <miguel@ximian.com>
14984 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
14987 * makefile: Add practical target `mcs3.exe' which builds the third
14988 generation compiler.
14990 * expression.cs (New): Fix structures constructor calling.
14992 * class.cs (Property, Method, Indexer): Emit Final flag on the
14993 method if we are an interface implementation and we are not
14996 * ecore.cs (PropertyExpr): New public field `IsBase', tells
14997 whether this property is referencing a `base' method.
14999 * expression.cs (Invocation.EmitCall): take an extra argument:
15000 is_base, this is used to determine whether the `call' or
15001 `callvirt' opcode should be used.
15004 * delegate.cs: update EmitCall.
15006 * class.cs (Method.Define): Set NewSlot for the cases where we are
15007 not implementing an interface method.
15009 (Property.Define): ditto.
15011 2002-01-02 Miguel de Icaza <miguel@ximian.com>
15013 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
15014 'r'. Allows mcs to parse itself fully.
15016 2002-01-02 Ravi Pratap <ravi@ximian.com>
15018 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
15019 of the number of initializers that require the InitializeArray method.
15021 (CheckIndices): Store the Expression in all cases - not the plain value. Also
15022 update the above field where necessary.
15024 (MakeByteBlob): Update accordingly.
15026 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
15029 (EmitDynamicInitializers): Update in accordance with the new optimization.
15031 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
15032 same OpCode applies.
15034 * cs-parser.jay : Fix some glaring errors I introduced.
15036 2002-01-01 Ravi Pratap <ravi@ximian.com>
15038 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
15039 so that we can check for name clashes there too.
15041 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
15042 for interface indexers.
15044 * interfaces.cs (Define): Emit the default member attribute.
15046 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
15047 variable was being referred to while setting the value ;-)
15049 2002-01-01 Miguel de Icaza <miguel@ximian.com>
15051 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
15052 byte-by-byte information when we know the data is zero.
15054 Make the block always a multiple of 4, because
15055 DefineInitializedData has a bug.
15057 * assign.cs: Fix, we should assign from the temporary, not from
15060 * expression.cs (MakeByteBlob): Fix my incorrect code.
15062 2001-12-31 Miguel de Icaza <miguel@ximian.com>
15064 * typemanager.cs (EnumToUnderlying): This function is used to get
15065 the underlying type from an enumeration, because it does not
15068 * constant.cs: Use the I4_S form for values between -128 and 127.
15070 * statement.cs (Block.LookupLabel): Looks up a label.
15071 (Block): Drop support for labeled blocks.
15073 (LabeledStatement): New kind of statement that represents a label
15076 (Goto): Finally implement this bad boy.
15078 * cs-parser.jay: Update to reflect new mechanism to implement
15081 2001-12-30 Miguel de Icaza <miguel@ximian.com>
15083 * codegen.cs (EmitContext.This): a codegen property that keeps the
15084 a single instance of this instead of creating many different this
15087 * delegate.cs (Delegate.DoResolve): Update to use the property;
15089 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
15091 * expression.cs (BaseAccess.DoResolve): Ditto.
15093 2001-12-29 Ravi Pratap <ravi@ximian.com>
15095 * typemanager.cs (methodimpl_attr_type): Add to hold the type
15096 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
15098 (InitCoreTypes): Update accordingly.
15100 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
15101 so we can quickly store the state.
15103 (ApplyAttributes): Set the correct implementation flags
15104 for InternalCall methods.
15106 2001-12-29 Miguel de Icaza <miguel@ximian.com>
15108 * expression.cs (EmitCall): if a method is not virtual, then do
15109 not use callvirt on it.
15111 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
15112 user defined stuff) requires the use of stobj, which takes an
15113 address on the stack instead of an array and an index. So emit
15114 the Ldelema operation for it.
15116 (EmitStoreOpcode): Use stobj for valuetypes.
15118 (UnaryMutator.EmitCode): Use the right 1 value depending on
15119 whether we are dealing with int64/uint64, float or doubles.
15121 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
15122 constructors that I implemented last night.
15124 (Constructor.IsDefault): Fix to work properly for static
15127 * cs-parser.jay (CheckDef): report method signature errors.
15128 Update error number 103 to be 132.
15130 * decl.cs: New AdditionResult enumeration value: MethodExists.
15131 Although we do this check for methods later on in the semantic
15132 analysis, catching repeated default constructors is so easy that
15133 we catch these here.
15135 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
15138 (ParameterReference.EmitAssign, Emit): handle
15141 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
15142 (ArrayAccess.EmitStoreOpcode): ditto.
15144 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
15146 * expression.cs (MakeByteBlob): Complete all the missing types
15147 (uint, short, ushort, byte, sbyte)
15149 * class.cs: Only init instance field initializers on instance
15152 Rename `constructors' to instance_constructors.
15154 (TypeContainer.AddConstructor): Only add constructors to the list
15155 if it is not static.
15157 Make sure that we handle default_static_constructor independently
15158 everywhere where we handle instance_constructors
15160 2001-12-28 Miguel de Icaza <miguel@ximian.com>
15162 * class.cs: Do not lookup or create a base initializer for a
15163 static constructor.
15165 (ConstructorInitializer.Resolve): use the proper type to lookup
15168 * cs-parser.jay: Report error 1585 (modifiers between type and name).
15170 * enum.cs, interface.cs: Remove CloseType, this is taken care by
15173 * decl.cs: CloseType is now an virtual method, the default
15174 implementation just closes this type.
15176 2001-12-28 Ravi Pratap <ravi@ximian.com>
15178 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
15179 to PreserveSig by default. Also emit HideBySig on such methods.
15181 Basically, set the defaults to standard values.
15183 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
15184 argument, if candidate is better, it can't be worse than the best !
15186 (Invocation): Re-write bits to differentiate between methods being
15187 applicable in their expanded form and their normal form - for params
15190 Get rid of use_standard everywhere as only standard conversions are allowed
15191 in overload resolution.
15193 More spec conformance.
15195 2001-12-27 Miguel de Icaza <miguel@ximian.com>
15197 * driver.cs: Add --timestamp, to see where the compiler spends
15200 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
15201 `this' in static code.
15203 (SimpleName.DoResolve): Implement in terms of a helper function
15204 that allows static-references to be passed upstream to
15207 (Expression.ResolveWithSimpleName): Resolve specially simple
15208 names when called by MemberAccess to implement the special
15211 (Expression.ImplicitReferenceConversion): Handle conversions from
15212 Null to reference types before others, as Null's type is
15215 * expression.cs (Invocation.EmitCall): Handle the special case of
15216 calling methods declared on a reference type from a ValueType
15217 (Base classes System.Object and System.Enum)
15219 (MemberAccess.Resolve): Only perform lookups on Enumerations if
15220 the left hand side is a TypeExpr, not on every enumeration.
15222 (Binary.Resolve): If types are reference types, then do a cast to
15223 object on operators != and == of both arguments.
15225 * typemanager.cs (FindMembers): Extract instance and static
15226 members if requested.
15228 * interface.cs (PopulateProperty): Use void_type instead of null
15229 as the return type for the setter method.
15231 (PopulateIndexer): ditto.
15233 2001-12-27 Ravi Pratap <ravi@ximian.com>
15235 * support.cs (ReflectionParameters): Fix minor bug where we
15236 were examining the wrong parameter for the ParamArray attribute.
15238 Cope with requests for the type of the parameter at position
15239 greater than the params parameter's. We now return the element
15240 type of the params array as that makes more sense.
15242 * expression.cs (Invocation.IsParamsMethodApplicable): Update
15243 accordingly as we no longer have to extract the element type
15246 (Invocation.OverloadResolve): Update.
15248 2001-12-27 Miguel de Icaza <miguel@ximian.com>
15250 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
15251 against IEnumerator, test whether the return value is a descendant
15252 of the IEnumerator interface.
15254 * class.cs (Indexer.Define): Use an auxiliary method to implement
15255 the other bits of the method definition. Begin support for
15256 explicit interface implementation.
15258 (Property.DefineMethod): Use TypeManager.void_type instead of null
15259 for an empty return value.
15261 2001-12-26 Miguel de Icaza <miguel@ximian.com>
15263 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
15264 dealing with a FieldExpr which is composed of a FieldBuilder, in
15265 the code path we did extract the constant, but we should have
15266 obtained the underlying value to be able to cast it (otherwise we
15267 end up in an infinite loop, this is what Ravi was running into).
15269 (ArrayCreation.UpdateIndices): Arrays might be empty.
15271 (MemberAccess.ResolveMemberAccess): Add support for section
15272 14.5.4.1 that deals with the special case of E.I when E is a type
15273 and something else, that I can be a reference to a static member.
15275 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
15276 handle a particular array type to create byte blobs, it is just
15277 something we dont generate byteblobs for.
15279 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
15282 * location.cs (Push): remove the key from the hashtable that we
15283 are about to add. This happens for empty files.
15285 * driver.cs: Dispose files after we have parsed them.
15287 (tokenize): new function that only runs the tokenizer on its
15288 input, for speed testing.
15290 2001-12-26 Ravi Pratap <ravi@ximian.com>
15292 * class.cs (Event.Define): Define the private field only if there
15293 are no accessors defined.
15295 * expression.cs (ResolveMemberAccess): If there is no associated
15296 field with the event, that means we have an event defined with its
15297 own accessors and we should flag error cs0070 since transforming
15298 ourselves into a field is not valid in that case.
15300 * ecore.cs (SimpleName.DoResolve): Same as above.
15302 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
15303 and charset to sane values.
15305 2001-12-25 Ravi Pratap <ravi@ximian.com>
15307 * assign.cs (DoResolve): Perform check on events only if they
15308 are being accessed outside the declaring type.
15310 * cs-parser.jay (event_declarations): Update rules to correctly
15311 set the type of the implicit parameter etc.
15313 (add_accessor, remove_accessor): Set current local parameters.
15315 * expression.cs (Binary): For delegate addition and subtraction,
15316 cast the return value from the method into the appropriate delegate
15319 2001-12-24 Ravi Pratap <ravi@ximian.com>
15321 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
15322 of these as the workaround is unnecessary.
15324 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
15325 delegate data - none of that is needed at all.
15327 Re-write bits to extract the instance expression and the delegate method
15330 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
15333 * attribute.cs (ApplyAttributes): New method to take care of common tasks
15334 of attaching attributes instead of duplicating code everywhere.
15336 * everywhere : Update code to do attribute emission using the above method.
15338 2001-12-23 Miguel de Icaza <miguel@ximian.com>
15340 * expression.cs (IsParamsMethodApplicable): if there are not
15341 parameters, return immediately.
15343 * ecore.cs: The 0 literal can be implicity converted to an enum
15346 (SimpleName.DoResolve): First lookup the type, then lookup the
15349 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
15350 want to get its address. If the InstanceExpression is not
15351 addressable, store the result in a temporary variable, then get
15354 * codegen.cs: Only display 219 errors on warning level or above.
15356 * expression.cs (ArrayAccess): Make it implement the
15357 IMemoryLocation interface.
15359 (Binary.DoResolve): handle the operator == (object a, object b)
15360 and operator != (object a, object b) without incurring into a
15361 BoxedCast (because 5 != o should never be performed).
15363 Handle binary enumerator operators.
15365 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
15366 value type, otherwise use Ldelem_ref.
15368 Use precomputed names;
15370 (AddressOf): Implement address of
15372 * cs-parser.jay (labeled_statement): Fix recursive block
15373 addition by reworking the production.
15375 * expression.cs (New.DoEmit): New has a special case:
15377 If we are dealing with a ValueType, we have a few
15378 situations to deal with:
15380 * The target of New is a ValueType variable, that is
15381 easy, we just pass this as the variable reference
15383 * The target of New is being passed as an argument,
15384 to a boxing operation or a function that takes a
15387 In this case, we need to create a temporary variable
15388 that is the argument of New.
15391 2001-12-23 Ravi Pratap <ravi@ximian.com>
15393 * rootcontext.cs (LookupType): Check that current_type is not null before
15394 going about looking at nested types.
15396 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
15397 not implement the IAssignMethod interface any more.
15399 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
15400 where we tranform them into FieldExprs if they are being resolved from within
15401 the declaring type.
15403 * ecore.cs (SimpleName.DoResolve): Do the same here.
15405 * assign.cs (DoResolve, Emit): Clean up code considerably.
15407 * ../errors/bug10.cs : Add.
15409 * ../errors/cs0070.cs : Add.
15411 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
15413 * assign.cs : Get rid of EventIsLocal everywhere.
15415 2001-12-23 Miguel de Icaza <miguel@ximian.com>
15417 * ecore.cs (ConvertIntLiteral): finished the implementation.
15419 * statement.cs (SwitchLabel): Convert the value we are using as a
15420 key before looking up the table.
15422 2001-12-22 Miguel de Icaza <miguel@ximian.com>
15424 * codegen.cs (EmitTopBlock): Require a Location argument now.
15426 * cs-parser.jay (constructor_declarator): We need to setup
15427 current_local_parameters before we parse the
15428 opt_constructor_initializer, to allow the variables to be bound
15429 to the constructor arguments.
15431 * rootcontext.cs (LookupType): First lookup nested classes in our
15432 class and our parents before we go looking outside our class.
15434 * expression.cs (ConstantFold): Extract/debox the values at the
15437 * rootcontext.cs (EmitCode): Resolve the constants first before we
15438 resolve the types. This is not really needed, but it helps debugging.
15440 * statement.cs: report location.
15442 * cs-parser.jay: pass location to throw statement.
15444 * driver.cs: Small bug fix.
15446 * report.cs: Updated format to be 4-zero filled digits.
15448 2001-12-22 Ravi Pratap <ravi@ximian.com>
15450 * expression.cs (CheckIndices): Fix minor bug where the wrong
15451 variable was being referred to ;-)
15453 (DoEmit): Do not call EmitStaticInitializers when the
15454 underlying type is System.Object.
15456 2001-12-21 Ravi Pratap <ravi@ximian.com>
15458 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
15459 and do the usual workaround for SRE.
15461 * class.cs (MyEventBuilder.EventType): New member to get at the type
15462 of the event, quickly.
15464 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
15466 * assign.cs (Assign.DoResolve): Handle the case when the target
15467 is an EventExpr and perform the necessary checks.
15469 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
15472 (SimpleName.MemberStaticCheck): Include check for EventExpr.
15474 (EventExpr): Set the type in the constructor itself since we
15475 are meant to be born fully resolved.
15477 (EventExpr.Define): Revert code I wrote earlier.
15479 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
15480 instance expression is null. The instance expression is a This in that case
15481 or a null, depending on whether it is a static method or not.
15483 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
15484 refers to more than one method.
15486 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
15487 and accordingly flag errors.
15489 2001-12-21 Miguel de Icaza <miguel@ximian.com>
15491 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
15493 2001-12-22 Miguel de Icaza <miguel@ximian.com>
15495 * location.cs (ToString): Provide useful rutine.
15497 2001-12-21 Miguel de Icaza <miguel@ximian.com>
15499 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
15500 objects, return the actual integral boxed.
15502 * statement.cs (SwitchLabel): define an ILLabel for each
15505 (Switch.CheckSwitch): If the value is a Literal, extract
15506 the underlying literal.
15508 Also in the unused hashtable we had, add the SwitchLabel so we can
15509 quickly look this value up.
15511 * constant.cs: Implement a bunch of new constants. Rewrite
15512 Literal based on this. Made changes everywhere to adapt to this.
15514 * expression.cs (Expression.MakeByteBlob): Optimize routine by
15515 dereferencing array only once, and also copes with enumrations.
15517 bytes are two bytes wide, not one.
15519 (Cast): Perform constant conversions.
15521 * ecore.cs (TryImplicitIntConversion): Return literals instead of
15522 wrappers to the literals here.
15524 * expression.cs (DoNumericPromotions): long literals can converted
15525 to ulong implicity (this is taken care of elsewhere, but I was
15526 missing this spot).
15528 * ecore.cs (Expression.Literalize): Make the return type Literal,
15529 to improve type checking.
15531 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
15533 2001-12-20 Miguel de Icaza <miguel@ximian.com>
15535 * literal.cs: Revert code from ravi that checked the bounds. The
15536 bounds are sane by the definition of the type itself.
15538 * typemanager.cs: Fix implementation of ImplementsInterface. We
15539 need to actually look up in our parent hierarchy for interfaces
15542 * const.cs: Use the underlying type for enumerations
15544 * delegate.cs: Compute the basename for the delegate creation,
15545 that should fix the delegate test case, and restore the correct
15546 Type Lookup semantics in rootcontext
15548 * rootcontext.cs: Revert Ravi's last patch. The correct way of
15549 referencing a nested type with the Reflection API is using the "+"
15552 * cs-parser.jay: Do not require EOF token at the end.
15554 2001-12-20 Ravi Pratap <ravi@ximian.com>
15556 * rootcontext.cs (LookupType): Concatenate type names with
15557 a '.' instead of a '+' The test suite passes again.
15559 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
15560 field of the enumeration.
15562 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
15563 the case when the member is an EventExpr.
15565 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
15566 static has an associated instance expression.
15568 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
15570 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
15572 * class.cs (Event.Define): Register event and perform appropriate checks
15575 We define the Add and Remove methods even if the use provides none because
15576 in that case, we provide default implementations ourselves.
15578 Define a private field of the type of the event. This is done by the CSC compiler
15579 and we should be doing it too ;-)
15581 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
15582 More methods we use in code we generate.
15584 (multicast_delegate_type, delegate_type): Two separate types since the distinction
15587 (InitCoreTypes): Update accordingly for the above.
15589 * class.cs (Event.Emit): Generate code for default accessors that we provide
15591 (EmitDefaultMethod): Do the job in the above.
15593 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
15596 2001-12-20 Miguel de Icaza <miguel@ximian.com>
15598 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
15599 builders even if we were missing one.
15601 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
15602 pass the Basename as our class name instead of the Name. The
15603 basename will be correctly composed for us.
15605 * parameter.cs (Paramters): Now takes a Location argument.
15607 * decl.cs (DeclSpace.LookupType): Removed convenience function and
15608 make all the code call directly LookupType in RootContext and take
15609 this chance to pass the Location information everywhere.
15611 * Everywhere: pass Location information.
15613 2001-12-19 Miguel de Icaza <miguel@ximian.com>
15615 * class.cs (Constructor.Define): Updated way of detecting the
15616 length of the parameters.
15618 (TypeContainer.DefineType): Use basename as the type name for
15621 (TypeContainer.Define): Do not recursively define types here, as
15622 definition is taken care in order by the RootContext.
15624 * tree.cs: Keep track of namespaces in a per-file basis.
15626 * parameter.cs (Parameter.ComputeSignature): Update to use
15629 (Parameters.GetSignature): ditto.
15631 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
15632 instead of a TypeContainer.
15634 (Interface.SemanticAnalysis): Use `this' instead of our parent to
15635 resolve names. Because we need to be resolve in our context, not
15638 * driver.cs: Implement response files.
15640 * class.cs (TypeContainer.DefineType): If we are defined, do not
15641 redefine ourselves.
15643 (Event.Emit): Emit the code for add/remove handlers.
15644 (Event.Define): Save the MethodBuilders for add/remove.
15646 * typemanager.cs: Use pair here too.
15648 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
15649 DictionaryEntry requires the first argument to be non-null.
15651 (enum_declaration): Compute full name for registering the
15654 (delegate_declaration): Instead of using
15655 formal_parameter_list, use opt_formal_parameter_list as the list
15658 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
15659 (EventParsing): New property that controls whether `add' and
15660 `remove' are returned as tokens or identifiers (for events);
15662 2001-12-19 Ravi Pratap <ravi@ximian.com>
15664 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
15665 use MyEventBuilder only and let it wrap the real builder for us.
15667 (MyEventBuilder): Revamp constructor etc.
15669 Implement all operations that we perform on EventBuilder in precisely the same
15672 (FindMembers): Update to use the EventBuilder member.
15674 (Event.Emit): Update accordingly.
15676 2001-12-18 Ravi Pratap <ravi@ximian.com>
15678 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
15679 by calling the appropriate methods.
15681 (GetCustomAttributes): Make stubs as they cannot possibly do anything
15684 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
15686 2001-12-17 Ravi Pratap <ravi@ximian.com>
15688 * delegate.cs (Delegate.Populate): Check that the return type
15689 and various parameters types are indeed accessible.
15691 * class.cs (Constructor.Define): Same here.
15693 (Field.Define): Ditto.
15695 (Event.Define): Ditto.
15697 (Operator.Define): Check that the underlying Method defined itself
15698 correctly - so it's MethodBuilder should not be null.
15700 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
15701 expression happens to be null.
15703 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
15704 members but as of now we don't seem to be able to do anything really useful with it.
15706 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
15707 not the EventBuilder.
15709 2001-12-18 Miguel de Icaza <miguel@ximian.com>
15711 * cs-tokenizer.cs: Add support for defines.
15712 Add support for #if, #elif, #else, #endif
15714 (eval_var): evaluates a variable.
15715 (eval): stubbed for evaluating functions.
15717 * cs-parser.jay: Pass the defines information
15719 * driver.cs: Add --define command line option.
15721 * decl.cs: Move MemberCore here.
15723 Make it the base class for DeclSpace. This allows us to catch and
15724 report 108 and 109 for everything now.
15726 * class.cs (TypeContainer.Define): Extract all the members
15727 before populating and emit the warning 108 (new keyword required
15728 to override) instead of having each member implement this.
15730 (MemberCore.Define): New abstract method, we will be using this in
15731 the warning reporting engine in Populate.
15733 (Operator.Define): Adjust to new MemberCore protocol.
15735 * const.cs (Const): This does not derive from Expression, it is a
15736 temporary object we use to create fields, it is a MemberCore.
15738 * class.cs (Method.Define): Allow the entry point to be in a
15741 * driver.cs: Rewrite the argument handler to clean it up a bit.
15743 * rootcontext.cs: Made it just an auxiliary namespace feature by
15744 making everything static.
15746 * driver.cs: Adapt code to use RootContext type name instead of
15749 * delegate.cs: Remove RootContext argument.
15751 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
15754 * class.cs (Event.Define): The lookup can fail.
15756 * cs-tokenizer.cs: Begin implementation of pre-procesor.
15758 * expression.cs: Resolve the this instance before invoking the code.
15760 2001-12-17 Miguel de Icaza <miguel@ximian.com>
15762 * cs-parser.jay: Add a production in element_access that allows
15763 the thing to become a "type" reference. This way we can parse
15764 things like "(string [])" as a type.
15766 Note that this still does not handle the more complex rules of
15770 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
15772 * ecore.cs: (CopyNewMethods): new utility function used to
15773 assemble the list of methods from running FindMembers.
15775 (MemberLookup): Rework FindMembers so that
15777 2001-12-16 Miguel de Icaza <miguel@ximian.com>
15779 * class.cs (TypeContainer): Remove Delegates who fail to be
15782 * delegate.cs (Populate): Verify that we dont get null return
15783 values. TODO: Check for AsAccessible.
15785 * cs-parser.jay: Use basename to emit error 574 (destructor should
15786 have the same name as container class), not the full name.
15788 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
15789 possible representation.
15791 Also implements integer type suffixes U and L.
15793 2001-12-15 Miguel de Icaza <miguel@ximian.com>
15795 * expression.cs (ArrayCreation.DoResolve): We need to do the
15796 argument resolution *always*.
15798 * decl.cs: Make this hold the namespace. Hold the root context as
15800 (LookupType): Move here.
15802 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
15804 * location.cs (Row, Name): Fixed the code, it was always returning
15805 references to the first file.
15807 * interface.cs: Register properties defined through interfaces.
15809 * driver.cs: Add support for globbing on the command line
15811 * class.cs (Field): Make it derive from MemberCore as well.
15814 2001-12-15 Ravi Pratap <ravi@ximian.com>
15816 * class.cs (Event::Define): Check that the type of the event is a delegate
15817 type else flag error #66.
15819 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
15822 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
15823 values of EntryPoint, CharSet etc etc.
15825 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
15827 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
15828 be null and we should ignore this. I am not sure if this is really clean. Apparently,
15829 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
15830 which needs this to do its work.
15832 * ../errors/cs0066.cs : Add.
15834 2001-12-14 Miguel de Icaza <miguel@ximian.com>
15836 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
15839 * class.cs: (MethodSignature.MethodSignature): Removed hack that
15840 clears out the parameters field.
15841 (MemberSignatureCompare): Cleanup
15843 (MemberCore): New base class used to share code between MethodCore
15846 (RegisterRequiredImplementations) BindingFlags.Public requires
15847 either BindingFlags.Instace or Static. Use instance here.
15849 (Property): Refactored code to cope better with the full spec.
15851 * parameter.cs (GetParameterInfo): Return an empty array instead
15854 * class.cs (Property): Abstract or extern properties have no bodies.
15856 * parameter.cs (GetParameterInfo): return a zero-sized array.
15858 * class.cs (TypeContainer.MethodModifiersValid): Move all the
15859 method modifier validation to the typecontainer so we can reuse
15860 this on properties.
15862 (MethodCore.ParameterTypes): return an empty sized array of types.
15864 (Property.Define): Test property modifier validity.
15866 Add tests for sealed/override too.
15868 (Method.Emit): abstract or extern methods have no bodies.
15870 2001-12-14 Ravi Pratap <ravi@ximian.com>
15872 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
15875 (Method::Define, ::Emit): Modify accordingly.
15877 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
15879 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
15881 * makefile: Pass in /unsafe.
15883 2001-12-13 Miguel de Icaza <miguel@ximian.com>
15885 * class.cs (MakeKey): Kill routine.
15887 * class.cs (TypeContainer.Define): Correctly define explicit
15888 method implementations (they require the full interface name plus
15891 * typemanager.cs: Deply the PtrHashtable here and stop using the
15892 lame keys. Things work so much better.
15894 This of course broke everyone who depended on `RegisterMethod' to
15895 do the `test for existance' test. This has to be done elsewhere.
15897 * support.cs (PtrHashtable): A hashtable that avoid comparing with
15898 the object stupid Equals method (because, that like fails all over
15899 the place). We still do not use it.
15901 * class.cs (TypeContainer.SetRequiredInterface,
15902 TypeContainer.RequireMethods): Killed these two routines and moved
15903 all the functionality to RegisterRequiredImplementations.
15905 (TypeContainer.RegisterRequiredImplementations): This routine now
15906 registers all the implementations required in an array for the
15907 interfaces and abstract methods. We use an array of structures
15908 which can be computed ahead of time to reduce memory usage and we
15909 also assume that lookups are cheap as most classes will not
15910 implement too many interfaces.
15912 We also avoid creating too many MethodSignatures.
15914 (TypeContainer.IsInterfaceMethod): Update and optionally does not
15915 clear the "pending" bit if we find that there are problems with
15918 (TypeContainer.VerifyPendingMethods): Update to report errors of
15919 methods that look like implementations but are not.
15921 (TypeContainer.Define): Add support for explicit interface method
15924 2001-12-12 Miguel de Icaza <miguel@ximian.com>
15926 * typemanager.cs: Keep track of the parameters here instead of
15927 being a feature of the TypeContainer.
15929 * class.cs: Drop the registration of parameters here, as
15930 InterfaceMethods are also interface declarations.
15932 * delegate.cs: Register methods with the TypeManager not only with
15933 the TypeContainer. This code was buggy.
15935 * interface.cs: Full registation here.
15937 2001-12-11 Miguel de Icaza <miguel@ximian.com>
15939 * expression.cs: Remove reducer for binary expressions, it can not
15942 * const.cs: Put here the code that used to go into constant.cs
15944 * constant.cs: Put here the code for constants, this is a new base
15945 class for Literals.
15947 * literal.cs: Make Literal derive from Constant.
15949 2001-12-09 Miguel de Icaza <miguel@ximian.com>
15951 * statement.cs (Return.Emit): Report error 157 if the user
15952 attempts to return from a finally block.
15954 (Return.Emit): Instead of emitting a return, jump to the end of
15957 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
15958 LocalBuilder to store the result of the function. ReturnLabel is
15959 the target where we jump.
15962 2001-12-09 Radek Doulik <rodo@ximian.com>
15964 * cs-parser.jay: remember alias in current namespace
15966 * ecore.cs (SimpleName::DoResolve): use aliases for types or
15969 * class.cs (LookupAlias): lookup alias in my_namespace
15971 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
15973 (LookupAlias): lookup alias in this and if needed in parent
15976 2001-12-08 Miguel de Icaza <miguel@ximian.com>
15980 * rootcontext.cs: (ModuleBuilder) Made static, first step into
15981 making things static. I need this to avoid passing the
15982 TypeContainer when calling ParameterType.
15984 * support.cs (InternalParameters.ParameterType): Remove ugly hack
15985 that did string manipulation to compute the type and then call
15986 GetType. Use Parameter.ParameterType instead.
15988 * cs-tokenizer.cs: Consume the suffix for floating values.
15990 * expression.cs (ParameterReference): figure out whether this is a
15991 reference parameter or not. Kill an extra variable by computing
15992 the arg_idx during emission.
15994 * parameter.cs (Parameters.GetParameterInfo): New overloaded
15995 function that returns whether a parameter is an out/ref value or not.
15997 (Parameter.ParameterType): The type of the parameter (base,
15998 without ref/out applied).
16000 (Parameter.Resolve): Perform resolution here.
16001 (Parameter.ExternalType): The full type (with ref/out applied).
16003 * statement.cs (Using.Emit, Using.EmitExpression): Implement
16004 support for expressions on the using statement.
16006 2001-12-07 Miguel de Icaza <miguel@ximian.com>
16008 * statement.cs (Using.EmitLocalVariableDecls): Split the
16009 localvariable handling of the using statement.
16011 (Block.EmitMeta): Keep track of variable count across blocks. We
16012 were reusing slots on separate branches of blocks.
16014 (Try.Emit): Emit the general code block, we were not emitting it.
16016 Check the type of the declaration to be an IDisposable or
16017 something that can be implicity converted to it.
16019 Emit conversions if required.
16021 * ecore.cs (EmptyExpression): New utility class.
16022 (Expression.ImplicitConversionExists): New utility function.
16024 2001-12-06 Miguel de Icaza <miguel@ximian.com>
16026 * statement.cs (Using): Implement.
16028 * expression.cs (LocalVariableReference): Support read only variables.
16030 * statement.cs: Remove the explicit emit for the Leave opcode.
16031 (VariableInfo): Add a readonly field.
16033 2001-12-05 Miguel de Icaza <miguel@ximian.com>
16035 * ecore.cs (ConvCast): new class used to encapsulate the various
16036 explicit integer conversions that works in both checked and
16037 unchecked contexts.
16039 (Expression.ConvertNumericExplicit): Use new ConvCast class to
16040 properly generate the overflow opcodes.
16042 2001-12-04 Miguel de Icaza <miguel@ximian.com>
16044 * statement.cs: The correct type for the EmptyExpression is the
16045 element_type, not the variable type. Ravi pointed this out.
16047 2001-12-04 Ravi Pratap <ravi@ximian.com>
16049 * class.cs (Method::Define): Handle PInvoke methods specially
16050 by using DefinePInvokeMethod instead of the usual one.
16052 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
16053 above to do the task of extracting information and defining the method.
16055 2001-12-04 Ravi Pratap <ravi@ximian.com>
16057 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
16058 of the condition for string type.
16060 (Emit): Move that here.
16062 (ArrayCreation::CheckIndices): Keep string literals in their expression
16065 (EmitDynamicInitializers): Handle strings appropriately.
16067 2001-12-04 Miguel de Icaza <miguel@ximian.com>
16069 * codegen.cs (EmitContext): Replace multiple variables with a
16070 single pointer to the current Switch statement.
16072 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
16075 2001-12-03 Miguel de Icaza <miguel@ximian.com>
16079 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
16082 (Foreach.Emit): Foreach on arrays was not setting
16083 up the loop variables (for break/continue).
16085 (GotoCase): Semi-implented.
16087 2001-12-03 Ravi Pratap <ravi@ximian.com>
16089 * attribute.cs (CheckAttribute): Handle system attributes by using
16090 Attribute.GetAttributes to examine information we need.
16092 (GetValidPlaces): Same here.
16094 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
16096 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
16098 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
16100 (Method::Define): Set appropriate flags if we have a DllImport attribute.
16102 (Method::Emit): Handle the case when we are a PInvoke method.
16104 2001-12-03 Miguel de Icaza <miguel@ximian.com>
16106 * expression.cs: Use ResolveWithSimpleName on compound names.
16108 2001-12-02 Ravi Pratap <ravi@ximian.com>
16110 * constant.cs (EmitConstant): Make sure we resolve the associated expression
16111 before trying to reduce it.
16113 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
16115 * constant.cs (LookupConstantValue): Implement.
16117 (EmitConstant): Use the above in emitting the constant.
16119 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
16120 that are user-defined by doing a LookupConstantValue on them.
16122 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
16125 2001-11-29 Miguel de Icaza <miguel@ximian.com>
16127 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
16129 (BaseAccess.DoResolve): Implement.
16131 (MemberAccess.DoResolve): Split this routine into a
16132 ResolveMemberAccess routine that can be used independently
16134 2001-11-28 Miguel de Icaza <miguel@ximian.com>
16136 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
16137 As that share bits of the implementation. Is returns a boolean,
16138 while As returns the Type that is being probed.
16140 2001-12-01 Ravi Pratap <ravi@ximian.com>
16142 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
16143 instead of a Literal - much easier.
16145 (EnumInTransit): Remove - utterly useless :-)
16147 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
16149 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
16151 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
16152 chain when we have no associated expression.
16154 2001-11-30 Ravi Pratap <ravi@ximian.com>
16156 * constant.cs (Define): Use Location while reporting the errror.
16158 Also emit a warning when 'new' is used and there is no inherited
16161 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
16164 (LookupEnumValue): Implement to lookup an enum member's value and define it
16167 (Populate): Re-write accordingly to use the above routine.
16169 2001-11-27 Miguel de Icaza <miguel@ximian.com>
16171 * expression.cs (This): Fix prototype for DoResolveLValue to
16172 override the base class DoResolveLValue.
16174 * cs-parser.cs: Report errors cs574 and cs575 (destructor
16177 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
16178 (we need to load the address of the field here). This fixes
16181 (FieldExpr.DoResolveLValue): Call the DoResolve
16182 function to initialize the Instance expression.
16184 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
16185 correctly the GetEnumerator operation on a value type.
16187 * cs-parser.jay: Add more simple parsing error catches.
16189 * statement.cs (Switch): Add support for string switches.
16190 Handle null specially.
16192 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
16194 2001-11-28 Ravi Pratap <ravi@ximian.com>
16196 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
16198 (declare_local_constant): New helper function.
16200 * statement.cs (AddConstant): Keep a separate record of constants
16202 (IsConstant): Implement to determine if a variable is a constant.
16204 (GetConstantExpression): Implement.
16206 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
16208 * statement.cs (IsVariableDefined): Re-write.
16210 2001-11-27 Ravi Pratap <ravi@ximian.com>
16212 * class.cs (TypeContainer::FindMembers): Look for constants
16213 in the case when we are looking for MemberTypes.Field
16215 * expression.cs (MemberAccess::DoResolve): Check that in the
16216 case we are a FieldExpr and a Literal, we are not being accessed
16217 by an instance reference.
16219 * cs-parser.jay (local_constant_declaration): Implement.
16221 (declaration_statement): Implement for constant declarations.
16223 2001-11-26 Miguel de Icaza <miguel@ximian.com>
16225 * statement.cs (Switch): Catch double defaults.
16227 (Switch): More work on the switch() statement
16228 implementation. It works for integral values now, need to finish
16232 2001-11-24 Miguel de Icaza <miguel@ximian.com>
16234 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
16235 integer literals into other integer literals. To be used by
16238 2001-11-24 Ravi Pratap <ravi@ximian.com>
16240 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
16243 (EmitDynamicInitializers): Cope with the above since we extract data
16244 directly from ArrayData now.
16246 (ExpectInitializers): Keep track of whether initializers are mandatory
16249 (Bounds): Make it a hashtable to prevent the same dimension being
16250 recorded for every element in that dimension.
16252 (EmitDynamicInitializers): Fix bug which prevented the Set array method
16255 Also fix bug which was causing the indices to be emitted in the reverse
16258 2001-11-24 Miguel de Icaza <miguel@ximian.com>
16260 * expression.cs (ArrayCreation): Implement the bits that Ravi left
16261 unfinished. They do not work, because the underlying code is
16264 2001-11-22 Miguel de Icaza <miguel@ximian.com>
16266 * cs-parser.jay: Remove bogus fixme.
16268 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
16269 on Switch statement.
16271 2001-11-23 Ravi Pratap <ravi@ximian.com>
16273 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
16276 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
16277 parameter. Apparently, any expression is allowed.
16279 (ValidateInitializers): Update accordingly.
16281 (CheckIndices): Fix some tricky bugs thanks to recursion.
16283 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
16284 I was being completely brain-dead.
16286 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
16287 and re-write acordingly.
16289 (DelegateInvocation): Re-write accordingly.
16291 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
16293 (MakeByteBlob): Handle types more correctly.
16295 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
16296 initialization from expressions but it is incomplete because I am a complete
16299 2001-11-22 Miguel de Icaza <miguel@ximian.com>
16301 * statement.cs (If.Emit): Fix a bug that generated incorrect code
16302 on If. Basically, we have to return `true' (ie, we do return to
16303 our caller) only if both branches of the if return.
16305 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
16306 short-circuit operators, handle them as short circuit operators.
16308 (Cast.DoResolve): Resolve type.
16309 (Cast.Cast): Take an expression as the target type.
16311 * cs-parser.jay (cast_expression): Remove old hack that only
16312 allowed a limited set of types to be handled. Now we take a
16313 unary_expression and we resolve to a type during semantic
16316 Use the grammar productions from Rhys to handle casts (this is
16317 not complete like Rhys syntax yet, we fail to handle that corner
16318 case that C# has regarding (-x), but we will get there.
16320 2001-11-22 Ravi Pratap <ravi@ximian.com>
16322 * class.cs (EmitFieldInitializer): Take care of the case when we have a
16323 field which is an array type.
16325 * cs-parser.jay (declare_local_variables): Support array initialization too.
16327 * typemanager.cs (MakeKey): Implement.
16329 (everywhere): Use the above appropriately.
16331 * cs-parser.jay (for_statement): Update for array initialization while
16332 declaring variables.
16334 * ecore.cs : The error message was correct, it's the variable's names that
16335 were misleading ;-) Make the code more readable.
16337 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
16338 the correct type etc.
16340 (ConvertExplicit): Handle Enum types by examining the underlying type.
16342 2001-11-21 Ravi Pratap <ravi@ximian.com>
16344 * parameter.cs (GetCallingConvention): Always return
16345 CallingConventions.Standard for now.
16347 2001-11-22 Miguel de Icaza <miguel@ximian.com>
16349 * expression.cs (Binary.ResolveOperator): Update the values of `l'
16350 and `r' after calling DoNumericPromotions.
16352 * ecore.cs: Fix error message (the types were in the wrong order).
16354 * statement.cs (Foreach.ProbeCollectionType): Need to pass
16355 BindingFlags.Instance as well
16357 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
16358 implicit int literal conversion in an empty cast so that we
16359 propagate the right type upstream.
16361 (UnboxCast): new class used to unbox value types.
16362 (Expression.ConvertExplicit): Add explicit type conversions done
16365 (Expression.ImplicitNumericConversion): Oops, forgot to test for
16366 the target type before applying the implicit LongLiterals to ULong
16369 2001-11-21 Miguel de Icaza <miguel@ximian.com>
16371 * cs-parser.jay (for_statement): Reworked the way For works: now
16372 we declare manually any variables that are introduced in
16373 for_initializer to solve the problem of having out-of-band code
16374 emition (that is what got for broken).
16376 (declaration_statement): Perform the actual variable declaration
16377 that used to be done in local_variable_declaration here.
16379 (local_variable_declaration): Do not declare anything, just pass
16380 the information on a DictionaryEntry
16382 2001-11-20 Ravi Pratap <ravi@ximian.com>
16384 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
16385 re-write of the logic to now make it recursive.
16387 (UpdateIndices): Re-write accordingly.
16389 Store element data in a separate ArrayData list in the above methods.
16391 (MakeByteBlob): Implement to dump the array data into a byte array.
16393 2001-11-19 Ravi Pratap <ravi@ximian.com>
16395 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
16398 * constant.cs (Define): Implement.
16400 (EmitConstant): Re-write fully.
16402 Pass in location info.
16404 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
16407 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
16408 DictionaryEntry since we need location info too.
16410 (constant_declaration): Update accordingly.
16412 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
16413 code into another method : UpdateIndices.
16415 2001-11-18 Ravi Pratap <ravi@ximian.com>
16417 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
16418 some type checking etc.
16420 2001-11-17 Ravi Pratap <ravi@ximian.com>
16422 * expression.cs (ArrayCreation::ValidateInitializers): Implement
16423 bits to provide dimension info if the user skips doing that.
16425 Update second constructor to store the rank correctly.
16427 2001-11-16 Ravi Pratap <ravi@ximian.com>
16429 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
16430 and try to implement.
16432 * ../errors/cs0150.cs : Add.
16434 * ../errors/cs0178.cs : Add.
16436 2001-11-16 Miguel de Icaza <miguel@ximian.com>
16438 * statement.cs: Implement foreach on multi-dimensional arrays.
16440 * parameter.cs (Parameters.GetParameterByName): Also lookup the
16441 name of the params argument.
16443 * expression.cs: Use EmitStoreOpcode to get the right opcode while
16444 initializing the array.
16446 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
16447 we can use this elsewhere.
16449 * statement.cs: Finish implementation of foreach for single
16452 * cs-parser.jay: Use an out-of-band stack to pass information
16453 around, I wonder why I need this.
16455 foreach_block: Make the new foreach_block the current_block.
16457 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
16458 function used to return a static Parameters structure. Used for
16459 empty parameters, as those are created very frequently.
16461 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
16463 2001-11-15 Ravi Pratap <ravi@ximian.com>
16465 * interface.cs : Default modifier is private, not public. The
16466 make verify test passes again.
16468 2001-11-15 Ravi Pratap <ravi@ximian.com>
16470 * support.cs (ReflectionParameters): Fix logic to determine
16471 whether the last parameter is a params one. Test 9 passes again.
16473 * delegate.cs (Populate): Register the builders we define with
16474 RegisterParameterForBuilder. Test 19 passes again.
16476 * cs-parser.jay (property_declaration): Reference $6 instead
16477 of $$ to get at the location.
16479 (indexer_declaration): Similar stuff.
16481 (attribute): Ditto.
16483 * class.cs (Property): Register parameters for the Get and Set methods
16484 if they exist. Test 23 passes again.
16486 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
16487 call to EmitArguments as we are sure there aren't any params arguments.
16488 Test 32 passes again.
16490 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
16491 IndexOutOfRangeException.
16493 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
16494 Test 33 now passes again.
16496 2001-11-15 Miguel de Icaza <miguel@ximian.com>
16498 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
16499 broke a bunch of things. Will have to come up with a better way
16500 of tracking locations.
16502 * statement.cs: Implemented foreach for single dimension arrays.
16504 2001-11-09 Miguel de Icaza <miguel@ximian.com>
16506 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
16507 an error. This removes the lookup from the critical path.
16509 * cs-parser.jay: Removed use of temporary_loc, which is completely
16512 2001-11-14 Miguel de Icaza <miguel@ximian.com>
16514 * support.cs (ReflectionParameters.ParameterModifier): Report
16515 whether the argument is a PARAMS argument or not.
16517 * class.cs: Set the attribute `ParamArrayAttribute' on the
16518 parameter argument.
16520 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
16521 and cons_param_array_attribute (ConstructorInfo for
16522 ParamArrayAttribute).,
16524 * codegen.cs: Emit the return using the `Return' statement, that
16525 way we can report the error correctly for missing return values.
16527 * class.cs (Method.Emit): Clean up.
16529 * expression.cs (Argument.Resolve): Take another argument: the
16530 location where this argument is used. Notice that this is not
16531 part of the "Argument" class as to reduce the size of the
16532 structure (we know the approximate location anyways).
16534 Test if the argument is a variable-reference, if not, then
16535 complain with a 206.
16537 (Argument.Emit): Emit addresses of variables.
16539 (Argument.FullDesc): Simplify.
16541 (Invocation.DoResolve): Update for Argument.Resolve.
16543 (ElementAccess.DoResolve): ditto.
16545 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
16546 method should be virtual, as this method is always virtual.
16548 (NewDelegate.DoResolve): Update for Argument.Resolve.
16550 * class.cs (ConstructorInitializer.DoResolve): ditto.
16552 * attribute.cs (Attribute.Resolve): ditto.
16554 2001-11-13 Miguel de Icaza <miguel@ximian.com>
16556 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
16558 * expression.cs (ParameterReference): Drop IStackStorage and implement
16559 IAssignMethod instead.
16561 (LocalVariableReference): ditto.
16563 * ecore.cs (FieldExpr): Drop IStackStorage and implement
16564 IAssignMethod instead.
16566 2001-11-13 Miguel de Icaza <miguel@ximian.com>
16568 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
16569 enumerations that are used in heavily used structures derive from
16570 byte in a laughable and pathetic attempt to reduce memory usage.
16571 This is the kind of pre-optimzations that you should not do at
16572 home without adult supervision.
16574 * expression.cs (UnaryMutator): New class, used to handle ++ and
16575 -- separatedly from the other unary operators. Cleans up the
16576 code, and kills the ExpressionStatement dependency in Unary.
16578 (Unary): Removed `method' and `Arguments' from this class, making
16579 it smaller, and moving it all to SimpleCall, so I can reuse this
16580 code in other locations and avoid creating a lot of transient data
16581 strucutres when not required.
16583 * cs-parser.jay: Adjust for new changes.
16585 2001-11-11 Miguel de Icaza <miguel@ximian.com>
16587 * enum.cs (Enum.Populate): If there is a failure during
16590 * cs-parser.jay (opt_enum_base): we used to catch type errors
16591 here, but this is really incorrect. The type error should be
16592 catched during semantic analysis.
16594 2001-12-11 Ravi Pratap <ravi@ximian.com>
16596 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
16597 current_local_parameters as expected since I, in my stupidity, had forgotten
16600 * attribute.cs (GetValidPlaces): Fix stupid bug.
16602 * class.cs (Method::Emit): Perform check on applicability of attributes.
16604 (Constructor::Emit): Ditto.
16606 (Field::Emit): Ditto.
16608 (Field.Location): Store location information.
16610 (Property, Event, Indexer, Operator): Ditto.
16612 * cs-parser.jay (field_declaration): Pass in location for each field.
16614 * ../errors/cs0592.cs : Add.
16616 2001-11-12 Ravi Pratap <ravi@ximian.com>
16618 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
16620 (InitCoreTypes): Update accordingly.
16622 (RegisterAttrType, LookupAttr): Implement.
16624 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
16625 info about the same.
16627 (Resolve): Update to populate the above as necessary.
16629 (Error592): Helper.
16631 (GetValidPlaces): Helper to the above.
16633 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
16635 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
16637 2001-11-12 Ravi Pratap <ravi@ximian.com>
16639 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
16641 * ../errors/cs0617.cs : Add.
16643 2001-11-11 Ravi Pratap <ravi@ximian.com>
16645 * enum.cs (Emit): Rename to Populate to be more consistent with what
16646 we expect it to do and when exactly it is called.
16648 * class.cs, rootcontext.cs : Update accordingly.
16650 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
16651 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
16653 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
16655 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
16656 of a fieldinfo using the above, when dealing with a FieldBuilder.
16658 2001-11-10 Ravi Pratap <ravi@ximian.com>
16660 * ../errors/cs0031.cs : Add.
16662 * ../errors/cs1008.cs : Add.
16664 * ../errrors/cs0543.cs : Add.
16666 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
16669 (FindMembers): Implement.
16671 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
16672 enums and delegates too.
16674 (enum_types): Rename to builder_to_enum.
16676 (delegate_types): Rename to builder_to_delegate.
16678 * delegate.cs (FindMembers): Implement.
16680 2001-11-09 Ravi Pratap <ravi@ximian.com>
16682 * typemanager.cs (IsEnumType): Implement.
16684 * enum.cs (Emit): Re-write parts to account for the underlying type
16685 better and perform checking etc.
16687 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
16688 of the underlying type.
16690 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
16693 * enum.cs (error31): Helper to report error #31.
16695 * cs-parser.jay (enum_declaration): Store location of each member too.
16697 * enum.cs (member_to_location): New hashtable.
16699 (AddEnumMember): Update location hashtable.
16701 (Emit): Use the location of each member while reporting errors.
16703 2001-11-09 Miguel de Icaza <miguel@ximian.com>
16705 * cs-parser.jay: A for_initializer if is a
16706 local_variable_declaration really ammount to have an implicit
16707 block with the variable declaration and no initializer for for.
16709 * statement.cs (For.Emit): Cope with null initializers.
16711 This fixes the infinite loop on for initializers.
16713 2001-11-08 Miguel de Icaza <miguel@ximian.com>
16715 * enum.cs: More cleanup.
16717 * ecore.cs: Remove dead code.
16719 * class.cs (Property.Emit): More simplification.
16720 (Event.Emit): ditto.
16722 Reworked to have less levels of indentation.
16724 2001-11-08 Ravi Pratap <ravi@ximian.com>
16726 * class.cs (Property): Emit attributes.
16736 * enum.cs (Emit): Ditto.
16738 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
16741 * class.cs (Field, Event, etc.): Move attribute generation into the
16742 Emit method everywhere.
16744 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
16745 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
16746 as we had no way of defining nested enums !
16748 * rootcontext.cs : Adjust code accordingly.
16750 * typemanager.cs (AddEnumType): To keep track of enum types separately.
16752 2001-11-07 Ravi Pratap <ravi@ximian.com>
16754 * expression.cs (EvalConstantExpression): Move into ecore.cs
16756 * enum.cs (Enum): Rename some members and make them public and readonly
16757 according to our convention.
16759 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
16762 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
16764 (Enum::Emit): Write a simple version for now which doesn't try to compute
16765 expressions. I shall modify this to be more robust in just a while.
16767 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
16769 (TypeContainer::CloseType): Create the Enum types too.
16771 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
16773 * expression.cs (EvalConstantExpression): Get rid of completely.
16775 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
16776 user-defined values and other cases.
16778 (IsValidEnumLiteral): Helper function.
16780 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
16781 out there in the case we had a literal FieldExpr.
16783 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
16785 (Literalize): Revamp a bit to take two arguments.
16787 (EnumLiteral): New class which derives from Literal to wrap enum literals.
16789 2001-11-06 Ravi Pratap <ravi@ximian.com>
16791 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
16793 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
16795 (Resolve): Use the above to ensure we have proper initializers.
16797 2001-11-05 Ravi Pratap <ravi@ximian.com>
16799 * expression.cs (Expression::EvalConstantExpression): New method to
16800 evaluate constant expressions.
16802 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
16804 2001-11-07 Miguel de Icaza <miguel@ximian.com>
16806 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
16809 (Binary.ResolveOperator): Handle operator != (object a, object b)
16810 and operator == (object a, object b);
16812 (Binary.DoNumericPromotions): Indicate whether the numeric
16813 promotion was possible.
16815 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
16818 Made the ArrayAccess implement interface IAssignMethod instead of
16819 IStackStore as the order in which arguments are passed reflects
16822 * assign.cs: Instead of using expr.ExprClass to select the way of
16823 assinging, probe for the IStackStore/IAssignMethod interfaces.
16825 * typemanager.cs: Load InitializeArray definition.
16827 * rootcontext.cs (RootContext.MakeStaticData): Used to define
16828 static data that can be used to initialize arrays.
16830 2001-11-05 Miguel de Icaza <miguel@ximian.com>
16832 * expression.cs: Handle operator== and operator!= for booleans.
16834 (Conditioal.Reduce): Implement reducer for the ?: operator.
16836 (Conditional.Resolve): Implement dead code elimination.
16838 (Binary.Resolve): Catch string literals and return a new
16839 concatenated string.
16841 (Unary.Reduce): Implement reduction of unary expressions.
16843 * ecore.cs: Split out the expression core handling here.
16845 (Expression.Reduce): New method used to perform constant folding
16846 and CSE. This is needed to support constant-expressions.
16848 * statement.cs (Statement.EmitBoolExpression): Pass true and false
16849 targets, and optimize for !x.
16851 2001-11-04 Ravi Pratap <ravi@ximian.com>
16853 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
16854 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
16855 set custom atttributes.
16857 * literal.cs (Literal::GetValue): New abstract method to return the actual
16858 value of the literal, cast as an object.
16860 (*Literal): Implement GetValue method.
16862 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
16863 expressions to the arraylist but objects of type Argument.
16865 * class.cs (TypeContainer::Emit): Emit our attributes too.
16867 (Method::Emit, Constructor::Emit): Ditto.
16869 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
16870 to be ignoring earlier.
16872 2001-11-03 Ravi Pratap <ravi@ximian.com>
16874 * attribute.cs (AttributeSection::Define): Implement to do the business
16875 of constructing a CustomAttributeBuilder.
16877 (Attribute): New trivial class. Increases readability of code.
16879 * cs-parser.jay : Update accordingly.
16881 (positional_argument_list, named_argument_list, named_argument): New rules
16883 (attribute_arguments): Use the above so that we are more correct.
16885 2001-11-02 Ravi Pratap <ravi@ximian.com>
16887 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
16888 to perform all checks for a method with a params parameter.
16890 (Invocation::OverloadResolve): Update to use the above method and therefore
16891 cope correctly with params method invocations.
16893 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
16896 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
16897 constructors in our parent too because we can't afford to miss out on
16900 * attribute.cs (AttributeSection): New name for the class Attribute
16902 Other trivial changes to improve readability.
16904 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
16905 use the new class names.
16907 2001-11-01 Ravi Pratap <ravi@ximian.com>
16909 * class.cs (Method::Define): Complete definition for params types too
16911 (Indexer::Define): Ditto.
16913 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
16914 Cope everywhere with a request for info about the array parameter.
16916 2001-11-01 Ravi Pratap <ravi@ximian.com>
16918 * tree.cs (RecordNamespace): Fix up to check for the correct key.
16920 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
16921 local_variable_type to extract the string corresponding to the type.
16923 (local_variable_type): Fixup the action to use the new helper method.
16925 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
16928 * expression.cs : Clean out code which uses the above.
16930 2001-10-31 Ravi Pratap <ravi@ximian.com>
16932 * typemanager.cs (RegisterMethod): Check if we already have an existing key
16933 and bale out if necessary by returning a false.
16935 (RegisterProperty): Ditto.
16937 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
16938 and print out appropriate error messages.
16940 * interface.cs (everywhere): Ditto.
16942 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
16943 location to constructor.
16945 * class.cs (Property, Event, Indexer): Update accordingly.
16947 * ../errors/cs111.cs : Added.
16949 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
16950 of a method, as laid down by the spec.
16952 (Invocation::OverloadResolve): Use the above method.
16954 2001-10-31 Ravi Pratap <ravi@ximian.com>
16956 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
16957 now take a TypeContainer and a Parameters object.
16959 (ParameterData): Modify return type of ParameterModifier method to be
16960 Parameter.Modifier and not a string.
16962 (ReflectionParameters, InternalParameters): Update accordingly.
16964 * expression.cs (Argument::GetParameterModifier): Same here.
16966 * support.cs (InternalParameters::ParameterType): Find a better way of determining
16967 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
16968 symbol in it at all so maybe this is only for now.
16970 2001-10-30 Ravi Pratap <ravi@ximian.com>
16972 * support.cs (InternalParameters): Constructor now takes an extra argument
16973 which is the actual Parameters class.
16975 (ParameterDesc): Update to provide info on ref/out modifiers.
16977 * class.cs (everywhere): Update call to InternalParameters to pass in
16978 the second argument too.
16980 * support.cs (ParameterData): Add ParameterModifier, which is a method
16981 to return the modifier info [ref/out etc]
16983 (InternalParameters, ReflectionParameters): Implement the above.
16985 * expression.cs (Argument::ParameterModifier): Similar function to return
16986 info about the argument's modifiers.
16988 (Invocation::OverloadResolve): Update to take into account matching modifiers
16991 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
16992 a new SetFormalParameters object which we pass to InternalParameters.
16994 2001-10-30 Ravi Pratap <ravi@ximian.com>
16996 * expression.cs (NewArray): Merge into the ArrayCreation class.
16998 2001-10-29 Ravi Pratap <ravi@ximian.com>
17000 * expression.cs (NewArray): Merge classes NewBuiltinArray and
17001 NewUserdefinedArray into one as there wasn't much of a use in having
17004 * expression.cs (Argument): Change field's name to ArgType from Type.
17006 (Type): New readonly property which returns the proper type, taking into
17007 account ref/out modifiers.
17009 (everywhere): Adjust code accordingly for the above.
17011 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
17012 whether we are emitting for a ref or out parameter.
17014 * expression.cs (Argument::Emit): Use the above field to set the state.
17016 (LocalVariableReference::Emit): Update to honour the flag and emit the
17019 * parameter.cs (Attributes): Set the correct flags for ref parameters.
17021 * expression.cs (Argument::FullDesc): New function to provide a full desc.
17023 * support.cs (ParameterData): Add method ParameterDesc to the interface.
17025 (ReflectionParameters, InternalParameters): Implement the above method.
17027 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
17030 (Invocation::FullMethodDesc): Ditto.
17032 2001-10-29 Miguel de Icaza <miguel@ximian.com>
17034 * cs-parser.jay: Add extra production for the second form of array
17037 * expression.cs (ArrayCreation): Update to reflect the above
17040 * Small changes to prepare for Array initialization.
17042 2001-10-28 Miguel de Icaza <miguel@ximian.com>
17044 * typemanager.cs (ImplementsInterface): interface might be null;
17045 Deal with this problem;
17047 Also, we do store negative hits on the cache (null values), so use
17048 this instead of calling t.GetInterfaces on the type everytime.
17050 2001-10-28 Ravi Pratap <ravi@ximian.com>
17052 * typemanager.cs (IsBuiltinType): New method to help determine the same.
17054 * expression.cs (New::DoResolve): Get rid of array creation code and instead
17055 split functionality out into different classes.
17057 (New::FormArrayType): Move into NewBuiltinArray.
17059 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
17062 (NewBuiltinArray): New class to handle creation of built-in arrays.
17064 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
17065 account creation of one-dimensional arrays.
17067 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
17069 (NewUserdefinedArray::DoResolve): Implement.
17071 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
17073 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
17074 we maintain inside the TypeManager. This is necessary to perform lookups on the
17077 (LookupType): Update to perform GetType on the module builders too.
17079 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
17081 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
17083 2001-10-23 Ravi Pratap <ravi@ximian.com>
17085 * expression.cs (New::DoResolve): Implement guts of array creation.
17087 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
17089 2001-10-27 Miguel de Icaza <miguel@ximian.com>
17091 * expression.cs: Fix bug I introduced lsat night that broke
17094 (Expression.Resolve): Report a 246 error (can not resolve name)
17095 if we find a SimpleName in the stream.
17097 (Expression.ResolveLValue): Ditto.
17099 (Expression.ResolveWithSimpleName): This function is a variant of
17100 ResolveName, this one allows SimpleNames to be returned without a
17101 warning. The only consumer of SimpleNames is MemberAccess
17103 2001-10-26 Miguel de Icaza <miguel@ximian.com>
17105 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
17106 might arrive here. I have my doubts that this is correct.
17108 * statement.cs (Lock): Implement lock statement.
17110 * cs-parser.jay: Small fixes to support `lock' and `using'
17112 * cs-tokenizer.cs: Remove extra space
17114 * driver.cs: New flag --checked, allows to turn on integer math
17117 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
17118 Threading.Monitor.Exit
17120 2001-10-23 Miguel de Icaza <miguel@ximian.com>
17122 * expression.cs (IndexerAccess::DoResolveLValue): Set the
17123 Expression Class to be IndexerAccess.
17125 Notice that Indexer::DoResolve sets the eclass to Value.
17127 2001-10-22 Miguel de Icaza <miguel@ximian.com>
17129 * class.cs (TypeContainer::Emit): Emit code for indexers.
17131 * assign.cs (IAssignMethod): New interface implemented by Indexers
17132 and Properties for handling assignment.
17134 (Assign::Emit): Simplify and reuse code.
17136 * expression.cs (IndexerAccess, PropertyExpr): Implement
17137 IAssignMethod, clean up old code.
17139 2001-10-22 Ravi Pratap <ravi@ximian.com>
17141 * typemanager.cs (ImplementsInterface): New method to determine if a type
17142 implements a given interface. Provides a nice cache too.
17144 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
17147 (ConvertReferenceExplicit): Ditto.
17149 * delegate.cs (Delegate::Populate): Update to define the parameters on the
17150 various methods, with correct names etc.
17152 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
17153 Operator.UnaryNegation.
17155 * cs-parser.jay (operator_declarator): Be a little clever in the case where
17156 we have a unary plus or minus operator.
17158 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
17161 * everywhere : update accordingly.
17163 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
17166 * class.cs (Method::Define): For the case where we are implementing a method
17167 inherited from an interface, we need to set the MethodAttributes.Final flag too.
17168 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
17170 2001-10-21 Ravi Pratap <ravi@ximian.com>
17172 * interface.cs (FindMembers): Implement to work around S.R.E
17175 * typemanager.cs (IsInterfaceType): Implement.
17177 (FindMembers): Update to handle interface types too.
17179 * expression.cs (ImplicitReferenceConversion): Re-write bits which
17180 use IsAssignableFrom as that is not correct - it doesn't work.
17182 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
17183 and accordingly override EmitStatement.
17185 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
17186 using the correct logic :-)
17188 2001-10-19 Ravi Pratap <ravi@ximian.com>
17190 * ../errors/cs-11.cs : Add to demonstrate error -11
17192 2001-10-17 Miguel de Icaza <miguel@ximian.com>
17194 * assign.cs (Assign::Resolve): Resolve right hand side first, and
17195 then pass this as a hint to ResolveLValue.
17197 * expression.cs (FieldExpr): Add Location information
17199 (FieldExpr::LValueResolve): Report assignment to readonly
17202 (Expression::ExprClassFromMemberInfo): Pass location information.
17204 (Expression::ResolveLValue): Add new method that resolves an
17207 (Expression::DoResolveLValue): Default invocation calls
17210 (Indexers): New class used to keep track of indexers in a given
17213 (IStackStore): Renamed from LValue, as it did not really describe
17214 what this did. Also ResolveLValue is gone from this interface and
17215 now is part of Expression.
17217 (ElementAccess): Depending on the element access type
17219 * typemanager.cs: Add `indexer_name_type' as a Core type
17220 (System.Runtime.CompilerServices.IndexerNameAttribute)
17222 * statement.cs (Goto): Take a location.
17224 2001-10-18 Ravi Pratap <ravi@ximian.com>
17226 * delegate.cs (Delegate::VerifyDelegate): New method to verify
17227 if two delegates are compatible.
17229 (NewDelegate::DoResolve): Update to take care of the case when
17230 we instantiate a delegate from another delegate.
17232 * typemanager.cs (FindMembers): Don't even try to look up members
17233 of Delegate types for now.
17235 2001-10-18 Ravi Pratap <ravi@ximian.com>
17237 * delegate.cs (NewDelegate): New class to take care of delegate
17240 * expression.cs (New): Split the delegate related code out into
17241 the NewDelegate class.
17243 * delegate.cs (DelegateInvocation): New class to handle delegate
17246 * expression.cs (Invocation): Split out delegate related code into
17247 the DelegateInvocation class.
17249 2001-10-17 Ravi Pratap <ravi@ximian.com>
17251 * expression.cs (New::DoResolve): Implement delegate creation fully
17252 and according to the spec.
17254 (New::DoEmit): Update to handle delegates differently.
17256 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
17257 because of which we were printing out arguments in reverse order !
17259 * delegate.cs (VerifyMethod): Implement to check if the given method
17260 matches the delegate.
17262 (FullDelegateDesc): Implement.
17264 (VerifyApplicability): Implement.
17266 * expression.cs (Invocation::DoResolve): Update to accordingly handle
17267 delegate invocations too.
17269 (Invocation::Emit): Ditto.
17271 * ../errors/cs1593.cs : Added.
17273 * ../errors/cs1594.cs : Added.
17275 * delegate.cs (InstanceExpression, TargetMethod): New properties.
17277 2001-10-16 Ravi Pratap <ravi@ximian.com>
17279 * typemanager.cs (intptr_type): Core type for System.IntPtr
17281 (InitCoreTypes): Update for the same.
17283 (iasyncresult_type, asynccallback_type): Ditto.
17285 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
17288 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
17291 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
17292 the builders for the 4 members of a delegate type :-)
17294 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
17297 * expression.cs (New::DoResolve): Implement guts for delegate creation.
17299 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
17301 2001-10-15 Miguel de Icaza <miguel@ximian.com>
17303 * statement.cs (Break::Emit): Implement.
17304 (Continue::Emit): Implement.
17306 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
17307 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
17308 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
17309 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
17312 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
17313 properties that track the label for the current loop (begin of the
17314 loop and end of the loop).
17316 2001-10-15 Ravi Pratap <ravi@ximian.com>
17318 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
17319 use of emitting anything at all.
17321 * class.cs, rootcontext.cs : Get rid of calls to the same.
17323 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
17325 (Populate): Define the constructor correctly and set the implementation
17328 * typemanager.cs (delegate_types): New hashtable to hold delegates that
17331 (AddDelegateType): Implement.
17333 (IsDelegateType): Implement helper method.
17335 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
17337 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
17338 and accordingly handle it.
17340 * delegate.cs (Populate): Take TypeContainer argument.
17341 Implement bits to define the Invoke method. However, I still haven't figured out
17342 how to take care of the native int bit :-(
17344 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
17345 Qualify the name of the delegate, not its return type !
17347 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
17350 (StandardConversionExists): Checking for array types turns out to be recursive.
17352 (ConvertReferenceExplicit): Implement array conversion.
17354 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
17356 2001-10-12 Ravi Pratap <ravi@ximian.com>
17358 * cs-parser.jay (delegate_declaration): Store the fully qualified
17359 name as it is a type declaration.
17361 * delegate.cs (ReturnType, Name): Rename members to these. Make them
17364 (DefineDelegate): Renamed from Define. Does the same thing essentially,
17365 as TypeContainer::DefineType.
17367 (Populate): Method in which all the definition of the various methods (Invoke)
17370 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
17373 (CloseDelegate): Finally creates the delegate.
17375 * class.cs (TypeContainer::DefineType): Update to define delegates.
17376 (Populate, Emit and CloseType): Do the same thing here too.
17378 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
17379 delegates in all these operations.
17381 2001-10-14 Miguel de Icaza <miguel@ximian.com>
17383 * expression.cs: LocalTemporary: a new expression used to
17384 reference a temporary that has been created.
17386 * assign.cs: Handle PropertyAccess back here, so that we can
17387 provide the proper semantic access to properties.
17389 * expression.cs (Expression::ConvertReferenceExplicit): Implement
17390 a few more explicit conversions.
17392 * modifiers.cs: `NEW' modifier maps to HideBySig.
17394 * expression.cs (PropertyExpr): Make this into an
17395 ExpressionStatement, and support the EmitStatement code path.
17397 Perform get/set error checking, clean up the interface.
17399 * assign.cs: recognize PropertyExprs as targets, and if so, turn
17400 them into toplevel access objects.
17402 2001-10-12 Miguel de Icaza <miguel@ximian.com>
17404 * expression.cs: PropertyExpr::PropertyExpr: use work around the
17407 * typemanager.cs: Keep track here of our PropertyBuilders again to
17408 work around lameness in SRE.
17410 2001-10-11 Miguel de Icaza <miguel@ximian.com>
17412 * expression.cs (LValue::LValueResolve): New method in the
17413 interface, used to perform a second resolution pass for LValues.
17415 (This::DoResolve): Catch the use of this in static methods.
17417 (This::LValueResolve): Implement.
17419 (This::Store): Remove warning, assigning to `this' in structures
17422 (Invocation::Emit): Deal with invocation of
17423 methods on value types. We need to pass the address to structure
17424 methods rather than the object itself. (The equivalent code to
17425 emit "this" for structures leaves the entire structure on the
17426 stack instead of a pointer to it).
17428 (ParameterReference::DoResolve): Compute the real index for the
17429 argument based on whether the method takes or not a `this' pointer
17430 (ie, the method is static).
17432 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
17433 value types returned from functions when we need to invoke a
17434 method on the sturcture.
17437 2001-10-11 Ravi Pratap <ravi@ximian.com>
17439 * class.cs (TypeContainer::DefineType): Method to actually do the business of
17440 defining the type in the Modulebuilder or Typebuilder. This is to take
17441 care of nested types which need to be defined on the TypeBuilder using
17442 DefineNestedMethod.
17444 (TypeContainer::GetClassBases): Implement. Essentially the code from the
17445 methods in RootContext, only ported to be part of TypeContainer.
17447 (TypeContainer::GetInterfaceOrClass): Ditto.
17449 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
17451 * interface.cs (Interface::DefineInterface): New method. Does exactly
17452 what RootContext.CreateInterface did earlier, only it takes care of nested types
17455 (Interface::GetInterfaces): Move from RootContext here and port.
17457 (Interface::GetInterfaceByName): Same here.
17459 * rootcontext.cs (ResolveTree): Re-write.
17461 (PopulateTypes): Re-write.
17463 * class.cs (TypeContainer::Populate): Populate nested types too.
17464 (TypeContainer::Emit): Emit nested members too.
17466 * typemanager.cs (AddUserType): Do not make use of the FullName property,
17467 instead just use the name argument passed in as it is already fully
17470 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
17471 to TypeContainer mapping to see if a type is user-defined.
17473 * class.cs (TypeContainer::CloseType): Implement.
17475 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
17476 the default constructor.
17478 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
17481 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
17483 * interface.cs (CloseType): Create the type here.
17485 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
17488 Remove all the methods which are now in TypeContainer.
17490 2001-10-10 Ravi Pratap <ravi@ximian.com>
17492 * delegate.cs (Define): Re-write bits to define the delegate
17495 2001-10-10 Miguel de Icaza <miguel@ximian.com>
17497 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
17499 * expression.cs (ImplicitReferenceConversion): handle null as well
17500 as a source to convert to any reference type.
17502 * statement.cs (Return): Perform any implicit conversions to
17503 expected return type.
17505 Validate use of return statement.
17507 * codegen.cs (EmitContext): Pass the expected return type here.
17509 * class.cs (Method, Constructor, Property): Pass expected return
17510 type to EmitContext.
17512 2001-10-09 Miguel de Icaza <miguel@ximian.com>
17514 * expression.cs: Make DoResolve take an EmitContext instead of a
17517 Replaced `l' and `location' for `loc', for consistency.
17519 (Error, Warning): Remove unneeded Tc argument.
17521 * assign.cs, literal.cs, constant.cs: Update to new calling
17524 * codegen.cs: EmitContext now contains a flag indicating whether
17525 code is being generated in a static method or not.
17527 * cs-parser.jay: DecomposeQI, new function that replaces the old
17528 QualifiedIdentifier. Now we always decompose the assembled
17529 strings from qualified_identifier productions into a group of
17532 2001-10-08 Miguel de Icaza <miguel@ximian.com>
17534 * rootcontext.cs: Deal with field-less struct types correctly now
17535 by passing the size option to Define Type.
17537 * class.cs: Removed hack that created one static field.
17539 2001-10-07 Miguel de Icaza <miguel@ximian.com>
17541 * statement.cs: Moved most of the code generation here.
17543 2001-10-09 Ravi Pratap <ravi@ximian.com>
17545 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
17548 (ElementAccess): Remove useless bits for now - keep checks as the spec
17551 2001-10-08 Ravi Pratap <ravi@ximian.com>
17553 * expression.cs (ElementAccess::DoResolve): Remove my crap code
17554 and start performing checks according to the spec.
17556 2001-10-07 Ravi Pratap <ravi@ximian.com>
17558 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
17559 rank_specifiers instead.
17561 (rank_specifiers): Change the order in which the rank specifiers are stored
17563 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
17565 * expression.cs (ElementAccess): Implement the LValue interface too.
17567 2001-10-06 Ravi Pratap <ravi@ximian.com>
17569 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
17570 except that user defined conversions are not included.
17572 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
17573 perform the conversion of the return type, if necessary.
17575 (New::DoResolve): Check whether we are creating an array or an object
17576 and accordingly do the needful.
17578 (New::Emit): Same here.
17580 (New::DoResolve): Implement guts of array creation.
17582 (New::FormLookupType): Helper function.
17584 2001-10-07 Miguel de Icaza <miguel@ximian.com>
17586 * codegen.cs: Removed most of the code generation here, and move the
17587 corresponding code generation bits to the statement classes.
17589 Added support for try/catch/finalize and throw.
17591 * cs-parser.jay: Added support for try/catch/finalize.
17593 * class.cs: Catch static methods having the flags override,
17594 virtual or abstract.
17596 * expression.cs (UserCast): This user cast was not really doing
17597 what it was supposed to do. Which is to be born in fully resolved
17598 state. Parts of the resolution were being performed at Emit time!
17602 2001-10-05 Miguel de Icaza <miguel@ximian.com>
17604 * expression.cs: Implicity convert the result from UserCast.
17606 2001-10-05 Ravi Pratap <ravi@ximian.com>
17608 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
17609 prevented it from working correctly.
17611 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
17612 merely ConvertImplicit.
17614 2001-10-05 Miguel de Icaza <miguel@ximian.com>
17616 * typemanager.cs: Make the LookupTypeContainer function static,
17617 and not per-instance.
17619 * class.cs: Make static FindMembers (the one that takes a Type
17622 * codegen.cs: Add EmitForeach here.
17624 * cs-parser.jay: Make foreach a toplevel object instead of the
17625 inline expansion, as we need to perform semantic analysis on it.
17627 2001-10-05 Ravi Pratap <ravi@ximian.com>
17629 * expression.cs (Expression::ImplicitUserConversion): Rename to
17630 UserDefinedConversion.
17632 (Expression::UserDefinedConversion): Take an extra argument specifying
17633 whether we look for explicit user conversions too.
17635 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
17637 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
17639 (ExplicitUserConversion): Make it a call to UserDefinedConversion
17640 with the appropriate arguments.
17642 * cs-parser.jay (cast_expression): Record location too.
17644 * expression.cs (Cast): Record location info.
17646 (Expression::ConvertExplicit): Take location argument.
17648 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
17649 to determine if we are doing explicit conversions.
17651 (UserCast::Emit): Update accordingly.
17653 (Expression::ConvertExplicit): Report an error if everything fails.
17655 * ../errors/cs0030.cs : Add.
17657 2001-10-04 Miguel de Icaza <miguel@ximian.com>
17659 * modifiers.cs: If the ABSTRACT keyword is present, also set the
17660 virtual and newslot bits.
17662 * class.cs (TypeContainer::RegisterRequiredImplementations):
17663 Record methods we need.
17665 (TypeContainer::MakeKey): Helper function to make keys for
17666 MethodBases, since the Methodbase key is useless.
17668 (TypeContainer::Populate): Call RegisterRequiredImplementations
17669 before defining the methods.
17671 Create a mapping for method_builders_to_methods ahead of time
17672 instead of inside a tight loop.
17674 (::RequireMethods): Accept an object as the data to set into the
17675 hashtable so we can report interface vs abstract method mismatch.
17677 2001-10-03 Miguel de Icaza <miguel@ximian.com>
17679 * report.cs: Make all of it static.
17681 * rootcontext.cs: Drop object_type and value_type computations, as
17682 we have those in the TypeManager anyways.
17684 Drop report instance variable too, now it is a global.
17686 * driver.cs: Use try/catch on command line handling.
17688 Add --probe option to debug the error reporting system with a test
17691 * report.cs: Add support for exiting program when a probe
17692 condition is reached.
17694 2001-10-03 Ravi Pratap <ravi@ximian.com>
17696 * expression.cs (Binary::DoNumericPromotions): Fix the case when
17697 we do a forcible conversion regardless of type, to check if
17698 ForceConversion returns a null.
17700 (Binary::error19): Use location to report error.
17702 (Unary::error23): Use location here too.
17704 * ../errors/cs0019.cs : Check in.
17706 * ../errors/cs0023.cs : Check in.
17708 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
17709 case of a non-null MethodInfo object with a length of 0 !
17711 (Binary::ResolveOperator): Flag error if overload resolution fails to find
17712 an applicable member - according to the spec :-)
17713 Also fix logic to find members in base types.
17715 (Unary::ResolveOperator): Same here.
17717 (Unary::report23): Change name to error23 and make first argument a TypeContainer
17718 as I was getting thoroughly confused between this and error19 :-)
17720 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
17721 (::FindMostEncompassedType): Implement.
17722 (::FindMostEncompassingType): Implement.
17723 (::StandardConversionExists): Implement.
17725 (UserImplicitCast): Re-vamp. We now need info about most specific
17726 source and target types so that we can do the necessary conversions.
17728 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
17729 mathematical union with no duplicates.
17731 2001-10-03 Miguel de Icaza <miguel@ximian.com>
17733 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
17734 in order from base classes to child classes, so that we can in
17735 child classes look up in our parent for method names and
17736 attributes (required for handling abstract, virtual, new, override
17737 constructs: we need to instrospect our base class, and if we dont
17738 populate the classes in order, the introspection might be
17739 incorrect. For example, a method could query its parent before
17740 the parent has any methods and would determine that the parent has
17741 no abstract methods (while it could have had them)).
17743 (RootContext::CreateType): Record the order in which we define the
17746 2001-10-02 Miguel de Icaza <miguel@ximian.com>
17748 * class.cs (TypeContainer::Populate): Also method definitions can
17749 fail now, keep track of this.
17751 (TypeContainer::FindMembers): Implement support for
17752 DeclaredOnly/noDeclaredOnly flag.
17754 (Constructor::Emit) Return the ConstructorBuilder.
17756 (Method::Emit) Return the MethodBuilder.
17757 Check for abstract or virtual methods to be public.
17759 * rootcontext.cs (RootContext::CreateType): Register all the
17760 abstract methods required for the class to be complete and the
17761 interface methods that must be implemented.
17763 * cs-parser.jay: Report error 501 (method requires body if it is
17764 not marked abstract or extern).
17766 * expression.cs (TypeOf::Emit): Implement.
17768 * typemanager.cs: runtime_handle_type, new global type.
17770 * class.cs (Property::Emit): Generate code for properties.
17772 2001-10-02 Ravi Pratap <ravi@ximian.com>
17774 * expression.cs (Unary::ResolveOperator): Find operators on base type
17775 too - we now conform exactly to the spec.
17777 (Binary::ResolveOperator): Same here.
17779 * class.cs (Operator::Define): Fix minor quirk in the tests.
17781 * ../errors/cs0215.cs : Added.
17783 * ../errors/cs0556.cs : Added.
17785 * ../errors/cs0555.cs : Added.
17787 2001-10-01 Miguel de Icaza <miguel@ximian.com>
17789 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
17790 single integer which is really efficient
17792 2001-10-01 Ravi Pratap <ravi@ximian.com>
17794 * expression.cs (Expression::ImplicitUserConversion): Use location
17795 even in the case when we are examining True operators.
17797 * class.cs (Operator::Define): Perform extensive checks to conform
17798 with the rules for operator overloading in the spec.
17800 * expression.cs (Expression::ImplicitReferenceConversion): Implement
17801 some of the other conversions mentioned in the spec.
17803 * typemanager.cs (array_type): New static member for the System.Array built-in
17806 (cloneable_interface): For System.ICloneable interface.
17808 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
17809 we start resolving the tree and populating types.
17811 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
17813 2001-10-01 Miguel de Icaza <miguel@ximian.com>
17815 * expression.cs (Expression::ExprClassFromMemberInfo,
17816 Expression::Literalize): Create literal expressions from
17817 FieldInfos which are literals.
17819 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
17820 type casts, because they were wrong. The test suite in tests
17823 (ImplicitNumericConversion): ushort to ulong requires a widening
17826 Int32 constant to long requires widening cast as well.
17828 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
17829 for integers because the type on the stack is not i4.
17831 2001-09-30 Miguel de Icaza <miguel@ximian.com>
17833 * expression.cs (report118): require location argument.
17835 * parameter.cs: Do not dereference potential null value.
17837 * class.cs: Catch methods that lack the `new' keyword when
17838 overriding a name. Report warnings when `new' is used without
17839 anything being there to override.
17841 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
17843 * class.cs: Only add constructor to hashtable if it is non-null
17844 (as now constructors can fail on define).
17846 (TypeManager, Class, Struct): Take location arguments.
17848 Catch field instance initialization in structs as errors.
17850 accepting_filter: a new filter for FindMembers that is static so
17851 that we dont create an instance per invocation.
17853 (Constructor::Define): Catch errors where a struct constructor is
17856 * cs-parser.jay: Pass location information for various new
17859 * delegate.cs (Delegate): take a location argument.
17861 * driver.cs: Do not call EmitCode if there were problesm in the
17862 Definition of the types, as many Builders wont be there.
17864 * decl.cs (Decl::Decl): Require a location argument.
17866 * cs-tokenizer.cs: Handle properly hex constants that can not fit
17867 into integers, and find the most appropiate integer for it.
17869 * literal.cs: Implement ULongLiteral.
17871 * rootcontext.cs: Provide better information about the location of
17872 failure when CreateType fails.
17874 2001-09-29 Miguel de Icaza <miguel@ximian.com>
17876 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
17879 * expression.cs (Binary::CheckShiftArguments): Add missing type
17881 (Binary::ResolveOperator): Add type to the logical and and logical
17882 or, Bitwise And/Or and Exclusive Or code paths, it was missing
17885 (Binary::DoNumericPromotions): In the case where either argument
17886 is ulong (and most signed types combined with ulong cause an
17887 error) perform implicit integer constant conversions as well.
17889 2001-09-28 Miguel de Icaza <miguel@ximian.com>
17891 * expression.cs (UserImplicitCast): Method should always be
17893 (Invocation::BetterConversion): Simplified test for IntLiteral.
17895 (Expression::ImplicitNumericConversion): Split this routine out.
17896 Put the code that performs implicit constant integer conversions
17899 (Expression::Resolve): Become a wrapper around DoResolve so we can
17900 check eclass and type being set after resolve.
17902 (Invocation::Badness): Remove this dead function
17904 (Binary::ResolveOperator): Do not compute the expensive argumnets
17905 unless we have a union for it.
17907 (Probe::Emit): Is needs to do an isinst and then
17908 compare against null.
17910 (::CanConvert): Added Location argument. If the Location argument
17911 is null (Location.Null), then we do not report errors. This is
17912 used by the `probe' mechanism of the Explicit conversion. We do
17913 not want to generate an error for something that the user
17914 explicitly requested to be casted. But the pipeline for an
17915 explicit cast first tests for potential implicit casts.
17917 So for now, if the Location is null, it means `Probe only' to
17918 avoid adding another argument. Might have to revise this
17921 (ClassCast): New class used to type cast objects into arbitrary
17922 classes (used in Explicit Reference Conversions).
17924 Implement `as' as well.
17926 Reverted all the patches from Ravi below: they were broken:
17928 * The use of `level' as a mechanism to stop recursive
17929 invocations is wrong. That was there just to catch the
17930 bug with a strack trace but not as a way of addressing
17933 To fix the problem we have to *understand* what is going
17934 on and the interactions and come up with a plan, not
17935 just get things going.
17937 * The use of the type conversion cache that I proposed
17938 last night had an open topic: How does this work across
17939 protection domains. A user defined conversion might not
17940 be public in the location where we are applying the
17941 conversion, a different conversion might be selected
17942 (ie, private A->B (better) but public B->A (worse),
17943 inside A, A->B applies, but outside it, B->A will
17946 * On top of that (ie, even if the above is solved),
17947 conversions in a cache need to be abstract. Ie, `To
17948 convert from an Int to a Short use an OpcodeCast', not
17949 `To convert from an Int to a Short use the OpcodeCast on
17950 the variable 5' (which is what this patch was doing).
17952 2001-09-28 Ravi Pratap <ravi@ximian.com>
17954 * expression.cs (Invocation::ConversionExists): Re-write to use
17955 the conversion cache
17957 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
17958 cache all conversions done, not just user-defined ones.
17960 (Invocation::BetterConversion): The real culprit. Use ConversionExists
17961 to determine if a conversion exists instead of acutually trying to
17962 perform the conversion. It's faster too.
17964 (Expression::ConvertExplicit): Modify to use ConversionExists to check
17965 and only then attempt the implicit conversion.
17967 2001-09-28 Ravi Pratap <ravi@ximian.com>
17969 * expression.cs (ConvertImplicit): Use a cache for conversions
17970 already found. Check level of recursion and bail out if necessary.
17972 2001-09-28 Miguel de Icaza <miguel@ximian.com>
17974 * typemanager.cs (string_concat_string_string, string_concat_object_object):
17975 Export standard methods that we expect for string operations.
17977 * statement.cs (Block::UsageWarning): Track usage of variables and
17978 report the errors for not used variables.
17980 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
17983 2001-09-27 Miguel de Icaza <miguel@ximian.com>
17985 * codegen.cs: remove unnneded code
17987 * expression.cs: Removed BuiltinTypeAccess class
17989 Fix the order in which implicit conversions are
17992 The previous fixed dropped support for boxed conversions (adding a
17993 test to the test suite now)
17995 (UserImplicitCast::CanConvert): Remove test for source being null,
17996 that code is broken. We should not feed a null to begin with, if
17997 we do, then we should track the bug where the problem originates
17998 and not try to cover it up here.
18000 Return a resolved expression of type UserImplicitCast on success
18001 rather than true/false. Ravi: this is what I was talking about,
18002 the pattern is to use a static method as a "constructor" for
18005 Also, do not create arguments until the very last minute,
18006 otherwise we always create the arguments even for lookups that
18007 will never be performed.
18009 (UserImplicitCast::Resolve): Eliminate, objects of type
18010 UserImplicitCast are born in a fully resolved state.
18012 * typemanager.cs (InitCoreTypes): Init also value_type
18013 (System.ValueType).
18015 * expression.cs (Cast::Resolve): First resolve the child expression.
18017 (LValue): Add new method AddressOf to be used by
18020 Change the argument of Store to take an EmitContext instead of an
18021 ILGenerator, because things like FieldExpr need to be able to call
18022 their children expression to generate the instance code.
18024 (Expression::Error, Expression::Warning): Sugar functions for
18027 (Expression::MemberLookup): Accept a TypeContainer instead of a
18028 Report as the first argument.
18030 (Expression::ResolvePrimary): Killed. I still want to improve
18031 this as currently the code is just not right.
18033 (Expression::ResolveMemberAccess): Simplify, but it is still
18036 (Unary::Resolve): Catch errors in AddressOf operators.
18038 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
18039 index to a byte for the short-version, or the compiler will choose
18040 the wrong Emit call, which generates the wrong data.
18042 (ParameterReference::Emit, ::Store): same.
18044 (FieldExpr::AddressOf): Implement.
18046 * typemanager.cs: TypeManager: made public variable instead of
18049 * driver.cs: document --fatal.
18051 * report.cs (ErrorMessage, WarningMessage): new names for the old
18052 Error and Warning classes.
18054 * cs-parser.jay (member_access): Turn built-in access to types
18055 into a normal simplename
18057 2001-09-27 Ravi Pratap <ravi@ximian.com>
18059 * expression.cs (Invocation::BetterConversion): Fix to cope
18060 with q being null, since this was introducing a bug.
18062 * expression.cs (ConvertImplicit): Do built-in conversions first.
18064 2001-09-27 Ravi Pratap <ravi@ximian.com>
18066 * expression.cs (UserImplicitCast::Resolve): Fix bug.
18068 2001-09-27 Ravi Pratap <ravi@ximian.com>
18070 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
18071 I had introduced long ago (what's new ?).
18073 * expression.cs (UserImplicitCast::CanConvert): Static method to do
18074 the work of all the checking.
18075 (ConvertImplicit): Call CanConvert and only then create object if necessary.
18076 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
18078 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
18079 that is the right way.
18081 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
18082 overloading resolution. Use everywhere instead of cutting and pasting code.
18084 (Binary::ResolveOperator): Use MakeUnionSet.
18086 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
18087 we have to convert to bool types. Not complete yet.
18089 2001-09-27 Miguel de Icaza <miguel@ximian.com>
18091 * typemanager.cs (TypeManager::CSharpName): support ushort.
18093 * expression.cs (Expression::TryImplicitIntConversion): Attempts
18094 to provide an expression that performsn an implicit constant int
18095 conversion (section 6.1.6).
18096 (Expression::ConvertImplicitRequired): Reworked to include
18097 implicit constant expression conversions.
18099 (Expression::ConvertNumericExplicit): Finished.
18101 (Invocation::Emit): If InstanceExpression is null, then it means
18102 that we perform a call on this.
18104 2001-09-26 Miguel de Icaza <miguel@ximian.com>
18106 * expression.cs (Unary::Emit): Remove some dead code.
18107 (Probe): Implement Resolve and Emit for `is'.
18108 (Expression::ConvertImplicitRequired): Attempt to do constant
18109 expression conversions here. Maybe should be moved to
18110 ConvertImplicit, but I am not sure.
18111 (Expression::ImplicitLongConstantConversionPossible,
18112 Expression::ImplicitIntConstantConversionPossible): New functions
18113 that tell whether is it possible to apply an implicit constant
18114 expression conversion.
18116 (ConvertNumericExplicit): Started work on explicit numeric
18119 * cs-parser.jay: Update operator constants.
18121 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
18122 (Parameters::GetSignature): Hook up VerifyArgs here.
18123 (Parameters::VerifyArgs): Verifies that no two arguments have the
18126 * class.cs (Operator): Update the operator names to reflect the
18127 ones that the spec expects (as we are just stringizing the
18130 * expression.cs (Unary::ResolveOperator): Fix bug: Use
18131 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
18132 previous usage did only work for our methods.
18133 (Expression::ConvertImplicit): Handle decimal implicit numeric
18134 conversions as well.
18135 (Expression::InternalTypeConstructor): Used to invoke constructors
18136 on internal types for default promotions.
18138 (Unary::Emit): Implement special handling for the pre/post
18139 increment/decrement for overloaded operators, as they need to have
18140 the same semantics as the other operators.
18142 (Binary::ResolveOperator): ditto.
18143 (Invocation::ConversionExists): ditto.
18144 (UserImplicitCast::Resolve): ditto.
18146 2001-09-26 Ravi Pratap <ravi@ximian.com>
18148 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
18149 operator, return after emitting body. Regression tests pass again !
18151 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
18152 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
18153 (Invocation::OverloadResolve): Ditto.
18154 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
18156 * everywhere : update calls to the above methods accordingly.
18158 2001-09-26 Miguel de Icaza <miguel@ximian.com>
18160 * assign.cs (Assign): Make it inherit from ExpressionStatement.
18162 * expression.cs (ExpressionStatement): New base class used for
18163 expressions that can appear in statements, so that we can provide
18164 an alternate path to generate expression that do not leave a value
18167 (Expression::Emit, and all the derivatives): We no longer return
18168 whether a value is left on the stack or not. Every expression
18169 after being emitted leaves a single value on the stack.
18171 * codegen.cs (EmitContext::EmitStatementExpression): Use the
18172 facilties of ExpressionStatement if possible.
18174 * cs-parser.jay: Update statement_expression.
18176 2001-09-25 Miguel de Icaza <miguel@ximian.com>
18178 * driver.cs: Change the wording of message
18180 2001-09-25 Ravi Pratap <ravi@ximian.com>
18182 * expression.cs (Binary::ResolveOperator): Had forgottten to set
18183 the type of the expression to the return type of the method if
18184 we have an overloaded operator match ! The regression tests pass again !
18185 (Unary::ResolveOperator): Ditto.
18187 * expression.cs (Invocation::ConversionExists): Correct the member lookup
18188 to find "op_Implicit", not "implicit" ;-)
18189 (UserImplicitCast): New class to take care of user-defined implicit conversions.
18190 (ConvertImplicit, ForceConversion): Take TypeContainer argument
18192 * everywhere : Correct calls to the above accordingly.
18194 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
18195 (ConvertImplicit): Do user-defined conversion if it exists.
18197 2001-09-24 Miguel de Icaza <miguel@ximian.com>
18199 * assign.cs: track location.
18200 (Resolve): Use implicit conversions on assignment.
18202 * literal.cs: Oops. Not good, Emit of short access values should
18203 pass (Bytes) or the wrong argument will be selected.
18205 * expression.cs (Unary::Emit): Emit code for -expr.
18207 (Unary::ResolveOperator): Handle `Substract' for non-constants
18208 (substract from zero from the non-constants).
18209 Deal with Doubles as well.
18211 (Expression::ConvertImplicitRequired): New routine that reports an
18212 error if no implicit conversion exists.
18214 (Invocation::OverloadResolve): Store the converted implicit
18215 expressions if we make them
18217 2001-09-24 Ravi Pratap <ravi@ximian.com>
18219 * class.cs (ConstructorInitializer): Take a Location argument.
18220 (ConstructorBaseInitializer): Same here.
18221 (ConstructorThisInitializer): Same here.
18223 * cs-parser.jay : Update all calls accordingly.
18225 * expression.cs (Unary, Binary, New): Take location argument.
18226 Update accordingly everywhere.
18228 * cs-parser.jay : Update all calls to the above to take a location
18231 * class.cs : Ditto.
18233 2001-09-24 Ravi Pratap <ravi@ximian.com>
18235 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
18236 (Invocation::BetterConversion): Same here
18237 (Invocation::ConversionExists): Ditto.
18239 (Invocation::ConversionExists): Implement.
18241 2001-09-22 Ravi Pratap <ravi@ximian.com>
18243 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
18244 Also take an additional TypeContainer argument.
18246 * All over : Pass in TypeContainer as argument to OverloadResolve.
18248 * typemanager.cs (CSharpName): Update to check for the string type and return
18251 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
18254 2001-09-21 Ravi Pratap <ravi@ximian.com>
18256 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
18257 (Invocation::BetterFunction): Implement.
18258 (Invocation::BetterConversion): Implement.
18259 (Invocation::ConversionExists): Skeleton, no implementation yet.
18261 Okay, things work fine !
18263 2001-09-21 Miguel de Icaza <miguel@ximian.com>
18265 * typemanager.cs: declare and load enum_type, delegate_type and
18268 * expression.cs (Expression::Emit): Now emit returns a value that
18269 tells whether a value is left on the stack or not. This strategy
18270 might be reveted tomorrow with a mechanism that would address
18271 multiple assignments.
18272 (Expression::report118): Utility routine to report mismatches on
18275 (Unary::Report23): Report impossible type/operator combination
18278 (Unary::IsIncrementableNumber): Whether the type can be
18279 incremented or decremented with add.
18280 (Unary::ResolveOperator): Also allow enumerations to be bitwise
18282 (Unary::ResolveOperator): Implement ++, !, ~,
18284 (Invocation::Emit): Deal with new Emit convetion.
18286 * All Expression derivatives: Updated their Emit method to return
18287 whether they leave values on the stack or not.
18289 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
18290 stack for expressions that are statements.
18292 2001-09-20 Miguel de Icaza <miguel@ximian.com>
18294 * expression.cs (LValue): New interface. Must be implemented by
18296 (LocalVariableReference, ParameterReference, FieldExpr): Implement
18299 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
18300 interface for generating code, simplifies the code.
18302 2001-09-20 Ravi Pratap <ravi@ximian.com>
18304 * expression.cs (everywhere): Comment out return statements in ::Resolve
18305 methods to avoid the warnings.
18307 2001-09-20 Miguel de Icaza <miguel@ximian.com>
18309 * driver.cs (parse): Report error 2001 if we can not open the
18312 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
18315 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
18318 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
18319 otherwise nested blocks end up with the same index.
18321 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
18323 * expression.cs: Instead of having FIXMEs in the Resolve
18324 functions, throw exceptions so it is obvious that we are facing a
18327 * cs-parser.jay (invocation_expression): Pass Location information.
18329 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
18330 Use a basename for those routines because .NET does not like paths
18333 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
18336 2001-09-19 Miguel de Icaza <miguel@ximian.com>
18338 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
18339 are loading the correct data types (throws an exception if not).
18340 (TypeManager::InitCoreTypes): Use CoreLookupType
18342 * expression.cs (Unary::ResolveOperator): return the child
18343 expression for expressions which are just +expr.
18344 (Unary::ResolveOperator): Return negative literals for -LITERAL
18345 expressions (otherwise they are Unary {Literal}).
18346 (Invocation::Badness): Take into account `Implicit constant
18347 expression conversions'.
18349 * literal.cs (LongLiteral): Implement long literal class.
18350 (IntLiteral): export the `Value' of the intliteral.
18352 2001-09-19 Ravi Pratap <ravi@ximian.com>
18354 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
18356 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
18357 instead of 'Operator'
18359 * expression.cs (Binary::ResolveOperator): Update accordingly.
18360 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
18363 * cs-parser.jay (unary_expression): Update to use the new names.
18365 * gen-treedump.cs (GetUnary): Same here.
18367 * expression.cs (Unary::Resolve): Implement.
18368 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
18369 operators are found instead of making noise ;-)
18370 (Unary::ResolveOperator): New method to do precisely the same thing which
18371 Binary::ResolveOperator does for Binary expressions.
18372 (Unary.method, .Arguments): Add.
18373 (Unary::OperName): Implement.
18374 (Unary::ForceConversion): Copy and Paste !
18376 * class.cs (Operator::Define): Fix a small bug for the case when we have
18379 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
18380 for the inbuilt operators. Only overloading works for now ;-)
18382 2001-09-18 Miguel de Icaza <miguel@ximian.com>
18384 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
18385 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
18387 * expression.cs (This::Emit): Implement.
18388 (This::Resolve): Implement.
18389 (TypeOf:Resolve): Implement.
18390 (Expression::ResolveSimpleName): Add an implicit this to instance
18392 (MemberAccess::Resolve): Deal with Parameters and Fields.
18393 Bind instance variable to Field expressions.
18394 (FieldExpr::Instance): New field used to track the expression that
18395 represents the object instance.
18396 (FieldExpr::Resolve): Track potential errors from MemberLookup not
18398 (FieldExpr::Emit): Implement.
18400 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
18401 the last instruction contains a return opcode to avoid generating
18402 the last `ret' instruction (this generates correct code, and it is
18403 nice to pass the peverify output).
18405 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
18406 initializer for static and instance variables.
18407 (Constructor::Emit): Allow initializer to be null in the case of
18408 static constructors. Only emit initializer for instance
18411 (TypeContainer::FindMembers): Return a null array if there are no
18414 Also fix the code for the MemberTypes.Method branch, as it was not
18415 scanning that for operators (or tried to access null variables before).
18417 * assign.cs (Assign::Emit): Handle instance and static fields.
18421 * driver.cs: Stop compilation if there are parse errors.
18423 * cs-parser.jay (constructor_declaration): Provide default base
18424 initializer for non-static constructors.
18425 (constructor_declarator): Do not provide a default base
18426 initializers if none was specified.
18427 Catch the fact that constructors should not have parameters.
18429 * class.cs: Do not emit parent class initializers for static
18430 constructors, that should be flagged as an error.
18432 2001-09-18 Ravi Pratap <ravi@ximian.com>
18434 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
18435 Move back code into TypeContainer::Populate.
18437 2001-09-18 Ravi Pratap <ravi@ximian.com>
18439 * class.cs (TypeContainer::AddConstructor): Fix the check to
18440 compare against Name, not Basename.
18441 (Operator::OpType): Change Plus and Minus to Add and Subtract.
18443 * cs-parser.jay : Update accordingly.
18445 * class.cs (TypeContainer::FindMembers): For the case where we are searching
18446 for methods, don't forget to look into the operators too.
18447 (RegisterMethodBuilder): Helper method to take care of this for
18448 methods, constructors and operators.
18449 (Operator::Define): Completely revamp.
18450 (Operator.OperatorMethod, MethodName): New fields.
18451 (TypeContainer::Populate): Move the registering of builders into
18452 RegisterMethodBuilder.
18453 (Operator::Emit): Re-write.
18455 * expression.cs (Binary::Emit): Comment out code path to emit method
18456 invocation stuff for the case when we have a user defined operator. I am
18457 just not able to get it right !
18459 2001-09-17 Miguel de Icaza <miguel@ximian.com>
18461 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
18464 (Expression::MemberLookup): Provide a version that allows to
18465 specify the MemberTypes and BindingFlags.
18467 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
18468 so it was not fetching variable information from outer blocks.
18470 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
18471 Beforefieldinit as it was buggy.
18473 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
18474 that Ravi put here.
18476 * class.cs (Constructor::Emit): Only emit if block is not null.
18477 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
18478 deal with this by semantically definining it as if the user had
18481 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
18482 constructors as we now "emit" them at a higher level.
18484 (TypeContainer::DefineDefaultConstructor): Used to define the
18485 default constructors if none was provided.
18487 (ConstructorInitializer): Add methods Resolve and Emit.
18489 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
18491 2001-09-17 Ravi Pratap <ravi@ximian.com>
18493 * class.cs (TypeContainer::EmitDefaultConstructor): Register
18494 the default constructor builder with our hashtable for methodbuilders
18497 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
18498 and argument_count is 0 in which case we have a match.
18499 (Binary::ResolveOperator): More null checking and miscellaneous coding
18502 2001-09-17 Ravi Pratap <ravi@ximian.com>
18504 * rootcontext.cs (IsNameSpace): Compare against null.
18506 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
18508 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
18509 and Unary::Operator.
18511 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
18514 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
18515 we have overloaded operators.
18516 (Binary::ResolveOperator): Implement the part which does the operator overload
18519 * class.cs (Operator::Emit): Implement.
18520 (TypeContainer::Emit): Emit the operators we have too.
18522 * expression.cs (Binary::Emit): Update to emit the appropriate code for
18523 the case when we have a user-defined operator.
18525 2001-09-17 Miguel de Icaza <miguel@ximian.com>
18527 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
18529 2001-09-16 Ravi Pratap <ravi@ximian.com>
18531 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
18532 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
18533 (Constructor::Emit): Implement.
18534 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
18535 if we have no work to do.
18536 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
18539 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
18540 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
18542 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
18545 2001-09-15 Ravi Pratap <ravi@ximian.com>
18547 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
18549 (Tree::RecordNamespace): Method to do what the name says ;-)
18550 (Tree::Namespaces): Property to get at the namespaces hashtable.
18552 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
18555 * rootcontext.cs (IsNamespace): Fixed it :-)
18557 2001-09-14 Miguel de Icaza <miguel@ximian.com>
18559 * class.cs (TypeContainer::FindMembers): Add support for
18561 (MethodCore): New class that encapsulates both the shared aspects
18562 of a Constructor and a Method.
18563 (Method, Constructor): Factored pieces into MethodCore.
18565 * driver.cs: Added --fatal which makes errors throw exceptions.
18566 Load System assembly as well as part of the standard library.
18568 * report.cs: Allow throwing exceptions on errors for debugging.
18570 * modifiers.cs: Do not use `parent', instead use the real type
18571 container to evaluate permission settings.
18573 * class.cs: Put Ravi's patch back in. He is right, and we will
18574 have to cope with the
18576 2001-09-14 Ravi Pratap <ravi@ximian.com>
18578 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
18579 FamORAssem, not FamANDAssem.
18581 2001-09-14 Miguel de Icaza <miguel@ximian.com>
18583 * driver.cs: Added --parse option that only parses its input files
18586 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
18587 incorrect. IsTopLevel is not used to tell whether an object is
18588 root_types or not (that can be achieved by testing this ==
18589 root_types). But to see if this is a top-level *class* (not
18590 necessarly our "toplevel" container).
18592 2001-09-14 Ravi Pratap <ravi@ximian.com>
18594 * enum.cs (Enum::Define): Modify to call the Lookup method on the
18595 parent instead of a direct call to GetType.
18597 2001-09-14 Ravi Pratap <ravi@ximian.com>
18599 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
18600 Modifiers.TypeAttr. This should just be a call to that method.
18602 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
18603 object so that we can determine if we are top-level or not.
18605 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
18608 * enum.cs (Enum::Define): Ditto.
18610 * modifiers.cs (FieldAttr): Re-write.
18612 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
18613 (TypeContainer::HaveStaticConstructor): New property to provide access
18614 to precisely that info.
18616 * modifiers.cs (MethodAttr): Re-write.
18617 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
18619 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
18620 of top-level types as claimed.
18622 2001-09-13 Miguel de Icaza <miguel@ximian.com>
18624 * expression.cs (MemberLookup): Fruitless attempt to lookup
18625 constructors. Maybe I need to emit default constructors? That
18626 might be it (currently .NET emits this for me automatically).
18627 (Invocation::OverloadResolve): Cope with Arguments == null.
18628 (Invocation::EmitArguments): new function, shared by the new
18629 constructor and us.
18630 (Invocation::Emit): Handle static and instance methods. Emit
18631 proper call instruction for virtual or non-virtual invocations.
18632 (New::Emit): Implement.
18633 (New::Resolve): Implement.
18634 (MemberAccess:Resolve): Implement.
18635 (MethodGroupExpr::InstanceExpression): used conforming to the spec
18636 to track instances.
18637 (FieldExpr::Resolve): Set type.
18639 * support.cs: Handle empty arguments.
18641 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
18642 SimpleLookup): Auxiliary routines to help parse a qualifier
18645 Update qualifier_identifier rule.
18647 * codegen.cs: Removed debugging messages.
18649 * class.cs: Make this a global thing, this acts just as a "key" to
18650 objects that we might have around.
18652 (Populate): Only initialize method_builders_to_methods once.
18654 * expression.cs (PropertyExpr): Initialize type from the
18657 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
18658 Resolve pattern. Attempt to implicitly convert value to boolean.
18661 * expression.cs: Set the type for the int32/int32 argument case.
18662 (Binary::ResolveOperator): Set the return type to boolean for
18663 comparission operators
18665 * typemanager.cs: Remove debugging print code.
18667 (Invocation::Resolve): resolve type.
18669 * class.cs: Allocate a MemberInfo of the correct size, as the code
18670 elsewhere depends on the test to reflect the correct contents.
18672 (Method::) Keep track of parameters, due to System.Reflection holes
18674 (TypeContainer::Populate): Keep track of MethodBuilders to Method
18677 (TypeContainer::FindMembers): Use ArrayList and then copy an array
18678 of the exact size and return that.
18680 (Class::LookupMethodByBuilder): New function that maps
18681 MethodBuilders to its methods. Required to locate the information
18682 on methods because System.Reflection bit us again.
18684 * support.cs: New file, contains an interface ParameterData and
18685 two implementations: ReflectionParameters and InternalParameters
18686 used to access Parameter information. We will need to grow this
18689 * expression.cs (Invocation::GetParameterData): implement a cache
18690 and a wrapper around the ParameterData creation for methods.
18691 (Invocation::OverloadResolve): Use new code.
18693 2001-09-13 Ravi Pratap <ravi@ximian.com>
18695 * class.cs (TypeContainer::EmitField): Remove and move into
18696 (Field::Define): here and modify accordingly.
18697 (Field.FieldBuilder): New member.
18698 (TypeContainer::Populate): Update accordingly.
18699 (TypeContainer::FindMembers): Implement.
18701 2001-09-13 Miguel de Icaza <miguel@ximian.com>
18703 * statement.cs: (VariableInfo::VariableType): New field to be
18704 initialized with the full type once it is resolved.
18706 2001-09-12 Miguel de Icaza <miguel@ximian.com>
18708 * parameter.cs (GetParameterInfo): Use a type cache to compute
18709 things only once, and to reuse this information
18711 * expression.cs (LocalVariableReference::Emit): Implement.
18712 (OpcodeCast::Emit): fix.
18714 (ParameterReference::Resolve): Implement.
18715 (ParameterReference::Emit): Implement.
18717 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
18718 that are expressions need to stay as Expressions.
18720 * typemanager.cs (CSharpName): Returns the C# name of a type if
18723 * expression.cs (Expression::ConvertImplicit): New function that
18724 implements implicit type conversions.
18726 (Expression::ImplicitReferenceConversion): Implements implicit
18727 reference conversions.
18729 (EmptyCast): New type for transparent casts.
18731 (OpcodeCast): New type for casts of types that are performed with
18732 a sequence of bytecodes.
18734 (BoxedCast): New type used for casting value types into reference
18735 types. Emits a box opcode.
18737 (Binary::DoNumericPromotions): Implements numeric promotions of
18738 and computation of the Binary::Type.
18740 (Binary::EmitBranchable): Optimization.
18742 (Binary::Emit): Implement code emission for expressions.
18744 * typemanager.cs (TypeManager): Added two new core types: sbyte
18747 2001-09-12 Ravi Pratap <ravi@ximian.com>
18749 * class.cs (TypeContainer::FindMembers): Method which does exactly
18750 what Type.FindMembers does, only we don't have to use reflection. No
18751 implementation yet.
18753 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
18754 typecontainer objects as we need to get at them.
18755 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
18757 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
18758 typecontainer object.
18760 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
18761 of just a Report object.
18763 2001-09-11 Ravi Pratap <ravi@ximian.com>
18765 * class.cs (Event::Define): Go back to using the prefixes "add_" and
18767 (TypeContainer::Populate): Now define the delegates of the type too.
18768 (TypeContainer.Delegates): Property to access the list of delegates defined
18771 * delegates.cs (Delegate::Define): Implement partially.
18773 * modifiers.cs (TypeAttr): Handle more flags.
18775 2001-09-11 Ravi Pratap <ravi@ximian.com>
18777 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
18779 (Operator::Define): Re-write logic to get types by using the LookupType method
18780 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
18781 (Indexer::Define): Ditto.
18782 (Event::Define): Ditto.
18783 (Property::Define): Ditto.
18785 2001-09-10 Ravi Pratap <ravi@ximian.com>
18787 * class.cs (TypeContainer::Populate): Now define operators too.
18788 (TypeContainer.Operators): New property to access the list of operators
18790 (Operator.OperatorMethodBuilder): New member to hold the method builder
18791 for the operator we are defining.
18792 (Operator::Define): Implement.
18794 2001-09-10 Ravi Pratap <ravi@ximian.com>
18796 * class.cs (Event::Define): Make the prefixes of the accessor methods
18797 addOn_ and removeOn_
18799 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
18800 of the location being passed in too. Ideally, this should go later since all
18801 error reporting should be done through the Report object.
18803 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
18804 (Populate): Iterate thru the indexers we have and define them too.
18805 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
18806 for the get and set accessors.
18807 (Indexer::Define): Implement.
18809 2001-09-09 Miguel de Icaza <miguel@ximian.com>
18811 * expression.cs (Binary::Resolve): Beginning of it. I scratched
18812 my previous implementation, did not work.
18814 * typemanager.cs: Add a couple of missing types (the longs).
18816 * literal.cs: Use TypeManager.bool_type instead of getting it.
18818 * expression.cs (EventExpr): New kind of expressions.
18819 (Expressio::ExprClassFromMemberInfo): finish
18821 2001-09-08 Miguel de Icaza <miguel@ximian.com>
18823 * assign.cs: Emit stores to static fields differently.
18825 2001-09-08 Ravi Pratap <ravi@ximian.com>
18827 * Merge in changes and adjust code to tackle conflicts. Backed out my
18828 code in Assign::Resolve ;-)
18830 2001-09-08 Ravi Pratap <ravi@ximian.com>
18832 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
18833 instead Report.Error and also pass in the location.
18834 (CSharpParser::Lexer): New readonly property to return the reference
18835 to the Tokenizer object.
18836 (declare_local_variables): Use Report.Error with location instead of plain
18840 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
18841 (Operator.CheckBinaryOperator): Ditto.
18843 * cs-parser.jay (operator_declarator): Update accordingly.
18845 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
18846 (CheckBinaryOperator): Same here.
18848 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
18849 on the name without any prefixes of namespace names etc. This is because we
18850 already might have something already fully qualified like
18851 'System.Console.WriteLine'
18853 * assign.cs (Resolve): Begin implementation. Stuck ;-)
18855 2001-09-07 Ravi Pratap <ravi@ximian.com>
18857 * cs-tokenizer.cs (location): Return a string which also contains
18860 * expression.cs (ElementAccess): New class for expressions of the
18861 type 'element access.'
18862 (BaseAccess): New class for expressions of the type 'base access.'
18863 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
18866 * cs-parser.jay (element_access): Implement action.
18867 (base_access): Implement actions.
18868 (checked_expression, unchecked_expression): Implement.
18870 * cs-parser.jay (local_variable_type): Correct and implement.
18871 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
18873 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
18875 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
18876 name and the specifiers.
18878 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
18880 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
18881 making them all public ;-)
18883 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
18886 2001-09-07 Miguel de Icaza <miguel@ximian.com>
18888 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
18890 (FieldExpr, PropertyExprs): New resolved expressions.
18891 (SimpleName::MemberStaticCheck): Perform static checks for access
18892 to non-static fields on static methods. Maybe this should be
18893 generalized for MemberAccesses.
18894 (SimpleName::ResolveSimpleName): More work on simple name
18897 * cs-parser.jay (primary_expression/qualified_identifier): track
18898 the parameter index.
18900 * codegen.cs (CodeGen::Save): Catch save exception, report error.
18901 (EmitContext::EmitBoolExpression): Chain to expression generation
18902 instead of temporary hack.
18903 (::EmitStatementExpression): Put generic expression code generation.
18905 * assign.cs (Assign::Emit): Implement variable assignments to
18906 local variables, parameters and fields.
18908 2001-09-06 Miguel de Icaza <miguel@ximian.com>
18910 * statement.cs (Block::GetVariableInfo): New method, returns the
18911 VariableInfo for a variable name in a block.
18912 (Block::GetVariableType): Implement in terms of GetVariableInfo
18914 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
18915 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
18917 2001-09-06 Ravi Pratap <ravi@ximian.com>
18919 * cs-parser.jay (operator_declaration): Continue on my quest : update
18920 to take attributes argument.
18921 (event_declaration): Ditto.
18922 (enum_declaration): Ditto.
18923 (indexer_declaration): Ditto.
18925 * class.cs (Operator::Operator): Update constructor accordingly.
18926 (Event::Event): Ditto.
18928 * delegate.cs (Delegate::Delegate): Same here.
18930 * enum.cs (Enum::Enum): Same here.
18932 2001-09-05 Ravi Pratap <ravi@ximian.com>
18934 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
18936 * ../tests/cs0658.cs : New file to demonstrate error 0658.
18938 * attribute.cs (Attributes): New class to encapsulate all attributes which were
18939 being passed around as an arraylist.
18940 (Attributes::AddAttribute): Method to add attribute sections.
18942 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
18943 (struct_declaration): Update accordingly.
18944 (constant_declaration): Update.
18945 (field_declaration): Update.
18946 (method_header): Update.
18947 (fixed_parameter): Update.
18948 (parameter_array): Ditto.
18949 (property_declaration): Ditto.
18950 (destructor_declaration): Ditto.
18952 * class.cs (Struct::Struct): Update constructors accordingly.
18953 (Class::Class): Ditto.
18954 (Field::Field): Ditto.
18955 (Method::Method): Ditto.
18956 (Property::Property): Ditto.
18957 (TypeContainer::OptAttribute): update property's return type.
18959 * interface.cs (Interface.opt_attributes): New member.
18960 (Interface::Interface): Update to take the extra Attributes argument.
18962 * parameter.cs (Parameter::Parameter): Ditto.
18964 * constant.cs (Constant::Constant): Ditto.
18966 * interface.cs (InterfaceMemberBase): New OptAttributes field.
18967 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
18968 the attributes as a parameter.
18969 (InterfaceProperty): Update constructor call.
18970 (InterfaceEvent): Ditto.
18971 (InterfaceMethod): Ditto.
18972 (InterfaceIndexer): Ditto.
18974 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
18975 pass the attributes too.
18976 (interface_event_declaration): Ditto.
18977 (interface_property_declaration): Ditto.
18978 (interface_method_declaration): Ditto.
18979 (interface_declaration): Ditto.
18981 2001-09-05 Miguel de Icaza <miguel@ximian.com>
18983 * class.cs (Method::Define): Track the "static Main" definition to
18984 create an entry point.
18986 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
18987 EntryPoint if we find it.
18989 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
18990 (EmitContext::ig): Make this variable public.
18992 * driver.cs: Make the default output file be the first file name
18993 with the .exe extension.
18995 Detect empty compilations
18997 Handle various kinds of output targets. Handle --target and
18998 rename -t to --dumper.
19000 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
19001 methods inherited from Expression return now an Expression. This
19002 will is used during the tree rewriting as we resolve them during
19005 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
19006 the spec. Missing entirely is the information about
19007 accessability of elements of it.
19009 (Expression::ExprClassFromMemberInfo): New constructor for
19010 Expressions that creates a fully initialized Expression based on
19011 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
19014 (Invocation::Resolve): Begin implementing resolution of invocations.
19016 * literal.cs (StringLiteral): Implement Emit.
19018 2001-09-05 Ravi Pratap <ravi@ximian.com>
19020 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
19023 2001-09-04 Ravi Pratap <ravi@ximian.com>
19025 * cs-parser.jay (attribute_arguments): Implement actions.
19026 (attribute): Fix bug in production. Implement action.
19027 (attribute_list): Implement.
19028 (attribute_target): Implement.
19029 (attribute_target_specifier, opt_target_specifier): Implement
19030 (CheckAttributeTarget): New method to check if the attribute target
19032 (attribute_section): Implement.
19033 (opt_attributes): Implement.
19035 * attribute.cs : New file to handle attributes.
19036 (Attribute): Class to hold attribute info.
19038 * cs-parser.jay (opt_attribute_target_specifier): Remove production
19039 (attribute_section): Modify production to use 2 different rules to
19040 achieve the same thing. 1 s/r conflict down !
19041 Clean out commented, useless, non-reducing dimension_separator rules.
19043 * class.cs (TypeContainer.attributes): New member to hold list
19044 of attributes for a type.
19045 (Struct::Struct): Modify to take one more argument, the attribute list.
19046 (Class::Class): Ditto.
19047 (Field::Field): Ditto.
19048 (Method::Method): Ditto.
19049 (Property::Property): Ditto.
19051 * cs-parser.jay (struct_declaration): Update constructor call to
19052 pass in the attributes too.
19053 (class_declaration): Ditto.
19054 (constant_declaration): Ditto.
19055 (field_declaration): Ditto.
19056 (method_header): Ditto.
19057 (fixed_parameter): Ditto.
19058 (parameter_array): Ditto.
19059 (property_declaration): Ditto.
19061 * constant.cs (Constant::Constant): Update constructor similarly.
19062 Use System.Collections.
19064 * parameter.cs (Parameter::Parameter): Update as above.
19066 2001-09-02 Ravi Pratap <ravi@ximian.com>
19068 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
19069 (TypeContainer.delegates): New member to hold list of delegates.
19071 * cs-parser.jay (delegate_declaration): Implement the action correctly
19072 this time as I seem to be on crack ;-)
19074 2001-09-02 Miguel de Icaza <miguel@ximian.com>
19076 * rootcontext.cs (RootContext::IsNamespace): new function, used to
19077 tell whether an identifier represents a namespace.
19079 * expression.cs (NamespaceExpr): A namespace expression, used only
19080 temporarly during expression resolution.
19081 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
19082 utility functions to resolve names on expressions.
19084 2001-09-01 Miguel de Icaza <miguel@ximian.com>
19086 * codegen.cs: Add hook for StatementExpressions.
19088 * class.cs: Fix inverted test for static flag in methods.
19090 2001-09-02 Ravi Pratap <ravi@ximian.com>
19092 * class.cs (Operator::CheckUnaryOperator): Correct error number used
19093 to make it coincide with MS' number.
19094 (Operator::CheckBinaryOperator): Ditto.
19096 * ../errors/errors.txt : Remove error numbers added earlier.
19098 * ../errors/cs1019.cs : Test case for error # 1019
19100 * ../errros/cs1020.cs : Test case for error # 1020
19102 * cs-parser.jay : Clean out commented cruft.
19103 (dimension_separators, dimension_separator): Comment out. Ostensibly not
19104 used anywhere - non-reducing rule.
19105 (namespace_declarations): Non-reducing rule - comment out.
19107 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
19108 with TypeContainer::AddEnum.
19110 * delegate.cs : New file for delegate handling classes.
19111 (Delegate): Class for declaring delegates.
19113 * makefile : Update.
19115 * cs-parser.jay (delegate_declaration): Implement.
19117 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
19119 * class.cs (Event::Define): Implement.
19120 (Event.EventBuilder): New member.
19122 * class.cs (TypeContainer::Populate): Update to define all enums and events
19124 (Events): New property for the events arraylist we hold. Shouldn't we move to using
19125 readonly fields for all these cases ?
19127 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
19129 * class.cs (Property): Revamp to use the convention of making fields readonly.
19130 Accordingly modify code elsewhere.
19132 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
19133 the Define method of the Property class.
19135 * class.cs : Clean up applied patch and update references to variables etc. Fix
19137 (TypeContainer::Populate): Update to define all the properties we have. Also
19138 define all enumerations.
19140 * enum.cs (Define): Implement.
19142 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
19144 * cs-parser.jay (overloadable_operator): The semantic value is an
19145 enum of the Operator class.
19146 (operator_declarator): Implement actions.
19147 (operator_declaration): Implement.
19149 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
19150 validity of definitions.
19151 (Operator::CheckBinaryOperator): Static method to check for binary operators
19152 (TypeContainer::AddOperator): New method to add an operator to a type.
19154 * cs-parser.jay (indexer_declaration): Added line to actually call the
19155 AddIndexer method so it gets added ;-)
19157 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
19158 already taken care of by the MS compiler ?
19160 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
19162 * class.cs (Operator): New class for operator declarations.
19163 (Operator::OpType): Enum for the various operators.
19165 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
19167 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
19168 ostensibly handle this in semantic analysis.
19170 * cs-parser.jay (general_catch_clause): Comment out
19171 (specific_catch_clauses, specific_catch_clause): Ditto.
19172 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
19173 (catch_args, opt_catch_args): New productions.
19174 (catch_clause): Rewrite to use the new productions above
19175 (catch_clauses): Modify accordingly.
19176 (opt_catch_clauses): New production to use in try_statement
19177 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
19178 and re-write the code in the actions to extract the specific and
19179 general catch clauses by being a little smart ;-)
19181 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
19182 Hooray, try and catch statements parse fine !
19184 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
19186 * statement.cs (Block::GetVariableType): Fix logic to extract the type
19187 string from the hashtable of variables.
19189 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
19190 I end up making that mistake ;-)
19191 (catch_clauses): Fixed gross error which made Key and Value of the
19192 DictionaryEntry the same : $1 !!
19194 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
19196 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
19198 * cs-parser.jay (event_declaration): Correct to remove the semicolon
19199 when the add and remove accessors are specified.
19201 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
19203 * cs-parser.jay (IndexerDeclaration): New helper class to hold
19204 information about indexer_declarator.
19205 (indexer_declarator): Implement actions.
19206 (parsing_indexer): New local boolean used to keep track of whether
19207 we are parsing indexers or properties. This is necessary because
19208 implicit_parameters come into picture even for the get accessor in the
19209 case of an indexer.
19210 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
19212 * class.cs (Indexer): New class for indexer declarations.
19213 (TypeContainer::AddIndexer): New method to add an indexer to a type.
19214 (TypeContainer::indexers): New member to hold list of indexers for the
19217 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
19219 * cs-parser.jay (add_accessor_declaration): Implement action.
19220 (remove_accessor_declaration): Implement action.
19221 (event_accessors_declaration): Implement
19222 (variable_declarators): swap statements for first rule - trivial.
19224 * class.cs (Event): New class to hold information about event
19226 (TypeContainer::AddEvent): New method to add an event to a type
19227 (TypeContainer::events): New member to hold list of events.
19229 * cs-parser.jay (event_declaration): Implement actions.
19231 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
19233 * cs-parser.jay (dim_separators): Implement. Make it a string
19234 concatenating all the commas together, just as they appear.
19235 (opt_dim_separators): Modify accordingly
19236 (rank_specifiers): Update accordingly. Basically do the same
19237 thing - instead, collect the brackets here.
19238 (opt_rank_sepcifiers): Modify accordingly.
19239 (array_type): Modify to actually return the complete type string
19240 instead of ignoring the rank_specifiers.
19241 (expression_list): Implement to collect the expressions
19242 (variable_initializer): Implement. We make it a list of expressions
19243 essentially so that we can handle the array_initializer case neatly too.
19244 (variable_initializer_list): Implement.
19245 (array_initializer): Make it a list of variable_initializers
19246 (opt_array_initializer): Modify accordingly.
19248 * expression.cs (New::NType): Add enumeration to help us
19249 keep track of whether we have an object/delegate creation
19250 or an array creation.
19251 (New:NewType, New::Rank, New::Indices, New::Initializers): New
19252 members to hold data about array creation.
19253 (New:New): Modify to update NewType
19254 (New:New): New Overloaded contructor for the array creation
19257 * cs-parser.jay (array_creation_expression): Implement to call
19258 the overloaded New constructor.
19260 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
19262 * class.cs (TypeContainer::Constructors): Return member
19263 constructors instead of returning null.
19265 2001-08-26 Miguel de Icaza <miguel@ximian.com>
19267 * typemanager.cs (InitCoreTypes): Initialize the various core
19268 types after we have populated the type manager with the user
19269 defined types (this distinction will be important later while
19270 compiling corlib.dll)
19272 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
19273 on Expression Classification. Now all expressions have a method
19274 `Resolve' and a method `Emit'.
19276 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
19277 generation from working. Also add some temporary debugging
19280 2001-08-24 Miguel de Icaza <miguel@ximian.com>
19282 * codegen.cs: Lots of code generation pieces. This is only the
19283 beginning, will continue tomorrow with more touches of polish. We
19284 handle the fundamentals of if, while, do, for, return. Others are
19285 trickier and I need to start working on invocations soon.
19287 * gen-treedump.cs: Bug fix, use s.Increment here instead of
19290 * codegen.cs (EmitContext): New struct, used during code
19291 emission to keep a context. Most of the code generation will be
19294 * cs-parser.jay: Add embedded blocks to the list of statements of
19295 this block. So code generation proceeds in a top down fashion.
19297 2001-08-23 Miguel de Icaza <miguel@ximian.com>
19299 * statement.cs: Add support for multiple child blocks.
19301 2001-08-22 Miguel de Icaza <miguel@ximian.com>
19303 * codegen.cs (EmitCode): New function, will emit the code for a
19304 Block of code given a TypeContainer and its ILGenerator.
19306 * statement.cs (Block): Standard public readonly optimization.
19307 (Block::Block constructors): Link children.
19308 (Block::Child): Child Linker.
19309 (Block::EmitVariables): Emits IL variable declarations.
19311 * class.cs: Drop support for MethodGroups here, delay until
19313 (Method::): Applied the same simplification that I did before, and
19314 move from Properties to public readonly fields.
19315 (Method::ParameterTypes): Returns the parameter types for the
19316 function, and implements a cache that will be useful later when I
19317 do error checking and the semantic analysis on the methods is
19319 (Constructor::GetCallingConvention): Renamed from CallingConvetion
19320 and made a method, optional argument tells whether this is a class
19321 or a structure to apply the `has-this' bit.
19322 (Method::GetCallingConvention): Implement, returns the calling
19324 (Method::Define): Defines the type, a second pass is performed
19325 later to populate the methods.
19327 (Constructor::ParameterTypes): implement a cache similar to the
19328 one on Method::ParameterTypes, useful later when we do semantic
19331 (TypeContainer::EmitMethod): New method. Emits methods.
19333 * expression.cs: Removed MethodGroup class from here.
19335 * parameter.cs (Parameters::GetCallingConvention): new method.
19337 2001-08-21 Miguel de Icaza <miguel@ximian.com>
19339 * class.cs (TypeContainer::Populate): Drop RootContext from the
19342 (Constructor::CallingConvention): Returns the calling convention.
19343 (Constructor::ParameterTypes): Returns the constructor parameter
19346 (TypeContainer::AddConstructor): Keep track of default constructor
19347 and the default static constructor.
19349 (Constructor::) Another class that starts using `public readonly'
19350 instead of properties.
19352 (Constructor::IsDefault): Whether this is a default constructor.
19354 (Field::) use readonly public fields instead of properties also.
19356 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
19357 track of static constructors; If none is used, turn on
19358 BeforeFieldInit in the TypeAttributes.
19360 * cs-parser.jay (opt_argument_list): now the return can be null
19361 for the cases where there are no arguments.
19363 (constructor_declarator): If there is no implicit `base' or
19364 `this', then invoke the default parent constructor.
19366 * modifiers.cs (MethodAttr): New static function maps a set of
19367 modifiers flags into a MethodAttributes enum
19368 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
19369 MethodAttr, TypeAttr to represent the various mappings where the
19370 modifiers are used.
19371 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
19373 2001-08-19 Miguel de Icaza <miguel@ximian.com>
19375 * parameter.cs (GetParameterInfo): Fix bug where there would be no
19378 * interface.cs (PopulateIndexer): Implemented the code generator
19379 for interface indexers.
19381 2001-08-17 Miguel de Icaza <miguel@ximian.com>
19383 * interface.cs (InterfaceMemberBase): Now we track the new status
19386 (PopulateProperty): Implement property population. Woohoo! Got
19387 Methods and Properties going today.
19389 Removed all the properties for interfaces, and replaced them with
19390 `public readonly' fields.
19392 2001-08-16 Miguel de Icaza <miguel@ximian.com>
19394 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
19395 initialize their hashtables/arraylists only when they are needed
19396 instead of doing this always.
19398 * parameter.cs: Handle refs and out parameters.
19400 * cs-parser.jay: Use an ArrayList to construct the arguments
19401 instead of the ParameterCollection, and then cast that to a
19404 * parameter.cs: Drop the use of ParameterCollection and use
19405 instead arrays of Parameters.
19407 (GetParameterInfo): Use the Type, not the Name when resolving
19410 2001-08-13 Miguel de Icaza <miguel@ximian.com>
19412 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
19413 and instead use public readonly fields.
19415 * class.cs: Put back walking code for type containers.
19417 2001-08-11 Miguel de Icaza <miguel@ximian.com>
19419 * class.cs (MakeConstant): Code to define constants.
19421 * rootcontext.cs (LookupType): New function. Used to locate types
19424 2001-08-08 Miguel de Icaza <miguel@ximian.com>
19426 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
19427 this System.Reflection code is. Kudos to Microsoft
19429 * typemanager.cs: Implement a type cache and avoid loading all
19430 types at boot time. Wrap in LookupType the internals. This made
19431 the compiler so much faster. Wow. I rule!
19433 * driver.cs: Make sure we always load mscorlib first (for
19434 debugging purposes, nothing really important).
19436 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
19437 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
19439 * rootcontext.cs: Lookup types on their namespace; Lookup types
19440 on namespaces that have been imported using the `using' keyword.
19442 * class.cs (TypeContainer::TypeAttr): Virtualize.
19443 (Class::TypeAttr): Return attributes suitable for this bad boy.
19444 (Struct::TypeAttr): ditto.
19445 Handle nested classes.
19446 (TypeContainer::) Remove all the type visiting code, it is now
19447 replaced with the rootcontext.cs code
19449 * rootcontext.cs (GetClassBases): Added support for structs.
19451 2001-08-06 Miguel de Icaza <miguel@ximian.com>
19453 * interface.cs, statement.cs, class.cs, parameter.cs,
19454 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
19455 Drop use of TypeRefs, and use strings instead.
19457 2001-08-04 Miguel de Icaza <miguel@ximian.com>
19461 * class.cs (Struct::Struct): set the SEALED flags after
19462 checking the modifiers.
19463 (TypeContainer::TypeAttr): new property, returns the
19464 TypeAttributes for a class.
19466 * cs-parser.jay (type_list): Oops, list production was creating a
19467 new list of base types.
19469 * rootcontext.cs (StdLib): New property.
19470 (GetInterfaceTypeByName): returns an interface by type name, and
19471 encapsulates error handling here.
19472 (GetInterfaces): simplified.
19473 (ResolveTree): Encapsulated all the tree resolution here.
19474 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
19477 * driver.cs: Add support for --nostdlib, to avoid loading the
19478 default assemblies.
19479 (Main): Do not put tree resolution here.
19481 * rootcontext.cs: Beginning of the class resolution.
19483 2001-08-03 Miguel de Icaza <miguel@ximian.com>
19485 * rootcontext.cs: Provide better error reporting.
19487 * cs-parser.jay (interface_base): set our $$ to be interfaces.
19489 * rootcontext.cs (CreateInterface): Handle the case where there
19490 are no parent interfaces.
19492 (CloseTypes): Routine to flush types at the end.
19493 (CreateInterface): Track types.
19494 (GetInterfaces): Returns an array of Types from the list of
19495 defined interfaces.
19497 * typemanager.c (AddUserType): Mechanism to track user types (puts
19498 the type on the global type hash, and allows us to close it at the
19501 2001-08-02 Miguel de Icaza <miguel@ximian.com>
19503 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
19504 RecordInterface instead.
19506 * cs-parser.jay: Updated to reflect changes above.
19508 * decl.cs (Definition): Keep track of the TypeBuilder type that
19509 represents this type here. Not sure we will use it in the long
19510 run, but wont hurt for now.
19512 * driver.cs: Smaller changes to accomodate the new code.
19514 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
19517 * rootcontext.cs (CreateInterface): New method, used to create
19518 the System.TypeBuilder type for interfaces.
19519 (ResolveInterfaces): new entry point to resolve the interface
19521 (CodeGen): Property, used to keep track of the code generator.
19523 2001-07-26 Miguel de Icaza <miguel@ximian.com>
19525 * cs-parser.jay: Add a second production for delegate_declaration
19528 (enum_body): Put an opt_comma here instead of putting it on
19529 enum_body or enum_member_declarations so we can handle trailing
19530 commas on enumeration members. Gets rid of a shift/reduce.
19532 (type_list): Need a COMMA in the middle.
19534 (indexer_declaration): Tell tokenizer to recognize get/set
19536 * Remove old targets.
19538 * Re-add the parser target.
19540 2001-07-13 Simon Cozens <simon@simon-cozens.org>
19542 * cs-parser.jay: Add precendence rules for a number of operators
19543 ot reduce the number of shift/reduce conflicts in the grammar.
19545 2001-07-17 Miguel de Icaza <miguel@ximian.com>
19547 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
19550 Get rid of old crufty code.
19552 * rootcontext.cs: Use this to keep track of the parsed
19553 representation and the defined types available to the program.
19555 * gen-treedump.cs: adjust for new convention.
19557 * type.cs: Split out the type manager, and the assembly builder
19560 * typemanager.cs: the type manager will live here now.
19562 * cil-codegen.cs: And the code generator here.
19564 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
19566 * makefile: Fixed up for easy making.
19568 2001-07-13 Simon Cozens <simon@simon-cozens.org>
19570 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
19573 (unary_expression): Expand pre_increment_expression and
19574 post_decrement_expression to reduce a shift/reduce.
19576 2001-07-11 Simon Cozens
19578 * cs-tokenizer.cs: Hex numbers should begin with a 0.
19580 Improve allow_keyword_as_indent name.
19582 2001-06-19 Miguel de Icaza <miguel@ximian.com>
19584 * Adjustments for Beta2.
19586 2001-06-13 Miguel de Icaza <miguel@ximian.com>
19588 * decl.cs: Added `Define' abstract method.
19589 (InTransit): new property, used to catch recursive definitions.
19591 * interface.cs: Implement `Define'.
19593 * modifiers.cs: Map Modifiers.constants to
19594 System.Reflection.TypeAttribute flags.
19596 * class.cs: Keep track of types and user-defined types.
19597 (BuilderInit): New method for creating an assembly
19598 (ResolveType): New function to launch the resolution process, only
19599 used by interfaces for now.
19601 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
19602 that are inserted into the name space.
19604 2001-06-08 Miguel de Icaza <miguel@ximian.com>
19606 * ARGH. I have screwed up my tree so many times due to the use of
19607 rsync rather than using CVS. Going to fix this at once.
19609 * driver.cs: Objetify driver. Load assemblies, use assemblies to
19612 2001-06-07 Miguel de Icaza <miguel@ximian.com>
19614 * Experiment successful: Use System.Type rather that our own
19617 2001-05-25 Miguel de Icaza <miguel@ximian.com>
19619 * cs-parser.jay: Removed nsAliases from here.
19621 Use new namespaces, handle `using XXX;'
19623 * namespace.cs: Reimplemented namespace handling, use a recursive
19624 definition of the class. Now we can keep track of using clauses
19625 and catch invalid using clauses.
19627 2001-05-24 Miguel de Icaza <miguel@ximian.com>
19629 * gen-treedump.cs: Adapted for all the renaming.
19631 * expression.cs (Expression): this class now has a Type property
19632 which returns an expression Type.
19634 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
19635 `Type', as this has a different meaning now in the base
19637 2001-05-22 Miguel de Icaza <miguel@ximian.com>
19639 * interface.cs, class.cs: Removed from all the sources the
19640 references to signature computation, as we can not do method
19641 signature computation during the parsing time, as we are not
19642 trying to solve at that point distinguishing:
19646 void a (NS.Blah x) {}
19649 Which depending on the context might be valid or not, as we do not
19650 know if Blah is the same thing as NS.Blah at that point.
19652 * Redid everything so the code uses TypeRefs now instead of
19653 Types. TypeRefs are just temporary type placeholders, that need
19654 to be resolved. They initially have a pointer to a string and the
19655 current scope in which they are used. This is used later by the
19656 compiler to resolve the reference to an actual Type.
19658 * DeclSpace is no longer a CIR.Type, and neither are
19659 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
19660 are all DeclSpaces, but no Types.
19662 * type.cs (TypeRefManager): This implements the TypeRef manager,
19663 which keeps track of all the types that need to be resolved after
19664 the parsing has finished.
19666 2001-05-13 Miguel de Icaza <miguel@ximian.com>
19668 * ARGH. We are going to have to store `foreach' as a class rather
19669 than resolving it, as we need to verify error 1579 after name
19670 resolution. *OR* we could keep a flag that says `This request to
19671 IEnumerator comes from a foreach statement' which we can then use
19672 to generate the error.
19674 2001-05-10 Miguel de Icaza <miguel@ximian.com>
19676 * class.cs (TypeContainer.AddMethod): we now add methods to the
19677 MethodGroup instead of the method hashtable.
19679 * expression.cs: Add MethodGroup abstraction, which gets us one
19680 step closer to the specification in the way we handle method
19683 * cs-parser.jay (primary_expression): qualified_identifier now
19684 tried to match up an identifier to a local variable reference or
19685 to a parameter reference.
19687 current_local_parameters is now a parser global variable that
19688 points to the current parameters for the block, used during name
19691 (property_declaration): Now creates an implicit `value' argument to
19694 2001-05-09 Miguel de Icaza <miguel@ximian.com>
19696 * parameter.cs: Do not use `param' arguments as part of the
19697 signature, per the spec.
19699 2001-05-08 Miguel de Icaza <miguel@ximian.com>
19701 * decl.cs: Base class for classes, structs and interfaces. This
19702 is the "Declaration Space"
19704 * cs-parser.jay: Use CheckDef for checking declaration errors
19705 instead of having one on each function.
19707 * class.cs: Factor out some code for handling error handling in
19708 accordance to the "Declarations" section in the "Basic Concepts"
19709 chapter in the ECMA C# spec.
19711 * interface.cs: Make all interface member classes derive from
19712 InterfaceMemberBase.
19714 2001-05-07 Miguel de Icaza <miguel@ximian.com>
19716 * Many things: all interfaces are parsed and generated in
19717 gen-treedump. Support for member variables, constructors,
19718 destructors, properties, constants is there.
19720 Beginning of the IL backend, but very little done, just there for
19723 2001-04-29 Miguel de Icaza <miguel@ximian.com>
19725 * cs-parser.jay: Fix labeled statement.
19727 * cs-tokenizer.cs (escape): Escape " and ' always.
19728 ref_line, ref_name: keep track of the line/filename as instructed
19729 by #line by the compiler.
19732 2001-04-27 Miguel de Icaza <miguel@ximian.com>
19734 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
19735 to match the values in System.CodeDOM.
19737 Divid renamed to Divide.
19739 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
19741 (Statements.set): remove.
19743 * System.CodeDOM/CodeCatchClause.cs: always have a valid
19746 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
19747 falseStatements always have valid values.
19749 * cs-parser.jay: Use System.CodeDOM now.