1 2003-07-22 Ravi Pratap <ravi@ximian.com>
3 * expression.cs (Invocation.OverloadResolve): Follow the spec more
4 closely: we eliminate methods in base types when we have an
5 applicable method in a top-level type.
7 Please see section 14.5.5.1 for an exact description of what goes
10 This fixes bug #45127 and a host of other related to corlib compilation.
12 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
13 array is the method corresponding to the top-level type (this is
14 because of the changes made to icall.c) so we change this
17 (MethodGroupExpr.Name): This too.
19 * typemanager.cs (GetElementType): New method which does the right
20 thing when compiling corlib.
22 * everywhere: Make use of the above in the relevant places.
24 2003-07-22 Martin Baulig <martin@ximian.com>
26 * cs-parser.jay (invocation_expression): Moved
27 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
28 `cast_expression', but create a InvocationOrCast which later
29 resolves to either an Invocation or a Cast.
31 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
32 method; call this before EmitStatement() to make sure that this
33 expression can be used as a statement.
35 * expression.cs (InvocationOrCast): New class; resolves to either
36 an Invocation or a Cast.
38 * statement.cs (StatementExpression): Call ResolveStatement() on
39 the ExpressionStatement before emitting it.
41 2003-07-21 Martin Baulig <martin@ximian.com>
43 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
44 `ref' and `out' attributes match; fixes #46220.
45 (MemberAccess.ResolveMemberAccess): You can't reference a type
46 through an expression; fixes #33180.
47 (Indexers.GetIndexersForType): Don't return the indexers from
48 interfaces the class implements; fixes #46502.
50 2003-07-21 Martin Baulig <martin@ximian.com>
52 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
53 CS0661 checks; fixes bug #30442.
55 2003-07-21 Martin Baulig <martin@ximian.com>
57 * decl.cs (AdditionResult): Added `Error'.
59 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
61 * typemanager.cs (TypeManager.ChangeType): Catch exceptions;
62 makes cs0031.cs actually work.
64 2003-07-20 Martin Baulig <martin@ximian.com>
66 * namespace.cs: Fixed that bug which caused a crash when compiling
69 2003-07-20 Miguel de Icaza <miguel@ximian.com>
71 * typemanager.cs (LookupTypeReflection): Never expose types which
72 are NotPublic, NestedPrivate, NestedAssembly, or
73 NestedFamANDAssem. We used to return these, and later do a check
74 that would report a meaningful error, but the problem is that we
75 would not get the real match, if there was a name override.
77 2003-07-18 Miguel de Icaza <miguel@ximian.com>
79 * namespace.cs (Namespace, Name): Do not compute the namespace
80 name dynamically, compute it in the constructor. This reduced
81 memory usage by 1697 KB.
83 * driver.cs: Use --pause to pause at the end.
85 2003-07-17 Peter Williams <peter@newton.cx>
87 * Makefile: Change the name of the test target so that it doesn't
88 conflict with the recursive test target.
90 2003-07-17 Miguel de Icaza <miguel@ximian.com>
92 * expression.cs (LocalVariableReference.Emit, EmitAssign,
93 AddressOf): Do not use EmitThis, that was wrong, use the actual
96 2003-07-15 Miguel de Icaza <miguel@ximian.com>
98 * class.cs (MethodData.Define): While checking if a method is an
99 interface implementation, improve the test: If we are not public
100 (use new test here: use the computed MethodAttributes directly,
101 instead of the parsed modifier flags) check if the `implementing'
102 method comes from an interface or not.
104 * pending.cs (VerifyPendingMethods): Slightly better error
107 * makefile: add test target that does the mcs bootstrap.
109 2003-07-16 Ravi Pratap <ravi@ximian.com>
111 * interface.cs (Define): Do nothing here since there are no
112 members to populate etc. Move the attribute emission out of here
113 since this was just totally the wrong place to put it. Attribute
114 application happens during the 'Emit' phase, not in the 'Define'
117 (Emit): Add this method and move the attribute emission here
119 * rootcontext.cs (EmitCode): Call the Emit method on interface
122 2003-07-14 Ravi Pratap M <ravi@ximian.com>
124 * expression.cs (OverloadResolve): Report error only if Location
125 is not 'Null' which means that there was a probe going on.
127 2003-07-14 Martin Baulig <martin@ximian.com>
129 * expression.cs (ConditionalLogicalOperator): New public class to
130 implement user defined conditional logical operators.
131 This is section 14.11.2 in the spec and bug #40505.
133 2003-07-14 Martin Baulig <martin@ximian.com>
135 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
137 2003-07-14 Martin Baulig <martin@ximian.com>
139 * codegen.cs (EmitContext.InFixedInitializer): New public field.
141 * ecore.cs (IVariable.VerifyFixed): New interface method.
143 * expression.cs (Unary.ResolveOperator): When resolving the `&'
144 operator, check whether the variable is actually fixed. Fixes bug
145 #36055. Set a variable definitely assigned when taking its
146 address as required by the spec.
148 * statement.cs (LocalInfo.IsFixed): New field.
149 (LocalInfo.MakePinned): Set `IsFixed' to true.
151 2003-07-14 Ravi Pratap M <ravi@ximian.com>
153 * attribute.cs (Attribute.Resolve): While doing a Member lookup
154 for .ctors, ensure that we only ask for members declared in the
155 attribute type (BindingFlags.DeclaredOnly).
159 * expression.cs (Error_WrongNumArguments): Report error 1501
160 correctly the way CSC does.
162 2003-07-13 Martin Baulig <martin@ximian.com>
164 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
165 lookup on the fully qualified name, to make things like "X.X" work
166 where "X.X" is a fully qualified type name, but we also have a
167 namespace "X" in the using list. Fixes #41975.
169 2003-07-13 Martin Baulig <martin@ximian.com>
171 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
172 function. If we're a CompoundAssign, we need to create an embedded
173 CompoundAssign, not an embedded Assign.
174 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
177 2003-07-13 Martin Baulig <martin@ximian.com>
179 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
180 work to fix bug #46088.
182 2003-07-13 Ravi Pratap <ravi@ximian.com>
184 * class.cs (Operator.Emit): Do not emit attributes here - it is
185 taken care of by the Method class that we delegate too. This takes
188 2003-07-10 Martin Baulig <martin@ximian.com>
190 * expression.cs (TypeOfVoid): New class.
191 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
193 2003-07-10 Martin Baulig <martin@ximian.com>
195 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
198 2003-07-10 Martin Baulig <martin@ximian.com>
200 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
201 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
203 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
205 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
207 2003-07-10 Martin Baulig <martin@ximian.com>
209 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
210 of decimal. Fixes #42850.
212 NOTE: I also fixed the created byte blob, but this doesn't work on
213 the MS runtime and csc never produces any byte blobs for decimal
216 2003-07-10 Martin Baulig <martin@ximian.com>
218 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
219 structs; fixes #32068.
220 (Block.AddChildVariableNames): Fixed #44302.
222 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
224 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
226 2003-07-07 Miguel de Icaza <miguel@ximian.com>
228 * attribute.cs: And this test is onger needed.
230 2003-07-08 Martin Baulig <martin@ximian.com>
232 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
233 inaccessible types. Fixes #36313.
235 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
237 * namespace.cs (NamespaceEntry): Create implicit entries for all
238 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
239 implicit entries for N1.N2 and N1.
241 2003-07-08 Martin Baulig <martin@ximian.com>
243 Rewrote the handling of namespaces to fix a lot of the issues
244 wrt. `using' aliases etc.
246 * namespace.cs (Namespace): Splitted this class into a
247 per-assembly `Namespace' and a per-file `NamespaceEntry'.
249 * typemanager.cs (TypeManager.IsNamespace): Removed.
250 (TypeManager.ComputeNamespaces): Only compute namespaces from
251 loaded assemblies here, not the namespaces from the assembly we're
254 2003-07-08 Martin Baulig <martin@ximian.com>
256 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
258 2003-07-07 Miguel de Icaza <miguel@ximian.com>
260 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
263 I thought about the memory savings here, but LookupTypeReflection
264 is used under already very constrained scenarios. Compiling
265 corlib or mcs only exposes one hit, so it would not really reduce
266 any memory consumption.
268 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
270 * typemanager.cs: fixes bug #45889 by only adding public types from
271 other assemblies to the list of known types.
273 2003-07-07 Miguel de Icaza <miguel@ximian.com>
275 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
276 on the type we resolved.
278 2003-07-05 Martin Baulig <martin@ximian.com>
280 * pending.cs (PendingImplementation.ParentImplements): Don't
281 create the proxy if the parent is abstract.
283 * class.cs (TypeContainer.DefineIndexers): Process explicit
284 interface implementations first. Fixes #37714.
286 2003-07-04 Miguel de Icaza <miguel@ximian.com>
288 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
289 defined recursively; but since we modify the input parameters
290 (left is set to `this' temporarily), we reset this value if the
291 left_is_explicit is false, which gives the original semantics to
294 * literal.cs (NullPointer): new class used to represent a null
295 literal in a pointer context.
297 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
298 type is a pointer, use a NullPointer object instead of a
299 NullLiteral. Closes 43687
301 (ExplicitConversion): Convert pointer values using
302 the conv opcode to the proper type.
304 * ecore.cs (New): change ValueTypeVariable property into a method,
305 that returns whether the valuetype is suitable for being used.
307 * expression.cs (Binary.DoNumericPromotions): Only return if we
308 the int constant was a valid uint, and we can return both left and
309 right as uints. If not, we continue processing, to trigger the
310 type conversion. This fixes 39018.
312 * statement.cs (Block.EmitMeta): During constant resolution, set
313 the CurrentBlock property on the emitcontext, so that we resolve
316 2003-07-02 Martin Baulig <martin@ximian.com>
318 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
319 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
321 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
322 than emitting it here.
324 * statement.cs: Fixed some more flow analysis bugs.
326 2003-07-02 Martin Baulig <martin@ximian.com>
328 * class.cs (MethodData.Define): When implementing interface
329 methods, set Final unless we're Virtual.
331 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
332 check work for interface methods.
334 2003-07-01 Martin Baulig <martin@ximian.com>
336 * ecore.cs (EmitContext.This): Replaced this property with a
337 GetThis() method which takes a Location argument. This ensures
338 that we get the correct error location for a CS0188.
340 2003-07-01 Miguel de Icaza <miguel@ximian.com>
342 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
343 ImplicitStandardConversion.
345 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
347 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
349 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
352 2003-06-30 Miguel de Icaza <miguel@ximian.com>
354 * class.cs (Constructor.Define): Turn off initlocals for unsafe
357 (MethodData.Define): Turn off initlocals for unsafe methods.
359 2003-06-29 Miguel de Icaza <miguel@ximian.com>
361 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
362 complete; Fixes #37521.
364 * delegate.cs: Use Modifiers.TypeAttr to compute the
365 TypeAttributes, instead of rolling our own. This makes the flags
366 correct for the delegates.
368 2003-06-28 Miguel de Icaza <miguel@ximian.com>
370 * class.cs (Constructor.Define): Set the private flag for static
371 constructors as well.
373 * cs-parser.jay (statement_expression): Set the return value to
374 null, to avoid a crash when we catch an error.
376 2003-06-24 Miguel de Icaza <miguel@ximian.com>
378 * cs-parser.jay: Applied patch from Jackson that adds support for
379 extern and unsafe modifiers to destructor declarations.
381 * expression.cs: Report error 21 if the user is trying to index a
384 * driver.cs: Add an error message, suggested by the bug report.
386 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
387 if we do not have a ": this ()" constructor initializer. Fixes 45149
389 2003-06-14 Miguel de Icaza <miguel@ximian.com>
391 * namespace.cs: Add some information to reduce FAQs.
393 2003-06-13 Miguel de Icaza <miguel@ximian.com>
395 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
396 underlying enumeration types. Fixes #43915.
398 * expression.cs: Treat ushort/short as legal values to be used in
401 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
403 * delegate.cs: transfer custom attributes for paramenters from
404 the delegate declaration to Invoke and BeginInvoke.
406 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
408 * attribute.cs: handle custom marshalers and emit marshal info
411 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
413 * makefile.gnu: Added anonymous.cs to the compiler sources.
415 2003-05-28 Miguel de Icaza <miguel@ximian.com>
417 * iterators.cs: Change the name of the proxy class to include two
420 * cs-parser.jay: Update grammar to include anonymous methods.
422 * anonymous.cs: new file.
424 2003-05-27 Miguel de Icaza <miguel@ximian.com>
426 * class.cs (Field.Define): Add missing test for pointers and
429 2003-05-27 Ravi Pratap <ravi@ximian.com>
431 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
432 we use the stobj opcode.
434 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
435 since it wasn't the correct fix.
437 It still is puzzling that we are required to use stobj for IntPtr
438 which seems to be a ValueType.
440 2003-05-26 Miguel de Icaza <miguel@ximian.com>
442 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
443 during regular simple name resolution. Now, the trick is that
444 instead of returning for processing the simplename, we do a
445 TypeManager.LookupType (ie, a rooted lookup as opposed to a
446 contextual lookup type). If a match is found, return that, if
447 not, return for further composition.
449 This fixes long-standing 30485.
451 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
452 using the address to initialize an object, do an Stobj instead of
453 using the regular Stelem.
455 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
456 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
457 Because if we are a BaseIndexerAccess that value will be true.
460 * statement.cs (GotoCase.Resolve): Return after reporting an
461 error, do not attempt to continue.
463 * expression.cs (PointerArithmetic.Emit): If our operand is a
464 long, convert our constants to match the operand before
465 multiplying. Convert to I type before adding. Fixes 43670.
467 2003-05-14 Ravi Pratap <ravi@ximian.com>
469 * enum.cs (ImplicitConversionExists) : Rename to
470 ImplicitEnumConversionExists to remove ambiguity.
472 * ecore.cs (NullCast): New type of cast expression class which
473 basically is very similar to EmptyCast with the difference being
474 it still is a constant since it is used only to cast a null to
478 * convert.cs (ImplicitReferenceConversion): When casting a null
479 literal, we return a NullCast.
481 * literal.cs (NullLiteralTyped): Remove - I don't see why this
482 should be around anymore.
484 The renaming (reported was slightly wrong). Corrections:
486 ConvertImplicitStandard -> ImplicitConversionStandard
487 ConvertExplicitStandard -> ExplicitConversionStandard
489 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
490 before passing them in !
492 * convert.cs (ImplicitConversionStandard): When comparing for
493 equal expr and target types, ensure that expr is not a
496 In general, we must not be checking (expr_type ==
497 target_type) in the top level conversion methods
498 (ImplicitConversion, ExplicitConversion etc). This checking is
499 done in the methods that they delegate to.
501 2003-05-20 Miguel de Icaza <miguel@ximian.com>
503 * convert.cs: Move Error_CannotConvertType,
504 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
505 ImplicitNumericConversion, ImplicitConversionExists,
506 ImplicitUserConversionExists, StandardConversionExists,
507 FindMostEncompassedType, FindMostSpecificSource,
508 FindMostSpecificTarget, ImplicitUserConversion,
509 ExplicitUserConversion, GetConversionOperators,
510 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
511 TryImplicitIntConversion, Error_CannotConvertImplicit,
512 ConvertImplicitRequired, ConvertNumericExplicit,
513 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
514 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
517 Perform the following renames:
519 StandardConversionExists -> ImplicitStandardConversionExists
520 ConvertImplicit -> ImplicitConversion
521 ConvertImplicitStandard -> ImplicitStandardConversion
522 TryImplicitIntConversion -> ImplicitIntConversion
523 ConvertImplicitRequired -> ImplicitConversionRequired
524 ConvertNumericExplicit -> ExplicitNumericConversion
525 ConvertReferenceExplicit -> ExplicitReferenceConversion
526 ConvertExplicit -> ExplicitConversion
527 ConvertExplicitStandard -> ExplicitStandardConversion
529 2003-05-19 Martin Baulig <martin@ximian.com>
531 * statement.cs (TypeInfo.StructInfo): Made this type protected.
532 (TypeInfo): Added support for structs having structs as fields.
534 * ecore.cs (FieldExpr): Implement IVariable.
535 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
536 VariableInfo for the field.
538 2003-05-18 Martin Baulig <martin@ximian.com>
540 * expression.cs (This.DoResolve): Report a CS0027 if we're
541 emitting a field initializer.
543 2003-05-18 Martin Baulig <martin@ximian.com>
545 * expression.cs (This.ResolveBase): New public function.
546 (This.DoResolve): Check for CS0188.
548 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
551 * ecore.cs (MethodGroupExpr.DoResolve): Set the
552 `instance_expression' to null if we don't have any non-static
555 2003-05-18 Martin Baulig <martin@ximian.com>
557 Reworked the way how local variables and parameters are handled by
558 the flow analysis code.
560 * statement.cs (TypeInfo, VariableMap): New public classes.
561 (VariableInfo): New public class. This is now responsible for
562 checking whether a variable has been assigned. It is used for
563 parameters and local variables.
564 (Block.EmitMeta): Take the InternalParameters as argument; compute
565 the layout of the flow vectors here.
566 (Block.LocalMap, Block.ParameterMap): New public properties.
567 (FlowBranching): The .ctor doesn't get the InternalParameters
568 anymore since Block.EmitMeta() now computes the layout of the flow
570 (MyStructInfo): This class is now known as `StructInfo' and nested
571 in `TypeInfo'; we don't access this directly anymore.
573 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
574 property and removed IsAssigned(), IsFieldAssigned(),
575 SetAssigned() and SetFieldAssigned(); we now call them on the
576 VariableInfo so we don't need to duplicate this code everywhere.
578 * expression.cs (ParameterReference): Added `Block block' argument
580 (LocalVariableReference, ParameterReference, This): The new
581 VariableInfo class is now responsible for all the definite
584 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
585 IsParameterAssigned, SetParameterAssigned): Removed.
587 2003-05-18 Martin Baulig <martin@ximian.com>
589 * typemanager.cs (InitCoreTypes): Try calling
590 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
591 the 3-args-version. Corlib now also needs our `void_type'.
592 (GetMethod): Added overloaded version which takes an optional
593 `bool report_errors' to allow lookups of optional methods.
595 2003-05-12 Martin Baulig <martin@ximian.com>
597 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
598 only used for locals and not for parameters.
600 2003-05-12 Miguel de Icaza <miguel@ximian.com>
602 * support.cs (InternalParameters.ParameterType): Return the
603 ExternalType of the parameter.
605 * parameter.cs (Parameter.ExternalType): drop the two arguments,
608 2003-05-11 Miguel de Icaza <miguel@ximian.com>
610 * class.cs (MethodData.Define): Do not set the `newslot' on
611 interface members, if they are also flagged as "override".
613 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
614 better code for ++i and i++. This only works for static fields
617 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
618 want to pull the DeclSpace out of the builder_to_declspace instead
619 of the TypeBuilder (like in TypeContainer.FindMembers).
621 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
622 instead of LookupTypeContainer. Fixes the crash on .NET for
623 looking up interface members.
625 * const.cs: Create our own emit context during the Definition
626 stage, so that constants are evaluated in the proper context, when
627 a recursive definition happens.
629 2003-05-11 Martin Baulig <martin@ximian.com>
631 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
632 new block for a switch section.
633 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
634 the adding/lookup in the switch block. Fixes #39828.
636 2003-05-09 Miguel de Icaza <miguel@ximian.com>
638 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
639 functionality: I needed to convert the data after I had performed
640 the add/sub operation into the operands type size.
642 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
643 pass the type for the box operation, otherwise the resulting
644 object would have been of type object.
646 (BoxedCast): Add constructor to specify the type to box as.
648 2003-05-07 Miguel de Icaza <miguel@ximian.com>
650 * iterators.cs: I was reusing the `count' variable inadvertently,
651 take steps to not allow this to happen.
653 2003-05-06 Miguel de Icaza <miguel@ximian.com>
655 * attribute.cs (Attribute.Resolve): Params attributes are encoded
656 by creating an array at the point where the params starts and
657 putting all those arguments there, then adjusting the size of the
660 2003-05-05 Miguel de Icaza <miguel@ximian.com>
662 * expression.cs (New.AddressOf): Implement interface
663 IMemoryLocation. This is used when the `new' operator is used in
664 the context of an invocation to a method on a value type.
666 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
669 * namespace.cs: Also check the using aliases here.
671 * driver.cs: Move the test for using validity after the types have
672 been entered, so we do a single pass that also includes the using
675 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
676 in the regular case. CreateSiblingForFinally is doing extra
679 * attribute.cs (GetAttributeArgumentExpression): Store the result
680 on an out value, and use the return value to indicate failure
681 instead of using null (which is a valid return for Constant.GetValue).
683 * statement.cs: Perform the analysis flow for the increment
684 portion after the statement, because this will be the real flow of
685 execution. Fixes #42385
687 * codegen.cs (EmitContext.EmitArgument,
688 EmitContext.EmitStoreArgument): New helper functions when the
689 RemapToProxy flag is set.
691 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
694 Add support for remapping parameters.
696 * iterators.cs: Propagate parameter values; Store parameter
697 values in the proxy classes.
699 2003-05-04 Miguel de Icaza <miguel@ximian.com>
701 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
702 need a proxy reference; I do not know what I was thinking
704 * cs-parser.jay (constructor_initializer): catch another error,
705 and display nice message.
707 (field_declaration): catch void field declaration
708 to flag a better error.
710 * class.cs (MemberBase.CheckBase): Report an error instead of a
711 warning if a new protected member is declared in a struct.
712 (Field.Define): catch the error of readonly/volatile.
714 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
716 (FieldExpr.AddressOf): ditto. Catch error where the address of a
717 volatile variable is taken
719 2003-05-02 Miguel de Icaza <miguel@ximian.com>
721 * statement.cs (Fixed.Resolve): Report an error if we are not in
724 2003-05-01 Miguel de Icaza <miguel@ximian.com>
726 * typemanager.cs: reuse the code that handles type clashes for
727 delegates and enumerations.
729 * class.cs (Report28): Always report.
731 * expression.cs (EncodeAsAttribute): Allow nulls here.
733 2003-04-28 Miguel de Icaza <miguel@ximian.com>
735 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
736 the functionality for testing whether an expression is valid for
737 an attribute here. Also handle the case of arrays of elements
740 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
741 encoding a linear array into an array of objects that are suitable
742 to be passed to an CustomAttributeBuilder.
744 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
746 * ecore.cs: (FieldExpr): Handle field remapping here.
748 * iteratators.cs: Pass the instance variable (if the method is an
749 instance method) to the constructors, so we can access the field
750 variables on the class.
752 TODO: Test this with structs. I think the THIS variable on
753 structs might have to be a pointer, and not a refenrece
755 2003-04-27 Miguel de Icaza <miguel@ximian.com>
757 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
758 local variables to fields in a proxy class.
760 * iterators.cs (PopulateProxy): Rename our internal fields to
762 Create a <THIS> field if we are an instance method, so we can
763 reference our parent container variables.
764 (MapVariable): Called back from the EmitContext code to enter a
765 new variable to field mapping into the proxy class (we just create
769 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
770 for using the remapped locals to fields.
772 I placed the code here, because that gives the same semantics to
773 local variables, and only changes the Emit code.
775 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
776 statements inside iterators.
777 (VariableInfo): Add a FieldBuilder for the cases when we are
778 remapping local variables to fields in a proxy class
780 * ecore.cs (SimpleNameResolve): Avoid testing two times for
781 current_block != null.
783 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
784 not cope with strings, as it has been moved to the
785 TableSwitchEmit. Fixed bug in switch generation.
787 * expression.cs (New.DoResolve): Provide more context for the user
788 when reporting an error.
790 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
793 * expression.cs (MemberAccess.DoResolve): When we get a type back,
794 check the permissions for it. Note than in a type-resolution
795 context the check was already present in DeclSpace.ResolveType,
796 but was missing from the MemberAccess.
798 (ArrayCreation.CheckIndices): warn if the user has
799 more nested levels of expressions, but there are no more
800 dimensions specified. Avoids crash on bug 41906.
802 2003-04-26 Miguel de Icaza <miguel@ximian.com>
804 * statement.cs (Block): replace Implicit bool, for a generic
806 New flag: `Unchecked'. This is used during the EmitMeta phase
807 (which is out-of-line with the regular Resolve/Emit process for a
808 statement, as this is done ahead of time, but still gets a chance
809 to call constant resolve).
811 (Block.Flags): new enum for adding a new flag.
813 (Block.EmitMeta): track the state of unchecked.
815 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
816 to enable constant resolution to work there as well.
818 2003-04-22 Miguel de Icaza <miguel@ximian.com>
820 * typemanager.cs (ienumerable_type): Also look up
821 System.Collections.IEnumerable.
823 2003-04-21 Miguel de Icaza <miguel@ximian.com>
825 TODO: Test more than one conditional per method.
827 * class.cs (Indexer.Define): Report the location where the user is
828 referencing the unsupported feature.
830 (MethodData): Overload the use of `conditionals' to
831 minimize the creation of needless ArrayLists. This saves roughly
834 (Method): Implement the new IIteratorContainer interface.
835 (Method.SetYields): Implement the method by setting the ModFlags
836 to contain METHOD_YIELDS.
838 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
839 which just got set to null.
841 * iterators.cs: New file.
843 (Yield, YieldBreak): New statements.
845 * statement.cs (Return.Resolve): Flag an error if we are used in
848 * codegen.cs (InIterator): New flag set if the code is being
849 compiled in an iterator method.
851 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
852 internal modifier, and we just use it to avoid adding extra
853 fields, as this is seldom used.
855 * cs-parser.jay: Add yield_statement (yield and yield break).
857 * driver.cs: New flag -v2 to turn on version 2 features.
859 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
860 hashtable when v2 is enabled.
862 2003-04-20 Miguel de Icaza <miguel@ximian.com>
864 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
865 there is already a namespace defined with this name.
867 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
868 people upgraded their corlibs.
870 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
871 always use fully qualified types, no need to use the compiler
874 (TypeManager.IsNamespace): Use binarysearch.
876 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
877 AddDelegate): I did not quite use the new IsValid API properly: I
878 have to pass the short-name and the fullname. I was passing only
879 the basename instead of the fullname sometimes.
881 (TypeContainer.DefineType): call NamespaceClash.
883 * interface.cs (Interface.DefineType): use NamespaceClash before
886 * delegate.cs (Delegate.DefineType): use NamespaceClash before
889 * enum.cs: (Enum.DefineType): use NamespaceClash before
892 * typemanager.cs (: 3-line patch that gives us some tasty 11%
893 speed increase. First, use the negative_hits cache when we get a
894 negative. Second, add the type with its full original name
895 instead of the new . and + encoded name (reflection uses + to
896 separate type from a nested type). Use LookupTypeReflection
897 directly which bypasses the type->name hashtable (that we already
898 know does not contain the type.
900 * decl.cs (DeclSpace.ResolveTypeExpr): track the
901 location/container type.
903 * driver.cs: When passing utf8, use directly the UTF8Encoding.
905 2003-04-19 Miguel de Icaza <miguel@ximian.com>
907 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
909 * delegate.cs (NewDelegate.Resolve): Test whether an instance
910 method is being referenced in the method group from a static
911 context, and report error 120 if so.
913 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
916 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
917 is created, we create the A namespace).
919 * cs-parser.jay: A namespace also introduces a DeclarationFound.
922 2003-04-18 Miguel de Icaza <miguel@ximian.com>
924 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
925 invocation to ModuleBuilder.GetType with the same values will
926 return a new type instance, so we need to cache its return
929 * expression.cs (Binary.ResolveOperator): Only allow the compare
930 operators on enums if they are of the same type.
932 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
933 types of ValueType on their own case. Before we were giving them
934 the same treatment as objects.
936 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
937 fullname. Short name is used to compare against container name.
938 Fullname is used to check against defined namespace names.
940 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
941 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
943 (Method.CheckBase): Call parent.
944 (MemberBase.CheckBase): Check for protected members on sealed
946 (PropertyBase.CheckBase): Call parent.
947 (Field.Define): Call parent.
949 * report.cs: Negative error codes are now mapped to 8000 - code,
950 so that the display is render more nicely.
952 * typemanager.cs: Do not use try/catch, instead report a regular
955 (GetPointerType, GetReferenceType): These methods provide
956 mechanisms to obtain the T* and T& from a T. We had the code
957 previously scattered around the code base, and it also used
958 TypeManager.LookupType that would go through plenty of caches.
959 This one goes directly to the type source.
961 In some places we did the Type.GetType followed by
962 ModuleBuilder.GetType, but not in others, so this unifies the
965 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
966 statements now that we have namespace information.
968 * typemanager.cs (IsNamespace): New method, returns whether the
969 string presented is a namespace or not.
971 (ComputeNamespaces): New public entry point, computes the list of
972 available namespaces, using the GetNamespaces API call in Mono, or
973 the slower version in MS.NET.
975 Now before we start the semantic analysis phase, we have a
976 complete list of namespaces including everything that the user has
979 Deleted old code to cache namespaces in .nsc files.
981 2003-04-17 Miguel de Icaza <miguel@ximian.com>
983 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
984 class/struct location definition Location for the implicit
985 constructor location.
987 (Operator.Define): Use the location of the operator for the
988 implicit Method definition.
990 (Constructor.Emit): use the constructor location for the implicit
991 base initializer constructor.
993 * ecore.cs: Remove ITypeExpression. This interface is now gone,
994 and the Expression class now contains two new methods:
996 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
997 isolate type lookup from the rest of the resolution process.
999 Since we use Expressions to hold type definitions due to the way
1000 we parse the input we have historically overloaded Resolve to
1001 perform the Type lookups if a special flag is passed. Now this is
1002 eliminated and two methods take their place.
1004 The differences in the two methods between xStep and xTerminal is
1005 that xStep is involved in our current lookup system that uses
1006 SimpleNames to compose a name, while xTerminal is used just to
1007 catch the case where the simplename lookup failed.
1009 2003-04-16 Miguel de Icaza <miguel@ximian.com>
1011 * expression.cs (ResolveMemberAccess): Remove redundant code.
1012 TypeExpr expressions are always born fully resolved.
1014 * interface.cs (PopulateMethod): Do not lookup the types twice.
1015 We were doing it once during SemanticAnalysis and once during
1018 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
1019 in local variable type definitions, were being returned as a
1020 SimpleName (we decomposed everything into a string), that is
1021 because primary_expression was being used instead of a type in the
1022 grammar (reduce/reduce conflicts).
1024 The part that was wrong is that we converted the expression into a
1025 string (an oversimplification in one hand, compounded with primary
1026 expressions doing string concatenation).
1032 Would return "A.B.C[]" as a SimpleName. This stopped things like
1033 using clauses from working on this particular context. And a type
1034 was being matched directly against "A.B.C[]".
1036 We now use the correct approach, and allow for ComposedCast to be
1037 part of the unary expression. So the "A.B.C []" become a composed
1038 cast of "A.B.C" (as a nested group of MemberAccess with a
1039 SimpleName at the end) plus the rank composition "[]".
1043 2003-04-10 Miguel de Icaza <miguel@ximian.com>
1045 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
1046 for the access level checking.
1048 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
1049 `TypeContainer container', because I kept getting confused when I
1050 was debugging this code.
1052 * expression.cs (Indexers): Instead of tracking getters/setters,
1053 we now track them in parallel. We create one arraylist less, but
1054 most importantly it is possible now for the LValue code to find a
1055 matching get for a set.
1057 (IndexerAccess.DoResolveLValue): Update the code.
1058 GetIndexersForType has been modified already to extract all the
1059 indexers from a type. The code assumed it did not.
1061 Also make the code set the correct return type for the indexer.
1062 This was fixed a long time ago for properties, but was missing for
1063 indexers. It used to be void_type.
1065 (Binary.Emit): Test first for doubles instead of
1066 floats, as they are more common.
1068 (Binary.EmitBranchable): Use the .un version of the branch opcodes
1069 when dealing with floats and the <=, >= operators. This fixes bug
1072 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
1073 to load the array value by emitting a load on the foreach variable
1074 type. This was incorrect.
1076 We now emit the code to load an element using the the array
1077 variable type, and then we emit the conversion operator.
1081 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
1083 * attribute.cs: Avoid allocation of ArrayLists in the common case.
1085 2003-04-09 Miguel de Icaza <miguel@ximian.com>
1087 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
1088 test for protection before we test for signatures.
1090 (MethodSignature.ToString): implement.
1092 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
1093 to the case where we reduced into a LongConstant.
1095 * decl.cs (CheckAccessLevel): If the type is an array, we can not
1096 depend on whether the information is acurrate, because the
1097 Microsoft runtime will always claim that the array type is public,
1098 regardless of the real state.
1100 If the type is a pointer, another problem happens: the type is
1101 reported as non-public in Microsoft.
1103 In both cases we have to call CheckAccessLevel recursively with
1104 the underlying type as the argument to be tested.
1106 2003-04-08 Miguel de Icaza <miguel@ximian.com>
1108 * assign.cs (Assign.Emit): If we are dealing with a compound
1109 assignment expression, we should use the code path that stores the
1110 intermediate result in a temporary value. This fixes #40903.
1112 *expression.cs (Indirection.ToString): Provide ToString method for
1115 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
1117 * class.cs: Null out fields holding references to Block objects so
1118 they can be garbage collected.
1120 * expression.cs (OverloadResolve): Remove unused local.
1122 2003-04-07 Martin Baulig <martin@ximian.com>
1124 * codegen.cs (EmitContext.CurrentFile): New public field.
1125 (EmitContext.Mark): Use the CurrentFile to check whether the
1126 location is in the correct file.
1127 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
1129 2003-04-07 Martin Baulig <martin@ximian.com>
1131 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
1133 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
1134 location. [FIXME: The location argument which gets passed to this
1135 method is sometimes wrong!]
1137 2003-04-07 Nick Drochak <ndrochak@gol.com>
1139 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
1141 2003-04-07 Miguel de Icaza <miguel@ximian.com>
1143 * expression.cs (Indirection.EmitAssign): We were using the
1144 temporary, but returning immediately instead of continuing the
1147 2003-04-06 Martin Baulig <martin@ximian.com>
1149 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
1150 if it's a nested child, but also deriving from the outer class.
1153 * typemanager.cs (IsNestedChildOf): Make this work if it's a
1154 nested child, but also deriving from the outer class. See
1156 (FilterWithClosure): We may access private members of the outer
1157 class if we're a nested child and deriving from the outer class.
1158 (RealMemberLookup): Only set `closure_private_ok' if the
1159 `original_bf' contained BindingFlags.NonPublic.
1161 2003-04-05 Martin Baulig <martin@ximian.com>
1163 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #40670.
1165 2003-04-02 Miguel de Icaza <miguel@ximian.com>
1167 * class.cs (Event.Define): Do not allow abstract events to have
1170 2003-04-01 Miguel de Icaza <miguel@ximian.com>
1172 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
1173 block in event declarations.
1175 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
1176 value type, get its address.
1178 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
1179 leaving a class on the stack instead of a boolean value (int
1180 0/1). Change the code so we compare against null, and then the
1181 result against zero.
1183 * class.cs (TypeContainer.GetClassBases): We were checking for the
1184 parent class being sealed too late.
1186 * expression.cs (Binary.Emit): For <= and >= when dealing with
1187 floating point values, use cgt.un and clt.un instead of cgt and
1190 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
1192 * statement.cs: Apply the same optimization as MS: skip the
1193 GetEnumerator returning an IEnumerator, and use the one returning a
1194 CharEnumerator instead. This allows us to avoid the try-finally block
1197 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
1199 * cs-parser.jay: Attributes cannot be applied to
1200 namespaces. Fixes #40473
1202 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
1205 (Add*): check if the name is valid using the full name for constants,
1206 fields, properties and events.
1208 2003-03-28 Miguel de Icaza <miguel@ximian.com>
1210 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
1211 char constants to be part of the enumeration.
1213 * expression.cs (Conditional.DoResolve): Add support for operator
1214 true. Implements the missing functionality from 14.12
1216 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
1217 operator true/false as required by the spec.
1219 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
1220 implicit conversion to boolean.
1222 * statement.cs (Statement.ResolveBoolean): A boolean expression is
1223 also one where the type implements `operator true'.
1225 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
1226 get an expression that will invoke operator true based on an
1229 (GetConversionOperators): Removed the hack that called op_True
1232 (Expression.ResolveBoolean): Move this from Statement.
1234 2003-03-17 Miguel de Icaza <miguel@ximian.com>
1236 * ecore.cs (FieldExpr): do not allow initialization of initonly
1237 fields on derived classes
1239 2003-03-13 Martin Baulig <martin@ximian.com>
1241 * statement.cs (Block.Emit): Call ig.BeginScope() and
1242 ig.EndScope() when compiling with debugging info; call
1243 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
1245 2003-03-08 Miguel de Icaza <miguel@ximian.com>
1247 * expression.cs (Indexers): Do not construct immediately, allow
1248 for new members to be appended as we go. Fixes 38143
1250 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
1252 * expression.cs: save/restore context when resolving an unchecked
1255 2003-03-05 Miguel de Icaza <miguel@ximian.com>
1257 * cfold.cs: Catch division by zero in modulus operator during
1260 2003-03-03 Miguel de Icaza <miguel@ximian.com>
1262 * interface.cs (Interface.DefineMembers): Avoid defining members
1265 2003-02-27 Miguel de Icaza <miguel@ximian.com>
1267 * driver.cs: handle the +/- options for -noconfig
1269 * statement.cs (Unckeched.Resolve): Also track the state of
1270 unchecked in the Resolve phase.
1272 2003-02-27 Martin Baulig <martin@ximian.com>
1274 * ecore.cs (Expression.MemberLookup): Don't create a
1275 MethodGroupExpr for something which is not a method. Fixes #38291.
1277 2003-02-25 Miguel de Icaza <miguel@ximian.com>
1279 * class.cs (MemberBase.CheckParameters): Also check that the type
1280 is unmanaged if it is a pointer.
1282 * expression.cs (SizeOf.Resolve): Add location information.
1284 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
1285 a managed type is declared.
1287 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
1288 parameter modifiers as well. Fixes bug 38606
1290 * class.cs: Very sad. Am backing out the speed up changes
1291 introduced by the ArrayList -> Array in the TypeContainer, as they
1292 were not actually that much faster, and introduced a bug (no error
1293 reports on duplicated methods).
1295 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
1296 source first, this will guarantee that we have a valid expression
1297 before calling in lower levels functions that will require a
1298 resolved object. Then use this original_source in the
1299 target.ResolveLValue instead of the original source that was
1302 Another change. Use target.Resolve instead of LValueResolve.
1303 Although we are resolving for LValues, we will let the Assign code
1304 take care of that (it will be called again from Resolve). This
1305 basically allows code like this:
1307 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
1308 class Y { void A (X x) { x [0] += o; }
1310 The problem was that the indexer was trying to resolve for
1311 set_Item (idx, object o) and never finding one. The real set_Item
1312 was set_Item (idx, X). By delaying the process we get the right
1317 2003-02-23 Martin Baulig <martin@ximian.com>
1319 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
1320 while calling DoEmit ().
1322 * codegen.cs (EmitContext.Mark): Don't mark locations in other
1323 source files; if you use the #line directive inside a method, the
1324 compiler stops emitting line numbers for the debugger until it
1325 reaches the end of the method or another #line directive which
1326 restores the original file.
1328 2003-02-23 Martin Baulig <martin@ximian.com>
1330 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
1332 2003-02-23 Martin Baulig <martin@ximian.com>
1334 * statement.cs (Block.AddChildVariableNames): We need to call this
1335 recursively, not just for our immediate children.
1337 2003-02-23 Martin Baulig <martin@ximian.com>
1339 * class.cs (Event.Define): Always make the field private, like csc does.
1341 * typemanager.cs (TypeManager.RealMemberLookup): Make events
1342 actually work, fixes bug #37521.
1344 2003-02-23 Miguel de Icaza <miguel@ximian.com>
1346 * delegate.cs: When creating the various temporary "Parameters"
1347 classes, make sure that we call the ComputeAndDefineParameterTypes
1348 on those new parameters (just like we do with the formal ones), to
1349 allow them to be resolved in the context of the DeclSpace.
1351 This fixes the bug that Dick observed in Bugzilla #38530.
1353 2003-02-22 Miguel de Icaza <miguel@ximian.com>
1355 * expression.cs (ResolveMemberAccess): When resolving a constant,
1356 do not attempt to pull a constant if the value was not able to
1357 generate a valid constant.
1359 * const.cs (LookupConstantValue): Do not report more errors than required.
1361 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
1363 * expression.cs: fixes bug #38328.
1365 2003-02-18 Miguel de Icaza <miguel@ximian.com>
1367 * class.cs: Changed all the various members that can be part of a
1368 class from being an ArrayList to be an Array of the right type.
1369 During the DefineType type_list, interface_list, delegate_list and
1370 enum_list are turned into types, interfaces, delegates and enums
1373 And during the member population, indexer_list, event_list,
1374 constant_list, field_list, instance_constructor_list, method_list,
1375 operator_list and property_list are turned into their real arrays.
1377 Although we could probably perform this operation earlier, for
1378 good error reporting we need to keep the lists and remove the
1379 lists for longer than required.
1381 This optimization was triggered by Paolo profiling the compiler
1382 speed on the output of `gen-sample-program.pl' perl script.
1384 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
1385 not crash in methods like MemberLookupFailed that use this field.
1387 This problem arises when the compiler fails to resolve a type
1388 during interface type definition for example.
1390 2003-02-18 Miguel de Icaza <miguel@ximian.com>
1392 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
1393 inherit from System.Object, so we have to stop at null, not only
1394 when reaching System.Object.
1396 2003-02-17 Miguel de Icaza <miguel@ximian.com>
1398 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
1399 DeclaredOnly because the parent indexer might have had a different
1400 name, but did not loop until the top of the hierarchy was reached.
1402 The problem this one fixes is 35492: when a class implemented an
1403 indexer from an interface, we were getting the interface method
1404 (which was abstract) and we were flagging an error (can not invoke
1407 This also keeps bug 33089 functioning, and test-148 functioning.
1409 * typemanager.cs (IsSpecialMethod): The correct way of figuring
1410 out if a method is special is to see if it is declared in a
1411 property or event, or whether it is one of the predefined operator
1412 names. This should fix correctly #36804.
1414 2003-02-15 Miguel de Icaza <miguel@ximian.com>
1416 The goal here is to remove the dependency on EmptyCast.Peel ().
1417 Killing it completely.
1419 The problem is that currently in a number of places where
1420 constants are expected, we have to "probe" for an EmptyCast, and
1421 Peel, which is not the correct thing to do, as this will be
1422 repetitive and will likely lead to errors.
1424 The idea is to remove any EmptyCasts that are used in casts that
1425 can be reduced to constants, so we only have to cope with
1428 This bug hunt was triggered by Bug 37363 and the desire to remove
1429 the duplicate pattern where we were "peeling" emptycasts to check
1430 whether they were constants. Now constants will always be
1433 * ecore.cs: Use an enumconstant here instead of wrapping with
1436 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
1437 throwing me off. By handling this we can get rid of a few hacks.
1439 * statement.cs (Switch): Removed Peel() code.
1441 2003-02-14 Miguel de Icaza <miguel@ximian.com>
1443 * class.cs: Location information for error 508
1445 * expression.cs (New.DoResolve): Add a guard against double
1446 resolution of an expression.
1448 The New DoResolve might be called twice when initializing field
1449 expressions (see EmitFieldInitializers, the call to
1450 GetInitializerExpression will perform a resolve on the expression,
1451 and later the assign will trigger another resolution
1453 This leads to bugs (#37014)
1455 * delegate.cs: The signature for EndInvoke should contain any ref
1456 or out parameters as well. We were not doing this in the past.
1458 * class.cs (Field.Define): Do not overwrite the type definition
1459 inside the `volatile' group. Turns out that volatile enumerations
1460 were changing the type here to perform a validity test, which
1463 2003-02-12 Miguel de Icaza <miguel@ximian.com>
1465 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
1466 and structs, we do not want to load the instance variable
1468 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
1469 enum_type has to be handled like an object reference (implicit
1470 conversions exists from this to object), but the regular IsClass
1471 and IsValueType tests will never return true for this one.
1473 Also we use TypeManager.IsValueType instead of type.IsValueType,
1474 just for consistency with the rest of the code (this is only
1475 needed if we ever use the construct exposed by test-180.cs inside
1476 corlib, which we dont today).
1478 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
1480 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
1483 2003-02-09 Martin Baulig <martin@ximian.com>
1485 * namespace.cs (Namespace..ctor): Added SourceFile argument.
1486 (Namespace.DefineNamespaces): New static public method; this is
1487 called when we're compiling with debugging to add all namespaces
1490 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
1491 pass it to the Namespace's .ctor.
1493 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
1494 and MethodBase arguments; pass the namespace ID to the symwriter;
1495 pass the MethodBase instead of the token to the symwriter.
1496 (SymbolWriter.DefineNamespace): New method to add a namespace to
1499 2003-02-09 Martin Baulig <martin@ximian.com>
1501 * symbolwriter.cs: New file. This is a wrapper around
1502 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
1503 methods here in near future.
1505 2003-02-09 Martin Baulig <martin@ximian.com>
1507 * codegen.cs (EmitContext.Mark): Just pass the arguments to
1508 ILGenerator.MarkSequencePoint() which are actually used by the
1511 2003-02-09 Martin Baulig <martin@ximian.com>
1513 * location.cs (SourceFile): New public sealed class. This
1514 contains the name and an index which is used in the location's token.
1515 (Location): Reserve an appropriate number of bits in the token for
1516 the source file instead of walking over that list, this gives us a
1517 really huge performance improvement when compiling with debugging.
1519 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
1520 `SourceFile' argument instead of a string.
1521 (Driver.ProcessFile): Add all the files via Location.AddFile(),
1522 but don't parse/tokenize here, we need to generate the list of all
1523 source files before we do that.
1524 (Driver.ProcessFiles): New static function. Parses/tokenizes all
1527 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
1528 instead of a string.
1530 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
1533 2003-02-09 Martin Baulig <martin@ximian.com>
1535 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
1536 filename on `#line default'.
1538 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
1540 * statement.cs: don't clear the pinned var when the fixed statement
1541 returns from the method (fixes bug#37752).
1543 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
1545 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
1548 2003-02-07 Martin Baulig <martin@ximian.com>
1550 * driver.cs: Removed the `--debug-args' command line argument.
1552 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
1553 automatically by the AsssemblyBuilder.
1554 (CodeGen.InitializeSymbolWriter): We don't need to call any
1555 initialization function on the symbol writer anymore. This method
1556 doesn't take any arguments.
1558 2003-02-03 Miguel de Icaza <miguel@ximian.com>
1560 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
1561 from referenced assemblies as well.
1563 2003-02-02 Martin Baulig <martin@ximian.com>
1565 * class.cs (MethodData.Emit): Generate debugging info for external methods.
1567 2003-02-02 Martin Baulig <martin@ximian.com>
1569 * class.cs (Constructor.Emit): Open the symbol writer before
1570 emitting the constructor initializer.
1571 (ConstructorInitializer.Emit): Call ec.Mark() to allow
1572 single-stepping through constructor initializers.
1574 2003-01-30 Miguel de Icaza <miguel@ximian.com>
1576 * class.cs: Handle error 549: do not allow virtual methods in
1579 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
1581 * decl.cs: Check access levels when resolving types
1583 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
1585 * statement.cs: Add parameters and locals set in catch blocks that might
1586 return to set vector
1588 2003-01-29 Miguel de Icaza <miguel@ximian.com>
1590 * class.cs (Operator): Set the SpecialName flags for operators.
1592 * expression.cs (Invocation.DoResolve): Only block calls to
1593 accessors and operators on SpecialName methods.
1595 (Cast.TryReduce): Handle conversions from char constants.
1598 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
1600 * statement.cs: small memory and time optimization in FlowBranching.
1602 2003-01-28 Pedro Mart <yoros@wanadoo.es>
1604 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
1605 problem that the last fix but in the other sid (Set).
1607 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
1608 access when there is no indexer in the hierarchy.
1610 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
1612 * class.cs: Combine some if statements.
1614 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
1616 * driver.cs: fixed bug #37187.
1618 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
1620 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
1621 any indexer, it's needed to build a list with all the indexers in the
1622 hierarchy (AllGetters), else we have problems. Fixes #35653.
1624 2003-01-23 Miguel de Icaza <miguel@ximian.com>
1626 * class.cs (MethodData.Define): It is wrong for an interface
1627 implementation to be static in both cases: explicit and implicit.
1628 We were only handling this in one case.
1630 Improve the if situation there to not have negations.
1632 * class.cs (Field.Define): Turns out that we do not need to check
1633 the unsafe bit on field definition, only on usage. Remove the test.
1635 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
1637 * driver.cs: use assembly.Location instead of Codebase (the latest
1638 patch made mcs fail when using MS assemblies).
1640 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
1642 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
1643 get the path to *corlib.dll.
1645 2003-01-21 Nick Drochak <ndrochak@gol.com>
1649 * typemanager.cs: Remove compiler warnings
1651 2003-01-20 Duncan Mak <duncan@ximian.com>
1653 * AssemblyInfo.cs: Bump the version number to 0.19.
1655 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
1657 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
1659 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
1661 * class.cs (Constructor::Emit): Emit debugging info for constructors.
1663 2003-01-17 Miguel de Icaza <miguel@ximian.com>
1665 * cs-parser.jay: Small fix: we were not comparing the constructor
1666 name correctly. Thanks to Zoltan for the initial pointer.
1668 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
1670 * cs-tokenizer.cs: Set file name when specified with #line
1672 2003-01-15 Miguel de Icaza <miguel@ximian.com>
1674 * cs-parser.jay: Only perform the constructor checks here if we
1675 are named like the class; This will help provider a better
1676 error. The constructor path is taken when a type definition is
1677 not found, but most likely the user forgot to add the type, so
1678 report that rather than the constructor error.
1680 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
1682 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
1685 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
1687 * cs-parser.jay: Add cleanup call.
1689 2003-01-13 Duncan Mak <duncan@ximian.com>
1691 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
1692 consistent with other methods.
1694 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
1696 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
1698 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
1700 * attribute.cs: only set GuidAttr to true when we have a
1703 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
1707 * typemanager.cs: fixes to allow mcs compile corlib with the new
1708 Type.IsSubclassOf fix.
1710 2003-01-08 Miguel de Icaza <miguel@ximian.com>
1712 * expression.cs (LocalVariableReference.DoResolve): Classify a
1713 constant as a value, not as a variable. Also, set the type for
1716 * cs-parser.jay (fixed_statement): take a type instead of a
1717 pointer_type, so we can produce a better error message later.
1719 * statement.cs (Fixed.Resolve): Flag types that are not pointers
1722 (For.DoEmit): Make inifinite loops have a
1723 non-conditional branch back.
1725 (Fixed.DoEmit): First populate the pinned variables, then emit the
1726 statement, then clear the variables. Before I was emitting the
1727 code once for each fixed piece.
1730 2003-01-08 Martin Baulig <martin@ximian.com>
1732 * statement.cs (FlowBranching.MergeChild): A break in a
1733 SWITCH_SECTION does not leave a loop. Fixes #36155.
1735 2003-01-08 Martin Baulig <martin@ximian.com>
1737 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
1738 lives in the same number space than `param_map'. Fixes #36154.
1740 2003-01-07 Miguel de Icaza <miguel@ximian.com>
1742 * cs-parser.jay (constructor_declaration): Set the
1743 Constructor.ModFlags before probing for it. This makes the
1744 compiler report 514, 515 and 132 (the code was there, but got
1747 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
1748 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
1749 (GotoCase.Resolve): Set `Returns' to ALWAYS.
1751 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
1753 * enum.cs: create the enum static fields using the enum type.
1755 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
1757 * class.cs: don't try to create the ParamBuilder for the return
1758 type if it's not needed (and handle it breaking for the ms runtime
1761 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
1763 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
1765 2002-12-29 Miguel de Icaza <miguel@ximian.com>
1767 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
1768 the command. This showed up while compiling the JANET source
1769 code, which used \r as its only newline separator.
1771 2002-12-28 Miguel de Icaza <miguel@ximian.com>
1773 * class.cs (Method.Define): If we are an operator (because it
1774 reuses our code), then set the SpecialName and HideBySig. #36128
1776 2002-12-22 Miguel de Icaza <miguel@ximian.com>
1778 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
1779 exception, report error 120 `object reference required'.
1781 * driver.cs: Add --pause option, used during to measure the size
1782 of the process as it goes with --timestamp.
1784 * expression.cs (Invocation.DoResolve): Do not allow methods with
1785 SpecialName to be invoked.
1787 2002-12-21 Miguel de Icaza <miguel@ximian.com>
1789 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
1790 number before adding it.
1792 2002-12-21 Ravi Pratap <ravi@ximian.com>
1794 * ecore.cs (StandardImplicitConversion): When in an unsafe
1795 context, we allow conversion between void * to any other pointer
1796 type. This fixes bug #35973.
1798 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
1800 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
1801 is not thrown when extensionless outputs are used
1803 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
1805 * rootcontext.cs: fixed compilation of corlib.
1807 2002-12-19 Miguel de Icaza <miguel@ximian.com>
1809 * attribute.cs (Attributes.Contains): Add new method.
1811 * class.cs (MethodCore.LabelParameters): if the parameter is an
1812 `out' parameter, check that no attribute `[In]' has been passed.
1814 * enum.cs: Handle the `value__' name in an enumeration.
1816 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
1818 * decl.cs: Added special case to allow overrides on "protected
1821 2002-12-18 Ravi Pratap <ravi@ximian.com>
1823 * attribute.cs (Attributes.AddAttributeSection): Rename to this
1824 since it makes much more sense.
1826 (Attributes.ctor): Don't require a Location parameter.
1828 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
1830 * attribute.cs (ApplyAttributes): Remove extra Location parameters
1831 since we already have that information per attribute.
1833 * everywhere : make appropriate changes.
1835 * class.cs (LabelParameters): Write the code which actually
1836 applies attributes to the return type. We can't do this on the MS
1837 .NET runtime so we flag a warning in the case an exception is
1840 2002-12-18 Miguel de Icaza <miguel@ximian.com>
1842 * const.cs: Handle implicit null conversions here too.
1844 2002-12-17 Ravi Pratap <ravi@ximian.com>
1846 * class.cs (MethodCore.LabelParameters): Remove the extra
1847 Type [] parameter since it is completely unnecessary. Instead
1848 pass in the method's attributes so that we can extract
1849 the "return" attribute.
1851 2002-12-17 Miguel de Icaza <miguel@ximian.com>
1853 * cs-parser.jay (parse): Use Report.Error to flag errors instead
1854 of ignoring it and letting the compile continue.
1856 * typemanager.cs (ChangeType): use an extra argument to return an
1857 error condition instead of throwing an exception.
1859 2002-12-15 Miguel de Icaza <miguel@ximian.com>
1861 * expression.cs (Unary.TryReduce): mimic the code for the regular
1862 code path. Perform an implicit cast in the cases where we can
1863 implicitly convert to one of the integral types, and then reduce
1864 based on that constant. This fixes bug #35483.
1866 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
1868 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
1870 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
1872 * namespace.cs: fixed bug #35489.
1874 2002-12-12 Miguel de Icaza <miguel@ximian.com>
1876 * class.cs: Remove some dead code.
1878 * cs-parser.jay: Estimate the number of methods needed
1879 (RootContext.MethodCount);
1881 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
1882 numbers instead of StringBuilders.
1884 * support.cs (PtrHashtable): Add constructor with initial size;
1885 We can now reduce reallocations of the method table.
1887 2002-12-10 Ravi Pratap <ravi@ximian.com>
1889 * attribute.cs (ApplyAttributes): Keep track of the emitted
1890 attributes on a per-target basis. This fixes bug #35413.
1892 2002-12-10 Miguel de Icaza <miguel@ximian.com>
1894 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
1895 default to the Windows 1252 encoding.
1897 (UnixParseOption): Support version, thanks to Alp for the missing
1900 * AssemblyInfo.cs: Add nice assembly information.
1902 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
1905 * cs-parser.jay: Allow a trailing comma before the close bracked
1906 in the attribute_section production.
1908 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
1909 address of the instance was being taken, I will take this out,
1910 because we take the address of the object immediately here.
1912 2002-12-09 Ravi Pratap <ravi@ximian.com>
1914 * typemanager.cs (AreMultipleAllowed): Take care of the most
1915 obvious case where attribute type is not in the current assembly -
1918 2002-12-08 Miguel de Icaza <miguel@ximian.com>
1920 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
1921 definitions, instead of doing that afterwards.
1923 Also we use a nice little hack, depending on the constructor, we
1924 know if we are a "composed" name or a simple name. Hence, we
1925 avoid the IndexOf test, and we avoid
1927 * codegen.cs: Add code to assist in a bug reporter to track down
1928 the source of a compiler crash.
1930 2002-12-07 Ravi Pratap <ravi@ximian.com>
1932 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
1933 types have been emitted for a given element and flag an error
1934 if something which does not have AllowMultiple set is used more
1937 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
1938 attribute types and their corresponding AllowMultiple properties
1940 (AreMultipleAllowed): Check the property for a given type.
1942 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
1943 property in the case we have a TypeContainer.
1945 (Attributes.AddAttribute): Detect duplicates and just skip on
1946 adding them. This trivial fix catches a pretty gross error in our
1947 attribute emission - global attributes were being emitted twice!
1949 Bugzilla bug #33187 is now fixed.
1951 2002-12-06 Miguel de Icaza <miguel@ximian.com>
1953 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
1956 * expression.cs (Binary.ResolveOperator): I can only use the
1957 Concat (string, string, string) and Concat (string, string,
1958 string, string) if the child is actually a concatenation of
1961 2002-12-04 Miguel de Icaza <miguel@ximian.com>
1963 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
1964 context where we need a 2-character lookahead.
1966 * pending.cs (PendingImplementation): Rework so we can keep track
1967 of interface types all the time, and flag those which were
1968 implemented by parents as optional.
1970 2002-12-03 Miguel de Icaza <miguel@ximian.com>
1972 * expression.cs (Binary.ResolveOperator): Use
1973 String.Concat(string,string,string) or
1974 String.Concat(string,string,string,string) when possible.
1976 * typemanager: More helper methods.
1979 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
1981 * pending.cs: remove the bogus return from GetMissingInterfaces()
1982 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
1984 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
1986 * namespace.cs: avoid duplicated 'using xxx' being added to
1987 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
1988 when we get more than one 'using' statement for the same namespace.
1989 Report a CS0105 warning for it.
1991 2002-11-30 Miguel de Icaza <miguel@ximian.com>
1993 * cs-tokenizer.cs (consume_identifier): use read directly, instead
1994 of calling getChar/putback, uses internal knowledge of it.
1996 (xtoken): Reorder tokenizer so most common patterns are checked
1997 first. This reduces the compilation time in another 5% (from 8.11s
1998 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
2000 The parsing time is 22% of the compilation in mcs, and from that
2001 64% is spent on the tokenization process.
2003 I tried using a binary search for keywords, but this is slower
2004 than the hashtable. Another option would be to do a couple of
2007 * Not use a StringBuilder, instead use an array of chars,
2008 with a set value. Notice that this way we could catch
2009 the 645 error without having to do it *afterwards*.
2011 * We could write a hand-parser to avoid the hashtable
2012 compares altogether.
2014 The identifier consumption process takes 37% of the tokenization
2015 time. Another 15% is spent on is_number. 56% of the time spent
2016 on is_number is spent on Int64.Parse:
2018 * We could probably choose based on the string length to
2019 use Int32.Parse or Int64.Parse and avoid all the 64-bit
2022 Another 3% is spend on wrapping `xtoken' in the `token' function.
2024 Handle 0xa0 as whitespace (#34752)
2026 2002-11-26 Miguel de Icaza <miguel@ximian.com>
2028 * typemanager.cs (IsCLRType): New routine to tell whether a type
2029 is one of the builtin types.
2031 Maybe it needs to use TypeCodes to be faster. Maybe we could use
2032 typecode in more places instead of doing pointer comparissions.
2033 We could leverage some knowledge about the way the typecodes are
2036 New code to cache namespaces in assemblies, it is currently not
2037 invoked, to be used soon.
2039 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
2041 * expression.cs (Binary.ResolveOperator): specially handle
2042 strings, and do not perform user-defined operator overloading for
2045 2002-11-24 Miguel de Icaza <miguel@ximian.com>
2047 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
2048 internalcall as it is a pretty simple operation; Avoid whenever
2049 possible to call Char.IsLetter.
2051 (consume_identifier): Cut by half the number of
2052 hashtable calls by merging the is_keyword and GetKeyword behavior.
2054 Do not short-circuit, because if we do, we
2055 report errors (ie, #if false && true would produce an invalid
2059 2002-11-24 Martin Baulig <martin@ximian.com>
2061 * expression.cs (Cast.TryReduce): If we're in checked syntax,
2062 check constant ranges and report a CS0221. Fixes #33186.
2064 2002-11-24 Martin Baulig <martin@ximian.com>
2066 * cs-parser.jay: Make this work for uninitialized variable
2067 declarations in the `for' initializer. Fixes #32416.
2069 2002-11-24 Martin Baulig <martin@ximian.com>
2071 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
2072 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
2074 2002-11-24 Martin Baulig <martin@ximian.com>
2076 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
2077 argument; if true, we also check for user-defined conversions.
2078 This is only needed if both arguments are of a user-defined type.
2079 Fixes #30443, added test-175.cs.
2080 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
2082 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
2084 2002-11-24 Martin Baulig <martin@ximian.com>
2086 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
2087 function to get the store opcode.
2088 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
2089 only emit the Ldelema if the store opcode is Stobj. You must run
2090 both test-34 and test-167 to test this. Fixes #34529.
2092 2002-11-23 Martin Baulig <martin@ximian.com>
2094 * ecore.cs (Expression.MemberLookup): Added additional
2095 `qualifier_type' argument which is used when we're being called
2096 from MemberAccess.DoResolve() and null if we're called from a
2098 (Expression.MemberLookupFailed): New method to report errors; this
2099 does the CS1540 check and reports the correct error message.
2101 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
2102 argument for the CS1540 check and redone the way how we're dealing
2103 with private members. See the comment in the source code for details.
2104 (FilterWithClosure): Reverted this back to revision 1.197; renamed
2105 `closure_start_type' to `closure_qualifier_type' and check whether
2106 it's not null. It was not this filter being broken, it was just
2107 being called with the wrong arguments.
2109 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
2110 and pass it the correct `qualifier_type'; this also does the error
2113 2002-11-22 Miguel de Icaza <miguel@ximian.com>
2115 * expression.cs (Invocation.EmitParams): If the we are dealing
2116 with a non-built-in value type, load its address as well.
2118 (ArrayCreation): Use a a pretty constant instead
2119 of the hardcoded value 2. Use 6 instead of 2 for the number of
2120 static initializers.
2122 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
2123 because they are not really value types, just glorified integers.
2125 * driver.cs: Do not append .exe, the CSC compiler does not do it.
2127 * ecore.cs: Remove redundant code for enumerations, make them use
2128 the same code path as everything else, fixes the casting issue
2129 with enumerations in Windows.Forms.
2131 * attribute.cs: Do only cast to string if it is a string, the
2132 validation happens later.
2134 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
2135 people upgrade their corlibs.
2137 * ecore.cs: Oops, enumerations were not following the entire code path
2139 2002-11-21 Miguel de Icaza <miguel@ximian.com>
2141 * typemanager.cs (FilterWithClosure): Commented out the test for
2142 1540 in typemanager.cs, as it has problems when accessing
2143 protected methods from a parent class (see test-174.cs).
2145 * attribute.cs (Attribute.ValidateGuid): new method.
2146 (Attribute.Resolve): Use above.
2148 2002-11-19 Miguel de Icaza <miguel@ximian.com>
2150 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
2152 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
2153 handling for enumerations, as we only needed the TypeContainer
2154 functionality to begin with (this is required for the fix below to
2155 work for enums that reference constants in a container class for
2158 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
2160 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
2161 a valid TypeBuilder to perform lookups on.o
2163 * class.cs (InheritableMemberSignatureCompare): Use true in the
2164 call to GetGetMethod and GetSetMethod, because we are comparing
2165 the signature, and we need to get the methods *even* if they are
2168 (PropertyBase.CheckBase): ditto.
2170 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
2171 GotoCase.Resolve): Use Peel on EmpytCasts.
2173 * ecore.cs (EmptyCast): drop child, add Peel method.
2175 2002-11-17 Martin Baulig <martin@ximian.com>
2177 * ecore.cs (EmptyCast.Child): New public property.
2179 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
2180 label resolved to an EmptyCast. Fixes #34162.
2181 (GotoCase.Resolve): Likewise.
2182 (Block.EmitMeta): Likewise.
2184 2002-11-17 Martin Baulig <martin@ximian.com>
2186 * expression.cs (Invocation.BetterConversion): Prefer int over
2187 uint; short over ushort; long over ulong for integer literals.
2188 Use ImplicitConversionExists instead of StandardConversionExists
2189 since we also need to check for user-defined implicit conversions.
2190 Fixes #34165. Added test-173.cs.
2192 2002-11-16 Martin Baulig <martin@ximian.com>
2194 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
2195 with the `true' and `false' literals. Fixes #33151.
2197 2002-11-16 Martin Baulig <martin@ximian.com>
2199 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
2200 October 22nd; don't do the cs1540 check for static members.
2202 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
2203 now using our own filter here and doing the cs1540 check again.
2205 2002-11-16 Martin Baulig <martin@ximian.com>
2207 * support.cs (InternalParameters): Don't crash if we don't have
2208 any fixed parameters. Fixes #33532.
2210 2002-11-16 Martin Baulig <martin@ximian.com>
2212 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
2213 when looking up static methods to make this work on Windows.
2216 2002-11-16 Martin Baulig <martin@ximian.com>
2218 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
2219 a setter rather than using PropertyInfo.CanWrite.
2221 2002-11-15 Nick Drochak <ndrochak@gol.com>
2223 * class.cs: Allow acces to block member by subclasses. Fixes build
2226 2002-11-14 Martin Baulig <martin@ximian.com>
2228 * class.cs (Constructor.Emit): Added the extern/block check.
2231 2002-11-14 Martin Baulig <martin@ximian.com>
2233 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
2234 iteration while looking for indexers, this is needed because the
2235 indexer may have a different name in our base classes. Fixed the
2236 error reporting (no indexers at all, not get accessor, no
2237 overloaded match). Fixes bug #33089.
2238 (IndexerAccess.DoResolveLValue): Likewise.
2240 2002-11-14 Martin Baulig <martin@ximian.com>
2242 * class.cs (PropertyBase.CheckBase): Make this work for multiple
2243 indexers. Fixes the first part of bug #33089.
2244 (MethodSignature.InheritableMemberSignatureCompare): Added support
2247 2002-11-13 Ravi Pratap <ravi@ximian.com>
2249 * attribute.cs (Attribute.Resolve): Catch the
2250 NullReferenceException and report it since it isn't supposed to
2253 2002-11-12 Miguel de Icaza <miguel@ximian.com>
2255 * expression.cs (Binary.EmitBranchable): Also handle the cases for
2256 LogicalOr and LogicalAnd that can benefit from recursively
2257 handling EmitBranchable. The code now should be nice for Paolo.
2259 2002-11-08 Miguel de Icaza <miguel@ximian.com>
2261 * typemanager.cs (LookupType): Added a negative-hit hashtable for
2262 the Type lookups, as we perform quite a number of lookups on
2263 non-Types. This can be removed once we can deterministically tell
2264 whether we have a type or a namespace in advance.
2266 But this might require special hacks from our corlib.
2270 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
2271 and double which avoids a conversion from an integer to a double.
2273 * expression.cs: tiny optimization, avoid calling IsConstant,
2274 because it effectively performs the lookup twice.
2276 2002-11-06 Miguel de Icaza <miguel@ximian.com>
2278 But a bogus return here to keep the semantics of the old code
2279 until the Mono runtime is fixed.
2281 * pending.cs (GetMissingInterfaces): New method used to remove all
2282 the interfaces that are already implemented by our parent
2283 classes from the list of pending methods.
2285 * interface.cs: Add checks for calls after ResolveTypeExpr.
2287 2002-11-05 Miguel de Icaza <miguel@ximian.com>
2289 * class.cs (Class.Emit): Report warning 67: event not used if the
2290 warning level is beyond 3.
2292 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
2293 being a NullLiteral.
2295 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
2298 * class.cs (TypeContainer.GetClassBases): Cover a missing code
2299 path that might fail if a type can not be resolved.
2301 * expression.cs (Binary.Emit): Emit unsigned versions of the
2304 * driver.cs: use error 5.
2306 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
2308 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
2310 2002-11-01 Miguel de Icaza <miguel@ximian.com>
2312 * cs-parser.jay (switch_section): A beautiful patch from Martin
2313 Baulig that fixed 33094.
2315 2002-10-31 Miguel de Icaza <miguel@ximian.com>
2317 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
2318 Check whether the base is abstract and report an error if so.
2320 * expression.cs (IndexerAccess.DoResolveLValue,
2321 IndexerAccess.DoResolve): ditto.
2323 (Invocation.DoResolve): ditto.
2325 (Invocation.FullMethodDesc): Improve the report string.
2327 * statement.cs (Block): Eliminate IsVariableDefined as it is
2328 basically just a wrapper for GetVariableInfo.
2330 * ecore.cs (SimpleName): Use new
2332 * support.cs (ReflectionParamter.ParameterType): We unwrap the
2333 type, as we return the actual parameter ref/unref state on a
2336 2002-10-30 Miguel de Icaza <miguel@ximian.com>
2338 * support.cs: Return proper flags REF/OUT fixing the previous
2341 * expression.cs: Reverted last patch, that was wrong. Is_ref is
2342 not used to mean `ref' but `ref or out' in ParameterReference
2344 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
2345 full type signature instead of calling TypeManger.CSharpName
2348 * support.cs (InternalParameters.ParameterDesc): Do not compare
2349 directly to the modflags, because REF/OUT will actually be bitsets
2352 * delegate.cs (VerifyMethod): Check also the modifiers.
2354 * cs-tokenizer.cs: Fix bug where floating point values with an
2355 exponent where a sign was missing was ignored.
2357 * driver.cs: Allow multiple assemblies to be specified in a single
2360 2002-10-28 Miguel de Icaza <miguel@ximian.com>
2362 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
2363 because identifiers after a parenthesis would end up in this kind
2364 of production, and we needed to desamiguate it for having casts
2367 (UserDefinedType *) xxx
2369 2002-10-24 Miguel de Icaza <miguel@ximian.com>
2371 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
2372 we should set on the Bindingflags.NonPublic, but not turn on
2373 private_ok. private_ok controls whether a Private member is
2374 returned (this is chekced on the filter routine), while the
2375 BindingFlags.NonPublic just controls whether private/protected
2376 will be allowed. This fixes the problem part of the problem of
2377 private properties being allowed to be used in derived classes.
2379 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
2380 so we can call the children DoResolveLValue method (this will
2381 properly signal errors on lvalue assignments to base properties)
2383 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
2384 getter are null, and we have a property info, we know that this
2385 happened because the lookup failed, so we report an error 122 for
2386 protection level violation.
2388 We also silently return if setter and getter are null in the
2389 resolve functions, this condition only happens if we have flagged
2390 the error before. This is the other half of the problem.
2392 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
2393 not have accessibility information, that is why we were returning
2394 true in the filter function in typemanager.cs.
2396 To properly report 122 (property is inaccessible because of its
2397 protection level) correctly, we report this error in ResolveAccess
2398 by failing if both the setter and the getter are lacking (ie, the
2401 DoResolve and DoLResolve have been modified to check for both
2402 setter/getter being null and returning silently, the reason being
2403 that I did not want to put the knowledge about this error in upper
2406 int old = Report.Errors;
2407 x = new PropertyExpr (...);
2408 if (old != Report.Errors)
2413 So the property expr is returned, but it is invalid, so the error
2414 will be flagged during the resolve process.
2416 * class.cs: Remove InheritablePropertySignatureCompare from the
2417 class, as we no longer depend on the property signature to compute
2418 whether it is possible to implement a method or not.
2420 The reason is that calling PropertyInfo.GetGetMethod will return
2421 null (in .NET, in Mono it works, and we should change this), in
2422 cases where the Get Method does not exist in that particular
2427 class X { public virtual int A { get { return 1; } } }
2429 class Z : Y { public override int A { get { return 2; } } }
2431 Would fail in Z because the parent (Y) would not have the property
2432 defined. So we avoid this completely now (because the alternative
2433 fix was ugly and slow), and we now depend exclusively on the
2436 (PropertyBase.CheckBase): Use a method-base mechanism to find our
2437 reference method, instead of using the property.
2439 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
2440 routines are gone now.
2442 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
2443 names, they were incorrectly named.
2445 * cs-tokenizer.cs: Return are more gentle token on failure.
2447 * pending.cs (PendingImplementation.InterfaceMethod): This routine
2448 had an out-of-sync index variable, which caused it to remove from
2449 the list of pending methods the wrong method sometimes.
2451 2002-10-22 Miguel de Icaza <miguel@ximian.com>
2453 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
2454 CanWrite, because those refer to this particular instance of the
2455 property, and do not take into account the fact that we can
2456 override single members of a property.
2458 Constructor requires an EmitContext. The resolution process does
2459 not happen here, but we need to compute the accessors before,
2460 because the resolution does not always happen for properties.
2462 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
2463 subclass, before we did not update this flag, but we did update
2466 (GetAccessors): Drop this routine, as it did not work in the
2467 presence of partially overwritten set/get methods.
2469 Notice that this broke the cs1540 detection, but that will require
2472 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
2476 * driver.cs: issue a warning instead of an error if we don't support
2477 debugging for the platform. Also ignore a couple of errors that may
2478 arise when trying to write the symbols. Undo my previous patch.
2480 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
2482 * driver.cs: ignore /debug switch except for Unix platforms.
2484 2002-10-23 Nick Drochak <ndrochak@gol.com>
2486 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
2488 2002-10-21 Miguel de Icaza <miguel@ximian.com>
2490 * driver.cs: Do not make mcs-debug conditional, so we do not break
2493 * statement.cs (UsageVector.MergeChildren): I would like Martin to
2494 review this patch. But basically after all the children variables
2495 have been merged, the value of "Breaks" was not being set to
2496 new_breaks for Switch blocks. I think that it should be set after
2497 it has executed. Currently I set this to the value of new_breaks,
2498 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
2499 conservative, but I do not understand this code very well.
2501 I did not break anything in the build, so that is good ;-)
2503 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
2505 2002-10-20 Mark Crichton <crichton@gimp.org>
2507 * cfold.cs: Fixed compile blocker. Really fixed it this time.
2509 2002-10-20 Nick Drochak <ndrochak@gol.com>
2511 * cfold.cs: Fixed compile blocker.
2513 2002-10-20 Miguel de Icaza <miguel@ximian.com>
2515 * driver.cs: I was chekcing the key, not the file.
2517 2002-10-19 Ravi Pratap <ravi@ximian.com>
2519 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
2520 message that we were generating - we just need to silently return
2523 2002-10-19 Miguel de Icaza <miguel@ximian.com>
2525 * class.cs (Event.Define): Change my previous commit, as this
2526 breaks the debugger. This is a temporary hack, as it seems like
2527 the compiler is generating events incorrectly to begin with.
2529 * expression.cs (Binary.ResolveOperator): Added support for
2530 "U operator - (E x, E y)"
2532 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
2535 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
2536 init-only variables, but this path did not take into account that
2537 there might be also instance readonly variables. Correct this
2540 This fixes bug 32253
2542 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
2545 * driver.cs: Change the extension for modules to `netmodule'
2547 * cs-parser.jay: Improved slightly the location tracking for
2548 the debugger symbols.
2550 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
2551 modifiers that were specified instead of the hardcoded value
2552 (FamAndAssem). This was basically ignoring the static modifier,
2553 and others. Fixes 32429.
2555 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
2556 fixed a bug in the process (32476)
2558 * expression.cs (ArrayAccess.EmitAssign): Patch from
2559 hwang_rob@yahoo.ca that fixes bug 31834.3
2561 2002-10-18 Miguel de Icaza <miguel@ximian.com>
2563 * driver.cs: Make the module extension .netmodule.
2565 2002-10-16 Miguel de Icaza <miguel@ximian.com>
2567 * driver.cs: Report an error if the resource file is not found
2568 instead of crashing.
2570 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
2571 false, like Emit does.
2573 2002-10-16 Nick Drochak <ndrochak@gol.com>
2575 * typemanager.cs: Remove unused private member. Also reported mcs
2576 bug to report this as a warning like csc.
2578 2002-10-15 Martin Baulig <martin@gnome.org>
2580 * statement.cs (Statement.Emit): Made this a virtual method; emits
2581 the line number info and calls DoEmit().
2582 (Statement.DoEmit): New protected abstract method, formerly knows
2583 as Statement.Emit().
2585 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
2587 2002-10-11 Miguel de Icaza <miguel@ximian.com>
2589 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
2590 have fixed a remaining problem: not every AddXXXX was adding a
2591 fully qualified name.
2593 Now everyone registers a fully qualified name in the DeclSpace as
2594 being defined instead of the partial name.
2596 Downsides: we are slower than we need to be due to the excess
2597 copies and the names being registered this way.
2599 The reason for this is that we currently depend (on the corlib
2600 bootstrap for instance) that types are fully qualified, because
2601 we dump all the types in the namespace, and we should really have
2602 types inserted into the proper namespace, so we can only store the
2603 basenames in the defined_names array.
2605 2002-10-10 Martin Baulig <martin@gnome.org>
2607 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
2608 from bug #31834, see the bug report for a testcase which is
2611 2002-10-10 Martin Baulig <martin@gnome.org>
2613 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
2614 flow analysis code for this.
2616 * statement.cs (Do, While, For): Tell the flow analysis code about
2618 (FlowBranching.UsageVector): Added support for infinite loops.
2619 (Block.Resolve): Moved the dead code elimination here and use flow
2622 2002-10-09 Miguel de Icaza <miguel@ximian.com>
2624 * class.cs (Field.Define): Catch cycles on struct type
2627 * typemanager.cs (IsUnmanagedtype): Do not recursively check
2628 fields if the fields are static. We only need to check instance
2631 * expression.cs (As.DoResolve): Test for reference type.
2633 * statement.cs (Using.ResolveExpression): Use
2634 ConvertImplicitRequired, not ConvertImplicit which reports an
2636 (Using.ResolveLocalVariableDecls): ditto.
2638 * expression.cs (Binary.ResolveOperator): Report errors in a few
2639 places where we had to.
2641 * typemanager.cs (IsUnmanagedtype): Finish implementation.
2643 2002-10-08 Miguel de Icaza <miguel@ximian.com>
2645 * expression.cs: Use StoreFromPtr instead of extracting the type
2646 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
2648 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
2649 an enumeration value to a System.Enum, but System.Enum is not a
2650 value type, but an class type, so we need to box.
2652 (Expression.ConvertExplicit): One codepath could return
2653 errors but not flag them. Fix this. Fixes #31853
2655 * parameter.cs (Resolve): Do not allow void as a parameter type.
2657 2002-10-06 Martin Baulig <martin@gnome.org>
2659 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
2660 if it's a class type and not a struct. Fixes #31815.
2662 2002-10-06 Martin Baulig <martin@gnome.org>
2664 * statement.cs: Reworked the flow analysis code a bit to make it
2665 usable for dead code elimination.
2667 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
2669 * cs-parser.jay: allow empty source files. Fixes bug #31781.
2671 2002-10-04 Miguel de Icaza <miguel@ximian.com>
2673 * expression.cs (ComposedCast.DoResolveType): A quick workaround
2674 to fix the test 165, will investigate deeper.
2676 2002-10-04 Martin Baulig <martin@gnome.org>
2678 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
2679 finally blocks actually work.
2680 (Try.Resolve): We don't need to create a sibling for `finally' if
2681 there is no finally block.
2683 2002-10-04 Martin Baulig <martin@gnome.org>
2685 * class.cs (Constructor.Define): The default accessibility for a
2686 non-default constructor is private, not public.
2688 2002-10-04 Miguel de Icaza <miguel@ximian.com>
2690 * class.cs (Constructor): Make AllowedModifiers public, add
2693 * cs-parser.jay: Perform the modifiers test here, as the
2694 constructor for the Constructor class usually receives a zero
2695 because of the way we create it (first we create, later we
2696 customize, and we were never checking the modifiers).
2698 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
2699 is a version of LookupTypeReflection that includes the type-name
2700 cache. This can be used as a fast path for functions that know
2701 the fully qualified name and are only calling into *.GetType() to
2702 obtain a composed type.
2704 This is also used by TypeManager.LookupType during its type
2707 (LookupType): We now also track the real type name, as sometimes
2708 we can get a quey for the real type name from things like
2709 ComposedCast. This fixes bug 31422.
2711 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
2712 complete type fullname, it does not have to go through the type
2713 resolution system to obtain the composed version of the type (for
2714 obtaining arrays or pointers).
2716 (Conditional.Emit): Use the EmitBoolExpression to
2717 generate nicer code, as requested by Paolo.
2719 (ArrayCreation.CheckIndices): Use the patch from
2720 hwang_rob@yahoo.ca to validate the array initializers.
2722 2002-10-03 Miguel de Icaza <miguel@ximian.com>
2724 * class.cs (ConstructorInitializer.Emit): simplify code by using
2725 Invocation.EmitCall, and at the same time, fix the bugs in calling
2726 parent constructors that took variable arguments.
2728 * ecore.cs (Expression.ConvertNumericExplicit,
2729 Expression.ImplicitNumericConversion): Remove the code that
2730 manually wrapped decimal (InternalTypeConstructor call is now gone
2733 * expression.cs (Cast.TryReduce): Also handle decimal types when
2734 trying to perform a constant fold on the type.
2736 * typemanager.cs (IsUnmanagedtype): Partially implemented.
2738 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
2739 that only turned off an error report, and did nothing else.
2741 2002-10-02 Miguel de Icaza <miguel@ximian.com>
2743 * driver.cs: Handle and ignore /fullpaths
2745 2002-10-01 Miguel de Icaza <miguel@ximian.com>
2747 * expression.cs (Binary.ResolveOperator): Catch the case where
2748 DoNumericPromotions returns true,
2750 (Binary.DoNumericPromotions): Simplify the code, and the tests.
2752 2002-09-27 Miguel de Icaza <miguel@ximian.com>
2754 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
2757 2002-09-26 Miguel de Icaza <miguel@ximian.com>
2759 * ecore.cs (ConvertNumericExplicit): It is not enough that the
2760 conversion exists, but it is also required that the conversion be
2761 performed. This manifested in "(Type64Enum) 2".
2763 * class.cs (TypeManager.AddMethod): The fix is not to change
2764 AddEnum, because that one was using a fully qualified name (every
2765 DeclSpace derivative does), but to change the AddMethod routine
2766 that was using an un-namespaced name. This now correctly reports
2767 the duplicated name.
2769 Revert patch until I can properly fix it. The issue
2770 is that we have a shared Type space across all namespaces
2771 currently, which is wrong.
2773 Options include making the Namespace a DeclSpace, and merge
2774 current_namespace/current_container in the parser.
2776 2002-09-25 Miguel de Icaza <miguel@ximian.com>
2778 * cs-parser.jay: Improve error reporting when we get a different
2779 kind of expression in local_variable_type and
2780 local_variable_pointer_type.
2782 Propagate this to avoid missleading errors being reported.
2784 * ecore.cs (ImplicitReferenceConversion): treat
2785 TypeManager.value_type as a target just like object_type. As
2790 Is valid, and needs to result in the int 1 being boxed before it
2791 is assigned to the value type v.
2793 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
2794 to validate the enumeration name.
2796 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
2797 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
2798 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
2800 * ecore.cs (TryImplicitIntConversion): When doing an
2801 implicit-enumeration-conversion, check if the type is 64-bits and
2802 perform a conversion before passing to EnumConstant.
2804 2002-09-23 Miguel de Icaza <miguel@ximian.com>
2806 * decl.cs (Error_AmbiguousTypeReference); New routine used to
2807 report ambiguous type references. Unlike the MS version, we
2808 report what the ambiguity is. Innovation at work ;-)
2810 (DeclSpace.FindType): Require a location argument to
2811 display when we display an ambiguous error.
2813 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
2815 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
2817 * expression.cs (EmitDynamicInitializers): Apply patch from
2818 hwang_rob@yahoo.ca that fixes the order in which we emit our
2821 2002-09-21 Martin Baulig <martin@gnome.org>
2823 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
2824 delegate takes no arguments.
2826 2002-09-20 Miguel de Icaza <miguel@ximian.com>
2828 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
2831 * expression.cs: Extract the underlying type.
2833 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
2835 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
2837 2002-09-19 Miguel de Icaza <miguel@ximian.com>
2839 * class.cs (TypeContainer.DefineType): We can not use the nice
2840 PackingSize with the size set to 1 DefineType method, because it
2841 will not allow us to define the interfaces that the struct
2844 This completes the fixing of bug 27287
2846 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
2847 means also structs. This fixes part of the problem.
2848 (Expresion.ImplicitReferenceConversionExists): ditto.
2850 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
2851 error if there were no errors reported during the type lookup
2852 process, to avoid duplicates or redundant errors. Without this
2853 you would get an ambiguous errors plus a type not found. We have
2854 beaten the user enough with the first error.
2856 (DeclSparce.FindType): Emit a warning if we have an ambiguous
2859 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
2860 during the resolution process, stop the lookup, this avoids
2861 repeated error reports (same error twice).
2863 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
2865 * typemanager.cs (LookupType): Redo the type lookup code to match
2866 the needs of System.Reflection.
2868 The issue is that System.Reflection requires references to nested
2869 types to begin with a "+" sign instead of a dot. So toplevel
2870 types look like: "NameSpace.TopLevelClass", and nested ones look
2871 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
2874 2002-09-19 Martin Baulig <martin@gnome.org>
2876 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
2877 says that a method always returns or always throws an exception,
2878 don't report the CS0161.
2880 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
2881 set `Returns = new_returns'.
2883 2002-09-19 Martin Baulig <martin@gnome.org>
2885 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
2886 to an enum constant, check for a CS0176.
2888 2002-09-18 Miguel de Icaza <miguel@ximian.com>
2890 * class.cs (TypeContainer.CheckPairedOperators): Now we check
2891 for operators that must be in pairs and report errors.
2893 * ecore.cs (SimpleName.DoResolveType): During the initial type
2894 resolution process, when we define types recursively, we must
2895 check first for types in our current scope before we perform
2896 lookups in the enclosing scopes.
2898 * expression.cs (MakeByteBlob): Handle Decimal blobs.
2900 (Invocation.VerifyArgumentsCompat): Call
2901 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
2902 I thought we were supposed to always call this, but there are a
2903 few places in the code where we dont do it.
2905 2002-09-17 Miguel de Icaza <miguel@ximian.com>
2907 * driver.cs: Add support in -linkres and -resource to specify the
2908 name of the identifier.
2910 2002-09-16 Miguel de Icaza <miguel@ximian.com>
2912 * ecore.cs (StandardConversionExists): Sync with the conversion
2913 code: allow anything-* to void* conversions.
2915 (FindMostSpecificSource): Use an Expression argument
2916 instead of a Type, because we might be handed over a Literal which
2917 gets a few more implicit conversions that plain types do not. So
2918 this information was being lost.
2920 Also, we drop the temporary type-holder expression when not
2923 2002-09-17 Martin Baulig <martin@gnome.org>
2925 * class.cs (PropertyBase.CheckBase): Don't check the base class if
2926 this is an explicit interface implementation.
2928 2002-09-17 Martin Baulig <martin@gnome.org>
2930 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
2931 different `IndexerName' attributes.
2933 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
2934 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
2935 virtual CommonResolve().
2937 2002-09-16 Miguel de Icaza <miguel@ximian.com>
2939 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
2940 and convert that to the UnderlyingType.
2942 * statement.cs (Foreach.Resolve): Indexers are just like variables
2943 or PropertyAccesses.
2945 * cs-tokenizer.cs (consume_string): Track line numbers and columns
2946 inside quoted strings, we were not doing this before.
2948 2002-09-16 Martin Baulig <martin@gnome.org>
2950 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
2951 resolve it. This is needed for the definite assignment check of the
2952 instance expression, fixes bug #29846.
2953 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
2955 2002-09-16 Nick Drochak <ndrochak@gol.com>
2957 * parameter.cs: Fix compile error. Cannot reference static member
2958 from an instance object. Is this an mcs bug?
2960 2002-09-14 Martin Baulig <martin@gnome.org>
2962 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
2963 multiple times. Fixes bug #30295, added test-166.cs.
2965 2002-09-14 Martin Baulig <martin@gnome.org>
2967 * statement.cs (Block.Emit): Don't emit unreachable code.
2968 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
2970 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
2972 2002-09-14 Martin Baulig <martin@gnome.org>
2974 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
2977 2002-09-14 Martin Baulig <martin@gnome.org>
2979 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
2980 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
2981 be false on the ms runtime.
2983 2002-09-13 Martin Baulig <martin@gnome.org>
2985 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
2986 the CS0038 error message.
2988 2002-09-12 Miguel de Icaza <miguel@ximian.com>
2990 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
2991 constant inside, return it.
2993 2002-09-12 Martin Baulig <martin@gnome.org>
2995 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
2996 implicit conversion can be done between enum types.
2998 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
2999 check whether an implicit conversion to the current enum's UnderlyingType
3000 exists and report an error if not.
3002 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
3003 without debugging support.
3005 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
3006 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
3008 2002-09-12 Martin Baulig <martin@gnome.org>
3010 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
3012 * ecore.cs (IMemberExpr.DeclaringType): New property.
3013 (SimpleName.SimpleNameResolve): Check whether we're accessing a
3014 nonstatic member of an outer type (CS0038).
3016 2002-09-11 Miguel de Icaza <miguel@ximian.com>
3018 * driver.cs: Activate the using-error detector at warning level
3019 4 (at least for MS-compatible APIs).
3021 * namespace.cs (VerifyUsing): Small buglett fix.
3023 * pending.cs (PendingImplementation): pass the container pointer.
3025 * interface.cs (GetMethods): Allow for recursive definition. Long
3026 term, I would like to move every type to support recursive
3027 definitions, not the current ordering mechanism that we have right
3030 The situation is this: Attributes are handled before interfaces,
3031 so we can apply attributes to interfaces. But some attributes
3032 implement interfaces, we will now handle the simple cases
3033 (recursive definitions will just get an error).
3035 * parameter.cs: Only invalidate types at the end if we fail to
3038 2002-09-09 Martin Baulig <martin@gnome.org>
3040 * ecore.cs (PropertyExpr.Emit): Also check for
3041 TypeManager.system_int_array_get_length so this'll also work when
3042 compiling corlib. Fixes #30003.
3044 2002-09-09 Martin Baulig <martin@gnome.org>
3046 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
3047 and throw an exception if we can't get the type's size. Fixed #30040,
3050 2002-09-09 Martin Baulig <martin@gnome.org>
3052 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
3054 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
3055 context. Fixes bug #30027.
3057 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
3058 virtual functions. Fixes bug #30043, added test-164.cs.
3060 2002-09-08 Ravi Pratap <ravi@ximian.com>
3062 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
3064 2002-09-08 Nick Drochak <ndrochak@gol.com>
3066 * driver.cs: Use an object to get the windows codepage since it's not a
3069 2002-09-08 Miguel de Icaza <miguel@ximian.com>
3071 * statement.cs (For.Emit): for infinite loops (test == null)
3072 return whether there is a break inside, not always "true".
3074 * namespace.cs (UsingEntry): New struct to hold the name of the
3075 using definition, the location where it is defined, and whether it
3076 has been used in a successful type lookup.
3078 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
3083 2002-09-06 Ravi Pratap <ravi@ximian.com>
3085 * attribute.cs : Fix incorrect code which relied on catching
3086 a NullReferenceException to detect a null being passed in
3087 where an object was expected.
3089 2002-09-06 Miguel de Icaza <miguel@ximian.com>
3091 * statement.cs (Try): flag the catch variable as assigned
3093 * expression.cs (Cast): Simplified by using ResolveType instead of
3096 * statement.cs (Catch): Fix bug by using ResolveType.
3098 2002-09-06 Ravi Pratap <ravi@ximian.com>
3100 * expression.cs (BetterConversion): Special case for when we have
3101 a NullLiteral as the argument and we have to choose between string
3102 and object types - we choose string the way csc does.
3104 * attribute.cs (Attribute.Resolve): Catch the
3105 NullReferenceException and report error #182 since the Mono
3106 runtime no more has the bug and having this exception raised means
3107 we tried to select a constructor which takes an object and is
3110 2002-09-05 Ravi Pratap <ravi@ximian.com>
3112 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
3113 message (1502, 1503) when we can't locate a method after overload
3114 resolution. This is much more informative and closes the bug
3117 * interface.cs (PopulateMethod): Return if there are no argument
3118 types. Fixes a NullReferenceException bug.
3120 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
3121 expressions too. Previously we were checking only in one place for
3122 positional arguments leaving out named arguments.
3124 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
3125 type to the enum type is not allowed. Remove code corresponding to
3128 (ConvertNumericExplicit): Allow explicit conversions from
3129 the underlying type to enum type. This precisely follows the spec
3130 and closes a bug filed by Gonzalo.
3132 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
3135 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
3137 2002-09-03 Miguel de Icaza <miguel@ximian.com>
3139 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
3140 it was important that we stored the right value after the
3141 reduction in `converted'.
3143 2002-09-04 Martin Baulig <martin@gnome.org>
3145 * location.cs (Location.SymbolDocument): Use full pathnames for the
3148 2002-08-30 Miguel de Icaza <miguel@ximian.com>
3150 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
3151 of the expression resolve mechanism, because that will catch the
3152 SimpleName error failures.
3154 (Conditional): If we can not resolve the
3155 expression, return, do not crash.
3157 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
3160 (location): display token name instead of its number.
3162 2002-08-28 Martin Baulig <martin@gnome.org>
3164 * expression.cs (Binary.ResolveOperator): Don't silently return
3165 but return an error if an operator cannot be applied between two
3168 2002-08-28 Martin Baulig <martin@gnome.org>
3170 * class.cs (Constructor.Define): Set the permission attributes
3171 correctly instead of making all constructors public.
3173 2002-08-28 Martin Baulig <martin@gnome.org>
3175 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
3176 for private members before reporting a CS0103; if we find anything,
3179 2002-08-28 Martin Baulig <martin@gnome.org>
3181 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
3182 to check whether `closure_start_type == closure_invocation_type',
3183 we also need to check whether `m.DeclaringType == closure_invocation_type'
3184 before bypassing the permission checks. We might be accessing
3185 protected/private members from the base class.
3186 (TypeManager.RealMemberLookup): Only set private_ok if private
3187 members were requested via BindingFlags.NonPublic.
3189 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
3191 * expression.cs (MemberAccess.ResolveMemberAccess): Set
3192 MethodGroupExpr.IsExplicitImpl if appropriate.
3193 (Invocation.DoResolve): Don't report the CS0120 for explicit
3194 interface implementations.
3196 2002-08-27 Martin Baulig <martin@gnome.org>
3198 * expression.cs (Invocation.DoResolve): If this is a static
3199 method and we don't have an InstanceExpression, we must report
3202 2002-08-25 Martin Baulig <martin@gnome.org>
3204 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
3205 `==' between a valuetype and an object.
3207 2002-08-25 Miguel de Icaza <miguel@ximian.com>
3209 * ecore.cs (TypeExpr): Provide a ToString method.
3211 2002-08-24 Martin Baulig <martin@gnome.org>
3213 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
3214 now called proggie.dbg and it's a binary file.
3216 2002-08-23 Martin Baulig <martin@gnome.org>
3218 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
3220 2002-08-23 Martin Baulig <martin@gnome.org>
3222 * struct.cs (MyStructInfo.ctor): Make this work with empty
3223 structs; it's not allowed to use foreach() on null.
3225 2002-08-23 Martin Baulig <martin@gnome.org>
3227 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
3228 writer the full pathname of the generated assembly.
3230 2002-08-23 Martin Baulig <martin@gnome.org>
3232 * statements.cs (FlowBranching.UsageVector.MergeChildren):
3233 A `finally' block never returns or breaks; improved handling of
3236 2002-08-23 Martin Baulig <martin@gnome.org>
3238 * statement.cs (Throw.Resolve): Allow `throw null'.
3240 2002-08-23 Martin Baulig <martin@gnome.org>
3242 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
3243 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
3244 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
3245 MemberLookup would return a wrong event if this is an explicit
3246 interface implementation and the class has an event with the same
3249 2002-08-23 Martin Baulig <martin@gnome.org>
3251 * statement.cs (Block.AddChildVariableNames): New public method.
3252 (Block.AddChildVariableName): Likewise.
3253 (Block.IsVariableNameUsedInChildBlock): Likewise.
3254 (Block.AddVariable): Check whether a variable name has already
3255 been used in a child block.
3257 * cs-parser.jay (declare_local_variables): Mark all variable names
3258 from the current block as being used in a child block in the
3261 2002-08-23 Martin Baulig <martin@gnome.org>
3263 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
3264 find the symbol writer.
3266 * driver.cs: csc also allows the arguments to /define being
3267 separated by commas, not only by semicolons.
3269 2002-08-23 Martin Baulig <martin@gnome.org>
3271 * interface.cs (Interface.GetMembers): Added static check for events.
3273 2002-08-15 Martin Baulig <martin@gnome.org>
3275 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
3276 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
3278 * ecore.cs (Expression.MemberLookup): Added documentation and explained
3279 why the MethodData.EmitDestructor() change was necessary.
3281 2002-08-20 Martin Baulig <martin@gnome.org>
3283 * class.cs (TypeContainer.FindMembers): Added static check for events.
3285 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
3287 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
3288 use Type.GetEvents(), not Type.FindMembers().
3290 2002-08-20 Martin Baulig <martin@gnome.org>
3292 * decl.cs (MemberCache): Added a special method cache which will
3293 be used for method-only searched. This ensures that a method
3294 search will return a MethodInfo with the correct ReflectedType for
3297 2002-08-20 Martin Baulig <martin@gnome.org>
3299 * decl.cs (DeclSpace.FindMembers): Made this public.
3301 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
3303 * delegate.cs: fixed build on windows.
3304 [FIXME: Filed as bug #29150: MCS must report these errors.]
3306 2002-08-19 Ravi Pratap <ravi@ximian.com>
3308 * ecore.cs (StandardConversionExists): Return a false
3309 if we are trying to convert the void type to anything else
3310 since that is not allowed.
3312 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
3313 we flag error 70 in the event an event is trying to be accessed
3314 directly from outside the declaring type.
3316 2002-08-20 Martin Baulig <martin@gnome.org>
3318 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
3319 MemberCache from typemanager.cs to decl.cs.
3321 2002-08-19 Martin Baulig <martin@gnome.org>
3323 * class.cs (TypeContainer): Implement IMemberContainer.
3324 (TypeContainer.DefineMembers): Create the MemberCache.
3325 (TypeContainer.FindMembers): Do better BindingFlags checking; only
3326 return public members if BindingFlags.Public was given, check
3327 whether members are static.
3329 2002-08-16 Martin Baulig <martin@gnome.org>
3331 * decl.cs (DeclSpace.Define): Splitted this in Define and
3332 DefineMembers. DefineMembers is called first and initializes the
3335 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
3336 DefineMembers() on all our DeclSpaces.
3338 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
3339 but call DefineMembers() on all nested interfaces. We call their
3340 Define() in our new Define() function.
3342 * interface.cs (Interface): Implement IMemberContainer.
3343 (Interface.Define): Moved all code except the attribute stuf to
3345 (Interface.DefineMembers): Initialize the member cache.
3347 * typemanager.cs (IMemberFinder): Removed this interface, we don't
3348 need this anymore since we can use MemberCache.FindMembers directly.
3350 2002-08-19 Martin Baulig <martin@gnome.org>
3352 * typemanager.cs (MemberCache): When creating the cache for an
3353 interface type, add all inherited members.
3354 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
3355 to `out bool used_cache' and documented it.
3356 (TypeManager.MemberLookup): If we already used the cache in the first
3357 iteration, we don't need to do the interfaces check.
3359 2002-08-19 Martin Baulig <martin@gnome.org>
3361 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
3362 here from IMemberFinder and don't implement this interface anymore.
3363 (DeclSpace.MemberCache): Moved here from IMemberFinder.
3365 * typemanager.cs (IMemberFinder): This interface is now only used by
3366 classes which actually support the member cache.
3367 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
3368 since we only put DeclSpaces into this Hashtable.
3369 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
3370 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
3372 2002-08-16 Martin Baulig <martin@gnome.org>
3374 * typemanager.cs (ICachingMemberFinder): Removed.
3375 (IMemberFinder.MemberCache): New property.
3376 (TypeManager.FindMembers): Merged this with RealFindMembers().
3377 This function will never be called from TypeManager.MemberLookup()
3378 so we can't use the cache here, just the IMemberFinder.
3379 (TypeManager.MemberLookup_FindMembers): Check whether the
3380 IMemberFinder has a MemberCache and call the cache's FindMembers
3382 (MemberCache): Rewrote larger parts of this yet another time and
3383 cleaned it up a bit.
3385 2002-08-15 Miguel de Icaza <miguel@ximian.com>
3387 * driver.cs (LoadArgs): Support quoting.
3389 (Usage): Show the CSC-like command line arguments.
3391 Improved a few error messages.
3393 2002-08-15 Martin Baulig <martin@gnome.org>
3395 * typemanager.cs (IMemberContainer.Type): New property.
3396 (IMemberContainer.IsInterface): New property.
3398 The following changes are conditional to BROKEN_RUNTIME, which is
3399 defined at the top of the file.
3401 * typemanager.cs (MemberCache.MemberCache): Don't add the base
3402 class'es members, but add all members from TypeHandle.ObjectType
3403 if we're an interface.
3404 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
3405 is the current type.
3406 (MemberCache.CacheEntry.Container): Removed this field.
3407 (TypeHandle.GetMembers): Include inherited members.
3409 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
3411 * typemanager.cs: fixed compilation and added a comment on a field that
3414 2002-08-15 Martin Baulig <martin@gnome.org>
3416 * class.cs (ConstructorInitializer.Resolve): In the
3417 Expression.MemberLookup call, use the queried_type as
3420 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
3421 declared' attribute, it's always true.
3422 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
3423 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
3424 temporary wrapper for FindMembers which tells MemberLookup whether
3425 members from the base classes are included in the return value.
3426 This will go away soon.
3427 (TypeManager.MemberLookup): Use this temporary hack here; once the
3428 new MemberCache is completed, we don't need to do the DeclaredOnly
3429 looping here anymore since the MemberCache will take care of this.
3430 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
3431 (MemberCache): When creating the MemberCache for a class, get
3432 members from the current class and all its base classes.
3433 (MemberCache.CacheEntry.Container): New field. This is a
3434 temporary hack until the Mono runtime is fixed to distinguish
3435 between ReflectedType and DeclaringType. It allows us to use MCS
3436 with both the MS runtime and the unfixed Mono runtime without
3437 problems and without accecting performance.
3438 (MemberCache.SearchMembers): The DeclaredOnly looping from
3439 TypeManager.MemberLookup is now done here.
3441 2002-08-14 Martin Baulig <martin@gnome.org>
3443 * statement.cs (MyStructInfo.MyStructInfo): Don't call
3444 Type.GetFields on dynamic types but get the fields from the
3445 corresponding TypeContainer.
3446 (MyStructInfo.GetStructInfo): Added check for enum types.
3448 * typemanager.cs (MemberList.IsSynchronized): Implemented.
3449 (MemberList.SyncRoot): Implemented.
3450 (TypeManager.FilterWithClosure): No need to check permissions if
3451 closure_start_type == closure_invocation_type, don't crash if
3452 closure_invocation_type is null.
3454 2002-08-13 Martin Baulig <martin@gnome.org>
3456 Rewrote TypeContainer.FindMembers to use a member cache. This
3457 gives us a speed increase of about 35% for the self-hosting MCS
3458 build and of about 15-20% for the class libs (both on GNU/Linux).
3460 * report.cs (Timer): New class to get enhanced profiling. This
3461 whole class is "TIMER" conditional since it remarkably slows down
3464 * class.cs (MemberList): New class. This is an IList wrapper
3465 which we're now using instead of passing MemberInfo[]'s around to
3466 avoid copying this array unnecessarily.
3467 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
3468 (ICachingMemberFinder, IMemberContainer): New interface.
3469 (TypeManager.FilterWithClosure): If `criteria' is null, the name
3470 has already been checked, otherwise use it for the name comparision.
3471 (TypeManager.FindMembers): Renamed to RealMemberFinder and
3472 provided wrapper which tries to use ICachingMemberFinder.FindMembers
3473 if possible. Returns a MemberList, not a MemberInfo [].
3474 (TypeHandle): New class, implements IMemberContainer. We create
3475 one instance of this class per type, it contains a MemberCache
3476 which is used to do the member lookups.
3477 (MemberCache): New class. Each instance of this class contains
3478 all members of a type and a name-based hash table.
3479 (MemberCache.FindMembers): This is our new member lookup
3480 function. First, it looks up all members of the requested name in
3481 the hash table. Then, it walks this list and sorts out all
3482 applicable members and returns them.
3484 2002-08-13 Martin Baulig <martin@gnome.org>
3486 In addition to a nice code cleanup, this gives us a performance
3487 increase of about 1.4% on GNU/Linux - not much, but it's already
3488 half a second for the self-hosting MCS compilation.
3490 * typemanager.cs (IMemberFinder): New interface. It is used by
3491 TypeManager.FindMembers to call FindMembers on a TypeContainer,
3492 Enum, Delegate or Interface.
3493 (TypeManager.finder_to_member_finder): New PtrHashtable.
3494 (TypeManager.finder_to_container): Removed.
3495 (TypeManager.finder_to_delegate): Removed.
3496 (TypeManager.finder_to_interface): Removed.
3497 (TypeManager.finder_to_enum): Removed.
3499 * interface.cs (Interface): Implement IMemberFinder.
3501 * delegate.cs (Delegate): Implement IMemberFinder.
3503 * enum.cs (Enum): Implement IMemberFinder.
3505 * class.cs (TypeContainer): Implement IMemberFinder.
3507 2002-08-12 Martin Baulig <martin@gnome.org>
3509 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
3511 2002-08-12 Martin Baulig <martin@gnome.org>
3513 * ecore.cs (ITypeExpression): New interface for expressions which
3515 (TypeExpression): Renamed to TypeLookupExpression.
3516 (Expression.DoResolve): If we're doing a types-only lookup, the
3517 expression must implement the ITypeExpression interface and we
3518 call DoResolveType() on it.
3519 (SimpleName): Implement the new ITypeExpression interface.
3520 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
3521 hack, the situation that we're only looking up types can't happen
3522 anymore when this method is called. Moved the type lookup code to
3523 DoResolveType() and call it.
3524 (SimpleName.DoResolveType): This ITypeExpression interface method
3525 is now doing the types-only lookup.
3526 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
3527 (ResolveFlags): Added MaskExprClass.
3529 * expression.cs (MemberAccess): Implement the ITypeExpression
3531 (MemberAccess.DoResolve): Added support for a types-only lookup
3532 when we're called via ITypeExpression.DoResolveType().
3533 (ComposedCast): Implement the ITypeExpression interface.
3535 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
3536 Expression.Resolve() with ResolveFlags.Type instead.
3538 2002-08-12 Martin Baulig <martin@gnome.org>
3540 * interface.cs (Interface.Define): Apply attributes.
3542 * attribute.cs (Attribute.ApplyAttributes): Added support for
3543 interface attributes.
3545 2002-08-11 Martin Baulig <martin@gnome.org>
3547 * statement.cs (Block.Emit): Only check the "this" variable if we
3548 do not always throw an exception.
3550 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
3551 whether the property has a set accessor.
3553 2002-08-11 Martin Baulig <martin@gnome.org>
3555 Added control flow analysis support for structs.
3557 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
3558 with control flow analysis turned off.
3559 (IVariable): New interface.
3560 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
3561 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
3562 (FieldExpr.DoResolve): Resolve the instance expression with flow
3563 analysis turned off and do the definite assignment check after the
3564 resolving when we know what the expression will resolve to.
3566 * expression.cs (LocalVariableReference, ParameterReference):
3567 Implement the new IVariable interface, only call the flow analysis
3568 code if ec.DoFlowAnalysis is true.
3569 (This): Added constructor which takes a Block argument. Implement
3570 the new IVariable interface.
3571 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
3572 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
3573 This does the definite assignment checks for struct members.
3575 * class.cs (Constructor.Emit): If this is a non-static `struct'
3576 constructor which doesn't have any initializer, call
3577 Block.AddThisVariable() to tell the flow analysis code that all
3578 struct elements must be initialized before control returns from
3581 * statement.cs (MyStructInfo): New public class.
3582 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
3583 argument to this indexer. If non-zero, check an individual struct
3584 member, not the whole struct.
3585 (FlowBranching.CheckOutParameters): Check struct members.
3586 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
3587 overloaded versions of these methods which take an additional
3588 `int field_idx' argument to check struct members.
3589 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
3590 overloaded versions of these methods which take an additional
3591 `string field_name' argument to check struct member.s
3592 (VariableInfo): Implement the IVariable interface.
3593 (VariableInfo.StructInfo): New public property. Returns the
3594 MyStructInfo instance of the variable if it's a struct or null.
3595 (Block.AddThisVariable): New public method. This is called from
3596 Constructor.Emit() for non-static `struct' constructor which do
3597 not have any initializer. It creates a special variable for the
3598 "this" instance variable which will be checked by the flow
3599 analysis code to ensure that all of the struct's fields are
3600 initialized before control returns from the constructor.
3601 (UsageVector): Added support for struct members. If a
3602 variable/parameter is a struct with N members, we reserve a slot
3603 in the usage vector for each member. A struct is considered fully
3604 initialized if either the struct itself (slot 0) or all its
3605 members are initialized.
3607 2002-08-08 Martin Baulig <martin@gnome.org>
3609 * driver.cs (Driver.MainDriver): Only report an error CS5001
3610 if there were no compilation errors.
3612 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
3613 `UnsafeContext' property to determine whether the parent is in
3614 unsafe context rather than checking the parent's ModFlags:
3615 classes nested in an unsafe class are unsafe as well.
3617 2002-08-08 Martin Baulig <martin@gnome.org>
3619 * statement.cs (UsageVector.MergeChildren): Distinguish between
3620 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
3621 we return. Added test17() and test18() to test-154.cs.
3623 2002-08-08 Martin Baulig <martin@gnome.org>
3625 * typemanager.cs (TypeManager.FilterWithClosure): If we have
3626 Family access, make sure the invoking type isn't a subclass of the
3627 queried type (that'd be a CS1540).
3629 * ecore.cs (Expression.MemberLookup): Added overloaded version of
3630 this method which takes an additional `Type invocation_type'.
3632 * expression.cs (BaseAccess.DoResolve): Use the base type as
3633 invocation and query type.
3634 (MemberAccess.DoResolve): If the lookup failed and we're about to
3635 report a CS0122, try a lookup with the ec.ContainerType - if this
3636 succeeds, we must report a CS1540.
3638 2002-08-08 Martin Baulig <martin@gnome.org>
3640 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
3641 (MethodGroupExpr): Implement the IMemberExpr interface.
3643 * expression (MemberAccess.ResolveMemberAccess): No need to have
3644 any special code for MethodGroupExprs anymore, they're now
3647 2002-08-08 Martin Baulig <martin@gnome.org>
3649 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
3650 Family, FamANDAssem and FamORAssem permissions.
3651 (TypeManager.IsSubclassOrNestedChildOf): New public method.
3653 2002-08-08 Martin Baulig <martin@gnome.org>
3655 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
3656 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
3659 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
3661 * driver.cs: implemented /resource option to embed managed resources.
3663 2002-08-07 Martin Baulig <martin@gnome.org>
3665 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
3666 (FieldBase.HasFieldInitializer): New public property.
3667 (FieldBase.GetInitializerExpression): New public method. Resolves and
3668 returns the field initializer and makes sure it is only resolved once.
3669 (TypeContainer.EmitFieldInitializers): Call
3670 FieldBase.GetInitializerExpression to get the initializer, this ensures
3671 that it isn't resolved multiple times.
3673 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
3674 the resolving process (SimpleName/MemberLookup) that we're currently
3675 emitting a field initializer (which must not access any instance members,
3676 this is an error CS0236).
3678 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
3679 argument, if the `IsFieldInitializer' flag is set, we must report and
3680 error CS0236 and not an error CS0120.
3682 2002-08-07 Martin Baulig <martin@gnome.org>
3684 * ecore.cs (IMemberExpr): New public interface.
3685 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
3686 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
3687 if the expression is an IMemberExpr.
3689 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
3690 to be null, implicitly default to `this' if we're non-static in
3691 this case. Simplified the code a lot by using the new IMemberExpr
3692 interface. Also fixed bug #28176 here.
3694 2002-08-06 Martin Baulig <martin@gnome.org>
3696 * cs-parser.jay (SimpleLookup): Removed. We need to create
3697 ParameterReferences during semantic analysis so that we can do a
3698 type-only search when resolving Cast, TypeOf and SizeOf.
3699 (block): Pass the `current_local_parameters' to the Block's
3702 * class.cs (ConstructorInitializer): Added `Parameters parameters'
3703 argument to the constructor.
3704 (ConstructorInitializer.Resolve): Create a temporary implicit
3705 block with the parameters.
3707 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
3708 references here if we aren't doing a type-only search.
3710 * statement.cs (Block): Added constructor which takes a
3711 `Parameters parameters' argument.
3712 (Block.Parameters): New public property.
3714 * support.cs (InternalParameters.Parameters): Renamed `parameters'
3715 to `Parameters' and made it public readonly.
3717 2002-08-06 Martin Baulig <martin@gnome.org>
3719 * ecore.cs (Expression.Warning): Made this public as well.
3721 * report.cs (Report.Debug): Print the contents of collections.
3723 2002-08-06 Martin Baulig <martin@gnome.org>
3725 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
3726 used to tell Resolve() which kinds of expressions it may return.
3727 (Expression.Resolve): Added overloaded version of this method which
3728 takes a `ResolveFlags flags' argument. This can be used to tell
3729 Resolve() which kinds of expressions it may return. Reports a
3731 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
3732 ResolveFlags.SimpleName.
3733 (Expression.Error118): Added overloaded version of this method which
3734 takes a `ResolveFlags flags' argument. It uses the flags to determine
3735 which kinds of expressions are allowed.
3737 * expression.cs (Argument.ResolveMethodGroup): New public method.
3738 Resolves an argument, but allows a MethodGroup to be returned.
3739 This is used when invoking a delegate.
3741 * TODO: Updated a bit.
3743 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
3745 Fixed compilation with csc.
3747 * ecore.cs: Expression.Error made public. Is this correct? Should
3748 Warning be made public too?
3750 * expression.cs: use ea.Location instead of ea.loc.
3751 [FIXME: Filed as bug #28607: MCS must report these errors.]
3753 2002-08-06 Martin Baulig <martin@gnome.org>
3755 * ecore.cs (Expression.loc): Moved the location here instead of
3756 duplicating it in all derived classes.
3757 (Expression.Location): New public property.
3758 (Expression.Error, Expression.Warning): Made them non-static and
3759 removed the location argument.
3760 (Expression.Warning): Added overloaded version which takes an
3761 `int level' argument.
3762 (Expression.Error118): Make this non-static and removed the
3763 expression and location arguments.
3764 (TypeExpr): Added location argument to the constructor.
3766 * expression.cs (StaticCallExpr): Added location argument to
3768 (Indirection, PointerArithmetic): Likewise.
3769 (CheckedExpr, UnCheckedExpr): Likewise.
3770 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
3771 (StringPtr): Likewise.
3774 2002-08-05 Martin Baulig <martin@gnome.org>
3776 * expression.cs (BaseAccess.DoResolve): Actually report errors.
3778 * assign.cs (Assign.DoResolve): Check whether the source
3779 expression is a value or variable.
3781 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
3782 while resolving the corresponding blocks.
3784 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
3785 an error, don't silently return null.
3787 * statement.cs (Block.AddVariable): Do the error reporting here
3788 and distinguish between CS0128 and CS0136.
3789 (Block.DoResolve): Report all unused labels (warning CS0164).
3790 (LabeledStatement): Pass the location to the constructor.
3791 (LabeledStatement.HasBeenReferenced): New property.
3792 (LabeledStatement.Resolve): Set it to true here.
3794 * statement.cs (Return.Emit): Return success even after reporting
3795 a type mismatch error (CS0126 or CS0127), this is what csc does and
3796 it avoids confusing the users with any consecutive errors.
3798 2002-08-05 Martin Baulig <martin@gnome.org>
3800 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
3802 * const.cs (Const.LookupConstantValue): Catch circular definitions.
3804 * expression.cs (MemberAccess.DoResolve): Silently return if an
3805 error has already been reported.
3807 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
3808 error has already been reported.
3810 2002-08-05 Martin Baulig <martin@gnome.org>
3812 * statement.cs (UsageVector): Only initialize the `parameters'
3813 vector if we actually have any "out" parameters.
3815 2002-08-05 Martin Baulig <martin@gnome.org>
3817 * expression.cs (Binary.ResolveOperator): When combining delegates,
3818 they must have the same type.
3820 2002-08-05 Martin Baulig <martin@gnome.org>
3822 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
3823 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
3824 work with the ms runtime and we also don't need it: if we're a
3825 PropertyBuilder and not in the `indexer_arguments' hash, then we
3826 are a property and not an indexer.
3828 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
3829 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
3830 since the latter one doesn't work with the ms runtime.
3832 2002-08-03 Martin Baulig <martin@gnome.org>
3834 Fixed bugs #27998 and #22735.
3836 * class.cs (Method.IsOperator): New public field.
3837 (Method.CheckBase): Report CS0111 if there's already a method
3838 with the same parameters in the current class. Report CS0508 when
3839 attempting to change the return type of an inherited method.
3840 (MethodData.Emit): Report CS0179 if a method doesn't have a body
3841 and it's not marked abstract or extern.
3842 (PropertyBase): New abstract base class for Property and Indexer.
3843 (PropertyBase.CheckBase): Moved here from Property and made it work
3845 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
3846 the same so we can reuse it there.
3847 (Property, Indexer): Derive from PropertyBase.
3848 (MethodSignature.inheritable_property_signature_filter): New delegate
3849 to find properties and indexers.
3851 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
3852 argument and improved error reporting.
3854 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
3855 EmptyReadOnlyParameters and made it a property.
3857 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
3858 version of this method which takes a `PropertyInfo indexer'.
3859 (TypeManager.RegisterIndexer): New method.
3861 * class.cs: Added myself as author of this file :-)
3863 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
3865 * class.cs: fixed compilation on windoze.
3867 2002-08-03 Martin Baulig <martin@gnome.org>
3869 * interface.cs (Interface.GetInterfaceBases): Check whether all
3870 base interfaces are at least as accessible than the current one.
3872 * class.cs (TypeContainer.GetClassBases): Check whether base types
3873 are at least as accessible than the current type.
3874 (TypeContainer.AsAccessible): Implemented and made non-static.
3875 (MemberBase.CheckParameters): Report errors if the accessibility
3878 * delegate.cs (Delegate.Delegate): The default visibility is
3879 internal for top-level types and private for nested types.
3880 (Delegate.Define): Report errors if the accessibility checks fail.
3882 * enum.cs (Enum.Enum): The default visibility is internal for
3883 top-level types and private for nested types.
3884 (Enum.DefineType): Compute the correct visibility.
3886 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
3887 function which takes a `bool is_toplevel' instead of a TypeContainer.
3889 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
3892 2002-08-02 Martin Baulig <martin@gnome.org>
3894 * expression.cs (LocalVariableReferenc): Added constructor which
3895 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
3896 (LocalVariableReference.IsReadOnly): New property.
3897 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
3898 variable is readonly, use our own readonly flag to do this; you can
3899 use the new constructor to get a writable reference to a read-only
3902 * cs-parser.jay (foreach_statement, using_statement): Get a writable
3903 reference to the local variable.
3905 2002-08-01 Miguel de Icaza <miguel@ximian.com>
3907 * rootcontext.cs (ResolveCore): Also include System.Exception
3909 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
3910 we reach an EmptyStatement.
3912 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
3915 * expression.cs (Binary.ResolveOperator): Check error result in
3918 use brtrue/brfalse directly and avoid compares to null.
3920 2002-08-02 Martin Baulig <martin@gnome.org>
3922 * class.cs (TypeContainer.Define): Define all nested interfaces here.
3923 Fixes bug #28407, added test-155.cs.
3925 2002-08-01 Martin Baulig <martin@gnome.org>
3927 * class.cs (Event.EmitDefaultMethod): Make this work with static
3928 events. Fixes #28311, added verify-3.cs.
3930 2002-08-01 Martin Baulig <martin@gnome.org>
3932 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
3933 `is_disposable' fields.
3934 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
3935 `hm.is_disposable' if we're using the collection pattern.
3936 (Foreach.EmitCollectionForeach): Use the correct type for the
3937 enumerator's local variable, only emit the try/finally block if
3938 necessary (fixes #27713).
3940 2002-08-01 Martin Baulig <martin@gnome.org>
3942 * ecore.cs (Expression.report118): Renamed to Error118 and made
3945 * statement.cs (Throw.Resolve): Check whether the expression is of
3946 the correct type (CS0118) and whether the type derives from
3947 System.Exception (CS0155).
3948 (Catch.Resolve): New method. Do the type lookup here and check
3949 whether it derives from System.Exception (CS0155).
3950 (Catch.CatchType, Catch.IsGeneral): New public properties.
3952 * typemanager.cs (TypeManager.exception_type): Added.
3954 2002-07-31 Miguel de Icaza <miguel@ximian.com>
3956 * driver.cs: Updated About function.
3958 2002-07-31 Martin Baulig <martin@gnome.org>
3960 Implemented Control Flow Analysis.
3962 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
3963 (EmitContext.CurrentBranching): Added.
3964 (EmitContext.StartFlowBranching): Added.
3965 (EmitContext.EndFlowBranching): Added.
3966 (EmitContext.KillFlowBranching): Added.
3967 (EmitContext.IsVariableAssigned): Added.
3968 (EmitContext.SetVariableAssigned): Added.
3969 (EmitContext.IsParameterAssigned): Added.
3970 (EmitContext.SetParameterAssigned): Added.
3971 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
3972 Added control flow analysis stuff here.
3974 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
3975 resolve the expression as lvalue.
3976 (LocalVariableReference.DoResolve): Check whether the variable has
3977 already been assigned.
3978 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
3979 the parameter as assigned here.
3980 (ParameterReference.DoResolve): Check whether the parameter has already
3982 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
3983 expression as lvalue.
3985 * statement.cs (FlowBranching): New class for the flow analysis code.
3986 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
3987 (LabeledStatement.IsDefined): New public property.
3988 (LabeledStatement.AddUsageVector): New public method to tell flow
3989 analyis that the label may be reached via a forward jump.
3990 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
3992 (VariableInfo.Number): New public field. This is used by flow analysis
3993 to number all locals of a block.
3994 (Block.CountVariables): New public property. This is the number of
3995 local variables in this block (including the locals from all parent
3997 (Block.EmitMeta): Number all the variables.
3999 * statement.cs: Added flow analysis support to all classes.
4001 2002-07-31 Martin Baulig <martin@gnome.org>
4003 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
4004 To get debugging messages, compile mcs with /define:MCS_DEBUG and
4005 then use this argument.
4007 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
4009 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
4010 use this to specify /define options.
4012 2002-07-29 Martin Baulig <martin@gnome.org>
4014 * statement.cs (Fixed): Moved all code that does variable lookups
4015 and resolvings from Emit to Resolve.
4017 * statement.cs (For): Moved all code that does variable lookups
4018 and resolvings from Emit to Resolve.
4020 * statement.cs (Using): Moved all code that does variable lookups
4021 and resolvings from Emit to Resolve.
4023 2002-07-29 Martin Baulig <martin@gnome.org>
4025 * attribute.cs (Attribute.Resolve): Explicitly catch a
4026 System.NullReferenceException when creating the
4027 CustromAttributeBuilder and report a different warning message.
4029 2002-07-29 Martin Baulig <martin@gnome.org>
4031 * support.cs (ParameterData.ParameterName): Added method to
4032 get the name of a parameter.
4034 * typemanager.cs (TypeManager.IsValueType): New public method.
4036 2002-07-29 Martin Baulig <martin@gnome.org>
4038 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
4039 is a flag which specifies that it's either ref or out.
4040 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
4041 the out parameter to `out Parameter.Modifier mod', also set the
4042 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
4044 * support.cs (InternalParameters.ParameterModifier): Distinguish
4045 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
4046 Parameter.Modifier.ISBYREF flag if it's either ref or out.
4048 * expression.cs (Argument.GetParameterModifier): Distinguish
4049 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
4050 Parameter.Modifier.ISBYREF flag if it's either ref or out.
4052 2002-07-29 Martin Baulig <martin@gnome.org>
4054 * expression.cs (ParameterReference.ParameterReference): Added
4055 `Location loc' argument to the constructor.
4057 * cs-parser.jay: Pass location to ParameterReference.
4059 2002-07-28 Miguel de Icaza <miguel@ximian.com>
4061 * statement.cs (Try): Initialize the location.
4063 * cs-parser.jay: pass location to Try.
4065 * expression.cs (Unary.Reduce): Change the prototype to return
4066 whether a constant fold could be performed or not. The result is
4067 returned in an out parameters. In the case of Indirection and
4068 AddressOf, we want to perform the full tests.
4070 2002-07-26 Miguel de Icaza <miguel@ximian.com>
4072 * statement.cs (Statement.Emit): Flag dead code.
4074 2002-07-27 Andrew Birkett <andy@nobugs.org>
4076 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
4078 2002-07-27 Martin Baulig <martin@gnome.org>
4080 * class.cs (MethodData.Define): Put back call to
4081 TypeManager.AddMethod(), accidentally commented this out.
4083 * report.cs (Debug): New public method to print debugging information,
4084 this is `[Conditional ("DEBUG")]'.
4086 2002-07-26 Martin Baulig <martin@gnome.org>
4088 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
4089 (switch_statement): Push the current_block to the switch_stack and
4090 pop it again when we're done with the switch.
4091 (switch_section): The new block is a child of the current_block.
4092 Fixes bug #24007, added test-152.cs.
4094 2002-07-27 Martin Baulig <martin@gnome.org>
4096 * expression.cs (Invocation.EmitArguments): When calling a varargs
4097 function with only its fixed arguments, we need to pass an empty
4100 2002-07-27 Martin Baulig <martin@gnome.org>
4102 Mono 0.13 has been released.
4104 2002-07-25 Miguel de Icaza <miguel@ximian.com>
4106 * driver.cs: Rename --resource to --linkres, because that is what
4107 we do currently, we dont support --resource yet.
4109 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
4111 2002-07-25 Martin Baulig <martin@gnome.org>
4113 * class.cs (MethodData): New public class. This is a `method builder'
4114 class for a method or one accessor of a Property/Indexer/Event.
4115 (MethodData.GetMethodFlags): Moved here from MemberBase.
4116 (MethodData.ApplyAttributes): Likewise.
4117 (MethodData.ApplyObsoleteAttribute): Likewise.
4118 (MethodData.ApplyConditionalAttribute): Likewise.
4119 (MethodData.ApplyDllImportAttribute): Likewise.
4120 (MethodData.CheckAbstractAndExternal): Likewise.
4121 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
4122 (MethodData.Emit): Formerly known as Method.Emit().
4123 (MemberBase): Moved everything which was specific to a single
4124 accessor/method to MethodData.
4125 (Method): Create a new MethodData and call Define() and Emit() on it.
4126 (Property, Indexer, Event): Create a new MethodData objects for each
4127 accessor and call Define() and Emit() on them.
4129 2002-07-25 Martin Baulig <martin@gnome.org>
4131 Made MethodCore derive from MemberBase to reuse the code from there.
4132 MemberBase now also checks for attributes.
4134 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
4135 (MemberBase.GetMethodFlags): Moved here from class Method and marked
4137 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
4138 `CallingConventions cc' and `Attributes opt_attrs' arguments.
4139 (MemberBase.ApplyAttributes): New virtual method; applies the
4140 attributes to a method or accessor.
4141 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
4142 (MemberBase.ApplyConditionalAttribute): Likewise.
4143 (MemberBase.ApplyDllImportAttribute): Likewise.
4144 (MemberBase.CheckAbstractAndExternal): Likewise.
4145 (MethodCore.ParameterTypes): This is now a property instead of a
4146 method, it's initialized from DoDefineParameters().
4147 (MethodCore.ParameterInfo): Removed the set accessor.
4148 (MethodCore.DoDefineParameters): New protected virtual method to
4149 initialize ParameterTypes and ParameterInfo.
4150 (Method.GetReturnType): We can now simply return the MemberType.
4151 (Method.GetMethodFlags): Override the MemberBase version and add
4152 the conditional flags.
4153 (Method.CheckBase): Moved some code from Define() here, call
4154 DoDefineParameters() here.
4155 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
4156 here to avoid some larger code duplication.
4157 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
4158 ensure that abstract and external accessors don't declare a body.
4160 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
4161 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
4162 lookup in the attribute's parent classes, so we need to abort as soon
4163 as we found the first match.
4164 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
4165 the attribute has no arguments.
4167 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
4170 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
4172 * cs-parser.jay: reverted previous patch.
4174 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
4176 * cs-parser.jay: fixed bug #22119.
4178 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
4180 * attribute.cs: fixed compilation. The error was:
4181 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
4182 be assigned to before control leaves the current method."
4183 [FIXME: Filed as bug #28186: MCS must report this error.]
4185 2002-07-25 Martin Baulig <martin@gnome.org>
4187 * attribute.cs (Attribute.Conditional_GetConditionName): New static
4188 method to pull the condition name ouf of a Conditional attribute.
4189 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
4190 the obsolete message and error flag out of an Obsolete attribute.
4192 * class.cs (Method.GetMethodFlags): New public method to get the
4193 TypeManager.MethodFlags for this method.
4194 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
4196 (Method.Define): Get and apply the Obsolete and Conditional attributes;
4197 if we're overriding a virtual function, set the new private variable
4198 `parent_method'; call the new TypeManager.AddMethod().
4200 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
4201 the MethodBuilder and the Method in a PtrHashtable.
4202 (TypeManager.builder_to_method): Added for this purpose.
4203 (TypeManager.MethodFlags): Added IsObsoleteError.
4204 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
4205 Obsolete and Conditional arguments in MethodBuilders. If we discover
4206 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
4207 the message from the attribute.
4209 2002-07-24 Martin Baulig <martin@gnome.org>
4211 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
4212 preprocessor directives, ensure that the argument to #define/#undef is
4213 exactly one identifier and that it's actually an identifier.
4215 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
4218 2002-07-24 Martin Baulig <martin@gnome.org>
4220 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
4221 initialize it to TypeManager.object_type in the constructor.
4222 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
4223 of the `hm.get_current' method if we're using the collection pattern.
4224 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
4225 for the explicit conversion to make it work when we're using the collection
4226 pattern and the `Current' property has a different return type than `object'.
4229 2002-07-24 Martin Baulig <martin@gnome.org>
4231 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
4232 does not match, but don't report any errors. This method is called in
4233 order for all methods in a MethodGroupExpr until a matching method is
4234 found, so we don't want to bail out if the first method doesn't match.
4235 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
4236 matches, report the 123. Fixes #28070.
4238 2002-07-24 Martin Baulig <martin@gnome.org>
4240 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
4241 TypeManager.TypeToCoreType() to the top of the method so the
4242 following equality checks will work. Fixes #28107.
4244 2002-07-24 Martin Baulig <martin@gnome.org>
4246 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
4247 operand is of type uint, and the other operand is of type sbyte,
4248 short or int, the operands are converted to type long." -
4249 Actually do what this comment already told us. Fixes bug #28106,
4252 2002-07-24 Martin Baulig <martin@gnome.org>
4254 * class.cs (MethodBase): New abstract class. This is now a base
4255 class for Property, Indexer and Event to avoid some code duplication
4256 in their Define() and DefineMethods() methods.
4257 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
4258 generic methods for Define() and DefineMethods().
4259 (FieldBase): Derive from MemberBase, not MemberCore.
4260 (Property): Derive from MemberBase, not MemberCore.
4261 (Property.DefineMethod): Moved all the code from this method to the
4262 new MethodBase.DefineAccessor(), just call it with appropriate
4264 (Property.Define): Call the new Property.DoDefine(), this does some
4265 sanity checks and we don't need to duplicate the code everywhere.
4266 (Event): Derive from MemberBase, not MemberCore.
4267 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
4268 accessors, this will also make them work with interface events.
4269 (Indexer): Derive from MemberBase, not MemberCore.
4270 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
4271 (Indexer.Define): Use the new MethodBase functions.
4273 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
4274 argument to the constructor.
4275 (Interface.FindMembers): Added support for interface events.
4276 (Interface.PopluateEvent): Implemented.
4278 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
4280 2002-07-22 Miguel de Icaza <miguel@ximian.com>
4282 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
4283 but this is required to check for a method name being the same as
4284 the containing class.
4288 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
4290 * interface.cs: initialize variable.
4292 2002-07-23 Martin Baulig <martin@gnome.org>
4294 Implemented the IndexerName attribute in interfaces.
4296 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
4297 name if this is an explicit interface implementation.
4298 (Indexer.InterfaceIndexerName): New public variable. If we're
4299 implementing an interface indexer, this is the IndexerName in that
4300 interface. Otherwise, it's the IndexerName.
4301 (Indexer.DefineMethod): If we're implementing interface indexer,
4302 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
4303 and Pending.ImplementIndexer methods.
4304 (Indexer.Define): Also define the PropertyBuilder if we're
4305 implementing an interface indexer and this is neither an explicit
4306 interface implementation nor do the IndexerName match the one in
4309 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
4310 If a method is defined here, then we always need to create a proxy
4311 for it. This is used when implementing interface indexers.
4312 (Pending.IsInterfaceIndexer): New public method.
4313 (Pending.ImplementIndexer): New public method.
4314 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
4315 This is used when implementing interface indexers to define a proxy
4317 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
4318 define a proxy if necessary.
4320 * interface.cs (Interface.IndexerName): New public variable.
4321 (Interface.PopulateIndexer): Set the IndexerName.
4322 (Interface.DefineIndexers): New private method. Populate all the
4323 indexers and make sure their IndexerNames match.
4325 * typemanager.cs (IndexerPropertyName): Added support for interface
4328 2002-07-22 Martin Baulig <martin@gnome.org>
4330 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
4331 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
4332 ret if HasReturnLabel.
4333 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
4336 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
4337 and set the ec.LoopBeginTryCatchLevel.
4338 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
4339 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
4340 the current ec.TryCatchLevel, the branch goes out of an exception
4341 block. In this case, we need to use Leave and not Br.
4343 2002-07-22 Martin Baulig <martin@gnome.org>
4345 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
4346 block unless the block does not always return or it is contained in
4347 another try { ... } catch { ... } block. Fixes bug #26506.
4348 Added verify-1.cs to the test suite.
4350 2002-07-22 Martin Baulig <martin@gnome.org>
4352 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
4353 then we do not always return. Fixes bug #24985.
4355 2002-07-22 Martin Baulig <martin@gnome.org>
4357 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
4358 lookup on a per-class level; ie. walk up the class hierarchy until we
4359 found at least one applicable method, then choose the best among them.
4360 Fixes bug #24463 and test-29.cs.
4362 2002-07-22 Martin Baulig <martin@gnome.org>
4364 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
4365 return types of the methods. The return type is not part of the
4366 signature and we must not check it to make the `new' modifier work.
4367 Fixes bug #27999, also added test-147.cs.
4368 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
4370 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
4371 on the method's return type.
4373 2002-07-21 Martin Baulig <martin@gnome.org>
4375 * assign.cs: Make this work if the rightmost source is a constant and
4376 we need to do an implicit type conversion. Also adding a few more tests
4377 to test-38.cs which should have caught this.
4379 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
4380 target in the makefile for this. The makefile.gnu is primarily intended
4381 for end-users who don't want to debug the compiler.
4383 2002-07-21 Martin Baulig <martin@gnome.org>
4385 * assign.cs: Improved the Assign class so it can now handle embedded
4386 assignments (X = Y = Z = something). As a side-effect this'll now also
4387 consume less local variables. test-38.cs now passes with MCS, added
4388 a few new test cases to that test.
4390 2002-07-20 Martin Baulig <martin@gnome.org>
4392 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
4393 instructions. Fixes bug #27977, also added test-146.cs.
4395 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
4397 * cs-tokenizer.cs: fixed getHex ().
4399 2002-07-19 Martin Baulig <martin@gnome.org>
4401 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
4402 not Type.GetType() to lookup the array type. This is needed when
4403 we're constructing an array of a user-defined type.
4404 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
4405 single-dimensional arrays, but also for single-dimensial arrays of
4408 2002-07-19 Martin Baulig <martin@gnome.org>
4410 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
4411 this function is called, it's not allowed to share LocalBuilders
4414 2002-07-19 Martin Baulig <martin@gnome.org>
4416 * expression.cs (Argument.Resolve): Report an error 118 when trying
4417 to pass a type as argument.
4419 2002-07-18 Martin Baulig <martin@gnome.org>
4421 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
4422 Conv_R_Un for the signed `long' type.
4424 2002-07-15 Miguel de Icaza <miguel@ximian.com>
4426 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
4427 `expr' for the temporary result, as that will fail if we do
4428 multiple resolves on the same expression.
4430 2002-07-05 Miguel de Icaza <miguel@ximian.com>
4432 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
4433 ec.TypeContainer for looking up aliases.
4435 * class.cs (TypeContainer): Remove LookupAlias from here.
4437 * decl.cs (DeclSpace); Move here.
4439 2002-07-01 Miguel de Icaza <miguel@ximian.com>
4441 * class.cs (FindMembers): Only call filter if the constructor
4442 bulider is not null.
4444 Also handle delegates in `NestedTypes' now. Now we will perform
4445 type lookups using the standard resolution process. This also
4448 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
4449 This uses Expressions (the limited kind that can be parsed by the
4450 tree) instead of strings.
4452 * expression.cs (ComposedCast.ToString): Implement, used to flag
4453 errors since now we have to render expressions.
4455 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
4458 * ecore.cs (SimpleName.ToString): ditto.
4460 * cs-parser.jay: Instead of using strings to assemble types, use
4461 Expressions to assemble the type (using SimpleName, ComposedCast,
4462 MemberAccess). This should fix the type lookups in declarations,
4463 because we were using a different code path for this.
4465 * statement.cs (Block.Resolve): Continue processing statements
4466 even when there is an error.
4468 2002-07-17 Miguel de Icaza <miguel@ximian.com>
4470 * class.cs (Event.Define): Also remove the `remove' method from
4471 the list of pending items.
4473 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
4474 generate more compact code.
4476 2002-07-17 Martin Baulig <martin@gnome.org>
4478 * const.cs (Const.LookupConstantValue): Add support for constant
4479 `unchecked' and `checked' expressions.
4480 Also adding test case test-140.cs for this.
4482 2002-07-17 Martin Baulig <martin@gnome.org>
4484 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
4485 check whether mi.ReturnType implements the IEnumerator interface; the
4486 `==' and the IsAssignableFrom() will fail in this situation.
4488 2002-07-16 Ravi Pratap <ravi@ximian.com>
4490 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
4493 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
4495 * expression.cs: fixed bug #27811.
4497 2002-07-14 Miguel de Icaza <miguel@ximian.com>
4499 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
4500 Molaro: when we are a ref, the value already contains a pointer
4501 value, do not take the address of it.
4503 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
4504 * removed mb-parser.jay and mb-tokenizer.cs
4506 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
4508 * expression.cs: check against the building corlib void type.
4510 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
4512 * ecore.cs: fix for valuetype static readonly fields: when
4513 initializing them, we need their address, not the address of a copy.
4515 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
4517 * typemanager.cs: register also enum_type in corlib.
4519 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
4521 * class.cs: allow calling this (but not base) initializers in structs.
4523 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
4525 * ecore.cs: make sure we compare against the building base types
4528 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
4530 * typemanager.cs: fix TypeToCoreType() to handle void and object
4531 (corlib gets no more typerefs after this change).
4533 2002-07-12 Miguel de Icaza <miguel@ximian.com>
4535 * expression.cs (ArrayCreation.EmitArrayArguments): use
4536 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
4538 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
4539 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
4540 array indexes, the runtime actually forbids them.
4542 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
4543 for array arguments here.
4545 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
4546 instead of the default for ValueTypes.
4548 (New.DoEmit): Use IsValueType instead of
4549 IsSubclassOf (value_type)
4550 (New.DoResolve): ditto.
4551 (Invocation.EmitCall): ditto.
4553 * assign.cs (Assign): ditto.
4555 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
4556 Statements *are* currently doing part of their resolution during
4559 Expressions do always resolve during resolve, but statements are
4560 only required to propagate resolution to their children.
4562 2002-07-11 Miguel de Icaza <miguel@ximian.com>
4564 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
4566 (LoadAssembly): Do not add the dll if it is already specified
4568 (MainDriver): Add the System directory to the link path at the end,
4569 after all the other -L arguments.
4571 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
4572 wrong opcode for loading bytes and bools (ldelem.i1 instead of
4573 ldelem.u1) and using the opposite for sbytes.
4575 This fixes Digger, and we can finally run it.
4577 * driver.cs (UnixParseOption): Move the option parsing here.
4578 (CSCParseOption): Implement CSC-like parsing of options.
4580 We now support both modes of operation, the old Unix way, and the
4581 new CSC-like way. This should help those who wanted to make cross
4584 The only thing broken is that /r:, /reference: and /lib: are not
4585 implemented, because I want to make those have the same semantics
4586 as the CSC compiler has, and kill once and for all the confussion
4587 around this. Will be doing this tomorrow.
4589 * statement.cs (Unsafe.Resolve): The state is checked during
4590 resolve, not emit, so we have to set the flags for IsUnsfe here.
4592 2002-07-10 Miguel de Icaza <miguel@ximian.com>
4594 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
4595 not catch the Error_ObjectRefRequired in SimpleName (as it is
4596 possible to have a class/instance variable name that later gets
4597 deambiguated), we have to check this here.
4599 2002-07-10 Ravi Pratap <ravi@ximian.com>
4601 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
4602 make static and put into Expression.
4604 (Event.Define): Register the private field of the event with the
4605 TypeManager so that GetFieldFromEvent can get at it.
4607 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
4608 keep track of the private field associated with an event which
4611 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
4614 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
4616 2002-07-10 Miguel de Icaza <miguel@ximian.com>
4618 * expression.cs (Binary.EmitBranchable): this routine emits the
4619 Binary expression in a branchable context. This basically means:
4620 we need to branch somewhere, not just get the value on the stack.
4622 This works together with Statement.EmitBoolExpression.
4624 * statement.cs (Statement.EmitBoolExpression): Use
4627 2002-07-09 Miguel de Icaza <miguel@ximian.com>
4629 * statement.cs (For): Reduce the number of jumps in loops.
4631 (For): Implement loop inversion for the For statement.
4633 (Break): We can be breaking out of a Try/Catch controlled section
4634 (foreach might have an implicit try/catch clause), so we need to
4635 use Leave instead of Br.
4637 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
4638 now). If the instace expression supports IMemoryLocation, we use
4639 the AddressOf method from the IMemoryLocation to extract the
4640 address instead of emitting the instance.
4642 This showed up with `This', as we were emitting the instance
4643 always (Emit) instead of the Address of This. Particularly
4644 interesting when This is a value type, as we dont want the Emit
4645 effect (which was to load the object).
4647 2002-07-08 Miguel de Icaza <miguel@ximian.com>
4649 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
4651 * statement.cs (Checked): Set the CheckedState during the resolve
4652 process too, as the ConvCast operations track the checked state on
4653 the resolve process, and not emit.
4655 * cs-parser.jay (namespace_member_declaration): Flag that we have
4656 found a declaration when we do. This is used to flag error 1529
4658 * driver.cs: Report ok when we display the help only.
4660 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
4662 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
4664 2002-07-04 Miguel de Icaza <miguel@ximian.com>
4666 * cs-tokenizer.cs (define): We also have to track locally the
4667 defines. AllDefines is just used for the Conditional Attribute,
4668 but we also need the local defines for the current source code.
4670 2002-07-03 Miguel de Icaza <miguel@ximian.com>
4672 * statement.cs (While, For, Do): These loops can exit through a
4673 Break statement, use this information to tell whether the
4674 statement is the last piece of code.
4676 (Break): Flag that we break.
4678 * codegen.cs (EmitContexts): New `Breaks' state variable.
4680 2002-07-03 Martin Baulig <martin@gnome.org>
4682 * class.cs (TypeContainer.MethodModifiersValid): Allow override
4683 modifiers in method declarations in structs. Otherwise, you won't
4684 be able to override things like Object.Equals().
4686 2002-07-02 Miguel de Icaza <miguel@ximian.com>
4688 * class.cs (Method, Property, Indexer): Do not allow the public
4689 modifier to be used in explicit interface implementations.
4691 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
4692 override modifiers in method declarations in structs
4694 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
4696 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
4697 integer or real overflow, report an error
4699 2002-07-02 Martin Baulig <martin@gnome.org>
4701 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
4702 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
4703 to tell the runtime about our newly created System.Object and
4704 System.ValueType types.
4706 2002-07-02 Miguel de Icaza <miguel@ximian.com>
4708 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
4709 struct instead of Ldarg/Starg.
4711 2002-07-02 Martin Baulig <martin@gnome.org>
4713 * expression.cs (Indirection.Indirection): Call
4714 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
4716 2002-07-02 Martin Baulig <martin@gnome.org>
4718 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
4719 ValueType, call TypeManager.TypeToCoreType() on it.
4720 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
4721 the OpCodes.Newarr argument.
4723 2002-07-02 Martin Baulig <martin@gnome.org>
4725 * expression.cs (Invocation.EmitCall): When compiling corlib,
4726 replace all calls to the system's System.Array type to calls to
4727 the newly created one.
4729 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
4730 System.Array methods.
4731 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
4732 from the system's System.Array type which must be replaced.
4734 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
4736 * typemanager.cs: load unverifiable_code_ctor so we can build
4737 corlib using the correct type. Avoid using GetTypeCode() with
4739 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
4740 TypeManager.object_type to allow building corlib.
4742 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
4744 * ecore.cs: handle System.Enum separately in LoadFromPtr().
4746 2002-07-01 Martin Baulig <martin@gnome.org>
4748 * class.cs: Make the last change actually work, we need to check
4749 whether `ifaces != null' to avoid a crash.
4751 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
4753 * class.cs: when we build structs without fields that implement
4754 interfaces, we need to add the interfaces separately, since there is
4755 no API to both set the size and add the interfaces at type creation
4758 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
4760 * expression.cs: the dimension arguments to the array constructors
4761 need to be converted if they are a long.
4763 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
4765 * class.cs: don't emit ldarg.0 if there is no parent constructor
4766 (fixes showstopper for corlib).
4768 2002-06-29 Martin Baulig <martin@gnome.org>
4770 MCS now compiles corlib on GNU/Linux :-)
4772 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
4773 ie. check for MethodImplOptions.InternalCall.
4775 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
4776 and TypeManager.attribute_type are null, so we must explicitly check
4777 whether parent is not null to find out whether it's an attribute type.
4778 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
4779 and SetBuilder, not only if the property is neither abstract nor external.
4780 This is necessary to set the MethodImplOptions on the accessor methods.
4781 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
4782 SetBuilder, see Property.Emit().
4784 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
4785 populate "System.Object", "System.ValueType" and "System.Attribute" since
4786 they've already been populated from BootCorlib_PopulateCoreTypes().
4788 2002-06-29 Martin Baulig <martin@gnome.org>
4790 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
4791 is the NullLiteral, we also need to make sure that target_type is not
4794 2002-06-29 Martin Baulig <martin@gnome.org>
4796 * rootcontext.cs (RootContext.ResolveCore): We must initialize
4797 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
4798 before calling BootstrapCorlib_ResolveDelegate ().
4800 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
4802 * statement.cs: fixed build-breaker. All tests passed ok.
4804 2002-06-27 Martin Baulig <martin@gnome.org>
4806 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
4807 for System.Decimal when compiling corlib.
4809 2002-06-27 Martin Baulig <martin@gnome.org>
4811 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
4812 switch blocks which contain nothing but a default clause.
4814 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
4816 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
4818 2002-06-27 Martin Baulig <martin@gnome.org>
4820 * ecore.cs (PropertyExpr.PropertyExpr): Call
4821 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
4823 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
4824 is already a TypeBuilder.
4826 2002-06-27 Martin Baulig <martin@gnome.org>
4828 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
4829 `target_type == TypeManager.array_type', not IsAssignableFrom() in
4830 the "from an array-type to System.Array" case. This makes it work
4831 when compiling corlib.
4833 2002-06-27 Martin Baulig <martin@gnome.org>
4835 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
4836 non-static PropertyExpr, set its InstanceExpression. This makes
4837 the `ICollection.Count' property work in System/Array.cs.
4839 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
4841 * driver.cs: Made error handling more consistent. Errors now
4842 tracked by Report class, so many methods which used to return int
4843 now return void. Main() now prints success/failure and
4844 errors/warnings message.
4846 Renamed '--probe' compiler argument to '--expect-error'. Removed
4847 the magic number return values (123 and 124). Now, if the
4848 expected error occurs, the compiler exits with success (exit value
4849 0). If the compilation completes without seeing that particular
4850 error, the compiler exits with failure (exit value 1). The
4851 makefile in mcs/errors has been changed to handle the new behaviour.
4853 * report.cs: Made 'expected error' number a property and renamed
4854 it from 'Probe' to 'ExpectedError'.
4856 * genericparser.cs: Removed error handling support, since it is
4857 now all done by Report class.
4859 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
4860 class, so parse() no longer returns an int.
4862 * namespace.cs: Use Report.Error instead of GenericParser.error
4864 2002-06-22 Miguel de Icaza <miguel@ximian.com>
4866 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
4867 TypeContainer.AddOperator): At the front of the list put the
4868 explicit implementations, so they get resolved/defined first.
4870 2002-06-21 Miguel de Icaza <miguel@ximian.com>
4872 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
4873 interface type is implemented by this TypeContainer. Used during
4874 explicit interface implementation.
4876 (Property.Define, Indexer.Define, Method.Define): Validate that
4877 the given interface in the explicit implementation is one of the
4878 base classes for the containing type.
4880 Also if we are explicitly implementing an interface, but there is
4881 no match in the pending implementation table, report an error.
4883 (Property.Define): Only define the property if we are
4884 not explicitly implementing a property from an interface. Use the
4885 correct name also for those properties (the same CSC uses,
4886 although that is really not needed).
4888 (Property.Emit): Do not emit attributes for explicitly implemented
4889 properties, as there is no TypeBuilder.
4891 (Indexer.Emit): ditto.
4893 Hiding then means that we do not really *implement* a pending
4894 implementation, which makes code fail.
4896 2002-06-22 Martin Baulig <martin@gnome.org>
4898 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
4899 the return value of Object.GetType(). [FIXME: we need to do this whenever
4900 we get a type back from the reflection library].
4902 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
4904 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
4906 2002-06-20 Miguel de Icaza <miguel@ximian.com>
4908 * attribute.cs: Return null if we can not look up the type.
4910 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
4911 the interface types found.
4913 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
4914 interface types found.
4916 * typemanager.cs (GetInterfaces): Make this routine returns alll
4917 the interfaces and work around the lame differences between
4918 System.Type and System.Reflection.Emit.TypeBuilder in the results
4919 result for GetInterfaces.
4921 (ExpandInterfaces): Given an array of interface types, expand and
4922 eliminate repeated ocurrences of an interface. This expands in
4923 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
4926 2002-06-21 Martin Baulig <martin@gnome.org>
4928 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
4931 2002-06-21 Martin Baulig <martin@gnome.org>
4933 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
4934 and called with one of the core types, return the corresponding typebuilder for
4937 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
4940 2002-06-21 Martin Baulig <martin@gnome.org>
4942 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
4943 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
4944 (Expression.ConvertReferenceExplicit): Likewise.
4946 * expression.cs (ElementAccess.DoResolve): Likewise.
4947 (ElementAccess.DoResolveLValue): Likewise.
4949 2002-06-10 Martin Baulig <martin@gnome.org>
4951 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
4952 add the "value" parameter to the parameter list.
4954 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
4957 2002-06-19 Miguel de Icaza <miguel@ximian.com>
4959 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
4960 the argument to an int, uint, long or ulong, per the spec. Also
4961 catch negative constants in array creation.
4963 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
4965 * class.cs: do not allow the same interface to appear twice in
4966 the definition list.
4968 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
4970 * ecore.cs: don't use ldlen with System.Array.
4972 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
4974 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
4976 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
4978 * modifiers.cs: produce correct field attributes for protected
4979 internal. Easy fix so miguel can work on ther harder stuff:-)
4981 2002-06-18 Miguel de Icaza <miguel@ximian.com>
4983 * pending.cs: New file. Move the code from class.cs here.
4984 Support clearning the pending flag for all methods (when not doing
4985 explicit interface implementation).
4987 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
4989 * rootcontext.cs: added a couple more types needed to bootstrap.
4991 2002-06-17 Miguel de Icaza <miguel@ximian.com>
4993 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
4994 constructor in the type, instead of any constructor in the type
4995 hierarchy. Thanks to Paolo for finding this bug (it showed up as
4996 a bug in the Mono runtime when applying the params attribute).
4998 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
4999 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
5001 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
5003 * expression.cs (Unary.ResolveOperator): Use TypeManager
5004 to resolve the type.
5006 2002-06-13 Ravi Pratap <ravi@ximian.com>
5008 * cs-parser.jay (enum_member_declaration): Pass in the attributes
5011 * enum.cs (AddEnumMember): Add support to store the attributes associated
5012 with each member too.
5014 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
5015 field builders too - this takes care of the enum member case.
5017 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
5019 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
5020 address-of operator on both value types and pointers.
5022 2002-06-10 Martin Baulig <martin@gnome.org>
5024 * interface.cs (Interface.PopulateIndexer): Add the indexer's
5025 PropertyBuilder to the `property_builders' list.
5027 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
5028 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
5029 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
5030 find any indexers which are inherited from an interface.
5032 2002-06-09 Martin Baulig <martin@gnome.org>
5034 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
5035 the same type as the constant if necessary. There's also a test-130.cs
5038 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
5040 * typemanager.cs (TypeManager.ChangeType): Previously known as
5041 Enum.ChangeEnumType().
5043 2002-06-09 Martin Baulig <martin@gnome.org>
5045 * expression.cs (Cast.TryReduce): Added support for consts.
5047 2002-06-08 Ravi Pratap <ravi@ximian.com>
5049 * class.cs (Accessor): Hold attributes information so we can pass
5052 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
5053 Modify to pass in attributes attached to the methods.
5055 (add_accessor_declaration, remove_accessor_declaration): Ditto.
5057 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
5058 to handle the Accessor kind :-)
5060 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
5062 2002-06-08 Martin Baulig <martin@gnome.org>
5064 * expression.cs (Unary.TryReduceNegative): Added support for
5067 2002-06-08 Martin Baulig <martin@gnome.org>
5069 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
5070 name can't be found in the `defined_names' - the caller will do a
5071 MemberLookup in this case and thus find methods in System.Enum
5072 such as Enum.IsDefined().
5074 2002-06-08 Martin Baulig <martin@gnome.org>
5076 * enum.cs (Enum.ChangeEnumType): This is a custom version of
5077 Convert.ChangeType() which works with TypeBuilder created types.
5078 (Enum.LookupEnumValue, Enum.Define): Use it here.
5080 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
5081 `TypeBuilder.BaseType != null' check.
5082 (TypeContainer.FindMembers): Only lookup parent members if we
5083 actually have a parent.
5084 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
5085 (ConstructorInitializer.Resolve): Likewise.
5087 * interface.cs (Interface.FindMembers): Added
5088 `TypeBuilder.BaseType != null' check.
5090 * rootcontext.cs (RootContext.ResolveCore): Added
5091 "System.Runtime.CompilerServices.IndexerNameAttribute" to
5092 classes_second_stage.
5094 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
5095 debug_type and trace_type when compiling with --nostdlib.
5097 2002-06-07 Martin Baulig <martin@gnome.org>
5099 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
5100 (AddField): Set it to true when adding a non-static field.
5101 (DefineType): Use `have_nonstatic_fields' to find out whether we
5102 have non-static fields, not `Fields != null'.
5104 2002-06-02 Miguel de Icaza <miguel@ximian.com>
5106 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
5107 dereferencing a null on the static-field code path)
5109 2002-05-30 Martin Baulig <martin@gnome.org>
5111 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
5112 to take command line arguments. Use reflection to call the new
5113 custom `Initialize' function on the symbol writer and pass it the
5114 command line arguments.
5116 * driver.cs (--debug-args): New command line argument to pass command
5117 line arguments to the symbol writer.
5119 2002-05-28 Miguel de Icaza <miguel@ximian.com>
5121 * assign.cs (DoResolve): Forgot to do the implicit conversion to
5122 the target type for indexers and properties. Thanks to Joe for
5125 2002-05-27 Miguel de Icaza <miguel@ximian.com>
5127 * typemanager.cs (MethodFlags): returns the method flags
5128 (Obsolete/ShouldIgnore) that control warning emission and whether
5129 the invocation should be made, or ignored.
5131 * expression.cs (Invocation.Emit): Remove previous hack, we should
5132 not do this on matching a base type, we should do this based on an attribute
5134 Only emit calls to System.Diagnostics.Debug and
5135 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
5136 on the command line.
5138 * rootcontext.cs: Global settings for tracing and debugging.
5140 * cs-tokenizer.cs (define): New utility function to track
5141 defines. Set the global settings for TRACE and DEBUG if found.
5143 2002-05-25 Ravi Pratap <ravi@ximian.com>
5145 * interface.cs (Populate*): Pass in the TypeContainer as well as
5146 the DeclSpace as parameters so that we can create EmitContexts and
5147 then use that to apply attributes etc.
5149 (PopulateMethod, PopulateEvent, PopulateProperty)
5150 (PopulateIndexer): Apply attributes everywhere.
5152 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
5155 (ApplyAttributes): Update accordingly.
5157 We now apply interface attributes for all members too.
5159 2002-05-26 Miguel de Icaza <miguel@ximian.com>
5161 * class.cs (Indexer.Define); Correctly check if we are explicit
5162 implementation (instead of checking the Name for a ".", we
5163 directly look up if the InterfaceType was specified).
5165 Delay the creation of the PropertyBuilder.
5167 Only create the PropertyBuilder if we are not an explicit
5168 interface implementation. This means that explicit interface
5169 implementation members do not participate in regular function
5170 lookups, and hence fixes another major ambiguity problem in
5171 overload resolution (that was the visible effect).
5173 (DefineMethod): Return whether we are doing an interface
5176 * typemanager.cs: Temporary hack until we get attributes in
5177 interfaces (Ravi is working on that) and we get IndexerName
5178 support in interfaces.
5180 * interface.cs: Register the indexers as properties.
5182 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
5183 warning, I have verified that this is a bug in the .NET runtime
5184 (JavaScript suffers of the same problem).
5186 * typemanager.cs (MemberLookup): When looking up members for
5187 interfaces, the parent of an interface is the implicit
5188 System.Object (so we succeed in searches of Object methods in an
5189 interface method invocation. Example: IEnumerable x; x.ToString
5192 2002-05-25 Miguel de Icaza <miguel@ximian.com>
5194 * class.cs (Event): Events should also register if they do
5195 implement the methods that an interface requires.
5197 * typemanager.cs (MemberLookup); use the new GetInterfaces
5200 (GetInterfaces): The code used to lookup interfaces for a type is
5201 used in more than one place, factor it here.
5203 * driver.cs: Track the errors at the bottom of the file, we kept
5206 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
5207 instance if the method we are calling is static!
5209 2002-05-24 Miguel de Icaza <miguel@ximian.com>
5211 * attribute.cs (ApplyAttributes): Make this function filter out
5212 the IndexerName attribute (as that attribute in reality is never
5213 applied) and return the string constant for the IndexerName
5216 * class.cs (TypeContainer.Emit): Validate that all the indexers
5217 have the same IndexerName attribute, and if so, set the
5218 DefaultName attribute on the class.
5220 * typemanager.cs: The return value might contain other stuff (not
5221 only methods). For instance, consider a method with an "Item"
5222 property and an Item method.
5224 * class.cs: If there is a problem with the parameter types,
5227 2002-05-24 Ravi Pratap <ravi@ximian.com>
5229 * ecore.cs (ImplicitConversionExists): Wrapper function which also
5230 looks at user defined conversion after making a call to
5231 StandardConversionExists - we need this for overload resolution.
5233 * expression.cs : Update accordingly the various method calls.
5235 This fixes 2 bugs filed against implicit user defined conversions
5237 2002-05-22 Miguel de Icaza <miguel@ximian.com>
5239 * statement.cs: Track the result of the assignment.
5241 2002-05-21 Miguel de Icaza <miguel@ximian.com>
5243 * expression.cs (MemberAccess): Improved error reporting for
5244 inaccessible members.
5246 2002-05-22 Martin Baulig <martin@gnome.org>
5248 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
5249 itself with debugging support.
5251 2002-05-22 Martin Baulig <martin@gnome.org>
5253 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
5254 Removed, this isn't needed anymore.
5256 2002-05-20 Martin Baulig <martin@gnome.org>
5258 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
5259 be underlying type for an enum.
5261 2002-05-20 Miguel de Icaza <miguel@ximian.com>
5263 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
5264 that splits out the loading of just the core types.
5266 * rootcontext.cs (ResolveCore): Split the struct resolution in
5267 two, so we can load the enumeration underlying types before any
5270 * expression.cs (Is): Bandaid until we fix properly Switch (see
5271 bug #24985 for details).
5273 * typemanager.cs (ImplementsInterface): The hashtable will contain
5274 a null if there are no interfaces implemented.
5276 2002-05-18 Miguel de Icaza <miguel@ximian.com>
5278 * cs-parser.jay (indexer_declarator): It is fine to have array
5281 2002-05-17 Miguel de Icaza <miguel@ximian.com>
5283 * typemanager.cs: (RegisterBuilder): New function used to register
5284 TypeBuilders that implement interfaces. Since
5285 TypeBuilder.GetInterfaces (as usual) does not work with lame
5287 (AddUserType): register interfaces.
5289 (ImplementsInterface): Use the builder_to_ifaces hash if we are
5290 dealing with TypeBuilder. Also, arrays are showing up as
5291 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
5292 methods can not be invoked on them!
5294 * ecore.cs (ExplicitReferenceConversionExists): Made public.
5295 (ImplicitReferenceConversionExists): Split out from
5296 StandardConversionExists.
5298 * expression.cs (As): We were only implementing one of the three
5299 cases for the as operator. We now implement them all.
5300 (Is): Implement the various other cases for Is as well.
5302 * typemanager.cs (CACHE): New define used to control if we want or
5303 not the FindMembers cache. Seems to have a negative impact on
5304 performance currently
5306 (MemberLookup): Nested types have full acess to
5307 enclosing type members
5309 Remove code that coped with instance/static returns for events, we
5310 now catch this in RealFindMembers.
5312 (RealFindMembers): only perform static lookup if the instance
5313 lookup did not return a type or an event.
5315 2002-05-17 Miguel de Icaza <miguel@ximian.com>
5317 * assign.cs (CompoundAssign): We pass more semantic information
5318 now to Compound Assignments than we did before: now we have all
5319 the information at hand, and now we resolve the target *before* we
5320 do the expression expansion, which allows the "CacheValue" method
5321 to have the effect we intended (before, a [x] += 1 would generate
5322 two differen ArrayAccess expressions from the ElementAccess,
5323 during the resolution process).
5325 (CompoundAssign.DoResolve): Resolve target and original_source here.
5327 2002-05-16 Miguel de Icaza <miguel@ximian.com>
5329 * expression.cs (ArrayAccess): dropped debugging information.
5331 * typemanager.cs: Small bug fix: I was always returning i_members,
5332 instead of one of i_members or s_members (depending on which had
5335 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
5336 method is invoked before any code generation takes place, and it
5337 is a mechanism to inform that the expression will be invoked more
5338 than once, and that the method should use temporary values to
5339 avoid having side effects
5341 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
5343 * ecore.cs (Expression.CacheTemporaries): Provide empty default
5346 * expression.cs (Indirection, ArrayAccess): Add support for
5347 CacheTemporaries in these two bad boys.
5349 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
5351 (StoreFromPtr): Handle stobj as well.
5353 * expression.cs (UnaryMutator): Share more code.
5355 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
5356 down: I was not tracking the Filter function as well, which
5357 was affecting the results of the cache.
5359 2002-05-15 Miguel de Icaza <miguel@ximian.com>
5361 * attribute.cs: Remove the hack to handle the CharSet property on
5364 2002-05-14 Miguel de Icaza <miguel@ximian.com>
5366 * attribute.cs (DoResolve): More uglyness, we now only try to
5367 resolve the attribute partially, to extract the CharSet
5368 information (only if we are a StructLayout attribute). Otherwise
5370 (GetExtraTypeInfo): Add some code to conditionally kill in the
5371 future this. I am more and more convinced that the .NET
5372 framework has special code to handle the attribute setting on
5375 * expression.cs (IsParamsMethodApplicable): Revert my previous
5376 foreach change here, it was wrong.
5378 2002-05-13 Miguel de Icaza <miguel@ximian.com>
5380 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
5381 (pp_expr): do not abort on unknown input, just return.
5382 (eval): abort if there are pending chars.
5384 * attribute.cs (Attribute.Resolve): Positional parameters are
5385 optional. Deal with that case.
5387 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
5388 the Ansi/Unicode/Auto information for the type.
5390 (TypeContainer.DefineType): instantiate the EmitContext here, as
5391 we will be using it during the type definition (to resolve
5392 attributes) and during the emit phase.
5394 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
5395 to pull type information out of the attributes
5397 (Attribute.Resolve): track the constructor builder, and allow for
5398 multiple invocations (structs and classes will use this).
5400 * ecore.cs (MemberLookupFinal): new version with all the
5401 parameters customizable.
5403 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
5404 constructors. Return if the result value is null (as the error
5405 would have been flagged already by MemberLookupFinal)
5407 Do not allow instances of abstract classes or interfaces to be
5410 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
5411 We have to compare the assembly property here when dealing with
5412 FamANDAssem and Assembly access modifiers, because we might be
5413 creating an assembly from *modules* (that means that we are not
5414 getting TypeBuilders for types defined in other modules that are
5415 part of this assembly).
5417 (Method.Emit): If the method is marked abstract and has a body,
5420 (TypeContainer.DefineMembers): If both the defined member and the
5421 parent name match are methods, then do not emit any warnings: let
5422 the Method.Define routine take care of flagging warnings. But if
5423 there is a mismatch (method overrides something else, or method is
5424 overriwritten by something, then emit warning).
5426 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
5427 set to null, this means `do not check for the return type on the
5430 (Method.Define): set the return type for the method signature to
5431 null, so that we get methods with the same name and parameters and
5432 different return types. This is used to flag warning 114 (you are
5433 hiding a method, and you probably want to use the new/override
5436 * typemanager.cs (MemberLookup): Implemented proper access
5437 control, closing a long standing set of bug reports. The problem
5438 was that the Framework only has two bits: Public and NonPublic,
5439 and NonPublic includes private and protected methods, but we need
5440 to enforce the FamANDAssem, FamOrAssem and Family.
5442 2002-05-11 Miguel de Icaza <miguel@ximian.com>
5444 * statement.cs (GotoCase): Return true: Ammounts to giving up
5445 knowledge on whether we return or not, and letting the other case
5446 be responsible for it.
5448 2002-05-10 Miguel de Icaza <miguel@ximian.com>
5450 * driver.cs: Do not load directories for each file processed, only
5451 do it if there is a pattern.
5453 * ecore.cs: Report readonly assigns here as well, as we might have
5454 been resolved only by MemberAccess.
5456 (SimpleName.SimpleNameResolve): Also be useful for LValue
5457 resolution. We need this to propagate assign to local readonly variables
5459 * typemanager.cs: Use a ptrhashtable for the criteria, because we
5460 do not want to reuse potential criteria memory.
5462 * class.cs (MyEventBuilder): Set reflected_type;
5464 * ecore.cs (Constantify): Added support for constifying bools.
5466 (RootContext.LookupType): Added a cache for values looked up in
5467 the declaration space.
5469 * typemanager.cs (FindMembers): Now is a front-end to
5470 RealFindMembers, and provides a two-level hashtable-based cache to
5473 15% performance improvement: from 22.5 to 19.2 seconds.
5475 * expression.cs (IsParamsMethodApplicable): use foreach.
5476 (Invocation.DoResolve): ditto.
5477 (New.DoResolve): ditto.
5478 (ArrayCreation.DoResolve): ditto.
5480 * ecore.cs (FindMostEncompassingType): use foreach.
5482 * delegate.cs (NewDelegate.DoResolve): Use foreach
5484 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
5485 (RemoveMethods): use foreach.
5487 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
5488 nested foreach statements instead of for, and also break out of
5489 the inner loop once a match is found.
5491 (Invocation.OverloadResolve): Use foreach, simplify the code.
5493 2002-05-08 Miguel de Icaza <miguel@ximian.com>
5495 * cfold.cs (BinaryFold): During an enumeration evaluation context,
5496 we actually unwrap the expression to allow for extra information
5499 * expression.cs: Use Shr_Un on unsigned operations.
5501 2002-05-08 Ravi Pratap <ravi@ximian.com>
5503 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
5504 applicable operators was not being considered correctly. This closes
5505 the bug Miguel reported.
5507 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
5509 * attribute.cs: check that the type derives from System.Attribute
5510 and report the correct error in that case (moved the duplicate code to
5511 its own method, too).
5513 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
5515 * attribute.cs: lookup attribute type name as the spec says: first the
5516 bare attribute name and then name + "Attribute" (nant compiles with
5517 mcs after this fix).
5519 2002-05-07 Miguel de Icaza <miguel@ximian.com>
5521 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
5522 Because of the way we parse things, we should try to see if a
5523 UIntConstant can fit in an integer.
5525 2002-05-07 Ravi Pratap <ravi@ximian.com>
5527 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
5528 when we are in an explicit context.
5530 (ConvertReferenceExplicit): When converting from Iface type S to Class
5531 T make sure the rules are implemented as an OR.
5533 * parameter.cs (ParameterType): Make it a property for now although the
5534 purpose really isn't anything immediate.
5536 * expression.cs (Is*Applicable): Do better checking on the parameter type
5537 of a ref/out parameter. The ones from the system assemblies are already
5538 marked with the correct type so we don't need to do any correction.
5540 * ecore.cs (StandardConversionExists): Conversion from Interface types to
5541 the object type is standard too so include that.
5543 2002-05-06 Miguel de Icaza <miguel@ximian.com>
5545 * ecore.cs (StandardConversionExists): Augment with missing code:
5546 deal with IntConstant, LongConstants and Enumerations.
5548 * assign.cs: Report the error, instead of failing silently
5550 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
5551 typecontainer that they are declared, because the
5552 typecontainer/namespace will have the list of using clauses that
5555 Assembly Attributes were escaping the normal registration
5558 (EmitCode): Apply attributes within an EmitContext that represents
5559 the container they were declared on.
5561 * cs-parser.jay: Track bases for structs. How did I get this wrong?
5563 2002-05-06 Ravi Pratap <ravi@ximian.com>
5565 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
5566 Revamp completely - make much cleaner as we now operate only
5569 (FindMostSpecificSource, FindMostSpecificTarget): New methods
5570 to implement the logic detailed in the spec more correctly.
5572 (UserDefinedConversion): Update accordingly.
5574 2002-05-06 Miguel de Icaza <miguel@ximian.com>
5576 * statement.cs: Return flow analysis information up.
5578 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
5581 (token): Do not consume an extra character before calling
5584 2002-05-06 Piers Haken <piersh@friskit.com>
5586 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
5588 2002-05-06 Miguel de Icaza <miguel@ximian.com>
5590 * class.cs (Constructor.Emit): Set the IsStatic flag in the
5591 EmitContext during the instance constructor initializer
5592 resolution, to stop access to instance variables.
5594 This is mandated by the spec, last paragraph of the `constructor
5595 initializers' section.
5597 2002-05-05 Miguel de Icaza <miguel@ximian.com>
5599 * cs-parser.jay, class.cs (Accessor): new class used to represent
5600 an accessor (get or set). In the past we used `null' to represent
5601 a missing accessor. But this is ambiguous because there was no
5602 way to tell in abstract indexers/properties if one of them was
5605 Now there is a way of addressing that.
5607 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
5608 instead of FindMembers.
5610 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
5611 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
5613 * attribute.cs: Treat indexers and properties as the same in terms
5614 of applying attributes
5616 * ecore.cs (FindMostEncompassedType): Use statically initialized
5617 EmptyExpressions()s like we do elsewhere to avoid creating useless
5618 objects (and we take this out of the tight loop).
5620 (GetConversionOperators): Move the code to extract the actual
5621 operators to a separate routine to clean things up.
5623 2002-05-04 Miguel de Icaza <miguel@ximian.com>
5625 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
5626 events are always registered FieldBuilders.
5628 * class.cs (FieldBase): New class shared by Fields
5630 * delegate.cs: If we are a toplevel delegate, use our full name.
5631 If we are a nested delegate, then only use our tail name.
5633 2002-05-02 Ravi Pratap <ravi@ximian.com>
5635 * expression.cs (IsApplicable): Ensure that we add the "&" to
5636 ref/out types before comparing it with the type of the argument.
5638 (IsParamsMethodApplicable): Ditto.
5640 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
5643 * delegate.cs : Handle the case when we have more than one applicable
5644 method. Flag an error only when we finish checking all.
5646 2002-05-02 Miguel de Icaza <miguel@ximian.com>
5648 * expression.cs: Add support for boolean static initializers.
5650 2002-05-01 Miguel de Icaza <miguel@ximian.com>
5652 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
5654 * parameter.cs (ComputeParameterTypes,
5655 ComputeAndDefineParameterTypes): Better error handling: now we
5656 clear the `types' cache if we fail during any of the type lookups.
5657 We also return the status code correctly to our caller
5659 * delegate.cs: If we fail to define a delegate, abort the extra
5662 * expression.cs (Binary.ResolveOperator): for
5663 operator==(object,object) and operator !=(object, object) we also
5664 have to verify that there is an implicit conversion from one to
5667 (ArrayAccess.DoResolve): Array Access can operate on
5670 2002-04-30 Miguel de Icaza <miguel@ximian.com>
5672 * assign.cs (CompoundAssign): A new class used as a "flag" that
5673 the assignment actually is happening as part of a compound
5674 assignment operator.
5676 During compound assignment, a few new rules exist to enable things
5683 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
5684 to the type of x) if y is implicitly convertible to the type of x,
5685 and the operator is a builtin operator and the return type of the
5686 operator is explicitly convertible to the type of x.
5688 * rootcontext.cs: Reset warning level to 2. 4 catches various
5689 "interesting" features in mcs, we must clean this up at some
5690 point, but currently am trying to kill other bugs ;-)
5692 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
5693 in container classes as well.
5695 * expression.cs (Binary.ResolveOperator): Handle string case
5696 before anything else (as operator overloading does emit an error
5697 before doing anything else).
5699 This code could go away when we move to a table driven model, but
5700 i could not come up with a good plan last night.
5702 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
5704 * typemanager.cs (CSharpName): reimplementation using regex.
5705 * class.cs: added null check for fields in Emit
5706 * rootcontext.cs: set warninglevel to 4
5708 2002-04-29 Miguel de Icaza <miguel@ximian.com>
5710 * typemanager.cs (CSharpName): reimplemented with Lupus
5713 2002-04-28 Miguel de Icaza <miguel@ximian.com>
5715 * statement.cs (If): correclty implement Resolve, because we were
5716 not catching sem errors in there. The same process is needed
5718 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
5721 (Statement.Warning_DeadCodeFound): Factorize code.
5722 (While): Report dead code here too.
5724 (Statement): Added Resolve virtual method to allow
5725 for resolution split from the emit code.
5727 2002-04-26 Miguel de Icaza <miguel@ximian.com>
5729 * statement.cs (EmitBoolExpression): No longer try to resolve the
5731 (MakeBoolean): New utility function that resolve, implicitly
5732 converts to boolean and tags the expression.
5735 (If, Do): Implement dead code elimination.
5736 (While): Implement loop inversion
5738 (Do, While, For, If): Resolve the expression prior to calling our
5741 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
5744 - added method Report28 (warning: program has more than one entry point)
5745 - added method IsEntryPoint, implements paragraph 10.1 of the spec
5746 - modified method Method.Define, the part at the end of the method
5748 * rootcontext.cs: added static public Location EntryPointLocation;
5750 * ../errors/cs0028.cs : Add test case for the above warning.
5753 - modified method CSharpName to allow arrays of primitive type to
5754 be printed nicely (e.g. instead of System.Int32[][] it now prints
5756 - added method CSharpSignature: returns the signature of a method
5757 in string format to be used in reporting errors, warnings, etc.
5759 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
5762 2002-04-26 Ravi Pratap <ravi@ximian.com>
5764 * delegate.cs (Define): Fix extremely silly bug where I was
5765 setting the type of the 'object' parameter of the BeginInvoke
5766 method to System.IAsyncResult instead of System.Object ;-)
5768 2002-04-26 Miguel de Icaza <miguel@ximian.com>
5770 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
5773 (Constructor.Emit): return if we fail to initialize the
5774 constructor. Another door closed!
5776 * expression.cs (New.DoResolve): Improve error message (from -6 to
5777 1501). Use DeclaredOnly lookup to find the exact constructor.
5779 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
5780 loop. This is useful.
5782 * cs-parser.jay: Adjust the default parameters so that destructors
5783 have the proper signature.
5785 2002-04-26 Martin Baulig <martin@gnome.org>
5787 * driver.cs (LoadAssembly): If `assembly' contains any characters
5788 which are only valid in path names and not in assembly names
5789 (currently slash, backslash and point), use Assembly.LoadFrom ()
5790 instead of Assembly.Load () on the `assembly' (before iteration
5791 over the link_paths).
5793 2002-04-26 Martin Baulig <martin@gnome.org>
5795 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
5797 2002-04-25 Miguel de Icaza <miguel@ximian.com>
5799 * class.cs (Property): use the new typemanager.MemberLookup
5801 (TypeContainer.MemberLookup): Implement using the
5802 TypeManager.MemberLookup now.
5804 * typemanager.cs: Make MemberLookup a function of the TypeManager,
5805 and return MemberInfos, so that these can be used without an
5806 EmitContext (what we had before).
5808 2002-04-24 Miguel de Icaza <miguel@ximian.com>
5810 * expression.cs: Fix the case where the argument to params if the
5811 type of the params. I omitted handling this before. Fixed
5813 2002-04-22 Miguel de Icaza <miguel@ximian.com>
5815 * driver.cs: Call BootCorlib_PopulateCoreType
5817 * class.cs (Property.CheckBase): Check for properties only, not
5820 * interface.cs: Temporary hack: try/catch around the
5821 CustomAttributeBuilder, because I am getting an exception that I
5824 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
5825 types whose definitions are required to be there (attributes are
5826 defined before standard types).
5828 Compute definitions as we boot the various types, as they are used
5829 immediately (value_type class will need object_type, but if we do
5830 not initialize object_type, we will pass a null, which will let
5831 the runtime pick the System.Object from the existing corlib, which
5832 is not what we want).
5834 2002-04-22 Patrik Torstensson <totte@labs2.com>
5836 * cs-tokenizer.cs: fixed a number of trim() issues.
5838 2002-04-22 Ravi Pratap <ravi@ximian.com>
5840 * expression.cs (Argument.Type): Ensure that we return the correct
5841 type when we have out or ref parameters [in which case we
5844 2002-04-22 Miguel de Icaza <miguel@ximian.com>
5846 * class.cs (Property, Indexer): Allow extern modifier in there.
5848 * typemanager.cs (InitBaseTypes): Initializes object_type and
5849 value_type, since those will be used early on during the bootstrap
5850 process to compile corlib.
5852 (InitCoreTypes): Move code from here to InitBaseTypes.
5854 2002-04-21 Miguel de Icaza <miguel@ximian.com>
5856 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
5857 single-dimension arrays as using the ldlen opcode.
5859 Daniel Lewis discovered this optimization.
5861 * typemanager.cs: Add signature for System.Array::get_Length
5863 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
5865 * statement.cs: report the error when the foreach does not apply to an
5866 array nor a collection.
5868 2002-04-19 Miguel de Icaza <miguel@ximian.com>
5870 * expression.cs: Add implicit conversions to the operator ~.
5872 * constant.cs (DecimalConstant.Emit): Emit decimal value.
5874 * typemanager.cs: Locate the decimal constructor.
5876 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
5878 * attribute.cs: use the new property of TypeOf.
5879 * expression.cs: added 'get' property around typearg.
5881 These changes fix a build breaker reported by NickD. Is this the
5882 correct way to fix? If not, please, revert my changes and make it
5885 2002-04-17 Miguel de Icaza <miguel@ximian.com>
5887 * attribute.cs: Add support for typeof in attribute invocations.
5888 I am not sure that this is right though.
5890 2002-04-14 Duncan Mak <duncan@ximian.com>
5892 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
5893 Binary.Operator.Division case.
5895 2002-04-13 Ravi Pratap <ravi@ximian.com>
5897 * class.cs (DefineType): Ensure that we do a proper check on
5898 attribute types and also register it with the TypeManager.
5900 (TypeContainer.Targets): The default for attribute types is
5901 AttributeTargets.All.
5903 * attribute.cs (ApplyAttributes): Registering the attribute type
5904 is done elsewhere, not when we discover we have a Usage attribute.
5906 2002-04-12 Ravi Pratap <ravi@ximian.com>
5908 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
5909 and get rid of is_delegate parameter.
5911 * everywhere : update.
5913 2002-04-12 Ravi Pratap <ravi@ximian.com>
5915 * cs-parser.jay (compilation_unit): Revamp completely to use
5916 some new ideas that I got from Rhys' grammar to solve the problems
5917 with assembly level attributes.
5919 (outer_declaration): New grammar production.
5921 (attribute_sections): Add.
5923 (opt_attributes): Base on attribute_sections
5925 (namespace_declaration): Allow opt_attributes to tackle the case
5926 when we have assembly level attributes - we are clever in this
5929 * attribute.cs (ApplyAttributes): Do not worry about assembly
5930 attributes in the non-global context.
5932 * rootcontext.cs (AddGlobalAttributes): Go back to using this
5933 instead of SetGlobalAttributes.
5935 * class.cs, rootcontext.cs : Ensure we define and generate
5936 attribute types before anything else.
5938 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
5939 and flag the new error -20 for the case when the attribute type
5940 does not have valid targets specified. csc does not catch this.
5942 * ../errors/errors.txt : update for error # -20
5944 2002-04-11 Ravi Pratap <ravi@ximian.com>
5946 * support.cs (InternalParameters.ParameterModifier): Do some null
5947 checking and return sane values.
5949 * class.cs (Method.Define): If we are a PInvoke method, ensure
5950 that we are static and extern. Report error # 601
5952 * ../errors/cs0601.cs : Add test case for the above error.
5954 2002-04-07 Ravi Pratap <ravi@ximian.com>
5956 * rootcontext.cs (attribute_types): We need to keep type of
5957 all attribute types separately and emit code for them first.
5959 (RegisterAttribute) : Implement.
5961 * class.cs (DefineType): Check if the current Type is a custom
5962 attribute type and register it accordingly.
5964 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
5965 adding the first attribute twice and rename to
5967 (SetGlobalAttributes): this.
5969 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
5972 * attribute.cs (ApplyAttributes): Take an additional argument telling us
5973 if we are processing global arguments. Hmm, I am unsure of this.
5975 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
5977 * expression.cs: added static array of strings to avoid calling
5978 Enum.ToString () for Operator in Binary. Significant recover of
5981 2002-04-10 Miguel de Icaza <miguel@ximian.com>
5983 * class.cs (FindMembers): Allow the Builders of the various
5984 members to be null. If they are skip them. This only happens
5985 during the PInvoke declaration.
5987 2002-04-09 Miguel de Icaza <miguel@ximian.com>
5989 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
5990 failure, so we do not keep going afterwards.
5992 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
5993 wanted to pass `false' as the `is_delegate' argument. If this is
5994 the case, why not use delegate_type == null to mean `is_delegate =
5995 false' and anything else as is_delegate = true.
5997 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
5999 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
6000 code for the section, not the beginning of the tests.
6002 2002-04-08 Miguel de Icaza <miguel@ximian.com>
6004 * cfold.cs: Handle operator + (Enum x, Underlying x)
6006 * expression.cs (Binary): same. Warn about errors where we have
6007 Enum/Enum in operator + as well.
6009 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
6012 - added support for switch(bool)
6013 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
6014 - add TableSwitchEmit() to handle table-based switch statements
6016 2002-04-05 Ravi Pratap <ravi@ximian.com>
6018 * expression.cs (Invocation.OverloadResolve): Factor out code which
6019 does parameter compatibility checking with arguments so that we can
6020 re-use the code even from Delegate.VerifyApplicability
6022 (VerifyArgumentsCompat): Move above code here.
6024 * delegate.cs (VerifyApplicability): Get rid of duplicate code
6025 and instead make a call to the above method.
6027 2002-03-31 Ravi Pratap <ravi@ximian.com>
6029 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
6030 We use it to keep track of classes which are attribute types.
6032 2002-04-02 Miguel de Icaza <miguel@ximian.com>
6034 * delegate.cs (Delegate.Define): Correctly define the types in the
6035 presence of fixed and array parameters.
6037 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
6040 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
6041 include NonPublic after the first iteration.
6043 * class.cs (Indexer.CheckBase): Only check if both parents are
6046 * cs-parser.jay (accessor_body): If empty, set to null.
6048 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
6049 same code path here to resolve constants names that we did have in
6050 MemberAccess.DoResolve. There is too much code duplicated here.
6052 2002-04-01 Miguel de Icaza <miguel@ximian.com>
6054 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
6056 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
6059 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
6060 tokens, numbers and strings.
6062 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
6065 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
6066 asyncronous parameters and the regular parameters.
6068 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
6069 specify the target directory.
6071 * expression.cs: (This.DoResolve): Simplify
6072 (As.Emit): Optimize, do not generate IsInst if the expression is
6073 always of the given type.
6075 (Is.DoResolve): Bug fix, we were reporting both always/never for
6078 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
6079 creating too many unnecessary arrays.
6081 2002-03-31 Miguel de Icaza <miguel@ximian.com>
6083 * class.cs (EmitFieldInitializer): Use Assign expression to assign
6084 fields instead of rolling our own initializer. Takes care of all
6085 implicit conversions, and drops unnecessary static checks/argument.
6087 2002-03-31 Dick Porter <dick@ximian.com>
6089 * driver.cs: use the GetDirectories() return values properly, and
6090 use "/" as path separator.
6092 2002-03-30 Miguel de Icaza <miguel@ximian.com>
6094 * expression.cs (Unary): Optimize - - expr into expr.
6095 (Binary): Optimize a + (-b) into a -b.
6097 * codegen.cs (CodeGen): Made all methods static.
6099 2002-03-29 Miguel de Icaza <miguel@ximian.com>
6103 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
6104 TypeBuilder property.
6106 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
6109 * tree.cs: Removed the various RecordXXXX, and replaced with a
6110 single RecordDecl. Removed all the accessor methods, and just
6111 left a single access point Type
6113 * enum.cs: Rename DefineEnum to DefineType.
6115 * decl.cs: New abstract method `DefineType' used to unify the
6116 Defines for Enumerations, Interfaces, TypeContainers and
6119 (FindType): Moved LookupInterfaceOrClass here. Moved the
6120 LookupBaseClasses method that used to live in class.cs and
6121 interface.cs here, and renamed to FindType.
6123 * delegate.cs: Implement DefineType. Take advantage of the
6124 refactored pattern for locating the parent builder without taking
6125 the parent_builder argument (which we know does not work if we are
6126 nested, and triggering a toplevel definition).
6128 2002-03-28 Miguel de Icaza <miguel@ximian.com>
6130 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
6131 accessibility of a member has changed during override and report
6134 * class.cs (Method.Define, Property.Define): Only complain on
6135 overrides if the method is private, any other accessibility is
6136 fine (and since we just checked the permission is the same, we are
6139 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
6140 and elif are processed always. The other pre-processing
6141 directives are only processed if we are "taking" the path
6143 2002-03-29 Martin Baulig <martin@gnome.org>
6145 * class.cs (Method.Emit): Only emit symbolic debugging info if the
6146 current location is not Null.
6148 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
6149 a separate method so we can profile it.
6151 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
6152 `span.Seconds' are just seconds, but no minutes or hours.
6153 (MainDriver): Profile the CodeGen.SaveSymbols calls.
6155 2002-03-28 Miguel de Icaza <miguel@ximian.com>
6157 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
6158 Remove the gratuitous set of Final:
6160 // If an interface implementation, then we can set Final.
6161 if (((flags & MethodAttributes.Abstract) == 0) &&
6162 implementing.DeclaringType.IsInterface)
6163 flags |= MethodAttributes.Final;
6165 I do not know what I was smoking when I used that.
6168 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
6169 step into fixing the name resolution issues for delegates and
6170 unifying the toplevel name resolution.
6172 2002-03-28 Martin Baulig <martin@gnome.org>
6174 * class.cs (Method.Emit): If we have a symbol writer, call its
6175 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
6176 tell it about the current method.
6178 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
6179 writer that we're going to emit the first byte of IL code for a new
6180 statement (a new source line).
6181 (EmitContext.EmitTopBlock): If we have a symbol writer, call
6182 EmitContext.Mark() before emitting any code.
6184 * location.cs (SymbolDocument): Return null when we're Null.
6186 * statement.cs (Statement): Moved the `Location loc' variable here.
6187 (Statement.EmitBoolExpression): If we have a symbol writer, call
6188 ec.Mark() before emitting any code to tell it that we're at the
6189 beginning of a new statement.
6190 (StatementExpression): Added `Location' argument to the constructor.
6191 (Block): Added public readonly variable `StartLocation' and public
6192 variable `EndLocation'. The latter is to be set using SetEndLocation().
6193 (Block): Added constructor which takes a start and end location.
6194 (Block.SetEndLocation): New method. This sets the end location.
6195 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
6196 local variables we create.
6197 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
6198 each statement and do also mark the begin and end of the block.
6200 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
6201 tell it the current lexer.Location, use Location.Null for the end of the
6203 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
6204 current block, set its end location using SetEndLocation().
6205 (statement_expression): StatementExpression constructor now takes the
6206 lexer.Location as additional argument.
6207 (for_statement, declare_local_variables): Likewise.
6208 (declare_local_variables): When creating a new implicit block, use the
6209 new Block constructor and pass it the lexer.Location.
6211 2002-03-28 Miguel de Icaza <miguel@ximian.com>
6213 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
6214 members also on the parent interfaces recursively.
6216 2002-03-27 Miguel de Icaza <miguel@ximian.com>
6218 * report.cs: Use new formats, since Gonzalo finished the missing
6221 * expression.cs (Binary.ResolveOperator): added missing operator|
6222 operator& and operator^ for bool/bool.
6224 * cs-parser.jay: CheckDef now takes a Location argument that is
6225 used to report errors more precisly (instead of reporting the end
6226 of a definition, we try to track something which is a lot closer
6227 to the source of the problem).
6229 * cs-tokenizer.cs: Track global token use, so we can properly flag
6230 the use of #define/#undef after the first token has been seen.
6232 Also, rename the reportXXXX to Error_DescriptiveName
6234 * decl.cs (DeclSpace.IsTopLevel): Move property here from
6235 TypeContainer, so that Enum and Interface can use this too.
6237 * class.cs (TypeContainer.LookupInterfaceOrClass,
6238 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
6239 `builder' argument. Typically this was used to pass the parent
6240 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
6243 The problem is that a nested class could trigger the definition of
6244 a toplevel class, and the builder would be obviously wrong in that
6247 So we drop this argument, and we compute dynamically the
6248 TypeBuilder/ModuleBuilder (the correct information was available
6249 to us anyways from DeclSpace.Parent)
6251 * interface.cs (Interface.DefineInterface): Drop builder
6252 parameter cleanup like class.cs
6254 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
6257 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
6260 (Try.Emit): Propagate the returns value from the statement.
6262 (Return.Emit): Even if we are leavning
6264 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
6266 * modifiers.cs: Fix the computation of MethodAttributes flags.
6268 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
6270 * driver.cs: allow compilation of files that start with '/'.
6271 Add a default case when checking the argument of --target.
6273 2002-03-25 Miguel de Icaza <miguel@ximian.com>
6275 * interface.cs: Implement the same search algorithm for types in
6278 * delegate.cs: Do not allow multiple definition.
6280 * Recovered ChangeLog that got accidentally amputated
6282 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
6284 * rootcontext.cs: Load manually enum to allow core classes to
6285 contain enumerations.
6287 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
6288 Update to new static methods in TypeManager.
6290 * typemanager.cs (GetMethod, GetConstructor): Use our
6291 implementation of FindMembers to find the members, since during
6292 corlib compilation, the types are TypeBuilders and GetMethod and
6293 GetConstructor do not work.
6295 Make all methods in TypeManager static.
6297 (InitCodeHelpers): Split the functionality from
6298 the InitCodeTypes function.
6300 * driver.cs: Call InitCodeHelpers after we have populated the
6303 * cs-parser.jay (delegate_declaration): we did not used to compute
6304 the delegate name correctly for void delegates.
6306 2002-03-24 Miguel de Icaza <miguel@ximian.com>
6308 * rootcontext.cs (RootContext): Init the interface_resolve_order
6309 and type_container_resolve_order always.
6311 (ResolveCore, BootstrapCorlib_ResolveClass,
6312 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
6313 compiler when compiling with --nostdlib
6315 * class.cs (TypeContainer.DefineType): Check that our parent is
6316 not null. This test is most important when we are bootstraping
6319 * codegen.cs: Split out the symbol writing code.
6321 2002-03-25 Martin Baulig <martin@gnome.org>
6323 * driver.cs (-g): Made -g an alias for --debug.
6325 2002-03-24 Martin Baulig <martin@gnome.org>
6327 * codegen.cs (SymbolWriter): New public variable. Returns the
6328 current symbol writer.
6329 (CodeGen): Added `bool want_debugging_support' argument to the
6330 constructor. If true, tell the ModuleBuild that we want debugging
6331 support and ask it for the ISymbolWriter.
6332 (Save): If we have a symbol writer, call it's Close() method after
6333 saving the assembly.
6335 * driver.c (--debug): New command line argument to create a
6336 debugger information file.
6338 * location.cs (SymbolDocument): New public property. Returns an
6339 ISymbolDocumentWriter object for the current source file or null
6340 if we don't have a symbol writer.
6342 2002-03-21 Miguel de Icaza <miguel@ximian.com>
6344 * driver.cs (LoadAssembly): Correctly return when all the paths
6345 have been tried and not before.
6347 * statement.cs (Switch.Emit): return the actual coverage for this
6348 statement (returns/not-returns)
6350 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
6351 switch of the statement if we are the last switch section. That
6352 kills two problems: try/catch problems (we used to emit an empty
6353 nop at the end) and switch statements where all branches would
6356 2002-03-19 Miguel de Icaza <miguel@ximian.com>
6358 * driver.cs: Add default assemblies (the equivalent to the
6359 Microsoft CSC.RSP file)
6361 * cs-tokenizer.cs: When updating `cols and setting it to zero,
6362 also update tokens_seen and set it to false.
6364 * driver.cs: Implement --recurse for Mike.
6366 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
6367 correctly splitting out the paths.
6369 2002-03-18 Miguel de Icaza <miguel@ximian.com>
6371 * interface.cs (Interface.PopulateProperty): Instead of using
6372 `parent' as the declaration space for the set parameters, use
6375 * support.cs (InternalParameters): InternalParameters constructor
6376 takes a DeclSpace instead of a TypeContainer.
6378 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
6379 types are being initialized, load the address of it before calling
6382 (New): Provide a mechanism to disable the generation of local
6383 value type temporaries when the caller will be providing us with
6384 an address to store it.
6386 (ArrayCreation.EmitDynamicInitializers): Use it.
6388 2002-03-17 Miguel de Icaza <miguel@ximian.com>
6390 * expression.cs (Invocation.EmitArguments): Only probe for array
6391 property if there is more than one argument. Sorry about that.
6393 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
6396 * class.cs (Method.LabelParameters): Fix incorrect code path that
6397 prevented the `ParamArrayAttribute' from being applied to the
6400 2002-03-16 Miguel de Icaza <miguel@ximian.com>
6402 * support.cs (ReflectionParameters): Correctly compute whether the
6403 last argument is a params array. Fixes the problem with
6406 * typemanager.cs: Make the assemblies array always be non-null
6407 (empty, but non-null)
6409 * tree.cs (RecordDecl): New function that abstracts the recording
6410 of names. This reports error 101, and provides a pointer to the
6411 previous declaration. Fixes a crash in the compiler.
6413 * cs-parser.jay (constructor_declaration): Update to new grammar,
6414 and provide a constructor_body that can be empty.
6416 2002-03-15 Miguel de Icaza <miguel@ximian.com>
6418 * driver.cs: Add support for --resources.
6420 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
6421 Make all types for the various array helper methods be integer.
6423 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
6424 CheckState to ConvCast.
6426 (ConvCast): Now it takes a `checked' state argument, to avoid
6427 depending on the emit context for the conversion, and just using
6428 the resolve time setting.
6430 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
6431 instead of Invocation.EmitArguments. We do not emit the original
6432 arguments, instead we emit those which have been converted to
6433 unsigned int expressions.
6435 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
6437 * codegen.cs: ditto.
6439 * expression.cs (LocalVariableReference): Drop the use of the
6440 Store function that depended on the variable index.
6442 * statement.cs (VariableInfo): Drop the `Idx' property from this
6443 class, as this is not taking into account the indexes for
6444 temporaries tat we generate during the execution, getting the
6447 * class.cs: First emit class initializers, then call the parent
6450 * expression.cs (Binary): Fix opcode emision.
6451 (UnaryMutator.EmitCode): Support checked code generation
6453 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
6454 matches for events for both the Static and Instance scans,
6455 pointing to the same element. Fix that.
6457 2002-03-14 Miguel de Icaza <miguel@ximian.com>
6459 * rootcontext.cs (ResolveTree): Always set the
6460 interface_resolve_order, because nested interfaces will be calling
6463 * class.cs (GetInterfaceOrClass): Track the same resolution
6464 process used by TypeManager.LookupType. This fixes the nested
6465 type lookups in class declarations (separate path from
6468 (TypeContainer.DefineType): Also define nested interfaces.
6469 (TypeContainer.RegisterOrder): New public function used to
6470 register the order in which child interfaces need to be closed.
6472 Nested interfaces need to be closed after their parents have been
6475 * interface.cs (InterfaceAttr): Put all the logic for computing
6476 the interface attribute here.
6478 (DefineInterface): Register our interface order with the
6479 RootContext or with the TypeContainer depending on the case.
6481 2002-03-12 Miguel de Icaza <miguel@ximian.com>
6483 * cs-parser.jay: rework foreach statement to work with the new
6484 changes to the policy on SimpleNames.
6486 * report.cs: support Stacktrace on warnings as well.
6488 * makefile: drop --unsafe and /unsafe from the compile.
6490 2002-03-13 Ravi Pratap <ravi@ximian.com>
6492 * ecore.cs (StandardConversionExists): Modify to take an Expression
6493 as the first parameter. Ensure we do null -> reference type conversion
6496 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
6497 temporary Expression objects.
6499 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
6501 * interface.cs: workaround bug in method overloading resolution
6502 (there is already a bugzilla bug for it).
6504 2002-03-12 Miguel de Icaza <miguel@ximian.com>
6506 We could also solve this problem by having a separate path for
6507 performing type lookups, instead of DoResolve, we could have a
6508 ResolveType entry point, and only participating pieces of the
6509 production (simplename, deref, array) would implement this.
6511 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
6512 signal SimpleName to only resolve type names and not attempt to
6513 resolve anything else.
6515 * expression.cs (Cast): Set the flag.
6517 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
6519 * class.cs: Only report 108 if there is no `new' modifier.
6521 * cs-parser.jay: rework foreach statement to work with the new
6522 changes to the policy on SimpleNames.
6524 * report.cs: support Stacktrace on warnings as well.
6526 * makefile: drop --unsafe and /unsafe from the compile.
6528 2002-03-11 Miguel de Icaza <miguel@ximian.com>
6530 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
6531 lookups here, instead of doing that at parse time. This means
6532 that our grammar will not introduce `LocalVariableReferences' as
6533 expressions at this point. That solves the problem of code like
6541 This is only half the fix. The full fix requires parameters to
6542 also be handled in this way.
6544 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
6545 makes the use more obvious of the DeclSpace. The
6546 ec.TypeContainer.TypeBuilder is now only used to pull the
6549 My theory is that I can get rid of the TypeBuilder completely from
6550 the EmitContext, and have typecasts where it is used (from
6551 DeclSpace to where it matters).
6553 The only pending problem is that the code that implements Aliases
6554 is on TypeContainer, and probably should go in DeclSpace.
6556 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
6557 lookups here, instead of doing that at parse time. This means
6558 that our grammar will not introduce `LocalVariableReferences' as
6559 expressions at this point. That solves the problem of code like
6567 This is only half the fix. The full fix requires parameters to
6568 also be handled in this way.
6570 * class.cs (Property.DefineMethod): When implementing an interface
6571 method, set newslot, when implementing an abstract method, do not
6572 set the flag (before we tried never setting it, or always setting
6573 it, which is the difference).
6574 (Indexer.DefineMethod): same.
6575 (Method.DefineMethod): same.
6577 * ecore.cs: Only set the status used flag if we get back a Field.
6579 * attribute.cs: Temporary hack, so Paolo can keep working.
6581 2002-03-08 Ravi Pratap <ravi@ximian.com>
6583 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
6584 the unmanaged type in the case we have a MarshalAs attribute.
6586 (Resolve): Handle the case when we are parsing the special MarshalAs
6587 attribute [we need to store the unmanaged type to use later]
6589 * typemanager.cs (marshal_as_attr_type): Built in type for the
6590 MarshalAs Attribute.
6592 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
6593 on parameters and accordingly set the marshalling info.
6595 2002-03-09 Miguel de Icaza <miguel@ximian.com>
6597 * class.cs: Optimizing slightly by removing redundant code after
6598 we switched to the `NoTypes' return value.
6599 (Property.DefineMethod): use NoTypes here too.
6601 This fixes the bug I introduced in my last batch of changes.
6603 2002-03-05 Ravi Pratap <ravi@ximian.com>
6605 * tree.cs (RecordEnum): Add. We now keep track of enums too.
6607 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
6608 Enums since those are types too.
6610 * cs-parser.jay (enum_declaration): Record enums as we parse them.
6612 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
6613 thanks to a call during the lookup process.
6615 2002-03-07 Miguel de Icaza <miguel@ximian.com>
6617 * statement.cs (Foreach): Lots of work to accomodate a particular
6618 kind of foreach statement that I had not kept in mind. It is
6619 possible to have foreachs on classes that provide a GetEnumerator
6620 method that return objects that implement the "pattern" for using
6621 a foreach, there is no need to support GetEnumerator
6624 This is needed to compile nant.
6626 * decl.cs: Only report 114 if the member is not `Finalize' and if
6627 the warning level is at least 2.
6629 * class.cs: Moved the compare function from Method to
6632 (MethodSignature.InheritableMemberSignatureCompare): Add new
6633 filter function that is used to extract inheritable methods from a
6636 (Method.Define): Use the new `inheritable_method_signature_filter'
6639 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
6642 2002-03-06 Miguel de Icaza <miguel@ximian.com>
6644 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
6646 * cs-parser.jay: Add opt_semicolon to the interface declaration.
6648 * expression.cs: Pass location information to
6649 ConvertImplicitStandard.
6651 * class.cs: Added debugging code to track return values from
6654 2002-03-05 Miguel de Icaza <miguel@ximian.com>
6656 * expression.cs (Is.DoResolve): If either side of the `is' is an
6657 interface, do not flag the warning.
6659 * ecore.cs (ImplicitReferenceConversion): We need a separate test
6662 * report.cs: Allow for --fatal to be used with --probe.
6664 * typemanager.cs (NoTypes): Move the definition for the empty Type
6667 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
6669 (TypeContainer.DefineProxy): New function used to proxy to parent
6670 implementations when implementing interfaces.
6671 (TypeContainer.ParentImplements): used to lookup if our parent
6672 implements a public function that is required by an interface.
6673 (TypeContainer.VerifyPendingMethods): Hook this up.
6675 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
6676 `modules' and `assemblies' arraylists into arrays. We only grow
6677 these are the very early start up of the program, so this improves
6678 the speedof LookupType (nicely measured).
6680 * expression.cs (MakeByteBlob): Replaced unsafe code with
6681 BitConverter, as suggested by Paolo.
6683 * cfold.cs (ConstantFold.Binary): Special case: perform constant
6684 folding of string concatenation, but if either side is a string,
6685 and the other is not, then return null, and let the runtime use
6686 the concatenation on the string plus the object (using
6689 2002-03-04 Miguel de Icaza <miguel@ximian.com>
6691 Constant Folding has been implemented now.
6693 * expression.cs (Unary.Reduce): Do not throw an exception, catch
6694 the error instead on types that are not supported in one's
6697 * constant.cs (Constant and all children): New set of functions to
6698 perform implict and explicit conversions.
6700 * ecore.cs (EnumConstant): Implement the new functions to perform
6701 conversion by proxying to the child expression.
6703 * codegen.cs: (ConstantCheckState): Constant evaluation has its
6704 own separate setting that can not be turned off from the command
6705 line using --unchecked or --checked and is only controlled using
6706 the checked/unchecked statements and expressions. This setting is
6707 used by the constant folder to flag errors.
6709 * expression.cs (CheckedExpr, UncheckedExpr): Set the
6710 ConstantCheckState as well.
6712 During Resolve, they also have to flag the state, because the
6713 constant folder runs completely in the Resolve phase.
6715 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
6718 2002-03-01 Miguel de Icaza <miguel@ximian.com>
6720 * cfold.cs: New file, this file contains the constant folder.
6722 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
6723 argument to track whether we are using the resulting address to
6724 load or store a value and provide better error messages.
6726 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
6727 new AddressOf arguments.
6729 * statement.cs (Foreach.EmitCollectionForeach): Update
6731 * expression.cs (Argument.Emit): Call AddressOf with proper
6732 arguments to track usage.
6734 (New.DoEmit): Call AddressOf with new arguments.
6736 (Unary.Emit): Adjust AddressOf call.
6738 2002-03-01 Ravi Pratap <ravi@ximian.com>
6740 * cs-parser.jay (member_access): Change the case for pre-defined types
6741 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
6744 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
6747 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
6748 essentially like methods and apply attributes like MethodImplOptions to them too.
6750 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
6753 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
6754 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
6757 * Update code everywhere accordingly.
6759 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
6761 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
6763 2002-02-28 Ravi Pratap <ravi@ximian.com>
6765 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
6766 try performing lookups against those instead of jumping straight into using
6767 the 'using' clauses.
6769 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
6771 (LookupType): Perform lookups in implicit parents too.
6773 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
6774 sequence as RootContext.LookupType.
6776 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
6777 the various cases of namespace lookups into this method.
6779 2002-03-01 Miguel de Icaza <miguel@ximian.com>
6781 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
6782 in positional arguments)
6784 * class.cs (Operator): Update the AllowedModifiers to contain
6787 * cs-parser.jay: Update operator declaration to allow for the
6788 operator body to be empty.
6790 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
6793 2002-02-27 Miguel de Icaza <miguel@ximian.com>
6795 * class.cs (Method.Emit): Label parameters.
6797 * driver.cs: Return 1 or 0 as the program exit code.
6799 2002-02-26 Miguel de Icaza <miguel@ximian.com>
6801 * expression.cs: Special case the `null' object when trying to
6802 auto-compute the type, as anything can be explicitly converted to
6805 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
6806 spotting this Paolo.
6808 (Expression.ImplicitNumericConversion): Perform comparissions of
6809 the type using the underlying type in the case of an enumeration
6810 rather than using the enumeration type for the compare.
6812 Cope with the underlying == type case, which is not possible to
6815 (Expression.ConvertNumericExplicit): Perform comparissions of
6816 the type using the underlying type in the case of an enumeration
6817 rather than using the enumeration type for the compare.
6819 * driver.cs: If the user does not supply an extension, assume .exe
6821 * cs-parser.jay (if_statement): Rewrote so that we can track the
6822 location for the if statement.
6824 * expression.cs (Binary.ConstantFold): Only concat strings when
6825 the operation is "+", not everything ;-)
6827 * statement.cs (Statement.EmitBoolExpression): Take a location
6829 (If, While, Do): Track location.
6831 * expression.cs (Binary.ResolveOperator): In the object + string
6832 case, I was missing a call to ConvertImplicit
6834 2002-02-25 Ravi Pratap <ravi@ximian.com>
6836 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
6837 Location arguments. Ensure we use RootContext.LookupType to do our work
6838 and not try to do a direct Type.GetType and ModuleBuilder.GetType
6840 * interface.cs (PopulateMethod): Handle the type of the parameter being
6843 * expression.cs (Invocation.BetterFunction): Handle the case when we
6844 have a params method with no fixed arguments and a call is made with no
6847 2002-02-25 Miguel de Icaza <miguel@ximian.com>
6849 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
6850 the verbatim-string-literal
6852 * support.cs (InternalParameters.ParameterModifier): handle null
6854 (InternalParameters.ParameterType): ditto.
6856 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
6857 duplicating the name of the variable parameter.
6858 (GetParameterByName): Fix bug where we were not looking up array
6859 paramters if they were the only present (thanks Paolo!).
6860 (GetParameterInfo): We only have an empty set of types if both
6861 fixed and array are set to null.
6862 (GetParameterInfo-idx): Handle FixedParameter == null
6864 * cs-parser.jay: Handle the case where there is no catch
6865 statements (missing null test).
6867 2002-02-22 Miguel de Icaza <miguel@ximian.com>
6869 * driver.cs (MainDriver): Be conservative on our command line
6872 Catch DirectoryNotFoundException when calling GetFiles.
6874 (SplitPathAndPattern): Used to split the input specification into
6875 a path and a pattern that we can feed to Directory.GetFiles.
6877 2002-02-21 Miguel de Icaza <miguel@ximian.com>
6879 * statement.cs (Fixed): Implement the last case of the Fixed
6880 statement (string handling).
6882 * expression.cs (StringPtr): New class used to return a char * to
6883 a string; Used by the Fixed statement.
6885 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
6887 * expression.cs (Binary.ResolveOperator): Remove redundant
6888 MemberLookup pn parent type.
6889 Optimize union call, we do not need a union if the types are the same.
6890 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
6893 Specialize the use of MemberLookup everywhere, instead of using
6894 the default settings.
6896 (StackAlloc): Implement stackalloc keyword.
6898 * cs-parser.jay: Add rule to parse stackalloc.
6900 * driver.cs: Handle /h, /help, /?
6902 * expression.cs (MakeByteBlob): Removed the hacks we had in place
6903 before we supported unsafe code.
6905 * makefile: add --unsafe to the self compilation of mcs.
6907 2002-02-20 Miguel de Icaza <miguel@ximian.com>
6909 * expression.cs (PointerArithmetic): New class that is used to
6910 perform pointer arithmetic.
6911 (Binary.Resolve): Handle pointer arithmetic
6912 Handle pointer comparission.
6913 (ArrayPtr): Utility expression class that is used to take the
6914 address of an array.
6916 (ElementAccess): Implement array access for pointers
6918 * statement.cs (Fixed): Implement fixed statement for arrays, we
6919 are missing one more case before we are done.
6921 * expression.cs (Indirection): Implement EmitAssign and set the
6922 ExprClass to Variable. This allows pointer dereferences to be
6923 treated as variables, and to have values assigned to them.
6925 * ecore.cs (Expression.StoreFromPtr): New utility function to
6926 store values dereferencing.
6928 2002-02-20 Ravi Pratap <ravi@ximian.com>
6930 * expression.cs (Binary.ResolveOperator): Ensure that we are
6931 not trying to operate on a void type - this fixes the reported
6934 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
6935 the parent implementation is sealed.
6937 * ../errors/cs0239.cs : Add.
6939 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
6941 * typemanager.cs (unverifiable_code_type): Corresponds to
6942 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
6943 which have unsafe code in them.
6945 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
6948 2002-02-19 Miguel de Icaza <miguel@ximian.com>
6950 * cs-tokenizer.cs: Add support for @"litreal strings"
6952 Make tokenizer accept pre-processor directives
6953 on any column (remove the old C-like limitation).
6955 * rootcontext.cs (EmitCode): Emit any global attributes.
6956 (AddGlobalAttributes): Used to keep track of assembly attributes.
6958 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
6960 * cs-parser.jay: Add support for global attributes.
6962 2002-02-17 Miguel de Icaza <miguel@ximian.com>
6964 * expression.cs (Indirection): New helper class. Unary will
6965 create Indirection classes to be able to implement the
6966 IMemoryLocation interface on it.
6968 2002-02-16 Miguel de Icaza <miguel@ximian.com>
6970 * cs-parser.jay (fixed_statement): reference the right statement.
6972 * statement.cs (Fixed.Emit): Finish implementing the fixed
6973 statement for the &x case.
6975 2002-02-14 Miguel de Icaza <miguel@ximian.com>
6977 * class.cs (Property.Define, Method.Define): Remove newslot when
6980 * modifiers.cs: My use of NewSlot when `Abstract' was set was
6981 wrong. NewSlot should only be used if the `new' keyword is present.
6983 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
6984 locating our system dir. Sorry about this.
6986 2002-02-13 Miguel de Icaza <miguel@ximian.com>
6988 * driver.cs (GetSystemDir): Compute correctly the location of our
6989 system assemblies. I was using the compiler directory instead of
6990 the library directory.
6992 2002-02-13 Ravi Pratap <ravi@ximian.com>
6994 * expression.cs (BetterFunction): Put back in what Miguel commented out
6995 since it is the correct fix. The problem is elsewhere ;-)
6997 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
6998 parameters of the parms method are themselves compatible or not !
7000 (StandardConversionExists): Fix very dangerous bug where we were forgetting
7001 to check that a class implements an interface before saying that an implicit
7002 conversion was allowed. Use ImplementsInterface to do the checking.
7004 2002-02-13 Miguel de Icaza <miguel@ximian.com>
7006 * class.cs (Method.Define): Track whether we are an explicit
7007 implementation or not. And only call DefineMethodOverride if we
7008 are an explicit implementation.
7010 (Property.DefineMethod): Ditto.
7012 2002-02-11 Ravi Pratap <ravi@ximian.com>
7014 * expression.cs (BetterFunction): Catch hideous bug which was
7015 preventing us from detecting ambiguous calls due to implicit casts i.e
7018 2002-01-29 Miguel de Icaza <miguel@ximian.com>
7020 * support.cs (Pair): Remove un-needed method. I figured why I was
7021 getting the error in cs-parser.jay, the variable in a foreach loop
7022 is readonly, and the compiler does not really treat this as a variable.
7024 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
7025 instead of EQUALS in grammar.
7027 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
7029 * expression.cs (Unary.DoResolve): Check whether the argument is
7032 2002-01-28 Miguel de Icaza <miguel@ximian.com>
7034 * support.cs: Api for Pair to set a value. Despite the fact that
7035 the variables are public the MS C# compiler refuses to compile
7036 code that accesses the field if the variable is part of a foreach
7039 * statement.cs (Fixed): Begin implementation of the fixed
7042 (Block.AddVariable): Return the VariableInfo on success and null
7043 on failure instead of true/false.
7045 * cs-parser.jay (foreach): Catch errors on variables already
7046 defined (we were ignoring this value before) and properly unwind
7049 (fixed_statement): grammar for the fixed statement.
7051 2002-01-25 Miguel de Icaza <miguel@ximian.com>
7053 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
7054 pointer types to be incretemented.
7056 (SizeOf): Implement.
7058 * cs-parser.jay (pointer_member_access): Implement
7059 expr->IDENTIFIER production.
7061 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
7062 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
7065 (Unary): Implement indirection.
7067 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
7068 use in non-unsafe context).
7070 (SimpleName.DoResolve): Check for pointers in field access on safe
7073 (Expression.LoadFromPtr): Factor the load-indirect code in this
7074 function. This was duplicated in UnboxCast and ParameterReference
7076 2002-01-24 Miguel de Icaza <miguel@ximian.com>
7078 * expression.cs (ComposedCast): report an error if a pointer cast
7079 is used in a safe region.
7081 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
7082 pointer type casts in unsafe context.
7084 * codegen.cs (EmitContext): Set up IsUnsafe.
7086 * cs-parser.jay (non_expression_type): Add productions for pointer
7089 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
7090 code. We should not use force into static mode if the method is
7091 not virtual. Fixes bug in MIS
7093 * statement.cs (Do.Emit, While.Emit, For.Emit,
7094 Statement.EmitBoolExpression): Add support to Do and While to
7095 propagate infinite loop as `I do return' semantics.
7097 Improve the For case to also test for boolean constants.
7099 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
7100 to the list of attributes we can add.
7102 Remove `EmitContext' argument.
7104 * class.cs (Method.Define): Apply parameter attributes.
7105 (Constructor.Define): Apply parameter attributes.
7106 (MethodCore.LabelParameters): Move here the core of labeling
7109 * support.cs (ReflectionParameters.ParameterModifier,
7110 InternalParameters.ParameterModifier): Use IsByRef on the type and
7111 only return the OUT bit for these parameters instead of in/out/ref
7114 This is because I miss-understood things. The ParameterInfo.IsIn
7115 and IsOut represent whether the parameter has the [In] and [Out]
7118 2002-01-22 Miguel de Icaza <miguel@ximian.com>
7120 * ecore.cs (FieldExpr.Emit): Release temporaries.
7122 * assign.cs (LocalTemporary.Release): new function.
7124 * codegen.cs (EmitContext.GetTemporaryStorage,
7125 EmitContext.FreeTemporaryStorage): Rework the way we deal with
7126 temporary storage. Now we can "put back" localbuilders when we
7129 2002-01-21 Miguel de Icaza <miguel@ximian.com>
7131 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
7132 need to make a copy of the variable to generate verifiable code.
7134 2002-01-19 Miguel de Icaza <miguel@ximian.com>
7136 * driver.cs: Compute dynamically the system directory.
7138 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
7139 Slower, but more generally useful. Used by the abstract
7140 registering implementation.
7142 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
7143 the rules for the special rule on Type/instances. First check if
7144 we have the same name, and if so, try that special static path
7145 rather than the instance path.
7147 2002-01-18 Miguel de Icaza <miguel@ximian.com>
7149 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
7152 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
7153 Enum, ValueType, Delegate or Array for non-corlib compiles.
7155 * cs-tokenizer.cs: Catch long identifiers (645)
7157 * typemanager.cs (IndexerPropetyName): Ravi never tested this
7160 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
7161 fix, we were returning too early, so we were not registering
7162 pending methods from abstract classes.
7164 Do not register pending methods if the class is abstract.
7166 * expression.cs (Conditional.DoResolve): Report circular implicit
7167 conversions when we neecd to compute it for conditional
7170 (Is.DoResolve): If the expression is always of the provided type,
7171 flag warning 183. If the expression can not ever be of the
7172 provided type flag warning 184.
7174 * class.cs: Catch 169 as well.
7176 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
7179 2002-01-18 Nick Drochak <ndrochak@gol.com>
7181 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
7183 2002-01-17 Miguel de Icaza <miguel@ximian.com>
7185 * interface.cs: (PopulateMethod): Check for pointers being defined
7186 only if the unsafe context is active.
7187 (PopulateProperty): ditto.
7188 (PopulateIndexer): ditto.
7190 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
7191 specified. If pointers are present, make sure that they are
7192 present in an unsafe context.
7193 (Constructor, Constructor.Define): ditto.
7194 (Field, Field.Define): ditto.
7195 (Property, Property.Define): ditto.
7196 (Event, Event.Define): ditto.
7198 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
7199 hashtable if there are classes or structs defined.
7201 * expression.cs (LocalVariableReference.DoResolve): Simplify this
7202 code, as the constant resolution moved.
7204 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
7205 the metadata, so we can flag error 133.
7207 * decl.cs (MemberCore.UnsafeOK): New function to test that a
7208 pointer is being declared in an unsafe context.
7210 2002-01-16 Miguel de Icaza <miguel@ximian.com>
7212 * modifiers.cs (Modifiers.Check): Require a Location argument.
7213 Report error 227 for Unsafe use.
7215 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
7217 * statement.cs (For.Emit): If the test is null, then report that
7218 we do `return', as we wont reach anything afterwards.
7220 (Switch.SwitchGoverningType): Track the expression that matched
7223 * driver.cs: Allow negative numbers as an error code to flag.
7225 * cs-parser.jay: Handle 1551.
7227 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
7229 2002-01-15 Miguel de Icaza <miguel@ximian.com>
7231 * cs-parser.jay: Report 1518 (type declaration can only contain
7232 class, struct, interface, enum or delegate)
7234 (switch_label): Report 1523 (keywords `case' or `default' must
7237 (opt_switch_sections): Report 1522 (empty switch)
7239 * driver.cs: Report 1515 (response file specified multiple times)
7240 Report 1516 (Source file specified multiple times).
7242 * expression.cs (Argument.Resolve): Signal 1510
7244 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
7245 access not allowed in static code)
7247 2002-01-11 Ravi Pratap <ravi@ximian.com>
7249 * typemanager.cs (IsPointerType): Utility method which we are going
7252 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
7253 the object type, so we take care of that.
7255 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
7257 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
7258 added to non-params parameters :-)
7260 * typemanager.cs (CSharpName): Include 'void' type too.
7262 (void_ptr_type): Include in the set of core types.
7264 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
7267 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
7270 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
7271 completely forgotten about it.
7273 2002-01-10 Ravi Pratap <ravi@ximian.com>
7275 * cs-parser.jay (pointer_type): Add. This begins our implementation
7276 of parsing rules for unsafe code.
7278 (unsafe_statement): Implement.
7280 (embedded_statement): Modify to include the above.
7282 * statement.cs (Unsafe): Implement new class for unsafe blocks.
7284 * codegen.cs (EmitContext.InUnsafe): Add. This determines
7285 if the current context is an unsafe one.
7287 * cs-parser.jay (local_variable_pointer_type): Since local variable types
7288 are handled differently, we need separate rules for them.
7290 (local_variable_declaration): Update to use local_variable_pointer_type
7291 to allow variable declarations of unmanaged pointer types.
7293 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
7296 * ../errors/cs0214.cs : Add.
7298 2002-01-16 Nick Drochak <ndrochak@gol.com>
7300 * makefile: remove 'response' file when cleaning.
7302 2002-01-15 Miguel de Icaza <miguel@ximian.com>
7304 * cs-parser.jay: Report 1524.
7306 2002-01-14 Miguel de Icaza <miguel@ximian.com>
7308 * typemanager.cs (RegisterMethod): drop checking if we have
7309 registered this from here
7311 2002-01-12 Miguel de Icaza <miguel@ximian.com>
7313 * class.cs (Method.EmitDestructor): Implement calling our base
7316 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
7319 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
7320 this routine and will wrap the call in a try/catch block. Deal
7323 2002-01-11 Miguel de Icaza <miguel@ximian.com>
7325 * ecore.cs (Expression.MemberLookup): instead of taking a
7326 parameter `same_type' that was used to tell whether we could
7327 access private members we compute our containing type from the
7330 (FieldExpr): Added partial support for volatile fields. This does
7331 not work for volatile fields exposed from assemblies, as I can not
7332 figure out how to extract the modreq from it.
7334 Updated all the source files to use this.
7336 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
7337 because it is referenced by MemberLookup very often.
7339 2002-01-09 Ravi Pratap <ravi@ximian.com>
7341 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
7342 TypeBuilder.GetCustomAttributes to retrieve what we need.
7344 Get rid of redundant default_member_attr_type as this is the same as
7345 default_member_type which already exists.
7347 * interface.cs, attribute.cs : Update accordingly.
7349 2002-01-08 Miguel de Icaza <miguel@ximian.com>
7351 * typemanager.cs: Enable IndexerPropertyName again. It does not
7352 work for TYpeBuilders though. Ravi, can you please fix this?
7354 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
7356 * expression.cs (Argument.Emit): Handle the case of ref objects
7357 being passed to ref functions;
7359 (ParameterReference.EmitLoad): Loads the content of the pointer
7360 without dereferencing.
7362 2002-01-07 Miguel de Icaza <miguel@ximian.com>
7364 * cs-tokenizer.cs: Implemented the pre-processing expressions.
7366 2002-01-08 Ravi Pratap <ravi@ximian.com>
7368 * class.cs (Indexer.DefineMethod): Incorporate the interface
7369 type in the name of the method if we are doing explicit interface
7372 * expression.cs (ConversionExists): Remove as it is completely obsolete.
7374 (BetterConversion): Fix extremely trivial bug where we were referring to
7375 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
7378 * ../errors/bug16.cs : Add although we have fixed it.
7380 2002-01-07 Miguel de Icaza <miguel@ximian.com>
7382 * expression.cs (BaseIndexer): Begin implementation.
7384 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
7386 * cs-parser.jay (indexer_declarator): Use qualified_identifier
7387 production directly to remove a shift/reduce, and implement
7388 explicit interface implementation.
7390 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
7391 after a floating point suffix.
7393 * expression.cs (DoNumericPromotions): Improved the conversion for
7394 uint/uint. If we have a constant, we avoid doing a typecast to a
7397 * class.cs (Indexer): Implement explicit interface implementation
7400 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
7402 * class.cs: make the default instance constructor public and hidebysig.
7404 2001-01-03 Ravi Pratap <ravi@ximian.com>
7406 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
7407 so we can call it from elsewhere.
7409 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
7410 we emit it internally if the class has a defined indexer; otherwise the user
7411 emits it by decorating the class definition with the DefaultMemberAttribute.
7413 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
7414 attribute is not used on a type which defines an indexer.
7416 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
7417 character when we skip whitespace.
7419 * ../errors/cs0646.cs : Add.
7421 2002-01-03 Miguel de Icaza <miguel@ximian.com>
7423 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
7426 * makefile: Add practical target `mcs3.exe' which builds the third
7427 generation compiler.
7429 * expression.cs (New): Fix structures constructor calling.
7431 * class.cs (Property, Method, Indexer): Emit Final flag on the
7432 method if we are an interface implementation and we are not
7435 * ecore.cs (PropertyExpr): New public field `IsBase', tells
7436 whether this property is referencing a `base' method.
7438 * expression.cs (Invocation.EmitCall): take an extra argument:
7439 is_base, this is used to determine whether the `call' or
7440 `callvirt' opcode should be used.
7443 * delegate.cs: update EmitCall.
7445 * class.cs (Method.Define): Set NewSlot for the cases where we are
7446 not implementing an interface method.
7448 (Property.Define): ditto.
7450 2002-01-02 Miguel de Icaza <miguel@ximian.com>
7452 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
7453 'r'. Allows mcs to parse itself fully.
7455 2002-01-02 Ravi Pratap <ravi@ximian.com>
7457 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
7458 of the number of initializers that require the InitializeArray method.
7460 (CheckIndices): Store the Expression in all cases - not the plain value. Also
7461 update the above field where necessary.
7463 (MakeByteBlob): Update accordingly.
7465 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
7468 (EmitDynamicInitializers): Update in accordance with the new optimization.
7470 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
7471 same OpCode applies.
7473 * cs-parser.jay : Fix some glaring errors I introduced.
7475 2002-01-01 Ravi Pratap <ravi@ximian.com>
7477 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
7478 so that we can check for name clashes there too.
7480 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
7481 for interface indexers.
7483 * interfaces.cs (Define): Emit the default member attribute.
7485 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
7486 variable was being referred to while setting the value ;-)
7488 2002-01-01 Miguel de Icaza <miguel@ximian.com>
7490 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
7491 byte-by-byte information when we know the data is zero.
7493 Make the block always a multiple of 4, because
7494 DefineInitializedData has a bug.
7496 * assign.cs: Fix, we should assign from the temporary, not from
7499 * expression.cs (MakeByteBlob): Fix my incorrect code.
7501 2001-12-31 Miguel de Icaza <miguel@ximian.com>
7503 * typemanager.cs (EnumToUnderlying): This function is used to get
7504 the underlying type from an enumeration, because it does not
7507 * constant.cs: Use the I4_S form for values between -128 and 127.
7509 * statement.cs (Block.LookupLabel): Looks up a label.
7510 (Block): Drop support for labeled blocks.
7512 (LabeledStatement): New kind of statement that represents a label
7515 (Goto): Finally implement this bad boy.
7517 * cs-parser.jay: Update to reflect new mechanism to implement
7520 2001-12-30 Miguel de Icaza <miguel@ximian.com>
7522 * codegen.cs (EmitContext.This): a codegen property that keeps the
7523 a single instance of this instead of creating many different this
7526 * delegate.cs (Delegate.DoResolve): Update to use the property;
7528 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
7530 * expression.cs (BaseAccess.DoResolve): Ditto.
7532 2001-12-29 Ravi Pratap <ravi@ximian.com>
7534 * typemanager.cs (methodimpl_attr_type): Add to hold the type
7535 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
7537 (InitCoreTypes): Update accordingly.
7539 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
7540 so we can quickly store the state.
7542 (ApplyAttributes): Set the correct implementation flags
7543 for InternalCall methods.
7545 2001-12-29 Miguel de Icaza <miguel@ximian.com>
7547 * expression.cs (EmitCall): if a method is not virtual, then do
7548 not use callvirt on it.
7550 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
7551 user defined stuff) requires the use of stobj, which takes an
7552 address on the stack instead of an array and an index. So emit
7553 the Ldelema operation for it.
7555 (EmitStoreOpcode): Use stobj for valuetypes.
7557 (UnaryMutator.EmitCode): Use the right 1 value depending on
7558 whether we are dealing with int64/uint64, float or doubles.
7560 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
7561 constructors that I implemented last night.
7563 (Constructor.IsDefault): Fix to work properly for static
7566 * cs-parser.jay (CheckDef): report method signature errors.
7567 Update error number 103 to be 132.
7569 * decl.cs: New AdditionResult enumeration value: MethodExists.
7570 Although we do this check for methods later on in the semantic
7571 analysis, catching repeated default constructors is so easy that
7572 we catch these here.
7574 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
7577 (ParameterReference.EmitAssign, Emit): handle
7580 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
7581 (ArrayAccess.EmitStoreOpcode): ditto.
7583 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
7585 * expression.cs (MakeByteBlob): Complete all the missing types
7586 (uint, short, ushort, byte, sbyte)
7588 * class.cs: Only init instance field initializers on instance
7591 Rename `constructors' to instance_constructors.
7593 (TypeContainer.AddConstructor): Only add constructors to the list
7594 if it is not static.
7596 Make sure that we handle default_static_constructor independently
7597 everywhere where we handle instance_constructors
7599 2001-12-28 Miguel de Icaza <miguel@ximian.com>
7601 * class.cs: Do not lookup or create a base initializer for a
7604 (ConstructorInitializer.Resolve): use the proper type to lookup
7607 * cs-parser.jay: Report error 1585 (modifiers between type and name).
7609 * enum.cs, interface.cs: Remove CloseType, this is taken care by
7612 * decl.cs: CloseType is now an virtual method, the default
7613 implementation just closes this type.
7615 2001-12-28 Ravi Pratap <ravi@ximian.com>
7617 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
7618 to PreserveSig by default. Also emit HideBySig on such methods.
7620 Basically, set the defaults to standard values.
7622 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
7623 argument, if candidate is better, it can't be worse than the best !
7625 (Invocation): Re-write bits to differentiate between methods being
7626 applicable in their expanded form and their normal form - for params
7629 Get rid of use_standard everywhere as only standard conversions are allowed
7630 in overload resolution.
7632 More spec conformance.
7634 2001-12-27 Miguel de Icaza <miguel@ximian.com>
7636 * driver.cs: Add --timestamp, to see where the compiler spends
7639 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
7640 `this' in static code.
7642 (SimpleName.DoResolve): Implement in terms of a helper function
7643 that allows static-references to be passed upstream to
7646 (Expression.ResolveWithSimpleName): Resolve specially simple
7647 names when called by MemberAccess to implement the special
7650 (Expression.ImplicitReferenceConversion): Handle conversions from
7651 Null to reference types before others, as Null's type is
7654 * expression.cs (Invocation.EmitCall): Handle the special case of
7655 calling methods declared on a reference type from a ValueType
7656 (Base classes System.Object and System.Enum)
7658 (MemberAccess.Resolve): Only perform lookups on Enumerations if
7659 the left hand side is a TypeExpr, not on every enumeration.
7661 (Binary.Resolve): If types are reference types, then do a cast to
7662 object on operators != and == of both arguments.
7664 * typemanager.cs (FindMembers): Extract instance and static
7665 members if requested.
7667 * interface.cs (PopulateProperty): Use void_type instead of null
7668 as the return type for the setter method.
7670 (PopulateIndexer): ditto.
7672 2001-12-27 Ravi Pratap <ravi@ximian.com>
7674 * support.cs (ReflectionParameters): Fix minor bug where we
7675 were examining the wrong parameter for the ParamArray attribute.
7677 Cope with requests for the type of the parameter at position
7678 greater than the params parameter's. We now return the element
7679 type of the params array as that makes more sense.
7681 * expression.cs (Invocation.IsParamsMethodApplicable): Update
7682 accordingly as we no longer have to extract the element type
7685 (Invocation.OverloadResolve): Update.
7687 2001-12-27 Miguel de Icaza <miguel@ximian.com>
7689 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
7690 against IEnumerator, test whether the return value is a descendant
7691 of the IEnumerator interface.
7693 * class.cs (Indexer.Define): Use an auxiliary method to implement
7694 the other bits of the method definition. Begin support for
7695 explicit interface implementation.
7697 (Property.DefineMethod): Use TypeManager.void_type instead of null
7698 for an empty return value.
7700 2001-12-26 Miguel de Icaza <miguel@ximian.com>
7702 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
7703 dealing with a FieldExpr which is composed of a FieldBuilder, in
7704 the code path we did extract the constant, but we should have
7705 obtained the underlying value to be able to cast it (otherwise we
7706 end up in an infinite loop, this is what Ravi was running into).
7708 (ArrayCreation.UpdateIndices): Arrays might be empty.
7710 (MemberAccess.ResolveMemberAccess): Add support for section
7711 14.5.4.1 that deals with the special case of E.I when E is a type
7712 and something else, that I can be a reference to a static member.
7714 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
7715 handle a particular array type to create byte blobs, it is just
7716 something we dont generate byteblobs for.
7718 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
7721 * location.cs (Push): remove the key from the hashtable that we
7722 are about to add. This happens for empty files.
7724 * driver.cs: Dispose files after we have parsed them.
7726 (tokenize): new function that only runs the tokenizer on its
7727 input, for speed testing.
7729 2001-12-26 Ravi Pratap <ravi@ximian.com>
7731 * class.cs (Event.Define): Define the private field only if there
7732 are no accessors defined.
7734 * expression.cs (ResolveMemberAccess): If there is no associated
7735 field with the event, that means we have an event defined with its
7736 own accessors and we should flag error cs0070 since transforming
7737 ourselves into a field is not valid in that case.
7739 * ecore.cs (SimpleName.DoResolve): Same as above.
7741 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
7742 and charset to sane values.
7744 2001-12-25 Ravi Pratap <ravi@ximian.com>
7746 * assign.cs (DoResolve): Perform check on events only if they
7747 are being accessed outside the declaring type.
7749 * cs-parser.jay (event_declarations): Update rules to correctly
7750 set the type of the implicit parameter etc.
7752 (add_accessor, remove_accessor): Set current local parameters.
7754 * expression.cs (Binary): For delegate addition and subtraction,
7755 cast the return value from the method into the appropriate delegate
7758 2001-12-24 Ravi Pratap <ravi@ximian.com>
7760 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
7761 of these as the workaround is unnecessary.
7763 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
7764 delegate data - none of that is needed at all.
7766 Re-write bits to extract the instance expression and the delegate method
7769 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
7772 * attribute.cs (ApplyAttributes): New method to take care of common tasks
7773 of attaching attributes instead of duplicating code everywhere.
7775 * everywhere : Update code to do attribute emission using the above method.
7777 2001-12-23 Miguel de Icaza <miguel@ximian.com>
7779 * expression.cs (IsParamsMethodApplicable): if there are not
7780 parameters, return immediately.
7782 * ecore.cs: The 0 literal can be implicity converted to an enum
7785 (SimpleName.DoResolve): First lookup the type, then lookup the
7788 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
7789 want to get its address. If the InstanceExpression is not
7790 addressable, store the result in a temporary variable, then get
7793 * codegen.cs: Only display 219 errors on warning level or above.
7795 * expression.cs (ArrayAccess): Make it implement the
7796 IMemoryLocation interface.
7798 (Binary.DoResolve): handle the operator == (object a, object b)
7799 and operator != (object a, object b) without incurring into a
7800 BoxedCast (because 5 != o should never be performed).
7802 Handle binary enumerator operators.
7804 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
7805 value type, otherwise use Ldelem_ref.
7807 Use precomputed names;
7809 (AddressOf): Implement address of
7811 * cs-parser.jay (labeled_statement): Fix recursive block
7812 addition by reworking the production.
7814 * expression.cs (New.DoEmit): New has a special case:
7816 If we are dealing with a ValueType, we have a few
7817 situations to deal with:
7819 * The target of New is a ValueType variable, that is
7820 easy, we just pass this as the variable reference
7822 * The target of New is being passed as an argument,
7823 to a boxing operation or a function that takes a
7826 In this case, we need to create a temporary variable
7827 that is the argument of New.
7830 2001-12-23 Ravi Pratap <ravi@ximian.com>
7832 * rootcontext.cs (LookupType): Check that current_type is not null before
7833 going about looking at nested types.
7835 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
7836 not implement the IAssignMethod interface any more.
7838 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
7839 where we tranform them into FieldExprs if they are being resolved from within
7842 * ecore.cs (SimpleName.DoResolve): Do the same here.
7844 * assign.cs (DoResolve, Emit): Clean up code considerably.
7846 * ../errors/bug10.cs : Add.
7848 * ../errors/cs0070.cs : Add.
7850 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
7852 * assign.cs : Get rid of EventIsLocal everywhere.
7854 2001-12-23 Miguel de Icaza <miguel@ximian.com>
7856 * ecore.cs (ConvertIntLiteral): finished the implementation.
7858 * statement.cs (SwitchLabel): Convert the value we are using as a
7859 key before looking up the table.
7861 2001-12-22 Miguel de Icaza <miguel@ximian.com>
7863 * codegen.cs (EmitTopBlock): Require a Location argument now.
7865 * cs-parser.jay (constructor_declarator): We need to setup
7866 current_local_parameters before we parse the
7867 opt_constructor_initializer, to allow the variables to be bound
7868 to the constructor arguments.
7870 * rootcontext.cs (LookupType): First lookup nested classes in our
7871 class and our parents before we go looking outside our class.
7873 * expression.cs (ConstantFold): Extract/debox the values at the
7876 * rootcontext.cs (EmitCode): Resolve the constants first before we
7877 resolve the types. This is not really needed, but it helps debugging.
7879 * statement.cs: report location.
7881 * cs-parser.jay: pass location to throw statement.
7883 * driver.cs: Small bug fix.
7885 * report.cs: Updated format to be 4-zero filled digits.
7887 2001-12-22 Ravi Pratap <ravi@ximian.com>
7889 * expression.cs (CheckIndices): Fix minor bug where the wrong
7890 variable was being referred to ;-)
7892 (DoEmit): Do not call EmitStaticInitializers when the
7893 underlying type is System.Object.
7895 2001-12-21 Ravi Pratap <ravi@ximian.com>
7897 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
7898 and do the usual workaround for SRE.
7900 * class.cs (MyEventBuilder.EventType): New member to get at the type
7901 of the event, quickly.
7903 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
7905 * assign.cs (Assign.DoResolve): Handle the case when the target
7906 is an EventExpr and perform the necessary checks.
7908 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
7911 (SimpleName.MemberStaticCheck): Include check for EventExpr.
7913 (EventExpr): Set the type in the constructor itself since we
7914 are meant to be born fully resolved.
7916 (EventExpr.Define): Revert code I wrote earlier.
7918 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
7919 instance expression is null. The instance expression is a This in that case
7920 or a null, depending on whether it is a static method or not.
7922 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
7923 refers to more than one method.
7925 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
7926 and accordingly flag errors.
7928 2001-12-21 Miguel de Icaza <miguel@ximian.com>
7930 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
7932 2001-12-22 Miguel de Icaza <miguel@ximian.com>
7934 * location.cs (ToString): Provide useful rutine.
7936 2001-12-21 Miguel de Icaza <miguel@ximian.com>
7938 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
7939 objects, return the actual integral boxed.
7941 * statement.cs (SwitchLabel): define an ILLabel for each
7944 (Switch.CheckSwitch): If the value is a Literal, extract
7945 the underlying literal.
7947 Also in the unused hashtable we had, add the SwitchLabel so we can
7948 quickly look this value up.
7950 * constant.cs: Implement a bunch of new constants. Rewrite
7951 Literal based on this. Made changes everywhere to adapt to this.
7953 * expression.cs (Expression.MakeByteBlob): Optimize routine by
7954 dereferencing array only once, and also copes with enumrations.
7956 bytes are two bytes wide, not one.
7958 (Cast): Perform constant conversions.
7960 * ecore.cs (TryImplicitIntConversion): Return literals instead of
7961 wrappers to the literals here.
7963 * expression.cs (DoNumericPromotions): long literals can converted
7964 to ulong implicity (this is taken care of elsewhere, but I was
7967 * ecore.cs (Expression.Literalize): Make the return type Literal,
7968 to improve type checking.
7970 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
7972 2001-12-20 Miguel de Icaza <miguel@ximian.com>
7974 * literal.cs: Revert code from ravi that checked the bounds. The
7975 bounds are sane by the definition of the type itself.
7977 * typemanager.cs: Fix implementation of ImplementsInterface. We
7978 need to actually look up in our parent hierarchy for interfaces
7981 * const.cs: Use the underlying type for enumerations
7983 * delegate.cs: Compute the basename for the delegate creation,
7984 that should fix the delegate test case, and restore the correct
7985 Type Lookup semantics in rootcontext
7987 * rootcontext.cs: Revert Ravi's last patch. The correct way of
7988 referencing a nested type with the Reflection API is using the "+"
7991 * cs-parser.jay: Do not require EOF token at the end.
7993 2001-12-20 Ravi Pratap <ravi@ximian.com>
7995 * rootcontext.cs (LookupType): Concatenate type names with
7996 a '.' instead of a '+' The test suite passes again.
7998 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
7999 field of the enumeration.
8001 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
8002 the case when the member is an EventExpr.
8004 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
8005 static has an associated instance expression.
8007 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
8009 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
8011 * class.cs (Event.Define): Register event and perform appropriate checks
8014 We define the Add and Remove methods even if the use provides none because
8015 in that case, we provide default implementations ourselves.
8017 Define a private field of the type of the event. This is done by the CSC compiler
8018 and we should be doing it too ;-)
8020 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
8021 More methods we use in code we generate.
8023 (multicast_delegate_type, delegate_type): Two separate types since the distinction
8026 (InitCoreTypes): Update accordingly for the above.
8028 * class.cs (Event.Emit): Generate code for default accessors that we provide
8030 (EmitDefaultMethod): Do the job in the above.
8032 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
8035 2001-12-20 Miguel de Icaza <miguel@ximian.com>
8037 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
8038 builders even if we were missing one.
8040 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
8041 pass the Basename as our class name instead of the Name. The
8042 basename will be correctly composed for us.
8044 * parameter.cs (Paramters): Now takes a Location argument.
8046 * decl.cs (DeclSpace.LookupType): Removed convenience function and
8047 make all the code call directly LookupType in RootContext and take
8048 this chance to pass the Location information everywhere.
8050 * Everywhere: pass Location information.
8052 2001-12-19 Miguel de Icaza <miguel@ximian.com>
8054 * class.cs (Constructor.Define): Updated way of detecting the
8055 length of the parameters.
8057 (TypeContainer.DefineType): Use basename as the type name for
8060 (TypeContainer.Define): Do not recursively define types here, as
8061 definition is taken care in order by the RootContext.
8063 * tree.cs: Keep track of namespaces in a per-file basis.
8065 * parameter.cs (Parameter.ComputeSignature): Update to use
8068 (Parameters.GetSignature): ditto.
8070 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
8071 instead of a TypeContainer.
8073 (Interface.SemanticAnalysis): Use `this' instead of our parent to
8074 resolve names. Because we need to be resolve in our context, not
8077 * driver.cs: Implement response files.
8079 * class.cs (TypeContainer.DefineType): If we are defined, do not
8082 (Event.Emit): Emit the code for add/remove handlers.
8083 (Event.Define): Save the MethodBuilders for add/remove.
8085 * typemanager.cs: Use pair here too.
8087 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
8088 DictionaryEntry requires the first argument to be non-null.
8090 (enum_declaration): Compute full name for registering the
8093 (delegate_declaration): Instead of using
8094 formal_parameter_list, use opt_formal_parameter_list as the list
8097 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
8098 (EventParsing): New property that controls whether `add' and
8099 `remove' are returned as tokens or identifiers (for events);
8101 2001-12-19 Ravi Pratap <ravi@ximian.com>
8103 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
8104 use MyEventBuilder only and let it wrap the real builder for us.
8106 (MyEventBuilder): Revamp constructor etc.
8108 Implement all operations that we perform on EventBuilder in precisely the same
8111 (FindMembers): Update to use the EventBuilder member.
8113 (Event.Emit): Update accordingly.
8115 2001-12-18 Ravi Pratap <ravi@ximian.com>
8117 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
8118 by calling the appropriate methods.
8120 (GetCustomAttributes): Make stubs as they cannot possibly do anything
8123 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
8125 2001-12-17 Ravi Pratap <ravi@ximian.com>
8127 * delegate.cs (Delegate.Populate): Check that the return type
8128 and various parameters types are indeed accessible.
8130 * class.cs (Constructor.Define): Same here.
8132 (Field.Define): Ditto.
8134 (Event.Define): Ditto.
8136 (Operator.Define): Check that the underlying Method defined itself
8137 correctly - so it's MethodBuilder should not be null.
8139 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
8140 expression happens to be null.
8142 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
8143 members but as of now we don't seem to be able to do anything really useful with it.
8145 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
8146 not the EventBuilder.
8148 2001-12-18 Miguel de Icaza <miguel@ximian.com>
8150 * cs-tokenizer.cs: Add support for defines.
8151 Add support for #if, #elif, #else, #endif
8153 (eval_var): evaluates a variable.
8154 (eval): stubbed for evaluating functions.
8156 * cs-parser.jay: Pass the defines information
8158 * driver.cs: Add --define command line option.
8160 * decl.cs: Move MemberCore here.
8162 Make it the base class for DeclSpace. This allows us to catch and
8163 report 108 and 109 for everything now.
8165 * class.cs (TypeContainer.Define): Extract all the members
8166 before populating and emit the warning 108 (new keyword required
8167 to override) instead of having each member implement this.
8169 (MemberCore.Define): New abstract method, we will be using this in
8170 the warning reporting engine in Populate.
8172 (Operator.Define): Adjust to new MemberCore protocol.
8174 * const.cs (Const): This does not derive from Expression, it is a
8175 temporary object we use to create fields, it is a MemberCore.
8177 * class.cs (Method.Define): Allow the entry point to be in a
8180 * driver.cs: Rewrite the argument handler to clean it up a bit.
8182 * rootcontext.cs: Made it just an auxiliary namespace feature by
8183 making everything static.
8185 * driver.cs: Adapt code to use RootContext type name instead of
8188 * delegate.cs: Remove RootContext argument.
8190 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
8193 * class.cs (Event.Define): The lookup can fail.
8195 * cs-tokenizer.cs: Begin implementation of pre-procesor.
8197 * expression.cs: Resolve the this instance before invoking the code.
8199 2001-12-17 Miguel de Icaza <miguel@ximian.com>
8201 * cs-parser.jay: Add a production in element_access that allows
8202 the thing to become a "type" reference. This way we can parse
8203 things like "(string [])" as a type.
8205 Note that this still does not handle the more complex rules of
8209 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
8211 * ecore.cs: (CopyNewMethods): new utility function used to
8212 assemble the list of methods from running FindMembers.
8214 (MemberLookup): Rework FindMembers so that
8216 2001-12-16 Miguel de Icaza <miguel@ximian.com>
8218 * class.cs (TypeContainer): Remove Delegates who fail to be
8221 * delegate.cs (Populate): Verify that we dont get null return
8222 values. TODO: Check for AsAccessible.
8224 * cs-parser.jay: Use basename to emit error 574 (destructor should
8225 have the same name as container class), not the full name.
8227 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
8228 possible representation.
8230 Also implements integer type suffixes U and L.
8232 2001-12-15 Miguel de Icaza <miguel@ximian.com>
8234 * expression.cs (ArrayCreation.DoResolve): We need to do the
8235 argument resolution *always*.
8237 * decl.cs: Make this hold the namespace. Hold the root context as
8239 (LookupType): Move here.
8241 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
8243 * location.cs (Row, Name): Fixed the code, it was always returning
8244 references to the first file.
8246 * interface.cs: Register properties defined through interfaces.
8248 * driver.cs: Add support for globbing on the command line
8250 * class.cs (Field): Make it derive from MemberCore as well.
8253 2001-12-15 Ravi Pratap <ravi@ximian.com>
8255 * class.cs (Event::Define): Check that the type of the event is a delegate
8256 type else flag error #66.
8258 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
8261 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
8262 values of EntryPoint, CharSet etc etc.
8264 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
8266 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
8267 be null and we should ignore this. I am not sure if this is really clean. Apparently,
8268 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
8269 which needs this to do its work.
8271 * ../errors/cs0066.cs : Add.
8273 2001-12-14 Miguel de Icaza <miguel@ximian.com>
8275 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
8278 * class.cs: (MethodSignature.MethodSignature): Removed hack that
8279 clears out the parameters field.
8280 (MemberSignatureCompare): Cleanup
8282 (MemberCore): New base class used to share code between MethodCore
8285 (RegisterRequiredImplementations) BindingFlags.Public requires
8286 either BindingFlags.Instace or Static. Use instance here.
8288 (Property): Refactored code to cope better with the full spec.
8290 * parameter.cs (GetParameterInfo): Return an empty array instead
8293 * class.cs (Property): Abstract or extern properties have no bodies.
8295 * parameter.cs (GetParameterInfo): return a zero-sized array.
8297 * class.cs (TypeContainer.MethodModifiersValid): Move all the
8298 method modifier validation to the typecontainer so we can reuse
8301 (MethodCore.ParameterTypes): return an empty sized array of types.
8303 (Property.Define): Test property modifier validity.
8305 Add tests for sealed/override too.
8307 (Method.Emit): abstract or extern methods have no bodies.
8309 2001-12-14 Ravi Pratap <ravi@ximian.com>
8311 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
8314 (Method::Define, ::Emit): Modify accordingly.
8316 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
8318 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
8320 * makefile: Pass in /unsafe.
8322 2001-12-13 Miguel de Icaza <miguel@ximian.com>
8324 * class.cs (MakeKey): Kill routine.
8326 * class.cs (TypeContainer.Define): Correctly define explicit
8327 method implementations (they require the full interface name plus
8330 * typemanager.cs: Deply the PtrHashtable here and stop using the
8331 lame keys. Things work so much better.
8333 This of course broke everyone who depended on `RegisterMethod' to
8334 do the `test for existance' test. This has to be done elsewhere.
8336 * support.cs (PtrHashtable): A hashtable that avoid comparing with
8337 the object stupid Equals method (because, that like fails all over
8338 the place). We still do not use it.
8340 * class.cs (TypeContainer.SetRequiredInterface,
8341 TypeContainer.RequireMethods): Killed these two routines and moved
8342 all the functionality to RegisterRequiredImplementations.
8344 (TypeContainer.RegisterRequiredImplementations): This routine now
8345 registers all the implementations required in an array for the
8346 interfaces and abstract methods. We use an array of structures
8347 which can be computed ahead of time to reduce memory usage and we
8348 also assume that lookups are cheap as most classes will not
8349 implement too many interfaces.
8351 We also avoid creating too many MethodSignatures.
8353 (TypeContainer.IsInterfaceMethod): Update and optionally does not
8354 clear the "pending" bit if we find that there are problems with
8357 (TypeContainer.VerifyPendingMethods): Update to report errors of
8358 methods that look like implementations but are not.
8360 (TypeContainer.Define): Add support for explicit interface method
8363 2001-12-12 Miguel de Icaza <miguel@ximian.com>
8365 * typemanager.cs: Keep track of the parameters here instead of
8366 being a feature of the TypeContainer.
8368 * class.cs: Drop the registration of parameters here, as
8369 InterfaceMethods are also interface declarations.
8371 * delegate.cs: Register methods with the TypeManager not only with
8372 the TypeContainer. This code was buggy.
8374 * interface.cs: Full registation here.
8376 2001-12-11 Miguel de Icaza <miguel@ximian.com>
8378 * expression.cs: Remove reducer for binary expressions, it can not
8381 * const.cs: Put here the code that used to go into constant.cs
8383 * constant.cs: Put here the code for constants, this is a new base
8386 * literal.cs: Make Literal derive from Constant.
8388 2001-12-09 Miguel de Icaza <miguel@ximian.com>
8390 * statement.cs (Return.Emit): Report error 157 if the user
8391 attempts to return from a finally block.
8393 (Return.Emit): Instead of emitting a return, jump to the end of
8396 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
8397 LocalBuilder to store the result of the function. ReturnLabel is
8398 the target where we jump.
8401 2001-12-09 Radek Doulik <rodo@ximian.com>
8403 * cs-parser.jay: remember alias in current namespace
8405 * ecore.cs (SimpleName::DoResolve): use aliases for types or
8408 * class.cs (LookupAlias): lookup alias in my_namespace
8410 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
8412 (LookupAlias): lookup alias in this and if needed in parent
8415 2001-12-08 Miguel de Icaza <miguel@ximian.com>
8419 * rootcontext.cs: (ModuleBuilder) Made static, first step into
8420 making things static. I need this to avoid passing the
8421 TypeContainer when calling ParameterType.
8423 * support.cs (InternalParameters.ParameterType): Remove ugly hack
8424 that did string manipulation to compute the type and then call
8425 GetType. Use Parameter.ParameterType instead.
8427 * cs-tokenizer.cs: Consume the suffix for floating values.
8429 * expression.cs (ParameterReference): figure out whether this is a
8430 reference parameter or not. Kill an extra variable by computing
8431 the arg_idx during emission.
8433 * parameter.cs (Parameters.GetParameterInfo): New overloaded
8434 function that returns whether a parameter is an out/ref value or not.
8436 (Parameter.ParameterType): The type of the parameter (base,
8437 without ref/out applied).
8439 (Parameter.Resolve): Perform resolution here.
8440 (Parameter.ExternalType): The full type (with ref/out applied).
8442 * statement.cs (Using.Emit, Using.EmitExpression): Implement
8443 support for expressions on the using statement.
8445 2001-12-07 Miguel de Icaza <miguel@ximian.com>
8447 * statement.cs (Using.EmitLocalVariableDecls): Split the
8448 localvariable handling of the using statement.
8450 (Block.EmitMeta): Keep track of variable count across blocks. We
8451 were reusing slots on separate branches of blocks.
8453 (Try.Emit): Emit the general code block, we were not emitting it.
8455 Check the type of the declaration to be an IDisposable or
8456 something that can be implicity converted to it.
8458 Emit conversions if required.
8460 * ecore.cs (EmptyExpression): New utility class.
8461 (Expression.ImplicitConversionExists): New utility function.
8463 2001-12-06 Miguel de Icaza <miguel@ximian.com>
8465 * statement.cs (Using): Implement.
8467 * expression.cs (LocalVariableReference): Support read only variables.
8469 * statement.cs: Remove the explicit emit for the Leave opcode.
8470 (VariableInfo): Add a readonly field.
8472 2001-12-05 Miguel de Icaza <miguel@ximian.com>
8474 * ecore.cs (ConvCast): new class used to encapsulate the various
8475 explicit integer conversions that works in both checked and
8478 (Expression.ConvertNumericExplicit): Use new ConvCast class to
8479 properly generate the overflow opcodes.
8481 2001-12-04 Miguel de Icaza <miguel@ximian.com>
8483 * statement.cs: The correct type for the EmptyExpression is the
8484 element_type, not the variable type. Ravi pointed this out.
8486 2001-12-04 Ravi Pratap <ravi@ximian.com>
8488 * class.cs (Method::Define): Handle PInvoke methods specially
8489 by using DefinePInvokeMethod instead of the usual one.
8491 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
8492 above to do the task of extracting information and defining the method.
8494 2001-12-04 Ravi Pratap <ravi@ximian.com>
8496 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
8497 of the condition for string type.
8499 (Emit): Move that here.
8501 (ArrayCreation::CheckIndices): Keep string literals in their expression
8504 (EmitDynamicInitializers): Handle strings appropriately.
8506 2001-12-04 Miguel de Icaza <miguel@ximian.com>
8508 * codegen.cs (EmitContext): Replace multiple variables with a
8509 single pointer to the current Switch statement.
8511 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
8514 2001-12-03 Miguel de Icaza <miguel@ximian.com>
8518 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
8521 (Foreach.Emit): Foreach on arrays was not setting
8522 up the loop variables (for break/continue).
8524 (GotoCase): Semi-implented.
8526 2001-12-03 Ravi Pratap <ravi@ximian.com>
8528 * attribute.cs (CheckAttribute): Handle system attributes by using
8529 Attribute.GetAttributes to examine information we need.
8531 (GetValidPlaces): Same here.
8533 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
8535 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
8537 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
8539 (Method::Define): Set appropriate flags if we have a DllImport attribute.
8541 (Method::Emit): Handle the case when we are a PInvoke method.
8543 2001-12-03 Miguel de Icaza <miguel@ximian.com>
8545 * expression.cs: Use ResolveWithSimpleName on compound names.
8547 2001-12-02 Ravi Pratap <ravi@ximian.com>
8549 * constant.cs (EmitConstant): Make sure we resolve the associated expression
8550 before trying to reduce it.
8552 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
8554 * constant.cs (LookupConstantValue): Implement.
8556 (EmitConstant): Use the above in emitting the constant.
8558 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
8559 that are user-defined by doing a LookupConstantValue on them.
8561 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
8564 2001-11-29 Miguel de Icaza <miguel@ximian.com>
8566 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
8568 (BaseAccess.DoResolve): Implement.
8570 (MemberAccess.DoResolve): Split this routine into a
8571 ResolveMemberAccess routine that can be used independently
8573 2001-11-28 Miguel de Icaza <miguel@ximian.com>
8575 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
8576 As that share bits of the implementation. Is returns a boolean,
8577 while As returns the Type that is being probed.
8579 2001-12-01 Ravi Pratap <ravi@ximian.com>
8581 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
8582 instead of a Literal - much easier.
8584 (EnumInTransit): Remove - utterly useless :-)
8586 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
8588 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
8590 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
8591 chain when we have no associated expression.
8593 2001-11-30 Ravi Pratap <ravi@ximian.com>
8595 * constant.cs (Define): Use Location while reporting the errror.
8597 Also emit a warning when 'new' is used and there is no inherited
8600 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
8603 (LookupEnumValue): Implement to lookup an enum member's value and define it
8606 (Populate): Re-write accordingly to use the above routine.
8608 2001-11-27 Miguel de Icaza <miguel@ximian.com>
8610 * expression.cs (This): Fix prototype for DoResolveLValue to
8611 override the base class DoResolveLValue.
8613 * cs-parser.cs: Report errors cs574 and cs575 (destructor
8616 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
8617 (we need to load the address of the field here). This fixes
8620 (FieldExpr.DoResolveLValue): Call the DoResolve
8621 function to initialize the Instance expression.
8623 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
8624 correctly the GetEnumerator operation on a value type.
8626 * cs-parser.jay: Add more simple parsing error catches.
8628 * statement.cs (Switch): Add support for string switches.
8629 Handle null specially.
8631 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
8633 2001-11-28 Ravi Pratap <ravi@ximian.com>
8635 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
8637 (declare_local_constant): New helper function.
8639 * statement.cs (AddConstant): Keep a separate record of constants
8641 (IsConstant): Implement to determine if a variable is a constant.
8643 (GetConstantExpression): Implement.
8645 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
8647 * statement.cs (IsVariableDefined): Re-write.
8649 2001-11-27 Ravi Pratap <ravi@ximian.com>
8651 * class.cs (TypeContainer::FindMembers): Look for constants
8652 in the case when we are looking for MemberTypes.Field
8654 * expression.cs (MemberAccess::DoResolve): Check that in the
8655 case we are a FieldExpr and a Literal, we are not being accessed
8656 by an instance reference.
8658 * cs-parser.jay (local_constant_declaration): Implement.
8660 (declaration_statement): Implement for constant declarations.
8662 2001-11-26 Miguel de Icaza <miguel@ximian.com>
8664 * statement.cs (Switch): Catch double defaults.
8666 (Switch): More work on the switch() statement
8667 implementation. It works for integral values now, need to finish
8671 2001-11-24 Miguel de Icaza <miguel@ximian.com>
8673 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
8674 integer literals into other integer literals. To be used by
8677 2001-11-24 Ravi Pratap <ravi@ximian.com>
8679 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
8682 (EmitDynamicInitializers): Cope with the above since we extract data
8683 directly from ArrayData now.
8685 (ExpectInitializers): Keep track of whether initializers are mandatory
8688 (Bounds): Make it a hashtable to prevent the same dimension being
8689 recorded for every element in that dimension.
8691 (EmitDynamicInitializers): Fix bug which prevented the Set array method
8694 Also fix bug which was causing the indices to be emitted in the reverse
8697 2001-11-24 Miguel de Icaza <miguel@ximian.com>
8699 * expression.cs (ArrayCreation): Implement the bits that Ravi left
8700 unfinished. They do not work, because the underlying code is
8703 2001-11-22 Miguel de Icaza <miguel@ximian.com>
8705 * cs-parser.jay: Remove bogus fixme.
8707 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
8708 on Switch statement.
8710 2001-11-23 Ravi Pratap <ravi@ximian.com>
8712 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
8715 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
8716 parameter. Apparently, any expression is allowed.
8718 (ValidateInitializers): Update accordingly.
8720 (CheckIndices): Fix some tricky bugs thanks to recursion.
8722 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
8723 I was being completely brain-dead.
8725 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
8726 and re-write acordingly.
8728 (DelegateInvocation): Re-write accordingly.
8730 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
8732 (MakeByteBlob): Handle types more correctly.
8734 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
8735 initialization from expressions but it is incomplete because I am a complete
8738 2001-11-22 Miguel de Icaza <miguel@ximian.com>
8740 * statement.cs (If.Emit): Fix a bug that generated incorrect code
8741 on If. Basically, we have to return `true' (ie, we do return to
8742 our caller) only if both branches of the if return.
8744 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
8745 short-circuit operators, handle them as short circuit operators.
8747 (Cast.DoResolve): Resolve type.
8748 (Cast.Cast): Take an expression as the target type.
8750 * cs-parser.jay (cast_expression): Remove old hack that only
8751 allowed a limited set of types to be handled. Now we take a
8752 unary_expression and we resolve to a type during semantic
8755 Use the grammar productions from Rhys to handle casts (this is
8756 not complete like Rhys syntax yet, we fail to handle that corner
8757 case that C# has regarding (-x), but we will get there.
8759 2001-11-22 Ravi Pratap <ravi@ximian.com>
8761 * class.cs (EmitFieldInitializer): Take care of the case when we have a
8762 field which is an array type.
8764 * cs-parser.jay (declare_local_variables): Support array initialization too.
8766 * typemanager.cs (MakeKey): Implement.
8768 (everywhere): Use the above appropriately.
8770 * cs-parser.jay (for_statement): Update for array initialization while
8771 declaring variables.
8773 * ecore.cs : The error message was correct, it's the variable's names that
8774 were misleading ;-) Make the code more readable.
8776 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
8777 the correct type etc.
8779 (ConvertExplicit): Handle Enum types by examining the underlying type.
8781 2001-11-21 Ravi Pratap <ravi@ximian.com>
8783 * parameter.cs (GetCallingConvention): Always return
8784 CallingConventions.Standard for now.
8786 2001-11-22 Miguel de Icaza <miguel@ximian.com>
8788 * expression.cs (Binary.ResolveOperator): Update the values of `l'
8789 and `r' after calling DoNumericPromotions.
8791 * ecore.cs: Fix error message (the types were in the wrong order).
8793 * statement.cs (Foreach.ProbeCollectionType): Need to pass
8794 BindingFlags.Instance as well
8796 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
8797 implicit int literal conversion in an empty cast so that we
8798 propagate the right type upstream.
8800 (UnboxCast): new class used to unbox value types.
8801 (Expression.ConvertExplicit): Add explicit type conversions done
8804 (Expression.ImplicitNumericConversion): Oops, forgot to test for
8805 the target type before applying the implicit LongLiterals to ULong
8808 2001-11-21 Miguel de Icaza <miguel@ximian.com>
8810 * cs-parser.jay (for_statement): Reworked the way For works: now
8811 we declare manually any variables that are introduced in
8812 for_initializer to solve the problem of having out-of-band code
8813 emition (that is what got for broken).
8815 (declaration_statement): Perform the actual variable declaration
8816 that used to be done in local_variable_declaration here.
8818 (local_variable_declaration): Do not declare anything, just pass
8819 the information on a DictionaryEntry
8821 2001-11-20 Ravi Pratap <ravi@ximian.com>
8823 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
8824 re-write of the logic to now make it recursive.
8826 (UpdateIndices): Re-write accordingly.
8828 Store element data in a separate ArrayData list in the above methods.
8830 (MakeByteBlob): Implement to dump the array data into a byte array.
8832 2001-11-19 Ravi Pratap <ravi@ximian.com>
8834 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
8837 * constant.cs (Define): Implement.
8839 (EmitConstant): Re-write fully.
8841 Pass in location info.
8843 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
8846 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
8847 DictionaryEntry since we need location info too.
8849 (constant_declaration): Update accordingly.
8851 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
8852 code into another method : UpdateIndices.
8854 2001-11-18 Ravi Pratap <ravi@ximian.com>
8856 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
8857 some type checking etc.
8859 2001-11-17 Ravi Pratap <ravi@ximian.com>
8861 * expression.cs (ArrayCreation::ValidateInitializers): Implement
8862 bits to provide dimension info if the user skips doing that.
8864 Update second constructor to store the rank correctly.
8866 2001-11-16 Ravi Pratap <ravi@ximian.com>
8868 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
8869 and try to implement.
8871 * ../errors/cs0150.cs : Add.
8873 * ../errors/cs0178.cs : Add.
8875 2001-11-16 Miguel de Icaza <miguel@ximian.com>
8877 * statement.cs: Implement foreach on multi-dimensional arrays.
8879 * parameter.cs (Parameters.GetParameterByName): Also lookup the
8880 name of the params argument.
8882 * expression.cs: Use EmitStoreOpcode to get the right opcode while
8883 initializing the array.
8885 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
8886 we can use this elsewhere.
8888 * statement.cs: Finish implementation of foreach for single
8891 * cs-parser.jay: Use an out-of-band stack to pass information
8892 around, I wonder why I need this.
8894 foreach_block: Make the new foreach_block the current_block.
8896 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
8897 function used to return a static Parameters structure. Used for
8898 empty parameters, as those are created very frequently.
8900 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
8902 2001-11-15 Ravi Pratap <ravi@ximian.com>
8904 * interface.cs : Default modifier is private, not public. The
8905 make verify test passes again.
8907 2001-11-15 Ravi Pratap <ravi@ximian.com>
8909 * support.cs (ReflectionParameters): Fix logic to determine
8910 whether the last parameter is a params one. Test 9 passes again.
8912 * delegate.cs (Populate): Register the builders we define with
8913 RegisterParameterForBuilder. Test 19 passes again.
8915 * cs-parser.jay (property_declaration): Reference $6 instead
8916 of $$ to get at the location.
8918 (indexer_declaration): Similar stuff.
8922 * class.cs (Property): Register parameters for the Get and Set methods
8923 if they exist. Test 23 passes again.
8925 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
8926 call to EmitArguments as we are sure there aren't any params arguments.
8927 Test 32 passes again.
8929 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
8930 IndexOutOfRangeException.
8932 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
8933 Test 33 now passes again.
8935 2001-11-15 Miguel de Icaza <miguel@ximian.com>
8937 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
8938 broke a bunch of things. Will have to come up with a better way
8939 of tracking locations.
8941 * statement.cs: Implemented foreach for single dimension arrays.
8943 2001-11-09 Miguel de Icaza <miguel@ximian.com>
8945 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
8946 an error. This removes the lookup from the critical path.
8948 * cs-parser.jay: Removed use of temporary_loc, which is completely
8951 2001-11-14 Miguel de Icaza <miguel@ximian.com>
8953 * support.cs (ReflectionParameters.ParameterModifier): Report
8954 whether the argument is a PARAMS argument or not.
8956 * class.cs: Set the attribute `ParamArrayAttribute' on the
8959 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
8960 and cons_param_array_attribute (ConstructorInfo for
8961 ParamArrayAttribute).,
8963 * codegen.cs: Emit the return using the `Return' statement, that
8964 way we can report the error correctly for missing return values.
8966 * class.cs (Method.Emit): Clean up.
8968 * expression.cs (Argument.Resolve): Take another argument: the
8969 location where this argument is used. Notice that this is not
8970 part of the "Argument" class as to reduce the size of the
8971 structure (we know the approximate location anyways).
8973 Test if the argument is a variable-reference, if not, then
8974 complain with a 206.
8976 (Argument.Emit): Emit addresses of variables.
8978 (Argument.FullDesc): Simplify.
8980 (Invocation.DoResolve): Update for Argument.Resolve.
8982 (ElementAccess.DoResolve): ditto.
8984 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
8985 method should be virtual, as this method is always virtual.
8987 (NewDelegate.DoResolve): Update for Argument.Resolve.
8989 * class.cs (ConstructorInitializer.DoResolve): ditto.
8991 * attribute.cs (Attribute.Resolve): ditto.
8993 2001-11-13 Miguel de Icaza <miguel@ximian.com>
8995 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
8997 * expression.cs (ParameterReference): Drop IStackStorage and implement
8998 IAssignMethod instead.
9000 (LocalVariableReference): ditto.
9002 * ecore.cs (FieldExpr): Drop IStackStorage and implement
9003 IAssignMethod instead.
9005 2001-11-13 Miguel de Icaza <miguel@ximian.com>
9007 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
9008 enumerations that are used in heavily used structures derive from
9009 byte in a laughable and pathetic attempt to reduce memory usage.
9010 This is the kind of pre-optimzations that you should not do at
9011 home without adult supervision.
9013 * expression.cs (UnaryMutator): New class, used to handle ++ and
9014 -- separatedly from the other unary operators. Cleans up the
9015 code, and kills the ExpressionStatement dependency in Unary.
9017 (Unary): Removed `method' and `Arguments' from this class, making
9018 it smaller, and moving it all to SimpleCall, so I can reuse this
9019 code in other locations and avoid creating a lot of transient data
9020 strucutres when not required.
9022 * cs-parser.jay: Adjust for new changes.
9024 2001-11-11 Miguel de Icaza <miguel@ximian.com>
9026 * enum.cs (Enum.Populate): If there is a failure during
9029 * cs-parser.jay (opt_enum_base): we used to catch type errors
9030 here, but this is really incorrect. The type error should be
9031 catched during semantic analysis.
9033 2001-12-11 Ravi Pratap <ravi@ximian.com>
9035 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
9036 current_local_parameters as expected since I, in my stupidity, had forgotten
9039 * attribute.cs (GetValidPlaces): Fix stupid bug.
9041 * class.cs (Method::Emit): Perform check on applicability of attributes.
9043 (Constructor::Emit): Ditto.
9045 (Field::Emit): Ditto.
9047 (Field.Location): Store location information.
9049 (Property, Event, Indexer, Operator): Ditto.
9051 * cs-parser.jay (field_declaration): Pass in location for each field.
9053 * ../errors/cs0592.cs : Add.
9055 2001-11-12 Ravi Pratap <ravi@ximian.com>
9057 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
9059 (InitCoreTypes): Update accordingly.
9061 (RegisterAttrType, LookupAttr): Implement.
9063 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
9064 info about the same.
9066 (Resolve): Update to populate the above as necessary.
9070 (GetValidPlaces): Helper to the above.
9072 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
9074 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
9076 2001-11-12 Ravi Pratap <ravi@ximian.com>
9078 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
9080 * ../errors/cs0617.cs : Add.
9082 2001-11-11 Ravi Pratap <ravi@ximian.com>
9084 * enum.cs (Emit): Rename to Populate to be more consistent with what
9085 we expect it to do and when exactly it is called.
9087 * class.cs, rootcontext.cs : Update accordingly.
9089 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
9090 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
9092 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
9094 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
9095 of a fieldinfo using the above, when dealing with a FieldBuilder.
9097 2001-11-10 Ravi Pratap <ravi@ximian.com>
9099 * ../errors/cs0031.cs : Add.
9101 * ../errors/cs1008.cs : Add.
9103 * ../errrors/cs0543.cs : Add.
9105 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
9108 (FindMembers): Implement.
9110 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
9111 enums and delegates too.
9113 (enum_types): Rename to builder_to_enum.
9115 (delegate_types): Rename to builder_to_delegate.
9117 * delegate.cs (FindMembers): Implement.
9119 2001-11-09 Ravi Pratap <ravi@ximian.com>
9121 * typemanager.cs (IsEnumType): Implement.
9123 * enum.cs (Emit): Re-write parts to account for the underlying type
9124 better and perform checking etc.
9126 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
9127 of the underlying type.
9129 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
9132 * enum.cs (error31): Helper to report error #31.
9134 * cs-parser.jay (enum_declaration): Store location of each member too.
9136 * enum.cs (member_to_location): New hashtable.
9138 (AddEnumMember): Update location hashtable.
9140 (Emit): Use the location of each member while reporting errors.
9142 2001-11-09 Miguel de Icaza <miguel@ximian.com>
9144 * cs-parser.jay: A for_initializer if is a
9145 local_variable_declaration really ammount to have an implicit
9146 block with the variable declaration and no initializer for for.
9148 * statement.cs (For.Emit): Cope with null initializers.
9150 This fixes the infinite loop on for initializers.
9152 2001-11-08 Miguel de Icaza <miguel@ximian.com>
9154 * enum.cs: More cleanup.
9156 * ecore.cs: Remove dead code.
9158 * class.cs (Property.Emit): More simplification.
9159 (Event.Emit): ditto.
9161 Reworked to have less levels of indentation.
9163 2001-11-08 Ravi Pratap <ravi@ximian.com>
9165 * class.cs (Property): Emit attributes.
9175 * enum.cs (Emit): Ditto.
9177 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
9180 * class.cs (Field, Event, etc.): Move attribute generation into the
9181 Emit method everywhere.
9183 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
9184 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
9185 as we had no way of defining nested enums !
9187 * rootcontext.cs : Adjust code accordingly.
9189 * typemanager.cs (AddEnumType): To keep track of enum types separately.
9191 2001-11-07 Ravi Pratap <ravi@ximian.com>
9193 * expression.cs (EvalConstantExpression): Move into ecore.cs
9195 * enum.cs (Enum): Rename some members and make them public and readonly
9196 according to our convention.
9198 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
9201 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
9203 (Enum::Emit): Write a simple version for now which doesn't try to compute
9204 expressions. I shall modify this to be more robust in just a while.
9206 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
9208 (TypeContainer::CloseType): Create the Enum types too.
9210 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
9212 * expression.cs (EvalConstantExpression): Get rid of completely.
9214 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
9215 user-defined values and other cases.
9217 (IsValidEnumLiteral): Helper function.
9219 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
9220 out there in the case we had a literal FieldExpr.
9222 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
9224 (Literalize): Revamp a bit to take two arguments.
9226 (EnumLiteral): New class which derives from Literal to wrap enum literals.
9228 2001-11-06 Ravi Pratap <ravi@ximian.com>
9230 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
9232 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
9234 (Resolve): Use the above to ensure we have proper initializers.
9236 2001-11-05 Ravi Pratap <ravi@ximian.com>
9238 * expression.cs (Expression::EvalConstantExpression): New method to
9239 evaluate constant expressions.
9241 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
9243 2001-11-07 Miguel de Icaza <miguel@ximian.com>
9245 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
9248 (Binary.ResolveOperator): Handle operator != (object a, object b)
9249 and operator == (object a, object b);
9251 (Binary.DoNumericPromotions): Indicate whether the numeric
9252 promotion was possible.
9254 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
9257 Made the ArrayAccess implement interface IAssignMethod instead of
9258 IStackStore as the order in which arguments are passed reflects
9261 * assign.cs: Instead of using expr.ExprClass to select the way of
9262 assinging, probe for the IStackStore/IAssignMethod interfaces.
9264 * typemanager.cs: Load InitializeArray definition.
9266 * rootcontext.cs (RootContext.MakeStaticData): Used to define
9267 static data that can be used to initialize arrays.
9269 2001-11-05 Miguel de Icaza <miguel@ximian.com>
9271 * expression.cs: Handle operator== and operator!= for booleans.
9273 (Conditioal.Reduce): Implement reducer for the ?: operator.
9275 (Conditional.Resolve): Implement dead code elimination.
9277 (Binary.Resolve): Catch string literals and return a new
9278 concatenated string.
9280 (Unary.Reduce): Implement reduction of unary expressions.
9282 * ecore.cs: Split out the expression core handling here.
9284 (Expression.Reduce): New method used to perform constant folding
9285 and CSE. This is needed to support constant-expressions.
9287 * statement.cs (Statement.EmitBoolExpression): Pass true and false
9288 targets, and optimize for !x.
9290 2001-11-04 Ravi Pratap <ravi@ximian.com>
9292 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
9293 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
9294 set custom atttributes.
9296 * literal.cs (Literal::GetValue): New abstract method to return the actual
9297 value of the literal, cast as an object.
9299 (*Literal): Implement GetValue method.
9301 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
9302 expressions to the arraylist but objects of type Argument.
9304 * class.cs (TypeContainer::Emit): Emit our attributes too.
9306 (Method::Emit, Constructor::Emit): Ditto.
9308 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
9309 to be ignoring earlier.
9311 2001-11-03 Ravi Pratap <ravi@ximian.com>
9313 * attribute.cs (AttributeSection::Define): Implement to do the business
9314 of constructing a CustomAttributeBuilder.
9316 (Attribute): New trivial class. Increases readability of code.
9318 * cs-parser.jay : Update accordingly.
9320 (positional_argument_list, named_argument_list, named_argument): New rules
9322 (attribute_arguments): Use the above so that we are more correct.
9324 2001-11-02 Ravi Pratap <ravi@ximian.com>
9326 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
9327 to perform all checks for a method with a params parameter.
9329 (Invocation::OverloadResolve): Update to use the above method and therefore
9330 cope correctly with params method invocations.
9332 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
9335 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
9336 constructors in our parent too because we can't afford to miss out on
9339 * attribute.cs (AttributeSection): New name for the class Attribute
9341 Other trivial changes to improve readability.
9343 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
9344 use the new class names.
9346 2001-11-01 Ravi Pratap <ravi@ximian.com>
9348 * class.cs (Method::Define): Complete definition for params types too
9350 (Indexer::Define): Ditto.
9352 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
9353 Cope everywhere with a request for info about the array parameter.
9355 2001-11-01 Ravi Pratap <ravi@ximian.com>
9357 * tree.cs (RecordNamespace): Fix up to check for the correct key.
9359 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
9360 local_variable_type to extract the string corresponding to the type.
9362 (local_variable_type): Fixup the action to use the new helper method.
9364 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
9367 * expression.cs : Clean out code which uses the above.
9369 2001-10-31 Ravi Pratap <ravi@ximian.com>
9371 * typemanager.cs (RegisterMethod): Check if we already have an existing key
9372 and bale out if necessary by returning a false.
9374 (RegisterProperty): Ditto.
9376 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
9377 and print out appropriate error messages.
9379 * interface.cs (everywhere): Ditto.
9381 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
9382 location to constructor.
9384 * class.cs (Property, Event, Indexer): Update accordingly.
9386 * ../errors/cs111.cs : Added.
9388 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
9389 of a method, as laid down by the spec.
9391 (Invocation::OverloadResolve): Use the above method.
9393 2001-10-31 Ravi Pratap <ravi@ximian.com>
9395 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
9396 now take a TypeContainer and a Parameters object.
9398 (ParameterData): Modify return type of ParameterModifier method to be
9399 Parameter.Modifier and not a string.
9401 (ReflectionParameters, InternalParameters): Update accordingly.
9403 * expression.cs (Argument::GetParameterModifier): Same here.
9405 * support.cs (InternalParameters::ParameterType): Find a better way of determining
9406 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
9407 symbol in it at all so maybe this is only for now.
9409 2001-10-30 Ravi Pratap <ravi@ximian.com>
9411 * support.cs (InternalParameters): Constructor now takes an extra argument
9412 which is the actual Parameters class.
9414 (ParameterDesc): Update to provide info on ref/out modifiers.
9416 * class.cs (everywhere): Update call to InternalParameters to pass in
9417 the second argument too.
9419 * support.cs (ParameterData): Add ParameterModifier, which is a method
9420 to return the modifier info [ref/out etc]
9422 (InternalParameters, ReflectionParameters): Implement the above.
9424 * expression.cs (Argument::ParameterModifier): Similar function to return
9425 info about the argument's modifiers.
9427 (Invocation::OverloadResolve): Update to take into account matching modifiers
9430 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
9431 a new SetFormalParameters object which we pass to InternalParameters.
9433 2001-10-30 Ravi Pratap <ravi@ximian.com>
9435 * expression.cs (NewArray): Merge into the ArrayCreation class.
9437 2001-10-29 Ravi Pratap <ravi@ximian.com>
9439 * expression.cs (NewArray): Merge classes NewBuiltinArray and
9440 NewUserdefinedArray into one as there wasn't much of a use in having
9443 * expression.cs (Argument): Change field's name to ArgType from Type.
9445 (Type): New readonly property which returns the proper type, taking into
9446 account ref/out modifiers.
9448 (everywhere): Adjust code accordingly for the above.
9450 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
9451 whether we are emitting for a ref or out parameter.
9453 * expression.cs (Argument::Emit): Use the above field to set the state.
9455 (LocalVariableReference::Emit): Update to honour the flag and emit the
9458 * parameter.cs (Attributes): Set the correct flags for ref parameters.
9460 * expression.cs (Argument::FullDesc): New function to provide a full desc.
9462 * support.cs (ParameterData): Add method ParameterDesc to the interface.
9464 (ReflectionParameters, InternalParameters): Implement the above method.
9466 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
9469 (Invocation::FullMethodDesc): Ditto.
9471 2001-10-29 Miguel de Icaza <miguel@ximian.com>
9473 * cs-parser.jay: Add extra production for the second form of array
9476 * expression.cs (ArrayCreation): Update to reflect the above
9479 * Small changes to prepare for Array initialization.
9481 2001-10-28 Miguel de Icaza <miguel@ximian.com>
9483 * typemanager.cs (ImplementsInterface): interface might be null;
9484 Deal with this problem;
9486 Also, we do store negative hits on the cache (null values), so use
9487 this instead of calling t.GetInterfaces on the type everytime.
9489 2001-10-28 Ravi Pratap <ravi@ximian.com>
9491 * typemanager.cs (IsBuiltinType): New method to help determine the same.
9493 * expression.cs (New::DoResolve): Get rid of array creation code and instead
9494 split functionality out into different classes.
9496 (New::FormArrayType): Move into NewBuiltinArray.
9498 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
9501 (NewBuiltinArray): New class to handle creation of built-in arrays.
9503 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
9504 account creation of one-dimensional arrays.
9506 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
9508 (NewUserdefinedArray::DoResolve): Implement.
9510 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
9512 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
9513 we maintain inside the TypeManager. This is necessary to perform lookups on the
9516 (LookupType): Update to perform GetType on the module builders too.
9518 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
9520 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
9522 2001-10-23 Ravi Pratap <ravi@ximian.com>
9524 * expression.cs (New::DoResolve): Implement guts of array creation.
9526 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
9528 2001-10-27 Miguel de Icaza <miguel@ximian.com>
9530 * expression.cs: Fix bug I introduced lsat night that broke
9533 (Expression.Resolve): Report a 246 error (can not resolve name)
9534 if we find a SimpleName in the stream.
9536 (Expression.ResolveLValue): Ditto.
9538 (Expression.ResolveWithSimpleName): This function is a variant of
9539 ResolveName, this one allows SimpleNames to be returned without a
9540 warning. The only consumer of SimpleNames is MemberAccess
9542 2001-10-26 Miguel de Icaza <miguel@ximian.com>
9544 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
9545 might arrive here. I have my doubts that this is correct.
9547 * statement.cs (Lock): Implement lock statement.
9549 * cs-parser.jay: Small fixes to support `lock' and `using'
9551 * cs-tokenizer.cs: Remove extra space
9553 * driver.cs: New flag --checked, allows to turn on integer math
9556 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
9557 Threading.Monitor.Exit
9559 2001-10-23 Miguel de Icaza <miguel@ximian.com>
9561 * expression.cs (IndexerAccess::DoResolveLValue): Set the
9562 Expression Class to be IndexerAccess.
9564 Notice that Indexer::DoResolve sets the eclass to Value.
9566 2001-10-22 Miguel de Icaza <miguel@ximian.com>
9568 * class.cs (TypeContainer::Emit): Emit code for indexers.
9570 * assign.cs (IAssignMethod): New interface implemented by Indexers
9571 and Properties for handling assignment.
9573 (Assign::Emit): Simplify and reuse code.
9575 * expression.cs (IndexerAccess, PropertyExpr): Implement
9576 IAssignMethod, clean up old code.
9578 2001-10-22 Ravi Pratap <ravi@ximian.com>
9580 * typemanager.cs (ImplementsInterface): New method to determine if a type
9581 implements a given interface. Provides a nice cache too.
9583 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
9586 (ConvertReferenceExplicit): Ditto.
9588 * delegate.cs (Delegate::Populate): Update to define the parameters on the
9589 various methods, with correct names etc.
9591 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
9592 Operator.UnaryNegation.
9594 * cs-parser.jay (operator_declarator): Be a little clever in the case where
9595 we have a unary plus or minus operator.
9597 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
9600 * everywhere : update accordingly.
9602 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
9605 * class.cs (Method::Define): For the case where we are implementing a method
9606 inherited from an interface, we need to set the MethodAttributes.Final flag too.
9607 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
9609 2001-10-21 Ravi Pratap <ravi@ximian.com>
9611 * interface.cs (FindMembers): Implement to work around S.R.E
9614 * typemanager.cs (IsInterfaceType): Implement.
9616 (FindMembers): Update to handle interface types too.
9618 * expression.cs (ImplicitReferenceConversion): Re-write bits which
9619 use IsAssignableFrom as that is not correct - it doesn't work.
9621 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
9622 and accordingly override EmitStatement.
9624 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
9625 using the correct logic :-)
9627 2001-10-19 Ravi Pratap <ravi@ximian.com>
9629 * ../errors/cs-11.cs : Add to demonstrate error -11
9631 2001-10-17 Miguel de Icaza <miguel@ximian.com>
9633 * assign.cs (Assign::Resolve): Resolve right hand side first, and
9634 then pass this as a hint to ResolveLValue.
9636 * expression.cs (FieldExpr): Add Location information
9638 (FieldExpr::LValueResolve): Report assignment to readonly
9641 (Expression::ExprClassFromMemberInfo): Pass location information.
9643 (Expression::ResolveLValue): Add new method that resolves an
9646 (Expression::DoResolveLValue): Default invocation calls
9649 (Indexers): New class used to keep track of indexers in a given
9652 (IStackStore): Renamed from LValue, as it did not really describe
9653 what this did. Also ResolveLValue is gone from this interface and
9654 now is part of Expression.
9656 (ElementAccess): Depending on the element access type
9658 * typemanager.cs: Add `indexer_name_type' as a Core type
9659 (System.Runtime.CompilerServices.IndexerNameAttribute)
9661 * statement.cs (Goto): Take a location.
9663 2001-10-18 Ravi Pratap <ravi@ximian.com>
9665 * delegate.cs (Delegate::VerifyDelegate): New method to verify
9666 if two delegates are compatible.
9668 (NewDelegate::DoResolve): Update to take care of the case when
9669 we instantiate a delegate from another delegate.
9671 * typemanager.cs (FindMembers): Don't even try to look up members
9672 of Delegate types for now.
9674 2001-10-18 Ravi Pratap <ravi@ximian.com>
9676 * delegate.cs (NewDelegate): New class to take care of delegate
9679 * expression.cs (New): Split the delegate related code out into
9680 the NewDelegate class.
9682 * delegate.cs (DelegateInvocation): New class to handle delegate
9685 * expression.cs (Invocation): Split out delegate related code into
9686 the DelegateInvocation class.
9688 2001-10-17 Ravi Pratap <ravi@ximian.com>
9690 * expression.cs (New::DoResolve): Implement delegate creation fully
9691 and according to the spec.
9693 (New::DoEmit): Update to handle delegates differently.
9695 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
9696 because of which we were printing out arguments in reverse order !
9698 * delegate.cs (VerifyMethod): Implement to check if the given method
9699 matches the delegate.
9701 (FullDelegateDesc): Implement.
9703 (VerifyApplicability): Implement.
9705 * expression.cs (Invocation::DoResolve): Update to accordingly handle
9706 delegate invocations too.
9708 (Invocation::Emit): Ditto.
9710 * ../errors/cs1593.cs : Added.
9712 * ../errors/cs1594.cs : Added.
9714 * delegate.cs (InstanceExpression, TargetMethod): New properties.
9716 2001-10-16 Ravi Pratap <ravi@ximian.com>
9718 * typemanager.cs (intptr_type): Core type for System.IntPtr
9720 (InitCoreTypes): Update for the same.
9722 (iasyncresult_type, asynccallback_type): Ditto.
9724 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
9727 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
9730 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
9731 the builders for the 4 members of a delegate type :-)
9733 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
9736 * expression.cs (New::DoResolve): Implement guts for delegate creation.
9738 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
9740 2001-10-15 Miguel de Icaza <miguel@ximian.com>
9742 * statement.cs (Break::Emit): Implement.
9743 (Continue::Emit): Implement.
9745 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
9746 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
9747 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
9748 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
9751 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
9752 properties that track the label for the current loop (begin of the
9753 loop and end of the loop).
9755 2001-10-15 Ravi Pratap <ravi@ximian.com>
9757 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
9758 use of emitting anything at all.
9760 * class.cs, rootcontext.cs : Get rid of calls to the same.
9762 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
9764 (Populate): Define the constructor correctly and set the implementation
9767 * typemanager.cs (delegate_types): New hashtable to hold delegates that
9770 (AddDelegateType): Implement.
9772 (IsDelegateType): Implement helper method.
9774 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
9776 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
9777 and accordingly handle it.
9779 * delegate.cs (Populate): Take TypeContainer argument.
9780 Implement bits to define the Invoke method. However, I still haven't figured out
9781 how to take care of the native int bit :-(
9783 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
9784 Qualify the name of the delegate, not its return type !
9786 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
9789 (StandardConversionExists): Checking for array types turns out to be recursive.
9791 (ConvertReferenceExplicit): Implement array conversion.
9793 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
9795 2001-10-12 Ravi Pratap <ravi@ximian.com>
9797 * cs-parser.jay (delegate_declaration): Store the fully qualified
9798 name as it is a type declaration.
9800 * delegate.cs (ReturnType, Name): Rename members to these. Make them
9803 (DefineDelegate): Renamed from Define. Does the same thing essentially,
9804 as TypeContainer::DefineType.
9806 (Populate): Method in which all the definition of the various methods (Invoke)
9809 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
9812 (CloseDelegate): Finally creates the delegate.
9814 * class.cs (TypeContainer::DefineType): Update to define delegates.
9815 (Populate, Emit and CloseType): Do the same thing here too.
9817 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
9818 delegates in all these operations.
9820 2001-10-14 Miguel de Icaza <miguel@ximian.com>
9822 * expression.cs: LocalTemporary: a new expression used to
9823 reference a temporary that has been created.
9825 * assign.cs: Handle PropertyAccess back here, so that we can
9826 provide the proper semantic access to properties.
9828 * expression.cs (Expression::ConvertReferenceExplicit): Implement
9829 a few more explicit conversions.
9831 * modifiers.cs: `NEW' modifier maps to HideBySig.
9833 * expression.cs (PropertyExpr): Make this into an
9834 ExpressionStatement, and support the EmitStatement code path.
9836 Perform get/set error checking, clean up the interface.
9838 * assign.cs: recognize PropertyExprs as targets, and if so, turn
9839 them into toplevel access objects.
9841 2001-10-12 Miguel de Icaza <miguel@ximian.com>
9843 * expression.cs: PropertyExpr::PropertyExpr: use work around the
9846 * typemanager.cs: Keep track here of our PropertyBuilders again to
9847 work around lameness in SRE.
9849 2001-10-11 Miguel de Icaza <miguel@ximian.com>
9851 * expression.cs (LValue::LValueResolve): New method in the
9852 interface, used to perform a second resolution pass for LValues.
9854 (This::DoResolve): Catch the use of this in static methods.
9856 (This::LValueResolve): Implement.
9858 (This::Store): Remove warning, assigning to `this' in structures
9861 (Invocation::Emit): Deal with invocation of
9862 methods on value types. We need to pass the address to structure
9863 methods rather than the object itself. (The equivalent code to
9864 emit "this" for structures leaves the entire structure on the
9865 stack instead of a pointer to it).
9867 (ParameterReference::DoResolve): Compute the real index for the
9868 argument based on whether the method takes or not a `this' pointer
9869 (ie, the method is static).
9871 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
9872 value types returned from functions when we need to invoke a
9873 method on the sturcture.
9876 2001-10-11 Ravi Pratap <ravi@ximian.com>
9878 * class.cs (TypeContainer::DefineType): Method to actually do the business of
9879 defining the type in the Modulebuilder or Typebuilder. This is to take
9880 care of nested types which need to be defined on the TypeBuilder using
9883 (TypeContainer::GetClassBases): Implement. Essentially the code from the
9884 methods in RootContext, only ported to be part of TypeContainer.
9886 (TypeContainer::GetInterfaceOrClass): Ditto.
9888 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
9890 * interface.cs (Interface::DefineInterface): New method. Does exactly
9891 what RootContext.CreateInterface did earlier, only it takes care of nested types
9894 (Interface::GetInterfaces): Move from RootContext here and port.
9896 (Interface::GetInterfaceByName): Same here.
9898 * rootcontext.cs (ResolveTree): Re-write.
9900 (PopulateTypes): Re-write.
9902 * class.cs (TypeContainer::Populate): Populate nested types too.
9903 (TypeContainer::Emit): Emit nested members too.
9905 * typemanager.cs (AddUserType): Do not make use of the FullName property,
9906 instead just use the name argument passed in as it is already fully
9909 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
9910 to TypeContainer mapping to see if a type is user-defined.
9912 * class.cs (TypeContainer::CloseType): Implement.
9914 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
9915 the default constructor.
9917 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
9920 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
9922 * interface.cs (CloseType): Create the type here.
9924 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
9927 Remove all the methods which are now in TypeContainer.
9929 2001-10-10 Ravi Pratap <ravi@ximian.com>
9931 * delegate.cs (Define): Re-write bits to define the delegate
9934 2001-10-10 Miguel de Icaza <miguel@ximian.com>
9936 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
9938 * expression.cs (ImplicitReferenceConversion): handle null as well
9939 as a source to convert to any reference type.
9941 * statement.cs (Return): Perform any implicit conversions to
9942 expected return type.
9944 Validate use of return statement.
9946 * codegen.cs (EmitContext): Pass the expected return type here.
9948 * class.cs (Method, Constructor, Property): Pass expected return
9949 type to EmitContext.
9951 2001-10-09 Miguel de Icaza <miguel@ximian.com>
9953 * expression.cs: Make DoResolve take an EmitContext instead of a
9956 Replaced `l' and `location' for `loc', for consistency.
9958 (Error, Warning): Remove unneeded Tc argument.
9960 * assign.cs, literal.cs, constant.cs: Update to new calling
9963 * codegen.cs: EmitContext now contains a flag indicating whether
9964 code is being generated in a static method or not.
9966 * cs-parser.jay: DecomposeQI, new function that replaces the old
9967 QualifiedIdentifier. Now we always decompose the assembled
9968 strings from qualified_identifier productions into a group of
9971 2001-10-08 Miguel de Icaza <miguel@ximian.com>
9973 * rootcontext.cs: Deal with field-less struct types correctly now
9974 by passing the size option to Define Type.
9976 * class.cs: Removed hack that created one static field.
9978 2001-10-07 Miguel de Icaza <miguel@ximian.com>
9980 * statement.cs: Moved most of the code generation here.
9982 2001-10-09 Ravi Pratap <ravi@ximian.com>
9984 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
9987 (ElementAccess): Remove useless bits for now - keep checks as the spec
9990 2001-10-08 Ravi Pratap <ravi@ximian.com>
9992 * expression.cs (ElementAccess::DoResolve): Remove my crap code
9993 and start performing checks according to the spec.
9995 2001-10-07 Ravi Pratap <ravi@ximian.com>
9997 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
9998 rank_specifiers instead.
10000 (rank_specifiers): Change the order in which the rank specifiers are stored
10002 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
10004 * expression.cs (ElementAccess): Implement the LValue interface too.
10006 2001-10-06 Ravi Pratap <ravi@ximian.com>
10008 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
10009 except that user defined conversions are not included.
10011 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
10012 perform the conversion of the return type, if necessary.
10014 (New::DoResolve): Check whether we are creating an array or an object
10015 and accordingly do the needful.
10017 (New::Emit): Same here.
10019 (New::DoResolve): Implement guts of array creation.
10021 (New::FormLookupType): Helper function.
10023 2001-10-07 Miguel de Icaza <miguel@ximian.com>
10025 * codegen.cs: Removed most of the code generation here, and move the
10026 corresponding code generation bits to the statement classes.
10028 Added support for try/catch/finalize and throw.
10030 * cs-parser.jay: Added support for try/catch/finalize.
10032 * class.cs: Catch static methods having the flags override,
10033 virtual or abstract.
10035 * expression.cs (UserCast): This user cast was not really doing
10036 what it was supposed to do. Which is to be born in fully resolved
10037 state. Parts of the resolution were being performed at Emit time!
10041 2001-10-05 Miguel de Icaza <miguel@ximian.com>
10043 * expression.cs: Implicity convert the result from UserCast.
10045 2001-10-05 Ravi Pratap <ravi@ximian.com>
10047 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
10048 prevented it from working correctly.
10050 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
10051 merely ConvertImplicit.
10053 2001-10-05 Miguel de Icaza <miguel@ximian.com>
10055 * typemanager.cs: Make the LookupTypeContainer function static,
10056 and not per-instance.
10058 * class.cs: Make static FindMembers (the one that takes a Type
10061 * codegen.cs: Add EmitForeach here.
10063 * cs-parser.jay: Make foreach a toplevel object instead of the
10064 inline expansion, as we need to perform semantic analysis on it.
10066 2001-10-05 Ravi Pratap <ravi@ximian.com>
10068 * expression.cs (Expression::ImplicitUserConversion): Rename to
10069 UserDefinedConversion.
10071 (Expression::UserDefinedConversion): Take an extra argument specifying
10072 whether we look for explicit user conversions too.
10074 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
10076 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
10078 (ExplicitUserConversion): Make it a call to UserDefinedConversion
10079 with the appropriate arguments.
10081 * cs-parser.jay (cast_expression): Record location too.
10083 * expression.cs (Cast): Record location info.
10085 (Expression::ConvertExplicit): Take location argument.
10087 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
10088 to determine if we are doing explicit conversions.
10090 (UserCast::Emit): Update accordingly.
10092 (Expression::ConvertExplicit): Report an error if everything fails.
10094 * ../errors/cs0030.cs : Add.
10096 2001-10-04 Miguel de Icaza <miguel@ximian.com>
10098 * modifiers.cs: If the ABSTRACT keyword is present, also set the
10099 virtual and newslot bits.
10101 * class.cs (TypeContainer::RegisterRequiredImplementations):
10102 Record methods we need.
10104 (TypeContainer::MakeKey): Helper function to make keys for
10105 MethodBases, since the Methodbase key is useless.
10107 (TypeContainer::Populate): Call RegisterRequiredImplementations
10108 before defining the methods.
10110 Create a mapping for method_builders_to_methods ahead of time
10111 instead of inside a tight loop.
10113 (::RequireMethods): Accept an object as the data to set into the
10114 hashtable so we can report interface vs abstract method mismatch.
10116 2001-10-03 Miguel de Icaza <miguel@ximian.com>
10118 * report.cs: Make all of it static.
10120 * rootcontext.cs: Drop object_type and value_type computations, as
10121 we have those in the TypeManager anyways.
10123 Drop report instance variable too, now it is a global.
10125 * driver.cs: Use try/catch on command line handling.
10127 Add --probe option to debug the error reporting system with a test
10130 * report.cs: Add support for exiting program when a probe
10131 condition is reached.
10133 2001-10-03 Ravi Pratap <ravi@ximian.com>
10135 * expression.cs (Binary::DoNumericPromotions): Fix the case when
10136 we do a forcible conversion regardless of type, to check if
10137 ForceConversion returns a null.
10139 (Binary::error19): Use location to report error.
10141 (Unary::error23): Use location here too.
10143 * ../errors/cs0019.cs : Check in.
10145 * ../errors/cs0023.cs : Check in.
10147 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
10148 case of a non-null MethodInfo object with a length of 0 !
10150 (Binary::ResolveOperator): Flag error if overload resolution fails to find
10151 an applicable member - according to the spec :-)
10152 Also fix logic to find members in base types.
10154 (Unary::ResolveOperator): Same here.
10156 (Unary::report23): Change name to error23 and make first argument a TypeContainer
10157 as I was getting thoroughly confused between this and error19 :-)
10159 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
10160 (::FindMostEncompassedType): Implement.
10161 (::FindMostEncompassingType): Implement.
10162 (::StandardConversionExists): Implement.
10164 (UserImplicitCast): Re-vamp. We now need info about most specific
10165 source and target types so that we can do the necessary conversions.
10167 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
10168 mathematical union with no duplicates.
10170 2001-10-03 Miguel de Icaza <miguel@ximian.com>
10172 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
10173 in order from base classes to child classes, so that we can in
10174 child classes look up in our parent for method names and
10175 attributes (required for handling abstract, virtual, new, override
10176 constructs: we need to instrospect our base class, and if we dont
10177 populate the classes in order, the introspection might be
10178 incorrect. For example, a method could query its parent before
10179 the parent has any methods and would determine that the parent has
10180 no abstract methods (while it could have had them)).
10182 (RootContext::CreateType): Record the order in which we define the
10185 2001-10-02 Miguel de Icaza <miguel@ximian.com>
10187 * class.cs (TypeContainer::Populate): Also method definitions can
10188 fail now, keep track of this.
10190 (TypeContainer::FindMembers): Implement support for
10191 DeclaredOnly/noDeclaredOnly flag.
10193 (Constructor::Emit) Return the ConstructorBuilder.
10195 (Method::Emit) Return the MethodBuilder.
10196 Check for abstract or virtual methods to be public.
10198 * rootcontext.cs (RootContext::CreateType): Register all the
10199 abstract methods required for the class to be complete and the
10200 interface methods that must be implemented.
10202 * cs-parser.jay: Report error 501 (method requires body if it is
10203 not marked abstract or extern).
10205 * expression.cs (TypeOf::Emit): Implement.
10207 * typemanager.cs: runtime_handle_type, new global type.
10209 * class.cs (Property::Emit): Generate code for properties.
10211 2001-10-02 Ravi Pratap <ravi@ximian.com>
10213 * expression.cs (Unary::ResolveOperator): Find operators on base type
10214 too - we now conform exactly to the spec.
10216 (Binary::ResolveOperator): Same here.
10218 * class.cs (Operator::Define): Fix minor quirk in the tests.
10220 * ../errors/cs0215.cs : Added.
10222 * ../errors/cs0556.cs : Added.
10224 * ../errors/cs0555.cs : Added.
10226 2001-10-01 Miguel de Icaza <miguel@ximian.com>
10228 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
10229 single integer which is really efficient
10231 2001-10-01 Ravi Pratap <ravi@ximian.com>
10233 * expression.cs (Expression::ImplicitUserConversion): Use location
10234 even in the case when we are examining True operators.
10236 * class.cs (Operator::Define): Perform extensive checks to conform
10237 with the rules for operator overloading in the spec.
10239 * expression.cs (Expression::ImplicitReferenceConversion): Implement
10240 some of the other conversions mentioned in the spec.
10242 * typemanager.cs (array_type): New static member for the System.Array built-in
10245 (cloneable_interface): For System.ICloneable interface.
10247 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
10248 we start resolving the tree and populating types.
10250 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
10252 2001-10-01 Miguel de Icaza <miguel@ximian.com>
10254 * expression.cs (Expression::ExprClassFromMemberInfo,
10255 Expression::Literalize): Create literal expressions from
10256 FieldInfos which are literals.
10258 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
10259 type casts, because they were wrong. The test suite in tests
10262 (ImplicitNumericConversion): ushort to ulong requires a widening
10265 Int32 constant to long requires widening cast as well.
10267 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
10268 for integers because the type on the stack is not i4.
10270 2001-09-30 Miguel de Icaza <miguel@ximian.com>
10272 * expression.cs (report118): require location argument.
10274 * parameter.cs: Do not dereference potential null value.
10276 * class.cs: Catch methods that lack the `new' keyword when
10277 overriding a name. Report warnings when `new' is used without
10278 anything being there to override.
10280 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
10282 * class.cs: Only add constructor to hashtable if it is non-null
10283 (as now constructors can fail on define).
10285 (TypeManager, Class, Struct): Take location arguments.
10287 Catch field instance initialization in structs as errors.
10289 accepting_filter: a new filter for FindMembers that is static so
10290 that we dont create an instance per invocation.
10292 (Constructor::Define): Catch errors where a struct constructor is
10295 * cs-parser.jay: Pass location information for various new
10298 * delegate.cs (Delegate): take a location argument.
10300 * driver.cs: Do not call EmitCode if there were problesm in the
10301 Definition of the types, as many Builders wont be there.
10303 * decl.cs (Decl::Decl): Require a location argument.
10305 * cs-tokenizer.cs: Handle properly hex constants that can not fit
10306 into integers, and find the most appropiate integer for it.
10308 * literal.cs: Implement ULongLiteral.
10310 * rootcontext.cs: Provide better information about the location of
10311 failure when CreateType fails.
10313 2001-09-29 Miguel de Icaza <miguel@ximian.com>
10315 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
10318 * expression.cs (Binary::CheckShiftArguments): Add missing type
10320 (Binary::ResolveOperator): Add type to the logical and and logical
10321 or, Bitwise And/Or and Exclusive Or code paths, it was missing
10324 (Binary::DoNumericPromotions): In the case where either argument
10325 is ulong (and most signed types combined with ulong cause an
10326 error) perform implicit integer constant conversions as well.
10328 2001-09-28 Miguel de Icaza <miguel@ximian.com>
10330 * expression.cs (UserImplicitCast): Method should always be
10332 (Invocation::BetterConversion): Simplified test for IntLiteral.
10334 (Expression::ImplicitNumericConversion): Split this routine out.
10335 Put the code that performs implicit constant integer conversions
10338 (Expression::Resolve): Become a wrapper around DoResolve so we can
10339 check eclass and type being set after resolve.
10341 (Invocation::Badness): Remove this dead function
10343 (Binary::ResolveOperator): Do not compute the expensive argumnets
10344 unless we have a union for it.
10346 (Probe::Emit): Is needs to do an isinst and then
10347 compare against null.
10349 (::CanConvert): Added Location argument. If the Location argument
10350 is null (Location.Null), then we do not report errors. This is
10351 used by the `probe' mechanism of the Explicit conversion. We do
10352 not want to generate an error for something that the user
10353 explicitly requested to be casted. But the pipeline for an
10354 explicit cast first tests for potential implicit casts.
10356 So for now, if the Location is null, it means `Probe only' to
10357 avoid adding another argument. Might have to revise this
10360 (ClassCast): New class used to type cast objects into arbitrary
10361 classes (used in Explicit Reference Conversions).
10363 Implement `as' as well.
10365 Reverted all the patches from Ravi below: they were broken:
10367 * The use of `level' as a mechanism to stop recursive
10368 invocations is wrong. That was there just to catch the
10369 bug with a strack trace but not as a way of addressing
10372 To fix the problem we have to *understand* what is going
10373 on and the interactions and come up with a plan, not
10374 just get things going.
10376 * The use of the type conversion cache that I proposed
10377 last night had an open topic: How does this work across
10378 protection domains. A user defined conversion might not
10379 be public in the location where we are applying the
10380 conversion, a different conversion might be selected
10381 (ie, private A->B (better) but public B->A (worse),
10382 inside A, A->B applies, but outside it, B->A will
10385 * On top of that (ie, even if the above is solved),
10386 conversions in a cache need to be abstract. Ie, `To
10387 convert from an Int to a Short use an OpcodeCast', not
10388 `To convert from an Int to a Short use the OpcodeCast on
10389 the variable 5' (which is what this patch was doing).
10391 2001-09-28 Ravi Pratap <ravi@ximian.com>
10393 * expression.cs (Invocation::ConversionExists): Re-write to use
10394 the conversion cache
10396 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
10397 cache all conversions done, not just user-defined ones.
10399 (Invocation::BetterConversion): The real culprit. Use ConversionExists
10400 to determine if a conversion exists instead of acutually trying to
10401 perform the conversion. It's faster too.
10403 (Expression::ConvertExplicit): Modify to use ConversionExists to check
10404 and only then attempt the implicit conversion.
10406 2001-09-28 Ravi Pratap <ravi@ximian.com>
10408 * expression.cs (ConvertImplicit): Use a cache for conversions
10409 already found. Check level of recursion and bail out if necessary.
10411 2001-09-28 Miguel de Icaza <miguel@ximian.com>
10413 * typemanager.cs (string_concat_string_string, string_concat_object_object):
10414 Export standard methods that we expect for string operations.
10416 * statement.cs (Block::UsageWarning): Track usage of variables and
10417 report the errors for not used variables.
10419 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
10422 2001-09-27 Miguel de Icaza <miguel@ximian.com>
10424 * codegen.cs: remove unnneded code
10426 * expression.cs: Removed BuiltinTypeAccess class
10428 Fix the order in which implicit conversions are
10431 The previous fixed dropped support for boxed conversions (adding a
10432 test to the test suite now)
10434 (UserImplicitCast::CanConvert): Remove test for source being null,
10435 that code is broken. We should not feed a null to begin with, if
10436 we do, then we should track the bug where the problem originates
10437 and not try to cover it up here.
10439 Return a resolved expression of type UserImplicitCast on success
10440 rather than true/false. Ravi: this is what I was talking about,
10441 the pattern is to use a static method as a "constructor" for
10444 Also, do not create arguments until the very last minute,
10445 otherwise we always create the arguments even for lookups that
10446 will never be performed.
10448 (UserImplicitCast::Resolve): Eliminate, objects of type
10449 UserImplicitCast are born in a fully resolved state.
10451 * typemanager.cs (InitCoreTypes): Init also value_type
10452 (System.ValueType).
10454 * expression.cs (Cast::Resolve): First resolve the child expression.
10456 (LValue): Add new method AddressOf to be used by
10459 Change the argument of Store to take an EmitContext instead of an
10460 ILGenerator, because things like FieldExpr need to be able to call
10461 their children expression to generate the instance code.
10463 (Expression::Error, Expression::Warning): Sugar functions for
10466 (Expression::MemberLookup): Accept a TypeContainer instead of a
10467 Report as the first argument.
10469 (Expression::ResolvePrimary): Killed. I still want to improve
10470 this as currently the code is just not right.
10472 (Expression::ResolveMemberAccess): Simplify, but it is still
10475 (Unary::Resolve): Catch errors in AddressOf operators.
10477 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
10478 index to a byte for the short-version, or the compiler will choose
10479 the wrong Emit call, which generates the wrong data.
10481 (ParameterReference::Emit, ::Store): same.
10483 (FieldExpr::AddressOf): Implement.
10485 * typemanager.cs: TypeManager: made public variable instead of
10488 * driver.cs: document --fatal.
10490 * report.cs (ErrorMessage, WarningMessage): new names for the old
10491 Error and Warning classes.
10493 * cs-parser.jay (member_access): Turn built-in access to types
10494 into a normal simplename
10496 2001-09-27 Ravi Pratap <ravi@ximian.com>
10498 * expression.cs (Invocation::BetterConversion): Fix to cope
10499 with q being null, since this was introducing a bug.
10501 * expression.cs (ConvertImplicit): Do built-in conversions first.
10503 2001-09-27 Ravi Pratap <ravi@ximian.com>
10505 * expression.cs (UserImplicitCast::Resolve): Fix bug.
10507 2001-09-27 Ravi Pratap <ravi@ximian.com>
10509 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
10510 I had introduced long ago (what's new ?).
10512 * expression.cs (UserImplicitCast::CanConvert): Static method to do
10513 the work of all the checking.
10514 (ConvertImplicit): Call CanConvert and only then create object if necessary.
10515 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
10517 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
10518 that is the right way.
10520 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
10521 overloading resolution. Use everywhere instead of cutting and pasting code.
10523 (Binary::ResolveOperator): Use MakeUnionSet.
10525 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
10526 we have to convert to bool types. Not complete yet.
10528 2001-09-27 Miguel de Icaza <miguel@ximian.com>
10530 * typemanager.cs (TypeManager::CSharpName): support ushort.
10532 * expression.cs (Expression::TryImplicitIntConversion): Attempts
10533 to provide an expression that performsn an implicit constant int
10534 conversion (section 6.1.6).
10535 (Expression::ConvertImplicitRequired): Reworked to include
10536 implicit constant expression conversions.
10538 (Expression::ConvertNumericExplicit): Finished.
10540 (Invocation::Emit): If InstanceExpression is null, then it means
10541 that we perform a call on this.
10543 2001-09-26 Miguel de Icaza <miguel@ximian.com>
10545 * expression.cs (Unary::Emit): Remove some dead code.
10546 (Probe): Implement Resolve and Emit for `is'.
10547 (Expression::ConvertImplicitRequired): Attempt to do constant
10548 expression conversions here. Maybe should be moved to
10549 ConvertImplicit, but I am not sure.
10550 (Expression::ImplicitLongConstantConversionPossible,
10551 Expression::ImplicitIntConstantConversionPossible): New functions
10552 that tell whether is it possible to apply an implicit constant
10553 expression conversion.
10555 (ConvertNumericExplicit): Started work on explicit numeric
10558 * cs-parser.jay: Update operator constants.
10560 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
10561 (Parameters::GetSignature): Hook up VerifyArgs here.
10562 (Parameters::VerifyArgs): Verifies that no two arguments have the
10565 * class.cs (Operator): Update the operator names to reflect the
10566 ones that the spec expects (as we are just stringizing the
10569 * expression.cs (Unary::ResolveOperator): Fix bug: Use
10570 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
10571 previous usage did only work for our methods.
10572 (Expression::ConvertImplicit): Handle decimal implicit numeric
10573 conversions as well.
10574 (Expression::InternalTypeConstructor): Used to invoke constructors
10575 on internal types for default promotions.
10577 (Unary::Emit): Implement special handling for the pre/post
10578 increment/decrement for overloaded operators, as they need to have
10579 the same semantics as the other operators.
10581 (Binary::ResolveOperator): ditto.
10582 (Invocation::ConversionExists): ditto.
10583 (UserImplicitCast::Resolve): ditto.
10585 2001-09-26 Ravi Pratap <ravi@ximian.com>
10587 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
10588 operator, return after emitting body. Regression tests pass again !
10590 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
10591 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
10592 (Invocation::OverloadResolve): Ditto.
10593 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
10595 * everywhere : update calls to the above methods accordingly.
10597 2001-09-26 Miguel de Icaza <miguel@ximian.com>
10599 * assign.cs (Assign): Make it inherit from ExpressionStatement.
10601 * expression.cs (ExpressionStatement): New base class used for
10602 expressions that can appear in statements, so that we can provide
10603 an alternate path to generate expression that do not leave a value
10606 (Expression::Emit, and all the derivatives): We no longer return
10607 whether a value is left on the stack or not. Every expression
10608 after being emitted leaves a single value on the stack.
10610 * codegen.cs (EmitContext::EmitStatementExpression): Use the
10611 facilties of ExpressionStatement if possible.
10613 * cs-parser.jay: Update statement_expression.
10615 2001-09-25 Miguel de Icaza <miguel@ximian.com>
10617 * driver.cs: Change the wording of message
10619 2001-09-25 Ravi Pratap <ravi@ximian.com>
10621 * expression.cs (Binary::ResolveOperator): Had forgottten to set
10622 the type of the expression to the return type of the method if
10623 we have an overloaded operator match ! The regression tests pass again !
10624 (Unary::ResolveOperator): Ditto.
10626 * expression.cs (Invocation::ConversionExists): Correct the member lookup
10627 to find "op_Implicit", not "implicit" ;-)
10628 (UserImplicitCast): New class to take care of user-defined implicit conversions.
10629 (ConvertImplicit, ForceConversion): Take TypeContainer argument
10631 * everywhere : Correct calls to the above accordingly.
10633 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
10634 (ConvertImplicit): Do user-defined conversion if it exists.
10636 2001-09-24 Miguel de Icaza <miguel@ximian.com>
10638 * assign.cs: track location.
10639 (Resolve): Use implicit conversions on assignment.
10641 * literal.cs: Oops. Not good, Emit of short access values should
10642 pass (Bytes) or the wrong argument will be selected.
10644 * expression.cs (Unary::Emit): Emit code for -expr.
10646 (Unary::ResolveOperator): Handle `Substract' for non-constants
10647 (substract from zero from the non-constants).
10648 Deal with Doubles as well.
10650 (Expression::ConvertImplicitRequired): New routine that reports an
10651 error if no implicit conversion exists.
10653 (Invocation::OverloadResolve): Store the converted implicit
10654 expressions if we make them
10656 2001-09-24 Ravi Pratap <ravi@ximian.com>
10658 * class.cs (ConstructorInitializer): Take a Location argument.
10659 (ConstructorBaseInitializer): Same here.
10660 (ConstructorThisInitializer): Same here.
10662 * cs-parser.jay : Update all calls accordingly.
10664 * expression.cs (Unary, Binary, New): Take location argument.
10665 Update accordingly everywhere.
10667 * cs-parser.jay : Update all calls to the above to take a location
10670 * class.cs : Ditto.
10672 2001-09-24 Ravi Pratap <ravi@ximian.com>
10674 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
10675 (Invocation::BetterConversion): Same here
10676 (Invocation::ConversionExists): Ditto.
10678 (Invocation::ConversionExists): Implement.
10680 2001-09-22 Ravi Pratap <ravi@ximian.com>
10682 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
10683 Also take an additional TypeContainer argument.
10685 * All over : Pass in TypeContainer as argument to OverloadResolve.
10687 * typemanager.cs (CSharpName): Update to check for the string type and return
10690 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
10693 2001-09-21 Ravi Pratap <ravi@ximian.com>
10695 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
10696 (Invocation::BetterFunction): Implement.
10697 (Invocation::BetterConversion): Implement.
10698 (Invocation::ConversionExists): Skeleton, no implementation yet.
10700 Okay, things work fine !
10702 2001-09-21 Miguel de Icaza <miguel@ximian.com>
10704 * typemanager.cs: declare and load enum_type, delegate_type and
10707 * expression.cs (Expression::Emit): Now emit returns a value that
10708 tells whether a value is left on the stack or not. This strategy
10709 might be reveted tomorrow with a mechanism that would address
10710 multiple assignments.
10711 (Expression::report118): Utility routine to report mismatches on
10714 (Unary::Report23): Report impossible type/operator combination
10717 (Unary::IsIncrementableNumber): Whether the type can be
10718 incremented or decremented with add.
10719 (Unary::ResolveOperator): Also allow enumerations to be bitwise
10721 (Unary::ResolveOperator): Implement ++, !, ~,
10723 (Invocation::Emit): Deal with new Emit convetion.
10725 * All Expression derivatives: Updated their Emit method to return
10726 whether they leave values on the stack or not.
10728 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
10729 stack for expressions that are statements.
10731 2001-09-20 Miguel de Icaza <miguel@ximian.com>
10733 * expression.cs (LValue): New interface. Must be implemented by
10735 (LocalVariableReference, ParameterReference, FieldExpr): Implement
10738 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
10739 interface for generating code, simplifies the code.
10741 2001-09-20 Ravi Pratap <ravi@ximian.com>
10743 * expression.cs (everywhere): Comment out return statements in ::Resolve
10744 methods to avoid the warnings.
10746 2001-09-20 Miguel de Icaza <miguel@ximian.com>
10748 * driver.cs (parse): Report error 2001 if we can not open the
10751 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
10754 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
10757 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
10758 otherwise nested blocks end up with the same index.
10760 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
10762 * expression.cs: Instead of having FIXMEs in the Resolve
10763 functions, throw exceptions so it is obvious that we are facing a
10766 * cs-parser.jay (invocation_expression): Pass Location information.
10768 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
10769 Use a basename for those routines because .NET does not like paths
10772 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
10775 2001-09-19 Miguel de Icaza <miguel@ximian.com>
10777 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
10778 are loading the correct data types (throws an exception if not).
10779 (TypeManager::InitCoreTypes): Use CoreLookupType
10781 * expression.cs (Unary::ResolveOperator): return the child
10782 expression for expressions which are just +expr.
10783 (Unary::ResolveOperator): Return negative literals for -LITERAL
10784 expressions (otherwise they are Unary {Literal}).
10785 (Invocation::Badness): Take into account `Implicit constant
10786 expression conversions'.
10788 * literal.cs (LongLiteral): Implement long literal class.
10789 (IntLiteral): export the `Value' of the intliteral.
10791 2001-09-19 Ravi Pratap <ravi@ximian.com>
10793 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
10795 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
10796 instead of 'Operator'
10798 * expression.cs (Binary::ResolveOperator): Update accordingly.
10799 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
10802 * cs-parser.jay (unary_expression): Update to use the new names.
10804 * gen-treedump.cs (GetUnary): Same here.
10806 * expression.cs (Unary::Resolve): Implement.
10807 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
10808 operators are found instead of making noise ;-)
10809 (Unary::ResolveOperator): New method to do precisely the same thing which
10810 Binary::ResolveOperator does for Binary expressions.
10811 (Unary.method, .Arguments): Add.
10812 (Unary::OperName): Implement.
10813 (Unary::ForceConversion): Copy and Paste !
10815 * class.cs (Operator::Define): Fix a small bug for the case when we have
10818 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
10819 for the inbuilt operators. Only overloading works for now ;-)
10821 2001-09-18 Miguel de Icaza <miguel@ximian.com>
10823 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
10824 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
10826 * expression.cs (This::Emit): Implement.
10827 (This::Resolve): Implement.
10828 (TypeOf:Resolve): Implement.
10829 (Expression::ResolveSimpleName): Add an implicit this to instance
10831 (MemberAccess::Resolve): Deal with Parameters and Fields.
10832 Bind instance variable to Field expressions.
10833 (FieldExpr::Instance): New field used to track the expression that
10834 represents the object instance.
10835 (FieldExpr::Resolve): Track potential errors from MemberLookup not
10837 (FieldExpr::Emit): Implement.
10839 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
10840 the last instruction contains a return opcode to avoid generating
10841 the last `ret' instruction (this generates correct code, and it is
10842 nice to pass the peverify output).
10844 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
10845 initializer for static and instance variables.
10846 (Constructor::Emit): Allow initializer to be null in the case of
10847 static constructors. Only emit initializer for instance
10850 (TypeContainer::FindMembers): Return a null array if there are no
10853 Also fix the code for the MemberTypes.Method branch, as it was not
10854 scanning that for operators (or tried to access null variables before).
10856 * assign.cs (Assign::Emit): Handle instance and static fields.
10860 * driver.cs: Stop compilation if there are parse errors.
10862 * cs-parser.jay (constructor_declaration): Provide default base
10863 initializer for non-static constructors.
10864 (constructor_declarator): Do not provide a default base
10865 initializers if none was specified.
10866 Catch the fact that constructors should not have parameters.
10868 * class.cs: Do not emit parent class initializers for static
10869 constructors, that should be flagged as an error.
10871 2001-09-18 Ravi Pratap <ravi@ximian.com>
10873 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
10874 Move back code into TypeContainer::Populate.
10876 2001-09-18 Ravi Pratap <ravi@ximian.com>
10878 * class.cs (TypeContainer::AddConstructor): Fix the check to
10879 compare against Name, not Basename.
10880 (Operator::OpType): Change Plus and Minus to Add and Subtract.
10882 * cs-parser.jay : Update accordingly.
10884 * class.cs (TypeContainer::FindMembers): For the case where we are searching
10885 for methods, don't forget to look into the operators too.
10886 (RegisterMethodBuilder): Helper method to take care of this for
10887 methods, constructors and operators.
10888 (Operator::Define): Completely revamp.
10889 (Operator.OperatorMethod, MethodName): New fields.
10890 (TypeContainer::Populate): Move the registering of builders into
10891 RegisterMethodBuilder.
10892 (Operator::Emit): Re-write.
10894 * expression.cs (Binary::Emit): Comment out code path to emit method
10895 invocation stuff for the case when we have a user defined operator. I am
10896 just not able to get it right !
10898 2001-09-17 Miguel de Icaza <miguel@ximian.com>
10900 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
10903 (Expression::MemberLookup): Provide a version that allows to
10904 specify the MemberTypes and BindingFlags.
10906 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
10907 so it was not fetching variable information from outer blocks.
10909 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
10910 Beforefieldinit as it was buggy.
10912 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
10913 that Ravi put here.
10915 * class.cs (Constructor::Emit): Only emit if block is not null.
10916 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
10917 deal with this by semantically definining it as if the user had
10920 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
10921 constructors as we now "emit" them at a higher level.
10923 (TypeContainer::DefineDefaultConstructor): Used to define the
10924 default constructors if none was provided.
10926 (ConstructorInitializer): Add methods Resolve and Emit.
10928 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
10930 2001-09-17 Ravi Pratap <ravi@ximian.com>
10932 * class.cs (TypeContainer::EmitDefaultConstructor): Register
10933 the default constructor builder with our hashtable for methodbuilders
10936 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
10937 and argument_count is 0 in which case we have a match.
10938 (Binary::ResolveOperator): More null checking and miscellaneous coding
10941 2001-09-17 Ravi Pratap <ravi@ximian.com>
10943 * rootcontext.cs (IsNameSpace): Compare against null.
10945 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
10947 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
10948 and Unary::Operator.
10950 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
10953 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
10954 we have overloaded operators.
10955 (Binary::ResolveOperator): Implement the part which does the operator overload
10958 * class.cs (Operator::Emit): Implement.
10959 (TypeContainer::Emit): Emit the operators we have too.
10961 * expression.cs (Binary::Emit): Update to emit the appropriate code for
10962 the case when we have a user-defined operator.
10964 2001-09-17 Miguel de Icaza <miguel@ximian.com>
10966 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
10968 2001-09-16 Ravi Pratap <ravi@ximian.com>
10970 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
10971 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
10972 (Constructor::Emit): Implement.
10973 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
10974 if we have no work to do.
10975 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
10978 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
10979 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
10981 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
10984 2001-09-15 Ravi Pratap <ravi@ximian.com>
10986 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
10988 (Tree::RecordNamespace): Method to do what the name says ;-)
10989 (Tree::Namespaces): Property to get at the namespaces hashtable.
10991 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
10994 * rootcontext.cs (IsNamespace): Fixed it :-)
10996 2001-09-14 Miguel de Icaza <miguel@ximian.com>
10998 * class.cs (TypeContainer::FindMembers): Add support for
11000 (MethodCore): New class that encapsulates both the shared aspects
11001 of a Constructor and a Method.
11002 (Method, Constructor): Factored pieces into MethodCore.
11004 * driver.cs: Added --fatal which makes errors throw exceptions.
11005 Load System assembly as well as part of the standard library.
11007 * report.cs: Allow throwing exceptions on errors for debugging.
11009 * modifiers.cs: Do not use `parent', instead use the real type
11010 container to evaluate permission settings.
11012 * class.cs: Put Ravi's patch back in. He is right, and we will
11013 have to cope with the
11015 2001-09-14 Ravi Pratap <ravi@ximian.com>
11017 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
11018 FamORAssem, not FamANDAssem.
11020 2001-09-14 Miguel de Icaza <miguel@ximian.com>
11022 * driver.cs: Added --parse option that only parses its input files
11025 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
11026 incorrect. IsTopLevel is not used to tell whether an object is
11027 root_types or not (that can be achieved by testing this ==
11028 root_types). But to see if this is a top-level *class* (not
11029 necessarly our "toplevel" container).
11031 2001-09-14 Ravi Pratap <ravi@ximian.com>
11033 * enum.cs (Enum::Define): Modify to call the Lookup method on the
11034 parent instead of a direct call to GetType.
11036 2001-09-14 Ravi Pratap <ravi@ximian.com>
11038 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
11039 Modifiers.TypeAttr. This should just be a call to that method.
11041 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
11042 object so that we can determine if we are top-level or not.
11044 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
11047 * enum.cs (Enum::Define): Ditto.
11049 * modifiers.cs (FieldAttr): Re-write.
11051 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
11052 (TypeContainer::HaveStaticConstructor): New property to provide access
11053 to precisely that info.
11055 * modifiers.cs (MethodAttr): Re-write.
11056 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
11058 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
11059 of top-level types as claimed.
11061 2001-09-13 Miguel de Icaza <miguel@ximian.com>
11063 * expression.cs (MemberLookup): Fruitless attempt to lookup
11064 constructors. Maybe I need to emit default constructors? That
11065 might be it (currently .NET emits this for me automatically).
11066 (Invocation::OverloadResolve): Cope with Arguments == null.
11067 (Invocation::EmitArguments): new function, shared by the new
11068 constructor and us.
11069 (Invocation::Emit): Handle static and instance methods. Emit
11070 proper call instruction for virtual or non-virtual invocations.
11071 (New::Emit): Implement.
11072 (New::Resolve): Implement.
11073 (MemberAccess:Resolve): Implement.
11074 (MethodGroupExpr::InstanceExpression): used conforming to the spec
11075 to track instances.
11076 (FieldExpr::Resolve): Set type.
11078 * support.cs: Handle empty arguments.
11080 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
11081 SimpleLookup): Auxiliary routines to help parse a qualifier
11084 Update qualifier_identifier rule.
11086 * codegen.cs: Removed debugging messages.
11088 * class.cs: Make this a global thing, this acts just as a "key" to
11089 objects that we might have around.
11091 (Populate): Only initialize method_builders_to_methods once.
11093 * expression.cs (PropertyExpr): Initialize type from the
11096 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
11097 Resolve pattern. Attempt to implicitly convert value to boolean.
11100 * expression.cs: Set the type for the int32/int32 argument case.
11101 (Binary::ResolveOperator): Set the return type to boolean for
11102 comparission operators
11104 * typemanager.cs: Remove debugging print code.
11106 (Invocation::Resolve): resolve type.
11108 * class.cs: Allocate a MemberInfo of the correct size, as the code
11109 elsewhere depends on the test to reflect the correct contents.
11111 (Method::) Keep track of parameters, due to System.Reflection holes
11113 (TypeContainer::Populate): Keep track of MethodBuilders to Method
11116 (TypeContainer::FindMembers): Use ArrayList and then copy an array
11117 of the exact size and return that.
11119 (Class::LookupMethodByBuilder): New function that maps
11120 MethodBuilders to its methods. Required to locate the information
11121 on methods because System.Reflection bit us again.
11123 * support.cs: New file, contains an interface ParameterData and
11124 two implementations: ReflectionParameters and InternalParameters
11125 used to access Parameter information. We will need to grow this
11128 * expression.cs (Invocation::GetParameterData): implement a cache
11129 and a wrapper around the ParameterData creation for methods.
11130 (Invocation::OverloadResolve): Use new code.
11132 2001-09-13 Ravi Pratap <ravi@ximian.com>
11134 * class.cs (TypeContainer::EmitField): Remove and move into
11135 (Field::Define): here and modify accordingly.
11136 (Field.FieldBuilder): New member.
11137 (TypeContainer::Populate): Update accordingly.
11138 (TypeContainer::FindMembers): Implement.
11140 2001-09-13 Miguel de Icaza <miguel@ximian.com>
11142 * statement.cs: (VariableInfo::VariableType): New field to be
11143 initialized with the full type once it is resolved.
11145 2001-09-12 Miguel de Icaza <miguel@ximian.com>
11147 * parameter.cs (GetParameterInfo): Use a type cache to compute
11148 things only once, and to reuse this information
11150 * expression.cs (LocalVariableReference::Emit): Implement.
11151 (OpcodeCast::Emit): fix.
11153 (ParameterReference::Resolve): Implement.
11154 (ParameterReference::Emit): Implement.
11156 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
11157 that are expressions need to stay as Expressions.
11159 * typemanager.cs (CSharpName): Returns the C# name of a type if
11162 * expression.cs (Expression::ConvertImplicit): New function that
11163 implements implicit type conversions.
11165 (Expression::ImplicitReferenceConversion): Implements implicit
11166 reference conversions.
11168 (EmptyCast): New type for transparent casts.
11170 (OpcodeCast): New type for casts of types that are performed with
11171 a sequence of bytecodes.
11173 (BoxedCast): New type used for casting value types into reference
11174 types. Emits a box opcode.
11176 (Binary::DoNumericPromotions): Implements numeric promotions of
11177 and computation of the Binary::Type.
11179 (Binary::EmitBranchable): Optimization.
11181 (Binary::Emit): Implement code emission for expressions.
11183 * typemanager.cs (TypeManager): Added two new core types: sbyte
11186 2001-09-12 Ravi Pratap <ravi@ximian.com>
11188 * class.cs (TypeContainer::FindMembers): Method which does exactly
11189 what Type.FindMembers does, only we don't have to use reflection. No
11190 implementation yet.
11192 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
11193 typecontainer objects as we need to get at them.
11194 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
11196 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
11197 typecontainer object.
11199 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
11200 of just a Report object.
11202 2001-09-11 Ravi Pratap <ravi@ximian.com>
11204 * class.cs (Event::Define): Go back to using the prefixes "add_" and
11206 (TypeContainer::Populate): Now define the delegates of the type too.
11207 (TypeContainer.Delegates): Property to access the list of delegates defined
11210 * delegates.cs (Delegate::Define): Implement partially.
11212 * modifiers.cs (TypeAttr): Handle more flags.
11214 2001-09-11 Ravi Pratap <ravi@ximian.com>
11216 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
11218 (Operator::Define): Re-write logic to get types by using the LookupType method
11219 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
11220 (Indexer::Define): Ditto.
11221 (Event::Define): Ditto.
11222 (Property::Define): Ditto.
11224 2001-09-10 Ravi Pratap <ravi@ximian.com>
11226 * class.cs (TypeContainer::Populate): Now define operators too.
11227 (TypeContainer.Operators): New property to access the list of operators
11229 (Operator.OperatorMethodBuilder): New member to hold the method builder
11230 for the operator we are defining.
11231 (Operator::Define): Implement.
11233 2001-09-10 Ravi Pratap <ravi@ximian.com>
11235 * class.cs (Event::Define): Make the prefixes of the accessor methods
11236 addOn_ and removeOn_
11238 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
11239 of the location being passed in too. Ideally, this should go later since all
11240 error reporting should be done through the Report object.
11242 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
11243 (Populate): Iterate thru the indexers we have and define them too.
11244 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
11245 for the get and set accessors.
11246 (Indexer::Define): Implement.
11248 2001-09-09 Miguel de Icaza <miguel@ximian.com>
11250 * expression.cs (Binary::Resolve): Beginning of it. I scratched
11251 my previous implementation, did not work.
11253 * typemanager.cs: Add a couple of missing types (the longs).
11255 * literal.cs: Use TypeManager.bool_type instead of getting it.
11257 * expression.cs (EventExpr): New kind of expressions.
11258 (Expressio::ExprClassFromMemberInfo): finish
11260 2001-09-08 Miguel de Icaza <miguel@ximian.com>
11262 * assign.cs: Emit stores to static fields differently.
11264 2001-09-08 Ravi Pratap <ravi@ximian.com>
11266 * Merge in changes and adjust code to tackle conflicts. Backed out my
11267 code in Assign::Resolve ;-)
11269 2001-09-08 Ravi Pratap <ravi@ximian.com>
11271 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
11272 instead Report.Error and also pass in the location.
11273 (CSharpParser::Lexer): New readonly property to return the reference
11274 to the Tokenizer object.
11275 (declare_local_variables): Use Report.Error with location instead of plain
11279 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
11280 (Operator.CheckBinaryOperator): Ditto.
11282 * cs-parser.jay (operator_declarator): Update accordingly.
11284 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
11285 (CheckBinaryOperator): Same here.
11287 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
11288 on the name without any prefixes of namespace names etc. This is because we
11289 already might have something already fully qualified like
11290 'System.Console.WriteLine'
11292 * assign.cs (Resolve): Begin implementation. Stuck ;-)
11294 2001-09-07 Ravi Pratap <ravi@ximian.com>
11296 * cs-tokenizer.cs (location): Return a string which also contains
11299 * expression.cs (ElementAccess): New class for expressions of the
11300 type 'element access.'
11301 (BaseAccess): New class for expressions of the type 'base access.'
11302 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
11305 * cs-parser.jay (element_access): Implement action.
11306 (base_access): Implement actions.
11307 (checked_expression, unchecked_expression): Implement.
11309 * cs-parser.jay (local_variable_type): Correct and implement.
11310 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
11312 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
11314 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
11315 name and the specifiers.
11317 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
11319 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
11320 making them all public ;-)
11322 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
11325 2001-09-07 Miguel de Icaza <miguel@ximian.com>
11327 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
11329 (FieldExpr, PropertyExprs): New resolved expressions.
11330 (SimpleName::MemberStaticCheck): Perform static checks for access
11331 to non-static fields on static methods. Maybe this should be
11332 generalized for MemberAccesses.
11333 (SimpleName::ResolveSimpleName): More work on simple name
11336 * cs-parser.jay (primary_expression/qualified_identifier): track
11337 the parameter index.
11339 * codegen.cs (CodeGen::Save): Catch save exception, report error.
11340 (EmitContext::EmitBoolExpression): Chain to expression generation
11341 instead of temporary hack.
11342 (::EmitStatementExpression): Put generic expression code generation.
11344 * assign.cs (Assign::Emit): Implement variable assignments to
11345 local variables, parameters and fields.
11347 2001-09-06 Miguel de Icaza <miguel@ximian.com>
11349 * statement.cs (Block::GetVariableInfo): New method, returns the
11350 VariableInfo for a variable name in a block.
11351 (Block::GetVariableType): Implement in terms of GetVariableInfo
11353 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
11354 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
11356 2001-09-06 Ravi Pratap <ravi@ximian.com>
11358 * cs-parser.jay (operator_declaration): Continue on my quest : update
11359 to take attributes argument.
11360 (event_declaration): Ditto.
11361 (enum_declaration): Ditto.
11362 (indexer_declaration): Ditto.
11364 * class.cs (Operator::Operator): Update constructor accordingly.
11365 (Event::Event): Ditto.
11367 * delegate.cs (Delegate::Delegate): Same here.
11369 * enum.cs (Enum::Enum): Same here.
11371 2001-09-05 Ravi Pratap <ravi@ximian.com>
11373 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
11375 * ../tests/cs0658.cs : New file to demonstrate error 0658.
11377 * attribute.cs (Attributes): New class to encapsulate all attributes which were
11378 being passed around as an arraylist.
11379 (Attributes::AddAttribute): Method to add attribute sections.
11381 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
11382 (struct_declaration): Update accordingly.
11383 (constant_declaration): Update.
11384 (field_declaration): Update.
11385 (method_header): Update.
11386 (fixed_parameter): Update.
11387 (parameter_array): Ditto.
11388 (property_declaration): Ditto.
11389 (destructor_declaration): Ditto.
11391 * class.cs (Struct::Struct): Update constructors accordingly.
11392 (Class::Class): Ditto.
11393 (Field::Field): Ditto.
11394 (Method::Method): Ditto.
11395 (Property::Property): Ditto.
11396 (TypeContainer::OptAttribute): update property's return type.
11398 * interface.cs (Interface.opt_attributes): New member.
11399 (Interface::Interface): Update to take the extra Attributes argument.
11401 * parameter.cs (Parameter::Parameter): Ditto.
11403 * constant.cs (Constant::Constant): Ditto.
11405 * interface.cs (InterfaceMemberBase): New OptAttributes field.
11406 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
11407 the attributes as a parameter.
11408 (InterfaceProperty): Update constructor call.
11409 (InterfaceEvent): Ditto.
11410 (InterfaceMethod): Ditto.
11411 (InterfaceIndexer): Ditto.
11413 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
11414 pass the attributes too.
11415 (interface_event_declaration): Ditto.
11416 (interface_property_declaration): Ditto.
11417 (interface_method_declaration): Ditto.
11418 (interface_declaration): Ditto.
11420 2001-09-05 Miguel de Icaza <miguel@ximian.com>
11422 * class.cs (Method::Define): Track the "static Main" definition to
11423 create an entry point.
11425 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
11426 EntryPoint if we find it.
11428 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
11429 (EmitContext::ig): Make this variable public.
11431 * driver.cs: Make the default output file be the first file name
11432 with the .exe extension.
11434 Detect empty compilations
11436 Handle various kinds of output targets. Handle --target and
11437 rename -t to --dumper.
11439 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
11440 methods inherited from Expression return now an Expression. This
11441 will is used during the tree rewriting as we resolve them during
11444 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
11445 the spec. Missing entirely is the information about
11446 accessability of elements of it.
11448 (Expression::ExprClassFromMemberInfo): New constructor for
11449 Expressions that creates a fully initialized Expression based on
11450 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
11453 (Invocation::Resolve): Begin implementing resolution of invocations.
11455 * literal.cs (StringLiteral): Implement Emit.
11457 2001-09-05 Ravi Pratap <ravi@ximian.com>
11459 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
11462 2001-09-04 Ravi Pratap <ravi@ximian.com>
11464 * cs-parser.jay (attribute_arguments): Implement actions.
11465 (attribute): Fix bug in production. Implement action.
11466 (attribute_list): Implement.
11467 (attribute_target): Implement.
11468 (attribute_target_specifier, opt_target_specifier): Implement
11469 (CheckAttributeTarget): New method to check if the attribute target
11471 (attribute_section): Implement.
11472 (opt_attributes): Implement.
11474 * attribute.cs : New file to handle attributes.
11475 (Attribute): Class to hold attribute info.
11477 * cs-parser.jay (opt_attribute_target_specifier): Remove production
11478 (attribute_section): Modify production to use 2 different rules to
11479 achieve the same thing. 1 s/r conflict down !
11480 Clean out commented, useless, non-reducing dimension_separator rules.
11482 * class.cs (TypeContainer.attributes): New member to hold list
11483 of attributes for a type.
11484 (Struct::Struct): Modify to take one more argument, the attribute list.
11485 (Class::Class): Ditto.
11486 (Field::Field): Ditto.
11487 (Method::Method): Ditto.
11488 (Property::Property): Ditto.
11490 * cs-parser.jay (struct_declaration): Update constructor call to
11491 pass in the attributes too.
11492 (class_declaration): Ditto.
11493 (constant_declaration): Ditto.
11494 (field_declaration): Ditto.
11495 (method_header): Ditto.
11496 (fixed_parameter): Ditto.
11497 (parameter_array): Ditto.
11498 (property_declaration): Ditto.
11500 * constant.cs (Constant::Constant): Update constructor similarly.
11501 Use System.Collections.
11503 * parameter.cs (Parameter::Parameter): Update as above.
11505 2001-09-02 Ravi Pratap <ravi@ximian.com>
11507 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
11508 (TypeContainer.delegates): New member to hold list of delegates.
11510 * cs-parser.jay (delegate_declaration): Implement the action correctly
11511 this time as I seem to be on crack ;-)
11513 2001-09-02 Miguel de Icaza <miguel@ximian.com>
11515 * rootcontext.cs (RootContext::IsNamespace): new function, used to
11516 tell whether an identifier represents a namespace.
11518 * expression.cs (NamespaceExpr): A namespace expression, used only
11519 temporarly during expression resolution.
11520 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
11521 utility functions to resolve names on expressions.
11523 2001-09-01 Miguel de Icaza <miguel@ximian.com>
11525 * codegen.cs: Add hook for StatementExpressions.
11527 * class.cs: Fix inverted test for static flag in methods.
11529 2001-09-02 Ravi Pratap <ravi@ximian.com>
11531 * class.cs (Operator::CheckUnaryOperator): Correct error number used
11532 to make it coincide with MS' number.
11533 (Operator::CheckBinaryOperator): Ditto.
11535 * ../errors/errors.txt : Remove error numbers added earlier.
11537 * ../errors/cs1019.cs : Test case for error # 1019
11539 * ../errros/cs1020.cs : Test case for error # 1020
11541 * cs-parser.jay : Clean out commented cruft.
11542 (dimension_separators, dimension_separator): Comment out. Ostensibly not
11543 used anywhere - non-reducing rule.
11544 (namespace_declarations): Non-reducing rule - comment out.
11546 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
11547 with TypeContainer::AddEnum.
11549 * delegate.cs : New file for delegate handling classes.
11550 (Delegate): Class for declaring delegates.
11552 * makefile : Update.
11554 * cs-parser.jay (delegate_declaration): Implement.
11556 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
11558 * class.cs (Event::Define): Implement.
11559 (Event.EventBuilder): New member.
11561 * class.cs (TypeContainer::Populate): Update to define all enums and events
11563 (Events): New property for the events arraylist we hold. Shouldn't we move to using
11564 readonly fields for all these cases ?
11566 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
11568 * class.cs (Property): Revamp to use the convention of making fields readonly.
11569 Accordingly modify code elsewhere.
11571 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
11572 the Define method of the Property class.
11574 * class.cs : Clean up applied patch and update references to variables etc. Fix
11576 (TypeContainer::Populate): Update to define all the properties we have. Also
11577 define all enumerations.
11579 * enum.cs (Define): Implement.
11581 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
11583 * cs-parser.jay (overloadable_operator): The semantic value is an
11584 enum of the Operator class.
11585 (operator_declarator): Implement actions.
11586 (operator_declaration): Implement.
11588 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
11589 validity of definitions.
11590 (Operator::CheckBinaryOperator): Static method to check for binary operators
11591 (TypeContainer::AddOperator): New method to add an operator to a type.
11593 * cs-parser.jay (indexer_declaration): Added line to actually call the
11594 AddIndexer method so it gets added ;-)
11596 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
11597 already taken care of by the MS compiler ?
11599 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
11601 * class.cs (Operator): New class for operator declarations.
11602 (Operator::OpType): Enum for the various operators.
11604 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
11606 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
11607 ostensibly handle this in semantic analysis.
11609 * cs-parser.jay (general_catch_clause): Comment out
11610 (specific_catch_clauses, specific_catch_clause): Ditto.
11611 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
11612 (catch_args, opt_catch_args): New productions.
11613 (catch_clause): Rewrite to use the new productions above
11614 (catch_clauses): Modify accordingly.
11615 (opt_catch_clauses): New production to use in try_statement
11616 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
11617 and re-write the code in the actions to extract the specific and
11618 general catch clauses by being a little smart ;-)
11620 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
11621 Hooray, try and catch statements parse fine !
11623 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
11625 * statement.cs (Block::GetVariableType): Fix logic to extract the type
11626 string from the hashtable of variables.
11628 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
11629 I end up making that mistake ;-)
11630 (catch_clauses): Fixed gross error which made Key and Value of the
11631 DictionaryEntry the same : $1 !!
11633 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
11635 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
11637 * cs-parser.jay (event_declaration): Correct to remove the semicolon
11638 when the add and remove accessors are specified.
11640 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
11642 * cs-parser.jay (IndexerDeclaration): New helper class to hold
11643 information about indexer_declarator.
11644 (indexer_declarator): Implement actions.
11645 (parsing_indexer): New local boolean used to keep track of whether
11646 we are parsing indexers or properties. This is necessary because
11647 implicit_parameters come into picture even for the get accessor in the
11648 case of an indexer.
11649 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
11651 * class.cs (Indexer): New class for indexer declarations.
11652 (TypeContainer::AddIndexer): New method to add an indexer to a type.
11653 (TypeContainer::indexers): New member to hold list of indexers for the
11656 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
11658 * cs-parser.jay (add_accessor_declaration): Implement action.
11659 (remove_accessor_declaration): Implement action.
11660 (event_accessors_declaration): Implement
11661 (variable_declarators): swap statements for first rule - trivial.
11663 * class.cs (Event): New class to hold information about event
11665 (TypeContainer::AddEvent): New method to add an event to a type
11666 (TypeContainer::events): New member to hold list of events.
11668 * cs-parser.jay (event_declaration): Implement actions.
11670 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
11672 * cs-parser.jay (dim_separators): Implement. Make it a string
11673 concatenating all the commas together, just as they appear.
11674 (opt_dim_separators): Modify accordingly
11675 (rank_specifiers): Update accordingly. Basically do the same
11676 thing - instead, collect the brackets here.
11677 (opt_rank_sepcifiers): Modify accordingly.
11678 (array_type): Modify to actually return the complete type string
11679 instead of ignoring the rank_specifiers.
11680 (expression_list): Implement to collect the expressions
11681 (variable_initializer): Implement. We make it a list of expressions
11682 essentially so that we can handle the array_initializer case neatly too.
11683 (variable_initializer_list): Implement.
11684 (array_initializer): Make it a list of variable_initializers
11685 (opt_array_initializer): Modify accordingly.
11687 * expression.cs (New::NType): Add enumeration to help us
11688 keep track of whether we have an object/delegate creation
11689 or an array creation.
11690 (New:NewType, New::Rank, New::Indices, New::Initializers): New
11691 members to hold data about array creation.
11692 (New:New): Modify to update NewType
11693 (New:New): New Overloaded contructor for the array creation
11696 * cs-parser.jay (array_creation_expression): Implement to call
11697 the overloaded New constructor.
11699 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
11701 * class.cs (TypeContainer::Constructors): Return member
11702 constructors instead of returning null.
11704 2001-08-26 Miguel de Icaza <miguel@ximian.com>
11706 * typemanager.cs (InitCoreTypes): Initialize the various core
11707 types after we have populated the type manager with the user
11708 defined types (this distinction will be important later while
11709 compiling corlib.dll)
11711 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
11712 on Expression Classification. Now all expressions have a method
11713 `Resolve' and a method `Emit'.
11715 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
11716 generation from working. Also add some temporary debugging
11719 2001-08-24 Miguel de Icaza <miguel@ximian.com>
11721 * codegen.cs: Lots of code generation pieces. This is only the
11722 beginning, will continue tomorrow with more touches of polish. We
11723 handle the fundamentals of if, while, do, for, return. Others are
11724 trickier and I need to start working on invocations soon.
11726 * gen-treedump.cs: Bug fix, use s.Increment here instead of
11729 * codegen.cs (EmitContext): New struct, used during code
11730 emission to keep a context. Most of the code generation will be
11733 * cs-parser.jay: Add embedded blocks to the list of statements of
11734 this block. So code generation proceeds in a top down fashion.
11736 2001-08-23 Miguel de Icaza <miguel@ximian.com>
11738 * statement.cs: Add support for multiple child blocks.
11740 2001-08-22 Miguel de Icaza <miguel@ximian.com>
11742 * codegen.cs (EmitCode): New function, will emit the code for a
11743 Block of code given a TypeContainer and its ILGenerator.
11745 * statement.cs (Block): Standard public readonly optimization.
11746 (Block::Block constructors): Link children.
11747 (Block::Child): Child Linker.
11748 (Block::EmitVariables): Emits IL variable declarations.
11750 * class.cs: Drop support for MethodGroups here, delay until
11752 (Method::): Applied the same simplification that I did before, and
11753 move from Properties to public readonly fields.
11754 (Method::ParameterTypes): Returns the parameter types for the
11755 function, and implements a cache that will be useful later when I
11756 do error checking and the semantic analysis on the methods is
11758 (Constructor::GetCallingConvention): Renamed from CallingConvetion
11759 and made a method, optional argument tells whether this is a class
11760 or a structure to apply the `has-this' bit.
11761 (Method::GetCallingConvention): Implement, returns the calling
11763 (Method::Define): Defines the type, a second pass is performed
11764 later to populate the methods.
11766 (Constructor::ParameterTypes): implement a cache similar to the
11767 one on Method::ParameterTypes, useful later when we do semantic
11770 (TypeContainer::EmitMethod): New method. Emits methods.
11772 * expression.cs: Removed MethodGroup class from here.
11774 * parameter.cs (Parameters::GetCallingConvention): new method.
11776 2001-08-21 Miguel de Icaza <miguel@ximian.com>
11778 * class.cs (TypeContainer::Populate): Drop RootContext from the
11781 (Constructor::CallingConvention): Returns the calling convention.
11782 (Constructor::ParameterTypes): Returns the constructor parameter
11785 (TypeContainer::AddConstructor): Keep track of default constructor
11786 and the default static constructor.
11788 (Constructor::) Another class that starts using `public readonly'
11789 instead of properties.
11791 (Constructor::IsDefault): Whether this is a default constructor.
11793 (Field::) use readonly public fields instead of properties also.
11795 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
11796 track of static constructors; If none is used, turn on
11797 BeforeFieldInit in the TypeAttributes.
11799 * cs-parser.jay (opt_argument_list): now the return can be null
11800 for the cases where there are no arguments.
11802 (constructor_declarator): If there is no implicit `base' or
11803 `this', then invoke the default parent constructor.
11805 * modifiers.cs (MethodAttr): New static function maps a set of
11806 modifiers flags into a MethodAttributes enum
11807 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
11808 MethodAttr, TypeAttr to represent the various mappings where the
11809 modifiers are used.
11810 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
11812 2001-08-19 Miguel de Icaza <miguel@ximian.com>
11814 * parameter.cs (GetParameterInfo): Fix bug where there would be no
11817 * interface.cs (PopulateIndexer): Implemented the code generator
11818 for interface indexers.
11820 2001-08-17 Miguel de Icaza <miguel@ximian.com>
11822 * interface.cs (InterfaceMemberBase): Now we track the new status
11825 (PopulateProperty): Implement property population. Woohoo! Got
11826 Methods and Properties going today.
11828 Removed all the properties for interfaces, and replaced them with
11829 `public readonly' fields.
11831 2001-08-16 Miguel de Icaza <miguel@ximian.com>
11833 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
11834 initialize their hashtables/arraylists only when they are needed
11835 instead of doing this always.
11837 * parameter.cs: Handle refs and out parameters.
11839 * cs-parser.jay: Use an ArrayList to construct the arguments
11840 instead of the ParameterCollection, and then cast that to a
11843 * parameter.cs: Drop the use of ParameterCollection and use
11844 instead arrays of Parameters.
11846 (GetParameterInfo): Use the Type, not the Name when resolving
11849 2001-08-13 Miguel de Icaza <miguel@ximian.com>
11851 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
11852 and instead use public readonly fields.
11854 * class.cs: Put back walking code for type containers.
11856 2001-08-11 Miguel de Icaza <miguel@ximian.com>
11858 * class.cs (MakeConstant): Code to define constants.
11860 * rootcontext.cs (LookupType): New function. Used to locate types
11863 2001-08-08 Miguel de Icaza <miguel@ximian.com>
11865 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
11866 this System.Reflection code is. Kudos to Microsoft
11868 * typemanager.cs: Implement a type cache and avoid loading all
11869 types at boot time. Wrap in LookupType the internals. This made
11870 the compiler so much faster. Wow. I rule!
11872 * driver.cs: Make sure we always load mscorlib first (for
11873 debugging purposes, nothing really important).
11875 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
11876 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
11878 * rootcontext.cs: Lookup types on their namespace; Lookup types
11879 on namespaces that have been imported using the `using' keyword.
11881 * class.cs (TypeContainer::TypeAttr): Virtualize.
11882 (Class::TypeAttr): Return attributes suitable for this bad boy.
11883 (Struct::TypeAttr): ditto.
11884 Handle nested classes.
11885 (TypeContainer::) Remove all the type visiting code, it is now
11886 replaced with the rootcontext.cs code
11888 * rootcontext.cs (GetClassBases): Added support for structs.
11890 2001-08-06 Miguel de Icaza <miguel@ximian.com>
11892 * interface.cs, statement.cs, class.cs, parameter.cs,
11893 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
11894 Drop use of TypeRefs, and use strings instead.
11896 2001-08-04 Miguel de Icaza <miguel@ximian.com>
11900 * class.cs (Struct::Struct): set the SEALED flags after
11901 checking the modifiers.
11902 (TypeContainer::TypeAttr): new property, returns the
11903 TypeAttributes for a class.
11905 * cs-parser.jay (type_list): Oops, list production was creating a
11906 new list of base types.
11908 * rootcontext.cs (StdLib): New property.
11909 (GetInterfaceTypeByName): returns an interface by type name, and
11910 encapsulates error handling here.
11911 (GetInterfaces): simplified.
11912 (ResolveTree): Encapsulated all the tree resolution here.
11913 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
11916 * driver.cs: Add support for --nostdlib, to avoid loading the
11917 default assemblies.
11918 (Main): Do not put tree resolution here.
11920 * rootcontext.cs: Beginning of the class resolution.
11922 2001-08-03 Miguel de Icaza <miguel@ximian.com>
11924 * rootcontext.cs: Provide better error reporting.
11926 * cs-parser.jay (interface_base): set our $$ to be interfaces.
11928 * rootcontext.cs (CreateInterface): Handle the case where there
11929 are no parent interfaces.
11931 (CloseTypes): Routine to flush types at the end.
11932 (CreateInterface): Track types.
11933 (GetInterfaces): Returns an array of Types from the list of
11934 defined interfaces.
11936 * typemanager.c (AddUserType): Mechanism to track user types (puts
11937 the type on the global type hash, and allows us to close it at the
11940 2001-08-02 Miguel de Icaza <miguel@ximian.com>
11942 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
11943 RecordInterface instead.
11945 * cs-parser.jay: Updated to reflect changes above.
11947 * decl.cs (Definition): Keep track of the TypeBuilder type that
11948 represents this type here. Not sure we will use it in the long
11949 run, but wont hurt for now.
11951 * driver.cs: Smaller changes to accomodate the new code.
11953 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
11956 * rootcontext.cs (CreateInterface): New method, used to create
11957 the System.TypeBuilder type for interfaces.
11958 (ResolveInterfaces): new entry point to resolve the interface
11960 (CodeGen): Property, used to keep track of the code generator.
11962 2001-07-26 Miguel de Icaza <miguel@ximian.com>
11964 * cs-parser.jay: Add a second production for delegate_declaration
11967 (enum_body): Put an opt_comma here instead of putting it on
11968 enum_body or enum_member_declarations so we can handle trailing
11969 commas on enumeration members. Gets rid of a shift/reduce.
11971 (type_list): Need a COMMA in the middle.
11973 (indexer_declaration): Tell tokenizer to recognize get/set
11975 * Remove old targets.
11977 * Re-add the parser target.
11979 2001-07-13 Simon Cozens <simon@simon-cozens.org>
11981 * cs-parser.jay: Add precendence rules for a number of operators
11982 ot reduce the number of shift/reduce conflicts in the grammar.
11984 2001-07-17 Miguel de Icaza <miguel@ximian.com>
11986 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
11989 Get rid of old crufty code.
11991 * rootcontext.cs: Use this to keep track of the parsed
11992 representation and the defined types available to the program.
11994 * gen-treedump.cs: adjust for new convention.
11996 * type.cs: Split out the type manager, and the assembly builder
11999 * typemanager.cs: the type manager will live here now.
12001 * cil-codegen.cs: And the code generator here.
12003 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
12005 * makefile: Fixed up for easy making.
12007 2001-07-13 Simon Cozens <simon@simon-cozens.org>
12009 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
12012 (unary_expression): Expand pre_increment_expression and
12013 post_decrement_expression to reduce a shift/reduce.
12015 2001-07-11 Simon Cozens
12017 * cs-tokenizer.cs: Hex numbers should begin with a 0.
12019 Improve allow_keyword_as_indent name.
12021 2001-06-19 Miguel de Icaza <miguel@ximian.com>
12023 * Adjustments for Beta2.
12025 2001-06-13 Miguel de Icaza <miguel@ximian.com>
12027 * decl.cs: Added `Define' abstract method.
12028 (InTransit): new property, used to catch recursive definitions.
12030 * interface.cs: Implement `Define'.
12032 * modifiers.cs: Map Modifiers.constants to
12033 System.Reflection.TypeAttribute flags.
12035 * class.cs: Keep track of types and user-defined types.
12036 (BuilderInit): New method for creating an assembly
12037 (ResolveType): New function to launch the resolution process, only
12038 used by interfaces for now.
12040 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
12041 that are inserted into the name space.
12043 2001-06-08 Miguel de Icaza <miguel@ximian.com>
12045 * ARGH. I have screwed up my tree so many times due to the use of
12046 rsync rather than using CVS. Going to fix this at once.
12048 * driver.cs: Objetify driver. Load assemblies, use assemblies to
12051 2001-06-07 Miguel de Icaza <miguel@ximian.com>
12053 * Experiment successful: Use System.Type rather that our own
12056 2001-05-25 Miguel de Icaza <miguel@ximian.com>
12058 * cs-parser.jay: Removed nsAliases from here.
12060 Use new namespaces, handle `using XXX;'
12062 * namespace.cs: Reimplemented namespace handling, use a recursive
12063 definition of the class. Now we can keep track of using clauses
12064 and catch invalid using clauses.
12066 2001-05-24 Miguel de Icaza <miguel@ximian.com>
12068 * gen-treedump.cs: Adapted for all the renaming.
12070 * expression.cs (Expression): this class now has a Type property
12071 which returns an expression Type.
12073 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
12074 `Type', as this has a different meaning now in the base
12076 2001-05-22 Miguel de Icaza <miguel@ximian.com>
12078 * interface.cs, class.cs: Removed from all the sources the
12079 references to signature computation, as we can not do method
12080 signature computation during the parsing time, as we are not
12081 trying to solve at that point distinguishing:
12085 void a (NS.Blah x) {}
12088 Which depending on the context might be valid or not, as we do not
12089 know if Blah is the same thing as NS.Blah at that point.
12091 * Redid everything so the code uses TypeRefs now instead of
12092 Types. TypeRefs are just temporary type placeholders, that need
12093 to be resolved. They initially have a pointer to a string and the
12094 current scope in which they are used. This is used later by the
12095 compiler to resolve the reference to an actual Type.
12097 * DeclSpace is no longer a CIR.Type, and neither are
12098 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
12099 are all DeclSpaces, but no Types.
12101 * type.cs (TypeRefManager): This implements the TypeRef manager,
12102 which keeps track of all the types that need to be resolved after
12103 the parsing has finished.
12105 2001-05-13 Miguel de Icaza <miguel@ximian.com>
12107 * ARGH. We are going to have to store `foreach' as a class rather
12108 than resolving it, as we need to verify error 1579 after name
12109 resolution. *OR* we could keep a flag that says `This request to
12110 IEnumerator comes from a foreach statement' which we can then use
12111 to generate the error.
12113 2001-05-10 Miguel de Icaza <miguel@ximian.com>
12115 * class.cs (TypeContainer.AddMethod): we now add methods to the
12116 MethodGroup instead of the method hashtable.
12118 * expression.cs: Add MethodGroup abstraction, which gets us one
12119 step closer to the specification in the way we handle method
12122 * cs-parser.jay (primary_expression): qualified_identifier now
12123 tried to match up an identifier to a local variable reference or
12124 to a parameter reference.
12126 current_local_parameters is now a parser global variable that
12127 points to the current parameters for the block, used during name
12130 (property_declaration): Now creates an implicit `value' argument to
12133 2001-05-09 Miguel de Icaza <miguel@ximian.com>
12135 * parameter.cs: Do not use `param' arguments as part of the
12136 signature, per the spec.
12138 2001-05-08 Miguel de Icaza <miguel@ximian.com>
12140 * decl.cs: Base class for classes, structs and interfaces. This
12141 is the "Declaration Space"
12143 * cs-parser.jay: Use CheckDef for checking declaration errors
12144 instead of having one on each function.
12146 * class.cs: Factor out some code for handling error handling in
12147 accordance to the "Declarations" section in the "Basic Concepts"
12148 chapter in the ECMA C# spec.
12150 * interface.cs: Make all interface member classes derive from
12151 InterfaceMemberBase.
12153 2001-05-07 Miguel de Icaza <miguel@ximian.com>
12155 * Many things: all interfaces are parsed and generated in
12156 gen-treedump. Support for member variables, constructors,
12157 destructors, properties, constants is there.
12159 Beginning of the IL backend, but very little done, just there for
12162 2001-04-29 Miguel de Icaza <miguel@ximian.com>
12164 * cs-parser.jay: Fix labeled statement.
12166 * cs-tokenizer.cs (escape): Escape " and ' always.
12167 ref_line, ref_name: keep track of the line/filename as instructed
12168 by #line by the compiler.
12171 2001-04-27 Miguel de Icaza <miguel@ximian.com>
12173 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
12174 to match the values in System.CodeDOM.
12176 Divid renamed to Divide.
12178 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
12180 (Statements.set): remove.
12182 * System.CodeDOM/CodeCatchClause.cs: always have a valid
12185 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
12186 falseStatements always have valid values.
12188 * cs-parser.jay: Use System.CodeDOM now.