1 2005-02-11 Marek Safar <marek.safar@seznam.cz>
3 C# 2.0 Fixed buffer implementation
5 * anonymous.cs: Update after RegisterHelperClass renaming.
7 * attribute.cs (AttributeTester.fixed_buffer_cache):
8 Cache of external fixed buffers.
9 (AttributeTester.GetFixedBuffer): Returns IFixedBuffer
10 implementation if field is fixed buffer else null.
13 (TypeContainer.AddField): Accept FieldMember instead of Field.
14 (FieldBase.IsFieldClsCompliant): Extracted code from
15 VerifyClsCompliance descendant customization.
16 (FixedField): New class handles fixed buffer fields.
17 (FixedFieldExternal): Keeps information about imported fixed
19 (IFixedField): Make access to internal or external fixed buffer
22 * cs-parser.jay: Add fixed buffer parsing.
24 * ecore.cs (FieldExpr.Emit): Add special emit case for fixed
27 * expression.cs (Indirection): Extended implementation to accept
29 (PointerArithmetic.Emit): Get element from fixed buffer as well.
30 (ElementAccess.MakePointerAccess): Get type as parameter.
31 (DoResolve): Add fixed buffer field expression conversion.
32 (DoResolveLValue): Ditto.
33 (FixedBufferPtr): New class. Moved most of original ArrayPtr.
34 (ArrayPtr): Derives from FixedBufferPtr.
35 (ArrayPtr.Emit): Add extra emit for array elements.
37 * flowanalysis.cs.cs (StructInfo): Use FieldMember.
39 * rootcontext.cs (CloseTypes): Emit CompilerGenerated attribute
40 for compiler generated types.
41 (RegisterCompilerGeneratedType): Renamed from RegisterHelperClass.
43 * statement.cs (Fixed): Refactored to be easier add fixed buffer
44 and consume less memory.
45 (Fixed.Resolve): Add fixed buffer case.
47 * typemanager.cs (compiler_generated_attr_ctor,
48 fixed_buffer_attr_ctor): Add new 2.0 compiler attributes.
49 (HasElementType): Add our own implementation to work on every
52 2005-02-11 Miguel de Icaza <miguel@novell.com>
54 * anonymous.cs (CaptureContext): Track whether `this' has been
57 * expression.cs (This.ResolveBase): Call CaptureThis. Before we
58 only captured `this' if it was implicitly done (instance
59 methods/variables were used).
61 * codegen.cs (EmitContext.CaptureThis): New method to flag that
62 `this' must be captured.
64 2005-01-30 Miguel de Icaza <miguel@novell.com>
66 * anonymous.cs (CreateMethodHost): If there Scope.ScopeTypeBuilder
67 is null it means that there has been no need to capture anything,
68 so we just create a sibling.
70 Renamed `EmitHelperClasses' to `EmitAnonymousHelperClasses'
72 Just a partial fix. The other half is fairly elusive.
74 2005-02-10 Raja R Harinath <rharinath@novell.com>
76 Fix #52586, cs0121-4.cs.
77 * decl.cs (MemberCache.DeepCopy): Rename from SetupCache. Take
78 and return a hashtable.
79 (MemberCache.ClearDeclaredOnly): New.
80 (MemberCache.MemberCache): Update to change. Make a deep copy of
81 the method_hash of a base type too.
82 (MemberCache.AddMethods): Adapt to having a deep copy of the base
83 type methods. Overwrite entries with the same MethodHandle so
84 that the ReflectedType is correct. The process leaves in base
85 virtual functions and their overrides as distinct entries.
86 (CacheEntry): Now a class instead of a struct. It shouldn't alter
87 matters since it was boxed in a ArrayList before.
88 (CacheEntry.Member, CacheEntry.EntryType): Remove 'readonly'
90 * expression.cs (Invocation.BetterFunction): Simplify. Handle the
91 case of a virtual function and its override (choose the overload
93 (Invocation.OverloadResolve): Avoid 'override' members during
94 'applicable_type' calculation.
96 2005-03-28 Raja R Harinath <rharinath@novell.com>
98 * typemanager.cs (TypeHandle.BaseType): Make into an IMemberContainer.
99 (TypeHandle.TypeHandle): Use LookupMemberCache rather than
100 GetTypeHandle. It is possible for a reflected type to derive from
101 a TypeBuilder (e.g., int[] derives from the TypeBuilder
102 System.Array during mscorlib compilation).
103 * decl.cs (MemberCache.MemberCache): If the base cache doesn't
104 contain a method_hash, don't create one either. Don't create a
105 deep copy of the base cache's method_hash.
106 (MemberCache.SetupCache): Rename back from DeepCopy.
107 (MemberCache.AddMethods): Rewrite, now that method_hash isn't
108 already initialized. If we see an override function, add its
109 underlying base virtual function to the member_hash too.
111 2005-02-09 Raja R Harinath <rharinath@novell.com>
113 Combine two near-redundant caches.
114 * typemanager.cs (method_params): Rename from method_internal_params.
115 (TypeManager.GetParameterData): New. Replace
116 Invocation.GetParameterData.
117 (TypeManager.LookupParametersByBuilder): Remove.
118 * expression.cs (Invocation.method_parameter_cache): Remove.
119 (Invocation.GetParameterData): Remove.
121 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
124 2005-02-08 Raja R Harinath <rharinath@novell.com>
127 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
128 TypeManager.multicast_delegate_type is null, resolve it by looking
129 up "System.MulticastDelegate".
130 * rootcontext.cs (RootContext.ResolveCore): Simplify.
132 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
133 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
134 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
137 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
138 (LabeledStatement.AddReference): New. Set 'referenced'.
139 (Goto.Resolve): Use it.
141 2005-02-05 John Luke <john.luke@gmail.com>
143 * driver.cs: remove duplicate -doc line in Usage ()
145 2005-02-04 Raja R Harinath <rharinath@novell.com>
147 * location.cs (Location.AddFile): Fix CS2002 error report.
149 2005-02-02 Martin Baulig <martin@ximian.com>
151 * delegate.cs (Delegate.DefineType): Report an internal error if
152 TypeManager.multicast_delegate_type is null. See bug #72015 for
155 2005-02-02 Raja R Harinath <rharinath@novell.com>
157 Fix a crasher in a variant of #31984.
158 * const.cs (Constant.CheckBase): New override that defers the
159 new-or-override check in case the base type hasn't been populated
161 (Constant.Define): Ensure the new-or-override check is performed.
163 2005-02-01 Duncan Mak <duncan@ximian.com>
165 * const.cs (LookupConstantValue): Check that `ce' is not null
166 before calling GetValue ().
168 2005-02-01 Raja R Harinath <rharinath@novell.com>
170 Fix test-334.cs (#69519).
171 * cs-parser.jay (using_alias_directive): Pass in an expression to
172 NamespaceEntry.UsingAlias.
173 (using_namespace_directive): Pass in an expression to
174 NamespaceEntry.Using.
175 (namespace_name): Don't flatten to a string.
176 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
177 (NamespaceEntry.AliasEntry.Resolve): Lookup using
179 (NamespaceEntry.UsingEntry): Likewise.
180 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
182 (NamespaceEntry.LookupForUsing): Remove.
183 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
185 (NamespaceEntry.Lookup): Remove support for dotted names.
187 2005-02-01 Raja R Harinath <rharinath@novell.com>
189 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
191 (NamespaceEntry.ImplicitParent): Compute on demand.
192 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
193 parallels the current.
194 (NamespaceEntry.LookupForUsing): Use it.
195 (NamespaceEntry.Lookup): If the current namespace-entry is
196 implicit, don't search aliases and using tables.
198 2005-02-01 Raja R Harinath <rharinath@novell.com>
201 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
203 (TypeContainer.BaseCache): Compute on demand.
204 (TypeContainer.FindMembers): Define constants and types if they're
206 (FieldMember.Define): Move resetting of ec.InUnsafe before error
208 * const.cs (Constant.Define): Make idempotent.
210 2005-01-29 Miguel de Icaza <miguel@novell.com>
212 * pending.cs: Produce better code (no nops produced by using Ldarg
215 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
216 i - 1' it should be arg + 1.
220 2005-01-28 Raja R Harinath <rharinath@novell.com>
222 * attribute.cs (Attribute.CheckAttributeType): Make private
224 (Attribute.ResolveType): Make virtual.
225 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
226 handling of RootContext.Tree.Types.
228 2005-01-27 Raja R Harinath <rharinath@novell.com>
230 Update attribute-handling to use the SimpleName/MemberAccess
232 * cs-parser.jay (attribute): Pass in an expression to the
233 constructors of Attribute and GlobalAttribute.
234 * attribute.cs (Attribute): Take an expression for the name.
235 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
236 passed in attribute name expression.
237 (Attribute.CheckAttributeType): Use it.
238 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
239 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
240 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
241 argument to prevent error messages if the lookup fails.
243 2005-01-27 Marek Safar <marek.safar@seznam.cz>
245 * expression.cs (Indirection): Implemented IVariable interface
246 to support indirection in AddressOf operator.
247 (PointerArithmetic.Emit): Add optimalization for case where
248 result can be precomputed.
250 2005-01-26 Martin Baulig <martin@ximian.com>
252 * class.cs (TypeContainer.AttributeTargets): Return the correct
253 AttributeTargets depending on our `Kind' instead of throwing an
254 exception; fixes #71632.
256 2005-01-26 Marek Safar <marek.safar@seznam.cz>
259 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
262 2005-03-17 Martin Baulig <martin@ximian.com>
264 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
265 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
267 2005-03-17 Martin Baulig <martin@ximian.com>
269 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
270 to bool so we can return an error condition.
271 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
274 2005-03-17 Martin Baulig <martin@ximian.com>
276 * generic.cs (TypeMananager.IsIEnumerable): New public method.
278 * convert.cs (Convert.ImplicitReferenceConversion(Exists)): Allow
279 converting from an array-type of T to `IEnumerable<T>'.
281 2005-03-16 Martin Baulig <martin@ximian.com>
283 * generic.cs (Nullable.Unwrap): Implement IAssignMethod.
284 (Nullable.LiftedUnaryMutator): New public class.
286 * expression.cs (UnaryMutator.DoResolve): Added support for
289 2005-03-14 Martin Baulig <martin@ximian.com>
291 * generic.cs (Nullable.NullCoalescingOperator): Implemented.
293 2005-03-14 Martin Baulig <martin@ximian.com>
295 * generic.cs (Nullable.LiftedBinaryOperator): Added support for
296 the comparision operators `<', `>', `<=' and `>='.
298 2005-03-13 Martin Baulig <martin@ximian.com>
301 (Nullable.NullLiteral): Renamed to `Nullable.NullableLiteral' to
302 avoid confusion with the `NullLiteral'.
303 (Nullable.LiftedBinaryOperator): Correctly implement `==' and '!='.
305 2005-03-13 Martin Baulig <martin@ximian.com>
307 * expression.cs (Binary.ResolveOperator): For `==' and `!=', allow
308 comparing arbitrary types with the null literal.
310 2005-03-13 Martin Baulig <martin@ximian.com>
312 * generic.cs (Nullable.LiftedBinaryOperator): Add support for the
313 boolean operators '&&', '||', '&' and '|'.
314 (Nullable.OperatorTrueOrFalse): New public class.
316 * ecore.cs (Expression.GetOperatorTrue/False): Return an `Expression'
317 instead of a `StaticCallExpr'; added support for nullables.
319 2005-03-10 Martin Baulig <martin@ximian.com>
322 (ArrayAccess.EmitDynamicInitializers): Use `etype.IsValueType'
323 rather than `etype.IsSubclassOf (TypeManager.value_type)'.
325 2005-03-07 Martin Baulig <martin@ximian.com>
327 * generic.cs (Nullable.Unwrap): Implement IMemoryLocation and make
328 it work if `expr' is not an IMemoryLocation.
329 (Nullable.Lifted): Implement IMemoryLocation.
330 (Nullable.LiftedConversion.ResolveUnderlying): Use the correct
333 2005-03-05 Martin Baulig <martin@ximian.com>
335 * generic.cs (Nullable.Unwrap, Wrap): New protected classes.
336 (Nullable.Lifted): New abstract class; rewrote the lifted conversions.
337 (Nullable): Added support for lifted unary and binary operators.
339 * expression.cs (Unary.DoResolve): Added support for nullable types.
340 (Binary.DoResolve): Likewise.
341 (Conditional.DoResolve): Likewise.
343 2005-03-02 Martin Baulig <martin@ximian.com>
345 * decl.cs (DeclSpace.SetParameterInfo): Make this virtual.
347 * class.cs (ClassPart.SetParameterInfo): Override this.
348 (PartialContainer.SetParameterInfo): Override this.
349 (TypeContainer.CheckConstraints): New protected method.
350 (PartialContainer.CheckConstraints): Override this and check
351 whether the same contraints were specified in all parts of a
352 partial generic type definition.
353 (PartialContainer.UpdateConstraints): New public method.
355 * generic.cs (TypeParameter.UpdateConstraints): New public method.
357 2005-03-02 Martin Baulig <martin@ximian.com>
359 Committing a patch from Carlos Alberto Cortez to fix #72887.
361 * convert.cs (Convert.ExplicitReferenceConversionExists): Allow
362 casts from `T []' to `int []'.
364 2005-03-02 Martin Baulig <martin@ximian.com>
366 * generic.cs (TypeManager.IsEqual): Make this symmetric.
368 * expression.cs (Binary.ResolveOperator): When resolving a
369 BinaryDelegate, use `TypeManager.IsEqual (l, r)' rather than just
370 `=='. Fixes #71866. See gen-127.cs.
372 2005-03-02 Martin Baulig <martin@ximian.com>
374 * class.cs (TypeContainer.DoDefineMembers): We also need a default
375 static constructor in static classes.
377 2005-03-02 Martin Baulig <martin@ximian.com>
380 (NullableType.Name, NullableType.FullName): Add a "?" to the name.
381 (Nullable.LiftedConversion): Added support for user-defined
384 * cs-tokenizer.cs (Tokenizer.PutbackCloseParens): New public method.
386 * cs-parser.jay: Use ComposedCast everywhere instead of
387 NullableType, so we don't need to check for NullableType
389 (conditional_expression): Added `INTERR CLOSE_PARENS' rule for the
390 case where we'll be resolved into a `parenthesized_expression_0'
394 (Convert.UserDefinedConversion): Added nullable conversions.
396 2005-02-28 Martin Baulig <martin@ximian.com>
398 * generic.cs (TypeManager.IsNullableType): New static method.
399 (Nullable): New abstract class.
400 (Nullable.NullLiteral): New public class.
401 (Nullable.LiftedConversion): New public class.
403 * cs-parser.jay (non_expression_type): Changed `builtin_types' to
404 `builtin_types opt_nullable'.
407 (Convert.ImplicitConversionStandard): Added nullable conversions.
408 (Convert.ExplicitConversionStandard): Likewise.
409 (Convert.ExplicitConversion): Likewise.
411 2005-02-26 Martin Baulig <martin@ximian.com>
413 * expression.cs (ComposedCast.DoResolveAsTypeStep): Allow `dim' to
414 begin with a "?", for instance "?[]". Don't do a type lookup if
417 2005-02-25 Martin Baulig <martin@ximian.com>
419 The first part of Nullable Types :-)
421 * generic.cs (NullableType): New public class.
422 (NullCoalescingOperator): New public class.
423 (TypeArguments.Resolve): Add a CS0306 check.
425 * cs-parser.jay (opt_error_modifier): Removed, this was unused.
426 (opt_nullable): New rule.
427 (type): Added `opt_nullable' to `namespace_or_type_name',
428 `builtin_types' and `pointer_type'.
429 (array_type): Added `opt_nullable'.
430 (opt_rank_specifier_or_nullable): New rule; this is the
431 combination of `opt_rank_specifier' and `opt_nullable'.
432 (opt_error): New rule; catch errors here.
433 (nullable_type_or_conditional): New rule; we use this to check for
434 nullable and still detect the conditional operator.
435 (local_variable_type): Use `opt_rank_specifier_or_nullable'
436 instead `opt_rank_specifier'.
438 * expression.cs (ComposedCast.DoResolveAsTypeStep): Added support
441 2005-02-24 Martin Baulig <martin@ximian.com>
443 * README, README.Changes: Removed; they're old and obsolete.
445 2005-02-22 Martin Baulig <martin@ximian.com>
447 * generic.cs (TypeParameter.Resolve): If resolving the constraints
448 returned an error, set `constraints' to null to avoid a crash
450 (TypeParameter.ResolveType): Likewise.
452 2005-02-22 Martin Baulig <martin@ximian.com>
455 (Constraints.ResolveTypes): Protect against being called twice.
456 (Constraints.CheckInterfaceMethod): Don't call ResolveTypes().
457 (TypeParameter.ResolveType): New public method; calls
458 constraints.ResolveTypes().
459 (TypeParameter.DefineType): Moved constraints.ResolveType() out
460 into the new ResolveType().
461 (GenericMethod.Define): Call ResolveType() on all our
464 2005-02-21 Martin Baulig <martin@ximian.com>
467 (TypeManager.generic_nullable_type): New static public field.
468 (TypeManager.InitGenericCoreType): Lookup "System.Nullable`1".
471 (RootContext.ResolveCore): Resolve "System.Nullable`1".
473 2005-02-15 Martin Baulig <martin@ximian.com>
475 * generic.cs (ConstructedType.Constraints): Correctly check
476 constraints if the argument type is a type parameter; fixes
479 2005-02-02 Martin Baulig <martin@ximian.com>
481 * delegate.cs (Delegate.DefineType): Report an internal error if
482 TypeManager.multicast_delegate_type is null. See bug #72015 for
485 2005-01-29 Miguel de Icaza <miguel@novell.com>
487 * pending.cs: Produce better code (no nops produced by using Ldarg
490 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
491 i - 1' it should be arg + 1.
495 2005-01-26 Martin Baulig <martin@ximian.com>
497 * cs-parser.jay (indexer_declarator): Don't report an error if we
498 have type parameters since we can be an explicit interface
499 implementation; fixes #71449.
501 2005-01-26 Martin Baulig <martin@ximian.com>
503 * class.cs (TypeContainer.AttributeTargets): Return the correct
504 AttributeTargets depending on our `Kind' instead of throwing an
505 exception; fixes #71632.
507 2005-01-26 Martin Baulig <martin@ximian.com>
509 * delegate.cs (Delegate.DefineType): Correctly define our type
510 parameters. Fixes #71483.
512 2005-01-25 Raja R Harinath <rharinath@novell.com>
515 * expression.cs (MemberAccess.DoResolve): Don't complain with
516 cs0572 when the LHS of a member access has identical name and type
519 2005-01-25 Marek Safar <marek.safar@seznam.cz>
522 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
524 Create custom PermissionSet only for PermissionSetAttribute.
526 2005-01-24 Marek Safar <marek.safar@seznam.cz>
529 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
530 delegates in static class.
532 2005-01-24 Martin Baulig <martin@ximian.com>
534 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
535 merging an implicit block, just use its reachability.
537 * statement.cs (Block.Resolve): Make the unreachable code check
538 work wrt. implicit blocks; see test-337 from #63842.
540 2005-01-21 Alp Toker <alp@atoker.com>
542 * cs-parser.jay: destructor_declaration's container is PartialContainer
543 not Class when partial types are used, so use Kind prop instead of
546 2005-01-22 Miguel de Icaza <miguel@ximian.com>
548 * cs-parser.jay: Improve error reporting when an interface
551 2005-01-20 Dick Porter <dick@ximian.com>
553 * support.cs: SeekableStreamReader fix from Sandor Dobos
554 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
555 chars are read. Fixes bug 70369.
557 2005-01-20 Raja R Harinath <rharinath@novell.com>
559 * cs-parser.jay (catch_clause): Simplify current_block handling
562 2005-01-17 Miguel de Icaza <miguel@ximian.com>
564 * convert.cs (ImplicitStandardConversionExists): Synchronize the
565 code with ImplicitStandardConversion to handle the implicit
566 conversion of method groups into valid delegate invocations.
568 The problem is that in parameter handling we were using this code
569 path. Fixes bug #64698
571 2005-01-19 Raja R Harinath <rharinath@novell.com>
573 * cs-parser.jay: Fix several infelicities.
574 - Avoid assigning to the parser value stack. Code like
575 '$3 = null' is unclean. Synthesize a value for the code block
577 - Avoid using oob_stack for storing location information. Use ...
578 (_mark_): ... this. New (empty) rule. Saves the current location
580 (foreach_statement): Avoid using oob_stack for current_block
581 handling. Use technique used in for_statement and
582 using_statement. Synthesize a value for the code block to store
583 additional intermediate information.
585 2005-01-13 Miguel de Icaza <miguel@ximian.com>
587 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
588 of a different type is only allowed to private fields of a
589 containing type, not on fields of a base class.
591 See test-174.cs and error cs0122-9.cs
593 2005-01-13 Raja R Harinath <rharinath@novell.com>
595 Fix test-335.cs (bug #58126).
596 * cs-parser.jay (argument): Split out non-expression parts of the
597 rule into 'non_simple_argument'.
598 (invocation_expression): Support parenthesized invocations with
599 multiple arguments, and with single non-simple arguments.
601 2005-01-13 Raja R Harinath <rharinath@novell.com>
603 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
606 2005-01-12 Raja R Harinath <rharinath@novell.com>
608 Fix cs0038-1.cs, cs1640-6.cs.
609 * ecore.cs (Expression.Resolve): Remove special-case for
610 SimpleName in error-handling.
611 (Expression.almostMatchedMembers): Relax access permission to
613 (Expression.MemberLookupFailed): Handle duplicates in
614 almostMatchedMembers list.
615 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
616 * expression.cs (New.DoResolve): Report CS1540 for more cases.
617 * typemanager.cs (GetFullNameSignature): Use the MethodBase
618 overload if the passed in MemberInfo is a MethodBase.
620 2005-01-25 Martin Baulig <martin@ximian.com>
623 (DocUtil.emptyParamList): Removed; use `Type.EmptyTypes' instead.
625 2005-01-12 Marek Safar <marek.safar@seznam.cz>
628 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
629 for non-CAS & merge permission sets properly.
631 2005-01-11 Raja R Harinath <rharinath@novell.com>
633 Improve standard-compliance of simple name and member access
634 resolution. Fixes bugs #52697, #57200, #67520, #69519.
635 * ecore.cs (FullNamedExpression): New abstract base class
636 for Namespaces and TypeExpressions.
637 (ResolveFlags.SimpleName): Remove.
638 (SimpleName): Remove support for dotted names.
639 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
640 DeclSpace.FindType and DeclSpace.LookupType.
641 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
642 (Expression.ExprClassName): Make member function.
643 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
644 a namespace. Remove creation of dotted "SimpleName"s.
645 (MemberAccess.DoResolve): Likewise.
646 * decl.cs (DeclSpace.Cache): Make private.
647 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
648 (DeclSpace.FindType): Update.
649 (DeclSpace.LookupType): Move here from RootContext. Return a
651 * namespace.cs (Namespace): Derive from FullNamedExpression
652 so that it can be part of expression resolution.
653 (Namespace.Lookup): Return an FullNamedExpression.
654 (NamespaceEntry.LookupAlias): Lookup aliases only in current
656 * rootcontext.cs (NamespaceLookup): Remove.
657 (LookupType): Move to DeclSpace.
658 * attribute.cs (CheckAttributeType): Update.
659 * doc.cs (FindDocumentedType): Remove allowAlias argument.
660 (FindDocumentedTypeNonArray): Likewise.
662 2005-01-11 Raja R Harinath <rharinath@novell.com>
664 Fix cs0509.cs, cs1632.cs.
665 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
666 is the same as IsInterface.
667 (TypeContainer.GetClassBases): Likewise.
668 * statement.cs (LabeledStatement.ig): New field.
669 (LabeledStatement.LabelTarget): Save ILGenerator which created the
671 (LabeledStatement.DoEmit): Check that the label was created with
672 the same ILGenerator.
674 2005-01-10 Marek Safar <marek.safar@seznam.cz>
677 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
678 accessors to its properties.
680 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
681 from accessors to property.
683 2005-01-10 Marek Safar <marek.safar@seznam.cz>
686 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
689 2005-01-08 Miguel de Icaza <miguel@ximian.com>
691 * attribute.cs: Check for null and empty strings.
693 I have lost another battle to Paolo.
695 2005-01-07 Marek Safar <marek.safar@seznam.cz>
698 * class.cs (PropertyMethod): Set Parent field in ctors.
699 (SetMethod.InternalParameters): Add unsafe switch hack.
700 Override MarkForDuplicationCheck where it is appropriate.
702 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
703 It says whether container allows members with the same name.
705 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
706 Removed is_method parameter.
708 2005-01-06 Duncan Mak <duncan@ximian.com>
710 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
711 because the previous change led to incorrect reporting of CS1032
712 ("Cannot define/undefine preprocessor symbols after first token in
713 file"). Instead of using `tokens_seen' as the only flag that
714 triggers CS1040, introduce `comments_seen'. This new flag is used
715 to signify having seen comments on the current line, so it is
716 unset after a newline.
718 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
720 * doc.cs : When searching for a type, find nested type too.
721 This fixes bug #71040.
723 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
726 - Warn missing member comment on those classes which also does not
727 have doc comments. Fixed bug #71041.
728 - Don't warn missing doc comment on default constructor.
731 2005-01-06 Duncan Mak <duncan@ximian.com>
733 * cs-tokenizer.cs (xtoken): After handling traditional C-style
734 comments, set `tokens_seen' to true. This allows us to detect
735 misplaced preprocessor directives (i.e. not at the beginning of
736 the a line, nor after whitespaces). In that case, report error
737 CS1040. This fixes bug #56460.
739 * cs-parser.jay (interface_member_declaration): Add checks for
740 IsExplicitImpl, and report CS0541 error if an interface member is
741 defined as an explicit interface declaration.
743 2005-01-06 Marek Safar <marek.safar@seznam.cz>
746 * class.cs (PropertyMethod): Set Parent field in ctors.
747 (SetMethod.InternalParameters): Add unsafe switch hack.
749 * decl.cs (MemberCore.Parent): Cannot be readonly.
751 2005-01-06 Raja R Harinath <rharinath@novell.com>
753 * decl.cs (DeclSpace.ResolveType): Remove.
754 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
755 Merge in code from ...
756 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
757 * class.cs, enum.cs: Update to changes.
759 2005-01-06 Miguel de Icaza <miguel@ximian.com>
761 * anonymous.cs: Ensure that we init the scope of our parent if it
762 has not been initialized yet.
764 2004-12-30 Duncan Mak <duncan@ximian.com>
766 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
767 if field.FieldBuilder is null. Fixes #70758.
769 * convert.cs: Fixed some typos and updated some of the comments.
770 (ImplicitStandardConversionExists):
771 (TryImplicitIntConversion): If `target_type' is an interface and
772 the type of `ic' implements this interface, return true or a new
773 BoxedCast instead of null. This fixes #70468.
775 2004-12-29 Duncan Mak <duncan@ximian.com>
777 * expression.cs (Argument.Emit): Check that Expr is
778 IMemoryLocation before casting to it, and report CS1510 otherwise.
782 2004-12-21 Ben Maurer <bmaurer@ximian.com>
784 * statement.cs (Block.ThisVariable): remove the recursion here, to
785 make the --profile more sane.
787 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
789 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
790 assembly, by JB Evain.
792 2004-12-17 Raja R Harinath <rharinath@novell.com>
794 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
795 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
796 "parent" refers to enclosing type/class. "base" refers to superclass.
798 2004-12-17 Raja R Harinath <rharinath@novell.com>
800 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
801 Ensure that we only have GlobalAttributes.
802 * attribute.cs (Attribute.Emit): Make non-virtual.
803 (GlobalAttribute.Emit): Remove.
804 (Attribute.Resolve): Make virtual.
805 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
806 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
807 the argument. Don't create one.
808 (Attribute.GetObsoleteAttribute): Likewise.
809 (Attribute.GetClsCompliantAttributeValue): Likewise.
810 * class.cs, decl.cs: Update to changes.
812 2004-12-17 Marek Safar <marek.safar@seznam.cz>
814 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
816 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
818 * statement.cs (Foreach.Resolve): Add error 186 report.
820 2004-12-16 Marek Safar <marek.safar@seznam.cz>
822 * expression.cs (Conditional.DoResolve): Add warning 429.
824 * statement.cs (If.Resolve): Add warning 665.
826 2004-12-16 Raja R Harinath <rharinath@novell.com>
828 New invariant: RootContext.Tree.Types.NamespaceEntry == null
829 except when in the parser, and in GlobalAttribute.
830 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
831 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
832 RootContext.Tree.Types.NamespaceEntry once work is done.
833 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
834 and resets RootContext.Tree.Types.NamespaceEntry.
836 2004-12-15 Marek Safar <marek.safar@seznam.cz>
838 * cs-parser.jay: Don't create a block for every variable.
840 2004-12-14 Miguel de Icaza <miguel@ximian.com>
842 * location.cs: Provide extra information.
844 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
845 variables from the captured environment, it is the ldarg_0.
847 2004-12-14 Marek Safar <marek.safar@seznam.cz>
849 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
852 * class.cs: Changed warning level for 169 to avoid developer
853 displeasure from warning flooding. It will be changed back when they
854 fix most of current BCL warnings.
856 * RootContext.cs: Pushed default WarningLevel to 3.
858 * statement.cs: Removed unused variable.
860 2004-12-14 Marek Safar <marek.safar@seznam.cz>
862 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
863 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
864 Add error 502 report.
865 (StaticClass.DefineType): Add error 441 report.
866 (Class.AllowedModifiersProp): New virtual property as temporary
867 extension to AllowedModifiers.
868 (Class.DefineType): Add error 418 report. Moved ModFlags check here
869 to share implementation with StaticClass and don't call virtual
872 * driver.cs (MainDriver): Add error 1558 test.
874 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
875 report. Moved error 36 test here.
877 * statement.cs (Throw.Resolve): Add error 724 report.
879 * typemanager.cs: Add out_attribute_type core type.
881 2004-12-13 Marek Safar <marek.safar@seznam.cz>
883 * class.cs (TypeContainer.VerifyClsCompliance): Add error
885 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
887 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
890 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
892 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
893 Add error 3023 report.
894 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
896 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
899 2004-12-12 John Luke <john.luke@gmail.com>
901 * driver.cs (AddArgs): take -- into account when
902 adding arguments, fixes bug 65710
904 2004-12-12 Martin Baulig <martin@ximian.com>
906 * expression.cs (Unary.TryReduceNegative): Added support for
907 SByteConstant and ByteConstant.
908 (Unary.Reduce): Check error values from TryReduceNegative().
910 2004-12-10 Marek Safar <marek.safar@seznam.cz>
912 * attributes.cs (Attribute.Resolve): Avoid multiple error report
913 and report exception as error 182.
915 2004-12-10 Raja R Harinath <rharinath@novell.com>
917 * driver.cs (Main): Fix message when there are warnings.
919 2004-12-09 Miguel de Icaza <miguel@ximian.com>
921 * delegate.cs: Fixed my fix from yesterday, sorry about that.
923 2004-12-09 Marek Safar <marek.safar@seznam.cz>
925 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
926 Reduced number of warnings.
928 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
930 2004-12-08 Miguel de Icaza <miguel@ximian.com>
932 * driver.cs: Removed message.
934 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
936 2004-12-08 <vargaz@freemail.hu>
938 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
940 2004-12-08 Martin Baulig <martin@ximian.com>
942 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
943 instead of a CS3002 for properties and indexer.
945 2004-12-08 Martin Baulig <martin@ximian.com>
947 * decl.cs (MemberName.ToString): Make this work again.
949 2004-12-08 Marek Safar <marek.safar@seznam.cz>
951 * attribute.cs (Resolve): Add error 591 detection.
953 * class.cs (FieldMember.Define): Add error 1547 detection.
954 (Indexer.Define): Add error 620 detection.
955 (Operator.Define): Add error 590 detection.
957 * ecore.cs: Missing argument for error 79.
959 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
962 2004-12-07 Marek Safar <marek.safar@seznam.cz>
965 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
968 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
970 * cs-parser.jay : handle doc comments on implicit/explicit operators.
971 Some operator comments were suppressed.
972 * doc.cs : Implicit/explicit operator name in doc comments are like
973 "op_Explicit(type)~returnType", so added suffix handling.
975 2005-01-21 Alp Toker <alp@atoker.com>
977 * cs-parser.jay: destructor_declaration's container is PartialContainer
978 not Class when partial types are used, so use Kind prop instead of 'is'.
980 2004-12-12 Martin Baulig <martin@ximian.com>
982 * expression.cs (Unary.TryReduceNegative): Added support for
983 SByteConstant and ByteConstant.
984 (Unary.Reduce): Check error values from TryReduceNegative().
986 2004-12-11 Martin Baulig <martin@ximian.com>
988 * support.cs (ReflectionParameters.ParameterName): If we have a
989 `gpd', call `ParameterName' on it.
991 * parameter.cs (Parameter.GetParameterAttributes): New static method.
993 * pending.cs (PendingImplementation.DefineProxy): Call
994 DefineParameter() for all of the MethodBuilder's arguments.
996 2004-12-09 Martin Baulig <martin@ximian.com>
998 * doc.cs (DocUtil): Make this a static class.
1000 2004-12-09 Martin Baulig <martin@ximian.com>
1002 * expression.cs (Invocation.InferType): Moved the type inference
1003 implementation into TypeManager.
1005 * generics.cs (TypeManager): Moved the type inference
1006 implementation here.
1008 2004-12-09 Martin Baulig <martin@ximian.com>
1010 * typemanager.cs (TypeManager): Make this a partial class.
1013 (TypeManager): Move the generics part of `TypeManager' here.
1015 2004-12-08 Martin Baulig <martin@ximian.com>
1017 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
1018 instead of a CS3002 for properties and indexer. Added CS3024
1019 check for generic interfaces.
1021 * attributes.cs (AttributeTester.AnalyzeTypeCompliance): Generic
1022 instances are not CLS-compliant.
1024 2004-12-08 Martin Baulig <martin@ximian.com>
1027 (void_pointer_expression): New rule for `void*', `void**' etc.
1028 (typeof_expression): Add `void_pointer_expression'; fixes #66846.
1030 2004-12-08 Martin Baulig <martin@ximian.com>
1032 * expression.cs (Invocation.InferType): Removed the hack for
1033 MethodCore.MayUnify().
1035 * typemanager.cs (TypeManager.MayBecomeEqualGenericTypes): Make
1038 * class.cs (MethodCore.MayUnify): Use
1039 TypeManager.MayBecomeEqualGenericTypes().
1041 2004-12-08 Martin Baulig <martin@ximian.com>
1043 * expression.cs (Is.DoResolve, As.DoResolve): If we're a type
1044 parameter, box it. Fixes #69233.
1046 2004-12-08 Martin Baulig <martin@ximian.com>
1048 * generic.cs (ConstructedType.CheckConstraints): Valuetypes always
1049 have the ctor constraint. Fixes #68326.
1051 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
1053 * cs-parser.jay : interface comment was not consumed because of
1054 extra opt_semicolon before doc handling.
1056 2004-12-03 Raja R Harinath <rharinath@novell.com>
1058 Fix test-327.cs, test-328.cs, and put in early infrastructure
1059 for eventually fixing #52697.
1060 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
1061 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
1063 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
1064 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
1065 (VerifyUsing, error246): Update.
1066 * rootcontext.cs (RootContext.NamespaceLookup): Just use
1067 'NamespaceEntry.LookupNamespaceOrType'.
1069 2004-12-07 Martin Baulig <martin@ximian.com>
1071 * driver.cs: Call it "BETA SOFTWARE" :-)
1073 2004-12-06 Raja R Harinath <rharinath@novell.com>
1075 Fix crash on cs0657-17.cs.
1076 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
1077 Use RootContext.Tree.Types, not 'new RootTypes ()'.
1078 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
1079 the case where the NamespaceEntry gets overwritten.
1081 2004-12-06 Marek Safar <marek.safar@seznam.cz>
1083 Fixed #69195, #56821
1084 * ecore.cs (ResolveBoolean): Tiny refactoring.
1086 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
1087 of right expression resolving when left is false constant and
1088 operator is LogicalAnd OR true constant and operator is LogicalOr.
1090 * statement.cs (ResolveUnreachable): Always reports warning.
1092 2004-12-05 Miguel de Icaza <miguel@ximian.com>
1094 * class.cs: Distinguish between 1721 and 1722 (just a little help
1095 for the programmer).
1097 2004-12-03 Miguel de Icaza <miguel@ximian.com>
1099 * delegate.cs: Only allow this on new versions of the language.
1101 2004-12-02 Duncan Mak <duncan@ximian.com>
1103 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
1105 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
1106 here as a static method. Take an additional bool out parameter
1107 `must_do_cs1540_check' for signaling to InstanceResolve.
1108 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
1109 member field from PropertyExpr class and made it an argument of
1111 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
1112 check for MarshalByRefObject, and report CS0122 instead of CS1540.
1113 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
1114 and `remove_accessor' as well as InstanceResolve: report CS0122
1119 2004-12-07 Martin Baulig <martin@ximian.com>
1121 * decl.cs (DeclSpace.AddToContainer): Report correct errors CS0694
1122 and CS0692 where appropriate.
1124 2004-12-06 Martin Baulig <martin@ximian.com>
1126 * class.cs (MethodCore.MayUnify): Moved the CS0408 check here from
1127 IsDuplicateImplementation() and improved it.
1129 * expression.cs (Invocation.InferTypeArguments): Added
1130 `Type[] inferred_class_types' argument (for MethodCore.MayUnify)
1131 and removed the "ref" modifier from `infered_types'.
1133 * decl.cs (MemberName.ToString): Removed the exception.
1135 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
1137 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
1138 comments are allowed.
1140 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
1142 * delegate.cs: Add checks for subtypes in paramaters and return values
1143 in VerifyMethod () to add support for Covariance/Contravariance
1146 2004-12-02 Miguel de Icaza <miguel@ximian.com>
1148 * report.cs: Remove extra closing parenthesis.
1150 * convert.cs (Error_CannotImplicitConversion): If the name of the
1151 types are the same, provide some extra information.
1153 2004-12-02 Marek Safar <marek.safar@seznam.cz>
1156 * attribute.cs (Resolve): Improved implementation of params
1157 attribute arguments.
1159 * support.cs (ParameterData): Add HasParams to be faster.
1161 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
1163 all things are for /doc support:
1165 * doc.cs: new file that supports XML documentation generation.
1166 * mcs.exe.sources: added doc.cs.
1168 Handle /doc command line option.
1169 Report error 2006 instead of 5 for missing file name for /doc.
1170 Generate XML documentation when required, after type resolution.
1172 Added support for picking up documentation (/// and /** ... */),
1173 including a new XmlCommentState enumeration.
1175 Added lines to fill Documentation element for field, constant,
1176 property, indexer, method, constructor, destructor, operator, event
1177 and class, struct, interface, delegate, enum.
1178 Added lines to warn incorrect comment.
1180 Added Documentation field (passed only when /doc was specified).
1182 Added DocComment, DocCommentHeader, GenerateDocComment() and
1183 OnGenerateDocComment() and some supporting private members for
1184 /doc feature to MemberCore.
1186 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
1188 Added overriden DocCommentHeader.
1190 Added overriden DocCommentHeader and GenerateDocComment().
1192 2004-12-01 Miguel de Icaza <miguel@ximian.com>
1194 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
1195 unwrapping the enumeration values, chain to
1196 DoConstantNumericPromotions again, so we can promote things to the
1197 fundamental types (takes care of enums that are bytes, sbytes).
1201 2004-12-01 Raja R Harinath <rharinath@novell.com>
1203 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
1204 Fix long-standing bug in type-lookup. Use FindType instead of
1205 LookupType when ec.ResolvingTypeTree.
1206 (Attribute.ResolveType, Attribute.Resolve)
1207 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
1209 (Attributes.Search): Remove internal version. Update.
1210 (Attributes.SearchMulti): Update.
1211 (Attributes.GetClsCompliantAttribute): Remove.
1212 (Attributes.GetIndexerNameAttribute): Remove.
1213 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
1214 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
1215 * class.cs (Indexer.Define): Likewise.
1217 2004-12-01 Marek Safar <marek.safar@seznam.cz>
1220 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
1221 MarshallByReference members access.
1223 * expression.cs: Use CheckMarshallByRefAccess;
1224 Better error CS0197 message.
1226 * report.cs: Print whole related error message.
1228 2004-11-29 Marek Safar <marek.safar@seznam.cz>
1230 * class (GetClassBases): Better error 60 report.
1231 (EventProperty): Disabled warning 67 detection.
1233 2004-11-29 Marek Safar <marek.safar@seznam.cz>
1236 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
1238 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
1241 2004-11-29 Marek Safar <marek.safar@seznam.cz>
1244 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
1246 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
1248 2004-11-26 Miguel de Icaza <miguel@ximian.com>
1250 * attribute.cs (Attribute.Resolve): Refine error reporting and
1251 report a cs0117 if the identifier does not exist, to distinguish
1252 from 0617 which is a miss-use of the actual identifier.
1254 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
1255 between cs0070 and cs0079.
1257 * class.cs (MemberBase.DoDefine): When reporting a wrong
1258 accessibility level, we use MethodCore to compare instead of
1259 Method (this was a regression in some refactoring effort).
1261 So now we correctly report cs0056 again.
1263 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
1264 testing the target_type (which was known to be object_type) and
1265 not the source type (which is anonymous_method).
1267 Fixed reporting of error cs1660.
1269 * expression.cs (UserCast.Source): Expose the underlying cast.
1271 * statement.cs (Switch.SwitchGoverningType): Sort the list of
1272 allowed types to find a match to int32 first (most common).
1274 In addition, it ignores any ImplicitUserConversions that did an
1275 internal implicit conversion (as the switch statement allows only
1276 one integral conversion to exist).
1278 * class.cs (PartialContainer.Create): rename `name' to
1279 `member_name' for clarity. Then replace the string calls with a
1280 call to MemberName.GetPartialName, as now using
1281 MemberName.ToString is an error (this is due to the side effects
1282 it had, that were fixed in the past).
1284 This will restore the error reporting on a number of partial class
1285 errors that were missusing this (and getting an exception as a
1286 results, which is now just a plain textual warning, because
1287 yyparse debug output would crash otherwise).
1289 2004-11-26 Raja R Harinath <rharinath@novell.com>
1291 * Makefile (PROGRAM_INSTALL_DIR): Remove.
1293 2004-11-25 Ben Maurer <bmaurer@ximian.com>
1295 * rootcontext.cs (LookupType): Make sure to cache lookups that
1296 don't give us a negative result. This saves about 5% of corlib
1299 2004-11-25 Miguel de Icaza <miguel@ximian.com>
1301 * report.cs (AbstractMessage.Print): messages are sent to stderr
1303 * class.cs (TypeContainer.GetClassBases): It is an error to have a
1304 non-interface in the list of interfaces (at this point, either
1305 parent was properly set, or a base class is being listed in the
1306 interfaces section).
1308 This flags error 1722, and resolves the crash from bug 69259.
1310 2004-11-25 Ben Maurer <bmaurer@ximian.com>
1312 * statement.cs (Using.EmitExpressionFinally): make this work right
1313 for valuetypes. Fixes 69926.
1315 2004-11-25 Miguel de Icaza <miguel@ximian.com>
1317 * const.cs (Const.ChangeType): Cope with the "0 literal can be
1318 converted to an enum" here, before we try to change the underlying
1319 type. This code exists, but it is a different code path than the
1320 one used while encoding constants.
1322 (ImplicitReferenceConversionExists): In addition, resynchronized
1323 the code here, so it matches the same code in
1324 ImplicitReferenceConversionExists for the `from any class-type S
1325 to any interface-type T'.
1327 2004-11-25 Marek Safar <marek.safar@seznam.cz>
1329 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
1331 2004-11-24 Miguel de Icaza <miguel@ximian.com>
1333 * cs-parser.jay: Use verbosity accordingly.
1335 2004-11-24 Marek Safar <marek.safar@seznam.cz>
1337 * expression.cs (Unary.ResolveOperator): Do not report warning;
1338 AddressOf reads from variable.
1340 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
1342 2004-11-24 Marek Safar <marek.safar@seznam.cz>
1346 * attribute.cs (Attributable): Removed CheckTargets.
1347 (Attributes.Emit): Explicit attribute targets are tested here.
1349 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
1350 not enabled for interfaces.
1352 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
1353 (GetAssemblyName): Ouch next bug there.
1355 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
1357 * expression.cs: Error 275 added.
1359 2004-11-23 Marek Safar <marek.safar@seznam.cz>
1361 Fix bug #69177 (Implemented decimal constant support)
1363 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
1364 (BinaryFold): Add DecimalConstant.
1366 * const.cs (Define): Decimal constant
1368 (ChangeType): Add decimal type handling.
1369 (LookupConstantValue): Don't set value for decimal type but
1370 emit DecimalConstantAttribute. Needed for constant optimization.
1372 * constant.cs (ToDecimal): New method.
1373 (ConvertToDecimal): New method.
1374 (IntConstant): Implemented ConvertToDecimal.
1375 (DecimalConstant.Emit): Emit optimized version for decimals in
1378 * expression.cs (ResolveOperator): Changed order of constant
1379 reduction to work correctly with native types which have
1380 overloaded operators.
1381 (ResolveMemberAccess): Extract constant value from attribute
1384 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
1386 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
1387 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
1388 (ChangeType): Decimal is special.
1389 (TypeToCoreType): Add decimal type.
1391 2004-11-22 Marek Safar <marek.safar@seznam.cz>
1393 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
1396 2004-11-22 Marek Safar <marek.safar@seznam.cz>
1398 * class.cs (EventField.ApplyAttributeBuilder): Fix error
1401 2004-11-19 Marek Safar <marek.safar@seznam.cz>
1403 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
1405 * pending.cs (PendingImplementation): Grab only interfaces.
1407 2004-11-19 Marek Safar <marek.safar@seznam.cz>
1409 * statement.cs (ForeachHelperMethods): Add location member and
1410 error 202 detection.
1412 2004-11-18 Marek Safar <marek.safar@seznam.cz>
1414 * expression.cs (DoResolveBase): Fixed wrong warning for out
1417 2004-12-04 Martin Baulig <martin@ximian.com>
1419 * convert.cs (Convert.TypeParameter_to_Null): Use the constraints
1420 to check whether the conversion is ok.
1422 * typemanager.cs (TypeManager.GetTypeArguments): Just return
1423 `Type.EmptyTypes' if we're not a generic TypeContainer.
1425 2004-11-25 Miguel de Icaza <miguel@ximian.com>
1427 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
1428 old bug: when converting from the null literal to a pointer,
1429 return an EmptyCast, not the NullLiteral.
1431 This fixes #69921, the recent null_type changes probably made this
1434 2004-12-03 Martin Baulig <martin@ximian.com>
1436 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
1437 method as our child, call AnonymousMethod.Compatible() on it.
1439 2004-12-02 Miguel de Icaza <miguel@ximian.com>
1441 * class.cs (FieldBase): Use an unused bit field from the field to
1442 encode the `has_offset' property from the FieldMember. This saves
1443 a couple of Ks on bootstrap compilation.
1445 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
1446 method as our child, return the AnonymousMethod resolved
1449 * expression.cs (New.DoResolve): Allow return values from
1450 NewDelegate to also include AnonymousMethods.
1454 2004-11-29 Raja R Harinath <rharinath@novell.com>
1456 * decl.cs (MemberCore.MemberName): Remove readonly to fix an error
1458 * rootcontext.cs (ResolveCore::interfaces_first_stage): Add
1459 System.Runtime.InteropServices._Exception, since it's a base
1460 interface of the core type System.Exception in the net_2_0 profile.
1462 2004-11-27 Martin Baulig <martin@ximian.com>
1464 * ecore.cs (Expression.StoreFromPtr): Use `stobj' for generic parameters.
1466 2004-11-26 Raja R Harinath <rharinath@novell.com>
1468 * Makefile: Convert to use executable.make.
1469 * gmcs.exe.sources: New.
1471 2004-11-25 Martin Baulig <martin@ximian.com>
1473 * expression.cs (Invocation.InferType): Added support for byref types.
1475 2004-11-25 Martin Baulig <martin@ximian.com>
1477 * statement.cs (Foreach.FetchMethodMoveNext): Wrap `mi.ReturnType'
1478 in TypeManager.TypeToCoreType().
1480 2004-11-25 Martin Baulig <martin@ximian.com>
1482 * iterators.cs (Iterator.DoDefineMembers): Override and lookup the
1483 "Dispose" method from the `current_type'.
1484 (Iterator.EmitMoveNext): Use the `dispose_method' we looked up in
1485 DoDefineMembers() instead of using the MethodBuilder; this is
1486 required for generic iterators.
1488 * class.cs (TypeContainer.DoDefineMembers): Make this virtual.
1490 2004-11-24 Martin Baulig <martin@ximian.com>
1492 * ecore.cs (Expression.LoadFromPtr): Use `ldobj' for generic parameters.
1494 2004-11-20 Martin Baulig <martin@ximian.com>
1496 * expression.cs (Invocation.InferType): Correctly infer generic
1497 instances; see gen-103.cs.
1498 (Invocation.InferTypeArguments): If a generic method doesn't have
1499 any unbound type parameters, we don't need to infer anything.
1501 2004-11-19 Raja R Harinath <rharinath@novell.com>
1503 * Makefile (gmcs.exe): Update to new location of bootstrap mcs.exe.
1505 2004-11-17 Raja R Harinath <rharinath@novell.com>
1507 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
1508 (TypeHandle.GetMemberCache): New.
1509 (TypeHandle.TypeHandle): Update.
1510 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
1511 (TypeManager.LookupParentInterfacesCache):
1512 Rename from LookupInterfaceCache. Optimize slightly.
1513 (TypeManager.MemberLookup_FindMembers): Update.
1514 * decl.cs (MemberCache.MemberCache): Set Container to null in the
1516 (AddCacheContents): Rename from AddHashtable.
1517 * class.cs (TypeContainer.parent_container): Remove.
1518 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
1519 (TypeContainer.DoDefineMembers): Don't initialize it.
1520 Update to name changes.
1522 2004-11-17 Miguel de Icaza <miguel@ximian.com>
1524 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
1525 that factors the code to check access modifiers on override.
1527 (PropertyBase): Use the code here.
1529 Patch from Lluis S'anchez, fixes bug #69361.
1531 2004-11-15 Miguel de Icaza <miguel@ximian.com>
1533 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
1534 routine that is used to report the use of a captured variable
1535 whose address has been taken.
1537 There are two checks: one when variables are being captured and
1538 the other check is when the address of a variable is taken.
1540 (because an anonymous methods might be resolved before *or* after
1541 the address has been taken) and
1543 * expression.cs (Conditional.DoResolve): Remove the special
1544 casing that Martin added to trueExpr and falseExpr being both
1545 NullLiteral. We get the right behavior now just by introducing
1546 the null_type into the compiler.
1548 * convert.cs (ExplicitConversion): Change the code to use
1549 null_type instead of testing `expr is NullLiteral'.
1550 (ImplicitConversionStandard): use null_type too.
1551 (ImplicitReferenceConversionExists): use null_type too.
1552 (ImplicitReferenceConversion): use null_type too.
1554 * literal.cs: The type of `NullLiteral' is now null_type instead
1556 (Resolve): Set the type here.
1558 * typemanager.cs: Introduce null_type.
1560 2004-11-18 Martin Baulig <martin@ximian.com>
1563 (RootContext.LookupType): Return a `Type', not a `TypeExpr'.
1565 2004-11-18 Martin Baulig <martin@ximian.com>
1567 * ecore.cs (TypeExpr.DoResolveAsTypeStep): Make this protected.
1569 2004-11-18 Martin Baulig <martin@ximian.com>
1571 * generic.cs (Constraints.Resolve): Take an `EmitContext' instead
1572 of a `DeclSpace'. If one of our constraints is a `ConstructedType',
1573 call ResolveConstructedType() on it to resolve it without checking
1575 (Constraints.ResolveTypes): Check them here.
1576 (ConstructedType.DoResolveAsTypeStep): Fully resolve ourselves,
1577 but don't check constraints.
1578 (ConstructedType.ResolveAsTypeTerminal): Override this and also
1579 check constraints here.
1580 (ConstructedType.ResolveConstructedType): New public method. This
1581 is called from DoResolveAsTypeStep() and Constraints.Resolve() to
1582 resolve ourselves without checking constraints.
1584 * ecore.cs (Expression.ResolveAsTypeTerminal): Make this virtual.
1586 2004-11-18 Martin Baulig <martin@ximian.com>
1589 (DeclSpace.CurrentType): Changed type from `TypeExpr' to `Type'.
1591 * delegate.cs (Delegate.DefineType): Always create the EmitContext.
1593 2004-11-18 Martin Baulig <martin@ximian.com>
1595 * ecore.cs (TypeExpr.ResolveType): Removed.
1596 (Expression.ResolveAsTypeTerminal): We always return a fully
1597 resolved `TypeExpr', so we can just access its `Type'.
1599 * class.cs (TypeContainer.DefineType): Resolve `CurrentType' here.
1601 2004-11-17 Martin Baulig <martin@ximian.com>
1603 * ecore.cs (IAlias.Type): Replaced with ResolveAsType() to make
1604 sure we don't return any unresolved TypeExpr's.
1605 (TypeAliasExpression): The .ctor now takes an `IAlias' instead of
1607 (Expression.ResolveAsTypeTerminal): Make sure `te.Type != null'.
1609 * expression.cs (MemberAccess.ResolveAsTypeStep): Don't return any
1610 unresolved `ConstructedType's.
1612 2004-11-17 Martin Baulig <martin@ximian.com>
1614 * ecore.cs (TypeExpr.ResolveType): Don't make this virtual.
1616 2004-11-17 Martin Baulig <martin@ximian.com>
1619 (Expression.ResolveAsTypeTerminal): Removed the `bool silent' argument.
1621 * decl.cs (DeclSpace.ResolveType): Removed.
1622 (DeclSpace.ResolveTypeExpr): Removed the `bool silent' argument.
1624 2004-11-17 Martin Baulig <martin@ximian.com>
1626 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
1627 direction, like FindMembers() does. Fixes #69546, testcase is in
1630 2004-11-16 Martin Baulig <martin@ximian.com>
1632 This is based on a patch from Marek Safar, see bug #69082.
1633 Fixes bugs #63705 and #67130.
1635 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
1636 method; create a MemberCache for an interface type and cache the
1639 * decl.cs (IMemberContainer.ParentContainer): Removed.
1640 (IMemberContainer.ParentCache): New property.
1641 (MemberCache.SetupCacheForInterface): Removed.
1642 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
1643 to create a cache for an interface's "parent".
1645 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
1648 2004-11-14 Ben Maurer <bmaurer@ximian.com>
1650 * statement.cs: Avoid adding bools to a hashtable.
1652 2004-11-15 Martin Baulig <martin@ximian.com>
1654 * decl.cs (MemberName.GetPartialName): Removed, use GetTypeName() instead.
1656 2004-11-11 Martin Baulig <martin@ximian.com>
1658 * typemanager.cs (TypeManager.GetMethodName): New method.
1660 * class.cs (MethodData.Define): Include the generic arity in the
1661 name of an explicit interface; also add it to the method name.
1663 * pending.cs (PendingImplementation.InterfaceMethod): The method
1664 name now includes the generic arity.
1666 2004-11-07 Miguel de Icaza <miguel@ximian.com>
1668 * expression.cs (Invocation.OverloadResolve): Flag error if we are
1669 calling an unsafe method from a safe location.
1671 2004-11-06 Marek Safar <marek.safar@seznam.cz>
1674 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
1676 2004-11-06 Miguel de Icaza <miguel@ximian.com>
1678 * namespace.cs (VerifyUsing): use GetPartialName instead of
1681 2004-11-05 Miguel de Icaza <miguel@ximian.com>
1683 * statement.cs (Return.Resolve): Fix regression in typo: if
1684 `in_exc', we have to request a NeedReturnLabel, this was a typo
1685 introduced in the anonymous method check-in. Fixes #69131.
1687 * Indexers were using the ShortName when defining themselves,
1688 causing a regression in the compiler bootstrap when applying the
1689 patch from 2004-11-02 (first part), now they use their full name
1690 and the bug is gone.
1692 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
1694 * driver.cs: Strip the path from the names of embedded resources. Fixes
1697 2004-11-04 Raja R Harinath <rharinath@novell.com>
1699 Fix error message regression: cs0104-2.cs.
1700 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
1701 (AliasEntry.Resolve): Update.
1702 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
1704 (RootContext.LookupType): Update.
1706 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
1708 * cs-parser.jay: Add support for handling accessor modifiers
1709 * class: Add support port accessor modifiers and error checking,
1710 define PropertyMethod.Define as virtual (not abstract anymore)
1711 * ecore.cs: Add checking for proeprties access with access modifiers
1712 * iterators.cs: Modify Accessor constructor call based in the modified
1714 2004-11-02 Ben Maurer <bmaurer@ximian.com>
1716 * expression.cs (StringConcat): Handle being called twice,
1717 as when we have a concat in a field init with more than two
1720 2004-11-02 Miguel de Icaza <miguel@ximian.com>
1722 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
1723 special case explicit implementations, we should always produce
1724 the .property or .event declaration.
1726 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
1727 since it will not return correct data if people use this
1728 unresolved in the presence of using statements (see test-313).
1730 * class.cs (MethodData.Define): If we are an explicit interface
1731 implementation, set the method name to the full name of the
1732 interface plus the name of the method.
1734 Notice that using the method.MethodName.GetFullName() does not
1735 work, as it will only contain the name as declared on the source
1736 file (it can be a shorthand in the presence of using statements)
1737 and not the fully qualifed type name, for example:
1741 class D : ICloneable {
1742 object ICloneable.Clone () {
1746 Would produce a method called `ICloneable.Clone' instead of
1747 `System.ICloneable.Clone'.
1749 * namespace.cs (Alias.Resolve): Use GetPartialName.
1751 2004-11-01 Marek Safar <marek.safar@seznam.cz>
1753 * cs-parser.jay: Add error 1055 report.
1755 2004-11-01 Miguel de Icaza <miguel@ximian.com>
1757 * assign.cs (Assign.DoResolve): Only do the transform of
1758 assignment into a New if the types are compatible, if not, fall
1759 through and let the implicit code deal with the errors and with
1760 the necessary conversions.
1762 2004-11-01 Marek Safar <marek.safar@seznam.cz>
1764 * cs-parser.jay: Add error 1031 report.
1766 * cs-tokenizer.cs: Add location for error 1038.
1768 2004-10-31 Marek Safar <marek.safar@seznam.cz>
1770 * cs-parser.jay: Add error 1016 report.
1772 2004-10-31 Marek Safar <marek.safar@seznam.cz>
1774 * cs-parser.jay: Add errors 1575,1611 report.
1776 2004-10-31 Marek Safar <marek.safar@seznam.cz>
1778 * cs-parser.jay: Add error 1001 report.
1780 2004-10-31 Marek Safar <marek.safar@seznam.cz>
1783 * attribute.cs (GetMarshal): Add method argument for
1784 caller identification.
1786 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
1787 agument for GetMarshal and RuntimeMissingSupport.
1789 2004-10-31 Marek Safar <marek.safar@seznam.cz>
1791 * attribute.cs (ExtractSecurityPermissionSet): Removed
1792 TypeManager.code_access_permission_type.
1794 * typemanager.cs: Removed TypeManager.code_access_permission_type.
1796 2004-10-27 Miguel de Icaza <miguel@ximian.com>
1798 * expression.cs (LocalVariableReference.DoResolveLValue): Check
1799 for obsolete use of a variable here. Fixes regression on errors
1800 cs0619-25 and cs0619-26.
1802 2004-10-27 Marek Safar <marek.safar@seznam.cz>
1804 Fix #62358, implemented security attribute encoding.
1806 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
1807 Tests permitted SecurityAction for assembly or other types.
1808 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
1809 data from SecurityPermissionAttribute to PermisionSet class.
1811 * class.cs (ApplyAttributeBuilder): Added special handling
1812 for System.Security.Permissions.SecurityAttribute based types.
1814 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
1815 special handling for System.Security.Permissions.SecurityAttribute
1818 * enum.cs (ApplyAttributeBuilder): Added special handling
1819 for System.Security.Permissions.SecurityAttribute based types.
1821 * parameter.cs (ApplyAttributeBuilder): Added special handling
1822 for System.Security.Permissions.SecurityAttribute based types.
1824 * rootcontext.cs: Next 2 core types.
1826 * typemanager.cs (TypeManager.security_permission_attr_type):
1827 Built in type for the SecurityPermission Attribute.
1828 (code_access_permission_type): Build in type.
1830 2004-10-17 Miguel de Icaza <miguel@ximian.com>
1832 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
1833 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
1834 all of this information into
1835 EmitContext.EmitCapturedVariableInstance.
1837 * codegen.cs (EmitCapturedVariableInstance): move here the
1838 funcionality of emitting an ldarg.0 in the presence of a
1839 remapping. This centralizes the instance emit code.
1841 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
1842 then emit a load of this: it means that we have reached the
1843 topmost ScopeInfo: the one that contains the pointer to the
1844 instance of the class hosting the anonymous method.
1846 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
1847 captures to the topmost CaptureContext.
1849 2004-10-12 Miguel de Icaza <miguel@ximian.com>
1851 * expression.cs (LocalVariableReference): Move the knowledge about
1852 the iterators into codegen's EmitCapturedVariableInstance.
1854 2004-10-11 Miguel de Icaza <miguel@ximian.com>
1856 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
1857 all code paths return a value from an anonymous method (it is the
1858 same as the 161 error, but for anonymous methods).
1860 2004-10-08 Miguel de Icaza <miguel@ximian.com>
1862 The introduction of anonymous methods in the compiler changed
1863 various ways of doing things in the compiler. The most
1864 significant one is the hard split between the resolution phase
1865 and the emission phases of the compiler.
1867 For instance, routines that referenced local variables no
1868 longer can safely create temporary variables during the
1869 resolution phase: they must do so from the emission phase,
1870 since the variable might have been "captured", hence access to
1871 it can not be done with the local-variable operations from the runtime.
1875 (Block.Flags): New flag `IsTopLevel' to indicate that this block
1876 is a toplevel block.
1878 (ToplevelBlock): A new kind of Block, these are the blocks that
1879 are created by the parser for all toplevel method bodies. These
1880 include methods, accessors and anonymous methods.
1882 These contain some extra information not found in regular blocks:
1883 A pointer to an optional CaptureContext (for tracking captured
1884 local variables and parameters). A pointer to the parent
1887 (Return.Resolve): Catch missmatches when returning a value from an
1888 anonymous method (error 1662).
1889 Invoke NeedReturnLabel from the Resolve phase instead of the emit
1892 (Break.Resolve): ditto.
1894 (SwitchLabel): instead of defining the labels during the
1895 resolution phase, we now turned the public ILLabel and ILLabelCode
1896 labels into methods called GetILLabelCode() and GetILLabel() that
1897 only define the label during the Emit phase.
1899 (GotoCase): Track the SwitchLabel instead of the computed label
1900 (its contained therein). Emit the code by using
1901 SwitchLabel.GetILLabelCode ().
1903 (LocalInfo.Flags.Captured): A new flag has been introduce to track
1904 whether the Local has been captured or not.
1906 (LocalInfo.IsCaptured): New property, used to tell whether the
1907 local has been captured.
1909 * anonymous.cs: Vastly updated to contain the anonymous method
1912 The main classes here are: CaptureContext which tracks any
1913 captured information for a toplevel block and ScopeInfo used to
1914 track the activation frames for various local variables.
1916 Each toplevel block has an optional capture context associated
1917 with it. When a method contains an anonymous method both the
1918 toplevel method and the anonymous method will create a capture
1919 context. When variables or parameters are captured, they are
1920 recorded on the CaptureContext that owns them, for example:
1924 MyDelegate d = delegate {
1929 Here `a' will be recorded as captured on the toplevel
1930 CapturedContext, the inner captured context will not have anything
1931 (it will only have data if local variables or parameters from it
1932 are captured in a nested anonymous method.
1934 The ScopeInfo is used to track the activation frames for local
1935 variables, for example:
1937 for (int i = 0; i < 10; i++)
1938 for (int j = 0; j < 10; j++){
1939 MyDelegate d = delegate {
1944 At runtime this captures a single captured variable `i', but it
1945 captures 10 different versions of the variable `j'. The variable
1946 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
1947 recorded on a child.
1949 The toplevel ScopeInfo will also track information like the `this'
1950 pointer if instance variables were referenced (this is necessary
1951 as the anonymous method lives inside a nested class in the host
1952 type of the method).
1954 (AnonymousMethod): Expanded to track the Toplevel, implement
1955 `AnonymousMethod.Compatible' to tell whether an anonymous method
1956 can be converted to a target delegate type.
1958 The routine now also produces the anonymous method content
1960 (AnonymousDelegate): A helper class that derives from
1961 DelegateCreation, this is used to generate the code necessary to
1962 produce the delegate for the anonymous method that was created.
1964 * assign.cs: API adjustments for new changes in
1965 Convert.ImplicitStandardConversionExists.
1967 * class.cs: Adjustments to cope with the fact that now toplevel
1968 blocks are of type `ToplevelBlock'.
1970 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
1971 insteda of standard blocks.
1973 Flag errors if params arguments are passed to anonymous methods.
1975 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
1976 `CurrentAnonymousMethod' which points to the current Anonymous
1977 Method. The variable points to the AnonymousMethod class that
1978 holds the code being compiled. It is set in the new EmitContext
1979 created for the anonymous method.
1981 (EmitContext.Phase): Introduce a variable and an enumeration to
1982 assist in enforcing some rules about when and where we are allowed
1983 to invoke certain methods (EmitContext.NeedsReturnLabel is the
1984 only one that enfonces this right now).
1986 (EmitContext.HaveCaptureInfo): new helper method that returns
1987 whether we have a CapturedContext initialized.
1989 (EmitContext.CaptureVariable): New method used to register that a
1990 LocalInfo must be flagged for capturing.
1992 (EmitContext.CapturedParameter): New method used to register that a
1993 parameters must be flagged for capturing.
1995 (EmitContext.CapturedField): New method used to register that a
1996 field must be flagged for capturing.
1998 (EmitContext.HaveCapturedVariables,
1999 EmitContext.HaveCapturedFields): Return whether there are captured
2000 variables or fields.
2002 (EmitContext.EmitMethodHostInstance): This is used to emit the
2003 instance for the anonymous method. The instance might be null
2004 (static methods), this (for anonymous methods that capture nothing
2005 and happen to live side-by-side with the current method body) or a
2006 more complicated expression if the method has a CaptureContext.
2008 (EmitContext.EmitTopBlock): Routine that drives the emission of
2009 code: it will first resolve the top block, then emit any metadata
2010 and then emit the code. The split is done so that we can extract
2011 any anonymous methods and flag any captured variables/parameters.
2013 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
2014 during this phase, the ILGenerator should not be used as labels
2015 and local variables declared here might not be accessible to any
2016 code that is part of an anonymous method.
2018 Exceptions to this include the temporary variables that are
2019 created by some statements internally for holding temporary
2022 (EmitContext.EmitMeta): New routine, in charge of emitting all the
2025 (EmitContext.TemporaryReturn): This method is typically called
2026 from the Emit phase, and its the only place where we allow the
2027 ReturnLabel to be defined other than the EmitMeta. The reason is
2028 that otherwise we would have to duplicate a lot of logic in the
2029 Resolve phases of various methods that today is on the Emit
2032 (EmitContext.NeedReturnLabel): This no longer creates the label,
2033 as the ILGenerator is not valid during the resolve phase.
2035 (EmitContext.EmitThis): Extended the knowledge in this class to
2036 work in anonymous methods in addition to iterators.
2038 (EmitContext.EmitCapturedVariableInstance): This emits whatever
2039 code is necessary on the stack to access the instance to a local
2040 variable (the variable will be accessed as a field).
2042 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
2043 EmitContext.EmitAddressOfParameter): Routines to support
2044 parameters (not completed at this point).
2046 Removals: Removed RemapLocal and RemapLocalLValue. We probably
2047 will also remove the parameters.
2049 * convert.cs (Convert): Define a `ConstantEC' which points to a
2050 null. This is just to prefity some code that uses
2051 ImplicitStandardConversion code and do not have an EmitContext
2054 The idea is to flag explicitly that at that point in time, it is
2055 known that the conversion will not trigger the delegate checking
2056 code in implicit conversions (which requires a valid
2059 Everywhere: pass new EmitContext parameter since
2060 ImplicitStandardConversionExists now requires it to check for
2061 anonymous method conversions.
2063 (Convert.ImplicitStandardConversionExists): If the type of an
2064 expression is the anonymous_method_type, and the type is a
2065 delegate, we invoke the AnonymousMethod.Compatible method to check
2066 whether an implicit conversion is possible.
2068 (Convert.ImplicitConversionStandard): Only do implicit method
2069 group conversions if the language level is not ISO_1.
2071 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
2072 MethodInfo for the Invoke method. used by Delegate and
2075 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
2076 method conversions if the target type is a delegate.
2078 Removed extra debugging nops.
2080 (LocalVariableReference): Turn the `local_info' into a public
2083 Add `prepared' field, the same hack used for FieldExprs to cope
2084 with composed assignments, as Local variables do not necessarily
2085 operate purely on the stack as they used to: they can be captured
2088 Add `temp' for a temporary result, like fields.
2090 Refactor DoResolve and DoResolveLValue into DoResolveBase.
2092 It now copes with Local variables that are captured and emits the
2093 proper instance variable to load it from a field in the captured
2096 (ParameterReference.DoResolveBase): During the resolve phase,
2097 capture parameters if we are in an anonymous method.
2099 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
2100 anonymous method, use the EmitContext helper routines to emit the
2101 parameter reference.
2103 * iterators.cs: Set RemapToProxy to true/false during the
2106 * parameters.cs (GetParameterByName): New helper method.
2108 * typemanager.cs (anonymous_method_type) a new type that
2109 represents an anonyous method. This is always an internal type,
2110 used as a fencepost to test against the anonymous-methodness of an
2113 2004-10-20 Marek Safar <marek.safar@seznam.cz>
2115 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
2117 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
2119 2004-11-10 Martin Baulig <martin@ximian.com>
2121 * expression.cs (Invocation.BetterFunction): If two methods have
2122 equal parameter types, but only one of them is generic, the
2123 non-generic one wins.
2124 (New.DoResolve): Don't set `is_struct' to false if we're a generic
2125 instance; just use `Type.IsValueType' to determine whether
2126 something is a struct or not.
2127 (MemberAccess.DoResolveAsTypeStep): Don't modify the `args' field,
2128 so we can be called multiple times.
2130 2004-11-10 Martin Baulig <martin@ximian.com>
2132 * generic.cs (TypeParameter.DefineConstraints): New public method.
2133 (TypeParameter.CheckAccessLevel): Override this and return true.
2134 (ConstructedType.ResolveType): Renamed to DoResolveType(), don't
2135 override ResolveType() anymore.
2136 (ConstructedType.DoResolveAsTypeStep): Call DoResolveType() here.
2138 2004-11-10 Martin Baulig <martin@ximian.com>
2140 * rootcontext.cs (RootContext.LookupType): If we're a nested type,
2141 call DeclSpace.ResolveNestedType() on it.
2143 2004-11-10 Martin Baulig <martin@ximian.com>
2145 * support.cs (ReflectionParameters.ParameterModifier): If `gpd' is
2146 non-null, call ParameterModifier() on it.
2148 2004-11-10 Martin Baulig <martin@ximian.com>
2151 (Iterators): Added `current_type' and `this_type' fields.
2152 (Iterators.DefineIterator): Create a new EmitContext and store it
2153 in `ec'; compute `this_type'.
2155 2004-11-10 Martin Baulig <martin@ximian.com>
2158 (TypeManager.IsPrivateAccessible): New public method.
2159 (Closure.Filter): Use IsPrivateAccessible() instead of IsEqual().
2161 2004-11-10 Martin Baulig <martin@ximian.com>
2163 * class.cs (TypeContainer.DefineType): Call
2164 TypeBuilder.DefineGenericParameters() before resolving the type
2166 (MethodData.parent_method): New protected field.
2167 (MethodData..ctor): Added `MethodInfo parent_method' argument.
2168 (MethodData.Define): Compute `parent_method'.
2171 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
2172 (MemberCore.GetClsCompliantAttributeValue): Likewise.
2173 (DeclSpace.ec): New protected field; store the EmitContext here.
2174 (DeclSpace.EmitContext): New public property.
2175 (DeclSpace.ResolveType): Un-comment from the [Obsolte] attribute.
2176 (DeclSpace.ResolveNestedType): New public method.
2177 (DeclSpace.ResolveTypeExpr): Just call ResolveAsTypeTerminal() here.
2178 (DeclSpace.NestedAccessible): Added `Type tb' argument.
2179 (DeclSpace.FamilyAccessible): Likewise.
2180 (DeclSpace.FindType): Call ResolveNestedType() for nested types.
2181 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
2184 * delegate.cs (Delegate.Define): Store the EmitContext in the `ec'
2187 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
2188 (Enum.Emit): Don't create a new EmitContext.
2190 2004-10-18 Martin Baulig <martin@ximian.com>
2192 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
2193 `Type' directly, but call ResolveType() on it.
2194 (Catch.Resolve): Likewise.
2195 (Foreach.Resolve): Likewise.
2197 2004-10-18 Martin Baulig <martin@ximian.com>
2199 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
2200 `Type' directly, but call ResolveType() on it.
2201 (Probe.DoResolve): Likewise.
2202 (ArrayCreation.LookupType): Likewise.
2203 (TypeOf.DoResolve): Likewise.
2204 (SizeOf.DoResolve): Likewise.
2206 2004-10-18 Raja R Harinath <rharinath@novell.com>
2208 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
2211 2004-10-17 John Luke <john.luke@gmail.com>
2213 * class.cs (Operator.GetSignatureForError): use CSharpName
2215 * parameter.cs (Parameter.GetSignatureForError): Returns
2216 correct name even if was not defined.
2218 2004-10-13 Raja R Harinath <rharinath@novell.com>
2221 * class.cs (TypeContainer.EmitContext): New property.
2222 (DefineNestedTypes): Create an emitcontext for each part.
2223 (MethodCore.DoDefineParameters): Use container's emitcontext.
2224 Pass type array to InternalParameters.
2225 (MemberBase.DoDefine): Use container's emitcontext.
2226 (FieldMember.Define): Likewise.
2227 (Event.Define): Likewise.
2228 (SetMethod.GetParameterInfo): Change argument to EmitContext.
2229 Pass type array to InternalParameters.
2230 (SetIndexerMethod.GetParameterInfo): Likewise.
2231 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
2232 * delegate.cs (Define): Pass emitcontext to
2233 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
2234 array to InternalParameters.
2235 * expression.cs (ParameterReference.DoResolveBase): Pass
2236 emitcontext to GetParameterInfo.
2237 (ComposedCast.DoResolveAsTypeStep): Remove check on
2238 ec.ResolvingTypeTree.
2239 * parameter.cs (Parameter.Resolve): Change argument to
2240 EmitContext. Use ResolveAsTypeTerminal.
2241 (Parameter.GetSignature): Change argument to EmitContext.
2242 (Parameters.ComputeSignature): Likewise.
2243 (Parameters.ComputeParameterTypes): Likewise.
2244 (Parameters.GetParameterInfo): Likewise.
2245 (Parameters.ComputeAndDefineParameterTypes): Likewise.
2246 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
2247 * support.cs (InternalParameters..ctor): Remove variant that takes
2249 * typemanager.cs (system_intptr_expr): New.
2250 (InitExpressionTypes): Initialize it.
2252 2004-10-12 Chris Toshok <toshok@ximian.com>
2254 * cs-parser.jay: fix location for try_statement and catch_clause.
2256 2004-10-18 Martin Baulig <martin@ximian.com>
2258 * class.cs (FieldMember.Define): Don't access the TypeExpr's
2259 `Type' directly, but call ResolveType() on it.
2260 (MemberBase.DoDefine): Likewise.
2262 * expression.cs (New.DoResolve): Don't access the TypeExpr's
2263 `Type' directly, but call ResolveType() on it.
2264 (ComposedCast.DoResolveAsTypeStep): Likewise.
2266 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
2267 `Type' directly, but call ResolveType() on it.
2269 2004-10-17 John Luke <john.luke@gmail.com>
2271 * class.cs (Operator.GetSignatureForError): use CSharpName
2273 * parameter.cs (Parameter.GetSignatureForError): Returns
2274 correct name even if was not defined.
2276 2004-10-13 Raja R Harinath <rharinath@novell.com>
2279 * class.cs (TypeContainer.EmitContext): New property.
2280 (DefineNestedTypes): Create an emitcontext for each part.
2281 (MethodCore.DoDefineParameters): Use container's emitcontext.
2282 Pass type array to InternalParameters.
2283 (MemberBase.DoDefine): Use container's emitcontext.
2284 (FieldMember.Define): Likewise.
2285 (Event.Define): Likewise.
2286 (SetMethod.GetParameterInfo): Change argument to EmitContext.
2287 Pass type array to InternalParameters.
2288 (SetIndexerMethod.GetParameterInfo): Likewise.
2289 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
2290 * delegate.cs (Define): Pass emitcontext to
2291 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
2292 array to InternalParameters.
2293 * expression.cs (ParameterReference.DoResolveBase): Pass
2294 emitcontext to GetParameterInfo.
2295 (ComposedCast.DoResolveAsTypeStep): Remove check on
2296 ec.ResolvingTypeTree.
2297 * parameter.cs (Parameter.Resolve): Change argument to
2298 EmitContext. Use ResolveAsTypeTerminal.
2299 (Parameter.GetSignature): Change argument to EmitContext.
2300 (Parameters.ComputeSignature): Likewise.
2301 (Parameters.ComputeParameterTypes): Likewise.
2302 (Parameters.GetParameterInfo): Likewise.
2303 (Parameters.ComputeAndDefineParameterTypes): Likewise.
2304 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
2305 * support.cs (InternalParameters..ctor): Remove variant that takes
2307 * typemanager.cs (system_intptr_expr): New.
2308 (InitExpressionTypes): Initialize it.
2310 2004-10-12 Chris Toshok <toshok@ximian.com>
2312 * cs-parser.jay: fix location for try_statement and catch_clause.
2314 2004-10-07 Raja R Harinath <rharinath@novell.com>
2316 More DeclSpace.ResolveType avoidance.
2317 * decl.cs (MemberCore.InUnsafe): New property.
2318 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
2319 with newly created EmitContext.
2320 (FieldMember.Define): Likewise.
2321 * delegate.cs (Delegate.Define): Likewise.
2322 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
2323 only if normal name-lookup fails.
2324 (TypeExpr.DoResolve): Enable error-checking.
2325 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
2326 (SizeOf.DoResolve): Likewise.
2327 (ComposedCast.DoResolveAsTypeStep): Likewise.
2328 (StackAlloc.DoResolve): Likewise.
2329 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
2330 (Block.Unsafe): New property.
2331 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
2332 (Unsafe): Set 'unsafe' flag of contained block.
2333 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
2334 (Fixed.Resolve): Likewise.
2335 (Catch.Resolve): Likewise.
2336 (Using.ResolveLocalVariableDecls): Likewise.
2337 (Foreach.Resolve): Likewise.
2339 2004-10-05 John Luke <john.luke@gmail.com>
2341 * cs-parser.jay: add location to error CS0175
2343 2004-10-04 Miguel de Icaza <miguel@ximian.com>
2345 * ecore.cs (Expression.Constantity): Add support for turning null
2348 * const.cs (Const.Define): Allow constants to be reference types
2349 as long as the value is Null.
2351 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
2353 * namespace.cs (NamespaceEntry.Using): No matter which warning
2354 level is set, check if this namespace name has already been added.
2356 2004-10-03 Ben Maurer <bmaurer@ximian.com>
2358 * expression.cs: reftype [!=]= null should always use br[true,false].
2361 2004-10-03 Marek Safar <marek.safar@seznam.cz>
2364 * attribute.cs: Enum conversion moved to
2365 GetAttributeArgumentExpression to be applied to the all
2368 2004-10-01 Raja R Harinath <rharinath@novell.com>
2370 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
2371 * class.c (TypeContainer.DefineType): Flag error if
2372 base types aren't accessible due to access permissions.
2373 * decl.cs (DeclSpace.ResolveType): Move logic to
2374 Expression.ResolveAsTypeTerminal.
2375 (DeclSpace.ResolveTypeExpr): Thin layer over
2376 Expression.ResolveAsTypeTerminal.
2377 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
2378 Refactor code into NestedAccess. Use it.
2379 (DeclSpace.NestedAccess): New.
2380 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
2381 argument to silence errors. Check access permissions.
2382 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
2383 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
2384 (Cast.DoResolve): Likewise.
2385 (New.DoResolve): Likewise.
2386 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
2387 (TypeOf.DoResolve): Likewise.
2389 * expression.cs (Invocation.BetterConversion): Return the Type of
2390 the better conversion. Implement section 14.4.2.3 more faithfully.
2391 (Invocation.BetterFunction): Make boolean. Make correspondence to
2392 section 14.4.2.2 explicit.
2393 (Invocation.OverloadResolve): Update.
2394 (Invocation): Remove is_base field.
2395 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
2396 (Invocation.Emit): Likewise.
2398 2004-09-24 Marek Safar <marek.safar@seznam.cz>
2400 * cs-parser.jay: Reverted 642 warning fix.
2402 2004-09-23 Marek Safar <marek.safar@seznam.cz>
2405 * decl.cs (FindMemberWithSameName): Indexer can have more than
2408 2004-09-23 Marek Safar <marek.safar@seznam.cz>
2410 * expression.cs (LocalVariableReference.DoResolveLValue):
2411 Do not report warning 219 for out values.
2412 (EmptyExpression.Null): New member to avoid extra allocations.
2414 2004-09-23 Marek Safar <marek.safar@seznam.cz>
2416 * cs-parser.jay: Fix wrong warning 642 report.
2418 * cs-tokenizer.cs (CheckNextToken): New helper;
2419 Inspect next character if is same as expected.
2421 2004-09-23 Martin Baulig <martin@ximian.com>
2423 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
2424 (Convert.ImplicitReferenceConversionExists): Likewise.
2426 2004-11-09 Raja R Harinath <rharinath@novell.com>
2428 * Makefile (DISTFILES): Comment out a few missing files.
2430 2004-10-29 Raja R Harinath <rharinath@novell.com>
2432 * Makefile (bootstrap_libs,bootstrap_libfiles): New.
2433 (bootstrap-libs): New target. Invokes the net_2_0_bootstrap profile.
2434 (gmcs.exe): Invoke bootstrap-libs.
2435 (clean-local): Clean the net_2_0_bootstrap profile too.
2436 (PROGRAM_INSTALL_DIR): New.
2437 (install-local): Use it.
2439 2004-10-13 Martin Baulig <martin@ximian.com>
2441 * generic.cs (TypeManager.InflatedConstraints): New nested class.
2442 (TypeParameter.DefineType): If we're a method type parameter and
2443 that method is overriding something, "inflate" its constraints.
2445 2004-10-12 Martin Baulig <martin@ximian.com>
2447 * expression.cs (MemberAccess.DoResolve): If we're a SimpleName
2448 and have type arguments, create and resolve a ConstructedType.
2450 2004-10-12 Martin Baulig <martin@ximian.com>
2452 * decl.cs (MemberCache.FindMemberToOverride): Use
2453 TypeManager.IsEqual() to compare the parameters and Type.Equals()
2454 to compare the invocationType.
2456 * typemanager.cs (TypeManager.IsEqual): Added support for arrays.
2457 When comparing two type parameters, only do the signature-only
2458 comparision for method type parameters.
2460 2004-10-11 Martin Baulig <martin@ximian.com>
2462 * report.cs: Don't make --fatal abort on warnings, we have
2463 -warnaserror for that.
2465 2004-10-11 Martin Baulig <martin@ximian.com>
2468 (TypeManager.IsEqualGenericType): Removed, use IsEqual() instead.
2469 (TypeManager.IsEqual): Call ourself recursively instead of using
2472 2004-10-11 Martin Baulig <martin@ximian.com>
2474 * class.cs (TypeContainer.DefineType): Only call TypeParameter.Define()
2475 on our own type parameters, not on the ones we inherit from a containing
2478 * expression.cs (Invocation.InferType): Use `==', not `Equals()' for
2481 * generic.cs (TypeParameter.Define): We may only be called once.
2483 * pending.cs (Pending.InterfaceMethod): Call TypeManager.Real_IsEqual()
2484 instead of TypeManager.IsEqual().
2486 2004-09-28 Martin Baulig <martin@ximian.com>
2489 (GenericConstraints.EffectiveBaseClass): New public property.
2490 (TypeParameter.GenericConstraints): New public property.
2491 (ConstructedType.CheckConstraints): Improved.
2493 * convert.cs (Convert.TypeParam_EffectiveBaseType): New private method.
2494 (Convert.TypeParameterConversion): New private method; use this in
2495 ImplicitReferenceConversion() and ImplicitReferenceConversionExists()
2496 for all conversions related to type parameters.
2498 2004-09-24 Martin Baulig <martin@ximian.com>
2500 * convert.cs (Convert.ImplicitReferenceConversion): Added implicit
2501 type parameter conversions for type parameters which are known to
2504 2004-09-24 Martin Baulig <martin@ximian.com>
2506 * generic.cs (GenericConstraints): Added `IsReferenceType' and
2507 `IsValueType' properties.
2509 * support.cs (ReflectionConstraints): Use
2510 Type.GetGenericParameterConstraints() instead of the old hack.
2512 2004-09-24 Martin Baulig <martin@ximian.com>
2514 * generic.cs (GenericConstraints): Moved here and made it an
2517 * support.cs (GenericConstraints): Moved to generic.cs.
2519 2004-09-24 Martin Baulig <martin@ximian.com>
2522 (ReflectionConstraints): Un-nested this class and made it public.
2525 (TypeManager.GetTypeParameterConstraints): New public method.
2526 (TypeManager.HasConstructorConstraint): Use the attributes.
2528 2004-09-24 Martin Baulig <martin@ximian.com>
2530 * support.cs (GenericConstraints): Replaced `HasConstructor',
2531 `IsReferenceType' and `IsValueType' with `Attributes'.
2532 (ReflectionParameters.ReflectionConstraints): Removed the Create()
2533 method and made the .ctor public.
2535 * generic.cs (Constraints.Attributes): New public property.
2536 (Constraints): Renamed `HasConstructor' -> `HasConstructorConstraint',
2537 `IsReferenceType' -> `HasReferenceTypeConstraint' and
2538 `IsValueType' -> `HasValueTypeConstraint'.
2540 2004-09-23 Martin Baulig <martin@ximian.com>
2542 * generic.cs (Constraints): Reflect latest runtime changes.
2544 2004-09-23 Martin Baulig <martin@ximian.com>
2546 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
2547 (Convert.ImplicitReferenceConversionExists): Likewise.
2549 2004-09-23 Marek Safar <marek.safar@seznam.cz>
2551 * class.cs (Operator.Define): Add error 448 and 559 report.
2553 2004-09-22 Marek Safar <marek.safar@seznam.cz>
2555 * class.cs (MemberBase.IsTypePermitted): New protected
2556 method for checking error CS0610.
2558 2004-09-22 Marek Safar <marek.safar@seznam.cz>
2560 * class.cs (TypeContainer.HasExplicitLayout): New property
2561 Returns whether container has StructLayout attribute set Explicit.
2562 (FieldMember): New abstract class for consts and fields.
2563 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
2564 (Field): Reuse FieldMember.
2566 * const.cs (Const): Reuse FieldMember.
2568 * rootcontext.cs: EmitConstants call moved to class.
2570 2004-09-22 Martin Baulig <martin@ximian.com>
2572 Marek and me just fixed one of our oldest bugs: #28562 :-)
2574 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
2576 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
2577 we're an EnumConstant, just return that.
2578 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
2579 an EnumConstant. In this case, we need to use GetValueAsEnumType()
2580 to get the value which'll actually be written into the attribute.
2581 However, we have to use GetValue() to access the attribute's value
2584 2004-09-22 Marek Safar <marek.safar@seznam.cz>
2586 * constant.cs (Constant.IsNegative): New abstract property
2589 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
2590 (StackAlloc.DoResolve): Reused IsNegative.
2592 2004-09-22 Martin Baulig <martin@ximian.com>
2594 * typemanager.cs (TypeManager.LookupGenericTypeContainer): New
2595 public method; like LookupTypeContainer, but also works for
2598 * report.cs (Report.SymbolRelatedToPreviousError): Use
2599 TypeManager.LookupGenericTypeContainer().
2601 2004-09-22 Martin Baulig <martin@ximian.com>
2603 Thanks to Peter Sestoft for this bug report.
2605 * expression.cs (Conditional): If both the `trueExpr' and the
2606 `falseExpr' is a NullLiteral, return a NullLiteral.
2608 2004-09-22 Martin Baulig <martin@ximian.com>
2610 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
2611 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
2612 for the "get_Current" call.
2614 2004-09-21 Martin Baulig <martin@ximian.com>
2616 * convert.cs (Convert.ImplicitReferenceConversion): When
2617 converting to an interface type, first check whether we're
2618 converting from a reference type.
2620 2004-09-14 Martin Baulig <martin@ximian.com>
2622 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
2624 2004-09-14 Marek Safar <marek.safar@seznam.cz>
2627 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
2628 called and is obsolete then this member suppress message
2629 when call is inside next [Obsolete] method or type.
2631 * expression.cs: Use TestObsoleteMethodUsage member.
2633 2004-09-14 Martin Baulig <martin@ximian.com>
2635 * genericparser.cs: Removed.
2637 2004-09-13 Marek Safar <marek.safar@seznam.cz>
2639 * class.cs (MethodCore.CheckBase): Fix bug #65757.
2641 2004-09-12 Marek Safar <marek.safar@seznam.cz>
2643 * attribute.cs (Attribute.Resolve): Add error 653 report.
2645 * class.cs (Class.ApplyAttributeBuilder): Add error 641
2647 (Method.ApplyAttributeBuilder): Add error 685 report.
2648 (Operator.Define): Add error 564 report.
2650 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
2652 * expression.cs (Invocation.DoResolve): Add error
2655 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
2658 2004-09-11 Marek Safar <marek.safar@seznam.cz>
2660 * class.cs (ConstructorInitializer.Resolve):
2661 Wrong error number (515->516).
2663 2004-09-11 Marek Safar <marek.safar@seznam.cz>
2665 * class.cs (Indexer.Define): Add error 631 report.
2667 2004-09-11 Marek Safar <marek.safar@seznam.cz>
2669 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
2671 2004-09-11 Marek Safar <marek.safar@seznam.cz>
2673 * expression.cs (Probe.DoResolve): Add error CS0241 report.
2675 2004-09-10 Marek Safar <marek.safar@seznam.cz>
2677 * cs-parser.jay: Added error CS0241 report.
2679 2004-09-10 Raja R Harinath <rharinath@novell.com>
2681 * cs-parser.jay (fixed_statement): Introduce a scope for the
2682 declaration in the 'fixed' statement.
2684 2004-09-09 Marek Safar <marek.safar@seznam.cz>
2686 * cs-parser.jay: Added CS0230 error report.
2688 2004-09-09 Marek Safar <marek.safar@seznam.cz>
2690 * cs-parser.jay: Added errors CS0231 and CS0257 report.
2692 2004-09-09 Marek Safar <marek.safar@seznam.cz>
2694 * expression.cs (Argument.Resolve): Added error CS0192 and
2697 2004-09-09 Marek Safar <marek.safar@seznam.cz>
2699 C# 2.0 #pragma warning feature
2701 * cs-tokenizer.cs (PreProcessPragma): New method;
2702 Handles #pragma directive.
2704 * report.cs (WarningRegions): New class; Support
2705 class for #pragma warning directive. It tests whether
2706 warning is enabled for a given line.
2708 2004-09-08 Miguel de Icaza <miguel@ximian.com>
2710 * const.cs: Add more descriptive error report, tahnks to
2713 2004-09-08 Marek Safar <marek.safar@seznam.cz>
2715 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
2717 2004-09-07 Miguel de Icaza <miguel@ximian.com>
2719 * expression.cs: Apply patch from Ben: Remove dead code from
2720 ArrayCreation, and remove the TurnintoConstant call in const.cs,
2721 as that code just threw an exception anwyays.
2723 * const.cs: Remove the call to the turnintoconstant, for details
2726 * literal.cs: The type of the null-literal is the null type; So
2727 we use a placeholder type (literal.cs:System.Null, defined here)
2730 * expression.cs (Conditional.DoResolve): Remove some old code that
2731 is no longer needed, conversions have been fixed.
2733 (ArrayCreationExpression.DoResolve): Return false if we fail to
2734 resolve the inner expression.
2736 2004-09-07 Raja R Harinath <rharinath@novell.com>
2739 * cs-parser.jay (delegate_declaration): Record a delegate
2740 declaration as a type declaration.
2741 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
2743 2004-09-06 Miguel de Icaza <miguel@ximian.com>
2745 * parameter.cs: Do not crash if the type can not be resolved.
2747 * expression.cs: Report errors with unsafe pointers, fixes #64896
2749 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
2751 * expression.cs: Pointer arith always needs to do a conv.i
2752 if the operand is a long. fix 65320
2754 2004-09-04 Marek Safar <marek.safar@seznam.cz>
2756 Fixed cs0619-37.cs, cs0619-38.cs
2758 * enum.cs (GetObsoleteAttribute): Removed.
2760 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
2761 on Enum member is double staged. The first is tested member
2764 2004-09-04 Marek Safar <marek.safar@seznam.cz>
2766 Fixed #56986, #63631, #65231
2768 * class.cs: (TypeContainer.AddToMemberContainer): New method,
2769 adds member to name container.
2770 (TypeContainer.AddToTypeContainer): New method, adds type to
2772 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
2773 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
2774 AddOperator): Simplified by reusing AddToMemberContainer.
2775 (TypeContainer.UserDefinedStaticConstructor): Changed to property
2777 (Method.CheckForDuplications): Fixed implementation to test all
2779 (MemberBase): Detection whether member is explicit interface
2780 implementation is now in constructor.
2781 (MemberBase.UpdateMemberName): Handles IndexerName.
2782 (Accessor): Changed to keep also location information.
2783 (AbstractPropertyEventMethod): Is derived from MemberCore.
2784 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
2785 will be emited or not.
2786 (PropertyBase.AreAccessorsDuplicateImplementation):
2787 Tests whether accessors are not in collision with some method.
2788 (Operator): Is derived from MethodCore to simplify common
2791 * decl.cs (Flags.TestMethodDuplication): Test for duplication
2793 (DeclSpace.AddToContainer): Adds the member to defined_names
2794 table. It tests for duplications and enclosing name conflicts.
2796 * enum.cs (EnumMember): Clean up to reuse the base structures
2798 2004-09-03 Martin Baulig <martin@ximian.com>
2800 Merged latest changes into gmcs. Please keep this comment in
2801 here, it makes it easier for me to see what changed in MCS since
2802 the last time I merged.
2804 2004-09-03 Martin Baulig <martin@ximian.com>
2806 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
2807 into TypeContainer, to make partial classes work again.
2809 2004-09-03 Martin Baulig <martin@ximian.com>
2811 * rootcontext.cs (RootContext.V2): Removed.
2813 2004-03-23 Martin Baulig <martin@ximian.com>
2815 * expression.cs (Invocation.OverloadResolve): Added `bool
2816 may_fail' argument and use it instead of the Location.IsNull() hack.
2818 2004-09-09 Martin Baulig <martin@ximian.com>
2820 * cs-parser.jay (namespace_declaration): Fixed CS0134 reporting.
2822 2004-09-09 Martin Baulig <martin@ximian.com>
2824 * generic.cs (TypeParameter.DefineType): Added support for
2825 explicit interface methods.
2827 2004-09-09 Martin Baulig <martin@ximian.com>
2829 * README.Changes: New document. Started to list important changes
2830 between MCS and GMCS here.
2832 2004-09-08 Martin Baulig <martin@ximian.com>
2835 (TypeContainer.CheckRecursiveDefinition): New protected method.
2836 (TypeContainer.DefineType): Move the CS0146 check into
2837 CheckRecursiveDefinition().
2839 2004-09-06 Martin Baulig <martin@ximian.com>
2841 * generic.cs (ConstructedType.CheckConstraints): Allow builtin
2842 types for the constructor constraint.
2844 2004-09-03 Martin Baulig <martin@ximian.com>
2846 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
2847 into TypeContainer, to make partial classes work again.
2849 2004-09-03 Martin Baulig <martin@ximian.com>
2851 * rootcontext.cs (RootContext.V2): Removed.
2853 2004-03-23 Martin Baulig <martin@ximian.com>
2855 * expression.cs (Invocation.OverloadResolve): Added `bool
2856 may_fail' argument and use it instead of the Location.IsNull() hack.
2858 2004-09-03 Martin Baulig <martin@ximian.com>
2860 Merged latest changes into gmcs. Please keep this comment in
2861 here, it makes it easier for me to see what changed in MCS since
2862 the last time I merged.
2864 2004-09-03 Raja R Harinath <rharinath@novell.com>
2867 * expression.cs (BetterConversion): Don't allow either conversion
2868 to be null. Remove redundant implicit conversion test when 'q ==
2869 null' -- when this function is invoked, we already know that the
2870 implicit conversion exists.
2871 (BetterFunction): Assume that 'best' is non-null. Remove
2872 redundant reimplementation of IsApplicable when 'best' is null.
2873 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
2874 number of arguments.
2875 (IsAncestralType): Extract from OverloadResolve.
2876 (OverloadResolve): Make robust to the MethodGroupExpr being
2877 unsorted. Implement all the logic of Section 14.5.5.1, and
2878 support overloading of methods from multiple applicable types.
2879 Clean up logic somewhat. Don't pass null methods to BetterFunction.
2881 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
2882 (RealError, Warning): Append type of report to related symbol.
2884 2004-09-03 Marek Safar <marek.safar@seznam.cz>
2886 * enum.cs: Fixed CLS-Compliance checks for enum members.
2887 Error tests cs3008-8.cs, cs3014-8.cs
2889 2004-09-02 Marek Safar <marek.safar@seznam.cz>
2891 Fixed bug #62342, #63102
2892 * class.cs: ImplementIndexer uses member.IsExplicitImpl
2893 like ImplementMethod.
2895 2004-09-02 Marek Safar <marek.safar@seznam.cz>
2897 * attribute.cs (Attribute.GetAttributeArgumentExpression):
2900 2004-09-02 Martin Baulig <martin@ximian.com>
2902 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
2903 TypeManager.GetArgumentTypes() rather than calling GetParameters()
2906 2004-09-01 Marek Safar <marek.safar@seznam.cz>
2908 C# 2.0 Static classes implemented
2910 * class.cs (TypeContainer): instance_constructors,
2911 initialized_fields, initialized_static_fields,
2912 default_constructor, base_inteface_types are protected to be
2913 accessible from StaticClass.
2914 (TypeContainer.DefineDefaultConstructor): New virtual method
2915 for custom default constructor generating
2916 (StaticClass): New class to handle "Static classes" feature.
2918 * cs-parser.jay: Handle static keyword on class like instance
2921 * driver.cs: Added "/langversion" command line switch with two
2922 options (iso-1, default).
2924 2004-08-31 Marek Safar <marek.safar@seznam.cz>
2926 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
2928 2004-08-31 Miguel de Icaza <miguel@ximian.com>
2930 * delegate.cs: Style.
2932 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
2934 * delegate.cs: Add seperate instance expr field for miguel.
2936 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
2938 * PointerArithmetic (Resolve): make sure we are not doing
2939 pointer arith on void*. Also, make sure we are resolved
2940 by not setting eclass until resolve.
2942 All callers: Make sure that PointerArithmetic gets resolved.
2944 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
2946 * ArrayCreation (LookupType): If the type does not resolve
2947 to an array, give an error.
2949 2004-08-27 Marek Safar <marek.safar@seznam.cz>
2951 * statement.cs (Try.Resolve): Fixed bug #64222
2953 2004-08-27 Martin Baulig <martin@ximian.com>
2956 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
2959 2004-08-26 Marek Safar <marek.safar@seznam.cz>
2961 * ecore.cs (Constantify): Get underlying type via
2962 System.Enum.GetUnderlyingType to avoid StackOverflow on the
2963 Windows in special cases.
2965 2004-08-26 Marek Safar <marek.safar@seznam.cz>
2967 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
2968 for obtaining also private methods.
2969 (GetRemoveMethod): Used GetRemoveMethod (true)
2970 for obtaining also private methods.
2972 2004-09-02 Martin Baulig <martin@ximian.com>
2974 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
2975 TypeManager.GetArgumentTypes() rather than calling GetParameters()
2978 2004-08-27 Martin Baulig <martin@ximian.com>
2981 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
2984 2004-08-25 Martin Baulig <martin@ximian.com>
2986 * support.cs (ReflectionParameters..ctor): If this is a generic
2987 method, retrieve and store its type parameters.
2988 (InternalParameters..ctor): Added `TypeParameter[]' argument.
2989 (ReflectionParameters.GenericConstraints): The argument specifies
2990 the type parameter, not the method parameter.
2991 (InternalParameters.GenericConstraints): Likewise.
2993 * generic.cs (TypeParameter.DefineType): Correctly handle
2994 constraints wrt. generic methods in interfaces and their
2997 2004-08-24 Martin Baulig <martin@ximian.com>
2999 * generic.cs (TypeParameter.IsSubclassOf): New public method.
3000 (Constraints.IsSubclassOf): New internal method.
3002 * typemanager.cs (TypeManager.FindMembers): Added special support
3003 for GenericTypeParameterBuilder's.
3004 (TypeManager.IsSubclassOf, IsFamilyAccessible): Added support for
3007 2004-08-24 Martin Baulig <martin@ximian.com>
3010 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
3011 this for accessibility checks.
3012 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
3013 IsNestedFamilyAccessible.
3014 (TypeManager.IsSubclassOf): New method, do what the name actually
3017 2004-08-24 Martin Baulig <martin@ximian.com>
3019 * expression.cs (MemberAccess.DoResolve): When resolving ourselves
3020 as a SimpleName, include the generic arity.
3022 2004-08-24 Martin Baulig <martin@ximian.com>
3024 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
3025 MethodAttributes.HideBySig for operators.
3027 2004-08-23 Martin Baulig <martin@ximian.com>
3029 Back to the old error reporting system :-)
3031 * report.cs (Message): Removed.
3032 (Report.MessageData, ErrorData, WarningData): Removed.
3033 (Report.Error, Warning): Back to the old system.
3035 2004-08-23 Martin Baulig <martin@ximian.com>
3037 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
3039 * class.cs (TypeContainer.ParentContainer): New public virtual
3040 method; replaces the explicit interface implementation.
3041 (ClassPart.ParentContainer): Override.
3043 2004-08-23 Martin Baulig <martin@ximian.com>
3045 * statement.cs (Switch): Added support for constant switches; see
3046 #59428 or test-285.cs.
3048 2004-08-22 Marek Safar <marek.safar@seznam.cz>
3051 * statement.cs (GetEnumeratorFilter): Removed useless
3052 logic because C# specs is strict. GetEnumerator must be
3055 2004-08-22 Martin Baulig <martin@ximian.com>
3057 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
3058 a switch and may break, reset the barrier. Fixes #59867.
3060 2004-08-22 Marek Safar <marek.safar@seznam.cz>
3062 CLS-Compliance speed up (~5% for corlib)
3064 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
3065 New method. Tests container for CLS-Compliant names
3067 * class.cs (TypeContainer.VerifyClsName): New method.
3068 Checks whether container name is CLS Compliant.
3069 (Constructor): Implements IMethodData.
3071 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
3072 low-case table for CLS Compliance test.
3073 (MemberCache.VerifyClsParameterConflict): New method.
3074 Checks method parameters for CS3006 error.
3076 * enum.cs (EnumMember): Is derived from MemberCore.
3077 (Enum.VerifyClsName): Optimized for better performance.
3079 2004-08-06 Marek Safar <marek.safar@seznam.cz>
3081 * report.cs: Renamed Error_T to Error and changed all
3084 2004-08-06 Marek Safar <marek.safar@seznam.cz>
3086 * class.cs (TypeContainer.IndexerArrayList): New inner class
3087 container for indexers.
3088 (TypeContainer.DefaultIndexerName): New constant for default
3089 indexer name. Replaced all "Item" with this constant.
3090 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
3092 * typemanager.cs (TypeManager.default_member_ctor): Cache here
3093 DefaultMemberAttribute constructor.
3095 2004-08-05 Martin Baulig <martin@ximian.com>
3097 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
3100 2004-08-05 Marek Safar <marek.safar@seznam.cz>
3102 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
3103 multi platforms problem.
3105 * compiler.csproj: Included shared files.
3107 2004-08-04 Marek Safar <marek.safar@seznam.cz>
3109 Fix bug 60333, 55971 in the more general way
3110 * attribute.cs (Attribute.GetAttributeArgumentExpression):
3111 Added arg_type argument for constant conversion.
3112 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
3114 2004-08-04 Marek Safar <marek.safar@seznam.cz>
3117 * class.cs (TypeContainer ): New inner classes MethodArrayList,
3118 OperatorArrayList, MethodCoreArrayList for typecontainer
3119 containers. Changed class member types to these new types.
3120 (MethodArrayList.DefineMembers): Added test for CS0659.
3122 2004-08-04 Miguel de Icaza <miguel@ximian.com>
3124 * cfold.cs: Synchronize the folding with the code in expression.cs
3125 Binary.DoNumericPromotions for uint operands.
3127 * attribute.cs: Revert patch from Raja, it introduced a regression
3128 while building Blam-1.2.1 (hard to isolate a test case).
3130 2004-08-04 Marek Safar <marek.safar@seznam.cz>
3134 (TypeContainer.Define): Renamed to DefineContainerMembers because of
3136 (MethodCore.parent_method): New member. The method we're overriding
3137 if this is an override method.
3138 (MethodCore.CheckBase): Moved from Method class and made common.
3139 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
3141 (MethodCore.CheckForDuplications): New abstract method. For custom
3142 member duplication search in a container
3143 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
3144 method and its return type.
3145 (Event.conflict_symbol): New member. Symbol with same name in the
3149 (MemberCache.FindMemberWithSameName): New method. The method
3150 is looking for conflict with inherited symbols.
3152 2004-08-04 Martin Baulig <martin@ximian.com>
3154 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
3156 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
3158 2004-08-03 Marek Safar <marek.safar@seznam.cz>
3160 * report.cs (Message): New enum for better error, warning reference in
3162 (MessageData): New inner abstract class. It generally handles printing of
3163 error and warning messages.
3164 Removed unused Error, Warning, Message methods.
3166 2004-08-03 Marek Safar <marek.safar@seznam.cz>
3168 Fix for cs0592-8.cs test
3170 (Attributable.ValidAttributeTargets): Made public.
3171 (Attribute.ExplicitTarget): New member for explicit target value.
3172 (Attribute.CheckTargets): Now we translate explicit attribute
3173 target to Target here.
3175 2004-08-03 Ben Maurer <bmaurer@ximian.com>
3177 * ecore.cs (MethodGroupExpr): new IsBase property.
3179 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
3181 * delegate.cs (DelegateCreation): store a MethodGroupExpr
3182 rather than an instance expr.
3184 (DelegateCreation.Emit): Use the method group rather than
3185 the instance expression. Also, if you have base.Foo as the
3186 method for a delegate, make sure to emit ldftn, not ldftnvirt.
3188 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
3190 (NewDelegate.DoResolve): Only check for the existance of Invoke
3191 if the method is going to be needed. Use MethodGroupExpr.
3193 (NewDelegate.Emit): Remove, DelegateCreation implements this.
3195 * expression.cs: For pointer arith., make sure to use
3196 the size of the type, not the size of the pointer to
3199 2004-08-03 Marek Safar <marek.safar@seznam.cz>
3202 * class.cs (Class): Added error CS0502 test.
3204 2004-08-03 John Luke <jluke@cfl.rr.com>
3205 Raja R Harinath <rharinath@novell.com>
3208 * attribute.cs (Attribute.complained_before): New flag.
3209 (Attribute.ResolveType, Attribute.Resolve),
3210 (Attribute.DefinePInvokeMethod): Set it.
3211 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
3213 2004-08-03 Martin Baulig <martin@ximian.com>
3215 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
3216 use a user-defined operator; we still need to do numeric
3217 promotions in case one argument is a builtin type and the other
3218 one has an implicit conversion to that type. Fixes #62322.
3220 2004-08-18 Martin Baulig <martin@ximian.com>
3222 * class.cs (Method.Define): Use the correct method name when
3223 creating the MethodBuilder for a generic method.
3225 2004-08-17 Martin Baulig <martin@ximian.com>
3227 * generic.cs (Constraints): Support type parameter constraints.
3229 2004-08-16 Martin Baulig <martin@ximian.com>
3231 * cs-tokenizer.cs (Tokenizer.TypeOfParsing): New public property.
3232 (Token.GENERIC_DIMENSION): New token; this is returned if we
3233 encounter an unbound generic type in a typeof() expression.
3235 * cs-parser.jay (opt_type_argument_list): Added GENERIC_DIMENSION;
3236 this token is only generated while parsing a typeof() expression.
3237 (typeof_expression): Removed the old unbound_type hack.
3239 * generic.cs (TypeArguments.IsUnbound): New public property.
3241 * decl.cs (MemberName): Added support for unbound types.
3243 2004-08-14 Martin Baulig <martin@ximian.com>
3246 (TypeManager.IsEqualGenericInstance): New static method.
3247 (TypeManager.IsSubclassOrNestedChildOf, IsSubclassOf): This is
3248 just used to check accessibility, so follow the rules of 26.1.6.
3250 * expression.cs (MemberAccess.ResolveAsTypeStep): Return a
3251 ConstructedType instead of a TypeExpression if we have type arguments.
3253 * cs-parser.jay (typeof_expression): Support unbound generic types.
3255 * ecore.cs (UnboundTypeExpression): New public class.
3257 2004-08-12 Martin Baulig <martin@ximian.com>
3259 * typemanager.cs (TypeManager.IsNestedChildOf): Use
3260 TypeManager.IsEqual() rather than `=='.
3262 * decl.cs (DeclSpace.CheckAccessLevel): Use `tb.FullName' for
3263 generic instances as well.
3265 2004-08-12 Martin Baulig <martin@ximian.com>
3267 * expression.cs (Invocation.InferType): We can only infer method
3268 type parameters. Fixes #62647.
3270 2004-08-11 Martin Baulig <martin@ximian.com>
3272 * class.cs (TypeContainer.DefineType): Create the TypeBuilder
3273 before resolving the base classes.
3275 2004-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
3277 * Makefile: install .mdb file too.
3279 2004-08-05 Martin Baulig <martin@ximian.com>
3281 * ecore.cs (FieldExpr.DoResolveLValue): If we're resolving a field
3282 initializer, the current type is just the TypeBuilder, not the
3283 instantiated generic type.
3284 (FieldExpr.IsFieldInitializer): New public property.
3286 2004-08-04 Martin Baulig <martin@ximian.com>
3288 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
3290 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
3292 2004-08-03 Martin Baulig <martin@ximian.com>
3294 * class.cs (MethodData.Define): If we're an explicit
3295 implementation, remove the generic arity from the type name.
3297 2004-08-03 Martin Baulig <martin@ximian.com>
3299 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
3300 use a user-defined operator; we still need to do numeric
3301 promotions in case one argument is a builtin type and the other
3302 one has an implicit conversion to that type. Fixes #62322.
3304 2004-08-02 Martin Baulig <martin@ximian.com>
3306 * class.cs (TypeContainer.ifaces): Make this a `Type[]', not a
3308 (TypeContainer.GetClassBases): Return the unexpanded list of
3309 interfaces; we expand them later.
3310 (TypeContainer.DefineType): After creating the TypeBuilder, call
3311 TypeManager.ExpandInterfaces() to get an expanded and resolved
3314 * ecore.cs (TypeExpr.GetInterfaces): Removed
3316 * generics.cs (Constraints.InterfaceConstraints): Remove.
3317 (TypeParameter.DefineType): Call TypeManager.RegisterBuilder() to
3318 register the interface constraints.
3321 (TypeManager.AddUserType): Removed the `ifaces' argument.
3322 (TypeManager.AddTypeParameter): Likewise.
3323 (TypeManager.AddUserInterface): Removed, was unused.
3324 (TypeManager.RegisterBuilder): Take a `Type[]' instead of a
3325 `TypeExpr[]' array for the interfaces.
3326 (TypeManager.ExpandInterfaces): Call this after the TypeBuilder
3327 has been defined, returns a list of the resolved interfaces types.
3328 (TypeManager.GetInterfaces): Return a `Type[]', not a `TypeExpr[]'.
3329 (TypeManager.GetExplicitInterfaces): Likewise.
3331 2004-08-02 Martin Baulig <martin@ximian.com>
3333 * expression.cs (Invocation.EmitCall): If we're invoking a method
3334 on a type parameter, use the new `Constrained' prefix opcode.
3336 2004-08-02 Martin Baulig <martin@ximian.com>
3338 * statement.cs (LocalInfo.Flags): Added `IsThis'.
3339 (LocalInfo.IsThis): New public property.
3340 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
3342 2004-08-01 Martin Baulig <martin@ximian.com>
3344 * class.cs (TypeContainer.GetClassBases): Don't set the default
3345 here since we may get called from GetPartialBases().
3346 (TypeContainer.DefineType): If GetClassBases() didn't return a
3347 parent, use the default one.
3349 2004-07-30 Martin Baulig <martin@ximian.com>
3351 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
3353 * class.cs (SourceMethod): New public class, derive from the
3354 symbol writer's ISourceMethod.
3355 (Method): Use the new symbol writer API.
3357 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
3358 as argument and use the new symbol writer.
3361 (SourceFile): Implement the symbol writer's ISourceFile.
3362 (Location.SymbolDocument): Removed.
3363 (Location.SourceFile): New public property.
3365 * symbolwriter.cs: Use the new symbol writer API.
3367 2004-07-30 Raja R Harinath <rharinath@novell.com>
3369 * Makefile (install-local): Remove. Functionality moved to
3372 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
3374 * Makefile: Install mcs.exe.config file together with mcs.exe.
3375 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
3376 correct runtime version.
3378 2004-07-25 Martin Baulig <martin@ximian.com>
3381 (TypeContainer.RegisterOrder): Removed, this was unused.
3382 (TypeContainer, interface_order): Removed.
3383 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
3384 TypeContainer as argument since we can also be called with a
3385 `PartialContainer' for a partial class/struct/interface.
3386 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
3387 of checking whether we're an `Interface' - we could be a
3389 (PartialContainer.Register): Override; call
3390 AddClass()/AddStruct()/AddInterface() on our parent.
3392 * cs-parser.jay (interface_member_declaration): Add things to the
3393 `current_container', not the `current_class'.
3395 * rootcontext.cs (RegisterOrder): The overloaded version which
3396 takes an `Interface' was unused, removed.
3398 * typemanager.cs (TypeManager.LookupInterface): Return a
3399 `TypeContainer', not an `Interface'.
3400 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
3401 contain a `PartialContainer' for an interface, so check it's
3402 `Kind' to figure out what it is.
3404 2004-07-25 Martin Baulig <martin@ximian.com>
3406 * class.cs (Class.DefaultTypeAttributes): New public constant.
3407 (Struct.DefaultTypeAttributes): Likewise.
3408 (Interface.DefaultTypeAttributes): Likewise.
3409 (PartialContainer.TypeAttr): Override this and add the
3410 DefaultTypeAttributes.
3412 2004-07-25 Martin Baulig <martin@ximian.com>
3414 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
3415 we can just use the `Parent' field instead.
3417 2004-07-25 Martin Baulig <martin@ximian.com>
3419 * class.cs (TypeContainer.Emit): Renamed to EmitType().
3421 2004-07-25 Martin Baulig <martin@ximian.com>
3423 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
3424 our parts before defining any methods.
3425 (TypeContainer.VerifyImplements): Make this virtual.
3426 (ClassPart.VerifyImplements): Override and call VerifyImplements()
3427 on our PartialContainer.
3429 2004-07-25 Martin Baulig <martin@ximian.com>
3431 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
3433 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
3434 argument, we can just use the `Parent' field instead.
3437 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
3438 (MemberBase.DoDefine): Likewise.
3440 2004-07-24 Martin Baulig <martin@ximian.com>
3442 * decl.cs (MemberCore.Parent): New public field.
3443 (DeclSpace.Parent): Moved to MemberCore.
3445 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
3446 (MemberBase.ctor): Added TypeContainer argument, pass it to our
3448 (FieldBase, Field, Operator): Likewise.
3449 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
3450 (EventField, Event): Likewise.
3452 2004-07-23 Martin Baulig <martin@ximian.com>
3454 * class.cs (PartialContainer): New public class.
3455 (ClassPart): New public class.
3456 (TypeContainer): Added support for partial classes.
3457 (TypeContainer.GetClassBases): Splitted some of the functionality
3458 out into GetNormalBases() and GetPartialBases().
3460 * cs-tokenizer.cs (Token.PARTIAL): New token.
3461 (Tokenizer.consume_identifier): Added some hacks to recognize
3462 `partial', but only if it's immediately followed by `class',
3463 `struct' or `interface'.
3465 * cs-parser.jay: Added support for partial clases.
3467 2004-07-23 Martin Baulig <martin@ximian.com>
3469 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
3470 a `DeclSpace' and also made it readonly.
3471 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
3472 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
3473 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
3475 * cs-parser.jay: Pass the `current_class', not the
3476 `current_container' (at the moment, this is still the same thing)
3477 to a new Method, Property, Event, Indexer or Constructor.
3479 2004-07-23 Martin Baulig <martin@ximian.com>
3481 * cs-parser.jay (CSharpParser): Added a new `current_class' field
3482 and removed the `current_interface' one.
3483 (struct_declaration, class_declaration, interface_declaration):
3484 Set `current_class' to the newly created class/struct/interface;
3485 set their `Bases' and call Register() before parsing their body.
3487 2004-07-23 Martin Baulig <martin@ximian.com>
3489 * class.cs (Kind): New public enum.
3490 (TypeContainer): Made this class abstract.
3491 (TypeContainer.Kind): New public readonly field.
3492 (TypeContainer.CheckDef): New public method; moved here from
3494 (TypeContainer.Register): New public abstract method.
3495 (TypeContainer.GetPendingImplementations): New public abstract
3497 (TypeContainer.GetClassBases): Removed the `is_class' and
3498 `is_iface' parameters.
3499 (TypeContainer.DefineNestedTypes): Formerly known as
3501 (ClassOrStruct): Made this class abstract.
3503 * tree.cs (RootTypes): New public type.
3505 2004-07-20 Martin Baulig <martin@ximian.com>
3507 * tree.cs (Tree.RecordNamespace): Removed.
3508 (Tree.Namespaces): Removed.
3510 * rootcontext.cs (RootContext.IsNamespace): Removed.
3512 * cs-parser.jay (namespace_declaration): Just create a new
3513 NamespaceEntry here.
3515 2004-07-21 Lluis Sanchez Gual <lluis@novell.com>
3517 * Makefile: Install gmcs.exe.config file together with gmcs.exe.
3518 * gmcs.exe.config: Renamed from mcs.exe.config. Added supportedRuntime
3519 entry to make sure it runs in the correct runtime version.
3521 2004-07-18 Martin Baulig <martin@ximian.com>
3523 * generic.cs (ConstructedType.CheckConstraints): Improved
3524 constraints checking.
3526 2004-07-18 Martin Baulig <martin@ximian.com>
3528 * expression.cs (Invocation.BetterMethod): Call
3529 TypeManager.TypeToCoreType() on all types and removed my previous
3530 hack; we're already doig the right thing here.
3532 2004-07-17 Martin Baulig <martin@ximian.com>
3534 * decl.cs (MemberName.MakeName): Create the "class`1" names here.
3536 2004-07-16 Martin Baulig <martin@ximian.com>
3538 * iterators.cs: Added generics support.
3540 2004-07-16 Martin Baulig <martin@ximian.com>
3542 * iterators.cs: Rewrote this. We're now using one single Proxy
3543 class for both the IEnumerable and the IEnumerator interface and
3544 `Iterator' derives from Class so we can use the high-level API.
3546 * class.cs (TypeContainer.AddIterator): New method.
3547 (TypeContainer.DoDefineType): New protected virtual method, which
3548 is called from DefineType().
3549 (TypeContainer.DoDefineMembers): Call DefineType() and
3550 DefineMembers() on all our iterators.
3551 (TypeContainer.Emit): Call Emit() on all our iterators.
3552 (TypeContainer.CloseType): Call CloseType() on all our iterators.
3554 * codegen.cs (EmitContext.CurrentIterator): New public field.
3556 2004-07-15 Martin Baulig <martin@ximian.com>
3559 (TypeManager.not_supported_exception_type): New type.
3561 2004-07-14 Martin Baulig <martin@ximian.com>
3564 (TypeManager.generic_ienumerable_type): New type.
3565 (TypeManager.generic_ienumerator_type): New type.
3568 (RootContext.interfaces_first_stage): Added
3569 "System.Collections.Generic.IEnumerator`1" and
3570 "System.Collections.Generic.IEnumerable`1".
3572 2004-07-14 Martin Baulig <martin@ximian.com>
3574 * iterators.cs: Use real error numbers.
3576 2004-07-14 Martin Baulig <martin@ximian.com>
3578 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
3579 requires this to be a System.Collection.IEnumerable and not a
3580 class implementing that interface.
3581 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
3583 2004-07-13 Marek Safar <marek.safar@seznam.cz>
3585 * class.cs: Fixed previous fix, it broke some error tests.
3587 2004-07-12 Martin Baulig <martin@ximian.com>
3589 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
3592 2004-07-14 Martin Baulig <martin@ximian.com>
3594 * decl.cs, expression.cs, generic.cs: Use a backqoute (`) and not
3595 an exclamation mark (!) for the generic arity to reflect the
3596 latest spec changes; ie. use "System.Collections.Generic.IList`1".
3598 2004-07-13 Martin Baulig <martin@ximian.com>
3600 * cs-tokenizer.cs (Tokenizer.parse_less_than): Allow array rank
3601 specifiers being part of a type argument.
3603 2004-07-13 Martin Baulig <martin@ximian.com>
3605 * expression.cs (MemberAccess.ResolveAsTypeStep): Use the full `!'
3606 name for generic types.
3608 2004-07-13 Martin Baulig <martin@ximian.com>
3610 * assign.cs (Assign.DoResolve): Moved the CS0131 check up a little
3613 2004-07-09 Miguel de Icaza <miguel@ximian.com>
3615 * assign.cs (LocalTemporary): Add new argument: is_address,If
3616 `is_address' is true, then the value that we store is the address
3617 to the real value, and not the value itself.
3619 * ecore.cs (PropertyExpr): use the new local temporary
3620 stuff to allow us to handle X.Y += z (where X is a struct)
3622 2004-07-08 Martin Baulig <martin@ximian.com>
3624 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
3625 not always return, just like we're doing in Using.Resolve().
3627 2004-07-07 Miguel de Icaza <miguel@ximian.com>
3629 * cs-parser.jay (fixed_statement): flag this as Pinned.
3631 2004-07-06 Miguel de Icaza <miguel@ximian.com>
3633 * typemanager.cs (TypeManager): Removed MakePinned method, this
3634 mechanism is replaced with the .NET 2.x compatible mechanism of
3635 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
3637 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
3638 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
3639 `IsFixed' property which has a different meaning.
3641 2004-07-02 Raja R Harinath <rharinath@novell.com>
3643 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
3644 visible from inside a nested class, not just the names of the
3645 immediately enclosing class.
3648 2004-06-24 Raja R Harinath <rharinath@novell.com>
3650 * expression.cs (BetterConversion): Remove buggy special-case
3651 handling of "implicit constant expression conversions". At this
3652 point, we already know that the conversion is possible -- we're
3653 only checking to see which is better.
3655 2004-06-24 Marek Safar <marek.safar@seznam.cz>
3657 * cs-parser.jay: Added error CS0210 test.
3659 2004-06-24 Marek Safar <marek.safar@seznam.cz>
3661 * cs-parser.jay: Added error CS0134 test.
3663 2004-06-24 Marek Safar <marek.safar@seznam.cz>
3666 * cs-parser.jay: Added error CS0145 test.
3668 2004-06-24 Marek Safar <marek.safar@seznam.cz>
3670 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
3672 2004-06-23 Ben Maurer <bmaurer@ximian.com>
3674 * expression.cs (StackAlloc.Resolve): The argument may not
3675 be a constant; deal with this case.
3677 2004-06-23 Marek Safar <marek.safar@seznam.cz>
3679 * attribute.cs (IndexerName_GetIndexerName): Renamed to
3680 GetIndexerAttributeValue.
3681 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
3683 * class.cs (Indexer.Define): Added error tests for CS0415,
3686 2004-06-23 Miguel de Icaza <miguel@ximian.com>
3688 * attribute.cs (Attribute.Resolve): Keep field code in sync with
3691 2004-06-23 Martin Baulig <martin@ximian.com>
3693 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
3694 neither return nor throw, reset the barrier as well. Fixes #60457.
3696 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
3698 * class.cs : EventAttributes is now set to None by default.
3699 This fixes bug #60459.
3701 2004-06-18 Marek Safar <marek.safar@seznam.cz>
3704 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
3705 Don't throw exception but return null (it's sufficient now).
3707 2004-06-18 Marek Safar <marek.safar@seznam.cz>
3709 * typemanager.cs (GetArgumentTypes): Faster implementation.
3711 2004-06-18 Martin Baulig <martin@ximian.com>
3713 * attribute.cs (Attribute.Resolve): Check whether we're an
3714 EmptyCast which a Constant child. Fixes #60333.
3716 2004-06-17 Ben Maurer <bmaurer@ximian.com>
3718 * statement.cs (EmitCollectionForeach): Account for the fact that
3719 not all valuetypes are in areas which we can take the address of.
3720 For these variables, we store to a temporary variable. Also, make
3721 sure that we dont emit a `callvirt' on a valuetype method.
3723 2004-06-15 Marek Safar <marek.safar@seznam.cz>
3725 * expression.cs (StackAlloc.DoReSolve): Added test for
3726 negative parameter (CS0247).
3728 2004-06-15 Marek Safar <marek.safar@seznam.cz>
3731 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
3733 2004-06-15 Marek Safar <marek.safar@seznam.cz>
3736 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
3739 2004-06-14 Marek Safar <marek.safar@seznam.cz>
3741 Fix bug #58254 & cs1555.cs, cs1556.cs
3742 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
3744 2004-06-14 Marek Safar <marek.safar@seznam.cz>
3746 * cs-parser.jay: Added error CS1669 test for indexers.
3748 2004-06-18 Martin Baulig <martin@ximian.com>
3750 * generics.cs (GenericMethod.ctor): Don't take an Attributes
3751 argument. Fixes #60441.
3753 2004-06-16 Ben Maurer <bmaurer@ximian.com>
3754 * ecore.cs (MethodGroupExpr.Name): Revert Martin's patch.
3755 The name needs to have the actual name of the method in order
3756 for other tests (such as the one in OverloadResolve for Invoke
3757 on a delegate) to work. As well, it does not really help
3758 error reporting because the method group had multiple methods.
3759 * Makefile: Remove MCS_DEBUG, you can enable with the DEBUG_FLAGS.
3760 Make profiling work.
3762 2004-06-13 Martin Baulig <martin@ximian.com>
3764 * cs-parser.jay: Don't allow generic attributes.
3766 2004-06-13 Martin Baulig <martin@ximian.com>
3768 * class.cs (MemberBase.DoDefineBase): New protected method.
3769 (MemberBase.DoDefine): Compute the `flags' in the new
3770 DoDefineBase() which must be called first.
3771 (Method.Define): Call DoDefineBase() first so we have the flags
3772 when defining the generic method.
3774 * cs-parser.jay (interface_method_declaration): Support generic methods.
3776 2004-06-13 Martin Baulig <martin@ximian.com>
3778 * decl.cs (TypeName): Removed.
3779 (MemberName): Removed TypeName and MemberNow; now we just have
3782 * cs-parser.jay: Don't distinguish between type arguments and type
3783 parameters in the grammar and simplified the rules a bit. The
3784 reduce/reduce conflicts are now gone (except the one we inherited
3787 2004-06-11 Martin Baulig <martin@ximian.com>
3789 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
3790 call this twice: for params and varargs methods.
3792 2004-06-11 Marek Safar <marek.safar@seznam.cz>
3795 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
3797 2004-06-11 Marek Safar <marek.safar@seznam.cz>
3799 * attribute.cs (Attribute.GetValidTargets): Made public.
3802 (AbstractPropertyEventMethod): New class for better code sharing.
3803 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
3805 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
3807 2004-06-09 Martin Baulig <martin@ximian.com>
3809 * cs-parser.jay: Removed a reduce/reduce conflict.
3811 2004-06-03 Martin Baulig <martin@ximian.com>
3813 * generic.cs (ConstructedType.GetMemberAccess): Renamed to
3814 GetSimpleName() and return a SimpleName.
3816 * ecore.cs (SimpleName.Arguments): New public field.
3817 (SimpleName): Added overloaded ctor which takes an additional
3818 TypeArguments argument.
3819 (SimpleName.SimpleNameResolve): Added support for generic methods.
3820 (MethodGroupExpr.ResolveGeneric): New public method. The code was
3821 formerly in MemberAccess.DoResolve(), but we also need it in
3822 SimpleNameResolve().
3824 * expression.cs (MemberAccess.DoResolve): Use the new
3825 MethodGroupExpr.ResolveGeneric().
3827 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
3829 * decl.cs: If possible, use lookuptypedirect here. We can only do
3830 this if there is no `.' after the namespace. Avoids using
3831 LookupType, which does lots of slow processing.
3832 (FindNestedType) New method, does what it says :-).
3833 * namespace.cs: use LookupTypeDirect.
3834 * rootcontext.cs: use membercache, if possible.
3835 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
3837 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
3840 According to the spec,
3842 In a member access of the form E.I, if E is a single identifier,
3843 and if the meaning of E as a simple-name (§7.5.2) is a constant,
3844 field, property, localvariable, or parameter with the same type as
3845 the meaning of E as a type-name (§3.8), then both possible
3846 meanings of E are permitted.
3848 We did not check that E as a simple-name had the same type as E as
3851 This trivial check gives us 5-7% on bootstrap time.
3853 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
3855 * expression.cs (Invocation.OverloadResolve): Avoid the
3856 use of hashtables and boxing here by allocating on demand.
3858 2004-05-30 Martin Baulig <martin@ximian.com>
3860 * rootcontext.cs (RootContext.LookupType): Don't cache things if
3861 we're doing a silent lookup. Don't try to lookup nested types in
3862 TypeManager.object_type (thanks to Ben Maurer).
3864 2004-05-30 Martin Baulig <martin@ximian.com>
3866 Committing a patch from Ben Maurer.
3868 * rootcontext.cs (RootContext.LookupType): Cache negative results.
3870 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
3872 * convert.cs: add a trivial cache for overload operator resolution.
3874 2004-05-31 Marek Safar <marek.safar@seznam.cz>
3877 (AttributeTester.GetObsoleteAttribute): Returns instance of
3878 ObsoleteAttribute when type is obsolete.
3881 (TypeContainer.VerifyObsoleteAttribute): Override.
3882 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
3883 (MethodCode.VerifyObsoleteAttribute): Override.
3884 (MemberBase.VerifyObsoleteAttribute): Override.
3887 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
3888 and report proper error.
3891 (Delegate.VerifyObsoleteAttribute): Override.
3894 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
3895 and report proper error.
3896 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
3899 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
3903 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
3904 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
3905 Added test for ObsoleteAttribute.
3908 (Catch): Derived from Statement.
3910 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
3912 * decl.cs: If possible, use lookuptypedirect here. We can only do
3913 this if there is no `.' after the namespace. Avoids using
3914 LookupType, which does lots of slow processing.
3915 (FindNestedType) New method, does what it says :-).
3916 * namespace.cs: use LookupTypeDirect.
3917 * rootcontext.cs: use membercache, if possible.
3918 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
3920 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
3923 According to the spec,
3925 In a member access of the form E.I, if E is a single identifier,
3926 and if the meaning of E as a simple-name (§7.5.2) is a constant,
3927 field, property, localvariable, or parameter with the same type as
3928 the meaning of E as a type-name (§3.8), then both possible
3929 meanings of E are permitted.
3931 We did not check that E as a simple-name had the same type as E as
3934 This trivial check gives us 5-7% on bootstrap time.
3936 2004-05-30 Marek Safar <marek.safar@seznam.cz>
3938 Fixed bug #59071 & cs0160.cs
3939 * statement.cs (Try.Resolve): Check here whether order of catch
3940 clauses matches their dependencies.
3942 2004-05-30 Marek Safar <marek.safar@seznam.cz>
3945 * ecore.cs (SimpleName.SimpleNameResolve): Added test for
3948 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
3950 * expression.cs (Invocation.OverloadResolve): Avoid the
3951 use of hashtables and boxing here by allocating on demand.
3953 2004-05-30 Martin Baulig <martin@ximian.com>
3955 * rootcontext.cs (RootContext.LookupType): Don't cache things if
3956 we're doing a silent lookup. Don't try to lookup nested types in
3957 TypeManager.object_type (thanks to Ben Maurer).
3959 2004-05-30 Martin Baulig <martin@ximian.com>
3961 Committing a patch from Ben Maurer.
3963 * rootcontext.cs (RootContext.LookupType): Cache negative results.
3965 2004-05-29 Martin Baulig <martin@ximian.com>
3967 * class.cs (IMethodData.ShouldIgnore): New method.
3969 * typemanager.cs (TypeManager.MethodFlags): Don't take a
3970 `Location' argument, we don't need it anywhere. Use
3971 `IMethodData.ShouldIgnore ()' instead of
3972 `MethodData.GetMethodFlags ()'.
3973 (TypeManager.AddMethod): Removed.
3974 (TypeManager.AddMethod2): Renamed to AddMethod.
3976 2004-05-29 Martin Baulig <martin@ximian.com>
3978 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
3980 * convert.cs (Convert.ImplicitReferenceConversion): If we're
3981 converting from a class type S to an interface type and we already
3982 have an object on the stack, don't box it again. Fixes #52578.
3984 2004-05-29 Martin Baulig <martin@ximian.com>
3986 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
3987 Added support for `params' parameters. Fixes #59267.
3989 2004-05-29 Martin Baulig <martin@ximian.com>
3991 * literal.cs (NullPointer): Provide a private .ctor which sets
3992 `type' to TypeManager.object_type. Fixes #59048.
3994 2004-05-29 Martin Baulig <martin@ximian.com>
3996 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
3997 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
3999 * ecore.cs (EventExpr.instance_expr): Make the field private.
4001 2004-05-26 Marek Safar <marek.safar@seznam.cz>
4003 Fixed bug #50080 & cs0214-2.cs
4004 * expression.cs (Cast.DoResolve): Check unsafe context here.
4006 * statement.cs (Resolve.DoResolve): Likewise.
4008 2004-05-26 Martin Baulig <martin@ximian.com>
4010 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
4012 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
4013 (RootContext.LookupType): Pass down the `silent' flag.
4015 2004-05-25 Martin Baulig <martin@ximian.com>
4018 (MethodGroupExpr.IdenticalTypeName): New public property.
4019 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
4020 expression actually refers to a type.
4022 2004-05-25 Martin Baulig <martin@ximian.com>
4024 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
4025 for #56176 and made it actually work.
4027 2004-05-25 Martin Baulig <martin@ximian.com>
4029 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
4030 (FieldExpr, PropertyExpr): Override and implement
4031 CacheTemporaries. Fixes #52279.
4033 2004-05-25 Miguel de Icaza <miguel@ximian.com>
4035 * location.cs: In the new compiler listing a file twice is a
4036 warning, not an error.
4038 2004-05-24 Martin Baulig <martin@ximian.com>
4040 * enum.cs (Enum.DefineType): For the `BaseType' to be a
4041 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
4043 2004-05-24 Martin Baulig <martin@ximian.com>
4045 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
4046 walking the `using' list. Fixes #53921.
4048 2004-05-24 Martin Baulig <martin@ximian.com>
4050 * const.cs (Const.LookupConstantValue): Added support for
4051 EmptyCast's; fixes #55251.
4053 2004-05-24 Martin Baulig <martin@ximian.com>
4055 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
4056 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
4057 which does the CS0135 check. The reason is that we first need to
4058 check whether the variable actually exists.
4060 2004-05-24 Martin Baulig <martin@ximian.com>
4062 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
4063 than RootContext.LookupType() to find the explicit interface
4066 2004-05-24 Raja R Harinath <rharinath@novell.com>
4068 * Makefile: Simplify. Use executable.make.
4069 * mcs.exe.sources: New file. List of sources of mcs.exe.
4071 2004-05-24 Anders Carlsson <andersca@gnome.org>
4075 Use the invariant culture when doing String.Compare for CLS case
4078 2004-05-23 Martin Baulig <martin@ximian.com>
4080 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
4081 don't have any dots. Fixes #52622, added cs0246-8.cs.
4083 * namespace.cs (NamespaceEntry.Lookup): Likewise.
4085 2004-05-23 Marek Safar <marek.safar@seznam.cz>
4087 * class.cs (MemberBase.Define): Reuse MemberType member for
4088 resolved type. Other methods can use it too.
4090 2004-05-23 Martin Baulig <martin@ximian.com>
4092 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
4093 the variable also exists in the current block (otherwise, we need
4094 to report a CS0103). Fixes #58670.
4096 2004-05-23 Martin Baulig <martin@ximian.com>
4098 * flowanalysis.cs (Reachability.Reachable): Compute this
4099 on-the-fly rather than storing it as a field.
4101 2004-05-23 Martin Baulig <martin@ximian.com>
4103 * flowanalysis.cs (Reachability.And): Manually compute the
4104 resulting `barrier' from the reachability.
4106 2004-05-23 Marek Safar <marek.safar@seznam.cz>
4109 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
4110 instance of ObsoleteAttribute when symbol is obsolete.
4113 (IMethodData): Extended interface for ObsoleteAttribute support.
4115 2004-05-22 Marek Safar <marek.safar@seznam.cz>
4117 * attribute.cs: Fix bug #55970
4119 2004-05-22 Marek Safar <marek.safar@seznam.cz>
4123 (GetObsoleteAttribute): New method. Creates the instance of
4125 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
4126 ObsoleteAttribute when member is obsolete.
4127 (AttributeTester.Report_ObsoleteMessage): Common method for
4128 Obsolete error/warning reporting.
4131 (TypeContainer.base_classs_type): New member for storing parent type.
4134 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
4135 for this MemberCore.
4137 2004-05-21 Marek Safar <marek.safar@seznam.cz>
4139 * attribute.cs, const.cs: Fix bug #58590
4141 2004-05-21 Martin Baulig <martin@ximian.com>
4143 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
4144 out parameters if the end of the method is unreachable. Fixes
4147 2004-05-21 Marek Safar <marek.safar@seznam.cz>
4149 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
4150 Hari was right, why extra method.
4152 2004-05-21 Marek Safar <marek.safar@seznam.cz>
4154 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
4156 2004-05-20 Martin Baulig <martin@ximian.com>
4158 * delegate.cs: Convert this file to Unix mode - like the original
4161 2004-05-20 Martin Baulig <martin@ximian.com>
4163 * attribute.cs: Convert this file to Unix mode - like the original
4166 2004-05-19 Marek Safar <marek.safar@seznam.cz>
4168 Fix bug #58688 (MCS does not report error when the same attribute
4171 * attribute.cs (Attribute.Emit): Distinction between null and default.
4173 2004-05-19 Raja R Harinath <rharinath@novell.com>
4175 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
4176 of a top-level attribute without an attribute target.
4177 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
4179 (Attribute.Conditional_GetConditionName),
4180 (Attribute.Obsolete_GetObsoleteMessage): Update.
4181 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
4182 part of ScanForIndexerName.
4183 (Attribute.CanIgnoreInvalidAttribute): New function.
4184 (Attribute.ScanForIndexerName): Move to ...
4185 (Attributes.ScanForIndexerName): ... here.
4186 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
4187 (Attributes.Search): New internal variant that can choose not to
4188 complain if types aren't resolved. The original signature now
4190 (Attributes.GetClsCompliantAttribute): Use internal variant, with
4191 complaints suppressed.
4192 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
4193 only if it not useful.
4194 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
4195 top-level for attributes that are shared between the assembly
4196 and a top-level class.
4197 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
4198 * class.cs: Update to reflect changes.
4199 (DefineIndexers): Fuse loops.
4200 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
4201 a couple more variants of attribute names.
4203 2004-05-18 Marek Safar <marek.safar@seznam.cz>
4205 Fix bug #52585 (Implemented explicit attribute declaration)
4208 (Attributable.ValidAttributeTargets): New abstract method. It gets
4209 list of valid attribute targets for explicit target declaration.
4210 (Attribute.Target): It holds target itself.
4211 (AttributeSection): Removed.
4212 (Attribute.CheckTargets): New method. It checks whether attribute
4213 target is valid for the current element.
4216 (EventProperty): New class. For events that are declared like
4217 property (with add and remove accessors).
4218 (EventField): New class. For events that are declared like field.
4221 * cs-parser.jay: Implemented explicit attribute target declaration.
4223 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
4224 Override ValidAttributeTargets.
4227 (ReturnParameter): Class for applying custom attributes on
4229 (ParameterAtribute): New class. Class for applying custom
4230 attributes on the parameter type.
4232 2004-05-17 Miguel de Icaza <miguel@ximian.com>
4234 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
4237 (Method): Allow UNSAFE here.
4239 * modifiers.cs: Support unsafe reporting.
4241 2004-05-17 Marek Safar <marek.safar@seznam.cz>
4243 * decl.cs: Fix bug #58478.
4245 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
4247 * statement.cs: When checking for unreachable code on an EmptyStatement,
4248 set the location. Fixes bug #58488.
4250 2004-05-13 Miguel de Icaza <miguel@ximian.com>
4252 * driver.cs: Add -pkg handling.
4254 From Gonzalo: UseShelLExecute=false
4256 2004-05-12 Marek Safar <marek.safar@seznam.cz>
4259 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
4261 (Attribute.IsClsCompliaceRequired): Moved to base for better
4263 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
4264 when attribute is AttributeUsageAttribute.
4265 (Attribute.GetValidTargets): Simplified.
4266 (Attribute.GetAttributeUsage): New method returns AttributeUsage
4267 attribute for this type.
4268 (Attribute.ApplyAttributes): Method renamed to Emit and make
4270 (GlobalAttributeSection): New class for special handling of global
4271 attributes (assembly, module).
4272 (AttributeSection.Emit): New method.
4274 * class.cs: Implemented Attributable abstract methods.
4275 (MethodCore.LabelParameters): Moved to Parameter class.
4276 (Accessor): Is back simple class.
4277 (PropertyMethod): Implemented Attributable abstract class.
4278 (DelegateMethod): Implemented Attributable abstract class.
4279 (Event): New constructor for disctintion between normal Event
4280 and Event with accessors.
4282 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
4284 * codegen.cs, const.cs, decl.cs, delegate.cs:
4285 (CommonAssemblyModulClass): Implemented Attributable abstract class
4288 * enum.cs: Implement IAttributeSupport interface.
4289 (EnumMember): New class for emum members. Implemented Attributable
4293 (ParameterBase): Is abstract.
4294 (ReturnParameter): New class for easier [return:] attribute handling.
4296 * typemanager.cs: Removed builder_to_attr.
4298 2004-05-11 Raja R Harinath <rharinath@novell.com>
4301 * attribute.cs (Attribute.GetPositionalValue): New function.
4302 * class.cs (TypeContainer.VerifyMembers): New function.
4303 (TypeContainer.Emit): Use it.
4304 (ClassOrStruct): New base class for Class and Struct.
4305 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
4306 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
4308 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
4309 then each non-static field should have a FieldOffset attribute.
4310 Otherwise, none of the fields should have a FieldOffset attribute.
4311 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
4312 and FieldOffset attributes.
4313 * typemanager.cs (TypeManager.struct_layout_attribute_type)
4314 (TypeManager.field_offset_attribute_type): New core types.
4315 (TypeManager.InitCoreTypes): Initialize them.
4317 2004-05-11 Michal Moskal <malekith@pld-linux.org>
4319 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
4320 Return correct type.
4323 2004-05-09 Miguel de Icaza <miguel@ximian.com>
4325 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
4326 be implicitly converted to ulong.
4328 * expression.cs: The logic for allowing operator &, | and ^ worked
4329 was wrong, it worked before because we did not report an error in
4330 an else branch. Fixes 57895.
4332 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
4333 allow volatile fields to be reference types.
4335 2004-05-07 Miguel de Icaza <miguel@ximian.com>
4337 * driver.cs: Add support for /debug-
4339 2004-05-07 Raja R Harinath <rharinath@novell.com>
4341 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
4342 Add a 'complain' parameter to silence errors.
4343 (Attribute.Resolve): Update to changes. Put in sanity check to catch
4344 silently overlooked type-resolutions.
4345 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
4347 (Attributes.Search): New function.
4348 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
4349 (Attributes.GetAttributeFullName): Remove hack.
4350 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
4351 Update to reflect changes.
4352 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
4353 Use Attributes.Search instead of nested loops.
4355 2004-05-07 Marek Safar <marek.safar@seznam.cz>
4358 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
4359 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
4360 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
4362 * report.cs: (Report.Warning): Renamed to Warning_T because of
4363 parameter collision.
4365 2004-05-05 Raja R Harinath <rharinath@novell.com>
4367 * expression.cs (MemberAccess.ResolveMemberAccess):
4368 Exit with non-zero status after Report.Error.
4369 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
4371 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
4373 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
4375 * support.cs: Don't hang when the file is empty.
4377 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
4379 * support.cs: In SeekableStreamReader, compute the preamble size of the
4380 underlying stream. Position changes should take into account that initial
4383 2004-05-03 Todd Berman <tberman@sevenl.net>
4385 * driver.cs: remove unused GetSysVersion function.
4387 2004-05-03 Todd Berman <tberman@sevenl.net>
4389 * driver.cs: Remove the hack from saturday, as well as the hack
4390 from jackson (LoadAssemblyFromGac), also adds the CWD to the
4391 link_paths to get that bit proper.
4393 2004-05-01 Todd Berman <tberman@sevenl.net>
4395 * driver.cs: Try a LoadFrom before a Load, this checks the current
4396 path. This is currently a bug in mono that is be fixed, however, this
4397 provides a workaround for now. This will be removed when the bug
4400 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
4402 * CryptoConvert.cs: Updated to latest version. Fix issue with
4403 incomplete key pairs (#57941).
4405 2004-05-01 Todd Berman <tberman@sevenl.net>
4407 * driver.cs: Remove '.' from path_chars, now System.* loads properly
4410 2004-04-30 Jackson Harper <jackson@ximian.com>
4412 * codegen.cs: Open keys readonly.
4414 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
4416 * typemanager.cs: don't report cyclic struct layout when a struct
4417 contains 2 or more fields of the same type. Failed for Pango.AttrShape
4418 which has 2 Pango.Rectangle fields.
4420 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
4422 * expression.cs: Handle IntPtr comparisons with IL code
4423 rather than a method call.
4425 2004-04-29 Martin Baulig <martin@ximian.com>
4427 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
4428 the list of PropertyInfo's in class hierarchy and find the
4429 accessor. Fixes #56013.
4431 2004-04-29 Martin Baulig <martin@ximian.com>
4433 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
4435 2004-04-29 Martin Baulig <martin@ximian.com>
4437 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
4439 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
4441 2004-04-29 Martin Baulig <martin@ximian.com>
4443 * class.cs (ConstructorInitializer.Resolve): Check whether the
4444 parent .ctor is accessible. Fixes #52146.
4446 2004-04-29 Martin Baulig <martin@ximian.com>
4448 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
4450 * statement.cs (Using.EmitLocalVariableDecls): Use
4451 TypeManager.idisposable_type, not typeof (IDisposable).
4452 (Foreach.EmitCollectionForeach): Added support for valuetypes.
4454 2004-04-29 Martin Baulig <martin@ximian.com>
4456 * class.cs (Event.Define): Don't emit the field and don't set
4457 RTSpecialName and SpecialName for events on interfaces. Fixes
4460 2004-04-29 Raja R Harinath <rharinath@novell.com>
4462 Refactor Attribute.ApplyAttributes.
4463 * attribute.cs (Attributable): New base class for objects that can
4464 have Attributes applied on them.
4465 (Attribute): Make AttributeUsage fields public.
4466 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
4467 (Attribute.IsInternalCall): New property.
4468 (Attribute.UsageAttr): Convert to a public read-only property.
4469 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
4470 (Attribute.ResolveType, Attribute.Resolve)
4471 (Attribute.ScanForIndexerName): Update to reflect changes.
4472 (Attribute.CheckAttributeTarget): Re-format.
4473 (Attribute.ApplyAttributes): Refactor, to various
4474 Attributable.ApplyAttributeBuilder methods.
4475 * decl.cs (MemberCore): Make Attributable.
4476 * class.cs (Accessor): Make Attributable.
4477 (MethodData.ApplyAttributes): Use proper attribute types, not
4479 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
4480 (TypeContainer.ApplyAttributeBuilder)
4481 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
4482 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
4483 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
4484 (Operator.ApplyAttributeBuilder): New factored-out methods.
4485 * const.cs (Const.ApplyAttributeBuilder): Likewise.
4486 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
4487 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
4488 * parameter.cs (ParameterBase): New Attributable base class
4489 that can also represent Return types.
4490 (Parameter): Update to the changes.
4492 2004-04-29 Jackson Harper <jackson@ximian.com>
4494 * driver.cs: Prefer the corlib system version when looking for
4495 assemblies in the GAC. This is still a hack, but its a better hack
4498 2004-04-29 Marek Safar <marek.safar@seznam.cz>
4500 * decl.cs, enum.cs: Improved error 3005 reporting.
4502 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
4503 (related_symbols): New private member for list of symbols
4504 related to reported error/warning.
4506 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
4508 2004-04-29 Martin Baulig <martin@ximian.com>
4510 * ecore.cs (Expression.Constantify): If we're an enum and
4511 TypeManager.TypeToCoreType() doesn't give us another type, use
4512 t.UnderlyingSystemType. Fixes #56178.
4514 2004-04-29 Martin Baulig <martin@ximian.com>
4516 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
4517 interfaces and for each interface, only add members directly
4518 declared in that interface. Fixes #53255.
4520 2004-04-28 Martin Baulig <martin@ximian.com>
4522 * expression.cs (ConditionalLogicalOperator): Use a temporary
4523 variable for `left' to avoid that we evaluate it more than once;
4526 2004-04-28 Martin Baulig <martin@ximian.com>
4528 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
4531 2004-04-28 Martin Baulig <martin@ximian.com>
4533 * statement.cs (LocalInfo.Resolve): Check whether the type is not
4536 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
4537 whether the type is not void (CS1547).
4539 2004-04-28 Martin Baulig <martin@ximian.com>
4541 * expression.cs (Unary.DoResolveLValue): Override this and report
4542 CS0131 for anything but Operator.Indirection.
4544 2004-04-28 Martin Baulig <martin@ximian.com>
4546 Committing a patch from Ben Maurer; see bug #50820.
4548 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
4551 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
4554 2004-04-28 Martin Baulig <martin@ximian.com>
4556 Committing a patch from Ben Maurer; see bug #50820.
4558 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
4561 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
4564 2004-04-28 Martin Baulig <martin@ximian.com>
4566 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
4567 (Block.AddLabel): Call DoLookupLabel() to only search in the
4570 2004-04-28 Martin Baulig <martin@ximian.com>
4572 * cfold.cs (ConstantFold.BinaryFold): Added special support for
4573 comparing StringConstants and NullLiterals in Equality and Inequality.
4575 2004-04-28 Jackson Harper <jackson@ximian.com>
4577 * driver.cs: Attempt to load referenced assemblies from the
4578 GAC. This is the quick and dirty version of this method that
4579 doesnt take into account versions and just takes the first
4580 canidate found. Will be good enough for now as we will not have more
4581 then one version installed into the GAC until I update this method.
4583 2004-04-28 Martin Baulig <martin@ximian.com>
4585 * typemanager.cs (TypeManager.CheckStructCycles): New public
4586 static method to check for cycles in the struct layout.
4588 * rootcontext.cs (RootContext.PopulateTypes): Call
4589 TypeManager.CheckStructCycles() for each TypeContainer.
4590 [Note: We only need to visit each type once.]
4592 2004-04-28 Martin Baulig <martin@ximian.com>
4594 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
4596 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
4597 success and added `out object value'. Use a `bool resolved' field
4598 to check whether we've already been called rather than
4599 `ConstantValue != null' since this breaks for NullLiterals.
4601 2004-04-28 Raja R Harinath <rharinath@novell.com>
4603 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
4604 setting of this flag, since the 'set' method may be non-public.
4606 2004-04-28 Raja R Harinath <rharinath@novell.com>
4608 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
4609 check on current_vector.Block.
4611 2004-04-27 Martin Baulig <martin@ximian.com>
4613 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
4614 a field initializer. Fixes #56459.
4616 2004-04-27 Martin Baulig <martin@ximian.com>
4618 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
4619 we're not attempting to use an indexer. Fixes #52154.
4621 2004-04-27 Martin Baulig <martin@ximian.com>
4623 * statement.cs (Return): Don't create a return label if we don't
4624 need it; reverts my change from January 20th. Thanks to Ben
4627 2004-04-27 Martin Baulig <martin@ximian.com>
4629 According to the spec, `goto' can only leave a nested scope, but
4632 * statement.cs (Block.LookupLabel): Only lookup in the current
4633 block, don't recurse into parent or child blocks.
4634 (Block.AddLabel): Check in parent and child blocks, report
4635 CS0140/CS0158 if we find a duplicate.
4636 (Block): Removed this indexer for label lookups.
4637 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
4638 this already does the error reporting for us.
4641 (FlowBranching.UsageVector.Block): New public variable; may be null.
4642 (FlowBranching.CreateSibling): Added `Block' argument.
4643 (FlowBranching.LookupLabel): New public virtual method. Lookup a
4644 label for the target of a `goto' and check whether we're not
4645 leaving a `finally'.
4647 2004-04-27 Martin Baulig <martin@ximian.com>
4649 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
4650 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
4653 2004-04-27 Martin Baulig <martin@ximian.com>
4655 * statement.cs (Block.AddLabel): Also check for implicit blocks
4656 and added a CS0158 check.
4658 2004-04-27 Martin Baulig <martin@ximian.com>
4660 * flowanalysis.cs (FlowBranchingLoop): New class.
4661 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
4662 UsageVector's instead of an ArrayList.
4663 (FlowBranching.Label): Likewise.
4664 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
4665 (FlowBranching.AddBreakVector): New method.
4667 2004-04-27 Miguel de Icaza <miguel@ximian.com>
4669 * attribute.cs: Small regression fix: only convert the type if we
4670 the type is different, fixes System.Drawing build.
4672 2004-04-27 Martin Baulig <martin@ximian.com>
4674 * attribute.cs (Attribute.Resolve): If we have a constant value
4675 for a named field or property, implicity convert it to the correct
4678 2004-04-27 Raja R Harinath <rharinath@novell.com>
4680 * statement.cs (Block.Block): Implicit blocks share
4681 'child_variable_names' fields with parent blocks.
4682 (Block.AddChildVariableNames): Remove.
4683 (Block.AddVariable): Mark variable as "used by a child block" in
4684 every surrounding block.
4685 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
4686 been used in a child block, complain about violation of "Invariant
4687 meaning in blocks" rule.
4688 * cs-parser.jay (declare_local_variables): Don't use
4689 AddChildVariableNames.
4690 (foreach_statement): Don't create an implicit block: 'foreach'
4693 2004-04-23 Miguel de Icaza <miguel@ximian.com>
4695 * convert.cs (ImplicitNumericConversion): 0 is also positive when
4696 converting from 0L to ulong. Fixes 57522.
4698 2004-04-22 Marek Safar <marek.safar@seznam.cz>
4700 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
4701 derived class hides via 'new' keyword field from base class (test-242.cs).
4702 TODO: Handle this in the more general way.
4704 * class.cs (CheckBase): Ditto.
4706 2004-04-22 Marek Safar <marek.safar@seznam.cz>
4708 * decl.cs (caching_flags): New member for storing cached values
4710 (MemberCore.Flags): New enum where bit flags for caching_flags
4712 (MemberCore.cls_compliance): Moved to caching_flags.
4713 (DeclSpace.Created): Moved to caching_flags.
4715 * class.cs: Use caching_flags instead of DeclSpace.Created
4717 2004-04-21 Miguel de Icaza <miguel@ximian.com>
4719 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
4720 if we are only a derived class, not a nested class.
4722 * typemanager.cs: Same as above, but do this at the MemberLookup
4723 level (used by field and methods, properties are handled in
4724 PropertyExpr). Allow for the qualified access if we are a nested
4727 2004-04-21 Marek Safar <marek.safar@seznam.cz>
4729 * class.cs: Refactoring.
4730 (IMethodData): New inteface; Holds links to parent members
4731 to avoid member duplication (reduced memory allocation).
4732 (Method): Implemented IMethodData interface.
4733 (PropertyBase): New inner classes for get/set methods.
4734 (PropertyBase.PropertyMethod): Implemented IMethodData interface
4735 (Event): New inner classes for add/remove methods.
4736 (Event.DelegateMethod): Implemented IMethodData interface.
4738 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
4739 EmitContext (related to class.cs refactoring).
4741 2004-04-21 Raja R Harinath <rharinath@novell.com>
4743 * delegate.cs (Delegate.VerifyApplicability): If the number of
4744 arguments are the same as the number of parameters, first try to
4745 verify applicability ignoring any 'params' modifier on the last
4749 2004-04-08 Martin Baulig <martin@ximian.com>
4751 Merged latest changes into gmcs. Please keep this comment in
4752 here, it makes it easier for me to see what changed in MCS since
4753 the last time I merged.
4755 2004-04-16 Raja R Harinath <rharinath@novell.com>
4757 * class.cs (TypeContainer.AddIndexer): Use
4758 'ExplicitInterfaceName' to determine if interface name was
4759 explicitly specified. 'InterfaceType' is not initialized at this time.
4760 (TypeContainer.DefineIndexers): Remove use of temporary list. The
4761 Indexers array is already in the required order. Initialize
4762 'IndexerName' only if there are normal indexers.
4763 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
4764 (TypeContainer.Emit): Emit DefaultMember attribute only if
4765 IndexerName is initialized.
4768 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
4770 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
4773 2004-04-15 Raja R Harinath <rharinath@novell.com>
4775 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
4779 * attribute.cs (Attribute.Resolve): Check for duplicate named
4783 2004-04-15 Miguel de Icaza <miguel@ximian.com>
4785 * iterators.cs (MarkYield): track whether we are in an exception,
4786 and generate code accordingly. Use a temporary value to store the
4787 result for our state.
4789 I had ignored a bit the interaction of try/catch with iterators
4790 since their behavior was not entirely obvious, but now it is
4791 possible to verify that our behavior is the same as MS .NET 2.0
4795 2004-04-14 Miguel de Icaza <miguel@ximian.com>
4797 * iterators.cs: Avoid creating temporaries if there is no work to
4800 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
4801 Enumerations, use TypeManager.EnumToUnderlying and call
4804 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
4807 (This.Emit): Use EmitContext.EmitThis to emit our
4810 (This.EmitAssign): Ditto.
4812 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
4813 codepaths, we will move all the functionality into
4816 (FieldExpr.EmitAssign): Ditto.
4818 This fixes several hidden bugs that I uncovered while doing a code
4819 review of this today.
4821 * codegen.cs (EmitThis): reworked so the semantics are more clear
4822 and also support value types "this" instances.
4824 * iterators.cs: Changed so that for iterators in value types, we
4825 do not pass the value type as a parameter.
4827 Initialization of the enumerator helpers is now done in the caller
4828 instead of passing the parameters to the constructors and having
4829 the constructor set the fields.
4831 The fields have now `assembly' visibility instead of private.
4833 2004-04-11 Miguel de Icaza <miguel@ximian.com>
4835 * expression.cs (Argument.Resolve): Check if fields passed as ref
4836 or out are contained in a MarshalByRefObject.
4838 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
4839 another compiler type.
4841 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
4843 * class.cs (Indexer.Define): use the new name checking method.
4844 Also, return false on an error.
4845 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
4846 (is_identifier_[start/part]_character): make static.
4848 2004-04-10 Miguel de Icaza <miguel@ximian.com>
4850 * expression.cs (Binary.ResolveOperator): Do no append strings
4851 twice: since we can be invoked more than once (array evaluation)
4852 on the same concatenation, take care of this here. Based on a fix
4853 from Ben (bug #56454)
4855 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
4857 * codegen.cs: Fix another case where CS1548 must be reported (when
4858 delay-sign isn't specified and no private is available #56564). Fix
4859 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
4860 error when MCS is used on the MS runtime and we need to delay-sign
4861 (which seems unsupported by AssemblyBuilder - see #56621).
4863 2004-04-08 Marek Safar <marek.safar@seznam.cz>
4865 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
4866 (TypeManager.ComputeNamespaces): Faster implementation for
4869 * compiler.csproj: Updated AssemblyName to mcs.
4871 2004-05-11 Jackson Harper <jackson@ximian.com>
4873 * Makefile: Preserve MONO_PATH
4875 2004-05-11 Jackson Harper <jackson@ximian.com>
4877 * Makefile: Use mono and mcs to build gmcs
4879 2004-05-03 Miguel de Icaza <miguel@ximian.com>
4881 * codegen.cs: Add patch from Robert Shade
4882 <rshade@dvsconsulting.com>, use FileAccess.Read on the keyfile, to
4885 2004-05-02 Sebastien Pouliot <sebastien@ximian.com>
4887 * CryptoConvert.cs: Updated to latest version. Fix issue with
4888 incomplete key pairs (#57941).
4890 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
4892 * codegen.cs: Fix another case where CS1548 must be reported (when
4893 delay-sign isn't specified and no private is available #56564). Fix
4894 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
4895 error when MCS is used on the MS runtime and we need to delay-sign
4896 (which seems unsupported by AssemblyBuilder - see #56621).
4898 2004-04-29 Jackson Harper <jackson@ximian.com>
4900 * Makefile: Set MONO_PATH to use the bootstrap corlib
4901 * driver.cs: Check the GAC for referenced assemblies.
4903 2004-04-29 Martin Baulig <martin@ximian.com>
4905 * Makefile (gmcs.exe): Set MONO_PATH to use `../class/lib/net_2_0'.
4907 2004-04-07 Martin Baulig <martin@ximian.com>
4909 * expression.cs (Binary.ResolveOperator): Added special case for
4910 Equality/Inequality between a type parameter and a null literal.
4912 2004-04-07 Martin Baulig <martin@ximian.com>
4914 * convert.cs: Check null literal -> type parameter conversions.
4916 2004-04-07 Martin Baulig <martin@ximian.com>
4918 * generic.cs (ConstructedType.CheckConstraints): Enforce the
4919 `class' and `struct' constraints.
4921 2004-04-07 Martin Baulig <martin@ximian.com>
4923 * generic.cs (SpecialConstraint): New public enum.
4924 (Constraints.Resolve): Added support for the `class' and `struct'
4927 * cs-parser.jay (type_parameter_constraint): Added support for the
4928 `class' and `struct' constraints.
4930 2004-04-07 Martin Baulig <martin@ximian.com>
4932 * support.cs (GenericConstraints): Replaced `Types' by
4933 `ClassConstraint' and `InterfaceConstraints'; added
4934 `HasClassConstraint'.
4936 2004-04-07 Martin Baulig <martin@ximian.com>
4939 (Constraints.InterfaceConstraints): New public property.
4940 (Constraints.Types): Make this property public
4941 (TypeParameter): Implement IMemberContainer.
4942 (TypeParameter.Define): Take a `GenericTypeParameterBuilder'
4943 instead of a TypeBuilder/MethodBuilder; pass the interface
4944 constraints to TypeManager.AddTypeParameter().
4945 (TypeParameter.DefineType): Just take an EmitContext and no
4946 TypeBuilder/MethodBuilder. Use the new public API.
4948 * typemanager.cs (TypeManager.AddTypeParameter): Added
4949 `TypeExpr[]' argument; add the interfaces to the
4950 `builder_to_ifaces' hash.
4951 (TypeManager.LookupMemberContainer): For
4952 GenericTypeParameterBuilders, get the TypeParameter from the
4953 `builder_to_type_param'.
4954 (TypeManager.FindMembers): For GenericTypeParameterBuilders, get
4955 the TypeParameter and call FindMembers on it.
4957 2004-04-07 Martin Baulig <martin@ximian.com>
4960 (MethodCore.GenericMethod): Moved this field here from Method.
4961 (MethodCore.IsDuplicateImplementation): Take the number of type
4962 parameters into account if we're a generic method.
4964 * expression.cs (Invocation.InferTypeArguments): Don't return true
4965 if `arguments' is null; we still need to check whether we actually
4966 don't need to infer anything in this case.
4967 (MemberAccess): Merged the functionality from GenericMemberAccess
4970 * generic.cs (GenericMemberAccess): Removed.
4972 2004-04-05 Martin Baulig <martin@ximian.com>
4974 * decl.cs (MemberCore): For generic classes, interfaces and
4975 structs, `Name' now includes the number of type parameters
4977 (DeclSpace.FindType): Removed the `num_type_args' argument; we now
4978 encode the number of type arguments in the type name.
4980 * expression.cs (Expression.MemberLookup): Removed the
4981 `num_type_args' argument; we now encode the number of type
4982 arguments in the type name.
4984 * ecore.cs (SimpleName): Encode the number of type arguments in
4985 the type name itself.
4987 * generic.cs (ConstructedType): Likewise.
4989 * tree.cs (Tree.RecordDecl): Take a `string' instead of a
4990 `MemberName'; we now include the number of type parameters in the
4993 * typemanager.cs (TypeManager.CheckGeneric): Removed.
4994 (TypeManager.MemberLookup): Removed the
4995 `num_type_args' argument; we now encode the number of type
4996 arguments in the type name.
4998 2004-04-03 Martin Baulig <martin@ximian.com>
5000 * decl.cs (MemberCore.ctor): Take a MemberName instead of a sting.
5001 (MemberCore.MemberName): Moved here from MemberBase.
5002 (DeclSpace.SetParameterInfo): Just take the constraints as an
5003 ArrayList; we already have the type parameters in our
5004 `MemberName'; also do the CS0080 reporting here.
5006 * cs-parser.jay (struct_declaration): Use `member_name' instead of
5007 `IDENTIFIER opt_type_parameter_list'; when constructing our
5008 `MemberName', it'll already include our type parameters.
5009 (class_declaration, interface_declaration): Likewise.
5010 (delegate_declaration): Likewise.
5011 (MakeName): Take a MemberName and return a MemberName.
5012 The following two changes are required to avoid shift/reduce conflicts:
5013 (member_name): Don't include a TypeName anymore; ie. this is now
5014 just 'IDENTIFIER opt_type_parameter_list'.
5015 (property_declaration, event_declaration): Use a
5016 `namespace_or_type_name' instead of a `member_name'.
5018 2004-04-03 Martin Baulig <martin@ximian.com>
5020 * decl.cs (MemberName): Renamed to `TypeName' and created a new
5022 (TypeName): Formerly known as MemberName.
5024 * namespace.cs (NamespaceEntry.UsingAlias): Take a `TypeName'
5025 instead of a `MemberName'.
5027 * cs-parser.jay (namespace_or_type_name): Create a TypeName.
5028 (member_name): New rule; create a MemberName.
5030 2004-04-02 Martin Baulig <martin@ximian.com>
5032 * namespace.cs (NamespaceEntry.VerifyUsing): Added error checking
5033 (CS0305 and CS0308).
5035 2004-04-02 Martin Baulig <martin@ximian.com>
5037 * generic.cs (GenericMemberAccess.ResolveAsTypeStep): Added
5038 support for nested types.
5040 2004-04-02 Martin Baulig <martin@ximian.com>
5042 * ecore.cs (IAlias): New public interface.
5043 (TypeExpr, TypeExpression): Implement IAlias.
5044 (TypeAliasExpression): New public class.
5046 * namespace.cs (Namespace): Implement IAlias.
5047 (Namespace.Lookup): Return an IAlias instead on an object.
5048 (Namespace.DefineName): Take an IAlias instead of an object.
5049 (NamespaceEntry.AliasEntry.Resolve): Return an IAlias instead of
5051 (NamespaceEntry.UsingAlias): Take a Membername instead of an
5053 (NamespaceEntry.LookupAlias): Return an IAlias instead on an
5055 (NamespaceEntry.Lookup): Likewise.
5057 * rootcontext.cs (RootContext.LookupType): Return a TypeExpr
5060 * decl.cs (DeclSpace): Implement IAlias.
5061 (DeclSpace.LookupAlias): Return an IAlias instead of a string.
5063 * generic.cs (ConstructedType): Improved error checking.
5065 2004-04-02 Martin Baulig <martin@ximian.com>
5067 * convert.cs: Added type parameter conversions.
5070 (UnboxCast.Emit): Emit an `unbox.any' for type params.
5071 (ClassCast.Emit): If the source type is a type parameter, box it.
5072 If the target type is a type parameter, emit an `unbox.any'
5073 instead of a `classcast'.1
5075 2004-04-01 Martin Baulig <martin@ximian.com>
5077 * cs-tokenizer.cs (parse_less_than): Allow Token.DOT.
5079 2004-04-01 Martin Baulig <martin@ximian.com>
5081 * generic.cs (ConstructedType.CheckConstraints): Use
5082 Convert.ImplicitStandardConversionExists(); user-defined implicit
5083 conversions are not allowed according to the spec.
5085 2004-03-30 Martin Baulig <martin@ximian.com>
5087 * expression.cs (New): Added support for type parameters.
5090 (TypeManager.activator_type): New public static field.
5091 (TypeManager.activator_create_instance): Likewise.
5093 2004-03-30 Martin Baulig <martin@ximian.com>
5095 * typemanager.cs (TypeManager.HasConstructorConstraint): New
5098 2004-03-30 Martin Baulig <martin@ximian.com>
5100 * generic.cs (ConstructedType.CheckConstraints): Actually follow
5101 the spec here: the argument type must be convertible to the
5104 2004-03-30 Martin Baulig <martin@ximian.com>
5107 (TypeParameter.Define, TypeParameter.DefineMethod): Call
5108 TypeManager.AddTypeParameter().
5109 (ConstructedType.CheckConstraints): Re-enable this and actually
5110 check whether we have a constructor constraint.
5113 (TypeManager.builder_to_type_param): New static field.
5114 (TypeManager.AddTypeParameter): New static method.
5115 (TypeManager.LookupTypeParameter): New public method.
5117 2004-03-30 Martin Baulig <martin@ximian.com>
5119 * generic.cs (TypeParameter.DefineType): Return a boolean and use
5120 the new API to actually define the constructor constraint.
5123 (TypeManager.new_constraint_attr_type): New static field.
5124 (TypeManager.InitCoreTypes): Initialize it.
5126 2004-03-30 Martin Baulig <martin@ximian.com>
5128 * generic.cs (Constraints): Completed error checking, use correct
5131 2004-03-29 Martin Baulig <martin@ximian.com>
5133 * delegate.cs (Delegate.VerifyMethod): Infer type arguments.
5135 * expression.cs (Invocation.InferTypeArguments): Added overloaded
5136 public version which takes a `ParameterData pd' instead of an
5139 2004-03-29 Martin Baulig <martin@ximian.com>
5141 * typemanager.cs (TypeManager.IsGenericMethod): Take a MethodBase,
5144 2004-03-29 Martin Baulig <martin@ximian.com>
5146 * expression.cs (Argument.ResolveMethodGroup): If we're a
5147 ConstructedType, call GetMemberAccess() on it.
5149 2004-03-29 Martin Baulig <martin@ximian.com>
5151 * class.cs (MethodBase.CheckGenericOverride): New abstract method.
5152 (MethodCore.CheckGenericOverride): When overriding a generic
5153 method, check whether the constraints match.
5155 * support.cs (GenericConstraints): New public interface.
5156 (ParameterData.GenericConstraints): New public method.
5158 * parameter.cs (Parameter.Resolve): Check whether we're a generic
5159 method parameter and compute our constraints if appropriate.
5160 (Parameter.GenericConstraints): New public property.
5162 * generic.cs (Constraints): Implement GenericConstraints.
5164 2004-03-29 Martin Baulig <martin@ximian.com>
5166 * decl.cs (MemberCache.FindMemberToOverride): Use
5167 `paramTypes [j].Equals (cmpAttrs [j])' instead of `=='.
5169 2004-03-29 Martin Baulig <martin@ximian.com>
5171 * generic.cs (GenericMethod.Define): Resolve our type parameters.
5173 2004-03-29 Martin Baulig <martin@ximian.com>
5175 * cs-parser.jay: Report CS0080 instead of -200 ("Constraints are
5176 not allowed on non-generic declarations").
5178 2004-03-29 Martin Baulig <martin@ximian.com>
5180 * expression.cs (Invocation.InferTypeArguments): Added overloaded
5181 public version of this method.
5183 * class.cs (MethodCore.IsDuplicateImplementation): Use
5184 Invocation.InferTypeArguments() to check this.
5186 2004-03-29 Martin Baulig <martin@ximian.com>
5188 * convert.cs: Use TypeManager.IsDelegateType() instead of
5189 comparing types correctly.
5191 2004-03-29 Martin Baulig <martin@ximian.com>
5193 * convert.cs: Use TypeManager.IsSubclassOf() instead of comparing
5194 types directly to make it work for generic instances.
5196 * typemanager.cs (TypeManager.IsSubclassOf): New static method.
5198 2004-03-29 Martin Baulig <martin@ximian.com>
5200 * typemanager.cs (TypeManager.MayBecomeEqualGenericTypes): Added
5203 2004-03-24 Martin Baulig <martin@ximian.com>
5205 * decl.cs (DeclSpace.FindType): Also use
5206 TypeManager.CheckGeneric() for types from the using clauses.
5208 2004-03-23 Martin Baulig <martin@ximian.com>
5210 * expression.cs (Invocation.OverloadResolve): Added `bool
5211 may_fail' argument and use it instead of the Location.IsNull() hack.
5213 2004-03-23 Martin Baulig <martin@ximian.com>
5215 * expression.cs (Invocation.InferType): Use correct type inference
5218 2004-03-23 Martin Baulig <martin@ximian.com>
5220 * ecore.cs (MethodGroupExpr.Name): Use
5221 TypeManager.CSharpSignature() instead of just the name.
5223 * expression.cs (Invocation.OverloadResolve): Provide better error
5225 (Invocation.DoResolve): OverloadResolve() never returns null
5226 without reporting an error, so removed the error -6 reporting here.
5228 2004-03-23 Martin Baulig <martin@ximian.com>
5230 * typemanager.cs (TypeManager.GetMethodFlags): Fixed the FIXME for
5233 * cs-parser.jay (delegate_declaration): Support generic delegates.
5235 * delegate.cs: Support generic delegates.
5237 2004-03-22 Martin Baulig <martin@ximian.com>
5239 * expression.cs (Invocation.InferParamsTypeArguments): New static
5240 method; does type inference for params arguments.
5242 2004-03-21 Martin Baulig <martin@ximian.com>
5244 * typemanager.cs (TypeManager.IsGenericMethod): New public static
5245 method; checks whether a method is a generic method.
5247 * expression.cs (Invocation.InferTypeArguments): New static method;
5248 infer type arguments for generic method invocation.
5250 * ecore.cs (MethodGroupExpr.HasTypeArguments): New public
5251 property; we set this to true if we're resolving a generic method
5252 invocation and the user specified type arguments, ie. we're not
5253 doing type inference.
5255 2004-03-20 Martin Baulig <martin@ximian.com>
5257 * class.cs (MethodData.DeclaringType): New public property.
5258 (MethodData.Define): Set DeclaringType here.
5259 (Operator.Define): Use OperatorMethod.MethodData.DeclaringType
5260 instead of OperatorMethodBuilder.DeclaringType.
5262 2004-03-20 Martin Baulig <martin@ximian.com>
5264 * cs-tokenizer.cs (xtoken): Return a special
5265 Token.DEFAULT_OPEN_PARENS for "`default' followed by open parens".
5267 * cs-parser.jay (default_value_expression): Switch to the new
5270 2004-03-19 Martin Baulig <martin@ximian.com>
5272 * decl.cs (MemberName): New class. We use this to "construct"
5273 namespace_or_type_name's.
5275 * generics.cs (TypeArguments.GetDeclarations): New public method;
5276 returns the type arguments as a string[] and reports a CS0081 if
5277 one of them is not an identifier.
5279 * class.cs (MemberBase): The .ctor now takes the name as a
5280 MemberName instead of a string.
5281 (MemberBase.ExplicitInterfaceName): Changed type from string to
5283 (MemberBase.DoDefine): If we're an explicit implementation, the
5284 InterfaceType may be a generic instance.
5286 * cs-parser.jay (namespace_or_type_name): Return a MemberName.
5287 (namespace_name): Call MemberName.GetName () to transform the
5288 MemberName into a string and ensure we don't have any type
5290 (type_name): Call MemberName.GetTypeExpression() to transfrom the
5291 MemberName into an expression.
5292 (method_header): Use namespace_or_type_name instead of member_name.
5294 2004-04-07 Miguel de Icaza <miguel@ximian.com>
5296 * rootcontext.cs: Add new types to the boot resolution.
5298 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
5299 MulticastDelegate is not allowed.
5301 * typemanager.cs: Add new types to lookup: System.TypedReference
5304 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
5305 check for TypedReference or ArgIterator, they are not allowed.
5307 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
5308 makes us properly catch 1510 in some conditions (see bug 56016 for
5311 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
5313 * CryptoConvert.cs: update from corlib version
5316 2004-04-05 Miguel de Icaza <miguel@ximian.com>
5318 * class.cs (Indexer.Define): Check indexername declaration
5320 2004-04-05 Marek Safar <marek.safar@seznam.cz>
5322 * attribute.cs (IsClsCompliant): Fixed problem with handling
5323 all three states (compliant, not-compliant, undetected).
5325 2004-03-30 Marek Safar <marek.safar@seznam.cz>
5327 * attribute.cs (Attribute): Location is now public.
5328 (Resolve): Store resolved arguments (pos_values) in attribute class.
5329 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
5330 (GetClsCompliantAttributeValue): New method that gets
5331 CLSCompliantAttribute value.
5332 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
5333 if exists else null.
5334 (AttributeTester): New class for CLS-Compliant verification routines.
5336 * class.cs (Emit): Add CLS-Compliant verification.
5337 (Method.GetSignatureForError): Implemented.
5338 (Constructor.GetSignatureForError): Implemented
5339 (Constructor.HasCompliantArgs): Returns if constructor has
5340 CLS-Compliant arguments.
5341 (Constructor.Emit): Override.
5342 (Construcor.IsIdentifierClsCompliant): New method; For constructors
5343 is needed to test only parameters.
5344 (FieldBase.GetSignatureForError): Implemented.
5345 (TypeContainer): New member for storing base interfaces.
5346 (TypeContainer.FindMembers): Search in base interfaces too.
5348 * codegen.cs (GetClsComplianceAttribute): New method that gets
5349 assembly or module CLSCompliantAttribute value.
5350 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
5352 (ModuleClass.Emit): Add error 3012 test.
5354 * const.cs (Emit): Override and call base for CLS-Compliant tests.
5356 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
5357 state for all decl types.
5358 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
5359 if CLS-Compliant tests are required.
5360 (IsClsCompliaceRequired): New method. Analyze whether code
5361 must be CLS-Compliant.
5362 (IsExposedFromAssembly): New method. Returns true when MemberCore
5363 is exposed from assembly.
5364 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
5365 value or gets cached value.
5366 (HasClsCompliantAttribute): New method. Returns true if MemberCore
5367 is explicitly marked with CLSCompliantAttribute.
5368 (IsIdentifierClsCompliant): New abstract method. This method is
5369 used to testing error 3005.
5370 (IsIdentifierAndParamClsCompliant): New method. Common helper method
5371 for identifier and parameters CLS-Compliant testing.
5372 (VerifyClsCompliance): New method. The main virtual method for
5373 CLS-Compliant verifications.
5374 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
5375 null. I don't know why is null (too many public members !).
5376 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
5377 and get value of first CLSCompliantAttribute that found.
5379 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
5380 (VerifyClsCompliance): Override and add extra tests.
5382 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
5383 clscheck- disable CLS-Compliant verification event if assembly is has
5384 CLSCompliantAttribute(true).
5386 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
5387 ApllyAttribute is now called in emit section as in the other cases.
5388 Possible future Emit integration.
5389 (IsIdentifierClsCompliant): New override.
5390 (VerifyClsCompliance): New override.
5391 (GetEnumeratorName): Returns full enum name.
5393 * parameter.cs (GetSignatureForError): Implemented.
5395 * report.cs (WarningData): New struct for Warning message information.
5396 (LocationOfPreviousError): New method.
5397 (Warning): New method. Reports warning based on the warning table.
5398 (Error_T): New method. Reports error based on the error table.
5400 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
5401 verifications are done here.
5403 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
5405 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
5406 CLSCompliantAttribute.
5407 (all_imported_types): New member holds all imported types from other
5409 (LoadAllImportedTypes): New method fills static table with exported types
5410 from all referenced assemblies.
5411 (Modules): New property returns all assembly modules.
5413 2004-03-30 Miguel de Icaza <miguel@ximian.com>
5415 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
5416 throwing a parser error.
5418 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
5419 which removes the hardcoded get_/set_ prefixes for properties, as
5420 IL allows for the properties to be named something else.
5424 * expression.cs: Do not override operand before we know if it is
5427 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
5429 * typemanager.cs: support for pinned variables.
5431 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
5433 * decl.cs, typemanager.cs: Avoid using an arraylist
5434 as a buffer if there is only one result set.
5436 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
5438 * expression.cs: Make sure you cant call a static method
5439 with an instance expression, bug #56174.
5441 2004-03-29 Miguel de Icaza <miguel@ximian.com>
5443 * class.cs (IsDuplicateImplementation): Improve error reporting to
5444 flag 663 (method only differs in parameter modifier).
5446 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
5447 in preprocessor directives.
5449 * location.cs (LookupFile): Allow for the empty path.
5451 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
5452 better approach for some of that patch, but its failing with the
5453 CharSet enumeration. For now try/catch will do.
5455 * typemanager.cs: Do not crash if a struct does not have fields.
5458 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
5460 * expression.cs: cs0213, cant fix a fixed expression.
5463 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
5465 * cs-parser.jay: detect invalid embeded statements gracefully.
5468 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
5470 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
5473 the invocation type may not be a subclass of the tye of the item/
5474 The type of the item must be a subclass of the invocation item.
5479 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
5481 * attribute.cs: Added methods to get a string and a bool from an
5482 attribute. Required to information from AssemblyKeyFileAttribute,
5483 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
5484 * codegen.cs: Modified AssemblyName creation to include support for
5485 strongnames. Catch additional exceptions to report them as CS1548.
5486 * compiler.csproj: Updated include CryptoConvert.cs.
5487 * compiler.csproj.user: Removed file - user specific configuration.
5488 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
5489 Mono.Security assembly. The original class is maintained and tested in
5490 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
5491 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
5492 like CSC 8.0 (C# v2) supports.
5493 * Makefile: Added CryptoConvert.cs to mcs sources.
5494 * rootcontext.cs: Added new options for strongnames.
5496 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
5498 * driver.cs: For --expect-error, report error code `2'
5499 if the program compiled with no errors, error code `1' if
5500 it compiled with an error other than the one expected.
5502 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
5504 * compiler.csproj: Updated for Visual Studio .NET 2003.
5505 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
5506 * compiler.sln: Updated for Visual Studio .NET 2003.
5508 2004-03-24 Ravi Pratap M <ravi@ximian.com>
5510 * expression.cs: Fix bug #47234. We basically need to apply the
5511 rule that we prefer the conversion of null to a reference type
5512 when faced with a conversion to 'object' (csc behaviour).
5514 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
5516 * statement.cs: Shorter form for foreach, eliminates
5517 a local variable. r=Martin.
5519 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
5521 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
5522 checks if we can use brtrue/brfalse to test for 0.
5523 * expression.cs: use the above in the test for using brtrue/brfalse.
5526 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
5528 * expression.cs: Rewrite string concat stuff. Benefits:
5530 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
5531 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
5532 rather than a concat chain.
5534 * typemanager.cs: Add lookups for more concat overloads.
5536 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
5538 * expression.cs: Emit shorter il code for array init.
5555 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
5557 * statement.cs: Before, two switch blocks would be merged if the
5558 total size of the blocks (end_item - begin_item + 1) was less than
5559 two times the combined sizes of the blocks.
5561 Now, it will only merge if after the merge at least half of the
5566 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
5568 * class.cs : csc build fix for GetMethods(). See bug #52503.
5570 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
5572 * expression.cs: Make sure fp comparisons work with NaN.
5573 This fixes bug #54303. Mig approved this patch a long
5574 time ago, but we were not able to test b/c the runtime
5577 2004-03-19 Miguel de Icaza <miguel@ximian.com>
5579 * ecore.cs (TypExpr.GetHashCode): implement this overload.
5581 2004-03-19 Martin Baulig <martin@ximian.com>
5583 * class.cs (MemberCore.IsDuplicateImplementation): Check whether
5584 two overloads may unify for some type parameter substitutions and
5585 report a CS0408 if appropriate.
5587 2004-03-19 Martin Baulig <martin@ximian.com>
5589 * class.cs (MemberCore.IsDuplicateImplementation): Report the
5590 error here and not in our caller.
5592 2004-03-19 Martin Baulig <martin@ximian.com>
5594 * interface.cs: Completely killed this file.
5595 (Interface): We're now a TypeContainer and live in class.cs.
5597 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
5598 argument; we're now also called for interfaces.
5599 (TypeContainer.DefineMembers): Allow this method being called
5601 (TypeContainer.GetMethods): New public method; formerly known as
5602 Interface.GetMethod(). This is used by PendingImplementation.
5603 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
5604 it's now private and non-static.
5605 (Interface): Moved this here; it's now implemented similar to
5607 (Method, Property, Event, Indexer): Added `bool is_interface'
5608 argument to their .ctor's.
5609 (MemberBase.IsInterface): New public field.
5611 * cs-parser.jay: Create normal Method, Property, Event, Indexer
5612 instances instead of InterfaceMethod, InterfaceProperty, etc.
5613 (opt_interface_base): Removed; we now use `opt_class_base' instead.
5614 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
5616 2004-03-19 Martin Baulig <martin@ximian.com>
5618 * class.cs (MethodCore.IsDuplicateImplementation): New private
5619 method which does the CS0111 checking.
5620 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
5621 Use IsDuplicateImplementation().
5623 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
5625 * decl.cs (FindMemberToOverride): New method to find the correct
5626 method or property to override in the base class.
5628 - Make Method/Property use the above method to find the
5629 version in the base class.
5630 - Remove the InheritableMemberSignatureCompare as it is now
5633 This patch makes large code bases much faster to compile, as it is
5634 O(n) rather than O(n^2) to do this validation.
5636 Also, it fixes bug 52458 which is that nested classes are not
5637 taken into account when finding the base class member.
5639 Reviewed/Approved by Martin.
5641 2004-03-17 Martin Baulig <martin@ximian.com>
5643 * expression.cs (MemberAccess.DoResolve): Take the parent's number
5644 of type arguments into account; use the `real_num_type_args'
5645 approach like in DoResolveAsTypeStep().
5647 * generic.cs (GenericMemberAccess.DoResolve): Make this work for
5650 2004-03-17 Marek Safar <marek.safar@seznam.cz>
5652 * interface.cs: In all interface classes removed redundant
5653 member initialization.
5655 2004-03-16 Martin Baulig <martin@ximian.com>
5657 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
5659 2004-03-15 Miguel de Icaza <miguel@ximian.com>
5661 * decl.cs (DefineTypeAndParents): New helper method to define a
5662 type's containers before the type itself is defined; This is a
5663 bug exposed by the recent changes to Windows.Forms when an
5664 implemented interface was defined inside a class that had not been
5667 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
5669 (Check): Loop correctly to report errors modifiers
5670 (UNSAFE was not in the loop, since it was the same as TOP).
5672 * interface.cs: Every interface member now takes a ModFlags,
5673 instead of a "is_new" bool, which we set on the base MemberCore.
5675 Every place where we called "UnsafeOk" in the interface, now we
5676 call the proper member (InterfaceMethod.UnsafeOK) instead to get
5677 the unsafe settings from the member declaration instead of the
5678 container interface.
5680 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
5682 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
5683 `set_indexer_name' to the pending bits (one per type).
5685 We fixed a bug today that was picking the wrong method to
5686 override, since for properties the existing InterfaceMethod code
5687 basically ignored the method name. Now we make sure that the
5688 method name is one of the valid indexer names.
5690 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
5692 * support.cs (SeekableStreamReader): Keep track of stream byte
5693 positions and don't mix them with character offsets to the buffer.
5695 Patch from Gustavo Giráldez
5697 2004-03-15 Marek Safar <marek.safar@seznam.cz>
5699 * interface.cs (InterfaceSetGetBase): Removed double member
5700 initialization, base class does it as well.
5702 2004-03-13 Martin Baulig <martin@ximian.com>
5704 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
5705 when compiling corlib.
5707 2004-03-13 Miguel de Icaza <miguel@ximian.com>
5709 * convert.cs (ExplicitConversion): We were reporting an error on
5710 certain conversions (object_type source to a value type, when the
5711 expression was `null') before we had a chance to pass it through
5712 the user defined conversions.
5714 * driver.cs: Replace / and \ in resource specifications to dots.
5717 * class.cs: Add check for duplicate operators. Fixes 52477
5719 2004-03-11 Miguel de Icaza <miguel@ximian.com>
5721 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
5722 that are in the middle of the statements, not only at the end.
5725 * class.cs (TypeContainer.AddField): No longer set the
5726 `HaveStaticConstructor' flag, now we call it
5727 `UserDefineStaticConstructor' to diferentiate the slightly
5728 semantic difference.
5730 The situation is that we were not adding BeforeFieldInit (from
5731 Modifiers.TypeAttr) to classes that could have it.
5732 BeforeFieldInit should be set to classes that have no static
5737 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
5739 And most importantly Zoltan's comment:
5741 http://bugzilla.ximian.com/show_bug.cgi?id=44229
5743 "I think beforefieldinit means 'it's ok to initialize the type sometime
5744 before its static fields are used', i.e. initialization does not need
5745 to be triggered by the first access to the type. Setting this flag
5746 helps the JIT to compile better code, since it can run the static
5747 constructor at JIT time, and does not need to generate code to call it
5748 (possibly lots of times) at runtime. Unfortunately, mcs does not set
5749 this flag for lots of classes like String.
5751 csc sets this flag if the type does not have an explicit static
5752 constructor. The reasoning seems to be that if there are only static
5753 initalizers for a type, and no static constructor, then the programmer
5754 does not care when this initialization happens, so beforefieldinit
5757 This bug prevents the AOT compiler from being usable, since it
5758 generates so many calls to mono_runtime_class_init that the AOT code
5759 is much slower than the JITted code. The JITted code is faster,
5760 because it does not generate these calls if the vtable is type is
5761 already initialized, which is true in the majority of cases. But the
5762 AOT compiler can't do this."
5764 2004-03-10 Miguel de Icaza <miguel@ximian.com>
5766 * class.cs (MethodData.Emit): Refactor the code so symbolic
5767 information is generated for destructors; For some reasons we
5768 were taking a code path that did not generate symbolic information
5771 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
5773 * class.cs: Create a Constructor.CheckBase method that
5774 takes care of all validation type code. The method
5775 contains some code that was moved from Define.
5777 It also includes new code that checks for duplicate ctors.
5778 This fixes bug #55148.
5780 2004-03-09 Joshua Tauberer <tauberer@for.net>
5782 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
5783 a { ... }-style array creation invokes EmitStaticInitializers
5784 which is not good for reference-type arrays. String, decimal
5785 and now null constants (NullCast) are not counted toward
5786 static initializers.
5788 2004-03-05 Martin Baulig <martin@ximian.com>
5790 * location.cs (SourceFile.HasLineDirective): New public field;
5791 specifies whether the file contains or is referenced by a "#line"
5793 (Location.DefineSymbolDocuments): Ignore source files which
5794 either contain or are referenced by a "#line" directive.
5796 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
5798 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
5799 direct access to our parent, so check the method inline there.
5801 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
5803 * expression.cs (Invocation.EmitCall): Miguel's last commit
5804 caused a regression. If you had:
5809 In Foo the implict this would be null.
5811 2004-02-27 Miguel de Icaza <miguel@ximian.com>
5813 * expression.cs (Invocation.EmitCall): If the method is not
5814 virtual, do not emit a CallVirt to it, use Call.
5816 * typemanager.cs (GetFullNameSignature): Improve the method to
5817 cope with ".ctor" and replace it with the type name.
5819 * class.cs (ConstructorInitializer.Resolve): Now the method takes
5820 as an argument the ConstructorBuilder where it is being defined,
5821 to catch the recursive constructor invocations.
5823 2004-03-16 Martin Baulig <martin@ximian.com>
5825 * expression.cs (MemberAccess.DoResolve): If `expr' resolved to a
5826 ConstructedType, call ResolveType() on it to get the type rather
5827 than just using `expr.Type'.
5829 2004-03-16 Martin Baulig <martin@ximian.com>
5831 * generics.cs (ConstructedType.GetMemberAccess): Take the
5832 EmitContext instead on the TypeExpr and use
5833 ec.TypeContainer.CurrentType/ec.ContainerType.
5835 2004-03-16 Martin Baulig <martin@ximian.com>
5837 * ecore.cs (SimpleName.DoResolveAsTypeStep): Lookup type
5838 parameters before aliases.
5840 2004-03-16 Martin Baulig <martin@ximian.com>
5842 * typemanager.cs (TypeManager.MayBecomeEqualGenericInstances):
5843 New oublic function; checks whether two generic instances may become
5844 equal under some instantiations (26.3.1).
5846 * class.cs (TypeContainer.Define): Call
5847 TypeManager.MayBecomeEqualGenericInstances() and report CS0695 on
5850 2004-03-16 Martin Baulig <martin@ximian.com>
5852 * class.cs (TypeContainer.GetClassBases): Moved
5853 Error_TypeParameterAsBase() here and also check whether the base
5854 class is not an attribute.
5856 2004-03-16 Martin Baulig <martin@ximian.com>
5858 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
5860 2004-03-16 Martin Baulig <martin@ximian.com>
5862 * class.cs (Error_TypeParameterAsBase): Use correct error number
5865 2004-03-16 Martin Baulig <martin@ximian.com>
5867 * decl.cs (DeclSpace.ResolveTypeExpr): Added more error checking
5870 * generics.cs (ConstructedType.DoResolveAsTypeStep): Added better
5873 2004-03-15 Martin Baulig <martin@ximian.com>
5875 * typemanager.cs (TypeManager.GetFullName): New public method.
5876 (TypeManager.MemberLookup): Added `int_num_type_arguments'
5877 argument; only return members with the correct number of type
5879 (TypeManager.CheckGeneric): Allow -1 to bypass the check.
5880 (TypeManager.FilterWithClosure): Call CheckGeneric() to check
5881 whether the number of type arguments matches.
5883 * generic.cs (GenericMemberAccess.ResolveAsTypeStep): Allow `expr'
5884 not being a ConstructedType; we can now do "typeof (Foo.Bar<U>)".
5886 * expression.cs (MemberAccess): Added public `NumTypeArguments'
5887 field; it's set by the protected .ctor when we're actually a
5888 GenericMemberAccess.
5889 (MemberAccess.ResolveAsTypeStep): Compute the total number of type
5890 arguments and pass it to MemberLookupFinal ().
5892 * ecore.cs (Expression.MemberLookup): Added `int
5893 num_type_arguments' argument; only return members with the correct
5894 number of type arguments.
5895 (Expression.MemberLookupFailed): Check whether the MemberLookup
5896 failed because we did not have the correct number of type
5897 arguments; report CS0305 in this case.
5899 * decl.cs (DeclSpace.ResolveTypeExpr): Don't report an error if
5900 `e.ResolveAsTypeTerminal()' already did so.
5902 2004-03-15 Martin Baulig <martin@ximian.com>
5904 * ecore.cs (Expression.ResolveLValue): Allow e.type being null if
5905 we're a ConstructedType; in this case, the caller must report an
5906 error (for instance CS0131).
5908 * generic.cs (TypeArguments): Added Location argument to the .ctor.
5909 (TypeArguments.Resolve): Actually report errors here.
5911 2004-03-15 Miguel de Icaza <miguel@ximian.com>
5913 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
5914 `set_indexer_name' to the pending bits (one per type).
5916 We fixed a bug today that was picking the wrong method to
5917 override, since for properties the existing InterfaceMethod code
5918 basically ignored the method name. Now we make sure that the
5919 method name is one of the valid indexer names.
5921 2004-03-15 Martin Baulig <martin@ximian.com>
5923 * typemanager.cs (TypeManager.IndexerPropertyName): Added support
5924 for generic instances.
5926 2004-03-13 Martin Baulig <martin@ximian.com>
5928 * class.cs (TypeContainer.DefineType): Call
5929 TypeManager.AddUserType() immediately after creating the
5930 TypeBuilder; pass all type parameters when creating the
5933 * decl.cs (DeclSpace.FindNestedType): New public method.
5934 (DeclSpace.FindType): Added `int num_type_args' argument; only
5935 return types with the correct number of type parameters.
5936 (DeclSpace.CountTypeParams): New public property.
5938 * ecore.cs (SimpleName.ctor): Added overloaded version which takes
5939 the number of type parameters; defaults to zero.
5941 * generic.cs (TypeArguments.Count): New public property.
5942 (ConstructedType.DoResolveAsTypeStep): First call
5943 ds.FindNestedType() to find out whether we're nested in the
5944 current generic type; in this case, we inherit all type parameters
5945 from the current class.
5947 * rootcontext.cs (RootContext.NamespaceLookup): Added `int
5948 num_type_args' argument.
5949 (RootContext.LookupType): Added overloaded version which takes the
5950 number of type arguments; only return types with the correct
5951 number of type arguments.
5953 * typemanager.cs (TypeManager.CheckGeneric): New public function;
5954 checks whether `Type t' has `int num_type_args'.
5956 2004-03-13 Martin Baulig <martin@ximian.com>
5958 * generic.cs (GenericMethod.DefineType): New method; calls
5959 DefineType() on all the type parameters.
5961 * class.cs (MethodData.ctor): Added `GenericMethod generic' argument.
5962 (MethodData.Define): If we're a generic method, call
5963 GenericMethod.DefineType() to define the type parameters.
5965 2004-03-10 Martin Baulig <martin@ximian.com>
5967 * pending.cs (Pending.InterfaceMethod): Use TypeManager.IsEqual()
5968 instead of IsAssignableFrom.
5970 2004-03-10 Martin Baulig <martin@ximian.com>
5972 * ecore.cs (FieldExpr.ctor): Use TypeManager.TypeToCoreType().
5974 * support.cs (ParameterData.HasArrayParameter): New property.
5975 (ReflectionParameters.ctor): Take a MethodBase instead of a
5976 ParameterInfo[]. If we have any type parameters, get the generic
5977 method definition and ask it whether we have variable arguments.
5979 2004-02-26 Miguel de Icaza <miguel@ximian.com>
5981 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
5982 routines to check if a type is an enumerable/enumerator allow
5983 classes that implement the IEnumerable or IEnumerator interfaces.
5985 * class.cs (Property, Operator): Implement IIteratorContainer, and
5986 implement SetYields.
5988 (Property.Define): Do the block swapping for get_methods in the
5989 context of iterators. We need to check if Properties also
5990 include indexers or not.
5992 (Operator): Assign the Block before invoking the
5993 OperatorMethod.Define, so we can trigger the Iterator code
5996 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
5997 Property and Operator classes are not created when we parse the
5998 declarator but until we have the block completed, so we use a
5999 singleton SimpleIteratorContainer.Simple to flag whether the
6000 SetYields has been invoked.
6002 We propagate this setting then to the Property or the Operator to
6003 allow the `yield' to function.
6005 2004-02-25 Marek Safar <marek.safar@seznam.cz>
6007 * codegen.cs: Implemented attribute support for modules.
6008 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
6009 Assembly/Module functionality.
6011 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
6012 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
6013 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
6015 2004-02-16 Marek Safar <marek.safar@seznam.cz>
6017 * interface.cs (FindMembers): The operation is performed on all base
6018 interfaces and not only on the first. It is required for future CLS Compliance patch.
6020 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
6022 * statement.cs, codegen.cs:
6023 This patch deals with patterns such as:
6025 public class List : IEnumerable {
6027 public MyEnumerator GetEnumerator () {
6028 return new MyEnumerator(this);
6031 IEnumerator IEnumerable.GetEnumerator () {
6035 public struct MyEnumerator : IEnumerator {
6040 Before, there were a few things we did wrong:
6041 1) we would emit callvirt on a struct, which is illegal
6042 2) we emited ldarg when we needed to emit ldarga
6043 3) we would mistakenly call the interface methods on an enumerator
6044 type that derived from IEnumerator and was in another assembly. For example:
6046 public class MyEnumerator : IEnumerator
6048 Would have the interface methods called, even if there were public impls of the
6049 method. In a struct, this lead to invalid IL code.
6051 2004-02-11 Marek Safar <marek.safar@seznam.cz>
6053 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
6056 * delegate.cs (Define): Fixed crash when delegate type is undefined.
6058 2004-02-11 Miguel de Icaza <miguel@ximian.com>
6060 * cs-parser.jay: Fix small regression: we were not testing V2
6061 compiler features correctly.
6063 * interface.cs: If the emit context is null, then create one
6065 2004-02-09 Marek Safar <marek.safar@seznam.cz>
6067 * decl.cs (GetSignatureForError): New virtual method to get full name
6070 * attribute.cs (IAttributeSupport): New interface for attribute setting.
6071 Now it is possible to rewrite ApplyAttributes method to be less if/else.
6073 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
6074 Duplicated members and code in these classes has been removed.
6075 Better encapsulation in these classes.
6077 2004-02-07 Miguel de Icaza <miguel@ximian.com>
6079 * assign.cs (Assign.DoResolve): When dealing with compound
6080 assignments, there is a new rule in ECMA C# 2.4 (might have been
6081 there before, but it is documented here) that states that in:
6085 If b is of type int, and the `op' is a shift-operator, then the
6086 above is evaluated as:
6090 * expression.cs (Binary.ResolveOperator): Instead of testing for
6091 int/uint/long/ulong, try to implicitly convert to any of those
6092 types and use that in pointer arithmetic.
6094 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
6095 method to print information for from the type, not from the
6096 null-method we were given.
6098 2004-02-01 Duncan Mak <duncan@ximian.com>
6100 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
6101 parsing for cmd, fixes bug #53694.
6103 2004-02-04 Marek Safar <marek.safar@seznam.cz>
6105 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
6106 in the member name duplication tests. Property and operator name duplication
6107 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
6109 2004-02-03 Marek Safar <marek.safar@seznam.cz>
6111 * interface.cs (PopulateMethod): Fixed crash when interface method
6112 returns not existing type (error test cs0246-3.cs).
6114 2004-02-02 Ravi Pratap M <ravi@ximian.com>
6116 * cs-parser.jay (interface_accessors): Re-write actions to also
6117 store attributes attached to get and set methods. Fix spelling
6120 (inteface_property_declaration): Modify accordingly.
6122 (InterfaceAccessorInfo): New helper class to store information to pass
6123 around between rules that use interface_accessors.
6125 * interface.cs (Emit): Apply attributes on the get and set
6126 accessors of properties and indexers too.
6128 * attribute.cs (ApplyAttributes): Modify accordingly to use the
6129 right MethodBuilder when applying attributes to the get and set accessors.
6131 2004-01-31 Miguel de Icaza <miguel@ximian.com>
6133 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
6135 2004-01-26 Miguel de Icaza <miguel@ximian.com>
6137 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
6139 2004-01-25 Miguel de Icaza <miguel@ximian.com>
6141 * cs-parser.jay: Remove YIELD token, instead use the new grammar
6142 changes that treat `yield' specially when present before `break'
6145 * cs-tokenizer.cs: yield is no longer a keyword.
6147 2004-01-23 Marek Safar <marek.safar@seznam.cz>
6149 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
6150 setting for default constructors.
6151 For default constructors are almost every time set wrong Modifier. The
6152 generated IL code has been alright. But inside mcs this values was
6153 wrong and this was reason why several of my CLS Compliance tests
6156 2004-02-27 Martin Baulig <martin@ximian.com>
6158 * generics.cs (ConstructedType.ResolveType): Make the nested type
6159 stuff actually work.
6161 2004-02-25 Martin Baulig <martin@ximian.com>
6163 * decl.cs (DeclSpace.CurrentTypeParameters): New protected
6164 property; returns the type parameters just from the current type,
6165 ie. with the ones from outer classes.
6166 (DeclSpace.LookupGeneric): First search in the current class, then
6168 (DeclSpace.initialize_type_params): When hiding a type parameter
6169 from an outer class, put it into the `type_param_list' anyways.
6171 * expression.cs (MemberAccess.expr): Made this field protected.
6173 * class.cs (TypeContainer.Define): The `CurrentType' just contains
6174 the type parameters from the current class.
6176 * generic.cs (ConstructedType.ResolveType): Support nested generic
6177 types by taking the type parameters which we inherit from outer
6178 classes into account.
6179 (GenericMemberAccess.ResolveAsTypeStep): Override this and added
6180 support for nested generic types.
6182 2004-02-23 Martin Baulig <martin@ximian.com>
6184 * decl.cs (DeclSpace.IsGeneric): Make this a property instead of a
6185 field and check whether we're nested inside a generic type.
6186 (DeclSpace.ResolveType): If we're resolving to a generic type
6187 definition, create a ConstructedType and return its resolved type.
6188 (DeclSpace.initialize_type_params): New private method;
6189 initializes the `type_param_list' field from the type parameters
6190 from this and all enclosing classes.
6191 (DeclSpace.TypeParameters): Call initialize_type_params() unless
6192 we're already initialized.
6194 2004-02-23 Martin Baulig <martin@ximian.com>
6196 * class.cs (Method.Define): Create the generic method before
6198 (Memberbase.DoDefine): Added DeclSpace argument (in addition to
6199 the TypeContainer one); we use this for generic methods.
6201 * decl.cs (CheckAccessLevel): If we're a GenericMethod, use our
6202 parent's TypeBuilder.
6204 2004-02-18 Martin Baulig <martin@ximian.com>
6206 * ecore.cs (FieldExpr.DoResolveLValue): Use TypeManager.IsEqual()
6207 to check for equality.
6209 2004-02-05 Martin Baulig <martin@ximian.com>
6211 * ecore.cs (FieldExpr.DoResolveLValue): If we have an
6212 `ec.TypeContainer.CurrentType', use it instead of
6213 `ec.ContainerType' to check whether we're in the type's ctor.
6215 2004-01-29 Martin Baulig <martin@ximian.com>
6217 * expression.cs (Invocation.DoResolve): If we're a
6218 `ConstructedType', then we're actually a generic method, so
6219 rewrite the expr as a GenericMemberAccess.
6221 * cs-parser.jay (member_name): Don't use `namespace_or_type_name'
6222 here; manually parse it into a string.
6224 2004-01-28 Martin Baulig <martin@ximian.com>
6226 * typemanager.cs (TypeManager.IsEqual): New static method.
6227 (TypeManager.FilterWithClosure): Call TypeManager.IsEqual() to
6228 check for equality instead of using `=='.
6230 2004-01-26 Martin Baulig <martin@ximian.com>
6232 * decl.cs (DeclSpace.CurrentType): New public field.
6234 * expression.cs (This.ResolveBase): If we have an
6235 `ec.TypeContainer.CurrentType', use it instead of
6238 * class.cs (TypeContainer.DefineType): If we're a generic type,
6239 create the `CurrentType' (unresolved).
6240 (TypeContainer.GenericType): New private field.
6241 (TypeContainer.DefineMembers): If we have a `CurrentType', resolve
6242 it and store it in `GenericType' before creating the MemberCache.
6243 (TypeContainer.GetMembers): If we have a `GenericType', call
6244 TypeManager.FindMembers() on it.
6246 * interface.cs (Interface.GenericType): New private field.
6247 (Interface.DefineType): If we're a generic type, create the
6248 `CurrentType' (unresolved).
6249 (Interface.DefineMembers): If we have a `CurrentType', resolve it
6250 and store it in `GenericType' before creating the MemberCache.
6251 (Interface.GetMembers): If we have a `GenericType', call
6252 TypeManager.FindMembers() on it.
6254 2004-01-22 Martin Baulig <martin@ximian.com>
6256 * cs-parser.jay (namespace_or_type_name): Return an Expression,
6257 not a QualifiedIdentifier. This is what `type_name_expression'
6258 was previously doing.
6259 (type_name_expression): Removed; the code is now in
6260 `namespace_or_type_name'.
6261 (qualified_identifier): Removed, use `namespace_or_type_name'
6263 (QualifiedIdentifier): Removed this class.
6265 2004-01-22 Martin Baulig <martin@ximian.com>
6267 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
6268 not a string as alias name.
6270 2004-01-21 Miguel de Icaza <miguel@ximian.com>
6272 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
6273 #52730 bug, and instead compute correctly the need to use a
6274 temporary variable when requesting an address based on the
6275 static/instace modified of the field and the constructor.
6277 2004-01-21 Martin Baulig <martin@ximian.com>
6279 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
6280 class and namespace before looking up aliases. Fixes #52517.
6282 2004-01-21 Martin Baulig <martin@ximian.com>
6284 * flowanalysis.cs (UsageVector.Merge): Allow variables being
6285 assinged in a 'try'; fixes exception4.cs.
6287 2004-01-21 Marek Safar <marek.safar@seznam.cz>
6288 * class.cs : Implemented parameter-less constructor for TypeContainer
6290 * decl.cs: Attributes are now stored here. New property OptAttributes
6292 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
6294 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
6296 2004-01-21 Marek Safar <marek.safar@seznam.cz>
6298 * typemanager.cs (CSharpSignature): Now reports also inner class name.
6299 (CSharpSignature): New method for indexer and property signature.
6301 2004-01-21 Marek Safar <marek.safar@seznam.cz>
6303 * pending.cs (IsVirtualFilter): Faster implementation.
6305 2004-01-21 Marek Safar <marek.safar@seznam.cz>
6307 * typemanager.cs: Avoid inclusion of same assembly more than once.
6309 2004-01-21 Marek Safar <marek.safar@seznam.cz>
6311 * cs-parser.jay: Fixed problem where the last assembly attribute
6312 has been applied also to following declaration (class, struct, etc.)
6314 2004-01-21 Marek Safar <marek.safar@seznam.cz>
6316 * class.cs: Added error CS0538, CS0539 reporting.
6317 Fixed crash on Microsoft runtime when field type is void.
6319 * cs-parser.jay: Added error CS0537 reporting.
6321 * pending.cs: Added error CS0535 reporting.
6322 Improved error report for errors CS0536, CS0534.
6324 2004-01-20 Miguel de Icaza <miguel@ximian.com>
6326 Merge a few bits from the Anonymous Method MCS tree.
6328 * statement.cs (ToplevelBlock): New class for toplevel methods,
6329 will hold anonymous methods, lifted variables.
6331 * cs-parser.jay: Create toplevel blocks for delegates and for
6332 regular blocks of code.
6334 2004-01-20 Martin Baulig <martin@ximian.com>
6336 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
6337 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
6338 and `NeedExplicitReturn'; added `IsLastStatement'.
6339 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
6340 have a `ReturnLabel' or we're not unreachable.
6342 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
6343 child's reachability; don't just override ours with it. Fixes
6344 #58058 (lluis's example).
6345 (FlowBranching): Added public InTryOrCatch(), InCatch(),
6346 InFinally(), InLoop(), InSwitch() and
6347 BreakCrossesTryCatchBoundary() methods.
6349 * statement.cs (Return): Do all error checking in Resolve().
6350 Unless we are the last statement in a top-level block, always
6351 create a return label and jump to it.
6352 (Break, Continue): Do all error checking in Resolve(); also make
6353 sure we aren't leaving a `finally'.
6354 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
6355 statement in a top-level block.
6356 (Block.Flags): Added `IsDestructor'.
6357 (Block.IsDestructor): New public property.
6359 2004-01-20 Martin Baulig <martin@ximian.com>
6361 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
6363 2004-01-20 Martin Baulig <martin@ximian.com>
6365 * statement.cs (Statement.ResolveUnreachable): New public method.
6366 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
6367 (Block.Resolve): Resolve unreachable statements.
6369 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
6371 * expression.cs: We need to fix the case where we do
6372 not have a temp variable here.
6374 * assign.cs: Only expression compound assignments need
6375 temporary variables.
6377 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
6379 * flowanalysis.cs: Reduce memory allocation in a few ways:
6380 - A block with no variables should not allocate a bit
6382 - A method with no out parameters does not need any tracking
6383 for assignment of the parameters, so we need not allocate
6386 public readonly Type[] VariableTypes;
6387 public readonly string[] VariableNames;
6388 Are redundant. The data is already stored in the variable
6389 map, so we need not allocate another array for it.
6390 - We need to add alot of checks for if (params | locals) == null
6391 due to the first two changes.
6393 2004-01-18 Miguel de Icaza <miguel@ximian.com>
6395 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
6396 implement IMemoryLocation, we store a copy on a local variable and
6397 take the address of it. Patch from Benjamin Jemlich
6399 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
6400 to use a special "type_name_expression" rule which reduces the
6401 number of "QualifiedIdentifier" classes created, and instead
6402 directly creates MemberAccess expressions.
6404 2004-01-17 Miguel de Icaza <miguel@ximian.com>
6406 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
6407 that fixes #52853. Null literal assignment to ValueType
6409 * class.cs (MethodData.Emit): Instead of checking the name of the
6410 method to determine if its a destructor, create a new derived
6411 class from Method called Destructor, and test for that.
6413 * cs-parser.jay: Create a Destructor object instead of a Method.
6415 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
6419 2004-01-16 Miguel de Icaza <miguel@ximian.com>
6421 * expression.cs (Binary.ResolveOperator): Perform an implicit
6422 conversion from MethodGroups to their delegate types on the
6425 * delegate.cs: Introduce a new class DelegateCreation that is the
6426 base class for `NewDelegate' and `ImplicitDelegateCreation',
6427 factor some code in here.
6429 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
6430 conversion from MethodGroups to compatible delegate types.
6432 * ecore.cs (Expression.Resolve): Do not flag error 654
6433 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
6434 we allow conversions from MethodGroups to delegate types now.
6436 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
6437 assignments in v2 either.
6439 2004-01-10 Miguel de Icaza <miguel@ximian.com>
6441 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
6442 static read-only fields in ctors.
6444 Applied patch from Benjamin Jemlich
6446 * expression.cs (UnaryMutator): Avoid leaking local variables.
6448 2004-01-09 Miguel de Icaza <miguel@ximian.com>
6450 * cs-tokenizer.cs (IsCastToken): Allow the various native types
6451 here to return true, as they can be used like this:
6455 Fixed 49836 and all the other dups
6457 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
6459 * driver.cs: Implement /win32res and /win32icon.
6461 2004-01-08 Miguel de Icaza <miguel@ximian.com>
6463 * cs-parser.jay: Add a rule to improve error handling for the
6464 common mistake of placing modifiers after the type.
6466 2004-01-07 Miguel de Icaza <miguel@ximian.com>
6468 * cs-parser.jay (interface_event_declaration): Catch
6469 initialization of events on interfaces, and report cs0068
6471 * cs-parser.jay (interface_event_declaration): Catch
6472 initialization of events.
6474 * ecore.cs: Better report missing constructors.
6476 * expression.cs (Binary.ResolveOperator): My previous bug fix had
6477 the error reporting done in the wrong place. Fix.
6479 * expression.cs (Binary.ResolveOperator): Catch the
6480 operator + (E x, E y) error earlier, and later allow for implicit
6481 conversions in operator +/- (E e, U x) from U to the underlying
6484 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
6485 52596, if the container class is abstract, the default constructor
6486 is protected otherwise its public (before, we were always public).
6488 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
6491 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
6492 Jemlich that fixes bug #52597, MCS was generating invalid code for
6493 idisposable structs. Thanks to Ben for following up with this
6496 2004-01-06 Miguel de Icaza <miguel@ximian.com>
6498 * driver.cs: Allow assemblies without code to be generated, fixes
6501 2004-01-07 Nick Drochak <ndrochak@gol.com>
6503 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
6505 2004-01-05 Miguel de Icaza <miguel@ximian.com>
6507 * cs-parser.jay: Add rules to improve error reporting if fields or
6508 methods are declared at the namespace level (error 116)
6510 * Add rules to catch event add/remove
6512 2004-01-04 David Sheldon <dave-mono@earth.li>
6514 * expression.cs: Added matching ")" to error message for
6517 2004-01-03 Todd Berman <tberman@gentoo.org>
6519 * ecore.cs, attribute.cs:
6520 Applying fix from #52429.
6522 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
6524 * ecore.cs, expression.cs, statement.cs:
6525 Total rewrite of how we handle branching. We
6526 now handle complex boolean expressions with fewer
6527 jumps. As well if (x == 0) no longer emits a ceq.
6529 if (x is Foo) is much faster now, because we generate
6532 Overall, we get a pretty big improvement on our benchmark
6533 tests. The code we generate is smaller and more readable.
6535 I did a full two-stage bootstrap. The patch was reviewed
6536 by Martin and Miguel.
6538 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
6540 * cs-parser.jay: Make primary_expression not take a QI.
6541 we dont need this because the member_access rule covers
6542 us here. So we replace the rule with just IDENTIFIER.
6544 This has two good effects. First, we remove a s/r conflict.
6545 Second, we allocate many fewer QualifiedIdentifier objects.
6547 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
6549 * attribute.cs: Handle MarshalAs attributes as pseudo, and
6550 set the correct information via SRE. This prevents
6551 hanging on the MS runtime. Fixes #29374.
6553 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
6555 * convert.cs: correctly handle conversions to value types
6556 from Enum and ValueType as unboxing conversions.
6558 Fixes bug #52569. Patch by Benjamin Jemlich.
6560 2004-01-02 Ravi Pratap <ravi@ximian.com>
6562 * expression.cs (BetterConversion): Prefer int -> uint
6563 over int -> ulong (csc's behaviour). This fixed bug #52046.
6565 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
6567 * decl.cs (MemberCache.FindMembers): now returns a
6570 * typemanager.cs: In general, go with with ^^.
6571 (CopyNewMethods): take an IList.
6572 (RealMemberLookup): Only allocate an arraylist
6573 if we copy from two sets of methods.
6575 This change basically does two things:
6576 1) Fewer array lists allocated due to CopyNewMethods.
6577 2) the explicit cast in MemberList costed ALOT.
6579 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
6581 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
6582 a hashtable to avoid needless string allocations when an identifier is
6583 used more than once (the common case).
6585 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
6587 * pending.cs: MS's TypeBuilder.GetInterfaces ()
6588 is broken, it will not return anything. So, we
6589 have to use the information we have in mcs to
6592 * typemanager.cs: Add a cache for GetInterfaces,
6593 since this will now be used more often (due to ^^)
6595 (GetExplicitInterfaces) New method that gets the
6596 declared, not effective, interfaces on a type
6597 builder (eg, if you have interface IFoo, interface
6598 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
6601 This patch makes MCS able to bootstrap itself on
6604 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
6606 * expression.cs: Remove the Nop's that Miguel put
6609 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
6611 * report.cs, codegen.cs: Give the real stack trace to
6612 the error when an exception is thrown.
6614 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
6616 * decl.cs: only allocate hashtables for ifaces if
6619 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
6621 * expression.cs: fix the error from cs0121-2.cs
6622 (a parent interface has two child interfaces that
6623 have a function with the same name and 0 params
6624 and the function is called through the parent).
6626 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
6628 * class.cs, rootcontext.cs, typmanager.cs: do not
6631 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
6633 * codegen.cs: remove stack for the ec flow branching.
6634 It is already a linked list, so no need.
6636 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
6638 * Makefile: Allow custom profiler here.
6640 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
6642 * typemanager.cs (LookupType):
6643 - Use a static char [], because split takes
6644 a param array for args, so it was allocating
6646 - Do not store true in a hashtable, it boxes.
6648 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
6650 * flowanalysis.cs: bytify common enums.
6652 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
6654 * modifiers.cs: Add a new set of flags for the
6655 flags allowed on explicit interface impls.
6656 * cs-parser.jay: catch the use of modifiers in
6657 interfaces correctly.
6658 * class.cs: catch private void IFoo.Blah ().
6660 All related to bug #50572.
6662 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
6664 * decl.cs: Rewrite the consistant accessability checking.
6665 Accessability is not linear, it must be implemented in
6666 a tableish way. Fixes #49704.
6668 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
6670 * expression.cs: Handle negation in a checked context.
6671 We must use subtraction from zero. Fixes #38674.
6673 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
6675 * class.cs: Ignore static void main in DLLs.
6676 * rootcontext.cs: Handle the target type here,
6677 since we are have to access it from class.cs
6678 * driver.cs: account for the above.
6680 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
6682 * report.cs: Give line numbers and files if available.
6684 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
6686 * driver.cs: Implement /addmodule.
6688 * typemanager.cs: Change 'modules' field so it now contains Modules not
6691 2003-12-20 Martin Baulig <martin@ximian.com>
6693 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
6694 (FieldBase.IsAssigned): Removed this field.
6695 (FieldBase.SetAssigned): New public method.
6696 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
6698 2003-12-20 Martin Baulig <martin@ximian.com>
6700 * expression.cs (LocalVariableReference.DoResolve): Don't set
6701 `vi.Used' if we're called from DoResolveLValue().
6703 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
6704 returns the usage vector it just merged into the current one -
6705 pass this one to UsageWarning().
6706 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
6707 of the `EmitContext', don't call this recursively on our children.
6709 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
6711 * driver.cs: Implement /target:module.
6713 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
6715 * support.cs (CharArrayHashtable): New helper class.
6717 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
6718 char arrays, not strings, so we can avoid creating a string in
6719 consume_identifier if the identifier is a keyword.
6721 2003-12-16 Martin Baulig <martin@ximian.com>
6723 * statement.cs (LocalInfo.Assigned): Removed this property.
6724 (LocalInfo.Flags): Removed `Assigned'.
6725 (LocalInfo.IsAssigned): New public method; takes the EmitContext
6726 and uses flow analysis.
6727 (Block.UsageWarning): Made this method private.
6728 (Block.Resolve): Call UsageWarning() if appropriate.
6730 * expression.cs (LocalVariableReference.DoResolve): Always set
6731 LocalInfo.Used here.
6733 2003-12-13 Martin Baulig <martin@ximian.com>
6735 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
6736 any value here; we're now using flow analysis to figure out
6737 whether a statement/block returns a value.
6739 2003-12-13 Martin Baulig <martin@ximian.com>
6741 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
6743 (FlowBranching.MergeFinally): Don't call
6744 `branching.CheckOutParameters()' here, this is called in
6746 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
6747 when adding the `finally' vector.
6749 2003-12-13 Martin Baulig <martin@ximian.com>
6752 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
6753 actually work and also fix #48962.
6755 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
6757 * decl.cs: Do not check System.Object for nested types,
6758 since we know it does not have any. Big bang for buck:
6763 corlib: 17.99 seconds
6767 corlib: 17.39 seconds
6769 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
6771 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
6772 time we are returning 0 members, so we save alot here.
6774 2003-12-11 Martin Baulig <martin@ximian.com>
6776 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
6777 `MergeChild()', also just take the `FlowBranching' as argument;
6778 call Merge() on it and return the result.
6779 (FlowBranching.Merge): We don't need to do anything if we just
6782 2003-12-11 Martin Baulig <martin@ximian.com>
6784 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
6785 them in an `ArrayList' to reduce memory usage. Thanks to Ben
6786 Maurer for this idea.
6788 2003-12-11 Martin Baulig <martin@ximian.com>
6790 * flowanalysis.cs (MergeResult): This class is now gone; we now
6791 use the `UsageVector' for this. The reason for this is that if a
6792 branching just has one sibling, we don't need to "merge" them at
6793 all - that's the next step to do.
6794 (FlowBranching.Merge): We now return a `UsageVector' instead of a
6797 2003-12-11 Martin Baulig <martin@ximian.com>
6799 Reworked flow analyis and made it more precise and bug-free. The
6800 most important change is that we're now using a special `Reachability'
6801 class instead of having "magic" meanings of `FlowReturns'. I'll
6802 do some more cleanups and optimizations and also add some more
6803 documentation this week.
6805 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
6806 largely reworked this class.
6807 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
6808 the new `Reachability' class instead of having "magic" values here.
6809 (FlowBranching): We're now using an instance of `Reachability'
6810 instead of having separate `Returns', `Breaks' etc. fields.
6812 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
6813 based on flow analysis; ignore the return value of block.Emit ().
6815 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
6817 * driver.cs typemanager.cs: Find the mono extensions to corlib even
6818 if they are private.
6820 2003-12-09 Martin Baulig <martin@ximian.com>
6822 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
6823 call them directly on the UsageVector.
6825 2003-12-09 Martin Baulig <martin@ximian.com>
6827 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
6828 Changed return type from `FlowReturns' to `Reachability'.
6830 2003-12-09 Martin Baulig <martin@ximian.com>
6832 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
6833 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
6834 `Reachable' fields with a single `Reachability' one.
6836 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
6838 * class.cs (FindMembers): Remove foreach's.
6851 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
6856 This patch does a few things:
6857 1. EmptyStatement is now a singleton, so it is never reallocated.
6858 2. All blah is EmptyStatement constructs have been changed to
6859 blah == EmptyStatement.Value, which is much faster and valid
6860 now that EmptyStatement is a singleton.
6861 3. When resolving a block, rather than allocating a new array for
6862 the non-empty statements, empty statements are replaced with
6863 EmptyStatement.Value
6864 4. Some recursive functions have been made non-recursive.
6865 Mainly the performance impact is from (3), however (1) and (2) are needed for
6866 this to work. (4) does not make a big difference in normal situations, however
6867 it makes the profile look saner.
6872 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
6873 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
6874 Total memory allocated: 56397 KB
6877 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
6878 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
6879 Total memory allocated: 55666 KB
6881 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
6883 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
6884 than the hashtable in a hashtable version
6886 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
6887 we always end up concating a string. This results in a huge perf
6888 loss, because many strings have to be tracked by the GC. In this
6889 patch, we first use a hashtable that works with two keys, so that
6890 the strings do not need to be concat'ed.
6901 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
6903 * Makefile: Add a new target `do-time' that does a quick and simple
6904 profile, leaving easy to parse output.
6906 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
6908 * codegen.cs (Init): Create the dynamic assembly with
6909 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
6911 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
6913 * support.cs: Make the PtrHashtable use only one
6914 instance of its comparer.
6916 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
6918 * typemanager.cs: Fix lookup of GetNamespaces.
6920 2003-11-29 Miguel de Icaza <miguel@ximian.com>
6922 * expression.cs: Removed redundant line.
6924 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
6925 ArrayLists, use for loops with bounds.
6927 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
6930 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
6931 arraylists, use for loop with bounds.
6933 The above three changes give us a 0.071 second performance
6934 improvement out of 3.294 seconds down to 3.223. On my machine
6935 the above changes reduced the memory usage by 1,387 KB during
6938 * cs-parser.jay (QualifiedIdentifier): New class used to represent
6939 QualifiedIdentifiers. Before we created a new string through
6940 concatenation, and mostly later on, the result would be
6941 manipulated by DecomposeQI through string manipulation.
6943 This reduced the compiler memory usage for bootstrapping from
6944 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
6945 compile times in 0.05 seconds.
6947 2003-11-28 Dick Porter <dick@ximian.com>
6949 * support.cs: Do string compares with the Invariant culture.
6957 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
6958 the comparison is done with the Invariant culture.
6960 2003-11-27 Miguel de Icaza <miguel@ximian.com>
6962 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
6963 GetEnumerator method.
6965 (ProbeCollectionType): Iterate starting at the most specific type
6966 upwards looking for a GetEnumerator
6968 * expression.cs: Shift count can be up to 31 for int/uint and 63
6971 2003-11-26 Miguel de Icaza <miguel@ximian.com>
6973 * statement.cs (Block.LookupLabel): Also look for the label on the
6974 children blocks. Use a hash table to keep track of visited
6977 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
6978 we actually did transform the other operand, otherwise fall back
6979 to the common codepath that casts to long.
6981 * cs-tokenizer.cs: Use the same code pattern as the int case.
6982 Maybe I should do the parsing myself, and avoid depending on the
6983 Parse routines to get this done.
6985 2003-11-25 Miguel de Icaza <miguel@ximian.com>
6987 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
6988 which fixes bug 51347. This time test it.
6990 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
6991 attributes for example can not tell the difference between these.
6992 The difference was only a syntax feature of the language.
6994 * attribute.cs: Apply attributes to delegates.
6996 * delegate.cs: Call the apply attributes method.
6998 2003-11-24 Miguel de Icaza <miguel@ximian.com>
7000 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
7001 comparing 0 vs Byte.MinValue, not the value
7003 (ImplicitConversionRequired): When reporting a conversion error,
7004 use error 31 to print out the constant error instead of the
7007 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
7008 which fixes bug 51347.
7010 2003-11-22 Miguel de Icaza <miguel@ximian.com>
7012 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
7013 which fixes the -warnaserror command line option.
7015 2003-11-21 Miguel de Icaza <miguel@ximian.com>
7017 * cfold.cs (DoNumericPromotions): During constant folding of
7018 additions on UIntConstant, special case intconstants with
7019 IntConstants like we do on the expression binary operator.
7021 2003-11-12 Miguel de Icaza <miguel@ximian.com>
7023 * convert.cs (ImplicitReferenceConversion): We were missing a case
7024 (System.Enum are not value types or class types, so we need to
7025 classify them separatedly).
7027 * driver.cs: We do not support error 2007.
7029 2003-11-12 Jackson Harper <jackson@ximian.com>
7031 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
7032 system directory. Also use the full file name so users can
7033 libraries names mscorlib-o-tron.dll in a non system dir.
7035 2004-01-04 David Sheldon <dave-mono@earth.li>
7037 * expression.cs: Added matching ")" to error message for CS0077.
7039 2003-12-19 Martin Baulig <martin@ximian.com>
7041 * typemanager.cs (TypeManager.IsEqualGenericType): New public
7042 static method; see documentation in the method.
7043 (TypeManager.IsSubclassOrNestedChild): Allow IsEqualGenericType().
7045 * convert.cs (Convert.ImplicitReferenceConversion,
7046 Convert.ImplicitReferenceConversionExists): Add support for
7047 generic type declarations; see gen-36.cs.
7049 2003-12-19 Martin Baulig <martin@ximian.com>
7051 * pending.cs (Pending.InterfaceMethod): Use
7052 `Type.IsAssignableFrom()' instead of `=='.
7054 2003-12-18 Martin Baulig <martin@ximian.com>
7056 * decl.cs (DeclSpace.AsAccessible): Check for array, pointer and
7059 * convert.cs (Convert.ImplicitStandardConversionExists): Use
7060 `expr_type.Equals (target_type)' instead of `=='.
7062 2003-12-08 Martin Baulig <martin@ximian.com>
7064 * generics.cs (Constraints.Types): Removed.
7065 (Constraints.Resolve): Just resolve everything to TypeExpr's, not
7067 (Constraints.ResolveTypes): New public method; resolves the
7068 TypeExpr's to Type's.
7069 (TypeParameter.Define): TypeBuilder.DefineGenericParameter() no
7070 longer takes the constraints.
7071 (TypeParameter.DefineMethod): Likewise.
7072 (TypeParameter.DefineType): New public method. Calls
7073 `TypeBuilder/MethodBuilder.SetGenericParameterConstraints()' to set
7076 2003-12-08 Martin Baulig <martin@ximian.com>
7078 * convert.cs (Convert.ImplicitConversionStandard): Use
7079 `expr_type.Equals (target_type)' instead of `=='.
7081 2003-12-08 Martin Baulig <martin@ximian.com>
7083 * typemanager.cs (TypeManager.GetReferenceType): Call
7084 `Type.MakeByRefType ()'.
7086 2003-12-08 Martin Baulig <martin@ximian.com>
7088 * cs-parser.jay, cs-tokenizer.cs: `where' is not a keyword, it
7089 just has some special meaning in some situations. For instance,
7090 it is allowed to use `where' as the name of a variable etc.
7092 2003-12-04 Martin Baulig <martin@ximian.com>
7094 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
7095 `Type.MakeArrayType()' for array types.
7097 2003-11-18 Miguel de Icaza <miguel@ximian.com>
7099 * expression.cs (Invocation.VerifyArgumentsCompat): Remove
7102 (SizeOf.DoResolve): assign the `type_queried' field. This gets
7105 2003-11-16 Martin Baulig <martin@ximian.com>
7107 * codegen.cs (EmitContext.IsGeneric): Removed.
7109 * ecore.cs (SimpleName.ResolveAsTypeStep): Always call
7110 ResolveGeneric() on the DeclSpace.
7112 2003-11-16 Martin Baulig <martin@ximian.com>
7114 * generic.cs (TypeArguments.Resolve):
7115 `Expression.ResolveAsTypeTerminal()' returns a TypeExpr; call
7116 `ResolveType()' on it to get the Type.
7118 2003-11-15 Martin Baulig <martin@ximian.com>
7120 * generic.cs (ConstructedType.GetInterfaces): Override this.
7122 2003-11-14 Martin Baulig <martin@ximian.com>
7124 * interface.cs (Interface.DefineType): Define all type parameters
7125 before adding the interfaces we inherit.
7127 2003-11-11 Martin Baulig <martin@ximian.com>
7129 * generic.cs (ConstructedType.ResolveType): Always call
7130 `gt.BindGenericParameters (atypes)'; also if `args.HasTypeArguments'.
7132 2003-11-10 Martin Baulig <martin@ximian.com>
7134 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
7135 (TypeManager.InitCoreTypes): Initialize them here, but instead of
7136 calling `ResolveType()' on them, directly assign their `Type'.
7138 2003-11-08 Martin Baulig <martin@ximian.com>
7140 * generic.cs (ConstructedType): Override `IsClass' etc.
7142 2003-11-08 Martin Baulig <martin@ximian.com>
7144 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
7145 return value and the `out parent' parameter.
7146 (TypeContainer.DefineType): Moved the CS0644 check into
7147 GetClassBases(). Don't pass the interface types to the
7148 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
7149 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
7151 * ecore.cs (TypeExpr.IsAttribute): New property.
7152 (TypeExpr.GetInterfaces): New method.
7154 * interface.cs (Interface.GetInterfaceTypeByName): Return a
7155 TypeExpr instead of a Type.
7156 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
7157 (Interface.DefineType): Don't pass the interface types to the
7158 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
7159 them later and then call `TypeBulider.AddInterfaceImplementation()'.
7161 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
7162 instead of a `Type[]'.
7163 (TypeManager.RegisterBuilder): Likewise.
7164 (TypeManager.AddUserInterface): Likewise.
7165 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
7166 `Type[]' and also return a `TypeExpr[]'.
7167 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
7169 2003-11-08 Martin Baulig <martin@ximian.com>
7171 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
7174 2003-11-08 Martin Baulig <martin@ximian.com>
7176 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
7177 TypeManager.ResolveExpressionTypes().
7179 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
7180 instead of an Expression.
7181 (TypeExpr): This is now an abstract base class for `TypeExpression'.
7182 (TypeExpression): New public class; formerly known as `TypeExpr'.
7184 * expression.cs (ComposedCast): Derive from TypeExpr.
7186 * typemanager.cs (TypeManager.system_*_expr): These are now
7187 TypExpr's instead of Expression's.
7188 (TypeManager.ResolveExpressionTypes): New public static function;
7189 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
7192 2003-11-06 Miguel de Icaza <miguel@ximian.com>
7194 * expression.cs (New.DoResolve): Do not dereference value that
7195 might be a null return.
7197 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
7198 sure that the constant value has the right type. Fixes an
7199 unreported bug, similar to 50425.
7201 * const.cs (Const.LookupConstantValue): Call
7202 ImplicitStandardConversionExists before doing a conversion to
7203 avoid havng the TypeManager.ChangeType do conversions.
7205 Reduced the number of casts used
7207 (Const.ChangeType): New routine to enable reuse of the constant
7208 type changing code from statement.
7210 * typemanager.cs (ChangeType): Move common initialization to
7211 static global variables.
7215 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
7216 every value type to go through, even if it was void. Fix that.
7218 * cs-tokenizer.cs: Use is_identifier_start_character on the start
7219 character of the define, and the is_identifier_part_character for
7220 the rest of the string.
7222 2003-11-05 Miguel de Icaza <miguel@ximian.com>
7224 * expression.cs (UnaryMutator.EmitCode): When I updated
7225 LocalVariableReference.DoResolve, I overdid it, and dropped an
7226 optimization done on local variable references.
7228 2003-11-04 Miguel de Icaza <miguel@ximian.com>
7230 * ecore.cs: Convert the return from Ldlen into an int.
7232 2003-10-20 Miguel de Icaza <miguel@ximian.com>
7234 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
7235 the accessibility, this is a special case for toplevel non-public
7236 classes (internal for instance).
7238 2003-10-20 Nick Drochak <ndrochak@gol.com>
7240 * ecore.cs: Fix typo and build. Needed another right paren.
7242 2003-10-19 Miguel de Icaza <miguel@ximian.com>
7244 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
7245 `internal' case regular and protected, but not allowing protected
7246 to be evaluated later. Bug 49840
7248 2003-10-15 Miguel de Icaza <miguel@ximian.com>
7250 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
7251 to kb.Nlast, and not the kb.nFirst to isolate the switch
7254 Extract the underlying type, so enumerations of long/ulong are
7255 treated like long/ulong.
7257 2003-10-14 Miguel de Icaza <miguel@ximian.com>
7259 * expression.cs (New): Overload the meaning of RequestedType to
7260 track the possible creation of the NewDelegate type, since
7261 DoResolve is invoked more than once for new constructors on field
7264 See bugs: #48800 and #37014
7266 * cs-parser.jay (declare_local_constants): Take an arraylist
7267 instead of a single constant.
7269 (local_constant_declaration): It should take a
7270 constant_declarators, not a constant_declarator. Fixes 49487
7272 * convert.cs: Fix error report.
7274 2003-10-13 Jackson Harper <jackson@ximian.com>
7276 * typemanager.cs (TypeToCoreType): Add float and double this fixes
7279 2003-11-03 Martin Baulig <martin@ximian.com>
7281 * expression.cs (ArrayAccess.GetStoreOpcode): Added
7282 `out bool has_type_arg'; if set, we need to pass the type to
7284 (ArrayAccess.GetStoreOpcode, ArrayAccess.EmitLoadOpcode): Use
7285 Stelem_Any/Ldelem_Any for generic parameters.
7287 2003-11-02 Martin Baulig <martin@ximian.com>
7289 * expression.cs (Invocation.EmitCall): Use
7290 `TypeManager.IsValueType()' to check whether it's a value type.
7291 Don't set `struct_call' when calling a method on a type parameter.
7293 2003-11-02 Martin Baulig <martin@ximian.com>
7295 * generics.cs (ConstructedType.Resolve): Renamed to ResolveType()
7296 and removed the TypeBuilder argument.
7298 * typemanager.cs (TypeManager.IsValueType): Return
7299 `t.IsGenericParameter || t.IsValueType'.
7301 2003-10-25 Martin Baulig <martin@ximian.com>
7303 * decl.cs (DeclSpace.ResolveType): If we're a ConstructedType,
7304 call ConstructedType.Resolve() on it.
7306 * generic.cs (ConstructedType.Resolve): Set `type' on success.
7308 2003-10-25 Martin Baulig <martin@ximian.com>
7310 * class.cs (TypeContainer.GetClassBases): Changed
7311 `out Type parent' into `out TypeExpr parent'. Moved CS0644 and
7312 CS8214 reporting here.
7313 (TypeContainer.DefineType): GetClassBases() gives us a `TypeExpr'
7314 instead of a `Type' for our parent. In case of a recursive
7315 declaration (see tests/gen-23.cs for an example), our parent is a
7316 ConstructedType and it doesn't have its type set. So, first
7317 create our own TypeBuilder, then call constructed.Resolve() to get
7318 the parent's type and finally TypeBuilder.SetParent() it.
7320 * ecore.cs (TypeExpr.Name): New public virtual property.
7323 (ConstructedType): We're now a TypeExpr and not just an Expression.
7324 (ConstructedType.ResolveAsTypeStep): Don't resolve our type
7325 arguments here; this is done later.
7326 (ConstructedType.Resolve): New public method to resolve the type
7327 arguments and bind them.
7329 2003-10-21 Martin Baulig <martin@ximian.com>
7331 * convert.cs: Use `TypeManager.IsValueType' instead of
7332 'type.IsValueType' everywhere.
7334 * typemanager.cs (TypeManager.IsValueType): Return true for type
7335 parameters. The reason for this is that we need to box a type
7336 parameter when converting it to a reference type.
7338 * cs-parser.jay: Added support for default value expressions.
7340 * generics.cs (DefaultValueExpression): New public class.
7342 2003-10-17 Martin Baulig <martin@ximian.com>
7344 * generic.cs (Constraints.Resolve): Take a DecpSpace instead of a
7345 TypeContainer so we can also use this for Interfaces.
7346 (TypeParameter.Resolve): Likewise.
7348 * interface.cs (Interface.DefineType): Added support for generic
7351 * cs-parser.jay: Added support for generic structs and interfaces.
7353 2003-10-17 Martin Baulig <martin@ximian.com>
7355 * generic.cs (GenericMemberAccess.DoResolve): We can now actually
7356 call generic methods :-)
7358 2003-10-16 Martin Baulig <martin@ximian.com>
7360 * cs-parser.jay (namespace_or_type_name): Only create a
7361 GenericMemberAccess if we actually have type arguments.
7363 2003-10-13 Martin Baulig <martin@ximian.com>
7365 * class.cs (Method.Define): If we're a generic method, call
7366 TypeBuilder.DefineGenericMethod () before resolving
7368 (MethodData): Added .ctor which takes an additional MethodBuilder
7369 argument; this is used for generic methods.
7370 (MethodData.Define): Call `builder.SetGenericMethodSignature()' if
7371 we already have a MethodBuilder.
7373 2003-10-10 Martin Baulig <martin@ximian.com>
7375 * class.cs (Method): Added .ctor which takes a `GenericMethod'
7376 instead of a `DeclSpace'. This is used for generic methods.
7378 * cs-parser.jay (method_header): Added support for generic
7379 methods; create a `GenericMethod' instance and pass it to the
7380 `Method's .ctor; it'll be used as the `DeclSpace' to lookup
7381 parameters and locals.
7383 * decl.cs (DeclSpace.SetParameterInfo): Removed Location argument
7384 since we already have the location. Check whether we're a generic
7385 type declaration or a generic method and create the correct type
7388 * generic.cs (TypeParameter.DefineMethod): New public method.
7389 (GenericMethod): New public class; derives from DeclSpace and is
7390 used for generic methods.
7392 2003-10-09 Martin Baulig <martin@ximian.com>
7394 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
7396 (MethodCore.DoDefineParameters): Removed the TypeContainer
7397 argument; use the DeclSpace which was passed to the .ctor instead.
7398 (MethodCore.CheckParameter): Take a DeclSpace instead of a
7399 TypeContainer; we only need a DeclSpace here.
7401 2003-10-09 Martin Baulig <martin@ximian.com>
7403 * class.cs (MethodData): Added additional `DeclSpace ds' argument
7405 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
7406 EmitContext's .ctor.
7408 2003-10-09 Martin Baulig <martin@ximian.com>
7410 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
7411 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
7412 AsAccessible(), moved them as well.
7414 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
7416 2003-10-07 Miguel de Icaza <miguel@ximian.com>
7418 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
7419 generation for >=, as spotted by Paolo, bug 48679.
7420 Patch from David Waite.
7422 * cs-tokenizer.cs: Add handling for #pragma.
7424 * cs-parser.jay: Allow for both yield and yield return in the
7425 syntax. The anti-cobolization of C# fight will go on!
7427 * class.cs (TypeBuilder.DefineType): Catch error condition here
7428 (Parent.DefineType erroring out and returning null).
7430 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
7431 coping with enumerations variables, we were mistakenly processing
7432 them as a regular value type instead of built-in types. Fixes the
7435 * typemanager.cs (IsBuiltinOrEnum): New method.
7437 2003-09-30 Miguel de Icaza <miguel@ximian.com>
7439 * cs-parser.jay: Upgrade: yield now needs the return clause.
7441 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
7443 * cs-parser.jay : Renamed yyName to yyNames related to jay.
7445 2003-09-29 Martin Baulig <martin@ximian.com>
7447 * typemanager.cs (TypeManager.GetMethodFlags): Added support for
7448 inflated generic methods.
7450 * generics.cs (ConstructedType): Distinguish between open and
7451 closed constructed types; correctly resolve the arguments.
7453 2003-09-22 Martin Baulig <martin@ximian.com>
7455 * generic.cs (ConstructedType.ResolveAsTypeCheck): Check whether
7456 all type arguments meet their constraints.
7458 2003-09-19 Martin Baulig <martin@ximian.com>
7460 * decl.cs (MemberCache.SetupCacheForInterface): Take a
7461 `MemberCache parent' argument. Normally, an interface doesn't
7462 have a parent type except System.Object, but we use this in gmcs
7463 for generic type parameters.
7465 2003-09-18 Martin Baulig <martin@ximian.com>
7467 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
7468 on `type.IsInterface'; don't check whether the type has a parent
7469 to determine whether it's an interface.
7471 2003-09-17 Martin Baulig <martin@ximian.com>
7473 * generic.cs (ConstructedType.ToString): Always use `name' as the
7476 2003-09-15 Martin Baulig <martin@ximian.com>
7478 * cs-parser.jay: Fix grammar wrt. type_parameter_constraints.
7480 * generic.cs (Constraints.Resolve): New public method; this is
7481 called to resolve the constraint types and to check whether all
7482 the constraints are correct.
7483 (Constraints.Types): New public property.
7484 (TypeParameter.Resolve): New public method; resolves all the
7487 * class.cs (TypeContainer.DefineType): Call
7488 TypeParameter.Resolve() before actually defining the type.
7490 2003-09-15 Martin Baulig <martin@ximian.com>
7492 * class.cs (TypeContainer.DefineType): Added an error flag to
7493 avoid reporting duplicate CS0146's ("class definition is
7496 * driver.cs (Driver.MainDriver): Abort if
7497 RootContext.ResolveTree() reported any errors.
7499 2003-09-07 Martin Baulig <martin@ximian.com>
7501 * report.cs (Error, Warning): Added overloaded versions which take
7502 a `params object[] args' and call String.Format().
7504 2003-09-07 Martin Baulig <martin@ximian.com>
7506 * decl.cs (DeclSpace..ctor): Don't call
7507 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
7508 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
7509 (DeclSpace.RecordDecl): New method.
7511 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
7513 2003-09-02 Ravi Pratap <ravi@ximian.com>
7515 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
7516 value attributes to be applied to ParameterBuilders.
7518 * class.cs (MethodCore.LabelParameters): Make static and more
7519 generic so that it can be used from other places - like interface
7520 methods, for instance.
7522 * interface.cs (Interface.Emit): Call LabelParameters before
7523 emitting attributes on the InterfaceMethod.
7525 2003-09-07 Martin Baulig <martin@ximian.com>
7527 * generic.cs (ConstructedType.ResolveAsTypeStep): Report a CS8217
7528 if the number of type parameters doesn't match.
7530 2003-09-04 Martin Baulig <martin@ximian.com>
7532 * expression.cs (ComposedCast.ResolveAsTypeStep): Added support
7533 for arrays of generic type params (ie. `!0[]').
7535 2003-09-04 Martin Baulig <martin@ximian.com>
7537 * class.cs (TypeContainer.AsAccessible): Ignore generic parameters
7540 2003-09-04 Martin Baulig <martin@ximian.com>
7542 * decl.cs (DeclSpace.LookupGeneric): New method.
7543 (DeclSpace.CheckAccessLevel): Ignore generic parameters for the
7546 * generic.cs (TypeParameterExpr): Take a TypeParameter as
7547 argument, not just a string.
7548 (TypeParameter.Define): New public method; this is called to
7549 actually define the generic parameter; after this, you can use the
7550 new `Type' property to get the type.
7552 2003-09-04 Martin Baulig <martin@ximian.com>
7554 * decl.cs (DeclSpace.SetParameterInfo): The `constraints' argument
7555 is now an ArrayList; initialize the result of the `TypeParameters'
7557 (DeclSpace.GetGenericData): Removed.
7558 (DeclSpace.LookupGeneric): Temporarily removed; we need to
7559 implement this in a different way.
7560 (DeclSpace.GetTypeParameters): Removed; there's now a
7561 `TypeParameters' property.
7562 (DeclSpace.TypeParameters): New public property.
7564 * generic.cs (Constraints): Make this class public.
7565 (TypeParameter): New public class.
7567 2003-09-04 Martin Baulig <martin@ximian.com>
7569 * decl.cs (DeclSpace.GetTypeParameters): New method to return the
7572 * class.cs (TypeContainer.DefineType): Call
7573 TypeBuilder.DefineGenericParameter () on all generic parameters if
7574 this is a generic type.
7576 2003-08-28 Martin Baulig <martin@ximian.com>
7578 * sample-stack.il: Compile this with ilasm: "ilasm /dll
7581 * sample-hello.cs: Compile this with gmcs: "gmcs
7582 /r:sample-stack.dll sample-hello.cs".
7584 2003-08-28 Martin Baulig <martin@ximian.com>
7586 * generic.cs (ConstructedType.ResolveAsTypeStep): Actually bind
7587 the parameters to the generic type.
7589 2003-08-28 Martin Baulig <martin@ximian.com>
7591 * cs-tokenizer.cs (parse_less_than): Also allow all builtin types.
7593 2003-08-28 Martin Baulig <martin@ximian.com>
7595 * cs-parser.jay (opt_type_argument_list): Use
7596 `OP_GENERICS_LT type_arguments OP_GENERICS_GT'.
7597 (primary_expression): Replace `qualified_identifier' with `type_name'.
7598 (type_parameter_list): Use `OP_GENERICS_LT type_parameters OP_GENERICS_GT'.
7600 * cs-tokenizer.cs (is_punct): When reading a `<', invoke a custom
7601 parser to check whether it is syntactically a type parameter list;
7602 return OP_GENERICS_LT/OP_GENERICS_GT instead of OP_LT/OP_GT in
7605 2003-08-26 Martin Baulig <martin@ximian.com>
7607 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
7608 resolving aliases; fixes #47927.
7610 2003-08-26 Martin Baulig <martin@ximian.com>
7612 * statement.cs (Using.DoResolve): This is internally emitting a
7613 try/finally clause, so we need to set ec.NeedExplicitReturn if we
7614 do not always return. Fixes #47681.
7616 2003-08-26 Martin Baulig <martin@ximian.com>
7618 * decl.cs (MemberCore): Moved WarningNotHiding(),
7619 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
7621 (AdditionResult): Make this nested in DeclSpace.
7622 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
7623 argument; call NamespaceEntry.Define() unless we're nested in a
7626 * namespace.cs (Namespace.DefineName): New public function. This
7627 is called from DeclSpace's .ctor to add
7628 (Namespace.Lookup): Include DeclSpaces in the lookup.
7630 * class.cs (Operator): Derive from MemberBase, not MemberCore.
7632 * const.cs (Const): Derive from MemberBase, not MemberCore.
7634 2003-08-25 Martin Baulig <martin@ximian.com>
7636 * convert.cs (Convert.ExplicitReferenceConversion): When
7637 converting from an interface type to a class, unbox if the target
7638 type is a struct type. Fixes #47822.
7640 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7642 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
7645 2003-08-22 Martin Baulig <martin@ximian.com>
7647 * class.cs (TypeManager.DefineType): When defining a nested type,
7648 call DefineType() on our parent; fixes #47801.
7650 2003-08-22 Martin Baulig <martin@ximian.com>
7652 * class.cs (MethodData.Define): While checking if a method is an
7653 interface implementation, improve the test a bit more to fix #47654.
7655 2003-08-22 Martin Baulig <martin@ximian.com>
7657 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
7658 correctly; fixes #47722.
7660 2003-08-22 Martin Baulig <martin@ximian.com>
7662 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
7663 LocalVariableReference, ensure it's not read-only. Fixes #47536.
7665 * statement.cs (Fixed.DoResolve): Make all variables read-only.
7667 2003-08-22 Martin Baulig <martin@ximian.com>
7669 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
7670 can only be assigned in static constructors. Fixes #47161.
7672 2003-08-22 Martin Baulig <martin@ximian.com>
7674 Rewrote and improved the flow analysis code.
7676 * flowbranching.cs (FlowBranching): Make this class abstract.
7677 (FlowBranching.CreateBranching): New static function to create a
7679 (FlowBranchingBlock, FlowBranchingException): New classes.
7680 (FlowBranching.UsageVector.Type): New public readonly field.
7681 (FlowBranching.UsageVector.Breaks): Removed the setter.
7682 (FlowBranching.UsageVector.Returns): Removed the setter.
7683 (FlowBranching.UsageVector): Added Break(), Return(),
7684 NeverReachable() and Throw() methods to modify the reachability.
7685 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
7686 done by FlowBranching.Merge().
7687 (FlowBranching.UsageVector.MergeChild): New method; merges the
7688 merge result into the current vector.
7689 (FlowBranching.Merge): New abstract method to merge a branching.
7691 2003-08-12 Martin Baulig <martin@ximian.com>
7693 * expression.cs (Indirection.CacheTemporaries): Create the
7694 LocalTemporary with the pointer type, not its element type.
7696 2003-08-10 Miguel de Icaza <miguel@ximian.com>
7698 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
7699 token was a keyword or not.
7701 Add `error' options where an IDENTIFIER was expected; Provide
7702 CheckToken and CheckIdentifierToken convenience error reporting
7705 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
7707 * decl.cs: Rename `NamespaceEntry Namespace' public field into
7708 NameSpaceEntry NameSpaceEntry.
7710 (LookupInterfaceOrClass): Avoid creating a full qualified name
7711 from namespace and name: avoid doing lookups when we know the
7712 namespace is non-existant. Use new Tree.LookupByNamespace which
7713 looks up DeclSpaces based on their namespace, name pair.
7715 * driver.cs: Provide a new `parser verbose' to display the
7716 exception thrown during parsing. This is turned off by default
7717 now, so the output of a failure from mcs is more graceful.
7719 * namespace.cs: Track all the namespaces defined in a hashtable
7722 (IsNamespace): New method
7724 2003-08-09 Miguel de Icaza <miguel@ximian.com>
7726 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
7727 we know that we need to concatenate (full typename can never be
7732 * statement.cs: Use a bitfield; Do not initialize to null things
7733 which are done by the constructor by default.
7735 * cs-parser.jay: bug fix, parameter was 4, not 3.
7737 * expression.cs: Just use the property;
7739 * statement.cs: No need for GetVariableInfo method.
7741 2003-08-08 Martin Baulig <martin@ximian.com>
7743 * flowanalysis.cs (FlowReturns): This is now nested in the
7744 `FlowBranching' class.
7745 (MyBitVector): Moved this here from statement.cs.
7746 (FlowBranching.SiblingType): New enum type.
7747 (FlowBranching.CreateSibling): Added `SiblingType' argument.
7749 2003-08-07 Martin Baulig <martin@ximian.com>
7751 * flowanalysis.cs (FlowBranchingType): This is now nested in the
7752 `FlowBranching' class and called `BranchingType'.
7754 2003-08-07 Martin Baulig <martin@ximian.com>
7756 * flowanalysis.cs: Moved all the control flow analysis code into
7759 2003-08-07 Martin Baulig <martin@ximian.com>
7761 * assign.cs (Assign.DoResolve): `target' must either be an
7762 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
7765 2003-08-07 Miguel de Icaza <miguel@ximian.com>
7767 * expression.cs (BinaryMethod): This kind of expression is created by the
7768 Binary class if it determines that the operator has to be handled
7771 (BinaryDelegate): This kind of expression is created if we are
7772 dealing with a + or - operator on delegates.
7774 (Binary): remove method, argumetns, and DelegateOperator: when
7775 dealing with methods,
7777 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
7779 * statement.cs (Block): use bitfields for the three extra booleans
7780 we had in use. Remove unused topblock parameter.
7782 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
7784 * assign.cs: Drop extra unneeded tests.
7786 2003-08-06 Miguel de Icaza <miguel@ximian.com>
7788 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
7790 * statement.cs (Foreach): Use VariableStorage instead of
7793 * codegen.cs (VariableStorage): New class used by clients that
7794 require a variable stored: locals or fields for variables that
7795 need to live across yield.
7797 Maybe provide a convenience api for EmitThis+EmitLoad?
7799 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
7802 2003-08-05 Miguel de Icaza <miguel@ximian.com>
7804 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
7805 RemapParameterLValue): New methods that are used to turn a
7806 precomputed FieldInfo into an expression like this:
7810 The idea is to use this instead of making LocalVariableReference
7811 have more than one meaning.
7813 * cs-parser.jay: Add error production to BASE.
7815 * ecore.cs: Deal with TypeManager.GetField returning null, which
7816 is now a valid return value.
7818 (FieldExprNoAddress): New expression for Fields whose address can
7821 * expression.cs (LocalVariableReference): During the resolve
7822 phases, create new expressions if we are in a remapping context.
7823 Remove code that dealt with remapping here.
7825 (ParameterReference): same.
7827 (ProxyInstance): New expression, like the `This' expression, but
7828 it is born fully resolved. We know what we are doing, so remove
7829 the errors that are targeted to user-provided uses of `this'.
7831 * statement.cs (Foreach): our variable is now stored as an
7832 Expression; During resolution, follow the protocol, dont just
7833 assume it will return this.
7835 2003-08-06 Martin Baulig <martin@ximian.com>
7837 * support.cs (SeekableStreamReader.cs): New public class.
7839 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
7840 SeekableStreamReader instead of the normal StreamReader.
7842 2003-08-04 Martin Baulig <martin@ximian.com>
7844 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
7845 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
7846 deambiguate casts and delegate invocations.
7847 (parenthesized_expression): Use the new tokens to ensure this is
7848 not a cast of method invocation.
7850 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
7851 when reading a `)' and Deambiguate_CloseParens () was previously
7854 * expression.cs (ParenthesizedExpression): New class. This is
7855 just used for the CS0075 test.
7856 (Binary.DoResolve): Check for CS0075.
7858 2003-07-29 Ravi Pratap <ravi@ximian.com>
7860 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
7861 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
7862 reference comparison.
7864 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
7865 examine the ReturnType for equality - this is necessary in the
7866 cases of implicit and explicit operators whose signature also
7867 includes the return type.
7869 2003-07-26 Miguel de Icaza <miguel@ximian.com>
7871 * namespace.cs: Cache the result of the namespace computation,
7872 instead of computing it every time.
7874 2003-07-24 Miguel de Icaza <miguel@ximian.com>
7876 * decl.cs: Use a global arraylist that we reuse over invocations
7877 to avoid excesive memory consumption. Reduces memory usage on an
7878 mcs compile by one meg (45 average).
7880 * typemanager.cs (LookupTypeReflection): In .NET pointers are
7881 private, work around that.
7883 2003-07-23 Miguel de Icaza <miguel@ximian.com>
7885 * literal.cs (IntLiteral): Define Zero and One static literals.
7887 * cs-parser.jay (integer_literal): use static literals to reduce
7888 memory usage for the most used literals (0, 1 and -1). 211kb
7889 reduced in memory usage.
7891 Replace all calls to `new ArrayList' with `new
7892 ArrayList(4)' which is a good average number for most allocations,
7893 and also requires only 16 bytes of memory for its buffer by
7896 This reduced MCS memory usage in seven megabytes for the RSS after
7899 2003-07-28 Ravi Pratap <ravi@ximian.com>
7901 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
7902 handle params methods the correct way by forming only one
7903 applicable set with params and normal methods in them. Earlier we
7904 were looking at params methods only if we found no normal methods
7905 which was not the correct thing to do.
7907 (Invocation.BetterFunction): Take separate arguments indicating
7908 when candidate and the best method are params methods in their
7911 This fixes bugs #43367 and #46199.
7913 * attribute.cs: Documentation updates.
7915 (CheckAttribute): Rename to CheckAttributeTarget.
7916 (GetValidPlaces): Rename to GetValidTargets.
7918 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
7919 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
7923 2003-07-28 Miguel de Icaza <miguel@ximian.com>
7925 * codegen.cs: Compute IsGeneric correctly.
7927 * cs-parser.jay: Introduce OP_GENERIC_LT for the grammar ambiguity
7930 Bring back (temporarily) OP_LEFT_SHIFT, OP_RIGHT_SHIFT,
7931 OP_SHIFT_RIGHT_ASSIGN, OP_SHIFT_LEFT_ASSIGN. There were too many
7932 regressions, and I was chasing more bugs than I required.
7934 * interface.cs: Use expressions for base type names (like classes
7935 and structs have been doing for a while now), and resolve that.
7936 This patch should probably go into head as well.
7938 This makes it one less user of FindType.
7940 2003-07-24 Miguel de Icaza <miguel@ximian.com>
7942 This compiler can not self host currently. Need to fix that.
7944 * Makefile: compile to `gmcs.exe'
7946 * driver.cs: Turn on v2 by default on gmcs.
7948 * generic.cs (ConstructedType): Does no longer take a container
7949 type argument; That will be taken care of later.
7951 (ConstructedType.DoResolve, ConstructedType.ResolveAsTypeStep):
7952 Use SimpleName to resolve for now, so we can continue the work on
7953 the parser, until we get Type.GetType that understands generics.
7955 (ConstructedType.ToString): Implement
7957 (TypeArguments.Resolve): Resolve the child expressions as types.
7959 * cs-parser.jay: Rename interface_constraints to
7960 type_parameter_constraints
7962 (namespace_or_type_name): Only use constructed types for the basic
7963 construction, we will deal with identifier<...> later.
7965 (type/type_name): No longer call DecomposeQI, as
7966 namespace_or_type_name is always decoded now.
7968 2003-07-22 Ravi Pratap <ravi@ximian.com>
7970 * expression.cs (Invocation.OverloadResolve): Follow the spec more
7971 closely: we eliminate methods in base types when we have an
7972 applicable method in a top-level type.
7974 Please see section 14.5.5.1 for an exact description of what goes
7977 This fixes bug #45127 and a host of other related to corlib compilation.
7979 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
7980 array is the method corresponding to the top-level type (this is
7981 because of the changes made to icall.c) so we change this
7984 (MethodGroupExpr.Name): This too.
7986 * typemanager.cs (GetElementType): New method which does the right
7987 thing when compiling corlib.
7989 * everywhere: Make use of the above in the relevant places.
7991 2003-07-22 Martin Baulig <martin@ximian.com>
7993 * cs-parser.jay (invocation_expression): Moved
7994 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
7995 `cast_expression', but create a InvocationOrCast which later
7996 resolves to either an Invocation or a Cast.
7998 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
7999 method; call this before EmitStatement() to make sure that this
8000 expression can be used as a statement.
8002 * expression.cs (InvocationOrCast): New class; resolves to either
8003 an Invocation or a Cast.
8005 * statement.cs (StatementExpression): Call ResolveStatement() on
8006 the ExpressionStatement before emitting it.
8008 2003-07-21 Martin Baulig <martin@ximian.com>
8010 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
8011 `ref' and `out' attributes match; fixes #46220.
8012 (MemberAccess.ResolveMemberAccess): You can't reference a type
8013 through an expression; fixes #33180.
8014 (Indexers.GetIndexersForType): Don't return the indexers from
8015 interfaces the class implements; fixes #46502.
8017 2003-07-21 Martin Baulig <martin@ximian.com>
8019 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
8020 CS0661 checks; fixes bug #30442.
8022 2003-07-21 Martin Baulig <martin@ximian.com>
8024 * decl.cs (AdditionResult): Added `Error'.
8026 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
8028 * typemanager.cs (TypeManager.ChangeType): Catch exceptions; makes
8029 cs0031.cs actually work.
8031 2003-07-20 Miguel de Icaza <miguel@ximian.com>
8033 * cs-parser.jay (namespace_name): do not use
8034 namespace_or_type_name, use qualified_identifier, because
8035 namespace_or_type_name will soon return a composed expression
8036 instead of a string.
8038 (namespace_or_type_name): Instead of returning a string, now this
8039 production returns an expression.
8041 * codegen.cs (EmitContext): Setup IsGeneric property based on
8042 whether our DeclSpace is generic, our the method is generic.
8044 * modifier.cs (Modifiers.METHOD_GENERIC): New definition, use if
8045 the method is generic.
8047 * cs-parser.jay (type_arguments, opt_type_argument_list,
8048 type_parameters, type_parameter_list, opt_type_parameter_list,
8049 type_parameter,, opt_type_parameter_constraints_clauses,
8050 type_parameter_constraints_clauses,
8051 type_parameter_constraint_clause, type_parameter_constraint,
8052 interface_constraints): Add new production
8054 * decl.cs (DeclSpace): IsGeneric, flag to track whether this
8055 DeclSpace is generic or not.
8057 (DeclSpace.SetParameterInfo): New routine, used to set the
8058 parameter info for a type.
8060 (DeclSpace.LookupGeneric): Lookups a name, and if it is a generic,
8061 returns a GenericTypeExpr
8063 * ecore.cs (SimpleName.ResolveAsTypeStep): If our container is
8064 generic, lookup the generic argument.
8066 * attribute.cs: Do not allow TypeParameterExpressions in
8069 * class.cs: Do not allow the Main method to be defined in a
8072 * expression.cs (SizeOf): Do not allow generic types to be used as
8073 arguments to sizeof.
8075 * typemanager.cs (IsGeneric): Wrapper for Reflection when we have
8076 it: whether a type is generic or not. Only works for types we are
8077 currently building for now.
8079 2003-07-20 Martin Baulig <martin@ximian.com>
8081 * namespace.cs: Fixed that bug which caused a crash when compiling
8084 2003-07-20 Miguel de Icaza <miguel@ximian.com>
8086 * typemanager.cs (LookupTypeReflection): Never expose types which
8087 are NotPublic, NestedPrivate, NestedAssembly, or
8088 NestedFamANDAssem. We used to return these, and later do a check
8089 that would report a meaningful error, but the problem is that we
8090 would not get the real match, if there was a name override.
8092 2003-07-18 Miguel de Icaza <miguel@ximian.com>
8094 * namespace.cs (Namespace, Name): Do not compute the namespace
8095 name dynamically, compute it in the constructor. This reduced
8096 memory usage by 1697 KB.
8098 * driver.cs: Use --pause to pause at the end.
8100 2003-07-17 Peter Williams <peter@newton.cx>
8102 * Makefile: Change the name of the test target so that it doesn't
8103 conflict with the recursive test target.
8105 2003-07-17 Miguel de Icaza <miguel@ximian.com>
8107 * expression.cs (LocalVariableReference.Emit, EmitAssign,
8108 AddressOf): Do not use EmitThis, that was wrong, use the actual
8111 2003-07-15 Miguel de Icaza <miguel@ximian.com>
8113 * class.cs (MethodData.Define): While checking if a method is an
8114 interface implementation, improve the test: If we are not public
8115 (use new test here: use the computed MethodAttributes directly,
8116 instead of the parsed modifier flags) check if the `implementing'
8117 method comes from an interface or not.
8119 * pending.cs (VerifyPendingMethods): Slightly better error
8122 * makefile: add test target that does the mcs bootstrap.
8124 2003-07-16 Ravi Pratap <ravi@ximian.com>
8126 * interface.cs (Define): Do nothing here since there are no
8127 members to populate etc. Move the attribute emission out of here
8128 since this was just totally the wrong place to put it. Attribute
8129 application happens during the 'Emit' phase, not in the 'Define'
8132 (Emit): Add this method and move the attribute emission here
8134 * rootcontext.cs (EmitCode): Call the Emit method on interface
8137 2003-07-14 Ravi Pratap M <ravi@ximian.com>
8139 * expression.cs (OverloadResolve): Report error only if Location
8140 is not 'Null' which means that there was a probe going on.
8142 2003-07-14 Martin Baulig <martin@ximian.com>
8144 * expression.cs (ConditionalLogicalOperator): New public class to
8145 implement user defined conditional logical operators.
8146 This is section 14.11.2 in the spec and bug #40505.
8148 2003-07-14 Martin Baulig <martin@ximian.com>
8150 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
8152 2003-07-14 Martin Baulig <martin@ximian.com>
8154 * codegen.cs (EmitContext.InFixedInitializer): New public field.
8156 * ecore.cs (IVariable.VerifyFixed): New interface method.
8158 * expression.cs (Unary.ResolveOperator): When resolving the `&'
8159 operator, check whether the variable is actually fixed. Fixes bug
8160 #36055. Set a variable definitely assigned when taking its
8161 address as required by the spec.
8163 * statement.cs (LocalInfo.IsFixed): New field.
8164 (LocalInfo.MakePinned): Set `IsFixed' to true.
8166 2003-07-14 Ravi Pratap M <ravi@ximian.com>
8168 * attribute.cs (Attribute.Resolve): While doing a Member lookup
8169 for .ctors, ensure that we only ask for members declared in the
8170 attribute type (BindingFlags.DeclaredOnly).
8174 * expression.cs (Error_WrongNumArguments): Report error 1501
8175 correctly the way CSC does.
8177 2003-07-13 Martin Baulig <martin@ximian.com>
8179 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
8180 lookup on the fully qualified name, to make things like "X.X" work
8181 where "X.X" is a fully qualified type name, but we also have a
8182 namespace "X" in the using list. Fixes #41975.
8184 2003-07-13 Martin Baulig <martin@ximian.com>
8186 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
8187 function. If we're a CompoundAssign, we need to create an embedded
8188 CompoundAssign, not an embedded Assign.
8189 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
8192 2003-07-13 Martin Baulig <martin@ximian.com>
8194 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
8195 work to fix bug #46088.
8197 2003-07-13 Ravi Pratap <ravi@ximian.com>
8199 * class.cs (Operator.Emit): Do not emit attributes here - it is
8200 taken care of by the Method class that we delegate too. This takes
8203 2003-07-10 Martin Baulig <martin@ximian.com>
8205 * expression.cs (TypeOfVoid): New class.
8206 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
8208 2003-07-10 Martin Baulig <martin@ximian.com>
8210 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
8213 2003-07-10 Martin Baulig <martin@ximian.com>
8215 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
8216 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
8218 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
8220 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
8222 2003-07-10 Martin Baulig <martin@ximian.com>
8224 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
8225 of decimal. Fixes #42850.
8227 NOTE: I also fixed the created byte blob, but this doesn't work on
8228 the MS runtime and csc never produces any byte blobs for decimal
8231 2003-07-10 Martin Baulig <martin@ximian.com>
8233 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
8234 structs; fixes #32068.
8235 (Block.AddChildVariableNames): Fixed #44302.
8237 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8239 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
8241 2003-07-07 Miguel de Icaza <miguel@ximian.com>
8243 * attribute.cs: And this test is onger needed.
8245 2003-07-08 Martin Baulig <martin@ximian.com>
8247 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
8248 inaccessible types. Fixes #36313.
8250 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
8252 * namespace.cs (NamespaceEntry): Create implicit entries for all
8253 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
8254 implicit entries for N1.N2 and N1.
8256 2003-07-08 Martin Baulig <martin@ximian.com>
8258 Rewrote the handling of namespaces to fix a lot of the issues
8259 wrt. `using' aliases etc.
8261 * namespace.cs (Namespace): Splitted this class into a
8262 per-assembly `Namespace' and a per-file `NamespaceEntry'.
8264 * typemanager.cs (TypeManager.IsNamespace): Removed.
8265 (TypeManager.ComputeNamespaces): Only compute namespaces from
8266 loaded assemblies here, not the namespaces from the assembly we're
8267 currently compiling.
8269 2003-07-08 Martin Baulig <martin@ximian.com>
8271 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
8273 2003-07-07 Miguel de Icaza <miguel@ximian.com>
8275 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
8278 I thought about the memory savings here, but LookupTypeReflection
8279 is used under already very constrained scenarios. Compiling
8280 corlib or mcs only exposes one hit, so it would not really reduce
8281 any memory consumption.
8283 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8285 * typemanager.cs: fixes bug #45889 by only adding public types from
8286 other assemblies to the list of known types.
8288 2003-07-07 Miguel de Icaza <miguel@ximian.com>
8290 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
8291 on the type we resolved.
8293 2003-07-05 Martin Baulig <martin@ximian.com>
8295 * pending.cs (PendingImplementation.ParentImplements): Don't
8296 create the proxy if the parent is abstract.
8298 * class.cs (TypeContainer.DefineIndexers): Process explicit
8299 interface implementations first. Fixes #37714.
8301 2003-07-04 Miguel de Icaza <miguel@ximian.com>
8303 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
8304 defined recursively; but since we modify the input parameters
8305 (left is set to `this' temporarily), we reset this value if the
8306 left_is_explicit is false, which gives the original semantics to
8309 * literal.cs (NullPointer): new class used to represent a null
8310 literal in a pointer context.
8312 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
8313 type is a pointer, use a NullPointer object instead of a
8314 NullLiteral. Closes 43687
8316 (ExplicitConversion): Convert pointer values using
8317 the conv opcode to the proper type.
8319 * ecore.cs (New): change ValueTypeVariable property into a method,
8320 that returns whether the valuetype is suitable for being used.
8322 * expression.cs (Binary.DoNumericPromotions): Only return if we
8323 the int constant was a valid uint, and we can return both left and
8324 right as uints. If not, we continue processing, to trigger the
8325 type conversion. This fixes 39018.
8327 * statement.cs (Block.EmitMeta): During constant resolution, set
8328 the CurrentBlock property on the emitcontext, so that we resolve
8329 constants propertly.
8331 2003-07-02 Martin Baulig <martin@ximian.com>
8333 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
8334 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
8336 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
8337 than emitting it here.
8339 * statement.cs: Fixed some more flow analysis bugs.
8341 2003-07-02 Martin Baulig <martin@ximian.com>
8343 * class.cs (MethodData.Define): When implementing interface
8344 methods, set Final unless we're Virtual.
8346 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
8347 check work for interface methods.
8349 2003-07-01 Martin Baulig <martin@ximian.com>
8351 * ecore.cs (EmitContext.This): Replaced this property with a
8352 GetThis() method which takes a Location argument. This ensures
8353 that we get the correct error location for a CS0188.
8355 2003-07-01 Miguel de Icaza <miguel@ximian.com>
8357 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
8358 ImplicitStandardConversion.
8360 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
8362 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
8364 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
8367 2003-06-30 Miguel de Icaza <miguel@ximian.com>
8369 * class.cs (Constructor.Define): Turn off initlocals for unsafe
8372 (MethodData.Define): Turn off initlocals for unsafe methods.
8374 2003-06-29 Miguel de Icaza <miguel@ximian.com>
8376 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
8377 complete; Fixes #37521.
8379 * delegate.cs: Use Modifiers.TypeAttr to compute the
8380 TypeAttributes, instead of rolling our own. This makes the flags
8381 correct for the delegates.
8383 2003-06-28 Miguel de Icaza <miguel@ximian.com>
8385 * class.cs (Constructor.Define): Set the private flag for static
8386 constructors as well.
8388 * cs-parser.jay (statement_expression): Set the return value to
8389 null, to avoid a crash when we catch an error.
8391 2003-06-24 Miguel de Icaza <miguel@ximian.com>
8393 * cs-parser.jay: Applied patch from Jackson that adds support for
8394 extern and unsafe modifiers to destructor declarations.
8396 * expression.cs: Report error 21 if the user is trying to index a
8399 * driver.cs: Add an error message, suggested by the bug report.
8401 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
8402 if we do not have a ": this ()" constructor initializer. Fixes 45149
8404 2003-06-14 Miguel de Icaza <miguel@ximian.com>
8406 * namespace.cs: Add some information to reduce FAQs.
8408 2003-06-13 Miguel de Icaza <miguel@ximian.com>
8410 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
8411 underlying enumeration types. Fixes #43915.
8413 * expression.cs: Treat ushort/short as legal values to be used in
8416 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
8418 * delegate.cs: transfer custom attributes for paramenters from
8419 the delegate declaration to Invoke and BeginInvoke.
8421 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
8423 * attribute.cs: handle custom marshalers and emit marshal info
8426 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
8428 * makefile.gnu: Added anonymous.cs to the compiler sources.
8430 2003-05-28 Miguel de Icaza <miguel@ximian.com>
8432 * iterators.cs: Change the name of the proxy class to include two
8435 * cs-parser.jay: Update grammar to include anonymous methods.
8437 * anonymous.cs: new file.
8439 2003-05-27 Miguel de Icaza <miguel@ximian.com>
8441 * class.cs (Field.Define): Add missing test for pointers and
8444 2003-05-27 Ravi Pratap <ravi@ximian.com>
8446 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
8447 we use the stobj opcode.
8449 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
8450 since it wasn't the correct fix.
8452 It still is puzzling that we are required to use stobj for IntPtr
8453 which seems to be a ValueType.
8455 2003-05-26 Miguel de Icaza <miguel@ximian.com>
8457 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
8458 during regular simple name resolution. Now, the trick is that
8459 instead of returning for processing the simplename, we do a
8460 TypeManager.LookupType (ie, a rooted lookup as opposed to a
8461 contextual lookup type). If a match is found, return that, if
8462 not, return for further composition.
8464 This fixes long-standing 30485.
8466 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
8467 using the address to initialize an object, do an Stobj instead of
8468 using the regular Stelem.
8470 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
8471 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
8472 Because if we are a BaseIndexerAccess that value will be true.
8475 * statement.cs (GotoCase.Resolve): Return after reporting an
8476 error, do not attempt to continue.
8478 * expression.cs (PointerArithmetic.Emit): If our operand is a
8479 long, convert our constants to match the operand before
8480 multiplying. Convert to I type before adding. Fixes 43670.
8482 2003-05-14 Ravi Pratap <ravi@ximian.com>
8484 * enum.cs (ImplicitConversionExists) : Rename to
8485 ImplicitEnumConversionExists to remove ambiguity.
8487 * ecore.cs (NullCast): New type of cast expression class which
8488 basically is very similar to EmptyCast with the difference being
8489 it still is a constant since it is used only to cast a null to
8493 * convert.cs (ImplicitReferenceConversion): When casting a null
8494 literal, we return a NullCast.
8496 * literal.cs (NullLiteralTyped): Remove - I don't see why this
8497 should be around anymore.
8499 The renaming (reported was slightly wrong). Corrections:
8501 ConvertImplicitStandard -> ImplicitConversionStandard
8502 ConvertExplicitStandard -> ExplicitConversionStandard
8504 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
8505 before passing them in !
8507 * convert.cs (ImplicitConversionStandard): When comparing for
8508 equal expr and target types, ensure that expr is not a
8511 In general, we must not be checking (expr_type ==
8512 target_type) in the top level conversion methods
8513 (ImplicitConversion, ExplicitConversion etc). This checking is
8514 done in the methods that they delegate to.
8516 2003-05-20 Miguel de Icaza <miguel@ximian.com>
8518 * convert.cs: Move Error_CannotConvertType,
8519 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
8520 ImplicitNumericConversion, ImplicitConversionExists,
8521 ImplicitUserConversionExists, StandardConversionExists,
8522 FindMostEncompassedType, FindMostSpecificSource,
8523 FindMostSpecificTarget, ImplicitUserConversion,
8524 ExplicitUserConversion, GetConversionOperators,
8525 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
8526 TryImplicitIntConversion, Error_CannotConvertImplicit,
8527 ConvertImplicitRequired, ConvertNumericExplicit,
8528 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
8529 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
8532 Perform the following renames:
8534 StandardConversionExists -> ImplicitStandardConversionExists
8535 ConvertImplicit -> ImplicitConversion
8536 ConvertImplicitStandard -> ImplicitStandardConversion
8537 TryImplicitIntConversion -> ImplicitIntConversion
8538 ConvertImplicitRequired -> ImplicitConversionRequired
8539 ConvertNumericExplicit -> ExplicitNumericConversion
8540 ConvertReferenceExplicit -> ExplicitReferenceConversion
8541 ConvertExplicit -> ExplicitConversion
8542 ConvertExplicitStandard -> ExplicitStandardConversion
8544 2003-05-19 Martin Baulig <martin@ximian.com>
8546 * statement.cs (TypeInfo.StructInfo): Made this type protected.
8547 (TypeInfo): Added support for structs having structs as fields.
8549 * ecore.cs (FieldExpr): Implement IVariable.
8550 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
8551 VariableInfo for the field.
8553 2003-05-18 Martin Baulig <martin@ximian.com>
8555 * expression.cs (This.DoResolve): Report a CS0027 if we're
8556 emitting a field initializer.
8558 2003-05-18 Martin Baulig <martin@ximian.com>
8560 * expression.cs (This.ResolveBase): New public function.
8561 (This.DoResolve): Check for CS0188.
8563 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
8566 * ecore.cs (MethodGroupExpr.DoResolve): Set the
8567 `instance_expression' to null if we don't have any non-static
8570 2003-05-18 Martin Baulig <martin@ximian.com>
8572 Reworked the way how local variables and parameters are handled by
8573 the flow analysis code.
8575 * statement.cs (TypeInfo, VariableMap): New public classes.
8576 (VariableInfo): New public class. This is now responsible for
8577 checking whether a variable has been assigned. It is used for
8578 parameters and local variables.
8579 (Block.EmitMeta): Take the InternalParameters as argument; compute
8580 the layout of the flow vectors here.
8581 (Block.LocalMap, Block.ParameterMap): New public properties.
8582 (FlowBranching): The .ctor doesn't get the InternalParameters
8583 anymore since Block.EmitMeta() now computes the layout of the flow
8585 (MyStructInfo): This class is now known as `StructInfo' and nested
8586 in `TypeInfo'; we don't access this directly anymore.
8588 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
8589 property and removed IsAssigned(), IsFieldAssigned(),
8590 SetAssigned() and SetFieldAssigned(); we now call them on the
8591 VariableInfo so we don't need to duplicate this code everywhere.
8593 * expression.cs (ParameterReference): Added `Block block' argument
8595 (LocalVariableReference, ParameterReference, This): The new
8596 VariableInfo class is now responsible for all the definite
8599 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
8600 IsParameterAssigned, SetParameterAssigned): Removed.
8602 2003-05-18 Martin Baulig <martin@ximian.com>
8604 * typemanager.cs (InitCoreTypes): Try calling
8605 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
8606 the 3-args-version. Corlib now also needs our `void_type'.
8607 (GetMethod): Added overloaded version which takes an optional
8608 `bool report_errors' to allow lookups of optional methods.
8610 2003-05-12 Martin Baulig <martin@ximian.com>
8612 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
8613 only used for locals and not for parameters.
8615 2003-05-12 Miguel de Icaza <miguel@ximian.com>
8617 * support.cs (InternalParameters.ParameterType): Return the
8618 ExternalType of the parameter.
8620 * parameter.cs (Parameter.ExternalType): drop the two arguments,
8623 2003-05-11 Miguel de Icaza <miguel@ximian.com>
8625 * class.cs (MethodData.Define): Do not set the `newslot' on
8626 interface members, if they are also flagged as "override".
8628 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
8629 better code for ++i and i++. This only works for static fields
8630 and local variables.
8632 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
8633 want to pull the DeclSpace out of the builder_to_declspace instead
8634 of the TypeBuilder (like in TypeContainer.FindMembers).
8636 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
8637 instead of LookupTypeContainer. Fixes the crash on .NET for
8638 looking up interface members.
8640 * const.cs: Create our own emit context during the Definition
8641 stage, so that constants are evaluated in the proper context, when
8642 a recursive definition happens.
8644 2003-05-11 Martin Baulig <martin@ximian.com>
8646 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
8647 new block for a switch section.
8648 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
8649 the adding/lookup in the switch block. Fixes #39828.
8651 2003-05-09 Miguel de Icaza <miguel@ximian.com>
8653 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
8654 functionality: I needed to convert the data after I had performed
8655 the add/sub operation into the operands type size.
8657 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
8658 pass the type for the box operation, otherwise the resulting
8659 object would have been of type object.
8661 (BoxedCast): Add constructor to specify the type to box as.
8663 2003-05-07 Miguel de Icaza <miguel@ximian.com>
8665 * iterators.cs: I was reusing the `count' variable inadvertently,
8666 take steps to not allow this to happen.
8668 2003-05-06 Miguel de Icaza <miguel@ximian.com>
8670 * attribute.cs (Attribute.Resolve): Params attributes are encoded
8671 by creating an array at the point where the params starts and
8672 putting all those arguments there, then adjusting the size of the
8675 2003-05-05 Miguel de Icaza <miguel@ximian.com>
8677 * expression.cs (New.AddressOf): Implement interface
8678 IMemoryLocation. This is used when the `new' operator is used in
8679 the context of an invocation to a method on a value type.
8681 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
8684 * namespace.cs: Also check the using aliases here.
8686 * driver.cs: Move the test for using validity after the types have
8687 been entered, so we do a single pass that also includes the using
8690 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
8691 in the regular case. CreateSiblingForFinally is doing extra
8694 * attribute.cs (GetAttributeArgumentExpression): Store the result
8695 on an out value, and use the return value to indicate failure
8696 instead of using null (which is a valid return for Constant.GetValue).
8698 * statement.cs: Perform the analysis flow for the increment
8699 portion after the statement, because this will be the real flow of
8700 execution. Fixes #42385
8702 * codegen.cs (EmitContext.EmitArgument,
8703 EmitContext.EmitStoreArgument): New helper functions when the
8704 RemapToProxy flag is set.
8706 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
8709 Add support for remapping parameters.
8711 * iterators.cs: Propagate parameter values; Store parameter
8712 values in the proxy classes.
8714 2003-05-04 Miguel de Icaza <miguel@ximian.com>
8716 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
8717 need a proxy reference; I do not know what I was thinking
8719 * cs-parser.jay (constructor_initializer): catch another error,
8720 and display nice message.
8722 (field_declaration): catch void field declaration
8723 to flag a better error.
8725 * class.cs (MemberBase.CheckBase): Report an error instead of a
8726 warning if a new protected member is declared in a struct.
8727 (Field.Define): catch the error of readonly/volatile.
8729 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
8731 (FieldExpr.AddressOf): ditto. Catch error where the address of a
8732 volatile variable is taken
8734 2003-05-02 Miguel de Icaza <miguel@ximian.com>
8736 * statement.cs (Fixed.Resolve): Report an error if we are not in
8739 2003-05-01 Miguel de Icaza <miguel@ximian.com>
8741 * typemanager.cs: reuse the code that handles type clashes for
8742 delegates and enumerations.
8744 * class.cs (Report28): Always report.
8746 * expression.cs (EncodeAsAttribute): Allow nulls here.
8748 2003-04-28 Miguel de Icaza <miguel@ximian.com>
8750 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
8751 the functionality for testing whether an expression is valid for
8752 an attribute here. Also handle the case of arrays of elements
8755 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
8756 encoding a linear array into an array of objects that are suitable
8757 to be passed to an CustomAttributeBuilder.
8759 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
8761 * ecore.cs: (FieldExpr): Handle field remapping here.
8763 * iteratators.cs: Pass the instance variable (if the method is an
8764 instance method) to the constructors, so we can access the field
8765 variables on the class.
8767 TODO: Test this with structs. I think the THIS variable on
8768 structs might have to be a pointer, and not a refenrece
8770 2003-04-27 Miguel de Icaza <miguel@ximian.com>
8772 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
8773 local variables to fields in a proxy class.
8775 * iterators.cs (PopulateProxy): Rename our internal fields to
8777 Create a <THIS> field if we are an instance method, so we can
8778 reference our parent container variables.
8779 (MapVariable): Called back from the EmitContext code to enter a
8780 new variable to field mapping into the proxy class (we just create
8784 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
8785 for using the remapped locals to fields.
8787 I placed the code here, because that gives the same semantics to
8788 local variables, and only changes the Emit code.
8790 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
8791 statements inside iterators.
8792 (VariableInfo): Add a FieldBuilder for the cases when we are
8793 remapping local variables to fields in a proxy class
8795 * ecore.cs (SimpleNameResolve): Avoid testing two times for
8796 current_block != null.
8798 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
8799 not cope with strings, as it has been moved to the
8800 TableSwitchEmit. Fixed bug in switch generation.
8802 * expression.cs (New.DoResolve): Provide more context for the user
8803 when reporting an error.
8805 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
8808 * expression.cs (MemberAccess.DoResolve): When we get a type back,
8809 check the permissions for it. Note than in a type-resolution
8810 context the check was already present in DeclSpace.ResolveType,
8811 but was missing from the MemberAccess.
8813 (ArrayCreation.CheckIndices): warn if the user has
8814 more nested levels of expressions, but there are no more
8815 dimensions specified. Avoids crash on bug 41906.
8817 2003-04-26 Miguel de Icaza <miguel@ximian.com>
8819 * statement.cs (Block): replace Implicit bool, for a generic
8821 New flag: `Unchecked'. This is used during the EmitMeta phase
8822 (which is out-of-line with the regular Resolve/Emit process for a
8823 statement, as this is done ahead of time, but still gets a chance
8824 to call constant resolve).
8826 (Block.Flags): new enum for adding a new flag.
8828 (Block.EmitMeta): track the state of unchecked.
8830 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
8831 to enable constant resolution to work there as well.
8833 2003-04-22 Miguel de Icaza <miguel@ximian.com>
8835 * typemanager.cs (ienumerable_type): Also look up
8836 System.Collections.IEnumerable.
8838 2003-04-21 Miguel de Icaza <miguel@ximian.com>
8840 TODO: Test more than one conditional per method.
8842 * class.cs (Indexer.Define): Report the location where the user is
8843 referencing the unsupported feature.
8845 (MethodData): Overload the use of `conditionals' to
8846 minimize the creation of needless ArrayLists. This saves roughly
8847 212kb on my machine.
8849 (Method): Implement the new IIteratorContainer interface.
8850 (Method.SetYields): Implement the method by setting the ModFlags
8851 to contain METHOD_YIELDS.
8853 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
8854 which just got set to null.
8856 * iterators.cs: New file.
8858 (Yield, YieldBreak): New statements.
8860 * statement.cs (Return.Resolve): Flag an error if we are used in
8863 * codegen.cs (InIterator): New flag set if the code is being
8864 compiled in an iterator method.
8866 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
8867 internal modifier, and we just use it to avoid adding extra
8868 fields, as this is seldom used.
8870 * cs-parser.jay: Add yield_statement (yield and yield break).
8872 * driver.cs: New flag -v2 to turn on version 2 features.
8874 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
8875 hashtable when v2 is enabled.
8877 2003-04-20 Miguel de Icaza <miguel@ximian.com>
8879 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
8880 there is already a namespace defined with this name.
8882 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
8883 people upgraded their corlibs.
8885 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
8886 always use fully qualified types, no need to use the compiler
8889 (TypeManager.IsNamespace): Use binarysearch.
8891 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
8892 AddDelegate): I did not quite use the new IsValid API properly: I
8893 have to pass the short-name and the fullname. I was passing only
8894 the basename instead of the fullname sometimes.
8896 (TypeContainer.DefineType): call NamespaceClash.
8898 * interface.cs (Interface.DefineType): use NamespaceClash before
8901 * delegate.cs (Delegate.DefineType): use NamespaceClash before
8904 * enum.cs: (Enum.DefineType): use NamespaceClash before
8907 * typemanager.cs (: 3-line patch that gives us some tasty 11%
8908 speed increase. First, use the negative_hits cache when we get a
8909 negative. Second, add the type with its full original name
8910 instead of the new . and + encoded name (reflection uses + to
8911 separate type from a nested type). Use LookupTypeReflection
8912 directly which bypasses the type->name hashtable (that we already
8913 know does not contain the type.
8915 * decl.cs (DeclSpace.ResolveTypeExpr): track the
8916 location/container type.
8918 * driver.cs: When passing utf8, use directly the UTF8Encoding.
8920 2003-04-19 Miguel de Icaza <miguel@ximian.com>
8922 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
8924 * delegate.cs (NewDelegate.Resolve): Test whether an instance
8925 method is being referenced in the method group from a static
8926 context, and report error 120 if so.
8928 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
8931 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
8932 is created, we create the A namespace).
8934 * cs-parser.jay: A namespace also introduces a DeclarationFound.
8937 2003-04-18 Miguel de Icaza <miguel@ximian.com>
8939 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
8940 invocation to ModuleBuilder.GetType with the same values will
8941 return a new type instance, so we need to cache its return
8944 * expression.cs (Binary.ResolveOperator): Only allow the compare
8945 operators on enums if they are of the same type.
8947 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
8948 types of ValueType on their own case. Before we were giving them
8949 the same treatment as objects.
8951 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
8952 fullname. Short name is used to compare against container name.
8953 Fullname is used to check against defined namespace names.
8955 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
8956 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
8958 (Method.CheckBase): Call parent.
8959 (MemberBase.CheckBase): Check for protected members on sealed
8961 (PropertyBase.CheckBase): Call parent.
8962 (Field.Define): Call parent.
8964 * report.cs: Negative error codes are now mapped to 8000 - code,
8965 so that the display is render more nicely.
8967 * typemanager.cs: Do not use try/catch, instead report a regular
8970 (GetPointerType, GetReferenceType): These methods provide
8971 mechanisms to obtain the T* and T& from a T. We had the code
8972 previously scattered around the code base, and it also used
8973 TypeManager.LookupType that would go through plenty of caches.
8974 This one goes directly to the type source.
8976 In some places we did the Type.GetType followed by
8977 ModuleBuilder.GetType, but not in others, so this unifies the
8980 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
8981 statements now that we have namespace information.
8983 * typemanager.cs (IsNamespace): New method, returns whether the
8984 string presented is a namespace or not.
8986 (ComputeNamespaces): New public entry point, computes the list of
8987 available namespaces, using the GetNamespaces API call in Mono, or
8988 the slower version in MS.NET.
8990 Now before we start the semantic analysis phase, we have a
8991 complete list of namespaces including everything that the user has
8994 Deleted old code to cache namespaces in .nsc files.
8996 2003-04-17 Miguel de Icaza <miguel@ximian.com>
8998 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
8999 class/struct location definition Location for the implicit
9000 constructor location.
9002 (Operator.Define): Use the location of the operator for the
9003 implicit Method definition.
9005 (Constructor.Emit): use the constructor location for the implicit
9006 base initializer constructor.
9008 * ecore.cs: Remove ITypeExpression. This interface is now gone,
9009 and the Expression class now contains two new methods:
9011 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
9012 isolate type lookup from the rest of the resolution process.
9014 Since we use Expressions to hold type definitions due to the way
9015 we parse the input we have historically overloaded Resolve to
9016 perform the Type lookups if a special flag is passed. Now this is
9017 eliminated and two methods take their place.
9019 The differences in the two methods between xStep and xTerminal is
9020 that xStep is involved in our current lookup system that uses
9021 SimpleNames to compose a name, while xTerminal is used just to
9022 catch the case where the simplename lookup failed.
9024 2003-04-16 Miguel de Icaza <miguel@ximian.com>
9026 * expression.cs (ResolveMemberAccess): Remove redundant code.
9027 TypeExpr expressions are always born fully resolved.
9029 * interface.cs (PopulateMethod): Do not lookup the types twice.
9030 We were doing it once during SemanticAnalysis and once during
9033 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
9034 in local variable type definitions, were being returned as a
9035 SimpleName (we decomposed everything into a string), that is
9036 because primary_expression was being used instead of a type in the
9037 grammar (reduce/reduce conflicts).
9039 The part that was wrong is that we converted the expression into a
9040 string (an oversimplification in one hand, compounded with primary
9041 expressions doing string concatenation).
9047 Would return "A.B.C[]" as a SimpleName. This stopped things like
9048 using clauses from working on this particular context. And a type
9049 was being matched directly against "A.B.C[]".
9051 We now use the correct approach, and allow for ComposedCast to be
9052 part of the unary expression. So the "A.B.C []" become a composed
9053 cast of "A.B.C" (as a nested group of MemberAccess with a
9054 SimpleName at the end) plus the rank composition "[]".
9058 2003-04-10 Miguel de Icaza <miguel@ximian.com>
9060 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
9061 for the access level checking.
9063 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
9064 `TypeContainer container', because I kept getting confused when I
9065 was debugging this code.
9067 * expression.cs (Indexers): Instead of tracking getters/setters,
9068 we now track them in parallel. We create one arraylist less, but
9069 most importantly it is possible now for the LValue code to find a
9070 matching get for a set.
9072 (IndexerAccess.DoResolveLValue): Update the code.
9073 GetIndexersForType has been modified already to extract all the
9074 indexers from a type. The code assumed it did not.
9076 Also make the code set the correct return type for the indexer.
9077 This was fixed a long time ago for properties, but was missing for
9078 indexers. It used to be void_type.
9080 (Binary.Emit): Test first for doubles instead of
9081 floats, as they are more common.
9083 (Binary.EmitBranchable): Use the .un version of the branch opcodes
9084 when dealing with floats and the <=, >= operators. This fixes bug
9087 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
9088 to load the array value by emitting a load on the foreach variable
9089 type. This was incorrect.
9091 We now emit the code to load an element using the the array
9092 variable type, and then we emit the conversion operator.
9096 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
9098 * attribute.cs: Avoid allocation of ArrayLists in the common case.
9100 2003-04-09 Miguel de Icaza <miguel@ximian.com>
9102 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
9103 test for protection before we test for signatures.
9105 (MethodSignature.ToString): implement.
9107 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
9108 to the case where we reduced into a LongConstant.
9110 * decl.cs (CheckAccessLevel): If the type is an array, we can not
9111 depend on whether the information is acurrate, because the
9112 Microsoft runtime will always claim that the array type is public,
9113 regardless of the real state.
9115 If the type is a pointer, another problem happens: the type is
9116 reported as non-public in Microsoft.
9118 In both cases we have to call CheckAccessLevel recursively with
9119 the underlying type as the argument to be tested.
9121 2003-04-08 Miguel de Icaza <miguel@ximian.com>
9123 * assign.cs (Assign.Emit): If we are dealing with a compound
9124 assignment expression, we should use the code path that stores the
9125 intermediate result in a temporary value. This fixes #40903.
9127 *expression.cs (Indirection.ToString): Provide ToString method for
9130 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
9132 * class.cs: Null out fields holding references to Block objects so
9133 they can be garbage collected.
9135 * expression.cs (OverloadResolve): Remove unused local.
9137 2003-04-07 Martin Baulig <martin@ximian.com>
9139 * codegen.cs (EmitContext.CurrentFile): New public field.
9140 (EmitContext.Mark): Use the CurrentFile to check whether the
9141 location is in the correct file.
9142 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
9144 2003-04-07 Martin Baulig <martin@ximian.com>
9146 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
9148 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
9149 location. [FIXME: The location argument which gets passed to this
9150 method is sometimes wrong!]
9152 2003-04-07 Nick Drochak <ndrochak@gol.com>
9154 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
9156 2003-04-07 Miguel de Icaza <miguel@ximian.com>
9158 * expression.cs (Indirection.EmitAssign): We were using the
9159 temporary, but returning immediately instead of continuing the
9162 2003-04-06 Martin Baulig <martin@ximian.com>
9164 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
9165 if it's a nested child, but also deriving from the outer class.
9168 * typemanager.cs (IsNestedChildOf): Make this work if it's a
9169 nested child, but also deriving from the outer class. See
9171 (FilterWithClosure): We may access private members of the outer
9172 class if we're a nested child and deriving from the outer class.
9173 (RealMemberLookup): Only set `closure_private_ok' if the
9174 `original_bf' contained BindingFlags.NonPublic.
9176 2003-04-05 Martin Baulig <martin@ximian.com>
9178 * expression.cs (SizeOf.DoResolve): Use ResolveTypeExpr, so we can
9179 probe if its a type parameter, and if so, flag an error.
9181 * decl.cs: Move here the SetParameterInfo code from class.cs.
9182 Handle IsGeneric here.
9184 Handle a variety of errors in the parameter info definition.
9186 * ecore.cs (SimpleName.DoResolveType): Handle look ups for generic
9187 type parameters here.
9189 * cs-parser.jay (class_declaration): report errors for parameters
9192 2003-01-21 Miguel de Icaza <miguel@ximian.com>
9194 * generic.cs: New file, contains support code for generics.
9196 * cs-parser.jay: Remove OP_SHIFT_LEFT, OP_SHIFT_RIGHT,
9197 OP_SHIFT_LEFT_ASSIGN, OP_SHIFT_RIGHT_ASSIGN.
9199 Update parser for the above removals.
9201 * cs-tokenizer.cs: Do not handle <<= or >>= specially. This is
9202 now taken care of in the parser.
9204 2003-04-02 Miguel de Icaza <miguel@ximian.com>
9206 * class.cs (Event.Define): Do not allow abstract events to have
9209 2003-04-01 Miguel de Icaza <miguel@ximian.com>
9211 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
9212 block in event declarations.
9214 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
9215 value type, get its address.
9217 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
9218 leaving a class on the stack instead of a boolean value (int
9219 0/1). Change the code so we compare against null, and then the
9220 result against zero.
9222 * class.cs (TypeContainer.GetClassBases): We were checking for the
9223 parent class being sealed too late.
9225 * expression.cs (Binary.Emit): For <= and >= when dealing with
9226 floating point values, use cgt.un and clt.un instead of cgt and
9229 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
9231 * statement.cs: Apply the same optimization as MS: skip the
9232 GetEnumerator returning an IEnumerator, and use the one returning a
9233 CharEnumerator instead. This allows us to avoid the try-finally block
9236 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
9238 * cs-parser.jay: Attributes cannot be applied to
9239 namespaces. Fixes #40473
9241 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9244 (Add*): check if the name is valid using the full name for constants,
9245 fields, properties and events.
9247 2003-03-28 Miguel de Icaza <miguel@ximian.com>
9249 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
9250 char constants to be part of the enumeration.
9252 * expression.cs (Conditional.DoResolve): Add support for operator
9253 true. Implements the missing functionality from 14.12
9255 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
9256 operator true/false as required by the spec.
9258 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
9259 implicit conversion to boolean.
9261 * statement.cs (Statement.ResolveBoolean): A boolean expression is
9262 also one where the type implements `operator true'.
9264 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
9265 get an expression that will invoke operator true based on an
9268 (GetConversionOperators): Removed the hack that called op_True
9271 (Expression.ResolveBoolean): Move this from Statement.
9273 2003-03-17 Miguel de Icaza <miguel@ximian.com>
9275 * ecore.cs (FieldExpr): do not allow initialization of initonly
9276 fields on derived classes
9278 2003-03-13 Martin Baulig <martin@ximian.com>
9280 * statement.cs (Block.Emit): Call ig.BeginScope() and
9281 ig.EndScope() when compiling with debugging info; call
9282 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
9284 2003-03-08 Miguel de Icaza <miguel@ximian.com>
9286 * expression.cs (Indexers): Do not construct immediately, allow
9287 for new members to be appended as we go. Fixes 38143
9289 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9291 * expression.cs: save/restore context when resolving an unchecked
9294 2003-03-05 Miguel de Icaza <miguel@ximian.com>
9296 * cfold.cs: Catch division by zero in modulus operator during
9299 2003-03-03 Miguel de Icaza <miguel@ximian.com>
9301 * interface.cs (Interface.DefineMembers): Avoid defining members
9304 2003-02-27 Miguel de Icaza <miguel@ximian.com>
9306 * driver.cs: handle the +/- options for -noconfig
9308 * statement.cs (Unckeched.Resolve): Also track the state of
9309 unchecked in the Resolve phase.
9311 2003-02-27 Martin Baulig <martin@ximian.com>
9313 * ecore.cs (Expression.MemberLookup): Don't create a
9314 MethodGroupExpr for something which is not a method. Fixes #38291.
9316 2003-02-25 Miguel de Icaza <miguel@ximian.com>
9318 * class.cs (MemberBase.CheckParameters): Also check that the type
9319 is unmanaged if it is a pointer.
9321 * expression.cs (SizeOf.Resolve): Add location information.
9323 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
9324 a managed type is declared.
9326 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
9327 parameter modifiers as well. Fixes bug 38606
9329 * class.cs: Very sad. Am backing out the speed up changes
9330 introduced by the ArrayList -> Array in the TypeContainer, as they
9331 were not actually that much faster, and introduced a bug (no error
9332 reports on duplicated methods).
9334 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
9335 source first, this will guarantee that we have a valid expression
9336 before calling in lower levels functions that will require a
9337 resolved object. Then use this original_source in the
9338 target.ResolveLValue instead of the original source that was
9341 Another change. Use target.Resolve instead of LValueResolve.
9342 Although we are resolving for LValues, we will let the Assign code
9343 take care of that (it will be called again from Resolve). This
9344 basically allows code like this:
9346 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
9347 class Y { void A (X x) { x [0] += o; }
9349 The problem was that the indexer was trying to resolve for
9350 set_Item (idx, object o) and never finding one. The real set_Item
9351 was set_Item (idx, X). By delaying the process we get the right
9356 2003-02-23 Martin Baulig <martin@ximian.com>
9358 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
9359 while calling DoEmit ().
9361 * codegen.cs (EmitContext.Mark): Don't mark locations in other
9362 source files; if you use the #line directive inside a method, the
9363 compiler stops emitting line numbers for the debugger until it
9364 reaches the end of the method or another #line directive which
9365 restores the original file.
9367 2003-02-23 Martin Baulig <martin@ximian.com>
9369 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
9371 2003-02-23 Martin Baulig <martin@ximian.com>
9373 * statement.cs (Block.AddChildVariableNames): We need to call this
9374 recursively, not just for our immediate children.
9376 2003-02-23 Martin Baulig <martin@ximian.com>
9378 * class.cs (Event.Define): Always make the field private, like csc does.
9380 * typemanager.cs (TypeManager.RealMemberLookup): Make events
9381 actually work, fixes bug #37521.
9383 2003-02-23 Miguel de Icaza <miguel@ximian.com>
9385 * delegate.cs: When creating the various temporary "Parameters"
9386 classes, make sure that we call the ComputeAndDefineParameterTypes
9387 on those new parameters (just like we do with the formal ones), to
9388 allow them to be resolved in the context of the DeclSpace.
9390 This fixes the bug that Dick observed in Bugzilla #38530.
9392 2003-02-22 Miguel de Icaza <miguel@ximian.com>
9394 * expression.cs (ResolveMemberAccess): When resolving a constant,
9395 do not attempt to pull a constant if the value was not able to
9396 generate a valid constant.
9398 * const.cs (LookupConstantValue): Do not report more errors than required.
9400 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9402 * expression.cs: fixes bug #38328.
9404 2003-02-18 Miguel de Icaza <miguel@ximian.com>
9406 * class.cs: Changed all the various members that can be part of a
9407 class from being an ArrayList to be an Array of the right type.
9408 During the DefineType type_list, interface_list, delegate_list and
9409 enum_list are turned into types, interfaces, delegates and enums
9412 And during the member population, indexer_list, event_list,
9413 constant_list, field_list, instance_constructor_list, method_list,
9414 operator_list and property_list are turned into their real arrays.
9416 Although we could probably perform this operation earlier, for
9417 good error reporting we need to keep the lists and remove the
9418 lists for longer than required.
9420 This optimization was triggered by Paolo profiling the compiler
9421 speed on the output of `gen-sample-program.pl' perl script.
9423 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
9424 not crash in methods like MemberLookupFailed that use this field.
9426 This problem arises when the compiler fails to resolve a type
9427 during interface type definition for example.
9429 2003-02-18 Miguel de Icaza <miguel@ximian.com>
9431 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
9432 inherit from System.Object, so we have to stop at null, not only
9433 when reaching System.Object.
9435 2003-02-17 Miguel de Icaza <miguel@ximian.com>
9437 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
9438 DeclaredOnly because the parent indexer might have had a different
9439 name, but did not loop until the top of the hierarchy was reached.
9441 The problem this one fixes is 35492: when a class implemented an
9442 indexer from an interface, we were getting the interface method
9443 (which was abstract) and we were flagging an error (can not invoke
9446 This also keeps bug 33089 functioning, and test-148 functioning.
9448 * typemanager.cs (IsSpecialMethod): The correct way of figuring
9449 out if a method is special is to see if it is declared in a
9450 property or event, or whether it is one of the predefined operator
9451 names. This should fix correctly #36804.
9453 2003-02-15 Miguel de Icaza <miguel@ximian.com>
9455 The goal here is to remove the dependency on EmptyCast.Peel ().
9456 Killing it completely.
9458 The problem is that currently in a number of places where
9459 constants are expected, we have to "probe" for an EmptyCast, and
9460 Peel, which is not the correct thing to do, as this will be
9461 repetitive and will likely lead to errors.
9463 The idea is to remove any EmptyCasts that are used in casts that
9464 can be reduced to constants, so we only have to cope with
9467 This bug hunt was triggered by Bug 37363 and the desire to remove
9468 the duplicate pattern where we were "peeling" emptycasts to check
9469 whether they were constants. Now constants will always be
9472 * ecore.cs: Use an enumconstant here instead of wrapping with
9475 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
9476 throwing me off. By handling this we can get rid of a few hacks.
9478 * statement.cs (Switch): Removed Peel() code.
9480 2003-02-14 Miguel de Icaza <miguel@ximian.com>
9482 * class.cs: Location information for error 508
9484 * expression.cs (New.DoResolve): Add a guard against double
9485 resolution of an expression.
9487 The New DoResolve might be called twice when initializing field
9488 expressions (see EmitFieldInitializers, the call to
9489 GetInitializerExpression will perform a resolve on the expression,
9490 and later the assign will trigger another resolution
9492 This leads to bugs (#37014)
9494 * delegate.cs: The signature for EndInvoke should contain any ref
9495 or out parameters as well. We were not doing this in the past.
9497 * class.cs (Field.Define): Do not overwrite the type definition
9498 inside the `volatile' group. Turns out that volatile enumerations
9499 were changing the type here to perform a validity test, which
9502 2003-02-12 Miguel de Icaza <miguel@ximian.com>
9504 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
9505 and structs, we do not want to load the instance variable
9507 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
9508 enum_type has to be handled like an object reference (implicit
9509 conversions exists from this to object), but the regular IsClass
9510 and IsValueType tests will never return true for this one.
9512 Also we use TypeManager.IsValueType instead of type.IsValueType,
9513 just for consistency with the rest of the code (this is only
9514 needed if we ever use the construct exposed by test-180.cs inside
9515 corlib, which we dont today).
9517 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
9519 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
9522 2003-02-09 Martin Baulig <martin@ximian.com>
9524 * namespace.cs (Namespace..ctor): Added SourceFile argument.
9525 (Namespace.DefineNamespaces): New static public method; this is
9526 called when we're compiling with debugging to add all namespaces
9529 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
9530 pass it to the Namespace's .ctor.
9532 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
9533 and MethodBase arguments; pass the namespace ID to the symwriter;
9534 pass the MethodBase instead of the token to the symwriter.
9535 (SymbolWriter.DefineNamespace): New method to add a namespace to
9538 2003-02-09 Martin Baulig <martin@ximian.com>
9540 * symbolwriter.cs: New file. This is a wrapper around
9541 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
9542 methods here in near future.
9544 2003-02-09 Martin Baulig <martin@ximian.com>
9546 * codegen.cs (EmitContext.Mark): Just pass the arguments to
9547 ILGenerator.MarkSequencePoint() which are actually used by the
9550 2003-02-09 Martin Baulig <martin@ximian.com>
9552 * location.cs (SourceFile): New public sealed class. This
9553 contains the name and an index which is used in the location's token.
9554 (Location): Reserve an appropriate number of bits in the token for
9555 the source file instead of walking over that list, this gives us a
9556 really huge performance improvement when compiling with debugging.
9558 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
9559 `SourceFile' argument instead of a string.
9560 (Driver.ProcessFile): Add all the files via Location.AddFile(),
9561 but don't parse/tokenize here, we need to generate the list of all
9562 source files before we do that.
9563 (Driver.ProcessFiles): New static function. Parses/tokenizes all
9566 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
9567 instead of a string.
9569 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
9572 2003-02-09 Martin Baulig <martin@ximian.com>
9574 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
9575 filename on `#line default'.
9577 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
9579 * statement.cs: don't clear the pinned var when the fixed statement
9580 returns from the method (fixes bug#37752).
9582 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
9584 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
9587 2003-02-07 Martin Baulig <martin@ximian.com>
9589 * driver.cs: Removed the `--debug-args' command line argument.
9591 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
9592 automatically by the AsssemblyBuilder.
9593 (CodeGen.InitializeSymbolWriter): We don't need to call any
9594 initialization function on the symbol writer anymore. This method
9595 doesn't take any arguments.
9597 2003-02-03 Miguel de Icaza <miguel@ximian.com>
9599 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
9600 from referenced assemblies as well.
9602 2003-02-02 Martin Baulig <martin@ximian.com>
9604 * class.cs (MethodData.Emit): Generate debugging info for external methods.
9606 2003-02-02 Martin Baulig <martin@ximian.com>
9608 * class.cs (Constructor.Emit): Open the symbol writer before
9609 emitting the constructor initializer.
9610 (ConstructorInitializer.Emit): Call ec.Mark() to allow
9611 single-stepping through constructor initializers.
9613 2003-01-30 Miguel de Icaza <miguel@ximian.com>
9615 * class.cs: Handle error 549: do not allow virtual methods in
9618 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
9620 * decl.cs: Check access levels when resolving types
9622 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
9624 * statement.cs: Add parameters and locals set in catch blocks that might
9625 return to set vector
9627 2003-01-29 Miguel de Icaza <miguel@ximian.com>
9629 * class.cs (Operator): Set the SpecialName flags for operators.
9631 * expression.cs (Invocation.DoResolve): Only block calls to
9632 accessors and operators on SpecialName methods.
9634 (Cast.TryReduce): Handle conversions from char constants.
9637 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
9639 * statement.cs: small memory and time optimization in FlowBranching.
9641 2003-01-28 Pedro Mart <yoros@wanadoo.es>
9643 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
9644 problem that the last fix but in the other sid (Set).
9646 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
9647 access when there is no indexer in the hierarchy.
9649 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
9651 * class.cs: Combine some if statements.
9653 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9655 * driver.cs: fixed bug #37187.
9657 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
9659 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
9660 any indexer, it's needed to build a list with all the indexers in the
9661 hierarchy (AllGetters), else we have problems. Fixes #35653.
9663 2003-01-23 Miguel de Icaza <miguel@ximian.com>
9665 * class.cs (MethodData.Define): It is wrong for an interface
9666 implementation to be static in both cases: explicit and implicit.
9667 We were only handling this in one case.
9669 Improve the if situation there to not have negations.
9671 * class.cs (Field.Define): Turns out that we do not need to check
9672 the unsafe bit on field definition, only on usage. Remove the test.
9674 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9676 * driver.cs: use assembly.Location instead of Codebase (the latest
9677 patch made mcs fail when using MS assemblies).
9679 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
9681 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
9682 get the path to *corlib.dll.
9684 2003-01-21 Nick Drochak <ndrochak@gol.com>
9688 * typemanager.cs: Remove compiler warnings
9690 2003-01-20 Duncan Mak <duncan@ximian.com>
9692 * AssemblyInfo.cs: Bump the version number to 0.19.
9694 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9696 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
9698 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
9700 * class.cs (Constructor::Emit): Emit debugging info for constructors.
9702 2003-01-17 Miguel de Icaza <miguel@ximian.com>
9704 * cs-parser.jay: Small fix: we were not comparing the constructor
9705 name correctly. Thanks to Zoltan for the initial pointer.
9707 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
9709 * cs-tokenizer.cs: Set file name when specified with #line
9711 2003-01-15 Miguel de Icaza <miguel@ximian.com>
9713 * cs-parser.jay: Only perform the constructor checks here if we
9714 are named like the class; This will help provider a better
9715 error. The constructor path is taken when a type definition is
9716 not found, but most likely the user forgot to add the type, so
9717 report that rather than the constructor error.
9719 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
9721 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
9724 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
9726 * cs-parser.jay: Add cleanup call.
9728 2003-01-13 Duncan Mak <duncan@ximian.com>
9730 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
9731 consistent with other methods.
9733 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
9735 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
9737 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
9739 * attribute.cs: only set GuidAttr to true when we have a
9742 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9746 * typemanager.cs: fixes to allow mcs compile corlib with the new
9747 Type.IsSubclassOf fix.
9749 2003-01-08 Miguel de Icaza <miguel@ximian.com>
9751 * expression.cs (LocalVariableReference.DoResolve): Classify a
9752 constant as a value, not as a variable. Also, set the type for
9755 * cs-parser.jay (fixed_statement): take a type instead of a
9756 pointer_type, so we can produce a better error message later.
9758 * statement.cs (Fixed.Resolve): Flag types that are not pointers
9761 (For.DoEmit): Make inifinite loops have a
9762 non-conditional branch back.
9764 (Fixed.DoEmit): First populate the pinned variables, then emit the
9765 statement, then clear the variables. Before I was emitting the
9766 code once for each fixed piece.
9769 2003-01-08 Martin Baulig <martin@ximian.com>
9771 * statement.cs (FlowBranching.MergeChild): A break in a
9772 SWITCH_SECTION does not leave a loop. Fixes #36155.
9774 2003-01-08 Martin Baulig <martin@ximian.com>
9776 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
9777 lives in the same number space than `param_map'. Fixes #36154.
9779 2003-01-07 Miguel de Icaza <miguel@ximian.com>
9781 * cs-parser.jay (constructor_declaration): Set the
9782 Constructor.ModFlags before probing for it. This makes the
9783 compiler report 514, 515 and 132 (the code was there, but got
9786 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
9787 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
9788 (GotoCase.Resolve): Set `Returns' to ALWAYS.
9790 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
9792 * enum.cs: create the enum static fields using the enum type.
9794 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
9796 * class.cs: don't try to create the ParamBuilder for the return
9797 type if it's not needed (and handle it breaking for the ms runtime
9800 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
9802 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
9804 2002-12-29 Miguel de Icaza <miguel@ximian.com>
9806 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
9807 the command. This showed up while compiling the JANET source
9808 code, which used \r as its only newline separator.
9810 2002-12-28 Miguel de Icaza <miguel@ximian.com>
9812 * class.cs (Method.Define): If we are an operator (because it
9813 reuses our code), then set the SpecialName and HideBySig. #36128
9815 2002-12-22 Miguel de Icaza <miguel@ximian.com>
9817 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
9818 exception, report error 120 `object reference required'.
9820 * driver.cs: Add --pause option, used during to measure the size
9821 of the process as it goes with --timestamp.
9823 * expression.cs (Invocation.DoResolve): Do not allow methods with
9824 SpecialName to be invoked.
9826 2002-12-21 Miguel de Icaza <miguel@ximian.com>
9828 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
9829 number before adding it.
9831 2002-12-21 Ravi Pratap <ravi@ximian.com>
9833 * ecore.cs (StandardImplicitConversion): When in an unsafe
9834 context, we allow conversion between void * to any other pointer
9835 type. This fixes bug #35973.
9837 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
9839 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
9840 is not thrown when extensionless outputs are used
9842 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9844 * rootcontext.cs: fixed compilation of corlib.
9846 2002-12-19 Miguel de Icaza <miguel@ximian.com>
9848 * attribute.cs (Attributes.Contains): Add new method.
9850 * class.cs (MethodCore.LabelParameters): if the parameter is an
9851 `out' parameter, check that no attribute `[In]' has been passed.
9853 * enum.cs: Handle the `value__' name in an enumeration.
9855 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
9857 * decl.cs: Added special case to allow overrides on "protected
9860 2002-12-18 Ravi Pratap <ravi@ximian.com>
9862 * attribute.cs (Attributes.AddAttributeSection): Rename to this
9863 since it makes much more sense.
9865 (Attributes.ctor): Don't require a Location parameter.
9867 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
9869 * attribute.cs (ApplyAttributes): Remove extra Location parameters
9870 since we already have that information per attribute.
9872 * everywhere : make appropriate changes.
9874 * class.cs (LabelParameters): Write the code which actually
9875 applies attributes to the return type. We can't do this on the MS
9876 .NET runtime so we flag a warning in the case an exception is
9879 2002-12-18 Miguel de Icaza <miguel@ximian.com>
9881 * const.cs: Handle implicit null conversions here too.
9883 2002-12-17 Ravi Pratap <ravi@ximian.com>
9885 * class.cs (MethodCore.LabelParameters): Remove the extra
9886 Type [] parameter since it is completely unnecessary. Instead
9887 pass in the method's attributes so that we can extract
9888 the "return" attribute.
9890 2002-12-17 Miguel de Icaza <miguel@ximian.com>
9892 * cs-parser.jay (parse): Use Report.Error to flag errors instead
9893 of ignoring it and letting the compile continue.
9895 * typemanager.cs (ChangeType): use an extra argument to return an
9896 error condition instead of throwing an exception.
9898 2002-12-15 Miguel de Icaza <miguel@ximian.com>
9900 * expression.cs (Unary.TryReduce): mimic the code for the regular
9901 code path. Perform an implicit cast in the cases where we can
9902 implicitly convert to one of the integral types, and then reduce
9903 based on that constant. This fixes bug #35483.
9905 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9907 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
9909 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9911 * namespace.cs: fixed bug #35489.
9913 2002-12-12 Miguel de Icaza <miguel@ximian.com>
9915 * class.cs: Remove some dead code.
9917 * cs-parser.jay: Estimate the number of methods needed
9918 (RootContext.MethodCount);
9920 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
9921 numbers instead of StringBuilders.
9923 * support.cs (PtrHashtable): Add constructor with initial size;
9924 We can now reduce reallocations of the method table.
9926 2002-12-10 Ravi Pratap <ravi@ximian.com>
9928 * attribute.cs (ApplyAttributes): Keep track of the emitted
9929 attributes on a per-target basis. This fixes bug #35413.
9931 2002-12-10 Miguel de Icaza <miguel@ximian.com>
9933 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
9934 default to the Windows 1252 encoding.
9936 (UnixParseOption): Support version, thanks to Alp for the missing
9939 * AssemblyInfo.cs: Add nice assembly information.
9941 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
9944 * cs-parser.jay: Allow a trailing comma before the close bracked
9945 in the attribute_section production.
9947 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
9948 address of the instance was being taken, I will take this out,
9949 because we take the address of the object immediately here.
9951 2002-12-09 Ravi Pratap <ravi@ximian.com>
9953 * typemanager.cs (AreMultipleAllowed): Take care of the most
9954 obvious case where attribute type is not in the current assembly -
9957 2002-12-08 Miguel de Icaza <miguel@ximian.com>
9959 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
9960 definitions, instead of doing that afterwards.
9962 Also we use a nice little hack, depending on the constructor, we
9963 know if we are a "composed" name or a simple name. Hence, we
9964 avoid the IndexOf test, and we avoid
9966 * codegen.cs: Add code to assist in a bug reporter to track down
9967 the source of a compiler crash.
9969 2002-12-07 Ravi Pratap <ravi@ximian.com>
9971 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
9972 types have been emitted for a given element and flag an error
9973 if something which does not have AllowMultiple set is used more
9976 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
9977 attribute types and their corresponding AllowMultiple properties
9979 (AreMultipleAllowed): Check the property for a given type.
9981 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
9982 property in the case we have a TypeContainer.
9984 (Attributes.AddAttribute): Detect duplicates and just skip on
9985 adding them. This trivial fix catches a pretty gross error in our
9986 attribute emission - global attributes were being emitted twice!
9988 Bugzilla bug #33187 is now fixed.
9990 2002-12-06 Miguel de Icaza <miguel@ximian.com>
9992 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
9995 * expression.cs (Binary.ResolveOperator): I can only use the
9996 Concat (string, string, string) and Concat (string, string,
9997 string, string) if the child is actually a concatenation of
10000 2002-12-04 Miguel de Icaza <miguel@ximian.com>
10002 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
10003 context where we need a 2-character lookahead.
10005 * pending.cs (PendingImplementation): Rework so we can keep track
10006 of interface types all the time, and flag those which were
10007 implemented by parents as optional.
10009 2002-12-03 Miguel de Icaza <miguel@ximian.com>
10011 * expression.cs (Binary.ResolveOperator): Use
10012 String.Concat(string,string,string) or
10013 String.Concat(string,string,string,string) when possible.
10015 * typemanager: More helper methods.
10018 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
10020 * pending.cs: remove the bogus return from GetMissingInterfaces()
10021 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
10023 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10025 * namespace.cs: avoid duplicated 'using xxx' being added to
10026 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
10027 when we get more than one 'using' statement for the same namespace.
10028 Report a CS0105 warning for it.
10030 2002-11-30 Miguel de Icaza <miguel@ximian.com>
10032 * cs-tokenizer.cs (consume_identifier): use read directly, instead
10033 of calling getChar/putback, uses internal knowledge of it.
10035 (xtoken): Reorder tokenizer so most common patterns are checked
10036 first. This reduces the compilation time in another 5% (from 8.11s
10037 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
10039 The parsing time is 22% of the compilation in mcs, and from that
10040 64% is spent on the tokenization process.
10042 I tried using a binary search for keywords, but this is slower
10043 than the hashtable. Another option would be to do a couple of
10046 * Not use a StringBuilder, instead use an array of chars,
10047 with a set value. Notice that this way we could catch
10048 the 645 error without having to do it *afterwards*.
10050 * We could write a hand-parser to avoid the hashtable
10051 compares altogether.
10053 The identifier consumption process takes 37% of the tokenization
10054 time. Another 15% is spent on is_number. 56% of the time spent
10055 on is_number is spent on Int64.Parse:
10057 * We could probably choose based on the string length to
10058 use Int32.Parse or Int64.Parse and avoid all the 64-bit
10061 Another 3% is spend on wrapping `xtoken' in the `token' function.
10063 Handle 0xa0 as whitespace (#34752)
10065 2002-11-26 Miguel de Icaza <miguel@ximian.com>
10067 * typemanager.cs (IsCLRType): New routine to tell whether a type
10068 is one of the builtin types.
10070 Maybe it needs to use TypeCodes to be faster. Maybe we could use
10071 typecode in more places instead of doing pointer comparissions.
10072 We could leverage some knowledge about the way the typecodes are
10075 New code to cache namespaces in assemblies, it is currently not
10076 invoked, to be used soon.
10078 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
10080 * expression.cs (Binary.ResolveOperator): specially handle
10081 strings, and do not perform user-defined operator overloading for
10084 2002-11-24 Miguel de Icaza <miguel@ximian.com>
10086 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
10087 internalcall as it is a pretty simple operation; Avoid whenever
10088 possible to call Char.IsLetter.
10090 (consume_identifier): Cut by half the number of
10091 hashtable calls by merging the is_keyword and GetKeyword behavior.
10093 Do not short-circuit, because if we do, we
10094 report errors (ie, #if false && true would produce an invalid
10098 2002-11-24 Martin Baulig <martin@ximian.com>
10100 * expression.cs (Cast.TryReduce): If we're in checked syntax,
10101 check constant ranges and report a CS0221. Fixes #33186.
10103 2002-11-24 Martin Baulig <martin@ximian.com>
10105 * cs-parser.jay: Make this work for uninitialized variable
10106 declarations in the `for' initializer. Fixes #32416.
10108 2002-11-24 Martin Baulig <martin@ximian.com>
10110 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
10111 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
10113 2002-11-24 Martin Baulig <martin@ximian.com>
10115 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
10116 argument; if true, we also check for user-defined conversions.
10117 This is only needed if both arguments are of a user-defined type.
10118 Fixes #30443, added test-175.cs.
10119 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
10121 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
10123 2002-11-24 Martin Baulig <martin@ximian.com>
10125 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
10126 function to get the store opcode.
10127 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
10128 only emit the Ldelema if the store opcode is Stobj. You must run
10129 both test-34 and test-167 to test this. Fixes #34529.
10131 2002-11-23 Martin Baulig <martin@ximian.com>
10133 * ecore.cs (Expression.MemberLookup): Added additional
10134 `qualifier_type' argument which is used when we're being called
10135 from MemberAccess.DoResolve() and null if we're called from a
10137 (Expression.MemberLookupFailed): New method to report errors; this
10138 does the CS1540 check and reports the correct error message.
10140 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
10141 argument for the CS1540 check and redone the way how we're dealing
10142 with private members. See the comment in the source code for details.
10143 (FilterWithClosure): Reverted this back to revision 1.197; renamed
10144 `closure_start_type' to `closure_qualifier_type' and check whether
10145 it's not null. It was not this filter being broken, it was just
10146 being called with the wrong arguments.
10148 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
10149 and pass it the correct `qualifier_type'; this also does the error
10152 2002-11-22 Miguel de Icaza <miguel@ximian.com>
10154 * expression.cs (Invocation.EmitParams): If the we are dealing
10155 with a non-built-in value type, load its address as well.
10157 (ArrayCreation): Use a a pretty constant instead
10158 of the hardcoded value 2. Use 6 instead of 2 for the number of
10159 static initializers.
10161 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
10162 because they are not really value types, just glorified integers.
10164 * driver.cs: Do not append .exe, the CSC compiler does not do it.
10166 * ecore.cs: Remove redundant code for enumerations, make them use
10167 the same code path as everything else, fixes the casting issue
10168 with enumerations in Windows.Forms.
10170 * attribute.cs: Do only cast to string if it is a string, the
10171 validation happens later.
10173 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
10174 people upgrade their corlibs.
10176 * ecore.cs: Oops, enumerations were not following the entire code path
10178 2002-11-21 Miguel de Icaza <miguel@ximian.com>
10180 * typemanager.cs (FilterWithClosure): Commented out the test for
10181 1540 in typemanager.cs, as it has problems when accessing
10182 protected methods from a parent class (see test-174.cs).
10184 * attribute.cs (Attribute.ValidateGuid): new method.
10185 (Attribute.Resolve): Use above.
10187 2002-11-19 Miguel de Icaza <miguel@ximian.com>
10189 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
10191 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
10192 handling for enumerations, as we only needed the TypeContainer
10193 functionality to begin with (this is required for the fix below to
10194 work for enums that reference constants in a container class for
10197 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
10199 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
10200 a valid TypeBuilder to perform lookups on.o
10202 * class.cs (InheritableMemberSignatureCompare): Use true in the
10203 call to GetGetMethod and GetSetMethod, because we are comparing
10204 the signature, and we need to get the methods *even* if they are
10207 (PropertyBase.CheckBase): ditto.
10209 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
10210 GotoCase.Resolve): Use Peel on EmpytCasts.
10212 * ecore.cs (EmptyCast): drop child, add Peel method.
10214 2002-11-17 Martin Baulig <martin@ximian.com>
10216 * ecore.cs (EmptyCast.Child): New public property.
10218 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
10219 label resolved to an EmptyCast. Fixes #34162.
10220 (GotoCase.Resolve): Likewise.
10221 (Block.EmitMeta): Likewise.
10223 2002-11-17 Martin Baulig <martin@ximian.com>
10225 * expression.cs (Invocation.BetterConversion): Prefer int over
10226 uint; short over ushort; long over ulong for integer literals.
10227 Use ImplicitConversionExists instead of StandardConversionExists
10228 since we also need to check for user-defined implicit conversions.
10229 Fixes #34165. Added test-173.cs.
10231 2002-11-16 Martin Baulig <martin@ximian.com>
10233 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
10234 with the `true' and `false' literals. Fixes #33151.
10236 2002-11-16 Martin Baulig <martin@ximian.com>
10238 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
10239 October 22nd; don't do the cs1540 check for static members.
10241 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
10242 now using our own filter here and doing the cs1540 check again.
10244 2002-11-16 Martin Baulig <martin@ximian.com>
10246 * support.cs (InternalParameters): Don't crash if we don't have
10247 any fixed parameters. Fixes #33532.
10249 2002-11-16 Martin Baulig <martin@ximian.com>
10251 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
10252 when looking up static methods to make this work on Windows.
10255 2002-11-16 Martin Baulig <martin@ximian.com>
10257 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
10258 a setter rather than using PropertyInfo.CanWrite.
10260 2002-11-15 Nick Drochak <ndrochak@gol.com>
10262 * class.cs: Allow acces to block member by subclasses. Fixes build
10265 2002-11-14 Martin Baulig <martin@ximian.com>
10267 * class.cs (Constructor.Emit): Added the extern/block check.
10270 2002-11-14 Martin Baulig <martin@ximian.com>
10272 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
10273 iteration while looking for indexers, this is needed because the
10274 indexer may have a different name in our base classes. Fixed the
10275 error reporting (no indexers at all, not get accessor, no
10276 overloaded match). Fixes bug #33089.
10277 (IndexerAccess.DoResolveLValue): Likewise.
10279 2002-11-14 Martin Baulig <martin@ximian.com>
10281 * class.cs (PropertyBase.CheckBase): Make this work for multiple
10282 indexers. Fixes the first part of bug #33089.
10283 (MethodSignature.InheritableMemberSignatureCompare): Added support
10286 2002-11-13 Ravi Pratap <ravi@ximian.com>
10288 * attribute.cs (Attribute.Resolve): Catch the
10289 NullReferenceException and report it since it isn't supposed to
10292 2002-11-12 Miguel de Icaza <miguel@ximian.com>
10294 * expression.cs (Binary.EmitBranchable): Also handle the cases for
10295 LogicalOr and LogicalAnd that can benefit from recursively
10296 handling EmitBranchable. The code now should be nice for Paolo.
10298 2002-11-08 Miguel de Icaza <miguel@ximian.com>
10300 * typemanager.cs (LookupType): Added a negative-hit hashtable for
10301 the Type lookups, as we perform quite a number of lookups on
10302 non-Types. This can be removed once we can deterministically tell
10303 whether we have a type or a namespace in advance.
10305 But this might require special hacks from our corlib.
10309 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
10310 and double which avoids a conversion from an integer to a double.
10312 * expression.cs: tiny optimization, avoid calling IsConstant,
10313 because it effectively performs the lookup twice.
10315 2002-11-06 Miguel de Icaza <miguel@ximian.com>
10317 But a bogus return here to keep the semantics of the old code
10318 until the Mono runtime is fixed.
10320 * pending.cs (GetMissingInterfaces): New method used to remove all
10321 the interfaces that are already implemented by our parent
10322 classes from the list of pending methods.
10324 * interface.cs: Add checks for calls after ResolveTypeExpr.
10326 2002-11-05 Miguel de Icaza <miguel@ximian.com>
10328 * class.cs (Class.Emit): Report warning 67: event not used if the
10329 warning level is beyond 3.
10331 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
10332 being a NullLiteral.
10334 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
10337 * class.cs (TypeContainer.GetClassBases): Cover a missing code
10338 path that might fail if a type can not be resolved.
10340 * expression.cs (Binary.Emit): Emit unsigned versions of the
10343 * driver.cs: use error 5.
10345 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
10347 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
10349 2002-11-01 Miguel de Icaza <miguel@ximian.com>
10351 * cs-parser.jay (switch_section): A beautiful patch from Martin
10352 Baulig that fixed 33094.
10354 2002-10-31 Miguel de Icaza <miguel@ximian.com>
10356 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
10357 Check whether the base is abstract and report an error if so.
10359 * expression.cs (IndexerAccess.DoResolveLValue,
10360 IndexerAccess.DoResolve): ditto.
10362 (Invocation.DoResolve): ditto.
10364 (Invocation.FullMethodDesc): Improve the report string.
10366 * statement.cs (Block): Eliminate IsVariableDefined as it is
10367 basically just a wrapper for GetVariableInfo.
10369 * ecore.cs (SimpleName): Use new
10371 * support.cs (ReflectionParamter.ParameterType): We unwrap the
10372 type, as we return the actual parameter ref/unref state on a
10375 2002-10-30 Miguel de Icaza <miguel@ximian.com>
10377 * support.cs: Return proper flags REF/OUT fixing the previous
10380 * expression.cs: Reverted last patch, that was wrong. Is_ref is
10381 not used to mean `ref' but `ref or out' in ParameterReference
10383 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
10384 full type signature instead of calling TypeManger.CSharpName
10387 * support.cs (InternalParameters.ParameterDesc): Do not compare
10388 directly to the modflags, because REF/OUT will actually be bitsets
10391 * delegate.cs (VerifyMethod): Check also the modifiers.
10393 * cs-tokenizer.cs: Fix bug where floating point values with an
10394 exponent where a sign was missing was ignored.
10396 * driver.cs: Allow multiple assemblies to be specified in a single
10399 2002-10-28 Miguel de Icaza <miguel@ximian.com>
10401 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
10402 because identifiers after a parenthesis would end up in this kind
10403 of production, and we needed to desamiguate it for having casts
10406 (UserDefinedType *) xxx
10408 2002-10-24 Miguel de Icaza <miguel@ximian.com>
10410 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
10411 we should set on the Bindingflags.NonPublic, but not turn on
10412 private_ok. private_ok controls whether a Private member is
10413 returned (this is chekced on the filter routine), while the
10414 BindingFlags.NonPublic just controls whether private/protected
10415 will be allowed. This fixes the problem part of the problem of
10416 private properties being allowed to be used in derived classes.
10418 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
10419 so we can call the children DoResolveLValue method (this will
10420 properly signal errors on lvalue assignments to base properties)
10422 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
10423 getter are null, and we have a property info, we know that this
10424 happened because the lookup failed, so we report an error 122 for
10425 protection level violation.
10427 We also silently return if setter and getter are null in the
10428 resolve functions, this condition only happens if we have flagged
10429 the error before. This is the other half of the problem.
10431 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
10432 not have accessibility information, that is why we were returning
10433 true in the filter function in typemanager.cs.
10435 To properly report 122 (property is inaccessible because of its
10436 protection level) correctly, we report this error in ResolveAccess
10437 by failing if both the setter and the getter are lacking (ie, the
10440 DoResolve and DoLResolve have been modified to check for both
10441 setter/getter being null and returning silently, the reason being
10442 that I did not want to put the knowledge about this error in upper
10445 int old = Report.Errors;
10446 x = new PropertyExpr (...);
10447 if (old != Report.Errors)
10452 So the property expr is returned, but it is invalid, so the error
10453 will be flagged during the resolve process.
10455 * class.cs: Remove InheritablePropertySignatureCompare from the
10456 class, as we no longer depend on the property signature to compute
10457 whether it is possible to implement a method or not.
10459 The reason is that calling PropertyInfo.GetGetMethod will return
10460 null (in .NET, in Mono it works, and we should change this), in
10461 cases where the Get Method does not exist in that particular
10466 class X { public virtual int A { get { return 1; } } }
10468 class Z : Y { public override int A { get { return 2; } } }
10470 Would fail in Z because the parent (Y) would not have the property
10471 defined. So we avoid this completely now (because the alternative
10472 fix was ugly and slow), and we now depend exclusively on the
10475 (PropertyBase.CheckBase): Use a method-base mechanism to find our
10476 reference method, instead of using the property.
10478 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
10479 routines are gone now.
10481 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
10482 names, they were incorrectly named.
10484 * cs-tokenizer.cs: Return are more gentle token on failure.
10486 * pending.cs (PendingImplementation.InterfaceMethod): This routine
10487 had an out-of-sync index variable, which caused it to remove from
10488 the list of pending methods the wrong method sometimes.
10490 2002-10-22 Miguel de Icaza <miguel@ximian.com>
10492 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
10493 CanWrite, because those refer to this particular instance of the
10494 property, and do not take into account the fact that we can
10495 override single members of a property.
10497 Constructor requires an EmitContext. The resolution process does
10498 not happen here, but we need to compute the accessors before,
10499 because the resolution does not always happen for properties.
10501 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
10502 subclass, before we did not update this flag, but we did update
10505 (GetAccessors): Drop this routine, as it did not work in the
10506 presence of partially overwritten set/get methods.
10508 Notice that this broke the cs1540 detection, but that will require
10511 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10515 * driver.cs: issue a warning instead of an error if we don't support
10516 debugging for the platform. Also ignore a couple of errors that may
10517 arise when trying to write the symbols. Undo my previous patch.
10519 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10521 * driver.cs: ignore /debug switch except for Unix platforms.
10523 2002-10-23 Nick Drochak <ndrochak@gol.com>
10525 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
10527 2002-10-21 Miguel de Icaza <miguel@ximian.com>
10529 * driver.cs: Do not make mcs-debug conditional, so we do not break
10530 builds that use it.
10532 * statement.cs (UsageVector.MergeChildren): I would like Martin to
10533 review this patch. But basically after all the children variables
10534 have been merged, the value of "Breaks" was not being set to
10535 new_breaks for Switch blocks. I think that it should be set after
10536 it has executed. Currently I set this to the value of new_breaks,
10537 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
10538 conservative, but I do not understand this code very well.
10540 I did not break anything in the build, so that is good ;-)
10542 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
10544 2002-10-20 Mark Crichton <crichton@gimp.org>
10546 * cfold.cs: Fixed compile blocker. Really fixed it this time.
10548 2002-10-20 Nick Drochak <ndrochak@gol.com>
10550 * cfold.cs: Fixed compile blocker.
10552 2002-10-20 Miguel de Icaza <miguel@ximian.com>
10554 * driver.cs: I was chekcing the key, not the file.
10556 2002-10-19 Ravi Pratap <ravi@ximian.com>
10558 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
10559 message that we were generating - we just need to silently return
10562 2002-10-19 Miguel de Icaza <miguel@ximian.com>
10564 * class.cs (Event.Define): Change my previous commit, as this
10565 breaks the debugger. This is a temporary hack, as it seems like
10566 the compiler is generating events incorrectly to begin with.
10568 * expression.cs (Binary.ResolveOperator): Added support for
10569 "U operator - (E x, E y)"
10571 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
10574 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
10575 init-only variables, but this path did not take into account that
10576 there might be also instance readonly variables. Correct this
10579 This fixes bug 32253
10581 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
10584 * driver.cs: Change the extension for modules to `netmodule'
10586 * cs-parser.jay: Improved slightly the location tracking for
10587 the debugger symbols.
10589 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
10590 modifiers that were specified instead of the hardcoded value
10591 (FamAndAssem). This was basically ignoring the static modifier,
10592 and others. Fixes 32429.
10594 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
10595 fixed a bug in the process (32476)
10597 * expression.cs (ArrayAccess.EmitAssign): Patch from
10598 hwang_rob@yahoo.ca that fixes bug 31834.3
10600 2002-10-18 Miguel de Icaza <miguel@ximian.com>
10602 * driver.cs: Make the module extension .netmodule.
10604 2002-10-16 Miguel de Icaza <miguel@ximian.com>
10606 * driver.cs: Report an error if the resource file is not found
10607 instead of crashing.
10609 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
10610 false, like Emit does.
10612 2002-10-16 Nick Drochak <ndrochak@gol.com>
10614 * typemanager.cs: Remove unused private member. Also reported mcs
10615 bug to report this as a warning like csc.
10617 2002-10-15 Martin Baulig <martin@gnome.org>
10619 * statement.cs (Statement.Emit): Made this a virtual method; emits
10620 the line number info and calls DoEmit().
10621 (Statement.DoEmit): New protected abstract method, formerly knows
10622 as Statement.Emit().
10624 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
10626 2002-10-11 Miguel de Icaza <miguel@ximian.com>
10628 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
10629 have fixed a remaining problem: not every AddXXXX was adding a
10630 fully qualified name.
10632 Now everyone registers a fully qualified name in the DeclSpace as
10633 being defined instead of the partial name.
10635 Downsides: we are slower than we need to be due to the excess
10636 copies and the names being registered this way.
10638 The reason for this is that we currently depend (on the corlib
10639 bootstrap for instance) that types are fully qualified, because
10640 we dump all the types in the namespace, and we should really have
10641 types inserted into the proper namespace, so we can only store the
10642 basenames in the defined_names array.
10644 2002-10-10 Martin Baulig <martin@gnome.org>
10646 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
10647 from bug #31834, see the bug report for a testcase which is
10650 2002-10-10 Martin Baulig <martin@gnome.org>
10652 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
10653 flow analysis code for this.
10655 * statement.cs (Do, While, For): Tell the flow analysis code about
10657 (FlowBranching.UsageVector): Added support for infinite loops.
10658 (Block.Resolve): Moved the dead code elimination here and use flow
10661 2002-10-09 Miguel de Icaza <miguel@ximian.com>
10663 * class.cs (Field.Define): Catch cycles on struct type
10666 * typemanager.cs (IsUnmanagedtype): Do not recursively check
10667 fields if the fields are static. We only need to check instance
10670 * expression.cs (As.DoResolve): Test for reference type.
10672 * statement.cs (Using.ResolveExpression): Use
10673 ConvertImplicitRequired, not ConvertImplicit which reports an
10675 (Using.ResolveLocalVariableDecls): ditto.
10677 * expression.cs (Binary.ResolveOperator): Report errors in a few
10678 places where we had to.
10680 * typemanager.cs (IsUnmanagedtype): Finish implementation.
10682 2002-10-08 Miguel de Icaza <miguel@ximian.com>
10684 * expression.cs: Use StoreFromPtr instead of extracting the type
10685 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
10687 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
10688 an enumeration value to a System.Enum, but System.Enum is not a
10689 value type, but an class type, so we need to box.
10691 (Expression.ConvertExplicit): One codepath could return
10692 errors but not flag them. Fix this. Fixes #31853
10694 * parameter.cs (Resolve): Do not allow void as a parameter type.
10696 2002-10-06 Martin Baulig <martin@gnome.org>
10698 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
10699 if it's a class type and not a struct. Fixes #31815.
10701 2002-10-06 Martin Baulig <martin@gnome.org>
10703 * statement.cs: Reworked the flow analysis code a bit to make it
10704 usable for dead code elimination.
10706 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10708 * cs-parser.jay: allow empty source files. Fixes bug #31781.
10710 2002-10-04 Miguel de Icaza <miguel@ximian.com>
10712 * expression.cs (ComposedCast.DoResolveType): A quick workaround
10713 to fix the test 165, will investigate deeper.
10715 2002-10-04 Martin Baulig <martin@gnome.org>
10717 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
10718 finally blocks actually work.
10719 (Try.Resolve): We don't need to create a sibling for `finally' if
10720 there is no finally block.
10722 2002-10-04 Martin Baulig <martin@gnome.org>
10724 * class.cs (Constructor.Define): The default accessibility for a
10725 non-default constructor is private, not public.
10727 2002-10-04 Miguel de Icaza <miguel@ximian.com>
10729 * class.cs (Constructor): Make AllowedModifiers public, add
10732 * cs-parser.jay: Perform the modifiers test here, as the
10733 constructor for the Constructor class usually receives a zero
10734 because of the way we create it (first we create, later we
10735 customize, and we were never checking the modifiers).
10737 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
10738 is a version of LookupTypeReflection that includes the type-name
10739 cache. This can be used as a fast path for functions that know
10740 the fully qualified name and are only calling into *.GetType() to
10741 obtain a composed type.
10743 This is also used by TypeManager.LookupType during its type
10746 (LookupType): We now also track the real type name, as sometimes
10747 we can get a quey for the real type name from things like
10748 ComposedCast. This fixes bug 31422.
10750 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
10751 complete type fullname, it does not have to go through the type
10752 resolution system to obtain the composed version of the type (for
10753 obtaining arrays or pointers).
10755 (Conditional.Emit): Use the EmitBoolExpression to
10756 generate nicer code, as requested by Paolo.
10758 (ArrayCreation.CheckIndices): Use the patch from
10759 hwang_rob@yahoo.ca to validate the array initializers.
10761 2002-10-03 Miguel de Icaza <miguel@ximian.com>
10763 * class.cs (ConstructorInitializer.Emit): simplify code by using
10764 Invocation.EmitCall, and at the same time, fix the bugs in calling
10765 parent constructors that took variable arguments.
10767 * ecore.cs (Expression.ConvertNumericExplicit,
10768 Expression.ImplicitNumericConversion): Remove the code that
10769 manually wrapped decimal (InternalTypeConstructor call is now gone
10772 * expression.cs (Cast.TryReduce): Also handle decimal types when
10773 trying to perform a constant fold on the type.
10775 * typemanager.cs (IsUnmanagedtype): Partially implemented.
10777 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
10778 that only turned off an error report, and did nothing else.
10780 2002-10-02 Miguel de Icaza <miguel@ximian.com>
10782 * driver.cs: Handle and ignore /fullpaths
10784 2002-10-01 Miguel de Icaza <miguel@ximian.com>
10786 * expression.cs (Binary.ResolveOperator): Catch the case where
10787 DoNumericPromotions returns true,
10789 (Binary.DoNumericPromotions): Simplify the code, and the tests.
10791 2002-09-27 Miguel de Icaza <miguel@ximian.com>
10793 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
10796 2002-09-26 Miguel de Icaza <miguel@ximian.com>
10798 * ecore.cs (ConvertNumericExplicit): It is not enough that the
10799 conversion exists, but it is also required that the conversion be
10800 performed. This manifested in "(Type64Enum) 2".
10802 * class.cs (TypeManager.AddMethod): The fix is not to change
10803 AddEnum, because that one was using a fully qualified name (every
10804 DeclSpace derivative does), but to change the AddMethod routine
10805 that was using an un-namespaced name. This now correctly reports
10806 the duplicated name.
10808 Revert patch until I can properly fix it. The issue
10809 is that we have a shared Type space across all namespaces
10810 currently, which is wrong.
10812 Options include making the Namespace a DeclSpace, and merge
10813 current_namespace/current_container in the parser.
10815 2002-09-25 Miguel de Icaza <miguel@ximian.com>
10817 * cs-parser.jay: Improve error reporting when we get a different
10818 kind of expression in local_variable_type and
10819 local_variable_pointer_type.
10821 Propagate this to avoid missleading errors being reported.
10823 * ecore.cs (ImplicitReferenceConversion): treat
10824 TypeManager.value_type as a target just like object_type. As
10829 Is valid, and needs to result in the int 1 being boxed before it
10830 is assigned to the value type v.
10832 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
10833 to validate the enumeration name.
10835 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
10836 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
10837 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
10839 * ecore.cs (TryImplicitIntConversion): When doing an
10840 implicit-enumeration-conversion, check if the type is 64-bits and
10841 perform a conversion before passing to EnumConstant.
10843 2002-09-23 Miguel de Icaza <miguel@ximian.com>
10845 * decl.cs (Error_AmbiguousTypeReference); New routine used to
10846 report ambiguous type references. Unlike the MS version, we
10847 report what the ambiguity is. Innovation at work ;-)
10849 (DeclSpace.FindType): Require a location argument to
10850 display when we display an ambiguous error.
10852 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
10854 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
10856 * expression.cs (EmitDynamicInitializers): Apply patch from
10857 hwang_rob@yahoo.ca that fixes the order in which we emit our
10860 2002-09-21 Martin Baulig <martin@gnome.org>
10862 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
10863 delegate takes no arguments.
10865 2002-09-20 Miguel de Icaza <miguel@ximian.com>
10867 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
10870 * expression.cs: Extract the underlying type.
10872 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
10874 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
10876 2002-09-19 Miguel de Icaza <miguel@ximian.com>
10878 * class.cs (TypeContainer.DefineType): We can not use the nice
10879 PackingSize with the size set to 1 DefineType method, because it
10880 will not allow us to define the interfaces that the struct
10883 This completes the fixing of bug 27287
10885 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
10886 means also structs. This fixes part of the problem.
10887 (Expresion.ImplicitReferenceConversionExists): ditto.
10889 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
10890 error if there were no errors reported during the type lookup
10891 process, to avoid duplicates or redundant errors. Without this
10892 you would get an ambiguous errors plus a type not found. We have
10893 beaten the user enough with the first error.
10895 (DeclSparce.FindType): Emit a warning if we have an ambiguous
10898 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
10899 during the resolution process, stop the lookup, this avoids
10900 repeated error reports (same error twice).
10902 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
10904 * typemanager.cs (LookupType): Redo the type lookup code to match
10905 the needs of System.Reflection.
10907 The issue is that System.Reflection requires references to nested
10908 types to begin with a "+" sign instead of a dot. So toplevel
10909 types look like: "NameSpace.TopLevelClass", and nested ones look
10910 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
10913 2002-09-19 Martin Baulig <martin@gnome.org>
10915 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
10916 says that a method always returns or always throws an exception,
10917 don't report the CS0161.
10919 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
10920 set `Returns = new_returns'.
10922 2002-09-19 Martin Baulig <martin@gnome.org>
10924 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
10925 to an enum constant, check for a CS0176.
10927 2002-09-18 Miguel de Icaza <miguel@ximian.com>
10929 * class.cs (TypeContainer.CheckPairedOperators): Now we check
10930 for operators that must be in pairs and report errors.
10932 * ecore.cs (SimpleName.DoResolveType): During the initial type
10933 resolution process, when we define types recursively, we must
10934 check first for types in our current scope before we perform
10935 lookups in the enclosing scopes.
10937 * expression.cs (MakeByteBlob): Handle Decimal blobs.
10939 (Invocation.VerifyArgumentsCompat): Call
10940 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
10941 I thought we were supposed to always call this, but there are a
10942 few places in the code where we dont do it.
10944 2002-09-17 Miguel de Icaza <miguel@ximian.com>
10946 * driver.cs: Add support in -linkres and -resource to specify the
10947 name of the identifier.
10949 2002-09-16 Miguel de Icaza <miguel@ximian.com>
10951 * ecore.cs (StandardConversionExists): Sync with the conversion
10952 code: allow anything-* to void* conversions.
10954 (FindMostSpecificSource): Use an Expression argument
10955 instead of a Type, because we might be handed over a Literal which
10956 gets a few more implicit conversions that plain types do not. So
10957 this information was being lost.
10959 Also, we drop the temporary type-holder expression when not
10962 2002-09-17 Martin Baulig <martin@gnome.org>
10964 * class.cs (PropertyBase.CheckBase): Don't check the base class if
10965 this is an explicit interface implementation.
10967 2002-09-17 Martin Baulig <martin@gnome.org>
10969 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
10970 different `IndexerName' attributes.
10972 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
10973 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
10974 virtual CommonResolve().
10976 2002-09-16 Miguel de Icaza <miguel@ximian.com>
10978 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
10979 and convert that to the UnderlyingType.
10981 * statement.cs (Foreach.Resolve): Indexers are just like variables
10982 or PropertyAccesses.
10984 * cs-tokenizer.cs (consume_string): Track line numbers and columns
10985 inside quoted strings, we were not doing this before.
10987 2002-09-16 Martin Baulig <martin@gnome.org>
10989 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
10990 resolve it. This is needed for the definite assignment check of the
10991 instance expression, fixes bug #29846.
10992 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
10994 2002-09-16 Nick Drochak <ndrochak@gol.com>
10996 * parameter.cs: Fix compile error. Cannot reference static member
10997 from an instance object. Is this an mcs bug?
10999 2002-09-14 Martin Baulig <martin@gnome.org>
11001 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
11002 multiple times. Fixes bug #30295, added test-166.cs.
11004 2002-09-14 Martin Baulig <martin@gnome.org>
11006 * statement.cs (Block.Emit): Don't emit unreachable code.
11007 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
11008 `break' statements.
11009 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
11011 2002-09-14 Martin Baulig <martin@gnome.org>
11013 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
11016 2002-09-14 Martin Baulig <martin@gnome.org>
11018 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
11019 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
11020 be false on the ms runtime.
11022 2002-09-13 Martin Baulig <martin@gnome.org>
11024 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
11025 the CS0038 error message.
11027 2002-09-12 Miguel de Icaza <miguel@ximian.com>
11029 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
11030 constant inside, return it.
11032 2002-09-12 Martin Baulig <martin@gnome.org>
11034 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
11035 implicit conversion can be done between enum types.
11037 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
11038 check whether an implicit conversion to the current enum's UnderlyingType
11039 exists and report an error if not.
11041 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
11042 without debugging support.
11044 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
11045 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
11047 2002-09-12 Martin Baulig <martin@gnome.org>
11049 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
11051 * ecore.cs (IMemberExpr.DeclaringType): New property.
11052 (SimpleName.SimpleNameResolve): Check whether we're accessing a
11053 nonstatic member of an outer type (CS0038).
11055 2002-09-11 Miguel de Icaza <miguel@ximian.com>
11057 * driver.cs: Activate the using-error detector at warning level
11058 4 (at least for MS-compatible APIs).
11060 * namespace.cs (VerifyUsing): Small buglett fix.
11062 * pending.cs (PendingImplementation): pass the container pointer.
11064 * interface.cs (GetMethods): Allow for recursive definition. Long
11065 term, I would like to move every type to support recursive
11066 definitions, not the current ordering mechanism that we have right
11069 The situation is this: Attributes are handled before interfaces,
11070 so we can apply attributes to interfaces. But some attributes
11071 implement interfaces, we will now handle the simple cases
11072 (recursive definitions will just get an error).
11074 * parameter.cs: Only invalidate types at the end if we fail to
11077 2002-09-09 Martin Baulig <martin@gnome.org>
11079 * ecore.cs (PropertyExpr.Emit): Also check for
11080 TypeManager.system_int_array_get_length so this'll also work when
11081 compiling corlib. Fixes #30003.
11083 2002-09-09 Martin Baulig <martin@gnome.org>
11085 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
11086 and throw an exception if we can't get the type's size. Fixed #30040,
11089 2002-09-09 Martin Baulig <martin@gnome.org>
11091 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
11093 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
11094 context. Fixes bug #30027.
11096 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
11097 virtual functions. Fixes bug #30043, added test-164.cs.
11099 2002-09-08 Ravi Pratap <ravi@ximian.com>
11101 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
11103 2002-09-08 Nick Drochak <ndrochak@gol.com>
11105 * driver.cs: Use an object to get the windows codepage since it's not a
11108 2002-09-08 Miguel de Icaza <miguel@ximian.com>
11110 * statement.cs (For.Emit): for infinite loops (test == null)
11111 return whether there is a break inside, not always "true".
11113 * namespace.cs (UsingEntry): New struct to hold the name of the
11114 using definition, the location where it is defined, and whether it
11115 has been used in a successful type lookup.
11117 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
11122 2002-09-06 Ravi Pratap <ravi@ximian.com>
11124 * attribute.cs : Fix incorrect code which relied on catching
11125 a NullReferenceException to detect a null being passed in
11126 where an object was expected.
11128 2002-09-06 Miguel de Icaza <miguel@ximian.com>
11130 * statement.cs (Try): flag the catch variable as assigned
11132 * expression.cs (Cast): Simplified by using ResolveType instead of
11133 manually resolving.
11135 * statement.cs (Catch): Fix bug by using ResolveType.
11137 2002-09-06 Ravi Pratap <ravi@ximian.com>
11139 * expression.cs (BetterConversion): Special case for when we have
11140 a NullLiteral as the argument and we have to choose between string
11141 and object types - we choose string the way csc does.
11143 * attribute.cs (Attribute.Resolve): Catch the
11144 NullReferenceException and report error #182 since the Mono
11145 runtime no more has the bug and having this exception raised means
11146 we tried to select a constructor which takes an object and is
11149 2002-09-05 Ravi Pratap <ravi@ximian.com>
11151 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
11152 message (1502, 1503) when we can't locate a method after overload
11153 resolution. This is much more informative and closes the bug
11156 * interface.cs (PopulateMethod): Return if there are no argument
11157 types. Fixes a NullReferenceException bug.
11159 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
11160 expressions too. Previously we were checking only in one place for
11161 positional arguments leaving out named arguments.
11163 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
11164 type to the enum type is not allowed. Remove code corresponding to
11167 (ConvertNumericExplicit): Allow explicit conversions from
11168 the underlying type to enum type. This precisely follows the spec
11169 and closes a bug filed by Gonzalo.
11171 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11174 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
11176 2002-09-03 Miguel de Icaza <miguel@ximian.com>
11178 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
11179 it was important that we stored the right value after the
11180 reduction in `converted'.
11182 2002-09-04 Martin Baulig <martin@gnome.org>
11184 * location.cs (Location.SymbolDocument): Use full pathnames for the
11187 2002-08-30 Miguel de Icaza <miguel@ximian.com>
11189 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
11190 of the expression resolve mechanism, because that will catch the
11191 SimpleName error failures.
11193 (Conditional): If we can not resolve the
11194 expression, return, do not crash.
11196 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11199 (location): display token name instead of its number.
11201 2002-08-28 Martin Baulig <martin@gnome.org>
11203 * expression.cs (Binary.ResolveOperator): Don't silently return
11204 but return an error if an operator cannot be applied between two
11207 2002-08-28 Martin Baulig <martin@gnome.org>
11209 * class.cs (Constructor.Define): Set the permission attributes
11210 correctly instead of making all constructors public.
11212 2002-08-28 Martin Baulig <martin@gnome.org>
11214 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
11215 for private members before reporting a CS0103; if we find anything,
11218 2002-08-28 Martin Baulig <martin@gnome.org>
11220 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
11221 to check whether `closure_start_type == closure_invocation_type',
11222 we also need to check whether `m.DeclaringType == closure_invocation_type'
11223 before bypassing the permission checks. We might be accessing
11224 protected/private members from the base class.
11225 (TypeManager.RealMemberLookup): Only set private_ok if private
11226 members were requested via BindingFlags.NonPublic.
11228 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
11230 * expression.cs (MemberAccess.ResolveMemberAccess): Set
11231 MethodGroupExpr.IsExplicitImpl if appropriate.
11232 (Invocation.DoResolve): Don't report the CS0120 for explicit
11233 interface implementations.
11235 2002-08-27 Martin Baulig <martin@gnome.org>
11237 * expression.cs (Invocation.DoResolve): If this is a static
11238 method and we don't have an InstanceExpression, we must report
11241 2002-08-25 Martin Baulig <martin@gnome.org>
11243 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
11244 `==' between a valuetype and an object.
11246 2002-08-25 Miguel de Icaza <miguel@ximian.com>
11248 * ecore.cs (TypeExpr): Provide a ToString method.
11250 2002-08-24 Martin Baulig <martin@gnome.org>
11252 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
11253 now called proggie.dbg and it's a binary file.
11255 2002-08-23 Martin Baulig <martin@gnome.org>
11257 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
11259 2002-08-23 Martin Baulig <martin@gnome.org>
11261 * struct.cs (MyStructInfo.ctor): Make this work with empty
11262 structs; it's not allowed to use foreach() on null.
11264 2002-08-23 Martin Baulig <martin@gnome.org>
11266 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
11267 writer the full pathname of the generated assembly.
11269 2002-08-23 Martin Baulig <martin@gnome.org>
11271 * statements.cs (FlowBranching.UsageVector.MergeChildren):
11272 A `finally' block never returns or breaks; improved handling of
11275 2002-08-23 Martin Baulig <martin@gnome.org>
11277 * statement.cs (Throw.Resolve): Allow `throw null'.
11279 2002-08-23 Martin Baulig <martin@gnome.org>
11281 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
11282 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
11283 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
11284 MemberLookup would return a wrong event if this is an explicit
11285 interface implementation and the class has an event with the same
11288 2002-08-23 Martin Baulig <martin@gnome.org>
11290 * statement.cs (Block.AddChildVariableNames): New public method.
11291 (Block.AddChildVariableName): Likewise.
11292 (Block.IsVariableNameUsedInChildBlock): Likewise.
11293 (Block.AddVariable): Check whether a variable name has already
11294 been used in a child block.
11296 * cs-parser.jay (declare_local_variables): Mark all variable names
11297 from the current block as being used in a child block in the
11300 2002-08-23 Martin Baulig <martin@gnome.org>
11302 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
11303 find the symbol writer.
11305 * driver.cs: csc also allows the arguments to /define being
11306 separated by commas, not only by semicolons.
11308 2002-08-23 Martin Baulig <martin@gnome.org>
11310 * interface.cs (Interface.GetMembers): Added static check for events.
11312 2002-08-15 Martin Baulig <martin@gnome.org>
11314 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
11315 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
11317 * ecore.cs (Expression.MemberLookup): Added documentation and explained
11318 why the MethodData.EmitDestructor() change was necessary.
11320 2002-08-20 Martin Baulig <martin@gnome.org>
11322 * class.cs (TypeContainer.FindMembers): Added static check for events.
11324 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
11326 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
11327 use Type.GetEvents(), not Type.FindMembers().
11329 2002-08-20 Martin Baulig <martin@gnome.org>
11331 * decl.cs (MemberCache): Added a special method cache which will
11332 be used for method-only searched. This ensures that a method
11333 search will return a MethodInfo with the correct ReflectedType for
11336 2002-08-20 Martin Baulig <martin@gnome.org>
11338 * decl.cs (DeclSpace.FindMembers): Made this public.
11340 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11342 * delegate.cs: fixed build on windows.
11343 [FIXME: Filed as bug #29150: MCS must report these errors.]
11345 2002-08-19 Ravi Pratap <ravi@ximian.com>
11347 * ecore.cs (StandardConversionExists): Return a false
11348 if we are trying to convert the void type to anything else
11349 since that is not allowed.
11351 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
11352 we flag error 70 in the event an event is trying to be accessed
11353 directly from outside the declaring type.
11355 2002-08-20 Martin Baulig <martin@gnome.org>
11357 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
11358 MemberCache from typemanager.cs to decl.cs.
11360 2002-08-19 Martin Baulig <martin@gnome.org>
11362 * class.cs (TypeContainer): Implement IMemberContainer.
11363 (TypeContainer.DefineMembers): Create the MemberCache.
11364 (TypeContainer.FindMembers): Do better BindingFlags checking; only
11365 return public members if BindingFlags.Public was given, check
11366 whether members are static.
11368 2002-08-16 Martin Baulig <martin@gnome.org>
11370 * decl.cs (DeclSpace.Define): Splitted this in Define and
11371 DefineMembers. DefineMembers is called first and initializes the
11374 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
11375 DefineMembers() on all our DeclSpaces.
11377 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
11378 but call DefineMembers() on all nested interfaces. We call their
11379 Define() in our new Define() function.
11381 * interface.cs (Interface): Implement IMemberContainer.
11382 (Interface.Define): Moved all code except the attribute stuf to
11384 (Interface.DefineMembers): Initialize the member cache.
11386 * typemanager.cs (IMemberFinder): Removed this interface, we don't
11387 need this anymore since we can use MemberCache.FindMembers directly.
11389 2002-08-19 Martin Baulig <martin@gnome.org>
11391 * typemanager.cs (MemberCache): When creating the cache for an
11392 interface type, add all inherited members.
11393 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
11394 to `out bool used_cache' and documented it.
11395 (TypeManager.MemberLookup): If we already used the cache in the first
11396 iteration, we don't need to do the interfaces check.
11398 2002-08-19 Martin Baulig <martin@gnome.org>
11400 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
11401 here from IMemberFinder and don't implement this interface anymore.
11402 (DeclSpace.MemberCache): Moved here from IMemberFinder.
11404 * typemanager.cs (IMemberFinder): This interface is now only used by
11405 classes which actually support the member cache.
11406 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
11407 since we only put DeclSpaces into this Hashtable.
11408 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
11409 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
11411 2002-08-16 Martin Baulig <martin@gnome.org>
11413 * typemanager.cs (ICachingMemberFinder): Removed.
11414 (IMemberFinder.MemberCache): New property.
11415 (TypeManager.FindMembers): Merged this with RealFindMembers().
11416 This function will never be called from TypeManager.MemberLookup()
11417 so we can't use the cache here, just the IMemberFinder.
11418 (TypeManager.MemberLookup_FindMembers): Check whether the
11419 IMemberFinder has a MemberCache and call the cache's FindMembers
11421 (MemberCache): Rewrote larger parts of this yet another time and
11422 cleaned it up a bit.
11424 2002-08-15 Miguel de Icaza <miguel@ximian.com>
11426 * driver.cs (LoadArgs): Support quoting.
11428 (Usage): Show the CSC-like command line arguments.
11430 Improved a few error messages.
11432 2002-08-15 Martin Baulig <martin@gnome.org>
11434 * typemanager.cs (IMemberContainer.Type): New property.
11435 (IMemberContainer.IsInterface): New property.
11437 The following changes are conditional to BROKEN_RUNTIME, which is
11438 defined at the top of the file.
11440 * typemanager.cs (MemberCache.MemberCache): Don't add the base
11441 class'es members, but add all members from TypeHandle.ObjectType
11442 if we're an interface.
11443 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
11444 is the current type.
11445 (MemberCache.CacheEntry.Container): Removed this field.
11446 (TypeHandle.GetMembers): Include inherited members.
11448 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11450 * typemanager.cs: fixed compilation and added a comment on a field that
11453 2002-08-15 Martin Baulig <martin@gnome.org>
11455 * class.cs (ConstructorInitializer.Resolve): In the
11456 Expression.MemberLookup call, use the queried_type as
11459 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
11460 declared' attribute, it's always true.
11461 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
11462 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
11463 temporary wrapper for FindMembers which tells MemberLookup whether
11464 members from the base classes are included in the return value.
11465 This will go away soon.
11466 (TypeManager.MemberLookup): Use this temporary hack here; once the
11467 new MemberCache is completed, we don't need to do the DeclaredOnly
11468 looping here anymore since the MemberCache will take care of this.
11469 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
11470 (MemberCache): When creating the MemberCache for a class, get
11471 members from the current class and all its base classes.
11472 (MemberCache.CacheEntry.Container): New field. This is a
11473 temporary hack until the Mono runtime is fixed to distinguish
11474 between ReflectedType and DeclaringType. It allows us to use MCS
11475 with both the MS runtime and the unfixed Mono runtime without
11476 problems and without accecting performance.
11477 (MemberCache.SearchMembers): The DeclaredOnly looping from
11478 TypeManager.MemberLookup is now done here.
11480 2002-08-14 Martin Baulig <martin@gnome.org>
11482 * statement.cs (MyStructInfo.MyStructInfo): Don't call
11483 Type.GetFields on dynamic types but get the fields from the
11484 corresponding TypeContainer.
11485 (MyStructInfo.GetStructInfo): Added check for enum types.
11487 * typemanager.cs (MemberList.IsSynchronized): Implemented.
11488 (MemberList.SyncRoot): Implemented.
11489 (TypeManager.FilterWithClosure): No need to check permissions if
11490 closure_start_type == closure_invocation_type, don't crash if
11491 closure_invocation_type is null.
11493 2002-08-13 Martin Baulig <martin@gnome.org>
11495 Rewrote TypeContainer.FindMembers to use a member cache. This
11496 gives us a speed increase of about 35% for the self-hosting MCS
11497 build and of about 15-20% for the class libs (both on GNU/Linux).
11499 * report.cs (Timer): New class to get enhanced profiling. This
11500 whole class is "TIMER" conditional since it remarkably slows down
11503 * class.cs (MemberList): New class. This is an IList wrapper
11504 which we're now using instead of passing MemberInfo[]'s around to
11505 avoid copying this array unnecessarily.
11506 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
11507 (ICachingMemberFinder, IMemberContainer): New interface.
11508 (TypeManager.FilterWithClosure): If `criteria' is null, the name
11509 has already been checked, otherwise use it for the name comparision.
11510 (TypeManager.FindMembers): Renamed to RealMemberFinder and
11511 provided wrapper which tries to use ICachingMemberFinder.FindMembers
11512 if possible. Returns a MemberList, not a MemberInfo [].
11513 (TypeHandle): New class, implements IMemberContainer. We create
11514 one instance of this class per type, it contains a MemberCache
11515 which is used to do the member lookups.
11516 (MemberCache): New class. Each instance of this class contains
11517 all members of a type and a name-based hash table.
11518 (MemberCache.FindMembers): This is our new member lookup
11519 function. First, it looks up all members of the requested name in
11520 the hash table. Then, it walks this list and sorts out all
11521 applicable members and returns them.
11523 2002-08-13 Martin Baulig <martin@gnome.org>
11525 In addition to a nice code cleanup, this gives us a performance
11526 increase of about 1.4% on GNU/Linux - not much, but it's already
11527 half a second for the self-hosting MCS compilation.
11529 * typemanager.cs (IMemberFinder): New interface. It is used by
11530 TypeManager.FindMembers to call FindMembers on a TypeContainer,
11531 Enum, Delegate or Interface.
11532 (TypeManager.finder_to_member_finder): New PtrHashtable.
11533 (TypeManager.finder_to_container): Removed.
11534 (TypeManager.finder_to_delegate): Removed.
11535 (TypeManager.finder_to_interface): Removed.
11536 (TypeManager.finder_to_enum): Removed.
11538 * interface.cs (Interface): Implement IMemberFinder.
11540 * delegate.cs (Delegate): Implement IMemberFinder.
11542 * enum.cs (Enum): Implement IMemberFinder.
11544 * class.cs (TypeContainer): Implement IMemberFinder.
11546 2002-08-12 Martin Baulig <martin@gnome.org>
11548 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
11550 2002-08-12 Martin Baulig <martin@gnome.org>
11552 * ecore.cs (ITypeExpression): New interface for expressions which
11554 (TypeExpression): Renamed to TypeLookupExpression.
11555 (Expression.DoResolve): If we're doing a types-only lookup, the
11556 expression must implement the ITypeExpression interface and we
11557 call DoResolveType() on it.
11558 (SimpleName): Implement the new ITypeExpression interface.
11559 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
11560 hack, the situation that we're only looking up types can't happen
11561 anymore when this method is called. Moved the type lookup code to
11562 DoResolveType() and call it.
11563 (SimpleName.DoResolveType): This ITypeExpression interface method
11564 is now doing the types-only lookup.
11565 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
11566 (ResolveFlags): Added MaskExprClass.
11568 * expression.cs (MemberAccess): Implement the ITypeExpression
11570 (MemberAccess.DoResolve): Added support for a types-only lookup
11571 when we're called via ITypeExpression.DoResolveType().
11572 (ComposedCast): Implement the ITypeExpression interface.
11574 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
11575 Expression.Resolve() with ResolveFlags.Type instead.
11577 2002-08-12 Martin Baulig <martin@gnome.org>
11579 * interface.cs (Interface.Define): Apply attributes.
11581 * attribute.cs (Attribute.ApplyAttributes): Added support for
11582 interface attributes.
11584 2002-08-11 Martin Baulig <martin@gnome.org>
11586 * statement.cs (Block.Emit): Only check the "this" variable if we
11587 do not always throw an exception.
11589 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
11590 whether the property has a set accessor.
11592 2002-08-11 Martin Baulig <martin@gnome.org>
11594 Added control flow analysis support for structs.
11596 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
11597 with control flow analysis turned off.
11598 (IVariable): New interface.
11599 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
11600 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
11601 (FieldExpr.DoResolve): Resolve the instance expression with flow
11602 analysis turned off and do the definite assignment check after the
11603 resolving when we know what the expression will resolve to.
11605 * expression.cs (LocalVariableReference, ParameterReference):
11606 Implement the new IVariable interface, only call the flow analysis
11607 code if ec.DoFlowAnalysis is true.
11608 (This): Added constructor which takes a Block argument. Implement
11609 the new IVariable interface.
11610 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
11611 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
11612 This does the definite assignment checks for struct members.
11614 * class.cs (Constructor.Emit): If this is a non-static `struct'
11615 constructor which doesn't have any initializer, call
11616 Block.AddThisVariable() to tell the flow analysis code that all
11617 struct elements must be initialized before control returns from
11620 * statement.cs (MyStructInfo): New public class.
11621 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
11622 argument to this indexer. If non-zero, check an individual struct
11623 member, not the whole struct.
11624 (FlowBranching.CheckOutParameters): Check struct members.
11625 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
11626 overloaded versions of these methods which take an additional
11627 `int field_idx' argument to check struct members.
11628 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
11629 overloaded versions of these methods which take an additional
11630 `string field_name' argument to check struct member.s
11631 (VariableInfo): Implement the IVariable interface.
11632 (VariableInfo.StructInfo): New public property. Returns the
11633 MyStructInfo instance of the variable if it's a struct or null.
11634 (Block.AddThisVariable): New public method. This is called from
11635 Constructor.Emit() for non-static `struct' constructor which do
11636 not have any initializer. It creates a special variable for the
11637 "this" instance variable which will be checked by the flow
11638 analysis code to ensure that all of the struct's fields are
11639 initialized before control returns from the constructor.
11640 (UsageVector): Added support for struct members. If a
11641 variable/parameter is a struct with N members, we reserve a slot
11642 in the usage vector for each member. A struct is considered fully
11643 initialized if either the struct itself (slot 0) or all its
11644 members are initialized.
11646 2002-08-08 Martin Baulig <martin@gnome.org>
11648 * driver.cs (Driver.MainDriver): Only report an error CS5001
11649 if there were no compilation errors.
11651 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
11652 `UnsafeContext' property to determine whether the parent is in
11653 unsafe context rather than checking the parent's ModFlags:
11654 classes nested in an unsafe class are unsafe as well.
11656 2002-08-08 Martin Baulig <martin@gnome.org>
11658 * statement.cs (UsageVector.MergeChildren): Distinguish between
11659 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
11660 we return. Added test17() and test18() to test-154.cs.
11662 2002-08-08 Martin Baulig <martin@gnome.org>
11664 * typemanager.cs (TypeManager.FilterWithClosure): If we have
11665 Family access, make sure the invoking type isn't a subclass of the
11666 queried type (that'd be a CS1540).
11668 * ecore.cs (Expression.MemberLookup): Added overloaded version of
11669 this method which takes an additional `Type invocation_type'.
11671 * expression.cs (BaseAccess.DoResolve): Use the base type as
11672 invocation and query type.
11673 (MemberAccess.DoResolve): If the lookup failed and we're about to
11674 report a CS0122, try a lookup with the ec.ContainerType - if this
11675 succeeds, we must report a CS1540.
11677 2002-08-08 Martin Baulig <martin@gnome.org>
11679 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
11680 (MethodGroupExpr): Implement the IMemberExpr interface.
11682 * expression (MemberAccess.ResolveMemberAccess): No need to have
11683 any special code for MethodGroupExprs anymore, they're now
11686 2002-08-08 Martin Baulig <martin@gnome.org>
11688 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
11689 Family, FamANDAssem and FamORAssem permissions.
11690 (TypeManager.IsSubclassOrNestedChildOf): New public method.
11692 2002-08-08 Martin Baulig <martin@gnome.org>
11694 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
11695 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
11698 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
11700 * driver.cs: implemented /resource option to embed managed resources.
11702 2002-08-07 Martin Baulig <martin@gnome.org>
11704 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
11705 (FieldBase.HasFieldInitializer): New public property.
11706 (FieldBase.GetInitializerExpression): New public method. Resolves and
11707 returns the field initializer and makes sure it is only resolved once.
11708 (TypeContainer.EmitFieldInitializers): Call
11709 FieldBase.GetInitializerExpression to get the initializer, this ensures
11710 that it isn't resolved multiple times.
11712 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
11713 the resolving process (SimpleName/MemberLookup) that we're currently
11714 emitting a field initializer (which must not access any instance members,
11715 this is an error CS0236).
11717 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
11718 argument, if the `IsFieldInitializer' flag is set, we must report and
11719 error CS0236 and not an error CS0120.
11721 2002-08-07 Martin Baulig <martin@gnome.org>
11723 * ecore.cs (IMemberExpr): New public interface.
11724 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
11725 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
11726 if the expression is an IMemberExpr.
11728 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
11729 to be null, implicitly default to `this' if we're non-static in
11730 this case. Simplified the code a lot by using the new IMemberExpr
11731 interface. Also fixed bug #28176 here.
11733 2002-08-06 Martin Baulig <martin@gnome.org>
11735 * cs-parser.jay (SimpleLookup): Removed. We need to create
11736 ParameterReferences during semantic analysis so that we can do a
11737 type-only search when resolving Cast, TypeOf and SizeOf.
11738 (block): Pass the `current_local_parameters' to the Block's
11741 * class.cs (ConstructorInitializer): Added `Parameters parameters'
11742 argument to the constructor.
11743 (ConstructorInitializer.Resolve): Create a temporary implicit
11744 block with the parameters.
11746 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
11747 references here if we aren't doing a type-only search.
11749 * statement.cs (Block): Added constructor which takes a
11750 `Parameters parameters' argument.
11751 (Block.Parameters): New public property.
11753 * support.cs (InternalParameters.Parameters): Renamed `parameters'
11754 to `Parameters' and made it public readonly.
11756 2002-08-06 Martin Baulig <martin@gnome.org>
11758 * ecore.cs (Expression.Warning): Made this public as well.
11760 * report.cs (Report.Debug): Print the contents of collections.
11762 2002-08-06 Martin Baulig <martin@gnome.org>
11764 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
11765 used to tell Resolve() which kinds of expressions it may return.
11766 (Expression.Resolve): Added overloaded version of this method which
11767 takes a `ResolveFlags flags' argument. This can be used to tell
11768 Resolve() which kinds of expressions it may return. Reports a
11770 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
11771 ResolveFlags.SimpleName.
11772 (Expression.Error118): Added overloaded version of this method which
11773 takes a `ResolveFlags flags' argument. It uses the flags to determine
11774 which kinds of expressions are allowed.
11776 * expression.cs (Argument.ResolveMethodGroup): New public method.
11777 Resolves an argument, but allows a MethodGroup to be returned.
11778 This is used when invoking a delegate.
11780 * TODO: Updated a bit.
11782 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11784 Fixed compilation with csc.
11786 * ecore.cs: Expression.Error made public. Is this correct? Should
11787 Warning be made public too?
11789 * expression.cs: use ea.Location instead of ea.loc.
11790 [FIXME: Filed as bug #28607: MCS must report these errors.]
11792 2002-08-06 Martin Baulig <martin@gnome.org>
11794 * ecore.cs (Expression.loc): Moved the location here instead of
11795 duplicating it in all derived classes.
11796 (Expression.Location): New public property.
11797 (Expression.Error, Expression.Warning): Made them non-static and
11798 removed the location argument.
11799 (Expression.Warning): Added overloaded version which takes an
11800 `int level' argument.
11801 (Expression.Error118): Make this non-static and removed the
11802 expression and location arguments.
11803 (TypeExpr): Added location argument to the constructor.
11805 * expression.cs (StaticCallExpr): Added location argument to
11807 (Indirection, PointerArithmetic): Likewise.
11808 (CheckedExpr, UnCheckedExpr): Likewise.
11809 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
11810 (StringPtr): Likewise.
11813 2002-08-05 Martin Baulig <martin@gnome.org>
11815 * expression.cs (BaseAccess.DoResolve): Actually report errors.
11817 * assign.cs (Assign.DoResolve): Check whether the source
11818 expression is a value or variable.
11820 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
11821 while resolving the corresponding blocks.
11823 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
11824 an error, don't silently return null.
11826 * statement.cs (Block.AddVariable): Do the error reporting here
11827 and distinguish between CS0128 and CS0136.
11828 (Block.DoResolve): Report all unused labels (warning CS0164).
11829 (LabeledStatement): Pass the location to the constructor.
11830 (LabeledStatement.HasBeenReferenced): New property.
11831 (LabeledStatement.Resolve): Set it to true here.
11833 * statement.cs (Return.Emit): Return success even after reporting
11834 a type mismatch error (CS0126 or CS0127), this is what csc does and
11835 it avoids confusing the users with any consecutive errors.
11837 2002-08-05 Martin Baulig <martin@gnome.org>
11839 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
11841 * const.cs (Const.LookupConstantValue): Catch circular definitions.
11843 * expression.cs (MemberAccess.DoResolve): Silently return if an
11844 error has already been reported.
11846 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
11847 error has already been reported.
11849 2002-08-05 Martin Baulig <martin@gnome.org>
11851 * statement.cs (UsageVector): Only initialize the `parameters'
11852 vector if we actually have any "out" parameters.
11854 2002-08-05 Martin Baulig <martin@gnome.org>
11856 * expression.cs (Binary.ResolveOperator): When combining delegates,
11857 they must have the same type.
11859 2002-08-05 Martin Baulig <martin@gnome.org>
11861 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
11862 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
11863 work with the ms runtime and we also don't need it: if we're a
11864 PropertyBuilder and not in the `indexer_arguments' hash, then we
11865 are a property and not an indexer.
11867 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
11868 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
11869 since the latter one doesn't work with the ms runtime.
11871 2002-08-03 Martin Baulig <martin@gnome.org>
11873 Fixed bugs #27998 and #22735.
11875 * class.cs (Method.IsOperator): New public field.
11876 (Method.CheckBase): Report CS0111 if there's already a method
11877 with the same parameters in the current class. Report CS0508 when
11878 attempting to change the return type of an inherited method.
11879 (MethodData.Emit): Report CS0179 if a method doesn't have a body
11880 and it's not marked abstract or extern.
11881 (PropertyBase): New abstract base class for Property and Indexer.
11882 (PropertyBase.CheckBase): Moved here from Property and made it work
11884 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
11885 the same so we can reuse it there.
11886 (Property, Indexer): Derive from PropertyBase.
11887 (MethodSignature.inheritable_property_signature_filter): New delegate
11888 to find properties and indexers.
11890 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
11891 argument and improved error reporting.
11893 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
11894 EmptyReadOnlyParameters and made it a property.
11896 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
11897 version of this method which takes a `PropertyInfo indexer'.
11898 (TypeManager.RegisterIndexer): New method.
11900 * class.cs: Added myself as author of this file :-)
11902 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11904 * class.cs: fixed compilation on windoze.
11906 2002-08-03 Martin Baulig <martin@gnome.org>
11908 * interface.cs (Interface.GetInterfaceBases): Check whether all
11909 base interfaces are at least as accessible than the current one.
11911 * class.cs (TypeContainer.GetClassBases): Check whether base types
11912 are at least as accessible than the current type.
11913 (TypeContainer.AsAccessible): Implemented and made non-static.
11914 (MemberBase.CheckParameters): Report errors if the accessibility
11917 * delegate.cs (Delegate.Delegate): The default visibility is
11918 internal for top-level types and private for nested types.
11919 (Delegate.Define): Report errors if the accessibility checks fail.
11921 * enum.cs (Enum.Enum): The default visibility is internal for
11922 top-level types and private for nested types.
11923 (Enum.DefineType): Compute the correct visibility.
11925 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
11926 function which takes a `bool is_toplevel' instead of a TypeContainer.
11928 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
11931 2002-08-02 Martin Baulig <martin@gnome.org>
11933 * expression.cs (LocalVariableReferenc): Added constructor which
11934 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
11935 (LocalVariableReference.IsReadOnly): New property.
11936 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
11937 variable is readonly, use our own readonly flag to do this; you can
11938 use the new constructor to get a writable reference to a read-only
11941 * cs-parser.jay (foreach_statement, using_statement): Get a writable
11942 reference to the local variable.
11944 2002-08-01 Miguel de Icaza <miguel@ximian.com>
11946 * rootcontext.cs (ResolveCore): Also include System.Exception
11948 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
11949 we reach an EmptyStatement.
11951 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
11954 * expression.cs (Binary.ResolveOperator): Check error result in
11957 use brtrue/brfalse directly and avoid compares to null.
11959 2002-08-02 Martin Baulig <martin@gnome.org>
11961 * class.cs (TypeContainer.Define): Define all nested interfaces here.
11962 Fixes bug #28407, added test-155.cs.
11964 2002-08-01 Martin Baulig <martin@gnome.org>
11966 * class.cs (Event.EmitDefaultMethod): Make this work with static
11967 events. Fixes #28311, added verify-3.cs.
11969 2002-08-01 Martin Baulig <martin@gnome.org>
11971 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
11972 `is_disposable' fields.
11973 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
11974 `hm.is_disposable' if we're using the collection pattern.
11975 (Foreach.EmitCollectionForeach): Use the correct type for the
11976 enumerator's local variable, only emit the try/finally block if
11977 necessary (fixes #27713).
11979 2002-08-01 Martin Baulig <martin@gnome.org>
11981 * ecore.cs (Expression.report118): Renamed to Error118 and made
11984 * statement.cs (Throw.Resolve): Check whether the expression is of
11985 the correct type (CS0118) and whether the type derives from
11986 System.Exception (CS0155).
11987 (Catch.Resolve): New method. Do the type lookup here and check
11988 whether it derives from System.Exception (CS0155).
11989 (Catch.CatchType, Catch.IsGeneral): New public properties.
11991 * typemanager.cs (TypeManager.exception_type): Added.
11993 2002-07-31 Miguel de Icaza <miguel@ximian.com>
11995 * driver.cs: Updated About function.
11997 2002-07-31 Martin Baulig <martin@gnome.org>
11999 Implemented Control Flow Analysis.
12001 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
12002 (EmitContext.CurrentBranching): Added.
12003 (EmitContext.StartFlowBranching): Added.
12004 (EmitContext.EndFlowBranching): Added.
12005 (EmitContext.KillFlowBranching): Added.
12006 (EmitContext.IsVariableAssigned): Added.
12007 (EmitContext.SetVariableAssigned): Added.
12008 (EmitContext.IsParameterAssigned): Added.
12009 (EmitContext.SetParameterAssigned): Added.
12010 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
12011 Added control flow analysis stuff here.
12013 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
12014 resolve the expression as lvalue.
12015 (LocalVariableReference.DoResolve): Check whether the variable has
12016 already been assigned.
12017 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
12018 the parameter as assigned here.
12019 (ParameterReference.DoResolve): Check whether the parameter has already
12021 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
12022 expression as lvalue.
12024 * statement.cs (FlowBranching): New class for the flow analysis code.
12025 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
12026 (LabeledStatement.IsDefined): New public property.
12027 (LabeledStatement.AddUsageVector): New public method to tell flow
12028 analyis that the label may be reached via a forward jump.
12029 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
12031 (VariableInfo.Number): New public field. This is used by flow analysis
12032 to number all locals of a block.
12033 (Block.CountVariables): New public property. This is the number of
12034 local variables in this block (including the locals from all parent
12036 (Block.EmitMeta): Number all the variables.
12038 * statement.cs: Added flow analysis support to all classes.
12040 2002-07-31 Martin Baulig <martin@gnome.org>
12042 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
12043 To get debugging messages, compile mcs with /define:MCS_DEBUG and
12044 then use this argument.
12046 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
12048 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
12049 use this to specify /define options.
12051 2002-07-29 Martin Baulig <martin@gnome.org>
12053 * statement.cs (Fixed): Moved all code that does variable lookups
12054 and resolvings from Emit to Resolve.
12056 * statement.cs (For): Moved all code that does variable lookups
12057 and resolvings from Emit to Resolve.
12059 * statement.cs (Using): Moved all code that does variable lookups
12060 and resolvings from Emit to Resolve.
12062 2002-07-29 Martin Baulig <martin@gnome.org>
12064 * attribute.cs (Attribute.Resolve): Explicitly catch a
12065 System.NullReferenceException when creating the
12066 CustromAttributeBuilder and report a different warning message.
12068 2002-07-29 Martin Baulig <martin@gnome.org>
12070 * support.cs (ParameterData.ParameterName): Added method to
12071 get the name of a parameter.
12073 * typemanager.cs (TypeManager.IsValueType): New public method.
12075 2002-07-29 Martin Baulig <martin@gnome.org>
12077 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
12078 is a flag which specifies that it's either ref or out.
12079 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
12080 the out parameter to `out Parameter.Modifier mod', also set the
12081 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
12083 * support.cs (InternalParameters.ParameterModifier): Distinguish
12084 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
12085 Parameter.Modifier.ISBYREF flag if it's either ref or out.
12087 * expression.cs (Argument.GetParameterModifier): Distinguish
12088 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
12089 Parameter.Modifier.ISBYREF flag if it's either ref or out.
12091 2002-07-29 Martin Baulig <martin@gnome.org>
12093 * expression.cs (ParameterReference.ParameterReference): Added
12094 `Location loc' argument to the constructor.
12096 * cs-parser.jay: Pass location to ParameterReference.
12098 2002-07-28 Miguel de Icaza <miguel@ximian.com>
12100 * statement.cs (Try): Initialize the location.
12102 * cs-parser.jay: pass location to Try.
12104 * expression.cs (Unary.Reduce): Change the prototype to return
12105 whether a constant fold could be performed or not. The result is
12106 returned in an out parameters. In the case of Indirection and
12107 AddressOf, we want to perform the full tests.
12109 2002-07-26 Miguel de Icaza <miguel@ximian.com>
12111 * statement.cs (Statement.Emit): Flag dead code.
12113 2002-07-27 Andrew Birkett <andy@nobugs.org>
12115 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
12117 2002-07-27 Martin Baulig <martin@gnome.org>
12119 * class.cs (MethodData.Define): Put back call to
12120 TypeManager.AddMethod(), accidentally commented this out.
12122 * report.cs (Debug): New public method to print debugging information,
12123 this is `[Conditional ("DEBUG")]'.
12125 2002-07-26 Martin Baulig <martin@gnome.org>
12127 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
12128 (switch_statement): Push the current_block to the switch_stack and
12129 pop it again when we're done with the switch.
12130 (switch_section): The new block is a child of the current_block.
12131 Fixes bug #24007, added test-152.cs.
12133 2002-07-27 Martin Baulig <martin@gnome.org>
12135 * expression.cs (Invocation.EmitArguments): When calling a varargs
12136 function with only its fixed arguments, we need to pass an empty
12139 2002-07-27 Martin Baulig <martin@gnome.org>
12141 Mono 0.13 has been released.
12143 2002-07-25 Miguel de Icaza <miguel@ximian.com>
12145 * driver.cs: Rename --resource to --linkres, because that is what
12146 we do currently, we dont support --resource yet.
12148 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
12150 2002-07-25 Martin Baulig <martin@gnome.org>
12152 * class.cs (MethodData): New public class. This is a `method builder'
12153 class for a method or one accessor of a Property/Indexer/Event.
12154 (MethodData.GetMethodFlags): Moved here from MemberBase.
12155 (MethodData.ApplyAttributes): Likewise.
12156 (MethodData.ApplyObsoleteAttribute): Likewise.
12157 (MethodData.ApplyConditionalAttribute): Likewise.
12158 (MethodData.ApplyDllImportAttribute): Likewise.
12159 (MethodData.CheckAbstractAndExternal): Likewise.
12160 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
12161 (MethodData.Emit): Formerly known as Method.Emit().
12162 (MemberBase): Moved everything which was specific to a single
12163 accessor/method to MethodData.
12164 (Method): Create a new MethodData and call Define() and Emit() on it.
12165 (Property, Indexer, Event): Create a new MethodData objects for each
12166 accessor and call Define() and Emit() on them.
12168 2002-07-25 Martin Baulig <martin@gnome.org>
12170 Made MethodCore derive from MemberBase to reuse the code from there.
12171 MemberBase now also checks for attributes.
12173 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
12174 (MemberBase.GetMethodFlags): Moved here from class Method and marked
12176 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
12177 `CallingConventions cc' and `Attributes opt_attrs' arguments.
12178 (MemberBase.ApplyAttributes): New virtual method; applies the
12179 attributes to a method or accessor.
12180 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
12181 (MemberBase.ApplyConditionalAttribute): Likewise.
12182 (MemberBase.ApplyDllImportAttribute): Likewise.
12183 (MemberBase.CheckAbstractAndExternal): Likewise.
12184 (MethodCore.ParameterTypes): This is now a property instead of a
12185 method, it's initialized from DoDefineParameters().
12186 (MethodCore.ParameterInfo): Removed the set accessor.
12187 (MethodCore.DoDefineParameters): New protected virtual method to
12188 initialize ParameterTypes and ParameterInfo.
12189 (Method.GetReturnType): We can now simply return the MemberType.
12190 (Method.GetMethodFlags): Override the MemberBase version and add
12191 the conditional flags.
12192 (Method.CheckBase): Moved some code from Define() here, call
12193 DoDefineParameters() here.
12194 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
12195 here to avoid some larger code duplication.
12196 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
12197 ensure that abstract and external accessors don't declare a body.
12199 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
12200 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
12201 lookup in the attribute's parent classes, so we need to abort as soon
12202 as we found the first match.
12203 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
12204 the attribute has no arguments.
12206 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
12209 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
12211 * cs-parser.jay: reverted previous patch.
12213 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
12215 * cs-parser.jay: fixed bug #22119.
12217 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
12219 * attribute.cs: fixed compilation. The error was:
12220 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
12221 be assigned to before control leaves the current method."
12222 [FIXME: Filed as bug #28186: MCS must report this error.]
12224 2002-07-25 Martin Baulig <martin@gnome.org>
12226 * attribute.cs (Attribute.Conditional_GetConditionName): New static
12227 method to pull the condition name ouf of a Conditional attribute.
12228 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
12229 the obsolete message and error flag out of an Obsolete attribute.
12231 * class.cs (Method.GetMethodFlags): New public method to get the
12232 TypeManager.MethodFlags for this method.
12233 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
12235 (Method.Define): Get and apply the Obsolete and Conditional attributes;
12236 if we're overriding a virtual function, set the new private variable
12237 `parent_method'; call the new TypeManager.AddMethod().
12239 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
12240 the MethodBuilder and the Method in a PtrHashtable.
12241 (TypeManager.builder_to_method): Added for this purpose.
12242 (TypeManager.MethodFlags): Added IsObsoleteError.
12243 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
12244 Obsolete and Conditional arguments in MethodBuilders. If we discover
12245 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
12246 the message from the attribute.
12248 2002-07-24 Martin Baulig <martin@gnome.org>
12250 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
12251 preprocessor directives, ensure that the argument to #define/#undef is
12252 exactly one identifier and that it's actually an identifier.
12254 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
12257 2002-07-24 Martin Baulig <martin@gnome.org>
12259 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
12260 initialize it to TypeManager.object_type in the constructor.
12261 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
12262 of the `hm.get_current' method if we're using the collection pattern.
12263 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
12264 for the explicit conversion to make it work when we're using the collection
12265 pattern and the `Current' property has a different return type than `object'.
12268 2002-07-24 Martin Baulig <martin@gnome.org>
12270 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
12271 does not match, but don't report any errors. This method is called in
12272 order for all methods in a MethodGroupExpr until a matching method is
12273 found, so we don't want to bail out if the first method doesn't match.
12274 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
12275 matches, report the 123. Fixes #28070.
12277 2002-07-24 Martin Baulig <martin@gnome.org>
12279 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
12280 TypeManager.TypeToCoreType() to the top of the method so the
12281 following equality checks will work. Fixes #28107.
12283 2002-07-24 Martin Baulig <martin@gnome.org>
12285 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
12286 operand is of type uint, and the other operand is of type sbyte,
12287 short or int, the operands are converted to type long." -
12288 Actually do what this comment already told us. Fixes bug #28106,
12291 2002-07-24 Martin Baulig <martin@gnome.org>
12293 * class.cs (MethodBase): New abstract class. This is now a base
12294 class for Property, Indexer and Event to avoid some code duplication
12295 in their Define() and DefineMethods() methods.
12296 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
12297 generic methods for Define() and DefineMethods().
12298 (FieldBase): Derive from MemberBase, not MemberCore.
12299 (Property): Derive from MemberBase, not MemberCore.
12300 (Property.DefineMethod): Moved all the code from this method to the
12301 new MethodBase.DefineAccessor(), just call it with appropriate
12303 (Property.Define): Call the new Property.DoDefine(), this does some
12304 sanity checks and we don't need to duplicate the code everywhere.
12305 (Event): Derive from MemberBase, not MemberCore.
12306 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
12307 accessors, this will also make them work with interface events.
12308 (Indexer): Derive from MemberBase, not MemberCore.
12309 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
12310 (Indexer.Define): Use the new MethodBase functions.
12312 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
12313 argument to the constructor.
12314 (Interface.FindMembers): Added support for interface events.
12315 (Interface.PopluateEvent): Implemented.
12317 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
12319 2002-07-22 Miguel de Icaza <miguel@ximian.com>
12321 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
12322 but this is required to check for a method name being the same as
12323 the containing class.
12327 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
12329 * interface.cs: initialize variable.
12331 2002-07-23 Martin Baulig <martin@gnome.org>
12333 Implemented the IndexerName attribute in interfaces.
12335 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
12336 name if this is an explicit interface implementation.
12337 (Indexer.InterfaceIndexerName): New public variable. If we're
12338 implementing an interface indexer, this is the IndexerName in that
12339 interface. Otherwise, it's the IndexerName.
12340 (Indexer.DefineMethod): If we're implementing interface indexer,
12341 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
12342 and Pending.ImplementIndexer methods.
12343 (Indexer.Define): Also define the PropertyBuilder if we're
12344 implementing an interface indexer and this is neither an explicit
12345 interface implementation nor do the IndexerName match the one in
12348 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
12349 If a method is defined here, then we always need to create a proxy
12350 for it. This is used when implementing interface indexers.
12351 (Pending.IsInterfaceIndexer): New public method.
12352 (Pending.ImplementIndexer): New public method.
12353 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
12354 This is used when implementing interface indexers to define a proxy
12356 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
12357 define a proxy if necessary.
12359 * interface.cs (Interface.IndexerName): New public variable.
12360 (Interface.PopulateIndexer): Set the IndexerName.
12361 (Interface.DefineIndexers): New private method. Populate all the
12362 indexers and make sure their IndexerNames match.
12364 * typemanager.cs (IndexerPropertyName): Added support for interface
12367 2002-07-22 Martin Baulig <martin@gnome.org>
12369 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
12370 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
12371 ret if HasReturnLabel.
12372 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
12375 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
12376 and set the ec.LoopBeginTryCatchLevel.
12377 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
12378 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
12379 the current ec.TryCatchLevel, the branch goes out of an exception
12380 block. In this case, we need to use Leave and not Br.
12382 2002-07-22 Martin Baulig <martin@gnome.org>
12384 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
12385 block unless the block does not always return or it is contained in
12386 another try { ... } catch { ... } block. Fixes bug #26506.
12387 Added verify-1.cs to the test suite.
12389 2002-07-22 Martin Baulig <martin@gnome.org>
12391 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
12392 then we do not always return. Fixes bug #24985.
12394 2002-07-22 Martin Baulig <martin@gnome.org>
12396 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
12397 lookup on a per-class level; ie. walk up the class hierarchy until we
12398 found at least one applicable method, then choose the best among them.
12399 Fixes bug #24463 and test-29.cs.
12401 2002-07-22 Martin Baulig <martin@gnome.org>
12403 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
12404 return types of the methods. The return type is not part of the
12405 signature and we must not check it to make the `new' modifier work.
12406 Fixes bug #27999, also added test-147.cs.
12407 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
12409 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
12410 on the method's return type.
12412 2002-07-21 Martin Baulig <martin@gnome.org>
12414 * assign.cs: Make this work if the rightmost source is a constant and
12415 we need to do an implicit type conversion. Also adding a few more tests
12416 to test-38.cs which should have caught this.
12418 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
12419 target in the makefile for this. The makefile.gnu is primarily intended
12420 for end-users who don't want to debug the compiler.
12422 2002-07-21 Martin Baulig <martin@gnome.org>
12424 * assign.cs: Improved the Assign class so it can now handle embedded
12425 assignments (X = Y = Z = something). As a side-effect this'll now also
12426 consume less local variables. test-38.cs now passes with MCS, added
12427 a few new test cases to that test.
12429 2002-07-20 Martin Baulig <martin@gnome.org>
12431 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
12432 instructions. Fixes bug #27977, also added test-146.cs.
12434 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
12436 * cs-tokenizer.cs: fixed getHex ().
12438 2002-07-19 Martin Baulig <martin@gnome.org>
12440 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
12441 not Type.GetType() to lookup the array type. This is needed when
12442 we're constructing an array of a user-defined type.
12443 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
12444 single-dimensional arrays, but also for single-dimensial arrays of
12447 2002-07-19 Martin Baulig <martin@gnome.org>
12449 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
12450 this function is called, it's not allowed to share LocalBuilders
12451 among ILGenerators.
12453 2002-07-19 Martin Baulig <martin@gnome.org>
12455 * expression.cs (Argument.Resolve): Report an error 118 when trying
12456 to pass a type as argument.
12458 2002-07-18 Martin Baulig <martin@gnome.org>
12460 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
12461 Conv_R_Un for the signed `long' type.
12463 2002-07-15 Miguel de Icaza <miguel@ximian.com>
12465 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
12466 `expr' for the temporary result, as that will fail if we do
12467 multiple resolves on the same expression.
12469 2002-07-05 Miguel de Icaza <miguel@ximian.com>
12471 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
12472 ec.TypeContainer for looking up aliases.
12474 * class.cs (TypeContainer): Remove LookupAlias from here.
12476 * decl.cs (DeclSpace); Move here.
12478 2002-07-01 Miguel de Icaza <miguel@ximian.com>
12480 * class.cs (FindMembers): Only call filter if the constructor
12481 bulider is not null.
12483 Also handle delegates in `NestedTypes' now. Now we will perform
12484 type lookups using the standard resolution process. This also
12487 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
12488 This uses Expressions (the limited kind that can be parsed by the
12489 tree) instead of strings.
12491 * expression.cs (ComposedCast.ToString): Implement, used to flag
12492 errors since now we have to render expressions.
12494 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
12497 * ecore.cs (SimpleName.ToString): ditto.
12499 * cs-parser.jay: Instead of using strings to assemble types, use
12500 Expressions to assemble the type (using SimpleName, ComposedCast,
12501 MemberAccess). This should fix the type lookups in declarations,
12502 because we were using a different code path for this.
12504 * statement.cs (Block.Resolve): Continue processing statements
12505 even when there is an error.
12507 2002-07-17 Miguel de Icaza <miguel@ximian.com>
12509 * class.cs (Event.Define): Also remove the `remove' method from
12510 the list of pending items.
12512 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
12513 generate more compact code.
12515 2002-07-17 Martin Baulig <martin@gnome.org>
12517 * const.cs (Const.LookupConstantValue): Add support for constant
12518 `unchecked' and `checked' expressions.
12519 Also adding test case test-140.cs for this.
12521 2002-07-17 Martin Baulig <martin@gnome.org>
12523 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
12524 check whether mi.ReturnType implements the IEnumerator interface; the
12525 `==' and the IsAssignableFrom() will fail in this situation.
12527 2002-07-16 Ravi Pratap <ravi@ximian.com>
12529 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
12532 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
12534 * expression.cs: fixed bug #27811.
12536 2002-07-14 Miguel de Icaza <miguel@ximian.com>
12538 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
12539 Molaro: when we are a ref, the value already contains a pointer
12540 value, do not take the address of it.
12542 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
12543 * removed mb-parser.jay and mb-tokenizer.cs
12545 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
12547 * expression.cs: check against the building corlib void type.
12549 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
12551 * ecore.cs: fix for valuetype static readonly fields: when
12552 initializing them, we need their address, not the address of a copy.
12554 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
12556 * typemanager.cs: register also enum_type in corlib.
12558 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
12560 * class.cs: allow calling this (but not base) initializers in structs.
12562 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
12564 * ecore.cs: make sure we compare against the building base types
12567 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
12569 * typemanager.cs: fix TypeToCoreType() to handle void and object
12570 (corlib gets no more typerefs after this change).
12572 2002-07-12 Miguel de Icaza <miguel@ximian.com>
12574 * expression.cs (ArrayCreation.EmitArrayArguments): use
12575 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
12577 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
12578 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
12579 array indexes, the runtime actually forbids them.
12581 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
12582 for array arguments here.
12584 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
12585 instead of the default for ValueTypes.
12587 (New.DoEmit): Use IsValueType instead of
12588 IsSubclassOf (value_type)
12589 (New.DoResolve): ditto.
12590 (Invocation.EmitCall): ditto.
12592 * assign.cs (Assign): ditto.
12594 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
12595 Statements *are* currently doing part of their resolution during
12598 Expressions do always resolve during resolve, but statements are
12599 only required to propagate resolution to their children.
12601 2002-07-11 Miguel de Icaza <miguel@ximian.com>
12603 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
12605 (LoadAssembly): Do not add the dll if it is already specified
12607 (MainDriver): Add the System directory to the link path at the end,
12608 after all the other -L arguments.
12610 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
12611 wrong opcode for loading bytes and bools (ldelem.i1 instead of
12612 ldelem.u1) and using the opposite for sbytes.
12614 This fixes Digger, and we can finally run it.
12616 * driver.cs (UnixParseOption): Move the option parsing here.
12617 (CSCParseOption): Implement CSC-like parsing of options.
12619 We now support both modes of operation, the old Unix way, and the
12620 new CSC-like way. This should help those who wanted to make cross
12621 platform makefiles.
12623 The only thing broken is that /r:, /reference: and /lib: are not
12624 implemented, because I want to make those have the same semantics
12625 as the CSC compiler has, and kill once and for all the confussion
12626 around this. Will be doing this tomorrow.
12628 * statement.cs (Unsafe.Resolve): The state is checked during
12629 resolve, not emit, so we have to set the flags for IsUnsfe here.
12631 2002-07-10 Miguel de Icaza <miguel@ximian.com>
12633 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
12634 not catch the Error_ObjectRefRequired in SimpleName (as it is
12635 possible to have a class/instance variable name that later gets
12636 deambiguated), we have to check this here.
12638 2002-07-10 Ravi Pratap <ravi@ximian.com>
12640 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
12641 make static and put into Expression.
12643 (Event.Define): Register the private field of the event with the
12644 TypeManager so that GetFieldFromEvent can get at it.
12646 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
12647 keep track of the private field associated with an event which
12650 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
12653 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
12655 2002-07-10 Miguel de Icaza <miguel@ximian.com>
12657 * expression.cs (Binary.EmitBranchable): this routine emits the
12658 Binary expression in a branchable context. This basically means:
12659 we need to branch somewhere, not just get the value on the stack.
12661 This works together with Statement.EmitBoolExpression.
12663 * statement.cs (Statement.EmitBoolExpression): Use
12666 2002-07-09 Miguel de Icaza <miguel@ximian.com>
12668 * statement.cs (For): Reduce the number of jumps in loops.
12670 (For): Implement loop inversion for the For statement.
12672 (Break): We can be breaking out of a Try/Catch controlled section
12673 (foreach might have an implicit try/catch clause), so we need to
12674 use Leave instead of Br.
12676 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
12677 now). If the instace expression supports IMemoryLocation, we use
12678 the AddressOf method from the IMemoryLocation to extract the
12679 address instead of emitting the instance.
12681 This showed up with `This', as we were emitting the instance
12682 always (Emit) instead of the Address of This. Particularly
12683 interesting when This is a value type, as we dont want the Emit
12684 effect (which was to load the object).
12686 2002-07-08 Miguel de Icaza <miguel@ximian.com>
12688 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
12690 * statement.cs (Checked): Set the CheckedState during the resolve
12691 process too, as the ConvCast operations track the checked state on
12692 the resolve process, and not emit.
12694 * cs-parser.jay (namespace_member_declaration): Flag that we have
12695 found a declaration when we do. This is used to flag error 1529
12697 * driver.cs: Report ok when we display the help only.
12699 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
12701 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
12703 2002-07-04 Miguel de Icaza <miguel@ximian.com>
12705 * cs-tokenizer.cs (define): We also have to track locally the
12706 defines. AllDefines is just used for the Conditional Attribute,
12707 but we also need the local defines for the current source code.
12709 2002-07-03 Miguel de Icaza <miguel@ximian.com>
12711 * statement.cs (While, For, Do): These loops can exit through a
12712 Break statement, use this information to tell whether the
12713 statement is the last piece of code.
12715 (Break): Flag that we break.
12717 * codegen.cs (EmitContexts): New `Breaks' state variable.
12719 2002-07-03 Martin Baulig <martin@gnome.org>
12721 * class.cs (TypeContainer.MethodModifiersValid): Allow override
12722 modifiers in method declarations in structs. Otherwise, you won't
12723 be able to override things like Object.Equals().
12725 2002-07-02 Miguel de Icaza <miguel@ximian.com>
12727 * class.cs (Method, Property, Indexer): Do not allow the public
12728 modifier to be used in explicit interface implementations.
12730 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
12731 override modifiers in method declarations in structs
12733 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
12735 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
12736 integer or real overflow, report an error
12738 2002-07-02 Martin Baulig <martin@gnome.org>
12740 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
12741 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
12742 to tell the runtime about our newly created System.Object and
12743 System.ValueType types.
12745 2002-07-02 Miguel de Icaza <miguel@ximian.com>
12747 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
12748 struct instead of Ldarg/Starg.
12750 2002-07-02 Martin Baulig <martin@gnome.org>
12752 * expression.cs (Indirection.Indirection): Call
12753 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
12755 2002-07-02 Martin Baulig <martin@gnome.org>
12757 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
12758 ValueType, call TypeManager.TypeToCoreType() on it.
12759 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
12760 the OpCodes.Newarr argument.
12762 2002-07-02 Martin Baulig <martin@gnome.org>
12764 * expression.cs (Invocation.EmitCall): When compiling corlib,
12765 replace all calls to the system's System.Array type to calls to
12766 the newly created one.
12768 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
12769 System.Array methods.
12770 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
12771 from the system's System.Array type which must be replaced.
12773 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
12775 * typemanager.cs: load unverifiable_code_ctor so we can build
12776 corlib using the correct type. Avoid using GetTypeCode() with
12778 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
12779 TypeManager.object_type to allow building corlib.
12781 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
12783 * ecore.cs: handle System.Enum separately in LoadFromPtr().
12785 2002-07-01 Martin Baulig <martin@gnome.org>
12787 * class.cs: Make the last change actually work, we need to check
12788 whether `ifaces != null' to avoid a crash.
12790 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
12792 * class.cs: when we build structs without fields that implement
12793 interfaces, we need to add the interfaces separately, since there is
12794 no API to both set the size and add the interfaces at type creation
12797 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
12799 * expression.cs: the dimension arguments to the array constructors
12800 need to be converted if they are a long.
12802 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
12804 * class.cs: don't emit ldarg.0 if there is no parent constructor
12805 (fixes showstopper for corlib).
12807 2002-06-29 Martin Baulig <martin@gnome.org>
12809 MCS now compiles corlib on GNU/Linux :-)
12811 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
12812 ie. check for MethodImplOptions.InternalCall.
12814 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
12815 and TypeManager.attribute_type are null, so we must explicitly check
12816 whether parent is not null to find out whether it's an attribute type.
12817 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
12818 and SetBuilder, not only if the property is neither abstract nor external.
12819 This is necessary to set the MethodImplOptions on the accessor methods.
12820 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
12821 SetBuilder, see Property.Emit().
12823 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
12824 populate "System.Object", "System.ValueType" and "System.Attribute" since
12825 they've already been populated from BootCorlib_PopulateCoreTypes().
12827 2002-06-29 Martin Baulig <martin@gnome.org>
12829 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
12830 is the NullLiteral, we also need to make sure that target_type is not
12833 2002-06-29 Martin Baulig <martin@gnome.org>
12835 * rootcontext.cs (RootContext.ResolveCore): We must initialize
12836 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
12837 before calling BootstrapCorlib_ResolveDelegate ().
12839 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
12841 * statement.cs: fixed build-breaker. All tests passed ok.
12843 2002-06-27 Martin Baulig <martin@gnome.org>
12845 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
12846 for System.Decimal when compiling corlib.
12848 2002-06-27 Martin Baulig <martin@gnome.org>
12850 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
12851 switch blocks which contain nothing but a default clause.
12853 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
12855 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
12857 2002-06-27 Martin Baulig <martin@gnome.org>
12859 * ecore.cs (PropertyExpr.PropertyExpr): Call
12860 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
12862 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
12863 is already a TypeBuilder.
12865 2002-06-27 Martin Baulig <martin@gnome.org>
12867 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
12868 `target_type == TypeManager.array_type', not IsAssignableFrom() in
12869 the "from an array-type to System.Array" case. This makes it work
12870 when compiling corlib.
12872 2002-06-27 Martin Baulig <martin@gnome.org>
12874 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
12875 non-static PropertyExpr, set its InstanceExpression. This makes
12876 the `ICollection.Count' property work in System/Array.cs.
12878 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
12880 * driver.cs: Made error handling more consistent. Errors now
12881 tracked by Report class, so many methods which used to return int
12882 now return void. Main() now prints success/failure and
12883 errors/warnings message.
12885 Renamed '--probe' compiler argument to '--expect-error'. Removed
12886 the magic number return values (123 and 124). Now, if the
12887 expected error occurs, the compiler exits with success (exit value
12888 0). If the compilation completes without seeing that particular
12889 error, the compiler exits with failure (exit value 1). The
12890 makefile in mcs/errors has been changed to handle the new behaviour.
12892 * report.cs: Made 'expected error' number a property and renamed
12893 it from 'Probe' to 'ExpectedError'.
12895 * genericparser.cs: Removed error handling support, since it is
12896 now all done by Report class.
12898 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
12899 class, so parse() no longer returns an int.
12901 * namespace.cs: Use Report.Error instead of GenericParser.error
12903 2002-06-22 Miguel de Icaza <miguel@ximian.com>
12905 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
12906 TypeContainer.AddOperator): At the front of the list put the
12907 explicit implementations, so they get resolved/defined first.
12909 2002-06-21 Miguel de Icaza <miguel@ximian.com>
12911 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
12912 interface type is implemented by this TypeContainer. Used during
12913 explicit interface implementation.
12915 (Property.Define, Indexer.Define, Method.Define): Validate that
12916 the given interface in the explicit implementation is one of the
12917 base classes for the containing type.
12919 Also if we are explicitly implementing an interface, but there is
12920 no match in the pending implementation table, report an error.
12922 (Property.Define): Only define the property if we are
12923 not explicitly implementing a property from an interface. Use the
12924 correct name also for those properties (the same CSC uses,
12925 although that is really not needed).
12927 (Property.Emit): Do not emit attributes for explicitly implemented
12928 properties, as there is no TypeBuilder.
12930 (Indexer.Emit): ditto.
12932 Hiding then means that we do not really *implement* a pending
12933 implementation, which makes code fail.
12935 2002-06-22 Martin Baulig <martin@gnome.org>
12937 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
12938 the return value of Object.GetType(). [FIXME: we need to do this whenever
12939 we get a type back from the reflection library].
12941 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
12943 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
12945 2002-06-20 Miguel de Icaza <miguel@ximian.com>
12947 * attribute.cs: Return null if we can not look up the type.
12949 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
12950 the interface types found.
12952 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
12953 interface types found.
12955 * typemanager.cs (GetInterfaces): Make this routine returns alll
12956 the interfaces and work around the lame differences between
12957 System.Type and System.Reflection.Emit.TypeBuilder in the results
12958 result for GetInterfaces.
12960 (ExpandInterfaces): Given an array of interface types, expand and
12961 eliminate repeated ocurrences of an interface. This expands in
12962 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
12965 2002-06-21 Martin Baulig <martin@gnome.org>
12967 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
12970 2002-06-21 Martin Baulig <martin@gnome.org>
12972 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
12973 and called with one of the core types, return the corresponding typebuilder for
12976 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
12979 2002-06-21 Martin Baulig <martin@gnome.org>
12981 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
12982 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
12983 (Expression.ConvertReferenceExplicit): Likewise.
12985 * expression.cs (ElementAccess.DoResolve): Likewise.
12986 (ElementAccess.DoResolveLValue): Likewise.
12988 2002-06-10 Martin Baulig <martin@gnome.org>
12990 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
12991 add the "value" parameter to the parameter list.
12993 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
12996 2002-06-19 Miguel de Icaza <miguel@ximian.com>
12998 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
12999 the argument to an int, uint, long or ulong, per the spec. Also
13000 catch negative constants in array creation.
13002 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
13004 * class.cs: do not allow the same interface to appear twice in
13005 the definition list.
13007 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
13009 * ecore.cs: don't use ldlen with System.Array.
13011 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
13013 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
13015 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
13017 * modifiers.cs: produce correct field attributes for protected
13018 internal. Easy fix so miguel can work on ther harder stuff:-)
13020 2002-06-18 Miguel de Icaza <miguel@ximian.com>
13022 * pending.cs: New file. Move the code from class.cs here.
13023 Support clearning the pending flag for all methods (when not doing
13024 explicit interface implementation).
13026 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
13028 * rootcontext.cs: added a couple more types needed to bootstrap.
13030 2002-06-17 Miguel de Icaza <miguel@ximian.com>
13032 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
13033 constructor in the type, instead of any constructor in the type
13034 hierarchy. Thanks to Paolo for finding this bug (it showed up as
13035 a bug in the Mono runtime when applying the params attribute).
13037 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
13038 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
13040 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
13042 * expression.cs (Unary.ResolveOperator): Use TypeManager
13043 to resolve the type.
13045 2002-06-13 Ravi Pratap <ravi@ximian.com>
13047 * cs-parser.jay (enum_member_declaration): Pass in the attributes
13050 * enum.cs (AddEnumMember): Add support to store the attributes associated
13051 with each member too.
13053 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
13054 field builders too - this takes care of the enum member case.
13056 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
13058 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
13059 address-of operator on both value types and pointers.
13061 2002-06-10 Martin Baulig <martin@gnome.org>
13063 * interface.cs (Interface.PopulateIndexer): Add the indexer's
13064 PropertyBuilder to the `property_builders' list.
13066 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
13067 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
13068 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
13069 find any indexers which are inherited from an interface.
13071 2002-06-09 Martin Baulig <martin@gnome.org>
13073 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
13074 the same type as the constant if necessary. There's also a test-130.cs
13077 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
13079 * typemanager.cs (TypeManager.ChangeType): Previously known as
13080 Enum.ChangeEnumType().
13082 2002-06-09 Martin Baulig <martin@gnome.org>
13084 * expression.cs (Cast.TryReduce): Added support for consts.
13086 2002-06-08 Ravi Pratap <ravi@ximian.com>
13088 * class.cs (Accessor): Hold attributes information so we can pass
13091 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
13092 Modify to pass in attributes attached to the methods.
13094 (add_accessor_declaration, remove_accessor_declaration): Ditto.
13096 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
13097 to handle the Accessor kind :-)
13099 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
13101 2002-06-08 Martin Baulig <martin@gnome.org>
13103 * expression.cs (Unary.TryReduceNegative): Added support for
13106 2002-06-08 Martin Baulig <martin@gnome.org>
13108 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
13109 name can't be found in the `defined_names' - the caller will do a
13110 MemberLookup in this case and thus find methods in System.Enum
13111 such as Enum.IsDefined().
13113 2002-06-08 Martin Baulig <martin@gnome.org>
13115 * enum.cs (Enum.ChangeEnumType): This is a custom version of
13116 Convert.ChangeType() which works with TypeBuilder created types.
13117 (Enum.LookupEnumValue, Enum.Define): Use it here.
13119 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
13120 `TypeBuilder.BaseType != null' check.
13121 (TypeContainer.FindMembers): Only lookup parent members if we
13122 actually have a parent.
13123 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
13124 (ConstructorInitializer.Resolve): Likewise.
13126 * interface.cs (Interface.FindMembers): Added
13127 `TypeBuilder.BaseType != null' check.
13129 * rootcontext.cs (RootContext.ResolveCore): Added
13130 "System.Runtime.CompilerServices.IndexerNameAttribute" to
13131 classes_second_stage.
13133 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
13134 debug_type and trace_type when compiling with --nostdlib.
13136 2002-06-07 Martin Baulig <martin@gnome.org>
13138 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
13139 (AddField): Set it to true when adding a non-static field.
13140 (DefineType): Use `have_nonstatic_fields' to find out whether we
13141 have non-static fields, not `Fields != null'.
13143 2002-06-02 Miguel de Icaza <miguel@ximian.com>
13145 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
13146 dereferencing a null on the static-field code path)
13148 2002-05-30 Martin Baulig <martin@gnome.org>
13150 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
13151 to take command line arguments. Use reflection to call the new
13152 custom `Initialize' function on the symbol writer and pass it the
13153 command line arguments.
13155 * driver.cs (--debug-args): New command line argument to pass command
13156 line arguments to the symbol writer.
13158 2002-05-28 Miguel de Icaza <miguel@ximian.com>
13160 * assign.cs (DoResolve): Forgot to do the implicit conversion to
13161 the target type for indexers and properties. Thanks to Joe for
13164 2002-05-27 Miguel de Icaza <miguel@ximian.com>
13166 * typemanager.cs (MethodFlags): returns the method flags
13167 (Obsolete/ShouldIgnore) that control warning emission and whether
13168 the invocation should be made, or ignored.
13170 * expression.cs (Invocation.Emit): Remove previous hack, we should
13171 not do this on matching a base type, we should do this based on an attribute
13173 Only emit calls to System.Diagnostics.Debug and
13174 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
13175 on the command line.
13177 * rootcontext.cs: Global settings for tracing and debugging.
13179 * cs-tokenizer.cs (define): New utility function to track
13180 defines. Set the global settings for TRACE and DEBUG if found.
13182 2002-05-25 Ravi Pratap <ravi@ximian.com>
13184 * interface.cs (Populate*): Pass in the TypeContainer as well as
13185 the DeclSpace as parameters so that we can create EmitContexts and
13186 then use that to apply attributes etc.
13188 (PopulateMethod, PopulateEvent, PopulateProperty)
13189 (PopulateIndexer): Apply attributes everywhere.
13191 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
13194 (ApplyAttributes): Update accordingly.
13196 We now apply interface attributes for all members too.
13198 2002-05-26 Miguel de Icaza <miguel@ximian.com>
13200 * class.cs (Indexer.Define); Correctly check if we are explicit
13201 implementation (instead of checking the Name for a ".", we
13202 directly look up if the InterfaceType was specified).
13204 Delay the creation of the PropertyBuilder.
13206 Only create the PropertyBuilder if we are not an explicit
13207 interface implementation. This means that explicit interface
13208 implementation members do not participate in regular function
13209 lookups, and hence fixes another major ambiguity problem in
13210 overload resolution (that was the visible effect).
13212 (DefineMethod): Return whether we are doing an interface
13215 * typemanager.cs: Temporary hack until we get attributes in
13216 interfaces (Ravi is working on that) and we get IndexerName
13217 support in interfaces.
13219 * interface.cs: Register the indexers as properties.
13221 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
13222 warning, I have verified that this is a bug in the .NET runtime
13223 (JavaScript suffers of the same problem).
13225 * typemanager.cs (MemberLookup): When looking up members for
13226 interfaces, the parent of an interface is the implicit
13227 System.Object (so we succeed in searches of Object methods in an
13228 interface method invocation. Example: IEnumerable x; x.ToString
13231 2002-05-25 Miguel de Icaza <miguel@ximian.com>
13233 * class.cs (Event): Events should also register if they do
13234 implement the methods that an interface requires.
13236 * typemanager.cs (MemberLookup); use the new GetInterfaces
13239 (GetInterfaces): The code used to lookup interfaces for a type is
13240 used in more than one place, factor it here.
13242 * driver.cs: Track the errors at the bottom of the file, we kept
13245 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
13246 instance if the method we are calling is static!
13248 2002-05-24 Miguel de Icaza <miguel@ximian.com>
13250 * attribute.cs (ApplyAttributes): Make this function filter out
13251 the IndexerName attribute (as that attribute in reality is never
13252 applied) and return the string constant for the IndexerName
13255 * class.cs (TypeContainer.Emit): Validate that all the indexers
13256 have the same IndexerName attribute, and if so, set the
13257 DefaultName attribute on the class.
13259 * typemanager.cs: The return value might contain other stuff (not
13260 only methods). For instance, consider a method with an "Item"
13261 property and an Item method.
13263 * class.cs: If there is a problem with the parameter types,
13266 2002-05-24 Ravi Pratap <ravi@ximian.com>
13268 * ecore.cs (ImplicitConversionExists): Wrapper function which also
13269 looks at user defined conversion after making a call to
13270 StandardConversionExists - we need this for overload resolution.
13272 * expression.cs : Update accordingly the various method calls.
13274 This fixes 2 bugs filed against implicit user defined conversions
13276 2002-05-22 Miguel de Icaza <miguel@ximian.com>
13278 * statement.cs: Track the result of the assignment.
13280 2002-05-21 Miguel de Icaza <miguel@ximian.com>
13282 * expression.cs (MemberAccess): Improved error reporting for
13283 inaccessible members.
13285 2002-05-22 Martin Baulig <martin@gnome.org>
13287 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
13288 itself with debugging support.
13290 2002-05-22 Martin Baulig <martin@gnome.org>
13292 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
13293 Removed, this isn't needed anymore.
13295 2002-05-20 Martin Baulig <martin@gnome.org>
13297 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
13298 be underlying type for an enum.
13300 2002-05-20 Miguel de Icaza <miguel@ximian.com>
13302 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
13303 that splits out the loading of just the core types.
13305 * rootcontext.cs (ResolveCore): Split the struct resolution in
13306 two, so we can load the enumeration underlying types before any
13309 * expression.cs (Is): Bandaid until we fix properly Switch (see
13310 bug #24985 for details).
13312 * typemanager.cs (ImplementsInterface): The hashtable will contain
13313 a null if there are no interfaces implemented.
13315 2002-05-18 Miguel de Icaza <miguel@ximian.com>
13317 * cs-parser.jay (indexer_declarator): It is fine to have array
13320 2002-05-17 Miguel de Icaza <miguel@ximian.com>
13322 * typemanager.cs: (RegisterBuilder): New function used to register
13323 TypeBuilders that implement interfaces. Since
13324 TypeBuilder.GetInterfaces (as usual) does not work with lame
13326 (AddUserType): register interfaces.
13328 (ImplementsInterface): Use the builder_to_ifaces hash if we are
13329 dealing with TypeBuilder. Also, arrays are showing up as
13330 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
13331 methods can not be invoked on them!
13333 * ecore.cs (ExplicitReferenceConversionExists): Made public.
13334 (ImplicitReferenceConversionExists): Split out from
13335 StandardConversionExists.
13337 * expression.cs (As): We were only implementing one of the three
13338 cases for the as operator. We now implement them all.
13339 (Is): Implement the various other cases for Is as well.
13341 * typemanager.cs (CACHE): New define used to control if we want or
13342 not the FindMembers cache. Seems to have a negative impact on
13343 performance currently
13345 (MemberLookup): Nested types have full acess to
13346 enclosing type members
13348 Remove code that coped with instance/static returns for events, we
13349 now catch this in RealFindMembers.
13351 (RealFindMembers): only perform static lookup if the instance
13352 lookup did not return a type or an event.
13354 2002-05-17 Miguel de Icaza <miguel@ximian.com>
13356 * assign.cs (CompoundAssign): We pass more semantic information
13357 now to Compound Assignments than we did before: now we have all
13358 the information at hand, and now we resolve the target *before* we
13359 do the expression expansion, which allows the "CacheValue" method
13360 to have the effect we intended (before, a [x] += 1 would generate
13361 two differen ArrayAccess expressions from the ElementAccess,
13362 during the resolution process).
13364 (CompoundAssign.DoResolve): Resolve target and original_source here.
13366 2002-05-16 Miguel de Icaza <miguel@ximian.com>
13368 * expression.cs (ArrayAccess): dropped debugging information.
13370 * typemanager.cs: Small bug fix: I was always returning i_members,
13371 instead of one of i_members or s_members (depending on which had
13374 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
13375 method is invoked before any code generation takes place, and it
13376 is a mechanism to inform that the expression will be invoked more
13377 than once, and that the method should use temporary values to
13378 avoid having side effects
13380 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
13382 * ecore.cs (Expression.CacheTemporaries): Provide empty default
13385 * expression.cs (Indirection, ArrayAccess): Add support for
13386 CacheTemporaries in these two bad boys.
13388 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
13389 ldobj or ldind_ref.
13390 (StoreFromPtr): Handle stobj as well.
13392 * expression.cs (UnaryMutator): Share more code.
13394 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
13395 down: I was not tracking the Filter function as well, which
13396 was affecting the results of the cache.
13398 2002-05-15 Miguel de Icaza <miguel@ximian.com>
13400 * attribute.cs: Remove the hack to handle the CharSet property on
13403 2002-05-14 Miguel de Icaza <miguel@ximian.com>
13405 * attribute.cs (DoResolve): More uglyness, we now only try to
13406 resolve the attribute partially, to extract the CharSet
13407 information (only if we are a StructLayout attribute). Otherwise
13409 (GetExtraTypeInfo): Add some code to conditionally kill in the
13410 future this. I am more and more convinced that the .NET
13411 framework has special code to handle the attribute setting on
13414 * expression.cs (IsParamsMethodApplicable): Revert my previous
13415 foreach change here, it was wrong.
13417 2002-05-13 Miguel de Icaza <miguel@ximian.com>
13419 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
13420 (pp_expr): do not abort on unknown input, just return.
13421 (eval): abort if there are pending chars.
13423 * attribute.cs (Attribute.Resolve): Positional parameters are
13424 optional. Deal with that case.
13426 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
13427 the Ansi/Unicode/Auto information for the type.
13429 (TypeContainer.DefineType): instantiate the EmitContext here, as
13430 we will be using it during the type definition (to resolve
13431 attributes) and during the emit phase.
13433 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
13434 to pull type information out of the attributes
13436 (Attribute.Resolve): track the constructor builder, and allow for
13437 multiple invocations (structs and classes will use this).
13439 * ecore.cs (MemberLookupFinal): new version with all the
13440 parameters customizable.
13442 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
13443 constructors. Return if the result value is null (as the error
13444 would have been flagged already by MemberLookupFinal)
13446 Do not allow instances of abstract classes or interfaces to be
13449 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
13450 We have to compare the assembly property here when dealing with
13451 FamANDAssem and Assembly access modifiers, because we might be
13452 creating an assembly from *modules* (that means that we are not
13453 getting TypeBuilders for types defined in other modules that are
13454 part of this assembly).
13456 (Method.Emit): If the method is marked abstract and has a body,
13459 (TypeContainer.DefineMembers): If both the defined member and the
13460 parent name match are methods, then do not emit any warnings: let
13461 the Method.Define routine take care of flagging warnings. But if
13462 there is a mismatch (method overrides something else, or method is
13463 overriwritten by something, then emit warning).
13465 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
13466 set to null, this means `do not check for the return type on the
13469 (Method.Define): set the return type for the method signature to
13470 null, so that we get methods with the same name and parameters and
13471 different return types. This is used to flag warning 114 (you are
13472 hiding a method, and you probably want to use the new/override
13475 * typemanager.cs (MemberLookup): Implemented proper access
13476 control, closing a long standing set of bug reports. The problem
13477 was that the Framework only has two bits: Public and NonPublic,
13478 and NonPublic includes private and protected methods, but we need
13479 to enforce the FamANDAssem, FamOrAssem and Family.
13481 2002-05-11 Miguel de Icaza <miguel@ximian.com>
13483 * statement.cs (GotoCase): Return true: Ammounts to giving up
13484 knowledge on whether we return or not, and letting the other case
13485 be responsible for it.
13487 2002-05-10 Miguel de Icaza <miguel@ximian.com>
13489 * driver.cs: Do not load directories for each file processed, only
13490 do it if there is a pattern.
13492 * ecore.cs: Report readonly assigns here as well, as we might have
13493 been resolved only by MemberAccess.
13495 (SimpleName.SimpleNameResolve): Also be useful for LValue
13496 resolution. We need this to propagate assign to local readonly variables
13498 * typemanager.cs: Use a ptrhashtable for the criteria, because we
13499 do not want to reuse potential criteria memory.
13501 * class.cs (MyEventBuilder): Set reflected_type;
13503 * ecore.cs (Constantify): Added support for constifying bools.
13505 (RootContext.LookupType): Added a cache for values looked up in
13506 the declaration space.
13508 * typemanager.cs (FindMembers): Now is a front-end to
13509 RealFindMembers, and provides a two-level hashtable-based cache to
13512 15% performance improvement: from 22.5 to 19.2 seconds.
13514 * expression.cs (IsParamsMethodApplicable): use foreach.
13515 (Invocation.DoResolve): ditto.
13516 (New.DoResolve): ditto.
13517 (ArrayCreation.DoResolve): ditto.
13519 * ecore.cs (FindMostEncompassingType): use foreach.
13521 * delegate.cs (NewDelegate.DoResolve): Use foreach
13523 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
13524 (RemoveMethods): use foreach.
13526 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
13527 nested foreach statements instead of for, and also break out of
13528 the inner loop once a match is found.
13530 (Invocation.OverloadResolve): Use foreach, simplify the code.
13532 2002-05-08 Miguel de Icaza <miguel@ximian.com>
13534 * cfold.cs (BinaryFold): During an enumeration evaluation context,
13535 we actually unwrap the expression to allow for extra information
13538 * expression.cs: Use Shr_Un on unsigned operations.
13540 2002-05-08 Ravi Pratap <ravi@ximian.com>
13542 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
13543 applicable operators was not being considered correctly. This closes
13544 the bug Miguel reported.
13546 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
13548 * attribute.cs: check that the type derives from System.Attribute
13549 and report the correct error in that case (moved the duplicate code to
13550 its own method, too).
13552 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
13554 * attribute.cs: lookup attribute type name as the spec says: first the
13555 bare attribute name and then name + "Attribute" (nant compiles with
13556 mcs after this fix).
13558 2002-05-07 Miguel de Icaza <miguel@ximian.com>
13560 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
13561 Because of the way we parse things, we should try to see if a
13562 UIntConstant can fit in an integer.
13564 2002-05-07 Ravi Pratap <ravi@ximian.com>
13566 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
13567 when we are in an explicit context.
13569 (ConvertReferenceExplicit): When converting from Iface type S to Class
13570 T make sure the rules are implemented as an OR.
13572 * parameter.cs (ParameterType): Make it a property for now although the
13573 purpose really isn't anything immediate.
13575 * expression.cs (Is*Applicable): Do better checking on the parameter type
13576 of a ref/out parameter. The ones from the system assemblies are already
13577 marked with the correct type so we don't need to do any correction.
13579 * ecore.cs (StandardConversionExists): Conversion from Interface types to
13580 the object type is standard too so include that.
13582 2002-05-06 Miguel de Icaza <miguel@ximian.com>
13584 * ecore.cs (StandardConversionExists): Augment with missing code:
13585 deal with IntConstant, LongConstants and Enumerations.
13587 * assign.cs: Report the error, instead of failing silently
13589 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
13590 typecontainer that they are declared, because the
13591 typecontainer/namespace will have the list of using clauses that
13592 need to be applied.
13594 Assembly Attributes were escaping the normal registration
13597 (EmitCode): Apply attributes within an EmitContext that represents
13598 the container they were declared on.
13600 * cs-parser.jay: Track bases for structs. How did I get this wrong?
13602 2002-05-06 Ravi Pratap <ravi@ximian.com>
13604 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
13605 Revamp completely - make much cleaner as we now operate only
13608 (FindMostSpecificSource, FindMostSpecificTarget): New methods
13609 to implement the logic detailed in the spec more correctly.
13611 (UserDefinedConversion): Update accordingly.
13613 2002-05-06 Miguel de Icaza <miguel@ximian.com>
13615 * statement.cs: Return flow analysis information up.
13617 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
13620 (token): Do not consume an extra character before calling
13623 2002-05-06 Piers Haken <piersh@friskit.com>
13625 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
13627 2002-05-06 Miguel de Icaza <miguel@ximian.com>
13629 * class.cs (Constructor.Emit): Set the IsStatic flag in the
13630 EmitContext during the instance constructor initializer
13631 resolution, to stop access to instance variables.
13633 This is mandated by the spec, last paragraph of the `constructor
13634 initializers' section.
13636 2002-05-05 Miguel de Icaza <miguel@ximian.com>
13638 * cs-parser.jay, class.cs (Accessor): new class used to represent
13639 an accessor (get or set). In the past we used `null' to represent
13640 a missing accessor. But this is ambiguous because there was no
13641 way to tell in abstract indexers/properties if one of them was
13644 Now there is a way of addressing that.
13646 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
13647 instead of FindMembers.
13649 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
13650 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
13652 * attribute.cs: Treat indexers and properties as the same in terms
13653 of applying attributes
13655 * ecore.cs (FindMostEncompassedType): Use statically initialized
13656 EmptyExpressions()s like we do elsewhere to avoid creating useless
13657 objects (and we take this out of the tight loop).
13659 (GetConversionOperators): Move the code to extract the actual
13660 operators to a separate routine to clean things up.
13662 2002-05-04 Miguel de Icaza <miguel@ximian.com>
13664 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
13665 events are always registered FieldBuilders.
13667 * class.cs (FieldBase): New class shared by Fields
13669 * delegate.cs: If we are a toplevel delegate, use our full name.
13670 If we are a nested delegate, then only use our tail name.
13672 2002-05-02 Ravi Pratap <ravi@ximian.com>
13674 * expression.cs (IsApplicable): Ensure that we add the "&" to
13675 ref/out types before comparing it with the type of the argument.
13677 (IsParamsMethodApplicable): Ditto.
13679 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
13682 * delegate.cs : Handle the case when we have more than one applicable
13683 method. Flag an error only when we finish checking all.
13685 2002-05-02 Miguel de Icaza <miguel@ximian.com>
13687 * expression.cs: Add support for boolean static initializers.
13689 2002-05-01 Miguel de Icaza <miguel@ximian.com>
13691 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
13693 * parameter.cs (ComputeParameterTypes,
13694 ComputeAndDefineParameterTypes): Better error handling: now we
13695 clear the `types' cache if we fail during any of the type lookups.
13696 We also return the status code correctly to our caller
13698 * delegate.cs: If we fail to define a delegate, abort the extra
13701 * expression.cs (Binary.ResolveOperator): for
13702 operator==(object,object) and operator !=(object, object) we also
13703 have to verify that there is an implicit conversion from one to
13706 (ArrayAccess.DoResolve): Array Access can operate on
13709 2002-04-30 Miguel de Icaza <miguel@ximian.com>
13711 * assign.cs (CompoundAssign): A new class used as a "flag" that
13712 the assignment actually is happening as part of a compound
13713 assignment operator.
13715 During compound assignment, a few new rules exist to enable things
13722 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
13723 to the type of x) if y is implicitly convertible to the type of x,
13724 and the operator is a builtin operator and the return type of the
13725 operator is explicitly convertible to the type of x.
13727 * rootcontext.cs: Reset warning level to 2. 4 catches various
13728 "interesting" features in mcs, we must clean this up at some
13729 point, but currently am trying to kill other bugs ;-)
13731 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
13732 in container classes as well.
13734 * expression.cs (Binary.ResolveOperator): Handle string case
13735 before anything else (as operator overloading does emit an error
13736 before doing anything else).
13738 This code could go away when we move to a table driven model, but
13739 i could not come up with a good plan last night.
13741 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
13743 * typemanager.cs (CSharpName): reimplementation using regex.
13744 * class.cs: added null check for fields in Emit
13745 * rootcontext.cs: set warninglevel to 4
13747 2002-04-29 Miguel de Icaza <miguel@ximian.com>
13749 * typemanager.cs (CSharpName): reimplemented with Lupus
13752 2002-04-28 Miguel de Icaza <miguel@ximian.com>
13754 * statement.cs (If): correclty implement Resolve, because we were
13755 not catching sem errors in there. The same process is needed
13757 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
13760 (Statement.Warning_DeadCodeFound): Factorize code.
13761 (While): Report dead code here too.
13763 (Statement): Added Resolve virtual method to allow
13764 for resolution split from the emit code.
13766 2002-04-26 Miguel de Icaza <miguel@ximian.com>
13768 * statement.cs (EmitBoolExpression): No longer try to resolve the
13770 (MakeBoolean): New utility function that resolve, implicitly
13771 converts to boolean and tags the expression.
13774 (If, Do): Implement dead code elimination.
13775 (While): Implement loop inversion
13777 (Do, While, For, If): Resolve the expression prior to calling our
13780 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
13783 - added method Report28 (warning: program has more than one entry point)
13784 - added method IsEntryPoint, implements paragraph 10.1 of the spec
13785 - modified method Method.Define, the part at the end of the method
13787 * rootcontext.cs: added static public Location EntryPointLocation;
13789 * ../errors/cs0028.cs : Add test case for the above warning.
13792 - modified method CSharpName to allow arrays of primitive type to
13793 be printed nicely (e.g. instead of System.Int32[][] it now prints
13795 - added method CSharpSignature: returns the signature of a method
13796 in string format to be used in reporting errors, warnings, etc.
13798 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
13801 2002-04-26 Ravi Pratap <ravi@ximian.com>
13803 * delegate.cs (Define): Fix extremely silly bug where I was
13804 setting the type of the 'object' parameter of the BeginInvoke
13805 method to System.IAsyncResult instead of System.Object ;-)
13807 2002-04-26 Miguel de Icaza <miguel@ximian.com>
13809 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
13812 (Constructor.Emit): return if we fail to initialize the
13813 constructor. Another door closed!
13815 * expression.cs (New.DoResolve): Improve error message (from -6 to
13816 1501). Use DeclaredOnly lookup to find the exact constructor.
13818 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
13819 loop. This is useful.
13821 * cs-parser.jay: Adjust the default parameters so that destructors
13822 have the proper signature.
13824 2002-04-26 Martin Baulig <martin@gnome.org>
13826 * driver.cs (LoadAssembly): If `assembly' contains any characters
13827 which are only valid in path names and not in assembly names
13828 (currently slash, backslash and point), use Assembly.LoadFrom ()
13829 instead of Assembly.Load () on the `assembly' (before iteration
13830 over the link_paths).
13832 2002-04-26 Martin Baulig <martin@gnome.org>
13834 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
13836 2002-04-25 Miguel de Icaza <miguel@ximian.com>
13838 * class.cs (Property): use the new typemanager.MemberLookup
13840 (TypeContainer.MemberLookup): Implement using the
13841 TypeManager.MemberLookup now.
13843 * typemanager.cs: Make MemberLookup a function of the TypeManager,
13844 and return MemberInfos, so that these can be used without an
13845 EmitContext (what we had before).
13847 2002-04-24 Miguel de Icaza <miguel@ximian.com>
13849 * expression.cs: Fix the case where the argument to params if the
13850 type of the params. I omitted handling this before. Fixed
13852 2002-04-22 Miguel de Icaza <miguel@ximian.com>
13854 * driver.cs: Call BootCorlib_PopulateCoreType
13856 * class.cs (Property.CheckBase): Check for properties only, not
13859 * interface.cs: Temporary hack: try/catch around the
13860 CustomAttributeBuilder, because I am getting an exception that I
13863 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
13864 types whose definitions are required to be there (attributes are
13865 defined before standard types).
13867 Compute definitions as we boot the various types, as they are used
13868 immediately (value_type class will need object_type, but if we do
13869 not initialize object_type, we will pass a null, which will let
13870 the runtime pick the System.Object from the existing corlib, which
13871 is not what we want).
13873 2002-04-22 Patrik Torstensson <totte@labs2.com>
13875 * cs-tokenizer.cs: fixed a number of trim() issues.
13877 2002-04-22 Ravi Pratap <ravi@ximian.com>
13879 * expression.cs (Argument.Type): Ensure that we return the correct
13880 type when we have out or ref parameters [in which case we
13883 2002-04-22 Miguel de Icaza <miguel@ximian.com>
13885 * class.cs (Property, Indexer): Allow extern modifier in there.
13887 * typemanager.cs (InitBaseTypes): Initializes object_type and
13888 value_type, since those will be used early on during the bootstrap
13889 process to compile corlib.
13891 (InitCoreTypes): Move code from here to InitBaseTypes.
13893 2002-04-21 Miguel de Icaza <miguel@ximian.com>
13895 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
13896 single-dimension arrays as using the ldlen opcode.
13898 Daniel Lewis discovered this optimization.
13900 * typemanager.cs: Add signature for System.Array::get_Length
13902 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
13904 * statement.cs: report the error when the foreach does not apply to an
13905 array nor a collection.
13907 2002-04-19 Miguel de Icaza <miguel@ximian.com>
13909 * expression.cs: Add implicit conversions to the operator ~.
13911 * constant.cs (DecimalConstant.Emit): Emit decimal value.
13913 * typemanager.cs: Locate the decimal constructor.
13915 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
13917 * attribute.cs: use the new property of TypeOf.
13918 * expression.cs: added 'get' property around typearg.
13920 These changes fix a build breaker reported by NickD. Is this the
13921 correct way to fix? If not, please, revert my changes and make it
13924 2002-04-17 Miguel de Icaza <miguel@ximian.com>
13926 * attribute.cs: Add support for typeof in attribute invocations.
13927 I am not sure that this is right though.
13929 2002-04-14 Duncan Mak <duncan@ximian.com>
13931 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
13932 Binary.Operator.Division case.
13934 2002-04-13 Ravi Pratap <ravi@ximian.com>
13936 * class.cs (DefineType): Ensure that we do a proper check on
13937 attribute types and also register it with the TypeManager.
13939 (TypeContainer.Targets): The default for attribute types is
13940 AttributeTargets.All.
13942 * attribute.cs (ApplyAttributes): Registering the attribute type
13943 is done elsewhere, not when we discover we have a Usage attribute.
13945 2002-04-12 Ravi Pratap <ravi@ximian.com>
13947 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
13948 and get rid of is_delegate parameter.
13950 * everywhere : update.
13952 2002-04-12 Ravi Pratap <ravi@ximian.com>
13954 * cs-parser.jay (compilation_unit): Revamp completely to use
13955 some new ideas that I got from Rhys' grammar to solve the problems
13956 with assembly level attributes.
13958 (outer_declaration): New grammar production.
13960 (attribute_sections): Add.
13962 (opt_attributes): Base on attribute_sections
13964 (namespace_declaration): Allow opt_attributes to tackle the case
13965 when we have assembly level attributes - we are clever in this
13968 * attribute.cs (ApplyAttributes): Do not worry about assembly
13969 attributes in the non-global context.
13971 * rootcontext.cs (AddGlobalAttributes): Go back to using this
13972 instead of SetGlobalAttributes.
13974 * class.cs, rootcontext.cs : Ensure we define and generate
13975 attribute types before anything else.
13977 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
13978 and flag the new error -20 for the case when the attribute type
13979 does not have valid targets specified. csc does not catch this.
13981 * ../errors/errors.txt : update for error # -20
13983 2002-04-11 Ravi Pratap <ravi@ximian.com>
13985 * support.cs (InternalParameters.ParameterModifier): Do some null
13986 checking and return sane values.
13988 * class.cs (Method.Define): If we are a PInvoke method, ensure
13989 that we are static and extern. Report error # 601
13991 * ../errors/cs0601.cs : Add test case for the above error.
13993 2002-04-07 Ravi Pratap <ravi@ximian.com>
13995 * rootcontext.cs (attribute_types): We need to keep type of
13996 all attribute types separately and emit code for them first.
13998 (RegisterAttribute) : Implement.
14000 * class.cs (DefineType): Check if the current Type is a custom
14001 attribute type and register it accordingly.
14003 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
14004 adding the first attribute twice and rename to
14006 (SetGlobalAttributes): this.
14008 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
14011 * attribute.cs (ApplyAttributes): Take an additional argument telling us
14012 if we are processing global arguments. Hmm, I am unsure of this.
14014 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
14016 * expression.cs: added static array of strings to avoid calling
14017 Enum.ToString () for Operator in Binary. Significant recover of
14020 2002-04-10 Miguel de Icaza <miguel@ximian.com>
14022 * class.cs (FindMembers): Allow the Builders of the various
14023 members to be null. If they are skip them. This only happens
14024 during the PInvoke declaration.
14026 2002-04-09 Miguel de Icaza <miguel@ximian.com>
14028 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
14029 failure, so we do not keep going afterwards.
14031 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
14032 wanted to pass `false' as the `is_delegate' argument. If this is
14033 the case, why not use delegate_type == null to mean `is_delegate =
14034 false' and anything else as is_delegate = true.
14036 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
14038 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
14039 code for the section, not the beginning of the tests.
14041 2002-04-08 Miguel de Icaza <miguel@ximian.com>
14043 * cfold.cs: Handle operator + (Enum x, Underlying x)
14045 * expression.cs (Binary): same. Warn about errors where we have
14046 Enum/Enum in operator + as well.
14048 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
14051 - added support for switch(bool)
14052 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
14053 - add TableSwitchEmit() to handle table-based switch statements
14055 2002-04-05 Ravi Pratap <ravi@ximian.com>
14057 * expression.cs (Invocation.OverloadResolve): Factor out code which
14058 does parameter compatibility checking with arguments so that we can
14059 re-use the code even from Delegate.VerifyApplicability
14061 (VerifyArgumentsCompat): Move above code here.
14063 * delegate.cs (VerifyApplicability): Get rid of duplicate code
14064 and instead make a call to the above method.
14066 2002-03-31 Ravi Pratap <ravi@ximian.com>
14068 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
14069 We use it to keep track of classes which are attribute types.
14071 2002-04-02 Miguel de Icaza <miguel@ximian.com>
14073 * delegate.cs (Delegate.Define): Correctly define the types in the
14074 presence of fixed and array parameters.
14076 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
14079 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
14080 include NonPublic after the first iteration.
14082 * class.cs (Indexer.CheckBase): Only check if both parents are
14085 * cs-parser.jay (accessor_body): If empty, set to null.
14087 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
14088 same code path here to resolve constants names that we did have in
14089 MemberAccess.DoResolve. There is too much code duplicated here.
14091 2002-04-01 Miguel de Icaza <miguel@ximian.com>
14093 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
14095 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
14098 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
14099 tokens, numbers and strings.
14101 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
14104 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
14105 asyncronous parameters and the regular parameters.
14107 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
14108 specify the target directory.
14110 * expression.cs: (This.DoResolve): Simplify
14111 (As.Emit): Optimize, do not generate IsInst if the expression is
14112 always of the given type.
14114 (Is.DoResolve): Bug fix, we were reporting both always/never for
14117 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
14118 creating too many unnecessary arrays.
14120 2002-03-31 Miguel de Icaza <miguel@ximian.com>
14122 * class.cs (EmitFieldInitializer): Use Assign expression to assign
14123 fields instead of rolling our own initializer. Takes care of all
14124 implicit conversions, and drops unnecessary static checks/argument.
14126 2002-03-31 Dick Porter <dick@ximian.com>
14128 * driver.cs: use the GetDirectories() return values properly, and
14129 use "/" as path separator.
14131 2002-03-30 Miguel de Icaza <miguel@ximian.com>
14133 * expression.cs (Unary): Optimize - - expr into expr.
14134 (Binary): Optimize a + (-b) into a -b.
14136 * codegen.cs (CodeGen): Made all methods static.
14138 2002-03-29 Miguel de Icaza <miguel@ximian.com>
14142 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
14143 TypeBuilder property.
14145 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
14148 * tree.cs: Removed the various RecordXXXX, and replaced with a
14149 single RecordDecl. Removed all the accessor methods, and just
14150 left a single access point Type
14152 * enum.cs: Rename DefineEnum to DefineType.
14154 * decl.cs: New abstract method `DefineType' used to unify the
14155 Defines for Enumerations, Interfaces, TypeContainers and
14158 (FindType): Moved LookupInterfaceOrClass here. Moved the
14159 LookupBaseClasses method that used to live in class.cs and
14160 interface.cs here, and renamed to FindType.
14162 * delegate.cs: Implement DefineType. Take advantage of the
14163 refactored pattern for locating the parent builder without taking
14164 the parent_builder argument (which we know does not work if we are
14165 nested, and triggering a toplevel definition).
14167 2002-03-28 Miguel de Icaza <miguel@ximian.com>
14169 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
14170 accessibility of a member has changed during override and report
14173 * class.cs (Method.Define, Property.Define): Only complain on
14174 overrides if the method is private, any other accessibility is
14175 fine (and since we just checked the permission is the same, we are
14178 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
14179 and elif are processed always. The other pre-processing
14180 directives are only processed if we are "taking" the path
14182 2002-03-29 Martin Baulig <martin@gnome.org>
14184 * class.cs (Method.Emit): Only emit symbolic debugging info if the
14185 current location is not Null.
14187 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
14188 a separate method so we can profile it.
14190 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
14191 `span.Seconds' are just seconds, but no minutes or hours.
14192 (MainDriver): Profile the CodeGen.SaveSymbols calls.
14194 2002-03-28 Miguel de Icaza <miguel@ximian.com>
14196 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
14197 Remove the gratuitous set of Final:
14199 // If an interface implementation, then we can set Final.
14200 if (((flags & MethodAttributes.Abstract) == 0) &&
14201 implementing.DeclaringType.IsInterface)
14202 flags |= MethodAttributes.Final;
14204 I do not know what I was smoking when I used that.
14207 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
14208 step into fixing the name resolution issues for delegates and
14209 unifying the toplevel name resolution.
14211 2002-03-28 Martin Baulig <martin@gnome.org>
14213 * class.cs (Method.Emit): If we have a symbol writer, call its
14214 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
14215 tell it about the current method.
14217 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
14218 writer that we're going to emit the first byte of IL code for a new
14219 statement (a new source line).
14220 (EmitContext.EmitTopBlock): If we have a symbol writer, call
14221 EmitContext.Mark() before emitting any code.
14223 * location.cs (SymbolDocument): Return null when we're Null.
14225 * statement.cs (Statement): Moved the `Location loc' variable here.
14226 (Statement.EmitBoolExpression): If we have a symbol writer, call
14227 ec.Mark() before emitting any code to tell it that we're at the
14228 beginning of a new statement.
14229 (StatementExpression): Added `Location' argument to the constructor.
14230 (Block): Added public readonly variable `StartLocation' and public
14231 variable `EndLocation'. The latter is to be set using SetEndLocation().
14232 (Block): Added constructor which takes a start and end location.
14233 (Block.SetEndLocation): New method. This sets the end location.
14234 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
14235 local variables we create.
14236 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
14237 each statement and do also mark the begin and end of the block.
14239 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
14240 tell it the current lexer.Location, use Location.Null for the end of the
14242 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
14243 current block, set its end location using SetEndLocation().
14244 (statement_expression): StatementExpression constructor now takes the
14245 lexer.Location as additional argument.
14246 (for_statement, declare_local_variables): Likewise.
14247 (declare_local_variables): When creating a new implicit block, use the
14248 new Block constructor and pass it the lexer.Location.
14250 2002-03-28 Miguel de Icaza <miguel@ximian.com>
14252 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
14253 members also on the parent interfaces recursively.
14255 2002-03-27 Miguel de Icaza <miguel@ximian.com>
14257 * report.cs: Use new formats, since Gonzalo finished the missing
14260 * expression.cs (Binary.ResolveOperator): added missing operator|
14261 operator& and operator^ for bool/bool.
14263 * cs-parser.jay: CheckDef now takes a Location argument that is
14264 used to report errors more precisly (instead of reporting the end
14265 of a definition, we try to track something which is a lot closer
14266 to the source of the problem).
14268 * cs-tokenizer.cs: Track global token use, so we can properly flag
14269 the use of #define/#undef after the first token has been seen.
14271 Also, rename the reportXXXX to Error_DescriptiveName
14273 * decl.cs (DeclSpace.IsTopLevel): Move property here from
14274 TypeContainer, so that Enum and Interface can use this too.
14276 * class.cs (TypeContainer.LookupInterfaceOrClass,
14277 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
14278 `builder' argument. Typically this was used to pass the parent
14279 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
14282 The problem is that a nested class could trigger the definition of
14283 a toplevel class, and the builder would be obviously wrong in that
14286 So we drop this argument, and we compute dynamically the
14287 TypeBuilder/ModuleBuilder (the correct information was available
14288 to us anyways from DeclSpace.Parent)
14290 * interface.cs (Interface.DefineInterface): Drop builder
14291 parameter cleanup like class.cs
14293 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
14296 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
14299 (Try.Emit): Propagate the returns value from the statement.
14301 (Return.Emit): Even if we are leavning
14303 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
14305 * modifiers.cs: Fix the computation of MethodAttributes flags.
14307 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
14309 * driver.cs: allow compilation of files that start with '/'.
14310 Add a default case when checking the argument of --target.
14312 2002-03-25 Miguel de Icaza <miguel@ximian.com>
14314 * interface.cs: Implement the same search algorithm for types in
14315 the interface code.
14317 * delegate.cs: Do not allow multiple definition.
14319 * Recovered ChangeLog that got accidentally amputated
14321 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
14323 * rootcontext.cs: Load manually enum to allow core classes to
14324 contain enumerations.
14326 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
14327 Update to new static methods in TypeManager.
14329 * typemanager.cs (GetMethod, GetConstructor): Use our
14330 implementation of FindMembers to find the members, since during
14331 corlib compilation, the types are TypeBuilders and GetMethod and
14332 GetConstructor do not work.
14334 Make all methods in TypeManager static.
14336 (InitCodeHelpers): Split the functionality from
14337 the InitCodeTypes function.
14339 * driver.cs: Call InitCodeHelpers after we have populated the
14342 * cs-parser.jay (delegate_declaration): we did not used to compute
14343 the delegate name correctly for void delegates.
14345 2002-03-24 Miguel de Icaza <miguel@ximian.com>
14347 * rootcontext.cs (RootContext): Init the interface_resolve_order
14348 and type_container_resolve_order always.
14350 (ResolveCore, BootstrapCorlib_ResolveClass,
14351 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
14352 compiler when compiling with --nostdlib
14354 * class.cs (TypeContainer.DefineType): Check that our parent is
14355 not null. This test is most important when we are bootstraping
14358 * codegen.cs: Split out the symbol writing code.
14360 2002-03-25 Martin Baulig <martin@gnome.org>
14362 * driver.cs (-g): Made -g an alias for --debug.
14364 2002-03-24 Martin Baulig <martin@gnome.org>
14366 * codegen.cs (SymbolWriter): New public variable. Returns the
14367 current symbol writer.
14368 (CodeGen): Added `bool want_debugging_support' argument to the
14369 constructor. If true, tell the ModuleBuild that we want debugging
14370 support and ask it for the ISymbolWriter.
14371 (Save): If we have a symbol writer, call it's Close() method after
14372 saving the assembly.
14374 * driver.c (--debug): New command line argument to create a
14375 debugger information file.
14377 * location.cs (SymbolDocument): New public property. Returns an
14378 ISymbolDocumentWriter object for the current source file or null
14379 if we don't have a symbol writer.
14381 2002-03-21 Miguel de Icaza <miguel@ximian.com>
14383 * driver.cs (LoadAssembly): Correctly return when all the paths
14384 have been tried and not before.
14386 * statement.cs (Switch.Emit): return the actual coverage for this
14387 statement (returns/not-returns)
14389 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
14390 switch of the statement if we are the last switch section. That
14391 kills two problems: try/catch problems (we used to emit an empty
14392 nop at the end) and switch statements where all branches would
14395 2002-03-19 Miguel de Icaza <miguel@ximian.com>
14397 * driver.cs: Add default assemblies (the equivalent to the
14398 Microsoft CSC.RSP file)
14400 * cs-tokenizer.cs: When updating `cols and setting it to zero,
14401 also update tokens_seen and set it to false.
14403 * driver.cs: Implement --recurse for Mike.
14405 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
14406 correctly splitting out the paths.
14408 2002-03-18 Miguel de Icaza <miguel@ximian.com>
14410 * interface.cs (Interface.PopulateProperty): Instead of using
14411 `parent' as the declaration space for the set parameters, use
14414 * support.cs (InternalParameters): InternalParameters constructor
14415 takes a DeclSpace instead of a TypeContainer.
14417 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
14418 types are being initialized, load the address of it before calling
14421 (New): Provide a mechanism to disable the generation of local
14422 value type temporaries when the caller will be providing us with
14423 an address to store it.
14425 (ArrayCreation.EmitDynamicInitializers): Use it.
14427 2002-03-17 Miguel de Icaza <miguel@ximian.com>
14429 * expression.cs (Invocation.EmitArguments): Only probe for array
14430 property if there is more than one argument. Sorry about that.
14432 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
14433 empty param arrays.
14435 * class.cs (Method.LabelParameters): Fix incorrect code path that
14436 prevented the `ParamArrayAttribute' from being applied to the
14439 2002-03-16 Miguel de Icaza <miguel@ximian.com>
14441 * support.cs (ReflectionParameters): Correctly compute whether the
14442 last argument is a params array. Fixes the problem with
14445 * typemanager.cs: Make the assemblies array always be non-null
14446 (empty, but non-null)
14448 * tree.cs (RecordDecl): New function that abstracts the recording
14449 of names. This reports error 101, and provides a pointer to the
14450 previous declaration. Fixes a crash in the compiler.
14452 * cs-parser.jay (constructor_declaration): Update to new grammar,
14453 and provide a constructor_body that can be empty.
14455 2002-03-15 Miguel de Icaza <miguel@ximian.com>
14457 * driver.cs: Add support for --resources.
14459 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
14460 Make all types for the various array helper methods be integer.
14462 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
14463 CheckState to ConvCast.
14465 (ConvCast): Now it takes a `checked' state argument, to avoid
14466 depending on the emit context for the conversion, and just using
14467 the resolve time setting.
14469 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
14470 instead of Invocation.EmitArguments. We do not emit the original
14471 arguments, instead we emit those which have been converted to
14472 unsigned int expressions.
14474 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
14476 * codegen.cs: ditto.
14478 * expression.cs (LocalVariableReference): Drop the use of the
14479 Store function that depended on the variable index.
14481 * statement.cs (VariableInfo): Drop the `Idx' property from this
14482 class, as this is not taking into account the indexes for
14483 temporaries tat we generate during the execution, getting the
14486 * class.cs: First emit class initializers, then call the parent
14489 * expression.cs (Binary): Fix opcode emision.
14490 (UnaryMutator.EmitCode): Support checked code generation
14492 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
14493 matches for events for both the Static and Instance scans,
14494 pointing to the same element. Fix that.
14496 2002-03-14 Miguel de Icaza <miguel@ximian.com>
14498 * rootcontext.cs (ResolveTree): Always set the
14499 interface_resolve_order, because nested interfaces will be calling
14502 * class.cs (GetInterfaceOrClass): Track the same resolution
14503 process used by TypeManager.LookupType. This fixes the nested
14504 type lookups in class declarations (separate path from
14507 (TypeContainer.DefineType): Also define nested interfaces.
14508 (TypeContainer.RegisterOrder): New public function used to
14509 register the order in which child interfaces need to be closed.
14511 Nested interfaces need to be closed after their parents have been
14514 * interface.cs (InterfaceAttr): Put all the logic for computing
14515 the interface attribute here.
14517 (DefineInterface): Register our interface order with the
14518 RootContext or with the TypeContainer depending on the case.
14520 2002-03-12 Miguel de Icaza <miguel@ximian.com>
14522 * cs-parser.jay: rework foreach statement to work with the new
14523 changes to the policy on SimpleNames.
14525 * report.cs: support Stacktrace on warnings as well.
14527 * makefile: drop --unsafe and /unsafe from the compile.
14529 2002-03-13 Ravi Pratap <ravi@ximian.com>
14531 * ecore.cs (StandardConversionExists): Modify to take an Expression
14532 as the first parameter. Ensure we do null -> reference type conversion
14535 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
14536 temporary Expression objects.
14538 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
14540 * interface.cs: workaround bug in method overloading resolution
14541 (there is already a bugzilla bug for it).
14543 2002-03-12 Miguel de Icaza <miguel@ximian.com>
14545 We could also solve this problem by having a separate path for
14546 performing type lookups, instead of DoResolve, we could have a
14547 ResolveType entry point, and only participating pieces of the
14548 production (simplename, deref, array) would implement this.
14550 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
14551 signal SimpleName to only resolve type names and not attempt to
14552 resolve anything else.
14554 * expression.cs (Cast): Set the flag.
14556 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
14558 * class.cs: Only report 108 if there is no `new' modifier.
14560 * cs-parser.jay: rework foreach statement to work with the new
14561 changes to the policy on SimpleNames.
14563 * report.cs: support Stacktrace on warnings as well.
14565 * makefile: drop --unsafe and /unsafe from the compile.
14567 2002-03-11 Miguel de Icaza <miguel@ximian.com>
14569 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
14570 lookups here, instead of doing that at parse time. This means
14571 that our grammar will not introduce `LocalVariableReferences' as
14572 expressions at this point. That solves the problem of code like
14576 static void Main ()
14580 This is only half the fix. The full fix requires parameters to
14581 also be handled in this way.
14583 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
14584 makes the use more obvious of the DeclSpace. The
14585 ec.TypeContainer.TypeBuilder is now only used to pull the
14586 TypeBuilder for it.
14588 My theory is that I can get rid of the TypeBuilder completely from
14589 the EmitContext, and have typecasts where it is used (from
14590 DeclSpace to where it matters).
14592 The only pending problem is that the code that implements Aliases
14593 is on TypeContainer, and probably should go in DeclSpace.
14595 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
14596 lookups here, instead of doing that at parse time. This means
14597 that our grammar will not introduce `LocalVariableReferences' as
14598 expressions at this point. That solves the problem of code like
14602 static void Main ()
14606 This is only half the fix. The full fix requires parameters to
14607 also be handled in this way.
14609 * class.cs (Property.DefineMethod): When implementing an interface
14610 method, set newslot, when implementing an abstract method, do not
14611 set the flag (before we tried never setting it, or always setting
14612 it, which is the difference).
14613 (Indexer.DefineMethod): same.
14614 (Method.DefineMethod): same.
14616 * ecore.cs: Only set the status used flag if we get back a Field.
14618 * attribute.cs: Temporary hack, so Paolo can keep working.
14620 2002-03-08 Ravi Pratap <ravi@ximian.com>
14622 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
14623 the unmanaged type in the case we have a MarshalAs attribute.
14625 (Resolve): Handle the case when we are parsing the special MarshalAs
14626 attribute [we need to store the unmanaged type to use later]
14628 * typemanager.cs (marshal_as_attr_type): Built in type for the
14629 MarshalAs Attribute.
14631 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
14632 on parameters and accordingly set the marshalling info.
14634 2002-03-09 Miguel de Icaza <miguel@ximian.com>
14636 * class.cs: Optimizing slightly by removing redundant code after
14637 we switched to the `NoTypes' return value.
14638 (Property.DefineMethod): use NoTypes here too.
14640 This fixes the bug I introduced in my last batch of changes.
14642 2002-03-05 Ravi Pratap <ravi@ximian.com>
14644 * tree.cs (RecordEnum): Add. We now keep track of enums too.
14646 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
14647 Enums since those are types too.
14649 * cs-parser.jay (enum_declaration): Record enums as we parse them.
14651 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
14652 thanks to a call during the lookup process.
14654 2002-03-07 Miguel de Icaza <miguel@ximian.com>
14656 * statement.cs (Foreach): Lots of work to accomodate a particular
14657 kind of foreach statement that I had not kept in mind. It is
14658 possible to have foreachs on classes that provide a GetEnumerator
14659 method that return objects that implement the "pattern" for using
14660 a foreach, there is no need to support GetEnumerator
14663 This is needed to compile nant.
14665 * decl.cs: Only report 114 if the member is not `Finalize' and if
14666 the warning level is at least 2.
14668 * class.cs: Moved the compare function from Method to
14671 (MethodSignature.InheritableMemberSignatureCompare): Add new
14672 filter function that is used to extract inheritable methods from a
14675 (Method.Define): Use the new `inheritable_method_signature_filter'
14678 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
14681 2002-03-06 Miguel de Icaza <miguel@ximian.com>
14683 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
14685 * cs-parser.jay: Add opt_semicolon to the interface declaration.
14687 * expression.cs: Pass location information to
14688 ConvertImplicitStandard.
14690 * class.cs: Added debugging code to track return values from
14693 2002-03-05 Miguel de Icaza <miguel@ximian.com>
14695 * expression.cs (Is.DoResolve): If either side of the `is' is an
14696 interface, do not flag the warning.
14698 * ecore.cs (ImplicitReferenceConversion): We need a separate test
14701 * report.cs: Allow for --fatal to be used with --probe.
14703 * typemanager.cs (NoTypes): Move the definition for the empty Type
14706 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
14708 (TypeContainer.DefineProxy): New function used to proxy to parent
14709 implementations when implementing interfaces.
14710 (TypeContainer.ParentImplements): used to lookup if our parent
14711 implements a public function that is required by an interface.
14712 (TypeContainer.VerifyPendingMethods): Hook this up.
14714 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
14715 `modules' and `assemblies' arraylists into arrays. We only grow
14716 these are the very early start up of the program, so this improves
14717 the speedof LookupType (nicely measured).
14719 * expression.cs (MakeByteBlob): Replaced unsafe code with
14720 BitConverter, as suggested by Paolo.
14722 * cfold.cs (ConstantFold.Binary): Special case: perform constant
14723 folding of string concatenation, but if either side is a string,
14724 and the other is not, then return null, and let the runtime use
14725 the concatenation on the string plus the object (using
14726 `Object.ToString').
14728 2002-03-04 Miguel de Icaza <miguel@ximian.com>
14730 Constant Folding has been implemented now.
14732 * expression.cs (Unary.Reduce): Do not throw an exception, catch
14733 the error instead on types that are not supported in one's
14736 * constant.cs (Constant and all children): New set of functions to
14737 perform implict and explicit conversions.
14739 * ecore.cs (EnumConstant): Implement the new functions to perform
14740 conversion by proxying to the child expression.
14742 * codegen.cs: (ConstantCheckState): Constant evaluation has its
14743 own separate setting that can not be turned off from the command
14744 line using --unchecked or --checked and is only controlled using
14745 the checked/unchecked statements and expressions. This setting is
14746 used by the constant folder to flag errors.
14748 * expression.cs (CheckedExpr, UncheckedExpr): Set the
14749 ConstantCheckState as well.
14751 During Resolve, they also have to flag the state, because the
14752 constant folder runs completely in the Resolve phase.
14754 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
14757 2002-03-01 Miguel de Icaza <miguel@ximian.com>
14759 * cfold.cs: New file, this file contains the constant folder.
14761 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
14762 argument to track whether we are using the resulting address to
14763 load or store a value and provide better error messages.
14765 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
14766 new AddressOf arguments.
14768 * statement.cs (Foreach.EmitCollectionForeach): Update
14770 * expression.cs (Argument.Emit): Call AddressOf with proper
14771 arguments to track usage.
14773 (New.DoEmit): Call AddressOf with new arguments.
14775 (Unary.Emit): Adjust AddressOf call.
14777 2002-03-01 Ravi Pratap <ravi@ximian.com>
14779 * cs-parser.jay (member_access): Change the case for pre-defined types
14780 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
14783 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
14786 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
14787 essentially like methods and apply attributes like MethodImplOptions to them too.
14789 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
14792 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
14793 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
14796 * Update code everywhere accordingly.
14798 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
14800 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
14802 2002-02-28 Ravi Pratap <ravi@ximian.com>
14804 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
14805 try performing lookups against those instead of jumping straight into using
14806 the 'using' clauses.
14808 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
14810 (LookupType): Perform lookups in implicit parents too.
14812 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
14813 sequence as RootContext.LookupType.
14815 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
14816 the various cases of namespace lookups into this method.
14818 2002-03-01 Miguel de Icaza <miguel@ximian.com>
14820 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
14821 in positional arguments)
14823 * class.cs (Operator): Update the AllowedModifiers to contain
14826 * cs-parser.jay: Update operator declaration to allow for the
14827 operator body to be empty.
14829 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
14832 2002-02-27 Miguel de Icaza <miguel@ximian.com>
14834 * class.cs (Method.Emit): Label parameters.
14836 * driver.cs: Return 1 or 0 as the program exit code.
14838 2002-02-26 Miguel de Icaza <miguel@ximian.com>
14840 * expression.cs: Special case the `null' object when trying to
14841 auto-compute the type, as anything can be explicitly converted to
14844 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
14845 spotting this Paolo.
14847 (Expression.ImplicitNumericConversion): Perform comparissions of
14848 the type using the underlying type in the case of an enumeration
14849 rather than using the enumeration type for the compare.
14851 Cope with the underlying == type case, which is not possible to
14854 (Expression.ConvertNumericExplicit): Perform comparissions of
14855 the type using the underlying type in the case of an enumeration
14856 rather than using the enumeration type for the compare.
14858 * driver.cs: If the user does not supply an extension, assume .exe
14860 * cs-parser.jay (if_statement): Rewrote so that we can track the
14861 location for the if statement.
14863 * expression.cs (Binary.ConstantFold): Only concat strings when
14864 the operation is "+", not everything ;-)
14866 * statement.cs (Statement.EmitBoolExpression): Take a location
14868 (If, While, Do): Track location.
14870 * expression.cs (Binary.ResolveOperator): In the object + string
14871 case, I was missing a call to ConvertImplicit
14873 2002-02-25 Ravi Pratap <ravi@ximian.com>
14875 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
14876 Location arguments. Ensure we use RootContext.LookupType to do our work
14877 and not try to do a direct Type.GetType and ModuleBuilder.GetType
14879 * interface.cs (PopulateMethod): Handle the type of the parameter being
14882 * expression.cs (Invocation.BetterFunction): Handle the case when we
14883 have a params method with no fixed arguments and a call is made with no
14886 2002-02-25 Miguel de Icaza <miguel@ximian.com>
14888 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
14889 the verbatim-string-literal
14891 * support.cs (InternalParameters.ParameterModifier): handle null
14893 (InternalParameters.ParameterType): ditto.
14895 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
14896 duplicating the name of the variable parameter.
14897 (GetParameterByName): Fix bug where we were not looking up array
14898 paramters if they were the only present (thanks Paolo!).
14899 (GetParameterInfo): We only have an empty set of types if both
14900 fixed and array are set to null.
14901 (GetParameterInfo-idx): Handle FixedParameter == null
14903 * cs-parser.jay: Handle the case where there is no catch
14904 statements (missing null test).
14906 2002-02-22 Miguel de Icaza <miguel@ximian.com>
14908 * driver.cs (MainDriver): Be conservative on our command line
14911 Catch DirectoryNotFoundException when calling GetFiles.
14913 (SplitPathAndPattern): Used to split the input specification into
14914 a path and a pattern that we can feed to Directory.GetFiles.
14916 2002-02-21 Miguel de Icaza <miguel@ximian.com>
14918 * statement.cs (Fixed): Implement the last case of the Fixed
14919 statement (string handling).
14921 * expression.cs (StringPtr): New class used to return a char * to
14922 a string; Used by the Fixed statement.
14924 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
14926 * expression.cs (Binary.ResolveOperator): Remove redundant
14927 MemberLookup pn parent type.
14928 Optimize union call, we do not need a union if the types are the same.
14929 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
14932 Specialize the use of MemberLookup everywhere, instead of using
14933 the default settings.
14935 (StackAlloc): Implement stackalloc keyword.
14937 * cs-parser.jay: Add rule to parse stackalloc.
14939 * driver.cs: Handle /h, /help, /?
14941 * expression.cs (MakeByteBlob): Removed the hacks we had in place
14942 before we supported unsafe code.
14944 * makefile: add --unsafe to the self compilation of mcs.
14946 2002-02-20 Miguel de Icaza <miguel@ximian.com>
14948 * expression.cs (PointerArithmetic): New class that is used to
14949 perform pointer arithmetic.
14950 (Binary.Resolve): Handle pointer arithmetic
14951 Handle pointer comparission.
14952 (ArrayPtr): Utility expression class that is used to take the
14953 address of an array.
14955 (ElementAccess): Implement array access for pointers
14957 * statement.cs (Fixed): Implement fixed statement for arrays, we
14958 are missing one more case before we are done.
14960 * expression.cs (Indirection): Implement EmitAssign and set the
14961 ExprClass to Variable. This allows pointer dereferences to be
14962 treated as variables, and to have values assigned to them.
14964 * ecore.cs (Expression.StoreFromPtr): New utility function to
14965 store values dereferencing.
14967 2002-02-20 Ravi Pratap <ravi@ximian.com>
14969 * expression.cs (Binary.ResolveOperator): Ensure that we are
14970 not trying to operate on a void type - this fixes the reported
14973 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
14974 the parent implementation is sealed.
14976 * ../errors/cs0239.cs : Add.
14978 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
14980 * typemanager.cs (unverifiable_code_type): Corresponds to
14981 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
14982 which have unsafe code in them.
14984 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
14987 2002-02-19 Miguel de Icaza <miguel@ximian.com>
14989 * cs-tokenizer.cs: Add support for @"litreal strings"
14991 Make tokenizer accept pre-processor directives
14992 on any column (remove the old C-like limitation).
14994 * rootcontext.cs (EmitCode): Emit any global attributes.
14995 (AddGlobalAttributes): Used to keep track of assembly attributes.
14997 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
14999 * cs-parser.jay: Add support for global attributes.
15001 2002-02-17 Miguel de Icaza <miguel@ximian.com>
15003 * expression.cs (Indirection): New helper class. Unary will
15004 create Indirection classes to be able to implement the
15005 IMemoryLocation interface on it.
15007 2002-02-16 Miguel de Icaza <miguel@ximian.com>
15009 * cs-parser.jay (fixed_statement): reference the right statement.
15011 * statement.cs (Fixed.Emit): Finish implementing the fixed
15012 statement for the &x case.
15014 2002-02-14 Miguel de Icaza <miguel@ximian.com>
15016 * class.cs (Property.Define, Method.Define): Remove newslot when
15019 * modifiers.cs: My use of NewSlot when `Abstract' was set was
15020 wrong. NewSlot should only be used if the `new' keyword is present.
15022 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
15023 locating our system dir. Sorry about this.
15025 2002-02-13 Miguel de Icaza <miguel@ximian.com>
15027 * driver.cs (GetSystemDir): Compute correctly the location of our
15028 system assemblies. I was using the compiler directory instead of
15029 the library directory.
15031 2002-02-13 Ravi Pratap <ravi@ximian.com>
15033 * expression.cs (BetterFunction): Put back in what Miguel commented out
15034 since it is the correct fix. The problem is elsewhere ;-)
15036 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
15037 parameters of the parms method are themselves compatible or not !
15039 (StandardConversionExists): Fix very dangerous bug where we were forgetting
15040 to check that a class implements an interface before saying that an implicit
15041 conversion was allowed. Use ImplementsInterface to do the checking.
15043 2002-02-13 Miguel de Icaza <miguel@ximian.com>
15045 * class.cs (Method.Define): Track whether we are an explicit
15046 implementation or not. And only call DefineMethodOverride if we
15047 are an explicit implementation.
15049 (Property.DefineMethod): Ditto.
15051 2002-02-11 Ravi Pratap <ravi@ximian.com>
15053 * expression.cs (BetterFunction): Catch hideous bug which was
15054 preventing us from detecting ambiguous calls due to implicit casts i.e
15057 2002-01-29 Miguel de Icaza <miguel@ximian.com>
15059 * support.cs (Pair): Remove un-needed method. I figured why I was
15060 getting the error in cs-parser.jay, the variable in a foreach loop
15061 is readonly, and the compiler does not really treat this as a variable.
15063 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
15064 instead of EQUALS in grammar.
15066 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
15068 * expression.cs (Unary.DoResolve): Check whether the argument is
15071 2002-01-28 Miguel de Icaza <miguel@ximian.com>
15073 * support.cs: Api for Pair to set a value. Despite the fact that
15074 the variables are public the MS C# compiler refuses to compile
15075 code that accesses the field if the variable is part of a foreach
15078 * statement.cs (Fixed): Begin implementation of the fixed
15081 (Block.AddVariable): Return the VariableInfo on success and null
15082 on failure instead of true/false.
15084 * cs-parser.jay (foreach): Catch errors on variables already
15085 defined (we were ignoring this value before) and properly unwind
15086 the block hierarchy
15088 (fixed_statement): grammar for the fixed statement.
15090 2002-01-25 Miguel de Icaza <miguel@ximian.com>
15092 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
15093 pointer types to be incretemented.
15095 (SizeOf): Implement.
15097 * cs-parser.jay (pointer_member_access): Implement
15098 expr->IDENTIFIER production.
15100 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
15101 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
15104 (Unary): Implement indirection.
15106 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
15107 use in non-unsafe context).
15109 (SimpleName.DoResolve): Check for pointers in field access on safe
15112 (Expression.LoadFromPtr): Factor the load-indirect code in this
15113 function. This was duplicated in UnboxCast and ParameterReference
15115 2002-01-24 Miguel de Icaza <miguel@ximian.com>
15117 * expression.cs (ComposedCast): report an error if a pointer cast
15118 is used in a safe region.
15120 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
15121 pointer type casts in unsafe context.
15123 * codegen.cs (EmitContext): Set up IsUnsafe.
15125 * cs-parser.jay (non_expression_type): Add productions for pointer
15128 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
15129 code. We should not use force into static mode if the method is
15130 not virtual. Fixes bug in MIS
15132 * statement.cs (Do.Emit, While.Emit, For.Emit,
15133 Statement.EmitBoolExpression): Add support to Do and While to
15134 propagate infinite loop as `I do return' semantics.
15136 Improve the For case to also test for boolean constants.
15138 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
15139 to the list of attributes we can add.
15141 Remove `EmitContext' argument.
15143 * class.cs (Method.Define): Apply parameter attributes.
15144 (Constructor.Define): Apply parameter attributes.
15145 (MethodCore.LabelParameters): Move here the core of labeling
15148 * support.cs (ReflectionParameters.ParameterModifier,
15149 InternalParameters.ParameterModifier): Use IsByRef on the type and
15150 only return the OUT bit for these parameters instead of in/out/ref
15153 This is because I miss-understood things. The ParameterInfo.IsIn
15154 and IsOut represent whether the parameter has the [In] and [Out]
15157 2002-01-22 Miguel de Icaza <miguel@ximian.com>
15159 * ecore.cs (FieldExpr.Emit): Release temporaries.
15161 * assign.cs (LocalTemporary.Release): new function.
15163 * codegen.cs (EmitContext.GetTemporaryStorage,
15164 EmitContext.FreeTemporaryStorage): Rework the way we deal with
15165 temporary storage. Now we can "put back" localbuilders when we
15168 2002-01-21 Miguel de Icaza <miguel@ximian.com>
15170 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
15171 need to make a copy of the variable to generate verifiable code.
15173 2002-01-19 Miguel de Icaza <miguel@ximian.com>
15175 * driver.cs: Compute dynamically the system directory.
15177 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
15178 Slower, but more generally useful. Used by the abstract
15179 registering implementation.
15181 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
15182 the rules for the special rule on Type/instances. First check if
15183 we have the same name, and if so, try that special static path
15184 rather than the instance path.
15186 2002-01-18 Miguel de Icaza <miguel@ximian.com>
15188 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
15191 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
15192 Enum, ValueType, Delegate or Array for non-corlib compiles.
15194 * cs-tokenizer.cs: Catch long identifiers (645)
15196 * typemanager.cs (IndexerPropetyName): Ravi never tested this
15199 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
15200 fix, we were returning too early, so we were not registering
15201 pending methods from abstract classes.
15203 Do not register pending methods if the class is abstract.
15205 * expression.cs (Conditional.DoResolve): Report circular implicit
15206 conversions when we neecd to compute it for conditional
15209 (Is.DoResolve): If the expression is always of the provided type,
15210 flag warning 183. If the expression can not ever be of the
15211 provided type flag warning 184.
15213 * class.cs: Catch 169 as well.
15215 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
15218 2002-01-18 Nick Drochak <ndrochak@gol.com>
15220 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
15222 2002-01-17 Miguel de Icaza <miguel@ximian.com>
15224 * interface.cs: (PopulateMethod): Check for pointers being defined
15225 only if the unsafe context is active.
15226 (PopulateProperty): ditto.
15227 (PopulateIndexer): ditto.
15229 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
15230 specified. If pointers are present, make sure that they are
15231 present in an unsafe context.
15232 (Constructor, Constructor.Define): ditto.
15233 (Field, Field.Define): ditto.
15234 (Property, Property.Define): ditto.
15235 (Event, Event.Define): ditto.
15237 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
15238 hashtable if there are classes or structs defined.
15240 * expression.cs (LocalVariableReference.DoResolve): Simplify this
15241 code, as the constant resolution moved.
15243 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
15244 the metadata, so we can flag error 133.
15246 * decl.cs (MemberCore.UnsafeOK): New function to test that a
15247 pointer is being declared in an unsafe context.
15249 2002-01-16 Miguel de Icaza <miguel@ximian.com>
15251 * modifiers.cs (Modifiers.Check): Require a Location argument.
15252 Report error 227 for Unsafe use.
15254 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
15256 * statement.cs (For.Emit): If the test is null, then report that
15257 we do `return', as we wont reach anything afterwards.
15259 (Switch.SwitchGoverningType): Track the expression that matched
15262 * driver.cs: Allow negative numbers as an error code to flag.
15264 * cs-parser.jay: Handle 1551.
15266 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
15268 2002-01-15 Miguel de Icaza <miguel@ximian.com>
15270 * cs-parser.jay: Report 1518 (type declaration can only contain
15271 class, struct, interface, enum or delegate)
15273 (switch_label): Report 1523 (keywords `case' or `default' must
15276 (opt_switch_sections): Report 1522 (empty switch)
15278 * driver.cs: Report 1515 (response file specified multiple times)
15279 Report 1516 (Source file specified multiple times).
15281 * expression.cs (Argument.Resolve): Signal 1510
15283 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
15284 access not allowed in static code)
15286 2002-01-11 Ravi Pratap <ravi@ximian.com>
15288 * typemanager.cs (IsPointerType): Utility method which we are going
15291 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
15292 the object type, so we take care of that.
15294 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
15296 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
15297 added to non-params parameters :-)
15299 * typemanager.cs (CSharpName): Include 'void' type too.
15301 (void_ptr_type): Include in the set of core types.
15303 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
15306 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
15309 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
15310 completely forgotten about it.
15312 2002-01-10 Ravi Pratap <ravi@ximian.com>
15314 * cs-parser.jay (pointer_type): Add. This begins our implementation
15315 of parsing rules for unsafe code.
15317 (unsafe_statement): Implement.
15319 (embedded_statement): Modify to include the above.
15321 * statement.cs (Unsafe): Implement new class for unsafe blocks.
15323 * codegen.cs (EmitContext.InUnsafe): Add. This determines
15324 if the current context is an unsafe one.
15326 * cs-parser.jay (local_variable_pointer_type): Since local variable types
15327 are handled differently, we need separate rules for them.
15329 (local_variable_declaration): Update to use local_variable_pointer_type
15330 to allow variable declarations of unmanaged pointer types.
15332 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
15333 in unsafe contexts.
15335 * ../errors/cs0214.cs : Add.
15337 2002-01-16 Nick Drochak <ndrochak@gol.com>
15339 * makefile: remove 'response' file when cleaning.
15341 2002-01-15 Miguel de Icaza <miguel@ximian.com>
15343 * cs-parser.jay: Report 1524.
15345 2002-01-14 Miguel de Icaza <miguel@ximian.com>
15347 * typemanager.cs (RegisterMethod): drop checking if we have
15348 registered this from here
15350 2002-01-12 Miguel de Icaza <miguel@ximian.com>
15352 * class.cs (Method.EmitDestructor): Implement calling our base
15355 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
15356 value of InFinally.
15358 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
15359 this routine and will wrap the call in a try/catch block. Deal
15362 2002-01-11 Miguel de Icaza <miguel@ximian.com>
15364 * ecore.cs (Expression.MemberLookup): instead of taking a
15365 parameter `same_type' that was used to tell whether we could
15366 access private members we compute our containing type from the
15369 (FieldExpr): Added partial support for volatile fields. This does
15370 not work for volatile fields exposed from assemblies, as I can not
15371 figure out how to extract the modreq from it.
15373 Updated all the source files to use this.
15375 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
15376 because it is referenced by MemberLookup very often.
15378 2002-01-09 Ravi Pratap <ravi@ximian.com>
15380 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
15381 TypeBuilder.GetCustomAttributes to retrieve what we need.
15383 Get rid of redundant default_member_attr_type as this is the same as
15384 default_member_type which already exists.
15386 * interface.cs, attribute.cs : Update accordingly.
15388 2002-01-08 Miguel de Icaza <miguel@ximian.com>
15390 * typemanager.cs: Enable IndexerPropertyName again. It does not
15391 work for TYpeBuilders though. Ravi, can you please fix this?
15393 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
15395 * expression.cs (Argument.Emit): Handle the case of ref objects
15396 being passed to ref functions;
15398 (ParameterReference.EmitLoad): Loads the content of the pointer
15399 without dereferencing.
15401 2002-01-07 Miguel de Icaza <miguel@ximian.com>
15403 * cs-tokenizer.cs: Implemented the pre-processing expressions.
15405 2002-01-08 Ravi Pratap <ravi@ximian.com>
15407 * class.cs (Indexer.DefineMethod): Incorporate the interface
15408 type in the name of the method if we are doing explicit interface
15411 * expression.cs (ConversionExists): Remove as it is completely obsolete.
15413 (BetterConversion): Fix extremely trivial bug where we were referring to
15414 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
15417 * ../errors/bug16.cs : Add although we have fixed it.
15419 2002-01-07 Miguel de Icaza <miguel@ximian.com>
15421 * expression.cs (BaseIndexer): Begin implementation.
15423 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
15425 * cs-parser.jay (indexer_declarator): Use qualified_identifier
15426 production directly to remove a shift/reduce, and implement
15427 explicit interface implementation.
15429 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
15430 after a floating point suffix.
15432 * expression.cs (DoNumericPromotions): Improved the conversion for
15433 uint/uint. If we have a constant, we avoid doing a typecast to a
15436 * class.cs (Indexer): Implement explicit interface implementation
15439 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
15441 * class.cs: make the default instance constructor public and hidebysig.
15443 2001-01-03 Ravi Pratap <ravi@ximian.com>
15445 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
15446 so we can call it from elsewhere.
15448 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
15449 we emit it internally if the class has a defined indexer; otherwise the user
15450 emits it by decorating the class definition with the DefaultMemberAttribute.
15452 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
15453 attribute is not used on a type which defines an indexer.
15455 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
15456 character when we skip whitespace.
15458 * ../errors/cs0646.cs : Add.
15460 2002-01-03 Miguel de Icaza <miguel@ximian.com>
15462 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
15465 * makefile: Add practical target `mcs3.exe' which builds the third
15466 generation compiler.
15468 * expression.cs (New): Fix structures constructor calling.
15470 * class.cs (Property, Method, Indexer): Emit Final flag on the
15471 method if we are an interface implementation and we are not
15474 * ecore.cs (PropertyExpr): New public field `IsBase', tells
15475 whether this property is referencing a `base' method.
15477 * expression.cs (Invocation.EmitCall): take an extra argument:
15478 is_base, this is used to determine whether the `call' or
15479 `callvirt' opcode should be used.
15482 * delegate.cs: update EmitCall.
15484 * class.cs (Method.Define): Set NewSlot for the cases where we are
15485 not implementing an interface method.
15487 (Property.Define): ditto.
15489 2002-01-02 Miguel de Icaza <miguel@ximian.com>
15491 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
15492 'r'. Allows mcs to parse itself fully.
15494 2002-01-02 Ravi Pratap <ravi@ximian.com>
15496 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
15497 of the number of initializers that require the InitializeArray method.
15499 (CheckIndices): Store the Expression in all cases - not the plain value. Also
15500 update the above field where necessary.
15502 (MakeByteBlob): Update accordingly.
15504 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
15507 (EmitDynamicInitializers): Update in accordance with the new optimization.
15509 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
15510 same OpCode applies.
15512 * cs-parser.jay : Fix some glaring errors I introduced.
15514 2002-01-01 Ravi Pratap <ravi@ximian.com>
15516 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
15517 so that we can check for name clashes there too.
15519 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
15520 for interface indexers.
15522 * interfaces.cs (Define): Emit the default member attribute.
15524 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
15525 variable was being referred to while setting the value ;-)
15527 2002-01-01 Miguel de Icaza <miguel@ximian.com>
15529 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
15530 byte-by-byte information when we know the data is zero.
15532 Make the block always a multiple of 4, because
15533 DefineInitializedData has a bug.
15535 * assign.cs: Fix, we should assign from the temporary, not from
15538 * expression.cs (MakeByteBlob): Fix my incorrect code.
15540 2001-12-31 Miguel de Icaza <miguel@ximian.com>
15542 * typemanager.cs (EnumToUnderlying): This function is used to get
15543 the underlying type from an enumeration, because it does not
15546 * constant.cs: Use the I4_S form for values between -128 and 127.
15548 * statement.cs (Block.LookupLabel): Looks up a label.
15549 (Block): Drop support for labeled blocks.
15551 (LabeledStatement): New kind of statement that represents a label
15554 (Goto): Finally implement this bad boy.
15556 * cs-parser.jay: Update to reflect new mechanism to implement
15559 2001-12-30 Miguel de Icaza <miguel@ximian.com>
15561 * codegen.cs (EmitContext.This): a codegen property that keeps the
15562 a single instance of this instead of creating many different this
15565 * delegate.cs (Delegate.DoResolve): Update to use the property;
15567 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
15569 * expression.cs (BaseAccess.DoResolve): Ditto.
15571 2001-12-29 Ravi Pratap <ravi@ximian.com>
15573 * typemanager.cs (methodimpl_attr_type): Add to hold the type
15574 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
15576 (InitCoreTypes): Update accordingly.
15578 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
15579 so we can quickly store the state.
15581 (ApplyAttributes): Set the correct implementation flags
15582 for InternalCall methods.
15584 2001-12-29 Miguel de Icaza <miguel@ximian.com>
15586 * expression.cs (EmitCall): if a method is not virtual, then do
15587 not use callvirt on it.
15589 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
15590 user defined stuff) requires the use of stobj, which takes an
15591 address on the stack instead of an array and an index. So emit
15592 the Ldelema operation for it.
15594 (EmitStoreOpcode): Use stobj for valuetypes.
15596 (UnaryMutator.EmitCode): Use the right 1 value depending on
15597 whether we are dealing with int64/uint64, float or doubles.
15599 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
15600 constructors that I implemented last night.
15602 (Constructor.IsDefault): Fix to work properly for static
15605 * cs-parser.jay (CheckDef): report method signature errors.
15606 Update error number 103 to be 132.
15608 * decl.cs: New AdditionResult enumeration value: MethodExists.
15609 Although we do this check for methods later on in the semantic
15610 analysis, catching repeated default constructors is so easy that
15611 we catch these here.
15613 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
15616 (ParameterReference.EmitAssign, Emit): handle
15619 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
15620 (ArrayAccess.EmitStoreOpcode): ditto.
15622 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
15624 * expression.cs (MakeByteBlob): Complete all the missing types
15625 (uint, short, ushort, byte, sbyte)
15627 * class.cs: Only init instance field initializers on instance
15630 Rename `constructors' to instance_constructors.
15632 (TypeContainer.AddConstructor): Only add constructors to the list
15633 if it is not static.
15635 Make sure that we handle default_static_constructor independently
15636 everywhere where we handle instance_constructors
15638 2001-12-28 Miguel de Icaza <miguel@ximian.com>
15640 * class.cs: Do not lookup or create a base initializer for a
15641 static constructor.
15643 (ConstructorInitializer.Resolve): use the proper type to lookup
15646 * cs-parser.jay: Report error 1585 (modifiers between type and name).
15648 * enum.cs, interface.cs: Remove CloseType, this is taken care by
15651 * decl.cs: CloseType is now an virtual method, the default
15652 implementation just closes this type.
15654 2001-12-28 Ravi Pratap <ravi@ximian.com>
15656 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
15657 to PreserveSig by default. Also emit HideBySig on such methods.
15659 Basically, set the defaults to standard values.
15661 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
15662 argument, if candidate is better, it can't be worse than the best !
15664 (Invocation): Re-write bits to differentiate between methods being
15665 applicable in their expanded form and their normal form - for params
15668 Get rid of use_standard everywhere as only standard conversions are allowed
15669 in overload resolution.
15671 More spec conformance.
15673 2001-12-27 Miguel de Icaza <miguel@ximian.com>
15675 * driver.cs: Add --timestamp, to see where the compiler spends
15678 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
15679 `this' in static code.
15681 (SimpleName.DoResolve): Implement in terms of a helper function
15682 that allows static-references to be passed upstream to
15685 (Expression.ResolveWithSimpleName): Resolve specially simple
15686 names when called by MemberAccess to implement the special
15689 (Expression.ImplicitReferenceConversion): Handle conversions from
15690 Null to reference types before others, as Null's type is
15693 * expression.cs (Invocation.EmitCall): Handle the special case of
15694 calling methods declared on a reference type from a ValueType
15695 (Base classes System.Object and System.Enum)
15697 (MemberAccess.Resolve): Only perform lookups on Enumerations if
15698 the left hand side is a TypeExpr, not on every enumeration.
15700 (Binary.Resolve): If types are reference types, then do a cast to
15701 object on operators != and == of both arguments.
15703 * typemanager.cs (FindMembers): Extract instance and static
15704 members if requested.
15706 * interface.cs (PopulateProperty): Use void_type instead of null
15707 as the return type for the setter method.
15709 (PopulateIndexer): ditto.
15711 2001-12-27 Ravi Pratap <ravi@ximian.com>
15713 * support.cs (ReflectionParameters): Fix minor bug where we
15714 were examining the wrong parameter for the ParamArray attribute.
15716 Cope with requests for the type of the parameter at position
15717 greater than the params parameter's. We now return the element
15718 type of the params array as that makes more sense.
15720 * expression.cs (Invocation.IsParamsMethodApplicable): Update
15721 accordingly as we no longer have to extract the element type
15724 (Invocation.OverloadResolve): Update.
15726 2001-12-27 Miguel de Icaza <miguel@ximian.com>
15728 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
15729 against IEnumerator, test whether the return value is a descendant
15730 of the IEnumerator interface.
15732 * class.cs (Indexer.Define): Use an auxiliary method to implement
15733 the other bits of the method definition. Begin support for
15734 explicit interface implementation.
15736 (Property.DefineMethod): Use TypeManager.void_type instead of null
15737 for an empty return value.
15739 2001-12-26 Miguel de Icaza <miguel@ximian.com>
15741 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
15742 dealing with a FieldExpr which is composed of a FieldBuilder, in
15743 the code path we did extract the constant, but we should have
15744 obtained the underlying value to be able to cast it (otherwise we
15745 end up in an infinite loop, this is what Ravi was running into).
15747 (ArrayCreation.UpdateIndices): Arrays might be empty.
15749 (MemberAccess.ResolveMemberAccess): Add support for section
15750 14.5.4.1 that deals with the special case of E.I when E is a type
15751 and something else, that I can be a reference to a static member.
15753 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
15754 handle a particular array type to create byte blobs, it is just
15755 something we dont generate byteblobs for.
15757 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
15760 * location.cs (Push): remove the key from the hashtable that we
15761 are about to add. This happens for empty files.
15763 * driver.cs: Dispose files after we have parsed them.
15765 (tokenize): new function that only runs the tokenizer on its
15766 input, for speed testing.
15768 2001-12-26 Ravi Pratap <ravi@ximian.com>
15770 * class.cs (Event.Define): Define the private field only if there
15771 are no accessors defined.
15773 * expression.cs (ResolveMemberAccess): If there is no associated
15774 field with the event, that means we have an event defined with its
15775 own accessors and we should flag error cs0070 since transforming
15776 ourselves into a field is not valid in that case.
15778 * ecore.cs (SimpleName.DoResolve): Same as above.
15780 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
15781 and charset to sane values.
15783 2001-12-25 Ravi Pratap <ravi@ximian.com>
15785 * assign.cs (DoResolve): Perform check on events only if they
15786 are being accessed outside the declaring type.
15788 * cs-parser.jay (event_declarations): Update rules to correctly
15789 set the type of the implicit parameter etc.
15791 (add_accessor, remove_accessor): Set current local parameters.
15793 * expression.cs (Binary): For delegate addition and subtraction,
15794 cast the return value from the method into the appropriate delegate
15797 2001-12-24 Ravi Pratap <ravi@ximian.com>
15799 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
15800 of these as the workaround is unnecessary.
15802 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
15803 delegate data - none of that is needed at all.
15805 Re-write bits to extract the instance expression and the delegate method
15808 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
15811 * attribute.cs (ApplyAttributes): New method to take care of common tasks
15812 of attaching attributes instead of duplicating code everywhere.
15814 * everywhere : Update code to do attribute emission using the above method.
15816 2001-12-23 Miguel de Icaza <miguel@ximian.com>
15818 * expression.cs (IsParamsMethodApplicable): if there are not
15819 parameters, return immediately.
15821 * ecore.cs: The 0 literal can be implicity converted to an enum
15824 (SimpleName.DoResolve): First lookup the type, then lookup the
15827 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
15828 want to get its address. If the InstanceExpression is not
15829 addressable, store the result in a temporary variable, then get
15832 * codegen.cs: Only display 219 errors on warning level or above.
15834 * expression.cs (ArrayAccess): Make it implement the
15835 IMemoryLocation interface.
15837 (Binary.DoResolve): handle the operator == (object a, object b)
15838 and operator != (object a, object b) without incurring into a
15839 BoxedCast (because 5 != o should never be performed).
15841 Handle binary enumerator operators.
15843 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
15844 value type, otherwise use Ldelem_ref.
15846 Use precomputed names;
15848 (AddressOf): Implement address of
15850 * cs-parser.jay (labeled_statement): Fix recursive block
15851 addition by reworking the production.
15853 * expression.cs (New.DoEmit): New has a special case:
15855 If we are dealing with a ValueType, we have a few
15856 situations to deal with:
15858 * The target of New is a ValueType variable, that is
15859 easy, we just pass this as the variable reference
15861 * The target of New is being passed as an argument,
15862 to a boxing operation or a function that takes a
15865 In this case, we need to create a temporary variable
15866 that is the argument of New.
15869 2001-12-23 Ravi Pratap <ravi@ximian.com>
15871 * rootcontext.cs (LookupType): Check that current_type is not null before
15872 going about looking at nested types.
15874 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
15875 not implement the IAssignMethod interface any more.
15877 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
15878 where we tranform them into FieldExprs if they are being resolved from within
15879 the declaring type.
15881 * ecore.cs (SimpleName.DoResolve): Do the same here.
15883 * assign.cs (DoResolve, Emit): Clean up code considerably.
15885 * ../errors/bug10.cs : Add.
15887 * ../errors/cs0070.cs : Add.
15889 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
15891 * assign.cs : Get rid of EventIsLocal everywhere.
15893 2001-12-23 Miguel de Icaza <miguel@ximian.com>
15895 * ecore.cs (ConvertIntLiteral): finished the implementation.
15897 * statement.cs (SwitchLabel): Convert the value we are using as a
15898 key before looking up the table.
15900 2001-12-22 Miguel de Icaza <miguel@ximian.com>
15902 * codegen.cs (EmitTopBlock): Require a Location argument now.
15904 * cs-parser.jay (constructor_declarator): We need to setup
15905 current_local_parameters before we parse the
15906 opt_constructor_initializer, to allow the variables to be bound
15907 to the constructor arguments.
15909 * rootcontext.cs (LookupType): First lookup nested classes in our
15910 class and our parents before we go looking outside our class.
15912 * expression.cs (ConstantFold): Extract/debox the values at the
15915 * rootcontext.cs (EmitCode): Resolve the constants first before we
15916 resolve the types. This is not really needed, but it helps debugging.
15918 * statement.cs: report location.
15920 * cs-parser.jay: pass location to throw statement.
15922 * driver.cs: Small bug fix.
15924 * report.cs: Updated format to be 4-zero filled digits.
15926 2001-12-22 Ravi Pratap <ravi@ximian.com>
15928 * expression.cs (CheckIndices): Fix minor bug where the wrong
15929 variable was being referred to ;-)
15931 (DoEmit): Do not call EmitStaticInitializers when the
15932 underlying type is System.Object.
15934 2001-12-21 Ravi Pratap <ravi@ximian.com>
15936 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
15937 and do the usual workaround for SRE.
15939 * class.cs (MyEventBuilder.EventType): New member to get at the type
15940 of the event, quickly.
15942 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
15944 * assign.cs (Assign.DoResolve): Handle the case when the target
15945 is an EventExpr and perform the necessary checks.
15947 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
15950 (SimpleName.MemberStaticCheck): Include check for EventExpr.
15952 (EventExpr): Set the type in the constructor itself since we
15953 are meant to be born fully resolved.
15955 (EventExpr.Define): Revert code I wrote earlier.
15957 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
15958 instance expression is null. The instance expression is a This in that case
15959 or a null, depending on whether it is a static method or not.
15961 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
15962 refers to more than one method.
15964 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
15965 and accordingly flag errors.
15967 2001-12-21 Miguel de Icaza <miguel@ximian.com>
15969 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
15971 2001-12-22 Miguel de Icaza <miguel@ximian.com>
15973 * location.cs (ToString): Provide useful rutine.
15975 2001-12-21 Miguel de Icaza <miguel@ximian.com>
15977 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
15978 objects, return the actual integral boxed.
15980 * statement.cs (SwitchLabel): define an ILLabel for each
15983 (Switch.CheckSwitch): If the value is a Literal, extract
15984 the underlying literal.
15986 Also in the unused hashtable we had, add the SwitchLabel so we can
15987 quickly look this value up.
15989 * constant.cs: Implement a bunch of new constants. Rewrite
15990 Literal based on this. Made changes everywhere to adapt to this.
15992 * expression.cs (Expression.MakeByteBlob): Optimize routine by
15993 dereferencing array only once, and also copes with enumrations.
15995 bytes are two bytes wide, not one.
15997 (Cast): Perform constant conversions.
15999 * ecore.cs (TryImplicitIntConversion): Return literals instead of
16000 wrappers to the literals here.
16002 * expression.cs (DoNumericPromotions): long literals can converted
16003 to ulong implicity (this is taken care of elsewhere, but I was
16004 missing this spot).
16006 * ecore.cs (Expression.Literalize): Make the return type Literal,
16007 to improve type checking.
16009 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
16011 2001-12-20 Miguel de Icaza <miguel@ximian.com>
16013 * literal.cs: Revert code from ravi that checked the bounds. The
16014 bounds are sane by the definition of the type itself.
16016 * typemanager.cs: Fix implementation of ImplementsInterface. We
16017 need to actually look up in our parent hierarchy for interfaces
16020 * const.cs: Use the underlying type for enumerations
16022 * delegate.cs: Compute the basename for the delegate creation,
16023 that should fix the delegate test case, and restore the correct
16024 Type Lookup semantics in rootcontext
16026 * rootcontext.cs: Revert Ravi's last patch. The correct way of
16027 referencing a nested type with the Reflection API is using the "+"
16030 * cs-parser.jay: Do not require EOF token at the end.
16032 2001-12-20 Ravi Pratap <ravi@ximian.com>
16034 * rootcontext.cs (LookupType): Concatenate type names with
16035 a '.' instead of a '+' The test suite passes again.
16037 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
16038 field of the enumeration.
16040 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
16041 the case when the member is an EventExpr.
16043 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
16044 static has an associated instance expression.
16046 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
16048 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
16050 * class.cs (Event.Define): Register event and perform appropriate checks
16053 We define the Add and Remove methods even if the use provides none because
16054 in that case, we provide default implementations ourselves.
16056 Define a private field of the type of the event. This is done by the CSC compiler
16057 and we should be doing it too ;-)
16059 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
16060 More methods we use in code we generate.
16062 (multicast_delegate_type, delegate_type): Two separate types since the distinction
16065 (InitCoreTypes): Update accordingly for the above.
16067 * class.cs (Event.Emit): Generate code for default accessors that we provide
16069 (EmitDefaultMethod): Do the job in the above.
16071 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
16074 2001-12-20 Miguel de Icaza <miguel@ximian.com>
16076 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
16077 builders even if we were missing one.
16079 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
16080 pass the Basename as our class name instead of the Name. The
16081 basename will be correctly composed for us.
16083 * parameter.cs (Paramters): Now takes a Location argument.
16085 * decl.cs (DeclSpace.LookupType): Removed convenience function and
16086 make all the code call directly LookupType in RootContext and take
16087 this chance to pass the Location information everywhere.
16089 * Everywhere: pass Location information.
16091 2001-12-19 Miguel de Icaza <miguel@ximian.com>
16093 * class.cs (Constructor.Define): Updated way of detecting the
16094 length of the parameters.
16096 (TypeContainer.DefineType): Use basename as the type name for
16099 (TypeContainer.Define): Do not recursively define types here, as
16100 definition is taken care in order by the RootContext.
16102 * tree.cs: Keep track of namespaces in a per-file basis.
16104 * parameter.cs (Parameter.ComputeSignature): Update to use
16107 (Parameters.GetSignature): ditto.
16109 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
16110 instead of a TypeContainer.
16112 (Interface.SemanticAnalysis): Use `this' instead of our parent to
16113 resolve names. Because we need to be resolve in our context, not
16116 * driver.cs: Implement response files.
16118 * class.cs (TypeContainer.DefineType): If we are defined, do not
16119 redefine ourselves.
16121 (Event.Emit): Emit the code for add/remove handlers.
16122 (Event.Define): Save the MethodBuilders for add/remove.
16124 * typemanager.cs: Use pair here too.
16126 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
16127 DictionaryEntry requires the first argument to be non-null.
16129 (enum_declaration): Compute full name for registering the
16132 (delegate_declaration): Instead of using
16133 formal_parameter_list, use opt_formal_parameter_list as the list
16136 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
16137 (EventParsing): New property that controls whether `add' and
16138 `remove' are returned as tokens or identifiers (for events);
16140 2001-12-19 Ravi Pratap <ravi@ximian.com>
16142 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
16143 use MyEventBuilder only and let it wrap the real builder for us.
16145 (MyEventBuilder): Revamp constructor etc.
16147 Implement all operations that we perform on EventBuilder in precisely the same
16150 (FindMembers): Update to use the EventBuilder member.
16152 (Event.Emit): Update accordingly.
16154 2001-12-18 Ravi Pratap <ravi@ximian.com>
16156 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
16157 by calling the appropriate methods.
16159 (GetCustomAttributes): Make stubs as they cannot possibly do anything
16162 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
16164 2001-12-17 Ravi Pratap <ravi@ximian.com>
16166 * delegate.cs (Delegate.Populate): Check that the return type
16167 and various parameters types are indeed accessible.
16169 * class.cs (Constructor.Define): Same here.
16171 (Field.Define): Ditto.
16173 (Event.Define): Ditto.
16175 (Operator.Define): Check that the underlying Method defined itself
16176 correctly - so it's MethodBuilder should not be null.
16178 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
16179 expression happens to be null.
16181 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
16182 members but as of now we don't seem to be able to do anything really useful with it.
16184 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
16185 not the EventBuilder.
16187 2001-12-18 Miguel de Icaza <miguel@ximian.com>
16189 * cs-tokenizer.cs: Add support for defines.
16190 Add support for #if, #elif, #else, #endif
16192 (eval_var): evaluates a variable.
16193 (eval): stubbed for evaluating functions.
16195 * cs-parser.jay: Pass the defines information
16197 * driver.cs: Add --define command line option.
16199 * decl.cs: Move MemberCore here.
16201 Make it the base class for DeclSpace. This allows us to catch and
16202 report 108 and 109 for everything now.
16204 * class.cs (TypeContainer.Define): Extract all the members
16205 before populating and emit the warning 108 (new keyword required
16206 to override) instead of having each member implement this.
16208 (MemberCore.Define): New abstract method, we will be using this in
16209 the warning reporting engine in Populate.
16211 (Operator.Define): Adjust to new MemberCore protocol.
16213 * const.cs (Const): This does not derive from Expression, it is a
16214 temporary object we use to create fields, it is a MemberCore.
16216 * class.cs (Method.Define): Allow the entry point to be in a
16219 * driver.cs: Rewrite the argument handler to clean it up a bit.
16221 * rootcontext.cs: Made it just an auxiliary namespace feature by
16222 making everything static.
16224 * driver.cs: Adapt code to use RootContext type name instead of
16227 * delegate.cs: Remove RootContext argument.
16229 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
16232 * class.cs (Event.Define): The lookup can fail.
16234 * cs-tokenizer.cs: Begin implementation of pre-procesor.
16236 * expression.cs: Resolve the this instance before invoking the code.
16238 2001-12-17 Miguel de Icaza <miguel@ximian.com>
16240 * cs-parser.jay: Add a production in element_access that allows
16241 the thing to become a "type" reference. This way we can parse
16242 things like "(string [])" as a type.
16244 Note that this still does not handle the more complex rules of
16248 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
16250 * ecore.cs: (CopyNewMethods): new utility function used to
16251 assemble the list of methods from running FindMembers.
16253 (MemberLookup): Rework FindMembers so that
16255 2001-12-16 Miguel de Icaza <miguel@ximian.com>
16257 * class.cs (TypeContainer): Remove Delegates who fail to be
16260 * delegate.cs (Populate): Verify that we dont get null return
16261 values. TODO: Check for AsAccessible.
16263 * cs-parser.jay: Use basename to emit error 574 (destructor should
16264 have the same name as container class), not the full name.
16266 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
16267 possible representation.
16269 Also implements integer type suffixes U and L.
16271 2001-12-15 Miguel de Icaza <miguel@ximian.com>
16273 * expression.cs (ArrayCreation.DoResolve): We need to do the
16274 argument resolution *always*.
16276 * decl.cs: Make this hold the namespace. Hold the root context as
16278 (LookupType): Move here.
16280 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
16282 * location.cs (Row, Name): Fixed the code, it was always returning
16283 references to the first file.
16285 * interface.cs: Register properties defined through interfaces.
16287 * driver.cs: Add support for globbing on the command line
16289 * class.cs (Field): Make it derive from MemberCore as well.
16292 2001-12-15 Ravi Pratap <ravi@ximian.com>
16294 * class.cs (Event::Define): Check that the type of the event is a delegate
16295 type else flag error #66.
16297 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
16300 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
16301 values of EntryPoint, CharSet etc etc.
16303 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
16305 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
16306 be null and we should ignore this. I am not sure if this is really clean. Apparently,
16307 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
16308 which needs this to do its work.
16310 * ../errors/cs0066.cs : Add.
16312 2001-12-14 Miguel de Icaza <miguel@ximian.com>
16314 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
16317 * class.cs: (MethodSignature.MethodSignature): Removed hack that
16318 clears out the parameters field.
16319 (MemberSignatureCompare): Cleanup
16321 (MemberCore): New base class used to share code between MethodCore
16324 (RegisterRequiredImplementations) BindingFlags.Public requires
16325 either BindingFlags.Instace or Static. Use instance here.
16327 (Property): Refactored code to cope better with the full spec.
16329 * parameter.cs (GetParameterInfo): Return an empty array instead
16332 * class.cs (Property): Abstract or extern properties have no bodies.
16334 * parameter.cs (GetParameterInfo): return a zero-sized array.
16336 * class.cs (TypeContainer.MethodModifiersValid): Move all the
16337 method modifier validation to the typecontainer so we can reuse
16338 this on properties.
16340 (MethodCore.ParameterTypes): return an empty sized array of types.
16342 (Property.Define): Test property modifier validity.
16344 Add tests for sealed/override too.
16346 (Method.Emit): abstract or extern methods have no bodies.
16348 2001-12-14 Ravi Pratap <ravi@ximian.com>
16350 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
16353 (Method::Define, ::Emit): Modify accordingly.
16355 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
16357 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
16359 * makefile: Pass in /unsafe.
16361 2001-12-13 Miguel de Icaza <miguel@ximian.com>
16363 * class.cs (MakeKey): Kill routine.
16365 * class.cs (TypeContainer.Define): Correctly define explicit
16366 method implementations (they require the full interface name plus
16369 * typemanager.cs: Deply the PtrHashtable here and stop using the
16370 lame keys. Things work so much better.
16372 This of course broke everyone who depended on `RegisterMethod' to
16373 do the `test for existance' test. This has to be done elsewhere.
16375 * support.cs (PtrHashtable): A hashtable that avoid comparing with
16376 the object stupid Equals method (because, that like fails all over
16377 the place). We still do not use it.
16379 * class.cs (TypeContainer.SetRequiredInterface,
16380 TypeContainer.RequireMethods): Killed these two routines and moved
16381 all the functionality to RegisterRequiredImplementations.
16383 (TypeContainer.RegisterRequiredImplementations): This routine now
16384 registers all the implementations required in an array for the
16385 interfaces and abstract methods. We use an array of structures
16386 which can be computed ahead of time to reduce memory usage and we
16387 also assume that lookups are cheap as most classes will not
16388 implement too many interfaces.
16390 We also avoid creating too many MethodSignatures.
16392 (TypeContainer.IsInterfaceMethod): Update and optionally does not
16393 clear the "pending" bit if we find that there are problems with
16396 (TypeContainer.VerifyPendingMethods): Update to report errors of
16397 methods that look like implementations but are not.
16399 (TypeContainer.Define): Add support for explicit interface method
16402 2001-12-12 Miguel de Icaza <miguel@ximian.com>
16404 * typemanager.cs: Keep track of the parameters here instead of
16405 being a feature of the TypeContainer.
16407 * class.cs: Drop the registration of parameters here, as
16408 InterfaceMethods are also interface declarations.
16410 * delegate.cs: Register methods with the TypeManager not only with
16411 the TypeContainer. This code was buggy.
16413 * interface.cs: Full registation here.
16415 2001-12-11 Miguel de Icaza <miguel@ximian.com>
16417 * expression.cs: Remove reducer for binary expressions, it can not
16420 * const.cs: Put here the code that used to go into constant.cs
16422 * constant.cs: Put here the code for constants, this is a new base
16423 class for Literals.
16425 * literal.cs: Make Literal derive from Constant.
16427 2001-12-09 Miguel de Icaza <miguel@ximian.com>
16429 * statement.cs (Return.Emit): Report error 157 if the user
16430 attempts to return from a finally block.
16432 (Return.Emit): Instead of emitting a return, jump to the end of
16435 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
16436 LocalBuilder to store the result of the function. ReturnLabel is
16437 the target where we jump.
16440 2001-12-09 Radek Doulik <rodo@ximian.com>
16442 * cs-parser.jay: remember alias in current namespace
16444 * ecore.cs (SimpleName::DoResolve): use aliases for types or
16447 * class.cs (LookupAlias): lookup alias in my_namespace
16449 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
16451 (LookupAlias): lookup alias in this and if needed in parent
16454 2001-12-08 Miguel de Icaza <miguel@ximian.com>
16458 * rootcontext.cs: (ModuleBuilder) Made static, first step into
16459 making things static. I need this to avoid passing the
16460 TypeContainer when calling ParameterType.
16462 * support.cs (InternalParameters.ParameterType): Remove ugly hack
16463 that did string manipulation to compute the type and then call
16464 GetType. Use Parameter.ParameterType instead.
16466 * cs-tokenizer.cs: Consume the suffix for floating values.
16468 * expression.cs (ParameterReference): figure out whether this is a
16469 reference parameter or not. Kill an extra variable by computing
16470 the arg_idx during emission.
16472 * parameter.cs (Parameters.GetParameterInfo): New overloaded
16473 function that returns whether a parameter is an out/ref value or not.
16475 (Parameter.ParameterType): The type of the parameter (base,
16476 without ref/out applied).
16478 (Parameter.Resolve): Perform resolution here.
16479 (Parameter.ExternalType): The full type (with ref/out applied).
16481 * statement.cs (Using.Emit, Using.EmitExpression): Implement
16482 support for expressions on the using statement.
16484 2001-12-07 Miguel de Icaza <miguel@ximian.com>
16486 * statement.cs (Using.EmitLocalVariableDecls): Split the
16487 localvariable handling of the using statement.
16489 (Block.EmitMeta): Keep track of variable count across blocks. We
16490 were reusing slots on separate branches of blocks.
16492 (Try.Emit): Emit the general code block, we were not emitting it.
16494 Check the type of the declaration to be an IDisposable or
16495 something that can be implicity converted to it.
16497 Emit conversions if required.
16499 * ecore.cs (EmptyExpression): New utility class.
16500 (Expression.ImplicitConversionExists): New utility function.
16502 2001-12-06 Miguel de Icaza <miguel@ximian.com>
16504 * statement.cs (Using): Implement.
16506 * expression.cs (LocalVariableReference): Support read only variables.
16508 * statement.cs: Remove the explicit emit for the Leave opcode.
16509 (VariableInfo): Add a readonly field.
16511 2001-12-05 Miguel de Icaza <miguel@ximian.com>
16513 * ecore.cs (ConvCast): new class used to encapsulate the various
16514 explicit integer conversions that works in both checked and
16515 unchecked contexts.
16517 (Expression.ConvertNumericExplicit): Use new ConvCast class to
16518 properly generate the overflow opcodes.
16520 2001-12-04 Miguel de Icaza <miguel@ximian.com>
16522 * statement.cs: The correct type for the EmptyExpression is the
16523 element_type, not the variable type. Ravi pointed this out.
16525 2001-12-04 Ravi Pratap <ravi@ximian.com>
16527 * class.cs (Method::Define): Handle PInvoke methods specially
16528 by using DefinePInvokeMethod instead of the usual one.
16530 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
16531 above to do the task of extracting information and defining the method.
16533 2001-12-04 Ravi Pratap <ravi@ximian.com>
16535 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
16536 of the condition for string type.
16538 (Emit): Move that here.
16540 (ArrayCreation::CheckIndices): Keep string literals in their expression
16543 (EmitDynamicInitializers): Handle strings appropriately.
16545 2001-12-04 Miguel de Icaza <miguel@ximian.com>
16547 * codegen.cs (EmitContext): Replace multiple variables with a
16548 single pointer to the current Switch statement.
16550 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
16553 2001-12-03 Miguel de Icaza <miguel@ximian.com>
16557 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
16560 (Foreach.Emit): Foreach on arrays was not setting
16561 up the loop variables (for break/continue).
16563 (GotoCase): Semi-implented.
16565 2001-12-03 Ravi Pratap <ravi@ximian.com>
16567 * attribute.cs (CheckAttribute): Handle system attributes by using
16568 Attribute.GetAttributes to examine information we need.
16570 (GetValidPlaces): Same here.
16572 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
16574 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
16576 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
16578 (Method::Define): Set appropriate flags if we have a DllImport attribute.
16580 (Method::Emit): Handle the case when we are a PInvoke method.
16582 2001-12-03 Miguel de Icaza <miguel@ximian.com>
16584 * expression.cs: Use ResolveWithSimpleName on compound names.
16586 2001-12-02 Ravi Pratap <ravi@ximian.com>
16588 * constant.cs (EmitConstant): Make sure we resolve the associated expression
16589 before trying to reduce it.
16591 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
16593 * constant.cs (LookupConstantValue): Implement.
16595 (EmitConstant): Use the above in emitting the constant.
16597 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
16598 that are user-defined by doing a LookupConstantValue on them.
16600 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
16603 2001-11-29 Miguel de Icaza <miguel@ximian.com>
16605 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
16607 (BaseAccess.DoResolve): Implement.
16609 (MemberAccess.DoResolve): Split this routine into a
16610 ResolveMemberAccess routine that can be used independently
16612 2001-11-28 Miguel de Icaza <miguel@ximian.com>
16614 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
16615 As that share bits of the implementation. Is returns a boolean,
16616 while As returns the Type that is being probed.
16618 2001-12-01 Ravi Pratap <ravi@ximian.com>
16620 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
16621 instead of a Literal - much easier.
16623 (EnumInTransit): Remove - utterly useless :-)
16625 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
16627 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
16629 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
16630 chain when we have no associated expression.
16632 2001-11-30 Ravi Pratap <ravi@ximian.com>
16634 * constant.cs (Define): Use Location while reporting the errror.
16636 Also emit a warning when 'new' is used and there is no inherited
16639 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
16642 (LookupEnumValue): Implement to lookup an enum member's value and define it
16645 (Populate): Re-write accordingly to use the above routine.
16647 2001-11-27 Miguel de Icaza <miguel@ximian.com>
16649 * expression.cs (This): Fix prototype for DoResolveLValue to
16650 override the base class DoResolveLValue.
16652 * cs-parser.cs: Report errors cs574 and cs575 (destructor
16655 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
16656 (we need to load the address of the field here). This fixes
16659 (FieldExpr.DoResolveLValue): Call the DoResolve
16660 function to initialize the Instance expression.
16662 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
16663 correctly the GetEnumerator operation on a value type.
16665 * cs-parser.jay: Add more simple parsing error catches.
16667 * statement.cs (Switch): Add support for string switches.
16668 Handle null specially.
16670 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
16672 2001-11-28 Ravi Pratap <ravi@ximian.com>
16674 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
16676 (declare_local_constant): New helper function.
16678 * statement.cs (AddConstant): Keep a separate record of constants
16680 (IsConstant): Implement to determine if a variable is a constant.
16682 (GetConstantExpression): Implement.
16684 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
16686 * statement.cs (IsVariableDefined): Re-write.
16688 2001-11-27 Ravi Pratap <ravi@ximian.com>
16690 * class.cs (TypeContainer::FindMembers): Look for constants
16691 in the case when we are looking for MemberTypes.Field
16693 * expression.cs (MemberAccess::DoResolve): Check that in the
16694 case we are a FieldExpr and a Literal, we are not being accessed
16695 by an instance reference.
16697 * cs-parser.jay (local_constant_declaration): Implement.
16699 (declaration_statement): Implement for constant declarations.
16701 2001-11-26 Miguel de Icaza <miguel@ximian.com>
16703 * statement.cs (Switch): Catch double defaults.
16705 (Switch): More work on the switch() statement
16706 implementation. It works for integral values now, need to finish
16710 2001-11-24 Miguel de Icaza <miguel@ximian.com>
16712 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
16713 integer literals into other integer literals. To be used by
16716 2001-11-24 Ravi Pratap <ravi@ximian.com>
16718 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
16721 (EmitDynamicInitializers): Cope with the above since we extract data
16722 directly from ArrayData now.
16724 (ExpectInitializers): Keep track of whether initializers are mandatory
16727 (Bounds): Make it a hashtable to prevent the same dimension being
16728 recorded for every element in that dimension.
16730 (EmitDynamicInitializers): Fix bug which prevented the Set array method
16733 Also fix bug which was causing the indices to be emitted in the reverse
16736 2001-11-24 Miguel de Icaza <miguel@ximian.com>
16738 * expression.cs (ArrayCreation): Implement the bits that Ravi left
16739 unfinished. They do not work, because the underlying code is
16742 2001-11-22 Miguel de Icaza <miguel@ximian.com>
16744 * cs-parser.jay: Remove bogus fixme.
16746 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
16747 on Switch statement.
16749 2001-11-23 Ravi Pratap <ravi@ximian.com>
16751 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
16754 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
16755 parameter. Apparently, any expression is allowed.
16757 (ValidateInitializers): Update accordingly.
16759 (CheckIndices): Fix some tricky bugs thanks to recursion.
16761 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
16762 I was being completely brain-dead.
16764 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
16765 and re-write acordingly.
16767 (DelegateInvocation): Re-write accordingly.
16769 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
16771 (MakeByteBlob): Handle types more correctly.
16773 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
16774 initialization from expressions but it is incomplete because I am a complete
16777 2001-11-22 Miguel de Icaza <miguel@ximian.com>
16779 * statement.cs (If.Emit): Fix a bug that generated incorrect code
16780 on If. Basically, we have to return `true' (ie, we do return to
16781 our caller) only if both branches of the if return.
16783 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
16784 short-circuit operators, handle them as short circuit operators.
16786 (Cast.DoResolve): Resolve type.
16787 (Cast.Cast): Take an expression as the target type.
16789 * cs-parser.jay (cast_expression): Remove old hack that only
16790 allowed a limited set of types to be handled. Now we take a
16791 unary_expression and we resolve to a type during semantic
16794 Use the grammar productions from Rhys to handle casts (this is
16795 not complete like Rhys syntax yet, we fail to handle that corner
16796 case that C# has regarding (-x), but we will get there.
16798 2001-11-22 Ravi Pratap <ravi@ximian.com>
16800 * class.cs (EmitFieldInitializer): Take care of the case when we have a
16801 field which is an array type.
16803 * cs-parser.jay (declare_local_variables): Support array initialization too.
16805 * typemanager.cs (MakeKey): Implement.
16807 (everywhere): Use the above appropriately.
16809 * cs-parser.jay (for_statement): Update for array initialization while
16810 declaring variables.
16812 * ecore.cs : The error message was correct, it's the variable's names that
16813 were misleading ;-) Make the code more readable.
16815 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
16816 the correct type etc.
16818 (ConvertExplicit): Handle Enum types by examining the underlying type.
16820 2001-11-21 Ravi Pratap <ravi@ximian.com>
16822 * parameter.cs (GetCallingConvention): Always return
16823 CallingConventions.Standard for now.
16825 2001-11-22 Miguel de Icaza <miguel@ximian.com>
16827 * expression.cs (Binary.ResolveOperator): Update the values of `l'
16828 and `r' after calling DoNumericPromotions.
16830 * ecore.cs: Fix error message (the types were in the wrong order).
16832 * statement.cs (Foreach.ProbeCollectionType): Need to pass
16833 BindingFlags.Instance as well
16835 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
16836 implicit int literal conversion in an empty cast so that we
16837 propagate the right type upstream.
16839 (UnboxCast): new class used to unbox value types.
16840 (Expression.ConvertExplicit): Add explicit type conversions done
16843 (Expression.ImplicitNumericConversion): Oops, forgot to test for
16844 the target type before applying the implicit LongLiterals to ULong
16847 2001-11-21 Miguel de Icaza <miguel@ximian.com>
16849 * cs-parser.jay (for_statement): Reworked the way For works: now
16850 we declare manually any variables that are introduced in
16851 for_initializer to solve the problem of having out-of-band code
16852 emition (that is what got for broken).
16854 (declaration_statement): Perform the actual variable declaration
16855 that used to be done in local_variable_declaration here.
16857 (local_variable_declaration): Do not declare anything, just pass
16858 the information on a DictionaryEntry
16860 2001-11-20 Ravi Pratap <ravi@ximian.com>
16862 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
16863 re-write of the logic to now make it recursive.
16865 (UpdateIndices): Re-write accordingly.
16867 Store element data in a separate ArrayData list in the above methods.
16869 (MakeByteBlob): Implement to dump the array data into a byte array.
16871 2001-11-19 Ravi Pratap <ravi@ximian.com>
16873 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
16876 * constant.cs (Define): Implement.
16878 (EmitConstant): Re-write fully.
16880 Pass in location info.
16882 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
16885 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
16886 DictionaryEntry since we need location info too.
16888 (constant_declaration): Update accordingly.
16890 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
16891 code into another method : UpdateIndices.
16893 2001-11-18 Ravi Pratap <ravi@ximian.com>
16895 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
16896 some type checking etc.
16898 2001-11-17 Ravi Pratap <ravi@ximian.com>
16900 * expression.cs (ArrayCreation::ValidateInitializers): Implement
16901 bits to provide dimension info if the user skips doing that.
16903 Update second constructor to store the rank correctly.
16905 2001-11-16 Ravi Pratap <ravi@ximian.com>
16907 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
16908 and try to implement.
16910 * ../errors/cs0150.cs : Add.
16912 * ../errors/cs0178.cs : Add.
16914 2001-11-16 Miguel de Icaza <miguel@ximian.com>
16916 * statement.cs: Implement foreach on multi-dimensional arrays.
16918 * parameter.cs (Parameters.GetParameterByName): Also lookup the
16919 name of the params argument.
16921 * expression.cs: Use EmitStoreOpcode to get the right opcode while
16922 initializing the array.
16924 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
16925 we can use this elsewhere.
16927 * statement.cs: Finish implementation of foreach for single
16930 * cs-parser.jay: Use an out-of-band stack to pass information
16931 around, I wonder why I need this.
16933 foreach_block: Make the new foreach_block the current_block.
16935 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
16936 function used to return a static Parameters structure. Used for
16937 empty parameters, as those are created very frequently.
16939 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
16941 2001-11-15 Ravi Pratap <ravi@ximian.com>
16943 * interface.cs : Default modifier is private, not public. The
16944 make verify test passes again.
16946 2001-11-15 Ravi Pratap <ravi@ximian.com>
16948 * support.cs (ReflectionParameters): Fix logic to determine
16949 whether the last parameter is a params one. Test 9 passes again.
16951 * delegate.cs (Populate): Register the builders we define with
16952 RegisterParameterForBuilder. Test 19 passes again.
16954 * cs-parser.jay (property_declaration): Reference $6 instead
16955 of $$ to get at the location.
16957 (indexer_declaration): Similar stuff.
16959 (attribute): Ditto.
16961 * class.cs (Property): Register parameters for the Get and Set methods
16962 if they exist. Test 23 passes again.
16964 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
16965 call to EmitArguments as we are sure there aren't any params arguments.
16966 Test 32 passes again.
16968 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
16969 IndexOutOfRangeException.
16971 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
16972 Test 33 now passes again.
16974 2001-11-15 Miguel de Icaza <miguel@ximian.com>
16976 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
16977 broke a bunch of things. Will have to come up with a better way
16978 of tracking locations.
16980 * statement.cs: Implemented foreach for single dimension arrays.
16982 2001-11-09 Miguel de Icaza <miguel@ximian.com>
16984 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
16985 an error. This removes the lookup from the critical path.
16987 * cs-parser.jay: Removed use of temporary_loc, which is completely
16990 2001-11-14 Miguel de Icaza <miguel@ximian.com>
16992 * support.cs (ReflectionParameters.ParameterModifier): Report
16993 whether the argument is a PARAMS argument or not.
16995 * class.cs: Set the attribute `ParamArrayAttribute' on the
16996 parameter argument.
16998 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
16999 and cons_param_array_attribute (ConstructorInfo for
17000 ParamArrayAttribute).,
17002 * codegen.cs: Emit the return using the `Return' statement, that
17003 way we can report the error correctly for missing return values.
17005 * class.cs (Method.Emit): Clean up.
17007 * expression.cs (Argument.Resolve): Take another argument: the
17008 location where this argument is used. Notice that this is not
17009 part of the "Argument" class as to reduce the size of the
17010 structure (we know the approximate location anyways).
17012 Test if the argument is a variable-reference, if not, then
17013 complain with a 206.
17015 (Argument.Emit): Emit addresses of variables.
17017 (Argument.FullDesc): Simplify.
17019 (Invocation.DoResolve): Update for Argument.Resolve.
17021 (ElementAccess.DoResolve): ditto.
17023 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
17024 method should be virtual, as this method is always virtual.
17026 (NewDelegate.DoResolve): Update for Argument.Resolve.
17028 * class.cs (ConstructorInitializer.DoResolve): ditto.
17030 * attribute.cs (Attribute.Resolve): ditto.
17032 2001-11-13 Miguel de Icaza <miguel@ximian.com>
17034 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
17036 * expression.cs (ParameterReference): Drop IStackStorage and implement
17037 IAssignMethod instead.
17039 (LocalVariableReference): ditto.
17041 * ecore.cs (FieldExpr): Drop IStackStorage and implement
17042 IAssignMethod instead.
17044 2001-11-13 Miguel de Icaza <miguel@ximian.com>
17046 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
17047 enumerations that are used in heavily used structures derive from
17048 byte in a laughable and pathetic attempt to reduce memory usage.
17049 This is the kind of pre-optimzations that you should not do at
17050 home without adult supervision.
17052 * expression.cs (UnaryMutator): New class, used to handle ++ and
17053 -- separatedly from the other unary operators. Cleans up the
17054 code, and kills the ExpressionStatement dependency in Unary.
17056 (Unary): Removed `method' and `Arguments' from this class, making
17057 it smaller, and moving it all to SimpleCall, so I can reuse this
17058 code in other locations and avoid creating a lot of transient data
17059 strucutres when not required.
17061 * cs-parser.jay: Adjust for new changes.
17063 2001-11-11 Miguel de Icaza <miguel@ximian.com>
17065 * enum.cs (Enum.Populate): If there is a failure during
17068 * cs-parser.jay (opt_enum_base): we used to catch type errors
17069 here, but this is really incorrect. The type error should be
17070 catched during semantic analysis.
17072 2001-12-11 Ravi Pratap <ravi@ximian.com>
17074 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
17075 current_local_parameters as expected since I, in my stupidity, had forgotten
17078 * attribute.cs (GetValidPlaces): Fix stupid bug.
17080 * class.cs (Method::Emit): Perform check on applicability of attributes.
17082 (Constructor::Emit): Ditto.
17084 (Field::Emit): Ditto.
17086 (Field.Location): Store location information.
17088 (Property, Event, Indexer, Operator): Ditto.
17090 * cs-parser.jay (field_declaration): Pass in location for each field.
17092 * ../errors/cs0592.cs : Add.
17094 2001-11-12 Ravi Pratap <ravi@ximian.com>
17096 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
17098 (InitCoreTypes): Update accordingly.
17100 (RegisterAttrType, LookupAttr): Implement.
17102 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
17103 info about the same.
17105 (Resolve): Update to populate the above as necessary.
17107 (Error592): Helper.
17109 (GetValidPlaces): Helper to the above.
17111 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
17113 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
17115 2001-11-12 Ravi Pratap <ravi@ximian.com>
17117 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
17119 * ../errors/cs0617.cs : Add.
17121 2001-11-11 Ravi Pratap <ravi@ximian.com>
17123 * enum.cs (Emit): Rename to Populate to be more consistent with what
17124 we expect it to do and when exactly it is called.
17126 * class.cs, rootcontext.cs : Update accordingly.
17128 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
17129 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
17131 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
17133 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
17134 of a fieldinfo using the above, when dealing with a FieldBuilder.
17136 2001-11-10 Ravi Pratap <ravi@ximian.com>
17138 * ../errors/cs0031.cs : Add.
17140 * ../errors/cs1008.cs : Add.
17142 * ../errrors/cs0543.cs : Add.
17144 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
17147 (FindMembers): Implement.
17149 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
17150 enums and delegates too.
17152 (enum_types): Rename to builder_to_enum.
17154 (delegate_types): Rename to builder_to_delegate.
17156 * delegate.cs (FindMembers): Implement.
17158 2001-11-09 Ravi Pratap <ravi@ximian.com>
17160 * typemanager.cs (IsEnumType): Implement.
17162 * enum.cs (Emit): Re-write parts to account for the underlying type
17163 better and perform checking etc.
17165 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
17166 of the underlying type.
17168 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
17171 * enum.cs (error31): Helper to report error #31.
17173 * cs-parser.jay (enum_declaration): Store location of each member too.
17175 * enum.cs (member_to_location): New hashtable.
17177 (AddEnumMember): Update location hashtable.
17179 (Emit): Use the location of each member while reporting errors.
17181 2001-11-09 Miguel de Icaza <miguel@ximian.com>
17183 * cs-parser.jay: A for_initializer if is a
17184 local_variable_declaration really ammount to have an implicit
17185 block with the variable declaration and no initializer for for.
17187 * statement.cs (For.Emit): Cope with null initializers.
17189 This fixes the infinite loop on for initializers.
17191 2001-11-08 Miguel de Icaza <miguel@ximian.com>
17193 * enum.cs: More cleanup.
17195 * ecore.cs: Remove dead code.
17197 * class.cs (Property.Emit): More simplification.
17198 (Event.Emit): ditto.
17200 Reworked to have less levels of indentation.
17202 2001-11-08 Ravi Pratap <ravi@ximian.com>
17204 * class.cs (Property): Emit attributes.
17214 * enum.cs (Emit): Ditto.
17216 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
17219 * class.cs (Field, Event, etc.): Move attribute generation into the
17220 Emit method everywhere.
17222 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
17223 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
17224 as we had no way of defining nested enums !
17226 * rootcontext.cs : Adjust code accordingly.
17228 * typemanager.cs (AddEnumType): To keep track of enum types separately.
17230 2001-11-07 Ravi Pratap <ravi@ximian.com>
17232 * expression.cs (EvalConstantExpression): Move into ecore.cs
17234 * enum.cs (Enum): Rename some members and make them public and readonly
17235 according to our convention.
17237 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
17240 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
17242 (Enum::Emit): Write a simple version for now which doesn't try to compute
17243 expressions. I shall modify this to be more robust in just a while.
17245 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
17247 (TypeContainer::CloseType): Create the Enum types too.
17249 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
17251 * expression.cs (EvalConstantExpression): Get rid of completely.
17253 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
17254 user-defined values and other cases.
17256 (IsValidEnumLiteral): Helper function.
17258 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
17259 out there in the case we had a literal FieldExpr.
17261 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
17263 (Literalize): Revamp a bit to take two arguments.
17265 (EnumLiteral): New class which derives from Literal to wrap enum literals.
17267 2001-11-06 Ravi Pratap <ravi@ximian.com>
17269 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
17271 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
17273 (Resolve): Use the above to ensure we have proper initializers.
17275 2001-11-05 Ravi Pratap <ravi@ximian.com>
17277 * expression.cs (Expression::EvalConstantExpression): New method to
17278 evaluate constant expressions.
17280 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
17282 2001-11-07 Miguel de Icaza <miguel@ximian.com>
17284 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
17287 (Binary.ResolveOperator): Handle operator != (object a, object b)
17288 and operator == (object a, object b);
17290 (Binary.DoNumericPromotions): Indicate whether the numeric
17291 promotion was possible.
17293 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
17296 Made the ArrayAccess implement interface IAssignMethod instead of
17297 IStackStore as the order in which arguments are passed reflects
17300 * assign.cs: Instead of using expr.ExprClass to select the way of
17301 assinging, probe for the IStackStore/IAssignMethod interfaces.
17303 * typemanager.cs: Load InitializeArray definition.
17305 * rootcontext.cs (RootContext.MakeStaticData): Used to define
17306 static data that can be used to initialize arrays.
17308 2001-11-05 Miguel de Icaza <miguel@ximian.com>
17310 * expression.cs: Handle operator== and operator!= for booleans.
17312 (Conditioal.Reduce): Implement reducer for the ?: operator.
17314 (Conditional.Resolve): Implement dead code elimination.
17316 (Binary.Resolve): Catch string literals and return a new
17317 concatenated string.
17319 (Unary.Reduce): Implement reduction of unary expressions.
17321 * ecore.cs: Split out the expression core handling here.
17323 (Expression.Reduce): New method used to perform constant folding
17324 and CSE. This is needed to support constant-expressions.
17326 * statement.cs (Statement.EmitBoolExpression): Pass true and false
17327 targets, and optimize for !x.
17329 2001-11-04 Ravi Pratap <ravi@ximian.com>
17331 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
17332 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
17333 set custom atttributes.
17335 * literal.cs (Literal::GetValue): New abstract method to return the actual
17336 value of the literal, cast as an object.
17338 (*Literal): Implement GetValue method.
17340 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
17341 expressions to the arraylist but objects of type Argument.
17343 * class.cs (TypeContainer::Emit): Emit our attributes too.
17345 (Method::Emit, Constructor::Emit): Ditto.
17347 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
17348 to be ignoring earlier.
17350 2001-11-03 Ravi Pratap <ravi@ximian.com>
17352 * attribute.cs (AttributeSection::Define): Implement to do the business
17353 of constructing a CustomAttributeBuilder.
17355 (Attribute): New trivial class. Increases readability of code.
17357 * cs-parser.jay : Update accordingly.
17359 (positional_argument_list, named_argument_list, named_argument): New rules
17361 (attribute_arguments): Use the above so that we are more correct.
17363 2001-11-02 Ravi Pratap <ravi@ximian.com>
17365 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
17366 to perform all checks for a method with a params parameter.
17368 (Invocation::OverloadResolve): Update to use the above method and therefore
17369 cope correctly with params method invocations.
17371 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
17374 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
17375 constructors in our parent too because we can't afford to miss out on
17378 * attribute.cs (AttributeSection): New name for the class Attribute
17380 Other trivial changes to improve readability.
17382 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
17383 use the new class names.
17385 2001-11-01 Ravi Pratap <ravi@ximian.com>
17387 * class.cs (Method::Define): Complete definition for params types too
17389 (Indexer::Define): Ditto.
17391 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
17392 Cope everywhere with a request for info about the array parameter.
17394 2001-11-01 Ravi Pratap <ravi@ximian.com>
17396 * tree.cs (RecordNamespace): Fix up to check for the correct key.
17398 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
17399 local_variable_type to extract the string corresponding to the type.
17401 (local_variable_type): Fixup the action to use the new helper method.
17403 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
17406 * expression.cs : Clean out code which uses the above.
17408 2001-10-31 Ravi Pratap <ravi@ximian.com>
17410 * typemanager.cs (RegisterMethod): Check if we already have an existing key
17411 and bale out if necessary by returning a false.
17413 (RegisterProperty): Ditto.
17415 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
17416 and print out appropriate error messages.
17418 * interface.cs (everywhere): Ditto.
17420 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
17421 location to constructor.
17423 * class.cs (Property, Event, Indexer): Update accordingly.
17425 * ../errors/cs111.cs : Added.
17427 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
17428 of a method, as laid down by the spec.
17430 (Invocation::OverloadResolve): Use the above method.
17432 2001-10-31 Ravi Pratap <ravi@ximian.com>
17434 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
17435 now take a TypeContainer and a Parameters object.
17437 (ParameterData): Modify return type of ParameterModifier method to be
17438 Parameter.Modifier and not a string.
17440 (ReflectionParameters, InternalParameters): Update accordingly.
17442 * expression.cs (Argument::GetParameterModifier): Same here.
17444 * support.cs (InternalParameters::ParameterType): Find a better way of determining
17445 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
17446 symbol in it at all so maybe this is only for now.
17448 2001-10-30 Ravi Pratap <ravi@ximian.com>
17450 * support.cs (InternalParameters): Constructor now takes an extra argument
17451 which is the actual Parameters class.
17453 (ParameterDesc): Update to provide info on ref/out modifiers.
17455 * class.cs (everywhere): Update call to InternalParameters to pass in
17456 the second argument too.
17458 * support.cs (ParameterData): Add ParameterModifier, which is a method
17459 to return the modifier info [ref/out etc]
17461 (InternalParameters, ReflectionParameters): Implement the above.
17463 * expression.cs (Argument::ParameterModifier): Similar function to return
17464 info about the argument's modifiers.
17466 (Invocation::OverloadResolve): Update to take into account matching modifiers
17469 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
17470 a new SetFormalParameters object which we pass to InternalParameters.
17472 2001-10-30 Ravi Pratap <ravi@ximian.com>
17474 * expression.cs (NewArray): Merge into the ArrayCreation class.
17476 2001-10-29 Ravi Pratap <ravi@ximian.com>
17478 * expression.cs (NewArray): Merge classes NewBuiltinArray and
17479 NewUserdefinedArray into one as there wasn't much of a use in having
17482 * expression.cs (Argument): Change field's name to ArgType from Type.
17484 (Type): New readonly property which returns the proper type, taking into
17485 account ref/out modifiers.
17487 (everywhere): Adjust code accordingly for the above.
17489 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
17490 whether we are emitting for a ref or out parameter.
17492 * expression.cs (Argument::Emit): Use the above field to set the state.
17494 (LocalVariableReference::Emit): Update to honour the flag and emit the
17497 * parameter.cs (Attributes): Set the correct flags for ref parameters.
17499 * expression.cs (Argument::FullDesc): New function to provide a full desc.
17501 * support.cs (ParameterData): Add method ParameterDesc to the interface.
17503 (ReflectionParameters, InternalParameters): Implement the above method.
17505 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
17508 (Invocation::FullMethodDesc): Ditto.
17510 2001-10-29 Miguel de Icaza <miguel@ximian.com>
17512 * cs-parser.jay: Add extra production for the second form of array
17515 * expression.cs (ArrayCreation): Update to reflect the above
17518 * Small changes to prepare for Array initialization.
17520 2001-10-28 Miguel de Icaza <miguel@ximian.com>
17522 * typemanager.cs (ImplementsInterface): interface might be null;
17523 Deal with this problem;
17525 Also, we do store negative hits on the cache (null values), so use
17526 this instead of calling t.GetInterfaces on the type everytime.
17528 2001-10-28 Ravi Pratap <ravi@ximian.com>
17530 * typemanager.cs (IsBuiltinType): New method to help determine the same.
17532 * expression.cs (New::DoResolve): Get rid of array creation code and instead
17533 split functionality out into different classes.
17535 (New::FormArrayType): Move into NewBuiltinArray.
17537 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
17540 (NewBuiltinArray): New class to handle creation of built-in arrays.
17542 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
17543 account creation of one-dimensional arrays.
17545 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
17547 (NewUserdefinedArray::DoResolve): Implement.
17549 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
17551 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
17552 we maintain inside the TypeManager. This is necessary to perform lookups on the
17555 (LookupType): Update to perform GetType on the module builders too.
17557 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
17559 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
17561 2001-10-23 Ravi Pratap <ravi@ximian.com>
17563 * expression.cs (New::DoResolve): Implement guts of array creation.
17565 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
17567 2001-10-27 Miguel de Icaza <miguel@ximian.com>
17569 * expression.cs: Fix bug I introduced lsat night that broke
17572 (Expression.Resolve): Report a 246 error (can not resolve name)
17573 if we find a SimpleName in the stream.
17575 (Expression.ResolveLValue): Ditto.
17577 (Expression.ResolveWithSimpleName): This function is a variant of
17578 ResolveName, this one allows SimpleNames to be returned without a
17579 warning. The only consumer of SimpleNames is MemberAccess
17581 2001-10-26 Miguel de Icaza <miguel@ximian.com>
17583 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
17584 might arrive here. I have my doubts that this is correct.
17586 * statement.cs (Lock): Implement lock statement.
17588 * cs-parser.jay: Small fixes to support `lock' and `using'
17590 * cs-tokenizer.cs: Remove extra space
17592 * driver.cs: New flag --checked, allows to turn on integer math
17595 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
17596 Threading.Monitor.Exit
17598 2001-10-23 Miguel de Icaza <miguel@ximian.com>
17600 * expression.cs (IndexerAccess::DoResolveLValue): Set the
17601 Expression Class to be IndexerAccess.
17603 Notice that Indexer::DoResolve sets the eclass to Value.
17605 2001-10-22 Miguel de Icaza <miguel@ximian.com>
17607 * class.cs (TypeContainer::Emit): Emit code for indexers.
17609 * assign.cs (IAssignMethod): New interface implemented by Indexers
17610 and Properties for handling assignment.
17612 (Assign::Emit): Simplify and reuse code.
17614 * expression.cs (IndexerAccess, PropertyExpr): Implement
17615 IAssignMethod, clean up old code.
17617 2001-10-22 Ravi Pratap <ravi@ximian.com>
17619 * typemanager.cs (ImplementsInterface): New method to determine if a type
17620 implements a given interface. Provides a nice cache too.
17622 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
17625 (ConvertReferenceExplicit): Ditto.
17627 * delegate.cs (Delegate::Populate): Update to define the parameters on the
17628 various methods, with correct names etc.
17630 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
17631 Operator.UnaryNegation.
17633 * cs-parser.jay (operator_declarator): Be a little clever in the case where
17634 we have a unary plus or minus operator.
17636 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
17639 * everywhere : update accordingly.
17641 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
17644 * class.cs (Method::Define): For the case where we are implementing a method
17645 inherited from an interface, we need to set the MethodAttributes.Final flag too.
17646 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
17648 2001-10-21 Ravi Pratap <ravi@ximian.com>
17650 * interface.cs (FindMembers): Implement to work around S.R.E
17653 * typemanager.cs (IsInterfaceType): Implement.
17655 (FindMembers): Update to handle interface types too.
17657 * expression.cs (ImplicitReferenceConversion): Re-write bits which
17658 use IsAssignableFrom as that is not correct - it doesn't work.
17660 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
17661 and accordingly override EmitStatement.
17663 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
17664 using the correct logic :-)
17666 2001-10-19 Ravi Pratap <ravi@ximian.com>
17668 * ../errors/cs-11.cs : Add to demonstrate error -11
17670 2001-10-17 Miguel de Icaza <miguel@ximian.com>
17672 * assign.cs (Assign::Resolve): Resolve right hand side first, and
17673 then pass this as a hint to ResolveLValue.
17675 * expression.cs (FieldExpr): Add Location information
17677 (FieldExpr::LValueResolve): Report assignment to readonly
17680 (Expression::ExprClassFromMemberInfo): Pass location information.
17682 (Expression::ResolveLValue): Add new method that resolves an
17685 (Expression::DoResolveLValue): Default invocation calls
17688 (Indexers): New class used to keep track of indexers in a given
17691 (IStackStore): Renamed from LValue, as it did not really describe
17692 what this did. Also ResolveLValue is gone from this interface and
17693 now is part of Expression.
17695 (ElementAccess): Depending on the element access type
17697 * typemanager.cs: Add `indexer_name_type' as a Core type
17698 (System.Runtime.CompilerServices.IndexerNameAttribute)
17700 * statement.cs (Goto): Take a location.
17702 2001-10-18 Ravi Pratap <ravi@ximian.com>
17704 * delegate.cs (Delegate::VerifyDelegate): New method to verify
17705 if two delegates are compatible.
17707 (NewDelegate::DoResolve): Update to take care of the case when
17708 we instantiate a delegate from another delegate.
17710 * typemanager.cs (FindMembers): Don't even try to look up members
17711 of Delegate types for now.
17713 2001-10-18 Ravi Pratap <ravi@ximian.com>
17715 * delegate.cs (NewDelegate): New class to take care of delegate
17718 * expression.cs (New): Split the delegate related code out into
17719 the NewDelegate class.
17721 * delegate.cs (DelegateInvocation): New class to handle delegate
17724 * expression.cs (Invocation): Split out delegate related code into
17725 the DelegateInvocation class.
17727 2001-10-17 Ravi Pratap <ravi@ximian.com>
17729 * expression.cs (New::DoResolve): Implement delegate creation fully
17730 and according to the spec.
17732 (New::DoEmit): Update to handle delegates differently.
17734 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
17735 because of which we were printing out arguments in reverse order !
17737 * delegate.cs (VerifyMethod): Implement to check if the given method
17738 matches the delegate.
17740 (FullDelegateDesc): Implement.
17742 (VerifyApplicability): Implement.
17744 * expression.cs (Invocation::DoResolve): Update to accordingly handle
17745 delegate invocations too.
17747 (Invocation::Emit): Ditto.
17749 * ../errors/cs1593.cs : Added.
17751 * ../errors/cs1594.cs : Added.
17753 * delegate.cs (InstanceExpression, TargetMethod): New properties.
17755 2001-10-16 Ravi Pratap <ravi@ximian.com>
17757 * typemanager.cs (intptr_type): Core type for System.IntPtr
17759 (InitCoreTypes): Update for the same.
17761 (iasyncresult_type, asynccallback_type): Ditto.
17763 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
17766 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
17769 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
17770 the builders for the 4 members of a delegate type :-)
17772 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
17775 * expression.cs (New::DoResolve): Implement guts for delegate creation.
17777 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
17779 2001-10-15 Miguel de Icaza <miguel@ximian.com>
17781 * statement.cs (Break::Emit): Implement.
17782 (Continue::Emit): Implement.
17784 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
17785 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
17786 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
17787 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
17790 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
17791 properties that track the label for the current loop (begin of the
17792 loop and end of the loop).
17794 2001-10-15 Ravi Pratap <ravi@ximian.com>
17796 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
17797 use of emitting anything at all.
17799 * class.cs, rootcontext.cs : Get rid of calls to the same.
17801 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
17803 (Populate): Define the constructor correctly and set the implementation
17806 * typemanager.cs (delegate_types): New hashtable to hold delegates that
17809 (AddDelegateType): Implement.
17811 (IsDelegateType): Implement helper method.
17813 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
17815 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
17816 and accordingly handle it.
17818 * delegate.cs (Populate): Take TypeContainer argument.
17819 Implement bits to define the Invoke method. However, I still haven't figured out
17820 how to take care of the native int bit :-(
17822 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
17823 Qualify the name of the delegate, not its return type !
17825 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
17828 (StandardConversionExists): Checking for array types turns out to be recursive.
17830 (ConvertReferenceExplicit): Implement array conversion.
17832 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
17834 2001-10-12 Ravi Pratap <ravi@ximian.com>
17836 * cs-parser.jay (delegate_declaration): Store the fully qualified
17837 name as it is a type declaration.
17839 * delegate.cs (ReturnType, Name): Rename members to these. Make them
17842 (DefineDelegate): Renamed from Define. Does the same thing essentially,
17843 as TypeContainer::DefineType.
17845 (Populate): Method in which all the definition of the various methods (Invoke)
17848 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
17851 (CloseDelegate): Finally creates the delegate.
17853 * class.cs (TypeContainer::DefineType): Update to define delegates.
17854 (Populate, Emit and CloseType): Do the same thing here too.
17856 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
17857 delegates in all these operations.
17859 2001-10-14 Miguel de Icaza <miguel@ximian.com>
17861 * expression.cs: LocalTemporary: a new expression used to
17862 reference a temporary that has been created.
17864 * assign.cs: Handle PropertyAccess back here, so that we can
17865 provide the proper semantic access to properties.
17867 * expression.cs (Expression::ConvertReferenceExplicit): Implement
17868 a few more explicit conversions.
17870 * modifiers.cs: `NEW' modifier maps to HideBySig.
17872 * expression.cs (PropertyExpr): Make this into an
17873 ExpressionStatement, and support the EmitStatement code path.
17875 Perform get/set error checking, clean up the interface.
17877 * assign.cs: recognize PropertyExprs as targets, and if so, turn
17878 them into toplevel access objects.
17880 2001-10-12 Miguel de Icaza <miguel@ximian.com>
17882 * expression.cs: PropertyExpr::PropertyExpr: use work around the
17885 * typemanager.cs: Keep track here of our PropertyBuilders again to
17886 work around lameness in SRE.
17888 2001-10-11 Miguel de Icaza <miguel@ximian.com>
17890 * expression.cs (LValue::LValueResolve): New method in the
17891 interface, used to perform a second resolution pass for LValues.
17893 (This::DoResolve): Catch the use of this in static methods.
17895 (This::LValueResolve): Implement.
17897 (This::Store): Remove warning, assigning to `this' in structures
17900 (Invocation::Emit): Deal with invocation of
17901 methods on value types. We need to pass the address to structure
17902 methods rather than the object itself. (The equivalent code to
17903 emit "this" for structures leaves the entire structure on the
17904 stack instead of a pointer to it).
17906 (ParameterReference::DoResolve): Compute the real index for the
17907 argument based on whether the method takes or not a `this' pointer
17908 (ie, the method is static).
17910 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
17911 value types returned from functions when we need to invoke a
17912 method on the sturcture.
17915 2001-10-11 Ravi Pratap <ravi@ximian.com>
17917 * class.cs (TypeContainer::DefineType): Method to actually do the business of
17918 defining the type in the Modulebuilder or Typebuilder. This is to take
17919 care of nested types which need to be defined on the TypeBuilder using
17920 DefineNestedMethod.
17922 (TypeContainer::GetClassBases): Implement. Essentially the code from the
17923 methods in RootContext, only ported to be part of TypeContainer.
17925 (TypeContainer::GetInterfaceOrClass): Ditto.
17927 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
17929 * interface.cs (Interface::DefineInterface): New method. Does exactly
17930 what RootContext.CreateInterface did earlier, only it takes care of nested types
17933 (Interface::GetInterfaces): Move from RootContext here and port.
17935 (Interface::GetInterfaceByName): Same here.
17937 * rootcontext.cs (ResolveTree): Re-write.
17939 (PopulateTypes): Re-write.
17941 * class.cs (TypeContainer::Populate): Populate nested types too.
17942 (TypeContainer::Emit): Emit nested members too.
17944 * typemanager.cs (AddUserType): Do not make use of the FullName property,
17945 instead just use the name argument passed in as it is already fully
17948 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
17949 to TypeContainer mapping to see if a type is user-defined.
17951 * class.cs (TypeContainer::CloseType): Implement.
17953 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
17954 the default constructor.
17956 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
17959 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
17961 * interface.cs (CloseType): Create the type here.
17963 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
17966 Remove all the methods which are now in TypeContainer.
17968 2001-10-10 Ravi Pratap <ravi@ximian.com>
17970 * delegate.cs (Define): Re-write bits to define the delegate
17973 2001-10-10 Miguel de Icaza <miguel@ximian.com>
17975 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
17977 * expression.cs (ImplicitReferenceConversion): handle null as well
17978 as a source to convert to any reference type.
17980 * statement.cs (Return): Perform any implicit conversions to
17981 expected return type.
17983 Validate use of return statement.
17985 * codegen.cs (EmitContext): Pass the expected return type here.
17987 * class.cs (Method, Constructor, Property): Pass expected return
17988 type to EmitContext.
17990 2001-10-09 Miguel de Icaza <miguel@ximian.com>
17992 * expression.cs: Make DoResolve take an EmitContext instead of a
17995 Replaced `l' and `location' for `loc', for consistency.
17997 (Error, Warning): Remove unneeded Tc argument.
17999 * assign.cs, literal.cs, constant.cs: Update to new calling
18002 * codegen.cs: EmitContext now contains a flag indicating whether
18003 code is being generated in a static method or not.
18005 * cs-parser.jay: DecomposeQI, new function that replaces the old
18006 QualifiedIdentifier. Now we always decompose the assembled
18007 strings from qualified_identifier productions into a group of
18010 2001-10-08 Miguel de Icaza <miguel@ximian.com>
18012 * rootcontext.cs: Deal with field-less struct types correctly now
18013 by passing the size option to Define Type.
18015 * class.cs: Removed hack that created one static field.
18017 2001-10-07 Miguel de Icaza <miguel@ximian.com>
18019 * statement.cs: Moved most of the code generation here.
18021 2001-10-09 Ravi Pratap <ravi@ximian.com>
18023 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
18026 (ElementAccess): Remove useless bits for now - keep checks as the spec
18029 2001-10-08 Ravi Pratap <ravi@ximian.com>
18031 * expression.cs (ElementAccess::DoResolve): Remove my crap code
18032 and start performing checks according to the spec.
18034 2001-10-07 Ravi Pratap <ravi@ximian.com>
18036 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
18037 rank_specifiers instead.
18039 (rank_specifiers): Change the order in which the rank specifiers are stored
18041 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
18043 * expression.cs (ElementAccess): Implement the LValue interface too.
18045 2001-10-06 Ravi Pratap <ravi@ximian.com>
18047 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
18048 except that user defined conversions are not included.
18050 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
18051 perform the conversion of the return type, if necessary.
18053 (New::DoResolve): Check whether we are creating an array or an object
18054 and accordingly do the needful.
18056 (New::Emit): Same here.
18058 (New::DoResolve): Implement guts of array creation.
18060 (New::FormLookupType): Helper function.
18062 2001-10-07 Miguel de Icaza <miguel@ximian.com>
18064 * codegen.cs: Removed most of the code generation here, and move the
18065 corresponding code generation bits to the statement classes.
18067 Added support for try/catch/finalize and throw.
18069 * cs-parser.jay: Added support for try/catch/finalize.
18071 * class.cs: Catch static methods having the flags override,
18072 virtual or abstract.
18074 * expression.cs (UserCast): This user cast was not really doing
18075 what it was supposed to do. Which is to be born in fully resolved
18076 state. Parts of the resolution were being performed at Emit time!
18080 2001-10-05 Miguel de Icaza <miguel@ximian.com>
18082 * expression.cs: Implicity convert the result from UserCast.
18084 2001-10-05 Ravi Pratap <ravi@ximian.com>
18086 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
18087 prevented it from working correctly.
18089 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
18090 merely ConvertImplicit.
18092 2001-10-05 Miguel de Icaza <miguel@ximian.com>
18094 * typemanager.cs: Make the LookupTypeContainer function static,
18095 and not per-instance.
18097 * class.cs: Make static FindMembers (the one that takes a Type
18100 * codegen.cs: Add EmitForeach here.
18102 * cs-parser.jay: Make foreach a toplevel object instead of the
18103 inline expansion, as we need to perform semantic analysis on it.
18105 2001-10-05 Ravi Pratap <ravi@ximian.com>
18107 * expression.cs (Expression::ImplicitUserConversion): Rename to
18108 UserDefinedConversion.
18110 (Expression::UserDefinedConversion): Take an extra argument specifying
18111 whether we look for explicit user conversions too.
18113 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
18115 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
18117 (ExplicitUserConversion): Make it a call to UserDefinedConversion
18118 with the appropriate arguments.
18120 * cs-parser.jay (cast_expression): Record location too.
18122 * expression.cs (Cast): Record location info.
18124 (Expression::ConvertExplicit): Take location argument.
18126 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
18127 to determine if we are doing explicit conversions.
18129 (UserCast::Emit): Update accordingly.
18131 (Expression::ConvertExplicit): Report an error if everything fails.
18133 * ../errors/cs0030.cs : Add.
18135 2001-10-04 Miguel de Icaza <miguel@ximian.com>
18137 * modifiers.cs: If the ABSTRACT keyword is present, also set the
18138 virtual and newslot bits.
18140 * class.cs (TypeContainer::RegisterRequiredImplementations):
18141 Record methods we need.
18143 (TypeContainer::MakeKey): Helper function to make keys for
18144 MethodBases, since the Methodbase key is useless.
18146 (TypeContainer::Populate): Call RegisterRequiredImplementations
18147 before defining the methods.
18149 Create a mapping for method_builders_to_methods ahead of time
18150 instead of inside a tight loop.
18152 (::RequireMethods): Accept an object as the data to set into the
18153 hashtable so we can report interface vs abstract method mismatch.
18155 2001-10-03 Miguel de Icaza <miguel@ximian.com>
18157 * report.cs: Make all of it static.
18159 * rootcontext.cs: Drop object_type and value_type computations, as
18160 we have those in the TypeManager anyways.
18162 Drop report instance variable too, now it is a global.
18164 * driver.cs: Use try/catch on command line handling.
18166 Add --probe option to debug the error reporting system with a test
18169 * report.cs: Add support for exiting program when a probe
18170 condition is reached.
18172 2001-10-03 Ravi Pratap <ravi@ximian.com>
18174 * expression.cs (Binary::DoNumericPromotions): Fix the case when
18175 we do a forcible conversion regardless of type, to check if
18176 ForceConversion returns a null.
18178 (Binary::error19): Use location to report error.
18180 (Unary::error23): Use location here too.
18182 * ../errors/cs0019.cs : Check in.
18184 * ../errors/cs0023.cs : Check in.
18186 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
18187 case of a non-null MethodInfo object with a length of 0 !
18189 (Binary::ResolveOperator): Flag error if overload resolution fails to find
18190 an applicable member - according to the spec :-)
18191 Also fix logic to find members in base types.
18193 (Unary::ResolveOperator): Same here.
18195 (Unary::report23): Change name to error23 and make first argument a TypeContainer
18196 as I was getting thoroughly confused between this and error19 :-)
18198 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
18199 (::FindMostEncompassedType): Implement.
18200 (::FindMostEncompassingType): Implement.
18201 (::StandardConversionExists): Implement.
18203 (UserImplicitCast): Re-vamp. We now need info about most specific
18204 source and target types so that we can do the necessary conversions.
18206 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
18207 mathematical union with no duplicates.
18209 2001-10-03 Miguel de Icaza <miguel@ximian.com>
18211 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
18212 in order from base classes to child classes, so that we can in
18213 child classes look up in our parent for method names and
18214 attributes (required for handling abstract, virtual, new, override
18215 constructs: we need to instrospect our base class, and if we dont
18216 populate the classes in order, the introspection might be
18217 incorrect. For example, a method could query its parent before
18218 the parent has any methods and would determine that the parent has
18219 no abstract methods (while it could have had them)).
18221 (RootContext::CreateType): Record the order in which we define the
18224 2001-10-02 Miguel de Icaza <miguel@ximian.com>
18226 * class.cs (TypeContainer::Populate): Also method definitions can
18227 fail now, keep track of this.
18229 (TypeContainer::FindMembers): Implement support for
18230 DeclaredOnly/noDeclaredOnly flag.
18232 (Constructor::Emit) Return the ConstructorBuilder.
18234 (Method::Emit) Return the MethodBuilder.
18235 Check for abstract or virtual methods to be public.
18237 * rootcontext.cs (RootContext::CreateType): Register all the
18238 abstract methods required for the class to be complete and the
18239 interface methods that must be implemented.
18241 * cs-parser.jay: Report error 501 (method requires body if it is
18242 not marked abstract or extern).
18244 * expression.cs (TypeOf::Emit): Implement.
18246 * typemanager.cs: runtime_handle_type, new global type.
18248 * class.cs (Property::Emit): Generate code for properties.
18250 2001-10-02 Ravi Pratap <ravi@ximian.com>
18252 * expression.cs (Unary::ResolveOperator): Find operators on base type
18253 too - we now conform exactly to the spec.
18255 (Binary::ResolveOperator): Same here.
18257 * class.cs (Operator::Define): Fix minor quirk in the tests.
18259 * ../errors/cs0215.cs : Added.
18261 * ../errors/cs0556.cs : Added.
18263 * ../errors/cs0555.cs : Added.
18265 2001-10-01 Miguel de Icaza <miguel@ximian.com>
18267 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
18268 single integer which is really efficient
18270 2001-10-01 Ravi Pratap <ravi@ximian.com>
18272 * expression.cs (Expression::ImplicitUserConversion): Use location
18273 even in the case when we are examining True operators.
18275 * class.cs (Operator::Define): Perform extensive checks to conform
18276 with the rules for operator overloading in the spec.
18278 * expression.cs (Expression::ImplicitReferenceConversion): Implement
18279 some of the other conversions mentioned in the spec.
18281 * typemanager.cs (array_type): New static member for the System.Array built-in
18284 (cloneable_interface): For System.ICloneable interface.
18286 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
18287 we start resolving the tree and populating types.
18289 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
18291 2001-10-01 Miguel de Icaza <miguel@ximian.com>
18293 * expression.cs (Expression::ExprClassFromMemberInfo,
18294 Expression::Literalize): Create literal expressions from
18295 FieldInfos which are literals.
18297 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
18298 type casts, because they were wrong. The test suite in tests
18301 (ImplicitNumericConversion): ushort to ulong requires a widening
18304 Int32 constant to long requires widening cast as well.
18306 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
18307 for integers because the type on the stack is not i4.
18309 2001-09-30 Miguel de Icaza <miguel@ximian.com>
18311 * expression.cs (report118): require location argument.
18313 * parameter.cs: Do not dereference potential null value.
18315 * class.cs: Catch methods that lack the `new' keyword when
18316 overriding a name. Report warnings when `new' is used without
18317 anything being there to override.
18319 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
18321 * class.cs: Only add constructor to hashtable if it is non-null
18322 (as now constructors can fail on define).
18324 (TypeManager, Class, Struct): Take location arguments.
18326 Catch field instance initialization in structs as errors.
18328 accepting_filter: a new filter for FindMembers that is static so
18329 that we dont create an instance per invocation.
18331 (Constructor::Define): Catch errors where a struct constructor is
18334 * cs-parser.jay: Pass location information for various new
18337 * delegate.cs (Delegate): take a location argument.
18339 * driver.cs: Do not call EmitCode if there were problesm in the
18340 Definition of the types, as many Builders wont be there.
18342 * decl.cs (Decl::Decl): Require a location argument.
18344 * cs-tokenizer.cs: Handle properly hex constants that can not fit
18345 into integers, and find the most appropiate integer for it.
18347 * literal.cs: Implement ULongLiteral.
18349 * rootcontext.cs: Provide better information about the location of
18350 failure when CreateType fails.
18352 2001-09-29 Miguel de Icaza <miguel@ximian.com>
18354 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
18357 * expression.cs (Binary::CheckShiftArguments): Add missing type
18359 (Binary::ResolveOperator): Add type to the logical and and logical
18360 or, Bitwise And/Or and Exclusive Or code paths, it was missing
18363 (Binary::DoNumericPromotions): In the case where either argument
18364 is ulong (and most signed types combined with ulong cause an
18365 error) perform implicit integer constant conversions as well.
18367 2001-09-28 Miguel de Icaza <miguel@ximian.com>
18369 * expression.cs (UserImplicitCast): Method should always be
18371 (Invocation::BetterConversion): Simplified test for IntLiteral.
18373 (Expression::ImplicitNumericConversion): Split this routine out.
18374 Put the code that performs implicit constant integer conversions
18377 (Expression::Resolve): Become a wrapper around DoResolve so we can
18378 check eclass and type being set after resolve.
18380 (Invocation::Badness): Remove this dead function
18382 (Binary::ResolveOperator): Do not compute the expensive argumnets
18383 unless we have a union for it.
18385 (Probe::Emit): Is needs to do an isinst and then
18386 compare against null.
18388 (::CanConvert): Added Location argument. If the Location argument
18389 is null (Location.Null), then we do not report errors. This is
18390 used by the `probe' mechanism of the Explicit conversion. We do
18391 not want to generate an error for something that the user
18392 explicitly requested to be casted. But the pipeline for an
18393 explicit cast first tests for potential implicit casts.
18395 So for now, if the Location is null, it means `Probe only' to
18396 avoid adding another argument. Might have to revise this
18399 (ClassCast): New class used to type cast objects into arbitrary
18400 classes (used in Explicit Reference Conversions).
18402 Implement `as' as well.
18404 Reverted all the patches from Ravi below: they were broken:
18406 * The use of `level' as a mechanism to stop recursive
18407 invocations is wrong. That was there just to catch the
18408 bug with a strack trace but not as a way of addressing
18411 To fix the problem we have to *understand* what is going
18412 on and the interactions and come up with a plan, not
18413 just get things going.
18415 * The use of the type conversion cache that I proposed
18416 last night had an open topic: How does this work across
18417 protection domains. A user defined conversion might not
18418 be public in the location where we are applying the
18419 conversion, a different conversion might be selected
18420 (ie, private A->B (better) but public B->A (worse),
18421 inside A, A->B applies, but outside it, B->A will
18424 * On top of that (ie, even if the above is solved),
18425 conversions in a cache need to be abstract. Ie, `To
18426 convert from an Int to a Short use an OpcodeCast', not
18427 `To convert from an Int to a Short use the OpcodeCast on
18428 the variable 5' (which is what this patch was doing).
18430 2001-09-28 Ravi Pratap <ravi@ximian.com>
18432 * expression.cs (Invocation::ConversionExists): Re-write to use
18433 the conversion cache
18435 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
18436 cache all conversions done, not just user-defined ones.
18438 (Invocation::BetterConversion): The real culprit. Use ConversionExists
18439 to determine if a conversion exists instead of acutually trying to
18440 perform the conversion. It's faster too.
18442 (Expression::ConvertExplicit): Modify to use ConversionExists to check
18443 and only then attempt the implicit conversion.
18445 2001-09-28 Ravi Pratap <ravi@ximian.com>
18447 * expression.cs (ConvertImplicit): Use a cache for conversions
18448 already found. Check level of recursion and bail out if necessary.
18450 2001-09-28 Miguel de Icaza <miguel@ximian.com>
18452 * typemanager.cs (string_concat_string_string, string_concat_object_object):
18453 Export standard methods that we expect for string operations.
18455 * statement.cs (Block::UsageWarning): Track usage of variables and
18456 report the errors for not used variables.
18458 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
18461 2001-09-27 Miguel de Icaza <miguel@ximian.com>
18463 * codegen.cs: remove unnneded code
18465 * expression.cs: Removed BuiltinTypeAccess class
18467 Fix the order in which implicit conversions are
18470 The previous fixed dropped support for boxed conversions (adding a
18471 test to the test suite now)
18473 (UserImplicitCast::CanConvert): Remove test for source being null,
18474 that code is broken. We should not feed a null to begin with, if
18475 we do, then we should track the bug where the problem originates
18476 and not try to cover it up here.
18478 Return a resolved expression of type UserImplicitCast on success
18479 rather than true/false. Ravi: this is what I was talking about,
18480 the pattern is to use a static method as a "constructor" for
18483 Also, do not create arguments until the very last minute,
18484 otherwise we always create the arguments even for lookups that
18485 will never be performed.
18487 (UserImplicitCast::Resolve): Eliminate, objects of type
18488 UserImplicitCast are born in a fully resolved state.
18490 * typemanager.cs (InitCoreTypes): Init also value_type
18491 (System.ValueType).
18493 * expression.cs (Cast::Resolve): First resolve the child expression.
18495 (LValue): Add new method AddressOf to be used by
18498 Change the argument of Store to take an EmitContext instead of an
18499 ILGenerator, because things like FieldExpr need to be able to call
18500 their children expression to generate the instance code.
18502 (Expression::Error, Expression::Warning): Sugar functions for
18505 (Expression::MemberLookup): Accept a TypeContainer instead of a
18506 Report as the first argument.
18508 (Expression::ResolvePrimary): Killed. I still want to improve
18509 this as currently the code is just not right.
18511 (Expression::ResolveMemberAccess): Simplify, but it is still
18514 (Unary::Resolve): Catch errors in AddressOf operators.
18516 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
18517 index to a byte for the short-version, or the compiler will choose
18518 the wrong Emit call, which generates the wrong data.
18520 (ParameterReference::Emit, ::Store): same.
18522 (FieldExpr::AddressOf): Implement.
18524 * typemanager.cs: TypeManager: made public variable instead of
18527 * driver.cs: document --fatal.
18529 * report.cs (ErrorMessage, WarningMessage): new names for the old
18530 Error and Warning classes.
18532 * cs-parser.jay (member_access): Turn built-in access to types
18533 into a normal simplename
18535 2001-09-27 Ravi Pratap <ravi@ximian.com>
18537 * expression.cs (Invocation::BetterConversion): Fix to cope
18538 with q being null, since this was introducing a bug.
18540 * expression.cs (ConvertImplicit): Do built-in conversions first.
18542 2001-09-27 Ravi Pratap <ravi@ximian.com>
18544 * expression.cs (UserImplicitCast::Resolve): Fix bug.
18546 2001-09-27 Ravi Pratap <ravi@ximian.com>
18548 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
18549 I had introduced long ago (what's new ?).
18551 * expression.cs (UserImplicitCast::CanConvert): Static method to do
18552 the work of all the checking.
18553 (ConvertImplicit): Call CanConvert and only then create object if necessary.
18554 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
18556 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
18557 that is the right way.
18559 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
18560 overloading resolution. Use everywhere instead of cutting and pasting code.
18562 (Binary::ResolveOperator): Use MakeUnionSet.
18564 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
18565 we have to convert to bool types. Not complete yet.
18567 2001-09-27 Miguel de Icaza <miguel@ximian.com>
18569 * typemanager.cs (TypeManager::CSharpName): support ushort.
18571 * expression.cs (Expression::TryImplicitIntConversion): Attempts
18572 to provide an expression that performsn an implicit constant int
18573 conversion (section 6.1.6).
18574 (Expression::ConvertImplicitRequired): Reworked to include
18575 implicit constant expression conversions.
18577 (Expression::ConvertNumericExplicit): Finished.
18579 (Invocation::Emit): If InstanceExpression is null, then it means
18580 that we perform a call on this.
18582 2001-09-26 Miguel de Icaza <miguel@ximian.com>
18584 * expression.cs (Unary::Emit): Remove some dead code.
18585 (Probe): Implement Resolve and Emit for `is'.
18586 (Expression::ConvertImplicitRequired): Attempt to do constant
18587 expression conversions here. Maybe should be moved to
18588 ConvertImplicit, but I am not sure.
18589 (Expression::ImplicitLongConstantConversionPossible,
18590 Expression::ImplicitIntConstantConversionPossible): New functions
18591 that tell whether is it possible to apply an implicit constant
18592 expression conversion.
18594 (ConvertNumericExplicit): Started work on explicit numeric
18597 * cs-parser.jay: Update operator constants.
18599 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
18600 (Parameters::GetSignature): Hook up VerifyArgs here.
18601 (Parameters::VerifyArgs): Verifies that no two arguments have the
18604 * class.cs (Operator): Update the operator names to reflect the
18605 ones that the spec expects (as we are just stringizing the
18608 * expression.cs (Unary::ResolveOperator): Fix bug: Use
18609 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
18610 previous usage did only work for our methods.
18611 (Expression::ConvertImplicit): Handle decimal implicit numeric
18612 conversions as well.
18613 (Expression::InternalTypeConstructor): Used to invoke constructors
18614 on internal types for default promotions.
18616 (Unary::Emit): Implement special handling for the pre/post
18617 increment/decrement for overloaded operators, as they need to have
18618 the same semantics as the other operators.
18620 (Binary::ResolveOperator): ditto.
18621 (Invocation::ConversionExists): ditto.
18622 (UserImplicitCast::Resolve): ditto.
18624 2001-09-26 Ravi Pratap <ravi@ximian.com>
18626 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
18627 operator, return after emitting body. Regression tests pass again !
18629 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
18630 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
18631 (Invocation::OverloadResolve): Ditto.
18632 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
18634 * everywhere : update calls to the above methods accordingly.
18636 2001-09-26 Miguel de Icaza <miguel@ximian.com>
18638 * assign.cs (Assign): Make it inherit from ExpressionStatement.
18640 * expression.cs (ExpressionStatement): New base class used for
18641 expressions that can appear in statements, so that we can provide
18642 an alternate path to generate expression that do not leave a value
18645 (Expression::Emit, and all the derivatives): We no longer return
18646 whether a value is left on the stack or not. Every expression
18647 after being emitted leaves a single value on the stack.
18649 * codegen.cs (EmitContext::EmitStatementExpression): Use the
18650 facilties of ExpressionStatement if possible.
18652 * cs-parser.jay: Update statement_expression.
18654 2001-09-25 Miguel de Icaza <miguel@ximian.com>
18656 * driver.cs: Change the wording of message
18658 2001-09-25 Ravi Pratap <ravi@ximian.com>
18660 * expression.cs (Binary::ResolveOperator): Had forgottten to set
18661 the type of the expression to the return type of the method if
18662 we have an overloaded operator match ! The regression tests pass again !
18663 (Unary::ResolveOperator): Ditto.
18665 * expression.cs (Invocation::ConversionExists): Correct the member lookup
18666 to find "op_Implicit", not "implicit" ;-)
18667 (UserImplicitCast): New class to take care of user-defined implicit conversions.
18668 (ConvertImplicit, ForceConversion): Take TypeContainer argument
18670 * everywhere : Correct calls to the above accordingly.
18672 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
18673 (ConvertImplicit): Do user-defined conversion if it exists.
18675 2001-09-24 Miguel de Icaza <miguel@ximian.com>
18677 * assign.cs: track location.
18678 (Resolve): Use implicit conversions on assignment.
18680 * literal.cs: Oops. Not good, Emit of short access values should
18681 pass (Bytes) or the wrong argument will be selected.
18683 * expression.cs (Unary::Emit): Emit code for -expr.
18685 (Unary::ResolveOperator): Handle `Substract' for non-constants
18686 (substract from zero from the non-constants).
18687 Deal with Doubles as well.
18689 (Expression::ConvertImplicitRequired): New routine that reports an
18690 error if no implicit conversion exists.
18692 (Invocation::OverloadResolve): Store the converted implicit
18693 expressions if we make them
18695 2001-09-24 Ravi Pratap <ravi@ximian.com>
18697 * class.cs (ConstructorInitializer): Take a Location argument.
18698 (ConstructorBaseInitializer): Same here.
18699 (ConstructorThisInitializer): Same here.
18701 * cs-parser.jay : Update all calls accordingly.
18703 * expression.cs (Unary, Binary, New): Take location argument.
18704 Update accordingly everywhere.
18706 * cs-parser.jay : Update all calls to the above to take a location
18709 * class.cs : Ditto.
18711 2001-09-24 Ravi Pratap <ravi@ximian.com>
18713 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
18714 (Invocation::BetterConversion): Same here
18715 (Invocation::ConversionExists): Ditto.
18717 (Invocation::ConversionExists): Implement.
18719 2001-09-22 Ravi Pratap <ravi@ximian.com>
18721 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
18722 Also take an additional TypeContainer argument.
18724 * All over : Pass in TypeContainer as argument to OverloadResolve.
18726 * typemanager.cs (CSharpName): Update to check for the string type and return
18729 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
18732 2001-09-21 Ravi Pratap <ravi@ximian.com>
18734 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
18735 (Invocation::BetterFunction): Implement.
18736 (Invocation::BetterConversion): Implement.
18737 (Invocation::ConversionExists): Skeleton, no implementation yet.
18739 Okay, things work fine !
18741 2001-09-21 Miguel de Icaza <miguel@ximian.com>
18743 * typemanager.cs: declare and load enum_type, delegate_type and
18746 * expression.cs (Expression::Emit): Now emit returns a value that
18747 tells whether a value is left on the stack or not. This strategy
18748 might be reveted tomorrow with a mechanism that would address
18749 multiple assignments.
18750 (Expression::report118): Utility routine to report mismatches on
18753 (Unary::Report23): Report impossible type/operator combination
18756 (Unary::IsIncrementableNumber): Whether the type can be
18757 incremented or decremented with add.
18758 (Unary::ResolveOperator): Also allow enumerations to be bitwise
18760 (Unary::ResolveOperator): Implement ++, !, ~,
18762 (Invocation::Emit): Deal with new Emit convetion.
18764 * All Expression derivatives: Updated their Emit method to return
18765 whether they leave values on the stack or not.
18767 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
18768 stack for expressions that are statements.
18770 2001-09-20 Miguel de Icaza <miguel@ximian.com>
18772 * expression.cs (LValue): New interface. Must be implemented by
18774 (LocalVariableReference, ParameterReference, FieldExpr): Implement
18777 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
18778 interface for generating code, simplifies the code.
18780 2001-09-20 Ravi Pratap <ravi@ximian.com>
18782 * expression.cs (everywhere): Comment out return statements in ::Resolve
18783 methods to avoid the warnings.
18785 2001-09-20 Miguel de Icaza <miguel@ximian.com>
18787 * driver.cs (parse): Report error 2001 if we can not open the
18790 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
18793 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
18796 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
18797 otherwise nested blocks end up with the same index.
18799 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
18801 * expression.cs: Instead of having FIXMEs in the Resolve
18802 functions, throw exceptions so it is obvious that we are facing a
18805 * cs-parser.jay (invocation_expression): Pass Location information.
18807 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
18808 Use a basename for those routines because .NET does not like paths
18811 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
18814 2001-09-19 Miguel de Icaza <miguel@ximian.com>
18816 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
18817 are loading the correct data types (throws an exception if not).
18818 (TypeManager::InitCoreTypes): Use CoreLookupType
18820 * expression.cs (Unary::ResolveOperator): return the child
18821 expression for expressions which are just +expr.
18822 (Unary::ResolveOperator): Return negative literals for -LITERAL
18823 expressions (otherwise they are Unary {Literal}).
18824 (Invocation::Badness): Take into account `Implicit constant
18825 expression conversions'.
18827 * literal.cs (LongLiteral): Implement long literal class.
18828 (IntLiteral): export the `Value' of the intliteral.
18830 2001-09-19 Ravi Pratap <ravi@ximian.com>
18832 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
18834 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
18835 instead of 'Operator'
18837 * expression.cs (Binary::ResolveOperator): Update accordingly.
18838 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
18841 * cs-parser.jay (unary_expression): Update to use the new names.
18843 * gen-treedump.cs (GetUnary): Same here.
18845 * expression.cs (Unary::Resolve): Implement.
18846 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
18847 operators are found instead of making noise ;-)
18848 (Unary::ResolveOperator): New method to do precisely the same thing which
18849 Binary::ResolveOperator does for Binary expressions.
18850 (Unary.method, .Arguments): Add.
18851 (Unary::OperName): Implement.
18852 (Unary::ForceConversion): Copy and Paste !
18854 * class.cs (Operator::Define): Fix a small bug for the case when we have
18857 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
18858 for the inbuilt operators. Only overloading works for now ;-)
18860 2001-09-18 Miguel de Icaza <miguel@ximian.com>
18862 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
18863 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
18865 * expression.cs (This::Emit): Implement.
18866 (This::Resolve): Implement.
18867 (TypeOf:Resolve): Implement.
18868 (Expression::ResolveSimpleName): Add an implicit this to instance
18870 (MemberAccess::Resolve): Deal with Parameters and Fields.
18871 Bind instance variable to Field expressions.
18872 (FieldExpr::Instance): New field used to track the expression that
18873 represents the object instance.
18874 (FieldExpr::Resolve): Track potential errors from MemberLookup not
18876 (FieldExpr::Emit): Implement.
18878 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
18879 the last instruction contains a return opcode to avoid generating
18880 the last `ret' instruction (this generates correct code, and it is
18881 nice to pass the peverify output).
18883 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
18884 initializer for static and instance variables.
18885 (Constructor::Emit): Allow initializer to be null in the case of
18886 static constructors. Only emit initializer for instance
18889 (TypeContainer::FindMembers): Return a null array if there are no
18892 Also fix the code for the MemberTypes.Method branch, as it was not
18893 scanning that for operators (or tried to access null variables before).
18895 * assign.cs (Assign::Emit): Handle instance and static fields.
18899 * driver.cs: Stop compilation if there are parse errors.
18901 * cs-parser.jay (constructor_declaration): Provide default base
18902 initializer for non-static constructors.
18903 (constructor_declarator): Do not provide a default base
18904 initializers if none was specified.
18905 Catch the fact that constructors should not have parameters.
18907 * class.cs: Do not emit parent class initializers for static
18908 constructors, that should be flagged as an error.
18910 2001-09-18 Ravi Pratap <ravi@ximian.com>
18912 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
18913 Move back code into TypeContainer::Populate.
18915 2001-09-18 Ravi Pratap <ravi@ximian.com>
18917 * class.cs (TypeContainer::AddConstructor): Fix the check to
18918 compare against Name, not Basename.
18919 (Operator::OpType): Change Plus and Minus to Add and Subtract.
18921 * cs-parser.jay : Update accordingly.
18923 * class.cs (TypeContainer::FindMembers): For the case where we are searching
18924 for methods, don't forget to look into the operators too.
18925 (RegisterMethodBuilder): Helper method to take care of this for
18926 methods, constructors and operators.
18927 (Operator::Define): Completely revamp.
18928 (Operator.OperatorMethod, MethodName): New fields.
18929 (TypeContainer::Populate): Move the registering of builders into
18930 RegisterMethodBuilder.
18931 (Operator::Emit): Re-write.
18933 * expression.cs (Binary::Emit): Comment out code path to emit method
18934 invocation stuff for the case when we have a user defined operator. I am
18935 just not able to get it right !
18937 2001-09-17 Miguel de Icaza <miguel@ximian.com>
18939 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
18942 (Expression::MemberLookup): Provide a version that allows to
18943 specify the MemberTypes and BindingFlags.
18945 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
18946 so it was not fetching variable information from outer blocks.
18948 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
18949 Beforefieldinit as it was buggy.
18951 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
18952 that Ravi put here.
18954 * class.cs (Constructor::Emit): Only emit if block is not null.
18955 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
18956 deal with this by semantically definining it as if the user had
18959 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
18960 constructors as we now "emit" them at a higher level.
18962 (TypeContainer::DefineDefaultConstructor): Used to define the
18963 default constructors if none was provided.
18965 (ConstructorInitializer): Add methods Resolve and Emit.
18967 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
18969 2001-09-17 Ravi Pratap <ravi@ximian.com>
18971 * class.cs (TypeContainer::EmitDefaultConstructor): Register
18972 the default constructor builder with our hashtable for methodbuilders
18975 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
18976 and argument_count is 0 in which case we have a match.
18977 (Binary::ResolveOperator): More null checking and miscellaneous coding
18980 2001-09-17 Ravi Pratap <ravi@ximian.com>
18982 * rootcontext.cs (IsNameSpace): Compare against null.
18984 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
18986 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
18987 and Unary::Operator.
18989 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
18992 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
18993 we have overloaded operators.
18994 (Binary::ResolveOperator): Implement the part which does the operator overload
18997 * class.cs (Operator::Emit): Implement.
18998 (TypeContainer::Emit): Emit the operators we have too.
19000 * expression.cs (Binary::Emit): Update to emit the appropriate code for
19001 the case when we have a user-defined operator.
19003 2001-09-17 Miguel de Icaza <miguel@ximian.com>
19005 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
19007 2001-09-16 Ravi Pratap <ravi@ximian.com>
19009 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
19010 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
19011 (Constructor::Emit): Implement.
19012 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
19013 if we have no work to do.
19014 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
19017 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
19018 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
19020 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
19023 2001-09-15 Ravi Pratap <ravi@ximian.com>
19025 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
19027 (Tree::RecordNamespace): Method to do what the name says ;-)
19028 (Tree::Namespaces): Property to get at the namespaces hashtable.
19030 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
19033 * rootcontext.cs (IsNamespace): Fixed it :-)
19035 2001-09-14 Miguel de Icaza <miguel@ximian.com>
19037 * class.cs (TypeContainer::FindMembers): Add support for
19039 (MethodCore): New class that encapsulates both the shared aspects
19040 of a Constructor and a Method.
19041 (Method, Constructor): Factored pieces into MethodCore.
19043 * driver.cs: Added --fatal which makes errors throw exceptions.
19044 Load System assembly as well as part of the standard library.
19046 * report.cs: Allow throwing exceptions on errors for debugging.
19048 * modifiers.cs: Do not use `parent', instead use the real type
19049 container to evaluate permission settings.
19051 * class.cs: Put Ravi's patch back in. He is right, and we will
19052 have to cope with the
19054 2001-09-14 Ravi Pratap <ravi@ximian.com>
19056 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
19057 FamORAssem, not FamANDAssem.
19059 2001-09-14 Miguel de Icaza <miguel@ximian.com>
19061 * driver.cs: Added --parse option that only parses its input files
19064 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
19065 incorrect. IsTopLevel is not used to tell whether an object is
19066 root_types or not (that can be achieved by testing this ==
19067 root_types). But to see if this is a top-level *class* (not
19068 necessarly our "toplevel" container).
19070 2001-09-14 Ravi Pratap <ravi@ximian.com>
19072 * enum.cs (Enum::Define): Modify to call the Lookup method on the
19073 parent instead of a direct call to GetType.
19075 2001-09-14 Ravi Pratap <ravi@ximian.com>
19077 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
19078 Modifiers.TypeAttr. This should just be a call to that method.
19080 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
19081 object so that we can determine if we are top-level or not.
19083 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
19086 * enum.cs (Enum::Define): Ditto.
19088 * modifiers.cs (FieldAttr): Re-write.
19090 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
19091 (TypeContainer::HaveStaticConstructor): New property to provide access
19092 to precisely that info.
19094 * modifiers.cs (MethodAttr): Re-write.
19095 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
19097 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
19098 of top-level types as claimed.
19100 2001-09-13 Miguel de Icaza <miguel@ximian.com>
19102 * expression.cs (MemberLookup): Fruitless attempt to lookup
19103 constructors. Maybe I need to emit default constructors? That
19104 might be it (currently .NET emits this for me automatically).
19105 (Invocation::OverloadResolve): Cope with Arguments == null.
19106 (Invocation::EmitArguments): new function, shared by the new
19107 constructor and us.
19108 (Invocation::Emit): Handle static and instance methods. Emit
19109 proper call instruction for virtual or non-virtual invocations.
19110 (New::Emit): Implement.
19111 (New::Resolve): Implement.
19112 (MemberAccess:Resolve): Implement.
19113 (MethodGroupExpr::InstanceExpression): used conforming to the spec
19114 to track instances.
19115 (FieldExpr::Resolve): Set type.
19117 * support.cs: Handle empty arguments.
19119 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
19120 SimpleLookup): Auxiliary routines to help parse a qualifier
19123 Update qualifier_identifier rule.
19125 * codegen.cs: Removed debugging messages.
19127 * class.cs: Make this a global thing, this acts just as a "key" to
19128 objects that we might have around.
19130 (Populate): Only initialize method_builders_to_methods once.
19132 * expression.cs (PropertyExpr): Initialize type from the
19135 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
19136 Resolve pattern. Attempt to implicitly convert value to boolean.
19139 * expression.cs: Set the type for the int32/int32 argument case.
19140 (Binary::ResolveOperator): Set the return type to boolean for
19141 comparission operators
19143 * typemanager.cs: Remove debugging print code.
19145 (Invocation::Resolve): resolve type.
19147 * class.cs: Allocate a MemberInfo of the correct size, as the code
19148 elsewhere depends on the test to reflect the correct contents.
19150 (Method::) Keep track of parameters, due to System.Reflection holes
19152 (TypeContainer::Populate): Keep track of MethodBuilders to Method
19155 (TypeContainer::FindMembers): Use ArrayList and then copy an array
19156 of the exact size and return that.
19158 (Class::LookupMethodByBuilder): New function that maps
19159 MethodBuilders to its methods. Required to locate the information
19160 on methods because System.Reflection bit us again.
19162 * support.cs: New file, contains an interface ParameterData and
19163 two implementations: ReflectionParameters and InternalParameters
19164 used to access Parameter information. We will need to grow this
19167 * expression.cs (Invocation::GetParameterData): implement a cache
19168 and a wrapper around the ParameterData creation for methods.
19169 (Invocation::OverloadResolve): Use new code.
19171 2001-09-13 Ravi Pratap <ravi@ximian.com>
19173 * class.cs (TypeContainer::EmitField): Remove and move into
19174 (Field::Define): here and modify accordingly.
19175 (Field.FieldBuilder): New member.
19176 (TypeContainer::Populate): Update accordingly.
19177 (TypeContainer::FindMembers): Implement.
19179 2001-09-13 Miguel de Icaza <miguel@ximian.com>
19181 * statement.cs: (VariableInfo::VariableType): New field to be
19182 initialized with the full type once it is resolved.
19184 2001-09-12 Miguel de Icaza <miguel@ximian.com>
19186 * parameter.cs (GetParameterInfo): Use a type cache to compute
19187 things only once, and to reuse this information
19189 * expression.cs (LocalVariableReference::Emit): Implement.
19190 (OpcodeCast::Emit): fix.
19192 (ParameterReference::Resolve): Implement.
19193 (ParameterReference::Emit): Implement.
19195 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
19196 that are expressions need to stay as Expressions.
19198 * typemanager.cs (CSharpName): Returns the C# name of a type if
19201 * expression.cs (Expression::ConvertImplicit): New function that
19202 implements implicit type conversions.
19204 (Expression::ImplicitReferenceConversion): Implements implicit
19205 reference conversions.
19207 (EmptyCast): New type for transparent casts.
19209 (OpcodeCast): New type for casts of types that are performed with
19210 a sequence of bytecodes.
19212 (BoxedCast): New type used for casting value types into reference
19213 types. Emits a box opcode.
19215 (Binary::DoNumericPromotions): Implements numeric promotions of
19216 and computation of the Binary::Type.
19218 (Binary::EmitBranchable): Optimization.
19220 (Binary::Emit): Implement code emission for expressions.
19222 * typemanager.cs (TypeManager): Added two new core types: sbyte
19225 2001-09-12 Ravi Pratap <ravi@ximian.com>
19227 * class.cs (TypeContainer::FindMembers): Method which does exactly
19228 what Type.FindMembers does, only we don't have to use reflection. No
19229 implementation yet.
19231 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
19232 typecontainer objects as we need to get at them.
19233 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
19235 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
19236 typecontainer object.
19238 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
19239 of just a Report object.
19241 2001-09-11 Ravi Pratap <ravi@ximian.com>
19243 * class.cs (Event::Define): Go back to using the prefixes "add_" and
19245 (TypeContainer::Populate): Now define the delegates of the type too.
19246 (TypeContainer.Delegates): Property to access the list of delegates defined
19249 * delegates.cs (Delegate::Define): Implement partially.
19251 * modifiers.cs (TypeAttr): Handle more flags.
19253 2001-09-11 Ravi Pratap <ravi@ximian.com>
19255 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
19257 (Operator::Define): Re-write logic to get types by using the LookupType method
19258 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
19259 (Indexer::Define): Ditto.
19260 (Event::Define): Ditto.
19261 (Property::Define): Ditto.
19263 2001-09-10 Ravi Pratap <ravi@ximian.com>
19265 * class.cs (TypeContainer::Populate): Now define operators too.
19266 (TypeContainer.Operators): New property to access the list of operators
19268 (Operator.OperatorMethodBuilder): New member to hold the method builder
19269 for the operator we are defining.
19270 (Operator::Define): Implement.
19272 2001-09-10 Ravi Pratap <ravi@ximian.com>
19274 * class.cs (Event::Define): Make the prefixes of the accessor methods
19275 addOn_ and removeOn_
19277 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
19278 of the location being passed in too. Ideally, this should go later since all
19279 error reporting should be done through the Report object.
19281 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
19282 (Populate): Iterate thru the indexers we have and define them too.
19283 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
19284 for the get and set accessors.
19285 (Indexer::Define): Implement.
19287 2001-09-09 Miguel de Icaza <miguel@ximian.com>
19289 * expression.cs (Binary::Resolve): Beginning of it. I scratched
19290 my previous implementation, did not work.
19292 * typemanager.cs: Add a couple of missing types (the longs).
19294 * literal.cs: Use TypeManager.bool_type instead of getting it.
19296 * expression.cs (EventExpr): New kind of expressions.
19297 (Expressio::ExprClassFromMemberInfo): finish
19299 2001-09-08 Miguel de Icaza <miguel@ximian.com>
19301 * assign.cs: Emit stores to static fields differently.
19303 2001-09-08 Ravi Pratap <ravi@ximian.com>
19305 * Merge in changes and adjust code to tackle conflicts. Backed out my
19306 code in Assign::Resolve ;-)
19308 2001-09-08 Ravi Pratap <ravi@ximian.com>
19310 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
19311 instead Report.Error and also pass in the location.
19312 (CSharpParser::Lexer): New readonly property to return the reference
19313 to the Tokenizer object.
19314 (declare_local_variables): Use Report.Error with location instead of plain
19318 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
19319 (Operator.CheckBinaryOperator): Ditto.
19321 * cs-parser.jay (operator_declarator): Update accordingly.
19323 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
19324 (CheckBinaryOperator): Same here.
19326 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
19327 on the name without any prefixes of namespace names etc. This is because we
19328 already might have something already fully qualified like
19329 'System.Console.WriteLine'
19331 * assign.cs (Resolve): Begin implementation. Stuck ;-)
19333 2001-09-07 Ravi Pratap <ravi@ximian.com>
19335 * cs-tokenizer.cs (location): Return a string which also contains
19338 * expression.cs (ElementAccess): New class for expressions of the
19339 type 'element access.'
19340 (BaseAccess): New class for expressions of the type 'base access.'
19341 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
19344 * cs-parser.jay (element_access): Implement action.
19345 (base_access): Implement actions.
19346 (checked_expression, unchecked_expression): Implement.
19348 * cs-parser.jay (local_variable_type): Correct and implement.
19349 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
19351 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
19353 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
19354 name and the specifiers.
19356 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
19358 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
19359 making them all public ;-)
19361 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
19364 2001-09-07 Miguel de Icaza <miguel@ximian.com>
19366 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
19368 (FieldExpr, PropertyExprs): New resolved expressions.
19369 (SimpleName::MemberStaticCheck): Perform static checks for access
19370 to non-static fields on static methods. Maybe this should be
19371 generalized for MemberAccesses.
19372 (SimpleName::ResolveSimpleName): More work on simple name
19375 * cs-parser.jay (primary_expression/qualified_identifier): track
19376 the parameter index.
19378 * codegen.cs (CodeGen::Save): Catch save exception, report error.
19379 (EmitContext::EmitBoolExpression): Chain to expression generation
19380 instead of temporary hack.
19381 (::EmitStatementExpression): Put generic expression code generation.
19383 * assign.cs (Assign::Emit): Implement variable assignments to
19384 local variables, parameters and fields.
19386 2001-09-06 Miguel de Icaza <miguel@ximian.com>
19388 * statement.cs (Block::GetVariableInfo): New method, returns the
19389 VariableInfo for a variable name in a block.
19390 (Block::GetVariableType): Implement in terms of GetVariableInfo
19392 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
19393 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
19395 2001-09-06 Ravi Pratap <ravi@ximian.com>
19397 * cs-parser.jay (operator_declaration): Continue on my quest : update
19398 to take attributes argument.
19399 (event_declaration): Ditto.
19400 (enum_declaration): Ditto.
19401 (indexer_declaration): Ditto.
19403 * class.cs (Operator::Operator): Update constructor accordingly.
19404 (Event::Event): Ditto.
19406 * delegate.cs (Delegate::Delegate): Same here.
19408 * enum.cs (Enum::Enum): Same here.
19410 2001-09-05 Ravi Pratap <ravi@ximian.com>
19412 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
19414 * ../tests/cs0658.cs : New file to demonstrate error 0658.
19416 * attribute.cs (Attributes): New class to encapsulate all attributes which were
19417 being passed around as an arraylist.
19418 (Attributes::AddAttribute): Method to add attribute sections.
19420 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
19421 (struct_declaration): Update accordingly.
19422 (constant_declaration): Update.
19423 (field_declaration): Update.
19424 (method_header): Update.
19425 (fixed_parameter): Update.
19426 (parameter_array): Ditto.
19427 (property_declaration): Ditto.
19428 (destructor_declaration): Ditto.
19430 * class.cs (Struct::Struct): Update constructors accordingly.
19431 (Class::Class): Ditto.
19432 (Field::Field): Ditto.
19433 (Method::Method): Ditto.
19434 (Property::Property): Ditto.
19435 (TypeContainer::OptAttribute): update property's return type.
19437 * interface.cs (Interface.opt_attributes): New member.
19438 (Interface::Interface): Update to take the extra Attributes argument.
19440 * parameter.cs (Parameter::Parameter): Ditto.
19442 * constant.cs (Constant::Constant): Ditto.
19444 * interface.cs (InterfaceMemberBase): New OptAttributes field.
19445 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
19446 the attributes as a parameter.
19447 (InterfaceProperty): Update constructor call.
19448 (InterfaceEvent): Ditto.
19449 (InterfaceMethod): Ditto.
19450 (InterfaceIndexer): Ditto.
19452 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
19453 pass the attributes too.
19454 (interface_event_declaration): Ditto.
19455 (interface_property_declaration): Ditto.
19456 (interface_method_declaration): Ditto.
19457 (interface_declaration): Ditto.
19459 2001-09-05 Miguel de Icaza <miguel@ximian.com>
19461 * class.cs (Method::Define): Track the "static Main" definition to
19462 create an entry point.
19464 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
19465 EntryPoint if we find it.
19467 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
19468 (EmitContext::ig): Make this variable public.
19470 * driver.cs: Make the default output file be the first file name
19471 with the .exe extension.
19473 Detect empty compilations
19475 Handle various kinds of output targets. Handle --target and
19476 rename -t to --dumper.
19478 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
19479 methods inherited from Expression return now an Expression. This
19480 will is used during the tree rewriting as we resolve them during
19483 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
19484 the spec. Missing entirely is the information about
19485 accessability of elements of it.
19487 (Expression::ExprClassFromMemberInfo): New constructor for
19488 Expressions that creates a fully initialized Expression based on
19489 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
19492 (Invocation::Resolve): Begin implementing resolution of invocations.
19494 * literal.cs (StringLiteral): Implement Emit.
19496 2001-09-05 Ravi Pratap <ravi@ximian.com>
19498 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
19501 2001-09-04 Ravi Pratap <ravi@ximian.com>
19503 * cs-parser.jay (attribute_arguments): Implement actions.
19504 (attribute): Fix bug in production. Implement action.
19505 (attribute_list): Implement.
19506 (attribute_target): Implement.
19507 (attribute_target_specifier, opt_target_specifier): Implement
19508 (CheckAttributeTarget): New method to check if the attribute target
19510 (attribute_section): Implement.
19511 (opt_attributes): Implement.
19513 * attribute.cs : New file to handle attributes.
19514 (Attribute): Class to hold attribute info.
19516 * cs-parser.jay (opt_attribute_target_specifier): Remove production
19517 (attribute_section): Modify production to use 2 different rules to
19518 achieve the same thing. 1 s/r conflict down !
19519 Clean out commented, useless, non-reducing dimension_separator rules.
19521 * class.cs (TypeContainer.attributes): New member to hold list
19522 of attributes for a type.
19523 (Struct::Struct): Modify to take one more argument, the attribute list.
19524 (Class::Class): Ditto.
19525 (Field::Field): Ditto.
19526 (Method::Method): Ditto.
19527 (Property::Property): Ditto.
19529 * cs-parser.jay (struct_declaration): Update constructor call to
19530 pass in the attributes too.
19531 (class_declaration): Ditto.
19532 (constant_declaration): Ditto.
19533 (field_declaration): Ditto.
19534 (method_header): Ditto.
19535 (fixed_parameter): Ditto.
19536 (parameter_array): Ditto.
19537 (property_declaration): Ditto.
19539 * constant.cs (Constant::Constant): Update constructor similarly.
19540 Use System.Collections.
19542 * parameter.cs (Parameter::Parameter): Update as above.
19544 2001-09-02 Ravi Pratap <ravi@ximian.com>
19546 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
19547 (TypeContainer.delegates): New member to hold list of delegates.
19549 * cs-parser.jay (delegate_declaration): Implement the action correctly
19550 this time as I seem to be on crack ;-)
19552 2001-09-02 Miguel de Icaza <miguel@ximian.com>
19554 * rootcontext.cs (RootContext::IsNamespace): new function, used to
19555 tell whether an identifier represents a namespace.
19557 * expression.cs (NamespaceExpr): A namespace expression, used only
19558 temporarly during expression resolution.
19559 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
19560 utility functions to resolve names on expressions.
19562 2001-09-01 Miguel de Icaza <miguel@ximian.com>
19564 * codegen.cs: Add hook for StatementExpressions.
19566 * class.cs: Fix inverted test for static flag in methods.
19568 2001-09-02 Ravi Pratap <ravi@ximian.com>
19570 * class.cs (Operator::CheckUnaryOperator): Correct error number used
19571 to make it coincide with MS' number.
19572 (Operator::CheckBinaryOperator): Ditto.
19574 * ../errors/errors.txt : Remove error numbers added earlier.
19576 * ../errors/cs1019.cs : Test case for error # 1019
19578 * ../errros/cs1020.cs : Test case for error # 1020
19580 * cs-parser.jay : Clean out commented cruft.
19581 (dimension_separators, dimension_separator): Comment out. Ostensibly not
19582 used anywhere - non-reducing rule.
19583 (namespace_declarations): Non-reducing rule - comment out.
19585 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
19586 with TypeContainer::AddEnum.
19588 * delegate.cs : New file for delegate handling classes.
19589 (Delegate): Class for declaring delegates.
19591 * makefile : Update.
19593 * cs-parser.jay (delegate_declaration): Implement.
19595 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
19597 * class.cs (Event::Define): Implement.
19598 (Event.EventBuilder): New member.
19600 * class.cs (TypeContainer::Populate): Update to define all enums and events
19602 (Events): New property for the events arraylist we hold. Shouldn't we move to using
19603 readonly fields for all these cases ?
19605 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
19607 * class.cs (Property): Revamp to use the convention of making fields readonly.
19608 Accordingly modify code elsewhere.
19610 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
19611 the Define method of the Property class.
19613 * class.cs : Clean up applied patch and update references to variables etc. Fix
19615 (TypeContainer::Populate): Update to define all the properties we have. Also
19616 define all enumerations.
19618 * enum.cs (Define): Implement.
19620 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
19622 * cs-parser.jay (overloadable_operator): The semantic value is an
19623 enum of the Operator class.
19624 (operator_declarator): Implement actions.
19625 (operator_declaration): Implement.
19627 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
19628 validity of definitions.
19629 (Operator::CheckBinaryOperator): Static method to check for binary operators
19630 (TypeContainer::AddOperator): New method to add an operator to a type.
19632 * cs-parser.jay (indexer_declaration): Added line to actually call the
19633 AddIndexer method so it gets added ;-)
19635 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
19636 already taken care of by the MS compiler ?
19638 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
19640 * class.cs (Operator): New class for operator declarations.
19641 (Operator::OpType): Enum for the various operators.
19643 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
19645 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
19646 ostensibly handle this in semantic analysis.
19648 * cs-parser.jay (general_catch_clause): Comment out
19649 (specific_catch_clauses, specific_catch_clause): Ditto.
19650 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
19651 (catch_args, opt_catch_args): New productions.
19652 (catch_clause): Rewrite to use the new productions above
19653 (catch_clauses): Modify accordingly.
19654 (opt_catch_clauses): New production to use in try_statement
19655 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
19656 and re-write the code in the actions to extract the specific and
19657 general catch clauses by being a little smart ;-)
19659 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
19660 Hooray, try and catch statements parse fine !
19662 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
19664 * statement.cs (Block::GetVariableType): Fix logic to extract the type
19665 string from the hashtable of variables.
19667 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
19668 I end up making that mistake ;-)
19669 (catch_clauses): Fixed gross error which made Key and Value of the
19670 DictionaryEntry the same : $1 !!
19672 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
19674 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
19676 * cs-parser.jay (event_declaration): Correct to remove the semicolon
19677 when the add and remove accessors are specified.
19679 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
19681 * cs-parser.jay (IndexerDeclaration): New helper class to hold
19682 information about indexer_declarator.
19683 (indexer_declarator): Implement actions.
19684 (parsing_indexer): New local boolean used to keep track of whether
19685 we are parsing indexers or properties. This is necessary because
19686 implicit_parameters come into picture even for the get accessor in the
19687 case of an indexer.
19688 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
19690 * class.cs (Indexer): New class for indexer declarations.
19691 (TypeContainer::AddIndexer): New method to add an indexer to a type.
19692 (TypeContainer::indexers): New member to hold list of indexers for the
19695 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
19697 * cs-parser.jay (add_accessor_declaration): Implement action.
19698 (remove_accessor_declaration): Implement action.
19699 (event_accessors_declaration): Implement
19700 (variable_declarators): swap statements for first rule - trivial.
19702 * class.cs (Event): New class to hold information about event
19704 (TypeContainer::AddEvent): New method to add an event to a type
19705 (TypeContainer::events): New member to hold list of events.
19707 * cs-parser.jay (event_declaration): Implement actions.
19709 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
19711 * cs-parser.jay (dim_separators): Implement. Make it a string
19712 concatenating all the commas together, just as they appear.
19713 (opt_dim_separators): Modify accordingly
19714 (rank_specifiers): Update accordingly. Basically do the same
19715 thing - instead, collect the brackets here.
19716 (opt_rank_sepcifiers): Modify accordingly.
19717 (array_type): Modify to actually return the complete type string
19718 instead of ignoring the rank_specifiers.
19719 (expression_list): Implement to collect the expressions
19720 (variable_initializer): Implement. We make it a list of expressions
19721 essentially so that we can handle the array_initializer case neatly too.
19722 (variable_initializer_list): Implement.
19723 (array_initializer): Make it a list of variable_initializers
19724 (opt_array_initializer): Modify accordingly.
19726 * expression.cs (New::NType): Add enumeration to help us
19727 keep track of whether we have an object/delegate creation
19728 or an array creation.
19729 (New:NewType, New::Rank, New::Indices, New::Initializers): New
19730 members to hold data about array creation.
19731 (New:New): Modify to update NewType
19732 (New:New): New Overloaded contructor for the array creation
19735 * cs-parser.jay (array_creation_expression): Implement to call
19736 the overloaded New constructor.
19738 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
19740 * class.cs (TypeContainer::Constructors): Return member
19741 constructors instead of returning null.
19743 2001-08-26 Miguel de Icaza <miguel@ximian.com>
19745 * typemanager.cs (InitCoreTypes): Initialize the various core
19746 types after we have populated the type manager with the user
19747 defined types (this distinction will be important later while
19748 compiling corlib.dll)
19750 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
19751 on Expression Classification. Now all expressions have a method
19752 `Resolve' and a method `Emit'.
19754 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
19755 generation from working. Also add some temporary debugging
19758 2001-08-24 Miguel de Icaza <miguel@ximian.com>
19760 * codegen.cs: Lots of code generation pieces. This is only the
19761 beginning, will continue tomorrow with more touches of polish. We
19762 handle the fundamentals of if, while, do, for, return. Others are
19763 trickier and I need to start working on invocations soon.
19765 * gen-treedump.cs: Bug fix, use s.Increment here instead of
19768 * codegen.cs (EmitContext): New struct, used during code
19769 emission to keep a context. Most of the code generation will be
19772 * cs-parser.jay: Add embedded blocks to the list of statements of
19773 this block. So code generation proceeds in a top down fashion.
19775 2001-08-23 Miguel de Icaza <miguel@ximian.com>
19777 * statement.cs: Add support for multiple child blocks.
19779 2001-08-22 Miguel de Icaza <miguel@ximian.com>
19781 * codegen.cs (EmitCode): New function, will emit the code for a
19782 Block of code given a TypeContainer and its ILGenerator.
19784 * statement.cs (Block): Standard public readonly optimization.
19785 (Block::Block constructors): Link children.
19786 (Block::Child): Child Linker.
19787 (Block::EmitVariables): Emits IL variable declarations.
19789 * class.cs: Drop support for MethodGroups here, delay until
19791 (Method::): Applied the same simplification that I did before, and
19792 move from Properties to public readonly fields.
19793 (Method::ParameterTypes): Returns the parameter types for the
19794 function, and implements a cache that will be useful later when I
19795 do error checking and the semantic analysis on the methods is
19797 (Constructor::GetCallingConvention): Renamed from CallingConvetion
19798 and made a method, optional argument tells whether this is a class
19799 or a structure to apply the `has-this' bit.
19800 (Method::GetCallingConvention): Implement, returns the calling
19802 (Method::Define): Defines the type, a second pass is performed
19803 later to populate the methods.
19805 (Constructor::ParameterTypes): implement a cache similar to the
19806 one on Method::ParameterTypes, useful later when we do semantic
19809 (TypeContainer::EmitMethod): New method. Emits methods.
19811 * expression.cs: Removed MethodGroup class from here.
19813 * parameter.cs (Parameters::GetCallingConvention): new method.
19815 2001-08-21 Miguel de Icaza <miguel@ximian.com>
19817 * class.cs (TypeContainer::Populate): Drop RootContext from the
19820 (Constructor::CallingConvention): Returns the calling convention.
19821 (Constructor::ParameterTypes): Returns the constructor parameter
19824 (TypeContainer::AddConstructor): Keep track of default constructor
19825 and the default static constructor.
19827 (Constructor::) Another class that starts using `public readonly'
19828 instead of properties.
19830 (Constructor::IsDefault): Whether this is a default constructor.
19832 (Field::) use readonly public fields instead of properties also.
19834 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
19835 track of static constructors; If none is used, turn on
19836 BeforeFieldInit in the TypeAttributes.
19838 * cs-parser.jay (opt_argument_list): now the return can be null
19839 for the cases where there are no arguments.
19841 (constructor_declarator): If there is no implicit `base' or
19842 `this', then invoke the default parent constructor.
19844 * modifiers.cs (MethodAttr): New static function maps a set of
19845 modifiers flags into a MethodAttributes enum
19846 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
19847 MethodAttr, TypeAttr to represent the various mappings where the
19848 modifiers are used.
19849 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
19851 2001-08-19 Miguel de Icaza <miguel@ximian.com>
19853 * parameter.cs (GetParameterInfo): Fix bug where there would be no
19856 * interface.cs (PopulateIndexer): Implemented the code generator
19857 for interface indexers.
19859 2001-08-17 Miguel de Icaza <miguel@ximian.com>
19861 * interface.cs (InterfaceMemberBase): Now we track the new status
19864 (PopulateProperty): Implement property population. Woohoo! Got
19865 Methods and Properties going today.
19867 Removed all the properties for interfaces, and replaced them with
19868 `public readonly' fields.
19870 2001-08-16 Miguel de Icaza <miguel@ximian.com>
19872 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
19873 initialize their hashtables/arraylists only when they are needed
19874 instead of doing this always.
19876 * parameter.cs: Handle refs and out parameters.
19878 * cs-parser.jay: Use an ArrayList to construct the arguments
19879 instead of the ParameterCollection, and then cast that to a
19882 * parameter.cs: Drop the use of ParameterCollection and use
19883 instead arrays of Parameters.
19885 (GetParameterInfo): Use the Type, not the Name when resolving
19888 2001-08-13 Miguel de Icaza <miguel@ximian.com>
19890 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
19891 and instead use public readonly fields.
19893 * class.cs: Put back walking code for type containers.
19895 2001-08-11 Miguel de Icaza <miguel@ximian.com>
19897 * class.cs (MakeConstant): Code to define constants.
19899 * rootcontext.cs (LookupType): New function. Used to locate types
19902 2001-08-08 Miguel de Icaza <miguel@ximian.com>
19904 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
19905 this System.Reflection code is. Kudos to Microsoft
19907 * typemanager.cs: Implement a type cache and avoid loading all
19908 types at boot time. Wrap in LookupType the internals. This made
19909 the compiler so much faster. Wow. I rule!
19911 * driver.cs: Make sure we always load mscorlib first (for
19912 debugging purposes, nothing really important).
19914 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
19915 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
19917 * rootcontext.cs: Lookup types on their namespace; Lookup types
19918 on namespaces that have been imported using the `using' keyword.
19920 * class.cs (TypeContainer::TypeAttr): Virtualize.
19921 (Class::TypeAttr): Return attributes suitable for this bad boy.
19922 (Struct::TypeAttr): ditto.
19923 Handle nested classes.
19924 (TypeContainer::) Remove all the type visiting code, it is now
19925 replaced with the rootcontext.cs code
19927 * rootcontext.cs (GetClassBases): Added support for structs.
19929 2001-08-06 Miguel de Icaza <miguel@ximian.com>
19931 * interface.cs, statement.cs, class.cs, parameter.cs,
19932 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
19933 Drop use of TypeRefs, and use strings instead.
19935 2001-08-04 Miguel de Icaza <miguel@ximian.com>
19939 * class.cs (Struct::Struct): set the SEALED flags after
19940 checking the modifiers.
19941 (TypeContainer::TypeAttr): new property, returns the
19942 TypeAttributes for a class.
19944 * cs-parser.jay (type_list): Oops, list production was creating a
19945 new list of base types.
19947 * rootcontext.cs (StdLib): New property.
19948 (GetInterfaceTypeByName): returns an interface by type name, and
19949 encapsulates error handling here.
19950 (GetInterfaces): simplified.
19951 (ResolveTree): Encapsulated all the tree resolution here.
19952 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
19955 * driver.cs: Add support for --nostdlib, to avoid loading the
19956 default assemblies.
19957 (Main): Do not put tree resolution here.
19959 * rootcontext.cs: Beginning of the class resolution.
19961 2001-08-03 Miguel de Icaza <miguel@ximian.com>
19963 * rootcontext.cs: Provide better error reporting.
19965 * cs-parser.jay (interface_base): set our $$ to be interfaces.
19967 * rootcontext.cs (CreateInterface): Handle the case where there
19968 are no parent interfaces.
19970 (CloseTypes): Routine to flush types at the end.
19971 (CreateInterface): Track types.
19972 (GetInterfaces): Returns an array of Types from the list of
19973 defined interfaces.
19975 * typemanager.c (AddUserType): Mechanism to track user types (puts
19976 the type on the global type hash, and allows us to close it at the
19979 2001-08-02 Miguel de Icaza <miguel@ximian.com>
19981 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
19982 RecordInterface instead.
19984 * cs-parser.jay: Updated to reflect changes above.
19986 * decl.cs (Definition): Keep track of the TypeBuilder type that
19987 represents this type here. Not sure we will use it in the long
19988 run, but wont hurt for now.
19990 * driver.cs: Smaller changes to accomodate the new code.
19992 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
19995 * rootcontext.cs (CreateInterface): New method, used to create
19996 the System.TypeBuilder type for interfaces.
19997 (ResolveInterfaces): new entry point to resolve the interface
19999 (CodeGen): Property, used to keep track of the code generator.
20001 2001-07-26 Miguel de Icaza <miguel@ximian.com>
20003 * cs-parser.jay: Add a second production for delegate_declaration
20006 (enum_body): Put an opt_comma here instead of putting it on
20007 enum_body or enum_member_declarations so we can handle trailing
20008 commas on enumeration members. Gets rid of a shift/reduce.
20010 (type_list): Need a COMMA in the middle.
20012 (indexer_declaration): Tell tokenizer to recognize get/set
20014 * Remove old targets.
20016 * Re-add the parser target.
20018 2001-07-13 Simon Cozens <simon@simon-cozens.org>
20020 * cs-parser.jay: Add precendence rules for a number of operators
20021 ot reduce the number of shift/reduce conflicts in the grammar.
20023 2001-07-17 Miguel de Icaza <miguel@ximian.com>
20025 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
20028 Get rid of old crufty code.
20030 * rootcontext.cs: Use this to keep track of the parsed
20031 representation and the defined types available to the program.
20033 * gen-treedump.cs: adjust for new convention.
20035 * type.cs: Split out the type manager, and the assembly builder
20038 * typemanager.cs: the type manager will live here now.
20040 * cil-codegen.cs: And the code generator here.
20042 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
20044 * makefile: Fixed up for easy making.
20046 2001-07-13 Simon Cozens <simon@simon-cozens.org>
20048 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
20051 (unary_expression): Expand pre_increment_expression and
20052 post_decrement_expression to reduce a shift/reduce.
20054 2001-07-11 Simon Cozens
20056 * cs-tokenizer.cs: Hex numbers should begin with a 0.
20058 Improve allow_keyword_as_indent name.
20060 2001-06-19 Miguel de Icaza <miguel@ximian.com>
20062 * Adjustments for Beta2.
20064 2001-06-13 Miguel de Icaza <miguel@ximian.com>
20066 * decl.cs: Added `Define' abstract method.
20067 (InTransit): new property, used to catch recursive definitions.
20069 * interface.cs: Implement `Define'.
20071 * modifiers.cs: Map Modifiers.constants to
20072 System.Reflection.TypeAttribute flags.
20074 * class.cs: Keep track of types and user-defined types.
20075 (BuilderInit): New method for creating an assembly
20076 (ResolveType): New function to launch the resolution process, only
20077 used by interfaces for now.
20079 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
20080 that are inserted into the name space.
20082 2001-06-08 Miguel de Icaza <miguel@ximian.com>
20084 * ARGH. I have screwed up my tree so many times due to the use of
20085 rsync rather than using CVS. Going to fix this at once.
20087 * driver.cs: Objetify driver. Load assemblies, use assemblies to
20090 2001-06-07 Miguel de Icaza <miguel@ximian.com>
20092 * Experiment successful: Use System.Type rather that our own
20095 2001-05-25 Miguel de Icaza <miguel@ximian.com>
20097 * cs-parser.jay: Removed nsAliases from here.
20099 Use new namespaces, handle `using XXX;'
20101 * namespace.cs: Reimplemented namespace handling, use a recursive
20102 definition of the class. Now we can keep track of using clauses
20103 and catch invalid using clauses.
20105 2001-05-24 Miguel de Icaza <miguel@ximian.com>
20107 * gen-treedump.cs: Adapted for all the renaming.
20109 * expression.cs (Expression): this class now has a Type property
20110 which returns an expression Type.
20112 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
20113 `Type', as this has a different meaning now in the base
20115 2001-05-22 Miguel de Icaza <miguel@ximian.com>
20117 * interface.cs, class.cs: Removed from all the sources the
20118 references to signature computation, as we can not do method
20119 signature computation during the parsing time, as we are not
20120 trying to solve at that point distinguishing:
20124 void a (NS.Blah x) {}
20127 Which depending on the context might be valid or not, as we do not
20128 know if Blah is the same thing as NS.Blah at that point.
20130 * Redid everything so the code uses TypeRefs now instead of
20131 Types. TypeRefs are just temporary type placeholders, that need
20132 to be resolved. They initially have a pointer to a string and the
20133 current scope in which they are used. This is used later by the
20134 compiler to resolve the reference to an actual Type.
20136 * DeclSpace is no longer a CIR.Type, and neither are
20137 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
20138 are all DeclSpaces, but no Types.
20140 * type.cs (TypeRefManager): This implements the TypeRef manager,
20141 which keeps track of all the types that need to be resolved after
20142 the parsing has finished.
20144 2001-05-13 Miguel de Icaza <miguel@ximian.com>
20146 * ARGH. We are going to have to store `foreach' as a class rather
20147 than resolving it, as we need to verify error 1579 after name
20148 resolution. *OR* we could keep a flag that says `This request to
20149 IEnumerator comes from a foreach statement' which we can then use
20150 to generate the error.
20152 2001-05-10 Miguel de Icaza <miguel@ximian.com>
20154 * class.cs (TypeContainer.AddMethod): we now add methods to the
20155 MethodGroup instead of the method hashtable.
20157 * expression.cs: Add MethodGroup abstraction, which gets us one
20158 step closer to the specification in the way we handle method
20161 * cs-parser.jay (primary_expression): qualified_identifier now
20162 tried to match up an identifier to a local variable reference or
20163 to a parameter reference.
20165 current_local_parameters is now a parser global variable that
20166 points to the current parameters for the block, used during name
20169 (property_declaration): Now creates an implicit `value' argument to
20172 2001-05-09 Miguel de Icaza <miguel@ximian.com>
20174 * parameter.cs: Do not use `param' arguments as part of the
20175 signature, per the spec.
20177 2001-05-08 Miguel de Icaza <miguel@ximian.com>
20179 * decl.cs: Base class for classes, structs and interfaces. This
20180 is the "Declaration Space"
20182 * cs-parser.jay: Use CheckDef for checking declaration errors
20183 instead of having one on each function.
20185 * class.cs: Factor out some code for handling error handling in
20186 accordance to the "Declarations" section in the "Basic Concepts"
20187 chapter in the ECMA C# spec.
20189 * interface.cs: Make all interface member classes derive from
20190 InterfaceMemberBase.
20192 2001-05-07 Miguel de Icaza <miguel@ximian.com>
20194 * Many things: all interfaces are parsed and generated in
20195 gen-treedump. Support for member variables, constructors,
20196 destructors, properties, constants is there.
20198 Beginning of the IL backend, but very little done, just there for
20201 2001-04-29 Miguel de Icaza <miguel@ximian.com>
20203 * cs-parser.jay: Fix labeled statement.
20205 * cs-tokenizer.cs (escape): Escape " and ' always.
20206 ref_line, ref_name: keep track of the line/filename as instructed
20207 by #line by the compiler.
20210 2001-04-27 Miguel de Icaza <miguel@ximian.com>
20212 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
20213 to match the values in System.CodeDOM.
20215 Divid renamed to Divide.
20217 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
20219 (Statements.set): remove.
20221 * System.CodeDOM/CodeCatchClause.cs: always have a valid
20224 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
20225 falseStatements always have valid values.
20227 * cs-parser.jay: Use System.CodeDOM now.