1 2006-09-15 Martin Baulig <martin@ximian.com>
3 * Makefile: Define `GMCS_SOURCE'.
5 * flowanalysis.cs: Removed; this file is now shared with mcs.
7 2006-09-15 Martin Baulig <martin@ximian.com>
9 Removed modifiers.cs, literal.cs, location.cs, roottypes.cs,
10 assign.cs, const.cs, cfold.cs, constant.cs, symbolwriter.cs and
11 doc.cs - they are now shared with mcs.
13 * gmcs.exe.sources: Include these files from ../mcs/.
15 2006-09-15 Martin Baulig <martin@ximian.com>
17 * old-code.cs, gen-il.cs, gen-treedump.cs: Removed old stuff.
18 * g1.cs, sample-hello.cs, sample-stack.il: Likewise.
20 2006-09-14 Marek Safar <marek.safar@seznam.cz>
22 * assign.cs, ecore.cs, expression.cs: Share error message text.
23 * class.cs (FieldMember.Define): Check for variable of static type.
24 * decl.cs (check_type_parameter): Report correct type name.
25 * driver.cs (LoadAssembly): Uses error output for errors.
26 * generic.cs (Constraints.Resolve): Add check for constraint accessibility
27 (TypeArguments.Resolve): Static class cannot be used as an argument.
28 * statement.cs (ResolveMeta): Constants cannot be generic types.
30 2006-09-12 Martin Baulig <martin@ximian.com>
32 * generic.cs (TypeManager.IsIList): Moved into convert.cs.
34 * convert.cs (Convert.Array_To_IList): Moved here and correctly
35 implement it; fixes #79345.
37 2006-09-08 Marek Safar <marek.safar@seznam.cz>
39 * decl.cs (DeclSpace.SetParameterInfo): Check for nonexistent type
41 * expression.cs (TypeOf.GetAttributableValue): Check for open generic
43 * generic.cs: Improved error messages.
44 * typemanager.cs (RemoveGenericArity): Made public.
46 2006-09-08 Martin Baulig <martin@ximian.com>
48 * typemanager.cs (TypeManager.interlocked_type): New public field.
49 (TypeManager.int_interlocked_compare-exchange): New public field.
50 (TypeManager.InitEnumUnderlyingTypes): Also initialize the
51 enumerator types here and call InitGenericCoreTypes().
52 (TypeManager.InitCoreTypes): Call InitEnumeratorTypes() right
53 after calling InitEnumUnderlyingTypes().
56 (RootContext.ResolveCore): Added `System.Threading.Interlocked' to
57 `classes_second_stage'.
59 2006-09-07 Marek Safar <marek.safar@seznam.cz>
61 * class.cs, generic.cs (GenericMethod.Define): Check for type parameter
63 * statement.cs (Block.Variables): Made public.
65 2006-09-07 Martin Baulig <martin@ximian.com>
68 (MainDriver): Revert r62663 from Marek; see #70506 for details.
70 2006-09-01 Martin Baulig <martin@ximian.com>
73 (TypeManager.IsIList): Also handle base classes and interfaces.
75 2006-09-01 Raja R Harinath <rharinath@novell.com>
78 * expression.cs (Invocation.MoreSpecific): Check for reference
81 2006-08-29 Miguel de Icaza <miguel@novell.com>
83 * cs-parser.jay: Turn 1522 into a warning, instead of an error #79210
85 2006-08-17 Miguel de Icaza <miguel@novell.com>
87 * cs-tokenizer.cs: Apply patch from Atsushi Enomoto that fixes
88 #52019 and #79064, the use of the \uXXXX sequence in source code
89 to represent unicode characters.
91 2006-08-15 Marek Safar <marek.safar@seznam.cz>
93 * expression.cs (SizeOf.DoResolve): Check for void type. Fixed enum types
95 * class.cs, ecore.cs, statement.cs: Merged to one error message.
97 2006-08-14 Raja R Harinath <rharinath@novell.com>
100 * cs-tokenizer.cs (parse_less_than): Allow '*' to appear in a type
101 parameter too. This only avoids a parse error -- the semantic
102 error is caught elsewhere.
104 2006-08-13 Miguel de Icaza <miguel@novell.com>
106 * assign.cs: Catch attempts to assign to a method groups in += and
109 2006-08-13 Marek Safar <marek.safar@seznam.cz>
112 * cs-parser.jay: Don't destroy current array type by typeof of array's.
114 2006-08-12 Marek Safar <marek.safar@seznam.cz>
116 * cs-parser.jay: Check whether a constraint clause has already been
117 specified for type parameter.
118 * generic.cs (Constraints): Exposed location.
120 2006-08-12 Marek Safar <marek.safar@seznam.cz>
122 * class.cs (Method.Define): Issue a warning when generic method looks like
124 * decl.cs (MemberCore.GetSignatureForError): Print member type arguments
126 * report.cs: New warning number.
128 2006-08-09 Marek Safar <marek.safar@seznam.cz>
130 * anonymous.cs(AnonymousDelegate.Emit): Uses Constructor filter when
132 * decl.cs (MemberCache.FindMembers): When container is interface we need to
133 search all base interfaces as a member can be ambiguous.
134 * delegate.cs (Delegate.FindMembers): Fixed to return valid data for
135 Constructor member type filter.
136 (Delegate.ResolveConstructorMethod) Uses Constructor filter.
137 * ecore.cs: (Expression.MemberLookup): Implemented ambiguity error/warning
138 reporting for returned memberinfos.
139 * report.cs: Updated.
140 * typemanager.cs (TypeManager.LookupBaseInterfacesCache): Uses TypeManager
141 version to work on all runtimes.
142 (TypeManager.RealMemberLookup): Removed members filtering.
144 2006-08-08 Raja R Harinath <rharinath@novell.com>
146 * ecore.cs (FieldExpr.EmitAssign): Release temporary.
147 (PropertyExpr.EmitAssign): Likewise.
148 * expression.cs (Indirection.EmitAssign): Likewise.
149 (LocalVariableReference.EmitAssign): Likewise.
150 (ParameterReference.EmitAssign): Likewise.
151 (Invocation.EmitArguments): Likewise.
152 (ArrayAccess.EmitAssign): Likewise.
153 (IndexerAccess.EmitAssign): Likewise.
154 (This.EmitAssign): Likewise.
155 (ConditionalLogicalOperator.Emit): Likewise.
158 * codegen.cs (EmitContext.GetTemporaryLocal): Simplify. Use Stack
159 instead of ArrayList. If the hashtable has a LocalBuilder, don't
160 leave it in after returning it.
161 (EmitContext.FreeTemporaryLocal): Simplify. Update to changes.
163 2006-08-06 Marek Safar <marek.safar@seznam.cz>
165 * expresssion.cs (IndexerAccess.DoResolve): Fixed to report correct error
168 2006-08-05 Marek Safar <marek.safar@seznam.cz>
170 * class.cs (TypeContainer.AddPartial): Add check for partial declarations
171 with different type names.
172 (TypeContainer.UpdateTypeParameterConstraints): Updated an error message.
174 2006-08-03 Raja R Harinath <rharinath@novell.com>
176 Fix cs0146-3.cs and cs0146-4.cs.
177 * class.cs (TypeManager.CheckRecursiveDefinition): Check that
178 enclosing types don't depend on the current type.
180 2006-08-02 Raja R Harinath <rharinath@novell.com>
183 * class.cs (TypeContainer.DoDefineMembers): Use
184 FindBaseMemberWithSameName on Parent, since we're interested in
185 whether we hide inherited members or not.
186 (FindBaseMemberWithSameName): Make slightly more robust.
189 * codegen.cs (IResolveContext.GenericDeclContainer): New.
190 (EmitContext): Implement new interface requirement.
191 * namespace.cs (UsingEntry, LocalAliasEntry): Likewise.
192 * decl.cs (MemberCore): Likewise.
193 (DeclSpace.GenericDeclContainer): Rename from DeclContainer.
194 * ecore.cs (SimpleName.ResolveAsTypeTerminal): Use
195 ec.GenericDeclContainer to check for generic parameters.
196 (SimpleName.DoSimpleNameResolve): Likewise.
197 * generic.cs (TypeParameter.DeclContainer): Remove override.
199 * namespace.cs (NamespaceEntry.Doppelganger): Create slave
200 declspaces for doppelgangers too.
201 (UsingEntry): Implement IResolveContext.
202 (UsingEntry.Resolve): Don't set ToplevelTypes.Namespace. Use
203 'this' as the resolve context.
204 (LocalAliasEntry): Likewise.
206 Implement parts of #77403
207 * roottypes.cs (RootDeclSpace): New. Used to represent the
208 toplevel declaration space. Each namespace declaration introduces
209 a "partial" root declaretion space.
210 * namespace.cs (NamespaceEntry.SlaveDeclSpace): New.
211 (NamespaceEntry.ctor): Create a SlaveDeclSpace if necessary.
212 * cs-parser.jay (CSharpParser.ctor): Initialize 'current_class'
213 from 'current_namespace.SlaveDeclSpace'.
214 (namespace_declaration): Likewise.
215 * class.cs (TypeContainer.ctor): Remove parent==ToplevelTypes
216 check. It can't happen now.
217 * decl.cs (DeclSpace.LookupType): Likewise.
218 * driver.cs (MainDriver): Sanity check.
220 2006-08-01 Raja R Harinath <rharinath@novell.com>
222 * decl.cs (DeclSpace.FindNestedType): Remove.
223 (DeclSpace.LookupNestedTypeINHierarchy): Use PartialContainer and
224 LookupTypeContainer to get the container of the nested type.
225 * class.cs (TypeContainer.FindNestedType): Make non-override.
227 2006-07-31 Raja R Harinath <rharinath@novell.com>
229 * decl.cs (DeclSpace.PartialContainer): Move field from ...
230 * class.cs (TypeContainer.PartialContainer): ... here.
231 (TypeContainer.AddBasesForPart): New helper.
232 (MemberBase.ParentContainer): Remove. Use Parent.PartialContainer
234 * cs-parser.jay (current_class): Convert to DeclSpace.
235 (struct_declaration, interface_declaration, class_declaration):
236 Use AddBasesForPart instead of .Bases directly.
237 * const.cs, iterators.cs: Update to changes.
239 2006-07-28 Raja R Harinath <rharinath@novell.com>
241 * class.cs (TypeContainer.AddMemberType): Rename from
243 (TypeContainer.AddMember): Rename from AddToMemberContainer.
244 (AddTypeContainer): New. Combine AddClassOrStruct and
246 (AddPartial): Update. Add 'is_partial' argument.
247 * roottypes.cs: Update to changes.
248 * cs-parser.jay (push_current_class): New helper for handling
249 current_container and current_class.
250 (struct_declaration, interface_declaration, class_declaration):
253 2006-07-26 Raja R Harinath <rharinath@novell.com>
255 * roottypes.cs: Rename from tree.cs.
257 Rename RootContext.Tree.Types to RootContext.ToplevelTypes.
258 * tree.cs (Tree, ITreeDump): Remove types.
259 * rootcontext.cs (tree, Tree): Remove fields.
260 (root, ToplevelTypes): New.
261 * *.cs: Update to rename.
263 * tree.cs (Tree.RecordDecl): Remove.
264 (RootTypes.AddToTypeContainer): Record the toplevel type in its
266 * class.cs, cs-parser.jay: Remove mention of RecordDecl.
268 2006-07-23 Raja R Harinath <harinath@gmail.com>
270 * codegen.cs (EmitContext.Flags): Move InCatch, InFinally,
271 DoFlowAnalysis and OmitStructFlowAnalysis here.
272 (ec.With): Rename from WithUnsafe and generalize.
273 (ec.WithCheckState): Remove. All users can be handled by 'With'.
274 (ec.WithFlowAnalyis): New.
275 * ecore.cs, expression.cs, statement.cs: Update.
277 2006-07-22 Raja R Harinath <harinath@gmail.com>
279 * statement.cs (Block.ResolveMeta): Simplify slightly.
281 * codegen.cs (EmitContext.Flags): New enum. Used to represent the
282 multiple boolean fields. Convert InUnsafe, constant_check_state,
283 check_state to flags.
284 (CheckState, ConstantCheckState): Update.
285 (InUnsafe): New read-only property.
286 (FlagsHandle): Rename from CheckStateHandle and convert to handle
288 (WithUnsafe): New helper similar to WithCheckState.
289 * statement.cs (Block.ResolveMeta): Use WithUnsafe.
290 (Unsafe.Resolve, Unsafe.DoEmit): Likewise.
292 2006-07-21 Raja R Harinath <rharinath@novell.com>
294 Make comparisons use the same IL irrespective of whether they're
295 in a 'checked' or 'unchecked' context: one of the issues in #78899
296 * codegen.cs (EmitContext.CheckState): Make read-only property.
297 (EmitContext.ConstantCheckState): Likewise.
298 (EmitContext.CheckStateHandle, EmitContext.WithCheckState): New
299 helper that implement a save/restore stack for CheckState
300 values. This is the only way to change check-state.
301 * ecore.cs (Expression.ExpressionToArrayArgument): Use WithCheckState.
302 * expression.cs (CheckedExpr.DoResolve, CheckedExpr.Emit): Likewise.
303 (CheckedExpr.EmitBranchable): New forwarding method.
304 (UnCheckedExpr): Likewise.
305 * statement.cs (Block.ResolveMeta): Use WithCheckState.
306 (Unchecked.Resolve, Unchecked.DoEmit): Likewise.
307 (Checked.Resolve, checked.DoEmit): Likewise.
309 2006-07-21 Martin Baulig <martin@ximian.com>
311 * generic.cs (TypeManager.InferType): When inferring an array
312 type, also allow IList<T> and ICollection<T>. Fixes #78900.
314 2006-07-21 Martin Baulig <martin@ximian.com>
316 * generic.cs (TypeManager.IsIEnumerable): Renamed into IsIList()
317 and allow IList`1 and all its base interfaces.
319 * convert.cs (Convert.ImplicitReferenceConversion): Allow
320 converting from an array-type of T to IList<T>.
322 2006-07-21 Martin Baulig <martin@ximian.com>
324 * ecore.cs (SimpleName.DoSimpleNameResolve): Added CS0307 check.
326 2006-07-20 Miguel de Icaza <miguel@novell.com>
328 * anonymous.cs: Cache the resolved anonymous delegate, and return
329 this so that the ResolveTopBlock is only triggered once, not
332 Currently we trigger ResolvetopBlock twice due to a first pass of
333 argument check compatibility, and a second pass that does the
336 2006-07-15 Marek Safar <marek.safar@seznam.cz>
338 * annonymous.cs (AnonymousMethod.CreateScopeType): Fixed nested type
340 * rootcontext.cs (Reset): Add helper_classes.
342 2006-07-15 Marek Safar <marek.safar@seznam.cz>
345 * statement.cs (Switch.SimpleSwitchEmit): Handle case null at any position
348 2006-07-13 Miguel de Icaza <miguel@novell.com>
350 * statement.cs (Lock): Handle expressions of type
351 TypeManager.null_type specially. Fixes #78770
353 2006-07-08 Marek Safar <marek.safar@seznam.cz>
355 * expression.cs (Binary.ResolveOperator): Don't crash when null is assigned
358 2006-07-08 Marek Safar <marek.safar@seznam.cz>
360 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Fixed to look
361 for accessors as well.
362 * ecore.cs (EventExpr): Add AccessorTable.
364 2006-07-03 Martin Baulig <martin@ximian.com>
366 * ecore.cs (UnboxCast.Emit): Also use `Unbox_Any' for generic
367 instances of value types.
369 * convert.cs (Convert.ExplicitConversion): Correctly handle
370 object->nullable conversions.
372 2006-07-01 Marek Safar <marek.safar@seznam.cz>
375 * attribute.cs, class.cs, ecore.cs : Add missing location of related symbol
376 for CS0122 where appropriate.
377 * typemanager.cs (IsNestedChildOf): Type can be null in the case of top
379 (Filter): Assembly can be null in the case of top level attributes.
381 2006-06-28 Raja R Harinath <rharinath@novell.com>
384 * generic.cs (TypeManager.InferParamsTypeArguments): If there are
385 no arguments, return 'false': nothing can be inferred.
387 2006-06-25 Marek Safar <marek.safar@seznam.cz>
391 * ecore.cs (Expression.MemberLookupFailed): Don't crash when failed lookup
392 is done at global level.
394 2006-06-24 Marek Safar <marek.safar@seznam.cz>
396 A fix for #77002, Implemented TypeForwarder support.
398 * attribute.cs (Attribute.GetArgumentType): Reads type argument.
399 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Add TypeForwarder
401 * expression.cs (TypeOf.TypeArgument): Exposes typeof type.
402 * typemanager.cs (): Add type_forwarder_attr_type.
404 2006-06-24 Marek Safar <marek.safar@seznam.cz>
406 * report.cs: Add CS0469 warning.
408 2006-06-22 Martin Baulig <martin@ximian.com>
411 (TypeContainer.GetNormalBases): Also use ResolveAsBaseTerminal()
412 for interfaces; fixes #78686, which is a modification of #78380
413 with interfaces instead of classes.
415 2006-06-21 Martin Baulig <martin@ximian.com>
417 * codegen.cs (CodeGen.Save): Moved the symbol file generation into
418 the `try'-block, so we also report CS0016 etc. there.
420 2006-06-21 Martin Baulig <martin@ximian.com>
422 * ecore.cs (FieldExpr.EmitAssign, FieldExpr.AddressOf): Correctly
423 handle SetAssigned() and SetMemberIsUsed() for generic types;
426 2006-06-21 Martin Baulig <martin@ximian.com>
429 (Delegate.VerifyMethod): Allow `params' methods; fixes #78678.
431 2006-06-21 Martin Baulig <martin@ximian.com>
433 * expression.cs (Unary.ResolveOperator): In `Operator.AddressOf',
434 also report CS1686 for parameters.
436 2006-06-21 Martin Baulig <martin@ximian.com>
438 * statement.cs (GotoCase.Resolve): Report a warning (CS0469)
439 instead of an error if the value is not implicitly convertible to
440 the switch types; fixes #77964.
442 2006-06-21 Raja R Harinath <rharinath@novell.com>
445 * class.cs (FieldBase.ResolveInitializer): Stop resolution if
446 FieldBuilder is null.
449 * expression.cs (Binary.CheckShiftArguments): Don't overwrite original
450 'left' and 'right' before error-checking.
452 2006-06-19 Martin Baulig <martin@ximian.com>
455 (Convert.ImplicitConversionStandard): Cleanup and correctly
456 implement nullable conversions.
457 (Convert.ImplicitStandardConversionExists): Likewise.
458 (Convert.ExplicitConversion): Likewise.
460 2006-06-19 Martin Baulig <martin@ximian.com>
463 (Nullable.Wrap.Create, Nullable.Unwrap.Create): New public static
464 methods; make the ctors protected.
466 2006-06-19 Martin Baulig <martin@ximian.com>
468 Fixed #78380; added gtest-273.cs.
471 (Expression.ResolveAsBaseTerminal): Move the constraint checking
472 into ResolveAsTypeTerminal().
475 (ConstraintChecker.HasDefaultConstructor): Use the non-cache based
476 TypeManager.FindMembers() to check for the default ctor.
478 2006-06-18 Marek Safar <marek.safar@seznam.cz>
480 * generic.cs: Fixed NullableInfo accessibility.
482 2006-06-16 Martin Baulig <martin@ximian.com>
485 (Constraints.InflatedConstraints.inflate): Correctly inflate
486 generic types; fixes #78400.
488 2006-06-16 Juraj Skripsky <js@hotfeet.ch>
490 * ecore.cs (SimpleName.Error_ObjectRefRequired): Do not truncate the name.
492 (MemberExpr.EmitInstance): Use GetSignatureForError () to get full name.
493 (FieldExpr.DoResolve): likewise.
494 (PropertyExpr.InstanceResolve): likewise.
495 (EventExpr.InstanceResolve): likewise.
497 2006-06-15 Martin Baulig <martin@ximian.com>
500 (SwitchLabel.ResolveAndReduce): Added `bool allow_nullable'
501 argument; always allow a `null' label if true.
502 (Switch.SwitchGoverningType): Take an `Expression expr' argument.
503 (Switch.TableSwitchEmit, Switch.SimpleSwitchEmit): Check whether
504 we have a `null' label and mark the new `null_target' label;
505 default to the `default' label.
506 (Switch.Resolve): Add support for nullable types. Fixes #78630.
508 2006-06-15 Martin Baulig <martin@ximian.com>
510 * class.cs (Operator.Define): Allow an implicit/explicit operator
511 to convert to/from a nullable value of the enclosing type.
513 * generic.cs (TypeManager.IsNullableTypeOf): New public method.
514 (Nullable.Unwrap, Nullable.Wrap): Make these classes public.
517 (Convert.ImplicitStandardConversionExists): Add support for lifted
518 implicit/explicit conversions.
519 (Convert.ImplicitConversionStandard): Likewise.
521 2006-06-13 Martin Baulig <martin@ximian.com>
523 * ecore.cs (SimpleName.DoSimpleNameResolve): Check whether we have
524 type arguments and create a ConstructedType if necessary. Fixes #78400.
526 2006-06-04 Marek Safar <marek.safar@seznam.cz>
528 * parameter.cs (Parameter.ApplyAttributeBuilder): More DefaultValue
529 attribute applicable tests for attribute argument.
531 2006-06-02 Raja R Harinath <rharinath@novell.com>
534 * expression.cs (Binary.DoNumericPromotions): Remove and rewrite.
535 (Binary.OverloadResolve_PredefinedIntegral): New.
536 (Binary.OverloadResolve_PredefinedFloating): New.
537 (Binary.OverloadResolve_PredefinedString): New.
538 (Binary.ResolveOperator): Use those instead of DoNumericPromotions.
539 Follow the standard more closely, and treat numeric promotions in
540 terms of overload resolution.
541 (Binary.CheckShiftArguments): Simplify.
543 2006-06-01 Raja R Harinath <rharinath@novell.com>
545 * flowanalysis.cs (MyBitVector): Simplify representation.
546 (MyBitVector.Clone): Avoid allocating BitArray.
547 (MyBitVector.operator&): Rename from MyBitVector.And and make symmetric.
548 (MyBitVector.operator|): Likewise, with MyBitVector.Or.
549 (*): Update. Change all references to MyBitVector.And and
550 MyBitVector.Or to &= and |=.
552 2006-05-31 Raja R Harinath <rharinath@novell.com>
554 * generic.cs (Nullable.LiftedBinaryOperator.EmitEquality):
555 Use bne.un instead of ceq+brfalse.
558 * typemanager.cs (IsUnmanagedType): Disallow generic types and
561 2006-05-29 Raja R Harinath <rharinath@novell.com>
564 * cs-parser.jay (formal_parameter_list): Extend the pattern below
565 to param arguments too.
567 2006-05-26 Miguel de Icaza <miguel@novell.com>
569 * cs-parser.jay: Catch another parsing form for arglist being
570 followed by other arguments. Fixes #78313.
572 2006-05-25 Raja R Harinath <rharinath@novell.com>
575 * expression.cs (Binary.DoResolve): Use Nullable.LiftedBinaryOperator
576 also when one of the operands is a null literal.
577 * generic.cs (Nullable.LiftedBinaryOperator.EmitEquality): Rewrite
578 to improve clarity, and generate slightly better code.
580 2006-05-24 Raja R Harinath <rharinath@novell.com>
582 * flowanalysis.cs (FlowBranchingToplevel.AddReturnOrigin): Move
583 checking of out parameters to ...
584 (FlowBranchingToplevel.Merge): ... here.
585 (FlowBranchingException.AddBreakOrigin): If 'finally_vector' is
586 set, propagate the origin upward, and only complain if there was
588 (FlowBranchingException.AddContinueOrigin): Likewise.
589 (FlowBranchingException.AddReturnOrigin): Likewise.
590 (FlowBranchingException.AddGotoOrigin): Likewise.
592 2006-05-23 Raja R Harinath <rharinath@novell.com>
594 * flowanalysis.cs (UsageVector.MergeOrigins): If an origin is
595 unreachable, skip it.
596 (FlowBranchingException.Merge): Always propagate jumps, even if
597 the finally block renders subsequent code unreachable.
599 2006-05-18 Raja R Harinath <rharinath@novell.com>
602 * statement.cs (Goto.Resolve): Move responsibility for resolving
603 'goto' to FlowBranching.AddGotoOrigin.
604 (Goto.SetResolvedTarget): New. Callback to set the
605 LabeledStatement that's the target of the goto.
606 (Goto.DoEmit): Use Leave instead of Br when crossing an
607 unwind-protect boundary.
608 * flowanalysis.cs (FlowBranching.AddGotoOrigin): Rename from
609 LookupLabel and adjust to new semantics.
610 (FlowBranchingToplevel.AddGotoOrigin): Likewise.
611 (FlowBranchingBlock.AddGotoOrigin): Likewise. Use
612 Goto.SetResolvedTarget to update target.
613 (FlowBranchingLabeled.AddGotoOrigin): Likewise.
614 (FlowBranchingException.AddGotoOrigin): Rewrite to be similar to
615 AddBreakOrigin & co. Delay propagation until ...
616 (FlowBranchingException.Merge): ... this.
618 * statement.cs (Block.Resolve): Always depend on flow-branching to
619 determine unreachability. Kill workaround that originally emitted
620 only one statement after an "unreachable" label (see infloop in
623 Fix #77869, #76148, #77755, #75255 and a host of other bugs.
624 This is still "wrong", but anything better would probably need a
625 multi-pass algorithm.
626 * flowanalysis.cs (FlowBranchingLabeled): Salt away a copy of the
627 usage vector. Force current usage vector to be reachable, to
628 optimistically signify backward jumps.
629 (FlowBranchingLabeled.LookupLabel): Note if a backward jump is
631 (FlowBranchingLabeled.Merge): New. If no backward jump was
632 detected, return the original salted-away usage vector instead,
633 updated with appropriate changes. Print unreachable warning if
635 * statement.cs (Block.Resolve): Don't print unreachable warning on
638 2006-05-17 Gert Driesen <drieseng@users.sourceforge.net>
640 * driver.cs: Pass filename without path to AssemblyBuilder's
641 AddResourceFile. Fixes bug #78407.
643 2006-05-17 Raja R Harinath <rharinath@novell.com>
645 * statement.cs (LabeledStatement.Resolve): Move merging of origins ...
646 * flowanalysis.cs (FlowBranchingLabeled): ... here.
647 (FlowBranching.MergeChild): Overwrite
648 reachability information from Labeled branchings too.
650 2006-05-16 Raja R Harinath <rharinath@novell.com>
652 * statement.cs (Goto.Resolve): Merge jump origins here ...
653 * flowanalysis.cs (FlowBranching.Label): ... rather than here.
655 * flowanalysis.cs (FlowBranching.LookupLabel): Move CS0159 check ...
656 (FlowBranchingToplevel.LookupLabel): ... here. Add CS1632 check.
657 (FlowBranchingGoto.LookupLabel): New. Handle back jumps.
658 (FlowBranchingBlock.LookupLabel): Call LabeledStatement.AddReference
660 * statement.cs (Goto.Resolve): ... not here.
661 (Goto.Emit): Remove CS1632 check.
663 2006-05-14 Marek Safar <marek.safar@seznam.cz>
665 * ecore.cs (Expression.ResolveAsTypeTerminal): Fixed type in the obsolete
668 2006-05-11 Raja R Harinath <rharinath@novell.com>
670 * flowanalysis.cs (UsageVector.MergeJumpOrigins): Kill.
671 (FlowBranchingBlock.Label): Use UsageVector.MergeOrigins.
672 (FlowBranchingException.Label): Likewise.
674 * flowanalysis.cs (MyBitVector.SetAll): New. Sets all bits to the
676 (MyBitVector.Or): Use it to avoid losing information (Count).
677 (FlowBranching.MergeOrigins): Likewise.
679 * flowanalysis.cs (UsageVector.IsDirty): Remove.
680 (UsageVector.Parameters, UsageVector.ParameterVector): Likewise.
681 (UsageVector.Locals, UsageVector.LocalVector): Likewise.
682 (UsageVector.ToString): Simplify.
683 (UsageVector.MergeSiblings): Move here from ...
684 (FlowBranching.Merge): ... here.
685 (FlowBranchingToplevel.CheckOutParameters): Take an UsageVector,
688 2006-05-10 Raja R Harinath <rharinath@novell.com>
690 * flowanalysis.cs (UsageVector.MergeOrigins): Simplify, now that a
691 null bitvector is treated as all-true.
693 * flowanalysis.cs (MyBitVector.And, MyBitVector.Or): Make lazier.
694 (MyBitVector): Rationalize invariants. 'vector != null' implies
695 that we have our own copy of the bitvector. Otherwise,
696 'InheritsFrom == null' implies all inherited bits are true.
698 2006-05-09 Marek Safar <marek.safar@seznam.cz>
700 * statement.cs (LocalInfo): Add IsConstant.
701 (LocalInfo.DeclareLocal): Moved from EmitMeta and changed to don't emit
702 local variable for constants.
704 2006-05-09 Raja R Harinath <rharinath@novell.com>
706 * flowanalysis.cs (MyBitVector.Empty): New.
707 (MyBitVector): Don't allow InheritedFrom to be null.
708 (MyBitVector.And, MyBitVector.Or): Treat 'null' as all-ones.
709 (UsageVector, FlowBranching): Update to changes.
711 * flowanalysis.cs (FlowBranching.InTryWithCatch): Don't terminate
712 recursion. The 'Parent == null' condition isn't sufficient for
714 (FlowBranching.AddBreakOrigin): Likewise.
715 (FlowBranching.AddContinueOrigin): Likewise.
716 (FlowBranching.AddReturnOrigin): Likewise.
717 (FlowBranching.StealFinallyClauses): Likewise.
718 (FlowBranching.MergeTopBlock): Move to FlowBranchingToplevel.
719 (FlowBranching.CheckOutParameters): Likewise.
720 (FlowBranchingToplevel): Terminate all the above recursions here.
721 (FlowBranchingToplevel.End): Rename from MergeTopBlock.
722 * codegen.cs (EmitContext.ResolveTopBlock): Update to changes.
724 * flowanalysis.cs (BranchingType.Toplevel): New. Represents a
726 (FlowBranchingToplevel): New. Empty for now.
727 (FlowBranching.MergeTopBlock): Update.
728 * codegen.cs (EmitContext.ResolveTopBlock): Create a Toplevel
729 branching for the anonymous delegate.
730 (EmitContext.StartFlowBranching): Add ToplevelBlock variant.
732 * flowanalysis.cs (UsageVector.MergeOrigins): Reorganize.
733 (UsageVector.MergeJumpOrigins): Don't ignore current reachability
734 information at the start of the merge. Reorganize.
736 2006-05-07 Marek Safar <marek.safar@seznam.cz>
738 * class.cs (MethodData.Define): Method cannot implement interface accessor.
740 2006-05-07 Marek Safar <marek.safar@seznam.cz>
742 * expression.cs (QualifiedAliasMember.ResolveAsTypeStep): Pass location
743 to newly introduced ctor.
745 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Moved an error
746 message to one place.
747 (GlobalRootNamespace.Error_NamespaceDoesNotExist): Custom message for
750 2006-05-07 Marek Safar <marek.safar@seznam.cz>
752 * const.cs (Const.Error_ExpressionMustBeConstant): Better error message.
754 * ecore.cs (Expression.ResolveAsConstant): Updated.
756 * statement.cs (ResolveMeta): Updated.
758 2006-05-06 Marek Safar <marek.safar@seznam.cz>
760 * cs-parser.jay: __arglist cannot be used in initializer.
762 2006-05-06 Marek Safar <marek.safar@seznam.cz>
765 * namespace.cs (LocalAliasEntry.DoResolve): Don't allow to access nested
768 2006-05-05 Raja R Harinath <rharinath@novell.com>
770 * statement.cs (EmptyStatement.ResolveUnreachable): Override.
771 (LabeledStatement): Add 'name' parameter.
772 (LabeledStatement.Name, LabeledStatement.JumpOrigins): New.
773 (Block.AddLabel): Update to changes.
774 * cs-parser.jay (labeled_statement): Likewise.
776 * flowanalysis.cs (BranchingType.Labeled): New.
777 (UsageVector.MergeOrigins): Remove unused 'branching' argument.
778 (FlowBranchingLabeled): New. Does nothing for now, but will
779 eventually handle 'goto' flows.
780 * codegen.cs (StartFlowBranching): Add new LabeledStatement variant.
781 * statement.cs (LabeledStatement.Resolve): Create a FlowBranching
782 that's terminated ...
783 (Block.Resolve): ... here.
785 * flowanalysis.cs (UsageVector.MergeFinally): Remove.
786 (UsageVector.MergeFinallyOrigins): Likewise.
787 (FlowBranching.InTryOrCatch): Likewise.
788 (FlowBranching.AddFinallyVector): Likewise.
789 (FlowBranchingException): Update to changes.
792 * statement.cs (Return.Resolve): Move error checking to ...
793 * flowbranching.cs (FlowBranching.AddReturnOrigin): ... this.
794 (FlowBranchingException): Handle return origins like break and
796 (FlowBranching.UsageVector.CheckOutParameters): Remove.
798 2006-05-04 Marek Safar <marek.safar@seznam.cz>
801 * class.cs (TypeContainer.FindMembers): Includes event method in the methods
804 2006-05-04 Marek Safar <marek.safar@seznam.cz>
807 * class.cs (MethodData.Define): Do public accessor check only when method
808 implements an interface.
810 2006-05-04 Raja R Harinath <rharinath@novell.com>
812 Remove special handling of 'break'
813 * flowanalysis.cs (Reachability): Remove all mention of 'breaks'.
814 (Reachability.Meet): Simplify. Remove 'do_breaks' argument.
815 (UsageVector.Break): Remove.
816 (FlowBranching.Merge): Use 'Reachable.IsUnreachable' to determine
818 (FlowBranchingBreakable.Merge): Don't ResetBreaks.
820 * statement.cs (Break.Resolve): Call UsageVector.Goto (), not
821 UsageVector.Breaks (). Don't set NeedsReturnLabel.
823 2006-05-03 Marek Safar <marek.safar@seznam.cz>
826 * pending.cs (PendingImplementation.BaseImplements): A found member cannot
827 be the interface member.
829 2006-05-03 Marek Safar <marek.safar@seznam.cz>
832 * constant.cs (LongConstant.EmitLong): Fixed to catch also negative values
833 for emitting small (int) values.
835 2006-05-03 Raja R Harinath <rharinath@novell.com>
838 * flowanalysis.cs (FlowBranchingException.Merge): Ensure
839 control-flow passes through the 'finally' after merging-in all the
840 control-flows from 'try' and the 'catch' clauses.
842 * flowanalysis.cs (FlowBranching.IsLoop): Remove.
843 (FlowBranching.IsTryOrCatch): Remove 'is_return' parameter. It's
844 always true at the only non-recursive entry point.
845 (FlowBranching.CreateBranching) [BranchingType.Loop]: Return a
846 FlowBranchingBreakable.
847 (FlowBranchingLoop): Remove.
848 * statement.cs (Return.DoResolve): Update to changes.
851 * flowanalysis.cs (FlowBranching.BranchingType.Embedded): New.
852 (FlowBranching.CreateBranching): Handle it: create a
853 FlowBranchingContinuable.
854 (FlowBranching.BreakCrossesExceptionBoundary): Remove.
855 (FlowBranching.AddContinueOrigin): Similar to AddBreakOrigin,
856 except that it handles the 'continue' command.
857 (FlowBranching.UsageVector.MergeOrigins): Rename from
859 (FlowBranchingContinuable): Similar to FlowBranchingBreakable,
860 except that it overrides AddContinueOrigin.
861 (FlowBranchingException): Override AddContinueOrigin, similar to
863 * statement.cs (While.Resolve, Foreach.ArrayForeach.Resolve):
864 Create a new branching around the embedded statement.
865 (Do.Resolve, For.Resolve): Likewise. Do reachability analysis for
866 control flow after the embedded statement.
867 (Continue.Resolve): Move all error checking to AddContinueOrigin.
869 * flowanalysis.cs (FlowBranching.IsSwitch): Remove.
870 (FlowBranching.CreateBranching) [BranchingType.Switch]: Create a
871 FlowBranchingBreakable.
872 (FlowBranchingSwitch): Remove.
875 * statement.cs (Break.Resolve): Simplify. Move responsibility for
876 error reporting to ...
877 * flowanalysis.cs (FlowBranching.AddBreakOrigin) ... this.
878 Rename from 'AddBreakVector'. Add new location argument. Return
879 a bool indicating whether the 'break' crosses an unwind-protect.
880 (FlowBranchingException.AddBreakOrigin): Add.
881 (FlowBranchingException.Merge): Propagate 'break's to surrounding
882 flowbranching after updating with the effects of the 'finally'
884 (FlowBranchingBreakable): New common base class for
885 FlowBranchingLoop and FlowBranchingSwitch.
887 * statement.cs (Foreach.ArrayForeach.Resolve): Set barrier after
889 (Foreach.CollectionForeach.Resolve): Remove extraneous flowbranching.
891 2006-05-02 Raja R Harinath <rharinath@novell.com>
893 * statement.cs (Do.Resolve): If the loop is infinite, set the
895 (While.Resolve, For.Resolve): Set a barrier after the embedded
896 statement. There's no direct control flow that goes from the end
897 of the embedded statement to the end of the loop.
898 * flowanalysis.cs (FlowBranching.Infinite): Remove.
899 (FlowBranchingLoop.Merge): Don't look at 'Infinite'. The changes
900 above ensure that the reachability is correctly computed.
902 * flowanalysis.cs (Reachability.ResetBarrier): Remove.
903 (UsageVector.MergeBreakOrigins): If the current path is
904 unreachable, treat it as if all parameters/locals are initialized.
905 (FlowBranchingLoop.Merge): Don't clear any barriers. Handle
906 infinite loops before merging-in break origins.
908 * flowanalysis.cs (Reachability.Meet): Simplify code handling 'returns'.
909 (Reachability.Reachable): Split part into ...
910 (Reachability.Unreachable): ... this. Simplify.
911 (Reachability.IsUnreachable): Use 'Unreachable' instead.
913 * flowanalysis.cs (Reachability.SetReturnsSometimes): Remove.
914 (Reachability.SetThrowsSometimes): Likewise.
915 (FlowBranchingBlock.MergeTopBlock): Don't compare against
916 TriState.Always, use corresponding property.
917 * statement.cs (Lock.Resolve, Try.Resolve, Using.Resolve): Likewise.
918 (Block.Resolve): Likewise. Remove some redundant checks.
920 2006-05-02 Raja R Harinath <harinath@gmail.com>
922 * flowanalysis.cs (UsageVector.Throw): Set barrier too.
923 (Reachability.Meet): Don't bother checking AlwaysThrows --
924 barrier is always set.
925 (FlowBranchingBlock.Merge): Likewise.
927 2006-05-01 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
929 * attribute.cs: fixed_buffer_cache is declared only if NET_2_0 is
930 defined, so it's references should also compile only for NET_2_0
931 (as occurs in mcs version)
933 2006-05-01 Raja R Harinath <harinath@gmail.com>
935 * codegen.cs (EmitContext.ResolveTopBlock): Remove redundant
936 checks for unreachable.
938 2006-05-01 Marek Safar <marek.safar@seznam.cz>
941 * flowanalysis.cs (UsageVector.IsAssigned): Add flag to ignore short path.
943 * statement.cs (Block.UsageWarning): Uses newly introduced flag to detect
944 whether field is really assigned.
946 2006-04-30 Raja R Harinath <harinath@gmail.com>
948 * flowanalysis.cs (Reachability): Make 4-argument constructor
950 (Reachability.Meet): Rename from 'And'. Remove static variant.
951 (Reachability.Always): Rename from the highly misleading
952 'Reachability.Never'.
953 (FlowBranching.Merge): Update to changes. Mark an impossible
954 situation with a 'throw'.
955 (*): Update to changes.
957 2006-04-29 Raja R Harinath <harinath@gmail.com>
959 * flowanalysis.cs (TriState): Rename from FlowBranching.FlowReturns.
961 (FlowBranching.TriState_Meet): Rename from AndFlowReturns. Simplify.
962 (FlowBranching.TriState_Max): Rename from OrFlowReturns. Simplify.
963 (*): Update to changes.
964 * statement.cs: Update to changes.
966 2006-04-28 Marek Safar <marek.safar@seznam.cz>
969 *class.cs (Method.FindOutBaseMethod): Base method cannot be property method.
971 2006-04-28 Raja R Harinath <harinath@gmail.com>
973 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't create a
976 * flowanalysis.cs (UsageVector.MergeChild): Change FlowBranching
977 argument to two arguments: an usage-vector and a bool. Move call
978 to FlowBranching.Merge () ...
979 (FlowBranching.MergeChild, FlowBranching.MergeTopBlock): ... here.
981 * flowanalysis.cs (UsageVector.MergeChild): Move special-case
982 handling of loop and switch reachability to ...
983 (FlowBranchingLoop.Merge, FlowBranchingSwitch.Merge): ... these.
985 2006-04-27 Raja R Harinath <harinath@gmail.com>
987 * flowanalysis.cs (FlowBranching.InLoop): Move special-case
988 handling to FlowBranchingLoop.InLoop.
989 (FlowBranching.InSwitch): Likewise, to FlowBranchingSwitch.
991 2006-04-26 Marek Safar <marek.safar@seznam.cz>
994 * anonymous.cs (AnonymousMethod.DoResolve): Moved the check whether
995 anonymous method is allowed from AnonymousContainer here.
997 * attribute.cs, codegen.cs (EmitContext): Add IsAnonymousMethodAllowed.
999 2006-04-24 Raja R Harinath <rharinath@novell.com>
1002 * flowanalysis.cs (MyBitVector.Or): Add null check on argument.
1004 2006-04-23 Marek Safar <marek.safar@seznam.cz>
1007 * constant.cs (FloatConstant.Reduce): Add range checking for checked context.
1008 (DoubleConstant.Reduce): Ditto.
1010 2006-04-23 Raja R Harinath <rharinath@novell.com>
1012 * expression.cs (LocalVariableReference.DoResolveBase): Simplify.
1013 Remove 'lvalue_right_side' argument. Move parts to ...
1014 (LocalVariableReference.ResolveLocalInfo, LocalVariable.DoResolve)
1015 (LocalVariable.DoResolveLValue): ... these.
1017 2006-04-21 Raja R Harinath <rharinath@novell.com>
1020 * codegen.cs (EmitContext.InRefOutArgumentResolving): Remove.
1021 * expression.cs (EmptyExpression.LValueMemberOutAccess): New.
1022 (LocalVariableReference.DoResolveBase): Use it to implement new
1024 (IndexerAccess.DoResolveLValue): Handle LValueMemberOutAccess.
1025 (Argument.Resolve): Simplify. Move CS1510 check ...
1026 * ecore.cs (Expression.ResolveLValue): ... here.
1027 (UnboxCast.DoResolveLValue): Handle LValueMemberOutAccess.
1028 (PropertyExpr.DoResolveLValue): Likewise.
1029 (FieldExpr.Report_AssignToReadonly): Likewise.
1030 (FieldExpr.DoResolve): Add 'out_access' argument. Use
1031 LValueMemberAccess or LValueMemberOutAccess on instance depending
1033 (FieldExpr.DoResolveLValue): Pass 'out_access' argument to
1034 DoResolve as appropriate.
1036 2006-04-20 Raja R Harinath <rharinath@novell.com>
1039 * expression.cs (Invocation.VerifyArgumentsCompat): Don't try
1040 implicit conversions on 'out' and 'ref' arguments.
1042 * expression.cs (Invocation.VerifyArgumentsCompat): Reorganize to
1043 improve clarity. Remove dead code.
1046 * statement.cs (Block.UsageWarning): Allow VariableInfo to be null.
1047 (Catch.Resolve): Resolve VarBlock if it exists.
1049 2006-04-19 Miguel de Icaza <miguel@novell.com>
1051 * statement.cs (Foreach.EmitFinally): Do not emit the enumerator
1052 twice, this was some residual code, the enumerator was emitted
1053 properly in the two branche of if later.
1057 Thanks to Martin for finding the source of the problem
1059 2006-04-19 Raja R Harinath <rharinath@novell.com>
1061 * expression.cs (Cast.ResolveLValue): Remove. The result of a
1062 cast is never an lvalue.
1063 (Cast.DoResolve, Cast.ResolveRest): Combine.
1064 (Argument.Emit): Simplify slightly. Move 'Expr is
1065 IMemoryLocation' check ...
1066 (Argument.Resolve): ... here.
1067 (Argument.Error_LValueRequired): Remove. Inline into only user.
1069 Simplifications. Fix cs0191-2.cs
1070 * ecore.cs (FieldExpr.DoResolve): Move handling of CS0192, CS0198,
1071 CS1649 and CS1651 to ...
1072 (FieldExpr.Report_AssignToReadonly): ... this. Simplify by moving
1073 the actual selection of the error code and message to a lookup
1074 table. Add a dummy return value to simplify callsites.
1075 (FieldExpr.ResolveLValue): Don't allow a constructor to write to
1076 readonly fields of other instances of the same type. Move CS0197
1078 * expression.cs (Argument.Resolve): ... here. Simplify code.
1079 Ensure that ec.InRefOutArgumentResolving is only set during LValue
1080 resolution of an out or ref argument. The code simplification
1081 above uses this invariant.
1083 2006-04-18 Raja R Harinath <rharinath@novell.com>
1085 Possibly fix #77752. Fix cs1690-[4-7].cs.
1086 * ecore.cs (Expression.CheckMarshalByRefAccess): Renamed from
1087 CheckMarshallByRefAccess. Drop parameter.
1088 (FieldExpr.CheckMarshalByRefAccess): Update. Change CS1690 to a
1090 (FieldExpr.DoResolve): Call CheckMarshalByRefAccess on
1092 * report.cs (AllWarnings): Add CS1690.
1093 * expression.cs (Argument.Resolve): Use EmptyExpression.OutAccess
1095 (LocalVariableReference.DoResolveBase): Update.
1097 2006-04-09 Marek Safar <marek.safar@seznam.cz>
1099 * class.cs (MethodOrOperator): Moved common parts from method class.
1100 detect obsolete attributes.
1101 (Method.Define): Simplified as it reuses code from base.
1102 (Constructor.ValidAttributeTargets): Fixed issue found during
1104 (Destructor.ValidAttributeTargets): Fixed issue found during
1106 (Operator): Finished refactoring set off by #78020. Operator class is now
1107 ordinary method class.
1109 * anonymous.cs: Updated.
1111 2006-04-09 Marek Safar <marek.safar@seznam.cz>
1113 * class.cs (Constructor.Emit): Don't emit the attributes twice.
1115 2006-04-09 Marek Safar <marek.safar@seznam.cz>
1117 * class.cs (Operator.Emit): Extracted code from MethodData to correctly
1118 detect obsolete attributes.
1119 (Method.CreateEmitContext): Moved to MethodOrOperator.
1121 2006-04-09 Marek Safar <marek.safar@seznam.cz>
1124 * class.cs (TypeContainer.MemberCoreArrayList.DefineContainerMembers): Throw
1125 customized exception to make crash detection easier.
1126 (MethodOrOperator): Started to work on new base class for methods and
1128 (Method): Derives from MethodOrOperator.
1129 (Constructor.Emit): Emits its own attributes.
1130 (AbstractPropertyEventMethod.Emit): Ditto.
1131 (Operator): Derives from MethodOrOperator, will refactor fully in extra
1133 (Operator.Emit): It's temporary more tricky than should be.
1135 * doc.cs (GetMethodDocCommentName): Updated after operator changes.
1137 * report.cs (InternalErrorException): Add ctor with inner exception.
1139 2006-04-08 Marek Safar <marek.safar@seznam.cz>
1142 * ecore.cs (SimpleName.ResolveAsTypeStep): Report better error when type is
1145 2006-04-07 Marek Safar <marek.safar@seznam.cz>
1148 * expression.cs (ArrayCreation.GetAttributableValue): Creates correctly typed
1151 2006-04-06 Marek Safar <marek.safar@seznam.cz>
1153 * class.cs (Class.ApplyAttributeBuilder): Report an error when ComImport
1154 attribute is present and Guid not.
1155 (Interface.ApplyAttributeBuilder): Ditto.
1157 * attribute.cs: Add error message.
1159 2006-04-06 Marek Safar <marek.safar@seznam.cz>
1163 * attribute.cs (Attribute.AttachTo): The attribute can have multiple
1164 sources (it's composite) so hold them in extra array as they are used in
1165 Emit phase only. It worked in the previous versions by mistake.
1166 (Attribute.Emit): Emit attribute for more owners when exist.
1168 * codegen.cs, class.cs: Updated to don't re-attach attribute twice as now
1169 it has now different behaviour.
1171 2006-04-04 Marek Safar <marek.safar@seznam.cz>
1173 * constant.cs (Constant.IsDefaultInitializer): New method.
1175 * class.cs: Updated.
1177 * expression.cs (ArrayCreation.CheckIndices): Add an optimization to don't
1178 re-initialize default values. It saves KBs almost for every assembly.
1179 Thanks Zoltan for the idea.
1180 (ArrayCreation.ResolveInitializers): Renamed from ValidateInitializers.
1181 (ArrayCreation.DoResolve): Resolve only once.
1182 (ArrayCreation.Emit): Emit static initializer only when it is faster.
1183 (ArrayCreation.GetAttributableValue): Cope with optimized values.
1185 2006-04-03 Zoltan Varga <vargaz@gmail.com>
1187 * report.cs (Warning, Error): Add 0-, 1-, and 2- argument specializations.
1190 2006-04-01 Marek Safar <marek.safar@seznam.cz>
1192 * assign.cs (Assign.DoResolve): Assignment to same variable can occur
1193 in an embedded statement too.
1195 2006-04-01 Raja R Harinath <rharinath@novell.com>
1198 * typemanager.cs (IsNestedChildOf): Drop generic arguments before
1202 * statement.cs (Switch.EmitObjectInteger) [ulong]: Remove bad cast.
1205 * report.cs (SymbolRelatedToPreviousError): Drop generic type
1206 arguments before checking whether a type is reflected or not.
1209 * expression.cs (Invocation.IsApplicable): Ensure a generic method
1210 definition doesn't take part in overload resolution.
1211 (Invocation.IsParamsMethodApplicable): Likewise.
1212 (Invocation.OverloadResolve): When replacing a reflected override
1213 method with its base definition, ensure that type arguments are
1216 2006-04-01 Marek Safar <marek.safar@seznam.cz>
1220 * class.cs (TypeContainer.AddPartial): Don't report an error when modifier
1223 * modifiers.cs: Add DEFAULT_ACCESS_MODIFER.
1225 2006-03-31 Marek Safar <marek.safar@seznam.cz>
1227 * assign.cs (LocalTemporary): Don't require ILGenerator in the resolve
1230 * anonymous.cs, assign.cs, ecore.cs, expression.cs: Updated after
1231 LocalTemporary change.
1233 * class.cs (ClassOrStruct.DefineDefaultConstructor): Moved from
1235 (ClassOrStruct.DefineFieldInitializers): Implemented static field
1236 initializers optimization.
1237 (ClassOrStruct.TypeAttr): Moved from modifiers.
1238 (Constructor.CheckBase): Don't crash when static ctor has parameters.
1239 (FieldBase.ResolveInitializer): Resolves initializer.
1240 (FieldBase.HasDefaultInitializer): New property.
1242 * cs-parser.jay: Removed message.
1244 * expression.cs (CompilerGeneratedThis): New specialization.
1246 * modifiers.cs (TypeAttr): Moved to ClassOrStruct.TypeAttr
1248 2006-03-28 Marek Safar <marek.safar@seznam.cz>
1250 * cs-parser.jay, cs-tokenizer.cs: On demand Stack allocation.
1252 2006-03-27 Marek Safar <marek.safar@seznam.cz>
1254 * ecore.cs (Expression.ResolveAsConstant): Clean up, enum constants should
1255 be now EnumConstants only.
1257 2006-03-27 Marek Safar <marek.safar@seznam.cz>
1259 * attribute.cs, driver.cs: Reset more caches.
1261 2006-03-26 Marek Safar <marek.safar@seznam.cz>
1263 * cs-tokenizer.cs (adjust_real): Uses float.Parse for float literals.
1265 2006-03-26 Marek Safar <marek.safar@seznam.cz>
1267 * constant.cs (Constant.Reduce): Replaced EmitContext with single bool
1268 for easier reuse. Updated all overrides.
1269 (IntegralConstant): New base class for all integral constants.
1270 (IntegralConstant.Error_ValueCannotBeConverted): When assigned value if out
1271 of the constant range, report custom error.
1272 (UIntConstant.Reduce): Fixed uint conversion.
1274 * ecore.cs, literal.cs: Reduce updates.
1276 2006-03-26 Marek Safar <marek.safar@seznam.cz>
1280 * class.cs (Constructor.Define): Removed extra if for default ctors.
1281 A patch from Atsushi Enomoto.
1283 2006-03-26 Marek Safar <marek.safar@seznam.cz>
1285 * attribute.cs (Attribute.ResolveConstructor): Conversion was moved to
1286 GetAttributableValue.
1288 * constant.cs (Constant.GetAttributableValue): Does implicit conversion
1291 * convert.cs (ImplicitConversionRequired): Error message moved to
1294 * ecore.cs (Expression.GetAttributableValue): Add type parameter for
1295 automatic implicit conversion of an output value.
1296 (EnumConstant.GetAttributableValue): Don't reduce the enum constants.
1298 * expression.cs (ArrayCreation.GetAttributableValue): Add element type
1300 (TypeOf.GetAttributableValue): Add extra handling for object type.
1302 * literal.cs (DoubleLiteral.Error_ValueCannotBeConverted): Doubles can have
1303 special error message.
1305 2006-03-25 Marek Safar <marek.safar@seznam.cz>
1307 * class.cs (Constructor.Emit): Don't crash when struct ctor is
1309 (Constructor.ApplyAttributeBuilder): Transform MethodImplAttribute to be
1310 compatible with MS runtime.
1312 2006-03-23 Marek Safar <marek.safar@seznam.cz>
1314 * attribute.cs (Attribute.ResolveConstructor): Check for an invalid
1315 attribute arguments here.
1317 * class.cs (Indexer.Define): The check was moved to attribute class.
1319 2006-03-21 Marek Safar <marek.safar@seznam.cz>
1321 * expression.cs (StringConcat.Append): Reverted back to no warning state.
1323 2006-03-21 Marek Safar <marek.safar@seznam.cz>
1325 * const.cs (Error_ConstantCanBeInitializedWithNullOnly): Share a message.
1327 * statement.cs (Block.ResolveMeta): Look for wrong object constants in
1330 2006-03-21 Atsushi Enomoto <atsushi@ximian.com>
1332 * doc-bootstrap.cs : fix build.
1334 2006-03-20 Marek Safar <marek.safar@seznam.cz>
1336 * expression.cs (StringConcat.Append): Issue a warning when empty string
1339 2006-03-20 Marek Safar <marek.safar@seznam.cz>
1341 * assign.cs (CompoundAssign.ResolveSource): Removed.
1343 * attribute.cs (ResolvePossibleAttributeType): Updated after MemberAccess
1346 * class.cs (TypeContainer.FindMethods): Removed.
1347 (TypeContainer.CheckMemberUsage): Made static.
1349 * codegen.cs (GetAssemblyName): Uses Length for empty string test.
1351 * constant.cs (CheckRange): Removed unused type argument.
1352 (CheckUnsigned): Removed unused type argument.
1354 * cs-parser.jay: Updated after MemberAccess clean up.
1355 Uses Length for empty string test.
1357 * cs-tokenizer.cs: Uses Length for empty string test.
1358 (IsCastToken): Made static.
1359 (is_hex): Made static.
1360 (real_type_suffix): Made static.
1362 * decl.cs (SetupCache): Made static.
1363 (OnGenerateDocComment): Removed unused ds argument.
1365 * delegate.cs (VerifyDelegate): Removed unused argument.
1367 * doc.cs: Uses Length for empty string test.
1369 * driver.cs: Uses Length for empty string test.
1371 * enum.cs (IsValidEnumType): Made static
1373 * expression.cs (EnumLiftUp): Removed unused argument.
1374 (ResolveMethodGroup): Ditto.
1375 (BetterConversion): Ditto.
1376 (GetVarargsTypes): Ditto.
1377 (UpdateIndices): Ditto.
1378 (ValidateInitializers): Ditto.
1379 (MemberAccess.ctor): Ditto.
1380 (GetIndexersForType): Ditto.
1382 * flowanalysis.cs: (MergeFinally): Removed unused argument.
1384 * iterators.cs: Updated after MemberAccess clean up.
1386 * location.cs: Uses Length for empty string test.
1388 * namespace.cs: Uses Length for empty string test.
1390 * report.cs (CheckWarningCode): Made static.
1392 * statement.cs (LabeledStatement): Removed unused argument.
1394 * typemanager.cs (FilterNone): Removed.
1396 2006-03-18 Marek Safar <marek.safar@seznam.cz>
1398 * codegen.cs (EmitContext.TestObsoleteMethodUsage): Removed as it become
1401 * class.cs: Updated.
1403 2006-03-18 Marek Safar <marek.safar@seznam.cz>
1405 * cs-parser.jay.cs: __arglist is not allowed for delegates.
1407 2006-03-18 Marek Safar <marek.safar@seznam.cz>
1411 * anonymous.cs.cs (AnonymousMethod): Add host to allow access to
1413 (AnonymousMethod.ImplicitStandardConversionExists): New method.
1414 (AnonymousMethod.Compatible): Moved parameter resolving to DoResolve.
1415 Add more error reporting; Fixed issue with params.
1417 * convert.cs (ImplicitStandardConversionExists): Returned conversion check.
1419 * cs-parser.jay: AnonymousMethod requires host container.
1421 * delegate.cs (NewDelegate.DoResolve): Updated after Compatible changes.
1423 2006-03-18 Raja R Harinath <harinath@gmail.com>
1425 * class.cs: Change 'TypeContainer ds' constructor argument to
1426 'DeclSpace parent'. Some classes were missed below due to
1427 different naming convention.
1429 * class.cs (MemberCore.Parent): Delete. This makes the
1430 ParentContainer changes below enforceable by the compiler.
1432 Treat pointers to enclosing declaration space as 'DeclSpace', not
1434 * class.cs, const.cs, delegate.cs, enum.cs, iterator.cs: Change
1435 'TypeContainer parent' constructor argument to 'DeclSpace parent'.
1437 * statement.cs (LocalInfo..ctor): Use DeclSpace argument instead
1439 (Block.AddThisVariable): Likewise.
1440 * class.cs (MethodData.Define, MethodData.Emit): Likewise.
1441 (AbstractPropertyEventMethod.Emit): Likewise.
1442 (AbstractPropertyEventMethod.EmitMethod): Likewise.
1443 (GetMethod.Define, SetMethod.Define): Likewise.
1444 (PropertyMethod.Define, DelegateMethod.Define): Likewise.
1445 (DelegateMethod.EmitMethod): Likewise.
1447 Fix regression test-partial-13.cs.
1448 Rationalize use of PartialContainer. Ensure that the partial
1449 class semantics can be tied to type-correctness, i.e., any
1450 violation will cause a compile error.
1451 * class.cs, const.cs: Access all fields that belong to class
1452 TypeContainer via ParentContainer. Arguments of EmitContexts and
1453 Resolve()-like functions still use 'Parent'.
1455 * class.cs (SourceMethod): Use DeclSpace, not TypeContainer.
1456 (*.CreateEmitContext): Change TypeContainer argument to DeclSpace.
1457 (PropertyMethod.CheckModifiers): Remove unused argument.
1458 * codegen.cs (EmitContext..ctor): Change TypeContainer argument to
1461 2006-03-28 Raja R Harinath <rharinath@novell.com>
1463 * decl.cs (DeclSpace.LookupGeneric): Update to changes.
1465 2006-03-17 Raja R Harinath <harinath@gmail.com>
1467 Make semantics of PartialContainer simpler.
1468 * decl.cs (DeclSpace.IsPartial): Remove.
1469 * class.cs (TypeContainer.IsPartial): Likewise.
1470 (TypeContainer..ctor): Set PartialContainer to point to self.
1471 (TypeContainer.GetClsCompliantAttributeValue): Don't use IsPartial.
1472 (TypeContainer.FindNestedType): Likewise.
1473 (MemberCore.ParentContainer): Simplify. Remove deprecation.
1475 2006-03-17 Marek Safar <marek.safar@seznam.cz>
1477 * typemanager.cs.cs (GetInterfaces): Don't recreate 0-sized arrays.
1479 2006-03-15 Marek Safar <marek.safar@seznam.cz>
1481 * class.cs (FieldMember.Emit): ParentContainer is real parent for partial
1484 2006-03-15 Marek Safar <marek.safar@seznam.cz>
1486 * class.cs (Operator.Define): An error for base conversion was not
1489 2006-03-13 Marek Safar <marek.safar@seznam.cz>
1491 A fix for #77593, #77574.
1493 * class.cs (MethodCore.CheckBase): Another if for operator.
1495 2006-03-18 Marek Safar <marek.safar@seznam.cz>
1499 * expression.cs (VerifyArgumentsCompat): Reverted to double error
1500 reporting, it's more tricky than I thought.
1502 2006-03-09 Marek Safar <marek.safar@seznam.cz>
1504 * anonymous.cs (AnonymousMethod.Compatible): Don't crash when parameters
1507 * delegate.cs (Delegate.GetInvokeMethod): Use emitcontext free MemberLookup.
1508 (DelegateCreation.ImplicitStandardConversionExists): New method for just
1511 * ecore.cs (Expression.MemberLookup): Don't ask for emitcontext when it's
1514 2006-03-04 Marek Safar <marek.safar@seznam.cz>
1518 * class.cs (SetMethod.DefineParameters): Uses new parameters type ctor.
1519 (Event.Define): ditto
1520 (SetIndexerMethod.DefineParameters): Uses Parameters.MergeGenerated.
1522 * delegate.cs (Delegate.Define): Uses Parameters.MergeGenerated.
1523 Removed redundant code and set NewSlot for Invoke method too.
1525 * parameter.cs (Parameters.ctor): Add custom, type ctor.
1526 (Parameters.MergeGenerated): New method. Use this method when you merge
1527 compiler generated argument with user arguments.
1529 2006-03-03 Marek Safar <marek.safar@seznam.cz>
1531 * attribute.cs (ResolveAsTypeTerminal): Removed.
1533 * ecore.cs (Expression.ResolveAsTypeTerminal): Make virtual to allow
1534 specialization for predefined types; 30% speed up.
1535 Finally placed obsolete check to right place.
1536 (Expression.ResolveType): Removed.
1538 * enum.cs, expression.cs, parameter.cs, statement.cs, typemanager.cs:
1539 Updated after ResolveType was removed.
1541 * expression.cs (Cast.ctor): Check void cast.
1542 (Binary.ResolveAsTypeTerminal): Is never type.
1543 (Conditional.ResolveAsTypeTerminal): Is never type.
1545 * rootcontext.cs (ResolveCore): Set base type to simplify some code later.
1547 2006-03-26 Marek Safar <marek.safar@seznam.cz>
1549 * rootcontext.cs (ResolveCore): Removed System.INullableValue.
1551 2006-03-23 Martin Baulig <martin@ximian.com>
1553 * expression.cs (Is.DoResolve, As.DoResolve): Perform a dynamic
1554 type check if either of the types is an open generic type.
1556 2006-03-23 Martin Baulig <martin@ximian.com>
1559 (Convert.ExplicitTypeParameterConversion): New method; implement
1560 explicit type parameter conversions.
1562 2006-03-23 Martin Baulig <martin@ximian.com>
1564 * convert.cs (Convert.ImplicitTypeParameterConversion): Do not
1565 blindly allow all conversions if we do not have any constraints.
1567 2006-02-27 Marek Safar <marek.safar@seznam.cz>
1569 * attribute.cs (Attribute.PosArguments, Attribute.NamedArguments): Use
1570 these two separated members to simplify the code.
1571 (Attribute.Resolve): Refactored to use new fields and methods.
1572 (Attribute.ResolveConstructor): Extracted from ResolveArguments and
1573 implemented obsolete attribute checking.
1574 (Attribute.ResolveNamedArguments): Extracted from ResolveArguments and
1575 implemented obsolete checking again. It look line never ending quest ;-)
1576 (GlobalAttribute.ResolveConstructor): Need to override as the rest.
1578 * cfold.cs (BinaryFold): TryReduce throws an exception to indicate error.
1580 * constanct.cs (TryReduce): Throws OverflowException to indicate error.
1582 *class.cs (Property.Define): Add RegisterProperty call.
1584 * cs-parser.jay: Replaced ArrayList with fixed array for attribute
1585 argument groups (only 2).
1587 * ecore.cs (Expression.GetAttributableValue): New virtual method used for
1588 encoding expression to arguments.
1589 (Expression.ExprClassToResolveFlags): Just turned to property.
1591 * expression.cs (ArrayCreation.ValidateInitializers): Slightly optimized.
1592 (ArrayCreation.GetAttributableValue): Renamed from EncodeAsAttribute and
1593 optimized as well as implemented support for zero-length attributes.
1595 * typemanager.cs (TypeManager.RegisterProperty, TypeManager.GetProperty):
1596 Add caching of PropertyInfo's.
1598 2006-02-25 Marek Safar <marek.safar@seznam.cz>
1600 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Don't report
1601 error multiple times.
1603 2006-02-25 Marek Safar <marek.safar@seznam.cz>
1605 New partial class implementation.
1606 A fix for #77027, #77029, #77403
1608 * attribute.cs (Attributable): Made attributes protected.
1610 * class.cs (TypeContainer): Add PartialContainer and partial_parts as
1611 the replacements of ClassPart and PartialContainer.
1612 (TypeContainer.AddClassOrStruct): Call RecordDecl here.
1613 (TypeContainer.AddInterface): Ditto.
1614 (TypeContainer.AddPartial): The main method for partial classes. It checks
1615 for errors and merges ModFlags and attributes. At the end class is added to
1617 (TYpeContainer.DefineDefaultConstructor): Checks whether default ctor is
1619 (TypeContainer.GetClsCompliantAttributeValue): Cope with partial class too.
1620 (TypeContainer.GetNormalPartialBases): Resolves base classes and interfaces
1621 from the rest of partial classes.
1622 (TypeContainer.GetClassBases): Simplified.
1623 (TypeContainer.DefineTypeBuilder): New method, mostly extracted from
1625 (TypeContainer.DefineDefaultConstructor): Is used by derived classes.
1626 (TypeContainer.HasExplicitLayout): Uses Flags now.
1627 (PartialContainer): Removed.
1628 (ClassOrStruct.AddToContainer): Moved enclosing member name check here.
1629 (StaticClass): Was merged with Class.
1630 (Class.GetClassBases): class and static class bases are verified here.
1631 (Class.TypeAttr): Added static attributes when class is static.
1632 (Struct.RegisterFieldForInitialization): Moved from TypeContainer.
1633 (MemberBase): In some cases we need to call parent container for partial
1634 class. It should be eliminated but it's not easy now.
1636 * cs-parser.jay: Replaced all PartialContainer with AddPartial.
1638 * decls.cs (MemberCore.DocComment): Introduced new property as is used by
1639 partial classed to accumulate class comments.
1640 (MemberCore.GetClsCompliantAttributeValue): Moved from TypeContainer.
1642 * doc.cs (GenerateTypeDocComment): Partial classes clean up.
1644 * driver.cs (MainDriver): Tree.GetDecl was removed.
1646 * modifiers.cs (Modifiers): Add partial modifier.
1648 * tree.cs (Tree.decl): Removed.
1649 (RootTypes): Started to use this class more often for root types
1652 2006-03-23 Raja R Harinath <rharinath@novell.com>
1654 * generic.cs (TypeParameter.UpdateConstraints): Update
1655 'constraints' if null.
1657 2006-02-22 Marek Safar <marek.safar@seznam.cz>
1661 * attribute.cs (AttributeTester.GetCoClassAttribute): Don't crash when
1662 external interface does not have an attribute.
1664 2006-02-22 Marek Safar <marek.safar@seznam.cz>
1666 Another prerequisites for new partial classs implementation.
1668 * attribute.cs (Attribute.Equal): Implemented.
1669 (Attribute.Emit): Changed as attributes can be applied more than twice.
1670 (Attributes.Emit): Check for duplicate attributes here.
1672 * class.cs, decl.cs, delegate.cs, doc.cs, enum.cs: Don't pass DeclSpace
1673 as a parameter, clean-up.
1675 2006-02-11 Marek Safar <marek.safar@seznam.cz>
1679 * class.cs (TypeContainer.DefineType): Cannot use ResolveType because it
1680 contains obsolete attribute check which can in some cases look for base
1681 type of current class which is not initialized yet.
1682 (TypeContainer.BaseType): Replacement of ptype.
1684 * decl.cs (MemberCore.CheckObsoleteType): Reuse existing code.
1686 2006-02-11 Marek Safar <marek.safar@seznam.cz>
1688 First of prerequisites for new partial classs implemention.
1690 * attribute.cs (Attributable): Extended by ResolveContext;
1691 Attributes finally have correct context for resolving in all cases.
1692 (AttachTo): Attribute owner is assigned here.
1694 * codegen.cs (IResolveContext): Introduce new interface to hold
1695 all information needed in resolving phase.
1696 (EmitContext): Implements IResolveContext; more clean-up needed here.
1698 * decl.cs (MemberCore): Implemented IResolveContext.
1700 * anonymous.cs, attribute.cs, class.cs, codegen.cs, const.cs,
1701 decl.cs, ecore.cs, enum.cs, expression.cs, iterators.cs, namespace.cs,
1702 parameter.cs, statement.cs, tree.cs, typemanager.cs:
1703 Refactored to use new IResolveContext instead of EmitContext; cleanup
1705 2006-03-22 Raja R Harinath <rharinath@novell.com>
1707 Support ParameterDefaultValueAttribute in gmcs. Also applied to
1708 mcs to keep code differences small.
1709 * attribute.cs (Attribute.GetParameterDefaultValue): New.
1710 * typemanager.cs (parameter_default_value_attribute_type): New.
1711 * parameter.cs (Parameter.ApplyAttributeBuilder): Use them. Add
1714 2006-03-22 Martin Baulig <martin@ximian.com>
1717 (Nullable.NullableLiteral): Derive from `NullLiteral'.
1720 (Convert.TypeParameter_to_Null): Create a `Nullable.NullableLiteral'
1721 instead of the normal `NullLiteral'.
1723 2006-03-21 Martin Baulig <martin@ximian.com>
1726 * generic.cs (TypeManager.InferType): If `pt' is a generic
1727 parameter, don't check whether `pt == at'.
1729 2006-03-20 Raja R Harinath <rharinath@novell.com>
1732 * generic.cs (Constraints.Resolve): Change argument to IResolveContext.
1733 (TypeParameter.Resolve): Update to change.
1734 (ConstraintChecker.CheckConstraints): Resolve type-argument
1735 constraints before use.
1737 2006-03-16 Martin Baulig <martin@ximian.com>
1740 (ConstraintChecker.HasDefaultConstructor): If we're a TypeBuilder
1741 and don't have any instance constructors, also lookup in the base class.
1742 (TypeManager.IsNullableValueType): New public method.
1744 * typemanager.cs (TypeManager.MemberLookup_FindMembers): Clear the
1745 `BindingFlags.DeclaredOnly' flag and set `used_cache'.
1746 (TypeManager.TryGetBaseDefinition): Use DropGenericMethodArguments().
1748 * expression.cs (Unary.DoResolve): Use TypeManager.IsNullableValueType()
1749 instead of just TypeManager.IsNullableType() to determine whether
1750 a lifted operator exists.
1751 (UnaryMutator.DoResolve): Likewise.
1752 (Conditional.DoResolve): Likewise.
1753 (Binary.DoResolve): A lifted operator only exists if both operands
1754 are valuetypes and at least one of them is a nullable type.
1756 2006-03-14 Atsushi Enomoto <atsushi@ximian.com>
1758 * iterator.cs : yield break is allowed in try statement which has
1759 catch clauses. Fixed bug #77767.
1761 2006-03-12 Martin Baulig <martin@ximian.com>
1763 * typemanager.cs (TypeManager.ArrayContainsMethod): Use a new
1764 private IsSignatureEqual() to compare types; see the comment in
1765 that method; fixes #77674.
1767 2006-03-10 Raja R Harinath <rharinath@novell.com>
1769 * ecore.cs (Expression.ResolveAsTypeStep): Remove 1-argument wrapper.
1770 (Expression.ResolveAsTypeTerminal): Likewise.
1771 * class.cs, decl.cs, delegate.cs, ecore.cs: Update to changes.
1772 * expression.cs, generic.cs, iterators.cs: Likewise.
1773 * parameter.cs, statement.cs, typemanager.cs: Likewise.
1775 2006-03-09 Martin Baulig <martin@ximian.com>
1777 * generic.cs (ConstraintChecker.HasDefaultConstructor): Call
1778 TypeManager.DropGenericTypeArguments() on the `atype'; fixes #77548.
1780 2006-03-09 Martin Baulig <martin@ximian.com>
1782 * ecore.cs (FieldExpr.AddressOf): Don't emit the instance if the
1783 `prepared' flag is set.
1785 * generic.cs (LiftedBinaryOperator): Don't allow `||' or `&&' anymore.
1786 (LiftedBinaryOperator, LiftedUnaryMutator): Fix a few nullable
1787 issues; see gtest-254.cs.
1789 2006-03-07 Martin Baulig <martin@ximian.com>
1791 * generic.cs (TypeManager.InferType): Allow infering
1792 `IEnumerable<T>' with an array of T; see gtest-251.cs.
1794 2006-03-06 Martin Baulig <martin@ximian.com>
1797 (TypeManager.InferType): Fix gtest-250.cs.
1800 (TypeManager.IsSubclassOf): Also check the base class.
1803 (Invocation.IsAncestralType): Use TypeManager.IsSubclassOf();
1806 2006-03-01 Raja R Harinath <rharinath@novell.com>
1809 * expression.cs (ParameterReference.DoResolveBase): Change return
1811 (ParameterReference.DoResolve, ParameterReference.DoResolveLValue):
1815 * ecore.cs (PropertyExpr.InstanceResolve): Fix CS1540 check.
1818 * typemanager.cs (GetFullNameSignature): Don't nullref on
1819 protected accessors.
1821 2006-02-16 Martin Baulig <martin@ximian.com>
1824 (TypeManager.GetGenericFieldDefinition): New public method; use it
1825 instead of the `FieldInfo.Mono_GetGenericFieldDefinition()' icall.
1827 2006-02-14 Martin Baulig <martin@ximian.com>
1829 * *.cs: Use `Type.IsGenericType' instead of `Type.IsGenericInstance'.
1831 2006-02-14 Martin Baulig <martin@ximian.com>
1834 (TypeManager.DropGenericMethodArguments): New public method; don't
1835 use GetGenericMethodDefinition() on something which is not a
1838 2006-02-14 Martin Baulig <martin@ximian.com>
1841 (ConstraintChecker.CheckConstraints): If a type parameter has the
1842 `struct' constraint, the type must be a non-nullable valuetype.
1844 2006-02-10 Martin Baulig <martin@ximian.com>
1847 (TypeManager.IsOverride): Make this work for instantiated methods
1848 in a generic class; fixes #77509.
1849 (TypeManager.ExpandInterfaces): Use TypeManager.GetInterfaces()
1850 rather than calling it directly; fixes #77488.
1852 2006-02-08 Martin Baulig <martin@ximian.com>
1854 * generic.cs (ConstraintChecker.CheckConstraints): Move the error
1855 reporting into CheckConstraint() so we can use the correctly
1858 2006-02-08 Martin Baulig <martin@ximian.com>
1860 * expression.cs (BaseAccess): Add support for generic methods.
1862 * ecore.cs (MethodGroupExpr.ResolveGeneric): Propagate `IsBase' to
1863 the new MethodGroupExpr.
1865 2006-02-07 Martin Baulig <martin@ximian.com>
1867 * generic.cs (ConstraintChecker.CheckConstraints): Interfaces are
1868 also reference types; fixes #77483.
1870 2006-02-07 Martin Baulig <martin@ximian.com>
1873 (TypeManager.IsGenericMethod): We now return whether something is
1874 an instantiated generic method (and not a generic method def).
1875 (TypeManager.IsGenericMethodDefinition): New public method.
1878 (TypeManager.CSharpSignature): Only include type arguments for
1879 "real" generic methods, not for any instantiated method.
1880 (TypeManager.GetMethodName): Likewise, but also allow generic
1881 method definitions here.
1883 2006-02-06 Miguel de Icaza <miguel@novell.com>
1885 * codegen.cs (EmitScopeInitFromBlock): check here the
1886 capture_context, there is no need to make two calls to the
1889 * anonymous.cs: Add some debugging messages that might help me
1890 track other instances of this problem in the future (the
1891 regression of test 467).
1893 * cs-parser.jay: track the variable block, as we need to initalize
1894 any captured variables declared in this block for the "catch"
1895 portion of the "Try" statement.
1897 * statement.cs (Try.Emit): If the "Catch" has a VarBlock, emit any
1898 scope initialization for captured variables.
1900 Also, move the emit for the variables after the block location has
1903 2006-02-06 Marek Safar <marek.safar@seznam.cz>
1905 * ecore.cs (PropertyExpr.FindAccessors): Just made flags const.
1907 2006-02-06 Martin Baulig <martin@ximian.com>
1909 * class.cs (TypeContainer.DefineType): If we're a struct, pass
1910 `TypeManager.value_type' as parent type to
1911 ModuleBuilder.DefineType(). Fixes #77358.
1913 2006-02-02 Miguel de Icaza <miguel@novell.com>
1915 * anonymous.cs (CaptureContext.EmitInitScope): I was wrong in the
1916 commit yesterday, the initialization for the roots is necessary.
1917 What is not necessary is the scope activation.
1919 2006-02-02 Raja R Harinath <rharinath@novell.com>
1921 * ecore.cs (PropertyExpr.DoResolveLValue): Add CS0206 check.
1922 * expression.cs (IndexerAccess.DoResolveLValue): Add CS1612 and
1924 (Argument.Resolve): Remove CS0206 checks.
1926 2006-02-01 Miguel de Icaza <miguel@novell.com>
1928 * anonymous.cs (CaptureContext.EmitInitScope): Do not emit the
1929 scopes for all the roots, the scopes will now be emitted when the
1930 Blocks are entered. [This change was wrong, fixed on 2006-02-02]
1932 (CaptureContext.EmitScopeInitFromBlock): Simply emit the ScopeInfo
1933 code. This reduces a lot of existing cruft.
1935 * statement.cs (Block.Emit): Call EmitScopeInitFromBlock here, so
1936 that the ScopeInfo is generated as we enter the scope, not at the
1937 time of use, which is what we used to do before.
1939 * codegen.cs (EmitScopeInitFromBlock): New routine, this is called
1940 every time a Block is about to be emitted if we have a
1943 2006-02-01 Raja R Harinath <rharinath@novell.com>
1945 * codegen.cs (AssemblyClass.Emit): Emit RuntimeCompatibility
1946 attribute for mscorlib too.
1948 * typemanager.cs (NoTypes, NoTypeExprs): Remove.
1950 * *.cs: Use Type.EmptyTypes instead of TypeManager.NoTypes.
1952 * typemanager.cs (cons_param_array_attribute): Make private.
1953 (Reset): Set it to null.
1954 (InitCoreHelpers): Don't initialize it.
1955 (ConsParamArrayAttribute): New. Initialize it as needed.
1956 * parameter.cs (ParamsParameter.ApplyAttribute): Update to change.
1958 2006-01-31 Miguel de Icaza <miguel@novell.com>
1960 * expression.cs: There might be errors reported during the
1961 selection of applicable methods. If there are errors, do not
1962 continue execution as it will lead the compiler to crash.
1964 2006-01-30 Miguel de Icaza <miguel@novell.com>
1966 * expression.cs: Member access is not allowed on anonymous
1967 methods. Fixes #77402.
1969 2006-01-30 Raja R Harinath <rharinath@novell.com>
1972 * cs-parser.jay (VariableDeclaration): Don't set
1973 current_array_type to null.
1974 (field_declaration, event_declaration, declaration_statement):
1975 Set it to null here.
1977 2006-01-29 Raja R Harinath <harinath@gmail.com>
1980 * generic.cs (TypeManager.IsEqual): Handle pass-by-ref types.
1982 2006-01-28 Raja R Harinath <harinath@gmail.com>
1984 * typemanager.cs (GenericParameterPosition): New.
1987 2006-01-28 Atsushi Enomoto <atsushi@ximian.com>
1989 * doc.cs : To process "include" elements, first we should create
1990 another list than XmlNodeList, because it could result in node
1991 removal, which could result in that the XmlNodeList gives up
1994 2006-01-25 Miguel de Icaza <miguel@novell.com>
1996 * expression.cs: Introduce an error report that we were not
1997 catching before. Gonzalo ran into it.
1999 2006-01-23 Miguel de Icaza <miguel@novell.com>
2001 A fix for bug: #76957
2003 * iterators.cs (MoveNextMethod.CreateMethodHost): call
2004 ComputeMethodHost before creating the method, this is a new
2007 * anonymous.cs (AnonymousContainer): Now we track all the scopes
2008 that this method references (RegisterScope). The actual scope
2009 where the method is hosted is computed with the ComputeMethodHost
2010 before we create the method.
2012 Moved the Deepest routine here.
2014 (AnonymousContainer.ComputeMethodHost): New routine used to
2015 compute the proper ScopeInfo that will host the anonymous method.
2017 (ScopeInfo): Deal with multiple roots. The problem was that we
2018 did not have a unique root where all ScopeInfos could be hanged
2019 from. Remove `topmost' ScopeInfo, and instead keep an arraylist
2022 Remove AdjustMethodScope which is now computed at the end. Remove
2023 LinkScope which did a partial link, instead link all ScopeInfos
2024 before code generation from the new "LinkScopes" routine.
2026 Simplify all the Add* routines as they no longer need to maintain
2027 the tree, they just need to record that they are using variables
2030 (IsAncestor, GetAncestorScopes, GetParentScope, LinkScope): New
2031 routines to produce the forest of ScopeInfo trees.
2033 * class.cs (TypeContainer.AppendMethod): This is just like
2034 AddMethod, but ensures that an interface implementation method
2035 (IEnumerable.XXX) is not inserted at the beginning of the queue of
2036 methods, but at the end.
2038 We use this functionality to ensure that the generated MoveNext
2039 method in the iterator class is resolved/emitted before the
2040 enumerator methods created.
2042 This is required because the MoveNext method computes the right
2043 ScopeInfo for the method. And the other methods will eventually
2044 need to resolve and fetch information computed from the anonymous
2048 2006-01-23 Raja R Harinath <rharinath@novell.com>
2050 Improve implementation of section 14.4.2.2 (Better function member).
2051 * expression.cs (Invocation.MoreSpecific): Compare all type
2052 arguments before deciding if one type is more specific than
2053 another. Handle array types too. Return the more specific type.
2054 (Invocation.BetterFunction): Add more tie-breaking rules from
2055 section 14.4.2.2. Perform "more specific" check after
2056 other tie-breaking rules. Compare all parameter types before
2057 choosing the "more specific" method.
2059 2006-01-21 Raja R Harinath <harinath@gmail.com>
2060 Carlos Alberto Cortez <calberto.cortez@gmail.com>
2063 * namespace.cs (NamespaceEntry.UsingExternalAliases): Don't add to
2065 (NamespaceEntry.LookupAlias): Lookup 'extern_aliases' hash too.
2066 (NamespaceEntry.VerifyUsing): Resolve external aliases too.
2068 2006-01-18 Martin Baulig <martin@ximian.com>
2070 * class.cs (TypeContainer.AddToMemberContainer): Use
2071 `symbol.MemberName.MethodName' instead of just `symbol.Name';
2074 2006-01-18 Martin Baulig <martin@ximian.com>
2076 Fix #76417: a generic class may now have methods which may unify
2077 for some type parameter substitutions.
2079 * class.cs (Method.IsDuplicateImplementation): Don't report CS0408
2080 for methods which may unify anymore.
2082 * expression.cs (Invocation.MoreSpecific): New private static
2083 method; checks whether one method is more specific than another
2084 according to 14.4.2.2 of the spec.
2085 (Invocation.BetterFunction): Implement the tie-breaking rules from
2086 14.4.2.2 of the spec: if two methods unify for some type parameter
2087 substitution, we need to pick the more specific one.
2089 2006-01-18 Raja R Harinath <rharinath@novell.com>
2091 Fix #76656, cs0231-2.cs.
2092 * cs-parser.jay (formal_parameter_list): Make error case catch
2094 (parenthesized_expression_0): Add CS1026 check.
2095 (invocation_expression): Remove unused { $$ = lexer.Location }.
2097 2006-01-17 Raja R Harinath <rharinath@novell.com>
2100 * cs-parser.jay (statement_expression): Don't list out the
2101 individual statement-expressions. Convert syntax error into
2104 2006-01-16 Raja R Harinath <rharinath@novell.com>
2107 * ecore.cs (MemberAccess.CheckIntermediateModification): Remove.
2108 (UnboxCast.DoResolveLValue): New. Move CS0445 check from
2109 CheckIntermediateModification.
2110 (FieldExpr.DoResolve): Add new two-argument version that
2111 allows us to resolve the InstanceExpression as an lvalue.
2112 The one-argument variant is now just a wrapper.
2113 (FieldExpr.DoResolveLValue): Use two-argument DoResolve.
2114 Resolve the lhs as an lvalue if the it has a value type.
2115 (FieldExpr.AssignToReadonly): Move CS1648 and CS1650 checks
2116 from Assign.DoResolve.
2117 (PropertyExpr.InstanceResolve): Allow InstanceExpression to be
2118 resolved as an lvalue.
2119 (PropertyExpr.DoResolve): Update.
2120 (PropertyExpr.DoResolveLValue): Resolve the lhs as an lvalue if it
2121 has a value type. Move CS1612 check here from
2122 CheckIntermediateModification.
2123 * assign.cs (Assign.DoResolve): Remove CS1648 and CS1650 checks.
2124 * expression.cs (EmptyExpression.OutAccess): New. Used as the
2125 'right_side' of a ResolveLValue on an 'out' argument.
2126 (EmptyExpression.LValueMemberAccess): New. Used as the
2127 'right_side' of a propagated ResolveLValue on a value type.
2128 (LocalVariableReference.DoResolveBase): Recognize
2129 EmptyExpression.OutAccess and EmptyExpression.LValueMemberAccess.
2131 (Argument.Resolve): Use EmptyExpression.OutAccess rather than
2132 EmptyExpression.Null.
2134 2006-01-16 Atsushi Enomoto <atsushi@ximian.com>
2136 * typemanager.cs : added IsGenericParameter(). In gmcs it returns
2137 Type.IsGenericParameter(). Fixed bug #77183.
2138 * doc.cs : it is now identical to doc.cs in mcs.
2140 2006-01-16 Martin Baulig <martin@ximian.com>
2142 * generic.cs (ConstraintChecker.CheckConstraint): Fix #77167.
2144 2006-01-16 Martin Baulig <martin@ximian.com>
2146 * typemanager.cs (TypeManager.CSharpSignature): Make this work for
2147 ctors; fixes #77250.
2149 2006-01-12 Miguel de Icaza <miguel@novell.com>
2151 This fixes the problem where we used ldfld instead of ldflda to
2152 load the "THIS" pointer on captured parameters, when THIS is a
2153 value type. See bug #77205.
2155 * iterators.cs (CapturedThisReference.Emit): Pass false to
2156 EmitThis (we do not need the address).
2158 * codegen.cs (EmitThis): it needs to know whether we need the
2159 address of `this' or not. This is used by value types.
2161 * expression.cs (This.AddressOf): Pass true to the EmitThis call,
2162 every other call passes false.
2164 2006-01-12 Raja R Harinath <rharinath@novell.com>
2167 * typemanager.cs (TryGetBaseDefinition): Rename from the mis-named
2169 * expression.cs (Invocation.OverloadResolve): Update.
2170 (Invocation.DoResolve): Avoid double resolution of invocation.
2172 2006-01-11 Raja R Harinath <rharinath@novell.com>
2175 * expression.cs (Unary.Emit): When in /checked+ mode, don't emit
2176 unary negation of floating point types as 0-expr; negation cannot
2177 overflow in floating point types.
2180 * expression.cs (MemberAccess.DoResolve): Disallow the use of '.'
2181 on operands of 'void' type.
2184 * cfold.cs (BinaryFold): Implement folding of BinaryOr, BinaryAnd
2185 and ExclusiveOr for boolean constants too.
2187 2006-01-12 Ben Maurer <bmaurer@andrew.cmu.edu>
2189 * expression.cs: Fix Console.WriteLine ((this = x).foo);
2191 2006-01-12 Miguel de Icaza <miguel@novell.com>
2193 * cs-tokenizer.cs (Position): New class used to save and restore
2194 the position state in the tokenizer. Before this patch the save
2195 and restore was not complete enough so the line and columns would
2196 start to drift and the debugger and stack traces will get the
2199 2006-01-10 Martin Baulig <martin@ximian.com>
2202 (TypeParameter.InflateConstraints): New public method.
2204 * iterators.cs (Iterator.DefineNestedTypes): Also inflate the
2205 constraints; fixes #77042.
2207 2006-01-10 Martin Baulig <martin@ximian.com>
2209 * anonymous.cs (ScopeInfo.EmitScopeType): Use the `CurrentType'
2210 instead of the `TypeBuilder' for this "<>THIS" variable; fixes
2213 2006-01-09 Raja R Harinath <rharinath@novell.com>
2216 * expression.cs (Invocation.OverloadResolve): Replace reflected
2217 override methods with their base virtual methods, rather than
2219 * typemanager.cs (TypeManager.GetOverride): New.
2221 2005-12-21 Miguel de Icaza <miguel@novell.com>
2223 * driver.cs: Report the case of no source files and no -out:
2226 2005-12-20 Raja R Harinath <rharinath@novell.com>
2229 * expression.cs (ComposedCast.GetSignatureForError): Define.
2231 2006-01-05 Jb Evain <jbevain@gmail.com>
2233 * class.cs (Property.Define, Indexer.Define): do not tag the
2234 properties as SpecialName | RTSpecialName.
2236 2006-01-04 Miguel de Icaza <miguel@novell.com>
2238 * class.cs (MethodCore.IsDuplicateImplementation): This method was
2239 doing a low-level comparission of parameter types. It was lacking
2240 a check for __argslist.
2242 2005-12-30 Miguel de Icaza <miguel@novell.com>
2244 * expression.cs (ParameterReference.DoResolveBase): Allow
2245 reference parameters if they are local to this block.
2247 This allows the ref and out parameters of a delegate to be used in
2248 an anonymous method, for example:
2250 delegate void set (out int x);
2252 set s = delegate (out int x){
2256 This is used by functionality introduced late in the C# language.
2258 * anonymous.cs (AnonymousMethod.Compatible): Allow anonymous
2259 method that take ref and out parameters.
2261 Fixes #77119 which was a late change in the spec.
2263 2005-12-23 Miguel de Icaza <miguel@novell.com>
2265 * anonymous.cs (ScopeInfo.LinkScope): Do not link the scope to its
2266 parent if its the same scope. Fixes #77060.
2268 2005-12-22 Marek Safar <marek.safar@seznam.cz>
2270 * expression.cs (ComposedCast.DoResolveAsTypeStep): Fixed wrong merge.
2272 2005-12-21 Carlos Alberto Cortez <calberto.cortez@gmail.com>
2274 * codegen.cs (AssemblyClass.CheckInternalsVisibleAttribute): Generate
2275 errors 1726 for strong named assemblies with InternalsVisibleToAttribute
2276 that doesn't contain the full public key. This is a update of the
2277 friend assemblies in .Net 2.0 release.
2279 2005-12-18 Carlos Alberto Cortez <calberto.cortez@gmail.com>
2283 * namespace.cs (NamespaceEntry): Add extern_aliases as a
2284 ListDictionary, to contain the ExternAliasEntry entries (in
2285 addition to the NamespaceEntry.aliases hashtable). This field is
2286 shared between the original entry and its doppelganger (bodyless
2288 (NamespaceEntry.UsingExternalAlias): Add the extern alias entry to
2289 extern_aliases field.
2290 (NamespaceEntry.Lookup): Move the IsImplicit check after the
2291 lookup in extern_aliases.
2293 2005-12-16 Raja R Harinath <rharinath@novell.com>
2296 * class.cs (TypeContainer.Mark_HasEquals): New.
2297 (TypeContainer.Mark_HasGetHashCode): New.
2298 (ClassPart): Override them.
2299 (MethodCore.CheckBase): Use them instead of referring to Parent.Methods.
2301 * generic.cs (GenericMethod.DefineMembers): Update to changes.
2302 (TypeParameter.TypeParameter): Change type of 'parent' argument to
2306 * enum.cs (EnumMember.EnumMember): Pass the parent_enum as the
2307 'parent' argument to the base constructor.
2309 Remove all mention of TypeContainer from decl.cs.
2310 * decl.cs (MemberCore.Parent): Change into a DeclSpace.
2311 (MemberCore.MemberCore): Change type of 'parent' argument to DeclSpace.
2312 (DeclSpace.DeclSpace): Likewise.
2313 (DeclSpace.DefineMembers): Remove unused argument.
2314 * cs-parser.jay (pop_current_class): Update to changes. Simplify
2315 debugging check -- we don't care if the debug code throws an
2316 InvalidCastException instead of an InternalErrorException.
2317 * class.cs (TypeContainer.DefineMembers): Update to changes.
2318 (TypeContainer.DoDefineMembers): Likewise.
2319 (TypeContainer.GetMethods): Likewise.
2320 (PropertyMember.Define): Likewise.
2321 (MemberBase.Parent): New property that forwards to
2322 MemberCore.Parent, but ensures that we get a TypeContainer.
2323 * rootcontext.cs (RootContext.PopulateCoreType): Update to changes.
2324 (RootContext.PopulateTypes): Likewise. Remove special case code
2325 for !RootContext.StdLib: DefineMembers is idempotent.
2327 2005-12-13 Marek Safar <marek.safar@seznam.cz>
2329 * class.cs (Method.ApplyAttributeBuilder): Test out modifier properly.
2331 2005-12-11 Atsushi Enomoto <atsushi@ximian.com>
2333 * doc.cs : The search for referenced namespace was insufficient to
2334 get global one as it used to do. Fixed bug #76965.
2336 2005-12-10 Atsushi Enomoto <atsushi@ximian.com>
2338 * doc.cs : check name in cref in the last phase that whether it is
2341 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
2343 * cs-tokenizer.cs : reverted the latest change: it somehow broke
2346 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
2348 * doc.cs : so it turned out that we cannot skip override check for
2349 interface members. Fixed bug #76954.
2351 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
2353 * cs-tokenizer.cs : fixed bug #75984:
2354 - #warning and #error should not be handled when the source line
2356 - #line is not checked strictly when the source line is disabled.
2357 - #define and #undef is on the other hand checked strictly at any
2360 2005-12-08 Atsushi Enomoto <atsushi@ximian.com>
2362 * cs-tokenizer.cs : missing Location (actually, filename) in one of
2365 2005-12-15 Raja R Harinath <rharinath@novell.com>
2367 * generic.cs (TypeManager.IsGeneric): Remove unused method.
2369 * typemanager.cs (TypeManager.GetFullName): Rewrite to handle
2372 2005-12-14 Martin Baulig <martin@ximian.com>
2374 * typemanager.cs (TypeManager.GetFullName): Make this public;
2375 `Type.Fullname' now never returns null.
2377 * class.cs (Method.Define): Use TypeManager.GetFullName() for
2378 explicit interface implementations; we're now using the same
2379 naming convention than csc does.
2381 2005-12-14 Miguel de Icaza <miguel@novell.com>
2383 * convert.cs (ExplicitConversionCore): Check the return value from
2384 ExplicitConversionCore which can return null on failure. Fixes #76914
2386 2005-12-09 Raja R Harinath <rharinath@novell.com>
2388 * anonymous.cs (AnonymousMethod.Compatible): Use IsGenericType
2389 instead of IsGenericInstance.
2390 * generic.cs (TypeManager.IsEqual): Likewise. Delete redundant
2391 code that's now covered by the more general test.
2392 * typemanager.cs (TypeManager.IsPrivateAccessible): Likewise.
2394 * generic.cs (DropGenericTypeArguments): New. Captures the common
2395 pattern: if (t.IsGenericInstance) t = t.GetGenericTypeDefinition ();
2396 * attribute.cs, class.cs, decl.cs, ecore.cs: Use it.
2397 * generic.cs, report.cs, typemanager.cs: Likewise.
2399 2005-12-08 Martin Baulig <martin@ximian.com>
2401 * generic.cs (TypeArguments.Resolve): Added CS1547 check.
2403 * typemanager.cs (TypeManager.CSharpSignature): Include type
2404 arguments in the signature of a generic method.
2406 2005-12-07 Martin Baulig <martin@ximian.com>
2408 Add support for custom attributes on type parameters.
2410 * cs-parser.jay (type_arguments): Added `opt_attributes'.
2412 * generic.cs (TypeParameterName): New public class; we use this
2413 instead of a `string' to store the name of a type parameter, so we
2414 can also have `Attributes'.
2415 (TypeArguments.GetDeclarations): Return a `TypeParameterName[]'
2416 array instead of a `string[]' array.
2417 (TypeParameter.ctor): We now also take an `Attributes' argument.
2418 (TypeParameter.EmitAttributes): New public method; emit our
2419 `OptAttributes' here.
2420 (GenericMethod.EmitAttributes): New public method; emit the custom
2421 attributes on all our type parameters.
2423 * class.cs (TypeContainer.EmitType): Call EmitAttributes() on all
2424 our type parameters.
2425 (MethodData.Define): If we're a generic method, call
2426 EmitAttributes() on it.
2428 2005-12-07 Martin Baulig <martin@ximian.com>
2431 (ConstraintChecker): New public abstract class; move the
2432 constraint checking here from `ConstructedType' and also do
2433 constraint checking for generic methods here.
2435 * expression.cs (Invocation.OverloadResolve): Use
2436 ConstraintChecker.CheckConstraints() if we resolved to a generic
2439 2005-12-05 Marek Safar <marek.safar@seznam.cz>
2441 * attribute.cs (GlobalAttribute.ctor): Pass NamespaceEntry only.
2443 * class.cs (EmitFieldInitializers): Simplified and fixed to work with
2445 (FieldBase.EmitInitializer): Moved from TypeContainer and simplified.
2446 (FieldBase.Initializer): Initializer is now optional.
2447 (EventField.Define): Only event field can have initializer.
2449 * codegen.cs (EmitContext): DeclSpace is not readonly (small hack).
2451 * const.cs (Const): Reuse initializer.
2453 * cs-parser.jay: Updated after FieldBase changes.
2454 Added current_array_type to simplify array initializers.
2456 * ecore.cs (NullCast.IsDefaultValue): Implemented.
2458 * expression.cs, iterators.cs: Updated.
2460 * namespace.cs (NamespaceEntry): Made UsingFound private.
2462 2005-12-05 Marek Safar <marek.safar@seznam.cz>
2464 * parameterCollection.cs: Obsolete, removed.
2465 * parser.cs: Obsolete, removed.
2467 2005-12-05 Marek Safar <marek.safar@seznam.cz>
2470 * class.cs (Constructor.Emit): Set obsolete checking for whole context.
2472 * enum.cs (Enum.Define): Set obsolete context here.
2474 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
2477 - FindDocumentedMember() now expects 1) paramList as null
2478 when "we don't have to check the number of parameters" and
2479 2) Type.EmptyTypes when "there is no arguments".
2480 - Introduced FoundMember struct to hold the exact type which was
2481 used to find the documented member (the above change broke
2482 test-xml-044; it might be better just to use DeclaringType than
2483 what MS does, like this change does, but it depends on usage.)
2485 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
2487 * doc.cs : documented member might be from DeclaringType for nested
2488 types. Fixed bug #76782.
2490 2005-12-03 Ben Maurer <bmaurer@ximian.com>
2492 * anonymous.cs: Have the param code handle leaving copies on the
2493 stack etc. Allows anonymous params to take part in the assignment
2494 code (++, +=, etc). Fixes bug #76550
2496 * expression.cs: Handle the prepare_for_load/leave_copy by passing
2497 it down to the anon code.
2499 * iterators.cs: Use dummy var here
2501 * codegen.cs: Handle new vars
2503 2005-12-01 Marek Safar <marek.safar@seznam.cz>
2506 * class.cs (MethodData.Define): Set proper Obsolete context.
2508 * ecore.cs (FieldExpr.ResolveMemberAccess): Don't check [Obsolete] in
2510 (FieldExpr.DoResolve): Ditto.
2512 2005-12-01 Marek Safar <marek.safar@seznam.cz>
2515 * class.cs (MethodCore.DoDefineParameters): Test [Obsolete] only when
2516 parent is not obsolete.
2518 2005-12-01 Atsushi Enomoto <atsushi@ximian.com>
2520 * doc.cs : (FindDocumentedMember) find parameterless members first
2521 and get CS0419 in the early stage. Fixed first case of bug #76727.
2523 2005-11-30 Marek Safar <marek.safar@seznam.cz>
2526 * ecore.cs (Expression.ResolveAsConstant): Report constant error only when
2527 no error was reported.
2529 *expression.cs (Binary.DoResolve): left can be null.
2531 2005-12-06 Raja R Harinath <rharinath@novell.com>
2533 * class.cs (MethodCore.CheckGenericOverride): Delete unused
2534 abstract method and all overrides.
2535 * support.cs (ParameterData.GenericConstraints): Delete.
2536 (ReflectionParameters.type_params): Delete.
2537 (ReflectionParameters.ReflectionParameters): Make private.
2538 (ReflectionParameters.GetConstaints): New factory method.
2539 * generic.cs (TypeParameterDefineType): Use it.
2540 (TypeManager.GetTypeParameterConstraints): Likewise.
2542 2005-11-22 Marek Safar <marek.safar@seznam.cz>
2545 * class.cs (MethodData.Emit): Parameters should be labeled first.
2547 2005-11-21 Marek Safar <marek.safar@seznam.cz>
2550 * parameter.cs (Parameter.ApplyAttributeBuilder): Fixed `ref' detection.
2552 2005-11-18 Marek Safar <marek.safar@seznam.cz>
2554 * attribute.cs (AreParametersCompliant): Moved to Parameter.
2556 * class.cs (MethodCore): Parameter clean up.
2557 (IMethodData): Added ParameterInfo.
2558 (MethodData): Parameter clean up.
2559 (Indexer.Define): Parameter clean up.
2571 * typemanager.cs: Parameter clean up.
2573 * delegate.cs (Define): Get rid of duplicated code.
2575 * expression.cs (ParameterReference): Removed useless parameters
2577 (Invocation): Ditto.
2579 * parameter.cs (ParamsParameter): New class, params specialization.
2580 (ArglistParameter): Attemp to separate arglist.
2581 (Parameter): Refactored to be reusable and faster.
2582 (Parameter.Modifier): Made understandable.
2583 (Parameters): Changed to be used as a class for `this' assembly
2584 parameters. Refactored to use new specialized classes.
2586 * support.cs (ParameterData): Added Types property.
2587 (InternalParameters): Deleted.
2589 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
2591 * doc.cs : the previous patch does not actually fix the bug.
2592 PropertyInfo override check is now implemented and really fixed it.
2593 * expression.cs : Invocation.IsAncestralType() is used from doc.cs.
2595 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
2597 * doc.cs : apply "override filter" also to properties.
2600 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
2602 * doc.cs : renamed FindMembers() to FindMethodBase(). For interfaces,
2603 no need to check overrides. For classes, omit those results from
2604 interfaces since they must exist in the class. Fixed bug #76726.
2606 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
2608 * typemanager.cs : (GetFullNameSignature) differentiate indexers
2609 with different parameters. Fixed the second problem in #76685.
2611 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
2613 * doc.cs : (FindDocumentedMember) pass invocation_type as well (to
2614 get expected 'protected' access in CheckValidFamilyAccess()).
2617 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
2619 * doc.cs : (GenerateTypeDocComment) Fields could be FixedField.
2620 Fixed bug #76705. CS1569 was incorrectly commented out.
2622 2005-11-23 Martin Baulig <martin@ximian.com>
2624 * generic.cs (Constraints.Define): Removed.
2625 (TypeParameter.DefineConstraints): Removed.
2626 (TypeParameter.DefineType): Call SetGenericParameterAttributes()
2627 on the GenericTypeParameterBuilder here.
2629 2005-11-23 Martin Baulig <martin@ximian.com>
2631 * typemanager.cs (TypeManager.GetProperty): Make this public.
2633 * generic.cs (Nullable.NullableInfo.ctor): Use
2634 TypeManager.GetProperty() rather than using reflection directly.
2636 2005-11-17 Martin Baulig <martin@ximian.com>
2638 * expression.cs (Indexers.GetIndexersForType): Added support for
2639 generic parameters; fixes #76587.
2641 2005-11-17 Martin Baulig <martin@ximian.com>
2644 (CaptureContext.EmitMethodHostInstance): Use `Ldarg_0' if we
2645 inherit the scope from our parent. Fixes #76653.
2647 2005-11-15 Martin Baulig <martin@ximian.com>
2649 * anonymous.cs (ScopeInfo.ScopeType): New public field; use this
2650 instead of `ScopeTypeBuilder' to refer to the "current" type.
2651 (AnonymousMethod.CreateScopeType): Correctly create the helper
2652 class if we're inside a generic type definition.
2654 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
2656 * doc.cs : use Invocation.IsOverride() to do real override check.
2657 * expression.cs : made Invocation.IsOverride() internal.
2659 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
2661 * doc.cs : use TypeManager.FindMembers() instead of (possible)
2662 TypeBuilder.FindMembers() and filter overriden base members out.
2665 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
2667 * doc.cs : ref/out parameters are represented as '@' (instead of
2668 '&' in type FullName). Fixed bug #76630 (additionally crefs).
2670 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
2672 * doc.cs : when there was no '.' in cref to methods in doc comment,
2673 then parameters were missing in the output. Fixed bug #76691.
2675 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
2677 * driver.cs : don't output docs when there is an error.
2680 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
2683 Now it should detect indexers. Fixed primary concern in bug #76685.
2684 Fixed CS0419 message to not show the identical member signature in
2687 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
2689 * doc.cs : (FindDocumentedMember) use TypeManager.MemberLookup()
2690 instead of Type.FindMembers() since it does not handle events.
2693 2005-11-12 Gert Driesen <drieseng@users.sourceforge.net>
2695 * codegen.cs: Fixed typo (speficied -> specified).
2697 2005-11-11 Marek Safar <marek.safar@seznam.cz>
2700 * doc.cs (FindDocumentedTypeNonArray): Don't resolve again.
2702 2005-11-11 Marek Safar <marek.safar@seznam.cz>
2704 * attribute.cs: Changed error message.
2706 * cs-tokenizer.cs: One more check.
2708 2005-11-10 Marek Safar <marek.safar@seznam.cz>
2710 * statement.cs (Block.Resolve): Ignore empty statement.
2712 2005-11-10 Marek Safar <marek.safar@seznam.cz>
2714 * report.cs: Made error/warning methods more strict to avoid
2717 * anonymous.cs, attribute.cs, class.cs, codegen.cs, constant.cs,
2718 convert.cs, cs-parser.jay, cs-tokenizer.cs, decl.cs, delegate.cs,
2719 doc.cs, driver.cs, ecore.cs, expression.cs, location.cs,
2720 namespace.cs, parameter.cs, statement.cs, typemanager.cs: Updated.
2722 2005-11-11 Carlos Alberto Cortez <calberto.cortez@gmail.com>
2724 * codegen.cs (AssemblyClass.CheckInternalsVisibleAttribute):
2725 Use the more explicit AssemblyName.FullName instead of
2726 AssemblyName.Name to report errors.
2728 2005-11-11 Marek Safar <marek.safar@seznam.cz>
2730 * attribute.cs, class.cs, cs-tokenizer.cs, parameter.cs: Sync
2733 2005-11-10 Marek Safar <marek.safar@seznam.cz>
2743 * report.cs: Fixed error reporting and typos.
2745 * generic.cs (TypeParameter.GetSignatureForError): New method.
2746 (ConstructedType.GetSignatureForError): Instead of DeclarationName.
2748 * typemanager.cs (GetFullName): Refactored.
2750 2005-11-08 Marek Safar <marek.safar@seznam.cz>
2752 * attribute.cs (Attribute.GetCoClassAttributeValue): New method.
2753 (AttributeTester.GetCoClassAttribute): Get CoClassAttribute.
2755 * class.cs (TypeContainer.IsComImport): New property.
2756 (Constructor.Define): Create proper ctor for ComImport types.
2758 * expression.cs (New.CheckComImport): Fixed.
2760 2005-11-07 Miguel de Icaza <miguel@novell.com>
2762 * anonymous.cs (CaptureContext.AddParameterToContext): The fact
2763 that a parameter has been captured does not mean that we do not
2764 have to do the rest of the processing. This fixes the second part
2765 of #76592. If there was another anonymous method capturing
2766 values in the past, the Scope would never be set for the second
2767 method that captured the same parameter.
2769 (CaptureContext.EmitAssignParameter): When `leave_copy' is passed,
2770 properly manipulate the stack. Second part of fix for #76592.
2772 * expression.cs (New): Add support for invoking "new" on
2773 interfaces that have been flagged with the ComImport attribute and
2774 the CoClass. Fixes #76637
2776 * statement.cs (Try.DoEmit): When a variable is captured, do not
2777 try to emit the vi.LocalBuilder variable as it has been captured.
2778 Create a temporary variable and store the results on the
2779 FieldBuilder. Fixes #76642
2781 2005-11-07 Marek Safar <marek.safar@seznam.cz>
2783 * class.cs (CheckPairedOperators): Made compilable with csc 2.0.
2785 * ecore.cs (InstanceResolve): Fixed CS1540 detection.
2787 * expression.cs (Binary.DoResolve): Added && optimalization.
2789 * typemanager.cs (AddUserType): Removed useless argument.
2791 2005-11-04 Marek Safar <marek.safar@seznam.cz>
2793 * statement.cs (Block.variables): Uses ListDictionary.
2795 2005-11-03 Marek Safar <marek.safar@seznam.cz>
2798 * class.cs (PartialContainer.EmitType): Customized to emit
2799 security attributes.
2800 (ClassPart.ApplyAttributeBuilder): Transform security attribute
2801 for partial classes.
2803 2005-11-03 Marek Safar <marek.safar@seznam.cz>
2806 * expression.cs (ElementAccess.DoResolveLValue): Fixed buffer
2807 access has to be fixed.
2809 * typemanager.cs (IsUnmanagedType): Wrong common field type.
2811 2005-11-01 Marek Safar <marek.safar@seznam.cz>
2814 * ecore.cs (NullCast.Reduce): Implemented.
2816 * expression.cs (ArrayCreation.CheckIndices): Correcly check
2819 * statement.cs (SwitchLabel.ResolveAndReduce): Catch null
2821 (Foreach.Resolve): Catch null properly.
2823 2005-10-29 Marek Safar <marek.safar@seznam.cz>
2825 * cs-tokenizer.cs: Warning text fix.
2827 * driver.cs: AllWarningNumbers exposed on public interface.
2829 * report.cs (): Reviewed warning numbers.
2830 (IsValidWarning): Use binary search.
2832 2005-10-29 Marek Safar <marek.safar@seznam.cz>
2834 * driver.cs: Implemeted resource visibility.
2835 (Resources): New class for code sharing between /res: and
2838 2005-11-07 Marek Safar <marek.safar@seznam.cz>
2840 decl.cs (CurrentTypeParameters): Fixed to be public.
2842 2005-11-07 Marek Safar <marek.safar@seznam.cz>
2844 generic.cs, rootcontext.cs: Removed NewConstraintAttribute.
2846 2005-11-07 Marek Safar <marek.safar@seznam.cz>
2848 gmcs.exe.sources: Use CryptoConvert.cs from corlib.
2850 2005-11-05 Kornél Pál <kornelpal@hotmail.com>
2852 * gmcs.exe.config: Updated runtime version to v2.0.50727 (2.0 RTM).
2854 2005-11-04 Carlos Alberto Cortez <calberto.cortez@gmail.com>
2856 Add friend assembly access support.
2857 * typemanager.cs: assembly_internals_vis_attrs
2858 cache for friend assembly access.
2859 (TypeManager.IsFriendAssembly): New method for
2860 checking friend assembly access.
2861 (TypeManager.Error_FriendAccessNameNotMatching): New
2863 (TypeManager.CompareKeyTokens): Likewise.
2864 (TypeManager.Filter): Handle friend accessible
2867 * namespace.cs (RootNamespace.GetTypeInAssembly): Return
2868 friend accessible types.
2870 * ecore.cs (Expression.IsAccessorAccessible): Handle
2871 friend accessible properties.
2873 * decl.cs (DeclSpace.CheckAccessLevel): Handle friend
2876 2005-10-28 Marek Safar <marek.safar@seznam.cz>
2879 * cfold.cs (ConstantFold.BinaryFold): Implemented null cast
2882 * convert (Convert.ImplicitReferenceConversion): NullCast holds
2885 * ecore.cs (NullCast): Child is contant only.
2887 * literal.cs (NullLiteral.Reduce): null can be converted to any
2890 2005-10-28 Kornél Pál <kornelpal@hotmail.com>
2892 * driver.cs: Use Encoding.Default as default code page instead
2895 2005-10-27 Raja R Harinath <rharinath@novell.com>
2898 * expression.cs (Invocation.Error_InvalidArguments): Handle
2899 __arglist parameters.
2900 (Invocation.VerifyArgumentsCompat): Likewise.
2901 * support.cs (ReflectionParameters.GetSignatureForError): Print
2902 __arglist parameters.
2903 (InternalParamters.GetSignatureForError): Likewise.
2904 * parameter.cs (Parameters.GetSignatureForError): Likewise.
2906 2005-10-26 Marek Safar <marek.safar@seznam.cz>
2908 * attribute.cs (GetPropertyValue): Made public.
2910 * codegen.cs (AssemblyClass): ResolveClsCompliance renamed to
2912 Add new property WrapNonExceptionThrows to handle 2.0 assembly
2914 (AssemblyClass.Emit): Emit RuntimeCompatibilityAttribute when it
2917 * driver.cs: Reflect method name change.
2919 * statement.cs (Try.Resolve): Warn when try has both general
2922 * typemanager.cs: runtime_compatibility_attr_type new predefined
2925 2005-10-26 Raja R Harinath <harinath@gmail.com>
2928 * pending.cs (InterfaceMethod): Allow tm.args [i] to be null --
2929 treat it as an empty parameter list.
2931 2005-10-26 Raja R Harinath <rharinath@novell.com>
2934 * ecore.cs (SimpleName.DoSimpleNameResolve): Make fall-back
2935 ResolveAsTypeStep silent.
2936 * statement.cs (Block.AddConstant): Mark block as used.
2937 (Block.ResolveMeta): Avoid piling on error messages
2938 if a constant initializer resolution fails.
2940 2005-10-25 Raja R Harinath <rharinath@novell.com>
2942 * namespace.cs (RootNamespace.VerifyUsingForAll, Namespace.VerifyUsing):
2944 (NamespaceEntry.VerifyAllUsing): New.
2945 (NamespaceEntry.AliasEntry.Resolve): New. Handles common error
2946 behaviour. Delegates actual resolution of alias to ...
2947 (NamespaceEntry.DoResolve): ... this. Renamed from Resolve.
2948 (NamespaceEntry.LocalAliasEntry, NamespaceEntry.ExternAliasEntry):
2950 * driver.cs (Driver.MainDriver): Update.
2952 * namespace.cs (NamespaceEntry.DefineNamespace): Remove.
2953 (NamespaceEntry.SymbolFileID): Make into a on-demand computed
2955 (Namespace.DefineNamespaces, RootNamespace.DefineNamespacesForAll):
2957 * symbolwriter.cs (SymbolWriter.Initialize): Don't call
2958 RootNamespace.DefineNamespacesForAll.
2960 2005-10-24 Raja R Harinath <harinath@gmail.com>
2962 * typemanager.cs (assemblies, external_aliases, modules)
2963 (AddAssembly, AddExternAlias, AddModule GetAssemblies, Modules)
2964 (ComputeNamespaces, GetRootNamespace): Remove extra staging
2965 overhead. Move resposibility ...
2966 * namespace.cs (GlobalRootNamespace): ... here. Update to changes.
2967 * driver.cs, attribute.cs, codegen.cs: Update to changes.
2969 2005-10-23 Raja R Harinath <harinath@gmail.com>
2971 * namespace.cs (RootNamespace.all_namespaces): Renamed from
2972 cached_namespaces. Improve usage.
2973 (RootNamespace.Reset, RootNamespace.RegisterNamespace)
2974 (RootNamespace.VerifyUsingForAll, RootNamespace.DefineNamespacesForAll):
2975 Move from GlobalRootNamespace and simplify.
2976 (RootNamespace.Global): Make instance variable.
2977 (RootNamespace.RootNamespace): Add "alias name" parameter.
2978 (GlobalRootNamespace): Simplify drastically.
2979 (Namespace.Lookup): Don't use GetNamespace.
2980 * typemanager.cs (GetRootNamespace): Rename from
2981 ComputeNamespaceForAlias.
2982 (NamespaceClash): Use Global.IsNamespace instead of GetNamespace.
2984 2005-10-23 Marek Safar <marek.safar@seznam.cz>
2986 * anonymous.cs (AnonymousContainer): Don't crash when container
2989 2005-10-23 Marek Safar <marek.safar@seznam.cz>
2991 * expression.cs (Binary.DoResolve): Warn when comparing same
2994 2005-10-23 Marek Safar <marek.safar@seznam.cz>
2997 * expression.cs (Binary.DoResolve): It looks like there are no
2998 convetsion rules in enum context.
3000 2005-10-19 Carlos Alberto Cortez <calberto.cortez@gmail.com>
3002 Add support for extern alias qualifiers.
3003 * typemanager.cs: Move some LookupTypeReflection code
3004 to namespace.cs, to have cleaner code. Added some methods
3005 to help us keep track of the extern aliased references.
3006 * driver.cs: Add suport for extern alias assemblies on command
3007 line and check for their warnings/errors. Also keep track of the
3008 extern aliased assemblies.
3009 * namespace.cs: Move the global functionality of Namespace
3010 to GlobalRootNamespace/RootNamespace. Now the global namespace
3011 is GlobalRootNamespace.Globa. Also the code moved from
3012 typemanager.cs lives in GlobalRootNames.cs/RootNamespace.cs.
3013 Finally added LocalAliasEntry (AliasEntry before) and
3014 ExternAliasEntry, to handle alias statements.
3015 * cs-parser.jay: Add support in the grammar for extern alias
3017 * doc.cs, delegate.cs, expression.cs ecore.cs, symbolwriter.cs:
3018 Update callings to Namespace (now in GlobalRootNamespace).
3020 2005-10-25 Martin Baulig <martin@ximian.com>
3022 * convert.cs (ImplicitTypeParameterConversion): Make base
3023 interfaces actually work; fixes #76557.
3025 2005-10-25 Martin Baulig <martin@ximian.com>
3028 (GenericMethod.Define): Call TypeParameter.DefineConstraints() on
3029 all the type parameters; fixes #76551.
3031 2005-10-25 Martin Baulig <martin@ximian.com>
3036 (GenericMethod.ctor): Added `Expression return_type' and
3037 `Parameters parameters' arguments.
3038 (GenericMethod.DefineType): Call ResolveAsTypeTerminal() on the
3039 parameter and return types to check their constraints if they're
3042 * codegen.cs (EmitContext.ResolvingGenericMethod): New public
3045 * ecore.cs (Expression.ResolveAsTypeTerminal): Don't check the
3046 constraints of a generic type if `ec.ResolvingGenericMethod'.
3048 * class.cs (MethodCore.DoDefineParameters): Set
3049 `ec.ResolvingGenericMethod' if we're a generic method.
3050 (MemberBase.MemberType): Likewise.
3052 2005-10-25 Carlos Alberto Cortez <calberto.cortez@gmail.com>
3054 * typemanager.cs (TypeManager): Added
3055 TypeManager.internals_visible_attr_type to cache
3056 S.R.CompilerServices.InternalsVisibleToAttribute.
3058 * codegen.cs (AssemblyClass): Added checks for
3059 InternalsVisibleToAttribute in new method
3060 CheckInternalsVisibleAttribute () and also cache the
3061 AssemblyName in AssemblyClass.Name.
3063 2005-10-24 Martin Baulig <martin@ximian.com>
3066 (TypeManager.ExpandInterfaces): Added overloaded version which
3067 just takes a `Type[]' array.
3070 (Constraints.Resolve): Don't expand the interfaces here; ie. we
3071 just use the interfaces which were explicitly specified and not
3072 the interfaces they inherit. Fixes #76482.
3073 (TypeParameter.FindMembers): Expand the interfaces here.
3075 2005-10-21 Martin Baulig <martin@ximian.com>
3078 (Constraints.Resolve): Also resolve the actual types here.
3079 (Constraints.ResolveTypes): Just check the constraints here.
3080 Fixes #76363; see gtest-218.cs.
3082 2005-10-21 Martin Baulig <martin@ximian.com>
3085 (Convert.ImplicitTypeParameterConversion): Use a `ClassCast'
3086 instead of a `BoxedCast'; fixes gtest-217.cs.
3088 2005-10-20 Atsushi Enomoto <atsushi@ximian.com>
3090 * generic.cs : (ConstructedType.CheckConstraints) warn CS0310 when
3091 1) "new()" is specified as generic parameter constraint and 2) the
3092 type is TypeBuilder and 3) the type is abstract even if it has a
3093 default .ctor(). Now errors/gcs0310-3.cs is correctly rejected.
3095 2005-10-20 Martin Baulig <martin@ximian.com>
3098 (GenericConstraints.TypeParameter): New public property.
3099 (TypeParameter.ctor): Also take a `DeclSpace' argument.
3100 (TypeParameter.DeclSpace): New public property.
3101 (TypeParameter.DefineType): Inflate the constraints if our
3102 `DeclSpace' is an `Iterator'.
3104 2005-10-19 Atsushi Enomoto <atsushi@ximian.com>
3106 * class.cs, decl.cs : (MemberCache.FindMemberToOverride) added
3107 GenericMethod argument to compare methods' generic type arguments.
3110 2005-10-19 Martin Baulig <martin@ximian.com>
3112 * class.cs (TypeContainer.DefineType): Only use ResolveAsTypeStep(),
3113 not ResolveType() when resolving the base type, so we're not
3114 checking the constraints here.
3115 (TypeContainer.ResolveType): Call ResolveType() on our base_type
3118 2005-10-19 Martin Baulig <martin@ximian.com>
3120 * generic.cs (ConstructedType.CheckConstraints): Committing
3121 untested fix for #76441.
3123 2005-10-18 Raja R Harinath <rharinath@novell.com>
3126 * class.cs (TypeContainer.DefineType): Move updating of
3127 topological sort earlier in the code.
3128 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Don't use TypeBuilder.
3130 2005-10-18 Marek Safar <marek.safar@seznam.cz>
3133 * cfold.cs (BinaryFold): Reduce constant in enum conversion.
3135 * constant.cs (Constant.TryReduce): Moved from Cast class.
3136 (Reduce): Made little bit more OO and fixed missing conversions.
3138 * ecore.cs (Reduce): Implemented.
3139 (Binary.EnumLiftUp): New method to upgrade values to enum values.
3141 * literal.cs (Reduce): Implemented.
3143 * class.cs: Reverted Miguel's wrong commit.
3145 2005-10-14 Miguel de Icaza <miguel@novell.com>
3147 * ecore.cs (GetMemberType): Report the correct mapping for the MemberCore
3149 2005-10-14 Atsushi Enomoto <atsushi@ximian.com>
3151 * cs-parser.jay, expression.cs : CS0214 was missing error location
3152 for constants. Fixed bug #76404.
3154 2005-10-10 Raja R Harinath <rharinath@novell.com>
3156 * ecore.cs (PropertyExpr.Emit): Use Invocation.EmitCall to emit
3158 (PropertyExpr.EmitCall): Likewise.
3159 * expression.cs (Invocation.EmitArguments): Handle case where
3161 (Invocation.EmitCall): Avoid allocating temporary variable if
3162 there are no arguments.
3164 2005-10-11 Marek Safar <marek.safar@seznam.cz>
3167 * convert.cs (ExplicitConversionCore): Fixed object->enum
3170 2005-10-07 Raja R Harinath <rharinath@novell.com>
3173 * convert.cs (ImplicitConversionStandard): Move conversion of
3174 void* to arbitrary pointer types ...
3175 (ExplicitConversionStandard): .. here.
3176 * ecore.cs (Expression.Error_ValueCannotBeConverted): Fix CS0266
3177 error to always print typenames.
3179 2005-10-07 Raja R Harinath <rharinath@novell.com>
3181 * convert.cs (GetConversionOperator): Rename from
3182 GetConversionOperators. Move operator selection code from ...
3183 (UserDefinedConversion): ... here.
3185 2005-10-06 Marek Safar <marek.safar@seznam.cz>
3187 * convert.cs (ExplicitConversionCore): Removed duplicate enum
3190 2005-10-05 Marek Safar <marek.safar@seznam.cz>
3192 * assign.cs (Assign.DoResolve): Error method changed.
3194 * cfold.cs (DoConstantNumericPromotions): Error method changed.
3196 * const.cs (ResolveValue): Reset in_transit immediately.
3198 * constant.cs: Error method changed.
3200 * convert.cs: Removed useless location parameter.
3201 (ExplicitNumericConversion): Don't do double enum check.
3202 (ExplicitConversionCore): Renamed from ExplicitConversion.
3203 (ExplicitUnsafe): Extracted from ExplicitConversion.
3204 (ExplicitConversion): Uses for error reporting.
3206 * ecore.cs (Error_ValueCannotBeConverted): More logic for more
3208 (ResolveBoolean): Uses common error method.
3209 (CastToDecimal): Get rid of ec.
3210 (CastFromDecimal): Optimized.
3211 (ConvCast): Get rid of ec.
3213 * enum.cs (ResolveValue): Reset in_transit immediately.
3214 (Emit): Return after first error.
3216 * expression.cs: Convert changes.
3218 * literal.cs: Error method changed.
3220 * statement.cs: Error method changed.
3222 2005-10-06 Raja R Harinath <rharinath@novell.com>
3224 Fix gtest-131.cs and gtest-211.cs.
3225 * generic.cs (Nullable.LiftedBinaryOperator.EmitEquality):
3226 Only emit code for a label if it is used. Unreachable code can
3227 violate ECMA evaluation stack invariants.
3229 2005-09-27 Marek Safar <marek.safar@seznam.cz>
3231 * anonymous.cs: Implemented ExprClassName.
3233 * assign.cs (Assign.DoResolve): Don't chrash when type is not
3236 * attribute.cs (ResolveArguments): Enabled MethodImplOptions
3239 * class.cs (StaticClass.DefineContainerMembers): Report protected
3242 * codegen.cs: if(ed) PRODUCTION.
3244 * convert.cs (Error_CannotImplicitConversion): Better error
3247 * cs-parser.jay: More error checks.
3249 * cs-tokenizer.cs (consume_identifier): Fixed Miguel's revert.
3251 * driver.cs (CSCParseOption): Enabled wrong option check.
3253 * ecore.cs (Expression.ExprClassName): Turned to property.
3254 (MemberExpr.CheckIntermediateModification): For checking boxed
3255 value types modification.
3257 * statement.cs (Fixed.Resolve): Expression type must be
3258 convertible to fixed type.
3259 (CollectionForeach.GetEnumeratorFilter,TryType):
3260 Small refactoring for easier error checking.
3262 2005-09-26 Marek Safar <marek.safar@seznam.cz>
3264 * attribute.cs (Attribute.Resolve): Check Obsolete attribute for
3267 * class.cs (GeneratedBaseInitializer): New class for customization
3268 compiler generated initializers.
3269 (MemberBase.DoDefine): Check Obsolete attribute here.
3270 (FieldMember.DoDefine): Ditto.
3272 * const.cs (ExternalConstant.CreateDecimal): Builder for decimal
3275 * decl.cs (MemberCore.EmitContext): Returns valid current ec.
3276 (MemberCore.GetObsoleteAttribute): Removed argument.
3277 (MemberCore.CheckObsoleteness): Obsolete attributes are hierarchic.
3278 (MemberCore.CheckObsoleteType): New helper.
3282 * statement.cs: Updates after MemberCore changes.
3284 * ecore.cs (TypeExpr.ResolveType): Check type obsoleteness here.
3285 (FieldExpr.ResolveMemberAccess): Fixed decimal constants checks.
3287 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't check
3288 obsolete attribute for compiler construct.
3289 (As.DoResolve): Cache result.
3291 * iterators.cs (Define_Constructor): Use GeneratedBaseInitializer.
3293 2005-10-01 Miguel de Icaza <miguel@novell.com>
3295 * expression.cs (Probe): instead of having a "Type probe_type"
3296 keep the extra information as a TypeExpr probe_type_expr since the
3297 "As" operator needs to perform some type checks.
3299 * (As.DoResolve): If the type is a type parameter, ensure that it
3300 is constrained by a class.
3302 2005-09-22 Miguel de Icaza <miguel@novell.com>
3304 * statement.cs (Lock): Use the TemporaryVariable class instead of
3305 manually using local variables as those do not work when variables
3308 * ecore.cs: Moved the TemporaryVariable class from being a nested
3309 class inside Foreach to be a public class that can be employed in
3312 2005-09-19 Marek Safar <marek.safar@seznam.cz>
3314 * cs-parser.jay: interface_accessors replaced by
3315 accessor_declarations.
3317 * ecore.cs, literal.cs, statement.cs: NullLiteral holds null
3320 * statement.cs (GotoCase.Resolve): Convert null constant to
3322 (SwitchLabel.ResolveAndReduce): Ditto.
3323 (SwitchLabel.NullStringCase): Custom null stamp.
3324 (Switch.SimpleSwitchEmit): Fix from NullLiteral to NullStringCase.
3326 typemanager.cs (CSharpSignature): Don't skip first argument
3329 2005-09-16 Marek Safar <marek.safar@seznam.cz>
3331 * cfold.cs, constant.cs, convert.cs, ecore.cs,
3332 expression.cs, iterators.cs, literal.cs: Store constants and
3335 * class.cs (MemberBase.ShortName): Pass location.
3337 * cs-parser.jay: Some location fixes.
3339 * ecore.cs (Expression.Location): Made virtual.
3341 2005-09-27 Marek Safar <marek.safar@seznam.cz>
3344 * const.cs (Const.ResolveValue): Check for assigning non-null
3345 value to reference type.
3347 2005-09-26 Raja R Harinath <rharinath@novell.com>
3350 * expression.cs (This.VerifyFixed): In a value type T, the type of
3351 'this' is T&, iow, 'this' is either an out or ref parameter. In a
3352 value type R, 'this' is treated as a value parameter.
3354 2005-09-05 Miguel de Icaza <miguel@novell.com>
3356 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
3357 if the underlying types are the same, otherwise we need to produce
3358 code that will do the proper cast.
3360 This was exposed by Marek's constant rewrite which produced
3361 invalid code for the call site:
3364 void Method (X v) {}
3368 This fixes test-49.cs
3370 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
3372 * attribute.cs : (Attribute.IsValidArgumentType): array of string/
3373 Type/Object should be allowed as well. Fixed bug #75968.
3375 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
3377 * expression.cs : (Binary.DoResolve): when one is enum constant and
3378 another is constant 0, then return enum one *as enum type*.
3381 2005-10-04 Martin Baulig <martin@ximian.com>
3383 * ecore.cs (PropertyExpr.ResolveAccessors): Cosmetic fix; make the
3384 `SetMemberIsUsed()' work for generics, too.
3386 2005-10-04 Martin Baulig <martin@ximian.com>
3388 * expression.cs (DelegateInvocation.EmitStatement): Make this work
3389 for corlib. Fixes #75691.
3391 2005-09-28 Marek Safar <marek.safar@seznam.cz>
3394 * driver.cs: Fix compilation files with full root path.
3396 2005-09-25 Miguel de Icaza <miguel@novell.com>
3398 * report.cs (SymbolRelatedToPreviousError): Format the output so
3399 it does not use an open parenthesis that is never closed.
3401 * driver.cs: Follow coding guidelines
3403 2005-09-18 Miguel de Icaza <miguel@novell.com>
3405 * driver.cs: Set InEmacs based on the environment variable EMACS.
3407 * location.cs (InEmacs): in this mode, do not report column
3408 location as it confuses Emacs.
3410 2005-10-03 Raja R Harinath <rharinath@novell.com>
3412 * support.cs (SeekableStreamReader.Position): Don't error out when
3413 the requested position is just beyond the end of the current
3416 2005-09-28 Raja R Harinath <rharinath@novell.com>
3418 * support.cs (SeekableStreamReader): Simplify drastically. Don't
3419 try to keep in sync with the byte count of the underlying Stream.
3420 However, this limits us to a window size of 2048 characters: i.e.,
3421 the maximum lookahead of our lexer/parser can be 2048 characters.
3423 2005-09-22 Martin Baulig <martin@ximian.com>
3425 * driver.cs: Removed a debugging FIXME.
3427 2005-09-21 Raja R Harinath <rharinath@novell.com>
3429 * cs-parser.jay (type_arguments): Add CS1644 check.
3430 * decl.cs (DeclSpace.AddToContainer): Restore CS0694 check.
3432 2005-09-15 Raja R Harinath <rharinath@novell.com>
3434 * Makefile (PROGRAM): Make profile specific.
3435 (gmcs.exe) [PROFILE=net_2_0]: Add utility rule to copy gmcs.exe to
3436 the current directory.
3439 * expression.cs (Invocation.EmitCall): Remove optimization on
3440 this_call since it doesn't handle 'this' being a value type.
3442 2005-09-05 Geoff Norton <gnorton@customerdna.com>
3444 * driver.cs: Ensure file handles are closed after parsing
3446 2005-09-05 Miguel de Icaza <miguel@novell.com>
3448 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
3449 if the underlying types are the same, otherwise we need to produce
3450 code that will do the proper cast.
3452 This was exposed by Marek's constant rewrite which produced
3453 invalid code for the call site:
3456 void Method (X v) {}
3460 This fixes test-49.cs
3462 2005-09-05 Martin Baulig <martin@ximian.com>
3464 * expression.cs (As.DoResolve): Use `probe_type.IsValueType'
3465 instead of `TypeManager.IsValueType (probe_type)'; fixes #75668.
3467 * cs-parser.jay (delegate_declaration): Small fix for #75852.
3469 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
3471 * typemanager.cs: (IsUnmanagedType) : generic parameter is not allowed
3472 to be a pointer type due to the spec 25.2, so check if declaring
3473 type is generic type definition. Fixed bug #75772.
3475 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
3478 * generic.cs : (TypeManager.IsEqual(Type,Type)): it should work when
3479 both types are not defined by methods.
3480 * expression.cs : (Invocation.IsApplicable): it should work when
3481 the argument type is equal to the parameter type, not only when
3482 ImplicitConversionExists() returns true.
3484 2005-09-02 Raja R Harinath <rharinath@novell.com>
3486 * attribute.cs (GetMarshal): Work even if "DefineCustom" is
3490 * ecore.cs (SimpleNameResolve.DoSimpleNameResolve): Disable
3491 flow-branching for LocalVariableReferences in case we were invoked
3492 from a MemberAccess.
3493 * expression.cs (LocalVariableReference.VerifyAssigned): New.
3495 (LocalVariableReference.DoResolveBase): ... this.
3496 (MemberAccess.Resolve): Do the check that was disabled during
3499 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
3502 (PartialContainer.Create): check abstract/sealed/static strictly
3503 but abstract/sealed can exist only at one side. Fixed bug #75883.
3505 2005-09-01 Kornél Pál <kornelpal@hotmail.com>
3508 * attribute.cs (Attribute.GetMarshal): If ArraySubType is not
3509 specified, don't default to UnmanagedType.I4.
3511 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
3513 * expression.cs : conditional operator should check possibly
3514 incorrect assign expression. Fixed bug #75946.
3516 2005-08-30 Raja R Harinath <rharinath@novell.com>
3519 * anonymous.cs (ScopeInfo.MakeFieldName): New helper.
3520 (ScopeInfo.EmitScopeType): Use it to construct field names from
3521 names of captured locals.
3524 * ecore.cs (BoxedCast.BoxedCast) [1-argument variant]: Remove.
3525 * convert.cs (ImplicitReferenceConversion, TryImplicitIntConversion):
3526 Pass 'target_type' to BoxedCast. Don't default to 'object'.
3527 (ExplicitConversion): Remove enum cases already handled by
3528 implicit conversion. Move implicit conversion check to the beginning.
3529 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Update.
3530 * expression.cs (ArrayCreation.EmitDynamicInitializers):
3531 Don't treat System.Enum as a struct.
3533 2005-08-30 Jb Evain <jbevain@gmail.com>
3535 * attribute.cs: handles as expression in parameters.
3537 2005-08-30 Raja R Harinath <rharinath@novell.com>
3540 * class.cs (TypeContainer.VerifyClsName): Don't use a
3541 PartialContainer when verifying CLS compliance.
3542 (AbstractPropertyEventMethod): Set Parent here, ...
3543 (PropertyMethod): ... not here.
3545 2005-08-30 Atsushi Enomoto <atsushi@ximian.com>
3547 * attribute.cs : escaped attribute name should not be allowed to be
3548 resolved (e.g. @class as classAttribute). Fixed bug #75930.
3550 2005-08-29 Raja R Harinath <rharinath@novell.com>
3553 * convert.cs (ImplicitStandardConversionExists): Allow zero also
3554 when converting a long constant to unsigned long.
3555 * expression.cs (Invocation.OverloadResolve): Add sanity check to
3556 detect where IsApplicable and VerifyArgumentsCompat disagree.
3558 2005-08-29 Raja R Harinath <rharinath@novell.com>
3559 and Carlos Alberto Cortez <carlos@unixmexico.org>
3562 * class.cs (TypeContainer.CanElideInitializer): New helper.
3563 (TypeContainer.EmitFieldInitializers): Use it to determine if we
3564 can safely emitting the initializer of a field.
3566 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
3568 * statement.cs : (Continue.Resolve()) Unlike break, continue is not
3569 allowed inside a switch (without loop). Fixed bug #75433.
3571 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
3573 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
3574 * mcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
3576 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
3578 * driver.cs : kinda reverting the default encoding changes (not exact
3579 revert since I noticed that "codepage:reset" might not work fine).
3581 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
3583 * class.cs : (AbstractPropertyEventMethod) SetupName() now takes
3584 Location. Now getter and setter store location correctly.
3585 (errors/cs0111-12.cs now reports the expected location.)
3587 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
3589 * driver.cs : Use default encoding on the environment.
3590 Removed (now that) extra parameter for SeekableStreamReader.
3591 * support.cs : (SeekableStreamReader) third .ctor() argument for
3592 StreamReader is not required (always true). preamble size could
3593 be acquired in simpler and safe way.
3595 2005-08-24 Atsushi Enomoto <atsushi@ximian.com>
3597 * cs-parser.jay: report CS0642 at warning level 3
3598 and report CS0642 for an if else statement also
3599 fixes bug #74745. Patch by John Luke (and a bit
3601 Removed extra CS0642 warning check for "while",
3603 * statement.cs: In Block.Resolve(), CS0642 check
3604 is reimplemented to check a sequence of an empty
3605 statement and a block.
3607 Both fix bug #66777.
3609 2005-08-24 Marek Safar <marek.safar@seznam.cz>
3611 * attribute.cs (GetMethodObsoleteAttribute): Disabled obsolete properties
3612 detection until I fix it.
3614 * cs-tokenizer.cs: Changed error message.
3616 * cs-parser.jay: Fixed 2 error locations.
3618 * ecore.cs (Error_TypeDoesNotContainDefinition): Share error message.
3619 (PropertyExpr.Error_PropertyNotFound): First attempt to detect non C#
3622 * enum.cs (GetSignatureForError): Fixed.
3624 * expression.cs (Invocation.IsSpecialMethodInvocation): Improved special
3628 * typemanager.cs (RegisterProperty): Removed.
3630 * statement.cs (CheckInvariantMeaningInBlock): Changed error message.
3632 2005-08-24 Raja R Harinath <rharinath@novell.com>
3635 * expression.cs (ArrayAccess.EmitLoadOpcode): Emit ldelem.i for pointers.
3636 (ArrayAccess.GetStoreOpcode): Return stelem.i for pointers.
3638 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
3640 * expression.cs : tiny fix is required for not warning positive ulong.
3643 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
3645 * expression.cs : add CS0652 check for constant and integral
3646 expression. Fixed bug #53974.
3648 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
3650 * expression.cs : in DoNumericPromotions(), check if there is implicit
3651 conversion overload for string (to check CS0034). Fixed bug #52492.
3653 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
3655 * cs-tokenizer.cs : Check newline in char constant. Fixed bug #75245.
3657 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
3659 * ecore.cs : report location when it is *not* Null.
3661 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
3667 Added OmitStructFlowAnalysis to EmitContext to handle CS0165 check
3668 correctly. Fixed bug #75721.
3670 2005-08-23 Raja R Harinath <rharinath@novell.com>
3672 * support.cs (SeekableStreamReader.Position): Avoid an expensive
3673 loop that performs 'min (pos, char_count)'.
3676 * expression.cs (Unary.ResolveOperator): Don't discard implicit
3677 converted value in Operator.OnesComplement.
3679 2005-08-22 Ben Maurer <bmaurer@ximian.com>
3681 * anonymous.cs: If the anon method is pulled into a helper class,
3682 it needs to be `internal' not `private'. Fixes runtime behavior on
3685 2005-08-17 Marek Safar <marek.safar@seznam.cz>
3688 * decl.cs (DeclSpace.VerifyClsCompliance): Skip when collision object
3691 2005-08-16 Marek Safar <marek.safar@seznam.cz>
3693 The big constants rewrite
3694 Fix #75746, #75685 and more
3695 As a side effect saved 1MB for MWF ;-)
3697 * attribute.cs (GetAttributeArgumentExpression): Use ToType, GetTypedValue.
3698 (GetMarshal, GetMethodImplOptions, GetLayoutKindValue): Values are not
3699 enum based for corlib compilation.
3701 * cfold.cs (BinaryFold): Convert operand for enum additions. Fixed enum
3704 * class.cs (FixedField.Define): Use ResolveAsConstant.
3706 * const.cs (IConstant): Interface constants and enums.
3707 (Const.ResolveValue): New method for constant resolvning.
3708 (ExternalConstant): Constants from imported assemblies.
3710 * constant.cs (Constant.GetTypedValue): Used to get constant with forced
3711 conversion; like enums.
3712 (Constant.ToType): Converts this constant to different type.
3713 (Constant.Increment): Adds 1.
3715 * convert.cs (ImplicitConversionRequired): Simplified.
3717 * cs-parser.jay: Create EnumMember directly.
3719 * decl.cs (MemberCore.CheckObsoleteness): Checks for ObsoleteAttribute presence.
3721 * doc.cs (GenerateEnumDocComment): Removed.
3723 * ecore.cs (Expression.ResolveAsConstant): New constant specific method.
3724 (ConvertIntLiteral): Removed.
3725 (FieldExpr.ResolveMemberAccess): Refactored to remove constant specific if(s).
3727 * enum.cs (EnumMember): Implement IConstant.
3728 (Enum.IsValidEnumConstant): Removed.
3729 (Enum.GetNextDefaultValue): Removed.
3730 (Enum.FindMembers): Updated.
3731 (Enum.GenerateDocComment): Iterate enum members.
3733 * expression.cs (Cast.TryReduce): Handle enums correctly.
3734 (New.Constantify): Made public.
3735 (MemberAccess.DoResolve): Removed contant specific if(s).
3737 * literal.cs (NullLiteral): Implement new abstract methods.
3739 * statement.cs (GotoCase.Resolve): Use new constant methods.
3740 (SwitchLabel.ResolveAndReduce): Use new constant methods.
3742 * typemanager.cs (LookupEnum): Removed.
3743 (IsEnumType): Fixed to work with corlib.
3744 (RegisterConstant): Removed.
3745 (LookupConstant): Removed.
3746 (GetConstant): Changed to work with IConstant.
3748 2005-08-04 Atsushi Enomoto <atsushi@ximian.com>
3750 * location.cs : Fixed overflown (>255) column number.
3752 2005-08-03 Raja R Harinath <rharinath@novell.com>
3754 First cut of the qualified-alias-member feature.
3755 * cs-tokenizer.cs (Tokenizer.is_punct): Recognize the double-colon
3757 * cs-parser.jay (DOUBLE_COLON): New token.
3758 (namespace_or_type_name): Add rule for recognizing
3759 qualified-alias-members.
3760 (primary_expression): Likewise.
3761 (element_access): Allow QualifiedAliasMember as a possible
3762 type-bearing expression.
3763 (local_variable_type, local_variable_pointer_type): Likewise.
3764 * namespace.cs (NamespaceEntry.LookupAlias): New. Looks up
3765 aliases in the current and enclosing namespace declarations.
3766 (NamespaceEntry.UsingAlias): Add CS0440 warning.
3767 * decl.cs (MemberName.is_double_colon): New.
3768 (MemberName.MemberName): Add new constructor for alias-member.
3769 (MemberName.GetTypeExpression): Generate QualifiedAliasMember too.
3770 * expression.cs (QualifiedAliasMember): New expression type.
3772 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
3774 * location.cs : it borked when no argument was specified.
3776 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
3778 * location.cs : tiny ToString() format fix.
3780 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
3782 * statement.cs : oops, it was missing.
3784 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
3786 A set of fixes for precise line/column location.
3789 "token" field now holds a file/line "delta", a line number offset
3790 from the segment, and a column number. See also:
3791 http://lists.ximian.com/pipermail/mono-devel-list/2004-
3792 December/009508.html
3793 Removed static IsNull. Use instance IsNull property instead.
3795 For some tokens it stores Location. For Identifier it stores
3796 LocatedToken which is a pair of string name and location.
3797 Column numbers are adjusted only at getChar().
3799 Use Location.ToString() for reporting (it now contains column).
3801 Largely modified to use LocatedToken instead of
3802 string (IDENTIFIER), and to acquire Location from some tokens.
3803 * namespace.cs, decl.cs, ecore.cs, class.cs, delegate.cs,
3804 iterators.cs, const.cs, anonymous.cs, tree.cs, enum.cs,
3806 Now MemberName holds Location. DeclSpace.ctor() receives Location
3807 as a parameter. Removed extra parameters to all derived classes.
3808 Replaced Location.IsNull() with instance property.
3809 * assign.cs, expression.cs :
3810 Added .ctor() overload that omits Location.
3812 Added "nameEscaped" flag that indicates the identifier was escaped
3813 in the source file. This fixes bug #57047.
3815 2005-09-02 Martin Baulig <martin@ximian.com>
3817 * class.cs: Make CS3005 a warning, not an error.
3819 2005-08-02 Marek Safar <marek.safar@seznam.cz>
3821 * attribute.cs (AttributeTester.GetImportedIgnoreCaseClsType):
3822 New method, looking for lo-case imported cls type.
3824 * decl.cs (DeclSpace.VerifyClsCompliance): Check CS3005 for types
3827 * driver.cs: Removed VerifyTopLevelNameClsCompliance usage.
3829 * enum (Enum.VerifyClsCompliance): Hardcode non-compliant types.
3831 * typemanager.cs (TypeManager.AllClsTopLevelTypes): Renamed from
3833 (TypeManager.LoadAllImportedTypes): Lo-case imported types.
3835 Optimized to save 3.5 MB for SWF compilation.
3837 2005-08-01 Marek Safar <marek.safar@seznam.cz>
3839 * class.cs (AddToTypeContainer): Use inheritance insted of if(s).
3840 (PartialContainer.Create): Moved logic AddToContainer.
3841 (PartialContainer.MarkForDuplicationCheck): Shares name.
3843 * decl.cs (DeclSpace.AddToContainer): Check name collisions at one
3846 * namespace.cs (Namespace.AddDeclSpace): Lazy declspaces
3848 (Namespace.GetSignatureForError): New method.
3850 * tree.cs (Tree.RecordDecl): Moved to AddToContainer.
3851 (RootTypes.AddToTypeContainer): se inheritance insted of if(s).
3853 2005-08-01 Raja R Harinath <rharinath@novell.com>
3856 * ecore.cs (Expression.MemberLookupFailed): Use queried_type for
3857 member lookup rather than qualifier_type, since qualifier_type can
3860 2005-08-01 Marek Safar <marek.safar@seznam.cz>
3862 * enum.cs (Enum.VerifyClsName): Fixed to allow not CLSCompliant
3865 2005-07-31 Miguel de Icaza <miguel@novell.com>
3867 * statement.cs: Copy the local exception into the exception
3868 captured local. Fixes 75674
3870 2005-07-31 Raja R Harinath <harinath@gmail.com>
3873 * expression.cs (Invocation.OverloadResolve): Don't report error
3874 CS1501 if error CS1502 has been reported.
3875 (New.DoResolve): Delegate CS1501 reporting to
3876 Invocation.OverloadResolve.
3879 * statement.cs (Block.CheckInvariantMeaningInBlock): Verify
3880 invariant-meaning-in-block property in an enclosing block if
3883 2005-07-29 Marek Safar <marek.safar@seznam.cz>
3885 * statement.cs (SwitchLabel.ResolveAndReduce): Refactored.
3886 (SwitchLabel.Erorr_AlreadyOccurs): Share error message.
3887 (Switch.CheckSwitch): Just save 50kb for SWF.
3889 2005-07-27 Martin Baulig <martin@ximian.com>
3891 * anonymous.cs (CaptureContext.AddField): Added
3892 `AnonymousContainer am' argument; compute its toplevel scope if
3893 it's not already computed. Fixes #75649.
3895 2005-07-26 Raja R Harinath <rharinath@novell.com>
3898 * class.cs (Constructor.Emit): Reset block to null if the block
3901 2005-07-25 Marek Safar <marek.safar@seznam.cz>
3903 * class.cs (TypeContainer.VerifyMembers): Be compatible in warning 169.
3905 2005-07-25 Marek Safar <marek.safar@seznam.cz>
3907 * class.cs (MethodData.Define): Check whether accessor implementing
3908 interface is public.
3910 * driver.cs (Driver.parse): Try to be smart and check for `MZ' header.
3912 2005-07-22 Marek Safar <marek.safar@seznam.cz>
3915 * namespace.cs (LookupType): Moved same type check to...
3917 * typemanager.cs (LookupTypeReflection): Don't allow to import more types
3920 2005-07-21 Raja R Harinath <rharinath@novell.com>
3922 * namespace.cs (NamespaceLookupType): Avoid a string allocation when we
3923 already found a typebuilder.
3924 * class.cs (MethodCore.IsDuplicateImplementation): Compare
3925 MemberNames, not strings.
3927 * const.cs (Error_ExpressionMustBeConst):
3928 Rename from Error_EpressionMustBeConst.
3929 * const.cs, class.cs, statement.cd: Update.
3931 2005-07-21 Marek Safar <marek.safar@seznam.cz>
3935 * const.cs (Const.LookupConstantValue): Report missing contant expression
3937 (Error_EpressionMustBeConstant): Only one error method.
3939 * class.cs, statement.c: Updated.
3941 2005-07-20 Raja R Harinath <rharinath@novell.com>
3943 * statement.cs (Block.Flags): Add back HasVarargs.
3944 (Block.flags): Make protected.
3945 (ToplevelBlock.HasVarargs): Convert to a property that updates flags.
3947 * typemanager.cs (types, typecontainers, user_types): Remove.
3948 (UserTypes, TypeContainers): Likewise.
3949 (HandleDuplicate, AddDelegateType, AddEnumType): Likewise.
3950 (CleanUp, Reset): Update.
3951 (AddUserType): Combine variants. Now, only updates builder_to_declspace.
3952 (GetNestedType): Use Type.GetNestedType.
3953 (CoreLookupType): Take two arguments, the namespace and the
3954 basename of the type. Update to use the Namespace.Lookup
3956 (InitEnumUnderlyingTypes, InitCoreTypes): Update.
3957 (RealMemberLookup): Use IsNestedChildOf instead of playing with
3958 string concatenation and substring matches.
3959 * class.cs, enum.cs, delegate.cs: Update to changes.
3961 2005-07-20 Marek Safar <marek.safar@seznam.cz>
3963 * constant.cs (Constant.Error_ConstantValueCannotBeConverted): Moved from
3964 Expression and made virtual.
3966 * convert.cs (ImplicitReferenceConversionExists): Skip for value types.
3967 (ImplicitStandardConversionExists): Fixed `byte' typo ?
3969 * ecore.cs (Expression.Error_ConstantValueCannotBeConverted): Moved.
3971 * literal.cs (NullLiteral.Error_ConstantValueCannotBeConverted): Customize
3974 * convert.cs, ecore.cs, enum.cs: Reflect Error_ConstantValueCannotBeConverted
3977 2005-07-18 Marek Safar <marek.safar@seznam.cz>
3980 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Check whether
3981 AssemblyCultureAttribute is not used on executable.
3984 * typemanager.cs: Add System.Reflection.AssemblyCultureAttribute.
3986 2005-07-16 Raja R Harinath <rharinath@novell.com>
3989 * expression.cs (Binary.Warning_UnintendeReferenceComparison):
3990 New. Reports CS0252/CS0253.
3991 Mostly taken from preliminary patch by Duncak Mak.
3992 (Binary.DoResolveOperator): Store results of operator lookup.
3993 Use them to detect if we need to warn about unintended reference
3996 2005-07-15 Raja R Harinath <rharinath@novell.com>
3999 * namespace.cs (Namespace.Lookup): Add back location parameter.
4000 (Namespace.LookupType): Add CS0436 report. Add location parameter.
4001 * delegate.cs, ecore.cs, expression.cs: Update to changes.
4003 * codegen.cs (EmitContext.DeclSpace): Make readonly.
4004 * namespace.cs (Namespace.Lookup): Carve out type lookup into ...
4005 (Namespace.LookupType): ... this.
4006 (NamespaceEntry.GetUsingTable): Allocate only one zero-sized array
4008 * typemanager.cs (LookupTypeReflection): Remove buggy code that
4009 purported to handle pointers.
4010 (char_ptr_type, void_ptr_type): Use GetPointerType rather than
4013 2005-07-15 Marek Safar <marek.safar@seznam.cz>
4015 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
4018 2005-07-15 Raja R Harinath <rharinath@novell.com>
4020 * namespace.cs (Namespace.Lookup): Drop location parameter.
4021 (NamespaceEntry.LookupAlias): Remove. Merge into ...
4022 (NamespaceEntry.Lookup): ... this.
4023 (NamespaceEntry.Error_AmbiguousTypeReference):
4024 Move here from DeclSpace.
4025 (NamespaceEntry.LookupNamespaceOrType): Move support for dotted
4027 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): ... here.
4028 * decl.cs (DeclSpace.ErrorAmbiguousTypeReference):
4029 Move to NamespaceEntry.
4030 * delegate.cs, expression.cs: Update to changes.
4032 2005-08-31 Martin Baulig <martin@ximian.com>
4034 Committing a patch from Atsushi Enomoto for #75850.
4036 * statement.cs (Foreach.CollectionForeach.GetEnumeratorFilter):
4037 Prefer a generic enumerator over a non-generic one.
4039 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
4041 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
4042 * gmcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
4044 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
4046 * driver.cs : reverting default encoding change as well as mcs.
4048 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
4050 * driver.cs, support.cs : merged r48826.
4052 > could you integrate your mcs changes to gmcs otherwise
4053 > gmcs cannot compile some files.
4055 2005-08-20 Martin Baulig <martin@ximian.com>
4057 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
4058 scope if we don't already have it.
4060 * expression.cs (Invocation.EmitCall): Use `ec.EmitThis ()' rather
4061 than `ig.Emit (OpCodes.Ldarg_0)' to make it work inside iterators;
4064 2005-07-31 Miguel de Icaza <miguel@novell.com>
4066 * statement.cs: Copy the local exception into the exception
4067 captured local. Fixes 75674
4069 2005-07-15 Marek Safar <marek.safar@seznam.cz>
4071 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
4074 2005-08-12 Martin Baulig <martin@ximian.com>
4076 * expression.cs (MemberAccess.ResolveNamespaceOrType): Only search
4077 for nested types here to avoid hitting the cache too early.
4079 2005-08-09 Miguel de Icaza <miguel@novell.com>
4081 * enum.cs: On the new compiler CLS error 3005 is now a warning not
4084 2005-08-03 Martin Baulig <martin@ximian.com>
4086 Make iterators in generic methods work; see gtest-191.cs.
4089 (Constraints.Resolve): Protect against being called twice.
4092 (TypeContainer.GetClassBases): Make this `protected virtual'.
4094 * iterator.cs (Iterator.ctor): Added `GenericMethod' argument.
4095 (Iterator.GetClassBases): Override this and compute the base
4097 (Iterator.DefineNestedTypes): If we're a generic method, all our
4098 method type parameters become class type parameters on the proxy
4102 (ToplevelBlock.Parameters): Make this a property, not a field.
4103 (ToplevelBlock.ResolveMeta): Update the `parameters' from the `ip'.
4105 2005-08-03 Martin Baulig <martin@ximian.com>
4107 * typemanager.cs (TypeManager.IsSubclassOf): Use
4108 `TypeManager.IsEqual' instead of `Type.Equals'; fixes gtest-190.cs.
4109 (TypeManager.GetFullName_recursed): Improved.
4111 2005-07-27 Carlos Alberto Cortez <calberto.cortez@gmail.com>
4114 * ecore.cs (Expression.IsAccessorAccessible): Change the check for
4115 Private accessor case, using TypeManager.IsPrivateAccessible instead of
4116 invocation_type == mi.DeclaringType, since the first one also checks
4117 other condition used by generic instances.
4119 2005-07-27 Martin Baulig <martin@ximian.com>
4121 * anonymous.cs (CaptureContext.AddField): Added
4122 `AnonymousContainer am' argument; compute its toplevel scope if
4123 it's not already computed. Fixes #75649.
4125 2005-07-14 Marek Safar <marek.safar@seznam.cz>
4127 * attribute.cs (Attribute.ResolveAttributeType): Renamed from
4128 CheckAttributeType and refactored.
4129 (Attribute.ResolvePossibleAttributeType): Changed to reuse
4130 ResolveAsTypeTerminal error handling.
4131 (ResolveAsTypeTerminal): Introduced because of global attributes extra
4133 (GetSignatureForError): Print errors in same way.
4136 * codegen.cs: Reflect attribute GetSignatureForError change.
4139 * expression.cs: Add silent parameter to ResolveAsTypeStep.
4141 * namespace.cs (UsingEntry): Refactored to make fields private.
4144 statement.cs: Error_UnexpectedKind has extra parameter.
4146 2005-07-14 Raja R Harinath <rharinath@novell.com>
4148 * ecore.cs (IAlias): Remove.
4149 * decl.cs (DeclSpace): Don't derive from IAlias. Remove members
4150 that implement the interface.
4151 * namespace.cs (Namespace): Likewise.
4152 (Namespace.declspaces): Renamed from 'defined_names'.
4153 (Namespace.AddDeclSpace): Renamed from 'DefineName'. Take a
4154 DeclSpace instead of an IAlias.
4155 * tree.cs (Tree.AddDecl): Update.
4157 2005-07-12 Raja R Harinath <rharinath@novell.com>
4159 * statement.cs (Block.Flags); Remove HasVarargs.
4160 (Block.HasVarargs): Move to ToplevelBlock.
4161 (Block.ThisVariable, Block.AddThisVariable): Likewise.
4162 (Block.Variables): Make protected. Initialize variable hashtable
4164 (Block.AddVariable): Update.
4165 (Block.Resolve): Update to changes.
4166 (ToplevelBlock.HasVarargs): New boolean.
4167 (ToplevelBlock.ThisVariable): Move here from Block.
4168 (ToplevelBlock.AddThisVariable): Likewise.
4169 (ToplevelBlock.IsThisAssigned): New. Forwards call to this_variable.
4170 * expression.cs (This.ResolveBase): Update to changes.
4171 (ArglistAccess.DoResolve): Likewise.
4173 2005-07-11 Marek Safar <marek.safar@seznam.cz>
4176 * ecore.cs, class.cs: Use SetAssigned instead of direct access.
4178 * class.cs (TypeContainer.VerifyMembers): Distinguish between
4179 not used and not used & assigned.
4180 (FieldBase.ASSIGNED): Moved to MemberCore.Flags.
4182 2005-07-11 Marek Safar <marek.safar@seznam.cz>
4185 * expression.cs (Is.DoResolve): null is never provided type.
4187 2005-07-08 Marek Safar <marek.safar@seznam.cz>
4190 * cs-parser.jay: Less strict event error rule to catch more errors.
4192 2005-07-11 Martin Baulig <martin@ximian.com>
4194 * generic.cs (ConstructedType.CheckConstraints): Improve the check
4195 for the constructor constraint: we do not only have to check
4196 whether the class has a public constructor, but also ensure that
4197 it's parameterless. Fixes #75492.
4199 2005-07-11 Martin Baulig <martin@ximian.com>
4201 * expression.cs (Binary.ResolveOperator): Only allow `==' and `!='
4202 between type parameters if they either have the reference type
4203 constraint or the class constraint.
4205 2005-07-10 Kamil Skalski <nazgul@nemerle.org>
4207 * generic.cs: Use MakeGenericType instead of BindGenericParameters.
4209 2005-07-07 Marek Safar <marek.safar@seznam.cz>
4212 * attribute.cs (orig_sec_assembly): Holds original version of assembly.
4213 (ExtractSecurityPermissionSet): Cope with self referencing security
4214 attributes properly.
4216 * driver.cs (SetOutputFile): Made public property OutputFile.
4218 2005-07-07 Raja R Harinath <rharinath@novell.com>
4221 * class.cs (TypeContainer.first_nonstatic_field): Rename from
4222 has_nonstatic_fields. Make into a FieldBase pointer.
4223 (TypeContainer.AddField): Add CS0282 check.
4224 (TypeContainer.EmitType): Update.
4226 2005-07-06 Miguel de Icaza <miguel@novell.com>
4228 * cs-tokenizer.cs (consume_identifier): Do not create strings to
4229 compare if they start with __.
4231 2005-07-06 Raja R Harinath <rharinath@novell.com>
4233 * statement.cs (Switch.SwitchGoverningType): Only look at
4234 UserCasts that don't need implicit standard conversions to one of
4235 the allowed switch types (Fixes test-322.cs).
4236 (LocalInfo.Resolve): Re-enable sanity-test.
4238 2005-07-06 Marek Safar <marek.safar@seznam.cz>
4240 * cs-tokenizer.cs (consume_identifier): Detect double undescores
4242 * ecore.cs (FieldExpr.AddressOf): Changed volatile error to warning.
4244 * expression.cs (Invocation.DoResolve): Report error CS0245 here.
4246 2005-07-06 Raja R Harinath <rharinath@novell.com>
4249 * ecore.cs (SimpleName.GetSignatureForError): Add.
4250 * expression.cs (MemberAccess.DoResolve): Don't clobber 'expr' field.
4251 (MemberAccess.GetSignatureForError): Add.
4253 2005-07-05 Marek Safar <marek.safar@seznam.cz>
4255 The big error and warning messages review.
4285 * typemanager.cs: Updated.
4287 * class.cs: (MethodCore.SetYields): Moved here to share.
4288 (PropertyMethod.Define): Moved iterator setup here.
4290 * iterators.cs: Add orig_method to have full access to parent
4293 2005-07-05 Raja R Harinath <rharinath@novell.com>
4295 Make 'fixed variable' handling standards compliant. Fix #70807, #72729.
4296 * ecore.cs (IVariable.VerifyFixed): Remove 'is_expression' parameter.
4297 (FieldExpr.VerifyFixed): Ensure that the field is part of a fixed
4298 variable of struct type.
4299 * expression.cs (Unary.ResolveOperator): Update to change.
4300 (Indirection.VerifyFixed): Likewise.
4301 (LocalVariableReference.VerifyFixed): A local variable is always fixed.
4302 (ParameterReference.VerifyFixed): Value parameters are fixed.
4303 (This.VerifyFixed): Treat 'this' as a value parameter.
4304 * statement.cs (LocalInfo.IsFixed): Remove.
4306 2005-07-01 Martin Baulig <martin@ximian.com>
4308 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
4309 `ec.EmitThis ()' to get the correct scope.
4311 2005-07-01 Martin Baulig <martin@ximian.com>
4313 * ecore.cs (FieldExpr.DoResolve): Don't capture the field if it's
4314 instance is a ParameterReference; fixes #75299.
4316 2005-06-30 Raja R Harinath <rharinath@novell.com>
4319 * expression.cs (Indexers.map): Remove.
4320 (Indexers.Append): Filter out inaccessible setters and getters.
4321 (IndexerAccess.DoResolve, IndexerAccess.DoResolveLValue): Update.
4324 * ecore.cs (MemberExpr.EmitInstance): New. Add CS0120 check.
4326 (FieldExpr.EmitInstance, PropertyExpr.EmitInstance): ... these.
4327 (FieldExpr.Emit, PropertyExpr.Emit): Update.
4328 (FieldExpr.EmitAssign, PropertyExpr.EmitAssign): Update.
4329 * expression.cs (Invocation.EmitCall): Add CS0120 check.
4331 2005-06-30 Marek Safar <marek.safar@seznam.cz>
4334 * class.cs (FieldBase.GetInitializerExpression): One more field
4337 2005-06-28 Miguel de Icaza <miguel@novell.com>
4339 * pending.cs: Do not define a proxy if the base method is virtual,
4340 it will be picked up by the runtime (bug 75270).
4342 2005-07-08 Martin Baulig <martin@ximian.com>
4344 * anonymous.cs (CaptureContext.EmitParameterInstance): Correctly
4345 handle parameters in nested scopes; fixes #74808; see gtest-188.cs.
4347 2005-07-07 Martin Baulig <martin@ximian.com>
4349 * generic.cs (ConstructedType.CheckConstraint): Use
4350 ResolveAsTypeStep(), not ResolveAsTypeTerminal() so we're not
4351 called recursively; fixes #75329.
4353 2005-07-06 Martin Baulig <martin@ximian.com>
4355 * generic.cs (TypeManager.InferTypeArguments): Added support for
4356 anonymous methods; fixes #75461.
4358 2005-07-01 Martin Baulig <martin@ximian.com>
4360 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
4361 `ec.EmitThis ()' to get the correct scope.
4363 2005-07-01 Martin Baulig <martin@ximian.com>
4365 * ecore.cs (FieldExpr.DoResolve): Only capture the field if it's
4366 instance is `This'; fixes #75299.
4368 2005-06-30 Martin Baulig <martin@ximian.com>
4370 * class.cs (Indexer): Implement IIteratorContainer; added support
4371 for iterators in indexers.
4374 (EmitContext.CurrentIterator): Make this a property, not a field.
4376 * anonymous.cs (AnonymousContainer.Iterator): New public property.
4378 2005-06-28 Miguel de Icaza <miguel@novell.com>
4380 * pending.cs: Do not define a proxy if the base method is virtual,
4381 it will be picked up by the runtime (bug 75270).
4383 2005-06-28 Martin Baulig <martin@ximian.com>
4385 * cs-parser.jay (interface_method_declaration): Avoid a
4386 reduce/reduce conflict by moving some of the code into a separate
4387 `interface_method_declaration_body' rule; fixes #75368.
4389 2005-06-28 Martin Baulig <martin@ximian.com>
4391 * typemanager.cs (TypeManager.MemberLookup_FindMembers): Move the
4392 array check after the check for TypeBuilder's.
4394 2005-06-21 Raja R Harinath <rharinath@novell.com>
4396 * convert.cs (FindMostEncompassedType): Add two trivial special
4397 cases (number_of_types == 0 || number_of_types == 1).
4398 (FindMostEncompasingType): Likewise.
4400 2005-06-17 Raja R Harinath <rharinath@novell.com>
4402 Some cleanups preparing for the fix of #75283.
4403 * ecore.cs (PropertyExpr.InstanceResolve): Tighten conditions for
4405 (EventExpr.InstanceResolve): Likewise.
4406 (EventExpr.DoResolve): Remove redundant checks.
4408 2005-06-08 Miguel de Icaza <miguel@novell.com>
4410 * class.cs: Small fix.
4412 2005-06-08 Raja R Harinath <rharinath@novell.com>
4415 * class.cs (GetPartialBases): Fix return value check of
4418 2005-06-07 Raja R Harinath <rharinath@novell.com>
4420 Ensure that partial classes are registered in their enclosing
4421 namespace. Initial part of fix of #75160.
4422 * tree.cs (Tree.RecordDecl): Add new namespace argument.
4423 Register declspace with namespace here, not in
4424 DeclSpace.RecordDecl.
4425 * cs-parser.jay: Pass namespace to RecordDecl.
4426 * class.cs (PartialContainer.Create): Likewise.
4427 (ClassPart.DefineType): New sanity-check. Throws an exception if
4429 * decl.cs (Declspace.RecordDecl): Remove.
4430 * namespace.cs (NamespaceEntry.DefineName): Remove.
4432 2005-06-06 Marek Safar <marek.safar@seznam.cz>
4434 * rootcontext.cs: Reset TargetExt as well.
4436 2005-06-03 Raja R Harinath <rharinath@novell.com>
4438 * ecore.cs (Expression.Resolve): Emit CS0654 error when
4441 2005-06-02 Raja R Harinath <rharinath@novell.com>
4443 Fix #75080, cs0119.cs.
4444 * ecore.cs (Expression.ExprClassToResolveFlags): New. Broken out
4446 (Expression.Resolve): ... this. Use it. Remove bogus code
4447 allowing ExprClass.Type and ExprClass.Namespace for
4448 ResolveFlags.VariableOrValue.
4449 (Expression.Resolve) [1-argument variant]: Change default resolve
4450 flags based on language version.
4451 (Expression.Error_UnexpectedKind): Use a simple string array
4452 rather than an ArrayList.
4453 * expression.cs (TypeOf.DoResolve): Set eclass to ExprClass.Value,
4455 (TypeOfVoid.DoResolve): Likewise.
4456 (MemberAccess.DoResolve) [3-argument variant]: Make private. Drop
4457 flags argument -- it always has the same value.
4459 2005-05-31 Raja R Harinath <rharinath@novell.com>
4462 * ecore.cs (Expression.ResolveLValue): Add a Location parameter.
4463 Use it in the error message.
4464 * assign.cs, expression.cs, statement.cs: Update.
4466 2005-05-30 Raja R Harinath <rharinath@novell.com>
4469 * ecore.cs (Expression.MemberLookupFailed): Add CS0122 check in
4470 the "almostMatchedMember" case too.
4471 * typemanager.cs (Closure.CheckValidFamilyAccess): Add anything
4472 that failed the accessibility checks to 'almost_match'.
4474 2005-05-27 Vladimir Vukicevic <vladimir@pobox.com>
4476 * attribute.cs: Use internal MethodBuilder methods to set
4477 ExactSpelling and SetLastError on PInvoke methods, instead
4478 of passing them via charset. Fixes #75060.
4480 2005-05-27 Raja R Harinath <rharinath@novell.com>
4482 * parameter.cs (Parameter): Remove TODO comment.
4483 (Parameter.DefineParameter): Remove Location parameter.
4484 (Parameters.LabelParameters): Likewise.
4485 * class.cs (Constructor.Emit): Update to change.
4486 (MethodData.Emit): Likewise.
4487 * anonymous.cs (AnonymousMethod.EmitMethod): Likewise.
4488 * delegate.cs (Delegate.Define, Delegate.Emit): Likewise.
4490 2005-05-27 Atsushi Enomoto <atsushi@ximian.com>
4493 Removed Parameters.Location and added Parameter.Location instead.
4494 Removed Location parameter from Emit() and GetSignature().
4501 Modified all related calls.
4503 2005-06-21 Martin Baulig <martin@ximian.com>
4505 * generic.cs (NullCoalescingOperator.Emit): Make this work if the
4506 left-hand side is not a nullable type; fixes #75328.
4508 2005-06-21 Martin Baulig <martin@ximian.com>
4511 (TypeManager.CSharpName): Use GetFullName() instead of `t.FullName'.
4512 (TypeManager.GetFullNameSignature): Likewise.
4514 * convert.cs (Convert.Error_CannotImplicitConversion): Compare
4515 `source.FullName' and `target.FullName' to check whether there are
4516 two conflicting definitions.
4518 2005-06-21 Martin Baulig <martin@ximian.com>
4520 * convert.cs (Convert.ImplicitTypeParameterConversion): Always use
4521 a BoxedCast - also for reference types - to be compatible with csc.
4523 2005-06-21 Martin Baulig <martin@ximian.com>
4525 * expression.cs (MemberAccess.DoResolve): Add support for nested
4526 types in a generic instance; fixes #75320.
4528 2005-06-20 Martin Baulig <martin@ximian.com>
4530 * generic.cs (TypeManager.InferType): Also walk the class
4531 hierarchy for generic instances; fixes #75261.
4533 2005-06-17 Martin Baulig <martin@ximian.com>
4535 * typemanager.cs (TypeManager.IsBuiltinType): Use TypeToCoreType()
4536 to make things work for corlib.
4538 2005-06-15 Martin Baulig <martin@ximian.com>
4540 * attribute.cs (Attribute.CheckSecurityActionValidity): Remove the
4541 obsolete `SecurityAction' values.
4543 2005-06-06 Marek Safar <marek.safar@seznam.cz>
4545 * rootcontext.cs: Reset TargetExt as well.
4547 2005-06-09 Martin Baulig <martin@ximian.com>
4549 * delegate.cs (Delegate.VerifyMethod): Added
4550 `MethodGroupExpr old_mg' argument; inherit its
4551 `HasTypeParameters'; fix #75085.
4553 2005-06-09 Martin Baulig <martin@ximian.com>
4555 * expression.cs (Invocation.OverloadResolve): Correctly handle
4556 generic methods for the SetMemberIsUsed(); fix #75064.
4558 2005-06-09 Martin Baulig <martin@ximian.com>
4560 * statement.cs (Throw.Resolve): Use TypeManager.IsSubclassOf();
4563 2005-06-08 Martin Baulig <martin@ximian.com>
4565 * cs-parser.jay (nullable_type_or_conditional): If we put the
4566 nullable back and our `type' is a `ComposedCast', remove the
4567 nullable from it. Fixes #75156.
4569 * expression.cs (ComposedCast.RemoveNullable): New public method.
4571 2005-06-08 Martin Baulig <martin@ximian.com>
4573 The big Iterators rewrite :-)
4575 * iterators.cs: Rewrite this to use the anonymous methods framework.
4577 * rootcontext.cs (RootContext.DefineTypes): Define Delegates
4578 before the TypeContainers; see 2test-21.cs.
4581 (TypeContainer.DefineType): Don't create a new EmitContext if we
4582 already have one (this only happens if we're an Iterator).
4583 (TypeContainer.Define): Also call Define() on all our iterators.
4584 (Method.CreateEmitContext): Added support for iterators.
4587 (AnonymousContainer): New abstract base class for `AnonymousMethod'.
4588 (AnonymousContainer.CreateMethodHost): Moved here from
4589 AnonymousMethod and made abstract.
4590 (AnonymousContainer.CreateScopeType): New abstract method.
4591 (AnonymousContainer.IsIterator): New public property.
4592 (ScopeInfo.EmitScopeType): Call CreateScopeType() on our Host to
4593 get the ScopeTypeBuilder rather than manually defining it here.
4594 (ScopeInfo.EmitScopeInstance): New public method; correctly handle
4597 * driver.cs (Driver.MainDriver): Call TypeManager.InitCodeHelpers()
4598 before RootContext.DefineTypes().
4600 * codegen.cs (EmitContext.RemapToProxy): Removed.
4601 (EmitContext.CurrentAnonymousMethod): Changed type from
4602 AnonymousMethod -> AnonymousContainer.
4603 (EmitContext.ResolveTopBlock): Protect from being called twice.
4604 (EmitContext.MapVariable, RemapParameter(LValue)): Removed.
4605 (EmitContext.EmitThis): Removed the iterators hacks; use the
4606 anonymous methods framework for that.
4609 (ToplevelBlock.Container): Make this a property, not a field.
4610 (ToplevelBlock.ReParent): New public method; move the
4611 ToplevelBlock into a new container.
4612 (Foreach.TemporaryVariable): Simplify.
4614 2005-06-05 Martin Baulig <martin@ximian.com>
4616 * statement.cs (LocalInfo.CompilerGenerated): New flag.
4617 (Block.AddTemporaryVariable): New public method; creates a new
4618 `LocalInfo' for a temporary variable.
4619 (Block.EmitMeta): Create the LocalBuilders for all the temporary
4621 (Foreach.TemporaryVariable): Use Block.AddTemporaryVariable() for
4622 non-iterator variables.
4624 2005-06-05 Martin Baulig <martin@ximian.com>
4626 * statement.cs (Foreach.TemporaryVariable): Create the
4627 LocalBuilder in the Emit phase and not in Resolve since in some
4628 situations, we don't have an ILGenerator during Resolve; see
4629 2test-19.cs for an example.
4631 2005-06-04 Martin Baulig <martin@ximian.com>
4633 The big Foreach rewrite - Part II.
4635 * typemanager.cs (TypeManager.object_getcurrent_void): Replaced
4636 with `PropertyInfo ienumerator_getcurrent'.
4638 * codegen.cs (VariableStorage): Removed.
4641 (Foreach): Derive from Statement, not ExceptionStatement.
4642 (Foreach.CollectionForeach): New nested class. Moved all the code
4643 dealing with collection foreach here.
4644 (Foreach.ForeachHelperMethods): Removed.
4645 (Foreach.TemporaryVariable): Implement IMemoryLocation.
4647 2005-05-23 Martin Baulig <martin@ximian.com>
4649 * statement.cs (Try.DoResolve): Don't create a `finally' if we
4650 don't need to. Fix #75014.
4652 2005-05-26 Raja R Harinath <rharinath@novell.com>
4654 Improve user-defined conversion handling.
4655 * convert.cs (GetConversionOperators): Rewrite. Return only the
4656 applicable operators.
4657 (AddConversionOperators): New. Helper for GetConversionOperators.
4658 (FindMostEncompassedType, FindMostEncompassingType): Verify that
4659 there is only one most encompassed/encompassing type.
4660 (FindMostSpecificSource, FindMostSpecificTarget): Remove
4661 "applicable operator" handling.
4662 (UserConversion): Move cache here from GetConversionOperators.
4663 Directly cache the chosen operator, rather than the whole
4665 (ExplicitNumericConversion): Fix buggy implementation of Decimal
4666 case. Allow conversion of decimal to sbyte and byte too.
4667 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
4668 New static methods. Used to avoid allocating EmptyExpressions in
4671 2005-05-24 Duncan Mak <duncan@novell.com>
4673 * ecore.cs (CastFromDecimal): New class for casting a decimal to
4674 another class, used in Convert.ExplicitNumericConversion.
4675 (CastToDecimal): New class, similar to above, but casts to
4676 System.Decimal, used in Convert.ImplicitNumericConversion and also
4677 in explicit convesion from double/float to decimal.
4679 * convert.cs (ImplicitNumericConversion): Handle implicit
4680 conversions to System.Decimal.
4681 (ExplicitNumericConversion): handle explicit conversions to
4686 2005-05-20 Miguel de Icaza <miguel@novell.com>
4688 * typemanager.cs: Do not throw an exception in the TypeBuilder
4689 case, we take care of it on the TypeCode.
4691 2005-05-17 Marek Safar <marek.safar@seznam.cz>
4693 * attribute.cs (Attribute.ResolveArguments): GuidAttribute check
4696 * cs-parser.jay: Catch more lexical errors.
4698 * report.cs: Add one more Error method.
4701 * typemanager.cs: Register System.Runtime.InteropServices.GuidAttribute
4703 2005-05-20 Martin Baulig <martin@ximian.com>
4705 * class.cs (TypeContainer.CircularDepException): Removed.
4706 (TypeContainer.DefineType): Removed the `InTransit' stuff.
4707 (TypeContainer.CheckRecursiveDefinition): Check for circular class
4708 (CS0146) and interface (CS0529) dependencies here.
4710 2005-05-20 Martin Baulig <martin@ximian.com>
4712 * expression.cs (New.DoResolve): Move the CS0712 check above the
4713 CS0144 check; otherwise it can never be reached.
4715 2005-05-20 Martin Baulig <martin@ximian.com>
4717 * cs-parser.jay: Fix CS0080 check; add CS0231 and CS0257 from MCS.
4719 2005-05-20 Martin Baulig <martin@ximian.com>
4721 * class.cs (TypeContainer.DefineType): Fix CS0698 check.
4723 * typemanager.cs (TypeManager.IsAttributeType): New public method.
4725 2005-05-19 Martin Baulig <martin@ximian.com>
4728 (ImplicitDelegateCreation.Check): Added `bool check_only' argument
4729 to disable error reporting.
4731 * convert.cs (Convert.ImplicitStandardConversionExists): Use it
4732 here since we don't want to report an error; see the new test-336.cs.
4734 2005-05-19 Raja R Harinath <rharinath@novell.com>
4736 * statement.cs (ToplevelBlock.GetParameterReference)
4737 (ToplevelBlock.IsParameterReference,ToplevelBlock.IsLocalParameter):
4738 Move here from class Block.
4739 * ecore.cs (SimpleName.SimpleNameResolve): Update to changes.
4740 * expression.cs (ParameterReference.DoResolveBase): Likewise.
4742 2005-05-18 Martin Baulig <martin@ximian.com>
4747 (FlowBranching.Reachability): Add non-static public And() and Or()
4749 (FlowBranchingSwitch): New class; do the `break_origins' thing
4750 like in FlowBranchingLoop.
4751 (FlowBranching.UsageVector.MergeBreakOrigins): Also merge the
4752 reachability, not just locals and parameters.
4753 (FlowBranching.MergeChild): Remove some of the hacks for loop and
4754 switch; MergeBreakOrigins() now takes care of that.
4756 2005-05-18 Martin Baulig <martin@ximian.com>
4758 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
4759 a loop and may leave it, reset the barrier; fixes #74974.
4761 2005-05-16 Raja R Harinath <rharinath@novell.com>
4763 Fix test-382.cs. Emit values of decimal constants.
4764 * class.cs (TypeContainer.RegisterFieldForInitialization): New.
4766 (TypeContainer.AddField): ... this.
4767 (TypeContainer.EmitFieldInitializers): Allow the list of fields
4768 with initializers to include 'Const's.
4769 (ClassPart.RegisterFieldForInitialization): Forward to
4771 * const.cs (Const.Const): Pass initializer to base class.
4772 (Const.Define): In case of decimal constants, register them for
4773 initialization in a static constructor.
4775 2005-05-14 Martin Baulig <martin@ximian.com>
4777 * statement.cs (Block.Resolve): Correctly handle unreachable code;
4778 do not call ResolveUnreachable() on unreachable statements in
4779 here, see the comment in the source code.
4781 2005-05-13 Raja R Harinath <rharinath@novell.com>
4784 * expression.cs (BinaryResolveOperator): If one of the operands of
4785 an equality comparison is 'null' and the other is a pointer type,
4786 convert the null to a NullPointer.
4787 * convert.cs (ImplicitReferenceConversion): If the expression is a
4788 NullLiteral and the target type is a pointer type, return a
4789 NullPointer instead.
4790 (ImplicitConversionStandard): Likewise.
4792 2005-05-13 Marek Safar <marek.safar@seznam.cz>
4794 * cs-parser.jay: Set readonly context based on special constructs.
4796 * expression.cs (LocalVariableReference.DoResolveBase): Improved
4797 readonly variable error handling.
4799 * rootcontext.cs (EmitCode): Don't verify members when error
4802 * statement.cs (LocalInfo): Add reaodnly context information.
4803 (SetReadOnlyContext, GetReadOnlyContext): New methods.
4805 2005-05-17 Martin Baulig <martin@ximian.com>
4807 * expression.cs (Argument.Resolve): Turn on flow analysis; fix
4810 2005-05-13 Martin Baulig <martin@ximian.com>
4812 * statement.cs (Block.Resolve, ResolveUnreachable): Correctly
4813 handle unreachable blocks.
4815 2005-05-13 Martin Baulig <martin@ximian.com>
4818 (ConstructorInitializer.GetOverloadedConstructor): Don't crash.
4819 (MethodCore.CheckCore): Use TypeManager.IsEqual(); fix #74904 and
4822 2005-05-13 Martin Baulig <martin@ximian.com>
4824 * statement.cs (Block.Resolve): Make the `bool unresolved' flag an
4825 instance variable, not a local. Fix #74873.
4826 (Block.ResolveUnreachable): Set it to true here.
4828 2005-05-12 Martin Baulig <martin@ximian.com>
4830 * cs-parser.jay (property_declaration): Pass the `current_class',
4831 not the `current_container' to Property's .ctor. Fixes #74912.
4833 2005-05-11 Martin Baulig <martin@ximian.com>
4835 * typemanager.cs (Closure): Copy this from MCS and merge all the
4836 GMCS-specific changes into it.
4838 2005-05-12 Raja R Harinath <harinath@gmail.com>
4841 * typemanager.cs (unmanaged_enclosing_types): New.
4842 (IsUnmanagedType): Avoid infloops by using
4843 'unmanaged_enclosing_types' to talk with recursive invocations.
4845 2005-05-11 Duncan Mak <duncan@novell.com>
4847 * cs-tokenizer.cs (get_cmd_arg): Check that 'c' is not -1 before
4848 continuing to process for 'arg'.
4849 (handle_preprocessing_directive): Check the argument of the #endif
4850 directive and report error CS1025 if there are any trailing
4853 According to the C# spec, having even whitespace after the #endif
4854 directive is illegal; however, because we call arg.TrimEnd ()
4855 beforehand, we have the same behavior as csc, allowing whitespace
4856 after the directive.
4860 2005-05-11 Marek Safar <marek.safar@seznam.cz>
4864 * class.cs (ConstructorInitializer.GetOverloadedConstructor): Removed.
4865 (Constructor.GetObsoleteAttribute): Implemented correctly.
4867 2005-05-10 Martin Baulig <martin@ximian.com>
4869 * generic.cs (Constraints.Resolve): Report CS0246 if we cannot
4870 resolve the type; fixes #74864.
4871 (DefaultValueExpression): Create the LocalTemporary in Emit(), not
4872 in DoResolve(); fixes #74862.
4874 2005-05-10 Martin Baulig <martin@ximian.com>
4876 * support.cs (ReflectionParameters.ParameterModifier): Use
4877 `Parameter.Modifier.REF' if we both have `ParameterAttributes.Out'
4878 and `ParameterAttributes.In'. Fixes #74884.
4880 2005-05-10 Martin Baulig <martin@ximian.com>
4882 * typemanager.cs (TypeManager.MemberLookup_FindMembers): Don't use
4883 the cache if we're just looking for `MemberTypes.NestedType' in a
4886 * ecore.cs (Expression.ResolveAsTypeTerminal): Don't check the
4887 constraints if we're still resolving the type tree.
4888 (Expression.MemberLookup): If we're resolving the type tree, only
4889 look for `MemberTypes.NestedType' since we're only interested in
4892 * class.cs (TypeContainer.DefineType): Don't resolve the type
4893 parameters here; do this later in ResolveType() after the type
4894 tree has been resolved.
4895 (TypeContainer.ResolveType): New public method; this is called
4896 after the type tree is resolved and before the types are being
4897 populated. We resolve the generic constraints here.
4898 (TypeContainer.DoDefineMember): Check the constraints on our base
4899 class and interfaces.
4901 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Make this protected;
4902 set the `ResolvingTypeTree' flag on the EmitContext.
4904 * codegen.cs (EmitContext.ResolvingTypeTree): New public field.
4906 2005-05-10 Marek Safar <marek.safar@seznam.cz>
4908 * class.cs (Method.Define): Catch attempt for Finalizer declaration.
4910 * expression.cs (Argument.GetParameterModifier): Turned to property.
4911 (Invocation.Error_InvalidArguments): Add more descriptive errors.
4913 * parameter.cs (Parameter.GetModifierSignature): Translates modifier to
4916 2005-05-09 Raja R Harinath <rharinath@novell.com>
4919 * decl.cs (MemberCache.AddMethods): Register override methods,
4920 rather than non-override methods.
4921 * typemanager.cs (RegisterOverride): New.
4922 (IsOverride): Update.
4924 2005-05-09 Marek Safar <marek.safar@seznam.cz>
4926 * typemanager.cs (TypeManager): Moved InitGenerics to Reset method.
4928 2005-05-06 Martin Baulig <martin@ximian.com>
4931 (Attributable.IsClsComplianceRequired): Fix typo in the method name.
4932 (AttributeTester.AnalyzeTypeCompliance): Add generics support.
4934 2005-05-09 Marek Safar <marek.safar@seznam.cz>
4938 * ecore.cs (SimpleName.SimpleNameResolve): Add in_transit to catch
4939 recursive declaration.
4941 * statement.cs (Block.ResolveMeta): Report any error in resolving.
4943 2005-05-06 Marek Safar <marek.safar@seznam.cz>
4945 * cfold (DoConstantNumericPromotions): Don't try to convert 0 enum.
4947 * expression.cs (Binary.DoResolve): (x && 0) is always 0.
4949 2005-05-05 Raja R Harinath <rharinath@novell.com>
4952 * decl.cs (DeclSpace.FamilyAccessible):
4953 Use TypeManager.IsNestedFamilyAccessible.
4955 Fix reopened #64812.
4956 * typemanager.cs (Closure.Filter): Introduce checks for 'protected
4959 2005-05-04 Raja R Harinath <rharinath@novell.com>
4960 Abin Thomas <projectmonokochi@rediffmail.com>
4961 Anoob V E <projectmonokochi@rediffmail.com>
4962 Harilal P R <projectmonokochi@rediffmail.com>
4965 * typemanager.cs (Closure.CheckValidFamilyAccess): Don't blindly
4966 allow access to all static members.
4968 2005-05-04 Martin Baulig <martin@ximian.com>
4970 * ecore.cs (FieldExpr.DoResolveLValue): Always call fb.SetAssigned().
4972 2005-05-04 Martin Baulig <martin@ximian.com>
4976 * statement.cs (Switch.SimpleSwitchEmit): Always emit the default
4977 section at the end; make things work if `default' is not the last
4980 2005-05-04 Martin Baulig <martin@ximian.com>
4984 * statement.cs (Switch): Replaced the `got_default' field with a
4985 `default_section' one.
4986 (Switch.CheckSwitch): Set `default_section' here.
4987 (Switch.Resolve): If we're a constant switch and the constant is
4988 not found, use the default section.
4990 2005-05-03 Martin Baulig <martin@ximian.com>
4992 * expression.cs (ArrayAccess.EmitGetLength): New public method.
4994 * statement.cs (Foreach.ArrayForeach): New nested class.
4995 (Foreach.TemporaryVariable): New nested class.
4996 (Foreach.EmitArrayForeach): Removed; this is now in the new
4999 2005-05-03 Raja R Harinath <rharinath@novell.com>
5001 * pending.cs (BaseImplements): Move the #74773 fix here. This is
5003 (VerifyPendingMethods): Revert change below.
5005 * typemanager.cs (IsOverride, RegisterNonOverride): New.
5006 * decl.cs (MemberCache.AddMethod): Register "non-override" methods
5007 that used to trigger warning -28. Remove warning -28.
5008 * expression.cs (Invocation.OverloadResolve): Use
5009 TypeManager.IsOverride to distinguish override methods.
5012 * pending.cs (VerifyPendingMethods): If a base type implements the
5013 requested interface, don't bother checking individual methods of
5014 the base type. As a side-effect, this prevents the creation of
5015 unnecessary proxies.
5017 2005-05-02 Martin Baulig <martin@ximian.com>
5021 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
5022 Also `And' the locals if the old vector is null.
5023 (FlowBranching.UsageVector.BitVector.And): Allow `vector' being
5024 null; in this case we basically reset all the variables.
5026 2005-05-02 Martin Baulig <martin@ximian.com>
5030 * flowanalysis.cs (FlowBranching.UsageVector.MergeBreakOrigins):
5031 Added `FlowBranching branching' argument; always `and' the
5032 variables instead of `or'ing them unless we're an infinite loop.
5034 * statement.cs (While.Resolve): Create a new sibling unless we're
5037 2005-05-02 Martin Baulig <martin@ximian.com>
5041 * class.cs (ConstructorInitializer.Resolve): Added `Block block'
5042 arguments; use it instead of creating a new TopLevelBlock.
5043 (Constructor.Emit): Call `block.ResolveMeta ()' before resolving
5044 our ConstructorInitializer.
5047 (TopLevelBlock.TopLevelBranching): New public property.
5048 (TopLevelBlock.ResolveMeta): New public method; call ResolveMeta()
5049 and create our `TopLevelBranching'.
5051 * codegen.cs (EmitContext.ResolveTopBlock): If we're not an
5052 anonymous method host, use `block.TopLevelBranching' rather than
5053 creating a new branching.
5055 2005-04-20 Miguel de Icaza <miguel@novell.com>
5057 * anonymous.cs (ScopeInfo.AddChild): when adding a new child to
5058 a ScopeInfo, if any of the current children is a child of the new
5059 entry, move those children there.
5061 2005-04-30 Martin Baulig <martin@ximian.com>
5063 * statement.cs (Switch.SimpleSwitchEmit): Reset `default_at_end'
5064 at the beginning of a SwitchSection. Fix #73335.
5066 2005-04-27 Marek Safar <marek.safar@seznam.cz>
5069 * class.cs (EmitFieldInitializers): Use FieldExpr in initializer.
5071 * ecore.cs (FieldExpr): Add a new ctor with in_initializer.
5072 (FieldExpr.DoResolve): Obsolete members are ignored for field
5075 2005-04-26 Marek Safar <marek.safar@seznam.cz>
5077 * attribute.cs (AreOverloadedMethodParamsClsCompliant): Add array
5078 of arrays detection.
5080 * class.cs (Interface.VerifyClsCompliance): Add base interfaces
5082 (Field.VerifyClsCompliance): Volatile fields are not compliant.
5084 * decl.cs (MemberCache.VerifyClsParameterConflict): Add array of
5087 2005-04-25 Ben Maurer <bmaurer@ximian.com>
5089 * cs-parser.jay: Use the prefered version of -unsafe in error
5092 2005-04-22 Marek Safar <marek.safar@seznam.cz>
5094 * driver.cs (CompilerCallableEntryPoint.Invoke): Reset under any
5097 2005-04-20 John Luke <john.luke@gmail.com>
5099 * driver.cs: fix typo in error message, --outout to --output
5101 2005-04-30 Martin Baulig <martin@ximian.com>
5103 * attribute.cs (Attribute.CheckSecurityActionValidity): Correctly
5104 handle the .NET 2.x security attributes.
5106 2005-04-30 Martin Baulig <martin@ximian.com>
5109 (TypeManager.ExpandInterfaces): Don't add things twice.
5112 (TypeContainer.VerifyClsCompliance): Allow generic instances.
5114 2005-04-29 Martin Baulig <martin@ximian.com>
5116 * generic.cs (Constraints.ResolveTypes): Expand interfaces.
5118 * anonymous.cs: Added support for anonymous generic methods.
5120 2005-04-29 Martin Baulig <martin@ximian.com>
5122 * typemanager.cs (TypeManager.GetInterfaces): Correctly handle
5125 2005-04-29 Martin Baulig <martin@ximian.com>
5127 * generic.cs (TypeManager.HasConstructorConstraint): Removed.
5129 * expression.cs (New.DoResolve): Fix the CS0304 check.
5131 2005-04-29 Martin Baulig <martin@ximian.com>
5133 * typemanager.cs (TypeManager.GetFullName): Updated to the new
5136 * class.cs (MethodCore.IsDuplicateImplementation): If we're an
5137 explicit interface implementation, compare the interface types.
5138 (MethodData.Define): Use the new naming scheme from the latest
5140 (MemberBase.DoDefineBase): Resolve `InterfaceType' here.
5142 * decl.cs (MemberName.GetMemberName): Removed.
5143 (MemberName.MethodName, FullName): New properties.
5145 2005-04-25 Raja R Harinath <rharinath@novell.com>
5147 * gmcs.exe.config: Update v2.0.40607 -> v2.0.50215.
5149 2005-04-22 Martin Baulig <martin@ximian.com>
5151 * generic.cs (GenericMethod): Create the EmitContext in the
5152 `Define()'; in `Define(MethodBuilder)', create the type parameters
5153 before calling `Define()'. Fixes #73933.
5155 2005-04-22 Martin Baulig <martin@ximian.com>
5158 (Constraints.Resolve): Make things work wrt. the new type lookup system.
5159 (ConstructedType.ResolveAsTypeTerminal): Don't override this.
5161 * ecore.cs (Expression.ResolveAsTypeTerminal): If `te' is a
5162 ConstructedType, check its constraints.
5164 2005-04-20 Marek Safar <marek.safar@seznam.cz>
5166 * codegen.cs (InRefOutArgumentResolving): New field.
5168 * ecore.cs (FieldExpr.DoResolve): Check for assigning to readonly
5169 fields outside contructor.
5171 * expression.cs (Argument.Resolve): Set InRefOutArgumentResolving.
5173 2005-04-19 Miguel de Icaza <miguel@novell.com>
5175 * anonymous.cs (CaptureContext.EmitParameterInstance): The
5176 parameter code was not completed ever, so it was not as up-to-date
5177 as local variables. Must finish it.
5179 The bug fix was to compare the Toplevel of the block, not the
5180 current block. Thanks for Ben for pointing this out.
5182 2005-04-19 Raja R Harinath <rharinath@novell.com>
5184 * decl.cs (AddMethods): Use the declaring type of the problem
5185 method to determine if we want to squash a warning.
5187 2005-04-19 Marek Safar <marek.safar@seznam.cz>
5189 * attribute.cs: Removed debug output.
5191 * decl.cs (MemberCache.AddMethods): Fixed Finalize ignoring.
5193 * driver.cs (Driver.parse): Synchronize parser ErrorOutput with
5196 2005-04-18 Raja R Harinath <rharinath@novell.com>
5199 * expression.cs (Binary.EqualsNullIsReferenceEquals): New.
5200 (Binary.DoResolveOperator): Use it to avoid blindly optimizing out
5201 all null comparisons against reference types.
5203 2005-04-18 Marek Safar <marek.safar@seznam.cz>
5206 * class.cs (TypeContainer.CircularDepException) New nested
5208 (GetPartialBases, GetNormalBases, GetClassBases): Removed error.
5209 (TypeContainer.DefineType): Removed error, reset InTransit before
5211 (Class.DefineType): Throw exception when is in Transit.
5212 Catch exception and report error.
5213 (Struct.DefineType): Throw exception when is in Transit.
5214 Catch exception and report error.
5215 (Interface.DefineType): Throw exception when is in Transit.
5216 Catch exception and report error.
5218 * codegen.cs: Add InCatch,InFinally to EmitContext to easily
5219 handle nested exception handlers.
5221 * flowanalysis.cs (InTryWithCatch): New method, search for try with
5224 * iterators.cs (Yield.CheckContext): Add CS1626 report. Updated
5225 InFinally and InCatch storage.
5227 * statement.cs (Throw.Resolve): Use InCatch, InFinally from ec.
5228 (Catch.Resolve): Set and Restore ec.InCatch.
5229 (Try.Resolve): Set and Restore ec.InFinally.
5230 (Try.HasCatch): True when try has catch.
5232 2005-04-17 Atsushi Enomoto <atsushi@ximian.com>
5234 * doc.cs : In some cases FilterName returns MonoEvent and MonoField
5235 for the same event member, so exclude such cases from warning 419.
5238 2005-04-16 Miguel de Icaza <miguel@novell.com>
5240 * expression.cs (Binary.ResolveOperator): Apply patch from John
5241 Luke to fix bug 59864: operators &, | and ^ on enumerations
5242 require that the same enum type on both sides.
5244 * driver.cs: Add warnings to old flag usage, this is to assist
5245 people who produce Makefiles and hope that the Makefiles will be
5248 * class.cs (TypeContainer.EmitType): Moved the definition of the
5249 special $PRIVATE$ field from the resolve phase to the Emit phase.
5250 During resolve we do not know if we are a struct with
5251 HasExplicitLayout, we know this only after the attributes for the
5254 Set the FieldOffset to zero on the dummy field that we create for
5255 the class. Fixes 74590.
5257 2005-04-16 Raja R Harinath <rharinath@novell.com>
5260 * ecore.cs (PropertyExpr.resolved): New.
5261 (DoResolve): Use it to handle a case of double resolution here.
5262 Handle a case of identical-name-and-type-name.
5263 * expression.cs (ArrayCreation.CheckIndices): Avoid double
5264 resolution by storing the results of expression resolution back
5265 into the "probes" array.
5267 2005-04-15 Raja R Harinath <rharinath@novell.com>
5269 Fix cs0208-7.cs and cs0208-8.cs.
5270 * typemanager.cs (IsUnmanagedType): Arrays are not allowed
5271 (cf. ECMA standard, behaviour of CSC 1.1 and CSC 2.0). Improve
5272 error reporting to point out the reason a struct is not unmanaged.
5274 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
5276 * doc.cs : In FindDocumentedType(), avoid TypeExpr.ResolveType() and
5277 just use TypeExpr.Type. This fixes bug #74595 when merged to gmcs.
5279 2005-04-13 Raja R Harinath <rharinath@novell.com>
5282 * ecore.cs (PropertyExpr.InstanceResolve): Handle a case of
5283 IdenticalNameAndTypeName here.
5284 (EventExpr.InstanceResolve): Likewise.
5286 2005-04-13 Marek Safar <marek.safar@seznam.cz>
5288 C# 2.0 DefaultCharSetAttribute implementation
5290 * attribute.cs (Attribute.ResolveAsTypeStep): New protected method
5291 which allows us to set GlobalNamespace for every resolve.
5292 (Attribute.ResolveArguments): Cut from Resolve.
5293 (Attribute.GetCharSetValue): Returns CharSet named argument.
5294 (Attribute.DefinePInvokeMethod): Gets default charset from
5296 (GlobalAttribute.ResolveAsTypeStep): Override.
5297 (GlobalAttribute.ResolveArguments): Override.
5299 * class.cs (TypeAttr): Is protected.
5301 * codegen.cs (ModuleClass.DefaultCharSet): New member.
5302 (ModuleClass.DefaultCharSetType): New memeber.
5303 (ModuleClass.ResolveAttributes): Resolves DefaultCharSetAttribute.
5305 * decl.cs (Decl.TypeAttr): New protected virtual. Returns default
5306 charset from module.
5308 * delegate.cs (TypeAttr): Override.
5309 (Delegate.DefineType): Use this TypeAttr.
5311 * driver.cs (Driver.MainDriver): Call Module.ResolveAttributes
5312 at very early stage (before types are defined) to resolve model
5313 module attributes. It will probably not work with corlib but it
5316 * enum.cs (Enum.TypeAttr): New protected virtual. Returns default
5317 charset from module.
5319 * typemanager.cs (default_charset_type): New type.
5321 2005-04-13 Raja R Harinath <rharinath@novell.com>
5323 * decl.cs (MemberCache.AddMethods): Don't warn if
5324 System.Object.Finalize has buggy MethodAttributes.
5326 * typemanager.cs (IsUnmanagedType): Restore !IsValueType check
5329 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
5331 * doc.cs : detect ambiguous reference to overloaded members.
5332 Fixed bug #71603. MS 1.1 csc does not detect it.
5334 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
5336 * doc.cs : delegates must not be referenced with parameters.
5339 2005-04-12 Miguel de Icaza <miguel@novell.com>
5341 * typemanager.cs (IsUnmanagedType): Arrays are allowed.
5343 2005-04-10 Miguel de Icaza <miguel@novell.com>
5345 * driver.cs (MainDriver): Stop processing if the CLS stage found
5348 (CompilerCallableEntryPoint.InvokeCompiler): Always
5349 reset after execution; Take a TextWriter argument for the
5352 * report.cs: Use the error stream instead of hardcoding stderr.
5354 2005-04-09 Miguel de Icaza <miguel@novell.com>
5356 * class.cs: Reduce code paths to test, too small of an
5357 optimization to make it worth the extra testing. Always perform
5360 2005-04-08 Raja R Harinath <rharinath@novell.com>
5363 * class.cs (OperatorArrayList.CheckPairedOperators): Skip
5364 operators that had errors reported on them.
5366 2005-04-08 Marek Safar <marek.safar@seznam.cz>
5368 * attribute.cs (Attribute.IsValidArgumentType): Test valid named
5370 (Attribute.Resolve): Add named argument type checking.
5372 * class.cs (FixedField.Define): Use IsPrimitiveType
5374 * expression.cs (Binary.ResolveOperator): Reflect IsCLRType renaming.
5376 * iterators.cs (Iterator.DefineIterator): Add check for arglist and
5377 unsafe parameter types.
5379 * statement.cs (Using.ResolveExpression): Add better error description.
5381 * typemanager.cs (IsCLRType): Renamed to IsPrimitiveType.
5383 2005-04-08 Raja R Harinath <rharinath@novell.com>
5386 * attribute.cs (Attribute.GetAttributeUsage): Resolve
5387 AttributeUsageAttribute in the emitcontext of the attribute class,
5388 not in the emitcontext of the attributable entity it was attached to.
5389 * cs-parser.jay: Use 'current_class', not 'current_container',
5390 when creating a GlobalAttribute.
5392 2005-04-08 Alp Toker <alp@atoker.com>
5394 * pending.cs: The fix to #58413 failed to compile methods implementing
5395 interfaces with/without params modifiers and vice versa, even though
5396 params modifiers aren't part of the signature. Make the modifier check
5397 less strict as in csc.
5399 2005-04-07 Abin Thomas <projectmonokochi@rediffmail.com>
5400 Anoob V E <projectmonokochi@rediffmail.com>
5401 Harilal P R <projectmonokochi@rediffmail.com>
5404 * pending.cs (TypeAndMethods.mods): New. Store the parameter
5405 modifiers of pending methods.
5406 (PendingImplementation.PendingImplementation): Initialize it.
5407 Add Parameter.Modifier [][] mods and initialize it with ParameterData.
5408 (PendingImplementation.InterFaceMethod): Repalce Type[] argument
5409 with ParameterData. Add check for modifiers.
5410 * class.cs (MethodData.Define): Update to changes.
5412 2005-04-07 Raja R Harinath <rharinath@novell.com>
5414 * ecore.cs (Expression.IsAccessorAccessible): Clarify code somewhat.
5416 2005-04-07 Marek Safar <marek.safar@seznam.cz>
5418 * class.cs (PropertyMethod.Define): Check private accessor in abstract
5421 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't allow RequiredAttribute
5424 * typemanager.cs: Registered RequiredAttributeAttribute.
5426 2005-04-06 Marek Safar <marek.safar@seznam.cz>
5428 * class.cs (VerifyMembers): Doesn't need EmitContext argument.
5429 Warning CS0169 is back at level 3.
5430 (IMethodData.SetMemberIsUsed): New method.
5432 * decl.cs (IsUsed): New value; moved from FieldBase.Status
5433 (SetMemberIsUsed, IsUsed): New methods, encapsulate IsUsed.
5435 * delegate.cs (ResolveMethodGroupExpr): Call SetMemberIsUsed.
5437 * ecore.cs (FieldExpr.ResolveMemberAccess): Call SetMemberIsUsed for
5439 (PropertyExpr.ResolveAccessors): Call SetMemberIsUsed when delegate
5442 * expression.cs (OverloadResolve): Call SetMemberIsUsed. when method
5445 * rootcontext.cs (RootContext.EmitCode): Call VerifyMembers in extra run
5446 to avoid the problems with nested types.
5448 2005-04-05 Abin Thomas <projectmonokochi@rediffmail.com>
5449 Anoob V.E <projectmonokochi@rediffmail.com>
5450 Harilal P.R <projectmonokochi@rediffmail.com>
5451 Raja R Harinath <rharinath@novell.com>
5454 * delegate.cs (Define): Emit ParamArrayAttribute for 'params'
5456 * typemanager (GetConstructor): Make public.
5458 2005-04-05 John Luke <john.luke@gmail.com>
5459 Raja R Harinath <rharinath@novell.com>
5462 * typemanager.cs (IsUnmanagedType): Check non-public fields of a
5463 struct too. Return false quicker in a few cases.
5464 (VerifyUnManaged): Use it.
5466 2005-04-05 Raja R Harinath <rharinath@novell.com>
5469 * statement.cs (Block.Resolve): Initialize 'unreachable' to false,
5470 not 'unreachable_seen'.
5472 2005-04-04 Marek Safar <marek.safar@seznam.cz>
5474 * attribute.cs (Attribute.GetValue): Removed unused.
5476 * codegen.cs (CodeGen.TrimExt): Removed unused.
5478 * cs-parser.jay (output): Removed unused.
5480 * cs-tokenizer.cs (hex_digits): Removed unused.
5482 * enum.cs (MapToInternalType, GetEnumeratorName): Removed unused.
5484 * expression.cs (Indirection.LoadExprValue): Removed unused.
5485 (ArrayCreation.ExpressionToArrayArgument): Removed unused.
5487 * iterators.cs (Iterator.param_types): Removed unused.
5489 * statement.cs (Goto.block): Removed unused.
5490 (ToplevelBlock.did): Removed unused.
5491 (Switch.ResolveConstantSwitch): Removed unused.
5493 2005-04-01 Ben Maurer <bmaurer@ximian.com>
5495 * rootcontext.cs: Allow mcs to bootstrap with the compilation
5498 2005-04-19 Martin Baulig <martin@ximian.com>
5500 Merged r42462 from MCS and made it work for GMCS.
5502 * class.cs (MethodCore.ds): Moved this field to `MemberBase'.
5504 * generic.cs (GenericMethod.Define): Removed `return_type' argument.
5506 2005-04-01 Raja R Harinath <rharinath@novell.com>
5508 Fix #74232 and cs0208-3.cs.
5509 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0208 check.
5510 * typemanager.cs (IsUnmanagedType): Don't allow 'object' as an
5511 unmanaged type. Don't use FieldBuilders when 't' is a
5512 TypeBuilder. Use ModFlags and MemberType fields.
5513 * class.cs (MemberBase.member_type): Rename from MemberType.
5514 (MemberBase.MemberType): New property. Determines member_type on
5516 (MemberBase.DoDefine): Don't initialize MemberType here.
5517 (FieldMember.Define): Likewise.
5519 2005-04-01 Marek Safar <marek.safar@seznam.cz>
5522 * class.cs (Event.Emit): Call Add/Remove emit even for interfaces.
5523 Attributes are emitted there.
5525 2005-04-01 Raja R Harinath <rharinath@novell.com>
5527 * cs-tokenizer.cs (consume_identifier): Treat 'partial' as a
5528 keyword in 'partial enum' too.
5529 * cs-parser.jay (enum_declaration): Add CS0267 check ('partial enum'
5531 Report from Kamil Skalski <nazgul@omega.pl>.
5534 * rootcontext.cs (ResolveTree): The 'root.Interfaces' list can
5535 have partial containers too.
5537 * ecore.cs (SimpleName.SimpleNameResolve): Move 'invariant meaning
5538 in block' checks to Block.CheckInvariantMeaningInBlock.
5539 * statement.cs (Block.GetKnownVariableInfo): Make private.
5540 (Block.IsVariableUsedInChildBlock): Remove.
5541 (Block.IsVariableUsedInBlock): Likewise.
5542 (Block.CheckInvariantMeaningInBlock): New. Show location of
5543 conflicting declaration.
5544 (Block.AddVariable): Make error messages less long-winded and more
5545 specific. Show location of conflicting declaration.
5546 * parameter.cs (Parameters.Location): New readonly property.
5548 2005-03-31 Raja R Harinath <rharinath@novell.com>
5550 Clean up semantics of invoking ResolveMemberAccess.
5551 * ecore.cs (SimpleName.DoSimpleNameResolve): If a MemberExpression
5552 can have an instance, ensure that we pass in a non-TypeExpression
5553 to ResolveMemberAccess. Tighten up IdenticalNameAndTypeName checks.
5554 (MemberExpr.DoSimpleNameResolve): Remove type_is_inferred
5555 argument. Update to changes and simplify.
5556 (FieldExpr.Emitinstance): Remove CS0120 check.
5557 (PropertyExpr.EmitInstance): Likewise.
5558 * expression.cs (Argument.Resolve): Likewise.
5559 (Invocation.DoResolve): Update to changes in semantics of
5562 2005-03-31 Marek Safar <marek.safar@seznam.cz>
5565 * class.cs (AbstractPropertyEventMethod.EmitMethod): Enable emit method
5568 * decl.cs (MemberCache.AddMethods): Fix infinite loop.
5570 2005-03-31 Raja R Harinath <rharinath@novell.com>
5572 Fix difference in behaviour with commandline invocation.
5573 * driver.cs (Driver.Reset): New.
5574 (CompilerCallableEntryPoint): Call it.
5576 * statement.cs (If.Resolve): Avoid spurious "uninitialized
5577 variable" warnings if the boolean expression failed to resolve.
5579 2005-03-30 Sebastien Pouliot <sebastien@ximian.com>
5581 * attribute.cs: Fix the union of several permissions when some of them
5582 are unrestricted (so the result isn't an unrestricted permission set).
5585 2005-03-30 Raja R Harinath <rharinath@novell.com>
5587 * ecore.cs (MemberExpr): New class. Convert from interface
5589 (MemberExpr.ResolveMemberAccess): Refactor and move here from
5590 MemberAccess.ResolveMemberAccess. Tighten up pre-conditions and
5592 (MethodGroupExpr, FieldExpr, PropertyExpr, EventExpr): Update.
5593 (MethodGroupExpr.IsExplicitImpl): Remove.
5594 (Expression.GetFieldFromEvent): Remove.
5595 (SimpleName.MemberStaticCheck): Remove.
5596 (SimpleName.DoSimpleNameResolve): Update to changes.
5597 * expression.cs (MemberAccess.ResolveMemberAccess): Refactor.
5598 (MemberAccess.IdenticalNameAndTypeName): Remove.
5599 (MemberAccess.error176): Move to MemberExpr.
5600 (MemberAccess.DoResolve): Update to changes.
5601 (BaseAccess.DoResolve): Likewise.
5603 2005-03-30 Marek Safar <marek.safar@seznam.cz>
5605 C# 2.0 Conditional attribute class implementation
5607 * attribute.cs (AttributeTester.IsAttributeExcluded): New method.
5608 Analyzes class whether it has attribute which has ConditionalAttribute
5609 and its condition is not defined.
5611 * class.cs (Class.ApplyAttributeBuilder): Add IsAttributeExcluded check.
5612 (Class.IsExcluded): New method. Search for at least one defined
5613 condition in ConditionalAttribute of attribute class.
5615 2005-03-30 Raja R Harinath <rharinath@novell.com>
5617 * ecore.cs (PropertyExpr): Derive from Expression, not
5618 ExpressionStatement.
5619 (PropertyExpr.EmitStatement): Remove.
5621 2005-03-29 Raja R Harinath <rharinath@novell.com>
5624 * expression.cs (MemberAccess.ResolveMemberAccess): Allow the
5625 internal field "value__" of an enum be private. The examples for
5626 "value__" that I found on MSDN all used FieldAttributes.Private.
5628 * decl.cs (MemberCache.AddMethods): Use C# terminology in warning.
5629 Don't mention IL method attribute names.
5631 Fix #47991. Remove a TODO.
5632 * statement.cs (Block.Toplevel): Make into a field.
5633 (Block.Parameters): Move into ToplevelBlock.
5634 (Block.known_variables): Rename from child_variable_names.
5635 (Block.Block): Remove variants that take Parameters. Initialize
5636 'Toplevel' with the immediately surrounding toplevel block.
5637 (Block.AddKnownVariable): Rename from AddChildVariableName. Add a
5638 LocalInfo parameter.
5639 (Block.GetKnownVariableInfo): New.
5640 (Block.IsVariableNameUsedInChildBlock): Update.
5641 (Block.IsVariableNameUsedInBlock): New. Checks if a name is used in
5642 the block, even though it may not be in scope.
5643 (Block.AddVariable): Remove Parameters parameter. Use
5644 Toplevel.Parameters instead.
5645 (Block.AddConstant): Remove Parameters parameter.
5646 (Block.GetParameterReference): Update to use Toplevel.Parameters.
5647 (Block.IsParamaterReference): Likewise.
5648 (Block.IsLocalParameter): Likewise. Simplify a lot.
5649 (ToplevelBlock.Parameters): New. Moved from Block.
5650 (ToplevelBlock.ToplevelBlock): Update to changes. Always
5651 initialize Parameters to a non-null value.
5652 * cs-parser.jay: Update to changes.
5653 * ecore.cs (SimpleName.SimpleNameResolve): Emit cs0136 error for
5654 simple names that mean different things in the same block. Use
5655 Block.IsVariableNameUsedInBlock.
5657 2005-03-28 Raja R Harinath <rharinath@novell.com>
5659 * enum.cs (Enum.LookupEnumValue): Remove debugging code.
5661 2005-03-26 Raja R Harinath <harinath@acm.org>
5664 * assign.cs (Assign.DoResolve): When the RHS of an assignment
5665 fails to resolve, ensure that the LHS is still resolved as an
5668 2005-03-25 Raja R Harinath <harinath@acm.org>
5670 * enum.cs (Enum.DefineType): Set ec.InEnumContext and
5672 (Enum.current_ec): Remove.
5673 (Enum.LookupEnumValue): Remove EmitContext argument.
5674 Just uses the one created during DefineType.
5675 (Enum.FindMembers): Update.
5676 * expression.cs (MemberAccess.DoResolve): Update.
5678 2005-03-22 Marek Safar <marek.safar@seznam.cz>
5680 * assign.cs (Assign.DoResolve): Check for CS1717 when
5681 source and target are same (uses Equals).
5683 * expression.cs (LocalVariableReference, ParameterReference,
5684 This): Implemented Equals, GetHashCode.
5686 * statement.cs (Block.GetParameterReference): Removed useless
5689 2005-03-22 Raja R Harinath <rharinath@novell.com>
5692 * statement.cs (Block.AddVariable): Ensure that we skip implicit
5693 blocks before deciding whether the error is cs0136 or cs0128.
5695 * cs-parser.jay: Pass MemberName to RootContext.Tree.RecordDecl.
5696 (using_alias_directive, using_namespace_directive): Pass
5697 MemberName, not an expression to Namespace.UsingAlias and
5699 (MakeName): Use the MemberName of the namespace.
5700 * namespace.cs (Namespace.MemberName): New.
5701 (UsingEntry.UsingEntry): Take a MemberName, not an expression.
5702 (AliasEntry.AliasEntry, Namespace.Using, Namespace.UsingAlias):
5704 * decl.cs (MemberName.Name): Make readonly.
5705 (MemberName.FromDotted): New "constructor".
5706 (MemberName.Equals, MemberName.GetHashCode): Implement overrides.
5707 (MemberCore.Name): Compute from MemberName on demand.
5708 (MemberCore.SetMemberName): Provide a way to change the
5710 (MemberCore.AddToContainer): Don't take a fullname parameter.
5711 * class.cs (TypeContainer.AddToMemberContainer): Don't add the
5712 fully qualified name of the container to the member name.
5713 (TypeContainer.AddToTypeContainer): Use a fully qualified name
5714 only if the type is a member of the root container.
5715 (TypeContainer.AddMethod, TypeContainer.AddProperty): Use
5716 MemberName.Left rather than searching for an embedded ".".
5717 (PartialContainer.CreatePart): Update to changes in RootContext.
5718 (MemberBase.ShortName): Turn into a property. Use
5719 MemberCore.SetMemberName.
5720 (MemberBase.ExplicitInterfaceName): Remove.
5721 (MemberBase.UpdateMemberName): Remove.
5722 (AbstractPropertyEventMethod.UpdateName): Use SetMemberName.
5723 (PropertyBase.SetMemberName): New override.
5724 * tree.cs (Tree.RecordDecl): Take a MemberName and use it as hash key.
5725 (Tree.GetDecl): New.
5726 (Tree.AllDecls): Rename from Decls.
5727 * attribute.cs, enum.cs, report.cs: Update to changes.
5728 * driver.cs (MainDriver): Use MemberName.FromDotted on
5729 RootContext.MainClass.
5731 2005-03-21 Marek Safar <marek.safar@seznam.cz>
5733 * class.cs (FixedField.Define): Check for CS1664 and more sanity
5736 * expression.cs (ElementAccess.DoResolveLValue): Check for CS1708.
5738 2005-03-18 Marek Safar <marek.safar@seznam.cz>
5740 * modifiers.cs (Modifiers.PROPERTY_CUSTOM): New constant for
5741 property accessor modifiers.
5743 * class.cs (FieldMember.ApplyAttributeBuilder): Don't allow apply
5744 fixed buffer attribute (CS1716).
5745 (PropertyMethod.HasCustomAccessModifier): When property accessor
5746 has custom modifier.
5748 * ecore (PropertyExpr.DoResolve): Add CS0271 for custom accessor
5750 (PropertyExpr.DoResolveLValue): Add CS0272.
5752 2005-03-17 Miguel de Icaza <miguel@novell.com>
5754 * convert.cs: When converting to a pointer, use the proper Conv.U
5755 or Conv.I depending on the source data type.
5757 * cs-tokenizer.cs: Make the size for large decimal constants,
5760 2005-03-17 Martin Baulig <martin@ximian.com>
5762 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
5763 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
5765 2005-03-17 Martin Baulig <martin@ximian.com>
5767 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
5768 to bool so we can return an error condition.
5769 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
5772 2005-03-16 Zoltan Varga <vargaz@freemail.hu>
5774 * attribute.cs: Encode ThrowOnUnmappableChar and BestFitMapping
5777 2005-03-16 Raja R Harinath <rharinath@novell.com>
5779 Remove TypeManager.LookupType and TypeManager.LookupTypeDirect.
5780 Refactor to avoid traversing the list of assemblies, and to avoid
5781 string concatenation.
5782 * typemanager.cs (guid_attr_type): Remove.
5783 (negative_hits, pointers, references): Remove hashes.
5785 (GetConstructedType): New. Uses type_hash to handle constructed
5786 types (arrays, references, pointers).
5787 (GetReferenceType, GetPointerType): Use it.
5788 (GetNestedType): New. Uses type_hash to handle nested types of
5790 (LookupType, LookupTypeDirect): Remove.
5791 (CoreLookupType): Inline parts of old LookupTypeDirect code. Use
5792 'types' hash and LookupTypeReflection directly.
5793 (params_string, params_object): Use GetConstructedType.
5794 * namespace.cs (Namespace.cached_types): New. Cache of reflected
5796 (Namespace.Lookup): Use cached_types.
5797 (NamespaceEntry.LookupNamespaceOrType): Inline the functionality
5798 provided by old TypeManager.LookupType.
5799 * rootcontext.cs (MakeFQN): Remove.
5800 * decl.cs (DeclSpace.MakeFQN): Likewise.
5801 (DeclSpace.LookupType): Use TypeManager.GetNestedType.
5802 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
5803 TypeManager.GetConstructedType.
5804 * tree.cs (decl_ns_hash, LookupByNamespace): Remove.
5806 2005-04-16 Zoltan Varga <vargaz@freemail.hu>
5808 * cs-parser.jay: Fix build.
5810 2005-03-15 Marek Safar <marek.safar@seznam.cz>
5812 * class.cs (TypeContainer.CircularDepException) New nested
5813 (MethodCore.CheckBase): Report CS1715 for properties and indexers.
5815 * cs-parser.jay: Reports CS1527 for any namespace element.
5817 * delegate.cs (DelegateCreation.Error_NoMatchingMethodForDelegate):
5820 * expression.cs (ParameterReference.IsAssigned): Changed error to
5822 (Error_WrongNumArguments): Moved CS0245 detection here.
5824 * statement.cs (Return.Resolve): Add CS1622 report.
5826 2005-03-11 Marek Safar <marek.safar@seznam.cz>
5828 * class.cs (StaticClass.DefineContainerMembers): Added CS0720.
5830 2005-03-11 Zoltan Varga <vargaz@freemail.hu>
5832 * attribute.cs expression.cs: Get rid of some allocations.
5834 2004-03-11 Atsushi Enomoto <atsushi@ximian.com>
5836 * doc.cs : just eliminate the latest change.
5838 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
5840 * doc.cs : commented out the latest change. It breaks xml-030.cs
5842 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
5844 * doc.cs : When TypeBuilder did not create Type yet, GetEvents() will
5845 fail. So invoke CreateType() in FindDocumentedType().
5847 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
5849 * cs-tokenizer.cs : added IsKeyword().
5850 * doc.cs : Detect keyword incorrectly used as identifier.
5851 Allow identifiers prefixed by @.
5853 2005-03-10 Marek Safar <marek.safar@seznam.cz>
5855 * attributes.cs (Attributes.Emit): Continue after CheckTargets.
5856 It caused exception in namespace resolving (again!).
5858 * class.cs (Class.ctor): Removed exit.
5859 (PropertyMethod.ctor): ditto.
5861 * codegen.cs (Codegen.Reset): Reset static data.
5862 (Codegen.ResolveTopBlock): Forward error status from ResolveMeta.
5864 * cs-tokenizer.cs (Cleanup): Removed.
5866 * driver.cs (GetSystemDir): Rewrote to one line command.
5867 It caused problem with unloaded dynamic modules.
5868 (UnixParseOption): Removed Exit.
5869 (CompilerCallableEntryPoint.InvokeCompiler): Make static.
5870 (CompilerCallableEntryPoint.Reset): Reset suitable static data.
5871 Now can be mcs used as library.
5873 * ecore.cs (Expression.ResolveBoolean): Use Location.Null for
5876 * location.cs (Reset): Reset static data.
5878 * namespace.cs (Reset): Reset static data.
5880 * report.cs (Report.Reset): Reset static data.
5882 * rootcontext.cs (RootContext.Reset): Reset static data.
5884 * tree.cs (RootTypes.ctor): Use Location.Null
5886 * typemanager.cs (TypeManager.Reset): Reset static data.
5887 (CoreLookupType): Removed Exit.
5888 (TypeHandle.Reset): Reset static data.
5890 2005-03-10 Raja R Harinath <rharinath@novell.com>
5893 * typemanager.cs (ComputeNamespaces): Import namespaces from
5894 referenced modules too.
5896 2005-03-09 Raja R Harinath <rharinath@novell.com>
5898 * class.cs (TypeContainer.AddToMemberContainer): Use "." rather
5901 2005-03-09 Raja R Harinath <rharinath@novell.com>
5903 * decl.cs (DeclSpace.LookupType): Don't loop but recurse into
5904 enclosing DeclSpace. This ensures that a name-lookup populates
5905 more caches and there are fewer 'TypeExpression's. Carve out
5906 nested type lookup into ...
5907 (LookupNestedTypeInHierarchy): ... this.
5909 2005-04-15 Martin Baulig <martin@ximian.com>
5911 Merged r41590 from MCS and make it work in the generics land.
5913 * generic.cs (TypeParameter.UpdateConstraints): Removed the
5916 * class.cs (PartialContainer.UpdateConstraints): Removed.
5917 (PartialContainer.CheckConstraints): Removed.
5918 (PartialContainer.SetParameterInfo): Store the constraints here.
5919 (PartialContainer.DefineTypeParameters): New public method;
5920 resolve the type parameter's constraints here. Note that the
5921 PartialContainer doesn't have an EmitContext anymore, so we must
5922 do this in the ClassPart.
5924 2005-03-09 Raja R Harinath <rharinath@novell.com>
5926 Clean up a few partial-class semantics.
5927 Fixes test-357.cs and cs1618-2.cs.
5928 * cs-parser.jay (struct_declaration): Use 'current_class' as
5929 parent of newly-created struct. Remove call to Register ().
5930 Use 'pop_current_class' to complete handing the current struct.
5931 (interface_declaration): Likewise.
5932 (class_declaration): Likewise.
5933 (enum_declaration): Use 'current_class' as parent of newly created
5935 (delegate_declaration): Likewise.
5936 (pop_current_class): New function. This is used to handle closing
5937 up the 'current_class' and 'current_container', and pointing them
5938 to the enclosing class/container.
5939 (CSharpParser): Initialize 'current_class' too.
5940 * decl.cs (MemberCore): Add check for invariant: a partial
5941 container is not a parsed entity, and thus does not enclose any
5943 (DeclSpace.TypeResolveEmitContext): Expose 'type_resolve_ec'.
5944 (DeclSpace.BaseTypeExpr): Use it.
5945 (DeclSpace.LookupType): Add check for invariant.
5946 * class.cs (TypeContainer): Add check for invariant: a nested
5947 class should have the same NamespaceEntry as its enclosing class.
5948 (TypeContainer.EmitFieldInitializers): Make virtual.
5949 (TypeContainer.DefineDefaultConstructor): Adhere to invariant in
5951 (TypeContainer.Register): Remove.
5952 (TypeContainer.DefineType): Set the 'ec' of a PartialContainer to
5953 null. Use TypeResolveEmitContext for resolving base types and
5954 interfaces. Move initialization of Parts.TypeBuilder here from
5956 (TypeContainer.DefineNestedTypes): ... here.
5957 (PartialContainer): Take a Namespace not a NamespaceEntry.
5958 (PartialContainer.Create): Don't use Register. Call the
5959 appropriate Add... function directly.
5960 (ClassPart): Take both the PartialContainer and the enclosing
5961 class as constructor arguments.
5962 (ClassPart.EmitFieldInitializers): Override.
5963 (ClassPart.PartFindNestedTypes): Remove.
5964 (FieldBase.GetInitializerExpression): Resolve the initializer
5965 expression in the emit context of the enclosing class.
5966 * tree.cs (RootTypes): Remove Register ().
5968 2005-03-08 Marek Safar <marek.safar@seznam.cz>
5970 * cs-parser.jay: Removed CS0134.
5972 * driver.cs: Removed CS1901.
5974 * expression.cs (SizeOf.DoResolve): Don't report CS0233
5975 for predefined types.
5977 2005-03-07 Duncan Mak <duncan@novell.com>
5979 * codegen.cs (Save): Catch UnauthorizedAccessException as
5980 well. Fixes bug #73454.
5982 2005-03-07 Marek Safar <marek.safar@seznam.cz>
5984 * cs-tokenizer.cs (xtoken): Add CS1035.
5986 * class.cs (MethodData.Define): Add CS0683.
5987 (FieldMember.ctor): Add CS0681.
5989 2005-03-07 Raja R Harinath <rharinath@novell.com>
5991 * ecore.cs (SimpleName.DoResolve): Rename from
5992 SimpleName.DoResolveAllowStatic.
5993 (SimpleName.DoSimpleNameResolve): Remove 'allow_static' argument.
5994 Pass 'intermediate' flag to MemberStaticCheck.
5995 (SimpleName.MemberStaticCheck): Skip "static check" only in case
5996 of "intermediate" lookups via MemberAccess.
5997 (SimpleName.IdenticalNameAndTypeName): New. Carved out of ...
5998 * expression.cs (MemberAccess.IdenticalNameAndTypeName): ... this.
6000 2005-03-07 Raja R Harinath <rharinath@novell.com>
6003 * ecore.cs (FieldExpr.EmitInstance): Catch cases of CS0120 that
6004 slipped in because of variable names that are identical to a
6005 builtin type's BCL equivalent ('string String;', 'int Int32;').
6006 (PropertyExpr.EmitInstance): Likewise.
6008 2005-03-04 Marek Safar <marek.safar@seznam.cz>
6010 * cs-tokenizer.cs (PreProcessPragma): Add warning 1633, 1635.
6012 * report.cs (warning_ignore_table): Made public.
6014 2005-03-04 Raja R Harinath <rharinath@novell.com>
6017 * class.cs (MethodData.Emit): Pass 'container' to
6018 container.GetObsoleteAttribute instead of 'container.Parent'.
6020 2005-03-03 Marek Safar <marek.safar@seznam.cz>
6022 * cs-parser.jay: Add 1534 error test.
6024 * iterators.cs (Yield.CheckContext): Add error 1629.
6025 (Iterator.ctor): Save unsafe modifier.
6026 (MoveNextMethod.DoEmit): Restore unsafe context.
6028 * namespace.cs (UsingAlias): Better error message.
6030 2005-03-03 Dan Winship <danw@novell.com>
6032 * convert.cs (Error_CannotImplicitConversion): fix two bugs in
6033 the warning message [#73219]
6035 2005-03-03 Raja R Harinath <rharinath@novell.com>
6037 Fix compile with MCS 1.0.0.0.
6038 * cs-tokenizer.cs (PreProcessPragma): Simplify w_disable and
6039 w_restore to not depend on string constant folding.
6041 2005-03-03 Raja R Harinath <rharinath@novell.com>
6043 * decl.cs (DeclSpace.LookupType): Remove 'silent' argument. Move
6044 CS0246 check to users who passed 'silent = false'.
6045 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): Add CS0246
6047 (SimpleName.SimpleNameResolve): Update.
6048 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0246 check.
6049 (MemberAccess.IdenticalNameAndTypeName): Update.
6050 * doc.cs (FindDocumentedTypeNonArray): Update.
6052 2005-03-03 Raja R Harinath <rharinath@novell.com>
6054 * codegen.cs (EmitContext): Remove ResolvingTypeTree.
6055 * parameters.cs (ComputeAndDefineParameters): Remove.
6056 * decl.cs (ResolveBaseTypeExpr): Don't set ResolvingTypeTree.
6057 * delegate.cs (Define): Don't invoke ComputeAndDefineParameters.
6058 Use GetParameterInfo.
6060 2005-03-02 Marek Safar <marek.safar@seznam.cz>
6062 * report.cs (StaticClass.DefineContainerMembers): Add warning 628.
6064 2005-03-02 Raja R Harinath <rharinath@novell.com>
6066 Unify DeclSpace.LookupType and DeclSpace.FindType.
6067 * decl.cs (DeclSpace.FindNestedType): New virtual function. This
6068 is in charge of defining nested types on demand.
6069 (DeclSpace.LookupType): Use it when the current_type is a
6070 TypeBuilder. Use LookupTypeDirect for reflected types.
6071 (DeclSpace.FindType): Remove.
6072 (DeclSpace.LookupInterfaceOrClass): Likewise.
6073 (DeclSpace.DefineTypeAndParents): Likewise.
6074 * ecore.cs (SimpleName.ResolveAsTypeStep): Just call
6075 DeclSpace.LookupType.
6076 * doc.cs (FindDocumentedTypeNonArray): Use DeclSpace.LookupType.
6077 * typemanager.cs (LookupType): Simplify.
6078 (AddUserType): Remove type from negative_hits.
6079 * namespace.cs (Namespace.Lookup): Use TypeManager.LookupTypeDirect.
6080 * class.cs (TypeContainer.FindMembers): Move handling of nested
6082 (TypeContainer.FindMembers_NestedTypes): ... here.
6083 (TypeContainer.FindNestedType): Implement override.
6084 (ClassPart.FindNestedType): Delegate to PartialContainer.
6085 (ClassPart.PartFindNestedType): Looks up the nested types of the
6088 2005-04-14 Martin Baulig <martin@ximian.com>
6090 * generic.cs (ConstructedType): Moved all the type lookup and
6091 nested class logic into SimpleName.
6092 (ConstructedType.ResolveConstructedType): Our underlying type is
6093 already fully resolved; all the type lookup stuff is in
6096 * ecore.cs (SimpleName.ResolveAsTypeStep): Resolve nested
6097 constructed types here instead of in ConstructedType.
6099 * decl.cs (MemberName.GetTypeExpression): Always create a
6100 SimpleName, not a ConstructedType.
6101 (DeclSpace.ResolveNestedType): Removed; this is now in SimpleName.
6103 2005-03-02 Martin Baulig <martin@ximian.com>
6105 * class.cs (TypeContainer.DoDefineMembers): We also need a default
6106 static constructor in static classes.
6108 2005-03-01 Zoltan Varga <vargaz@freemail.hu>
6110 * attribute.cs: Pass -1 to DefineLPArrayInternal if sizeConst or
6111 sizeParamIndex is not specified.
6113 2005-03-01 Marek Safar <marek.safar@seznam.cz>
6116 * report.cs (WarningMessage.IsEnabled): Missing null check.
6118 2005-02-28 Marek Safar <marek.safar@seznam.cz>
6120 * attribute.cs (DefinePInvokeMethod): Fix, all data are stored
6121 in the fields and not in the properties.
6123 2005-02-28 Zoltan Varga <vargaz@freemail.hu>
6125 * attribute.cs (GetMarshal): Marshal SizeConst and SizeParamIndex
6128 2005-02-28 Marek Safar <marek.safar@seznam.cz>
6130 * attribute.cs: Small refactoring (improved robustness).
6131 (ImplOptions, UnmanagedType, UsageAttribute): Removed members.
6132 (ValidateGuid): Removed.
6133 (Resolve): Removed referenced to above mentioned.
6134 (GetAttributeUsage): Made private and changed to work without
6136 (GetIndexerAttributeValue): Don't crash.
6137 (GetConditionalAttributeValue): Ditto.
6138 (GetClsCompliantAttributeValue): Ditto.
6139 (ExtractSecurityPermissionSet): All attributes exceptions are
6141 (GetPropertyValue): New helper.
6142 (GetMethodImplOptions): New method.
6143 (DefinePInvokeMethod): Reuse common code. Implemented handling of
6144 some missing properties.
6146 * class.cs (ClassOrStruct.ApplyAttributeBuilder): Updated.
6147 (Method.ApplyAttributeBuilder): Updated.
6149 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't catch shared
6152 2005-02-28 Raja R Harinath <rharinath@novell.com>
6155 * report.cs (Report.SymbolRelatedToPreviousError): Handle
6156 non-simple types (array, pointer, reference).
6158 2005-02-28 Marek Safar <marek.safar@seznam.cz>
6160 * cs-parser.jay: Add errors 1617, 650, 1007, 531, 547, 548
6162 * class.cs (MethodCore.IsDuplicateImplementation): Special error
6164 (Method.CheckBase): Catch wrong destructor here.
6165 (MethodData.Define): Add errors 550, 668.
6167 * cs-tokenizer.cs (PreProcessPragma): Add warning 1634.
6169 * ecore.cs (PropertyExpr.DoResolveLValue): Fixed wrong error code.
6171 * pending.cs (VerifyPendingMethods): Add error 551.
6173 * typemanager.cs (CSharpName): Next error report helper.
6175 2005-02-25 Marek Safar <marek.safar@seznam.cz>
6177 * attribute.cs (Atttribute.Resolve): Add cache for parameter-less
6178 attributes. Removed useless attribute double check.
6179 It saves almost 2MBs for corlib.
6181 2005-02-25 Raja R Harinath <rharinath@novell.com>
6184 * statement.cs (ExpressionStatement.Resolve): Make robust to being
6185 called twice in case of error.
6187 2005-02-23 Chris Toshok <toshok@ximian.com>
6189 Fix compiler portions of #72827.
6190 * statement.cs (Block.Emit): call Begin/EndScope on the
6191 EmitContext instead of the ILGenerator.
6193 * codegen.cs (EmitContext.BeginScope): new method, call
6194 ILGenerator.BeginScope as well as the SymbolWriter's OpenScope (if
6196 (EmitContext.BeginScope): same, but EndScope and CloseScope
6198 * symbolwriter.cs (SymbolWriter.OpenScope): get the current il
6199 offset and call the superclass's OpenScope(int) with it.
6200 (SymbolWriter.CloseScope): get the current il
6201 offset and call superclass's CloseScope(int) with it.
6203 2005-02-23 Marek Safar <marek.safar@seznam.cz>
6205 * anonymous.cs (AnonymousMethod.Compatible): Fixed to report
6206 CS1677 for out and ref as well.
6208 * class.cs (Method.Define): Add error CS1599 detection.
6210 * cs-parser.jay: Add CS1609, CS1670, CS1627 detection.
6212 * cs-tokenizer.cs (xtoken): Add error CS1646 detection.
6214 * delegate.cs (Delegate.Define): Add error CS1599 detection.
6216 * support.cs.cs (ModifierDesc): New helper method.
6218 2005-02-23 Raja R Harinath <rharinath@novell.com>
6219 Abin Thomas <projectmonokochi@rediffmail.com>
6220 Anoob V E <projectmonokochi@rediffmail.com>
6221 Harilal P R <projectmonokochi@rediffmail.com>
6224 * class.cs (ConstructorBuilder.Resolve): Make sure that the second
6225 MemberLookup (used for error reporting) actually returns a result.
6226 Fix error report number (122, not 112).
6228 2005-02-22 Abin Thomas <projectmonokochi@rediffmail.com>
6229 Anoob V E <projectmonokochi@rediffmail.com>
6230 Harilal P R <projectmonokochi@rediffmail.com>
6233 * pending.cs (PendingImplementation.GetAbstractMethods):
6234 Find NonPublic members too.
6236 2005-02-22 Marek Safar <marek.safar@seznam.cz>
6238 * expression.cs.cs (ConditionalLogicalOperator.DoResolve):
6241 * class.cs (MethodCore.CheckMethodAgainstBase):
6242 Add error 239 report.
6244 2005-02-21 Marek Safar <marek.safar@seznam.cz>
6246 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
6248 * class.cs (Operator.Define): Add error 217 report.
6250 2005-02-21 Raja R Harinath <rharinath@novell.com>
6253 * expression.cs (Invocation.IsApplicable): Make public.
6254 (Invocation.IsParamsMethodApplicable): Likewise.
6255 * delegate.cs (Delegate.VerifyApplicability): Don't use
6256 Invocation.VerifyArgumentCompat for parameter applicability
6257 testing. Use Invocation.IsApplicable and
6258 Invocation.IsParamsMethodApplicable.
6260 2005-02-21 Marek Safar <marek.safar@seznam.cz>
6262 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
6264 * class.cs (Operator.Define): Add error 217 report.
6266 2005-02-21 Raja R Harinath <rharinath@novell.com>
6268 * namespace.cs (UsingEntry.Resolve): Undo change below.
6270 2005-02-21 Raja R Harinath <rharinath@novell.com>
6273 * ecore.cs (Expression.MemberLookupFailed): Add argument to
6274 disable the error message when the extended MemberLookup also
6276 (Expression.MemberLookupFinal): Update.
6277 (SimpleName.DoSimpleNameResolve): Update.
6278 * expression.cs (MemberAccess.ResolveNamespaceOrType):
6279 Don't use MemberLookupFinal.
6280 (New.DoResolve): Update.
6281 (BaseAccess.CommonResolve): Update.
6283 2005-02-21 Raja R Harinath <rharinath@novell.com>
6286 * attribute.cs (Attribute.ResolveType): If a 'resolve_error' had
6287 occured previously, don't resolve again.
6289 2005-02-21 Marek Safar <marek.safar@seznam.cz>
6292 * attribute.cs (Attribute.GetAttributeUsage): Add EmitContext
6293 argument. Call ResolveAttributeUsage for unresolved.
6294 when types doesn't match ctor arguments.
6296 * class.cs (DoDefineMembers.TypeContainer): Removed safety check
6297 for nested attribute classes.
6298 (Class.attribute_usage): Removed.
6299 (Class.ResolveAttributeUsage): Resolves AttributeUsageAttribute
6300 for attribute class.
6302 * ecore.cs (IsAttribute): Removed.
6304 * namespace.cs (UsingEntry.Resolve): Don't destroy NamespaceEntry.
6306 * rootcontext.cs (RegisterAttribute): Removed, attributes are
6308 (attribute_types): Removed.
6309 (EmitCode): Global attributes are emited as the latest.
6311 2005-02-18 Marek Safar <marek.safar@seznam.cz>
6313 * class.cs (EmitFieldInitializers): Don't emit field initializer
6314 for default values when optimilization is on.
6316 * constant.cs (Constant.IsDefaultValue): New property.
6318 * driver.cs: Add /optimize handling.
6322 * literal.cs: Implement new IsDefaultValue property.
6324 * rootcontext.cs (Optimize): New field, holds /optimize option.
6326 2005-02-18 Raja R Harinath <rharinath@novell.com>
6328 Fix crasher in re-opened #72347.
6329 * namespace.cs (Namespace.Lookup): Return null if
6330 DeclSpace.DefineType returns null.
6333 * expression.cs (Argument.Resolve): Handle a case of CS0120 here.
6335 2005-02-18 Raja R Harinath <rharinath@novell.com>
6337 Fix remainder of #63202. Change semantics of DoResolveLValue: it
6338 now returns null if it cannot resolve to an lvalue.
6339 * ecore.cs (Expression.DoResolveLValue): Return 'null' by default.
6340 (Expression.ResolveLValue): Emit CS0131 error if DoResolveLValue
6341 returned null. Remove check for SimpleName.
6342 (EventExpr.DoResolveLValue): New.
6343 * iterators.cs (Iterator.FieldExpression.DoResolveLValue): New.
6344 * expression.cs (Argument.Error_LValueRequired): New. Move CS1510
6346 (Argument.Resolve): ... here. Use it. Use DoResolveLValue to
6348 (Unary.ResolveOperator): Move CS0211 check ...
6349 (Unary.DoResolve): ... here. Use DoResolveLValue to avoid
6351 (Unary.DoResolveLValue): Simplify.
6352 (AddressOf.DoResolveLValue): New.
6353 (ArrayAccess.DoResolveLValue): New.
6355 2005-02-16 Marek Safar <marek.safar@seznam.cz>
6357 * attribute.cs (Attribute.Resolve): Add arguments casting for
6358 when types doesn't match ctor arguments.
6360 2005-02-16 Raja R Harinath <rharinath@novell.com>
6362 Fix parts of #63202.
6363 * expression.cs (UnaryMutator.ResolveOperator): Remove redundant
6364 lookup of operator in base type. Ensure that all checks happen
6365 when the operator resolves to an "op_..." method.
6367 2005-02-15 Raja R Harinath <rharinath@novell.com>
6370 * namespace.cs (NamespaceEntry.LookupNamespaceOrType): Add
6371 'ignore_cs0104' parameter. Pass it to ...
6372 (NamespaceEntry.Lookup): ... this.
6373 * decl.cs (DeclSpace.LookupType): Add 'ignore_cs0104' parameter.
6374 * ecore.cs (SimpleName.ResolveAsTypeStep): Update.
6375 (TypeLookupExpression.DoResolveAsTypeStep): Update.
6376 * expression.cs (MemberAccess.IdenticalNameAndTypeName):
6377 Update. Request that cs0104 errors be ignored.
6378 (ComposedCast.ResolveAsTypeStep): Update.
6380 2005-02-14 Raja R Harinath <rharinath@novell.com>
6383 * expression.cs (Invocation.BetterFunction): Remove support for
6384 comparing virtual functions and their overrides.
6385 (Invocation.IsOverride): New.
6386 (Invocation.OverloadResolve): Don't consider 'override' functions
6387 during candidate selection. Store them in a lookaside list.
6388 If the selected method is a 'virtual' function, use the list to
6389 find any overrides that are closer to the LHS type.
6391 2005-02-14 Marek Safar <marek.safar@seznam.cz>
6393 * expression.cs (New.DoResolve): Add complex core type reduction.
6394 (New.Constantify): Converts complex core type syntax like 'new int ()'
6397 2005-02-14 Raja R Harinath <rharinath@novell.com>
6399 * decl.cs (EntryType.EntryType): New constructor to create an
6400 updated copy of a cache entry.
6401 (MemberCache.AddMethods): Use it.
6402 (MemberCache.ClearDeclaredOnly): Remove.
6403 (MemberCache.MemberCache): Update.
6405 2005-02-11 Miguel de Icaza <miguel@novell.com>
6407 * codegen.cs (EmitContext): Introduce the `MethodIsStatic'
6408 variable. This one is represents the actual low-level declaration
6409 of the method, as opposed to the semantic level `IsStatic'.
6411 An anonymous method which is hosted into a static method might be
6412 actually an instance method. IsStatic would reflect the
6413 container, while MethodIsStatic represents the actual code
6416 * expression.cs (ParameterReference): Use the new MethodIsStatic
6417 instead of IsStatic.
6419 * anonymous.cs (AnonymousMethod.Compatible): Pass the
6420 Modifiers.STATIC to the Anonymous' Method EmitContext if static is
6421 set on the current EmitContext.
6423 * expression.cs (Cast): Overload DoResolveLValue so we can pass
6424 resolve our casted expression as an LValue. This triggers the
6425 proper LValue processing that is later required by Assign.
6429 * cs-tokenizer.cs (pp_and): recurse on pp_and, fixes #61903.
6431 2005-02-11 Marek Safar <marek.safar@seznam.cz>
6433 C# 2.0 Fixed buffer implementation
6435 * anonymous.cs: Update after RegisterHelperClass renaming.
6437 * attribute.cs (AttributeTester.fixed_buffer_cache):
6438 Cache of external fixed buffers.
6439 (AttributeTester.GetFixedBuffer): Returns IFixedBuffer
6440 implementation if field is fixed buffer else null.
6443 (TypeContainer.AddField): Accept FieldMember instead of Field.
6444 (FieldBase.IsFieldClsCompliant): Extracted code from
6445 VerifyClsCompliance descendant customization.
6446 (FixedField): New class handles fixed buffer fields.
6447 (FixedFieldExternal): Keeps information about imported fixed
6449 (IFixedField): Make access to internal or external fixed buffer
6452 * cs-parser.jay: Add fixed buffer parsing.
6454 * ecore.cs (FieldExpr.Emit): Add special emit case for fixed
6457 * expression.cs (Indirection): Extended implementation to accept
6459 (PointerArithmetic.Emit): Get element from fixed buffer as well.
6460 (ElementAccess.MakePointerAccess): Get type as parameter.
6461 (DoResolve): Add fixed buffer field expression conversion.
6462 (DoResolveLValue): Ditto.
6463 (FixedBufferPtr): New class. Moved most of original ArrayPtr.
6464 (ArrayPtr): Derives from FixedBufferPtr.
6465 (ArrayPtr.Emit): Add extra emit for array elements.
6467 * flowanalysis.cs.cs (StructInfo): Use FieldMember.
6469 * rootcontext.cs (CloseTypes): Emit CompilerGenerated attribute
6470 for compiler generated types.
6471 (RegisterCompilerGeneratedType): Renamed from RegisterHelperClass.
6473 * statement.cs (Fixed): Refactored to be easier add fixed buffer
6474 and consume less memory.
6475 (Fixed.Resolve): Add fixed buffer case.
6477 * typemanager.cs (compiler_generated_attr_ctor,
6478 fixed_buffer_attr_ctor): Add new 2.0 compiler attributes.
6479 (HasElementType): Add our own implementation to work on every
6482 2005-02-11 Miguel de Icaza <miguel@novell.com>
6484 * anonymous.cs (CaptureContext): Track whether `this' has been
6487 * expression.cs (This.ResolveBase): Call CaptureThis. Before we
6488 only captured `this' if it was implicitly done (instance
6489 methods/variables were used).
6491 * codegen.cs (EmitContext.CaptureThis): New method to flag that
6492 `this' must be captured.
6494 2005-01-30 Miguel de Icaza <miguel@novell.com>
6496 * anonymous.cs (CreateMethodHost): If there Scope.ScopeTypeBuilder
6497 is null it means that there has been no need to capture anything,
6498 so we just create a sibling.
6500 Renamed `EmitHelperClasses' to `EmitAnonymousHelperClasses'
6502 Just a partial fix. The other half is fairly elusive.
6504 2005-02-10 Raja R Harinath <rharinath@novell.com>
6506 Fix #52586, cs0121-4.cs.
6507 * decl.cs (MemberCache.DeepCopy): Rename from SetupCache. Take
6508 and return a hashtable.
6509 (MemberCache.ClearDeclaredOnly): New.
6510 (MemberCache.MemberCache): Update to change. Make a deep copy of
6511 the method_hash of a base type too.
6512 (MemberCache.AddMethods): Adapt to having a deep copy of the base
6513 type methods. Overwrite entries with the same MethodHandle so
6514 that the ReflectedType is correct. The process leaves in base
6515 virtual functions and their overrides as distinct entries.
6516 (CacheEntry): Now a class instead of a struct. It shouldn't alter
6517 matters since it was boxed in a ArrayList before.
6518 (CacheEntry.Member, CacheEntry.EntryType): Remove 'readonly'
6520 * expression.cs (Invocation.BetterFunction): Simplify. Handle the
6521 case of a virtual function and its override (choose the overload
6523 (Invocation.OverloadResolve): Avoid 'override' members during
6524 'applicable_type' calculation.
6526 2005-03-28 Raja R Harinath <rharinath@novell.com>
6528 * typemanager.cs (TypeHandle.BaseType): Make into an IMemberContainer.
6529 (TypeHandle.TypeHandle): Use LookupMemberCache rather than
6530 GetTypeHandle. It is possible for a reflected type to derive from
6531 a TypeBuilder (e.g., int[] derives from the TypeBuilder
6532 System.Array during mscorlib compilation).
6533 * decl.cs (MemberCache.MemberCache): If the base cache doesn't
6534 contain a method_hash, don't create one either. Don't create a
6535 deep copy of the base cache's method_hash.
6536 (MemberCache.SetupCache): Rename back from DeepCopy.
6537 (MemberCache.AddMethods): Rewrite, now that method_hash isn't
6538 already initialized. If we see an override function, add its
6539 underlying base virtual function to the member_hash too.
6541 2005-02-09 Raja R Harinath <rharinath@novell.com>
6543 Combine two near-redundant caches.
6544 * typemanager.cs (method_params): Rename from method_internal_params.
6545 (TypeManager.GetParameterData): New. Replace
6546 Invocation.GetParameterData.
6547 (TypeManager.LookupParametersByBuilder): Remove.
6548 * expression.cs (Invocation.method_parameter_cache): Remove.
6549 (Invocation.GetParameterData): Remove.
6551 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
6554 2005-02-08 Raja R Harinath <rharinath@novell.com>
6557 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
6558 TypeManager.multicast_delegate_type is null, resolve it by looking
6559 up "System.MulticastDelegate".
6560 * rootcontext.cs (RootContext.ResolveCore): Simplify.
6562 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
6563 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
6564 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
6567 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
6568 (LabeledStatement.AddReference): New. Set 'referenced'.
6569 (Goto.Resolve): Use it.
6571 2005-02-05 John Luke <john.luke@gmail.com>
6573 * driver.cs: remove duplicate -doc line in Usage ()
6575 2005-02-04 Raja R Harinath <rharinath@novell.com>
6577 * location.cs (Location.AddFile): Fix CS2002 error report.
6579 2005-02-02 Martin Baulig <martin@ximian.com>
6581 * delegate.cs (Delegate.DefineType): Report an internal error if
6582 TypeManager.multicast_delegate_type is null. See bug #72015 for
6585 2005-02-02 Raja R Harinath <rharinath@novell.com>
6587 Fix a crasher in a variant of #31984.
6588 * const.cs (Constant.CheckBase): New override that defers the
6589 new-or-override check in case the base type hasn't been populated
6591 (Constant.Define): Ensure the new-or-override check is performed.
6593 2005-02-01 Duncan Mak <duncan@ximian.com>
6595 * const.cs (LookupConstantValue): Check that `ce' is not null
6596 before calling GetValue ().
6598 2005-02-01 Raja R Harinath <rharinath@novell.com>
6600 Fix test-334.cs (#69519).
6601 * cs-parser.jay (using_alias_directive): Pass in an expression to
6602 NamespaceEntry.UsingAlias.
6603 (using_namespace_directive): Pass in an expression to
6604 NamespaceEntry.Using.
6605 (namespace_name): Don't flatten to a string.
6606 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
6607 (NamespaceEntry.AliasEntry.Resolve): Lookup using
6609 (NamespaceEntry.UsingEntry): Likewise.
6610 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
6612 (NamespaceEntry.LookupForUsing): Remove.
6613 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
6615 (NamespaceEntry.Lookup): Remove support for dotted names.
6617 2005-02-01 Raja R Harinath <rharinath@novell.com>
6619 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
6621 (NamespaceEntry.ImplicitParent): Compute on demand.
6622 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
6623 parallels the current.
6624 (NamespaceEntry.LookupForUsing): Use it.
6625 (NamespaceEntry.Lookup): If the current namespace-entry is
6626 implicit, don't search aliases and using tables.
6628 2005-02-01 Raja R Harinath <rharinath@novell.com>
6631 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
6633 (TypeContainer.BaseCache): Compute on demand.
6634 (TypeContainer.FindMembers): Define constants and types if they're
6635 not already created.
6636 (FieldMember.Define): Move resetting of ec.InUnsafe before error
6638 * const.cs (Constant.Define): Make idempotent.
6640 2005-01-29 Miguel de Icaza <miguel@novell.com>
6642 * pending.cs: Produce better code (no nops produced by using Ldarg
6645 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
6646 i - 1' it should be arg + 1.
6650 2005-01-28 Raja R Harinath <rharinath@novell.com>
6652 * attribute.cs (Attribute.CheckAttributeType): Make private
6654 (Attribute.ResolveType): Make virtual.
6655 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
6656 handling of RootContext.Tree.Types.
6658 2005-01-27 Raja R Harinath <rharinath@novell.com>
6660 Update attribute-handling to use the SimpleName/MemberAccess
6662 * cs-parser.jay (attribute): Pass in an expression to the
6663 constructors of Attribute and GlobalAttribute.
6664 * attribute.cs (Attribute): Take an expression for the name.
6665 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
6666 passed in attribute name expression.
6667 (Attribute.CheckAttributeType): Use it.
6668 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
6669 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
6670 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
6671 argument to prevent error messages if the lookup fails.
6673 2005-01-27 Marek Safar <marek.safar@seznam.cz>
6675 * expression.cs (Indirection): Implemented IVariable interface
6676 to support indirection in AddressOf operator.
6677 (PointerArithmetic.Emit): Add optimalization for case where
6678 result can be precomputed.
6680 2005-01-26 Martin Baulig <martin@ximian.com>
6682 * class.cs (TypeContainer.AttributeTargets): Return the correct
6683 AttributeTargets depending on our `Kind' instead of throwing an
6684 exception; fixes #71632.
6686 2005-01-26 Marek Safar <marek.safar@seznam.cz>
6689 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
6692 2005-03-17 Martin Baulig <martin@ximian.com>
6694 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
6695 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
6697 2005-03-17 Martin Baulig <martin@ximian.com>
6699 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
6700 to bool so we can return an error condition.
6701 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
6704 2005-03-17 Martin Baulig <martin@ximian.com>
6706 * generic.cs (TypeMananager.IsIEnumerable): New public method.
6708 * convert.cs (Convert.ImplicitReferenceConversion(Exists)): Allow
6709 converting from an array-type of T to `IEnumerable<T>'.
6711 2005-03-16 Martin Baulig <martin@ximian.com>
6713 * generic.cs (Nullable.Unwrap): Implement IAssignMethod.
6714 (Nullable.LiftedUnaryMutator): New public class.
6716 * expression.cs (UnaryMutator.DoResolve): Added support for
6719 2005-03-14 Martin Baulig <martin@ximian.com>
6721 * generic.cs (Nullable.NullCoalescingOperator): Implemented.
6723 2005-03-14 Martin Baulig <martin@ximian.com>
6725 * generic.cs (Nullable.LiftedBinaryOperator): Added support for
6726 the comparision operators `<', `>', `<=' and `>='.
6728 2005-03-13 Martin Baulig <martin@ximian.com>
6731 (Nullable.NullLiteral): Renamed to `Nullable.NullableLiteral' to
6732 avoid confusion with the `NullLiteral'.
6733 (Nullable.LiftedBinaryOperator): Correctly implement `==' and '!='.
6735 2005-03-13 Martin Baulig <martin@ximian.com>
6737 * expression.cs (Binary.ResolveOperator): For `==' and `!=', allow
6738 comparing arbitrary types with the null literal.
6740 2005-03-13 Martin Baulig <martin@ximian.com>
6742 * generic.cs (Nullable.LiftedBinaryOperator): Add support for the
6743 boolean operators '&&', '||', '&' and '|'.
6744 (Nullable.OperatorTrueOrFalse): New public class.
6746 * ecore.cs (Expression.GetOperatorTrue/False): Return an `Expression'
6747 instead of a `StaticCallExpr'; added support for nullables.
6749 2005-03-10 Martin Baulig <martin@ximian.com>
6752 (ArrayAccess.EmitDynamicInitializers): Use `etype.IsValueType'
6753 rather than `etype.IsSubclassOf (TypeManager.value_type)'.
6755 2005-03-07 Martin Baulig <martin@ximian.com>
6757 * generic.cs (Nullable.Unwrap): Implement IMemoryLocation and make
6758 it work if `expr' is not an IMemoryLocation.
6759 (Nullable.Lifted): Implement IMemoryLocation.
6760 (Nullable.LiftedConversion.ResolveUnderlying): Use the correct
6763 2005-03-05 Martin Baulig <martin@ximian.com>
6765 * generic.cs (Nullable.Unwrap, Wrap): New protected classes.
6766 (Nullable.Lifted): New abstract class; rewrote the lifted conversions.
6767 (Nullable): Added support for lifted unary and binary operators.
6769 * expression.cs (Unary.DoResolve): Added support for nullable types.
6770 (Binary.DoResolve): Likewise.
6771 (Conditional.DoResolve): Likewise.
6773 2005-03-02 Martin Baulig <martin@ximian.com>
6775 * decl.cs (DeclSpace.SetParameterInfo): Make this virtual.
6777 * class.cs (ClassPart.SetParameterInfo): Override this.
6778 (PartialContainer.SetParameterInfo): Override this.
6779 (TypeContainer.CheckConstraints): New protected method.
6780 (PartialContainer.CheckConstraints): Override this and check
6781 whether the same contraints were specified in all parts of a
6782 partial generic type definition.
6783 (PartialContainer.UpdateConstraints): New public method.
6785 * generic.cs (TypeParameter.UpdateConstraints): New public method.
6787 2005-03-02 Martin Baulig <martin@ximian.com>
6789 Committing a patch from Carlos Alberto Cortez to fix #72887.
6791 * convert.cs (Convert.ExplicitReferenceConversionExists): Allow
6792 casts from `T []' to `int []'.
6794 2005-03-02 Martin Baulig <martin@ximian.com>
6796 * generic.cs (TypeManager.IsEqual): Make this symmetric.
6798 * expression.cs (Binary.ResolveOperator): When resolving a
6799 BinaryDelegate, use `TypeManager.IsEqual (l, r)' rather than just
6800 `=='. Fixes #71866. See gen-127.cs.
6802 2005-03-02 Martin Baulig <martin@ximian.com>
6804 * class.cs (TypeContainer.DoDefineMembers): We also need a default
6805 static constructor in static classes.
6807 2005-03-02 Martin Baulig <martin@ximian.com>
6810 (NullableType.Name, NullableType.FullName): Add a "?" to the name.
6811 (Nullable.LiftedConversion): Added support for user-defined
6814 * cs-tokenizer.cs (Tokenizer.PutbackCloseParens): New public method.
6816 * cs-parser.jay: Use ComposedCast everywhere instead of
6817 NullableType, so we don't need to check for NullableType
6819 (conditional_expression): Added `INTERR CLOSE_PARENS' rule for the
6820 case where we'll be resolved into a `parenthesized_expression_0'
6824 (Convert.UserDefinedConversion): Added nullable conversions.
6826 2005-02-28 Martin Baulig <martin@ximian.com>
6828 * generic.cs (TypeManager.IsNullableType): New static method.
6829 (Nullable): New abstract class.
6830 (Nullable.NullLiteral): New public class.
6831 (Nullable.LiftedConversion): New public class.
6833 * cs-parser.jay (non_expression_type): Changed `builtin_types' to
6834 `builtin_types opt_nullable'.
6837 (Convert.ImplicitConversionStandard): Added nullable conversions.
6838 (Convert.ExplicitConversionStandard): Likewise.
6839 (Convert.ExplicitConversion): Likewise.
6841 2005-02-26 Martin Baulig <martin@ximian.com>
6843 * expression.cs (ComposedCast.DoResolveAsTypeStep): Allow `dim' to
6844 begin with a "?", for instance "?[]". Don't do a type lookup if
6847 2005-02-25 Martin Baulig <martin@ximian.com>
6849 The first part of Nullable Types :-)
6851 * generic.cs (NullableType): New public class.
6852 (NullCoalescingOperator): New public class.
6853 (TypeArguments.Resolve): Add a CS0306 check.
6855 * cs-parser.jay (opt_error_modifier): Removed, this was unused.
6856 (opt_nullable): New rule.
6857 (type): Added `opt_nullable' to `namespace_or_type_name',
6858 `builtin_types' and `pointer_type'.
6859 (array_type): Added `opt_nullable'.
6860 (opt_rank_specifier_or_nullable): New rule; this is the
6861 combination of `opt_rank_specifier' and `opt_nullable'.
6862 (opt_error): New rule; catch errors here.
6863 (nullable_type_or_conditional): New rule; we use this to check for
6864 nullable and still detect the conditional operator.
6865 (local_variable_type): Use `opt_rank_specifier_or_nullable'
6866 instead `opt_rank_specifier'.
6868 * expression.cs (ComposedCast.DoResolveAsTypeStep): Added support
6871 2005-02-24 Martin Baulig <martin@ximian.com>
6873 * README, README.Changes: Removed; they're old and obsolete.
6875 2005-02-22 Martin Baulig <martin@ximian.com>
6877 * generic.cs (TypeParameter.Resolve): If resolving the constraints
6878 returned an error, set `constraints' to null to avoid a crash
6880 (TypeParameter.ResolveType): Likewise.
6882 2005-02-22 Martin Baulig <martin@ximian.com>
6885 (Constraints.ResolveTypes): Protect against being called twice.
6886 (Constraints.CheckInterfaceMethod): Don't call ResolveTypes().
6887 (TypeParameter.ResolveType): New public method; calls
6888 constraints.ResolveTypes().
6889 (TypeParameter.DefineType): Moved constraints.ResolveType() out
6890 into the new ResolveType().
6891 (GenericMethod.Define): Call ResolveType() on all our
6894 2005-02-21 Martin Baulig <martin@ximian.com>
6897 (TypeManager.generic_nullable_type): New static public field.
6898 (TypeManager.InitGenericCoreType): Lookup "System.Nullable`1".
6901 (RootContext.ResolveCore): Resolve "System.Nullable`1".
6903 2005-02-15 Martin Baulig <martin@ximian.com>
6905 * generic.cs (ConstructedType.Constraints): Correctly check
6906 constraints if the argument type is a type parameter; fixes
6909 2005-02-02 Martin Baulig <martin@ximian.com>
6911 * delegate.cs (Delegate.DefineType): Report an internal error if
6912 TypeManager.multicast_delegate_type is null. See bug #72015 for
6915 2005-01-29 Miguel de Icaza <miguel@novell.com>
6917 * pending.cs: Produce better code (no nops produced by using Ldarg
6920 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
6921 i - 1' it should be arg + 1.
6925 2005-01-26 Martin Baulig <martin@ximian.com>
6927 * cs-parser.jay (indexer_declarator): Don't report an error if we
6928 have type parameters since we can be an explicit interface
6929 implementation; fixes #71449.
6931 2005-01-26 Martin Baulig <martin@ximian.com>
6933 * class.cs (TypeContainer.AttributeTargets): Return the correct
6934 AttributeTargets depending on our `Kind' instead of throwing an
6935 exception; fixes #71632.
6937 2005-01-26 Martin Baulig <martin@ximian.com>
6939 * delegate.cs (Delegate.DefineType): Correctly define our type
6940 parameters. Fixes #71483.
6942 2005-01-25 Raja R Harinath <rharinath@novell.com>
6945 * expression.cs (MemberAccess.DoResolve): Don't complain with
6946 cs0572 when the LHS of a member access has identical name and type
6949 2005-01-25 Marek Safar <marek.safar@seznam.cz>
6952 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
6954 Create custom PermissionSet only for PermissionSetAttribute.
6956 2005-01-24 Marek Safar <marek.safar@seznam.cz>
6959 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
6960 delegates in static class.
6962 2005-01-24 Martin Baulig <martin@ximian.com>
6964 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
6965 merging an implicit block, just use its reachability.
6967 * statement.cs (Block.Resolve): Make the unreachable code check
6968 work wrt. implicit blocks; see test-337 from #63842.
6970 2005-01-21 Alp Toker <alp@atoker.com>
6972 * cs-parser.jay: destructor_declaration's container is PartialContainer
6973 not Class when partial types are used, so use Kind prop instead of
6976 2005-01-22 Miguel de Icaza <miguel@ximian.com>
6978 * cs-parser.jay: Improve error reporting when an interface
6981 2005-01-20 Dick Porter <dick@ximian.com>
6983 * support.cs: SeekableStreamReader fix from Sandor Dobos
6984 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
6985 chars are read. Fixes bug 70369.
6987 2005-01-20 Raja R Harinath <rharinath@novell.com>
6989 * cs-parser.jay (catch_clause): Simplify current_block handling
6992 2005-01-17 Miguel de Icaza <miguel@ximian.com>
6994 * convert.cs (ImplicitStandardConversionExists): Synchronize the
6995 code with ImplicitStandardConversion to handle the implicit
6996 conversion of method groups into valid delegate invocations.
6998 The problem is that in parameter handling we were using this code
6999 path. Fixes bug #64698
7001 2005-01-19 Raja R Harinath <rharinath@novell.com>
7003 * cs-parser.jay: Fix several infelicities.
7004 - Avoid assigning to the parser value stack. Code like
7005 '$3 = null' is unclean. Synthesize a value for the code block
7007 - Avoid using oob_stack for storing location information. Use ...
7008 (_mark_): ... this. New (empty) rule. Saves the current location
7010 (foreach_statement): Avoid using oob_stack for current_block
7011 handling. Use technique used in for_statement and
7012 using_statement. Synthesize a value for the code block to store
7013 additional intermediate information.
7015 2005-01-13 Miguel de Icaza <miguel@ximian.com>
7017 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
7018 of a different type is only allowed to private fields of a
7019 containing type, not on fields of a base class.
7021 See test-174.cs and error cs0122-9.cs
7023 2005-01-13 Raja R Harinath <rharinath@novell.com>
7025 Fix test-335.cs (bug #58126).
7026 * cs-parser.jay (argument): Split out non-expression parts of the
7027 rule into 'non_simple_argument'.
7028 (invocation_expression): Support parenthesized invocations with
7029 multiple arguments, and with single non-simple arguments.
7031 2005-01-13 Raja R Harinath <rharinath@novell.com>
7033 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
7036 2005-01-12 Raja R Harinath <rharinath@novell.com>
7038 Fix cs0038-1.cs, cs1640-6.cs.
7039 * ecore.cs (Expression.Resolve): Remove special-case for
7040 SimpleName in error-handling.
7041 (Expression.almostMatchedMembers): Relax access permission to
7043 (Expression.MemberLookupFailed): Handle duplicates in
7044 almostMatchedMembers list.
7045 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
7046 * expression.cs (New.DoResolve): Report CS1540 for more cases.
7047 * typemanager.cs (GetFullNameSignature): Use the MethodBase
7048 overload if the passed in MemberInfo is a MethodBase.
7050 2005-01-25 Martin Baulig <martin@ximian.com>
7053 (DocUtil.emptyParamList): Removed; use `Type.EmptyTypes' instead.
7055 2005-01-12 Marek Safar <marek.safar@seznam.cz>
7058 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
7059 for non-CAS & merge permission sets properly.
7061 2005-01-11 Raja R Harinath <rharinath@novell.com>
7063 Improve standard-compliance of simple name and member access
7064 resolution. Fixes bugs #52697, #57200, #67520, #69519.
7065 * ecore.cs (FullNamedExpression): New abstract base class
7066 for Namespaces and TypeExpressions.
7067 (ResolveFlags.SimpleName): Remove.
7068 (SimpleName): Remove support for dotted names.
7069 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
7070 DeclSpace.FindType and DeclSpace.LookupType.
7071 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
7072 (Expression.ExprClassName): Make member function.
7073 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
7074 a namespace. Remove creation of dotted "SimpleName"s.
7075 (MemberAccess.DoResolve): Likewise.
7076 * decl.cs (DeclSpace.Cache): Make private.
7077 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
7078 (DeclSpace.FindType): Update.
7079 (DeclSpace.LookupType): Move here from RootContext. Return a
7080 FullNamedExpression.
7081 * namespace.cs (Namespace): Derive from FullNamedExpression
7082 so that it can be part of expression resolution.
7083 (Namespace.Lookup): Return an FullNamedExpression.
7084 (NamespaceEntry.LookupAlias): Lookup aliases only in current
7086 * rootcontext.cs (NamespaceLookup): Remove.
7087 (LookupType): Move to DeclSpace.
7088 * attribute.cs (CheckAttributeType): Update.
7089 * doc.cs (FindDocumentedType): Remove allowAlias argument.
7090 (FindDocumentedTypeNonArray): Likewise.
7092 2005-01-11 Raja R Harinath <rharinath@novell.com>
7094 Fix cs0509.cs, cs1632.cs.
7095 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
7096 is the same as IsInterface.
7097 (TypeContainer.GetClassBases): Likewise.
7098 * statement.cs (LabeledStatement.ig): New field.
7099 (LabeledStatement.LabelTarget): Save ILGenerator which created the
7101 (LabeledStatement.DoEmit): Check that the label was created with
7102 the same ILGenerator.
7104 2005-01-10 Marek Safar <marek.safar@seznam.cz>
7107 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
7108 accessors to its properties.
7110 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
7111 from accessors to property.
7113 2005-01-10 Marek Safar <marek.safar@seznam.cz>
7116 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
7119 2005-01-08 Miguel de Icaza <miguel@ximian.com>
7121 * attribute.cs: Check for null and empty strings.
7123 I have lost another battle to Paolo.
7125 2005-01-07 Marek Safar <marek.safar@seznam.cz>
7128 * class.cs (PropertyMethod): Set Parent field in ctors.
7129 (SetMethod.InternalParameters): Add unsafe switch hack.
7130 Override MarkForDuplicationCheck where it is appropriate.
7132 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
7133 It says whether container allows members with the same name.
7135 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
7136 Removed is_method parameter.
7138 2005-01-06 Duncan Mak <duncan@ximian.com>
7140 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
7141 because the previous change led to incorrect reporting of CS1032
7142 ("Cannot define/undefine preprocessor symbols after first token in
7143 file"). Instead of using `tokens_seen' as the only flag that
7144 triggers CS1040, introduce `comments_seen'. This new flag is used
7145 to signify having seen comments on the current line, so it is
7146 unset after a newline.
7148 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
7150 * doc.cs : When searching for a type, find nested type too.
7151 This fixes bug #71040.
7153 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
7156 - Warn missing member comment on those classes which also does not
7157 have doc comments. Fixed bug #71041.
7158 - Don't warn missing doc comment on default constructor.
7161 2005-01-06 Duncan Mak <duncan@ximian.com>
7163 * cs-tokenizer.cs (xtoken): After handling traditional C-style
7164 comments, set `tokens_seen' to true. This allows us to detect
7165 misplaced preprocessor directives (i.e. not at the beginning of
7166 the a line, nor after whitespaces). In that case, report error
7167 CS1040. This fixes bug #56460.
7169 * cs-parser.jay (interface_member_declaration): Add checks for
7170 IsExplicitImpl, and report CS0541 error if an interface member is
7171 defined as an explicit interface declaration.
7173 2005-01-06 Marek Safar <marek.safar@seznam.cz>
7176 * class.cs (PropertyMethod): Set Parent field in ctors.
7177 (SetMethod.InternalParameters): Add unsafe switch hack.
7179 * decl.cs (MemberCore.Parent): Cannot be readonly.
7181 2005-01-06 Raja R Harinath <rharinath@novell.com>
7183 * decl.cs (DeclSpace.ResolveType): Remove.
7184 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
7185 Merge in code from ...
7186 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
7187 * class.cs, enum.cs: Update to changes.
7189 2005-01-06 Miguel de Icaza <miguel@ximian.com>
7191 * anonymous.cs: Ensure that we init the scope of our parent if it
7192 has not been initialized yet.
7194 2004-12-30 Duncan Mak <duncan@ximian.com>
7196 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
7197 if field.FieldBuilder is null. Fixes #70758.
7199 * convert.cs: Fixed some typos and updated some of the comments.
7200 (ImplicitStandardConversionExists):
7201 (TryImplicitIntConversion): If `target_type' is an interface and
7202 the type of `ic' implements this interface, return true or a new
7203 BoxedCast instead of null. This fixes #70468.
7205 2004-12-29 Duncan Mak <duncan@ximian.com>
7207 * expression.cs (Argument.Emit): Check that Expr is
7208 IMemoryLocation before casting to it, and report CS1510 otherwise.
7212 2004-12-21 Ben Maurer <bmaurer@ximian.com>
7214 * statement.cs (Block.ThisVariable): remove the recursion here, to
7215 make the --profile more sane.
7217 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
7219 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
7220 assembly, by JB Evain.
7222 2004-12-17 Raja R Harinath <rharinath@novell.com>
7224 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
7225 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
7226 "parent" refers to enclosing type/class. "base" refers to superclass.
7228 2004-12-17 Raja R Harinath <rharinath@novell.com>
7230 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
7231 Ensure that we only have GlobalAttributes.
7232 * attribute.cs (Attribute.Emit): Make non-virtual.
7233 (GlobalAttribute.Emit): Remove.
7234 (Attribute.Resolve): Make virtual.
7235 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
7236 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
7237 the argument. Don't create one.
7238 (Attribute.GetObsoleteAttribute): Likewise.
7239 (Attribute.GetClsCompliantAttributeValue): Likewise.
7240 * class.cs, decl.cs: Update to changes.
7242 2004-12-17 Marek Safar <marek.safar@seznam.cz>
7244 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
7246 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
7248 * statement.cs (Foreach.Resolve): Add error 186 report.
7250 2004-12-16 Marek Safar <marek.safar@seznam.cz>
7252 * expression.cs (Conditional.DoResolve): Add warning 429.
7254 * statement.cs (If.Resolve): Add warning 665.
7256 2004-12-16 Raja R Harinath <rharinath@novell.com>
7258 New invariant: RootContext.Tree.Types.NamespaceEntry == null
7259 except when in the parser, and in GlobalAttribute.
7260 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
7261 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
7262 RootContext.Tree.Types.NamespaceEntry once work is done.
7263 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
7264 and resets RootContext.Tree.Types.NamespaceEntry.
7266 2004-12-15 Marek Safar <marek.safar@seznam.cz>
7268 * cs-parser.jay: Don't create a block for every variable.
7270 2004-12-14 Miguel de Icaza <miguel@ximian.com>
7272 * location.cs: Provide extra information.
7274 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
7275 variables from the captured environment, it is the ldarg_0.
7277 2004-12-14 Marek Safar <marek.safar@seznam.cz>
7279 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
7282 * class.cs: Changed warning level for 169 to avoid developer
7283 displeasure from warning flooding. It will be changed back when they
7284 fix most of current BCL warnings.
7286 * RootContext.cs: Pushed default WarningLevel to 3.
7288 * statement.cs: Removed unused variable.
7290 2004-12-14 Marek Safar <marek.safar@seznam.cz>
7292 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
7293 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
7294 Add error 502 report.
7295 (StaticClass.DefineType): Add error 441 report.
7296 (Class.AllowedModifiersProp): New virtual property as temporary
7297 extension to AllowedModifiers.
7298 (Class.DefineType): Add error 418 report. Moved ModFlags check here
7299 to share implementation with StaticClass and don't call virtual
7302 * driver.cs (MainDriver): Add error 1558 test.
7304 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
7305 report. Moved error 36 test here.
7307 * statement.cs (Throw.Resolve): Add error 724 report.
7309 * typemanager.cs: Add out_attribute_type core type.
7311 2004-12-13 Marek Safar <marek.safar@seznam.cz>
7313 * class.cs (TypeContainer.VerifyClsCompliance): Add error
7315 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
7317 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
7320 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
7322 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
7323 Add error 3023 report.
7324 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
7326 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
7329 2004-12-12 John Luke <john.luke@gmail.com>
7331 * driver.cs (AddArgs): take -- into account when
7332 adding arguments, fixes bug 65710
7334 2004-12-12 Martin Baulig <martin@ximian.com>
7336 * expression.cs (Unary.TryReduceNegative): Added support for
7337 SByteConstant and ByteConstant.
7338 (Unary.Reduce): Check error values from TryReduceNegative().
7340 2004-12-10 Marek Safar <marek.safar@seznam.cz>
7342 * attributes.cs (Attribute.Resolve): Avoid multiple error report
7343 and report exception as error 182.
7345 2004-12-10 Raja R Harinath <rharinath@novell.com>
7347 * driver.cs (Main): Fix message when there are warnings.
7349 2004-12-09 Miguel de Icaza <miguel@ximian.com>
7351 * delegate.cs: Fixed my fix from yesterday, sorry about that.
7353 2004-12-09 Marek Safar <marek.safar@seznam.cz>
7355 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
7356 Reduced number of warnings.
7358 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
7360 2004-12-08 Miguel de Icaza <miguel@ximian.com>
7362 * driver.cs: Removed message.
7364 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
7366 2004-12-08 <vargaz@freemail.hu>
7368 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
7370 2004-12-08 Martin Baulig <martin@ximian.com>
7372 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
7373 instead of a CS3002 for properties and indexer.
7375 2004-12-08 Martin Baulig <martin@ximian.com>
7377 * decl.cs (MemberName.ToString): Make this work again.
7379 2004-12-08 Marek Safar <marek.safar@seznam.cz>
7381 * attribute.cs (Resolve): Add error 591 detection.
7383 * class.cs (FieldMember.Define): Add error 1547 detection.
7384 (Indexer.Define): Add error 620 detection.
7385 (Operator.Define): Add error 590 detection.
7387 * ecore.cs: Missing argument for error 79.
7389 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
7392 2004-12-07 Marek Safar <marek.safar@seznam.cz>
7395 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
7398 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
7400 * cs-parser.jay : handle doc comments on implicit/explicit operators.
7401 Some operator comments were suppressed.
7402 * doc.cs : Implicit/explicit operator name in doc comments are like
7403 "op_Explicit(type)~returnType", so added suffix handling.
7405 2005-01-21 Alp Toker <alp@atoker.com>
7407 * cs-parser.jay: destructor_declaration's container is PartialContainer
7408 not Class when partial types are used, so use Kind prop instead of 'is'.
7410 2004-12-12 Martin Baulig <martin@ximian.com>
7412 * expression.cs (Unary.TryReduceNegative): Added support for
7413 SByteConstant and ByteConstant.
7414 (Unary.Reduce): Check error values from TryReduceNegative().
7416 2004-12-11 Martin Baulig <martin@ximian.com>
7418 * support.cs (ReflectionParameters.ParameterName): If we have a
7419 `gpd', call `ParameterName' on it.
7421 * parameter.cs (Parameter.GetParameterAttributes): New static method.
7423 * pending.cs (PendingImplementation.DefineProxy): Call
7424 DefineParameter() for all of the MethodBuilder's arguments.
7426 2004-12-09 Martin Baulig <martin@ximian.com>
7428 * doc.cs (DocUtil): Make this a static class.
7430 2004-12-09 Martin Baulig <martin@ximian.com>
7432 * expression.cs (Invocation.InferType): Moved the type inference
7433 implementation into TypeManager.
7435 * generics.cs (TypeManager): Moved the type inference
7436 implementation here.
7438 2004-12-09 Martin Baulig <martin@ximian.com>
7440 * typemanager.cs (TypeManager): Make this a partial class.
7443 (TypeManager): Move the generics part of `TypeManager' here.
7445 2004-12-08 Martin Baulig <martin@ximian.com>
7447 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
7448 instead of a CS3002 for properties and indexer. Added CS3024
7449 check for generic interfaces.
7451 * attributes.cs (AttributeTester.AnalyzeTypeCompliance): Generic
7452 instances are not CLS-compliant.
7454 2004-12-08 Martin Baulig <martin@ximian.com>
7457 (void_pointer_expression): New rule for `void*', `void**' etc.
7458 (typeof_expression): Add `void_pointer_expression'; fixes #66846.
7460 2004-12-08 Martin Baulig <martin@ximian.com>
7462 * expression.cs (Invocation.InferType): Removed the hack for
7463 MethodCore.MayUnify().
7465 * typemanager.cs (TypeManager.MayBecomeEqualGenericTypes): Make
7468 * class.cs (MethodCore.MayUnify): Use
7469 TypeManager.MayBecomeEqualGenericTypes().
7471 2004-12-08 Martin Baulig <martin@ximian.com>
7473 * expression.cs (Is.DoResolve, As.DoResolve): If we're a type
7474 parameter, box it. Fixes #69233.
7476 2004-12-08 Martin Baulig <martin@ximian.com>
7478 * generic.cs (ConstructedType.CheckConstraints): Valuetypes always
7479 have the ctor constraint. Fixes #68326.
7481 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
7483 * cs-parser.jay : interface comment was not consumed because of
7484 extra opt_semicolon before doc handling.
7486 2004-12-03 Raja R Harinath <rharinath@novell.com>
7488 Fix test-327.cs, test-328.cs, and put in early infrastructure
7489 for eventually fixing #52697.
7490 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
7491 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
7493 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
7494 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
7495 (VerifyUsing, error246): Update.
7496 * rootcontext.cs (RootContext.NamespaceLookup): Just use
7497 'NamespaceEntry.LookupNamespaceOrType'.
7499 2004-12-07 Martin Baulig <martin@ximian.com>
7501 * driver.cs: Call it "BETA SOFTWARE" :-)
7503 2004-12-06 Raja R Harinath <rharinath@novell.com>
7505 Fix crash on cs0657-17.cs.
7506 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
7507 Use RootContext.Tree.Types, not 'new RootTypes ()'.
7508 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
7509 the case where the NamespaceEntry gets overwritten.
7511 2004-12-06 Marek Safar <marek.safar@seznam.cz>
7513 Fixed #69195, #56821
7514 * ecore.cs (ResolveBoolean): Tiny refactoring.
7516 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
7517 of right expression resolving when left is false constant and
7518 operator is LogicalAnd OR true constant and operator is LogicalOr.
7520 * statement.cs (ResolveUnreachable): Always reports warning.
7522 2004-12-05 Miguel de Icaza <miguel@ximian.com>
7524 * class.cs: Distinguish between 1721 and 1722 (just a little help
7525 for the programmer).
7527 2004-12-03 Miguel de Icaza <miguel@ximian.com>
7529 * delegate.cs: Only allow this on new versions of the language.
7531 2004-12-02 Duncan Mak <duncan@ximian.com>
7533 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
7535 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
7536 here as a static method. Take an additional bool out parameter
7537 `must_do_cs1540_check' for signaling to InstanceResolve.
7538 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
7539 member field from PropertyExpr class and made it an argument of
7541 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
7542 check for MarshalByRefObject, and report CS0122 instead of CS1540.
7543 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
7544 and `remove_accessor' as well as InstanceResolve: report CS0122
7549 2004-12-07 Martin Baulig <martin@ximian.com>
7551 * decl.cs (DeclSpace.AddToContainer): Report correct errors CS0694
7552 and CS0692 where appropriate.
7554 2004-12-06 Martin Baulig <martin@ximian.com>
7556 * class.cs (MethodCore.MayUnify): Moved the CS0408 check here from
7557 IsDuplicateImplementation() and improved it.
7559 * expression.cs (Invocation.InferTypeArguments): Added
7560 `Type[] inferred_class_types' argument (for MethodCore.MayUnify)
7561 and removed the "ref" modifier from `infered_types'.
7563 * decl.cs (MemberName.ToString): Removed the exception.
7565 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
7567 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
7568 comments are allowed.
7570 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
7572 * delegate.cs: Add checks for subtypes in paramaters and return values
7573 in VerifyMethod () to add support for Covariance/Contravariance
7576 2004-12-02 Miguel de Icaza <miguel@ximian.com>
7578 * report.cs: Remove extra closing parenthesis.
7580 * convert.cs (Error_CannotImplicitConversion): If the name of the
7581 types are the same, provide some extra information.
7583 2004-12-02 Marek Safar <marek.safar@seznam.cz>
7586 * attribute.cs (Resolve): Improved implementation of params
7587 attribute arguments.
7589 * support.cs (ParameterData): Add HasParams to be faster.
7591 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
7593 all things are for /doc support:
7595 * doc.cs: new file that supports XML documentation generation.
7596 * mcs.exe.sources: added doc.cs.
7598 Handle /doc command line option.
7599 Report error 2006 instead of 5 for missing file name for /doc.
7600 Generate XML documentation when required, after type resolution.
7602 Added support for picking up documentation (/// and /** ... */),
7603 including a new XmlCommentState enumeration.
7605 Added lines to fill Documentation element for field, constant,
7606 property, indexer, method, constructor, destructor, operator, event
7607 and class, struct, interface, delegate, enum.
7608 Added lines to warn incorrect comment.
7610 Added Documentation field (passed only when /doc was specified).
7612 Added DocComment, DocCommentHeader, GenerateDocComment() and
7613 OnGenerateDocComment() and some supporting private members for
7614 /doc feature to MemberCore.
7616 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
7618 Added overriden DocCommentHeader.
7620 Added overriden DocCommentHeader and GenerateDocComment().
7622 2004-12-01 Miguel de Icaza <miguel@ximian.com>
7624 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
7625 unwrapping the enumeration values, chain to
7626 DoConstantNumericPromotions again, so we can promote things to the
7627 fundamental types (takes care of enums that are bytes, sbytes).
7631 2004-12-01 Raja R Harinath <rharinath@novell.com>
7633 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
7634 Fix long-standing bug in type-lookup. Use FindType instead of
7635 LookupType when ec.ResolvingTypeTree.
7636 (Attribute.ResolveType, Attribute.Resolve)
7637 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
7639 (Attributes.Search): Remove internal version. Update.
7640 (Attributes.SearchMulti): Update.
7641 (Attributes.GetClsCompliantAttribute): Remove.
7642 (Attributes.GetIndexerNameAttribute): Remove.
7643 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
7644 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
7645 * class.cs (Indexer.Define): Likewise.
7647 2004-12-01 Marek Safar <marek.safar@seznam.cz>
7650 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
7651 MarshallByReference members access.
7653 * expression.cs: Use CheckMarshallByRefAccess;
7654 Better error CS0197 message.
7656 * report.cs: Print whole related error message.
7658 2004-11-29 Marek Safar <marek.safar@seznam.cz>
7660 * class (GetClassBases): Better error 60 report.
7661 (EventProperty): Disabled warning 67 detection.
7663 2004-11-29 Marek Safar <marek.safar@seznam.cz>
7666 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
7668 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
7671 2004-11-29 Marek Safar <marek.safar@seznam.cz>
7674 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
7676 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
7678 2004-11-26 Miguel de Icaza <miguel@ximian.com>
7680 * attribute.cs (Attribute.Resolve): Refine error reporting and
7681 report a cs0117 if the identifier does not exist, to distinguish
7682 from 0617 which is a miss-use of the actual identifier.
7684 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
7685 between cs0070 and cs0079.
7687 * class.cs (MemberBase.DoDefine): When reporting a wrong
7688 accessibility level, we use MethodCore to compare instead of
7689 Method (this was a regression in some refactoring effort).
7691 So now we correctly report cs0056 again.
7693 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
7694 testing the target_type (which was known to be object_type) and
7695 not the source type (which is anonymous_method).
7697 Fixed reporting of error cs1660.
7699 * expression.cs (UserCast.Source): Expose the underlying cast.
7701 * statement.cs (Switch.SwitchGoverningType): Sort the list of
7702 allowed types to find a match to int32 first (most common).
7704 In addition, it ignores any ImplicitUserConversions that did an
7705 internal implicit conversion (as the switch statement allows only
7706 one integral conversion to exist).
7708 * class.cs (PartialContainer.Create): rename `name' to
7709 `member_name' for clarity. Then replace the string calls with a
7710 call to MemberName.GetPartialName, as now using
7711 MemberName.ToString is an error (this is due to the side effects
7712 it had, that were fixed in the past).
7714 This will restore the error reporting on a number of partial class
7715 errors that were missusing this (and getting an exception as a
7716 results, which is now just a plain textual warning, because
7717 yyparse debug output would crash otherwise).
7719 2004-11-26 Raja R Harinath <rharinath@novell.com>
7721 * Makefile (PROGRAM_INSTALL_DIR): Remove.
7723 2004-11-25 Ben Maurer <bmaurer@ximian.com>
7725 * rootcontext.cs (LookupType): Make sure to cache lookups that
7726 don't give us a negative result. This saves about 5% of corlib
7729 2004-11-25 Miguel de Icaza <miguel@ximian.com>
7731 * report.cs (AbstractMessage.Print): messages are sent to stderr
7733 * class.cs (TypeContainer.GetClassBases): It is an error to have a
7734 non-interface in the list of interfaces (at this point, either
7735 parent was properly set, or a base class is being listed in the
7736 interfaces section).
7738 This flags error 1722, and resolves the crash from bug 69259.
7740 2004-11-25 Ben Maurer <bmaurer@ximian.com>
7742 * statement.cs (Using.EmitExpressionFinally): make this work right
7743 for valuetypes. Fixes 69926.
7745 2004-11-25 Miguel de Icaza <miguel@ximian.com>
7747 * const.cs (Const.ChangeType): Cope with the "0 literal can be
7748 converted to an enum" here, before we try to change the underlying
7749 type. This code exists, but it is a different code path than the
7750 one used while encoding constants.
7752 (ImplicitReferenceConversionExists): In addition, resynchronized
7753 the code here, so it matches the same code in
7754 ImplicitReferenceConversionExists for the `from any class-type S
7755 to any interface-type T'.
7757 2004-11-25 Marek Safar <marek.safar@seznam.cz>
7759 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
7761 2004-11-24 Miguel de Icaza <miguel@ximian.com>
7763 * cs-parser.jay: Use verbosity accordingly.
7765 2004-11-24 Marek Safar <marek.safar@seznam.cz>
7767 * expression.cs (Unary.ResolveOperator): Do not report warning;
7768 AddressOf reads from variable.
7770 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
7772 2004-11-24 Marek Safar <marek.safar@seznam.cz>
7776 * attribute.cs (Attributable): Removed CheckTargets.
7777 (Attributes.Emit): Explicit attribute targets are tested here.
7779 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
7780 not enabled for interfaces.
7782 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
7783 (GetAssemblyName): Ouch next bug there.
7785 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
7787 * expression.cs: Error 275 added.
7789 2004-11-23 Marek Safar <marek.safar@seznam.cz>
7791 Fix bug #69177 (Implemented decimal constant support)
7793 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
7794 (BinaryFold): Add DecimalConstant.
7796 * const.cs (Define): Decimal constant
7798 (ChangeType): Add decimal type handling.
7799 (LookupConstantValue): Don't set value for decimal type but
7800 emit DecimalConstantAttribute. Needed for constant optimization.
7802 * constant.cs (ToDecimal): New method.
7803 (ConvertToDecimal): New method.
7804 (IntConstant): Implemented ConvertToDecimal.
7805 (DecimalConstant.Emit): Emit optimized version for decimals in
7808 * expression.cs (ResolveOperator): Changed order of constant
7809 reduction to work correctly with native types which have
7810 overloaded operators.
7811 (ResolveMemberAccess): Extract constant value from attribute
7814 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
7816 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
7817 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
7818 (ChangeType): Decimal is special.
7819 (TypeToCoreType): Add decimal type.
7821 2004-11-22 Marek Safar <marek.safar@seznam.cz>
7823 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
7826 2004-11-22 Marek Safar <marek.safar@seznam.cz>
7828 * class.cs (EventField.ApplyAttributeBuilder): Fix error
7831 2004-11-19 Marek Safar <marek.safar@seznam.cz>
7833 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
7835 * pending.cs (PendingImplementation): Grab only interfaces.
7837 2004-11-19 Marek Safar <marek.safar@seznam.cz>
7839 * statement.cs (ForeachHelperMethods): Add location member and
7840 error 202 detection.
7842 2004-11-18 Marek Safar <marek.safar@seznam.cz>
7844 * expression.cs (DoResolveBase): Fixed wrong warning for out
7847 2004-12-04 Martin Baulig <martin@ximian.com>
7849 * convert.cs (Convert.TypeParameter_to_Null): Use the constraints
7850 to check whether the conversion is ok.
7852 * typemanager.cs (TypeManager.GetTypeArguments): Just return
7853 `Type.EmptyTypes' if we're not a generic TypeContainer.
7855 2004-11-25 Miguel de Icaza <miguel@ximian.com>
7857 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
7858 old bug: when converting from the null literal to a pointer,
7859 return an EmptyCast, not the NullLiteral.
7861 This fixes #69921, the recent null_type changes probably made this
7864 2004-12-03 Martin Baulig <martin@ximian.com>
7866 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
7867 method as our child, call AnonymousMethod.Compatible() on it.
7869 2004-12-02 Miguel de Icaza <miguel@ximian.com>
7871 * class.cs (FieldBase): Use an unused bit field from the field to
7872 encode the `has_offset' property from the FieldMember. This saves
7873 a couple of Ks on bootstrap compilation.
7875 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
7876 method as our child, return the AnonymousMethod resolved
7879 * expression.cs (New.DoResolve): Allow return values from
7880 NewDelegate to also include AnonymousMethods.
7884 2004-11-29 Raja R Harinath <rharinath@novell.com>
7886 * decl.cs (MemberCore.MemberName): Remove readonly to fix an error
7888 * rootcontext.cs (ResolveCore::interfaces_first_stage): Add
7889 System.Runtime.InteropServices._Exception, since it's a base
7890 interface of the core type System.Exception in the net_2_0 profile.
7892 2004-11-27 Martin Baulig <martin@ximian.com>
7894 * ecore.cs (Expression.StoreFromPtr): Use `stobj' for generic parameters.
7896 2004-11-26 Raja R Harinath <rharinath@novell.com>
7898 * Makefile: Convert to use executable.make.
7899 * gmcs.exe.sources: New.
7901 2004-11-25 Martin Baulig <martin@ximian.com>
7903 * expression.cs (Invocation.InferType): Added support for byref types.
7905 2004-11-25 Martin Baulig <martin@ximian.com>
7907 * statement.cs (Foreach.FetchMethodMoveNext): Wrap `mi.ReturnType'
7908 in TypeManager.TypeToCoreType().
7910 2004-11-25 Martin Baulig <martin@ximian.com>
7912 * iterators.cs (Iterator.DoDefineMembers): Override and lookup the
7913 "Dispose" method from the `current_type'.
7914 (Iterator.EmitMoveNext): Use the `dispose_method' we looked up in
7915 DoDefineMembers() instead of using the MethodBuilder; this is
7916 required for generic iterators.
7918 * class.cs (TypeContainer.DoDefineMembers): Make this virtual.
7920 2004-11-24 Martin Baulig <martin@ximian.com>
7922 * ecore.cs (Expression.LoadFromPtr): Use `ldobj' for generic parameters.
7924 2004-11-20 Martin Baulig <martin@ximian.com>
7926 * expression.cs (Invocation.InferType): Correctly infer generic
7927 instances; see gen-103.cs.
7928 (Invocation.InferTypeArguments): If a generic method doesn't have
7929 any unbound type parameters, we don't need to infer anything.
7931 2004-11-19 Raja R Harinath <rharinath@novell.com>
7933 * Makefile (gmcs.exe): Update to new location of bootstrap mcs.exe.
7935 2004-11-17 Raja R Harinath <rharinath@novell.com>
7937 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
7938 (TypeHandle.GetMemberCache): New.
7939 (TypeHandle.TypeHandle): Update.
7940 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
7941 (TypeManager.LookupParentInterfacesCache):
7942 Rename from LookupInterfaceCache. Optimize slightly.
7943 (TypeManager.MemberLookup_FindMembers): Update.
7944 * decl.cs (MemberCache.MemberCache): Set Container to null in the
7946 (AddCacheContents): Rename from AddHashtable.
7947 * class.cs (TypeContainer.parent_container): Remove.
7948 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
7949 (TypeContainer.DoDefineMembers): Don't initialize it.
7950 Update to name changes.
7952 2004-11-17 Miguel de Icaza <miguel@ximian.com>
7954 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
7955 that factors the code to check access modifiers on override.
7957 (PropertyBase): Use the code here.
7959 Patch from Lluis S'anchez, fixes bug #69361.
7961 2004-11-15 Miguel de Icaza <miguel@ximian.com>
7963 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
7964 routine that is used to report the use of a captured variable
7965 whose address has been taken.
7967 There are two checks: one when variables are being captured and
7968 the other check is when the address of a variable is taken.
7970 (because an anonymous methods might be resolved before *or* after
7971 the address has been taken) and
7973 * expression.cs (Conditional.DoResolve): Remove the special
7974 casing that Martin added to trueExpr and falseExpr being both
7975 NullLiteral. We get the right behavior now just by introducing
7976 the null_type into the compiler.
7978 * convert.cs (ExplicitConversion): Change the code to use
7979 null_type instead of testing `expr is NullLiteral'.
7980 (ImplicitConversionStandard): use null_type too.
7981 (ImplicitReferenceConversionExists): use null_type too.
7982 (ImplicitReferenceConversion): use null_type too.
7984 * literal.cs: The type of `NullLiteral' is now null_type instead
7986 (Resolve): Set the type here.
7988 * typemanager.cs: Introduce null_type.
7990 2004-11-18 Martin Baulig <martin@ximian.com>
7993 (RootContext.LookupType): Return a `Type', not a `TypeExpr'.
7995 2004-11-18 Martin Baulig <martin@ximian.com>
7997 * ecore.cs (TypeExpr.DoResolveAsTypeStep): Make this protected.
7999 2004-11-18 Martin Baulig <martin@ximian.com>
8001 * generic.cs (Constraints.Resolve): Take an `EmitContext' instead
8002 of a `DeclSpace'. If one of our constraints is a `ConstructedType',
8003 call ResolveConstructedType() on it to resolve it without checking
8005 (Constraints.ResolveTypes): Check them here.
8006 (ConstructedType.DoResolveAsTypeStep): Fully resolve ourselves,
8007 but don't check constraints.
8008 (ConstructedType.ResolveAsTypeTerminal): Override this and also
8009 check constraints here.
8010 (ConstructedType.ResolveConstructedType): New public method. This
8011 is called from DoResolveAsTypeStep() and Constraints.Resolve() to
8012 resolve ourselves without checking constraints.
8014 * ecore.cs (Expression.ResolveAsTypeTerminal): Make this virtual.
8016 2004-11-18 Martin Baulig <martin@ximian.com>
8019 (DeclSpace.CurrentType): Changed type from `TypeExpr' to `Type'.
8021 * delegate.cs (Delegate.DefineType): Always create the EmitContext.
8023 2004-11-18 Martin Baulig <martin@ximian.com>
8025 * ecore.cs (TypeExpr.ResolveType): Removed.
8026 (Expression.ResolveAsTypeTerminal): We always return a fully
8027 resolved `TypeExpr', so we can just access its `Type'.
8029 * class.cs (TypeContainer.DefineType): Resolve `CurrentType' here.
8031 2004-11-17 Martin Baulig <martin@ximian.com>
8033 * ecore.cs (IAlias.Type): Replaced with ResolveAsType() to make
8034 sure we don't return any unresolved TypeExpr's.
8035 (TypeAliasExpression): The .ctor now takes an `IAlias' instead of
8037 (Expression.ResolveAsTypeTerminal): Make sure `te.Type != null'.
8039 * expression.cs (MemberAccess.ResolveAsTypeStep): Don't return any
8040 unresolved `ConstructedType's.
8042 2004-11-17 Martin Baulig <martin@ximian.com>
8044 * ecore.cs (TypeExpr.ResolveType): Don't make this virtual.
8046 2004-11-17 Martin Baulig <martin@ximian.com>
8049 (Expression.ResolveAsTypeTerminal): Removed the `bool silent' argument.
8051 * decl.cs (DeclSpace.ResolveType): Removed.
8052 (DeclSpace.ResolveTypeExpr): Removed the `bool silent' argument.
8054 2004-11-17 Martin Baulig <martin@ximian.com>
8056 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
8057 direction, like FindMembers() does. Fixes #69546, testcase is in
8060 2004-11-16 Martin Baulig <martin@ximian.com>
8062 This is based on a patch from Marek Safar, see bug #69082.
8063 Fixes bugs #63705 and #67130.
8065 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
8066 method; create a MemberCache for an interface type and cache the
8069 * decl.cs (IMemberContainer.ParentContainer): Removed.
8070 (IMemberContainer.ParentCache): New property.
8071 (MemberCache.SetupCacheForInterface): Removed.
8072 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
8073 to create a cache for an interface's "parent".
8075 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
8078 2004-11-14 Ben Maurer <bmaurer@ximian.com>
8080 * statement.cs: Avoid adding bools to a hashtable.
8082 2004-11-15 Martin Baulig <martin@ximian.com>
8084 * decl.cs (MemberName.GetPartialName): Removed, use GetTypeName() instead.
8086 2004-11-11 Martin Baulig <martin@ximian.com>
8088 * typemanager.cs (TypeManager.GetMethodName): New method.
8090 * class.cs (MethodData.Define): Include the generic arity in the
8091 name of an explicit interface; also add it to the method name.
8093 * pending.cs (PendingImplementation.InterfaceMethod): The method
8094 name now includes the generic arity.
8096 2004-11-07 Miguel de Icaza <miguel@ximian.com>
8098 * expression.cs (Invocation.OverloadResolve): Flag error if we are
8099 calling an unsafe method from a safe location.
8101 2004-11-06 Marek Safar <marek.safar@seznam.cz>
8104 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
8106 2004-11-06 Miguel de Icaza <miguel@ximian.com>
8108 * namespace.cs (VerifyUsing): use GetPartialName instead of
8111 2004-11-05 Miguel de Icaza <miguel@ximian.com>
8113 * statement.cs (Return.Resolve): Fix regression in typo: if
8114 `in_exc', we have to request a NeedReturnLabel, this was a typo
8115 introduced in the anonymous method check-in. Fixes #69131.
8117 * Indexers were using the ShortName when defining themselves,
8118 causing a regression in the compiler bootstrap when applying the
8119 patch from 2004-11-02 (first part), now they use their full name
8120 and the bug is gone.
8122 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
8124 * driver.cs: Strip the path from the names of embedded resources. Fixes
8127 2004-11-04 Raja R Harinath <rharinath@novell.com>
8129 Fix error message regression: cs0104-2.cs.
8130 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
8131 (AliasEntry.Resolve): Update.
8132 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
8134 (RootContext.LookupType): Update.
8136 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
8138 * cs-parser.jay: Add support for handling accessor modifiers
8139 * class: Add support port accessor modifiers and error checking,
8140 define PropertyMethod.Define as virtual (not abstract anymore)
8141 * ecore.cs: Add checking for proeprties access with access modifiers
8142 * iterators.cs: Modify Accessor constructor call based in the modified
8144 2004-11-02 Ben Maurer <bmaurer@ximian.com>
8146 * expression.cs (StringConcat): Handle being called twice,
8147 as when we have a concat in a field init with more than two
8150 2004-11-02 Miguel de Icaza <miguel@ximian.com>
8152 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
8153 special case explicit implementations, we should always produce
8154 the .property or .event declaration.
8156 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
8157 since it will not return correct data if people use this
8158 unresolved in the presence of using statements (see test-313).
8160 * class.cs (MethodData.Define): If we are an explicit interface
8161 implementation, set the method name to the full name of the
8162 interface plus the name of the method.
8164 Notice that using the method.MethodName.GetFullName() does not
8165 work, as it will only contain the name as declared on the source
8166 file (it can be a shorthand in the presence of using statements)
8167 and not the fully qualifed type name, for example:
8171 class D : ICloneable {
8172 object ICloneable.Clone () {
8176 Would produce a method called `ICloneable.Clone' instead of
8177 `System.ICloneable.Clone'.
8179 * namespace.cs (Alias.Resolve): Use GetPartialName.
8181 2004-11-01 Marek Safar <marek.safar@seznam.cz>
8183 * cs-parser.jay: Add error 1055 report.
8185 2004-11-01 Miguel de Icaza <miguel@ximian.com>
8187 * assign.cs (Assign.DoResolve): Only do the transform of
8188 assignment into a New if the types are compatible, if not, fall
8189 through and let the implicit code deal with the errors and with
8190 the necessary conversions.
8192 2004-11-01 Marek Safar <marek.safar@seznam.cz>
8194 * cs-parser.jay: Add error 1031 report.
8196 * cs-tokenizer.cs: Add location for error 1038.
8198 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8200 * cs-parser.jay: Add error 1016 report.
8202 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8204 * cs-parser.jay: Add errors 1575,1611 report.
8206 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8208 * cs-parser.jay: Add error 1001 report.
8210 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8213 * attribute.cs (GetMarshal): Add method argument for
8214 caller identification.
8216 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
8217 agument for GetMarshal and RuntimeMissingSupport.
8219 2004-10-31 Marek Safar <marek.safar@seznam.cz>
8221 * attribute.cs (ExtractSecurityPermissionSet): Removed
8222 TypeManager.code_access_permission_type.
8224 * typemanager.cs: Removed TypeManager.code_access_permission_type.
8226 2004-10-27 Miguel de Icaza <miguel@ximian.com>
8228 * expression.cs (LocalVariableReference.DoResolveLValue): Check
8229 for obsolete use of a variable here. Fixes regression on errors
8230 cs0619-25 and cs0619-26.
8232 2004-10-27 Marek Safar <marek.safar@seznam.cz>
8234 Fix #62358, implemented security attribute encoding.
8236 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
8237 Tests permitted SecurityAction for assembly or other types.
8238 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
8239 data from SecurityPermissionAttribute to PermisionSet class.
8241 * class.cs (ApplyAttributeBuilder): Added special handling
8242 for System.Security.Permissions.SecurityAttribute based types.
8244 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
8245 special handling for System.Security.Permissions.SecurityAttribute
8248 * enum.cs (ApplyAttributeBuilder): Added special handling
8249 for System.Security.Permissions.SecurityAttribute based types.
8251 * parameter.cs (ApplyAttributeBuilder): Added special handling
8252 for System.Security.Permissions.SecurityAttribute based types.
8254 * rootcontext.cs: Next 2 core types.
8256 * typemanager.cs (TypeManager.security_permission_attr_type):
8257 Built in type for the SecurityPermission Attribute.
8258 (code_access_permission_type): Build in type.
8260 2004-10-17 Miguel de Icaza <miguel@ximian.com>
8262 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
8263 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
8264 all of this information into
8265 EmitContext.EmitCapturedVariableInstance.
8267 * codegen.cs (EmitCapturedVariableInstance): move here the
8268 funcionality of emitting an ldarg.0 in the presence of a
8269 remapping. This centralizes the instance emit code.
8271 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
8272 then emit a load of this: it means that we have reached the
8273 topmost ScopeInfo: the one that contains the pointer to the
8274 instance of the class hosting the anonymous method.
8276 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
8277 captures to the topmost CaptureContext.
8279 2004-10-12 Miguel de Icaza <miguel@ximian.com>
8281 * expression.cs (LocalVariableReference): Move the knowledge about
8282 the iterators into codegen's EmitCapturedVariableInstance.
8284 2004-10-11 Miguel de Icaza <miguel@ximian.com>
8286 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
8287 all code paths return a value from an anonymous method (it is the
8288 same as the 161 error, but for anonymous methods).
8290 2004-10-08 Miguel de Icaza <miguel@ximian.com>
8292 The introduction of anonymous methods in the compiler changed
8293 various ways of doing things in the compiler. The most
8294 significant one is the hard split between the resolution phase
8295 and the emission phases of the compiler.
8297 For instance, routines that referenced local variables no
8298 longer can safely create temporary variables during the
8299 resolution phase: they must do so from the emission phase,
8300 since the variable might have been "captured", hence access to
8301 it can not be done with the local-variable operations from the runtime.
8305 (Block.Flags): New flag `IsTopLevel' to indicate that this block
8306 is a toplevel block.
8308 (ToplevelBlock): A new kind of Block, these are the blocks that
8309 are created by the parser for all toplevel method bodies. These
8310 include methods, accessors and anonymous methods.
8312 These contain some extra information not found in regular blocks:
8313 A pointer to an optional CaptureContext (for tracking captured
8314 local variables and parameters). A pointer to the parent
8317 (Return.Resolve): Catch missmatches when returning a value from an
8318 anonymous method (error 1662).
8319 Invoke NeedReturnLabel from the Resolve phase instead of the emit
8322 (Break.Resolve): ditto.
8324 (SwitchLabel): instead of defining the labels during the
8325 resolution phase, we now turned the public ILLabel and ILLabelCode
8326 labels into methods called GetILLabelCode() and GetILLabel() that
8327 only define the label during the Emit phase.
8329 (GotoCase): Track the SwitchLabel instead of the computed label
8330 (its contained therein). Emit the code by using
8331 SwitchLabel.GetILLabelCode ().
8333 (LocalInfo.Flags.Captured): A new flag has been introduce to track
8334 whether the Local has been captured or not.
8336 (LocalInfo.IsCaptured): New property, used to tell whether the
8337 local has been captured.
8339 * anonymous.cs: Vastly updated to contain the anonymous method
8342 The main classes here are: CaptureContext which tracks any
8343 captured information for a toplevel block and ScopeInfo used to
8344 track the activation frames for various local variables.
8346 Each toplevel block has an optional capture context associated
8347 with it. When a method contains an anonymous method both the
8348 toplevel method and the anonymous method will create a capture
8349 context. When variables or parameters are captured, they are
8350 recorded on the CaptureContext that owns them, for example:
8354 MyDelegate d = delegate {
8359 Here `a' will be recorded as captured on the toplevel
8360 CapturedContext, the inner captured context will not have anything
8361 (it will only have data if local variables or parameters from it
8362 are captured in a nested anonymous method.
8364 The ScopeInfo is used to track the activation frames for local
8365 variables, for example:
8367 for (int i = 0; i < 10; i++)
8368 for (int j = 0; j < 10; j++){
8369 MyDelegate d = delegate {
8374 At runtime this captures a single captured variable `i', but it
8375 captures 10 different versions of the variable `j'. The variable
8376 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
8377 recorded on a child.
8379 The toplevel ScopeInfo will also track information like the `this'
8380 pointer if instance variables were referenced (this is necessary
8381 as the anonymous method lives inside a nested class in the host
8382 type of the method).
8384 (AnonymousMethod): Expanded to track the Toplevel, implement
8385 `AnonymousMethod.Compatible' to tell whether an anonymous method
8386 can be converted to a target delegate type.
8388 The routine now also produces the anonymous method content
8390 (AnonymousDelegate): A helper class that derives from
8391 DelegateCreation, this is used to generate the code necessary to
8392 produce the delegate for the anonymous method that was created.
8394 * assign.cs: API adjustments for new changes in
8395 Convert.ImplicitStandardConversionExists.
8397 * class.cs: Adjustments to cope with the fact that now toplevel
8398 blocks are of type `ToplevelBlock'.
8400 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
8401 insteda of standard blocks.
8403 Flag errors if params arguments are passed to anonymous methods.
8405 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
8406 `CurrentAnonymousMethod' which points to the current Anonymous
8407 Method. The variable points to the AnonymousMethod class that
8408 holds the code being compiled. It is set in the new EmitContext
8409 created for the anonymous method.
8411 (EmitContext.Phase): Introduce a variable and an enumeration to
8412 assist in enforcing some rules about when and where we are allowed
8413 to invoke certain methods (EmitContext.NeedsReturnLabel is the
8414 only one that enfonces this right now).
8416 (EmitContext.HaveCaptureInfo): new helper method that returns
8417 whether we have a CapturedContext initialized.
8419 (EmitContext.CaptureVariable): New method used to register that a
8420 LocalInfo must be flagged for capturing.
8422 (EmitContext.CapturedParameter): New method used to register that a
8423 parameters must be flagged for capturing.
8425 (EmitContext.CapturedField): New method used to register that a
8426 field must be flagged for capturing.
8428 (EmitContext.HaveCapturedVariables,
8429 EmitContext.HaveCapturedFields): Return whether there are captured
8430 variables or fields.
8432 (EmitContext.EmitMethodHostInstance): This is used to emit the
8433 instance for the anonymous method. The instance might be null
8434 (static methods), this (for anonymous methods that capture nothing
8435 and happen to live side-by-side with the current method body) or a
8436 more complicated expression if the method has a CaptureContext.
8438 (EmitContext.EmitTopBlock): Routine that drives the emission of
8439 code: it will first resolve the top block, then emit any metadata
8440 and then emit the code. The split is done so that we can extract
8441 any anonymous methods and flag any captured variables/parameters.
8443 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
8444 during this phase, the ILGenerator should not be used as labels
8445 and local variables declared here might not be accessible to any
8446 code that is part of an anonymous method.
8448 Exceptions to this include the temporary variables that are
8449 created by some statements internally for holding temporary
8452 (EmitContext.EmitMeta): New routine, in charge of emitting all the
8455 (EmitContext.TemporaryReturn): This method is typically called
8456 from the Emit phase, and its the only place where we allow the
8457 ReturnLabel to be defined other than the EmitMeta. The reason is
8458 that otherwise we would have to duplicate a lot of logic in the
8459 Resolve phases of various methods that today is on the Emit
8462 (EmitContext.NeedReturnLabel): This no longer creates the label,
8463 as the ILGenerator is not valid during the resolve phase.
8465 (EmitContext.EmitThis): Extended the knowledge in this class to
8466 work in anonymous methods in addition to iterators.
8468 (EmitContext.EmitCapturedVariableInstance): This emits whatever
8469 code is necessary on the stack to access the instance to a local
8470 variable (the variable will be accessed as a field).
8472 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
8473 EmitContext.EmitAddressOfParameter): Routines to support
8474 parameters (not completed at this point).
8476 Removals: Removed RemapLocal and RemapLocalLValue. We probably
8477 will also remove the parameters.
8479 * convert.cs (Convert): Define a `ConstantEC' which points to a
8480 null. This is just to prefity some code that uses
8481 ImplicitStandardConversion code and do not have an EmitContext
8484 The idea is to flag explicitly that at that point in time, it is
8485 known that the conversion will not trigger the delegate checking
8486 code in implicit conversions (which requires a valid
8489 Everywhere: pass new EmitContext parameter since
8490 ImplicitStandardConversionExists now requires it to check for
8491 anonymous method conversions.
8493 (Convert.ImplicitStandardConversionExists): If the type of an
8494 expression is the anonymous_method_type, and the type is a
8495 delegate, we invoke the AnonymousMethod.Compatible method to check
8496 whether an implicit conversion is possible.
8498 (Convert.ImplicitConversionStandard): Only do implicit method
8499 group conversions if the language level is not ISO_1.
8501 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
8502 MethodInfo for the Invoke method. used by Delegate and
8505 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
8506 method conversions if the target type is a delegate.
8508 Removed extra debugging nops.
8510 (LocalVariableReference): Turn the `local_info' into a public
8513 Add `prepared' field, the same hack used for FieldExprs to cope
8514 with composed assignments, as Local variables do not necessarily
8515 operate purely on the stack as they used to: they can be captured
8518 Add `temp' for a temporary result, like fields.
8520 Refactor DoResolve and DoResolveLValue into DoResolveBase.
8522 It now copes with Local variables that are captured and emits the
8523 proper instance variable to load it from a field in the captured
8526 (ParameterReference.DoResolveBase): During the resolve phase,
8527 capture parameters if we are in an anonymous method.
8529 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
8530 anonymous method, use the EmitContext helper routines to emit the
8531 parameter reference.
8533 * iterators.cs: Set RemapToProxy to true/false during the
8536 * parameters.cs (GetParameterByName): New helper method.
8538 * typemanager.cs (anonymous_method_type) a new type that
8539 represents an anonyous method. This is always an internal type,
8540 used as a fencepost to test against the anonymous-methodness of an
8543 2004-10-20 Marek Safar <marek.safar@seznam.cz>
8545 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
8547 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
8549 2004-11-10 Martin Baulig <martin@ximian.com>
8551 * expression.cs (Invocation.BetterFunction): If two methods have
8552 equal parameter types, but only one of them is generic, the
8553 non-generic one wins.
8554 (New.DoResolve): Don't set `is_struct' to false if we're a generic
8555 instance; just use `Type.IsValueType' to determine whether
8556 something is a struct or not.
8557 (MemberAccess.DoResolveAsTypeStep): Don't modify the `args' field,
8558 so we can be called multiple times.
8560 2004-11-10 Martin Baulig <martin@ximian.com>
8562 * generic.cs (TypeParameter.DefineConstraints): New public method.
8563 (TypeParameter.CheckAccessLevel): Override this and return true.
8564 (ConstructedType.ResolveType): Renamed to DoResolveType(), don't
8565 override ResolveType() anymore.
8566 (ConstructedType.DoResolveAsTypeStep): Call DoResolveType() here.
8568 2004-11-10 Martin Baulig <martin@ximian.com>
8570 * rootcontext.cs (RootContext.LookupType): If we're a nested type,
8571 call DeclSpace.ResolveNestedType() on it.
8573 2004-11-10 Martin Baulig <martin@ximian.com>
8575 * support.cs (ReflectionParameters.ParameterModifier): If `gpd' is
8576 non-null, call ParameterModifier() on it.
8578 2004-11-10 Martin Baulig <martin@ximian.com>
8581 (Iterators): Added `current_type' and `this_type' fields.
8582 (Iterators.DefineIterator): Create a new EmitContext and store it
8583 in `ec'; compute `this_type'.
8585 2004-11-10 Martin Baulig <martin@ximian.com>
8588 (TypeManager.IsPrivateAccessible): New public method.
8589 (Closure.Filter): Use IsPrivateAccessible() instead of IsEqual().
8591 2004-11-10 Martin Baulig <martin@ximian.com>
8593 * class.cs (TypeContainer.DefineType): Call
8594 TypeBuilder.DefineGenericParameters() before resolving the type
8596 (MethodData.parent_method): New protected field.
8597 (MethodData..ctor): Added `MethodInfo parent_method' argument.
8598 (MethodData.Define): Compute `parent_method'.
8601 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
8602 (MemberCore.GetClsCompliantAttributeValue): Likewise.
8603 (DeclSpace.ec): New protected field; store the EmitContext here.
8604 (DeclSpace.EmitContext): New public property.
8605 (DeclSpace.ResolveType): Un-comment from the [Obsolte] attribute.
8606 (DeclSpace.ResolveNestedType): New public method.
8607 (DeclSpace.ResolveTypeExpr): Just call ResolveAsTypeTerminal() here.
8608 (DeclSpace.NestedAccessible): Added `Type tb' argument.
8609 (DeclSpace.FamilyAccessible): Likewise.
8610 (DeclSpace.FindType): Call ResolveNestedType() for nested types.
8611 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
8614 * delegate.cs (Delegate.Define): Store the EmitContext in the `ec'
8617 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
8618 (Enum.Emit): Don't create a new EmitContext.
8620 2004-10-18 Martin Baulig <martin@ximian.com>
8622 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
8623 `Type' directly, but call ResolveType() on it.
8624 (Catch.Resolve): Likewise.
8625 (Foreach.Resolve): Likewise.
8627 2004-10-18 Martin Baulig <martin@ximian.com>
8629 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
8630 `Type' directly, but call ResolveType() on it.
8631 (Probe.DoResolve): Likewise.
8632 (ArrayCreation.LookupType): Likewise.
8633 (TypeOf.DoResolve): Likewise.
8634 (SizeOf.DoResolve): Likewise.
8636 2004-10-18 Raja R Harinath <rharinath@novell.com>
8638 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
8641 2004-10-17 John Luke <john.luke@gmail.com>
8643 * class.cs (Operator.GetSignatureForError): use CSharpName
8645 * parameter.cs (Parameter.GetSignatureForError): Returns
8646 correct name even if was not defined.
8648 2004-10-13 Raja R Harinath <rharinath@novell.com>
8651 * class.cs (TypeContainer.EmitContext): New property.
8652 (DefineNestedTypes): Create an emitcontext for each part.
8653 (MethodCore.DoDefineParameters): Use container's emitcontext.
8654 Pass type array to InternalParameters.
8655 (MemberBase.DoDefine): Use container's emitcontext.
8656 (FieldMember.Define): Likewise.
8657 (Event.Define): Likewise.
8658 (SetMethod.GetParameterInfo): Change argument to EmitContext.
8659 Pass type array to InternalParameters.
8660 (SetIndexerMethod.GetParameterInfo): Likewise.
8661 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
8662 * delegate.cs (Define): Pass emitcontext to
8663 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
8664 array to InternalParameters.
8665 * expression.cs (ParameterReference.DoResolveBase): Pass
8666 emitcontext to GetParameterInfo.
8667 (ComposedCast.DoResolveAsTypeStep): Remove check on
8668 ec.ResolvingTypeTree.
8669 * parameter.cs (Parameter.Resolve): Change argument to
8670 EmitContext. Use ResolveAsTypeTerminal.
8671 (Parameter.GetSignature): Change argument to EmitContext.
8672 (Parameters.ComputeSignature): Likewise.
8673 (Parameters.ComputeParameterTypes): Likewise.
8674 (Parameters.GetParameterInfo): Likewise.
8675 (Parameters.ComputeAndDefineParameterTypes): Likewise.
8676 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
8677 * support.cs (InternalParameters..ctor): Remove variant that takes
8679 * typemanager.cs (system_intptr_expr): New.
8680 (InitExpressionTypes): Initialize it.
8682 2004-10-12 Chris Toshok <toshok@ximian.com>
8684 * cs-parser.jay: fix location for try_statement and catch_clause.
8686 2004-10-18 Martin Baulig <martin@ximian.com>
8688 * class.cs (FieldMember.Define): Don't access the TypeExpr's
8689 `Type' directly, but call ResolveType() on it.
8690 (MemberBase.DoDefine): Likewise.
8692 * expression.cs (New.DoResolve): Don't access the TypeExpr's
8693 `Type' directly, but call ResolveType() on it.
8694 (ComposedCast.DoResolveAsTypeStep): Likewise.
8696 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
8697 `Type' directly, but call ResolveType() on it.
8699 2004-10-17 John Luke <john.luke@gmail.com>
8701 * class.cs (Operator.GetSignatureForError): use CSharpName
8703 * parameter.cs (Parameter.GetSignatureForError): Returns
8704 correct name even if was not defined.
8706 2004-10-13 Raja R Harinath <rharinath@novell.com>
8709 * class.cs (TypeContainer.EmitContext): New property.
8710 (DefineNestedTypes): Create an emitcontext for each part.
8711 (MethodCore.DoDefineParameters): Use container's emitcontext.
8712 Pass type array to InternalParameters.
8713 (MemberBase.DoDefine): Use container's emitcontext.
8714 (FieldMember.Define): Likewise.
8715 (Event.Define): Likewise.
8716 (SetMethod.GetParameterInfo): Change argument to EmitContext.
8717 Pass type array to InternalParameters.
8718 (SetIndexerMethod.GetParameterInfo): Likewise.
8719 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
8720 * delegate.cs (Define): Pass emitcontext to
8721 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
8722 array to InternalParameters.
8723 * expression.cs (ParameterReference.DoResolveBase): Pass
8724 emitcontext to GetParameterInfo.
8725 (ComposedCast.DoResolveAsTypeStep): Remove check on
8726 ec.ResolvingTypeTree.
8727 * parameter.cs (Parameter.Resolve): Change argument to
8728 EmitContext. Use ResolveAsTypeTerminal.
8729 (Parameter.GetSignature): Change argument to EmitContext.
8730 (Parameters.ComputeSignature): Likewise.
8731 (Parameters.ComputeParameterTypes): Likewise.
8732 (Parameters.GetParameterInfo): Likewise.
8733 (Parameters.ComputeAndDefineParameterTypes): Likewise.
8734 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
8735 * support.cs (InternalParameters..ctor): Remove variant that takes
8737 * typemanager.cs (system_intptr_expr): New.
8738 (InitExpressionTypes): Initialize it.
8740 2004-10-12 Chris Toshok <toshok@ximian.com>
8742 * cs-parser.jay: fix location for try_statement and catch_clause.
8744 2004-10-07 Raja R Harinath <rharinath@novell.com>
8746 More DeclSpace.ResolveType avoidance.
8747 * decl.cs (MemberCore.InUnsafe): New property.
8748 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
8749 with newly created EmitContext.
8750 (FieldMember.Define): Likewise.
8751 * delegate.cs (Delegate.Define): Likewise.
8752 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
8753 only if normal name-lookup fails.
8754 (TypeExpr.DoResolve): Enable error-checking.
8755 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
8756 (SizeOf.DoResolve): Likewise.
8757 (ComposedCast.DoResolveAsTypeStep): Likewise.
8758 (StackAlloc.DoResolve): Likewise.
8759 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
8760 (Block.Unsafe): New property.
8761 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
8762 (Unsafe): Set 'unsafe' flag of contained block.
8763 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
8764 (Fixed.Resolve): Likewise.
8765 (Catch.Resolve): Likewise.
8766 (Using.ResolveLocalVariableDecls): Likewise.
8767 (Foreach.Resolve): Likewise.
8769 2004-10-05 John Luke <john.luke@gmail.com>
8771 * cs-parser.jay: add location to error CS0175
8773 2004-10-04 Miguel de Icaza <miguel@ximian.com>
8775 * ecore.cs (Expression.Constantity): Add support for turning null
8778 * const.cs (Const.Define): Allow constants to be reference types
8779 as long as the value is Null.
8781 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
8783 * namespace.cs (NamespaceEntry.Using): No matter which warning
8784 level is set, check if this namespace name has already been added.
8786 2004-10-03 Ben Maurer <bmaurer@ximian.com>
8788 * expression.cs: reftype [!=]= null should always use br[true,false].
8791 2004-10-03 Marek Safar <marek.safar@seznam.cz>
8794 * attribute.cs: Enum conversion moved to
8795 GetAttributeArgumentExpression to be applied to the all
8798 2004-10-01 Raja R Harinath <rharinath@novell.com>
8800 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
8801 * class.c (TypeContainer.DefineType): Flag error if
8802 base types aren't accessible due to access permissions.
8803 * decl.cs (DeclSpace.ResolveType): Move logic to
8804 Expression.ResolveAsTypeTerminal.
8805 (DeclSpace.ResolveTypeExpr): Thin layer over
8806 Expression.ResolveAsTypeTerminal.
8807 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
8808 Refactor code into NestedAccess. Use it.
8809 (DeclSpace.NestedAccess): New.
8810 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
8811 argument to silence errors. Check access permissions.
8812 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
8813 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
8814 (Cast.DoResolve): Likewise.
8815 (New.DoResolve): Likewise.
8816 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
8817 (TypeOf.DoResolve): Likewise.
8819 * expression.cs (Invocation.BetterConversion): Return the Type of
8820 the better conversion. Implement section 14.4.2.3 more faithfully.
8821 (Invocation.BetterFunction): Make boolean. Make correspondence to
8822 section 14.4.2.2 explicit.
8823 (Invocation.OverloadResolve): Update.
8824 (Invocation): Remove is_base field.
8825 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
8826 (Invocation.Emit): Likewise.
8828 2004-09-24 Marek Safar <marek.safar@seznam.cz>
8830 * cs-parser.jay: Reverted 642 warning fix.
8832 2004-09-23 Marek Safar <marek.safar@seznam.cz>
8835 * decl.cs (FindMemberWithSameName): Indexer can have more than
8838 2004-09-23 Marek Safar <marek.safar@seznam.cz>
8840 * expression.cs (LocalVariableReference.DoResolveLValue):
8841 Do not report warning 219 for out values.
8842 (EmptyExpression.Null): New member to avoid extra allocations.
8844 2004-09-23 Marek Safar <marek.safar@seznam.cz>
8846 * cs-parser.jay: Fix wrong warning 642 report.
8848 * cs-tokenizer.cs (CheckNextToken): New helper;
8849 Inspect next character if is same as expected.
8851 2004-09-23 Martin Baulig <martin@ximian.com>
8853 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
8854 (Convert.ImplicitReferenceConversionExists): Likewise.
8856 2004-11-09 Raja R Harinath <rharinath@novell.com>
8858 * Makefile (DISTFILES): Comment out a few missing files.
8860 2004-10-29 Raja R Harinath <rharinath@novell.com>
8862 * Makefile (bootstrap_libs,bootstrap_libfiles): New.
8863 (bootstrap-libs): New target. Invokes the net_2_0_bootstrap profile.
8864 (gmcs.exe): Invoke bootstrap-libs.
8865 (clean-local): Clean the net_2_0_bootstrap profile too.
8866 (PROGRAM_INSTALL_DIR): New.
8867 (install-local): Use it.
8869 2004-10-13 Martin Baulig <martin@ximian.com>
8871 * generic.cs (TypeManager.InflatedConstraints): New nested class.
8872 (TypeParameter.DefineType): If we're a method type parameter and
8873 that method is overriding something, "inflate" its constraints.
8875 2004-10-12 Martin Baulig <martin@ximian.com>
8877 * expression.cs (MemberAccess.DoResolve): If we're a SimpleName
8878 and have type arguments, create and resolve a ConstructedType.
8880 2004-10-12 Martin Baulig <martin@ximian.com>
8882 * decl.cs (MemberCache.FindMemberToOverride): Use
8883 TypeManager.IsEqual() to compare the parameters and Type.Equals()
8884 to compare the invocationType.
8886 * typemanager.cs (TypeManager.IsEqual): Added support for arrays.
8887 When comparing two type parameters, only do the signature-only
8888 comparision for method type parameters.
8890 2004-10-11 Martin Baulig <martin@ximian.com>
8892 * report.cs: Don't make --fatal abort on warnings, we have
8893 -warnaserror for that.
8895 2004-10-11 Martin Baulig <martin@ximian.com>
8898 (TypeManager.IsEqualGenericType): Removed, use IsEqual() instead.
8899 (TypeManager.IsEqual): Call ourself recursively instead of using
8902 2004-10-11 Martin Baulig <martin@ximian.com>
8904 * class.cs (TypeContainer.DefineType): Only call TypeParameter.Define()
8905 on our own type parameters, not on the ones we inherit from a containing
8908 * expression.cs (Invocation.InferType): Use `==', not `Equals()' for
8911 * generic.cs (TypeParameter.Define): We may only be called once.
8913 * pending.cs (Pending.InterfaceMethod): Call TypeManager.Real_IsEqual()
8914 instead of TypeManager.IsEqual().
8916 2004-09-28 Martin Baulig <martin@ximian.com>
8919 (GenericConstraints.EffectiveBaseClass): New public property.
8920 (TypeParameter.GenericConstraints): New public property.
8921 (ConstructedType.CheckConstraints): Improved.
8923 * convert.cs (Convert.TypeParam_EffectiveBaseType): New private method.
8924 (Convert.TypeParameterConversion): New private method; use this in
8925 ImplicitReferenceConversion() and ImplicitReferenceConversionExists()
8926 for all conversions related to type parameters.
8928 2004-09-24 Martin Baulig <martin@ximian.com>
8930 * convert.cs (Convert.ImplicitReferenceConversion): Added implicit
8931 type parameter conversions for type parameters which are known to
8934 2004-09-24 Martin Baulig <martin@ximian.com>
8936 * generic.cs (GenericConstraints): Added `IsReferenceType' and
8937 `IsValueType' properties.
8939 * support.cs (ReflectionConstraints): Use
8940 Type.GetGenericParameterConstraints() instead of the old hack.
8942 2004-09-24 Martin Baulig <martin@ximian.com>
8944 * generic.cs (GenericConstraints): Moved here and made it an
8947 * support.cs (GenericConstraints): Moved to generic.cs.
8949 2004-09-24 Martin Baulig <martin@ximian.com>
8952 (ReflectionConstraints): Un-nested this class and made it public.
8955 (TypeManager.GetTypeParameterConstraints): New public method.
8956 (TypeManager.HasConstructorConstraint): Use the attributes.
8958 2004-09-24 Martin Baulig <martin@ximian.com>
8960 * support.cs (GenericConstraints): Replaced `HasConstructor',
8961 `IsReferenceType' and `IsValueType' with `Attributes'.
8962 (ReflectionParameters.ReflectionConstraints): Removed the Create()
8963 method and made the .ctor public.
8965 * generic.cs (Constraints.Attributes): New public property.
8966 (Constraints): Renamed `HasConstructor' -> `HasConstructorConstraint',
8967 `IsReferenceType' -> `HasReferenceTypeConstraint' and
8968 `IsValueType' -> `HasValueTypeConstraint'.
8970 2004-09-23 Martin Baulig <martin@ximian.com>
8972 * generic.cs (Constraints): Reflect latest runtime changes.
8974 2004-09-23 Martin Baulig <martin@ximian.com>
8976 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
8977 (Convert.ImplicitReferenceConversionExists): Likewise.
8979 2004-09-23 Marek Safar <marek.safar@seznam.cz>
8981 * class.cs (Operator.Define): Add error 448 and 559 report.
8983 2004-09-22 Marek Safar <marek.safar@seznam.cz>
8985 * class.cs (MemberBase.IsTypePermitted): New protected
8986 method for checking error CS0610.
8988 2004-09-22 Marek Safar <marek.safar@seznam.cz>
8990 * class.cs (TypeContainer.HasExplicitLayout): New property
8991 Returns whether container has StructLayout attribute set Explicit.
8992 (FieldMember): New abstract class for consts and fields.
8993 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
8994 (Field): Reuse FieldMember.
8996 * const.cs (Const): Reuse FieldMember.
8998 * rootcontext.cs: EmitConstants call moved to class.
9000 2004-09-22 Martin Baulig <martin@ximian.com>
9002 Marek and me just fixed one of our oldest bugs: #28562 :-)
9004 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
9006 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
9007 we're an EnumConstant, just return that.
9008 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
9009 an EnumConstant. In this case, we need to use GetValueAsEnumType()
9010 to get the value which'll actually be written into the attribute.
9011 However, we have to use GetValue() to access the attribute's value
9014 2004-09-22 Marek Safar <marek.safar@seznam.cz>
9016 * constant.cs (Constant.IsNegative): New abstract property
9019 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
9020 (StackAlloc.DoResolve): Reused IsNegative.
9022 2004-09-22 Martin Baulig <martin@ximian.com>
9024 * typemanager.cs (TypeManager.LookupGenericTypeContainer): New
9025 public method; like LookupTypeContainer, but also works for
9028 * report.cs (Report.SymbolRelatedToPreviousError): Use
9029 TypeManager.LookupGenericTypeContainer().
9031 2004-09-22 Martin Baulig <martin@ximian.com>
9033 Thanks to Peter Sestoft for this bug report.
9035 * expression.cs (Conditional): If both the `trueExpr' and the
9036 `falseExpr' is a NullLiteral, return a NullLiteral.
9038 2004-09-22 Martin Baulig <martin@ximian.com>
9040 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
9041 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
9042 for the "get_Current" call.
9044 2004-09-21 Martin Baulig <martin@ximian.com>
9046 * convert.cs (Convert.ImplicitReferenceConversion): When
9047 converting to an interface type, first check whether we're
9048 converting from a reference type.
9050 2004-09-14 Martin Baulig <martin@ximian.com>
9052 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
9054 2004-09-14 Marek Safar <marek.safar@seznam.cz>
9057 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
9058 called and is obsolete then this member suppress message
9059 when call is inside next [Obsolete] method or type.
9061 * expression.cs: Use TestObsoleteMethodUsage member.
9063 2004-09-14 Martin Baulig <martin@ximian.com>
9065 * genericparser.cs: Removed.
9067 2004-09-13 Marek Safar <marek.safar@seznam.cz>
9069 * class.cs (MethodCore.CheckBase): Fix bug #65757.
9071 2004-09-12 Marek Safar <marek.safar@seznam.cz>
9073 * attribute.cs (Attribute.Resolve): Add error 653 report.
9075 * class.cs (Class.ApplyAttributeBuilder): Add error 641
9077 (Method.ApplyAttributeBuilder): Add error 685 report.
9078 (Operator.Define): Add error 564 report.
9080 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
9082 * expression.cs (Invocation.DoResolve): Add error
9085 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
9088 2004-09-11 Marek Safar <marek.safar@seznam.cz>
9090 * class.cs (ConstructorInitializer.Resolve):
9091 Wrong error number (515->516).
9093 2004-09-11 Marek Safar <marek.safar@seznam.cz>
9095 * class.cs (Indexer.Define): Add error 631 report.
9097 2004-09-11 Marek Safar <marek.safar@seznam.cz>
9099 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
9101 2004-09-11 Marek Safar <marek.safar@seznam.cz>
9103 * expression.cs (Probe.DoResolve): Add error CS0241 report.
9105 2004-09-10 Marek Safar <marek.safar@seznam.cz>
9107 * cs-parser.jay: Added error CS0241 report.
9109 2004-09-10 Raja R Harinath <rharinath@novell.com>
9111 * cs-parser.jay (fixed_statement): Introduce a scope for the
9112 declaration in the 'fixed' statement.
9114 2004-09-09 Marek Safar <marek.safar@seznam.cz>
9116 * cs-parser.jay: Added CS0230 error report.
9118 2004-09-09 Marek Safar <marek.safar@seznam.cz>
9120 * cs-parser.jay: Added errors CS0231 and CS0257 report.
9122 2004-09-09 Marek Safar <marek.safar@seznam.cz>
9124 * expression.cs (Argument.Resolve): Added error CS0192 and
9127 2004-09-09 Marek Safar <marek.safar@seznam.cz>
9129 C# 2.0 #pragma warning feature
9131 * cs-tokenizer.cs (PreProcessPragma): New method;
9132 Handles #pragma directive.
9134 * report.cs (WarningRegions): New class; Support
9135 class for #pragma warning directive. It tests whether
9136 warning is enabled for a given line.
9138 2004-09-08 Miguel de Icaza <miguel@ximian.com>
9140 * const.cs: Add more descriptive error report, tahnks to
9143 2004-09-08 Marek Safar <marek.safar@seznam.cz>
9145 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
9147 2004-09-07 Miguel de Icaza <miguel@ximian.com>
9149 * expression.cs: Apply patch from Ben: Remove dead code from
9150 ArrayCreation, and remove the TurnintoConstant call in const.cs,
9151 as that code just threw an exception anwyays.
9153 * const.cs: Remove the call to the turnintoconstant, for details
9156 * literal.cs: The type of the null-literal is the null type; So
9157 we use a placeholder type (literal.cs:System.Null, defined here)
9160 * expression.cs (Conditional.DoResolve): Remove some old code that
9161 is no longer needed, conversions have been fixed.
9163 (ArrayCreationExpression.DoResolve): Return false if we fail to
9164 resolve the inner expression.
9166 2004-09-07 Raja R Harinath <rharinath@novell.com>
9169 * cs-parser.jay (delegate_declaration): Record a delegate
9170 declaration as a type declaration.
9171 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
9173 2004-09-06 Miguel de Icaza <miguel@ximian.com>
9175 * parameter.cs: Do not crash if the type can not be resolved.
9177 * expression.cs: Report errors with unsafe pointers, fixes #64896
9179 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
9181 * expression.cs: Pointer arith always needs to do a conv.i
9182 if the operand is a long. fix 65320
9184 2004-09-04 Marek Safar <marek.safar@seznam.cz>
9186 Fixed cs0619-37.cs, cs0619-38.cs
9188 * enum.cs (GetObsoleteAttribute): Removed.
9190 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
9191 on Enum member is double staged. The first is tested member
9194 2004-09-04 Marek Safar <marek.safar@seznam.cz>
9196 Fixed #56986, #63631, #65231
9198 * class.cs: (TypeContainer.AddToMemberContainer): New method,
9199 adds member to name container.
9200 (TypeContainer.AddToTypeContainer): New method, adds type to
9202 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
9203 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
9204 AddOperator): Simplified by reusing AddToMemberContainer.
9205 (TypeContainer.UserDefinedStaticConstructor): Changed to property
9207 (Method.CheckForDuplications): Fixed implementation to test all
9209 (MemberBase): Detection whether member is explicit interface
9210 implementation is now in constructor.
9211 (MemberBase.UpdateMemberName): Handles IndexerName.
9212 (Accessor): Changed to keep also location information.
9213 (AbstractPropertyEventMethod): Is derived from MemberCore.
9214 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
9215 will be emited or not.
9216 (PropertyBase.AreAccessorsDuplicateImplementation):
9217 Tests whether accessors are not in collision with some method.
9218 (Operator): Is derived from MethodCore to simplify common
9221 * decl.cs (Flags.TestMethodDuplication): Test for duplication
9223 (DeclSpace.AddToContainer): Adds the member to defined_names
9224 table. It tests for duplications and enclosing name conflicts.
9226 * enum.cs (EnumMember): Clean up to reuse the base structures
9228 2004-09-03 Martin Baulig <martin@ximian.com>
9230 Merged latest changes into gmcs. Please keep this comment in
9231 here, it makes it easier for me to see what changed in MCS since
9232 the last time I merged.
9234 2004-09-03 Martin Baulig <martin@ximian.com>
9236 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
9237 into TypeContainer, to make partial classes work again.
9239 2004-09-03 Martin Baulig <martin@ximian.com>
9241 * rootcontext.cs (RootContext.V2): Removed.
9243 2004-03-23 Martin Baulig <martin@ximian.com>
9245 * expression.cs (Invocation.OverloadResolve): Added `bool
9246 may_fail' argument and use it instead of the Location.IsNull() hack.
9248 2004-09-09 Martin Baulig <martin@ximian.com>
9250 * cs-parser.jay (namespace_declaration): Fixed CS0134 reporting.
9252 2004-09-09 Martin Baulig <martin@ximian.com>
9254 * generic.cs (TypeParameter.DefineType): Added support for
9255 explicit interface methods.
9257 2004-09-09 Martin Baulig <martin@ximian.com>
9259 * README.Changes: New document. Started to list important changes
9260 between MCS and GMCS here.
9262 2004-09-08 Martin Baulig <martin@ximian.com>
9265 (TypeContainer.CheckRecursiveDefinition): New protected method.
9266 (TypeContainer.DefineType): Move the CS0146 check into
9267 CheckRecursiveDefinition().
9269 2004-09-06 Martin Baulig <martin@ximian.com>
9271 * generic.cs (ConstructedType.CheckConstraints): Allow builtin
9272 types for the constructor constraint.
9274 2004-09-03 Martin Baulig <martin@ximian.com>
9276 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
9277 into TypeContainer, to make partial classes work again.
9279 2004-09-03 Martin Baulig <martin@ximian.com>
9281 * rootcontext.cs (RootContext.V2): Removed.
9283 2004-03-23 Martin Baulig <martin@ximian.com>
9285 * expression.cs (Invocation.OverloadResolve): Added `bool
9286 may_fail' argument and use it instead of the Location.IsNull() hack.
9288 2004-09-03 Martin Baulig <martin@ximian.com>
9290 Merged latest changes into gmcs. Please keep this comment in
9291 here, it makes it easier for me to see what changed in MCS since
9292 the last time I merged.
9294 2004-09-03 Raja R Harinath <rharinath@novell.com>
9297 * expression.cs (BetterConversion): Don't allow either conversion
9298 to be null. Remove redundant implicit conversion test when 'q ==
9299 null' -- when this function is invoked, we already know that the
9300 implicit conversion exists.
9301 (BetterFunction): Assume that 'best' is non-null. Remove
9302 redundant reimplementation of IsApplicable when 'best' is null.
9303 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
9304 number of arguments.
9305 (IsAncestralType): Extract from OverloadResolve.
9306 (OverloadResolve): Make robust to the MethodGroupExpr being
9307 unsorted. Implement all the logic of Section 14.5.5.1, and
9308 support overloading of methods from multiple applicable types.
9309 Clean up logic somewhat. Don't pass null methods to BetterFunction.
9311 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
9312 (RealError, Warning): Append type of report to related symbol.
9314 2004-09-03 Marek Safar <marek.safar@seznam.cz>
9316 * enum.cs: Fixed CLS-Compliance checks for enum members.
9317 Error tests cs3008-8.cs, cs3014-8.cs
9319 2004-09-02 Marek Safar <marek.safar@seznam.cz>
9321 Fixed bug #62342, #63102
9322 * class.cs: ImplementIndexer uses member.IsExplicitImpl
9323 like ImplementMethod.
9325 2004-09-02 Marek Safar <marek.safar@seznam.cz>
9327 * attribute.cs (Attribute.GetAttributeArgumentExpression):
9330 2004-09-02 Martin Baulig <martin@ximian.com>
9332 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
9333 TypeManager.GetArgumentTypes() rather than calling GetParameters()
9336 2004-09-01 Marek Safar <marek.safar@seznam.cz>
9338 C# 2.0 Static classes implemented
9340 * class.cs (TypeContainer): instance_constructors,
9341 initialized_fields, initialized_static_fields,
9342 default_constructor, base_inteface_types are protected to be
9343 accessible from StaticClass.
9344 (TypeContainer.DefineDefaultConstructor): New virtual method
9345 for custom default constructor generating
9346 (StaticClass): New class to handle "Static classes" feature.
9348 * cs-parser.jay: Handle static keyword on class like instance
9351 * driver.cs: Added "/langversion" command line switch with two
9352 options (iso-1, default).
9354 2004-08-31 Marek Safar <marek.safar@seznam.cz>
9356 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
9358 2004-08-31 Miguel de Icaza <miguel@ximian.com>
9360 * delegate.cs: Style.
9362 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
9364 * delegate.cs: Add seperate instance expr field for miguel.
9366 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
9368 * PointerArithmetic (Resolve): make sure we are not doing
9369 pointer arith on void*. Also, make sure we are resolved
9370 by not setting eclass until resolve.
9372 All callers: Make sure that PointerArithmetic gets resolved.
9374 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
9376 * ArrayCreation (LookupType): If the type does not resolve
9377 to an array, give an error.
9379 2004-08-27 Marek Safar <marek.safar@seznam.cz>
9381 * statement.cs (Try.Resolve): Fixed bug #64222
9383 2004-08-27 Martin Baulig <martin@ximian.com>
9386 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
9389 2004-08-26 Marek Safar <marek.safar@seznam.cz>
9391 * ecore.cs (Constantify): Get underlying type via
9392 System.Enum.GetUnderlyingType to avoid StackOverflow on the
9393 Windows in special cases.
9395 2004-08-26 Marek Safar <marek.safar@seznam.cz>
9397 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
9398 for obtaining also private methods.
9399 (GetRemoveMethod): Used GetRemoveMethod (true)
9400 for obtaining also private methods.
9402 2004-09-02 Martin Baulig <martin@ximian.com>
9404 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
9405 TypeManager.GetArgumentTypes() rather than calling GetParameters()
9408 2004-08-27 Martin Baulig <martin@ximian.com>
9411 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
9414 2004-08-25 Martin Baulig <martin@ximian.com>
9416 * support.cs (ReflectionParameters..ctor): If this is a generic
9417 method, retrieve and store its type parameters.
9418 (InternalParameters..ctor): Added `TypeParameter[]' argument.
9419 (ReflectionParameters.GenericConstraints): The argument specifies
9420 the type parameter, not the method parameter.
9421 (InternalParameters.GenericConstraints): Likewise.
9423 * generic.cs (TypeParameter.DefineType): Correctly handle
9424 constraints wrt. generic methods in interfaces and their
9427 2004-08-24 Martin Baulig <martin@ximian.com>
9429 * generic.cs (TypeParameter.IsSubclassOf): New public method.
9430 (Constraints.IsSubclassOf): New internal method.
9432 * typemanager.cs (TypeManager.FindMembers): Added special support
9433 for GenericTypeParameterBuilder's.
9434 (TypeManager.IsSubclassOf, IsFamilyAccessible): Added support for
9437 2004-08-24 Martin Baulig <martin@ximian.com>
9440 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
9441 this for accessibility checks.
9442 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
9443 IsNestedFamilyAccessible.
9444 (TypeManager.IsSubclassOf): New method, do what the name actually
9447 2004-08-24 Martin Baulig <martin@ximian.com>
9449 * expression.cs (MemberAccess.DoResolve): When resolving ourselves
9450 as a SimpleName, include the generic arity.
9452 2004-08-24 Martin Baulig <martin@ximian.com>
9454 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
9455 MethodAttributes.HideBySig for operators.
9457 2004-08-23 Martin Baulig <martin@ximian.com>
9459 Back to the old error reporting system :-)
9461 * report.cs (Message): Removed.
9462 (Report.MessageData, ErrorData, WarningData): Removed.
9463 (Report.Error, Warning): Back to the old system.
9465 2004-08-23 Martin Baulig <martin@ximian.com>
9467 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
9469 * class.cs (TypeContainer.ParentContainer): New public virtual
9470 method; replaces the explicit interface implementation.
9471 (ClassPart.ParentContainer): Override.
9473 2004-08-23 Martin Baulig <martin@ximian.com>
9475 * statement.cs (Switch): Added support for constant switches; see
9476 #59428 or test-285.cs.
9478 2004-08-22 Marek Safar <marek.safar@seznam.cz>
9481 * statement.cs (GetEnumeratorFilter): Removed useless
9482 logic because C# specs is strict. GetEnumerator must be
9485 2004-08-22 Martin Baulig <martin@ximian.com>
9487 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
9488 a switch and may break, reset the barrier. Fixes #59867.
9490 2004-08-22 Marek Safar <marek.safar@seznam.cz>
9492 CLS-Compliance speed up (~5% for corlib)
9494 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
9495 New method. Tests container for CLS-Compliant names
9497 * class.cs (TypeContainer.VerifyClsName): New method.
9498 Checks whether container name is CLS Compliant.
9499 (Constructor): Implements IMethodData.
9501 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
9502 low-case table for CLS Compliance test.
9503 (MemberCache.VerifyClsParameterConflict): New method.
9504 Checks method parameters for CS3006 error.
9506 * enum.cs (EnumMember): Is derived from MemberCore.
9507 (Enum.VerifyClsName): Optimized for better performance.
9509 2004-08-06 Marek Safar <marek.safar@seznam.cz>
9511 * report.cs: Renamed Error_T to Error and changed all
9514 2004-08-06 Marek Safar <marek.safar@seznam.cz>
9516 * class.cs (TypeContainer.IndexerArrayList): New inner class
9517 container for indexers.
9518 (TypeContainer.DefaultIndexerName): New constant for default
9519 indexer name. Replaced all "Item" with this constant.
9520 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
9522 * typemanager.cs (TypeManager.default_member_ctor): Cache here
9523 DefaultMemberAttribute constructor.
9525 2004-08-05 Martin Baulig <martin@ximian.com>
9527 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
9530 2004-08-05 Marek Safar <marek.safar@seznam.cz>
9532 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
9533 multi platforms problem.
9535 * compiler.csproj: Included shared files.
9537 2004-08-04 Marek Safar <marek.safar@seznam.cz>
9539 Fix bug 60333, 55971 in the more general way
9540 * attribute.cs (Attribute.GetAttributeArgumentExpression):
9541 Added arg_type argument for constant conversion.
9542 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
9544 2004-08-04 Marek Safar <marek.safar@seznam.cz>
9547 * class.cs (TypeContainer ): New inner classes MethodArrayList,
9548 OperatorArrayList, MethodCoreArrayList for typecontainer
9549 containers. Changed class member types to these new types.
9550 (MethodArrayList.DefineMembers): Added test for CS0659.
9552 2004-08-04 Miguel de Icaza <miguel@ximian.com>
9554 * cfold.cs: Synchronize the folding with the code in expression.cs
9555 Binary.DoNumericPromotions for uint operands.
9557 * attribute.cs: Revert patch from Raja, it introduced a regression
9558 while building Blam-1.2.1 (hard to isolate a test case).
9560 2004-08-04 Marek Safar <marek.safar@seznam.cz>
9564 (TypeContainer.Define): Renamed to DefineContainerMembers because of
9566 (MethodCore.parent_method): New member. The method we're overriding
9567 if this is an override method.
9568 (MethodCore.CheckBase): Moved from Method class and made common.
9569 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
9571 (MethodCore.CheckForDuplications): New abstract method. For custom
9572 member duplication search in a container
9573 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
9574 method and its return type.
9575 (Event.conflict_symbol): New member. Symbol with same name in the
9579 (MemberCache.FindMemberWithSameName): New method. The method
9580 is looking for conflict with inherited symbols.
9582 2004-08-04 Martin Baulig <martin@ximian.com>
9584 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
9586 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
9588 2004-08-03 Marek Safar <marek.safar@seznam.cz>
9590 * report.cs (Message): New enum for better error, warning reference in
9592 (MessageData): New inner abstract class. It generally handles printing of
9593 error and warning messages.
9594 Removed unused Error, Warning, Message methods.
9596 2004-08-03 Marek Safar <marek.safar@seznam.cz>
9598 Fix for cs0592-8.cs test
9600 (Attributable.ValidAttributeTargets): Made public.
9601 (Attribute.ExplicitTarget): New member for explicit target value.
9602 (Attribute.CheckTargets): Now we translate explicit attribute
9603 target to Target here.
9605 2004-08-03 Ben Maurer <bmaurer@ximian.com>
9607 * ecore.cs (MethodGroupExpr): new IsBase property.
9609 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
9611 * delegate.cs (DelegateCreation): store a MethodGroupExpr
9612 rather than an instance expr.
9614 (DelegateCreation.Emit): Use the method group rather than
9615 the instance expression. Also, if you have base.Foo as the
9616 method for a delegate, make sure to emit ldftn, not ldftnvirt.
9618 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
9620 (NewDelegate.DoResolve): Only check for the existance of Invoke
9621 if the method is going to be needed. Use MethodGroupExpr.
9623 (NewDelegate.Emit): Remove, DelegateCreation implements this.
9625 * expression.cs: For pointer arith., make sure to use
9626 the size of the type, not the size of the pointer to
9629 2004-08-03 Marek Safar <marek.safar@seznam.cz>
9632 * class.cs (Class): Added error CS0502 test.
9634 2004-08-03 John Luke <jluke@cfl.rr.com>
9635 Raja R Harinath <rharinath@novell.com>
9638 * attribute.cs (Attribute.complained_before): New flag.
9639 (Attribute.ResolveType, Attribute.Resolve),
9640 (Attribute.DefinePInvokeMethod): Set it.
9641 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
9643 2004-08-03 Martin Baulig <martin@ximian.com>
9645 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
9646 use a user-defined operator; we still need to do numeric
9647 promotions in case one argument is a builtin type and the other
9648 one has an implicit conversion to that type. Fixes #62322.
9650 2004-08-18 Martin Baulig <martin@ximian.com>
9652 * class.cs (Method.Define): Use the correct method name when
9653 creating the MethodBuilder for a generic method.
9655 2004-08-17 Martin Baulig <martin@ximian.com>
9657 * generic.cs (Constraints): Support type parameter constraints.
9659 2004-08-16 Martin Baulig <martin@ximian.com>
9661 * cs-tokenizer.cs (Tokenizer.TypeOfParsing): New public property.
9662 (Token.GENERIC_DIMENSION): New token; this is returned if we
9663 encounter an unbound generic type in a typeof() expression.
9665 * cs-parser.jay (opt_type_argument_list): Added GENERIC_DIMENSION;
9666 this token is only generated while parsing a typeof() expression.
9667 (typeof_expression): Removed the old unbound_type hack.
9669 * generic.cs (TypeArguments.IsUnbound): New public property.
9671 * decl.cs (MemberName): Added support for unbound types.
9673 2004-08-14 Martin Baulig <martin@ximian.com>
9676 (TypeManager.IsEqualGenericInstance): New static method.
9677 (TypeManager.IsSubclassOrNestedChildOf, IsSubclassOf): This is
9678 just used to check accessibility, so follow the rules of 26.1.6.
9680 * expression.cs (MemberAccess.ResolveAsTypeStep): Return a
9681 ConstructedType instead of a TypeExpression if we have type arguments.
9683 * cs-parser.jay (typeof_expression): Support unbound generic types.
9685 * ecore.cs (UnboundTypeExpression): New public class.
9687 2004-08-12 Martin Baulig <martin@ximian.com>
9689 * typemanager.cs (TypeManager.IsNestedChildOf): Use
9690 TypeManager.IsEqual() rather than `=='.
9692 * decl.cs (DeclSpace.CheckAccessLevel): Use `tb.FullName' for
9693 generic instances as well.
9695 2004-08-12 Martin Baulig <martin@ximian.com>
9697 * expression.cs (Invocation.InferType): We can only infer method
9698 type parameters. Fixes #62647.
9700 2004-08-11 Martin Baulig <martin@ximian.com>
9702 * class.cs (TypeContainer.DefineType): Create the TypeBuilder
9703 before resolving the base classes.
9705 2004-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9707 * Makefile: install .mdb file too.
9709 2004-08-05 Martin Baulig <martin@ximian.com>
9711 * ecore.cs (FieldExpr.DoResolveLValue): If we're resolving a field
9712 initializer, the current type is just the TypeBuilder, not the
9713 instantiated generic type.
9714 (FieldExpr.IsFieldInitializer): New public property.
9716 2004-08-04 Martin Baulig <martin@ximian.com>
9718 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
9720 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
9722 2004-08-03 Martin Baulig <martin@ximian.com>
9724 * class.cs (MethodData.Define): If we're an explicit
9725 implementation, remove the generic arity from the type name.
9727 2004-08-03 Martin Baulig <martin@ximian.com>
9729 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
9730 use a user-defined operator; we still need to do numeric
9731 promotions in case one argument is a builtin type and the other
9732 one has an implicit conversion to that type. Fixes #62322.
9734 2004-08-02 Martin Baulig <martin@ximian.com>
9736 * class.cs (TypeContainer.ifaces): Make this a `Type[]', not a
9738 (TypeContainer.GetClassBases): Return the unexpanded list of
9739 interfaces; we expand them later.
9740 (TypeContainer.DefineType): After creating the TypeBuilder, call
9741 TypeManager.ExpandInterfaces() to get an expanded and resolved
9744 * ecore.cs (TypeExpr.GetInterfaces): Removed
9746 * generics.cs (Constraints.InterfaceConstraints): Remove.
9747 (TypeParameter.DefineType): Call TypeManager.RegisterBuilder() to
9748 register the interface constraints.
9751 (TypeManager.AddUserType): Removed the `ifaces' argument.
9752 (TypeManager.AddTypeParameter): Likewise.
9753 (TypeManager.AddUserInterface): Removed, was unused.
9754 (TypeManager.RegisterBuilder): Take a `Type[]' instead of a
9755 `TypeExpr[]' array for the interfaces.
9756 (TypeManager.ExpandInterfaces): Call this after the TypeBuilder
9757 has been defined, returns a list of the resolved interfaces types.
9758 (TypeManager.GetInterfaces): Return a `Type[]', not a `TypeExpr[]'.
9759 (TypeManager.GetExplicitInterfaces): Likewise.
9761 2004-08-02 Martin Baulig <martin@ximian.com>
9763 * expression.cs (Invocation.EmitCall): If we're invoking a method
9764 on a type parameter, use the new `Constrained' prefix opcode.
9766 2004-08-02 Martin Baulig <martin@ximian.com>
9768 * statement.cs (LocalInfo.Flags): Added `IsThis'.
9769 (LocalInfo.IsThis): New public property.
9770 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
9772 2004-08-01 Martin Baulig <martin@ximian.com>
9774 * class.cs (TypeContainer.GetClassBases): Don't set the default
9775 here since we may get called from GetPartialBases().
9776 (TypeContainer.DefineType): If GetClassBases() didn't return a
9777 parent, use the default one.
9779 2004-07-30 Martin Baulig <martin@ximian.com>
9781 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
9783 * class.cs (SourceMethod): New public class, derive from the
9784 symbol writer's ISourceMethod.
9785 (Method): Use the new symbol writer API.
9787 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
9788 as argument and use the new symbol writer.
9791 (SourceFile): Implement the symbol writer's ISourceFile.
9792 (Location.SymbolDocument): Removed.
9793 (Location.SourceFile): New public property.
9795 * symbolwriter.cs: Use the new symbol writer API.
9797 2004-07-30 Raja R Harinath <rharinath@novell.com>
9799 * Makefile (install-local): Remove. Functionality moved to
9802 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
9804 * Makefile: Install mcs.exe.config file together with mcs.exe.
9805 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
9806 correct runtime version.
9808 2004-07-25 Martin Baulig <martin@ximian.com>
9811 (TypeContainer.RegisterOrder): Removed, this was unused.
9812 (TypeContainer, interface_order): Removed.
9813 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
9814 TypeContainer as argument since we can also be called with a
9815 `PartialContainer' for a partial class/struct/interface.
9816 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
9817 of checking whether we're an `Interface' - we could be a
9819 (PartialContainer.Register): Override; call
9820 AddClass()/AddStruct()/AddInterface() on our parent.
9822 * cs-parser.jay (interface_member_declaration): Add things to the
9823 `current_container', not the `current_class'.
9825 * rootcontext.cs (RegisterOrder): The overloaded version which
9826 takes an `Interface' was unused, removed.
9828 * typemanager.cs (TypeManager.LookupInterface): Return a
9829 `TypeContainer', not an `Interface'.
9830 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
9831 contain a `PartialContainer' for an interface, so check it's
9832 `Kind' to figure out what it is.
9834 2004-07-25 Martin Baulig <martin@ximian.com>
9836 * class.cs (Class.DefaultTypeAttributes): New public constant.
9837 (Struct.DefaultTypeAttributes): Likewise.
9838 (Interface.DefaultTypeAttributes): Likewise.
9839 (PartialContainer.TypeAttr): Override this and add the
9840 DefaultTypeAttributes.
9842 2004-07-25 Martin Baulig <martin@ximian.com>
9844 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
9845 we can just use the `Parent' field instead.
9847 2004-07-25 Martin Baulig <martin@ximian.com>
9849 * class.cs (TypeContainer.Emit): Renamed to EmitType().
9851 2004-07-25 Martin Baulig <martin@ximian.com>
9853 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
9854 our parts before defining any methods.
9855 (TypeContainer.VerifyImplements): Make this virtual.
9856 (ClassPart.VerifyImplements): Override and call VerifyImplements()
9857 on our PartialContainer.
9859 2004-07-25 Martin Baulig <martin@ximian.com>
9861 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
9863 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
9864 argument, we can just use the `Parent' field instead.
9867 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
9868 (MemberBase.DoDefine): Likewise.
9870 2004-07-24 Martin Baulig <martin@ximian.com>
9872 * decl.cs (MemberCore.Parent): New public field.
9873 (DeclSpace.Parent): Moved to MemberCore.
9875 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
9876 (MemberBase.ctor): Added TypeContainer argument, pass it to our
9878 (FieldBase, Field, Operator): Likewise.
9879 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
9880 (EventField, Event): Likewise.
9882 2004-07-23 Martin Baulig <martin@ximian.com>
9884 * class.cs (PartialContainer): New public class.
9885 (ClassPart): New public class.
9886 (TypeContainer): Added support for partial classes.
9887 (TypeContainer.GetClassBases): Splitted some of the functionality
9888 out into GetNormalBases() and GetPartialBases().
9890 * cs-tokenizer.cs (Token.PARTIAL): New token.
9891 (Tokenizer.consume_identifier): Added some hacks to recognize
9892 `partial', but only if it's immediately followed by `class',
9893 `struct' or `interface'.
9895 * cs-parser.jay: Added support for partial clases.
9897 2004-07-23 Martin Baulig <martin@ximian.com>
9899 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
9900 a `DeclSpace' and also made it readonly.
9901 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
9902 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
9903 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
9905 * cs-parser.jay: Pass the `current_class', not the
9906 `current_container' (at the moment, this is still the same thing)
9907 to a new Method, Property, Event, Indexer or Constructor.
9909 2004-07-23 Martin Baulig <martin@ximian.com>
9911 * cs-parser.jay (CSharpParser): Added a new `current_class' field
9912 and removed the `current_interface' one.
9913 (struct_declaration, class_declaration, interface_declaration):
9914 Set `current_class' to the newly created class/struct/interface;
9915 set their `Bases' and call Register() before parsing their body.
9917 2004-07-23 Martin Baulig <martin@ximian.com>
9919 * class.cs (Kind): New public enum.
9920 (TypeContainer): Made this class abstract.
9921 (TypeContainer.Kind): New public readonly field.
9922 (TypeContainer.CheckDef): New public method; moved here from
9924 (TypeContainer.Register): New public abstract method.
9925 (TypeContainer.GetPendingImplementations): New public abstract
9927 (TypeContainer.GetClassBases): Removed the `is_class' and
9928 `is_iface' parameters.
9929 (TypeContainer.DefineNestedTypes): Formerly known as
9931 (ClassOrStruct): Made this class abstract.
9933 * tree.cs (RootTypes): New public type.
9935 2004-07-20 Martin Baulig <martin@ximian.com>
9937 * tree.cs (Tree.RecordNamespace): Removed.
9938 (Tree.Namespaces): Removed.
9940 * rootcontext.cs (RootContext.IsNamespace): Removed.
9942 * cs-parser.jay (namespace_declaration): Just create a new
9943 NamespaceEntry here.
9945 2004-07-21 Lluis Sanchez Gual <lluis@novell.com>
9947 * Makefile: Install gmcs.exe.config file together with gmcs.exe.
9948 * gmcs.exe.config: Renamed from mcs.exe.config. Added supportedRuntime
9949 entry to make sure it runs in the correct runtime version.
9951 2004-07-18 Martin Baulig <martin@ximian.com>
9953 * generic.cs (ConstructedType.CheckConstraints): Improved
9954 constraints checking.
9956 2004-07-18 Martin Baulig <martin@ximian.com>
9958 * expression.cs (Invocation.BetterMethod): Call
9959 TypeManager.TypeToCoreType() on all types and removed my previous
9960 hack; we're already doig the right thing here.
9962 2004-07-17 Martin Baulig <martin@ximian.com>
9964 * decl.cs (MemberName.MakeName): Create the "class`1" names here.
9966 2004-07-16 Martin Baulig <martin@ximian.com>
9968 * iterators.cs: Added generics support.
9970 2004-07-16 Martin Baulig <martin@ximian.com>
9972 * iterators.cs: Rewrote this. We're now using one single Proxy
9973 class for both the IEnumerable and the IEnumerator interface and
9974 `Iterator' derives from Class so we can use the high-level API.
9976 * class.cs (TypeContainer.AddIterator): New method.
9977 (TypeContainer.DoDefineType): New protected virtual method, which
9978 is called from DefineType().
9979 (TypeContainer.DoDefineMembers): Call DefineType() and
9980 DefineMembers() on all our iterators.
9981 (TypeContainer.Emit): Call Emit() on all our iterators.
9982 (TypeContainer.CloseType): Call CloseType() on all our iterators.
9984 * codegen.cs (EmitContext.CurrentIterator): New public field.
9986 2004-07-15 Martin Baulig <martin@ximian.com>
9989 (TypeManager.not_supported_exception_type): New type.
9991 2004-07-14 Martin Baulig <martin@ximian.com>
9994 (TypeManager.generic_ienumerable_type): New type.
9995 (TypeManager.generic_ienumerator_type): New type.
9998 (RootContext.interfaces_first_stage): Added
9999 "System.Collections.Generic.IEnumerator`1" and
10000 "System.Collections.Generic.IEnumerable`1".
10002 2004-07-14 Martin Baulig <martin@ximian.com>
10004 * iterators.cs: Use real error numbers.
10006 2004-07-14 Martin Baulig <martin@ximian.com>
10008 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
10009 requires this to be a System.Collection.IEnumerable and not a
10010 class implementing that interface.
10011 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
10013 2004-07-13 Marek Safar <marek.safar@seznam.cz>
10015 * class.cs: Fixed previous fix, it broke some error tests.
10017 2004-07-12 Martin Baulig <martin@ximian.com>
10019 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
10022 2004-07-14 Martin Baulig <martin@ximian.com>
10024 * decl.cs, expression.cs, generic.cs: Use a backqoute (`) and not
10025 an exclamation mark (!) for the generic arity to reflect the
10026 latest spec changes; ie. use "System.Collections.Generic.IList`1".
10028 2004-07-13 Martin Baulig <martin@ximian.com>
10030 * cs-tokenizer.cs (Tokenizer.parse_less_than): Allow array rank
10031 specifiers being part of a type argument.
10033 2004-07-13 Martin Baulig <martin@ximian.com>
10035 * expression.cs (MemberAccess.ResolveAsTypeStep): Use the full `!'
10036 name for generic types.
10038 2004-07-13 Martin Baulig <martin@ximian.com>
10040 * assign.cs (Assign.DoResolve): Moved the CS0131 check up a little
10043 2004-07-09 Miguel de Icaza <miguel@ximian.com>
10045 * assign.cs (LocalTemporary): Add new argument: is_address,If
10046 `is_address' is true, then the value that we store is the address
10047 to the real value, and not the value itself.
10049 * ecore.cs (PropertyExpr): use the new local temporary
10050 stuff to allow us to handle X.Y += z (where X is a struct)
10052 2004-07-08 Martin Baulig <martin@ximian.com>
10054 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
10055 not always return, just like we're doing in Using.Resolve().
10057 2004-07-07 Miguel de Icaza <miguel@ximian.com>
10059 * cs-parser.jay (fixed_statement): flag this as Pinned.
10061 2004-07-06 Miguel de Icaza <miguel@ximian.com>
10063 * typemanager.cs (TypeManager): Removed MakePinned method, this
10064 mechanism is replaced with the .NET 2.x compatible mechanism of
10065 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
10067 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
10068 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
10069 `IsFixed' property which has a different meaning.
10071 2004-07-02 Raja R Harinath <rharinath@novell.com>
10073 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
10074 visible from inside a nested class, not just the names of the
10075 immediately enclosing class.
10076 Fix for bug #60730.
10078 2004-06-24 Raja R Harinath <rharinath@novell.com>
10080 * expression.cs (BetterConversion): Remove buggy special-case
10081 handling of "implicit constant expression conversions". At this
10082 point, we already know that the conversion is possible -- we're
10083 only checking to see which is better.
10085 2004-06-24 Marek Safar <marek.safar@seznam.cz>
10087 * cs-parser.jay: Added error CS0210 test.
10089 2004-06-24 Marek Safar <marek.safar@seznam.cz>
10091 * cs-parser.jay: Added error CS0134 test.
10093 2004-06-24 Marek Safar <marek.safar@seznam.cz>
10096 * cs-parser.jay: Added error CS0145 test.
10098 2004-06-24 Marek Safar <marek.safar@seznam.cz>
10100 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
10102 2004-06-23 Ben Maurer <bmaurer@ximian.com>
10104 * expression.cs (StackAlloc.Resolve): The argument may not
10105 be a constant; deal with this case.
10107 2004-06-23 Marek Safar <marek.safar@seznam.cz>
10109 * attribute.cs (IndexerName_GetIndexerName): Renamed to
10110 GetIndexerAttributeValue.
10111 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
10113 * class.cs (Indexer.Define): Added error tests for CS0415,
10116 2004-06-23 Miguel de Icaza <miguel@ximian.com>
10118 * attribute.cs (Attribute.Resolve): Keep field code in sync with
10121 2004-06-23 Martin Baulig <martin@ximian.com>
10123 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
10124 neither return nor throw, reset the barrier as well. Fixes #60457.
10126 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
10128 * class.cs : EventAttributes is now set to None by default.
10129 This fixes bug #60459.
10131 2004-06-18 Marek Safar <marek.safar@seznam.cz>
10134 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
10135 Don't throw exception but return null (it's sufficient now).
10137 2004-06-18 Marek Safar <marek.safar@seznam.cz>
10139 * typemanager.cs (GetArgumentTypes): Faster implementation.
10141 2004-06-18 Martin Baulig <martin@ximian.com>
10143 * attribute.cs (Attribute.Resolve): Check whether we're an
10144 EmptyCast which a Constant child. Fixes #60333.
10146 2004-06-17 Ben Maurer <bmaurer@ximian.com>
10148 * statement.cs (EmitCollectionForeach): Account for the fact that
10149 not all valuetypes are in areas which we can take the address of.
10150 For these variables, we store to a temporary variable. Also, make
10151 sure that we dont emit a `callvirt' on a valuetype method.
10153 2004-06-15 Marek Safar <marek.safar@seznam.cz>
10155 * expression.cs (StackAlloc.DoReSolve): Added test for
10156 negative parameter (CS0247).
10158 2004-06-15 Marek Safar <marek.safar@seznam.cz>
10161 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
10163 2004-06-15 Marek Safar <marek.safar@seznam.cz>
10166 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
10169 2004-06-14 Marek Safar <marek.safar@seznam.cz>
10171 Fix bug #58254 & cs1555.cs, cs1556.cs
10172 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
10174 2004-06-14 Marek Safar <marek.safar@seznam.cz>
10176 * cs-parser.jay: Added error CS1669 test for indexers.
10178 2004-06-18 Martin Baulig <martin@ximian.com>
10180 * generics.cs (GenericMethod.ctor): Don't take an Attributes
10181 argument. Fixes #60441.
10183 2004-06-16 Ben Maurer <bmaurer@ximian.com>
10184 * ecore.cs (MethodGroupExpr.Name): Revert Martin's patch.
10185 The name needs to have the actual name of the method in order
10186 for other tests (such as the one in OverloadResolve for Invoke
10187 on a delegate) to work. As well, it does not really help
10188 error reporting because the method group had multiple methods.
10189 * Makefile: Remove MCS_DEBUG, you can enable with the DEBUG_FLAGS.
10190 Make profiling work.
10192 2004-06-13 Martin Baulig <martin@ximian.com>
10194 * cs-parser.jay: Don't allow generic attributes.
10196 2004-06-13 Martin Baulig <martin@ximian.com>
10198 * class.cs (MemberBase.DoDefineBase): New protected method.
10199 (MemberBase.DoDefine): Compute the `flags' in the new
10200 DoDefineBase() which must be called first.
10201 (Method.Define): Call DoDefineBase() first so we have the flags
10202 when defining the generic method.
10204 * cs-parser.jay (interface_method_declaration): Support generic methods.
10206 2004-06-13 Martin Baulig <martin@ximian.com>
10208 * decl.cs (TypeName): Removed.
10209 (MemberName): Removed TypeName and MemberNow; now we just have
10212 * cs-parser.jay: Don't distinguish between type arguments and type
10213 parameters in the grammar and simplified the rules a bit. The
10214 reduce/reduce conflicts are now gone (except the one we inherited
10217 2004-06-11 Martin Baulig <martin@ximian.com>
10219 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
10220 call this twice: for params and varargs methods.
10222 2004-06-11 Marek Safar <marek.safar@seznam.cz>
10225 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
10227 2004-06-11 Marek Safar <marek.safar@seznam.cz>
10229 * attribute.cs (Attribute.GetValidTargets): Made public.
10232 (AbstractPropertyEventMethod): New class for better code sharing.
10233 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
10235 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
10237 2004-06-09 Martin Baulig <martin@ximian.com>
10239 * cs-parser.jay: Removed a reduce/reduce conflict.
10241 2004-06-03 Martin Baulig <martin@ximian.com>
10243 * generic.cs (ConstructedType.GetMemberAccess): Renamed to
10244 GetSimpleName() and return a SimpleName.
10246 * ecore.cs (SimpleName.Arguments): New public field.
10247 (SimpleName): Added overloaded ctor which takes an additional
10248 TypeArguments argument.
10249 (SimpleName.SimpleNameResolve): Added support for generic methods.
10250 (MethodGroupExpr.ResolveGeneric): New public method. The code was
10251 formerly in MemberAccess.DoResolve(), but we also need it in
10252 SimpleNameResolve().
10254 * expression.cs (MemberAccess.DoResolve): Use the new
10255 MethodGroupExpr.ResolveGeneric().
10257 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10259 * decl.cs: If possible, use lookuptypedirect here. We can only do
10260 this if there is no `.' after the namespace. Avoids using
10261 LookupType, which does lots of slow processing.
10262 (FindNestedType) New method, does what it says :-).
10263 * namespace.cs: use LookupTypeDirect.
10264 * rootcontext.cs: use membercache, if possible.
10265 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
10267 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10270 According to the spec,
10272 In a member access of the form E.I, if E is a single identifier,
10273 and if the meaning of E as a simple-name (§7.5.2) is a constant,
10274 field, property, localvariable, or parameter with the same type as
10275 the meaning of E as a type-name (§3.8), then both possible
10276 meanings of E are permitted.
10278 We did not check that E as a simple-name had the same type as E as
10281 This trivial check gives us 5-7% on bootstrap time.
10283 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10285 * expression.cs (Invocation.OverloadResolve): Avoid the
10286 use of hashtables and boxing here by allocating on demand.
10288 2004-05-30 Martin Baulig <martin@ximian.com>
10290 * rootcontext.cs (RootContext.LookupType): Don't cache things if
10291 we're doing a silent lookup. Don't try to lookup nested types in
10292 TypeManager.object_type (thanks to Ben Maurer).
10294 2004-05-30 Martin Baulig <martin@ximian.com>
10296 Committing a patch from Ben Maurer.
10298 * rootcontext.cs (RootContext.LookupType): Cache negative results.
10300 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10302 * convert.cs: add a trivial cache for overload operator resolution.
10304 2004-05-31 Marek Safar <marek.safar@seznam.cz>
10307 (AttributeTester.GetObsoleteAttribute): Returns instance of
10308 ObsoleteAttribute when type is obsolete.
10311 (TypeContainer.VerifyObsoleteAttribute): Override.
10312 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
10313 (MethodCode.VerifyObsoleteAttribute): Override.
10314 (MemberBase.VerifyObsoleteAttribute): Override.
10317 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
10318 and report proper error.
10321 (Delegate.VerifyObsoleteAttribute): Override.
10324 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
10325 and report proper error.
10326 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
10329 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
10333 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
10334 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
10335 Added test for ObsoleteAttribute.
10338 (Catch): Derived from Statement.
10340 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10342 * decl.cs: If possible, use lookuptypedirect here. We can only do
10343 this if there is no `.' after the namespace. Avoids using
10344 LookupType, which does lots of slow processing.
10345 (FindNestedType) New method, does what it says :-).
10346 * namespace.cs: use LookupTypeDirect.
10347 * rootcontext.cs: use membercache, if possible.
10348 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
10350 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10353 According to the spec,
10355 In a member access of the form E.I, if E is a single identifier,
10356 and if the meaning of E as a simple-name (§7.5.2) is a constant,
10357 field, property, localvariable, or parameter with the same type as
10358 the meaning of E as a type-name (§3.8), then both possible
10359 meanings of E are permitted.
10361 We did not check that E as a simple-name had the same type as E as
10364 This trivial check gives us 5-7% on bootstrap time.
10366 2004-05-30 Marek Safar <marek.safar@seznam.cz>
10368 Fixed bug #59071 & cs0160.cs
10369 * statement.cs (Try.Resolve): Check here whether order of catch
10370 clauses matches their dependencies.
10372 2004-05-30 Marek Safar <marek.safar@seznam.cz>
10375 * ecore.cs (SimpleName.SimpleNameResolve): Added test for
10378 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
10380 * expression.cs (Invocation.OverloadResolve): Avoid the
10381 use of hashtables and boxing here by allocating on demand.
10383 2004-05-30 Martin Baulig <martin@ximian.com>
10385 * rootcontext.cs (RootContext.LookupType): Don't cache things if
10386 we're doing a silent lookup. Don't try to lookup nested types in
10387 TypeManager.object_type (thanks to Ben Maurer).
10389 2004-05-30 Martin Baulig <martin@ximian.com>
10391 Committing a patch from Ben Maurer.
10393 * rootcontext.cs (RootContext.LookupType): Cache negative results.
10395 2004-05-29 Martin Baulig <martin@ximian.com>
10397 * class.cs (IMethodData.ShouldIgnore): New method.
10399 * typemanager.cs (TypeManager.MethodFlags): Don't take a
10400 `Location' argument, we don't need it anywhere. Use
10401 `IMethodData.ShouldIgnore ()' instead of
10402 `MethodData.GetMethodFlags ()'.
10403 (TypeManager.AddMethod): Removed.
10404 (TypeManager.AddMethod2): Renamed to AddMethod.
10406 2004-05-29 Martin Baulig <martin@ximian.com>
10408 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
10410 * convert.cs (Convert.ImplicitReferenceConversion): If we're
10411 converting from a class type S to an interface type and we already
10412 have an object on the stack, don't box it again. Fixes #52578.
10414 2004-05-29 Martin Baulig <martin@ximian.com>
10416 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
10417 Added support for `params' parameters. Fixes #59267.
10419 2004-05-29 Martin Baulig <martin@ximian.com>
10421 * literal.cs (NullPointer): Provide a private .ctor which sets
10422 `type' to TypeManager.object_type. Fixes #59048.
10424 2004-05-29 Martin Baulig <martin@ximian.com>
10426 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
10427 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
10429 * ecore.cs (EventExpr.instance_expr): Make the field private.
10431 2004-05-26 Marek Safar <marek.safar@seznam.cz>
10433 Fixed bug #50080 & cs0214-2.cs
10434 * expression.cs (Cast.DoResolve): Check unsafe context here.
10436 * statement.cs (Resolve.DoResolve): Likewise.
10438 2004-05-26 Martin Baulig <martin@ximian.com>
10440 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
10442 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
10443 (RootContext.LookupType): Pass down the `silent' flag.
10445 2004-05-25 Martin Baulig <martin@ximian.com>
10448 (MethodGroupExpr.IdenticalTypeName): New public property.
10449 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
10450 expression actually refers to a type.
10452 2004-05-25 Martin Baulig <martin@ximian.com>
10454 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
10455 for #56176 and made it actually work.
10457 2004-05-25 Martin Baulig <martin@ximian.com>
10459 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
10460 (FieldExpr, PropertyExpr): Override and implement
10461 CacheTemporaries. Fixes #52279.
10463 2004-05-25 Miguel de Icaza <miguel@ximian.com>
10465 * location.cs: In the new compiler listing a file twice is a
10466 warning, not an error.
10468 2004-05-24 Martin Baulig <martin@ximian.com>
10470 * enum.cs (Enum.DefineType): For the `BaseType' to be a
10471 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
10473 2004-05-24 Martin Baulig <martin@ximian.com>
10475 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
10476 walking the `using' list. Fixes #53921.
10478 2004-05-24 Martin Baulig <martin@ximian.com>
10480 * const.cs (Const.LookupConstantValue): Added support for
10481 EmptyCast's; fixes #55251.
10483 2004-05-24 Martin Baulig <martin@ximian.com>
10485 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
10486 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
10487 which does the CS0135 check. The reason is that we first need to
10488 check whether the variable actually exists.
10490 2004-05-24 Martin Baulig <martin@ximian.com>
10492 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
10493 than RootContext.LookupType() to find the explicit interface
10494 type. Fixes #58584.
10496 2004-05-24 Raja R Harinath <rharinath@novell.com>
10498 * Makefile: Simplify. Use executable.make.
10499 * mcs.exe.sources: New file. List of sources of mcs.exe.
10501 2004-05-24 Anders Carlsson <andersca@gnome.org>
10505 Use the invariant culture when doing String.Compare for CLS case
10508 2004-05-23 Martin Baulig <martin@ximian.com>
10510 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
10511 don't have any dots. Fixes #52622, added cs0246-8.cs.
10513 * namespace.cs (NamespaceEntry.Lookup): Likewise.
10515 2004-05-23 Marek Safar <marek.safar@seznam.cz>
10517 * class.cs (MemberBase.Define): Reuse MemberType member for
10518 resolved type. Other methods can use it too.
10520 2004-05-23 Martin Baulig <martin@ximian.com>
10522 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
10523 the variable also exists in the current block (otherwise, we need
10524 to report a CS0103). Fixes #58670.
10526 2004-05-23 Martin Baulig <martin@ximian.com>
10528 * flowanalysis.cs (Reachability.Reachable): Compute this
10529 on-the-fly rather than storing it as a field.
10531 2004-05-23 Martin Baulig <martin@ximian.com>
10533 * flowanalysis.cs (Reachability.And): Manually compute the
10534 resulting `barrier' from the reachability.
10536 2004-05-23 Marek Safar <marek.safar@seznam.cz>
10539 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
10540 instance of ObsoleteAttribute when symbol is obsolete.
10543 (IMethodData): Extended interface for ObsoleteAttribute support.
10545 2004-05-22 Marek Safar <marek.safar@seznam.cz>
10547 * attribute.cs: Fix bug #55970
10549 2004-05-22 Marek Safar <marek.safar@seznam.cz>
10553 (GetObsoleteAttribute): New method. Creates the instance of
10555 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
10556 ObsoleteAttribute when member is obsolete.
10557 (AttributeTester.Report_ObsoleteMessage): Common method for
10558 Obsolete error/warning reporting.
10561 (TypeContainer.base_classs_type): New member for storing parent type.
10564 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
10565 for this MemberCore.
10567 2004-05-21 Marek Safar <marek.safar@seznam.cz>
10569 * attribute.cs, const.cs: Fix bug #58590
10571 2004-05-21 Martin Baulig <martin@ximian.com>
10573 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
10574 out parameters if the end of the method is unreachable. Fixes
10577 2004-05-21 Marek Safar <marek.safar@seznam.cz>
10579 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
10580 Hari was right, why extra method.
10582 2004-05-21 Marek Safar <marek.safar@seznam.cz>
10584 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
10586 2004-05-20 Martin Baulig <martin@ximian.com>
10588 * delegate.cs: Convert this file to Unix mode - like the original
10591 2004-05-20 Martin Baulig <martin@ximian.com>
10593 * attribute.cs: Convert this file to Unix mode - like the original
10596 2004-05-19 Marek Safar <marek.safar@seznam.cz>
10598 Fix bug #58688 (MCS does not report error when the same attribute
10601 * attribute.cs (Attribute.Emit): Distinction between null and default.
10603 2004-05-19 Raja R Harinath <rharinath@novell.com>
10605 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
10606 of a top-level attribute without an attribute target.
10607 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
10609 (Attribute.Conditional_GetConditionName),
10610 (Attribute.Obsolete_GetObsoleteMessage): Update.
10611 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
10612 part of ScanForIndexerName.
10613 (Attribute.CanIgnoreInvalidAttribute): New function.
10614 (Attribute.ScanForIndexerName): Move to ...
10615 (Attributes.ScanForIndexerName): ... here.
10616 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
10617 (Attributes.Search): New internal variant that can choose not to
10618 complain if types aren't resolved. The original signature now
10620 (Attributes.GetClsCompliantAttribute): Use internal variant, with
10621 complaints suppressed.
10622 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
10623 only if it not useful.
10624 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
10625 top-level for attributes that are shared between the assembly
10626 and a top-level class.
10627 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
10628 * class.cs: Update to reflect changes.
10629 (DefineIndexers): Fuse loops.
10630 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
10631 a couple more variants of attribute names.
10633 2004-05-18 Marek Safar <marek.safar@seznam.cz>
10635 Fix bug #52585 (Implemented explicit attribute declaration)
10638 (Attributable.ValidAttributeTargets): New abstract method. It gets
10639 list of valid attribute targets for explicit target declaration.
10640 (Attribute.Target): It holds target itself.
10641 (AttributeSection): Removed.
10642 (Attribute.CheckTargets): New method. It checks whether attribute
10643 target is valid for the current element.
10646 (EventProperty): New class. For events that are declared like
10647 property (with add and remove accessors).
10648 (EventField): New class. For events that are declared like field.
10651 * cs-parser.jay: Implemented explicit attribute target declaration.
10653 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
10654 Override ValidAttributeTargets.
10657 (ReturnParameter): Class for applying custom attributes on
10659 (ParameterAtribute): New class. Class for applying custom
10660 attributes on the parameter type.
10662 2004-05-17 Miguel de Icaza <miguel@ximian.com>
10664 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
10667 (Method): Allow UNSAFE here.
10669 * modifiers.cs: Support unsafe reporting.
10671 2004-05-17 Marek Safar <marek.safar@seznam.cz>
10673 * decl.cs: Fix bug #58478.
10675 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10677 * statement.cs: When checking for unreachable code on an EmptyStatement,
10678 set the location. Fixes bug #58488.
10680 2004-05-13 Miguel de Icaza <miguel@ximian.com>
10682 * driver.cs: Add -pkg handling.
10684 From Gonzalo: UseShelLExecute=false
10686 2004-05-12 Marek Safar <marek.safar@seznam.cz>
10689 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
10691 (Attribute.IsClsCompliaceRequired): Moved to base for better
10693 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
10694 when attribute is AttributeUsageAttribute.
10695 (Attribute.GetValidTargets): Simplified.
10696 (Attribute.GetAttributeUsage): New method returns AttributeUsage
10697 attribute for this type.
10698 (Attribute.ApplyAttributes): Method renamed to Emit and make
10700 (GlobalAttributeSection): New class for special handling of global
10701 attributes (assembly, module).
10702 (AttributeSection.Emit): New method.
10704 * class.cs: Implemented Attributable abstract methods.
10705 (MethodCore.LabelParameters): Moved to Parameter class.
10706 (Accessor): Is back simple class.
10707 (PropertyMethod): Implemented Attributable abstract class.
10708 (DelegateMethod): Implemented Attributable abstract class.
10709 (Event): New constructor for disctintion between normal Event
10710 and Event with accessors.
10712 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
10714 * codegen.cs, const.cs, decl.cs, delegate.cs:
10715 (CommonAssemblyModulClass): Implemented Attributable abstract class
10718 * enum.cs: Implement IAttributeSupport interface.
10719 (EnumMember): New class for emum members. Implemented Attributable
10723 (ParameterBase): Is abstract.
10724 (ReturnParameter): New class for easier [return:] attribute handling.
10726 * typemanager.cs: Removed builder_to_attr.
10728 2004-05-11 Raja R Harinath <rharinath@novell.com>
10731 * attribute.cs (Attribute.GetPositionalValue): New function.
10732 * class.cs (TypeContainer.VerifyMembers): New function.
10733 (TypeContainer.Emit): Use it.
10734 (ClassOrStruct): New base class for Class and Struct.
10735 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
10736 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
10738 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
10739 then each non-static field should have a FieldOffset attribute.
10740 Otherwise, none of the fields should have a FieldOffset attribute.
10741 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
10742 and FieldOffset attributes.
10743 * typemanager.cs (TypeManager.struct_layout_attribute_type)
10744 (TypeManager.field_offset_attribute_type): New core types.
10745 (TypeManager.InitCoreTypes): Initialize them.
10747 2004-05-11 Michal Moskal <malekith@pld-linux.org>
10749 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
10750 Return correct type.
10753 2004-05-09 Miguel de Icaza <miguel@ximian.com>
10755 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
10756 be implicitly converted to ulong.
10758 * expression.cs: The logic for allowing operator &, | and ^ worked
10759 was wrong, it worked before because we did not report an error in
10760 an else branch. Fixes 57895.
10762 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
10763 allow volatile fields to be reference types.
10765 2004-05-07 Miguel de Icaza <miguel@ximian.com>
10767 * driver.cs: Add support for /debug-
10769 2004-05-07 Raja R Harinath <rharinath@novell.com>
10771 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
10772 Add a 'complain' parameter to silence errors.
10773 (Attribute.Resolve): Update to changes. Put in sanity check to catch
10774 silently overlooked type-resolutions.
10775 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
10776 to reflect changes.
10777 (Attributes.Search): New function.
10778 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
10779 (Attributes.GetAttributeFullName): Remove hack.
10780 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
10781 Update to reflect changes.
10782 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
10783 Use Attributes.Search instead of nested loops.
10785 2004-05-07 Marek Safar <marek.safar@seznam.cz>
10788 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
10789 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
10790 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
10792 * report.cs: (Report.Warning): Renamed to Warning_T because of
10793 parameter collision.
10795 2004-05-05 Raja R Harinath <rharinath@novell.com>
10797 * expression.cs (MemberAccess.ResolveMemberAccess):
10798 Exit with non-zero status after Report.Error.
10799 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
10801 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
10803 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
10805 * support.cs: Don't hang when the file is empty.
10807 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
10809 * support.cs: In SeekableStreamReader, compute the preamble size of the
10810 underlying stream. Position changes should take into account that initial
10813 2004-05-03 Todd Berman <tberman@sevenl.net>
10815 * driver.cs: remove unused GetSysVersion function.
10817 2004-05-03 Todd Berman <tberman@sevenl.net>
10819 * driver.cs: Remove the hack from saturday, as well as the hack
10820 from jackson (LoadAssemblyFromGac), also adds the CWD to the
10821 link_paths to get that bit proper.
10823 2004-05-01 Todd Berman <tberman@sevenl.net>
10825 * driver.cs: Try a LoadFrom before a Load, this checks the current
10826 path. This is currently a bug in mono that is be fixed, however, this
10827 provides a workaround for now. This will be removed when the bug
10830 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
10832 * CryptoConvert.cs: Updated to latest version. Fix issue with
10833 incomplete key pairs (#57941).
10835 2004-05-01 Todd Berman <tberman@sevenl.net>
10837 * driver.cs: Remove '.' from path_chars, now System.* loads properly
10840 2004-04-30 Jackson Harper <jackson@ximian.com>
10842 * codegen.cs: Open keys readonly.
10844 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10846 * typemanager.cs: don't report cyclic struct layout when a struct
10847 contains 2 or more fields of the same type. Failed for Pango.AttrShape
10848 which has 2 Pango.Rectangle fields.
10850 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
10852 * expression.cs: Handle IntPtr comparisons with IL code
10853 rather than a method call.
10855 2004-04-29 Martin Baulig <martin@ximian.com>
10857 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
10858 the list of PropertyInfo's in class hierarchy and find the
10859 accessor. Fixes #56013.
10861 2004-04-29 Martin Baulig <martin@ximian.com>
10863 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
10865 2004-04-29 Martin Baulig <martin@ximian.com>
10867 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
10869 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
10871 2004-04-29 Martin Baulig <martin@ximian.com>
10873 * class.cs (ConstructorInitializer.Resolve): Check whether the
10874 parent .ctor is accessible. Fixes #52146.
10876 2004-04-29 Martin Baulig <martin@ximian.com>
10878 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
10880 * statement.cs (Using.EmitLocalVariableDecls): Use
10881 TypeManager.idisposable_type, not typeof (IDisposable).
10882 (Foreach.EmitCollectionForeach): Added support for valuetypes.
10884 2004-04-29 Martin Baulig <martin@ximian.com>
10886 * class.cs (Event.Define): Don't emit the field and don't set
10887 RTSpecialName and SpecialName for events on interfaces. Fixes
10890 2004-04-29 Raja R Harinath <rharinath@novell.com>
10892 Refactor Attribute.ApplyAttributes.
10893 * attribute.cs (Attributable): New base class for objects that can
10894 have Attributes applied on them.
10895 (Attribute): Make AttributeUsage fields public.
10896 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
10897 (Attribute.IsInternalCall): New property.
10898 (Attribute.UsageAttr): Convert to a public read-only property.
10899 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
10900 (Attribute.ResolveType, Attribute.Resolve)
10901 (Attribute.ScanForIndexerName): Update to reflect changes.
10902 (Attribute.CheckAttributeTarget): Re-format.
10903 (Attribute.ApplyAttributes): Refactor, to various
10904 Attributable.ApplyAttributeBuilder methods.
10905 * decl.cs (MemberCore): Make Attributable.
10906 * class.cs (Accessor): Make Attributable.
10907 (MethodData.ApplyAttributes): Use proper attribute types, not
10909 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
10910 (TypeContainer.ApplyAttributeBuilder)
10911 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
10912 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
10913 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
10914 (Operator.ApplyAttributeBuilder): New factored-out methods.
10915 * const.cs (Const.ApplyAttributeBuilder): Likewise.
10916 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
10917 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
10918 * parameter.cs (ParameterBase): New Attributable base class
10919 that can also represent Return types.
10920 (Parameter): Update to the changes.
10922 2004-04-29 Jackson Harper <jackson@ximian.com>
10924 * driver.cs: Prefer the corlib system version when looking for
10925 assemblies in the GAC. This is still a hack, but its a better hack
10928 2004-04-29 Marek Safar <marek.safar@seznam.cz>
10930 * decl.cs, enum.cs: Improved error 3005 reporting.
10932 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
10933 (related_symbols): New private member for list of symbols
10934 related to reported error/warning.
10936 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
10938 2004-04-29 Martin Baulig <martin@ximian.com>
10940 * ecore.cs (Expression.Constantify): If we're an enum and
10941 TypeManager.TypeToCoreType() doesn't give us another type, use
10942 t.UnderlyingSystemType. Fixes #56178.
10944 2004-04-29 Martin Baulig <martin@ximian.com>
10946 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
10947 interfaces and for each interface, only add members directly
10948 declared in that interface. Fixes #53255.
10950 2004-04-28 Martin Baulig <martin@ximian.com>
10952 * expression.cs (ConditionalLogicalOperator): Use a temporary
10953 variable for `left' to avoid that we evaluate it more than once;
10956 2004-04-28 Martin Baulig <martin@ximian.com>
10958 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
10961 2004-04-28 Martin Baulig <martin@ximian.com>
10963 * statement.cs (LocalInfo.Resolve): Check whether the type is not
10966 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
10967 whether the type is not void (CS1547).
10969 2004-04-28 Martin Baulig <martin@ximian.com>
10971 * expression.cs (Unary.DoResolveLValue): Override this and report
10972 CS0131 for anything but Operator.Indirection.
10974 2004-04-28 Martin Baulig <martin@ximian.com>
10976 Committing a patch from Ben Maurer; see bug #50820.
10978 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
10981 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
10984 2004-04-28 Martin Baulig <martin@ximian.com>
10986 Committing a patch from Ben Maurer; see bug #50820.
10988 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
10991 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
10994 2004-04-28 Martin Baulig <martin@ximian.com>
10996 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
10997 (Block.AddLabel): Call DoLookupLabel() to only search in the
11000 2004-04-28 Martin Baulig <martin@ximian.com>
11002 * cfold.cs (ConstantFold.BinaryFold): Added special support for
11003 comparing StringConstants and NullLiterals in Equality and Inequality.
11005 2004-04-28 Jackson Harper <jackson@ximian.com>
11007 * driver.cs: Attempt to load referenced assemblies from the
11008 GAC. This is the quick and dirty version of this method that
11009 doesnt take into account versions and just takes the first
11010 canidate found. Will be good enough for now as we will not have more
11011 then one version installed into the GAC until I update this method.
11013 2004-04-28 Martin Baulig <martin@ximian.com>
11015 * typemanager.cs (TypeManager.CheckStructCycles): New public
11016 static method to check for cycles in the struct layout.
11018 * rootcontext.cs (RootContext.PopulateTypes): Call
11019 TypeManager.CheckStructCycles() for each TypeContainer.
11020 [Note: We only need to visit each type once.]
11022 2004-04-28 Martin Baulig <martin@ximian.com>
11024 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
11026 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
11027 success and added `out object value'. Use a `bool resolved' field
11028 to check whether we've already been called rather than
11029 `ConstantValue != null' since this breaks for NullLiterals.
11031 2004-04-28 Raja R Harinath <rharinath@novell.com>
11033 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
11034 setting of this flag, since the 'set' method may be non-public.
11036 2004-04-28 Raja R Harinath <rharinath@novell.com>
11038 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
11039 check on current_vector.Block.
11041 2004-04-27 Martin Baulig <martin@ximian.com>
11043 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
11044 a field initializer. Fixes #56459.
11046 2004-04-27 Martin Baulig <martin@ximian.com>
11048 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
11049 we're not attempting to use an indexer. Fixes #52154.
11051 2004-04-27 Martin Baulig <martin@ximian.com>
11053 * statement.cs (Return): Don't create a return label if we don't
11054 need it; reverts my change from January 20th. Thanks to Ben
11057 2004-04-27 Martin Baulig <martin@ximian.com>
11059 According to the spec, `goto' can only leave a nested scope, but
11062 * statement.cs (Block.LookupLabel): Only lookup in the current
11063 block, don't recurse into parent or child blocks.
11064 (Block.AddLabel): Check in parent and child blocks, report
11065 CS0140/CS0158 if we find a duplicate.
11066 (Block): Removed this indexer for label lookups.
11067 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
11068 this already does the error reporting for us.
11071 (FlowBranching.UsageVector.Block): New public variable; may be null.
11072 (FlowBranching.CreateSibling): Added `Block' argument.
11073 (FlowBranching.LookupLabel): New public virtual method. Lookup a
11074 label for the target of a `goto' and check whether we're not
11075 leaving a `finally'.
11077 2004-04-27 Martin Baulig <martin@ximian.com>
11079 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
11080 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
11083 2004-04-27 Martin Baulig <martin@ximian.com>
11085 * statement.cs (Block.AddLabel): Also check for implicit blocks
11086 and added a CS0158 check.
11088 2004-04-27 Martin Baulig <martin@ximian.com>
11090 * flowanalysis.cs (FlowBranchingLoop): New class.
11091 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
11092 UsageVector's instead of an ArrayList.
11093 (FlowBranching.Label): Likewise.
11094 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
11095 (FlowBranching.AddBreakVector): New method.
11097 2004-04-27 Miguel de Icaza <miguel@ximian.com>
11099 * attribute.cs: Small regression fix: only convert the type if we
11100 the type is different, fixes System.Drawing build.
11102 2004-04-27 Martin Baulig <martin@ximian.com>
11104 * attribute.cs (Attribute.Resolve): If we have a constant value
11105 for a named field or property, implicity convert it to the correct
11108 2004-04-27 Raja R Harinath <rharinath@novell.com>
11110 * statement.cs (Block.Block): Implicit blocks share
11111 'child_variable_names' fields with parent blocks.
11112 (Block.AddChildVariableNames): Remove.
11113 (Block.AddVariable): Mark variable as "used by a child block" in
11114 every surrounding block.
11115 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
11116 been used in a child block, complain about violation of "Invariant
11117 meaning in blocks" rule.
11118 * cs-parser.jay (declare_local_variables): Don't use
11119 AddChildVariableNames.
11120 (foreach_statement): Don't create an implicit block: 'foreach'
11121 introduces a scope.
11123 2004-04-23 Miguel de Icaza <miguel@ximian.com>
11125 * convert.cs (ImplicitNumericConversion): 0 is also positive when
11126 converting from 0L to ulong. Fixes 57522.
11128 2004-04-22 Marek Safar <marek.safar@seznam.cz>
11130 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
11131 derived class hides via 'new' keyword field from base class (test-242.cs).
11132 TODO: Handle this in the more general way.
11134 * class.cs (CheckBase): Ditto.
11136 2004-04-22 Marek Safar <marek.safar@seznam.cz>
11138 * decl.cs (caching_flags): New member for storing cached values
11140 (MemberCore.Flags): New enum where bit flags for caching_flags
11142 (MemberCore.cls_compliance): Moved to caching_flags.
11143 (DeclSpace.Created): Moved to caching_flags.
11145 * class.cs: Use caching_flags instead of DeclSpace.Created
11147 2004-04-21 Miguel de Icaza <miguel@ximian.com>
11149 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
11150 if we are only a derived class, not a nested class.
11152 * typemanager.cs: Same as above, but do this at the MemberLookup
11153 level (used by field and methods, properties are handled in
11154 PropertyExpr). Allow for the qualified access if we are a nested
11157 2004-04-21 Marek Safar <marek.safar@seznam.cz>
11159 * class.cs: Refactoring.
11160 (IMethodData): New inteface; Holds links to parent members
11161 to avoid member duplication (reduced memory allocation).
11162 (Method): Implemented IMethodData interface.
11163 (PropertyBase): New inner classes for get/set methods.
11164 (PropertyBase.PropertyMethod): Implemented IMethodData interface
11165 (Event): New inner classes for add/remove methods.
11166 (Event.DelegateMethod): Implemented IMethodData interface.
11168 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
11169 EmitContext (related to class.cs refactoring).
11171 2004-04-21 Raja R Harinath <rharinath@novell.com>
11173 * delegate.cs (Delegate.VerifyApplicability): If the number of
11174 arguments are the same as the number of parameters, first try to
11175 verify applicability ignoring any 'params' modifier on the last
11179 2004-04-08 Martin Baulig <martin@ximian.com>
11181 Merged latest changes into gmcs. Please keep this comment in
11182 here, it makes it easier for me to see what changed in MCS since
11183 the last time I merged.
11185 2004-04-16 Raja R Harinath <rharinath@novell.com>
11187 * class.cs (TypeContainer.AddIndexer): Use
11188 'ExplicitInterfaceName' to determine if interface name was
11189 explicitly specified. 'InterfaceType' is not initialized at this time.
11190 (TypeContainer.DefineIndexers): Remove use of temporary list. The
11191 Indexers array is already in the required order. Initialize
11192 'IndexerName' only if there are normal indexers.
11193 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
11194 (TypeContainer.Emit): Emit DefaultMember attribute only if
11195 IndexerName is initialized.
11198 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
11200 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
11203 2004-04-15 Raja R Harinath <rharinath@novell.com>
11205 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
11209 * attribute.cs (Attribute.Resolve): Check for duplicate named
11213 2004-04-15 Miguel de Icaza <miguel@ximian.com>
11215 * iterators.cs (MarkYield): track whether we are in an exception,
11216 and generate code accordingly. Use a temporary value to store the
11217 result for our state.
11219 I had ignored a bit the interaction of try/catch with iterators
11220 since their behavior was not entirely obvious, but now it is
11221 possible to verify that our behavior is the same as MS .NET 2.0
11225 2004-04-14 Miguel de Icaza <miguel@ximian.com>
11227 * iterators.cs: Avoid creating temporaries if there is no work to
11230 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
11231 Enumerations, use TypeManager.EnumToUnderlying and call
11234 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
11237 (This.Emit): Use EmitContext.EmitThis to emit our
11240 (This.EmitAssign): Ditto.
11242 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
11243 codepaths, we will move all the functionality into
11246 (FieldExpr.EmitAssign): Ditto.
11248 This fixes several hidden bugs that I uncovered while doing a code
11249 review of this today.
11251 * codegen.cs (EmitThis): reworked so the semantics are more clear
11252 and also support value types "this" instances.
11254 * iterators.cs: Changed so that for iterators in value types, we
11255 do not pass the value type as a parameter.
11257 Initialization of the enumerator helpers is now done in the caller
11258 instead of passing the parameters to the constructors and having
11259 the constructor set the fields.
11261 The fields have now `assembly' visibility instead of private.
11263 2004-04-11 Miguel de Icaza <miguel@ximian.com>
11265 * expression.cs (Argument.Resolve): Check if fields passed as ref
11266 or out are contained in a MarshalByRefObject.
11268 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
11269 another compiler type.
11271 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
11273 * class.cs (Indexer.Define): use the new name checking method.
11274 Also, return false on an error.
11275 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
11276 (is_identifier_[start/part]_character): make static.
11278 2004-04-10 Miguel de Icaza <miguel@ximian.com>
11280 * expression.cs (Binary.ResolveOperator): Do no append strings
11281 twice: since we can be invoked more than once (array evaluation)
11282 on the same concatenation, take care of this here. Based on a fix
11283 from Ben (bug #56454)
11285 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
11287 * codegen.cs: Fix another case where CS1548 must be reported (when
11288 delay-sign isn't specified and no private is available #56564). Fix
11289 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
11290 error when MCS is used on the MS runtime and we need to delay-sign
11291 (which seems unsupported by AssemblyBuilder - see #56621).
11293 2004-04-08 Marek Safar <marek.safar@seznam.cz>
11295 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
11296 (TypeManager.ComputeNamespaces): Faster implementation for
11299 * compiler.csproj: Updated AssemblyName to mcs.
11301 2004-05-11 Jackson Harper <jackson@ximian.com>
11303 * Makefile: Preserve MONO_PATH
11305 2004-05-11 Jackson Harper <jackson@ximian.com>
11307 * Makefile: Use mono and mcs to build gmcs
11309 2004-05-03 Miguel de Icaza <miguel@ximian.com>
11311 * codegen.cs: Add patch from Robert Shade
11312 <rshade@dvsconsulting.com>, use FileAccess.Read on the keyfile, to
11315 2004-05-02 Sebastien Pouliot <sebastien@ximian.com>
11317 * CryptoConvert.cs: Updated to latest version. Fix issue with
11318 incomplete key pairs (#57941).
11320 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
11322 * codegen.cs: Fix another case where CS1548 must be reported (when
11323 delay-sign isn't specified and no private is available #56564). Fix
11324 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
11325 error when MCS is used on the MS runtime and we need to delay-sign
11326 (which seems unsupported by AssemblyBuilder - see #56621).
11328 2004-04-29 Jackson Harper <jackson@ximian.com>
11330 * Makefile: Set MONO_PATH to use the bootstrap corlib
11331 * driver.cs: Check the GAC for referenced assemblies.
11333 2004-04-29 Martin Baulig <martin@ximian.com>
11335 * Makefile (gmcs.exe): Set MONO_PATH to use `../class/lib/net_2_0'.
11337 2004-04-07 Martin Baulig <martin@ximian.com>
11339 * expression.cs (Binary.ResolveOperator): Added special case for
11340 Equality/Inequality between a type parameter and a null literal.
11342 2004-04-07 Martin Baulig <martin@ximian.com>
11344 * convert.cs: Check null literal -> type parameter conversions.
11346 2004-04-07 Martin Baulig <martin@ximian.com>
11348 * generic.cs (ConstructedType.CheckConstraints): Enforce the
11349 `class' and `struct' constraints.
11351 2004-04-07 Martin Baulig <martin@ximian.com>
11353 * generic.cs (SpecialConstraint): New public enum.
11354 (Constraints.Resolve): Added support for the `class' and `struct'
11357 * cs-parser.jay (type_parameter_constraint): Added support for the
11358 `class' and `struct' constraints.
11360 2004-04-07 Martin Baulig <martin@ximian.com>
11362 * support.cs (GenericConstraints): Replaced `Types' by
11363 `ClassConstraint' and `InterfaceConstraints'; added
11364 `HasClassConstraint'.
11366 2004-04-07 Martin Baulig <martin@ximian.com>
11369 (Constraints.InterfaceConstraints): New public property.
11370 (Constraints.Types): Make this property public
11371 (TypeParameter): Implement IMemberContainer.
11372 (TypeParameter.Define): Take a `GenericTypeParameterBuilder'
11373 instead of a TypeBuilder/MethodBuilder; pass the interface
11374 constraints to TypeManager.AddTypeParameter().
11375 (TypeParameter.DefineType): Just take an EmitContext and no
11376 TypeBuilder/MethodBuilder. Use the new public API.
11378 * typemanager.cs (TypeManager.AddTypeParameter): Added
11379 `TypeExpr[]' argument; add the interfaces to the
11380 `builder_to_ifaces' hash.
11381 (TypeManager.LookupMemberContainer): For
11382 GenericTypeParameterBuilders, get the TypeParameter from the
11383 `builder_to_type_param'.
11384 (TypeManager.FindMembers): For GenericTypeParameterBuilders, get
11385 the TypeParameter and call FindMembers on it.
11387 2004-04-07 Martin Baulig <martin@ximian.com>
11390 (MethodCore.GenericMethod): Moved this field here from Method.
11391 (MethodCore.IsDuplicateImplementation): Take the number of type
11392 parameters into account if we're a generic method.
11394 * expression.cs (Invocation.InferTypeArguments): Don't return true
11395 if `arguments' is null; we still need to check whether we actually
11396 don't need to infer anything in this case.
11397 (MemberAccess): Merged the functionality from GenericMemberAccess
11400 * generic.cs (GenericMemberAccess): Removed.
11402 2004-04-05 Martin Baulig <martin@ximian.com>
11404 * decl.cs (MemberCore): For generic classes, interfaces and
11405 structs, `Name' now includes the number of type parameters
11406 ("Stack!1.Node!1").
11407 (DeclSpace.FindType): Removed the `num_type_args' argument; we now
11408 encode the number of type arguments in the type name.
11410 * expression.cs (Expression.MemberLookup): Removed the
11411 `num_type_args' argument; we now encode the number of type
11412 arguments in the type name.
11414 * ecore.cs (SimpleName): Encode the number of type arguments in
11415 the type name itself.
11417 * generic.cs (ConstructedType): Likewise.
11419 * tree.cs (Tree.RecordDecl): Take a `string' instead of a
11420 `MemberName'; we now include the number of type parameters in the
11423 * typemanager.cs (TypeManager.CheckGeneric): Removed.
11424 (TypeManager.MemberLookup): Removed the
11425 `num_type_args' argument; we now encode the number of type
11426 arguments in the type name.
11428 2004-04-03 Martin Baulig <martin@ximian.com>
11430 * decl.cs (MemberCore.ctor): Take a MemberName instead of a sting.
11431 (MemberCore.MemberName): Moved here from MemberBase.
11432 (DeclSpace.SetParameterInfo): Just take the constraints as an
11433 ArrayList; we already have the type parameters in our
11434 `MemberName'; also do the CS0080 reporting here.
11436 * cs-parser.jay (struct_declaration): Use `member_name' instead of
11437 `IDENTIFIER opt_type_parameter_list'; when constructing our
11438 `MemberName', it'll already include our type parameters.
11439 (class_declaration, interface_declaration): Likewise.
11440 (delegate_declaration): Likewise.
11441 (MakeName): Take a MemberName and return a MemberName.
11442 The following two changes are required to avoid shift/reduce conflicts:
11443 (member_name): Don't include a TypeName anymore; ie. this is now
11444 just 'IDENTIFIER opt_type_parameter_list'.
11445 (property_declaration, event_declaration): Use a
11446 `namespace_or_type_name' instead of a `member_name'.
11448 2004-04-03 Martin Baulig <martin@ximian.com>
11450 * decl.cs (MemberName): Renamed to `TypeName' and created a new
11451 `MemberName' class.
11452 (TypeName): Formerly known as MemberName.
11454 * namespace.cs (NamespaceEntry.UsingAlias): Take a `TypeName'
11455 instead of a `MemberName'.
11457 * cs-parser.jay (namespace_or_type_name): Create a TypeName.
11458 (member_name): New rule; create a MemberName.
11460 2004-04-02 Martin Baulig <martin@ximian.com>
11462 * namespace.cs (NamespaceEntry.VerifyUsing): Added error checking
11463 (CS0305 and CS0308).
11465 2004-04-02 Martin Baulig <martin@ximian.com>
11467 * generic.cs (GenericMemberAccess.ResolveAsTypeStep): Added
11468 support for nested types.
11470 2004-04-02 Martin Baulig <martin@ximian.com>
11472 * ecore.cs (IAlias): New public interface.
11473 (TypeExpr, TypeExpression): Implement IAlias.
11474 (TypeAliasExpression): New public class.
11476 * namespace.cs (Namespace): Implement IAlias.
11477 (Namespace.Lookup): Return an IAlias instead on an object.
11478 (Namespace.DefineName): Take an IAlias instead of an object.
11479 (NamespaceEntry.AliasEntry.Resolve): Return an IAlias instead of
11481 (NamespaceEntry.UsingAlias): Take a Membername instead of an
11483 (NamespaceEntry.LookupAlias): Return an IAlias instead on an
11485 (NamespaceEntry.Lookup): Likewise.
11487 * rootcontext.cs (RootContext.LookupType): Return a TypeExpr
11490 * decl.cs (DeclSpace): Implement IAlias.
11491 (DeclSpace.LookupAlias): Return an IAlias instead of a string.
11493 * generic.cs (ConstructedType): Improved error checking.
11495 2004-04-02 Martin Baulig <martin@ximian.com>
11497 * convert.cs: Added type parameter conversions.
11500 (UnboxCast.Emit): Emit an `unbox.any' for type params.
11501 (ClassCast.Emit): If the source type is a type parameter, box it.
11502 If the target type is a type parameter, emit an `unbox.any'
11503 instead of a `classcast'.1
11505 2004-04-01 Martin Baulig <martin@ximian.com>
11507 * cs-tokenizer.cs (parse_less_than): Allow Token.DOT.
11509 2004-04-01 Martin Baulig <martin@ximian.com>
11511 * generic.cs (ConstructedType.CheckConstraints): Use
11512 Convert.ImplicitStandardConversionExists(); user-defined implicit
11513 conversions are not allowed according to the spec.
11515 2004-03-30 Martin Baulig <martin@ximian.com>
11517 * expression.cs (New): Added support for type parameters.
11520 (TypeManager.activator_type): New public static field.
11521 (TypeManager.activator_create_instance): Likewise.
11523 2004-03-30 Martin Baulig <martin@ximian.com>
11525 * typemanager.cs (TypeManager.HasConstructorConstraint): New
11528 2004-03-30 Martin Baulig <martin@ximian.com>
11530 * generic.cs (ConstructedType.CheckConstraints): Actually follow
11531 the spec here: the argument type must be convertible to the
11534 2004-03-30 Martin Baulig <martin@ximian.com>
11537 (TypeParameter.Define, TypeParameter.DefineMethod): Call
11538 TypeManager.AddTypeParameter().
11539 (ConstructedType.CheckConstraints): Re-enable this and actually
11540 check whether we have a constructor constraint.
11543 (TypeManager.builder_to_type_param): New static field.
11544 (TypeManager.AddTypeParameter): New static method.
11545 (TypeManager.LookupTypeParameter): New public method.
11547 2004-03-30 Martin Baulig <martin@ximian.com>
11549 * generic.cs (TypeParameter.DefineType): Return a boolean and use
11550 the new API to actually define the constructor constraint.
11553 (TypeManager.new_constraint_attr_type): New static field.
11554 (TypeManager.InitCoreTypes): Initialize it.
11556 2004-03-30 Martin Baulig <martin@ximian.com>
11558 * generic.cs (Constraints): Completed error checking, use correct
11561 2004-03-29 Martin Baulig <martin@ximian.com>
11563 * delegate.cs (Delegate.VerifyMethod): Infer type arguments.
11565 * expression.cs (Invocation.InferTypeArguments): Added overloaded
11566 public version which takes a `ParameterData pd' instead of an
11569 2004-03-29 Martin Baulig <martin@ximian.com>
11571 * typemanager.cs (TypeManager.IsGenericMethod): Take a MethodBase,
11574 2004-03-29 Martin Baulig <martin@ximian.com>
11576 * expression.cs (Argument.ResolveMethodGroup): If we're a
11577 ConstructedType, call GetMemberAccess() on it.
11579 2004-03-29 Martin Baulig <martin@ximian.com>
11581 * class.cs (MethodBase.CheckGenericOverride): New abstract method.
11582 (MethodCore.CheckGenericOverride): When overriding a generic
11583 method, check whether the constraints match.
11585 * support.cs (GenericConstraints): New public interface.
11586 (ParameterData.GenericConstraints): New public method.
11588 * parameter.cs (Parameter.Resolve): Check whether we're a generic
11589 method parameter and compute our constraints if appropriate.
11590 (Parameter.GenericConstraints): New public property.
11592 * generic.cs (Constraints): Implement GenericConstraints.
11594 2004-03-29 Martin Baulig <martin@ximian.com>
11596 * decl.cs (MemberCache.FindMemberToOverride): Use
11597 `paramTypes [j].Equals (cmpAttrs [j])' instead of `=='.
11599 2004-03-29 Martin Baulig <martin@ximian.com>
11601 * generic.cs (GenericMethod.Define): Resolve our type parameters.
11603 2004-03-29 Martin Baulig <martin@ximian.com>
11605 * cs-parser.jay: Report CS0080 instead of -200 ("Constraints are
11606 not allowed on non-generic declarations").
11608 2004-03-29 Martin Baulig <martin@ximian.com>
11610 * expression.cs (Invocation.InferTypeArguments): Added overloaded
11611 public version of this method.
11613 * class.cs (MethodCore.IsDuplicateImplementation): Use
11614 Invocation.InferTypeArguments() to check this.
11616 2004-03-29 Martin Baulig <martin@ximian.com>
11618 * convert.cs: Use TypeManager.IsDelegateType() instead of
11619 comparing types correctly.
11621 2004-03-29 Martin Baulig <martin@ximian.com>
11623 * convert.cs: Use TypeManager.IsSubclassOf() instead of comparing
11624 types directly to make it work for generic instances.
11626 * typemanager.cs (TypeManager.IsSubclassOf): New static method.
11628 2004-03-29 Martin Baulig <martin@ximian.com>
11630 * typemanager.cs (TypeManager.MayBecomeEqualGenericTypes): Added
11631 support for arrays.
11633 2004-03-24 Martin Baulig <martin@ximian.com>
11635 * decl.cs (DeclSpace.FindType): Also use
11636 TypeManager.CheckGeneric() for types from the using clauses.
11638 2004-03-23 Martin Baulig <martin@ximian.com>
11640 * expression.cs (Invocation.OverloadResolve): Added `bool
11641 may_fail' argument and use it instead of the Location.IsNull() hack.
11643 2004-03-23 Martin Baulig <martin@ximian.com>
11645 * expression.cs (Invocation.InferType): Use correct type inference
11648 2004-03-23 Martin Baulig <martin@ximian.com>
11650 * ecore.cs (MethodGroupExpr.Name): Use
11651 TypeManager.CSharpSignature() instead of just the name.
11653 * expression.cs (Invocation.OverloadResolve): Provide better error
11655 (Invocation.DoResolve): OverloadResolve() never returns null
11656 without reporting an error, so removed the error -6 reporting here.
11658 2004-03-23 Martin Baulig <martin@ximian.com>
11660 * typemanager.cs (TypeManager.GetMethodFlags): Fixed the FIXME for
11663 * cs-parser.jay (delegate_declaration): Support generic delegates.
11665 * delegate.cs: Support generic delegates.
11667 2004-03-22 Martin Baulig <martin@ximian.com>
11669 * expression.cs (Invocation.InferParamsTypeArguments): New static
11670 method; does type inference for params arguments.
11672 2004-03-21 Martin Baulig <martin@ximian.com>
11674 * typemanager.cs (TypeManager.IsGenericMethod): New public static
11675 method; checks whether a method is a generic method.
11677 * expression.cs (Invocation.InferTypeArguments): New static method;
11678 infer type arguments for generic method invocation.
11680 * ecore.cs (MethodGroupExpr.HasTypeArguments): New public
11681 property; we set this to true if we're resolving a generic method
11682 invocation and the user specified type arguments, ie. we're not
11683 doing type inference.
11685 2004-03-20 Martin Baulig <martin@ximian.com>
11687 * class.cs (MethodData.DeclaringType): New public property.
11688 (MethodData.Define): Set DeclaringType here.
11689 (Operator.Define): Use OperatorMethod.MethodData.DeclaringType
11690 instead of OperatorMethodBuilder.DeclaringType.
11692 2004-03-20 Martin Baulig <martin@ximian.com>
11694 * cs-tokenizer.cs (xtoken): Return a special
11695 Token.DEFAULT_OPEN_PARENS for "`default' followed by open parens".
11697 * cs-parser.jay (default_value_expression): Switch to the new
11700 2004-03-19 Martin Baulig <martin@ximian.com>
11702 * decl.cs (MemberName): New class. We use this to "construct"
11703 namespace_or_type_name's.
11705 * generics.cs (TypeArguments.GetDeclarations): New public method;
11706 returns the type arguments as a string[] and reports a CS0081 if
11707 one of them is not an identifier.
11709 * class.cs (MemberBase): The .ctor now takes the name as a
11710 MemberName instead of a string.
11711 (MemberBase.ExplicitInterfaceName): Changed type from string to
11713 (MemberBase.DoDefine): If we're an explicit implementation, the
11714 InterfaceType may be a generic instance.
11716 * cs-parser.jay (namespace_or_type_name): Return a MemberName.
11717 (namespace_name): Call MemberName.GetName () to transform the
11718 MemberName into a string and ensure we don't have any type
11720 (type_name): Call MemberName.GetTypeExpression() to transfrom the
11721 MemberName into an expression.
11722 (method_header): Use namespace_or_type_name instead of member_name.
11724 2004-04-07 Miguel de Icaza <miguel@ximian.com>
11726 * rootcontext.cs: Add new types to the boot resolution.
11728 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
11729 MulticastDelegate is not allowed.
11731 * typemanager.cs: Add new types to lookup: System.TypedReference
11734 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
11735 check for TypedReference or ArgIterator, they are not allowed.
11737 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
11738 makes us properly catch 1510 in some conditions (see bug 56016 for
11741 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
11743 * CryptoConvert.cs: update from corlib version
11746 2004-04-05 Miguel de Icaza <miguel@ximian.com>
11748 * class.cs (Indexer.Define): Check indexername declaration
11750 2004-04-05 Marek Safar <marek.safar@seznam.cz>
11752 * attribute.cs (IsClsCompliant): Fixed problem with handling
11753 all three states (compliant, not-compliant, undetected).
11755 2004-03-30 Marek Safar <marek.safar@seznam.cz>
11757 * attribute.cs (Attribute): Location is now public.
11758 (Resolve): Store resolved arguments (pos_values) in attribute class.
11759 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
11760 (GetClsCompliantAttributeValue): New method that gets
11761 CLSCompliantAttribute value.
11762 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
11763 if exists else null.
11764 (AttributeTester): New class for CLS-Compliant verification routines.
11766 * class.cs (Emit): Add CLS-Compliant verification.
11767 (Method.GetSignatureForError): Implemented.
11768 (Constructor.GetSignatureForError): Implemented
11769 (Constructor.HasCompliantArgs): Returns if constructor has
11770 CLS-Compliant arguments.
11771 (Constructor.Emit): Override.
11772 (Construcor.IsIdentifierClsCompliant): New method; For constructors
11773 is needed to test only parameters.
11774 (FieldBase.GetSignatureForError): Implemented.
11775 (TypeContainer): New member for storing base interfaces.
11776 (TypeContainer.FindMembers): Search in base interfaces too.
11778 * codegen.cs (GetClsComplianceAttribute): New method that gets
11779 assembly or module CLSCompliantAttribute value.
11780 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
11782 (ModuleClass.Emit): Add error 3012 test.
11784 * const.cs (Emit): Override and call base for CLS-Compliant tests.
11786 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
11787 state for all decl types.
11788 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
11789 if CLS-Compliant tests are required.
11790 (IsClsCompliaceRequired): New method. Analyze whether code
11791 must be CLS-Compliant.
11792 (IsExposedFromAssembly): New method. Returns true when MemberCore
11793 is exposed from assembly.
11794 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
11795 value or gets cached value.
11796 (HasClsCompliantAttribute): New method. Returns true if MemberCore
11797 is explicitly marked with CLSCompliantAttribute.
11798 (IsIdentifierClsCompliant): New abstract method. This method is
11799 used to testing error 3005.
11800 (IsIdentifierAndParamClsCompliant): New method. Common helper method
11801 for identifier and parameters CLS-Compliant testing.
11802 (VerifyClsCompliance): New method. The main virtual method for
11803 CLS-Compliant verifications.
11804 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
11805 null. I don't know why is null (too many public members !).
11806 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
11807 and get value of first CLSCompliantAttribute that found.
11809 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
11810 (VerifyClsCompliance): Override and add extra tests.
11812 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
11813 clscheck- disable CLS-Compliant verification event if assembly is has
11814 CLSCompliantAttribute(true).
11816 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
11817 ApllyAttribute is now called in emit section as in the other cases.
11818 Possible future Emit integration.
11819 (IsIdentifierClsCompliant): New override.
11820 (VerifyClsCompliance): New override.
11821 (GetEnumeratorName): Returns full enum name.
11823 * parameter.cs (GetSignatureForError): Implemented.
11825 * report.cs (WarningData): New struct for Warning message information.
11826 (LocationOfPreviousError): New method.
11827 (Warning): New method. Reports warning based on the warning table.
11828 (Error_T): New method. Reports error based on the error table.
11830 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
11831 verifications are done here.
11833 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
11835 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
11836 CLSCompliantAttribute.
11837 (all_imported_types): New member holds all imported types from other
11839 (LoadAllImportedTypes): New method fills static table with exported types
11840 from all referenced assemblies.
11841 (Modules): New property returns all assembly modules.
11843 2004-03-30 Miguel de Icaza <miguel@ximian.com>
11845 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
11846 throwing a parser error.
11848 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
11849 which removes the hardcoded get_/set_ prefixes for properties, as
11850 IL allows for the properties to be named something else.
11854 * expression.cs: Do not override operand before we know if it is
11855 non-null. Fix 56207
11857 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
11859 * typemanager.cs: support for pinned variables.
11861 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
11863 * decl.cs, typemanager.cs: Avoid using an arraylist
11864 as a buffer if there is only one result set.
11866 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
11868 * expression.cs: Make sure you cant call a static method
11869 with an instance expression, bug #56174.
11871 2004-03-29 Miguel de Icaza <miguel@ximian.com>
11873 * class.cs (IsDuplicateImplementation): Improve error reporting to
11874 flag 663 (method only differs in parameter modifier).
11876 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
11877 in preprocessor directives.
11879 * location.cs (LookupFile): Allow for the empty path.
11881 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
11882 better approach for some of that patch, but its failing with the
11883 CharSet enumeration. For now try/catch will do.
11885 * typemanager.cs: Do not crash if a struct does not have fields.
11888 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
11890 * expression.cs: cs0213, cant fix a fixed expression.
11893 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
11895 * cs-parser.jay: detect invalid embeded statements gracefully.
11898 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
11900 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
11903 the invocation type may not be a subclass of the tye of the item/
11904 The type of the item must be a subclass of the invocation item.
11909 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
11911 * attribute.cs: Added methods to get a string and a bool from an
11912 attribute. Required to information from AssemblyKeyFileAttribute,
11913 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
11914 * codegen.cs: Modified AssemblyName creation to include support for
11915 strongnames. Catch additional exceptions to report them as CS1548.
11916 * compiler.csproj: Updated include CryptoConvert.cs.
11917 * compiler.csproj.user: Removed file - user specific configuration.
11918 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
11919 Mono.Security assembly. The original class is maintained and tested in
11920 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
11921 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
11922 like CSC 8.0 (C# v2) supports.
11923 * Makefile: Added CryptoConvert.cs to mcs sources.
11924 * rootcontext.cs: Added new options for strongnames.
11926 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
11928 * driver.cs: For --expect-error, report error code `2'
11929 if the program compiled with no errors, error code `1' if
11930 it compiled with an error other than the one expected.
11932 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
11934 * compiler.csproj: Updated for Visual Studio .NET 2003.
11935 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
11936 * compiler.sln: Updated for Visual Studio .NET 2003.
11938 2004-03-24 Ravi Pratap M <ravi@ximian.com>
11940 * expression.cs: Fix bug #47234. We basically need to apply the
11941 rule that we prefer the conversion of null to a reference type
11942 when faced with a conversion to 'object' (csc behaviour).
11944 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
11946 * statement.cs: Shorter form for foreach, eliminates
11947 a local variable. r=Martin.
11949 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
11951 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
11952 checks if we can use brtrue/brfalse to test for 0.
11953 * expression.cs: use the above in the test for using brtrue/brfalse.
11954 cleanup code a bit.
11956 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
11958 * expression.cs: Rewrite string concat stuff. Benefits:
11960 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
11961 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
11962 rather than a concat chain.
11964 * typemanager.cs: Add lookups for more concat overloads.
11966 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
11968 * expression.cs: Emit shorter il code for array init.
11985 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
11987 * statement.cs: Before, two switch blocks would be merged if the
11988 total size of the blocks (end_item - begin_item + 1) was less than
11989 two times the combined sizes of the blocks.
11991 Now, it will only merge if after the merge at least half of the
11996 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
11998 * class.cs : csc build fix for GetMethods(). See bug #52503.
12000 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
12002 * expression.cs: Make sure fp comparisons work with NaN.
12003 This fixes bug #54303. Mig approved this patch a long
12004 time ago, but we were not able to test b/c the runtime
12007 2004-03-19 Miguel de Icaza <miguel@ximian.com>
12009 * ecore.cs (TypExpr.GetHashCode): implement this overload.
12011 2004-03-19 Martin Baulig <martin@ximian.com>
12013 * class.cs (MemberCore.IsDuplicateImplementation): Check whether
12014 two overloads may unify for some type parameter substitutions and
12015 report a CS0408 if appropriate.
12017 2004-03-19 Martin Baulig <martin@ximian.com>
12019 * class.cs (MemberCore.IsDuplicateImplementation): Report the
12020 error here and not in our caller.
12022 2004-03-19 Martin Baulig <martin@ximian.com>
12024 * interface.cs: Completely killed this file.
12025 (Interface): We're now a TypeContainer and live in class.cs.
12027 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
12028 argument; we're now also called for interfaces.
12029 (TypeContainer.DefineMembers): Allow this method being called
12031 (TypeContainer.GetMethods): New public method; formerly known as
12032 Interface.GetMethod(). This is used by PendingImplementation.
12033 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
12034 it's now private and non-static.
12035 (Interface): Moved this here; it's now implemented similar to
12037 (Method, Property, Event, Indexer): Added `bool is_interface'
12038 argument to their .ctor's.
12039 (MemberBase.IsInterface): New public field.
12041 * cs-parser.jay: Create normal Method, Property, Event, Indexer
12042 instances instead of InterfaceMethod, InterfaceProperty, etc.
12043 (opt_interface_base): Removed; we now use `opt_class_base' instead.
12044 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
12046 2004-03-19 Martin Baulig <martin@ximian.com>
12048 * class.cs (MethodCore.IsDuplicateImplementation): New private
12049 method which does the CS0111 checking.
12050 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
12051 Use IsDuplicateImplementation().
12053 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
12055 * decl.cs (FindMemberToOverride): New method to find the correct
12056 method or property to override in the base class.
12058 - Make Method/Property use the above method to find the
12059 version in the base class.
12060 - Remove the InheritableMemberSignatureCompare as it is now
12063 This patch makes large code bases much faster to compile, as it is
12064 O(n) rather than O(n^2) to do this validation.
12066 Also, it fixes bug 52458 which is that nested classes are not
12067 taken into account when finding the base class member.
12069 Reviewed/Approved by Martin.
12071 2004-03-17 Martin Baulig <martin@ximian.com>
12073 * expression.cs (MemberAccess.DoResolve): Take the parent's number
12074 of type arguments into account; use the `real_num_type_args'
12075 approach like in DoResolveAsTypeStep().
12077 * generic.cs (GenericMemberAccess.DoResolve): Make this work for
12080 2004-03-17 Marek Safar <marek.safar@seznam.cz>
12082 * interface.cs: In all interface classes removed redundant
12083 member initialization.
12085 2004-03-16 Martin Baulig <martin@ximian.com>
12087 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
12089 2004-03-15 Miguel de Icaza <miguel@ximian.com>
12091 * decl.cs (DefineTypeAndParents): New helper method to define a
12092 type's containers before the type itself is defined; This is a
12093 bug exposed by the recent changes to Windows.Forms when an
12094 implemented interface was defined inside a class that had not been
12097 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
12099 (Check): Loop correctly to report errors modifiers
12100 (UNSAFE was not in the loop, since it was the same as TOP).
12102 * interface.cs: Every interface member now takes a ModFlags,
12103 instead of a "is_new" bool, which we set on the base MemberCore.
12105 Every place where we called "UnsafeOk" in the interface, now we
12106 call the proper member (InterfaceMethod.UnsafeOK) instead to get
12107 the unsafe settings from the member declaration instead of the
12108 container interface.
12110 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
12112 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
12113 `set_indexer_name' to the pending bits (one per type).
12115 We fixed a bug today that was picking the wrong method to
12116 override, since for properties the existing InterfaceMethod code
12117 basically ignored the method name. Now we make sure that the
12118 method name is one of the valid indexer names.
12120 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
12122 * support.cs (SeekableStreamReader): Keep track of stream byte
12123 positions and don't mix them with character offsets to the buffer.
12125 Patch from Gustavo Giráldez
12127 2004-03-15 Marek Safar <marek.safar@seznam.cz>
12129 * interface.cs (InterfaceSetGetBase): Removed double member
12130 initialization, base class does it as well.
12132 2004-03-13 Martin Baulig <martin@ximian.com>
12134 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
12135 when compiling corlib.
12137 2004-03-13 Miguel de Icaza <miguel@ximian.com>
12139 * convert.cs (ExplicitConversion): We were reporting an error on
12140 certain conversions (object_type source to a value type, when the
12141 expression was `null') before we had a chance to pass it through
12142 the user defined conversions.
12144 * driver.cs: Replace / and \ in resource specifications to dots.
12147 * class.cs: Add check for duplicate operators. Fixes 52477
12149 2004-03-11 Miguel de Icaza <miguel@ximian.com>
12151 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
12152 that are in the middle of the statements, not only at the end.
12155 * class.cs (TypeContainer.AddField): No longer set the
12156 `HaveStaticConstructor' flag, now we call it
12157 `UserDefineStaticConstructor' to diferentiate the slightly
12158 semantic difference.
12160 The situation is that we were not adding BeforeFieldInit (from
12161 Modifiers.TypeAttr) to classes that could have it.
12162 BeforeFieldInit should be set to classes that have no static
12167 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
12169 And most importantly Zoltan's comment:
12171 http://bugzilla.ximian.com/show_bug.cgi?id=44229
12173 "I think beforefieldinit means 'it's ok to initialize the type sometime
12174 before its static fields are used', i.e. initialization does not need
12175 to be triggered by the first access to the type. Setting this flag
12176 helps the JIT to compile better code, since it can run the static
12177 constructor at JIT time, and does not need to generate code to call it
12178 (possibly lots of times) at runtime. Unfortunately, mcs does not set
12179 this flag for lots of classes like String.
12181 csc sets this flag if the type does not have an explicit static
12182 constructor. The reasoning seems to be that if there are only static
12183 initalizers for a type, and no static constructor, then the programmer
12184 does not care when this initialization happens, so beforefieldinit
12187 This bug prevents the AOT compiler from being usable, since it
12188 generates so many calls to mono_runtime_class_init that the AOT code
12189 is much slower than the JITted code. The JITted code is faster,
12190 because it does not generate these calls if the vtable is type is
12191 already initialized, which is true in the majority of cases. But the
12192 AOT compiler can't do this."
12194 2004-03-10 Miguel de Icaza <miguel@ximian.com>
12196 * class.cs (MethodData.Emit): Refactor the code so symbolic
12197 information is generated for destructors; For some reasons we
12198 were taking a code path that did not generate symbolic information
12201 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
12203 * class.cs: Create a Constructor.CheckBase method that
12204 takes care of all validation type code. The method
12205 contains some code that was moved from Define.
12207 It also includes new code that checks for duplicate ctors.
12208 This fixes bug #55148.
12210 2004-03-09 Joshua Tauberer <tauberer@for.net>
12212 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
12213 a { ... }-style array creation invokes EmitStaticInitializers
12214 which is not good for reference-type arrays. String, decimal
12215 and now null constants (NullCast) are not counted toward
12216 static initializers.
12218 2004-03-05 Martin Baulig <martin@ximian.com>
12220 * location.cs (SourceFile.HasLineDirective): New public field;
12221 specifies whether the file contains or is referenced by a "#line"
12223 (Location.DefineSymbolDocuments): Ignore source files which
12224 either contain or are referenced by a "#line" directive.
12226 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
12228 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
12229 direct access to our parent, so check the method inline there.
12231 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
12233 * expression.cs (Invocation.EmitCall): Miguel's last commit
12234 caused a regression. If you had:
12239 In Foo the implict this would be null.
12241 2004-02-27 Miguel de Icaza <miguel@ximian.com>
12243 * expression.cs (Invocation.EmitCall): If the method is not
12244 virtual, do not emit a CallVirt to it, use Call.
12246 * typemanager.cs (GetFullNameSignature): Improve the method to
12247 cope with ".ctor" and replace it with the type name.
12249 * class.cs (ConstructorInitializer.Resolve): Now the method takes
12250 as an argument the ConstructorBuilder where it is being defined,
12251 to catch the recursive constructor invocations.
12253 2004-03-16 Martin Baulig <martin@ximian.com>
12255 * expression.cs (MemberAccess.DoResolve): If `expr' resolved to a
12256 ConstructedType, call ResolveType() on it to get the type rather
12257 than just using `expr.Type'.
12259 2004-03-16 Martin Baulig <martin@ximian.com>
12261 * generics.cs (ConstructedType.GetMemberAccess): Take the
12262 EmitContext instead on the TypeExpr and use
12263 ec.TypeContainer.CurrentType/ec.ContainerType.
12265 2004-03-16 Martin Baulig <martin@ximian.com>
12267 * ecore.cs (SimpleName.DoResolveAsTypeStep): Lookup type
12268 parameters before aliases.
12270 2004-03-16 Martin Baulig <martin@ximian.com>
12272 * typemanager.cs (TypeManager.MayBecomeEqualGenericInstances):
12273 New oublic function; checks whether two generic instances may become
12274 equal under some instantiations (26.3.1).
12276 * class.cs (TypeContainer.Define): Call
12277 TypeManager.MayBecomeEqualGenericInstances() and report CS0695 on
12280 2004-03-16 Martin Baulig <martin@ximian.com>
12282 * class.cs (TypeContainer.GetClassBases): Moved
12283 Error_TypeParameterAsBase() here and also check whether the base
12284 class is not an attribute.
12286 2004-03-16 Martin Baulig <martin@ximian.com>
12288 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
12290 2004-03-16 Martin Baulig <martin@ximian.com>
12292 * class.cs (Error_TypeParameterAsBase): Use correct error number
12295 2004-03-16 Martin Baulig <martin@ximian.com>
12297 * decl.cs (DeclSpace.ResolveTypeExpr): Added more error checking
12300 * generics.cs (ConstructedType.DoResolveAsTypeStep): Added better
12303 2004-03-15 Martin Baulig <martin@ximian.com>
12305 * typemanager.cs (TypeManager.GetFullName): New public method.
12306 (TypeManager.MemberLookup): Added `int_num_type_arguments'
12307 argument; only return members with the correct number of type
12309 (TypeManager.CheckGeneric): Allow -1 to bypass the check.
12310 (TypeManager.FilterWithClosure): Call CheckGeneric() to check
12311 whether the number of type arguments matches.
12313 * generic.cs (GenericMemberAccess.ResolveAsTypeStep): Allow `expr'
12314 not being a ConstructedType; we can now do "typeof (Foo.Bar<U>)".
12316 * expression.cs (MemberAccess): Added public `NumTypeArguments'
12317 field; it's set by the protected .ctor when we're actually a
12318 GenericMemberAccess.
12319 (MemberAccess.ResolveAsTypeStep): Compute the total number of type
12320 arguments and pass it to MemberLookupFinal ().
12322 * ecore.cs (Expression.MemberLookup): Added `int
12323 num_type_arguments' argument; only return members with the correct
12324 number of type arguments.
12325 (Expression.MemberLookupFailed): Check whether the MemberLookup
12326 failed because we did not have the correct number of type
12327 arguments; report CS0305 in this case.
12329 * decl.cs (DeclSpace.ResolveTypeExpr): Don't report an error if
12330 `e.ResolveAsTypeTerminal()' already did so.
12332 2004-03-15 Martin Baulig <martin@ximian.com>
12334 * ecore.cs (Expression.ResolveLValue): Allow e.type being null if
12335 we're a ConstructedType; in this case, the caller must report an
12336 error (for instance CS0131).
12338 * generic.cs (TypeArguments): Added Location argument to the .ctor.
12339 (TypeArguments.Resolve): Actually report errors here.
12341 2004-03-15 Miguel de Icaza <miguel@ximian.com>
12343 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
12344 `set_indexer_name' to the pending bits (one per type).
12346 We fixed a bug today that was picking the wrong method to
12347 override, since for properties the existing InterfaceMethod code
12348 basically ignored the method name. Now we make sure that the
12349 method name is one of the valid indexer names.
12351 2004-03-15 Martin Baulig <martin@ximian.com>
12353 * typemanager.cs (TypeManager.IndexerPropertyName): Added support
12354 for generic instances.
12356 2004-03-13 Martin Baulig <martin@ximian.com>
12358 * class.cs (TypeContainer.DefineType): Call
12359 TypeManager.AddUserType() immediately after creating the
12360 TypeBuilder; pass all type parameters when creating the
12363 * decl.cs (DeclSpace.FindNestedType): New public method.
12364 (DeclSpace.FindType): Added `int num_type_args' argument; only
12365 return types with the correct number of type parameters.
12366 (DeclSpace.CountTypeParams): New public property.
12368 * ecore.cs (SimpleName.ctor): Added overloaded version which takes
12369 the number of type parameters; defaults to zero.
12371 * generic.cs (TypeArguments.Count): New public property.
12372 (ConstructedType.DoResolveAsTypeStep): First call
12373 ds.FindNestedType() to find out whether we're nested in the
12374 current generic type; in this case, we inherit all type parameters
12375 from the current class.
12377 * rootcontext.cs (RootContext.NamespaceLookup): Added `int
12378 num_type_args' argument.
12379 (RootContext.LookupType): Added overloaded version which takes the
12380 number of type arguments; only return types with the correct
12381 number of type arguments.
12383 * typemanager.cs (TypeManager.CheckGeneric): New public function;
12384 checks whether `Type t' has `int num_type_args'.
12386 2004-03-13 Martin Baulig <martin@ximian.com>
12388 * generic.cs (GenericMethod.DefineType): New method; calls
12389 DefineType() on all the type parameters.
12391 * class.cs (MethodData.ctor): Added `GenericMethod generic' argument.
12392 (MethodData.Define): If we're a generic method, call
12393 GenericMethod.DefineType() to define the type parameters.
12395 2004-03-10 Martin Baulig <martin@ximian.com>
12397 * pending.cs (Pending.InterfaceMethod): Use TypeManager.IsEqual()
12398 instead of IsAssignableFrom.
12400 2004-03-10 Martin Baulig <martin@ximian.com>
12402 * ecore.cs (FieldExpr.ctor): Use TypeManager.TypeToCoreType().
12404 * support.cs (ParameterData.HasArrayParameter): New property.
12405 (ReflectionParameters.ctor): Take a MethodBase instead of a
12406 ParameterInfo[]. If we have any type parameters, get the generic
12407 method definition and ask it whether we have variable arguments.
12409 2004-02-26 Miguel de Icaza <miguel@ximian.com>
12411 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
12412 routines to check if a type is an enumerable/enumerator allow
12413 classes that implement the IEnumerable or IEnumerator interfaces.
12415 * class.cs (Property, Operator): Implement IIteratorContainer, and
12416 implement SetYields.
12418 (Property.Define): Do the block swapping for get_methods in the
12419 context of iterators. We need to check if Properties also
12420 include indexers or not.
12422 (Operator): Assign the Block before invoking the
12423 OperatorMethod.Define, so we can trigger the Iterator code
12426 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
12427 Property and Operator classes are not created when we parse the
12428 declarator but until we have the block completed, so we use a
12429 singleton SimpleIteratorContainer.Simple to flag whether the
12430 SetYields has been invoked.
12432 We propagate this setting then to the Property or the Operator to
12433 allow the `yield' to function.
12435 2004-02-25 Marek Safar <marek.safar@seznam.cz>
12437 * codegen.cs: Implemented attribute support for modules.
12438 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
12439 Assembly/Module functionality.
12441 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
12442 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
12443 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
12445 2004-02-16 Marek Safar <marek.safar@seznam.cz>
12447 * interface.cs (FindMembers): The operation is performed on all base
12448 interfaces and not only on the first. It is required for future CLS Compliance patch.
12450 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
12452 * statement.cs, codegen.cs:
12453 This patch deals with patterns such as:
12455 public class List : IEnumerable {
12457 public MyEnumerator GetEnumerator () {
12458 return new MyEnumerator(this);
12461 IEnumerator IEnumerable.GetEnumerator () {
12465 public struct MyEnumerator : IEnumerator {
12470 Before, there were a few things we did wrong:
12471 1) we would emit callvirt on a struct, which is illegal
12472 2) we emited ldarg when we needed to emit ldarga
12473 3) we would mistakenly call the interface methods on an enumerator
12474 type that derived from IEnumerator and was in another assembly. For example:
12476 public class MyEnumerator : IEnumerator
12478 Would have the interface methods called, even if there were public impls of the
12479 method. In a struct, this lead to invalid IL code.
12481 2004-02-11 Marek Safar <marek.safar@seznam.cz>
12483 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
12486 * delegate.cs (Define): Fixed crash when delegate type is undefined.
12488 2004-02-11 Miguel de Icaza <miguel@ximian.com>
12490 * cs-parser.jay: Fix small regression: we were not testing V2
12491 compiler features correctly.
12493 * interface.cs: If the emit context is null, then create one
12495 2004-02-09 Marek Safar <marek.safar@seznam.cz>
12497 * decl.cs (GetSignatureForError): New virtual method to get full name
12498 for error messages.
12500 * attribute.cs (IAttributeSupport): New interface for attribute setting.
12501 Now it is possible to rewrite ApplyAttributes method to be less if/else.
12503 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
12504 Duplicated members and code in these classes has been removed.
12505 Better encapsulation in these classes.
12507 2004-02-07 Miguel de Icaza <miguel@ximian.com>
12509 * assign.cs (Assign.DoResolve): When dealing with compound
12510 assignments, there is a new rule in ECMA C# 2.4 (might have been
12511 there before, but it is documented here) that states that in:
12515 If b is of type int, and the `op' is a shift-operator, then the
12516 above is evaluated as:
12520 * expression.cs (Binary.ResolveOperator): Instead of testing for
12521 int/uint/long/ulong, try to implicitly convert to any of those
12522 types and use that in pointer arithmetic.
12524 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
12525 method to print information for from the type, not from the
12526 null-method we were given.
12528 2004-02-01 Duncan Mak <duncan@ximian.com>
12530 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
12531 parsing for cmd, fixes bug #53694.
12533 2004-02-04 Marek Safar <marek.safar@seznam.cz>
12535 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
12536 in the member name duplication tests. Property and operator name duplication
12537 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
12539 2004-02-03 Marek Safar <marek.safar@seznam.cz>
12541 * interface.cs (PopulateMethod): Fixed crash when interface method
12542 returns not existing type (error test cs0246-3.cs).
12544 2004-02-02 Ravi Pratap M <ravi@ximian.com>
12546 * cs-parser.jay (interface_accessors): Re-write actions to also
12547 store attributes attached to get and set methods. Fix spelling
12550 (inteface_property_declaration): Modify accordingly.
12552 (InterfaceAccessorInfo): New helper class to store information to pass
12553 around between rules that use interface_accessors.
12555 * interface.cs (Emit): Apply attributes on the get and set
12556 accessors of properties and indexers too.
12558 * attribute.cs (ApplyAttributes): Modify accordingly to use the
12559 right MethodBuilder when applying attributes to the get and set accessors.
12561 2004-01-31 Miguel de Icaza <miguel@ximian.com>
12563 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
12565 2004-01-26 Miguel de Icaza <miguel@ximian.com>
12567 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
12569 2004-01-25 Miguel de Icaza <miguel@ximian.com>
12571 * cs-parser.jay: Remove YIELD token, instead use the new grammar
12572 changes that treat `yield' specially when present before `break'
12573 or `return' tokens.
12575 * cs-tokenizer.cs: yield is no longer a keyword.
12577 2004-01-23 Marek Safar <marek.safar@seznam.cz>
12579 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
12580 setting for default constructors.
12581 For default constructors are almost every time set wrong Modifier. The
12582 generated IL code has been alright. But inside mcs this values was
12583 wrong and this was reason why several of my CLS Compliance tests
12586 2004-02-27 Martin Baulig <martin@ximian.com>
12588 * generics.cs (ConstructedType.ResolveType): Make the nested type
12589 stuff actually work.
12591 2004-02-25 Martin Baulig <martin@ximian.com>
12593 * decl.cs (DeclSpace.CurrentTypeParameters): New protected
12594 property; returns the type parameters just from the current type,
12595 ie. with the ones from outer classes.
12596 (DeclSpace.LookupGeneric): First search in the current class, then
12598 (DeclSpace.initialize_type_params): When hiding a type parameter
12599 from an outer class, put it into the `type_param_list' anyways.
12601 * expression.cs (MemberAccess.expr): Made this field protected.
12603 * class.cs (TypeContainer.Define): The `CurrentType' just contains
12604 the type parameters from the current class.
12606 * generic.cs (ConstructedType.ResolveType): Support nested generic
12607 types by taking the type parameters which we inherit from outer
12608 classes into account.
12609 (GenericMemberAccess.ResolveAsTypeStep): Override this and added
12610 support for nested generic types.
12612 2004-02-23 Martin Baulig <martin@ximian.com>
12614 * decl.cs (DeclSpace.IsGeneric): Make this a property instead of a
12615 field and check whether we're nested inside a generic type.
12616 (DeclSpace.ResolveType): If we're resolving to a generic type
12617 definition, create a ConstructedType and return its resolved type.
12618 (DeclSpace.initialize_type_params): New private method;
12619 initializes the `type_param_list' field from the type parameters
12620 from this and all enclosing classes.
12621 (DeclSpace.TypeParameters): Call initialize_type_params() unless
12622 we're already initialized.
12624 2004-02-23 Martin Baulig <martin@ximian.com>
12626 * class.cs (Method.Define): Create the generic method before
12627 calling DoDefine().
12628 (Memberbase.DoDefine): Added DeclSpace argument (in addition to
12629 the TypeContainer one); we use this for generic methods.
12631 * decl.cs (CheckAccessLevel): If we're a GenericMethod, use our
12632 parent's TypeBuilder.
12634 2004-02-18 Martin Baulig <martin@ximian.com>
12636 * ecore.cs (FieldExpr.DoResolveLValue): Use TypeManager.IsEqual()
12637 to check for equality.
12639 2004-02-05 Martin Baulig <martin@ximian.com>
12641 * ecore.cs (FieldExpr.DoResolveLValue): If we have an
12642 `ec.TypeContainer.CurrentType', use it instead of
12643 `ec.ContainerType' to check whether we're in the type's ctor.
12645 2004-01-29 Martin Baulig <martin@ximian.com>
12647 * expression.cs (Invocation.DoResolve): If we're a
12648 `ConstructedType', then we're actually a generic method, so
12649 rewrite the expr as a GenericMemberAccess.
12651 * cs-parser.jay (member_name): Don't use `namespace_or_type_name'
12652 here; manually parse it into a string.
12654 2004-01-28 Martin Baulig <martin@ximian.com>
12656 * typemanager.cs (TypeManager.IsEqual): New static method.
12657 (TypeManager.FilterWithClosure): Call TypeManager.IsEqual() to
12658 check for equality instead of using `=='.
12660 2004-01-26 Martin Baulig <martin@ximian.com>
12662 * decl.cs (DeclSpace.CurrentType): New public field.
12664 * expression.cs (This.ResolveBase): If we have an
12665 `ec.TypeContainer.CurrentType', use it instead of
12666 `ec.ContainerType'.
12668 * class.cs (TypeContainer.DefineType): If we're a generic type,
12669 create the `CurrentType' (unresolved).
12670 (TypeContainer.GenericType): New private field.
12671 (TypeContainer.DefineMembers): If we have a `CurrentType', resolve
12672 it and store it in `GenericType' before creating the MemberCache.
12673 (TypeContainer.GetMembers): If we have a `GenericType', call
12674 TypeManager.FindMembers() on it.
12676 * interface.cs (Interface.GenericType): New private field.
12677 (Interface.DefineType): If we're a generic type, create the
12678 `CurrentType' (unresolved).
12679 (Interface.DefineMembers): If we have a `CurrentType', resolve it
12680 and store it in `GenericType' before creating the MemberCache.
12681 (Interface.GetMembers): If we have a `GenericType', call
12682 TypeManager.FindMembers() on it.
12684 2004-01-22 Martin Baulig <martin@ximian.com>
12686 * cs-parser.jay (namespace_or_type_name): Return an Expression,
12687 not a QualifiedIdentifier. This is what `type_name_expression'
12688 was previously doing.
12689 (type_name_expression): Removed; the code is now in
12690 `namespace_or_type_name'.
12691 (qualified_identifier): Removed, use `namespace_or_type_name'
12693 (QualifiedIdentifier): Removed this class.
12695 2004-01-22 Martin Baulig <martin@ximian.com>
12697 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
12698 not a string as alias name.
12700 2004-01-21 Miguel de Icaza <miguel@ximian.com>
12702 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
12703 #52730 bug, and instead compute correctly the need to use a
12704 temporary variable when requesting an address based on the
12705 static/instace modified of the field and the constructor.
12707 2004-01-21 Martin Baulig <martin@ximian.com>
12709 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
12710 class and namespace before looking up aliases. Fixes #52517.
12712 2004-01-21 Martin Baulig <martin@ximian.com>
12714 * flowanalysis.cs (UsageVector.Merge): Allow variables being
12715 assinged in a 'try'; fixes exception4.cs.
12717 2004-01-21 Marek Safar <marek.safar@seznam.cz>
12718 * class.cs : Implemented parameter-less constructor for TypeContainer
12720 * decl.cs: Attributes are now stored here. New property OptAttributes
12722 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
12724 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
12726 2004-01-21 Marek Safar <marek.safar@seznam.cz>
12728 * typemanager.cs (CSharpSignature): Now reports also inner class name.
12729 (CSharpSignature): New method for indexer and property signature.
12731 2004-01-21 Marek Safar <marek.safar@seznam.cz>
12733 * pending.cs (IsVirtualFilter): Faster implementation.
12735 2004-01-21 Marek Safar <marek.safar@seznam.cz>
12737 * typemanager.cs: Avoid inclusion of same assembly more than once.
12739 2004-01-21 Marek Safar <marek.safar@seznam.cz>
12741 * cs-parser.jay: Fixed problem where the last assembly attribute
12742 has been applied also to following declaration (class, struct, etc.)
12744 2004-01-21 Marek Safar <marek.safar@seznam.cz>
12746 * class.cs: Added error CS0538, CS0539 reporting.
12747 Fixed crash on Microsoft runtime when field type is void.
12749 * cs-parser.jay: Added error CS0537 reporting.
12751 * pending.cs: Added error CS0535 reporting.
12752 Improved error report for errors CS0536, CS0534.
12754 2004-01-20 Miguel de Icaza <miguel@ximian.com>
12756 Merge a few bits from the Anonymous Method MCS tree.
12758 * statement.cs (ToplevelBlock): New class for toplevel methods,
12759 will hold anonymous methods, lifted variables.
12761 * cs-parser.jay: Create toplevel blocks for delegates and for
12762 regular blocks of code.
12764 2004-01-20 Martin Baulig <martin@ximian.com>
12766 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
12767 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
12768 and `NeedExplicitReturn'; added `IsLastStatement'.
12769 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
12770 have a `ReturnLabel' or we're not unreachable.
12772 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
12773 child's reachability; don't just override ours with it. Fixes
12774 #58058 (lluis's example).
12775 (FlowBranching): Added public InTryOrCatch(), InCatch(),
12776 InFinally(), InLoop(), InSwitch() and
12777 BreakCrossesTryCatchBoundary() methods.
12779 * statement.cs (Return): Do all error checking in Resolve().
12780 Unless we are the last statement in a top-level block, always
12781 create a return label and jump to it.
12782 (Break, Continue): Do all error checking in Resolve(); also make
12783 sure we aren't leaving a `finally'.
12784 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
12785 statement in a top-level block.
12786 (Block.Flags): Added `IsDestructor'.
12787 (Block.IsDestructor): New public property.
12789 2004-01-20 Martin Baulig <martin@ximian.com>
12791 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
12793 2004-01-20 Martin Baulig <martin@ximian.com>
12795 * statement.cs (Statement.ResolveUnreachable): New public method.
12796 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
12797 (Block.Resolve): Resolve unreachable statements.
12799 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
12801 * expression.cs: We need to fix the case where we do
12802 not have a temp variable here.
12804 * assign.cs: Only expression compound assignments need
12805 temporary variables.
12807 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
12809 * flowanalysis.cs: Reduce memory allocation in a few ways:
12810 - A block with no variables should not allocate a bit
12812 - A method with no out parameters does not need any tracking
12813 for assignment of the parameters, so we need not allocate
12816 public readonly Type[] VariableTypes;
12817 public readonly string[] VariableNames;
12818 Are redundant. The data is already stored in the variable
12819 map, so we need not allocate another array for it.
12820 - We need to add alot of checks for if (params | locals) == null
12821 due to the first two changes.
12823 2004-01-18 Miguel de Icaza <miguel@ximian.com>
12825 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
12826 implement IMemoryLocation, we store a copy on a local variable and
12827 take the address of it. Patch from Benjamin Jemlich
12829 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
12830 to use a special "type_name_expression" rule which reduces the
12831 number of "QualifiedIdentifier" classes created, and instead
12832 directly creates MemberAccess expressions.
12834 2004-01-17 Miguel de Icaza <miguel@ximian.com>
12836 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
12837 that fixes #52853. Null literal assignment to ValueType
12839 * class.cs (MethodData.Emit): Instead of checking the name of the
12840 method to determine if its a destructor, create a new derived
12841 class from Method called Destructor, and test for that.
12843 * cs-parser.jay: Create a Destructor object instead of a Method.
12845 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
12849 2004-01-16 Miguel de Icaza <miguel@ximian.com>
12851 * expression.cs (Binary.ResolveOperator): Perform an implicit
12852 conversion from MethodGroups to their delegate types on the
12853 Addition operation.
12855 * delegate.cs: Introduce a new class DelegateCreation that is the
12856 base class for `NewDelegate' and `ImplicitDelegateCreation',
12857 factor some code in here.
12859 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
12860 conversion from MethodGroups to compatible delegate types.
12862 * ecore.cs (Expression.Resolve): Do not flag error 654
12863 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
12864 we allow conversions from MethodGroups to delegate types now.
12866 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
12867 assignments in v2 either.
12869 2004-01-10 Miguel de Icaza <miguel@ximian.com>
12871 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
12872 static read-only fields in ctors.
12874 Applied patch from Benjamin Jemlich
12876 * expression.cs (UnaryMutator): Avoid leaking local variables.
12878 2004-01-09 Miguel de Icaza <miguel@ximian.com>
12880 * cs-tokenizer.cs (IsCastToken): Allow the various native types
12881 here to return true, as they can be used like this:
12883 (XXX) int.MEMBER ()
12885 Fixed 49836 and all the other dups
12887 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
12889 * driver.cs: Implement /win32res and /win32icon.
12891 2004-01-08 Miguel de Icaza <miguel@ximian.com>
12893 * cs-parser.jay: Add a rule to improve error handling for the
12894 common mistake of placing modifiers after the type.
12896 2004-01-07 Miguel de Icaza <miguel@ximian.com>
12898 * cs-parser.jay (interface_event_declaration): Catch
12899 initialization of events on interfaces, and report cs0068
12901 * cs-parser.jay (interface_event_declaration): Catch
12902 initialization of events.
12904 * ecore.cs: Better report missing constructors.
12906 * expression.cs (Binary.ResolveOperator): My previous bug fix had
12907 the error reporting done in the wrong place. Fix.
12909 * expression.cs (Binary.ResolveOperator): Catch the
12910 operator + (E x, E y) error earlier, and later allow for implicit
12911 conversions in operator +/- (E e, U x) from U to the underlying
12914 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
12915 52596, if the container class is abstract, the default constructor
12916 is protected otherwise its public (before, we were always public).
12918 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
12921 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
12922 Jemlich that fixes bug #52597, MCS was generating invalid code for
12923 idisposable structs. Thanks to Ben for following up with this
12926 2004-01-06 Miguel de Icaza <miguel@ximian.com>
12928 * driver.cs: Allow assemblies without code to be generated, fixes
12931 2004-01-07 Nick Drochak <ndrochak@gol.com>
12933 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
12935 2004-01-05 Miguel de Icaza <miguel@ximian.com>
12937 * cs-parser.jay: Add rules to improve error reporting if fields or
12938 methods are declared at the namespace level (error 116)
12940 * Add rules to catch event add/remove
12942 2004-01-04 David Sheldon <dave-mono@earth.li>
12944 * expression.cs: Added matching ")" to error message for
12947 2004-01-03 Todd Berman <tberman@gentoo.org>
12949 * ecore.cs, attribute.cs:
12950 Applying fix from #52429.
12952 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
12954 * ecore.cs, expression.cs, statement.cs:
12955 Total rewrite of how we handle branching. We
12956 now handle complex boolean expressions with fewer
12957 jumps. As well if (x == 0) no longer emits a ceq.
12959 if (x is Foo) is much faster now, because we generate
12962 Overall, we get a pretty big improvement on our benchmark
12963 tests. The code we generate is smaller and more readable.
12965 I did a full two-stage bootstrap. The patch was reviewed
12966 by Martin and Miguel.
12968 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
12970 * cs-parser.jay: Make primary_expression not take a QI.
12971 we dont need this because the member_access rule covers
12972 us here. So we replace the rule with just IDENTIFIER.
12974 This has two good effects. First, we remove a s/r conflict.
12975 Second, we allocate many fewer QualifiedIdentifier objects.
12977 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
12979 * attribute.cs: Handle MarshalAs attributes as pseudo, and
12980 set the correct information via SRE. This prevents
12981 hanging on the MS runtime. Fixes #29374.
12983 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
12985 * convert.cs: correctly handle conversions to value types
12986 from Enum and ValueType as unboxing conversions.
12988 Fixes bug #52569. Patch by Benjamin Jemlich.
12990 2004-01-02 Ravi Pratap <ravi@ximian.com>
12992 * expression.cs (BetterConversion): Prefer int -> uint
12993 over int -> ulong (csc's behaviour). This fixed bug #52046.
12995 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
12997 * decl.cs (MemberCache.FindMembers): now returns a
13000 * typemanager.cs: In general, go with with ^^.
13001 (CopyNewMethods): take an IList.
13002 (RealMemberLookup): Only allocate an arraylist
13003 if we copy from two sets of methods.
13005 This change basically does two things:
13006 1) Fewer array lists allocated due to CopyNewMethods.
13007 2) the explicit cast in MemberList costed ALOT.
13009 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
13011 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
13012 a hashtable to avoid needless string allocations when an identifier is
13013 used more than once (the common case).
13015 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
13017 * pending.cs: MS's TypeBuilder.GetInterfaces ()
13018 is broken, it will not return anything. So, we
13019 have to use the information we have in mcs to
13022 * typemanager.cs: Add a cache for GetInterfaces,
13023 since this will now be used more often (due to ^^)
13025 (GetExplicitInterfaces) New method that gets the
13026 declared, not effective, interfaces on a type
13027 builder (eg, if you have interface IFoo, interface
13028 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
13031 This patch makes MCS able to bootstrap itself on
13034 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
13036 * expression.cs: Remove the Nop's that Miguel put
13039 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
13041 * report.cs, codegen.cs: Give the real stack trace to
13042 the error when an exception is thrown.
13044 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
13046 * decl.cs: only allocate hashtables for ifaces if
13049 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
13051 * expression.cs: fix the error from cs0121-2.cs
13052 (a parent interface has two child interfaces that
13053 have a function with the same name and 0 params
13054 and the function is called through the parent).
13056 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
13058 * class.cs, rootcontext.cs, typmanager.cs: do not
13061 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
13063 * codegen.cs: remove stack for the ec flow branching.
13064 It is already a linked list, so no need.
13066 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
13068 * Makefile: Allow custom profiler here.
13070 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
13072 * typemanager.cs (LookupType):
13073 - Use a static char [], because split takes
13074 a param array for args, so it was allocating
13076 - Do not store true in a hashtable, it boxes.
13078 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
13080 * flowanalysis.cs: bytify common enums.
13082 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
13084 * modifiers.cs: Add a new set of flags for the
13085 flags allowed on explicit interface impls.
13086 * cs-parser.jay: catch the use of modifiers in
13087 interfaces correctly.
13088 * class.cs: catch private void IFoo.Blah ().
13090 All related to bug #50572.
13092 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
13094 * decl.cs: Rewrite the consistant accessability checking.
13095 Accessability is not linear, it must be implemented in
13096 a tableish way. Fixes #49704.
13098 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
13100 * expression.cs: Handle negation in a checked context.
13101 We must use subtraction from zero. Fixes #38674.
13103 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
13105 * class.cs: Ignore static void main in DLLs.
13106 * rootcontext.cs: Handle the target type here,
13107 since we are have to access it from class.cs
13108 * driver.cs: account for the above.
13110 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
13112 * report.cs: Give line numbers and files if available.
13114 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
13116 * driver.cs: Implement /addmodule.
13118 * typemanager.cs: Change 'modules' field so it now contains Modules not
13121 2003-12-20 Martin Baulig <martin@ximian.com>
13123 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
13124 (FieldBase.IsAssigned): Removed this field.
13125 (FieldBase.SetAssigned): New public method.
13126 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
13128 2003-12-20 Martin Baulig <martin@ximian.com>
13130 * expression.cs (LocalVariableReference.DoResolve): Don't set
13131 `vi.Used' if we're called from DoResolveLValue().
13133 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
13134 returns the usage vector it just merged into the current one -
13135 pass this one to UsageWarning().
13136 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
13137 of the `EmitContext', don't call this recursively on our children.
13139 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
13141 * driver.cs: Implement /target:module.
13143 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
13145 * support.cs (CharArrayHashtable): New helper class.
13147 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
13148 char arrays, not strings, so we can avoid creating a string in
13149 consume_identifier if the identifier is a keyword.
13151 2003-12-16 Martin Baulig <martin@ximian.com>
13153 * statement.cs (LocalInfo.Assigned): Removed this property.
13154 (LocalInfo.Flags): Removed `Assigned'.
13155 (LocalInfo.IsAssigned): New public method; takes the EmitContext
13156 and uses flow analysis.
13157 (Block.UsageWarning): Made this method private.
13158 (Block.Resolve): Call UsageWarning() if appropriate.
13160 * expression.cs (LocalVariableReference.DoResolve): Always set
13161 LocalInfo.Used here.
13163 2003-12-13 Martin Baulig <martin@ximian.com>
13165 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
13166 any value here; we're now using flow analysis to figure out
13167 whether a statement/block returns a value.
13169 2003-12-13 Martin Baulig <martin@ximian.com>
13171 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
13173 (FlowBranching.MergeFinally): Don't call
13174 `branching.CheckOutParameters()' here, this is called in
13176 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
13177 when adding the `finally' vector.
13179 2003-12-13 Martin Baulig <martin@ximian.com>
13182 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
13183 actually work and also fix #48962.
13185 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
13187 * decl.cs: Do not check System.Object for nested types,
13188 since we know it does not have any. Big bang for buck:
13191 Run 1: 8.35 seconds
13192 Run 2: 8.32 seconds
13193 corlib: 17.99 seconds
13195 Run 1: 8.17 seconds
13196 Run 2: 8.17 seconds
13197 corlib: 17.39 seconds
13199 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
13201 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
13202 time we are returning 0 members, so we save alot here.
13204 2003-12-11 Martin Baulig <martin@ximian.com>
13206 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
13207 `MergeChild()', also just take the `FlowBranching' as argument;
13208 call Merge() on it and return the result.
13209 (FlowBranching.Merge): We don't need to do anything if we just
13212 2003-12-11 Martin Baulig <martin@ximian.com>
13214 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
13215 them in an `ArrayList' to reduce memory usage. Thanks to Ben
13216 Maurer for this idea.
13218 2003-12-11 Martin Baulig <martin@ximian.com>
13220 * flowanalysis.cs (MergeResult): This class is now gone; we now
13221 use the `UsageVector' for this. The reason for this is that if a
13222 branching just has one sibling, we don't need to "merge" them at
13223 all - that's the next step to do.
13224 (FlowBranching.Merge): We now return a `UsageVector' instead of a
13227 2003-12-11 Martin Baulig <martin@ximian.com>
13229 Reworked flow analyis and made it more precise and bug-free. The
13230 most important change is that we're now using a special `Reachability'
13231 class instead of having "magic" meanings of `FlowReturns'. I'll
13232 do some more cleanups and optimizations and also add some more
13233 documentation this week.
13235 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
13236 largely reworked this class.
13237 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
13238 the new `Reachability' class instead of having "magic" values here.
13239 (FlowBranching): We're now using an instance of `Reachability'
13240 instead of having separate `Returns', `Breaks' etc. fields.
13242 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
13243 based on flow analysis; ignore the return value of block.Emit ().
13245 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
13247 * driver.cs typemanager.cs: Find the mono extensions to corlib even
13248 if they are private.
13250 2003-12-09 Martin Baulig <martin@ximian.com>
13252 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
13253 call them directly on the UsageVector.
13255 2003-12-09 Martin Baulig <martin@ximian.com>
13257 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
13258 Changed return type from `FlowReturns' to `Reachability'.
13260 2003-12-09 Martin Baulig <martin@ximian.com>
13262 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
13263 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
13264 `Reachable' fields with a single `Reachability' one.
13266 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
13268 * class.cs (FindMembers): Remove foreach's.
13273 Run 1: 8.74 seconds
13274 Run 2: 8.71 seconds
13277 Run 1: 8.64 seconds
13278 Run 2: 8.58 seconds
13281 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
13286 This patch does a few things:
13287 1. EmptyStatement is now a singleton, so it is never reallocated.
13288 2. All blah is EmptyStatement constructs have been changed to
13289 blah == EmptyStatement.Value, which is much faster and valid
13290 now that EmptyStatement is a singleton.
13291 3. When resolving a block, rather than allocating a new array for
13292 the non-empty statements, empty statements are replaced with
13293 EmptyStatement.Value
13294 4. Some recursive functions have been made non-recursive.
13295 Mainly the performance impact is from (3), however (1) and (2) are needed for
13296 this to work. (4) does not make a big difference in normal situations, however
13297 it makes the profile look saner.
13302 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
13303 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
13304 Total memory allocated: 56397 KB
13307 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
13308 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
13309 Total memory allocated: 55666 KB
13311 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
13313 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
13314 than the hashtable in a hashtable version
13316 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
13317 we always end up concating a string. This results in a huge perf
13318 loss, because many strings have to be tracked by the GC. In this
13319 patch, we first use a hashtable that works with two keys, so that
13320 the strings do not need to be concat'ed.
13324 Run 1: 8.74 seconds
13325 Run 2: 8.71 seconds
13328 Run 1: 8.65 seconds
13329 Run 2: 8.56 seconds
13331 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
13333 * Makefile: Add a new target `do-time' that does a quick and simple
13334 profile, leaving easy to parse output.
13336 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
13338 * codegen.cs (Init): Create the dynamic assembly with
13339 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
13341 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
13343 * support.cs: Make the PtrHashtable use only one
13344 instance of its comparer.
13346 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
13348 * typemanager.cs: Fix lookup of GetNamespaces.
13350 2003-11-29 Miguel de Icaza <miguel@ximian.com>
13352 * expression.cs: Removed redundant line.
13354 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
13355 ArrayLists, use for loops with bounds.
13357 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
13360 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
13361 arraylists, use for loop with bounds.
13363 The above three changes give us a 0.071 second performance
13364 improvement out of 3.294 seconds down to 3.223. On my machine
13365 the above changes reduced the memory usage by 1,387 KB during
13366 compiler bootstrap.
13368 * cs-parser.jay (QualifiedIdentifier): New class used to represent
13369 QualifiedIdentifiers. Before we created a new string through
13370 concatenation, and mostly later on, the result would be
13371 manipulated by DecomposeQI through string manipulation.
13373 This reduced the compiler memory usage for bootstrapping from
13374 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
13375 compile times in 0.05 seconds.
13377 2003-11-28 Dick Porter <dick@ximian.com>
13379 * support.cs: Do string compares with the Invariant culture.
13387 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
13388 the comparison is done with the Invariant culture.
13390 2003-11-27 Miguel de Icaza <miguel@ximian.com>
13392 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
13393 GetEnumerator method.
13395 (ProbeCollectionType): Iterate starting at the most specific type
13396 upwards looking for a GetEnumerator
13398 * expression.cs: Shift count can be up to 31 for int/uint and 63
13401 2003-11-26 Miguel de Icaza <miguel@ximian.com>
13403 * statement.cs (Block.LookupLabel): Also look for the label on the
13404 children blocks. Use a hash table to keep track of visited
13407 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
13408 we actually did transform the other operand, otherwise fall back
13409 to the common codepath that casts to long.
13411 * cs-tokenizer.cs: Use the same code pattern as the int case.
13412 Maybe I should do the parsing myself, and avoid depending on the
13413 Parse routines to get this done.
13415 2003-11-25 Miguel de Icaza <miguel@ximian.com>
13417 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
13418 which fixes bug 51347. This time test it.
13420 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
13421 attributes for example can not tell the difference between these.
13422 The difference was only a syntax feature of the language.
13424 * attribute.cs: Apply attributes to delegates.
13426 * delegate.cs: Call the apply attributes method.
13428 2003-11-24 Miguel de Icaza <miguel@ximian.com>
13430 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
13431 comparing 0 vs Byte.MinValue, not the value
13433 (ImplicitConversionRequired): When reporting a conversion error,
13434 use error 31 to print out the constant error instead of the
13437 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
13438 which fixes bug 51347.
13440 2003-11-22 Miguel de Icaza <miguel@ximian.com>
13442 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
13443 which fixes the -warnaserror command line option.
13445 2003-11-21 Miguel de Icaza <miguel@ximian.com>
13447 * cfold.cs (DoNumericPromotions): During constant folding of
13448 additions on UIntConstant, special case intconstants with
13449 IntConstants like we do on the expression binary operator.
13451 2003-11-12 Miguel de Icaza <miguel@ximian.com>
13453 * convert.cs (ImplicitReferenceConversion): We were missing a case
13454 (System.Enum are not value types or class types, so we need to
13455 classify them separatedly).
13457 * driver.cs: We do not support error 2007.
13459 2003-11-12 Jackson Harper <jackson@ximian.com>
13461 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
13462 system directory. Also use the full file name so users can
13463 libraries names mscorlib-o-tron.dll in a non system dir.
13465 2004-01-04 David Sheldon <dave-mono@earth.li>
13467 * expression.cs: Added matching ")" to error message for CS0077.
13469 2003-12-19 Martin Baulig <martin@ximian.com>
13471 * typemanager.cs (TypeManager.IsEqualGenericType): New public
13472 static method; see documentation in the method.
13473 (TypeManager.IsSubclassOrNestedChild): Allow IsEqualGenericType().
13475 * convert.cs (Convert.ImplicitReferenceConversion,
13476 Convert.ImplicitReferenceConversionExists): Add support for
13477 generic type declarations; see gen-36.cs.
13479 2003-12-19 Martin Baulig <martin@ximian.com>
13481 * pending.cs (Pending.InterfaceMethod): Use
13482 `Type.IsAssignableFrom()' instead of `=='.
13484 2003-12-18 Martin Baulig <martin@ximian.com>
13486 * decl.cs (DeclSpace.AsAccessible): Check for array, pointer and
13489 * convert.cs (Convert.ImplicitStandardConversionExists): Use
13490 `expr_type.Equals (target_type)' instead of `=='.
13492 2003-12-08 Martin Baulig <martin@ximian.com>
13494 * generics.cs (Constraints.Types): Removed.
13495 (Constraints.Resolve): Just resolve everything to TypeExpr's, not
13497 (Constraints.ResolveTypes): New public method; resolves the
13498 TypeExpr's to Type's.
13499 (TypeParameter.Define): TypeBuilder.DefineGenericParameter() no
13500 longer takes the constraints.
13501 (TypeParameter.DefineMethod): Likewise.
13502 (TypeParameter.DefineType): New public method. Calls
13503 `TypeBuilder/MethodBuilder.SetGenericParameterConstraints()' to set
13506 2003-12-08 Martin Baulig <martin@ximian.com>
13508 * convert.cs (Convert.ImplicitConversionStandard): Use
13509 `expr_type.Equals (target_type)' instead of `=='.
13511 2003-12-08 Martin Baulig <martin@ximian.com>
13513 * typemanager.cs (TypeManager.GetReferenceType): Call
13514 `Type.MakeByRefType ()'.
13516 2003-12-08 Martin Baulig <martin@ximian.com>
13518 * cs-parser.jay, cs-tokenizer.cs: `where' is not a keyword, it
13519 just has some special meaning in some situations. For instance,
13520 it is allowed to use `where' as the name of a variable etc.
13522 2003-12-04 Martin Baulig <martin@ximian.com>
13524 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
13525 `Type.MakeArrayType()' for array types.
13527 2003-11-18 Miguel de Icaza <miguel@ximian.com>
13529 * expression.cs (Invocation.VerifyArgumentsCompat): Remove
13532 (SizeOf.DoResolve): assign the `type_queried' field. This gets
13535 2003-11-16 Martin Baulig <martin@ximian.com>
13537 * codegen.cs (EmitContext.IsGeneric): Removed.
13539 * ecore.cs (SimpleName.ResolveAsTypeStep): Always call
13540 ResolveGeneric() on the DeclSpace.
13542 2003-11-16 Martin Baulig <martin@ximian.com>
13544 * generic.cs (TypeArguments.Resolve):
13545 `Expression.ResolveAsTypeTerminal()' returns a TypeExpr; call
13546 `ResolveType()' on it to get the Type.
13548 2003-11-15 Martin Baulig <martin@ximian.com>
13550 * generic.cs (ConstructedType.GetInterfaces): Override this.
13552 2003-11-14 Martin Baulig <martin@ximian.com>
13554 * interface.cs (Interface.DefineType): Define all type parameters
13555 before adding the interfaces we inherit.
13557 2003-11-11 Martin Baulig <martin@ximian.com>
13559 * generic.cs (ConstructedType.ResolveType): Always call
13560 `gt.BindGenericParameters (atypes)'; also if `args.HasTypeArguments'.
13562 2003-11-10 Martin Baulig <martin@ximian.com>
13564 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
13565 (TypeManager.InitCoreTypes): Initialize them here, but instead of
13566 calling `ResolveType()' on them, directly assign their `Type'.
13568 2003-11-08 Martin Baulig <martin@ximian.com>
13570 * generic.cs (ConstructedType): Override `IsClass' etc.
13572 2003-11-08 Martin Baulig <martin@ximian.com>
13574 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
13575 return value and the `out parent' parameter.
13576 (TypeContainer.DefineType): Moved the CS0644 check into
13577 GetClassBases(). Don't pass the interface types to the
13578 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
13579 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
13581 * ecore.cs (TypeExpr.IsAttribute): New property.
13582 (TypeExpr.GetInterfaces): New method.
13584 * interface.cs (Interface.GetInterfaceTypeByName): Return a
13585 TypeExpr instead of a Type.
13586 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
13587 (Interface.DefineType): Don't pass the interface types to the
13588 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
13589 them later and then call `TypeBulider.AddInterfaceImplementation()'.
13591 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
13592 instead of a `Type[]'.
13593 (TypeManager.RegisterBuilder): Likewise.
13594 (TypeManager.AddUserInterface): Likewise.
13595 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
13596 `Type[]' and also return a `TypeExpr[]'.
13597 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
13599 2003-11-08 Martin Baulig <martin@ximian.com>
13601 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
13604 2003-11-08 Martin Baulig <martin@ximian.com>
13606 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
13607 TypeManager.ResolveExpressionTypes().
13609 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
13610 instead of an Expression.
13611 (TypeExpr): This is now an abstract base class for `TypeExpression'.
13612 (TypeExpression): New public class; formerly known as `TypeExpr'.
13614 * expression.cs (ComposedCast): Derive from TypeExpr.
13616 * typemanager.cs (TypeManager.system_*_expr): These are now
13617 TypExpr's instead of Expression's.
13618 (TypeManager.ResolveExpressionTypes): New public static function;
13619 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
13622 2003-11-06 Miguel de Icaza <miguel@ximian.com>
13624 * expression.cs (New.DoResolve): Do not dereference value that
13625 might be a null return.
13627 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
13628 sure that the constant value has the right type. Fixes an
13629 unreported bug, similar to 50425.
13631 * const.cs (Const.LookupConstantValue): Call
13632 ImplicitStandardConversionExists before doing a conversion to
13633 avoid havng the TypeManager.ChangeType do conversions.
13635 Reduced the number of casts used
13637 (Const.ChangeType): New routine to enable reuse of the constant
13638 type changing code from statement.
13640 * typemanager.cs (ChangeType): Move common initialization to
13641 static global variables.
13645 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
13646 every value type to go through, even if it was void. Fix that.
13648 * cs-tokenizer.cs: Use is_identifier_start_character on the start
13649 character of the define, and the is_identifier_part_character for
13650 the rest of the string.
13652 2003-11-05 Miguel de Icaza <miguel@ximian.com>
13654 * expression.cs (UnaryMutator.EmitCode): When I updated
13655 LocalVariableReference.DoResolve, I overdid it, and dropped an
13656 optimization done on local variable references.
13658 2003-11-04 Miguel de Icaza <miguel@ximian.com>
13660 * ecore.cs: Convert the return from Ldlen into an int.
13662 2003-10-20 Miguel de Icaza <miguel@ximian.com>
13664 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
13665 the accessibility, this is a special case for toplevel non-public
13666 classes (internal for instance).
13668 2003-10-20 Nick Drochak <ndrochak@gol.com>
13670 * ecore.cs: Fix typo and build. Needed another right paren.
13672 2003-10-19 Miguel de Icaza <miguel@ximian.com>
13674 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
13675 `internal' case regular and protected, but not allowing protected
13676 to be evaluated later. Bug 49840
13678 2003-10-15 Miguel de Icaza <miguel@ximian.com>
13680 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
13681 to kb.Nlast, and not the kb.nFirst to isolate the switch
13684 Extract the underlying type, so enumerations of long/ulong are
13685 treated like long/ulong.
13687 2003-10-14 Miguel de Icaza <miguel@ximian.com>
13689 * expression.cs (New): Overload the meaning of RequestedType to
13690 track the possible creation of the NewDelegate type, since
13691 DoResolve is invoked more than once for new constructors on field
13694 See bugs: #48800 and #37014
13696 * cs-parser.jay (declare_local_constants): Take an arraylist
13697 instead of a single constant.
13699 (local_constant_declaration): It should take a
13700 constant_declarators, not a constant_declarator. Fixes 49487
13702 * convert.cs: Fix error report.
13704 2003-10-13 Jackson Harper <jackson@ximian.com>
13706 * typemanager.cs (TypeToCoreType): Add float and double this fixes
13709 2003-11-03 Martin Baulig <martin@ximian.com>
13711 * expression.cs (ArrayAccess.GetStoreOpcode): Added
13712 `out bool has_type_arg'; if set, we need to pass the type to
13714 (ArrayAccess.GetStoreOpcode, ArrayAccess.EmitLoadOpcode): Use
13715 Stelem_Any/Ldelem_Any for generic parameters.
13717 2003-11-02 Martin Baulig <martin@ximian.com>
13719 * expression.cs (Invocation.EmitCall): Use
13720 `TypeManager.IsValueType()' to check whether it's a value type.
13721 Don't set `struct_call' when calling a method on a type parameter.
13723 2003-11-02 Martin Baulig <martin@ximian.com>
13725 * generics.cs (ConstructedType.Resolve): Renamed to ResolveType()
13726 and removed the TypeBuilder argument.
13728 * typemanager.cs (TypeManager.IsValueType): Return
13729 `t.IsGenericParameter || t.IsValueType'.
13731 2003-10-25 Martin Baulig <martin@ximian.com>
13733 * decl.cs (DeclSpace.ResolveType): If we're a ConstructedType,
13734 call ConstructedType.Resolve() on it.
13736 * generic.cs (ConstructedType.Resolve): Set `type' on success.
13738 2003-10-25 Martin Baulig <martin@ximian.com>
13740 * class.cs (TypeContainer.GetClassBases): Changed
13741 `out Type parent' into `out TypeExpr parent'. Moved CS0644 and
13742 CS8214 reporting here.
13743 (TypeContainer.DefineType): GetClassBases() gives us a `TypeExpr'
13744 instead of a `Type' for our parent. In case of a recursive
13745 declaration (see tests/gen-23.cs for an example), our parent is a
13746 ConstructedType and it doesn't have its type set. So, first
13747 create our own TypeBuilder, then call constructed.Resolve() to get
13748 the parent's type and finally TypeBuilder.SetParent() it.
13750 * ecore.cs (TypeExpr.Name): New public virtual property.
13753 (ConstructedType): We're now a TypeExpr and not just an Expression.
13754 (ConstructedType.ResolveAsTypeStep): Don't resolve our type
13755 arguments here; this is done later.
13756 (ConstructedType.Resolve): New public method to resolve the type
13757 arguments and bind them.
13759 2003-10-21 Martin Baulig <martin@ximian.com>
13761 * convert.cs: Use `TypeManager.IsValueType' instead of
13762 'type.IsValueType' everywhere.
13764 * typemanager.cs (TypeManager.IsValueType): Return true for type
13765 parameters. The reason for this is that we need to box a type
13766 parameter when converting it to a reference type.
13768 * cs-parser.jay: Added support for default value expressions.
13770 * generics.cs (DefaultValueExpression): New public class.
13772 2003-10-17 Martin Baulig <martin@ximian.com>
13774 * generic.cs (Constraints.Resolve): Take a DecpSpace instead of a
13775 TypeContainer so we can also use this for Interfaces.
13776 (TypeParameter.Resolve): Likewise.
13778 * interface.cs (Interface.DefineType): Added support for generic
13781 * cs-parser.jay: Added support for generic structs and interfaces.
13783 2003-10-17 Martin Baulig <martin@ximian.com>
13785 * generic.cs (GenericMemberAccess.DoResolve): We can now actually
13786 call generic methods :-)
13788 2003-10-16 Martin Baulig <martin@ximian.com>
13790 * cs-parser.jay (namespace_or_type_name): Only create a
13791 GenericMemberAccess if we actually have type arguments.
13793 2003-10-13 Martin Baulig <martin@ximian.com>
13795 * class.cs (Method.Define): If we're a generic method, call
13796 TypeBuilder.DefineGenericMethod () before resolving
13798 (MethodData): Added .ctor which takes an additional MethodBuilder
13799 argument; this is used for generic methods.
13800 (MethodData.Define): Call `builder.SetGenericMethodSignature()' if
13801 we already have a MethodBuilder.
13803 2003-10-10 Martin Baulig <martin@ximian.com>
13805 * class.cs (Method): Added .ctor which takes a `GenericMethod'
13806 instead of a `DeclSpace'. This is used for generic methods.
13808 * cs-parser.jay (method_header): Added support for generic
13809 methods; create a `GenericMethod' instance and pass it to the
13810 `Method's .ctor; it'll be used as the `DeclSpace' to lookup
13811 parameters and locals.
13813 * decl.cs (DeclSpace.SetParameterInfo): Removed Location argument
13814 since we already have the location. Check whether we're a generic
13815 type declaration or a generic method and create the correct type
13818 * generic.cs (TypeParameter.DefineMethod): New public method.
13819 (GenericMethod): New public class; derives from DeclSpace and is
13820 used for generic methods.
13822 2003-10-09 Martin Baulig <martin@ximian.com>
13824 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
13826 (MethodCore.DoDefineParameters): Removed the TypeContainer
13827 argument; use the DeclSpace which was passed to the .ctor instead.
13828 (MethodCore.CheckParameter): Take a DeclSpace instead of a
13829 TypeContainer; we only need a DeclSpace here.
13831 2003-10-09 Martin Baulig <martin@ximian.com>
13833 * class.cs (MethodData): Added additional `DeclSpace ds' argument
13835 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
13836 EmitContext's .ctor.
13838 2003-10-09 Martin Baulig <martin@ximian.com>
13840 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
13841 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
13842 AsAccessible(), moved them as well.
13844 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
13846 2003-10-07 Miguel de Icaza <miguel@ximian.com>
13848 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
13849 generation for >=, as spotted by Paolo, bug 48679.
13850 Patch from David Waite.
13852 * cs-tokenizer.cs: Add handling for #pragma.
13854 * cs-parser.jay: Allow for both yield and yield return in the
13855 syntax. The anti-cobolization of C# fight will go on!
13857 * class.cs (TypeBuilder.DefineType): Catch error condition here
13858 (Parent.DefineType erroring out and returning null).
13860 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
13861 coping with enumerations variables, we were mistakenly processing
13862 them as a regular value type instead of built-in types. Fixes the
13865 * typemanager.cs (IsBuiltinOrEnum): New method.
13867 2003-09-30 Miguel de Icaza <miguel@ximian.com>
13869 * cs-parser.jay: Upgrade: yield now needs the return clause.
13871 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
13873 * cs-parser.jay : Renamed yyName to yyNames related to jay.
13875 2003-09-29 Martin Baulig <martin@ximian.com>
13877 * typemanager.cs (TypeManager.GetMethodFlags): Added support for
13878 inflated generic methods.
13880 * generics.cs (ConstructedType): Distinguish between open and
13881 closed constructed types; correctly resolve the arguments.
13883 2003-09-22 Martin Baulig <martin@ximian.com>
13885 * generic.cs (ConstructedType.ResolveAsTypeCheck): Check whether
13886 all type arguments meet their constraints.
13888 2003-09-19 Martin Baulig <martin@ximian.com>
13890 * decl.cs (MemberCache.SetupCacheForInterface): Take a
13891 `MemberCache parent' argument. Normally, an interface doesn't
13892 have a parent type except System.Object, but we use this in gmcs
13893 for generic type parameters.
13895 2003-09-18 Martin Baulig <martin@ximian.com>
13897 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
13898 on `type.IsInterface'; don't check whether the type has a parent
13899 to determine whether it's an interface.
13901 2003-09-17 Martin Baulig <martin@ximian.com>
13903 * generic.cs (ConstructedType.ToString): Always use `name' as the
13906 2003-09-15 Martin Baulig <martin@ximian.com>
13908 * cs-parser.jay: Fix grammar wrt. type_parameter_constraints.
13910 * generic.cs (Constraints.Resolve): New public method; this is
13911 called to resolve the constraint types and to check whether all
13912 the constraints are correct.
13913 (Constraints.Types): New public property.
13914 (TypeParameter.Resolve): New public method; resolves all the
13915 type's constraints.
13917 * class.cs (TypeContainer.DefineType): Call
13918 TypeParameter.Resolve() before actually defining the type.
13920 2003-09-15 Martin Baulig <martin@ximian.com>
13922 * class.cs (TypeContainer.DefineType): Added an error flag to
13923 avoid reporting duplicate CS0146's ("class definition is
13926 * driver.cs (Driver.MainDriver): Abort if
13927 RootContext.ResolveTree() reported any errors.
13929 2003-09-07 Martin Baulig <martin@ximian.com>
13931 * report.cs (Error, Warning): Added overloaded versions which take
13932 a `params object[] args' and call String.Format().
13934 2003-09-07 Martin Baulig <martin@ximian.com>
13936 * decl.cs (DeclSpace..ctor): Don't call
13937 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
13938 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
13939 (DeclSpace.RecordDecl): New method.
13941 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
13943 2003-09-02 Ravi Pratap <ravi@ximian.com>
13945 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
13946 value attributes to be applied to ParameterBuilders.
13948 * class.cs (MethodCore.LabelParameters): Make static and more
13949 generic so that it can be used from other places - like interface
13950 methods, for instance.
13952 * interface.cs (Interface.Emit): Call LabelParameters before
13953 emitting attributes on the InterfaceMethod.
13955 2003-09-07 Martin Baulig <martin@ximian.com>
13957 * generic.cs (ConstructedType.ResolveAsTypeStep): Report a CS8217
13958 if the number of type parameters doesn't match.
13960 2003-09-04 Martin Baulig <martin@ximian.com>
13962 * expression.cs (ComposedCast.ResolveAsTypeStep): Added support
13963 for arrays of generic type params (ie. `!0[]').
13965 2003-09-04 Martin Baulig <martin@ximian.com>
13967 * class.cs (TypeContainer.AsAccessible): Ignore generic parameters
13970 2003-09-04 Martin Baulig <martin@ximian.com>
13972 * decl.cs (DeclSpace.LookupGeneric): New method.
13973 (DeclSpace.CheckAccessLevel): Ignore generic parameters for the
13976 * generic.cs (TypeParameterExpr): Take a TypeParameter as
13977 argument, not just a string.
13978 (TypeParameter.Define): New public method; this is called to
13979 actually define the generic parameter; after this, you can use the
13980 new `Type' property to get the type.
13982 2003-09-04 Martin Baulig <martin@ximian.com>
13984 * decl.cs (DeclSpace.SetParameterInfo): The `constraints' argument
13985 is now an ArrayList; initialize the result of the `TypeParameters'
13987 (DeclSpace.GetGenericData): Removed.
13988 (DeclSpace.LookupGeneric): Temporarily removed; we need to
13989 implement this in a different way.
13990 (DeclSpace.GetTypeParameters): Removed; there's now a
13991 `TypeParameters' property.
13992 (DeclSpace.TypeParameters): New public property.
13994 * generic.cs (Constraints): Make this class public.
13995 (TypeParameter): New public class.
13997 2003-09-04 Martin Baulig <martin@ximian.com>
13999 * decl.cs (DeclSpace.GetTypeParameters): New method to return the
14000 generic parameters.
14002 * class.cs (TypeContainer.DefineType): Call
14003 TypeBuilder.DefineGenericParameter () on all generic parameters if
14004 this is a generic type.
14006 2003-08-28 Martin Baulig <martin@ximian.com>
14008 * sample-stack.il: Compile this with ilasm: "ilasm /dll
14011 * sample-hello.cs: Compile this with gmcs: "gmcs
14012 /r:sample-stack.dll sample-hello.cs".
14014 2003-08-28 Martin Baulig <martin@ximian.com>
14016 * generic.cs (ConstructedType.ResolveAsTypeStep): Actually bind
14017 the parameters to the generic type.
14019 2003-08-28 Martin Baulig <martin@ximian.com>
14021 * cs-tokenizer.cs (parse_less_than): Also allow all builtin types.
14023 2003-08-28 Martin Baulig <martin@ximian.com>
14025 * cs-parser.jay (opt_type_argument_list): Use
14026 `OP_GENERICS_LT type_arguments OP_GENERICS_GT'.
14027 (primary_expression): Replace `qualified_identifier' with `type_name'.
14028 (type_parameter_list): Use `OP_GENERICS_LT type_parameters OP_GENERICS_GT'.
14030 * cs-tokenizer.cs (is_punct): When reading a `<', invoke a custom
14031 parser to check whether it is syntactically a type parameter list;
14032 return OP_GENERICS_LT/OP_GENERICS_GT instead of OP_LT/OP_GT in
14035 2003-08-26 Martin Baulig <martin@ximian.com>
14037 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
14038 resolving aliases; fixes #47927.
14040 2003-08-26 Martin Baulig <martin@ximian.com>
14042 * statement.cs (Using.DoResolve): This is internally emitting a
14043 try/finally clause, so we need to set ec.NeedExplicitReturn if we
14044 do not always return. Fixes #47681.
14046 2003-08-26 Martin Baulig <martin@ximian.com>
14048 * decl.cs (MemberCore): Moved WarningNotHiding(),
14049 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
14051 (AdditionResult): Make this nested in DeclSpace.
14052 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
14053 argument; call NamespaceEntry.Define() unless we're nested in a
14056 * namespace.cs (Namespace.DefineName): New public function. This
14057 is called from DeclSpace's .ctor to add
14058 (Namespace.Lookup): Include DeclSpaces in the lookup.
14060 * class.cs (Operator): Derive from MemberBase, not MemberCore.
14062 * const.cs (Const): Derive from MemberBase, not MemberCore.
14064 2003-08-25 Martin Baulig <martin@ximian.com>
14066 * convert.cs (Convert.ExplicitReferenceConversion): When
14067 converting from an interface type to a class, unbox if the target
14068 type is a struct type. Fixes #47822.
14070 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
14072 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
14075 2003-08-22 Martin Baulig <martin@ximian.com>
14077 * class.cs (TypeManager.DefineType): When defining a nested type,
14078 call DefineType() on our parent; fixes #47801.
14080 2003-08-22 Martin Baulig <martin@ximian.com>
14082 * class.cs (MethodData.Define): While checking if a method is an
14083 interface implementation, improve the test a bit more to fix #47654.
14085 2003-08-22 Martin Baulig <martin@ximian.com>
14087 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
14088 correctly; fixes #47722.
14090 2003-08-22 Martin Baulig <martin@ximian.com>
14092 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
14093 LocalVariableReference, ensure it's not read-only. Fixes #47536.
14095 * statement.cs (Fixed.DoResolve): Make all variables read-only.
14097 2003-08-22 Martin Baulig <martin@ximian.com>
14099 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
14100 can only be assigned in static constructors. Fixes #47161.
14102 2003-08-22 Martin Baulig <martin@ximian.com>
14104 Rewrote and improved the flow analysis code.
14106 * flowbranching.cs (FlowBranching): Make this class abstract.
14107 (FlowBranching.CreateBranching): New static function to create a
14108 new flow branching.
14109 (FlowBranchingBlock, FlowBranchingException): New classes.
14110 (FlowBranching.UsageVector.Type): New public readonly field.
14111 (FlowBranching.UsageVector.Breaks): Removed the setter.
14112 (FlowBranching.UsageVector.Returns): Removed the setter.
14113 (FlowBranching.UsageVector): Added Break(), Return(),
14114 NeverReachable() and Throw() methods to modify the reachability.
14115 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
14116 done by FlowBranching.Merge().
14117 (FlowBranching.UsageVector.MergeChild): New method; merges the
14118 merge result into the current vector.
14119 (FlowBranching.Merge): New abstract method to merge a branching.
14121 2003-08-12 Martin Baulig <martin@ximian.com>
14123 * expression.cs (Indirection.CacheTemporaries): Create the
14124 LocalTemporary with the pointer type, not its element type.
14126 2003-08-10 Miguel de Icaza <miguel@ximian.com>
14128 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
14129 token was a keyword or not.
14131 Add `error' options where an IDENTIFIER was expected; Provide
14132 CheckToken and CheckIdentifierToken convenience error reporting
14135 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
14137 * decl.cs: Rename `NamespaceEntry Namespace' public field into
14138 NameSpaceEntry NameSpaceEntry.
14140 (LookupInterfaceOrClass): Avoid creating a full qualified name
14141 from namespace and name: avoid doing lookups when we know the
14142 namespace is non-existant. Use new Tree.LookupByNamespace which
14143 looks up DeclSpaces based on their namespace, name pair.
14145 * driver.cs: Provide a new `parser verbose' to display the
14146 exception thrown during parsing. This is turned off by default
14147 now, so the output of a failure from mcs is more graceful.
14149 * namespace.cs: Track all the namespaces defined in a hashtable
14152 (IsNamespace): New method
14154 2003-08-09 Miguel de Icaza <miguel@ximian.com>
14156 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
14157 we know that we need to concatenate (full typename can never be
14162 * statement.cs: Use a bitfield; Do not initialize to null things
14163 which are done by the constructor by default.
14165 * cs-parser.jay: bug fix, parameter was 4, not 3.
14167 * expression.cs: Just use the property;
14169 * statement.cs: No need for GetVariableInfo method.
14171 2003-08-08 Martin Baulig <martin@ximian.com>
14173 * flowanalysis.cs (FlowReturns): This is now nested in the
14174 `FlowBranching' class.
14175 (MyBitVector): Moved this here from statement.cs.
14176 (FlowBranching.SiblingType): New enum type.
14177 (FlowBranching.CreateSibling): Added `SiblingType' argument.
14179 2003-08-07 Martin Baulig <martin@ximian.com>
14181 * flowanalysis.cs (FlowBranchingType): This is now nested in the
14182 `FlowBranching' class and called `BranchingType'.
14184 2003-08-07 Martin Baulig <martin@ximian.com>
14186 * flowanalysis.cs: Moved all the control flow analysis code into
14189 2003-08-07 Martin Baulig <martin@ximian.com>
14191 * assign.cs (Assign.DoResolve): `target' must either be an
14192 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
14195 2003-08-07 Miguel de Icaza <miguel@ximian.com>
14197 * expression.cs (BinaryMethod): This kind of expression is created by the
14198 Binary class if it determines that the operator has to be handled
14201 (BinaryDelegate): This kind of expression is created if we are
14202 dealing with a + or - operator on delegates.
14204 (Binary): remove method, argumetns, and DelegateOperator: when
14205 dealing with methods,
14207 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
14209 * statement.cs (Block): use bitfields for the three extra booleans
14210 we had in use. Remove unused topblock parameter.
14212 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
14214 * assign.cs: Drop extra unneeded tests.
14216 2003-08-06 Miguel de Icaza <miguel@ximian.com>
14218 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
14220 * statement.cs (Foreach): Use VariableStorage instead of
14223 * codegen.cs (VariableStorage): New class used by clients that
14224 require a variable stored: locals or fields for variables that
14225 need to live across yield.
14227 Maybe provide a convenience api for EmitThis+EmitLoad?
14229 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
14232 2003-08-05 Miguel de Icaza <miguel@ximian.com>
14234 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
14235 RemapParameterLValue): New methods that are used to turn a
14236 precomputed FieldInfo into an expression like this:
14240 The idea is to use this instead of making LocalVariableReference
14241 have more than one meaning.
14243 * cs-parser.jay: Add error production to BASE.
14245 * ecore.cs: Deal with TypeManager.GetField returning null, which
14246 is now a valid return value.
14248 (FieldExprNoAddress): New expression for Fields whose address can
14251 * expression.cs (LocalVariableReference): During the resolve
14252 phases, create new expressions if we are in a remapping context.
14253 Remove code that dealt with remapping here.
14255 (ParameterReference): same.
14257 (ProxyInstance): New expression, like the `This' expression, but
14258 it is born fully resolved. We know what we are doing, so remove
14259 the errors that are targeted to user-provided uses of `this'.
14261 * statement.cs (Foreach): our variable is now stored as an
14262 Expression; During resolution, follow the protocol, dont just
14263 assume it will return this.
14265 2003-08-06 Martin Baulig <martin@ximian.com>
14267 * support.cs (SeekableStreamReader.cs): New public class.
14269 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
14270 SeekableStreamReader instead of the normal StreamReader.
14272 2003-08-04 Martin Baulig <martin@ximian.com>
14274 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
14275 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
14276 deambiguate casts and delegate invocations.
14277 (parenthesized_expression): Use the new tokens to ensure this is
14278 not a cast of method invocation.
14280 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
14281 when reading a `)' and Deambiguate_CloseParens () was previously
14284 * expression.cs (ParenthesizedExpression): New class. This is
14285 just used for the CS0075 test.
14286 (Binary.DoResolve): Check for CS0075.
14288 2003-07-29 Ravi Pratap <ravi@ximian.com>
14290 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
14291 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
14292 reference comparison.
14294 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
14295 examine the ReturnType for equality - this is necessary in the
14296 cases of implicit and explicit operators whose signature also
14297 includes the return type.
14299 2003-07-26 Miguel de Icaza <miguel@ximian.com>
14301 * namespace.cs: Cache the result of the namespace computation,
14302 instead of computing it every time.
14304 2003-07-24 Miguel de Icaza <miguel@ximian.com>
14306 * decl.cs: Use a global arraylist that we reuse over invocations
14307 to avoid excesive memory consumption. Reduces memory usage on an
14308 mcs compile by one meg (45 average).
14310 * typemanager.cs (LookupTypeReflection): In .NET pointers are
14311 private, work around that.
14313 2003-07-23 Miguel de Icaza <miguel@ximian.com>
14315 * literal.cs (IntLiteral): Define Zero and One static literals.
14317 * cs-parser.jay (integer_literal): use static literals to reduce
14318 memory usage for the most used literals (0, 1 and -1). 211kb
14319 reduced in memory usage.
14321 Replace all calls to `new ArrayList' with `new
14322 ArrayList(4)' which is a good average number for most allocations,
14323 and also requires only 16 bytes of memory for its buffer by
14326 This reduced MCS memory usage in seven megabytes for the RSS after
14329 2003-07-28 Ravi Pratap <ravi@ximian.com>
14331 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
14332 handle params methods the correct way by forming only one
14333 applicable set with params and normal methods in them. Earlier we
14334 were looking at params methods only if we found no normal methods
14335 which was not the correct thing to do.
14337 (Invocation.BetterFunction): Take separate arguments indicating
14338 when candidate and the best method are params methods in their
14341 This fixes bugs #43367 and #46199.
14343 * attribute.cs: Documentation updates.
14345 (CheckAttribute): Rename to CheckAttributeTarget.
14346 (GetValidPlaces): Rename to GetValidTargets.
14348 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
14349 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
14353 2003-07-28 Miguel de Icaza <miguel@ximian.com>
14355 * codegen.cs: Compute IsGeneric correctly.
14357 * cs-parser.jay: Introduce OP_GENERIC_LT for the grammar ambiguity
14360 Bring back (temporarily) OP_LEFT_SHIFT, OP_RIGHT_SHIFT,
14361 OP_SHIFT_RIGHT_ASSIGN, OP_SHIFT_LEFT_ASSIGN. There were too many
14362 regressions, and I was chasing more bugs than I required.
14364 * interface.cs: Use expressions for base type names (like classes
14365 and structs have been doing for a while now), and resolve that.
14366 This patch should probably go into head as well.
14368 This makes it one less user of FindType.
14370 2003-07-24 Miguel de Icaza <miguel@ximian.com>
14372 This compiler can not self host currently. Need to fix that.
14374 * Makefile: compile to `gmcs.exe'
14376 * driver.cs: Turn on v2 by default on gmcs.
14378 * generic.cs (ConstructedType): Does no longer take a container
14379 type argument; That will be taken care of later.
14381 (ConstructedType.DoResolve, ConstructedType.ResolveAsTypeStep):
14382 Use SimpleName to resolve for now, so we can continue the work on
14383 the parser, until we get Type.GetType that understands generics.
14385 (ConstructedType.ToString): Implement
14387 (TypeArguments.Resolve): Resolve the child expressions as types.
14389 * cs-parser.jay: Rename interface_constraints to
14390 type_parameter_constraints
14392 (namespace_or_type_name): Only use constructed types for the basic
14393 construction, we will deal with identifier<...> later.
14395 (type/type_name): No longer call DecomposeQI, as
14396 namespace_or_type_name is always decoded now.
14398 2003-07-22 Ravi Pratap <ravi@ximian.com>
14400 * expression.cs (Invocation.OverloadResolve): Follow the spec more
14401 closely: we eliminate methods in base types when we have an
14402 applicable method in a top-level type.
14404 Please see section 14.5.5.1 for an exact description of what goes
14407 This fixes bug #45127 and a host of other related to corlib compilation.
14409 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
14410 array is the method corresponding to the top-level type (this is
14411 because of the changes made to icall.c) so we change this
14414 (MethodGroupExpr.Name): This too.
14416 * typemanager.cs (GetElementType): New method which does the right
14417 thing when compiling corlib.
14419 * everywhere: Make use of the above in the relevant places.
14421 2003-07-22 Martin Baulig <martin@ximian.com>
14423 * cs-parser.jay (invocation_expression): Moved
14424 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
14425 `cast_expression', but create a InvocationOrCast which later
14426 resolves to either an Invocation or a Cast.
14428 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
14429 method; call this before EmitStatement() to make sure that this
14430 expression can be used as a statement.
14432 * expression.cs (InvocationOrCast): New class; resolves to either
14433 an Invocation or a Cast.
14435 * statement.cs (StatementExpression): Call ResolveStatement() on
14436 the ExpressionStatement before emitting it.
14438 2003-07-21 Martin Baulig <martin@ximian.com>
14440 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
14441 `ref' and `out' attributes match; fixes #46220.
14442 (MemberAccess.ResolveMemberAccess): You can't reference a type
14443 through an expression; fixes #33180.
14444 (Indexers.GetIndexersForType): Don't return the indexers from
14445 interfaces the class implements; fixes #46502.
14447 2003-07-21 Martin Baulig <martin@ximian.com>
14449 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
14450 CS0661 checks; fixes bug #30442.
14452 2003-07-21 Martin Baulig <martin@ximian.com>
14454 * decl.cs (AdditionResult): Added `Error'.
14456 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
14458 * typemanager.cs (TypeManager.ChangeType): Catch exceptions; makes
14459 cs0031.cs actually work.
14461 2003-07-20 Miguel de Icaza <miguel@ximian.com>
14463 * cs-parser.jay (namespace_name): do not use
14464 namespace_or_type_name, use qualified_identifier, because
14465 namespace_or_type_name will soon return a composed expression
14466 instead of a string.
14468 (namespace_or_type_name): Instead of returning a string, now this
14469 production returns an expression.
14471 * codegen.cs (EmitContext): Setup IsGeneric property based on
14472 whether our DeclSpace is generic, our the method is generic.
14474 * modifier.cs (Modifiers.METHOD_GENERIC): New definition, use if
14475 the method is generic.
14477 * cs-parser.jay (type_arguments, opt_type_argument_list,
14478 type_parameters, type_parameter_list, opt_type_parameter_list,
14479 type_parameter,, opt_type_parameter_constraints_clauses,
14480 type_parameter_constraints_clauses,
14481 type_parameter_constraint_clause, type_parameter_constraint,
14482 interface_constraints): Add new production
14484 * decl.cs (DeclSpace): IsGeneric, flag to track whether this
14485 DeclSpace is generic or not.
14487 (DeclSpace.SetParameterInfo): New routine, used to set the
14488 parameter info for a type.
14490 (DeclSpace.LookupGeneric): Lookups a name, and if it is a generic,
14491 returns a GenericTypeExpr
14493 * ecore.cs (SimpleName.ResolveAsTypeStep): If our container is
14494 generic, lookup the generic argument.
14496 * attribute.cs: Do not allow TypeParameterExpressions in
14499 * class.cs: Do not allow the Main method to be defined in a
14502 * expression.cs (SizeOf): Do not allow generic types to be used as
14503 arguments to sizeof.
14505 * typemanager.cs (IsGeneric): Wrapper for Reflection when we have
14506 it: whether a type is generic or not. Only works for types we are
14507 currently building for now.
14509 2003-07-20 Martin Baulig <martin@ximian.com>
14511 * namespace.cs: Fixed that bug which caused a crash when compiling
14512 the debugger's GUI.
14514 2003-07-20 Miguel de Icaza <miguel@ximian.com>
14516 * typemanager.cs (LookupTypeReflection): Never expose types which
14517 are NotPublic, NestedPrivate, NestedAssembly, or
14518 NestedFamANDAssem. We used to return these, and later do a check
14519 that would report a meaningful error, but the problem is that we
14520 would not get the real match, if there was a name override.
14522 2003-07-18 Miguel de Icaza <miguel@ximian.com>
14524 * namespace.cs (Namespace, Name): Do not compute the namespace
14525 name dynamically, compute it in the constructor. This reduced
14526 memory usage by 1697 KB.
14528 * driver.cs: Use --pause to pause at the end.
14530 2003-07-17 Peter Williams <peter@newton.cx>
14532 * Makefile: Change the name of the test target so that it doesn't
14533 conflict with the recursive test target.
14535 2003-07-17 Miguel de Icaza <miguel@ximian.com>
14537 * expression.cs (LocalVariableReference.Emit, EmitAssign,
14538 AddressOf): Do not use EmitThis, that was wrong, use the actual
14541 2003-07-15 Miguel de Icaza <miguel@ximian.com>
14543 * class.cs (MethodData.Define): While checking if a method is an
14544 interface implementation, improve the test: If we are not public
14545 (use new test here: use the computed MethodAttributes directly,
14546 instead of the parsed modifier flags) check if the `implementing'
14547 method comes from an interface or not.
14549 * pending.cs (VerifyPendingMethods): Slightly better error
14552 * makefile: add test target that does the mcs bootstrap.
14554 2003-07-16 Ravi Pratap <ravi@ximian.com>
14556 * interface.cs (Define): Do nothing here since there are no
14557 members to populate etc. Move the attribute emission out of here
14558 since this was just totally the wrong place to put it. Attribute
14559 application happens during the 'Emit' phase, not in the 'Define'
14562 (Emit): Add this method and move the attribute emission here
14564 * rootcontext.cs (EmitCode): Call the Emit method on interface
14567 2003-07-14 Ravi Pratap M <ravi@ximian.com>
14569 * expression.cs (OverloadResolve): Report error only if Location
14570 is not 'Null' which means that there was a probe going on.
14572 2003-07-14 Martin Baulig <martin@ximian.com>
14574 * expression.cs (ConditionalLogicalOperator): New public class to
14575 implement user defined conditional logical operators.
14576 This is section 14.11.2 in the spec and bug #40505.
14578 2003-07-14 Martin Baulig <martin@ximian.com>
14580 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
14582 2003-07-14 Martin Baulig <martin@ximian.com>
14584 * codegen.cs (EmitContext.InFixedInitializer): New public field.
14586 * ecore.cs (IVariable.VerifyFixed): New interface method.
14588 * expression.cs (Unary.ResolveOperator): When resolving the `&'
14589 operator, check whether the variable is actually fixed. Fixes bug
14590 #36055. Set a variable definitely assigned when taking its
14591 address as required by the spec.
14593 * statement.cs (LocalInfo.IsFixed): New field.
14594 (LocalInfo.MakePinned): Set `IsFixed' to true.
14596 2003-07-14 Ravi Pratap M <ravi@ximian.com>
14598 * attribute.cs (Attribute.Resolve): While doing a Member lookup
14599 for .ctors, ensure that we only ask for members declared in the
14600 attribute type (BindingFlags.DeclaredOnly).
14604 * expression.cs (Error_WrongNumArguments): Report error 1501
14605 correctly the way CSC does.
14607 2003-07-13 Martin Baulig <martin@ximian.com>
14609 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
14610 lookup on the fully qualified name, to make things like "X.X" work
14611 where "X.X" is a fully qualified type name, but we also have a
14612 namespace "X" in the using list. Fixes #41975.
14614 2003-07-13 Martin Baulig <martin@ximian.com>
14616 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
14617 function. If we're a CompoundAssign, we need to create an embedded
14618 CompoundAssign, not an embedded Assign.
14619 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
14622 2003-07-13 Martin Baulig <martin@ximian.com>
14624 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
14625 work to fix bug #46088.
14627 2003-07-13 Ravi Pratap <ravi@ximian.com>
14629 * class.cs (Operator.Emit): Do not emit attributes here - it is
14630 taken care of by the Method class that we delegate too. This takes
14631 care of bug #45876.
14633 2003-07-10 Martin Baulig <martin@ximian.com>
14635 * expression.cs (TypeOfVoid): New class.
14636 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
14638 2003-07-10 Martin Baulig <martin@ximian.com>
14640 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
14643 2003-07-10 Martin Baulig <martin@ximian.com>
14645 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
14646 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
14648 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
14650 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
14652 2003-07-10 Martin Baulig <martin@ximian.com>
14654 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
14655 of decimal. Fixes #42850.
14657 NOTE: I also fixed the created byte blob, but this doesn't work on
14658 the MS runtime and csc never produces any byte blobs for decimal
14661 2003-07-10 Martin Baulig <martin@ximian.com>
14663 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
14664 structs; fixes #32068.
14665 (Block.AddChildVariableNames): Fixed #44302.
14667 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
14669 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
14671 2003-07-07 Miguel de Icaza <miguel@ximian.com>
14673 * attribute.cs: And this test is onger needed.
14675 2003-07-08 Martin Baulig <martin@ximian.com>
14677 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
14678 inaccessible types. Fixes #36313.
14680 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
14682 * namespace.cs (NamespaceEntry): Create implicit entries for all
14683 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
14684 implicit entries for N1.N2 and N1.
14686 2003-07-08 Martin Baulig <martin@ximian.com>
14688 Rewrote the handling of namespaces to fix a lot of the issues
14689 wrt. `using' aliases etc.
14691 * namespace.cs (Namespace): Splitted this class into a
14692 per-assembly `Namespace' and a per-file `NamespaceEntry'.
14694 * typemanager.cs (TypeManager.IsNamespace): Removed.
14695 (TypeManager.ComputeNamespaces): Only compute namespaces from
14696 loaded assemblies here, not the namespaces from the assembly we're
14697 currently compiling.
14699 2003-07-08 Martin Baulig <martin@ximian.com>
14701 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
14703 2003-07-07 Miguel de Icaza <miguel@ximian.com>
14705 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
14708 I thought about the memory savings here, but LookupTypeReflection
14709 is used under already very constrained scenarios. Compiling
14710 corlib or mcs only exposes one hit, so it would not really reduce
14711 any memory consumption.
14713 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
14715 * typemanager.cs: fixes bug #45889 by only adding public types from
14716 other assemblies to the list of known types.
14718 2003-07-07 Miguel de Icaza <miguel@ximian.com>
14720 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
14721 on the type we resolved.
14723 2003-07-05 Martin Baulig <martin@ximian.com>
14725 * pending.cs (PendingImplementation.ParentImplements): Don't
14726 create the proxy if the parent is abstract.
14728 * class.cs (TypeContainer.DefineIndexers): Process explicit
14729 interface implementations first. Fixes #37714.
14731 2003-07-04 Miguel de Icaza <miguel@ximian.com>
14733 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
14734 defined recursively; but since we modify the input parameters
14735 (left is set to `this' temporarily), we reset this value if the
14736 left_is_explicit is false, which gives the original semantics to
14739 * literal.cs (NullPointer): new class used to represent a null
14740 literal in a pointer context.
14742 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
14743 type is a pointer, use a NullPointer object instead of a
14744 NullLiteral. Closes 43687
14746 (ExplicitConversion): Convert pointer values using
14747 the conv opcode to the proper type.
14749 * ecore.cs (New): change ValueTypeVariable property into a method,
14750 that returns whether the valuetype is suitable for being used.
14752 * expression.cs (Binary.DoNumericPromotions): Only return if we
14753 the int constant was a valid uint, and we can return both left and
14754 right as uints. If not, we continue processing, to trigger the
14755 type conversion. This fixes 39018.
14757 * statement.cs (Block.EmitMeta): During constant resolution, set
14758 the CurrentBlock property on the emitcontext, so that we resolve
14759 constants propertly.
14761 2003-07-02 Martin Baulig <martin@ximian.com>
14763 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
14764 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
14766 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
14767 than emitting it here.
14769 * statement.cs: Fixed some more flow analysis bugs.
14771 2003-07-02 Martin Baulig <martin@ximian.com>
14773 * class.cs (MethodData.Define): When implementing interface
14774 methods, set Final unless we're Virtual.
14776 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
14777 check work for interface methods.
14779 2003-07-01 Martin Baulig <martin@ximian.com>
14781 * ecore.cs (EmitContext.This): Replaced this property with a
14782 GetThis() method which takes a Location argument. This ensures
14783 that we get the correct error location for a CS0188.
14785 2003-07-01 Miguel de Icaza <miguel@ximian.com>
14787 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
14788 ImplicitStandardConversion.
14790 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
14792 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
14794 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
14797 2003-06-30 Miguel de Icaza <miguel@ximian.com>
14799 * class.cs (Constructor.Define): Turn off initlocals for unsafe
14802 (MethodData.Define): Turn off initlocals for unsafe methods.
14804 2003-06-29 Miguel de Icaza <miguel@ximian.com>
14806 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
14807 complete; Fixes #37521.
14809 * delegate.cs: Use Modifiers.TypeAttr to compute the
14810 TypeAttributes, instead of rolling our own. This makes the flags
14811 correct for the delegates.
14813 2003-06-28 Miguel de Icaza <miguel@ximian.com>
14815 * class.cs (Constructor.Define): Set the private flag for static
14816 constructors as well.
14818 * cs-parser.jay (statement_expression): Set the return value to
14819 null, to avoid a crash when we catch an error.
14821 2003-06-24 Miguel de Icaza <miguel@ximian.com>
14823 * cs-parser.jay: Applied patch from Jackson that adds support for
14824 extern and unsafe modifiers to destructor declarations.
14826 * expression.cs: Report error 21 if the user is trying to index a
14829 * driver.cs: Add an error message, suggested by the bug report.
14831 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
14832 if we do not have a ": this ()" constructor initializer. Fixes 45149
14834 2003-06-14 Miguel de Icaza <miguel@ximian.com>
14836 * namespace.cs: Add some information to reduce FAQs.
14838 2003-06-13 Miguel de Icaza <miguel@ximian.com>
14840 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
14841 underlying enumeration types. Fixes #43915.
14843 * expression.cs: Treat ushort/short as legal values to be used in
14844 bitwise operations.
14846 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
14848 * delegate.cs: transfer custom attributes for paramenters from
14849 the delegate declaration to Invoke and BeginInvoke.
14851 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
14853 * attribute.cs: handle custom marshalers and emit marshal info
14856 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
14858 * makefile.gnu: Added anonymous.cs to the compiler sources.
14860 2003-05-28 Miguel de Icaza <miguel@ximian.com>
14862 * iterators.cs: Change the name of the proxy class to include two
14865 * cs-parser.jay: Update grammar to include anonymous methods.
14867 * anonymous.cs: new file.
14869 2003-05-27 Miguel de Icaza <miguel@ximian.com>
14871 * class.cs (Field.Define): Add missing test for pointers and
14874 2003-05-27 Ravi Pratap <ravi@ximian.com>
14876 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
14877 we use the stobj opcode.
14879 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
14880 since it wasn't the correct fix.
14882 It still is puzzling that we are required to use stobj for IntPtr
14883 which seems to be a ValueType.
14885 2003-05-26 Miguel de Icaza <miguel@ximian.com>
14887 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
14888 during regular simple name resolution. Now, the trick is that
14889 instead of returning for processing the simplename, we do a
14890 TypeManager.LookupType (ie, a rooted lookup as opposed to a
14891 contextual lookup type). If a match is found, return that, if
14892 not, return for further composition.
14894 This fixes long-standing 30485.
14896 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
14897 using the address to initialize an object, do an Stobj instead of
14898 using the regular Stelem.
14900 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
14901 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
14902 Because if we are a BaseIndexerAccess that value will be true.
14905 * statement.cs (GotoCase.Resolve): Return after reporting an
14906 error, do not attempt to continue.
14908 * expression.cs (PointerArithmetic.Emit): If our operand is a
14909 long, convert our constants to match the operand before
14910 multiplying. Convert to I type before adding. Fixes 43670.
14912 2003-05-14 Ravi Pratap <ravi@ximian.com>
14914 * enum.cs (ImplicitConversionExists) : Rename to
14915 ImplicitEnumConversionExists to remove ambiguity.
14917 * ecore.cs (NullCast): New type of cast expression class which
14918 basically is very similar to EmptyCast with the difference being
14919 it still is a constant since it is used only to cast a null to
14921 (eg. (string) null)
14923 * convert.cs (ImplicitReferenceConversion): When casting a null
14924 literal, we return a NullCast.
14926 * literal.cs (NullLiteralTyped): Remove - I don't see why this
14927 should be around anymore.
14929 The renaming (reported was slightly wrong). Corrections:
14931 ConvertImplicitStandard -> ImplicitConversionStandard
14932 ConvertExplicitStandard -> ExplicitConversionStandard
14934 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
14935 before passing them in !
14937 * convert.cs (ImplicitConversionStandard): When comparing for
14938 equal expr and target types, ensure that expr is not a
14941 In general, we must not be checking (expr_type ==
14942 target_type) in the top level conversion methods
14943 (ImplicitConversion, ExplicitConversion etc). This checking is
14944 done in the methods that they delegate to.
14946 2003-05-20 Miguel de Icaza <miguel@ximian.com>
14948 * convert.cs: Move Error_CannotConvertType,
14949 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
14950 ImplicitNumericConversion, ImplicitConversionExists,
14951 ImplicitUserConversionExists, StandardConversionExists,
14952 FindMostEncompassedType, FindMostSpecificSource,
14953 FindMostSpecificTarget, ImplicitUserConversion,
14954 ExplicitUserConversion, GetConversionOperators,
14955 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
14956 TryImplicitIntConversion, Error_CannotConvertImplicit,
14957 ConvertImplicitRequired, ConvertNumericExplicit,
14958 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
14959 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
14962 Perform the following renames:
14964 StandardConversionExists -> ImplicitStandardConversionExists
14965 ConvertImplicit -> ImplicitConversion
14966 ConvertImplicitStandard -> ImplicitStandardConversion
14967 TryImplicitIntConversion -> ImplicitIntConversion
14968 ConvertImplicitRequired -> ImplicitConversionRequired
14969 ConvertNumericExplicit -> ExplicitNumericConversion
14970 ConvertReferenceExplicit -> ExplicitReferenceConversion
14971 ConvertExplicit -> ExplicitConversion
14972 ConvertExplicitStandard -> ExplicitStandardConversion
14974 2003-05-19 Martin Baulig <martin@ximian.com>
14976 * statement.cs (TypeInfo.StructInfo): Made this type protected.
14977 (TypeInfo): Added support for structs having structs as fields.
14979 * ecore.cs (FieldExpr): Implement IVariable.
14980 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
14981 VariableInfo for the field.
14983 2003-05-18 Martin Baulig <martin@ximian.com>
14985 * expression.cs (This.DoResolve): Report a CS0027 if we're
14986 emitting a field initializer.
14988 2003-05-18 Martin Baulig <martin@ximian.com>
14990 * expression.cs (This.ResolveBase): New public function.
14991 (This.DoResolve): Check for CS0188.
14993 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
14996 * ecore.cs (MethodGroupExpr.DoResolve): Set the
14997 `instance_expression' to null if we don't have any non-static
15000 2003-05-18 Martin Baulig <martin@ximian.com>
15002 Reworked the way how local variables and parameters are handled by
15003 the flow analysis code.
15005 * statement.cs (TypeInfo, VariableMap): New public classes.
15006 (VariableInfo): New public class. This is now responsible for
15007 checking whether a variable has been assigned. It is used for
15008 parameters and local variables.
15009 (Block.EmitMeta): Take the InternalParameters as argument; compute
15010 the layout of the flow vectors here.
15011 (Block.LocalMap, Block.ParameterMap): New public properties.
15012 (FlowBranching): The .ctor doesn't get the InternalParameters
15013 anymore since Block.EmitMeta() now computes the layout of the flow
15015 (MyStructInfo): This class is now known as `StructInfo' and nested
15016 in `TypeInfo'; we don't access this directly anymore.
15018 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
15019 property and removed IsAssigned(), IsFieldAssigned(),
15020 SetAssigned() and SetFieldAssigned(); we now call them on the
15021 VariableInfo so we don't need to duplicate this code everywhere.
15023 * expression.cs (ParameterReference): Added `Block block' argument
15025 (LocalVariableReference, ParameterReference, This): The new
15026 VariableInfo class is now responsible for all the definite
15029 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
15030 IsParameterAssigned, SetParameterAssigned): Removed.
15032 2003-05-18 Martin Baulig <martin@ximian.com>
15034 * typemanager.cs (InitCoreTypes): Try calling
15035 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
15036 the 3-args-version. Corlib now also needs our `void_type'.
15037 (GetMethod): Added overloaded version which takes an optional
15038 `bool report_errors' to allow lookups of optional methods.
15040 2003-05-12 Martin Baulig <martin@ximian.com>
15042 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
15043 only used for locals and not for parameters.
15045 2003-05-12 Miguel de Icaza <miguel@ximian.com>
15047 * support.cs (InternalParameters.ParameterType): Return the
15048 ExternalType of the parameter.
15050 * parameter.cs (Parameter.ExternalType): drop the two arguments,
15053 2003-05-11 Miguel de Icaza <miguel@ximian.com>
15055 * class.cs (MethodData.Define): Do not set the `newslot' on
15056 interface members, if they are also flagged as "override".
15058 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
15059 better code for ++i and i++. This only works for static fields
15060 and local variables.
15062 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
15063 want to pull the DeclSpace out of the builder_to_declspace instead
15064 of the TypeBuilder (like in TypeContainer.FindMembers).
15066 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
15067 instead of LookupTypeContainer. Fixes the crash on .NET for
15068 looking up interface members.
15070 * const.cs: Create our own emit context during the Definition
15071 stage, so that constants are evaluated in the proper context, when
15072 a recursive definition happens.
15074 2003-05-11 Martin Baulig <martin@ximian.com>
15076 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
15077 new block for a switch section.
15078 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
15079 the adding/lookup in the switch block. Fixes #39828.
15081 2003-05-09 Miguel de Icaza <miguel@ximian.com>
15083 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
15084 functionality: I needed to convert the data after I had performed
15085 the add/sub operation into the operands type size.
15087 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
15088 pass the type for the box operation, otherwise the resulting
15089 object would have been of type object.
15091 (BoxedCast): Add constructor to specify the type to box as.
15093 2003-05-07 Miguel de Icaza <miguel@ximian.com>
15095 * iterators.cs: I was reusing the `count' variable inadvertently,
15096 take steps to not allow this to happen.
15098 2003-05-06 Miguel de Icaza <miguel@ximian.com>
15100 * attribute.cs (Attribute.Resolve): Params attributes are encoded
15101 by creating an array at the point where the params starts and
15102 putting all those arguments there, then adjusting the size of the
15105 2003-05-05 Miguel de Icaza <miguel@ximian.com>
15107 * expression.cs (New.AddressOf): Implement interface
15108 IMemoryLocation. This is used when the `new' operator is used in
15109 the context of an invocation to a method on a value type.
15111 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
15114 * namespace.cs: Also check the using aliases here.
15116 * driver.cs: Move the test for using validity after the types have
15117 been entered, so we do a single pass that also includes the using
15120 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
15121 in the regular case. CreateSiblingForFinally is doing extra
15124 * attribute.cs (GetAttributeArgumentExpression): Store the result
15125 on an out value, and use the return value to indicate failure
15126 instead of using null (which is a valid return for Constant.GetValue).
15128 * statement.cs: Perform the analysis flow for the increment
15129 portion after the statement, because this will be the real flow of
15130 execution. Fixes #42385
15132 * codegen.cs (EmitContext.EmitArgument,
15133 EmitContext.EmitStoreArgument): New helper functions when the
15134 RemapToProxy flag is set.
15136 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
15139 Add support for remapping parameters.
15141 * iterators.cs: Propagate parameter values; Store parameter
15142 values in the proxy classes.
15144 2003-05-04 Miguel de Icaza <miguel@ximian.com>
15146 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
15147 need a proxy reference; I do not know what I was thinking
15149 * cs-parser.jay (constructor_initializer): catch another error,
15150 and display nice message.
15152 (field_declaration): catch void field declaration
15153 to flag a better error.
15155 * class.cs (MemberBase.CheckBase): Report an error instead of a
15156 warning if a new protected member is declared in a struct.
15157 (Field.Define): catch the error of readonly/volatile.
15159 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
15161 (FieldExpr.AddressOf): ditto. Catch error where the address of a
15162 volatile variable is taken
15164 2003-05-02 Miguel de Icaza <miguel@ximian.com>
15166 * statement.cs (Fixed.Resolve): Report an error if we are not in
15169 2003-05-01 Miguel de Icaza <miguel@ximian.com>
15171 * typemanager.cs: reuse the code that handles type clashes for
15172 delegates and enumerations.
15174 * class.cs (Report28): Always report.
15176 * expression.cs (EncodeAsAttribute): Allow nulls here.
15178 2003-04-28 Miguel de Icaza <miguel@ximian.com>
15180 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
15181 the functionality for testing whether an expression is valid for
15182 an attribute here. Also handle the case of arrays of elements
15185 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
15186 encoding a linear array into an array of objects that are suitable
15187 to be passed to an CustomAttributeBuilder.
15189 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
15191 * ecore.cs: (FieldExpr): Handle field remapping here.
15193 * iteratators.cs: Pass the instance variable (if the method is an
15194 instance method) to the constructors, so we can access the field
15195 variables on the class.
15197 TODO: Test this with structs. I think the THIS variable on
15198 structs might have to be a pointer, and not a refenrece
15200 2003-04-27 Miguel de Icaza <miguel@ximian.com>
15202 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
15203 local variables to fields in a proxy class.
15205 * iterators.cs (PopulateProxy): Rename our internal fields to
15207 Create a <THIS> field if we are an instance method, so we can
15208 reference our parent container variables.
15209 (MapVariable): Called back from the EmitContext code to enter a
15210 new variable to field mapping into the proxy class (we just create
15214 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
15215 for using the remapped locals to fields.
15217 I placed the code here, because that gives the same semantics to
15218 local variables, and only changes the Emit code.
15220 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
15221 statements inside iterators.
15222 (VariableInfo): Add a FieldBuilder for the cases when we are
15223 remapping local variables to fields in a proxy class
15225 * ecore.cs (SimpleNameResolve): Avoid testing two times for
15226 current_block != null.
15228 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
15229 not cope with strings, as it has been moved to the
15230 TableSwitchEmit. Fixed bug in switch generation.
15232 * expression.cs (New.DoResolve): Provide more context for the user
15233 when reporting an error.
15235 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
15238 * expression.cs (MemberAccess.DoResolve): When we get a type back,
15239 check the permissions for it. Note than in a type-resolution
15240 context the check was already present in DeclSpace.ResolveType,
15241 but was missing from the MemberAccess.
15243 (ArrayCreation.CheckIndices): warn if the user has
15244 more nested levels of expressions, but there are no more
15245 dimensions specified. Avoids crash on bug 41906.
15247 2003-04-26 Miguel de Icaza <miguel@ximian.com>
15249 * statement.cs (Block): replace Implicit bool, for a generic
15251 New flag: `Unchecked'. This is used during the EmitMeta phase
15252 (which is out-of-line with the regular Resolve/Emit process for a
15253 statement, as this is done ahead of time, but still gets a chance
15254 to call constant resolve).
15256 (Block.Flags): new enum for adding a new flag.
15258 (Block.EmitMeta): track the state of unchecked.
15260 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
15261 to enable constant resolution to work there as well.
15263 2003-04-22 Miguel de Icaza <miguel@ximian.com>
15265 * typemanager.cs (ienumerable_type): Also look up
15266 System.Collections.IEnumerable.
15268 2003-04-21 Miguel de Icaza <miguel@ximian.com>
15270 TODO: Test more than one conditional per method.
15272 * class.cs (Indexer.Define): Report the location where the user is
15273 referencing the unsupported feature.
15275 (MethodData): Overload the use of `conditionals' to
15276 minimize the creation of needless ArrayLists. This saves roughly
15277 212kb on my machine.
15279 (Method): Implement the new IIteratorContainer interface.
15280 (Method.SetYields): Implement the method by setting the ModFlags
15281 to contain METHOD_YIELDS.
15283 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
15284 which just got set to null.
15286 * iterators.cs: New file.
15288 (Yield, YieldBreak): New statements.
15290 * statement.cs (Return.Resolve): Flag an error if we are used in
15291 an iterator method.
15293 * codegen.cs (InIterator): New flag set if the code is being
15294 compiled in an iterator method.
15296 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
15297 internal modifier, and we just use it to avoid adding extra
15298 fields, as this is seldom used.
15300 * cs-parser.jay: Add yield_statement (yield and yield break).
15302 * driver.cs: New flag -v2 to turn on version 2 features.
15304 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
15305 hashtable when v2 is enabled.
15307 2003-04-20 Miguel de Icaza <miguel@ximian.com>
15309 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
15310 there is already a namespace defined with this name.
15312 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
15313 people upgraded their corlibs.
15315 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
15316 always use fully qualified types, no need to use the compiler
15319 (TypeManager.IsNamespace): Use binarysearch.
15321 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
15322 AddDelegate): I did not quite use the new IsValid API properly: I
15323 have to pass the short-name and the fullname. I was passing only
15324 the basename instead of the fullname sometimes.
15326 (TypeContainer.DefineType): call NamespaceClash.
15328 * interface.cs (Interface.DefineType): use NamespaceClash before
15331 * delegate.cs (Delegate.DefineType): use NamespaceClash before
15334 * enum.cs: (Enum.DefineType): use NamespaceClash before
15337 * typemanager.cs (: 3-line patch that gives us some tasty 11%
15338 speed increase. First, use the negative_hits cache when we get a
15339 negative. Second, add the type with its full original name
15340 instead of the new . and + encoded name (reflection uses + to
15341 separate type from a nested type). Use LookupTypeReflection
15342 directly which bypasses the type->name hashtable (that we already
15343 know does not contain the type.
15345 * decl.cs (DeclSpace.ResolveTypeExpr): track the
15346 location/container type.
15348 * driver.cs: When passing utf8, use directly the UTF8Encoding.
15350 2003-04-19 Miguel de Icaza <miguel@ximian.com>
15352 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
15354 * delegate.cs (NewDelegate.Resolve): Test whether an instance
15355 method is being referenced in the method group from a static
15356 context, and report error 120 if so.
15358 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
15361 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
15362 is created, we create the A namespace).
15364 * cs-parser.jay: A namespace also introduces a DeclarationFound.
15367 2003-04-18 Miguel de Icaza <miguel@ximian.com>
15369 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
15370 invocation to ModuleBuilder.GetType with the same values will
15371 return a new type instance, so we need to cache its return
15374 * expression.cs (Binary.ResolveOperator): Only allow the compare
15375 operators on enums if they are of the same type.
15377 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
15378 types of ValueType on their own case. Before we were giving them
15379 the same treatment as objects.
15381 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
15382 fullname. Short name is used to compare against container name.
15383 Fullname is used to check against defined namespace names.
15385 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
15386 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
15388 (Method.CheckBase): Call parent.
15389 (MemberBase.CheckBase): Check for protected members on sealed
15391 (PropertyBase.CheckBase): Call parent.
15392 (Field.Define): Call parent.
15394 * report.cs: Negative error codes are now mapped to 8000 - code,
15395 so that the display is render more nicely.
15397 * typemanager.cs: Do not use try/catch, instead report a regular
15400 (GetPointerType, GetReferenceType): These methods provide
15401 mechanisms to obtain the T* and T& from a T. We had the code
15402 previously scattered around the code base, and it also used
15403 TypeManager.LookupType that would go through plenty of caches.
15404 This one goes directly to the type source.
15406 In some places we did the Type.GetType followed by
15407 ModuleBuilder.GetType, but not in others, so this unifies the
15408 processing as well.
15410 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
15411 statements now that we have namespace information.
15413 * typemanager.cs (IsNamespace): New method, returns whether the
15414 string presented is a namespace or not.
15416 (ComputeNamespaces): New public entry point, computes the list of
15417 available namespaces, using the GetNamespaces API call in Mono, or
15418 the slower version in MS.NET.
15420 Now before we start the semantic analysis phase, we have a
15421 complete list of namespaces including everything that the user has
15424 Deleted old code to cache namespaces in .nsc files.
15426 2003-04-17 Miguel de Icaza <miguel@ximian.com>
15428 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
15429 class/struct location definition Location for the implicit
15430 constructor location.
15432 (Operator.Define): Use the location of the operator for the
15433 implicit Method definition.
15435 (Constructor.Emit): use the constructor location for the implicit
15436 base initializer constructor.
15438 * ecore.cs: Remove ITypeExpression. This interface is now gone,
15439 and the Expression class now contains two new methods:
15441 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
15442 isolate type lookup from the rest of the resolution process.
15444 Since we use Expressions to hold type definitions due to the way
15445 we parse the input we have historically overloaded Resolve to
15446 perform the Type lookups if a special flag is passed. Now this is
15447 eliminated and two methods take their place.
15449 The differences in the two methods between xStep and xTerminal is
15450 that xStep is involved in our current lookup system that uses
15451 SimpleNames to compose a name, while xTerminal is used just to
15452 catch the case where the simplename lookup failed.
15454 2003-04-16 Miguel de Icaza <miguel@ximian.com>
15456 * expression.cs (ResolveMemberAccess): Remove redundant code.
15457 TypeExpr expressions are always born fully resolved.
15459 * interface.cs (PopulateMethod): Do not lookup the types twice.
15460 We were doing it once during SemanticAnalysis and once during
15463 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
15464 in local variable type definitions, were being returned as a
15465 SimpleName (we decomposed everything into a string), that is
15466 because primary_expression was being used instead of a type in the
15467 grammar (reduce/reduce conflicts).
15469 The part that was wrong is that we converted the expression into a
15470 string (an oversimplification in one hand, compounded with primary
15471 expressions doing string concatenation).
15477 Would return "A.B.C[]" as a SimpleName. This stopped things like
15478 using clauses from working on this particular context. And a type
15479 was being matched directly against "A.B.C[]".
15481 We now use the correct approach, and allow for ComposedCast to be
15482 part of the unary expression. So the "A.B.C []" become a composed
15483 cast of "A.B.C" (as a nested group of MemberAccess with a
15484 SimpleName at the end) plus the rank composition "[]".
15488 2003-04-10 Miguel de Icaza <miguel@ximian.com>
15490 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
15491 for the access level checking.
15493 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
15494 `TypeContainer container', because I kept getting confused when I
15495 was debugging this code.
15497 * expression.cs (Indexers): Instead of tracking getters/setters,
15498 we now track them in parallel. We create one arraylist less, but
15499 most importantly it is possible now for the LValue code to find a
15500 matching get for a set.
15502 (IndexerAccess.DoResolveLValue): Update the code.
15503 GetIndexersForType has been modified already to extract all the
15504 indexers from a type. The code assumed it did not.
15506 Also make the code set the correct return type for the indexer.
15507 This was fixed a long time ago for properties, but was missing for
15508 indexers. It used to be void_type.
15510 (Binary.Emit): Test first for doubles instead of
15511 floats, as they are more common.
15513 (Binary.EmitBranchable): Use the .un version of the branch opcodes
15514 when dealing with floats and the <=, >= operators. This fixes bug
15517 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
15518 to load the array value by emitting a load on the foreach variable
15519 type. This was incorrect.
15521 We now emit the code to load an element using the the array
15522 variable type, and then we emit the conversion operator.
15526 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
15528 * attribute.cs: Avoid allocation of ArrayLists in the common case.
15530 2003-04-09 Miguel de Icaza <miguel@ximian.com>
15532 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
15533 test for protection before we test for signatures.
15535 (MethodSignature.ToString): implement.
15537 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
15538 to the case where we reduced into a LongConstant.
15540 * decl.cs (CheckAccessLevel): If the type is an array, we can not
15541 depend on whether the information is acurrate, because the
15542 Microsoft runtime will always claim that the array type is public,
15543 regardless of the real state.
15545 If the type is a pointer, another problem happens: the type is
15546 reported as non-public in Microsoft.
15548 In both cases we have to call CheckAccessLevel recursively with
15549 the underlying type as the argument to be tested.
15551 2003-04-08 Miguel de Icaza <miguel@ximian.com>
15553 * assign.cs (Assign.Emit): If we are dealing with a compound
15554 assignment expression, we should use the code path that stores the
15555 intermediate result in a temporary value. This fixes #40903.
15557 *expression.cs (Indirection.ToString): Provide ToString method for
15560 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
15562 * class.cs: Null out fields holding references to Block objects so
15563 they can be garbage collected.
15565 * expression.cs (OverloadResolve): Remove unused local.
15567 2003-04-07 Martin Baulig <martin@ximian.com>
15569 * codegen.cs (EmitContext.CurrentFile): New public field.
15570 (EmitContext.Mark): Use the CurrentFile to check whether the
15571 location is in the correct file.
15572 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
15574 2003-04-07 Martin Baulig <martin@ximian.com>
15576 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
15578 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
15579 location. [FIXME: The location argument which gets passed to this
15580 method is sometimes wrong!]
15582 2003-04-07 Nick Drochak <ndrochak@gol.com>
15584 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
15586 2003-04-07 Miguel de Icaza <miguel@ximian.com>
15588 * expression.cs (Indirection.EmitAssign): We were using the
15589 temporary, but returning immediately instead of continuing the
15592 2003-04-06 Martin Baulig <martin@ximian.com>
15594 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
15595 if it's a nested child, but also deriving from the outer class.
15598 * typemanager.cs (IsNestedChildOf): Make this work if it's a
15599 nested child, but also deriving from the outer class. See
15601 (FilterWithClosure): We may access private members of the outer
15602 class if we're a nested child and deriving from the outer class.
15603 (RealMemberLookup): Only set `closure_private_ok' if the
15604 `original_bf' contained BindingFlags.NonPublic.
15606 2003-04-05 Martin Baulig <martin@ximian.com>
15608 * expression.cs (SizeOf.DoResolve): Use ResolveTypeExpr, so we can
15609 probe if its a type parameter, and if so, flag an error.
15611 * decl.cs: Move here the SetParameterInfo code from class.cs.
15612 Handle IsGeneric here.
15614 Handle a variety of errors in the parameter info definition.
15616 * ecore.cs (SimpleName.DoResolveType): Handle look ups for generic
15617 type parameters here.
15619 * cs-parser.jay (class_declaration): report errors for parameters
15622 2003-01-21 Miguel de Icaza <miguel@ximian.com>
15624 * generic.cs: New file, contains support code for generics.
15626 * cs-parser.jay: Remove OP_SHIFT_LEFT, OP_SHIFT_RIGHT,
15627 OP_SHIFT_LEFT_ASSIGN, OP_SHIFT_RIGHT_ASSIGN.
15629 Update parser for the above removals.
15631 * cs-tokenizer.cs: Do not handle <<= or >>= specially. This is
15632 now taken care of in the parser.
15634 2003-04-02 Miguel de Icaza <miguel@ximian.com>
15636 * class.cs (Event.Define): Do not allow abstract events to have
15639 2003-04-01 Miguel de Icaza <miguel@ximian.com>
15641 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
15642 block in event declarations.
15644 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
15645 value type, get its address.
15647 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
15648 leaving a class on the stack instead of a boolean value (int
15649 0/1). Change the code so we compare against null, and then the
15650 result against zero.
15652 * class.cs (TypeContainer.GetClassBases): We were checking for the
15653 parent class being sealed too late.
15655 * expression.cs (Binary.Emit): For <= and >= when dealing with
15656 floating point values, use cgt.un and clt.un instead of cgt and
15659 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
15661 * statement.cs: Apply the same optimization as MS: skip the
15662 GetEnumerator returning an IEnumerator, and use the one returning a
15663 CharEnumerator instead. This allows us to avoid the try-finally block
15666 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
15668 * cs-parser.jay: Attributes cannot be applied to
15669 namespaces. Fixes #40473
15671 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
15674 (Add*): check if the name is valid using the full name for constants,
15675 fields, properties and events.
15677 2003-03-28 Miguel de Icaza <miguel@ximian.com>
15679 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
15680 char constants to be part of the enumeration.
15682 * expression.cs (Conditional.DoResolve): Add support for operator
15683 true. Implements the missing functionality from 14.12
15685 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
15686 operator true/false as required by the spec.
15688 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
15689 implicit conversion to boolean.
15691 * statement.cs (Statement.ResolveBoolean): A boolean expression is
15692 also one where the type implements `operator true'.
15694 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
15695 get an expression that will invoke operator true based on an
15698 (GetConversionOperators): Removed the hack that called op_True
15701 (Expression.ResolveBoolean): Move this from Statement.
15703 2003-03-17 Miguel de Icaza <miguel@ximian.com>
15705 * ecore.cs (FieldExpr): do not allow initialization of initonly
15706 fields on derived classes
15708 2003-03-13 Martin Baulig <martin@ximian.com>
15710 * statement.cs (Block.Emit): Call ig.BeginScope() and
15711 ig.EndScope() when compiling with debugging info; call
15712 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
15714 2003-03-08 Miguel de Icaza <miguel@ximian.com>
15716 * expression.cs (Indexers): Do not construct immediately, allow
15717 for new members to be appended as we go. Fixes 38143
15719 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
15721 * expression.cs: save/restore context when resolving an unchecked
15724 2003-03-05 Miguel de Icaza <miguel@ximian.com>
15726 * cfold.cs: Catch division by zero in modulus operator during
15729 2003-03-03 Miguel de Icaza <miguel@ximian.com>
15731 * interface.cs (Interface.DefineMembers): Avoid defining members
15734 2003-02-27 Miguel de Icaza <miguel@ximian.com>
15736 * driver.cs: handle the +/- options for -noconfig
15738 * statement.cs (Unckeched.Resolve): Also track the state of
15739 unchecked in the Resolve phase.
15741 2003-02-27 Martin Baulig <martin@ximian.com>
15743 * ecore.cs (Expression.MemberLookup): Don't create a
15744 MethodGroupExpr for something which is not a method. Fixes #38291.
15746 2003-02-25 Miguel de Icaza <miguel@ximian.com>
15748 * class.cs (MemberBase.CheckParameters): Also check that the type
15749 is unmanaged if it is a pointer.
15751 * expression.cs (SizeOf.Resolve): Add location information.
15753 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
15754 a managed type is declared.
15756 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
15757 parameter modifiers as well. Fixes bug 38606
15759 * class.cs: Very sad. Am backing out the speed up changes
15760 introduced by the ArrayList -> Array in the TypeContainer, as they
15761 were not actually that much faster, and introduced a bug (no error
15762 reports on duplicated methods).
15764 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
15765 source first, this will guarantee that we have a valid expression
15766 before calling in lower levels functions that will require a
15767 resolved object. Then use this original_source in the
15768 target.ResolveLValue instead of the original source that was
15771 Another change. Use target.Resolve instead of LValueResolve.
15772 Although we are resolving for LValues, we will let the Assign code
15773 take care of that (it will be called again from Resolve). This
15774 basically allows code like this:
15776 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
15777 class Y { void A (X x) { x [0] += o; }
15779 The problem was that the indexer was trying to resolve for
15780 set_Item (idx, object o) and never finding one. The real set_Item
15781 was set_Item (idx, X). By delaying the process we get the right
15786 2003-02-23 Martin Baulig <martin@ximian.com>
15788 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
15789 while calling DoEmit ().
15791 * codegen.cs (EmitContext.Mark): Don't mark locations in other
15792 source files; if you use the #line directive inside a method, the
15793 compiler stops emitting line numbers for the debugger until it
15794 reaches the end of the method or another #line directive which
15795 restores the original file.
15797 2003-02-23 Martin Baulig <martin@ximian.com>
15799 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
15801 2003-02-23 Martin Baulig <martin@ximian.com>
15803 * statement.cs (Block.AddChildVariableNames): We need to call this
15804 recursively, not just for our immediate children.
15806 2003-02-23 Martin Baulig <martin@ximian.com>
15808 * class.cs (Event.Define): Always make the field private, like csc does.
15810 * typemanager.cs (TypeManager.RealMemberLookup): Make events
15811 actually work, fixes bug #37521.
15813 2003-02-23 Miguel de Icaza <miguel@ximian.com>
15815 * delegate.cs: When creating the various temporary "Parameters"
15816 classes, make sure that we call the ComputeAndDefineParameterTypes
15817 on those new parameters (just like we do with the formal ones), to
15818 allow them to be resolved in the context of the DeclSpace.
15820 This fixes the bug that Dick observed in Bugzilla #38530.
15822 2003-02-22 Miguel de Icaza <miguel@ximian.com>
15824 * expression.cs (ResolveMemberAccess): When resolving a constant,
15825 do not attempt to pull a constant if the value was not able to
15826 generate a valid constant.
15828 * const.cs (LookupConstantValue): Do not report more errors than required.
15830 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
15832 * expression.cs: fixes bug #38328.
15834 2003-02-18 Miguel de Icaza <miguel@ximian.com>
15836 * class.cs: Changed all the various members that can be part of a
15837 class from being an ArrayList to be an Array of the right type.
15838 During the DefineType type_list, interface_list, delegate_list and
15839 enum_list are turned into types, interfaces, delegates and enums
15842 And during the member population, indexer_list, event_list,
15843 constant_list, field_list, instance_constructor_list, method_list,
15844 operator_list and property_list are turned into their real arrays.
15846 Although we could probably perform this operation earlier, for
15847 good error reporting we need to keep the lists and remove the
15848 lists for longer than required.
15850 This optimization was triggered by Paolo profiling the compiler
15851 speed on the output of `gen-sample-program.pl' perl script.
15853 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
15854 not crash in methods like MemberLookupFailed that use this field.
15856 This problem arises when the compiler fails to resolve a type
15857 during interface type definition for example.
15859 2003-02-18 Miguel de Icaza <miguel@ximian.com>
15861 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
15862 inherit from System.Object, so we have to stop at null, not only
15863 when reaching System.Object.
15865 2003-02-17 Miguel de Icaza <miguel@ximian.com>
15867 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
15868 DeclaredOnly because the parent indexer might have had a different
15869 name, but did not loop until the top of the hierarchy was reached.
15871 The problem this one fixes is 35492: when a class implemented an
15872 indexer from an interface, we were getting the interface method
15873 (which was abstract) and we were flagging an error (can not invoke
15876 This also keeps bug 33089 functioning, and test-148 functioning.
15878 * typemanager.cs (IsSpecialMethod): The correct way of figuring
15879 out if a method is special is to see if it is declared in a
15880 property or event, or whether it is one of the predefined operator
15881 names. This should fix correctly #36804.
15883 2003-02-15 Miguel de Icaza <miguel@ximian.com>
15885 The goal here is to remove the dependency on EmptyCast.Peel ().
15886 Killing it completely.
15888 The problem is that currently in a number of places where
15889 constants are expected, we have to "probe" for an EmptyCast, and
15890 Peel, which is not the correct thing to do, as this will be
15891 repetitive and will likely lead to errors.
15893 The idea is to remove any EmptyCasts that are used in casts that
15894 can be reduced to constants, so we only have to cope with
15897 This bug hunt was triggered by Bug 37363 and the desire to remove
15898 the duplicate pattern where we were "peeling" emptycasts to check
15899 whether they were constants. Now constants will always be
15902 * ecore.cs: Use an enumconstant here instead of wrapping with
15905 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
15906 throwing me off. By handling this we can get rid of a few hacks.
15908 * statement.cs (Switch): Removed Peel() code.
15910 2003-02-14 Miguel de Icaza <miguel@ximian.com>
15912 * class.cs: Location information for error 508
15914 * expression.cs (New.DoResolve): Add a guard against double
15915 resolution of an expression.
15917 The New DoResolve might be called twice when initializing field
15918 expressions (see EmitFieldInitializers, the call to
15919 GetInitializerExpression will perform a resolve on the expression,
15920 and later the assign will trigger another resolution
15922 This leads to bugs (#37014)
15924 * delegate.cs: The signature for EndInvoke should contain any ref
15925 or out parameters as well. We were not doing this in the past.
15927 * class.cs (Field.Define): Do not overwrite the type definition
15928 inside the `volatile' group. Turns out that volatile enumerations
15929 were changing the type here to perform a validity test, which
15932 2003-02-12 Miguel de Icaza <miguel@ximian.com>
15934 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
15935 and structs, we do not want to load the instance variable
15937 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
15938 enum_type has to be handled like an object reference (implicit
15939 conversions exists from this to object), but the regular IsClass
15940 and IsValueType tests will never return true for this one.
15942 Also we use TypeManager.IsValueType instead of type.IsValueType,
15943 just for consistency with the rest of the code (this is only
15944 needed if we ever use the construct exposed by test-180.cs inside
15945 corlib, which we dont today).
15947 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
15949 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
15952 2003-02-09 Martin Baulig <martin@ximian.com>
15954 * namespace.cs (Namespace..ctor): Added SourceFile argument.
15955 (Namespace.DefineNamespaces): New static public method; this is
15956 called when we're compiling with debugging to add all namespaces
15957 to the symbol file.
15959 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
15960 pass it to the Namespace's .ctor.
15962 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
15963 and MethodBase arguments; pass the namespace ID to the symwriter;
15964 pass the MethodBase instead of the token to the symwriter.
15965 (SymbolWriter.DefineNamespace): New method to add a namespace to
15968 2003-02-09 Martin Baulig <martin@ximian.com>
15970 * symbolwriter.cs: New file. This is a wrapper around
15971 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
15972 methods here in near future.
15974 2003-02-09 Martin Baulig <martin@ximian.com>
15976 * codegen.cs (EmitContext.Mark): Just pass the arguments to
15977 ILGenerator.MarkSequencePoint() which are actually used by the
15980 2003-02-09 Martin Baulig <martin@ximian.com>
15982 * location.cs (SourceFile): New public sealed class. This
15983 contains the name and an index which is used in the location's token.
15984 (Location): Reserve an appropriate number of bits in the token for
15985 the source file instead of walking over that list, this gives us a
15986 really huge performance improvement when compiling with debugging.
15988 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
15989 `SourceFile' argument instead of a string.
15990 (Driver.ProcessFile): Add all the files via Location.AddFile(),
15991 but don't parse/tokenize here, we need to generate the list of all
15992 source files before we do that.
15993 (Driver.ProcessFiles): New static function. Parses/tokenizes all
15996 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
15997 instead of a string.
15999 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
16002 2003-02-09 Martin Baulig <martin@ximian.com>
16004 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
16005 filename on `#line default'.
16007 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
16009 * statement.cs: don't clear the pinned var when the fixed statement
16010 returns from the method (fixes bug#37752).
16012 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
16014 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
16017 2003-02-07 Martin Baulig <martin@ximian.com>
16019 * driver.cs: Removed the `--debug-args' command line argument.
16021 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
16022 automatically by the AsssemblyBuilder.
16023 (CodeGen.InitializeSymbolWriter): We don't need to call any
16024 initialization function on the symbol writer anymore. This method
16025 doesn't take any arguments.
16027 2003-02-03 Miguel de Icaza <miguel@ximian.com>
16029 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
16030 from referenced assemblies as well.
16032 2003-02-02 Martin Baulig <martin@ximian.com>
16034 * class.cs (MethodData.Emit): Generate debugging info for external methods.
16036 2003-02-02 Martin Baulig <martin@ximian.com>
16038 * class.cs (Constructor.Emit): Open the symbol writer before
16039 emitting the constructor initializer.
16040 (ConstructorInitializer.Emit): Call ec.Mark() to allow
16041 single-stepping through constructor initializers.
16043 2003-01-30 Miguel de Icaza <miguel@ximian.com>
16045 * class.cs: Handle error 549: do not allow virtual methods in
16048 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
16050 * decl.cs: Check access levels when resolving types
16052 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
16054 * statement.cs: Add parameters and locals set in catch blocks that might
16055 return to set vector
16057 2003-01-29 Miguel de Icaza <miguel@ximian.com>
16059 * class.cs (Operator): Set the SpecialName flags for operators.
16061 * expression.cs (Invocation.DoResolve): Only block calls to
16062 accessors and operators on SpecialName methods.
16064 (Cast.TryReduce): Handle conversions from char constants.
16067 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
16069 * statement.cs: small memory and time optimization in FlowBranching.
16071 2003-01-28 Pedro Mart <yoros@wanadoo.es>
16073 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
16074 problem that the last fix but in the other sid (Set).
16076 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
16077 access when there is no indexer in the hierarchy.
16079 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
16081 * class.cs: Combine some if statements.
16083 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16085 * driver.cs: fixed bug #37187.
16087 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
16089 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
16090 any indexer, it's needed to build a list with all the indexers in the
16091 hierarchy (AllGetters), else we have problems. Fixes #35653.
16093 2003-01-23 Miguel de Icaza <miguel@ximian.com>
16095 * class.cs (MethodData.Define): It is wrong for an interface
16096 implementation to be static in both cases: explicit and implicit.
16097 We were only handling this in one case.
16099 Improve the if situation there to not have negations.
16101 * class.cs (Field.Define): Turns out that we do not need to check
16102 the unsafe bit on field definition, only on usage. Remove the test.
16104 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16106 * driver.cs: use assembly.Location instead of Codebase (the latest
16107 patch made mcs fail when using MS assemblies).
16109 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
16111 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
16112 get the path to *corlib.dll.
16114 2003-01-21 Nick Drochak <ndrochak@gol.com>
16118 * typemanager.cs: Remove compiler warnings
16120 2003-01-20 Duncan Mak <duncan@ximian.com>
16122 * AssemblyInfo.cs: Bump the version number to 0.19.
16124 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16126 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
16128 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
16130 * class.cs (Constructor::Emit): Emit debugging info for constructors.
16132 2003-01-17 Miguel de Icaza <miguel@ximian.com>
16134 * cs-parser.jay: Small fix: we were not comparing the constructor
16135 name correctly. Thanks to Zoltan for the initial pointer.
16137 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
16139 * cs-tokenizer.cs: Set file name when specified with #line
16141 2003-01-15 Miguel de Icaza <miguel@ximian.com>
16143 * cs-parser.jay: Only perform the constructor checks here if we
16144 are named like the class; This will help provider a better
16145 error. The constructor path is taken when a type definition is
16146 not found, but most likely the user forgot to add the type, so
16147 report that rather than the constructor error.
16149 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
16151 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
16154 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
16156 * cs-parser.jay: Add cleanup call.
16158 2003-01-13 Duncan Mak <duncan@ximian.com>
16160 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
16161 consistent with other methods.
16163 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
16165 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
16167 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
16169 * attribute.cs: only set GuidAttr to true when we have a
16172 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16176 * typemanager.cs: fixes to allow mcs compile corlib with the new
16177 Type.IsSubclassOf fix.
16179 2003-01-08 Miguel de Icaza <miguel@ximian.com>
16181 * expression.cs (LocalVariableReference.DoResolve): Classify a
16182 constant as a value, not as a variable. Also, set the type for
16185 * cs-parser.jay (fixed_statement): take a type instead of a
16186 pointer_type, so we can produce a better error message later.
16188 * statement.cs (Fixed.Resolve): Flag types that are not pointers
16191 (For.DoEmit): Make inifinite loops have a
16192 non-conditional branch back.
16194 (Fixed.DoEmit): First populate the pinned variables, then emit the
16195 statement, then clear the variables. Before I was emitting the
16196 code once for each fixed piece.
16199 2003-01-08 Martin Baulig <martin@ximian.com>
16201 * statement.cs (FlowBranching.MergeChild): A break in a
16202 SWITCH_SECTION does not leave a loop. Fixes #36155.
16204 2003-01-08 Martin Baulig <martin@ximian.com>
16206 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
16207 lives in the same number space than `param_map'. Fixes #36154.
16209 2003-01-07 Miguel de Icaza <miguel@ximian.com>
16211 * cs-parser.jay (constructor_declaration): Set the
16212 Constructor.ModFlags before probing for it. This makes the
16213 compiler report 514, 515 and 132 (the code was there, but got
16216 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
16217 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
16218 (GotoCase.Resolve): Set `Returns' to ALWAYS.
16220 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
16222 * enum.cs: create the enum static fields using the enum type.
16224 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
16226 * class.cs: don't try to create the ParamBuilder for the return
16227 type if it's not needed (and handle it breaking for the ms runtime
16230 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
16232 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
16234 2002-12-29 Miguel de Icaza <miguel@ximian.com>
16236 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
16237 the command. This showed up while compiling the JANET source
16238 code, which used \r as its only newline separator.
16240 2002-12-28 Miguel de Icaza <miguel@ximian.com>
16242 * class.cs (Method.Define): If we are an operator (because it
16243 reuses our code), then set the SpecialName and HideBySig. #36128
16245 2002-12-22 Miguel de Icaza <miguel@ximian.com>
16247 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
16248 exception, report error 120 `object reference required'.
16250 * driver.cs: Add --pause option, used during to measure the size
16251 of the process as it goes with --timestamp.
16253 * expression.cs (Invocation.DoResolve): Do not allow methods with
16254 SpecialName to be invoked.
16256 2002-12-21 Miguel de Icaza <miguel@ximian.com>
16258 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
16259 number before adding it.
16261 2002-12-21 Ravi Pratap <ravi@ximian.com>
16263 * ecore.cs (StandardImplicitConversion): When in an unsafe
16264 context, we allow conversion between void * to any other pointer
16265 type. This fixes bug #35973.
16267 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
16269 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
16270 is not thrown when extensionless outputs are used
16272 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16274 * rootcontext.cs: fixed compilation of corlib.
16276 2002-12-19 Miguel de Icaza <miguel@ximian.com>
16278 * attribute.cs (Attributes.Contains): Add new method.
16280 * class.cs (MethodCore.LabelParameters): if the parameter is an
16281 `out' parameter, check that no attribute `[In]' has been passed.
16283 * enum.cs: Handle the `value__' name in an enumeration.
16285 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
16287 * decl.cs: Added special case to allow overrides on "protected
16290 2002-12-18 Ravi Pratap <ravi@ximian.com>
16292 * attribute.cs (Attributes.AddAttributeSection): Rename to this
16293 since it makes much more sense.
16295 (Attributes.ctor): Don't require a Location parameter.
16297 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
16299 * attribute.cs (ApplyAttributes): Remove extra Location parameters
16300 since we already have that information per attribute.
16302 * everywhere : make appropriate changes.
16304 * class.cs (LabelParameters): Write the code which actually
16305 applies attributes to the return type. We can't do this on the MS
16306 .NET runtime so we flag a warning in the case an exception is
16309 2002-12-18 Miguel de Icaza <miguel@ximian.com>
16311 * const.cs: Handle implicit null conversions here too.
16313 2002-12-17 Ravi Pratap <ravi@ximian.com>
16315 * class.cs (MethodCore.LabelParameters): Remove the extra
16316 Type [] parameter since it is completely unnecessary. Instead
16317 pass in the method's attributes so that we can extract
16318 the "return" attribute.
16320 2002-12-17 Miguel de Icaza <miguel@ximian.com>
16322 * cs-parser.jay (parse): Use Report.Error to flag errors instead
16323 of ignoring it and letting the compile continue.
16325 * typemanager.cs (ChangeType): use an extra argument to return an
16326 error condition instead of throwing an exception.
16328 2002-12-15 Miguel de Icaza <miguel@ximian.com>
16330 * expression.cs (Unary.TryReduce): mimic the code for the regular
16331 code path. Perform an implicit cast in the cases where we can
16332 implicitly convert to one of the integral types, and then reduce
16333 based on that constant. This fixes bug #35483.
16335 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16337 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
16339 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16341 * namespace.cs: fixed bug #35489.
16343 2002-12-12 Miguel de Icaza <miguel@ximian.com>
16345 * class.cs: Remove some dead code.
16347 * cs-parser.jay: Estimate the number of methods needed
16348 (RootContext.MethodCount);
16350 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
16351 numbers instead of StringBuilders.
16353 * support.cs (PtrHashtable): Add constructor with initial size;
16354 We can now reduce reallocations of the method table.
16356 2002-12-10 Ravi Pratap <ravi@ximian.com>
16358 * attribute.cs (ApplyAttributes): Keep track of the emitted
16359 attributes on a per-target basis. This fixes bug #35413.
16361 2002-12-10 Miguel de Icaza <miguel@ximian.com>
16363 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
16364 default to the Windows 1252 encoding.
16366 (UnixParseOption): Support version, thanks to Alp for the missing
16369 * AssemblyInfo.cs: Add nice assembly information.
16371 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
16374 * cs-parser.jay: Allow a trailing comma before the close bracked
16375 in the attribute_section production.
16377 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
16378 address of the instance was being taken, I will take this out,
16379 because we take the address of the object immediately here.
16381 2002-12-09 Ravi Pratap <ravi@ximian.com>
16383 * typemanager.cs (AreMultipleAllowed): Take care of the most
16384 obvious case where attribute type is not in the current assembly -
16387 2002-12-08 Miguel de Icaza <miguel@ximian.com>
16389 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
16390 definitions, instead of doing that afterwards.
16392 Also we use a nice little hack, depending on the constructor, we
16393 know if we are a "composed" name or a simple name. Hence, we
16394 avoid the IndexOf test, and we avoid
16396 * codegen.cs: Add code to assist in a bug reporter to track down
16397 the source of a compiler crash.
16399 2002-12-07 Ravi Pratap <ravi@ximian.com>
16401 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
16402 types have been emitted for a given element and flag an error
16403 if something which does not have AllowMultiple set is used more
16406 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
16407 attribute types and their corresponding AllowMultiple properties
16409 (AreMultipleAllowed): Check the property for a given type.
16411 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
16412 property in the case we have a TypeContainer.
16414 (Attributes.AddAttribute): Detect duplicates and just skip on
16415 adding them. This trivial fix catches a pretty gross error in our
16416 attribute emission - global attributes were being emitted twice!
16418 Bugzilla bug #33187 is now fixed.
16420 2002-12-06 Miguel de Icaza <miguel@ximian.com>
16422 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
16423 instead of pp_and).
16425 * expression.cs (Binary.ResolveOperator): I can only use the
16426 Concat (string, string, string) and Concat (string, string,
16427 string, string) if the child is actually a concatenation of
16430 2002-12-04 Miguel de Icaza <miguel@ximian.com>
16432 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
16433 context where we need a 2-character lookahead.
16435 * pending.cs (PendingImplementation): Rework so we can keep track
16436 of interface types all the time, and flag those which were
16437 implemented by parents as optional.
16439 2002-12-03 Miguel de Icaza <miguel@ximian.com>
16441 * expression.cs (Binary.ResolveOperator): Use
16442 String.Concat(string,string,string) or
16443 String.Concat(string,string,string,string) when possible.
16445 * typemanager: More helper methods.
16448 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
16450 * pending.cs: remove the bogus return from GetMissingInterfaces()
16451 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
16453 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16455 * namespace.cs: avoid duplicated 'using xxx' being added to
16456 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
16457 when we get more than one 'using' statement for the same namespace.
16458 Report a CS0105 warning for it.
16460 2002-11-30 Miguel de Icaza <miguel@ximian.com>
16462 * cs-tokenizer.cs (consume_identifier): use read directly, instead
16463 of calling getChar/putback, uses internal knowledge of it.
16465 (xtoken): Reorder tokenizer so most common patterns are checked
16466 first. This reduces the compilation time in another 5% (from 8.11s
16467 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
16469 The parsing time is 22% of the compilation in mcs, and from that
16470 64% is spent on the tokenization process.
16472 I tried using a binary search for keywords, but this is slower
16473 than the hashtable. Another option would be to do a couple of
16476 * Not use a StringBuilder, instead use an array of chars,
16477 with a set value. Notice that this way we could catch
16478 the 645 error without having to do it *afterwards*.
16480 * We could write a hand-parser to avoid the hashtable
16481 compares altogether.
16483 The identifier consumption process takes 37% of the tokenization
16484 time. Another 15% is spent on is_number. 56% of the time spent
16485 on is_number is spent on Int64.Parse:
16487 * We could probably choose based on the string length to
16488 use Int32.Parse or Int64.Parse and avoid all the 64-bit
16491 Another 3% is spend on wrapping `xtoken' in the `token' function.
16493 Handle 0xa0 as whitespace (#34752)
16495 2002-11-26 Miguel de Icaza <miguel@ximian.com>
16497 * typemanager.cs (IsCLRType): New routine to tell whether a type
16498 is one of the builtin types.
16500 Maybe it needs to use TypeCodes to be faster. Maybe we could use
16501 typecode in more places instead of doing pointer comparissions.
16502 We could leverage some knowledge about the way the typecodes are
16505 New code to cache namespaces in assemblies, it is currently not
16506 invoked, to be used soon.
16508 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
16510 * expression.cs (Binary.ResolveOperator): specially handle
16511 strings, and do not perform user-defined operator overloading for
16514 2002-11-24 Miguel de Icaza <miguel@ximian.com>
16516 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
16517 internalcall as it is a pretty simple operation; Avoid whenever
16518 possible to call Char.IsLetter.
16520 (consume_identifier): Cut by half the number of
16521 hashtable calls by merging the is_keyword and GetKeyword behavior.
16523 Do not short-circuit, because if we do, we
16524 report errors (ie, #if false && true would produce an invalid
16528 2002-11-24 Martin Baulig <martin@ximian.com>
16530 * expression.cs (Cast.TryReduce): If we're in checked syntax,
16531 check constant ranges and report a CS0221. Fixes #33186.
16533 2002-11-24 Martin Baulig <martin@ximian.com>
16535 * cs-parser.jay: Make this work for uninitialized variable
16536 declarations in the `for' initializer. Fixes #32416.
16538 2002-11-24 Martin Baulig <martin@ximian.com>
16540 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
16541 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
16543 2002-11-24 Martin Baulig <martin@ximian.com>
16545 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
16546 argument; if true, we also check for user-defined conversions.
16547 This is only needed if both arguments are of a user-defined type.
16548 Fixes #30443, added test-175.cs.
16549 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
16551 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
16553 2002-11-24 Martin Baulig <martin@ximian.com>
16555 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
16556 function to get the store opcode.
16557 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
16558 only emit the Ldelema if the store opcode is Stobj. You must run
16559 both test-34 and test-167 to test this. Fixes #34529.
16561 2002-11-23 Martin Baulig <martin@ximian.com>
16563 * ecore.cs (Expression.MemberLookup): Added additional
16564 `qualifier_type' argument which is used when we're being called
16565 from MemberAccess.DoResolve() and null if we're called from a
16567 (Expression.MemberLookupFailed): New method to report errors; this
16568 does the CS1540 check and reports the correct error message.
16570 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
16571 argument for the CS1540 check and redone the way how we're dealing
16572 with private members. See the comment in the source code for details.
16573 (FilterWithClosure): Reverted this back to revision 1.197; renamed
16574 `closure_start_type' to `closure_qualifier_type' and check whether
16575 it's not null. It was not this filter being broken, it was just
16576 being called with the wrong arguments.
16578 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
16579 and pass it the correct `qualifier_type'; this also does the error
16582 2002-11-22 Miguel de Icaza <miguel@ximian.com>
16584 * expression.cs (Invocation.EmitParams): If the we are dealing
16585 with a non-built-in value type, load its address as well.
16587 (ArrayCreation): Use a a pretty constant instead
16588 of the hardcoded value 2. Use 6 instead of 2 for the number of
16589 static initializers.
16591 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
16592 because they are not really value types, just glorified integers.
16594 * driver.cs: Do not append .exe, the CSC compiler does not do it.
16596 * ecore.cs: Remove redundant code for enumerations, make them use
16597 the same code path as everything else, fixes the casting issue
16598 with enumerations in Windows.Forms.
16600 * attribute.cs: Do only cast to string if it is a string, the
16601 validation happens later.
16603 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
16604 people upgrade their corlibs.
16606 * ecore.cs: Oops, enumerations were not following the entire code path
16608 2002-11-21 Miguel de Icaza <miguel@ximian.com>
16610 * typemanager.cs (FilterWithClosure): Commented out the test for
16611 1540 in typemanager.cs, as it has problems when accessing
16612 protected methods from a parent class (see test-174.cs).
16614 * attribute.cs (Attribute.ValidateGuid): new method.
16615 (Attribute.Resolve): Use above.
16617 2002-11-19 Miguel de Icaza <miguel@ximian.com>
16619 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
16621 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
16622 handling for enumerations, as we only needed the TypeContainer
16623 functionality to begin with (this is required for the fix below to
16624 work for enums that reference constants in a container class for
16627 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
16629 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
16630 a valid TypeBuilder to perform lookups on.o
16632 * class.cs (InheritableMemberSignatureCompare): Use true in the
16633 call to GetGetMethod and GetSetMethod, because we are comparing
16634 the signature, and we need to get the methods *even* if they are
16637 (PropertyBase.CheckBase): ditto.
16639 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
16640 GotoCase.Resolve): Use Peel on EmpytCasts.
16642 * ecore.cs (EmptyCast): drop child, add Peel method.
16644 2002-11-17 Martin Baulig <martin@ximian.com>
16646 * ecore.cs (EmptyCast.Child): New public property.
16648 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
16649 label resolved to an EmptyCast. Fixes #34162.
16650 (GotoCase.Resolve): Likewise.
16651 (Block.EmitMeta): Likewise.
16653 2002-11-17 Martin Baulig <martin@ximian.com>
16655 * expression.cs (Invocation.BetterConversion): Prefer int over
16656 uint; short over ushort; long over ulong for integer literals.
16657 Use ImplicitConversionExists instead of StandardConversionExists
16658 since we also need to check for user-defined implicit conversions.
16659 Fixes #34165. Added test-173.cs.
16661 2002-11-16 Martin Baulig <martin@ximian.com>
16663 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
16664 with the `true' and `false' literals. Fixes #33151.
16666 2002-11-16 Martin Baulig <martin@ximian.com>
16668 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
16669 October 22nd; don't do the cs1540 check for static members.
16671 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
16672 now using our own filter here and doing the cs1540 check again.
16674 2002-11-16 Martin Baulig <martin@ximian.com>
16676 * support.cs (InternalParameters): Don't crash if we don't have
16677 any fixed parameters. Fixes #33532.
16679 2002-11-16 Martin Baulig <martin@ximian.com>
16681 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
16682 when looking up static methods to make this work on Windows.
16685 2002-11-16 Martin Baulig <martin@ximian.com>
16687 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
16688 a setter rather than using PropertyInfo.CanWrite.
16690 2002-11-15 Nick Drochak <ndrochak@gol.com>
16692 * class.cs: Allow acces to block member by subclasses. Fixes build
16695 2002-11-14 Martin Baulig <martin@ximian.com>
16697 * class.cs (Constructor.Emit): Added the extern/block check.
16700 2002-11-14 Martin Baulig <martin@ximian.com>
16702 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
16703 iteration while looking for indexers, this is needed because the
16704 indexer may have a different name in our base classes. Fixed the
16705 error reporting (no indexers at all, not get accessor, no
16706 overloaded match). Fixes bug #33089.
16707 (IndexerAccess.DoResolveLValue): Likewise.
16709 2002-11-14 Martin Baulig <martin@ximian.com>
16711 * class.cs (PropertyBase.CheckBase): Make this work for multiple
16712 indexers. Fixes the first part of bug #33089.
16713 (MethodSignature.InheritableMemberSignatureCompare): Added support
16716 2002-11-13 Ravi Pratap <ravi@ximian.com>
16718 * attribute.cs (Attribute.Resolve): Catch the
16719 NullReferenceException and report it since it isn't supposed to
16722 2002-11-12 Miguel de Icaza <miguel@ximian.com>
16724 * expression.cs (Binary.EmitBranchable): Also handle the cases for
16725 LogicalOr and LogicalAnd that can benefit from recursively
16726 handling EmitBranchable. The code now should be nice for Paolo.
16728 2002-11-08 Miguel de Icaza <miguel@ximian.com>
16730 * typemanager.cs (LookupType): Added a negative-hit hashtable for
16731 the Type lookups, as we perform quite a number of lookups on
16732 non-Types. This can be removed once we can deterministically tell
16733 whether we have a type or a namespace in advance.
16735 But this might require special hacks from our corlib.
16739 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
16740 and double which avoids a conversion from an integer to a double.
16742 * expression.cs: tiny optimization, avoid calling IsConstant,
16743 because it effectively performs the lookup twice.
16745 2002-11-06 Miguel de Icaza <miguel@ximian.com>
16747 But a bogus return here to keep the semantics of the old code
16748 until the Mono runtime is fixed.
16750 * pending.cs (GetMissingInterfaces): New method used to remove all
16751 the interfaces that are already implemented by our parent
16752 classes from the list of pending methods.
16754 * interface.cs: Add checks for calls after ResolveTypeExpr.
16756 2002-11-05 Miguel de Icaza <miguel@ximian.com>
16758 * class.cs (Class.Emit): Report warning 67: event not used if the
16759 warning level is beyond 3.
16761 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
16762 being a NullLiteral.
16764 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
16767 * class.cs (TypeContainer.GetClassBases): Cover a missing code
16768 path that might fail if a type can not be resolved.
16770 * expression.cs (Binary.Emit): Emit unsigned versions of the
16773 * driver.cs: use error 5.
16775 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
16777 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
16779 2002-11-01 Miguel de Icaza <miguel@ximian.com>
16781 * cs-parser.jay (switch_section): A beautiful patch from Martin
16782 Baulig that fixed 33094.
16784 2002-10-31 Miguel de Icaza <miguel@ximian.com>
16786 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
16787 Check whether the base is abstract and report an error if so.
16789 * expression.cs (IndexerAccess.DoResolveLValue,
16790 IndexerAccess.DoResolve): ditto.
16792 (Invocation.DoResolve): ditto.
16794 (Invocation.FullMethodDesc): Improve the report string.
16796 * statement.cs (Block): Eliminate IsVariableDefined as it is
16797 basically just a wrapper for GetVariableInfo.
16799 * ecore.cs (SimpleName): Use new
16801 * support.cs (ReflectionParamter.ParameterType): We unwrap the
16802 type, as we return the actual parameter ref/unref state on a
16805 2002-10-30 Miguel de Icaza <miguel@ximian.com>
16807 * support.cs: Return proper flags REF/OUT fixing the previous
16810 * expression.cs: Reverted last patch, that was wrong. Is_ref is
16811 not used to mean `ref' but `ref or out' in ParameterReference
16813 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
16814 full type signature instead of calling TypeManger.CSharpName
16817 * support.cs (InternalParameters.ParameterDesc): Do not compare
16818 directly to the modflags, because REF/OUT will actually be bitsets
16821 * delegate.cs (VerifyMethod): Check also the modifiers.
16823 * cs-tokenizer.cs: Fix bug where floating point values with an
16824 exponent where a sign was missing was ignored.
16826 * driver.cs: Allow multiple assemblies to be specified in a single
16829 2002-10-28 Miguel de Icaza <miguel@ximian.com>
16831 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
16832 because identifiers after a parenthesis would end up in this kind
16833 of production, and we needed to desamiguate it for having casts
16836 (UserDefinedType *) xxx
16838 2002-10-24 Miguel de Icaza <miguel@ximian.com>
16840 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
16841 we should set on the Bindingflags.NonPublic, but not turn on
16842 private_ok. private_ok controls whether a Private member is
16843 returned (this is chekced on the filter routine), while the
16844 BindingFlags.NonPublic just controls whether private/protected
16845 will be allowed. This fixes the problem part of the problem of
16846 private properties being allowed to be used in derived classes.
16848 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
16849 so we can call the children DoResolveLValue method (this will
16850 properly signal errors on lvalue assignments to base properties)
16852 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
16853 getter are null, and we have a property info, we know that this
16854 happened because the lookup failed, so we report an error 122 for
16855 protection level violation.
16857 We also silently return if setter and getter are null in the
16858 resolve functions, this condition only happens if we have flagged
16859 the error before. This is the other half of the problem.
16861 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
16862 not have accessibility information, that is why we were returning
16863 true in the filter function in typemanager.cs.
16865 To properly report 122 (property is inaccessible because of its
16866 protection level) correctly, we report this error in ResolveAccess
16867 by failing if both the setter and the getter are lacking (ie, the
16870 DoResolve and DoLResolve have been modified to check for both
16871 setter/getter being null and returning silently, the reason being
16872 that I did not want to put the knowledge about this error in upper
16875 int old = Report.Errors;
16876 x = new PropertyExpr (...);
16877 if (old != Report.Errors)
16882 So the property expr is returned, but it is invalid, so the error
16883 will be flagged during the resolve process.
16885 * class.cs: Remove InheritablePropertySignatureCompare from the
16886 class, as we no longer depend on the property signature to compute
16887 whether it is possible to implement a method or not.
16889 The reason is that calling PropertyInfo.GetGetMethod will return
16890 null (in .NET, in Mono it works, and we should change this), in
16891 cases where the Get Method does not exist in that particular
16896 class X { public virtual int A { get { return 1; } } }
16898 class Z : Y { public override int A { get { return 2; } } }
16900 Would fail in Z because the parent (Y) would not have the property
16901 defined. So we avoid this completely now (because the alternative
16902 fix was ugly and slow), and we now depend exclusively on the
16905 (PropertyBase.CheckBase): Use a method-base mechanism to find our
16906 reference method, instead of using the property.
16908 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
16909 routines are gone now.
16911 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
16912 names, they were incorrectly named.
16914 * cs-tokenizer.cs: Return are more gentle token on failure.
16916 * pending.cs (PendingImplementation.InterfaceMethod): This routine
16917 had an out-of-sync index variable, which caused it to remove from
16918 the list of pending methods the wrong method sometimes.
16920 2002-10-22 Miguel de Icaza <miguel@ximian.com>
16922 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
16923 CanWrite, because those refer to this particular instance of the
16924 property, and do not take into account the fact that we can
16925 override single members of a property.
16927 Constructor requires an EmitContext. The resolution process does
16928 not happen here, but we need to compute the accessors before,
16929 because the resolution does not always happen for properties.
16931 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
16932 subclass, before we did not update this flag, but we did update
16935 (GetAccessors): Drop this routine, as it did not work in the
16936 presence of partially overwritten set/get methods.
16938 Notice that this broke the cs1540 detection, but that will require
16941 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16945 * driver.cs: issue a warning instead of an error if we don't support
16946 debugging for the platform. Also ignore a couple of errors that may
16947 arise when trying to write the symbols. Undo my previous patch.
16949 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16951 * driver.cs: ignore /debug switch except for Unix platforms.
16953 2002-10-23 Nick Drochak <ndrochak@gol.com>
16955 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
16957 2002-10-21 Miguel de Icaza <miguel@ximian.com>
16959 * driver.cs: Do not make mcs-debug conditional, so we do not break
16960 builds that use it.
16962 * statement.cs (UsageVector.MergeChildren): I would like Martin to
16963 review this patch. But basically after all the children variables
16964 have been merged, the value of "Breaks" was not being set to
16965 new_breaks for Switch blocks. I think that it should be set after
16966 it has executed. Currently I set this to the value of new_breaks,
16967 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
16968 conservative, but I do not understand this code very well.
16970 I did not break anything in the build, so that is good ;-)
16972 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
16974 2002-10-20 Mark Crichton <crichton@gimp.org>
16976 * cfold.cs: Fixed compile blocker. Really fixed it this time.
16978 2002-10-20 Nick Drochak <ndrochak@gol.com>
16980 * cfold.cs: Fixed compile blocker.
16982 2002-10-20 Miguel de Icaza <miguel@ximian.com>
16984 * driver.cs: I was chekcing the key, not the file.
16986 2002-10-19 Ravi Pratap <ravi@ximian.com>
16988 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
16989 message that we were generating - we just need to silently return
16992 2002-10-19 Miguel de Icaza <miguel@ximian.com>
16994 * class.cs (Event.Define): Change my previous commit, as this
16995 breaks the debugger. This is a temporary hack, as it seems like
16996 the compiler is generating events incorrectly to begin with.
16998 * expression.cs (Binary.ResolveOperator): Added support for
16999 "U operator - (E x, E y)"
17001 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
17004 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
17005 init-only variables, but this path did not take into account that
17006 there might be also instance readonly variables. Correct this
17009 This fixes bug 32253
17011 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
17014 * driver.cs: Change the extension for modules to `netmodule'
17016 * cs-parser.jay: Improved slightly the location tracking for
17017 the debugger symbols.
17019 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
17020 modifiers that were specified instead of the hardcoded value
17021 (FamAndAssem). This was basically ignoring the static modifier,
17022 and others. Fixes 32429.
17024 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
17025 fixed a bug in the process (32476)
17027 * expression.cs (ArrayAccess.EmitAssign): Patch from
17028 hwang_rob@yahoo.ca that fixes bug 31834.3
17030 2002-10-18 Miguel de Icaza <miguel@ximian.com>
17032 * driver.cs: Make the module extension .netmodule.
17034 2002-10-16 Miguel de Icaza <miguel@ximian.com>
17036 * driver.cs: Report an error if the resource file is not found
17037 instead of crashing.
17039 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
17040 false, like Emit does.
17042 2002-10-16 Nick Drochak <ndrochak@gol.com>
17044 * typemanager.cs: Remove unused private member. Also reported mcs
17045 bug to report this as a warning like csc.
17047 2002-10-15 Martin Baulig <martin@gnome.org>
17049 * statement.cs (Statement.Emit): Made this a virtual method; emits
17050 the line number info and calls DoEmit().
17051 (Statement.DoEmit): New protected abstract method, formerly knows
17052 as Statement.Emit().
17054 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
17056 2002-10-11 Miguel de Icaza <miguel@ximian.com>
17058 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
17059 have fixed a remaining problem: not every AddXXXX was adding a
17060 fully qualified name.
17062 Now everyone registers a fully qualified name in the DeclSpace as
17063 being defined instead of the partial name.
17065 Downsides: we are slower than we need to be due to the excess
17066 copies and the names being registered this way.
17068 The reason for this is that we currently depend (on the corlib
17069 bootstrap for instance) that types are fully qualified, because
17070 we dump all the types in the namespace, and we should really have
17071 types inserted into the proper namespace, so we can only store the
17072 basenames in the defined_names array.
17074 2002-10-10 Martin Baulig <martin@gnome.org>
17076 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
17077 from bug #31834, see the bug report for a testcase which is
17080 2002-10-10 Martin Baulig <martin@gnome.org>
17082 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
17083 flow analysis code for this.
17085 * statement.cs (Do, While, For): Tell the flow analysis code about
17087 (FlowBranching.UsageVector): Added support for infinite loops.
17088 (Block.Resolve): Moved the dead code elimination here and use flow
17091 2002-10-09 Miguel de Icaza <miguel@ximian.com>
17093 * class.cs (Field.Define): Catch cycles on struct type
17096 * typemanager.cs (IsUnmanagedtype): Do not recursively check
17097 fields if the fields are static. We only need to check instance
17100 * expression.cs (As.DoResolve): Test for reference type.
17102 * statement.cs (Using.ResolveExpression): Use
17103 ConvertImplicitRequired, not ConvertImplicit which reports an
17105 (Using.ResolveLocalVariableDecls): ditto.
17107 * expression.cs (Binary.ResolveOperator): Report errors in a few
17108 places where we had to.
17110 * typemanager.cs (IsUnmanagedtype): Finish implementation.
17112 2002-10-08 Miguel de Icaza <miguel@ximian.com>
17114 * expression.cs: Use StoreFromPtr instead of extracting the type
17115 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
17117 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
17118 an enumeration value to a System.Enum, but System.Enum is not a
17119 value type, but an class type, so we need to box.
17121 (Expression.ConvertExplicit): One codepath could return
17122 errors but not flag them. Fix this. Fixes #31853
17124 * parameter.cs (Resolve): Do not allow void as a parameter type.
17126 2002-10-06 Martin Baulig <martin@gnome.org>
17128 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
17129 if it's a class type and not a struct. Fixes #31815.
17131 2002-10-06 Martin Baulig <martin@gnome.org>
17133 * statement.cs: Reworked the flow analysis code a bit to make it
17134 usable for dead code elimination.
17136 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17138 * cs-parser.jay: allow empty source files. Fixes bug #31781.
17140 2002-10-04 Miguel de Icaza <miguel@ximian.com>
17142 * expression.cs (ComposedCast.DoResolveType): A quick workaround
17143 to fix the test 165, will investigate deeper.
17145 2002-10-04 Martin Baulig <martin@gnome.org>
17147 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
17148 finally blocks actually work.
17149 (Try.Resolve): We don't need to create a sibling for `finally' if
17150 there is no finally block.
17152 2002-10-04 Martin Baulig <martin@gnome.org>
17154 * class.cs (Constructor.Define): The default accessibility for a
17155 non-default constructor is private, not public.
17157 2002-10-04 Miguel de Icaza <miguel@ximian.com>
17159 * class.cs (Constructor): Make AllowedModifiers public, add
17162 * cs-parser.jay: Perform the modifiers test here, as the
17163 constructor for the Constructor class usually receives a zero
17164 because of the way we create it (first we create, later we
17165 customize, and we were never checking the modifiers).
17167 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
17168 is a version of LookupTypeReflection that includes the type-name
17169 cache. This can be used as a fast path for functions that know
17170 the fully qualified name and are only calling into *.GetType() to
17171 obtain a composed type.
17173 This is also used by TypeManager.LookupType during its type
17176 (LookupType): We now also track the real type name, as sometimes
17177 we can get a quey for the real type name from things like
17178 ComposedCast. This fixes bug 31422.
17180 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
17181 complete type fullname, it does not have to go through the type
17182 resolution system to obtain the composed version of the type (for
17183 obtaining arrays or pointers).
17185 (Conditional.Emit): Use the EmitBoolExpression to
17186 generate nicer code, as requested by Paolo.
17188 (ArrayCreation.CheckIndices): Use the patch from
17189 hwang_rob@yahoo.ca to validate the array initializers.
17191 2002-10-03 Miguel de Icaza <miguel@ximian.com>
17193 * class.cs (ConstructorInitializer.Emit): simplify code by using
17194 Invocation.EmitCall, and at the same time, fix the bugs in calling
17195 parent constructors that took variable arguments.
17197 * ecore.cs (Expression.ConvertNumericExplicit,
17198 Expression.ImplicitNumericConversion): Remove the code that
17199 manually wrapped decimal (InternalTypeConstructor call is now gone
17202 * expression.cs (Cast.TryReduce): Also handle decimal types when
17203 trying to perform a constant fold on the type.
17205 * typemanager.cs (IsUnmanagedtype): Partially implemented.
17207 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
17208 that only turned off an error report, and did nothing else.
17210 2002-10-02 Miguel de Icaza <miguel@ximian.com>
17212 * driver.cs: Handle and ignore /fullpaths
17214 2002-10-01 Miguel de Icaza <miguel@ximian.com>
17216 * expression.cs (Binary.ResolveOperator): Catch the case where
17217 DoNumericPromotions returns true,
17219 (Binary.DoNumericPromotions): Simplify the code, and the tests.
17221 2002-09-27 Miguel de Icaza <miguel@ximian.com>
17223 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
17226 2002-09-26 Miguel de Icaza <miguel@ximian.com>
17228 * ecore.cs (ConvertNumericExplicit): It is not enough that the
17229 conversion exists, but it is also required that the conversion be
17230 performed. This manifested in "(Type64Enum) 2".
17232 * class.cs (TypeManager.AddMethod): The fix is not to change
17233 AddEnum, because that one was using a fully qualified name (every
17234 DeclSpace derivative does), but to change the AddMethod routine
17235 that was using an un-namespaced name. This now correctly reports
17236 the duplicated name.
17238 Revert patch until I can properly fix it. The issue
17239 is that we have a shared Type space across all namespaces
17240 currently, which is wrong.
17242 Options include making the Namespace a DeclSpace, and merge
17243 current_namespace/current_container in the parser.
17245 2002-09-25 Miguel de Icaza <miguel@ximian.com>
17247 * cs-parser.jay: Improve error reporting when we get a different
17248 kind of expression in local_variable_type and
17249 local_variable_pointer_type.
17251 Propagate this to avoid missleading errors being reported.
17253 * ecore.cs (ImplicitReferenceConversion): treat
17254 TypeManager.value_type as a target just like object_type. As
17259 Is valid, and needs to result in the int 1 being boxed before it
17260 is assigned to the value type v.
17262 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
17263 to validate the enumeration name.
17265 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
17266 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
17267 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
17269 * ecore.cs (TryImplicitIntConversion): When doing an
17270 implicit-enumeration-conversion, check if the type is 64-bits and
17271 perform a conversion before passing to EnumConstant.
17273 2002-09-23 Miguel de Icaza <miguel@ximian.com>
17275 * decl.cs (Error_AmbiguousTypeReference); New routine used to
17276 report ambiguous type references. Unlike the MS version, we
17277 report what the ambiguity is. Innovation at work ;-)
17279 (DeclSpace.FindType): Require a location argument to
17280 display when we display an ambiguous error.
17282 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
17284 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
17286 * expression.cs (EmitDynamicInitializers): Apply patch from
17287 hwang_rob@yahoo.ca that fixes the order in which we emit our
17290 2002-09-21 Martin Baulig <martin@gnome.org>
17292 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
17293 delegate takes no arguments.
17295 2002-09-20 Miguel de Icaza <miguel@ximian.com>
17297 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
17300 * expression.cs: Extract the underlying type.
17302 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
17304 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
17306 2002-09-19 Miguel de Icaza <miguel@ximian.com>
17308 * class.cs (TypeContainer.DefineType): We can not use the nice
17309 PackingSize with the size set to 1 DefineType method, because it
17310 will not allow us to define the interfaces that the struct
17313 This completes the fixing of bug 27287
17315 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
17316 means also structs. This fixes part of the problem.
17317 (Expresion.ImplicitReferenceConversionExists): ditto.
17319 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
17320 error if there were no errors reported during the type lookup
17321 process, to avoid duplicates or redundant errors. Without this
17322 you would get an ambiguous errors plus a type not found. We have
17323 beaten the user enough with the first error.
17325 (DeclSparce.FindType): Emit a warning if we have an ambiguous
17328 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
17329 during the resolution process, stop the lookup, this avoids
17330 repeated error reports (same error twice).
17332 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
17334 * typemanager.cs (LookupType): Redo the type lookup code to match
17335 the needs of System.Reflection.
17337 The issue is that System.Reflection requires references to nested
17338 types to begin with a "+" sign instead of a dot. So toplevel
17339 types look like: "NameSpace.TopLevelClass", and nested ones look
17340 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
17343 2002-09-19 Martin Baulig <martin@gnome.org>
17345 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
17346 says that a method always returns or always throws an exception,
17347 don't report the CS0161.
17349 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
17350 set `Returns = new_returns'.
17352 2002-09-19 Martin Baulig <martin@gnome.org>
17354 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
17355 to an enum constant, check for a CS0176.
17357 2002-09-18 Miguel de Icaza <miguel@ximian.com>
17359 * class.cs (TypeContainer.CheckPairedOperators): Now we check
17360 for operators that must be in pairs and report errors.
17362 * ecore.cs (SimpleName.DoResolveType): During the initial type
17363 resolution process, when we define types recursively, we must
17364 check first for types in our current scope before we perform
17365 lookups in the enclosing scopes.
17367 * expression.cs (MakeByteBlob): Handle Decimal blobs.
17369 (Invocation.VerifyArgumentsCompat): Call
17370 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
17371 I thought we were supposed to always call this, but there are a
17372 few places in the code where we dont do it.
17374 2002-09-17 Miguel de Icaza <miguel@ximian.com>
17376 * driver.cs: Add support in -linkres and -resource to specify the
17377 name of the identifier.
17379 2002-09-16 Miguel de Icaza <miguel@ximian.com>
17381 * ecore.cs (StandardConversionExists): Sync with the conversion
17382 code: allow anything-* to void* conversions.
17384 (FindMostSpecificSource): Use an Expression argument
17385 instead of a Type, because we might be handed over a Literal which
17386 gets a few more implicit conversions that plain types do not. So
17387 this information was being lost.
17389 Also, we drop the temporary type-holder expression when not
17392 2002-09-17 Martin Baulig <martin@gnome.org>
17394 * class.cs (PropertyBase.CheckBase): Don't check the base class if
17395 this is an explicit interface implementation.
17397 2002-09-17 Martin Baulig <martin@gnome.org>
17399 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
17400 different `IndexerName' attributes.
17402 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
17403 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
17404 virtual CommonResolve().
17406 2002-09-16 Miguel de Icaza <miguel@ximian.com>
17408 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
17409 and convert that to the UnderlyingType.
17411 * statement.cs (Foreach.Resolve): Indexers are just like variables
17412 or PropertyAccesses.
17414 * cs-tokenizer.cs (consume_string): Track line numbers and columns
17415 inside quoted strings, we were not doing this before.
17417 2002-09-16 Martin Baulig <martin@gnome.org>
17419 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
17420 resolve it. This is needed for the definite assignment check of the
17421 instance expression, fixes bug #29846.
17422 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
17424 2002-09-16 Nick Drochak <ndrochak@gol.com>
17426 * parameter.cs: Fix compile error. Cannot reference static member
17427 from an instance object. Is this an mcs bug?
17429 2002-09-14 Martin Baulig <martin@gnome.org>
17431 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
17432 multiple times. Fixes bug #30295, added test-166.cs.
17434 2002-09-14 Martin Baulig <martin@gnome.org>
17436 * statement.cs (Block.Emit): Don't emit unreachable code.
17437 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
17438 `break' statements.
17439 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
17441 2002-09-14 Martin Baulig <martin@gnome.org>
17443 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
17446 2002-09-14 Martin Baulig <martin@gnome.org>
17448 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
17449 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
17450 be false on the ms runtime.
17452 2002-09-13 Martin Baulig <martin@gnome.org>
17454 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
17455 the CS0038 error message.
17457 2002-09-12 Miguel de Icaza <miguel@ximian.com>
17459 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
17460 constant inside, return it.
17462 2002-09-12 Martin Baulig <martin@gnome.org>
17464 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
17465 implicit conversion can be done between enum types.
17467 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
17468 check whether an implicit conversion to the current enum's UnderlyingType
17469 exists and report an error if not.
17471 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
17472 without debugging support.
17474 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
17475 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
17477 2002-09-12 Martin Baulig <martin@gnome.org>
17479 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
17481 * ecore.cs (IMemberExpr.DeclaringType): New property.
17482 (SimpleName.SimpleNameResolve): Check whether we're accessing a
17483 nonstatic member of an outer type (CS0038).
17485 2002-09-11 Miguel de Icaza <miguel@ximian.com>
17487 * driver.cs: Activate the using-error detector at warning level
17488 4 (at least for MS-compatible APIs).
17490 * namespace.cs (VerifyUsing): Small buglett fix.
17492 * pending.cs (PendingImplementation): pass the container pointer.
17494 * interface.cs (GetMethods): Allow for recursive definition. Long
17495 term, I would like to move every type to support recursive
17496 definitions, not the current ordering mechanism that we have right
17499 The situation is this: Attributes are handled before interfaces,
17500 so we can apply attributes to interfaces. But some attributes
17501 implement interfaces, we will now handle the simple cases
17502 (recursive definitions will just get an error).
17504 * parameter.cs: Only invalidate types at the end if we fail to
17507 2002-09-09 Martin Baulig <martin@gnome.org>
17509 * ecore.cs (PropertyExpr.Emit): Also check for
17510 TypeManager.system_int_array_get_length so this'll also work when
17511 compiling corlib. Fixes #30003.
17513 2002-09-09 Martin Baulig <martin@gnome.org>
17515 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
17516 and throw an exception if we can't get the type's size. Fixed #30040,
17519 2002-09-09 Martin Baulig <martin@gnome.org>
17521 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
17523 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
17524 context. Fixes bug #30027.
17526 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
17527 virtual functions. Fixes bug #30043, added test-164.cs.
17529 2002-09-08 Ravi Pratap <ravi@ximian.com>
17531 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
17533 2002-09-08 Nick Drochak <ndrochak@gol.com>
17535 * driver.cs: Use an object to get the windows codepage since it's not a
17538 2002-09-08 Miguel de Icaza <miguel@ximian.com>
17540 * statement.cs (For.Emit): for infinite loops (test == null)
17541 return whether there is a break inside, not always "true".
17543 * namespace.cs (UsingEntry): New struct to hold the name of the
17544 using definition, the location where it is defined, and whether it
17545 has been used in a successful type lookup.
17547 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
17552 2002-09-06 Ravi Pratap <ravi@ximian.com>
17554 * attribute.cs : Fix incorrect code which relied on catching
17555 a NullReferenceException to detect a null being passed in
17556 where an object was expected.
17558 2002-09-06 Miguel de Icaza <miguel@ximian.com>
17560 * statement.cs (Try): flag the catch variable as assigned
17562 * expression.cs (Cast): Simplified by using ResolveType instead of
17563 manually resolving.
17565 * statement.cs (Catch): Fix bug by using ResolveType.
17567 2002-09-06 Ravi Pratap <ravi@ximian.com>
17569 * expression.cs (BetterConversion): Special case for when we have
17570 a NullLiteral as the argument and we have to choose between string
17571 and object types - we choose string the way csc does.
17573 * attribute.cs (Attribute.Resolve): Catch the
17574 NullReferenceException and report error #182 since the Mono
17575 runtime no more has the bug and having this exception raised means
17576 we tried to select a constructor which takes an object and is
17579 2002-09-05 Ravi Pratap <ravi@ximian.com>
17581 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
17582 message (1502, 1503) when we can't locate a method after overload
17583 resolution. This is much more informative and closes the bug
17586 * interface.cs (PopulateMethod): Return if there are no argument
17587 types. Fixes a NullReferenceException bug.
17589 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
17590 expressions too. Previously we were checking only in one place for
17591 positional arguments leaving out named arguments.
17593 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
17594 type to the enum type is not allowed. Remove code corresponding to
17597 (ConvertNumericExplicit): Allow explicit conversions from
17598 the underlying type to enum type. This precisely follows the spec
17599 and closes a bug filed by Gonzalo.
17601 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17604 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
17606 2002-09-03 Miguel de Icaza <miguel@ximian.com>
17608 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
17609 it was important that we stored the right value after the
17610 reduction in `converted'.
17612 2002-09-04 Martin Baulig <martin@gnome.org>
17614 * location.cs (Location.SymbolDocument): Use full pathnames for the
17617 2002-08-30 Miguel de Icaza <miguel@ximian.com>
17619 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
17620 of the expression resolve mechanism, because that will catch the
17621 SimpleName error failures.
17623 (Conditional): If we can not resolve the
17624 expression, return, do not crash.
17626 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17629 (location): display token name instead of its number.
17631 2002-08-28 Martin Baulig <martin@gnome.org>
17633 * expression.cs (Binary.ResolveOperator): Don't silently return
17634 but return an error if an operator cannot be applied between two
17637 2002-08-28 Martin Baulig <martin@gnome.org>
17639 * class.cs (Constructor.Define): Set the permission attributes
17640 correctly instead of making all constructors public.
17642 2002-08-28 Martin Baulig <martin@gnome.org>
17644 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
17645 for private members before reporting a CS0103; if we find anything,
17648 2002-08-28 Martin Baulig <martin@gnome.org>
17650 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
17651 to check whether `closure_start_type == closure_invocation_type',
17652 we also need to check whether `m.DeclaringType == closure_invocation_type'
17653 before bypassing the permission checks. We might be accessing
17654 protected/private members from the base class.
17655 (TypeManager.RealMemberLookup): Only set private_ok if private
17656 members were requested via BindingFlags.NonPublic.
17658 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
17660 * expression.cs (MemberAccess.ResolveMemberAccess): Set
17661 MethodGroupExpr.IsExplicitImpl if appropriate.
17662 (Invocation.DoResolve): Don't report the CS0120 for explicit
17663 interface implementations.
17665 2002-08-27 Martin Baulig <martin@gnome.org>
17667 * expression.cs (Invocation.DoResolve): If this is a static
17668 method and we don't have an InstanceExpression, we must report
17671 2002-08-25 Martin Baulig <martin@gnome.org>
17673 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
17674 `==' between a valuetype and an object.
17676 2002-08-25 Miguel de Icaza <miguel@ximian.com>
17678 * ecore.cs (TypeExpr): Provide a ToString method.
17680 2002-08-24 Martin Baulig <martin@gnome.org>
17682 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
17683 now called proggie.dbg and it's a binary file.
17685 2002-08-23 Martin Baulig <martin@gnome.org>
17687 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
17689 2002-08-23 Martin Baulig <martin@gnome.org>
17691 * struct.cs (MyStructInfo.ctor): Make this work with empty
17692 structs; it's not allowed to use foreach() on null.
17694 2002-08-23 Martin Baulig <martin@gnome.org>
17696 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
17697 writer the full pathname of the generated assembly.
17699 2002-08-23 Martin Baulig <martin@gnome.org>
17701 * statements.cs (FlowBranching.UsageVector.MergeChildren):
17702 A `finally' block never returns or breaks; improved handling of
17705 2002-08-23 Martin Baulig <martin@gnome.org>
17707 * statement.cs (Throw.Resolve): Allow `throw null'.
17709 2002-08-23 Martin Baulig <martin@gnome.org>
17711 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
17712 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
17713 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
17714 MemberLookup would return a wrong event if this is an explicit
17715 interface implementation and the class has an event with the same
17718 2002-08-23 Martin Baulig <martin@gnome.org>
17720 * statement.cs (Block.AddChildVariableNames): New public method.
17721 (Block.AddChildVariableName): Likewise.
17722 (Block.IsVariableNameUsedInChildBlock): Likewise.
17723 (Block.AddVariable): Check whether a variable name has already
17724 been used in a child block.
17726 * cs-parser.jay (declare_local_variables): Mark all variable names
17727 from the current block as being used in a child block in the
17730 2002-08-23 Martin Baulig <martin@gnome.org>
17732 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
17733 find the symbol writer.
17735 * driver.cs: csc also allows the arguments to /define being
17736 separated by commas, not only by semicolons.
17738 2002-08-23 Martin Baulig <martin@gnome.org>
17740 * interface.cs (Interface.GetMembers): Added static check for events.
17742 2002-08-15 Martin Baulig <martin@gnome.org>
17744 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
17745 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
17747 * ecore.cs (Expression.MemberLookup): Added documentation and explained
17748 why the MethodData.EmitDestructor() change was necessary.
17750 2002-08-20 Martin Baulig <martin@gnome.org>
17752 * class.cs (TypeContainer.FindMembers): Added static check for events.
17754 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
17756 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
17757 use Type.GetEvents(), not Type.FindMembers().
17759 2002-08-20 Martin Baulig <martin@gnome.org>
17761 * decl.cs (MemberCache): Added a special method cache which will
17762 be used for method-only searched. This ensures that a method
17763 search will return a MethodInfo with the correct ReflectedType for
17766 2002-08-20 Martin Baulig <martin@gnome.org>
17768 * decl.cs (DeclSpace.FindMembers): Made this public.
17770 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17772 * delegate.cs: fixed build on windows.
17773 [FIXME: Filed as bug #29150: MCS must report these errors.]
17775 2002-08-19 Ravi Pratap <ravi@ximian.com>
17777 * ecore.cs (StandardConversionExists): Return a false
17778 if we are trying to convert the void type to anything else
17779 since that is not allowed.
17781 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
17782 we flag error 70 in the event an event is trying to be accessed
17783 directly from outside the declaring type.
17785 2002-08-20 Martin Baulig <martin@gnome.org>
17787 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
17788 MemberCache from typemanager.cs to decl.cs.
17790 2002-08-19 Martin Baulig <martin@gnome.org>
17792 * class.cs (TypeContainer): Implement IMemberContainer.
17793 (TypeContainer.DefineMembers): Create the MemberCache.
17794 (TypeContainer.FindMembers): Do better BindingFlags checking; only
17795 return public members if BindingFlags.Public was given, check
17796 whether members are static.
17798 2002-08-16 Martin Baulig <martin@gnome.org>
17800 * decl.cs (DeclSpace.Define): Splitted this in Define and
17801 DefineMembers. DefineMembers is called first and initializes the
17804 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
17805 DefineMembers() on all our DeclSpaces.
17807 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
17808 but call DefineMembers() on all nested interfaces. We call their
17809 Define() in our new Define() function.
17811 * interface.cs (Interface): Implement IMemberContainer.
17812 (Interface.Define): Moved all code except the attribute stuf to
17814 (Interface.DefineMembers): Initialize the member cache.
17816 * typemanager.cs (IMemberFinder): Removed this interface, we don't
17817 need this anymore since we can use MemberCache.FindMembers directly.
17819 2002-08-19 Martin Baulig <martin@gnome.org>
17821 * typemanager.cs (MemberCache): When creating the cache for an
17822 interface type, add all inherited members.
17823 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
17824 to `out bool used_cache' and documented it.
17825 (TypeManager.MemberLookup): If we already used the cache in the first
17826 iteration, we don't need to do the interfaces check.
17828 2002-08-19 Martin Baulig <martin@gnome.org>
17830 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
17831 here from IMemberFinder and don't implement this interface anymore.
17832 (DeclSpace.MemberCache): Moved here from IMemberFinder.
17834 * typemanager.cs (IMemberFinder): This interface is now only used by
17835 classes which actually support the member cache.
17836 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
17837 since we only put DeclSpaces into this Hashtable.
17838 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
17839 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
17841 2002-08-16 Martin Baulig <martin@gnome.org>
17843 * typemanager.cs (ICachingMemberFinder): Removed.
17844 (IMemberFinder.MemberCache): New property.
17845 (TypeManager.FindMembers): Merged this with RealFindMembers().
17846 This function will never be called from TypeManager.MemberLookup()
17847 so we can't use the cache here, just the IMemberFinder.
17848 (TypeManager.MemberLookup_FindMembers): Check whether the
17849 IMemberFinder has a MemberCache and call the cache's FindMembers
17851 (MemberCache): Rewrote larger parts of this yet another time and
17852 cleaned it up a bit.
17854 2002-08-15 Miguel de Icaza <miguel@ximian.com>
17856 * driver.cs (LoadArgs): Support quoting.
17858 (Usage): Show the CSC-like command line arguments.
17860 Improved a few error messages.
17862 2002-08-15 Martin Baulig <martin@gnome.org>
17864 * typemanager.cs (IMemberContainer.Type): New property.
17865 (IMemberContainer.IsInterface): New property.
17867 The following changes are conditional to BROKEN_RUNTIME, which is
17868 defined at the top of the file.
17870 * typemanager.cs (MemberCache.MemberCache): Don't add the base
17871 class'es members, but add all members from TypeHandle.ObjectType
17872 if we're an interface.
17873 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
17874 is the current type.
17875 (MemberCache.CacheEntry.Container): Removed this field.
17876 (TypeHandle.GetMembers): Include inherited members.
17878 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17880 * typemanager.cs: fixed compilation and added a comment on a field that
17883 2002-08-15 Martin Baulig <martin@gnome.org>
17885 * class.cs (ConstructorInitializer.Resolve): In the
17886 Expression.MemberLookup call, use the queried_type as
17889 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
17890 declared' attribute, it's always true.
17891 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
17892 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
17893 temporary wrapper for FindMembers which tells MemberLookup whether
17894 members from the base classes are included in the return value.
17895 This will go away soon.
17896 (TypeManager.MemberLookup): Use this temporary hack here; once the
17897 new MemberCache is completed, we don't need to do the DeclaredOnly
17898 looping here anymore since the MemberCache will take care of this.
17899 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
17900 (MemberCache): When creating the MemberCache for a class, get
17901 members from the current class and all its base classes.
17902 (MemberCache.CacheEntry.Container): New field. This is a
17903 temporary hack until the Mono runtime is fixed to distinguish
17904 between ReflectedType and DeclaringType. It allows us to use MCS
17905 with both the MS runtime and the unfixed Mono runtime without
17906 problems and without accecting performance.
17907 (MemberCache.SearchMembers): The DeclaredOnly looping from
17908 TypeManager.MemberLookup is now done here.
17910 2002-08-14 Martin Baulig <martin@gnome.org>
17912 * statement.cs (MyStructInfo.MyStructInfo): Don't call
17913 Type.GetFields on dynamic types but get the fields from the
17914 corresponding TypeContainer.
17915 (MyStructInfo.GetStructInfo): Added check for enum types.
17917 * typemanager.cs (MemberList.IsSynchronized): Implemented.
17918 (MemberList.SyncRoot): Implemented.
17919 (TypeManager.FilterWithClosure): No need to check permissions if
17920 closure_start_type == closure_invocation_type, don't crash if
17921 closure_invocation_type is null.
17923 2002-08-13 Martin Baulig <martin@gnome.org>
17925 Rewrote TypeContainer.FindMembers to use a member cache. This
17926 gives us a speed increase of about 35% for the self-hosting MCS
17927 build and of about 15-20% for the class libs (both on GNU/Linux).
17929 * report.cs (Timer): New class to get enhanced profiling. This
17930 whole class is "TIMER" conditional since it remarkably slows down
17933 * class.cs (MemberList): New class. This is an IList wrapper
17934 which we're now using instead of passing MemberInfo[]'s around to
17935 avoid copying this array unnecessarily.
17936 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
17937 (ICachingMemberFinder, IMemberContainer): New interface.
17938 (TypeManager.FilterWithClosure): If `criteria' is null, the name
17939 has already been checked, otherwise use it for the name comparision.
17940 (TypeManager.FindMembers): Renamed to RealMemberFinder and
17941 provided wrapper which tries to use ICachingMemberFinder.FindMembers
17942 if possible. Returns a MemberList, not a MemberInfo [].
17943 (TypeHandle): New class, implements IMemberContainer. We create
17944 one instance of this class per type, it contains a MemberCache
17945 which is used to do the member lookups.
17946 (MemberCache): New class. Each instance of this class contains
17947 all members of a type and a name-based hash table.
17948 (MemberCache.FindMembers): This is our new member lookup
17949 function. First, it looks up all members of the requested name in
17950 the hash table. Then, it walks this list and sorts out all
17951 applicable members and returns them.
17953 2002-08-13 Martin Baulig <martin@gnome.org>
17955 In addition to a nice code cleanup, this gives us a performance
17956 increase of about 1.4% on GNU/Linux - not much, but it's already
17957 half a second for the self-hosting MCS compilation.
17959 * typemanager.cs (IMemberFinder): New interface. It is used by
17960 TypeManager.FindMembers to call FindMembers on a TypeContainer,
17961 Enum, Delegate or Interface.
17962 (TypeManager.finder_to_member_finder): New PtrHashtable.
17963 (TypeManager.finder_to_container): Removed.
17964 (TypeManager.finder_to_delegate): Removed.
17965 (TypeManager.finder_to_interface): Removed.
17966 (TypeManager.finder_to_enum): Removed.
17968 * interface.cs (Interface): Implement IMemberFinder.
17970 * delegate.cs (Delegate): Implement IMemberFinder.
17972 * enum.cs (Enum): Implement IMemberFinder.
17974 * class.cs (TypeContainer): Implement IMemberFinder.
17976 2002-08-12 Martin Baulig <martin@gnome.org>
17978 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
17980 2002-08-12 Martin Baulig <martin@gnome.org>
17982 * ecore.cs (ITypeExpression): New interface for expressions which
17984 (TypeExpression): Renamed to TypeLookupExpression.
17985 (Expression.DoResolve): If we're doing a types-only lookup, the
17986 expression must implement the ITypeExpression interface and we
17987 call DoResolveType() on it.
17988 (SimpleName): Implement the new ITypeExpression interface.
17989 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
17990 hack, the situation that we're only looking up types can't happen
17991 anymore when this method is called. Moved the type lookup code to
17992 DoResolveType() and call it.
17993 (SimpleName.DoResolveType): This ITypeExpression interface method
17994 is now doing the types-only lookup.
17995 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
17996 (ResolveFlags): Added MaskExprClass.
17998 * expression.cs (MemberAccess): Implement the ITypeExpression
18000 (MemberAccess.DoResolve): Added support for a types-only lookup
18001 when we're called via ITypeExpression.DoResolveType().
18002 (ComposedCast): Implement the ITypeExpression interface.
18004 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
18005 Expression.Resolve() with ResolveFlags.Type instead.
18007 2002-08-12 Martin Baulig <martin@gnome.org>
18009 * interface.cs (Interface.Define): Apply attributes.
18011 * attribute.cs (Attribute.ApplyAttributes): Added support for
18012 interface attributes.
18014 2002-08-11 Martin Baulig <martin@gnome.org>
18016 * statement.cs (Block.Emit): Only check the "this" variable if we
18017 do not always throw an exception.
18019 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
18020 whether the property has a set accessor.
18022 2002-08-11 Martin Baulig <martin@gnome.org>
18024 Added control flow analysis support for structs.
18026 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
18027 with control flow analysis turned off.
18028 (IVariable): New interface.
18029 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
18030 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
18031 (FieldExpr.DoResolve): Resolve the instance expression with flow
18032 analysis turned off and do the definite assignment check after the
18033 resolving when we know what the expression will resolve to.
18035 * expression.cs (LocalVariableReference, ParameterReference):
18036 Implement the new IVariable interface, only call the flow analysis
18037 code if ec.DoFlowAnalysis is true.
18038 (This): Added constructor which takes a Block argument. Implement
18039 the new IVariable interface.
18040 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
18041 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
18042 This does the definite assignment checks for struct members.
18044 * class.cs (Constructor.Emit): If this is a non-static `struct'
18045 constructor which doesn't have any initializer, call
18046 Block.AddThisVariable() to tell the flow analysis code that all
18047 struct elements must be initialized before control returns from
18050 * statement.cs (MyStructInfo): New public class.
18051 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
18052 argument to this indexer. If non-zero, check an individual struct
18053 member, not the whole struct.
18054 (FlowBranching.CheckOutParameters): Check struct members.
18055 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
18056 overloaded versions of these methods which take an additional
18057 `int field_idx' argument to check struct members.
18058 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
18059 overloaded versions of these methods which take an additional
18060 `string field_name' argument to check struct member.s
18061 (VariableInfo): Implement the IVariable interface.
18062 (VariableInfo.StructInfo): New public property. Returns the
18063 MyStructInfo instance of the variable if it's a struct or null.
18064 (Block.AddThisVariable): New public method. This is called from
18065 Constructor.Emit() for non-static `struct' constructor which do
18066 not have any initializer. It creates a special variable for the
18067 "this" instance variable which will be checked by the flow
18068 analysis code to ensure that all of the struct's fields are
18069 initialized before control returns from the constructor.
18070 (UsageVector): Added support for struct members. If a
18071 variable/parameter is a struct with N members, we reserve a slot
18072 in the usage vector for each member. A struct is considered fully
18073 initialized if either the struct itself (slot 0) or all its
18074 members are initialized.
18076 2002-08-08 Martin Baulig <martin@gnome.org>
18078 * driver.cs (Driver.MainDriver): Only report an error CS5001
18079 if there were no compilation errors.
18081 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
18082 `UnsafeContext' property to determine whether the parent is in
18083 unsafe context rather than checking the parent's ModFlags:
18084 classes nested in an unsafe class are unsafe as well.
18086 2002-08-08 Martin Baulig <martin@gnome.org>
18088 * statement.cs (UsageVector.MergeChildren): Distinguish between
18089 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
18090 we return. Added test17() and test18() to test-154.cs.
18092 2002-08-08 Martin Baulig <martin@gnome.org>
18094 * typemanager.cs (TypeManager.FilterWithClosure): If we have
18095 Family access, make sure the invoking type isn't a subclass of the
18096 queried type (that'd be a CS1540).
18098 * ecore.cs (Expression.MemberLookup): Added overloaded version of
18099 this method which takes an additional `Type invocation_type'.
18101 * expression.cs (BaseAccess.DoResolve): Use the base type as
18102 invocation and query type.
18103 (MemberAccess.DoResolve): If the lookup failed and we're about to
18104 report a CS0122, try a lookup with the ec.ContainerType - if this
18105 succeeds, we must report a CS1540.
18107 2002-08-08 Martin Baulig <martin@gnome.org>
18109 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
18110 (MethodGroupExpr): Implement the IMemberExpr interface.
18112 * expression (MemberAccess.ResolveMemberAccess): No need to have
18113 any special code for MethodGroupExprs anymore, they're now
18116 2002-08-08 Martin Baulig <martin@gnome.org>
18118 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
18119 Family, FamANDAssem and FamORAssem permissions.
18120 (TypeManager.IsSubclassOrNestedChildOf): New public method.
18122 2002-08-08 Martin Baulig <martin@gnome.org>
18124 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
18125 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
18128 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
18130 * driver.cs: implemented /resource option to embed managed resources.
18132 2002-08-07 Martin Baulig <martin@gnome.org>
18134 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
18135 (FieldBase.HasFieldInitializer): New public property.
18136 (FieldBase.GetInitializerExpression): New public method. Resolves and
18137 returns the field initializer and makes sure it is only resolved once.
18138 (TypeContainer.EmitFieldInitializers): Call
18139 FieldBase.GetInitializerExpression to get the initializer, this ensures
18140 that it isn't resolved multiple times.
18142 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
18143 the resolving process (SimpleName/MemberLookup) that we're currently
18144 emitting a field initializer (which must not access any instance members,
18145 this is an error CS0236).
18147 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
18148 argument, if the `IsFieldInitializer' flag is set, we must report and
18149 error CS0236 and not an error CS0120.
18151 2002-08-07 Martin Baulig <martin@gnome.org>
18153 * ecore.cs (IMemberExpr): New public interface.
18154 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
18155 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
18156 if the expression is an IMemberExpr.
18158 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
18159 to be null, implicitly default to `this' if we're non-static in
18160 this case. Simplified the code a lot by using the new IMemberExpr
18161 interface. Also fixed bug #28176 here.
18163 2002-08-06 Martin Baulig <martin@gnome.org>
18165 * cs-parser.jay (SimpleLookup): Removed. We need to create
18166 ParameterReferences during semantic analysis so that we can do a
18167 type-only search when resolving Cast, TypeOf and SizeOf.
18168 (block): Pass the `current_local_parameters' to the Block's
18171 * class.cs (ConstructorInitializer): Added `Parameters parameters'
18172 argument to the constructor.
18173 (ConstructorInitializer.Resolve): Create a temporary implicit
18174 block with the parameters.
18176 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
18177 references here if we aren't doing a type-only search.
18179 * statement.cs (Block): Added constructor which takes a
18180 `Parameters parameters' argument.
18181 (Block.Parameters): New public property.
18183 * support.cs (InternalParameters.Parameters): Renamed `parameters'
18184 to `Parameters' and made it public readonly.
18186 2002-08-06 Martin Baulig <martin@gnome.org>
18188 * ecore.cs (Expression.Warning): Made this public as well.
18190 * report.cs (Report.Debug): Print the contents of collections.
18192 2002-08-06 Martin Baulig <martin@gnome.org>
18194 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
18195 used to tell Resolve() which kinds of expressions it may return.
18196 (Expression.Resolve): Added overloaded version of this method which
18197 takes a `ResolveFlags flags' argument. This can be used to tell
18198 Resolve() which kinds of expressions it may return. Reports a
18200 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
18201 ResolveFlags.SimpleName.
18202 (Expression.Error118): Added overloaded version of this method which
18203 takes a `ResolveFlags flags' argument. It uses the flags to determine
18204 which kinds of expressions are allowed.
18206 * expression.cs (Argument.ResolveMethodGroup): New public method.
18207 Resolves an argument, but allows a MethodGroup to be returned.
18208 This is used when invoking a delegate.
18210 * TODO: Updated a bit.
18212 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18214 Fixed compilation with csc.
18216 * ecore.cs: Expression.Error made public. Is this correct? Should
18217 Warning be made public too?
18219 * expression.cs: use ea.Location instead of ea.loc.
18220 [FIXME: Filed as bug #28607: MCS must report these errors.]
18222 2002-08-06 Martin Baulig <martin@gnome.org>
18224 * ecore.cs (Expression.loc): Moved the location here instead of
18225 duplicating it in all derived classes.
18226 (Expression.Location): New public property.
18227 (Expression.Error, Expression.Warning): Made them non-static and
18228 removed the location argument.
18229 (Expression.Warning): Added overloaded version which takes an
18230 `int level' argument.
18231 (Expression.Error118): Make this non-static and removed the
18232 expression and location arguments.
18233 (TypeExpr): Added location argument to the constructor.
18235 * expression.cs (StaticCallExpr): Added location argument to
18237 (Indirection, PointerArithmetic): Likewise.
18238 (CheckedExpr, UnCheckedExpr): Likewise.
18239 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
18240 (StringPtr): Likewise.
18243 2002-08-05 Martin Baulig <martin@gnome.org>
18245 * expression.cs (BaseAccess.DoResolve): Actually report errors.
18247 * assign.cs (Assign.DoResolve): Check whether the source
18248 expression is a value or variable.
18250 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
18251 while resolving the corresponding blocks.
18253 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
18254 an error, don't silently return null.
18256 * statement.cs (Block.AddVariable): Do the error reporting here
18257 and distinguish between CS0128 and CS0136.
18258 (Block.DoResolve): Report all unused labels (warning CS0164).
18259 (LabeledStatement): Pass the location to the constructor.
18260 (LabeledStatement.HasBeenReferenced): New property.
18261 (LabeledStatement.Resolve): Set it to true here.
18263 * statement.cs (Return.Emit): Return success even after reporting
18264 a type mismatch error (CS0126 or CS0127), this is what csc does and
18265 it avoids confusing the users with any consecutive errors.
18267 2002-08-05 Martin Baulig <martin@gnome.org>
18269 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
18271 * const.cs (Const.LookupConstantValue): Catch circular definitions.
18273 * expression.cs (MemberAccess.DoResolve): Silently return if an
18274 error has already been reported.
18276 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
18277 error has already been reported.
18279 2002-08-05 Martin Baulig <martin@gnome.org>
18281 * statement.cs (UsageVector): Only initialize the `parameters'
18282 vector if we actually have any "out" parameters.
18284 2002-08-05 Martin Baulig <martin@gnome.org>
18286 * expression.cs (Binary.ResolveOperator): When combining delegates,
18287 they must have the same type.
18289 2002-08-05 Martin Baulig <martin@gnome.org>
18291 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
18292 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
18293 work with the ms runtime and we also don't need it: if we're a
18294 PropertyBuilder and not in the `indexer_arguments' hash, then we
18295 are a property and not an indexer.
18297 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
18298 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
18299 since the latter one doesn't work with the ms runtime.
18301 2002-08-03 Martin Baulig <martin@gnome.org>
18303 Fixed bugs #27998 and #22735.
18305 * class.cs (Method.IsOperator): New public field.
18306 (Method.CheckBase): Report CS0111 if there's already a method
18307 with the same parameters in the current class. Report CS0508 when
18308 attempting to change the return type of an inherited method.
18309 (MethodData.Emit): Report CS0179 if a method doesn't have a body
18310 and it's not marked abstract or extern.
18311 (PropertyBase): New abstract base class for Property and Indexer.
18312 (PropertyBase.CheckBase): Moved here from Property and made it work
18314 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
18315 the same so we can reuse it there.
18316 (Property, Indexer): Derive from PropertyBase.
18317 (MethodSignature.inheritable_property_signature_filter): New delegate
18318 to find properties and indexers.
18320 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
18321 argument and improved error reporting.
18323 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
18324 EmptyReadOnlyParameters and made it a property.
18326 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
18327 version of this method which takes a `PropertyInfo indexer'.
18328 (TypeManager.RegisterIndexer): New method.
18330 * class.cs: Added myself as author of this file :-)
18332 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18334 * class.cs: fixed compilation on windoze.
18336 2002-08-03 Martin Baulig <martin@gnome.org>
18338 * interface.cs (Interface.GetInterfaceBases): Check whether all
18339 base interfaces are at least as accessible than the current one.
18341 * class.cs (TypeContainer.GetClassBases): Check whether base types
18342 are at least as accessible than the current type.
18343 (TypeContainer.AsAccessible): Implemented and made non-static.
18344 (MemberBase.CheckParameters): Report errors if the accessibility
18347 * delegate.cs (Delegate.Delegate): The default visibility is
18348 internal for top-level types and private for nested types.
18349 (Delegate.Define): Report errors if the accessibility checks fail.
18351 * enum.cs (Enum.Enum): The default visibility is internal for
18352 top-level types and private for nested types.
18353 (Enum.DefineType): Compute the correct visibility.
18355 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
18356 function which takes a `bool is_toplevel' instead of a TypeContainer.
18358 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
18361 2002-08-02 Martin Baulig <martin@gnome.org>
18363 * expression.cs (LocalVariableReferenc): Added constructor which
18364 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
18365 (LocalVariableReference.IsReadOnly): New property.
18366 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
18367 variable is readonly, use our own readonly flag to do this; you can
18368 use the new constructor to get a writable reference to a read-only
18371 * cs-parser.jay (foreach_statement, using_statement): Get a writable
18372 reference to the local variable.
18374 2002-08-01 Miguel de Icaza <miguel@ximian.com>
18376 * rootcontext.cs (ResolveCore): Also include System.Exception
18378 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
18379 we reach an EmptyStatement.
18381 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
18384 * expression.cs (Binary.ResolveOperator): Check error result in
18387 use brtrue/brfalse directly and avoid compares to null.
18389 2002-08-02 Martin Baulig <martin@gnome.org>
18391 * class.cs (TypeContainer.Define): Define all nested interfaces here.
18392 Fixes bug #28407, added test-155.cs.
18394 2002-08-01 Martin Baulig <martin@gnome.org>
18396 * class.cs (Event.EmitDefaultMethod): Make this work with static
18397 events. Fixes #28311, added verify-3.cs.
18399 2002-08-01 Martin Baulig <martin@gnome.org>
18401 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
18402 `is_disposable' fields.
18403 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
18404 `hm.is_disposable' if we're using the collection pattern.
18405 (Foreach.EmitCollectionForeach): Use the correct type for the
18406 enumerator's local variable, only emit the try/finally block if
18407 necessary (fixes #27713).
18409 2002-08-01 Martin Baulig <martin@gnome.org>
18411 * ecore.cs (Expression.report118): Renamed to Error118 and made
18414 * statement.cs (Throw.Resolve): Check whether the expression is of
18415 the correct type (CS0118) and whether the type derives from
18416 System.Exception (CS0155).
18417 (Catch.Resolve): New method. Do the type lookup here and check
18418 whether it derives from System.Exception (CS0155).
18419 (Catch.CatchType, Catch.IsGeneral): New public properties.
18421 * typemanager.cs (TypeManager.exception_type): Added.
18423 2002-07-31 Miguel de Icaza <miguel@ximian.com>
18425 * driver.cs: Updated About function.
18427 2002-07-31 Martin Baulig <martin@gnome.org>
18429 Implemented Control Flow Analysis.
18431 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
18432 (EmitContext.CurrentBranching): Added.
18433 (EmitContext.StartFlowBranching): Added.
18434 (EmitContext.EndFlowBranching): Added.
18435 (EmitContext.KillFlowBranching): Added.
18436 (EmitContext.IsVariableAssigned): Added.
18437 (EmitContext.SetVariableAssigned): Added.
18438 (EmitContext.IsParameterAssigned): Added.
18439 (EmitContext.SetParameterAssigned): Added.
18440 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
18441 Added control flow analysis stuff here.
18443 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
18444 resolve the expression as lvalue.
18445 (LocalVariableReference.DoResolve): Check whether the variable has
18446 already been assigned.
18447 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
18448 the parameter as assigned here.
18449 (ParameterReference.DoResolve): Check whether the parameter has already
18451 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
18452 expression as lvalue.
18454 * statement.cs (FlowBranching): New class for the flow analysis code.
18455 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
18456 (LabeledStatement.IsDefined): New public property.
18457 (LabeledStatement.AddUsageVector): New public method to tell flow
18458 analyis that the label may be reached via a forward jump.
18459 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
18461 (VariableInfo.Number): New public field. This is used by flow analysis
18462 to number all locals of a block.
18463 (Block.CountVariables): New public property. This is the number of
18464 local variables in this block (including the locals from all parent
18466 (Block.EmitMeta): Number all the variables.
18468 * statement.cs: Added flow analysis support to all classes.
18470 2002-07-31 Martin Baulig <martin@gnome.org>
18472 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
18473 To get debugging messages, compile mcs with /define:MCS_DEBUG and
18474 then use this argument.
18476 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
18478 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
18479 use this to specify /define options.
18481 2002-07-29 Martin Baulig <martin@gnome.org>
18483 * statement.cs (Fixed): Moved all code that does variable lookups
18484 and resolvings from Emit to Resolve.
18486 * statement.cs (For): Moved all code that does variable lookups
18487 and resolvings from Emit to Resolve.
18489 * statement.cs (Using): Moved all code that does variable lookups
18490 and resolvings from Emit to Resolve.
18492 2002-07-29 Martin Baulig <martin@gnome.org>
18494 * attribute.cs (Attribute.Resolve): Explicitly catch a
18495 System.NullReferenceException when creating the
18496 CustromAttributeBuilder and report a different warning message.
18498 2002-07-29 Martin Baulig <martin@gnome.org>
18500 * support.cs (ParameterData.ParameterName): Added method to
18501 get the name of a parameter.
18503 * typemanager.cs (TypeManager.IsValueType): New public method.
18505 2002-07-29 Martin Baulig <martin@gnome.org>
18507 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
18508 is a flag which specifies that it's either ref or out.
18509 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
18510 the out parameter to `out Parameter.Modifier mod', also set the
18511 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
18513 * support.cs (InternalParameters.ParameterModifier): Distinguish
18514 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
18515 Parameter.Modifier.ISBYREF flag if it's either ref or out.
18517 * expression.cs (Argument.GetParameterModifier): Distinguish
18518 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
18519 Parameter.Modifier.ISBYREF flag if it's either ref or out.
18521 2002-07-29 Martin Baulig <martin@gnome.org>
18523 * expression.cs (ParameterReference.ParameterReference): Added
18524 `Location loc' argument to the constructor.
18526 * cs-parser.jay: Pass location to ParameterReference.
18528 2002-07-28 Miguel de Icaza <miguel@ximian.com>
18530 * statement.cs (Try): Initialize the location.
18532 * cs-parser.jay: pass location to Try.
18534 * expression.cs (Unary.Reduce): Change the prototype to return
18535 whether a constant fold could be performed or not. The result is
18536 returned in an out parameters. In the case of Indirection and
18537 AddressOf, we want to perform the full tests.
18539 2002-07-26 Miguel de Icaza <miguel@ximian.com>
18541 * statement.cs (Statement.Emit): Flag dead code.
18543 2002-07-27 Andrew Birkett <andy@nobugs.org>
18545 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
18547 2002-07-27 Martin Baulig <martin@gnome.org>
18549 * class.cs (MethodData.Define): Put back call to
18550 TypeManager.AddMethod(), accidentally commented this out.
18552 * report.cs (Debug): New public method to print debugging information,
18553 this is `[Conditional ("DEBUG")]'.
18555 2002-07-26 Martin Baulig <martin@gnome.org>
18557 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
18558 (switch_statement): Push the current_block to the switch_stack and
18559 pop it again when we're done with the switch.
18560 (switch_section): The new block is a child of the current_block.
18561 Fixes bug #24007, added test-152.cs.
18563 2002-07-27 Martin Baulig <martin@gnome.org>
18565 * expression.cs (Invocation.EmitArguments): When calling a varargs
18566 function with only its fixed arguments, we need to pass an empty
18569 2002-07-27 Martin Baulig <martin@gnome.org>
18571 Mono 0.13 has been released.
18573 2002-07-25 Miguel de Icaza <miguel@ximian.com>
18575 * driver.cs: Rename --resource to --linkres, because that is what
18576 we do currently, we dont support --resource yet.
18578 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
18580 2002-07-25 Martin Baulig <martin@gnome.org>
18582 * class.cs (MethodData): New public class. This is a `method builder'
18583 class for a method or one accessor of a Property/Indexer/Event.
18584 (MethodData.GetMethodFlags): Moved here from MemberBase.
18585 (MethodData.ApplyAttributes): Likewise.
18586 (MethodData.ApplyObsoleteAttribute): Likewise.
18587 (MethodData.ApplyConditionalAttribute): Likewise.
18588 (MethodData.ApplyDllImportAttribute): Likewise.
18589 (MethodData.CheckAbstractAndExternal): Likewise.
18590 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
18591 (MethodData.Emit): Formerly known as Method.Emit().
18592 (MemberBase): Moved everything which was specific to a single
18593 accessor/method to MethodData.
18594 (Method): Create a new MethodData and call Define() and Emit() on it.
18595 (Property, Indexer, Event): Create a new MethodData objects for each
18596 accessor and call Define() and Emit() on them.
18598 2002-07-25 Martin Baulig <martin@gnome.org>
18600 Made MethodCore derive from MemberBase to reuse the code from there.
18601 MemberBase now also checks for attributes.
18603 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
18604 (MemberBase.GetMethodFlags): Moved here from class Method and marked
18606 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
18607 `CallingConventions cc' and `Attributes opt_attrs' arguments.
18608 (MemberBase.ApplyAttributes): New virtual method; applies the
18609 attributes to a method or accessor.
18610 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
18611 (MemberBase.ApplyConditionalAttribute): Likewise.
18612 (MemberBase.ApplyDllImportAttribute): Likewise.
18613 (MemberBase.CheckAbstractAndExternal): Likewise.
18614 (MethodCore.ParameterTypes): This is now a property instead of a
18615 method, it's initialized from DoDefineParameters().
18616 (MethodCore.ParameterInfo): Removed the set accessor.
18617 (MethodCore.DoDefineParameters): New protected virtual method to
18618 initialize ParameterTypes and ParameterInfo.
18619 (Method.GetReturnType): We can now simply return the MemberType.
18620 (Method.GetMethodFlags): Override the MemberBase version and add
18621 the conditional flags.
18622 (Method.CheckBase): Moved some code from Define() here, call
18623 DoDefineParameters() here.
18624 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
18625 here to avoid some larger code duplication.
18626 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
18627 ensure that abstract and external accessors don't declare a body.
18629 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
18630 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
18631 lookup in the attribute's parent classes, so we need to abort as soon
18632 as we found the first match.
18633 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
18634 the attribute has no arguments.
18636 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
18639 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18641 * cs-parser.jay: reverted previous patch.
18643 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18645 * cs-parser.jay: fixed bug #22119.
18647 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18649 * attribute.cs: fixed compilation. The error was:
18650 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
18651 be assigned to before control leaves the current method."
18652 [FIXME: Filed as bug #28186: MCS must report this error.]
18654 2002-07-25 Martin Baulig <martin@gnome.org>
18656 * attribute.cs (Attribute.Conditional_GetConditionName): New static
18657 method to pull the condition name ouf of a Conditional attribute.
18658 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
18659 the obsolete message and error flag out of an Obsolete attribute.
18661 * class.cs (Method.GetMethodFlags): New public method to get the
18662 TypeManager.MethodFlags for this method.
18663 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
18665 (Method.Define): Get and apply the Obsolete and Conditional attributes;
18666 if we're overriding a virtual function, set the new private variable
18667 `parent_method'; call the new TypeManager.AddMethod().
18669 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
18670 the MethodBuilder and the Method in a PtrHashtable.
18671 (TypeManager.builder_to_method): Added for this purpose.
18672 (TypeManager.MethodFlags): Added IsObsoleteError.
18673 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
18674 Obsolete and Conditional arguments in MethodBuilders. If we discover
18675 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
18676 the message from the attribute.
18678 2002-07-24 Martin Baulig <martin@gnome.org>
18680 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
18681 preprocessor directives, ensure that the argument to #define/#undef is
18682 exactly one identifier and that it's actually an identifier.
18684 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
18687 2002-07-24 Martin Baulig <martin@gnome.org>
18689 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
18690 initialize it to TypeManager.object_type in the constructor.
18691 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
18692 of the `hm.get_current' method if we're using the collection pattern.
18693 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
18694 for the explicit conversion to make it work when we're using the collection
18695 pattern and the `Current' property has a different return type than `object'.
18698 2002-07-24 Martin Baulig <martin@gnome.org>
18700 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
18701 does not match, but don't report any errors. This method is called in
18702 order for all methods in a MethodGroupExpr until a matching method is
18703 found, so we don't want to bail out if the first method doesn't match.
18704 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
18705 matches, report the 123. Fixes #28070.
18707 2002-07-24 Martin Baulig <martin@gnome.org>
18709 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
18710 TypeManager.TypeToCoreType() to the top of the method so the
18711 following equality checks will work. Fixes #28107.
18713 2002-07-24 Martin Baulig <martin@gnome.org>
18715 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
18716 operand is of type uint, and the other operand is of type sbyte,
18717 short or int, the operands are converted to type long." -
18718 Actually do what this comment already told us. Fixes bug #28106,
18721 2002-07-24 Martin Baulig <martin@gnome.org>
18723 * class.cs (MethodBase): New abstract class. This is now a base
18724 class for Property, Indexer and Event to avoid some code duplication
18725 in their Define() and DefineMethods() methods.
18726 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
18727 generic methods for Define() and DefineMethods().
18728 (FieldBase): Derive from MemberBase, not MemberCore.
18729 (Property): Derive from MemberBase, not MemberCore.
18730 (Property.DefineMethod): Moved all the code from this method to the
18731 new MethodBase.DefineAccessor(), just call it with appropriate
18733 (Property.Define): Call the new Property.DoDefine(), this does some
18734 sanity checks and we don't need to duplicate the code everywhere.
18735 (Event): Derive from MemberBase, not MemberCore.
18736 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
18737 accessors, this will also make them work with interface events.
18738 (Indexer): Derive from MemberBase, not MemberCore.
18739 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
18740 (Indexer.Define): Use the new MethodBase functions.
18742 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
18743 argument to the constructor.
18744 (Interface.FindMembers): Added support for interface events.
18745 (Interface.PopluateEvent): Implemented.
18747 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
18749 2002-07-22 Miguel de Icaza <miguel@ximian.com>
18751 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
18752 but this is required to check for a method name being the same as
18753 the containing class.
18757 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18759 * interface.cs: initialize variable.
18761 2002-07-23 Martin Baulig <martin@gnome.org>
18763 Implemented the IndexerName attribute in interfaces.
18765 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
18766 name if this is an explicit interface implementation.
18767 (Indexer.InterfaceIndexerName): New public variable. If we're
18768 implementing an interface indexer, this is the IndexerName in that
18769 interface. Otherwise, it's the IndexerName.
18770 (Indexer.DefineMethod): If we're implementing interface indexer,
18771 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
18772 and Pending.ImplementIndexer methods.
18773 (Indexer.Define): Also define the PropertyBuilder if we're
18774 implementing an interface indexer and this is neither an explicit
18775 interface implementation nor do the IndexerName match the one in
18778 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
18779 If a method is defined here, then we always need to create a proxy
18780 for it. This is used when implementing interface indexers.
18781 (Pending.IsInterfaceIndexer): New public method.
18782 (Pending.ImplementIndexer): New public method.
18783 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
18784 This is used when implementing interface indexers to define a proxy
18786 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
18787 define a proxy if necessary.
18789 * interface.cs (Interface.IndexerName): New public variable.
18790 (Interface.PopulateIndexer): Set the IndexerName.
18791 (Interface.DefineIndexers): New private method. Populate all the
18792 indexers and make sure their IndexerNames match.
18794 * typemanager.cs (IndexerPropertyName): Added support for interface
18797 2002-07-22 Martin Baulig <martin@gnome.org>
18799 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
18800 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
18801 ret if HasReturnLabel.
18802 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
18805 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
18806 and set the ec.LoopBeginTryCatchLevel.
18807 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
18808 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
18809 the current ec.TryCatchLevel, the branch goes out of an exception
18810 block. In this case, we need to use Leave and not Br.
18812 2002-07-22 Martin Baulig <martin@gnome.org>
18814 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
18815 block unless the block does not always return or it is contained in
18816 another try { ... } catch { ... } block. Fixes bug #26506.
18817 Added verify-1.cs to the test suite.
18819 2002-07-22 Martin Baulig <martin@gnome.org>
18821 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
18822 then we do not always return. Fixes bug #24985.
18824 2002-07-22 Martin Baulig <martin@gnome.org>
18826 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
18827 lookup on a per-class level; ie. walk up the class hierarchy until we
18828 found at least one applicable method, then choose the best among them.
18829 Fixes bug #24463 and test-29.cs.
18831 2002-07-22 Martin Baulig <martin@gnome.org>
18833 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
18834 return types of the methods. The return type is not part of the
18835 signature and we must not check it to make the `new' modifier work.
18836 Fixes bug #27999, also added test-147.cs.
18837 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
18839 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
18840 on the method's return type.
18842 2002-07-21 Martin Baulig <martin@gnome.org>
18844 * assign.cs: Make this work if the rightmost source is a constant and
18845 we need to do an implicit type conversion. Also adding a few more tests
18846 to test-38.cs which should have caught this.
18848 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
18849 target in the makefile for this. The makefile.gnu is primarily intended
18850 for end-users who don't want to debug the compiler.
18852 2002-07-21 Martin Baulig <martin@gnome.org>
18854 * assign.cs: Improved the Assign class so it can now handle embedded
18855 assignments (X = Y = Z = something). As a side-effect this'll now also
18856 consume less local variables. test-38.cs now passes with MCS, added
18857 a few new test cases to that test.
18859 2002-07-20 Martin Baulig <martin@gnome.org>
18861 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
18862 instructions. Fixes bug #27977, also added test-146.cs.
18864 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18866 * cs-tokenizer.cs: fixed getHex ().
18868 2002-07-19 Martin Baulig <martin@gnome.org>
18870 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
18871 not Type.GetType() to lookup the array type. This is needed when
18872 we're constructing an array of a user-defined type.
18873 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
18874 single-dimensional arrays, but also for single-dimensial arrays of
18877 2002-07-19 Martin Baulig <martin@gnome.org>
18879 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
18880 this function is called, it's not allowed to share LocalBuilders
18881 among ILGenerators.
18883 2002-07-19 Martin Baulig <martin@gnome.org>
18885 * expression.cs (Argument.Resolve): Report an error 118 when trying
18886 to pass a type as argument.
18888 2002-07-18 Martin Baulig <martin@gnome.org>
18890 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
18891 Conv_R_Un for the signed `long' type.
18893 2002-07-15 Miguel de Icaza <miguel@ximian.com>
18895 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
18896 `expr' for the temporary result, as that will fail if we do
18897 multiple resolves on the same expression.
18899 2002-07-05 Miguel de Icaza <miguel@ximian.com>
18901 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
18902 ec.TypeContainer for looking up aliases.
18904 * class.cs (TypeContainer): Remove LookupAlias from here.
18906 * decl.cs (DeclSpace); Move here.
18908 2002-07-01 Miguel de Icaza <miguel@ximian.com>
18910 * class.cs (FindMembers): Only call filter if the constructor
18911 bulider is not null.
18913 Also handle delegates in `NestedTypes' now. Now we will perform
18914 type lookups using the standard resolution process. This also
18917 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
18918 This uses Expressions (the limited kind that can be parsed by the
18919 tree) instead of strings.
18921 * expression.cs (ComposedCast.ToString): Implement, used to flag
18922 errors since now we have to render expressions.
18924 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
18927 * ecore.cs (SimpleName.ToString): ditto.
18929 * cs-parser.jay: Instead of using strings to assemble types, use
18930 Expressions to assemble the type (using SimpleName, ComposedCast,
18931 MemberAccess). This should fix the type lookups in declarations,
18932 because we were using a different code path for this.
18934 * statement.cs (Block.Resolve): Continue processing statements
18935 even when there is an error.
18937 2002-07-17 Miguel de Icaza <miguel@ximian.com>
18939 * class.cs (Event.Define): Also remove the `remove' method from
18940 the list of pending items.
18942 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
18943 generate more compact code.
18945 2002-07-17 Martin Baulig <martin@gnome.org>
18947 * const.cs (Const.LookupConstantValue): Add support for constant
18948 `unchecked' and `checked' expressions.
18949 Also adding test case test-140.cs for this.
18951 2002-07-17 Martin Baulig <martin@gnome.org>
18953 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
18954 check whether mi.ReturnType implements the IEnumerator interface; the
18955 `==' and the IsAssignableFrom() will fail in this situation.
18957 2002-07-16 Ravi Pratap <ravi@ximian.com>
18959 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
18962 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18964 * expression.cs: fixed bug #27811.
18966 2002-07-14 Miguel de Icaza <miguel@ximian.com>
18968 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
18969 Molaro: when we are a ref, the value already contains a pointer
18970 value, do not take the address of it.
18972 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
18973 * removed mb-parser.jay and mb-tokenizer.cs
18975 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
18977 * expression.cs: check against the building corlib void type.
18979 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
18981 * ecore.cs: fix for valuetype static readonly fields: when
18982 initializing them, we need their address, not the address of a copy.
18984 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
18986 * typemanager.cs: register also enum_type in corlib.
18988 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
18990 * class.cs: allow calling this (but not base) initializers in structs.
18992 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
18994 * ecore.cs: make sure we compare against the building base types
18997 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
18999 * typemanager.cs: fix TypeToCoreType() to handle void and object
19000 (corlib gets no more typerefs after this change).
19002 2002-07-12 Miguel de Icaza <miguel@ximian.com>
19004 * expression.cs (ArrayCreation.EmitArrayArguments): use
19005 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
19007 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
19008 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
19009 array indexes, the runtime actually forbids them.
19011 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
19012 for array arguments here.
19014 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
19015 instead of the default for ValueTypes.
19017 (New.DoEmit): Use IsValueType instead of
19018 IsSubclassOf (value_type)
19019 (New.DoResolve): ditto.
19020 (Invocation.EmitCall): ditto.
19022 * assign.cs (Assign): ditto.
19024 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
19025 Statements *are* currently doing part of their resolution during
19028 Expressions do always resolve during resolve, but statements are
19029 only required to propagate resolution to their children.
19031 2002-07-11 Miguel de Icaza <miguel@ximian.com>
19033 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
19035 (LoadAssembly): Do not add the dll if it is already specified
19037 (MainDriver): Add the System directory to the link path at the end,
19038 after all the other -L arguments.
19040 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
19041 wrong opcode for loading bytes and bools (ldelem.i1 instead of
19042 ldelem.u1) and using the opposite for sbytes.
19044 This fixes Digger, and we can finally run it.
19046 * driver.cs (UnixParseOption): Move the option parsing here.
19047 (CSCParseOption): Implement CSC-like parsing of options.
19049 We now support both modes of operation, the old Unix way, and the
19050 new CSC-like way. This should help those who wanted to make cross
19051 platform makefiles.
19053 The only thing broken is that /r:, /reference: and /lib: are not
19054 implemented, because I want to make those have the same semantics
19055 as the CSC compiler has, and kill once and for all the confussion
19056 around this. Will be doing this tomorrow.
19058 * statement.cs (Unsafe.Resolve): The state is checked during
19059 resolve, not emit, so we have to set the flags for IsUnsfe here.
19061 2002-07-10 Miguel de Icaza <miguel@ximian.com>
19063 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
19064 not catch the Error_ObjectRefRequired in SimpleName (as it is
19065 possible to have a class/instance variable name that later gets
19066 deambiguated), we have to check this here.
19068 2002-07-10 Ravi Pratap <ravi@ximian.com>
19070 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
19071 make static and put into Expression.
19073 (Event.Define): Register the private field of the event with the
19074 TypeManager so that GetFieldFromEvent can get at it.
19076 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
19077 keep track of the private field associated with an event which
19080 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
19083 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
19085 2002-07-10 Miguel de Icaza <miguel@ximian.com>
19087 * expression.cs (Binary.EmitBranchable): this routine emits the
19088 Binary expression in a branchable context. This basically means:
19089 we need to branch somewhere, not just get the value on the stack.
19091 This works together with Statement.EmitBoolExpression.
19093 * statement.cs (Statement.EmitBoolExpression): Use
19096 2002-07-09 Miguel de Icaza <miguel@ximian.com>
19098 * statement.cs (For): Reduce the number of jumps in loops.
19100 (For): Implement loop inversion for the For statement.
19102 (Break): We can be breaking out of a Try/Catch controlled section
19103 (foreach might have an implicit try/catch clause), so we need to
19104 use Leave instead of Br.
19106 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
19107 now). If the instace expression supports IMemoryLocation, we use
19108 the AddressOf method from the IMemoryLocation to extract the
19109 address instead of emitting the instance.
19111 This showed up with `This', as we were emitting the instance
19112 always (Emit) instead of the Address of This. Particularly
19113 interesting when This is a value type, as we dont want the Emit
19114 effect (which was to load the object).
19116 2002-07-08 Miguel de Icaza <miguel@ximian.com>
19118 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
19120 * statement.cs (Checked): Set the CheckedState during the resolve
19121 process too, as the ConvCast operations track the checked state on
19122 the resolve process, and not emit.
19124 * cs-parser.jay (namespace_member_declaration): Flag that we have
19125 found a declaration when we do. This is used to flag error 1529
19127 * driver.cs: Report ok when we display the help only.
19129 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
19131 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
19133 2002-07-04 Miguel de Icaza <miguel@ximian.com>
19135 * cs-tokenizer.cs (define): We also have to track locally the
19136 defines. AllDefines is just used for the Conditional Attribute,
19137 but we also need the local defines for the current source code.
19139 2002-07-03 Miguel de Icaza <miguel@ximian.com>
19141 * statement.cs (While, For, Do): These loops can exit through a
19142 Break statement, use this information to tell whether the
19143 statement is the last piece of code.
19145 (Break): Flag that we break.
19147 * codegen.cs (EmitContexts): New `Breaks' state variable.
19149 2002-07-03 Martin Baulig <martin@gnome.org>
19151 * class.cs (TypeContainer.MethodModifiersValid): Allow override
19152 modifiers in method declarations in structs. Otherwise, you won't
19153 be able to override things like Object.Equals().
19155 2002-07-02 Miguel de Icaza <miguel@ximian.com>
19157 * class.cs (Method, Property, Indexer): Do not allow the public
19158 modifier to be used in explicit interface implementations.
19160 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
19161 override modifiers in method declarations in structs
19163 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
19165 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
19166 integer or real overflow, report an error
19168 2002-07-02 Martin Baulig <martin@gnome.org>
19170 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
19171 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
19172 to tell the runtime about our newly created System.Object and
19173 System.ValueType types.
19175 2002-07-02 Miguel de Icaza <miguel@ximian.com>
19177 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
19178 struct instead of Ldarg/Starg.
19180 2002-07-02 Martin Baulig <martin@gnome.org>
19182 * expression.cs (Indirection.Indirection): Call
19183 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
19185 2002-07-02 Martin Baulig <martin@gnome.org>
19187 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
19188 ValueType, call TypeManager.TypeToCoreType() on it.
19189 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
19190 the OpCodes.Newarr argument.
19192 2002-07-02 Martin Baulig <martin@gnome.org>
19194 * expression.cs (Invocation.EmitCall): When compiling corlib,
19195 replace all calls to the system's System.Array type to calls to
19196 the newly created one.
19198 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
19199 System.Array methods.
19200 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
19201 from the system's System.Array type which must be replaced.
19203 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
19205 * typemanager.cs: load unverifiable_code_ctor so we can build
19206 corlib using the correct type. Avoid using GetTypeCode() with
19208 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
19209 TypeManager.object_type to allow building corlib.
19211 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
19213 * ecore.cs: handle System.Enum separately in LoadFromPtr().
19215 2002-07-01 Martin Baulig <martin@gnome.org>
19217 * class.cs: Make the last change actually work, we need to check
19218 whether `ifaces != null' to avoid a crash.
19220 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
19222 * class.cs: when we build structs without fields that implement
19223 interfaces, we need to add the interfaces separately, since there is
19224 no API to both set the size and add the interfaces at type creation
19227 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
19229 * expression.cs: the dimension arguments to the array constructors
19230 need to be converted if they are a long.
19232 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
19234 * class.cs: don't emit ldarg.0 if there is no parent constructor
19235 (fixes showstopper for corlib).
19237 2002-06-29 Martin Baulig <martin@gnome.org>
19239 MCS now compiles corlib on GNU/Linux :-)
19241 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
19242 ie. check for MethodImplOptions.InternalCall.
19244 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
19245 and TypeManager.attribute_type are null, so we must explicitly check
19246 whether parent is not null to find out whether it's an attribute type.
19247 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
19248 and SetBuilder, not only if the property is neither abstract nor external.
19249 This is necessary to set the MethodImplOptions on the accessor methods.
19250 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
19251 SetBuilder, see Property.Emit().
19253 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
19254 populate "System.Object", "System.ValueType" and "System.Attribute" since
19255 they've already been populated from BootCorlib_PopulateCoreTypes().
19257 2002-06-29 Martin Baulig <martin@gnome.org>
19259 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
19260 is the NullLiteral, we also need to make sure that target_type is not
19263 2002-06-29 Martin Baulig <martin@gnome.org>
19265 * rootcontext.cs (RootContext.ResolveCore): We must initialize
19266 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
19267 before calling BootstrapCorlib_ResolveDelegate ().
19269 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19271 * statement.cs: fixed build-breaker. All tests passed ok.
19273 2002-06-27 Martin Baulig <martin@gnome.org>
19275 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
19276 for System.Decimal when compiling corlib.
19278 2002-06-27 Martin Baulig <martin@gnome.org>
19280 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
19281 switch blocks which contain nothing but a default clause.
19283 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
19285 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
19287 2002-06-27 Martin Baulig <martin@gnome.org>
19289 * ecore.cs (PropertyExpr.PropertyExpr): Call
19290 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
19292 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
19293 is already a TypeBuilder.
19295 2002-06-27 Martin Baulig <martin@gnome.org>
19297 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
19298 `target_type == TypeManager.array_type', not IsAssignableFrom() in
19299 the "from an array-type to System.Array" case. This makes it work
19300 when compiling corlib.
19302 2002-06-27 Martin Baulig <martin@gnome.org>
19304 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
19305 non-static PropertyExpr, set its InstanceExpression. This makes
19306 the `ICollection.Count' property work in System/Array.cs.
19308 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
19310 * driver.cs: Made error handling more consistent. Errors now
19311 tracked by Report class, so many methods which used to return int
19312 now return void. Main() now prints success/failure and
19313 errors/warnings message.
19315 Renamed '--probe' compiler argument to '--expect-error'. Removed
19316 the magic number return values (123 and 124). Now, if the
19317 expected error occurs, the compiler exits with success (exit value
19318 0). If the compilation completes without seeing that particular
19319 error, the compiler exits with failure (exit value 1). The
19320 makefile in mcs/errors has been changed to handle the new behaviour.
19322 * report.cs: Made 'expected error' number a property and renamed
19323 it from 'Probe' to 'ExpectedError'.
19325 * genericparser.cs: Removed error handling support, since it is
19326 now all done by Report class.
19328 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
19329 class, so parse() no longer returns an int.
19331 * namespace.cs: Use Report.Error instead of GenericParser.error
19333 2002-06-22 Miguel de Icaza <miguel@ximian.com>
19335 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
19336 TypeContainer.AddOperator): At the front of the list put the
19337 explicit implementations, so they get resolved/defined first.
19339 2002-06-21 Miguel de Icaza <miguel@ximian.com>
19341 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
19342 interface type is implemented by this TypeContainer. Used during
19343 explicit interface implementation.
19345 (Property.Define, Indexer.Define, Method.Define): Validate that
19346 the given interface in the explicit implementation is one of the
19347 base classes for the containing type.
19349 Also if we are explicitly implementing an interface, but there is
19350 no match in the pending implementation table, report an error.
19352 (Property.Define): Only define the property if we are
19353 not explicitly implementing a property from an interface. Use the
19354 correct name also for those properties (the same CSC uses,
19355 although that is really not needed).
19357 (Property.Emit): Do not emit attributes for explicitly implemented
19358 properties, as there is no TypeBuilder.
19360 (Indexer.Emit): ditto.
19362 Hiding then means that we do not really *implement* a pending
19363 implementation, which makes code fail.
19365 2002-06-22 Martin Baulig <martin@gnome.org>
19367 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
19368 the return value of Object.GetType(). [FIXME: we need to do this whenever
19369 we get a type back from the reflection library].
19371 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
19373 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
19375 2002-06-20 Miguel de Icaza <miguel@ximian.com>
19377 * attribute.cs: Return null if we can not look up the type.
19379 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
19380 the interface types found.
19382 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
19383 interface types found.
19385 * typemanager.cs (GetInterfaces): Make this routine returns alll
19386 the interfaces and work around the lame differences between
19387 System.Type and System.Reflection.Emit.TypeBuilder in the results
19388 result for GetInterfaces.
19390 (ExpandInterfaces): Given an array of interface types, expand and
19391 eliminate repeated ocurrences of an interface. This expands in
19392 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
19395 2002-06-21 Martin Baulig <martin@gnome.org>
19397 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
19400 2002-06-21 Martin Baulig <martin@gnome.org>
19402 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
19403 and called with one of the core types, return the corresponding typebuilder for
19406 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
19409 2002-06-21 Martin Baulig <martin@gnome.org>
19411 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
19412 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
19413 (Expression.ConvertReferenceExplicit): Likewise.
19415 * expression.cs (ElementAccess.DoResolve): Likewise.
19416 (ElementAccess.DoResolveLValue): Likewise.
19418 2002-06-10 Martin Baulig <martin@gnome.org>
19420 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
19421 add the "value" parameter to the parameter list.
19423 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
19426 2002-06-19 Miguel de Icaza <miguel@ximian.com>
19428 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
19429 the argument to an int, uint, long or ulong, per the spec. Also
19430 catch negative constants in array creation.
19432 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
19434 * class.cs: do not allow the same interface to appear twice in
19435 the definition list.
19437 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
19439 * ecore.cs: don't use ldlen with System.Array.
19441 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
19443 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
19445 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
19447 * modifiers.cs: produce correct field attributes for protected
19448 internal. Easy fix so miguel can work on ther harder stuff:-)
19450 2002-06-18 Miguel de Icaza <miguel@ximian.com>
19452 * pending.cs: New file. Move the code from class.cs here.
19453 Support clearning the pending flag for all methods (when not doing
19454 explicit interface implementation).
19456 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
19458 * rootcontext.cs: added a couple more types needed to bootstrap.
19460 2002-06-17 Miguel de Icaza <miguel@ximian.com>
19462 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
19463 constructor in the type, instead of any constructor in the type
19464 hierarchy. Thanks to Paolo for finding this bug (it showed up as
19465 a bug in the Mono runtime when applying the params attribute).
19467 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
19468 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
19470 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
19472 * expression.cs (Unary.ResolveOperator): Use TypeManager
19473 to resolve the type.
19475 2002-06-13 Ravi Pratap <ravi@ximian.com>
19477 * cs-parser.jay (enum_member_declaration): Pass in the attributes
19480 * enum.cs (AddEnumMember): Add support to store the attributes associated
19481 with each member too.
19483 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
19484 field builders too - this takes care of the enum member case.
19486 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
19488 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
19489 address-of operator on both value types and pointers.
19491 2002-06-10 Martin Baulig <martin@gnome.org>
19493 * interface.cs (Interface.PopulateIndexer): Add the indexer's
19494 PropertyBuilder to the `property_builders' list.
19496 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
19497 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
19498 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
19499 find any indexers which are inherited from an interface.
19501 2002-06-09 Martin Baulig <martin@gnome.org>
19503 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
19504 the same type as the constant if necessary. There's also a test-130.cs
19507 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
19509 * typemanager.cs (TypeManager.ChangeType): Previously known as
19510 Enum.ChangeEnumType().
19512 2002-06-09 Martin Baulig <martin@gnome.org>
19514 * expression.cs (Cast.TryReduce): Added support for consts.
19516 2002-06-08 Ravi Pratap <ravi@ximian.com>
19518 * class.cs (Accessor): Hold attributes information so we can pass
19521 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
19522 Modify to pass in attributes attached to the methods.
19524 (add_accessor_declaration, remove_accessor_declaration): Ditto.
19526 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
19527 to handle the Accessor kind :-)
19529 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
19531 2002-06-08 Martin Baulig <martin@gnome.org>
19533 * expression.cs (Unary.TryReduceNegative): Added support for
19536 2002-06-08 Martin Baulig <martin@gnome.org>
19538 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
19539 name can't be found in the `defined_names' - the caller will do a
19540 MemberLookup in this case and thus find methods in System.Enum
19541 such as Enum.IsDefined().
19543 2002-06-08 Martin Baulig <martin@gnome.org>
19545 * enum.cs (Enum.ChangeEnumType): This is a custom version of
19546 Convert.ChangeType() which works with TypeBuilder created types.
19547 (Enum.LookupEnumValue, Enum.Define): Use it here.
19549 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
19550 `TypeBuilder.BaseType != null' check.
19551 (TypeContainer.FindMembers): Only lookup parent members if we
19552 actually have a parent.
19553 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
19554 (ConstructorInitializer.Resolve): Likewise.
19556 * interface.cs (Interface.FindMembers): Added
19557 `TypeBuilder.BaseType != null' check.
19559 * rootcontext.cs (RootContext.ResolveCore): Added
19560 "System.Runtime.CompilerServices.IndexerNameAttribute" to
19561 classes_second_stage.
19563 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
19564 debug_type and trace_type when compiling with --nostdlib.
19566 2002-06-07 Martin Baulig <martin@gnome.org>
19568 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
19569 (AddField): Set it to true when adding a non-static field.
19570 (DefineType): Use `have_nonstatic_fields' to find out whether we
19571 have non-static fields, not `Fields != null'.
19573 2002-06-02 Miguel de Icaza <miguel@ximian.com>
19575 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
19576 dereferencing a null on the static-field code path)
19578 2002-05-30 Martin Baulig <martin@gnome.org>
19580 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
19581 to take command line arguments. Use reflection to call the new
19582 custom `Initialize' function on the symbol writer and pass it the
19583 command line arguments.
19585 * driver.cs (--debug-args): New command line argument to pass command
19586 line arguments to the symbol writer.
19588 2002-05-28 Miguel de Icaza <miguel@ximian.com>
19590 * assign.cs (DoResolve): Forgot to do the implicit conversion to
19591 the target type for indexers and properties. Thanks to Joe for
19594 2002-05-27 Miguel de Icaza <miguel@ximian.com>
19596 * typemanager.cs (MethodFlags): returns the method flags
19597 (Obsolete/ShouldIgnore) that control warning emission and whether
19598 the invocation should be made, or ignored.
19600 * expression.cs (Invocation.Emit): Remove previous hack, we should
19601 not do this on matching a base type, we should do this based on an attribute
19603 Only emit calls to System.Diagnostics.Debug and
19604 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
19605 on the command line.
19607 * rootcontext.cs: Global settings for tracing and debugging.
19609 * cs-tokenizer.cs (define): New utility function to track
19610 defines. Set the global settings for TRACE and DEBUG if found.
19612 2002-05-25 Ravi Pratap <ravi@ximian.com>
19614 * interface.cs (Populate*): Pass in the TypeContainer as well as
19615 the DeclSpace as parameters so that we can create EmitContexts and
19616 then use that to apply attributes etc.
19618 (PopulateMethod, PopulateEvent, PopulateProperty)
19619 (PopulateIndexer): Apply attributes everywhere.
19621 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
19624 (ApplyAttributes): Update accordingly.
19626 We now apply interface attributes for all members too.
19628 2002-05-26 Miguel de Icaza <miguel@ximian.com>
19630 * class.cs (Indexer.Define); Correctly check if we are explicit
19631 implementation (instead of checking the Name for a ".", we
19632 directly look up if the InterfaceType was specified).
19634 Delay the creation of the PropertyBuilder.
19636 Only create the PropertyBuilder if we are not an explicit
19637 interface implementation. This means that explicit interface
19638 implementation members do not participate in regular function
19639 lookups, and hence fixes another major ambiguity problem in
19640 overload resolution (that was the visible effect).
19642 (DefineMethod): Return whether we are doing an interface
19645 * typemanager.cs: Temporary hack until we get attributes in
19646 interfaces (Ravi is working on that) and we get IndexerName
19647 support in interfaces.
19649 * interface.cs: Register the indexers as properties.
19651 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
19652 warning, I have verified that this is a bug in the .NET runtime
19653 (JavaScript suffers of the same problem).
19655 * typemanager.cs (MemberLookup): When looking up members for
19656 interfaces, the parent of an interface is the implicit
19657 System.Object (so we succeed in searches of Object methods in an
19658 interface method invocation. Example: IEnumerable x; x.ToString
19661 2002-05-25 Miguel de Icaza <miguel@ximian.com>
19663 * class.cs (Event): Events should also register if they do
19664 implement the methods that an interface requires.
19666 * typemanager.cs (MemberLookup); use the new GetInterfaces
19669 (GetInterfaces): The code used to lookup interfaces for a type is
19670 used in more than one place, factor it here.
19672 * driver.cs: Track the errors at the bottom of the file, we kept
19675 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
19676 instance if the method we are calling is static!
19678 2002-05-24 Miguel de Icaza <miguel@ximian.com>
19680 * attribute.cs (ApplyAttributes): Make this function filter out
19681 the IndexerName attribute (as that attribute in reality is never
19682 applied) and return the string constant for the IndexerName
19685 * class.cs (TypeContainer.Emit): Validate that all the indexers
19686 have the same IndexerName attribute, and if so, set the
19687 DefaultName attribute on the class.
19689 * typemanager.cs: The return value might contain other stuff (not
19690 only methods). For instance, consider a method with an "Item"
19691 property and an Item method.
19693 * class.cs: If there is a problem with the parameter types,
19696 2002-05-24 Ravi Pratap <ravi@ximian.com>
19698 * ecore.cs (ImplicitConversionExists): Wrapper function which also
19699 looks at user defined conversion after making a call to
19700 StandardConversionExists - we need this for overload resolution.
19702 * expression.cs : Update accordingly the various method calls.
19704 This fixes 2 bugs filed against implicit user defined conversions
19706 2002-05-22 Miguel de Icaza <miguel@ximian.com>
19708 * statement.cs: Track the result of the assignment.
19710 2002-05-21 Miguel de Icaza <miguel@ximian.com>
19712 * expression.cs (MemberAccess): Improved error reporting for
19713 inaccessible members.
19715 2002-05-22 Martin Baulig <martin@gnome.org>
19717 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
19718 itself with debugging support.
19720 2002-05-22 Martin Baulig <martin@gnome.org>
19722 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
19723 Removed, this isn't needed anymore.
19725 2002-05-20 Martin Baulig <martin@gnome.org>
19727 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
19728 be underlying type for an enum.
19730 2002-05-20 Miguel de Icaza <miguel@ximian.com>
19732 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
19733 that splits out the loading of just the core types.
19735 * rootcontext.cs (ResolveCore): Split the struct resolution in
19736 two, so we can load the enumeration underlying types before any
19739 * expression.cs (Is): Bandaid until we fix properly Switch (see
19740 bug #24985 for details).
19742 * typemanager.cs (ImplementsInterface): The hashtable will contain
19743 a null if there are no interfaces implemented.
19745 2002-05-18 Miguel de Icaza <miguel@ximian.com>
19747 * cs-parser.jay (indexer_declarator): It is fine to have array
19750 2002-05-17 Miguel de Icaza <miguel@ximian.com>
19752 * typemanager.cs: (RegisterBuilder): New function used to register
19753 TypeBuilders that implement interfaces. Since
19754 TypeBuilder.GetInterfaces (as usual) does not work with lame
19756 (AddUserType): register interfaces.
19758 (ImplementsInterface): Use the builder_to_ifaces hash if we are
19759 dealing with TypeBuilder. Also, arrays are showing up as
19760 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
19761 methods can not be invoked on them!
19763 * ecore.cs (ExplicitReferenceConversionExists): Made public.
19764 (ImplicitReferenceConversionExists): Split out from
19765 StandardConversionExists.
19767 * expression.cs (As): We were only implementing one of the three
19768 cases for the as operator. We now implement them all.
19769 (Is): Implement the various other cases for Is as well.
19771 * typemanager.cs (CACHE): New define used to control if we want or
19772 not the FindMembers cache. Seems to have a negative impact on
19773 performance currently
19775 (MemberLookup): Nested types have full acess to
19776 enclosing type members
19778 Remove code that coped with instance/static returns for events, we
19779 now catch this in RealFindMembers.
19781 (RealFindMembers): only perform static lookup if the instance
19782 lookup did not return a type or an event.
19784 2002-05-17 Miguel de Icaza <miguel@ximian.com>
19786 * assign.cs (CompoundAssign): We pass more semantic information
19787 now to Compound Assignments than we did before: now we have all
19788 the information at hand, and now we resolve the target *before* we
19789 do the expression expansion, which allows the "CacheValue" method
19790 to have the effect we intended (before, a [x] += 1 would generate
19791 two differen ArrayAccess expressions from the ElementAccess,
19792 during the resolution process).
19794 (CompoundAssign.DoResolve): Resolve target and original_source here.
19796 2002-05-16 Miguel de Icaza <miguel@ximian.com>
19798 * expression.cs (ArrayAccess): dropped debugging information.
19800 * typemanager.cs: Small bug fix: I was always returning i_members,
19801 instead of one of i_members or s_members (depending on which had
19804 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
19805 method is invoked before any code generation takes place, and it
19806 is a mechanism to inform that the expression will be invoked more
19807 than once, and that the method should use temporary values to
19808 avoid having side effects
19810 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
19812 * ecore.cs (Expression.CacheTemporaries): Provide empty default
19815 * expression.cs (Indirection, ArrayAccess): Add support for
19816 CacheTemporaries in these two bad boys.
19818 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
19819 ldobj or ldind_ref.
19820 (StoreFromPtr): Handle stobj as well.
19822 * expression.cs (UnaryMutator): Share more code.
19824 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
19825 down: I was not tracking the Filter function as well, which
19826 was affecting the results of the cache.
19828 2002-05-15 Miguel de Icaza <miguel@ximian.com>
19830 * attribute.cs: Remove the hack to handle the CharSet property on
19833 2002-05-14 Miguel de Icaza <miguel@ximian.com>
19835 * attribute.cs (DoResolve): More uglyness, we now only try to
19836 resolve the attribute partially, to extract the CharSet
19837 information (only if we are a StructLayout attribute). Otherwise
19839 (GetExtraTypeInfo): Add some code to conditionally kill in the
19840 future this. I am more and more convinced that the .NET
19841 framework has special code to handle the attribute setting on
19844 * expression.cs (IsParamsMethodApplicable): Revert my previous
19845 foreach change here, it was wrong.
19847 2002-05-13 Miguel de Icaza <miguel@ximian.com>
19849 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
19850 (pp_expr): do not abort on unknown input, just return.
19851 (eval): abort if there are pending chars.
19853 * attribute.cs (Attribute.Resolve): Positional parameters are
19854 optional. Deal with that case.
19856 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
19857 the Ansi/Unicode/Auto information for the type.
19859 (TypeContainer.DefineType): instantiate the EmitContext here, as
19860 we will be using it during the type definition (to resolve
19861 attributes) and during the emit phase.
19863 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
19864 to pull type information out of the attributes
19866 (Attribute.Resolve): track the constructor builder, and allow for
19867 multiple invocations (structs and classes will use this).
19869 * ecore.cs (MemberLookupFinal): new version with all the
19870 parameters customizable.
19872 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
19873 constructors. Return if the result value is null (as the error
19874 would have been flagged already by MemberLookupFinal)
19876 Do not allow instances of abstract classes or interfaces to be
19879 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
19880 We have to compare the assembly property here when dealing with
19881 FamANDAssem and Assembly access modifiers, because we might be
19882 creating an assembly from *modules* (that means that we are not
19883 getting TypeBuilders for types defined in other modules that are
19884 part of this assembly).
19886 (Method.Emit): If the method is marked abstract and has a body,
19889 (TypeContainer.DefineMembers): If both the defined member and the
19890 parent name match are methods, then do not emit any warnings: let
19891 the Method.Define routine take care of flagging warnings. But if
19892 there is a mismatch (method overrides something else, or method is
19893 overriwritten by something, then emit warning).
19895 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
19896 set to null, this means `do not check for the return type on the
19899 (Method.Define): set the return type for the method signature to
19900 null, so that we get methods with the same name and parameters and
19901 different return types. This is used to flag warning 114 (you are
19902 hiding a method, and you probably want to use the new/override
19905 * typemanager.cs (MemberLookup): Implemented proper access
19906 control, closing a long standing set of bug reports. The problem
19907 was that the Framework only has two bits: Public and NonPublic,
19908 and NonPublic includes private and protected methods, but we need
19909 to enforce the FamANDAssem, FamOrAssem and Family.
19911 2002-05-11 Miguel de Icaza <miguel@ximian.com>
19913 * statement.cs (GotoCase): Return true: Ammounts to giving up
19914 knowledge on whether we return or not, and letting the other case
19915 be responsible for it.
19917 2002-05-10 Miguel de Icaza <miguel@ximian.com>
19919 * driver.cs: Do not load directories for each file processed, only
19920 do it if there is a pattern.
19922 * ecore.cs: Report readonly assigns here as well, as we might have
19923 been resolved only by MemberAccess.
19925 (SimpleName.SimpleNameResolve): Also be useful for LValue
19926 resolution. We need this to propagate assign to local readonly variables
19928 * typemanager.cs: Use a ptrhashtable for the criteria, because we
19929 do not want to reuse potential criteria memory.
19931 * class.cs (MyEventBuilder): Set reflected_type;
19933 * ecore.cs (Constantify): Added support for constifying bools.
19935 (RootContext.LookupType): Added a cache for values looked up in
19936 the declaration space.
19938 * typemanager.cs (FindMembers): Now is a front-end to
19939 RealFindMembers, and provides a two-level hashtable-based cache to
19942 15% performance improvement: from 22.5 to 19.2 seconds.
19944 * expression.cs (IsParamsMethodApplicable): use foreach.
19945 (Invocation.DoResolve): ditto.
19946 (New.DoResolve): ditto.
19947 (ArrayCreation.DoResolve): ditto.
19949 * ecore.cs (FindMostEncompassingType): use foreach.
19951 * delegate.cs (NewDelegate.DoResolve): Use foreach
19953 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
19954 (RemoveMethods): use foreach.
19956 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
19957 nested foreach statements instead of for, and also break out of
19958 the inner loop once a match is found.
19960 (Invocation.OverloadResolve): Use foreach, simplify the code.
19962 2002-05-08 Miguel de Icaza <miguel@ximian.com>
19964 * cfold.cs (BinaryFold): During an enumeration evaluation context,
19965 we actually unwrap the expression to allow for extra information
19968 * expression.cs: Use Shr_Un on unsigned operations.
19970 2002-05-08 Ravi Pratap <ravi@ximian.com>
19972 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
19973 applicable operators was not being considered correctly. This closes
19974 the bug Miguel reported.
19976 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
19978 * attribute.cs: check that the type derives from System.Attribute
19979 and report the correct error in that case (moved the duplicate code to
19980 its own method, too).
19982 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
19984 * attribute.cs: lookup attribute type name as the spec says: first the
19985 bare attribute name and then name + "Attribute" (nant compiles with
19986 mcs after this fix).
19988 2002-05-07 Miguel de Icaza <miguel@ximian.com>
19990 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
19991 Because of the way we parse things, we should try to see if a
19992 UIntConstant can fit in an integer.
19994 2002-05-07 Ravi Pratap <ravi@ximian.com>
19996 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
19997 when we are in an explicit context.
19999 (ConvertReferenceExplicit): When converting from Iface type S to Class
20000 T make sure the rules are implemented as an OR.
20002 * parameter.cs (ParameterType): Make it a property for now although the
20003 purpose really isn't anything immediate.
20005 * expression.cs (Is*Applicable): Do better checking on the parameter type
20006 of a ref/out parameter. The ones from the system assemblies are already
20007 marked with the correct type so we don't need to do any correction.
20009 * ecore.cs (StandardConversionExists): Conversion from Interface types to
20010 the object type is standard too so include that.
20012 2002-05-06 Miguel de Icaza <miguel@ximian.com>
20014 * ecore.cs (StandardConversionExists): Augment with missing code:
20015 deal with IntConstant, LongConstants and Enumerations.
20017 * assign.cs: Report the error, instead of failing silently
20019 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
20020 typecontainer that they are declared, because the
20021 typecontainer/namespace will have the list of using clauses that
20022 need to be applied.
20024 Assembly Attributes were escaping the normal registration
20027 (EmitCode): Apply attributes within an EmitContext that represents
20028 the container they were declared on.
20030 * cs-parser.jay: Track bases for structs. How did I get this wrong?
20032 2002-05-06 Ravi Pratap <ravi@ximian.com>
20034 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
20035 Revamp completely - make much cleaner as we now operate only
20038 (FindMostSpecificSource, FindMostSpecificTarget): New methods
20039 to implement the logic detailed in the spec more correctly.
20041 (UserDefinedConversion): Update accordingly.
20043 2002-05-06 Miguel de Icaza <miguel@ximian.com>
20045 * statement.cs: Return flow analysis information up.
20047 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
20050 (token): Do not consume an extra character before calling
20053 2002-05-06 Piers Haken <piersh@friskit.com>
20055 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
20057 2002-05-06 Miguel de Icaza <miguel@ximian.com>
20059 * class.cs (Constructor.Emit): Set the IsStatic flag in the
20060 EmitContext during the instance constructor initializer
20061 resolution, to stop access to instance variables.
20063 This is mandated by the spec, last paragraph of the `constructor
20064 initializers' section.
20066 2002-05-05 Miguel de Icaza <miguel@ximian.com>
20068 * cs-parser.jay, class.cs (Accessor): new class used to represent
20069 an accessor (get or set). In the past we used `null' to represent
20070 a missing accessor. But this is ambiguous because there was no
20071 way to tell in abstract indexers/properties if one of them was
20074 Now there is a way of addressing that.
20076 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
20077 instead of FindMembers.
20079 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
20080 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
20082 * attribute.cs: Treat indexers and properties as the same in terms
20083 of applying attributes
20085 * ecore.cs (FindMostEncompassedType): Use statically initialized
20086 EmptyExpressions()s like we do elsewhere to avoid creating useless
20087 objects (and we take this out of the tight loop).
20089 (GetConversionOperators): Move the code to extract the actual
20090 operators to a separate routine to clean things up.
20092 2002-05-04 Miguel de Icaza <miguel@ximian.com>
20094 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
20095 events are always registered FieldBuilders.
20097 * class.cs (FieldBase): New class shared by Fields
20099 * delegate.cs: If we are a toplevel delegate, use our full name.
20100 If we are a nested delegate, then only use our tail name.
20102 2002-05-02 Ravi Pratap <ravi@ximian.com>
20104 * expression.cs (IsApplicable): Ensure that we add the "&" to
20105 ref/out types before comparing it with the type of the argument.
20107 (IsParamsMethodApplicable): Ditto.
20109 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
20112 * delegate.cs : Handle the case when we have more than one applicable
20113 method. Flag an error only when we finish checking all.
20115 2002-05-02 Miguel de Icaza <miguel@ximian.com>
20117 * expression.cs: Add support for boolean static initializers.
20119 2002-05-01 Miguel de Icaza <miguel@ximian.com>
20121 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
20123 * parameter.cs (ComputeParameterTypes,
20124 ComputeAndDefineParameterTypes): Better error handling: now we
20125 clear the `types' cache if we fail during any of the type lookups.
20126 We also return the status code correctly to our caller
20128 * delegate.cs: If we fail to define a delegate, abort the extra
20131 * expression.cs (Binary.ResolveOperator): for
20132 operator==(object,object) and operator !=(object, object) we also
20133 have to verify that there is an implicit conversion from one to
20136 (ArrayAccess.DoResolve): Array Access can operate on
20139 2002-04-30 Miguel de Icaza <miguel@ximian.com>
20141 * assign.cs (CompoundAssign): A new class used as a "flag" that
20142 the assignment actually is happening as part of a compound
20143 assignment operator.
20145 During compound assignment, a few new rules exist to enable things
20152 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
20153 to the type of x) if y is implicitly convertible to the type of x,
20154 and the operator is a builtin operator and the return type of the
20155 operator is explicitly convertible to the type of x.
20157 * rootcontext.cs: Reset warning level to 2. 4 catches various
20158 "interesting" features in mcs, we must clean this up at some
20159 point, but currently am trying to kill other bugs ;-)
20161 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
20162 in container classes as well.
20164 * expression.cs (Binary.ResolveOperator): Handle string case
20165 before anything else (as operator overloading does emit an error
20166 before doing anything else).
20168 This code could go away when we move to a table driven model, but
20169 i could not come up with a good plan last night.
20171 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
20173 * typemanager.cs (CSharpName): reimplementation using regex.
20174 * class.cs: added null check for fields in Emit
20175 * rootcontext.cs: set warninglevel to 4
20177 2002-04-29 Miguel de Icaza <miguel@ximian.com>
20179 * typemanager.cs (CSharpName): reimplemented with Lupus
20182 2002-04-28 Miguel de Icaza <miguel@ximian.com>
20184 * statement.cs (If): correclty implement Resolve, because we were
20185 not catching sem errors in there. The same process is needed
20187 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
20190 (Statement.Warning_DeadCodeFound): Factorize code.
20191 (While): Report dead code here too.
20193 (Statement): Added Resolve virtual method to allow
20194 for resolution split from the emit code.
20196 2002-04-26 Miguel de Icaza <miguel@ximian.com>
20198 * statement.cs (EmitBoolExpression): No longer try to resolve the
20200 (MakeBoolean): New utility function that resolve, implicitly
20201 converts to boolean and tags the expression.
20204 (If, Do): Implement dead code elimination.
20205 (While): Implement loop inversion
20207 (Do, While, For, If): Resolve the expression prior to calling our
20210 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
20213 - added method Report28 (warning: program has more than one entry point)
20214 - added method IsEntryPoint, implements paragraph 10.1 of the spec
20215 - modified method Method.Define, the part at the end of the method
20217 * rootcontext.cs: added static public Location EntryPointLocation;
20219 * ../errors/cs0028.cs : Add test case for the above warning.
20222 - modified method CSharpName to allow arrays of primitive type to
20223 be printed nicely (e.g. instead of System.Int32[][] it now prints
20225 - added method CSharpSignature: returns the signature of a method
20226 in string format to be used in reporting errors, warnings, etc.
20228 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
20231 2002-04-26 Ravi Pratap <ravi@ximian.com>
20233 * delegate.cs (Define): Fix extremely silly bug where I was
20234 setting the type of the 'object' parameter of the BeginInvoke
20235 method to System.IAsyncResult instead of System.Object ;-)
20237 2002-04-26 Miguel de Icaza <miguel@ximian.com>
20239 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
20242 (Constructor.Emit): return if we fail to initialize the
20243 constructor. Another door closed!
20245 * expression.cs (New.DoResolve): Improve error message (from -6 to
20246 1501). Use DeclaredOnly lookup to find the exact constructor.
20248 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
20249 loop. This is useful.
20251 * cs-parser.jay: Adjust the default parameters so that destructors
20252 have the proper signature.
20254 2002-04-26 Martin Baulig <martin@gnome.org>
20256 * driver.cs (LoadAssembly): If `assembly' contains any characters
20257 which are only valid in path names and not in assembly names
20258 (currently slash, backslash and point), use Assembly.LoadFrom ()
20259 instead of Assembly.Load () on the `assembly' (before iteration
20260 over the link_paths).
20262 2002-04-26 Martin Baulig <martin@gnome.org>
20264 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
20266 2002-04-25 Miguel de Icaza <miguel@ximian.com>
20268 * class.cs (Property): use the new typemanager.MemberLookup
20270 (TypeContainer.MemberLookup): Implement using the
20271 TypeManager.MemberLookup now.
20273 * typemanager.cs: Make MemberLookup a function of the TypeManager,
20274 and return MemberInfos, so that these can be used without an
20275 EmitContext (what we had before).
20277 2002-04-24 Miguel de Icaza <miguel@ximian.com>
20279 * expression.cs: Fix the case where the argument to params if the
20280 type of the params. I omitted handling this before. Fixed
20282 2002-04-22 Miguel de Icaza <miguel@ximian.com>
20284 * driver.cs: Call BootCorlib_PopulateCoreType
20286 * class.cs (Property.CheckBase): Check for properties only, not
20289 * interface.cs: Temporary hack: try/catch around the
20290 CustomAttributeBuilder, because I am getting an exception that I
20293 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
20294 types whose definitions are required to be there (attributes are
20295 defined before standard types).
20297 Compute definitions as we boot the various types, as they are used
20298 immediately (value_type class will need object_type, but if we do
20299 not initialize object_type, we will pass a null, which will let
20300 the runtime pick the System.Object from the existing corlib, which
20301 is not what we want).
20303 2002-04-22 Patrik Torstensson <totte@labs2.com>
20305 * cs-tokenizer.cs: fixed a number of trim() issues.
20307 2002-04-22 Ravi Pratap <ravi@ximian.com>
20309 * expression.cs (Argument.Type): Ensure that we return the correct
20310 type when we have out or ref parameters [in which case we
20313 2002-04-22 Miguel de Icaza <miguel@ximian.com>
20315 * class.cs (Property, Indexer): Allow extern modifier in there.
20317 * typemanager.cs (InitBaseTypes): Initializes object_type and
20318 value_type, since those will be used early on during the bootstrap
20319 process to compile corlib.
20321 (InitCoreTypes): Move code from here to InitBaseTypes.
20323 2002-04-21 Miguel de Icaza <miguel@ximian.com>
20325 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
20326 single-dimension arrays as using the ldlen opcode.
20328 Daniel Lewis discovered this optimization.
20330 * typemanager.cs: Add signature for System.Array::get_Length
20332 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20334 * statement.cs: report the error when the foreach does not apply to an
20335 array nor a collection.
20337 2002-04-19 Miguel de Icaza <miguel@ximian.com>
20339 * expression.cs: Add implicit conversions to the operator ~.
20341 * constant.cs (DecimalConstant.Emit): Emit decimal value.
20343 * typemanager.cs: Locate the decimal constructor.
20345 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20347 * attribute.cs: use the new property of TypeOf.
20348 * expression.cs: added 'get' property around typearg.
20350 These changes fix a build breaker reported by NickD. Is this the
20351 correct way to fix? If not, please, revert my changes and make it
20354 2002-04-17 Miguel de Icaza <miguel@ximian.com>
20356 * attribute.cs: Add support for typeof in attribute invocations.
20357 I am not sure that this is right though.
20359 2002-04-14 Duncan Mak <duncan@ximian.com>
20361 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
20362 Binary.Operator.Division case.
20364 2002-04-13 Ravi Pratap <ravi@ximian.com>
20366 * class.cs (DefineType): Ensure that we do a proper check on
20367 attribute types and also register it with the TypeManager.
20369 (TypeContainer.Targets): The default for attribute types is
20370 AttributeTargets.All.
20372 * attribute.cs (ApplyAttributes): Registering the attribute type
20373 is done elsewhere, not when we discover we have a Usage attribute.
20375 2002-04-12 Ravi Pratap <ravi@ximian.com>
20377 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
20378 and get rid of is_delegate parameter.
20380 * everywhere : update.
20382 2002-04-12 Ravi Pratap <ravi@ximian.com>
20384 * cs-parser.jay (compilation_unit): Revamp completely to use
20385 some new ideas that I got from Rhys' grammar to solve the problems
20386 with assembly level attributes.
20388 (outer_declaration): New grammar production.
20390 (attribute_sections): Add.
20392 (opt_attributes): Base on attribute_sections
20394 (namespace_declaration): Allow opt_attributes to tackle the case
20395 when we have assembly level attributes - we are clever in this
20398 * attribute.cs (ApplyAttributes): Do not worry about assembly
20399 attributes in the non-global context.
20401 * rootcontext.cs (AddGlobalAttributes): Go back to using this
20402 instead of SetGlobalAttributes.
20404 * class.cs, rootcontext.cs : Ensure we define and generate
20405 attribute types before anything else.
20407 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
20408 and flag the new error -20 for the case when the attribute type
20409 does not have valid targets specified. csc does not catch this.
20411 * ../errors/errors.txt : update for error # -20
20413 2002-04-11 Ravi Pratap <ravi@ximian.com>
20415 * support.cs (InternalParameters.ParameterModifier): Do some null
20416 checking and return sane values.
20418 * class.cs (Method.Define): If we are a PInvoke method, ensure
20419 that we are static and extern. Report error # 601
20421 * ../errors/cs0601.cs : Add test case for the above error.
20423 2002-04-07 Ravi Pratap <ravi@ximian.com>
20425 * rootcontext.cs (attribute_types): We need to keep type of
20426 all attribute types separately and emit code for them first.
20428 (RegisterAttribute) : Implement.
20430 * class.cs (DefineType): Check if the current Type is a custom
20431 attribute type and register it accordingly.
20433 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
20434 adding the first attribute twice and rename to
20436 (SetGlobalAttributes): this.
20438 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
20441 * attribute.cs (ApplyAttributes): Take an additional argument telling us
20442 if we are processing global arguments. Hmm, I am unsure of this.
20444 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20446 * expression.cs: added static array of strings to avoid calling
20447 Enum.ToString () for Operator in Binary. Significant recover of
20450 2002-04-10 Miguel de Icaza <miguel@ximian.com>
20452 * class.cs (FindMembers): Allow the Builders of the various
20453 members to be null. If they are skip them. This only happens
20454 during the PInvoke declaration.
20456 2002-04-09 Miguel de Icaza <miguel@ximian.com>
20458 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
20459 failure, so we do not keep going afterwards.
20461 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
20462 wanted to pass `false' as the `is_delegate' argument. If this is
20463 the case, why not use delegate_type == null to mean `is_delegate =
20464 false' and anything else as is_delegate = true.
20466 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
20468 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
20469 code for the section, not the beginning of the tests.
20471 2002-04-08 Miguel de Icaza <miguel@ximian.com>
20473 * cfold.cs: Handle operator + (Enum x, Underlying x)
20475 * expression.cs (Binary): same. Warn about errors where we have
20476 Enum/Enum in operator + as well.
20478 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
20481 - added support for switch(bool)
20482 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
20483 - add TableSwitchEmit() to handle table-based switch statements
20485 2002-04-05 Ravi Pratap <ravi@ximian.com>
20487 * expression.cs (Invocation.OverloadResolve): Factor out code which
20488 does parameter compatibility checking with arguments so that we can
20489 re-use the code even from Delegate.VerifyApplicability
20491 (VerifyArgumentsCompat): Move above code here.
20493 * delegate.cs (VerifyApplicability): Get rid of duplicate code
20494 and instead make a call to the above method.
20496 2002-03-31 Ravi Pratap <ravi@ximian.com>
20498 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
20499 We use it to keep track of classes which are attribute types.
20501 2002-04-02 Miguel de Icaza <miguel@ximian.com>
20503 * delegate.cs (Delegate.Define): Correctly define the types in the
20504 presence of fixed and array parameters.
20506 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
20509 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
20510 include NonPublic after the first iteration.
20512 * class.cs (Indexer.CheckBase): Only check if both parents are
20515 * cs-parser.jay (accessor_body): If empty, set to null.
20517 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
20518 same code path here to resolve constants names that we did have in
20519 MemberAccess.DoResolve. There is too much code duplicated here.
20521 2002-04-01 Miguel de Icaza <miguel@ximian.com>
20523 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
20525 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
20528 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
20529 tokens, numbers and strings.
20531 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
20534 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
20535 asyncronous parameters and the regular parameters.
20537 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
20538 specify the target directory.
20540 * expression.cs: (This.DoResolve): Simplify
20541 (As.Emit): Optimize, do not generate IsInst if the expression is
20542 always of the given type.
20544 (Is.DoResolve): Bug fix, we were reporting both always/never for
20547 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
20548 creating too many unnecessary arrays.
20550 2002-03-31 Miguel de Icaza <miguel@ximian.com>
20552 * class.cs (EmitFieldInitializer): Use Assign expression to assign
20553 fields instead of rolling our own initializer. Takes care of all
20554 implicit conversions, and drops unnecessary static checks/argument.
20556 2002-03-31 Dick Porter <dick@ximian.com>
20558 * driver.cs: use the GetDirectories() return values properly, and
20559 use "/" as path separator.
20561 2002-03-30 Miguel de Icaza <miguel@ximian.com>
20563 * expression.cs (Unary): Optimize - - expr into expr.
20564 (Binary): Optimize a + (-b) into a -b.
20566 * codegen.cs (CodeGen): Made all methods static.
20568 2002-03-29 Miguel de Icaza <miguel@ximian.com>
20572 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
20573 TypeBuilder property.
20575 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
20578 * tree.cs: Removed the various RecordXXXX, and replaced with a
20579 single RecordDecl. Removed all the accessor methods, and just
20580 left a single access point Type
20582 * enum.cs: Rename DefineEnum to DefineType.
20584 * decl.cs: New abstract method `DefineType' used to unify the
20585 Defines for Enumerations, Interfaces, TypeContainers and
20588 (FindType): Moved LookupInterfaceOrClass here. Moved the
20589 LookupBaseClasses method that used to live in class.cs and
20590 interface.cs here, and renamed to FindType.
20592 * delegate.cs: Implement DefineType. Take advantage of the
20593 refactored pattern for locating the parent builder without taking
20594 the parent_builder argument (which we know does not work if we are
20595 nested, and triggering a toplevel definition).
20597 2002-03-28 Miguel de Icaza <miguel@ximian.com>
20599 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
20600 accessibility of a member has changed during override and report
20603 * class.cs (Method.Define, Property.Define): Only complain on
20604 overrides if the method is private, any other accessibility is
20605 fine (and since we just checked the permission is the same, we are
20608 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
20609 and elif are processed always. The other pre-processing
20610 directives are only processed if we are "taking" the path
20612 2002-03-29 Martin Baulig <martin@gnome.org>
20614 * class.cs (Method.Emit): Only emit symbolic debugging info if the
20615 current location is not Null.
20617 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
20618 a separate method so we can profile it.
20620 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
20621 `span.Seconds' are just seconds, but no minutes or hours.
20622 (MainDriver): Profile the CodeGen.SaveSymbols calls.
20624 2002-03-28 Miguel de Icaza <miguel@ximian.com>
20626 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
20627 Remove the gratuitous set of Final:
20629 // If an interface implementation, then we can set Final.
20630 if (((flags & MethodAttributes.Abstract) == 0) &&
20631 implementing.DeclaringType.IsInterface)
20632 flags |= MethodAttributes.Final;
20634 I do not know what I was smoking when I used that.
20637 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
20638 step into fixing the name resolution issues for delegates and
20639 unifying the toplevel name resolution.
20641 2002-03-28 Martin Baulig <martin@gnome.org>
20643 * class.cs (Method.Emit): If we have a symbol writer, call its
20644 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
20645 tell it about the current method.
20647 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
20648 writer that we're going to emit the first byte of IL code for a new
20649 statement (a new source line).
20650 (EmitContext.EmitTopBlock): If we have a symbol writer, call
20651 EmitContext.Mark() before emitting any code.
20653 * location.cs (SymbolDocument): Return null when we're Null.
20655 * statement.cs (Statement): Moved the `Location loc' variable here.
20656 (Statement.EmitBoolExpression): If we have a symbol writer, call
20657 ec.Mark() before emitting any code to tell it that we're at the
20658 beginning of a new statement.
20659 (StatementExpression): Added `Location' argument to the constructor.
20660 (Block): Added public readonly variable `StartLocation' and public
20661 variable `EndLocation'. The latter is to be set using SetEndLocation().
20662 (Block): Added constructor which takes a start and end location.
20663 (Block.SetEndLocation): New method. This sets the end location.
20664 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
20665 local variables we create.
20666 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
20667 each statement and do also mark the begin and end of the block.
20669 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
20670 tell it the current lexer.Location, use Location.Null for the end of the
20672 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
20673 current block, set its end location using SetEndLocation().
20674 (statement_expression): StatementExpression constructor now takes the
20675 lexer.Location as additional argument.
20676 (for_statement, declare_local_variables): Likewise.
20677 (declare_local_variables): When creating a new implicit block, use the
20678 new Block constructor and pass it the lexer.Location.
20680 2002-03-28 Miguel de Icaza <miguel@ximian.com>
20682 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
20683 members also on the parent interfaces recursively.
20685 2002-03-27 Miguel de Icaza <miguel@ximian.com>
20687 * report.cs: Use new formats, since Gonzalo finished the missing
20690 * expression.cs (Binary.ResolveOperator): added missing operator|
20691 operator& and operator^ for bool/bool.
20693 * cs-parser.jay: CheckDef now takes a Location argument that is
20694 used to report errors more precisly (instead of reporting the end
20695 of a definition, we try to track something which is a lot closer
20696 to the source of the problem).
20698 * cs-tokenizer.cs: Track global token use, so we can properly flag
20699 the use of #define/#undef after the first token has been seen.
20701 Also, rename the reportXXXX to Error_DescriptiveName
20703 * decl.cs (DeclSpace.IsTopLevel): Move property here from
20704 TypeContainer, so that Enum and Interface can use this too.
20706 * class.cs (TypeContainer.LookupInterfaceOrClass,
20707 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
20708 `builder' argument. Typically this was used to pass the parent
20709 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
20712 The problem is that a nested class could trigger the definition of
20713 a toplevel class, and the builder would be obviously wrong in that
20716 So we drop this argument, and we compute dynamically the
20717 TypeBuilder/ModuleBuilder (the correct information was available
20718 to us anyways from DeclSpace.Parent)
20720 * interface.cs (Interface.DefineInterface): Drop builder
20721 parameter cleanup like class.cs
20723 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
20726 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
20729 (Try.Emit): Propagate the returns value from the statement.
20731 (Return.Emit): Even if we are leavning
20733 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
20735 * modifiers.cs: Fix the computation of MethodAttributes flags.
20737 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
20739 * driver.cs: allow compilation of files that start with '/'.
20740 Add a default case when checking the argument of --target.
20742 2002-03-25 Miguel de Icaza <miguel@ximian.com>
20744 * interface.cs: Implement the same search algorithm for types in
20745 the interface code.
20747 * delegate.cs: Do not allow multiple definition.
20749 * Recovered ChangeLog that got accidentally amputated
20751 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
20753 * rootcontext.cs: Load manually enum to allow core classes to
20754 contain enumerations.
20756 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
20757 Update to new static methods in TypeManager.
20759 * typemanager.cs (GetMethod, GetConstructor): Use our
20760 implementation of FindMembers to find the members, since during
20761 corlib compilation, the types are TypeBuilders and GetMethod and
20762 GetConstructor do not work.
20764 Make all methods in TypeManager static.
20766 (InitCodeHelpers): Split the functionality from
20767 the InitCodeTypes function.
20769 * driver.cs: Call InitCodeHelpers after we have populated the
20772 * cs-parser.jay (delegate_declaration): we did not used to compute
20773 the delegate name correctly for void delegates.
20775 2002-03-24 Miguel de Icaza <miguel@ximian.com>
20777 * rootcontext.cs (RootContext): Init the interface_resolve_order
20778 and type_container_resolve_order always.
20780 (ResolveCore, BootstrapCorlib_ResolveClass,
20781 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
20782 compiler when compiling with --nostdlib
20784 * class.cs (TypeContainer.DefineType): Check that our parent is
20785 not null. This test is most important when we are bootstraping
20788 * codegen.cs: Split out the symbol writing code.
20790 2002-03-25 Martin Baulig <martin@gnome.org>
20792 * driver.cs (-g): Made -g an alias for --debug.
20794 2002-03-24 Martin Baulig <martin@gnome.org>
20796 * codegen.cs (SymbolWriter): New public variable. Returns the
20797 current symbol writer.
20798 (CodeGen): Added `bool want_debugging_support' argument to the
20799 constructor. If true, tell the ModuleBuild that we want debugging
20800 support and ask it for the ISymbolWriter.
20801 (Save): If we have a symbol writer, call it's Close() method after
20802 saving the assembly.
20804 * driver.c (--debug): New command line argument to create a
20805 debugger information file.
20807 * location.cs (SymbolDocument): New public property. Returns an
20808 ISymbolDocumentWriter object for the current source file or null
20809 if we don't have a symbol writer.
20811 2002-03-21 Miguel de Icaza <miguel@ximian.com>
20813 * driver.cs (LoadAssembly): Correctly return when all the paths
20814 have been tried and not before.
20816 * statement.cs (Switch.Emit): return the actual coverage for this
20817 statement (returns/not-returns)
20819 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
20820 switch of the statement if we are the last switch section. That
20821 kills two problems: try/catch problems (we used to emit an empty
20822 nop at the end) and switch statements where all branches would
20825 2002-03-19 Miguel de Icaza <miguel@ximian.com>
20827 * driver.cs: Add default assemblies (the equivalent to the
20828 Microsoft CSC.RSP file)
20830 * cs-tokenizer.cs: When updating `cols and setting it to zero,
20831 also update tokens_seen and set it to false.
20833 * driver.cs: Implement --recurse for Mike.
20835 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
20836 correctly splitting out the paths.
20838 2002-03-18 Miguel de Icaza <miguel@ximian.com>
20840 * interface.cs (Interface.PopulateProperty): Instead of using
20841 `parent' as the declaration space for the set parameters, use
20844 * support.cs (InternalParameters): InternalParameters constructor
20845 takes a DeclSpace instead of a TypeContainer.
20847 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
20848 types are being initialized, load the address of it before calling
20851 (New): Provide a mechanism to disable the generation of local
20852 value type temporaries when the caller will be providing us with
20853 an address to store it.
20855 (ArrayCreation.EmitDynamicInitializers): Use it.
20857 2002-03-17 Miguel de Icaza <miguel@ximian.com>
20859 * expression.cs (Invocation.EmitArguments): Only probe for array
20860 property if there is more than one argument. Sorry about that.
20862 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
20863 empty param arrays.
20865 * class.cs (Method.LabelParameters): Fix incorrect code path that
20866 prevented the `ParamArrayAttribute' from being applied to the
20869 2002-03-16 Miguel de Icaza <miguel@ximian.com>
20871 * support.cs (ReflectionParameters): Correctly compute whether the
20872 last argument is a params array. Fixes the problem with
20875 * typemanager.cs: Make the assemblies array always be non-null
20876 (empty, but non-null)
20878 * tree.cs (RecordDecl): New function that abstracts the recording
20879 of names. This reports error 101, and provides a pointer to the
20880 previous declaration. Fixes a crash in the compiler.
20882 * cs-parser.jay (constructor_declaration): Update to new grammar,
20883 and provide a constructor_body that can be empty.
20885 2002-03-15 Miguel de Icaza <miguel@ximian.com>
20887 * driver.cs: Add support for --resources.
20889 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
20890 Make all types for the various array helper methods be integer.
20892 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
20893 CheckState to ConvCast.
20895 (ConvCast): Now it takes a `checked' state argument, to avoid
20896 depending on the emit context for the conversion, and just using
20897 the resolve time setting.
20899 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
20900 instead of Invocation.EmitArguments. We do not emit the original
20901 arguments, instead we emit those which have been converted to
20902 unsigned int expressions.
20904 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
20906 * codegen.cs: ditto.
20908 * expression.cs (LocalVariableReference): Drop the use of the
20909 Store function that depended on the variable index.
20911 * statement.cs (VariableInfo): Drop the `Idx' property from this
20912 class, as this is not taking into account the indexes for
20913 temporaries tat we generate during the execution, getting the
20916 * class.cs: First emit class initializers, then call the parent
20919 * expression.cs (Binary): Fix opcode emision.
20920 (UnaryMutator.EmitCode): Support checked code generation
20922 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
20923 matches for events for both the Static and Instance scans,
20924 pointing to the same element. Fix that.
20926 2002-03-14 Miguel de Icaza <miguel@ximian.com>
20928 * rootcontext.cs (ResolveTree): Always set the
20929 interface_resolve_order, because nested interfaces will be calling
20932 * class.cs (GetInterfaceOrClass): Track the same resolution
20933 process used by TypeManager.LookupType. This fixes the nested
20934 type lookups in class declarations (separate path from
20937 (TypeContainer.DefineType): Also define nested interfaces.
20938 (TypeContainer.RegisterOrder): New public function used to
20939 register the order in which child interfaces need to be closed.
20941 Nested interfaces need to be closed after their parents have been
20944 * interface.cs (InterfaceAttr): Put all the logic for computing
20945 the interface attribute here.
20947 (DefineInterface): Register our interface order with the
20948 RootContext or with the TypeContainer depending on the case.
20950 2002-03-12 Miguel de Icaza <miguel@ximian.com>
20952 * cs-parser.jay: rework foreach statement to work with the new
20953 changes to the policy on SimpleNames.
20955 * report.cs: support Stacktrace on warnings as well.
20957 * makefile: drop --unsafe and /unsafe from the compile.
20959 2002-03-13 Ravi Pratap <ravi@ximian.com>
20961 * ecore.cs (StandardConversionExists): Modify to take an Expression
20962 as the first parameter. Ensure we do null -> reference type conversion
20965 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
20966 temporary Expression objects.
20968 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
20970 * interface.cs: workaround bug in method overloading resolution
20971 (there is already a bugzilla bug for it).
20973 2002-03-12 Miguel de Icaza <miguel@ximian.com>
20975 We could also solve this problem by having a separate path for
20976 performing type lookups, instead of DoResolve, we could have a
20977 ResolveType entry point, and only participating pieces of the
20978 production (simplename, deref, array) would implement this.
20980 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
20981 signal SimpleName to only resolve type names and not attempt to
20982 resolve anything else.
20984 * expression.cs (Cast): Set the flag.
20986 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
20988 * class.cs: Only report 108 if there is no `new' modifier.
20990 * cs-parser.jay: rework foreach statement to work with the new
20991 changes to the policy on SimpleNames.
20993 * report.cs: support Stacktrace on warnings as well.
20995 * makefile: drop --unsafe and /unsafe from the compile.
20997 2002-03-11 Miguel de Icaza <miguel@ximian.com>
20999 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
21000 lookups here, instead of doing that at parse time. This means
21001 that our grammar will not introduce `LocalVariableReferences' as
21002 expressions at this point. That solves the problem of code like
21006 static void Main ()
21010 This is only half the fix. The full fix requires parameters to
21011 also be handled in this way.
21013 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
21014 makes the use more obvious of the DeclSpace. The
21015 ec.TypeContainer.TypeBuilder is now only used to pull the
21016 TypeBuilder for it.
21018 My theory is that I can get rid of the TypeBuilder completely from
21019 the EmitContext, and have typecasts where it is used (from
21020 DeclSpace to where it matters).
21022 The only pending problem is that the code that implements Aliases
21023 is on TypeContainer, and probably should go in DeclSpace.
21025 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
21026 lookups here, instead of doing that at parse time. This means
21027 that our grammar will not introduce `LocalVariableReferences' as
21028 expressions at this point. That solves the problem of code like
21032 static void Main ()
21036 This is only half the fix. The full fix requires parameters to
21037 also be handled in this way.
21039 * class.cs (Property.DefineMethod): When implementing an interface
21040 method, set newslot, when implementing an abstract method, do not
21041 set the flag (before we tried never setting it, or always setting
21042 it, which is the difference).
21043 (Indexer.DefineMethod): same.
21044 (Method.DefineMethod): same.
21046 * ecore.cs: Only set the status used flag if we get back a Field.
21048 * attribute.cs: Temporary hack, so Paolo can keep working.
21050 2002-03-08 Ravi Pratap <ravi@ximian.com>
21052 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
21053 the unmanaged type in the case we have a MarshalAs attribute.
21055 (Resolve): Handle the case when we are parsing the special MarshalAs
21056 attribute [we need to store the unmanaged type to use later]
21058 * typemanager.cs (marshal_as_attr_type): Built in type for the
21059 MarshalAs Attribute.
21061 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
21062 on parameters and accordingly set the marshalling info.
21064 2002-03-09 Miguel de Icaza <miguel@ximian.com>
21066 * class.cs: Optimizing slightly by removing redundant code after
21067 we switched to the `NoTypes' return value.
21068 (Property.DefineMethod): use NoTypes here too.
21070 This fixes the bug I introduced in my last batch of changes.
21072 2002-03-05 Ravi Pratap <ravi@ximian.com>
21074 * tree.cs (RecordEnum): Add. We now keep track of enums too.
21076 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
21077 Enums since those are types too.
21079 * cs-parser.jay (enum_declaration): Record enums as we parse them.
21081 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
21082 thanks to a call during the lookup process.
21084 2002-03-07 Miguel de Icaza <miguel@ximian.com>
21086 * statement.cs (Foreach): Lots of work to accomodate a particular
21087 kind of foreach statement that I had not kept in mind. It is
21088 possible to have foreachs on classes that provide a GetEnumerator
21089 method that return objects that implement the "pattern" for using
21090 a foreach, there is no need to support GetEnumerator
21093 This is needed to compile nant.
21095 * decl.cs: Only report 114 if the member is not `Finalize' and if
21096 the warning level is at least 2.
21098 * class.cs: Moved the compare function from Method to
21101 (MethodSignature.InheritableMemberSignatureCompare): Add new
21102 filter function that is used to extract inheritable methods from a
21105 (Method.Define): Use the new `inheritable_method_signature_filter'
21108 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
21111 2002-03-06 Miguel de Icaza <miguel@ximian.com>
21113 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
21115 * cs-parser.jay: Add opt_semicolon to the interface declaration.
21117 * expression.cs: Pass location information to
21118 ConvertImplicitStandard.
21120 * class.cs: Added debugging code to track return values from
21123 2002-03-05 Miguel de Icaza <miguel@ximian.com>
21125 * expression.cs (Is.DoResolve): If either side of the `is' is an
21126 interface, do not flag the warning.
21128 * ecore.cs (ImplicitReferenceConversion): We need a separate test
21131 * report.cs: Allow for --fatal to be used with --probe.
21133 * typemanager.cs (NoTypes): Move the definition for the empty Type
21136 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
21138 (TypeContainer.DefineProxy): New function used to proxy to parent
21139 implementations when implementing interfaces.
21140 (TypeContainer.ParentImplements): used to lookup if our parent
21141 implements a public function that is required by an interface.
21142 (TypeContainer.VerifyPendingMethods): Hook this up.
21144 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
21145 `modules' and `assemblies' arraylists into arrays. We only grow
21146 these are the very early start up of the program, so this improves
21147 the speedof LookupType (nicely measured).
21149 * expression.cs (MakeByteBlob): Replaced unsafe code with
21150 BitConverter, as suggested by Paolo.
21152 * cfold.cs (ConstantFold.Binary): Special case: perform constant
21153 folding of string concatenation, but if either side is a string,
21154 and the other is not, then return null, and let the runtime use
21155 the concatenation on the string plus the object (using
21156 `Object.ToString').
21158 2002-03-04 Miguel de Icaza <miguel@ximian.com>
21160 Constant Folding has been implemented now.
21162 * expression.cs (Unary.Reduce): Do not throw an exception, catch
21163 the error instead on types that are not supported in one's
21166 * constant.cs (Constant and all children): New set of functions to
21167 perform implict and explicit conversions.
21169 * ecore.cs (EnumConstant): Implement the new functions to perform
21170 conversion by proxying to the child expression.
21172 * codegen.cs: (ConstantCheckState): Constant evaluation has its
21173 own separate setting that can not be turned off from the command
21174 line using --unchecked or --checked and is only controlled using
21175 the checked/unchecked statements and expressions. This setting is
21176 used by the constant folder to flag errors.
21178 * expression.cs (CheckedExpr, UncheckedExpr): Set the
21179 ConstantCheckState as well.
21181 During Resolve, they also have to flag the state, because the
21182 constant folder runs completely in the Resolve phase.
21184 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
21187 2002-03-01 Miguel de Icaza <miguel@ximian.com>
21189 * cfold.cs: New file, this file contains the constant folder.
21191 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
21192 argument to track whether we are using the resulting address to
21193 load or store a value and provide better error messages.
21195 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
21196 new AddressOf arguments.
21198 * statement.cs (Foreach.EmitCollectionForeach): Update
21200 * expression.cs (Argument.Emit): Call AddressOf with proper
21201 arguments to track usage.
21203 (New.DoEmit): Call AddressOf with new arguments.
21205 (Unary.Emit): Adjust AddressOf call.
21207 2002-03-01 Ravi Pratap <ravi@ximian.com>
21209 * cs-parser.jay (member_access): Change the case for pre-defined types
21210 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
21213 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
21216 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
21217 essentially like methods and apply attributes like MethodImplOptions to them too.
21219 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
21222 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
21223 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
21226 * Update code everywhere accordingly.
21228 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
21230 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
21232 2002-02-28 Ravi Pratap <ravi@ximian.com>
21234 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
21235 try performing lookups against those instead of jumping straight into using
21236 the 'using' clauses.
21238 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
21240 (LookupType): Perform lookups in implicit parents too.
21242 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
21243 sequence as RootContext.LookupType.
21245 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
21246 the various cases of namespace lookups into this method.
21248 2002-03-01 Miguel de Icaza <miguel@ximian.com>
21250 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
21251 in positional arguments)
21253 * class.cs (Operator): Update the AllowedModifiers to contain
21256 * cs-parser.jay: Update operator declaration to allow for the
21257 operator body to be empty.
21259 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
21262 2002-02-27 Miguel de Icaza <miguel@ximian.com>
21264 * class.cs (Method.Emit): Label parameters.
21266 * driver.cs: Return 1 or 0 as the program exit code.
21268 2002-02-26 Miguel de Icaza <miguel@ximian.com>
21270 * expression.cs: Special case the `null' object when trying to
21271 auto-compute the type, as anything can be explicitly converted to
21274 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
21275 spotting this Paolo.
21277 (Expression.ImplicitNumericConversion): Perform comparissions of
21278 the type using the underlying type in the case of an enumeration
21279 rather than using the enumeration type for the compare.
21281 Cope with the underlying == type case, which is not possible to
21284 (Expression.ConvertNumericExplicit): Perform comparissions of
21285 the type using the underlying type in the case of an enumeration
21286 rather than using the enumeration type for the compare.
21288 * driver.cs: If the user does not supply an extension, assume .exe
21290 * cs-parser.jay (if_statement): Rewrote so that we can track the
21291 location for the if statement.
21293 * expression.cs (Binary.ConstantFold): Only concat strings when
21294 the operation is "+", not everything ;-)
21296 * statement.cs (Statement.EmitBoolExpression): Take a location
21298 (If, While, Do): Track location.
21300 * expression.cs (Binary.ResolveOperator): In the object + string
21301 case, I was missing a call to ConvertImplicit
21303 2002-02-25 Ravi Pratap <ravi@ximian.com>
21305 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
21306 Location arguments. Ensure we use RootContext.LookupType to do our work
21307 and not try to do a direct Type.GetType and ModuleBuilder.GetType
21309 * interface.cs (PopulateMethod): Handle the type of the parameter being
21312 * expression.cs (Invocation.BetterFunction): Handle the case when we
21313 have a params method with no fixed arguments and a call is made with no
21316 2002-02-25 Miguel de Icaza <miguel@ximian.com>
21318 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
21319 the verbatim-string-literal
21321 * support.cs (InternalParameters.ParameterModifier): handle null
21323 (InternalParameters.ParameterType): ditto.
21325 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
21326 duplicating the name of the variable parameter.
21327 (GetParameterByName): Fix bug where we were not looking up array
21328 paramters if they were the only present (thanks Paolo!).
21329 (GetParameterInfo): We only have an empty set of types if both
21330 fixed and array are set to null.
21331 (GetParameterInfo-idx): Handle FixedParameter == null
21333 * cs-parser.jay: Handle the case where there is no catch
21334 statements (missing null test).
21336 2002-02-22 Miguel de Icaza <miguel@ximian.com>
21338 * driver.cs (MainDriver): Be conservative on our command line
21341 Catch DirectoryNotFoundException when calling GetFiles.
21343 (SplitPathAndPattern): Used to split the input specification into
21344 a path and a pattern that we can feed to Directory.GetFiles.
21346 2002-02-21 Miguel de Icaza <miguel@ximian.com>
21348 * statement.cs (Fixed): Implement the last case of the Fixed
21349 statement (string handling).
21351 * expression.cs (StringPtr): New class used to return a char * to
21352 a string; Used by the Fixed statement.
21354 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
21356 * expression.cs (Binary.ResolveOperator): Remove redundant
21357 MemberLookup pn parent type.
21358 Optimize union call, we do not need a union if the types are the same.
21359 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
21362 Specialize the use of MemberLookup everywhere, instead of using
21363 the default settings.
21365 (StackAlloc): Implement stackalloc keyword.
21367 * cs-parser.jay: Add rule to parse stackalloc.
21369 * driver.cs: Handle /h, /help, /?
21371 * expression.cs (MakeByteBlob): Removed the hacks we had in place
21372 before we supported unsafe code.
21374 * makefile: add --unsafe to the self compilation of mcs.
21376 2002-02-20 Miguel de Icaza <miguel@ximian.com>
21378 * expression.cs (PointerArithmetic): New class that is used to
21379 perform pointer arithmetic.
21380 (Binary.Resolve): Handle pointer arithmetic
21381 Handle pointer comparission.
21382 (ArrayPtr): Utility expression class that is used to take the
21383 address of an array.
21385 (ElementAccess): Implement array access for pointers
21387 * statement.cs (Fixed): Implement fixed statement for arrays, we
21388 are missing one more case before we are done.
21390 * expression.cs (Indirection): Implement EmitAssign and set the
21391 ExprClass to Variable. This allows pointer dereferences to be
21392 treated as variables, and to have values assigned to them.
21394 * ecore.cs (Expression.StoreFromPtr): New utility function to
21395 store values dereferencing.
21397 2002-02-20 Ravi Pratap <ravi@ximian.com>
21399 * expression.cs (Binary.ResolveOperator): Ensure that we are
21400 not trying to operate on a void type - this fixes the reported
21403 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
21404 the parent implementation is sealed.
21406 * ../errors/cs0239.cs : Add.
21408 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
21410 * typemanager.cs (unverifiable_code_type): Corresponds to
21411 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
21412 which have unsafe code in them.
21414 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
21417 2002-02-19 Miguel de Icaza <miguel@ximian.com>
21419 * cs-tokenizer.cs: Add support for @"litreal strings"
21421 Make tokenizer accept pre-processor directives
21422 on any column (remove the old C-like limitation).
21424 * rootcontext.cs (EmitCode): Emit any global attributes.
21425 (AddGlobalAttributes): Used to keep track of assembly attributes.
21427 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
21429 * cs-parser.jay: Add support for global attributes.
21431 2002-02-17 Miguel de Icaza <miguel@ximian.com>
21433 * expression.cs (Indirection): New helper class. Unary will
21434 create Indirection classes to be able to implement the
21435 IMemoryLocation interface on it.
21437 2002-02-16 Miguel de Icaza <miguel@ximian.com>
21439 * cs-parser.jay (fixed_statement): reference the right statement.
21441 * statement.cs (Fixed.Emit): Finish implementing the fixed
21442 statement for the &x case.
21444 2002-02-14 Miguel de Icaza <miguel@ximian.com>
21446 * class.cs (Property.Define, Method.Define): Remove newslot when
21449 * modifiers.cs: My use of NewSlot when `Abstract' was set was
21450 wrong. NewSlot should only be used if the `new' keyword is present.
21452 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
21453 locating our system dir. Sorry about this.
21455 2002-02-13 Miguel de Icaza <miguel@ximian.com>
21457 * driver.cs (GetSystemDir): Compute correctly the location of our
21458 system assemblies. I was using the compiler directory instead of
21459 the library directory.
21461 2002-02-13 Ravi Pratap <ravi@ximian.com>
21463 * expression.cs (BetterFunction): Put back in what Miguel commented out
21464 since it is the correct fix. The problem is elsewhere ;-)
21466 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
21467 parameters of the parms method are themselves compatible or not !
21469 (StandardConversionExists): Fix very dangerous bug where we were forgetting
21470 to check that a class implements an interface before saying that an implicit
21471 conversion was allowed. Use ImplementsInterface to do the checking.
21473 2002-02-13 Miguel de Icaza <miguel@ximian.com>
21475 * class.cs (Method.Define): Track whether we are an explicit
21476 implementation or not. And only call DefineMethodOverride if we
21477 are an explicit implementation.
21479 (Property.DefineMethod): Ditto.
21481 2002-02-11 Ravi Pratap <ravi@ximian.com>
21483 * expression.cs (BetterFunction): Catch hideous bug which was
21484 preventing us from detecting ambiguous calls due to implicit casts i.e
21487 2002-01-29 Miguel de Icaza <miguel@ximian.com>
21489 * support.cs (Pair): Remove un-needed method. I figured why I was
21490 getting the error in cs-parser.jay, the variable in a foreach loop
21491 is readonly, and the compiler does not really treat this as a variable.
21493 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
21494 instead of EQUALS in grammar.
21496 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
21498 * expression.cs (Unary.DoResolve): Check whether the argument is
21501 2002-01-28 Miguel de Icaza <miguel@ximian.com>
21503 * support.cs: Api for Pair to set a value. Despite the fact that
21504 the variables are public the MS C# compiler refuses to compile
21505 code that accesses the field if the variable is part of a foreach
21508 * statement.cs (Fixed): Begin implementation of the fixed
21511 (Block.AddVariable): Return the VariableInfo on success and null
21512 on failure instead of true/false.
21514 * cs-parser.jay (foreach): Catch errors on variables already
21515 defined (we were ignoring this value before) and properly unwind
21516 the block hierarchy
21518 (fixed_statement): grammar for the fixed statement.
21520 2002-01-25 Miguel de Icaza <miguel@ximian.com>
21522 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
21523 pointer types to be incretemented.
21525 (SizeOf): Implement.
21527 * cs-parser.jay (pointer_member_access): Implement
21528 expr->IDENTIFIER production.
21530 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
21531 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
21534 (Unary): Implement indirection.
21536 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
21537 use in non-unsafe context).
21539 (SimpleName.DoResolve): Check for pointers in field access on safe
21542 (Expression.LoadFromPtr): Factor the load-indirect code in this
21543 function. This was duplicated in UnboxCast and ParameterReference
21545 2002-01-24 Miguel de Icaza <miguel@ximian.com>
21547 * expression.cs (ComposedCast): report an error if a pointer cast
21548 is used in a safe region.
21550 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
21551 pointer type casts in unsafe context.
21553 * codegen.cs (EmitContext): Set up IsUnsafe.
21555 * cs-parser.jay (non_expression_type): Add productions for pointer
21558 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
21559 code. We should not use force into static mode if the method is
21560 not virtual. Fixes bug in MIS
21562 * statement.cs (Do.Emit, While.Emit, For.Emit,
21563 Statement.EmitBoolExpression): Add support to Do and While to
21564 propagate infinite loop as `I do return' semantics.
21566 Improve the For case to also test for boolean constants.
21568 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
21569 to the list of attributes we can add.
21571 Remove `EmitContext' argument.
21573 * class.cs (Method.Define): Apply parameter attributes.
21574 (Constructor.Define): Apply parameter attributes.
21575 (MethodCore.LabelParameters): Move here the core of labeling
21578 * support.cs (ReflectionParameters.ParameterModifier,
21579 InternalParameters.ParameterModifier): Use IsByRef on the type and
21580 only return the OUT bit for these parameters instead of in/out/ref
21583 This is because I miss-understood things. The ParameterInfo.IsIn
21584 and IsOut represent whether the parameter has the [In] and [Out]
21587 2002-01-22 Miguel de Icaza <miguel@ximian.com>
21589 * ecore.cs (FieldExpr.Emit): Release temporaries.
21591 * assign.cs (LocalTemporary.Release): new function.
21593 * codegen.cs (EmitContext.GetTemporaryStorage,
21594 EmitContext.FreeTemporaryStorage): Rework the way we deal with
21595 temporary storage. Now we can "put back" localbuilders when we
21598 2002-01-21 Miguel de Icaza <miguel@ximian.com>
21600 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
21601 need to make a copy of the variable to generate verifiable code.
21603 2002-01-19 Miguel de Icaza <miguel@ximian.com>
21605 * driver.cs: Compute dynamically the system directory.
21607 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
21608 Slower, but more generally useful. Used by the abstract
21609 registering implementation.
21611 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
21612 the rules for the special rule on Type/instances. First check if
21613 we have the same name, and if so, try that special static path
21614 rather than the instance path.
21616 2002-01-18 Miguel de Icaza <miguel@ximian.com>
21618 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
21621 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
21622 Enum, ValueType, Delegate or Array for non-corlib compiles.
21624 * cs-tokenizer.cs: Catch long identifiers (645)
21626 * typemanager.cs (IndexerPropetyName): Ravi never tested this
21629 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
21630 fix, we were returning too early, so we were not registering
21631 pending methods from abstract classes.
21633 Do not register pending methods if the class is abstract.
21635 * expression.cs (Conditional.DoResolve): Report circular implicit
21636 conversions when we neecd to compute it for conditional
21639 (Is.DoResolve): If the expression is always of the provided type,
21640 flag warning 183. If the expression can not ever be of the
21641 provided type flag warning 184.
21643 * class.cs: Catch 169 as well.
21645 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
21648 2002-01-18 Nick Drochak <ndrochak@gol.com>
21650 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
21652 2002-01-17 Miguel de Icaza <miguel@ximian.com>
21654 * interface.cs: (PopulateMethod): Check for pointers being defined
21655 only if the unsafe context is active.
21656 (PopulateProperty): ditto.
21657 (PopulateIndexer): ditto.
21659 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
21660 specified. If pointers are present, make sure that they are
21661 present in an unsafe context.
21662 (Constructor, Constructor.Define): ditto.
21663 (Field, Field.Define): ditto.
21664 (Property, Property.Define): ditto.
21665 (Event, Event.Define): ditto.
21667 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
21668 hashtable if there are classes or structs defined.
21670 * expression.cs (LocalVariableReference.DoResolve): Simplify this
21671 code, as the constant resolution moved.
21673 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
21674 the metadata, so we can flag error 133.
21676 * decl.cs (MemberCore.UnsafeOK): New function to test that a
21677 pointer is being declared in an unsafe context.
21679 2002-01-16 Miguel de Icaza <miguel@ximian.com>
21681 * modifiers.cs (Modifiers.Check): Require a Location argument.
21682 Report error 227 for Unsafe use.
21684 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
21686 * statement.cs (For.Emit): If the test is null, then report that
21687 we do `return', as we wont reach anything afterwards.
21689 (Switch.SwitchGoverningType): Track the expression that matched
21692 * driver.cs: Allow negative numbers as an error code to flag.
21694 * cs-parser.jay: Handle 1551.
21696 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
21698 2002-01-15 Miguel de Icaza <miguel@ximian.com>
21700 * cs-parser.jay: Report 1518 (type declaration can only contain
21701 class, struct, interface, enum or delegate)
21703 (switch_label): Report 1523 (keywords `case' or `default' must
21706 (opt_switch_sections): Report 1522 (empty switch)
21708 * driver.cs: Report 1515 (response file specified multiple times)
21709 Report 1516 (Source file specified multiple times).
21711 * expression.cs (Argument.Resolve): Signal 1510
21713 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
21714 access not allowed in static code)
21716 2002-01-11 Ravi Pratap <ravi@ximian.com>
21718 * typemanager.cs (IsPointerType): Utility method which we are going
21721 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
21722 the object type, so we take care of that.
21724 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
21726 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
21727 added to non-params parameters :-)
21729 * typemanager.cs (CSharpName): Include 'void' type too.
21731 (void_ptr_type): Include in the set of core types.
21733 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
21736 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
21739 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
21740 completely forgotten about it.
21742 2002-01-10 Ravi Pratap <ravi@ximian.com>
21744 * cs-parser.jay (pointer_type): Add. This begins our implementation
21745 of parsing rules for unsafe code.
21747 (unsafe_statement): Implement.
21749 (embedded_statement): Modify to include the above.
21751 * statement.cs (Unsafe): Implement new class for unsafe blocks.
21753 * codegen.cs (EmitContext.InUnsafe): Add. This determines
21754 if the current context is an unsafe one.
21756 * cs-parser.jay (local_variable_pointer_type): Since local variable types
21757 are handled differently, we need separate rules for them.
21759 (local_variable_declaration): Update to use local_variable_pointer_type
21760 to allow variable declarations of unmanaged pointer types.
21762 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
21763 in unsafe contexts.
21765 * ../errors/cs0214.cs : Add.
21767 2002-01-16 Nick Drochak <ndrochak@gol.com>
21769 * makefile: remove 'response' file when cleaning.
21771 2002-01-15 Miguel de Icaza <miguel@ximian.com>
21773 * cs-parser.jay: Report 1524.
21775 2002-01-14 Miguel de Icaza <miguel@ximian.com>
21777 * typemanager.cs (RegisterMethod): drop checking if we have
21778 registered this from here
21780 2002-01-12 Miguel de Icaza <miguel@ximian.com>
21782 * class.cs (Method.EmitDestructor): Implement calling our base
21785 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
21786 value of InFinally.
21788 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
21789 this routine and will wrap the call in a try/catch block. Deal
21792 2002-01-11 Miguel de Icaza <miguel@ximian.com>
21794 * ecore.cs (Expression.MemberLookup): instead of taking a
21795 parameter `same_type' that was used to tell whether we could
21796 access private members we compute our containing type from the
21799 (FieldExpr): Added partial support for volatile fields. This does
21800 not work for volatile fields exposed from assemblies, as I can not
21801 figure out how to extract the modreq from it.
21803 Updated all the source files to use this.
21805 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
21806 because it is referenced by MemberLookup very often.
21808 2002-01-09 Ravi Pratap <ravi@ximian.com>
21810 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
21811 TypeBuilder.GetCustomAttributes to retrieve what we need.
21813 Get rid of redundant default_member_attr_type as this is the same as
21814 default_member_type which already exists.
21816 * interface.cs, attribute.cs : Update accordingly.
21818 2002-01-08 Miguel de Icaza <miguel@ximian.com>
21820 * typemanager.cs: Enable IndexerPropertyName again. It does not
21821 work for TYpeBuilders though. Ravi, can you please fix this?
21823 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
21825 * expression.cs (Argument.Emit): Handle the case of ref objects
21826 being passed to ref functions;
21828 (ParameterReference.EmitLoad): Loads the content of the pointer
21829 without dereferencing.
21831 2002-01-07 Miguel de Icaza <miguel@ximian.com>
21833 * cs-tokenizer.cs: Implemented the pre-processing expressions.
21835 2002-01-08 Ravi Pratap <ravi@ximian.com>
21837 * class.cs (Indexer.DefineMethod): Incorporate the interface
21838 type in the name of the method if we are doing explicit interface
21841 * expression.cs (ConversionExists): Remove as it is completely obsolete.
21843 (BetterConversion): Fix extremely trivial bug where we were referring to
21844 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
21847 * ../errors/bug16.cs : Add although we have fixed it.
21849 2002-01-07 Miguel de Icaza <miguel@ximian.com>
21851 * expression.cs (BaseIndexer): Begin implementation.
21853 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
21855 * cs-parser.jay (indexer_declarator): Use qualified_identifier
21856 production directly to remove a shift/reduce, and implement
21857 explicit interface implementation.
21859 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
21860 after a floating point suffix.
21862 * expression.cs (DoNumericPromotions): Improved the conversion for
21863 uint/uint. If we have a constant, we avoid doing a typecast to a
21866 * class.cs (Indexer): Implement explicit interface implementation
21869 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
21871 * class.cs: make the default instance constructor public and hidebysig.
21873 2001-01-03 Ravi Pratap <ravi@ximian.com>
21875 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
21876 so we can call it from elsewhere.
21878 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
21879 we emit it internally if the class has a defined indexer; otherwise the user
21880 emits it by decorating the class definition with the DefaultMemberAttribute.
21882 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
21883 attribute is not used on a type which defines an indexer.
21885 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
21886 character when we skip whitespace.
21888 * ../errors/cs0646.cs : Add.
21890 2002-01-03 Miguel de Icaza <miguel@ximian.com>
21892 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
21895 * makefile: Add practical target `mcs3.exe' which builds the third
21896 generation compiler.
21898 * expression.cs (New): Fix structures constructor calling.
21900 * class.cs (Property, Method, Indexer): Emit Final flag on the
21901 method if we are an interface implementation and we are not
21904 * ecore.cs (PropertyExpr): New public field `IsBase', tells
21905 whether this property is referencing a `base' method.
21907 * expression.cs (Invocation.EmitCall): take an extra argument:
21908 is_base, this is used to determine whether the `call' or
21909 `callvirt' opcode should be used.
21912 * delegate.cs: update EmitCall.
21914 * class.cs (Method.Define): Set NewSlot for the cases where we are
21915 not implementing an interface method.
21917 (Property.Define): ditto.
21919 2002-01-02 Miguel de Icaza <miguel@ximian.com>
21921 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
21922 'r'. Allows mcs to parse itself fully.
21924 2002-01-02 Ravi Pratap <ravi@ximian.com>
21926 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
21927 of the number of initializers that require the InitializeArray method.
21929 (CheckIndices): Store the Expression in all cases - not the plain value. Also
21930 update the above field where necessary.
21932 (MakeByteBlob): Update accordingly.
21934 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
21937 (EmitDynamicInitializers): Update in accordance with the new optimization.
21939 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
21940 same OpCode applies.
21942 * cs-parser.jay : Fix some glaring errors I introduced.
21944 2002-01-01 Ravi Pratap <ravi@ximian.com>
21946 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
21947 so that we can check for name clashes there too.
21949 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
21950 for interface indexers.
21952 * interfaces.cs (Define): Emit the default member attribute.
21954 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
21955 variable was being referred to while setting the value ;-)
21957 2002-01-01 Miguel de Icaza <miguel@ximian.com>
21959 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
21960 byte-by-byte information when we know the data is zero.
21962 Make the block always a multiple of 4, because
21963 DefineInitializedData has a bug.
21965 * assign.cs: Fix, we should assign from the temporary, not from
21968 * expression.cs (MakeByteBlob): Fix my incorrect code.
21970 2001-12-31 Miguel de Icaza <miguel@ximian.com>
21972 * typemanager.cs (EnumToUnderlying): This function is used to get
21973 the underlying type from an enumeration, because it does not
21976 * constant.cs: Use the I4_S form for values between -128 and 127.
21978 * statement.cs (Block.LookupLabel): Looks up a label.
21979 (Block): Drop support for labeled blocks.
21981 (LabeledStatement): New kind of statement that represents a label
21984 (Goto): Finally implement this bad boy.
21986 * cs-parser.jay: Update to reflect new mechanism to implement
21989 2001-12-30 Miguel de Icaza <miguel@ximian.com>
21991 * codegen.cs (EmitContext.This): a codegen property that keeps the
21992 a single instance of this instead of creating many different this
21995 * delegate.cs (Delegate.DoResolve): Update to use the property;
21997 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
21999 * expression.cs (BaseAccess.DoResolve): Ditto.
22001 2001-12-29 Ravi Pratap <ravi@ximian.com>
22003 * typemanager.cs (methodimpl_attr_type): Add to hold the type
22004 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
22006 (InitCoreTypes): Update accordingly.
22008 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
22009 so we can quickly store the state.
22011 (ApplyAttributes): Set the correct implementation flags
22012 for InternalCall methods.
22014 2001-12-29 Miguel de Icaza <miguel@ximian.com>
22016 * expression.cs (EmitCall): if a method is not virtual, then do
22017 not use callvirt on it.
22019 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
22020 user defined stuff) requires the use of stobj, which takes an
22021 address on the stack instead of an array and an index. So emit
22022 the Ldelema operation for it.
22024 (EmitStoreOpcode): Use stobj for valuetypes.
22026 (UnaryMutator.EmitCode): Use the right 1 value depending on
22027 whether we are dealing with int64/uint64, float or doubles.
22029 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
22030 constructors that I implemented last night.
22032 (Constructor.IsDefault): Fix to work properly for static
22035 * cs-parser.jay (CheckDef): report method signature errors.
22036 Update error number 103 to be 132.
22038 * decl.cs: New AdditionResult enumeration value: MethodExists.
22039 Although we do this check for methods later on in the semantic
22040 analysis, catching repeated default constructors is so easy that
22041 we catch these here.
22043 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
22046 (ParameterReference.EmitAssign, Emit): handle
22049 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
22050 (ArrayAccess.EmitStoreOpcode): ditto.
22052 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
22054 * expression.cs (MakeByteBlob): Complete all the missing types
22055 (uint, short, ushort, byte, sbyte)
22057 * class.cs: Only init instance field initializers on instance
22060 Rename `constructors' to instance_constructors.
22062 (TypeContainer.AddConstructor): Only add constructors to the list
22063 if it is not static.
22065 Make sure that we handle default_static_constructor independently
22066 everywhere where we handle instance_constructors
22068 2001-12-28 Miguel de Icaza <miguel@ximian.com>
22070 * class.cs: Do not lookup or create a base initializer for a
22071 static constructor.
22073 (ConstructorInitializer.Resolve): use the proper type to lookup
22076 * cs-parser.jay: Report error 1585 (modifiers between type and name).
22078 * enum.cs, interface.cs: Remove CloseType, this is taken care by
22081 * decl.cs: CloseType is now an virtual method, the default
22082 implementation just closes this type.
22084 2001-12-28 Ravi Pratap <ravi@ximian.com>
22086 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
22087 to PreserveSig by default. Also emit HideBySig on such methods.
22089 Basically, set the defaults to standard values.
22091 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
22092 argument, if candidate is better, it can't be worse than the best !
22094 (Invocation): Re-write bits to differentiate between methods being
22095 applicable in their expanded form and their normal form - for params
22098 Get rid of use_standard everywhere as only standard conversions are allowed
22099 in overload resolution.
22101 More spec conformance.
22103 2001-12-27 Miguel de Icaza <miguel@ximian.com>
22105 * driver.cs: Add --timestamp, to see where the compiler spends
22108 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
22109 `this' in static code.
22111 (SimpleName.DoResolve): Implement in terms of a helper function
22112 that allows static-references to be passed upstream to
22115 (Expression.ResolveWithSimpleName): Resolve specially simple
22116 names when called by MemberAccess to implement the special
22119 (Expression.ImplicitReferenceConversion): Handle conversions from
22120 Null to reference types before others, as Null's type is
22123 * expression.cs (Invocation.EmitCall): Handle the special case of
22124 calling methods declared on a reference type from a ValueType
22125 (Base classes System.Object and System.Enum)
22127 (MemberAccess.Resolve): Only perform lookups on Enumerations if
22128 the left hand side is a TypeExpr, not on every enumeration.
22130 (Binary.Resolve): If types are reference types, then do a cast to
22131 object on operators != and == of both arguments.
22133 * typemanager.cs (FindMembers): Extract instance and static
22134 members if requested.
22136 * interface.cs (PopulateProperty): Use void_type instead of null
22137 as the return type for the setter method.
22139 (PopulateIndexer): ditto.
22141 2001-12-27 Ravi Pratap <ravi@ximian.com>
22143 * support.cs (ReflectionParameters): Fix minor bug where we
22144 were examining the wrong parameter for the ParamArray attribute.
22146 Cope with requests for the type of the parameter at position
22147 greater than the params parameter's. We now return the element
22148 type of the params array as that makes more sense.
22150 * expression.cs (Invocation.IsParamsMethodApplicable): Update
22151 accordingly as we no longer have to extract the element type
22154 (Invocation.OverloadResolve): Update.
22156 2001-12-27 Miguel de Icaza <miguel@ximian.com>
22158 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
22159 against IEnumerator, test whether the return value is a descendant
22160 of the IEnumerator interface.
22162 * class.cs (Indexer.Define): Use an auxiliary method to implement
22163 the other bits of the method definition. Begin support for
22164 explicit interface implementation.
22166 (Property.DefineMethod): Use TypeManager.void_type instead of null
22167 for an empty return value.
22169 2001-12-26 Miguel de Icaza <miguel@ximian.com>
22171 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
22172 dealing with a FieldExpr which is composed of a FieldBuilder, in
22173 the code path we did extract the constant, but we should have
22174 obtained the underlying value to be able to cast it (otherwise we
22175 end up in an infinite loop, this is what Ravi was running into).
22177 (ArrayCreation.UpdateIndices): Arrays might be empty.
22179 (MemberAccess.ResolveMemberAccess): Add support for section
22180 14.5.4.1 that deals with the special case of E.I when E is a type
22181 and something else, that I can be a reference to a static member.
22183 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
22184 handle a particular array type to create byte blobs, it is just
22185 something we dont generate byteblobs for.
22187 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
22190 * location.cs (Push): remove the key from the hashtable that we
22191 are about to add. This happens for empty files.
22193 * driver.cs: Dispose files after we have parsed them.
22195 (tokenize): new function that only runs the tokenizer on its
22196 input, for speed testing.
22198 2001-12-26 Ravi Pratap <ravi@ximian.com>
22200 * class.cs (Event.Define): Define the private field only if there
22201 are no accessors defined.
22203 * expression.cs (ResolveMemberAccess): If there is no associated
22204 field with the event, that means we have an event defined with its
22205 own accessors and we should flag error cs0070 since transforming
22206 ourselves into a field is not valid in that case.
22208 * ecore.cs (SimpleName.DoResolve): Same as above.
22210 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
22211 and charset to sane values.
22213 2001-12-25 Ravi Pratap <ravi@ximian.com>
22215 * assign.cs (DoResolve): Perform check on events only if they
22216 are being accessed outside the declaring type.
22218 * cs-parser.jay (event_declarations): Update rules to correctly
22219 set the type of the implicit parameter etc.
22221 (add_accessor, remove_accessor): Set current local parameters.
22223 * expression.cs (Binary): For delegate addition and subtraction,
22224 cast the return value from the method into the appropriate delegate
22227 2001-12-24 Ravi Pratap <ravi@ximian.com>
22229 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
22230 of these as the workaround is unnecessary.
22232 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
22233 delegate data - none of that is needed at all.
22235 Re-write bits to extract the instance expression and the delegate method
22238 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
22241 * attribute.cs (ApplyAttributes): New method to take care of common tasks
22242 of attaching attributes instead of duplicating code everywhere.
22244 * everywhere : Update code to do attribute emission using the above method.
22246 2001-12-23 Miguel de Icaza <miguel@ximian.com>
22248 * expression.cs (IsParamsMethodApplicable): if there are not
22249 parameters, return immediately.
22251 * ecore.cs: The 0 literal can be implicity converted to an enum
22254 (SimpleName.DoResolve): First lookup the type, then lookup the
22257 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
22258 want to get its address. If the InstanceExpression is not
22259 addressable, store the result in a temporary variable, then get
22262 * codegen.cs: Only display 219 errors on warning level or above.
22264 * expression.cs (ArrayAccess): Make it implement the
22265 IMemoryLocation interface.
22267 (Binary.DoResolve): handle the operator == (object a, object b)
22268 and operator != (object a, object b) without incurring into a
22269 BoxedCast (because 5 != o should never be performed).
22271 Handle binary enumerator operators.
22273 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
22274 value type, otherwise use Ldelem_ref.
22276 Use precomputed names;
22278 (AddressOf): Implement address of
22280 * cs-parser.jay (labeled_statement): Fix recursive block
22281 addition by reworking the production.
22283 * expression.cs (New.DoEmit): New has a special case:
22285 If we are dealing with a ValueType, we have a few
22286 situations to deal with:
22288 * The target of New is a ValueType variable, that is
22289 easy, we just pass this as the variable reference
22291 * The target of New is being passed as an argument,
22292 to a boxing operation or a function that takes a
22295 In this case, we need to create a temporary variable
22296 that is the argument of New.
22299 2001-12-23 Ravi Pratap <ravi@ximian.com>
22301 * rootcontext.cs (LookupType): Check that current_type is not null before
22302 going about looking at nested types.
22304 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
22305 not implement the IAssignMethod interface any more.
22307 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
22308 where we tranform them into FieldExprs if they are being resolved from within
22309 the declaring type.
22311 * ecore.cs (SimpleName.DoResolve): Do the same here.
22313 * assign.cs (DoResolve, Emit): Clean up code considerably.
22315 * ../errors/bug10.cs : Add.
22317 * ../errors/cs0070.cs : Add.
22319 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
22321 * assign.cs : Get rid of EventIsLocal everywhere.
22323 2001-12-23 Miguel de Icaza <miguel@ximian.com>
22325 * ecore.cs (ConvertIntLiteral): finished the implementation.
22327 * statement.cs (SwitchLabel): Convert the value we are using as a
22328 key before looking up the table.
22330 2001-12-22 Miguel de Icaza <miguel@ximian.com>
22332 * codegen.cs (EmitTopBlock): Require a Location argument now.
22334 * cs-parser.jay (constructor_declarator): We need to setup
22335 current_local_parameters before we parse the
22336 opt_constructor_initializer, to allow the variables to be bound
22337 to the constructor arguments.
22339 * rootcontext.cs (LookupType): First lookup nested classes in our
22340 class and our parents before we go looking outside our class.
22342 * expression.cs (ConstantFold): Extract/debox the values at the
22345 * rootcontext.cs (EmitCode): Resolve the constants first before we
22346 resolve the types. This is not really needed, but it helps debugging.
22348 * statement.cs: report location.
22350 * cs-parser.jay: pass location to throw statement.
22352 * driver.cs: Small bug fix.
22354 * report.cs: Updated format to be 4-zero filled digits.
22356 2001-12-22 Ravi Pratap <ravi@ximian.com>
22358 * expression.cs (CheckIndices): Fix minor bug where the wrong
22359 variable was being referred to ;-)
22361 (DoEmit): Do not call EmitStaticInitializers when the
22362 underlying type is System.Object.
22364 2001-12-21 Ravi Pratap <ravi@ximian.com>
22366 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
22367 and do the usual workaround for SRE.
22369 * class.cs (MyEventBuilder.EventType): New member to get at the type
22370 of the event, quickly.
22372 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
22374 * assign.cs (Assign.DoResolve): Handle the case when the target
22375 is an EventExpr and perform the necessary checks.
22377 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
22380 (SimpleName.MemberStaticCheck): Include check for EventExpr.
22382 (EventExpr): Set the type in the constructor itself since we
22383 are meant to be born fully resolved.
22385 (EventExpr.Define): Revert code I wrote earlier.
22387 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
22388 instance expression is null. The instance expression is a This in that case
22389 or a null, depending on whether it is a static method or not.
22391 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
22392 refers to more than one method.
22394 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
22395 and accordingly flag errors.
22397 2001-12-21 Miguel de Icaza <miguel@ximian.com>
22399 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
22401 2001-12-22 Miguel de Icaza <miguel@ximian.com>
22403 * location.cs (ToString): Provide useful rutine.
22405 2001-12-21 Miguel de Icaza <miguel@ximian.com>
22407 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
22408 objects, return the actual integral boxed.
22410 * statement.cs (SwitchLabel): define an ILLabel for each
22413 (Switch.CheckSwitch): If the value is a Literal, extract
22414 the underlying literal.
22416 Also in the unused hashtable we had, add the SwitchLabel so we can
22417 quickly look this value up.
22419 * constant.cs: Implement a bunch of new constants. Rewrite
22420 Literal based on this. Made changes everywhere to adapt to this.
22422 * expression.cs (Expression.MakeByteBlob): Optimize routine by
22423 dereferencing array only once, and also copes with enumrations.
22425 bytes are two bytes wide, not one.
22427 (Cast): Perform constant conversions.
22429 * ecore.cs (TryImplicitIntConversion): Return literals instead of
22430 wrappers to the literals here.
22432 * expression.cs (DoNumericPromotions): long literals can converted
22433 to ulong implicity (this is taken care of elsewhere, but I was
22434 missing this spot).
22436 * ecore.cs (Expression.Literalize): Make the return type Literal,
22437 to improve type checking.
22439 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
22441 2001-12-20 Miguel de Icaza <miguel@ximian.com>
22443 * literal.cs: Revert code from ravi that checked the bounds. The
22444 bounds are sane by the definition of the type itself.
22446 * typemanager.cs: Fix implementation of ImplementsInterface. We
22447 need to actually look up in our parent hierarchy for interfaces
22450 * const.cs: Use the underlying type for enumerations
22452 * delegate.cs: Compute the basename for the delegate creation,
22453 that should fix the delegate test case, and restore the correct
22454 Type Lookup semantics in rootcontext
22456 * rootcontext.cs: Revert Ravi's last patch. The correct way of
22457 referencing a nested type with the Reflection API is using the "+"
22460 * cs-parser.jay: Do not require EOF token at the end.
22462 2001-12-20 Ravi Pratap <ravi@ximian.com>
22464 * rootcontext.cs (LookupType): Concatenate type names with
22465 a '.' instead of a '+' The test suite passes again.
22467 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
22468 field of the enumeration.
22470 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
22471 the case when the member is an EventExpr.
22473 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
22474 static has an associated instance expression.
22476 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
22478 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
22480 * class.cs (Event.Define): Register event and perform appropriate checks
22483 We define the Add and Remove methods even if the use provides none because
22484 in that case, we provide default implementations ourselves.
22486 Define a private field of the type of the event. This is done by the CSC compiler
22487 and we should be doing it too ;-)
22489 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
22490 More methods we use in code we generate.
22492 (multicast_delegate_type, delegate_type): Two separate types since the distinction
22495 (InitCoreTypes): Update accordingly for the above.
22497 * class.cs (Event.Emit): Generate code for default accessors that we provide
22499 (EmitDefaultMethod): Do the job in the above.
22501 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
22504 2001-12-20 Miguel de Icaza <miguel@ximian.com>
22506 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
22507 builders even if we were missing one.
22509 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
22510 pass the Basename as our class name instead of the Name. The
22511 basename will be correctly composed for us.
22513 * parameter.cs (Paramters): Now takes a Location argument.
22515 * decl.cs (DeclSpace.LookupType): Removed convenience function and
22516 make all the code call directly LookupType in RootContext and take
22517 this chance to pass the Location information everywhere.
22519 * Everywhere: pass Location information.
22521 2001-12-19 Miguel de Icaza <miguel@ximian.com>
22523 * class.cs (Constructor.Define): Updated way of detecting the
22524 length of the parameters.
22526 (TypeContainer.DefineType): Use basename as the type name for
22529 (TypeContainer.Define): Do not recursively define types here, as
22530 definition is taken care in order by the RootContext.
22532 * tree.cs: Keep track of namespaces in a per-file basis.
22534 * parameter.cs (Parameter.ComputeSignature): Update to use
22537 (Parameters.GetSignature): ditto.
22539 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
22540 instead of a TypeContainer.
22542 (Interface.SemanticAnalysis): Use `this' instead of our parent to
22543 resolve names. Because we need to be resolve in our context, not
22546 * driver.cs: Implement response files.
22548 * class.cs (TypeContainer.DefineType): If we are defined, do not
22549 redefine ourselves.
22551 (Event.Emit): Emit the code for add/remove handlers.
22552 (Event.Define): Save the MethodBuilders for add/remove.
22554 * typemanager.cs: Use pair here too.
22556 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
22557 DictionaryEntry requires the first argument to be non-null.
22559 (enum_declaration): Compute full name for registering the
22562 (delegate_declaration): Instead of using
22563 formal_parameter_list, use opt_formal_parameter_list as the list
22566 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
22567 (EventParsing): New property that controls whether `add' and
22568 `remove' are returned as tokens or identifiers (for events);
22570 2001-12-19 Ravi Pratap <ravi@ximian.com>
22572 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
22573 use MyEventBuilder only and let it wrap the real builder for us.
22575 (MyEventBuilder): Revamp constructor etc.
22577 Implement all operations that we perform on EventBuilder in precisely the same
22580 (FindMembers): Update to use the EventBuilder member.
22582 (Event.Emit): Update accordingly.
22584 2001-12-18 Ravi Pratap <ravi@ximian.com>
22586 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
22587 by calling the appropriate methods.
22589 (GetCustomAttributes): Make stubs as they cannot possibly do anything
22592 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
22594 2001-12-17 Ravi Pratap <ravi@ximian.com>
22596 * delegate.cs (Delegate.Populate): Check that the return type
22597 and various parameters types are indeed accessible.
22599 * class.cs (Constructor.Define): Same here.
22601 (Field.Define): Ditto.
22603 (Event.Define): Ditto.
22605 (Operator.Define): Check that the underlying Method defined itself
22606 correctly - so it's MethodBuilder should not be null.
22608 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
22609 expression happens to be null.
22611 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
22612 members but as of now we don't seem to be able to do anything really useful with it.
22614 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
22615 not the EventBuilder.
22617 2001-12-18 Miguel de Icaza <miguel@ximian.com>
22619 * cs-tokenizer.cs: Add support for defines.
22620 Add support for #if, #elif, #else, #endif
22622 (eval_var): evaluates a variable.
22623 (eval): stubbed for evaluating functions.
22625 * cs-parser.jay: Pass the defines information
22627 * driver.cs: Add --define command line option.
22629 * decl.cs: Move MemberCore here.
22631 Make it the base class for DeclSpace. This allows us to catch and
22632 report 108 and 109 for everything now.
22634 * class.cs (TypeContainer.Define): Extract all the members
22635 before populating and emit the warning 108 (new keyword required
22636 to override) instead of having each member implement this.
22638 (MemberCore.Define): New abstract method, we will be using this in
22639 the warning reporting engine in Populate.
22641 (Operator.Define): Adjust to new MemberCore protocol.
22643 * const.cs (Const): This does not derive from Expression, it is a
22644 temporary object we use to create fields, it is a MemberCore.
22646 * class.cs (Method.Define): Allow the entry point to be in a
22649 * driver.cs: Rewrite the argument handler to clean it up a bit.
22651 * rootcontext.cs: Made it just an auxiliary namespace feature by
22652 making everything static.
22654 * driver.cs: Adapt code to use RootContext type name instead of
22657 * delegate.cs: Remove RootContext argument.
22659 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
22662 * class.cs (Event.Define): The lookup can fail.
22664 * cs-tokenizer.cs: Begin implementation of pre-procesor.
22666 * expression.cs: Resolve the this instance before invoking the code.
22668 2001-12-17 Miguel de Icaza <miguel@ximian.com>
22670 * cs-parser.jay: Add a production in element_access that allows
22671 the thing to become a "type" reference. This way we can parse
22672 things like "(string [])" as a type.
22674 Note that this still does not handle the more complex rules of
22678 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
22680 * ecore.cs: (CopyNewMethods): new utility function used to
22681 assemble the list of methods from running FindMembers.
22683 (MemberLookup): Rework FindMembers so that
22685 2001-12-16 Miguel de Icaza <miguel@ximian.com>
22687 * class.cs (TypeContainer): Remove Delegates who fail to be
22690 * delegate.cs (Populate): Verify that we dont get null return
22691 values. TODO: Check for AsAccessible.
22693 * cs-parser.jay: Use basename to emit error 574 (destructor should
22694 have the same name as container class), not the full name.
22696 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
22697 possible representation.
22699 Also implements integer type suffixes U and L.
22701 2001-12-15 Miguel de Icaza <miguel@ximian.com>
22703 * expression.cs (ArrayCreation.DoResolve): We need to do the
22704 argument resolution *always*.
22706 * decl.cs: Make this hold the namespace. Hold the root context as
22708 (LookupType): Move here.
22710 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
22712 * location.cs (Row, Name): Fixed the code, it was always returning
22713 references to the first file.
22715 * interface.cs: Register properties defined through interfaces.
22717 * driver.cs: Add support for globbing on the command line
22719 * class.cs (Field): Make it derive from MemberCore as well.
22722 2001-12-15 Ravi Pratap <ravi@ximian.com>
22724 * class.cs (Event::Define): Check that the type of the event is a delegate
22725 type else flag error #66.
22727 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
22730 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
22731 values of EntryPoint, CharSet etc etc.
22733 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
22735 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
22736 be null and we should ignore this. I am not sure if this is really clean. Apparently,
22737 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
22738 which needs this to do its work.
22740 * ../errors/cs0066.cs : Add.
22742 2001-12-14 Miguel de Icaza <miguel@ximian.com>
22744 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
22747 * class.cs: (MethodSignature.MethodSignature): Removed hack that
22748 clears out the parameters field.
22749 (MemberSignatureCompare): Cleanup
22751 (MemberCore): New base class used to share code between MethodCore
22754 (RegisterRequiredImplementations) BindingFlags.Public requires
22755 either BindingFlags.Instace or Static. Use instance here.
22757 (Property): Refactored code to cope better with the full spec.
22759 * parameter.cs (GetParameterInfo): Return an empty array instead
22762 * class.cs (Property): Abstract or extern properties have no bodies.
22764 * parameter.cs (GetParameterInfo): return a zero-sized array.
22766 * class.cs (TypeContainer.MethodModifiersValid): Move all the
22767 method modifier validation to the typecontainer so we can reuse
22768 this on properties.
22770 (MethodCore.ParameterTypes): return an empty sized array of types.
22772 (Property.Define): Test property modifier validity.
22774 Add tests for sealed/override too.
22776 (Method.Emit): abstract or extern methods have no bodies.
22778 2001-12-14 Ravi Pratap <ravi@ximian.com>
22780 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
22783 (Method::Define, ::Emit): Modify accordingly.
22785 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
22787 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
22789 * makefile: Pass in /unsafe.
22791 2001-12-13 Miguel de Icaza <miguel@ximian.com>
22793 * class.cs (MakeKey): Kill routine.
22795 * class.cs (TypeContainer.Define): Correctly define explicit
22796 method implementations (they require the full interface name plus
22799 * typemanager.cs: Deply the PtrHashtable here and stop using the
22800 lame keys. Things work so much better.
22802 This of course broke everyone who depended on `RegisterMethod' to
22803 do the `test for existance' test. This has to be done elsewhere.
22805 * support.cs (PtrHashtable): A hashtable that avoid comparing with
22806 the object stupid Equals method (because, that like fails all over
22807 the place). We still do not use it.
22809 * class.cs (TypeContainer.SetRequiredInterface,
22810 TypeContainer.RequireMethods): Killed these two routines and moved
22811 all the functionality to RegisterRequiredImplementations.
22813 (TypeContainer.RegisterRequiredImplementations): This routine now
22814 registers all the implementations required in an array for the
22815 interfaces and abstract methods. We use an array of structures
22816 which can be computed ahead of time to reduce memory usage and we
22817 also assume that lookups are cheap as most classes will not
22818 implement too many interfaces.
22820 We also avoid creating too many MethodSignatures.
22822 (TypeContainer.IsInterfaceMethod): Update and optionally does not
22823 clear the "pending" bit if we find that there are problems with
22826 (TypeContainer.VerifyPendingMethods): Update to report errors of
22827 methods that look like implementations but are not.
22829 (TypeContainer.Define): Add support for explicit interface method
22832 2001-12-12 Miguel de Icaza <miguel@ximian.com>
22834 * typemanager.cs: Keep track of the parameters here instead of
22835 being a feature of the TypeContainer.
22837 * class.cs: Drop the registration of parameters here, as
22838 InterfaceMethods are also interface declarations.
22840 * delegate.cs: Register methods with the TypeManager not only with
22841 the TypeContainer. This code was buggy.
22843 * interface.cs: Full registation here.
22845 2001-12-11 Miguel de Icaza <miguel@ximian.com>
22847 * expression.cs: Remove reducer for binary expressions, it can not
22850 * const.cs: Put here the code that used to go into constant.cs
22852 * constant.cs: Put here the code for constants, this is a new base
22853 class for Literals.
22855 * literal.cs: Make Literal derive from Constant.
22857 2001-12-09 Miguel de Icaza <miguel@ximian.com>
22859 * statement.cs (Return.Emit): Report error 157 if the user
22860 attempts to return from a finally block.
22862 (Return.Emit): Instead of emitting a return, jump to the end of
22865 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
22866 LocalBuilder to store the result of the function. ReturnLabel is
22867 the target where we jump.
22870 2001-12-09 Radek Doulik <rodo@ximian.com>
22872 * cs-parser.jay: remember alias in current namespace
22874 * ecore.cs (SimpleName::DoResolve): use aliases for types or
22877 * class.cs (LookupAlias): lookup alias in my_namespace
22879 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
22881 (LookupAlias): lookup alias in this and if needed in parent
22884 2001-12-08 Miguel de Icaza <miguel@ximian.com>
22888 * rootcontext.cs: (ModuleBuilder) Made static, first step into
22889 making things static. I need this to avoid passing the
22890 TypeContainer when calling ParameterType.
22892 * support.cs (InternalParameters.ParameterType): Remove ugly hack
22893 that did string manipulation to compute the type and then call
22894 GetType. Use Parameter.ParameterType instead.
22896 * cs-tokenizer.cs: Consume the suffix for floating values.
22898 * expression.cs (ParameterReference): figure out whether this is a
22899 reference parameter or not. Kill an extra variable by computing
22900 the arg_idx during emission.
22902 * parameter.cs (Parameters.GetParameterInfo): New overloaded
22903 function that returns whether a parameter is an out/ref value or not.
22905 (Parameter.ParameterType): The type of the parameter (base,
22906 without ref/out applied).
22908 (Parameter.Resolve): Perform resolution here.
22909 (Parameter.ExternalType): The full type (with ref/out applied).
22911 * statement.cs (Using.Emit, Using.EmitExpression): Implement
22912 support for expressions on the using statement.
22914 2001-12-07 Miguel de Icaza <miguel@ximian.com>
22916 * statement.cs (Using.EmitLocalVariableDecls): Split the
22917 localvariable handling of the using statement.
22919 (Block.EmitMeta): Keep track of variable count across blocks. We
22920 were reusing slots on separate branches of blocks.
22922 (Try.Emit): Emit the general code block, we were not emitting it.
22924 Check the type of the declaration to be an IDisposable or
22925 something that can be implicity converted to it.
22927 Emit conversions if required.
22929 * ecore.cs (EmptyExpression): New utility class.
22930 (Expression.ImplicitConversionExists): New utility function.
22932 2001-12-06 Miguel de Icaza <miguel@ximian.com>
22934 * statement.cs (Using): Implement.
22936 * expression.cs (LocalVariableReference): Support read only variables.
22938 * statement.cs: Remove the explicit emit for the Leave opcode.
22939 (VariableInfo): Add a readonly field.
22941 2001-12-05 Miguel de Icaza <miguel@ximian.com>
22943 * ecore.cs (ConvCast): new class used to encapsulate the various
22944 explicit integer conversions that works in both checked and
22945 unchecked contexts.
22947 (Expression.ConvertNumericExplicit): Use new ConvCast class to
22948 properly generate the overflow opcodes.
22950 2001-12-04 Miguel de Icaza <miguel@ximian.com>
22952 * statement.cs: The correct type for the EmptyExpression is the
22953 element_type, not the variable type. Ravi pointed this out.
22955 2001-12-04 Ravi Pratap <ravi@ximian.com>
22957 * class.cs (Method::Define): Handle PInvoke methods specially
22958 by using DefinePInvokeMethod instead of the usual one.
22960 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
22961 above to do the task of extracting information and defining the method.
22963 2001-12-04 Ravi Pratap <ravi@ximian.com>
22965 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
22966 of the condition for string type.
22968 (Emit): Move that here.
22970 (ArrayCreation::CheckIndices): Keep string literals in their expression
22973 (EmitDynamicInitializers): Handle strings appropriately.
22975 2001-12-04 Miguel de Icaza <miguel@ximian.com>
22977 * codegen.cs (EmitContext): Replace multiple variables with a
22978 single pointer to the current Switch statement.
22980 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
22983 2001-12-03 Miguel de Icaza <miguel@ximian.com>
22987 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
22990 (Foreach.Emit): Foreach on arrays was not setting
22991 up the loop variables (for break/continue).
22993 (GotoCase): Semi-implented.
22995 2001-12-03 Ravi Pratap <ravi@ximian.com>
22997 * attribute.cs (CheckAttribute): Handle system attributes by using
22998 Attribute.GetAttributes to examine information we need.
23000 (GetValidPlaces): Same here.
23002 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
23004 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
23006 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
23008 (Method::Define): Set appropriate flags if we have a DllImport attribute.
23010 (Method::Emit): Handle the case when we are a PInvoke method.
23012 2001-12-03 Miguel de Icaza <miguel@ximian.com>
23014 * expression.cs: Use ResolveWithSimpleName on compound names.
23016 2001-12-02 Ravi Pratap <ravi@ximian.com>
23018 * constant.cs (EmitConstant): Make sure we resolve the associated expression
23019 before trying to reduce it.
23021 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
23023 * constant.cs (LookupConstantValue): Implement.
23025 (EmitConstant): Use the above in emitting the constant.
23027 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
23028 that are user-defined by doing a LookupConstantValue on them.
23030 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
23033 2001-11-29 Miguel de Icaza <miguel@ximian.com>
23035 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
23037 (BaseAccess.DoResolve): Implement.
23039 (MemberAccess.DoResolve): Split this routine into a
23040 ResolveMemberAccess routine that can be used independently
23042 2001-11-28 Miguel de Icaza <miguel@ximian.com>
23044 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
23045 As that share bits of the implementation. Is returns a boolean,
23046 while As returns the Type that is being probed.
23048 2001-12-01 Ravi Pratap <ravi@ximian.com>
23050 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
23051 instead of a Literal - much easier.
23053 (EnumInTransit): Remove - utterly useless :-)
23055 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
23057 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
23059 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
23060 chain when we have no associated expression.
23062 2001-11-30 Ravi Pratap <ravi@ximian.com>
23064 * constant.cs (Define): Use Location while reporting the errror.
23066 Also emit a warning when 'new' is used and there is no inherited
23069 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
23072 (LookupEnumValue): Implement to lookup an enum member's value and define it
23075 (Populate): Re-write accordingly to use the above routine.
23077 2001-11-27 Miguel de Icaza <miguel@ximian.com>
23079 * expression.cs (This): Fix prototype for DoResolveLValue to
23080 override the base class DoResolveLValue.
23082 * cs-parser.cs: Report errors cs574 and cs575 (destructor
23085 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
23086 (we need to load the address of the field here). This fixes
23089 (FieldExpr.DoResolveLValue): Call the DoResolve
23090 function to initialize the Instance expression.
23092 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
23093 correctly the GetEnumerator operation on a value type.
23095 * cs-parser.jay: Add more simple parsing error catches.
23097 * statement.cs (Switch): Add support for string switches.
23098 Handle null specially.
23100 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
23102 2001-11-28 Ravi Pratap <ravi@ximian.com>
23104 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
23106 (declare_local_constant): New helper function.
23108 * statement.cs (AddConstant): Keep a separate record of constants
23110 (IsConstant): Implement to determine if a variable is a constant.
23112 (GetConstantExpression): Implement.
23114 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
23116 * statement.cs (IsVariableDefined): Re-write.
23118 2001-11-27 Ravi Pratap <ravi@ximian.com>
23120 * class.cs (TypeContainer::FindMembers): Look for constants
23121 in the case when we are looking for MemberTypes.Field
23123 * expression.cs (MemberAccess::DoResolve): Check that in the
23124 case we are a FieldExpr and a Literal, we are not being accessed
23125 by an instance reference.
23127 * cs-parser.jay (local_constant_declaration): Implement.
23129 (declaration_statement): Implement for constant declarations.
23131 2001-11-26 Miguel de Icaza <miguel@ximian.com>
23133 * statement.cs (Switch): Catch double defaults.
23135 (Switch): More work on the switch() statement
23136 implementation. It works for integral values now, need to finish
23140 2001-11-24 Miguel de Icaza <miguel@ximian.com>
23142 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
23143 integer literals into other integer literals. To be used by
23146 2001-11-24 Ravi Pratap <ravi@ximian.com>
23148 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
23151 (EmitDynamicInitializers): Cope with the above since we extract data
23152 directly from ArrayData now.
23154 (ExpectInitializers): Keep track of whether initializers are mandatory
23157 (Bounds): Make it a hashtable to prevent the same dimension being
23158 recorded for every element in that dimension.
23160 (EmitDynamicInitializers): Fix bug which prevented the Set array method
23163 Also fix bug which was causing the indices to be emitted in the reverse
23166 2001-11-24 Miguel de Icaza <miguel@ximian.com>
23168 * expression.cs (ArrayCreation): Implement the bits that Ravi left
23169 unfinished. They do not work, because the underlying code is
23172 2001-11-22 Miguel de Icaza <miguel@ximian.com>
23174 * cs-parser.jay: Remove bogus fixme.
23176 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
23177 on Switch statement.
23179 2001-11-23 Ravi Pratap <ravi@ximian.com>
23181 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
23184 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
23185 parameter. Apparently, any expression is allowed.
23187 (ValidateInitializers): Update accordingly.
23189 (CheckIndices): Fix some tricky bugs thanks to recursion.
23191 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
23192 I was being completely brain-dead.
23194 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
23195 and re-write acordingly.
23197 (DelegateInvocation): Re-write accordingly.
23199 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
23201 (MakeByteBlob): Handle types more correctly.
23203 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
23204 initialization from expressions but it is incomplete because I am a complete
23207 2001-11-22 Miguel de Icaza <miguel@ximian.com>
23209 * statement.cs (If.Emit): Fix a bug that generated incorrect code
23210 on If. Basically, we have to return `true' (ie, we do return to
23211 our caller) only if both branches of the if return.
23213 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
23214 short-circuit operators, handle them as short circuit operators.
23216 (Cast.DoResolve): Resolve type.
23217 (Cast.Cast): Take an expression as the target type.
23219 * cs-parser.jay (cast_expression): Remove old hack that only
23220 allowed a limited set of types to be handled. Now we take a
23221 unary_expression and we resolve to a type during semantic
23224 Use the grammar productions from Rhys to handle casts (this is
23225 not complete like Rhys syntax yet, we fail to handle that corner
23226 case that C# has regarding (-x), but we will get there.
23228 2001-11-22 Ravi Pratap <ravi@ximian.com>
23230 * class.cs (EmitFieldInitializer): Take care of the case when we have a
23231 field which is an array type.
23233 * cs-parser.jay (declare_local_variables): Support array initialization too.
23235 * typemanager.cs (MakeKey): Implement.
23237 (everywhere): Use the above appropriately.
23239 * cs-parser.jay (for_statement): Update for array initialization while
23240 declaring variables.
23242 * ecore.cs : The error message was correct, it's the variable's names that
23243 were misleading ;-) Make the code more readable.
23245 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
23246 the correct type etc.
23248 (ConvertExplicit): Handle Enum types by examining the underlying type.
23250 2001-11-21 Ravi Pratap <ravi@ximian.com>
23252 * parameter.cs (GetCallingConvention): Always return
23253 CallingConventions.Standard for now.
23255 2001-11-22 Miguel de Icaza <miguel@ximian.com>
23257 * expression.cs (Binary.ResolveOperator): Update the values of `l'
23258 and `r' after calling DoNumericPromotions.
23260 * ecore.cs: Fix error message (the types were in the wrong order).
23262 * statement.cs (Foreach.ProbeCollectionType): Need to pass
23263 BindingFlags.Instance as well
23265 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
23266 implicit int literal conversion in an empty cast so that we
23267 propagate the right type upstream.
23269 (UnboxCast): new class used to unbox value types.
23270 (Expression.ConvertExplicit): Add explicit type conversions done
23273 (Expression.ImplicitNumericConversion): Oops, forgot to test for
23274 the target type before applying the implicit LongLiterals to ULong
23277 2001-11-21 Miguel de Icaza <miguel@ximian.com>
23279 * cs-parser.jay (for_statement): Reworked the way For works: now
23280 we declare manually any variables that are introduced in
23281 for_initializer to solve the problem of having out-of-band code
23282 emition (that is what got for broken).
23284 (declaration_statement): Perform the actual variable declaration
23285 that used to be done in local_variable_declaration here.
23287 (local_variable_declaration): Do not declare anything, just pass
23288 the information on a DictionaryEntry
23290 2001-11-20 Ravi Pratap <ravi@ximian.com>
23292 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
23293 re-write of the logic to now make it recursive.
23295 (UpdateIndices): Re-write accordingly.
23297 Store element data in a separate ArrayData list in the above methods.
23299 (MakeByteBlob): Implement to dump the array data into a byte array.
23301 2001-11-19 Ravi Pratap <ravi@ximian.com>
23303 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
23306 * constant.cs (Define): Implement.
23308 (EmitConstant): Re-write fully.
23310 Pass in location info.
23312 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
23315 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
23316 DictionaryEntry since we need location info too.
23318 (constant_declaration): Update accordingly.
23320 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
23321 code into another method : UpdateIndices.
23323 2001-11-18 Ravi Pratap <ravi@ximian.com>
23325 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
23326 some type checking etc.
23328 2001-11-17 Ravi Pratap <ravi@ximian.com>
23330 * expression.cs (ArrayCreation::ValidateInitializers): Implement
23331 bits to provide dimension info if the user skips doing that.
23333 Update second constructor to store the rank correctly.
23335 2001-11-16 Ravi Pratap <ravi@ximian.com>
23337 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
23338 and try to implement.
23340 * ../errors/cs0150.cs : Add.
23342 * ../errors/cs0178.cs : Add.
23344 2001-11-16 Miguel de Icaza <miguel@ximian.com>
23346 * statement.cs: Implement foreach on multi-dimensional arrays.
23348 * parameter.cs (Parameters.GetParameterByName): Also lookup the
23349 name of the params argument.
23351 * expression.cs: Use EmitStoreOpcode to get the right opcode while
23352 initializing the array.
23354 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
23355 we can use this elsewhere.
23357 * statement.cs: Finish implementation of foreach for single
23360 * cs-parser.jay: Use an out-of-band stack to pass information
23361 around, I wonder why I need this.
23363 foreach_block: Make the new foreach_block the current_block.
23365 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
23366 function used to return a static Parameters structure. Used for
23367 empty parameters, as those are created very frequently.
23369 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
23371 2001-11-15 Ravi Pratap <ravi@ximian.com>
23373 * interface.cs : Default modifier is private, not public. The
23374 make verify test passes again.
23376 2001-11-15 Ravi Pratap <ravi@ximian.com>
23378 * support.cs (ReflectionParameters): Fix logic to determine
23379 whether the last parameter is a params one. Test 9 passes again.
23381 * delegate.cs (Populate): Register the builders we define with
23382 RegisterParameterForBuilder. Test 19 passes again.
23384 * cs-parser.jay (property_declaration): Reference $6 instead
23385 of $$ to get at the location.
23387 (indexer_declaration): Similar stuff.
23389 (attribute): Ditto.
23391 * class.cs (Property): Register parameters for the Get and Set methods
23392 if they exist. Test 23 passes again.
23394 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
23395 call to EmitArguments as we are sure there aren't any params arguments.
23396 Test 32 passes again.
23398 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
23399 IndexOutOfRangeException.
23401 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
23402 Test 33 now passes again.
23404 2001-11-15 Miguel de Icaza <miguel@ximian.com>
23406 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
23407 broke a bunch of things. Will have to come up with a better way
23408 of tracking locations.
23410 * statement.cs: Implemented foreach for single dimension arrays.
23412 2001-11-09 Miguel de Icaza <miguel@ximian.com>
23414 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
23415 an error. This removes the lookup from the critical path.
23417 * cs-parser.jay: Removed use of temporary_loc, which is completely
23420 2001-11-14 Miguel de Icaza <miguel@ximian.com>
23422 * support.cs (ReflectionParameters.ParameterModifier): Report
23423 whether the argument is a PARAMS argument or not.
23425 * class.cs: Set the attribute `ParamArrayAttribute' on the
23426 parameter argument.
23428 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
23429 and cons_param_array_attribute (ConstructorInfo for
23430 ParamArrayAttribute).,
23432 * codegen.cs: Emit the return using the `Return' statement, that
23433 way we can report the error correctly for missing return values.
23435 * class.cs (Method.Emit): Clean up.
23437 * expression.cs (Argument.Resolve): Take another argument: the
23438 location where this argument is used. Notice that this is not
23439 part of the "Argument" class as to reduce the size of the
23440 structure (we know the approximate location anyways).
23442 Test if the argument is a variable-reference, if not, then
23443 complain with a 206.
23445 (Argument.Emit): Emit addresses of variables.
23447 (Argument.FullDesc): Simplify.
23449 (Invocation.DoResolve): Update for Argument.Resolve.
23451 (ElementAccess.DoResolve): ditto.
23453 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
23454 method should be virtual, as this method is always virtual.
23456 (NewDelegate.DoResolve): Update for Argument.Resolve.
23458 * class.cs (ConstructorInitializer.DoResolve): ditto.
23460 * attribute.cs (Attribute.Resolve): ditto.
23462 2001-11-13 Miguel de Icaza <miguel@ximian.com>
23464 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
23466 * expression.cs (ParameterReference): Drop IStackStorage and implement
23467 IAssignMethod instead.
23469 (LocalVariableReference): ditto.
23471 * ecore.cs (FieldExpr): Drop IStackStorage and implement
23472 IAssignMethod instead.
23474 2001-11-13 Miguel de Icaza <miguel@ximian.com>
23476 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
23477 enumerations that are used in heavily used structures derive from
23478 byte in a laughable and pathetic attempt to reduce memory usage.
23479 This is the kind of pre-optimzations that you should not do at
23480 home without adult supervision.
23482 * expression.cs (UnaryMutator): New class, used to handle ++ and
23483 -- separatedly from the other unary operators. Cleans up the
23484 code, and kills the ExpressionStatement dependency in Unary.
23486 (Unary): Removed `method' and `Arguments' from this class, making
23487 it smaller, and moving it all to SimpleCall, so I can reuse this
23488 code in other locations and avoid creating a lot of transient data
23489 strucutres when not required.
23491 * cs-parser.jay: Adjust for new changes.
23493 2001-11-11 Miguel de Icaza <miguel@ximian.com>
23495 * enum.cs (Enum.Populate): If there is a failure during
23498 * cs-parser.jay (opt_enum_base): we used to catch type errors
23499 here, but this is really incorrect. The type error should be
23500 catched during semantic analysis.
23502 2001-12-11 Ravi Pratap <ravi@ximian.com>
23504 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
23505 current_local_parameters as expected since I, in my stupidity, had forgotten
23508 * attribute.cs (GetValidPlaces): Fix stupid bug.
23510 * class.cs (Method::Emit): Perform check on applicability of attributes.
23512 (Constructor::Emit): Ditto.
23514 (Field::Emit): Ditto.
23516 (Field.Location): Store location information.
23518 (Property, Event, Indexer, Operator): Ditto.
23520 * cs-parser.jay (field_declaration): Pass in location for each field.
23522 * ../errors/cs0592.cs : Add.
23524 2001-11-12 Ravi Pratap <ravi@ximian.com>
23526 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
23528 (InitCoreTypes): Update accordingly.
23530 (RegisterAttrType, LookupAttr): Implement.
23532 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
23533 info about the same.
23535 (Resolve): Update to populate the above as necessary.
23537 (Error592): Helper.
23539 (GetValidPlaces): Helper to the above.
23541 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
23543 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
23545 2001-11-12 Ravi Pratap <ravi@ximian.com>
23547 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
23549 * ../errors/cs0617.cs : Add.
23551 2001-11-11 Ravi Pratap <ravi@ximian.com>
23553 * enum.cs (Emit): Rename to Populate to be more consistent with what
23554 we expect it to do and when exactly it is called.
23556 * class.cs, rootcontext.cs : Update accordingly.
23558 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
23559 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
23561 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
23563 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
23564 of a fieldinfo using the above, when dealing with a FieldBuilder.
23566 2001-11-10 Ravi Pratap <ravi@ximian.com>
23568 * ../errors/cs0031.cs : Add.
23570 * ../errors/cs1008.cs : Add.
23572 * ../errrors/cs0543.cs : Add.
23574 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
23577 (FindMembers): Implement.
23579 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
23580 enums and delegates too.
23582 (enum_types): Rename to builder_to_enum.
23584 (delegate_types): Rename to builder_to_delegate.
23586 * delegate.cs (FindMembers): Implement.
23588 2001-11-09 Ravi Pratap <ravi@ximian.com>
23590 * typemanager.cs (IsEnumType): Implement.
23592 * enum.cs (Emit): Re-write parts to account for the underlying type
23593 better and perform checking etc.
23595 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
23596 of the underlying type.
23598 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
23601 * enum.cs (error31): Helper to report error #31.
23603 * cs-parser.jay (enum_declaration): Store location of each member too.
23605 * enum.cs (member_to_location): New hashtable.
23607 (AddEnumMember): Update location hashtable.
23609 (Emit): Use the location of each member while reporting errors.
23611 2001-11-09 Miguel de Icaza <miguel@ximian.com>
23613 * cs-parser.jay: A for_initializer if is a
23614 local_variable_declaration really ammount to have an implicit
23615 block with the variable declaration and no initializer for for.
23617 * statement.cs (For.Emit): Cope with null initializers.
23619 This fixes the infinite loop on for initializers.
23621 2001-11-08 Miguel de Icaza <miguel@ximian.com>
23623 * enum.cs: More cleanup.
23625 * ecore.cs: Remove dead code.
23627 * class.cs (Property.Emit): More simplification.
23628 (Event.Emit): ditto.
23630 Reworked to have less levels of indentation.
23632 2001-11-08 Ravi Pratap <ravi@ximian.com>
23634 * class.cs (Property): Emit attributes.
23644 * enum.cs (Emit): Ditto.
23646 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
23649 * class.cs (Field, Event, etc.): Move attribute generation into the
23650 Emit method everywhere.
23652 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
23653 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
23654 as we had no way of defining nested enums !
23656 * rootcontext.cs : Adjust code accordingly.
23658 * typemanager.cs (AddEnumType): To keep track of enum types separately.
23660 2001-11-07 Ravi Pratap <ravi@ximian.com>
23662 * expression.cs (EvalConstantExpression): Move into ecore.cs
23664 * enum.cs (Enum): Rename some members and make them public and readonly
23665 according to our convention.
23667 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
23670 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
23672 (Enum::Emit): Write a simple version for now which doesn't try to compute
23673 expressions. I shall modify this to be more robust in just a while.
23675 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
23677 (TypeContainer::CloseType): Create the Enum types too.
23679 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
23681 * expression.cs (EvalConstantExpression): Get rid of completely.
23683 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
23684 user-defined values and other cases.
23686 (IsValidEnumLiteral): Helper function.
23688 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
23689 out there in the case we had a literal FieldExpr.
23691 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
23693 (Literalize): Revamp a bit to take two arguments.
23695 (EnumLiteral): New class which derives from Literal to wrap enum literals.
23697 2001-11-06 Ravi Pratap <ravi@ximian.com>
23699 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
23701 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
23703 (Resolve): Use the above to ensure we have proper initializers.
23705 2001-11-05 Ravi Pratap <ravi@ximian.com>
23707 * expression.cs (Expression::EvalConstantExpression): New method to
23708 evaluate constant expressions.
23710 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
23712 2001-11-07 Miguel de Icaza <miguel@ximian.com>
23714 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
23717 (Binary.ResolveOperator): Handle operator != (object a, object b)
23718 and operator == (object a, object b);
23720 (Binary.DoNumericPromotions): Indicate whether the numeric
23721 promotion was possible.
23723 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
23726 Made the ArrayAccess implement interface IAssignMethod instead of
23727 IStackStore as the order in which arguments are passed reflects
23730 * assign.cs: Instead of using expr.ExprClass to select the way of
23731 assinging, probe for the IStackStore/IAssignMethod interfaces.
23733 * typemanager.cs: Load InitializeArray definition.
23735 * rootcontext.cs (RootContext.MakeStaticData): Used to define
23736 static data that can be used to initialize arrays.
23738 2001-11-05 Miguel de Icaza <miguel@ximian.com>
23740 * expression.cs: Handle operator== and operator!= for booleans.
23742 (Conditioal.Reduce): Implement reducer for the ?: operator.
23744 (Conditional.Resolve): Implement dead code elimination.
23746 (Binary.Resolve): Catch string literals and return a new
23747 concatenated string.
23749 (Unary.Reduce): Implement reduction of unary expressions.
23751 * ecore.cs: Split out the expression core handling here.
23753 (Expression.Reduce): New method used to perform constant folding
23754 and CSE. This is needed to support constant-expressions.
23756 * statement.cs (Statement.EmitBoolExpression): Pass true and false
23757 targets, and optimize for !x.
23759 2001-11-04 Ravi Pratap <ravi@ximian.com>
23761 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
23762 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
23763 set custom atttributes.
23765 * literal.cs (Literal::GetValue): New abstract method to return the actual
23766 value of the literal, cast as an object.
23768 (*Literal): Implement GetValue method.
23770 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
23771 expressions to the arraylist but objects of type Argument.
23773 * class.cs (TypeContainer::Emit): Emit our attributes too.
23775 (Method::Emit, Constructor::Emit): Ditto.
23777 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
23778 to be ignoring earlier.
23780 2001-11-03 Ravi Pratap <ravi@ximian.com>
23782 * attribute.cs (AttributeSection::Define): Implement to do the business
23783 of constructing a CustomAttributeBuilder.
23785 (Attribute): New trivial class. Increases readability of code.
23787 * cs-parser.jay : Update accordingly.
23789 (positional_argument_list, named_argument_list, named_argument): New rules
23791 (attribute_arguments): Use the above so that we are more correct.
23793 2001-11-02 Ravi Pratap <ravi@ximian.com>
23795 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
23796 to perform all checks for a method with a params parameter.
23798 (Invocation::OverloadResolve): Update to use the above method and therefore
23799 cope correctly with params method invocations.
23801 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
23804 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
23805 constructors in our parent too because we can't afford to miss out on
23808 * attribute.cs (AttributeSection): New name for the class Attribute
23810 Other trivial changes to improve readability.
23812 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
23813 use the new class names.
23815 2001-11-01 Ravi Pratap <ravi@ximian.com>
23817 * class.cs (Method::Define): Complete definition for params types too
23819 (Indexer::Define): Ditto.
23821 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
23822 Cope everywhere with a request for info about the array parameter.
23824 2001-11-01 Ravi Pratap <ravi@ximian.com>
23826 * tree.cs (RecordNamespace): Fix up to check for the correct key.
23828 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
23829 local_variable_type to extract the string corresponding to the type.
23831 (local_variable_type): Fixup the action to use the new helper method.
23833 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
23836 * expression.cs : Clean out code which uses the above.
23838 2001-10-31 Ravi Pratap <ravi@ximian.com>
23840 * typemanager.cs (RegisterMethod): Check if we already have an existing key
23841 and bale out if necessary by returning a false.
23843 (RegisterProperty): Ditto.
23845 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
23846 and print out appropriate error messages.
23848 * interface.cs (everywhere): Ditto.
23850 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
23851 location to constructor.
23853 * class.cs (Property, Event, Indexer): Update accordingly.
23855 * ../errors/cs111.cs : Added.
23857 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
23858 of a method, as laid down by the spec.
23860 (Invocation::OverloadResolve): Use the above method.
23862 2001-10-31 Ravi Pratap <ravi@ximian.com>
23864 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
23865 now take a TypeContainer and a Parameters object.
23867 (ParameterData): Modify return type of ParameterModifier method to be
23868 Parameter.Modifier and not a string.
23870 (ReflectionParameters, InternalParameters): Update accordingly.
23872 * expression.cs (Argument::GetParameterModifier): Same here.
23874 * support.cs (InternalParameters::ParameterType): Find a better way of determining
23875 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
23876 symbol in it at all so maybe this is only for now.
23878 2001-10-30 Ravi Pratap <ravi@ximian.com>
23880 * support.cs (InternalParameters): Constructor now takes an extra argument
23881 which is the actual Parameters class.
23883 (ParameterDesc): Update to provide info on ref/out modifiers.
23885 * class.cs (everywhere): Update call to InternalParameters to pass in
23886 the second argument too.
23888 * support.cs (ParameterData): Add ParameterModifier, which is a method
23889 to return the modifier info [ref/out etc]
23891 (InternalParameters, ReflectionParameters): Implement the above.
23893 * expression.cs (Argument::ParameterModifier): Similar function to return
23894 info about the argument's modifiers.
23896 (Invocation::OverloadResolve): Update to take into account matching modifiers
23899 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
23900 a new SetFormalParameters object which we pass to InternalParameters.
23902 2001-10-30 Ravi Pratap <ravi@ximian.com>
23904 * expression.cs (NewArray): Merge into the ArrayCreation class.
23906 2001-10-29 Ravi Pratap <ravi@ximian.com>
23908 * expression.cs (NewArray): Merge classes NewBuiltinArray and
23909 NewUserdefinedArray into one as there wasn't much of a use in having
23912 * expression.cs (Argument): Change field's name to ArgType from Type.
23914 (Type): New readonly property which returns the proper type, taking into
23915 account ref/out modifiers.
23917 (everywhere): Adjust code accordingly for the above.
23919 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
23920 whether we are emitting for a ref or out parameter.
23922 * expression.cs (Argument::Emit): Use the above field to set the state.
23924 (LocalVariableReference::Emit): Update to honour the flag and emit the
23927 * parameter.cs (Attributes): Set the correct flags for ref parameters.
23929 * expression.cs (Argument::FullDesc): New function to provide a full desc.
23931 * support.cs (ParameterData): Add method ParameterDesc to the interface.
23933 (ReflectionParameters, InternalParameters): Implement the above method.
23935 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
23938 (Invocation::FullMethodDesc): Ditto.
23940 2001-10-29 Miguel de Icaza <miguel@ximian.com>
23942 * cs-parser.jay: Add extra production for the second form of array
23945 * expression.cs (ArrayCreation): Update to reflect the above
23948 * Small changes to prepare for Array initialization.
23950 2001-10-28 Miguel de Icaza <miguel@ximian.com>
23952 * typemanager.cs (ImplementsInterface): interface might be null;
23953 Deal with this problem;
23955 Also, we do store negative hits on the cache (null values), so use
23956 this instead of calling t.GetInterfaces on the type everytime.
23958 2001-10-28 Ravi Pratap <ravi@ximian.com>
23960 * typemanager.cs (IsBuiltinType): New method to help determine the same.
23962 * expression.cs (New::DoResolve): Get rid of array creation code and instead
23963 split functionality out into different classes.
23965 (New::FormArrayType): Move into NewBuiltinArray.
23967 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
23970 (NewBuiltinArray): New class to handle creation of built-in arrays.
23972 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
23973 account creation of one-dimensional arrays.
23975 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
23977 (NewUserdefinedArray::DoResolve): Implement.
23979 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
23981 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
23982 we maintain inside the TypeManager. This is necessary to perform lookups on the
23985 (LookupType): Update to perform GetType on the module builders too.
23987 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
23989 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
23991 2001-10-23 Ravi Pratap <ravi@ximian.com>
23993 * expression.cs (New::DoResolve): Implement guts of array creation.
23995 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
23997 2001-10-27 Miguel de Icaza <miguel@ximian.com>
23999 * expression.cs: Fix bug I introduced lsat night that broke
24002 (Expression.Resolve): Report a 246 error (can not resolve name)
24003 if we find a SimpleName in the stream.
24005 (Expression.ResolveLValue): Ditto.
24007 (Expression.ResolveWithSimpleName): This function is a variant of
24008 ResolveName, this one allows SimpleNames to be returned without a
24009 warning. The only consumer of SimpleNames is MemberAccess
24011 2001-10-26 Miguel de Icaza <miguel@ximian.com>
24013 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
24014 might arrive here. I have my doubts that this is correct.
24016 * statement.cs (Lock): Implement lock statement.
24018 * cs-parser.jay: Small fixes to support `lock' and `using'
24020 * cs-tokenizer.cs: Remove extra space
24022 * driver.cs: New flag --checked, allows to turn on integer math
24025 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
24026 Threading.Monitor.Exit
24028 2001-10-23 Miguel de Icaza <miguel@ximian.com>
24030 * expression.cs (IndexerAccess::DoResolveLValue): Set the
24031 Expression Class to be IndexerAccess.
24033 Notice that Indexer::DoResolve sets the eclass to Value.
24035 2001-10-22 Miguel de Icaza <miguel@ximian.com>
24037 * class.cs (TypeContainer::Emit): Emit code for indexers.
24039 * assign.cs (IAssignMethod): New interface implemented by Indexers
24040 and Properties for handling assignment.
24042 (Assign::Emit): Simplify and reuse code.
24044 * expression.cs (IndexerAccess, PropertyExpr): Implement
24045 IAssignMethod, clean up old code.
24047 2001-10-22 Ravi Pratap <ravi@ximian.com>
24049 * typemanager.cs (ImplementsInterface): New method to determine if a type
24050 implements a given interface. Provides a nice cache too.
24052 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
24055 (ConvertReferenceExplicit): Ditto.
24057 * delegate.cs (Delegate::Populate): Update to define the parameters on the
24058 various methods, with correct names etc.
24060 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
24061 Operator.UnaryNegation.
24063 * cs-parser.jay (operator_declarator): Be a little clever in the case where
24064 we have a unary plus or minus operator.
24066 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
24069 * everywhere : update accordingly.
24071 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
24074 * class.cs (Method::Define): For the case where we are implementing a method
24075 inherited from an interface, we need to set the MethodAttributes.Final flag too.
24076 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
24078 2001-10-21 Ravi Pratap <ravi@ximian.com>
24080 * interface.cs (FindMembers): Implement to work around S.R.E
24083 * typemanager.cs (IsInterfaceType): Implement.
24085 (FindMembers): Update to handle interface types too.
24087 * expression.cs (ImplicitReferenceConversion): Re-write bits which
24088 use IsAssignableFrom as that is not correct - it doesn't work.
24090 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
24091 and accordingly override EmitStatement.
24093 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
24094 using the correct logic :-)
24096 2001-10-19 Ravi Pratap <ravi@ximian.com>
24098 * ../errors/cs-11.cs : Add to demonstrate error -11
24100 2001-10-17 Miguel de Icaza <miguel@ximian.com>
24102 * assign.cs (Assign::Resolve): Resolve right hand side first, and
24103 then pass this as a hint to ResolveLValue.
24105 * expression.cs (FieldExpr): Add Location information
24107 (FieldExpr::LValueResolve): Report assignment to readonly
24110 (Expression::ExprClassFromMemberInfo): Pass location information.
24112 (Expression::ResolveLValue): Add new method that resolves an
24115 (Expression::DoResolveLValue): Default invocation calls
24118 (Indexers): New class used to keep track of indexers in a given
24121 (IStackStore): Renamed from LValue, as it did not really describe
24122 what this did. Also ResolveLValue is gone from this interface and
24123 now is part of Expression.
24125 (ElementAccess): Depending on the element access type
24127 * typemanager.cs: Add `indexer_name_type' as a Core type
24128 (System.Runtime.CompilerServices.IndexerNameAttribute)
24130 * statement.cs (Goto): Take a location.
24132 2001-10-18 Ravi Pratap <ravi@ximian.com>
24134 * delegate.cs (Delegate::VerifyDelegate): New method to verify
24135 if two delegates are compatible.
24137 (NewDelegate::DoResolve): Update to take care of the case when
24138 we instantiate a delegate from another delegate.
24140 * typemanager.cs (FindMembers): Don't even try to look up members
24141 of Delegate types for now.
24143 2001-10-18 Ravi Pratap <ravi@ximian.com>
24145 * delegate.cs (NewDelegate): New class to take care of delegate
24148 * expression.cs (New): Split the delegate related code out into
24149 the NewDelegate class.
24151 * delegate.cs (DelegateInvocation): New class to handle delegate
24154 * expression.cs (Invocation): Split out delegate related code into
24155 the DelegateInvocation class.
24157 2001-10-17 Ravi Pratap <ravi@ximian.com>
24159 * expression.cs (New::DoResolve): Implement delegate creation fully
24160 and according to the spec.
24162 (New::DoEmit): Update to handle delegates differently.
24164 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
24165 because of which we were printing out arguments in reverse order !
24167 * delegate.cs (VerifyMethod): Implement to check if the given method
24168 matches the delegate.
24170 (FullDelegateDesc): Implement.
24172 (VerifyApplicability): Implement.
24174 * expression.cs (Invocation::DoResolve): Update to accordingly handle
24175 delegate invocations too.
24177 (Invocation::Emit): Ditto.
24179 * ../errors/cs1593.cs : Added.
24181 * ../errors/cs1594.cs : Added.
24183 * delegate.cs (InstanceExpression, TargetMethod): New properties.
24185 2001-10-16 Ravi Pratap <ravi@ximian.com>
24187 * typemanager.cs (intptr_type): Core type for System.IntPtr
24189 (InitCoreTypes): Update for the same.
24191 (iasyncresult_type, asynccallback_type): Ditto.
24193 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
24196 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
24199 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
24200 the builders for the 4 members of a delegate type :-)
24202 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
24205 * expression.cs (New::DoResolve): Implement guts for delegate creation.
24207 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
24209 2001-10-15 Miguel de Icaza <miguel@ximian.com>
24211 * statement.cs (Break::Emit): Implement.
24212 (Continue::Emit): Implement.
24214 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
24215 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
24216 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
24217 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
24220 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
24221 properties that track the label for the current loop (begin of the
24222 loop and end of the loop).
24224 2001-10-15 Ravi Pratap <ravi@ximian.com>
24226 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
24227 use of emitting anything at all.
24229 * class.cs, rootcontext.cs : Get rid of calls to the same.
24231 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
24233 (Populate): Define the constructor correctly and set the implementation
24236 * typemanager.cs (delegate_types): New hashtable to hold delegates that
24239 (AddDelegateType): Implement.
24241 (IsDelegateType): Implement helper method.
24243 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
24245 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
24246 and accordingly handle it.
24248 * delegate.cs (Populate): Take TypeContainer argument.
24249 Implement bits to define the Invoke method. However, I still haven't figured out
24250 how to take care of the native int bit :-(
24252 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
24253 Qualify the name of the delegate, not its return type !
24255 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
24258 (StandardConversionExists): Checking for array types turns out to be recursive.
24260 (ConvertReferenceExplicit): Implement array conversion.
24262 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
24264 2001-10-12 Ravi Pratap <ravi@ximian.com>
24266 * cs-parser.jay (delegate_declaration): Store the fully qualified
24267 name as it is a type declaration.
24269 * delegate.cs (ReturnType, Name): Rename members to these. Make them
24272 (DefineDelegate): Renamed from Define. Does the same thing essentially,
24273 as TypeContainer::DefineType.
24275 (Populate): Method in which all the definition of the various methods (Invoke)
24278 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
24281 (CloseDelegate): Finally creates the delegate.
24283 * class.cs (TypeContainer::DefineType): Update to define delegates.
24284 (Populate, Emit and CloseType): Do the same thing here too.
24286 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
24287 delegates in all these operations.
24289 2001-10-14 Miguel de Icaza <miguel@ximian.com>
24291 * expression.cs: LocalTemporary: a new expression used to
24292 reference a temporary that has been created.
24294 * assign.cs: Handle PropertyAccess back here, so that we can
24295 provide the proper semantic access to properties.
24297 * expression.cs (Expression::ConvertReferenceExplicit): Implement
24298 a few more explicit conversions.
24300 * modifiers.cs: `NEW' modifier maps to HideBySig.
24302 * expression.cs (PropertyExpr): Make this into an
24303 ExpressionStatement, and support the EmitStatement code path.
24305 Perform get/set error checking, clean up the interface.
24307 * assign.cs: recognize PropertyExprs as targets, and if so, turn
24308 them into toplevel access objects.
24310 2001-10-12 Miguel de Icaza <miguel@ximian.com>
24312 * expression.cs: PropertyExpr::PropertyExpr: use work around the
24315 * typemanager.cs: Keep track here of our PropertyBuilders again to
24316 work around lameness in SRE.
24318 2001-10-11 Miguel de Icaza <miguel@ximian.com>
24320 * expression.cs (LValue::LValueResolve): New method in the
24321 interface, used to perform a second resolution pass for LValues.
24323 (This::DoResolve): Catch the use of this in static methods.
24325 (This::LValueResolve): Implement.
24327 (This::Store): Remove warning, assigning to `this' in structures
24330 (Invocation::Emit): Deal with invocation of
24331 methods on value types. We need to pass the address to structure
24332 methods rather than the object itself. (The equivalent code to
24333 emit "this" for structures leaves the entire structure on the
24334 stack instead of a pointer to it).
24336 (ParameterReference::DoResolve): Compute the real index for the
24337 argument based on whether the method takes or not a `this' pointer
24338 (ie, the method is static).
24340 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
24341 value types returned from functions when we need to invoke a
24342 method on the sturcture.
24345 2001-10-11 Ravi Pratap <ravi@ximian.com>
24347 * class.cs (TypeContainer::DefineType): Method to actually do the business of
24348 defining the type in the Modulebuilder or Typebuilder. This is to take
24349 care of nested types which need to be defined on the TypeBuilder using
24350 DefineNestedMethod.
24352 (TypeContainer::GetClassBases): Implement. Essentially the code from the
24353 methods in RootContext, only ported to be part of TypeContainer.
24355 (TypeContainer::GetInterfaceOrClass): Ditto.
24357 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
24359 * interface.cs (Interface::DefineInterface): New method. Does exactly
24360 what RootContext.CreateInterface did earlier, only it takes care of nested types
24363 (Interface::GetInterfaces): Move from RootContext here and port.
24365 (Interface::GetInterfaceByName): Same here.
24367 * rootcontext.cs (ResolveTree): Re-write.
24369 (PopulateTypes): Re-write.
24371 * class.cs (TypeContainer::Populate): Populate nested types too.
24372 (TypeContainer::Emit): Emit nested members too.
24374 * typemanager.cs (AddUserType): Do not make use of the FullName property,
24375 instead just use the name argument passed in as it is already fully
24378 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
24379 to TypeContainer mapping to see if a type is user-defined.
24381 * class.cs (TypeContainer::CloseType): Implement.
24383 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
24384 the default constructor.
24386 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
24389 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
24391 * interface.cs (CloseType): Create the type here.
24393 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
24396 Remove all the methods which are now in TypeContainer.
24398 2001-10-10 Ravi Pratap <ravi@ximian.com>
24400 * delegate.cs (Define): Re-write bits to define the delegate
24403 2001-10-10 Miguel de Icaza <miguel@ximian.com>
24405 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
24407 * expression.cs (ImplicitReferenceConversion): handle null as well
24408 as a source to convert to any reference type.
24410 * statement.cs (Return): Perform any implicit conversions to
24411 expected return type.
24413 Validate use of return statement.
24415 * codegen.cs (EmitContext): Pass the expected return type here.
24417 * class.cs (Method, Constructor, Property): Pass expected return
24418 type to EmitContext.
24420 2001-10-09 Miguel de Icaza <miguel@ximian.com>
24422 * expression.cs: Make DoResolve take an EmitContext instead of a
24425 Replaced `l' and `location' for `loc', for consistency.
24427 (Error, Warning): Remove unneeded Tc argument.
24429 * assign.cs, literal.cs, constant.cs: Update to new calling
24432 * codegen.cs: EmitContext now contains a flag indicating whether
24433 code is being generated in a static method or not.
24435 * cs-parser.jay: DecomposeQI, new function that replaces the old
24436 QualifiedIdentifier. Now we always decompose the assembled
24437 strings from qualified_identifier productions into a group of
24440 2001-10-08 Miguel de Icaza <miguel@ximian.com>
24442 * rootcontext.cs: Deal with field-less struct types correctly now
24443 by passing the size option to Define Type.
24445 * class.cs: Removed hack that created one static field.
24447 2001-10-07 Miguel de Icaza <miguel@ximian.com>
24449 * statement.cs: Moved most of the code generation here.
24451 2001-10-09 Ravi Pratap <ravi@ximian.com>
24453 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
24456 (ElementAccess): Remove useless bits for now - keep checks as the spec
24459 2001-10-08 Ravi Pratap <ravi@ximian.com>
24461 * expression.cs (ElementAccess::DoResolve): Remove my crap code
24462 and start performing checks according to the spec.
24464 2001-10-07 Ravi Pratap <ravi@ximian.com>
24466 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
24467 rank_specifiers instead.
24469 (rank_specifiers): Change the order in which the rank specifiers are stored
24471 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
24473 * expression.cs (ElementAccess): Implement the LValue interface too.
24475 2001-10-06 Ravi Pratap <ravi@ximian.com>
24477 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
24478 except that user defined conversions are not included.
24480 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
24481 perform the conversion of the return type, if necessary.
24483 (New::DoResolve): Check whether we are creating an array or an object
24484 and accordingly do the needful.
24486 (New::Emit): Same here.
24488 (New::DoResolve): Implement guts of array creation.
24490 (New::FormLookupType): Helper function.
24492 2001-10-07 Miguel de Icaza <miguel@ximian.com>
24494 * codegen.cs: Removed most of the code generation here, and move the
24495 corresponding code generation bits to the statement classes.
24497 Added support for try/catch/finalize and throw.
24499 * cs-parser.jay: Added support for try/catch/finalize.
24501 * class.cs: Catch static methods having the flags override,
24502 virtual or abstract.
24504 * expression.cs (UserCast): This user cast was not really doing
24505 what it was supposed to do. Which is to be born in fully resolved
24506 state. Parts of the resolution were being performed at Emit time!
24510 2001-10-05 Miguel de Icaza <miguel@ximian.com>
24512 * expression.cs: Implicity convert the result from UserCast.
24514 2001-10-05 Ravi Pratap <ravi@ximian.com>
24516 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
24517 prevented it from working correctly.
24519 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
24520 merely ConvertImplicit.
24522 2001-10-05 Miguel de Icaza <miguel@ximian.com>
24524 * typemanager.cs: Make the LookupTypeContainer function static,
24525 and not per-instance.
24527 * class.cs: Make static FindMembers (the one that takes a Type
24530 * codegen.cs: Add EmitForeach here.
24532 * cs-parser.jay: Make foreach a toplevel object instead of the
24533 inline expansion, as we need to perform semantic analysis on it.
24535 2001-10-05 Ravi Pratap <ravi@ximian.com>
24537 * expression.cs (Expression::ImplicitUserConversion): Rename to
24538 UserDefinedConversion.
24540 (Expression::UserDefinedConversion): Take an extra argument specifying
24541 whether we look for explicit user conversions too.
24543 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
24545 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
24547 (ExplicitUserConversion): Make it a call to UserDefinedConversion
24548 with the appropriate arguments.
24550 * cs-parser.jay (cast_expression): Record location too.
24552 * expression.cs (Cast): Record location info.
24554 (Expression::ConvertExplicit): Take location argument.
24556 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
24557 to determine if we are doing explicit conversions.
24559 (UserCast::Emit): Update accordingly.
24561 (Expression::ConvertExplicit): Report an error if everything fails.
24563 * ../errors/cs0030.cs : Add.
24565 2001-10-04 Miguel de Icaza <miguel@ximian.com>
24567 * modifiers.cs: If the ABSTRACT keyword is present, also set the
24568 virtual and newslot bits.
24570 * class.cs (TypeContainer::RegisterRequiredImplementations):
24571 Record methods we need.
24573 (TypeContainer::MakeKey): Helper function to make keys for
24574 MethodBases, since the Methodbase key is useless.
24576 (TypeContainer::Populate): Call RegisterRequiredImplementations
24577 before defining the methods.
24579 Create a mapping for method_builders_to_methods ahead of time
24580 instead of inside a tight loop.
24582 (::RequireMethods): Accept an object as the data to set into the
24583 hashtable so we can report interface vs abstract method mismatch.
24585 2001-10-03 Miguel de Icaza <miguel@ximian.com>
24587 * report.cs: Make all of it static.
24589 * rootcontext.cs: Drop object_type and value_type computations, as
24590 we have those in the TypeManager anyways.
24592 Drop report instance variable too, now it is a global.
24594 * driver.cs: Use try/catch on command line handling.
24596 Add --probe option to debug the error reporting system with a test
24599 * report.cs: Add support for exiting program when a probe
24600 condition is reached.
24602 2001-10-03 Ravi Pratap <ravi@ximian.com>
24604 * expression.cs (Binary::DoNumericPromotions): Fix the case when
24605 we do a forcible conversion regardless of type, to check if
24606 ForceConversion returns a null.
24608 (Binary::error19): Use location to report error.
24610 (Unary::error23): Use location here too.
24612 * ../errors/cs0019.cs : Check in.
24614 * ../errors/cs0023.cs : Check in.
24616 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
24617 case of a non-null MethodInfo object with a length of 0 !
24619 (Binary::ResolveOperator): Flag error if overload resolution fails to find
24620 an applicable member - according to the spec :-)
24621 Also fix logic to find members in base types.
24623 (Unary::ResolveOperator): Same here.
24625 (Unary::report23): Change name to error23 and make first argument a TypeContainer
24626 as I was getting thoroughly confused between this and error19 :-)
24628 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
24629 (::FindMostEncompassedType): Implement.
24630 (::FindMostEncompassingType): Implement.
24631 (::StandardConversionExists): Implement.
24633 (UserImplicitCast): Re-vamp. We now need info about most specific
24634 source and target types so that we can do the necessary conversions.
24636 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
24637 mathematical union with no duplicates.
24639 2001-10-03 Miguel de Icaza <miguel@ximian.com>
24641 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
24642 in order from base classes to child classes, so that we can in
24643 child classes look up in our parent for method names and
24644 attributes (required for handling abstract, virtual, new, override
24645 constructs: we need to instrospect our base class, and if we dont
24646 populate the classes in order, the introspection might be
24647 incorrect. For example, a method could query its parent before
24648 the parent has any methods and would determine that the parent has
24649 no abstract methods (while it could have had them)).
24651 (RootContext::CreateType): Record the order in which we define the
24654 2001-10-02 Miguel de Icaza <miguel@ximian.com>
24656 * class.cs (TypeContainer::Populate): Also method definitions can
24657 fail now, keep track of this.
24659 (TypeContainer::FindMembers): Implement support for
24660 DeclaredOnly/noDeclaredOnly flag.
24662 (Constructor::Emit) Return the ConstructorBuilder.
24664 (Method::Emit) Return the MethodBuilder.
24665 Check for abstract or virtual methods to be public.
24667 * rootcontext.cs (RootContext::CreateType): Register all the
24668 abstract methods required for the class to be complete and the
24669 interface methods that must be implemented.
24671 * cs-parser.jay: Report error 501 (method requires body if it is
24672 not marked abstract or extern).
24674 * expression.cs (TypeOf::Emit): Implement.
24676 * typemanager.cs: runtime_handle_type, new global type.
24678 * class.cs (Property::Emit): Generate code for properties.
24680 2001-10-02 Ravi Pratap <ravi@ximian.com>
24682 * expression.cs (Unary::ResolveOperator): Find operators on base type
24683 too - we now conform exactly to the spec.
24685 (Binary::ResolveOperator): Same here.
24687 * class.cs (Operator::Define): Fix minor quirk in the tests.
24689 * ../errors/cs0215.cs : Added.
24691 * ../errors/cs0556.cs : Added.
24693 * ../errors/cs0555.cs : Added.
24695 2001-10-01 Miguel de Icaza <miguel@ximian.com>
24697 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
24698 single integer which is really efficient
24700 2001-10-01 Ravi Pratap <ravi@ximian.com>
24702 * expression.cs (Expression::ImplicitUserConversion): Use location
24703 even in the case when we are examining True operators.
24705 * class.cs (Operator::Define): Perform extensive checks to conform
24706 with the rules for operator overloading in the spec.
24708 * expression.cs (Expression::ImplicitReferenceConversion): Implement
24709 some of the other conversions mentioned in the spec.
24711 * typemanager.cs (array_type): New static member for the System.Array built-in
24714 (cloneable_interface): For System.ICloneable interface.
24716 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
24717 we start resolving the tree and populating types.
24719 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
24721 2001-10-01 Miguel de Icaza <miguel@ximian.com>
24723 * expression.cs (Expression::ExprClassFromMemberInfo,
24724 Expression::Literalize): Create literal expressions from
24725 FieldInfos which are literals.
24727 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
24728 type casts, because they were wrong. The test suite in tests
24731 (ImplicitNumericConversion): ushort to ulong requires a widening
24734 Int32 constant to long requires widening cast as well.
24736 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
24737 for integers because the type on the stack is not i4.
24739 2001-09-30 Miguel de Icaza <miguel@ximian.com>
24741 * expression.cs (report118): require location argument.
24743 * parameter.cs: Do not dereference potential null value.
24745 * class.cs: Catch methods that lack the `new' keyword when
24746 overriding a name. Report warnings when `new' is used without
24747 anything being there to override.
24749 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
24751 * class.cs: Only add constructor to hashtable if it is non-null
24752 (as now constructors can fail on define).
24754 (TypeManager, Class, Struct): Take location arguments.
24756 Catch field instance initialization in structs as errors.
24758 accepting_filter: a new filter for FindMembers that is static so
24759 that we dont create an instance per invocation.
24761 (Constructor::Define): Catch errors where a struct constructor is
24764 * cs-parser.jay: Pass location information for various new
24767 * delegate.cs (Delegate): take a location argument.
24769 * driver.cs: Do not call EmitCode if there were problesm in the
24770 Definition of the types, as many Builders wont be there.
24772 * decl.cs (Decl::Decl): Require a location argument.
24774 * cs-tokenizer.cs: Handle properly hex constants that can not fit
24775 into integers, and find the most appropiate integer for it.
24777 * literal.cs: Implement ULongLiteral.
24779 * rootcontext.cs: Provide better information about the location of
24780 failure when CreateType fails.
24782 2001-09-29 Miguel de Icaza <miguel@ximian.com>
24784 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
24787 * expression.cs (Binary::CheckShiftArguments): Add missing type
24789 (Binary::ResolveOperator): Add type to the logical and and logical
24790 or, Bitwise And/Or and Exclusive Or code paths, it was missing
24793 (Binary::DoNumericPromotions): In the case where either argument
24794 is ulong (and most signed types combined with ulong cause an
24795 error) perform implicit integer constant conversions as well.
24797 2001-09-28 Miguel de Icaza <miguel@ximian.com>
24799 * expression.cs (UserImplicitCast): Method should always be
24801 (Invocation::BetterConversion): Simplified test for IntLiteral.
24803 (Expression::ImplicitNumericConversion): Split this routine out.
24804 Put the code that performs implicit constant integer conversions
24807 (Expression::Resolve): Become a wrapper around DoResolve so we can
24808 check eclass and type being set after resolve.
24810 (Invocation::Badness): Remove this dead function
24812 (Binary::ResolveOperator): Do not compute the expensive argumnets
24813 unless we have a union for it.
24815 (Probe::Emit): Is needs to do an isinst and then
24816 compare against null.
24818 (::CanConvert): Added Location argument. If the Location argument
24819 is null (Location.Null), then we do not report errors. This is
24820 used by the `probe' mechanism of the Explicit conversion. We do
24821 not want to generate an error for something that the user
24822 explicitly requested to be casted. But the pipeline for an
24823 explicit cast first tests for potential implicit casts.
24825 So for now, if the Location is null, it means `Probe only' to
24826 avoid adding another argument. Might have to revise this
24829 (ClassCast): New class used to type cast objects into arbitrary
24830 classes (used in Explicit Reference Conversions).
24832 Implement `as' as well.
24834 Reverted all the patches from Ravi below: they were broken:
24836 * The use of `level' as a mechanism to stop recursive
24837 invocations is wrong. That was there just to catch the
24838 bug with a strack trace but not as a way of addressing
24841 To fix the problem we have to *understand* what is going
24842 on and the interactions and come up with a plan, not
24843 just get things going.
24845 * The use of the type conversion cache that I proposed
24846 last night had an open topic: How does this work across
24847 protection domains. A user defined conversion might not
24848 be public in the location where we are applying the
24849 conversion, a different conversion might be selected
24850 (ie, private A->B (better) but public B->A (worse),
24851 inside A, A->B applies, but outside it, B->A will
24854 * On top of that (ie, even if the above is solved),
24855 conversions in a cache need to be abstract. Ie, `To
24856 convert from an Int to a Short use an OpcodeCast', not
24857 `To convert from an Int to a Short use the OpcodeCast on
24858 the variable 5' (which is what this patch was doing).
24860 2001-09-28 Ravi Pratap <ravi@ximian.com>
24862 * expression.cs (Invocation::ConversionExists): Re-write to use
24863 the conversion cache
24865 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
24866 cache all conversions done, not just user-defined ones.
24868 (Invocation::BetterConversion): The real culprit. Use ConversionExists
24869 to determine if a conversion exists instead of acutually trying to
24870 perform the conversion. It's faster too.
24872 (Expression::ConvertExplicit): Modify to use ConversionExists to check
24873 and only then attempt the implicit conversion.
24875 2001-09-28 Ravi Pratap <ravi@ximian.com>
24877 * expression.cs (ConvertImplicit): Use a cache for conversions
24878 already found. Check level of recursion and bail out if necessary.
24880 2001-09-28 Miguel de Icaza <miguel@ximian.com>
24882 * typemanager.cs (string_concat_string_string, string_concat_object_object):
24883 Export standard methods that we expect for string operations.
24885 * statement.cs (Block::UsageWarning): Track usage of variables and
24886 report the errors for not used variables.
24888 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
24891 2001-09-27 Miguel de Icaza <miguel@ximian.com>
24893 * codegen.cs: remove unnneded code
24895 * expression.cs: Removed BuiltinTypeAccess class
24897 Fix the order in which implicit conversions are
24900 The previous fixed dropped support for boxed conversions (adding a
24901 test to the test suite now)
24903 (UserImplicitCast::CanConvert): Remove test for source being null,
24904 that code is broken. We should not feed a null to begin with, if
24905 we do, then we should track the bug where the problem originates
24906 and not try to cover it up here.
24908 Return a resolved expression of type UserImplicitCast on success
24909 rather than true/false. Ravi: this is what I was talking about,
24910 the pattern is to use a static method as a "constructor" for
24913 Also, do not create arguments until the very last minute,
24914 otherwise we always create the arguments even for lookups that
24915 will never be performed.
24917 (UserImplicitCast::Resolve): Eliminate, objects of type
24918 UserImplicitCast are born in a fully resolved state.
24920 * typemanager.cs (InitCoreTypes): Init also value_type
24921 (System.ValueType).
24923 * expression.cs (Cast::Resolve): First resolve the child expression.
24925 (LValue): Add new method AddressOf to be used by
24928 Change the argument of Store to take an EmitContext instead of an
24929 ILGenerator, because things like FieldExpr need to be able to call
24930 their children expression to generate the instance code.
24932 (Expression::Error, Expression::Warning): Sugar functions for
24935 (Expression::MemberLookup): Accept a TypeContainer instead of a
24936 Report as the first argument.
24938 (Expression::ResolvePrimary): Killed. I still want to improve
24939 this as currently the code is just not right.
24941 (Expression::ResolveMemberAccess): Simplify, but it is still
24944 (Unary::Resolve): Catch errors in AddressOf operators.
24946 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
24947 index to a byte for the short-version, or the compiler will choose
24948 the wrong Emit call, which generates the wrong data.
24950 (ParameterReference::Emit, ::Store): same.
24952 (FieldExpr::AddressOf): Implement.
24954 * typemanager.cs: TypeManager: made public variable instead of
24957 * driver.cs: document --fatal.
24959 * report.cs (ErrorMessage, WarningMessage): new names for the old
24960 Error and Warning classes.
24962 * cs-parser.jay (member_access): Turn built-in access to types
24963 into a normal simplename
24965 2001-09-27 Ravi Pratap <ravi@ximian.com>
24967 * expression.cs (Invocation::BetterConversion): Fix to cope
24968 with q being null, since this was introducing a bug.
24970 * expression.cs (ConvertImplicit): Do built-in conversions first.
24972 2001-09-27 Ravi Pratap <ravi@ximian.com>
24974 * expression.cs (UserImplicitCast::Resolve): Fix bug.
24976 2001-09-27 Ravi Pratap <ravi@ximian.com>
24978 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
24979 I had introduced long ago (what's new ?).
24981 * expression.cs (UserImplicitCast::CanConvert): Static method to do
24982 the work of all the checking.
24983 (ConvertImplicit): Call CanConvert and only then create object if necessary.
24984 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
24986 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
24987 that is the right way.
24989 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
24990 overloading resolution. Use everywhere instead of cutting and pasting code.
24992 (Binary::ResolveOperator): Use MakeUnionSet.
24994 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
24995 we have to convert to bool types. Not complete yet.
24997 2001-09-27 Miguel de Icaza <miguel@ximian.com>
24999 * typemanager.cs (TypeManager::CSharpName): support ushort.
25001 * expression.cs (Expression::TryImplicitIntConversion): Attempts
25002 to provide an expression that performsn an implicit constant int
25003 conversion (section 6.1.6).
25004 (Expression::ConvertImplicitRequired): Reworked to include
25005 implicit constant expression conversions.
25007 (Expression::ConvertNumericExplicit): Finished.
25009 (Invocation::Emit): If InstanceExpression is null, then it means
25010 that we perform a call on this.
25012 2001-09-26 Miguel de Icaza <miguel@ximian.com>
25014 * expression.cs (Unary::Emit): Remove some dead code.
25015 (Probe): Implement Resolve and Emit for `is'.
25016 (Expression::ConvertImplicitRequired): Attempt to do constant
25017 expression conversions here. Maybe should be moved to
25018 ConvertImplicit, but I am not sure.
25019 (Expression::ImplicitLongConstantConversionPossible,
25020 Expression::ImplicitIntConstantConversionPossible): New functions
25021 that tell whether is it possible to apply an implicit constant
25022 expression conversion.
25024 (ConvertNumericExplicit): Started work on explicit numeric
25027 * cs-parser.jay: Update operator constants.
25029 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
25030 (Parameters::GetSignature): Hook up VerifyArgs here.
25031 (Parameters::VerifyArgs): Verifies that no two arguments have the
25034 * class.cs (Operator): Update the operator names to reflect the
25035 ones that the spec expects (as we are just stringizing the
25038 * expression.cs (Unary::ResolveOperator): Fix bug: Use
25039 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
25040 previous usage did only work for our methods.
25041 (Expression::ConvertImplicit): Handle decimal implicit numeric
25042 conversions as well.
25043 (Expression::InternalTypeConstructor): Used to invoke constructors
25044 on internal types for default promotions.
25046 (Unary::Emit): Implement special handling for the pre/post
25047 increment/decrement for overloaded operators, as they need to have
25048 the same semantics as the other operators.
25050 (Binary::ResolveOperator): ditto.
25051 (Invocation::ConversionExists): ditto.
25052 (UserImplicitCast::Resolve): ditto.
25054 2001-09-26 Ravi Pratap <ravi@ximian.com>
25056 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
25057 operator, return after emitting body. Regression tests pass again !
25059 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
25060 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
25061 (Invocation::OverloadResolve): Ditto.
25062 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
25064 * everywhere : update calls to the above methods accordingly.
25066 2001-09-26 Miguel de Icaza <miguel@ximian.com>
25068 * assign.cs (Assign): Make it inherit from ExpressionStatement.
25070 * expression.cs (ExpressionStatement): New base class used for
25071 expressions that can appear in statements, so that we can provide
25072 an alternate path to generate expression that do not leave a value
25075 (Expression::Emit, and all the derivatives): We no longer return
25076 whether a value is left on the stack or not. Every expression
25077 after being emitted leaves a single value on the stack.
25079 * codegen.cs (EmitContext::EmitStatementExpression): Use the
25080 facilties of ExpressionStatement if possible.
25082 * cs-parser.jay: Update statement_expression.
25084 2001-09-25 Miguel de Icaza <miguel@ximian.com>
25086 * driver.cs: Change the wording of message
25088 2001-09-25 Ravi Pratap <ravi@ximian.com>
25090 * expression.cs (Binary::ResolveOperator): Had forgottten to set
25091 the type of the expression to the return type of the method if
25092 we have an overloaded operator match ! The regression tests pass again !
25093 (Unary::ResolveOperator): Ditto.
25095 * expression.cs (Invocation::ConversionExists): Correct the member lookup
25096 to find "op_Implicit", not "implicit" ;-)
25097 (UserImplicitCast): New class to take care of user-defined implicit conversions.
25098 (ConvertImplicit, ForceConversion): Take TypeContainer argument
25100 * everywhere : Correct calls to the above accordingly.
25102 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
25103 (ConvertImplicit): Do user-defined conversion if it exists.
25105 2001-09-24 Miguel de Icaza <miguel@ximian.com>
25107 * assign.cs: track location.
25108 (Resolve): Use implicit conversions on assignment.
25110 * literal.cs: Oops. Not good, Emit of short access values should
25111 pass (Bytes) or the wrong argument will be selected.
25113 * expression.cs (Unary::Emit): Emit code for -expr.
25115 (Unary::ResolveOperator): Handle `Substract' for non-constants
25116 (substract from zero from the non-constants).
25117 Deal with Doubles as well.
25119 (Expression::ConvertImplicitRequired): New routine that reports an
25120 error if no implicit conversion exists.
25122 (Invocation::OverloadResolve): Store the converted implicit
25123 expressions if we make them
25125 2001-09-24 Ravi Pratap <ravi@ximian.com>
25127 * class.cs (ConstructorInitializer): Take a Location argument.
25128 (ConstructorBaseInitializer): Same here.
25129 (ConstructorThisInitializer): Same here.
25131 * cs-parser.jay : Update all calls accordingly.
25133 * expression.cs (Unary, Binary, New): Take location argument.
25134 Update accordingly everywhere.
25136 * cs-parser.jay : Update all calls to the above to take a location
25139 * class.cs : Ditto.
25141 2001-09-24 Ravi Pratap <ravi@ximian.com>
25143 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
25144 (Invocation::BetterConversion): Same here
25145 (Invocation::ConversionExists): Ditto.
25147 (Invocation::ConversionExists): Implement.
25149 2001-09-22 Ravi Pratap <ravi@ximian.com>
25151 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
25152 Also take an additional TypeContainer argument.
25154 * All over : Pass in TypeContainer as argument to OverloadResolve.
25156 * typemanager.cs (CSharpName): Update to check for the string type and return
25159 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
25162 2001-09-21 Ravi Pratap <ravi@ximian.com>
25164 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
25165 (Invocation::BetterFunction): Implement.
25166 (Invocation::BetterConversion): Implement.
25167 (Invocation::ConversionExists): Skeleton, no implementation yet.
25169 Okay, things work fine !
25171 2001-09-21 Miguel de Icaza <miguel@ximian.com>
25173 * typemanager.cs: declare and load enum_type, delegate_type and
25176 * expression.cs (Expression::Emit): Now emit returns a value that
25177 tells whether a value is left on the stack or not. This strategy
25178 might be reveted tomorrow with a mechanism that would address
25179 multiple assignments.
25180 (Expression::report118): Utility routine to report mismatches on
25183 (Unary::Report23): Report impossible type/operator combination
25186 (Unary::IsIncrementableNumber): Whether the type can be
25187 incremented or decremented with add.
25188 (Unary::ResolveOperator): Also allow enumerations to be bitwise
25190 (Unary::ResolveOperator): Implement ++, !, ~,
25192 (Invocation::Emit): Deal with new Emit convetion.
25194 * All Expression derivatives: Updated their Emit method to return
25195 whether they leave values on the stack or not.
25197 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
25198 stack for expressions that are statements.
25200 2001-09-20 Miguel de Icaza <miguel@ximian.com>
25202 * expression.cs (LValue): New interface. Must be implemented by
25204 (LocalVariableReference, ParameterReference, FieldExpr): Implement
25207 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
25208 interface for generating code, simplifies the code.
25210 2001-09-20 Ravi Pratap <ravi@ximian.com>
25212 * expression.cs (everywhere): Comment out return statements in ::Resolve
25213 methods to avoid the warnings.
25215 2001-09-20 Miguel de Icaza <miguel@ximian.com>
25217 * driver.cs (parse): Report error 2001 if we can not open the
25220 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
25223 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
25226 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
25227 otherwise nested blocks end up with the same index.
25229 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
25231 * expression.cs: Instead of having FIXMEs in the Resolve
25232 functions, throw exceptions so it is obvious that we are facing a
25235 * cs-parser.jay (invocation_expression): Pass Location information.
25237 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
25238 Use a basename for those routines because .NET does not like paths
25241 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
25244 2001-09-19 Miguel de Icaza <miguel@ximian.com>
25246 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
25247 are loading the correct data types (throws an exception if not).
25248 (TypeManager::InitCoreTypes): Use CoreLookupType
25250 * expression.cs (Unary::ResolveOperator): return the child
25251 expression for expressions which are just +expr.
25252 (Unary::ResolveOperator): Return negative literals for -LITERAL
25253 expressions (otherwise they are Unary {Literal}).
25254 (Invocation::Badness): Take into account `Implicit constant
25255 expression conversions'.
25257 * literal.cs (LongLiteral): Implement long literal class.
25258 (IntLiteral): export the `Value' of the intliteral.
25260 2001-09-19 Ravi Pratap <ravi@ximian.com>
25262 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
25264 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
25265 instead of 'Operator'
25267 * expression.cs (Binary::ResolveOperator): Update accordingly.
25268 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
25271 * cs-parser.jay (unary_expression): Update to use the new names.
25273 * gen-treedump.cs (GetUnary): Same here.
25275 * expression.cs (Unary::Resolve): Implement.
25276 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
25277 operators are found instead of making noise ;-)
25278 (Unary::ResolveOperator): New method to do precisely the same thing which
25279 Binary::ResolveOperator does for Binary expressions.
25280 (Unary.method, .Arguments): Add.
25281 (Unary::OperName): Implement.
25282 (Unary::ForceConversion): Copy and Paste !
25284 * class.cs (Operator::Define): Fix a small bug for the case when we have
25287 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
25288 for the inbuilt operators. Only overloading works for now ;-)
25290 2001-09-18 Miguel de Icaza <miguel@ximian.com>
25292 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
25293 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
25295 * expression.cs (This::Emit): Implement.
25296 (This::Resolve): Implement.
25297 (TypeOf:Resolve): Implement.
25298 (Expression::ResolveSimpleName): Add an implicit this to instance
25300 (MemberAccess::Resolve): Deal with Parameters and Fields.
25301 Bind instance variable to Field expressions.
25302 (FieldExpr::Instance): New field used to track the expression that
25303 represents the object instance.
25304 (FieldExpr::Resolve): Track potential errors from MemberLookup not
25306 (FieldExpr::Emit): Implement.
25308 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
25309 the last instruction contains a return opcode to avoid generating
25310 the last `ret' instruction (this generates correct code, and it is
25311 nice to pass the peverify output).
25313 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
25314 initializer for static and instance variables.
25315 (Constructor::Emit): Allow initializer to be null in the case of
25316 static constructors. Only emit initializer for instance
25319 (TypeContainer::FindMembers): Return a null array if there are no
25322 Also fix the code for the MemberTypes.Method branch, as it was not
25323 scanning that for operators (or tried to access null variables before).
25325 * assign.cs (Assign::Emit): Handle instance and static fields.
25329 * driver.cs: Stop compilation if there are parse errors.
25331 * cs-parser.jay (constructor_declaration): Provide default base
25332 initializer for non-static constructors.
25333 (constructor_declarator): Do not provide a default base
25334 initializers if none was specified.
25335 Catch the fact that constructors should not have parameters.
25337 * class.cs: Do not emit parent class initializers for static
25338 constructors, that should be flagged as an error.
25340 2001-09-18 Ravi Pratap <ravi@ximian.com>
25342 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
25343 Move back code into TypeContainer::Populate.
25345 2001-09-18 Ravi Pratap <ravi@ximian.com>
25347 * class.cs (TypeContainer::AddConstructor): Fix the check to
25348 compare against Name, not Basename.
25349 (Operator::OpType): Change Plus and Minus to Add and Subtract.
25351 * cs-parser.jay : Update accordingly.
25353 * class.cs (TypeContainer::FindMembers): For the case where we are searching
25354 for methods, don't forget to look into the operators too.
25355 (RegisterMethodBuilder): Helper method to take care of this for
25356 methods, constructors and operators.
25357 (Operator::Define): Completely revamp.
25358 (Operator.OperatorMethod, MethodName): New fields.
25359 (TypeContainer::Populate): Move the registering of builders into
25360 RegisterMethodBuilder.
25361 (Operator::Emit): Re-write.
25363 * expression.cs (Binary::Emit): Comment out code path to emit method
25364 invocation stuff for the case when we have a user defined operator. I am
25365 just not able to get it right !
25367 2001-09-17 Miguel de Icaza <miguel@ximian.com>
25369 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
25372 (Expression::MemberLookup): Provide a version that allows to
25373 specify the MemberTypes and BindingFlags.
25375 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
25376 so it was not fetching variable information from outer blocks.
25378 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
25379 Beforefieldinit as it was buggy.
25381 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
25382 that Ravi put here.
25384 * class.cs (Constructor::Emit): Only emit if block is not null.
25385 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
25386 deal with this by semantically definining it as if the user had
25389 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
25390 constructors as we now "emit" them at a higher level.
25392 (TypeContainer::DefineDefaultConstructor): Used to define the
25393 default constructors if none was provided.
25395 (ConstructorInitializer): Add methods Resolve and Emit.
25397 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
25399 2001-09-17 Ravi Pratap <ravi@ximian.com>
25401 * class.cs (TypeContainer::EmitDefaultConstructor): Register
25402 the default constructor builder with our hashtable for methodbuilders
25405 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
25406 and argument_count is 0 in which case we have a match.
25407 (Binary::ResolveOperator): More null checking and miscellaneous coding
25410 2001-09-17 Ravi Pratap <ravi@ximian.com>
25412 * rootcontext.cs (IsNameSpace): Compare against null.
25414 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
25416 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
25417 and Unary::Operator.
25419 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
25422 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
25423 we have overloaded operators.
25424 (Binary::ResolveOperator): Implement the part which does the operator overload
25427 * class.cs (Operator::Emit): Implement.
25428 (TypeContainer::Emit): Emit the operators we have too.
25430 * expression.cs (Binary::Emit): Update to emit the appropriate code for
25431 the case when we have a user-defined operator.
25433 2001-09-17 Miguel de Icaza <miguel@ximian.com>
25435 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
25437 2001-09-16 Ravi Pratap <ravi@ximian.com>
25439 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
25440 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
25441 (Constructor::Emit): Implement.
25442 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
25443 if we have no work to do.
25444 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
25447 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
25448 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
25450 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
25453 2001-09-15 Ravi Pratap <ravi@ximian.com>
25455 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
25457 (Tree::RecordNamespace): Method to do what the name says ;-)
25458 (Tree::Namespaces): Property to get at the namespaces hashtable.
25460 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
25463 * rootcontext.cs (IsNamespace): Fixed it :-)
25465 2001-09-14 Miguel de Icaza <miguel@ximian.com>
25467 * class.cs (TypeContainer::FindMembers): Add support for
25469 (MethodCore): New class that encapsulates both the shared aspects
25470 of a Constructor and a Method.
25471 (Method, Constructor): Factored pieces into MethodCore.
25473 * driver.cs: Added --fatal which makes errors throw exceptions.
25474 Load System assembly as well as part of the standard library.
25476 * report.cs: Allow throwing exceptions on errors for debugging.
25478 * modifiers.cs: Do not use `parent', instead use the real type
25479 container to evaluate permission settings.
25481 * class.cs: Put Ravi's patch back in. He is right, and we will
25482 have to cope with the
25484 2001-09-14 Ravi Pratap <ravi@ximian.com>
25486 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
25487 FamORAssem, not FamANDAssem.
25489 2001-09-14 Miguel de Icaza <miguel@ximian.com>
25491 * driver.cs: Added --parse option that only parses its input files
25494 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
25495 incorrect. IsTopLevel is not used to tell whether an object is
25496 root_types or not (that can be achieved by testing this ==
25497 root_types). But to see if this is a top-level *class* (not
25498 necessarly our "toplevel" container).
25500 2001-09-14 Ravi Pratap <ravi@ximian.com>
25502 * enum.cs (Enum::Define): Modify to call the Lookup method on the
25503 parent instead of a direct call to GetType.
25505 2001-09-14 Ravi Pratap <ravi@ximian.com>
25507 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
25508 Modifiers.TypeAttr. This should just be a call to that method.
25510 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
25511 object so that we can determine if we are top-level or not.
25513 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
25516 * enum.cs (Enum::Define): Ditto.
25518 * modifiers.cs (FieldAttr): Re-write.
25520 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
25521 (TypeContainer::HaveStaticConstructor): New property to provide access
25522 to precisely that info.
25524 * modifiers.cs (MethodAttr): Re-write.
25525 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
25527 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
25528 of top-level types as claimed.
25530 2001-09-13 Miguel de Icaza <miguel@ximian.com>
25532 * expression.cs (MemberLookup): Fruitless attempt to lookup
25533 constructors. Maybe I need to emit default constructors? That
25534 might be it (currently .NET emits this for me automatically).
25535 (Invocation::OverloadResolve): Cope with Arguments == null.
25536 (Invocation::EmitArguments): new function, shared by the new
25537 constructor and us.
25538 (Invocation::Emit): Handle static and instance methods. Emit
25539 proper call instruction for virtual or non-virtual invocations.
25540 (New::Emit): Implement.
25541 (New::Resolve): Implement.
25542 (MemberAccess:Resolve): Implement.
25543 (MethodGroupExpr::InstanceExpression): used conforming to the spec
25544 to track instances.
25545 (FieldExpr::Resolve): Set type.
25547 * support.cs: Handle empty arguments.
25549 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
25550 SimpleLookup): Auxiliary routines to help parse a qualifier
25553 Update qualifier_identifier rule.
25555 * codegen.cs: Removed debugging messages.
25557 * class.cs: Make this a global thing, this acts just as a "key" to
25558 objects that we might have around.
25560 (Populate): Only initialize method_builders_to_methods once.
25562 * expression.cs (PropertyExpr): Initialize type from the
25565 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
25566 Resolve pattern. Attempt to implicitly convert value to boolean.
25569 * expression.cs: Set the type for the int32/int32 argument case.
25570 (Binary::ResolveOperator): Set the return type to boolean for
25571 comparission operators
25573 * typemanager.cs: Remove debugging print code.
25575 (Invocation::Resolve): resolve type.
25577 * class.cs: Allocate a MemberInfo of the correct size, as the code
25578 elsewhere depends on the test to reflect the correct contents.
25580 (Method::) Keep track of parameters, due to System.Reflection holes
25582 (TypeContainer::Populate): Keep track of MethodBuilders to Method
25585 (TypeContainer::FindMembers): Use ArrayList and then copy an array
25586 of the exact size and return that.
25588 (Class::LookupMethodByBuilder): New function that maps
25589 MethodBuilders to its methods. Required to locate the information
25590 on methods because System.Reflection bit us again.
25592 * support.cs: New file, contains an interface ParameterData and
25593 two implementations: ReflectionParameters and InternalParameters
25594 used to access Parameter information. We will need to grow this
25597 * expression.cs (Invocation::GetParameterData): implement a cache
25598 and a wrapper around the ParameterData creation for methods.
25599 (Invocation::OverloadResolve): Use new code.
25601 2001-09-13 Ravi Pratap <ravi@ximian.com>
25603 * class.cs (TypeContainer::EmitField): Remove and move into
25604 (Field::Define): here and modify accordingly.
25605 (Field.FieldBuilder): New member.
25606 (TypeContainer::Populate): Update accordingly.
25607 (TypeContainer::FindMembers): Implement.
25609 2001-09-13 Miguel de Icaza <miguel@ximian.com>
25611 * statement.cs: (VariableInfo::VariableType): New field to be
25612 initialized with the full type once it is resolved.
25614 2001-09-12 Miguel de Icaza <miguel@ximian.com>
25616 * parameter.cs (GetParameterInfo): Use a type cache to compute
25617 things only once, and to reuse this information
25619 * expression.cs (LocalVariableReference::Emit): Implement.
25620 (OpcodeCast::Emit): fix.
25622 (ParameterReference::Resolve): Implement.
25623 (ParameterReference::Emit): Implement.
25625 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
25626 that are expressions need to stay as Expressions.
25628 * typemanager.cs (CSharpName): Returns the C# name of a type if
25631 * expression.cs (Expression::ConvertImplicit): New function that
25632 implements implicit type conversions.
25634 (Expression::ImplicitReferenceConversion): Implements implicit
25635 reference conversions.
25637 (EmptyCast): New type for transparent casts.
25639 (OpcodeCast): New type for casts of types that are performed with
25640 a sequence of bytecodes.
25642 (BoxedCast): New type used for casting value types into reference
25643 types. Emits a box opcode.
25645 (Binary::DoNumericPromotions): Implements numeric promotions of
25646 and computation of the Binary::Type.
25648 (Binary::EmitBranchable): Optimization.
25650 (Binary::Emit): Implement code emission for expressions.
25652 * typemanager.cs (TypeManager): Added two new core types: sbyte
25655 2001-09-12 Ravi Pratap <ravi@ximian.com>
25657 * class.cs (TypeContainer::FindMembers): Method which does exactly
25658 what Type.FindMembers does, only we don't have to use reflection. No
25659 implementation yet.
25661 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
25662 typecontainer objects as we need to get at them.
25663 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
25665 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
25666 typecontainer object.
25668 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
25669 of just a Report object.
25671 2001-09-11 Ravi Pratap <ravi@ximian.com>
25673 * class.cs (Event::Define): Go back to using the prefixes "add_" and
25675 (TypeContainer::Populate): Now define the delegates of the type too.
25676 (TypeContainer.Delegates): Property to access the list of delegates defined
25679 * delegates.cs (Delegate::Define): Implement partially.
25681 * modifiers.cs (TypeAttr): Handle more flags.
25683 2001-09-11 Ravi Pratap <ravi@ximian.com>
25685 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
25687 (Operator::Define): Re-write logic to get types by using the LookupType method
25688 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
25689 (Indexer::Define): Ditto.
25690 (Event::Define): Ditto.
25691 (Property::Define): Ditto.
25693 2001-09-10 Ravi Pratap <ravi@ximian.com>
25695 * class.cs (TypeContainer::Populate): Now define operators too.
25696 (TypeContainer.Operators): New property to access the list of operators
25698 (Operator.OperatorMethodBuilder): New member to hold the method builder
25699 for the operator we are defining.
25700 (Operator::Define): Implement.
25702 2001-09-10 Ravi Pratap <ravi@ximian.com>
25704 * class.cs (Event::Define): Make the prefixes of the accessor methods
25705 addOn_ and removeOn_
25707 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
25708 of the location being passed in too. Ideally, this should go later since all
25709 error reporting should be done through the Report object.
25711 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
25712 (Populate): Iterate thru the indexers we have and define them too.
25713 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
25714 for the get and set accessors.
25715 (Indexer::Define): Implement.
25717 2001-09-09 Miguel de Icaza <miguel@ximian.com>
25719 * expression.cs (Binary::Resolve): Beginning of it. I scratched
25720 my previous implementation, did not work.
25722 * typemanager.cs: Add a couple of missing types (the longs).
25724 * literal.cs: Use TypeManager.bool_type instead of getting it.
25726 * expression.cs (EventExpr): New kind of expressions.
25727 (Expressio::ExprClassFromMemberInfo): finish
25729 2001-09-08 Miguel de Icaza <miguel@ximian.com>
25731 * assign.cs: Emit stores to static fields differently.
25733 2001-09-08 Ravi Pratap <ravi@ximian.com>
25735 * Merge in changes and adjust code to tackle conflicts. Backed out my
25736 code in Assign::Resolve ;-)
25738 2001-09-08 Ravi Pratap <ravi@ximian.com>
25740 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
25741 instead Report.Error and also pass in the location.
25742 (CSharpParser::Lexer): New readonly property to return the reference
25743 to the Tokenizer object.
25744 (declare_local_variables): Use Report.Error with location instead of plain
25748 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
25749 (Operator.CheckBinaryOperator): Ditto.
25751 * cs-parser.jay (operator_declarator): Update accordingly.
25753 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
25754 (CheckBinaryOperator): Same here.
25756 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
25757 on the name without any prefixes of namespace names etc. This is because we
25758 already might have something already fully qualified like
25759 'System.Console.WriteLine'
25761 * assign.cs (Resolve): Begin implementation. Stuck ;-)
25763 2001-09-07 Ravi Pratap <ravi@ximian.com>
25765 * cs-tokenizer.cs (location): Return a string which also contains
25768 * expression.cs (ElementAccess): New class for expressions of the
25769 type 'element access.'
25770 (BaseAccess): New class for expressions of the type 'base access.'
25771 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
25774 * cs-parser.jay (element_access): Implement action.
25775 (base_access): Implement actions.
25776 (checked_expression, unchecked_expression): Implement.
25778 * cs-parser.jay (local_variable_type): Correct and implement.
25779 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
25781 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
25783 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
25784 name and the specifiers.
25786 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
25788 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
25789 making them all public ;-)
25791 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
25794 2001-09-07 Miguel de Icaza <miguel@ximian.com>
25796 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
25798 (FieldExpr, PropertyExprs): New resolved expressions.
25799 (SimpleName::MemberStaticCheck): Perform static checks for access
25800 to non-static fields on static methods. Maybe this should be
25801 generalized for MemberAccesses.
25802 (SimpleName::ResolveSimpleName): More work on simple name
25805 * cs-parser.jay (primary_expression/qualified_identifier): track
25806 the parameter index.
25808 * codegen.cs (CodeGen::Save): Catch save exception, report error.
25809 (EmitContext::EmitBoolExpression): Chain to expression generation
25810 instead of temporary hack.
25811 (::EmitStatementExpression): Put generic expression code generation.
25813 * assign.cs (Assign::Emit): Implement variable assignments to
25814 local variables, parameters and fields.
25816 2001-09-06 Miguel de Icaza <miguel@ximian.com>
25818 * statement.cs (Block::GetVariableInfo): New method, returns the
25819 VariableInfo for a variable name in a block.
25820 (Block::GetVariableType): Implement in terms of GetVariableInfo
25822 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
25823 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
25825 2001-09-06 Ravi Pratap <ravi@ximian.com>
25827 * cs-parser.jay (operator_declaration): Continue on my quest : update
25828 to take attributes argument.
25829 (event_declaration): Ditto.
25830 (enum_declaration): Ditto.
25831 (indexer_declaration): Ditto.
25833 * class.cs (Operator::Operator): Update constructor accordingly.
25834 (Event::Event): Ditto.
25836 * delegate.cs (Delegate::Delegate): Same here.
25838 * enum.cs (Enum::Enum): Same here.
25840 2001-09-05 Ravi Pratap <ravi@ximian.com>
25842 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
25844 * ../tests/cs0658.cs : New file to demonstrate error 0658.
25846 * attribute.cs (Attributes): New class to encapsulate all attributes which were
25847 being passed around as an arraylist.
25848 (Attributes::AddAttribute): Method to add attribute sections.
25850 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
25851 (struct_declaration): Update accordingly.
25852 (constant_declaration): Update.
25853 (field_declaration): Update.
25854 (method_header): Update.
25855 (fixed_parameter): Update.
25856 (parameter_array): Ditto.
25857 (property_declaration): Ditto.
25858 (destructor_declaration): Ditto.
25860 * class.cs (Struct::Struct): Update constructors accordingly.
25861 (Class::Class): Ditto.
25862 (Field::Field): Ditto.
25863 (Method::Method): Ditto.
25864 (Property::Property): Ditto.
25865 (TypeContainer::OptAttribute): update property's return type.
25867 * interface.cs (Interface.opt_attributes): New member.
25868 (Interface::Interface): Update to take the extra Attributes argument.
25870 * parameter.cs (Parameter::Parameter): Ditto.
25872 * constant.cs (Constant::Constant): Ditto.
25874 * interface.cs (InterfaceMemberBase): New OptAttributes field.
25875 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
25876 the attributes as a parameter.
25877 (InterfaceProperty): Update constructor call.
25878 (InterfaceEvent): Ditto.
25879 (InterfaceMethod): Ditto.
25880 (InterfaceIndexer): Ditto.
25882 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
25883 pass the attributes too.
25884 (interface_event_declaration): Ditto.
25885 (interface_property_declaration): Ditto.
25886 (interface_method_declaration): Ditto.
25887 (interface_declaration): Ditto.
25889 2001-09-05 Miguel de Icaza <miguel@ximian.com>
25891 * class.cs (Method::Define): Track the "static Main" definition to
25892 create an entry point.
25894 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
25895 EntryPoint if we find it.
25897 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
25898 (EmitContext::ig): Make this variable public.
25900 * driver.cs: Make the default output file be the first file name
25901 with the .exe extension.
25903 Detect empty compilations
25905 Handle various kinds of output targets. Handle --target and
25906 rename -t to --dumper.
25908 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
25909 methods inherited from Expression return now an Expression. This
25910 will is used during the tree rewriting as we resolve them during
25913 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
25914 the spec. Missing entirely is the information about
25915 accessability of elements of it.
25917 (Expression::ExprClassFromMemberInfo): New constructor for
25918 Expressions that creates a fully initialized Expression based on
25919 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
25922 (Invocation::Resolve): Begin implementing resolution of invocations.
25924 * literal.cs (StringLiteral): Implement Emit.
25926 2001-09-05 Ravi Pratap <ravi@ximian.com>
25928 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
25931 2001-09-04 Ravi Pratap <ravi@ximian.com>
25933 * cs-parser.jay (attribute_arguments): Implement actions.
25934 (attribute): Fix bug in production. Implement action.
25935 (attribute_list): Implement.
25936 (attribute_target): Implement.
25937 (attribute_target_specifier, opt_target_specifier): Implement
25938 (CheckAttributeTarget): New method to check if the attribute target
25940 (attribute_section): Implement.
25941 (opt_attributes): Implement.
25943 * attribute.cs : New file to handle attributes.
25944 (Attribute): Class to hold attribute info.
25946 * cs-parser.jay (opt_attribute_target_specifier): Remove production
25947 (attribute_section): Modify production to use 2 different rules to
25948 achieve the same thing. 1 s/r conflict down !
25949 Clean out commented, useless, non-reducing dimension_separator rules.
25951 * class.cs (TypeContainer.attributes): New member to hold list
25952 of attributes for a type.
25953 (Struct::Struct): Modify to take one more argument, the attribute list.
25954 (Class::Class): Ditto.
25955 (Field::Field): Ditto.
25956 (Method::Method): Ditto.
25957 (Property::Property): Ditto.
25959 * cs-parser.jay (struct_declaration): Update constructor call to
25960 pass in the attributes too.
25961 (class_declaration): Ditto.
25962 (constant_declaration): Ditto.
25963 (field_declaration): Ditto.
25964 (method_header): Ditto.
25965 (fixed_parameter): Ditto.
25966 (parameter_array): Ditto.
25967 (property_declaration): Ditto.
25969 * constant.cs (Constant::Constant): Update constructor similarly.
25970 Use System.Collections.
25972 * parameter.cs (Parameter::Parameter): Update as above.
25974 2001-09-02 Ravi Pratap <ravi@ximian.com>
25976 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
25977 (TypeContainer.delegates): New member to hold list of delegates.
25979 * cs-parser.jay (delegate_declaration): Implement the action correctly
25980 this time as I seem to be on crack ;-)
25982 2001-09-02 Miguel de Icaza <miguel@ximian.com>
25984 * rootcontext.cs (RootContext::IsNamespace): new function, used to
25985 tell whether an identifier represents a namespace.
25987 * expression.cs (NamespaceExpr): A namespace expression, used only
25988 temporarly during expression resolution.
25989 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
25990 utility functions to resolve names on expressions.
25992 2001-09-01 Miguel de Icaza <miguel@ximian.com>
25994 * codegen.cs: Add hook for StatementExpressions.
25996 * class.cs: Fix inverted test for static flag in methods.
25998 2001-09-02 Ravi Pratap <ravi@ximian.com>
26000 * class.cs (Operator::CheckUnaryOperator): Correct error number used
26001 to make it coincide with MS' number.
26002 (Operator::CheckBinaryOperator): Ditto.
26004 * ../errors/errors.txt : Remove error numbers added earlier.
26006 * ../errors/cs1019.cs : Test case for error # 1019
26008 * ../errros/cs1020.cs : Test case for error # 1020
26010 * cs-parser.jay : Clean out commented cruft.
26011 (dimension_separators, dimension_separator): Comment out. Ostensibly not
26012 used anywhere - non-reducing rule.
26013 (namespace_declarations): Non-reducing rule - comment out.
26015 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
26016 with TypeContainer::AddEnum.
26018 * delegate.cs : New file for delegate handling classes.
26019 (Delegate): Class for declaring delegates.
26021 * makefile : Update.
26023 * cs-parser.jay (delegate_declaration): Implement.
26025 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
26027 * class.cs (Event::Define): Implement.
26028 (Event.EventBuilder): New member.
26030 * class.cs (TypeContainer::Populate): Update to define all enums and events
26032 (Events): New property for the events arraylist we hold. Shouldn't we move to using
26033 readonly fields for all these cases ?
26035 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
26037 * class.cs (Property): Revamp to use the convention of making fields readonly.
26038 Accordingly modify code elsewhere.
26040 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
26041 the Define method of the Property class.
26043 * class.cs : Clean up applied patch and update references to variables etc. Fix
26045 (TypeContainer::Populate): Update to define all the properties we have. Also
26046 define all enumerations.
26048 * enum.cs (Define): Implement.
26050 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
26052 * cs-parser.jay (overloadable_operator): The semantic value is an
26053 enum of the Operator class.
26054 (operator_declarator): Implement actions.
26055 (operator_declaration): Implement.
26057 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
26058 validity of definitions.
26059 (Operator::CheckBinaryOperator): Static method to check for binary operators
26060 (TypeContainer::AddOperator): New method to add an operator to a type.
26062 * cs-parser.jay (indexer_declaration): Added line to actually call the
26063 AddIndexer method so it gets added ;-)
26065 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
26066 already taken care of by the MS compiler ?
26068 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
26070 * class.cs (Operator): New class for operator declarations.
26071 (Operator::OpType): Enum for the various operators.
26073 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
26075 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
26076 ostensibly handle this in semantic analysis.
26078 * cs-parser.jay (general_catch_clause): Comment out
26079 (specific_catch_clauses, specific_catch_clause): Ditto.
26080 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
26081 (catch_args, opt_catch_args): New productions.
26082 (catch_clause): Rewrite to use the new productions above
26083 (catch_clauses): Modify accordingly.
26084 (opt_catch_clauses): New production to use in try_statement
26085 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
26086 and re-write the code in the actions to extract the specific and
26087 general catch clauses by being a little smart ;-)
26089 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
26090 Hooray, try and catch statements parse fine !
26092 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
26094 * statement.cs (Block::GetVariableType): Fix logic to extract the type
26095 string from the hashtable of variables.
26097 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
26098 I end up making that mistake ;-)
26099 (catch_clauses): Fixed gross error which made Key and Value of the
26100 DictionaryEntry the same : $1 !!
26102 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
26104 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
26106 * cs-parser.jay (event_declaration): Correct to remove the semicolon
26107 when the add and remove accessors are specified.
26109 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
26111 * cs-parser.jay (IndexerDeclaration): New helper class to hold
26112 information about indexer_declarator.
26113 (indexer_declarator): Implement actions.
26114 (parsing_indexer): New local boolean used to keep track of whether
26115 we are parsing indexers or properties. This is necessary because
26116 implicit_parameters come into picture even for the get accessor in the
26117 case of an indexer.
26118 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
26120 * class.cs (Indexer): New class for indexer declarations.
26121 (TypeContainer::AddIndexer): New method to add an indexer to a type.
26122 (TypeContainer::indexers): New member to hold list of indexers for the
26125 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
26127 * cs-parser.jay (add_accessor_declaration): Implement action.
26128 (remove_accessor_declaration): Implement action.
26129 (event_accessors_declaration): Implement
26130 (variable_declarators): swap statements for first rule - trivial.
26132 * class.cs (Event): New class to hold information about event
26134 (TypeContainer::AddEvent): New method to add an event to a type
26135 (TypeContainer::events): New member to hold list of events.
26137 * cs-parser.jay (event_declaration): Implement actions.
26139 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
26141 * cs-parser.jay (dim_separators): Implement. Make it a string
26142 concatenating all the commas together, just as they appear.
26143 (opt_dim_separators): Modify accordingly
26144 (rank_specifiers): Update accordingly. Basically do the same
26145 thing - instead, collect the brackets here.
26146 (opt_rank_sepcifiers): Modify accordingly.
26147 (array_type): Modify to actually return the complete type string
26148 instead of ignoring the rank_specifiers.
26149 (expression_list): Implement to collect the expressions
26150 (variable_initializer): Implement. We make it a list of expressions
26151 essentially so that we can handle the array_initializer case neatly too.
26152 (variable_initializer_list): Implement.
26153 (array_initializer): Make it a list of variable_initializers
26154 (opt_array_initializer): Modify accordingly.
26156 * expression.cs (New::NType): Add enumeration to help us
26157 keep track of whether we have an object/delegate creation
26158 or an array creation.
26159 (New:NewType, New::Rank, New::Indices, New::Initializers): New
26160 members to hold data about array creation.
26161 (New:New): Modify to update NewType
26162 (New:New): New Overloaded contructor for the array creation
26165 * cs-parser.jay (array_creation_expression): Implement to call
26166 the overloaded New constructor.
26168 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
26170 * class.cs (TypeContainer::Constructors): Return member
26171 constructors instead of returning null.
26173 2001-08-26 Miguel de Icaza <miguel@ximian.com>
26175 * typemanager.cs (InitCoreTypes): Initialize the various core
26176 types after we have populated the type manager with the user
26177 defined types (this distinction will be important later while
26178 compiling corlib.dll)
26180 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
26181 on Expression Classification. Now all expressions have a method
26182 `Resolve' and a method `Emit'.
26184 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
26185 generation from working. Also add some temporary debugging
26188 2001-08-24 Miguel de Icaza <miguel@ximian.com>
26190 * codegen.cs: Lots of code generation pieces. This is only the
26191 beginning, will continue tomorrow with more touches of polish. We
26192 handle the fundamentals of if, while, do, for, return. Others are
26193 trickier and I need to start working on invocations soon.
26195 * gen-treedump.cs: Bug fix, use s.Increment here instead of
26198 * codegen.cs (EmitContext): New struct, used during code
26199 emission to keep a context. Most of the code generation will be
26202 * cs-parser.jay: Add embedded blocks to the list of statements of
26203 this block. So code generation proceeds in a top down fashion.
26205 2001-08-23 Miguel de Icaza <miguel@ximian.com>
26207 * statement.cs: Add support for multiple child blocks.
26209 2001-08-22 Miguel de Icaza <miguel@ximian.com>
26211 * codegen.cs (EmitCode): New function, will emit the code for a
26212 Block of code given a TypeContainer and its ILGenerator.
26214 * statement.cs (Block): Standard public readonly optimization.
26215 (Block::Block constructors): Link children.
26216 (Block::Child): Child Linker.
26217 (Block::EmitVariables): Emits IL variable declarations.
26219 * class.cs: Drop support for MethodGroups here, delay until
26221 (Method::): Applied the same simplification that I did before, and
26222 move from Properties to public readonly fields.
26223 (Method::ParameterTypes): Returns the parameter types for the
26224 function, and implements a cache that will be useful later when I
26225 do error checking and the semantic analysis on the methods is
26227 (Constructor::GetCallingConvention): Renamed from CallingConvetion
26228 and made a method, optional argument tells whether this is a class
26229 or a structure to apply the `has-this' bit.
26230 (Method::GetCallingConvention): Implement, returns the calling
26232 (Method::Define): Defines the type, a second pass is performed
26233 later to populate the methods.
26235 (Constructor::ParameterTypes): implement a cache similar to the
26236 one on Method::ParameterTypes, useful later when we do semantic
26239 (TypeContainer::EmitMethod): New method. Emits methods.
26241 * expression.cs: Removed MethodGroup class from here.
26243 * parameter.cs (Parameters::GetCallingConvention): new method.
26245 2001-08-21 Miguel de Icaza <miguel@ximian.com>
26247 * class.cs (TypeContainer::Populate): Drop RootContext from the
26250 (Constructor::CallingConvention): Returns the calling convention.
26251 (Constructor::ParameterTypes): Returns the constructor parameter
26254 (TypeContainer::AddConstructor): Keep track of default constructor
26255 and the default static constructor.
26257 (Constructor::) Another class that starts using `public readonly'
26258 instead of properties.
26260 (Constructor::IsDefault): Whether this is a default constructor.
26262 (Field::) use readonly public fields instead of properties also.
26264 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
26265 track of static constructors; If none is used, turn on
26266 BeforeFieldInit in the TypeAttributes.
26268 * cs-parser.jay (opt_argument_list): now the return can be null
26269 for the cases where there are no arguments.
26271 (constructor_declarator): If there is no implicit `base' or
26272 `this', then invoke the default parent constructor.
26274 * modifiers.cs (MethodAttr): New static function maps a set of
26275 modifiers flags into a MethodAttributes enum
26276 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
26277 MethodAttr, TypeAttr to represent the various mappings where the
26278 modifiers are used.
26279 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
26281 2001-08-19 Miguel de Icaza <miguel@ximian.com>
26283 * parameter.cs (GetParameterInfo): Fix bug where there would be no
26286 * interface.cs (PopulateIndexer): Implemented the code generator
26287 for interface indexers.
26289 2001-08-17 Miguel de Icaza <miguel@ximian.com>
26291 * interface.cs (InterfaceMemberBase): Now we track the new status
26294 (PopulateProperty): Implement property population. Woohoo! Got
26295 Methods and Properties going today.
26297 Removed all the properties for interfaces, and replaced them with
26298 `public readonly' fields.
26300 2001-08-16 Miguel de Icaza <miguel@ximian.com>
26302 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
26303 initialize their hashtables/arraylists only when they are needed
26304 instead of doing this always.
26306 * parameter.cs: Handle refs and out parameters.
26308 * cs-parser.jay: Use an ArrayList to construct the arguments
26309 instead of the ParameterCollection, and then cast that to a
26312 * parameter.cs: Drop the use of ParameterCollection and use
26313 instead arrays of Parameters.
26315 (GetParameterInfo): Use the Type, not the Name when resolving
26318 2001-08-13 Miguel de Icaza <miguel@ximian.com>
26320 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
26321 and instead use public readonly fields.
26323 * class.cs: Put back walking code for type containers.
26325 2001-08-11 Miguel de Icaza <miguel@ximian.com>
26327 * class.cs (MakeConstant): Code to define constants.
26329 * rootcontext.cs (LookupType): New function. Used to locate types
26332 2001-08-08 Miguel de Icaza <miguel@ximian.com>
26334 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
26335 this System.Reflection code is. Kudos to Microsoft
26337 * typemanager.cs: Implement a type cache and avoid loading all
26338 types at boot time. Wrap in LookupType the internals. This made
26339 the compiler so much faster. Wow. I rule!
26341 * driver.cs: Make sure we always load mscorlib first (for
26342 debugging purposes, nothing really important).
26344 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
26345 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
26347 * rootcontext.cs: Lookup types on their namespace; Lookup types
26348 on namespaces that have been imported using the `using' keyword.
26350 * class.cs (TypeContainer::TypeAttr): Virtualize.
26351 (Class::TypeAttr): Return attributes suitable for this bad boy.
26352 (Struct::TypeAttr): ditto.
26353 Handle nested classes.
26354 (TypeContainer::) Remove all the type visiting code, it is now
26355 replaced with the rootcontext.cs code
26357 * rootcontext.cs (GetClassBases): Added support for structs.
26359 2001-08-06 Miguel de Icaza <miguel@ximian.com>
26361 * interface.cs, statement.cs, class.cs, parameter.cs,
26362 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
26363 Drop use of TypeRefs, and use strings instead.
26365 2001-08-04 Miguel de Icaza <miguel@ximian.com>
26369 * class.cs (Struct::Struct): set the SEALED flags after
26370 checking the modifiers.
26371 (TypeContainer::TypeAttr): new property, returns the
26372 TypeAttributes for a class.
26374 * cs-parser.jay (type_list): Oops, list production was creating a
26375 new list of base types.
26377 * rootcontext.cs (StdLib): New property.
26378 (GetInterfaceTypeByName): returns an interface by type name, and
26379 encapsulates error handling here.
26380 (GetInterfaces): simplified.
26381 (ResolveTree): Encapsulated all the tree resolution here.
26382 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
26385 * driver.cs: Add support for --nostdlib, to avoid loading the
26386 default assemblies.
26387 (Main): Do not put tree resolution here.
26389 * rootcontext.cs: Beginning of the class resolution.
26391 2001-08-03 Miguel de Icaza <miguel@ximian.com>
26393 * rootcontext.cs: Provide better error reporting.
26395 * cs-parser.jay (interface_base): set our $$ to be interfaces.
26397 * rootcontext.cs (CreateInterface): Handle the case where there
26398 are no parent interfaces.
26400 (CloseTypes): Routine to flush types at the end.
26401 (CreateInterface): Track types.
26402 (GetInterfaces): Returns an array of Types from the list of
26403 defined interfaces.
26405 * typemanager.c (AddUserType): Mechanism to track user types (puts
26406 the type on the global type hash, and allows us to close it at the
26409 2001-08-02 Miguel de Icaza <miguel@ximian.com>
26411 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
26412 RecordInterface instead.
26414 * cs-parser.jay: Updated to reflect changes above.
26416 * decl.cs (Definition): Keep track of the TypeBuilder type that
26417 represents this type here. Not sure we will use it in the long
26418 run, but wont hurt for now.
26420 * driver.cs: Smaller changes to accomodate the new code.
26422 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
26425 * rootcontext.cs (CreateInterface): New method, used to create
26426 the System.TypeBuilder type for interfaces.
26427 (ResolveInterfaces): new entry point to resolve the interface
26429 (CodeGen): Property, used to keep track of the code generator.
26431 2001-07-26 Miguel de Icaza <miguel@ximian.com>
26433 * cs-parser.jay: Add a second production for delegate_declaration
26436 (enum_body): Put an opt_comma here instead of putting it on
26437 enum_body or enum_member_declarations so we can handle trailing
26438 commas on enumeration members. Gets rid of a shift/reduce.
26440 (type_list): Need a COMMA in the middle.
26442 (indexer_declaration): Tell tokenizer to recognize get/set
26444 * Remove old targets.
26446 * Re-add the parser target.
26448 2001-07-13 Simon Cozens <simon@simon-cozens.org>
26450 * cs-parser.jay: Add precendence rules for a number of operators
26451 ot reduce the number of shift/reduce conflicts in the grammar.
26453 2001-07-17 Miguel de Icaza <miguel@ximian.com>
26455 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
26458 Get rid of old crufty code.
26460 * rootcontext.cs: Use this to keep track of the parsed
26461 representation and the defined types available to the program.
26463 * gen-treedump.cs: adjust for new convention.
26465 * type.cs: Split out the type manager, and the assembly builder
26468 * typemanager.cs: the type manager will live here now.
26470 * cil-codegen.cs: And the code generator here.
26472 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
26474 * makefile: Fixed up for easy making.
26476 2001-07-13 Simon Cozens <simon@simon-cozens.org>
26478 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
26481 (unary_expression): Expand pre_increment_expression and
26482 post_decrement_expression to reduce a shift/reduce.
26484 2001-07-11 Simon Cozens
26486 * cs-tokenizer.cs: Hex numbers should begin with a 0.
26488 Improve allow_keyword_as_indent name.
26490 2001-06-19 Miguel de Icaza <miguel@ximian.com>
26492 * Adjustments for Beta2.
26494 2001-06-13 Miguel de Icaza <miguel@ximian.com>
26496 * decl.cs: Added `Define' abstract method.
26497 (InTransit): new property, used to catch recursive definitions.
26499 * interface.cs: Implement `Define'.
26501 * modifiers.cs: Map Modifiers.constants to
26502 System.Reflection.TypeAttribute flags.
26504 * class.cs: Keep track of types and user-defined types.
26505 (BuilderInit): New method for creating an assembly
26506 (ResolveType): New function to launch the resolution process, only
26507 used by interfaces for now.
26509 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
26510 that are inserted into the name space.
26512 2001-06-08 Miguel de Icaza <miguel@ximian.com>
26514 * ARGH. I have screwed up my tree so many times due to the use of
26515 rsync rather than using CVS. Going to fix this at once.
26517 * driver.cs: Objetify driver. Load assemblies, use assemblies to
26520 2001-06-07 Miguel de Icaza <miguel@ximian.com>
26522 * Experiment successful: Use System.Type rather that our own
26525 2001-05-25 Miguel de Icaza <miguel@ximian.com>
26527 * cs-parser.jay: Removed nsAliases from here.
26529 Use new namespaces, handle `using XXX;'
26531 * namespace.cs: Reimplemented namespace handling, use a recursive
26532 definition of the class. Now we can keep track of using clauses
26533 and catch invalid using clauses.
26535 2001-05-24 Miguel de Icaza <miguel@ximian.com>
26537 * gen-treedump.cs: Adapted for all the renaming.
26539 * expression.cs (Expression): this class now has a Type property
26540 which returns an expression Type.
26542 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
26543 `Type', as this has a different meaning now in the base
26545 2001-05-22 Miguel de Icaza <miguel@ximian.com>
26547 * interface.cs, class.cs: Removed from all the sources the
26548 references to signature computation, as we can not do method
26549 signature computation during the parsing time, as we are not
26550 trying to solve at that point distinguishing:
26554 void a (NS.Blah x) {}
26557 Which depending on the context might be valid or not, as we do not
26558 know if Blah is the same thing as NS.Blah at that point.
26560 * Redid everything so the code uses TypeRefs now instead of
26561 Types. TypeRefs are just temporary type placeholders, that need
26562 to be resolved. They initially have a pointer to a string and the
26563 current scope in which they are used. This is used later by the
26564 compiler to resolve the reference to an actual Type.
26566 * DeclSpace is no longer a CIR.Type, and neither are
26567 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
26568 are all DeclSpaces, but no Types.
26570 * type.cs (TypeRefManager): This implements the TypeRef manager,
26571 which keeps track of all the types that need to be resolved after
26572 the parsing has finished.
26574 2001-05-13 Miguel de Icaza <miguel@ximian.com>
26576 * ARGH. We are going to have to store `foreach' as a class rather
26577 than resolving it, as we need to verify error 1579 after name
26578 resolution. *OR* we could keep a flag that says `This request to
26579 IEnumerator comes from a foreach statement' which we can then use
26580 to generate the error.
26582 2001-05-10 Miguel de Icaza <miguel@ximian.com>
26584 * class.cs (TypeContainer.AddMethod): we now add methods to the
26585 MethodGroup instead of the method hashtable.
26587 * expression.cs: Add MethodGroup abstraction, which gets us one
26588 step closer to the specification in the way we handle method
26591 * cs-parser.jay (primary_expression): qualified_identifier now
26592 tried to match up an identifier to a local variable reference or
26593 to a parameter reference.
26595 current_local_parameters is now a parser global variable that
26596 points to the current parameters for the block, used during name
26599 (property_declaration): Now creates an implicit `value' argument to
26602 2001-05-09 Miguel de Icaza <miguel@ximian.com>
26604 * parameter.cs: Do not use `param' arguments as part of the
26605 signature, per the spec.
26607 2001-05-08 Miguel de Icaza <miguel@ximian.com>
26609 * decl.cs: Base class for classes, structs and interfaces. This
26610 is the "Declaration Space"
26612 * cs-parser.jay: Use CheckDef for checking declaration errors
26613 instead of having one on each function.
26615 * class.cs: Factor out some code for handling error handling in
26616 accordance to the "Declarations" section in the "Basic Concepts"
26617 chapter in the ECMA C# spec.
26619 * interface.cs: Make all interface member classes derive from
26620 InterfaceMemberBase.
26622 2001-05-07 Miguel de Icaza <miguel@ximian.com>
26624 * Many things: all interfaces are parsed and generated in
26625 gen-treedump. Support for member variables, constructors,
26626 destructors, properties, constants is there.
26628 Beginning of the IL backend, but very little done, just there for
26631 2001-04-29 Miguel de Icaza <miguel@ximian.com>
26633 * cs-parser.jay: Fix labeled statement.
26635 * cs-tokenizer.cs (escape): Escape " and ' always.
26636 ref_line, ref_name: keep track of the line/filename as instructed
26637 by #line by the compiler.
26640 2001-04-27 Miguel de Icaza <miguel@ximian.com>
26642 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
26643 to match the values in System.CodeDOM.
26645 Divid renamed to Divide.
26647 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
26649 (Statements.set): remove.
26651 * System.CodeDOM/CodeCatchClause.cs: always have a valid
26654 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
26655 falseStatements always have valid values.
26657 * cs-parser.jay: Use System.CodeDOM now.