1 2005-03-07 Martin Baulig <martin@ximian.com>
3 * generic.cs (Nullable.Unwrap): Implement IMemoryLocation and make
4 it work if `expr' is not an IMemoryLocation.
5 (Nullable.Lifted): Implement IMemoryLocation.
6 (Nullable.LiftedConversion.ResolveUnderlying): Use the correct
9 2005-03-05 Martin Baulig <martin@ximian.com>
11 * generic.cs (Nullable.Unwrap, Wrap): New protected classes.
12 (Nullable.Lifted): New abstract class; rewrote the lifted conversions.
13 (Nullable): Added support for lifted unary and binary operators.
15 * expression.cs (Unary.DoResolve): Added support for nullable types.
16 (Binary.DoResolve): Likewise.
17 (Conditional.DoResolve): Likewise.
19 2005-03-02 Martin Baulig <martin@ximian.com>
21 * decl.cs (DeclSpace.SetParameterInfo): Make this virtual.
23 * class.cs (ClassPart.SetParameterInfo): Override this.
24 (PartialContainer.SetParameterInfo): Override this.
25 (TypeContainer.CheckConstraints): New protected method.
26 (PartialContainer.CheckConstraints): Override this and check
27 whether the same contraints were specified in all parts of a
28 partial generic type definition.
29 (PartialContainer.UpdateConstraints): New public method.
31 * generic.cs (TypeParameter.UpdateConstraints): New public method.
33 2005-03-02 Martin Baulig <martin@ximian.com>
35 Committing a patch from Carlos Alberto Cortez to fix #72887.
37 * convert.cs (Convert.ExplicitReferenceConversionExists): Allow
38 casts from `T []' to `int []'.
40 2005-03-02 Martin Baulig <martin@ximian.com>
42 * generic.cs (TypeManager.IsEqual): Make this symmetric.
44 * expression.cs (Binary.ResolveOperator): When resolving a
45 BinaryDelegate, use `TypeManager.IsEqual (l, r)' rather than just
46 `=='. Fixes #71866. See gen-127.cs.
48 2005-03-02 Martin Baulig <martin@ximian.com>
50 * class.cs (TypeContainer.DoDefineMembers): We also need a default
51 static constructor in static classes.
53 2005-03-02 Martin Baulig <martin@ximian.com>
56 (NullableType.Name, NullableType.FullName): Add a "?" to the name.
57 (Nullable.LiftedConversion): Added support for user-defined
60 * cs-tokenizer.cs (Tokenizer.PutbackCloseParens): New public method.
62 * cs-parser.jay: Use ComposedCast everywhere instead of
63 NullableType, so we don't need to check for NullableType
65 (conditional_expression): Added `INTERR CLOSE_PARENS' rule for the
66 case where we'll be resolved into a `parenthesized_expression_0'
70 (Convert.UserDefinedConversion): Added nullable conversions.
72 2005-02-28 Martin Baulig <martin@ximian.com>
74 * generic.cs (TypeManager.IsNullableType): New static method.
75 (Nullable): New abstract class.
76 (Nullable.NullLiteral): New public class.
77 (Nullable.LiftedConversion): New public class.
79 * cs-parser.jay (non_expression_type): Changed `builtin_types' to
80 `builtin_types opt_nullable'.
83 (Convert.ImplicitConversionStandard): Added nullable conversions.
84 (Convert.ExplicitConversionStandard): Likewise.
85 (Convert.ExplicitConversion): Likewise.
87 2005-02-26 Martin Baulig <martin@ximian.com>
89 * expression.cs (ComposedCast.DoResolveAsTypeStep): Allow `dim' to
90 begin with a "?", for instance "?[]". Don't do a type lookup if
93 2005-02-25 Martin Baulig <martin@ximian.com>
95 The first part of Nullable Types :-)
97 * generic.cs (NullableType): New public class.
98 (NullCoalescingOperator): New public class.
99 (TypeArguments.Resolve): Add a CS0306 check.
101 * cs-parser.jay (opt_error_modifier): Removed, this was unused.
102 (opt_nullable): New rule.
103 (type): Added `opt_nullable' to `namespace_or_type_name',
104 `builtin_types' and `pointer_type'.
105 (array_type): Added `opt_nullable'.
106 (opt_rank_specifier_or_nullable): New rule; this is the
107 combination of `opt_rank_specifier' and `opt_nullable'.
108 (opt_error): New rule; catch errors here.
109 (nullable_type_or_conditional): New rule; we use this to check for
110 nullable and still detect the conditional operator.
111 (local_variable_type): Use `opt_rank_specifier_or_nullable'
112 instead `opt_rank_specifier'.
114 * expression.cs (ComposedCast.DoResolveAsTypeStep): Added support
117 2005-02-24 Martin Baulig <martin@ximian.com>
119 * README, README.Changes: Removed; they're old and obsolete.
121 2005-02-22 Martin Baulig <martin@ximian.com>
123 * generic.cs (TypeParameter.Resolve): If resolving the constraints
124 returned an error, set `constraints' to null to avoid a crash
126 (TypeParameter.ResolveType): Likewise.
128 2005-02-22 Martin Baulig <martin@ximian.com>
131 (Constraints.ResolveTypes): Protect against being called twice.
132 (Constraints.CheckInterfaceMethod): Don't call ResolveTypes().
133 (TypeParameter.ResolveType): New public method; calls
134 constraints.ResolveTypes().
135 (TypeParameter.DefineType): Moved constraints.ResolveType() out
136 into the new ResolveType().
137 (GenericMethod.Define): Call ResolveType() on all our
140 2005-02-21 Martin Baulig <martin@ximian.com>
143 (TypeManager.generic_nullable_type): New static public field.
144 (TypeManager.InitGenericCoreType): Lookup "System.Nullable`1".
147 (RootContext.ResolveCore): Resolve "System.Nullable`1".
149 2005-02-15 Martin Baulig <martin@ximian.com>
151 * generic.cs (ConstructedType.Constraints): Correctly check
152 constraints if the argument type is a type parameter; fixes
155 2005-02-02 Martin Baulig <martin@ximian.com>
157 * delegate.cs (Delegate.DefineType): Report an internal error if
158 TypeManager.multicast_delegate_type is null. See bug #72015 for
161 2005-01-29 Miguel de Icaza <miguel@novell.com>
163 * pending.cs: Produce better code (no nops produced by using Ldarg
166 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
167 i - 1' it should be arg + 1.
171 2005-01-26 Martin Baulig <martin@ximian.com>
173 * cs-parser.jay (indexer_declarator): Don't report an error if we
174 have type parameters since we can be an explicit interface
175 implementation; fixes #71449.
177 2005-01-26 Martin Baulig <martin@ximian.com>
179 * class.cs (TypeContainer.AttributeTargets): Return the correct
180 AttributeTargets depending on our `Kind' instead of throwing an
181 exception; fixes #71632.
183 2005-01-26 Martin Baulig <martin@ximian.com>
185 * delegate.cs (Delegate.DefineType): Correctly define our type
186 parameters. Fixes #71483.
188 2005-01-25 Raja R Harinath <rharinath@novell.com>
191 * expression.cs (MemberAccess.DoResolve): Don't complain with
192 cs0572 when the LHS of a member access has identical name and type
195 2005-01-25 Marek Safar <marek.safar@seznam.cz>
198 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
200 Create custom PermissionSet only for PermissionSetAttribute.
202 2005-01-24 Marek Safar <marek.safar@seznam.cz>
205 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
206 delegates in static class.
208 2005-01-24 Martin Baulig <martin@ximian.com>
210 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
211 merging an implicit block, just use its reachability.
213 * statement.cs (Block.Resolve): Make the unreachable code check
214 work wrt. implicit blocks; see test-337 from #63842.
216 2005-01-21 Alp Toker <alp@atoker.com>
218 * cs-parser.jay: destructor_declaration's container is PartialContainer
219 not Class when partial types are used, so use Kind prop instead of
222 2005-01-22 Miguel de Icaza <miguel@ximian.com>
224 * cs-parser.jay: Improve error reporting when an interface
227 2005-01-20 Dick Porter <dick@ximian.com>
229 * support.cs: SeekableStreamReader fix from Sandor Dobos
230 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
231 chars are read. Fixes bug 70369.
233 2005-01-20 Raja R Harinath <rharinath@novell.com>
235 * cs-parser.jay (catch_clause): Simplify current_block handling
238 2005-01-17 Miguel de Icaza <miguel@ximian.com>
240 * convert.cs (ImplicitStandardConversionExists): Synchronize the
241 code with ImplicitStandardConversion to handle the implicit
242 conversion of method groups into valid delegate invocations.
244 The problem is that in parameter handling we were using this code
245 path. Fixes bug #64698
247 2005-01-19 Raja R Harinath <rharinath@novell.com>
249 * cs-parser.jay: Fix several infelicities.
250 - Avoid assigning to the parser value stack. Code like
251 '$3 = null' is unclean. Synthesize a value for the code block
253 - Avoid using oob_stack for storing location information. Use ...
254 (_mark_): ... this. New (empty) rule. Saves the current location
256 (foreach_statement): Avoid using oob_stack for current_block
257 handling. Use technique used in for_statement and
258 using_statement. Synthesize a value for the code block to store
259 additional intermediate information.
261 2005-01-13 Miguel de Icaza <miguel@ximian.com>
263 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
264 of a different type is only allowed to private fields of a
265 containing type, not on fields of a base class.
267 See test-174.cs and error cs0122-9.cs
269 2005-01-13 Raja R Harinath <rharinath@novell.com>
271 Fix test-335.cs (bug #58126).
272 * cs-parser.jay (argument): Split out non-expression parts of the
273 rule into 'non_simple_argument'.
274 (invocation_expression): Support parenthesized invocations with
275 multiple arguments, and with single non-simple arguments.
277 2005-01-13 Raja R Harinath <rharinath@novell.com>
279 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
282 2005-01-12 Raja R Harinath <rharinath@novell.com>
284 Fix cs0038-1.cs, cs1640-6.cs.
285 * ecore.cs (Expression.Resolve): Remove special-case for
286 SimpleName in error-handling.
287 (Expression.almostMatchedMembers): Relax access permission to
289 (Expression.MemberLookupFailed): Handle duplicates in
290 almostMatchedMembers list.
291 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
292 * expression.cs (New.DoResolve): Report CS1540 for more cases.
293 * typemanager.cs (GetFullNameSignature): Use the MethodBase
294 overload if the passed in MemberInfo is a MethodBase.
296 2005-01-25 Martin Baulig <martin@ximian.com>
299 (DocUtil.emptyParamList): Removed; use `Type.EmptyTypes' instead.
301 2005-01-12 Marek Safar <marek.safar@seznam.cz>
304 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
305 for non-CAS & merge permission sets properly.
307 2005-01-11 Raja R Harinath <rharinath@novell.com>
309 Improve standard-compliance of simple name and member access
310 resolution. Fixes bugs #52697, #57200, #67520, #69519.
311 * ecore.cs (FullNamedExpression): New abstract base class
312 for Namespaces and TypeExpressions.
313 (ResolveFlags.SimpleName): Remove.
314 (SimpleName): Remove support for dotted names.
315 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
316 DeclSpace.FindType and DeclSpace.LookupType.
317 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
318 (Expression.ExprClassName): Make member function.
319 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
320 a namespace. Remove creation of dotted "SimpleName"s.
321 (MemberAccess.DoResolve): Likewise.
322 * decl.cs (DeclSpace.Cache): Make private.
323 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
324 (DeclSpace.FindType): Update.
325 (DeclSpace.LookupType): Move here from RootContext. Return a
327 * namespace.cs (Namespace): Derive from FullNamedExpression
328 so that it can be part of expression resolution.
329 (Namespace.Lookup): Return an FullNamedExpression.
330 (NamespaceEntry.LookupAlias): Lookup aliases only in current
332 * rootcontext.cs (NamespaceLookup): Remove.
333 (LookupType): Move to DeclSpace.
334 * attribute.cs (CheckAttributeType): Update.
335 * doc.cs (FindDocumentedType): Remove allowAlias argument.
336 (FindDocumentedTypeNonArray): Likewise.
338 2005-01-11 Raja R Harinath <rharinath@novell.com>
340 Fix cs0509.cs, cs1632.cs.
341 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
342 is the same as IsInterface.
343 (TypeContainer.GetClassBases): Likewise.
344 * statement.cs (LabeledStatement.ig): New field.
345 (LabeledStatement.LabelTarget): Save ILGenerator which created the
347 (LabeledStatement.DoEmit): Check that the label was created with
348 the same ILGenerator.
350 2005-01-10 Marek Safar <marek.safar@seznam.cz>
353 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
354 accessors to its properties.
356 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
357 from accessors to property.
359 2005-01-10 Marek Safar <marek.safar@seznam.cz>
362 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
365 2005-01-08 Miguel de Icaza <miguel@ximian.com>
367 * attribute.cs: Check for null and empty strings.
369 I have lost another battle to Paolo.
371 2005-01-07 Marek Safar <marek.safar@seznam.cz>
374 * class.cs (PropertyMethod): Set Parent field in ctors.
375 (SetMethod.InternalParameters): Add unsafe switch hack.
376 Override MarkForDuplicationCheck where it is appropriate.
378 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
379 It says whether container allows members with the same name.
381 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
382 Removed is_method parameter.
384 2005-01-06 Duncan Mak <duncan@ximian.com>
386 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
387 because the previous change led to incorrect reporting of CS1032
388 ("Cannot define/undefine preprocessor symbols after first token in
389 file"). Instead of using `tokens_seen' as the only flag that
390 triggers CS1040, introduce `comments_seen'. This new flag is used
391 to signify having seen comments on the current line, so it is
392 unset after a newline.
394 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
396 * doc.cs : When searching for a type, find nested type too.
397 This fixes bug #71040.
399 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
402 - Warn missing member comment on those classes which also does not
403 have doc comments. Fixed bug #71041.
404 - Don't warn missing doc comment on default constructor.
407 2005-01-06 Duncan Mak <duncan@ximian.com>
409 * cs-tokenizer.cs (xtoken): After handling traditional C-style
410 comments, set `tokens_seen' to true. This allows us to detect
411 misplaced preprocessor directives (i.e. not at the beginning of
412 the a line, nor after whitespaces). In that case, report error
413 CS1040. This fixes bug #56460.
415 * cs-parser.jay (interface_member_declaration): Add checks for
416 IsExplicitImpl, and report CS0541 error if an interface member is
417 defined as an explicit interface declaration.
419 2005-01-06 Marek Safar <marek.safar@seznam.cz>
422 * class.cs (PropertyMethod): Set Parent field in ctors.
423 (SetMethod.InternalParameters): Add unsafe switch hack.
425 * decl.cs (MemberCore.Parent): Cannot be readonly.
427 2005-01-06 Raja R Harinath <rharinath@novell.com>
429 * decl.cs (DeclSpace.ResolveType): Remove.
430 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
431 Merge in code from ...
432 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
433 * class.cs, enum.cs: Update to changes.
435 2005-01-06 Miguel de Icaza <miguel@ximian.com>
437 * anonymous.cs: Ensure that we init the scope of our parent if it
438 has not been initialized yet.
440 2004-12-30 Duncan Mak <duncan@ximian.com>
442 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
443 if field.FieldBuilder is null. Fixes #70758.
445 * convert.cs: Fixed some typos and updated some of the comments.
446 (ImplicitStandardConversionExists):
447 (TryImplicitIntConversion): If `target_type' is an interface and
448 the type of `ic' implements this interface, return true or a new
449 BoxedCast instead of null. This fixes #70468.
451 2004-12-29 Duncan Mak <duncan@ximian.com>
453 * expression.cs (Argument.Emit): Check that Expr is
454 IMemoryLocation before casting to it, and report CS1510 otherwise.
458 2004-12-21 Ben Maurer <bmaurer@ximian.com>
460 * statement.cs (Block.ThisVariable): remove the recursion here, to
461 make the --profile more sane.
463 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
465 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
466 assembly, by JB Evain.
468 2004-12-17 Raja R Harinath <rharinath@novell.com>
470 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
471 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
472 "parent" refers to enclosing type/class. "base" refers to superclass.
474 2004-12-17 Raja R Harinath <rharinath@novell.com>
476 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
477 Ensure that we only have GlobalAttributes.
478 * attribute.cs (Attribute.Emit): Make non-virtual.
479 (GlobalAttribute.Emit): Remove.
480 (Attribute.Resolve): Make virtual.
481 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
482 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
483 the argument. Don't create one.
484 (Attribute.GetObsoleteAttribute): Likewise.
485 (Attribute.GetClsCompliantAttributeValue): Likewise.
486 * class.cs, decl.cs: Update to changes.
488 2004-12-17 Marek Safar <marek.safar@seznam.cz>
490 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
492 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
494 * statement.cs (Foreach.Resolve): Add error 186 report.
496 2004-12-16 Marek Safar <marek.safar@seznam.cz>
498 * expression.cs (Conditional.DoResolve): Add warning 429.
500 * statement.cs (If.Resolve): Add warning 665.
502 2004-12-16 Raja R Harinath <rharinath@novell.com>
504 New invariant: RootContext.Tree.Types.NamespaceEntry == null
505 except when in the parser, and in GlobalAttribute.
506 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
507 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
508 RootContext.Tree.Types.NamespaceEntry once work is done.
509 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
510 and resets RootContext.Tree.Types.NamespaceEntry.
512 2004-12-15 Marek Safar <marek.safar@seznam.cz>
514 * cs-parser.jay: Don't create a block for every variable.
516 2004-12-14 Miguel de Icaza <miguel@ximian.com>
518 * location.cs: Provide extra information.
520 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
521 variables from the captured environment, it is the ldarg_0.
523 2004-12-14 Marek Safar <marek.safar@seznam.cz>
525 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
528 * class.cs: Changed warning level for 169 to avoid developer
529 displeasure from warning flooding. It will be changed back when they
530 fix most of current BCL warnings.
532 * RootContext.cs: Pushed default WarningLevel to 3.
534 * statement.cs: Removed unused variable.
536 2004-12-14 Marek Safar <marek.safar@seznam.cz>
538 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
539 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
540 Add error 502 report.
541 (StaticClass.DefineType): Add error 441 report.
542 (Class.AllowedModifiersProp): New virtual property as temporary
543 extension to AllowedModifiers.
544 (Class.DefineType): Add error 418 report. Moved ModFlags check here
545 to share implementation with StaticClass and don't call virtual
548 * driver.cs (MainDriver): Add error 1558 test.
550 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
551 report. Moved error 36 test here.
553 * statement.cs (Throw.Resolve): Add error 724 report.
555 * typemanager.cs: Add out_attribute_type core type.
557 2004-12-13 Marek Safar <marek.safar@seznam.cz>
559 * class.cs (TypeContainer.VerifyClsCompliance): Add error
561 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
563 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
566 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
568 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
569 Add error 3023 report.
570 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
572 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
575 2004-12-12 John Luke <john.luke@gmail.com>
577 * driver.cs (AddArgs): take -- into account when
578 adding arguments, fixes bug 65710
580 2004-12-12 Martin Baulig <martin@ximian.com>
582 * expression.cs (Unary.TryReduceNegative): Added support for
583 SByteConstant and ByteConstant.
584 (Unary.Reduce): Check error values from TryReduceNegative().
586 2004-12-10 Marek Safar <marek.safar@seznam.cz>
588 * attributes.cs (Attribute.Resolve): Avoid multiple error report
589 and report exception as error 182.
591 2004-12-10 Raja R Harinath <rharinath@novell.com>
593 * driver.cs (Main): Fix message when there are warnings.
595 2004-12-09 Miguel de Icaza <miguel@ximian.com>
597 * delegate.cs: Fixed my fix from yesterday, sorry about that.
599 2004-12-09 Marek Safar <marek.safar@seznam.cz>
601 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
602 Reduced number of warnings.
604 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
606 2004-12-08 Miguel de Icaza <miguel@ximian.com>
608 * driver.cs: Removed message.
610 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
612 2004-12-08 <vargaz@freemail.hu>
614 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
616 2004-12-08 Martin Baulig <martin@ximian.com>
618 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
619 instead of a CS3002 for properties and indexer.
621 2004-12-08 Martin Baulig <martin@ximian.com>
623 * decl.cs (MemberName.ToString): Make this work again.
625 2004-12-08 Marek Safar <marek.safar@seznam.cz>
627 * attribute.cs (Resolve): Add error 591 detection.
629 * class.cs (FieldMember.Define): Add error 1547 detection.
630 (Indexer.Define): Add error 620 detection.
631 (Operator.Define): Add error 590 detection.
633 * ecore.cs: Missing argument for error 79.
635 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
638 2004-12-07 Marek Safar <marek.safar@seznam.cz>
641 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
644 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
646 * cs-parser.jay : handle doc comments on implicit/explicit operators.
647 Some operator comments were suppressed.
648 * doc.cs : Implicit/explicit operator name in doc comments are like
649 "op_Explicit(type)~returnType", so added suffix handling.
651 2005-01-21 Alp Toker <alp@atoker.com>
653 * cs-parser.jay: destructor_declaration's container is PartialContainer
654 not Class when partial types are used, so use Kind prop instead of 'is'.
656 2004-12-12 Martin Baulig <martin@ximian.com>
658 * expression.cs (Unary.TryReduceNegative): Added support for
659 SByteConstant and ByteConstant.
660 (Unary.Reduce): Check error values from TryReduceNegative().
662 2004-12-11 Martin Baulig <martin@ximian.com>
664 * support.cs (ReflectionParameters.ParameterName): If we have a
665 `gpd', call `ParameterName' on it.
667 * parameter.cs (Parameter.GetParameterAttributes): New static method.
669 * pending.cs (PendingImplementation.DefineProxy): Call
670 DefineParameter() for all of the MethodBuilder's arguments.
672 2004-12-09 Martin Baulig <martin@ximian.com>
674 * doc.cs (DocUtil): Make this a static class.
676 2004-12-09 Martin Baulig <martin@ximian.com>
678 * expression.cs (Invocation.InferType): Moved the type inference
679 implementation into TypeManager.
681 * generics.cs (TypeManager): Moved the type inference
684 2004-12-09 Martin Baulig <martin@ximian.com>
686 * typemanager.cs (TypeManager): Make this a partial class.
689 (TypeManager): Move the generics part of `TypeManager' here.
691 2004-12-08 Martin Baulig <martin@ximian.com>
693 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
694 instead of a CS3002 for properties and indexer. Added CS3024
695 check for generic interfaces.
697 * attributes.cs (AttributeTester.AnalyzeTypeCompliance): Generic
698 instances are not CLS-compliant.
700 2004-12-08 Martin Baulig <martin@ximian.com>
703 (void_pointer_expression): New rule for `void*', `void**' etc.
704 (typeof_expression): Add `void_pointer_expression'; fixes #66846.
706 2004-12-08 Martin Baulig <martin@ximian.com>
708 * expression.cs (Invocation.InferType): Removed the hack for
709 MethodCore.MayUnify().
711 * typemanager.cs (TypeManager.MayBecomeEqualGenericTypes): Make
714 * class.cs (MethodCore.MayUnify): Use
715 TypeManager.MayBecomeEqualGenericTypes().
717 2004-12-08 Martin Baulig <martin@ximian.com>
719 * expression.cs (Is.DoResolve, As.DoResolve): If we're a type
720 parameter, box it. Fixes #69233.
722 2004-12-08 Martin Baulig <martin@ximian.com>
724 * generic.cs (ConstructedType.CheckConstraints): Valuetypes always
725 have the ctor constraint. Fixes #68326.
727 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
729 * cs-parser.jay : interface comment was not consumed because of
730 extra opt_semicolon before doc handling.
732 2004-12-03 Raja R Harinath <rharinath@novell.com>
734 Fix test-327.cs, test-328.cs, and put in early infrastructure
735 for eventually fixing #52697.
736 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
737 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
739 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
740 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
741 (VerifyUsing, error246): Update.
742 * rootcontext.cs (RootContext.NamespaceLookup): Just use
743 'NamespaceEntry.LookupNamespaceOrType'.
745 2004-12-07 Martin Baulig <martin@ximian.com>
747 * driver.cs: Call it "BETA SOFTWARE" :-)
749 2004-12-06 Raja R Harinath <rharinath@novell.com>
751 Fix crash on cs0657-17.cs.
752 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
753 Use RootContext.Tree.Types, not 'new RootTypes ()'.
754 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
755 the case where the NamespaceEntry gets overwritten.
757 2004-12-06 Marek Safar <marek.safar@seznam.cz>
760 * ecore.cs (ResolveBoolean): Tiny refactoring.
762 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
763 of right expression resolving when left is false constant and
764 operator is LogicalAnd OR true constant and operator is LogicalOr.
766 * statement.cs (ResolveUnreachable): Always reports warning.
768 2004-12-05 Miguel de Icaza <miguel@ximian.com>
770 * class.cs: Distinguish between 1721 and 1722 (just a little help
773 2004-12-03 Miguel de Icaza <miguel@ximian.com>
775 * delegate.cs: Only allow this on new versions of the language.
777 2004-12-02 Duncan Mak <duncan@ximian.com>
779 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
781 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
782 here as a static method. Take an additional bool out parameter
783 `must_do_cs1540_check' for signaling to InstanceResolve.
784 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
785 member field from PropertyExpr class and made it an argument of
787 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
788 check for MarshalByRefObject, and report CS0122 instead of CS1540.
789 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
790 and `remove_accessor' as well as InstanceResolve: report CS0122
795 2004-12-07 Martin Baulig <martin@ximian.com>
797 * decl.cs (DeclSpace.AddToContainer): Report correct errors CS0694
798 and CS0692 where appropriate.
800 2004-12-06 Martin Baulig <martin@ximian.com>
802 * class.cs (MethodCore.MayUnify): Moved the CS0408 check here from
803 IsDuplicateImplementation() and improved it.
805 * expression.cs (Invocation.InferTypeArguments): Added
806 `Type[] inferred_class_types' argument (for MethodCore.MayUnify)
807 and removed the "ref" modifier from `infered_types'.
809 * decl.cs (MemberName.ToString): Removed the exception.
811 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
813 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
814 comments are allowed.
816 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
818 * delegate.cs: Add checks for subtypes in paramaters and return values
819 in VerifyMethod () to add support for Covariance/Contravariance
822 2004-12-02 Miguel de Icaza <miguel@ximian.com>
824 * report.cs: Remove extra closing parenthesis.
826 * convert.cs (Error_CannotImplicitConversion): If the name of the
827 types are the same, provide some extra information.
829 2004-12-02 Marek Safar <marek.safar@seznam.cz>
832 * attribute.cs (Resolve): Improved implementation of params
835 * support.cs (ParameterData): Add HasParams to be faster.
837 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
839 all things are for /doc support:
841 * doc.cs: new file that supports XML documentation generation.
842 * mcs.exe.sources: added doc.cs.
844 Handle /doc command line option.
845 Report error 2006 instead of 5 for missing file name for /doc.
846 Generate XML documentation when required, after type resolution.
848 Added support for picking up documentation (/// and /** ... */),
849 including a new XmlCommentState enumeration.
851 Added lines to fill Documentation element for field, constant,
852 property, indexer, method, constructor, destructor, operator, event
853 and class, struct, interface, delegate, enum.
854 Added lines to warn incorrect comment.
856 Added Documentation field (passed only when /doc was specified).
858 Added DocComment, DocCommentHeader, GenerateDocComment() and
859 OnGenerateDocComment() and some supporting private members for
860 /doc feature to MemberCore.
862 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
864 Added overriden DocCommentHeader.
866 Added overriden DocCommentHeader and GenerateDocComment().
868 2004-12-01 Miguel de Icaza <miguel@ximian.com>
870 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
871 unwrapping the enumeration values, chain to
872 DoConstantNumericPromotions again, so we can promote things to the
873 fundamental types (takes care of enums that are bytes, sbytes).
877 2004-12-01 Raja R Harinath <rharinath@novell.com>
879 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
880 Fix long-standing bug in type-lookup. Use FindType instead of
881 LookupType when ec.ResolvingTypeTree.
882 (Attribute.ResolveType, Attribute.Resolve)
883 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
885 (Attributes.Search): Remove internal version. Update.
886 (Attributes.SearchMulti): Update.
887 (Attributes.GetClsCompliantAttribute): Remove.
888 (Attributes.GetIndexerNameAttribute): Remove.
889 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
890 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
891 * class.cs (Indexer.Define): Likewise.
893 2004-12-01 Marek Safar <marek.safar@seznam.cz>
896 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
897 MarshallByReference members access.
899 * expression.cs: Use CheckMarshallByRefAccess;
900 Better error CS0197 message.
902 * report.cs: Print whole related error message.
904 2004-11-29 Marek Safar <marek.safar@seznam.cz>
906 * class (GetClassBases): Better error 60 report.
907 (EventProperty): Disabled warning 67 detection.
909 2004-11-29 Marek Safar <marek.safar@seznam.cz>
912 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
914 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
917 2004-11-29 Marek Safar <marek.safar@seznam.cz>
920 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
922 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
924 2004-11-26 Miguel de Icaza <miguel@ximian.com>
926 * attribute.cs (Attribute.Resolve): Refine error reporting and
927 report a cs0117 if the identifier does not exist, to distinguish
928 from 0617 which is a miss-use of the actual identifier.
930 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
931 between cs0070 and cs0079.
933 * class.cs (MemberBase.DoDefine): When reporting a wrong
934 accessibility level, we use MethodCore to compare instead of
935 Method (this was a regression in some refactoring effort).
937 So now we correctly report cs0056 again.
939 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
940 testing the target_type (which was known to be object_type) and
941 not the source type (which is anonymous_method).
943 Fixed reporting of error cs1660.
945 * expression.cs (UserCast.Source): Expose the underlying cast.
947 * statement.cs (Switch.SwitchGoverningType): Sort the list of
948 allowed types to find a match to int32 first (most common).
950 In addition, it ignores any ImplicitUserConversions that did an
951 internal implicit conversion (as the switch statement allows only
952 one integral conversion to exist).
954 * class.cs (PartialContainer.Create): rename `name' to
955 `member_name' for clarity. Then replace the string calls with a
956 call to MemberName.GetPartialName, as now using
957 MemberName.ToString is an error (this is due to the side effects
958 it had, that were fixed in the past).
960 This will restore the error reporting on a number of partial class
961 errors that were missusing this (and getting an exception as a
962 results, which is now just a plain textual warning, because
963 yyparse debug output would crash otherwise).
965 2004-11-26 Raja R Harinath <rharinath@novell.com>
967 * Makefile (PROGRAM_INSTALL_DIR): Remove.
969 2004-11-25 Ben Maurer <bmaurer@ximian.com>
971 * rootcontext.cs (LookupType): Make sure to cache lookups that
972 don't give us a negative result. This saves about 5% of corlib
975 2004-11-25 Miguel de Icaza <miguel@ximian.com>
977 * report.cs (AbstractMessage.Print): messages are sent to stderr
979 * class.cs (TypeContainer.GetClassBases): It is an error to have a
980 non-interface in the list of interfaces (at this point, either
981 parent was properly set, or a base class is being listed in the
984 This flags error 1722, and resolves the crash from bug 69259.
986 2004-11-25 Ben Maurer <bmaurer@ximian.com>
988 * statement.cs (Using.EmitExpressionFinally): make this work right
989 for valuetypes. Fixes 69926.
991 2004-11-25 Miguel de Icaza <miguel@ximian.com>
993 * const.cs (Const.ChangeType): Cope with the "0 literal can be
994 converted to an enum" here, before we try to change the underlying
995 type. This code exists, but it is a different code path than the
996 one used while encoding constants.
998 (ImplicitReferenceConversionExists): In addition, resynchronized
999 the code here, so it matches the same code in
1000 ImplicitReferenceConversionExists for the `from any class-type S
1001 to any interface-type T'.
1003 2004-11-25 Marek Safar <marek.safar@seznam.cz>
1005 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
1007 2004-11-24 Miguel de Icaza <miguel@ximian.com>
1009 * cs-parser.jay: Use verbosity accordingly.
1011 2004-11-24 Marek Safar <marek.safar@seznam.cz>
1013 * expression.cs (Unary.ResolveOperator): Do not report warning;
1014 AddressOf reads from variable.
1016 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
1018 2004-11-24 Marek Safar <marek.safar@seznam.cz>
1022 * attribute.cs (Attributable): Removed CheckTargets.
1023 (Attributes.Emit): Explicit attribute targets are tested here.
1025 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
1026 not enabled for interfaces.
1028 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
1029 (GetAssemblyName): Ouch next bug there.
1031 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
1033 * expression.cs: Error 275 added.
1035 2004-11-23 Marek Safar <marek.safar@seznam.cz>
1037 Fix bug #69177 (Implemented decimal constant support)
1039 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
1040 (BinaryFold): Add DecimalConstant.
1042 * const.cs (Define): Decimal constant
1044 (ChangeType): Add decimal type handling.
1045 (LookupConstantValue): Don't set value for decimal type but
1046 emit DecimalConstantAttribute. Needed for constant optimization.
1048 * constant.cs (ToDecimal): New method.
1049 (ConvertToDecimal): New method.
1050 (IntConstant): Implemented ConvertToDecimal.
1051 (DecimalConstant.Emit): Emit optimized version for decimals in
1054 * expression.cs (ResolveOperator): Changed order of constant
1055 reduction to work correctly with native types which have
1056 overloaded operators.
1057 (ResolveMemberAccess): Extract constant value from attribute
1060 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
1062 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
1063 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
1064 (ChangeType): Decimal is special.
1065 (TypeToCoreType): Add decimal type.
1067 2004-11-22 Marek Safar <marek.safar@seznam.cz>
1069 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
1072 2004-11-22 Marek Safar <marek.safar@seznam.cz>
1074 * class.cs (EventField.ApplyAttributeBuilder): Fix error
1077 2004-11-19 Marek Safar <marek.safar@seznam.cz>
1079 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
1081 * pending.cs (PendingImplementation): Grab only interfaces.
1083 2004-11-19 Marek Safar <marek.safar@seznam.cz>
1085 * statement.cs (ForeachHelperMethods): Add location member and
1086 error 202 detection.
1088 2004-11-18 Marek Safar <marek.safar@seznam.cz>
1090 * expression.cs (DoResolveBase): Fixed wrong warning for out
1093 2004-12-04 Martin Baulig <martin@ximian.com>
1095 * convert.cs (Convert.TypeParameter_to_Null): Use the constraints
1096 to check whether the conversion is ok.
1098 * typemanager.cs (TypeManager.GetTypeArguments): Just return
1099 `Type.EmptyTypes' if we're not a generic TypeContainer.
1101 2004-11-25 Miguel de Icaza <miguel@ximian.com>
1103 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
1104 old bug: when converting from the null literal to a pointer,
1105 return an EmptyCast, not the NullLiteral.
1107 This fixes #69921, the recent null_type changes probably made this
1110 2004-12-03 Martin Baulig <martin@ximian.com>
1112 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
1113 method as our child, call AnonymousMethod.Compatible() on it.
1115 2004-12-02 Miguel de Icaza <miguel@ximian.com>
1117 * class.cs (FieldBase): Use an unused bit field from the field to
1118 encode the `has_offset' property from the FieldMember. This saves
1119 a couple of Ks on bootstrap compilation.
1121 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
1122 method as our child, return the AnonymousMethod resolved
1125 * expression.cs (New.DoResolve): Allow return values from
1126 NewDelegate to also include AnonymousMethods.
1130 2004-11-29 Raja R Harinath <rharinath@novell.com>
1132 * decl.cs (MemberCore.MemberName): Remove readonly to fix an error
1134 * rootcontext.cs (ResolveCore::interfaces_first_stage): Add
1135 System.Runtime.InteropServices._Exception, since it's a base
1136 interface of the core type System.Exception in the net_2_0 profile.
1138 2004-11-27 Martin Baulig <martin@ximian.com>
1140 * ecore.cs (Expression.StoreFromPtr): Use `stobj' for generic parameters.
1142 2004-11-26 Raja R Harinath <rharinath@novell.com>
1144 * Makefile: Convert to use executable.make.
1145 * gmcs.exe.sources: New.
1147 2004-11-25 Martin Baulig <martin@ximian.com>
1149 * expression.cs (Invocation.InferType): Added support for byref types.
1151 2004-11-25 Martin Baulig <martin@ximian.com>
1153 * statement.cs (Foreach.FetchMethodMoveNext): Wrap `mi.ReturnType'
1154 in TypeManager.TypeToCoreType().
1156 2004-11-25 Martin Baulig <martin@ximian.com>
1158 * iterators.cs (Iterator.DoDefineMembers): Override and lookup the
1159 "Dispose" method from the `current_type'.
1160 (Iterator.EmitMoveNext): Use the `dispose_method' we looked up in
1161 DoDefineMembers() instead of using the MethodBuilder; this is
1162 required for generic iterators.
1164 * class.cs (TypeContainer.DoDefineMembers): Make this virtual.
1166 2004-11-24 Martin Baulig <martin@ximian.com>
1168 * ecore.cs (Expression.LoadFromPtr): Use `ldobj' for generic parameters.
1170 2004-11-20 Martin Baulig <martin@ximian.com>
1172 * expression.cs (Invocation.InferType): Correctly infer generic
1173 instances; see gen-103.cs.
1174 (Invocation.InferTypeArguments): If a generic method doesn't have
1175 any unbound type parameters, we don't need to infer anything.
1177 2004-11-19 Raja R Harinath <rharinath@novell.com>
1179 * Makefile (gmcs.exe): Update to new location of bootstrap mcs.exe.
1181 2004-11-17 Raja R Harinath <rharinath@novell.com>
1183 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
1184 (TypeHandle.GetMemberCache): New.
1185 (TypeHandle.TypeHandle): Update.
1186 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
1187 (TypeManager.LookupParentInterfacesCache):
1188 Rename from LookupInterfaceCache. Optimize slightly.
1189 (TypeManager.MemberLookup_FindMembers): Update.
1190 * decl.cs (MemberCache.MemberCache): Set Container to null in the
1192 (AddCacheContents): Rename from AddHashtable.
1193 * class.cs (TypeContainer.parent_container): Remove.
1194 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
1195 (TypeContainer.DoDefineMembers): Don't initialize it.
1196 Update to name changes.
1198 2004-11-17 Miguel de Icaza <miguel@ximian.com>
1200 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
1201 that factors the code to check access modifiers on override.
1203 (PropertyBase): Use the code here.
1205 Patch from Lluis S'anchez, fixes bug #69361.
1207 2004-11-15 Miguel de Icaza <miguel@ximian.com>
1209 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
1210 routine that is used to report the use of a captured variable
1211 whose address has been taken.
1213 There are two checks: one when variables are being captured and
1214 the other check is when the address of a variable is taken.
1216 (because an anonymous methods might be resolved before *or* after
1217 the address has been taken) and
1219 * expression.cs (Conditional.DoResolve): Remove the special
1220 casing that Martin added to trueExpr and falseExpr being both
1221 NullLiteral. We get the right behavior now just by introducing
1222 the null_type into the compiler.
1224 * convert.cs (ExplicitConversion): Change the code to use
1225 null_type instead of testing `expr is NullLiteral'.
1226 (ImplicitConversionStandard): use null_type too.
1227 (ImplicitReferenceConversionExists): use null_type too.
1228 (ImplicitReferenceConversion): use null_type too.
1230 * literal.cs: The type of `NullLiteral' is now null_type instead
1232 (Resolve): Set the type here.
1234 * typemanager.cs: Introduce null_type.
1236 2004-11-18 Martin Baulig <martin@ximian.com>
1239 (RootContext.LookupType): Return a `Type', not a `TypeExpr'.
1241 2004-11-18 Martin Baulig <martin@ximian.com>
1243 * ecore.cs (TypeExpr.DoResolveAsTypeStep): Make this protected.
1245 2004-11-18 Martin Baulig <martin@ximian.com>
1247 * generic.cs (Constraints.Resolve): Take an `EmitContext' instead
1248 of a `DeclSpace'. If one of our constraints is a `ConstructedType',
1249 call ResolveConstructedType() on it to resolve it without checking
1251 (Constraints.ResolveTypes): Check them here.
1252 (ConstructedType.DoResolveAsTypeStep): Fully resolve ourselves,
1253 but don't check constraints.
1254 (ConstructedType.ResolveAsTypeTerminal): Override this and also
1255 check constraints here.
1256 (ConstructedType.ResolveConstructedType): New public method. This
1257 is called from DoResolveAsTypeStep() and Constraints.Resolve() to
1258 resolve ourselves without checking constraints.
1260 * ecore.cs (Expression.ResolveAsTypeTerminal): Make this virtual.
1262 2004-11-18 Martin Baulig <martin@ximian.com>
1265 (DeclSpace.CurrentType): Changed type from `TypeExpr' to `Type'.
1267 * delegate.cs (Delegate.DefineType): Always create the EmitContext.
1269 2004-11-18 Martin Baulig <martin@ximian.com>
1271 * ecore.cs (TypeExpr.ResolveType): Removed.
1272 (Expression.ResolveAsTypeTerminal): We always return a fully
1273 resolved `TypeExpr', so we can just access its `Type'.
1275 * class.cs (TypeContainer.DefineType): Resolve `CurrentType' here.
1277 2004-11-17 Martin Baulig <martin@ximian.com>
1279 * ecore.cs (IAlias.Type): Replaced with ResolveAsType() to make
1280 sure we don't return any unresolved TypeExpr's.
1281 (TypeAliasExpression): The .ctor now takes an `IAlias' instead of
1283 (Expression.ResolveAsTypeTerminal): Make sure `te.Type != null'.
1285 * expression.cs (MemberAccess.ResolveAsTypeStep): Don't return any
1286 unresolved `ConstructedType's.
1288 2004-11-17 Martin Baulig <martin@ximian.com>
1290 * ecore.cs (TypeExpr.ResolveType): Don't make this virtual.
1292 2004-11-17 Martin Baulig <martin@ximian.com>
1295 (Expression.ResolveAsTypeTerminal): Removed the `bool silent' argument.
1297 * decl.cs (DeclSpace.ResolveType): Removed.
1298 (DeclSpace.ResolveTypeExpr): Removed the `bool silent' argument.
1300 2004-11-17 Martin Baulig <martin@ximian.com>
1302 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
1303 direction, like FindMembers() does. Fixes #69546, testcase is in
1306 2004-11-16 Martin Baulig <martin@ximian.com>
1308 This is based on a patch from Marek Safar, see bug #69082.
1309 Fixes bugs #63705 and #67130.
1311 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
1312 method; create a MemberCache for an interface type and cache the
1315 * decl.cs (IMemberContainer.ParentContainer): Removed.
1316 (IMemberContainer.ParentCache): New property.
1317 (MemberCache.SetupCacheForInterface): Removed.
1318 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
1319 to create a cache for an interface's "parent".
1321 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
1324 2004-11-14 Ben Maurer <bmaurer@ximian.com>
1326 * statement.cs: Avoid adding bools to a hashtable.
1328 2004-11-15 Martin Baulig <martin@ximian.com>
1330 * decl.cs (MemberName.GetPartialName): Removed, use GetTypeName() instead.
1332 2004-11-11 Martin Baulig <martin@ximian.com>
1334 * typemanager.cs (TypeManager.GetMethodName): New method.
1336 * class.cs (MethodData.Define): Include the generic arity in the
1337 name of an explicit interface; also add it to the method name.
1339 * pending.cs (PendingImplementation.InterfaceMethod): The method
1340 name now includes the generic arity.
1342 2004-11-07 Miguel de Icaza <miguel@ximian.com>
1344 * expression.cs (Invocation.OverloadResolve): Flag error if we are
1345 calling an unsafe method from a safe location.
1347 2004-11-06 Marek Safar <marek.safar@seznam.cz>
1350 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
1352 2004-11-06 Miguel de Icaza <miguel@ximian.com>
1354 * namespace.cs (VerifyUsing): use GetPartialName instead of
1357 2004-11-05 Miguel de Icaza <miguel@ximian.com>
1359 * statement.cs (Return.Resolve): Fix regression in typo: if
1360 `in_exc', we have to request a NeedReturnLabel, this was a typo
1361 introduced in the anonymous method check-in. Fixes #69131.
1363 * Indexers were using the ShortName when defining themselves,
1364 causing a regression in the compiler bootstrap when applying the
1365 patch from 2004-11-02 (first part), now they use their full name
1366 and the bug is gone.
1368 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
1370 * driver.cs: Strip the path from the names of embedded resources. Fixes
1373 2004-11-04 Raja R Harinath <rharinath@novell.com>
1375 Fix error message regression: cs0104-2.cs.
1376 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
1377 (AliasEntry.Resolve): Update.
1378 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
1380 (RootContext.LookupType): Update.
1382 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
1384 * cs-parser.jay: Add support for handling accessor modifiers
1385 * class: Add support port accessor modifiers and error checking,
1386 define PropertyMethod.Define as virtual (not abstract anymore)
1387 * ecore.cs: Add checking for proeprties access with access modifiers
1388 * iterators.cs: Modify Accessor constructor call based in the modified
1390 2004-11-02 Ben Maurer <bmaurer@ximian.com>
1392 * expression.cs (StringConcat): Handle being called twice,
1393 as when we have a concat in a field init with more than two
1396 2004-11-02 Miguel de Icaza <miguel@ximian.com>
1398 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
1399 special case explicit implementations, we should always produce
1400 the .property or .event declaration.
1402 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
1403 since it will not return correct data if people use this
1404 unresolved in the presence of using statements (see test-313).
1406 * class.cs (MethodData.Define): If we are an explicit interface
1407 implementation, set the method name to the full name of the
1408 interface plus the name of the method.
1410 Notice that using the method.MethodName.GetFullName() does not
1411 work, as it will only contain the name as declared on the source
1412 file (it can be a shorthand in the presence of using statements)
1413 and not the fully qualifed type name, for example:
1417 class D : ICloneable {
1418 object ICloneable.Clone () {
1422 Would produce a method called `ICloneable.Clone' instead of
1423 `System.ICloneable.Clone'.
1425 * namespace.cs (Alias.Resolve): Use GetPartialName.
1427 2004-11-01 Marek Safar <marek.safar@seznam.cz>
1429 * cs-parser.jay: Add error 1055 report.
1431 2004-11-01 Miguel de Icaza <miguel@ximian.com>
1433 * assign.cs (Assign.DoResolve): Only do the transform of
1434 assignment into a New if the types are compatible, if not, fall
1435 through and let the implicit code deal with the errors and with
1436 the necessary conversions.
1438 2004-11-01 Marek Safar <marek.safar@seznam.cz>
1440 * cs-parser.jay: Add error 1031 report.
1442 * cs-tokenizer.cs: Add location for error 1038.
1444 2004-10-31 Marek Safar <marek.safar@seznam.cz>
1446 * cs-parser.jay: Add error 1016 report.
1448 2004-10-31 Marek Safar <marek.safar@seznam.cz>
1450 * cs-parser.jay: Add errors 1575,1611 report.
1452 2004-10-31 Marek Safar <marek.safar@seznam.cz>
1454 * cs-parser.jay: Add error 1001 report.
1456 2004-10-31 Marek Safar <marek.safar@seznam.cz>
1459 * attribute.cs (GetMarshal): Add method argument for
1460 caller identification.
1462 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
1463 agument for GetMarshal and RuntimeMissingSupport.
1465 2004-10-31 Marek Safar <marek.safar@seznam.cz>
1467 * attribute.cs (ExtractSecurityPermissionSet): Removed
1468 TypeManager.code_access_permission_type.
1470 * typemanager.cs: Removed TypeManager.code_access_permission_type.
1472 2004-10-27 Miguel de Icaza <miguel@ximian.com>
1474 * expression.cs (LocalVariableReference.DoResolveLValue): Check
1475 for obsolete use of a variable here. Fixes regression on errors
1476 cs0619-25 and cs0619-26.
1478 2004-10-27 Marek Safar <marek.safar@seznam.cz>
1480 Fix #62358, implemented security attribute encoding.
1482 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
1483 Tests permitted SecurityAction for assembly or other types.
1484 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
1485 data from SecurityPermissionAttribute to PermisionSet class.
1487 * class.cs (ApplyAttributeBuilder): Added special handling
1488 for System.Security.Permissions.SecurityAttribute based types.
1490 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
1491 special handling for System.Security.Permissions.SecurityAttribute
1494 * enum.cs (ApplyAttributeBuilder): Added special handling
1495 for System.Security.Permissions.SecurityAttribute based types.
1497 * parameter.cs (ApplyAttributeBuilder): Added special handling
1498 for System.Security.Permissions.SecurityAttribute based types.
1500 * rootcontext.cs: Next 2 core types.
1502 * typemanager.cs (TypeManager.security_permission_attr_type):
1503 Built in type for the SecurityPermission Attribute.
1504 (code_access_permission_type): Build in type.
1506 2004-10-17 Miguel de Icaza <miguel@ximian.com>
1508 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
1509 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
1510 all of this information into
1511 EmitContext.EmitCapturedVariableInstance.
1513 * codegen.cs (EmitCapturedVariableInstance): move here the
1514 funcionality of emitting an ldarg.0 in the presence of a
1515 remapping. This centralizes the instance emit code.
1517 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
1518 then emit a load of this: it means that we have reached the
1519 topmost ScopeInfo: the one that contains the pointer to the
1520 instance of the class hosting the anonymous method.
1522 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
1523 captures to the topmost CaptureContext.
1525 2004-10-12 Miguel de Icaza <miguel@ximian.com>
1527 * expression.cs (LocalVariableReference): Move the knowledge about
1528 the iterators into codegen's EmitCapturedVariableInstance.
1530 2004-10-11 Miguel de Icaza <miguel@ximian.com>
1532 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
1533 all code paths return a value from an anonymous method (it is the
1534 same as the 161 error, but for anonymous methods).
1536 2004-10-08 Miguel de Icaza <miguel@ximian.com>
1538 The introduction of anonymous methods in the compiler changed
1539 various ways of doing things in the compiler. The most
1540 significant one is the hard split between the resolution phase
1541 and the emission phases of the compiler.
1543 For instance, routines that referenced local variables no
1544 longer can safely create temporary variables during the
1545 resolution phase: they must do so from the emission phase,
1546 since the variable might have been "captured", hence access to
1547 it can not be done with the local-variable operations from the runtime.
1551 (Block.Flags): New flag `IsTopLevel' to indicate that this block
1552 is a toplevel block.
1554 (ToplevelBlock): A new kind of Block, these are the blocks that
1555 are created by the parser for all toplevel method bodies. These
1556 include methods, accessors and anonymous methods.
1558 These contain some extra information not found in regular blocks:
1559 A pointer to an optional CaptureContext (for tracking captured
1560 local variables and parameters). A pointer to the parent
1563 (Return.Resolve): Catch missmatches when returning a value from an
1564 anonymous method (error 1662).
1565 Invoke NeedReturnLabel from the Resolve phase instead of the emit
1568 (Break.Resolve): ditto.
1570 (SwitchLabel): instead of defining the labels during the
1571 resolution phase, we now turned the public ILLabel and ILLabelCode
1572 labels into methods called GetILLabelCode() and GetILLabel() that
1573 only define the label during the Emit phase.
1575 (GotoCase): Track the SwitchLabel instead of the computed label
1576 (its contained therein). Emit the code by using
1577 SwitchLabel.GetILLabelCode ().
1579 (LocalInfo.Flags.Captured): A new flag has been introduce to track
1580 whether the Local has been captured or not.
1582 (LocalInfo.IsCaptured): New property, used to tell whether the
1583 local has been captured.
1585 * anonymous.cs: Vastly updated to contain the anonymous method
1588 The main classes here are: CaptureContext which tracks any
1589 captured information for a toplevel block and ScopeInfo used to
1590 track the activation frames for various local variables.
1592 Each toplevel block has an optional capture context associated
1593 with it. When a method contains an anonymous method both the
1594 toplevel method and the anonymous method will create a capture
1595 context. When variables or parameters are captured, they are
1596 recorded on the CaptureContext that owns them, for example:
1600 MyDelegate d = delegate {
1605 Here `a' will be recorded as captured on the toplevel
1606 CapturedContext, the inner captured context will not have anything
1607 (it will only have data if local variables or parameters from it
1608 are captured in a nested anonymous method.
1610 The ScopeInfo is used to track the activation frames for local
1611 variables, for example:
1613 for (int i = 0; i < 10; i++)
1614 for (int j = 0; j < 10; j++){
1615 MyDelegate d = delegate {
1620 At runtime this captures a single captured variable `i', but it
1621 captures 10 different versions of the variable `j'. The variable
1622 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
1623 recorded on a child.
1625 The toplevel ScopeInfo will also track information like the `this'
1626 pointer if instance variables were referenced (this is necessary
1627 as the anonymous method lives inside a nested class in the host
1628 type of the method).
1630 (AnonymousMethod): Expanded to track the Toplevel, implement
1631 `AnonymousMethod.Compatible' to tell whether an anonymous method
1632 can be converted to a target delegate type.
1634 The routine now also produces the anonymous method content
1636 (AnonymousDelegate): A helper class that derives from
1637 DelegateCreation, this is used to generate the code necessary to
1638 produce the delegate for the anonymous method that was created.
1640 * assign.cs: API adjustments for new changes in
1641 Convert.ImplicitStandardConversionExists.
1643 * class.cs: Adjustments to cope with the fact that now toplevel
1644 blocks are of type `ToplevelBlock'.
1646 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
1647 insteda of standard blocks.
1649 Flag errors if params arguments are passed to anonymous methods.
1651 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
1652 `CurrentAnonymousMethod' which points to the current Anonymous
1653 Method. The variable points to the AnonymousMethod class that
1654 holds the code being compiled. It is set in the new EmitContext
1655 created for the anonymous method.
1657 (EmitContext.Phase): Introduce a variable and an enumeration to
1658 assist in enforcing some rules about when and where we are allowed
1659 to invoke certain methods (EmitContext.NeedsReturnLabel is the
1660 only one that enfonces this right now).
1662 (EmitContext.HaveCaptureInfo): new helper method that returns
1663 whether we have a CapturedContext initialized.
1665 (EmitContext.CaptureVariable): New method used to register that a
1666 LocalInfo must be flagged for capturing.
1668 (EmitContext.CapturedParameter): New method used to register that a
1669 parameters must be flagged for capturing.
1671 (EmitContext.CapturedField): New method used to register that a
1672 field must be flagged for capturing.
1674 (EmitContext.HaveCapturedVariables,
1675 EmitContext.HaveCapturedFields): Return whether there are captured
1676 variables or fields.
1678 (EmitContext.EmitMethodHostInstance): This is used to emit the
1679 instance for the anonymous method. The instance might be null
1680 (static methods), this (for anonymous methods that capture nothing
1681 and happen to live side-by-side with the current method body) or a
1682 more complicated expression if the method has a CaptureContext.
1684 (EmitContext.EmitTopBlock): Routine that drives the emission of
1685 code: it will first resolve the top block, then emit any metadata
1686 and then emit the code. The split is done so that we can extract
1687 any anonymous methods and flag any captured variables/parameters.
1689 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
1690 during this phase, the ILGenerator should not be used as labels
1691 and local variables declared here might not be accessible to any
1692 code that is part of an anonymous method.
1694 Exceptions to this include the temporary variables that are
1695 created by some statements internally for holding temporary
1698 (EmitContext.EmitMeta): New routine, in charge of emitting all the
1701 (EmitContext.TemporaryReturn): This method is typically called
1702 from the Emit phase, and its the only place where we allow the
1703 ReturnLabel to be defined other than the EmitMeta. The reason is
1704 that otherwise we would have to duplicate a lot of logic in the
1705 Resolve phases of various methods that today is on the Emit
1708 (EmitContext.NeedReturnLabel): This no longer creates the label,
1709 as the ILGenerator is not valid during the resolve phase.
1711 (EmitContext.EmitThis): Extended the knowledge in this class to
1712 work in anonymous methods in addition to iterators.
1714 (EmitContext.EmitCapturedVariableInstance): This emits whatever
1715 code is necessary on the stack to access the instance to a local
1716 variable (the variable will be accessed as a field).
1718 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
1719 EmitContext.EmitAddressOfParameter): Routines to support
1720 parameters (not completed at this point).
1722 Removals: Removed RemapLocal and RemapLocalLValue. We probably
1723 will also remove the parameters.
1725 * convert.cs (Convert): Define a `ConstantEC' which points to a
1726 null. This is just to prefity some code that uses
1727 ImplicitStandardConversion code and do not have an EmitContext
1730 The idea is to flag explicitly that at that point in time, it is
1731 known that the conversion will not trigger the delegate checking
1732 code in implicit conversions (which requires a valid
1735 Everywhere: pass new EmitContext parameter since
1736 ImplicitStandardConversionExists now requires it to check for
1737 anonymous method conversions.
1739 (Convert.ImplicitStandardConversionExists): If the type of an
1740 expression is the anonymous_method_type, and the type is a
1741 delegate, we invoke the AnonymousMethod.Compatible method to check
1742 whether an implicit conversion is possible.
1744 (Convert.ImplicitConversionStandard): Only do implicit method
1745 group conversions if the language level is not ISO_1.
1747 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
1748 MethodInfo for the Invoke method. used by Delegate and
1751 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
1752 method conversions if the target type is a delegate.
1754 Removed extra debugging nops.
1756 (LocalVariableReference): Turn the `local_info' into a public
1759 Add `prepared' field, the same hack used for FieldExprs to cope
1760 with composed assignments, as Local variables do not necessarily
1761 operate purely on the stack as they used to: they can be captured
1764 Add `temp' for a temporary result, like fields.
1766 Refactor DoResolve and DoResolveLValue into DoResolveBase.
1768 It now copes with Local variables that are captured and emits the
1769 proper instance variable to load it from a field in the captured
1772 (ParameterReference.DoResolveBase): During the resolve phase,
1773 capture parameters if we are in an anonymous method.
1775 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
1776 anonymous method, use the EmitContext helper routines to emit the
1777 parameter reference.
1779 * iterators.cs: Set RemapToProxy to true/false during the
1782 * parameters.cs (GetParameterByName): New helper method.
1784 * typemanager.cs (anonymous_method_type) a new type that
1785 represents an anonyous method. This is always an internal type,
1786 used as a fencepost to test against the anonymous-methodness of an
1789 2004-10-20 Marek Safar <marek.safar@seznam.cz>
1791 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
1793 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
1795 2004-11-10 Martin Baulig <martin@ximian.com>
1797 * expression.cs (Invocation.BetterFunction): If two methods have
1798 equal parameter types, but only one of them is generic, the
1799 non-generic one wins.
1800 (New.DoResolve): Don't set `is_struct' to false if we're a generic
1801 instance; just use `Type.IsValueType' to determine whether
1802 something is a struct or not.
1803 (MemberAccess.DoResolveAsTypeStep): Don't modify the `args' field,
1804 so we can be called multiple times.
1806 2004-11-10 Martin Baulig <martin@ximian.com>
1808 * generic.cs (TypeParameter.DefineConstraints): New public method.
1809 (TypeParameter.CheckAccessLevel): Override this and return true.
1810 (ConstructedType.ResolveType): Renamed to DoResolveType(), don't
1811 override ResolveType() anymore.
1812 (ConstructedType.DoResolveAsTypeStep): Call DoResolveType() here.
1814 2004-11-10 Martin Baulig <martin@ximian.com>
1816 * rootcontext.cs (RootContext.LookupType): If we're a nested type,
1817 call DeclSpace.ResolveNestedType() on it.
1819 2004-11-10 Martin Baulig <martin@ximian.com>
1821 * support.cs (ReflectionParameters.ParameterModifier): If `gpd' is
1822 non-null, call ParameterModifier() on it.
1824 2004-11-10 Martin Baulig <martin@ximian.com>
1827 (Iterators): Added `current_type' and `this_type' fields.
1828 (Iterators.DefineIterator): Create a new EmitContext and store it
1829 in `ec'; compute `this_type'.
1831 2004-11-10 Martin Baulig <martin@ximian.com>
1834 (TypeManager.IsPrivateAccessible): New public method.
1835 (Closure.Filter): Use IsPrivateAccessible() instead of IsEqual().
1837 2004-11-10 Martin Baulig <martin@ximian.com>
1839 * class.cs (TypeContainer.DefineType): Call
1840 TypeBuilder.DefineGenericParameters() before resolving the type
1842 (MethodData.parent_method): New protected field.
1843 (MethodData..ctor): Added `MethodInfo parent_method' argument.
1844 (MethodData.Define): Compute `parent_method'.
1847 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
1848 (MemberCore.GetClsCompliantAttributeValue): Likewise.
1849 (DeclSpace.ec): New protected field; store the EmitContext here.
1850 (DeclSpace.EmitContext): New public property.
1851 (DeclSpace.ResolveType): Un-comment from the [Obsolte] attribute.
1852 (DeclSpace.ResolveNestedType): New public method.
1853 (DeclSpace.ResolveTypeExpr): Just call ResolveAsTypeTerminal() here.
1854 (DeclSpace.NestedAccessible): Added `Type tb' argument.
1855 (DeclSpace.FamilyAccessible): Likewise.
1856 (DeclSpace.FindType): Call ResolveNestedType() for nested types.
1857 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
1860 * delegate.cs (Delegate.Define): Store the EmitContext in the `ec'
1863 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
1864 (Enum.Emit): Don't create a new EmitContext.
1866 2004-10-18 Martin Baulig <martin@ximian.com>
1868 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
1869 `Type' directly, but call ResolveType() on it.
1870 (Catch.Resolve): Likewise.
1871 (Foreach.Resolve): Likewise.
1873 2004-10-18 Martin Baulig <martin@ximian.com>
1875 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
1876 `Type' directly, but call ResolveType() on it.
1877 (Probe.DoResolve): Likewise.
1878 (ArrayCreation.LookupType): Likewise.
1879 (TypeOf.DoResolve): Likewise.
1880 (SizeOf.DoResolve): Likewise.
1882 2004-10-18 Raja R Harinath <rharinath@novell.com>
1884 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
1887 2004-10-17 John Luke <john.luke@gmail.com>
1889 * class.cs (Operator.GetSignatureForError): use CSharpName
1891 * parameter.cs (Parameter.GetSignatureForError): Returns
1892 correct name even if was not defined.
1894 2004-10-13 Raja R Harinath <rharinath@novell.com>
1897 * class.cs (TypeContainer.EmitContext): New property.
1898 (DefineNestedTypes): Create an emitcontext for each part.
1899 (MethodCore.DoDefineParameters): Use container's emitcontext.
1900 Pass type array to InternalParameters.
1901 (MemberBase.DoDefine): Use container's emitcontext.
1902 (FieldMember.Define): Likewise.
1903 (Event.Define): Likewise.
1904 (SetMethod.GetParameterInfo): Change argument to EmitContext.
1905 Pass type array to InternalParameters.
1906 (SetIndexerMethod.GetParameterInfo): Likewise.
1907 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
1908 * delegate.cs (Define): Pass emitcontext to
1909 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
1910 array to InternalParameters.
1911 * expression.cs (ParameterReference.DoResolveBase): Pass
1912 emitcontext to GetParameterInfo.
1913 (ComposedCast.DoResolveAsTypeStep): Remove check on
1914 ec.ResolvingTypeTree.
1915 * parameter.cs (Parameter.Resolve): Change argument to
1916 EmitContext. Use ResolveAsTypeTerminal.
1917 (Parameter.GetSignature): Change argument to EmitContext.
1918 (Parameters.ComputeSignature): Likewise.
1919 (Parameters.ComputeParameterTypes): Likewise.
1920 (Parameters.GetParameterInfo): Likewise.
1921 (Parameters.ComputeAndDefineParameterTypes): Likewise.
1922 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
1923 * support.cs (InternalParameters..ctor): Remove variant that takes
1925 * typemanager.cs (system_intptr_expr): New.
1926 (InitExpressionTypes): Initialize it.
1928 2004-10-12 Chris Toshok <toshok@ximian.com>
1930 * cs-parser.jay: fix location for try_statement and catch_clause.
1932 2004-10-18 Martin Baulig <martin@ximian.com>
1934 * class.cs (FieldMember.Define): Don't access the TypeExpr's
1935 `Type' directly, but call ResolveType() on it.
1936 (MemberBase.DoDefine): Likewise.
1938 * expression.cs (New.DoResolve): Don't access the TypeExpr's
1939 `Type' directly, but call ResolveType() on it.
1940 (ComposedCast.DoResolveAsTypeStep): Likewise.
1942 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
1943 `Type' directly, but call ResolveType() on it.
1945 2004-10-17 John Luke <john.luke@gmail.com>
1947 * class.cs (Operator.GetSignatureForError): use CSharpName
1949 * parameter.cs (Parameter.GetSignatureForError): Returns
1950 correct name even if was not defined.
1952 2004-10-13 Raja R Harinath <rharinath@novell.com>
1955 * class.cs (TypeContainer.EmitContext): New property.
1956 (DefineNestedTypes): Create an emitcontext for each part.
1957 (MethodCore.DoDefineParameters): Use container's emitcontext.
1958 Pass type array to InternalParameters.
1959 (MemberBase.DoDefine): Use container's emitcontext.
1960 (FieldMember.Define): Likewise.
1961 (Event.Define): Likewise.
1962 (SetMethod.GetParameterInfo): Change argument to EmitContext.
1963 Pass type array to InternalParameters.
1964 (SetIndexerMethod.GetParameterInfo): Likewise.
1965 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
1966 * delegate.cs (Define): Pass emitcontext to
1967 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
1968 array to InternalParameters.
1969 * expression.cs (ParameterReference.DoResolveBase): Pass
1970 emitcontext to GetParameterInfo.
1971 (ComposedCast.DoResolveAsTypeStep): Remove check on
1972 ec.ResolvingTypeTree.
1973 * parameter.cs (Parameter.Resolve): Change argument to
1974 EmitContext. Use ResolveAsTypeTerminal.
1975 (Parameter.GetSignature): Change argument to EmitContext.
1976 (Parameters.ComputeSignature): Likewise.
1977 (Parameters.ComputeParameterTypes): Likewise.
1978 (Parameters.GetParameterInfo): Likewise.
1979 (Parameters.ComputeAndDefineParameterTypes): Likewise.
1980 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
1981 * support.cs (InternalParameters..ctor): Remove variant that takes
1983 * typemanager.cs (system_intptr_expr): New.
1984 (InitExpressionTypes): Initialize it.
1986 2004-10-12 Chris Toshok <toshok@ximian.com>
1988 * cs-parser.jay: fix location for try_statement and catch_clause.
1990 2004-10-07 Raja R Harinath <rharinath@novell.com>
1992 More DeclSpace.ResolveType avoidance.
1993 * decl.cs (MemberCore.InUnsafe): New property.
1994 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
1995 with newly created EmitContext.
1996 (FieldMember.Define): Likewise.
1997 * delegate.cs (Delegate.Define): Likewise.
1998 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
1999 only if normal name-lookup fails.
2000 (TypeExpr.DoResolve): Enable error-checking.
2001 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
2002 (SizeOf.DoResolve): Likewise.
2003 (ComposedCast.DoResolveAsTypeStep): Likewise.
2004 (StackAlloc.DoResolve): Likewise.
2005 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
2006 (Block.Unsafe): New property.
2007 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
2008 (Unsafe): Set 'unsafe' flag of contained block.
2009 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
2010 (Fixed.Resolve): Likewise.
2011 (Catch.Resolve): Likewise.
2012 (Using.ResolveLocalVariableDecls): Likewise.
2013 (Foreach.Resolve): Likewise.
2015 2004-10-05 John Luke <john.luke@gmail.com>
2017 * cs-parser.jay: add location to error CS0175
2019 2004-10-04 Miguel de Icaza <miguel@ximian.com>
2021 * ecore.cs (Expression.Constantity): Add support for turning null
2024 * const.cs (Const.Define): Allow constants to be reference types
2025 as long as the value is Null.
2027 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
2029 * namespace.cs (NamespaceEntry.Using): No matter which warning
2030 level is set, check if this namespace name has already been added.
2032 2004-10-03 Ben Maurer <bmaurer@ximian.com>
2034 * expression.cs: reftype [!=]= null should always use br[true,false].
2037 2004-10-03 Marek Safar <marek.safar@seznam.cz>
2040 * attribute.cs: Enum conversion moved to
2041 GetAttributeArgumentExpression to be applied to the all
2044 2004-10-01 Raja R Harinath <rharinath@novell.com>
2046 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
2047 * class.c (TypeContainer.DefineType): Flag error if
2048 base types aren't accessible due to access permissions.
2049 * decl.cs (DeclSpace.ResolveType): Move logic to
2050 Expression.ResolveAsTypeTerminal.
2051 (DeclSpace.ResolveTypeExpr): Thin layer over
2052 Expression.ResolveAsTypeTerminal.
2053 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
2054 Refactor code into NestedAccess. Use it.
2055 (DeclSpace.NestedAccess): New.
2056 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
2057 argument to silence errors. Check access permissions.
2058 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
2059 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
2060 (Cast.DoResolve): Likewise.
2061 (New.DoResolve): Likewise.
2062 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
2063 (TypeOf.DoResolve): Likewise.
2065 * expression.cs (Invocation.BetterConversion): Return the Type of
2066 the better conversion. Implement section 14.4.2.3 more faithfully.
2067 (Invocation.BetterFunction): Make boolean. Make correspondence to
2068 section 14.4.2.2 explicit.
2069 (Invocation.OverloadResolve): Update.
2070 (Invocation): Remove is_base field.
2071 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
2072 (Invocation.Emit): Likewise.
2074 2004-09-24 Marek Safar <marek.safar@seznam.cz>
2076 * cs-parser.jay: Reverted 642 warning fix.
2078 2004-09-23 Marek Safar <marek.safar@seznam.cz>
2081 * decl.cs (FindMemberWithSameName): Indexer can have more than
2084 2004-09-23 Marek Safar <marek.safar@seznam.cz>
2086 * expression.cs (LocalVariableReference.DoResolveLValue):
2087 Do not report warning 219 for out values.
2088 (EmptyExpression.Null): New member to avoid extra allocations.
2090 2004-09-23 Marek Safar <marek.safar@seznam.cz>
2092 * cs-parser.jay: Fix wrong warning 642 report.
2094 * cs-tokenizer.cs (CheckNextToken): New helper;
2095 Inspect next character if is same as expected.
2097 2004-09-23 Martin Baulig <martin@ximian.com>
2099 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
2100 (Convert.ImplicitReferenceConversionExists): Likewise.
2102 2004-11-09 Raja R Harinath <rharinath@novell.com>
2104 * Makefile (DISTFILES): Comment out a few missing files.
2106 2004-10-29 Raja R Harinath <rharinath@novell.com>
2108 * Makefile (bootstrap_libs,bootstrap_libfiles): New.
2109 (bootstrap-libs): New target. Invokes the net_2_0_bootstrap profile.
2110 (gmcs.exe): Invoke bootstrap-libs.
2111 (clean-local): Clean the net_2_0_bootstrap profile too.
2112 (PROGRAM_INSTALL_DIR): New.
2113 (install-local): Use it.
2115 2004-10-13 Martin Baulig <martin@ximian.com>
2117 * generic.cs (TypeManager.InflatedConstraints): New nested class.
2118 (TypeParameter.DefineType): If we're a method type parameter and
2119 that method is overriding something, "inflate" its constraints.
2121 2004-10-12 Martin Baulig <martin@ximian.com>
2123 * expression.cs (MemberAccess.DoResolve): If we're a SimpleName
2124 and have type arguments, create and resolve a ConstructedType.
2126 2004-10-12 Martin Baulig <martin@ximian.com>
2128 * decl.cs (MemberCache.FindMemberToOverride): Use
2129 TypeManager.IsEqual() to compare the parameters and Type.Equals()
2130 to compare the invocationType.
2132 * typemanager.cs (TypeManager.IsEqual): Added support for arrays.
2133 When comparing two type parameters, only do the signature-only
2134 comparision for method type parameters.
2136 2004-10-11 Martin Baulig <martin@ximian.com>
2138 * report.cs: Don't make --fatal abort on warnings, we have
2139 -warnaserror for that.
2141 2004-10-11 Martin Baulig <martin@ximian.com>
2144 (TypeManager.IsEqualGenericType): Removed, use IsEqual() instead.
2145 (TypeManager.IsEqual): Call ourself recursively instead of using
2148 2004-10-11 Martin Baulig <martin@ximian.com>
2150 * class.cs (TypeContainer.DefineType): Only call TypeParameter.Define()
2151 on our own type parameters, not on the ones we inherit from a containing
2154 * expression.cs (Invocation.InferType): Use `==', not `Equals()' for
2157 * generic.cs (TypeParameter.Define): We may only be called once.
2159 * pending.cs (Pending.InterfaceMethod): Call TypeManager.Real_IsEqual()
2160 instead of TypeManager.IsEqual().
2162 2004-09-28 Martin Baulig <martin@ximian.com>
2165 (GenericConstraints.EffectiveBaseClass): New public property.
2166 (TypeParameter.GenericConstraints): New public property.
2167 (ConstructedType.CheckConstraints): Improved.
2169 * convert.cs (Convert.TypeParam_EffectiveBaseType): New private method.
2170 (Convert.TypeParameterConversion): New private method; use this in
2171 ImplicitReferenceConversion() and ImplicitReferenceConversionExists()
2172 for all conversions related to type parameters.
2174 2004-09-24 Martin Baulig <martin@ximian.com>
2176 * convert.cs (Convert.ImplicitReferenceConversion): Added implicit
2177 type parameter conversions for type parameters which are known to
2180 2004-09-24 Martin Baulig <martin@ximian.com>
2182 * generic.cs (GenericConstraints): Added `IsReferenceType' and
2183 `IsValueType' properties.
2185 * support.cs (ReflectionConstraints): Use
2186 Type.GetGenericParameterConstraints() instead of the old hack.
2188 2004-09-24 Martin Baulig <martin@ximian.com>
2190 * generic.cs (GenericConstraints): Moved here and made it an
2193 * support.cs (GenericConstraints): Moved to generic.cs.
2195 2004-09-24 Martin Baulig <martin@ximian.com>
2198 (ReflectionConstraints): Un-nested this class and made it public.
2201 (TypeManager.GetTypeParameterConstraints): New public method.
2202 (TypeManager.HasConstructorConstraint): Use the attributes.
2204 2004-09-24 Martin Baulig <martin@ximian.com>
2206 * support.cs (GenericConstraints): Replaced `HasConstructor',
2207 `IsReferenceType' and `IsValueType' with `Attributes'.
2208 (ReflectionParameters.ReflectionConstraints): Removed the Create()
2209 method and made the .ctor public.
2211 * generic.cs (Constraints.Attributes): New public property.
2212 (Constraints): Renamed `HasConstructor' -> `HasConstructorConstraint',
2213 `IsReferenceType' -> `HasReferenceTypeConstraint' and
2214 `IsValueType' -> `HasValueTypeConstraint'.
2216 2004-09-23 Martin Baulig <martin@ximian.com>
2218 * generic.cs (Constraints): Reflect latest runtime changes.
2220 2004-09-23 Martin Baulig <martin@ximian.com>
2222 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
2223 (Convert.ImplicitReferenceConversionExists): Likewise.
2225 2004-09-23 Marek Safar <marek.safar@seznam.cz>
2227 * class.cs (Operator.Define): Add error 448 and 559 report.
2229 2004-09-22 Marek Safar <marek.safar@seznam.cz>
2231 * class.cs (MemberBase.IsTypePermitted): New protected
2232 method for checking error CS0610.
2234 2004-09-22 Marek Safar <marek.safar@seznam.cz>
2236 * class.cs (TypeContainer.HasExplicitLayout): New property
2237 Returns whether container has StructLayout attribute set Explicit.
2238 (FieldMember): New abstract class for consts and fields.
2239 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
2240 (Field): Reuse FieldMember.
2242 * const.cs (Const): Reuse FieldMember.
2244 * rootcontext.cs: EmitConstants call moved to class.
2246 2004-09-22 Martin Baulig <martin@ximian.com>
2248 Marek and me just fixed one of our oldest bugs: #28562 :-)
2250 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
2252 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
2253 we're an EnumConstant, just return that.
2254 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
2255 an EnumConstant. In this case, we need to use GetValueAsEnumType()
2256 to get the value which'll actually be written into the attribute.
2257 However, we have to use GetValue() to access the attribute's value
2260 2004-09-22 Marek Safar <marek.safar@seznam.cz>
2262 * constant.cs (Constant.IsNegative): New abstract property
2265 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
2266 (StackAlloc.DoResolve): Reused IsNegative.
2268 2004-09-22 Martin Baulig <martin@ximian.com>
2270 * typemanager.cs (TypeManager.LookupGenericTypeContainer): New
2271 public method; like LookupTypeContainer, but also works for
2274 * report.cs (Report.SymbolRelatedToPreviousError): Use
2275 TypeManager.LookupGenericTypeContainer().
2277 2004-09-22 Martin Baulig <martin@ximian.com>
2279 Thanks to Peter Sestoft for this bug report.
2281 * expression.cs (Conditional): If both the `trueExpr' and the
2282 `falseExpr' is a NullLiteral, return a NullLiteral.
2284 2004-09-22 Martin Baulig <martin@ximian.com>
2286 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
2287 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
2288 for the "get_Current" call.
2290 2004-09-21 Martin Baulig <martin@ximian.com>
2292 * convert.cs (Convert.ImplicitReferenceConversion): When
2293 converting to an interface type, first check whether we're
2294 converting from a reference type.
2296 2004-09-14 Martin Baulig <martin@ximian.com>
2298 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
2300 2004-09-14 Marek Safar <marek.safar@seznam.cz>
2303 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
2304 called and is obsolete then this member suppress message
2305 when call is inside next [Obsolete] method or type.
2307 * expression.cs: Use TestObsoleteMethodUsage member.
2309 2004-09-14 Martin Baulig <martin@ximian.com>
2311 * genericparser.cs: Removed.
2313 2004-09-13 Marek Safar <marek.safar@seznam.cz>
2315 * class.cs (MethodCore.CheckBase): Fix bug #65757.
2317 2004-09-12 Marek Safar <marek.safar@seznam.cz>
2319 * attribute.cs (Attribute.Resolve): Add error 653 report.
2321 * class.cs (Class.ApplyAttributeBuilder): Add error 641
2323 (Method.ApplyAttributeBuilder): Add error 685 report.
2324 (Operator.Define): Add error 564 report.
2326 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
2328 * expression.cs (Invocation.DoResolve): Add error
2331 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
2334 2004-09-11 Marek Safar <marek.safar@seznam.cz>
2336 * class.cs (ConstructorInitializer.Resolve):
2337 Wrong error number (515->516).
2339 2004-09-11 Marek Safar <marek.safar@seznam.cz>
2341 * class.cs (Indexer.Define): Add error 631 report.
2343 2004-09-11 Marek Safar <marek.safar@seznam.cz>
2345 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
2347 2004-09-11 Marek Safar <marek.safar@seznam.cz>
2349 * expression.cs (Probe.DoResolve): Add error CS0241 report.
2351 2004-09-10 Marek Safar <marek.safar@seznam.cz>
2353 * cs-parser.jay: Added error CS0241 report.
2355 2004-09-10 Raja R Harinath <rharinath@novell.com>
2357 * cs-parser.jay (fixed_statement): Introduce a scope for the
2358 declaration in the 'fixed' statement.
2360 2004-09-09 Marek Safar <marek.safar@seznam.cz>
2362 * cs-parser.jay: Added CS0230 error report.
2364 2004-09-09 Marek Safar <marek.safar@seznam.cz>
2366 * cs-parser.jay: Added errors CS0231 and CS0257 report.
2368 2004-09-09 Marek Safar <marek.safar@seznam.cz>
2370 * expression.cs (Argument.Resolve): Added error CS0192 and
2373 2004-09-09 Marek Safar <marek.safar@seznam.cz>
2375 C# 2.0 #pragma warning feature
2377 * cs-tokenizer.cs (PreProcessPragma): New method;
2378 Handles #pragma directive.
2380 * report.cs (WarningRegions): New class; Support
2381 class for #pragma warning directive. It tests whether
2382 warning is enabled for a given line.
2384 2004-09-08 Miguel de Icaza <miguel@ximian.com>
2386 * const.cs: Add more descriptive error report, tahnks to
2389 2004-09-08 Marek Safar <marek.safar@seznam.cz>
2391 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
2393 2004-09-07 Miguel de Icaza <miguel@ximian.com>
2395 * expression.cs: Apply patch from Ben: Remove dead code from
2396 ArrayCreation, and remove the TurnintoConstant call in const.cs,
2397 as that code just threw an exception anwyays.
2399 * const.cs: Remove the call to the turnintoconstant, for details
2402 * literal.cs: The type of the null-literal is the null type; So
2403 we use a placeholder type (literal.cs:System.Null, defined here)
2406 * expression.cs (Conditional.DoResolve): Remove some old code that
2407 is no longer needed, conversions have been fixed.
2409 (ArrayCreationExpression.DoResolve): Return false if we fail to
2410 resolve the inner expression.
2412 2004-09-07 Raja R Harinath <rharinath@novell.com>
2415 * cs-parser.jay (delegate_declaration): Record a delegate
2416 declaration as a type declaration.
2417 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
2419 2004-09-06 Miguel de Icaza <miguel@ximian.com>
2421 * parameter.cs: Do not crash if the type can not be resolved.
2423 * expression.cs: Report errors with unsafe pointers, fixes #64896
2425 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
2427 * expression.cs: Pointer arith always needs to do a conv.i
2428 if the operand is a long. fix 65320
2430 2004-09-04 Marek Safar <marek.safar@seznam.cz>
2432 Fixed cs0619-37.cs, cs0619-38.cs
2434 * enum.cs (GetObsoleteAttribute): Removed.
2436 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
2437 on Enum member is double staged. The first is tested member
2440 2004-09-04 Marek Safar <marek.safar@seznam.cz>
2442 Fixed #56986, #63631, #65231
2444 * class.cs: (TypeContainer.AddToMemberContainer): New method,
2445 adds member to name container.
2446 (TypeContainer.AddToTypeContainer): New method, adds type to
2448 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
2449 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
2450 AddOperator): Simplified by reusing AddToMemberContainer.
2451 (TypeContainer.UserDefinedStaticConstructor): Changed to property
2453 (Method.CheckForDuplications): Fixed implementation to test all
2455 (MemberBase): Detection whether member is explicit interface
2456 implementation is now in constructor.
2457 (MemberBase.UpdateMemberName): Handles IndexerName.
2458 (Accessor): Changed to keep also location information.
2459 (AbstractPropertyEventMethod): Is derived from MemberCore.
2460 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
2461 will be emited or not.
2462 (PropertyBase.AreAccessorsDuplicateImplementation):
2463 Tests whether accessors are not in collision with some method.
2464 (Operator): Is derived from MethodCore to simplify common
2467 * decl.cs (Flags.TestMethodDuplication): Test for duplication
2469 (DeclSpace.AddToContainer): Adds the member to defined_names
2470 table. It tests for duplications and enclosing name conflicts.
2472 * enum.cs (EnumMember): Clean up to reuse the base structures
2474 2004-09-03 Martin Baulig <martin@ximian.com>
2476 Merged latest changes into gmcs. Please keep this comment in
2477 here, it makes it easier for me to see what changed in MCS since
2478 the last time I merged.
2480 2004-09-03 Martin Baulig <martin@ximian.com>
2482 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
2483 into TypeContainer, to make partial classes work again.
2485 2004-09-03 Martin Baulig <martin@ximian.com>
2487 * rootcontext.cs (RootContext.V2): Removed.
2489 2004-03-23 Martin Baulig <martin@ximian.com>
2491 * expression.cs (Invocation.OverloadResolve): Added `bool
2492 may_fail' argument and use it instead of the Location.IsNull() hack.
2494 2004-09-09 Martin Baulig <martin@ximian.com>
2496 * cs-parser.jay (namespace_declaration): Fixed CS0134 reporting.
2498 2004-09-09 Martin Baulig <martin@ximian.com>
2500 * generic.cs (TypeParameter.DefineType): Added support for
2501 explicit interface methods.
2503 2004-09-09 Martin Baulig <martin@ximian.com>
2505 * README.Changes: New document. Started to list important changes
2506 between MCS and GMCS here.
2508 2004-09-08 Martin Baulig <martin@ximian.com>
2511 (TypeContainer.CheckRecursiveDefinition): New protected method.
2512 (TypeContainer.DefineType): Move the CS0146 check into
2513 CheckRecursiveDefinition().
2515 2004-09-06 Martin Baulig <martin@ximian.com>
2517 * generic.cs (ConstructedType.CheckConstraints): Allow builtin
2518 types for the constructor constraint.
2520 2004-09-03 Martin Baulig <martin@ximian.com>
2522 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
2523 into TypeContainer, to make partial classes work again.
2525 2004-09-03 Martin Baulig <martin@ximian.com>
2527 * rootcontext.cs (RootContext.V2): Removed.
2529 2004-03-23 Martin Baulig <martin@ximian.com>
2531 * expression.cs (Invocation.OverloadResolve): Added `bool
2532 may_fail' argument and use it instead of the Location.IsNull() hack.
2534 2004-09-03 Martin Baulig <martin@ximian.com>
2536 Merged latest changes into gmcs. Please keep this comment in
2537 here, it makes it easier for me to see what changed in MCS since
2538 the last time I merged.
2540 2004-09-03 Raja R Harinath <rharinath@novell.com>
2543 * expression.cs (BetterConversion): Don't allow either conversion
2544 to be null. Remove redundant implicit conversion test when 'q ==
2545 null' -- when this function is invoked, we already know that the
2546 implicit conversion exists.
2547 (BetterFunction): Assume that 'best' is non-null. Remove
2548 redundant reimplementation of IsApplicable when 'best' is null.
2549 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
2550 number of arguments.
2551 (IsAncestralType): Extract from OverloadResolve.
2552 (OverloadResolve): Make robust to the MethodGroupExpr being
2553 unsorted. Implement all the logic of Section 14.5.5.1, and
2554 support overloading of methods from multiple applicable types.
2555 Clean up logic somewhat. Don't pass null methods to BetterFunction.
2557 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
2558 (RealError, Warning): Append type of report to related symbol.
2560 2004-09-03 Marek Safar <marek.safar@seznam.cz>
2562 * enum.cs: Fixed CLS-Compliance checks for enum members.
2563 Error tests cs3008-8.cs, cs3014-8.cs
2565 2004-09-02 Marek Safar <marek.safar@seznam.cz>
2567 Fixed bug #62342, #63102
2568 * class.cs: ImplementIndexer uses member.IsExplicitImpl
2569 like ImplementMethod.
2571 2004-09-02 Marek Safar <marek.safar@seznam.cz>
2573 * attribute.cs (Attribute.GetAttributeArgumentExpression):
2576 2004-09-02 Martin Baulig <martin@ximian.com>
2578 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
2579 TypeManager.GetArgumentTypes() rather than calling GetParameters()
2582 2004-09-01 Marek Safar <marek.safar@seznam.cz>
2584 C# 2.0 Static classes implemented
2586 * class.cs (TypeContainer): instance_constructors,
2587 initialized_fields, initialized_static_fields,
2588 default_constructor, base_inteface_types are protected to be
2589 accessible from StaticClass.
2590 (TypeContainer.DefineDefaultConstructor): New virtual method
2591 for custom default constructor generating
2592 (StaticClass): New class to handle "Static classes" feature.
2594 * cs-parser.jay: Handle static keyword on class like instance
2597 * driver.cs: Added "/langversion" command line switch with two
2598 options (iso-1, default).
2600 2004-08-31 Marek Safar <marek.safar@seznam.cz>
2602 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
2604 2004-08-31 Miguel de Icaza <miguel@ximian.com>
2606 * delegate.cs: Style.
2608 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
2610 * delegate.cs: Add seperate instance expr field for miguel.
2612 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
2614 * PointerArithmetic (Resolve): make sure we are not doing
2615 pointer arith on void*. Also, make sure we are resolved
2616 by not setting eclass until resolve.
2618 All callers: Make sure that PointerArithmetic gets resolved.
2620 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
2622 * ArrayCreation (LookupType): If the type does not resolve
2623 to an array, give an error.
2625 2004-08-27 Marek Safar <marek.safar@seznam.cz>
2627 * statement.cs (Try.Resolve): Fixed bug #64222
2629 2004-08-27 Martin Baulig <martin@ximian.com>
2632 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
2635 2004-08-26 Marek Safar <marek.safar@seznam.cz>
2637 * ecore.cs (Constantify): Get underlying type via
2638 System.Enum.GetUnderlyingType to avoid StackOverflow on the
2639 Windows in special cases.
2641 2004-08-26 Marek Safar <marek.safar@seznam.cz>
2643 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
2644 for obtaining also private methods.
2645 (GetRemoveMethod): Used GetRemoveMethod (true)
2646 for obtaining also private methods.
2648 2004-09-02 Martin Baulig <martin@ximian.com>
2650 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
2651 TypeManager.GetArgumentTypes() rather than calling GetParameters()
2654 2004-08-27 Martin Baulig <martin@ximian.com>
2657 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
2660 2004-08-25 Martin Baulig <martin@ximian.com>
2662 * support.cs (ReflectionParameters..ctor): If this is a generic
2663 method, retrieve and store its type parameters.
2664 (InternalParameters..ctor): Added `TypeParameter[]' argument.
2665 (ReflectionParameters.GenericConstraints): The argument specifies
2666 the type parameter, not the method parameter.
2667 (InternalParameters.GenericConstraints): Likewise.
2669 * generic.cs (TypeParameter.DefineType): Correctly handle
2670 constraints wrt. generic methods in interfaces and their
2673 2004-08-24 Martin Baulig <martin@ximian.com>
2675 * generic.cs (TypeParameter.IsSubclassOf): New public method.
2676 (Constraints.IsSubclassOf): New internal method.
2678 * typemanager.cs (TypeManager.FindMembers): Added special support
2679 for GenericTypeParameterBuilder's.
2680 (TypeManager.IsSubclassOf, IsFamilyAccessible): Added support for
2683 2004-08-24 Martin Baulig <martin@ximian.com>
2686 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
2687 this for accessibility checks.
2688 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
2689 IsNestedFamilyAccessible.
2690 (TypeManager.IsSubclassOf): New method, do what the name actually
2693 2004-08-24 Martin Baulig <martin@ximian.com>
2695 * expression.cs (MemberAccess.DoResolve): When resolving ourselves
2696 as a SimpleName, include the generic arity.
2698 2004-08-24 Martin Baulig <martin@ximian.com>
2700 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
2701 MethodAttributes.HideBySig for operators.
2703 2004-08-23 Martin Baulig <martin@ximian.com>
2705 Back to the old error reporting system :-)
2707 * report.cs (Message): Removed.
2708 (Report.MessageData, ErrorData, WarningData): Removed.
2709 (Report.Error, Warning): Back to the old system.
2711 2004-08-23 Martin Baulig <martin@ximian.com>
2713 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
2715 * class.cs (TypeContainer.ParentContainer): New public virtual
2716 method; replaces the explicit interface implementation.
2717 (ClassPart.ParentContainer): Override.
2719 2004-08-23 Martin Baulig <martin@ximian.com>
2721 * statement.cs (Switch): Added support for constant switches; see
2722 #59428 or test-285.cs.
2724 2004-08-22 Marek Safar <marek.safar@seznam.cz>
2727 * statement.cs (GetEnumeratorFilter): Removed useless
2728 logic because C# specs is strict. GetEnumerator must be
2731 2004-08-22 Martin Baulig <martin@ximian.com>
2733 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
2734 a switch and may break, reset the barrier. Fixes #59867.
2736 2004-08-22 Marek Safar <marek.safar@seznam.cz>
2738 CLS-Compliance speed up (~5% for corlib)
2740 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
2741 New method. Tests container for CLS-Compliant names
2743 * class.cs (TypeContainer.VerifyClsName): New method.
2744 Checks whether container name is CLS Compliant.
2745 (Constructor): Implements IMethodData.
2747 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
2748 low-case table for CLS Compliance test.
2749 (MemberCache.VerifyClsParameterConflict): New method.
2750 Checks method parameters for CS3006 error.
2752 * enum.cs (EnumMember): Is derived from MemberCore.
2753 (Enum.VerifyClsName): Optimized for better performance.
2755 2004-08-06 Marek Safar <marek.safar@seznam.cz>
2757 * report.cs: Renamed Error_T to Error and changed all
2760 2004-08-06 Marek Safar <marek.safar@seznam.cz>
2762 * class.cs (TypeContainer.IndexerArrayList): New inner class
2763 container for indexers.
2764 (TypeContainer.DefaultIndexerName): New constant for default
2765 indexer name. Replaced all "Item" with this constant.
2766 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
2768 * typemanager.cs (TypeManager.default_member_ctor): Cache here
2769 DefaultMemberAttribute constructor.
2771 2004-08-05 Martin Baulig <martin@ximian.com>
2773 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
2776 2004-08-05 Marek Safar <marek.safar@seznam.cz>
2778 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
2779 multi platforms problem.
2781 * compiler.csproj: Included shared files.
2783 2004-08-04 Marek Safar <marek.safar@seznam.cz>
2785 Fix bug 60333, 55971 in the more general way
2786 * attribute.cs (Attribute.GetAttributeArgumentExpression):
2787 Added arg_type argument for constant conversion.
2788 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
2790 2004-08-04 Marek Safar <marek.safar@seznam.cz>
2793 * class.cs (TypeContainer ): New inner classes MethodArrayList,
2794 OperatorArrayList, MethodCoreArrayList for typecontainer
2795 containers. Changed class member types to these new types.
2796 (MethodArrayList.DefineMembers): Added test for CS0659.
2798 2004-08-04 Miguel de Icaza <miguel@ximian.com>
2800 * cfold.cs: Synchronize the folding with the code in expression.cs
2801 Binary.DoNumericPromotions for uint operands.
2803 * attribute.cs: Revert patch from Raja, it introduced a regression
2804 while building Blam-1.2.1 (hard to isolate a test case).
2806 2004-08-04 Marek Safar <marek.safar@seznam.cz>
2810 (TypeContainer.Define): Renamed to DefineContainerMembers because of
2812 (MethodCore.parent_method): New member. The method we're overriding
2813 if this is an override method.
2814 (MethodCore.CheckBase): Moved from Method class and made common.
2815 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
2817 (MethodCore.CheckForDuplications): New abstract method. For custom
2818 member duplication search in a container
2819 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
2820 method and its return type.
2821 (Event.conflict_symbol): New member. Symbol with same name in the
2825 (MemberCache.FindMemberWithSameName): New method. The method
2826 is looking for conflict with inherited symbols.
2828 2004-08-04 Martin Baulig <martin@ximian.com>
2830 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
2832 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
2834 2004-08-03 Marek Safar <marek.safar@seznam.cz>
2836 * report.cs (Message): New enum for better error, warning reference in
2838 (MessageData): New inner abstract class. It generally handles printing of
2839 error and warning messages.
2840 Removed unused Error, Warning, Message methods.
2842 2004-08-03 Marek Safar <marek.safar@seznam.cz>
2844 Fix for cs0592-8.cs test
2846 (Attributable.ValidAttributeTargets): Made public.
2847 (Attribute.ExplicitTarget): New member for explicit target value.
2848 (Attribute.CheckTargets): Now we translate explicit attribute
2849 target to Target here.
2851 2004-08-03 Ben Maurer <bmaurer@ximian.com>
2853 * ecore.cs (MethodGroupExpr): new IsBase property.
2855 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
2857 * delegate.cs (DelegateCreation): store a MethodGroupExpr
2858 rather than an instance expr.
2860 (DelegateCreation.Emit): Use the method group rather than
2861 the instance expression. Also, if you have base.Foo as the
2862 method for a delegate, make sure to emit ldftn, not ldftnvirt.
2864 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
2866 (NewDelegate.DoResolve): Only check for the existance of Invoke
2867 if the method is going to be needed. Use MethodGroupExpr.
2869 (NewDelegate.Emit): Remove, DelegateCreation implements this.
2871 * expression.cs: For pointer arith., make sure to use
2872 the size of the type, not the size of the pointer to
2875 2004-08-03 Marek Safar <marek.safar@seznam.cz>
2878 * class.cs (Class): Added error CS0502 test.
2880 2004-08-03 John Luke <jluke@cfl.rr.com>
2881 Raja R Harinath <rharinath@novell.com>
2884 * attribute.cs (Attribute.complained_before): New flag.
2885 (Attribute.ResolveType, Attribute.Resolve),
2886 (Attribute.DefinePInvokeMethod): Set it.
2887 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
2889 2004-08-03 Martin Baulig <martin@ximian.com>
2891 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
2892 use a user-defined operator; we still need to do numeric
2893 promotions in case one argument is a builtin type and the other
2894 one has an implicit conversion to that type. Fixes #62322.
2896 2004-08-18 Martin Baulig <martin@ximian.com>
2898 * class.cs (Method.Define): Use the correct method name when
2899 creating the MethodBuilder for a generic method.
2901 2004-08-17 Martin Baulig <martin@ximian.com>
2903 * generic.cs (Constraints): Support type parameter constraints.
2905 2004-08-16 Martin Baulig <martin@ximian.com>
2907 * cs-tokenizer.cs (Tokenizer.TypeOfParsing): New public property.
2908 (Token.GENERIC_DIMENSION): New token; this is returned if we
2909 encounter an unbound generic type in a typeof() expression.
2911 * cs-parser.jay (opt_type_argument_list): Added GENERIC_DIMENSION;
2912 this token is only generated while parsing a typeof() expression.
2913 (typeof_expression): Removed the old unbound_type hack.
2915 * generic.cs (TypeArguments.IsUnbound): New public property.
2917 * decl.cs (MemberName): Added support for unbound types.
2919 2004-08-14 Martin Baulig <martin@ximian.com>
2922 (TypeManager.IsEqualGenericInstance): New static method.
2923 (TypeManager.IsSubclassOrNestedChildOf, IsSubclassOf): This is
2924 just used to check accessibility, so follow the rules of 26.1.6.
2926 * expression.cs (MemberAccess.ResolveAsTypeStep): Return a
2927 ConstructedType instead of a TypeExpression if we have type arguments.
2929 * cs-parser.jay (typeof_expression): Support unbound generic types.
2931 * ecore.cs (UnboundTypeExpression): New public class.
2933 2004-08-12 Martin Baulig <martin@ximian.com>
2935 * typemanager.cs (TypeManager.IsNestedChildOf): Use
2936 TypeManager.IsEqual() rather than `=='.
2938 * decl.cs (DeclSpace.CheckAccessLevel): Use `tb.FullName' for
2939 generic instances as well.
2941 2004-08-12 Martin Baulig <martin@ximian.com>
2943 * expression.cs (Invocation.InferType): We can only infer method
2944 type parameters. Fixes #62647.
2946 2004-08-11 Martin Baulig <martin@ximian.com>
2948 * class.cs (TypeContainer.DefineType): Create the TypeBuilder
2949 before resolving the base classes.
2951 2004-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
2953 * Makefile: install .mdb file too.
2955 2004-08-05 Martin Baulig <martin@ximian.com>
2957 * ecore.cs (FieldExpr.DoResolveLValue): If we're resolving a field
2958 initializer, the current type is just the TypeBuilder, not the
2959 instantiated generic type.
2960 (FieldExpr.IsFieldInitializer): New public property.
2962 2004-08-04 Martin Baulig <martin@ximian.com>
2964 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
2966 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
2968 2004-08-03 Martin Baulig <martin@ximian.com>
2970 * class.cs (MethodData.Define): If we're an explicit
2971 implementation, remove the generic arity from the type name.
2973 2004-08-03 Martin Baulig <martin@ximian.com>
2975 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
2976 use a user-defined operator; we still need to do numeric
2977 promotions in case one argument is a builtin type and the other
2978 one has an implicit conversion to that type. Fixes #62322.
2980 2004-08-02 Martin Baulig <martin@ximian.com>
2982 * class.cs (TypeContainer.ifaces): Make this a `Type[]', not a
2984 (TypeContainer.GetClassBases): Return the unexpanded list of
2985 interfaces; we expand them later.
2986 (TypeContainer.DefineType): After creating the TypeBuilder, call
2987 TypeManager.ExpandInterfaces() to get an expanded and resolved
2990 * ecore.cs (TypeExpr.GetInterfaces): Removed
2992 * generics.cs (Constraints.InterfaceConstraints): Remove.
2993 (TypeParameter.DefineType): Call TypeManager.RegisterBuilder() to
2994 register the interface constraints.
2997 (TypeManager.AddUserType): Removed the `ifaces' argument.
2998 (TypeManager.AddTypeParameter): Likewise.
2999 (TypeManager.AddUserInterface): Removed, was unused.
3000 (TypeManager.RegisterBuilder): Take a `Type[]' instead of a
3001 `TypeExpr[]' array for the interfaces.
3002 (TypeManager.ExpandInterfaces): Call this after the TypeBuilder
3003 has been defined, returns a list of the resolved interfaces types.
3004 (TypeManager.GetInterfaces): Return a `Type[]', not a `TypeExpr[]'.
3005 (TypeManager.GetExplicitInterfaces): Likewise.
3007 2004-08-02 Martin Baulig <martin@ximian.com>
3009 * expression.cs (Invocation.EmitCall): If we're invoking a method
3010 on a type parameter, use the new `Constrained' prefix opcode.
3012 2004-08-02 Martin Baulig <martin@ximian.com>
3014 * statement.cs (LocalInfo.Flags): Added `IsThis'.
3015 (LocalInfo.IsThis): New public property.
3016 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
3018 2004-08-01 Martin Baulig <martin@ximian.com>
3020 * class.cs (TypeContainer.GetClassBases): Don't set the default
3021 here since we may get called from GetPartialBases().
3022 (TypeContainer.DefineType): If GetClassBases() didn't return a
3023 parent, use the default one.
3025 2004-07-30 Martin Baulig <martin@ximian.com>
3027 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
3029 * class.cs (SourceMethod): New public class, derive from the
3030 symbol writer's ISourceMethod.
3031 (Method): Use the new symbol writer API.
3033 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
3034 as argument and use the new symbol writer.
3037 (SourceFile): Implement the symbol writer's ISourceFile.
3038 (Location.SymbolDocument): Removed.
3039 (Location.SourceFile): New public property.
3041 * symbolwriter.cs: Use the new symbol writer API.
3043 2004-07-30 Raja R Harinath <rharinath@novell.com>
3045 * Makefile (install-local): Remove. Functionality moved to
3048 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
3050 * Makefile: Install mcs.exe.config file together with mcs.exe.
3051 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
3052 correct runtime version.
3054 2004-07-25 Martin Baulig <martin@ximian.com>
3057 (TypeContainer.RegisterOrder): Removed, this was unused.
3058 (TypeContainer, interface_order): Removed.
3059 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
3060 TypeContainer as argument since we can also be called with a
3061 `PartialContainer' for a partial class/struct/interface.
3062 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
3063 of checking whether we're an `Interface' - we could be a
3065 (PartialContainer.Register): Override; call
3066 AddClass()/AddStruct()/AddInterface() on our parent.
3068 * cs-parser.jay (interface_member_declaration): Add things to the
3069 `current_container', not the `current_class'.
3071 * rootcontext.cs (RegisterOrder): The overloaded version which
3072 takes an `Interface' was unused, removed.
3074 * typemanager.cs (TypeManager.LookupInterface): Return a
3075 `TypeContainer', not an `Interface'.
3076 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
3077 contain a `PartialContainer' for an interface, so check it's
3078 `Kind' to figure out what it is.
3080 2004-07-25 Martin Baulig <martin@ximian.com>
3082 * class.cs (Class.DefaultTypeAttributes): New public constant.
3083 (Struct.DefaultTypeAttributes): Likewise.
3084 (Interface.DefaultTypeAttributes): Likewise.
3085 (PartialContainer.TypeAttr): Override this and add the
3086 DefaultTypeAttributes.
3088 2004-07-25 Martin Baulig <martin@ximian.com>
3090 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
3091 we can just use the `Parent' field instead.
3093 2004-07-25 Martin Baulig <martin@ximian.com>
3095 * class.cs (TypeContainer.Emit): Renamed to EmitType().
3097 2004-07-25 Martin Baulig <martin@ximian.com>
3099 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
3100 our parts before defining any methods.
3101 (TypeContainer.VerifyImplements): Make this virtual.
3102 (ClassPart.VerifyImplements): Override and call VerifyImplements()
3103 on our PartialContainer.
3105 2004-07-25 Martin Baulig <martin@ximian.com>
3107 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
3109 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
3110 argument, we can just use the `Parent' field instead.
3113 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
3114 (MemberBase.DoDefine): Likewise.
3116 2004-07-24 Martin Baulig <martin@ximian.com>
3118 * decl.cs (MemberCore.Parent): New public field.
3119 (DeclSpace.Parent): Moved to MemberCore.
3121 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
3122 (MemberBase.ctor): Added TypeContainer argument, pass it to our
3124 (FieldBase, Field, Operator): Likewise.
3125 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
3126 (EventField, Event): Likewise.
3128 2004-07-23 Martin Baulig <martin@ximian.com>
3130 * class.cs (PartialContainer): New public class.
3131 (ClassPart): New public class.
3132 (TypeContainer): Added support for partial classes.
3133 (TypeContainer.GetClassBases): Splitted some of the functionality
3134 out into GetNormalBases() and GetPartialBases().
3136 * cs-tokenizer.cs (Token.PARTIAL): New token.
3137 (Tokenizer.consume_identifier): Added some hacks to recognize
3138 `partial', but only if it's immediately followed by `class',
3139 `struct' or `interface'.
3141 * cs-parser.jay: Added support for partial clases.
3143 2004-07-23 Martin Baulig <martin@ximian.com>
3145 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
3146 a `DeclSpace' and also made it readonly.
3147 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
3148 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
3149 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
3151 * cs-parser.jay: Pass the `current_class', not the
3152 `current_container' (at the moment, this is still the same thing)
3153 to a new Method, Property, Event, Indexer or Constructor.
3155 2004-07-23 Martin Baulig <martin@ximian.com>
3157 * cs-parser.jay (CSharpParser): Added a new `current_class' field
3158 and removed the `current_interface' one.
3159 (struct_declaration, class_declaration, interface_declaration):
3160 Set `current_class' to the newly created class/struct/interface;
3161 set their `Bases' and call Register() before parsing their body.
3163 2004-07-23 Martin Baulig <martin@ximian.com>
3165 * class.cs (Kind): New public enum.
3166 (TypeContainer): Made this class abstract.
3167 (TypeContainer.Kind): New public readonly field.
3168 (TypeContainer.CheckDef): New public method; moved here from
3170 (TypeContainer.Register): New public abstract method.
3171 (TypeContainer.GetPendingImplementations): New public abstract
3173 (TypeContainer.GetClassBases): Removed the `is_class' and
3174 `is_iface' parameters.
3175 (TypeContainer.DefineNestedTypes): Formerly known as
3177 (ClassOrStruct): Made this class abstract.
3179 * tree.cs (RootTypes): New public type.
3181 2004-07-20 Martin Baulig <martin@ximian.com>
3183 * tree.cs (Tree.RecordNamespace): Removed.
3184 (Tree.Namespaces): Removed.
3186 * rootcontext.cs (RootContext.IsNamespace): Removed.
3188 * cs-parser.jay (namespace_declaration): Just create a new
3189 NamespaceEntry here.
3191 2004-07-21 Lluis Sanchez Gual <lluis@novell.com>
3193 * Makefile: Install gmcs.exe.config file together with gmcs.exe.
3194 * gmcs.exe.config: Renamed from mcs.exe.config. Added supportedRuntime
3195 entry to make sure it runs in the correct runtime version.
3197 2004-07-18 Martin Baulig <martin@ximian.com>
3199 * generic.cs (ConstructedType.CheckConstraints): Improved
3200 constraints checking.
3202 2004-07-18 Martin Baulig <martin@ximian.com>
3204 * expression.cs (Invocation.BetterMethod): Call
3205 TypeManager.TypeToCoreType() on all types and removed my previous
3206 hack; we're already doig the right thing here.
3208 2004-07-17 Martin Baulig <martin@ximian.com>
3210 * decl.cs (MemberName.MakeName): Create the "class`1" names here.
3212 2004-07-16 Martin Baulig <martin@ximian.com>
3214 * iterators.cs: Added generics support.
3216 2004-07-16 Martin Baulig <martin@ximian.com>
3218 * iterators.cs: Rewrote this. We're now using one single Proxy
3219 class for both the IEnumerable and the IEnumerator interface and
3220 `Iterator' derives from Class so we can use the high-level API.
3222 * class.cs (TypeContainer.AddIterator): New method.
3223 (TypeContainer.DoDefineType): New protected virtual method, which
3224 is called from DefineType().
3225 (TypeContainer.DoDefineMembers): Call DefineType() and
3226 DefineMembers() on all our iterators.
3227 (TypeContainer.Emit): Call Emit() on all our iterators.
3228 (TypeContainer.CloseType): Call CloseType() on all our iterators.
3230 * codegen.cs (EmitContext.CurrentIterator): New public field.
3232 2004-07-15 Martin Baulig <martin@ximian.com>
3235 (TypeManager.not_supported_exception_type): New type.
3237 2004-07-14 Martin Baulig <martin@ximian.com>
3240 (TypeManager.generic_ienumerable_type): New type.
3241 (TypeManager.generic_ienumerator_type): New type.
3244 (RootContext.interfaces_first_stage): Added
3245 "System.Collections.Generic.IEnumerator`1" and
3246 "System.Collections.Generic.IEnumerable`1".
3248 2004-07-14 Martin Baulig <martin@ximian.com>
3250 * iterators.cs: Use real error numbers.
3252 2004-07-14 Martin Baulig <martin@ximian.com>
3254 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
3255 requires this to be a System.Collection.IEnumerable and not a
3256 class implementing that interface.
3257 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
3259 2004-07-13 Marek Safar <marek.safar@seznam.cz>
3261 * class.cs: Fixed previous fix, it broke some error tests.
3263 2004-07-12 Martin Baulig <martin@ximian.com>
3265 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
3268 2004-07-14 Martin Baulig <martin@ximian.com>
3270 * decl.cs, expression.cs, generic.cs: Use a backqoute (`) and not
3271 an exclamation mark (!) for the generic arity to reflect the
3272 latest spec changes; ie. use "System.Collections.Generic.IList`1".
3274 2004-07-13 Martin Baulig <martin@ximian.com>
3276 * cs-tokenizer.cs (Tokenizer.parse_less_than): Allow array rank
3277 specifiers being part of a type argument.
3279 2004-07-13 Martin Baulig <martin@ximian.com>
3281 * expression.cs (MemberAccess.ResolveAsTypeStep): Use the full `!'
3282 name for generic types.
3284 2004-07-13 Martin Baulig <martin@ximian.com>
3286 * assign.cs (Assign.DoResolve): Moved the CS0131 check up a little
3289 2004-07-09 Miguel de Icaza <miguel@ximian.com>
3291 * assign.cs (LocalTemporary): Add new argument: is_address,If
3292 `is_address' is true, then the value that we store is the address
3293 to the real value, and not the value itself.
3295 * ecore.cs (PropertyExpr): use the new local temporary
3296 stuff to allow us to handle X.Y += z (where X is a struct)
3298 2004-07-08 Martin Baulig <martin@ximian.com>
3300 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
3301 not always return, just like we're doing in Using.Resolve().
3303 2004-07-07 Miguel de Icaza <miguel@ximian.com>
3305 * cs-parser.jay (fixed_statement): flag this as Pinned.
3307 2004-07-06 Miguel de Icaza <miguel@ximian.com>
3309 * typemanager.cs (TypeManager): Removed MakePinned method, this
3310 mechanism is replaced with the .NET 2.x compatible mechanism of
3311 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
3313 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
3314 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
3315 `IsFixed' property which has a different meaning.
3317 2004-07-02 Raja R Harinath <rharinath@novell.com>
3319 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
3320 visible from inside a nested class, not just the names of the
3321 immediately enclosing class.
3324 2004-06-24 Raja R Harinath <rharinath@novell.com>
3326 * expression.cs (BetterConversion): Remove buggy special-case
3327 handling of "implicit constant expression conversions". At this
3328 point, we already know that the conversion is possible -- we're
3329 only checking to see which is better.
3331 2004-06-24 Marek Safar <marek.safar@seznam.cz>
3333 * cs-parser.jay: Added error CS0210 test.
3335 2004-06-24 Marek Safar <marek.safar@seznam.cz>
3337 * cs-parser.jay: Added error CS0134 test.
3339 2004-06-24 Marek Safar <marek.safar@seznam.cz>
3342 * cs-parser.jay: Added error CS0145 test.
3344 2004-06-24 Marek Safar <marek.safar@seznam.cz>
3346 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
3348 2004-06-23 Ben Maurer <bmaurer@ximian.com>
3350 * expression.cs (StackAlloc.Resolve): The argument may not
3351 be a constant; deal with this case.
3353 2004-06-23 Marek Safar <marek.safar@seznam.cz>
3355 * attribute.cs (IndexerName_GetIndexerName): Renamed to
3356 GetIndexerAttributeValue.
3357 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
3359 * class.cs (Indexer.Define): Added error tests for CS0415,
3362 2004-06-23 Miguel de Icaza <miguel@ximian.com>
3364 * attribute.cs (Attribute.Resolve): Keep field code in sync with
3367 2004-06-23 Martin Baulig <martin@ximian.com>
3369 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
3370 neither return nor throw, reset the barrier as well. Fixes #60457.
3372 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
3374 * class.cs : EventAttributes is now set to None by default.
3375 This fixes bug #60459.
3377 2004-06-18 Marek Safar <marek.safar@seznam.cz>
3380 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
3381 Don't throw exception but return null (it's sufficient now).
3383 2004-06-18 Marek Safar <marek.safar@seznam.cz>
3385 * typemanager.cs (GetArgumentTypes): Faster implementation.
3387 2004-06-18 Martin Baulig <martin@ximian.com>
3389 * attribute.cs (Attribute.Resolve): Check whether we're an
3390 EmptyCast which a Constant child. Fixes #60333.
3392 2004-06-17 Ben Maurer <bmaurer@ximian.com>
3394 * statement.cs (EmitCollectionForeach): Account for the fact that
3395 not all valuetypes are in areas which we can take the address of.
3396 For these variables, we store to a temporary variable. Also, make
3397 sure that we dont emit a `callvirt' on a valuetype method.
3399 2004-06-15 Marek Safar <marek.safar@seznam.cz>
3401 * expression.cs (StackAlloc.DoReSolve): Added test for
3402 negative parameter (CS0247).
3404 2004-06-15 Marek Safar <marek.safar@seznam.cz>
3407 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
3409 2004-06-15 Marek Safar <marek.safar@seznam.cz>
3412 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
3415 2004-06-14 Marek Safar <marek.safar@seznam.cz>
3417 Fix bug #58254 & cs1555.cs, cs1556.cs
3418 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
3420 2004-06-14 Marek Safar <marek.safar@seznam.cz>
3422 * cs-parser.jay: Added error CS1669 test for indexers.
3424 2004-06-18 Martin Baulig <martin@ximian.com>
3426 * generics.cs (GenericMethod.ctor): Don't take an Attributes
3427 argument. Fixes #60441.
3429 2004-06-16 Ben Maurer <bmaurer@ximian.com>
3430 * ecore.cs (MethodGroupExpr.Name): Revert Martin's patch.
3431 The name needs to have the actual name of the method in order
3432 for other tests (such as the one in OverloadResolve for Invoke
3433 on a delegate) to work. As well, it does not really help
3434 error reporting because the method group had multiple methods.
3435 * Makefile: Remove MCS_DEBUG, you can enable with the DEBUG_FLAGS.
3436 Make profiling work.
3438 2004-06-13 Martin Baulig <martin@ximian.com>
3440 * cs-parser.jay: Don't allow generic attributes.
3442 2004-06-13 Martin Baulig <martin@ximian.com>
3444 * class.cs (MemberBase.DoDefineBase): New protected method.
3445 (MemberBase.DoDefine): Compute the `flags' in the new
3446 DoDefineBase() which must be called first.
3447 (Method.Define): Call DoDefineBase() first so we have the flags
3448 when defining the generic method.
3450 * cs-parser.jay (interface_method_declaration): Support generic methods.
3452 2004-06-13 Martin Baulig <martin@ximian.com>
3454 * decl.cs (TypeName): Removed.
3455 (MemberName): Removed TypeName and MemberNow; now we just have
3458 * cs-parser.jay: Don't distinguish between type arguments and type
3459 parameters in the grammar and simplified the rules a bit. The
3460 reduce/reduce conflicts are now gone (except the one we inherited
3463 2004-06-11 Martin Baulig <martin@ximian.com>
3465 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
3466 call this twice: for params and varargs methods.
3468 2004-06-11 Marek Safar <marek.safar@seznam.cz>
3471 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
3473 2004-06-11 Marek Safar <marek.safar@seznam.cz>
3475 * attribute.cs (Attribute.GetValidTargets): Made public.
3478 (AbstractPropertyEventMethod): New class for better code sharing.
3479 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
3481 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
3483 2004-06-09 Martin Baulig <martin@ximian.com>
3485 * cs-parser.jay: Removed a reduce/reduce conflict.
3487 2004-06-03 Martin Baulig <martin@ximian.com>
3489 * generic.cs (ConstructedType.GetMemberAccess): Renamed to
3490 GetSimpleName() and return a SimpleName.
3492 * ecore.cs (SimpleName.Arguments): New public field.
3493 (SimpleName): Added overloaded ctor which takes an additional
3494 TypeArguments argument.
3495 (SimpleName.SimpleNameResolve): Added support for generic methods.
3496 (MethodGroupExpr.ResolveGeneric): New public method. The code was
3497 formerly in MemberAccess.DoResolve(), but we also need it in
3498 SimpleNameResolve().
3500 * expression.cs (MemberAccess.DoResolve): Use the new
3501 MethodGroupExpr.ResolveGeneric().
3503 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
3505 * decl.cs: If possible, use lookuptypedirect here. We can only do
3506 this if there is no `.' after the namespace. Avoids using
3507 LookupType, which does lots of slow processing.
3508 (FindNestedType) New method, does what it says :-).
3509 * namespace.cs: use LookupTypeDirect.
3510 * rootcontext.cs: use membercache, if possible.
3511 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
3513 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
3516 According to the spec,
3518 In a member access of the form E.I, if E is a single identifier,
3519 and if the meaning of E as a simple-name (§7.5.2) is a constant,
3520 field, property, localvariable, or parameter with the same type as
3521 the meaning of E as a type-name (§3.8), then both possible
3522 meanings of E are permitted.
3524 We did not check that E as a simple-name had the same type as E as
3527 This trivial check gives us 5-7% on bootstrap time.
3529 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
3531 * expression.cs (Invocation.OverloadResolve): Avoid the
3532 use of hashtables and boxing here by allocating on demand.
3534 2004-05-30 Martin Baulig <martin@ximian.com>
3536 * rootcontext.cs (RootContext.LookupType): Don't cache things if
3537 we're doing a silent lookup. Don't try to lookup nested types in
3538 TypeManager.object_type (thanks to Ben Maurer).
3540 2004-05-30 Martin Baulig <martin@ximian.com>
3542 Committing a patch from Ben Maurer.
3544 * rootcontext.cs (RootContext.LookupType): Cache negative results.
3546 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
3548 * convert.cs: add a trivial cache for overload operator resolution.
3550 2004-05-31 Marek Safar <marek.safar@seznam.cz>
3553 (AttributeTester.GetObsoleteAttribute): Returns instance of
3554 ObsoleteAttribute when type is obsolete.
3557 (TypeContainer.VerifyObsoleteAttribute): Override.
3558 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
3559 (MethodCode.VerifyObsoleteAttribute): Override.
3560 (MemberBase.VerifyObsoleteAttribute): Override.
3563 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
3564 and report proper error.
3567 (Delegate.VerifyObsoleteAttribute): Override.
3570 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
3571 and report proper error.
3572 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
3575 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
3579 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
3580 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
3581 Added test for ObsoleteAttribute.
3584 (Catch): Derived from Statement.
3586 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
3588 * decl.cs: If possible, use lookuptypedirect here. We can only do
3589 this if there is no `.' after the namespace. Avoids using
3590 LookupType, which does lots of slow processing.
3591 (FindNestedType) New method, does what it says :-).
3592 * namespace.cs: use LookupTypeDirect.
3593 * rootcontext.cs: use membercache, if possible.
3594 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
3596 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
3599 According to the spec,
3601 In a member access of the form E.I, if E is a single identifier,
3602 and if the meaning of E as a simple-name (§7.5.2) is a constant,
3603 field, property, localvariable, or parameter with the same type as
3604 the meaning of E as a type-name (§3.8), then both possible
3605 meanings of E are permitted.
3607 We did not check that E as a simple-name had the same type as E as
3610 This trivial check gives us 5-7% on bootstrap time.
3612 2004-05-30 Marek Safar <marek.safar@seznam.cz>
3614 Fixed bug #59071 & cs0160.cs
3615 * statement.cs (Try.Resolve): Check here whether order of catch
3616 clauses matches their dependencies.
3618 2004-05-30 Marek Safar <marek.safar@seznam.cz>
3621 * ecore.cs (SimpleName.SimpleNameResolve): Added test for
3624 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
3626 * expression.cs (Invocation.OverloadResolve): Avoid the
3627 use of hashtables and boxing here by allocating on demand.
3629 2004-05-30 Martin Baulig <martin@ximian.com>
3631 * rootcontext.cs (RootContext.LookupType): Don't cache things if
3632 we're doing a silent lookup. Don't try to lookup nested types in
3633 TypeManager.object_type (thanks to Ben Maurer).
3635 2004-05-30 Martin Baulig <martin@ximian.com>
3637 Committing a patch from Ben Maurer.
3639 * rootcontext.cs (RootContext.LookupType): Cache negative results.
3641 2004-05-29 Martin Baulig <martin@ximian.com>
3643 * class.cs (IMethodData.ShouldIgnore): New method.
3645 * typemanager.cs (TypeManager.MethodFlags): Don't take a
3646 `Location' argument, we don't need it anywhere. Use
3647 `IMethodData.ShouldIgnore ()' instead of
3648 `MethodData.GetMethodFlags ()'.
3649 (TypeManager.AddMethod): Removed.
3650 (TypeManager.AddMethod2): Renamed to AddMethod.
3652 2004-05-29 Martin Baulig <martin@ximian.com>
3654 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
3656 * convert.cs (Convert.ImplicitReferenceConversion): If we're
3657 converting from a class type S to an interface type and we already
3658 have an object on the stack, don't box it again. Fixes #52578.
3660 2004-05-29 Martin Baulig <martin@ximian.com>
3662 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
3663 Added support for `params' parameters. Fixes #59267.
3665 2004-05-29 Martin Baulig <martin@ximian.com>
3667 * literal.cs (NullPointer): Provide a private .ctor which sets
3668 `type' to TypeManager.object_type. Fixes #59048.
3670 2004-05-29 Martin Baulig <martin@ximian.com>
3672 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
3673 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
3675 * ecore.cs (EventExpr.instance_expr): Make the field private.
3677 2004-05-26 Marek Safar <marek.safar@seznam.cz>
3679 Fixed bug #50080 & cs0214-2.cs
3680 * expression.cs (Cast.DoResolve): Check unsafe context here.
3682 * statement.cs (Resolve.DoResolve): Likewise.
3684 2004-05-26 Martin Baulig <martin@ximian.com>
3686 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
3688 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
3689 (RootContext.LookupType): Pass down the `silent' flag.
3691 2004-05-25 Martin Baulig <martin@ximian.com>
3694 (MethodGroupExpr.IdenticalTypeName): New public property.
3695 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
3696 expression actually refers to a type.
3698 2004-05-25 Martin Baulig <martin@ximian.com>
3700 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
3701 for #56176 and made it actually work.
3703 2004-05-25 Martin Baulig <martin@ximian.com>
3705 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
3706 (FieldExpr, PropertyExpr): Override and implement
3707 CacheTemporaries. Fixes #52279.
3709 2004-05-25 Miguel de Icaza <miguel@ximian.com>
3711 * location.cs: In the new compiler listing a file twice is a
3712 warning, not an error.
3714 2004-05-24 Martin Baulig <martin@ximian.com>
3716 * enum.cs (Enum.DefineType): For the `BaseType' to be a
3717 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
3719 2004-05-24 Martin Baulig <martin@ximian.com>
3721 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
3722 walking the `using' list. Fixes #53921.
3724 2004-05-24 Martin Baulig <martin@ximian.com>
3726 * const.cs (Const.LookupConstantValue): Added support for
3727 EmptyCast's; fixes #55251.
3729 2004-05-24 Martin Baulig <martin@ximian.com>
3731 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
3732 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
3733 which does the CS0135 check. The reason is that we first need to
3734 check whether the variable actually exists.
3736 2004-05-24 Martin Baulig <martin@ximian.com>
3738 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
3739 than RootContext.LookupType() to find the explicit interface
3742 2004-05-24 Raja R Harinath <rharinath@novell.com>
3744 * Makefile: Simplify. Use executable.make.
3745 * mcs.exe.sources: New file. List of sources of mcs.exe.
3747 2004-05-24 Anders Carlsson <andersca@gnome.org>
3751 Use the invariant culture when doing String.Compare for CLS case
3754 2004-05-23 Martin Baulig <martin@ximian.com>
3756 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
3757 don't have any dots. Fixes #52622, added cs0246-8.cs.
3759 * namespace.cs (NamespaceEntry.Lookup): Likewise.
3761 2004-05-23 Marek Safar <marek.safar@seznam.cz>
3763 * class.cs (MemberBase.Define): Reuse MemberType member for
3764 resolved type. Other methods can use it too.
3766 2004-05-23 Martin Baulig <martin@ximian.com>
3768 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
3769 the variable also exists in the current block (otherwise, we need
3770 to report a CS0103). Fixes #58670.
3772 2004-05-23 Martin Baulig <martin@ximian.com>
3774 * flowanalysis.cs (Reachability.Reachable): Compute this
3775 on-the-fly rather than storing it as a field.
3777 2004-05-23 Martin Baulig <martin@ximian.com>
3779 * flowanalysis.cs (Reachability.And): Manually compute the
3780 resulting `barrier' from the reachability.
3782 2004-05-23 Marek Safar <marek.safar@seznam.cz>
3785 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
3786 instance of ObsoleteAttribute when symbol is obsolete.
3789 (IMethodData): Extended interface for ObsoleteAttribute support.
3791 2004-05-22 Marek Safar <marek.safar@seznam.cz>
3793 * attribute.cs: Fix bug #55970
3795 2004-05-22 Marek Safar <marek.safar@seznam.cz>
3799 (GetObsoleteAttribute): New method. Creates the instance of
3801 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
3802 ObsoleteAttribute when member is obsolete.
3803 (AttributeTester.Report_ObsoleteMessage): Common method for
3804 Obsolete error/warning reporting.
3807 (TypeContainer.base_classs_type): New member for storing parent type.
3810 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
3811 for this MemberCore.
3813 2004-05-21 Marek Safar <marek.safar@seznam.cz>
3815 * attribute.cs, const.cs: Fix bug #58590
3817 2004-05-21 Martin Baulig <martin@ximian.com>
3819 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
3820 out parameters if the end of the method is unreachable. Fixes
3823 2004-05-21 Marek Safar <marek.safar@seznam.cz>
3825 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
3826 Hari was right, why extra method.
3828 2004-05-21 Marek Safar <marek.safar@seznam.cz>
3830 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
3832 2004-05-20 Martin Baulig <martin@ximian.com>
3834 * delegate.cs: Convert this file to Unix mode - like the original
3837 2004-05-20 Martin Baulig <martin@ximian.com>
3839 * attribute.cs: Convert this file to Unix mode - like the original
3842 2004-05-19 Marek Safar <marek.safar@seznam.cz>
3844 Fix bug #58688 (MCS does not report error when the same attribute
3847 * attribute.cs (Attribute.Emit): Distinction between null and default.
3849 2004-05-19 Raja R Harinath <rharinath@novell.com>
3851 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
3852 of a top-level attribute without an attribute target.
3853 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
3855 (Attribute.Conditional_GetConditionName),
3856 (Attribute.Obsolete_GetObsoleteMessage): Update.
3857 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
3858 part of ScanForIndexerName.
3859 (Attribute.CanIgnoreInvalidAttribute): New function.
3860 (Attribute.ScanForIndexerName): Move to ...
3861 (Attributes.ScanForIndexerName): ... here.
3862 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
3863 (Attributes.Search): New internal variant that can choose not to
3864 complain if types aren't resolved. The original signature now
3866 (Attributes.GetClsCompliantAttribute): Use internal variant, with
3867 complaints suppressed.
3868 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
3869 only if it not useful.
3870 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
3871 top-level for attributes that are shared between the assembly
3872 and a top-level class.
3873 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
3874 * class.cs: Update to reflect changes.
3875 (DefineIndexers): Fuse loops.
3876 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
3877 a couple more variants of attribute names.
3879 2004-05-18 Marek Safar <marek.safar@seznam.cz>
3881 Fix bug #52585 (Implemented explicit attribute declaration)
3884 (Attributable.ValidAttributeTargets): New abstract method. It gets
3885 list of valid attribute targets for explicit target declaration.
3886 (Attribute.Target): It holds target itself.
3887 (AttributeSection): Removed.
3888 (Attribute.CheckTargets): New method. It checks whether attribute
3889 target is valid for the current element.
3892 (EventProperty): New class. For events that are declared like
3893 property (with add and remove accessors).
3894 (EventField): New class. For events that are declared like field.
3897 * cs-parser.jay: Implemented explicit attribute target declaration.
3899 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
3900 Override ValidAttributeTargets.
3903 (ReturnParameter): Class for applying custom attributes on
3905 (ParameterAtribute): New class. Class for applying custom
3906 attributes on the parameter type.
3908 2004-05-17 Miguel de Icaza <miguel@ximian.com>
3910 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
3913 (Method): Allow UNSAFE here.
3915 * modifiers.cs: Support unsafe reporting.
3917 2004-05-17 Marek Safar <marek.safar@seznam.cz>
3919 * decl.cs: Fix bug #58478.
3921 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
3923 * statement.cs: When checking for unreachable code on an EmptyStatement,
3924 set the location. Fixes bug #58488.
3926 2004-05-13 Miguel de Icaza <miguel@ximian.com>
3928 * driver.cs: Add -pkg handling.
3930 From Gonzalo: UseShelLExecute=false
3932 2004-05-12 Marek Safar <marek.safar@seznam.cz>
3935 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
3937 (Attribute.IsClsCompliaceRequired): Moved to base for better
3939 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
3940 when attribute is AttributeUsageAttribute.
3941 (Attribute.GetValidTargets): Simplified.
3942 (Attribute.GetAttributeUsage): New method returns AttributeUsage
3943 attribute for this type.
3944 (Attribute.ApplyAttributes): Method renamed to Emit and make
3946 (GlobalAttributeSection): New class for special handling of global
3947 attributes (assembly, module).
3948 (AttributeSection.Emit): New method.
3950 * class.cs: Implemented Attributable abstract methods.
3951 (MethodCore.LabelParameters): Moved to Parameter class.
3952 (Accessor): Is back simple class.
3953 (PropertyMethod): Implemented Attributable abstract class.
3954 (DelegateMethod): Implemented Attributable abstract class.
3955 (Event): New constructor for disctintion between normal Event
3956 and Event with accessors.
3958 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
3960 * codegen.cs, const.cs, decl.cs, delegate.cs:
3961 (CommonAssemblyModulClass): Implemented Attributable abstract class
3964 * enum.cs: Implement IAttributeSupport interface.
3965 (EnumMember): New class for emum members. Implemented Attributable
3969 (ParameterBase): Is abstract.
3970 (ReturnParameter): New class for easier [return:] attribute handling.
3972 * typemanager.cs: Removed builder_to_attr.
3974 2004-05-11 Raja R Harinath <rharinath@novell.com>
3977 * attribute.cs (Attribute.GetPositionalValue): New function.
3978 * class.cs (TypeContainer.VerifyMembers): New function.
3979 (TypeContainer.Emit): Use it.
3980 (ClassOrStruct): New base class for Class and Struct.
3981 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
3982 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
3984 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
3985 then each non-static field should have a FieldOffset attribute.
3986 Otherwise, none of the fields should have a FieldOffset attribute.
3987 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
3988 and FieldOffset attributes.
3989 * typemanager.cs (TypeManager.struct_layout_attribute_type)
3990 (TypeManager.field_offset_attribute_type): New core types.
3991 (TypeManager.InitCoreTypes): Initialize them.
3993 2004-05-11 Michal Moskal <malekith@pld-linux.org>
3995 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
3996 Return correct type.
3999 2004-05-09 Miguel de Icaza <miguel@ximian.com>
4001 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
4002 be implicitly converted to ulong.
4004 * expression.cs: The logic for allowing operator &, | and ^ worked
4005 was wrong, it worked before because we did not report an error in
4006 an else branch. Fixes 57895.
4008 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
4009 allow volatile fields to be reference types.
4011 2004-05-07 Miguel de Icaza <miguel@ximian.com>
4013 * driver.cs: Add support for /debug-
4015 2004-05-07 Raja R Harinath <rharinath@novell.com>
4017 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
4018 Add a 'complain' parameter to silence errors.
4019 (Attribute.Resolve): Update to changes. Put in sanity check to catch
4020 silently overlooked type-resolutions.
4021 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
4023 (Attributes.Search): New function.
4024 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
4025 (Attributes.GetAttributeFullName): Remove hack.
4026 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
4027 Update to reflect changes.
4028 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
4029 Use Attributes.Search instead of nested loops.
4031 2004-05-07 Marek Safar <marek.safar@seznam.cz>
4034 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
4035 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
4036 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
4038 * report.cs: (Report.Warning): Renamed to Warning_T because of
4039 parameter collision.
4041 2004-05-05 Raja R Harinath <rharinath@novell.com>
4043 * expression.cs (MemberAccess.ResolveMemberAccess):
4044 Exit with non-zero status after Report.Error.
4045 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
4047 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
4049 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
4051 * support.cs: Don't hang when the file is empty.
4053 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
4055 * support.cs: In SeekableStreamReader, compute the preamble size of the
4056 underlying stream. Position changes should take into account that initial
4059 2004-05-03 Todd Berman <tberman@sevenl.net>
4061 * driver.cs: remove unused GetSysVersion function.
4063 2004-05-03 Todd Berman <tberman@sevenl.net>
4065 * driver.cs: Remove the hack from saturday, as well as the hack
4066 from jackson (LoadAssemblyFromGac), also adds the CWD to the
4067 link_paths to get that bit proper.
4069 2004-05-01 Todd Berman <tberman@sevenl.net>
4071 * driver.cs: Try a LoadFrom before a Load, this checks the current
4072 path. This is currently a bug in mono that is be fixed, however, this
4073 provides a workaround for now. This will be removed when the bug
4076 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
4078 * CryptoConvert.cs: Updated to latest version. Fix issue with
4079 incomplete key pairs (#57941).
4081 2004-05-01 Todd Berman <tberman@sevenl.net>
4083 * driver.cs: Remove '.' from path_chars, now System.* loads properly
4086 2004-04-30 Jackson Harper <jackson@ximian.com>
4088 * codegen.cs: Open keys readonly.
4090 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
4092 * typemanager.cs: don't report cyclic struct layout when a struct
4093 contains 2 or more fields of the same type. Failed for Pango.AttrShape
4094 which has 2 Pango.Rectangle fields.
4096 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
4098 * expression.cs: Handle IntPtr comparisons with IL code
4099 rather than a method call.
4101 2004-04-29 Martin Baulig <martin@ximian.com>
4103 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
4104 the list of PropertyInfo's in class hierarchy and find the
4105 accessor. Fixes #56013.
4107 2004-04-29 Martin Baulig <martin@ximian.com>
4109 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
4111 2004-04-29 Martin Baulig <martin@ximian.com>
4113 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
4115 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
4117 2004-04-29 Martin Baulig <martin@ximian.com>
4119 * class.cs (ConstructorInitializer.Resolve): Check whether the
4120 parent .ctor is accessible. Fixes #52146.
4122 2004-04-29 Martin Baulig <martin@ximian.com>
4124 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
4126 * statement.cs (Using.EmitLocalVariableDecls): Use
4127 TypeManager.idisposable_type, not typeof (IDisposable).
4128 (Foreach.EmitCollectionForeach): Added support for valuetypes.
4130 2004-04-29 Martin Baulig <martin@ximian.com>
4132 * class.cs (Event.Define): Don't emit the field and don't set
4133 RTSpecialName and SpecialName for events on interfaces. Fixes
4136 2004-04-29 Raja R Harinath <rharinath@novell.com>
4138 Refactor Attribute.ApplyAttributes.
4139 * attribute.cs (Attributable): New base class for objects that can
4140 have Attributes applied on them.
4141 (Attribute): Make AttributeUsage fields public.
4142 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
4143 (Attribute.IsInternalCall): New property.
4144 (Attribute.UsageAttr): Convert to a public read-only property.
4145 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
4146 (Attribute.ResolveType, Attribute.Resolve)
4147 (Attribute.ScanForIndexerName): Update to reflect changes.
4148 (Attribute.CheckAttributeTarget): Re-format.
4149 (Attribute.ApplyAttributes): Refactor, to various
4150 Attributable.ApplyAttributeBuilder methods.
4151 * decl.cs (MemberCore): Make Attributable.
4152 * class.cs (Accessor): Make Attributable.
4153 (MethodData.ApplyAttributes): Use proper attribute types, not
4155 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
4156 (TypeContainer.ApplyAttributeBuilder)
4157 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
4158 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
4159 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
4160 (Operator.ApplyAttributeBuilder): New factored-out methods.
4161 * const.cs (Const.ApplyAttributeBuilder): Likewise.
4162 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
4163 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
4164 * parameter.cs (ParameterBase): New Attributable base class
4165 that can also represent Return types.
4166 (Parameter): Update to the changes.
4168 2004-04-29 Jackson Harper <jackson@ximian.com>
4170 * driver.cs: Prefer the corlib system version when looking for
4171 assemblies in the GAC. This is still a hack, but its a better hack
4174 2004-04-29 Marek Safar <marek.safar@seznam.cz>
4176 * decl.cs, enum.cs: Improved error 3005 reporting.
4178 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
4179 (related_symbols): New private member for list of symbols
4180 related to reported error/warning.
4182 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
4184 2004-04-29 Martin Baulig <martin@ximian.com>
4186 * ecore.cs (Expression.Constantify): If we're an enum and
4187 TypeManager.TypeToCoreType() doesn't give us another type, use
4188 t.UnderlyingSystemType. Fixes #56178.
4190 2004-04-29 Martin Baulig <martin@ximian.com>
4192 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
4193 interfaces and for each interface, only add members directly
4194 declared in that interface. Fixes #53255.
4196 2004-04-28 Martin Baulig <martin@ximian.com>
4198 * expression.cs (ConditionalLogicalOperator): Use a temporary
4199 variable for `left' to avoid that we evaluate it more than once;
4202 2004-04-28 Martin Baulig <martin@ximian.com>
4204 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
4207 2004-04-28 Martin Baulig <martin@ximian.com>
4209 * statement.cs (LocalInfo.Resolve): Check whether the type is not
4212 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
4213 whether the type is not void (CS1547).
4215 2004-04-28 Martin Baulig <martin@ximian.com>
4217 * expression.cs (Unary.DoResolveLValue): Override this and report
4218 CS0131 for anything but Operator.Indirection.
4220 2004-04-28 Martin Baulig <martin@ximian.com>
4222 Committing a patch from Ben Maurer; see bug #50820.
4224 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
4227 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
4230 2004-04-28 Martin Baulig <martin@ximian.com>
4232 Committing a patch from Ben Maurer; see bug #50820.
4234 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
4237 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
4240 2004-04-28 Martin Baulig <martin@ximian.com>
4242 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
4243 (Block.AddLabel): Call DoLookupLabel() to only search in the
4246 2004-04-28 Martin Baulig <martin@ximian.com>
4248 * cfold.cs (ConstantFold.BinaryFold): Added special support for
4249 comparing StringConstants and NullLiterals in Equality and Inequality.
4251 2004-04-28 Jackson Harper <jackson@ximian.com>
4253 * driver.cs: Attempt to load referenced assemblies from the
4254 GAC. This is the quick and dirty version of this method that
4255 doesnt take into account versions and just takes the first
4256 canidate found. Will be good enough for now as we will not have more
4257 then one version installed into the GAC until I update this method.
4259 2004-04-28 Martin Baulig <martin@ximian.com>
4261 * typemanager.cs (TypeManager.CheckStructCycles): New public
4262 static method to check for cycles in the struct layout.
4264 * rootcontext.cs (RootContext.PopulateTypes): Call
4265 TypeManager.CheckStructCycles() for each TypeContainer.
4266 [Note: We only need to visit each type once.]
4268 2004-04-28 Martin Baulig <martin@ximian.com>
4270 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
4272 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
4273 success and added `out object value'. Use a `bool resolved' field
4274 to check whether we've already been called rather than
4275 `ConstantValue != null' since this breaks for NullLiterals.
4277 2004-04-28 Raja R Harinath <rharinath@novell.com>
4279 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
4280 setting of this flag, since the 'set' method may be non-public.
4282 2004-04-28 Raja R Harinath <rharinath@novell.com>
4284 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
4285 check on current_vector.Block.
4287 2004-04-27 Martin Baulig <martin@ximian.com>
4289 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
4290 a field initializer. Fixes #56459.
4292 2004-04-27 Martin Baulig <martin@ximian.com>
4294 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
4295 we're not attempting to use an indexer. Fixes #52154.
4297 2004-04-27 Martin Baulig <martin@ximian.com>
4299 * statement.cs (Return): Don't create a return label if we don't
4300 need it; reverts my change from January 20th. Thanks to Ben
4303 2004-04-27 Martin Baulig <martin@ximian.com>
4305 According to the spec, `goto' can only leave a nested scope, but
4308 * statement.cs (Block.LookupLabel): Only lookup in the current
4309 block, don't recurse into parent or child blocks.
4310 (Block.AddLabel): Check in parent and child blocks, report
4311 CS0140/CS0158 if we find a duplicate.
4312 (Block): Removed this indexer for label lookups.
4313 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
4314 this already does the error reporting for us.
4317 (FlowBranching.UsageVector.Block): New public variable; may be null.
4318 (FlowBranching.CreateSibling): Added `Block' argument.
4319 (FlowBranching.LookupLabel): New public virtual method. Lookup a
4320 label for the target of a `goto' and check whether we're not
4321 leaving a `finally'.
4323 2004-04-27 Martin Baulig <martin@ximian.com>
4325 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
4326 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
4329 2004-04-27 Martin Baulig <martin@ximian.com>
4331 * statement.cs (Block.AddLabel): Also check for implicit blocks
4332 and added a CS0158 check.
4334 2004-04-27 Martin Baulig <martin@ximian.com>
4336 * flowanalysis.cs (FlowBranchingLoop): New class.
4337 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
4338 UsageVector's instead of an ArrayList.
4339 (FlowBranching.Label): Likewise.
4340 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
4341 (FlowBranching.AddBreakVector): New method.
4343 2004-04-27 Miguel de Icaza <miguel@ximian.com>
4345 * attribute.cs: Small regression fix: only convert the type if we
4346 the type is different, fixes System.Drawing build.
4348 2004-04-27 Martin Baulig <martin@ximian.com>
4350 * attribute.cs (Attribute.Resolve): If we have a constant value
4351 for a named field or property, implicity convert it to the correct
4354 2004-04-27 Raja R Harinath <rharinath@novell.com>
4356 * statement.cs (Block.Block): Implicit blocks share
4357 'child_variable_names' fields with parent blocks.
4358 (Block.AddChildVariableNames): Remove.
4359 (Block.AddVariable): Mark variable as "used by a child block" in
4360 every surrounding block.
4361 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
4362 been used in a child block, complain about violation of "Invariant
4363 meaning in blocks" rule.
4364 * cs-parser.jay (declare_local_variables): Don't use
4365 AddChildVariableNames.
4366 (foreach_statement): Don't create an implicit block: 'foreach'
4369 2004-04-23 Miguel de Icaza <miguel@ximian.com>
4371 * convert.cs (ImplicitNumericConversion): 0 is also positive when
4372 converting from 0L to ulong. Fixes 57522.
4374 2004-04-22 Marek Safar <marek.safar@seznam.cz>
4376 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
4377 derived class hides via 'new' keyword field from base class (test-242.cs).
4378 TODO: Handle this in the more general way.
4380 * class.cs (CheckBase): Ditto.
4382 2004-04-22 Marek Safar <marek.safar@seznam.cz>
4384 * decl.cs (caching_flags): New member for storing cached values
4386 (MemberCore.Flags): New enum where bit flags for caching_flags
4388 (MemberCore.cls_compliance): Moved to caching_flags.
4389 (DeclSpace.Created): Moved to caching_flags.
4391 * class.cs: Use caching_flags instead of DeclSpace.Created
4393 2004-04-21 Miguel de Icaza <miguel@ximian.com>
4395 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
4396 if we are only a derived class, not a nested class.
4398 * typemanager.cs: Same as above, but do this at the MemberLookup
4399 level (used by field and methods, properties are handled in
4400 PropertyExpr). Allow for the qualified access if we are a nested
4403 2004-04-21 Marek Safar <marek.safar@seznam.cz>
4405 * class.cs: Refactoring.
4406 (IMethodData): New inteface; Holds links to parent members
4407 to avoid member duplication (reduced memory allocation).
4408 (Method): Implemented IMethodData interface.
4409 (PropertyBase): New inner classes for get/set methods.
4410 (PropertyBase.PropertyMethod): Implemented IMethodData interface
4411 (Event): New inner classes for add/remove methods.
4412 (Event.DelegateMethod): Implemented IMethodData interface.
4414 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
4415 EmitContext (related to class.cs refactoring).
4417 2004-04-21 Raja R Harinath <rharinath@novell.com>
4419 * delegate.cs (Delegate.VerifyApplicability): If the number of
4420 arguments are the same as the number of parameters, first try to
4421 verify applicability ignoring any 'params' modifier on the last
4425 2004-04-08 Martin Baulig <martin@ximian.com>
4427 Merged latest changes into gmcs. Please keep this comment in
4428 here, it makes it easier for me to see what changed in MCS since
4429 the last time I merged.
4431 2004-04-16 Raja R Harinath <rharinath@novell.com>
4433 * class.cs (TypeContainer.AddIndexer): Use
4434 'ExplicitInterfaceName' to determine if interface name was
4435 explicitly specified. 'InterfaceType' is not initialized at this time.
4436 (TypeContainer.DefineIndexers): Remove use of temporary list. The
4437 Indexers array is already in the required order. Initialize
4438 'IndexerName' only if there are normal indexers.
4439 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
4440 (TypeContainer.Emit): Emit DefaultMember attribute only if
4441 IndexerName is initialized.
4444 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
4446 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
4449 2004-04-15 Raja R Harinath <rharinath@novell.com>
4451 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
4455 * attribute.cs (Attribute.Resolve): Check for duplicate named
4459 2004-04-15 Miguel de Icaza <miguel@ximian.com>
4461 * iterators.cs (MarkYield): track whether we are in an exception,
4462 and generate code accordingly. Use a temporary value to store the
4463 result for our state.
4465 I had ignored a bit the interaction of try/catch with iterators
4466 since their behavior was not entirely obvious, but now it is
4467 possible to verify that our behavior is the same as MS .NET 2.0
4471 2004-04-14 Miguel de Icaza <miguel@ximian.com>
4473 * iterators.cs: Avoid creating temporaries if there is no work to
4476 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
4477 Enumerations, use TypeManager.EnumToUnderlying and call
4480 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
4483 (This.Emit): Use EmitContext.EmitThis to emit our
4486 (This.EmitAssign): Ditto.
4488 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
4489 codepaths, we will move all the functionality into
4492 (FieldExpr.EmitAssign): Ditto.
4494 This fixes several hidden bugs that I uncovered while doing a code
4495 review of this today.
4497 * codegen.cs (EmitThis): reworked so the semantics are more clear
4498 and also support value types "this" instances.
4500 * iterators.cs: Changed so that for iterators in value types, we
4501 do not pass the value type as a parameter.
4503 Initialization of the enumerator helpers is now done in the caller
4504 instead of passing the parameters to the constructors and having
4505 the constructor set the fields.
4507 The fields have now `assembly' visibility instead of private.
4509 2004-04-11 Miguel de Icaza <miguel@ximian.com>
4511 * expression.cs (Argument.Resolve): Check if fields passed as ref
4512 or out are contained in a MarshalByRefObject.
4514 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
4515 another compiler type.
4517 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
4519 * class.cs (Indexer.Define): use the new name checking method.
4520 Also, return false on an error.
4521 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
4522 (is_identifier_[start/part]_character): make static.
4524 2004-04-10 Miguel de Icaza <miguel@ximian.com>
4526 * expression.cs (Binary.ResolveOperator): Do no append strings
4527 twice: since we can be invoked more than once (array evaluation)
4528 on the same concatenation, take care of this here. Based on a fix
4529 from Ben (bug #56454)
4531 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
4533 * codegen.cs: Fix another case where CS1548 must be reported (when
4534 delay-sign isn't specified and no private is available #56564). Fix
4535 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
4536 error when MCS is used on the MS runtime and we need to delay-sign
4537 (which seems unsupported by AssemblyBuilder - see #56621).
4539 2004-04-08 Marek Safar <marek.safar@seznam.cz>
4541 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
4542 (TypeManager.ComputeNamespaces): Faster implementation for
4545 * compiler.csproj: Updated AssemblyName to mcs.
4547 2004-05-11 Jackson Harper <jackson@ximian.com>
4549 * Makefile: Preserve MONO_PATH
4551 2004-05-11 Jackson Harper <jackson@ximian.com>
4553 * Makefile: Use mono and mcs to build gmcs
4555 2004-05-03 Miguel de Icaza <miguel@ximian.com>
4557 * codegen.cs: Add patch from Robert Shade
4558 <rshade@dvsconsulting.com>, use FileAccess.Read on the keyfile, to
4561 2004-05-02 Sebastien Pouliot <sebastien@ximian.com>
4563 * CryptoConvert.cs: Updated to latest version. Fix issue with
4564 incomplete key pairs (#57941).
4566 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
4568 * codegen.cs: Fix another case where CS1548 must be reported (when
4569 delay-sign isn't specified and no private is available #56564). Fix
4570 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
4571 error when MCS is used on the MS runtime and we need to delay-sign
4572 (which seems unsupported by AssemblyBuilder - see #56621).
4574 2004-04-29 Jackson Harper <jackson@ximian.com>
4576 * Makefile: Set MONO_PATH to use the bootstrap corlib
4577 * driver.cs: Check the GAC for referenced assemblies.
4579 2004-04-29 Martin Baulig <martin@ximian.com>
4581 * Makefile (gmcs.exe): Set MONO_PATH to use `../class/lib/net_2_0'.
4583 2004-04-07 Martin Baulig <martin@ximian.com>
4585 * expression.cs (Binary.ResolveOperator): Added special case for
4586 Equality/Inequality between a type parameter and a null literal.
4588 2004-04-07 Martin Baulig <martin@ximian.com>
4590 * convert.cs: Check null literal -> type parameter conversions.
4592 2004-04-07 Martin Baulig <martin@ximian.com>
4594 * generic.cs (ConstructedType.CheckConstraints): Enforce the
4595 `class' and `struct' constraints.
4597 2004-04-07 Martin Baulig <martin@ximian.com>
4599 * generic.cs (SpecialConstraint): New public enum.
4600 (Constraints.Resolve): Added support for the `class' and `struct'
4603 * cs-parser.jay (type_parameter_constraint): Added support for the
4604 `class' and `struct' constraints.
4606 2004-04-07 Martin Baulig <martin@ximian.com>
4608 * support.cs (GenericConstraints): Replaced `Types' by
4609 `ClassConstraint' and `InterfaceConstraints'; added
4610 `HasClassConstraint'.
4612 2004-04-07 Martin Baulig <martin@ximian.com>
4615 (Constraints.InterfaceConstraints): New public property.
4616 (Constraints.Types): Make this property public
4617 (TypeParameter): Implement IMemberContainer.
4618 (TypeParameter.Define): Take a `GenericTypeParameterBuilder'
4619 instead of a TypeBuilder/MethodBuilder; pass the interface
4620 constraints to TypeManager.AddTypeParameter().
4621 (TypeParameter.DefineType): Just take an EmitContext and no
4622 TypeBuilder/MethodBuilder. Use the new public API.
4624 * typemanager.cs (TypeManager.AddTypeParameter): Added
4625 `TypeExpr[]' argument; add the interfaces to the
4626 `builder_to_ifaces' hash.
4627 (TypeManager.LookupMemberContainer): For
4628 GenericTypeParameterBuilders, get the TypeParameter from the
4629 `builder_to_type_param'.
4630 (TypeManager.FindMembers): For GenericTypeParameterBuilders, get
4631 the TypeParameter and call FindMembers on it.
4633 2004-04-07 Martin Baulig <martin@ximian.com>
4636 (MethodCore.GenericMethod): Moved this field here from Method.
4637 (MethodCore.IsDuplicateImplementation): Take the number of type
4638 parameters into account if we're a generic method.
4640 * expression.cs (Invocation.InferTypeArguments): Don't return true
4641 if `arguments' is null; we still need to check whether we actually
4642 don't need to infer anything in this case.
4643 (MemberAccess): Merged the functionality from GenericMemberAccess
4646 * generic.cs (GenericMemberAccess): Removed.
4648 2004-04-05 Martin Baulig <martin@ximian.com>
4650 * decl.cs (MemberCore): For generic classes, interfaces and
4651 structs, `Name' now includes the number of type parameters
4653 (DeclSpace.FindType): Removed the `num_type_args' argument; we now
4654 encode the number of type arguments in the type name.
4656 * expression.cs (Expression.MemberLookup): Removed the
4657 `num_type_args' argument; we now encode the number of type
4658 arguments in the type name.
4660 * ecore.cs (SimpleName): Encode the number of type arguments in
4661 the type name itself.
4663 * generic.cs (ConstructedType): Likewise.
4665 * tree.cs (Tree.RecordDecl): Take a `string' instead of a
4666 `MemberName'; we now include the number of type parameters in the
4669 * typemanager.cs (TypeManager.CheckGeneric): Removed.
4670 (TypeManager.MemberLookup): Removed the
4671 `num_type_args' argument; we now encode the number of type
4672 arguments in the type name.
4674 2004-04-03 Martin Baulig <martin@ximian.com>
4676 * decl.cs (MemberCore.ctor): Take a MemberName instead of a sting.
4677 (MemberCore.MemberName): Moved here from MemberBase.
4678 (DeclSpace.SetParameterInfo): Just take the constraints as an
4679 ArrayList; we already have the type parameters in our
4680 `MemberName'; also do the CS0080 reporting here.
4682 * cs-parser.jay (struct_declaration): Use `member_name' instead of
4683 `IDENTIFIER opt_type_parameter_list'; when constructing our
4684 `MemberName', it'll already include our type parameters.
4685 (class_declaration, interface_declaration): Likewise.
4686 (delegate_declaration): Likewise.
4687 (MakeName): Take a MemberName and return a MemberName.
4688 The following two changes are required to avoid shift/reduce conflicts:
4689 (member_name): Don't include a TypeName anymore; ie. this is now
4690 just 'IDENTIFIER opt_type_parameter_list'.
4691 (property_declaration, event_declaration): Use a
4692 `namespace_or_type_name' instead of a `member_name'.
4694 2004-04-03 Martin Baulig <martin@ximian.com>
4696 * decl.cs (MemberName): Renamed to `TypeName' and created a new
4698 (TypeName): Formerly known as MemberName.
4700 * namespace.cs (NamespaceEntry.UsingAlias): Take a `TypeName'
4701 instead of a `MemberName'.
4703 * cs-parser.jay (namespace_or_type_name): Create a TypeName.
4704 (member_name): New rule; create a MemberName.
4706 2004-04-02 Martin Baulig <martin@ximian.com>
4708 * namespace.cs (NamespaceEntry.VerifyUsing): Added error checking
4709 (CS0305 and CS0308).
4711 2004-04-02 Martin Baulig <martin@ximian.com>
4713 * generic.cs (GenericMemberAccess.ResolveAsTypeStep): Added
4714 support for nested types.
4716 2004-04-02 Martin Baulig <martin@ximian.com>
4718 * ecore.cs (IAlias): New public interface.
4719 (TypeExpr, TypeExpression): Implement IAlias.
4720 (TypeAliasExpression): New public class.
4722 * namespace.cs (Namespace): Implement IAlias.
4723 (Namespace.Lookup): Return an IAlias instead on an object.
4724 (Namespace.DefineName): Take an IAlias instead of an object.
4725 (NamespaceEntry.AliasEntry.Resolve): Return an IAlias instead of
4727 (NamespaceEntry.UsingAlias): Take a Membername instead of an
4729 (NamespaceEntry.LookupAlias): Return an IAlias instead on an
4731 (NamespaceEntry.Lookup): Likewise.
4733 * rootcontext.cs (RootContext.LookupType): Return a TypeExpr
4736 * decl.cs (DeclSpace): Implement IAlias.
4737 (DeclSpace.LookupAlias): Return an IAlias instead of a string.
4739 * generic.cs (ConstructedType): Improved error checking.
4741 2004-04-02 Martin Baulig <martin@ximian.com>
4743 * convert.cs: Added type parameter conversions.
4746 (UnboxCast.Emit): Emit an `unbox.any' for type params.
4747 (ClassCast.Emit): If the source type is a type parameter, box it.
4748 If the target type is a type parameter, emit an `unbox.any'
4749 instead of a `classcast'.1
4751 2004-04-01 Martin Baulig <martin@ximian.com>
4753 * cs-tokenizer.cs (parse_less_than): Allow Token.DOT.
4755 2004-04-01 Martin Baulig <martin@ximian.com>
4757 * generic.cs (ConstructedType.CheckConstraints): Use
4758 Convert.ImplicitStandardConversionExists(); user-defined implicit
4759 conversions are not allowed according to the spec.
4761 2004-03-30 Martin Baulig <martin@ximian.com>
4763 * expression.cs (New): Added support for type parameters.
4766 (TypeManager.activator_type): New public static field.
4767 (TypeManager.activator_create_instance): Likewise.
4769 2004-03-30 Martin Baulig <martin@ximian.com>
4771 * typemanager.cs (TypeManager.HasConstructorConstraint): New
4774 2004-03-30 Martin Baulig <martin@ximian.com>
4776 * generic.cs (ConstructedType.CheckConstraints): Actually follow
4777 the spec here: the argument type must be convertible to the
4780 2004-03-30 Martin Baulig <martin@ximian.com>
4783 (TypeParameter.Define, TypeParameter.DefineMethod): Call
4784 TypeManager.AddTypeParameter().
4785 (ConstructedType.CheckConstraints): Re-enable this and actually
4786 check whether we have a constructor constraint.
4789 (TypeManager.builder_to_type_param): New static field.
4790 (TypeManager.AddTypeParameter): New static method.
4791 (TypeManager.LookupTypeParameter): New public method.
4793 2004-03-30 Martin Baulig <martin@ximian.com>
4795 * generic.cs (TypeParameter.DefineType): Return a boolean and use
4796 the new API to actually define the constructor constraint.
4799 (TypeManager.new_constraint_attr_type): New static field.
4800 (TypeManager.InitCoreTypes): Initialize it.
4802 2004-03-30 Martin Baulig <martin@ximian.com>
4804 * generic.cs (Constraints): Completed error checking, use correct
4807 2004-03-29 Martin Baulig <martin@ximian.com>
4809 * delegate.cs (Delegate.VerifyMethod): Infer type arguments.
4811 * expression.cs (Invocation.InferTypeArguments): Added overloaded
4812 public version which takes a `ParameterData pd' instead of an
4815 2004-03-29 Martin Baulig <martin@ximian.com>
4817 * typemanager.cs (TypeManager.IsGenericMethod): Take a MethodBase,
4820 2004-03-29 Martin Baulig <martin@ximian.com>
4822 * expression.cs (Argument.ResolveMethodGroup): If we're a
4823 ConstructedType, call GetMemberAccess() on it.
4825 2004-03-29 Martin Baulig <martin@ximian.com>
4827 * class.cs (MethodBase.CheckGenericOverride): New abstract method.
4828 (MethodCore.CheckGenericOverride): When overriding a generic
4829 method, check whether the constraints match.
4831 * support.cs (GenericConstraints): New public interface.
4832 (ParameterData.GenericConstraints): New public method.
4834 * parameter.cs (Parameter.Resolve): Check whether we're a generic
4835 method parameter and compute our constraints if appropriate.
4836 (Parameter.GenericConstraints): New public property.
4838 * generic.cs (Constraints): Implement GenericConstraints.
4840 2004-03-29 Martin Baulig <martin@ximian.com>
4842 * decl.cs (MemberCache.FindMemberToOverride): Use
4843 `paramTypes [j].Equals (cmpAttrs [j])' instead of `=='.
4845 2004-03-29 Martin Baulig <martin@ximian.com>
4847 * generic.cs (GenericMethod.Define): Resolve our type parameters.
4849 2004-03-29 Martin Baulig <martin@ximian.com>
4851 * cs-parser.jay: Report CS0080 instead of -200 ("Constraints are
4852 not allowed on non-generic declarations").
4854 2004-03-29 Martin Baulig <martin@ximian.com>
4856 * expression.cs (Invocation.InferTypeArguments): Added overloaded
4857 public version of this method.
4859 * class.cs (MethodCore.IsDuplicateImplementation): Use
4860 Invocation.InferTypeArguments() to check this.
4862 2004-03-29 Martin Baulig <martin@ximian.com>
4864 * convert.cs: Use TypeManager.IsDelegateType() instead of
4865 comparing types correctly.
4867 2004-03-29 Martin Baulig <martin@ximian.com>
4869 * convert.cs: Use TypeManager.IsSubclassOf() instead of comparing
4870 types directly to make it work for generic instances.
4872 * typemanager.cs (TypeManager.IsSubclassOf): New static method.
4874 2004-03-29 Martin Baulig <martin@ximian.com>
4876 * typemanager.cs (TypeManager.MayBecomeEqualGenericTypes): Added
4879 2004-03-24 Martin Baulig <martin@ximian.com>
4881 * decl.cs (DeclSpace.FindType): Also use
4882 TypeManager.CheckGeneric() for types from the using clauses.
4884 2004-03-23 Martin Baulig <martin@ximian.com>
4886 * expression.cs (Invocation.OverloadResolve): Added `bool
4887 may_fail' argument and use it instead of the Location.IsNull() hack.
4889 2004-03-23 Martin Baulig <martin@ximian.com>
4891 * expression.cs (Invocation.InferType): Use correct type inference
4894 2004-03-23 Martin Baulig <martin@ximian.com>
4896 * ecore.cs (MethodGroupExpr.Name): Use
4897 TypeManager.CSharpSignature() instead of just the name.
4899 * expression.cs (Invocation.OverloadResolve): Provide better error
4901 (Invocation.DoResolve): OverloadResolve() never returns null
4902 without reporting an error, so removed the error -6 reporting here.
4904 2004-03-23 Martin Baulig <martin@ximian.com>
4906 * typemanager.cs (TypeManager.GetMethodFlags): Fixed the FIXME for
4909 * cs-parser.jay (delegate_declaration): Support generic delegates.
4911 * delegate.cs: Support generic delegates.
4913 2004-03-22 Martin Baulig <martin@ximian.com>
4915 * expression.cs (Invocation.InferParamsTypeArguments): New static
4916 method; does type inference for params arguments.
4918 2004-03-21 Martin Baulig <martin@ximian.com>
4920 * typemanager.cs (TypeManager.IsGenericMethod): New public static
4921 method; checks whether a method is a generic method.
4923 * expression.cs (Invocation.InferTypeArguments): New static method;
4924 infer type arguments for generic method invocation.
4926 * ecore.cs (MethodGroupExpr.HasTypeArguments): New public
4927 property; we set this to true if we're resolving a generic method
4928 invocation and the user specified type arguments, ie. we're not
4929 doing type inference.
4931 2004-03-20 Martin Baulig <martin@ximian.com>
4933 * class.cs (MethodData.DeclaringType): New public property.
4934 (MethodData.Define): Set DeclaringType here.
4935 (Operator.Define): Use OperatorMethod.MethodData.DeclaringType
4936 instead of OperatorMethodBuilder.DeclaringType.
4938 2004-03-20 Martin Baulig <martin@ximian.com>
4940 * cs-tokenizer.cs (xtoken): Return a special
4941 Token.DEFAULT_OPEN_PARENS for "`default' followed by open parens".
4943 * cs-parser.jay (default_value_expression): Switch to the new
4946 2004-03-19 Martin Baulig <martin@ximian.com>
4948 * decl.cs (MemberName): New class. We use this to "construct"
4949 namespace_or_type_name's.
4951 * generics.cs (TypeArguments.GetDeclarations): New public method;
4952 returns the type arguments as a string[] and reports a CS0081 if
4953 one of them is not an identifier.
4955 * class.cs (MemberBase): The .ctor now takes the name as a
4956 MemberName instead of a string.
4957 (MemberBase.ExplicitInterfaceName): Changed type from string to
4959 (MemberBase.DoDefine): If we're an explicit implementation, the
4960 InterfaceType may be a generic instance.
4962 * cs-parser.jay (namespace_or_type_name): Return a MemberName.
4963 (namespace_name): Call MemberName.GetName () to transform the
4964 MemberName into a string and ensure we don't have any type
4966 (type_name): Call MemberName.GetTypeExpression() to transfrom the
4967 MemberName into an expression.
4968 (method_header): Use namespace_or_type_name instead of member_name.
4970 2004-04-07 Miguel de Icaza <miguel@ximian.com>
4972 * rootcontext.cs: Add new types to the boot resolution.
4974 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
4975 MulticastDelegate is not allowed.
4977 * typemanager.cs: Add new types to lookup: System.TypedReference
4980 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
4981 check for TypedReference or ArgIterator, they are not allowed.
4983 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
4984 makes us properly catch 1510 in some conditions (see bug 56016 for
4987 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
4989 * CryptoConvert.cs: update from corlib version
4992 2004-04-05 Miguel de Icaza <miguel@ximian.com>
4994 * class.cs (Indexer.Define): Check indexername declaration
4996 2004-04-05 Marek Safar <marek.safar@seznam.cz>
4998 * attribute.cs (IsClsCompliant): Fixed problem with handling
4999 all three states (compliant, not-compliant, undetected).
5001 2004-03-30 Marek Safar <marek.safar@seznam.cz>
5003 * attribute.cs (Attribute): Location is now public.
5004 (Resolve): Store resolved arguments (pos_values) in attribute class.
5005 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
5006 (GetClsCompliantAttributeValue): New method that gets
5007 CLSCompliantAttribute value.
5008 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
5009 if exists else null.
5010 (AttributeTester): New class for CLS-Compliant verification routines.
5012 * class.cs (Emit): Add CLS-Compliant verification.
5013 (Method.GetSignatureForError): Implemented.
5014 (Constructor.GetSignatureForError): Implemented
5015 (Constructor.HasCompliantArgs): Returns if constructor has
5016 CLS-Compliant arguments.
5017 (Constructor.Emit): Override.
5018 (Construcor.IsIdentifierClsCompliant): New method; For constructors
5019 is needed to test only parameters.
5020 (FieldBase.GetSignatureForError): Implemented.
5021 (TypeContainer): New member for storing base interfaces.
5022 (TypeContainer.FindMembers): Search in base interfaces too.
5024 * codegen.cs (GetClsComplianceAttribute): New method that gets
5025 assembly or module CLSCompliantAttribute value.
5026 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
5028 (ModuleClass.Emit): Add error 3012 test.
5030 * const.cs (Emit): Override and call base for CLS-Compliant tests.
5032 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
5033 state for all decl types.
5034 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
5035 if CLS-Compliant tests are required.
5036 (IsClsCompliaceRequired): New method. Analyze whether code
5037 must be CLS-Compliant.
5038 (IsExposedFromAssembly): New method. Returns true when MemberCore
5039 is exposed from assembly.
5040 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
5041 value or gets cached value.
5042 (HasClsCompliantAttribute): New method. Returns true if MemberCore
5043 is explicitly marked with CLSCompliantAttribute.
5044 (IsIdentifierClsCompliant): New abstract method. This method is
5045 used to testing error 3005.
5046 (IsIdentifierAndParamClsCompliant): New method. Common helper method
5047 for identifier and parameters CLS-Compliant testing.
5048 (VerifyClsCompliance): New method. The main virtual method for
5049 CLS-Compliant verifications.
5050 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
5051 null. I don't know why is null (too many public members !).
5052 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
5053 and get value of first CLSCompliantAttribute that found.
5055 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
5056 (VerifyClsCompliance): Override and add extra tests.
5058 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
5059 clscheck- disable CLS-Compliant verification event if assembly is has
5060 CLSCompliantAttribute(true).
5062 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
5063 ApllyAttribute is now called in emit section as in the other cases.
5064 Possible future Emit integration.
5065 (IsIdentifierClsCompliant): New override.
5066 (VerifyClsCompliance): New override.
5067 (GetEnumeratorName): Returns full enum name.
5069 * parameter.cs (GetSignatureForError): Implemented.
5071 * report.cs (WarningData): New struct for Warning message information.
5072 (LocationOfPreviousError): New method.
5073 (Warning): New method. Reports warning based on the warning table.
5074 (Error_T): New method. Reports error based on the error table.
5076 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
5077 verifications are done here.
5079 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
5081 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
5082 CLSCompliantAttribute.
5083 (all_imported_types): New member holds all imported types from other
5085 (LoadAllImportedTypes): New method fills static table with exported types
5086 from all referenced assemblies.
5087 (Modules): New property returns all assembly modules.
5089 2004-03-30 Miguel de Icaza <miguel@ximian.com>
5091 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
5092 throwing a parser error.
5094 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
5095 which removes the hardcoded get_/set_ prefixes for properties, as
5096 IL allows for the properties to be named something else.
5100 * expression.cs: Do not override operand before we know if it is
5103 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
5105 * typemanager.cs: support for pinned variables.
5107 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
5109 * decl.cs, typemanager.cs: Avoid using an arraylist
5110 as a buffer if there is only one result set.
5112 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
5114 * expression.cs: Make sure you cant call a static method
5115 with an instance expression, bug #56174.
5117 2004-03-29 Miguel de Icaza <miguel@ximian.com>
5119 * class.cs (IsDuplicateImplementation): Improve error reporting to
5120 flag 663 (method only differs in parameter modifier).
5122 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
5123 in preprocessor directives.
5125 * location.cs (LookupFile): Allow for the empty path.
5127 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
5128 better approach for some of that patch, but its failing with the
5129 CharSet enumeration. For now try/catch will do.
5131 * typemanager.cs: Do not crash if a struct does not have fields.
5134 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
5136 * expression.cs: cs0213, cant fix a fixed expression.
5139 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
5141 * cs-parser.jay: detect invalid embeded statements gracefully.
5144 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
5146 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
5149 the invocation type may not be a subclass of the tye of the item/
5150 The type of the item must be a subclass of the invocation item.
5155 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
5157 * attribute.cs: Added methods to get a string and a bool from an
5158 attribute. Required to information from AssemblyKeyFileAttribute,
5159 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
5160 * codegen.cs: Modified AssemblyName creation to include support for
5161 strongnames. Catch additional exceptions to report them as CS1548.
5162 * compiler.csproj: Updated include CryptoConvert.cs.
5163 * compiler.csproj.user: Removed file - user specific configuration.
5164 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
5165 Mono.Security assembly. The original class is maintained and tested in
5166 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
5167 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
5168 like CSC 8.0 (C# v2) supports.
5169 * Makefile: Added CryptoConvert.cs to mcs sources.
5170 * rootcontext.cs: Added new options for strongnames.
5172 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
5174 * driver.cs: For --expect-error, report error code `2'
5175 if the program compiled with no errors, error code `1' if
5176 it compiled with an error other than the one expected.
5178 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
5180 * compiler.csproj: Updated for Visual Studio .NET 2003.
5181 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
5182 * compiler.sln: Updated for Visual Studio .NET 2003.
5184 2004-03-24 Ravi Pratap M <ravi@ximian.com>
5186 * expression.cs: Fix bug #47234. We basically need to apply the
5187 rule that we prefer the conversion of null to a reference type
5188 when faced with a conversion to 'object' (csc behaviour).
5190 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
5192 * statement.cs: Shorter form for foreach, eliminates
5193 a local variable. r=Martin.
5195 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
5197 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
5198 checks if we can use brtrue/brfalse to test for 0.
5199 * expression.cs: use the above in the test for using brtrue/brfalse.
5202 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
5204 * expression.cs: Rewrite string concat stuff. Benefits:
5206 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
5207 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
5208 rather than a concat chain.
5210 * typemanager.cs: Add lookups for more concat overloads.
5212 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
5214 * expression.cs: Emit shorter il code for array init.
5231 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
5233 * statement.cs: Before, two switch blocks would be merged if the
5234 total size of the blocks (end_item - begin_item + 1) was less than
5235 two times the combined sizes of the blocks.
5237 Now, it will only merge if after the merge at least half of the
5242 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
5244 * class.cs : csc build fix for GetMethods(). See bug #52503.
5246 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
5248 * expression.cs: Make sure fp comparisons work with NaN.
5249 This fixes bug #54303. Mig approved this patch a long
5250 time ago, but we were not able to test b/c the runtime
5253 2004-03-19 Miguel de Icaza <miguel@ximian.com>
5255 * ecore.cs (TypExpr.GetHashCode): implement this overload.
5257 2004-03-19 Martin Baulig <martin@ximian.com>
5259 * class.cs (MemberCore.IsDuplicateImplementation): Check whether
5260 two overloads may unify for some type parameter substitutions and
5261 report a CS0408 if appropriate.
5263 2004-03-19 Martin Baulig <martin@ximian.com>
5265 * class.cs (MemberCore.IsDuplicateImplementation): Report the
5266 error here and not in our caller.
5268 2004-03-19 Martin Baulig <martin@ximian.com>
5270 * interface.cs: Completely killed this file.
5271 (Interface): We're now a TypeContainer and live in class.cs.
5273 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
5274 argument; we're now also called for interfaces.
5275 (TypeContainer.DefineMembers): Allow this method being called
5277 (TypeContainer.GetMethods): New public method; formerly known as
5278 Interface.GetMethod(). This is used by PendingImplementation.
5279 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
5280 it's now private and non-static.
5281 (Interface): Moved this here; it's now implemented similar to
5283 (Method, Property, Event, Indexer): Added `bool is_interface'
5284 argument to their .ctor's.
5285 (MemberBase.IsInterface): New public field.
5287 * cs-parser.jay: Create normal Method, Property, Event, Indexer
5288 instances instead of InterfaceMethod, InterfaceProperty, etc.
5289 (opt_interface_base): Removed; we now use `opt_class_base' instead.
5290 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
5292 2004-03-19 Martin Baulig <martin@ximian.com>
5294 * class.cs (MethodCore.IsDuplicateImplementation): New private
5295 method which does the CS0111 checking.
5296 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
5297 Use IsDuplicateImplementation().
5299 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
5301 * decl.cs (FindMemberToOverride): New method to find the correct
5302 method or property to override in the base class.
5304 - Make Method/Property use the above method to find the
5305 version in the base class.
5306 - Remove the InheritableMemberSignatureCompare as it is now
5309 This patch makes large code bases much faster to compile, as it is
5310 O(n) rather than O(n^2) to do this validation.
5312 Also, it fixes bug 52458 which is that nested classes are not
5313 taken into account when finding the base class member.
5315 Reviewed/Approved by Martin.
5317 2004-03-17 Martin Baulig <martin@ximian.com>
5319 * expression.cs (MemberAccess.DoResolve): Take the parent's number
5320 of type arguments into account; use the `real_num_type_args'
5321 approach like in DoResolveAsTypeStep().
5323 * generic.cs (GenericMemberAccess.DoResolve): Make this work for
5326 2004-03-17 Marek Safar <marek.safar@seznam.cz>
5328 * interface.cs: In all interface classes removed redundant
5329 member initialization.
5331 2004-03-16 Martin Baulig <martin@ximian.com>
5333 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
5335 2004-03-15 Miguel de Icaza <miguel@ximian.com>
5337 * decl.cs (DefineTypeAndParents): New helper method to define a
5338 type's containers before the type itself is defined; This is a
5339 bug exposed by the recent changes to Windows.Forms when an
5340 implemented interface was defined inside a class that had not been
5343 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
5345 (Check): Loop correctly to report errors modifiers
5346 (UNSAFE was not in the loop, since it was the same as TOP).
5348 * interface.cs: Every interface member now takes a ModFlags,
5349 instead of a "is_new" bool, which we set on the base MemberCore.
5351 Every place where we called "UnsafeOk" in the interface, now we
5352 call the proper member (InterfaceMethod.UnsafeOK) instead to get
5353 the unsafe settings from the member declaration instead of the
5354 container interface.
5356 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
5358 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
5359 `set_indexer_name' to the pending bits (one per type).
5361 We fixed a bug today that was picking the wrong method to
5362 override, since for properties the existing InterfaceMethod code
5363 basically ignored the method name. Now we make sure that the
5364 method name is one of the valid indexer names.
5366 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
5368 * support.cs (SeekableStreamReader): Keep track of stream byte
5369 positions and don't mix them with character offsets to the buffer.
5371 Patch from Gustavo Giráldez
5373 2004-03-15 Marek Safar <marek.safar@seznam.cz>
5375 * interface.cs (InterfaceSetGetBase): Removed double member
5376 initialization, base class does it as well.
5378 2004-03-13 Martin Baulig <martin@ximian.com>
5380 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
5381 when compiling corlib.
5383 2004-03-13 Miguel de Icaza <miguel@ximian.com>
5385 * convert.cs (ExplicitConversion): We were reporting an error on
5386 certain conversions (object_type source to a value type, when the
5387 expression was `null') before we had a chance to pass it through
5388 the user defined conversions.
5390 * driver.cs: Replace / and \ in resource specifications to dots.
5393 * class.cs: Add check for duplicate operators. Fixes 52477
5395 2004-03-11 Miguel de Icaza <miguel@ximian.com>
5397 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
5398 that are in the middle of the statements, not only at the end.
5401 * class.cs (TypeContainer.AddField): No longer set the
5402 `HaveStaticConstructor' flag, now we call it
5403 `UserDefineStaticConstructor' to diferentiate the slightly
5404 semantic difference.
5406 The situation is that we were not adding BeforeFieldInit (from
5407 Modifiers.TypeAttr) to classes that could have it.
5408 BeforeFieldInit should be set to classes that have no static
5413 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
5415 And most importantly Zoltan's comment:
5417 http://bugzilla.ximian.com/show_bug.cgi?id=44229
5419 "I think beforefieldinit means 'it's ok to initialize the type sometime
5420 before its static fields are used', i.e. initialization does not need
5421 to be triggered by the first access to the type. Setting this flag
5422 helps the JIT to compile better code, since it can run the static
5423 constructor at JIT time, and does not need to generate code to call it
5424 (possibly lots of times) at runtime. Unfortunately, mcs does not set
5425 this flag for lots of classes like String.
5427 csc sets this flag if the type does not have an explicit static
5428 constructor. The reasoning seems to be that if there are only static
5429 initalizers for a type, and no static constructor, then the programmer
5430 does not care when this initialization happens, so beforefieldinit
5433 This bug prevents the AOT compiler from being usable, since it
5434 generates so many calls to mono_runtime_class_init that the AOT code
5435 is much slower than the JITted code. The JITted code is faster,
5436 because it does not generate these calls if the vtable is type is
5437 already initialized, which is true in the majority of cases. But the
5438 AOT compiler can't do this."
5440 2004-03-10 Miguel de Icaza <miguel@ximian.com>
5442 * class.cs (MethodData.Emit): Refactor the code so symbolic
5443 information is generated for destructors; For some reasons we
5444 were taking a code path that did not generate symbolic information
5447 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
5449 * class.cs: Create a Constructor.CheckBase method that
5450 takes care of all validation type code. The method
5451 contains some code that was moved from Define.
5453 It also includes new code that checks for duplicate ctors.
5454 This fixes bug #55148.
5456 2004-03-09 Joshua Tauberer <tauberer@for.net>
5458 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
5459 a { ... }-style array creation invokes EmitStaticInitializers
5460 which is not good for reference-type arrays. String, decimal
5461 and now null constants (NullCast) are not counted toward
5462 static initializers.
5464 2004-03-05 Martin Baulig <martin@ximian.com>
5466 * location.cs (SourceFile.HasLineDirective): New public field;
5467 specifies whether the file contains or is referenced by a "#line"
5469 (Location.DefineSymbolDocuments): Ignore source files which
5470 either contain or are referenced by a "#line" directive.
5472 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
5474 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
5475 direct access to our parent, so check the method inline there.
5477 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
5479 * expression.cs (Invocation.EmitCall): Miguel's last commit
5480 caused a regression. If you had:
5485 In Foo the implict this would be null.
5487 2004-02-27 Miguel de Icaza <miguel@ximian.com>
5489 * expression.cs (Invocation.EmitCall): If the method is not
5490 virtual, do not emit a CallVirt to it, use Call.
5492 * typemanager.cs (GetFullNameSignature): Improve the method to
5493 cope with ".ctor" and replace it with the type name.
5495 * class.cs (ConstructorInitializer.Resolve): Now the method takes
5496 as an argument the ConstructorBuilder where it is being defined,
5497 to catch the recursive constructor invocations.
5499 2004-03-16 Martin Baulig <martin@ximian.com>
5501 * expression.cs (MemberAccess.DoResolve): If `expr' resolved to a
5502 ConstructedType, call ResolveType() on it to get the type rather
5503 than just using `expr.Type'.
5505 2004-03-16 Martin Baulig <martin@ximian.com>
5507 * generics.cs (ConstructedType.GetMemberAccess): Take the
5508 EmitContext instead on the TypeExpr and use
5509 ec.TypeContainer.CurrentType/ec.ContainerType.
5511 2004-03-16 Martin Baulig <martin@ximian.com>
5513 * ecore.cs (SimpleName.DoResolveAsTypeStep): Lookup type
5514 parameters before aliases.
5516 2004-03-16 Martin Baulig <martin@ximian.com>
5518 * typemanager.cs (TypeManager.MayBecomeEqualGenericInstances):
5519 New oublic function; checks whether two generic instances may become
5520 equal under some instantiations (26.3.1).
5522 * class.cs (TypeContainer.Define): Call
5523 TypeManager.MayBecomeEqualGenericInstances() and report CS0695 on
5526 2004-03-16 Martin Baulig <martin@ximian.com>
5528 * class.cs (TypeContainer.GetClassBases): Moved
5529 Error_TypeParameterAsBase() here and also check whether the base
5530 class is not an attribute.
5532 2004-03-16 Martin Baulig <martin@ximian.com>
5534 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
5536 2004-03-16 Martin Baulig <martin@ximian.com>
5538 * class.cs (Error_TypeParameterAsBase): Use correct error number
5541 2004-03-16 Martin Baulig <martin@ximian.com>
5543 * decl.cs (DeclSpace.ResolveTypeExpr): Added more error checking
5546 * generics.cs (ConstructedType.DoResolveAsTypeStep): Added better
5549 2004-03-15 Martin Baulig <martin@ximian.com>
5551 * typemanager.cs (TypeManager.GetFullName): New public method.
5552 (TypeManager.MemberLookup): Added `int_num_type_arguments'
5553 argument; only return members with the correct number of type
5555 (TypeManager.CheckGeneric): Allow -1 to bypass the check.
5556 (TypeManager.FilterWithClosure): Call CheckGeneric() to check
5557 whether the number of type arguments matches.
5559 * generic.cs (GenericMemberAccess.ResolveAsTypeStep): Allow `expr'
5560 not being a ConstructedType; we can now do "typeof (Foo.Bar<U>)".
5562 * expression.cs (MemberAccess): Added public `NumTypeArguments'
5563 field; it's set by the protected .ctor when we're actually a
5564 GenericMemberAccess.
5565 (MemberAccess.ResolveAsTypeStep): Compute the total number of type
5566 arguments and pass it to MemberLookupFinal ().
5568 * ecore.cs (Expression.MemberLookup): Added `int
5569 num_type_arguments' argument; only return members with the correct
5570 number of type arguments.
5571 (Expression.MemberLookupFailed): Check whether the MemberLookup
5572 failed because we did not have the correct number of type
5573 arguments; report CS0305 in this case.
5575 * decl.cs (DeclSpace.ResolveTypeExpr): Don't report an error if
5576 `e.ResolveAsTypeTerminal()' already did so.
5578 2004-03-15 Martin Baulig <martin@ximian.com>
5580 * ecore.cs (Expression.ResolveLValue): Allow e.type being null if
5581 we're a ConstructedType; in this case, the caller must report an
5582 error (for instance CS0131).
5584 * generic.cs (TypeArguments): Added Location argument to the .ctor.
5585 (TypeArguments.Resolve): Actually report errors here.
5587 2004-03-15 Miguel de Icaza <miguel@ximian.com>
5589 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
5590 `set_indexer_name' to the pending bits (one per type).
5592 We fixed a bug today that was picking the wrong method to
5593 override, since for properties the existing InterfaceMethod code
5594 basically ignored the method name. Now we make sure that the
5595 method name is one of the valid indexer names.
5597 2004-03-15 Martin Baulig <martin@ximian.com>
5599 * typemanager.cs (TypeManager.IndexerPropertyName): Added support
5600 for generic instances.
5602 2004-03-13 Martin Baulig <martin@ximian.com>
5604 * class.cs (TypeContainer.DefineType): Call
5605 TypeManager.AddUserType() immediately after creating the
5606 TypeBuilder; pass all type parameters when creating the
5609 * decl.cs (DeclSpace.FindNestedType): New public method.
5610 (DeclSpace.FindType): Added `int num_type_args' argument; only
5611 return types with the correct number of type parameters.
5612 (DeclSpace.CountTypeParams): New public property.
5614 * ecore.cs (SimpleName.ctor): Added overloaded version which takes
5615 the number of type parameters; defaults to zero.
5617 * generic.cs (TypeArguments.Count): New public property.
5618 (ConstructedType.DoResolveAsTypeStep): First call
5619 ds.FindNestedType() to find out whether we're nested in the
5620 current generic type; in this case, we inherit all type parameters
5621 from the current class.
5623 * rootcontext.cs (RootContext.NamespaceLookup): Added `int
5624 num_type_args' argument.
5625 (RootContext.LookupType): Added overloaded version which takes the
5626 number of type arguments; only return types with the correct
5627 number of type arguments.
5629 * typemanager.cs (TypeManager.CheckGeneric): New public function;
5630 checks whether `Type t' has `int num_type_args'.
5632 2004-03-13 Martin Baulig <martin@ximian.com>
5634 * generic.cs (GenericMethod.DefineType): New method; calls
5635 DefineType() on all the type parameters.
5637 * class.cs (MethodData.ctor): Added `GenericMethod generic' argument.
5638 (MethodData.Define): If we're a generic method, call
5639 GenericMethod.DefineType() to define the type parameters.
5641 2004-03-10 Martin Baulig <martin@ximian.com>
5643 * pending.cs (Pending.InterfaceMethod): Use TypeManager.IsEqual()
5644 instead of IsAssignableFrom.
5646 2004-03-10 Martin Baulig <martin@ximian.com>
5648 * ecore.cs (FieldExpr.ctor): Use TypeManager.TypeToCoreType().
5650 * support.cs (ParameterData.HasArrayParameter): New property.
5651 (ReflectionParameters.ctor): Take a MethodBase instead of a
5652 ParameterInfo[]. If we have any type parameters, get the generic
5653 method definition and ask it whether we have variable arguments.
5655 2004-02-26 Miguel de Icaza <miguel@ximian.com>
5657 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
5658 routines to check if a type is an enumerable/enumerator allow
5659 classes that implement the IEnumerable or IEnumerator interfaces.
5661 * class.cs (Property, Operator): Implement IIteratorContainer, and
5662 implement SetYields.
5664 (Property.Define): Do the block swapping for get_methods in the
5665 context of iterators. We need to check if Properties also
5666 include indexers or not.
5668 (Operator): Assign the Block before invoking the
5669 OperatorMethod.Define, so we can trigger the Iterator code
5672 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
5673 Property and Operator classes are not created when we parse the
5674 declarator but until we have the block completed, so we use a
5675 singleton SimpleIteratorContainer.Simple to flag whether the
5676 SetYields has been invoked.
5678 We propagate this setting then to the Property or the Operator to
5679 allow the `yield' to function.
5681 2004-02-25 Marek Safar <marek.safar@seznam.cz>
5683 * codegen.cs: Implemented attribute support for modules.
5684 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
5685 Assembly/Module functionality.
5687 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
5688 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
5689 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
5691 2004-02-16 Marek Safar <marek.safar@seznam.cz>
5693 * interface.cs (FindMembers): The operation is performed on all base
5694 interfaces and not only on the first. It is required for future CLS Compliance patch.
5696 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
5698 * statement.cs, codegen.cs:
5699 This patch deals with patterns such as:
5701 public class List : IEnumerable {
5703 public MyEnumerator GetEnumerator () {
5704 return new MyEnumerator(this);
5707 IEnumerator IEnumerable.GetEnumerator () {
5711 public struct MyEnumerator : IEnumerator {
5716 Before, there were a few things we did wrong:
5717 1) we would emit callvirt on a struct, which is illegal
5718 2) we emited ldarg when we needed to emit ldarga
5719 3) we would mistakenly call the interface methods on an enumerator
5720 type that derived from IEnumerator and was in another assembly. For example:
5722 public class MyEnumerator : IEnumerator
5724 Would have the interface methods called, even if there were public impls of the
5725 method. In a struct, this lead to invalid IL code.
5727 2004-02-11 Marek Safar <marek.safar@seznam.cz>
5729 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
5732 * delegate.cs (Define): Fixed crash when delegate type is undefined.
5734 2004-02-11 Miguel de Icaza <miguel@ximian.com>
5736 * cs-parser.jay: Fix small regression: we were not testing V2
5737 compiler features correctly.
5739 * interface.cs: If the emit context is null, then create one
5741 2004-02-09 Marek Safar <marek.safar@seznam.cz>
5743 * decl.cs (GetSignatureForError): New virtual method to get full name
5746 * attribute.cs (IAttributeSupport): New interface for attribute setting.
5747 Now it is possible to rewrite ApplyAttributes method to be less if/else.
5749 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
5750 Duplicated members and code in these classes has been removed.
5751 Better encapsulation in these classes.
5753 2004-02-07 Miguel de Icaza <miguel@ximian.com>
5755 * assign.cs (Assign.DoResolve): When dealing with compound
5756 assignments, there is a new rule in ECMA C# 2.4 (might have been
5757 there before, but it is documented here) that states that in:
5761 If b is of type int, and the `op' is a shift-operator, then the
5762 above is evaluated as:
5766 * expression.cs (Binary.ResolveOperator): Instead of testing for
5767 int/uint/long/ulong, try to implicitly convert to any of those
5768 types and use that in pointer arithmetic.
5770 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
5771 method to print information for from the type, not from the
5772 null-method we were given.
5774 2004-02-01 Duncan Mak <duncan@ximian.com>
5776 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
5777 parsing for cmd, fixes bug #53694.
5779 2004-02-04 Marek Safar <marek.safar@seznam.cz>
5781 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
5782 in the member name duplication tests. Property and operator name duplication
5783 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
5785 2004-02-03 Marek Safar <marek.safar@seznam.cz>
5787 * interface.cs (PopulateMethod): Fixed crash when interface method
5788 returns not existing type (error test cs0246-3.cs).
5790 2004-02-02 Ravi Pratap M <ravi@ximian.com>
5792 * cs-parser.jay (interface_accessors): Re-write actions to also
5793 store attributes attached to get and set methods. Fix spelling
5796 (inteface_property_declaration): Modify accordingly.
5798 (InterfaceAccessorInfo): New helper class to store information to pass
5799 around between rules that use interface_accessors.
5801 * interface.cs (Emit): Apply attributes on the get and set
5802 accessors of properties and indexers too.
5804 * attribute.cs (ApplyAttributes): Modify accordingly to use the
5805 right MethodBuilder when applying attributes to the get and set accessors.
5807 2004-01-31 Miguel de Icaza <miguel@ximian.com>
5809 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
5811 2004-01-26 Miguel de Icaza <miguel@ximian.com>
5813 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
5815 2004-01-25 Miguel de Icaza <miguel@ximian.com>
5817 * cs-parser.jay: Remove YIELD token, instead use the new grammar
5818 changes that treat `yield' specially when present before `break'
5821 * cs-tokenizer.cs: yield is no longer a keyword.
5823 2004-01-23 Marek Safar <marek.safar@seznam.cz>
5825 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
5826 setting for default constructors.
5827 For default constructors are almost every time set wrong Modifier. The
5828 generated IL code has been alright. But inside mcs this values was
5829 wrong and this was reason why several of my CLS Compliance tests
5832 2004-02-27 Martin Baulig <martin@ximian.com>
5834 * generics.cs (ConstructedType.ResolveType): Make the nested type
5835 stuff actually work.
5837 2004-02-25 Martin Baulig <martin@ximian.com>
5839 * decl.cs (DeclSpace.CurrentTypeParameters): New protected
5840 property; returns the type parameters just from the current type,
5841 ie. with the ones from outer classes.
5842 (DeclSpace.LookupGeneric): First search in the current class, then
5844 (DeclSpace.initialize_type_params): When hiding a type parameter
5845 from an outer class, put it into the `type_param_list' anyways.
5847 * expression.cs (MemberAccess.expr): Made this field protected.
5849 * class.cs (TypeContainer.Define): The `CurrentType' just contains
5850 the type parameters from the current class.
5852 * generic.cs (ConstructedType.ResolveType): Support nested generic
5853 types by taking the type parameters which we inherit from outer
5854 classes into account.
5855 (GenericMemberAccess.ResolveAsTypeStep): Override this and added
5856 support for nested generic types.
5858 2004-02-23 Martin Baulig <martin@ximian.com>
5860 * decl.cs (DeclSpace.IsGeneric): Make this a property instead of a
5861 field and check whether we're nested inside a generic type.
5862 (DeclSpace.ResolveType): If we're resolving to a generic type
5863 definition, create a ConstructedType and return its resolved type.
5864 (DeclSpace.initialize_type_params): New private method;
5865 initializes the `type_param_list' field from the type parameters
5866 from this and all enclosing classes.
5867 (DeclSpace.TypeParameters): Call initialize_type_params() unless
5868 we're already initialized.
5870 2004-02-23 Martin Baulig <martin@ximian.com>
5872 * class.cs (Method.Define): Create the generic method before
5874 (Memberbase.DoDefine): Added DeclSpace argument (in addition to
5875 the TypeContainer one); we use this for generic methods.
5877 * decl.cs (CheckAccessLevel): If we're a GenericMethod, use our
5878 parent's TypeBuilder.
5880 2004-02-18 Martin Baulig <martin@ximian.com>
5882 * ecore.cs (FieldExpr.DoResolveLValue): Use TypeManager.IsEqual()
5883 to check for equality.
5885 2004-02-05 Martin Baulig <martin@ximian.com>
5887 * ecore.cs (FieldExpr.DoResolveLValue): If we have an
5888 `ec.TypeContainer.CurrentType', use it instead of
5889 `ec.ContainerType' to check whether we're in the type's ctor.
5891 2004-01-29 Martin Baulig <martin@ximian.com>
5893 * expression.cs (Invocation.DoResolve): If we're a
5894 `ConstructedType', then we're actually a generic method, so
5895 rewrite the expr as a GenericMemberAccess.
5897 * cs-parser.jay (member_name): Don't use `namespace_or_type_name'
5898 here; manually parse it into a string.
5900 2004-01-28 Martin Baulig <martin@ximian.com>
5902 * typemanager.cs (TypeManager.IsEqual): New static method.
5903 (TypeManager.FilterWithClosure): Call TypeManager.IsEqual() to
5904 check for equality instead of using `=='.
5906 2004-01-26 Martin Baulig <martin@ximian.com>
5908 * decl.cs (DeclSpace.CurrentType): New public field.
5910 * expression.cs (This.ResolveBase): If we have an
5911 `ec.TypeContainer.CurrentType', use it instead of
5914 * class.cs (TypeContainer.DefineType): If we're a generic type,
5915 create the `CurrentType' (unresolved).
5916 (TypeContainer.GenericType): New private field.
5917 (TypeContainer.DefineMembers): If we have a `CurrentType', resolve
5918 it and store it in `GenericType' before creating the MemberCache.
5919 (TypeContainer.GetMembers): If we have a `GenericType', call
5920 TypeManager.FindMembers() on it.
5922 * interface.cs (Interface.GenericType): New private field.
5923 (Interface.DefineType): If we're a generic type, create the
5924 `CurrentType' (unresolved).
5925 (Interface.DefineMembers): If we have a `CurrentType', resolve it
5926 and store it in `GenericType' before creating the MemberCache.
5927 (Interface.GetMembers): If we have a `GenericType', call
5928 TypeManager.FindMembers() on it.
5930 2004-01-22 Martin Baulig <martin@ximian.com>
5932 * cs-parser.jay (namespace_or_type_name): Return an Expression,
5933 not a QualifiedIdentifier. This is what `type_name_expression'
5934 was previously doing.
5935 (type_name_expression): Removed; the code is now in
5936 `namespace_or_type_name'.
5937 (qualified_identifier): Removed, use `namespace_or_type_name'
5939 (QualifiedIdentifier): Removed this class.
5941 2004-01-22 Martin Baulig <martin@ximian.com>
5943 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
5944 not a string as alias name.
5946 2004-01-21 Miguel de Icaza <miguel@ximian.com>
5948 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
5949 #52730 bug, and instead compute correctly the need to use a
5950 temporary variable when requesting an address based on the
5951 static/instace modified of the field and the constructor.
5953 2004-01-21 Martin Baulig <martin@ximian.com>
5955 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
5956 class and namespace before looking up aliases. Fixes #52517.
5958 2004-01-21 Martin Baulig <martin@ximian.com>
5960 * flowanalysis.cs (UsageVector.Merge): Allow variables being
5961 assinged in a 'try'; fixes exception4.cs.
5963 2004-01-21 Marek Safar <marek.safar@seznam.cz>
5964 * class.cs : Implemented parameter-less constructor for TypeContainer
5966 * decl.cs: Attributes are now stored here. New property OptAttributes
5968 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
5970 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
5972 2004-01-21 Marek Safar <marek.safar@seznam.cz>
5974 * typemanager.cs (CSharpSignature): Now reports also inner class name.
5975 (CSharpSignature): New method for indexer and property signature.
5977 2004-01-21 Marek Safar <marek.safar@seznam.cz>
5979 * pending.cs (IsVirtualFilter): Faster implementation.
5981 2004-01-21 Marek Safar <marek.safar@seznam.cz>
5983 * typemanager.cs: Avoid inclusion of same assembly more than once.
5985 2004-01-21 Marek Safar <marek.safar@seznam.cz>
5987 * cs-parser.jay: Fixed problem where the last assembly attribute
5988 has been applied also to following declaration (class, struct, etc.)
5990 2004-01-21 Marek Safar <marek.safar@seznam.cz>
5992 * class.cs: Added error CS0538, CS0539 reporting.
5993 Fixed crash on Microsoft runtime when field type is void.
5995 * cs-parser.jay: Added error CS0537 reporting.
5997 * pending.cs: Added error CS0535 reporting.
5998 Improved error report for errors CS0536, CS0534.
6000 2004-01-20 Miguel de Icaza <miguel@ximian.com>
6002 Merge a few bits from the Anonymous Method MCS tree.
6004 * statement.cs (ToplevelBlock): New class for toplevel methods,
6005 will hold anonymous methods, lifted variables.
6007 * cs-parser.jay: Create toplevel blocks for delegates and for
6008 regular blocks of code.
6010 2004-01-20 Martin Baulig <martin@ximian.com>
6012 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
6013 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
6014 and `NeedExplicitReturn'; added `IsLastStatement'.
6015 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
6016 have a `ReturnLabel' or we're not unreachable.
6018 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
6019 child's reachability; don't just override ours with it. Fixes
6020 #58058 (lluis's example).
6021 (FlowBranching): Added public InTryOrCatch(), InCatch(),
6022 InFinally(), InLoop(), InSwitch() and
6023 BreakCrossesTryCatchBoundary() methods.
6025 * statement.cs (Return): Do all error checking in Resolve().
6026 Unless we are the last statement in a top-level block, always
6027 create a return label and jump to it.
6028 (Break, Continue): Do all error checking in Resolve(); also make
6029 sure we aren't leaving a `finally'.
6030 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
6031 statement in a top-level block.
6032 (Block.Flags): Added `IsDestructor'.
6033 (Block.IsDestructor): New public property.
6035 2004-01-20 Martin Baulig <martin@ximian.com>
6037 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
6039 2004-01-20 Martin Baulig <martin@ximian.com>
6041 * statement.cs (Statement.ResolveUnreachable): New public method.
6042 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
6043 (Block.Resolve): Resolve unreachable statements.
6045 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
6047 * expression.cs: We need to fix the case where we do
6048 not have a temp variable here.
6050 * assign.cs: Only expression compound assignments need
6051 temporary variables.
6053 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
6055 * flowanalysis.cs: Reduce memory allocation in a few ways:
6056 - A block with no variables should not allocate a bit
6058 - A method with no out parameters does not need any tracking
6059 for assignment of the parameters, so we need not allocate
6062 public readonly Type[] VariableTypes;
6063 public readonly string[] VariableNames;
6064 Are redundant. The data is already stored in the variable
6065 map, so we need not allocate another array for it.
6066 - We need to add alot of checks for if (params | locals) == null
6067 due to the first two changes.
6069 2004-01-18 Miguel de Icaza <miguel@ximian.com>
6071 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
6072 implement IMemoryLocation, we store a copy on a local variable and
6073 take the address of it. Patch from Benjamin Jemlich
6075 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
6076 to use a special "type_name_expression" rule which reduces the
6077 number of "QualifiedIdentifier" classes created, and instead
6078 directly creates MemberAccess expressions.
6080 2004-01-17 Miguel de Icaza <miguel@ximian.com>
6082 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
6083 that fixes #52853. Null literal assignment to ValueType
6085 * class.cs (MethodData.Emit): Instead of checking the name of the
6086 method to determine if its a destructor, create a new derived
6087 class from Method called Destructor, and test for that.
6089 * cs-parser.jay: Create a Destructor object instead of a Method.
6091 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
6095 2004-01-16 Miguel de Icaza <miguel@ximian.com>
6097 * expression.cs (Binary.ResolveOperator): Perform an implicit
6098 conversion from MethodGroups to their delegate types on the
6101 * delegate.cs: Introduce a new class DelegateCreation that is the
6102 base class for `NewDelegate' and `ImplicitDelegateCreation',
6103 factor some code in here.
6105 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
6106 conversion from MethodGroups to compatible delegate types.
6108 * ecore.cs (Expression.Resolve): Do not flag error 654
6109 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
6110 we allow conversions from MethodGroups to delegate types now.
6112 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
6113 assignments in v2 either.
6115 2004-01-10 Miguel de Icaza <miguel@ximian.com>
6117 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
6118 static read-only fields in ctors.
6120 Applied patch from Benjamin Jemlich
6122 * expression.cs (UnaryMutator): Avoid leaking local variables.
6124 2004-01-09 Miguel de Icaza <miguel@ximian.com>
6126 * cs-tokenizer.cs (IsCastToken): Allow the various native types
6127 here to return true, as they can be used like this:
6131 Fixed 49836 and all the other dups
6133 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
6135 * driver.cs: Implement /win32res and /win32icon.
6137 2004-01-08 Miguel de Icaza <miguel@ximian.com>
6139 * cs-parser.jay: Add a rule to improve error handling for the
6140 common mistake of placing modifiers after the type.
6142 2004-01-07 Miguel de Icaza <miguel@ximian.com>
6144 * cs-parser.jay (interface_event_declaration): Catch
6145 initialization of events on interfaces, and report cs0068
6147 * cs-parser.jay (interface_event_declaration): Catch
6148 initialization of events.
6150 * ecore.cs: Better report missing constructors.
6152 * expression.cs (Binary.ResolveOperator): My previous bug fix had
6153 the error reporting done in the wrong place. Fix.
6155 * expression.cs (Binary.ResolveOperator): Catch the
6156 operator + (E x, E y) error earlier, and later allow for implicit
6157 conversions in operator +/- (E e, U x) from U to the underlying
6160 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
6161 52596, if the container class is abstract, the default constructor
6162 is protected otherwise its public (before, we were always public).
6164 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
6167 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
6168 Jemlich that fixes bug #52597, MCS was generating invalid code for
6169 idisposable structs. Thanks to Ben for following up with this
6172 2004-01-06 Miguel de Icaza <miguel@ximian.com>
6174 * driver.cs: Allow assemblies without code to be generated, fixes
6177 2004-01-07 Nick Drochak <ndrochak@gol.com>
6179 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
6181 2004-01-05 Miguel de Icaza <miguel@ximian.com>
6183 * cs-parser.jay: Add rules to improve error reporting if fields or
6184 methods are declared at the namespace level (error 116)
6186 * Add rules to catch event add/remove
6188 2004-01-04 David Sheldon <dave-mono@earth.li>
6190 * expression.cs: Added matching ")" to error message for
6193 2004-01-03 Todd Berman <tberman@gentoo.org>
6195 * ecore.cs, attribute.cs:
6196 Applying fix from #52429.
6198 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
6200 * ecore.cs, expression.cs, statement.cs:
6201 Total rewrite of how we handle branching. We
6202 now handle complex boolean expressions with fewer
6203 jumps. As well if (x == 0) no longer emits a ceq.
6205 if (x is Foo) is much faster now, because we generate
6208 Overall, we get a pretty big improvement on our benchmark
6209 tests. The code we generate is smaller and more readable.
6211 I did a full two-stage bootstrap. The patch was reviewed
6212 by Martin and Miguel.
6214 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
6216 * cs-parser.jay: Make primary_expression not take a QI.
6217 we dont need this because the member_access rule covers
6218 us here. So we replace the rule with just IDENTIFIER.
6220 This has two good effects. First, we remove a s/r conflict.
6221 Second, we allocate many fewer QualifiedIdentifier objects.
6223 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
6225 * attribute.cs: Handle MarshalAs attributes as pseudo, and
6226 set the correct information via SRE. This prevents
6227 hanging on the MS runtime. Fixes #29374.
6229 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
6231 * convert.cs: correctly handle conversions to value types
6232 from Enum and ValueType as unboxing conversions.
6234 Fixes bug #52569. Patch by Benjamin Jemlich.
6236 2004-01-02 Ravi Pratap <ravi@ximian.com>
6238 * expression.cs (BetterConversion): Prefer int -> uint
6239 over int -> ulong (csc's behaviour). This fixed bug #52046.
6241 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
6243 * decl.cs (MemberCache.FindMembers): now returns a
6246 * typemanager.cs: In general, go with with ^^.
6247 (CopyNewMethods): take an IList.
6248 (RealMemberLookup): Only allocate an arraylist
6249 if we copy from two sets of methods.
6251 This change basically does two things:
6252 1) Fewer array lists allocated due to CopyNewMethods.
6253 2) the explicit cast in MemberList costed ALOT.
6255 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
6257 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
6258 a hashtable to avoid needless string allocations when an identifier is
6259 used more than once (the common case).
6261 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
6263 * pending.cs: MS's TypeBuilder.GetInterfaces ()
6264 is broken, it will not return anything. So, we
6265 have to use the information we have in mcs to
6268 * typemanager.cs: Add a cache for GetInterfaces,
6269 since this will now be used more often (due to ^^)
6271 (GetExplicitInterfaces) New method that gets the
6272 declared, not effective, interfaces on a type
6273 builder (eg, if you have interface IFoo, interface
6274 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
6277 This patch makes MCS able to bootstrap itself on
6280 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
6282 * expression.cs: Remove the Nop's that Miguel put
6285 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
6287 * report.cs, codegen.cs: Give the real stack trace to
6288 the error when an exception is thrown.
6290 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
6292 * decl.cs: only allocate hashtables for ifaces if
6295 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
6297 * expression.cs: fix the error from cs0121-2.cs
6298 (a parent interface has two child interfaces that
6299 have a function with the same name and 0 params
6300 and the function is called through the parent).
6302 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
6304 * class.cs, rootcontext.cs, typmanager.cs: do not
6307 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
6309 * codegen.cs: remove stack for the ec flow branching.
6310 It is already a linked list, so no need.
6312 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
6314 * Makefile: Allow custom profiler here.
6316 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
6318 * typemanager.cs (LookupType):
6319 - Use a static char [], because split takes
6320 a param array for args, so it was allocating
6322 - Do not store true in a hashtable, it boxes.
6324 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
6326 * flowanalysis.cs: bytify common enums.
6328 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
6330 * modifiers.cs: Add a new set of flags for the
6331 flags allowed on explicit interface impls.
6332 * cs-parser.jay: catch the use of modifiers in
6333 interfaces correctly.
6334 * class.cs: catch private void IFoo.Blah ().
6336 All related to bug #50572.
6338 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
6340 * decl.cs: Rewrite the consistant accessability checking.
6341 Accessability is not linear, it must be implemented in
6342 a tableish way. Fixes #49704.
6344 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
6346 * expression.cs: Handle negation in a checked context.
6347 We must use subtraction from zero. Fixes #38674.
6349 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
6351 * class.cs: Ignore static void main in DLLs.
6352 * rootcontext.cs: Handle the target type here,
6353 since we are have to access it from class.cs
6354 * driver.cs: account for the above.
6356 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
6358 * report.cs: Give line numbers and files if available.
6360 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
6362 * driver.cs: Implement /addmodule.
6364 * typemanager.cs: Change 'modules' field so it now contains Modules not
6367 2003-12-20 Martin Baulig <martin@ximian.com>
6369 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
6370 (FieldBase.IsAssigned): Removed this field.
6371 (FieldBase.SetAssigned): New public method.
6372 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
6374 2003-12-20 Martin Baulig <martin@ximian.com>
6376 * expression.cs (LocalVariableReference.DoResolve): Don't set
6377 `vi.Used' if we're called from DoResolveLValue().
6379 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
6380 returns the usage vector it just merged into the current one -
6381 pass this one to UsageWarning().
6382 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
6383 of the `EmitContext', don't call this recursively on our children.
6385 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
6387 * driver.cs: Implement /target:module.
6389 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
6391 * support.cs (CharArrayHashtable): New helper class.
6393 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
6394 char arrays, not strings, so we can avoid creating a string in
6395 consume_identifier if the identifier is a keyword.
6397 2003-12-16 Martin Baulig <martin@ximian.com>
6399 * statement.cs (LocalInfo.Assigned): Removed this property.
6400 (LocalInfo.Flags): Removed `Assigned'.
6401 (LocalInfo.IsAssigned): New public method; takes the EmitContext
6402 and uses flow analysis.
6403 (Block.UsageWarning): Made this method private.
6404 (Block.Resolve): Call UsageWarning() if appropriate.
6406 * expression.cs (LocalVariableReference.DoResolve): Always set
6407 LocalInfo.Used here.
6409 2003-12-13 Martin Baulig <martin@ximian.com>
6411 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
6412 any value here; we're now using flow analysis to figure out
6413 whether a statement/block returns a value.
6415 2003-12-13 Martin Baulig <martin@ximian.com>
6417 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
6419 (FlowBranching.MergeFinally): Don't call
6420 `branching.CheckOutParameters()' here, this is called in
6422 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
6423 when adding the `finally' vector.
6425 2003-12-13 Martin Baulig <martin@ximian.com>
6428 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
6429 actually work and also fix #48962.
6431 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
6433 * decl.cs: Do not check System.Object for nested types,
6434 since we know it does not have any. Big bang for buck:
6439 corlib: 17.99 seconds
6443 corlib: 17.39 seconds
6445 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
6447 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
6448 time we are returning 0 members, so we save alot here.
6450 2003-12-11 Martin Baulig <martin@ximian.com>
6452 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
6453 `MergeChild()', also just take the `FlowBranching' as argument;
6454 call Merge() on it and return the result.
6455 (FlowBranching.Merge): We don't need to do anything if we just
6458 2003-12-11 Martin Baulig <martin@ximian.com>
6460 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
6461 them in an `ArrayList' to reduce memory usage. Thanks to Ben
6462 Maurer for this idea.
6464 2003-12-11 Martin Baulig <martin@ximian.com>
6466 * flowanalysis.cs (MergeResult): This class is now gone; we now
6467 use the `UsageVector' for this. The reason for this is that if a
6468 branching just has one sibling, we don't need to "merge" them at
6469 all - that's the next step to do.
6470 (FlowBranching.Merge): We now return a `UsageVector' instead of a
6473 2003-12-11 Martin Baulig <martin@ximian.com>
6475 Reworked flow analyis and made it more precise and bug-free. The
6476 most important change is that we're now using a special `Reachability'
6477 class instead of having "magic" meanings of `FlowReturns'. I'll
6478 do some more cleanups and optimizations and also add some more
6479 documentation this week.
6481 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
6482 largely reworked this class.
6483 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
6484 the new `Reachability' class instead of having "magic" values here.
6485 (FlowBranching): We're now using an instance of `Reachability'
6486 instead of having separate `Returns', `Breaks' etc. fields.
6488 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
6489 based on flow analysis; ignore the return value of block.Emit ().
6491 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
6493 * driver.cs typemanager.cs: Find the mono extensions to corlib even
6494 if they are private.
6496 2003-12-09 Martin Baulig <martin@ximian.com>
6498 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
6499 call them directly on the UsageVector.
6501 2003-12-09 Martin Baulig <martin@ximian.com>
6503 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
6504 Changed return type from `FlowReturns' to `Reachability'.
6506 2003-12-09 Martin Baulig <martin@ximian.com>
6508 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
6509 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
6510 `Reachable' fields with a single `Reachability' one.
6512 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
6514 * class.cs (FindMembers): Remove foreach's.
6527 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
6532 This patch does a few things:
6533 1. EmptyStatement is now a singleton, so it is never reallocated.
6534 2. All blah is EmptyStatement constructs have been changed to
6535 blah == EmptyStatement.Value, which is much faster and valid
6536 now that EmptyStatement is a singleton.
6537 3. When resolving a block, rather than allocating a new array for
6538 the non-empty statements, empty statements are replaced with
6539 EmptyStatement.Value
6540 4. Some recursive functions have been made non-recursive.
6541 Mainly the performance impact is from (3), however (1) and (2) are needed for
6542 this to work. (4) does not make a big difference in normal situations, however
6543 it makes the profile look saner.
6548 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
6549 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
6550 Total memory allocated: 56397 KB
6553 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
6554 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
6555 Total memory allocated: 55666 KB
6557 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
6559 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
6560 than the hashtable in a hashtable version
6562 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
6563 we always end up concating a string. This results in a huge perf
6564 loss, because many strings have to be tracked by the GC. In this
6565 patch, we first use a hashtable that works with two keys, so that
6566 the strings do not need to be concat'ed.
6577 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
6579 * Makefile: Add a new target `do-time' that does a quick and simple
6580 profile, leaving easy to parse output.
6582 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
6584 * codegen.cs (Init): Create the dynamic assembly with
6585 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
6587 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
6589 * support.cs: Make the PtrHashtable use only one
6590 instance of its comparer.
6592 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
6594 * typemanager.cs: Fix lookup of GetNamespaces.
6596 2003-11-29 Miguel de Icaza <miguel@ximian.com>
6598 * expression.cs: Removed redundant line.
6600 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
6601 ArrayLists, use for loops with bounds.
6603 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
6606 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
6607 arraylists, use for loop with bounds.
6609 The above three changes give us a 0.071 second performance
6610 improvement out of 3.294 seconds down to 3.223. On my machine
6611 the above changes reduced the memory usage by 1,387 KB during
6614 * cs-parser.jay (QualifiedIdentifier): New class used to represent
6615 QualifiedIdentifiers. Before we created a new string through
6616 concatenation, and mostly later on, the result would be
6617 manipulated by DecomposeQI through string manipulation.
6619 This reduced the compiler memory usage for bootstrapping from
6620 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
6621 compile times in 0.05 seconds.
6623 2003-11-28 Dick Porter <dick@ximian.com>
6625 * support.cs: Do string compares with the Invariant culture.
6633 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
6634 the comparison is done with the Invariant culture.
6636 2003-11-27 Miguel de Icaza <miguel@ximian.com>
6638 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
6639 GetEnumerator method.
6641 (ProbeCollectionType): Iterate starting at the most specific type
6642 upwards looking for a GetEnumerator
6644 * expression.cs: Shift count can be up to 31 for int/uint and 63
6647 2003-11-26 Miguel de Icaza <miguel@ximian.com>
6649 * statement.cs (Block.LookupLabel): Also look for the label on the
6650 children blocks. Use a hash table to keep track of visited
6653 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
6654 we actually did transform the other operand, otherwise fall back
6655 to the common codepath that casts to long.
6657 * cs-tokenizer.cs: Use the same code pattern as the int case.
6658 Maybe I should do the parsing myself, and avoid depending on the
6659 Parse routines to get this done.
6661 2003-11-25 Miguel de Icaza <miguel@ximian.com>
6663 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
6664 which fixes bug 51347. This time test it.
6666 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
6667 attributes for example can not tell the difference between these.
6668 The difference was only a syntax feature of the language.
6670 * attribute.cs: Apply attributes to delegates.
6672 * delegate.cs: Call the apply attributes method.
6674 2003-11-24 Miguel de Icaza <miguel@ximian.com>
6676 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
6677 comparing 0 vs Byte.MinValue, not the value
6679 (ImplicitConversionRequired): When reporting a conversion error,
6680 use error 31 to print out the constant error instead of the
6683 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
6684 which fixes bug 51347.
6686 2003-11-22 Miguel de Icaza <miguel@ximian.com>
6688 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
6689 which fixes the -warnaserror command line option.
6691 2003-11-21 Miguel de Icaza <miguel@ximian.com>
6693 * cfold.cs (DoNumericPromotions): During constant folding of
6694 additions on UIntConstant, special case intconstants with
6695 IntConstants like we do on the expression binary operator.
6697 2003-11-12 Miguel de Icaza <miguel@ximian.com>
6699 * convert.cs (ImplicitReferenceConversion): We were missing a case
6700 (System.Enum are not value types or class types, so we need to
6701 classify them separatedly).
6703 * driver.cs: We do not support error 2007.
6705 2003-11-12 Jackson Harper <jackson@ximian.com>
6707 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
6708 system directory. Also use the full file name so users can
6709 libraries names mscorlib-o-tron.dll in a non system dir.
6711 2004-01-04 David Sheldon <dave-mono@earth.li>
6713 * expression.cs: Added matching ")" to error message for CS0077.
6715 2003-12-19 Martin Baulig <martin@ximian.com>
6717 * typemanager.cs (TypeManager.IsEqualGenericType): New public
6718 static method; see documentation in the method.
6719 (TypeManager.IsSubclassOrNestedChild): Allow IsEqualGenericType().
6721 * convert.cs (Convert.ImplicitReferenceConversion,
6722 Convert.ImplicitReferenceConversionExists): Add support for
6723 generic type declarations; see gen-36.cs.
6725 2003-12-19 Martin Baulig <martin@ximian.com>
6727 * pending.cs (Pending.InterfaceMethod): Use
6728 `Type.IsAssignableFrom()' instead of `=='.
6730 2003-12-18 Martin Baulig <martin@ximian.com>
6732 * decl.cs (DeclSpace.AsAccessible): Check for array, pointer and
6735 * convert.cs (Convert.ImplicitStandardConversionExists): Use
6736 `expr_type.Equals (target_type)' instead of `=='.
6738 2003-12-08 Martin Baulig <martin@ximian.com>
6740 * generics.cs (Constraints.Types): Removed.
6741 (Constraints.Resolve): Just resolve everything to TypeExpr's, not
6743 (Constraints.ResolveTypes): New public method; resolves the
6744 TypeExpr's to Type's.
6745 (TypeParameter.Define): TypeBuilder.DefineGenericParameter() no
6746 longer takes the constraints.
6747 (TypeParameter.DefineMethod): Likewise.
6748 (TypeParameter.DefineType): New public method. Calls
6749 `TypeBuilder/MethodBuilder.SetGenericParameterConstraints()' to set
6752 2003-12-08 Martin Baulig <martin@ximian.com>
6754 * convert.cs (Convert.ImplicitConversionStandard): Use
6755 `expr_type.Equals (target_type)' instead of `=='.
6757 2003-12-08 Martin Baulig <martin@ximian.com>
6759 * typemanager.cs (TypeManager.GetReferenceType): Call
6760 `Type.MakeByRefType ()'.
6762 2003-12-08 Martin Baulig <martin@ximian.com>
6764 * cs-parser.jay, cs-tokenizer.cs: `where' is not a keyword, it
6765 just has some special meaning in some situations. For instance,
6766 it is allowed to use `where' as the name of a variable etc.
6768 2003-12-04 Martin Baulig <martin@ximian.com>
6770 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
6771 `Type.MakeArrayType()' for array types.
6773 2003-11-18 Miguel de Icaza <miguel@ximian.com>
6775 * expression.cs (Invocation.VerifyArgumentsCompat): Remove
6778 (SizeOf.DoResolve): assign the `type_queried' field. This gets
6781 2003-11-16 Martin Baulig <martin@ximian.com>
6783 * codegen.cs (EmitContext.IsGeneric): Removed.
6785 * ecore.cs (SimpleName.ResolveAsTypeStep): Always call
6786 ResolveGeneric() on the DeclSpace.
6788 2003-11-16 Martin Baulig <martin@ximian.com>
6790 * generic.cs (TypeArguments.Resolve):
6791 `Expression.ResolveAsTypeTerminal()' returns a TypeExpr; call
6792 `ResolveType()' on it to get the Type.
6794 2003-11-15 Martin Baulig <martin@ximian.com>
6796 * generic.cs (ConstructedType.GetInterfaces): Override this.
6798 2003-11-14 Martin Baulig <martin@ximian.com>
6800 * interface.cs (Interface.DefineType): Define all type parameters
6801 before adding the interfaces we inherit.
6803 2003-11-11 Martin Baulig <martin@ximian.com>
6805 * generic.cs (ConstructedType.ResolveType): Always call
6806 `gt.BindGenericParameters (atypes)'; also if `args.HasTypeArguments'.
6808 2003-11-10 Martin Baulig <martin@ximian.com>
6810 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
6811 (TypeManager.InitCoreTypes): Initialize them here, but instead of
6812 calling `ResolveType()' on them, directly assign their `Type'.
6814 2003-11-08 Martin Baulig <martin@ximian.com>
6816 * generic.cs (ConstructedType): Override `IsClass' etc.
6818 2003-11-08 Martin Baulig <martin@ximian.com>
6820 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
6821 return value and the `out parent' parameter.
6822 (TypeContainer.DefineType): Moved the CS0644 check into
6823 GetClassBases(). Don't pass the interface types to the
6824 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
6825 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
6827 * ecore.cs (TypeExpr.IsAttribute): New property.
6828 (TypeExpr.GetInterfaces): New method.
6830 * interface.cs (Interface.GetInterfaceTypeByName): Return a
6831 TypeExpr instead of a Type.
6832 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
6833 (Interface.DefineType): Don't pass the interface types to the
6834 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
6835 them later and then call `TypeBulider.AddInterfaceImplementation()'.
6837 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
6838 instead of a `Type[]'.
6839 (TypeManager.RegisterBuilder): Likewise.
6840 (TypeManager.AddUserInterface): Likewise.
6841 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
6842 `Type[]' and also return a `TypeExpr[]'.
6843 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
6845 2003-11-08 Martin Baulig <martin@ximian.com>
6847 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
6850 2003-11-08 Martin Baulig <martin@ximian.com>
6852 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
6853 TypeManager.ResolveExpressionTypes().
6855 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
6856 instead of an Expression.
6857 (TypeExpr): This is now an abstract base class for `TypeExpression'.
6858 (TypeExpression): New public class; formerly known as `TypeExpr'.
6860 * expression.cs (ComposedCast): Derive from TypeExpr.
6862 * typemanager.cs (TypeManager.system_*_expr): These are now
6863 TypExpr's instead of Expression's.
6864 (TypeManager.ResolveExpressionTypes): New public static function;
6865 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
6868 2003-11-06 Miguel de Icaza <miguel@ximian.com>
6870 * expression.cs (New.DoResolve): Do not dereference value that
6871 might be a null return.
6873 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
6874 sure that the constant value has the right type. Fixes an
6875 unreported bug, similar to 50425.
6877 * const.cs (Const.LookupConstantValue): Call
6878 ImplicitStandardConversionExists before doing a conversion to
6879 avoid havng the TypeManager.ChangeType do conversions.
6881 Reduced the number of casts used
6883 (Const.ChangeType): New routine to enable reuse of the constant
6884 type changing code from statement.
6886 * typemanager.cs (ChangeType): Move common initialization to
6887 static global variables.
6891 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
6892 every value type to go through, even if it was void. Fix that.
6894 * cs-tokenizer.cs: Use is_identifier_start_character on the start
6895 character of the define, and the is_identifier_part_character for
6896 the rest of the string.
6898 2003-11-05 Miguel de Icaza <miguel@ximian.com>
6900 * expression.cs (UnaryMutator.EmitCode): When I updated
6901 LocalVariableReference.DoResolve, I overdid it, and dropped an
6902 optimization done on local variable references.
6904 2003-11-04 Miguel de Icaza <miguel@ximian.com>
6906 * ecore.cs: Convert the return from Ldlen into an int.
6908 2003-10-20 Miguel de Icaza <miguel@ximian.com>
6910 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
6911 the accessibility, this is a special case for toplevel non-public
6912 classes (internal for instance).
6914 2003-10-20 Nick Drochak <ndrochak@gol.com>
6916 * ecore.cs: Fix typo and build. Needed another right paren.
6918 2003-10-19 Miguel de Icaza <miguel@ximian.com>
6920 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
6921 `internal' case regular and protected, but not allowing protected
6922 to be evaluated later. Bug 49840
6924 2003-10-15 Miguel de Icaza <miguel@ximian.com>
6926 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
6927 to kb.Nlast, and not the kb.nFirst to isolate the switch
6930 Extract the underlying type, so enumerations of long/ulong are
6931 treated like long/ulong.
6933 2003-10-14 Miguel de Icaza <miguel@ximian.com>
6935 * expression.cs (New): Overload the meaning of RequestedType to
6936 track the possible creation of the NewDelegate type, since
6937 DoResolve is invoked more than once for new constructors on field
6940 See bugs: #48800 and #37014
6942 * cs-parser.jay (declare_local_constants): Take an arraylist
6943 instead of a single constant.
6945 (local_constant_declaration): It should take a
6946 constant_declarators, not a constant_declarator. Fixes 49487
6948 * convert.cs: Fix error report.
6950 2003-10-13 Jackson Harper <jackson@ximian.com>
6952 * typemanager.cs (TypeToCoreType): Add float and double this fixes
6955 2003-11-03 Martin Baulig <martin@ximian.com>
6957 * expression.cs (ArrayAccess.GetStoreOpcode): Added
6958 `out bool has_type_arg'; if set, we need to pass the type to
6960 (ArrayAccess.GetStoreOpcode, ArrayAccess.EmitLoadOpcode): Use
6961 Stelem_Any/Ldelem_Any for generic parameters.
6963 2003-11-02 Martin Baulig <martin@ximian.com>
6965 * expression.cs (Invocation.EmitCall): Use
6966 `TypeManager.IsValueType()' to check whether it's a value type.
6967 Don't set `struct_call' when calling a method on a type parameter.
6969 2003-11-02 Martin Baulig <martin@ximian.com>
6971 * generics.cs (ConstructedType.Resolve): Renamed to ResolveType()
6972 and removed the TypeBuilder argument.
6974 * typemanager.cs (TypeManager.IsValueType): Return
6975 `t.IsGenericParameter || t.IsValueType'.
6977 2003-10-25 Martin Baulig <martin@ximian.com>
6979 * decl.cs (DeclSpace.ResolveType): If we're a ConstructedType,
6980 call ConstructedType.Resolve() on it.
6982 * generic.cs (ConstructedType.Resolve): Set `type' on success.
6984 2003-10-25 Martin Baulig <martin@ximian.com>
6986 * class.cs (TypeContainer.GetClassBases): Changed
6987 `out Type parent' into `out TypeExpr parent'. Moved CS0644 and
6988 CS8214 reporting here.
6989 (TypeContainer.DefineType): GetClassBases() gives us a `TypeExpr'
6990 instead of a `Type' for our parent. In case of a recursive
6991 declaration (see tests/gen-23.cs for an example), our parent is a
6992 ConstructedType and it doesn't have its type set. So, first
6993 create our own TypeBuilder, then call constructed.Resolve() to get
6994 the parent's type and finally TypeBuilder.SetParent() it.
6996 * ecore.cs (TypeExpr.Name): New public virtual property.
6999 (ConstructedType): We're now a TypeExpr and not just an Expression.
7000 (ConstructedType.ResolveAsTypeStep): Don't resolve our type
7001 arguments here; this is done later.
7002 (ConstructedType.Resolve): New public method to resolve the type
7003 arguments and bind them.
7005 2003-10-21 Martin Baulig <martin@ximian.com>
7007 * convert.cs: Use `TypeManager.IsValueType' instead of
7008 'type.IsValueType' everywhere.
7010 * typemanager.cs (TypeManager.IsValueType): Return true for type
7011 parameters. The reason for this is that we need to box a type
7012 parameter when converting it to a reference type.
7014 * cs-parser.jay: Added support for default value expressions.
7016 * generics.cs (DefaultValueExpression): New public class.
7018 2003-10-17 Martin Baulig <martin@ximian.com>
7020 * generic.cs (Constraints.Resolve): Take a DecpSpace instead of a
7021 TypeContainer so we can also use this for Interfaces.
7022 (TypeParameter.Resolve): Likewise.
7024 * interface.cs (Interface.DefineType): Added support for generic
7027 * cs-parser.jay: Added support for generic structs and interfaces.
7029 2003-10-17 Martin Baulig <martin@ximian.com>
7031 * generic.cs (GenericMemberAccess.DoResolve): We can now actually
7032 call generic methods :-)
7034 2003-10-16 Martin Baulig <martin@ximian.com>
7036 * cs-parser.jay (namespace_or_type_name): Only create a
7037 GenericMemberAccess if we actually have type arguments.
7039 2003-10-13 Martin Baulig <martin@ximian.com>
7041 * class.cs (Method.Define): If we're a generic method, call
7042 TypeBuilder.DefineGenericMethod () before resolving
7044 (MethodData): Added .ctor which takes an additional MethodBuilder
7045 argument; this is used for generic methods.
7046 (MethodData.Define): Call `builder.SetGenericMethodSignature()' if
7047 we already have a MethodBuilder.
7049 2003-10-10 Martin Baulig <martin@ximian.com>
7051 * class.cs (Method): Added .ctor which takes a `GenericMethod'
7052 instead of a `DeclSpace'. This is used for generic methods.
7054 * cs-parser.jay (method_header): Added support for generic
7055 methods; create a `GenericMethod' instance and pass it to the
7056 `Method's .ctor; it'll be used as the `DeclSpace' to lookup
7057 parameters and locals.
7059 * decl.cs (DeclSpace.SetParameterInfo): Removed Location argument
7060 since we already have the location. Check whether we're a generic
7061 type declaration or a generic method and create the correct type
7064 * generic.cs (TypeParameter.DefineMethod): New public method.
7065 (GenericMethod): New public class; derives from DeclSpace and is
7066 used for generic methods.
7068 2003-10-09 Martin Baulig <martin@ximian.com>
7070 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
7072 (MethodCore.DoDefineParameters): Removed the TypeContainer
7073 argument; use the DeclSpace which was passed to the .ctor instead.
7074 (MethodCore.CheckParameter): Take a DeclSpace instead of a
7075 TypeContainer; we only need a DeclSpace here.
7077 2003-10-09 Martin Baulig <martin@ximian.com>
7079 * class.cs (MethodData): Added additional `DeclSpace ds' argument
7081 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
7082 EmitContext's .ctor.
7084 2003-10-09 Martin Baulig <martin@ximian.com>
7086 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
7087 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
7088 AsAccessible(), moved them as well.
7090 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
7092 2003-10-07 Miguel de Icaza <miguel@ximian.com>
7094 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
7095 generation for >=, as spotted by Paolo, bug 48679.
7096 Patch from David Waite.
7098 * cs-tokenizer.cs: Add handling for #pragma.
7100 * cs-parser.jay: Allow for both yield and yield return in the
7101 syntax. The anti-cobolization of C# fight will go on!
7103 * class.cs (TypeBuilder.DefineType): Catch error condition here
7104 (Parent.DefineType erroring out and returning null).
7106 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
7107 coping with enumerations variables, we were mistakenly processing
7108 them as a regular value type instead of built-in types. Fixes the
7111 * typemanager.cs (IsBuiltinOrEnum): New method.
7113 2003-09-30 Miguel de Icaza <miguel@ximian.com>
7115 * cs-parser.jay: Upgrade: yield now needs the return clause.
7117 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
7119 * cs-parser.jay : Renamed yyName to yyNames related to jay.
7121 2003-09-29 Martin Baulig <martin@ximian.com>
7123 * typemanager.cs (TypeManager.GetMethodFlags): Added support for
7124 inflated generic methods.
7126 * generics.cs (ConstructedType): Distinguish between open and
7127 closed constructed types; correctly resolve the arguments.
7129 2003-09-22 Martin Baulig <martin@ximian.com>
7131 * generic.cs (ConstructedType.ResolveAsTypeCheck): Check whether
7132 all type arguments meet their constraints.
7134 2003-09-19 Martin Baulig <martin@ximian.com>
7136 * decl.cs (MemberCache.SetupCacheForInterface): Take a
7137 `MemberCache parent' argument. Normally, an interface doesn't
7138 have a parent type except System.Object, but we use this in gmcs
7139 for generic type parameters.
7141 2003-09-18 Martin Baulig <martin@ximian.com>
7143 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
7144 on `type.IsInterface'; don't check whether the type has a parent
7145 to determine whether it's an interface.
7147 2003-09-17 Martin Baulig <martin@ximian.com>
7149 * generic.cs (ConstructedType.ToString): Always use `name' as the
7152 2003-09-15 Martin Baulig <martin@ximian.com>
7154 * cs-parser.jay: Fix grammar wrt. type_parameter_constraints.
7156 * generic.cs (Constraints.Resolve): New public method; this is
7157 called to resolve the constraint types and to check whether all
7158 the constraints are correct.
7159 (Constraints.Types): New public property.
7160 (TypeParameter.Resolve): New public method; resolves all the
7163 * class.cs (TypeContainer.DefineType): Call
7164 TypeParameter.Resolve() before actually defining the type.
7166 2003-09-15 Martin Baulig <martin@ximian.com>
7168 * class.cs (TypeContainer.DefineType): Added an error flag to
7169 avoid reporting duplicate CS0146's ("class definition is
7172 * driver.cs (Driver.MainDriver): Abort if
7173 RootContext.ResolveTree() reported any errors.
7175 2003-09-07 Martin Baulig <martin@ximian.com>
7177 * report.cs (Error, Warning): Added overloaded versions which take
7178 a `params object[] args' and call String.Format().
7180 2003-09-07 Martin Baulig <martin@ximian.com>
7182 * decl.cs (DeclSpace..ctor): Don't call
7183 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
7184 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
7185 (DeclSpace.RecordDecl): New method.
7187 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
7189 2003-09-02 Ravi Pratap <ravi@ximian.com>
7191 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
7192 value attributes to be applied to ParameterBuilders.
7194 * class.cs (MethodCore.LabelParameters): Make static and more
7195 generic so that it can be used from other places - like interface
7196 methods, for instance.
7198 * interface.cs (Interface.Emit): Call LabelParameters before
7199 emitting attributes on the InterfaceMethod.
7201 2003-09-07 Martin Baulig <martin@ximian.com>
7203 * generic.cs (ConstructedType.ResolveAsTypeStep): Report a CS8217
7204 if the number of type parameters doesn't match.
7206 2003-09-04 Martin Baulig <martin@ximian.com>
7208 * expression.cs (ComposedCast.ResolveAsTypeStep): Added support
7209 for arrays of generic type params (ie. `!0[]').
7211 2003-09-04 Martin Baulig <martin@ximian.com>
7213 * class.cs (TypeContainer.AsAccessible): Ignore generic parameters
7216 2003-09-04 Martin Baulig <martin@ximian.com>
7218 * decl.cs (DeclSpace.LookupGeneric): New method.
7219 (DeclSpace.CheckAccessLevel): Ignore generic parameters for the
7222 * generic.cs (TypeParameterExpr): Take a TypeParameter as
7223 argument, not just a string.
7224 (TypeParameter.Define): New public method; this is called to
7225 actually define the generic parameter; after this, you can use the
7226 new `Type' property to get the type.
7228 2003-09-04 Martin Baulig <martin@ximian.com>
7230 * decl.cs (DeclSpace.SetParameterInfo): The `constraints' argument
7231 is now an ArrayList; initialize the result of the `TypeParameters'
7233 (DeclSpace.GetGenericData): Removed.
7234 (DeclSpace.LookupGeneric): Temporarily removed; we need to
7235 implement this in a different way.
7236 (DeclSpace.GetTypeParameters): Removed; there's now a
7237 `TypeParameters' property.
7238 (DeclSpace.TypeParameters): New public property.
7240 * generic.cs (Constraints): Make this class public.
7241 (TypeParameter): New public class.
7243 2003-09-04 Martin Baulig <martin@ximian.com>
7245 * decl.cs (DeclSpace.GetTypeParameters): New method to return the
7248 * class.cs (TypeContainer.DefineType): Call
7249 TypeBuilder.DefineGenericParameter () on all generic parameters if
7250 this is a generic type.
7252 2003-08-28 Martin Baulig <martin@ximian.com>
7254 * sample-stack.il: Compile this with ilasm: "ilasm /dll
7257 * sample-hello.cs: Compile this with gmcs: "gmcs
7258 /r:sample-stack.dll sample-hello.cs".
7260 2003-08-28 Martin Baulig <martin@ximian.com>
7262 * generic.cs (ConstructedType.ResolveAsTypeStep): Actually bind
7263 the parameters to the generic type.
7265 2003-08-28 Martin Baulig <martin@ximian.com>
7267 * cs-tokenizer.cs (parse_less_than): Also allow all builtin types.
7269 2003-08-28 Martin Baulig <martin@ximian.com>
7271 * cs-parser.jay (opt_type_argument_list): Use
7272 `OP_GENERICS_LT type_arguments OP_GENERICS_GT'.
7273 (primary_expression): Replace `qualified_identifier' with `type_name'.
7274 (type_parameter_list): Use `OP_GENERICS_LT type_parameters OP_GENERICS_GT'.
7276 * cs-tokenizer.cs (is_punct): When reading a `<', invoke a custom
7277 parser to check whether it is syntactically a type parameter list;
7278 return OP_GENERICS_LT/OP_GENERICS_GT instead of OP_LT/OP_GT in
7281 2003-08-26 Martin Baulig <martin@ximian.com>
7283 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
7284 resolving aliases; fixes #47927.
7286 2003-08-26 Martin Baulig <martin@ximian.com>
7288 * statement.cs (Using.DoResolve): This is internally emitting a
7289 try/finally clause, so we need to set ec.NeedExplicitReturn if we
7290 do not always return. Fixes #47681.
7292 2003-08-26 Martin Baulig <martin@ximian.com>
7294 * decl.cs (MemberCore): Moved WarningNotHiding(),
7295 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
7297 (AdditionResult): Make this nested in DeclSpace.
7298 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
7299 argument; call NamespaceEntry.Define() unless we're nested in a
7302 * namespace.cs (Namespace.DefineName): New public function. This
7303 is called from DeclSpace's .ctor to add
7304 (Namespace.Lookup): Include DeclSpaces in the lookup.
7306 * class.cs (Operator): Derive from MemberBase, not MemberCore.
7308 * const.cs (Const): Derive from MemberBase, not MemberCore.
7310 2003-08-25 Martin Baulig <martin@ximian.com>
7312 * convert.cs (Convert.ExplicitReferenceConversion): When
7313 converting from an interface type to a class, unbox if the target
7314 type is a struct type. Fixes #47822.
7316 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7318 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
7321 2003-08-22 Martin Baulig <martin@ximian.com>
7323 * class.cs (TypeManager.DefineType): When defining a nested type,
7324 call DefineType() on our parent; fixes #47801.
7326 2003-08-22 Martin Baulig <martin@ximian.com>
7328 * class.cs (MethodData.Define): While checking if a method is an
7329 interface implementation, improve the test a bit more to fix #47654.
7331 2003-08-22 Martin Baulig <martin@ximian.com>
7333 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
7334 correctly; fixes #47722.
7336 2003-08-22 Martin Baulig <martin@ximian.com>
7338 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
7339 LocalVariableReference, ensure it's not read-only. Fixes #47536.
7341 * statement.cs (Fixed.DoResolve): Make all variables read-only.
7343 2003-08-22 Martin Baulig <martin@ximian.com>
7345 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
7346 can only be assigned in static constructors. Fixes #47161.
7348 2003-08-22 Martin Baulig <martin@ximian.com>
7350 Rewrote and improved the flow analysis code.
7352 * flowbranching.cs (FlowBranching): Make this class abstract.
7353 (FlowBranching.CreateBranching): New static function to create a
7355 (FlowBranchingBlock, FlowBranchingException): New classes.
7356 (FlowBranching.UsageVector.Type): New public readonly field.
7357 (FlowBranching.UsageVector.Breaks): Removed the setter.
7358 (FlowBranching.UsageVector.Returns): Removed the setter.
7359 (FlowBranching.UsageVector): Added Break(), Return(),
7360 NeverReachable() and Throw() methods to modify the reachability.
7361 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
7362 done by FlowBranching.Merge().
7363 (FlowBranching.UsageVector.MergeChild): New method; merges the
7364 merge result into the current vector.
7365 (FlowBranching.Merge): New abstract method to merge a branching.
7367 2003-08-12 Martin Baulig <martin@ximian.com>
7369 * expression.cs (Indirection.CacheTemporaries): Create the
7370 LocalTemporary with the pointer type, not its element type.
7372 2003-08-10 Miguel de Icaza <miguel@ximian.com>
7374 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
7375 token was a keyword or not.
7377 Add `error' options where an IDENTIFIER was expected; Provide
7378 CheckToken and CheckIdentifierToken convenience error reporting
7381 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
7383 * decl.cs: Rename `NamespaceEntry Namespace' public field into
7384 NameSpaceEntry NameSpaceEntry.
7386 (LookupInterfaceOrClass): Avoid creating a full qualified name
7387 from namespace and name: avoid doing lookups when we know the
7388 namespace is non-existant. Use new Tree.LookupByNamespace which
7389 looks up DeclSpaces based on their namespace, name pair.
7391 * driver.cs: Provide a new `parser verbose' to display the
7392 exception thrown during parsing. This is turned off by default
7393 now, so the output of a failure from mcs is more graceful.
7395 * namespace.cs: Track all the namespaces defined in a hashtable
7398 (IsNamespace): New method
7400 2003-08-09 Miguel de Icaza <miguel@ximian.com>
7402 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
7403 we know that we need to concatenate (full typename can never be
7408 * statement.cs: Use a bitfield; Do not initialize to null things
7409 which are done by the constructor by default.
7411 * cs-parser.jay: bug fix, parameter was 4, not 3.
7413 * expression.cs: Just use the property;
7415 * statement.cs: No need for GetVariableInfo method.
7417 2003-08-08 Martin Baulig <martin@ximian.com>
7419 * flowanalysis.cs (FlowReturns): This is now nested in the
7420 `FlowBranching' class.
7421 (MyBitVector): Moved this here from statement.cs.
7422 (FlowBranching.SiblingType): New enum type.
7423 (FlowBranching.CreateSibling): Added `SiblingType' argument.
7425 2003-08-07 Martin Baulig <martin@ximian.com>
7427 * flowanalysis.cs (FlowBranchingType): This is now nested in the
7428 `FlowBranching' class and called `BranchingType'.
7430 2003-08-07 Martin Baulig <martin@ximian.com>
7432 * flowanalysis.cs: Moved all the control flow analysis code into
7435 2003-08-07 Martin Baulig <martin@ximian.com>
7437 * assign.cs (Assign.DoResolve): `target' must either be an
7438 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
7441 2003-08-07 Miguel de Icaza <miguel@ximian.com>
7443 * expression.cs (BinaryMethod): This kind of expression is created by the
7444 Binary class if it determines that the operator has to be handled
7447 (BinaryDelegate): This kind of expression is created if we are
7448 dealing with a + or - operator on delegates.
7450 (Binary): remove method, argumetns, and DelegateOperator: when
7451 dealing with methods,
7453 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
7455 * statement.cs (Block): use bitfields for the three extra booleans
7456 we had in use. Remove unused topblock parameter.
7458 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
7460 * assign.cs: Drop extra unneeded tests.
7462 2003-08-06 Miguel de Icaza <miguel@ximian.com>
7464 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
7466 * statement.cs (Foreach): Use VariableStorage instead of
7469 * codegen.cs (VariableStorage): New class used by clients that
7470 require a variable stored: locals or fields for variables that
7471 need to live across yield.
7473 Maybe provide a convenience api for EmitThis+EmitLoad?
7475 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
7478 2003-08-05 Miguel de Icaza <miguel@ximian.com>
7480 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
7481 RemapParameterLValue): New methods that are used to turn a
7482 precomputed FieldInfo into an expression like this:
7486 The idea is to use this instead of making LocalVariableReference
7487 have more than one meaning.
7489 * cs-parser.jay: Add error production to BASE.
7491 * ecore.cs: Deal with TypeManager.GetField returning null, which
7492 is now a valid return value.
7494 (FieldExprNoAddress): New expression for Fields whose address can
7497 * expression.cs (LocalVariableReference): During the resolve
7498 phases, create new expressions if we are in a remapping context.
7499 Remove code that dealt with remapping here.
7501 (ParameterReference): same.
7503 (ProxyInstance): New expression, like the `This' expression, but
7504 it is born fully resolved. We know what we are doing, so remove
7505 the errors that are targeted to user-provided uses of `this'.
7507 * statement.cs (Foreach): our variable is now stored as an
7508 Expression; During resolution, follow the protocol, dont just
7509 assume it will return this.
7511 2003-08-06 Martin Baulig <martin@ximian.com>
7513 * support.cs (SeekableStreamReader.cs): New public class.
7515 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
7516 SeekableStreamReader instead of the normal StreamReader.
7518 2003-08-04 Martin Baulig <martin@ximian.com>
7520 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
7521 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
7522 deambiguate casts and delegate invocations.
7523 (parenthesized_expression): Use the new tokens to ensure this is
7524 not a cast of method invocation.
7526 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
7527 when reading a `)' and Deambiguate_CloseParens () was previously
7530 * expression.cs (ParenthesizedExpression): New class. This is
7531 just used for the CS0075 test.
7532 (Binary.DoResolve): Check for CS0075.
7534 2003-07-29 Ravi Pratap <ravi@ximian.com>
7536 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
7537 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
7538 reference comparison.
7540 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
7541 examine the ReturnType for equality - this is necessary in the
7542 cases of implicit and explicit operators whose signature also
7543 includes the return type.
7545 2003-07-26 Miguel de Icaza <miguel@ximian.com>
7547 * namespace.cs: Cache the result of the namespace computation,
7548 instead of computing it every time.
7550 2003-07-24 Miguel de Icaza <miguel@ximian.com>
7552 * decl.cs: Use a global arraylist that we reuse over invocations
7553 to avoid excesive memory consumption. Reduces memory usage on an
7554 mcs compile by one meg (45 average).
7556 * typemanager.cs (LookupTypeReflection): In .NET pointers are
7557 private, work around that.
7559 2003-07-23 Miguel de Icaza <miguel@ximian.com>
7561 * literal.cs (IntLiteral): Define Zero and One static literals.
7563 * cs-parser.jay (integer_literal): use static literals to reduce
7564 memory usage for the most used literals (0, 1 and -1). 211kb
7565 reduced in memory usage.
7567 Replace all calls to `new ArrayList' with `new
7568 ArrayList(4)' which is a good average number for most allocations,
7569 and also requires only 16 bytes of memory for its buffer by
7572 This reduced MCS memory usage in seven megabytes for the RSS after
7575 2003-07-28 Ravi Pratap <ravi@ximian.com>
7577 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
7578 handle params methods the correct way by forming only one
7579 applicable set with params and normal methods in them. Earlier we
7580 were looking at params methods only if we found no normal methods
7581 which was not the correct thing to do.
7583 (Invocation.BetterFunction): Take separate arguments indicating
7584 when candidate and the best method are params methods in their
7587 This fixes bugs #43367 and #46199.
7589 * attribute.cs: Documentation updates.
7591 (CheckAttribute): Rename to CheckAttributeTarget.
7592 (GetValidPlaces): Rename to GetValidTargets.
7594 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
7595 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
7599 2003-07-28 Miguel de Icaza <miguel@ximian.com>
7601 * codegen.cs: Compute IsGeneric correctly.
7603 * cs-parser.jay: Introduce OP_GENERIC_LT for the grammar ambiguity
7606 Bring back (temporarily) OP_LEFT_SHIFT, OP_RIGHT_SHIFT,
7607 OP_SHIFT_RIGHT_ASSIGN, OP_SHIFT_LEFT_ASSIGN. There were too many
7608 regressions, and I was chasing more bugs than I required.
7610 * interface.cs: Use expressions for base type names (like classes
7611 and structs have been doing for a while now), and resolve that.
7612 This patch should probably go into head as well.
7614 This makes it one less user of FindType.
7616 2003-07-24 Miguel de Icaza <miguel@ximian.com>
7618 This compiler can not self host currently. Need to fix that.
7620 * Makefile: compile to `gmcs.exe'
7622 * driver.cs: Turn on v2 by default on gmcs.
7624 * generic.cs (ConstructedType): Does no longer take a container
7625 type argument; That will be taken care of later.
7627 (ConstructedType.DoResolve, ConstructedType.ResolveAsTypeStep):
7628 Use SimpleName to resolve for now, so we can continue the work on
7629 the parser, until we get Type.GetType that understands generics.
7631 (ConstructedType.ToString): Implement
7633 (TypeArguments.Resolve): Resolve the child expressions as types.
7635 * cs-parser.jay: Rename interface_constraints to
7636 type_parameter_constraints
7638 (namespace_or_type_name): Only use constructed types for the basic
7639 construction, we will deal with identifier<...> later.
7641 (type/type_name): No longer call DecomposeQI, as
7642 namespace_or_type_name is always decoded now.
7644 2003-07-22 Ravi Pratap <ravi@ximian.com>
7646 * expression.cs (Invocation.OverloadResolve): Follow the spec more
7647 closely: we eliminate methods in base types when we have an
7648 applicable method in a top-level type.
7650 Please see section 14.5.5.1 for an exact description of what goes
7653 This fixes bug #45127 and a host of other related to corlib compilation.
7655 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
7656 array is the method corresponding to the top-level type (this is
7657 because of the changes made to icall.c) so we change this
7660 (MethodGroupExpr.Name): This too.
7662 * typemanager.cs (GetElementType): New method which does the right
7663 thing when compiling corlib.
7665 * everywhere: Make use of the above in the relevant places.
7667 2003-07-22 Martin Baulig <martin@ximian.com>
7669 * cs-parser.jay (invocation_expression): Moved
7670 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
7671 `cast_expression', but create a InvocationOrCast which later
7672 resolves to either an Invocation or a Cast.
7674 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
7675 method; call this before EmitStatement() to make sure that this
7676 expression can be used as a statement.
7678 * expression.cs (InvocationOrCast): New class; resolves to either
7679 an Invocation or a Cast.
7681 * statement.cs (StatementExpression): Call ResolveStatement() on
7682 the ExpressionStatement before emitting it.
7684 2003-07-21 Martin Baulig <martin@ximian.com>
7686 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
7687 `ref' and `out' attributes match; fixes #46220.
7688 (MemberAccess.ResolveMemberAccess): You can't reference a type
7689 through an expression; fixes #33180.
7690 (Indexers.GetIndexersForType): Don't return the indexers from
7691 interfaces the class implements; fixes #46502.
7693 2003-07-21 Martin Baulig <martin@ximian.com>
7695 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
7696 CS0661 checks; fixes bug #30442.
7698 2003-07-21 Martin Baulig <martin@ximian.com>
7700 * decl.cs (AdditionResult): Added `Error'.
7702 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
7704 * typemanager.cs (TypeManager.ChangeType): Catch exceptions; makes
7705 cs0031.cs actually work.
7707 2003-07-20 Miguel de Icaza <miguel@ximian.com>
7709 * cs-parser.jay (namespace_name): do not use
7710 namespace_or_type_name, use qualified_identifier, because
7711 namespace_or_type_name will soon return a composed expression
7712 instead of a string.
7714 (namespace_or_type_name): Instead of returning a string, now this
7715 production returns an expression.
7717 * codegen.cs (EmitContext): Setup IsGeneric property based on
7718 whether our DeclSpace is generic, our the method is generic.
7720 * modifier.cs (Modifiers.METHOD_GENERIC): New definition, use if
7721 the method is generic.
7723 * cs-parser.jay (type_arguments, opt_type_argument_list,
7724 type_parameters, type_parameter_list, opt_type_parameter_list,
7725 type_parameter,, opt_type_parameter_constraints_clauses,
7726 type_parameter_constraints_clauses,
7727 type_parameter_constraint_clause, type_parameter_constraint,
7728 interface_constraints): Add new production
7730 * decl.cs (DeclSpace): IsGeneric, flag to track whether this
7731 DeclSpace is generic or not.
7733 (DeclSpace.SetParameterInfo): New routine, used to set the
7734 parameter info for a type.
7736 (DeclSpace.LookupGeneric): Lookups a name, and if it is a generic,
7737 returns a GenericTypeExpr
7739 * ecore.cs (SimpleName.ResolveAsTypeStep): If our container is
7740 generic, lookup the generic argument.
7742 * attribute.cs: Do not allow TypeParameterExpressions in
7745 * class.cs: Do not allow the Main method to be defined in a
7748 * expression.cs (SizeOf): Do not allow generic types to be used as
7749 arguments to sizeof.
7751 * typemanager.cs (IsGeneric): Wrapper for Reflection when we have
7752 it: whether a type is generic or not. Only works for types we are
7753 currently building for now.
7755 2003-07-20 Martin Baulig <martin@ximian.com>
7757 * namespace.cs: Fixed that bug which caused a crash when compiling
7760 2003-07-20 Miguel de Icaza <miguel@ximian.com>
7762 * typemanager.cs (LookupTypeReflection): Never expose types which
7763 are NotPublic, NestedPrivate, NestedAssembly, or
7764 NestedFamANDAssem. We used to return these, and later do a check
7765 that would report a meaningful error, but the problem is that we
7766 would not get the real match, if there was a name override.
7768 2003-07-18 Miguel de Icaza <miguel@ximian.com>
7770 * namespace.cs (Namespace, Name): Do not compute the namespace
7771 name dynamically, compute it in the constructor. This reduced
7772 memory usage by 1697 KB.
7774 * driver.cs: Use --pause to pause at the end.
7776 2003-07-17 Peter Williams <peter@newton.cx>
7778 * Makefile: Change the name of the test target so that it doesn't
7779 conflict with the recursive test target.
7781 2003-07-17 Miguel de Icaza <miguel@ximian.com>
7783 * expression.cs (LocalVariableReference.Emit, EmitAssign,
7784 AddressOf): Do not use EmitThis, that was wrong, use the actual
7787 2003-07-15 Miguel de Icaza <miguel@ximian.com>
7789 * class.cs (MethodData.Define): While checking if a method is an
7790 interface implementation, improve the test: If we are not public
7791 (use new test here: use the computed MethodAttributes directly,
7792 instead of the parsed modifier flags) check if the `implementing'
7793 method comes from an interface or not.
7795 * pending.cs (VerifyPendingMethods): Slightly better error
7798 * makefile: add test target that does the mcs bootstrap.
7800 2003-07-16 Ravi Pratap <ravi@ximian.com>
7802 * interface.cs (Define): Do nothing here since there are no
7803 members to populate etc. Move the attribute emission out of here
7804 since this was just totally the wrong place to put it. Attribute
7805 application happens during the 'Emit' phase, not in the 'Define'
7808 (Emit): Add this method and move the attribute emission here
7810 * rootcontext.cs (EmitCode): Call the Emit method on interface
7813 2003-07-14 Ravi Pratap M <ravi@ximian.com>
7815 * expression.cs (OverloadResolve): Report error only if Location
7816 is not 'Null' which means that there was a probe going on.
7818 2003-07-14 Martin Baulig <martin@ximian.com>
7820 * expression.cs (ConditionalLogicalOperator): New public class to
7821 implement user defined conditional logical operators.
7822 This is section 14.11.2 in the spec and bug #40505.
7824 2003-07-14 Martin Baulig <martin@ximian.com>
7826 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
7828 2003-07-14 Martin Baulig <martin@ximian.com>
7830 * codegen.cs (EmitContext.InFixedInitializer): New public field.
7832 * ecore.cs (IVariable.VerifyFixed): New interface method.
7834 * expression.cs (Unary.ResolveOperator): When resolving the `&'
7835 operator, check whether the variable is actually fixed. Fixes bug
7836 #36055. Set a variable definitely assigned when taking its
7837 address as required by the spec.
7839 * statement.cs (LocalInfo.IsFixed): New field.
7840 (LocalInfo.MakePinned): Set `IsFixed' to true.
7842 2003-07-14 Ravi Pratap M <ravi@ximian.com>
7844 * attribute.cs (Attribute.Resolve): While doing a Member lookup
7845 for .ctors, ensure that we only ask for members declared in the
7846 attribute type (BindingFlags.DeclaredOnly).
7850 * expression.cs (Error_WrongNumArguments): Report error 1501
7851 correctly the way CSC does.
7853 2003-07-13 Martin Baulig <martin@ximian.com>
7855 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
7856 lookup on the fully qualified name, to make things like "X.X" work
7857 where "X.X" is a fully qualified type name, but we also have a
7858 namespace "X" in the using list. Fixes #41975.
7860 2003-07-13 Martin Baulig <martin@ximian.com>
7862 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
7863 function. If we're a CompoundAssign, we need to create an embedded
7864 CompoundAssign, not an embedded Assign.
7865 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
7868 2003-07-13 Martin Baulig <martin@ximian.com>
7870 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
7871 work to fix bug #46088.
7873 2003-07-13 Ravi Pratap <ravi@ximian.com>
7875 * class.cs (Operator.Emit): Do not emit attributes here - it is
7876 taken care of by the Method class that we delegate too. This takes
7879 2003-07-10 Martin Baulig <martin@ximian.com>
7881 * expression.cs (TypeOfVoid): New class.
7882 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
7884 2003-07-10 Martin Baulig <martin@ximian.com>
7886 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
7889 2003-07-10 Martin Baulig <martin@ximian.com>
7891 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
7892 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
7894 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
7896 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
7898 2003-07-10 Martin Baulig <martin@ximian.com>
7900 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
7901 of decimal. Fixes #42850.
7903 NOTE: I also fixed the created byte blob, but this doesn't work on
7904 the MS runtime and csc never produces any byte blobs for decimal
7907 2003-07-10 Martin Baulig <martin@ximian.com>
7909 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
7910 structs; fixes #32068.
7911 (Block.AddChildVariableNames): Fixed #44302.
7913 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7915 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
7917 2003-07-07 Miguel de Icaza <miguel@ximian.com>
7919 * attribute.cs: And this test is onger needed.
7921 2003-07-08 Martin Baulig <martin@ximian.com>
7923 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
7924 inaccessible types. Fixes #36313.
7926 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
7928 * namespace.cs (NamespaceEntry): Create implicit entries for all
7929 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
7930 implicit entries for N1.N2 and N1.
7932 2003-07-08 Martin Baulig <martin@ximian.com>
7934 Rewrote the handling of namespaces to fix a lot of the issues
7935 wrt. `using' aliases etc.
7937 * namespace.cs (Namespace): Splitted this class into a
7938 per-assembly `Namespace' and a per-file `NamespaceEntry'.
7940 * typemanager.cs (TypeManager.IsNamespace): Removed.
7941 (TypeManager.ComputeNamespaces): Only compute namespaces from
7942 loaded assemblies here, not the namespaces from the assembly we're
7943 currently compiling.
7945 2003-07-08 Martin Baulig <martin@ximian.com>
7947 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
7949 2003-07-07 Miguel de Icaza <miguel@ximian.com>
7951 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
7954 I thought about the memory savings here, but LookupTypeReflection
7955 is used under already very constrained scenarios. Compiling
7956 corlib or mcs only exposes one hit, so it would not really reduce
7957 any memory consumption.
7959 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7961 * typemanager.cs: fixes bug #45889 by only adding public types from
7962 other assemblies to the list of known types.
7964 2003-07-07 Miguel de Icaza <miguel@ximian.com>
7966 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
7967 on the type we resolved.
7969 2003-07-05 Martin Baulig <martin@ximian.com>
7971 * pending.cs (PendingImplementation.ParentImplements): Don't
7972 create the proxy if the parent is abstract.
7974 * class.cs (TypeContainer.DefineIndexers): Process explicit
7975 interface implementations first. Fixes #37714.
7977 2003-07-04 Miguel de Icaza <miguel@ximian.com>
7979 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
7980 defined recursively; but since we modify the input parameters
7981 (left is set to `this' temporarily), we reset this value if the
7982 left_is_explicit is false, which gives the original semantics to
7985 * literal.cs (NullPointer): new class used to represent a null
7986 literal in a pointer context.
7988 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
7989 type is a pointer, use a NullPointer object instead of a
7990 NullLiteral. Closes 43687
7992 (ExplicitConversion): Convert pointer values using
7993 the conv opcode to the proper type.
7995 * ecore.cs (New): change ValueTypeVariable property into a method,
7996 that returns whether the valuetype is suitable for being used.
7998 * expression.cs (Binary.DoNumericPromotions): Only return if we
7999 the int constant was a valid uint, and we can return both left and
8000 right as uints. If not, we continue processing, to trigger the
8001 type conversion. This fixes 39018.
8003 * statement.cs (Block.EmitMeta): During constant resolution, set
8004 the CurrentBlock property on the emitcontext, so that we resolve
8005 constants propertly.
8007 2003-07-02 Martin Baulig <martin@ximian.com>
8009 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
8010 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
8012 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
8013 than emitting it here.
8015 * statement.cs: Fixed some more flow analysis bugs.
8017 2003-07-02 Martin Baulig <martin@ximian.com>
8019 * class.cs (MethodData.Define): When implementing interface
8020 methods, set Final unless we're Virtual.
8022 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
8023 check work for interface methods.
8025 2003-07-01 Martin Baulig <martin@ximian.com>
8027 * ecore.cs (EmitContext.This): Replaced this property with a
8028 GetThis() method which takes a Location argument. This ensures
8029 that we get the correct error location for a CS0188.
8031 2003-07-01 Miguel de Icaza <miguel@ximian.com>
8033 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
8034 ImplicitStandardConversion.
8036 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
8038 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
8040 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
8043 2003-06-30 Miguel de Icaza <miguel@ximian.com>
8045 * class.cs (Constructor.Define): Turn off initlocals for unsafe
8048 (MethodData.Define): Turn off initlocals for unsafe methods.
8050 2003-06-29 Miguel de Icaza <miguel@ximian.com>
8052 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
8053 complete; Fixes #37521.
8055 * delegate.cs: Use Modifiers.TypeAttr to compute the
8056 TypeAttributes, instead of rolling our own. This makes the flags
8057 correct for the delegates.
8059 2003-06-28 Miguel de Icaza <miguel@ximian.com>
8061 * class.cs (Constructor.Define): Set the private flag for static
8062 constructors as well.
8064 * cs-parser.jay (statement_expression): Set the return value to
8065 null, to avoid a crash when we catch an error.
8067 2003-06-24 Miguel de Icaza <miguel@ximian.com>
8069 * cs-parser.jay: Applied patch from Jackson that adds support for
8070 extern and unsafe modifiers to destructor declarations.
8072 * expression.cs: Report error 21 if the user is trying to index a
8075 * driver.cs: Add an error message, suggested by the bug report.
8077 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
8078 if we do not have a ": this ()" constructor initializer. Fixes 45149
8080 2003-06-14 Miguel de Icaza <miguel@ximian.com>
8082 * namespace.cs: Add some information to reduce FAQs.
8084 2003-06-13 Miguel de Icaza <miguel@ximian.com>
8086 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
8087 underlying enumeration types. Fixes #43915.
8089 * expression.cs: Treat ushort/short as legal values to be used in
8092 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
8094 * delegate.cs: transfer custom attributes for paramenters from
8095 the delegate declaration to Invoke and BeginInvoke.
8097 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
8099 * attribute.cs: handle custom marshalers and emit marshal info
8102 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
8104 * makefile.gnu: Added anonymous.cs to the compiler sources.
8106 2003-05-28 Miguel de Icaza <miguel@ximian.com>
8108 * iterators.cs: Change the name of the proxy class to include two
8111 * cs-parser.jay: Update grammar to include anonymous methods.
8113 * anonymous.cs: new file.
8115 2003-05-27 Miguel de Icaza <miguel@ximian.com>
8117 * class.cs (Field.Define): Add missing test for pointers and
8120 2003-05-27 Ravi Pratap <ravi@ximian.com>
8122 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
8123 we use the stobj opcode.
8125 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
8126 since it wasn't the correct fix.
8128 It still is puzzling that we are required to use stobj for IntPtr
8129 which seems to be a ValueType.
8131 2003-05-26 Miguel de Icaza <miguel@ximian.com>
8133 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
8134 during regular simple name resolution. Now, the trick is that
8135 instead of returning for processing the simplename, we do a
8136 TypeManager.LookupType (ie, a rooted lookup as opposed to a
8137 contextual lookup type). If a match is found, return that, if
8138 not, return for further composition.
8140 This fixes long-standing 30485.
8142 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
8143 using the address to initialize an object, do an Stobj instead of
8144 using the regular Stelem.
8146 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
8147 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
8148 Because if we are a BaseIndexerAccess that value will be true.
8151 * statement.cs (GotoCase.Resolve): Return after reporting an
8152 error, do not attempt to continue.
8154 * expression.cs (PointerArithmetic.Emit): If our operand is a
8155 long, convert our constants to match the operand before
8156 multiplying. Convert to I type before adding. Fixes 43670.
8158 2003-05-14 Ravi Pratap <ravi@ximian.com>
8160 * enum.cs (ImplicitConversionExists) : Rename to
8161 ImplicitEnumConversionExists to remove ambiguity.
8163 * ecore.cs (NullCast): New type of cast expression class which
8164 basically is very similar to EmptyCast with the difference being
8165 it still is a constant since it is used only to cast a null to
8169 * convert.cs (ImplicitReferenceConversion): When casting a null
8170 literal, we return a NullCast.
8172 * literal.cs (NullLiteralTyped): Remove - I don't see why this
8173 should be around anymore.
8175 The renaming (reported was slightly wrong). Corrections:
8177 ConvertImplicitStandard -> ImplicitConversionStandard
8178 ConvertExplicitStandard -> ExplicitConversionStandard
8180 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
8181 before passing them in !
8183 * convert.cs (ImplicitConversionStandard): When comparing for
8184 equal expr and target types, ensure that expr is not a
8187 In general, we must not be checking (expr_type ==
8188 target_type) in the top level conversion methods
8189 (ImplicitConversion, ExplicitConversion etc). This checking is
8190 done in the methods that they delegate to.
8192 2003-05-20 Miguel de Icaza <miguel@ximian.com>
8194 * convert.cs: Move Error_CannotConvertType,
8195 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
8196 ImplicitNumericConversion, ImplicitConversionExists,
8197 ImplicitUserConversionExists, StandardConversionExists,
8198 FindMostEncompassedType, FindMostSpecificSource,
8199 FindMostSpecificTarget, ImplicitUserConversion,
8200 ExplicitUserConversion, GetConversionOperators,
8201 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
8202 TryImplicitIntConversion, Error_CannotConvertImplicit,
8203 ConvertImplicitRequired, ConvertNumericExplicit,
8204 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
8205 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
8208 Perform the following renames:
8210 StandardConversionExists -> ImplicitStandardConversionExists
8211 ConvertImplicit -> ImplicitConversion
8212 ConvertImplicitStandard -> ImplicitStandardConversion
8213 TryImplicitIntConversion -> ImplicitIntConversion
8214 ConvertImplicitRequired -> ImplicitConversionRequired
8215 ConvertNumericExplicit -> ExplicitNumericConversion
8216 ConvertReferenceExplicit -> ExplicitReferenceConversion
8217 ConvertExplicit -> ExplicitConversion
8218 ConvertExplicitStandard -> ExplicitStandardConversion
8220 2003-05-19 Martin Baulig <martin@ximian.com>
8222 * statement.cs (TypeInfo.StructInfo): Made this type protected.
8223 (TypeInfo): Added support for structs having structs as fields.
8225 * ecore.cs (FieldExpr): Implement IVariable.
8226 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
8227 VariableInfo for the field.
8229 2003-05-18 Martin Baulig <martin@ximian.com>
8231 * expression.cs (This.DoResolve): Report a CS0027 if we're
8232 emitting a field initializer.
8234 2003-05-18 Martin Baulig <martin@ximian.com>
8236 * expression.cs (This.ResolveBase): New public function.
8237 (This.DoResolve): Check for CS0188.
8239 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
8242 * ecore.cs (MethodGroupExpr.DoResolve): Set the
8243 `instance_expression' to null if we don't have any non-static
8246 2003-05-18 Martin Baulig <martin@ximian.com>
8248 Reworked the way how local variables and parameters are handled by
8249 the flow analysis code.
8251 * statement.cs (TypeInfo, VariableMap): New public classes.
8252 (VariableInfo): New public class. This is now responsible for
8253 checking whether a variable has been assigned. It is used for
8254 parameters and local variables.
8255 (Block.EmitMeta): Take the InternalParameters as argument; compute
8256 the layout of the flow vectors here.
8257 (Block.LocalMap, Block.ParameterMap): New public properties.
8258 (FlowBranching): The .ctor doesn't get the InternalParameters
8259 anymore since Block.EmitMeta() now computes the layout of the flow
8261 (MyStructInfo): This class is now known as `StructInfo' and nested
8262 in `TypeInfo'; we don't access this directly anymore.
8264 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
8265 property and removed IsAssigned(), IsFieldAssigned(),
8266 SetAssigned() and SetFieldAssigned(); we now call them on the
8267 VariableInfo so we don't need to duplicate this code everywhere.
8269 * expression.cs (ParameterReference): Added `Block block' argument
8271 (LocalVariableReference, ParameterReference, This): The new
8272 VariableInfo class is now responsible for all the definite
8275 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
8276 IsParameterAssigned, SetParameterAssigned): Removed.
8278 2003-05-18 Martin Baulig <martin@ximian.com>
8280 * typemanager.cs (InitCoreTypes): Try calling
8281 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
8282 the 3-args-version. Corlib now also needs our `void_type'.
8283 (GetMethod): Added overloaded version which takes an optional
8284 `bool report_errors' to allow lookups of optional methods.
8286 2003-05-12 Martin Baulig <martin@ximian.com>
8288 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
8289 only used for locals and not for parameters.
8291 2003-05-12 Miguel de Icaza <miguel@ximian.com>
8293 * support.cs (InternalParameters.ParameterType): Return the
8294 ExternalType of the parameter.
8296 * parameter.cs (Parameter.ExternalType): drop the two arguments,
8299 2003-05-11 Miguel de Icaza <miguel@ximian.com>
8301 * class.cs (MethodData.Define): Do not set the `newslot' on
8302 interface members, if they are also flagged as "override".
8304 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
8305 better code for ++i and i++. This only works for static fields
8306 and local variables.
8308 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
8309 want to pull the DeclSpace out of the builder_to_declspace instead
8310 of the TypeBuilder (like in TypeContainer.FindMembers).
8312 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
8313 instead of LookupTypeContainer. Fixes the crash on .NET for
8314 looking up interface members.
8316 * const.cs: Create our own emit context during the Definition
8317 stage, so that constants are evaluated in the proper context, when
8318 a recursive definition happens.
8320 2003-05-11 Martin Baulig <martin@ximian.com>
8322 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
8323 new block for a switch section.
8324 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
8325 the adding/lookup in the switch block. Fixes #39828.
8327 2003-05-09 Miguel de Icaza <miguel@ximian.com>
8329 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
8330 functionality: I needed to convert the data after I had performed
8331 the add/sub operation into the operands type size.
8333 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
8334 pass the type for the box operation, otherwise the resulting
8335 object would have been of type object.
8337 (BoxedCast): Add constructor to specify the type to box as.
8339 2003-05-07 Miguel de Icaza <miguel@ximian.com>
8341 * iterators.cs: I was reusing the `count' variable inadvertently,
8342 take steps to not allow this to happen.
8344 2003-05-06 Miguel de Icaza <miguel@ximian.com>
8346 * attribute.cs (Attribute.Resolve): Params attributes are encoded
8347 by creating an array at the point where the params starts and
8348 putting all those arguments there, then adjusting the size of the
8351 2003-05-05 Miguel de Icaza <miguel@ximian.com>
8353 * expression.cs (New.AddressOf): Implement interface
8354 IMemoryLocation. This is used when the `new' operator is used in
8355 the context of an invocation to a method on a value type.
8357 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
8360 * namespace.cs: Also check the using aliases here.
8362 * driver.cs: Move the test for using validity after the types have
8363 been entered, so we do a single pass that also includes the using
8366 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
8367 in the regular case. CreateSiblingForFinally is doing extra
8370 * attribute.cs (GetAttributeArgumentExpression): Store the result
8371 on an out value, and use the return value to indicate failure
8372 instead of using null (which is a valid return for Constant.GetValue).
8374 * statement.cs: Perform the analysis flow for the increment
8375 portion after the statement, because this will be the real flow of
8376 execution. Fixes #42385
8378 * codegen.cs (EmitContext.EmitArgument,
8379 EmitContext.EmitStoreArgument): New helper functions when the
8380 RemapToProxy flag is set.
8382 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
8385 Add support for remapping parameters.
8387 * iterators.cs: Propagate parameter values; Store parameter
8388 values in the proxy classes.
8390 2003-05-04 Miguel de Icaza <miguel@ximian.com>
8392 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
8393 need a proxy reference; I do not know what I was thinking
8395 * cs-parser.jay (constructor_initializer): catch another error,
8396 and display nice message.
8398 (field_declaration): catch void field declaration
8399 to flag a better error.
8401 * class.cs (MemberBase.CheckBase): Report an error instead of a
8402 warning if a new protected member is declared in a struct.
8403 (Field.Define): catch the error of readonly/volatile.
8405 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
8407 (FieldExpr.AddressOf): ditto. Catch error where the address of a
8408 volatile variable is taken
8410 2003-05-02 Miguel de Icaza <miguel@ximian.com>
8412 * statement.cs (Fixed.Resolve): Report an error if we are not in
8415 2003-05-01 Miguel de Icaza <miguel@ximian.com>
8417 * typemanager.cs: reuse the code that handles type clashes for
8418 delegates and enumerations.
8420 * class.cs (Report28): Always report.
8422 * expression.cs (EncodeAsAttribute): Allow nulls here.
8424 2003-04-28 Miguel de Icaza <miguel@ximian.com>
8426 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
8427 the functionality for testing whether an expression is valid for
8428 an attribute here. Also handle the case of arrays of elements
8431 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
8432 encoding a linear array into an array of objects that are suitable
8433 to be passed to an CustomAttributeBuilder.
8435 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
8437 * ecore.cs: (FieldExpr): Handle field remapping here.
8439 * iteratators.cs: Pass the instance variable (if the method is an
8440 instance method) to the constructors, so we can access the field
8441 variables on the class.
8443 TODO: Test this with structs. I think the THIS variable on
8444 structs might have to be a pointer, and not a refenrece
8446 2003-04-27 Miguel de Icaza <miguel@ximian.com>
8448 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
8449 local variables to fields in a proxy class.
8451 * iterators.cs (PopulateProxy): Rename our internal fields to
8453 Create a <THIS> field if we are an instance method, so we can
8454 reference our parent container variables.
8455 (MapVariable): Called back from the EmitContext code to enter a
8456 new variable to field mapping into the proxy class (we just create
8460 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
8461 for using the remapped locals to fields.
8463 I placed the code here, because that gives the same semantics to
8464 local variables, and only changes the Emit code.
8466 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
8467 statements inside iterators.
8468 (VariableInfo): Add a FieldBuilder for the cases when we are
8469 remapping local variables to fields in a proxy class
8471 * ecore.cs (SimpleNameResolve): Avoid testing two times for
8472 current_block != null.
8474 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
8475 not cope with strings, as it has been moved to the
8476 TableSwitchEmit. Fixed bug in switch generation.
8478 * expression.cs (New.DoResolve): Provide more context for the user
8479 when reporting an error.
8481 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
8484 * expression.cs (MemberAccess.DoResolve): When we get a type back,
8485 check the permissions for it. Note than in a type-resolution
8486 context the check was already present in DeclSpace.ResolveType,
8487 but was missing from the MemberAccess.
8489 (ArrayCreation.CheckIndices): warn if the user has
8490 more nested levels of expressions, but there are no more
8491 dimensions specified. Avoids crash on bug 41906.
8493 2003-04-26 Miguel de Icaza <miguel@ximian.com>
8495 * statement.cs (Block): replace Implicit bool, for a generic
8497 New flag: `Unchecked'. This is used during the EmitMeta phase
8498 (which is out-of-line with the regular Resolve/Emit process for a
8499 statement, as this is done ahead of time, but still gets a chance
8500 to call constant resolve).
8502 (Block.Flags): new enum for adding a new flag.
8504 (Block.EmitMeta): track the state of unchecked.
8506 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
8507 to enable constant resolution to work there as well.
8509 2003-04-22 Miguel de Icaza <miguel@ximian.com>
8511 * typemanager.cs (ienumerable_type): Also look up
8512 System.Collections.IEnumerable.
8514 2003-04-21 Miguel de Icaza <miguel@ximian.com>
8516 TODO: Test more than one conditional per method.
8518 * class.cs (Indexer.Define): Report the location where the user is
8519 referencing the unsupported feature.
8521 (MethodData): Overload the use of `conditionals' to
8522 minimize the creation of needless ArrayLists. This saves roughly
8523 212kb on my machine.
8525 (Method): Implement the new IIteratorContainer interface.
8526 (Method.SetYields): Implement the method by setting the ModFlags
8527 to contain METHOD_YIELDS.
8529 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
8530 which just got set to null.
8532 * iterators.cs: New file.
8534 (Yield, YieldBreak): New statements.
8536 * statement.cs (Return.Resolve): Flag an error if we are used in
8539 * codegen.cs (InIterator): New flag set if the code is being
8540 compiled in an iterator method.
8542 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
8543 internal modifier, and we just use it to avoid adding extra
8544 fields, as this is seldom used.
8546 * cs-parser.jay: Add yield_statement (yield and yield break).
8548 * driver.cs: New flag -v2 to turn on version 2 features.
8550 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
8551 hashtable when v2 is enabled.
8553 2003-04-20 Miguel de Icaza <miguel@ximian.com>
8555 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
8556 there is already a namespace defined with this name.
8558 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
8559 people upgraded their corlibs.
8561 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
8562 always use fully qualified types, no need to use the compiler
8565 (TypeManager.IsNamespace): Use binarysearch.
8567 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
8568 AddDelegate): I did not quite use the new IsValid API properly: I
8569 have to pass the short-name and the fullname. I was passing only
8570 the basename instead of the fullname sometimes.
8572 (TypeContainer.DefineType): call NamespaceClash.
8574 * interface.cs (Interface.DefineType): use NamespaceClash before
8577 * delegate.cs (Delegate.DefineType): use NamespaceClash before
8580 * enum.cs: (Enum.DefineType): use NamespaceClash before
8583 * typemanager.cs (: 3-line patch that gives us some tasty 11%
8584 speed increase. First, use the negative_hits cache when we get a
8585 negative. Second, add the type with its full original name
8586 instead of the new . and + encoded name (reflection uses + to
8587 separate type from a nested type). Use LookupTypeReflection
8588 directly which bypasses the type->name hashtable (that we already
8589 know does not contain the type.
8591 * decl.cs (DeclSpace.ResolveTypeExpr): track the
8592 location/container type.
8594 * driver.cs: When passing utf8, use directly the UTF8Encoding.
8596 2003-04-19 Miguel de Icaza <miguel@ximian.com>
8598 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
8600 * delegate.cs (NewDelegate.Resolve): Test whether an instance
8601 method is being referenced in the method group from a static
8602 context, and report error 120 if so.
8604 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
8607 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
8608 is created, we create the A namespace).
8610 * cs-parser.jay: A namespace also introduces a DeclarationFound.
8613 2003-04-18 Miguel de Icaza <miguel@ximian.com>
8615 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
8616 invocation to ModuleBuilder.GetType with the same values will
8617 return a new type instance, so we need to cache its return
8620 * expression.cs (Binary.ResolveOperator): Only allow the compare
8621 operators on enums if they are of the same type.
8623 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
8624 types of ValueType on their own case. Before we were giving them
8625 the same treatment as objects.
8627 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
8628 fullname. Short name is used to compare against container name.
8629 Fullname is used to check against defined namespace names.
8631 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
8632 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
8634 (Method.CheckBase): Call parent.
8635 (MemberBase.CheckBase): Check for protected members on sealed
8637 (PropertyBase.CheckBase): Call parent.
8638 (Field.Define): Call parent.
8640 * report.cs: Negative error codes are now mapped to 8000 - code,
8641 so that the display is render more nicely.
8643 * typemanager.cs: Do not use try/catch, instead report a regular
8646 (GetPointerType, GetReferenceType): These methods provide
8647 mechanisms to obtain the T* and T& from a T. We had the code
8648 previously scattered around the code base, and it also used
8649 TypeManager.LookupType that would go through plenty of caches.
8650 This one goes directly to the type source.
8652 In some places we did the Type.GetType followed by
8653 ModuleBuilder.GetType, but not in others, so this unifies the
8656 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
8657 statements now that we have namespace information.
8659 * typemanager.cs (IsNamespace): New method, returns whether the
8660 string presented is a namespace or not.
8662 (ComputeNamespaces): New public entry point, computes the list of
8663 available namespaces, using the GetNamespaces API call in Mono, or
8664 the slower version in MS.NET.
8666 Now before we start the semantic analysis phase, we have a
8667 complete list of namespaces including everything that the user has
8670 Deleted old code to cache namespaces in .nsc files.
8672 2003-04-17 Miguel de Icaza <miguel@ximian.com>
8674 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
8675 class/struct location definition Location for the implicit
8676 constructor location.
8678 (Operator.Define): Use the location of the operator for the
8679 implicit Method definition.
8681 (Constructor.Emit): use the constructor location for the implicit
8682 base initializer constructor.
8684 * ecore.cs: Remove ITypeExpression. This interface is now gone,
8685 and the Expression class now contains two new methods:
8687 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
8688 isolate type lookup from the rest of the resolution process.
8690 Since we use Expressions to hold type definitions due to the way
8691 we parse the input we have historically overloaded Resolve to
8692 perform the Type lookups if a special flag is passed. Now this is
8693 eliminated and two methods take their place.
8695 The differences in the two methods between xStep and xTerminal is
8696 that xStep is involved in our current lookup system that uses
8697 SimpleNames to compose a name, while xTerminal is used just to
8698 catch the case where the simplename lookup failed.
8700 2003-04-16 Miguel de Icaza <miguel@ximian.com>
8702 * expression.cs (ResolveMemberAccess): Remove redundant code.
8703 TypeExpr expressions are always born fully resolved.
8705 * interface.cs (PopulateMethod): Do not lookup the types twice.
8706 We were doing it once during SemanticAnalysis and once during
8709 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
8710 in local variable type definitions, were being returned as a
8711 SimpleName (we decomposed everything into a string), that is
8712 because primary_expression was being used instead of a type in the
8713 grammar (reduce/reduce conflicts).
8715 The part that was wrong is that we converted the expression into a
8716 string (an oversimplification in one hand, compounded with primary
8717 expressions doing string concatenation).
8723 Would return "A.B.C[]" as a SimpleName. This stopped things like
8724 using clauses from working on this particular context. And a type
8725 was being matched directly against "A.B.C[]".
8727 We now use the correct approach, and allow for ComposedCast to be
8728 part of the unary expression. So the "A.B.C []" become a composed
8729 cast of "A.B.C" (as a nested group of MemberAccess with a
8730 SimpleName at the end) plus the rank composition "[]".
8734 2003-04-10 Miguel de Icaza <miguel@ximian.com>
8736 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
8737 for the access level checking.
8739 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
8740 `TypeContainer container', because I kept getting confused when I
8741 was debugging this code.
8743 * expression.cs (Indexers): Instead of tracking getters/setters,
8744 we now track them in parallel. We create one arraylist less, but
8745 most importantly it is possible now for the LValue code to find a
8746 matching get for a set.
8748 (IndexerAccess.DoResolveLValue): Update the code.
8749 GetIndexersForType has been modified already to extract all the
8750 indexers from a type. The code assumed it did not.
8752 Also make the code set the correct return type for the indexer.
8753 This was fixed a long time ago for properties, but was missing for
8754 indexers. It used to be void_type.
8756 (Binary.Emit): Test first for doubles instead of
8757 floats, as they are more common.
8759 (Binary.EmitBranchable): Use the .un version of the branch opcodes
8760 when dealing with floats and the <=, >= operators. This fixes bug
8763 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
8764 to load the array value by emitting a load on the foreach variable
8765 type. This was incorrect.
8767 We now emit the code to load an element using the the array
8768 variable type, and then we emit the conversion operator.
8772 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
8774 * attribute.cs: Avoid allocation of ArrayLists in the common case.
8776 2003-04-09 Miguel de Icaza <miguel@ximian.com>
8778 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
8779 test for protection before we test for signatures.
8781 (MethodSignature.ToString): implement.
8783 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
8784 to the case where we reduced into a LongConstant.
8786 * decl.cs (CheckAccessLevel): If the type is an array, we can not
8787 depend on whether the information is acurrate, because the
8788 Microsoft runtime will always claim that the array type is public,
8789 regardless of the real state.
8791 If the type is a pointer, another problem happens: the type is
8792 reported as non-public in Microsoft.
8794 In both cases we have to call CheckAccessLevel recursively with
8795 the underlying type as the argument to be tested.
8797 2003-04-08 Miguel de Icaza <miguel@ximian.com>
8799 * assign.cs (Assign.Emit): If we are dealing with a compound
8800 assignment expression, we should use the code path that stores the
8801 intermediate result in a temporary value. This fixes #40903.
8803 *expression.cs (Indirection.ToString): Provide ToString method for
8806 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
8808 * class.cs: Null out fields holding references to Block objects so
8809 they can be garbage collected.
8811 * expression.cs (OverloadResolve): Remove unused local.
8813 2003-04-07 Martin Baulig <martin@ximian.com>
8815 * codegen.cs (EmitContext.CurrentFile): New public field.
8816 (EmitContext.Mark): Use the CurrentFile to check whether the
8817 location is in the correct file.
8818 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
8820 2003-04-07 Martin Baulig <martin@ximian.com>
8822 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
8824 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
8825 location. [FIXME: The location argument which gets passed to this
8826 method is sometimes wrong!]
8828 2003-04-07 Nick Drochak <ndrochak@gol.com>
8830 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
8832 2003-04-07 Miguel de Icaza <miguel@ximian.com>
8834 * expression.cs (Indirection.EmitAssign): We were using the
8835 temporary, but returning immediately instead of continuing the
8838 2003-04-06 Martin Baulig <martin@ximian.com>
8840 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
8841 if it's a nested child, but also deriving from the outer class.
8844 * typemanager.cs (IsNestedChildOf): Make this work if it's a
8845 nested child, but also deriving from the outer class. See
8847 (FilterWithClosure): We may access private members of the outer
8848 class if we're a nested child and deriving from the outer class.
8849 (RealMemberLookup): Only set `closure_private_ok' if the
8850 `original_bf' contained BindingFlags.NonPublic.
8852 2003-04-05 Martin Baulig <martin@ximian.com>
8854 * expression.cs (SizeOf.DoResolve): Use ResolveTypeExpr, so we can
8855 probe if its a type parameter, and if so, flag an error.
8857 * decl.cs: Move here the SetParameterInfo code from class.cs.
8858 Handle IsGeneric here.
8860 Handle a variety of errors in the parameter info definition.
8862 * ecore.cs (SimpleName.DoResolveType): Handle look ups for generic
8863 type parameters here.
8865 * cs-parser.jay (class_declaration): report errors for parameters
8868 2003-01-21 Miguel de Icaza <miguel@ximian.com>
8870 * generic.cs: New file, contains support code for generics.
8872 * cs-parser.jay: Remove OP_SHIFT_LEFT, OP_SHIFT_RIGHT,
8873 OP_SHIFT_LEFT_ASSIGN, OP_SHIFT_RIGHT_ASSIGN.
8875 Update parser for the above removals.
8877 * cs-tokenizer.cs: Do not handle <<= or >>= specially. This is
8878 now taken care of in the parser.
8880 2003-04-02 Miguel de Icaza <miguel@ximian.com>
8882 * class.cs (Event.Define): Do not allow abstract events to have
8885 2003-04-01 Miguel de Icaza <miguel@ximian.com>
8887 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
8888 block in event declarations.
8890 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
8891 value type, get its address.
8893 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
8894 leaving a class on the stack instead of a boolean value (int
8895 0/1). Change the code so we compare against null, and then the
8896 result against zero.
8898 * class.cs (TypeContainer.GetClassBases): We were checking for the
8899 parent class being sealed too late.
8901 * expression.cs (Binary.Emit): For <= and >= when dealing with
8902 floating point values, use cgt.un and clt.un instead of cgt and
8905 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
8907 * statement.cs: Apply the same optimization as MS: skip the
8908 GetEnumerator returning an IEnumerator, and use the one returning a
8909 CharEnumerator instead. This allows us to avoid the try-finally block
8912 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
8914 * cs-parser.jay: Attributes cannot be applied to
8915 namespaces. Fixes #40473
8917 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8920 (Add*): check if the name is valid using the full name for constants,
8921 fields, properties and events.
8923 2003-03-28 Miguel de Icaza <miguel@ximian.com>
8925 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
8926 char constants to be part of the enumeration.
8928 * expression.cs (Conditional.DoResolve): Add support for operator
8929 true. Implements the missing functionality from 14.12
8931 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
8932 operator true/false as required by the spec.
8934 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
8935 implicit conversion to boolean.
8937 * statement.cs (Statement.ResolveBoolean): A boolean expression is
8938 also one where the type implements `operator true'.
8940 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
8941 get an expression that will invoke operator true based on an
8944 (GetConversionOperators): Removed the hack that called op_True
8947 (Expression.ResolveBoolean): Move this from Statement.
8949 2003-03-17 Miguel de Icaza <miguel@ximian.com>
8951 * ecore.cs (FieldExpr): do not allow initialization of initonly
8952 fields on derived classes
8954 2003-03-13 Martin Baulig <martin@ximian.com>
8956 * statement.cs (Block.Emit): Call ig.BeginScope() and
8957 ig.EndScope() when compiling with debugging info; call
8958 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
8960 2003-03-08 Miguel de Icaza <miguel@ximian.com>
8962 * expression.cs (Indexers): Do not construct immediately, allow
8963 for new members to be appended as we go. Fixes 38143
8965 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8967 * expression.cs: save/restore context when resolving an unchecked
8970 2003-03-05 Miguel de Icaza <miguel@ximian.com>
8972 * cfold.cs: Catch division by zero in modulus operator during
8975 2003-03-03 Miguel de Icaza <miguel@ximian.com>
8977 * interface.cs (Interface.DefineMembers): Avoid defining members
8980 2003-02-27 Miguel de Icaza <miguel@ximian.com>
8982 * driver.cs: handle the +/- options for -noconfig
8984 * statement.cs (Unckeched.Resolve): Also track the state of
8985 unchecked in the Resolve phase.
8987 2003-02-27 Martin Baulig <martin@ximian.com>
8989 * ecore.cs (Expression.MemberLookup): Don't create a
8990 MethodGroupExpr for something which is not a method. Fixes #38291.
8992 2003-02-25 Miguel de Icaza <miguel@ximian.com>
8994 * class.cs (MemberBase.CheckParameters): Also check that the type
8995 is unmanaged if it is a pointer.
8997 * expression.cs (SizeOf.Resolve): Add location information.
8999 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
9000 a managed type is declared.
9002 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
9003 parameter modifiers as well. Fixes bug 38606
9005 * class.cs: Very sad. Am backing out the speed up changes
9006 introduced by the ArrayList -> Array in the TypeContainer, as they
9007 were not actually that much faster, and introduced a bug (no error
9008 reports on duplicated methods).
9010 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
9011 source first, this will guarantee that we have a valid expression
9012 before calling in lower levels functions that will require a
9013 resolved object. Then use this original_source in the
9014 target.ResolveLValue instead of the original source that was
9017 Another change. Use target.Resolve instead of LValueResolve.
9018 Although we are resolving for LValues, we will let the Assign code
9019 take care of that (it will be called again from Resolve). This
9020 basically allows code like this:
9022 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
9023 class Y { void A (X x) { x [0] += o; }
9025 The problem was that the indexer was trying to resolve for
9026 set_Item (idx, object o) and never finding one. The real set_Item
9027 was set_Item (idx, X). By delaying the process we get the right
9032 2003-02-23 Martin Baulig <martin@ximian.com>
9034 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
9035 while calling DoEmit ().
9037 * codegen.cs (EmitContext.Mark): Don't mark locations in other
9038 source files; if you use the #line directive inside a method, the
9039 compiler stops emitting line numbers for the debugger until it
9040 reaches the end of the method or another #line directive which
9041 restores the original file.
9043 2003-02-23 Martin Baulig <martin@ximian.com>
9045 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
9047 2003-02-23 Martin Baulig <martin@ximian.com>
9049 * statement.cs (Block.AddChildVariableNames): We need to call this
9050 recursively, not just for our immediate children.
9052 2003-02-23 Martin Baulig <martin@ximian.com>
9054 * class.cs (Event.Define): Always make the field private, like csc does.
9056 * typemanager.cs (TypeManager.RealMemberLookup): Make events
9057 actually work, fixes bug #37521.
9059 2003-02-23 Miguel de Icaza <miguel@ximian.com>
9061 * delegate.cs: When creating the various temporary "Parameters"
9062 classes, make sure that we call the ComputeAndDefineParameterTypes
9063 on those new parameters (just like we do with the formal ones), to
9064 allow them to be resolved in the context of the DeclSpace.
9066 This fixes the bug that Dick observed in Bugzilla #38530.
9068 2003-02-22 Miguel de Icaza <miguel@ximian.com>
9070 * expression.cs (ResolveMemberAccess): When resolving a constant,
9071 do not attempt to pull a constant if the value was not able to
9072 generate a valid constant.
9074 * const.cs (LookupConstantValue): Do not report more errors than required.
9076 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9078 * expression.cs: fixes bug #38328.
9080 2003-02-18 Miguel de Icaza <miguel@ximian.com>
9082 * class.cs: Changed all the various members that can be part of a
9083 class from being an ArrayList to be an Array of the right type.
9084 During the DefineType type_list, interface_list, delegate_list and
9085 enum_list are turned into types, interfaces, delegates and enums
9088 And during the member population, indexer_list, event_list,
9089 constant_list, field_list, instance_constructor_list, method_list,
9090 operator_list and property_list are turned into their real arrays.
9092 Although we could probably perform this operation earlier, for
9093 good error reporting we need to keep the lists and remove the
9094 lists for longer than required.
9096 This optimization was triggered by Paolo profiling the compiler
9097 speed on the output of `gen-sample-program.pl' perl script.
9099 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
9100 not crash in methods like MemberLookupFailed that use this field.
9102 This problem arises when the compiler fails to resolve a type
9103 during interface type definition for example.
9105 2003-02-18 Miguel de Icaza <miguel@ximian.com>
9107 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
9108 inherit from System.Object, so we have to stop at null, not only
9109 when reaching System.Object.
9111 2003-02-17 Miguel de Icaza <miguel@ximian.com>
9113 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
9114 DeclaredOnly because the parent indexer might have had a different
9115 name, but did not loop until the top of the hierarchy was reached.
9117 The problem this one fixes is 35492: when a class implemented an
9118 indexer from an interface, we were getting the interface method
9119 (which was abstract) and we were flagging an error (can not invoke
9122 This also keeps bug 33089 functioning, and test-148 functioning.
9124 * typemanager.cs (IsSpecialMethod): The correct way of figuring
9125 out if a method is special is to see if it is declared in a
9126 property or event, or whether it is one of the predefined operator
9127 names. This should fix correctly #36804.
9129 2003-02-15 Miguel de Icaza <miguel@ximian.com>
9131 The goal here is to remove the dependency on EmptyCast.Peel ().
9132 Killing it completely.
9134 The problem is that currently in a number of places where
9135 constants are expected, we have to "probe" for an EmptyCast, and
9136 Peel, which is not the correct thing to do, as this will be
9137 repetitive and will likely lead to errors.
9139 The idea is to remove any EmptyCasts that are used in casts that
9140 can be reduced to constants, so we only have to cope with
9143 This bug hunt was triggered by Bug 37363 and the desire to remove
9144 the duplicate pattern where we were "peeling" emptycasts to check
9145 whether they were constants. Now constants will always be
9148 * ecore.cs: Use an enumconstant here instead of wrapping with
9151 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
9152 throwing me off. By handling this we can get rid of a few hacks.
9154 * statement.cs (Switch): Removed Peel() code.
9156 2003-02-14 Miguel de Icaza <miguel@ximian.com>
9158 * class.cs: Location information for error 508
9160 * expression.cs (New.DoResolve): Add a guard against double
9161 resolution of an expression.
9163 The New DoResolve might be called twice when initializing field
9164 expressions (see EmitFieldInitializers, the call to
9165 GetInitializerExpression will perform a resolve on the expression,
9166 and later the assign will trigger another resolution
9168 This leads to bugs (#37014)
9170 * delegate.cs: The signature for EndInvoke should contain any ref
9171 or out parameters as well. We were not doing this in the past.
9173 * class.cs (Field.Define): Do not overwrite the type definition
9174 inside the `volatile' group. Turns out that volatile enumerations
9175 were changing the type here to perform a validity test, which
9178 2003-02-12 Miguel de Icaza <miguel@ximian.com>
9180 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
9181 and structs, we do not want to load the instance variable
9183 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
9184 enum_type has to be handled like an object reference (implicit
9185 conversions exists from this to object), but the regular IsClass
9186 and IsValueType tests will never return true for this one.
9188 Also we use TypeManager.IsValueType instead of type.IsValueType,
9189 just for consistency with the rest of the code (this is only
9190 needed if we ever use the construct exposed by test-180.cs inside
9191 corlib, which we dont today).
9193 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
9195 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
9198 2003-02-09 Martin Baulig <martin@ximian.com>
9200 * namespace.cs (Namespace..ctor): Added SourceFile argument.
9201 (Namespace.DefineNamespaces): New static public method; this is
9202 called when we're compiling with debugging to add all namespaces
9205 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
9206 pass it to the Namespace's .ctor.
9208 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
9209 and MethodBase arguments; pass the namespace ID to the symwriter;
9210 pass the MethodBase instead of the token to the symwriter.
9211 (SymbolWriter.DefineNamespace): New method to add a namespace to
9214 2003-02-09 Martin Baulig <martin@ximian.com>
9216 * symbolwriter.cs: New file. This is a wrapper around
9217 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
9218 methods here in near future.
9220 2003-02-09 Martin Baulig <martin@ximian.com>
9222 * codegen.cs (EmitContext.Mark): Just pass the arguments to
9223 ILGenerator.MarkSequencePoint() which are actually used by the
9226 2003-02-09 Martin Baulig <martin@ximian.com>
9228 * location.cs (SourceFile): New public sealed class. This
9229 contains the name and an index which is used in the location's token.
9230 (Location): Reserve an appropriate number of bits in the token for
9231 the source file instead of walking over that list, this gives us a
9232 really huge performance improvement when compiling with debugging.
9234 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
9235 `SourceFile' argument instead of a string.
9236 (Driver.ProcessFile): Add all the files via Location.AddFile(),
9237 but don't parse/tokenize here, we need to generate the list of all
9238 source files before we do that.
9239 (Driver.ProcessFiles): New static function. Parses/tokenizes all
9242 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
9243 instead of a string.
9245 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
9248 2003-02-09 Martin Baulig <martin@ximian.com>
9250 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
9251 filename on `#line default'.
9253 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
9255 * statement.cs: don't clear the pinned var when the fixed statement
9256 returns from the method (fixes bug#37752).
9258 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
9260 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
9263 2003-02-07 Martin Baulig <martin@ximian.com>
9265 * driver.cs: Removed the `--debug-args' command line argument.
9267 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
9268 automatically by the AsssemblyBuilder.
9269 (CodeGen.InitializeSymbolWriter): We don't need to call any
9270 initialization function on the symbol writer anymore. This method
9271 doesn't take any arguments.
9273 2003-02-03 Miguel de Icaza <miguel@ximian.com>
9275 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
9276 from referenced assemblies as well.
9278 2003-02-02 Martin Baulig <martin@ximian.com>
9280 * class.cs (MethodData.Emit): Generate debugging info for external methods.
9282 2003-02-02 Martin Baulig <martin@ximian.com>
9284 * class.cs (Constructor.Emit): Open the symbol writer before
9285 emitting the constructor initializer.
9286 (ConstructorInitializer.Emit): Call ec.Mark() to allow
9287 single-stepping through constructor initializers.
9289 2003-01-30 Miguel de Icaza <miguel@ximian.com>
9291 * class.cs: Handle error 549: do not allow virtual methods in
9294 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
9296 * decl.cs: Check access levels when resolving types
9298 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
9300 * statement.cs: Add parameters and locals set in catch blocks that might
9301 return to set vector
9303 2003-01-29 Miguel de Icaza <miguel@ximian.com>
9305 * class.cs (Operator): Set the SpecialName flags for operators.
9307 * expression.cs (Invocation.DoResolve): Only block calls to
9308 accessors and operators on SpecialName methods.
9310 (Cast.TryReduce): Handle conversions from char constants.
9313 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
9315 * statement.cs: small memory and time optimization in FlowBranching.
9317 2003-01-28 Pedro Mart <yoros@wanadoo.es>
9319 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
9320 problem that the last fix but in the other sid (Set).
9322 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
9323 access when there is no indexer in the hierarchy.
9325 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
9327 * class.cs: Combine some if statements.
9329 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9331 * driver.cs: fixed bug #37187.
9333 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
9335 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
9336 any indexer, it's needed to build a list with all the indexers in the
9337 hierarchy (AllGetters), else we have problems. Fixes #35653.
9339 2003-01-23 Miguel de Icaza <miguel@ximian.com>
9341 * class.cs (MethodData.Define): It is wrong for an interface
9342 implementation to be static in both cases: explicit and implicit.
9343 We were only handling this in one case.
9345 Improve the if situation there to not have negations.
9347 * class.cs (Field.Define): Turns out that we do not need to check
9348 the unsafe bit on field definition, only on usage. Remove the test.
9350 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9352 * driver.cs: use assembly.Location instead of Codebase (the latest
9353 patch made mcs fail when using MS assemblies).
9355 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
9357 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
9358 get the path to *corlib.dll.
9360 2003-01-21 Nick Drochak <ndrochak@gol.com>
9364 * typemanager.cs: Remove compiler warnings
9366 2003-01-20 Duncan Mak <duncan@ximian.com>
9368 * AssemblyInfo.cs: Bump the version number to 0.19.
9370 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9372 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
9374 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
9376 * class.cs (Constructor::Emit): Emit debugging info for constructors.
9378 2003-01-17 Miguel de Icaza <miguel@ximian.com>
9380 * cs-parser.jay: Small fix: we were not comparing the constructor
9381 name correctly. Thanks to Zoltan for the initial pointer.
9383 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
9385 * cs-tokenizer.cs: Set file name when specified with #line
9387 2003-01-15 Miguel de Icaza <miguel@ximian.com>
9389 * cs-parser.jay: Only perform the constructor checks here if we
9390 are named like the class; This will help provider a better
9391 error. The constructor path is taken when a type definition is
9392 not found, but most likely the user forgot to add the type, so
9393 report that rather than the constructor error.
9395 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
9397 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
9400 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
9402 * cs-parser.jay: Add cleanup call.
9404 2003-01-13 Duncan Mak <duncan@ximian.com>
9406 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
9407 consistent with other methods.
9409 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
9411 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
9413 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
9415 * attribute.cs: only set GuidAttr to true when we have a
9418 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9422 * typemanager.cs: fixes to allow mcs compile corlib with the new
9423 Type.IsSubclassOf fix.
9425 2003-01-08 Miguel de Icaza <miguel@ximian.com>
9427 * expression.cs (LocalVariableReference.DoResolve): Classify a
9428 constant as a value, not as a variable. Also, set the type for
9431 * cs-parser.jay (fixed_statement): take a type instead of a
9432 pointer_type, so we can produce a better error message later.
9434 * statement.cs (Fixed.Resolve): Flag types that are not pointers
9437 (For.DoEmit): Make inifinite loops have a
9438 non-conditional branch back.
9440 (Fixed.DoEmit): First populate the pinned variables, then emit the
9441 statement, then clear the variables. Before I was emitting the
9442 code once for each fixed piece.
9445 2003-01-08 Martin Baulig <martin@ximian.com>
9447 * statement.cs (FlowBranching.MergeChild): A break in a
9448 SWITCH_SECTION does not leave a loop. Fixes #36155.
9450 2003-01-08 Martin Baulig <martin@ximian.com>
9452 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
9453 lives in the same number space than `param_map'. Fixes #36154.
9455 2003-01-07 Miguel de Icaza <miguel@ximian.com>
9457 * cs-parser.jay (constructor_declaration): Set the
9458 Constructor.ModFlags before probing for it. This makes the
9459 compiler report 514, 515 and 132 (the code was there, but got
9462 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
9463 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
9464 (GotoCase.Resolve): Set `Returns' to ALWAYS.
9466 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
9468 * enum.cs: create the enum static fields using the enum type.
9470 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
9472 * class.cs: don't try to create the ParamBuilder for the return
9473 type if it's not needed (and handle it breaking for the ms runtime
9476 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
9478 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
9480 2002-12-29 Miguel de Icaza <miguel@ximian.com>
9482 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
9483 the command. This showed up while compiling the JANET source
9484 code, which used \r as its only newline separator.
9486 2002-12-28 Miguel de Icaza <miguel@ximian.com>
9488 * class.cs (Method.Define): If we are an operator (because it
9489 reuses our code), then set the SpecialName and HideBySig. #36128
9491 2002-12-22 Miguel de Icaza <miguel@ximian.com>
9493 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
9494 exception, report error 120 `object reference required'.
9496 * driver.cs: Add --pause option, used during to measure the size
9497 of the process as it goes with --timestamp.
9499 * expression.cs (Invocation.DoResolve): Do not allow methods with
9500 SpecialName to be invoked.
9502 2002-12-21 Miguel de Icaza <miguel@ximian.com>
9504 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
9505 number before adding it.
9507 2002-12-21 Ravi Pratap <ravi@ximian.com>
9509 * ecore.cs (StandardImplicitConversion): When in an unsafe
9510 context, we allow conversion between void * to any other pointer
9511 type. This fixes bug #35973.
9513 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
9515 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
9516 is not thrown when extensionless outputs are used
9518 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9520 * rootcontext.cs: fixed compilation of corlib.
9522 2002-12-19 Miguel de Icaza <miguel@ximian.com>
9524 * attribute.cs (Attributes.Contains): Add new method.
9526 * class.cs (MethodCore.LabelParameters): if the parameter is an
9527 `out' parameter, check that no attribute `[In]' has been passed.
9529 * enum.cs: Handle the `value__' name in an enumeration.
9531 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
9533 * decl.cs: Added special case to allow overrides on "protected
9536 2002-12-18 Ravi Pratap <ravi@ximian.com>
9538 * attribute.cs (Attributes.AddAttributeSection): Rename to this
9539 since it makes much more sense.
9541 (Attributes.ctor): Don't require a Location parameter.
9543 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
9545 * attribute.cs (ApplyAttributes): Remove extra Location parameters
9546 since we already have that information per attribute.
9548 * everywhere : make appropriate changes.
9550 * class.cs (LabelParameters): Write the code which actually
9551 applies attributes to the return type. We can't do this on the MS
9552 .NET runtime so we flag a warning in the case an exception is
9555 2002-12-18 Miguel de Icaza <miguel@ximian.com>
9557 * const.cs: Handle implicit null conversions here too.
9559 2002-12-17 Ravi Pratap <ravi@ximian.com>
9561 * class.cs (MethodCore.LabelParameters): Remove the extra
9562 Type [] parameter since it is completely unnecessary. Instead
9563 pass in the method's attributes so that we can extract
9564 the "return" attribute.
9566 2002-12-17 Miguel de Icaza <miguel@ximian.com>
9568 * cs-parser.jay (parse): Use Report.Error to flag errors instead
9569 of ignoring it and letting the compile continue.
9571 * typemanager.cs (ChangeType): use an extra argument to return an
9572 error condition instead of throwing an exception.
9574 2002-12-15 Miguel de Icaza <miguel@ximian.com>
9576 * expression.cs (Unary.TryReduce): mimic the code for the regular
9577 code path. Perform an implicit cast in the cases where we can
9578 implicitly convert to one of the integral types, and then reduce
9579 based on that constant. This fixes bug #35483.
9581 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9583 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
9585 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9587 * namespace.cs: fixed bug #35489.
9589 2002-12-12 Miguel de Icaza <miguel@ximian.com>
9591 * class.cs: Remove some dead code.
9593 * cs-parser.jay: Estimate the number of methods needed
9594 (RootContext.MethodCount);
9596 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
9597 numbers instead of StringBuilders.
9599 * support.cs (PtrHashtable): Add constructor with initial size;
9600 We can now reduce reallocations of the method table.
9602 2002-12-10 Ravi Pratap <ravi@ximian.com>
9604 * attribute.cs (ApplyAttributes): Keep track of the emitted
9605 attributes on a per-target basis. This fixes bug #35413.
9607 2002-12-10 Miguel de Icaza <miguel@ximian.com>
9609 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
9610 default to the Windows 1252 encoding.
9612 (UnixParseOption): Support version, thanks to Alp for the missing
9615 * AssemblyInfo.cs: Add nice assembly information.
9617 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
9620 * cs-parser.jay: Allow a trailing comma before the close bracked
9621 in the attribute_section production.
9623 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
9624 address of the instance was being taken, I will take this out,
9625 because we take the address of the object immediately here.
9627 2002-12-09 Ravi Pratap <ravi@ximian.com>
9629 * typemanager.cs (AreMultipleAllowed): Take care of the most
9630 obvious case where attribute type is not in the current assembly -
9633 2002-12-08 Miguel de Icaza <miguel@ximian.com>
9635 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
9636 definitions, instead of doing that afterwards.
9638 Also we use a nice little hack, depending on the constructor, we
9639 know if we are a "composed" name or a simple name. Hence, we
9640 avoid the IndexOf test, and we avoid
9642 * codegen.cs: Add code to assist in a bug reporter to track down
9643 the source of a compiler crash.
9645 2002-12-07 Ravi Pratap <ravi@ximian.com>
9647 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
9648 types have been emitted for a given element and flag an error
9649 if something which does not have AllowMultiple set is used more
9652 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
9653 attribute types and their corresponding AllowMultiple properties
9655 (AreMultipleAllowed): Check the property for a given type.
9657 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
9658 property in the case we have a TypeContainer.
9660 (Attributes.AddAttribute): Detect duplicates and just skip on
9661 adding them. This trivial fix catches a pretty gross error in our
9662 attribute emission - global attributes were being emitted twice!
9664 Bugzilla bug #33187 is now fixed.
9666 2002-12-06 Miguel de Icaza <miguel@ximian.com>
9668 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
9671 * expression.cs (Binary.ResolveOperator): I can only use the
9672 Concat (string, string, string) and Concat (string, string,
9673 string, string) if the child is actually a concatenation of
9676 2002-12-04 Miguel de Icaza <miguel@ximian.com>
9678 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
9679 context where we need a 2-character lookahead.
9681 * pending.cs (PendingImplementation): Rework so we can keep track
9682 of interface types all the time, and flag those which were
9683 implemented by parents as optional.
9685 2002-12-03 Miguel de Icaza <miguel@ximian.com>
9687 * expression.cs (Binary.ResolveOperator): Use
9688 String.Concat(string,string,string) or
9689 String.Concat(string,string,string,string) when possible.
9691 * typemanager: More helper methods.
9694 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
9696 * pending.cs: remove the bogus return from GetMissingInterfaces()
9697 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
9699 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9701 * namespace.cs: avoid duplicated 'using xxx' being added to
9702 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
9703 when we get more than one 'using' statement for the same namespace.
9704 Report a CS0105 warning for it.
9706 2002-11-30 Miguel de Icaza <miguel@ximian.com>
9708 * cs-tokenizer.cs (consume_identifier): use read directly, instead
9709 of calling getChar/putback, uses internal knowledge of it.
9711 (xtoken): Reorder tokenizer so most common patterns are checked
9712 first. This reduces the compilation time in another 5% (from 8.11s
9713 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
9715 The parsing time is 22% of the compilation in mcs, and from that
9716 64% is spent on the tokenization process.
9718 I tried using a binary search for keywords, but this is slower
9719 than the hashtable. Another option would be to do a couple of
9722 * Not use a StringBuilder, instead use an array of chars,
9723 with a set value. Notice that this way we could catch
9724 the 645 error without having to do it *afterwards*.
9726 * We could write a hand-parser to avoid the hashtable
9727 compares altogether.
9729 The identifier consumption process takes 37% of the tokenization
9730 time. Another 15% is spent on is_number. 56% of the time spent
9731 on is_number is spent on Int64.Parse:
9733 * We could probably choose based on the string length to
9734 use Int32.Parse or Int64.Parse and avoid all the 64-bit
9737 Another 3% is spend on wrapping `xtoken' in the `token' function.
9739 Handle 0xa0 as whitespace (#34752)
9741 2002-11-26 Miguel de Icaza <miguel@ximian.com>
9743 * typemanager.cs (IsCLRType): New routine to tell whether a type
9744 is one of the builtin types.
9746 Maybe it needs to use TypeCodes to be faster. Maybe we could use
9747 typecode in more places instead of doing pointer comparissions.
9748 We could leverage some knowledge about the way the typecodes are
9751 New code to cache namespaces in assemblies, it is currently not
9752 invoked, to be used soon.
9754 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
9756 * expression.cs (Binary.ResolveOperator): specially handle
9757 strings, and do not perform user-defined operator overloading for
9760 2002-11-24 Miguel de Icaza <miguel@ximian.com>
9762 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
9763 internalcall as it is a pretty simple operation; Avoid whenever
9764 possible to call Char.IsLetter.
9766 (consume_identifier): Cut by half the number of
9767 hashtable calls by merging the is_keyword and GetKeyword behavior.
9769 Do not short-circuit, because if we do, we
9770 report errors (ie, #if false && true would produce an invalid
9774 2002-11-24 Martin Baulig <martin@ximian.com>
9776 * expression.cs (Cast.TryReduce): If we're in checked syntax,
9777 check constant ranges and report a CS0221. Fixes #33186.
9779 2002-11-24 Martin Baulig <martin@ximian.com>
9781 * cs-parser.jay: Make this work for uninitialized variable
9782 declarations in the `for' initializer. Fixes #32416.
9784 2002-11-24 Martin Baulig <martin@ximian.com>
9786 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
9787 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
9789 2002-11-24 Martin Baulig <martin@ximian.com>
9791 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
9792 argument; if true, we also check for user-defined conversions.
9793 This is only needed if both arguments are of a user-defined type.
9794 Fixes #30443, added test-175.cs.
9795 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
9797 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
9799 2002-11-24 Martin Baulig <martin@ximian.com>
9801 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
9802 function to get the store opcode.
9803 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
9804 only emit the Ldelema if the store opcode is Stobj. You must run
9805 both test-34 and test-167 to test this. Fixes #34529.
9807 2002-11-23 Martin Baulig <martin@ximian.com>
9809 * ecore.cs (Expression.MemberLookup): Added additional
9810 `qualifier_type' argument which is used when we're being called
9811 from MemberAccess.DoResolve() and null if we're called from a
9813 (Expression.MemberLookupFailed): New method to report errors; this
9814 does the CS1540 check and reports the correct error message.
9816 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
9817 argument for the CS1540 check and redone the way how we're dealing
9818 with private members. See the comment in the source code for details.
9819 (FilterWithClosure): Reverted this back to revision 1.197; renamed
9820 `closure_start_type' to `closure_qualifier_type' and check whether
9821 it's not null. It was not this filter being broken, it was just
9822 being called with the wrong arguments.
9824 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
9825 and pass it the correct `qualifier_type'; this also does the error
9828 2002-11-22 Miguel de Icaza <miguel@ximian.com>
9830 * expression.cs (Invocation.EmitParams): If the we are dealing
9831 with a non-built-in value type, load its address as well.
9833 (ArrayCreation): Use a a pretty constant instead
9834 of the hardcoded value 2. Use 6 instead of 2 for the number of
9835 static initializers.
9837 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
9838 because they are not really value types, just glorified integers.
9840 * driver.cs: Do not append .exe, the CSC compiler does not do it.
9842 * ecore.cs: Remove redundant code for enumerations, make them use
9843 the same code path as everything else, fixes the casting issue
9844 with enumerations in Windows.Forms.
9846 * attribute.cs: Do only cast to string if it is a string, the
9847 validation happens later.
9849 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
9850 people upgrade their corlibs.
9852 * ecore.cs: Oops, enumerations were not following the entire code path
9854 2002-11-21 Miguel de Icaza <miguel@ximian.com>
9856 * typemanager.cs (FilterWithClosure): Commented out the test for
9857 1540 in typemanager.cs, as it has problems when accessing
9858 protected methods from a parent class (see test-174.cs).
9860 * attribute.cs (Attribute.ValidateGuid): new method.
9861 (Attribute.Resolve): Use above.
9863 2002-11-19 Miguel de Icaza <miguel@ximian.com>
9865 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
9867 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
9868 handling for enumerations, as we only needed the TypeContainer
9869 functionality to begin with (this is required for the fix below to
9870 work for enums that reference constants in a container class for
9873 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
9875 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
9876 a valid TypeBuilder to perform lookups on.o
9878 * class.cs (InheritableMemberSignatureCompare): Use true in the
9879 call to GetGetMethod and GetSetMethod, because we are comparing
9880 the signature, and we need to get the methods *even* if they are
9883 (PropertyBase.CheckBase): ditto.
9885 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
9886 GotoCase.Resolve): Use Peel on EmpytCasts.
9888 * ecore.cs (EmptyCast): drop child, add Peel method.
9890 2002-11-17 Martin Baulig <martin@ximian.com>
9892 * ecore.cs (EmptyCast.Child): New public property.
9894 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
9895 label resolved to an EmptyCast. Fixes #34162.
9896 (GotoCase.Resolve): Likewise.
9897 (Block.EmitMeta): Likewise.
9899 2002-11-17 Martin Baulig <martin@ximian.com>
9901 * expression.cs (Invocation.BetterConversion): Prefer int over
9902 uint; short over ushort; long over ulong for integer literals.
9903 Use ImplicitConversionExists instead of StandardConversionExists
9904 since we also need to check for user-defined implicit conversions.
9905 Fixes #34165. Added test-173.cs.
9907 2002-11-16 Martin Baulig <martin@ximian.com>
9909 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
9910 with the `true' and `false' literals. Fixes #33151.
9912 2002-11-16 Martin Baulig <martin@ximian.com>
9914 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
9915 October 22nd; don't do the cs1540 check for static members.
9917 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
9918 now using our own filter here and doing the cs1540 check again.
9920 2002-11-16 Martin Baulig <martin@ximian.com>
9922 * support.cs (InternalParameters): Don't crash if we don't have
9923 any fixed parameters. Fixes #33532.
9925 2002-11-16 Martin Baulig <martin@ximian.com>
9927 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
9928 when looking up static methods to make this work on Windows.
9931 2002-11-16 Martin Baulig <martin@ximian.com>
9933 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
9934 a setter rather than using PropertyInfo.CanWrite.
9936 2002-11-15 Nick Drochak <ndrochak@gol.com>
9938 * class.cs: Allow acces to block member by subclasses. Fixes build
9941 2002-11-14 Martin Baulig <martin@ximian.com>
9943 * class.cs (Constructor.Emit): Added the extern/block check.
9946 2002-11-14 Martin Baulig <martin@ximian.com>
9948 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
9949 iteration while looking for indexers, this is needed because the
9950 indexer may have a different name in our base classes. Fixed the
9951 error reporting (no indexers at all, not get accessor, no
9952 overloaded match). Fixes bug #33089.
9953 (IndexerAccess.DoResolveLValue): Likewise.
9955 2002-11-14 Martin Baulig <martin@ximian.com>
9957 * class.cs (PropertyBase.CheckBase): Make this work for multiple
9958 indexers. Fixes the first part of bug #33089.
9959 (MethodSignature.InheritableMemberSignatureCompare): Added support
9962 2002-11-13 Ravi Pratap <ravi@ximian.com>
9964 * attribute.cs (Attribute.Resolve): Catch the
9965 NullReferenceException and report it since it isn't supposed to
9968 2002-11-12 Miguel de Icaza <miguel@ximian.com>
9970 * expression.cs (Binary.EmitBranchable): Also handle the cases for
9971 LogicalOr and LogicalAnd that can benefit from recursively
9972 handling EmitBranchable. The code now should be nice for Paolo.
9974 2002-11-08 Miguel de Icaza <miguel@ximian.com>
9976 * typemanager.cs (LookupType): Added a negative-hit hashtable for
9977 the Type lookups, as we perform quite a number of lookups on
9978 non-Types. This can be removed once we can deterministically tell
9979 whether we have a type or a namespace in advance.
9981 But this might require special hacks from our corlib.
9985 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
9986 and double which avoids a conversion from an integer to a double.
9988 * expression.cs: tiny optimization, avoid calling IsConstant,
9989 because it effectively performs the lookup twice.
9991 2002-11-06 Miguel de Icaza <miguel@ximian.com>
9993 But a bogus return here to keep the semantics of the old code
9994 until the Mono runtime is fixed.
9996 * pending.cs (GetMissingInterfaces): New method used to remove all
9997 the interfaces that are already implemented by our parent
9998 classes from the list of pending methods.
10000 * interface.cs: Add checks for calls after ResolveTypeExpr.
10002 2002-11-05 Miguel de Icaza <miguel@ximian.com>
10004 * class.cs (Class.Emit): Report warning 67: event not used if the
10005 warning level is beyond 3.
10007 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
10008 being a NullLiteral.
10010 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
10013 * class.cs (TypeContainer.GetClassBases): Cover a missing code
10014 path that might fail if a type can not be resolved.
10016 * expression.cs (Binary.Emit): Emit unsigned versions of the
10019 * driver.cs: use error 5.
10021 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
10023 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
10025 2002-11-01 Miguel de Icaza <miguel@ximian.com>
10027 * cs-parser.jay (switch_section): A beautiful patch from Martin
10028 Baulig that fixed 33094.
10030 2002-10-31 Miguel de Icaza <miguel@ximian.com>
10032 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
10033 Check whether the base is abstract and report an error if so.
10035 * expression.cs (IndexerAccess.DoResolveLValue,
10036 IndexerAccess.DoResolve): ditto.
10038 (Invocation.DoResolve): ditto.
10040 (Invocation.FullMethodDesc): Improve the report string.
10042 * statement.cs (Block): Eliminate IsVariableDefined as it is
10043 basically just a wrapper for GetVariableInfo.
10045 * ecore.cs (SimpleName): Use new
10047 * support.cs (ReflectionParamter.ParameterType): We unwrap the
10048 type, as we return the actual parameter ref/unref state on a
10051 2002-10-30 Miguel de Icaza <miguel@ximian.com>
10053 * support.cs: Return proper flags REF/OUT fixing the previous
10056 * expression.cs: Reverted last patch, that was wrong. Is_ref is
10057 not used to mean `ref' but `ref or out' in ParameterReference
10059 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
10060 full type signature instead of calling TypeManger.CSharpName
10063 * support.cs (InternalParameters.ParameterDesc): Do not compare
10064 directly to the modflags, because REF/OUT will actually be bitsets
10067 * delegate.cs (VerifyMethod): Check also the modifiers.
10069 * cs-tokenizer.cs: Fix bug where floating point values with an
10070 exponent where a sign was missing was ignored.
10072 * driver.cs: Allow multiple assemblies to be specified in a single
10075 2002-10-28 Miguel de Icaza <miguel@ximian.com>
10077 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
10078 because identifiers after a parenthesis would end up in this kind
10079 of production, and we needed to desamiguate it for having casts
10082 (UserDefinedType *) xxx
10084 2002-10-24 Miguel de Icaza <miguel@ximian.com>
10086 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
10087 we should set on the Bindingflags.NonPublic, but not turn on
10088 private_ok. private_ok controls whether a Private member is
10089 returned (this is chekced on the filter routine), while the
10090 BindingFlags.NonPublic just controls whether private/protected
10091 will be allowed. This fixes the problem part of the problem of
10092 private properties being allowed to be used in derived classes.
10094 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
10095 so we can call the children DoResolveLValue method (this will
10096 properly signal errors on lvalue assignments to base properties)
10098 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
10099 getter are null, and we have a property info, we know that this
10100 happened because the lookup failed, so we report an error 122 for
10101 protection level violation.
10103 We also silently return if setter and getter are null in the
10104 resolve functions, this condition only happens if we have flagged
10105 the error before. This is the other half of the problem.
10107 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
10108 not have accessibility information, that is why we were returning
10109 true in the filter function in typemanager.cs.
10111 To properly report 122 (property is inaccessible because of its
10112 protection level) correctly, we report this error in ResolveAccess
10113 by failing if both the setter and the getter are lacking (ie, the
10116 DoResolve and DoLResolve have been modified to check for both
10117 setter/getter being null and returning silently, the reason being
10118 that I did not want to put the knowledge about this error in upper
10121 int old = Report.Errors;
10122 x = new PropertyExpr (...);
10123 if (old != Report.Errors)
10128 So the property expr is returned, but it is invalid, so the error
10129 will be flagged during the resolve process.
10131 * class.cs: Remove InheritablePropertySignatureCompare from the
10132 class, as we no longer depend on the property signature to compute
10133 whether it is possible to implement a method or not.
10135 The reason is that calling PropertyInfo.GetGetMethod will return
10136 null (in .NET, in Mono it works, and we should change this), in
10137 cases where the Get Method does not exist in that particular
10142 class X { public virtual int A { get { return 1; } } }
10144 class Z : Y { public override int A { get { return 2; } } }
10146 Would fail in Z because the parent (Y) would not have the property
10147 defined. So we avoid this completely now (because the alternative
10148 fix was ugly and slow), and we now depend exclusively on the
10151 (PropertyBase.CheckBase): Use a method-base mechanism to find our
10152 reference method, instead of using the property.
10154 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
10155 routines are gone now.
10157 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
10158 names, they were incorrectly named.
10160 * cs-tokenizer.cs: Return are more gentle token on failure.
10162 * pending.cs (PendingImplementation.InterfaceMethod): This routine
10163 had an out-of-sync index variable, which caused it to remove from
10164 the list of pending methods the wrong method sometimes.
10166 2002-10-22 Miguel de Icaza <miguel@ximian.com>
10168 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
10169 CanWrite, because those refer to this particular instance of the
10170 property, and do not take into account the fact that we can
10171 override single members of a property.
10173 Constructor requires an EmitContext. The resolution process does
10174 not happen here, but we need to compute the accessors before,
10175 because the resolution does not always happen for properties.
10177 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
10178 subclass, before we did not update this flag, but we did update
10181 (GetAccessors): Drop this routine, as it did not work in the
10182 presence of partially overwritten set/get methods.
10184 Notice that this broke the cs1540 detection, but that will require
10187 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10191 * driver.cs: issue a warning instead of an error if we don't support
10192 debugging for the platform. Also ignore a couple of errors that may
10193 arise when trying to write the symbols. Undo my previous patch.
10195 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10197 * driver.cs: ignore /debug switch except for Unix platforms.
10199 2002-10-23 Nick Drochak <ndrochak@gol.com>
10201 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
10203 2002-10-21 Miguel de Icaza <miguel@ximian.com>
10205 * driver.cs: Do not make mcs-debug conditional, so we do not break
10206 builds that use it.
10208 * statement.cs (UsageVector.MergeChildren): I would like Martin to
10209 review this patch. But basically after all the children variables
10210 have been merged, the value of "Breaks" was not being set to
10211 new_breaks for Switch blocks. I think that it should be set after
10212 it has executed. Currently I set this to the value of new_breaks,
10213 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
10214 conservative, but I do not understand this code very well.
10216 I did not break anything in the build, so that is good ;-)
10218 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
10220 2002-10-20 Mark Crichton <crichton@gimp.org>
10222 * cfold.cs: Fixed compile blocker. Really fixed it this time.
10224 2002-10-20 Nick Drochak <ndrochak@gol.com>
10226 * cfold.cs: Fixed compile blocker.
10228 2002-10-20 Miguel de Icaza <miguel@ximian.com>
10230 * driver.cs: I was chekcing the key, not the file.
10232 2002-10-19 Ravi Pratap <ravi@ximian.com>
10234 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
10235 message that we were generating - we just need to silently return
10238 2002-10-19 Miguel de Icaza <miguel@ximian.com>
10240 * class.cs (Event.Define): Change my previous commit, as this
10241 breaks the debugger. This is a temporary hack, as it seems like
10242 the compiler is generating events incorrectly to begin with.
10244 * expression.cs (Binary.ResolveOperator): Added support for
10245 "U operator - (E x, E y)"
10247 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
10250 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
10251 init-only variables, but this path did not take into account that
10252 there might be also instance readonly variables. Correct this
10255 This fixes bug 32253
10257 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
10260 * driver.cs: Change the extension for modules to `netmodule'
10262 * cs-parser.jay: Improved slightly the location tracking for
10263 the debugger symbols.
10265 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
10266 modifiers that were specified instead of the hardcoded value
10267 (FamAndAssem). This was basically ignoring the static modifier,
10268 and others. Fixes 32429.
10270 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
10271 fixed a bug in the process (32476)
10273 * expression.cs (ArrayAccess.EmitAssign): Patch from
10274 hwang_rob@yahoo.ca that fixes bug 31834.3
10276 2002-10-18 Miguel de Icaza <miguel@ximian.com>
10278 * driver.cs: Make the module extension .netmodule.
10280 2002-10-16 Miguel de Icaza <miguel@ximian.com>
10282 * driver.cs: Report an error if the resource file is not found
10283 instead of crashing.
10285 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
10286 false, like Emit does.
10288 2002-10-16 Nick Drochak <ndrochak@gol.com>
10290 * typemanager.cs: Remove unused private member. Also reported mcs
10291 bug to report this as a warning like csc.
10293 2002-10-15 Martin Baulig <martin@gnome.org>
10295 * statement.cs (Statement.Emit): Made this a virtual method; emits
10296 the line number info and calls DoEmit().
10297 (Statement.DoEmit): New protected abstract method, formerly knows
10298 as Statement.Emit().
10300 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
10302 2002-10-11 Miguel de Icaza <miguel@ximian.com>
10304 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
10305 have fixed a remaining problem: not every AddXXXX was adding a
10306 fully qualified name.
10308 Now everyone registers a fully qualified name in the DeclSpace as
10309 being defined instead of the partial name.
10311 Downsides: we are slower than we need to be due to the excess
10312 copies and the names being registered this way.
10314 The reason for this is that we currently depend (on the corlib
10315 bootstrap for instance) that types are fully qualified, because
10316 we dump all the types in the namespace, and we should really have
10317 types inserted into the proper namespace, so we can only store the
10318 basenames in the defined_names array.
10320 2002-10-10 Martin Baulig <martin@gnome.org>
10322 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
10323 from bug #31834, see the bug report for a testcase which is
10326 2002-10-10 Martin Baulig <martin@gnome.org>
10328 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
10329 flow analysis code for this.
10331 * statement.cs (Do, While, For): Tell the flow analysis code about
10333 (FlowBranching.UsageVector): Added support for infinite loops.
10334 (Block.Resolve): Moved the dead code elimination here and use flow
10337 2002-10-09 Miguel de Icaza <miguel@ximian.com>
10339 * class.cs (Field.Define): Catch cycles on struct type
10342 * typemanager.cs (IsUnmanagedtype): Do not recursively check
10343 fields if the fields are static. We only need to check instance
10346 * expression.cs (As.DoResolve): Test for reference type.
10348 * statement.cs (Using.ResolveExpression): Use
10349 ConvertImplicitRequired, not ConvertImplicit which reports an
10351 (Using.ResolveLocalVariableDecls): ditto.
10353 * expression.cs (Binary.ResolveOperator): Report errors in a few
10354 places where we had to.
10356 * typemanager.cs (IsUnmanagedtype): Finish implementation.
10358 2002-10-08 Miguel de Icaza <miguel@ximian.com>
10360 * expression.cs: Use StoreFromPtr instead of extracting the type
10361 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
10363 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
10364 an enumeration value to a System.Enum, but System.Enum is not a
10365 value type, but an class type, so we need to box.
10367 (Expression.ConvertExplicit): One codepath could return
10368 errors but not flag them. Fix this. Fixes #31853
10370 * parameter.cs (Resolve): Do not allow void as a parameter type.
10372 2002-10-06 Martin Baulig <martin@gnome.org>
10374 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
10375 if it's a class type and not a struct. Fixes #31815.
10377 2002-10-06 Martin Baulig <martin@gnome.org>
10379 * statement.cs: Reworked the flow analysis code a bit to make it
10380 usable for dead code elimination.
10382 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10384 * cs-parser.jay: allow empty source files. Fixes bug #31781.
10386 2002-10-04 Miguel de Icaza <miguel@ximian.com>
10388 * expression.cs (ComposedCast.DoResolveType): A quick workaround
10389 to fix the test 165, will investigate deeper.
10391 2002-10-04 Martin Baulig <martin@gnome.org>
10393 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
10394 finally blocks actually work.
10395 (Try.Resolve): We don't need to create a sibling for `finally' if
10396 there is no finally block.
10398 2002-10-04 Martin Baulig <martin@gnome.org>
10400 * class.cs (Constructor.Define): The default accessibility for a
10401 non-default constructor is private, not public.
10403 2002-10-04 Miguel de Icaza <miguel@ximian.com>
10405 * class.cs (Constructor): Make AllowedModifiers public, add
10408 * cs-parser.jay: Perform the modifiers test here, as the
10409 constructor for the Constructor class usually receives a zero
10410 because of the way we create it (first we create, later we
10411 customize, and we were never checking the modifiers).
10413 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
10414 is a version of LookupTypeReflection that includes the type-name
10415 cache. This can be used as a fast path for functions that know
10416 the fully qualified name and are only calling into *.GetType() to
10417 obtain a composed type.
10419 This is also used by TypeManager.LookupType during its type
10422 (LookupType): We now also track the real type name, as sometimes
10423 we can get a quey for the real type name from things like
10424 ComposedCast. This fixes bug 31422.
10426 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
10427 complete type fullname, it does not have to go through the type
10428 resolution system to obtain the composed version of the type (for
10429 obtaining arrays or pointers).
10431 (Conditional.Emit): Use the EmitBoolExpression to
10432 generate nicer code, as requested by Paolo.
10434 (ArrayCreation.CheckIndices): Use the patch from
10435 hwang_rob@yahoo.ca to validate the array initializers.
10437 2002-10-03 Miguel de Icaza <miguel@ximian.com>
10439 * class.cs (ConstructorInitializer.Emit): simplify code by using
10440 Invocation.EmitCall, and at the same time, fix the bugs in calling
10441 parent constructors that took variable arguments.
10443 * ecore.cs (Expression.ConvertNumericExplicit,
10444 Expression.ImplicitNumericConversion): Remove the code that
10445 manually wrapped decimal (InternalTypeConstructor call is now gone
10448 * expression.cs (Cast.TryReduce): Also handle decimal types when
10449 trying to perform a constant fold on the type.
10451 * typemanager.cs (IsUnmanagedtype): Partially implemented.
10453 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
10454 that only turned off an error report, and did nothing else.
10456 2002-10-02 Miguel de Icaza <miguel@ximian.com>
10458 * driver.cs: Handle and ignore /fullpaths
10460 2002-10-01 Miguel de Icaza <miguel@ximian.com>
10462 * expression.cs (Binary.ResolveOperator): Catch the case where
10463 DoNumericPromotions returns true,
10465 (Binary.DoNumericPromotions): Simplify the code, and the tests.
10467 2002-09-27 Miguel de Icaza <miguel@ximian.com>
10469 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
10472 2002-09-26 Miguel de Icaza <miguel@ximian.com>
10474 * ecore.cs (ConvertNumericExplicit): It is not enough that the
10475 conversion exists, but it is also required that the conversion be
10476 performed. This manifested in "(Type64Enum) 2".
10478 * class.cs (TypeManager.AddMethod): The fix is not to change
10479 AddEnum, because that one was using a fully qualified name (every
10480 DeclSpace derivative does), but to change the AddMethod routine
10481 that was using an un-namespaced name. This now correctly reports
10482 the duplicated name.
10484 Revert patch until I can properly fix it. The issue
10485 is that we have a shared Type space across all namespaces
10486 currently, which is wrong.
10488 Options include making the Namespace a DeclSpace, and merge
10489 current_namespace/current_container in the parser.
10491 2002-09-25 Miguel de Icaza <miguel@ximian.com>
10493 * cs-parser.jay: Improve error reporting when we get a different
10494 kind of expression in local_variable_type and
10495 local_variable_pointer_type.
10497 Propagate this to avoid missleading errors being reported.
10499 * ecore.cs (ImplicitReferenceConversion): treat
10500 TypeManager.value_type as a target just like object_type. As
10505 Is valid, and needs to result in the int 1 being boxed before it
10506 is assigned to the value type v.
10508 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
10509 to validate the enumeration name.
10511 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
10512 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
10513 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
10515 * ecore.cs (TryImplicitIntConversion): When doing an
10516 implicit-enumeration-conversion, check if the type is 64-bits and
10517 perform a conversion before passing to EnumConstant.
10519 2002-09-23 Miguel de Icaza <miguel@ximian.com>
10521 * decl.cs (Error_AmbiguousTypeReference); New routine used to
10522 report ambiguous type references. Unlike the MS version, we
10523 report what the ambiguity is. Innovation at work ;-)
10525 (DeclSpace.FindType): Require a location argument to
10526 display when we display an ambiguous error.
10528 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
10530 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
10532 * expression.cs (EmitDynamicInitializers): Apply patch from
10533 hwang_rob@yahoo.ca that fixes the order in which we emit our
10536 2002-09-21 Martin Baulig <martin@gnome.org>
10538 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
10539 delegate takes no arguments.
10541 2002-09-20 Miguel de Icaza <miguel@ximian.com>
10543 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
10546 * expression.cs: Extract the underlying type.
10548 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
10550 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
10552 2002-09-19 Miguel de Icaza <miguel@ximian.com>
10554 * class.cs (TypeContainer.DefineType): We can not use the nice
10555 PackingSize with the size set to 1 DefineType method, because it
10556 will not allow us to define the interfaces that the struct
10559 This completes the fixing of bug 27287
10561 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
10562 means also structs. This fixes part of the problem.
10563 (Expresion.ImplicitReferenceConversionExists): ditto.
10565 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
10566 error if there were no errors reported during the type lookup
10567 process, to avoid duplicates or redundant errors. Without this
10568 you would get an ambiguous errors plus a type not found. We have
10569 beaten the user enough with the first error.
10571 (DeclSparce.FindType): Emit a warning if we have an ambiguous
10574 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
10575 during the resolution process, stop the lookup, this avoids
10576 repeated error reports (same error twice).
10578 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
10580 * typemanager.cs (LookupType): Redo the type lookup code to match
10581 the needs of System.Reflection.
10583 The issue is that System.Reflection requires references to nested
10584 types to begin with a "+" sign instead of a dot. So toplevel
10585 types look like: "NameSpace.TopLevelClass", and nested ones look
10586 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
10589 2002-09-19 Martin Baulig <martin@gnome.org>
10591 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
10592 says that a method always returns or always throws an exception,
10593 don't report the CS0161.
10595 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
10596 set `Returns = new_returns'.
10598 2002-09-19 Martin Baulig <martin@gnome.org>
10600 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
10601 to an enum constant, check for a CS0176.
10603 2002-09-18 Miguel de Icaza <miguel@ximian.com>
10605 * class.cs (TypeContainer.CheckPairedOperators): Now we check
10606 for operators that must be in pairs and report errors.
10608 * ecore.cs (SimpleName.DoResolveType): During the initial type
10609 resolution process, when we define types recursively, we must
10610 check first for types in our current scope before we perform
10611 lookups in the enclosing scopes.
10613 * expression.cs (MakeByteBlob): Handle Decimal blobs.
10615 (Invocation.VerifyArgumentsCompat): Call
10616 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
10617 I thought we were supposed to always call this, but there are a
10618 few places in the code where we dont do it.
10620 2002-09-17 Miguel de Icaza <miguel@ximian.com>
10622 * driver.cs: Add support in -linkres and -resource to specify the
10623 name of the identifier.
10625 2002-09-16 Miguel de Icaza <miguel@ximian.com>
10627 * ecore.cs (StandardConversionExists): Sync with the conversion
10628 code: allow anything-* to void* conversions.
10630 (FindMostSpecificSource): Use an Expression argument
10631 instead of a Type, because we might be handed over a Literal which
10632 gets a few more implicit conversions that plain types do not. So
10633 this information was being lost.
10635 Also, we drop the temporary type-holder expression when not
10638 2002-09-17 Martin Baulig <martin@gnome.org>
10640 * class.cs (PropertyBase.CheckBase): Don't check the base class if
10641 this is an explicit interface implementation.
10643 2002-09-17 Martin Baulig <martin@gnome.org>
10645 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
10646 different `IndexerName' attributes.
10648 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
10649 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
10650 virtual CommonResolve().
10652 2002-09-16 Miguel de Icaza <miguel@ximian.com>
10654 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
10655 and convert that to the UnderlyingType.
10657 * statement.cs (Foreach.Resolve): Indexers are just like variables
10658 or PropertyAccesses.
10660 * cs-tokenizer.cs (consume_string): Track line numbers and columns
10661 inside quoted strings, we were not doing this before.
10663 2002-09-16 Martin Baulig <martin@gnome.org>
10665 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
10666 resolve it. This is needed for the definite assignment check of the
10667 instance expression, fixes bug #29846.
10668 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
10670 2002-09-16 Nick Drochak <ndrochak@gol.com>
10672 * parameter.cs: Fix compile error. Cannot reference static member
10673 from an instance object. Is this an mcs bug?
10675 2002-09-14 Martin Baulig <martin@gnome.org>
10677 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
10678 multiple times. Fixes bug #30295, added test-166.cs.
10680 2002-09-14 Martin Baulig <martin@gnome.org>
10682 * statement.cs (Block.Emit): Don't emit unreachable code.
10683 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
10684 `break' statements.
10685 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
10687 2002-09-14 Martin Baulig <martin@gnome.org>
10689 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
10692 2002-09-14 Martin Baulig <martin@gnome.org>
10694 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
10695 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
10696 be false on the ms runtime.
10698 2002-09-13 Martin Baulig <martin@gnome.org>
10700 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
10701 the CS0038 error message.
10703 2002-09-12 Miguel de Icaza <miguel@ximian.com>
10705 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
10706 constant inside, return it.
10708 2002-09-12 Martin Baulig <martin@gnome.org>
10710 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
10711 implicit conversion can be done between enum types.
10713 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
10714 check whether an implicit conversion to the current enum's UnderlyingType
10715 exists and report an error if not.
10717 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
10718 without debugging support.
10720 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
10721 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
10723 2002-09-12 Martin Baulig <martin@gnome.org>
10725 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
10727 * ecore.cs (IMemberExpr.DeclaringType): New property.
10728 (SimpleName.SimpleNameResolve): Check whether we're accessing a
10729 nonstatic member of an outer type (CS0038).
10731 2002-09-11 Miguel de Icaza <miguel@ximian.com>
10733 * driver.cs: Activate the using-error detector at warning level
10734 4 (at least for MS-compatible APIs).
10736 * namespace.cs (VerifyUsing): Small buglett fix.
10738 * pending.cs (PendingImplementation): pass the container pointer.
10740 * interface.cs (GetMethods): Allow for recursive definition. Long
10741 term, I would like to move every type to support recursive
10742 definitions, not the current ordering mechanism that we have right
10745 The situation is this: Attributes are handled before interfaces,
10746 so we can apply attributes to interfaces. But some attributes
10747 implement interfaces, we will now handle the simple cases
10748 (recursive definitions will just get an error).
10750 * parameter.cs: Only invalidate types at the end if we fail to
10753 2002-09-09 Martin Baulig <martin@gnome.org>
10755 * ecore.cs (PropertyExpr.Emit): Also check for
10756 TypeManager.system_int_array_get_length so this'll also work when
10757 compiling corlib. Fixes #30003.
10759 2002-09-09 Martin Baulig <martin@gnome.org>
10761 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
10762 and throw an exception if we can't get the type's size. Fixed #30040,
10765 2002-09-09 Martin Baulig <martin@gnome.org>
10767 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
10769 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
10770 context. Fixes bug #30027.
10772 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
10773 virtual functions. Fixes bug #30043, added test-164.cs.
10775 2002-09-08 Ravi Pratap <ravi@ximian.com>
10777 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
10779 2002-09-08 Nick Drochak <ndrochak@gol.com>
10781 * driver.cs: Use an object to get the windows codepage since it's not a
10784 2002-09-08 Miguel de Icaza <miguel@ximian.com>
10786 * statement.cs (For.Emit): for infinite loops (test == null)
10787 return whether there is a break inside, not always "true".
10789 * namespace.cs (UsingEntry): New struct to hold the name of the
10790 using definition, the location where it is defined, and whether it
10791 has been used in a successful type lookup.
10793 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
10798 2002-09-06 Ravi Pratap <ravi@ximian.com>
10800 * attribute.cs : Fix incorrect code which relied on catching
10801 a NullReferenceException to detect a null being passed in
10802 where an object was expected.
10804 2002-09-06 Miguel de Icaza <miguel@ximian.com>
10806 * statement.cs (Try): flag the catch variable as assigned
10808 * expression.cs (Cast): Simplified by using ResolveType instead of
10809 manually resolving.
10811 * statement.cs (Catch): Fix bug by using ResolveType.
10813 2002-09-06 Ravi Pratap <ravi@ximian.com>
10815 * expression.cs (BetterConversion): Special case for when we have
10816 a NullLiteral as the argument and we have to choose between string
10817 and object types - we choose string the way csc does.
10819 * attribute.cs (Attribute.Resolve): Catch the
10820 NullReferenceException and report error #182 since the Mono
10821 runtime no more has the bug and having this exception raised means
10822 we tried to select a constructor which takes an object and is
10825 2002-09-05 Ravi Pratap <ravi@ximian.com>
10827 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
10828 message (1502, 1503) when we can't locate a method after overload
10829 resolution. This is much more informative and closes the bug
10832 * interface.cs (PopulateMethod): Return if there are no argument
10833 types. Fixes a NullReferenceException bug.
10835 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
10836 expressions too. Previously we were checking only in one place for
10837 positional arguments leaving out named arguments.
10839 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
10840 type to the enum type is not allowed. Remove code corresponding to
10843 (ConvertNumericExplicit): Allow explicit conversions from
10844 the underlying type to enum type. This precisely follows the spec
10845 and closes a bug filed by Gonzalo.
10847 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10850 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
10852 2002-09-03 Miguel de Icaza <miguel@ximian.com>
10854 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
10855 it was important that we stored the right value after the
10856 reduction in `converted'.
10858 2002-09-04 Martin Baulig <martin@gnome.org>
10860 * location.cs (Location.SymbolDocument): Use full pathnames for the
10863 2002-08-30 Miguel de Icaza <miguel@ximian.com>
10865 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
10866 of the expression resolve mechanism, because that will catch the
10867 SimpleName error failures.
10869 (Conditional): If we can not resolve the
10870 expression, return, do not crash.
10872 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10875 (location): display token name instead of its number.
10877 2002-08-28 Martin Baulig <martin@gnome.org>
10879 * expression.cs (Binary.ResolveOperator): Don't silently return
10880 but return an error if an operator cannot be applied between two
10883 2002-08-28 Martin Baulig <martin@gnome.org>
10885 * class.cs (Constructor.Define): Set the permission attributes
10886 correctly instead of making all constructors public.
10888 2002-08-28 Martin Baulig <martin@gnome.org>
10890 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
10891 for private members before reporting a CS0103; if we find anything,
10894 2002-08-28 Martin Baulig <martin@gnome.org>
10896 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
10897 to check whether `closure_start_type == closure_invocation_type',
10898 we also need to check whether `m.DeclaringType == closure_invocation_type'
10899 before bypassing the permission checks. We might be accessing
10900 protected/private members from the base class.
10901 (TypeManager.RealMemberLookup): Only set private_ok if private
10902 members were requested via BindingFlags.NonPublic.
10904 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
10906 * expression.cs (MemberAccess.ResolveMemberAccess): Set
10907 MethodGroupExpr.IsExplicitImpl if appropriate.
10908 (Invocation.DoResolve): Don't report the CS0120 for explicit
10909 interface implementations.
10911 2002-08-27 Martin Baulig <martin@gnome.org>
10913 * expression.cs (Invocation.DoResolve): If this is a static
10914 method and we don't have an InstanceExpression, we must report
10917 2002-08-25 Martin Baulig <martin@gnome.org>
10919 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
10920 `==' between a valuetype and an object.
10922 2002-08-25 Miguel de Icaza <miguel@ximian.com>
10924 * ecore.cs (TypeExpr): Provide a ToString method.
10926 2002-08-24 Martin Baulig <martin@gnome.org>
10928 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
10929 now called proggie.dbg and it's a binary file.
10931 2002-08-23 Martin Baulig <martin@gnome.org>
10933 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
10935 2002-08-23 Martin Baulig <martin@gnome.org>
10937 * struct.cs (MyStructInfo.ctor): Make this work with empty
10938 structs; it's not allowed to use foreach() on null.
10940 2002-08-23 Martin Baulig <martin@gnome.org>
10942 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
10943 writer the full pathname of the generated assembly.
10945 2002-08-23 Martin Baulig <martin@gnome.org>
10947 * statements.cs (FlowBranching.UsageVector.MergeChildren):
10948 A `finally' block never returns or breaks; improved handling of
10951 2002-08-23 Martin Baulig <martin@gnome.org>
10953 * statement.cs (Throw.Resolve): Allow `throw null'.
10955 2002-08-23 Martin Baulig <martin@gnome.org>
10957 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
10958 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
10959 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
10960 MemberLookup would return a wrong event if this is an explicit
10961 interface implementation and the class has an event with the same
10964 2002-08-23 Martin Baulig <martin@gnome.org>
10966 * statement.cs (Block.AddChildVariableNames): New public method.
10967 (Block.AddChildVariableName): Likewise.
10968 (Block.IsVariableNameUsedInChildBlock): Likewise.
10969 (Block.AddVariable): Check whether a variable name has already
10970 been used in a child block.
10972 * cs-parser.jay (declare_local_variables): Mark all variable names
10973 from the current block as being used in a child block in the
10976 2002-08-23 Martin Baulig <martin@gnome.org>
10978 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
10979 find the symbol writer.
10981 * driver.cs: csc also allows the arguments to /define being
10982 separated by commas, not only by semicolons.
10984 2002-08-23 Martin Baulig <martin@gnome.org>
10986 * interface.cs (Interface.GetMembers): Added static check for events.
10988 2002-08-15 Martin Baulig <martin@gnome.org>
10990 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
10991 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
10993 * ecore.cs (Expression.MemberLookup): Added documentation and explained
10994 why the MethodData.EmitDestructor() change was necessary.
10996 2002-08-20 Martin Baulig <martin@gnome.org>
10998 * class.cs (TypeContainer.FindMembers): Added static check for events.
11000 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
11002 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
11003 use Type.GetEvents(), not Type.FindMembers().
11005 2002-08-20 Martin Baulig <martin@gnome.org>
11007 * decl.cs (MemberCache): Added a special method cache which will
11008 be used for method-only searched. This ensures that a method
11009 search will return a MethodInfo with the correct ReflectedType for
11012 2002-08-20 Martin Baulig <martin@gnome.org>
11014 * decl.cs (DeclSpace.FindMembers): Made this public.
11016 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11018 * delegate.cs: fixed build on windows.
11019 [FIXME: Filed as bug #29150: MCS must report these errors.]
11021 2002-08-19 Ravi Pratap <ravi@ximian.com>
11023 * ecore.cs (StandardConversionExists): Return a false
11024 if we are trying to convert the void type to anything else
11025 since that is not allowed.
11027 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
11028 we flag error 70 in the event an event is trying to be accessed
11029 directly from outside the declaring type.
11031 2002-08-20 Martin Baulig <martin@gnome.org>
11033 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
11034 MemberCache from typemanager.cs to decl.cs.
11036 2002-08-19 Martin Baulig <martin@gnome.org>
11038 * class.cs (TypeContainer): Implement IMemberContainer.
11039 (TypeContainer.DefineMembers): Create the MemberCache.
11040 (TypeContainer.FindMembers): Do better BindingFlags checking; only
11041 return public members if BindingFlags.Public was given, check
11042 whether members are static.
11044 2002-08-16 Martin Baulig <martin@gnome.org>
11046 * decl.cs (DeclSpace.Define): Splitted this in Define and
11047 DefineMembers. DefineMembers is called first and initializes the
11050 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
11051 DefineMembers() on all our DeclSpaces.
11053 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
11054 but call DefineMembers() on all nested interfaces. We call their
11055 Define() in our new Define() function.
11057 * interface.cs (Interface): Implement IMemberContainer.
11058 (Interface.Define): Moved all code except the attribute stuf to
11060 (Interface.DefineMembers): Initialize the member cache.
11062 * typemanager.cs (IMemberFinder): Removed this interface, we don't
11063 need this anymore since we can use MemberCache.FindMembers directly.
11065 2002-08-19 Martin Baulig <martin@gnome.org>
11067 * typemanager.cs (MemberCache): When creating the cache for an
11068 interface type, add all inherited members.
11069 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
11070 to `out bool used_cache' and documented it.
11071 (TypeManager.MemberLookup): If we already used the cache in the first
11072 iteration, we don't need to do the interfaces check.
11074 2002-08-19 Martin Baulig <martin@gnome.org>
11076 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
11077 here from IMemberFinder and don't implement this interface anymore.
11078 (DeclSpace.MemberCache): Moved here from IMemberFinder.
11080 * typemanager.cs (IMemberFinder): This interface is now only used by
11081 classes which actually support the member cache.
11082 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
11083 since we only put DeclSpaces into this Hashtable.
11084 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
11085 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
11087 2002-08-16 Martin Baulig <martin@gnome.org>
11089 * typemanager.cs (ICachingMemberFinder): Removed.
11090 (IMemberFinder.MemberCache): New property.
11091 (TypeManager.FindMembers): Merged this with RealFindMembers().
11092 This function will never be called from TypeManager.MemberLookup()
11093 so we can't use the cache here, just the IMemberFinder.
11094 (TypeManager.MemberLookup_FindMembers): Check whether the
11095 IMemberFinder has a MemberCache and call the cache's FindMembers
11097 (MemberCache): Rewrote larger parts of this yet another time and
11098 cleaned it up a bit.
11100 2002-08-15 Miguel de Icaza <miguel@ximian.com>
11102 * driver.cs (LoadArgs): Support quoting.
11104 (Usage): Show the CSC-like command line arguments.
11106 Improved a few error messages.
11108 2002-08-15 Martin Baulig <martin@gnome.org>
11110 * typemanager.cs (IMemberContainer.Type): New property.
11111 (IMemberContainer.IsInterface): New property.
11113 The following changes are conditional to BROKEN_RUNTIME, which is
11114 defined at the top of the file.
11116 * typemanager.cs (MemberCache.MemberCache): Don't add the base
11117 class'es members, but add all members from TypeHandle.ObjectType
11118 if we're an interface.
11119 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
11120 is the current type.
11121 (MemberCache.CacheEntry.Container): Removed this field.
11122 (TypeHandle.GetMembers): Include inherited members.
11124 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11126 * typemanager.cs: fixed compilation and added a comment on a field that
11129 2002-08-15 Martin Baulig <martin@gnome.org>
11131 * class.cs (ConstructorInitializer.Resolve): In the
11132 Expression.MemberLookup call, use the queried_type as
11135 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
11136 declared' attribute, it's always true.
11137 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
11138 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
11139 temporary wrapper for FindMembers which tells MemberLookup whether
11140 members from the base classes are included in the return value.
11141 This will go away soon.
11142 (TypeManager.MemberLookup): Use this temporary hack here; once the
11143 new MemberCache is completed, we don't need to do the DeclaredOnly
11144 looping here anymore since the MemberCache will take care of this.
11145 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
11146 (MemberCache): When creating the MemberCache for a class, get
11147 members from the current class and all its base classes.
11148 (MemberCache.CacheEntry.Container): New field. This is a
11149 temporary hack until the Mono runtime is fixed to distinguish
11150 between ReflectedType and DeclaringType. It allows us to use MCS
11151 with both the MS runtime and the unfixed Mono runtime without
11152 problems and without accecting performance.
11153 (MemberCache.SearchMembers): The DeclaredOnly looping from
11154 TypeManager.MemberLookup is now done here.
11156 2002-08-14 Martin Baulig <martin@gnome.org>
11158 * statement.cs (MyStructInfo.MyStructInfo): Don't call
11159 Type.GetFields on dynamic types but get the fields from the
11160 corresponding TypeContainer.
11161 (MyStructInfo.GetStructInfo): Added check for enum types.
11163 * typemanager.cs (MemberList.IsSynchronized): Implemented.
11164 (MemberList.SyncRoot): Implemented.
11165 (TypeManager.FilterWithClosure): No need to check permissions if
11166 closure_start_type == closure_invocation_type, don't crash if
11167 closure_invocation_type is null.
11169 2002-08-13 Martin Baulig <martin@gnome.org>
11171 Rewrote TypeContainer.FindMembers to use a member cache. This
11172 gives us a speed increase of about 35% for the self-hosting MCS
11173 build and of about 15-20% for the class libs (both on GNU/Linux).
11175 * report.cs (Timer): New class to get enhanced profiling. This
11176 whole class is "TIMER" conditional since it remarkably slows down
11179 * class.cs (MemberList): New class. This is an IList wrapper
11180 which we're now using instead of passing MemberInfo[]'s around to
11181 avoid copying this array unnecessarily.
11182 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
11183 (ICachingMemberFinder, IMemberContainer): New interface.
11184 (TypeManager.FilterWithClosure): If `criteria' is null, the name
11185 has already been checked, otherwise use it for the name comparision.
11186 (TypeManager.FindMembers): Renamed to RealMemberFinder and
11187 provided wrapper which tries to use ICachingMemberFinder.FindMembers
11188 if possible. Returns a MemberList, not a MemberInfo [].
11189 (TypeHandle): New class, implements IMemberContainer. We create
11190 one instance of this class per type, it contains a MemberCache
11191 which is used to do the member lookups.
11192 (MemberCache): New class. Each instance of this class contains
11193 all members of a type and a name-based hash table.
11194 (MemberCache.FindMembers): This is our new member lookup
11195 function. First, it looks up all members of the requested name in
11196 the hash table. Then, it walks this list and sorts out all
11197 applicable members and returns them.
11199 2002-08-13 Martin Baulig <martin@gnome.org>
11201 In addition to a nice code cleanup, this gives us a performance
11202 increase of about 1.4% on GNU/Linux - not much, but it's already
11203 half a second for the self-hosting MCS compilation.
11205 * typemanager.cs (IMemberFinder): New interface. It is used by
11206 TypeManager.FindMembers to call FindMembers on a TypeContainer,
11207 Enum, Delegate or Interface.
11208 (TypeManager.finder_to_member_finder): New PtrHashtable.
11209 (TypeManager.finder_to_container): Removed.
11210 (TypeManager.finder_to_delegate): Removed.
11211 (TypeManager.finder_to_interface): Removed.
11212 (TypeManager.finder_to_enum): Removed.
11214 * interface.cs (Interface): Implement IMemberFinder.
11216 * delegate.cs (Delegate): Implement IMemberFinder.
11218 * enum.cs (Enum): Implement IMemberFinder.
11220 * class.cs (TypeContainer): Implement IMemberFinder.
11222 2002-08-12 Martin Baulig <martin@gnome.org>
11224 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
11226 2002-08-12 Martin Baulig <martin@gnome.org>
11228 * ecore.cs (ITypeExpression): New interface for expressions which
11230 (TypeExpression): Renamed to TypeLookupExpression.
11231 (Expression.DoResolve): If we're doing a types-only lookup, the
11232 expression must implement the ITypeExpression interface and we
11233 call DoResolveType() on it.
11234 (SimpleName): Implement the new ITypeExpression interface.
11235 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
11236 hack, the situation that we're only looking up types can't happen
11237 anymore when this method is called. Moved the type lookup code to
11238 DoResolveType() and call it.
11239 (SimpleName.DoResolveType): This ITypeExpression interface method
11240 is now doing the types-only lookup.
11241 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
11242 (ResolveFlags): Added MaskExprClass.
11244 * expression.cs (MemberAccess): Implement the ITypeExpression
11246 (MemberAccess.DoResolve): Added support for a types-only lookup
11247 when we're called via ITypeExpression.DoResolveType().
11248 (ComposedCast): Implement the ITypeExpression interface.
11250 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
11251 Expression.Resolve() with ResolveFlags.Type instead.
11253 2002-08-12 Martin Baulig <martin@gnome.org>
11255 * interface.cs (Interface.Define): Apply attributes.
11257 * attribute.cs (Attribute.ApplyAttributes): Added support for
11258 interface attributes.
11260 2002-08-11 Martin Baulig <martin@gnome.org>
11262 * statement.cs (Block.Emit): Only check the "this" variable if we
11263 do not always throw an exception.
11265 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
11266 whether the property has a set accessor.
11268 2002-08-11 Martin Baulig <martin@gnome.org>
11270 Added control flow analysis support for structs.
11272 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
11273 with control flow analysis turned off.
11274 (IVariable): New interface.
11275 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
11276 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
11277 (FieldExpr.DoResolve): Resolve the instance expression with flow
11278 analysis turned off and do the definite assignment check after the
11279 resolving when we know what the expression will resolve to.
11281 * expression.cs (LocalVariableReference, ParameterReference):
11282 Implement the new IVariable interface, only call the flow analysis
11283 code if ec.DoFlowAnalysis is true.
11284 (This): Added constructor which takes a Block argument. Implement
11285 the new IVariable interface.
11286 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
11287 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
11288 This does the definite assignment checks for struct members.
11290 * class.cs (Constructor.Emit): If this is a non-static `struct'
11291 constructor which doesn't have any initializer, call
11292 Block.AddThisVariable() to tell the flow analysis code that all
11293 struct elements must be initialized before control returns from
11296 * statement.cs (MyStructInfo): New public class.
11297 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
11298 argument to this indexer. If non-zero, check an individual struct
11299 member, not the whole struct.
11300 (FlowBranching.CheckOutParameters): Check struct members.
11301 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
11302 overloaded versions of these methods which take an additional
11303 `int field_idx' argument to check struct members.
11304 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
11305 overloaded versions of these methods which take an additional
11306 `string field_name' argument to check struct member.s
11307 (VariableInfo): Implement the IVariable interface.
11308 (VariableInfo.StructInfo): New public property. Returns the
11309 MyStructInfo instance of the variable if it's a struct or null.
11310 (Block.AddThisVariable): New public method. This is called from
11311 Constructor.Emit() for non-static `struct' constructor which do
11312 not have any initializer. It creates a special variable for the
11313 "this" instance variable which will be checked by the flow
11314 analysis code to ensure that all of the struct's fields are
11315 initialized before control returns from the constructor.
11316 (UsageVector): Added support for struct members. If a
11317 variable/parameter is a struct with N members, we reserve a slot
11318 in the usage vector for each member. A struct is considered fully
11319 initialized if either the struct itself (slot 0) or all its
11320 members are initialized.
11322 2002-08-08 Martin Baulig <martin@gnome.org>
11324 * driver.cs (Driver.MainDriver): Only report an error CS5001
11325 if there were no compilation errors.
11327 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
11328 `UnsafeContext' property to determine whether the parent is in
11329 unsafe context rather than checking the parent's ModFlags:
11330 classes nested in an unsafe class are unsafe as well.
11332 2002-08-08 Martin Baulig <martin@gnome.org>
11334 * statement.cs (UsageVector.MergeChildren): Distinguish between
11335 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
11336 we return. Added test17() and test18() to test-154.cs.
11338 2002-08-08 Martin Baulig <martin@gnome.org>
11340 * typemanager.cs (TypeManager.FilterWithClosure): If we have
11341 Family access, make sure the invoking type isn't a subclass of the
11342 queried type (that'd be a CS1540).
11344 * ecore.cs (Expression.MemberLookup): Added overloaded version of
11345 this method which takes an additional `Type invocation_type'.
11347 * expression.cs (BaseAccess.DoResolve): Use the base type as
11348 invocation and query type.
11349 (MemberAccess.DoResolve): If the lookup failed and we're about to
11350 report a CS0122, try a lookup with the ec.ContainerType - if this
11351 succeeds, we must report a CS1540.
11353 2002-08-08 Martin Baulig <martin@gnome.org>
11355 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
11356 (MethodGroupExpr): Implement the IMemberExpr interface.
11358 * expression (MemberAccess.ResolveMemberAccess): No need to have
11359 any special code for MethodGroupExprs anymore, they're now
11362 2002-08-08 Martin Baulig <martin@gnome.org>
11364 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
11365 Family, FamANDAssem and FamORAssem permissions.
11366 (TypeManager.IsSubclassOrNestedChildOf): New public method.
11368 2002-08-08 Martin Baulig <martin@gnome.org>
11370 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
11371 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
11374 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
11376 * driver.cs: implemented /resource option to embed managed resources.
11378 2002-08-07 Martin Baulig <martin@gnome.org>
11380 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
11381 (FieldBase.HasFieldInitializer): New public property.
11382 (FieldBase.GetInitializerExpression): New public method. Resolves and
11383 returns the field initializer and makes sure it is only resolved once.
11384 (TypeContainer.EmitFieldInitializers): Call
11385 FieldBase.GetInitializerExpression to get the initializer, this ensures
11386 that it isn't resolved multiple times.
11388 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
11389 the resolving process (SimpleName/MemberLookup) that we're currently
11390 emitting a field initializer (which must not access any instance members,
11391 this is an error CS0236).
11393 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
11394 argument, if the `IsFieldInitializer' flag is set, we must report and
11395 error CS0236 and not an error CS0120.
11397 2002-08-07 Martin Baulig <martin@gnome.org>
11399 * ecore.cs (IMemberExpr): New public interface.
11400 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
11401 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
11402 if the expression is an IMemberExpr.
11404 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
11405 to be null, implicitly default to `this' if we're non-static in
11406 this case. Simplified the code a lot by using the new IMemberExpr
11407 interface. Also fixed bug #28176 here.
11409 2002-08-06 Martin Baulig <martin@gnome.org>
11411 * cs-parser.jay (SimpleLookup): Removed. We need to create
11412 ParameterReferences during semantic analysis so that we can do a
11413 type-only search when resolving Cast, TypeOf and SizeOf.
11414 (block): Pass the `current_local_parameters' to the Block's
11417 * class.cs (ConstructorInitializer): Added `Parameters parameters'
11418 argument to the constructor.
11419 (ConstructorInitializer.Resolve): Create a temporary implicit
11420 block with the parameters.
11422 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
11423 references here if we aren't doing a type-only search.
11425 * statement.cs (Block): Added constructor which takes a
11426 `Parameters parameters' argument.
11427 (Block.Parameters): New public property.
11429 * support.cs (InternalParameters.Parameters): Renamed `parameters'
11430 to `Parameters' and made it public readonly.
11432 2002-08-06 Martin Baulig <martin@gnome.org>
11434 * ecore.cs (Expression.Warning): Made this public as well.
11436 * report.cs (Report.Debug): Print the contents of collections.
11438 2002-08-06 Martin Baulig <martin@gnome.org>
11440 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
11441 used to tell Resolve() which kinds of expressions it may return.
11442 (Expression.Resolve): Added overloaded version of this method which
11443 takes a `ResolveFlags flags' argument. This can be used to tell
11444 Resolve() which kinds of expressions it may return. Reports a
11446 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
11447 ResolveFlags.SimpleName.
11448 (Expression.Error118): Added overloaded version of this method which
11449 takes a `ResolveFlags flags' argument. It uses the flags to determine
11450 which kinds of expressions are allowed.
11452 * expression.cs (Argument.ResolveMethodGroup): New public method.
11453 Resolves an argument, but allows a MethodGroup to be returned.
11454 This is used when invoking a delegate.
11456 * TODO: Updated a bit.
11458 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11460 Fixed compilation with csc.
11462 * ecore.cs: Expression.Error made public. Is this correct? Should
11463 Warning be made public too?
11465 * expression.cs: use ea.Location instead of ea.loc.
11466 [FIXME: Filed as bug #28607: MCS must report these errors.]
11468 2002-08-06 Martin Baulig <martin@gnome.org>
11470 * ecore.cs (Expression.loc): Moved the location here instead of
11471 duplicating it in all derived classes.
11472 (Expression.Location): New public property.
11473 (Expression.Error, Expression.Warning): Made them non-static and
11474 removed the location argument.
11475 (Expression.Warning): Added overloaded version which takes an
11476 `int level' argument.
11477 (Expression.Error118): Make this non-static and removed the
11478 expression and location arguments.
11479 (TypeExpr): Added location argument to the constructor.
11481 * expression.cs (StaticCallExpr): Added location argument to
11483 (Indirection, PointerArithmetic): Likewise.
11484 (CheckedExpr, UnCheckedExpr): Likewise.
11485 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
11486 (StringPtr): Likewise.
11489 2002-08-05 Martin Baulig <martin@gnome.org>
11491 * expression.cs (BaseAccess.DoResolve): Actually report errors.
11493 * assign.cs (Assign.DoResolve): Check whether the source
11494 expression is a value or variable.
11496 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
11497 while resolving the corresponding blocks.
11499 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
11500 an error, don't silently return null.
11502 * statement.cs (Block.AddVariable): Do the error reporting here
11503 and distinguish between CS0128 and CS0136.
11504 (Block.DoResolve): Report all unused labels (warning CS0164).
11505 (LabeledStatement): Pass the location to the constructor.
11506 (LabeledStatement.HasBeenReferenced): New property.
11507 (LabeledStatement.Resolve): Set it to true here.
11509 * statement.cs (Return.Emit): Return success even after reporting
11510 a type mismatch error (CS0126 or CS0127), this is what csc does and
11511 it avoids confusing the users with any consecutive errors.
11513 2002-08-05 Martin Baulig <martin@gnome.org>
11515 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
11517 * const.cs (Const.LookupConstantValue): Catch circular definitions.
11519 * expression.cs (MemberAccess.DoResolve): Silently return if an
11520 error has already been reported.
11522 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
11523 error has already been reported.
11525 2002-08-05 Martin Baulig <martin@gnome.org>
11527 * statement.cs (UsageVector): Only initialize the `parameters'
11528 vector if we actually have any "out" parameters.
11530 2002-08-05 Martin Baulig <martin@gnome.org>
11532 * expression.cs (Binary.ResolveOperator): When combining delegates,
11533 they must have the same type.
11535 2002-08-05 Martin Baulig <martin@gnome.org>
11537 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
11538 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
11539 work with the ms runtime and we also don't need it: if we're a
11540 PropertyBuilder and not in the `indexer_arguments' hash, then we
11541 are a property and not an indexer.
11543 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
11544 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
11545 since the latter one doesn't work with the ms runtime.
11547 2002-08-03 Martin Baulig <martin@gnome.org>
11549 Fixed bugs #27998 and #22735.
11551 * class.cs (Method.IsOperator): New public field.
11552 (Method.CheckBase): Report CS0111 if there's already a method
11553 with the same parameters in the current class. Report CS0508 when
11554 attempting to change the return type of an inherited method.
11555 (MethodData.Emit): Report CS0179 if a method doesn't have a body
11556 and it's not marked abstract or extern.
11557 (PropertyBase): New abstract base class for Property and Indexer.
11558 (PropertyBase.CheckBase): Moved here from Property and made it work
11560 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
11561 the same so we can reuse it there.
11562 (Property, Indexer): Derive from PropertyBase.
11563 (MethodSignature.inheritable_property_signature_filter): New delegate
11564 to find properties and indexers.
11566 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
11567 argument and improved error reporting.
11569 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
11570 EmptyReadOnlyParameters and made it a property.
11572 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
11573 version of this method which takes a `PropertyInfo indexer'.
11574 (TypeManager.RegisterIndexer): New method.
11576 * class.cs: Added myself as author of this file :-)
11578 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11580 * class.cs: fixed compilation on windoze.
11582 2002-08-03 Martin Baulig <martin@gnome.org>
11584 * interface.cs (Interface.GetInterfaceBases): Check whether all
11585 base interfaces are at least as accessible than the current one.
11587 * class.cs (TypeContainer.GetClassBases): Check whether base types
11588 are at least as accessible than the current type.
11589 (TypeContainer.AsAccessible): Implemented and made non-static.
11590 (MemberBase.CheckParameters): Report errors if the accessibility
11593 * delegate.cs (Delegate.Delegate): The default visibility is
11594 internal for top-level types and private for nested types.
11595 (Delegate.Define): Report errors if the accessibility checks fail.
11597 * enum.cs (Enum.Enum): The default visibility is internal for
11598 top-level types and private for nested types.
11599 (Enum.DefineType): Compute the correct visibility.
11601 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
11602 function which takes a `bool is_toplevel' instead of a TypeContainer.
11604 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
11607 2002-08-02 Martin Baulig <martin@gnome.org>
11609 * expression.cs (LocalVariableReferenc): Added constructor which
11610 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
11611 (LocalVariableReference.IsReadOnly): New property.
11612 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
11613 variable is readonly, use our own readonly flag to do this; you can
11614 use the new constructor to get a writable reference to a read-only
11617 * cs-parser.jay (foreach_statement, using_statement): Get a writable
11618 reference to the local variable.
11620 2002-08-01 Miguel de Icaza <miguel@ximian.com>
11622 * rootcontext.cs (ResolveCore): Also include System.Exception
11624 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
11625 we reach an EmptyStatement.
11627 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
11630 * expression.cs (Binary.ResolveOperator): Check error result in
11633 use brtrue/brfalse directly and avoid compares to null.
11635 2002-08-02 Martin Baulig <martin@gnome.org>
11637 * class.cs (TypeContainer.Define): Define all nested interfaces here.
11638 Fixes bug #28407, added test-155.cs.
11640 2002-08-01 Martin Baulig <martin@gnome.org>
11642 * class.cs (Event.EmitDefaultMethod): Make this work with static
11643 events. Fixes #28311, added verify-3.cs.
11645 2002-08-01 Martin Baulig <martin@gnome.org>
11647 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
11648 `is_disposable' fields.
11649 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
11650 `hm.is_disposable' if we're using the collection pattern.
11651 (Foreach.EmitCollectionForeach): Use the correct type for the
11652 enumerator's local variable, only emit the try/finally block if
11653 necessary (fixes #27713).
11655 2002-08-01 Martin Baulig <martin@gnome.org>
11657 * ecore.cs (Expression.report118): Renamed to Error118 and made
11660 * statement.cs (Throw.Resolve): Check whether the expression is of
11661 the correct type (CS0118) and whether the type derives from
11662 System.Exception (CS0155).
11663 (Catch.Resolve): New method. Do the type lookup here and check
11664 whether it derives from System.Exception (CS0155).
11665 (Catch.CatchType, Catch.IsGeneral): New public properties.
11667 * typemanager.cs (TypeManager.exception_type): Added.
11669 2002-07-31 Miguel de Icaza <miguel@ximian.com>
11671 * driver.cs: Updated About function.
11673 2002-07-31 Martin Baulig <martin@gnome.org>
11675 Implemented Control Flow Analysis.
11677 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
11678 (EmitContext.CurrentBranching): Added.
11679 (EmitContext.StartFlowBranching): Added.
11680 (EmitContext.EndFlowBranching): Added.
11681 (EmitContext.KillFlowBranching): Added.
11682 (EmitContext.IsVariableAssigned): Added.
11683 (EmitContext.SetVariableAssigned): Added.
11684 (EmitContext.IsParameterAssigned): Added.
11685 (EmitContext.SetParameterAssigned): Added.
11686 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
11687 Added control flow analysis stuff here.
11689 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
11690 resolve the expression as lvalue.
11691 (LocalVariableReference.DoResolve): Check whether the variable has
11692 already been assigned.
11693 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
11694 the parameter as assigned here.
11695 (ParameterReference.DoResolve): Check whether the parameter has already
11697 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
11698 expression as lvalue.
11700 * statement.cs (FlowBranching): New class for the flow analysis code.
11701 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
11702 (LabeledStatement.IsDefined): New public property.
11703 (LabeledStatement.AddUsageVector): New public method to tell flow
11704 analyis that the label may be reached via a forward jump.
11705 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
11707 (VariableInfo.Number): New public field. This is used by flow analysis
11708 to number all locals of a block.
11709 (Block.CountVariables): New public property. This is the number of
11710 local variables in this block (including the locals from all parent
11712 (Block.EmitMeta): Number all the variables.
11714 * statement.cs: Added flow analysis support to all classes.
11716 2002-07-31 Martin Baulig <martin@gnome.org>
11718 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
11719 To get debugging messages, compile mcs with /define:MCS_DEBUG and
11720 then use this argument.
11722 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
11724 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
11725 use this to specify /define options.
11727 2002-07-29 Martin Baulig <martin@gnome.org>
11729 * statement.cs (Fixed): Moved all code that does variable lookups
11730 and resolvings from Emit to Resolve.
11732 * statement.cs (For): Moved all code that does variable lookups
11733 and resolvings from Emit to Resolve.
11735 * statement.cs (Using): Moved all code that does variable lookups
11736 and resolvings from Emit to Resolve.
11738 2002-07-29 Martin Baulig <martin@gnome.org>
11740 * attribute.cs (Attribute.Resolve): Explicitly catch a
11741 System.NullReferenceException when creating the
11742 CustromAttributeBuilder and report a different warning message.
11744 2002-07-29 Martin Baulig <martin@gnome.org>
11746 * support.cs (ParameterData.ParameterName): Added method to
11747 get the name of a parameter.
11749 * typemanager.cs (TypeManager.IsValueType): New public method.
11751 2002-07-29 Martin Baulig <martin@gnome.org>
11753 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
11754 is a flag which specifies that it's either ref or out.
11755 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
11756 the out parameter to `out Parameter.Modifier mod', also set the
11757 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
11759 * support.cs (InternalParameters.ParameterModifier): Distinguish
11760 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
11761 Parameter.Modifier.ISBYREF flag if it's either ref or out.
11763 * expression.cs (Argument.GetParameterModifier): Distinguish
11764 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
11765 Parameter.Modifier.ISBYREF flag if it's either ref or out.
11767 2002-07-29 Martin Baulig <martin@gnome.org>
11769 * expression.cs (ParameterReference.ParameterReference): Added
11770 `Location loc' argument to the constructor.
11772 * cs-parser.jay: Pass location to ParameterReference.
11774 2002-07-28 Miguel de Icaza <miguel@ximian.com>
11776 * statement.cs (Try): Initialize the location.
11778 * cs-parser.jay: pass location to Try.
11780 * expression.cs (Unary.Reduce): Change the prototype to return
11781 whether a constant fold could be performed or not. The result is
11782 returned in an out parameters. In the case of Indirection and
11783 AddressOf, we want to perform the full tests.
11785 2002-07-26 Miguel de Icaza <miguel@ximian.com>
11787 * statement.cs (Statement.Emit): Flag dead code.
11789 2002-07-27 Andrew Birkett <andy@nobugs.org>
11791 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
11793 2002-07-27 Martin Baulig <martin@gnome.org>
11795 * class.cs (MethodData.Define): Put back call to
11796 TypeManager.AddMethod(), accidentally commented this out.
11798 * report.cs (Debug): New public method to print debugging information,
11799 this is `[Conditional ("DEBUG")]'.
11801 2002-07-26 Martin Baulig <martin@gnome.org>
11803 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
11804 (switch_statement): Push the current_block to the switch_stack and
11805 pop it again when we're done with the switch.
11806 (switch_section): The new block is a child of the current_block.
11807 Fixes bug #24007, added test-152.cs.
11809 2002-07-27 Martin Baulig <martin@gnome.org>
11811 * expression.cs (Invocation.EmitArguments): When calling a varargs
11812 function with only its fixed arguments, we need to pass an empty
11815 2002-07-27 Martin Baulig <martin@gnome.org>
11817 Mono 0.13 has been released.
11819 2002-07-25 Miguel de Icaza <miguel@ximian.com>
11821 * driver.cs: Rename --resource to --linkres, because that is what
11822 we do currently, we dont support --resource yet.
11824 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
11826 2002-07-25 Martin Baulig <martin@gnome.org>
11828 * class.cs (MethodData): New public class. This is a `method builder'
11829 class for a method or one accessor of a Property/Indexer/Event.
11830 (MethodData.GetMethodFlags): Moved here from MemberBase.
11831 (MethodData.ApplyAttributes): Likewise.
11832 (MethodData.ApplyObsoleteAttribute): Likewise.
11833 (MethodData.ApplyConditionalAttribute): Likewise.
11834 (MethodData.ApplyDllImportAttribute): Likewise.
11835 (MethodData.CheckAbstractAndExternal): Likewise.
11836 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
11837 (MethodData.Emit): Formerly known as Method.Emit().
11838 (MemberBase): Moved everything which was specific to a single
11839 accessor/method to MethodData.
11840 (Method): Create a new MethodData and call Define() and Emit() on it.
11841 (Property, Indexer, Event): Create a new MethodData objects for each
11842 accessor and call Define() and Emit() on them.
11844 2002-07-25 Martin Baulig <martin@gnome.org>
11846 Made MethodCore derive from MemberBase to reuse the code from there.
11847 MemberBase now also checks for attributes.
11849 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
11850 (MemberBase.GetMethodFlags): Moved here from class Method and marked
11852 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
11853 `CallingConventions cc' and `Attributes opt_attrs' arguments.
11854 (MemberBase.ApplyAttributes): New virtual method; applies the
11855 attributes to a method or accessor.
11856 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
11857 (MemberBase.ApplyConditionalAttribute): Likewise.
11858 (MemberBase.ApplyDllImportAttribute): Likewise.
11859 (MemberBase.CheckAbstractAndExternal): Likewise.
11860 (MethodCore.ParameterTypes): This is now a property instead of a
11861 method, it's initialized from DoDefineParameters().
11862 (MethodCore.ParameterInfo): Removed the set accessor.
11863 (MethodCore.DoDefineParameters): New protected virtual method to
11864 initialize ParameterTypes and ParameterInfo.
11865 (Method.GetReturnType): We can now simply return the MemberType.
11866 (Method.GetMethodFlags): Override the MemberBase version and add
11867 the conditional flags.
11868 (Method.CheckBase): Moved some code from Define() here, call
11869 DoDefineParameters() here.
11870 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
11871 here to avoid some larger code duplication.
11872 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
11873 ensure that abstract and external accessors don't declare a body.
11875 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
11876 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
11877 lookup in the attribute's parent classes, so we need to abort as soon
11878 as we found the first match.
11879 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
11880 the attribute has no arguments.
11882 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
11885 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11887 * cs-parser.jay: reverted previous patch.
11889 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11891 * cs-parser.jay: fixed bug #22119.
11893 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11895 * attribute.cs: fixed compilation. The error was:
11896 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
11897 be assigned to before control leaves the current method."
11898 [FIXME: Filed as bug #28186: MCS must report this error.]
11900 2002-07-25 Martin Baulig <martin@gnome.org>
11902 * attribute.cs (Attribute.Conditional_GetConditionName): New static
11903 method to pull the condition name ouf of a Conditional attribute.
11904 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
11905 the obsolete message and error flag out of an Obsolete attribute.
11907 * class.cs (Method.GetMethodFlags): New public method to get the
11908 TypeManager.MethodFlags for this method.
11909 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
11911 (Method.Define): Get and apply the Obsolete and Conditional attributes;
11912 if we're overriding a virtual function, set the new private variable
11913 `parent_method'; call the new TypeManager.AddMethod().
11915 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
11916 the MethodBuilder and the Method in a PtrHashtable.
11917 (TypeManager.builder_to_method): Added for this purpose.
11918 (TypeManager.MethodFlags): Added IsObsoleteError.
11919 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
11920 Obsolete and Conditional arguments in MethodBuilders. If we discover
11921 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
11922 the message from the attribute.
11924 2002-07-24 Martin Baulig <martin@gnome.org>
11926 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
11927 preprocessor directives, ensure that the argument to #define/#undef is
11928 exactly one identifier and that it's actually an identifier.
11930 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
11933 2002-07-24 Martin Baulig <martin@gnome.org>
11935 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
11936 initialize it to TypeManager.object_type in the constructor.
11937 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
11938 of the `hm.get_current' method if we're using the collection pattern.
11939 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
11940 for the explicit conversion to make it work when we're using the collection
11941 pattern and the `Current' property has a different return type than `object'.
11944 2002-07-24 Martin Baulig <martin@gnome.org>
11946 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
11947 does not match, but don't report any errors. This method is called in
11948 order for all methods in a MethodGroupExpr until a matching method is
11949 found, so we don't want to bail out if the first method doesn't match.
11950 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
11951 matches, report the 123. Fixes #28070.
11953 2002-07-24 Martin Baulig <martin@gnome.org>
11955 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
11956 TypeManager.TypeToCoreType() to the top of the method so the
11957 following equality checks will work. Fixes #28107.
11959 2002-07-24 Martin Baulig <martin@gnome.org>
11961 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
11962 operand is of type uint, and the other operand is of type sbyte,
11963 short or int, the operands are converted to type long." -
11964 Actually do what this comment already told us. Fixes bug #28106,
11967 2002-07-24 Martin Baulig <martin@gnome.org>
11969 * class.cs (MethodBase): New abstract class. This is now a base
11970 class for Property, Indexer and Event to avoid some code duplication
11971 in their Define() and DefineMethods() methods.
11972 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
11973 generic methods for Define() and DefineMethods().
11974 (FieldBase): Derive from MemberBase, not MemberCore.
11975 (Property): Derive from MemberBase, not MemberCore.
11976 (Property.DefineMethod): Moved all the code from this method to the
11977 new MethodBase.DefineAccessor(), just call it with appropriate
11979 (Property.Define): Call the new Property.DoDefine(), this does some
11980 sanity checks and we don't need to duplicate the code everywhere.
11981 (Event): Derive from MemberBase, not MemberCore.
11982 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
11983 accessors, this will also make them work with interface events.
11984 (Indexer): Derive from MemberBase, not MemberCore.
11985 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
11986 (Indexer.Define): Use the new MethodBase functions.
11988 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
11989 argument to the constructor.
11990 (Interface.FindMembers): Added support for interface events.
11991 (Interface.PopluateEvent): Implemented.
11993 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
11995 2002-07-22 Miguel de Icaza <miguel@ximian.com>
11997 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
11998 but this is required to check for a method name being the same as
11999 the containing class.
12003 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
12005 * interface.cs: initialize variable.
12007 2002-07-23 Martin Baulig <martin@gnome.org>
12009 Implemented the IndexerName attribute in interfaces.
12011 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
12012 name if this is an explicit interface implementation.
12013 (Indexer.InterfaceIndexerName): New public variable. If we're
12014 implementing an interface indexer, this is the IndexerName in that
12015 interface. Otherwise, it's the IndexerName.
12016 (Indexer.DefineMethod): If we're implementing interface indexer,
12017 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
12018 and Pending.ImplementIndexer methods.
12019 (Indexer.Define): Also define the PropertyBuilder if we're
12020 implementing an interface indexer and this is neither an explicit
12021 interface implementation nor do the IndexerName match the one in
12024 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
12025 If a method is defined here, then we always need to create a proxy
12026 for it. This is used when implementing interface indexers.
12027 (Pending.IsInterfaceIndexer): New public method.
12028 (Pending.ImplementIndexer): New public method.
12029 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
12030 This is used when implementing interface indexers to define a proxy
12032 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
12033 define a proxy if necessary.
12035 * interface.cs (Interface.IndexerName): New public variable.
12036 (Interface.PopulateIndexer): Set the IndexerName.
12037 (Interface.DefineIndexers): New private method. Populate all the
12038 indexers and make sure their IndexerNames match.
12040 * typemanager.cs (IndexerPropertyName): Added support for interface
12043 2002-07-22 Martin Baulig <martin@gnome.org>
12045 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
12046 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
12047 ret if HasReturnLabel.
12048 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
12051 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
12052 and set the ec.LoopBeginTryCatchLevel.
12053 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
12054 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
12055 the current ec.TryCatchLevel, the branch goes out of an exception
12056 block. In this case, we need to use Leave and not Br.
12058 2002-07-22 Martin Baulig <martin@gnome.org>
12060 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
12061 block unless the block does not always return or it is contained in
12062 another try { ... } catch { ... } block. Fixes bug #26506.
12063 Added verify-1.cs to the test suite.
12065 2002-07-22 Martin Baulig <martin@gnome.org>
12067 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
12068 then we do not always return. Fixes bug #24985.
12070 2002-07-22 Martin Baulig <martin@gnome.org>
12072 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
12073 lookup on a per-class level; ie. walk up the class hierarchy until we
12074 found at least one applicable method, then choose the best among them.
12075 Fixes bug #24463 and test-29.cs.
12077 2002-07-22 Martin Baulig <martin@gnome.org>
12079 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
12080 return types of the methods. The return type is not part of the
12081 signature and we must not check it to make the `new' modifier work.
12082 Fixes bug #27999, also added test-147.cs.
12083 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
12085 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
12086 on the method's return type.
12088 2002-07-21 Martin Baulig <martin@gnome.org>
12090 * assign.cs: Make this work if the rightmost source is a constant and
12091 we need to do an implicit type conversion. Also adding a few more tests
12092 to test-38.cs which should have caught this.
12094 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
12095 target in the makefile for this. The makefile.gnu is primarily intended
12096 for end-users who don't want to debug the compiler.
12098 2002-07-21 Martin Baulig <martin@gnome.org>
12100 * assign.cs: Improved the Assign class so it can now handle embedded
12101 assignments (X = Y = Z = something). As a side-effect this'll now also
12102 consume less local variables. test-38.cs now passes with MCS, added
12103 a few new test cases to that test.
12105 2002-07-20 Martin Baulig <martin@gnome.org>
12107 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
12108 instructions. Fixes bug #27977, also added test-146.cs.
12110 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
12112 * cs-tokenizer.cs: fixed getHex ().
12114 2002-07-19 Martin Baulig <martin@gnome.org>
12116 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
12117 not Type.GetType() to lookup the array type. This is needed when
12118 we're constructing an array of a user-defined type.
12119 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
12120 single-dimensional arrays, but also for single-dimensial arrays of
12123 2002-07-19 Martin Baulig <martin@gnome.org>
12125 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
12126 this function is called, it's not allowed to share LocalBuilders
12127 among ILGenerators.
12129 2002-07-19 Martin Baulig <martin@gnome.org>
12131 * expression.cs (Argument.Resolve): Report an error 118 when trying
12132 to pass a type as argument.
12134 2002-07-18 Martin Baulig <martin@gnome.org>
12136 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
12137 Conv_R_Un for the signed `long' type.
12139 2002-07-15 Miguel de Icaza <miguel@ximian.com>
12141 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
12142 `expr' for the temporary result, as that will fail if we do
12143 multiple resolves on the same expression.
12145 2002-07-05 Miguel de Icaza <miguel@ximian.com>
12147 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
12148 ec.TypeContainer for looking up aliases.
12150 * class.cs (TypeContainer): Remove LookupAlias from here.
12152 * decl.cs (DeclSpace); Move here.
12154 2002-07-01 Miguel de Icaza <miguel@ximian.com>
12156 * class.cs (FindMembers): Only call filter if the constructor
12157 bulider is not null.
12159 Also handle delegates in `NestedTypes' now. Now we will perform
12160 type lookups using the standard resolution process. This also
12163 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
12164 This uses Expressions (the limited kind that can be parsed by the
12165 tree) instead of strings.
12167 * expression.cs (ComposedCast.ToString): Implement, used to flag
12168 errors since now we have to render expressions.
12170 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
12173 * ecore.cs (SimpleName.ToString): ditto.
12175 * cs-parser.jay: Instead of using strings to assemble types, use
12176 Expressions to assemble the type (using SimpleName, ComposedCast,
12177 MemberAccess). This should fix the type lookups in declarations,
12178 because we were using a different code path for this.
12180 * statement.cs (Block.Resolve): Continue processing statements
12181 even when there is an error.
12183 2002-07-17 Miguel de Icaza <miguel@ximian.com>
12185 * class.cs (Event.Define): Also remove the `remove' method from
12186 the list of pending items.
12188 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
12189 generate more compact code.
12191 2002-07-17 Martin Baulig <martin@gnome.org>
12193 * const.cs (Const.LookupConstantValue): Add support for constant
12194 `unchecked' and `checked' expressions.
12195 Also adding test case test-140.cs for this.
12197 2002-07-17 Martin Baulig <martin@gnome.org>
12199 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
12200 check whether mi.ReturnType implements the IEnumerator interface; the
12201 `==' and the IsAssignableFrom() will fail in this situation.
12203 2002-07-16 Ravi Pratap <ravi@ximian.com>
12205 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
12208 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
12210 * expression.cs: fixed bug #27811.
12212 2002-07-14 Miguel de Icaza <miguel@ximian.com>
12214 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
12215 Molaro: when we are a ref, the value already contains a pointer
12216 value, do not take the address of it.
12218 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
12219 * removed mb-parser.jay and mb-tokenizer.cs
12221 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
12223 * expression.cs: check against the building corlib void type.
12225 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
12227 * ecore.cs: fix for valuetype static readonly fields: when
12228 initializing them, we need their address, not the address of a copy.
12230 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
12232 * typemanager.cs: register also enum_type in corlib.
12234 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
12236 * class.cs: allow calling this (but not base) initializers in structs.
12238 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
12240 * ecore.cs: make sure we compare against the building base types
12243 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
12245 * typemanager.cs: fix TypeToCoreType() to handle void and object
12246 (corlib gets no more typerefs after this change).
12248 2002-07-12 Miguel de Icaza <miguel@ximian.com>
12250 * expression.cs (ArrayCreation.EmitArrayArguments): use
12251 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
12253 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
12254 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
12255 array indexes, the runtime actually forbids them.
12257 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
12258 for array arguments here.
12260 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
12261 instead of the default for ValueTypes.
12263 (New.DoEmit): Use IsValueType instead of
12264 IsSubclassOf (value_type)
12265 (New.DoResolve): ditto.
12266 (Invocation.EmitCall): ditto.
12268 * assign.cs (Assign): ditto.
12270 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
12271 Statements *are* currently doing part of their resolution during
12274 Expressions do always resolve during resolve, but statements are
12275 only required to propagate resolution to their children.
12277 2002-07-11 Miguel de Icaza <miguel@ximian.com>
12279 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
12281 (LoadAssembly): Do not add the dll if it is already specified
12283 (MainDriver): Add the System directory to the link path at the end,
12284 after all the other -L arguments.
12286 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
12287 wrong opcode for loading bytes and bools (ldelem.i1 instead of
12288 ldelem.u1) and using the opposite for sbytes.
12290 This fixes Digger, and we can finally run it.
12292 * driver.cs (UnixParseOption): Move the option parsing here.
12293 (CSCParseOption): Implement CSC-like parsing of options.
12295 We now support both modes of operation, the old Unix way, and the
12296 new CSC-like way. This should help those who wanted to make cross
12297 platform makefiles.
12299 The only thing broken is that /r:, /reference: and /lib: are not
12300 implemented, because I want to make those have the same semantics
12301 as the CSC compiler has, and kill once and for all the confussion
12302 around this. Will be doing this tomorrow.
12304 * statement.cs (Unsafe.Resolve): The state is checked during
12305 resolve, not emit, so we have to set the flags for IsUnsfe here.
12307 2002-07-10 Miguel de Icaza <miguel@ximian.com>
12309 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
12310 not catch the Error_ObjectRefRequired in SimpleName (as it is
12311 possible to have a class/instance variable name that later gets
12312 deambiguated), we have to check this here.
12314 2002-07-10 Ravi Pratap <ravi@ximian.com>
12316 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
12317 make static and put into Expression.
12319 (Event.Define): Register the private field of the event with the
12320 TypeManager so that GetFieldFromEvent can get at it.
12322 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
12323 keep track of the private field associated with an event which
12326 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
12329 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
12331 2002-07-10 Miguel de Icaza <miguel@ximian.com>
12333 * expression.cs (Binary.EmitBranchable): this routine emits the
12334 Binary expression in a branchable context. This basically means:
12335 we need to branch somewhere, not just get the value on the stack.
12337 This works together with Statement.EmitBoolExpression.
12339 * statement.cs (Statement.EmitBoolExpression): Use
12342 2002-07-09 Miguel de Icaza <miguel@ximian.com>
12344 * statement.cs (For): Reduce the number of jumps in loops.
12346 (For): Implement loop inversion for the For statement.
12348 (Break): We can be breaking out of a Try/Catch controlled section
12349 (foreach might have an implicit try/catch clause), so we need to
12350 use Leave instead of Br.
12352 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
12353 now). If the instace expression supports IMemoryLocation, we use
12354 the AddressOf method from the IMemoryLocation to extract the
12355 address instead of emitting the instance.
12357 This showed up with `This', as we were emitting the instance
12358 always (Emit) instead of the Address of This. Particularly
12359 interesting when This is a value type, as we dont want the Emit
12360 effect (which was to load the object).
12362 2002-07-08 Miguel de Icaza <miguel@ximian.com>
12364 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
12366 * statement.cs (Checked): Set the CheckedState during the resolve
12367 process too, as the ConvCast operations track the checked state on
12368 the resolve process, and not emit.
12370 * cs-parser.jay (namespace_member_declaration): Flag that we have
12371 found a declaration when we do. This is used to flag error 1529
12373 * driver.cs: Report ok when we display the help only.
12375 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
12377 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
12379 2002-07-04 Miguel de Icaza <miguel@ximian.com>
12381 * cs-tokenizer.cs (define): We also have to track locally the
12382 defines. AllDefines is just used for the Conditional Attribute,
12383 but we also need the local defines for the current source code.
12385 2002-07-03 Miguel de Icaza <miguel@ximian.com>
12387 * statement.cs (While, For, Do): These loops can exit through a
12388 Break statement, use this information to tell whether the
12389 statement is the last piece of code.
12391 (Break): Flag that we break.
12393 * codegen.cs (EmitContexts): New `Breaks' state variable.
12395 2002-07-03 Martin Baulig <martin@gnome.org>
12397 * class.cs (TypeContainer.MethodModifiersValid): Allow override
12398 modifiers in method declarations in structs. Otherwise, you won't
12399 be able to override things like Object.Equals().
12401 2002-07-02 Miguel de Icaza <miguel@ximian.com>
12403 * class.cs (Method, Property, Indexer): Do not allow the public
12404 modifier to be used in explicit interface implementations.
12406 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
12407 override modifiers in method declarations in structs
12409 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
12411 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
12412 integer or real overflow, report an error
12414 2002-07-02 Martin Baulig <martin@gnome.org>
12416 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
12417 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
12418 to tell the runtime about our newly created System.Object and
12419 System.ValueType types.
12421 2002-07-02 Miguel de Icaza <miguel@ximian.com>
12423 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
12424 struct instead of Ldarg/Starg.
12426 2002-07-02 Martin Baulig <martin@gnome.org>
12428 * expression.cs (Indirection.Indirection): Call
12429 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
12431 2002-07-02 Martin Baulig <martin@gnome.org>
12433 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
12434 ValueType, call TypeManager.TypeToCoreType() on it.
12435 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
12436 the OpCodes.Newarr argument.
12438 2002-07-02 Martin Baulig <martin@gnome.org>
12440 * expression.cs (Invocation.EmitCall): When compiling corlib,
12441 replace all calls to the system's System.Array type to calls to
12442 the newly created one.
12444 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
12445 System.Array methods.
12446 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
12447 from the system's System.Array type which must be replaced.
12449 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
12451 * typemanager.cs: load unverifiable_code_ctor so we can build
12452 corlib using the correct type. Avoid using GetTypeCode() with
12454 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
12455 TypeManager.object_type to allow building corlib.
12457 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
12459 * ecore.cs: handle System.Enum separately in LoadFromPtr().
12461 2002-07-01 Martin Baulig <martin@gnome.org>
12463 * class.cs: Make the last change actually work, we need to check
12464 whether `ifaces != null' to avoid a crash.
12466 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
12468 * class.cs: when we build structs without fields that implement
12469 interfaces, we need to add the interfaces separately, since there is
12470 no API to both set the size and add the interfaces at type creation
12473 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
12475 * expression.cs: the dimension arguments to the array constructors
12476 need to be converted if they are a long.
12478 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
12480 * class.cs: don't emit ldarg.0 if there is no parent constructor
12481 (fixes showstopper for corlib).
12483 2002-06-29 Martin Baulig <martin@gnome.org>
12485 MCS now compiles corlib on GNU/Linux :-)
12487 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
12488 ie. check for MethodImplOptions.InternalCall.
12490 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
12491 and TypeManager.attribute_type are null, so we must explicitly check
12492 whether parent is not null to find out whether it's an attribute type.
12493 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
12494 and SetBuilder, not only if the property is neither abstract nor external.
12495 This is necessary to set the MethodImplOptions on the accessor methods.
12496 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
12497 SetBuilder, see Property.Emit().
12499 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
12500 populate "System.Object", "System.ValueType" and "System.Attribute" since
12501 they've already been populated from BootCorlib_PopulateCoreTypes().
12503 2002-06-29 Martin Baulig <martin@gnome.org>
12505 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
12506 is the NullLiteral, we also need to make sure that target_type is not
12509 2002-06-29 Martin Baulig <martin@gnome.org>
12511 * rootcontext.cs (RootContext.ResolveCore): We must initialize
12512 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
12513 before calling BootstrapCorlib_ResolveDelegate ().
12515 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
12517 * statement.cs: fixed build-breaker. All tests passed ok.
12519 2002-06-27 Martin Baulig <martin@gnome.org>
12521 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
12522 for System.Decimal when compiling corlib.
12524 2002-06-27 Martin Baulig <martin@gnome.org>
12526 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
12527 switch blocks which contain nothing but a default clause.
12529 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
12531 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
12533 2002-06-27 Martin Baulig <martin@gnome.org>
12535 * ecore.cs (PropertyExpr.PropertyExpr): Call
12536 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
12538 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
12539 is already a TypeBuilder.
12541 2002-06-27 Martin Baulig <martin@gnome.org>
12543 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
12544 `target_type == TypeManager.array_type', not IsAssignableFrom() in
12545 the "from an array-type to System.Array" case. This makes it work
12546 when compiling corlib.
12548 2002-06-27 Martin Baulig <martin@gnome.org>
12550 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
12551 non-static PropertyExpr, set its InstanceExpression. This makes
12552 the `ICollection.Count' property work in System/Array.cs.
12554 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
12556 * driver.cs: Made error handling more consistent. Errors now
12557 tracked by Report class, so many methods which used to return int
12558 now return void. Main() now prints success/failure and
12559 errors/warnings message.
12561 Renamed '--probe' compiler argument to '--expect-error'. Removed
12562 the magic number return values (123 and 124). Now, if the
12563 expected error occurs, the compiler exits with success (exit value
12564 0). If the compilation completes without seeing that particular
12565 error, the compiler exits with failure (exit value 1). The
12566 makefile in mcs/errors has been changed to handle the new behaviour.
12568 * report.cs: Made 'expected error' number a property and renamed
12569 it from 'Probe' to 'ExpectedError'.
12571 * genericparser.cs: Removed error handling support, since it is
12572 now all done by Report class.
12574 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
12575 class, so parse() no longer returns an int.
12577 * namespace.cs: Use Report.Error instead of GenericParser.error
12579 2002-06-22 Miguel de Icaza <miguel@ximian.com>
12581 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
12582 TypeContainer.AddOperator): At the front of the list put the
12583 explicit implementations, so they get resolved/defined first.
12585 2002-06-21 Miguel de Icaza <miguel@ximian.com>
12587 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
12588 interface type is implemented by this TypeContainer. Used during
12589 explicit interface implementation.
12591 (Property.Define, Indexer.Define, Method.Define): Validate that
12592 the given interface in the explicit implementation is one of the
12593 base classes for the containing type.
12595 Also if we are explicitly implementing an interface, but there is
12596 no match in the pending implementation table, report an error.
12598 (Property.Define): Only define the property if we are
12599 not explicitly implementing a property from an interface. Use the
12600 correct name also for those properties (the same CSC uses,
12601 although that is really not needed).
12603 (Property.Emit): Do not emit attributes for explicitly implemented
12604 properties, as there is no TypeBuilder.
12606 (Indexer.Emit): ditto.
12608 Hiding then means that we do not really *implement* a pending
12609 implementation, which makes code fail.
12611 2002-06-22 Martin Baulig <martin@gnome.org>
12613 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
12614 the return value of Object.GetType(). [FIXME: we need to do this whenever
12615 we get a type back from the reflection library].
12617 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
12619 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
12621 2002-06-20 Miguel de Icaza <miguel@ximian.com>
12623 * attribute.cs: Return null if we can not look up the type.
12625 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
12626 the interface types found.
12628 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
12629 interface types found.
12631 * typemanager.cs (GetInterfaces): Make this routine returns alll
12632 the interfaces and work around the lame differences between
12633 System.Type and System.Reflection.Emit.TypeBuilder in the results
12634 result for GetInterfaces.
12636 (ExpandInterfaces): Given an array of interface types, expand and
12637 eliminate repeated ocurrences of an interface. This expands in
12638 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
12641 2002-06-21 Martin Baulig <martin@gnome.org>
12643 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
12646 2002-06-21 Martin Baulig <martin@gnome.org>
12648 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
12649 and called with one of the core types, return the corresponding typebuilder for
12652 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
12655 2002-06-21 Martin Baulig <martin@gnome.org>
12657 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
12658 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
12659 (Expression.ConvertReferenceExplicit): Likewise.
12661 * expression.cs (ElementAccess.DoResolve): Likewise.
12662 (ElementAccess.DoResolveLValue): Likewise.
12664 2002-06-10 Martin Baulig <martin@gnome.org>
12666 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
12667 add the "value" parameter to the parameter list.
12669 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
12672 2002-06-19 Miguel de Icaza <miguel@ximian.com>
12674 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
12675 the argument to an int, uint, long or ulong, per the spec. Also
12676 catch negative constants in array creation.
12678 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
12680 * class.cs: do not allow the same interface to appear twice in
12681 the definition list.
12683 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
12685 * ecore.cs: don't use ldlen with System.Array.
12687 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
12689 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
12691 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
12693 * modifiers.cs: produce correct field attributes for protected
12694 internal. Easy fix so miguel can work on ther harder stuff:-)
12696 2002-06-18 Miguel de Icaza <miguel@ximian.com>
12698 * pending.cs: New file. Move the code from class.cs here.
12699 Support clearning the pending flag for all methods (when not doing
12700 explicit interface implementation).
12702 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
12704 * rootcontext.cs: added a couple more types needed to bootstrap.
12706 2002-06-17 Miguel de Icaza <miguel@ximian.com>
12708 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
12709 constructor in the type, instead of any constructor in the type
12710 hierarchy. Thanks to Paolo for finding this bug (it showed up as
12711 a bug in the Mono runtime when applying the params attribute).
12713 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
12714 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
12716 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
12718 * expression.cs (Unary.ResolveOperator): Use TypeManager
12719 to resolve the type.
12721 2002-06-13 Ravi Pratap <ravi@ximian.com>
12723 * cs-parser.jay (enum_member_declaration): Pass in the attributes
12726 * enum.cs (AddEnumMember): Add support to store the attributes associated
12727 with each member too.
12729 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
12730 field builders too - this takes care of the enum member case.
12732 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
12734 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
12735 address-of operator on both value types and pointers.
12737 2002-06-10 Martin Baulig <martin@gnome.org>
12739 * interface.cs (Interface.PopulateIndexer): Add the indexer's
12740 PropertyBuilder to the `property_builders' list.
12742 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
12743 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
12744 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
12745 find any indexers which are inherited from an interface.
12747 2002-06-09 Martin Baulig <martin@gnome.org>
12749 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
12750 the same type as the constant if necessary. There's also a test-130.cs
12753 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
12755 * typemanager.cs (TypeManager.ChangeType): Previously known as
12756 Enum.ChangeEnumType().
12758 2002-06-09 Martin Baulig <martin@gnome.org>
12760 * expression.cs (Cast.TryReduce): Added support for consts.
12762 2002-06-08 Ravi Pratap <ravi@ximian.com>
12764 * class.cs (Accessor): Hold attributes information so we can pass
12767 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
12768 Modify to pass in attributes attached to the methods.
12770 (add_accessor_declaration, remove_accessor_declaration): Ditto.
12772 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
12773 to handle the Accessor kind :-)
12775 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
12777 2002-06-08 Martin Baulig <martin@gnome.org>
12779 * expression.cs (Unary.TryReduceNegative): Added support for
12782 2002-06-08 Martin Baulig <martin@gnome.org>
12784 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
12785 name can't be found in the `defined_names' - the caller will do a
12786 MemberLookup in this case and thus find methods in System.Enum
12787 such as Enum.IsDefined().
12789 2002-06-08 Martin Baulig <martin@gnome.org>
12791 * enum.cs (Enum.ChangeEnumType): This is a custom version of
12792 Convert.ChangeType() which works with TypeBuilder created types.
12793 (Enum.LookupEnumValue, Enum.Define): Use it here.
12795 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
12796 `TypeBuilder.BaseType != null' check.
12797 (TypeContainer.FindMembers): Only lookup parent members if we
12798 actually have a parent.
12799 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
12800 (ConstructorInitializer.Resolve): Likewise.
12802 * interface.cs (Interface.FindMembers): Added
12803 `TypeBuilder.BaseType != null' check.
12805 * rootcontext.cs (RootContext.ResolveCore): Added
12806 "System.Runtime.CompilerServices.IndexerNameAttribute" to
12807 classes_second_stage.
12809 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
12810 debug_type and trace_type when compiling with --nostdlib.
12812 2002-06-07 Martin Baulig <martin@gnome.org>
12814 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
12815 (AddField): Set it to true when adding a non-static field.
12816 (DefineType): Use `have_nonstatic_fields' to find out whether we
12817 have non-static fields, not `Fields != null'.
12819 2002-06-02 Miguel de Icaza <miguel@ximian.com>
12821 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
12822 dereferencing a null on the static-field code path)
12824 2002-05-30 Martin Baulig <martin@gnome.org>
12826 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
12827 to take command line arguments. Use reflection to call the new
12828 custom `Initialize' function on the symbol writer and pass it the
12829 command line arguments.
12831 * driver.cs (--debug-args): New command line argument to pass command
12832 line arguments to the symbol writer.
12834 2002-05-28 Miguel de Icaza <miguel@ximian.com>
12836 * assign.cs (DoResolve): Forgot to do the implicit conversion to
12837 the target type for indexers and properties. Thanks to Joe for
12840 2002-05-27 Miguel de Icaza <miguel@ximian.com>
12842 * typemanager.cs (MethodFlags): returns the method flags
12843 (Obsolete/ShouldIgnore) that control warning emission and whether
12844 the invocation should be made, or ignored.
12846 * expression.cs (Invocation.Emit): Remove previous hack, we should
12847 not do this on matching a base type, we should do this based on an attribute
12849 Only emit calls to System.Diagnostics.Debug and
12850 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
12851 on the command line.
12853 * rootcontext.cs: Global settings for tracing and debugging.
12855 * cs-tokenizer.cs (define): New utility function to track
12856 defines. Set the global settings for TRACE and DEBUG if found.
12858 2002-05-25 Ravi Pratap <ravi@ximian.com>
12860 * interface.cs (Populate*): Pass in the TypeContainer as well as
12861 the DeclSpace as parameters so that we can create EmitContexts and
12862 then use that to apply attributes etc.
12864 (PopulateMethod, PopulateEvent, PopulateProperty)
12865 (PopulateIndexer): Apply attributes everywhere.
12867 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
12870 (ApplyAttributes): Update accordingly.
12872 We now apply interface attributes for all members too.
12874 2002-05-26 Miguel de Icaza <miguel@ximian.com>
12876 * class.cs (Indexer.Define); Correctly check if we are explicit
12877 implementation (instead of checking the Name for a ".", we
12878 directly look up if the InterfaceType was specified).
12880 Delay the creation of the PropertyBuilder.
12882 Only create the PropertyBuilder if we are not an explicit
12883 interface implementation. This means that explicit interface
12884 implementation members do not participate in regular function
12885 lookups, and hence fixes another major ambiguity problem in
12886 overload resolution (that was the visible effect).
12888 (DefineMethod): Return whether we are doing an interface
12891 * typemanager.cs: Temporary hack until we get attributes in
12892 interfaces (Ravi is working on that) and we get IndexerName
12893 support in interfaces.
12895 * interface.cs: Register the indexers as properties.
12897 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
12898 warning, I have verified that this is a bug in the .NET runtime
12899 (JavaScript suffers of the same problem).
12901 * typemanager.cs (MemberLookup): When looking up members for
12902 interfaces, the parent of an interface is the implicit
12903 System.Object (so we succeed in searches of Object methods in an
12904 interface method invocation. Example: IEnumerable x; x.ToString
12907 2002-05-25 Miguel de Icaza <miguel@ximian.com>
12909 * class.cs (Event): Events should also register if they do
12910 implement the methods that an interface requires.
12912 * typemanager.cs (MemberLookup); use the new GetInterfaces
12915 (GetInterfaces): The code used to lookup interfaces for a type is
12916 used in more than one place, factor it here.
12918 * driver.cs: Track the errors at the bottom of the file, we kept
12921 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
12922 instance if the method we are calling is static!
12924 2002-05-24 Miguel de Icaza <miguel@ximian.com>
12926 * attribute.cs (ApplyAttributes): Make this function filter out
12927 the IndexerName attribute (as that attribute in reality is never
12928 applied) and return the string constant for the IndexerName
12931 * class.cs (TypeContainer.Emit): Validate that all the indexers
12932 have the same IndexerName attribute, and if so, set the
12933 DefaultName attribute on the class.
12935 * typemanager.cs: The return value might contain other stuff (not
12936 only methods). For instance, consider a method with an "Item"
12937 property and an Item method.
12939 * class.cs: If there is a problem with the parameter types,
12942 2002-05-24 Ravi Pratap <ravi@ximian.com>
12944 * ecore.cs (ImplicitConversionExists): Wrapper function which also
12945 looks at user defined conversion after making a call to
12946 StandardConversionExists - we need this for overload resolution.
12948 * expression.cs : Update accordingly the various method calls.
12950 This fixes 2 bugs filed against implicit user defined conversions
12952 2002-05-22 Miguel de Icaza <miguel@ximian.com>
12954 * statement.cs: Track the result of the assignment.
12956 2002-05-21 Miguel de Icaza <miguel@ximian.com>
12958 * expression.cs (MemberAccess): Improved error reporting for
12959 inaccessible members.
12961 2002-05-22 Martin Baulig <martin@gnome.org>
12963 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
12964 itself with debugging support.
12966 2002-05-22 Martin Baulig <martin@gnome.org>
12968 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
12969 Removed, this isn't needed anymore.
12971 2002-05-20 Martin Baulig <martin@gnome.org>
12973 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
12974 be underlying type for an enum.
12976 2002-05-20 Miguel de Icaza <miguel@ximian.com>
12978 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
12979 that splits out the loading of just the core types.
12981 * rootcontext.cs (ResolveCore): Split the struct resolution in
12982 two, so we can load the enumeration underlying types before any
12985 * expression.cs (Is): Bandaid until we fix properly Switch (see
12986 bug #24985 for details).
12988 * typemanager.cs (ImplementsInterface): The hashtable will contain
12989 a null if there are no interfaces implemented.
12991 2002-05-18 Miguel de Icaza <miguel@ximian.com>
12993 * cs-parser.jay (indexer_declarator): It is fine to have array
12996 2002-05-17 Miguel de Icaza <miguel@ximian.com>
12998 * typemanager.cs: (RegisterBuilder): New function used to register
12999 TypeBuilders that implement interfaces. Since
13000 TypeBuilder.GetInterfaces (as usual) does not work with lame
13002 (AddUserType): register interfaces.
13004 (ImplementsInterface): Use the builder_to_ifaces hash if we are
13005 dealing with TypeBuilder. Also, arrays are showing up as
13006 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
13007 methods can not be invoked on them!
13009 * ecore.cs (ExplicitReferenceConversionExists): Made public.
13010 (ImplicitReferenceConversionExists): Split out from
13011 StandardConversionExists.
13013 * expression.cs (As): We were only implementing one of the three
13014 cases for the as operator. We now implement them all.
13015 (Is): Implement the various other cases for Is as well.
13017 * typemanager.cs (CACHE): New define used to control if we want or
13018 not the FindMembers cache. Seems to have a negative impact on
13019 performance currently
13021 (MemberLookup): Nested types have full acess to
13022 enclosing type members
13024 Remove code that coped with instance/static returns for events, we
13025 now catch this in RealFindMembers.
13027 (RealFindMembers): only perform static lookup if the instance
13028 lookup did not return a type or an event.
13030 2002-05-17 Miguel de Icaza <miguel@ximian.com>
13032 * assign.cs (CompoundAssign): We pass more semantic information
13033 now to Compound Assignments than we did before: now we have all
13034 the information at hand, and now we resolve the target *before* we
13035 do the expression expansion, which allows the "CacheValue" method
13036 to have the effect we intended (before, a [x] += 1 would generate
13037 two differen ArrayAccess expressions from the ElementAccess,
13038 during the resolution process).
13040 (CompoundAssign.DoResolve): Resolve target and original_source here.
13042 2002-05-16 Miguel de Icaza <miguel@ximian.com>
13044 * expression.cs (ArrayAccess): dropped debugging information.
13046 * typemanager.cs: Small bug fix: I was always returning i_members,
13047 instead of one of i_members or s_members (depending on which had
13050 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
13051 method is invoked before any code generation takes place, and it
13052 is a mechanism to inform that the expression will be invoked more
13053 than once, and that the method should use temporary values to
13054 avoid having side effects
13056 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
13058 * ecore.cs (Expression.CacheTemporaries): Provide empty default
13061 * expression.cs (Indirection, ArrayAccess): Add support for
13062 CacheTemporaries in these two bad boys.
13064 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
13065 ldobj or ldind_ref.
13066 (StoreFromPtr): Handle stobj as well.
13068 * expression.cs (UnaryMutator): Share more code.
13070 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
13071 down: I was not tracking the Filter function as well, which
13072 was affecting the results of the cache.
13074 2002-05-15 Miguel de Icaza <miguel@ximian.com>
13076 * attribute.cs: Remove the hack to handle the CharSet property on
13079 2002-05-14 Miguel de Icaza <miguel@ximian.com>
13081 * attribute.cs (DoResolve): More uglyness, we now only try to
13082 resolve the attribute partially, to extract the CharSet
13083 information (only if we are a StructLayout attribute). Otherwise
13085 (GetExtraTypeInfo): Add some code to conditionally kill in the
13086 future this. I am more and more convinced that the .NET
13087 framework has special code to handle the attribute setting on
13090 * expression.cs (IsParamsMethodApplicable): Revert my previous
13091 foreach change here, it was wrong.
13093 2002-05-13 Miguel de Icaza <miguel@ximian.com>
13095 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
13096 (pp_expr): do not abort on unknown input, just return.
13097 (eval): abort if there are pending chars.
13099 * attribute.cs (Attribute.Resolve): Positional parameters are
13100 optional. Deal with that case.
13102 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
13103 the Ansi/Unicode/Auto information for the type.
13105 (TypeContainer.DefineType): instantiate the EmitContext here, as
13106 we will be using it during the type definition (to resolve
13107 attributes) and during the emit phase.
13109 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
13110 to pull type information out of the attributes
13112 (Attribute.Resolve): track the constructor builder, and allow for
13113 multiple invocations (structs and classes will use this).
13115 * ecore.cs (MemberLookupFinal): new version with all the
13116 parameters customizable.
13118 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
13119 constructors. Return if the result value is null (as the error
13120 would have been flagged already by MemberLookupFinal)
13122 Do not allow instances of abstract classes or interfaces to be
13125 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
13126 We have to compare the assembly property here when dealing with
13127 FamANDAssem and Assembly access modifiers, because we might be
13128 creating an assembly from *modules* (that means that we are not
13129 getting TypeBuilders for types defined in other modules that are
13130 part of this assembly).
13132 (Method.Emit): If the method is marked abstract and has a body,
13135 (TypeContainer.DefineMembers): If both the defined member and the
13136 parent name match are methods, then do not emit any warnings: let
13137 the Method.Define routine take care of flagging warnings. But if
13138 there is a mismatch (method overrides something else, or method is
13139 overriwritten by something, then emit warning).
13141 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
13142 set to null, this means `do not check for the return type on the
13145 (Method.Define): set the return type for the method signature to
13146 null, so that we get methods with the same name and parameters and
13147 different return types. This is used to flag warning 114 (you are
13148 hiding a method, and you probably want to use the new/override
13151 * typemanager.cs (MemberLookup): Implemented proper access
13152 control, closing a long standing set of bug reports. The problem
13153 was that the Framework only has two bits: Public and NonPublic,
13154 and NonPublic includes private and protected methods, but we need
13155 to enforce the FamANDAssem, FamOrAssem and Family.
13157 2002-05-11 Miguel de Icaza <miguel@ximian.com>
13159 * statement.cs (GotoCase): Return true: Ammounts to giving up
13160 knowledge on whether we return or not, and letting the other case
13161 be responsible for it.
13163 2002-05-10 Miguel de Icaza <miguel@ximian.com>
13165 * driver.cs: Do not load directories for each file processed, only
13166 do it if there is a pattern.
13168 * ecore.cs: Report readonly assigns here as well, as we might have
13169 been resolved only by MemberAccess.
13171 (SimpleName.SimpleNameResolve): Also be useful for LValue
13172 resolution. We need this to propagate assign to local readonly variables
13174 * typemanager.cs: Use a ptrhashtable for the criteria, because we
13175 do not want to reuse potential criteria memory.
13177 * class.cs (MyEventBuilder): Set reflected_type;
13179 * ecore.cs (Constantify): Added support for constifying bools.
13181 (RootContext.LookupType): Added a cache for values looked up in
13182 the declaration space.
13184 * typemanager.cs (FindMembers): Now is a front-end to
13185 RealFindMembers, and provides a two-level hashtable-based cache to
13188 15% performance improvement: from 22.5 to 19.2 seconds.
13190 * expression.cs (IsParamsMethodApplicable): use foreach.
13191 (Invocation.DoResolve): ditto.
13192 (New.DoResolve): ditto.
13193 (ArrayCreation.DoResolve): ditto.
13195 * ecore.cs (FindMostEncompassingType): use foreach.
13197 * delegate.cs (NewDelegate.DoResolve): Use foreach
13199 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
13200 (RemoveMethods): use foreach.
13202 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
13203 nested foreach statements instead of for, and also break out of
13204 the inner loop once a match is found.
13206 (Invocation.OverloadResolve): Use foreach, simplify the code.
13208 2002-05-08 Miguel de Icaza <miguel@ximian.com>
13210 * cfold.cs (BinaryFold): During an enumeration evaluation context,
13211 we actually unwrap the expression to allow for extra information
13214 * expression.cs: Use Shr_Un on unsigned operations.
13216 2002-05-08 Ravi Pratap <ravi@ximian.com>
13218 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
13219 applicable operators was not being considered correctly. This closes
13220 the bug Miguel reported.
13222 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
13224 * attribute.cs: check that the type derives from System.Attribute
13225 and report the correct error in that case (moved the duplicate code to
13226 its own method, too).
13228 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
13230 * attribute.cs: lookup attribute type name as the spec says: first the
13231 bare attribute name and then name + "Attribute" (nant compiles with
13232 mcs after this fix).
13234 2002-05-07 Miguel de Icaza <miguel@ximian.com>
13236 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
13237 Because of the way we parse things, we should try to see if a
13238 UIntConstant can fit in an integer.
13240 2002-05-07 Ravi Pratap <ravi@ximian.com>
13242 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
13243 when we are in an explicit context.
13245 (ConvertReferenceExplicit): When converting from Iface type S to Class
13246 T make sure the rules are implemented as an OR.
13248 * parameter.cs (ParameterType): Make it a property for now although the
13249 purpose really isn't anything immediate.
13251 * expression.cs (Is*Applicable): Do better checking on the parameter type
13252 of a ref/out parameter. The ones from the system assemblies are already
13253 marked with the correct type so we don't need to do any correction.
13255 * ecore.cs (StandardConversionExists): Conversion from Interface types to
13256 the object type is standard too so include that.
13258 2002-05-06 Miguel de Icaza <miguel@ximian.com>
13260 * ecore.cs (StandardConversionExists): Augment with missing code:
13261 deal with IntConstant, LongConstants and Enumerations.
13263 * assign.cs: Report the error, instead of failing silently
13265 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
13266 typecontainer that they are declared, because the
13267 typecontainer/namespace will have the list of using clauses that
13268 need to be applied.
13270 Assembly Attributes were escaping the normal registration
13273 (EmitCode): Apply attributes within an EmitContext that represents
13274 the container they were declared on.
13276 * cs-parser.jay: Track bases for structs. How did I get this wrong?
13278 2002-05-06 Ravi Pratap <ravi@ximian.com>
13280 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
13281 Revamp completely - make much cleaner as we now operate only
13284 (FindMostSpecificSource, FindMostSpecificTarget): New methods
13285 to implement the logic detailed in the spec more correctly.
13287 (UserDefinedConversion): Update accordingly.
13289 2002-05-06 Miguel de Icaza <miguel@ximian.com>
13291 * statement.cs: Return flow analysis information up.
13293 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
13296 (token): Do not consume an extra character before calling
13299 2002-05-06 Piers Haken <piersh@friskit.com>
13301 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
13303 2002-05-06 Miguel de Icaza <miguel@ximian.com>
13305 * class.cs (Constructor.Emit): Set the IsStatic flag in the
13306 EmitContext during the instance constructor initializer
13307 resolution, to stop access to instance variables.
13309 This is mandated by the spec, last paragraph of the `constructor
13310 initializers' section.
13312 2002-05-05 Miguel de Icaza <miguel@ximian.com>
13314 * cs-parser.jay, class.cs (Accessor): new class used to represent
13315 an accessor (get or set). In the past we used `null' to represent
13316 a missing accessor. But this is ambiguous because there was no
13317 way to tell in abstract indexers/properties if one of them was
13320 Now there is a way of addressing that.
13322 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
13323 instead of FindMembers.
13325 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
13326 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
13328 * attribute.cs: Treat indexers and properties as the same in terms
13329 of applying attributes
13331 * ecore.cs (FindMostEncompassedType): Use statically initialized
13332 EmptyExpressions()s like we do elsewhere to avoid creating useless
13333 objects (and we take this out of the tight loop).
13335 (GetConversionOperators): Move the code to extract the actual
13336 operators to a separate routine to clean things up.
13338 2002-05-04 Miguel de Icaza <miguel@ximian.com>
13340 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
13341 events are always registered FieldBuilders.
13343 * class.cs (FieldBase): New class shared by Fields
13345 * delegate.cs: If we are a toplevel delegate, use our full name.
13346 If we are a nested delegate, then only use our tail name.
13348 2002-05-02 Ravi Pratap <ravi@ximian.com>
13350 * expression.cs (IsApplicable): Ensure that we add the "&" to
13351 ref/out types before comparing it with the type of the argument.
13353 (IsParamsMethodApplicable): Ditto.
13355 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
13358 * delegate.cs : Handle the case when we have more than one applicable
13359 method. Flag an error only when we finish checking all.
13361 2002-05-02 Miguel de Icaza <miguel@ximian.com>
13363 * expression.cs: Add support for boolean static initializers.
13365 2002-05-01 Miguel de Icaza <miguel@ximian.com>
13367 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
13369 * parameter.cs (ComputeParameterTypes,
13370 ComputeAndDefineParameterTypes): Better error handling: now we
13371 clear the `types' cache if we fail during any of the type lookups.
13372 We also return the status code correctly to our caller
13374 * delegate.cs: If we fail to define a delegate, abort the extra
13377 * expression.cs (Binary.ResolveOperator): for
13378 operator==(object,object) and operator !=(object, object) we also
13379 have to verify that there is an implicit conversion from one to
13382 (ArrayAccess.DoResolve): Array Access can operate on
13385 2002-04-30 Miguel de Icaza <miguel@ximian.com>
13387 * assign.cs (CompoundAssign): A new class used as a "flag" that
13388 the assignment actually is happening as part of a compound
13389 assignment operator.
13391 During compound assignment, a few new rules exist to enable things
13398 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
13399 to the type of x) if y is implicitly convertible to the type of x,
13400 and the operator is a builtin operator and the return type of the
13401 operator is explicitly convertible to the type of x.
13403 * rootcontext.cs: Reset warning level to 2. 4 catches various
13404 "interesting" features in mcs, we must clean this up at some
13405 point, but currently am trying to kill other bugs ;-)
13407 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
13408 in container classes as well.
13410 * expression.cs (Binary.ResolveOperator): Handle string case
13411 before anything else (as operator overloading does emit an error
13412 before doing anything else).
13414 This code could go away when we move to a table driven model, but
13415 i could not come up with a good plan last night.
13417 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
13419 * typemanager.cs (CSharpName): reimplementation using regex.
13420 * class.cs: added null check for fields in Emit
13421 * rootcontext.cs: set warninglevel to 4
13423 2002-04-29 Miguel de Icaza <miguel@ximian.com>
13425 * typemanager.cs (CSharpName): reimplemented with Lupus
13428 2002-04-28 Miguel de Icaza <miguel@ximian.com>
13430 * statement.cs (If): correclty implement Resolve, because we were
13431 not catching sem errors in there. The same process is needed
13433 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
13436 (Statement.Warning_DeadCodeFound): Factorize code.
13437 (While): Report dead code here too.
13439 (Statement): Added Resolve virtual method to allow
13440 for resolution split from the emit code.
13442 2002-04-26 Miguel de Icaza <miguel@ximian.com>
13444 * statement.cs (EmitBoolExpression): No longer try to resolve the
13446 (MakeBoolean): New utility function that resolve, implicitly
13447 converts to boolean and tags the expression.
13450 (If, Do): Implement dead code elimination.
13451 (While): Implement loop inversion
13453 (Do, While, For, If): Resolve the expression prior to calling our
13456 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
13459 - added method Report28 (warning: program has more than one entry point)
13460 - added method IsEntryPoint, implements paragraph 10.1 of the spec
13461 - modified method Method.Define, the part at the end of the method
13463 * rootcontext.cs: added static public Location EntryPointLocation;
13465 * ../errors/cs0028.cs : Add test case for the above warning.
13468 - modified method CSharpName to allow arrays of primitive type to
13469 be printed nicely (e.g. instead of System.Int32[][] it now prints
13471 - added method CSharpSignature: returns the signature of a method
13472 in string format to be used in reporting errors, warnings, etc.
13474 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
13477 2002-04-26 Ravi Pratap <ravi@ximian.com>
13479 * delegate.cs (Define): Fix extremely silly bug where I was
13480 setting the type of the 'object' parameter of the BeginInvoke
13481 method to System.IAsyncResult instead of System.Object ;-)
13483 2002-04-26 Miguel de Icaza <miguel@ximian.com>
13485 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
13488 (Constructor.Emit): return if we fail to initialize the
13489 constructor. Another door closed!
13491 * expression.cs (New.DoResolve): Improve error message (from -6 to
13492 1501). Use DeclaredOnly lookup to find the exact constructor.
13494 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
13495 loop. This is useful.
13497 * cs-parser.jay: Adjust the default parameters so that destructors
13498 have the proper signature.
13500 2002-04-26 Martin Baulig <martin@gnome.org>
13502 * driver.cs (LoadAssembly): If `assembly' contains any characters
13503 which are only valid in path names and not in assembly names
13504 (currently slash, backslash and point), use Assembly.LoadFrom ()
13505 instead of Assembly.Load () on the `assembly' (before iteration
13506 over the link_paths).
13508 2002-04-26 Martin Baulig <martin@gnome.org>
13510 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
13512 2002-04-25 Miguel de Icaza <miguel@ximian.com>
13514 * class.cs (Property): use the new typemanager.MemberLookup
13516 (TypeContainer.MemberLookup): Implement using the
13517 TypeManager.MemberLookup now.
13519 * typemanager.cs: Make MemberLookup a function of the TypeManager,
13520 and return MemberInfos, so that these can be used without an
13521 EmitContext (what we had before).
13523 2002-04-24 Miguel de Icaza <miguel@ximian.com>
13525 * expression.cs: Fix the case where the argument to params if the
13526 type of the params. I omitted handling this before. Fixed
13528 2002-04-22 Miguel de Icaza <miguel@ximian.com>
13530 * driver.cs: Call BootCorlib_PopulateCoreType
13532 * class.cs (Property.CheckBase): Check for properties only, not
13535 * interface.cs: Temporary hack: try/catch around the
13536 CustomAttributeBuilder, because I am getting an exception that I
13539 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
13540 types whose definitions are required to be there (attributes are
13541 defined before standard types).
13543 Compute definitions as we boot the various types, as they are used
13544 immediately (value_type class will need object_type, but if we do
13545 not initialize object_type, we will pass a null, which will let
13546 the runtime pick the System.Object from the existing corlib, which
13547 is not what we want).
13549 2002-04-22 Patrik Torstensson <totte@labs2.com>
13551 * cs-tokenizer.cs: fixed a number of trim() issues.
13553 2002-04-22 Ravi Pratap <ravi@ximian.com>
13555 * expression.cs (Argument.Type): Ensure that we return the correct
13556 type when we have out or ref parameters [in which case we
13559 2002-04-22 Miguel de Icaza <miguel@ximian.com>
13561 * class.cs (Property, Indexer): Allow extern modifier in there.
13563 * typemanager.cs (InitBaseTypes): Initializes object_type and
13564 value_type, since those will be used early on during the bootstrap
13565 process to compile corlib.
13567 (InitCoreTypes): Move code from here to InitBaseTypes.
13569 2002-04-21 Miguel de Icaza <miguel@ximian.com>
13571 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
13572 single-dimension arrays as using the ldlen opcode.
13574 Daniel Lewis discovered this optimization.
13576 * typemanager.cs: Add signature for System.Array::get_Length
13578 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
13580 * statement.cs: report the error when the foreach does not apply to an
13581 array nor a collection.
13583 2002-04-19 Miguel de Icaza <miguel@ximian.com>
13585 * expression.cs: Add implicit conversions to the operator ~.
13587 * constant.cs (DecimalConstant.Emit): Emit decimal value.
13589 * typemanager.cs: Locate the decimal constructor.
13591 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
13593 * attribute.cs: use the new property of TypeOf.
13594 * expression.cs: added 'get' property around typearg.
13596 These changes fix a build breaker reported by NickD. Is this the
13597 correct way to fix? If not, please, revert my changes and make it
13600 2002-04-17 Miguel de Icaza <miguel@ximian.com>
13602 * attribute.cs: Add support for typeof in attribute invocations.
13603 I am not sure that this is right though.
13605 2002-04-14 Duncan Mak <duncan@ximian.com>
13607 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
13608 Binary.Operator.Division case.
13610 2002-04-13 Ravi Pratap <ravi@ximian.com>
13612 * class.cs (DefineType): Ensure that we do a proper check on
13613 attribute types and also register it with the TypeManager.
13615 (TypeContainer.Targets): The default for attribute types is
13616 AttributeTargets.All.
13618 * attribute.cs (ApplyAttributes): Registering the attribute type
13619 is done elsewhere, not when we discover we have a Usage attribute.
13621 2002-04-12 Ravi Pratap <ravi@ximian.com>
13623 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
13624 and get rid of is_delegate parameter.
13626 * everywhere : update.
13628 2002-04-12 Ravi Pratap <ravi@ximian.com>
13630 * cs-parser.jay (compilation_unit): Revamp completely to use
13631 some new ideas that I got from Rhys' grammar to solve the problems
13632 with assembly level attributes.
13634 (outer_declaration): New grammar production.
13636 (attribute_sections): Add.
13638 (opt_attributes): Base on attribute_sections
13640 (namespace_declaration): Allow opt_attributes to tackle the case
13641 when we have assembly level attributes - we are clever in this
13644 * attribute.cs (ApplyAttributes): Do not worry about assembly
13645 attributes in the non-global context.
13647 * rootcontext.cs (AddGlobalAttributes): Go back to using this
13648 instead of SetGlobalAttributes.
13650 * class.cs, rootcontext.cs : Ensure we define and generate
13651 attribute types before anything else.
13653 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
13654 and flag the new error -20 for the case when the attribute type
13655 does not have valid targets specified. csc does not catch this.
13657 * ../errors/errors.txt : update for error # -20
13659 2002-04-11 Ravi Pratap <ravi@ximian.com>
13661 * support.cs (InternalParameters.ParameterModifier): Do some null
13662 checking and return sane values.
13664 * class.cs (Method.Define): If we are a PInvoke method, ensure
13665 that we are static and extern. Report error # 601
13667 * ../errors/cs0601.cs : Add test case for the above error.
13669 2002-04-07 Ravi Pratap <ravi@ximian.com>
13671 * rootcontext.cs (attribute_types): We need to keep type of
13672 all attribute types separately and emit code for them first.
13674 (RegisterAttribute) : Implement.
13676 * class.cs (DefineType): Check if the current Type is a custom
13677 attribute type and register it accordingly.
13679 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
13680 adding the first attribute twice and rename to
13682 (SetGlobalAttributes): this.
13684 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
13687 * attribute.cs (ApplyAttributes): Take an additional argument telling us
13688 if we are processing global arguments. Hmm, I am unsure of this.
13690 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
13692 * expression.cs: added static array of strings to avoid calling
13693 Enum.ToString () for Operator in Binary. Significant recover of
13696 2002-04-10 Miguel de Icaza <miguel@ximian.com>
13698 * class.cs (FindMembers): Allow the Builders of the various
13699 members to be null. If they are skip them. This only happens
13700 during the PInvoke declaration.
13702 2002-04-09 Miguel de Icaza <miguel@ximian.com>
13704 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
13705 failure, so we do not keep going afterwards.
13707 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
13708 wanted to pass `false' as the `is_delegate' argument. If this is
13709 the case, why not use delegate_type == null to mean `is_delegate =
13710 false' and anything else as is_delegate = true.
13712 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
13714 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
13715 code for the section, not the beginning of the tests.
13717 2002-04-08 Miguel de Icaza <miguel@ximian.com>
13719 * cfold.cs: Handle operator + (Enum x, Underlying x)
13721 * expression.cs (Binary): same. Warn about errors where we have
13722 Enum/Enum in operator + as well.
13724 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
13727 - added support for switch(bool)
13728 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
13729 - add TableSwitchEmit() to handle table-based switch statements
13731 2002-04-05 Ravi Pratap <ravi@ximian.com>
13733 * expression.cs (Invocation.OverloadResolve): Factor out code which
13734 does parameter compatibility checking with arguments so that we can
13735 re-use the code even from Delegate.VerifyApplicability
13737 (VerifyArgumentsCompat): Move above code here.
13739 * delegate.cs (VerifyApplicability): Get rid of duplicate code
13740 and instead make a call to the above method.
13742 2002-03-31 Ravi Pratap <ravi@ximian.com>
13744 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
13745 We use it to keep track of classes which are attribute types.
13747 2002-04-02 Miguel de Icaza <miguel@ximian.com>
13749 * delegate.cs (Delegate.Define): Correctly define the types in the
13750 presence of fixed and array parameters.
13752 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
13755 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
13756 include NonPublic after the first iteration.
13758 * class.cs (Indexer.CheckBase): Only check if both parents are
13761 * cs-parser.jay (accessor_body): If empty, set to null.
13763 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
13764 same code path here to resolve constants names that we did have in
13765 MemberAccess.DoResolve. There is too much code duplicated here.
13767 2002-04-01 Miguel de Icaza <miguel@ximian.com>
13769 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
13771 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
13774 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
13775 tokens, numbers and strings.
13777 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
13780 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
13781 asyncronous parameters and the regular parameters.
13783 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
13784 specify the target directory.
13786 * expression.cs: (This.DoResolve): Simplify
13787 (As.Emit): Optimize, do not generate IsInst if the expression is
13788 always of the given type.
13790 (Is.DoResolve): Bug fix, we were reporting both always/never for
13793 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
13794 creating too many unnecessary arrays.
13796 2002-03-31 Miguel de Icaza <miguel@ximian.com>
13798 * class.cs (EmitFieldInitializer): Use Assign expression to assign
13799 fields instead of rolling our own initializer. Takes care of all
13800 implicit conversions, and drops unnecessary static checks/argument.
13802 2002-03-31 Dick Porter <dick@ximian.com>
13804 * driver.cs: use the GetDirectories() return values properly, and
13805 use "/" as path separator.
13807 2002-03-30 Miguel de Icaza <miguel@ximian.com>
13809 * expression.cs (Unary): Optimize - - expr into expr.
13810 (Binary): Optimize a + (-b) into a -b.
13812 * codegen.cs (CodeGen): Made all methods static.
13814 2002-03-29 Miguel de Icaza <miguel@ximian.com>
13818 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
13819 TypeBuilder property.
13821 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
13824 * tree.cs: Removed the various RecordXXXX, and replaced with a
13825 single RecordDecl. Removed all the accessor methods, and just
13826 left a single access point Type
13828 * enum.cs: Rename DefineEnum to DefineType.
13830 * decl.cs: New abstract method `DefineType' used to unify the
13831 Defines for Enumerations, Interfaces, TypeContainers and
13834 (FindType): Moved LookupInterfaceOrClass here. Moved the
13835 LookupBaseClasses method that used to live in class.cs and
13836 interface.cs here, and renamed to FindType.
13838 * delegate.cs: Implement DefineType. Take advantage of the
13839 refactored pattern for locating the parent builder without taking
13840 the parent_builder argument (which we know does not work if we are
13841 nested, and triggering a toplevel definition).
13843 2002-03-28 Miguel de Icaza <miguel@ximian.com>
13845 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
13846 accessibility of a member has changed during override and report
13849 * class.cs (Method.Define, Property.Define): Only complain on
13850 overrides if the method is private, any other accessibility is
13851 fine (and since we just checked the permission is the same, we are
13854 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
13855 and elif are processed always. The other pre-processing
13856 directives are only processed if we are "taking" the path
13858 2002-03-29 Martin Baulig <martin@gnome.org>
13860 * class.cs (Method.Emit): Only emit symbolic debugging info if the
13861 current location is not Null.
13863 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
13864 a separate method so we can profile it.
13866 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
13867 `span.Seconds' are just seconds, but no minutes or hours.
13868 (MainDriver): Profile the CodeGen.SaveSymbols calls.
13870 2002-03-28 Miguel de Icaza <miguel@ximian.com>
13872 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
13873 Remove the gratuitous set of Final:
13875 // If an interface implementation, then we can set Final.
13876 if (((flags & MethodAttributes.Abstract) == 0) &&
13877 implementing.DeclaringType.IsInterface)
13878 flags |= MethodAttributes.Final;
13880 I do not know what I was smoking when I used that.
13883 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
13884 step into fixing the name resolution issues for delegates and
13885 unifying the toplevel name resolution.
13887 2002-03-28 Martin Baulig <martin@gnome.org>
13889 * class.cs (Method.Emit): If we have a symbol writer, call its
13890 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
13891 tell it about the current method.
13893 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
13894 writer that we're going to emit the first byte of IL code for a new
13895 statement (a new source line).
13896 (EmitContext.EmitTopBlock): If we have a symbol writer, call
13897 EmitContext.Mark() before emitting any code.
13899 * location.cs (SymbolDocument): Return null when we're Null.
13901 * statement.cs (Statement): Moved the `Location loc' variable here.
13902 (Statement.EmitBoolExpression): If we have a symbol writer, call
13903 ec.Mark() before emitting any code to tell it that we're at the
13904 beginning of a new statement.
13905 (StatementExpression): Added `Location' argument to the constructor.
13906 (Block): Added public readonly variable `StartLocation' and public
13907 variable `EndLocation'. The latter is to be set using SetEndLocation().
13908 (Block): Added constructor which takes a start and end location.
13909 (Block.SetEndLocation): New method. This sets the end location.
13910 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
13911 local variables we create.
13912 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
13913 each statement and do also mark the begin and end of the block.
13915 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
13916 tell it the current lexer.Location, use Location.Null for the end of the
13918 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
13919 current block, set its end location using SetEndLocation().
13920 (statement_expression): StatementExpression constructor now takes the
13921 lexer.Location as additional argument.
13922 (for_statement, declare_local_variables): Likewise.
13923 (declare_local_variables): When creating a new implicit block, use the
13924 new Block constructor and pass it the lexer.Location.
13926 2002-03-28 Miguel de Icaza <miguel@ximian.com>
13928 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
13929 members also on the parent interfaces recursively.
13931 2002-03-27 Miguel de Icaza <miguel@ximian.com>
13933 * report.cs: Use new formats, since Gonzalo finished the missing
13936 * expression.cs (Binary.ResolveOperator): added missing operator|
13937 operator& and operator^ for bool/bool.
13939 * cs-parser.jay: CheckDef now takes a Location argument that is
13940 used to report errors more precisly (instead of reporting the end
13941 of a definition, we try to track something which is a lot closer
13942 to the source of the problem).
13944 * cs-tokenizer.cs: Track global token use, so we can properly flag
13945 the use of #define/#undef after the first token has been seen.
13947 Also, rename the reportXXXX to Error_DescriptiveName
13949 * decl.cs (DeclSpace.IsTopLevel): Move property here from
13950 TypeContainer, so that Enum and Interface can use this too.
13952 * class.cs (TypeContainer.LookupInterfaceOrClass,
13953 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
13954 `builder' argument. Typically this was used to pass the parent
13955 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
13958 The problem is that a nested class could trigger the definition of
13959 a toplevel class, and the builder would be obviously wrong in that
13962 So we drop this argument, and we compute dynamically the
13963 TypeBuilder/ModuleBuilder (the correct information was available
13964 to us anyways from DeclSpace.Parent)
13966 * interface.cs (Interface.DefineInterface): Drop builder
13967 parameter cleanup like class.cs
13969 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
13972 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
13975 (Try.Emit): Propagate the returns value from the statement.
13977 (Return.Emit): Even if we are leavning
13979 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
13981 * modifiers.cs: Fix the computation of MethodAttributes flags.
13983 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
13985 * driver.cs: allow compilation of files that start with '/'.
13986 Add a default case when checking the argument of --target.
13988 2002-03-25 Miguel de Icaza <miguel@ximian.com>
13990 * interface.cs: Implement the same search algorithm for types in
13991 the interface code.
13993 * delegate.cs: Do not allow multiple definition.
13995 * Recovered ChangeLog that got accidentally amputated
13997 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
13999 * rootcontext.cs: Load manually enum to allow core classes to
14000 contain enumerations.
14002 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
14003 Update to new static methods in TypeManager.
14005 * typemanager.cs (GetMethod, GetConstructor): Use our
14006 implementation of FindMembers to find the members, since during
14007 corlib compilation, the types are TypeBuilders and GetMethod and
14008 GetConstructor do not work.
14010 Make all methods in TypeManager static.
14012 (InitCodeHelpers): Split the functionality from
14013 the InitCodeTypes function.
14015 * driver.cs: Call InitCodeHelpers after we have populated the
14018 * cs-parser.jay (delegate_declaration): we did not used to compute
14019 the delegate name correctly for void delegates.
14021 2002-03-24 Miguel de Icaza <miguel@ximian.com>
14023 * rootcontext.cs (RootContext): Init the interface_resolve_order
14024 and type_container_resolve_order always.
14026 (ResolveCore, BootstrapCorlib_ResolveClass,
14027 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
14028 compiler when compiling with --nostdlib
14030 * class.cs (TypeContainer.DefineType): Check that our parent is
14031 not null. This test is most important when we are bootstraping
14034 * codegen.cs: Split out the symbol writing code.
14036 2002-03-25 Martin Baulig <martin@gnome.org>
14038 * driver.cs (-g): Made -g an alias for --debug.
14040 2002-03-24 Martin Baulig <martin@gnome.org>
14042 * codegen.cs (SymbolWriter): New public variable. Returns the
14043 current symbol writer.
14044 (CodeGen): Added `bool want_debugging_support' argument to the
14045 constructor. If true, tell the ModuleBuild that we want debugging
14046 support and ask it for the ISymbolWriter.
14047 (Save): If we have a symbol writer, call it's Close() method after
14048 saving the assembly.
14050 * driver.c (--debug): New command line argument to create a
14051 debugger information file.
14053 * location.cs (SymbolDocument): New public property. Returns an
14054 ISymbolDocumentWriter object for the current source file or null
14055 if we don't have a symbol writer.
14057 2002-03-21 Miguel de Icaza <miguel@ximian.com>
14059 * driver.cs (LoadAssembly): Correctly return when all the paths
14060 have been tried and not before.
14062 * statement.cs (Switch.Emit): return the actual coverage for this
14063 statement (returns/not-returns)
14065 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
14066 switch of the statement if we are the last switch section. That
14067 kills two problems: try/catch problems (we used to emit an empty
14068 nop at the end) and switch statements where all branches would
14071 2002-03-19 Miguel de Icaza <miguel@ximian.com>
14073 * driver.cs: Add default assemblies (the equivalent to the
14074 Microsoft CSC.RSP file)
14076 * cs-tokenizer.cs: When updating `cols and setting it to zero,
14077 also update tokens_seen and set it to false.
14079 * driver.cs: Implement --recurse for Mike.
14081 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
14082 correctly splitting out the paths.
14084 2002-03-18 Miguel de Icaza <miguel@ximian.com>
14086 * interface.cs (Interface.PopulateProperty): Instead of using
14087 `parent' as the declaration space for the set parameters, use
14090 * support.cs (InternalParameters): InternalParameters constructor
14091 takes a DeclSpace instead of a TypeContainer.
14093 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
14094 types are being initialized, load the address of it before calling
14097 (New): Provide a mechanism to disable the generation of local
14098 value type temporaries when the caller will be providing us with
14099 an address to store it.
14101 (ArrayCreation.EmitDynamicInitializers): Use it.
14103 2002-03-17 Miguel de Icaza <miguel@ximian.com>
14105 * expression.cs (Invocation.EmitArguments): Only probe for array
14106 property if there is more than one argument. Sorry about that.
14108 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
14109 empty param arrays.
14111 * class.cs (Method.LabelParameters): Fix incorrect code path that
14112 prevented the `ParamArrayAttribute' from being applied to the
14115 2002-03-16 Miguel de Icaza <miguel@ximian.com>
14117 * support.cs (ReflectionParameters): Correctly compute whether the
14118 last argument is a params array. Fixes the problem with
14121 * typemanager.cs: Make the assemblies array always be non-null
14122 (empty, but non-null)
14124 * tree.cs (RecordDecl): New function that abstracts the recording
14125 of names. This reports error 101, and provides a pointer to the
14126 previous declaration. Fixes a crash in the compiler.
14128 * cs-parser.jay (constructor_declaration): Update to new grammar,
14129 and provide a constructor_body that can be empty.
14131 2002-03-15 Miguel de Icaza <miguel@ximian.com>
14133 * driver.cs: Add support for --resources.
14135 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
14136 Make all types for the various array helper methods be integer.
14138 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
14139 CheckState to ConvCast.
14141 (ConvCast): Now it takes a `checked' state argument, to avoid
14142 depending on the emit context for the conversion, and just using
14143 the resolve time setting.
14145 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
14146 instead of Invocation.EmitArguments. We do not emit the original
14147 arguments, instead we emit those which have been converted to
14148 unsigned int expressions.
14150 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
14152 * codegen.cs: ditto.
14154 * expression.cs (LocalVariableReference): Drop the use of the
14155 Store function that depended on the variable index.
14157 * statement.cs (VariableInfo): Drop the `Idx' property from this
14158 class, as this is not taking into account the indexes for
14159 temporaries tat we generate during the execution, getting the
14162 * class.cs: First emit class initializers, then call the parent
14165 * expression.cs (Binary): Fix opcode emision.
14166 (UnaryMutator.EmitCode): Support checked code generation
14168 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
14169 matches for events for both the Static and Instance scans,
14170 pointing to the same element. Fix that.
14172 2002-03-14 Miguel de Icaza <miguel@ximian.com>
14174 * rootcontext.cs (ResolveTree): Always set the
14175 interface_resolve_order, because nested interfaces will be calling
14178 * class.cs (GetInterfaceOrClass): Track the same resolution
14179 process used by TypeManager.LookupType. This fixes the nested
14180 type lookups in class declarations (separate path from
14183 (TypeContainer.DefineType): Also define nested interfaces.
14184 (TypeContainer.RegisterOrder): New public function used to
14185 register the order in which child interfaces need to be closed.
14187 Nested interfaces need to be closed after their parents have been
14190 * interface.cs (InterfaceAttr): Put all the logic for computing
14191 the interface attribute here.
14193 (DefineInterface): Register our interface order with the
14194 RootContext or with the TypeContainer depending on the case.
14196 2002-03-12 Miguel de Icaza <miguel@ximian.com>
14198 * cs-parser.jay: rework foreach statement to work with the new
14199 changes to the policy on SimpleNames.
14201 * report.cs: support Stacktrace on warnings as well.
14203 * makefile: drop --unsafe and /unsafe from the compile.
14205 2002-03-13 Ravi Pratap <ravi@ximian.com>
14207 * ecore.cs (StandardConversionExists): Modify to take an Expression
14208 as the first parameter. Ensure we do null -> reference type conversion
14211 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
14212 temporary Expression objects.
14214 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
14216 * interface.cs: workaround bug in method overloading resolution
14217 (there is already a bugzilla bug for it).
14219 2002-03-12 Miguel de Icaza <miguel@ximian.com>
14221 We could also solve this problem by having a separate path for
14222 performing type lookups, instead of DoResolve, we could have a
14223 ResolveType entry point, and only participating pieces of the
14224 production (simplename, deref, array) would implement this.
14226 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
14227 signal SimpleName to only resolve type names and not attempt to
14228 resolve anything else.
14230 * expression.cs (Cast): Set the flag.
14232 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
14234 * class.cs: Only report 108 if there is no `new' modifier.
14236 * cs-parser.jay: rework foreach statement to work with the new
14237 changes to the policy on SimpleNames.
14239 * report.cs: support Stacktrace on warnings as well.
14241 * makefile: drop --unsafe and /unsafe from the compile.
14243 2002-03-11 Miguel de Icaza <miguel@ximian.com>
14245 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
14246 lookups here, instead of doing that at parse time. This means
14247 that our grammar will not introduce `LocalVariableReferences' as
14248 expressions at this point. That solves the problem of code like
14252 static void Main ()
14256 This is only half the fix. The full fix requires parameters to
14257 also be handled in this way.
14259 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
14260 makes the use more obvious of the DeclSpace. The
14261 ec.TypeContainer.TypeBuilder is now only used to pull the
14262 TypeBuilder for it.
14264 My theory is that I can get rid of the TypeBuilder completely from
14265 the EmitContext, and have typecasts where it is used (from
14266 DeclSpace to where it matters).
14268 The only pending problem is that the code that implements Aliases
14269 is on TypeContainer, and probably should go in DeclSpace.
14271 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
14272 lookups here, instead of doing that at parse time. This means
14273 that our grammar will not introduce `LocalVariableReferences' as
14274 expressions at this point. That solves the problem of code like
14278 static void Main ()
14282 This is only half the fix. The full fix requires parameters to
14283 also be handled in this way.
14285 * class.cs (Property.DefineMethod): When implementing an interface
14286 method, set newslot, when implementing an abstract method, do not
14287 set the flag (before we tried never setting it, or always setting
14288 it, which is the difference).
14289 (Indexer.DefineMethod): same.
14290 (Method.DefineMethod): same.
14292 * ecore.cs: Only set the status used flag if we get back a Field.
14294 * attribute.cs: Temporary hack, so Paolo can keep working.
14296 2002-03-08 Ravi Pratap <ravi@ximian.com>
14298 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
14299 the unmanaged type in the case we have a MarshalAs attribute.
14301 (Resolve): Handle the case when we are parsing the special MarshalAs
14302 attribute [we need to store the unmanaged type to use later]
14304 * typemanager.cs (marshal_as_attr_type): Built in type for the
14305 MarshalAs Attribute.
14307 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
14308 on parameters and accordingly set the marshalling info.
14310 2002-03-09 Miguel de Icaza <miguel@ximian.com>
14312 * class.cs: Optimizing slightly by removing redundant code after
14313 we switched to the `NoTypes' return value.
14314 (Property.DefineMethod): use NoTypes here too.
14316 This fixes the bug I introduced in my last batch of changes.
14318 2002-03-05 Ravi Pratap <ravi@ximian.com>
14320 * tree.cs (RecordEnum): Add. We now keep track of enums too.
14322 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
14323 Enums since those are types too.
14325 * cs-parser.jay (enum_declaration): Record enums as we parse them.
14327 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
14328 thanks to a call during the lookup process.
14330 2002-03-07 Miguel de Icaza <miguel@ximian.com>
14332 * statement.cs (Foreach): Lots of work to accomodate a particular
14333 kind of foreach statement that I had not kept in mind. It is
14334 possible to have foreachs on classes that provide a GetEnumerator
14335 method that return objects that implement the "pattern" for using
14336 a foreach, there is no need to support GetEnumerator
14339 This is needed to compile nant.
14341 * decl.cs: Only report 114 if the member is not `Finalize' and if
14342 the warning level is at least 2.
14344 * class.cs: Moved the compare function from Method to
14347 (MethodSignature.InheritableMemberSignatureCompare): Add new
14348 filter function that is used to extract inheritable methods from a
14351 (Method.Define): Use the new `inheritable_method_signature_filter'
14354 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
14357 2002-03-06 Miguel de Icaza <miguel@ximian.com>
14359 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
14361 * cs-parser.jay: Add opt_semicolon to the interface declaration.
14363 * expression.cs: Pass location information to
14364 ConvertImplicitStandard.
14366 * class.cs: Added debugging code to track return values from
14369 2002-03-05 Miguel de Icaza <miguel@ximian.com>
14371 * expression.cs (Is.DoResolve): If either side of the `is' is an
14372 interface, do not flag the warning.
14374 * ecore.cs (ImplicitReferenceConversion): We need a separate test
14377 * report.cs: Allow for --fatal to be used with --probe.
14379 * typemanager.cs (NoTypes): Move the definition for the empty Type
14382 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
14384 (TypeContainer.DefineProxy): New function used to proxy to parent
14385 implementations when implementing interfaces.
14386 (TypeContainer.ParentImplements): used to lookup if our parent
14387 implements a public function that is required by an interface.
14388 (TypeContainer.VerifyPendingMethods): Hook this up.
14390 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
14391 `modules' and `assemblies' arraylists into arrays. We only grow
14392 these are the very early start up of the program, so this improves
14393 the speedof LookupType (nicely measured).
14395 * expression.cs (MakeByteBlob): Replaced unsafe code with
14396 BitConverter, as suggested by Paolo.
14398 * cfold.cs (ConstantFold.Binary): Special case: perform constant
14399 folding of string concatenation, but if either side is a string,
14400 and the other is not, then return null, and let the runtime use
14401 the concatenation on the string plus the object (using
14402 `Object.ToString').
14404 2002-03-04 Miguel de Icaza <miguel@ximian.com>
14406 Constant Folding has been implemented now.
14408 * expression.cs (Unary.Reduce): Do not throw an exception, catch
14409 the error instead on types that are not supported in one's
14412 * constant.cs (Constant and all children): New set of functions to
14413 perform implict and explicit conversions.
14415 * ecore.cs (EnumConstant): Implement the new functions to perform
14416 conversion by proxying to the child expression.
14418 * codegen.cs: (ConstantCheckState): Constant evaluation has its
14419 own separate setting that can not be turned off from the command
14420 line using --unchecked or --checked and is only controlled using
14421 the checked/unchecked statements and expressions. This setting is
14422 used by the constant folder to flag errors.
14424 * expression.cs (CheckedExpr, UncheckedExpr): Set the
14425 ConstantCheckState as well.
14427 During Resolve, they also have to flag the state, because the
14428 constant folder runs completely in the Resolve phase.
14430 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
14433 2002-03-01 Miguel de Icaza <miguel@ximian.com>
14435 * cfold.cs: New file, this file contains the constant folder.
14437 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
14438 argument to track whether we are using the resulting address to
14439 load or store a value and provide better error messages.
14441 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
14442 new AddressOf arguments.
14444 * statement.cs (Foreach.EmitCollectionForeach): Update
14446 * expression.cs (Argument.Emit): Call AddressOf with proper
14447 arguments to track usage.
14449 (New.DoEmit): Call AddressOf with new arguments.
14451 (Unary.Emit): Adjust AddressOf call.
14453 2002-03-01 Ravi Pratap <ravi@ximian.com>
14455 * cs-parser.jay (member_access): Change the case for pre-defined types
14456 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
14459 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
14462 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
14463 essentially like methods and apply attributes like MethodImplOptions to them too.
14465 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
14468 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
14469 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
14472 * Update code everywhere accordingly.
14474 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
14476 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
14478 2002-02-28 Ravi Pratap <ravi@ximian.com>
14480 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
14481 try performing lookups against those instead of jumping straight into using
14482 the 'using' clauses.
14484 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
14486 (LookupType): Perform lookups in implicit parents too.
14488 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
14489 sequence as RootContext.LookupType.
14491 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
14492 the various cases of namespace lookups into this method.
14494 2002-03-01 Miguel de Icaza <miguel@ximian.com>
14496 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
14497 in positional arguments)
14499 * class.cs (Operator): Update the AllowedModifiers to contain
14502 * cs-parser.jay: Update operator declaration to allow for the
14503 operator body to be empty.
14505 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
14508 2002-02-27 Miguel de Icaza <miguel@ximian.com>
14510 * class.cs (Method.Emit): Label parameters.
14512 * driver.cs: Return 1 or 0 as the program exit code.
14514 2002-02-26 Miguel de Icaza <miguel@ximian.com>
14516 * expression.cs: Special case the `null' object when trying to
14517 auto-compute the type, as anything can be explicitly converted to
14520 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
14521 spotting this Paolo.
14523 (Expression.ImplicitNumericConversion): Perform comparissions of
14524 the type using the underlying type in the case of an enumeration
14525 rather than using the enumeration type for the compare.
14527 Cope with the underlying == type case, which is not possible to
14530 (Expression.ConvertNumericExplicit): Perform comparissions of
14531 the type using the underlying type in the case of an enumeration
14532 rather than using the enumeration type for the compare.
14534 * driver.cs: If the user does not supply an extension, assume .exe
14536 * cs-parser.jay (if_statement): Rewrote so that we can track the
14537 location for the if statement.
14539 * expression.cs (Binary.ConstantFold): Only concat strings when
14540 the operation is "+", not everything ;-)
14542 * statement.cs (Statement.EmitBoolExpression): Take a location
14544 (If, While, Do): Track location.
14546 * expression.cs (Binary.ResolveOperator): In the object + string
14547 case, I was missing a call to ConvertImplicit
14549 2002-02-25 Ravi Pratap <ravi@ximian.com>
14551 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
14552 Location arguments. Ensure we use RootContext.LookupType to do our work
14553 and not try to do a direct Type.GetType and ModuleBuilder.GetType
14555 * interface.cs (PopulateMethod): Handle the type of the parameter being
14558 * expression.cs (Invocation.BetterFunction): Handle the case when we
14559 have a params method with no fixed arguments and a call is made with no
14562 2002-02-25 Miguel de Icaza <miguel@ximian.com>
14564 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
14565 the verbatim-string-literal
14567 * support.cs (InternalParameters.ParameterModifier): handle null
14569 (InternalParameters.ParameterType): ditto.
14571 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
14572 duplicating the name of the variable parameter.
14573 (GetParameterByName): Fix bug where we were not looking up array
14574 paramters if they were the only present (thanks Paolo!).
14575 (GetParameterInfo): We only have an empty set of types if both
14576 fixed and array are set to null.
14577 (GetParameterInfo-idx): Handle FixedParameter == null
14579 * cs-parser.jay: Handle the case where there is no catch
14580 statements (missing null test).
14582 2002-02-22 Miguel de Icaza <miguel@ximian.com>
14584 * driver.cs (MainDriver): Be conservative on our command line
14587 Catch DirectoryNotFoundException when calling GetFiles.
14589 (SplitPathAndPattern): Used to split the input specification into
14590 a path and a pattern that we can feed to Directory.GetFiles.
14592 2002-02-21 Miguel de Icaza <miguel@ximian.com>
14594 * statement.cs (Fixed): Implement the last case of the Fixed
14595 statement (string handling).
14597 * expression.cs (StringPtr): New class used to return a char * to
14598 a string; Used by the Fixed statement.
14600 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
14602 * expression.cs (Binary.ResolveOperator): Remove redundant
14603 MemberLookup pn parent type.
14604 Optimize union call, we do not need a union if the types are the same.
14605 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
14608 Specialize the use of MemberLookup everywhere, instead of using
14609 the default settings.
14611 (StackAlloc): Implement stackalloc keyword.
14613 * cs-parser.jay: Add rule to parse stackalloc.
14615 * driver.cs: Handle /h, /help, /?
14617 * expression.cs (MakeByteBlob): Removed the hacks we had in place
14618 before we supported unsafe code.
14620 * makefile: add --unsafe to the self compilation of mcs.
14622 2002-02-20 Miguel de Icaza <miguel@ximian.com>
14624 * expression.cs (PointerArithmetic): New class that is used to
14625 perform pointer arithmetic.
14626 (Binary.Resolve): Handle pointer arithmetic
14627 Handle pointer comparission.
14628 (ArrayPtr): Utility expression class that is used to take the
14629 address of an array.
14631 (ElementAccess): Implement array access for pointers
14633 * statement.cs (Fixed): Implement fixed statement for arrays, we
14634 are missing one more case before we are done.
14636 * expression.cs (Indirection): Implement EmitAssign and set the
14637 ExprClass to Variable. This allows pointer dereferences to be
14638 treated as variables, and to have values assigned to them.
14640 * ecore.cs (Expression.StoreFromPtr): New utility function to
14641 store values dereferencing.
14643 2002-02-20 Ravi Pratap <ravi@ximian.com>
14645 * expression.cs (Binary.ResolveOperator): Ensure that we are
14646 not trying to operate on a void type - this fixes the reported
14649 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
14650 the parent implementation is sealed.
14652 * ../errors/cs0239.cs : Add.
14654 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
14656 * typemanager.cs (unverifiable_code_type): Corresponds to
14657 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
14658 which have unsafe code in them.
14660 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
14663 2002-02-19 Miguel de Icaza <miguel@ximian.com>
14665 * cs-tokenizer.cs: Add support for @"litreal strings"
14667 Make tokenizer accept pre-processor directives
14668 on any column (remove the old C-like limitation).
14670 * rootcontext.cs (EmitCode): Emit any global attributes.
14671 (AddGlobalAttributes): Used to keep track of assembly attributes.
14673 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
14675 * cs-parser.jay: Add support for global attributes.
14677 2002-02-17 Miguel de Icaza <miguel@ximian.com>
14679 * expression.cs (Indirection): New helper class. Unary will
14680 create Indirection classes to be able to implement the
14681 IMemoryLocation interface on it.
14683 2002-02-16 Miguel de Icaza <miguel@ximian.com>
14685 * cs-parser.jay (fixed_statement): reference the right statement.
14687 * statement.cs (Fixed.Emit): Finish implementing the fixed
14688 statement for the &x case.
14690 2002-02-14 Miguel de Icaza <miguel@ximian.com>
14692 * class.cs (Property.Define, Method.Define): Remove newslot when
14695 * modifiers.cs: My use of NewSlot when `Abstract' was set was
14696 wrong. NewSlot should only be used if the `new' keyword is present.
14698 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
14699 locating our system dir. Sorry about this.
14701 2002-02-13 Miguel de Icaza <miguel@ximian.com>
14703 * driver.cs (GetSystemDir): Compute correctly the location of our
14704 system assemblies. I was using the compiler directory instead of
14705 the library directory.
14707 2002-02-13 Ravi Pratap <ravi@ximian.com>
14709 * expression.cs (BetterFunction): Put back in what Miguel commented out
14710 since it is the correct fix. The problem is elsewhere ;-)
14712 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
14713 parameters of the parms method are themselves compatible or not !
14715 (StandardConversionExists): Fix very dangerous bug where we were forgetting
14716 to check that a class implements an interface before saying that an implicit
14717 conversion was allowed. Use ImplementsInterface to do the checking.
14719 2002-02-13 Miguel de Icaza <miguel@ximian.com>
14721 * class.cs (Method.Define): Track whether we are an explicit
14722 implementation or not. And only call DefineMethodOverride if we
14723 are an explicit implementation.
14725 (Property.DefineMethod): Ditto.
14727 2002-02-11 Ravi Pratap <ravi@ximian.com>
14729 * expression.cs (BetterFunction): Catch hideous bug which was
14730 preventing us from detecting ambiguous calls due to implicit casts i.e
14733 2002-01-29 Miguel de Icaza <miguel@ximian.com>
14735 * support.cs (Pair): Remove un-needed method. I figured why I was
14736 getting the error in cs-parser.jay, the variable in a foreach loop
14737 is readonly, and the compiler does not really treat this as a variable.
14739 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
14740 instead of EQUALS in grammar.
14742 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
14744 * expression.cs (Unary.DoResolve): Check whether the argument is
14747 2002-01-28 Miguel de Icaza <miguel@ximian.com>
14749 * support.cs: Api for Pair to set a value. Despite the fact that
14750 the variables are public the MS C# compiler refuses to compile
14751 code that accesses the field if the variable is part of a foreach
14754 * statement.cs (Fixed): Begin implementation of the fixed
14757 (Block.AddVariable): Return the VariableInfo on success and null
14758 on failure instead of true/false.
14760 * cs-parser.jay (foreach): Catch errors on variables already
14761 defined (we were ignoring this value before) and properly unwind
14762 the block hierarchy
14764 (fixed_statement): grammar for the fixed statement.
14766 2002-01-25 Miguel de Icaza <miguel@ximian.com>
14768 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
14769 pointer types to be incretemented.
14771 (SizeOf): Implement.
14773 * cs-parser.jay (pointer_member_access): Implement
14774 expr->IDENTIFIER production.
14776 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
14777 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
14780 (Unary): Implement indirection.
14782 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
14783 use in non-unsafe context).
14785 (SimpleName.DoResolve): Check for pointers in field access on safe
14788 (Expression.LoadFromPtr): Factor the load-indirect code in this
14789 function. This was duplicated in UnboxCast and ParameterReference
14791 2002-01-24 Miguel de Icaza <miguel@ximian.com>
14793 * expression.cs (ComposedCast): report an error if a pointer cast
14794 is used in a safe region.
14796 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
14797 pointer type casts in unsafe context.
14799 * codegen.cs (EmitContext): Set up IsUnsafe.
14801 * cs-parser.jay (non_expression_type): Add productions for pointer
14804 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
14805 code. We should not use force into static mode if the method is
14806 not virtual. Fixes bug in MIS
14808 * statement.cs (Do.Emit, While.Emit, For.Emit,
14809 Statement.EmitBoolExpression): Add support to Do and While to
14810 propagate infinite loop as `I do return' semantics.
14812 Improve the For case to also test for boolean constants.
14814 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
14815 to the list of attributes we can add.
14817 Remove `EmitContext' argument.
14819 * class.cs (Method.Define): Apply parameter attributes.
14820 (Constructor.Define): Apply parameter attributes.
14821 (MethodCore.LabelParameters): Move here the core of labeling
14824 * support.cs (ReflectionParameters.ParameterModifier,
14825 InternalParameters.ParameterModifier): Use IsByRef on the type and
14826 only return the OUT bit for these parameters instead of in/out/ref
14829 This is because I miss-understood things. The ParameterInfo.IsIn
14830 and IsOut represent whether the parameter has the [In] and [Out]
14833 2002-01-22 Miguel de Icaza <miguel@ximian.com>
14835 * ecore.cs (FieldExpr.Emit): Release temporaries.
14837 * assign.cs (LocalTemporary.Release): new function.
14839 * codegen.cs (EmitContext.GetTemporaryStorage,
14840 EmitContext.FreeTemporaryStorage): Rework the way we deal with
14841 temporary storage. Now we can "put back" localbuilders when we
14844 2002-01-21 Miguel de Icaza <miguel@ximian.com>
14846 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
14847 need to make a copy of the variable to generate verifiable code.
14849 2002-01-19 Miguel de Icaza <miguel@ximian.com>
14851 * driver.cs: Compute dynamically the system directory.
14853 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
14854 Slower, but more generally useful. Used by the abstract
14855 registering implementation.
14857 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
14858 the rules for the special rule on Type/instances. First check if
14859 we have the same name, and if so, try that special static path
14860 rather than the instance path.
14862 2002-01-18 Miguel de Icaza <miguel@ximian.com>
14864 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
14867 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
14868 Enum, ValueType, Delegate or Array for non-corlib compiles.
14870 * cs-tokenizer.cs: Catch long identifiers (645)
14872 * typemanager.cs (IndexerPropetyName): Ravi never tested this
14875 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
14876 fix, we were returning too early, so we were not registering
14877 pending methods from abstract classes.
14879 Do not register pending methods if the class is abstract.
14881 * expression.cs (Conditional.DoResolve): Report circular implicit
14882 conversions when we neecd to compute it for conditional
14885 (Is.DoResolve): If the expression is always of the provided type,
14886 flag warning 183. If the expression can not ever be of the
14887 provided type flag warning 184.
14889 * class.cs: Catch 169 as well.
14891 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
14894 2002-01-18 Nick Drochak <ndrochak@gol.com>
14896 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
14898 2002-01-17 Miguel de Icaza <miguel@ximian.com>
14900 * interface.cs: (PopulateMethod): Check for pointers being defined
14901 only if the unsafe context is active.
14902 (PopulateProperty): ditto.
14903 (PopulateIndexer): ditto.
14905 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
14906 specified. If pointers are present, make sure that they are
14907 present in an unsafe context.
14908 (Constructor, Constructor.Define): ditto.
14909 (Field, Field.Define): ditto.
14910 (Property, Property.Define): ditto.
14911 (Event, Event.Define): ditto.
14913 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
14914 hashtable if there are classes or structs defined.
14916 * expression.cs (LocalVariableReference.DoResolve): Simplify this
14917 code, as the constant resolution moved.
14919 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
14920 the metadata, so we can flag error 133.
14922 * decl.cs (MemberCore.UnsafeOK): New function to test that a
14923 pointer is being declared in an unsafe context.
14925 2002-01-16 Miguel de Icaza <miguel@ximian.com>
14927 * modifiers.cs (Modifiers.Check): Require a Location argument.
14928 Report error 227 for Unsafe use.
14930 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
14932 * statement.cs (For.Emit): If the test is null, then report that
14933 we do `return', as we wont reach anything afterwards.
14935 (Switch.SwitchGoverningType): Track the expression that matched
14938 * driver.cs: Allow negative numbers as an error code to flag.
14940 * cs-parser.jay: Handle 1551.
14942 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
14944 2002-01-15 Miguel de Icaza <miguel@ximian.com>
14946 * cs-parser.jay: Report 1518 (type declaration can only contain
14947 class, struct, interface, enum or delegate)
14949 (switch_label): Report 1523 (keywords `case' or `default' must
14952 (opt_switch_sections): Report 1522 (empty switch)
14954 * driver.cs: Report 1515 (response file specified multiple times)
14955 Report 1516 (Source file specified multiple times).
14957 * expression.cs (Argument.Resolve): Signal 1510
14959 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
14960 access not allowed in static code)
14962 2002-01-11 Ravi Pratap <ravi@ximian.com>
14964 * typemanager.cs (IsPointerType): Utility method which we are going
14967 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
14968 the object type, so we take care of that.
14970 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
14972 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
14973 added to non-params parameters :-)
14975 * typemanager.cs (CSharpName): Include 'void' type too.
14977 (void_ptr_type): Include in the set of core types.
14979 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
14982 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
14985 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
14986 completely forgotten about it.
14988 2002-01-10 Ravi Pratap <ravi@ximian.com>
14990 * cs-parser.jay (pointer_type): Add. This begins our implementation
14991 of parsing rules for unsafe code.
14993 (unsafe_statement): Implement.
14995 (embedded_statement): Modify to include the above.
14997 * statement.cs (Unsafe): Implement new class for unsafe blocks.
14999 * codegen.cs (EmitContext.InUnsafe): Add. This determines
15000 if the current context is an unsafe one.
15002 * cs-parser.jay (local_variable_pointer_type): Since local variable types
15003 are handled differently, we need separate rules for them.
15005 (local_variable_declaration): Update to use local_variable_pointer_type
15006 to allow variable declarations of unmanaged pointer types.
15008 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
15009 in unsafe contexts.
15011 * ../errors/cs0214.cs : Add.
15013 2002-01-16 Nick Drochak <ndrochak@gol.com>
15015 * makefile: remove 'response' file when cleaning.
15017 2002-01-15 Miguel de Icaza <miguel@ximian.com>
15019 * cs-parser.jay: Report 1524.
15021 2002-01-14 Miguel de Icaza <miguel@ximian.com>
15023 * typemanager.cs (RegisterMethod): drop checking if we have
15024 registered this from here
15026 2002-01-12 Miguel de Icaza <miguel@ximian.com>
15028 * class.cs (Method.EmitDestructor): Implement calling our base
15031 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
15032 value of InFinally.
15034 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
15035 this routine and will wrap the call in a try/catch block. Deal
15038 2002-01-11 Miguel de Icaza <miguel@ximian.com>
15040 * ecore.cs (Expression.MemberLookup): instead of taking a
15041 parameter `same_type' that was used to tell whether we could
15042 access private members we compute our containing type from the
15045 (FieldExpr): Added partial support for volatile fields. This does
15046 not work for volatile fields exposed from assemblies, as I can not
15047 figure out how to extract the modreq from it.
15049 Updated all the source files to use this.
15051 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
15052 because it is referenced by MemberLookup very often.
15054 2002-01-09 Ravi Pratap <ravi@ximian.com>
15056 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
15057 TypeBuilder.GetCustomAttributes to retrieve what we need.
15059 Get rid of redundant default_member_attr_type as this is the same as
15060 default_member_type which already exists.
15062 * interface.cs, attribute.cs : Update accordingly.
15064 2002-01-08 Miguel de Icaza <miguel@ximian.com>
15066 * typemanager.cs: Enable IndexerPropertyName again. It does not
15067 work for TYpeBuilders though. Ravi, can you please fix this?
15069 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
15071 * expression.cs (Argument.Emit): Handle the case of ref objects
15072 being passed to ref functions;
15074 (ParameterReference.EmitLoad): Loads the content of the pointer
15075 without dereferencing.
15077 2002-01-07 Miguel de Icaza <miguel@ximian.com>
15079 * cs-tokenizer.cs: Implemented the pre-processing expressions.
15081 2002-01-08 Ravi Pratap <ravi@ximian.com>
15083 * class.cs (Indexer.DefineMethod): Incorporate the interface
15084 type in the name of the method if we are doing explicit interface
15087 * expression.cs (ConversionExists): Remove as it is completely obsolete.
15089 (BetterConversion): Fix extremely trivial bug where we were referring to
15090 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
15093 * ../errors/bug16.cs : Add although we have fixed it.
15095 2002-01-07 Miguel de Icaza <miguel@ximian.com>
15097 * expression.cs (BaseIndexer): Begin implementation.
15099 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
15101 * cs-parser.jay (indexer_declarator): Use qualified_identifier
15102 production directly to remove a shift/reduce, and implement
15103 explicit interface implementation.
15105 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
15106 after a floating point suffix.
15108 * expression.cs (DoNumericPromotions): Improved the conversion for
15109 uint/uint. If we have a constant, we avoid doing a typecast to a
15112 * class.cs (Indexer): Implement explicit interface implementation
15115 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
15117 * class.cs: make the default instance constructor public and hidebysig.
15119 2001-01-03 Ravi Pratap <ravi@ximian.com>
15121 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
15122 so we can call it from elsewhere.
15124 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
15125 we emit it internally if the class has a defined indexer; otherwise the user
15126 emits it by decorating the class definition with the DefaultMemberAttribute.
15128 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
15129 attribute is not used on a type which defines an indexer.
15131 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
15132 character when we skip whitespace.
15134 * ../errors/cs0646.cs : Add.
15136 2002-01-03 Miguel de Icaza <miguel@ximian.com>
15138 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
15141 * makefile: Add practical target `mcs3.exe' which builds the third
15142 generation compiler.
15144 * expression.cs (New): Fix structures constructor calling.
15146 * class.cs (Property, Method, Indexer): Emit Final flag on the
15147 method if we are an interface implementation and we are not
15150 * ecore.cs (PropertyExpr): New public field `IsBase', tells
15151 whether this property is referencing a `base' method.
15153 * expression.cs (Invocation.EmitCall): take an extra argument:
15154 is_base, this is used to determine whether the `call' or
15155 `callvirt' opcode should be used.
15158 * delegate.cs: update EmitCall.
15160 * class.cs (Method.Define): Set NewSlot for the cases where we are
15161 not implementing an interface method.
15163 (Property.Define): ditto.
15165 2002-01-02 Miguel de Icaza <miguel@ximian.com>
15167 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
15168 'r'. Allows mcs to parse itself fully.
15170 2002-01-02 Ravi Pratap <ravi@ximian.com>
15172 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
15173 of the number of initializers that require the InitializeArray method.
15175 (CheckIndices): Store the Expression in all cases - not the plain value. Also
15176 update the above field where necessary.
15178 (MakeByteBlob): Update accordingly.
15180 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
15183 (EmitDynamicInitializers): Update in accordance with the new optimization.
15185 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
15186 same OpCode applies.
15188 * cs-parser.jay : Fix some glaring errors I introduced.
15190 2002-01-01 Ravi Pratap <ravi@ximian.com>
15192 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
15193 so that we can check for name clashes there too.
15195 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
15196 for interface indexers.
15198 * interfaces.cs (Define): Emit the default member attribute.
15200 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
15201 variable was being referred to while setting the value ;-)
15203 2002-01-01 Miguel de Icaza <miguel@ximian.com>
15205 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
15206 byte-by-byte information when we know the data is zero.
15208 Make the block always a multiple of 4, because
15209 DefineInitializedData has a bug.
15211 * assign.cs: Fix, we should assign from the temporary, not from
15214 * expression.cs (MakeByteBlob): Fix my incorrect code.
15216 2001-12-31 Miguel de Icaza <miguel@ximian.com>
15218 * typemanager.cs (EnumToUnderlying): This function is used to get
15219 the underlying type from an enumeration, because it does not
15222 * constant.cs: Use the I4_S form for values between -128 and 127.
15224 * statement.cs (Block.LookupLabel): Looks up a label.
15225 (Block): Drop support for labeled blocks.
15227 (LabeledStatement): New kind of statement that represents a label
15230 (Goto): Finally implement this bad boy.
15232 * cs-parser.jay: Update to reflect new mechanism to implement
15235 2001-12-30 Miguel de Icaza <miguel@ximian.com>
15237 * codegen.cs (EmitContext.This): a codegen property that keeps the
15238 a single instance of this instead of creating many different this
15241 * delegate.cs (Delegate.DoResolve): Update to use the property;
15243 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
15245 * expression.cs (BaseAccess.DoResolve): Ditto.
15247 2001-12-29 Ravi Pratap <ravi@ximian.com>
15249 * typemanager.cs (methodimpl_attr_type): Add to hold the type
15250 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
15252 (InitCoreTypes): Update accordingly.
15254 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
15255 so we can quickly store the state.
15257 (ApplyAttributes): Set the correct implementation flags
15258 for InternalCall methods.
15260 2001-12-29 Miguel de Icaza <miguel@ximian.com>
15262 * expression.cs (EmitCall): if a method is not virtual, then do
15263 not use callvirt on it.
15265 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
15266 user defined stuff) requires the use of stobj, which takes an
15267 address on the stack instead of an array and an index. So emit
15268 the Ldelema operation for it.
15270 (EmitStoreOpcode): Use stobj for valuetypes.
15272 (UnaryMutator.EmitCode): Use the right 1 value depending on
15273 whether we are dealing with int64/uint64, float or doubles.
15275 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
15276 constructors that I implemented last night.
15278 (Constructor.IsDefault): Fix to work properly for static
15281 * cs-parser.jay (CheckDef): report method signature errors.
15282 Update error number 103 to be 132.
15284 * decl.cs: New AdditionResult enumeration value: MethodExists.
15285 Although we do this check for methods later on in the semantic
15286 analysis, catching repeated default constructors is so easy that
15287 we catch these here.
15289 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
15292 (ParameterReference.EmitAssign, Emit): handle
15295 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
15296 (ArrayAccess.EmitStoreOpcode): ditto.
15298 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
15300 * expression.cs (MakeByteBlob): Complete all the missing types
15301 (uint, short, ushort, byte, sbyte)
15303 * class.cs: Only init instance field initializers on instance
15306 Rename `constructors' to instance_constructors.
15308 (TypeContainer.AddConstructor): Only add constructors to the list
15309 if it is not static.
15311 Make sure that we handle default_static_constructor independently
15312 everywhere where we handle instance_constructors
15314 2001-12-28 Miguel de Icaza <miguel@ximian.com>
15316 * class.cs: Do not lookup or create a base initializer for a
15317 static constructor.
15319 (ConstructorInitializer.Resolve): use the proper type to lookup
15322 * cs-parser.jay: Report error 1585 (modifiers between type and name).
15324 * enum.cs, interface.cs: Remove CloseType, this is taken care by
15327 * decl.cs: CloseType is now an virtual method, the default
15328 implementation just closes this type.
15330 2001-12-28 Ravi Pratap <ravi@ximian.com>
15332 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
15333 to PreserveSig by default. Also emit HideBySig on such methods.
15335 Basically, set the defaults to standard values.
15337 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
15338 argument, if candidate is better, it can't be worse than the best !
15340 (Invocation): Re-write bits to differentiate between methods being
15341 applicable in their expanded form and their normal form - for params
15344 Get rid of use_standard everywhere as only standard conversions are allowed
15345 in overload resolution.
15347 More spec conformance.
15349 2001-12-27 Miguel de Icaza <miguel@ximian.com>
15351 * driver.cs: Add --timestamp, to see where the compiler spends
15354 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
15355 `this' in static code.
15357 (SimpleName.DoResolve): Implement in terms of a helper function
15358 that allows static-references to be passed upstream to
15361 (Expression.ResolveWithSimpleName): Resolve specially simple
15362 names when called by MemberAccess to implement the special
15365 (Expression.ImplicitReferenceConversion): Handle conversions from
15366 Null to reference types before others, as Null's type is
15369 * expression.cs (Invocation.EmitCall): Handle the special case of
15370 calling methods declared on a reference type from a ValueType
15371 (Base classes System.Object and System.Enum)
15373 (MemberAccess.Resolve): Only perform lookups on Enumerations if
15374 the left hand side is a TypeExpr, not on every enumeration.
15376 (Binary.Resolve): If types are reference types, then do a cast to
15377 object on operators != and == of both arguments.
15379 * typemanager.cs (FindMembers): Extract instance and static
15380 members if requested.
15382 * interface.cs (PopulateProperty): Use void_type instead of null
15383 as the return type for the setter method.
15385 (PopulateIndexer): ditto.
15387 2001-12-27 Ravi Pratap <ravi@ximian.com>
15389 * support.cs (ReflectionParameters): Fix minor bug where we
15390 were examining the wrong parameter for the ParamArray attribute.
15392 Cope with requests for the type of the parameter at position
15393 greater than the params parameter's. We now return the element
15394 type of the params array as that makes more sense.
15396 * expression.cs (Invocation.IsParamsMethodApplicable): Update
15397 accordingly as we no longer have to extract the element type
15400 (Invocation.OverloadResolve): Update.
15402 2001-12-27 Miguel de Icaza <miguel@ximian.com>
15404 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
15405 against IEnumerator, test whether the return value is a descendant
15406 of the IEnumerator interface.
15408 * class.cs (Indexer.Define): Use an auxiliary method to implement
15409 the other bits of the method definition. Begin support for
15410 explicit interface implementation.
15412 (Property.DefineMethod): Use TypeManager.void_type instead of null
15413 for an empty return value.
15415 2001-12-26 Miguel de Icaza <miguel@ximian.com>
15417 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
15418 dealing with a FieldExpr which is composed of a FieldBuilder, in
15419 the code path we did extract the constant, but we should have
15420 obtained the underlying value to be able to cast it (otherwise we
15421 end up in an infinite loop, this is what Ravi was running into).
15423 (ArrayCreation.UpdateIndices): Arrays might be empty.
15425 (MemberAccess.ResolveMemberAccess): Add support for section
15426 14.5.4.1 that deals with the special case of E.I when E is a type
15427 and something else, that I can be a reference to a static member.
15429 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
15430 handle a particular array type to create byte blobs, it is just
15431 something we dont generate byteblobs for.
15433 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
15436 * location.cs (Push): remove the key from the hashtable that we
15437 are about to add. This happens for empty files.
15439 * driver.cs: Dispose files after we have parsed them.
15441 (tokenize): new function that only runs the tokenizer on its
15442 input, for speed testing.
15444 2001-12-26 Ravi Pratap <ravi@ximian.com>
15446 * class.cs (Event.Define): Define the private field only if there
15447 are no accessors defined.
15449 * expression.cs (ResolveMemberAccess): If there is no associated
15450 field with the event, that means we have an event defined with its
15451 own accessors and we should flag error cs0070 since transforming
15452 ourselves into a field is not valid in that case.
15454 * ecore.cs (SimpleName.DoResolve): Same as above.
15456 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
15457 and charset to sane values.
15459 2001-12-25 Ravi Pratap <ravi@ximian.com>
15461 * assign.cs (DoResolve): Perform check on events only if they
15462 are being accessed outside the declaring type.
15464 * cs-parser.jay (event_declarations): Update rules to correctly
15465 set the type of the implicit parameter etc.
15467 (add_accessor, remove_accessor): Set current local parameters.
15469 * expression.cs (Binary): For delegate addition and subtraction,
15470 cast the return value from the method into the appropriate delegate
15473 2001-12-24 Ravi Pratap <ravi@ximian.com>
15475 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
15476 of these as the workaround is unnecessary.
15478 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
15479 delegate data - none of that is needed at all.
15481 Re-write bits to extract the instance expression and the delegate method
15484 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
15487 * attribute.cs (ApplyAttributes): New method to take care of common tasks
15488 of attaching attributes instead of duplicating code everywhere.
15490 * everywhere : Update code to do attribute emission using the above method.
15492 2001-12-23 Miguel de Icaza <miguel@ximian.com>
15494 * expression.cs (IsParamsMethodApplicable): if there are not
15495 parameters, return immediately.
15497 * ecore.cs: The 0 literal can be implicity converted to an enum
15500 (SimpleName.DoResolve): First lookup the type, then lookup the
15503 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
15504 want to get its address. If the InstanceExpression is not
15505 addressable, store the result in a temporary variable, then get
15508 * codegen.cs: Only display 219 errors on warning level or above.
15510 * expression.cs (ArrayAccess): Make it implement the
15511 IMemoryLocation interface.
15513 (Binary.DoResolve): handle the operator == (object a, object b)
15514 and operator != (object a, object b) without incurring into a
15515 BoxedCast (because 5 != o should never be performed).
15517 Handle binary enumerator operators.
15519 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
15520 value type, otherwise use Ldelem_ref.
15522 Use precomputed names;
15524 (AddressOf): Implement address of
15526 * cs-parser.jay (labeled_statement): Fix recursive block
15527 addition by reworking the production.
15529 * expression.cs (New.DoEmit): New has a special case:
15531 If we are dealing with a ValueType, we have a few
15532 situations to deal with:
15534 * The target of New is a ValueType variable, that is
15535 easy, we just pass this as the variable reference
15537 * The target of New is being passed as an argument,
15538 to a boxing operation or a function that takes a
15541 In this case, we need to create a temporary variable
15542 that is the argument of New.
15545 2001-12-23 Ravi Pratap <ravi@ximian.com>
15547 * rootcontext.cs (LookupType): Check that current_type is not null before
15548 going about looking at nested types.
15550 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
15551 not implement the IAssignMethod interface any more.
15553 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
15554 where we tranform them into FieldExprs if they are being resolved from within
15555 the declaring type.
15557 * ecore.cs (SimpleName.DoResolve): Do the same here.
15559 * assign.cs (DoResolve, Emit): Clean up code considerably.
15561 * ../errors/bug10.cs : Add.
15563 * ../errors/cs0070.cs : Add.
15565 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
15567 * assign.cs : Get rid of EventIsLocal everywhere.
15569 2001-12-23 Miguel de Icaza <miguel@ximian.com>
15571 * ecore.cs (ConvertIntLiteral): finished the implementation.
15573 * statement.cs (SwitchLabel): Convert the value we are using as a
15574 key before looking up the table.
15576 2001-12-22 Miguel de Icaza <miguel@ximian.com>
15578 * codegen.cs (EmitTopBlock): Require a Location argument now.
15580 * cs-parser.jay (constructor_declarator): We need to setup
15581 current_local_parameters before we parse the
15582 opt_constructor_initializer, to allow the variables to be bound
15583 to the constructor arguments.
15585 * rootcontext.cs (LookupType): First lookup nested classes in our
15586 class and our parents before we go looking outside our class.
15588 * expression.cs (ConstantFold): Extract/debox the values at the
15591 * rootcontext.cs (EmitCode): Resolve the constants first before we
15592 resolve the types. This is not really needed, but it helps debugging.
15594 * statement.cs: report location.
15596 * cs-parser.jay: pass location to throw statement.
15598 * driver.cs: Small bug fix.
15600 * report.cs: Updated format to be 4-zero filled digits.
15602 2001-12-22 Ravi Pratap <ravi@ximian.com>
15604 * expression.cs (CheckIndices): Fix minor bug where the wrong
15605 variable was being referred to ;-)
15607 (DoEmit): Do not call EmitStaticInitializers when the
15608 underlying type is System.Object.
15610 2001-12-21 Ravi Pratap <ravi@ximian.com>
15612 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
15613 and do the usual workaround for SRE.
15615 * class.cs (MyEventBuilder.EventType): New member to get at the type
15616 of the event, quickly.
15618 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
15620 * assign.cs (Assign.DoResolve): Handle the case when the target
15621 is an EventExpr and perform the necessary checks.
15623 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
15626 (SimpleName.MemberStaticCheck): Include check for EventExpr.
15628 (EventExpr): Set the type in the constructor itself since we
15629 are meant to be born fully resolved.
15631 (EventExpr.Define): Revert code I wrote earlier.
15633 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
15634 instance expression is null. The instance expression is a This in that case
15635 or a null, depending on whether it is a static method or not.
15637 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
15638 refers to more than one method.
15640 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
15641 and accordingly flag errors.
15643 2001-12-21 Miguel de Icaza <miguel@ximian.com>
15645 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
15647 2001-12-22 Miguel de Icaza <miguel@ximian.com>
15649 * location.cs (ToString): Provide useful rutine.
15651 2001-12-21 Miguel de Icaza <miguel@ximian.com>
15653 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
15654 objects, return the actual integral boxed.
15656 * statement.cs (SwitchLabel): define an ILLabel for each
15659 (Switch.CheckSwitch): If the value is a Literal, extract
15660 the underlying literal.
15662 Also in the unused hashtable we had, add the SwitchLabel so we can
15663 quickly look this value up.
15665 * constant.cs: Implement a bunch of new constants. Rewrite
15666 Literal based on this. Made changes everywhere to adapt to this.
15668 * expression.cs (Expression.MakeByteBlob): Optimize routine by
15669 dereferencing array only once, and also copes with enumrations.
15671 bytes are two bytes wide, not one.
15673 (Cast): Perform constant conversions.
15675 * ecore.cs (TryImplicitIntConversion): Return literals instead of
15676 wrappers to the literals here.
15678 * expression.cs (DoNumericPromotions): long literals can converted
15679 to ulong implicity (this is taken care of elsewhere, but I was
15680 missing this spot).
15682 * ecore.cs (Expression.Literalize): Make the return type Literal,
15683 to improve type checking.
15685 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
15687 2001-12-20 Miguel de Icaza <miguel@ximian.com>
15689 * literal.cs: Revert code from ravi that checked the bounds. The
15690 bounds are sane by the definition of the type itself.
15692 * typemanager.cs: Fix implementation of ImplementsInterface. We
15693 need to actually look up in our parent hierarchy for interfaces
15696 * const.cs: Use the underlying type for enumerations
15698 * delegate.cs: Compute the basename for the delegate creation,
15699 that should fix the delegate test case, and restore the correct
15700 Type Lookup semantics in rootcontext
15702 * rootcontext.cs: Revert Ravi's last patch. The correct way of
15703 referencing a nested type with the Reflection API is using the "+"
15706 * cs-parser.jay: Do not require EOF token at the end.
15708 2001-12-20 Ravi Pratap <ravi@ximian.com>
15710 * rootcontext.cs (LookupType): Concatenate type names with
15711 a '.' instead of a '+' The test suite passes again.
15713 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
15714 field of the enumeration.
15716 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
15717 the case when the member is an EventExpr.
15719 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
15720 static has an associated instance expression.
15722 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
15724 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
15726 * class.cs (Event.Define): Register event and perform appropriate checks
15729 We define the Add and Remove methods even if the use provides none because
15730 in that case, we provide default implementations ourselves.
15732 Define a private field of the type of the event. This is done by the CSC compiler
15733 and we should be doing it too ;-)
15735 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
15736 More methods we use in code we generate.
15738 (multicast_delegate_type, delegate_type): Two separate types since the distinction
15741 (InitCoreTypes): Update accordingly for the above.
15743 * class.cs (Event.Emit): Generate code for default accessors that we provide
15745 (EmitDefaultMethod): Do the job in the above.
15747 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
15750 2001-12-20 Miguel de Icaza <miguel@ximian.com>
15752 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
15753 builders even if we were missing one.
15755 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
15756 pass the Basename as our class name instead of the Name. The
15757 basename will be correctly composed for us.
15759 * parameter.cs (Paramters): Now takes a Location argument.
15761 * decl.cs (DeclSpace.LookupType): Removed convenience function and
15762 make all the code call directly LookupType in RootContext and take
15763 this chance to pass the Location information everywhere.
15765 * Everywhere: pass Location information.
15767 2001-12-19 Miguel de Icaza <miguel@ximian.com>
15769 * class.cs (Constructor.Define): Updated way of detecting the
15770 length of the parameters.
15772 (TypeContainer.DefineType): Use basename as the type name for
15775 (TypeContainer.Define): Do not recursively define types here, as
15776 definition is taken care in order by the RootContext.
15778 * tree.cs: Keep track of namespaces in a per-file basis.
15780 * parameter.cs (Parameter.ComputeSignature): Update to use
15783 (Parameters.GetSignature): ditto.
15785 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
15786 instead of a TypeContainer.
15788 (Interface.SemanticAnalysis): Use `this' instead of our parent to
15789 resolve names. Because we need to be resolve in our context, not
15792 * driver.cs: Implement response files.
15794 * class.cs (TypeContainer.DefineType): If we are defined, do not
15795 redefine ourselves.
15797 (Event.Emit): Emit the code for add/remove handlers.
15798 (Event.Define): Save the MethodBuilders for add/remove.
15800 * typemanager.cs: Use pair here too.
15802 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
15803 DictionaryEntry requires the first argument to be non-null.
15805 (enum_declaration): Compute full name for registering the
15808 (delegate_declaration): Instead of using
15809 formal_parameter_list, use opt_formal_parameter_list as the list
15812 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
15813 (EventParsing): New property that controls whether `add' and
15814 `remove' are returned as tokens or identifiers (for events);
15816 2001-12-19 Ravi Pratap <ravi@ximian.com>
15818 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
15819 use MyEventBuilder only and let it wrap the real builder for us.
15821 (MyEventBuilder): Revamp constructor etc.
15823 Implement all operations that we perform on EventBuilder in precisely the same
15826 (FindMembers): Update to use the EventBuilder member.
15828 (Event.Emit): Update accordingly.
15830 2001-12-18 Ravi Pratap <ravi@ximian.com>
15832 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
15833 by calling the appropriate methods.
15835 (GetCustomAttributes): Make stubs as they cannot possibly do anything
15838 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
15840 2001-12-17 Ravi Pratap <ravi@ximian.com>
15842 * delegate.cs (Delegate.Populate): Check that the return type
15843 and various parameters types are indeed accessible.
15845 * class.cs (Constructor.Define): Same here.
15847 (Field.Define): Ditto.
15849 (Event.Define): Ditto.
15851 (Operator.Define): Check that the underlying Method defined itself
15852 correctly - so it's MethodBuilder should not be null.
15854 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
15855 expression happens to be null.
15857 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
15858 members but as of now we don't seem to be able to do anything really useful with it.
15860 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
15861 not the EventBuilder.
15863 2001-12-18 Miguel de Icaza <miguel@ximian.com>
15865 * cs-tokenizer.cs: Add support for defines.
15866 Add support for #if, #elif, #else, #endif
15868 (eval_var): evaluates a variable.
15869 (eval): stubbed for evaluating functions.
15871 * cs-parser.jay: Pass the defines information
15873 * driver.cs: Add --define command line option.
15875 * decl.cs: Move MemberCore here.
15877 Make it the base class for DeclSpace. This allows us to catch and
15878 report 108 and 109 for everything now.
15880 * class.cs (TypeContainer.Define): Extract all the members
15881 before populating and emit the warning 108 (new keyword required
15882 to override) instead of having each member implement this.
15884 (MemberCore.Define): New abstract method, we will be using this in
15885 the warning reporting engine in Populate.
15887 (Operator.Define): Adjust to new MemberCore protocol.
15889 * const.cs (Const): This does not derive from Expression, it is a
15890 temporary object we use to create fields, it is a MemberCore.
15892 * class.cs (Method.Define): Allow the entry point to be in a
15895 * driver.cs: Rewrite the argument handler to clean it up a bit.
15897 * rootcontext.cs: Made it just an auxiliary namespace feature by
15898 making everything static.
15900 * driver.cs: Adapt code to use RootContext type name instead of
15903 * delegate.cs: Remove RootContext argument.
15905 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
15908 * class.cs (Event.Define): The lookup can fail.
15910 * cs-tokenizer.cs: Begin implementation of pre-procesor.
15912 * expression.cs: Resolve the this instance before invoking the code.
15914 2001-12-17 Miguel de Icaza <miguel@ximian.com>
15916 * cs-parser.jay: Add a production in element_access that allows
15917 the thing to become a "type" reference. This way we can parse
15918 things like "(string [])" as a type.
15920 Note that this still does not handle the more complex rules of
15924 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
15926 * ecore.cs: (CopyNewMethods): new utility function used to
15927 assemble the list of methods from running FindMembers.
15929 (MemberLookup): Rework FindMembers so that
15931 2001-12-16 Miguel de Icaza <miguel@ximian.com>
15933 * class.cs (TypeContainer): Remove Delegates who fail to be
15936 * delegate.cs (Populate): Verify that we dont get null return
15937 values. TODO: Check for AsAccessible.
15939 * cs-parser.jay: Use basename to emit error 574 (destructor should
15940 have the same name as container class), not the full name.
15942 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
15943 possible representation.
15945 Also implements integer type suffixes U and L.
15947 2001-12-15 Miguel de Icaza <miguel@ximian.com>
15949 * expression.cs (ArrayCreation.DoResolve): We need to do the
15950 argument resolution *always*.
15952 * decl.cs: Make this hold the namespace. Hold the root context as
15954 (LookupType): Move here.
15956 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
15958 * location.cs (Row, Name): Fixed the code, it was always returning
15959 references to the first file.
15961 * interface.cs: Register properties defined through interfaces.
15963 * driver.cs: Add support for globbing on the command line
15965 * class.cs (Field): Make it derive from MemberCore as well.
15968 2001-12-15 Ravi Pratap <ravi@ximian.com>
15970 * class.cs (Event::Define): Check that the type of the event is a delegate
15971 type else flag error #66.
15973 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
15976 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
15977 values of EntryPoint, CharSet etc etc.
15979 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
15981 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
15982 be null and we should ignore this. I am not sure if this is really clean. Apparently,
15983 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
15984 which needs this to do its work.
15986 * ../errors/cs0066.cs : Add.
15988 2001-12-14 Miguel de Icaza <miguel@ximian.com>
15990 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
15993 * class.cs: (MethodSignature.MethodSignature): Removed hack that
15994 clears out the parameters field.
15995 (MemberSignatureCompare): Cleanup
15997 (MemberCore): New base class used to share code between MethodCore
16000 (RegisterRequiredImplementations) BindingFlags.Public requires
16001 either BindingFlags.Instace or Static. Use instance here.
16003 (Property): Refactored code to cope better with the full spec.
16005 * parameter.cs (GetParameterInfo): Return an empty array instead
16008 * class.cs (Property): Abstract or extern properties have no bodies.
16010 * parameter.cs (GetParameterInfo): return a zero-sized array.
16012 * class.cs (TypeContainer.MethodModifiersValid): Move all the
16013 method modifier validation to the typecontainer so we can reuse
16014 this on properties.
16016 (MethodCore.ParameterTypes): return an empty sized array of types.
16018 (Property.Define): Test property modifier validity.
16020 Add tests for sealed/override too.
16022 (Method.Emit): abstract or extern methods have no bodies.
16024 2001-12-14 Ravi Pratap <ravi@ximian.com>
16026 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
16029 (Method::Define, ::Emit): Modify accordingly.
16031 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
16033 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
16035 * makefile: Pass in /unsafe.
16037 2001-12-13 Miguel de Icaza <miguel@ximian.com>
16039 * class.cs (MakeKey): Kill routine.
16041 * class.cs (TypeContainer.Define): Correctly define explicit
16042 method implementations (they require the full interface name plus
16045 * typemanager.cs: Deply the PtrHashtable here and stop using the
16046 lame keys. Things work so much better.
16048 This of course broke everyone who depended on `RegisterMethod' to
16049 do the `test for existance' test. This has to be done elsewhere.
16051 * support.cs (PtrHashtable): A hashtable that avoid comparing with
16052 the object stupid Equals method (because, that like fails all over
16053 the place). We still do not use it.
16055 * class.cs (TypeContainer.SetRequiredInterface,
16056 TypeContainer.RequireMethods): Killed these two routines and moved
16057 all the functionality to RegisterRequiredImplementations.
16059 (TypeContainer.RegisterRequiredImplementations): This routine now
16060 registers all the implementations required in an array for the
16061 interfaces and abstract methods. We use an array of structures
16062 which can be computed ahead of time to reduce memory usage and we
16063 also assume that lookups are cheap as most classes will not
16064 implement too many interfaces.
16066 We also avoid creating too many MethodSignatures.
16068 (TypeContainer.IsInterfaceMethod): Update and optionally does not
16069 clear the "pending" bit if we find that there are problems with
16072 (TypeContainer.VerifyPendingMethods): Update to report errors of
16073 methods that look like implementations but are not.
16075 (TypeContainer.Define): Add support for explicit interface method
16078 2001-12-12 Miguel de Icaza <miguel@ximian.com>
16080 * typemanager.cs: Keep track of the parameters here instead of
16081 being a feature of the TypeContainer.
16083 * class.cs: Drop the registration of parameters here, as
16084 InterfaceMethods are also interface declarations.
16086 * delegate.cs: Register methods with the TypeManager not only with
16087 the TypeContainer. This code was buggy.
16089 * interface.cs: Full registation here.
16091 2001-12-11 Miguel de Icaza <miguel@ximian.com>
16093 * expression.cs: Remove reducer for binary expressions, it can not
16096 * const.cs: Put here the code that used to go into constant.cs
16098 * constant.cs: Put here the code for constants, this is a new base
16099 class for Literals.
16101 * literal.cs: Make Literal derive from Constant.
16103 2001-12-09 Miguel de Icaza <miguel@ximian.com>
16105 * statement.cs (Return.Emit): Report error 157 if the user
16106 attempts to return from a finally block.
16108 (Return.Emit): Instead of emitting a return, jump to the end of
16111 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
16112 LocalBuilder to store the result of the function. ReturnLabel is
16113 the target where we jump.
16116 2001-12-09 Radek Doulik <rodo@ximian.com>
16118 * cs-parser.jay: remember alias in current namespace
16120 * ecore.cs (SimpleName::DoResolve): use aliases for types or
16123 * class.cs (LookupAlias): lookup alias in my_namespace
16125 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
16127 (LookupAlias): lookup alias in this and if needed in parent
16130 2001-12-08 Miguel de Icaza <miguel@ximian.com>
16134 * rootcontext.cs: (ModuleBuilder) Made static, first step into
16135 making things static. I need this to avoid passing the
16136 TypeContainer when calling ParameterType.
16138 * support.cs (InternalParameters.ParameterType): Remove ugly hack
16139 that did string manipulation to compute the type and then call
16140 GetType. Use Parameter.ParameterType instead.
16142 * cs-tokenizer.cs: Consume the suffix for floating values.
16144 * expression.cs (ParameterReference): figure out whether this is a
16145 reference parameter or not. Kill an extra variable by computing
16146 the arg_idx during emission.
16148 * parameter.cs (Parameters.GetParameterInfo): New overloaded
16149 function that returns whether a parameter is an out/ref value or not.
16151 (Parameter.ParameterType): The type of the parameter (base,
16152 without ref/out applied).
16154 (Parameter.Resolve): Perform resolution here.
16155 (Parameter.ExternalType): The full type (with ref/out applied).
16157 * statement.cs (Using.Emit, Using.EmitExpression): Implement
16158 support for expressions on the using statement.
16160 2001-12-07 Miguel de Icaza <miguel@ximian.com>
16162 * statement.cs (Using.EmitLocalVariableDecls): Split the
16163 localvariable handling of the using statement.
16165 (Block.EmitMeta): Keep track of variable count across blocks. We
16166 were reusing slots on separate branches of blocks.
16168 (Try.Emit): Emit the general code block, we were not emitting it.
16170 Check the type of the declaration to be an IDisposable or
16171 something that can be implicity converted to it.
16173 Emit conversions if required.
16175 * ecore.cs (EmptyExpression): New utility class.
16176 (Expression.ImplicitConversionExists): New utility function.
16178 2001-12-06 Miguel de Icaza <miguel@ximian.com>
16180 * statement.cs (Using): Implement.
16182 * expression.cs (LocalVariableReference): Support read only variables.
16184 * statement.cs: Remove the explicit emit for the Leave opcode.
16185 (VariableInfo): Add a readonly field.
16187 2001-12-05 Miguel de Icaza <miguel@ximian.com>
16189 * ecore.cs (ConvCast): new class used to encapsulate the various
16190 explicit integer conversions that works in both checked and
16191 unchecked contexts.
16193 (Expression.ConvertNumericExplicit): Use new ConvCast class to
16194 properly generate the overflow opcodes.
16196 2001-12-04 Miguel de Icaza <miguel@ximian.com>
16198 * statement.cs: The correct type for the EmptyExpression is the
16199 element_type, not the variable type. Ravi pointed this out.
16201 2001-12-04 Ravi Pratap <ravi@ximian.com>
16203 * class.cs (Method::Define): Handle PInvoke methods specially
16204 by using DefinePInvokeMethod instead of the usual one.
16206 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
16207 above to do the task of extracting information and defining the method.
16209 2001-12-04 Ravi Pratap <ravi@ximian.com>
16211 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
16212 of the condition for string type.
16214 (Emit): Move that here.
16216 (ArrayCreation::CheckIndices): Keep string literals in their expression
16219 (EmitDynamicInitializers): Handle strings appropriately.
16221 2001-12-04 Miguel de Icaza <miguel@ximian.com>
16223 * codegen.cs (EmitContext): Replace multiple variables with a
16224 single pointer to the current Switch statement.
16226 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
16229 2001-12-03 Miguel de Icaza <miguel@ximian.com>
16233 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
16236 (Foreach.Emit): Foreach on arrays was not setting
16237 up the loop variables (for break/continue).
16239 (GotoCase): Semi-implented.
16241 2001-12-03 Ravi Pratap <ravi@ximian.com>
16243 * attribute.cs (CheckAttribute): Handle system attributes by using
16244 Attribute.GetAttributes to examine information we need.
16246 (GetValidPlaces): Same here.
16248 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
16250 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
16252 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
16254 (Method::Define): Set appropriate flags if we have a DllImport attribute.
16256 (Method::Emit): Handle the case when we are a PInvoke method.
16258 2001-12-03 Miguel de Icaza <miguel@ximian.com>
16260 * expression.cs: Use ResolveWithSimpleName on compound names.
16262 2001-12-02 Ravi Pratap <ravi@ximian.com>
16264 * constant.cs (EmitConstant): Make sure we resolve the associated expression
16265 before trying to reduce it.
16267 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
16269 * constant.cs (LookupConstantValue): Implement.
16271 (EmitConstant): Use the above in emitting the constant.
16273 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
16274 that are user-defined by doing a LookupConstantValue on them.
16276 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
16279 2001-11-29 Miguel de Icaza <miguel@ximian.com>
16281 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
16283 (BaseAccess.DoResolve): Implement.
16285 (MemberAccess.DoResolve): Split this routine into a
16286 ResolveMemberAccess routine that can be used independently
16288 2001-11-28 Miguel de Icaza <miguel@ximian.com>
16290 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
16291 As that share bits of the implementation. Is returns a boolean,
16292 while As returns the Type that is being probed.
16294 2001-12-01 Ravi Pratap <ravi@ximian.com>
16296 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
16297 instead of a Literal - much easier.
16299 (EnumInTransit): Remove - utterly useless :-)
16301 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
16303 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
16305 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
16306 chain when we have no associated expression.
16308 2001-11-30 Ravi Pratap <ravi@ximian.com>
16310 * constant.cs (Define): Use Location while reporting the errror.
16312 Also emit a warning when 'new' is used and there is no inherited
16315 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
16318 (LookupEnumValue): Implement to lookup an enum member's value and define it
16321 (Populate): Re-write accordingly to use the above routine.
16323 2001-11-27 Miguel de Icaza <miguel@ximian.com>
16325 * expression.cs (This): Fix prototype for DoResolveLValue to
16326 override the base class DoResolveLValue.
16328 * cs-parser.cs: Report errors cs574 and cs575 (destructor
16331 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
16332 (we need to load the address of the field here). This fixes
16335 (FieldExpr.DoResolveLValue): Call the DoResolve
16336 function to initialize the Instance expression.
16338 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
16339 correctly the GetEnumerator operation on a value type.
16341 * cs-parser.jay: Add more simple parsing error catches.
16343 * statement.cs (Switch): Add support for string switches.
16344 Handle null specially.
16346 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
16348 2001-11-28 Ravi Pratap <ravi@ximian.com>
16350 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
16352 (declare_local_constant): New helper function.
16354 * statement.cs (AddConstant): Keep a separate record of constants
16356 (IsConstant): Implement to determine if a variable is a constant.
16358 (GetConstantExpression): Implement.
16360 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
16362 * statement.cs (IsVariableDefined): Re-write.
16364 2001-11-27 Ravi Pratap <ravi@ximian.com>
16366 * class.cs (TypeContainer::FindMembers): Look for constants
16367 in the case when we are looking for MemberTypes.Field
16369 * expression.cs (MemberAccess::DoResolve): Check that in the
16370 case we are a FieldExpr and a Literal, we are not being accessed
16371 by an instance reference.
16373 * cs-parser.jay (local_constant_declaration): Implement.
16375 (declaration_statement): Implement for constant declarations.
16377 2001-11-26 Miguel de Icaza <miguel@ximian.com>
16379 * statement.cs (Switch): Catch double defaults.
16381 (Switch): More work on the switch() statement
16382 implementation. It works for integral values now, need to finish
16386 2001-11-24 Miguel de Icaza <miguel@ximian.com>
16388 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
16389 integer literals into other integer literals. To be used by
16392 2001-11-24 Ravi Pratap <ravi@ximian.com>
16394 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
16397 (EmitDynamicInitializers): Cope with the above since we extract data
16398 directly from ArrayData now.
16400 (ExpectInitializers): Keep track of whether initializers are mandatory
16403 (Bounds): Make it a hashtable to prevent the same dimension being
16404 recorded for every element in that dimension.
16406 (EmitDynamicInitializers): Fix bug which prevented the Set array method
16409 Also fix bug which was causing the indices to be emitted in the reverse
16412 2001-11-24 Miguel de Icaza <miguel@ximian.com>
16414 * expression.cs (ArrayCreation): Implement the bits that Ravi left
16415 unfinished. They do not work, because the underlying code is
16418 2001-11-22 Miguel de Icaza <miguel@ximian.com>
16420 * cs-parser.jay: Remove bogus fixme.
16422 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
16423 on Switch statement.
16425 2001-11-23 Ravi Pratap <ravi@ximian.com>
16427 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
16430 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
16431 parameter. Apparently, any expression is allowed.
16433 (ValidateInitializers): Update accordingly.
16435 (CheckIndices): Fix some tricky bugs thanks to recursion.
16437 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
16438 I was being completely brain-dead.
16440 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
16441 and re-write acordingly.
16443 (DelegateInvocation): Re-write accordingly.
16445 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
16447 (MakeByteBlob): Handle types more correctly.
16449 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
16450 initialization from expressions but it is incomplete because I am a complete
16453 2001-11-22 Miguel de Icaza <miguel@ximian.com>
16455 * statement.cs (If.Emit): Fix a bug that generated incorrect code
16456 on If. Basically, we have to return `true' (ie, we do return to
16457 our caller) only if both branches of the if return.
16459 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
16460 short-circuit operators, handle them as short circuit operators.
16462 (Cast.DoResolve): Resolve type.
16463 (Cast.Cast): Take an expression as the target type.
16465 * cs-parser.jay (cast_expression): Remove old hack that only
16466 allowed a limited set of types to be handled. Now we take a
16467 unary_expression and we resolve to a type during semantic
16470 Use the grammar productions from Rhys to handle casts (this is
16471 not complete like Rhys syntax yet, we fail to handle that corner
16472 case that C# has regarding (-x), but we will get there.
16474 2001-11-22 Ravi Pratap <ravi@ximian.com>
16476 * class.cs (EmitFieldInitializer): Take care of the case when we have a
16477 field which is an array type.
16479 * cs-parser.jay (declare_local_variables): Support array initialization too.
16481 * typemanager.cs (MakeKey): Implement.
16483 (everywhere): Use the above appropriately.
16485 * cs-parser.jay (for_statement): Update for array initialization while
16486 declaring variables.
16488 * ecore.cs : The error message was correct, it's the variable's names that
16489 were misleading ;-) Make the code more readable.
16491 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
16492 the correct type etc.
16494 (ConvertExplicit): Handle Enum types by examining the underlying type.
16496 2001-11-21 Ravi Pratap <ravi@ximian.com>
16498 * parameter.cs (GetCallingConvention): Always return
16499 CallingConventions.Standard for now.
16501 2001-11-22 Miguel de Icaza <miguel@ximian.com>
16503 * expression.cs (Binary.ResolveOperator): Update the values of `l'
16504 and `r' after calling DoNumericPromotions.
16506 * ecore.cs: Fix error message (the types were in the wrong order).
16508 * statement.cs (Foreach.ProbeCollectionType): Need to pass
16509 BindingFlags.Instance as well
16511 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
16512 implicit int literal conversion in an empty cast so that we
16513 propagate the right type upstream.
16515 (UnboxCast): new class used to unbox value types.
16516 (Expression.ConvertExplicit): Add explicit type conversions done
16519 (Expression.ImplicitNumericConversion): Oops, forgot to test for
16520 the target type before applying the implicit LongLiterals to ULong
16523 2001-11-21 Miguel de Icaza <miguel@ximian.com>
16525 * cs-parser.jay (for_statement): Reworked the way For works: now
16526 we declare manually any variables that are introduced in
16527 for_initializer to solve the problem of having out-of-band code
16528 emition (that is what got for broken).
16530 (declaration_statement): Perform the actual variable declaration
16531 that used to be done in local_variable_declaration here.
16533 (local_variable_declaration): Do not declare anything, just pass
16534 the information on a DictionaryEntry
16536 2001-11-20 Ravi Pratap <ravi@ximian.com>
16538 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
16539 re-write of the logic to now make it recursive.
16541 (UpdateIndices): Re-write accordingly.
16543 Store element data in a separate ArrayData list in the above methods.
16545 (MakeByteBlob): Implement to dump the array data into a byte array.
16547 2001-11-19 Ravi Pratap <ravi@ximian.com>
16549 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
16552 * constant.cs (Define): Implement.
16554 (EmitConstant): Re-write fully.
16556 Pass in location info.
16558 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
16561 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
16562 DictionaryEntry since we need location info too.
16564 (constant_declaration): Update accordingly.
16566 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
16567 code into another method : UpdateIndices.
16569 2001-11-18 Ravi Pratap <ravi@ximian.com>
16571 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
16572 some type checking etc.
16574 2001-11-17 Ravi Pratap <ravi@ximian.com>
16576 * expression.cs (ArrayCreation::ValidateInitializers): Implement
16577 bits to provide dimension info if the user skips doing that.
16579 Update second constructor to store the rank correctly.
16581 2001-11-16 Ravi Pratap <ravi@ximian.com>
16583 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
16584 and try to implement.
16586 * ../errors/cs0150.cs : Add.
16588 * ../errors/cs0178.cs : Add.
16590 2001-11-16 Miguel de Icaza <miguel@ximian.com>
16592 * statement.cs: Implement foreach on multi-dimensional arrays.
16594 * parameter.cs (Parameters.GetParameterByName): Also lookup the
16595 name of the params argument.
16597 * expression.cs: Use EmitStoreOpcode to get the right opcode while
16598 initializing the array.
16600 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
16601 we can use this elsewhere.
16603 * statement.cs: Finish implementation of foreach for single
16606 * cs-parser.jay: Use an out-of-band stack to pass information
16607 around, I wonder why I need this.
16609 foreach_block: Make the new foreach_block the current_block.
16611 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
16612 function used to return a static Parameters structure. Used for
16613 empty parameters, as those are created very frequently.
16615 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
16617 2001-11-15 Ravi Pratap <ravi@ximian.com>
16619 * interface.cs : Default modifier is private, not public. The
16620 make verify test passes again.
16622 2001-11-15 Ravi Pratap <ravi@ximian.com>
16624 * support.cs (ReflectionParameters): Fix logic to determine
16625 whether the last parameter is a params one. Test 9 passes again.
16627 * delegate.cs (Populate): Register the builders we define with
16628 RegisterParameterForBuilder. Test 19 passes again.
16630 * cs-parser.jay (property_declaration): Reference $6 instead
16631 of $$ to get at the location.
16633 (indexer_declaration): Similar stuff.
16635 (attribute): Ditto.
16637 * class.cs (Property): Register parameters for the Get and Set methods
16638 if they exist. Test 23 passes again.
16640 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
16641 call to EmitArguments as we are sure there aren't any params arguments.
16642 Test 32 passes again.
16644 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
16645 IndexOutOfRangeException.
16647 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
16648 Test 33 now passes again.
16650 2001-11-15 Miguel de Icaza <miguel@ximian.com>
16652 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
16653 broke a bunch of things. Will have to come up with a better way
16654 of tracking locations.
16656 * statement.cs: Implemented foreach for single dimension arrays.
16658 2001-11-09 Miguel de Icaza <miguel@ximian.com>
16660 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
16661 an error. This removes the lookup from the critical path.
16663 * cs-parser.jay: Removed use of temporary_loc, which is completely
16666 2001-11-14 Miguel de Icaza <miguel@ximian.com>
16668 * support.cs (ReflectionParameters.ParameterModifier): Report
16669 whether the argument is a PARAMS argument or not.
16671 * class.cs: Set the attribute `ParamArrayAttribute' on the
16672 parameter argument.
16674 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
16675 and cons_param_array_attribute (ConstructorInfo for
16676 ParamArrayAttribute).,
16678 * codegen.cs: Emit the return using the `Return' statement, that
16679 way we can report the error correctly for missing return values.
16681 * class.cs (Method.Emit): Clean up.
16683 * expression.cs (Argument.Resolve): Take another argument: the
16684 location where this argument is used. Notice that this is not
16685 part of the "Argument" class as to reduce the size of the
16686 structure (we know the approximate location anyways).
16688 Test if the argument is a variable-reference, if not, then
16689 complain with a 206.
16691 (Argument.Emit): Emit addresses of variables.
16693 (Argument.FullDesc): Simplify.
16695 (Invocation.DoResolve): Update for Argument.Resolve.
16697 (ElementAccess.DoResolve): ditto.
16699 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
16700 method should be virtual, as this method is always virtual.
16702 (NewDelegate.DoResolve): Update for Argument.Resolve.
16704 * class.cs (ConstructorInitializer.DoResolve): ditto.
16706 * attribute.cs (Attribute.Resolve): ditto.
16708 2001-11-13 Miguel de Icaza <miguel@ximian.com>
16710 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
16712 * expression.cs (ParameterReference): Drop IStackStorage and implement
16713 IAssignMethod instead.
16715 (LocalVariableReference): ditto.
16717 * ecore.cs (FieldExpr): Drop IStackStorage and implement
16718 IAssignMethod instead.
16720 2001-11-13 Miguel de Icaza <miguel@ximian.com>
16722 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
16723 enumerations that are used in heavily used structures derive from
16724 byte in a laughable and pathetic attempt to reduce memory usage.
16725 This is the kind of pre-optimzations that you should not do at
16726 home without adult supervision.
16728 * expression.cs (UnaryMutator): New class, used to handle ++ and
16729 -- separatedly from the other unary operators. Cleans up the
16730 code, and kills the ExpressionStatement dependency in Unary.
16732 (Unary): Removed `method' and `Arguments' from this class, making
16733 it smaller, and moving it all to SimpleCall, so I can reuse this
16734 code in other locations and avoid creating a lot of transient data
16735 strucutres when not required.
16737 * cs-parser.jay: Adjust for new changes.
16739 2001-11-11 Miguel de Icaza <miguel@ximian.com>
16741 * enum.cs (Enum.Populate): If there is a failure during
16744 * cs-parser.jay (opt_enum_base): we used to catch type errors
16745 here, but this is really incorrect. The type error should be
16746 catched during semantic analysis.
16748 2001-12-11 Ravi Pratap <ravi@ximian.com>
16750 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
16751 current_local_parameters as expected since I, in my stupidity, had forgotten
16754 * attribute.cs (GetValidPlaces): Fix stupid bug.
16756 * class.cs (Method::Emit): Perform check on applicability of attributes.
16758 (Constructor::Emit): Ditto.
16760 (Field::Emit): Ditto.
16762 (Field.Location): Store location information.
16764 (Property, Event, Indexer, Operator): Ditto.
16766 * cs-parser.jay (field_declaration): Pass in location for each field.
16768 * ../errors/cs0592.cs : Add.
16770 2001-11-12 Ravi Pratap <ravi@ximian.com>
16772 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
16774 (InitCoreTypes): Update accordingly.
16776 (RegisterAttrType, LookupAttr): Implement.
16778 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
16779 info about the same.
16781 (Resolve): Update to populate the above as necessary.
16783 (Error592): Helper.
16785 (GetValidPlaces): Helper to the above.
16787 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
16789 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
16791 2001-11-12 Ravi Pratap <ravi@ximian.com>
16793 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
16795 * ../errors/cs0617.cs : Add.
16797 2001-11-11 Ravi Pratap <ravi@ximian.com>
16799 * enum.cs (Emit): Rename to Populate to be more consistent with what
16800 we expect it to do and when exactly it is called.
16802 * class.cs, rootcontext.cs : Update accordingly.
16804 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
16805 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
16807 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
16809 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
16810 of a fieldinfo using the above, when dealing with a FieldBuilder.
16812 2001-11-10 Ravi Pratap <ravi@ximian.com>
16814 * ../errors/cs0031.cs : Add.
16816 * ../errors/cs1008.cs : Add.
16818 * ../errrors/cs0543.cs : Add.
16820 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
16823 (FindMembers): Implement.
16825 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
16826 enums and delegates too.
16828 (enum_types): Rename to builder_to_enum.
16830 (delegate_types): Rename to builder_to_delegate.
16832 * delegate.cs (FindMembers): Implement.
16834 2001-11-09 Ravi Pratap <ravi@ximian.com>
16836 * typemanager.cs (IsEnumType): Implement.
16838 * enum.cs (Emit): Re-write parts to account for the underlying type
16839 better and perform checking etc.
16841 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
16842 of the underlying type.
16844 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
16847 * enum.cs (error31): Helper to report error #31.
16849 * cs-parser.jay (enum_declaration): Store location of each member too.
16851 * enum.cs (member_to_location): New hashtable.
16853 (AddEnumMember): Update location hashtable.
16855 (Emit): Use the location of each member while reporting errors.
16857 2001-11-09 Miguel de Icaza <miguel@ximian.com>
16859 * cs-parser.jay: A for_initializer if is a
16860 local_variable_declaration really ammount to have an implicit
16861 block with the variable declaration and no initializer for for.
16863 * statement.cs (For.Emit): Cope with null initializers.
16865 This fixes the infinite loop on for initializers.
16867 2001-11-08 Miguel de Icaza <miguel@ximian.com>
16869 * enum.cs: More cleanup.
16871 * ecore.cs: Remove dead code.
16873 * class.cs (Property.Emit): More simplification.
16874 (Event.Emit): ditto.
16876 Reworked to have less levels of indentation.
16878 2001-11-08 Ravi Pratap <ravi@ximian.com>
16880 * class.cs (Property): Emit attributes.
16890 * enum.cs (Emit): Ditto.
16892 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
16895 * class.cs (Field, Event, etc.): Move attribute generation into the
16896 Emit method everywhere.
16898 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
16899 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
16900 as we had no way of defining nested enums !
16902 * rootcontext.cs : Adjust code accordingly.
16904 * typemanager.cs (AddEnumType): To keep track of enum types separately.
16906 2001-11-07 Ravi Pratap <ravi@ximian.com>
16908 * expression.cs (EvalConstantExpression): Move into ecore.cs
16910 * enum.cs (Enum): Rename some members and make them public and readonly
16911 according to our convention.
16913 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
16916 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
16918 (Enum::Emit): Write a simple version for now which doesn't try to compute
16919 expressions. I shall modify this to be more robust in just a while.
16921 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
16923 (TypeContainer::CloseType): Create the Enum types too.
16925 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
16927 * expression.cs (EvalConstantExpression): Get rid of completely.
16929 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
16930 user-defined values and other cases.
16932 (IsValidEnumLiteral): Helper function.
16934 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
16935 out there in the case we had a literal FieldExpr.
16937 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
16939 (Literalize): Revamp a bit to take two arguments.
16941 (EnumLiteral): New class which derives from Literal to wrap enum literals.
16943 2001-11-06 Ravi Pratap <ravi@ximian.com>
16945 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
16947 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
16949 (Resolve): Use the above to ensure we have proper initializers.
16951 2001-11-05 Ravi Pratap <ravi@ximian.com>
16953 * expression.cs (Expression::EvalConstantExpression): New method to
16954 evaluate constant expressions.
16956 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
16958 2001-11-07 Miguel de Icaza <miguel@ximian.com>
16960 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
16963 (Binary.ResolveOperator): Handle operator != (object a, object b)
16964 and operator == (object a, object b);
16966 (Binary.DoNumericPromotions): Indicate whether the numeric
16967 promotion was possible.
16969 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
16972 Made the ArrayAccess implement interface IAssignMethod instead of
16973 IStackStore as the order in which arguments are passed reflects
16976 * assign.cs: Instead of using expr.ExprClass to select the way of
16977 assinging, probe for the IStackStore/IAssignMethod interfaces.
16979 * typemanager.cs: Load InitializeArray definition.
16981 * rootcontext.cs (RootContext.MakeStaticData): Used to define
16982 static data that can be used to initialize arrays.
16984 2001-11-05 Miguel de Icaza <miguel@ximian.com>
16986 * expression.cs: Handle operator== and operator!= for booleans.
16988 (Conditioal.Reduce): Implement reducer for the ?: operator.
16990 (Conditional.Resolve): Implement dead code elimination.
16992 (Binary.Resolve): Catch string literals and return a new
16993 concatenated string.
16995 (Unary.Reduce): Implement reduction of unary expressions.
16997 * ecore.cs: Split out the expression core handling here.
16999 (Expression.Reduce): New method used to perform constant folding
17000 and CSE. This is needed to support constant-expressions.
17002 * statement.cs (Statement.EmitBoolExpression): Pass true and false
17003 targets, and optimize for !x.
17005 2001-11-04 Ravi Pratap <ravi@ximian.com>
17007 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
17008 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
17009 set custom atttributes.
17011 * literal.cs (Literal::GetValue): New abstract method to return the actual
17012 value of the literal, cast as an object.
17014 (*Literal): Implement GetValue method.
17016 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
17017 expressions to the arraylist but objects of type Argument.
17019 * class.cs (TypeContainer::Emit): Emit our attributes too.
17021 (Method::Emit, Constructor::Emit): Ditto.
17023 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
17024 to be ignoring earlier.
17026 2001-11-03 Ravi Pratap <ravi@ximian.com>
17028 * attribute.cs (AttributeSection::Define): Implement to do the business
17029 of constructing a CustomAttributeBuilder.
17031 (Attribute): New trivial class. Increases readability of code.
17033 * cs-parser.jay : Update accordingly.
17035 (positional_argument_list, named_argument_list, named_argument): New rules
17037 (attribute_arguments): Use the above so that we are more correct.
17039 2001-11-02 Ravi Pratap <ravi@ximian.com>
17041 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
17042 to perform all checks for a method with a params parameter.
17044 (Invocation::OverloadResolve): Update to use the above method and therefore
17045 cope correctly with params method invocations.
17047 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
17050 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
17051 constructors in our parent too because we can't afford to miss out on
17054 * attribute.cs (AttributeSection): New name for the class Attribute
17056 Other trivial changes to improve readability.
17058 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
17059 use the new class names.
17061 2001-11-01 Ravi Pratap <ravi@ximian.com>
17063 * class.cs (Method::Define): Complete definition for params types too
17065 (Indexer::Define): Ditto.
17067 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
17068 Cope everywhere with a request for info about the array parameter.
17070 2001-11-01 Ravi Pratap <ravi@ximian.com>
17072 * tree.cs (RecordNamespace): Fix up to check for the correct key.
17074 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
17075 local_variable_type to extract the string corresponding to the type.
17077 (local_variable_type): Fixup the action to use the new helper method.
17079 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
17082 * expression.cs : Clean out code which uses the above.
17084 2001-10-31 Ravi Pratap <ravi@ximian.com>
17086 * typemanager.cs (RegisterMethod): Check if we already have an existing key
17087 and bale out if necessary by returning a false.
17089 (RegisterProperty): Ditto.
17091 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
17092 and print out appropriate error messages.
17094 * interface.cs (everywhere): Ditto.
17096 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
17097 location to constructor.
17099 * class.cs (Property, Event, Indexer): Update accordingly.
17101 * ../errors/cs111.cs : Added.
17103 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
17104 of a method, as laid down by the spec.
17106 (Invocation::OverloadResolve): Use the above method.
17108 2001-10-31 Ravi Pratap <ravi@ximian.com>
17110 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
17111 now take a TypeContainer and a Parameters object.
17113 (ParameterData): Modify return type of ParameterModifier method to be
17114 Parameter.Modifier and not a string.
17116 (ReflectionParameters, InternalParameters): Update accordingly.
17118 * expression.cs (Argument::GetParameterModifier): Same here.
17120 * support.cs (InternalParameters::ParameterType): Find a better way of determining
17121 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
17122 symbol in it at all so maybe this is only for now.
17124 2001-10-30 Ravi Pratap <ravi@ximian.com>
17126 * support.cs (InternalParameters): Constructor now takes an extra argument
17127 which is the actual Parameters class.
17129 (ParameterDesc): Update to provide info on ref/out modifiers.
17131 * class.cs (everywhere): Update call to InternalParameters to pass in
17132 the second argument too.
17134 * support.cs (ParameterData): Add ParameterModifier, which is a method
17135 to return the modifier info [ref/out etc]
17137 (InternalParameters, ReflectionParameters): Implement the above.
17139 * expression.cs (Argument::ParameterModifier): Similar function to return
17140 info about the argument's modifiers.
17142 (Invocation::OverloadResolve): Update to take into account matching modifiers
17145 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
17146 a new SetFormalParameters object which we pass to InternalParameters.
17148 2001-10-30 Ravi Pratap <ravi@ximian.com>
17150 * expression.cs (NewArray): Merge into the ArrayCreation class.
17152 2001-10-29 Ravi Pratap <ravi@ximian.com>
17154 * expression.cs (NewArray): Merge classes NewBuiltinArray and
17155 NewUserdefinedArray into one as there wasn't much of a use in having
17158 * expression.cs (Argument): Change field's name to ArgType from Type.
17160 (Type): New readonly property which returns the proper type, taking into
17161 account ref/out modifiers.
17163 (everywhere): Adjust code accordingly for the above.
17165 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
17166 whether we are emitting for a ref or out parameter.
17168 * expression.cs (Argument::Emit): Use the above field to set the state.
17170 (LocalVariableReference::Emit): Update to honour the flag and emit the
17173 * parameter.cs (Attributes): Set the correct flags for ref parameters.
17175 * expression.cs (Argument::FullDesc): New function to provide a full desc.
17177 * support.cs (ParameterData): Add method ParameterDesc to the interface.
17179 (ReflectionParameters, InternalParameters): Implement the above method.
17181 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
17184 (Invocation::FullMethodDesc): Ditto.
17186 2001-10-29 Miguel de Icaza <miguel@ximian.com>
17188 * cs-parser.jay: Add extra production for the second form of array
17191 * expression.cs (ArrayCreation): Update to reflect the above
17194 * Small changes to prepare for Array initialization.
17196 2001-10-28 Miguel de Icaza <miguel@ximian.com>
17198 * typemanager.cs (ImplementsInterface): interface might be null;
17199 Deal with this problem;
17201 Also, we do store negative hits on the cache (null values), so use
17202 this instead of calling t.GetInterfaces on the type everytime.
17204 2001-10-28 Ravi Pratap <ravi@ximian.com>
17206 * typemanager.cs (IsBuiltinType): New method to help determine the same.
17208 * expression.cs (New::DoResolve): Get rid of array creation code and instead
17209 split functionality out into different classes.
17211 (New::FormArrayType): Move into NewBuiltinArray.
17213 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
17216 (NewBuiltinArray): New class to handle creation of built-in arrays.
17218 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
17219 account creation of one-dimensional arrays.
17221 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
17223 (NewUserdefinedArray::DoResolve): Implement.
17225 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
17227 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
17228 we maintain inside the TypeManager. This is necessary to perform lookups on the
17231 (LookupType): Update to perform GetType on the module builders too.
17233 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
17235 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
17237 2001-10-23 Ravi Pratap <ravi@ximian.com>
17239 * expression.cs (New::DoResolve): Implement guts of array creation.
17241 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
17243 2001-10-27 Miguel de Icaza <miguel@ximian.com>
17245 * expression.cs: Fix bug I introduced lsat night that broke
17248 (Expression.Resolve): Report a 246 error (can not resolve name)
17249 if we find a SimpleName in the stream.
17251 (Expression.ResolveLValue): Ditto.
17253 (Expression.ResolveWithSimpleName): This function is a variant of
17254 ResolveName, this one allows SimpleNames to be returned without a
17255 warning. The only consumer of SimpleNames is MemberAccess
17257 2001-10-26 Miguel de Icaza <miguel@ximian.com>
17259 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
17260 might arrive here. I have my doubts that this is correct.
17262 * statement.cs (Lock): Implement lock statement.
17264 * cs-parser.jay: Small fixes to support `lock' and `using'
17266 * cs-tokenizer.cs: Remove extra space
17268 * driver.cs: New flag --checked, allows to turn on integer math
17271 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
17272 Threading.Monitor.Exit
17274 2001-10-23 Miguel de Icaza <miguel@ximian.com>
17276 * expression.cs (IndexerAccess::DoResolveLValue): Set the
17277 Expression Class to be IndexerAccess.
17279 Notice that Indexer::DoResolve sets the eclass to Value.
17281 2001-10-22 Miguel de Icaza <miguel@ximian.com>
17283 * class.cs (TypeContainer::Emit): Emit code for indexers.
17285 * assign.cs (IAssignMethod): New interface implemented by Indexers
17286 and Properties for handling assignment.
17288 (Assign::Emit): Simplify and reuse code.
17290 * expression.cs (IndexerAccess, PropertyExpr): Implement
17291 IAssignMethod, clean up old code.
17293 2001-10-22 Ravi Pratap <ravi@ximian.com>
17295 * typemanager.cs (ImplementsInterface): New method to determine if a type
17296 implements a given interface. Provides a nice cache too.
17298 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
17301 (ConvertReferenceExplicit): Ditto.
17303 * delegate.cs (Delegate::Populate): Update to define the parameters on the
17304 various methods, with correct names etc.
17306 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
17307 Operator.UnaryNegation.
17309 * cs-parser.jay (operator_declarator): Be a little clever in the case where
17310 we have a unary plus or minus operator.
17312 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
17315 * everywhere : update accordingly.
17317 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
17320 * class.cs (Method::Define): For the case where we are implementing a method
17321 inherited from an interface, we need to set the MethodAttributes.Final flag too.
17322 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
17324 2001-10-21 Ravi Pratap <ravi@ximian.com>
17326 * interface.cs (FindMembers): Implement to work around S.R.E
17329 * typemanager.cs (IsInterfaceType): Implement.
17331 (FindMembers): Update to handle interface types too.
17333 * expression.cs (ImplicitReferenceConversion): Re-write bits which
17334 use IsAssignableFrom as that is not correct - it doesn't work.
17336 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
17337 and accordingly override EmitStatement.
17339 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
17340 using the correct logic :-)
17342 2001-10-19 Ravi Pratap <ravi@ximian.com>
17344 * ../errors/cs-11.cs : Add to demonstrate error -11
17346 2001-10-17 Miguel de Icaza <miguel@ximian.com>
17348 * assign.cs (Assign::Resolve): Resolve right hand side first, and
17349 then pass this as a hint to ResolveLValue.
17351 * expression.cs (FieldExpr): Add Location information
17353 (FieldExpr::LValueResolve): Report assignment to readonly
17356 (Expression::ExprClassFromMemberInfo): Pass location information.
17358 (Expression::ResolveLValue): Add new method that resolves an
17361 (Expression::DoResolveLValue): Default invocation calls
17364 (Indexers): New class used to keep track of indexers in a given
17367 (IStackStore): Renamed from LValue, as it did not really describe
17368 what this did. Also ResolveLValue is gone from this interface and
17369 now is part of Expression.
17371 (ElementAccess): Depending on the element access type
17373 * typemanager.cs: Add `indexer_name_type' as a Core type
17374 (System.Runtime.CompilerServices.IndexerNameAttribute)
17376 * statement.cs (Goto): Take a location.
17378 2001-10-18 Ravi Pratap <ravi@ximian.com>
17380 * delegate.cs (Delegate::VerifyDelegate): New method to verify
17381 if two delegates are compatible.
17383 (NewDelegate::DoResolve): Update to take care of the case when
17384 we instantiate a delegate from another delegate.
17386 * typemanager.cs (FindMembers): Don't even try to look up members
17387 of Delegate types for now.
17389 2001-10-18 Ravi Pratap <ravi@ximian.com>
17391 * delegate.cs (NewDelegate): New class to take care of delegate
17394 * expression.cs (New): Split the delegate related code out into
17395 the NewDelegate class.
17397 * delegate.cs (DelegateInvocation): New class to handle delegate
17400 * expression.cs (Invocation): Split out delegate related code into
17401 the DelegateInvocation class.
17403 2001-10-17 Ravi Pratap <ravi@ximian.com>
17405 * expression.cs (New::DoResolve): Implement delegate creation fully
17406 and according to the spec.
17408 (New::DoEmit): Update to handle delegates differently.
17410 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
17411 because of which we were printing out arguments in reverse order !
17413 * delegate.cs (VerifyMethod): Implement to check if the given method
17414 matches the delegate.
17416 (FullDelegateDesc): Implement.
17418 (VerifyApplicability): Implement.
17420 * expression.cs (Invocation::DoResolve): Update to accordingly handle
17421 delegate invocations too.
17423 (Invocation::Emit): Ditto.
17425 * ../errors/cs1593.cs : Added.
17427 * ../errors/cs1594.cs : Added.
17429 * delegate.cs (InstanceExpression, TargetMethod): New properties.
17431 2001-10-16 Ravi Pratap <ravi@ximian.com>
17433 * typemanager.cs (intptr_type): Core type for System.IntPtr
17435 (InitCoreTypes): Update for the same.
17437 (iasyncresult_type, asynccallback_type): Ditto.
17439 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
17442 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
17445 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
17446 the builders for the 4 members of a delegate type :-)
17448 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
17451 * expression.cs (New::DoResolve): Implement guts for delegate creation.
17453 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
17455 2001-10-15 Miguel de Icaza <miguel@ximian.com>
17457 * statement.cs (Break::Emit): Implement.
17458 (Continue::Emit): Implement.
17460 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
17461 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
17462 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
17463 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
17466 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
17467 properties that track the label for the current loop (begin of the
17468 loop and end of the loop).
17470 2001-10-15 Ravi Pratap <ravi@ximian.com>
17472 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
17473 use of emitting anything at all.
17475 * class.cs, rootcontext.cs : Get rid of calls to the same.
17477 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
17479 (Populate): Define the constructor correctly and set the implementation
17482 * typemanager.cs (delegate_types): New hashtable to hold delegates that
17485 (AddDelegateType): Implement.
17487 (IsDelegateType): Implement helper method.
17489 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
17491 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
17492 and accordingly handle it.
17494 * delegate.cs (Populate): Take TypeContainer argument.
17495 Implement bits to define the Invoke method. However, I still haven't figured out
17496 how to take care of the native int bit :-(
17498 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
17499 Qualify the name of the delegate, not its return type !
17501 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
17504 (StandardConversionExists): Checking for array types turns out to be recursive.
17506 (ConvertReferenceExplicit): Implement array conversion.
17508 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
17510 2001-10-12 Ravi Pratap <ravi@ximian.com>
17512 * cs-parser.jay (delegate_declaration): Store the fully qualified
17513 name as it is a type declaration.
17515 * delegate.cs (ReturnType, Name): Rename members to these. Make them
17518 (DefineDelegate): Renamed from Define. Does the same thing essentially,
17519 as TypeContainer::DefineType.
17521 (Populate): Method in which all the definition of the various methods (Invoke)
17524 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
17527 (CloseDelegate): Finally creates the delegate.
17529 * class.cs (TypeContainer::DefineType): Update to define delegates.
17530 (Populate, Emit and CloseType): Do the same thing here too.
17532 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
17533 delegates in all these operations.
17535 2001-10-14 Miguel de Icaza <miguel@ximian.com>
17537 * expression.cs: LocalTemporary: a new expression used to
17538 reference a temporary that has been created.
17540 * assign.cs: Handle PropertyAccess back here, so that we can
17541 provide the proper semantic access to properties.
17543 * expression.cs (Expression::ConvertReferenceExplicit): Implement
17544 a few more explicit conversions.
17546 * modifiers.cs: `NEW' modifier maps to HideBySig.
17548 * expression.cs (PropertyExpr): Make this into an
17549 ExpressionStatement, and support the EmitStatement code path.
17551 Perform get/set error checking, clean up the interface.
17553 * assign.cs: recognize PropertyExprs as targets, and if so, turn
17554 them into toplevel access objects.
17556 2001-10-12 Miguel de Icaza <miguel@ximian.com>
17558 * expression.cs: PropertyExpr::PropertyExpr: use work around the
17561 * typemanager.cs: Keep track here of our PropertyBuilders again to
17562 work around lameness in SRE.
17564 2001-10-11 Miguel de Icaza <miguel@ximian.com>
17566 * expression.cs (LValue::LValueResolve): New method in the
17567 interface, used to perform a second resolution pass for LValues.
17569 (This::DoResolve): Catch the use of this in static methods.
17571 (This::LValueResolve): Implement.
17573 (This::Store): Remove warning, assigning to `this' in structures
17576 (Invocation::Emit): Deal with invocation of
17577 methods on value types. We need to pass the address to structure
17578 methods rather than the object itself. (The equivalent code to
17579 emit "this" for structures leaves the entire structure on the
17580 stack instead of a pointer to it).
17582 (ParameterReference::DoResolve): Compute the real index for the
17583 argument based on whether the method takes or not a `this' pointer
17584 (ie, the method is static).
17586 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
17587 value types returned from functions when we need to invoke a
17588 method on the sturcture.
17591 2001-10-11 Ravi Pratap <ravi@ximian.com>
17593 * class.cs (TypeContainer::DefineType): Method to actually do the business of
17594 defining the type in the Modulebuilder or Typebuilder. This is to take
17595 care of nested types which need to be defined on the TypeBuilder using
17596 DefineNestedMethod.
17598 (TypeContainer::GetClassBases): Implement. Essentially the code from the
17599 methods in RootContext, only ported to be part of TypeContainer.
17601 (TypeContainer::GetInterfaceOrClass): Ditto.
17603 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
17605 * interface.cs (Interface::DefineInterface): New method. Does exactly
17606 what RootContext.CreateInterface did earlier, only it takes care of nested types
17609 (Interface::GetInterfaces): Move from RootContext here and port.
17611 (Interface::GetInterfaceByName): Same here.
17613 * rootcontext.cs (ResolveTree): Re-write.
17615 (PopulateTypes): Re-write.
17617 * class.cs (TypeContainer::Populate): Populate nested types too.
17618 (TypeContainer::Emit): Emit nested members too.
17620 * typemanager.cs (AddUserType): Do not make use of the FullName property,
17621 instead just use the name argument passed in as it is already fully
17624 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
17625 to TypeContainer mapping to see if a type is user-defined.
17627 * class.cs (TypeContainer::CloseType): Implement.
17629 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
17630 the default constructor.
17632 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
17635 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
17637 * interface.cs (CloseType): Create the type here.
17639 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
17642 Remove all the methods which are now in TypeContainer.
17644 2001-10-10 Ravi Pratap <ravi@ximian.com>
17646 * delegate.cs (Define): Re-write bits to define the delegate
17649 2001-10-10 Miguel de Icaza <miguel@ximian.com>
17651 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
17653 * expression.cs (ImplicitReferenceConversion): handle null as well
17654 as a source to convert to any reference type.
17656 * statement.cs (Return): Perform any implicit conversions to
17657 expected return type.
17659 Validate use of return statement.
17661 * codegen.cs (EmitContext): Pass the expected return type here.
17663 * class.cs (Method, Constructor, Property): Pass expected return
17664 type to EmitContext.
17666 2001-10-09 Miguel de Icaza <miguel@ximian.com>
17668 * expression.cs: Make DoResolve take an EmitContext instead of a
17671 Replaced `l' and `location' for `loc', for consistency.
17673 (Error, Warning): Remove unneeded Tc argument.
17675 * assign.cs, literal.cs, constant.cs: Update to new calling
17678 * codegen.cs: EmitContext now contains a flag indicating whether
17679 code is being generated in a static method or not.
17681 * cs-parser.jay: DecomposeQI, new function that replaces the old
17682 QualifiedIdentifier. Now we always decompose the assembled
17683 strings from qualified_identifier productions into a group of
17686 2001-10-08 Miguel de Icaza <miguel@ximian.com>
17688 * rootcontext.cs: Deal with field-less struct types correctly now
17689 by passing the size option to Define Type.
17691 * class.cs: Removed hack that created one static field.
17693 2001-10-07 Miguel de Icaza <miguel@ximian.com>
17695 * statement.cs: Moved most of the code generation here.
17697 2001-10-09 Ravi Pratap <ravi@ximian.com>
17699 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
17702 (ElementAccess): Remove useless bits for now - keep checks as the spec
17705 2001-10-08 Ravi Pratap <ravi@ximian.com>
17707 * expression.cs (ElementAccess::DoResolve): Remove my crap code
17708 and start performing checks according to the spec.
17710 2001-10-07 Ravi Pratap <ravi@ximian.com>
17712 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
17713 rank_specifiers instead.
17715 (rank_specifiers): Change the order in which the rank specifiers are stored
17717 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
17719 * expression.cs (ElementAccess): Implement the LValue interface too.
17721 2001-10-06 Ravi Pratap <ravi@ximian.com>
17723 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
17724 except that user defined conversions are not included.
17726 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
17727 perform the conversion of the return type, if necessary.
17729 (New::DoResolve): Check whether we are creating an array or an object
17730 and accordingly do the needful.
17732 (New::Emit): Same here.
17734 (New::DoResolve): Implement guts of array creation.
17736 (New::FormLookupType): Helper function.
17738 2001-10-07 Miguel de Icaza <miguel@ximian.com>
17740 * codegen.cs: Removed most of the code generation here, and move the
17741 corresponding code generation bits to the statement classes.
17743 Added support for try/catch/finalize and throw.
17745 * cs-parser.jay: Added support for try/catch/finalize.
17747 * class.cs: Catch static methods having the flags override,
17748 virtual or abstract.
17750 * expression.cs (UserCast): This user cast was not really doing
17751 what it was supposed to do. Which is to be born in fully resolved
17752 state. Parts of the resolution were being performed at Emit time!
17756 2001-10-05 Miguel de Icaza <miguel@ximian.com>
17758 * expression.cs: Implicity convert the result from UserCast.
17760 2001-10-05 Ravi Pratap <ravi@ximian.com>
17762 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
17763 prevented it from working correctly.
17765 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
17766 merely ConvertImplicit.
17768 2001-10-05 Miguel de Icaza <miguel@ximian.com>
17770 * typemanager.cs: Make the LookupTypeContainer function static,
17771 and not per-instance.
17773 * class.cs: Make static FindMembers (the one that takes a Type
17776 * codegen.cs: Add EmitForeach here.
17778 * cs-parser.jay: Make foreach a toplevel object instead of the
17779 inline expansion, as we need to perform semantic analysis on it.
17781 2001-10-05 Ravi Pratap <ravi@ximian.com>
17783 * expression.cs (Expression::ImplicitUserConversion): Rename to
17784 UserDefinedConversion.
17786 (Expression::UserDefinedConversion): Take an extra argument specifying
17787 whether we look for explicit user conversions too.
17789 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
17791 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
17793 (ExplicitUserConversion): Make it a call to UserDefinedConversion
17794 with the appropriate arguments.
17796 * cs-parser.jay (cast_expression): Record location too.
17798 * expression.cs (Cast): Record location info.
17800 (Expression::ConvertExplicit): Take location argument.
17802 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
17803 to determine if we are doing explicit conversions.
17805 (UserCast::Emit): Update accordingly.
17807 (Expression::ConvertExplicit): Report an error if everything fails.
17809 * ../errors/cs0030.cs : Add.
17811 2001-10-04 Miguel de Icaza <miguel@ximian.com>
17813 * modifiers.cs: If the ABSTRACT keyword is present, also set the
17814 virtual and newslot bits.
17816 * class.cs (TypeContainer::RegisterRequiredImplementations):
17817 Record methods we need.
17819 (TypeContainer::MakeKey): Helper function to make keys for
17820 MethodBases, since the Methodbase key is useless.
17822 (TypeContainer::Populate): Call RegisterRequiredImplementations
17823 before defining the methods.
17825 Create a mapping for method_builders_to_methods ahead of time
17826 instead of inside a tight loop.
17828 (::RequireMethods): Accept an object as the data to set into the
17829 hashtable so we can report interface vs abstract method mismatch.
17831 2001-10-03 Miguel de Icaza <miguel@ximian.com>
17833 * report.cs: Make all of it static.
17835 * rootcontext.cs: Drop object_type and value_type computations, as
17836 we have those in the TypeManager anyways.
17838 Drop report instance variable too, now it is a global.
17840 * driver.cs: Use try/catch on command line handling.
17842 Add --probe option to debug the error reporting system with a test
17845 * report.cs: Add support for exiting program when a probe
17846 condition is reached.
17848 2001-10-03 Ravi Pratap <ravi@ximian.com>
17850 * expression.cs (Binary::DoNumericPromotions): Fix the case when
17851 we do a forcible conversion regardless of type, to check if
17852 ForceConversion returns a null.
17854 (Binary::error19): Use location to report error.
17856 (Unary::error23): Use location here too.
17858 * ../errors/cs0019.cs : Check in.
17860 * ../errors/cs0023.cs : Check in.
17862 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
17863 case of a non-null MethodInfo object with a length of 0 !
17865 (Binary::ResolveOperator): Flag error if overload resolution fails to find
17866 an applicable member - according to the spec :-)
17867 Also fix logic to find members in base types.
17869 (Unary::ResolveOperator): Same here.
17871 (Unary::report23): Change name to error23 and make first argument a TypeContainer
17872 as I was getting thoroughly confused between this and error19 :-)
17874 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
17875 (::FindMostEncompassedType): Implement.
17876 (::FindMostEncompassingType): Implement.
17877 (::StandardConversionExists): Implement.
17879 (UserImplicitCast): Re-vamp. We now need info about most specific
17880 source and target types so that we can do the necessary conversions.
17882 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
17883 mathematical union with no duplicates.
17885 2001-10-03 Miguel de Icaza <miguel@ximian.com>
17887 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
17888 in order from base classes to child classes, so that we can in
17889 child classes look up in our parent for method names and
17890 attributes (required for handling abstract, virtual, new, override
17891 constructs: we need to instrospect our base class, and if we dont
17892 populate the classes in order, the introspection might be
17893 incorrect. For example, a method could query its parent before
17894 the parent has any methods and would determine that the parent has
17895 no abstract methods (while it could have had them)).
17897 (RootContext::CreateType): Record the order in which we define the
17900 2001-10-02 Miguel de Icaza <miguel@ximian.com>
17902 * class.cs (TypeContainer::Populate): Also method definitions can
17903 fail now, keep track of this.
17905 (TypeContainer::FindMembers): Implement support for
17906 DeclaredOnly/noDeclaredOnly flag.
17908 (Constructor::Emit) Return the ConstructorBuilder.
17910 (Method::Emit) Return the MethodBuilder.
17911 Check for abstract or virtual methods to be public.
17913 * rootcontext.cs (RootContext::CreateType): Register all the
17914 abstract methods required for the class to be complete and the
17915 interface methods that must be implemented.
17917 * cs-parser.jay: Report error 501 (method requires body if it is
17918 not marked abstract or extern).
17920 * expression.cs (TypeOf::Emit): Implement.
17922 * typemanager.cs: runtime_handle_type, new global type.
17924 * class.cs (Property::Emit): Generate code for properties.
17926 2001-10-02 Ravi Pratap <ravi@ximian.com>
17928 * expression.cs (Unary::ResolveOperator): Find operators on base type
17929 too - we now conform exactly to the spec.
17931 (Binary::ResolveOperator): Same here.
17933 * class.cs (Operator::Define): Fix minor quirk in the tests.
17935 * ../errors/cs0215.cs : Added.
17937 * ../errors/cs0556.cs : Added.
17939 * ../errors/cs0555.cs : Added.
17941 2001-10-01 Miguel de Icaza <miguel@ximian.com>
17943 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
17944 single integer which is really efficient
17946 2001-10-01 Ravi Pratap <ravi@ximian.com>
17948 * expression.cs (Expression::ImplicitUserConversion): Use location
17949 even in the case when we are examining True operators.
17951 * class.cs (Operator::Define): Perform extensive checks to conform
17952 with the rules for operator overloading in the spec.
17954 * expression.cs (Expression::ImplicitReferenceConversion): Implement
17955 some of the other conversions mentioned in the spec.
17957 * typemanager.cs (array_type): New static member for the System.Array built-in
17960 (cloneable_interface): For System.ICloneable interface.
17962 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
17963 we start resolving the tree and populating types.
17965 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
17967 2001-10-01 Miguel de Icaza <miguel@ximian.com>
17969 * expression.cs (Expression::ExprClassFromMemberInfo,
17970 Expression::Literalize): Create literal expressions from
17971 FieldInfos which are literals.
17973 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
17974 type casts, because they were wrong. The test suite in tests
17977 (ImplicitNumericConversion): ushort to ulong requires a widening
17980 Int32 constant to long requires widening cast as well.
17982 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
17983 for integers because the type on the stack is not i4.
17985 2001-09-30 Miguel de Icaza <miguel@ximian.com>
17987 * expression.cs (report118): require location argument.
17989 * parameter.cs: Do not dereference potential null value.
17991 * class.cs: Catch methods that lack the `new' keyword when
17992 overriding a name. Report warnings when `new' is used without
17993 anything being there to override.
17995 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
17997 * class.cs: Only add constructor to hashtable if it is non-null
17998 (as now constructors can fail on define).
18000 (TypeManager, Class, Struct): Take location arguments.
18002 Catch field instance initialization in structs as errors.
18004 accepting_filter: a new filter for FindMembers that is static so
18005 that we dont create an instance per invocation.
18007 (Constructor::Define): Catch errors where a struct constructor is
18010 * cs-parser.jay: Pass location information for various new
18013 * delegate.cs (Delegate): take a location argument.
18015 * driver.cs: Do not call EmitCode if there were problesm in the
18016 Definition of the types, as many Builders wont be there.
18018 * decl.cs (Decl::Decl): Require a location argument.
18020 * cs-tokenizer.cs: Handle properly hex constants that can not fit
18021 into integers, and find the most appropiate integer for it.
18023 * literal.cs: Implement ULongLiteral.
18025 * rootcontext.cs: Provide better information about the location of
18026 failure when CreateType fails.
18028 2001-09-29 Miguel de Icaza <miguel@ximian.com>
18030 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
18033 * expression.cs (Binary::CheckShiftArguments): Add missing type
18035 (Binary::ResolveOperator): Add type to the logical and and logical
18036 or, Bitwise And/Or and Exclusive Or code paths, it was missing
18039 (Binary::DoNumericPromotions): In the case where either argument
18040 is ulong (and most signed types combined with ulong cause an
18041 error) perform implicit integer constant conversions as well.
18043 2001-09-28 Miguel de Icaza <miguel@ximian.com>
18045 * expression.cs (UserImplicitCast): Method should always be
18047 (Invocation::BetterConversion): Simplified test for IntLiteral.
18049 (Expression::ImplicitNumericConversion): Split this routine out.
18050 Put the code that performs implicit constant integer conversions
18053 (Expression::Resolve): Become a wrapper around DoResolve so we can
18054 check eclass and type being set after resolve.
18056 (Invocation::Badness): Remove this dead function
18058 (Binary::ResolveOperator): Do not compute the expensive argumnets
18059 unless we have a union for it.
18061 (Probe::Emit): Is needs to do an isinst and then
18062 compare against null.
18064 (::CanConvert): Added Location argument. If the Location argument
18065 is null (Location.Null), then we do not report errors. This is
18066 used by the `probe' mechanism of the Explicit conversion. We do
18067 not want to generate an error for something that the user
18068 explicitly requested to be casted. But the pipeline for an
18069 explicit cast first tests for potential implicit casts.
18071 So for now, if the Location is null, it means `Probe only' to
18072 avoid adding another argument. Might have to revise this
18075 (ClassCast): New class used to type cast objects into arbitrary
18076 classes (used in Explicit Reference Conversions).
18078 Implement `as' as well.
18080 Reverted all the patches from Ravi below: they were broken:
18082 * The use of `level' as a mechanism to stop recursive
18083 invocations is wrong. That was there just to catch the
18084 bug with a strack trace but not as a way of addressing
18087 To fix the problem we have to *understand* what is going
18088 on and the interactions and come up with a plan, not
18089 just get things going.
18091 * The use of the type conversion cache that I proposed
18092 last night had an open topic: How does this work across
18093 protection domains. A user defined conversion might not
18094 be public in the location where we are applying the
18095 conversion, a different conversion might be selected
18096 (ie, private A->B (better) but public B->A (worse),
18097 inside A, A->B applies, but outside it, B->A will
18100 * On top of that (ie, even if the above is solved),
18101 conversions in a cache need to be abstract. Ie, `To
18102 convert from an Int to a Short use an OpcodeCast', not
18103 `To convert from an Int to a Short use the OpcodeCast on
18104 the variable 5' (which is what this patch was doing).
18106 2001-09-28 Ravi Pratap <ravi@ximian.com>
18108 * expression.cs (Invocation::ConversionExists): Re-write to use
18109 the conversion cache
18111 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
18112 cache all conversions done, not just user-defined ones.
18114 (Invocation::BetterConversion): The real culprit. Use ConversionExists
18115 to determine if a conversion exists instead of acutually trying to
18116 perform the conversion. It's faster too.
18118 (Expression::ConvertExplicit): Modify to use ConversionExists to check
18119 and only then attempt the implicit conversion.
18121 2001-09-28 Ravi Pratap <ravi@ximian.com>
18123 * expression.cs (ConvertImplicit): Use a cache for conversions
18124 already found. Check level of recursion and bail out if necessary.
18126 2001-09-28 Miguel de Icaza <miguel@ximian.com>
18128 * typemanager.cs (string_concat_string_string, string_concat_object_object):
18129 Export standard methods that we expect for string operations.
18131 * statement.cs (Block::UsageWarning): Track usage of variables and
18132 report the errors for not used variables.
18134 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
18137 2001-09-27 Miguel de Icaza <miguel@ximian.com>
18139 * codegen.cs: remove unnneded code
18141 * expression.cs: Removed BuiltinTypeAccess class
18143 Fix the order in which implicit conversions are
18146 The previous fixed dropped support for boxed conversions (adding a
18147 test to the test suite now)
18149 (UserImplicitCast::CanConvert): Remove test for source being null,
18150 that code is broken. We should not feed a null to begin with, if
18151 we do, then we should track the bug where the problem originates
18152 and not try to cover it up here.
18154 Return a resolved expression of type UserImplicitCast on success
18155 rather than true/false. Ravi: this is what I was talking about,
18156 the pattern is to use a static method as a "constructor" for
18159 Also, do not create arguments until the very last minute,
18160 otherwise we always create the arguments even for lookups that
18161 will never be performed.
18163 (UserImplicitCast::Resolve): Eliminate, objects of type
18164 UserImplicitCast are born in a fully resolved state.
18166 * typemanager.cs (InitCoreTypes): Init also value_type
18167 (System.ValueType).
18169 * expression.cs (Cast::Resolve): First resolve the child expression.
18171 (LValue): Add new method AddressOf to be used by
18174 Change the argument of Store to take an EmitContext instead of an
18175 ILGenerator, because things like FieldExpr need to be able to call
18176 their children expression to generate the instance code.
18178 (Expression::Error, Expression::Warning): Sugar functions for
18181 (Expression::MemberLookup): Accept a TypeContainer instead of a
18182 Report as the first argument.
18184 (Expression::ResolvePrimary): Killed. I still want to improve
18185 this as currently the code is just not right.
18187 (Expression::ResolveMemberAccess): Simplify, but it is still
18190 (Unary::Resolve): Catch errors in AddressOf operators.
18192 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
18193 index to a byte for the short-version, or the compiler will choose
18194 the wrong Emit call, which generates the wrong data.
18196 (ParameterReference::Emit, ::Store): same.
18198 (FieldExpr::AddressOf): Implement.
18200 * typemanager.cs: TypeManager: made public variable instead of
18203 * driver.cs: document --fatal.
18205 * report.cs (ErrorMessage, WarningMessage): new names for the old
18206 Error and Warning classes.
18208 * cs-parser.jay (member_access): Turn built-in access to types
18209 into a normal simplename
18211 2001-09-27 Ravi Pratap <ravi@ximian.com>
18213 * expression.cs (Invocation::BetterConversion): Fix to cope
18214 with q being null, since this was introducing a bug.
18216 * expression.cs (ConvertImplicit): Do built-in conversions first.
18218 2001-09-27 Ravi Pratap <ravi@ximian.com>
18220 * expression.cs (UserImplicitCast::Resolve): Fix bug.
18222 2001-09-27 Ravi Pratap <ravi@ximian.com>
18224 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
18225 I had introduced long ago (what's new ?).
18227 * expression.cs (UserImplicitCast::CanConvert): Static method to do
18228 the work of all the checking.
18229 (ConvertImplicit): Call CanConvert and only then create object if necessary.
18230 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
18232 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
18233 that is the right way.
18235 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
18236 overloading resolution. Use everywhere instead of cutting and pasting code.
18238 (Binary::ResolveOperator): Use MakeUnionSet.
18240 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
18241 we have to convert to bool types. Not complete yet.
18243 2001-09-27 Miguel de Icaza <miguel@ximian.com>
18245 * typemanager.cs (TypeManager::CSharpName): support ushort.
18247 * expression.cs (Expression::TryImplicitIntConversion): Attempts
18248 to provide an expression that performsn an implicit constant int
18249 conversion (section 6.1.6).
18250 (Expression::ConvertImplicitRequired): Reworked to include
18251 implicit constant expression conversions.
18253 (Expression::ConvertNumericExplicit): Finished.
18255 (Invocation::Emit): If InstanceExpression is null, then it means
18256 that we perform a call on this.
18258 2001-09-26 Miguel de Icaza <miguel@ximian.com>
18260 * expression.cs (Unary::Emit): Remove some dead code.
18261 (Probe): Implement Resolve and Emit for `is'.
18262 (Expression::ConvertImplicitRequired): Attempt to do constant
18263 expression conversions here. Maybe should be moved to
18264 ConvertImplicit, but I am not sure.
18265 (Expression::ImplicitLongConstantConversionPossible,
18266 Expression::ImplicitIntConstantConversionPossible): New functions
18267 that tell whether is it possible to apply an implicit constant
18268 expression conversion.
18270 (ConvertNumericExplicit): Started work on explicit numeric
18273 * cs-parser.jay: Update operator constants.
18275 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
18276 (Parameters::GetSignature): Hook up VerifyArgs here.
18277 (Parameters::VerifyArgs): Verifies that no two arguments have the
18280 * class.cs (Operator): Update the operator names to reflect the
18281 ones that the spec expects (as we are just stringizing the
18284 * expression.cs (Unary::ResolveOperator): Fix bug: Use
18285 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
18286 previous usage did only work for our methods.
18287 (Expression::ConvertImplicit): Handle decimal implicit numeric
18288 conversions as well.
18289 (Expression::InternalTypeConstructor): Used to invoke constructors
18290 on internal types for default promotions.
18292 (Unary::Emit): Implement special handling for the pre/post
18293 increment/decrement for overloaded operators, as they need to have
18294 the same semantics as the other operators.
18296 (Binary::ResolveOperator): ditto.
18297 (Invocation::ConversionExists): ditto.
18298 (UserImplicitCast::Resolve): ditto.
18300 2001-09-26 Ravi Pratap <ravi@ximian.com>
18302 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
18303 operator, return after emitting body. Regression tests pass again !
18305 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
18306 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
18307 (Invocation::OverloadResolve): Ditto.
18308 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
18310 * everywhere : update calls to the above methods accordingly.
18312 2001-09-26 Miguel de Icaza <miguel@ximian.com>
18314 * assign.cs (Assign): Make it inherit from ExpressionStatement.
18316 * expression.cs (ExpressionStatement): New base class used for
18317 expressions that can appear in statements, so that we can provide
18318 an alternate path to generate expression that do not leave a value
18321 (Expression::Emit, and all the derivatives): We no longer return
18322 whether a value is left on the stack or not. Every expression
18323 after being emitted leaves a single value on the stack.
18325 * codegen.cs (EmitContext::EmitStatementExpression): Use the
18326 facilties of ExpressionStatement if possible.
18328 * cs-parser.jay: Update statement_expression.
18330 2001-09-25 Miguel de Icaza <miguel@ximian.com>
18332 * driver.cs: Change the wording of message
18334 2001-09-25 Ravi Pratap <ravi@ximian.com>
18336 * expression.cs (Binary::ResolveOperator): Had forgottten to set
18337 the type of the expression to the return type of the method if
18338 we have an overloaded operator match ! The regression tests pass again !
18339 (Unary::ResolveOperator): Ditto.
18341 * expression.cs (Invocation::ConversionExists): Correct the member lookup
18342 to find "op_Implicit", not "implicit" ;-)
18343 (UserImplicitCast): New class to take care of user-defined implicit conversions.
18344 (ConvertImplicit, ForceConversion): Take TypeContainer argument
18346 * everywhere : Correct calls to the above accordingly.
18348 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
18349 (ConvertImplicit): Do user-defined conversion if it exists.
18351 2001-09-24 Miguel de Icaza <miguel@ximian.com>
18353 * assign.cs: track location.
18354 (Resolve): Use implicit conversions on assignment.
18356 * literal.cs: Oops. Not good, Emit of short access values should
18357 pass (Bytes) or the wrong argument will be selected.
18359 * expression.cs (Unary::Emit): Emit code for -expr.
18361 (Unary::ResolveOperator): Handle `Substract' for non-constants
18362 (substract from zero from the non-constants).
18363 Deal with Doubles as well.
18365 (Expression::ConvertImplicitRequired): New routine that reports an
18366 error if no implicit conversion exists.
18368 (Invocation::OverloadResolve): Store the converted implicit
18369 expressions if we make them
18371 2001-09-24 Ravi Pratap <ravi@ximian.com>
18373 * class.cs (ConstructorInitializer): Take a Location argument.
18374 (ConstructorBaseInitializer): Same here.
18375 (ConstructorThisInitializer): Same here.
18377 * cs-parser.jay : Update all calls accordingly.
18379 * expression.cs (Unary, Binary, New): Take location argument.
18380 Update accordingly everywhere.
18382 * cs-parser.jay : Update all calls to the above to take a location
18385 * class.cs : Ditto.
18387 2001-09-24 Ravi Pratap <ravi@ximian.com>
18389 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
18390 (Invocation::BetterConversion): Same here
18391 (Invocation::ConversionExists): Ditto.
18393 (Invocation::ConversionExists): Implement.
18395 2001-09-22 Ravi Pratap <ravi@ximian.com>
18397 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
18398 Also take an additional TypeContainer argument.
18400 * All over : Pass in TypeContainer as argument to OverloadResolve.
18402 * typemanager.cs (CSharpName): Update to check for the string type and return
18405 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
18408 2001-09-21 Ravi Pratap <ravi@ximian.com>
18410 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
18411 (Invocation::BetterFunction): Implement.
18412 (Invocation::BetterConversion): Implement.
18413 (Invocation::ConversionExists): Skeleton, no implementation yet.
18415 Okay, things work fine !
18417 2001-09-21 Miguel de Icaza <miguel@ximian.com>
18419 * typemanager.cs: declare and load enum_type, delegate_type and
18422 * expression.cs (Expression::Emit): Now emit returns a value that
18423 tells whether a value is left on the stack or not. This strategy
18424 might be reveted tomorrow with a mechanism that would address
18425 multiple assignments.
18426 (Expression::report118): Utility routine to report mismatches on
18429 (Unary::Report23): Report impossible type/operator combination
18432 (Unary::IsIncrementableNumber): Whether the type can be
18433 incremented or decremented with add.
18434 (Unary::ResolveOperator): Also allow enumerations to be bitwise
18436 (Unary::ResolveOperator): Implement ++, !, ~,
18438 (Invocation::Emit): Deal with new Emit convetion.
18440 * All Expression derivatives: Updated their Emit method to return
18441 whether they leave values on the stack or not.
18443 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
18444 stack for expressions that are statements.
18446 2001-09-20 Miguel de Icaza <miguel@ximian.com>
18448 * expression.cs (LValue): New interface. Must be implemented by
18450 (LocalVariableReference, ParameterReference, FieldExpr): Implement
18453 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
18454 interface for generating code, simplifies the code.
18456 2001-09-20 Ravi Pratap <ravi@ximian.com>
18458 * expression.cs (everywhere): Comment out return statements in ::Resolve
18459 methods to avoid the warnings.
18461 2001-09-20 Miguel de Icaza <miguel@ximian.com>
18463 * driver.cs (parse): Report error 2001 if we can not open the
18466 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
18469 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
18472 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
18473 otherwise nested blocks end up with the same index.
18475 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
18477 * expression.cs: Instead of having FIXMEs in the Resolve
18478 functions, throw exceptions so it is obvious that we are facing a
18481 * cs-parser.jay (invocation_expression): Pass Location information.
18483 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
18484 Use a basename for those routines because .NET does not like paths
18487 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
18490 2001-09-19 Miguel de Icaza <miguel@ximian.com>
18492 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
18493 are loading the correct data types (throws an exception if not).
18494 (TypeManager::InitCoreTypes): Use CoreLookupType
18496 * expression.cs (Unary::ResolveOperator): return the child
18497 expression for expressions which are just +expr.
18498 (Unary::ResolveOperator): Return negative literals for -LITERAL
18499 expressions (otherwise they are Unary {Literal}).
18500 (Invocation::Badness): Take into account `Implicit constant
18501 expression conversions'.
18503 * literal.cs (LongLiteral): Implement long literal class.
18504 (IntLiteral): export the `Value' of the intliteral.
18506 2001-09-19 Ravi Pratap <ravi@ximian.com>
18508 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
18510 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
18511 instead of 'Operator'
18513 * expression.cs (Binary::ResolveOperator): Update accordingly.
18514 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
18517 * cs-parser.jay (unary_expression): Update to use the new names.
18519 * gen-treedump.cs (GetUnary): Same here.
18521 * expression.cs (Unary::Resolve): Implement.
18522 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
18523 operators are found instead of making noise ;-)
18524 (Unary::ResolveOperator): New method to do precisely the same thing which
18525 Binary::ResolveOperator does for Binary expressions.
18526 (Unary.method, .Arguments): Add.
18527 (Unary::OperName): Implement.
18528 (Unary::ForceConversion): Copy and Paste !
18530 * class.cs (Operator::Define): Fix a small bug for the case when we have
18533 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
18534 for the inbuilt operators. Only overloading works for now ;-)
18536 2001-09-18 Miguel de Icaza <miguel@ximian.com>
18538 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
18539 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
18541 * expression.cs (This::Emit): Implement.
18542 (This::Resolve): Implement.
18543 (TypeOf:Resolve): Implement.
18544 (Expression::ResolveSimpleName): Add an implicit this to instance
18546 (MemberAccess::Resolve): Deal with Parameters and Fields.
18547 Bind instance variable to Field expressions.
18548 (FieldExpr::Instance): New field used to track the expression that
18549 represents the object instance.
18550 (FieldExpr::Resolve): Track potential errors from MemberLookup not
18552 (FieldExpr::Emit): Implement.
18554 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
18555 the last instruction contains a return opcode to avoid generating
18556 the last `ret' instruction (this generates correct code, and it is
18557 nice to pass the peverify output).
18559 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
18560 initializer for static and instance variables.
18561 (Constructor::Emit): Allow initializer to be null in the case of
18562 static constructors. Only emit initializer for instance
18565 (TypeContainer::FindMembers): Return a null array if there are no
18568 Also fix the code for the MemberTypes.Method branch, as it was not
18569 scanning that for operators (or tried to access null variables before).
18571 * assign.cs (Assign::Emit): Handle instance and static fields.
18575 * driver.cs: Stop compilation if there are parse errors.
18577 * cs-parser.jay (constructor_declaration): Provide default base
18578 initializer for non-static constructors.
18579 (constructor_declarator): Do not provide a default base
18580 initializers if none was specified.
18581 Catch the fact that constructors should not have parameters.
18583 * class.cs: Do not emit parent class initializers for static
18584 constructors, that should be flagged as an error.
18586 2001-09-18 Ravi Pratap <ravi@ximian.com>
18588 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
18589 Move back code into TypeContainer::Populate.
18591 2001-09-18 Ravi Pratap <ravi@ximian.com>
18593 * class.cs (TypeContainer::AddConstructor): Fix the check to
18594 compare against Name, not Basename.
18595 (Operator::OpType): Change Plus and Minus to Add and Subtract.
18597 * cs-parser.jay : Update accordingly.
18599 * class.cs (TypeContainer::FindMembers): For the case where we are searching
18600 for methods, don't forget to look into the operators too.
18601 (RegisterMethodBuilder): Helper method to take care of this for
18602 methods, constructors and operators.
18603 (Operator::Define): Completely revamp.
18604 (Operator.OperatorMethod, MethodName): New fields.
18605 (TypeContainer::Populate): Move the registering of builders into
18606 RegisterMethodBuilder.
18607 (Operator::Emit): Re-write.
18609 * expression.cs (Binary::Emit): Comment out code path to emit method
18610 invocation stuff for the case when we have a user defined operator. I am
18611 just not able to get it right !
18613 2001-09-17 Miguel de Icaza <miguel@ximian.com>
18615 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
18618 (Expression::MemberLookup): Provide a version that allows to
18619 specify the MemberTypes and BindingFlags.
18621 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
18622 so it was not fetching variable information from outer blocks.
18624 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
18625 Beforefieldinit as it was buggy.
18627 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
18628 that Ravi put here.
18630 * class.cs (Constructor::Emit): Only emit if block is not null.
18631 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
18632 deal with this by semantically definining it as if the user had
18635 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
18636 constructors as we now "emit" them at a higher level.
18638 (TypeContainer::DefineDefaultConstructor): Used to define the
18639 default constructors if none was provided.
18641 (ConstructorInitializer): Add methods Resolve and Emit.
18643 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
18645 2001-09-17 Ravi Pratap <ravi@ximian.com>
18647 * class.cs (TypeContainer::EmitDefaultConstructor): Register
18648 the default constructor builder with our hashtable for methodbuilders
18651 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
18652 and argument_count is 0 in which case we have a match.
18653 (Binary::ResolveOperator): More null checking and miscellaneous coding
18656 2001-09-17 Ravi Pratap <ravi@ximian.com>
18658 * rootcontext.cs (IsNameSpace): Compare against null.
18660 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
18662 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
18663 and Unary::Operator.
18665 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
18668 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
18669 we have overloaded operators.
18670 (Binary::ResolveOperator): Implement the part which does the operator overload
18673 * class.cs (Operator::Emit): Implement.
18674 (TypeContainer::Emit): Emit the operators we have too.
18676 * expression.cs (Binary::Emit): Update to emit the appropriate code for
18677 the case when we have a user-defined operator.
18679 2001-09-17 Miguel de Icaza <miguel@ximian.com>
18681 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
18683 2001-09-16 Ravi Pratap <ravi@ximian.com>
18685 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
18686 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
18687 (Constructor::Emit): Implement.
18688 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
18689 if we have no work to do.
18690 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
18693 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
18694 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
18696 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
18699 2001-09-15 Ravi Pratap <ravi@ximian.com>
18701 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
18703 (Tree::RecordNamespace): Method to do what the name says ;-)
18704 (Tree::Namespaces): Property to get at the namespaces hashtable.
18706 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
18709 * rootcontext.cs (IsNamespace): Fixed it :-)
18711 2001-09-14 Miguel de Icaza <miguel@ximian.com>
18713 * class.cs (TypeContainer::FindMembers): Add support for
18715 (MethodCore): New class that encapsulates both the shared aspects
18716 of a Constructor and a Method.
18717 (Method, Constructor): Factored pieces into MethodCore.
18719 * driver.cs: Added --fatal which makes errors throw exceptions.
18720 Load System assembly as well as part of the standard library.
18722 * report.cs: Allow throwing exceptions on errors for debugging.
18724 * modifiers.cs: Do not use `parent', instead use the real type
18725 container to evaluate permission settings.
18727 * class.cs: Put Ravi's patch back in. He is right, and we will
18728 have to cope with the
18730 2001-09-14 Ravi Pratap <ravi@ximian.com>
18732 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
18733 FamORAssem, not FamANDAssem.
18735 2001-09-14 Miguel de Icaza <miguel@ximian.com>
18737 * driver.cs: Added --parse option that only parses its input files
18740 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
18741 incorrect. IsTopLevel is not used to tell whether an object is
18742 root_types or not (that can be achieved by testing this ==
18743 root_types). But to see if this is a top-level *class* (not
18744 necessarly our "toplevel" container).
18746 2001-09-14 Ravi Pratap <ravi@ximian.com>
18748 * enum.cs (Enum::Define): Modify to call the Lookup method on the
18749 parent instead of a direct call to GetType.
18751 2001-09-14 Ravi Pratap <ravi@ximian.com>
18753 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
18754 Modifiers.TypeAttr. This should just be a call to that method.
18756 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
18757 object so that we can determine if we are top-level or not.
18759 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
18762 * enum.cs (Enum::Define): Ditto.
18764 * modifiers.cs (FieldAttr): Re-write.
18766 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
18767 (TypeContainer::HaveStaticConstructor): New property to provide access
18768 to precisely that info.
18770 * modifiers.cs (MethodAttr): Re-write.
18771 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
18773 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
18774 of top-level types as claimed.
18776 2001-09-13 Miguel de Icaza <miguel@ximian.com>
18778 * expression.cs (MemberLookup): Fruitless attempt to lookup
18779 constructors. Maybe I need to emit default constructors? That
18780 might be it (currently .NET emits this for me automatically).
18781 (Invocation::OverloadResolve): Cope with Arguments == null.
18782 (Invocation::EmitArguments): new function, shared by the new
18783 constructor and us.
18784 (Invocation::Emit): Handle static and instance methods. Emit
18785 proper call instruction for virtual or non-virtual invocations.
18786 (New::Emit): Implement.
18787 (New::Resolve): Implement.
18788 (MemberAccess:Resolve): Implement.
18789 (MethodGroupExpr::InstanceExpression): used conforming to the spec
18790 to track instances.
18791 (FieldExpr::Resolve): Set type.
18793 * support.cs: Handle empty arguments.
18795 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
18796 SimpleLookup): Auxiliary routines to help parse a qualifier
18799 Update qualifier_identifier rule.
18801 * codegen.cs: Removed debugging messages.
18803 * class.cs: Make this a global thing, this acts just as a "key" to
18804 objects that we might have around.
18806 (Populate): Only initialize method_builders_to_methods once.
18808 * expression.cs (PropertyExpr): Initialize type from the
18811 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
18812 Resolve pattern. Attempt to implicitly convert value to boolean.
18815 * expression.cs: Set the type for the int32/int32 argument case.
18816 (Binary::ResolveOperator): Set the return type to boolean for
18817 comparission operators
18819 * typemanager.cs: Remove debugging print code.
18821 (Invocation::Resolve): resolve type.
18823 * class.cs: Allocate a MemberInfo of the correct size, as the code
18824 elsewhere depends on the test to reflect the correct contents.
18826 (Method::) Keep track of parameters, due to System.Reflection holes
18828 (TypeContainer::Populate): Keep track of MethodBuilders to Method
18831 (TypeContainer::FindMembers): Use ArrayList and then copy an array
18832 of the exact size and return that.
18834 (Class::LookupMethodByBuilder): New function that maps
18835 MethodBuilders to its methods. Required to locate the information
18836 on methods because System.Reflection bit us again.
18838 * support.cs: New file, contains an interface ParameterData and
18839 two implementations: ReflectionParameters and InternalParameters
18840 used to access Parameter information. We will need to grow this
18843 * expression.cs (Invocation::GetParameterData): implement a cache
18844 and a wrapper around the ParameterData creation for methods.
18845 (Invocation::OverloadResolve): Use new code.
18847 2001-09-13 Ravi Pratap <ravi@ximian.com>
18849 * class.cs (TypeContainer::EmitField): Remove and move into
18850 (Field::Define): here and modify accordingly.
18851 (Field.FieldBuilder): New member.
18852 (TypeContainer::Populate): Update accordingly.
18853 (TypeContainer::FindMembers): Implement.
18855 2001-09-13 Miguel de Icaza <miguel@ximian.com>
18857 * statement.cs: (VariableInfo::VariableType): New field to be
18858 initialized with the full type once it is resolved.
18860 2001-09-12 Miguel de Icaza <miguel@ximian.com>
18862 * parameter.cs (GetParameterInfo): Use a type cache to compute
18863 things only once, and to reuse this information
18865 * expression.cs (LocalVariableReference::Emit): Implement.
18866 (OpcodeCast::Emit): fix.
18868 (ParameterReference::Resolve): Implement.
18869 (ParameterReference::Emit): Implement.
18871 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
18872 that are expressions need to stay as Expressions.
18874 * typemanager.cs (CSharpName): Returns the C# name of a type if
18877 * expression.cs (Expression::ConvertImplicit): New function that
18878 implements implicit type conversions.
18880 (Expression::ImplicitReferenceConversion): Implements implicit
18881 reference conversions.
18883 (EmptyCast): New type for transparent casts.
18885 (OpcodeCast): New type for casts of types that are performed with
18886 a sequence of bytecodes.
18888 (BoxedCast): New type used for casting value types into reference
18889 types. Emits a box opcode.
18891 (Binary::DoNumericPromotions): Implements numeric promotions of
18892 and computation of the Binary::Type.
18894 (Binary::EmitBranchable): Optimization.
18896 (Binary::Emit): Implement code emission for expressions.
18898 * typemanager.cs (TypeManager): Added two new core types: sbyte
18901 2001-09-12 Ravi Pratap <ravi@ximian.com>
18903 * class.cs (TypeContainer::FindMembers): Method which does exactly
18904 what Type.FindMembers does, only we don't have to use reflection. No
18905 implementation yet.
18907 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
18908 typecontainer objects as we need to get at them.
18909 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
18911 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
18912 typecontainer object.
18914 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
18915 of just a Report object.
18917 2001-09-11 Ravi Pratap <ravi@ximian.com>
18919 * class.cs (Event::Define): Go back to using the prefixes "add_" and
18921 (TypeContainer::Populate): Now define the delegates of the type too.
18922 (TypeContainer.Delegates): Property to access the list of delegates defined
18925 * delegates.cs (Delegate::Define): Implement partially.
18927 * modifiers.cs (TypeAttr): Handle more flags.
18929 2001-09-11 Ravi Pratap <ravi@ximian.com>
18931 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
18933 (Operator::Define): Re-write logic to get types by using the LookupType method
18934 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
18935 (Indexer::Define): Ditto.
18936 (Event::Define): Ditto.
18937 (Property::Define): Ditto.
18939 2001-09-10 Ravi Pratap <ravi@ximian.com>
18941 * class.cs (TypeContainer::Populate): Now define operators too.
18942 (TypeContainer.Operators): New property to access the list of operators
18944 (Operator.OperatorMethodBuilder): New member to hold the method builder
18945 for the operator we are defining.
18946 (Operator::Define): Implement.
18948 2001-09-10 Ravi Pratap <ravi@ximian.com>
18950 * class.cs (Event::Define): Make the prefixes of the accessor methods
18951 addOn_ and removeOn_
18953 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
18954 of the location being passed in too. Ideally, this should go later since all
18955 error reporting should be done through the Report object.
18957 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
18958 (Populate): Iterate thru the indexers we have and define them too.
18959 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
18960 for the get and set accessors.
18961 (Indexer::Define): Implement.
18963 2001-09-09 Miguel de Icaza <miguel@ximian.com>
18965 * expression.cs (Binary::Resolve): Beginning of it. I scratched
18966 my previous implementation, did not work.
18968 * typemanager.cs: Add a couple of missing types (the longs).
18970 * literal.cs: Use TypeManager.bool_type instead of getting it.
18972 * expression.cs (EventExpr): New kind of expressions.
18973 (Expressio::ExprClassFromMemberInfo): finish
18975 2001-09-08 Miguel de Icaza <miguel@ximian.com>
18977 * assign.cs: Emit stores to static fields differently.
18979 2001-09-08 Ravi Pratap <ravi@ximian.com>
18981 * Merge in changes and adjust code to tackle conflicts. Backed out my
18982 code in Assign::Resolve ;-)
18984 2001-09-08 Ravi Pratap <ravi@ximian.com>
18986 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
18987 instead Report.Error and also pass in the location.
18988 (CSharpParser::Lexer): New readonly property to return the reference
18989 to the Tokenizer object.
18990 (declare_local_variables): Use Report.Error with location instead of plain
18994 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
18995 (Operator.CheckBinaryOperator): Ditto.
18997 * cs-parser.jay (operator_declarator): Update accordingly.
18999 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
19000 (CheckBinaryOperator): Same here.
19002 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
19003 on the name without any prefixes of namespace names etc. This is because we
19004 already might have something already fully qualified like
19005 'System.Console.WriteLine'
19007 * assign.cs (Resolve): Begin implementation. Stuck ;-)
19009 2001-09-07 Ravi Pratap <ravi@ximian.com>
19011 * cs-tokenizer.cs (location): Return a string which also contains
19014 * expression.cs (ElementAccess): New class for expressions of the
19015 type 'element access.'
19016 (BaseAccess): New class for expressions of the type 'base access.'
19017 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
19020 * cs-parser.jay (element_access): Implement action.
19021 (base_access): Implement actions.
19022 (checked_expression, unchecked_expression): Implement.
19024 * cs-parser.jay (local_variable_type): Correct and implement.
19025 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
19027 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
19029 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
19030 name and the specifiers.
19032 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
19034 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
19035 making them all public ;-)
19037 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
19040 2001-09-07 Miguel de Icaza <miguel@ximian.com>
19042 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
19044 (FieldExpr, PropertyExprs): New resolved expressions.
19045 (SimpleName::MemberStaticCheck): Perform static checks for access
19046 to non-static fields on static methods. Maybe this should be
19047 generalized for MemberAccesses.
19048 (SimpleName::ResolveSimpleName): More work on simple name
19051 * cs-parser.jay (primary_expression/qualified_identifier): track
19052 the parameter index.
19054 * codegen.cs (CodeGen::Save): Catch save exception, report error.
19055 (EmitContext::EmitBoolExpression): Chain to expression generation
19056 instead of temporary hack.
19057 (::EmitStatementExpression): Put generic expression code generation.
19059 * assign.cs (Assign::Emit): Implement variable assignments to
19060 local variables, parameters and fields.
19062 2001-09-06 Miguel de Icaza <miguel@ximian.com>
19064 * statement.cs (Block::GetVariableInfo): New method, returns the
19065 VariableInfo for a variable name in a block.
19066 (Block::GetVariableType): Implement in terms of GetVariableInfo
19068 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
19069 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
19071 2001-09-06 Ravi Pratap <ravi@ximian.com>
19073 * cs-parser.jay (operator_declaration): Continue on my quest : update
19074 to take attributes argument.
19075 (event_declaration): Ditto.
19076 (enum_declaration): Ditto.
19077 (indexer_declaration): Ditto.
19079 * class.cs (Operator::Operator): Update constructor accordingly.
19080 (Event::Event): Ditto.
19082 * delegate.cs (Delegate::Delegate): Same here.
19084 * enum.cs (Enum::Enum): Same here.
19086 2001-09-05 Ravi Pratap <ravi@ximian.com>
19088 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
19090 * ../tests/cs0658.cs : New file to demonstrate error 0658.
19092 * attribute.cs (Attributes): New class to encapsulate all attributes which were
19093 being passed around as an arraylist.
19094 (Attributes::AddAttribute): Method to add attribute sections.
19096 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
19097 (struct_declaration): Update accordingly.
19098 (constant_declaration): Update.
19099 (field_declaration): Update.
19100 (method_header): Update.
19101 (fixed_parameter): Update.
19102 (parameter_array): Ditto.
19103 (property_declaration): Ditto.
19104 (destructor_declaration): Ditto.
19106 * class.cs (Struct::Struct): Update constructors accordingly.
19107 (Class::Class): Ditto.
19108 (Field::Field): Ditto.
19109 (Method::Method): Ditto.
19110 (Property::Property): Ditto.
19111 (TypeContainer::OptAttribute): update property's return type.
19113 * interface.cs (Interface.opt_attributes): New member.
19114 (Interface::Interface): Update to take the extra Attributes argument.
19116 * parameter.cs (Parameter::Parameter): Ditto.
19118 * constant.cs (Constant::Constant): Ditto.
19120 * interface.cs (InterfaceMemberBase): New OptAttributes field.
19121 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
19122 the attributes as a parameter.
19123 (InterfaceProperty): Update constructor call.
19124 (InterfaceEvent): Ditto.
19125 (InterfaceMethod): Ditto.
19126 (InterfaceIndexer): Ditto.
19128 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
19129 pass the attributes too.
19130 (interface_event_declaration): Ditto.
19131 (interface_property_declaration): Ditto.
19132 (interface_method_declaration): Ditto.
19133 (interface_declaration): Ditto.
19135 2001-09-05 Miguel de Icaza <miguel@ximian.com>
19137 * class.cs (Method::Define): Track the "static Main" definition to
19138 create an entry point.
19140 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
19141 EntryPoint if we find it.
19143 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
19144 (EmitContext::ig): Make this variable public.
19146 * driver.cs: Make the default output file be the first file name
19147 with the .exe extension.
19149 Detect empty compilations
19151 Handle various kinds of output targets. Handle --target and
19152 rename -t to --dumper.
19154 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
19155 methods inherited from Expression return now an Expression. This
19156 will is used during the tree rewriting as we resolve them during
19159 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
19160 the spec. Missing entirely is the information about
19161 accessability of elements of it.
19163 (Expression::ExprClassFromMemberInfo): New constructor for
19164 Expressions that creates a fully initialized Expression based on
19165 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
19168 (Invocation::Resolve): Begin implementing resolution of invocations.
19170 * literal.cs (StringLiteral): Implement Emit.
19172 2001-09-05 Ravi Pratap <ravi@ximian.com>
19174 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
19177 2001-09-04 Ravi Pratap <ravi@ximian.com>
19179 * cs-parser.jay (attribute_arguments): Implement actions.
19180 (attribute): Fix bug in production. Implement action.
19181 (attribute_list): Implement.
19182 (attribute_target): Implement.
19183 (attribute_target_specifier, opt_target_specifier): Implement
19184 (CheckAttributeTarget): New method to check if the attribute target
19186 (attribute_section): Implement.
19187 (opt_attributes): Implement.
19189 * attribute.cs : New file to handle attributes.
19190 (Attribute): Class to hold attribute info.
19192 * cs-parser.jay (opt_attribute_target_specifier): Remove production
19193 (attribute_section): Modify production to use 2 different rules to
19194 achieve the same thing. 1 s/r conflict down !
19195 Clean out commented, useless, non-reducing dimension_separator rules.
19197 * class.cs (TypeContainer.attributes): New member to hold list
19198 of attributes for a type.
19199 (Struct::Struct): Modify to take one more argument, the attribute list.
19200 (Class::Class): Ditto.
19201 (Field::Field): Ditto.
19202 (Method::Method): Ditto.
19203 (Property::Property): Ditto.
19205 * cs-parser.jay (struct_declaration): Update constructor call to
19206 pass in the attributes too.
19207 (class_declaration): Ditto.
19208 (constant_declaration): Ditto.
19209 (field_declaration): Ditto.
19210 (method_header): Ditto.
19211 (fixed_parameter): Ditto.
19212 (parameter_array): Ditto.
19213 (property_declaration): Ditto.
19215 * constant.cs (Constant::Constant): Update constructor similarly.
19216 Use System.Collections.
19218 * parameter.cs (Parameter::Parameter): Update as above.
19220 2001-09-02 Ravi Pratap <ravi@ximian.com>
19222 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
19223 (TypeContainer.delegates): New member to hold list of delegates.
19225 * cs-parser.jay (delegate_declaration): Implement the action correctly
19226 this time as I seem to be on crack ;-)
19228 2001-09-02 Miguel de Icaza <miguel@ximian.com>
19230 * rootcontext.cs (RootContext::IsNamespace): new function, used to
19231 tell whether an identifier represents a namespace.
19233 * expression.cs (NamespaceExpr): A namespace expression, used only
19234 temporarly during expression resolution.
19235 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
19236 utility functions to resolve names on expressions.
19238 2001-09-01 Miguel de Icaza <miguel@ximian.com>
19240 * codegen.cs: Add hook for StatementExpressions.
19242 * class.cs: Fix inverted test for static flag in methods.
19244 2001-09-02 Ravi Pratap <ravi@ximian.com>
19246 * class.cs (Operator::CheckUnaryOperator): Correct error number used
19247 to make it coincide with MS' number.
19248 (Operator::CheckBinaryOperator): Ditto.
19250 * ../errors/errors.txt : Remove error numbers added earlier.
19252 * ../errors/cs1019.cs : Test case for error # 1019
19254 * ../errros/cs1020.cs : Test case for error # 1020
19256 * cs-parser.jay : Clean out commented cruft.
19257 (dimension_separators, dimension_separator): Comment out. Ostensibly not
19258 used anywhere - non-reducing rule.
19259 (namespace_declarations): Non-reducing rule - comment out.
19261 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
19262 with TypeContainer::AddEnum.
19264 * delegate.cs : New file for delegate handling classes.
19265 (Delegate): Class for declaring delegates.
19267 * makefile : Update.
19269 * cs-parser.jay (delegate_declaration): Implement.
19271 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
19273 * class.cs (Event::Define): Implement.
19274 (Event.EventBuilder): New member.
19276 * class.cs (TypeContainer::Populate): Update to define all enums and events
19278 (Events): New property for the events arraylist we hold. Shouldn't we move to using
19279 readonly fields for all these cases ?
19281 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
19283 * class.cs (Property): Revamp to use the convention of making fields readonly.
19284 Accordingly modify code elsewhere.
19286 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
19287 the Define method of the Property class.
19289 * class.cs : Clean up applied patch and update references to variables etc. Fix
19291 (TypeContainer::Populate): Update to define all the properties we have. Also
19292 define all enumerations.
19294 * enum.cs (Define): Implement.
19296 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
19298 * cs-parser.jay (overloadable_operator): The semantic value is an
19299 enum of the Operator class.
19300 (operator_declarator): Implement actions.
19301 (operator_declaration): Implement.
19303 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
19304 validity of definitions.
19305 (Operator::CheckBinaryOperator): Static method to check for binary operators
19306 (TypeContainer::AddOperator): New method to add an operator to a type.
19308 * cs-parser.jay (indexer_declaration): Added line to actually call the
19309 AddIndexer method so it gets added ;-)
19311 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
19312 already taken care of by the MS compiler ?
19314 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
19316 * class.cs (Operator): New class for operator declarations.
19317 (Operator::OpType): Enum for the various operators.
19319 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
19321 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
19322 ostensibly handle this in semantic analysis.
19324 * cs-parser.jay (general_catch_clause): Comment out
19325 (specific_catch_clauses, specific_catch_clause): Ditto.
19326 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
19327 (catch_args, opt_catch_args): New productions.
19328 (catch_clause): Rewrite to use the new productions above
19329 (catch_clauses): Modify accordingly.
19330 (opt_catch_clauses): New production to use in try_statement
19331 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
19332 and re-write the code in the actions to extract the specific and
19333 general catch clauses by being a little smart ;-)
19335 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
19336 Hooray, try and catch statements parse fine !
19338 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
19340 * statement.cs (Block::GetVariableType): Fix logic to extract the type
19341 string from the hashtable of variables.
19343 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
19344 I end up making that mistake ;-)
19345 (catch_clauses): Fixed gross error which made Key and Value of the
19346 DictionaryEntry the same : $1 !!
19348 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
19350 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
19352 * cs-parser.jay (event_declaration): Correct to remove the semicolon
19353 when the add and remove accessors are specified.
19355 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
19357 * cs-parser.jay (IndexerDeclaration): New helper class to hold
19358 information about indexer_declarator.
19359 (indexer_declarator): Implement actions.
19360 (parsing_indexer): New local boolean used to keep track of whether
19361 we are parsing indexers or properties. This is necessary because
19362 implicit_parameters come into picture even for the get accessor in the
19363 case of an indexer.
19364 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
19366 * class.cs (Indexer): New class for indexer declarations.
19367 (TypeContainer::AddIndexer): New method to add an indexer to a type.
19368 (TypeContainer::indexers): New member to hold list of indexers for the
19371 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
19373 * cs-parser.jay (add_accessor_declaration): Implement action.
19374 (remove_accessor_declaration): Implement action.
19375 (event_accessors_declaration): Implement
19376 (variable_declarators): swap statements for first rule - trivial.
19378 * class.cs (Event): New class to hold information about event
19380 (TypeContainer::AddEvent): New method to add an event to a type
19381 (TypeContainer::events): New member to hold list of events.
19383 * cs-parser.jay (event_declaration): Implement actions.
19385 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
19387 * cs-parser.jay (dim_separators): Implement. Make it a string
19388 concatenating all the commas together, just as they appear.
19389 (opt_dim_separators): Modify accordingly
19390 (rank_specifiers): Update accordingly. Basically do the same
19391 thing - instead, collect the brackets here.
19392 (opt_rank_sepcifiers): Modify accordingly.
19393 (array_type): Modify to actually return the complete type string
19394 instead of ignoring the rank_specifiers.
19395 (expression_list): Implement to collect the expressions
19396 (variable_initializer): Implement. We make it a list of expressions
19397 essentially so that we can handle the array_initializer case neatly too.
19398 (variable_initializer_list): Implement.
19399 (array_initializer): Make it a list of variable_initializers
19400 (opt_array_initializer): Modify accordingly.
19402 * expression.cs (New::NType): Add enumeration to help us
19403 keep track of whether we have an object/delegate creation
19404 or an array creation.
19405 (New:NewType, New::Rank, New::Indices, New::Initializers): New
19406 members to hold data about array creation.
19407 (New:New): Modify to update NewType
19408 (New:New): New Overloaded contructor for the array creation
19411 * cs-parser.jay (array_creation_expression): Implement to call
19412 the overloaded New constructor.
19414 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
19416 * class.cs (TypeContainer::Constructors): Return member
19417 constructors instead of returning null.
19419 2001-08-26 Miguel de Icaza <miguel@ximian.com>
19421 * typemanager.cs (InitCoreTypes): Initialize the various core
19422 types after we have populated the type manager with the user
19423 defined types (this distinction will be important later while
19424 compiling corlib.dll)
19426 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
19427 on Expression Classification. Now all expressions have a method
19428 `Resolve' and a method `Emit'.
19430 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
19431 generation from working. Also add some temporary debugging
19434 2001-08-24 Miguel de Icaza <miguel@ximian.com>
19436 * codegen.cs: Lots of code generation pieces. This is only the
19437 beginning, will continue tomorrow with more touches of polish. We
19438 handle the fundamentals of if, while, do, for, return. Others are
19439 trickier and I need to start working on invocations soon.
19441 * gen-treedump.cs: Bug fix, use s.Increment here instead of
19444 * codegen.cs (EmitContext): New struct, used during code
19445 emission to keep a context. Most of the code generation will be
19448 * cs-parser.jay: Add embedded blocks to the list of statements of
19449 this block. So code generation proceeds in a top down fashion.
19451 2001-08-23 Miguel de Icaza <miguel@ximian.com>
19453 * statement.cs: Add support for multiple child blocks.
19455 2001-08-22 Miguel de Icaza <miguel@ximian.com>
19457 * codegen.cs (EmitCode): New function, will emit the code for a
19458 Block of code given a TypeContainer and its ILGenerator.
19460 * statement.cs (Block): Standard public readonly optimization.
19461 (Block::Block constructors): Link children.
19462 (Block::Child): Child Linker.
19463 (Block::EmitVariables): Emits IL variable declarations.
19465 * class.cs: Drop support for MethodGroups here, delay until
19467 (Method::): Applied the same simplification that I did before, and
19468 move from Properties to public readonly fields.
19469 (Method::ParameterTypes): Returns the parameter types for the
19470 function, and implements a cache that will be useful later when I
19471 do error checking and the semantic analysis on the methods is
19473 (Constructor::GetCallingConvention): Renamed from CallingConvetion
19474 and made a method, optional argument tells whether this is a class
19475 or a structure to apply the `has-this' bit.
19476 (Method::GetCallingConvention): Implement, returns the calling
19478 (Method::Define): Defines the type, a second pass is performed
19479 later to populate the methods.
19481 (Constructor::ParameterTypes): implement a cache similar to the
19482 one on Method::ParameterTypes, useful later when we do semantic
19485 (TypeContainer::EmitMethod): New method. Emits methods.
19487 * expression.cs: Removed MethodGroup class from here.
19489 * parameter.cs (Parameters::GetCallingConvention): new method.
19491 2001-08-21 Miguel de Icaza <miguel@ximian.com>
19493 * class.cs (TypeContainer::Populate): Drop RootContext from the
19496 (Constructor::CallingConvention): Returns the calling convention.
19497 (Constructor::ParameterTypes): Returns the constructor parameter
19500 (TypeContainer::AddConstructor): Keep track of default constructor
19501 and the default static constructor.
19503 (Constructor::) Another class that starts using `public readonly'
19504 instead of properties.
19506 (Constructor::IsDefault): Whether this is a default constructor.
19508 (Field::) use readonly public fields instead of properties also.
19510 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
19511 track of static constructors; If none is used, turn on
19512 BeforeFieldInit in the TypeAttributes.
19514 * cs-parser.jay (opt_argument_list): now the return can be null
19515 for the cases where there are no arguments.
19517 (constructor_declarator): If there is no implicit `base' or
19518 `this', then invoke the default parent constructor.
19520 * modifiers.cs (MethodAttr): New static function maps a set of
19521 modifiers flags into a MethodAttributes enum
19522 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
19523 MethodAttr, TypeAttr to represent the various mappings where the
19524 modifiers are used.
19525 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
19527 2001-08-19 Miguel de Icaza <miguel@ximian.com>
19529 * parameter.cs (GetParameterInfo): Fix bug where there would be no
19532 * interface.cs (PopulateIndexer): Implemented the code generator
19533 for interface indexers.
19535 2001-08-17 Miguel de Icaza <miguel@ximian.com>
19537 * interface.cs (InterfaceMemberBase): Now we track the new status
19540 (PopulateProperty): Implement property population. Woohoo! Got
19541 Methods and Properties going today.
19543 Removed all the properties for interfaces, and replaced them with
19544 `public readonly' fields.
19546 2001-08-16 Miguel de Icaza <miguel@ximian.com>
19548 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
19549 initialize their hashtables/arraylists only when they are needed
19550 instead of doing this always.
19552 * parameter.cs: Handle refs and out parameters.
19554 * cs-parser.jay: Use an ArrayList to construct the arguments
19555 instead of the ParameterCollection, and then cast that to a
19558 * parameter.cs: Drop the use of ParameterCollection and use
19559 instead arrays of Parameters.
19561 (GetParameterInfo): Use the Type, not the Name when resolving
19564 2001-08-13 Miguel de Icaza <miguel@ximian.com>
19566 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
19567 and instead use public readonly fields.
19569 * class.cs: Put back walking code for type containers.
19571 2001-08-11 Miguel de Icaza <miguel@ximian.com>
19573 * class.cs (MakeConstant): Code to define constants.
19575 * rootcontext.cs (LookupType): New function. Used to locate types
19578 2001-08-08 Miguel de Icaza <miguel@ximian.com>
19580 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
19581 this System.Reflection code is. Kudos to Microsoft
19583 * typemanager.cs: Implement a type cache and avoid loading all
19584 types at boot time. Wrap in LookupType the internals. This made
19585 the compiler so much faster. Wow. I rule!
19587 * driver.cs: Make sure we always load mscorlib first (for
19588 debugging purposes, nothing really important).
19590 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
19591 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
19593 * rootcontext.cs: Lookup types on their namespace; Lookup types
19594 on namespaces that have been imported using the `using' keyword.
19596 * class.cs (TypeContainer::TypeAttr): Virtualize.
19597 (Class::TypeAttr): Return attributes suitable for this bad boy.
19598 (Struct::TypeAttr): ditto.
19599 Handle nested classes.
19600 (TypeContainer::) Remove all the type visiting code, it is now
19601 replaced with the rootcontext.cs code
19603 * rootcontext.cs (GetClassBases): Added support for structs.
19605 2001-08-06 Miguel de Icaza <miguel@ximian.com>
19607 * interface.cs, statement.cs, class.cs, parameter.cs,
19608 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
19609 Drop use of TypeRefs, and use strings instead.
19611 2001-08-04 Miguel de Icaza <miguel@ximian.com>
19615 * class.cs (Struct::Struct): set the SEALED flags after
19616 checking the modifiers.
19617 (TypeContainer::TypeAttr): new property, returns the
19618 TypeAttributes for a class.
19620 * cs-parser.jay (type_list): Oops, list production was creating a
19621 new list of base types.
19623 * rootcontext.cs (StdLib): New property.
19624 (GetInterfaceTypeByName): returns an interface by type name, and
19625 encapsulates error handling here.
19626 (GetInterfaces): simplified.
19627 (ResolveTree): Encapsulated all the tree resolution here.
19628 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
19631 * driver.cs: Add support for --nostdlib, to avoid loading the
19632 default assemblies.
19633 (Main): Do not put tree resolution here.
19635 * rootcontext.cs: Beginning of the class resolution.
19637 2001-08-03 Miguel de Icaza <miguel@ximian.com>
19639 * rootcontext.cs: Provide better error reporting.
19641 * cs-parser.jay (interface_base): set our $$ to be interfaces.
19643 * rootcontext.cs (CreateInterface): Handle the case where there
19644 are no parent interfaces.
19646 (CloseTypes): Routine to flush types at the end.
19647 (CreateInterface): Track types.
19648 (GetInterfaces): Returns an array of Types from the list of
19649 defined interfaces.
19651 * typemanager.c (AddUserType): Mechanism to track user types (puts
19652 the type on the global type hash, and allows us to close it at the
19655 2001-08-02 Miguel de Icaza <miguel@ximian.com>
19657 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
19658 RecordInterface instead.
19660 * cs-parser.jay: Updated to reflect changes above.
19662 * decl.cs (Definition): Keep track of the TypeBuilder type that
19663 represents this type here. Not sure we will use it in the long
19664 run, but wont hurt for now.
19666 * driver.cs: Smaller changes to accomodate the new code.
19668 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
19671 * rootcontext.cs (CreateInterface): New method, used to create
19672 the System.TypeBuilder type for interfaces.
19673 (ResolveInterfaces): new entry point to resolve the interface
19675 (CodeGen): Property, used to keep track of the code generator.
19677 2001-07-26 Miguel de Icaza <miguel@ximian.com>
19679 * cs-parser.jay: Add a second production for delegate_declaration
19682 (enum_body): Put an opt_comma here instead of putting it on
19683 enum_body or enum_member_declarations so we can handle trailing
19684 commas on enumeration members. Gets rid of a shift/reduce.
19686 (type_list): Need a COMMA in the middle.
19688 (indexer_declaration): Tell tokenizer to recognize get/set
19690 * Remove old targets.
19692 * Re-add the parser target.
19694 2001-07-13 Simon Cozens <simon@simon-cozens.org>
19696 * cs-parser.jay: Add precendence rules for a number of operators
19697 ot reduce the number of shift/reduce conflicts in the grammar.
19699 2001-07-17 Miguel de Icaza <miguel@ximian.com>
19701 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
19704 Get rid of old crufty code.
19706 * rootcontext.cs: Use this to keep track of the parsed
19707 representation and the defined types available to the program.
19709 * gen-treedump.cs: adjust for new convention.
19711 * type.cs: Split out the type manager, and the assembly builder
19714 * typemanager.cs: the type manager will live here now.
19716 * cil-codegen.cs: And the code generator here.
19718 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
19720 * makefile: Fixed up for easy making.
19722 2001-07-13 Simon Cozens <simon@simon-cozens.org>
19724 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
19727 (unary_expression): Expand pre_increment_expression and
19728 post_decrement_expression to reduce a shift/reduce.
19730 2001-07-11 Simon Cozens
19732 * cs-tokenizer.cs: Hex numbers should begin with a 0.
19734 Improve allow_keyword_as_indent name.
19736 2001-06-19 Miguel de Icaza <miguel@ximian.com>
19738 * Adjustments for Beta2.
19740 2001-06-13 Miguel de Icaza <miguel@ximian.com>
19742 * decl.cs: Added `Define' abstract method.
19743 (InTransit): new property, used to catch recursive definitions.
19745 * interface.cs: Implement `Define'.
19747 * modifiers.cs: Map Modifiers.constants to
19748 System.Reflection.TypeAttribute flags.
19750 * class.cs: Keep track of types and user-defined types.
19751 (BuilderInit): New method for creating an assembly
19752 (ResolveType): New function to launch the resolution process, only
19753 used by interfaces for now.
19755 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
19756 that are inserted into the name space.
19758 2001-06-08 Miguel de Icaza <miguel@ximian.com>
19760 * ARGH. I have screwed up my tree so many times due to the use of
19761 rsync rather than using CVS. Going to fix this at once.
19763 * driver.cs: Objetify driver. Load assemblies, use assemblies to
19766 2001-06-07 Miguel de Icaza <miguel@ximian.com>
19768 * Experiment successful: Use System.Type rather that our own
19771 2001-05-25 Miguel de Icaza <miguel@ximian.com>
19773 * cs-parser.jay: Removed nsAliases from here.
19775 Use new namespaces, handle `using XXX;'
19777 * namespace.cs: Reimplemented namespace handling, use a recursive
19778 definition of the class. Now we can keep track of using clauses
19779 and catch invalid using clauses.
19781 2001-05-24 Miguel de Icaza <miguel@ximian.com>
19783 * gen-treedump.cs: Adapted for all the renaming.
19785 * expression.cs (Expression): this class now has a Type property
19786 which returns an expression Type.
19788 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
19789 `Type', as this has a different meaning now in the base
19791 2001-05-22 Miguel de Icaza <miguel@ximian.com>
19793 * interface.cs, class.cs: Removed from all the sources the
19794 references to signature computation, as we can not do method
19795 signature computation during the parsing time, as we are not
19796 trying to solve at that point distinguishing:
19800 void a (NS.Blah x) {}
19803 Which depending on the context might be valid or not, as we do not
19804 know if Blah is the same thing as NS.Blah at that point.
19806 * Redid everything so the code uses TypeRefs now instead of
19807 Types. TypeRefs are just temporary type placeholders, that need
19808 to be resolved. They initially have a pointer to a string and the
19809 current scope in which they are used. This is used later by the
19810 compiler to resolve the reference to an actual Type.
19812 * DeclSpace is no longer a CIR.Type, and neither are
19813 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
19814 are all DeclSpaces, but no Types.
19816 * type.cs (TypeRefManager): This implements the TypeRef manager,
19817 which keeps track of all the types that need to be resolved after
19818 the parsing has finished.
19820 2001-05-13 Miguel de Icaza <miguel@ximian.com>
19822 * ARGH. We are going to have to store `foreach' as a class rather
19823 than resolving it, as we need to verify error 1579 after name
19824 resolution. *OR* we could keep a flag that says `This request to
19825 IEnumerator comes from a foreach statement' which we can then use
19826 to generate the error.
19828 2001-05-10 Miguel de Icaza <miguel@ximian.com>
19830 * class.cs (TypeContainer.AddMethod): we now add methods to the
19831 MethodGroup instead of the method hashtable.
19833 * expression.cs: Add MethodGroup abstraction, which gets us one
19834 step closer to the specification in the way we handle method
19837 * cs-parser.jay (primary_expression): qualified_identifier now
19838 tried to match up an identifier to a local variable reference or
19839 to a parameter reference.
19841 current_local_parameters is now a parser global variable that
19842 points to the current parameters for the block, used during name
19845 (property_declaration): Now creates an implicit `value' argument to
19848 2001-05-09 Miguel de Icaza <miguel@ximian.com>
19850 * parameter.cs: Do not use `param' arguments as part of the
19851 signature, per the spec.
19853 2001-05-08 Miguel de Icaza <miguel@ximian.com>
19855 * decl.cs: Base class for classes, structs and interfaces. This
19856 is the "Declaration Space"
19858 * cs-parser.jay: Use CheckDef for checking declaration errors
19859 instead of having one on each function.
19861 * class.cs: Factor out some code for handling error handling in
19862 accordance to the "Declarations" section in the "Basic Concepts"
19863 chapter in the ECMA C# spec.
19865 * interface.cs: Make all interface member classes derive from
19866 InterfaceMemberBase.
19868 2001-05-07 Miguel de Icaza <miguel@ximian.com>
19870 * Many things: all interfaces are parsed and generated in
19871 gen-treedump. Support for member variables, constructors,
19872 destructors, properties, constants is there.
19874 Beginning of the IL backend, but very little done, just there for
19877 2001-04-29 Miguel de Icaza <miguel@ximian.com>
19879 * cs-parser.jay: Fix labeled statement.
19881 * cs-tokenizer.cs (escape): Escape " and ' always.
19882 ref_line, ref_name: keep track of the line/filename as instructed
19883 by #line by the compiler.
19886 2001-04-27 Miguel de Icaza <miguel@ximian.com>
19888 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
19889 to match the values in System.CodeDOM.
19891 Divid renamed to Divide.
19893 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
19895 (Statements.set): remove.
19897 * System.CodeDOM/CodeCatchClause.cs: always have a valid
19900 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
19901 falseStatements always have valid values.
19903 * cs-parser.jay: Use System.CodeDOM now.